id
int64 393k
2.82B
| repo
stringclasses 68
values | title
stringlengths 1
936
| body
stringlengths 0
256k
⌀ | labels
stringlengths 2
508
| priority
stringclasses 3
values | severity
stringclasses 3
values |
|---|---|---|---|---|---|---|
573,885,971 | godot | C# Creating arrayMesh with indices gives ERR_INVALID_PARAMETER error | **Godot version:**
3.1.1-stable-mono_win64
**OS/device including version:**
Windows 7 SP1
**Issue description:**
When trying to create an arrayMesh in C# with indices i get
> E 0:00:02:0247 Condition ' p_arrays[ai].get_type() != Variant::POOL_INT_ARRAY ' is true. returned: ERR_INVALID_PARAMETER servers/visual_server.cpp:709 @ _surface_set_data() :0 @ void Godot.NativeCalls.godot_icall_4_141(IntPtr , IntPtr , Int32 , IntPtr , IntPtr , Int32 )() ArrayMesh.cs:245 @ void Godot.ArrayMesh.AddSurfaceFromArrays(Godot.Mesh+PrimitiveType , Godot.Collections.Array , Godot.Collections.Array , Int32 )() HexMesh.cs:37 @ void HexMesh._Ready()()
and
> E 0:00:02:0251 Invalid array format for surface servers/visual_server.cpp:1154 @ mesh_add_surface_from_arrays() :0 @ void Godot.NativeCalls.godot_icall_4_141(IntPtr , IntPtr , Int32 , IntPtr , IntPtr , Int32 )() ArrayMesh.cs:245 @ void Godot.ArrayMesh.AddSurfaceFromArrays(Godot.Mesh+PrimitiveType , Godot.Collections.Array , Godot.Collections.Array , Int32 )() HexMesh.cs:37 @ void HexMesh._Ready()()
Even though the array in question has type int.
**Steps to reproduce:**
```cs
Vector2 center = new Vector2(30,30);
Vector2 dir = new Vector2(10, 0);
Array<Vector2> vectors = new Array<Vector2>();
Array<int> indices = new Array<int>();
for(int i = 0; i < 3; i++){
vectors.Add(center + dir.Rotated(Mathf.Deg2Rad(60 * i)));
}
indices.Add(0);
indices.Add(1);
indices.Add(2);
hexMesh = new ArrayMesh();
Godot.Collections.Array arrays = new Godot.Collections.Array();
arrays.Resize((int)ArrayMesh.ArrayType.Max);
arrays[(int)ArrayMesh.ArrayType.Vertex] = vectors;
arrays[(int)ArrayMesh.ArrayType.Index] = indices;
hexMesh.AddSurfaceFromArrays(Mesh.PrimitiveType.Triangles, arrays);
this.Mesh = hexMesh;
```
This is inside ready() method of script and script is attached to MeshIntance2D node.
**Minimal reproduction project:**
[HexMap.zip](https://github.com/godotengine/godot/files/4274931/HexMap.zip)
| discussion,topic:dotnet | low | Critical |
573,950,364 | TypeScript | Declaration emit should not inline type definitions | **TypeScript Version:** 3.8.3, 3.8.1, probably others
**Search Terms:**
declaration inlining, dts inlining, declaration inline, inline literal, declaration literal
**Code**
```ts
// parent.ts
import { num, obj } from "./child"
export const reExportNum = num;
export const reExportObj = obj;
```
```ts
// child.d.ts
export declare const num: number;
export declare const obj: { a: 1 };
```
`tsc index.ts --declaration`
**Expected behavior:**
Declaration emit for `parent.ts` should not inline types.
```ts
// parent.d.ts
import { num, obj } from "./child"
export declare const reExportNum: typeof num;
export declare const reExportObj: typeof obj;
```
**Actual behavior:**
Today, declaration emit for `parent.ts` inlines the types **and** eliminates the import of the `child.d.ts` type definition.
```ts
// parent.d.ts
export declare const reExportNum: number;
export declare const reExportObj: {
a: 1;
};
```
This is a correctness issue, because consumers of `parent.d.ts` will not get the correct types if the types in `child.d.ts` change.
In practice, this is most likely to happen when `parent` and `child` are in separate packages, because they are published independently, i.e. an application uses `parent-package` which uses types from `child-package`. This is exacerbated by the current practice on npm of `parent-package` depending on an unpinned version, using `package.json` dependency syntax `"child-package": "*"`.
> This issue was co-authored with @robpalme | Needs Investigation | medium | Critical |
573,952,504 | youtube-dl | Site support request: audius.co | <!--
######################################################################
WARNING!
IGNORING THE FOLLOWING TEMPLATE WILL RESULT IN ISSUE CLOSED AS INCOMPLETE
######################################################################
-->
## Checklist
<!--
Carefully read and work through this check list in order to prevent the most common mistakes and misuse of youtube-dl:
- First of, make sure you are using the latest version of youtube-dl. Run `youtube-dl --version` and ensure your version is 2020.03.01. If it's not, see https://yt-dl.org/update on how to update. Issues with outdated version will be REJECTED.
- Make sure that all provided video/audio/playlist URLs (if any) are alive and playable in a browser.
- Make sure that site you are requesting is not dedicated to copyright infringement, see https://yt-dl.org/copyright-infringement. youtube-dl does not support such sites. In order for site support request to be accepted all provided example URLs should not violate any copyrights.
- Search the bugtracker for similar site support requests: http://yt-dl.org/search-issues. DO NOT post duplicates.
- Finally, put x into all relevant boxes (like this [x])
-->
- [x] I'm reporting a new site support request
- [x] I've verified that I'm running youtube-dl version **2020.03.01**
- [x] I've checked that all provided URLs are alive and playable in a browser
- [x] I've checked that none of provided URLs violate any copyrights
- [x] I've searched the bugtracker for similar site support requests including closed ones
## Example URLs
<!--
Provide all kinds of example URLs support for which should be included. Replace following example URLs by yours.
-->
- Single track: https://audius.co/laxcitymusic/delete-3337
- Artist page: https://audius.co/laxcitymusic
- Charts: https://audius.co/trending
## Description
<!--
Provide any additional information.
If work on your issue requires account credentials please provide them or explain how one can obtain them.
-->
Audius is a music streaming site.
https://audius.co
Tried the latest version but I only got unsupported url error.
Verbose log:
```
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['--ignore-config', '-v', 'https://audius.co/laxcitymusic/delete-3337']
[debug] Encodings: locale cp1252, fs mbcs, out cp850, pref cp1252
[debug] youtube-dl version 2020.03.01
[debug] Python version 3.4.4 (CPython) - Windows-10-10.0.18362
[debug] exe versions: ffmpeg 4.2.2, ffprobe 4.2.2
[debug] Proxy map: {}
[generic] delete-3337: Requesting header
WARNING: Falling back on generic information extractor.
[generic] delete-3337: Downloading webpage
[generic] delete-3337: Extracting information
ERROR: Unsupported URL: https://audius.co/laxcitymusic/delete-3337
Traceback (most recent call last):
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpavop71lg\build\youtube_dl\YoutubeDL.py", line 797, in extract_info
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpavop71lg\build\youtube_dl\extractor\common.py", line 530, in extract
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpavop71lg\build\youtube_dl\extractor\generic.py", line 3351, in _real_extract
youtube_dl.utils.UnsupportedError: Unsupported URL: https://audius.co/laxcitymusic/delete-3337
```
| site-support-request | low | Critical |
573,980,778 | vue | Swapping from functional to non-functional component using v-if does not change v-data-* attribute. | ### Version
2.6.11
### Reproduction link
[https://codesandbox.io/embed/heuristic-brown-u7rvw?fontsize=14&hidenavigation=1&theme=dark](https://codesandbox.io/embed/heuristic-brown-u7rvw?fontsize=14&hidenavigation=1&theme=dark)
### Steps to reproduce
Click the tick box.
### What is expected?
It should say "BLUE BOX" with a blue background colour.
### What is actually happening?
It says "BLUE BOX" with no background colour.
---
The issue stems from the data-v-* attribute not being re-set for the blue_block div when it is swapped to. It is still using the data-v-* attribute of the child div in the functional component. Thus the CSS class styling does not apply.
https://imgur.com/a/gukDePJ
Swapping from a functional component to something else is useful. E.g. When showing a simple loading bar component before swapping to a more complex component.
<!-- generated by vue-issues. DO NOT REMOVE --> | bug | low | Minor |
574,001,025 | godot | [Bullet] 3D: long (+300 m) collision shapes for static bodies resulting in strange behaviour | **Godot version:**
3.2 stable official
**OS/device including version:**
Windows 10 Home
**Issue description:**
In 3D, when making large or long collision shapes for static bodies, strange behaviour occurs, if a rigid body rolls or pass on it.
Setting the collision shape for a static body, and setting the collision shape extent (using the 3D gizmo or setting the EXTENT property in the editor) to 150 or more (resulting in a collision shape with 300 m length), rotating it to make an inclined plane, and placing a rigid body with a collision shape like a sphere on it, and letting it roll, results in the sphere bouncing or stopping abruptly at some point.
Sometimes the sphere just doesn't move anymore, sometimes it rotates in other directions, like it was deflecting something.
Another aspect, is that if the static body is placed in another place, the rigid body movement changes.
The example I've attached uses a sphere, but I've noticed it with a car I'm making, using cylinders (rigid bodies) as wheels. The car stopped or deflected, like the sphere in this example does. So it is not restricted to one collision shape.
EDIT: It looks like the problem is the ratio between at least two of the axis. If extent in X is set to 150 and, Y and Z are 1, the strange behaviour occurs. If the extent in Z is set to 10, no problem occurs.
Also, it looks like the ratio is not fixed, it depends on size. Changing to 300 in one axis, and 10 in another, still resulted in problems. Changing to 300 and 30, evertything was fine.
**Steps to reproduce:**
1. Add a static body
2. Add a collision shape to it, and set shape to BOX
3. Set extents to 150, in X for example
4. Rotate it, to make it an inclined plane, so that you can drop a rigid body, like a sphere on it
5. Add a rigid body, add a collision shape to it, set shape to SPHERE
6. Place the sphere rigid body on the static body
7. Run the game
8. Change the location of the static body, to see different rigid body behaviours
9. Change extent in Z axis to 10, to see no problem occurring
**Minimal reproduction project:**
[StaticBodyBug.zip](https://github.com/godotengine/godot/files/4275728/StaticBodyBug.zip)
I have also attached 2 videos showing the behaviour
[StaticBodyBug_video.zip](https://github.com/godotengine/godot/files/4275729/StaticBodyBug_video.zip)
https://user-images.githubusercontent.com/22160489/103038813-27a7b500-454e-11eb-9230-ee9c6502d404.mp4
https://user-images.githubusercontent.com/22160489/103038815-28d8e200-454e-11eb-838c-55a58c91665b.mp4
| bug,confirmed,topic:physics,topic:3d | low | Critical |
574,011,834 | pytorch | [docs] Unclear description of indices arg in torch.index_put_ | https://pytorch.org/docs/master/tensors.html#torch.Tensor.index_put_
`
Puts values from the tensor value into the tensor self using the indices specified in indices (which is a tuple of Tensors). The expression tensor.index_put_(indices, value) is equivalent to tensor[indices] = value
`
However if we follow the suggested link [indices](https://pytorch.org/docs/master/tensors.html#torch.Tensor.indices), it only explains something about sparse tensors: `If self is a sparse COO tensor (i.e., with torch.sparse_coo layout), this returns a view of the contained indices tensor. Otherwise, this throws an error.`
So this (the suggested indices link + phrasing "using the indices specified in indices" and the requirement to use a tuple of tensors) is a confusing reference when `index_put_` is to be used with dense tensors.
If the function is not normally expected to be used with dense tensors, a notice about that would be a great clarification.
```python
a = torch.rand(3)
a.index_put_((torch.tensor(-1), ), torch.tensor(0.0)) # notice a lot of wrapper torch.tensor calls and the required tuple
```
In the doc it mentions that the op is equivalent to `tensor[indices] = value`, so naturally I first tried the call `a.index_put_(-1, 0)` for zeroing out the last tensor element and it failed badly. | module: docs,triaged | low | Critical |
574,023,561 | go | cmd/compile: spurious "cannot use reflect.Kind(9) … as type uint64 in assignment" on darwin-amd64-race builder | [2020-03-01T21:02:40-e44cda3/darwin-amd64-race](https://build.golang.org/log/60b8a176634d0f45bf048c11aab56185d0a8d3a0)
```
# encoding/xml [encoding/xml.test]
/var/folders/9w/4l2_g3kx01x199n37fbmv3s80000gn/T/workdir-host-darwin-10_14/go/src/encoding/xml/marshal.go:849:62: cannot use reflect.Kind(9) (type reflect.Kind) as type uint64 in assignment
FAIL encoding/xml [build failed]
```
CC @randall77 @josharian | NeedsInvestigation,compiler/runtime | low | Critical |
574,025,886 | pytorch | pip --requirement installs incorrect CUDA version | ## Issue description
When installing PyTorch using pip with requirements file provided it installs PyTorch for CUDA 9.2 while when installed from command line it would install for CUDA 10.1.
[requirements.txt](https://github.com/pytorch/pytorch/files/4275930/requirements.txt)
INline:
```
torch==1.4.0
torchvision==0.5.0
```
## Code example
```
# Install PyTorch using attached requirements file.
python -m venv requirements
cd requirements
Scripts\activate
python -m pip install --upgrade pip
pip install -r requirements.txt -f https://download.pytorch.org/whl/torch_stable.html
pip freeze
...
torch==1.4.0+cu92
torchvision==0.5.0+cu92
```
On the other side if PyTorch is installed from command line.
```
# Install PyTorch from the command line.
python -m venv command_line
cd command_line
Scripts\activate
python -m pip install --upgrade pip
pip install torch===1.4.0 torchvision===0.5.0 -f https://download.pytorch.org/whl/torch_stable.html
pip freeze
...
torch==1.4.0
torchvision==0.5.0
```
## System Info
```
# For PyTorch installed from requirements file.
python collect_env.py
```
PyTorch version: 1.4.0+cu92
Is debug build: No
CUDA used to build PyTorch: 9.2
OS: Microsoft Windows 10 Enterprise
GCC version: Could not collect
CMake version: Could not collect
Python version: 3.6
Is CUDA available: Yes
CUDA runtime version: 10.1.243
GPU models and configuration: GPU 0: GeForce RTX 2070
Nvidia driver version: 441.87
cuDNN version: C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v10.1\bin\cudnn64_7.dll
Versions of relevant libraries:
[pip3] numpy==1.18.1
[pip3] torch==1.4.0+cu92
[pip3] torchvision==0.5.0+cu92
[conda] Could not collect
cc @ezyang | module: dependency bug,module: binaries,oncall: releng,triaged | low | Critical |
574,033,843 | go | go/types: SIGSEGV in (*Checker).exprInternal | ```
#!watchflakes
post <- log ~ `SIGSEGV(.*\n)*\ngoroutine \d+ \[.+\]:\n(\s*.+\n)*go/types\.\(\*Checker\)\.(?:rawExpr|exprInternal)`
```
[2020-03-01T21:04:30-a4f7b08/darwin-amd64-nocgo](https://build.golang.org/log/5bf8057cb3fef78574cf666b1c6c06198d423825)
<details>
```
go_test.go:2345: # strings_test
panic: runtime error: invalid memory address or nil pointer dereference [recovered]
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x20 pc=0x1215e20]
goroutine 1 [running]:
go/types.(*Checker).handleBailout(0xc000131680, 0xc00067f9f0)
/private/var/folders/9w/4l2_g3kx01x199n37fbmv3s80000gn/T/workdir-host-darwin-10_14/go/src/go/types/check.go:243 +0x98
panic(0x12fe680, 0x15c1cf0)
/private/var/folders/9w/4l2_g3kx01x199n37fbmv3s80000gn/T/workdir-host-darwin-10_14/go/src/runtime/panic.go:967 +0x15d
go/types.(*Checker).exprInternal(0xc000131680, 0xc0001c3d80, 0x0, 0x0, 0x0, 0x0, 0x30)
/private/var/folders/9w/4l2_g3kx01x199n37fbmv3s80000gn/T/workdir-host-darwin-10_14/go/src/go/types/expr.go:1526 +0x1980
go/types.(*Checker).rawExpr(0xc000131680, 0xc0001c3d80, 0x0, 0x0, 0x0, 0x0, 0x132b060)
/private/var/folders/9w/4l2_g3kx01x199n37fbmv3s80000gn/T/workdir-host-darwin-10_14/go/src/go/types/expr.go:987 +0x81
go/types.(*Checker).exprOrType(0xc000131680, 0xc0001c3d80, 0x0, 0x0)
/private/var/folders/9w/4l2_g3kx01x199n37fbmv3s80000gn/T/workdir-host-darwin-10_14/go/src/go/types/expr.go:1644 +0x55
go/types.(*Checker).call(0xc000131680, 0xc0001c3d80, 0xc00027f080, 0x4)
/private/var/folders/9w/4l2_g3kx01x199n37fbmv3s80000gn/T/workdir-host-darwin-10_14/go/src/go/types/call.go:15 +0x66
go/types.(*Checker).exprInternal(0xc000131680, 0xc0001c3d80, 0x13ce0c0, 0xc00027f080, 0x0, 0x0, 0x11fbb58)
/private/var/folders/9w/4l2_g3kx01x199n37fbmv3s80000gn/T/workdir-host-darwin-10_14/go/src/go/types/expr.go:1471 +0x1e61
go/types.(*Checker).rawExpr(0xc000131680, 0xc0001c3d80, 0x13ce0c0, 0xc00027f080, 0x0, 0x0, 0x1)
/private/var/folders/9w/4l2_g3kx01x199n37fbmv3s80000gn/T/workdir-host-darwin-10_14/go/src/go/types/expr.go:987 +0x81
go/types.(*Checker).multiExpr(0xc000131680, 0xc0001c3d80, 0x13ce0c0, 0xc00027f080)
/private/var/folders/9w/4l2_g3kx01x199n37fbmv3s80000gn/T/workdir-host-darwin-10_14/go/src/go/types/expr.go:1601 +0x58
go/types.(*Checker).expr(0xc000131680, 0xc0001c3d80, 0x13ce0c0, 0xc00027f080)
/private/var/folders/9w/4l2_g3kx01x199n37fbmv3s80000gn/T/workdir-host-darwin-10_14/go/src/go/types/expr.go:1595 +0x49
go/types.(*Checker).exprInternal(0xc000131680, 0xc0001c3d80, 0x13ce1c0, 0xc00027f140, 0x13cb340, 0xc0000dce60, 0x100bb95)
/private/var/folders/9w/4l2_g3kx01x199n37fbmv3s80000gn/T/workdir-host-darwin-10_14/go/src/go/types/expr.go:1145 +0x15be
go/types.(*Checker).rawExpr(0xc000131680, 0xc0001c3d80, 0x13ce1c0, 0xc00027f140, 0x13cb340, 0xc0000dce60, 0x100c438)
/private/var/folders/9w/4l2_g3kx01x199n37fbmv3s80000gn/T/workdir-host-darwin-10_14/go/src/go/types/expr.go:987 +0x81
go/types.(*Checker).exprWithHint(0xc000131680, 0xc0001c3d80, 0x13ce1c0, 0xc00027f140, 0x13cb340, 0xc0000dce60)
/private/var/folders/9w/4l2_g3kx01x199n37fbmv3s80000gn/T/workdir-host-darwin-10_14/go/src/go/types/expr.go:1623 +0x73
go/types.(*Checker).indexedElts(0xc000131680, 0xc000246c00, 0xf, 0x10, 0x13cb340, 0xc0000dce60, 0xffffffffffffffff, 0xd)
/private/var/folders/9w/4l2_g3kx01x199n37fbmv3s80000gn/T/workdir-host-darwin-10_14/go/src/go/types/expr.go:957 +0x1e2
go/types.(*Checker).exprInternal(0xc000131680, 0xc0001c3400, 0x13ce1c0, 0xc00027f440, 0x0, 0x0, 0x0)
/private/var/folders/9w/4l2_g3kx01x199n37fbmv3s80000gn/T/workdir-host-darwin-10_14/go/src/go/types/expr.go:1200 +0x584
go/types.(*Checker).rawExpr(0xc000131680, 0xc0001c3400, 0x13ce1c0, 0xc00027f440, 0x0, 0x0, 0x0)
/private/var/folders/9w/4l2_g3kx01x199n37fbmv3s80000gn/T/workdir-host-darwin-10_14/go/src/go/types/expr.go:987 +0x81
go/types.(*Checker).multiExpr(0xc000131680, 0xc0001c3400, 0x13ce1c0, 0xc00027f440)
/private/var/folders/9w/4l2_g3kx01x199n37fbmv3s80000gn/T/workdir-host-darwin-10_14/go/src/go/types/expr.go:1601 +0x58
go/types.(*Checker).expr(0xc000131680, 0xc0001c3400, 0x13ce1c0, 0xc00027f440)
/private/var/folders/9w/4l2_g3kx01x199n37fbmv3s80000gn/T/workdir-host-darwin-10_14/go/src/go/types/expr.go:1595 +0x49
go/types.(*Checker).varDecl(0xc000131680, 0xc000071220, 0xc00000f148, 0x1, 0x1, 0x0, 0x0, 0x13ce1c0, 0xc00027f440)
/private/var/folders/9w/4l2_g3kx01x199n37fbmv3s80000gn/T/workdir-host-darwin-10_14/go/src/go/types/decl.go:445 +0x187
go/types.(*Checker).objDecl(0xc000131680, 0x13d3ca0, 0xc000071220, 0x0)
/private/var/folders/9w/4l2_g3kx01x199n37fbmv3s80000gn/T/workdir-host-darwin-10_14/go/src/go/types/decl.go:189 +0x666
go/types.(*Checker).packageObjects(0xc000131680)
/private/var/folders/9w/4l2_g3kx01x199n37fbmv3s80000gn/T/workdir-host-darwin-10_14/go/src/go/types/resolver.go:570 +0x390
go/types.(*Checker).checkFiles(0xc000131680, 0xc00025fc00, 0x7, 0x8, 0x0, 0x0)
/private/var/folders/9w/4l2_g3kx01x199n37fbmv3s80000gn/T/workdir-host-darwin-10_14/go/src/go/types/check.go:257 +0xa3
go/types.(*Checker).Files(...)
/private/var/folders/9w/4l2_g3kx01x199n37fbmv3s80000gn/T/workdir-host-darwin-10_14/go/src/go/types/check.go:248
go/types.(*Config).Check(0xc000358ac0, 0xc00012abd0, 0xc, 0xc00019c880, 0xc00025fc00, 0x7, 0x8, 0xc00035c5a0, 0x0, 0x16, ...)
/private/var/folders/9w/4l2_g3kx01x199n37fbmv3s80000gn/T/workdir-host-darwin-10_14/go/src/go/types/api.go:348 +0x14e
cmd/vendor/golang.org/x/tools/go/analysis/unitchecker.run(0xc00019c880, 0xc000134c60, 0xc000164600, 0x15, 0x20, 0x2e746c7573, 0x13d4660, 0x12fed40, 0xc00012a81c, 0xc000143c10)
/private/var/folders/9w/4l2_g3kx01x199n37fbmv3s80000gn/T/workdir-host-darwin-10_14/go/src/cmd/vendor/golang.org/x/tools/go/analysis/unitchecker/unitchecker.go:235 +0x42a
cmd/vendor/golang.org/x/tools/go/analysis/unitchecker.Run(0x7ffeefbff749, 0x83, 0xc000164600, 0x15, 0x20)
/private/var/folders/9w/4l2_g3kx01x199n37fbmv3s80000gn/T/workdir-host-darwin-10_14/go/src/cmd/vendor/golang.org/x/tools/go/analysis/unitchecker/unitchecker.go:131 +0x113
cmd/vendor/golang.org/x/tools/go/analysis/unitchecker.Main(0xc000164600, 0x15, 0x20)
/private/var/folders/9w/4l2_g3kx01x199n37fbmv3s80000gn/T/workdir-host-darwin-10_14/go/src/cmd/vendor/golang.org/x/tools/go/analysis/unitchecker/unitchecker.go:118 +0x25f
main.main()
/private/var/folders/9w/4l2_g3kx01x199n37fbmv3s80000gn/T/workdir-host-darwin-10_14/go/src/cmd/vet/main.go:35 +0x2bd
go_test.go:2345: go [test -cover -short math strings] failed unexpectedly in /var/folders/9w/4l2_g3kx01x199n37fbmv3s80000gn/T/workdir-host-darwin-10_14/go/src/cmd/go: exit status 2
```
</details>
This may be related to #36605, although the failures reported for that issue are supposed to be fixed in 1.14 and at tip (https://github.com/golang/go/issues/36605#issuecomment-576924501).
CC @matloob @griesemer | NeedsInvestigation,compiler/runtime | medium | Critical |
574,036,791 | bitcoin | Make fee estimation mockable via RPC | Right now the only(?) test we have that exercises interesting fee estimation codepaths is `feature_estimate_fee.py`. For fee-bumping and other tests it would make sense to allow test authors to quickly construct fluctuating fee scenarios at will.
related: https://github.com/bitcoin/bitcoin/issues/18240 | Feature | low | Minor |
574,048,208 | go | x/build/maintner/maintnerd, x/build/maintner: changes are hard to review and test | This issue is to note that it is currently difficult and time-intensive to review changes to the maintner server. Changes to the server are risky and can cause crashes, or worse, incorrect data to be written. Many services depend on the maintner server being stable and correct.
It has some tests, but they're not enough to provide sufficient confidence. Manual testing is not easy. There isn't a staging instance that's actively used.
This issue is to track progress on making it easier and safer to make changes to maintner. It has known bugs that need to be resolved, and Gerrit and GitHub APIs may change, so not making any changes will not be viable indefinitely.
/cc @cagedmantis @toothrot | Builders,NeedsInvestigation | low | Critical |
574,053,077 | deno | Make `Deno.readDir` actually streaming | probably with async iterator | feat,cli | low | Major |
574,085,335 | TypeScript | types 'new (...args: any) => E' and wrapper types constructor for primitive types have no overlap | <!-- 🚨 STOP 🚨 𝗦𝗧𝗢𝗣 🚨 𝑺𝑻𝑶𝑷 🚨
Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Even if you think you've found a *bug*, please read the FAQ first, especially the Common "Bugs" That Aren't Bugs section!
Please help us by doing the following steps before logging an issue:
* Search: https://github.com/Microsoft/TypeScript/search?type=Issues
* Read the FAQ: https://github.com/Microsoft/TypeScript/wiki/FAQ
Please fill in the *entire* template below.
-->
<!--
Please try to reproduce the issue with the latest published version. It may have already been fixed.
For npm: `typescript@next`
This is also the 'Nightly' version in the playground: http://www.typescriptlang.org/play/?ts=Nightly
-->
**TypeScript Version:** 3.8.3
**Code**
```ts
class TreeSet<E> {
constructor(elementType: new(...args: any) => E) {
if (elementType === Number) { //This condition will always return 'false' since the types 'new (...args: any) => E' and 'NumberConstructor' have no overlap.(2367)
console.log("hello")
}
}
}
new TreeSet(Number)
```
**Actual behavior:**
The error is prompted at compile time "This condition will always return 'false' since the types 'new (...args: any) => E' and 'NumberConstructor' have no overlap.(2367)" but compiled code actually runs correctly.
**Playground Link:** <!-- A link to a TypeScript Playground "Share" link which demonstrates this behavior -->
https://www.typescriptlang.org/play/?ssl=9&ssc=20&pln=1&pc=1#code/MYGwhgzhAEAqBOBTRBlRAXAPAUQHzQG8AoaU6YAewDsJ14BXYdC+ACkREQFtEr1YAngAdEALmhVEAd1YA6eWHgBzCOLBUBASmgBefNm3Eyx6AEsAZtHacefQSN06d0AHL0uAI0TxDJE-8oaCk5ZEAolVgAiAAsOMMjNP38AXyToVNSiSSk4JFQMVjdPb00gA
| Bug | low | Critical |
574,119,126 | material-ui | [CSP] Issue with inline-style and Content Security Policy | According to the documentation, to support the CSP header, a nonce needs to be added to the style-src directive (https://mui.com/material-ui/guides/content-security-policy/). However, a number of Material-UI components make use of inline style attributes (e.g. Tabs - https://github.com/mui/material-ui/blob/5c96f3cad765c259d029321a8f7d2f57c9bcc36b/packages/mui-material/src/Tabs/Tabs.js#L768-L773). These require the 'unsafe-inline' source (or a hash for each style although this isn't practical). The 'unsafe-inline' source is ignored if a hash or nonce source is set, thus necessitating the removal of the nonce.
So generally for Material-UI as I see it, I think one of two things are needed:
1. Update the CSP documentation for a setup to allow inline style attribute setting (not a great CSP, but would make Material-UIs stance clear on styling then).
2. Set a standard of no inline style attribute setting and we fix them all as bugs.
What do you think? I did an issue search and found this (https://github.com/mui-org/material-ui/issues/13364) suggesting that Material-UI as a whole allows inline style attributes and thus are happy with necessitating a non strict CSP setting. Is this still the case and we're happy with what this means for CSP?
Related:
- https://github.com/radix-ui/primitives/issues/2057 | discussion,core | medium | Critical |
574,130,029 | pytorch | [C++ API Parity] Incorrect documentation for optim initialization in serialization docs | https://pytorch.org/cppdocs/api/function_namespacetorch_1a99dc9f736064b2179cc58e6436f7a021.html#exhale-function-namespacetorch-1a99dc9f736064b2179cc58e6436f7a021
https://pytorch.org/cppdocs/api/function_namespacetorch_1a4b369494adfb10b9a005aeb0bb6207cb.html#exhale-function-namespacetorch-1a4b369494adfb10b9a005aeb0bb6207cb
see issue: https://github.com/pytorch/pytorch/issues/33862#issuecomment-593518890
cc @yf225 @vincentqb | module: docs,module: cpp,module: optimizer,triaged | low | Minor |
574,142,687 | vscode | Awaiting Terminal processId never returns value on Windows | The PowerShell extension [creates a console using the `vscode.window.createTerminal` API](https://github.com/PowerShell/vscode-powershell/blob/3dff85b849f61b34776517e05fa02297342f6ecc/src/process.ts#L106-L111) and then [tries to log its PID with `terminal.processId`](https://github.com/PowerShell/vscode-powershell/blob/3dff85b849f61b34776517e05fa02297342f6ecc/src/process.ts#L131).
A simplified version of this startup might be something like:
```typescript
const pwshTerminal = vscode.window.createTerminal({
name: 'PowerShell Console',
shellPath: 'C:\\Program Files\\PowerShell\\7-preview\\pwsh.exe',
shellArgs: ['-NonInteractive', '-NoProfile'], // Options suppress things like PSReadLine, so simplify repro
hideFromUser: false});
pwshTerminal.processId.then((pid) => console.log(pid));
```
In https://github.com/PowerShell/vscode-powershell/pull/2482 I changed our `then()` call to an `async`/`await` version, like:
```typescript
const pwshTerminal = vscode.window.createTerminal({
name: 'PowerShell Console',
shellPath: 'C:\\Program Files\\PowerShell\\7-preview\\pwsh.exe',
shellArgs: ['-NonInteractive', '-NoProfile'], // Options suppress things like PSReadLine, so simplify repro
hideFromUser: false});
const pid = await pwshTerminal.processId;
console.log(pid);
```
This led to https://github.com/PowerShell/vscode-powershell/issues/2491, where the extension client would not progress past this await call (as discovered with log points).
As I say in https://github.com/PowerShell/vscode-powershell/issues/2491#issuecomment-593500969, I can reproduce this with the following change from https://github.com/PowerShell/vscode-powershell/commit/d431617d6997c75fdce35342323e016f1bbaf271:
```diff
diff --git a/src/process.ts b/src/process.ts
index aa957b5..b70966e 100644
--- a/src/process.ts
+++ b/src/process.ts
@@ -128,7 +128,9 @@ export class PowerShellProcess {
// Log that the PowerShell terminal process has been started
this.log.write("Registering terminal PID log callback");
- this.consoleTerminal.processId.then((pid) => this.logTerminalPid(pid, pwshName));
+ const pid = await this.consoleTerminal.processId;
+ this.logTerminalPid(pid, pwshName);
+ // this.consoleTerminal.processId.then((pid) => this.logTerminalPid(pid, pwshName));
return sessionDetails;
}
```
So startup pauses, since the client never opens a named pipe. Debugging the server shows it waiting on a named pipe connection.
In the client, pausing the debugger shows us stopped here:
Log points on each line showed us progressing through the startup code as expected until awaiting the `processId` value of the terminal, at which point we stopped progressing.
We worked around this issue https://github.com/PowerShell/vscode-powershell/pull/2498 by moving back to the `.then()` (I suspect there are startups where we never log the PID).
I've only seen this on Windows. My machine's OS version, where I've managed to reproduce:
```
OS Name: Microsoft Windows 10 Enterprise Insider Preview
OS Version: 10.0.19535 N/A Build 19535
```
This is running VSCode 1.43.0-insider (user setup). | bug,api,terminal-process | low | Critical |
574,142,822 | flutter | Add flutter upgrade --hotfix | Users may want to upgrade to the most recent hotfix, but wait on upgrading to the most recent stable. | c: new feature,tool,P3,team-tool,triaged-tool | low | Minor |
574,209,266 | material-ui | [ErrorBoundary] New ErrorBoundary Component | <!-- Provide a general summary of the feature in the Title above -->
This ticket is to track ideas/rationale for material-ui including an ErrorBoundary component.
I would like to contribute this component to material-ui, as described below.
- [x] I have searched the [issues](https://github.com/mui-org/material-ui/issues) of this repository and believe that this is not a duplicate.
## Summary 💡
[ErrorBoundaries](https://reactjs.org/docs/error-boundaries.html) are a React 16+ specific feature that uses the [componentDidCatch](https://reactjs.org/docs/react-component.html#componentdidcatch) API for handling uncaught errors without unmounting the whole React component tree.
This ticket exists to request feedback and ideas for a material-ui-provided ErrorBoundary component.
<!-- Describe how it should work. -->
## Examples 🌈
[The react-ui-roundup tracks ErrorBoundaries](https://github.com/dimitropoulos/react-ui-roundup#errorboundary), and it appears that there are just 3 implementations:
<a href="https://github.com/dimitropoulos/react-ui-roundup#errorboundary">
<img src="https://user-images.githubusercontent.com/15232461/75711292-27bf8700-5c94-11ea-9731-6ac285de25df.png" height="300px;" border="5"/>
</a>
For convenience, I've linked to the actual code for these three here:
- [Elastic's code](https://github.com/elastic/eui/blob/master/src/components/error_boundary/error_boundary.tsx): This one is the simplest (and, best looking, in my opinion). No props, just catches the error as you might expect.
- [AntD's code](https://github.com/ant-design/ant-design/blob/master/components/alert/ErrorBoundary.tsx#L36): This is implemented by adapting the Alert component (I _do not_ think we should do this in this project, btw). It therefore accepts a `title` and `description` prop (both strings), but not for passing in a custom fallback component, which is a bummer.
- [Carbon Design's code](https://github.com/carbon-design-system/carbon/blob/master/packages/react/src/components/ErrorBoundary/ErrorBoundary.js#L48): This one, although the storybook example they have is a bit unfortunate (it doesn't even show an error or callstack..???), it's actually the most flexible of the bunch. It allows passing in a fallback component via a fallback prop. The only downside here is that the actual error and componentStack are not accessible because they are not passed in to the fallback component.
So basically, I'm suggesting a mashup of the above 3, the looks of Eui, the simple string api of AntD, the flexible fallback (if you really need or want it), and _two more_ little additions (they're related).
I have done a few of these ErrorBoundary components for various projects in the past and one thing I ALWAYS end up needing is a little section at the bottom of the callstack where I can tell the user something like:
> Oops! Something went wrong. Please contact support at 1-800-867-5309
Or (better) sometimes it's appropriate to have a button that the user can click to contact support that will then open up something like Intercom, will start an email with some useful information pre-populated, or will send an error report dialog with something like getSentry.
Speaking of which, mature codebases will often be tracking errors of this sort with something like getSentry, and the `onCatch` prop exists as a simple callback that will allow the user to trigger some analytics (or other change) if an error state is to occur.
I propose the following API:
```ts
import { ReactNode, ErrorInfo } from 'react';
interface ErrorBoundaryProps {
/**
* This inserts a section below the call stack (or fallback) but within the ErrorBoundary that you can use to provide the users with more info (such as a support phone number to call) or
*/
actions?: ReactNode;
/**
* Can be overridden by providing a `fallback` prop.
*/
description?: string | ((componentStack: string) => string);
/**
* forces the ErrorBoundary to render when debug is `true`
*/
debug?: boolean;
/**
* This matches the arguments of `componentDidCatch`.
* If provided, overrides `title` and `description` props by occupying the space where the title and description are.
*/
renderFallback?: (error: Error, errorInfo: ErrorInfo) => ReactNode;
/**
* This matches the arguments of `componentDidCatch`.
* This callback is useful for enabling sending error information to analytics.
*/
onCatch?: (error: Error, errorInfo: ErrorInfo) => void;
/**
* Provide a string to override, or a function that receives the name of the error
*/
title?: string | ((errorTitle: string) => string);
}
const ErrorBoundary: FC<ErrorBoundary> = props => { ... }
```
As far as styling goes, I think Elastic's looks best. Perhaps we can just play around with material-ui internals and quickly find something suitable that works in both light and dark themes.
## Motivation 🔦
this was mentioned by @oliviertassinari https://github.com/mui-org/material-ui/issues/19744#issuecomment-593408040 in a comment about improving user experience. | new feature | low | Critical |
574,213,538 | go | cmd/compile: branch elimination opportunites when comparing constants | <!--
Please answer these questions before submitting your issue. Thanks!
For questions please use one of our forums: https://github.com/golang/go/wiki/Questions
-->
### What version of Go are you using (`go version`)?
<pre>
latest
</pre>
### Does this issue reproduce with the latest release?
Yes
### What operating system and processor architecture are you using (`go env`)?
<details><summary><code>go env</code> Output</summary><br><pre>
$ go env
linux/ppc64le but I see it in the SSA on x86
</pre></details>
### What did you do?
<!--
If possible, provide a recipe for reproducing the error.
A complete runnable program is good.
A link on play.golang.org is best.
-->
Inspecting code for other reasons, found cases where there are constant compares and subsequent branches against those constants, resulting in several unnecessary branches.
### What did you expect to see?
No unnecessary branches.
### What did you see instead?
Unnecessary branching due to constant compares of known values.
This example comes from the ssa output of bytes.(Buffer).WriteByte. Here are some snippets:
v18 00011 (+107) MOVD 8(R6), R7
v38 00012 (107) MOVD 16(R6), R5
v26 00013 (107) SUB R7, R5, R8
v70 00014 (107) CMP R8, $1
// This could be BLT 36. Block starting at 46 sets R3 to 0 then branches to a CMP R3, $0.
b1 00015 (107) BLT 46 <--- Change to BLT 36
v54 00019 (108) MOVD R4, 8(R6)
// Once the block at 46 is eliminated as a predecessor of this block, then the next 3 instructions are not needed, since the CMPW has only a single predecessor and it is comparing 0 against 1 and the BEQ will never happen.
v45 00020 (108) MOVD $1, R3 <---- Remove
v52 00021 (+265) CMPW R3, $0 <---- Remove
b9 00022 (+266) BEQ 36 <---- Remove
v24 00023 (+269) PCDATA $1, $1
v24 00024 (+269) MOVD 8(R6), R4
v34 00025 (+269) PCDATA $0, $2
v34 00026 (269) MOVD (R6), R5
v88 00027 (269) CMPU R4, R7
v63 00036 (267) PCDATA $1, $0
v63 00037 (+267) MOVD R6, 32(R1)
v81 00038 (267) MOVD $1, R3
v65 00039 (267) MOVD R3, 40(R1)
v66 00040 (+267) CALL "".(*Buffer).grow(SB)
v68 00041 (267) MOVD 48(R1), R7
v36 00042 (269) PCDATA $0, $1
v36 00043 (269) PCDATA $1, $1
v36 00044 (269) MOVD "".b(R1), R6
b11 00045 (267) JMP 23
// The MOVD $0, R3 and JMP 21 could be replaced by JMP 36 since the successor is CMP $0, R3 followed by BEQ 36. Once it is decided that 36 is the successor, I think the MOVD $0, R7 could also go away since the block starting at 36 doesn't use it. That also means the predecessor of this block could branch directly to 36.
v21 00046 (267) PCDATA $1, $0 <--- Remove
v21 00047 (267) MOVD $0, R7 <--- Remove
v25 00048 (267) MOVD $0, R3 <--- Remove
b2 00049 (+265) JMP 21 <---- Remove
This scenario is common in stdlib functions. It looks like the same situation occurs in x86, so it is not specific to ppc64/ppc64le.
@josharian I think I reported this problem last fall and you commented on it, but I can't find the issue where that was done.
| Performance,NeedsInvestigation,compiler/runtime | medium | Critical |
574,223,412 | pytorch | RPC API Changes for TensorPipes | ## 🚀 Feature
In order for RPC Agent to support the full functionality of TensorPipes' fast point-point communication, the following API-level changes will need to be made:
* Results Placement: Process A can send a message to Process B with instructions to send the result of the computation to Process C. We must also support the case where the result is a nested structure (list, dict, etc.), and so the results should be sent to multiple processes.
* Args Placement: Process A can send a message to Process B, indicating that the arguments must be placed on different machines prior to performing the computation. Much like the case above with nested results, we must support nested arguments.
cc @pietern @mrshenli @pritamdamania87 @zhaojuanmao @satgera @gqchen @aazzolini @rohan-varma @xush6528 @jjlilley @osalpekar | triaged,module: rpc | low | Minor |
574,229,057 | pytorch | Autograd deep copy avoidance optimization unsound in the presence of views | Right now, we have the following optimization in accumulate grad:
```
// under following condition, we can avoid clone()
if (!GradMode::is_enabled()
&& !new_grad.is_sparse()
&& new_grad.is_contiguous()
&& new_grad.use_count() <= 1 + !post_hooks().empty()) {
// first check it is in first-order grad only mode
// then check not sparse before is_contiguous
// then check contiguous, otherwise later in place accumulation may fail
// and lastly, check it is the last reference before we grab it.
// If the function has post hooks (for example, a DDP allreduce hook),
// call_function in Engine.cpp will temporarily bump the refcount by one, hence the
// addition of !post_hooks().empty().
variable.grad() = new_grad.detach();
```
We test the use count on the Tensor object to see if we can steal it into the input buffer (to be accumulated into when we make subsequent modifications). However, this is unsound if `new_grad` is a view on another tensor, because then we will save a view into `variable.grad()` and the aliasing is now observable.
There is also a minor correctness problem, where not all post hooks are safe to apply; if the post hook saves the gradient directly (without copying it) it can also observe subsequent mutations.
cc @ezyang @SsnL @albanD @zou3519 @gqchen @mcarilli | module: autograd,triaged | low | Minor |
574,238,382 | pytorch | Enable profiler tracing tests on windows | ## 🚀 Feature
As mentioned in https://github.com/pytorch/pytorch/pull/33987/files, the tests for `export_chrome_trace` in `test/test_autograd.py` are currently disabled on Windows due to a file permission issue.
A correct fix here would be to pass the file object directly to `export_chrome_trace`, however, this would require modifying its API.
When this is done we should re-enable the two tests that are currently skipped for windows:
`test_profiler_aggregation_lstm` and `test_profiler_tracing`
| feature,triaged | low | Minor |
574,290,205 | go | cmd/compile: use staticuint64s | CL 216401 introduced a new static array of uint64s running from 0 to 255.
Two follow-ups here:
* We should use it in the compiler instead of staticbytes for byte-sized values (see https://go-review.googlesource.com/c/go/+/216401/2/src/runtime/iface.go#531).
* We should use it in the compiler for larger-sized ints whose value is a constant between 0 and 255.
| Suggested,Performance,help wanted,NeedsFix,compiler/runtime | medium | Major |
574,294,596 | TypeScript | Go to definition shouldn't go to the import/require/aliased statement | *TS Template added by @mjbvz*
**TypeScript Version**: 3.8.3
**Search Terms**
- go to definition
- require
- node / nodejs
---
```js
const { c } = require('./a');
c();
```
When I `CTRL + CLICK` `c`, I want to go to the definition of `c` inside `a.js`, not to the require statement.
Currently
- `go to type definition` gives this behavior, but I can't rebind mouse commands
- if I allow `peek`, the second option is the one that I want | Bug | low | Minor |
574,298,576 | flutter | Semantic buttons in TextSpan with gesture recognizer weren't read consecutively. | Internal bug: b/150621008
The client is building a `TextSpan` via:
```dart
child: RichText(
text: TextSpan(
text: '',
children: [...]
```
Inside TextSpan there's a bunch of children that may or may not be "links". The links like this:
```dart
TextSpan(
text: someLoremIpsumText,
style: someLinkStyle,
recognizer: TapGestureRecognizer()..onTap = someGestureHandler,
semanticsLabel: someText,
);
```
**The problem is that when the text reader announces these, it stops at each link.** It requires user action (like a "next gesture" or a tap) to continue. The expected behavior is that the reader should just keep going.
The semantic tree looks like this (with a link in the middle):
```
|─SemanticsNode#48
I/flutter ( 4942): │ │ Rect.fromLTRB(68.0, -4.0, 192.0, 24.0)
I/flutter ( 4942): │ │ actions: tap
I/flutter ( 4942): │ │ flags: isLink
I/flutter ( 4942): │ │ label: "lorem ipsum"
I/flutter ( 4942): │ │ textDirection: ltr
I/flutter ( 4942): │ │ sortKey: OrdinalSortKey#cac8c(order: 1.0)
I/flutter ( 4942): │ │
I/flutter ( 4942): │ ├─SemanticsNode#49
I/flutter ( 4942): │ │ Rect.fromLTRB(-4.0, -4.0, 521.0, 44.0)
I/flutter ( 4942): │ │ label:
I/flutter ( 4942): │ │ " lorem ipsum lorem ipsum "
I/flutter ( 4942): │ │ textDirection: ltr
I/flutter ( 4942): │ │ sortKey: OrdinalSortKey#d570b(order: 2.0)
I/flutter ( 4942): │ │
I/flutter ( 4942): │ ├─SemanticsNode#50
I/flutter ( 4942): │ │ Rect.fromLTRB(41.0, 16.0, 282.0, 44.0)
I/flutter ( 4942): │ │ actions: tap
I/flutter ( 4942): │ │ flags: isLink
I/flutter ( 4942): │ │ label: " lorem link ipsum "
I/flutter ( 4942): │ │ textDirection: ltr
I/flutter ( 4942): │ │ sortKey: OrdinalSortKey#a369f(order: 3.0)
I/flutter ( 4942): │ │
I/flutter ( 4942): │ ├─SemanticsNode#51
I/flutter ( 4942): │ │ Rect.fromLTRB(-4.0, 16.0, 630.0, 84.0)
I/flutter ( 4942): │ │ label:
I/flutter ( 4942): │ │ " lorem ipsum"
I/flutter ( 4942): │ │ textDirection: ltr
I/flutter ( 4942): │ │ sortKey: OrdinalSortKey#73755(order: 4.0)
``` | platform-android,framework,a: accessibility,customer: dream (g3),has reproducible steps,customer: peppermint,P2,found in release: 3.7,found in release: 3.10,team-android,triaged-android | low | Critical |
574,301,611 | godot | 3.2 Stable Mono - Exported standalone custom resource has default/null field values, arrays of custom resources work as expected | **Godot version:**
3.2 Stable Mono
**OS/device including version:**
Windows 10
**Issue description:**
Custom resources exported by themselves are not initialized properly. Ex:
```cs
public class MyCustomResource : Resource {
[Export]
public string Id { get; private set; } = "my resource id"
}
```
```cs
// SomeNode.cs
[Export]
private MyCustomResource _resource; // assume I have assigned my custom resource via the editor
public override void _Ready() {
GD.Print(_resource?.Id ?? "no id"); // prints "no id" on run
}
```
However, when I structure the export as a `Godot.Collections.Array` I see the following:
```cs
[Export]
private Godot.Collections.Array<MyCustomResource> _resource; // assume I have assigned a single resource via the editor
public override void _Ready() {
GD.Print(_resource[0].Id); // prints "my resource id" on run
}
```
Potentially related, I also noticed that attempting to duplicate custom resources at run time also clears out all of the properties and fields of the resource. Let me know if I should file a separate bug for that.
**Steps to reproduce:**
See above
**Minimal reproduction project:**
N/A | topic:dotnet | low | Critical |
574,335,711 | nvm | Support Node Aliases | Hey, I was wondering what it would take to get nvm to support these aliases?
https://github.com/nodejs/package-maintenance/issues/236
Is this something you are interested in? | feature requests | low | Major |
574,345,726 | flutter | Cupertino Date picker with Reachability in IOS accessibility on | ## Steps to Reproduce
<!-- You must include full steps to reproduce so that we can reproduce the problem. -->
1. Run `flutter create bug`.
2. Update the files as follows:
[bug 2.zip](https://github.com/flutter/flutter/files/4278733/bug.2.zip)
1. create an application that shows CupertinoDatePicker
2. turn on reachability in iOS accessbility
3. try to pick a date -->
**Expected results:** Be able to pick a date without triggering reachability
**Actual results:** Reachability triggers and is unable to pick date properly
<details>
<summary>Logs</summary>
<!--
Run your application with `flutter run --verbose` and attach all the
log output below between the lines with the backticks. If there is an
exception, please see if the error message includes enough information
to explain how to solve the issue.
-->
```
[logs.txt](https://github.com/flutter/flutter/files/4278718/logs.txt)
```
<!--
Run `flutter analyze` and attach any output of that command below.
If there are any analysis errors, try resolving them before filing this issue.
-->
```
Jasons-MacBook-Pro:datepicker jasonzheng$ flutter analyze
Analyzing datepicker...
No issues found! (ran in 2.7s)
```
<!-- Finally, paste the output of running `flutter doctor -v` here. -->
```
Jasons-MacBook-Pro:datepicker jasonzheng$ flutter doctor -v
[✓] Flutter (Channel beta, v1.14.6, on Mac OS X 10.14.6 18G103, locale en-US)
• Flutter version 1.14.6 at /Volumes/Data/Sources/flutter
• Framework revision fabeb2a16f (5 weeks ago), 2020-01-28 07:56:51 -0800
• Engine revision c4229bfbba
• Dart version 2.8.0 (build 2.8.0-dev.5.0 fc3af737c7)
[✓] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
• Android SDK at /Users/jasonzheng/Library/Android/sdk
• Android NDK location not configured (optional; useful for native profiling
support)
• Platform android-29, build-tools 28.0.3
• Java binary at: /Applications/Android
Studio.app/Contents/jre/jdk/Contents/Home/bin/java
• Java version OpenJDK Runtime Environment (build
1.8.0_202-release-1483-b49-5587405)
• All Android licenses accepted.
[✓] Xcode - develop for iOS and macOS (Xcode 11.3.1)
• Xcode at /Applications/Xcode.app/Contents/Developer
• Xcode 11.3.1, Build version 11C504
• CocoaPods version 1.8.4
[✓] Android Studio (version 3.5)
• Android Studio at /Applications/Android Studio.app/Contents
• Flutter plugin version 41.1.2
• Dart plugin version 191.8593
• Java version OpenJDK Runtime Environment (build
1.8.0_202-release-1483-b49-5587405)
[✓] VS Code (version 1.42.1)
• VS Code at /Applications/Visual Studio Code.app/Contents
• Flutter extension version 3.8.1
[✓] Connected device (1 available)
• iPhone 11 Pro • 64C37970-1AC3-4F52-A335-46701F492CFA • ios •
com.apple.CoreSimulator.SimRuntime.iOS-13-3 (simulator)
• No issues found!
```
</details>
| platform-ios,framework,a: accessibility,f: cupertino,customer: crowd,has reproducible steps,found in release: 3.3,found in release: 3.7,team-design,triaged-design | low | Critical |
574,366,716 | rust | Consider integrating with OSS-Fuzz? | (Similar to my issue for regex: https://github.com/rust-lang/regex/issues/650)
[OSS-Fuzz](https://google.github.io/oss-fuzz/) is a Google-provided service that can automatically and continuously fuzz OSS code and report bugs for discovered issues.
[The requirement for being accepted](https://google.github.io/oss-fuzz/getting-started/accepting-new-projects/) in OSS-Fuzz is "project must have a significant user base and/or be critical to the global IT infrastructure" which I _personally_ believe includes the rustc since it's at the core of so much stuff. Also, OSS-Fuzz supports fuzzing Rust libraries, so IMO that signals the project views Rust as important enough. [List of projects that are currently in OSS-Fuzz.](https://github.com/google/oss-fuzz/tree/master/projects) Note that LLVM and Go are on the list, so compilers have been accepted before.
Can't hurt to file a form and ask.
OSS-Fuzz offers [monetary rewards for integration](https://opensource.googleblog.com/2017/05/oss-fuzz-five-months-later-and.html), up to $20k. It can be donated to a charity and Google will double the reward. (Has the much-talked-about Rust Foundation been created? If so, it would be a great fit.)
$40k to a charity for a few days of work doesn't sound like a bad deal...
(Disclaimer: I work for Google, but not on anything fuzzing or security-related. I do not speak for my employer. This suggestion comes from "personal Val", not "business Val". :smiley:)
cc @Shnatsel @rust-fuzz | C-enhancement,T-compiler | low | Critical |
574,375,059 | rust | Very hard to read error when returning `?` from closure not returning Result or Option | The original code:
```rust
// '[' expr ']' | '(' argument* ')' | '.' ID | '->' ID | '++' | '--'
fn match_postfix_op(&mut self) -> SyntaxResult<Option<Locatable<impl Fn(Expr) -> ExprType>>> {
let needs_id = |this: &mut Self, constructor: fn(Box<Expr>, InternedStr) -> ExprType| {
let start = this.next_token().unwrap().location;
let Locatable { data: id, location } = this.expect_id()?;
let location = start.merge(&location);
(move |expr| constructor(expr, id), location)
};
// prefix operator
let (func, location) = match self.peek_token() {
Some(Token::Dot) => needs_id(self, ExprType::Member)?,
_ => return Ok(None),
};
Ok(Some(Locatable {
data: move |e| func(Box::new(e)),
location,
}))
}
```
```
error[E0277]: the `?` operator can only be used in a closure that returns `Result` or `Option` (or another type that implements `std::ops::Try`)
--> src/expr.rs:237:52
|
235 | let needs_id = |this: &mut Self, constructor: fn(Box<Expr>, InternedStr) -> ExprType| {
| ________________________-
236 | | let start = this.next_token().unwrap().location;
237 | | let Locatable { data: id, location } = this.expect_id()?;
| | ^^^^^^^^^^^^^^^^^ cannot use the `?` operator in a closure that returns `([closure@src/expr.rs:239:14: 239:47 constructor:_, id:_], data::lex::DefaultLocation)`
238 | | let location = start.merge(&location);
239 | | (move |expr| constructor(expr, id), location)
240 | | };
| |_________- this function should return `Result` or `Option` to accept `?`
|
= help: the trait `std::ops::Try` is not implemented for `([closure@src/expr.rs:239:14: 239:47 constructor:_, id:_], data::lex::DefaultLocation)`
= note: required by `std::ops::Try::from_error`
error[E0277]: the `?` operator can only be applied to values that implement `std::ops::Try`
--> src/expr.rs:243:33
|
243 | Some(Token::Dot) => needs_id(self, ExprType::Member)?,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `?` operator cannot be applied to type `([closure@src/expr.rs:239:14: 239:47 constructor:_, id:_], data::lex::DefaultLocation)`
|
= help: the trait `std::ops::Try` is not implemented for `([closure@src/expr.rs:239:14: 239:47 constructor:_, id:_], data::lex::DefaultLocation)`
= note: required by `std::ops::Try::into_result`
error: aborting due to 2 previous errors
```
The fix was to return `Ok()` at the end of the closure: ` Ok((move |expr| constructor(expr, id), location))`. It would be much more helpful if the error message suggested returning `Ok()` at the end instead of spouting a wall of text at me. | C-enhancement,A-diagnostics,T-compiler,A-suggestion-diagnostics,D-papercut | low | Critical |
574,380,354 | rust | Improve diagnostics when a type does not impl a trait despite #[derive]'ing it |
_Originally posted by @simonbuchan in https://github.com/rust-lang/rust/issues/26925#issuecomment-593708712_
I think I would be a lot happier with the current situation with "just" adding more information to the compiler diagnostic.
At the moment, you get something like:
```
error[E0599]: no method named `clone` found for type `Ptr<Foo>` in the current scope
--> src/main.rs:9:15
|
2 | struct Ptr<T>(*mut T);
| ---------------------- method `clone` not found for this
...
9 | let b = a.clone();
| ^^^^^ method not found in `Ptr<Foo>`
|
= note: the method `clone` exists but the following trait bounds were not satisfied:
`Ptr<Foo> : std::clone::Clone`
= help: items from traits can only be used if the trait is implemented and in scope
= note: the following trait defines an item `clone`, perhaps you need to implement it:
candidate #1: `std::clone::Clone`
```
or
```
error[E0382]: use of moved value: `a`
--> src/main.rs:10:15
|
8 | let a = Ptr(&mut foo);
| - move occurs because `a` has type `Ptr<Foo>`, which does not implement the `Copy` trait
9 | let b = a;
| - value moved here
10 | let ptr = a.0;
| ^^^ value used here after move
```
Neither of these tell you that the *reason* `Ptr` doesn't implement `Copy` or `Clone`, despite `#[derive(Copy, Clone)]` being right there. I think some logic to add another sentence for this would get rid of the case where `derive` doesn't implement when it should, which I think newer users (like me!) would be more likely to hit. | C-enhancement,A-diagnostics,T-compiler | low | Critical |
574,382,232 | pytorch | autograd with TorchScript does not match finite differences | ## 🐛 Bug
Some code does not match finite differences (`torch.autograd.gradcheck`) if scripted. Below is a minimum reproducible example:
## To Reproduce
```python
import torch
torch.set_default_dtype(torch.float64)
def func(arg: torch.Tensor) -> torch.Tensor:
a = (arg * 1.001)[None]
b, = torch.unbind(a, dim=0)
#b = a[0] # Uncommenting this line works
return arg * 1.001 + b
torch.autograd.gradcheck(func, (torch.tensor(1., requires_grad=True))) # This passes
torch.autograd.gradcheck(torch.jit.script(func), (torch.tensor(1., requires_grad=True))) # This fails
```
Output:
```
RuntimeError Traceback (most recent call last)
<ipython-input-30-771c6d9493c6> in <module>
10
11 torch.autograd.gradcheck(func, (torch.tensor(1., requires_grad=True))) # This passes
---> 12 torch.autograd.gradcheck(torch.jit.script(func), (torch.tensor(1., requires_grad=True))) # This fails
~/.local/lib/python3.6/site-packages/torch/autograd/gradcheck.py in gradcheck(func, inputs, eps, atol, rtol, raise_exception, check_sparse_nnz, nondet_tol)
287 if not torch.allclose(a, n, rtol, atol):
288 return fail_test('Jacobian mismatch for output %d with respect to input %d,\n'
--> 289 'numerical:%s\nanalytical:%s\n' % (i, j, n, a))
290
291 if not reentrant:
~/.local/lib/python3.6/site-packages/torch/autograd/gradcheck.py in fail_test(msg)
225 def fail_test(msg):
226 if raise_exception:
--> 227 raise RuntimeError(msg)
228 return False
229
RuntimeError: Jacobian mismatch for output 0 with respect to input 0,
numerical:tensor([[2.0020]])
analytical:tensor([[1.0010]])
```
I experimented with a few other cases. The scalar multipliers (here `1.001`) must be the same, and cannot be `0.` or `1.`. Replacing `unbind` with indexing (as commented in the example) also solves the issue.
## Expected behavior
The gradient of PyTorch and TorchScript functions should agree with each other, and with finite differences.
## Environment
PyTorch version: 1.4.0 (installed through pip)
Is debug build: No
CUDA used to build PyTorch: 10.1
OS: Ubuntu 18.04.4 LTS
GCC version: (Ubuntu 7.4.0-1ubuntu1~18.04.1) 7.4.0
CMake version: version 3.10.2
Python version: 3.6
Is CUDA available: Yes
CUDA runtime version: Could not collect
GPU models and configuration: GPU 0: GeForce GTX 1080 Ti
Nvidia driver version: 440.59
cuDNN version: /usr/lib/x86_64-linux-gnu/libcudnn.so.7.6.5
Versions of relevant libraries:
[pip3] numpy==1.18.1
[pip3] pytorch3d==0.1
[pip3] torch==1.4.0
[pip3] torch-cg==1.0.1
[pip3] torchtext==0.4.0
[pip3] torchvision==0.5.0
[conda] Could not collect
cc @ezyang @gchanan @zou3519 @bdhirsh @heitorschueroff @gmagogsfm @suo | high priority,triage review,oncall: jit | low | Critical |
574,436,521 | rust | Tracking issue for more precise coroutine captures | Today, valid programs using coroutines (and async/await) are rejected by the compiler because it thinks certain values may be held across yields when they are not.
Examples / to do: (please add more as they come up)
- [x] https://github.com/rust-lang/rust/issues/57017
- [x] https://github.com/rust-lang/rust/issues/57478
- [x] https://github.com/rust-lang/rust/issues/72956
- [x] #72651
- [ ] https://github.com/rust-lang/rust/issues/63768
- [x] #87309
- [x] #104883
### Unresolved Questions
How should we implement this?
Are there any programs which _could_ be accepted, but shouldn't be because they would depend too heavily on implementation details of the compiler?
### Implementation notes
There's some discussion here: https://github.com/rust-lang/rust/issues/57017#issuecomment-540023781
<!-- TRIAGEBOT_START -->
<!-- TRIAGEBOT_ASSIGN_START -->
This issue has been assigned to @eholk via [this comment](https://github.com/rust-lang/rust/issues/69663#issuecomment-881594396).
<!-- TRIAGEBOT_ASSIGN_DATA_START$${"user":"eholk"}$$TRIAGEBOT_ASSIGN_DATA_END -->
<!-- TRIAGEBOT_ASSIGN_END -->
<!-- TRIAGEBOT_END --> | A-type-system,E-hard,C-enhancement,T-compiler,A-coroutines,A-async-await,AsyncAwait-Triaged,T-types | medium | Major |
574,485,762 | storybook | MDX Props table doesn't display props of external library component | I have a use-case where I want to document in my storybook a material-ui component and get all of it's props to be displayed in the table.
As a naive approach, here was my mdx doc file:
```mdx
import { Meta, Story, Preview, Props } from "@storybook/addon-docs/blocks";
import { Button } from "@material-ui/core";
<Meta title="Button" component={Button} />
### Basic
<Preview>
<Story name="Basic">
<Button>
Storybook
</Button>
</Story>
</Preview>
### Props
<Props of={Button} />
```
Unfortunately, I couldn't see any props in the table.
I'm consuming the compiled version material-ui component which includes a separated `d.ts` types file with all the relevant props and descriptions but I can't seem to load them properly.
| feature request,addon: docs,block: props | medium | Major |
574,486,204 | rust | Tracking Issue for the `avr-interrupt`/`avr-non-blocking-interrupt` calling convention/ABI | <!--
Thank you for creating a tracking issue! 📜 Tracking issues are for tracking a
feature from implementation to stabilisation. Make sure to include the relevant
RFC for the feature if it has one. Otherwise provide a short summary of the
feature and link any relevant PRs or issues, and remove any sections that are
not relevant to the feature.
Remember to add team labels to the tracking issue.
For a language team feature, this would e.g., be `T-lang`.
Such a feature should also be labeled with e.g., `F-my_feature`.
This label is used to associate issues (e.g., bugs and design questions) to the feature.
-->
This is a tracking issue for the RFC "XXX" (rust-lang/rfcs#NNN).
The feature gate for the issue is `#![feature(FFF)]`.
### Steps
- [x] Implement the RFC
- [ ] Adjust documentation ([see instructions on rustc-guide][doc-guide])
- [ ] Stabilization PR ([see instructions on rustc-guide][stabilization-guide])
[stabilization-guide]: https://rust-lang.github.io/rustc-guide/stabilization_guide.html#stabilization-pr
[doc-guide]: https://rust-lang.github.io/rustc-guide/stabilization_guide.html#documentation-prs
### Unresolved Questions
None yet.
### Implementation history
* #69478 introduces AVR as a tier-3 target upstream
| T-lang,B-unstable,C-tracking-issue,WG-embedded,O-AVR,S-tracking-needs-summary,A-hardware-interrupts | low | Critical |
574,518,210 | scrcpy | Lock video rotation to landscape but display in portrait | Hello, please let me know if this is the right place to ask.
I'm having problem with screen rotation of the device, basically the screen orientation (portrait, 1080x1920) & input capture (click) are correct, but the video stream of the screen are not (c.f. screenshot 1 & output 1)
```
❯ ninja -Cx && ./run x --lock-video-orientation 0 scrcpy/git/dev
ninja: Entering directory `x'
[0/1] Generating scrcpy-server with a custom command.
Deprecated Gradle features were used in this build, making it incompatible with Gradle 6.0.
Use '--warning-mode all' to show the individual deprecation warnings.
See https://docs.gradle.org/5.5.1/userguide/command_line_interface.html#sec:command_line_warnings
BUILD SUCCESSFUL in 739ms
26 actionable tasks: 1 executed, 25 up-to-date
2020-03-03 09:57:38.751 scrcpy[72447:1637298] INFO: scrcpy 1.12.1 <https://github.com/Genymobile/scrcpy>
x/server/scrcpy-server: 1 file pushed. 1.8 MB/s (26886 bytes in 0.014s)
2020-03-03 09:57:39.175 scrcpy[72447:1637298] INFO: Initial texture: 1080x1920
```
When I try to lock screen to rotate 90 degree, it works perfectly, but then everything is rotated (c.f. screenshot2 and output 2)
```
❯ ninja -Cx && ./run x --lock-video-orientation 1 scrcpy/git/dev
ninja: Entering directory `x'
[0/1] Generating scrcpy-server with a custom command.
Deprecated Gradle features were used in this build, making it incompatible with Gradle 6.0.
Use '--warning-mode all' to show the individual deprecation warnings.
See https://docs.gradle.org/5.5.1/userguide/command_line_interface.html#sec:command_line_warnings
BUILD SUCCESSFUL in 758ms
26 actionable tasks: 1 executed, 25 up-to-date
2020-03-03 10:03:17.570 scrcpy[72684:1643900] INFO: scrcpy 1.12.1 <https://github.com/Genymobile/scrcpy>
x/server/scrcpy-server: 1 file pushed. 1.8 MB/s (26886 bytes in 0.015s)
2020-03-03 10:03:17.999 scrcpy[72684:1643900] INFO: Initial texture: 1080x1920
2020-03-03 10:03:18.126 scrcpy[72684:1643900] INFO: New texture: 1920x1080
```
My question is "is there a way to rotate the stream again 90 degree so I can work with the app normally without having my neck rotated." I don't mind to hard code a walkaround for this specific case, but still don't know where I can modify the code, client or server etc.
Regards,
Screenshots
https://imgur.com/a/VC2kvEg
| rotation | medium | Major |
574,519,277 | flutter | [in_app_purchase] autoConsume should be false by default | By what it looks like, in_app_purchases autoCompletes transactions by default:
```
Future<bool> buyConsumable({@required PurchaseParam purchaseParam, bool autoConsume = true});
```
I presume those auto-consumed purchases are not verified against app licence and therefore might be spoofed. By setting `autoConsume` to be `true` by default it creates a potential threat to users who do not even think about verifying purchases as the library completes the purchase for them.
| p: in_app_purchase,package,c: proposal,team-ecosystem,P3,triaged-ecosystem | low | Minor |
574,544,473 | flutter | Provide system font info in initial configuration on Linux | Material should be using the system font; on most platforms we have a specific font (Roboto, San Francisco, etc.) but on Linux we should be getting that information from the system. E.g., on Ubuntu it should be Ubuntu, but that wouldn't be right for Debian.
The current thinking is that we should query the system for that an pass it in the initial configuration system channel (which isn't currently being sent at all on Linux IIRC, but we can certainly add it).
/cc @gspencergoog | framework,engine,platform-linux,c: proposal,a: desktop,P3,team-linux,triaged-linux | low | Major |
574,546,392 | go | net/http: improve proxy handling | ### What version of Go are you using (`go version`)?
<pre>
$ go version
go version go1.14 darwin/amd64
</pre>
### Does this issue reproduce with the latest release?
Yes
### What operating system and processor architecture are you using (`go env`)?
<details><summary><code>go env</code> Output</summary><br><pre>
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/vico/Library/Caches/go-build"
GOENV="/Users/vico/Library/Application Support/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOINSECURE=""
GONOPROXY=""
GONOSUMDB=""
GOOS="darwin"
GOPATH="/Users/vico/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/darwin_amd64"
GCCGO="gccgo"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/32/7qmymd5950b3nhv4dd7qbqkw0000gn/T/go-build036564932=/tmp/go-build -gno-record-gcc-switches -fno-common"
</pre></details>
### What did you do?
I'm running requests (using **go-resty library**, based on default HTTP client). This problem is I need to use proxies, some of proxies are dead (public proxies) and so, they don't answer the request.
I started learning Go not a long time ago, but when I was programming in C#, the proxy handling was good, I mean :
- Most of proxies respond well. Here in Go, the proxy definition is sketchy (in my opinion). There is also no official way to put proxy with authentication (not sure?).
- When a proxy is dead, it throws an error fast. Here in Go, it waits for the default page timeout, not a connect timeout or something.
### What did you expect to see?
Proxy integration that respond better or that skips wrong/dead proxies faster.
### What did you see instead?
Mainly performance losses, and when I use public proxies, Go seems not connecting to all proxies while some are really working.
(Original issue from go-resty: https://github.com/go-resty/resty/issues/320) | NeedsInvestigation | low | Critical |
574,578,042 | pytorch | torch::jit::script::Object::attr should throw AttributeError instead of RuntimeError | ## 🐛 Bug
Not doing so breaks the `hasattr` builtin, as per https://docs.python.org/3/library/functions.html#hasattr
## To Reproduce
```python
import torch
nt = torch.classes._TorchScriptTesting_PickleTester([3, 4])
print(hasattr(nt, "non_existent_attr"))
```
```
Traceback (most recent call last):
File "test_script_throw.py", line 4, in <module>
print(hasattr(nt, "non_existent_attr"))
RuntimeError: __torch__.torch.classes._TorchScriptTesting_PickleTester does not have a field with name 'non_existent_attr'
```
## Expected behavior
`hasattr` should not throw
cc @suo | oncall: jit,triaged | low | Critical |
574,622,756 | angular | Enter and leave animations don't behave as expected with parent-child relationships | # 🐞 Bug report
### Affected Package
@angular/animation or @angular/core
### Is this a regression?
I've made a Stackblitz with Angular 9, 8 and 7. All versions have this problem.
### Description
There is a problem when you nest a component with an :enter and :leave animation inside a parent which is conditionally visible using *ngIf. When the parent is visible for the first time there is no issue. Once you trigger the parent to leave and enter again, the child will not be visible.
It looks like the leave animation of the child gets triggered when the parent leaves but the enter animation isn't fired once the parent enters again.
## 🔬 Minimal Reproduction
I've made a simple example in Stackblitz. You can even make it less complex by removing the animations on the collapsible panel.
[Stackblitz with Angular 17](https://stackblitz.com/edit/angular-17-animations-bug)
[Stackblitz with Angular 9](https://stackblitz.com/edit/angular-9-animations-bug)
[Stackblitz with Angular 8](https://stackblitz.com/edit/angular-8-animations-bug)
[Stackblitz with Angular 7](https://stackblitz.com/edit/angular-7-animations-bug)
## 🌍 Your Environment
Angular 9 but it's also reproducible in 8 and 7.
Stackblitz contains my package versions.
| type: bug/fix,area: animations,freq3: high,P3 | medium | Critical |
574,694,383 | pytorch | ExceptionWrapper cannot handle exceptions with more than one argument | ## 🐛 Bug
_utils.py: ExceptionWrapper cannot handle exceptions with more than one argument
## To Reproduce
Steps to reproduce the behavior:
1. Create a DataLoader
2. Raise an error that takes multplie arguments in the constructor, eg. `urllib.error.HTTPError`
```
/torch/_utils.py", line 394, in reraise
raise self.exc_type(msg)
TypeError: __init__() missing 4 required positional arguments: 'code', 'msg', 'hdrs', and 'fp'
```
## Expected behavior
ExceptionWrapper shouldn't throw in reraise. The exception should be wrapped in a generic Exception or initialized with all arguments (not sure if that's possible? Perhaps passing the exception object from the worker would be better)
## Environment
Please copy and paste the output from our
PyTorch Version (e.g., 1.0): 1.4.0
OS (e.g., Linux): CentOS 6.3
How you installed PyTorch (conda, pip, source): pip
Build command you used (if compiling from source):
Python version: 3.6.5
CUDA/cuDNN version: 10.0, 7.5
GPU models and configuration: P4
cc @SsnL | module: dataloader,module: error checking,triaged | low | Critical |
574,755,740 | rust | Resolving recursive traits with type parameters requires exponential memory in certain cases | This is an extremely niche case, but after asking about it on the rust community Discord I was told I should open an issue.
When trying to compile this code, the memory use (and compile time) increases exponentially with the nesting depth of `I`:
```rust
trait Op<S, T> {
type Result;
}
impl<
I: Op<(), A>,
J: Op<(), (F, (F, R)), Result = A>,
S: Op<(), I::Result>,
A, F, R
> Op<S, (F, R)> for (I, J) {
type Result = S::Result;
}
impl<S, T> Op<S, T> for () {
type Result = T;
}
type I<T> = (T, ());
type Ty = I<I<I<I<I<I<I<I<I<I<()>>>>>>>>>>;
// nesting `I` more times causes exponential increase in compile time and memory usage
// about 13 is where it becomes noticeable
type Test = <I<I<I<Ty>>> as Op<(), (u8, i8)>>::Result;
fn main() {
// force the compiler to actually evaluate Test and show an error message
// with the type of Test
println!("{}", Test::default().push(1));
}
```
The actual amount of work the compiler is doing should not be growing exponentially. We can see this by doing the work in 2 parts:
```rust
// we break the 13 level deep nesting into 7 and 6
// <I<I<I<I<I<I<I<()>>>>>>> as Op<(), (u8, i8)>>::Result
// finding this took almost no time or memory
type O = (u8, (u8, (u8, (u8, (u8, (u8, (u8, (u8, i8))))))));
// resolving this takes almost no time or memory
type Test = <I<I<I<I<I<I<()>>>>>> as Op<(), O>>::Result;
```
Recursive trait implementations that do generate exponentially large types generally cause the compiler to hang with memory increasing very slowly, however with this I was able to use all 16GB of RAM and 8GM of swap on my computer in about 5 minutes.
The reason I think this is a bug and not just a general limitation of Rust is that re writing the code to not use traits with type parameters causes the memory use to grow linearly instead. This code does exactly the same as the original example, except replacing `T as Op<U, S>` with `(T, U, S) as Op`:
```rust
trait Op {
type Result;
}
impl<I, J, S, F, R, A, C, D> Op for ((I, J), S, (F, R)) where
(J, (), (F, (F, R))): Op<Result = A>,
(I, (), A): Op<Result = C>,
(S, (), C): Op<Result = D>,
{
type Result = D;
}
impl<S, T> Op for ((), S, T) {
type Result = T;
}
type I<T> = (T, ());
type Ty = I<I<I<I<I<I<I<I<I<I<()>>>>>>>>>>;
type Test = <(I<I<I<Ty>>>, (), (u8, i8)) as Op>::Result;
fn main() {
println!("{}", Test::default().push(1));
}
```
This is surprising, since I thought that this was basically how traits with type parameters were handled by the compiler.
I have done some testing, and even small changes cause this behavior to not happen. Note that while these are identical to the original example for this type, they don't behave exactly the same for some other types:
```rust
trait Op<T> {
type Result;
}
impl<
I: Op<A>,
J: Op<(F, (F, R)), Result = A>,
A,
F, R,
> Op<(F, R)> for (I, J) {
type Result = I::Result;
}
impl<T> Op<T> for () {
type Result = T;
}
type I<T> = (T, ());
type Ty = I<I<I<I<I<I<I<I<I<I<()>>>>>>>>>>;
type Test = <I<I<I<Ty>>> as Op<(u8, i8)>>::Result;
fn main() {
println!("{}", Test::default().push(1));
}
```
```rust
trait Op<S, T> {
type Result;
}
impl<
I: Op<(), (F, (F, R))>,
S: Op<(), I::Result>,
J, F, R
> Op<S, (F, R)> for (I, J) {
type Result = S::Result;
}
impl<S, T> Op<S, T> for () {
type Result = T;
}
type I<T> = (T, ());
type Ty = I<I<I<I<I<I<I<I<I<I<()>>>>>>>>>>;
type Test = <I<I<I<Ty>>> as Op<(), (u8, i8)>>::Result;
fn main() {
println!("{}", Test::default().push(1));
}
```
```rust
trait Op<S, T> {
type Result;
}
impl<
I: Op<(), J::Result>,
J: Op<(), (F, (F, R))>,
S: Op<(), I::Result>,
F, R
> Op<S, (F, R)> for (I, J) {
type Result = S::Result;
}
impl<S, T> Op<S, T> for () {
type Result = T;
}
type I<T> = (T, ());
type Ty = I<I<I<I<I<I<I<I<I<I<()>>>>>>>>>>;
type Test = <I<I<I<Ty>>> as Op<(), (u8, i8)>>::Result;
fn main() {
println!("{}", Test::default().push(1));
}
``` | C-enhancement,A-trait-system,I-compiletime,T-compiler,I-compilemem,T-types,fixed-by-next-solver | low | Critical |
574,782,447 | flutter | hide the samples related commands from `flutter create` | We should hide the sample related commands from `flutter create`. IDEs don't call these anymore - they instead identify samples in-line in the source code you have open, and show hyperlinks to open the hosted versions of these samples in the generated docs.
And, the samples aren't pedagogical getting started flutter apps, unlike the `flutter create` templates. Having both samples and templates in flutter create is esp. confusing for new users, as to which ones they should create to get started.
```
-s, --sample=<id> Specifies the Flutter code sample to use as the main.dart for an application. Implies --template=app. The value
should be the sample ID of the desired sample from the API documentation website (http://docs.flutter.dev). An
example can be found at https://master-api.flutter.dev/flutter/widgets/SingleChildScrollView-class.html
--list-samples=<path> Specifies a JSON output file for a listing of Flutter code samples that can created with --sample.
```
| tool,P3,team-tool,triaged-tool | low | Minor |
574,793,352 | opencv | DNN - Add support for XNNPACK Target for NN acceleration on ARM Devices | I'd love to see XNNPACK as an inference engine for DNN, especially for running models on low-powered ARM devices. Thanks!
https://github.com/google/XNNPACK | optimization,feature,category: dnn,platform: arm | low | Minor |
574,813,616 | material-ui | Popover - Cannot close Popover when using screen reader (Voiceover w/ Safari on Mac and iPad) | - [X] The issue is present in the latest release.
- [X] I have searched the [issues](https://github.com/mui-org/material-ui/issues) of this repository and believe that this is not a duplicate.
## Current Behavior 😯
Currently you are unable to close a Popover when you are using a screen reader. I tested this on Safari on Mac and iPad with Voiceover. You end up getting into a focus trap where you cannot tab anymore once the Popover opens, so you cannot get back to the button that opened it to close it again.
## Expected Behavior 🤔
You should be able to tab away when a Popover is open so you can close it again.
## Steps to Reproduce 🕹
Steps:
1. Go the MUI site's Popover page https://v4-3-3.material-ui.com/components/popover/
2. Turn on your screen reader
3. Tab down to the Open Popover button in the first example, "Simple Popover"
4. Click the space bar or enter to press the button. Notice that the focus has not shifted to being onside the Popover and the content is read out.
5. Try to tab or back tab to get away from the Popover content and get to a different interactive element on the screen. You are unable to do so.
The only behavior I can do is press the up arrow key which will send the focus to text at the bottom of the screen and read it out, but you cannot get to interactive elements so there's no way to close the Popover.
## Context 🔦
This is blocking screen reader users from being able to close the Popover and creates a focus trap so they are not able to use any other interactive elements on a screen once a Popover has been opened.
## Your Environment 🌎
| Tech | Version |
| ----------- | ------- |
| Material-UI | v4.3.3 |
| React | |
| Browser | Safari (best browser for using Voiceover) |
| TypeScript | |
| etc. | iOS Sierra v10.12.6 |
| accessibility,component: Popover | low | Major |
574,852,016 | flutter | flutter run (when spawned from external script) crashes when its stdin is written to | <!-- Thank you for using Flutter!
If you are looking for support, please check out our documentation
or consider asking a question on Stack Overflow:
* https://flutter.dev/
* https://api.flutter.dev/
* https://stackoverflow.com/questions/tagged/flutter?sort=frequent
If you have found a bug or if our documentation doesn't have an answer
to what you're looking for, then fill our the template below. Please read
our guide to filing a bug first: https://flutter.dev/docs/resources/bug-reports
-->
## Steps to Reproduce
<!-- Please tell us exactly how to reproduce the problem you are running into. -->
description: I was attempting to induce a hot reload from a build/test script written in rust,
this example illustrates the attempted use of q hotkey after flutter is running
1. install rust toolchain (https://www.rust-lang.org/tools/install)
2. ```cargo new flutter_stdin```
3. paste https://gist.github.com/smokytheangel0/c2f4b97ab0037a1e1357b9848dd17274 into flutter_stdin/src/main.rs
4. ```cargo build``` in flutter_stdin
5. ```flutter create stdin_test``` in ../
6. ```cp flutter_stdin/target/debug/flutter_stdin stdin_test```
7. ```./flutter_stdin``` in stdin_test
## Logs
<!--
Include the full logs of the commands you are running between the lines
with the backticks below. If you are running any "flutter" commands,
please include the output of running them with "--verbose"; for example,
the output of running "flutter --verbose create foo".
-->
```
Unhandled exception:
FileSystemException: writeFrom failed, path = '' (OS Error: Broken pipe, errno = 32)
#0 _RandomAccessFile.writeFromSync (dart:io/file_impl.dart:881:7)
#1 _StdConsumer.addStream.<anonymous closure> (dart:io/stdio.dart:312:15)
#2 _rootRunUnary (dart:async/zone.dart:1138:13)
#3 _CustomZone.runUnary (dart:async/zone.dart:1031:19)
#4 _CustomZone.runUnaryGuarded (dart:async/zone.dart:933:7)
#5 _BufferingStreamSubscription._sendData (dart:async/stream_impl.dart:339:11)
#6 _BufferingStreamSubscription._add (dart:async/stream_impl.dart:266:7)
#7 _SyncStreamControllerDispatch._sendData (dart:async/stream_controller.dart:773:19)
#8 _StreamController._add (dart:async/stream_controller.dart:649:7)
#9 _StreamController.add (dart:async/stream_controller.dart:595:5)
#10 _StreamSinkImpl.add (dart:io/io_sink.dart:158:17)
#11 _IOSinkImpl.write (dart:io/io_sink.dart:291:5)
#12 _StdSink.write (dart:io/stdio.dart:341:11)
#13 Stdio._stdioWrite.<anonymous closure> (package:flutter_tools/src/base/io.dart:276:12)
#14 asyncGuard.<anonymous closure> (package:flutter_tools/src/base/async_guard.dart:111:32)
#15 _rootRun (dart:async/zone.dart:1126:13)
#16 _CustomZone.run (dart:async/zone.dart:1023:19)
#17 _runZoned (dart:async/zone.dart:1518:10)
#18 runZoned (dart:async/zone.dart:1502:12)
#19 asyncGuard (package:flutter_tools/src/base/async_guard.dart:109:3)
#20 Stdio._stdioWrite (package:flutter_tools/src/base/io.dart:275:5)
#21 Stdio.stdoutWrite (package:flutter_tools/src/base/io.dart:269:9)
#22 StdoutLogger.writeToStdOut (package:flutter_tools/src/base/logger.dart:270:48)
#23 StdoutLogger.printStatus (package:flutter_tools/src/base/logger.dart:265:5)
#24 printStatus (package:flutter_tools/src/globals.dart:128:10)
#25 TerminalHandler._commonTerminalInputHandler (package:flutter_tools/src/resident_runner.dart:1161:5)
#26 TerminalHandler.processTerminalInput (package:flutter_tools/src/resident_runner.dart:1303:13)
#27 _rootRunUnary (dart:async/zone.dart:1134:38)
#28 _CustomZone.runUnary (dart:async/zone.dart:1031:19)
#29 _CustomZone.runUnaryGuarded (dart:async/zone.dart:933:7)
#30 _BufferingStreamSubscription._sendData (dart:async/stream_impl.dart:339:11)
#31 _BufferingStreamSubscription._add (dart:async/stream_impl.dart:266:7)
#32 _SyncBroadcastStreamController._sendData (dart:async/broadcast_stream_controller.dart:377:20)
#33 _BroadcastStreamController.add (dart:async/broadcast_stream_controller.dart:252:5)
#34 _AsBroadcastStreamController.add (dart:async/broadcast_stream_controller.dart:476:11)
#35 _rootRunUnary (dart:async/zone.dart:1134:38)
#36 _CustomZone.runUnary (dart:async/zone.dart:1031:19)
#37 _CustomZone.runUnaryGuarded (dart:async/zone.dart:933:7)
#38 _BufferingStreamSubscription._sendData (dart:async/stream_impl.dart:339:11)
#39 _BufferingStreamSubscription._add (dart:async/stream_impl.dart:266:7)
#40 _SinkTransformerStreamSubscription._add (dart:async/stream_transformers.dart:70:11)
#41 _EventSinkWrapper.add (dart:async/stream_transformers.dart:17:11)
#42 _StringAdapterSink.add (dart:convert/string_conversion.dart:238:11)
#43 _StringAdapterSink.addSlice (dart:convert/string_conversion.dart:243:7)
#44 _Utf8ConversionSink.addSlice (dart:convert/string_conversion.dart:314:20)
#45 _ErrorHandlingAsciiDecoderSink.addSlice (dart:convert/ascii.dart:254:17)
#46 _ErrorHandlingAsciiDecoderSink.add (dart:convert/ascii.dart:240:5)
#47 _ConverterStreamEventSink.add (dart:convert/chunked_conversion.dart:74:18)
#48 _SinkTransformerStreamSubscription._handleData (dart:async/stream_transformers.dart:122:24)
#49 _rootRunUnary (dart:async/zone.dart:1134:38)
#50 _CustomZone.runUnary (dart:async/zone.dart:1031:19)
#51 _CustomZone.runUnaryGuarded (dart:async/zone.dart:933:7)
#52 _BufferingStreamSubscription._sendData (dart:async/stream_impl.dart:339:11)
#53 _BufferingStreamSubscription._add (dart:async/stream_impl.dart:266:7)
#54 _SyncStreamControllerDispatch._sendData (dart:async/stream_controller.dart:773:19)
#55 _StreamController._add (dart:async/stream_controller.dart:649:7)
#56 _StreamController.add (dart:async/stream_controller.dart:595:5)
#57 _Socket._onData (dart:io-patch/socket_patch.dart:1878:41)
#58 _rootRunUnary (dart:async/zone.dart:1138:13)
#59 _CustomZone.runUnary (dart:async/zone.dart:1031:19)
#60 _CustomZone.runUnaryGuarded (dart:async/zone.dart:933:7)
#61 _BufferingStreamSubscription._sendData (dart:async/stream_impl.dart:339:11)
#62 _BufferingStreamSubscription._add (dart:async/stream_impl.dart:266:7)
#63 _SyncStreamControllerDispatch._sendData (dart:async/stream_controller.dart:773:19)
#64 _StreamController._add (dart:async/stream_controller.dart:649:7)
#65 _StreamController.add (dart:async/stream_controller.dart:595:5)
#66 new _RawSocket.<anonymous closure> (dart:io-patch/socket_patch.dart:1423:33)
#67 _NativeSocket.issueReadEvent.issue (dart:io-patch/socket_patch.dart:927:14)
#68 _microtaskLoop (dart:async/schedule_microtask.dart:43:21)
#69 _startMicrotaskLoop (dart:async/schedule_microtask.dart:52:5)
#70 _runPendingImmediateCallback (dart:isolate-patch/isolate_patch.dart:118:13)
#71 _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:169:5)
```
<!-- If possible, paste the output of running `flutter doctor -v` here. -->
```
[✓] Flutter (Channel master, v1.15.4-pre.201, on Linux, locale en_US.UTF-8)
• Flutter version 1.15.4-pre.201 at /home/j0/flutter
• Framework revision 52a5311924 (5 days ago), 2020-02-27 10:41:08 -0800
• Engine revision 060a7733a6
• Dart version 2.8.0 (build 2.8.0-dev.10.0 4189237330)
[!] Android toolchain - develop for Android devices (Android SDK version 29.0.3)
• Android SDK at /home/j0/Android/Sdk
• Android NDK location not configured (optional; useful for native profiling
support)
• Platform android-29, build-tools 29.0.3
• ANDROID_HOME = /home/j0/Android/Sdk
• Java binary at: /home/j0/Downloads/android-studio/jre/bin/java
• Java version OpenJDK Runtime Environment (build
1.8.0_212-release-1586-b4-5784211)
✗ Android license status unknown.
Try re-installing or updating your Android SDK Manager.
See https://developer.android.com/studio/#downloads or visit
https://flutter.dev/setup/#android-setup for detailed instructions.
[!] Android Studio (version 3.6)
• Android Studio at /home/j0/Downloads/android-studio
✗ Flutter plugin not installed; this adds Flutter specific functionality.
✗ Dart plugin not installed; this adds Dart specific functionality.
• Java version OpenJDK Runtime Environment (build
1.8.0_212-release-1586-b4-5784211)
[✓] VS Code (version 1.41.1)
• VS Code at /usr/share/code
• Flutter extension version 3.8.1
[✓] Connected device (1 available)
• Nexus 6P • 84B7N15A07006474 • android-arm64 • Android 8.1.0 (API 27)
! Doctor found issues in 2 categories.
```
| c: crash,tool,has reproducible steps,P2,found in release: 3.0,found in release: 3.1,team-tool,triaged-tool | low | Critical |
574,855,027 | rust | [rustdoc] Fuzzy search in rustdoc should be configurable | I was in the std docs, and searched for "then" looking specifically for things that are "then" or "and_then". I ended up getting a LOT of results for "len"
I find that for things like grep, rg, search and replace, ctags, etc., when searching code, I want either exact matches, or exact machines (case insensitive).
Would it be possible to make this exact? or at least configurable?
Thanks! | T-rustdoc,C-feature-request | low | Minor |
574,859,197 | go | x/build: investigate possibility of supporting Go tests that require use of Docker in trybots/builders | We would like the trybots to be able to run a docker container.
The discovery site needs a postgres database to run tests, and we've been starting it in our CI with `docker run`.
An alternative would be to install postgres in the trybot image, but that's probably more difficult and definitely less general. | Builders,NeedsInvestigation,FeatureRequest | low | Major |
574,878,784 | TypeScript | Path based Code navigation to /index.js seems broken | - VSCode Version: 1.42.1
- OS Version: Mac OS
Steps to Reproduce:
Code navigation seems broken when you import by path and the file is actually in an index.js file.
There are a couple of scenarios relevant to developing in react-native
1. import from another package in a monorepo `import SomeComponent from 'common-lib/Router`, when the file is `packages/common-lib/src/Router/index.js`
2. import in the same package `import SomeComponent from 'modules/Router`, when the file is `src/modules/Router/index.js`
3. `import SomeComponent from 'modules/Router`, when the file is not actually index.js `src/modules/Router/index.ios.js` and `src/modules/Router/index.android.js`
In general, what works is loading a file name by name (not an index.js file)
What doesn't work is loading a file by path that is actually an index.js, index.native.js, index.ios.js, index.android.js etc file
My code structure is
```
root
packages
mobile
server
src
server
shared
common-lib
```
There is some history here that is not ideal. But ok.
packages/server jsconfig.json
```
{
"compilerOptions": {
"target": "es2017",
"allowSyntheticDefaultImports": false,
"baseUrl": ".",
"paths": {
"common-lib/*": ["../common-lib/*"],
"mobile/*": ["../mobile/*"],
"modules/*": ["./src/shared/modules/*"],
"components/*": ["./src/shared/components/*"],
"router/*": ["./src/shared/router/*"],
"server/*": ["./src/server*"],
"App": ["./src/App"]
}
},
"exclude": ["node_modules", "../../node_modules", "build"]
}
```
<!-- Launch with `code --disable-extensions` to check. -->
Does this issue occur when all extensions are disabled?: Yes
| Suggestion,Experience Enhancement | low | Critical |
574,887,848 | TypeScript | Add extract to parameter refactoring for JS/TS in vscode | <!-- 🚨 STOP 🚨 𝗦𝗧𝗢𝗣 🚨 𝑺𝑻𝑶𝑷 🚨
Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker.
Please help us by doing the following steps before logging an issue:
* Search: https://github.com/Microsoft/TypeScript/search?type=Issues
* Read the FAQ, especially the "Common Feature Requests" section: https://github.com/Microsoft/TypeScript/wiki/FAQ
-->
## Search Terms
<!-- List of keywords you searched for before creating this issue. Write them down here so that others can find this suggestion more easily -->
## Suggestion
Add a refactoring to extract to parameter for JS/TS
e.g.
for
```
const fangler = () => {
return {
someProperty: [
"a", "b"
]
}
}
```
the extract to parameter refactoring would change to
```
const fangler = (secondItem) => {
return {
someProperty: [
"a", secondItem
]
}
}
```
and populate each existing call site with the extracted value (in this example "b")
## Use Cases
It is a common refactoring when you discover that a previously fixed value should instead be provided by a caller
## Examples
e.g. in the case where I went looking for it code in a Lambda function that created a fixed header had to start providing a varying value depending on context and the easiest refactoring was to extract the currently fixed value as a parameter so that the callers that would vary it could do without breaking other callers
see https://twitter.com/mattbierner/status/1234920525543002113
## Checklist
My suggestion meets these guidelines:
* [x] This wouldn't be a breaking change in existing TypeScript/JavaScript code
* [x] This wouldn't change the runtime behavior of existing JavaScript code
* [x] This could be implemented without emitting different JS based on the types of the expressions
* [x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
* [ ] This feature would agree with the rest of [TypeScript's Design Goals](https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals).
| Suggestion,Awaiting More Feedback,Domain: Refactorings | low | Critical |
574,902,408 | go | text/template: JSEscape generates invalid JSON | ### What version of Go are you using (`go version`)?
<pre>
$ go version
go version go1.14 linux/amd64
</pre>
### Does this issue reproduce with the latest release?
Yes
### What operating system and processor architecture are you using (`go env`)?
<details><summary><code>go env</code> Output</summary><br><pre>
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/shang/.cache/go-build"
GOENV="/home/shang/.config/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GONOPROXY="*.epic.com"
GONOSUMDB="*.epic.com"
GOOS="linux"
GOPATH="/home/shang/go"
GOPRIVATE="*.epic.com"
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build973203171=/tmp/go-build -gno-record-gcc-switches"
</pre></details>
### What did you do?
Ran this code:
```
package main
import (
"log"
"os"
"text/template"
)
func main() {
const plate = `"{{ .Value | js}}"`
type Vals struct {
Value string
}
vals := &Vals{`=`}
t := template.Must(template.New("plate").Parse(plate))
err := t.Execute(os.Stdout, vals)
if err != nil {
log.Println("executing template:", err)
}
}
```
### What did you expect to see?
Expected to see `"="`, which is the behavior in `go1.13.8`
### What did you see instead?
Insead see `"\x3D"`.
| NeedsInvestigation | low | Critical |
574,905,367 | TypeScript | Inference from rest parameters has strange inconsistent results | ```ts
declare function foo(...x: readonly any[]): any
type FooParams = Parameters<typeof foo>;
declare function bar(...x: readonly number[]): any
type BarParams = Parameters<typeof bar>
```
**Expected**:
* `FooParams` is `any[]` or `readonly any[]`
* `BarParams` is `number[]` or `readonly number[]`
**Actual**
* `FooParams` is `unknown[]`
* `BarParams` is `never`
[Playground link](http://www.typescriptlang.org/play/index.html#code/PTAEHUEsBcAsHsCu1QCcCmBDAJvAdgDYCeAsAFDnboDGBmGoAZontdJPk-PABQB0AgB4AuUJjxEA2gF0AlKPGkKZaEQAO6UADFuABXqYAtgGdQAXlD7UR9NHSpjAHlUb4jLvAB8AbnKUadAzMrOycAEb0-EKieIiGYfYy8mISfirqmgBC9FZGpha5hrb2Ti7obqARqJ5pIBAwsGhYuIRK-rT0msFsHHhojNxRfCJNOPjEKVJyCqnKZaAASjrwhfmWBkV2Ds4ZFagDXr7KVB1BLD2cqFVDIxhjraCx8YnTk2nzC9moq+br1pslHaudxXeg1MhAA) | Needs Investigation | low | Major |
574,982,380 | flutter | Add platform screenshot capability to package:integration_test | add screenshot capability to e2e web integration tests.
These screenshots should be easy to trigger from the widget tests, but should be taken on the platform (by the browser's driver).
| a: tests,c: new feature,framework,customer: crowd,c: proposal,f: integration_test,P1,team-framework,triaged-framework | medium | Critical |
574,989,508 | node | Docs only shows version subset in navigation | * **Browser version**: Chrome Version 80.0.3987.106
* **Operating system**: macOS 10.14
When viewing a given API reference on the website, there's an option to view another version:
<img width="688" alt="Screen Shot 2020-03-03 at 11 13 02 AM" src="https://user-images.githubusercontent.com/2036040/75810734-fac8ae00-5d3f-11ea-9e10-0de3e19b1826.png">
It allows for a user to pick another version to swap to and see relevant docs, but it's constrained by what existed at the time the _currently chosen doc_ was written. This means that e.g when a user picks v11.x, they won't be able to go back to v13.x:
<img width="732" alt="Screen Shot 2020-03-03 at 11 14 25 AM" src="https://user-images.githubusercontent.com/2036040/75810846-32375a80-5d40-11ea-97a0-23c7e06e0b30.png">
without first going back to v12.x.
I'd say this is an antipattern, and that we should unilaterally be storing the versions available in the most recently defined major line. If this seems like a good path forward, i'm happy to implement this myself!
| doc,meta | medium | Major |
574,993,073 | flutter | Engine repo should be able to run tests that depends on the framework. | This issue tracks the effort of making engine repo run flutter driver and e2e tests.
Flutter driver integration tests are not currently set up to be run in the engine.
When we fix engine code that is not directly testable in the engine, for example, platform view related code. We would need to create an integration test in the framework. The test won't run until the engine fix rolled into the framework. This creates a delay to find out whether the engine fix breaks tests.
Although not every integration test can be tested in engine, the ones that merely exists for engine behaviors should be run in the engine repo. Such tests include `flutter_driver_screenshot_test` as the time this issue is created.
Setting up flutter driver/e2e tests in engine can also help testing in engine easier. We currently use the [scenario app](https://github.com/flutter/engine/tree/master/testing/scenario_app) to run integration tests in engine. Although the `scenario app` can handle simple cases like screenshot and touch events, it is hard to wire up a test in the `scenario app` that handles complicated situations such as thread merging. The `scenario app` test case is much harder to write compares to flutter driver tests or e2e tests.
There is already a [ci script](https://github.com/flutter/engine/blob/master/.cirrus.yml#L19) in engine repo to fetch the framework for web team to run web related tests. We should be able to do something similar for mobiles and other platforms.
| framework,engine,c: proposal,P3,team-engine,triaged-engine | low | Major |
575,018,560 | TypeScript | Release Automation Meta Issue | We're trying to find ways to reduce the amount of manual work that a release requires. This currently includes
* [x] https://github.com/microsoft/TypeScript/issues/36863
* [ ] https://github.com/microsoft/TypeScript/issues/36864
* [ ] https://github.com/microsoft/TypeScript/issues/34818
More may be added to this list over time | Infrastructure,Meta-Issue | low | Minor |
575,023,722 | pytorch | END_HANDLE_TH_ERRORS_PYBIND prevents pybind11 Exception translation | ## 🐛 Bug
[pybind11 allows exception translation](https://pybind11.readthedocs.io/en/stable/advanced/exceptions.html#built-in-exception-translation) by [catching and translating C++ exceptions](https://github.com/pybind/pybind11/blob/1376eb0e518ff2b7b412c84a907dd1cd3f7f2dcd/include/pybind11/detail/internals.h#L215). This is similar to what we do within [END_HANDLE_TH_ERRORS_PYBIND](https://github.com/pytorch/pytorch/blob/4b3ae7e0af17cfaab832fd7954f5bfad07cee0ba/torch/csrc/Exceptions.h#L82) as well, in the sense that we also inspect the thrown type and handle it differently in some cases (e.g. py::builtin_exception). However, due to CATCH_ALL_ERRORS we prevent pybind from catching something like a std::out_of_range and instead bubble up a PyExc_RuntimeError. For the pybind11 user that's writing code out of tree and uses wrap_pybind_function as exception translation for at:: specific errors this means they have to setup their own translation within the wrapped function to get the proper error.
## To Reproduce
To reproduce this behavior register a simple pybind11 function that throws out_of_range and see it turn into RuntimeError and not IndexError. I can provide a code snippet if needed.
## Expected behavior
I'd expect us to simply forward the exception and rely on pybind11 to do the proper translation for the listed functions, so we can simply forward them. I think this is ok, because END_HANDLE_TH_ERROR_PYBIND is explicitly written for pybind11.
## Environment
```
$ python torch/utils/collect_env.py
Collecting environment information...
PyTorch version: 1.5.0a0+45c4519
Is debug build: Yes
CUDA used to build PyTorch: Could not collect
OS: Ubuntu 18.04.3 LTS
GCC version: (Ubuntu 7.4.0-1ubuntu1~18.04.1) 7.4.0
CMake version: version 3.12.2
Python version: 3.7
Is CUDA available: No
CUDA runtime version: 9.2.88
GPU models and configuration:
GPU 0: Quadro GP100
GPU 1: Quadro GP100
Nvidia driver version: 418.116.00
cuDNN version: Could not collect
Versions of relevant libraries:
[pip3] gpytorch==0.2.1
[pip3] numpy==1.16.4
[pip3] torch==1.5.0a0+45c4519
[pip3] torchvision==0.6.0a0+0156d58
[conda] blas 1.0 mkl
[conda] gpytorch 0.2.1 pypi_0 pypi
[conda] magma-cuda100 2.5.0 1 pytorch
[conda] mkl 2019.4 243
[conda] mkl-include 2019.4 243
[conda] mkl-service 2.3.0 py37he904b0f_0
[conda] mkl_fft 1.0.15 py37ha843d7b_0
[conda] mkl_random 1.1.0 py37hd6b4f25_0
[conda] torch 1.5.0a0+45c4519 dev_0 <develop>
[conda] torchvision 0.6.0a0+0156d58 dev_0 <develop>
```
Compiled from source
## Additional context
This showed up in the context of porting [NestedTensor.to_tensor into C++](https://github.com/pytorch/nestedtensor/pull/74). | triaged,module: pybind | low | Critical |
575,030,805 | flutter | CupertinoBar color does not update with brightness, for dark mode. | <!-- Thank you for using Flutter!
If you are looking for support, please check out our documentation
or consider asking a question on Stack Overflow:
* https://flutter.dev/
* https://api.flutter.dev/
* https://stackoverflow.com/questions/tagged/flutter?sort=frequent
If you have found a bug or if our documentation doesn't have an answer
to what you're looking for, then fill our the template below. Please read
our guide to filing a bug first: https://flutter.dev/docs/resources/bug-reports
-->
## Steps to Reproduce
<!-- You must include full steps to reproduce so that we can reproduce the problem. -->
1. Run `flutter create bug`.
2. Update the main.dart as follows:
```
import 'package:flutter/cupertino.dart';
import 'package:flutter/material.dart';
void main() => runApp(MyApp());
class MyApp extends StatelessWidget {
@override
Widget build(BuildContext context) {
return MaterialApp(
title: 'Flutter Demo',
theme: ThemeData(
cupertinoOverrideTheme:
const CupertinoThemeData(brightness: Brightness.dark),
primarySwatch: Colors.blue,
),
home: MyHomePage(title: 'Flutter Demo Home'),
);
}
}
class MyHomePage extends StatefulWidget {
MyHomePage({Key key, this.title}) : super(key: key);
final String title;
@override
_MyHomePageState createState() => _MyHomePageState();
}
class _MyHomePageState extends State<MyHomePage> {
int _counter = 0;
void _incrementCounter() {
setState(() {
_counter++;
});
}
@override
Widget build(BuildContext context) {
return Scaffold(
appBar: AppBar(
title: Text(widget.title),
),
body: Center(
child: Column(
mainAxisAlignment: MainAxisAlignment.center,
children: <Widget>[
Text(
'You have pushed the button this many times:',
),
Text(
'$_counter',
style: Theme.of(context).textTheme.display1,
),
],
),
),
floatingActionButton: FloatingActionButton(
onPressed: _incrementCounter,
tooltip: 'Increment',
child: Icon(Icons.add),
),
bottomNavigationBar: CupertinoTabBar(
items: [
BottomNavigationBarItem(
icon: Icon(Icons.ac_unit),
title: Text('AC'),
),
BottomNavigationBarItem(
icon: Icon(Icons.access_alarm),
title: Text('Alarm'),
),
],
)
);
}
}
```
**Expected results:** <!-- what did you want to see? -->
If brightness is Light, the status bar icons should be black or viceversa. If brightness is Black, app bar should be black.
```
cupertinoOverrideTheme:
const CupertinoThemeData(brightness: Brightness.dark),
```
**Actual results:** <!-- what did you see? -->
Only the CupertinoTabBar is updating if overriding, if not overriding but dark theme is on it works too but no the app bar.
<details>
<summary>Logs</summary>
<!-- Finally, paste the output of running `flutter doctor -v` here. -->
Flutter Doctor
```
[✓] Flutter (Channel stable, v1.12.13+hotfix.8, on Mac OS X 10.15.3 19D76, locale en-CO)
• Flutter version 1.12.13+hotfix.8 at /Users/nicolas.villamizar/flutter
• Framework revision 0b8abb4724 (3 weeks ago), 2020-02-11 11:44:36 -0800
• Engine revision e1e6ced81d
• Dart version 2.7.0
[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.3)
• Android SDK at /Users/nicolas.villamizar/Library/Android/sdk
• Android NDK location not configured (optional; useful for native profiling support)
• Platform android-29, build-tools 29.0.3
• Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
• Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b4-5784211)
• All Android licenses accepted.
[✓] Xcode - develop for iOS and macOS (Xcode 11.3.1)
• Xcode at /Applications/Xcode.app/Contents/Developer
• Xcode 11.3.1, Build version 11C504
• CocoaPods version 1.8.4
[✓] Android Studio (version 3.6)
• Android Studio at /Applications/Android Studio.app/Contents
• Flutter plugin version 43.0.2
• Dart plugin version 192.7761
• Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b4-5784211)
[✓] VS Code (version 1.42.1)
• VS Code at /Applications/Visual Studio Code.app/Contents
• Flutter extension version 3.8.1
[✓] Connected device (1 available)
• iPhone 11 • A27B9117-A941-4F9F-8177-60DEA19279F7 • ios • com.apple.CoreSimulator.SimRuntime.iOS-13-3 (simulator)
• No issues found!
```
</details>
| framework,f: cupertino,has reproducible steps,found in release: 3.3,found in release: 3.7,team-design,triaged-design | medium | Critical |
575,032,351 | PowerToys | [Shortcut Guide] App specific guide for foreground app | App specific shortcut guide for any configured app using a modifier + foreground running application.
The Shortcut Guide would function normally with the Windows key long press, but what if you added a modifier key and getting an app specific Shortcut Guide to load when pressing a modifier key whilst the app X is in the foreground.
Example: PhotoShop is running in the foreground, you press Windows+Alt+P and it loads all of the PS shortcuts just like the normal Shortcut Guide.
A catalogue of popular applications would need to be built and people could easily contribute to popular applications using a template.
| Idea-Enhancement,Product-Shortcut Guide | low | Major |
575,036,269 | rust | [libs] add recursive variant of `fs::read_dir` | ## Motivation
As part of the [`fs` module](https://doc.rust-lang.org/std/fs/index.html) there exist various recursive and non-recursive operations. `create_dir` and `create_dir_all`. `remove_dir` and `remove_dir_all`. But to read the contents of a directory there currently only exists [`read_dir`](https://doc.rust-lang.org/std/fs/fn.read_dir.html), but no recursive counterpart:
|Action Kind| Base function | Recursive variant
|---| -- | -- |
| Create a directory| `fs::create_dir` | `fs::create_dir_all` |
| Remove a directory | `fs::remove_dir` | `fs::remove_dir_all` |
| Read a directory's contents | `fs::read_dir` | ... |
I noticed the omission of this method when trying to read out a directory recursively, and discovered this was the only directory operation that doesn't have a recursive counterpart.
## Usage overview
I'd imagine `fs::read_dir_all` would be used in much the same way as `fs::read_dir`:
```rust
for entry in fs::read_dir_all(dir)? {
let entry = entry?;
dbg!(entry.path());
}
```
## Implementation overview
Roughly the API additions to `std::fs` would look like this:
```rust
#[derive(Debug)]
pub struct ReadDirAll;
impl Iterator for ReadDirAll {
type Item = Result<DirEntry>;
}
pub fn read_dir_all<P: AsRef<Path>>(path: P) -> Result<ReadDirAll>;
```
## Potential drawbacks
I remember reading something about the [`readdir(3)` syscall](https://linux.die.net/man/3/readdir), and a file filtering as part of the kernel. But I can't seem to find any reference to that anymore. I also thought this had been referenced in a prior RFC, but that too I cannot find.
But for argument's sake, even if there was a variant for `readdir` variant that took a filter I'd argue that since `std::fs::read_dir` doesn't provide filtering, neither should `std::fs_read_dir_all`. And if we'd want a variant that *does* provide filtering, it would not be a clean counterpart to `fs::read_dir`, so it would warrant introducing under a new name.
These functions should be able to co-exist with each other, much the same way `fs::read_to_string` and `io::Read::read_to_string` co-exist (both useful, but is a simplified version of the other).
## Similar functionality in other languages
- __C++__ has [`std::filesystem::recursive_directory_iterator`](https://en.cppreference.com/w/cpp/filesystem/recursive_directory_iterator) since C++ 17.
- __nodejs__ doesn't include this as part of core, but the [readdirp](https://www.npmjs.com/package/readdirp) package in userland has [over half a billion](https://img.shields.io/npm/dt/readdirp.svg?style=flat-square) downloads indicating there's interest in this functionality.
- __bash__ has the `find` command generally available. `$ find .` will recursively print out all directory contents.
- And more entries can be found as part of [rosetta code](https://rosettacode.org/wiki/Walk_a_directory/Recursively).
## Conclusion
I think `fs::read_dir_all` makes for a straight forward addition to the stdlib. People expect this functionality to exist by default, and the shape and name of this function doesn't seem controversial. Even if filtering supersets of this functionality could possibly exist, they would likely be a different shape, and could co-exist with this function. Thanks! | T-libs-api,C-feature-request | medium | Critical |
575,170,636 | rust | riscv: unable to use atomics with linker-plugin-lto | <!--
Thank you for filing a bug report! 🐛 Please provide a short summary of the bug,
along with any information you feel relevant to replicating the bug.
-->
The following code compiles fine without `linker-plugin-lto`, but fails to compile when it is enabled:
```rust
#![no_std]
#![no_main]
use core::sync::atomic::{AtomicUsize, Ordering};
static MM_HANDLE_COUNT: AtomicUsize = AtomicUsize::new(0);
#[no_mangle]
pub extern "C" fn _start() -> ! {
let _count = MM_HANDLE_COUNT.fetch_add(1, Ordering::SeqCst);
loop {}
}
use core::panic::PanicInfo;
#[panic_handler]
fn handle_panic(_arg: &PanicInfo) -> ! {
loop {}
}
#[no_mangle]
pub extern "C" fn abort() -> ! {
loop {}
}
```
This code should compile cleanly with:
```sh
$ rustc +nightly main.rs --target riscv64gc-unknown-none-elf
$
```
However, with the lto plugin, it doesn't compile:
```sh
$ rustc +nightly -C linker-plugin-lto main.rs --target riscv64gc-unknown-none-elf error: linking with `rust-lld` failed: exit code: 1
|
= note: "rust-lld" "-flavor" "gnu" "-plugin-opt=O0" "-plugin-opt=mcpu=generic-rv64" "-L" "/home/user/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/riscv64gc-unknown-none-elf/lib" "main.main.7rcbfp3g-cgu.0.rcgu.o" "main.main.7rcbfp3g-cgu.1.rcgu.o" "main.main.7rcbfp3g-cgu.2.rcgu.o" "-o" "main" "--gc-sections" "-L" "/home/user/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/riscv64gc-unknown-none-elf/lib" "-Bstatic" "/home/user/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/riscv64gc-unknown-none-elf/lib/librustc_std_workspace_core-a43e904133f39ebe.rlib" "/home/user/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/riscv64gc-unknown-none-elf/lib/libcore-de86a0d6e9117873.rlib" "/home/user/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/riscv64gc-unknown-none-elf/lib/libcompiler_builtins-980292810b049237.rlib" "-Bdynamic"
= note: rust-lld: error: undefined symbol: __atomic_fetch_add_8
>>> referenced by main.7rcbfp3g-cgu.2
>>> lto.tmp:(core::sync::atomic::AtomicUsize::fetch_add::h6aa949cc8cd90341)
error: aborting due to previous error
$
```
### Meta
<!--
If you're using the stable version of the compiler, you should also check if the
bug also exists in the beta or nightly versions.
-->
`rustc --version --verbose`:
```
rustc 1.43.0-nightly (4ad624882 2020-03-03)
binary: rustc
commit-hash: 4ad62488258972bdb0e2df225d100f99ef58dbad
commit-date: 2020-03-03
host: x86_64-unknown-linux-gnu
release: 1.43.0-nightly
LLVM version: 9.0
```
This occurs on both `riscv64gc-unknown-none-elf` and `riscv32imac-unknown-none-elf`. | A-linkage,T-compiler,C-bug,WG-embedded,A-atomic | low | Critical |
575,197,216 | opencv | imread（3.4.8version） can not read old version jpg\png。may be JPEG ver 90 do not support ver62? | <!--
If you have a question rather than reporting a bug please go to http://answers.opencv.org where you get much faster responses.
If you need further assistance please read [How To Contribute](https://github.com/opencv/opencv/wiki/How_to_contribute).
Please:
* Read the documentation to test with the latest developer build.
* Check if other person has already created the same issue to avoid duplicates. You can comment on it if there already is an issue.
* Try to be as detailed as possible in your report.
* Report only one problem per created issue.
This is a template helping you to create an issue which can be processed as quickly as possible. This is the bug reporting section for the OpenCV library.
-->
##### System information (version)
<!-- Example
- OpenCV => 3.1
- Operating System / Platform => Windows 64 Bit
- Compiler => Visual Studio 2015
-->
- OpenCV => :grey_question:3.4.8
- Operating System / Platform => :grey_question:win 10
- Compiler => :grey_question:vs 2013
##### Detailed description
<!-- your description -->
##### Steps to reproduce
<!-- to add code example fence it with triple backticks and optional file extension
```.cpp
// C++ code example
```
or attach as .txt or .zip file
-->
| incomplete | low | Critical |
575,223,802 | godot | Strange flickering when Timer calls a function that adds an animated label | **Godot version:**
3.2
**OS/device including version:**
Windows 10 v1909
**Issue description:**
When calling a function that dynamically creates a ui object that shows text which is animated with a tween, it shows ok. But if a timer calls the function, it flickers.
**Steps to reproduce:**
unzip the project,and run it in godot.
Click test 1 (several times if you like). It will show some animated text to the right without flicker.
Click test 2 (several times if you like) it will show some animated text to the right, but with flicker.
**Minimal reproduction project:**
[TestProject.zip](https://github.com/godotengine/godot/files/4286131/TestProject.zip)
**Other notes**
I have brain stormed this with someone on Discord. I got it to not flicker by setting the modulate's alpha channel to 0 on the label on the test object scene. | bug,confirmed,topic:gui | low | Minor |
575,239,812 | rust | std::env members need to document "process global" risks. | I've hit a few bugs in various crate test suites where 2 different tests both modify POSIX ENV, and then execute code and assertions based on those changes.
Often, this works simply due to the code being fast enough, but you can randomly get weird failures due to the data races in `ENV`, due to `ENV` being shared between threads.
But I don't see any documentation pointing out either:
a. That this risk occurs
b. How this risk occurs
c. How to manage this risk.
The best I see is: https://doc.rust-lang.org/nightly/std/env/fn.set_var.html
But its current prose of "Note that while concurrent access to environment variables is safe in Rust" can give the false impression that there isn't any problem to manage here unless one is doing FFI.
It needs to be more explicit, and highlight that you can trip into this when writing just plain ol' rust without anything fancy, with no external crates, and no custom ffi code.
( And probably needs to be mentioned at a higher level, like https://doc.rust-lang.org/nightly/std/env/index.html )
In tests, its especially spicy, as a test failing (which is ultimately a panic!), results in the Mutex becoming poisoned, which, if not managed properly in the tests, results in all tests that need to lock `ENV`, also failing with confusing errors, due to said poisoning.
There's already 2 PR's where I've submitted working solutions for this, and perhaps some of the strategies I've used could be used as a baseline for some documented guidance.
( Personally I wish rust wrapped the `env` access controls to protect code against this sort of problem, but asking for that is a bit of a tall order for me, so a documentation solution is better than nothing )
: https://github.com/sagiegurari/ci_info/pull/9
: https://github.com/seanmonstar/reqwest/pull/837
| C-enhancement,T-libs-api,A-docs,A-process | low | Critical |
575,269,559 | pytorch | Support vars/__dict__ on torch.return_types tuples e.g. topk | It is sometimes useful to convert them to dict (for custom serialization purposes) and supporting `__dict__` method would be an idiomatic solution | triaged,enhancement | low | Major |
575,274,277 | go | runtime: ThreadSanitizer failed to allocate / CHECK failed | ### What version of Go are you using (`go version`)?
<pre>
$ go version
go version go1.14 linux/amd64
</pre>
### Does this issue reproduce with the latest release?
Yes
### What operating system and processor architecture are you using (`go env`)?
<details><summary><code>go env</code> Output</summary><br><pre>
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/nfs/users/nfs_s/sb10/.cache/go-build"
GOENV="/nfs/users/nfs_s/sb10/.config/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/nfs/users/nfs_s/sb10/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/software/vertres/installs/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/software/vertres/installs/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="0"
GOMOD="/nfs/users/nfs_s/sb10/src/go/github.com/VertebrateResequencing/wr/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build484982129=/tmp/go-build -gno-record-gcc-switches"
$ free -m
total used free shared buff/cache available
Mem: 135359 19962 78221 28 37175 114236
Swap: 223231 38 223193
</pre></details>
### What did you do?
<pre>
git clone https://github.com/sb10/wr.git
cd wr
git checkout ThreadSanitizer
CGO_ENABLED=1 go test -p 1 -tags netgo -race --count 1 -gcflags=all=-d=checkptr=0 ./jobqueue -run TestJobqueueRunners -v
</pre>
### What did you expect to see?
Tests should pass cleanly the same way they do without race (`go test -p 1 -tags netgo --count 1 ./jobqueue -run TestJobqueueRunners -v`).
### What did you see instead?
Variations on:
<pre>
ERROR: ThreadSanitizer failed to allocate 0x28000 (163840) bytes of sync allocator (error code: 12)
FATAL: ThreadSanitizer CHECK failed: ./gotsan.cpp:7064 "((0 && "unable to mmap")) != (0)" (0x0, 0x0)
</pre>
Which exits the test. It happens during a seemingly random test each attempt.
Additional info:
- As mentioned, no problems with race detection disabled.
- Problem also happens with go1.13.8, didn't check other versions.
- Problem goes away if I revert usage of `github.com/sasha-s/go-deadlock` back to `sync`, but I want to run go-deadlock in production to catch deadlock bugs that my tests aren't finding.
As a bad interaction between go-deadlock and the go race detector, I have no idea how to debug this. | NeedsInvestigation,compiler/runtime | low | Critical |
575,288,541 | go | net: Interfaces() does not return all interfaces on Windows | <!-- Please answer these questions before submitting your issue. Thanks! -->
### What version of Go are you using (`go version`)?
<pre>
$ go version
go version go1.13.4 linux/amd64
</pre>
### Does this issue reproduce with the latest release?
Y
### What operating system and processor architecture are you using (`go env`)?
<details><summary><code>go env</code> Output</summary><br><pre>
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/root/.cache/go-build"
GOENV="/root/.config/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/root/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/lib/golang"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/lib/golang/pkg/tool/linux_amd64"
GCCGO="gccgo"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build467654165=/tmp/go-build -gno-record-gcc-switches"
</pre></details>
### What did you do?
<!--
If possible, provide a recipe for reproducing the error.
A complete runnable program is good.
A link on play.golang.org is best.
-->
I am trying to use `net.Interfaces()` to get all interfaces on Windows, however, some interfaces can only display using Wireshark.
### What did you expect to see?
If Wireshark was able to display an interface on Windows, net.Interfaces() can also do the same.
### What did you see instead?
Some interfaces can be seen using Wireshark on Windows, which cannot been seen by `net.Interfaces()`.
| NeedsInvestigation | low | Critical |
575,331,189 | godot | Mono: AutoLoad inheriting Node still gives error: Script does not inherit a Node | ___
***Bugsquad note:** This issue has been confirmed several times already. No need to confirm it further.*
___
**Godot version:**
3.2 stable mono
**OS/device including version:**
Debian 10
**Issue description:**
```
E 0:00:00.662 start: Script does not inherit a Node: res://AutoLoad/GodotUtilities.cs
<C++ Error> Condition "!valid_type" is true. Continuing.
<C++ Source> main/main.cpp:1693 @ start()
```
```
E 0:00:00.666 start: Script does not inherit a Node: res://AutoLoad/Pool.cs
<C++ Error> Condition "!valid_type" is true. Continuing.
<C++ Source> main/main.cpp:1693 @ start()
```
**Steps to reproduce:**
```
namespace GodotUtilities
{
public class Log : Node
{
```
```
public class Pool<T> : Node where T : new()
{
```
**Minimal reproduction project:**
NA | bug,confirmed,topic:dotnet | high | Critical |
575,342,425 | flutter | [camera] Support for multiple cameras at once | I am trying to initialize multiple cameras at once just like a [bothie feature in nokia phones](https://www.lifewire.com/what-is-a-bothie-4158927),
<img src="https://images-eu.ssl-images-amazon.com/images/G/31/img17/Wireless/CEEX/Nokia8/ingress/1._CB514833683_.jpg" width=400>
As of now only one camera can be initialized at a time and other camera gets disposed off automatically, And also when I print the available cameras length it always prints 2 even though my device has three cameras in the back and a camera in the front, Is there any specific reason to that?.
This is how one of the camera gets disabled (Green Area) on initializing multiple cameras at once.The Sample image shows a screen with two halves the upper part for the primary camera (camera[0]) and lower for the secondary camera (camera[1] which is disposed)
<img src="https://user-images.githubusercontent.com/31410839/75876636-10230280-5e3c-11ea-96ff-3b277dd65fc8.jpg" width=400>
| c: new feature,customer: crowd,p: camera,package,team-ecosystem,P3,triaged-ecosystem | high | Critical |
575,347,606 | pytorch | [docs] Unclear arg spec for torch.full | https://pytorch.org/docs/master/torch.html?highlight=torch%20full#torch.full
`fill_value – the number to fill the output tensor with.`
the arg spec or the arg description doesn't specify if the "number" must be Python scalar or if Torch scalar is also fine. It also doesn't specify if the device of the Torch scalar must match the device passed to the `full(...)` call and if gradient to `fill_value` is backpropped, Wording `number` is quite vague.
Also argument name `size` is used - maybe better to replace it with `shape`? `shape` property name was adopted long time ago, and even NumPy uses `shape` in the similar method: https://docs.scipy.org/doc/numpy/reference/generated/numpy.full.html | module: docs,triaged,module: numpy | low | Minor |
575,352,053 | go | x/mobile: gomobile version doesn't work when not checked out under GOPATH or not built in GOPATH mode |
### What version of Go are you using (`go version`)?
<pre>
$ go version
go version go1.13.4 linux/amd64
</pre>
### Does this issue reproduce with the latest release?
yes
### What operating system and processor architecture are you using (`go env`)?
amd64
linux
### What did you do?
gomobile version
gomobile version unknown: mobile repo git log failed: exit status 128, fatal: not a git repository (or any of the parent directories): .git
| NeedsInvestigation,mobile | low | Critical |
575,352,272 | TypeScript | JSDoc: @inheritDoc disregards optionality of parameters from parent class method | <!-- 🚨 STOP 🚨 𝗦𝗧𝗢𝗣 🚨 𝑺𝑻𝑶𝑷 🚨
Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Even if you think you've found a *bug*, please read the FAQ first, especially the Common "Bugs" That Aren't Bugs section!
Please help us by doing the following steps before logging an issue:
* Search: https://github.com/Microsoft/TypeScript/search?type=Issues
* Read the FAQ: https://github.com/Microsoft/TypeScript/wiki/FAQ
Please fill in the *entire* template below.
-->
<!--
Please try to reproduce the issue with the latest published version. It may have already been fixed.
For npm: `typescript@next`
This is also the 'Nightly' version in the playground: http://www.typescriptlang.org/play/?ts=Nightly
-->
**TypeScript Version:** 3.8.3
<!-- Search terms you tried before logging this (so others can find this issue more easily) -->
**Search Terms:** inheritDoc optionality jsdoc
**Code**
A conceptual example of JSDoc-annotated ES6 classes I'm generating `d.ts` definitions for
```js
class Base {
/**
* @abstract
* @param {Array<import("./Layer.js").default>} [opt_array] Array of layers (to be
* modified in place).
* @return {Array<import("./Layer.js").default>} Array of layers.
*/
getLayersArray(opt_array) {
return abstract();
}
}
class Derived extends Base {
/**
* @inheritDoc
*/
getLayersArray(opt_array) {
return [];
}
}
```
**Expected behavior:**
TypeScript to transpile this to something resembling this
```ts
declare class Base {
/**
* @abstract
* @param {Array<import("./Layer.js").default>} [opt_array] Array of layers (to be
* modified in place).
* @return {Array<import("./Layer.js").default>} Array of layers.
*/
getLayersArray(opt_array?: any[]): any[];
}
declare class Derived extends Base {
/**
* @inheritDoc
*/
getLayersArray(opt_array?: any): any[];
}
```
**Actual behavior:**
The optionality specifier is lost on `Derived.getLayersArray`
```ts
declare class Base {
/**
* @abstract
* @param {Array<import("./Layer.js").default>} [opt_array] Array of layers (to be
* modified in place).
* @return {Array<import("./Layer.js").default>} Array of layers.
*/
getLayersArray(opt_array?: any[]): any[];
}
declare class Derived extends Base {
/**
* @inheritDoc
*/
getLayersArray(opt_array: any): any[];
}
```
**Playground Link:** <!-- A link to a TypeScript Playground "Share" link which demonstrates this behavior -->
https://www.typescriptlang.org/play/?useJavaScript=true#code/MYGwhgzhAEBCkFNoG8CwAoa0D0AqXGW0u0AAmAEYQAuATmMNYViaQA5j0C2KAgrfQCeAHgCWXNgHta1ABQAiAHTYAMmEEJaigFYR5ASkUATBADMwAVxDUAfAF9oAbUltqAfU5CAutH5DokqbQ4Bq0MLLUktAUCMzERFhckkaipqIIRtCiAHbQbODACIZxrLQI1Ba0uch+6mIS0nJKquqaOnqGJuZWtg61ggFBIZoQiiXYzADm5WqhEP2yLu6e6voocdBlFVXQlDT0jLL6ANzMdhjn6BigkDAAIpqiAG4Z0AgAHtQI2UYw8BBINCYHD4EpkHIAC0e1DukmA4ymM1aYQWSw8AlW62BCS2lVyji8p2BlzsQA
**Related Issues:** <!-- Did you find other bugs that looked similar? -->
EDIT: In the original ES6 example, the class `Derived` didn't actually extend `Base` which led to the possibility I may have submitted an invalid report. Fixing the code sample and re-running the playground with the updated example ES6 code showed the problem to still persist. Code sample in this issue and playground link have been updated. | Bug,Effort: Difficult,Domain: JSDoc,feature-request | low | Critical |
575,415,766 | neovim | :redir terminated by signal SIGABRT | <!-- Before reporting: search existing issues and check the FAQ. -->
- `nvim --version`: `NVIM v0.5.0-415-gf8f41d088`
- `vim -u DEFAULTS` (version: 8.1.2292) works
- Operating system/version: osx Catalina
### Steps to reproduce using `nvim -u NORC`
```
nvim -u NORC -c 'redir @*| exe "!ls" | redir END'
```
### Actual behaviour
```
'nvim -u NORC -c 'redir @*| exe…' terminated by signal SIGABRT (Abort)
```
### Expected behaviour
`redir` works | bug | low | Minor |
575,436,795 | TypeScript | Guidance on reducing heap usage of large typings? | I maintain google/schema-dts which generates typings for schema.org JSON-LD. The generated typings are ~10k loc and involves a lot of type unions (e.g. Thing can be Organization or CreativeWork or Person or ...), and these can get pretty nested.
Compiling these works for me and the vast majority of users. But I get constant reports of JavaScript heap OOM errors from users consuming the typings. See google/schema-dts#34. I haven't been able to repro this at all, but I'm still hoping for some guidance on getting a better memory footprint for the type checker.
FYI, the .d.ts file looks something like this: https://unpkg.com/[email protected]/schema.d.ts
Questions (I'd take answers to any of these):
1. Are there better strategies for writing these in a more memory friendly way? e.g. naming intermediate types, or declaring all properties in one huge object and defining respective types in terms of `Pick<>`?
2. Are there any profiling tools that anyone would recommend using to track this down?
3. any other advice is appreciated.
Unfortunately splitting the types up isn't an option (at least not obviously) because the types are deeply self referential. | Docs | low | Critical |
575,440,939 | godot | Instancing certain scenes in threads is extremely slow | **Godot version:**
3.2.stable.official
**OS/device including version:**
Ubuntu 19
**Issue description:**
When calling `load(path).instance()` in a thread, I would expect the performance to be similar as outside of a thread, maybe slightly slower. With certain scenes, this is the case. For example, instancing a scene with a simple Node or a Spatial only takes 1.5x-2x longer in a thread than on the main thread.
However, with other scenes, this is not the case at all. Instancing a scene with, for example, a Node2D or a MeshInstance in the main thread is completely fine and fast, but doing so in a separate thread takes about 100x as long as in the main thread!
In addition, I have noticed that calling `wait_to_finish()` on such a thread is completely blocking, seemingly forever.
**Steps to reproduce:**
Instance a scene with a MeshInstance or a Node2D (likely others too, have only tested a few) in a thread and measure the time it takes with `OS.get_ticks_usec()`.
**Minimal reproduction project:**
[slow-thread-instancing.zip](https://github.com/godotengine/godot/files/4287638/slow-thread-instancing.zip)
Start the project and check the logs. On my machine, the second iteration ("Slow scene", "Threaded") takes much longer, about 100x as long.
| topic:core,confirmed,performance | low | Major |
575,463,920 | rust | false negative unused_mut: if let x .. = &mut | ````rust
fn main() {
let mut word = "hello".to_string();
if let Some(_) = &mut word.chars().last() { // here
word.push_str(" word");
}
println!("{}", word);
}
````
In this example, the `mut` in `if let Some(char) = &mut word.chars().last() {` is redundant but the compiler issued no warning.
`rustc 1.43.0-nightly (4ad624882 2020-03-03)` | A-lints,A-borrow-checker,T-compiler,C-bug | low | Minor |
575,545,748 | youtube-dl | Site support request : NRJ.fr (podcasts) | <!--
######################################################################
WARNING!
IGNORING THE FOLLOWING TEMPLATE WILL RESULT IN ISSUE CLOSED AS INCOMPLETE
######################################################################
-->
## Checklist
<!--
Carefully read and work through this check list in order to prevent the most common mistakes and misuse of youtube-dl:
- First of, make sure you are using the latest version of youtube-dl. Run `youtube-dl --version` and ensure your version is 2020.03.01. If it's not, see https://yt-dl.org/update on how to update. Issues with outdated version will be REJECTED.
- Make sure that all provided video/audio/playlist URLs (if any) are alive and playable in a browser.
- Make sure that site you are requesting is not dedicated to copyright infringement, see https://yt-dl.org/copyright-infringement. youtube-dl does not support such sites. In order for site support request to be accepted all provided example URLs should not violate any copyrights.
- Search the bugtracker for similar site support requests: http://yt-dl.org/search-issues. DO NOT post duplicates.
- Finally, put x into all relevant boxes (like this [x])
-->
- [x] I'm reporting a new site support request
- [x] I've verified that I'm running youtube-dl version **2020.03.01**
- [x] I've checked that all provided URLs are alive and playable in a browser
- [x] I've checked that none of provided URLs violate any copyrights
- [x] I've searched the bugtracker for similar site support requests including closed ones
## Example URLs
<!--
Provide all kinds of example URLs support for which should be included. Replace following example URLs by yours.
-->
Playlist : https://www.nrj.fr/podcasts/l-appel-automatique-de-georges/
Single : https://www.nrj.fr/podcasts/l-appel-automatique-de-georges/l-appel-automatique-de-georges-vos-affaires-personnelles-mises-aux-encheres
## Description
<!--
Provide any additional information.
If work on your issue requires account credentials please provide them or explain how one can obtain them.
-->
NRJ is a French radio and has a podcast category on his website, it would be useful to download podcasts from the website
| site-support-request | low | Critical |
575,569,082 | flutter | Support simple dragging | In some cases it would be great to be able to drag widgets (like dialogs) inside the dimensions of the phone or inside a widget without exchaning any data or having a specific drop target - i. e. moving a dialog to see what is below it.
Draggable and DropTarget seems to be disproportionate and to complicated to implement for this usecase... | c: new feature,framework,P3,team-framework,triaged-framework | low | Minor |
575,581,501 | go | x/text/language: Match() choses the wrong Tag | ### What version of Go are you using (`go version`)?
<pre>
$ go version
go version go1.14 linux/amd64
</pre>
### Does this issue reproduce with the latest release?
Yes.
### What operating system and processor architecture are you using (`go env`)?
<details><summary><code>go env</code> Output</summary><br><pre>
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/root/.cache/go-build"
GOENV="/root/.config/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build210008815=/tmp/go-build -gno-record-gcc-switches"
</pre></details>
### What did you do?
https://play.golang.org/p/_qlIzcAWD5F
```go
package main
import (
"fmt"
"golang.org/x/text/language"
)
func main() {
matcher := language.NewMatcher([]language.Tag{
language.MustParse("en-GB"),
language.MustParse("fr-FR"),
language.MustParse("es-ES"),
})
tag, _, confidence := matcher.Match(
language.MustParse("en"),
language.MustParse("fr"),
language.MustParse("en-US"),
)
fmt.Printf("best match: %s, confidence: %s\n", tag, confidence)
}
```
### What did you expect to see?
```
best match: en-GB, confidence: High
```
### What did you see instead?
```
best match: fr-FR, confidence: Exact
``` | NeedsInvestigation | low | Critical |
575,664,648 | flutter | Support for @2x, @3x, etc naming convention for images | <!-- Thank you for using Flutter!
If you are looking for support, please check out our documentation
or consider asking a question on Stack Overflow:
* https://flutter.dev/
* https://api.flutter.dev/
* https://stackoverflow.com/questions/tagged/flutter?sort=frequent
If you have found a bug or if our documentation doesn't have an answer
to what you're looking for, then fill our the template below. Please read
our guide to filing a bug first: https://flutter.dev/docs/resources/bug-reports
-->
## Use case
<!--
Please tell us the problem you are running into that led to you wanting
a new feature.
Is your feature request related to a problem? Please give a clear and
concise description of what the problem is.
Describe alternative solutions you've considered. Is there a package
on pub.dev/flutter that already solves this?
-->
When creating new images or reusing images from other projects, design apps export them with @2x, @3x or similar. Even if it is not possible to support having all these images in the same folder, at least being able to understand them when they are in the 2.0x, 3.0x folder would be great.
## Proposal
<!--
Briefly but precisely describe what you would like Flutter to be able to do.
Consider attaching images showing what you are imagining.
Does this have to be provided by Flutter directly, or can it be provided
by a package on pub.dev/flutter? If so, maybe consider implementing and
publishing such a package rather than filing a bug.
-->
When having an image.png file, and putting a higher quality image in the 2.0x folder, flutter should accept [email protected]
| tool,framework,a: assets,a: images,c: proposal,P3,team-framework,triaged-framework | low | Critical |
575,676,338 | pytorch | RuntimeError with torch.unique: radix_sort: failed on 2nd step: invalid argument | ## 🐛 Bug
Hello, I encountered the following error when using `torch.unique` inside my code:
```
File "/new_envs/lib/python3.7/site-packages/torch/functional.py", line 471, in unique
return_counts=return_counts,
RuntimeError: radix_sort: failed on 2nd step: invalid argument
```
The line causing this problem is `torch.unique(label)`.
The weird thing is that sometimes I can run the code without running into any issue, but if I stop it (ctrl+c) and run again, the above error showed up again. And if I write a test file `test.py` that contains the following code
```
import torch
a = torch.Tensor(3, 5, 10).cuda()
b = torch.unique(a)
```
and run it with `python test.py`, the bug doesn't show up again.
Using `torch.unique` on the interactive mode is fine
## Environment
I install pytorch via:
```
conda create --prefix ./new_envs python=3.7
conda activate ./new_envs
conda install pytorch torchvision cudatoolkit=10.0 -c pytorch.
```
The output of collect_env script:
```
Collecting environment information... [7/1926]
PyTorch version: 1.4.0
Is debug build: No
CUDA used to build PyTorch: 10.0
OS: Ubuntu 14.04.6 LTS
GCC version: (GCC) 5.2.0
CMake version: version 2.8.12.2
Python version: 3.7
Is CUDA available: Yes
CUDA runtime version: 10.0.130
GPU models and configuration: GPU 0: TITAN Xp
Nvidia driver version: 430.14
cuDNN version: Could not collect
Versions of relevant libraries:
[pip] numpy==1.18.1
[pip] torch==1.4.0
[pip] torchvision==0.5.0
[conda] blas 1.0 mkl
[conda] mkl 2020.0 166
[conda] mkl-service 2.3.0 py37he904b0f_0
[conda] mkl_fft 1.0.15 py37ha843d7b_0
[conda] mkl_random 1.1.0 py37hd6b4f25_0
[conda] pytorch 1.4.0 py3.7_cuda10.0.130_cudnn7.6.3_0 pytorch
[conda] torchvision 0.5.0 py37_cu100 pytorch
```
## Additional context
<!-- Add any other context about the problem here. -->
cc @ngimel @heitorschueroff | module: cuda,triaged,module: sorting and selection | medium | Critical |
575,740,681 | youtube-dl | Add Vlare support | <!--
######################################################################
WARNING!
IGNORING THE FOLLOWING TEMPLATE WILL RESULT IN ISSUE CLOSED AS INCOMPLETE
######################################################################
-->
## Checklist
<!--
Carefully read and work through this check list in order to prevent the most common mistakes and misuse of youtube-dl:
- First of, make sure you are using the latest version of youtube-dl. Run `youtube-dl --version` and ensure your version is 2020.03.01. If it's not, see https://yt-dl.org/update on how to update. Issues with outdated version will be REJECTED.
- Make sure that all provided video/audio/playlist URLs (if any) are alive and playable in a browser.
- Make sure that site you are requesting is not dedicated to copyright infringement, see https://yt-dl.org/copyright-infringement. youtube-dl does not support such sites. In order for site support request to be accepted all provided example URLs should not violate any copyrights.
- Search the bugtracker for similar site support requests: http://yt-dl.org/search-issues. DO NOT post duplicates.
- Finally, put x into all relevant boxes (like this [x])
-->
- [x] I'm reporting a new site support request
- [x] I've verified that I'm running youtube-dl version **2020.03.01**
- [x] I've checked that all provided URLs are alive and playable in a browser
- [x] I've checked that none of provided URLs violate any copyrights
- [x] I've searched the bugtracker for similar site support requests including closed ones
## Example URLs
<!--
Provide all kinds of example URLs support for which should be included. Replace following example URLs by yours.
-->
- Single video: https://vlare.tv/v/HSzfUoye
- Playlist: https://vlare.tv/u/xdb6VaaO/playlist/501
- Channel: https://vlare.tv/u/xdb6VaaO
## Description
<!--
Provide any additional information.
If work on your issue requires account credentials please provide them or explain how one can obtain them.
-->
ytdl DOES support downloading videos (although, not playlists) by using the 'generic information extractor', but some built-in support for Vlare would be nice.
| site-support-request | low | Critical |
575,740,829 | pytorch | CustomFromMask pruning stores a copy of the user-provided mask | ## 🐛 Bug
(Not a bug, strictly speaking, because it doesn't compromise correctness, but still an issue because it affects model size).
The pruning method called `CustomFromMask` in `torch/nn/utils/prune.py` is designed to prune parameters by applying a user-provided mask. An instance of this class is then attached to the pruned module as a `forward_pre_hook`. The issue is that each hook carries (and therefore attaches to the module) a copy of the user-provided mask (of the same size as the pruned parameter), thus significantly growing the size of the model. This becomes particularly problematic in global pruning, which prunes the entire network by relying on `CustomFromMask`.
## To Reproduce
Steps to reproduce the behavior:
1. Create a `nn.Module`
1. Prune it using `torch.nn.utils.prune.custom_from_mask`
1. Check that a `forward_pre_hook` has been added to the Module
1. Notice that the hook carries and attribute called `mask` that stores a (undesirable) copy of the mask applied to the parameter that impacts the size of the Module, when serialized.
```python
import torch
from torch import nn
import torch.nn.utils.prune as prune
m = nn.Conv2d(3, 512, 3)
custom_mask = torch.randint(0, 2, size=m.weight.shape)
prune.custom_from_mask(m, 'weight', mask=custom_mask)
print([v.mask for v in m._forward_pre_hooks.values()])
```
Specifically, when comparing the size of a module pruned with any other pruning technique versus a module pruned with `CustomFromMask`, the size difference is clearly visible.
```python
m = nn.Conv2d(3, 512, 3)
custom_mask = torch.randint(0, 2, size=m.weight.shape)
prune.custom_from_mask(m, 'weight', mask=custom_mask)
torch.save(m, 'custom.pth')
n = nn.Conv2d(3, 512, 3)
prune.l1_unstructured(n, 'weight', amount=0.5)
torch.save(n, 'l1.pth')
```
Then `ls -lht *.pth` yields:
```
173K Mar 3 15:39 l1.pth
281K Mar 3 15:39 custom.pth
```
## Expected behavior
The user-provided mask is used only once when `compute_mask` is called, so it could be manually deleted afterwards. If keeping the mask was desirable for some use cases, we can add a flag in the constructor to determine whether the mask should be stored or deleted after it's been used.
## Environment
PyTorch version: 1.5.0.dev20200303
Is debug build: No
CUDA used to build PyTorch: 10.1
OS: Ubuntu 18.04.3 LTS
GCC version: (Ubuntu 7.4.0-1ubuntu1~18.04.1) 7.4.0
CMake version: version 3.10.2
Python version: 3.6
Is CUDA available: Yes
CUDA runtime version: Could not collect
GPU models and configuration:
GPU 0: Quadro GP100
GPU 1: Quadro GP100
Nvidia driver version: 418.116.00
cuDNN version: Could not collect
Versions of relevant libraries:
[pip3] numpy==1.18.1
[pip3] torch==1.5.0.dev20200303
[pip3] torchvision==0.6.0.dev20200303
[conda] Could not collect
cc @albanD @mruberry | module: nn,triaged,module: pruning | low | Critical |
575,805,206 | rust | More precise drop elaboration | #68943 and #68528 changed drop elaboration to reduce the number of `Drop` terminators emitted for enums. Originally, these PRs were intended only to solve #66753, but they also resulted in [significant perf improvements](https://perf.rust-lang.org/compare.html?start=a8437cf213ac1e950b6f5c691c4d2a29bf949bcd&end=d9051341a1c142542a3f7dab509266606c775382&stat=instructions%3Au) for codegen-ed builds (look only at the "clean" runs).
It may be possible to find more perf wins by making drop elaboration more precise. Notably, #68528 added a `discriminant_switch_effect` to `MaybeInitializedPlaces` but did not make the equivalent change to `MaybeUninitializedPlaces`. As a result, some frivolous drop terminators remain after drop elaboration (e.g., `bb5` in [this recreation of `Option::unwrap`](https://play.rust-lang.org/?version=nightly&mode=debug&edition=2018&gist=4e59ddba525666d19fba8d706f2aa822)). This occurs because the move path for the local containing the `Option` is calculated to be "maybe live" by drop elaboration, but is determined *not* to be "maybe dead" since `MaybeUninitializedLocals` does not mark the move path for the `Option::Some(_)` variant as uninitialized. As a result, elaboration considers the drop of `Option<T>` along the unwind edge as ["static" instead of "open"](https://github.com/rust-lang/rust/blob/e0e5d82e1677c82d209b214bbfc2cc5705c2336a/src/librustc_mir/transform/elaborate_drops.rs#L191). Only "open" drops trigger the new code introduced in #68943 for fieldless enum variants such as `Option::None`.
On the other hand, marking more drops of enums as "open" ones could *increase* the amount of MIR we need to codegen. If we can't prove that they are frivolous, open drops cause drop flags to be created within a function's MIR, while static drops simply invoke the drop shim. I'm not confident enough in my understanding of drop elaboration to be sure of this, however.
`MaybeUninitializedLocals` is also used in the borrow-checker, so care should be taken when modifying it. In the worst case, we could use a different version of that analysis for drop elaboration than for borrow-checking. However, using a more precise variant of the analysis during borrow-checking may have positive effects.
@eddyb also suggested incorporating information about the active enum variant during drop elaboration, similar to what [`NeedsDrop`](https://github.com/rust-lang/rust/blob/e0e5d82e1677c82d209b214bbfc2cc5705c2336a/src/librustc_mir/transform/check_consts/qualifs.rs#L227) does for const-checking. If this were implemented, we could eliminate all drops of an enum that occur after it is assigned a variant that needs no drop glue (e.g. `Option::None`) with no intervening assignment. I'm more skeptical of this approach than the first, since it becomes pretty useless as soon as a pointer exists that could mutate the place (unless we are willing to do a much more complex alias analysis). Perhaps they disagree?
In summary, I think we (myself and possibly @rust-lang/wg-mir-opt) should investigate the following ideas, with the first one given higher priority:
- [x] Add a `discriminant_switch_effect` to `MaybeUninitializedPlaces` in the style of #68528.
- [ ] Track assignments of enum variants during drop elaboration. | C-enhancement,I-compiletime,T-compiler,A-MIR | low | Critical |
575,832,354 | storybook | MDX: sbdocs classes are applied to html elements, and they collide with styles applied from classnames. | **Describe the bug**
Storybook CSS is cancelling out CSS for classNames that I'm writing.
**To Reproduce**
1. Create a `.mdx` file with the following:
```
import { Meta } from "@storybook/addon-docs/blocks";
<Meta title="Foo/Bar" />
<Preview>
<h2 className="font-big">Hello World</h2>
</Preview>
```
2. Import a CSS file into your `preview.js` file:
```
import "../src/index.css";
```
3. Create the css file with the following:
```
.font-big { font-size: 40px }
```
4. When you do all of this and load the above story, you should notice in the source code, Storybook has applied a set of classes to this element, and it will override the font style you set.
**Expected behavior**
I only expect the classes to be applied to actual markdown, not html. It doesn't seem very safe for people who are absolutely creating api's that accept html, to pass storybook classes onto this. Even if that was the case, it seems like `Preview` should be able to shield against this, or this should be some sort of configuration.
An alternative: There should be some feature to allow us to load our CSS "after" the Storybook CSS has loaded.
**Screenshots**
<img width="1582" alt="Screen Shot 2020-03-04 at 5 19 36 PM" src="https://user-images.githubusercontent.com/52427513/75928424-5d9f6f80-5e3c-11ea-8758-1980050df63c.png">
**Code snippets**
If applicable, add code samples to help explain your problem.
**System:**
```
Environment Info:
System:
OS: macOS Mojave 10.14.5
CPU: (8) x64 Intel(R) Core(TM) i5-8259U CPU @ 2.30GHz
Binaries:
Node: 10.16.0 - /usr/local/bin/node
Yarn: 1.19.1 - /usr/local/bin/yarn
npm: 6.11.3 - /usr/local/bin/npm
Browsers:
Chrome: 80.0.3987.122
Firefox: 67.0.1
Safari: 12.1.1
npmPackages:
@storybook/addon-a11y: ^6.0.0-alpha.20 => 6.0.0-alpha.20
@storybook/addon-actions: ^6.0.0-alpha.20 => 6.0.0-alpha.20
@storybook/addon-backgrounds: ^6.0.0-alpha.20 => 6.0.0-alpha.20
@storybook/addon-centered: ^6.0.0-alpha.20 => 6.0.0-alpha.20
@storybook/addon-docs: ^6.0.0-alpha.20 => 6.0.0-alpha.20
@storybook/addon-knobs: ^6.0.0-alpha.20 => 6.0.0-alpha.20
@storybook/addon-links: ^6.0.0-alpha.20 => 6.0.0-alpha.20
@storybook/addons: ^6.0.0-alpha.20 => 6.0.0-alpha.20
@storybook/react: ^6.0.0-alpha.20 => 6.0.0-alpha.20
@storybook/theming: ^6.0.0-alpha.20 => 6.0.0-alpha.20
```
**Additional context**
This is similar to #8504, except I feel there's a big safety risk of applying storybook css to user supplied html, where the documentation may not display what the output of something actually is. | question / support,theming,addon: docs,mdx | medium | Critical |
575,863,886 | rust | Confusing diagnostics where the error mentions Sized but not that a trait bound is not implemented (where it would be for a Sized type). | This comes from the [user forum](https://users.rust-lang.org/t/wrapping-boxed-errors/38951), [playground](https://play.rust-lang.org/?version=nightly&mode=debug&edition=2018&gist=66943a8d8e850922681779926208b1fd), moved from #27964:
```rust
use std::error::Error;
fn library_function<F1, E1>(f1: F1) -> Result<(), E1>
where
F1: FnOnce() -> Result<(), E1>,
E1: Error, // <-remove this line -> compile
{
f1()
}
fn main() -> Result<(), Box<dyn Error>>
{
library_function( || Ok(()) )
}
```
Error:
```
error[E0277]: the size for values of type `dyn std::error::Error` cannot be known at compilation time
--> src/main.rs:13:5
|
3 | fn library_function<F1, E1>(f1: F1) -> Result<(), E1>
| ----------------
...
6 | E1: Error, // <-remove this line -> compile
| ----- required by this bound in `library_function`
...
13 | library_function( || Ok(()) )
| ^^^^^^^^^^^^^^^^ doesn't have a size known at compile-time
|
= help: the trait `std::marker::Sized` is not implemented for `dyn std::error::Error`
= note: to learn more, visit <https://doc.rust-lang.org/book/ch19-04-advanced-types.html#dynamically-sized-types-and-the-sized-trait>
= note: required because of the requirements on the impl of `std::error::Error` for `std::boxed::Box<dyn std::error::Error>`
```
Go figure why "library_function doesn't have a size known at compile time".
Analysis:
There is a blanket impl for `Error` on `Box<T>`, so quickly looking it up in the docs makes you think that it should implement Error, but it's not on `Box<T: ?Sized>`. credit to @Yandros
I feel the main issue here is that we have a trait bound on Error that isn't satisfied, so probably it would be nice to replace `library_function` not being sized by: `Box<dyn Error> does not implement Error. The following Impls where found: impl<T: Error> Error for Box<T>, but that requires T: Sized`. | C-enhancement,A-diagnostics,T-compiler,D-terse | low | Critical |
575,864,081 | go | x/build/cmd/gopherbot: check if next release release branch exists before considering it for backports | It occurred to me know that we can implement a better heuristic. If a release branch for the next version of Go does not exist yet, gopherbot should not consider creating a backport issue for that version.
Related to #37672.
/cc @toothrot @cagedmantis | Builders,NeedsInvestigation | low | Minor |
575,880,065 | TypeScript | VSCode Angular 9 Auto-Import for Custom Libraries |
*TS Template added by @mjbvz*
**TypeScript Version**: 3.8.3
**Search Terms**
- angular
---
I'm currently building an Angular 9 Library using VSCode (version 1.42.1 on MAC OS). I followed the Angular Tutorial on how to create libraries - https://angular.io/guide/creating-libraries.
I also added schematics to the angular package, I'm currently having problems when I add the Library to Angular Application using the `ng add ~/projects/my-library-0.01.tgz --save `command.
VSCode is unable to auto-import components or classes defined in this package.
> Cannot find name 'MyService'.
If I manually add `import { MyService } from 'my-library' `this works fines.
Is there a reason why the auto-import is not working for custom angular libraries? | Needs Investigation | low | Major |
575,901,157 | flutter | ImageFilter.matrix and ImageFiltered do not provide an origin alignment property | The following gist is an example of how to use a `Transform` widget or an `ImageFiltered` widget to achieve a similar effect. The `Transform` widget will render its child anew with each change of the matrix, but the `ImageFiltered` widget will use a simpler, possibly more cacheable, pixel filter on the untransformed child to achieve the same effect.
The ease of use between them is similar except for the issue of trying to create a transform that rotates the child around its center point. The `Transform` widget provides an origin alignment property that makes this effect trivial to accomplish, but the `ImageFiltered` widget and the `ImageFilter.matrix` filter do not provide any alignment property and the workaround involves a difficult to manage postFrameCallback to get the information it needs. Not only is this code more work, but the answer will not be available to incorporate into the first frame rendered.
Gist: https://gist.github.com/flar/da94ae35e8b86184b404000dfda68313 | engine,a: images,has reproducible steps,P2,found in release: 3.3,found in release: 3.7,team-engine,triaged-engine | low | Major |
575,917,209 | pytorch | `torch.norm` is 113x slower than `torch.sqrt(a**2 + b**2)` | ## 🐛 Bug
`torch.norm` is really slow compared to `torch.sqrt(a**2 + b**2)`. The specific `input_` size is based on the output of `torch.stft`.
## To Reproduce
```python
import torch
import timeit
import numpy
input_ = torch.randn(500, 1000, 2)
def version_one(input_):
a, b = input_.unbind(-1)
return torch.sqrt(a**2 + b**2)
def version_two(input_):
return torch.norm(input_, dim=-1)
numpy.testing.assert_almost_equal(
version_one(input_).numpy(), version_two(input_).numpy(), decimal=6)
print('Version One:', timeit.timeit('version_one(input_)', number=100, globals=globals()))
print('Version Two:', timeit.timeit('version_two(input_)', number=100, globals=globals()))
```
```bash
Version One: 0.10085414599999998
Version Two: 13.104690384
```
## Expected behavior
The performance should be similar...
## Environment
```bash
Collecting environment information...
PyTorch version: 1.4.0
Is debug build: No
CUDA used to build PyTorch: None
OS: Mac OSX 10.14.6
GCC version: Could not collect
CMake version: Could not collect
Python version: 3.7
Is CUDA available: No
CUDA runtime version: No CUDA
GPU models and configuration: No CUDA
Nvidia driver version: No CUDA
cuDNN version: No CUDA
Versions of relevant libraries:
[pip3] numpy==1.18.1
[pip3] pytorch-nlp==0.5.0
[pip3] torch==1.4.0
[pip3] torchaudio==0.4.0
[conda] Could not collect
```
cc @vincentqb @vishwakftw @jianyuh @nikitaved @pearu @mruberry @VitalyFedyunin @ngimel | module: performance,triaged,module: linear algebra | low | Critical |
575,949,484 | TypeScript | Allow narrowing type based on others properties when creating a new object | ## Search Terms
- narrowing type
## Suggestion
Currently, TypeScript isn't narrowing the type based on others properties that is defined while creating a new object. For example. Let's say the we have the following function:
```ts
type TParams = { kind: 'name', value: string } | { kind: 'age', value: number }
const example = (params: TParams) => {
...
}
```
So we can call it using codes like:
```ts
example({ kind: 'name', value: 'macabeus' })
example({ kind: 'age', value: 23 })
```
But isn't possible to compile code like:
```ts
let nameOrAge: 'name' | 'age' = 'name'
example({
kind: nameOrAge,
value: (nameOrAge === 'name' ? 'macabeus' : 23),
})
```
[_Playground_](https://www.typescriptlang.org/play/?ssl=18&ssc=2&pln=6&pc=1#code/C4TwDgpgBAKgCgQwE4ILYGcoF4oG8oDWAlgHYAmAXFAOQloTUA0UAbggDYCuEV6wSpAOZQAvlAA+eQqUo0EghszZceUEp1QAjCElEBYAFABjAPYk+UCAA80YdtBwAKMMjToq8VxgCU2AHx4hoYiQQb2wGr0APJIAIIKVLT01BJyCik4SagModa29o64hlAl0uRUdNkx8RCMxaXK3FSOlRDVCthYma0pAPw0qAhGCNqc6ClUAEwAzN51BiLehkA)
but we know that, if `nameOrAge` is `'name'`, the property `value` will be a string, otherwise `nameOrAge` will be `'age'` and `value` will be `23` - that is correct.
I think that would be useful if TS could check this behaviour.
## Use Cases
It would be useful to reduce the amount of code on situations like described on the above section.
Currently, is necessary to write more lines to have the same behaviour:
```ts
let nameOrAge: 'name' | 'age' = 'name'
if (nameOrAge === 'name') {
example({
kind: nameOrAge,
value: 'macabeus',
})
} else {
example({
kind: nameOrAge,
value: 23,
})
}
```
[_Playground_](https://www.typescriptlang.org/play/?ssl=1&ssc=1&pln=19&pc=1#code/C4TwDgpgBAKgCgQwE4ILYGcoF4oG8oDWAlgHYAmAXFAOQloTUA0UAbggDYCuEV6wSpAOZQAvlAA+eQqUo0EghszZceUEp1QAjCElEBYAFABjAPYk+UCAA80YdtBwAKMMjToq8VxgCU2AHx4hoYiQQb2wGr0APJIAIIKVLT01BJyCik4SagMoUQAZlCOdNkx8Q5YmcUMvvhQdYZ1dda29o64DY2dxORUVaUKjB2ddcrciagIRgjanOhMQ6LewZbs6NDtBp3NqHYQbQtdMr3RcQMHjaOqAEwAzIObjSJLBiEGQA)
## Related
I know that there are a lot of issues saying about narrowing types based on variables, such as:
- [that](https://github.com/microsoft/TypeScript/issues/28981) about narrowing on arrays values
- [that](https://github.com/microsoft/TypeScript/issues/12184) about narrowing when calling a function
But here I'm saying only about when is creating a new object, and _as far as I know_ is a simpler case if compared on these others issues, since doesn't need to track the entire code base.
On the case that I'm saying, TS just need to check the others properties defined on the same object **and** if the variable name already is used. For example, TS doesn't need to change its behaviour on this case:
```ts
example({
kind: nameOrAge,
value: otherVariabledDeclaredOnOtherScope ? 'macabeus' : 23,
}) // still should fail
```
Probably it isn't the best solution, but I think that it follow the Pareto efficiency.
## Checklist
My suggestion meets these guidelines:
* [x] This wouldn't be a breaking change in existing TypeScript/JavaScript code
* [x] This wouldn't change the runtime behavior of existing JavaScript code
* [x] This could be implemented without emitting different JS based on the types of the expressions
* [x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
* [x] This feature would agree with the rest of [TypeScript's Design Goals](https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals).
| Suggestion,Awaiting More Feedback | low | Minor |
575,951,897 | flutter | floating SliverAppBar keep elevation when hidden | ## Use case
In google news for example the shadow stays visible even if the appbar is scrolled away.
So you have a small shadow below the status bar when the appbar is hidden.
## Proposal
It would be nice if this would be possible with SliverAppBar. | framework,f: material design,c: proposal,team-design,triaged-design | low | Minor |
575,963,841 | flutter | Plugin linking fails using local engine: Flutter.framework/Flutter, building for iOS-arm64 but attempting to link with file built for iOS Simulator-x86_64 | Similar to https://github.com/flutter/flutter/issues/50568 but for plugins when building with a non-fat local engine (only x86 or only arm)
```
ld: warning: ignoring file /Users/m/Downloads/app5/ios/Flutter/Flutter.framework/Flutter, building for iOS-arm64 but attempting to link with file built for iOS Simulator-x86_64
Undefined symbols for architecture arm64:
"_OBJC_CLASS_$_FlutterStandardMessageCodec", referenced from:
objc-class-ref in FlutterWebView.o
"_OBJC_CLASS_$_FlutterError", referenced from:
objc-class-ref in FLTWKNavigationDelegate.o
objc-class-ref in FlutterWebView.o
"_OBJC_CLASS_$_FlutterMethodChannel", referenced from:
objc-class-ref in FLTCookieManager.o
objc-class-ref in FlutterWebView.o
"_FlutterMethodNotImplemented", referenced from:
-[FLTCookieManager handleMethodCall:result:] in FLTCookieManager.o
___83-[FLTWKNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]_block_invoke in FLTWKNavigationDelegate.o
-[FLTWebViewController onMethodCall:result:] in FlutterWebView.o
ld: symbol(s) not found for architecture arm64
```
The plugin targets run before the app target, so it fails before xcode_backend can run and copy the right version of Flutter.framework at `FRAMEWORK_SEARCH_PATHS = $(inherited) "${PODS_ROOT}/../Flutter"`.
Made worse by https://github.com/flutter/flutter/pull/42029/files#diff-4c9b1f4062d1444c8802dec8fea33e95L49. | tool,t: xcode,P2,team-tool,triaged-tool | low | Critical |
575,981,409 | kubernetes | systemd specs should be in-repo | <!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks!
If the matter is security related, please disclose it privately via https://kubernetes.io/security/
-->
**What happened**:
https://github.com/kubernetes/kubernetes/pull/87585#pullrequestreview-369105857
**What you expected to happen**:
**How to reproduce it (as minimally and precisely as possible)**:
**Anything else we need to know?**:
**Environment**:
- Kubernetes version (use `kubectl version`):
- Cloud provider or hardware configuration:
- OS (e.g: `cat /etc/os-release`):
- Kernel (e.g. `uname -a`):
- Install tools:
- Network plugin and version (if this is a network-related bug):
- Others:
/assign @justaugustus | kind/bug,sig/release,lifecycle/frozen,needs-triage | medium | Critical |
575,995,951 | electron | Request for webview full page capture API | ### Problem Description
I'm working on an app that renders a URL in `<webview>` and takes screenshots from it. `<webview>.capturePage([rect])` API can be used to capture the visible content but there is no way to capture the **entire page length** i.e content beyond the visible region with scrollbar. I have tried changing height variable in `[rect] `object, still, it won't capture beyond the window height.
### Proposed Solution
A new method `<webview>.captureFullPage` that is capable of capturing entire page length is a great solution. Thre is a similar problem with chrome API, that is solved by `capture visible page > scroll to the next visible region > and repeat till the end > stitch the images together. `
### Alternatives Considered
An alternate workaround is to use the html2canvas library to convert HTML to canvas.
### Additional Information
_version: 6.1.9_
| enhancement :sparkles: | low | Major |
576,067,357 | go | spec: disallow duplicate keys via variables in keyed constructors | <!--
Please answer these questions before submitting your issue. Thanks!
For questions please use one of our forums: https://github.com/golang/go/wiki/Questions
-->
### What version of Go are you using (`go version`)?
<pre>
go version go1.13.8 darwin/amd64
</pre>
### Does this issue reproduce with the latest release?
Yes
### What operating system and processor architecture are you using (`go env`)?
<details><summary><code>go env</code> Output</summary><br><pre>
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/big0ne/Library/Caches/go-build"
GOENV="/Users/big0ne/Library/Application Support/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GONOPROXY=""
GONOSUMDB=""
GOOS="darwin"
GOPATH="/Users/big0ne/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/darwin_amd64"
GCCGO="gccgo"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/ql/g_n75d6510s0lxhzzs70h5g40000gn/T/go-build587896349=/tmp/go-build -gno-record-gcc-switches -fno-common"
</pre></details>
### What did you do?
I have struct like this:
`type person struct {
first string
last string
skills []string
}`
and I have two variables in this type:
` p1 := person{
first: "John",
last: "Stallone",
skills: []string{"Java", "Go"},
}
p2 := person{
first: "Mark",
last: "Stallone",
skills: []string{"C++", "Python", "Go"},
}`
If I wanted create something like this:
` persons := map[string]person{
"Stallone": p1,
"Stallone": p2,
}`
it would be obvious error, but if I try this:
` persons := map[string]person{
p1.last: p1,
p2.last: p2,
}`
there is no problem.
And result may be confusing, because second key overwrites previous one. For example for this code:
`
for _, v := range persons {
fmt.Println(v.first)
fmt.Println(v.last)
for i, val := range v.skills {
fmt.Println(i+1, val)
}
fmt.Println("===")
}`
I get only one person with skills, when I have map with two values in there.
### What did you expect to see?
Consistency would be better (so we should let developer write map with two keys all the time or we should block every try of duplication by raise an exception)
### What did you see instead?
`Mark
Stallone
1 C++
2 Python
3 Go
` | NeedsDecision | low | Critical |
576,080,743 | go | runtime: save CPU registers for the frame calling runtime.sigpanic | When a OS signal/exception causes a panic a call to runtime.sigpanic is pushed onto the goroutine stack but a debugger has no way to recover the state of the CPU registers for the frame that caused the signal to happen. Having them would be useful for debugging optimized executables (where some variables may be registerized) as well as debugging problems with functions implemented in assembly.
Context: https://github.com/go-delve/delve/issues/1838#issuecomment-577506916
cc @heschik | NeedsInvestigation,Debugging,compiler/runtime | low | Critical |
576,109,681 | flutter | AndroidView and UiKitView are not clickable | As the title suggests i'm using the androidView to display a particular image.
The problem is that AndroidView is not clickable, wrapping it in a gesturedetector the onTap is never called when i click the widget,but onTapCancel，onDoubleTap，onLongPress can working
```java
GestureDetector(
onTap: (){ print("onTap"); },
onTapCancel: (){ print("onTapCancel"); },
onLongPress: (){ print("onTapCancel"); },
onDoubleTap: (){ print("onTapCancel"); },
child: AndroidView(
viewType: '..',
onPlatformViewCreated: onPlatformViewCreated,
creationParams: creationParams,
creationParamsCodec: const StandardMessageCodec(),
)
),
``` | framework,engine,f: gestures,a: platform-views,has reproducible steps,P2,found in release: 3.7,found in release: 3.8,team-engine,triaged-engine | low | Major |
576,133,072 | vue | Vue form inputs broken on IE11 on browser refresh | ### Version
2.6.11
### Reproduction link
[https://codepen.io/affeman/pen/LYVzzYw](https://codepen.io/affeman/pen/LYVzzYw)
### Steps to reproduce
Not reproducible in CodePen but the code is the same used in the Vue official documentation (See below)
1. Go to https://vuejs.org/v2/guide/forms.html#Checkbox in Internet Explorer 11
2. Click the checkbox
3. Reload the page
### What is expected?
The checkbox is unchecked and the label is false
### What is actually happening?
The checkbox is checked and the label is false
---
The same issue applies to the other components on the page as well.
The issue is not applicable after a hard refresh.
<!-- generated by vue-issues. DO NOT REMOVE --> | browser quirks | low | Critical |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.