id
int64 393k
2.82B
| repo
stringclasses 68
values | title
stringlengths 1
936
| body
stringlengths 0
256k
⌀ | labels
stringlengths 2
508
| priority
stringclasses 3
values | severity
stringclasses 3
values |
|---|---|---|---|---|---|---|
569,480,982 | TypeScript | NaN incorrectly narrows to 0 | <!-- 🚨 STOP 🚨 𝗦𝗧𝗢𝗣 🚨 𝑺𝑻𝑶𝑷 🚨
Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Even if you think you've found a *bug*, please read the FAQ first, especially the Common "Bugs" That Aren't Bugs section!
Please help us by doing the following steps before logging an issue:
* Search: https://github.com/Microsoft/TypeScript/search?type=Issues
* Read the FAQ: https://github.com/Microsoft/TypeScript/wiki/FAQ
Please fill in the *entire* template below.
-->
<!--
Please try to reproduce the issue with the latest published version. It may have already been fixed.
For npm: `typescript@next`
This is also the 'Nightly' version in the playground: http://www.typescriptlang.org/play/?ts=Nightly
-->
**TypeScript Version:** 3.9.0-dev.20200222
<!-- Search terms you tried before logging this (so others can find this issue more easily) -->
**Search Terms:** NaN Truthiness Falsy
**Code**
```ts
function bool(): boolean { return false; }
function number(): number { return NaN; }
let a = number();
let b = bool();
const x = a && b; // type = boolean | 0
console.log(x); // prints NaN (which is neither boolean, nor 0)
```
**Expected behavior:**
Type of `x` should be `number | boolean`.
Since `NaN` isn't a "unit type" like `0`, we can't express `NaN` without using `number`.
**Actual behavior:**
Type of `x` is `0 | boolean`.
**Playground Link:** [playground link](http://www.typescriptlang.org/play/?ts=3.9.0-dev.20200222&ssl=1&ssc=1&pln=8&pc=30#code/GYVwdgxgLglg9mABAIznANgCgJQC4VroCmAhkgN6IBORUIVSwJ6AzkQNyIC+AUKJLASIwIALbIiVHPhHjJiSjToNEAORKrOvHsSiISiALzCxEqdnY7aKIwQw5LPCAhZ6AHrYMAyLyk4B6f0QoAE8AByJbVAxSJAAfRAAGJxcYgDp0OABzTDcLREDEMKoYMCgWNQ0gA)
**Related Issues:** <!-- Did you find other bugs that looked similar? -->
https://github.com/microsoft/TypeScript/issues/32778 (Incorrectly marked as duplicate?) | Suggestion,Awaiting More Feedback | low | Critical |
569,501,847 | pytorch | [dev] `RecursiveScriptModule` does not expose `jit.ignore`d methods | ## 🐛 Bug
`RecursiveScriptModule` does not expose `jit.ignore`d methods. `jit.ignore` seems to be the recommended way to "gradually prepare" code for scripting, though.
## To Reproduce
```py
class Foo(nn.Module):
def forward(self, x):
return None
@T.jit.ignore
def foo(self):
return None
foo = jit.script(Foo())
print(foo.__dict__.keys())
assert 'foo' not in foo.__dict__
```
## Expected behavior
Either `jit.ignore` should work here (it used to), or the docs need an update.
## Environment
- PyTorch Version (e.g., 1.0): 1.5.0.dev20200223
- OS (e.g., Linux): Ubuntu 18.04 LTS
- How you installed PyTorch (`conda`, `pip`, source): pip / dev
- Python version: 3.6.8
- CUDA/cuDNN version: 10.2
- GPU models and configuration: P100
- Any other relevant information:
## Additional context
<!-- Add any other context about the problem here. -->
cc @suo | oncall: jit,triaged | low | Critical |
569,544,084 | neovim | inccommand substitution should not call input() | <!-- Before reporting: search existing issues and check the FAQ. -->
- `nvim --version`:
```
NVIM v0.4.3
Build type: Release
LuaJIT 2.1.0-beta3
Compilation: /usr/lib/ccache/bin/cc -fstack-clash-protection -D_FORTIFY_SOURCE=2 -mtune=generic -O2 -pipe -g -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=1 -O2 -DNDEBUG -DMIN_LOG_LEVEL=3 -Wall -Wextra -pedantic -Wno-unused-parameter -Wstrict-prototypes -std=gnu99 -Wshadow -Wconversion -Wmissing-prototypes -Wimplicit-fallthrough -Wvla -fstack-protector-strong -fdiagnostics-color=auto -DINCLUDE_GENERATED_DECLARATIONS -D_GNU_SOURCE -DNVIM_MSGPACK_HAS_FLOAT32 -DNVIM_UNIBI_HAS_VAR_FROM -I/builddir/neovim-0.4.3/build/config -I/builddir/neovim-0.4.3/src -I/usr/include -I/builddir/neovim-0.4.3/build/src/nvim/auto -I/builddir/neovim-0.4.3/build/include
```
### Steps to reproduce using `nvim -u NORC`
```
nvim -u NORC
:set inccomand=nosplit
:s/^/\=input("sub: ")
```
### Actual behaviour
Prompts you for input when you're typing your substitute command and does nothing with your input, and then takes you back to the command you were typing.
### Expected behaviour
Shouldn't prompt you while you're typing your command.
| bug,complexity:low,core,inccommand | low | Critical |
569,548,832 | flutter | GoogleMapController.animateCamera - Return Future after animation completion | ## Use case
<!--
Please tell us the problem you are running into that led to you wanting
a new feature.
Is your feature request related to a problem? Please give a clear and
concise description of what the problem is.
Describe alternative solutions you've considered. Is there a package
on pub.dev/flutter that already solves this?
-->
Flutter's Google Maps plugin `GoogleMapController.animateCamera` has a `Future<void>` return value.
According to the documentation:
`The returned Future completes after the change has been started on the platform side.`
I would like this Future to instead return after the change has been **completed** on the platform side. This is useful because it would enable`animateCamera().then(() => {})` logic that depends on the state of the map after the animation has completed.
## Proposal
<!--
Briefly but precisely describe what you would like Flutter to be able to do.
Consider attaching images showing what you are imagining.
Does this have to be provided by Flutter directly, or can it be provided
by a package on pub.dev/flutter? If so, maybe consider implementing and
publishing such a package rather than filing a bug.
-->
Have `GoogleMapController.animateCamera` return a Future<void> after the animation has been **completed** on the platform side instead of after the animation has started. | c: new feature,p: maps,package,c: proposal,team-ecosystem,P3,triaged-ecosystem | low | Critical |
569,562,052 | TypeScript | Feature request: typed yield expression | <!-- 🚨 STOP 🚨 𝗦𝗧𝗢𝗣 🚨 𝑺𝑻𝑶𝑷 🚨
Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker.
Please help us by doing the following steps before logging an issue:
* Search: https://github.com/Microsoft/TypeScript/search?type=Issues
* Read the FAQ, especially the "Common Feature Requests" section: https://github.com/Microsoft/TypeScript/wiki/FAQ
-->
## Search Terms
generator, iterator, yield, type inference, co, redux-saga
<!-- List of keywords you searched for before creating this issue. Write them down here so that others can find this suggestion more easily -->
## Related Issues
#32523
## Suggestion
<!-- A summary of what you'd like to see added or changed -->
Allow passing of yield operator signature to generator functions
```typescript
declare function fetchUser(): Promise<User>;
function asyncAction*(yield: <R>(p: Promise<R>) => R) {
const user = yield fetchUser(); // user type inferred to User based on yield param
// impl
}
```
where `yield` inside params list is a pseudo-parameter similar to `this`.
## Use Cases
<!--
What do you want to use this for?
What shortcomings exist with current approaches?
-->
Discussion of use cases is given in #32523.
My intended use is case is emulating do notation for monads with generator functions.
This implies I would normally have some generator runner that does composition defined before writing generator function, so type of expression at which generator resumes is trivially inferrable based on yielded value.
## Discussion
<!-- Show how this would be used and what the behavior would be -->
The hard thing in typing `yield` expressions in is that resumed type does not depend only on passed parameters and generator type, but also on context in which the generator is run.
There is a precedent in TypeScript with similar situation -- `this` parameter in functions.
The situation is analogous -- what `this` behaves like depends on which object function is member of.
The proposal is to allow declaring contextual info about `yield` inside generator functions, by introducing appropriate pseudo-param.
I could see this working in two ways:
- `yield` param gets erased early, it does not affect generator function signature,
it serves merely as a contract for type-checking / inferrence inside body
```typescript
function asyncAction*(yield: <R>(p: Promise<R>) => R) {
// impl
}
typeof asyncAction == () => Generator<...>
```
- `yield` param is preserved as type info like `this` param.
then it is always present on types of shape `(yield: ...) => Generator<>` and defaults to `(a: any) => any`.
```typescript
function asyncAction*(yield: <R>(p: Promise<R>) => R) {
// impl
}
typeof asyncAction == (yield: <R>(p: Promise<R>) => R) => Generator<...>
```
Additionaly
1. signature of `yield` must extend `(a: any) => any` and defaults to it
```typescript
function asyncAction*(yield: number) {
// impl
}
// Error: signature must be of shape (any => any)
```
2. yielded values inside generator function body must be assignable to argument of `yield` signature
```typescript
function asyncAction*(yield: (s: string) => void) {
yield 7; // Error: number is not assignable to string
}
```
3. this parameter has no effect on `Generator<>` return type, whether declared or
other than obvious coherence guaranteed by (2)
## Checklist
My suggestion meets these guidelines:
* [x] This wouldn't be a breaking change in existing TypeScript/JavaScript code
thats an opt-in feature
* [x] This wouldn't change the runtime behavior of existing JavaScript code
type level feature, doesn't affect runtime behavior
* [x] This could be implemented without emitting different JS based on the types of the expressions
* [x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
* [x] This feature would agree with the rest of [TypeScript's Design Goals](https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals).
| Suggestion,Awaiting More Feedback | medium | Critical |
569,576,096 | TypeScript | Distribute property type union members to create union of object types | **TypeScript Version:** v3.9.0-dev.20200222
<!-- Search terms you tried before logging this (so others can find this issue more easily) -->
**Search Terms:** union type object property
**Code**
```ts
type Test =
| { b: [false, "a"] }
| { b: [true, "b"] }
declare const b2: boolean;
const a: Test = { b: b2 ? [b2, "b"] : [b2, "a"] }
```
**Expected behavior:**
No error. I'm not exactly sure if this is a bug or feature request but, essentially, it'd be nice if TS could recognize that: `{ b: [true, "b"] | [false, "a"]; }` is identical to `{ b: [true, "b"] } | { b: [false, "a"]; }`
**Actual behavior:**
```
Type '{ b: [true, "b"] | [false, "a"]; }' is not assignable to type 'Test'.
Type '{ b: [true, "b"] | [false, "a"]; }' is not assignable to type '{ b: [true, "b"]; }'.
Types of property 'b' are incompatible.
Type '[true, "b"] | [false, "a"]' is not assignable to type '[true, "b"]'.
Type '[false, "a"]' is not assignable to type '[true, "b"]'.
Type 'false' is not assignable to type 'true'.
```
**Playground Link:** [Playground Link](http://www.typescriptlang.org/v2/en/play?ts=3.8.0-beta#code/C4TwDgpgBAKhDOwoF4BQUoB8oG8oCMAuKAbQDMBDAG3ggBooAiCxgXSgF90tcDiTgAJwCu9JvjaduqACYQAxlQqDo8gPYA7RAQBMxfGrVUIFDQG5U6rUgrE425LyK6oAflL4dDRhPb9P3izsHEA) | Bug | low | Critical |
569,582,011 | youtube-dl | support otr-online.ru | ## Checklist
- [x] I'm reporting a new site support request
- [x] I've verified that I'm running youtube-dl version **2020.02.16**
- [x] I've checked that all provided URLs are alive and playable in a browser
- [x] I've checked that none of provided URLs violate any copyrights
- [x] I've searched the bugtracker for similar site support requests including closed ones
## Example URLs
- Single video: https://otr-online.ru/programmy/segodnya-v-rossii/sergey-leskov-41386.html
- Single video: https://otr-online.ru/programmy/segodnya-v-rossii/sergey-leskov-41465.html
## Description
The site of [Public Television of Russia](https://en.wikipedia.org/wiki/Public_Television_of_Russia) seems to provide single video players only with adjacent playlists (compelling their viewers to continue). However, youtube-dl should download only the first video. | site-support-request | low | Critical |
569,606,017 | excalidraw | show finish-arrow button always or on touchscreens | I find the way to end a multiline arrow/line not ideal.
My instinct was to click on the line shape again but that did nothing. Maybe we should make it end.
The checkmark button is not visible enough. We should make it a lot more obvious than it is right now somehow. Maybe change colors and/or location. | mobile | low | Minor |
569,606,768 | pytorch | Decouple Lifetime of Local RRef and RPC | Multiple people (cc @pietern @mrshenli @pritamdamania87 @zhaojuanmao @satgera @rohan-varma @gqchen @aazzolini @xush6528 @osalpekar @javier-m @shz0116) requested decouple the lifetime of local RRef from RPC, to allow creating local RRefs before `init_rpc`. See discussions ini #33587.
Technically, this shouldn't be hard to implement, but it might look weird if RRef constructor is independent of `init_rpc` but `rpc.shutdown()` marks all RRefs as invalid. A more appropriate solution might be decoupling `OwnerRRef`'s lifetime from RPC, but `UserRRef` can only live between `init_rpc()` and `rpc.shutdown()`. This will also be easier to convey in the API description.
More specifically, `rpc.shutdown()` would still clear all local RRefContext states, including the fork map. But, as long as the application still holds a Python object of the `OwnerRRef`, it can still use it if necessary. If later, the application calls `init_rpc` again, it can still pass the `OwnerRRef` as an argument in RPC calls. | oncall: distributed,triaged | low | Minor |
569,628,309 | TypeScript | Return export nodes of ast when resolving alias symbol |
## Search Terms
export star node
## Suggestion
Add an API which returns alias symbol of import specifier and the export nodes on the searching path.
## Use Cases
I want to write a little tool to extract certain type in typescript code and its dependent types.
Current approaches just return the alias symbol, and it's difficult to establish relationship between import specifier and export star statements.
## Examples
a.ts:
```
import {C} from './b';
```
b.ts:
```
export * from './c';
export * from './d';
export * from './e';
```
c.ts:
```
export const C = 1;
```
I want to get not only the location of symbol "C", but also the export star node in the AST of "b.ts", which is "export * from './c'".
## Checklist
My suggestion meets these guidelines:
* [x] This wouldn't be a breaking change in existing TypeScript/JavaScript code
* [x] This wouldn't change the runtime behavior of existing JavaScript code
* [x] This could be implemented without emitting different JS based on the types of the expressions
* [x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
* [ ] This feature would agree with the rest of [TypeScript's Design Goals](https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals).
| Suggestion,Awaiting More Feedback | low | Minor |
569,641,427 | godot | Collision shapes created through CollisionObject2D APIs are not visible | **Godot version:** 3.2
**OS/device including version:** Windows 10
**Issue description:** Collision shapes created using `CollisionObject2D` APIs work but are not visible on enabling "Visible Collision Shapes".
**Steps to reproduce:** Create collision shape using `shape_owner*` APIs
```
var own = create_shape_owner($Child)
var shape = CircleShape2D.new()
shape.radius = 20
shape_owner_add_shape(own, shape)
```
**Minimal reproduction project:**
[CollisionVisibilityBug.zip](https://github.com/godotengine/godot/files/4243133/CollisionVisibilityBug.zip) | enhancement,topic:physics,topic:2d | low | Critical |
569,760,207 | flutter | App crashes often in Emulator while Hot Reload, occurs mainly when new variable declared | Occurs mainly when new variable declared and used in UI but sometimes crashes on some other changes too.
I checked its not NullException. I checked issue #15196 and #31274 answer not found.
```bash
Performing hot reload...
Syncing files to device AOSP on IA Emulator...
W/Thread-8( 9575): type=1400 audit(0.0:37): avc: denied { search } for name="power_supply" dev="sysfs" ino=11715 scontext=u:r:untrusted_app:s0:c87,c256,c512,c768 tcontext=u:object_r:sysfs_batteryinfo:s0 tclass=dir permissive=0
F/libc ( 9575): Fatal signal 11 (SIGSEGV), code 1 (SEGV_MAPERR), fault addr 0x41017 in tid 9622 (Thread-8), pid 9575 (.am_flutter_app)
*** *** *** *** *** *** *** *** *** *** *** *** *** *** *** ***
Build fingerprint: 'google/sdk_gphone_x86_arm/generic_x86_arm:9/PSR1.180720.117/5875966:user/release-keys'
Revision: '0'
ABI: 'x86'
pid: 9575, tid: 9622, name: Thread-8 >>> com.example.am_flutter_app <<<
signal 11 (SIGSEGV), code 1 (SEGV_MAPERR), fault addr 0x41017
eax b50e08c5 ebx c81eef94 ecx 00041018 edx c81a5164
edi dd8a674c esi c4357400
ebp c670a838 esp c670a810 eip c7d246da
backtrace:
#00 pc 016186da /data/app/com.example.am_flutter_app-5mcQ-xDkdJX_8DYG4-YZvQ==/lib/x86/libflutter.so (offset 0x1190000)
#01 pc 01698d98 /data/app/com.example.am_flutter_app-5mcQ-xDkdJX_8DYG4-YZvQ==/lib/x86/libflutter.so (offset 0x1190000)
#02 pc 01697685 /data/app/com.example.am_flutter_app-5mcQ-xDkdJX_8DYG4-YZvQ==/lib/x86/libflutter.so (offset 0x1190000)
#03 pc 01691d7d /data/app/com.example.am_flutter_app-5mcQ-xDkdJX_8DYG4-YZvQ==/lib/x86/libflutter.so (offset 0x1190000)
#04 pc 0178bf7e /data/app/com.example.am_flutter_app-5mcQ-xDkdJX_8DYG4-YZvQ==/lib/x86/libflutter.so (offset 0x1190000)
#05 pc 017848f3 /data/app/com.example.am_flutter_app-5mcQ-xDkdJX_8DYG4-YZvQ==/lib/x86/libflutter.so (offset 0x1190000)
#06 pc 01784f21 /data/app/com.example.am_flutter_app-5mcQ-xDkdJX_8DYG4-YZvQ==/lib/x86/libflutter.so (offset 0x1190000)
#07 pc 0168ee0c /data/app/com.example.am_flutter_app-5mcQ-xDkdJX_8DYG4-YZvQ==/lib/x86/libflutter.so (offset 0x1190000)
#08 pc 016b690c /data/app/com.example.am_flutter_app-5mcQ-xDkdJX_8DYG4-YZvQ==/lib/x86/libflutter.so (offset 0x1190000)
#09 pc 016b6eee /data/app/com.example.am_flutter_app-5mcQ-xDkdJX_8DYG4-YZvQ==/lib/x86/libflutter.so (offset 0x1190000)
#10 pc 017a8958 /data/app/com.example.am_flutter_app-5mcQ-xDkdJX_8DYG4-YZvQ==/lib/x86/libflutter.so (offset 0x1190000)
#11 pc 0177cb3a /data/app/com.example.am_flutter_app-5mcQ-xDkdJX_8DYG4-YZvQ==/lib/x86/libflutter.so (offset 0x1190000)
#12 pc 00000639 <anonymous:c5600000>
Lost connection to device.
```
### Emulator Details
```console
Name: Pixel_2_API_28
CPU/ABI: Google Play Intel Atom (x86)
Path: C:\Users\NAVOKI\.android\avd\Pixel_2_API_28.avd
Target: google_apis_playstore [Google Play] (API level 28)
Skin: pixel_2
SD Card: 512M
fastboot.chosenSnapshotFile:
runtime.network.speed: full
hw.accelerometer: yes
hw.device.name: pixel_2
hw.lcd.width: 1080
hw.initialOrientation: Portrait
image.androidVersion.api: 28
tag.id: google_apis_playstore
hw.mainKeys: no
hw.camera.front: emulated
avd.ini.displayname: Pixel 2 API 28
hw.gpu.mode: auto
hw.ramSize: 1536
PlayStore.enabled: true
fastboot.forceColdBoot: yes
hw.cpu.ncore: 4
hw.keyboard: yes
hw.sensors.proximity: yes
hw.dPad: no
hw.lcd.height: 1920
vm.heapSize: 256
skin.dynamic: yes
hw.device.manufacturer: Google
hw.gps: yes
hw.audioInput: yes
image.sysdir.1: system-images\android-28\google_apis_playstore\x86\
showDeviceFrame: yes
hw.camera.back: virtualscene
AvdId: Pixel_2_API_28
hw.lcd.density: 420
hw.arc: false
hw.device.hash2: MD5:55acbc835978f326788ed66a5cd4c9a7
fastboot.forceChosenSnapshotBoot: no
fastboot.forceFastBoot: no
hw.trackBall: no
hw.battery: yes
hw.sdCard: yes
tag.display: Google Play
runtime.network.latency: none
disk.dataPartition.size: 6442450944
hw.sensors.orientation: yes
avd.ini.encoding: UTF-8
hw.gpu.enabled: yes
```
flutter doctor -v
```console
C:\Users\NAVOKI>flutter doctor -v
[√] Flutter (Channel master, v1.15.4-pre.139, on Microsoft Windows [Version 10.0.18363.657], locale en-IN)
• Flutter version 1.15.4-pre.139 at C:\Users\NAVOKI\flutter
• Framework revision 4df8fdb7df (2 days ago), 2020-02-22 18:24:03 -0800
• Engine revision f2f8c342be
• Dart version 2.8.0 (build 2.8.0-dev.9.0 0f141be8bd)
[√] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
• Android SDK at C:\Users\NAVOKI\AppData\Local\Android\sdk
• Android NDK location not configured (optional; useful for native profiling support)
• Platform android-29, build-tools 29.0.2
• Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
• Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b03)
• All Android licenses accepted.
[√] Chrome - develop for the web
• Chrome at C:\Program Files (x86)\Google\Chrome\Application\chrome.exe
[√] Visual Studio - develop for Windows (Visual Studio Community 2019 16.4.5)
• Visual Studio at C:\Program Files (x86)\Microsoft Visual Studio\2019\Community
• Visual Studio Community 2019 version 16.4.29806.167
[√] Android Studio (version 3.5)
• Android Studio at C:\Program Files\Android\Android Studio
• Flutter plugin version 43.0.1
• Dart plugin version 191.8593
• Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b03)
[√] IntelliJ IDEA Community Edition (version 2019.2)
• IntelliJ at C:\Program Files\JetBrains\IntelliJ IDEA Community Edition 2019.2.4
• Flutter plugin version 42.2.2
• Dart plugin version 192.7761
[√] Connected device (4 available)
• AOSP on IA Emulator • emulator-5554 • android-x86 • Android 9 (API 28) (emulator)
• Windows • Windows • windows-x64 • Microsoft Windows [Version 10.0.18363.657]
• Chrome • chrome • web-javascript • Google Chrome 80.0.3987.116
• Web Server • web-server • web-javascript • Flutter Tools
• No issues found!
``` | c: crash,platform-android,engine,dependency: dart,P2,team-android,triaged-android | low | Critical |
569,769,244 | pytorch | Some module has incorrect scope in complex naming situations in tensorboard graph export | ## 🐛 Bug
<!-- A clear and concise description of what the bug is. -->
## To Reproduce
My example is rather complex. To reproduce, I created a simple example.
```python
import json
import torch
import torch.nn as nn
from torch.utils.tensorboard._pytorch_graph import graph
from google.protobuf import json_format
class MyModule(nn.Module):
def __init__(self):
super().__init__()
self.weight = nn.Linear(5, 3)
self.bias = nn.Linear(5, 3)
self.module = nn.Linear(6, 1)
def forward(self, x):
tensors = [self.weight(x), self.bias(x)]
self.module(torch.cat(tensors, dim=1))
return x
module = MyModule()
result, _ = graph(module, torch.randn(5, 5))
result = json_format.MessageToDict(result)
for node in result["node"]:
node["attr"] = "..."
print(json.dumps(result, sort_keys=True, indent=2))
```
Output is:
```json
{
"node": [
{
"attr": "...",
"name": "input/input.1",
"op": "IO Node"
},
{
"attr": "...",
"input": [
"input/input.1"
],
"name": "output/output.1",
"op": "IO Node"
},
{
"attr": "...",
"input": [
"MyModule/Linear[weight]/weight/35"
],
"name": "MyModule/Linear[weight]/bias/49",
"op": "prim::GetAttr"
},
{
"attr": "...",
"input": [
"MyModule/Linear[weight]/weight/35"
],
"name": "MyModule/Linear[weight]/weight/50",
"op": "prim::GetAttr"
},
{
"attr": "...",
"input": [
"MyModule/Linear[weight]/weight/50"
],
"name": "MyModule/Linear[weight]/51",
"op": "aten::t"
},
{
"attr": "...",
"name": "MyModule/Linear[weight]/52",
"op": "prim::Constant"
},
{
"attr": "...",
"name": "MyModule/Linear[weight]/53",
"op": "prim::Constant"
},
{
"attr": "...",
"input": [
"MyModule/Linear[weight]/bias/49",
"input/input.1",
"MyModule/Linear[weight]/51",
"MyModule/Linear[weight]/52",
"MyModule/Linear[weight]/53"
],
"name": "MyModule/Linear[weight]/54",
"op": "aten::addmm"
},
{
"attr": "...",
"input": [
"MyModule/Linear[weight]/bias/bias/weight/38"
],
"name": "MyModule/Linear[weight]/bias/bias/55",
"op": "prim::GetAttr"
},
{
"attr": "...",
"input": [
"MyModule/Linear[weight]/bias/bias/weight/38"
],
"name": "MyModule/Linear[weight]/bias/bias/weight/56",
"op": "prim::GetAttr"
},
{
"attr": "...",
"input": [
"MyModule/Linear[weight]/bias/bias/weight/56"
],
"name": "MyModule/Linear[bias]/57",
"op": "aten::t"
},
{
"attr": "...",
"name": "MyModule/Linear[bias]/58",
"op": "prim::Constant"
},
{
"attr": "...",
"name": "MyModule/Linear[bias]/59",
"op": "prim::Constant"
},
{
"attr": "...",
"input": [
"MyModule/Linear[weight]/bias/bias/55",
"input/input.1",
"MyModule/Linear[bias]/57",
"MyModule/Linear[bias]/58",
"MyModule/Linear[bias]/59"
],
"name": "MyModule/Linear[bias]/60",
"op": "aten::addmm"
},
{
"attr": "...",
"input": [
"MyModule/Linear[weight]/54",
"MyModule/Linear[bias]/60"
],
"name": "MyModule/23",
"op": "prim::ListConstruct"
},
{
"attr": "...",
"name": "MyModule/24",
"op": "prim::Constant"
},
{
"attr": "...",
"input": [
"MyModule/23",
"MyModule/24"
],
"name": "MyModule/input",
"op": "aten::cat"
},
{
"attr": "...",
"name": "MyModule/61",
"op": "prim::Constant"
}
],
"versions": {
"producer": 22
}
}
```
Notice that `bias/bias/weight` there. It's obviously wrong.
<!-- If you have a code sample, error messages, stack traces, please provide it here as well -->
## Expected behavior
<!-- A clear and concise description of what you expected to happen. -->
Code responsible for the error can be found in `_pytorch_graph.py`. It looks like this:
```python
for node in graph.nodes():
if node.kind() == GETATTR_KIND:
attr_name = node.s('name')
parent = node.input().node()
if parent.kind() == GETATTR_KIND: # If the parent node is not the top-level "self" node
parent_attr_name = parent.s('name')
parent_scope = attr_to_scope[parent_attr_name]
attr_scope = parent_scope.split('/')[-1]
attr_to_scope[attr_name] = '{}/{}.{}'.format(parent_scope, attr_scope, attr_name)
else:
attr_to_scope[attr_name] = '__module.{}'.format(attr_name)
# We don't need classtype nodes; scope will provide this information
if node.output().type().kind() != CLASSTYPE_KIND:
node_py = NodePyOP(node)
node_py.scopeName = attr_to_scope[attr_name]
nodes_py.append(node_py)
else:
nodes_py.append(NodePyOP(node))
```
It used `attr_name` as key to find scope. However `attr_name` is often `weight` and `bias` and very easy to induce collision.
I tried to use node id as key, but failed to find any docs (nor related source code). So I use the first part of str (which is `%xxx`) as key. The modified code is:
```python
attr_to_scope = dict()
node_to_name = lambda d: str(d).split(":")[0].strip()
for node in graph.nodes():
if node.kind() == GETATTR_KIND:
attr_name = node.s('name')
node_name = node_to_name(node)
parent = node.input().node()
if parent.kind() == GETATTR_KIND: # If the parent node is not the top-level "self" node
parent_attr_name = parent.s('name')
parent_scope = attr_to_scope[node_to_name(parent)]
attr_scope = parent_scope.split('/')[-1]
attr_to_scope[node_name] = '{}/{}.{}'.format(parent_scope, attr_scope, attr_name)
else:
attr_to_scope[node_name] = '__module.{}'.format(attr_name)
# We don't need classtype nodes; scope will provide this information
if node.output().type().kind() != CLASSTYPE_KIND:
node_py = NodePyOP(node)
node_py.scopeName = attr_to_scope[node_name]
nodes_py.append(node_py)
else:
nodes_py.append(NodePyOP(node))
```
Now the result is:
```json
{
"node": [
{
"attr": "...",
"name": "input/input.1",
"op": "IO Node"
},
{
"attr": "...",
"input": [
"input/input.1"
],
"name": "output/output.1",
"op": "IO Node"
},
{
"attr": "...",
"input": [
"MyModule/Linear[weight]/weight/35"
],
"name": "MyModule/Linear[weight]/bias/49",
"op": "prim::GetAttr"
},
{
"attr": "...",
"input": [
"MyModule/Linear[weight]/weight/35"
],
"name": "MyModule/Linear[weight]/weight/50",
"op": "prim::GetAttr"
},
{
"attr": "...",
"input": [
"MyModule/Linear[weight]/weight/50"
],
"name": "MyModule/Linear[weight]/51",
"op": "aten::t"
},
{
"attr": "...",
"name": "MyModule/Linear[weight]/52",
"op": "prim::Constant"
},
{
"attr": "...",
"name": "MyModule/Linear[weight]/53",
"op": "prim::Constant"
},
{
"attr": "...",
"input": [
"MyModule/Linear[weight]/bias/49",
"input/input.1",
"MyModule/Linear[weight]/51",
"MyModule/Linear[weight]/52",
"MyModule/Linear[weight]/53"
],
"name": "MyModule/Linear[weight]/54",
"op": "aten::addmm"
},
{
"attr": "...",
"input": [
"MyModule/Linear[bias]/weight/38"
],
"name": "MyModule/Linear[bias]/bias/55",
"op": "prim::GetAttr"
},
{
"attr": "...",
"input": [
"MyModule/Linear[bias]/weight/38"
],
"name": "MyModule/Linear[bias]/weight/56",
"op": "prim::GetAttr"
},
{
"attr": "...",
"input": [
"MyModule/Linear[bias]/weight/56"
],
"name": "MyModule/Linear[bias]/57",
"op": "aten::t"
},
{
"attr": "...",
"name": "MyModule/Linear[bias]/58",
"op": "prim::Constant"
},
{
"attr": "...",
"name": "MyModule/Linear[bias]/59",
"op": "prim::Constant"
},
{
"attr": "...",
"input": [
"MyModule/Linear[bias]/bias/55",
"input/input.1",
"MyModule/Linear[bias]/57",
"MyModule/Linear[bias]/58",
"MyModule/Linear[bias]/59"
],
"name": "MyModule/Linear[bias]/60",
"op": "aten::addmm"
},
{
"attr": "...",
"input": [
"MyModule/Linear[weight]/54",
"MyModule/Linear[bias]/60"
],
"name": "MyModule/23",
"op": "prim::ListConstruct"
},
{
"attr": "...",
"name": "MyModule/24",
"op": "prim::Constant"
},
{
"attr": "...",
"input": [
"MyModule/23",
"MyModule/24"
],
"name": "MyModule/input",
"op": "aten::cat"
},
{
"attr": "...",
"name": "MyModule/61",
"op": "prim::Constant"
}
],
"versions": {
"producer": 22
}
}
```
## Environment
Not important.
## Additional context
<!-- Add any other context about the problem here. -->
Looks like this parse function is buggy. #33670 | triaged,module: tensorboard | low | Critical |
569,803,019 | rust | Make emitting an error necessary to acquire a `ErrorReported` token | `ErrorReported` indicates that a compiler error has been emitted, but currently it may be freely constructed. We should make it unconstructable, so that the only way to get one is to `.emit()` an error.
cc https://github.com/rust-lang/rust/pull/68434#discussion_r370961307 @eddyb @estebank | C-cleanup,T-compiler | low | Critical |
569,816,913 | flutter | Make the _TimePickerDialog easier to drive with Flutter driver | <!-- Thank you for using Flutter!
Please check out our documentation first:
* https://flutter.dev/
* https://api.flutter.dev/
If you can't find the answer there, please consider asking a question on
the Stack Overflow Web site:
* https://stackoverflow.com/questions/tagged/flutter?sort=frequent
Please don't file a GitHub issue for support requests. GitHub issues are
for tracking defects in the product. If you file a bug asking for help, we
will consider this a request for a documentation update.
-->
Currently I'm unable to select a time in the time picker dialog, I've had a look through the source code the tests for this use an offset which is fine for widget testing but not great for integration testing, can we have a key or a text to select the times | framework,f: material design,f: date/time picker,t: flutter driver,c: proposal,team-design,triaged-design | low | Critical |
569,825,613 | excalidraw | Close menu when deselecting | Steps:
1. select shape and open properties menu
2. click away to deselect (which closes the menu)
3. select some element, which opens the menu again
IMO this is non-intuitive (and it tends to use the same tap you used to select an element for clicking a button in the menu if it happens to be under pointer --- I tested this on devTools emulation only, so it may not be what's happening on real device). | mobile | low | Minor |
569,832,871 | node | HTTP2 bandwidth issues | * **Version**: 13.9.0
* **Platform**: Linux
Hi,
I've been trying to launch a simple app, copying directories containing files only, using HTTP2.
my implementation was simple - create http2 session and use concurrent streams within this session to transfer all the files in the directory.
First environment: server and client were both launched on a Linux machine on AWS ec2 service. the two Linux machines were in the same subnet.
At first, I tried to copy directories with lots of small files - 500k/600k/700k each 1KB.
the performance was really good.
However, when I tried to copy a directory with larger files - 300/200/100 files 1GB each, the performance was poor. I've tried to change MaxSessionMemory but there was no change.
Then, I've tried to change my implementation. I opened a new session **for each file**. This improved the performance of the directories with the large files significantly, but the performance of the directories with small files was worse than before.
I had no idea why it's happening, so I just decided to set some sort of threshold "x" for file's size - If the file size was smaller then x, then don't initiate a new session and use the existing one, else - initiate a new session to copy the file. That way, I thought I overcame this obstacle.
But, unfortunately, I was wrong. My next target was to try to copy the files over the internet. So I've tried to launch server and client on Linux machines in **different regions**.
This time, the best performance for both scenarios was to create a new session for each file - even for directories with lots of small files.
PS - by saying "poor performance" I mean that I checked bandwidth using "bmon", and saw big bandwidth differences.
Also, tried to change initialWindowSize, but didn't work.
I'm not so familiar with the http2 protocol itself, but I think maybe we need to have some sort of a way to control the session memory and the stream's memory at the session, maybe that's the problem.
reproduce:
https://github.com/Rantoledo/http2_nodejs_client_server_example2
| http2 | low | Major |
569,846,960 | pytorch | JIT tracing check fails with boolean tensor modifications | ## 🐛 Bug
Tracing code that modifies a boolean tensor fails with TracingCheckError. Tracing works only with `torch.jit.trace(..., check_trace=False)`.
## To Reproduce
Small repro case:
```
import torch
import torch.nn
class Model(torch.nn.Module):
def __init__(self):
super().__init__()
def forward(self):
mask = torch.zeros(5, dtype=torch.bool)
mask[1] = True
return mask
model = Model()
# fails with torch.jit.TracingCheckError
traced_model = torch.jit.trace(model, ())
# works
#traced_model = torch.jit.trace(model, (), check_trace=False)
```
Running `python bool_trace.py` fails with:
```
Traceback (most recent call last):
File "bool_trace.py", line 17, in <module>
traced_model = torch.jit.trace(model, ())
File "/home/jarno/miniconda3/envs/scratch/lib/python3.6/site-packages/torch/jit/__init__.py", line 882, in trace
check_tolerance, _force_outplace, _module_class)
File "/home/jarno/miniconda3/envs/scratch/lib/python3.6/site-packages/torch/jit/__init__.py", line 1044, in trace_module
check_tolerance, _force_outplace, True, _module_class)
File "/home/jarno/miniconda3/envs/scratch/lib/python3.6/site-packages/torch/autograd/grad_mode.py", line 49, in decorate_no_grad
return func(*args, **kwargs)
File "/home/jarno/miniconda3/envs/scratch/lib/python3.6/site-packages/torch/jit/__init__.py", line 685, in _check_trace
raise TracingCheckError(*diag_info)
torch.jit.TracingCheckError: Tracing failed sanity checks!
ERROR: Tensor-valued Constant nodes differed in value across invocations. This often indicates that the tracer has encountered untraceable code.
Node:
%11 : Tensor = prim::Constant[value={1}]() # bool_trace.py:12:0
Source Location:
bool_trace.py(12): forward
/home/jarno/miniconda3/envs/scratch/lib/python3.6/site-packages/torch/nn/modules/module.py(516): _slow_forward
/home/jarno/miniconda3/envs/scratch/lib/python3.6/site-packages/torch/nn/modules/module.py(530): __call__
/home/jarno/miniconda3/envs/scratch/lib/python3.6/site-packages/torch/jit/__init__.py(1034): trace_module
/home/jarno/miniconda3/envs/scratch/lib/python3.6/site-packages/torch/jit/__init__.py(882): trace
bool_trace.py(17): <module>
Comparison exception: Subtraction, the `-` operator, with two bool tensors is not supported. Use the `^` or `logical_xor()` operator instead.
```
## Expected behavior
tracing should work equally well with `check_trace=True` as `=False`
## Environment
```
Collecting environment information...
PyTorch version: 1.4.0
Is debug build: No
CUDA used to build PyTorch: 10.1
OS: Ubuntu 18.04.4 LTS
GCC version: (Ubuntu 7.4.0-1ubuntu1~18.04.1) 7.4.0
CMake version: version 3.10.2
Python version: 3.6
Is CUDA available: No
CUDA runtime version: No CUDA
GPU models and configuration: No CUDA
Nvidia driver version: No CUDA
cuDNN version: No CUDA
Versions of relevant libraries:
[pip] numpy==1.18.1
[pip] torch==1.4.0
[conda] blas 1.0 mkl
[conda] mkl 2020.0 166
[conda] mkl-service 2.3.0 py36he904b0f_0
[conda] mkl_fft 1.0.15 py36ha843d7b_0
[conda] mkl_random 1.1.0 py36hd6b4f25_0
[conda] pytorch 1.4.0 py3.6_cuda10.1.243_cudnn7.6.3_0 pytorch
```
cc @suo | triage review,oncall: jit,actionable | low | Critical |
569,870,113 | flutter | Include current tree depth in BuildContext | I have a system that is using StreamBuilders in the Widget tree. Changes to the system are directly published to the streams and will cause the Widget tree to rerender. However, that can cause some updates to no longer be relevant. I would like to only trigger updates that are necessary by targeting streams higher in the build tree first.
I found I can use: `findRenderObject`, but it doesn't seem like it designed for something like this (performance wise).
Can't the BuildContext be aware of it's depth in the Widget tree? Or is there another way to do this.
Any help is appreciated. | c: new feature,framework,d: stackoverflow,P3,team-framework,triaged-framework | low | Major |
569,874,423 | flutter | OpenContainer should support Hero animations (Focal Elements). | ## Steps to Reproduce
1. Copy https://github.com/flutter/packages/tree/master/packages/animations
2. Open container_transition.dart in exmalpe app
3. Wrap the same Image.asset into Hero widget with the same tag (both line 294 for _ExampleCard and 476 in _DetailsPage)
4. Run the example app, enter the "Container transform" and tap the first card.
**Expected results:** Hero widget "flies" between screens with container animation as well.
**Actual results:** Hero animation does not work, only container animation is played.
<details>
<summary>Logs</summary>
<!--
Run your application with `flutter run --verbose` and attach all the
log output below between the lines with the backticks. If there is an
exception, please see if the error message includes enough information
to explain how to solve the issue.
-->
```
Microsoft Windows [Version 10.0.18362.657]
nts\Repos\packages\packages\animations>flutter run --verbose
[ +23 ms] executing: [C:\Android\flutter/] git -c log.showSignature=false log -n 1 --pretty=format:%H
[ +102 ms] Exit code 0 from: git -c log.showSignature=false log -n 1 --pretty=format:%H
[ +2 ms] fabeb2a16f1d008ab8230f450c49141d35669798
[ ] executing: [C:\Android\flutter/] git describe --match v*.*.* --first-parent --long --tags
[ +119 ms] Exit code 0 from: git describe --match v*.*.* --first-parent --long --tags
[ ] v1.14.6-0-gfabeb2a16
[ +5 ms] executing: [C:\Android\flutter/] git rev-parse --abbrev-ref --symbolic @{u}
[ +39 ms] Exit code 0 from: git rev-parse --abbrev-ref --symbolic @{u}
[ ] origin/beta
[ ] executing: [C:\Android\flutter/] git ls-remote --get-url origin
[ +43 ms] Exit code 0 from: git ls-remote --get-url origin
[ ] https://github.com/flutter/flutter.git
[ +75 ms] executing: [C:\Android\flutter/] git rev-parse --abbrev-ref HEAD
[ +34 ms] Exit code 0 from: git rev-parse --abbrev-ref HEAD
[ ] beta
[ +38 ms] Artifact Instance of 'AndroidMavenArtifacts' is not required, skipping update.
[ ] Artifact Instance of 'AndroidGenSnapshotArtifacts' is not required, skipping update.
[ +1 ms] Artifact Instance of 'AndroidInternalBuildArtifacts' is not required, skipping update.
[ ] Artifact Instance of 'IOSEngineArtifacts' is not required, skipping update.
[ ] Artifact Instance of 'FlutterWebSdk' is not required, skipping update.
[ +11 ms] Artifact Instance of 'WindowsEngineArtifacts' is not required, skipping update.
[ ] Artifact Instance of 'MacOSEngineArtifacts' is not required, skipping update.
[ ] Artifact Instance of 'LinuxEngineArtifacts' is not required, skipping update.
[ ] Artifact Instance of 'LinuxFuchsiaSDKArtifacts' is not required, skipping update.
[ ] Artifact Instance of 'MacOSFuchsiaSDKArtifacts' is not required, skipping update.
[ ] Artifact Instance of 'FlutterRunnerSDKArtifacts' is not required, skipping update.
[ ] Artifact Instance of 'FlutterRunnerDebugSymbols' is not required, skipping update.
[ +31 ms] executing: C:\Android\sdk\platform-tools\adb.exe devices -l
[ +28 ms] Exit code 0 from: C:\Android\sdk\platform-tools\adb.exe devices -l
[ +1 ms] List of devices attached
RF8M80G7PGZ device product:beyond0lteeea model:SM_G970F device:beyond0 transport_id:23
[ +9 ms] C:\Android\sdk\platform-tools\adb.exe -s RF8M80G7PGZ shell getprop
[ +90 ms] Artifact Instance of 'AndroidMavenArtifacts' is not required, skipping update.
[ +9 ms] Artifact Instance of 'AndroidInternalBuildArtifacts' is not required, skipping update.
[ ] Artifact Instance of 'IOSEngineArtifacts' is not required, skipping update.
[ ] Artifact Instance of 'FlutterWebSdk' is not required, skipping update.
[ +2 ms] Artifact Instance of 'WindowsEngineArtifacts' is not required, skipping update.
[ ] Artifact Instance of 'MacOSEngineArtifacts' is not required, skipping update.
[ ] Artifact Instance of 'LinuxEngineArtifacts' is not required, skipping update.
[ +1 ms] Artifact Instance of 'LinuxFuchsiaSDKArtifacts' is not required, skipping update.
[ ] Artifact Instance of 'MacOSFuchsiaSDKArtifacts' is not required, skipping update.
[ ] Artifact Instance of 'FlutterRunnerSDKArtifacts' is not required, skipping update.
[ ] Artifact Instance of 'FlutterRunnerDebugSymbols' is not required, skipping update.
[ +15 ms] "flutter run" took 281ms.
Target file "lib\main.dart" not found.
#0 FlutterCommand.validateCommand (package:flutter_tools/src/runner/flutter_command.dart:739:9)
#1 RunCommand.validateCommand (package:flutter_tools/src/commands/run.dart:320:19)
#2 FlutterCommand.verifyThenRunCommand (package:flutter_tools/src/runner/flutter_command.dart:619:11)
<asynchronous suspension>
#3 FlutterCommand.run.<anonymous closure> (package:flutter_tools/src/runner/flutter_command.dart:537:33)
<asynchronous suspension>
#4 AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:150:29)
#5 _rootRun (dart:async/zone.dart:1126:13)
#6 _CustomZone.run (dart:async/zone.dart:1023:19)
#7 _runZoned (dart:async/zone.dart:1518:10)
#8 runZoned (dart:async/zone.dart:1465:12)
#9 AppContext.run (package:flutter_tools/src/base/context.dart:149:18)
#10 FlutterCommand.run (package:flutter_tools/src/runner/flutter_command.dart:527:20)
#11 CommandRunner.runCommand (package:args/command_runner.dart:197:27)
#12 FlutterCommandRunner.runCommand.<anonymous closure> (package:flutter_tools/src/runner/flutter_command_runner.dart:338:21)
<asynchronous suspension>
#13 AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:150:29)
#14 _rootRun (dart:async/zone.dart:1126:13)
#15 _CustomZone.run (dart:async/zone.dart:1023:19)
#16 _runZoned (dart:async/zone.dart:1518:10)
#17 runZoned (dart:async/zone.dart:1465:12)
#18 AppContext.run (package:flutter_tools/src/base/context.dart:149:18)
#19 FlutterCommandRunner.runCommand (package:flutter_tools/src/runner/flutter_command_runner.dart:288:19)
#20 CommandRunner.run.<anonymous closure> (package:args/command_runner.dart:112:25)
#21 new Future.sync (dart:async/future.dart:224:31)
#22 CommandRunner.run (package:args/command_runner.dart:112:14)
#23 FlutterCommandRunner.run (package:flutter_tools/src/runner/flutter_command_runner.dart:231:18)
#24 run.<anonymous closure>.<anonymous closure> (package:flutter_tools/runner.dart:64:22)
#25 _rootRun (dart:async/zone.dart:1126:13)
#26 _CustomZone.run (dart:async/zone.dart:1023:19)
#27 _runZoned (dart:async/zone.dart:1518:10)
#28 runZoned (dart:async/zone.dart:1502:12)
#29 run.<anonymous closure> (package:flutter_tools/runner.dart:62:18)
<asynchronous suspension>
#30 AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:150:29)
#31 _rootRun (dart:async/zone.dart:1126:13)
#32 _CustomZone.run (dart:async/zone.dart:1023:19)
#33 _runZoned (dart:async/zone.dart:1518:10)
#34 runZoned (dart:async/zone.dart:1465:12)
#35 AppContext.run (package:flutter_tools/src/base/context.dart:149:18)
#36 runInContext (package:flutter_tools/src/context_runner.dart:64:24)
#37 run (package:flutter_tools/runner.dart:51:10)
#38 main (package:flutter_tools/executable.dart:65:9)
#39 main (file:///C:/Android/flutter/packages/flutter_tools/bin/flutter_tools.dart:8:3)
#40 _startIsolate.<anonymous closure> (dart:isolate-patch/isolate_patch.dart:299:32)
#41 _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:168:12)
C:\Users\msienczyk\Documents\Repos\packages\packages\animations>
C:\Users\msienczyk\Documents\Repos\packages\packages\animations>cd example
C:\Users\msienczyk\Documents\Repos\packages\packages\animations\example>flutter run --verbose
[ +22 ms] executing: [C:\Android\flutter/] git -c log.showSignature=false log -n 1 --pretty=format:%H
[ +71 ms] Exit code 0 from: git -c log.showSignature=false log -n 1 --pretty=format:%H
[ ] fabeb2a16f1d008ab8230f450c49141d35669798
[ ] executing: [C:\Android\flutter/] git describe --match v*.*.* --first-parent --long --tags
[ +67 ms] Exit code 0 from: git describe --match v*.*.* --first-parent --long --tags
[ ] v1.14.6-0-gfabeb2a16
[ +5 ms] executing: [C:\Android\flutter/] git rev-parse --abbrev-ref --symbolic @{u}
[ +37 ms] Exit code 0 from: git rev-parse --abbrev-ref --symbolic @{u}
[ ] origin/beta
[ ] executing: [C:\Android\flutter/] git ls-remote --get-url origin
[ +42 ms] Exit code 0 from: git ls-remote --get-url origin
[ ] https://github.com/flutter/flutter.git
[ +66 ms] executing: [C:\Android\flutter/] git rev-parse --abbrev-ref HEAD
[ +30 ms] Exit code 0 from: git rev-parse --abbrev-ref HEAD
[ ] beta
[ +31 ms] Artifact Instance of 'AndroidMavenArtifacts' is not required, skipping update.
[ ] Artifact Instance of 'AndroidGenSnapshotArtifacts' is not required, skipping update.
[ ] Artifact Instance of 'AndroidInternalBuildArtifacts' is not required, skipping update.
[ ] Artifact Instance of 'IOSEngineArtifacts' is not required, skipping update.
[ ] Artifact Instance of 'FlutterWebSdk' is not required, skipping update.
[ +3 ms] Artifact Instance of 'WindowsEngineArtifacts' is not required, skipping update.
[ ] Artifact Instance of 'MacOSEngineArtifacts' is not required, skipping update.
[ ] Artifact Instance of 'LinuxEngineArtifacts' is not required, skipping update.
[ ] Artifact Instance of 'LinuxFuchsiaSDKArtifacts' is not required, skipping update.
[ ] Artifact Instance of 'MacOSFuchsiaSDKArtifacts' is not required, skipping update.
[ ] Artifact Instance of 'FlutterRunnerSDKArtifacts' is not required, skipping update.
[ ] Artifact Instance of 'FlutterRunnerDebugSymbols' is not required, skipping update.
[ +33 ms] executing: C:\Android\sdk\platform-tools\adb.exe devices -l
[ +25 ms] Exit code 0 from: C:\Android\sdk\platform-tools\adb.exe devices -l
[ ] List of devices attached
RF8M80G7PGZ device product:beyond0lteeea model:SM_G970F device:beyond0 transport_id:23
[ +9 ms] C:\Android\sdk\platform-tools\adb.exe -s RF8M80G7PGZ shell getprop
[ +83 ms] Artifact Instance of 'AndroidMavenArtifacts' is not required, skipping update.
[ +3 ms] Artifact Instance of 'AndroidInternalBuildArtifacts' is not required, skipping update.
[ ] Artifact Instance of 'IOSEngineArtifacts' is not required, skipping update.
[ ] Artifact Instance of 'FlutterWebSdk' is not required, skipping update.
[ +2 ms] Artifact Instance of 'WindowsEngineArtifacts' is not required, skipping update.
[ ] Artifact Instance of 'MacOSEngineArtifacts' is not required, skipping update.
[ ] Artifact Instance of 'LinuxEngineArtifacts' is not required, skipping update.
[ ] Artifact Instance of 'LinuxFuchsiaSDKArtifacts' is not required, skipping update.
[ ] Artifact Instance of 'MacOSFuchsiaSDKArtifacts' is not required, skipping update.
[ ] Artifact Instance of 'FlutterRunnerSDKArtifacts' is not required, skipping update.
[ ] Artifact Instance of 'FlutterRunnerDebugSymbols' is not required, skipping update.
[ +157 ms] Generating C:\Users\msienczyk\Documents\Repos\packages\packages\animations\example\android\app\src\main\java\io\flutter\plugins\GeneratedPluginRegistrant.java
[ +21 ms] ro.hardware = exynos9820
[ ] ro.build.characteristics = phone
[ +33 ms] Launching lib\main.dart on SM G970F in debug mode...
[ +8 ms] executing: C:\Android\sdk\build-tools\29.0.2\aapt dump xmltree C:\Users\msienczyk\Documents\Repos\packages\packages\animations\example\build\app\outputs\apk\app.apk AndroidManifest.xml
[ +22 ms] Exit code 0 from: C:\Android\sdk\build-tools\29.0.2\aapt dump xmltree C:\Users\msienczyk\Documents\Repos\packages\packages\animations\example\build\app\outputs\apk\app.apk AndroidManifest.xml
[ ] N: android=http://schemas.android.com/apk/res/android
E: manifest (line=2)
A: android:versionCode(0x0101021b)=(type 0x10)0x1
A: android:versionName(0x0101021c)="0.0.1" (Raw: "0.0.1")
A: android:compileSdkVersion(0x01010572)=(type 0x10)0x1c
A: android:compileSdkVersionCodename(0x01010573)="9" (Raw: "9")
A: package="dev.flutter.packages.animations.example" (Raw: "dev.flutter.packages.animations.example")
A: platformBuildVersionCode=(type 0x10)0x1c
A: platformBuildVersionName=(type 0x10)0x9
E: uses-sdk (line=7)
A: android:minSdkVersion(0x0101020c)=(type 0x10)0x10
A: android:targetSdkVersion(0x01010270)=(type 0x10)0x1c
E: uses-permission (line=14)
A: android:name(0x01010003)="android.permission.INTERNET" (Raw: "android.permission.INTERNET")
E: application (line=22)
A: android:label(0x01010001)="example" (Raw: "example")
A: android:icon(0x01010002)=@0x7f080000
A: android:name(0x01010003)="io.flutter.app.FlutterApplication" (Raw: "io.flutter.app.FlutterApplication")
A: android:debuggable(0x0101000f)=(type 0x12)0xffffffff
A: android:appComponentFactory(0x0101057a)="androidx.core.app.CoreComponentFactory" (Raw: "androidx.core.app.CoreComponentFactory")
E: activity (line=28)
A: android:theme(0x01010000)=@0x7f0a0000
A: android:name(0x01010003)="dev.flutter.packages.animations.example.MainActivity" (Raw: "dev.flutter.packages.animations.example.MainActivity")
A: android:launchMode(0x0101001d)=(type 0x10)0x1
A: android:configChanges(0x0101001f)=(type 0x11)0x40003fb4
A: android:windowSoftInputMode(0x0101022b)=(type 0x11)0x10
A: android:hardwareAccelerated(0x010102d3)=(type 0x12)0xffffffff
E: intent-filter (line=35)
E: action (line=36)
A: android:name(0x01010003)="android.intent.action.MAIN" (Raw: "android.intent.action.MAIN")
E: category (line=38)
A: android:name(0x01010003)="android.intent.category.LAUNCHER" (Raw: "android.intent.category.LAUNCHER")
E: meta-data (line=45)
A: android:name(0x01010003)="flutterEmbedding" (Raw: "flutterEmbedding")
A: android:value(0x01010024)=(type 0x10)0x2
[ +5 ms] executing: C:\Android\sdk\platform-tools\adb.exe -s RF8M80G7PGZ shell -x logcat -v time -t 1
[ +120 ms] Exit code 0 from: C:\Android\sdk\platform-tools\adb.exe -s RF8M80G7PGZ shell -x logcat -v time -t 1
[ ] --------- beginning of main
02-24 14:56:48.908 D/[DOP]ControlUtils(20151): [208:run] ConnDaemonInitThread App start indication listening...
[ +5 ms] executing: C:\Android\sdk\platform-tools\adb.exe version
[ +1 ms] executing: C:\Android\sdk\platform-tools\adb.exe -s RF8M80G7PGZ logcat -v time -T 02-24 14:56:48.908
[ +98 ms] Android Debug Bridge version 1.0.41
Version 29.0.5-5949299
Installed as C:\Android\sdk\platform-tools\adb.exe
[ +2 ms] executing: C:\Android\sdk\platform-tools\adb.exe start-server
[ +26 ms] Building APK
[ +14 ms] Running Gradle task 'assembleDebug'...
[ +2 ms] gradle.properties already sets `android.enableR8`
[ +3 ms] Using gradle from C:\Users\msienczyk\Documents\Repos\packages\packages\animations\example\android\gradlew.bat.
[ +1 ms] C:\Users\msienczyk\Documents\Repos\packages\packages\animations\example\android\gradlew.bat mode: 33279 rwxrwxrwx.
[ +5 ms] executing: C:\Android\Android Studio\jre\bin\java -version
[ +99 ms] Exit code 0 from: C:\Android\Android Studio\jre\bin\java -version
[ ] openjdk version "1.8.0_202-release"
OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b03)
OpenJDK 64-Bit Server VM (build 25.202-b03, mixed mode)
[ +2 ms] executing: [C:\Users\msienczyk\Documents\Repos\packages\packages\animations\example\android/] C:\Users\msienczyk\Documents\Repos\packages\packages\animations\example\android\gradlew.bat -Pverbose=true
-Ptarget=C:\Users\msienczyk\Documents\Repos\packages\packages\animations\example\lib\main.dart -Ptrack-widget-creation=true -Pfilesystem-scheme=org-dartlang-root -Ptarget-platform=android-arm64 assembleDebug
[+3911 ms] > Task :app:compileFlutterBuildDebug
[ ] [ +19 ms] executing: [C:\Android\flutter/] git -c log.showSignature=false log -n 1 --pretty=format:%H
[ ] [ +79 ms] Exit code 0 from: git -c log.showSignature=false log -n 1 --pretty=format:%H
[ ] [ ] fabeb2a16f1d008ab8230f450c49141d35669798
[ ] [ ] executing: [C:\Android\flutter/] git describe --match v*.*.* --first-parent --long --tags
[ ] [ +71 ms] Exit code 0 from: git describe --match v*.*.* --first-parent --long --tags
[ ] [ ] v1.14.6-0-gfabeb2a16
[ ] [ +5 ms] executing: [C:\Android\flutter/] git rev-parse --abbrev-ref --symbolic @{u}
[ ] [ +31 ms] Exit code 0 from: git rev-parse --abbrev-ref --symbolic @{u}
[ ] [ ] origin/beta
[ ] [ ] executing: [C:\Android\flutter/] git ls-remote --get-url origin
[ ] [ +48 ms] Exit code 0 from: git ls-remote --get-url origin
[ ] [ ] https://github.com/flutter/flutter.git
[ ] [ +68 ms] executing: [C:\Android\flutter/] git rev-parse --abbrev-ref HEAD
[ ] [ +35 ms] Exit code 0 from: git rev-parse --abbrev-ref HEAD
[ ] [ ] beta
[ ] [ +16 ms] Artifact Instance of 'AndroidMavenArtifacts' is not required, skipping update.
[ ] [ ] Artifact Instance of 'AndroidGenSnapshotArtifacts' is not required, skipping update.
[ ] [ ] Artifact Instance of 'AndroidInternalBuildArtifacts' is not required, skipping update.
[ ] [ ] Artifact Instance of 'IOSEngineArtifacts' is not required, skipping update.
[ ] [ ] Artifact Instance of 'FlutterWebSdk' is not required, skipping update.
[ ] [ +2 ms] Artifact Instance of 'WindowsEngineArtifacts' is not required, skipping update.
[ ] [ ] Artifact Instance of 'MacOSEngineArtifacts' is not required, skipping update.
[ ] [ ] Artifact Instance of 'LinuxEngineArtifacts' is not required, skipping update.
[ ] [ ] Artifact Instance of 'LinuxFuchsiaSDKArtifacts' is not required, skipping update.
[ ] [ ] Artifact Instance of 'MacOSFuchsiaSDKArtifacts' is not required, skipping update.
[ ] [ ] Artifact Instance of 'FlutterRunnerSDKArtifacts' is not required, skipping update.
[ ] [ ] Artifact Instance of 'FlutterRunnerDebugSymbols' is not required, skipping update.
[ ] [ +10 ms] Artifact Instance of 'MaterialFonts' is not required, skipping update.
[ ] [ ] Artifact Instance of 'GradleWrapper' is not required, skipping update.
[ ] [ ] Artifact Instance of 'AndroidMavenArtifacts' is not required, skipping update.
[ ] [ ] Artifact Instance of 'AndroidGenSnapshotArtifacts' is not required, skipping update.
[ ] [ ] Artifact Instance of 'AndroidInternalBuildArtifacts' is not required, skipping update.
[ ] [ ] Artifact Instance of 'IOSEngineArtifacts' is not required, skipping update.
[ ] [ ] Artifact Instance of 'FlutterWebSdk' is not required, skipping update.
[ ] [ ] Artifact Instance of 'FlutterSdk' is not required, skipping update.
[ ] [ ] Artifact Instance of 'WindowsEngineArtifacts' is not required, skipping update.
[ ] [ ] Artifact Instance of 'MacOSEngineArtifacts' is not required, skipping update.
[ ] [ ] Artifact Instance of 'LinuxEngineArtifacts' is not required, skipping update.
[ ] [ ] Artifact Instance of 'LinuxFuchsiaSDKArtifacts' is not required, skipping update.
[ ] [ ] Artifact Instance of 'MacOSFuchsiaSDKArtifacts' is not required, skipping update.
[ ] [ ] Artifact Instance of 'FlutterRunnerSDKArtifacts' is not required, skipping update.
[ ] [ ] Artifact Instance of 'FlutterRunnerDebugSymbols' is not required, skipping update.
[ ] [ ] Artifact Instance of 'IosUsbArtifacts' is not required, skipping update.
[ ] [ ] Artifact Instance of 'IosUsbArtifacts' is not required, skipping update.
[ ] [ ] Artifact Instance of 'IosUsbArtifacts' is not required, skipping update.
[ ] [ ] Artifact Instance of 'IosUsbArtifacts' is not required, skipping update.
[ ] [ ] Artifact Instance of 'IosUsbArtifacts' is not required, skipping update.
[ ] [ ] Artifact Instance of 'IosUsbArtifacts' is not required, skipping update.
[ ] [ ] Artifact Instance of 'IosUsbArtifacts' is not required, skipping update.
[ ] [ ] Artifact Instance of 'FontSubsetArtifacts' is not required, skipping update.
[ ] [ +56 ms] Initializing file store
[ ] [ +15 ms] Done initializing file store
[ +268 ms] [+1301 ms] kernel_snapshot: Starting due to {InvalidatedReason.inputChanged}
[ +2 ms] [ +10 ms] C:\Android\flutter\bin\cache\dart-sdk\bin\dart.exe C:\Android\flutter\bin\cache\artifacts\engine\windows-x64\frontend_server.dart.snapshot --sdk-root C:\Android\flutter\bin\cache\artifacts\engine\common\flutter_patched_sdk/ --target=flutter
-Ddart.developer.causal_async_stacks=true -Ddart.vm.profile=false -Ddart.vm.product=false --bytecode-options=source-positions,local-var-info,debugger-stops,instance-field-initializers,keep-unreachable-code,avoid-closure-call-instructions --enable-asserts
--track-widget-creation --no-link-platform --packages C:\Users\msienczyk\Documents\Repos\packages\packages\animations\example\.packages --output-dill
C:\Users\msienczyk\Documents\Repos\packages\packages\animations\example\.dart_tool\flutter_build\dd90c711b07f76eb39b90d572d6164f7\app.dill --depfile
C:\Users\msienczyk\Documents\Repos\packages\packages\animations\example\.dart_tool\flutter_build\dd90c711b07f76eb39b90d572d6164f7\kernel_snapshot.d package:animations_example/main.dart
[+4698 ms] [+4699 ms] kernel_snapshot: Complete
[ +299 ms] [ +308 ms] debug_android_application: Starting due to {InvalidatedReason.inputChanged, InvalidatedReason.outputMissing}
[ +200 ms] [ +251 ms] debug_android_application: Complete
[ +1 ms] [ +13 ms] Persisting file store
[ ] [ +6 ms] Done persisting file store
[ ] [ +2 ms] build succeeded.
[ +96 ms] [ +10 ms] "flutter assemble" took 6 742ms.
[ +99 ms] > Task :app:packLibsflutterBuildDebug UP-TO-DATE
[ +1 ms] > Task :app:preBuild UP-TO-DATE
[ ] > Task :app:preDebugBuild UP-TO-DATE
[ ] > Task :app:checkDebugManifest UP-TO-DATE
[ ] > Task :app:generateDebugBuildConfig UP-TO-DATE
[ ] > Task :app:compileDebugRenderscript NO-SOURCE
[ ] > Task :app:compileDebugAidl NO-SOURCE
[ ] > Task :app:cleanMergeDebugAssets
[ +96 ms] > Task :app:mergeDebugShaders UP-TO-DATE
[ ] > Task :app:compileDebugShaders UP-TO-DATE
[ ] > Task :app:generateDebugAssets UP-TO-DATE
[ ] > Task :app:mergeDebugAssets
[ +196 ms] > Task :app:copyFlutterAssetsDebug
[ ] > Task :app:mainApkListPersistenceDebug UP-TO-DATE
[ ] > Task :app:generateDebugResValues UP-TO-DATE
[ ] > Task :app:generateDebugResources UP-TO-DATE
[ ] > Task :app:mergeDebugResources UP-TO-DATE
[ ] > Task :app:createDebugCompatibleScreenManifests UP-TO-DATE
[ +103 ms] > Task :app:processDebugManifest UP-TO-DATE
[ +13 ms] > Task :app:processDebugResources UP-TO-DATE
[ ] > Task :app:compileDebugKotlin UP-TO-DATE
[ ] > Task :app:javaPreCompileDebug UP-TO-DATE
[ ] > Task :app:compileDebugJavaWithJavac UP-TO-DATE
[ ] > Task :app:compileDebugSources UP-TO-DATE
[ ] > Task :app:processDebugJavaRes NO-SOURCE
[ ] > Task :app:mergeDebugJavaResource UP-TO-DATE
[ ] > Task :app:checkDebugDuplicateClasses UP-TO-DATE
[ +76 ms] > Task :app:transformClassesWithDexBuilderForDebug UP-TO-DATE
[ +2 ms] > Task :app:desugarDebugFileDependencies UP-TO-DATE
[ ] > Task :app:mergeExtDexDebug UP-TO-DATE
[ ] > Task :app:mergeDexDebug UP-TO-DATE
[ ] > Task :app:validateSigningDebug UP-TO-DATE
[ ] > Task :app:signingConfigWriterDebug UP-TO-DATE
[ ] > Task :app:mergeDebugJniLibFolders UP-TO-DATE
[ +93 ms] > Task :app:mergeDebugNativeLibs UP-TO-DATE
[ ] > Task :app:stripDebugDebugSymbols UP-TO-DATE
[+1251 ms] > Task :app:packageDebug
[ +3 ms] > Task :app:assembleDebug
[ +1 ms] BUILD SUCCESSFUL in 11s
[ ] 30 actionable tasks: 5 executed, 25 up-to-date
[ +362 ms] Running Gradle task 'assembleDebug'... (completed in 11,9s)
[ +23 ms] calculateSha: LocalDirectory: 'C:\Users\msienczyk\Documents\Repos\packages\packages\animations\example\build\app\outputs\apk'/app.apk
[ +45 ms] calculateSha: reading file took 44us
[ +485 ms] calculateSha: computing sha took 484us
[ +5 ms] √ Built build\app\outputs\apk\debug\app-debug.apk.
[ +6 ms] executing: C:\Android\sdk\build-tools\29.0.2\aapt dump xmltree C:\Users\msienczyk\Documents\Repos\packages\packages\animations\example\build\app\outputs\apk\app.apk AndroidManifest.xml
[ +15 ms] Exit code 0 from: C:\Android\sdk\build-tools\29.0.2\aapt dump xmltree C:\Users\msienczyk\Documents\Repos\packages\packages\animations\example\build\app\outputs\apk\app.apk AndroidManifest.xml
[ ] N: android=http://schemas.android.com/apk/res/android
E: manifest (line=2)
A: android:versionCode(0x0101021b)=(type 0x10)0x1
A: android:versionName(0x0101021c)="0.0.1" (Raw: "0.0.1")
A: android:compileSdkVersion(0x01010572)=(type 0x10)0x1c
A: android:compileSdkVersionCodename(0x01010573)="9" (Raw: "9")
A: package="dev.flutter.packages.animations.example" (Raw: "dev.flutter.packages.animations.example")
A: platformBuildVersionCode=(type 0x10)0x1c
A: platformBuildVersionName=(type 0x10)0x9
E: uses-sdk (line=7)
A: android:minSdkVersion(0x0101020c)=(type 0x10)0x10
A: android:targetSdkVersion(0x01010270)=(type 0x10)0x1c
E: uses-permission (line=14)
A: android:name(0x01010003)="android.permission.INTERNET" (Raw: "android.permission.INTERNET")
E: application (line=22)
A: android:label(0x01010001)="example" (Raw: "example")
A: android:icon(0x01010002)=@0x7f080000
A: android:name(0x01010003)="io.flutter.app.FlutterApplication" (Raw: "io.flutter.app.FlutterApplication")
A: android:debuggable(0x0101000f)=(type 0x12)0xffffffff
A: android:appComponentFactory(0x0101057a)="androidx.core.app.CoreComponentFactory" (Raw: "androidx.core.app.CoreComponentFactory")
E: activity (line=28)
A: android:theme(0x01010000)=@0x7f0a0000
A: android:name(0x01010003)="dev.flutter.packages.animations.example.MainActivity" (Raw: "dev.flutter.packages.animations.example.MainActivity")
A: android:launchMode(0x0101001d)=(type 0x10)0x1
A: android:configChanges(0x0101001f)=(type 0x11)0x40003fb4
A: android:windowSoftInputMode(0x0101022b)=(type 0x11)0x10
A: android:hardwareAccelerated(0x010102d3)=(type 0x12)0xffffffff
E: intent-filter (line=35)
E: action (line=36)
A: android:name(0x01010003)="android.intent.action.MAIN" (Raw: "android.intent.action.MAIN")
E: category (line=38)
A: android:name(0x01010003)="android.intent.category.LAUNCHER" (Raw: "android.intent.category.LAUNCHER")
E: meta-data (line=45)
A: android:name(0x01010003)="flutterEmbedding" (Raw: "flutterEmbedding")
A: android:value(0x01010024)=(type 0x10)0x2
[ +1 ms] Stopping app 'app.apk' on SM G970F.
[ +1 ms] executing: C:\Android\sdk\platform-tools\adb.exe -s RF8M80G7PGZ shell am force-stop dev.flutter.packages.animations.example
[ +127 ms] executing: C:\Android\sdk\platform-tools\adb.exe -s RF8M80G7PGZ shell pm list packages dev.flutter.packages.animations.example
[ +99 ms] package:dev.flutter.packages.animations.example
[ +3 ms] executing: C:\Android\sdk\platform-tools\adb.exe -s RF8M80G7PGZ shell cat /data/local/tmp/sky.dev.flutter.packages.animations.example.sha1
[ +53 ms] dcd2239586bb16ab31dce537bdf5e207480ac1fc
[ +1 ms] Installing APK.
[ +1 ms] executing: C:\Android\sdk\platform-tools\adb.exe version
[ +25 ms] Android Debug Bridge version 1.0.41
Version 29.0.5-5949299
Installed as C:\Android\sdk\platform-tools\adb.exe
[ +1 ms] executing: C:\Android\sdk\platform-tools\adb.exe start-server
[ +25 ms] Installing build\app\outputs\apk\app.apk...
[ +1 ms] executing: C:\Android\sdk\platform-tools\adb.exe -s RF8M80G7PGZ install -t -r C:\Users\msienczyk\Documents\Repos\packages\packages\animations\example\build\app\outputs\apk\app.apk
[+12355 ms] Performing Streamed Install
Success
[ ] Installing build\app\outputs\apk\app.apk... (completed in 12,4s)
[ +1 ms] executing: C:\Android\sdk\platform-tools\adb.exe -s RF8M80G7PGZ shell echo -n 0a9088d1a7db6ac79011783a12534b343d6bc5ad > /data/local/tmp/sky.dev.flutter.packages.animations.example.sha1
[ +46 ms] SM G970F startApp
[ +1 ms] executing: C:\Android\sdk\platform-tools\adb.exe -s RF8M80G7PGZ shell am start -a android.intent.action.RUN -f 0x20000000 --ez enable-background-compilation true --ez enable-dart-profiling true --ez enable-checked-mode true --ez verify-entry-points true
dev.flutter.packages.animations.example/dev.flutter.packages.animations.example.MainActivity
[ +151 ms] Starting: Intent { act=android.intent.action.RUN flg=0x20000000 cmp=dev.flutter.packages.animations.example/.MainActivity (has extras) }
[ +1 ms] Waiting for observatory port to be available...
[+4993 ms] Observatory URL on device: http://127.0.0.1:36873/Xo7I_DIzhB0=/
[ +2 ms] executing: C:\Android\sdk\platform-tools\adb.exe -s RF8M80G7PGZ forward tcp:0 tcp:36873
[ +34 ms] 50583
[ ] Forwarded host port 50583 to device port 36873 for Observatory
[ +6 ms] Connecting to service protocol: http://127.0.0.1:50583/Xo7I_DIzhB0=/
[+1115 ms] Successfully connected to service protocol: http://127.0.0.1:50583/Xo7I_DIzhB0=/
[ +7 ms] Sending to VM service: getVM({})
[ +18 ms] Result: {type: VM, name: vm, architectureBits: 64, hostCPU: Unknown, operatingSystem: android, targetCPU: arm64, version: 2.8.0-dev.5.0.flutter-fc3af737c7 (Fri Jan 24 09:53:26 2020 +0000) on "android_arm64", _profilerMode: VM, _nativeZoneMemoryUsage: 0,
p...
[ +4 ms] Sending to VM service: getIsolate({isolateId: isolates/4327579177820019})
[ +2 ms] Sending to VM service: _flutter.listViews({})
[ +24 ms] Result: {type: FlutterViewList, views: [{type: FlutterView, id: _flutterView/0x77efdc0420, isolate: {type: @Isolate, fixedId: true, id: isolates/4327579177820019, name: main.dart$main-4327579177820019, number: 4327579177820019}}]}
[ +4 ms] DevFS: Creating new filesystem on the device (null)
[ +1 ms] Sending to VM service: _createDevFS({fsName: example})
[ +212 ms] Result: {type: Isolate, id: isolates/4327579177820019, name: main, number: 4327579177820019, _originNumber: 4327579177820019, startTime: 1582552639247, _heaps: {new: {type: HeapSpace, name: new, vmName: Scavenger, collections: 0,
avgCollectionPeriodMillis...
[ +9 ms] Result: {type: FileSystem, name: example, uri: file:///data/user/0/dev.flutter.packages.animations.example/code_cache/exampleXBVUVQ/example/}
[ +1 ms] DevFS: Created new filesystem on the device (file:///data/user/0/dev.flutter.packages.animations.example/code_cache/exampleXBVUVQ/example/)
[ +2 ms] Updating assets
[ +72 ms] Syncing files to device SM G970F...
[ +2 ms] Scanning asset files
[ +2 ms] <- reset
[ ] Compiling dart to kernel with 0 updated files
[ +6 ms] C:\Android\flutter\bin\cache\dart-sdk\bin\dart.exe C:\Android\flutter\bin\cache\artifacts\engine\windows-x64\frontend_server.dart.snapshot --sdk-root C:\Android\flutter\bin\cache\artifacts\engine\common\flutter_patched_sdk/ --incremental --target=flutter
-Ddart.developer.causal_async_stacks=true --output-dill C:\Users\MSIENC~1\AppData\Local\Temp\flutter_tool.8004f22d-570d-11ea-9502-c8f7500069cb\app.dill --packages C:\Users\msienczyk\Documents\Repos\packages\packages\animations\example\.packages
-Ddart.vm.profile=false -Ddart.vm.product=false --bytecode-options=source-positions,local-var-info,debugger-stops,instance-field-initializers,keep-unreachable-code,avoid-closure-call-instructions --enable-asserts --track-widget-creation --filesystem-scheme
org-dartlang-root
[ +4 ms] <- compile package:animations_example/main.dart
[ +3 ms] D/SurfaceView(20985): onWindowVisibilityChanged(4) false io.flutter.embedding.android.FlutterSurfaceView{66fb4c9 V.E...... ......I. 0,0-0,0} of ViewRootImpl@f58ab2a[MainActivity]
[ +37 ms] D/ViewRootImpl@f58ab2a[MainActivity](20985): Relayout returned: old=[0,0][1080,2280] new=[0,0][1080,2280] req=(0,0)4 dur=8 res=0x1 s={false 0} ch=false
[ +33 ms] D/ViewRootImpl@f58ab2a[MainActivity](20985): stopped(false) old=true
[ +6 ms] D/SurfaceView(20985): windowStopped(false) false io.flutter.embedding.android.FlutterSurfaceView{66fb4c9 V.E...... ......I. 0,0-0,0} of ViewRootImpl@f58ab2a[MainActivity]
[ +1 ms] D/ViewRootImpl@f58ab2a[MainActivity](20985): stopped(false) old=false
[ +3 ms] D/SurfaceView(20985): onWindowVisibilityChanged(0) true io.flutter.embedding.android.FlutterSurfaceView{66fb4c9 V.E...... ......I. 0,0-0,0} of ViewRootImpl@f58ab2a[MainActivity]
[ +2 ms] D/ViewRootImpl@f58ab2a[MainActivity](20985): Relayout returned: old=[0,0][1080,2280] new=[0,0][1080,2280] req=(1080,2280)0 dur=4 res=0x7 s={true 515125882880} ch=true
[ ] D/OpenGLRenderer(20985): createReliableSurface : 0x775cc1b6c0, 0x77efe53000
[ ] D/OpenGLRenderer(20985): SurfaceChanged : 0x0 -> 0x0
[ +2 ms] D/SurfaceView(20985): surfaceCreated 1 #8 io.flutter.embedding.android.FlutterSurfaceView{66fb4c9 V.E...... ......ID 0,0-1080,2136}
[ ] I/mali_winsys(20985): new_window_surface() [1080x2280] return: 0x3000
[ ] I/mali_winsys(20985): new_window_surface() [1080x2136] return: 0x3000
[ +481 ms] D/SurfaceView(20985): surfaceChanged (1080,2136) 1 #8 io.flutter.embedding.android.FlutterSurfaceView{66fb4c9 V.E...... ......ID 0,0-1080,2136}
[ +2 ms] D/OpenGLRenderer(20985): SurfaceChanged : 0x0 -> 0x775cc1e080
[ +4 ms] W/Gralloc3(20985): mapper 3.x is not supported
[ +7 ms] I/gralloc (20985): Arm Module v1.0
[ +126 ms] D/ViewRootImpl@f58ab2a[MainActivity](20985): MSG_RESIZED_REPORT: frame=[0,0][1080,2280] ci=[0,117][0,144] vi=[0,117][0,144] or=1
[ +20 ms] D/ViewRootImpl@f58ab2a[MainActivity](20985): MSG_RESIZED_REPORT: frame=[0,0][1080,2280] ci=[0,117][0,144] vi=[0,117][0,144] or=1
[ +65 ms] D/ViewRootImpl@f58ab2a[MainActivity](20985): MSG_WINDOW_FOCUS_CHANGED 1 1
[ +1 ms] D/InputMethodManager(20985): prepareNavigationBarInfo() DecorView@1ebfb1e[MainActivity]
[ ] D/InputMethodManager(20985): getNavigationBarColor() -855310
[ ] D/InputMethodManager(20985): prepareNavigationBarInfo() DecorView@1ebfb1e[MainActivity]
[ ] D/InputMethodManager(20985): getNavigationBarColor() -855310
[ ] V/InputMethodManager(20985): Starting input: tba=dev.flutter.packages.animations.example ic=null mNaviBarColor -855310 mIsGetNaviBarColorSuccess true , NavVisible : true , NavTrans : false
[ ] D/InputMethodManager(20985): startInputInner - Id : 0
[ ] I/InputMethodManager(20985): startInputInner - mService.startInputOrWindowGainedFocus
[ +58 ms] D/InputMethodManager(20985): prepareNavigationBarInfo() DecorView@1ebfb1e[MainActivity]
[ ] D/InputMethodManager(20985): getNavigationBarColor() -855310
[ ] V/InputMethodManager(20985): Starting input: tba=dev.flutter.packages.animations.example ic=null mNaviBarColor -855310 mIsGetNaviBarColorSuccess true , NavVisible : true , NavTrans : false
[ ] D/InputMethodManager(20985): startInputInner - Id : 0
[+3483 ms] Updating files
[ +137 ms] DevFS: Sync finished
[ +1 ms] Syncing files to device SM G970F... (completed in 4 501ms, longer than expected)
[ +1 ms] Synced 0.9MB.
[ +1 ms] Sending to VM service: _flutter.listViews({})
[ +3 ms] Result: {type: FlutterViewList, views: [{type: FlutterView, id: _flutterView/0x77efdc0420, isolate: {type: @Isolate, fixedId: true, id: isolates/4327579177820019, name: main.dart$main-4327579177820019, number: 4327579177820019}}]}
[ +1 ms] <- accept
[ ] Connected to _flutterView/0x77efdc0420.
[ +1 ms] Flutter run key commands.
[ +1 ms] r Hot reload. ���
[ +1 ms] R Hot restart.
[ ] h Repeat this help message.
[ ] d Detach (terminate "flutter run" but leave application running).
[ ] q Quit (terminate the application on the device).
[ ] An Observatory debugger and profiler on SM G970F is available at: http://127.0.0.1:50583/Xo7I_DIzhB0=/
```
<!--
Run `flutter analyze` and attach any output of that command below.
If there are any analysis errors, try resolving them before filing this issue.
-->
```
Analyzing example...
No issues found! (ran in 2.4s)
```
<!-- Finally, paste the output of running `flutter doctor -v` here. -->
```
[√] Flutter (Channel beta, v1.14.6, on Microsoft Windows [Version 10.0.18362.657], locale pl-PL)
• Flutter version 1.14.6 at C:\Android\flutter
• Framework revision fabeb2a16f (4 weeks ago), 2020-01-28 07:56:51 -0800
• Engine revision c4229bfbba
• Dart version 2.8.0 (build 2.8.0-dev.5.0 fc3af737c7)
[√] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
• Android SDK at C:\Android\sdk
• Android NDK location not configured (optional; useful for native profiling support)
• Platform android-29, build-tools 29.0.2
• ANDROID_HOME = C:\Android\sdk
• Java binary at: C:\Android\Android Studio\jre\bin\java
• Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b03)
• All Android licenses accepted.
[√] Android Studio (version 3.5)
• Android Studio at C:\Android\Android Studio
• Flutter plugin version 43.0.1
• Dart plugin version 191.8593
• Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b03)
[√] VS Code (version 1.41.1)
• VS Code at C:\Users\msienczyk\AppData\Local\Programs\Microsoft VS Code
• Flutter extension version 3.6.0
[√] Connected device (1 available)
• SM G970F • RF8M80G7PGZ • android-arm64 • Android 10 (API 29)
• No issues found!
```
</details>
| c: new feature,framework,a: animation,f: material design,customer: crowd,package,p: animations,P2,team-design,triaged-design | low | Critical |
569,878,317 | go | runtime: "interface {} is nil, not *main.T" on linux-amd64-noopt builder | [2020-02-22T04:31:41-059a5ac/linux-amd64-noopt](https://build.golang.org/log/9df8661fd5326a034504b9834d9e49931fdc7b41)
```
# go run run.go -- fixedbugs/issue13169.go
exit status 1
panic: interface conversion: interface {} is nil, not *main.T
goroutine 34 [running]:
main.main.func2(0xc00008c060, 0xc00008c0c0)
/workdir/go/test/fixedbugs/issue13169.go:40 +0xc0
created by main.main
/workdir/go/test/fixedbugs/issue13169.go:38 +0xd4
exit status 2
FAIL fixedbugs/issue13169.go 1.089s
```
See previously #13169 (CC @aclements, @randall77, @mknyszek).
Perhaps some operation that the runtime assumes to be atomic no longer is in `noopt` mode? (#36110 may be related; CC @cherrymui) | NeedsInvestigation,compiler/runtime | low | Critical |
569,895,975 | vscode | Use VS Code's syntax highlighting in Markdown preview | Issue Type: <b>Bug</b>
When I use `"editor.semanticHighlighting.enabled": true,` TypeScript looks great, but now the Markdown code looks bad in comparison. Please see the screenshot.
VS Code version: Code 1.42.1 (c47d83b293181d9be64f27ff093689e8e7aed054, 2020-02-11T14:50:36.977Z)
OS version: Linux x64 4.18.0-147.5.1.el8_1.x86_64
<details>
<summary>System Info</summary>
|Item|Value|
|---|---|
|CPUs|Intel(R) Core(TM) i7-4770S CPU @ 3.10GHz (8 x 3681)|
|GPU Status|2d_canvas: enabled<br>flash_3d: enabled<br>flash_stage3d: enabled<br>flash_stage3d_baseline: enabled<br>gpu_compositing: enabled<br>metal: disabled_off<br>multiple_raster_threads: enabled_on<br>oop_rasterization: disabled_off<br>protected_video_decode: unavailable_off<br>rasterization: disabled_software<br>skia_renderer: disabled_off<br>surface_control: disabled_off<br>surface_synchronization: enabled_on<br>video_decode: unavailable_off<br>viz_display_compositor: enabled_on<br>viz_hit_test_surface_layer: disabled_off<br>webgl: enabled<br>webgl2: enabled|
|Load (avg)|1, 1, 0|
|Memory (System)|7.50GB (2.44GB free)|
|Process Argv|--no-sandbox --unity-launch /home/david/sites/Link to typing objects cheat-sheet.md|
|Screen Reader|no|
|VM|0%|
</details><details><summary>Extensions (9)</summary>
Extension|Author (truncated)|Version
---|---|---
vscode-deno|axe|2.0.4
spellright|ban|3.0.50
vscode-eslint|dba|2.1.1
prettier-vscode|esb|3.20.0
shell-format|fox|7.0.1
debugger-for-chrome|msj|4.12.6
LiveServer|rit|5.6.1
shellcheck|tim|0.9.0
quokka-vscode|Wal|1.0.279
</details>
<!-- generated by issue reporter --> | feature-request,markdown,keep | medium | Critical |
569,913,425 | go | cmd/compile/internal/ssa: apparent deadlock in TestNexting | [2020-02-23T18:06:08-5bd1454/linux-amd64-longtest](https://build.golang.org/log/a55bc25df89a2b612ae43e28e083b6c8269d5a31)
[2019-12-27T14:52:12-dcd3b2c/linux-amd64-longtest](https://build.golang.org/log/832e4e63da8301b2395df3f239adfa6dbdc25c48)
[2019-11-22T17:33:48-05511a5/linux-amd64-longtest](https://build.golang.org/log/1f3925c311f007b4b5e67ed2fc599461aba9863f)
[2019-11-19T18:43:52-2ac9f1d/linux-amd64-longtest](https://build.golang.org/log/0d9a9a9453f04c2b688e176bbc4f43eb26980423)
[2019-11-19T18:43:52-2ac9f1d/linux-amd64-longtest](https://build.golang.org/log/5fb99e119cc1166e7e8a5889960bd75330a747d7)
[2019-11-18T19:03:27-48989d5/linux-amd64-longtest](https://build.golang.org/log/190e897890a1a0c54f1a93871de9d85b95575bd1)
[2019-11-07T17:45:27-763d3ac/linux-amd64-longtest](https://build.golang.org/log/afd4654b020b1440879a72d0a1fa8b579b8c9af1)
[2019-11-04T05:27:25-fb29e22/linux-amd64-longtest](https://build.golang.org/log/d0a3ea14bd4aa751e917789020b1734ad8404315)
CC @dr2chase @randall77 @cagedmantis; see also #37050.
As far as I can tell, this is a bug in the test harness itself (or perhaps in the third-party debugger) rather than a bug in the `ssa` package proper.
<details>
```
panic: test timed out after 15m0s
goroutine 194 [running]:
testing.(*M).startAlarm.func1()
/workdir/go/src/testing/testing.go:1479 +0xdf
created by time.goFunc
/workdir/go/src/time/sleep.go:168 +0x44
goroutine 1 [chan receive, 12 minutes]:
testing.(*T).Run(0xc000282120, 0xb14f08, 0xb, 0xb2be88, 0x482601)
/workdir/go/src/testing/testing.go:1044 +0x37e
testing.runTests.func1(0xc000168000)
/workdir/go/src/testing/testing.go:1300 +0x78
testing.tRunner(0xc000168000, 0xc00005ddf8)
/workdir/go/src/testing/testing.go:992 +0xdc
testing.runTests(0xc00000c640, 0x1063a60, 0x5c, 0x5c, 0xbf8ccf536472d01d, 0xd18c3eb719, 0x10d5000, 0x78)
/workdir/go/src/testing/testing.go:1298 +0x2d8
testing.(*M).Run(0xc00001e100, 0x0)
/workdir/go/src/testing/testing.go:1210 +0x1a7
main.main()
_testmain.go:280 +0x135
goroutine 186 [select, 12 minutes]:
cmd/compile/internal/ssa_test.(*ioState).readSimpleExpecting(0xc0001f47e0, 0xb1431b, 0xa, 0x2, 0x2, 0x0, 0x0)
/workdir/go/src/cmd/compile/internal/ssa/debug_test.go:917 +0x150
cmd/compile/internal/ssa_test.(*ioState).writeReadExpect(0xc0001f47e0, 0xc000094050, 0x2, 0xb1431b, 0xa, 0xc000094050, 0x2, 0x0, 0x0)
/workdir/go/src/cmd/compile/internal/ssa/debug_test.go:863 +0xe6
cmd/compile/internal/ssa_test.(*delveState).stepnext(0xc0001e0420, 0xb0ae30, 0x1, 0xb1431b)
/workdir/go/src/cmd/compile/internal/ssa/debug_test.go:520 +0xbc
cmd/compile/internal/ssa_test.(*delveState).start(0xc0001e0420)
/workdir/go/src/cmd/compile/internal/ssa/debug_test.go:563 +0x23c
cmd/compile/internal/ssa_test.runDbgr(0xca1f00, 0xc0001e0420, 0x3e8, 0x34)
/workdir/go/src/cmd/compile/internal/ssa/debug_test.go:279 +0x35
cmd/compile/internal/ssa_test.testNexting(0xc000168480, 0xb0f233, 0x6, 0xc0001fd6a5, 0x7, 0x0, 0x0, 0x3e8, 0x110f490, 0x0, ...)
/workdir/go/src/cmd/compile/internal/ssa/debug_test.go:246 +0x5dd
cmd/compile/internal/ssa_test.optSubTest.func1(0xc000168480)
/workdir/go/src/cmd/compile/internal/ssa/debug_test.go:202 +0x95
testing.tRunner(0xc000168480, 0xc0001e0120)
/workdir/go/src/testing/testing.go:992 +0xdc
created by testing.(*T).Run
/workdir/go/src/testing/testing.go:1043 +0x357
goroutine 170 [chan receive, 12 minutes]:
testing.(*T).Run(0xc000168480, 0xc0001fd6b0, 0xe, 0xc0001e0120, 0x1)
/workdir/go/src/testing/testing.go:1044 +0x37e
cmd/compile/internal/ssa_test.optSubTest(0xc000282120, 0xc0001fd6a5, 0x7, 0xb0f233, 0x6, 0x0, 0x0, 0x3e8, 0x110f490, 0x0, ...)
/workdir/go/src/cmd/compile/internal/ssa/debug_test.go:200 +0x146
cmd/compile/internal/ssa_test.TestNexting(0xc000282120)
/workdir/go/src/cmd/compile/internal/ssa/debug_test.go:164 +0x611
testing.tRunner(0xc000282120, 0xb2be88)
/workdir/go/src/testing/testing.go:992 +0xdc
created by testing.(*T).Run
/workdir/go/src/testing/testing.go:1043 +0x357
goroutine 189 [IO wait, 12 minutes]:
internal/poll.runtime_pollWait(0x7f73050bcde8, 0x72, 0xffffffffffffffff)
/workdir/go/src/runtime/netpoll.go:203 +0x55
internal/poll.(*pollDesc).wait(0xc0001e0558, 0x72, 0x1001, 0x1000, 0xffffffffffffffff)
/workdir/go/src/internal/poll/fd_poll_runtime.go:87 +0x45
internal/poll.(*pollDesc).waitRead(...)
/workdir/go/src/internal/poll/fd_poll_runtime.go:92
internal/poll.(*FD).Read(0xc0001e0540, 0xc00025e000, 0x1000, 0x1000, 0x0, 0x0, 0x0)
/workdir/go/src/internal/poll/fd_unix.go:169 +0x19b
os.(*File).read(...)
/workdir/go/src/os/file_unix.go:263
os.(*File).Read(0xc00068e540, 0xc00025e000, 0x1000, 0x1000, 0xc000220000, 0x4b, 0x0)
/workdir/go/src/os/file.go:116 +0x71
cmd/compile/internal/ssa_test.newIoState.func1(0xc0001f47e0)
/workdir/go/src/cmd/compile/internal/ssa/debug_test.go:796 +0x92
created by cmd/compile/internal/ssa_test.newIoState
/workdir/go/src/cmd/compile/internal/ssa/debug_test.go:793 +0x22c
goroutine 190 [IO wait, 12 minutes]:
internal/poll.runtime_pollWait(0x7f73050bcc28, 0x72, 0xffffffffffffffff)
/workdir/go/src/runtime/netpoll.go:203 +0x55
internal/poll.(*pollDesc).wait(0xc0001e0618, 0x72, 0x1001, 0x1000, 0xffffffffffffffff)
/workdir/go/src/internal/poll/fd_poll_runtime.go:87 +0x45
internal/poll.(*pollDesc).waitRead(...)
/workdir/go/src/internal/poll/fd_poll_runtime.go:92
internal/poll.(*FD).Read(0xc0001e0600, 0xc00025f000, 0x1000, 0x1000, 0x0, 0x0, 0x0)
/workdir/go/src/internal/poll/fd_unix.go:169 +0x19b
os.(*File).read(...)
/workdir/go/src/os/file_unix.go:263
os.(*File).Read(0xc00068e550, 0xc00025f000, 0x1000, 0x1000, 0x2020202020200a3e, 0x3376202020202020, 0x745066664f203d20)
/workdir/go/src/os/file.go:116 +0x71
cmd/compile/internal/ssa_test.newIoState.func2(0xc0001f47e0)
/workdir/go/src/cmd/compile/internal/ssa/debug_test.go:815 +0x93
created by cmd/compile/internal/ssa_test.newIoState
/workdir/go/src/cmd/compile/internal/ssa/debug_test.go:812 +0x24e
FAIL cmd/compile/internal/ssa 900.007s
```
</details> | Testing,NeedsInvestigation,compiler/runtime | low | Critical |
569,951,317 | flutter | Misspelled command triggers 1st run message | I have seen this happen sometimes when a wrong command is run, not limited to `flutter build`.
<details>
<summary>Logs</summary>
```
PS C:\Users\Cristian\Desktop\airhopping> flutter build apk --tree-shake-icons --split-per-ab
Could not find an option named "split-per-ab".
Run 'flutter -h' (or 'flutter <command> -h') for available flutter commands and options.
╔════════════════════════════════════════════════════════════════════════════╗
║ ║
║ The Flutter tool uses Google Analytics to anonymously report feature usage ║
║ statistics and basic crash reports. This data is used to help improve ║
║ Flutter tools over time. ║
║ ║
║ Flutter tool analytics are not sent on the very first run. To disable ║
║ reporting, type 'flutter config --no-analytics'. To display the current ║
║ setting, type 'flutter config'. If you opt out of analytics, an opt-out ║
║ event will be sent, and then no further information will be sent by the ║
║ Flutter tool. ║
║ ║
║ By downloading the Flutter SDK, you agree to the Google Terms of Service. ║
║ Note: The Google Privacy Policy describes how data is handled in this ║
║ service. ║
║ ║
║ Moreover, Flutter includes the Dart SDK, which may send usage metrics and ║
║ crash reports to Google. ║
║ ║
║ Read about data we send with crash reports: ║
║ https://flutter.dev/docs/reference/crash-reporting ║
║ ║
║ See Google's privacy policy: ║
║ https://policies.google.com/privacy ║
╚════════════════════════════════════════════════════════════════════════════╝
```
```
[✓] Flutter (Channel master, v1.15.4-pre.140, on Microsoft Windows [Versión 10.0.18363.657], locale es-ES)
• Flutter version 1.15.4-pre.140 at C:\src\flutter
• Framework revision 1d4667bb38 (12 hours ago), 2020-02-24 08:56:02 +0530
• Engine revision f2f8c342be
• Dart version 2.8.0 (build 2.8.0-dev.9.0 0f141be8bd)
[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.3)
• Android SDK at C:\Users\Cristian\AppData\Local\Android\sdk
• Android NDK location not configured (optional; useful for native profiling support)
• Platform android-R, build-tools 29.0.3
• Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
• Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b03)
• All Android licenses accepted.
[✓] Chrome - develop for the web
• Chrome at C:\Program Files (x86)\Google\Chrome\Application\chrome.exe
[✓] Android Studio (version 3.5)
• Android Studio at C:\Program Files\Android\Android Studio
• Flutter plugin version 44.0.1-dev.4
• Dart plugin version 191.8593
• Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b03)
[✓] Connected device (3 available)
• Pixel 3 XL • 89PY09NNV • android-arm64 • Android 10 (API 29)
• Chrome • chrome • web-javascript • Google Chrome 80.0.3987.116
• Web Server • web-server • web-javascript • Flutter Tools
• No issues found!
```
</details>
| tool,a: quality,P2,team-tool,triaged-tool | low | Critical |
569,958,208 | go | x/exp/cmd/gorelease: add glossary-defined code next to each (in)compatible change | <!-- Please answer these questions before submitting your issue. Thanks! -->
### What version of Go are you using (`go version`)?
<pre>
$ go version
go version devel +151ccd4bdb Mon Feb 24 02:36:05 2020 +0000 linux/amd64
$ git rev-parse HEAD
7c80518d1cc79ffde9e571fe4fd281f321d36200
</pre>
### Does this issue reproduce with the latest release?
Yes
### What operating system and processor architecture are you using (`go env`)?
<details><summary><code>go env</code> Output</summary><br><pre>
$ go env
GO111MODULE="on"
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/myitcv/.cache/go-build"
GOENV="/home/myitcv/.config/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/home/myitcv/gostuff"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/home/myitcv/gos"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/home/myitcv/gos/pkg/tool/linux_amd64"
GCCGO="gccgo"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="/home/myitcv/gostuff/src/github.com/myitcv/govim/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build347856664=/tmp/go-build -gno-record-gcc-switches"
</pre></details>
### What did you do?
Ran `gorelease` against `govim`:
```
$ gorelease -base=v0.0.29
github.com/govim/govim
----------------------
Compatible changes:
- EventUser: added
github.com/govim/govim/cmd/govim/config
---------------------------------------
Incompatible changes:
- Config.ExperimentalTempModfile: removed
Compatible changes:
- CommandHighlightReferences: added
- Config.HighlightReferences: added
- Config.TempModfile: added
- EnvVarGoplsGOMAXPROCSMinusN: added
- FunctionWorkspaceSymbol: added
- HighlightReferences: added
github.com/govim/govim/testsetup
--------------------------------
Compatible changes:
- EnvStrictVimBufferLifecycle: added
github.com/govim/govim/testdriver
---------------------------------
Compatible changes:
- Config.Vim: added
- VimConfig: added
Suggested version: v0.1.0
```
### What did you expect to see?
Some sort of code/reference against each change that allows me to refer to a glossary for more detail. Very much in the same vein as [`staticcheck`'s codes for each analysis](https://staticcheck.io/docs/checks).
### What did you see instead?
A plain presentation of the changes that were compatible/incompatible.
cc @jayconrod | NeedsInvestigation,FeatureRequest | low | Critical |
569,975,536 | angular | Template compiles with strict but not with full | # 🐞 bug report
### Affected Package
The issue is caused by package @angular/compiler (I guess)
### Is this a regression?
Yes, kiiiiinda
With enableIvy false (v9 and I'm almost certain v8 as well), changing the final non-null assert (`!`) in the template into a null propagation (`?`) makes the error go away.
### Description
The code in the reproduction below compiles with `"strictTemplate": true` in tsconfig, but not with `"fullTemplateTypeCheck": true` only.
As far as I understand, anything that compiles with strict should compile with full? As an aside, I think it would be good if that was made clear one way or another in [this section of the docs](https://angular.io/guide/template-typecheck#strict-mode) (happy to raise a separate issue).
Furthermore, the error in full mode doesn't make any sense, as far as I understand.
As noted above, there is a similar issue with Ivy disabled, but for reasons I don't understand it goes away when using null propagation rather than non-null assertion.
## 🔬 Minimal Reproduction
https://github.com/jgbpercy/AngularCompilesOnlyStrict
(currently the repo should be in a non-compiling state - add `"strictTemplate": true` to tsconfig angularCompilerOptions and it should compile)
## 🔥 Exception or Error
<pre><code>
ERROR in src/app/app.component.html:2:12 - error TS2339: Property 'doDar' does not exist on type 'never'.
2 <div>{{ (thinger!.innerObs | async)!.doDar }}</div>
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/app/app.component.ts:14:16
14 templateUrl: './app.component.html',
~~~~~~~~~~~~~~~~~~~~~~
Error occurs in the template of component AppComponent.
</code></pre>
## 🌍 Your Environment
**Angular Version:**
<pre><code>
Angular CLI: 9.0.3
Node: 10.15.0
OS: win32 x64
Angular: 9.0.2
... animations, common, compiler, compiler-cli, core, forms
... language-service, platform-browser, platform-browser-dynamic
... router
Ivy Workspace: Yes
Package Version
-----------------------------------------------------------
@angular-devkit/architect 0.900.3
@angular-devkit/build-angular 0.900.3
@angular-devkit/build-optimizer 0.900.3
@angular-devkit/build-webpack 0.900.3
@angular-devkit/core 9.0.3
@angular-devkit/schematics 9.0.3
@angular/cli 9.0.3
@ngtools/webpack 9.0.3
@schematics/angular 9.0.3
@schematics/update 0.900.3
rxjs 6.5.4
typescript 3.7.5
webpack 4.41.2
</code></pre>
**Anything else relevant?**
The language service thinks the code is fine and picks up the type ok!
So I'm guessing in full the first `| async` is polluting the type it outputs with a union to `null`, and then the second `| async` is chewing up horribly on that somehow. Whereas in strict it has enough information to know that null isn't part of the relevant type at the right time. | type: bug/fix,area: common,workaround1: obvious,freq1: low,state: confirmed,cross-cutting: types,P4,common: async pipe | low | Critical |
569,979,366 | node | http module emits 'end' event after 'error' event being called | Hello
Update: Found another similar topic:
https://github.com/nodejs/node/issues/2156
Couldn't find solution, but, found similar issue related to TCP sockets
https://github.com/nodejs/node/issues/6083
* OS: Ubuntu 18.04.3 LTS
* node v12.16.1
What I need is to receive Github webhook request and handle it within 'End' event as 'Data' Event might not contain all data (as I understood the process). And, if there is a DoS attempt detected from a 3rd party just want to drop that connection to prevent node process to grow.
Code to reproduce:
```
const http = require('http');
console.log("Webhook Server: STARTING")
http.createServer((request, response) => {
const { headers, method, url } = request;
let body = [];
request.on('error', (err) => {
console.log("Webhook Server: Request Handler Error event: " + err);
}).on('data', (chunk) => {
console.log("Webhook Server: Data event");
body.push(chunk);
console.log("Webhook Server: Emitting Error");
request.emit('error', "Error message");
}).on('end', () => {
console.log("Webhook Server: End event");
response.on('error', (err) => {
console.log("Webhook Server: Response Error")
console.error(err);
});
response.writeHead(200, {'Content-Type': 'application/json'})
const responseBody = { headers, method, url, body };
response.end(JSON.stringify(responseBody))
});
}).listen(3001, '127.0.0.1', function() {
console.log("Webhook Server: LISTENING")
});
```
Getting:
Webhook Server: STARTING
Webhook Server: LISTENING
Webhook Server: Data event
Webhook Server: Emitting Error
Webhook Server: Request Handler Error event: Error message
Webhook Server: End event | http | low | Critical |
570,001,902 | vscode | [folding] context menu on expand/collapse arrow | It would be nice if you can right click on expand/collapse code block arrow to get small menu to collapse/expand all blocks:
| feature-request,editor-folding | low | Minor |
570,005,562 | flutter | Color.fromRGBO constructs color with wrong alpha value | Constructing colors using `fromRGBO` should return the same values as the CSS `rgba()` notation.
`rgba(0, 0, 255, 0.5)` is the same as `#0000ff80`
but `fromRGBO` sometimes creates a color with an off by one alpha value
```dart
expect(Color.fromRGBO(0, 0, 255, 0.5), Color(0x800000ff));
```
```
Expected: Color:<Color(0x800000ff)>
Actual: Color:<Color(0x7f0000ff)>
```
if we use `withOpacity` to create the same color it returns the correct color:
```dart
expect(Color.fromRGBO(0, 0, 255, 1).withOpacity(0.5), Color(0x800000ff));
```
flutter/engine#13777 was an attempted fix but was reverted because it broke goldens and consensus was that it should be done in a non-breaking way. | engine,a: fidelity,a: quality,has reproducible steps,P3,team-engine,triaged-engine,found in release: 3.16,found in release: 3.18 | low | Major |
570,014,454 | go | cmd/compile: partial cse of phi inputs? | This is an optimization idea, one that is still very rough. I'm interested in feedback and ideas.
Consider the beginning of os/basename (on unix):
```go
func basename(name string) string {
i := len(name) - 1
// Remove trailing slashes
for ; i > 0 && name[i] == '/'; i-- {
name = name[:i]
}
```
After decompose built-in, part of the loop here has SSA form
```
b2: ← b1 b4
v11 (23) = Phi <int> v10 v41 (i[int], name+8[int])
v74 (34) = Phi <int> v54 v11 (name+8[int])
v13 (+23) = Greater64 <bool> v11 v12
v82 (34) = StringMake <string> v50 v74
If v13 → b7 b5 (23)
```
b1 is the entry block. v11 is `i`. v74 is `len(name)`.
Consider v11's args in more detail.
v10 is `Add64 <int> v26 v54 (i[int])`. v41 is `Add64 <int> v26 v11 (i[int])`. (v26 is const -1.) They are the same except for the second arg.
So we could do a partial CSE and rewrite v11 as: `Add64 <int> v26 vNEW (i[int])`, where vNEW is `Phi <int> v54 v11`. Which is to say, vNEW is the same as v74!
So we end up with fewer phi values, and fewer Add64 values. We might even be able to eliminate a bounds check (v17) that was previously out of reach; I'm not sure.
Note that this transformation is I believe similar in effect to optimizing the code above to not modify name in the loop:
```go
func basename(name string) string {
i := len(name) - 1
// Remove trailing slashes
for ; i > 0 && name[i] == '/'; i-- {
}
name = name[:i]
```
In this optimized code we have only a single phi value (for `i`), and we calculate `len(name)` from it when we need it. The CSE'ing approach discussed above generates code that has only a single phi value (for `len(name)`) and we calculate `i` from it when we need it.
In general terms, the idea is to look for phi values whose arguments are identical except for a single argument, and then to CSE those arguments, replacing the varying argument with a new phi value.
cc @randall77 @dr2chase @cherrymui | Performance,NeedsInvestigation,compiler/runtime | low | Minor |
570,018,604 | flutter | Safe area left and right of notch not clickable in iOS | When using fullscreen widgets on iOS devices with a notch, the parts left and right of the safe area are not clickable.
## Steps to Reproduce
```
class FullPage extends StatelessWidget {
@override
Widget build(BuildContext context) {
SystemChrome.setEnabledSystemUIOverlays ([]);
return Scaffold(
appBar: null,
body: Stack(
fit: StackFit.expand,
overflow: Overflow.visible,
children: <Widget>[
Container(
height: double.infinity,
width: double.infinity,
color: Colors.green,
),
Positioned(
top: 21.0,
right: 24.0,
child: InkWell(
onTap: () {
Navigator.pop(context);
},
child: Container(
width: 20,
height: 20,
color: Colors.red
),
)
),
],
),
);
}
}
```
**Expected results:** on iPhone 11: When tapping on the red container, the widget should close
**Actual results:** on iPhone 11: When tapping on the red container, nothing happens
```
flutter analyze
Analyzing app...
No issues found! (ran in 16.3s)
```
```
[✓] Flutter (Channel stable, v1.12.13+hotfix.8, on Mac OS X 10.15.3 19D76, locale en-AT)
• Flutter version 1.12.13+hotfix.8 at /Users/x/Applications/flutter
• Framework revision 0b8abb4724 (13 days ago), 2020-02-11 11:44:36 -0800
• Engine revision e1e6ced81d
• Dart version 2.7.0
[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.0)
• Android SDK at /Users/x/Library/Android/sdk
• Android NDK location not configured (optional; useful for native profiling support)
• Platform android-29, build-tools 29.0.0
• ANDROID_HOME = /Users/x/Library/Android/sdk
• Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
• Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405)
• All Android licenses accepted.
[✓] Xcode - develop for iOS and macOS (Xcode 11.3.1)
• Xcode at /Applications/Xcode.app/Contents/Developer
• Xcode 11.3.1, Build version 11C504
• CocoaPods version 1.8.4
[✓] Android Studio (version 3.5)
• Android Studio at /Applications/Android Studio.app/Contents
• Flutter plugin version 43.0.1
• Dart plugin version 191.8593
• Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405)
[✓] Connected device (2 available)
• iPhone 6 • x • ios • com.apple.CoreSimulator.SimRuntime.iOS-12-2 (simulator)
• iPhone 11 • x • ios • com.apple.CoreSimulator.SimRuntime.iOS-13-3 (simulator)
• No issues found!
```
| platform-ios,framework,engine,a: layout,has reproducible steps,P2,found in release: 3.3,found in release: 3.7,team-ios,triaged-ios | low | Critical |
570,023,777 | godot | AnimationPlayer: Bezier Curves don't stay constant, when they should | **Godot version:**
3.2.stable
**OS/device including version:**
Windows 10 1903
**Issue description:**
When adding a bezier curve animation for a property it doesn't stay constant when it should (Follow the cursor):
Which leads to jerky effects like this:
I suspect the issue coming from rounding errors beeing extremyfied with rounding to an integer.
**Steps to reproduce:**
1. Add a PanelContainer
2. give it some content (a label or sth.)
3. Add an AnimationPlayer and create a new animation
4. Add a default keyframe for the margin left (Use bezier curves!)
5. Add another keyframe for the same margin
6. Add a third to a different (i.e. 0) value
**Minimal reproduction project:**
[anim_curve.zip](https://github.com/godotengine/godot/files/4245993/anim_curve.zip) | bug,topic:core,confirmed | low | Critical |
570,028,273 | TypeScript | `Omit` helper loses type information when used with extended Records. | <!-- 🚨 STOP 🚨 𝗦𝗧𝗢𝗣 🚨 𝑺𝑻𝑶𝑷 🚨
Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Even if you think you've found a *bug*, please read the FAQ first, especially the Common "Bugs" That Aren't Bugs section!
Please help us by doing the following steps before logging an issue:
* Search: https://github.com/Microsoft/TypeScript/search?type=Issues
* Read the FAQ: https://github.com/Microsoft/TypeScript/wiki/FAQ
Please fill in the *entire* template below.
-->
**TypeScript Version:** 3.8 & Nightly
<!-- Search terms you tried before logging this (so others can find this issue more easily) -->
**Search Terms:**
- Omit
- Record
- Any
- Loses type information
**Expected behavior:**
I expect the following types to be as described in the inline comments.
```ts
type AnyRecord = Record<string, any>;
interface ExtendsAny extends AnyRecord {
myKey1: string;
myKey2: string;
}
// ExtendsAny['myKey1'] === string
// ExtendsAny['otherKey'] === any
type OmitsKey = Omit<ExtendsAny, "myKey2">;
// OmitsKey['myKey'] === string
// OmitsKey['otherKey'] === any
```
Please note that this works without the omit, or without the record, but not when both are used together.
**Actual behavior:**
What actually happens is that after using omit, all keys become "any" and any information for code completion, etc that the specifically defined keys even exist, are removed, even thought they were working in the original extension.
```ts
type AnyRecord = Record<string, any>;
interface ExtendsAny extends AnyRecord {
myKey1: string;
myKey2: string;
}
// ExtendsAny['myKey1'] === string
// ExtendsAny['otherKey'] === any
type OmitsKey = Omit<ExtendsAny, "myKey2">;
// 🚨Problem here 🚨
// OmitsKey['myKey1'] === any
// OmitsKey['otherKey'] === any
const instance: OmitsKey = {
myKey1: "test",
}
// 🚨 When typing this no autocomplete is provided for myKey1 🚨
instance.myKey1.
```
<!-- Did you find other bugs that looked similar? -->
**Related Issues:**
- https://github.com/microsoft/TypeScript/issues/27883
**Potential Workaround**
In the meantime, I am redefining the base interface (very large) because it comes from a library without the record type mixed in. I do my omit, then add it back in afterwards.
**Code**
```ts
/**
* @copyright 2020 Adam (charrondev) Charron
* @license MIT
*/
export interface IBase<T = number> {
baseProp: T;
baseProp2: T;
baseFunction: () => T;
}
const base: IBase<number> = {
baseProp: 0,
baseProp2: 0,
baseFunction: () => 0,
};
// number
base.baseProp;
///
/// Without the omit
///
type AnyRecord = Record<string, any>;
interface IExtend<T> extends IBase<T>, AnyRecord {
extendProp: T;
}
const extended: IExtend<number> = {
baseProp: 0,
baseProp2: 0,
baseFunction: () => 0,
extendProp: 0,
};
// number
extended.baseProp2;
///
/// With an Omit
///
interface IOmittedInterface extends Omit<IExtend<number>, "baseProp"> {}
const omitted: IOmittedInterface = {
baseProp2: 0,
baseFunction: () => 0,
};
// any
omitted.baseProp2;
```
<details><summary><b>Output</b></summary>
```ts
/**
* @copyright 2020 Adam (charrondev) Charron
* @license MIT
*/
const base = {
baseProp: 0,
baseProp2: 0,
baseFunction: () => 0,
};
// number
base.baseProp;
const extended = {
baseProp: 0,
baseProp2: 0,
baseFunction: () => 0,
extendProp: 0,
};
// number
extended.baseProp2;
const omitted = {
baseProp2: 0,
baseFunction: () => 0,
};
// any
omitted.baseProp2;
```
</details>
<details><summary><b>Compiler Options</b></summary>
```json
{
"compilerOptions": {
"noImplicitAny": true,
"strictNullChecks": true,
"strictFunctionTypes": true,
"strictPropertyInitialization": true,
"strictBindCallApply": true,
"noImplicitThis": true,
"noImplicitReturns": true,
"useDefineForClassFields": false,
"alwaysStrict": true,
"allowUnreachableCode": false,
"allowUnusedLabels": false,
"downlevelIteration": false,
"noEmitHelpers": false,
"noLib": false,
"noStrictGenericChecks": false,
"noUnusedLocals": false,
"noUnusedParameters": false,
"esModuleInterop": true,
"preserveConstEnums": false,
"removeComments": false,
"skipLibCheck": false,
"checkJs": false,
"allowJs": false,
"declaration": true,
"experimentalDecorators": false,
"emitDecoratorMetadata": false,
"target": "ES2017",
"module": "ESNext"
}
}
```
</details>
**Playground Link:** [Provided](http://www.typescriptlang.org/play/?ts=Nightly#)
| Needs Investigation,Fix Available,Rescheduled | medium | Critical |
570,029,416 | flutter | [animations] Code sample improvements | Created off of https://github.com/flutter/flutter/issues/51300#issuecomment-590468967
- Add code samples to animations that make sense. For example, using the `PageTransitionsBuilder`s and describing how to handle hit testing for `FadeScaleTransition`.
- Link Material motion system article in the API documentation. | a: animation,a: accessibility,d: examples,package,p: animations,team-ecosystem,P3,triaged-ecosystem | low | Minor |
570,133,438 | react | React retains component references to old renders causing browser memory to increase | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
React version: 16.12.0
Link to deployed demo app - https://tsjohns9.github.io/react-memory-leak/
Link to demo repo - https://github.com/tsjohns9/react-memory-leak
## The current behavior
React appears to retain references to old renders of components which prevents the browser from running the garbage collector on unused memory.
## The expected behavior
React should release the memory of components from previous renders
## Description
I have a web app that imports an OAS 3/Swagger 2.0 json spec file, and renders the file using the swagger-ui component, https://github.com/swagger-api/swagger-ui.
These json files can be very large. If I upload a file that is 500kb and pass it into the swagger-ui component the heap snapshot in chrome will show about 32.6 MB being used to render the app.
At some point during the lifecycle of this component the spec file may be updated by a user. When this happens the swagger-ui component will re-render. Between re-renders I can see from my heap snapshot that about 15 more mb are added to the heap.
Even if this component is completely unmounted, the memory is still retained and cannot be garbage collected.
I would expect that after a re-render the heap size would be about the same, and the old references would be released for garbage collection.
I have come here with this issue and not swagger-ui because based on the heap snapshots the detached DOM elements are being retained by React directly.
The spec file that I have used is about 500kb. Unfortunately it is a proprietary file and I cannot share it here. Instead, I have provided a spec file from swagger-ui. This file is much smaller, but it will serve the purpose of showing how react is retaining references to old component renders. In my situation since the file is so large this becomes much more apparent to the user that there is a problem than with a much smaller json file.
## Steps To Reproduce
1. View the app [here](https://tsjohns9.github.io/react-memory-leak/)
2. Open the console, and take a heap snapshot
3. Press the Update Spec button in the top left of the app, or the Unmount button
4. Take another heap snapshot.
5. You will see that the heap size has increased
6. Compare the two heap sizes and check to see how many new detached objects there are. Here is a screenshot as an example
Link to code example: https://tsjohns9.github.io/react-memory-leak | Type: Needs Investigation | medium | Critical |
570,133,908 | svelte | Perf: Frequently updating reactive variables cause garbage collection pressure & hitching | We're seeing some hitches in a game we're developing that uses embedded webkit(Coherent GT) for the UI and I've narrowed this down to what appears to be GC pressure created when using reactive variables.
We're updating reactive variables within our components nearly every frame for things like health & positions. In a normal web app, the GC times we're seeing(can get up to 20ms) wouldn't be an issue, but our UI has a small budget for each frame (~3ms).
I'm able to repro this in latest chrome with the following component in svelte 3.18.2:
```
<div data-amount="{amount}" />
<script>
let amount = 0;
setInterval(() => {
amount = (amount + 1) % 100;
}, 4);
</script>
```
Here's what the memory looks like when profiling in chrome:
A different approach that doesn't use reactive variables does not have this issue:
```
<div data-amount="{0}" bind:this={amountEl}/>
<script>
let amountEl;
setInterval(() => {
amountEl.setAttribute("data-amount", (Number(amountEl.getAttribute("data-amount")) + 1) % 100);
}, 4);
</script>
```
Here's what the memory profile in chrome looks like when not using reactive variables:
I've looked at the generated output and tried to narrow down what might be causing a lot of the extra allocation, but haven't been able to nail anything down yet. Any help would be appreciated! | perf,temp-stale | low | Minor |
570,138,341 | go | cmd/compile: add a way to declare variables in rewrite rules | Consider this rewrite rule: `(Div32F (Const32F [c]) (Const32F [d])) && !math.IsNaN(float64(auxTo32F(c) / auxTo32F(d))) -> (Const32F [auxFrom32F(auxTo32F(c) / auxTo32F(d))])`
It'd be a lot easier to read and write (and compile) if we could declare a variable somewhere to hold the value `auxTo32F(c) / auxTo32F(d)`. I run into this a fair amount.
Maybe we could let the condition section contain short variable declarations?
`(Div32F (Const32F [c]) (Const32F [d])) && quo := auxTo32F(c) / auxTo32F(d) && !math.IsNaN(float64(quo)) -> (Const32F [auxFrom32F(quo)])`
It looks a bit weird. Other ideas?
Kinda related: https://github.com/golang/go/issues/30818
cc @mvdan @randall77
| NeedsInvestigation,compiler/runtime | low | Major |
570,141,706 | rust | Trait bounds on associated types not resolving correctly | In [the attached gist](https://gist.github.com/myrrlyn/47b57e6a16371a34a1ca113d9c204bf0), I provide a demonstration of a trait resolution error, and an equivalent fix for it.
The summary is this:
I have a trait `A` that depends on other traits, including `core::ops` operator implementations. It depends on multiple versions of the same operator trait. I have another trait `B` that uses this as an associated type bound `AssocA: A`.
Values typed as `<B as AssocA>::A` fail to correctly select the operator trait that matches the expression, and instead insist that only the *last* operator trait variant in the requirements list, by source order, exists, and the expression must be reshaped to fit it.
Changing the type of the value from `<B as AssocA>::A` to `T where T: A` causes the expression to resolve its traits correctly.
Code summary:
```rust
trait A:
BitAnd<Self, Output = Self>
+ for<'a> BitAnd<&'a Self, Output = Self>
{}
trait B {
type AssocA: A;
}
fn fails<T: B>(this: T::AssocA) -> T::AssocA {
this & this // wants `this & &this`
}
call_fails::<Something>(<Something as B>::AssocA::default());
fn succeeds<T: A>(this: T) -> T {
this & this
}
call_succeeds::<<Something as B>::AssocA>(a_value);
```
### Meta
<!--
If you're using the stable version of the compiler, you should also check if the
bug also exists in the beta or nightly versions.
-->
`rustc --version --verbose`:
```
rustc 1.41.0 (5e1a79984 2020-01-27)
binary: rustc
commit-hash: 5e1a799842ba6ed4a57e91f7ab9435947482f7d8
commit-date: 2020-01-27
host: x86_64-pc-windows-msvc
release: 1.41.0
LLVM version: 9.0
rustc 1.43.0-nightly (58b834344 2020-02-05)
binary: rustc
commit-hash: 58b834344fc7b9185e7a50db1ff24e5eb07dae5e
commit-date: 2020-02-05
host: x86_64-pc-windows-msvc
release: 1.43.0-nightly
LLVM version: 9.0
```
### Reproduction
The two `.rs` source files in the gist are tests; put them in `tests/` of a new library. Add `funty = "1"` to the `Cargo.toml` manifest. Attempt to compile. | A-trait-system,A-associated-items,T-compiler,C-bug,T-types | low | Critical |
570,142,138 | TypeScript | Find all references for module.exports expandoes differ depending on expandoes members are calculated or not | <!-- 🚨 STOP 🚨 𝗦𝗧𝗢𝗣 🚨 𝑺𝑻𝑶𝑷 🚨
Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Even if you think you've found a *bug*, please read the FAQ first, especially the Common "Bugs" That Aren't Bugs section!
Please help us by doing the following steps before logging an issue:
* Search: https://github.com/Microsoft/TypeScript/search?type=Issues
* Read the FAQ: https://github.com/Microsoft/TypeScript/wiki/FAQ
Please fill in the *entire* template below.
-->
<!--
Please try to reproduce the issue with the latest published version. It may have already been fixed.
For npm: `typescript@next`
This is also the 'Nightly' version in the playground: http://www.typescriptlang.org/play/?ts=Nightly
-->
**TypeScript Version:** 3.7.x-dev.201xxxxx
Found with #36808
<!-- Search terms you tried before logging this (so others can find this issue more easily) -->
**Search Terms:**
**Code**
Test case : tests/cases/fourslash/findAllRefs_importType_js.ts
```ts
/// <reference path='fourslash.ts' />
// @allowJs: true
// @checkJs: true
// @Filename: /a.js
////[|[|{| "contextRangeIndex": 0 |}module|].exports = [|class [|{| "isWriteAccess": true, "isDefinition": true, "contextRangeIndex": 2 |}C|] {}|];|]
////[|module.exports.[|{| "isWriteAccess": true, "isDefinition": true, "contextRangeIndex": 4 |}D|] = [|class [|{| "isWriteAccess": true, "isDefinition": true, "contextRangeIndex": 6 |}D|] {}|];|]
// @Filename: /b.js
/////** [|@type {import("[|{| "contextRangeIndex": 8 |}./a|]")}|] */
////const x = 0;
/////** [|@type {import("[|{| "contextRangeIndex": 10 |}./a|]").[|D|]}|] */
////const y = 0;
verify.noErrors();
// TODO: GH#24025
const [rModuleDef, rModule, r0Def, r0, r1Def, r1, r2Def, r2, r3Def, r3, r4Def, r4, r5] = test.ranges();
verify.referenceGroups([r3, r4], [
{ definition: 'module "/a"', ranges: [r4, rModule] },
{ definition: "(local class) C", ranges: [r0] },
{ definition: "(alias) (local class) export=\nimport export=", ranges: [r3] },
]); // This is correct result of findallrefs
verify.referenceGroups(rModule, [{ definition: 'module "/a"', ranges: [r3, r4, rModule] }]);
verify.referenceGroups(r0, [
{ definition: "(local class) C", ranges: [r0] },
// TODO: This definition is really ugly
{ definition: "(alias) (local class) export=\nimport export=", ranges: [r3] },
]);
verify.referenceGroups([r1, r5], [
{ definition: "class D\n(property) D: typeof D", ranges: [r1, r5, r5] }, // TODO: should only reference r5 once
]);
verify.referenceGroups(r2, [
{ definition: "(local class) D", ranges: [r2] },
{ definition: "class D\n(property) D: typeof D", ranges: [r5] },
]);
verify.referenceGroups([r3, r4], [
{ definition: 'module "/a"', ranges: [r4, rModule] },
/// This should be same as the correct one checked at the start
//{ definition: "(local class) C", ranges: [r0] },
//{ definition: "(alias) (local class) export=\nimport export=", ranges: [r3] },
]);
```
**Expected behavior:**
**Actual behavior:**
**Playground Link:** <!-- A link to a TypeScript Playground "Share" link which demonstrates this behavior -->
**Related Issues:** <!-- Did you find other bugs that looked similar? -->
| Bug,Domain: Symbol Navigation | low | Critical |
570,157,456 | go | cmd/go: clean file paths in module replace directives | ### What version of Go are you using (`go version`)?
<pre>
$ go version
1.14rc1
</pre>
### Does this issue reproduce with the latest release?
yes
### What operating system and processor architecture are you using (`go env`)?
<details><summary><code>go env</code> Output</summary><br><pre>
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/jayconrod/Library/Caches/go-build"
GOENV="/Users/jayconrod/Library/Application Support/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOINSECURE=""
GONOPROXY=""
GONOSUMDB=""
GOOS="darwin"
GOPATH="/Users/jayconrod/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/opt/go/installed"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/opt/go/installed/pkg/tool/darwin_amd64"
GCCGO="gccgo"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD="/Users/jayconrod/Code/test/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/rq/x0692kqj6ml8cvrhcqh5bswc008xj1/T/go-build479050676=/tmp/go-build -gno-record-gcc-switches -fno-common"
</pre></details>
### What did you do?
Create a `go.mod` file with a `replace` directive with an unclean path on the right side. For example, the path might have a trailing slash, or a `..` component in the middle.
Run any command that updates `go.mod`.
### What did you expect to see?
The `replace` directive should be updated with a clean path.
`go list -m -json` should report the clean path.
If `-mod=readonly` is used, `go list -m -json` should still report the clean path, but `go.mod` should not be updated.
### What did you see instead?
No change.
This partially caused #36193. | NeedsFix,modules,Tools | low | Critical |
570,162,204 | go | cmd/compile: investigate performance regression vs Go 1.13 | ### What version of Go are you using (`go version`)?
<pre>
go1.14-almost
</pre>
### Does this issue reproduce with the latest release?
Yes
### What operating system and processor architecture are you using (`go env`)?
<pre>
Linux, AMD64, does not have the recent Intel microcode update (does not need it as far as I can tell).
</pre>
### What did you do?
This is a do-not-forget performance note.
Somewhere during 1.14 development, [performance of the "bent" benchmark](https://perf.golang.org/search?q=bentstamp%3A20200213T213137)
<pre>
github.com/ethereum/go-ethereum/common/bitutil
Encoding4KBVerySparse
</pre>
got worse by about 9% (it varies). According to bisection this was linked to
[insertion of a dead code phase in the compiler to improve debugging output](https://go-review.googlesource.com/c/go/+/198479) but I have not tracked down the exact cause. It could be related to branch alignment, but superficially it "makes no sense". | Performance,NeedsInvestigation,compiler/runtime | low | Critical |
570,172,361 | flutter | Assert if an invisible widget is continuing to cause rebuilds, at least in some cases | Related idea to #51000
Related to https://github.com/flutter/flutter/pull/50842
It would be nice if the framework warned you when you if you caused a widget to rebuild while it is invisible, perhaps with a directive to consider using a `Visibility` widget for this case. This can be a somewhat confusing thing to diagnose, as it's easy to imagine that your animated GIF or animated widget is not doing work once you can't see it anymore - and it can be particularly confusing if you're consuming the animation from third party package and not sure about whether the package is doing this automatically or not.
/cc @goderbauer @shihaohong @digiter @liyuqian | framework,a: animation,a: error message,P2,team-framework,triaged-framework | low | Minor |
570,179,489 | pytorch | Tensor.random_ is not implemented for bfloat16 on CPU(but implemented on CUDA) |
```
In [1]: import torch
In [2]: t = torch.empty(100, dtype=torch.bfloat16, device='cpu')
In [3]: t.random_()
---------------------------------------------------------------------------
RuntimeError Traceback (most recent call last)
<ipython-input-3-19301e232e42> in <module>
----> 1 t.random_()
RuntimeError: _th_random_ not supported on CPUType for BFloat16
In [4]: t = torch.empty(100, dtype=torch.bfloat16, device='cuda')
In [5]: t.random_()
Out[5]:
tensor([154., 228., 30., 46., 229., 165., 194., 0., 138., 97., 159., 49.,
126., 242., 20., 37., 121., 248., 96., 250., 145., 142., 189., 200.,
33., 210., 225., 44., 189., 207., 165., 169., 251., 191., 2., 59.,
33., 75., 155., 73., 175., 173., 209., 50., 222., 116., 256., 229.,
198., 208., 135., 218., 163., 235., 21., 107., 134., 178., 16., 39.,
124., 104., 231., 242., 157., 108., 177., 238., 67., 225., 33., 129.,
193., 204., 195., 64., 94., 72., 216., 189., 232., 207., 102., 107.,
187., 55., 74., 87., 220., 211., 3., 83., 86., 74., 149., 186.,
85., 29., 155., 31.], device='cuda:0', dtype=torch.bfloat16)
```
cc @VitalyFedyunin | module: cpu,triaged,module: random | low | Critical |
570,255,482 | pytorch | Support pipelining the backward pass and optimizer.step() for distributed autograd. | ## 🚀 Feature
## Motivation
Some pseudocode for what a training loop looks like when using distributed autograd today:
```
for data in iterator:
loss = model.forward()
dist_autograd.backward([loss])
optim.step()
```
Distributed backward runs on multiple nodes and accumulates gradients on different nodes via RPC. Once the complete backward pass is done, only then we run `DistributedOptimizer.step()` which basically does an RPC to all of those nodes again and updates the parameters on those nodes. There is an opportunity here to pipeline these two operations such that they overlap and avoid additional RPCs.
## Pitch
Enhance the distributed backward pass to overlap with the optimizer. Once the distributed backward pass has computed all the gradients necessary for a particular parameter, we should just run the optimizer for that parameter inline as well (instead of waiting for the entire backward pass to be done and running the optimizer separately).
A couple of options in terms of how this can be done in the API:
1. Allow distributed backward to take a DistributedOptimizer instance as part of the backward API to execute the optimizer in parallel.
2. Register post hooks for the parameters we need to optimize, run the optimizer in the post hooks and enable post hooks for distributed autograd.
cc @pietern @mrshenli @pritamdamania87 @zhaojuanmao @satgera @rohan-varma @gqchen @aazzolini @xush6528 @osalpekar @jjlilley | oncall: distributed,triaged,module: rpc | low | Minor |
570,340,365 | rust | rustc's -W/A/D/F options should ignore clippy:: lints | <!--
Thank you for filing a bug report! 🐛 Please provide a short summary of the bug,
along with any information you feel relevant to replicating the bug.
-->
In code, rustc will ignore:
```
#![allow(clippy::foo)]
```
But it fails with:
```
$ rustc --crate-type lib --emit metadata -Aclippy::foo t.rs
error[E0602]: unknown lint: `clippy::foo`
|
= note: requested on the command line with `-A clippy::foo`
error: aborting due to previous error
For more information about this error, try `rustc --explain E0602`.
```
It should ignore unknown options consistent with directives in source code.
The current behaviour means that one can't share the same command line when invoking `rustc` vs `clippy-driver`.
### Meta
<!--
If you're using the stable version of the compiler, you should also check if the
bug also exists in the beta or nightly versions.
-->
`rustc --version --verbose`:
```
rustc 1.43.0-nightly (8aa9d2014 2020-02-21)
binary: rustc
commit-hash: 8aa9d2014f4e5258f83b907e8431c59a33acdae7
commit-date: 2020-02-21
host: x86_64-unknown-linux-gnu
release: 1.43.0-nightly
LLVM version: 9.0
``` | A-lints,C-bug | low | Critical |
570,446,244 | create-react-app | Control TSC's noEmit or emitDeclarationOnly when using composite projects | `create-react-app` doesn't work in composite typescript projects, because for composite projects `emitDeclarationOnly` must be used instead of `noEmit` (when using noEmit: true and composite: true typescript compiler throws an error). I suggest to add a check - if typescript project is composite-based, use `emitDeclarationOnly` flag instead of `noEmit`.
See https://github.com/microsoft/TypeScript/issues/36917 for more information. | issue: proposal,needs triage | medium | Critical |
570,451,865 | ant-design | dataIndex with dot notation returns undefined when getting value on EditCell example [Table Component] | - [x] I have searched the [issues](https://github.com/ant-design/ant-design/issues) of this repository and believe that this is not a duplicate.
### Reproduction link
[](https://codesandbox.io/s/cool-leaf-7mnjj)
### Steps to reproduce
Set `dataIndex` to a nested object property
### What is expected?
`record[dataIndex]` should return the nested object value when trying to edit the cell value.
### What is actually happening?
It returns `undefined`
| Environment | Info |
|---|---|
| antd | 3.26.12 |
| React | 16.12.0 |
| System | MacOS 10.15.3 |
| Browser | Chrome 79.0 |
---
Take a look at console in sandbox link, temp workaround is to add `object-path` npm package in order to get the record value at current nested path.
<!-- generated by ant-design-issue-helper. DO NOT REMOVE --> | Inactive | low | Minor |
570,473,498 | flutter | Flutter performance problems on specific device(s) | <!-- Thank you for using Flutter!
If you are looking for support, please check out our documentation
or consider asking a question on Stack Overflow:
* https://flutter.dev/
* https://api.flutter.dev/
* https://stackoverflow.com/questions/tagged/flutter?sort=frequent
If you have found a performance problem, then fill our the template below.
Please read our guide to filing a bug first: https://flutter.dev/docs/resources/bug-reports
-->
## Details
<!--
1. Please tell us exactly how to reproduce the problem you are running into.
2. Please attach a small application (ideally just one main.dart file) that
reproduces the problem. You could use https://gist.github.com/ for this.
3. Switch flutter to master channel and run this app on a physical device
using profile mode with Skia tracing enabled, as follows:
flutter channel master
flutter run --profile --trace-skia
Then press ‘P’ to enable the performance overlay.
The bleeding edge master channel is encouraged here because Flutter is
constantly fixing bugs and improving its performance. Your problem in an
older Flutter version may have already been solved in the master channel.
4. Record a video of the performance issue using another phone so we
can have an intuitive understanding of what happened. Don’t use
"adb screenrecord", as that affects the performance of the profile run.
5. Open Observatory and save a timeline trace of the performance issue
so we know which functions might be causing it. See "How to Collect
and Read Timeline Traces" on this blog post:
https://medium.com/flutter-io/profiling-flutter-applications-using-the-timeline-a1a434964af03#a499
-->
(First of all I am using profile/release mode.)
I just started using flutter so I wanted to check performance for a simple app, including a ListView and a TabBarView. I noticed that this simple app is slow on my OnePlus 6T, but running good on a Pixel C, OnePlus 7T, Pixel XL. It seems like there is not a specific Widget/... to trigger this slow behavior, but flutter performs not good in general on this device.
Here is the app: https://gist.github.com/jannik4/8c46a9868afbbf91a85de6071a910144
In this specific app scrolling vertically is smooth but when changing between tabs it noticeably stutters.
(But with a more complex ListView even scrolling vertically lags)
<!--
Please tell us which target platform(s) the problem occurs (Android / iOS / Web / macOS / Linux / Windows)
Which target OS version, for Web, browser, is the test system running?
Does the problem occur on emulator/simulator as well as on physical devices?
-->
**Target Platform:** Android
**Target OS version/browser:** 10
**Devices:** OnePlus 6T
## Logs
<!--
Run `flutter analyze` and attach any output of that command below.
If there are any analysis errors, try resolving them before filing this issue.
-->
```
$ flutter analyze
Analyzing flutter_app...
No issues found! (ran in 11.9s)
```
<!-- Finally, paste the output of running `flutter doctor -v` here, with your device plugged in. -->
```
$ flutter doctor -v
[√] Flutter (Channel stable, v1.12.13+hotfix.8, on Microsoft Windows [Version 10.0.18362.657], locale de-DE)
• Flutter version 1.12.13+hotfix.8 at C:\Users\Jannik\bin\flutter
• Framework revision 0b8abb4724 (2 weeks ago), 2020-02-11 11:44:36 -0800
• Engine revision e1e6ced81d
• Dart version 2.7.0
[!] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
• Android SDK at C:\Users\Jannik\AppData\Local\Android\Sdk
• Android NDK location not configured (optional; useful for native profiling support)
• Platform android-29, build-tools 29.0.2
• ANDROID_HOME = C:\Users\Jannik\AppData\Local\Android\Sdk
• Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
• Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b03)
X Android license status unknown.
Try re-installing or updating your Android SDK Manager.
See https://developer.android.com/studio/#downloads or visit https://flutter.dev/setup/#android-setup for detailed instructions.
[√] Android Studio (version 3.5)
• Android Studio at C:\Program Files\Android\Android Studio
• Flutter plugin version 43.0.1
• Dart plugin version 191.8593
• Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b03)
[!] IntelliJ IDEA Community Edition (version 2019.2)
• IntelliJ at C:\Users\Jannik\AppData\Local\JetBrains\Toolbox\apps\IDEA-C\ch-0\192.6817.14
X Flutter plugin not installed; this adds Flutter specific functionality.
X Dart plugin not installed; this adds Dart specific functionality.
• For information about installing plugins, see
https://flutter.dev/intellij-setup/#installing-the-plugins
[!] IntelliJ IDEA Ultimate Edition (version 2018.3)
• IntelliJ at C:\Users\Jannik\AppData\Local\JetBrains\Toolbox\apps\IDEA-U\ch-0\183.5912.21
X Flutter plugin not installed; this adds Flutter specific functionality.
X Dart plugin not installed; this adds Dart specific functionality.
• For information about installing plugins, see
https://flutter.dev/intellij-setup/#installing-the-plugins
[!] VS Code (version 1.42.1)
• VS Code at C:\Users\Jannik\AppData\Local\Programs\Microsoft VS Code
X Flutter extension not installed; install from
https://marketplace.visualstudio.com/items?itemName=Dart-Code.flutter
[√] Connected device (1 available)
• ONEPLUS A6013 • 4ece8b3b • android-arm64 • Android 10 (API 29)
! Doctor found issues in 4 categories.
```
| e: device-specific,framework,engine,f: material design,c: performance,f: scrolling,perf: speed,P2,team-design,triaged-design | low | Critical |
570,540,536 | vscode | Undo/Redo: consider to show global undo/redo as label in menu | Refs: #91248
I think we should indicate to the user that the next Undo or Redo triggers as global undo/redo by showing this in the Edit menu. E.g. `Undo (Rename)` and `Redo (Rename)`.
I would not change the labels for operations that happened from user typing and not refactorings. | feature-request,undo-redo | low | Minor |
570,543,653 | terminal | Add title to split window | # Description of the new feature/enhancement
When doing split windows in a tab, there's no header per window, rather the last command given is used int he TAB header. See attached example
Can you provide per split window a header with the command?
This is when using alt-shift-+ to open e.g. multiple Command prompts to perform pings.
<!--
A clear and concise description of what the problem is that the new feature would solve.
Describe why and how a user would use this new functionality (if applicable).
-->
# Proposed technical implementation details (optional)
Add a header to split windows with the command given
<!--
A clear and concise description of what you want to happen.
-->
| Help Wanted,Area-UserInterface,Product-Terminal,Issue-Task | medium | Major |
570,562,164 | vscode | Define a `vscode.executeSemanticHighlightProvider` command | Providers also define a command so that extensions can use them. See
https://code.visualstudio.com/api/references/commands
for examples.
The semantic highlight provider should offer something similar.
Uses cases:
- get semantic highlighting for a virtual document
| feature-request,semantic-tokens | low | Major |
570,600,210 | opencv | [Proposal] imread and imdecode RGB data | - OpenCV => 4.2
- Operating System / Platform => Any
- Compiler => Any
##### Detailed description
For main DNN frameworks it need to read RGB (not BGR!) data from jpeg files. But now OpenCV can decode images only in BGR colour space. So cv::imread:
1. [auto in imgcodecs] Decode from jpeg to YUVxxx
2. [auto in imgcodecs] Convert from YUVxxx to RGB and memory allocation
3. [auto in imgcodecs] Convert from RGB to BGR and memory allocation (JpegDecoder::readData):
```
if( cinfo->out_color_components == 3 )
icvCvt_RGB2BGR_8u_C3R( buffer[0], 0, data, 0, Size(m_width,1) );
```
4. [manual in user code] Convert from RGB to BGR and memory allocation:
`cv::cvtColor(imgBGR, imgRGB, cv::COLOR_BGR2RGB);`
5. [automatic in DNN framework] split RGB to [3 x W x H]
But for cv::imread we can use cv::IMREAD_UNCHANGED option. I advice to use this option in JpegDecoder::readData to reduce memory allocations and color conversions:
1. with cv::IMREAD_COLOR function returns BGR image;
2. with cv::IMREAD_UNCHANGED function returns RGB image for 3 channels (memcpy( data, buffer[0], step );).
Now for fastest jpeg decoding cv::imread is the worst choise. | category: imgcodecs,RFC | low | Major |
570,629,780 | ant-design | Virtual list example in documentation has broken layout | - [x] I have searched the [issues](https://github.com/ant-design/ant-design/issues) of this repository and believe that this is not a duplicate.
### Reproduction link
[https://next.ant.design/components/table/#components-table-demo-virtual-list](https://next.ant.design/components/table/#components-table-demo-virtual-list)
### Steps to reproduce
Select "RTL" at the top of the screen. Try scrolling the virtual list horizontally.
### What is expected?
Headers are aligned with cells
### What is actually happening?
Headers are not aligned with cells
| Environment | Info |
|---|---|
| antd | 4.0.0-rc.6 |
| React | Any |
| System | Windows 10 |
| Browser | Chrome 79 |
<!-- generated by ant-design-issue-helper. DO NOT REMOVE --> | help wanted,Inactive,rtl | low | Critical |
570,733,045 | create-react-app | Update workbox-webpack-plugin to strip deprecated [email protected] | ### Is your proposal related to a problem?
Update `workbox-webpack-plugin` to strip deprecated `[email protected]`.
### Describe the solution you'd like
```bash
└─┬ [email protected]
└─┬ [email protected]
└─┬ [email protected]
└─┬ [email protected]
└─┬ [email protected]
└─┬ [email protected]
└── [email protected]
```
https://www.npmjs.com/package/workbox-webpack-plugin
| issue: proposal,needs triage | low | Major |
570,747,231 | vscode | Task instanceLimit doesn't work when depending on long running tasks | Re #91154
```
{
"label": "Run Mock",
"type": "shell",
"command": "./scripts/test.sh",
"windows": {
"command": ".\\scripts\\test.bat"
},
"group": "test",
"presentation": {
"echo": true,
"reveal": "always"
},
"dependsOn": [
"Run tests"
],
"runOptions": {
"instanceLimit": 3
}
},
{
"label": "Run tests",
"type": "shell",
"command": "./scripts/test.sh",
"windows": {
"command": ".\\scripts\\test.bat"
},
"group": "test",
"presentation": {
"echo": true,
"reveal": "always"
}
},
```
Run `Run Mock` 6 times, there is only one terminal open which runs `Run tests` and no hinting at all about how many `Run Mock` tasks are initialized. Once `Run tests` finishes, 6 `Run Mock` tasks are created, which ignores the instance limit. | bug,tasks | low | Minor |
570,748,845 | flutter | [tool_crash] xcrun simctl install crashes: ProcessException: ...An application bundle was not found at the provided path... | ## Command
```
flutter run
```
## Logs
```bash
ProcessException: ProcessException: Process exited abnormally:
An error was encountered processing the command (domain=NSPOSIXErrorDomain, code=2):
Failed to install the requested application
An application bundle was not found at the provided path.
Provide a valid path to the desired application bundle.
Command: /usr/bin/xcrun simctl install B62A8778-6255-4ACE-8D3E-A47C97AE7BD2 /Volumes/Macintosh Data/ragogna/build/ios/iphonesimulator/Runner.app
```
```bash
#0 RunResult.throwException (package:flutter_tools/src/base/process.dart:172:5)
#1 _DefaultProcessUtils.run (package:flutter_tools/src/base/process.dart:322:19)
<asynchronous suspension>
#2 SimControl.install (package:flutter_tools/src/ios/simulators.dart:145:29)
#3 IOSSimulator._setupUpdatedApplicationBundle (package:flutter_tools/src/ios/simulators.dart:452:31)
<asynchronous suspension>
#4 IOSSimulator.startApp (package:flutter_tools/src/ios/simulators.dart:351:15)
#5 FlutterDevice.runHot (package:flutter_tools/src/resident_runner.dart:436:54)
#6 _rootRunUnary (dart:async/zone.dart:1134:38)
#7 _CustomZone.runUnary (dart:async/zone.dart:1031:19)
#8 _FutureListener.handleValue (dart:async/future_impl.dart:140:18)
#9 Future._propagateToListeners.handleValueCallback (dart:async/future_impl.dart:682:45)
#10 Future._propagateToListeners (dart:async/future_impl.dart:711:32)
#11 Future._completeWithValue (dart:async/future_impl.dart:526:5)
#12 _AsyncAwaitCompleter.complete (dart:async-patch/async_patch.dart:34:15)
#13 _completeOnAsyncReturn (dart:async-patch/async_patch.dart:293:13)
#14 ApplicationPackageFactory.getPackageForPlatform (package:flutter_tools/src/application_package.dart)
#15 _rootRunUnary (dart:async/zone.dart:1134:38)
#16 _CustomZone.runUnary (dart:async/zone.dart:1031:19)
#17 _FutureListener.handleValue (dart:async/future_impl.dart:140:18)
```
```console
[✓] Flutter (Channel master, v1.15.4-pre.139, on Mac OS X 10.14.5 18F132, locale en-IT)
• Flutter version 1.15.4-pre.139 at /Users/cosminrus/Utils/flutter
• Framework revision 4df8fdb7df (3 days ago), 2020-02-22 18:24:03 -0800
• Engine revision f2f8c342be
• Dart version 2.8.0 (build 2.8.0-dev.9.0 0f141be8bd)
[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
• Android SDK at /Users/cosminrus/Library/Android/sdk
• Android NDK location not configured (optional; useful for native profiling support)
• Platform android-29, build-tools 29.0.2
• Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
• Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405)
• All Android licenses accepted.
[✓] Xcode - develop for iOS and macOS (Xcode 11.3)
• Xcode at /Applications/Xcode.app/Contents/Developer
• Xcode 11.3, Build version 11C29
• CocoaPods version 1.8.4
[✓] Android Studio (version 3.5)
• Android Studio at /Applications/Android Studio.app/Contents
• Flutter plugin version 42.1.1
• Dart plugin version 191.8593
• Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405)
[✓] VS Code (version 1.41.1)
• VS Code at /Applications/Visual Studio Code.app/Contents
• Flutter extension version 3.8.1
[✓] Connected device (1 available)
• iPhone 11 Pro Max • B62A8778-6255-4ACE-8D3E-A47C97AE7BD2 • ios • com.apple.CoreSimulator.SimRuntime.iOS-13-3 (simulator)
• No issues found!
```
## Flutter Application Metadata
**Version**: 0.0.1+0.0.1
**Material**: true
**Android X**: false
**Module**: false
**Plugin**: false
**Android package**: null
**iOS bundle identifier**: null
### Plugins
add_2_calendar-1.3.1
path_provider-1.6.1
share-0.6.3+6
sqflite-1.2.1
url_launcher-5.4.2
url_launcher_macos-0.0.1+4
url_launcher_web-0.1.1+1
| c: crash,tool,P2,team-tool,triaged-tool | low | Critical |
570,764,166 | rust | False warning: "unused logical operation that must be used" | In a loop, in some cases, rustc seems to not understand that a boolean expression was used for sideeffects, and warns about unused logical operation. The following code can quickly replicate the problem.
```rust
use std::sync::{atomic::{AtomicBool, Ordering}, Arc};
fn main() {
let running = Arc::new(AtomicBool::from(true));
{
let running = Arc::clone(&running);
std::thread::spawn(move || {
running.swap(false, Ordering::Relaxed);
});
}
loop {
// ...
println!("Running....");
!running.load(Ordering::Relaxed) && break;
}
println!("Exhausted >.>");
}
```
The expected result is that rustc doesn't output a warning in this case.
### Meta
* rustc version: 1.41.0 | A-lints,T-compiler,C-bug | low | Major |
570,788,270 | flutter | `flutter test` fails to clean up if the process is interrupted | The easiest way to reproduce this is to run `flutter test --start-paused path\to\test.dart`, wait for it to generate its temp files, and hit ctrl+C
This leaks files into the temp directory, which can get pretty full.
Related to #51421 | a: tests,team,tool,a: quality,P2,c: flake,team-tool,triaged-tool | low | Minor |
570,791,201 | go | x/tools/gopls: go/parser work-arounds | This issue tracks all of the workarounds implemented in `gopls` to handle places where go/parser loses information. Most of this code can be found in [`golang.org/x/tools/internal/lsp/cache/parse.go`](https://github.com/golang/tools/blob/fefc8d187781328d218f957bacb7632909acab8f/internal/lsp/cache/parse.go#L220) and was written by @muirdm.
The current list of workarounds includes handling:
- Missing curly braces in `if` statements (`if foo` -> `if foo {}`)
- Missing selectors (`x.` -> `x._`)
- Partial identifiers that are keywords (`foo.var` -> `foo._`)
- Missing conditional statements in `if` statements with initialization statements (`if i := 0`)
- Unexpected array types (`[]int` -> `[]int{}`)
- Incomplete `go` or `defer` statements (`go foo` -> `go foo()`).
- Dangling selectors in `go` or `defer` statements
```go
go foo.
y := 1
```
becomes
```go
go foo._
y := 1
``` | Thinking,gopls,Tools | low | Minor |
570,815,351 | go | x/build: add slowbots heuristics | Slowbots are awesome, but manual, and thus error-prone.
We could add some heuristics to automatically trigger appropriate slowbots. For example, any change that touches cmd/compile/internal/ssa/rewrite_ARCH.go should trigger slowbots for that arch (or set of arches). Similarly for any file named whatever_ARCH.s. Probably something similar for files named whatever_OS.go.
We could start small and improve heuristics over time. There'd be a few false positives, but probably few enough that it'd be worth it.
cc @bcmills @dmitshur
| help wanted,Builders,NeedsInvestigation,FeatureRequest | low | Critical |
570,822,632 | terminal | COOKED_READ with prompt the width of the buffer places the cursor inside prompt, mangles prompt | Migrated from MSFT:25341382.
Original description:
> If the command prompt is as long as the terminal window is wide, then hitting Escape clips off the > character at the end of the prompt.
/cc @bviglietta | Product-Conhost,Area-Input,Issue-Bug,Priority-3 | low | Minor |
570,823,920 | flutter | [google_maps_flutter] API for setting GMSServices.provideAPIKey | Can we get an API for setting `GMSServices.provideAPIKey` so that we can avoid baking hard-coded values in `AppDelegate` (as described [here](https://pub.dev/packages/google_maps_flutter#ios))?
## Use case
Avoid hard-coding sensitive API keys in `AppDelegate` (as described [here](https://pub.dev/packages/google_maps_flutter#ios)).
## Proposal
If there was an API exposed to Dart, one could get the API key from the database after authentication or _Firebase Remote Config_, and then pass it to _Google Maps_ before instantiating a widget.
_Will this approach work for [Android](https://pub.dev/packages/google_maps_flutter#android) too?_ (Obviously, a uniform solution is ideal.) | platform-ios,p: maps,package,c: proposal,team-ecosystem,P3,triaged-ecosystem | medium | Major |
570,858,954 | opencv | Pre-built iOS frameworks have bad structure | ##### System information (version)
- OpenCV => 4.1.1 or higher
- Operating System / Platform => macOS 10.15.3
- Compiler => Xcode 11.3.1 (11C504)
##### Detailed description
The pre-built frameworks seem to all lack a proper Info.plist at the top level of the framework bundle, and the overall structure is incorrect in some way that Xcode 11 refuses. The Info.plist file in the Resources folder seems to be incomplete. It looks like this:
```
<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
<dict>
<key>CFBundleName</key>
<string>OpenCV</string>
<key>CFBundleIdentifier</key>
<string>org.opencv</string>
<key>CFBundleVersion</key>
<string>4.2.0</string>
<key>CFBundleShortVersionString</key>
<string>4.2.0</string>
<key>CFBundleSignature</key>
<string>????</string>
<key>CFBundlePackageType</key>
<string>FMWK</string>
</dict>
</plist>
```
But a proper Info.plist should look more like this:
```
<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
<dict>
<key>BuildMachineOSBuild</key>
<string>18G103</string>
<key>CFBundleDevelopmentRegion</key>
<string>en</string>
<key>CFBundleExecutable</key>
<string>FileKit</string>
<key>CFBundleIdentifier</key>
<string>com.nikolaivazquez.FileKit</string>
<key>CFBundleInfoDictionaryVersion</key>
<string>6.0</string>
<key>CFBundleName</key>
<string>FileKit</string>
<key>CFBundlePackageType</key>
<string>FMWK</string>
<key>CFBundleShortVersionString</key>
<string>4.0.1</string>
<key>CFBundleSignature</key>
<string>????</string>
<key>CFBundleSupportedPlatforms</key>
<array>
<string>iPhoneOS</string>
</array>
<key>CFBundleVersion</key>
<string>12</string>
<key>DTCompiler</key>
<string>com.apple.compilers.llvm.clang.1_0</string>
<key>DTPlatformBuild</key>
<string>17B102</string>
<key>DTPlatformName</key>
<string>iphoneos</string>
<key>DTPlatformVersion</key>
<string>13.2</string>
<key>DTSDKBuild</key>
<string>17B102</string>
<key>DTSDKName</key>
<string>iphoneos13.2</string>
<key>DTXcode</key>
<string>1120</string>
<key>DTXcodeBuild</key>
<string>11B53</string>
<key>MinimumOSVersion</key>
<string>8.0</string>
<key>UIDeviceFamily</key>
<array>
<integer>1</integer>
<integer>2</integer>
</array>
</dict>
</plist>
```
It ends up being much simpler to structure the framework like this:
```
$ tree opencv2.framework
├── Headers
├── Info.plist
└── opencv2
```
Doing all of the above allows Xcode to sign the framework without the discouraged `--deep`, and it allows the iOS loader to succeed.
##### Steps to reproduce
n/a | category: build/install,platform: ios/osx | low | Minor |
570,866,891 | pytorch | [JIT] BroadcastingList annotations don't work with ignore'd functions | ## 🐛 Bug
```
@torch.jit.ignore
def foo(x):
# type: (BroadcastingList1[float]) -> List[float]
return x
@torch.jit.script
def hi():
return foo(1.)
```
cc @suo | oncall: jit,triaged | low | Critical |
570,879,315 | pytorch | Deepcopy fails with nn.parallel.replicate | ## 🐛 Bug
I have a use case where I need to copy an entire model using copy.deepcopy. If I want to run this on multiple GPUs, ideally I would use `DataParallel` but since my input to my model is not a tensor, I am trying to parallelize it myself using `nn.parallel.replicate` and `nn.parallel.parallel_apply`. However, when I try to do the forward pass using `nn.parallel.parallel_apply` after the models were replicated on all devices using `nn.parallel.replicate`, I get an error saying the deepcopy is not supported. What is the idea behind not allowing this? Is the replicate method doing a different kind of copy of the model that prevents performing a deepcopy later? Is there a workaround in this case?
## To Reproduce
Code to reproduce the behavior:
```
import copy
from torch import nn, optim
import torch
from torch.nn.utils.rnn import pack_padded_sequence, pad_packed_sequence
class Base(nn.Module):
def __init__(self, hidden=10):
super(Base, self).__init__()
self.hidden = hidden
self.gru = nn.GRU(input_size=50,
hidden_size=self.hidden,
num_layers=1,
batch_first=True,
bidirectional=True
)
self.linear = nn.Linear(2 * self.hidden, 10)
self.tanh = nn.Tanh()
def forward(self, input, input_len):
packed = pack_padded_sequence(input, input_len, batch_first=True, enforce_sorted=False)
hidden, _ = self.gru(packed)
hidden, _ = pad_packed_sequence(hidden, batch_first=True)
hidden = self.tanh(hidden)
d = self.tanh(self.linear(hidden))
return d
class MetaModel(nn.Module):
def __init__(self):
super(MetaModel, self).__init__()
self.learner = Base()
self.loss = nn.CrossEntropyLoss()
self.lr = 0.1
def forward(self, support_x, support_y, support_len, query_x, query_y, query_len):
learner = copy.deepcopy(self.learner)
params = [p for p in learner.parameters() if p.requires_grad]
optimizer = optim.SGD(params, lr=self.lr)
output = learner(support_x, support_len)
loss = self.loss(output.view(-1, 10), support_y.view(-1))
optimizer.zero_grad()
loss.backward()
optimizer.step()
output = learner(query_x, query_len)
loss = self.loss(output.view(-1, 10), query_y.view(-1))
grads = torch.autograd.grad(loss, learner.parameters())
return grads
if __name__ == '__main__':
support_x = torch.randn(size=(5, 10, 50))
support_y = torch.randint(0, 10, size=(5, 10))
support_len = torch.ones(5) * 10
query_x = torch.randn(size=(5, 10, 50))
query_y = torch.randint(0, 10, size=(5, 10))
query_len = torch.ones(5) * 10
model = MetaModel()
grads = model(support_x, support_y, support_len, query_x, query_y, query_len)
device = torch.device('cuda' if torch.cuda.is_available() else 'cpu')
if torch.cuda.is_available() and torch.cuda.device_count() > 1:
model = model.to(device)
device_ids = list(range(torch.cuda.device_count()))
replica_models = nn.parallel.replicate(model, device_ids)
inputs = ([support_x, support_y, support_len, query_x, query_y, query_len], ) * len(device_ids)
print(inputs)
print(len(inputs))
outputs = nn.parallel.parallel_apply(replica_models, inputs)
print(outputs)
```
## Expected behavior
Expected to work fine without any errors but I get this:
``` outputs = nn.parallel.parallel_apply(replica_models, inputs)
File "/home/nithinh/.local/lib/python3.6/site-packages/torch/nn/parallel/parallel_apply.py", line 85, in parallel_apply
output.reraise()
File "/home/nithinh/.local/lib/python3.6/site-packages/torch/_utils.py", line 394, in reraise
raise self.exc_type(msg)
RuntimeError: Caught RuntimeError in replica 0 on device 0.
Original Traceback (most recent call last):
File "/home/nithinh/.local/lib/python3.6/site-packages/torch/nn/parallel/parallel_apply.py", line 60, in _worker
output = module(*input, **kwargs)
File "/home/nithinh/.local/lib/python3.6/site-packages/torch/nn/modules/module.py", line 532, in __call__
result = self.forward(*input, **kwargs)
File "dummy.py", line 37, in forward
learner = copy.deepcopy(self.learner)
File "/hpc/eb/Debian9/Python/3.6.3-foss-2017b/lib/python3.6/copy.py", line 180, in deepcopy
y = _reconstruct(x, memo, *rv)
File "/hpc/eb/Debian9/Python/3.6.3-foss-2017b/lib/python3.6/copy.py", line 280, in _reconstruct
state = deepcopy(state, memo)
File "/hpc/eb/Debian9/Python/3.6.3-foss-2017b/lib/python3.6/copy.py", line 150, in deepcopy
y = copier(x, memo)
File "/hpc/eb/Debian9/Python/3.6.3-foss-2017b/lib/python3.6/copy.py", line 240, in _deepcopy_dict y[deepcopy(key, memo)] = deepcopy(value, memo)
File "/hpc/eb/Debian9/Python/3.6.3-foss-2017b/lib/python3.6/copy.py", line 180, in deepcopy
y = _reconstruct(x, memo, *rv)
File "/hpc/eb/Debian9/Python/3.6.3-foss-2017b/lib/python3.6/copy.py", line 306, in _reconstruct
value = deepcopy(value, memo)
File "/hpc/eb/Debian9/Python/3.6.3-foss-2017b/lib/python3.6/copy.py", line 180, in deepcopy
y = _reconstruct(x, memo, *rv)
File "/hpc/eb/Debian9/Python/3.6.3-foss-2017b/lib/python3.6/copy.py", line 280, in _reconstruct
state = deepcopy(state, memo)
File "/hpc/eb/Debian9/Python/3.6.3-foss-2017b/lib/python3.6/copy.py", line 150, in deepcopy
y = copier(x, memo)
File "/hpc/eb/Debian9/Python/3.6.3-foss-2017b/lib/python3.6/copy.py", line 240, in _deepcopy_dict y[deepcopy(key, memo)] = deepcopy(value, memo)
File "/hpc/eb/Debian9/Python/3.6.3-foss-2017b/lib/python3.6/copy.py", line 180, in deepcopy
y = _reconstruct(x, memo, *rv)
File "/hpc/eb/Debian9/Python/3.6.3-foss-2017b/lib/python3.6/copy.py", line 306, in _reconstruct
value = deepcopy(value, memo)
File "/hpc/eb/Debian9/Python/3.6.3-foss-2017b/lib/python3.6/copy.py", line 161, in deepcopy
y = copier(memo)
File "/home/nithinh/.local/lib/python3.6/site-packages/torch/tensor.py", line 44, in __deepcopy__ raise RuntimeError("Only Tensors created explicitly by the user "
RuntimeError: Only Tensors created explicitly by the user (graph leaves) support the deepcopy protocol at the moment
```
## Environment
PyTorch version: 1.4.0
Is debug build: No
CUDA used to build PyTorch: 10.1
OS: Debian GNU/Linux 9.12 (stretch)
GCC version: (GCC) 6.4.0
CMake version: version 3.7.2
Python version: 3.6
Is CUDA available: Yes
CUDA runtime version: Could not collect
GPU models and configuration:
GPU 0: GeForce GTX 1080 Ti
GPU 1: GeForce GTX 1080 Ti
GPU 2: GeForce GTX 1080 Ti
GPU 3: GeForce GTX 1080 Ti
Nvidia driver version: 418.56
cuDNN version: Could not collect
Versions of relevant libraries:
[pip3] numpy==1.18.1
[pip3] numpydoc==0.9.1
[pip3] pytorch-pretrained-bert==0.6.2
[pip3] pytorch-transformers==1.1.0
[pip3] torch==1.4.0
[pip3] torch-nightly==1.2.0.dev20190722
[pip3] torchtext==0.5.0
[pip3] torchvision==0.5.0
[conda] Could not collect
## Additional context
NA
| triaged,module: data parallel | low | Critical |
570,889,901 | TypeScript | Add a modifier for "closed" blocks and functions | ## Search Terms
puppeteer, worker, webpack
## Suggestion
Add a `closed` clause to create blocks/functions that cannot capture any value outside the scope of the block. Any dependencies must be imported explicitly within the block. These dependencies can be inlined to form a self-contained block (using an extra `inline` keyword in the `closed` statement or through a boolean field in the compiler options). The resulting inline block can be optimized and unused code can be removed.
## Use Cases
### Serialize functions
Tools like [puppeteer](https://github.com/puppeteer/puppeteer) provide functions to perform a callback in the browser context. These callbacks are serialized. This can cause problems with functions in TypeScript, since the language uses `tslib` and errors like `awaiter is not defined` can occur. Also, the compiler will not report an error when any value is captured within the callback, but these values will not be available within the browser context.
### Workers in webpack
There are some problems when using workers with webpack. The emitted code for the `import|require` statements contains functions that will not be available in the worker scope. With a `closed inline block`, these problems are resolved without needs to use any extra plugin or loader.
## Examples
```typescript
const path = require('path')
closed {
const pathSeparator = path.sep // Compiler error - `path` is not defined
import('path').then(module => { // The right way
// ...
})
}
closed inline {
const pathSeparator = path.sep // Compiler error - `path` is not defined
import('path').then(module => { // The right way
// The path module will be inlined within the `closed inline` block
})
}
closed function foo() {
const pathSeparator = path.sep // Compiler error - `path` is not defined
import('path').then(module => { // The right way
// ...
})
}
closed inline foo() {
const pathSeparator = path.sep // Compiler error - `path` is not defined
import('path').then(module => { // The right way
// The path module will be inlined within the `closed inline` function
})
}
```
| Suggestion,Awaiting More Feedback | low | Critical |
570,897,547 | pytorch | MSE Loss Implementation | During the implementation of ONNX export of mse loss function I encountered a problem with broadcastable tensors (not supported in ONNX), and I have a couple of questions about certain implementation details of mse loss in Pytorch.
1. Documentation of MSELoss states that input and target tensors should be of the same shape:
https://pytorch.org/docs/stable/nn.html#mseloss, so I don't understand why are broadcastable tensors used in mse_loss function: https://github.com/pytorch/pytorch/blob/a9cef05f5d6ca2a74f993feb191531a03e445d40/torch/nn/functional.py#L2523
2. When required_grad is set to True for target tensor, tensors don't need to be broadcastable: https://github.com/pytorch/pytorch/blob/a9cef05f5d6ca2a74f993feb191531a03e445d40/torch/nn/functional.py#L2518. Why is the condition of requires grad only applied for target and not for input as well?
@houseroad
cc @houseroad @spandantiwari @lara-hdr @BowenBao @neginraoof | triaged | low | Minor |
570,944,964 | rust | Inferred lifetimes in static trait method resolve to 'static, even though a local lifetime would suffice | With a static function `sf` on a trait implemented on struct `S`, then calling `S::sf(&value)` with value being `(&str, …)`, the borrow checker will report that the string within the tuple doesn't live long enough. It behaves like it expects `&str` to be static, and indeed works only with &'static strings. However, if `S::sf` is made into a standalone function `sf`, it works as expected with non-static strings.
I tried to run `cargo check` on [this code](https://github.com/crates-io/criner/blob/2c6314397b347d4b3ddd4dcf6e3f0278bcaa447b/criner/src/engine/report/waste.rs#L50-L57), which caused these error messages:
<img width="794" alt="Screenshot 2020-02-26 at 08 02 37" src="https://user-images.githubusercontent.com/63622/75298787-6907ff00-586e-11ea-8363-83730d55b9e2.png">
Instead I expected the check to pass.
When commenting in [this line](https://github.com/crates-io/criner/blob/2c6314397b347d4b3ddd4dcf6e3f0278bcaa447b/criner/src/engine/report/waste.rs#L59) and commenting out [this line](https://github.com/crates-io/criner/blob/2c6314397b347d4b3ddd4dcf6e3f0278bcaa447b/criner/src/engine/report/waste.rs#L57) `sf` is used instead, and `cargo check` passes as expected.
### How to reproduce
The following snippet takes 1min 10s to execute on a 12core laptop.
```sh
git clone https://github.com/crates-io/criner && \
cd criner && \
git checkout 2c6314397b347d4b3ddd4dcf6e3f0278bcaa447b && \
cargo check
```
### Observations
The error message provided by the borrow checker is sparse compared to how helpful it usually is. Also I do suspect it is related to interactions of using references in static trait functions.
### Meta
`rustc --version --verbose`:
```
rustc 1.41.0 (5e1a79984 2020-01-27)
binary: rustc
commit-hash: 5e1a799842ba6ed4a57e91f7ab9435947482f7d8
commit-date: 2020-01-27
host: x86_64-apple-darwin
release: 1.41.0
LLVM version: 9.0
```
Also tested on nightly - the issue persists:
`rustc +nightly --version --verbose`
```
rustc 1.43.0-nightly (834bc5650 2020-02-24)
binary: rustc
commit-hash: 834bc5650acf7019a53b409db68986857822812c
commit-date: 2020-02-24
host: x86_64-apple-darwin
release: 1.43.0-nightly
LLVM version: 9.0
``` | A-lifetimes,T-compiler,A-inference,C-bug,E-needs-mcve | low | Critical |
571,005,487 | pytorch | Add `start_process_in_context` to `torch.multiprocessing` | ## 🚀 Feature
Add the method `start_process_in_context(mp_context, fn, args=(), nprocs=1, join=True, daemon=False)` to `torch.multiprocessing.spawn` to allow the user to pass a python multiprocessing context object.
## Motivation
Currently `start_process` takes a string `start_method` and internally constructs a python multiprocessing context to start the subprocess. The issue with this approach is that if I wanted to use a multiprocessing data structure (e.g. mp Queue) in my function, this needs to be created in the context I'm running my sub-processes on which is not available to me.
See: https://github.com/pytorch/pytorch/blob/master/torch/multiprocessing/spawn.py#L137
## Pitch
See RFC PR: https://github.com/pytorch/pytorch/pull/33797
1. Add a `start_process_in_context` method that takes an `mp_context` object as a parameter
2. Change the `start_process` method to call `start_process_in_context(multiprocessing.get_context(start_method, fn, args, nprocs, join, daemon)`
## Alternatives
1. Can have the user use vanilla python multiprocessing when they want to use mp data structures in their functions. PyTorch mp adds some nice features on top of vanilla multiprocessing such as error queues and better join logic using sentinels.
## Additional context
N/A | module: multiprocessing,triaged,enhancement | low | Critical |
571,026,708 | pytorch | Can't get module gradient in autograd.Function's custom backward when DataParallel is used | I noticed a strange behavior when using `DataParallel` with custom backward pass in `autograd.Function`. Here is an example:
```py
import torch
import torch.nn as nn
from torch.autograd import Function
torch.set_default_tensor_type('torch.cuda.FloatTensor')
import os
class Combo(nn.Module):
def __init__(self):
super(Combo, self).__init__()
self.func = nn.Conv1d(3,3,3,padding=1)
def forward(self, x):
z = Debug.apply(self.func, x)
return z
class Debug(Function):
@staticmethod
def forward(ctx, f, z):
ctx.save_for_backward(z)
ctx.f = f
return z
@staticmethod
def backward(ctx, grad):
grad = grad.clone()
f = ctx.f
z, = ctx.saved_tensors
z = z.clone().detach().requires_grad_()
with torch.enable_grad():
y = f(z)
y.backward(torch.randn(z.shape), retain_graph=False)
print(f.weight.grad) # <------------------ HERE
return None, grad
net = Combo()
para_net = nn.DataParallel(net)
xx = torch.randn(4,3,7).requires_grad_() # Batch size 4
yy = para_net(xx)
loss = yy.mean()
loss.backward()
```
I want to compute and update `f.weight.grad` within the custom `backward` function (see "<----- HERE" in the code). I found that when `CUDA_VISIBLE_DEVICES=0` (i.e., only 1 GPU is used), this works fine; but if I use `CUDA_VISIBLE_DEVICES=0,1,2,3`, the printed `f.weight.grad` will be `None` on each GPU device.
My guess is that when using multiple GPUs, each device will store a copy of `f`, which creates this problem.
The desired behavior is for each device to compute its own `f.weight.grad` and then added together when eventually collected by GPU 0. Is there anyway to resolve this?
Thanks a lot! | triaged,module: data parallel | low | Critical |
571,044,574 | nvm | --lts flag won't install on ubuntu (Windows Linux Subsystem) might be just ubuntu too | The option to download <code>nvm install --lts</code> gets a bunch of downloads done and saves it in cache, however, it just spits out the lts version failed to download. In my case it said
<code>nvm: install v12.16.1 failed!</code>
A quick workaround is to just manually install the version you want.
In my case, I had tried to run the installation with the --lts flag then I just explicitly installed v 12.16.1
Might be worthwhile to look into because this might be an issue with all Ubuntu users.
Also, I downloaded nvm with curl. I'm not sure if that might help. | OS: windows,installing node,pull request wanted | low | Critical |
571,070,636 | godot | export(NodePath) references to the node and not the path | **Godot version:**
3.2 and 3.2.1 rc1
**OS/device including version:**
Windows 10 64 bit
**Issue description:**
An example:
tool
extends Position3D
```
export(NodePath) var target
var from : Spatial
func _ready():
print(target)
from = get_node(target)
print(from)
```
will print this in-editor:
../../../Skeleton2/LThigh
[BoneAttachment:66373]
../../../Skeleton2/LCalf/Position3D
[Position3D:66376]
../../../Skeleton2/LFoot
[BoneAttachment:66377]
but will print this in-game:
[Object:null]
[Object:null]
[Object:null]
I also got it to throw an error:
> Assigned type (Object) doesn't match the function argument's type (NodePath).
with the same above code, but I've been unable to recreate it. This issue was found when trying to find a workaround to #34415
I've included the project with these files, the bug is present in src/Player/Player.tscn
**Steps to reproduce:**
Using the above code and set the export value to some node
**Minimal reproduction project:**
[bug_mannequin.zip](https://github.com/godotengine/godot/files/4253474/bug_mannequin.zip)
| bug,topic:editor | low | Critical |
571,077,253 | go | cmd/go: fails when main module is in a 9P network share on Windows Subsystem for Linux | ### What version of Go are you using (`go version`)?
<pre>
$ go version
go version go1.14 windows/amd64
</pre>
### Does this issue reproduce with the latest release?
It is the last release
### What operating system and processor architecture are you using (`go env`)?
<details><summary><code>go env</code> Output</summary><br><pre>
$ go env
set GO111MODULE=on
set GOARCH=amd64
set GOBIN=
set GOCACHE=C:\Users\a\AppData\Local\go-build
set GOENV=C:\Users\a\AppData\Roaming\go\env
set GOEXE=.exe
set GOFLAGS= -mod=
set GOHOSTARCH=amd64
set GOHOSTOS=windows
set GOINSECURE=
set GONOPROXY=
set GONOSUMDB=
set GOOS=windows
set GOPATH=C:\Users\a\go
set GOPRIVATE=
set GOPROXY=direct
set GOROOT=C:\Go
set GOSUMDB=sum.golang.org
set GOTMPDIR=
set GOTOOLDIR=C:\Go\pkg\tool\windows_amd64
set GCCGO=gccgo
set AR=ar
set CC=gcc
set CXX=g++
set CGO_ENABLED=1
set GOMOD=Z:\home\a\go\graph\go.mod
set CGO_CFLAGS=-g -O2
set CGO_CPPFLAGS=
set CGO_CXXFLAGS=-g -O2
set CGO_FFLAGS=-g -O2
set CGO_LDFLAGS=-g -O2
set PKG_CONFIG=pkg-config
set GOGCCFLAGS=-m64 -mthreads -fmessage-length=0 -fdebug-prefix-map=C:\Users\a\AppData\Local\Temp\go-build115528494=/tmp/go-build -gno-record-gcc-switches
</pre></details>
### What did you do?
I'm using Windows Subsystem for Linux 2 and I access my files using a network driver. I tried to use `go mod init` in a new project and got this error :
```
a@Hackintosh-Windows MINGW64 /z/home/a/go/graph
$ go mod init graph
go: creating new go.mod: module graph
go: updating go.mod: Lock Z:\home\a\go\graph\go.mod: Fonction incorrecte.
```
(Fonction incorrecte means incorrect/invalid function)
Then i tried to create it by end with the content :
```
module graph
go 1.14
```
Running `go list -m` (or any command requiring this file actually) gives me this error : `go: RLock Z:\home\a\go\graph\go.mod: Fonction incorrecte.`
### What did you expect to see?
my go.mod file created.
### What did you see instead?
An error about Lock/RLock.
### More information:
After reinstalling go 1.13.8, i had everything working back. | OS-Windows,NeedsInvestigation,GoCommand,modules | medium | Critical |
571,116,775 | rust | impl_trait_in_bindings doesn't interact well with associated types yet | I tried this code:
```rust
#![allow(incomplete_features)]
#![feature(impl_trait_in_bindings)]
trait Trait {
type R;
}
struct A;
impl Trait for A {
type R = i32;
}
static ARR: [impl Fn(<A as Trait>::R) -> <A as Trait>::R; 1] = [|x| x];
```
https://play.rust-lang.org/?version=nightly&mode=debug&edition=2018&gist=9aed9cb362dff5db78c7af96567f31ee
I expected to see this happen: It compiles.
Instead, this happened: Compiler error:
```
error[E0277]: expected a `std::ops::Fn<(i32,)>` closure, found `impl std::ops::Fn<(<A as Trait>::R,)>`
--> src/lib.rs:13:13
|
13 | static ARR: [impl Fn(<A as Trait>::R) -> <A as Trait>::R; 1] = [|x| x];
| ^-------------------------------------------^^^^
| ||
| |required by `ARR::{{opaque}}#0`
| expected an `Fn<(i32,)>` closure, found `impl std::ops::Fn<(<A as Trait>::R,)>`
|
= help: the trait `std::ops::Fn<(i32,)>` is not implemented for `impl std::ops::Fn<(<A as Trait>::R,)>`
error: aborting due to previous error
```
Btw, this is an abbreviated version of a real world use case of using [`impl_trait_in_bindings`](https://github.com/rust-lang/rust/issues/63065).
---
Btw, this compiles: `static ARR: [impl Fn(i32) -> i32; 1] = [|x| x];`
But this `static ARR: [impl Fn(i32) -> i32; 0] = [];` gives another error:
```
error[E0391]: cycle detected when processing `ARR::{{opaque}}#0`
--> src/lib.rs:4:14
|
4 | static ARR: [impl Fn(i32) -> i32; 0] = [];
| ^^^^^^^^^^^^^^^^^^^
|
note: ...which requires borrow-checking `ARR`...
--> src/lib.rs:4:1
|
4 | static ARR: [impl Fn(i32) -> i32; 0] = [];
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
note: ...which requires processing `ARR`...
--> src/lib.rs:4:1
|
4 | static ARR: [impl Fn(i32) -> i32; 0] = [];
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
note: ...which requires const checking `ARR`...
--> src/lib.rs:4:1
|
4 | static ARR: [impl Fn(i32) -> i32; 0] = [];
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
= note: ...which requires computing whether `[impl std::ops::Fn<(i32,)>; 0]` is freeze...
= note: ...which requires evaluating trait selection obligation `[impl std::ops::Fn<(i32,)>; 0]: std::marker::Freeze`...
= note: ...which again requires processing `ARR::{{opaque}}#0`, completing the cycle
note: cycle used when collecting item types in top-level module
--> src/lib.rs:1:1
|
1 | / #![allow(incomplete_features)]
2 | | #![feature(impl_trait_in_bindings)]
3 | |
4 | | static ARR: [impl Fn(i32) -> i32; 0] = [];
| |__________________________________________^
error[E0391]: cycle detected when processing `ARR::{{opaque}}#0`
--> src/lib.rs:4:14
|
4 | static ARR: [impl Fn(i32) -> i32; 0] = [];
| ^^^^^^^^^^^^^^^^^^^
|
note: ...which requires borrow-checking `ARR`...
--> src/lib.rs:4:1
|
4 | static ARR: [impl Fn(i32) -> i32; 0] = [];
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
note: ...which requires processing `ARR`...
--> src/lib.rs:4:1
|
4 | static ARR: [impl Fn(i32) -> i32; 0] = [];
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
note: ...which requires const checking `ARR`...
--> src/lib.rs:4:1
|
4 | static ARR: [impl Fn(i32) -> i32; 0] = [];
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
= note: ...which requires evaluating trait selection obligation `[impl std::ops::Fn<(i32,)>; 0]: std::marker::Sync`...
= note: ...which again requires processing `ARR::{{opaque}}#0`, completing the cycle
note: cycle used when collecting item types in top-level module
--> src/lib.rs:1:1
|
1 | / #![allow(incomplete_features)]
2 | | #![feature(impl_trait_in_bindings)]
3 | |
4 | | static ARR: [impl Fn(i32) -> i32; 0] = [];
| |__________________________________________^
error[E0391]: cycle detected when processing `ARR::{{opaque}}#0`
--> src/lib.rs:4:14
|
4 | static ARR: [impl Fn(i32) -> i32; 0] = [];
| ^^^^^^^^^^^^^^^^^^^
|
note: ...which requires borrow-checking `ARR`...
--> src/lib.rs:4:1
|
4 | static ARR: [impl Fn(i32) -> i32; 0] = [];
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
note: ...which requires processing `ARR`...
--> src/lib.rs:4:1
|
4 | static ARR: [impl Fn(i32) -> i32; 0] = [];
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
note: ...which requires const checking `ARR`...
--> src/lib.rs:4:1
|
4 | static ARR: [impl Fn(i32) -> i32; 0] = [];
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
= note: ...which again requires processing `ARR::{{opaque}}#0`, completing the cycle
note: cycle used when collecting item types in top-level module
--> src/lib.rs:1:1
|
1 | / #![allow(incomplete_features)]
2 | | #![feature(impl_trait_in_bindings)]
3 | |
4 | | static ARR: [impl Fn(i32) -> i32; 0] = [];
| |__________________________________________^
error: could not find defining uses
--> src/lib.rs:4:14
|
4 | static ARR: [impl Fn(i32) -> i32; 0] = [];
| ^^^^^^^^^^^^^^^^^^^
error: aborting due to 4 previous errors
```
https://play.rust-lang.org/?version=nightly&mode=debug&edition=2018&gist=09044d61d101f3ac849534eb9978e7c3
But IMO it should also compile. | A-associated-items,T-compiler,C-bug,F-impl_trait_in_bindings,requires-nightly | low | Critical |
571,268,760 | pytorch | Wrongly detected: Division of ints in TorchScript uses Python 3 true division semantics | ## 🐛 Bug
<!-- A clear and concise description of what the bug is. -->
https://github.com/pytorch/pytorch/blob/758ad516f32708de243f194144ee0f7b9e0f5117/torch/jit/frontend.py#L507 gives false positive exception on expressions like `float(a) / float(b)`.
## To Reproduce
For instance [(source):](https://circleci.com/gh/pytorch/pytorch/4601756?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link)
```
Feb 26 08:48:58 File "/opt/python/cp27-cp27mu/lib/python2.7/site-packages/torch/jit/frontend.py", line 509, in build_BinOp
Feb 26 08:48:58 raise FrontendError(err_range, 'Division of ints in TorchScript uses Python 3 true '
Feb 26 08:48:58 torch.jit.frontend.FrontendError: Division of ints in TorchScript uses Python 3 true division semantics. Please put `from __future__ import division` at the top of your file:
Feb 26 08:48:58 File "/opt/python/cp27-cp27mu/lib/python2.7/site-packages/torch/_lobpcg.py", line 646
Feb 26 08:48:58 dtype=UBU.dtype)
Feb 26 08:48:58 R_norm = _utils.norm(R)
Feb 26 08:48:58 rerr = float(R_norm) / float(BU_norm * U_norm)
Feb 26 08:48:58 ~~~~ <--- HERE
Feb 26 08:48:58 vkey = 'ortho_UBUmI_rerr[{}, {}]'.format(i, j)
Feb 26 08:48:58 self.fvars[vkey] = rerr
```
## Expected behavior
<!-- A clear and concise description of what you expected to happen. -->
No exception should be raised.
| oncall: jit | low | Critical |
571,283,791 | pytorch | Models saved in C++ LibTorch with torch::save, cannot be loaded in python using torch.load | ## 🐛 Bug
Models saved in C++ LibTorch with torch::save, cannot be loaded in python using torch.load. When I save a custom model (a class which inherits from torch::nn::Module) using torch::save(model, filepath), the result is a zip archive (.pt). The archive has the same structure as [it should](https://github.com/pytorch/pytorch/blob/master/torch/csrc/jit/docs/serialization.md) but python comes up with the error
## To Reproduce
Steps to reproduce the behavior:
1. Save a class which inherits from the torch::nn::Module class in C++ using torch::save
2. Try to load that saved archive in python using torch.load
3. Find this error below:
`Traceback (most recent call last):
File "torch_plotting.py", line 59, in <module>
policy_model, value_model = load_models(containing_path, model_number)
File "torch_plotting.py", line 37, in load_models
policy_model = torch.load(policy_file)
File "/home/jamie/anaconda3/envs/tensorflow/lib/python3.7/site-packages/torch/serialization.py", line 528, in load
return _load(opened_zipfile, map_location, pickle_module, **pickle_load_args)
File "/home/jamie/anaconda3/envs/tensorflow/lib/python3.7/site-packages/torch/serialization.py", line 782, in _load
result = unpickler.load()
ModuleNotFoundError: No module named '__torch__'`
## Expected behavior
Expect to have a fully loaded model that behaves the same way as the c++ one which I can use to perform inference.
## Environment
PyTorch version: 1.4.0
Is debug build: No
CUDA used to build PyTorch: 10.1
OS: Ubuntu 19.10
GCC version: (Ubuntu 9.2.1-9ubuntu2) 9.2.1 20191008
CMake version: version 3.16.4
Python version: 3.7
Is CUDA available: Yes
CUDA runtime version: Could not collect
GPU models and configuration: GPU 0: GeForce GTX 1050 Ti
Nvidia driver version: 440.33.01
cuDNN version: Probably one of the following:
/usr/lib/x86_64-linux-gnu/libcudnn.so.7.6.5
/usr/local/cuda-10.2/targets/x86_64-linux/lib/libcudnn.so.7.6.5
Versions of relevant libraries:
[pip3] numpy==1.17.2
[pip3] numpydoc==0.9.1
[pip3] torch==1.4.0
[pip3] torchvision==0.5.0
[conda] blas 1.0 mkl
[conda] mkl 2019.4 243
[conda] mkl-service 2.3.0 py37he904b0f_0
[conda] mkl_fft 1.0.14 py37ha843d7b_0
[conda] mkl_random 1.1.0 py37hd6b4f25_0
[conda] torch 1.4.0 pypi_0 pypi
[conda] torchvision 0.5.0 pypi_0 pypi
## Additional context
I am using the libtorch provided by [this link](https://download.pytorch.org/libtorch/cpu/libtorch-shared-with-deps-1.4.0%2Bcpu.zip) and using cmake to build my project. The file to open is
[policy_9999.zip](https://github.com/pytorch/pytorch/files/4255490/policy_9999.zip) (renamed to policy_9999.zip instead of the original policy_9999.pt so it could be uploaded.)
cc @yf225 @glaringlee @SsnL | module: cpp,module: serialization,triaged | low | Critical |
571,291,636 | go | runtime: frequent enlisting of short-lived background workers leads to performance regression with async preemption | ### What version of Go are you using (`go version`)?
<pre>
λ go version
go version go1.14 windows/amd64
λ go version
go version go1.13.8 windows/amd64
</pre>
### Does this issue reproduce with the latest release?
Yes.
### What operating system and processor architecture are you using (`go env`)?
<details><summary><code>go env</code> Output</summary><br><pre>
λ go env
set GO111MODULE=
set GOARCH=amd64
set GOBIN=
set GOCACHE=C:\Users\klaus\AppData\Local\go-build
set GOENV=C:\Users\klaus\AppData\Roaming\go\env
set GOEXE=.exe
set GOFLAGS=
set GOHOSTARCH=amd64
set GOHOSTOS=windows
set GONOPROXY=
set GONOSUMDB=
set GOOS=windows
set GOPATH=e:\gopath
set GOPRIVATE=
set GOPROXY=https://goproxy.io
set GOROOT=c:\go
set GOSUMDB=sum.golang.org
set GOTMPDIR=
set GOTOOLDIR=c:\go\pkg\tool\windows_amd64
set GCCGO=gccgo
set AR=ar
set CC=gcc
set CXX=g++
set CGO_ENABLED=1
set GOMOD=
set CGO_CFLAGS=-g -O2
set CGO_CPPFLAGS=
set CGO_CXXFLAGS=-g -O2
set CGO_FFLAGS=-g -O2
set CGO_LDFLAGS=-g -O2
set PKG_CONFIG=pkg-config
set GOGCCFLAGS=-m64 -mthreads -fmessage-length=0 -fdebug-prefix-map=d:\temp\wintemp\go-build155272862=/tmp/go-build -gno-record-gcc-switches
</pre></details>
### What did you do?
Run benchmark: https://play.golang.org/p/WeuJg6yaOuJ
`go test -bench=. -test.benchtime=10s` used to test.
### What did you expect to see?
Close or similar benchmark speeds.
### What did you see instead?
40% performance regression.
```
λ benchcmp go113.txt go114.txt
benchmark old ns/op new ns/op delta
BenchmarkCompressAllocationsSingle/flate-32 87026 121741 +39.89%
BenchmarkCompressAllocationsSingle/gzip-32 88654 122632 +38.33%
```
This is not a purely theoretical benchmark. While suboptimal, this is the easiest way to compress a piece of data, so this will be seen in the wild. It could also indicate a general regression for applications allocating a lot.
Edit: This is not related to changes in the referenced packages. Seeing this when using packages outside the stdlib as well. | Performance,help wanted,NeedsFix | medium | Critical |
571,336,159 | go | x/net/html: do not parse the blank line and line break as a TextNode | <!--
Please answer these questions before submitting your issue. Thanks!
For questions please use one of our forums: https://github.com/golang/go/wiki/Questions
-->
### What version of Go are you using (`go version`)?
<pre>
$ go version
go version go1.13.7 darwin/amd64
</pre>
### Does this issue reproduce with the latest release?
Yes
### What operating system and processor architecture are you using (`go env`)?
<details><summary><code>go env</code></summary><br><pre>
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/changxin/Library/Caches/go-build"
GOENV="/Users/changxin/Library/Application Support/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GONOPROXY=""
GONOSUMDB=""
GOOS="darwin"
GOPATH="/Users/changxin/go"
GOPRIVATE=""
GOPROXY="https://goproxy.io,direct"
GOROOT="/usr/local/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/darwin_amd64"
GCCGO="gccgo"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/rl/_ybfhjr975s9ldh7zjlqnlfc0000gn/T/go-build286633492=/tmp/go-build -gno-record-gcc-switches -fno-common"
</pre></details>
### What did you do?
<!--
If possible, provide a recipe for reproducing the error.
A complete runnable program is good.
A link on play.golang.org is best.
-->
I tried to parse the golang.org page with the net / html package, and tried to print all the information in TextNode, but I found that many blank lines appeared, and after testing, I found that all the blank lines and line breaks were parsed as TextNode, but They are just empty to format the code, not the information that the page needs to display, and there is no correct way to distinguish them from the real content.
my project
`package main
import (
"fmt"
"os"
"golang.org/x/net/html"
)
func main() {
doc, err := html.Parse(os.Stdin)
if err != nil {
fmt.Fprintf(os.Stderr, "content print :%v\n", err)
}
contentPrint(doc)
}
func contentPrint(n *html.Node) {
if n.Type == html.ElementNode && n.Data != "script" && n.Data != "style" {
if n.FirstChild != nil && n.FirstChild.Type == html.TextNode {
fmt.Printf("content:%s\n", n.FirstChild.Data)
}
}
for c := n.FirstChild; c != nil; c = c.NextSibling {
contentPrint(c)
}
}`
### What did you expect to see?
`content:The Go Programming Language
content:Documents
content:Packages
content:The Project
content:Help
content:Blog
content:Play
content:Search
content:simple
content:reliable
content:efficient
content:Try Go
content:Open in Playground
content:// You can edit this code!
// Click here and start typing.
package main
import "fmt"
func main() {
fmt.Println("Hello, 世界")
}
content:Hello, World!
content:Conway's Game of Life
content:Fibonacci Closure
content:Peano Integers
content:Concurrent pi
content:Concurrent Prime Sieve
content:Peg Solitaire Solver
content:Tree Comparison
content:Run
content:Share
content:Tour
content:Featured articles
content:Go 1.14 is released
content:download page
content:Published 25 February 2020
content:Next steps for pkg.go.dev
content:go.dev
content:Published 31 January 2020
content:Read more >
content:Featured video
content:Copyright
content:Terms of Service
content:Privacy Policy
content:Report a website issue
content:Supported by Google`
### What did you see instead?
`The Go Programming Language
Documents
Packages
The Project
Help
Blog
Play
Search
simple
reliable
efficient
Try Go
Open in Playground
// You can edit this code!
// Click here and start typing.
package main
import "fmt"
func main() {
fmt.Println("Hello, 世界")
}
Hello, World!
Conway's Game of Life
Fibonacci Closure
Peano Integers
Concurrent pi
Concurrent Prime Sieve
Peg Solitaire Solver
Tree Comparison
Run
Share
Tour
Featured articles
Go 1.14 is released
download page
Published 25 February 2020
Next steps for pkg.go.dev
go.dev
Published 31 January 2020
Read more >
Featured video
Copyright
Terms of Service
Privacy Policy
Report a website issue
Supported by Google
~/go/src/go_bible/ch5/5.3 go build
~/go/src/go_bible/ch5/5.3 ./5.3 <golang_org.htm
^C
✘ ~/go/src/go_bible/ch5/5.3 go build
~/go/src/go_bible/ch5/5.3 ./5.3 <golang_org.htm
content:The Go Programming Language
content:
content:
content:
content:
content:
content:Documents
content:Packages
content:The Project
content:Help
content:Blog
content:Play
content:
content:
content:
content:Search
content:
content:
content:
content:
content:
Go is an open source programming language that makes it easy to build
content:simple
content:reliable
content:efficient
content:
content:
Binary distributions available for
content:
content:
content:Try Go
content:Open in Playground
content:
content:// You can edit this code!
// Click here and start typing.
package main
import "fmt"
func main() {
fmt.Println("Hello, 世界")
}
content:
content:
content:Hello, World!
content:Conway's Game of Life
content:Fibonacci Closure
content:Peano Integers
content:Concurrent pi
content:Concurrent Prime Sieve
content:Peg Solitaire Solver
content:Tree Comparison
content:
content:Run
content:
content:Share
content:Tour
content:
content:Featured articles
content:Go 1.14 is released
content:Today the Go team is very happy to announce the release of Go 1.14. You can get it from the
content:download page
content:Published 25 February 2020
content:Next steps for pkg.go.dev
content:In 2019, we launched
content:go.dev
content:Published 31 January 2020
content:Read more >
content:
content:Featured video
content:
content:
content:
content:
content:Copyright
content:Terms of Service
content:Privacy Policy
content:Report a website issue
content:Supported by Google` | NeedsInvestigation | low | Critical |
571,440,341 | go | github: consider using GitHub Discussions | The Go project uses the GitHub issue tracker for tracking bugs, not for asking questions or having general discussions.
Proposal #23745 was about considering using it with a "question" label, which we tried, but it wasn't a great experience for everyone involved (an issue tracker is designed primarily for tracking bugs, not asking questions or having discussions), and so we didn't proceed with it.
As @mvdan mentioned in https://github.com/golang/go/issues/23745#issuecomment-591378648, GitHub is working on a [new Discussions feature](https://news.ycombinator.com/item?id=22388639) that is specifically for having discussions rather than tracking bugs. Once it becomes available for general use, we can consider using it for the Go project. **Edit:** It's now [available](https://github.blog/2020-12-08-new-from-universe-2020-dark-mode-github-sponsors-for-companies-and-more/#discussions) in beta.
This is the tracking issue.
(Until something changes, please see https://golang.org/wiki/Questions for a list of places to ask questions and having discussions.)
/cc @golang/osp-team | NeedsInvestigation,Community | low | Critical |
571,461,152 | TypeScript | @ts-ignore on an import that gets redefined strips the import from output | <!-- 🚨 STOP 🚨 𝗦𝗧𝗢𝗣 🚨 𝑺𝑻𝑶𝑷 🚨
Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Even if you think you've found a *bug*, please read the FAQ first, especially the Common "Bugs" That Aren't Bugs section!
Please help us by doing the following steps before logging an issue:
* Search: https://github.com/Microsoft/TypeScript/search?type=Issues
* Read the FAQ: https://github.com/Microsoft/TypeScript/wiki/FAQ
Please fill in the *entire* template below.
-->
<!--
Please try to reproduce the issue with the latest published version. It may have already been fixed.
For npm: `typescript@next`
This is also the 'Nightly' version in the playground: http://www.typescriptlang.org/play/?ts=Nightly
-->
**TypeScript Version:** 3.7.5 and 3.8.0
<!-- Search terms you tried before logging this (so others can find this issue more easily) -->
**Search Terms:**
- ts-ignore remove import
- ts-ignore strip import
**Code**
```ts
// @ts-ignore: Local Foo override
import Foo from "foo";
declare const Foo: {
bar(): number;
}
Foo.bar();
```
**Expected behavior:**
JS output should probably be:
```js
import Foo from "foo";
Foo.bar();
```
**Actual behavior:**
JS output is:
```js
Foo.bar();
```
**Playground Link:** https://www.typescriptlang.org/play/index.html?ts=3.8-Beta&ssl=9&ssc=1&pln=1&pc=1#code/PTAEAEBcGcFoEsDmA7A9gJwKYC5QBlUBjAQwBtQAxVVUVAN03XXgBNMAoeAWwAcNJK1UADN0qLqABEw6pIDc7dm0KliWUIVTJoAqqlwBvdqBOgARmoAUASlzIArlzOMFAX0V6AdBfQ2FQA
**Related Issues:** None so far
---
**Additional remarks**: We are aware of other ways to type the `foo` module but in this particular case the foo override needs to be done in the file using it. As far as we tried, adding a ts-ignore is the only way to make ts understand that we want to redefine the module.
Now, this seems to move the declaration site from the import to the the declare statement and that has the effect to mark the import site as unused, since the import is unused, ts strips it. | Bug | low | Critical |
571,468,879 | flutter | Flutter OnScreen Keyboard opens on physical key press | I have a device that uses a laserscanner to scan barcodes and outputs the result as simulated keypresses. I've used this with a RawKeyboardListener and it worked fine. Since then I've added a login screen to the app, that is only shown if the user hasn't logged in. If the login screen has been shown and disposed the onscreen keyboard opens when i press the physical scanner button. This should not happen and doesn't happen if the login screen hasn't been shown. My guess is, that there still are some remains of the textfields used in the login screen, after it is disposed. I've tried setting the FocusNodes for the Textfields and then disposing them in the dispose method, but that didn't work
I've asked a question on StackOverflow: [https://stackoverflow.com/questions/60417173/flutter-onscreen-keyboard-opens-on-physical-key-press](url)
## Steps to Reproduce
1. Screen with one or more Textfields
2. focus one or more
3. navigate to new screen
4. press physical button
**Expected results:** button is pressed but only the keyevents are fired
**Actual results:** the onscreen keyboard opens
<details>
<summary>Logs</summary>
```
[√] Flutter (Channel stable, v1.12.13+hotfix.8, on Microsoft Windows [Version 10.0.16299.1686], locale de-DE)
• Flutter version 1.12.13+hotfix.8 at C:\Users\sruettge\Documents\flutter
• Framework revision 0b8abb4724 (2 weeks ago), 2020-02-11 11:44:36 -0800
• Engine revision e1e6ced81d
• Dart version 2.7.0
[√] Android toolchain - develop for Android devices (Android SDK version 29.0.1)
• Android SDK at C:\Users\sruettge\AppData\Local\Android\sdk
• Android NDK location not configured (optional; useful for native profiling support)
• Platform android-29, build-tools 29.0.1
• Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
• Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b03)
• All Android licenses accepted.
[√] Android Studio (version 3.5)
• Android Studio at C:\Program Files\Android\Android Studio
• Flutter plugin version 36.0.1
• Dart plugin version 183.6270
• Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b03)
[√] VS Code (version 1.42.1)
• VS Code at C:\Users\sruettge\AppData\Local\Programs\Microsoft VS Code
• Flutter extension version 3.8.1
[√] Connected device (1 available)
• MEMOR 10 • S19H00332 • android-arm64 • Android 8.1.0 (API 27)
• No issues found!
```
</details>
| a: text input,e: device-specific,framework,P3,team-text-input,triaged-text-input | medium | Critical |
571,513,187 | node | Many zlib tests are failing on armhf with system zlib | <!--
Thank you for reporting an issue.
This issue tracker is for bugs and issues found within Node.js core.
If you require more general support please file an issue on our help
repo. https://github.com/nodejs/help
Please fill in as much of the template below as you're able.
Version: output of `node -v`
Platform: output of `uname -a` (UNIX), or version and 32 or 64-bit (Windows)
Subsystem: if known, please specify affected core module name
-->
* **Version**: 10.19.0
* **Platform**: armhf-linux
* **Subsystem**: tests
### What steps will reproduce the bug?
<!--
Enter details about your bug, preferably a simple code snippet that can be
run using `node` directly without installing third-party dependencies.
-->
Build Node on ARMv7 with `--shared-zlib`, then run `make test-ci-js`.
### How often does it reproduce? Is there a required condition?
Every time.
### What is the expected behavior?
Tests succeed.
<!--
If possible please provide textual output instead of screenshots.
-->
### What do you see instead?
<!--
If possible please provide textual output instead of screenshots.
-->
```
ot ok 2163 parallel/test-zlib
---
duration_ms: 1.641
severity: crashed
exitcode: -7
stack: |-
...
not ok 2164 parallel/test-zlib-brotli
---
duration_ms: 1.441
severity: crashed
exitcode: -7
stack: |-
...
not ok 2165 parallel/test-zlib-brotli-flush
---
duration_ms: 1.636
severity: crashed
exitcode: -7
stack: |-
...
not ok 2166 parallel/test-zlib-brotli-from-brotli
---
duration_ms: 1.317
severity: crashed
exitcode: -7
stack: |-
...
not ok 2167 parallel/test-zlib-brotli-from-string
---
duration_ms: 1.418
severity: crashed
exitcode: -7
stack: |-
...
not ok 2174 parallel/test-zlib-convenience-methods
---
duration_ms: 1.524
severity: crashed
exitcode: -7
stack: |-
...
not ok 2199 parallel/test-zlib-random-byte-pipes
---
duration_ms: 1.445
severity: crashed
exitcode: -7
stack: |-
...
not ok 2205 parallel/test-zlib-write-after-flush
---
duration_ms: 1.315
severity: crashed
exitcode: -7
stack: |-
...
```
### Additional information
<!--
Tell us anything else you think we should know.
-->
| arm | low | Critical |
571,575,313 | vscode | [folding] pressing Enter in collapsed region should add new line outside region |
Issue Type: <b>Bug</b>
1. In a TypeScript file add a region
```ts
//#region Helper functions XXX
YYY
... some code goes here
//#endregion
ZZZ
```
2. Collapse the region.
3. Place the cursor just after XXX.
4. Press Enter
**Expected result:**
Line break is added after end of region (before ZZZ)
```ts
//#region Helper functions XXX
YYY
... some code goes here
//#endregion
ZZZ
```
**Actual result:**
Region is expanded. Line break is added at the beginning off the region (before YYY)
```ts
//#region Helper functions XXX
YYY
... some code goes here
//#endregion
ZZZ
```
VS Code version: Code 1.42.1 (c47d83b293181d9be64f27ff093689e8e7aed054, 2020-02-11T14:46:03.121Z)
OS version: Windows_NT ia32 10.0.18363
<details>
<summary>System Info</summary>
|Item|Value|
|---|---|
|CPUs|Intel(R) Core(TM) i7-6700 CPU @ 3.40GHz (8 x 3408)|
|GPU Status|2d_canvas: enabled<br>flash_3d: enabled<br>flash_stage3d: enabled<br>flash_stage3d_baseline: enabled<br>gpu_compositing: enabled<br>metal: disabled_off<br>multiple_raster_threads: enabled_on<br>oop_rasterization: disabled_off<br>protected_video_decode: unavailable_off<br>rasterization: enabled<br>skia_renderer: disabled_off<br>surface_control: disabled_off<br>surface_synchronization: enabled_on<br>video_decode: enabled<br>viz_display_compositor: enabled_on<br>viz_hit_test_surface_layer: disabled_off<br>webgl: enabled<br>webgl2: enabled|
|Load (avg)|undefined|
|Memory (System)|31.79GB (15.58GB free)|
|Process Argv||
|Screen Reader|no|
|VM|0%|
</details><details><summary>Extensions (4)</summary>
Extension|Author (truncated)|Version
---|---|---
EditorConfig|Edi|0.14.4
csharp|ms-|1.21.12
debugger-for-chrome|msj|4.12.6
vetur|oct|0.23.0
</details>
<!-- generated by issue reporter --> | feature-request,editor-folding | low | Critical |
571,615,741 | TypeScript | disable certain global types for specific files, or specify type roots for specific files. | This continues some ideas from https://github.com/microsoft/TypeScript/issues/17042, which was closed by @microsoft (for inactivity, I think?).
## Search Terms
disable certain global types for specific files, specific type roots for certain files
## Suggestion
Ability to specify which `@types` (or in general, which specified `typeRoots`) apply to which files in a project.
## Use Cases
My project's `src` folder contains both `.ts` and `.test.ts` files, and I'd like an easy way for globals like `describe` to be defined only for the `.test.ts` files.
## Examples
Not sure, but maybe some sort of new options in `tsconfig.json` for specifying which `types` items, `lib` items, or `typeRoots` items apply to which files.
This would be a beneficial feature because various editors (VS Code aside) look for a `tsconfig.json` file at the root of a project, and at the moment the only way to make types work in all files is to just provides all types for all files, which is undesirable because `describe` is not a function that is available in source files (as an example).
Example configuration: maybe instead of a `typeRoots` array, it can be an object like:
```js
"typeRoots": {
"./src/**/*.test.ts": ["../path/to/test/types"], // test-only types
"./src/**/*.ts": ["../path/to/@types"] // other types other files
}
```
Or something. That's just an example to get the idea rolling.
## Checklist
My suggestion meets these guidelines:
* [x] This wouldn't be a breaking change in existing TypeScript/JavaScript code
* [x] This wouldn't change the runtime behavior of existing JavaScript code
* [x] This could be implemented without emitting different JS based on the types of the expressions
* [x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
* [x] This feature would agree with the rest of [TypeScript's Design Goals](https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals).
| Suggestion,Awaiting More Feedback | high | Critical |
571,622,607 | node | console.group() emits duplicate CDP messages | * **Version**: v12.11.1
* **Platform**: Darwin 10.14
### What steps will reproduce the bug?
With a debugger attached, invoke:
```
console.group('group name', { foo: true });
```
### How often does it reproduce? Is there a required condition?
Every time
### What is the expected behavior?
There should be a single CDP message for the console group. Running that line of code in the Chrome devtools, that is the case and I get a single message:
### What do you see instead?
Running that line of code in Node.js, I get two messages--the correct `startGroup` type, and then an additional log message whose stack says it comes from the `group` method in `internal/console/constructor.js`
```json
{"method":"Runtime.consoleAPICalled","params":{"type":"startGroup","args":[{"type":"string","value":"group name"},{"type":"object","className":"Object","description":"Object","objectId":"{\"injectedScriptId\":1,\"id\":1}","preview":{"type":"object","description":"Object","overflow":false,"properties":[{"name":"foo","type":"boolean","value":"true"}]}}],"executionContextId":1,"timestamp":1582746620974.181,"stackTrace":{"callFrames":[{"functionName":"","scriptId":"97","url":"file:///Users/copeet/Github/vscode-pwa/demos/node/main.js","lineNumber":1,"columnNumber":8},{"functionName":"Module._compile","scriptId":"43","url":"internal/modules/cjs/loader.js","lineNumber":944,"columnNumber":29},{"functionName":"Module._extensions..js","scriptId":"43","url":"internal/modules/cjs/loader.js","lineNumber":961,"columnNumber":9},{"functionName":"Module.load","scriptId":"43","url":"internal/modules/cjs/loader.js","lineNumber":797,"columnNumber":31},{"functionName":"Module._load","scriptId":"43","url":"internal/modules/cjs/loader.js","lineNumber":710,"columnNumber":11},{"functionName":"Module.runMain","scriptId":"43","url":"internal/modules/cjs/loader.js","lineNumber":1013,"columnNumber":9},{"functionName":"","scriptId":"39","url":"internal/main/run_main_module.js","lineNumber":16,"columnNumber":10}]}}}
{"method":"Runtime.consoleAPICalled","params":{"type":"log","args":[{"type":"string","value":"group name"},{"type":"object","className":"Object","description":"Object","objectId":"{\"injectedScriptId\":1,\"id\":2}","preview":{"type":"object","description":"Object","overflow":false,"properties":[{"name":"foo","type":"boolean","value":"true"}]}}],"executionContextId":1,"timestamp":1582746620974.757,"stackTrace":{"callFrames":[{"functionName":"group","scriptId":"25","url":"internal/console/constructor.js","lineNumber":385,"columnNumber":11},{"functionName":"","scriptId":"97","url":"file:///Users/copeet/Github/vscode-pwa/demos/node/main.js","lineNumber":1,"columnNumber":8},{"functionName":"Module._compile","scriptId":"43","url":"internal/modules/cjs/loader.js","lineNumber":944,"columnNumber":29},{"functionName":"Module._extensions..js","scriptId":"43","url":"internal/modules/cjs/loader.js","lineNumber":961,"columnNumber":9},{"functionName":"Module.load","scriptId":"43","url":"internal/modules/cjs/loader.js","lineNumber":797,"columnNumber":31},{"functionName":"Module._load","scriptId":"43","url":"internal/modules/cjs/loader.js","lineNumber":710,"columnNumber":11},{"functionName":"Module.runMain","scriptId":"43","url":"internal/modules/cjs/loader.js","lineNumber":1013,"columnNumber":9},{"functionName":"","scriptId":"39","url":"internal/main/run_main_module.js","lineNumber":16,"columnNumber":10}]}}}
```
### Additional information
For now I can look for this behavior inside our debugger and ignore logs that come from the 'group' function in that file, though this is rather delicate. It'd be nice to have it resolved 🙂
Ref: https://github.com/microsoft/vscode/issues/91095 | console,inspector | low | Critical |
571,681,788 | vscode | Windows: Code opening cli.js when run as Administrator | - VSCode Version: 1.42.1
- OS Version: Windows_NT x64 10.0.18363
Steps to Reproduce:
1. Open pwsh in windows terminal
2. Go to any folder
3. Run `code .` in the folder
Does this issue occur when all extensions are disabled?: Yes
Troubleshooting steps:
Uninstalled and Reinstalled VSCode. <= This actually fixed the issue on another computer, but not my main work computer.
Followed any other steps in #69373, #88432, #89088
The reason you don't see the wait in the terminal for the first 3 `code .` commands is because there was already a vscode window open, however, the cli.js was still opening in these instances. The terminal wait logging came back after closing all vscode instances.
Nobody else got you the command line for the process, so here it is with some privacy censors. Some of the processes had really, really log command line args so I couldn't get them all to fit in my Task Manager window....
 | bug,help wanted,windows,workbench-os-integration | high | Critical |
571,728,901 | pytorch | [jit] Returning different types with `Any` segfaults | We should have a better error message here.
```python
@torch.jit.script
def x(a):
# type: (Any) -> Any
if isinstance(a, int):
return a
else:
return 'b'
# printing the graph segfaults
print(x.graph)
```
cc @suo | oncall: jit,triaged | low | Critical |
571,750,264 | rust | Type Inferencing of Type Parameters with Associated Types Is Incorrect | Rust fails to properly infer types when there is a type parameter that implements are trait that contains associated types that have relationships between each other.
Suppose there are two structs `Wrapper1` and `Wrapper2` that each hold a type `I1` and `I2` respectively.
We want to express the relationship that `I2 : Deref<Target = I1>`
So there's a 2 ways to do this:
1. define `Wrapper1` and `Wrapper2` with 2 types, `T1` and `T2` where `T2 : Deref<Target = T1>`
e.g.
https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=5c8869c7499b8cf628695b8b8a66ad40
2. define a type `WT` where `WT` has types `Inner1` and `Inner2` such that `Inner2 : Deref<Target = Self::Inner1>`.
e.g.
https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=892489013b67f5f8ef5de1e60dcdb1ef
However, in the second case, the compiler cannot infer types correctly for code to use the properties of the associated types `Inner2 : Deref<Target = Self::Inner1>`.
In the above code examples, `foo2` does not compile in 2.
It looks like the compiler is unable to infer the types correctly and apply the Deref, since for `foo1`, where we explicitly indicate the type, it compiles properly.
This ends up causing the Deref traits to not be always inferred properly by other users too. | A-associated-items,T-compiler,A-inference,C-bug | low | Critical |
571,780,960 | flutter | [web]: Support for backend proxy | On the _traditional_ web frameworks such as Angular, React, and Vue, they tend to provide a way to automatically proxy requests to the backend. For instance, [in Angular](https://github.com/angular/angular-cli/blob/master/docs/documentation/stories/proxy.md), simply providing a `proxy.conf.json` does the trick. All 3 seem to achieve this using an express server with a [proxy middleware](https://github.com/chimurai/http-proxy-middleware).
As of the moment, the flutter docs seem to hint that the only way is to [allow CORS on the server-side](https://flutter.dev/docs/development/platform-integration/web#implementing-cors). While this is doable, it still is not as pretty as it requires you to put a CORS-during-dev condition on the server.
Is this feature on the roadmap for the stable release?
```
$ flutter --version
Flutter 1.14.6 • channel beta • https://github.com/flutter/flutter
Framework • revision fabeb2a16f (4 weeks ago) • 2020-01-28 07:56:51 -0800
Engine • revision c4229bfbba
Tools • Dart 2.8.0 (build 2.8.0-dev.5.0 fc3af737c7)
```
---
P.S.: I'm also interested in contributing to flutter, so if the team sees this fit to be prioritized, please guide me accordingly! | c: new feature,tool,platform-web,P3,team-web,triaged-web | medium | Critical |
571,794,127 | TypeScript | Ability to decorate abstract member function | <!-- 🚨 STOP 🚨 𝗦𝗧𝗢𝗣 🚨 𝑺𝑻𝑶𝑷 🚨
Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker.
Please help us by doing the following steps before logging an issue:
* Search: https://github.com/Microsoft/TypeScript/search?type=Issues
* Read the FAQ, especially the "Common Feature Requests" section: https://github.com/Microsoft/TypeScript/wiki/FAQ
-->
## Search Terms
I search "decorate abstract member" in the issues list, and #20887 has memtioned this issue but closed.
## Suggestion
<!-- A summary of what you'd like to see added or changed -->
Ability to decorate abstract function and its params.
## Use Cases
To implement a [retrofit](https://square.github.io/retrofit/)-like http request library with Typescript. Examples from retrofit website:
```java
public interface GitHubService {
@GET("users/{user}/repos")
Call<List<Repo>> listRepos(@Path("user") String user);
}
```
When translate it into Typescript, we need to decorate an abstract class since interface will be erased after compilation. But,
```typescript
@MyAPI() // Okay, abstract class is decoratable
abstract class GitHubService {
@GET("users/{user}/repos") // ERROR: Cannot decorate an abstract class member
abstract Call<List<Repo>> listRepos(@Path("user") user: string); // ERROR
}
```
<!--
What do you want to use this for?
What shortcomings exist with current approaches?
-->
To workaround such limitation, we cannot use abstract class, so it turns out to be
```typescript
@MyAPI() // Okay, abstract class is decoratable
class GitHubService {
@GET("users/{user}/repos")
Call<List<Repo>> listRepos(@Path("user") user: user) {
throw new Error('unimplemented');
}
}
```
This is obviousely not elegant.
I think such ability can be implemented without breaks existing valid code.
Decorator function can determin wheter it's decorating an abstract member by check if value of property descriptor is undefined.
```typescript
function ClassMemberDecorator(prototype: {}, name: string, pd: PropertyDescriptor) {
if (typeof pd.value === 'undefined') { // we're decorating abstract member
}
}
function ClassMemberParamDecorator(prototype: {}, name: string, index: number) {
if (typeof prototype[name] === 'undefiend') { // we're decorating abstract member param
}
}
```
Since when targetting ES3, `PropertyDescriptor.value` is always undefined, this feature shall only be supported when targetting ES5-onward.
## Checklist
My suggestion meets these guidelines:
* [x] This wouldn't be a breaking change in existing TypeScript/JavaScript code
* [x] This wouldn't change the runtime behavior of existing JavaScript code
* [x] This could be implemented without emitting different JS based on the types of the expressions
* [x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
* [x] This feature would agree with the rest of [TypeScript's Design Goals](https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals).
| Suggestion,Awaiting More Feedback | medium | Critical |
571,803,438 | pytorch | Unclear output for Pytorch Profiler | ## 📚 Documentation on PyTorch Profiler
<!-- A clear and concise description of what content in https://pytorch.org/docs is an issue. If this has to do with the general https://pytorch.org website, please file an issue at https://github.com/pytorch/pytorch.github.io/issues/new/choose instead. If this has to do with https://pytorch.org/tutorials, please file an issue at https://github.com/pytorch/tutorials/issues/new -->
I don't fully understand the output of [PyTorch Profiler](https://pytorch.org/docs/stable/autograd.html#torch.autograd.profiler.profile) after using `torch.autograd.profiler` (combined with `torch.autograd.profiler.record_function` for labeling). To be specifically, the output of `prof.key_averages().table(sort_by="cuda_time_total")` gets the following table:
| Name | Self CPU total % | Self CPU total | CPU total % | CPU total | CPU time avg | CUDA total % | CUDA total | CUDA time avg | Number of Calls |
| ---- | ---------------- | -------------- | ----------- | --------- | ------------ | ------------ | ---------- | ------------- | --------------- |
| | | | | | | | | | |
It seems the document doesn't explain much for the clear meanings of each item. To be concretely, I will very appreciate if the document can provide answers to the following questions:
1. What's the meaning and the difference of `Self CPU total` and `CPU total`
2. Is the `CUDA total` purely the execution time for the cuda code? Or it also includes time of kernel launching, kernel queueing in GPU?
3. How can I understand the `CPU total` for operations which are executed on GPU, e.g., model forwarding and backwarding. Since these operations are done in GPU, but I still find even unneglectable time cost spent by CPU.
cc @ezyang @SsnL @albanD @zou3519 @gqchen | module: docs,module: autograd,triaged | low | Major |
571,834,243 | pytorch | Possibility to support int4 data type | There are two motivations. First, the low precision inference is becoming popular, int4 could make full advantage of latest NV GPUs. Second, we are doing some quantum simulation stuff based on PyTorch, int4 based on NV GPUs will significantly improve the simulation speed in our framework. | feature,triaged | low | Minor |
571,849,277 | node | Performance of for await of (async iteration) | I hope this is the right place to ask the question and that this hasn't already been discussed to death elsewhere. Feel free to direct me elsewhere or close the issue if I've missed something.
In short, I am one of the maintainers of exceljs (which is basically a transfrom stream taking in a read stream, unzipping its contents, running an xml parser on the unzipped chunks and then emitting back excel-related events) and we're in the process of adding support for async iteration via for await of (https://github.com/exceljs/exceljs/pull/1135).
In doing that, we've noticed that for await of is significantly slower than the current `.on('data',..)` based approach. Our benchmark is not a microbenchmark, but a full end-to-end benchmark incl. creating and analyzing excel objects in memory (https://github.com/exceljs/exceljs/pull/1139). Switching to for await of (vs. handling the events in sync callbacks) decreased performance by around 60%.
I have debugged this issue (https://github.com/lddubeau/saxes/issues/32) and in short, the issue arises because for every chunk/event passed into our transform stream, we emit out a magnitude greater of chunks/events. And so what's causing the performance is that the callback code would run through these emitted chunks/events mostly synchronously, whereas the current implementation of `Symbol.asyncIterator` on `Readable` calls `setImmediate` between each event, which is quite expensive. I wrote a simple microbenchmark to compare for of against for await of on the same array or iterator, and the difference is around 10x.
So we've come up with this 'hack' where instead of emitting one-by-one all of these chunks/events that our transform produces, we now gather them up in an array and emit that once. Or phrased another way, instead of calling `this.push()` for every excel related event that we produce, we call, for each chunk written into our stream, a lot of `this.events.push()` (where `this.events` is just an array that initialized in the constructor) and then finally `this.push(this.events)` once we're done consuming the chunk (and we also reset `this.events` to an empty array again). Clever, but now consuming the stream is ugly. Instead of writing `` we now write
```js
// We'd like to write this, but it's slow
for await (const chunk of readable) { ... }
// This is within 2% of the runtime of the callback based approach, but not very ergonomic
for await (const chunks of readable) {
for (const chunk of chunks) { ... }
}
```
I think this performance issue will bite a lot people because it's so easy to fall into and, at least to me, came as a surprise. I remember reading that `readline` has similar performance issues (and similarly to the above it produces a lot more events than it takes in) and would probably also see performance improvements from the above approach.
My question boils down to this: Is there a fundamental reason in the spec around async iteration or streams that we have to go to setImmediate if the read buffer still has stuff in it (i.e., if we could call `.next()` synchronously? Is it something that v8 can/will eventually optimize? If no to both questions, what should library authors do to give users all the advantages of async iteration while not sacrificing performance?
Roping in @BridgeAR as a fellow performance nerd and the only one I know here ;) | question,stream,performance | high | Critical |
571,931,596 | rust | -Ctarget-cpu=skylake trashes ends_with_str performance | I was running these benchmarks:
```rust
#![feature(test)]
extern crate test;
use crate::test::black_box;
use crate::test::Bencher;
fn main() {
println!("Hello, world!");
}
#[bench]
fn starts_with_char(b: &mut Bencher) {
let text = black_box("kdjsfhlakfhlsghlkvcnljknfqiunvcijqenwodind");
b.iter(|| {
for _ in 0..1024 {
black_box(text.starts_with('k'));
}
})
}
#[bench]
fn starts_with_str(b: &mut Bencher) {
let text = black_box("kdjsfhlakfhlsghlkvcnljknfqiunvcijqenwodind");
b.iter(|| {
for _ in 0..1024 {
black_box(text.starts_with("k"));
}
})
}
#[bench]
fn ends_with_char(b: &mut Bencher) {
let text = black_box("kdjsfhlakfhlsghlkvcnljknfqiunvcijqenwodind");
b.iter(|| {
for _ in 0..1024 {
black_box(text.ends_with('k'));
}
})
}
#[bench]
fn ends_with_str(b: &mut Bencher) {
let text = black_box("kdjsfhlakfhlsghlkvcnljknfqiunvcijqenwodind");
b.iter(|| {
for _ in 0..1024 {
black_box(text.ends_with("k"));
}
})
}
```
It turned out that I got a major performance drop with `-Ctarget-cpu=native` (`-Ctarget-cpu=skylake` in my case).
`RUSTFLAGS="-Ctarget-cpu=skylake" cargo bench`
````
running 4 tests
test ends_with_char ... bench: 692 ns/iter (+/- 38)
test ends_with_str ... bench: 1,033 ns/iter (+/- 23)
test starts_with_char ... bench: 356 ns/iter (+/- 44)
test starts_with_str ... bench: 362 ns/iter (+/- 410)
````
`RUSTFLAGS="" cargo bench`
````
running 4 tests
test ends_with_char ... bench: 468 ns/iter (+/- 21)
test ends_with_str ... bench: 539 ns/iter (+/- 40)
test starts_with_char ... bench: 356 ns/iter (+/- 12)
test starts_with_str ... bench: 693 ns/iter (+/- 44)
````
By generating code "optimized" for my machine, perf dropped from 539 ns/iter to 1,033 ns/iter for `ends_with_str` :(
### Meta
cpu info:
```
processor : 3
vendor_id : GenuineIntel
cpu family : 6
model : 142
model name : Intel(R) Core(TM) i5-7200U CPU @ 2.50GHz
stepping : 9
microcode : 0xca
cpu MHz : 591.388
cache size : 3072 KB
physical id : 0
siblings : 4
core id : 1
cpu cores : 2
apicid : 3
initial apicid : 3
fpu : yes
fpu_exception : yes
cpuid level : 22
wp : yes
flags : fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush dts acpi mmx fxsr sse sse2 ss ht tm pbe syscall nx pdpe1gb rdtscp lm constant_tsc art arch_perfmon pebs bts rep_good nopl xtopology nonstop_tsc cpuid aperfmperf pni pclmulqdq dtes64 monitor ds_cpl vmx est tm2 ssse3 sdbg fma cx16 xtpr pdcm pcid sse4_1 sse4_2 x2apic movbe popcnt tsc_deadline_timer aes xsave avx f16c rdrand lahf_lm abm 3dnowprefetch cpuid_fault epb invpcid_single pti ssbd ibrs ibpb stibp tpr_shadow vnmi flexpriority ept vpid ept_ad fsgsbase tsc_adjust bmi1 avx2 smep bmi2 erms invpcid mpx rdseed adx smap clflushopt intel_pt xsaveopt xsavec xgetbv1 xsaves dtherm ida arat pln pts hwp hwp_notify hwp_act_window hwp_epp md_clear flush_l1d
bugs : cpu_meltdown spectre_v1 spectre_v2 spec_store_bypass l1tf mds swapgs itlb_multihit
bogomips : 5401.81
clflush size : 64
cache_alignment : 64
address sizes : 39 bits physical, 48 bits virtual
power management:
```
`rustc --version --verbose`:
```
rustc 1.43.0-nightly (abc3073c9 2020-02-26)
binary: rustc
commit-hash: abc3073c92df034636a823c5382ece2186d22b9e
commit-date: 2020-02-26
host: x86_64-unknown-linux-gnu
release: 1.43.0-nightly
LLVM version: 9.0
```
| A-LLVM,I-slow,T-compiler,C-bug,A-target-feature | low | Critical |
572,069,581 | pytorch | Memory leak in embedding layer and LSTM | ## 🐛 Bug
Memory leaks when forwarding embedding layer and LSTM.
## To Reproduce
Run this code,
The memory usage doesn't increase every iteration, but it increases over time.
```
import os, torch, gc
length=100
vocab_size = 50
hidden_size=512
vocab_id = 10 # randomly chosen between 0-49
text_lengths = [length]
enc_input = torch.LongTensor([vocab_id for _ in range(length)]).view(1, -1)
embedding = torch.nn.Embedding(vocab_size, hidden_size)
LSTM = torch.nn.LSTM(input_size=hidden_size, hidden_size=hidden_size // 2, num_layers=1, batch_first=True, bidirectional=True)
pid = os.getpid()
count = 0
prev_mem = 0
with torch.no_grad():
while True:
output = embedding(enc_input)
output = torch.nn.utils.rnn.pack_padded_sequence(output, text_lengths, True, enforce_sorted=False)
output, _ = LSTM(output)
output, _ = torch.nn.utils.rnn.pad_packed_sequence(output, True) # NxTx2H
if count % 500 == 0:
gc.collect()
cur_mem = (int(open('/proc/%s/statm' % pid, 'r').read().split()[1]) + 0.0) / 256
add_mem = cur_mem - prev_mem
prev_mem = cur_mem
print(" train iterations: %s, added mem: %sM, curr mem: %sM" % (count, add_mem, cur_mem))
count += 1
```
Output of the code:
```
train iterations: 0, added mem: 183.74609375M, curr mem: 183.74609375M
train iterations: 500, added mem: 9.54296875M, curr mem: 193.2890625M
train iterations: 1000, added mem: 0.48828125M, curr mem: 193.77734375M
train iterations: 1500, added mem: 3.265625M, curr mem: 197.04296875M
train iterations: 2000, added mem: 0.3984375M, curr mem: 197.44140625M
train iterations: 2500, added mem: 0.98046875M, curr mem: 198.421875M
train iterations: 3000, added mem: 2.7890625M, curr mem: 201.2109375M
train iterations: 3500, added mem: 0.078125M, curr mem: 201.2890625M
train iterations: 4000, added mem: 0.9140625M, curr mem: 202.203125M
train iterations: 4500, added mem: 0.49609375M, curr mem: 202.69921875M
train iterations: 5000, added mem: 0.7890625M, curr mem: 203.48828125M
```
## Expected behavior
Memory usage should not be increased.
## Environment
- PyTorch Version (e.g., 1.0): 1.4.0
- OS (e.g., Linux): 16.04.5 LTS
- How you installed PyTorch (`conda`, `pip`, source): conda
- Build command you used (if compiling from source):
- Python version: 3.6.8
- CUDA/cuDNN version: not used
- GPU models and configuration: not used
- Any other relevant information:
| module: memory usage,triaged | low | Critical |
572,106,159 | go | runtime: "found bad pointer in Go heap" on solaris-amd64-oraclerel builder | [2020-02-26T23:27:55-12cd55c/solaris-amd64-oraclerel](https://build.golang.org/log/8947081013c049c51c44c087e33b8a7fdeaed2b5)
```
##### ../doc/codewalk
runtime: pointer 0xc00033c002 to unallocated span span.base()=0xc00033c000 span.limit=0xc00033dee0 span.state=0
runtime: found in object at *(0xc000230000+0x0)
object=0xc000230000 s.base()=0xc000230000 s.limit=0xc000232000 s.spanclass=10 s.elemsize=64 s.state=mSpanInUse
*(object+0) = 0xc00033c002 <==
*(object+8) = 0x9
*(object+16) = 0xc00033c00e
*(object+24) = 0x10
*(object+32) = 0xc00033c021
*(object+40) = 0xb
*(object+48) = 0xc00033c02f
*(object+56) = 0xc
fatal error: found bad pointer in Go heap (incorrect use of unsafe or cgo?)
```
The `doc/codewalk` test is pretty simple (no `unsafe` or cgo and only a little concurrency), so I suspect this is a runtime or platform bug.
Compare #35541, #32324, #28054.
CC @mknyszek, @cherrymui @aclements | OS-Solaris,NeedsInvestigation,compiler/runtime | low | Critical |
572,138,517 | neovim | shada write error does not show up necessarily / should re-use temp files | I've noticed that Neovim stopped writing the ShaDa file, and when running `:wshada` it showed:
> E138: All /home/user/.local/share/nvim/shada/main.shada.tmp.X files exist, cannot write ShaDa file!
The error message is a bit confusing, and does not show up with `:h E138` (https://github.com/neovim/neovim/commit/492f2cfeff9a8ed295d2cbf3f4197a91654e07ca?#commitcomment-37510589), but looking at the file system showed this:
```
-rw------- 1 user user 1.5K Jul 20 2017 /home/user/.local/share/nvim/shada/main.shada.tmp.a
…
-rw------- 1 user user 0 Feb 25 18:58 /home/user/.local/share/nvim/shada/main.shada.tmp.z
```
I.e. tempfiles with `[a-z]` in the end do exist already.
1. I think Neovim should clean out old tempfiles here automatically, i.e. start again using `a` if `z` is used already - especially when they are that old already.
2. There should be an error about this during shutdown always.
I see it with `nvim -u NONE` on `:q`, but with `nvim -u NORC` it only flashes up, but does not wait for ENTER. So some default plugin appears to make a difference there.
(With my config it is not visible at all, but that might be due to lazyredraw or similar)
NVIM v0.5.0-398-g78ec95ce7-dirty
| bug,editor-state | low | Critical |
572,140,975 | opencv | OpenCV and Flutter | I've seen there is OpenCV support for Android and iOS. Are there any plans to support Flutter as development platform as well? If not, is it possible to use the OpenCV libraries in Flutter for both, Android and iOS? | feature,priority: low,platform: other | low | Major |
572,153,862 | pytorch | cuDNN batchnorm with non-contiguous running mean silently discards updates | ```
if (use_cudnn && eps >= detail::getCUDAHooks().batchnormMinEpsilonCuDNN()) {
return std::tuple_cat(
at::cudnn_batch_norm(
input.contiguous(input.suggest_memory_format()), weight.contiguous(),
bias.contiguous(),
running_mean.defined() ? running_mean.contiguous() : running_mean,
running_var.defined() ? running_var.contiguous() : running_var,
training, momentum, eps),
std::make_tuple(1));
}
```
This looks highly suspect. If running mean/var are not contiguous, then we will allocate a new tensor to make the contiguous, and thereby end up losing updates to the running mean/var entirely.
Discovered while looking into #13402
cc @csarofeen @ptrblck | module: cudnn,triaged | low | Major |
572,158,790 | PowerToys | [PowerRename] Bulk regex rename needs to include folders | I read that this utility would allow renaming multiple files with regular expressions. There was a checkbox to exclude folders, so I thought if I unchecked that it would _include_ folders. Apparently my expectation of "include folders" doesn't match how the utility works.
I have a lot of files in the form:
* `2019\02\05\foo.html`
* `2020\04\03\bar.html`
I want to rename them to the form:
* `@2019-02-05-foo.html`
* `@2020-04-03-bar.html`
I figured I would match some regex `(\d\d\d\d)\\(\d\d)\\(\d\d)\\(.+)\.html` and rename that to `@$1-$2-$3-$4.html`. It seemed straightforward to me. Looks like the utility can't handle it, though; apparently it only looks at the filename.
You might make this shortcoming explicit in the documentation. | Idea-Enhancement,Help Wanted,Product-PowerRename | low | Major |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.