id
int64 393k
2.82B
| repo
stringclasses 68
values | title
stringlengths 1
936
| body
stringlengths 0
256k
β | labels
stringlengths 2
508
| priority
stringclasses 3
values | severity
stringclasses 3
values |
|---|---|---|---|---|---|---|
567,711,855 | angular | `animateChild` invoke disabled child animation in group |
# π bug report
### Affected Package
The issue is caused by package `@angular/animations`
### Is this a regression?
I don't know
### Description
I have group animations. Child animation is disabled on small screen, but child animation is called by `animateChild` despite being disabled.
```
trigger('parentAnimation', [
state('in', style({opacity: 1})),
transition(':enter', group([
query('.main', [style({opacity: 0}), animate('2s ease')]),
query('@*', animateChild())
])),
...
```
```
<div @parentAnimation *ngIf="display">
<p class="main">Should animate</p>
<p @childAnimation [@.disabled]="true">
Shouldn't animates
</p>
</div>
```
## π¬ Minimal Reproduction
https://stackblitz.com/edit/animate-child
In Chrome and FF two animations are showing.
In Safari no animations.
## π Your Environment
**Angular Version:**
<pre><code>
Angular CLI: 8.3.20
Node: 12.10.0
OS: darwin x64
Angular: 8.2.14
... animations, common, compiler, compiler-cli, core, forms
... platform-browser, platform-browser-dynamic, router, upgrade
Package Version
-----------------------------------------------------------
@angular-devkit/architect 0.803.20
@angular-devkit/build-angular 0.803.20
@angular-devkit/build-optimizer 0.803.20
@angular-devkit/build-webpack 0.803.20
@angular-devkit/core 8.3.8
@angular-devkit/schematics 8.3.20
@angular/cdk 8.2.3
@angular/cli 8.3.20
@ngtools/webpack 8.3.8
@schematics/angular 8.3.20
@schematics/update 0.803.20
rxjs 6.5.3
typescript 3.5.3
webpack 4.41.2
</code></pre> | type: bug/fix,area: animations,freq2: medium,state: confirmed,P3 | low | Critical |
567,740,107 | go | cmd/go: go list should not allow an empty "" argument | <!-- Please answer these questions before submitting your issue. Thanks! -->
### What version of Go are you using (`go version`)?
<pre>
$ go version
go version go1.14rc1 linux/amd64
</pre>
### Does this issue reproduce with the latest release?
Yes.
### What operating system and processor architecture are you using (`go env`)?
<details><summary><code>go env</code> Output</summary><br><pre>
$ go env
GO111MODULE="on"
GOARCH="amd64"
GOBIN="/home/manlio/.local/bin"
GOCACHE="/home/manlio/.cache/go-build"
GOENV="/home/manlio/.config/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/home/manlio/.local/lib/go:/home/manlio/src/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/home/manlio/sdk/go1.14rc1"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/home/manlio/sdk/go1.14rc1/pkg/tool/linux_amd64"
GCCGO="gccgo"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="/dev/null"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build552987847=/tmp/go-build -gno-record-gcc-switches"
GOROOT/bin/go version: go version go1.14rc1 linux/amd64
GOROOT/bin/go tool compile -V: compile version go1.14rc1
uname -sr: Linux 5.5.4-arch1-1
/usr/lib/libc.so.6: GNU C Library (GNU libc) stable release version 2.31.
gdb --version: GNU gdb (GDB) 9.1
</pre></details>
### What did you do?
Inside a module `github.com/perillo/goprint`:
```
$ go list -m ""
```
### What did you expect to see?
```
github.com/perillo/goprint
```
### What did you see instead?
```
go list -m: module : not a known dependency
```
`go list ""` works fine. Is there a reason for this asymmetry?
If an empty module path **must** be rejected, the error message should be changed.
Thanks. | NeedsFix | low | Critical |
567,744,578 | pytorch | When a Node fails to resolve to an Operator, print out the types of arguments, and all "close matches" in known operators | Related to #33500
Sometimes, malformed nodes can show up in your IR. The most common situation this occurs is when you've written out IR by hand, as is done in some alias analysis and dce tests. When this happens, you get an assert like:
```
RuntimeError: hasSpecialCase INTERNAL ASSERT FAILED at ../torch/csrc/jit/passes/alias_analysis.cpp:311, please report a bug to PyTorch. We don't have an op for aten::ones but it isn't a special case. (analyzeImpl at ../torch/csrc/jit/passes/alias_analysis.cpp:311)
```
Asserts like this can be made dramatically more useful by reporting:
* The types of the arguments
* The list of "close miss" declarations which might have matched, but didn't match for some reason
Assuming there are no bugs in the subsumption check, this would make it instantly clear what the problem is.
cc @suo | oncall: jit,triaged | low | Critical |
567,764,018 | TypeScript | Symbol type is incorrectly generalized when used as a property value of an object literal | **TypeScript Version:** 3.7.5
**Search Terms:** symbol infer type
**Expected behavior:**
Symbol `const uniqueSymbol = Symbol()` when used as property value in an object literal is inferred as unique type `typeof uniqueSymbol`.
**Actual behavior:**
Symbol `const uniqueSymbol = Symbol()` when used as property value in an object literal is inferred as general type `symbol`.
**Related Issues:**
**Code**
```ts
const uniqueSymbol = Symbol()
// Example of incorrect inference (unique symbol is generalized to type `symbol`)
const foo = {
prop: uniqueSymbol,
}
type Foo = typeof foo // { prop: symbol }
// Workarounds for incorrect behavior
const bar = {
prop: uniqueSymbol as typeof uniqueSymbol,
}
type Bar = typeof bar // { prop: typeof uniqueSymbol }
const genericFactory = <T>(value: T) => ({ prop: value })
const baz = genericFactory(uniqueSymbol)
type Baz = typeof baz // { prop: typeof uniqueSymbol }
```
<details><summary><b>Output</b></summary>
```ts
"use strict";
const uniqueSymbol = Symbol();
// Example of incorrect inference (unique symbol is generalized to type `symbol`)
const foo = {
prop: uniqueSymbol,
};
// Workarounds for incorrect behavior
const bar = {
prop: uniqueSymbol,
};
const genericFactory = (value) => ({ prop: value });
const baz = genericFactory(uniqueSymbol);
```
</details>
<details><summary><b>Compiler Options</b></summary>
```json
{
"compilerOptions": {
"noImplicitAny": true,
"strictNullChecks": true,
"strictFunctionTypes": true,
"strictPropertyInitialization": true,
"strictBindCallApply": true,
"noImplicitThis": true,
"noImplicitReturns": true,
"useDefineForClassFields": false,
"alwaysStrict": true,
"allowUnreachableCode": false,
"allowUnusedLabels": false,
"downlevelIteration": false,
"noEmitHelpers": false,
"noLib": false,
"noStrictGenericChecks": false,
"noUnusedLocals": false,
"noUnusedParameters": false,
"esModuleInterop": true,
"preserveConstEnums": false,
"removeComments": false,
"skipLibCheck": false,
"checkJs": false,
"allowJs": false,
"declaration": true,
"experimentalDecorators": false,
"emitDecoratorMetadata": false,
"target": "ES2017",
"module": "ESNext"
}
}
```
</details>
**Playground Link:** [Provided](https://www.typescriptlang.org/play/?ssl=1&ssc=1&pln=24&pc=1#code/MYewdgzgLgBArmAlgRzgUwMoE8C2AjEAGxgF4Zt8iAKASgCg6B6RmAUQA8BDHAB0LRggAZjERhQAJwlpgsMULTTxAqghToYEXAWKIIMAOZowizoUQAvNABMYUEHaw8BAAy2VCL+nVCRYQkAcyAG86GBgeCRAeAC54JFRMbSIAGjoAXwYoJwEAMUDSR2dhGACHGGYYYIio2M1k4kymFgB1EAkAa04ohGt9AIlRcXbpWRg8NAALTgA3RHaGX2hx7sLQ8MjouLVEih0YTn1s4pEd9D3UjKycmAAhVbJjtBK8VcrqzbqnkrOkjxgmktYEYTBJEMBcpxZO0sIUADwAFQAfFQZmZ0HEETRSEiYFQPrU4mjCBp0t4gSsLIUQYpwZDoRIsKoEucGt4nndOFTHjkXlyKiwCVsis9Tiy-vtMkA)
| Needs Investigation | low | Major |
567,773,019 | react-native | [TM][C++] Improve C++ TurboModule system | # Context
The C++ TurboModule system, unlike the ObjC and Java systems, is fairly immature. It has a lot of problems that need to be addressed, and gaps that need to be filled. Unfortunately, at Facebook, we only have a handful of C++ NativeModules. Additionally, there's no urgency to convert these NativeModules to C++-only TurboModules, because these NativeModules are already going through a bridging layer in the TurboModule system (i.e: we could turn off the old NativeModule system and still have these NativeModules fully functional). Therefore, it's difficult to prioritize development of the C++ TurboModule system internally.
For transparency, this is my focus in H1 2020:
- Open source and internal iOS NativeModule migration.
- Internal rollout of the TurboModule system (on both iOS and Android).
- The effort to make TurboModules and Codegen open source ready.
With all the things on my plate this half, I find it unlikely that the C++ TurboModule system will be finished any time soon. So, this GitHub issue documents the work that's required to build out the C++ TurboModule system. If anyone is interested in taking ownership over this portion of the TurboModule project, please feel free to comment below. I'd love to work together and see this completed. π
## Problem
This is currently the interface of our C++-only TurboModules:
```C++
class SampleTurboCxxModule : public NativeSampleTurboCxxModuleSpecJSI {
public:
SampleTurboCxxModule(std::shared_ptr<CallInvoker> jsInvoker);
void voidFunc(jsi::Runtime &rt) override;
bool getBool(jsi::Runtime &rt, bool arg) override;
double getNumber(jsi::Runtime &rt, double arg) override;
jsi::String getString(jsi::Runtime &rt, const jsi::String &arg) override;
jsi::Array getArray(jsi::Runtime &rt, const jsi::Array &arg) override;
jsi::Object getObject(jsi::Runtime &rt, const jsi::Object &arg) override;
jsi::Object getValue(
jsi::Runtime &rt,
double x,
const jsi::String &y,
const jsi::Object &z) override;
void getValueWithCallback(jsi::Runtime &rt, const jsi::Function &callback)
override;
jsi::Value getValueWithPromise(jsi::Runtime &rt, bool error) override;
jsi::Object getConstants(jsi::Runtime &rt) override;
};
```
There are a few problems with this API.
1. Hermes is a "bring your own locks" VM. The application/framework using Hermes is responsible for making sure that `jsi::Runtime` is accessed safely. This simply isn't possible if we provide all C++-only TurboModules with access to the `jsi::Runtime`.
2. It's not a good idea to give C++-only TurboModules ownership of JSI objects (eg:`jsi::Function`, `jsi::String`, `jsi::Array`, `jsi::Object`). First, this isn't a very clean API. Second, by design, many of these JSI objects (`jsi::Function` especially) can't outlive the `jsi::Runtime` (see [the jsi.h](https://github.com/facebook/react-native/blob/145151ef0f44156bcc03fa4a44a5aa630cc3e5f2/ReactCommon/jsi/jsi/jsi.h#L140-L146)). So, we should had C++-only TurboModules safe wrappers around these objects, so that the TurboModule framework can manage their lifecycles.
Other things to think about:
1. How do we perform cleanup for C++-only TurboModules? Should we expect C++-only TurboModules to have a custom invalidate method, or is using their destructor fine?
2. There is no `CxxTurboModule` class, like we have `JavaTurboModule`, and `ObjCTurboModule`. If we want to make C++-only TurboModules more robust without bloating the codegen, this class would be necessary.
## How do I start?
There is currently only one pure C++ TurboModule: [`SampleTurboCxxModule`](https://github.com/facebook/react-native/blob/d4d8887b5018782eeb3f26efa85125e6bbff73e4/ReactCommon/turbomodule/samples/SampleTurboCxxModule.cpp#L1). This TurboModule extends its "code-generated" spec [`NativeSampleTurboCxxModuleSpecJSI`](https://github.com/facebook/react-native/blob/d4d8887b5018782eeb3f26efa85125e6bbff73e4/ReactCommon/turbomodule/samples/NativeSampleTurboCxxModuleSpecJSI.cpp#L1) (the spec is really just hand-written). This spec directly extends [`TurboModule`](https://github.com/facebook/react-native/blob/d4d8887b5018782eeb3f26efa85125e6bbff73e4/ReactCommon/turbomodule/core/TurboModule.h#L38-L61), as you can see [here](https://github.com/facebook/react-native/blob/d4d8887b5018782eeb3f26efa85125e6bbff73e4/ReactCommon/turbomodule/samples/NativeSampleTurboCxxModuleSpecJSI.h#L19).
1. Create a new `CxxTurboModule` class and have it extend TurboModule. Have `NativeSampleTurboCxxModuleSpecJSI` extend `CxxTurboModule`.
2. You can call into CxxTurboModule from the ["code-generated" __hostFunctions](https://github.com/facebook/react-native/blob/d4d8887b5018782eeb3f26efa85125e6bbff73e4/ReactCommon/turbomodule/samples/NativeSampleTurboCxxModuleSpecJSI.cpp#L15-L113) in `NativeSampleTurboCxxModuleSpecJSI`. Feel free to modify the contents of the __hostFunctions in the codegen. Please look at [`RCTSampleTurboModuleSpec.mm`](https://github.com/facebook/react-native/blob/d4d8887b5018782eeb3f26efa85125e6bbff73e4/ReactCommon/turbomodule/samples/platform/ios/RCTNativeSampleTurboModuleSpec.mm#L1) for an example of how we do this in iOS. Some of the responsibilities of `CxxTurboModule`:
1. Convert JS arguments (JSI objects) to vanilla C++ objects.
1. What do we convert the `Object` type to? Should we use `folly::dynamic`?
2. What do we convert object literals (eg: `{| foo: bar |}`) to? In ObjC, we convert them to structs, since we know the type of each property.
3. What do we convert `Array<T>` to? Should we just use an STL container?
2. Convert C++ returns to JSI objects.
1. How do we handle `Promise` returns?
2. Do we simply pass in the C++-only TurboModule method a `resolve` and a `reject` lambda, like in ObjC, or do we pass in a "Promise" object, like we do in Android. Alternatively, should we leverage some STL data structure (`std::promise`)?
3. Dispatch async method calls appropriately on each platform. This will require the `CxxTurboModule` constructor to accept a native `CallInvoker` that dispatches work to a background thread.
- On iOS, every C++ NativeModule calls its async methods on its own ObjC method queue.
1. MethodQueue is created here, for each NativeModule: [code](https://github.com/facebook/react-native/blob/145151ef0f44156bcc03fa4a44a5aa630cc3e5f2/React/Base/RCTModuleData.mm#L210).
2. C++ NativeModule list is created here, from `RCTModuleData` objects: [code](https://github.com/facebook/react-native/blob/145151ef0f44156bcc03fa4a44a5aa630cc3e5f2/React/CxxModule/RCTCxxUtils.mm#L25-L40).
3. `DispatchMessageQueueThread` is the class our C++ NativeModules use to dispatch to the MessageQueue. Here's the async dispatch method: [code](https://github.com/facebook/react-native/blob/145151ef0f44156bcc03fa4a44a5aa630cc3e5f2/React/CxxModule/DispatchMessageQueueThread.h#L26).
- On Android, all NativeModule async methods dispatch to the same NativeModules thread.
1. The NativeModules thread is created by the bridge here: [code](https://github.com/facebook/react-native/blob/145151ef0f44156bcc03fa4a44a5aa630cc3e5f2/ReactAndroid/src/main/jni/react/jni/CatalystInstanceImpl.cpp#L153-L154).
2. It's passed into buildNativeModuleList here: [code](https://github.com/facebook/react-native/blob/145151ef0f44156bcc03fa4a44a5aa630cc3e5f2/ReactAndroid/src/main/jni/react/jni/CatalystInstanceImpl.cpp#L173-L177).
3. And used to create CxxNativeModule (i.e: legacy Cxx Native Modules) here: [code](https://github.com/facebook/react-native/blob/145151ef0f44156bcc03fa4a44a5aa630cc3e5f2/ReactAndroid/src/main/jni/react/jni/ModuleRegistryBuilder.cpp#L57-L58).
4. Asynchronously invoke JS callbacks (ex: `jsi::Function`s) on the JS Thread. This will require the `CxxTurboModule` constructor to accept a `CallInvoker` that dispatches work to the JS thread. Also, we'll have to store all the `jsi::Function` objects passed from JS to C++ so that they can be invoked later by the JS thread. This presents an additional problem:
- When the TurboModuleManager is destroyed, ensure that all held `jsi::Function`s (i.e: JS callbacks that were passed into C++ from JS) are destroyed. In iOS and Android, we accomplish this by using `LongLivedObjectCollection`, and `CallbackWrapper`. `LongLivedObjectCollection` is cleared when the runtime is destroyed.
## How do I test?
To test your changes, in RNTester on iOS, access the TurboModule in JS via `TurboModuleRegistry.get('SampleTurboCxxModule')`. | Help Wanted :octocat:,RN Team | medium | Critical |
567,829,383 | pytorch | Make setter non-optional, e.g., TensorOptions::device(optional<Device>) -> device(Device), and add a device_opt setter | Instead of
```
class TensorOptions {
TensorOptions device(optional<Device>) { ... } // setter
}
```
we should have
```
class TensorOptions {
TensorOptions device(Device) { ... } // setter
TensorOptions device_opt(optional<Device>) { ... } // setter
}
```
This makes the class more user friendly as now `x.device({kCUDA, 1})` works; it also makes it symmetric with `at::device({kCUDA, 1})`.
cc @yf225 | module: cpp,triaged | low | Minor |
567,858,917 | godot | Editor window does not snap to screen edges on 1920Γ1080 display due to editor minimum window size being more than 50% of the screen | **Godot version:** 3.2
**OS/device including version:** Linux Mint Tricia, Cinnamon desktop
This is important! Ubuntu, Unity desktop works fine.
Will test on Windows and Mint Mate later.
**Issue description:**
When dragging the editor window toward window the left, right edges, the window does not snap to occupy the left half, right half respectively (dragging to top expands as expected).
Using Meta+Left/Right/Up/Down does not snap/expand/minimize the window either.
Note that desktop and shortcut settings may affect this behavior. For instance, Cinnamon allows snapping to corners as well, but the principle is the same.
At first, I thought it came from the fact that Godot uses a custom window system (e.g. it uses modal windows / pop-ups not being considered extra windows by the OS; but I only care about the main window's behaviour here). But seeing it work on Ubuntu + Unity, I can't help thinking it's Cinnamon-specifics, so I don't even know if supporting this desktop is expected to fit in development scope.
**Steps to reproduce:**
1. Open Godot Editor (or even the Project pop-up)
2a. Drag Godot to the left or right edge of the screen
3a. Press Meta (Windows) + Left/Right/Up/Down. Alternatively Meta+Ctrl+Direction.
Expect: window snapping/expand
Actual: nothing happens | enhancement,discussion,topic:editor,confirmed | low | Major |
567,879,683 | PowerToys | light/dark mode switch based key, on time or sunset/sunrise | An option inside Power Toys that automatically switches between Windows 10's light and dark theme at a certain time of day, or at sunset and sunrise, similar to how Night Light does in Windows 10. Feature could also be configurable so that the user can choose to have the automated process switch only app theme, or both app and system theme. | Help Wanted,Idea-New PowerToy | high | Critical |
567,893,425 | go | proposal: spec: immutable data | This issue describes language feature proposal to **immutable data**.
There are more general proposals for Go 2 that postulate changes in the language type system:
[Support read-only and practical immutable values in Go](https://github.com/golang/go/issues/32245)
[Read-only and immutability](https://github.com/golang/go/issues/29192)
[Immutable type qualifier](https://github.com/golang/go/issues/27975)
This proposal isn't as general as the ones mentioned above and focuses only on the data embedded in the code as in the example below (taken from the unicode package):
```go
var _C = &RangeTable{
R16: []Range16{
{0x0000, 0x001f, 1},
{0x007f, 0x009f, 1},
{0x00ad, 0x0600, 1363},
{0x0601, 0x0605, 1},
{0x061c, 0x06dd, 193},
{0x070f, 0x08e2, 467},
{0x180e, 0x200b, 2045},
{0x200c, 0x200f, 1},
{0x202a, 0x202e, 1},
{0x2060, 0x2064, 1},
{0x2066, 0x206f, 1},
{0xd800, 0xf8ff, 1},
{0xfeff, 0xfff9, 250},
{0xfffa, 0xfffb, 1},
},
R32: []Range32{
{0x110bd, 0x110cd, 16},
{0x1bca0, 0x1bca3, 1},
{0x1d173, 0x1d17a, 1},
{0xe0001, 0xe0020, 31},
{0xe0021, 0xe007f, 1},
{0xf0000, 0xffffd, 1},
{0x100000, 0x10fffd, 1},
},
LatinOffset: 2,
}
```
### The problems this proposal tries to solve
1. If a package exports some data (explicitly or implicitly) that is intended to be immutable there is no way in the current language specification/implementation to ensure immutability or to detect that some faulty code changes the exported data.
2. In case of microcontroller based embedded systems the mutable data is copied from Flash to RAM at the system startup. In such systems there is a very little RAM because the immutable parts of the program (text and read-only data) are intended to be executed/read by the CPU directly from Flash. There is no way in the current language implementation to leave the immutable data in Flash which causes that the available RAM overflows very quickly as you import more packages.
### Language changes
This proposal doesn't require changes to the language specification. It can be implemented by adding a new compiler directive as in the example bellow:
```go
//go:immutable
var _C = &RangeTable1{
R32: []Range32{
{0x0000, 0x001f, 1},
},
}
```
_Edit:_ There is another syntax proposed that requires change in the language specification:
```go
const var _C = &RangeTable1{
R32: []Range32{
{0x0000, 0x001f, 1},
},
}
```
Unlike `const x = 2` the `const var y = 2` allows to take address of y.
### Implementation
The go:immutable directive should make the variable and any composite literals used to construct it immutable. The compiler should return an error if the data on the right hand side cannot be generated at the compile time. Immutable data should be placed in .rodata section.
The go:immutable directive can be documented as a hint directive that may or may not be implemented by the compiler, the hardware or the operating system.
An immutability violation is detected at runtime and cause the program abort. The detection relies on the operating system which usually uses read-only pages for read-only sections. In case of embedded systems the immutability violation can be detected by hardware and generate an exception.
### Design decision argumentation
Using the compiler directive instead of new keyword or an existing keyword combination like ```const var``` has the advantage that it doesn't introduce any changes to the language specification. If the more general approach for immutability will be developed the directive can be easily removed from the compiler specification.
### Tests
I've done some tests simulating the go:immutable directive at the linker level by adding the following code to the [Link.dodata](https://github.com/golang/go/blob/a7acf9af07bdc288129fa5756768b41f312d05f4/src/cmd/link/internal/ld/data.go#L1145) function:
```go
for _, s := range ctxt.Syms.Allsym {
if strings.HasPrefix(s.Name, "unicode..stmp_") {
s.Type = sym.SRODATA
}
}
```
It moves to the .rodata section all "static temp" symbols from the unicode package that correspond mainly to the composite literals used to initialize global variables. The impact on the code generated for simple *Hello, World!* program:
```go
package main
import "fmt"
func main() {
fmt.Println("Hello, World!")
}
```
is as follow:
before:
```
text data bss dec hex filename
883610 58172 11128 952910 e8a4e helloworld.elf
```
after:
```
text data bss dec hex filename
931847 9700 11128 952675 e8963 helloworld.elf
```
As you can see about 48 KB have been moved from the data segment to the text segment and they are all from unicode package only. It isn't impressive from OS capable system point of view but it's a game changer in case of microcontroller based embedded systems which rarely have more than 256 KB of RAM.
### Impact on the existing code
Introducing go:immutable directives for immutable data in the standard library and other packages shouldn't affect the correct code in any way. The faulty code can stop work.
### Additional explanation
See [additional explanation](https://github.com/golang/go/issues/37303#issuecomment-589765310) below which is also an example of using `const var` instead of `//go:immutable`. | LanguageChange,Proposal,LanguageChangeReview | high | Critical |
567,893,458 | pytorch | Reverse Cumulative Sum | ## π Feature
Add `reverse` option to `torch.cumsum`, such as in [tensorflow](https://www.tensorflow.org/api_docs/python/tf/math/cumsum)
## Motivation
This would compute right to left cumulative sum more efficiently. Currently, as far as I know, the only way to do it is
```Python
x = torch.arange(9).view(3, 3)
r2lcumsum = th.flip(th.cumsum(th.flip(x, [1]), 1), [1])
```
Result should be:
```Python
tensor([[ 3, 3, 2],
[12, 9, 5],
[21, 15, 8]])
```
## Pitch
Add `reverse` arg to native `cumsum` function
## Alternatives
## Additional context
| triaged,function request | medium | Critical |
567,932,893 | go | testing: go test JSON output reports failure if stdout redirected | <!--
Please answer these questions before submitting your issue. Thanks!
For questions please use one of our forums: https://github.com/golang/go/wiki/Questions
-->
### What version of Go are you using (`go version`)?
<pre>
$ go version
go version go1.13.4 darwin/amd64
</pre>
### Does this issue reproduce with the latest release?
It should; I don't see why it wouldn't as the code I highlighted below is in the master branch.
### What operating system and processor architecture are you using (`go env`)?
<details><summary><code>go env</code> Output</summary><br><pre>
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/jamesjohnston/Library/Caches/go-build"
GOENV="/Users/jamesjohnston/Library/Application Support/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GONOPROXY=""
GONOSUMDB=""
GOOS="darwin"
GOPATH="/Users/jamesjohnston/Thumbtack/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/Cellar/go/1.13.4/libexec"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/Cellar/go/1.13.4/libexec/pkg/tool/darwin_amd64"
GCCGO="gccgo"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS="-I/usr/local/include"
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-L/usr/local/lib"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/4_/s_mp89t54_b8xbgwclmf2scw0000gp/T/go-build586602208=/tmp/go-build -gno-record-gcc-switches -fno-common"
</pre></details>
### What did you do?
<!--
If possible, provide a recipe for reproducing the error.
A complete runnable program is good.
A link on play.golang.org is best.
-->
Create a test that overwrites os.Stdout, and then run it using `go test -json`.
https://play.golang.org/p/zeonvI5FdUJ
```
func TestWithOverride(t *testing.T) {
_, stdOutPipe, _ := os.Pipe()
os.Stdout = stdOutPipe
}
```
Then run the test using `go test -json`.
### What did you expect to see?
The test should succeed: both the exit code should be 0, and the JSON output should indicate a successful test.
### What did you see instead?
The JSON output indicates the test failed, yet the exit code is still 0, indicating success:
```
jamesjohnston-mac:testcase jamesjohnston$ go test -json
{"Time":"2020-02-19T15:27:30.928348-08:00","Action":"run","Package":"github.com/thumbtack/go/testcase","Test":"TestWithOverride"}
{"Time":"2020-02-19T15:27:30.928623-08:00","Action":"output","Package":"github.com/thumbtack/go/testcase","Test":"TestWithOverride","Output":"=== RUN TestWithOverride\n"}
{"Time":"2020-02-19T15:27:30.928661-08:00","Action":"output","Package":"github.com/thumbtack/go/testcase","Test":"TestWithOverride","Output":"--- PASS: TestWithOverride (0.00s)\n"}
{"Time":"2020-02-19T15:27:30.92872-08:00","Action":"output","Package":"github.com/thumbtack/go/testcase","Test":"TestWithOverride","Output":"ok \tgithub.com/thumbtack/go/testcase\t0.006s\n"}
{"Time":"2020-02-19T15:27:30.928732-08:00","Action":"fail","Package":"github.com/thumbtack/go/testcase","Test":"TestWithOverride","Elapsed":0.007}
jamesjohnston-mac:testcase jamesjohnston$ echo $?
0
```
Notice the failure that is reported in the JSON: `"Action":"fail"`. This is all very ambiguous: did the test pass or fail? The exit code says one thing, but the JSON output says another.
### Further investigation
Notice if we run the above play link, we get this output:
```
=== RUN TestWithOverride
--- PASS: TestWithOverride (0.00s)
All tests passed.
```
However, if we write a "normal" test that does not tamper with Stdout, we get additional output: a final "PASS": https://play.golang.org/p/3Z8hY3rAfhj
```
package main
import (
"testing"
)
func TestWithoutOverride(t *testing.T) {
// do nothing
}
```
Output:
```
=== RUN TestWithoutOverride
--- PASS: TestWithoutOverride (0.00s)
PASS
All tests passed.
```
It would appear that test2json is interpreting the lack of a final "PASS" as being a failure when converting it to JSON. However, the main "go test" command does not do similarly, and thus exits with a "successful" exit code. Therefore, we end up with a test that is both "passing" and "failing" simultaneously.
The issue appears to be that the `testing.go` file is completely written under the assumption that the end-user will never write to any of the `os.StdXYZ` variables. For example: https://github.com/golang/go/blob/c4c73ce0e3a7b5c3a61678325c61b09783f76220/src/testing/testing.go#L1211
```
fmt.Println("PASS")
```
is the code that writes the final "PASS" note.
A couple possible fixes might be:
* Update `testing.go` so that it reads the `os.StdXYZ` variables at the start of testing, and then never reads from them again. So e.g. the above code would be updated to `fmt.Fprintln(originalStdOut, "PASS")`. This protects the code from tests that tamper with the standard files.
* Update go test and/or test2json so that if a test binary outputs a truncated output due to this issue (or any other), it consistently either passes or fails the test and does not leave disagreement between JSON and exit code.
Interestingly, the issue is limited only to `-json` flag. If we run `go test` without that flag, the test will pass and no indication of anything going wrong will be given.
### Justification / backstory
This test case was derived from a test somebody wrote at my employer that was testing a command-line tool of some sort. It was temporarily replacing Stdout so that output could be captured and compared against expected output. The issue is that for one test, this person forgot to restore the original Stdout, and this was not noticed until I started working on introducing tools that work with the JSON output, like using `gotestsum` to convert JSON to JUnit XML and then passing that to Jenkins JUnit plug-in.... Jenkins was (surprisingly) reporting failed tests despite the test suite "passing."
While replacing `os.Stdout` might arguably not the best approach to testing a command-line tool, somebody did write a test that way, and in such a scenario, I feel that the test runner should exhibit predictable behavior when presented with "interesting" tests like this one. | NeedsInvestigation | low | Critical |
567,969,777 | flutter | [url_launcher] - PlatformException when launching URLs from a Flutter AAR module added to an Android app | I am currently working on a project in which a Flutter module is packaged into an AAR and imported into an Android project, which in turn will then be shipped as an Android library, abstracting Flutter to the end user. In order to achieve this, a FlutterActivity or FlutterFragment was not used and instead a custom view was created which wraps a FlutterView backed by a FlutterEngine. This allows complete flexibility to the consumers of the library without even having to know that Flutter is a dependency.
While this setup works perfectly, I am having some issues with the url_launcher library. The Flutter module makes use of this library to open URL's on Android, and while this works well within the Flutter module, once embedded into an Android app in the method described above, the following error is thrown whenever a URL is opened:
```
E/flutter: [ERROR:flutter/lib/ui/ui_dart_state.cc(157)] Unhandled Exception: PlatformException(NO_ACTIVITY, Launching a URL requires a foreground activity., null)
#0 StandardMethodCodec.decodeEnvelope (package:flutter/src/services/message_codecs.dart:569:7)
#1 MethodChannel._invokeMethod (package:flutter/src/services/platform_channel.dart:156:18)
<asynchronous suspension>
#2 MethodChannel.invokeMethod (package:flutter/src/services/platform_channel.dart:329:12)
#3 MethodChannelUrlLauncher.launch (package:url_launcher_platform_interface/method_channel_url_launcher.dart:39:21)
#4 launch (package:url_launcher/url_launcher.dart:86:58)
#5 RouteManager.start.<anonymous closure> (package:engine_native/managers/route_manager.dart:23:19)
<asynchronous suspension>
#6 _rootRunUnary (dart:async/zone.dart:1134:38)
#7 _CustomZone.runUnary (dart:async/zone.dart:1031:19)
#8 _CustomZone.runUnaryGuarded (dart:async/zone.dart:933:7)
#9 _BufferingStreamSubscription._sendData (dart:async/stream_impl.dart:339:11)
#10 _DelayedData.perform (dart:async/stream_impl.dart:594:14)
#11 _StreamImplEvents.handleNext (dart:async/stream_impl.dart:710:11)
#12 _PendingEvents.schedule.<anonymous closure> (dart:async/stream_impl.dart:670:7)
#13 _rootRun (dart:async/zone.dart:1122:38)
#14 _CustomZone.run (dart:async/zone.dart:1023:19)
#15 _CustomZone.runGuarded (dart:async/zone.dart:925:7)
#16 _CustomZone.bindCallbackGuarded.<anonymous closure> (dart:async/zone.dart:965:23)
#17 _rootRun (dart:async/zone.dart:1126:13)
#18 _CustomZone.run (dart:async/zone.dart:1023:19)
#19 _CustomZone.runGuarded (dart:async/zone.dart:925:7)
#20 _CustomZone.bindCallbackGuarded.<anonymous closure> (dart:async/zone.dart:965:23)
#21 _microtaskLoop (dart:async/schedule_microtask.dart:43:21)
#22 _startMicrotaskLoop (dart:async/schedule_microtask.dart:52:5)
```
Upon further investigation, the issue seems to be that the `UrlLauncherPlugin` relies on the `ActivityAware` class to retrieve the Activity, however for me `onAttachedToActivity` is never called. According to the documentation, the `onAttachedToActivity` in the `ActivityAware` class retrieves the activity in the following two scenarios:
> - This ActivityAware FlutterPlugin was just added to a FlutterEngine that was already connected to a running Activity.
> - This ActivityAware FlutterPlugin was already added to a FlutterEngine and that FlutterEngine was just connected to an Activity.
Given that FlutterEngine lives in a custom view that is created within an Activity, shouldn't `onAttachedToActivity` be called automatically?
Any help with this issue would be appreciated. Thanks in advance. | c: crash,platform-android,engine,a: existing-apps,P2,a: plugins,team-android,triaged-android | low | Critical |
567,985,790 | TypeScript | Not performing exhaustiveness checking for this | **TypeScript Version:** nightly
**Search Terms:**
* instanceof never TS2366
**Code**
```ts
class Parent {
bar(this: Foo): string {
if (this instanceof Foo) return "foo";
const proveIsNever: never = this;
}
}
class Foo extends Parent { }
```
**Expected behavior:**
It should type-check.
**Actual behavior:**
`TS2366: Function lacks ending return statement and return type does not include 'undefined'.`
The type of `this` after the if statement is correctly never, but TypeScript doesn't use this information and demands that I return some value.
**Playground Link:** [Playground Link](https://www.typescriptlang.org/play/index.html#code/MYGwhgzhAEAKYCcCmA7ALtA3gKGn6ARogBRoAWAlhAFzQBiA9gwJS0RoIUoDmWu+AigDNopSjC7swKYEgYjGLaMjQBXBCmgAiIUy0BufgLzAGKdtAAOCBgDckASQgA5JPYS0UbpAmgBeaHIqQwEAX2xw0EgYRWgkAA80VAATGHhkdCxoUKA)
**Related Issues:**
Not sure, I tried my best to find something and #12825 looks similar, but I'm not sure if it's the same bug. It seems like proving `this` to be never should make this type-check. | Bug | low | Critical |
568,054,994 | go | cmd/link: unexpected fault address (when low on disk space?) | I just got some mysterious linker errors. I suspect they're because this machine only has 20MB of disk free (which I just noticed).
```
# tailscale.io/control/cfgdb.test
unexpected fault address 0x7f24b561d000
fatal error: fault
[signal SIGBUS: bus error code=0x2 addr=0x7f24b561d000 pc=0x463c2e]
goroutine 1 [running]:
runtime.throw(0x6b7228, 0x5)
/home/bradfitz/go/src/runtime/panic.go:1112 +0x72 fp=0xc003df2ee8 sp=0xc003df2eb8 pc=0x432f62
runtime.sigpanic()
/home/bradfitz/go/src/runtime/signal_unix.go:674 +0x443 fp=0xc003df2f18 sp=0xc003df2ee8 pc=0x449533
runtime.memmove(0x7f24b561b6b0, 0x7f24b6c77c85, 0x22df)
/home/bradfitz/go/src/runtime/memmove_amd64.s:108 +0xbe fp=0xc003df2f20 sp=0xc003df2f18 pc=0x463c2e
cmd/link/internal/ld.(*OutBuf).Write(0xc000024900, 0x7f24b6c77c85, 0x22df, 0x22df, 0x1, 0x1, 0x0)
/home/bradfitz/go/src/cmd/link/internal/ld/outbuf.go:65 +0xa1 fp=0xc003df2f70 sp=0xc003df2f20 pc=0x5c83a1
cmd/link/internal/ld.(*OutBuf).WriteSym(0xc000024900, 0xc002807a90)
/home/bradfitz/go/src/cmd/link/internal/ld/outbuf.go:159 +0x6c fp=0xc003df2fc0 sp=0xc003df2f70 pc=0x5c8b7c
cmd/link/internal/ld.blk(0xc000024900, 0xc004dd0000, 0x18d8, 0x1c00, 0x5ca6b0, 0x31299c, 0xc0063c4b00, 0x1, 0x1)
/home/bradfitz/go/src/cmd/link/internal/ld/data.go:787 +0x10f fp=0xc003df3090 sp=0xc003df2fc0 pc=0x570d1f
cmd/link/internal/ld.CodeblkPad(0xc000001e00, 0x401000, 0x31299c, 0xc0063c4b00, 0x1, 0x1)
/home/bradfitz/go/src/cmd/link/internal/ld/data.go:701 +0xbb fp=0xc003df31a0 sp=0xc003df3090 pc=0x5703fb
cmd/link/internal/amd64.asmb(0xc000001e00)
/home/bradfitz/go/src/cmd/link/internal/amd64/asm.go:669 +0xc6 fp=0xc003df3200 sp=0xc003df31a0 pc=0x5ec9f6
cmd/link/internal/ld.Main(0x899300, 0x10, 0x20, 0x1, 0x7, 0x10, 0x6c25b5, 0x1b, 0x6be64d, 0x14, ...)
/home/bradfitz/go/src/cmd/link/internal/ld/main.go:269 +0xd61 fp=0xc003df3358 sp=0xc003df3200 pc=0x5c7451
main.main()
/home/bradfitz/go/src/cmd/link/main.go:68 +0x1bc fp=0xc003df3f88 sp=0xc003df3358 pc=0x63d2bc
runtime.main()
/home/bradfitz/go/src/runtime/proc.go:203 +0x212 fp=0xc003df3fe0 sp=0xc003df3f88 pc=0x4355b2
runtime.goexit()
/home/bradfitz/go/src/runtime/asm_amd64.s:1375 +0x1 fp=0xc003df3fe8 sp=0xc003df3fe0 pc=0x4629c1
FAIL tailscale.io/control/cfgdb [build failed]
FAIL
```
And another, which looks like the same:
```
goroutine 1 [running]:
runtime.throw(0x6b7228, 0x5)
/home/bradfitz/go/src/runtime/panic.go:1112 +0x72 fp=0xc00004eee8 sp=0xc00004eeb8 pc=0x432f62
runtime.sigpanic()
/home/bradfitz/go/src/runtime/signal_unix.go:674 +0x443 fp=0xc00004ef18 sp=0xc00004eee8 pc=0x449533
runtime.memmove(0x7f29fc0a5000, 0x7f29fc6447ce, 0x4b)
/home/bradfitz/go/src/runtime/memmove_amd64.s:205 +0x1b2 fp=0xc00004ef20 sp=0xc00004ef18 pc=0x463d22
cmd/link/internal/ld.(*OutBuf).Write(0xc000024900, 0x7f29fc6447ce, 0x4b, 0x4b, 0x7f2a23f586e0, 0x3f, 0xb)
/home/bradfitz/go/src/cmd/link/internal/ld/outbuf.go:65 +0xa1 fp=0xc00004ef70 sp=0xc00004ef20 pc=0x5c83a1
cmd/link/internal/ld.(*OutBuf).WriteSym(0xc000024900, 0xc000a5d5f0)
/home/bradfitz/go/src/cmd/link/internal/ld/outbuf.go:159 +0x6c fp=0xc00004efc0 sp=0xc00004ef70 pc=0x5c8b7c
cmd/link/internal/ld.blk(0xc000024900, 0xc0022e8000, 0xa80, 0xc00, 0x401000, 0x102b7c, 0xc000b93280, 0x1, 0x1)
/home/bradfitz/go/src/cmd/link/internal/ld/data.go:787 +0x10f fp=0xc00004f090 sp=0xc00004efc0 pc=0x570d1f
cmd/link/internal/ld.CodeblkPad(0xc000001e00, 0x401000, 0x102b7c, 0xc000b93280, 0x1, 0x1)
/home/bradfitz/go/src/cmd/link/internal/ld/data.go:701 +0xbb fp=0xc00004f1a0 sp=0xc00004f090 pc=0x5703fb
cmd/link/internal/amd64.asmb(0xc000001e00)
/home/bradfitz/go/src/cmd/link/internal/amd64/asm.go:669 +0xc6 fp=0xc00004f200 sp=0xc00004f1a0 pc=0x5ec9f6
cmd/link/internal/ld.Main(0x899300, 0x10, 0x20, 0x1, 0x7, 0x10, 0x6c25b5, 0x1b, 0x6be64d, 0x14, ...)
/home/bradfitz/go/src/cmd/link/internal/ld/main.go:269 +0xd61 fp=0xc00004f358 sp=0xc00004f200 pc=0x5c7451
main.main()
/home/bradfitz/go/src/cmd/link/main.go:68 +0x1bc fp=0xc00004ff88 sp=0xc00004f358 pc=0x63d2bc
runtime.main()
/home/bradfitz/go/src/runtime/proc.go:203 +0x212 fp=0xc00004ffe0 sp=0xc00004ff88 pc=0x4355b2
runtime.goexit()
/home/bradfitz/go/src/runtime/asm_amd64.s:1375 +0x1 fp=0xc00004ffe8 sp=0xc00004ffe0 pc=0x4629c1
FAIL tailscale.com/logtail/filch [build failed]
FAIL
``` | NeedsInvestigation,compiler/runtime | medium | Critical |
568,067,451 | godot | using UV creates pixels while SCREEN_UV doesn't | **Godot version:**
3.2
**OS/device including version:**
MacOS 10.15.2
**Issue description:**
https://youtu.be/TxE91tWPZmU
Hi, here I was following JFonS code in implementing Frustum culling to stop stuff behind the portal from appearing in the mesh texture.
JFonS project: https://github.com/JFonS/godot-mirror-example/
I hit a snag where whenever my character get's close enough to the mesh that's rendering the viewport texture, everything in it get's pixelated, like when you stick your face too close to the TV as a kid and you start seeing the small LEDs.
I thought I was the only one who had this problem until I noticed JFonS mirror asset doing the same thing :(
I narrowed it down to the shaders when using UV instead of SCREEN_UV
as seen in the video
apparently when using the SCREEN_UV to map out the texture you get a better resolution regardless of how close you are to the mesh.
I would love to use SCREEN_UV but to avoid having that nightmare of a dynamic perspective shift as you can see in the video, I need to get the portal camera to follow my character's head rotation as well, however the camera's near plane is fixed to be always perpendicular to the camera's line of sight that means, as my portal camera's near plane is positioned right behind it's portal, it clips through the portal cutting triangles at the bottom from the rendered view in the process:
https://www.youtube.com/watch?v=UiWfSZGLuHw
I need to have the ability to angle the camera's near plane to keep it parallel with the portal while rendering the texture to SCREEN_UV to fix this
but I'm not too sure if angled near and far camera planes are possible in 3.2
Help is much appreciated :)
My project: https://github.com/19PHOBOSS98/Godot---PortalInstance
**Steps to reproduce:**
Set shader to render viewport texture using UV instead of SCREEN_UV
**Minimal reproduction project:**
https://github.com/19PHOBOSS98/Godot---PortalInstance
https://github.com/JFonS/godot-mirror-example/ | discussion,topic:shaders | low | Minor |
568,129,491 | flutter | ListView with sticky header and reordable items features | ## Use case
Hi!
One effect that I'm struggling to achieve in my app is having a `ListView` that loads paginated data and has this two features:
1. sticky headers like this: https://miro.medium.com/max/346/1*74Ky84hOwhK6MNA8BvspQQ.gif
I've tried a bunch of community libraries (like https://pub.dev/packages/flutter_sticky_header or https://pub.dev/packages/sticky_headers) but none of them allow to create items on the fly like the `itemBuilder` in `ListView.builder`
2. capability of reording items. I know that `ReorderableListView` exists but that widget accepts only a precalculated list of children and still doesn't have an "item builder" like `ListView.builder` so it's impossible to build list items on demand and having the same performance as the ListView.
## Proposal
For the part of paginated data I've created this question on StackOverflow and I'm trying to create the best implementation
https://stackoverflow.com/questions/60074466/pagination-infinite-scrolling-in-flutter-with-caching-and-realtime-invalidatio
For the part of sticky headers and reordable items having an item builder I still can't figure it out.
Is there already a widget or the tools to achieve this? If not can you please suggest a possible approach and maybe create a specific example?
Thanks
| c: new feature,framework,f: material design,f: scrolling,c: proposal,P3,team-design,triaged-design | low | Major |
568,172,032 | create-react-app | Don't swallow git error message | ### Is your proposal related to a problem?
When `git commit` fails for some reason (e.g. `user.name` is not set -- see #6442), CRA swallows git's output and displays a rather cryptic error message:
```
Git commit not created Error: Command failed: git commit -m "Initialize project using Create React App"
at checkExecSyncError (child_process.js:621:11)
at execSync (child_process.js:657:15)
at tryGitCommit (/home/pastelmind/test-app/node_modules/react-scripts/scripts/init.js:62:5)
at module.exports (/home/pastelmind/test-app/node_modules/react-scripts/scripts/init.js:335:25)
at [eval]:3:14
at Script.runInThisContext (vm.js:116:20)
at Object.runInThisContext (vm.js:306:38)
at Object.<anonymous> ([eval]-wrapper:9:26)
at Module._compile (internal/modules/cjs/loader.js:955:30)
at evalScript (internal/process/execution.js:80:25) {
status: 128,
signal: null,
output: [ null, null, null ],
pid: 2531,
stdout: null,
stderr: null
}
Removing .git directory...
```
Currently, [`init.js`](https://github.com/facebook/create-react-app/blob/038e6fa92735c941c5d6335d2775b585b18413fe/packages/react-scripts/scripts/init.js#L62) calls [`child_process.spawnSync()`](https://nodejs.org/api/child_process.html#child_process_child_process_spawnsync_command_args_options) with `stdio: 'ignore'`, which completely swallows Git's error message and leaves the user in the dark.
### Describe the solution you'd like
Use `stdio: 'pipe'`, at least for stderr. Also use `encoding: 'utf-8'` (or whatever is appropriate), because otherwise the `stdout` is a Buffer object--which isn't really helpful when printed on the terminal.
### Describe alternatives you've considered
<!--
Let us know about other solutions you've tried or researched.
-->
(Write your answer here.)
### Additional context
<!--
Is there anything else you can add about the proposal?
You might want to link to related issues here, if you haven't already.
-->
(Write your answer here.)
| issue: bug,contributions: claimed | low | Critical |
568,197,262 | godot | Some RichTextLabel getter methods only return a correct value on the next frame | **Godot version:** 3.2.stable
**OS/device including version:** Win 64
**Issue description:**
get_total_character_count() returns 0 in a RichTextLabel with text.
**Steps to reproduce:**
1. Add RichTextLabel node
2. add text in textbox
3. add script:
```
extends RichTextLabel
func _ready():
print( get_total_character_count() )
```
This should work according to the docs:
https://docs.godotengine.org/en/3.2/classes/class_richtextlabel.html#class-richtextlabel-method-get-total-character-count
possibly related: https://github.com/godotengine/godot/issues/874
| documentation,topic:gui | low | Major |
568,258,882 | flutter | [web]: System Colors with Flutter |
Property | Description |
-- | --
ActiveBorder | Active window border | Β
ActiveCaption | Active window caption | Β
AppWorkspace | Background color of multiple document interface | Β
Background | Desktop background | Β
ButtonFace | Face color for 3D display elements | Β
ButtonHighlight | Dark shadow for 3D display elements (facing away from light) | Β
ButtonShadow | Shadow color for 3D display elements | Β
ButtonText | Text on push buttons | Β
CaptionText | Text in caption, size box, and scrollbar arrow box | Β
GrayText | Grayed (disabled) text (#000 if not supported by OS) | Β
Highlight | Item(s) selected in a control | Β
HighlightText | Text of item(s) selected in a control | Β
InactiveBorder | Inactive window border | Β
InactiveCaption | Inactive window caption | Β
InactiveCaptionText | Color of text in an inactive caption | Β
InfoBackground | Background color for tooltip controls | Β
InfoText | Text color for tooltip controls | Β
Menu | Menu background | Β
MenuText | Text in menus | Β
Scrollbar | Scroll bar gray area | Β
ThreeDDarkShadow | Dark shadow for 3D display elements | Β
ThreeDFace | Face color for 3D display elements | Β
ThreeDHighlight | Highlight color for 3D display elements | Β
ThreeDLightShadow | Light color for 3D display elements (facing the light) | Β
ThreeDShadow | Dark shadow for 3D display elements | Β
Window | Window background | Β
WindowFrame | Window frame | Β
WindowText | Text in windows | Β
Google Groups reference:
https://groups.google.com/d/msg/flutter-dev/XDsI6yzMscg/pKKC7RBhBwAJ
| framework,c: proposal,P3,team-framework,triaged-framework | low | Minor |
568,305,110 | go | x/net/route: TestFetchAndParseRIB failure on freebsd-386-12_0 builder | https://build.golang.org/log/f6a2d4db3516c80bf97648a85c23cd92789725e5
```
--- FAIL: TestFetchAndParseRIB (0.00s)
message_test.go:34: 1 got (inet6 0000:0000:0000:0000:0000:0000:0000:0000 0) (inet4 28.28.0.0) (inet4 0.0.0.0) (inet4 0.0.0.0) (inet4 0.0.0.0); want inet6
message_test.go:38: 3 ifp (type=6 mtu=1460) (link 1 vtnet0 42:01:0a:f0:00:18)
message_test.go:38: 3 netmask|ifa|brd (inet4 255.255.255.255) (inet4 10.240.0.24) (inet4 10.240.0.24)
message_test.go:38: 3 ifp (type=24 mtu=16384) (link 2 lo0 <nil>)
message_test.go:38: 3 netmask|ifa|brd (inet6 ffff:ffff:ffff:ffff:ffff:ffff:ffff:ffff 0) (inet6 0000:0000:0000:0000:0000:0000:0000:0000 0) (inet6 0000:0000:0000:0000:0000:0000:0000:0001 0)
message_test.go:38: 3 netmask|ifa|brd (inet6 ffff:ffff:ffff:ffff:0000:0000:0000:0000 0) (inet6 0000:0000:0000:0000:0000:0000:0000:0000 0) (inet6 fe80:0000:0000:0000:0000:0000:0000:0001 2)
message_test.go:38: 3 netmask|ifa|brd (inet4 255.0.0.0) (inet4 127.0.0.1) (inet4 127.0.0.1)
message_test.go:38: 3 ifp (type=6 mtu=1460) (link 1 vtnet0 42:01:0a:f0:00:18)
message_test.go:38: 3 netmask|ifa|brd (inet4 255.255.255.255) (inet4 10.240.0.24) (inet4 10.240.0.24)
message_test.go:38: 3 ifp (type=24 mtu=16384) (link 2 lo0 <nil>)
message_test.go:38: 3 netmask|ifa|brd (inet4 255.0.0.0) (inet4 127.0.0.1) (inet4 127.0.0.1)
message_test.go:38: 3 ifp (type=6 mtu=1460) (link 1 vtnet0 42:01:0a:f0:00:18)
message_test.go:38: 3 ifp (type=24 mtu=16384) (link 2 lo0 <nil>)
message_test.go:38: 3 netmask|ifa|brd (inet6 ffff:ffff:ffff:ffff:ffff:ffff:ffff:ffff 0) (inet6 0000:0000:0000:0000:0000:0000:0000:0000 0) (inet6 0000:0000:0000:0000:0000:0000:0000:0001 0)
message_test.go:38: 3 netmask|ifa|brd (inet6 ffff:ffff:ffff:ffff:0000:0000:0000:0000 0) (inet6 0000:0000:0000:0000:0000:0000:0000:0000 0) (inet6 fe80:0000:0000:0000:0000:0000:0000:0001 2)
FAIL
FAIL golang.org/x/net/route 0.012s
```
I couldn't easily check for other occurrences due to #35515. | NeedsInvestigation | low | Critical |
568,313,966 | vscode | [npm] load description/homepage from referenced node module version | <!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ -->
<!-- Please search existing issues to avoid creating duplicates. -->
<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: https://code.visualstudio.com/insiders/ -->
<!-- Use Help > Report Issue to prefill these. -->
- VSCode Version: 1.42.1
- OS Version: macos Catalina 10.15.3
Steps to Reproduce:
1. `yarn add azer/indexeddb`
2. highlight `indexeddb` row in the `package.json
<!-- Launch with `code --disable-extensions` to check. -->
Does this issue occur when all extensions are disabled?: Yes
## Screenshot
<img width="556" alt="Screenshot 2020-02-20 at 18 41 42" src="https://user-images.githubusercontent.com/13215662/74938899-b6b8dd80-5410-11ea-8120-bed75f744742.png">
It shows https://github.com/bigeasy/indexeddb, though it should be https://github.com/azer/indexeddb | feature-request,json | low | Minor |
568,323,416 | flutter | WidgetTester.pageBack only work in an english application | WidgetTester has a method `pageBack` that tries to find a Back button.
```
await tester.pumpWidget(MyWidget());
await tester.tap(find.text('Button'));
await tester.pageBack();
```
The implementation as shown here: https://api.flutter.dev/flutter/flutter_test/WidgetTester/pageBack.html, look for a tooltip with text "Back".
This doesn't work when the application is translated with MaterialLocalizations and the test runned in a language other than english.
The `pageBack` method should use an other technique to locate the button (ie. use a semantic label or search for a `BackButton` widget).
<details>
<summary>Logs</summary>
<!--
Run your application with `flutter run --verbose` and attach all the
log output below between the lines with the backticks. If there is an
exception, please see if the error message includes enough information
to explain how to solve the issue.
-->
```
```
<!--
Run `flutter analyze` and attach any output of that command below.
If there are any analysis errors, try resolving them before filing this issue.
-->
```
```
<!-- Finally, paste the output of running `flutter doctor -v` here. -->
```
[β] Flutter (Channel stable, v1.12.13+hotfix.8, on Mac OS X 10.15.2 19C57, locale en-BE)
β’ Flutter version 1.12.13+hotfix.8 at /Users/xavier/projects/flutter_stable
β’ Framework revision 0b8abb4724 (9 days ago), 2020-02-11 11:44:36 -0800
β’ Engine revision e1e6ced81d
β’ Dart version 2.7.0
[β] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
β’ Android SDK at /Users/xavier/Library/Android/sdk
β’ Android NDK location not configured (optional; useful for native profiling support)
β’ Platform android-29, build-tools 29.0.2
β’ Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
β’ Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405)
β’ All Android licenses accepted.
[β] Xcode - develop for iOS and macOS (Xcode 11.3.1)
β’ Xcode at /Applications/Xcode.app/Contents/Developer
β’ Xcode 11.3.1, Build version 11C504
β’ CocoaPods version 1.8.4
[β] Android Studio (version 3.5)
β’ Android Studio at /Applications/Android Studio.app/Contents
β’ Flutter plugin version 43.0.1
β’ Dart plugin version 191.8593
β’ Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405)
[β] IntelliJ IDEA Ultimate Edition (version 2019.3.2)
β’ IntelliJ at /Applications/IntelliJ IDEA.app
β’ Flutter plugin version 43.0.3
β’ Dart plugin version 193.6015.53
[β] VS Code (version 1.41.1)
β’ VS Code at /Applications/Visual Studio Code.app/Contents
β’ Flutter extension version 3.7.1
[β] Connected device (2 available)
β’ Moto G 5 Plus β’ ZY224FKBCL β’ android-arm β’ Android 8.1.0 (API 27)
β’ Xavierβs iPhone β’ 00008030-00012D9C0212802E β’ ios β’ iOS 13.3.1
β’ No issues found!
```
</details>
| a: tests,c: crash,framework,a: internationalization,f: routes,has reproducible steps,P2,found in release: 3.7,found in release: 3.8,team-framework,triaged-framework | low | Critical |
568,392,304 | go | runtime: TestGcSys is still flaky | ```
--- FAIL: TestGcSys (0.03s)
gc_test.go:27: expected "OK\n", but got "using too much memory: 70486024 bytes\n"
FAIL
FAIL runtime 50.446s
```
See previously #28574, #27636, #27156, #23343.
CC @mknyszek @aclements
[2020-02-15T16:40:12-6917529/freebsd-amd64-race](https://build.golang.org/log/1332da8c3cb0222c5e925b116d11b5d6de1bfb01)
[2020-02-05T18:27:48-702226f/freebsd-amd64-race](https://build.golang.org/log/60634ae049700ca97d5a89b191778ba7e5e3569f)
[2020-01-31T15:04:07-f2a4ab3/freebsd-amd64-race](https://build.golang.org/log/97ddc13cc1f3420a5d29c0c577aaed27f2837dfa)
[2020-01-07T19:53:19-7d98da8/darwin-amd64-10_15](https://build.golang.org/log/ccd26fa871a0a0433158a4b6937784055a7be22b)
[2019-12-31T12:11:24-bbd25d2/solaris-amd64-oraclerel](https://build.golang.org/log/c7ecea0ba94b3b906f9d47ccf764b74d33bafdad)
[2019-12-11T00:01:17-9c8c27a/solaris-amd64-oraclerel](https://build.golang.org/log/f3aec9603f99d24cfdafe4a4ef86b2de1d32fc9f)
[2019-11-04T15:18:34-d3660e8/plan9-386-0intro](https://build.golang.org/log/1dcfa79fd9ceb919885427b151fbc0f935643e47)
[2019-09-12T14:08:16-3d522b1/solaris-amd64-smartosbuildlet](https://build.golang.org/log/ef2b3b3c556f09113bccd1ea2eb472d8c8217058) | NeedsInvestigation | medium | Critical |
568,395,979 | angular | Cannot read property 'bindingStartIndex' of null when using Library | # π bug report
### Affected Package
Not sure. Maybe this is somewhere in @angular/cli or somewhere related to Webpack.
### Is this a regression?
Yes, the previous version in which this bug was not present was Angular 8
### Description
When creating a library as described in [the documentation](https://angular.io/guide/creating-libraries) and using it in an empty app, I get the following error at runtime:
ERROR TypeError: Cannot read property 'bindingStartIndex' of null
at Module.Ι΅Ι΅elementStart (core.js:20997)
at MyLibComponent_Template (my-lib.js:19)
at executeTemplate (core.js:11930)
at renderView (core.js:11716)
at renderComponent (core.js:13232)
at renderChildComponents (core.js:11519)
at renderView (core.js:11742)
at renderComponent (core.js:13232)
at renderChildComponents (core.js:11519)
at renderView (core.js:11742)
I do not see any errors while compiling.
## π¬ Minimal Reproduction
I did the following:
- Create a `my-libs` project: `ng new my-libs --create-application=false`
- Create a library: `cd my-libs` and `ng generate library my-lib`
- Create an app next to this: `cd ..` and `ng new my-app`
- Add the library as a dependency of the app: Add `"my-lib": "file:../my-libs/dist/my-lib"` to the `dependencies` in the app's `package.json` and run `npm install`
- Import the `MyLibModule` in the `AppModule` (imported via `import { MyLibModule } from 'my-lib';`)
- Use the component in the `AppComponent`: `<lib-my-lib></lib-my-lib>`
- Build the library: `cd my-libs` and `ng build --prod`
- Run the app: `cd ..` and `ng serve`
- Point browser at `http://localhost:4200/`
- Open Developer Tools to look at the console
The resulting project is contained in this zip-file [repro.zip](https://github.com/angular/angular/files/4231679/repro.zip). I removed the `node_modules`, so please do
$ cd my-libs
$ npm install
$ ng build --prod
$ cd ..
$ cd my-app
$ npm install
$ ng serve
## π₯ Exception or Error
<pre><code>
ERROR TypeError: Cannot read property 'bindingStartIndex' of null
at Module.Ι΅Ι΅elementStart (core.js:20997)
at MyLibComponent_Template (my-lib.js:19)
at executeTemplate (core.js:11930)
at renderView (core.js:11716)
at renderComponent (core.js:13232)
at renderChildComponents (core.js:11519)
at renderView (core.js:11742)
at renderComponent (core.js:13232)
at renderChildComponents (core.js:11519)
at renderView (core.js:11742)
</code></pre>
## π Your Environment
**Angular Version:**
<pre><code>
_ _ ____ _ ___
/ \ _ __ __ _ _ _| | __ _ _ __ / ___| | |_ _|
/ β³ \ | '_ \ / _` | | | | |/ _` | '__| | | | | | |
/ ___ \| | | | (_| | |_| | | (_| | | | |___| |___ | |
/_/ \_\_| |_|\__, |\__,_|_|\__,_|_| \____|_____|___|
|___/
Angular CLI: 9.0.2
Node: 12.13.0
OS: darwin x64
Angular:
...
Ivy Workspace:
Package Version
------------------------------------------------------
@angular-devkit/architect 0.900.2
@angular-devkit/core 9.0.2
@angular-devkit/schematics 9.0.2
@schematics/angular 9.0.2
@schematics/update 0.900.2
rxjs 6.5.3
</code></pre>
| type: bug/fix,area: core,area: compiler,P4 | medium | Critical |
568,451,785 | terminal | Move AzureConnection back to terminal VT once terminal's VT adapter is robust | To improve the Azure connection before v1.0, we started running it through a shim executable just to get ConPTY to translate its complicated VT for us.
Once terminal is _good_ at VT, we should cut that out. | Product-Terminal,Issue-Task,Area-AzureShell | low | Minor |
568,470,699 | go | cmd/go: mod download modpath@HEAD erroneously resolves to a pseudo-version when HEAD is subsequently tagged | <!-- Please answer these questions before submitting your issue. Thanks! -->
### What version of Go are you using (`go version`)?
<pre>
$ go version
go version go1.14rc1 linux/amd64
</pre>
### Does this issue reproduce with the latest release?
Yes.
### What operating system and processor architecture are you using (`go env`)?
<details><summary><code>go env</code> Output</summary><br><pre>
$ go env
GO111MODULE="on"
GOARCH="amd64"
GOBIN="/home/manlio/.local/bin"
GOCACHE="/home/manlio/.cache/go-build"
GOENV="/home/manlio/.config/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/home/manlio/.local/lib/go:/home/manlio/src/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/home/manlio/sdk/go1.14rc1"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/home/manlio/sdk/go1.14rc1/pkg/tool/linux_amd64"
GCCGO="gccgo"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="/home/manlio/src/go/src/mperillo.test/issue/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build788093506=/tmp/go-build -gno-record-gcc-switches"
GOROOT/bin/go version: go version go1.14rc1 linux/amd64
GOROOT/bin/go tool compile -V: compile version go1.14rc1
uname -sr: Linux 5.5.4-arch1-1
/usr/lib/libc.so.6: GNU C Library (GNU libc) stable release version 2.31.
gdb --version: GNU gdb (GDB) 9.1
</pre></details>
### What did you do?
First, I configured *git* with:
```
[url "file:///home/manlio/src/go/src/mperillo.test/"]
insteadOf = https://mperillo.test/
```
in order to test with local module paths.
In a new git repository with only 1 commit:
```
$ go1.14rc1 clean -modcache
$ GOPRIVATE="*" go1.14rc1 mod download -json mperillo.test/issue.git@HEAD
{
"Path": "mperillo.test/issue.git",
"Version": "v0.0.0-20200220172602-e96c074fea4f",
}
```
Now I release a version, without a new commit:
```
$ git tag -a v0.1.0
$ GOPRIVATE="*" go1.14rc1 mod download -json mperillo.test/issue.git@HEAD
{
"Path": "mperillo.test/issue.git",
"Version": "v0.1.1-0.20200220172602-e96c074fea4f",
"Error": "mperillo.test/[email protected]: invalid pseudo-version: tag (v0.1.0) found on revision e96c074fea4f is already canonical, so should not be replaced with a pseudo-version derived from that tag",
}
```
### What did you expect to see?
Not sure.
But it is not clear why it fails, and the error message seems a bit confusing. Why is `go` trying to replace the canonical `v0.1.0` if this is the version that it is processing now?
### P.S.
The actual *module path*, as defined in `go.mod`, is `mperillo.test/issue` and not `mperillo.test/issue.git`. Can this be considered a bug?
The `.git` extension was added to force `go` to don't try to get `https://mperillo.test/issue?go-get=1`. | help wanted,NeedsInvestigation,modules | low | Critical |
568,478,994 | vscode | Git - Git Typechanges do not appear in source control panel | Issue Type: <b>Bug</b>
The source control panel does not display files where git has detected that the type has changed, such as when an actual file replaces a symlink.
1. Create a file and a symlink to the file in a git repository. (`git init; touch default_img; ln -s default_img john_smith_headshot`)
2. Commit both the files. (`git commit -m 'Commit default image for use until actual photos arrive'`)
3. Replace the symlink with an actual, distinct file. (`mv some_other_image john_smith_headshot`)
4. Run git status. Note that git detects the typechange (`git status`)
Expected behaviour: The file which replaced the symlink appears in the source control panel, marked as T for typechange
Actual behaviour: Panel remains empty
VS Code version: Code 1.42.1 (c47d83b293181d9be64f27ff093689e8e7aed054, 2020-02-11T14:50:36.977Z)
OS version: Linux x64 5.3.0-40-generic
<details>
<summary>System Info</summary>
|Item|Value|
|---|---|
|CPUs|Intel(R) Core(TM) i7-6700HQ CPU @ 2.60GHz (8 x 2922)|
|GPU Status|2d_canvas: enabled<br>flash_3d: enabled<br>flash_stage3d: enabled<br>flash_stage3d_baseline: enabled<br>gpu_compositing: enabled<br>metal: disabled_off<br>multiple_raster_threads: enabled_on<br>oop_rasterization: disabled_off<br>protected_video_decode: unavailable_off<br>rasterization: disabled_software<br>skia_renderer: disabled_off<br>surface_control: disabled_off<br>surface_synchronization: enabled_on<br>video_decode: unavailable_off<br>viz_display_compositor: enabled_on<br>viz_hit_test_surface_layer: disabled_off<br>webgl: enabled<br>webgl2: enabled|
|Load (avg)|1, 1, 1|
|Memory (System)|15.52GB (9.33GB free)|
|Process Argv|--disable-extensions . --no-sandbox|
|Screen Reader|no|
|VM|0%|
</details>Extensions disabled
<!-- generated by issue reporter --> | bug,help wanted,git | low | Critical |
568,494,319 | flutter | Migrate ShellTestPlatformViewVulkan::OffscreenSurface functionality into //vulkan | A quick OffscreenSurface implementation was added to ShellTestPlatformViewVulkan which was mostly forked from //vulkan/vulkan_window.cc. The impact isn't particularly huge but we should look into moving this code/functionality back into //vulkan. | engine,P2,team-engine,triaged-engine | low | Minor |
568,494,728 | godot | Statically linked mono on Windows - external profiler doesn't work | **Godot version: 3.2**
**OS/device including version: Windows 10**
**Issue description:**
When following steps in godotengine/godot#34382
JetBrains dotTrace or JetBrains Rider show "Unsupported Mono version"
It happens only on Windows with official Godot build, however with locally compiled Godot build with dynamically liked mono profiler works fine.
JetBrains engineers think that when mono is statically linked, its exports are not inherited.
JetBrains profiler dll loaded in Godot process is looking for mono api function and fails.
```
auto lib_handle = LoadLibrary("godot_exe_name");
auto func = GetProcAddress(lib_handle, "some_mono_function"); // this call fails
```
Example of the function: MONO_API MonoProfilerHandle mono_profiler_create (MonoProfiler *prof);
This happens only on Windows because mono on Windows works differently, as mono documentations says that for windows each function should be marked for export.
https://www.mono-project.com/docs/advanced/embedding/#windows-considerations | bug,platform:windows,topic:buildsystem,topic:dotnet | medium | Major |
568,509,189 | vscode | Add a command to file an issue (bug) with relevant info | I would love to be able to have a command (in the palette and something I can shortcut) that would open a GitHub issue and paste in the system info. Basically like using the Issue Reporter and you uncheck include extensions (I never want to include those), but in a single shot without entering a title or message. | feature-request,issue-reporter | low | Critical |
568,523,170 | godot | Mono editor plugins can't cast non-tool C# types | **Godot version:** 3.2.stable
**OS/device including version:** Windows 10 Pro
**Issue description:**
With the following hierarchy
`Game` (`Control`) and `ToolGame` (`Node2D`) have their own C# classes with the same names. `ToolGame` is a `[Tool]`, and makes a `GetParent<Game>()` call, that works in-game, but fails in-editor with the following error:
```
modules/mono/mono_gd/gd_mono_utils.cpp:357 - System.InvalidCastException: Specified cast is not valid.
```
The same message is shown between 3 and 5 times. The exact same structure and code in Gdscript works as intended.
**Steps to reproduce:**
Create a scene like the one in the screenshot, and add corresponding classes.
`ToolGame.cs` contains this minimal code:
```cs
using Godot;
[Tool]
public class ToolGame : Node2D
{
public override void _Ready()
{
}
public override void _Draw()
{
var control = GetParent<Control>(); // Fine
var game = GetParent<Game>(); // InvalidCastException
}
}
```
| bug,topic:dotnet | medium | Critical |
568,530,029 | pytorch | empty_sparse shouldn't be called with memory layout but is | Memory format is completely ignored by sparse constructor. It would be good to specify an error if it's specified...
```
Tensor empty_sparse(IntArrayRef size, const TensorOptions& options, c10::optional<MemoryFormat> optional_memory_format) {
TORCH_CHECK(!options.pinned_memory(), "Only dense CPU tensors can be pinned");
//TORCH_CHECK(!optional_memory_format.has_value(), "Only dense CPU tensors can have memory format");
return new_with_dims_sparse(size.size(), 0, size, options);
}
```
But you cannot because this is an override of `empty` and apparently in some situations the memory format is set:
```
Feb 19 16:06:29 ======================================================================
Feb 19 16:06:29 ERROR [0.046s]: test_EmbeddingBag_sparse (__main__.TestNN)
Feb 19 16:06:29 ----------------------------------------------------------------------
Feb 19 16:06:29 Traceback (most recent call last):
Feb 19 16:06:29 File "test_nn.py", line 8499, in <lambda>
Feb 19 16:06:29 add(test_name, lambda self, test=test: test(self))
Feb 19 16:06:29 File "/Users/distiller/workspace/miniconda3/lib/python3.7/site-packages/torch/testing/_internal/common_nn.py", line 3664, in __call__
Feb 19 16:06:29 self._do_test(test_case, module, input)
Feb 19 16:06:29 File "test_nn.py", line 285, in _do_test
Feb 19 16:06:29 module.float()
Feb 19 16:06:29 File "/Users/distiller/workspace/miniconda3/lib/python3.7/site-packages/torch/nn/modules/module.py", line 334, in float
Feb 19 16:06:29 return self._apply(lambda t: t.float() if t.is_floating_point() else t)
Feb 19 16:06:29 File "/Users/distiller/workspace/miniconda3/lib/python3.7/site-packages/torch/nn/modules/module.py", line 236, in _apply
Feb 19 16:06:29 grad_applied = fn(param.grad)
Feb 19 16:06:29 File "/Users/distiller/workspace/miniconda3/lib/python3.7/site-packages/torch/nn/modules/module.py", line 334, in <lambda>
Feb 19 16:06:29 return self._apply(lambda t: t.float() if t.is_floating_point() else t)
Feb 19 16:06:29 RuntimeError: Only dense CPU tensors can have memory format
Feb 19 16:06:29
Feb 19 16:06:29 ======================================================================
Feb 19 16:06:29 ERROR [0.040s]: test_Embedding_sparse (__main__.TestNN)
Feb 19 16:06:29 ----------------------------------------------------------------------
Feb 19 16:06:29 Traceback (most recent call last):
Feb 19 16:06:29 File "test_nn.py", line 8499, in <lambda>
Feb 19 16:06:29 add(test_name, lambda self, test=test: test(self))
Feb 19 16:06:29 File "/Users/distiller/workspace/miniconda3/lib/python3.7/site-packages/torch/testing/_internal/common_nn.py", line 3664, in __call__
Feb 19 16:06:29 self._do_test(test_case, module, input)
Feb 19 16:06:29 File "test_nn.py", line 285, in _do_test
Feb 19 16:06:29 module.float()
Feb 19 16:06:29 File "/Users/distiller/workspace/miniconda3/lib/python3.7/site-packages/torch/nn/modules/module.py", line 334, in float
Feb 19 16:06:29 return self._apply(lambda t: t.float() if t.is_floating_point() else t)
Feb 19 16:06:29 File "/Users/distiller/workspace/miniconda3/lib/python3.7/site-packages/torch/nn/modules/module.py", line 236, in _apply
Feb 19 16:06:29 grad_applied = fn(param.grad)
Feb 19 16:06:29 File "/Users/distiller/workspace/miniconda3/lib/python3.7/site-packages/torch/nn/modules/module.py", line 334, in <lambda>
Feb 19 16:06:29 return self._apply(lambda t: t.float() if t.is_floating_point() else t)
Feb 19 16:06:29 RuntimeError: Only dense CPU tensors can have memory format
Feb 19 16:06:29
```
This seems a bit fishy.
cc @vincentqb @aocsa @nikitaved @pearu @mruberry @VitalyFedyunin @jamesr66a @ppwwyyxx | module: sparse,triaged,module: memory format,module: tensor creation | low | Critical |
568,532,175 | godot | is_action_pressed sometimes skips key press | **Godot version:**
3.2-stable
**OS/device including version:**
Windows 10 Home (Version: 1903, Build 18362.657)
**Issue description:**
Sometimes in-game keystroke events are skipped (this happens often when fps is low). This happens if you press them between frame updates. In my case, this happened with the βXβ and arrow buttons. But I think there are many other cases when this can happen.
**Steps to reproduce:**
To reproduce this problem with a 99% guarantee, you will need to set the `Frame Delay Msec` to high value, for example, to 1000 (1 frame per second). Then need to press any arrow key and then X key (but before next render). In test you'll see `x____`
**Minimal reproduction project:**
[KeyboardTest.zip](https://github.com/godotengine/godot/files/4497427/KeyboardTest.zip) (version 2)
If everything is OK, you'll see something like this `x__<_` (pressing left then X) or this `x^___` (pressing up then X)
If not, you'll only see `x____` (when pressed any arrow key then X) or even `_____`.
Frame rate of demo already set to 1 frame per second
**My thoughts on this issue:**
I downloaded the source code of the engine and did a little research. I think the problem is in the WM_KEYPRESS event (most likely on the Windows side).
As I understand it, this is because the OS sets a flag to indicate that it is a key repeat, regardless of whether the program processed the keystroke or not. Thus, in the WM_KEYPRESS event, the 30th bit of lParam indicates that the arrow key was previously pressed (but the Godot did not know about it).
To fix this problem, it probably makes sense to change the [1183 line](https://github.com/godotengine/godot/blob/851cb429631168369d2a51812de763b658795fbf/platform/windows/os_windows.cpp#L1183) of `os_windows.cpp` to something like this:
```c++
bool last_is_pressed = Input::get_singleton()->is_key_pressed(k->get_scancode());
k->set_echo((ke.uMsg == WM_KEYDOWN && last_is_pressed));
``` | bug,platform:windows,confirmed,topic:input | low | Major |
568,550,329 | node | http2 client request doesn't always fire end event | * **Version**: v12.16.1
* **Platform**: Darwin Cypher.local 19.3.0 Darwin Kernel Version 19.3.0: Thu Jan 9 20:58:23 PST 2020; root:xnu-6153.81.5~1/RELEASE_X86_64 x86_64
* **Subsystem**: http2
### What steps will reproduce the bug?
```
const http2 = require('http2');
const client = http2.connect('https://prod.geo-fsty.philo.com');
const req = client.request({ ':path': '/' });
let data = '';
req.on('data', chunk => { data += chunk; });
req.on('end', () => {
console.log(`END: ${data}`);
client.close();
});
req.end();
```
### How often does it reproduce? Is there a required condition?
This is reproducible every time.
Other HTTP/2 clients behave correctly, such as: `curl --http2 -v https://prod.geo-fsty.philo.com`
### What is the expected behavior?
The end event is fired.
### What do you see instead?
The end event does not fire. The complete data payload is received.
### Additional information
If the code is modified to wait for the ClientHttp2Session to be ready and delay issuing the request via setImmediate, it works.
```
const http2 = require('http2');
const client = http2.connect('https://prod.geo-fsty.philo.com', () => {
setImmediate(() => {
const req = client.request({ ':path': '/' });
let data = '';
req.on('data', chunk => { data += chunk; });
req.on('end', () => {
console.log(`END: ${data}`);
client.close();
});
req.end();
});
});
```
| http2 | low | Critical |
568,565,908 | youtube-dl | VKSPEED.COM | <!--
######################################################################
WARNING!
IGNORING THE FOLLOWING TEMPLATE WILL RESULT IN ISSUE CLOSED AS INCOMPLETE
######################################################################
-->
## Checklist
<!--
Carefully read and work through this check list in order to prevent the most common mistakes and misuse of youtube-dl:
- First of, make sure you are using the latest version of youtube-dl. Run `youtube-dl --version` and ensure your version is 2020.02.16. If it's not, see https://yt-dl.org/update on how to update. Issues with outdated version will be REJECTED.
- Make sure that all provided video/audio/playlist URLs (if any) are alive and playable in a browser.
- Make sure that site you are requesting is not dedicated to copyright infringement, see https://yt-dl.org/copyright-infringement. youtube-dl does not support such sites. In order for site support request to be accepted all provided example URLs should not violate any copyrights.
- Search the bugtracker for similar site support requests: http://yt-dl.org/search-issues. DO NOT post duplicates.
- Finally, put x into all relevant boxes (like this [x])
-->
- [x ] I'm reporting a new site support request
- [x ] I've verified that I'm running youtube-dl version **2020.02.16**
- [x ] I've checked that all provided URLs are alive and playable in a browser
- [x ] I've checked that none of provided URLs violate any copyrights
- [x ] I've searched the bugtracker for similar site support requests including closed ones
## Example URLs
<!--
Provide all kinds of example URLs support for which should be included. Replace following example URLs by yours.
-->
- Single video: https://vkspeed.com/oyuzj5ziy4r0.html
- Single video: https://vkspeed.com/6l67mljbc9qa.html
- Playlist: Not a feature on the website
## Description
<!--
Provide any additional information.
If work on your issue requires account credentials please provide them or explain how one can obtain them.
-->
It is a video hosting platform. Examples provided are of same type. No other fancy features on the website and hence no other types of URL.
Generic Information Extractor says "Unsupported URL"
Please let me know if you require further information.
| site-support-request | low | Critical |
568,611,095 | rust | Feature Request: NonZeroInt literal coersion | It should be possible for an integer literal to initialize a `NonZeroInt` type, like `NonZeroUsize`. For instance, this should be legal:
```rust
struct Settings {
// None means unlimited
max_args: Option<NonZeroUsize>
}
let settings = Settings {
max_args: Some(2),
}
```
The compiler can easily check whether the literal is zero and fail if it is.
While I know that the `NonZero` types are "just" regular structs, it seems as though they already have so many special compiler attributes attached to them to ensure that they work with Option correctly that it seems like it wouldn't be much of a stretch to have this one as well (though I'm happy to be corrected there). | T-lang,C-feature-request,A-coercions | low | Major |
568,620,788 | flutter | [web][safari] unskip safari font test | font_collection_test.dart is failing in Safari on LUCI (not locally)
The LUCI logs for the failure: https://logs.chromium.org/logs/flutter/led/nurhan_google.com/8b7433ee4ff6b175296bd9807acf776eb9c45e899119691659f27d49334a4fad/+/steps/felt_test/0/stdout | a: tests,team,framework,a: typography,platform-web,browser: safari-macos,P2,team-web,triaged-web | low | Critical |
568,640,212 | godot | VisualServer: `get_video_adapter_vendor()` and `get_video_adapter_name()` return `null` when multithreaded rendering is enabled | **Godot version:**
3.2
**OS/device including version:**
Windows/Linux
**Issue description:**
get_video_adapter_vendor() and get_video_adapter_name() both return null if they are not running on the rendering thread.
**Steps to reproduce:**
Configure a project with the following setting in `project.godot`
```
[rendering]
threads/thread_model=2
```
call VisualServer.get_video_adapter_name() or VisualServer.get_video_adapter_vendor()
Observe the empty strings.
**Minimal reproduction project:**
[renderer-repro.zip](https://github.com/godotengine/godot/files/4233511/renderer-repro.zip) | bug,topic:core,topic:rendering,confirmed | low | Major |
568,645,638 | godot | Animation Curves: moving the timeline in the Animation Panel is delayed by seconds. | **Godot version:** 3.2.stable
**OS/device including version:** Win 64
**Issue description:**
**Steps to reproduce:**
1. Make a new animation and enable curves.
2. set some keyframes and click the curves symbol to edit the curves
3. try to move the Timeline left panel border | bug,topic:editor | low | Major |
568,657,166 | go | os/user: On windows, current() -> t.GetUserProfileDirectory() errors when for RemoteInteractive Logon session on system without user profile | # What version of Go are you using (`go version`)?
<pre>
$ go version
go version go1.13.7 darwin/amd64
</pre>
### Does this issue reproduce with the latest release?
yes
### What operating system and processor architecture are you using (`go env`)?
<details><summary><code>go env</code> Output</summary><br><pre>
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/amanners/Library/Caches/go-build"
GOENV="/Users/amanners/Library/Application Support/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GONOPROXY=""
GONOSUMDB=""
GOOS="darwin"
GOPATH="/Users/amanners/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/Cellar/go/1.13.7/libexec"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/Cellar/go/1.13.7/libexec/pkg/tool/darwin_amd64"
GCCGO="gccgo"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/5l/sgy31cm96k9671825xjz_sm40000gq/T/go-build492878366=/tmp/go-build -gno-record-gcc-switches -fno-common"
</pre></details>
### What did you do?
Attempted to use WMIC/PSRemote to interact with a system to launch a GO executable that logs the current user (aka PSSession user/WMI exec) using `user.Current()`. User returns as `nil` with err `The system cannot find the file specified.` because the user does not have a home directory on the remote system.
Platform: `Windows Server 2016 Version 1607 Build 14393.3326`
### What did you expect to see?
Valid User structure with Dir as nil/empty string.
`os/user/lookup_windows.go:184`
```Golang
func newUser(uid, gid, dir, username, domain string) (*User, error) {
domainAndUser := domain + `\` + username
name, e := lookupFullName(domain, username, domainAndUser)
if e != nil {
return nil, e
}
u := &User{
Uid: uid,
Gid: gid,
Username: domainAndUser,
Name: name,
HomeDir: dir, <- should return as empty/nil
}
return u, nil
}
```
### What did you see instead?
No user returned, error stated above.
### Extra information
The specific issue resides in how `t.GetUserProfileDirectory()` is handled in `current()`:
```Golang
func current() (*User, error) {
t, e := syscall.OpenCurrentProcessToken()
if e != nil {
return nil, e
}
defer t.Close()
u, e := t.GetTokenUser()
if e != nil {
return nil, e
}
pg, e := t.GetTokenPrimaryGroup()
if e != nil {
return nil, e
}
uid, e := u.User.Sid.String()
if e != nil {
return nil, e
}
gid, e := pg.PrimaryGroup.String()
if e != nil {
return nil, e
}
dir, e := t.GetUserProfileDirectory() <- These lines
if e != nil {
return nil, e <- should set directory to nil and continue on
}
username, domain, e := lookupUsernameAndDomain(u.User.Sid)
if e != nil {
return nil, e
}
return newUser(uid, gid, dir, username, domain)
}
```
In windows environments it is possible to have a login type where the user doesn't have a Home Directory on that system (all remote windows domain administrator tasks). I will submit a PR with a proposed solution to this.
@christophert and I discovered this while trying to start remote tasks on Windows system that we had never logged into. | OS-Windows,NeedsInvestigation | low | Critical |
568,663,979 | PowerToys | [FancyZones] Cycle Windows across Zones (not Focus) Round Robin on hotkey | # Summary of the new feature/enhancement
When the user presses a HotKey, FZ should shift Windows one place left or right.
In a Scenario like "Priority Grid". User can cycle and bring into the center focus one of the 3 Windows. Of course, an alternative is to Use Win+Arrow, but that leaves a spot open.
Please note, I'm requesting that the Window shift from their original grid positions, not merely shifting the focus (#358 #175 )
That said, I have not thought about how to deal with overlapping windows. | Idea-Enhancement,Product-FancyZones | low | Major |
568,664,565 | godot | This error check seems unreasonable (MAX_EXTENSIONS) at vulkan_context.h | Version: 4.0
Shouldn't we replace this with a comment to tell if ever we may care about more than 128 extensions, we should increase the constant MAX_EXTENSIONS to 254? Unless we reach this specific situation this condition will be false.
https://github.com/godotengine/godot/blob/851cb429631168369d2a51812de763b658795fbf/drivers/vulkan/vulkan_context.cpp#L251
Does it ever occur for a driver have a limit for the number of extensions? Because to me, even limiting the number of extensions affordable seems odd. | discussion,topic:rendering | low | Critical |
568,687,120 | flutter | [google_maps_flutter] Add support for transit layer | Add transit layer api support as in the Google Maps Javascript API, which can be found here: https://developers.google.com/maps/documentation/javascript/trafficlayer#transit_layer | c: new feature,p: maps,package,c: proposal,team-ecosystem,P3,triaged-ecosystem | low | Minor |
568,717,308 | terminal | Duplicate Tab doesn't duplicate split panes |
# Steps to reproduce
Create some spit panes in a tab, then ctrl-shift-d to duplicateTab, new tab is a single pane tab.
# Expected behavior
new tab is a duplicate of the split paned tab with the same panes
# Actual behavior
single pane tab
| Help Wanted,Area-UserInterface,Product-Terminal,Issue-Task | low | Major |
568,727,184 | TypeScript | No excess property error for computed property | **TypeScript Version:** 3.7.5 and 3.9.0-dev.20200220
<!-- Search terms you tried before logging this (so others can find this issue more easily) -->
**Search Terms:** excess property, computed property, index signature
**Code**
```ts
interface Foo {
a: string;
}
const bar: Foo = {
a: "",
z: "" // error, excess prop
}
const baz: Foo = {
a: "",
["Z".toLowerCase()]: "" // this is okay I guess?
}
```
**Expected behavior:**
The computed property in the definition of `baz` should maybe produce an excess property error, since `Foo` has no string index signature and `"Z".toLowerCase()` is only known to be a `string`.
**Actual behavior:**
The computed property is allowed.
**Playground Link:** [Here](https://www.typescriptlang.org/play/#code/JYOwLgpgTgZghgYwgAgGIHt3IN4FgBQAkHAFzIDOYUoA5gNwEC+yBBC6IlyARnFGRiwBeHAWJkARBIA0YgF6SJyAPTLk0KOijT1ADyTlyyAA6bjTFvjYcuvBWkzIReIqWRTZRANoSAWhIA6MHQAGXQAd2gAYThyCAAKAEoAXUUVNTAAC2AjHOR0AGs4AE9kAElkGgBXCEMAfiZWfCA)
**Related Issues:** #22427
This issue is a re-opening of #22427, which was marked as a bug and closed as "fixed", but I don't see an actual fix referenced anywhere in that issue and the behavior described in that issue persists. Any ideas? Thanks!
There's an [SO question](https://stackoverflow.com/questions/60331830/why-can-i-create-an-index-dynamically-in-typescript) asking this, which brought me to #22427, which has me scratching my head π. | Suggestion,In Discussion | low | Critical |
568,738,373 | pytorch | Resnet 32x32 in caffe2 generates ResNet with wrong number of layers | ## Issue description
The generated 32x32 resnet model in `caffe2/python/models/resnet.py` does not reflect the architecture of He et al (2015). For example, if the num_groups parameter (supposedly `n` in He et al. 2015) is set to 3, it should generate ResNet18 having 6*n (+ 2) layers. However, it generates a network having 36 (+2) layers (thus ResNet36).
The bug is in line 256 of `https://github.com/pytorch/pytorch/blob/master/caffe2/python/models/resnet.py`
The line ` for blockidx in range(0, 2 * num_groups): ` should be `for blockidx in range(0, num_groups):` as each simple block already contains 2 conv layers.
| caffe2 | low | Critical |
568,748,795 | go | x/crypto/acme/autocert: Consider storing certificates as "*.pem" in DirCache | I recently implemented autocert to generate certificates; it works quite well for me :+1:
I did run in to one snag: the `DirCache` implementation stores the generated certificates as just the domain name; e.g. `test.example.com`, rather than `test.example.com.pem`.
I also use the generated certificates with an external TLS proxy (hitch), and loading the certificates like this isn't possible since it will errors out on non-certificate files like `acme_account+key`, which strikes me as reasonable behaviour on hitch's part.
If they would be stored as `*.pem` I could tell hitch to load only those files, which works.
I worked around this by wrapping the `DirCache` as below, but I think it might be reasonable to change the behaviour of `DirCache` to always do this?
```
// cache is like autocert.DirCache, but ensures that certificates end with .pem.
type cache struct{ dc autocert.DirCache }
func NewCache(dir string) cache { return cache{dc: autocert.DirCache(dir)} }
func (d cache) Get(ctx context.Context, key string) ([]byte, error) {
if !strings.Contains(key, "+") {
key += ".pem"
}
return d.dc.Get(ctx, key)
}
func (d cache) Delete(ctx context.Context, key string) error {
if !strings.Contains(key, "+") {
key += ".pem"
}
return d.dc.Delete(ctx, key)
}
func (d cache) Put(ctx context.Context, key string, data []byte) error {
if !strings.Contains(key, "+") {
key += ".pem"
}
return d.dc.Put(ctx, key, data)
}
``` | NeedsInvestigation | low | Critical |
568,762,662 | opencv | dnn(Scale): errornous handling of batch inputs in untrainable scale mode | ##### System information (version)
- OpenCV => 3.4
##### Detailed description
The untrainable mode in ScaleLayer uses the second input as scale factors for the first input.
```
outputs[0] = inputs[0] * inputs[1] // elementwise multiplication with broadcasting
```
The code which performs the above operation appears to assume that the batch size is one (but there is no assertion to enforce the requirement).
https://github.com/opencv/opencv/blob/3efa78311a837b7a06d81f2f359ca98e6d26609a/modules/dnn/src/layers/scale_layer.cpp#L86-L94
`weights` is reshaped (assuming that batch size is one?).
https://github.com/opencv/opencv/blob/3efa78311a837b7a06d81f2f359ca98e6d26609a/modules/dnn/src/layers/scale_layer.cpp#L98-L104
This code attempts to look for broadcasting options. It does so by attempting to match `numWeights` (which is `weights.total()`) to a subrange in the input tensor starting from `axis`. This logic will fail to find a match and depending on input shapes will either lead to incorrect outputs or tip-off downstream assertions
**Example:**
```
input shape: 2 3 3 3
weights input: 2 3 1 1
```
The shapes are compatible for an elementwise operation. The current logic will fail to see it.
`weights` is reshaped to `6 1`. The matching code tries to look for a subrange in the input `(2 3 3 3)` which totals to 6 but there is no such range.
This particular example triggers an assertion.
```
(-215:Assertion failed) start <= (int)shape.size() && end <= (int)shape.size() && start <= end in function 'total'
```
##### Steps to reproduce
A test for PR16436 (not merged yet) can reproduce it:
https://github.com/opencv/opencv/blob/a42268678eac90fb7d5f09d16e3a2db7167d2641/modules/dnn/test/test_darknet_importer.cpp#L547-L548
Change `testDarknetLayer("scale_channels", false, false);` to `testDarknetLayer("scale_channels", false, true);`
| bug,category: dnn | low | Critical |
568,769,986 | vscode | Cannot drag/drop file from VS Code to other apps due to invalid data object | Version: 1.42.1 (user setup)
Commit: c47d83b293181d9be64f27ff093689e8e7aed054
Date: 2020-02-11T14:45:59.656Z
Electron: 6.1.6
Chrome: 76.0.3809.146
Node.js: 12.4.0
V8: 7.6.303.31-electron.0
OS: Windows_NT x64 10.0.18363
## Steps to Reproduce:
Drag a file from _Explorer_ tool window and drop it onto:
### Visual Studio
1. Visual Studio's main window (with no editors open)
**Expected**: For VS to open the file
**Actual**: Get stop icon indicating the drag is not supported
2. C# project in Solution Explorer
**Expected**: For the file to be copied to the project
**Actual**: Get an drag icon indicating that a Copy will occur, but after dropping nothing happens --
### Outlook
3. Onto Outlook
**Expected**: New Email with file as attachment
**Actual** : Message Box with _Cannot copy the items_
### Excel
4. Drop it on Excel
Expected: File to be opened as text
Actual: Just the _file name_ is pasted into cell
Does this issue occur when all extensions are disabled?: Yes
## Background
I work on Visual Studio and debugged this from our side, and this is what I've found. We are expecting a format of CF_HDROP and doing the following pseudo code:
``` C#
var format = new FORMATETC
{
cfFormat = CF_HDROP,
ptd = IntPtr.Zero,
dwAspect = (uint)DVASPECT.DVASPECT_CONTENT,
lindex = -1,
tymed = (uint)TYMED.TYMED_HGLOBAL
};
var storage = default(STGMEDIUM);
if (dataObject.QueryGetData(format) == S_OK)
{
dataObject.GetData(format, storage) // "Invalid FORMATETC structure (0x80040064 - DV_E_FORMATETC)
}
```
QueryGetData is saying "I support this format", yet GetData is returning a HRESULT saying the format we just passed to QueryGetData is invalid. I suspect this is happening similarly in other applications. We have 4 or 5 places we look CF_HDROP and everyone of them fails.
I spent a little bit of time trying to figure out how VS Code produces CF_HDROP but to no avail. Could not find any code that looks like it puts a data object into the clipboard other than text. | feature-request,file-explorer | medium | Critical |
568,770,417 | godot | Undefined Behavior IAP. Transactions do not end. | **Godot version:** 3.2
**OS/device including version:** IOS (All version)
**Issue description:**
Transactions do not end.
This is not mentioned anywhere in the documentation.
**Steps to reproduce:**
If you make a purchase, it will not end.
"pop_pending_event" Will return a purchase every time.
**Minimal reproduction project:**
Source Code in Godot engine 3.2.
_in_app_store.mm_ : 31-45 line
see on var "_auto_finish_transactions_"
```objc++
#ifdef STOREKIT_ENABLED
#include "in_app_store.h"
extern "C" {
#import <Foundation/Foundation.h>
#import <StoreKit/StoreKit.h>
};
bool auto_finish_transactions = true; // <==== This code is misleading! In the constructor, it is reinitialized
NSMutableDictionary *pending_transactions = [NSMutableDictionary dictionary];
@interface SKProduct (LocalizedPrice)
@property(nonatomic, readonly) NSString *localizedPrice;
@end
...
```
in_app_store.mm : 314-322 line
see on var "_auto_finish_transactions_"
```objc++
InAppStore::InAppStore() {
ERR_FAIL_COND(instance != NULL);
instance = this;
auto_finish_transactions = false; // <==== SEEE
TransObserver *observer = [[TransObserver alloc] init];
[[SKPaymentQueue defaultQueue] addTransactionObserver:observer];
//pending_transactions = [NSMutableDictionary dictionary];
};
```
As you can see, in the constructor the variable becomes false.
But these methods are not documented: https://docs.godotengine.org/ru/latest/tutorials/platform/services_for_ios.html#purchase
```objc++
ClassDB::bind_method(D_METHOD("finish_transaction"), &InAppStore::finish_transaction);
ClassDB::bind_method(D_METHOD("set_auto_finish_transaction"), &InAppStore::set_auto_finish_transaction);
```
- -
I also ran into a problem that it is not possible to process deferred transactions through:
```objc
- (BOOL)paymentQueue:(SKPaymentQueue *)queue shouldAddStorePayment:(SKPayment *)payment forProduct:(SKProduct *)product
```
to use promotion: https://developer.apple.com/app-store/promoting-in-app-purchases/ | bug,platform:ios,topic:porting | low | Minor |
568,795,935 | TypeScript | tsconfig paths not work if dir name start with dot. | <!-- π¨ STOP π¨ π¦π§π’π£ π¨ πΊπ»πΆπ· π¨
Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Even if you think you've found a *bug*, please read the FAQ first, especially the Common "Bugs" That Aren't Bugs section!
Please help us by doing the following steps before logging an issue:
* Search: https://github.com/Microsoft/TypeScript/search?type=Issues
* Read the FAQ: https://github.com/Microsoft/TypeScript/wiki/FAQ
Please fill in the *entire* template below.
-->
<!--
Please try to reproduce the issue with the latest published version. It may have already been fixed.
For npm: `typescript@next`
This is also the 'Nightly' version in the playground: http://www.typescriptlang.org/play/?ts=Nightly
-->
**TypeScript Version:** 3.7.3
<!-- Search terms you tried before logging this (so others can find this issue more easily) -->
**Search Terms:**
**Code**
`./.temp/test`
```
export enum Test {
test
}
```
The following code does not work
```
import { Test } from '@temp/test'
```
```ts
paths: {
"@temp/*": [
"./.temp/*"
]
}
```
**Expected behavior:**
import not error tips.
**Actual behavior:**
**Playground Link:** <!-- A link to a TypeScript Playground "Share" link which demonstrates this behavior -->
**Related Issues:** <!-- Did you find other bugs that looked similar? -->
| Bug | low | Critical |
568,798,929 | godot | set_transform() doesn't work while mouse is moving |
**Godot version:**
3.2
**OS/device including version:**
Arch Linux & Windows 8.1, i7-6700, GTX 1070
**Issue description:**
If object.set_transform() is called while the mouse is moving, the object's transform may not be updated properly. Calling object.get_rotation() after object.set_transform() (even discarding get_rotation()'s result) seems to prevent the bug from happening.
**Steps to reproduce:**
Run the attached project. Drag the blue arrow with the mouse. Be sure to stop moving the mouse before releasing the mouse button. See that the arrow resets to its initial position.
Resetting the arrow is done by reset() in ArrowArea.gd. The relevant lines are:
```
onready var initial_transform = mesh.get_transform()
β¦
func reset():
mesh.set_transform(initial_transform)
other_area.mesh.set_transform(other_area.initial_transform)
```
Try dragging the arrow again, but this time release the mouse button while the mouse is still moving. See that the arrow doesn't reset properly.
Go into ArrowArea.gd and uncomment the last 2 get_rotation() lines. Run it and drag the arrow again. See that the arrow now resets properly, even if the mouse is still moving.
**Minimal reproduction project:**
~~[set-transform-bug.zip](https://github.com/godotengine/godot/files/4234857/set-transform-bug.zip)~~
*Bugsquad edit: Fixed project to avoid mixed indentation in scripts: [set-transform-bug.zip](https://github.com/godotengine/godot/files/4434902/set-transform-bug.zip)* | bug,topic:core,confirmed,topic:input | low | Critical |
568,812,420 | youtube-dl | Delay / missing videos in requested playlist vs actual youtube site | <!--
######################################################################
WARNING!
IGNORING THE FOLLOWING TEMPLATE WILL RESULT IN ISSUE CLOSED AS INCOMPLETE
######################################################################
-->
## Checklist
<!--
Carefully read and work through this check list in order to prevent the most common mistakes and misuse of youtube-dl:
- Look through the README (http://yt-dl.org/readme) and FAQ (http://yt-dl.org/faq) for similar questions
- Search the bugtracker for similar questions: http://yt-dl.org/search-issues
- Finally, put x into all relevant boxes (like this [x])
-->
- [x ] I'm asking a question
- [ x] I've looked through the README and FAQ for similar questions
- [x ] I've searched the bugtracker for similar questions including closed ones
## Question
<!--
Ask your question in an arbitrary form. Please make sure it's worded well enough to be understood, see https://github.com/ytdl-org/youtube-dl#is-the-description-of-the-issue-itself-sufficient.
-->
This question was previously marked as duplicate with no indication of the link or source to the duplicate question. Searching does not turn up a duplicate question. Is this issue resolvable?
Link to the dupe or the solution?
Thank you.
When requesting playlist items youtube-dl is missing several most recent videos compared to the actual youtube page. Some hours old. This happens on several youtube channels. Is there some sort of delay?
youtube-dl --playlist-items 1-3 -j --flat-playlist https://www.youtube.com/user/NHLVideo/videos
[debug] Command-line args: [u'-v', u'--playlist-items', u'1-3', u'-j', u'--flat-playlist', u'https://www.youtube.com/user/NHLVideo/videos']
[debug] Encodings: locale UTF-8, fs UTF-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2020.02.16
[debug] Python version 2.7.17 (CPython) - Linux-5.3.0-29-generic-x86_64-with-Ubuntu-19.10-eoan
[debug] exe versions: ffmpeg 4.1.4-1build2, ffprobe 4.1.4-1build2, phantomjs 26300, rtmpdump 2.4
| question | low | Critical |
568,844,203 | rust | current_exe() returns invalid path on linux when exe has been deleted | Calling `current_exe()` on linux after the original executable has been deleted or replaced results in an invalid path being returned.
```rust
fn main() {
// current_exe = /path/to/executable
remove_file(current_exe().unwrap()).ok();
println!("{:?}", current_exe());
}
```
### Output
`Ok("/path/to/executable (deleted)")`
### Desired behavior
While it is the correct behavior of the underlying `/proc/self/exe` to append the string ` (deleted)` to the original pathname the result is not a valid path and might even end up pointing to a completely different file.
I would either expect the docs to explicitly mention this behavior or classify it as an error and return `io::ErrorKind::NotFound` accordingly.
### Meta
<!--
If you're using the stable version of the compiler, you should also check if the
bug also exists in the beta or nightly versions.
-->
`rustc --version --verbose`:
```
rustc 1.41.0 (5e1a79984 2020-01-27)
binary: rustc
commit-hash: 5e1a799842ba6ed4a57e91f7ab9435947482f7d8
commit-date: 2020-01-27
host: x86_64-unknown-linux-gnu
release: 1.41.0
LLVM version: 9.0
```
I would gladly claim this issue if you agree to it.
| O-linux,T-libs-api,C-bug | low | Critical |
568,846,732 | godot | When an external editor is configured, script opens in the Godot script editor when double-clicking an error line | **Godot version:**
3.2 stable mono
**OS/device including version:**
win10 64
**Issue description:**
When you double click on an error report that indicates the script file, the script opens in the Godot editor creating inconsistencies in the scene execution.
I have everything configured correctly, I use VSCode.
**Steps to reproduce:**
1 - Cause an error like the one in the image.
2 - Double click on the line that informs the file that contains the script.
3 - Run the scene.
4 - A window will open automatically indicating something that does not apply, in the GIF casually did not appear.
5 - Note that the script was opened in the Godot code editor.
**Minimal reproduction project:**
[testPosicion.zip](https://github.com/godotengine/godot/files/4235326/testPosicion.zip)
| bug,topic:editor,confirmed,usability | low | Critical |
568,852,121 | PowerToys | Add option to turn ON/OFF Virtual Desktop zoneset inheritance from parent | When a new Virtual Desktop is created, FancyZones applies to it the same zoneset of the parent desktop.
This behavior may not be ideal for some users.
We should consider adding an option to turn ON/OFF this feature. | Idea-Enhancement,FancyZones-Settings,Product-FancyZones,Cost-Small,FancyZones-VirtualDesktop | low | Minor |
568,860,846 | opencv | dnn: mixed-precision inference and quantization | ##### System information (version)
- OpenCV => 4.2.0
##### Detailed description
The CUDA backend can support mixed-precision inference with various types: FP32, FP16, INT32, (U)INT8 and possibly INT4 and INT1. It's fairly easy to implement as cuDNN already has convolution primitives for many of these types and the existing CUDA backend codebase is fully template-based.
Before this can be implemented, some issues need to be sorted out:
1. Is it required?
2. APIs to configure mixed-precision
- APIs to allow the user to control the mixed-precision configuration
- ability to import quantized models and use the quantized weights during inference
Other ideas:
1. Default Mixed-precision policies
- example: fp16 for convolutions and fp32 for the rest?
2. Automatic Mixed-Precision
- the user provides a representative dataset and the AMP system automatically figures out a good configuration
- a similar thing would be required to implement in-house quantization
IE supports mixed-precision inference. A generic `cv::dnn` API for mixed-precision could be used for all the backends that support it.
| RFC,category: dnn | low | Major |
568,953,245 | TypeScript | If you pass a generic type argument to another generic type, constraints cannot be inferred correctly. | <!-- π¨ STOP π¨ π¦π§π’π£ π¨ πΊπ»πΆπ· π¨
Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Even if you think you've found a *bug*, please read the FAQ first, especially the Common "Bugs" That Aren't Bugs section!
Please help us by doing the following steps before logging an issue:
* Search: https://github.com/Microsoft/TypeScript/search?type=Issues
* Read the FAQ: https://github.com/Microsoft/TypeScript/wiki/FAQ
Please fill in the *entire* template below.
-->
**TypeScript Version:** 3.7.5
<!-- Search terms you tried before logging this (so others can find this issue more easily) -->
**Search Terms:**
Conditional types, Generics
**Expected behavior:**
No errors occur.
**Actual behavior:**
typescript compiler say "T that extends string does not extend string because string does not extend string."
<!-- Did you find other bugs that looked similar? -->
**Related Issues:**
**Code**
```ts
type ExtendsCheck<A extends B, B> = A;
// I want this function to handle not only strings but also numbers, boolean, etc.
type GetLiteralParent<T extends string> = T extends string ? string : never;
type Correct1 = ExtendsCheck<"test1" | "test2", GetLiteralParent<"test1" | "test2">>;
type Correct2 = ExtendsCheck<string, GetLiteralParent<string>>;
// Type 'T' does not satisfy the constraint 'GetLiteralParent<T>'.
// Type 'string' is not assignable to type 'GetLiteralParent<T>'.(2344)
type ErrorHappen<T extends string> = ExtendsCheck<T, GetLiteralParent<T>>;
```
<details><summary><b>Output</b></summary>
```ts
"use strict";
```
</details>
<details><summary><b>Compiler Options</b></summary>
```json
{
"compilerOptions": {
"noImplicitAny": true,
"strictNullChecks": true,
"strictFunctionTypes": true,
"strictPropertyInitialization": true,
"strictBindCallApply": true,
"noImplicitThis": true,
"noImplicitReturns": true,
"useDefineForClassFields": false,
"alwaysStrict": true,
"allowUnreachableCode": false,
"allowUnusedLabels": false,
"downlevelIteration": false,
"noEmitHelpers": false,
"noLib": false,
"noStrictGenericChecks": false,
"noUnusedLocals": false,
"noUnusedParameters": false,
"esModuleInterop": true,
"preserveConstEnums": false,
"removeComments": false,
"skipLibCheck": false,
"checkJs": false,
"allowJs": false,
"declaration": true,
"experimentalDecorators": false,
"emitDecoratorMetadata": false,
"target": "ES2017",
"module": "ESNext"
}
}
```
</details>
**Playground Link:** [Provided](https://www.typescriptlang.org/play/#code/C4TwDgpgBAogHsCA7AJgZwMIAsIGMDWAPAIJQQLLpQBCANDQHxQC8UxA3ALABQA9L1ACSUAO4BDJMCjAsASzRQAZgFckuYLID2SaZqhYJKADbQkmqdqMgoaYACdZSAOYKARsqlijaPUmUBbVwg7NHpXTU0TCXoIYFwAOh5QSCgAcViAGVlEOy8ABTE7ZGBCABUyClQFWwdnJlZy8kQqm3tHJygAflbajoAuKCQIADdgrm5k6AxNOyL1AEYWWEr0bDwiACJEW3mNqAAfKC2IWwAmDfp04Cyc-MLiwmOdvcOn4HOGBnHJqGnZvHeS3gzVWOAIhBq7UumWywTuRUkELadS+PB4-CgpXA0AA5KUcVAUJoToNzDYxBo0IprDJoLhtDUxI4pDirjc4UYCgiSqUGDjEnwBFiUjjIc4CfJSZ40GhZE4kGJXCZdNJsVBWTDbpz7ojefyABSnADMABYTQBKJJqmCzGYACTEYEgSDKFRB1WRTnqy3da3BpWh11huW13LKn3YQA)
| Bug | low | Critical |
568,959,700 | flutter | Missing grid layout in flutter | Flutter needs grid layout similar or same to CSS grid. In most cases we probably will not need to use this layout but if you need it then replacing it with Rows and Columns is just crazy. I found a package **flutter_layout_grid** but I honestly think that this should comes with flutter especially in web development | c: new feature,framework,P3,team-framework,triaged-framework | low | Minor |
569,045,744 | flutter | testing very simple GridView.count fails |
## Steps to Reproduce
This simple test fails
```dart
testWidgets('GridView.count', (tester) async {
await tester.pumpWidget(
MaterialApp(
home: GridView.count(
crossAxisCount: 1,
children: <Widget>[
Text('1'),
Text('2'),
Text('3'),
Text('4'),
],
),
),
);
expect(find.byType(Text), findsNWidgets(4));
});
```
the error message:
βββ‘ EXCEPTION CAUGHT BY FLUTTER TEST FRAMEWORK βββββββββββββββββββββββββββββββββββββββββββββββββββββ
The following TestFailure object was thrown running a test:
Expected: exactly 4 matching nodes in the widget tree
Actual: _WidgetTypeFinder:<exactly one widget with type "Text" (ignoring offstage widgets):
Text("1", dependencies: [MediaQuery, DefaultTextStyle])>
Which: is not enough
Flutter doctor :
[β] Flutter (Channel master, v1.14.7-pre.103, on Microsoft Windows [Version 10.0.18362.657], locale en-US)
[!] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
X Android license status unknown.
Try re-installing or updating your Android SDK Manager.
See https://developer.android.com/studio/#downloads or visit https://flutter.dev/setup/#android-setup for
detailed instructions.
[β] Chrome - develop for the web
[!] Android Studio (version 3.2)
X Flutter plugin not installed; this adds Flutter specific functionality.
X Dart plugin not installed; this adds Dart specific functionality.
[β] VS Code (version 1.42.0)
[β] Connected device (2 available)
| a: tests,framework,f: scrolling,has reproducible steps,P2,found in release: 3.3,found in release: 3.7,team-framework,triaged-framework | low | Critical |
569,050,799 | flutter | Flutter MethodChannel handler memory semantics are potentially confusing | https://b.corp.google.com/issues/149979662.
cc @chinmaygarde | engine,c: performance,d: api docs,customer: dream (g3),perf: memory,P3,team-engine,triaged-engine | low | Major |
569,066,385 | flutter | AnimatedIcon more_vert to arrow_back | The text selection overflow menu in native Android animates the icon transition between the 3 dot more_vert icon and arrow_back, so Flutter should do this too! However, it seems that [AnimatedIcons](https://master-api.flutter.dev/flutter/material/AnimatedIcons-class.html) doesn't support this transition. We should add it.
This is what native Android looks like:
<img width="250" src="https://user-images.githubusercontent.com/389558/62390332-dccf6c80-b516-11e9-80cb-22bb924ab070.gif" />
I noticed this when implementing the overflow menu in https://github.com/flutter/flutter/pull/49391. | c: new feature,framework,f: material design,a: fidelity,P3,team-text-input,triaged-text-input | low | Minor |
569,091,907 | rust | Occasional non-reproducibility when building rustc | Over the past few days I have occasionally seen my builds of rustc be non-reproducible. The differences most often seem to be in stage 1's libparking_log, librustc_parse, or librustc_driver.
A git bisect suggests that this was caused by 138c50f0af57e2631aa09092b826e2c3efd224d2, although due to the fact that this issue is itself difficult to reproduce this could potentially be incorrect. But after many builds with and without that patch, I have only seen the error with it. Assuming that is correct, I believe this issue might well be due to non-determinism in LLVM's `-O3`, but I'm not sure how to run just the LLVM portion on the compile so I'm not sure.
Note that this is a part of #34902. | T-compiler,C-bug,A-reproducibility | low | Critical |
569,104,805 | TypeScript | Type completions in jsDoc @augments and @implements tags. | ## Suggestion
Add code completions in jsDoc `@augments` and `@implements` clauses.
## Use Cases
Anybody using the new `@implements` and `@augments` jsDoc tags will benefit from this.
## Examples
Inside the `{}` triggering code completions should show types.
```ts
/**
* @augments {}
* @implements {}
*/
declare class B {
b(): void;
i(): void;
}
```
## Checklist
My suggestion meets these guidelines:
* [X] This wouldn't be a breaking change in existing TypeScript/JavaScript code
* [X] This wouldn't change the runtime behavior of existing JavaScript code
* [X] This could be implemented without emitting different JS based on the types of the expressions
* [X] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
* [X] This feature would agree with the rest of [TypeScript's Design Goals](https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals).
This is a flow-on from #36292 cc: @sandersn | Needs Investigation | low | Minor |
569,140,811 | flutter | Namespace collision with flutter_android_lifecycle | **This is the counter-issue I'm opening for the issue I have opened in the other repository: https://github.com/blackmenthor/flutter-android-lifecycle-plugin/issues/6 . I'm doing this to facilitate communication for both packages, if necessary.**
This is very unfortunate and I don't have a good solution for this. Personally, I'll be forking the other repository for a while and change the name until this has been "officially" resolved.
After updating the `image_picker` dependency (https://pub.dev/packages/image_picker), I am now getting this error:
```
...\app-name\android\app\src\main\java\io\flutter\plugins\GeneratedPluginRegistrant.java:17: error: a type with the same simple name is already defined by the single-type-import of FlutterAndroidLifecyclePlugin
import io.flutter.plugins.flutter_plugin_android_lifecycle.FlutterAndroidLifecyclePlugin;
```
(Because of this change in `image_picker`: https://github.com/flutter/plugins/commit/35957436b517793fa4cb568a3af6a1f054c7bdbb#diff-94aec143fa15896e4c8aca6854f7ecd7R19)
`...\app-name\android\app\src\main\java\io\flutter\plugins\GeneratedPluginRegistrant.java` looks like this:
```java
/**
* Generated file. Do not edit.
*/
public final class GeneratedPluginRegistrant {
public static void registerWith(PluginRegistry registry) {
if (alreadyRegisteredWith(registry)) {
return;
}
FlutterAndroidLifecyclePlugin.registerWith(registry.registrarFor("com.anggach.flutterandroidlifecycle.FlutterAndroidLifecyclePlugin"));
FlutterAndroidLifecyclePlugin.registerWith(registry.registrarFor("io.flutter.plugins.flutter_plugin_android_lifecycle.FlutterAndroidLifecyclePlugin"));
...
}
...
```
This package is the package with the competing namespace: https://pub.dev/packages/flutter_android_lifecycle
Again, this is super unfortunate because either you have to change the namespace of this package, or communicate with the maintainers of the other package to change it on their end. | platform-android,package,P3,p: flutter_plugin_android_lifecycle,team-android,triaged-android | low | Critical |
569,153,783 | rust | Possibly incorrect syntax `Enum::<Type, Params>::Variant` allowed since 1.33 | A coworker recently identified the following case:
```rust
pub enum Foo<'a, T> {
Struct {},
Tuple(),
Unit,
Usage(&'a T),
}
pub fn main() {
let foo = Foo::<String>::Unit;
let foo = Foo::<String>::Tuple();
let foo = Foo::<String>::Struct {};
}
```
[This used to fail because of the lack of implicit bound `T: 'a`](https://godbolt.org/z/-zUiCa):
```
error[E0309]: the parameter type `T` may not live long enough
--> <source>:5:11
|
1 | pub enum Foo<'a, T> {
| - help: consider adding an explicit lifetime bound `T: 'a`...
...
5 | Usage(&'a T),
| ^^^^^
|
note: ...so that the reference type `&'a T` does not outlive the data it points at
--> <source>:5:11
|
5 | Usage(&'a T),
| ^^^^^
```
[After fixing that, it complains about the type params](https://godbolt.org/z/HwCIEP):
```
error[E0109]: type parameters are not allowed on this type
--> <source>:8:21
|
8 | let foo = Foo::<String>::Unit;
| ^^^^^^ type parameter not allowed
error[E0109]: type parameters are not allowed on this type
--> <source>:9:21
|
9 | let foo = Foo::<String>::Tuple();
| ^^^^^^ type parameter not allowed
error[E0109]: type parameters are not allowed on this type
--> <source>:10:21
|
10 | let foo = Foo::<String>::Struct {};
| ^^^^^^ type parameter not allowed
```
[Starting in 1.33, all but the `Struct` path are accepted](https://godbolt.org/z/EO_SBq):
```
error[E0110]: lifetime arguments are not allowed on this entity
--> <source>:10:15
|
10 | let foo = Foo::<String>::Struct {};
| ^^^^^^^^^^^^^^^^^^^^^ lifetime argument not allowed
error[E0107]: wrong number of lifetime arguments: expected 1, found 0
--> <source>:10:15
|
10 | let foo = Foo::<String>::Struct {};
| ^^^^^^^^^^^^^^^^^^^^^ expected 1 lifetime argument
```
[The correct code for this would of course be](https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=2afe55bc512078a34ba3e37409d74902):
```rust
pub enum Foo<'a, T> {
Struct {},
Tuple(),
Unit,
Usage(&'a T),
}
pub fn main() {
let foo = Foo::Unit::<String>;
let foo = Foo::Tuple::<String>();
let foo = Foo::Struct::<String> {};
}
```
My questions:
- Was this change in behavior (accepting some of these paths) intended?
- If so, was it intended to deny only _one_ of these cases?
- If this change wasn't intended, should we try to reintroduce it or grandfather it in?
Depending on the answer to those questions, the solution to this ticket could be:
- Make the compiler accept the `let foo = Foo::Struct::<String> {};` case
- Deny all cases with a suggestion pointing at the right syntax
cc @Centril | A-type-system,P-medium,T-compiler,regression-from-stable-to-stable,C-bug,T-types | low | Critical |
569,156,033 | pytorch | Remove .data subset1 for fixathon | Even though it is not documented, many users still use it. And it leads to many bugs in user code.
So we should remove it completely to prevent this.
To do this, do one of:
1) [preferred] remove `.data`
2) [if possible] otherwise, replace with either `.detach()` or wrap in a `torch.no_grad` block
3) [otherwise] leave as is.
For 2), generally use whichever is nicer. `torch.no_grad()` is often clearer but is extra characters and is often done on another line. One place where you may have to use `.detach()` is in the return of a function, i.e.:
`return x.detach()` returns a tensor without a history. but:
```
with torch.no_grad():
return x
```
will return a tensor with history
For 3) This happens rarely, only if you explicitly don't want to share the version counter (e.g. because autograd would complain about the change but you happen to know it is okay, or the version counter is being explicitly tested).
The expected steps are:
- [ ] `benchmarks/`
- [ ] `docs/source/scripts/build_activation_images.py` and `docs/source/notes/extending.rst`
- [ ] `test/test_numba_integration.py`, `test/onnx/...`
- [ ] `torch/testing`
- [ ] `torch/utils/tensorboard/`
cc @ezyang @SsnL @albanD @zou3519 @gqchen | module: autograd,triaged,enhancement,better-engineering,actionable,fixathon | low | Critical |
569,165,269 | go | runtime: test hung in TestGdbAutotmpTypes | ```
go version devel +a224fa7fb9 Fri Feb 21 13:27:59 2020 -0500 linux/amd64
```
I ran `run.bash` on my local workstation to test https://golang.org/cl/211358, and got a `runtime` test failure that does not seem to be in any way related to the change β and looks an awful lot like a deadlock in `TestGdbAutotmpTypes`.
The test passed on a subsequent run.
I think there are two action items for this:
- [ ] Fix the test to emit some kind of useful diagnostic in case of a timeout. (That should be much easier now that the [`(*testing.T).Deadline`](https://tip.golang.org/pkg/testing/#T.Deadline) method is available.)
- [ ] Figure out the root cause of the deadlock and fix it.
CC @dr2chase @aclements
<details>
```
panic: test timed out after 9m0s
goroutine 154647 [running]:
panic(0x629de0, 0xc000b86010)
/usr/local/google/home/bcmills/go/src/runtime/panic.go:1060 +0x420 fp=0xc000258f88 sp=0xc000258ee0 pc=0x436890
testing.(*M).startAlarm.func1()
/usr/local/google/home/bcmills/go/src/testing/testing.go:1479 +0xdf fp=0xc000258fe0 sp=0xc000258f88 pc=0x4e9e4f
runtime.goexit()
/usr/local/google/home/bcmills/go/src/runtime/asm_amd64.s:1373 +0x1 fp=0xc000258fe8 sp=0xc000258fe0 pc=0x46dde1
created by time.goFunc
/usr/local/google/home/bcmills/go/src/time/sleep.go:168 +0x44
goroutine 1 [chan receive, 8 minutes, locked to thread]:
runtime.gopark(0x69d768, 0xc00008fc78, 0x170e, 0x2)
/usr/local/google/home/bcmills/go/src/runtime/proc.go:304 +0xe0 fp=0xc000050b60 sp=0xc000050b40 pc=0x4396a0
runtime.chanrecv(0xc00008fc20, 0x0, 0xc000415101, 0xc000080101)
/usr/local/google/home/bcmills/go/src/runtime/chan.go:525 +0x2e7 fp=0xc000050bf0 sp=0xc000050b60 pc=0x407807
runtime.chanrecv1(0xc00008fc20, 0x0)
/usr/local/google/home/bcmills/go/src/runtime/chan.go:407 +0x2b fp=0xc000050c20 sp=0xc000050bf0 pc=0x4074cb
testing.tRunner.func1(0xc0000de000)
/usr/local/google/home/bcmills/go/src/testing/testing.go:957 +0x238 fp=0xc000050cc8 sp=0xc000050c20 pc=0x4e9978
testing.tRunner(0xc0000de000, 0xc000050da8)
/usr/local/google/home/bcmills/go/src/testing/testing.go:996 +0x10b fp=0xc000050d18 sp=0xc000050cc8 pc=0x4e566b
testing.runTests(0xc0000a60a0, 0x870000, 0x153, 0x153, 0xbf8c2c32819f2ada, 0x7dba860a67, 0x873580, 0x203000)
/usr/local/google/home/bcmills/go/src/testing/testing.go:1298 +0x2d8 fp=0xc000050dd8 sp=0xc000050d18 pc=0x4e7028
testing.(*M).Run(0xc0000d8000, 0x0)
/usr/local/google/home/bcmills/go/src/testing/testing.go:1210 +0x1a7 fp=0xc000050ed0 sp=0xc000050dd8 pc=0x4e5f47
runtime_test.TestMain(0xc0000d8000)
/usr/local/google/home/bcmills/go/src/runtime/crash_test.go:28 +0x2f fp=0xc000050f20 sp=0xc000050ed0 pc=0x57ef3f
main.main()
_testmain.go:1192 +0x135 fp=0xc000050f88 sp=0xc000050f20 pc=0x604fd5
runtime.main()
/usr/local/google/home/bcmills/go/src/runtime/proc.go:203 +0x212 fp=0xc000050fe0 sp=0xc000050f88 pc=0x4392c2
runtime.goexit()
/usr/local/google/home/bcmills/go/src/runtime/asm_amd64.s:1373 +0x1 fp=0xc000050fe8 sp=0xc000050fe0 pc=0x46dde1
goroutine 2 [force gc (idle), 2 minutes]:
runtime.gopark(0x69da78, 0x872da0, 0x1411, 0x1)
/usr/local/google/home/bcmills/go/src/runtime/proc.go:304 +0xe0 fp=0xc000042fb0 sp=0xc000042f90 pc=0x4396a0
runtime.goparkunlock(...)
/usr/local/google/home/bcmills/go/src/runtime/proc.go:310
runtime.forcegchelper()
/usr/local/google/home/bcmills/go/src/runtime/proc.go:253 +0xb7 fp=0xc000042fe0 sp=0xc000042fb0 pc=0x439557
runtime.goexit()
/usr/local/google/home/bcmills/go/src/runtime/asm_amd64.s:1373 +0x1 fp=0xc000042fe8 sp=0xc000042fe0 pc=0x46dde1
created by runtime.init.6
/usr/local/google/home/bcmills/go/src/runtime/proc.go:242 +0x35
goroutine 3 [GC sweep wait]:
runtime.gopark(0x69da78, 0x8731c0, 0x140c, 0x1)
/usr/local/google/home/bcmills/go/src/runtime/proc.go:304 +0xe0 fp=0xc0000437a8 sp=0xc000043788 pc=0x4396a0
runtime.goparkunlock(...)
/usr/local/google/home/bcmills/go/src/runtime/proc.go:310
runtime.bgsweep(0xc000018150)
/usr/local/google/home/bcmills/go/src/runtime/mgcsweep.go:89 +0x131 fp=0xc0000437d8 sp=0xc0000437a8 pc=0x424fc1
runtime.goexit()
/usr/local/google/home/bcmills/go/src/runtime/asm_amd64.s:1373 +0x1 fp=0xc0000437e0 sp=0xc0000437d8 pc=0x46dde1
created by runtime.gcenable
/usr/local/google/home/bcmills/go/src/runtime/mgc.go:214 +0x5c
goroutine 4 [GC scavenge wait]:
runtime.gopark(0x69da78, 0x873180, 0x140d, 0x1)
/usr/local/google/home/bcmills/go/src/runtime/proc.go:304 +0xe0 fp=0xc000043f78 sp=0xc000043f58 pc=0x4396a0
runtime.goparkunlock(...)
/usr/local/google/home/bcmills/go/src/runtime/proc.go:310
runtime.bgscavenge(0xc000018150)
/usr/local/google/home/bcmills/go/src/runtime/mgcscavenge.go:285 +0x20f fp=0xc000043fd8 sp=0xc000043f78 pc=0x42366f
runtime.goexit()
/usr/local/google/home/bcmills/go/src/runtime/asm_amd64.s:1373 +0x1 fp=0xc000043fe0 sp=0xc000043fd8 pc=0x46dde1
created by runtime.gcenable
/usr/local/google/home/bcmills/go/src/runtime/mgc.go:215 +0x7e
goroutine 18 [finalizer wait, 6 minutes]:
runtime.gopark(0x69da78, 0x89d5a0, 0xc0000d1410, 0x1)
/usr/local/google/home/bcmills/go/src/runtime/proc.go:304 +0xe0 fp=0xc0001b4758 sp=0xc0001b4738 pc=0x4396a0
runtime.goparkunlock(...)
/usr/local/google/home/bcmills/go/src/runtime/proc.go:310
runtime.runfinq()
/usr/local/google/home/bcmills/go/src/runtime/mfinal.go:175 +0xa3 fp=0xc0001b47e0 sp=0xc0001b4758 pc=0x41ab83
runtime.goexit()
/usr/local/google/home/bcmills/go/src/runtime/asm_amd64.s:1373 +0x1 fp=0xc0001b47e8 sp=0xc0001b47e0 pc=0x46dde1
created by runtime.createfing
/usr/local/google/home/bcmills/go/src/runtime/mfinal.go:156 +0x61
goroutine 23445 [chan send, 8 minutes]:
runtime.gopark(0x69d768, 0xc00008fdf8, 0x62160f, 0x2)
/usr/local/google/home/bcmills/go/src/runtime/proc.go:304 +0xe0 fp=0xc000254e20 sp=0xc000254e00 pc=0x4396a0
runtime.chansend(0xc00008fda0, 0xc000254f0f, 0xc00008e001, 0x4e9a93, 0x69f8e0)
/usr/local/google/home/bcmills/go/src/runtime/chan.go:236 +0x22d fp=0xc000254ea0 sp=0xc000254e20 pc=0x406bed
runtime.chansend1(0xc00008fda0, 0xc000329f0f)
/usr/local/google/home/bcmills/go/src/runtime/chan.go:127 +0x35 fp=0xc000254ed8 sp=0xc000254ea0 pc=0x4069b5
testing.tRunner.func1(0xc0003f7e60)
/usr/local/google/home/bcmills/go/src/testing/testing.go:982 +0x353 fp=0xc000254f80 sp=0xc000254ed8 pc=0x4e9a93
testing.tRunner(0xc0003f7e60, 0x69ec28)
/usr/local/google/home/bcmills/go/src/testing/testing.go:996 +0x10b fp=0xc000254fd0 sp=0xc000254f80 pc=0x4e566b
runtime.goexit()
/usr/local/google/home/bcmills/go/src/runtime/asm_amd64.s:1373 +0x1 fp=0xc000254fd8 sp=0xc000254fd0 pc=0x46dde1
created by testing.(*T).Run
/usr/local/google/home/bcmills/go/src/testing/testing.go:1043 +0x357
goroutine 23444 [chan send, 8 minutes]:
runtime.gopark(0x69d768, 0xc00008fd38, 0x62160f, 0x2)
/usr/local/google/home/bcmills/go/src/runtime/proc.go:304 +0xe0 fp=0xc000180e20 sp=0xc000180e00 pc=0x4396a0
runtime.chansend(0xc00008fce0, 0xc000180f0f, 0xc00008e001, 0x4e9a93, 0x69f8e0)
/usr/local/google/home/bcmills/go/src/runtime/chan.go:236 +0x22d fp=0xc000180ea0 sp=0xc000180e20 pc=0x406bed
runtime.chansend1(0xc00008fce0, 0xc00032bf0f)
/usr/local/google/home/bcmills/go/src/runtime/chan.go:127 +0x35 fp=0xc000180ed8 sp=0xc000180ea0 pc=0x4069b5
testing.tRunner.func1(0xc0003f7d40)
/usr/local/google/home/bcmills/go/src/testing/testing.go:982 +0x353 fp=0xc000180f80 sp=0xc000180ed8 pc=0x4e9a93
testing.tRunner(0xc0003f7d40, 0x69ec20)
/usr/local/google/home/bcmills/go/src/testing/testing.go:996 +0x10b fp=0xc000180fd0 sp=0xc000180f80 pc=0x4e566b
runtime.goexit()
/usr/local/google/home/bcmills/go/src/runtime/asm_amd64.s:1373 +0x1 fp=0xc000180fd8 sp=0xc000180fd0 pc=0x46dde1
created by testing.(*T).Run
/usr/local/google/home/bcmills/go/src/testing/testing.go:1043 +0x357
goroutine 23443 [syscall, 8 minutes]:
syscall.Syscall6(0xf7, 0x1, 0x1e307, 0xc0003259d8, 0x1000004, 0x0, 0x0, 0x6dafe8, 0x40, 0xc000325a18)
/usr/local/google/home/bcmills/go/src/syscall/asm_linux_amd64.s:41 +0x5 fp=0xc000325988 sp=0xc000325980 pc=0x4ada75
os.(*Process).blockUntilWaitable(0xc0005303f0, 0x203000, 0x422d55, 0x1)
/usr/local/google/home/bcmills/go/src/os/wait_waitid.go:31 +0x98 fp=0xc000325a78 sp=0xc000325988 pc=0x4c2f68
os.(*Process).wait(0xc0005303f0, 0x69d560, 0x69d568, 0x69d558)
/usr/local/google/home/bcmills/go/src/os/exec_unix.go:22 +0x39 fp=0xc000325af0 sp=0xc000325a78 pc=0x4be309
os.(*Process).Wait(...)
/usr/local/google/home/bcmills/go/src/os/exec.go:125
os/exec.(*Cmd).Wait(0xc0002d6000, 0x0, 0x0)
/usr/local/google/home/bcmills/go/src/os/exec/exec.go:502 +0x60 fp=0xc000325b68 sp=0xc000325af0 pc=0x527f70
os/exec.(*Cmd).Run(0xc0002d6000, 0xc0002d4240, 0xc0002d6000)
/usr/local/google/home/bcmills/go/src/os/exec/exec.go:340 +0x5c fp=0xc000325b90 sp=0xc000325b68 pc=0x52740c
os/exec.(*Cmd).CombinedOutput(0xc0002d6000, 0x3, 0xc000325e68, 0xf, 0xf, 0xc0002d6000)
/usr/local/google/home/bcmills/go/src/os/exec/exec.go:562 +0x91 fp=0xc000325bc0 sp=0xc000325b90 pc=0x5282c1
runtime_test.TestGdbAutotmpTypes(0xc0003f7c20)
/usr/local/google/home/bcmills/go/src/runtime/runtime-gdb_test.go:463 +0x822 fp=0xc000325f80 sp=0xc000325bc0 pc=0x5d20f2
testing.tRunner(0xc0003f7c20, 0x69ec10)
/usr/local/google/home/bcmills/go/src/testing/testing.go:992 +0xdc fp=0xc000325fd0 sp=0xc000325f80 pc=0x4e563c
runtime.goexit()
/usr/local/google/home/bcmills/go/src/runtime/asm_amd64.s:1373 +0x1 fp=0xc000325fd8 sp=0xc000325fd0 pc=0x46dde1
created by testing.(*T).Run
/usr/local/google/home/bcmills/go/src/testing/testing.go:1043 +0x357
goroutine 144644 [GC worker (idle)]:
runtime.gopark(0x69d880, 0xc0002cb8d0, 0xc0002e1418, 0x0)
/usr/local/google/home/bcmills/go/src/runtime/proc.go:304 +0xe0 fp=0xc0002e4760 sp=0xc0002e4740 pc=0x4396a0
runtime.gcBgMarkWorker(0xc00002f000)
/usr/local/google/home/bcmills/go/src/runtime/mgc.go:1865 +0xff fp=0xc0002e47d8 sp=0xc0002e4760 pc=0x41e58f
runtime.goexit()
/usr/local/google/home/bcmills/go/src/runtime/asm_amd64.s:1373 +0x1 fp=0xc0002e47e0 sp=0xc0002e47d8 pc=0x46dde1
created by runtime.gcBgMarkStartWorkers
/usr/local/google/home/bcmills/go/src/runtime/mgc.go:1813 +0x77
goroutine 144641 [GC worker (idle)]:
runtime.gopark(0x69d880, 0xc000f47c90, 0xc0001b1418, 0x0)
/usr/local/google/home/bcmills/go/src/runtime/proc.go:304 +0xe0 fp=0xc0001b3760 sp=0xc0001b3740 pc=0x4396a0
runtime.gcBgMarkWorker(0xc000031800)
/usr/local/google/home/bcmills/go/src/runtime/mgc.go:1865 +0xff fp=0xc0001b37d8 sp=0xc0001b3760 pc=0x41e58f
runtime.goexit()
/usr/local/google/home/bcmills/go/src/runtime/asm_amd64.s:1373 +0x1 fp=0xc0001b37e0 sp=0xc0001b37d8 pc=0x46dde1
created by runtime.gcBgMarkStartWorkers
/usr/local/google/home/bcmills/go/src/runtime/mgc.go:1813 +0x77
goroutine 144640 [GC worker (idle), 2 minutes]:
runtime.gopark(0x69d880, 0xc000f478e0, 0xc000641418, 0x0)
/usr/local/google/home/bcmills/go/src/runtime/proc.go:304 +0xe0 fp=0xc000646760 sp=0xc000646740 pc=0x4396a0
runtime.gcBgMarkWorker(0xc00002c800)
/usr/local/google/home/bcmills/go/src/runtime/mgc.go:1865 +0xff fp=0xc0006467d8 sp=0xc000646760 pc=0x41e58f
runtime.goexit()
/usr/local/google/home/bcmills/go/src/runtime/asm_amd64.s:1373 +0x1 fp=0xc0006467e0 sp=0xc0006467d8 pc=0x46dde1
created by runtime.gcBgMarkStartWorkers
/usr/local/google/home/bcmills/go/src/runtime/mgc.go:1813 +0x77
goroutine 147342 [IO wait, 8 minutes]:
runtime.gopark(0x69da30, 0x7f0cb8a45a90, 0xc000501b02, 0x5)
/usr/local/google/home/bcmills/go/src/runtime/proc.go:304 +0xe0 fp=0xc0004864d0 sp=0xc0004864b0 pc=0x4396a0
runtime.netpollblock(0x7f0cb8a45a68, 0x72, 0xc000268120)
/usr/local/google/home/bcmills/go/src/runtime/netpoll.go:419 +0x9a fp=0xc000486508 sp=0xc0004864d0 pc=0x43238a
internal/poll.runtime_pollWait(0x7f0cb8a45a68, 0x72, 0xffffffffffffffff)
/usr/local/google/home/bcmills/go/src/runtime/netpoll.go:203 +0x55 fp=0xc000486530 sp=0xc000486508 pc=0x431955
internal/poll.(*pollDesc).wait(0xc000380738, 0x72, 0x401, 0x4e0, 0xffffffffffffffff)
/usr/local/google/home/bcmills/go/src/internal/poll/fd_poll_runtime.go:87 +0x45 fp=0xc000486560 sp=0xc000486530 pc=0x4b93d5
internal/poll.(*pollDesc).waitRead(...)
/usr/local/google/home/bcmills/go/src/internal/poll/fd_poll_runtime.go:92
internal/poll.(*FD).Read(0xc000380720, 0xc000268120, 0x4e0, 0x4e0, 0x0, 0x0, 0x0)
/usr/local/google/home/bcmills/go/src/internal/poll/fd_unix.go:169 +0x19b fp=0xc0004865d0 sp=0xc000486560 pc=0x4b9ddb
os.(*File).read(...)
/usr/local/google/home/bcmills/go/src/os/file_unix.go:263
os.(*File).Read(0xc0000b4028, 0xc000268120, 0x4e0, 0x4e0, 0x14, 0x0, 0x0)
/usr/local/google/home/bcmills/go/src/os/file.go:116 +0x71 fp=0xc000486640 sp=0xc0004865d0 pc=0x4be9f1
bytes.(*Buffer).ReadFrom(0xc0002d4240, 0x6e5980, 0xc0000b4028, 0x7f0cb80a41d0, 0xc0002d4240, 0x70000000063c601)
/usr/local/google/home/bcmills/go/src/bytes/buffer.go:204 +0xb1 fp=0xc0004866b0 sp=0xc000486640 pc=0x4d73a1
io.copyBuffer(0x6e5780, 0xc0002d4240, 0x6e5980, 0xc0000b4028, 0x0, 0x0, 0x0, 0xffffffffffffffff, 0xc0004867b8, 0x5eebb6)
/usr/local/google/home/bcmills/go/src/io/io.go:391 +0x2fc fp=0xc000486728 sp=0xc0004866b0 pc=0x4a3e1c
io.Copy(...)
/usr/local/google/home/bcmills/go/src/io/io.go:364
os/exec.(*Cmd).writerDescriptor.func1(0x2f, 0xc00087a000)
/usr/local/google/home/bcmills/go/src/os/exec/exec.go:310 +0x63 fp=0xc0004867a0 sp=0xc000486728 pc=0x528f33
os/exec.(*Cmd).Start.func1(0xc0002d6000, 0xc0002420e0)
/usr/local/google/home/bcmills/go/src/os/exec/exec.go:436 +0x27 fp=0xc0004867d0 sp=0xc0004867a0 pc=0x528fb7
runtime.goexit()
/usr/local/google/home/bcmills/go/src/runtime/asm_amd64.s:1373 +0x1 fp=0xc0004867d8 sp=0xc0004867d0 pc=0x46dde1
created by os/exec.(*Cmd).Start
/usr/local/google/home/bcmills/go/src/os/exec/exec.go:435 +0x608
goroutine 144660 [chan send, 8 minutes]:
runtime.gopark(0x69d768, 0xc000024418, 0x62160f, 0x2)
/usr/local/google/home/bcmills/go/src/runtime/proc.go:304 +0xe0 fp=0xc0010ece20 sp=0xc0010ece00 pc=0x4396a0
runtime.chansend(0xc0000243c0, 0xc0010ecf0f, 0xc00008e001, 0x4e9a93, 0x69f8e0)
/usr/local/google/home/bcmills/go/src/runtime/chan.go:236 +0x22d fp=0xc0010ecea0 sp=0xc0010ece20 pc=0x406bed
runtime.chansend1(0xc0000243c0, 0xc0010ecf0f)
/usr/local/google/home/bcmills/go/src/runtime/chan.go:127 +0x35 fp=0xc0010eced8 sp=0xc0010ecea0 pc=0x4069b5
testing.tRunner.func1(0xc0000de6c0)
/usr/local/google/home/bcmills/go/src/testing/testing.go:982 +0x353 fp=0xc0010ecf80 sp=0xc0010eced8 pc=0x4e9a93
testing.tRunner(0xc0000de6c0, 0x69eb08)
/usr/local/google/home/bcmills/go/src/testing/testing.go:996 +0x10b fp=0xc0010ecfd0 sp=0xc0010ecf80 pc=0x4e566b
runtime.goexit()
/usr/local/google/home/bcmills/go/src/runtime/asm_amd64.s:1373 +0x1 fp=0xc0010ecfd8 sp=0xc0010ecfd0 pc=0x46dde1
created by testing.(*T).Run
/usr/local/google/home/bcmills/go/src/testing/testing.go:1043 +0x357
goroutine 144658 [GC worker (idle)]:
runtime.gopark(0x69d880, 0xc000f47ca0, 0xc0002e1418, 0x0)
/usr/local/google/home/bcmills/go/src/runtime/proc.go:304 +0xe0 fp=0xc0002eef60 sp=0xc0002eef40 pc=0x4396a0
runtime.gcBgMarkWorker(0xc000036800)
/usr/local/google/home/bcmills/go/src/runtime/mgc.go:1865 +0xff fp=0xc0002eefd8 sp=0xc0002eef60 pc=0x41e58f
runtime.goexit()
/usr/local/google/home/bcmills/go/src/runtime/asm_amd64.s:1373 +0x1 fp=0xc0002eefe0 sp=0xc0002eefd8 pc=0x46dde1
created by runtime.gcBgMarkStartWorkers
/usr/local/google/home/bcmills/go/src/runtime/mgc.go:1813 +0x77
goroutine 144645 [GC worker (idle)]:
runtime.gopark(0x69d880, 0xc0002cb8e0, 0xc000521418, 0x0)
/usr/local/google/home/bcmills/go/src/runtime/proc.go:304 +0xe0 fp=0xc00052cf60 sp=0xc00052cf40 pc=0x4396a0
runtime.gcBgMarkWorker(0xc000034000)
/usr/local/google/home/bcmills/go/src/runtime/mgc.go:1865 +0xff fp=0xc00052cfd8 sp=0xc00052cf60 pc=0x41e58f
runtime.goexit()
/usr/local/google/home/bcmills/go/src/runtime/asm_amd64.s:1373 +0x1 fp=0xc00052cfe0 sp=0xc00052cfd8 pc=0x46dde1
created by runtime.gcBgMarkStartWorkers
/usr/local/google/home/bcmills/go/src/runtime/mgc.go:1813 +0x77
goroutine 143713 [chan receive, 8 minutes]:
runtime.gopark(0x69d768, 0xc00008e178, 0x170e, 0x2)
/usr/local/google/home/bcmills/go/src/runtime/proc.go:304 +0xe0 fp=0xc0002e5ef8 sp=0xc0002e5ed8 pc=0x4396a0
runtime.chanrecv(0xc00008e120, 0x0, 0x69d801, 0xc000025d40)
/usr/local/google/home/bcmills/go/src/runtime/chan.go:525 +0x2e7 fp=0xc0002e5f88 sp=0xc0002e5ef8 pc=0x407807
runtime.chanrecv1(0xc00008e120, 0x0)
/usr/local/google/home/bcmills/go/src/runtime/chan.go:407 +0x2b fp=0xc0002e5fb8 sp=0xc0002e5f88 pc=0x4074cb
testing.runTests.func1.1(0xc0000de000)
/usr/local/google/home/bcmills/go/src/testing/testing.go:1305 +0x3b fp=0xc0002e5fd8 sp=0xc0002e5fb8 pc=0x4e9c5b
runtime.goexit()
/usr/local/google/home/bcmills/go/src/runtime/asm_amd64.s:1373 +0x1 fp=0xc0002e5fe0 sp=0xc0002e5fd8 pc=0x46dde1
created by testing.runTests.func1
/usr/local/google/home/bcmills/go/src/testing/testing.go:1305 +0xac
goroutine 143587 [chan send, 8 minutes]:
runtime.gopark(0x69d768, 0xc0004e6718, 0x62160f, 0x2)
/usr/local/google/home/bcmills/go/src/runtime/proc.go:304 +0xe0 fp=0xc000256e20 sp=0xc000256e00 pc=0x4396a0
runtime.chansend(0xc0004e66c0, 0xc000256f0f, 0xc00008e001, 0x4e9a93, 0x69f8e0)
/usr/local/google/home/bcmills/go/src/runtime/chan.go:236 +0x22d fp=0xc000256ea0 sp=0xc000256e20 pc=0x406bed
runtime.chansend1(0xc0004e66c0, 0xc000256f0f)
/usr/local/google/home/bcmills/go/src/runtime/chan.go:127 +0x35 fp=0xc000256ed8 sp=0xc000256ea0 pc=0x4069b5
testing.tRunner.func1(0xc0003f65a0)
/usr/local/google/home/bcmills/go/src/testing/testing.go:982 +0x353 fp=0xc000256f80 sp=0xc000256ed8 pc=0x4e9a93
testing.tRunner(0xc0003f65a0, 0x69f460)
/usr/local/google/home/bcmills/go/src/testing/testing.go:996 +0x10b fp=0xc000256fd0 sp=0xc000256f80 pc=0x4e566b
runtime.goexit()
/usr/local/google/home/bcmills/go/src/runtime/asm_amd64.s:1373 +0x1 fp=0xc000256fd8 sp=0xc000256fd0 pc=0x46dde1
created by testing.(*T).Run
/usr/local/google/home/bcmills/go/src/testing/testing.go:1043 +0x357
goroutine 124685 [GC worker (idle)]:
runtime.gopark(0x69d880, 0xc0000b0040, 0xc000471418, 0x0)
/usr/local/google/home/bcmills/go/src/runtime/proc.go:304 +0xe0 fp=0xc000475f60 sp=0xc000475f40 pc=0x4396a0
runtime.gcBgMarkWorker(0xc00002a000)
/usr/local/google/home/bcmills/go/src/runtime/mgc.go:1865 +0xff fp=0xc000475fd8 sp=0xc000475f60 pc=0x41e58f
runtime.goexit()
/usr/local/google/home/bcmills/go/src/runtime/asm_amd64.s:1373 +0x1 fp=0xc000475fe0 sp=0xc000475fd8 pc=0x46dde1
created by runtime.gcBgMarkStartWorkers
/usr/local/google/home/bcmills/go/src/runtime/mgc.go:1813 +0x77
FAIL runtime 540.043s
```
</details> | NeedsInvestigation,compiler/runtime | low | Critical |
569,176,281 | react | Bug: Unexpected render | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
https://stackoverflow.com/questions/60345064/react-hooks-rendering-cause
I'm playing with simple React components to understand when rendering occurs.
## The current behavior
[Sample 1][1] - Initially renders once. Regardless of the number of times the button is clicked, it doesn't render. This is expected.
import React, { useState } from "react";
import "./styles.css";
export default function App() {
const [state, setState] = useState([
{ id: 1, name: "test1" },
{ id: 2, name: "test2" }
]);
const onClick = () => setState(data => data);
console.log("App rendered");
return (
<div className="App">
<h1>Test if setting same data causes re-rendering</h1>
<button onClick={onClick}>Call setState with same data</button>
{state.map(({ id, name }) => (
<p key={id}>{name}</p>
))}
</div>
);
}
[Sample 2][2] - Initially renders twice since `useEffect` updates `setMessages` with a value. This is expected. However, if the button is click 1+ times, it renders once. It shouldn't even re-render since the same value is being set. **Why is it rendering if no new value / reference is being updated?**
import React, { useState, useEffect, useMemo, useCallback } from "react";
import axios from "axios";
import "./styles.css";
const days = [
"Sunday",
"Monday",
"Tuesday",
"Wednesday",
"Thursday",
"Friday",
"Saturday"
];
export default function App() {
const [messages, setMessages] = useState([]);
useEffect(() => {
axios
.get(`https://api.myjson.com/bins/10xva4`)
.then(({ data: { messages } }) => setMessages(messages));
}, []);
const Display = useMemo(
() =>
messages.map(({ content, senderUuid, sentAt }, index) => {
let d = new Date(sentAt);
return (
<div className="container" key={index}>
<p>Content: {content}</p>
<p>SenderUuid: {senderUuid}</p>
<p>DayOfTheWeek: {d.getDate()}</p>
<p>Month: {d.getMonth()}</p>
<p>Day: {days[d.getDay()]}</p>
<p>Year: {d.getFullYear()}</p>
</div>
);
}),
[messages]
);
const onClick = useCallback(() => setMessages(messages => messages), []);
console.log("App rendered");
// console.log({ messages });
return useMemo(
() => (
<div className="App">
<button onClick={onClick}>Call setMessages with same data</button>
{Display}
</div>
),
[Display, onClick]
);
}
[1]: https://codesandbox.io/s/testing-rendering-bo9bp
[2]: https://codesandbox.io/s/call-api-with-useeffect-vlo34
<!--
Your bug will get fixed much faster if we can run your code and it doesn't
have dependencies other than React. Issues without reproduction steps or
code examples may be immediately closed as not actionable.
-->
## The expected behavior
Should not re-render if no new value or reference is updated.
| Type: Bug | medium | Critical |
569,180,819 | pytorch | bitmapToFloat32Tensor() 1 channel Tensor [feature] [mobile] | ## π Feature
``bitmapToFloat32Tensor`` with 1 channel Tensor as return.
## Motivation
While trying to bring my project to android I noticed that there is only a function for RGB / 3 channel Tensors so far, which does not work for my 1 channel input ConvNet.
## Pitch
Add ``TensorImageUtils.bitmapToFloat32Tensor`` with 1 channel Tensor as return. (android)
e.g.: ``shape: [1, 1, 1280, 960]``
## Additional context
Since it is not a particularly extensive or complex feature, I have already tried it locally.
https://github.com/Unity05/pytorch/blob/master/android/pytorch_android_torchvision/src/main/java/org/pytorch/torchvision/TensorImageUtils.java | oncall: mobile,oncall: java | low | Minor |
569,187,821 | vscode | Cannot load any extensions in extensions marketplace in visual studio code on imac catalina | <!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ -->
<!-- Please search existing issues to avoid creating duplicates. -->
<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: https://code.visualstudio.com/insiders/ -->
<!-- Use Help > Report Issue to prefill these. -->
- VSCode Version:Version: 1.42.1
Commit: c47d83b293181d9be64f27ff093689e8e7aed054
Date: 2020-02-11T14:44:27.652Z
Electron: 6.1.6
Chrome: 76.0.3809.146
Node.js: 12.4.0
V8: 7.6.303.31-electron.0
OS: Darwin x64 19.3.0
- OS Version: macOS Catalina 10.15.3 (19D76)
Steps to Reproduce:
1. double click or open visual studio code in either dock OR in applications folder.
2. go to extensions marketplace by clicking on the icon.
<!-- Launch with `code --disable-extensions` to check. -->
Does this issue occur when all extensions are disabled?: Yes/No
There are no extensions extant yet. This is a brand new download out of the box.
Here's a screen recording of what happens.
[Screen Recording 2020-02-21 at 4.05.27 PM 480.mov.zip](https://github.com/microsoft/vscode/files/4238065/Screen.Recording.2020-02-21.at.4.05.27.PM.480.mov.zip)
# Extra notes
This is a fresh install of vs code on a freshly updated mac OS system | bug,proxy | low | Major |
569,192,160 | flutter | Relax stable ordering of backing stores given to the embedder for presentation. | This will improve render target cache utilization. This optimization must be made when an internal embedder migrates to be resilient to this optimization.
Pessimization added in https://github.com/flutter/engine/pull/16711 for b/146142979. | engine,c: performance,e: embedder,customer: dream (g3),perf: memory,P3,team-engine,triaged-engine | low | Minor |
569,193,029 | flutter | Collect unused render targets before asking the embedder to create updated targets. | This will reduce peak memory usage. This optimization must be made when an internal embedder migrates to be resilient to this optimization.
Pessimization added in https://github.com/flutter/engine/pull/16711 for b/146142979. | engine,c: performance,e: embedder,customer: dream (g3),perf: memory,P3,team-engine,triaged-engine | low | Major |
569,222,187 | go | cmd/link: -X does not work on variables with non-constant default values | ### What version of Go are you using (`go version`)?
<pre>
$ go version
go version go1.14rc1 darwin/amd64
</pre>
### Does this issue reproduce with the latest release?
This is a regression in Go 1.14rc1. It does not reproduce in 1.13.8.
### What operating system and processor architecture are you using (`go env`)?
<details><summary><code>go env</code> Output</summary><br><pre>
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/jayconrod/Library/Caches/go-build"
GOENV="/Users/jayconrod/Library/Application Support/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOINSECURE=""
GONOPROXY=""
GONOSUMDB=""
GOOS="darwin"
GOPATH="/Users/jayconrod/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/opt/go/installed"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/opt/go/installed/pkg/tool/darwin_amd64"
GCCGO="gccgo"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD="/Users/jayconrod/Code/test/tmp2/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/rq/x0692kqj6ml8cvrhcqh5bswc008xj1/T/go-build343063917=/tmp/go-build -gno-record-gcc-switches -fno-common"
</pre></details>
### What did you do?
Run the testscript below:
```
go run -ldflags='-X=example.com/test/stamp.STAMP=pass' ./main
stdout pass
-- go.mod --
module example.com/test
go 1.14
-- main/main.go --
package main
import (
"fmt"
"example.com/test/stamp"
)
func main() {
fmt.Printf("STAMP = %s\n", stamp.STAMP)
}
-- stamp/stamp.go --
package stamp
var DEFAULT = "fail"
var STAMP = DEFAULT
```
### What did you expect to see?
The program should print `STAMP = pass`, and the test should pass.
### What did you see instead?
The program prints `STAMP = fail`.
This only happens when `STAMP` is assigned to another variable. The test passes if `STAMP` is assigned the value `"fail"` instead of `DEFAULT`.
### Other thoughts
I've milestoned this Go1.14 and added the Soon label because this is a regression. It should be triaged before the 1.14 release.
I don't know if this was intended to work before. If not, feel free to close.
If it was intended to work, I'm not sure whether this should block 1.14.
| NeedsInvestigation | low | Critical |
569,229,439 | react | Arbitrary log lines may appear in between an error and the subsequent "The above errorβ¦" message | React version: 16.12
If one component throws, and one of its siblings logs something else to the console, that sibling's logs appear in between the throwing component and the extra React information about that throw.
This is hard to explain in words but easy to explain in code and pictures, so look:
Repro: https://codesandbox.io/s/boring-firefly-bu79e
The third log line ("The aboveβ¦") refers to the first ("Uncaughtβ¦") but looks like it refers to the second ("Please don'tβ¦"). This is confusing when debugging.
Instead, I would expect "The above errorβ¦" to be right below the uncaught window-level exception we raise. (Maybe this isn't possible without diverging dev vs. prod behavior? Not sure but thought I'd fileβ¦) | Type: Bug | low | Critical |
569,247,363 | go | x/build/maintner: Maintner does not detect transferred issues | Related to #30184.
Maintner's sync loop uses a ListIssues call sorted by update time to determine which issues it needs to re-fetch issue data and event data for. Deleted issues and transferred issues don't show up in the ListIssues response, Maintner is never aware that they're gone, and ultimately those issues are frozen in the corpus in the state they had before they were deleted/transferred. They are never marked NotExist (tombstoned). https://go-review.googlesource.com/c/build/+/161521/ is an insufficient fix for this reason.
https://go-review.googlesource.com/c/build/+/205598 proposes exposing a mutation method so an external process can inform Maintner of the deleted/transferred issues, but that requires an external process (also, see other comments on that CL).
I think a better solution would be for Maintner, during its issue sync, to pull repository events up to the GitHub poller's lastUpdated timestamp, looking specifically for issue transfer and issue delete events, and tombstoning (mark as `NotExist`) the appropriate issues before moving onto the regular issue sync.
The difficulty will be for repos that are already being synced, this doesn't provide a way to go back in time and handle previous deletes/transfers, which, the external process _would_ be capable of doing.
/cc @bradfitz @dmitshur @orthros | Builders,NeedsInvestigation | low | Minor |
569,264,537 | flutter | Element should have a "design discussion" section talking about build order | We should document some of our design decisions about how widgets build:
* The framework guarantees that ancestors build before descendants.
* The framework does not guarantee anything about the order other than this.
* Some widgets might in rare cases build twice, this is considered an aberration to be avoided (layout builder that ends up dirty both at the widget layer and the layout layer is the example).
* One pass build.
Maybe point to "Inside Flutter" (https://flutter.dev/docs/resources/inside-flutter). | framework,d: api docs,P2,team-framework,triaged-framework | low | Minor |
569,276,430 | terminal | Pane focus movement doesn't remember where it came from | # Steps to reproduce
create a vertical split, then on the right pane, create a horizontal split
somewhat like this :
```
|-----------|
| | 2 |
| 1 |______|
| | 3 |
|____|______|
```
if you move focus from 1 to 2 by moveFocus right
then move focus from 2 to 3 by moveFocus down
then move focus from 3 to 1 by moveFocus left
then moveFocus right
# Expected behavior
The focus should go back to 3. Otherwise toggling between 1 and 3 becomes a painful, especially if 2 is ends up more complicated with more panes.
# Actual behavior
focus goes to 2
| Help Wanted,Issue-Bug,Area-UserInterface,Product-Terminal,Priority-2 | low | Major |
569,279,624 | flutter | EditableText does not call onEditingComplete on focus loss (macOS) | On desktop operating systems, it's typical for certain types of focus loss (via mouse input or keyboard navigation) to commit a text field's value, but Flutter's `EditableText` widget does not invoke the equivalent lifecycle method, `onEditingComplete`, in this situation. It appears that the only way to invoke the method on desktop is through an enter press.
I believe this to be in error, as the mobile equivalent to a tab/shift+tab press (`TextInputAction.next`, `TextInputAction.previous`) invokes `onEditingComplete`.
cc @gspencergoog | a: text input,framework,platform-mac,a: desktop,has reproducible steps,P2,found in release: 3.3,found in release: 3.7,fyi-text-input,team-macos,triaged-macos | low | Critical |
569,297,041 | pytorch | master build error |
```
/pytorch/caffe2/opt/onnxifi_op.h:259:37: error: invalid conversion from βuint32_t {aka unsigned int}β to βvoid*β [-fpermissive]
static_cast<uint32_t>(max_seq_size_),
^
/media/jinn/netac/permanent/software/source_codes/dl/pytorch/c10/util/Logging.h:222:61: note: in definition of macro βCAFFE_ENFORCE_THAT_IMPLβ
const EnforceFailMessage& CAFFE_ENFORCE_THAT_IMPL_r_ = (condition); \
^~~~~~~~~
/media/jian/netac/permanent/software/source_codes/dl/pytorch/caffe2/opt/onnxifi_op.h:250:7: note: in expansion of macro βCAFFE_ENFORCE_EQβ
CAFFE_ENFORCE_EQ(
^~~~~~~~~~~~~~~~
/media//netac/permanent/software/source_codes/dl/pytorch/c10/util/Logging.h:254:33: error: too many arguments to function
CAFFE_ENFORCE_THAT_IMPL(Equals((x), (y)), #x " == " #y, __VA_ARGS__)
^
/media//netac/permanent/software/source_codes/dl/pytorch/c10/util/Logging.h:222:61: note: in definition of macro βCAFFE_ENFORCE_THAT_IMPLβ
const EnforceFailMessage& CAFFE_ENFORCE_THAT_IMPL_r_ = (condition); \
^~~~~~~~~
/media//netac/permanent/software/source_codes/dl/pytorch/caffe2/opt/onnxifi_op.h:250:7: note: in expansion of macro βCAFFE_ENFORCE_EQβ
CAFFE_ENFORCE_EQ(
^~~~~~~~~~~~~~~~
[ 66%] Building CXX object caffe2/CMakeFiles/torch_cpu.dir/opt/shape_info.cc.o
In file included from /usr/include/c++/6/memory:79:0,
from /media//netac/permanent/software/source_codes/dl/pytorch/third_party/protobuf/src/google/protobuf/stubs/common.h:41,
from /media//netac/permanent/software/source_codes/dl/pytorch/build/third_party/onnx/onnx/onnx_onnx_torch-ml.pb.h:9,
from /media/jintn/netac/permanent/software/source_codes/dl/pytorch/build/third_party/onnx/onnx/onnx-ml.pb.h:2,
from /media/jinian/netac/permanent/software/source_codes/dl/pytorch/third_party/onnx/onnx/onnx_pb.h:50,
from /media/netac/permanent/software/source_codes/dl/pytorch/caffe2/opt/onnxifi_op.h:5,
from /media/netac/permanent/software/source_codes/dl/pytorch/caffe2/opt/onnxifi_op.cc:1:
/usr/include/c++/6/functional:2106:7: error: βstd::function<_Res(_ArgTypes ...)>::function(_Functor) [with _Functor = caffe2::OnnxifiOp<Context>::buildBackendAndGraph(caffe2::Workspace*, const std::vector<long unsigned int, std::allocator<long unsigned int> >&, const string&) [with Context = caffe2::CPUContext; std::__cxx11::string = std::__cxx11::basic_string<char>]::<lambda()>; <template-parameter-2-2> = void; <template-parameter-2-3> = void; _Res = std::shared_ptr<caffe2::onnx::BackendGraphInfo>; _ArgTypes = {}]β, declared using local type βcaffe2::OnnxifiOp<Context>::buildBackendAndGraph(caffe2::Workspace*, const std::vector<long unsigned int, std::allocator<long unsigned int> >&, const string&) [with Context = caffe2::CPUContext; std::__cxx11::string = std::__cxx11::basic_string<char>]::<lambda()>β, is used but never defined [-fpermissive]
function<_Res(_ArgTypes...)>::
^~~~~~~~~~~~~~~~~~~~~~~~~~~~
caffe2/CMakeFiles/torch_cpu.dir/build.make:9835: recipe for target 'caffe2/CMakeFiles/torch_cpu.dir/opt/onnxifi_op.cc.o' failed
make[2]: *** [caffe2/CMakeFiles/torch_cpu.dir/opt/onnxifi_op.cc.o] Error 1
``` | caffe2 | low | Critical |
569,303,139 | flutter | Flutter video_player widget doesn't fit into the parent widget. | Hello,
Greetings!.
I'm using a carouselslider widget under which I've added aspectratio widget followed by video_player widget. But, for some videos, video_player flows outside the carousel widget.
P.S.: Reference to issue no. #48854
-----------------------------------------------------------------------------------
_**Please refer the screenshot for reference:-**_
<img src="https://user-images.githubusercontent.com/61319375/75089118-978a8f00-557b-11ea-92b0-d2358f5773b3.jpeg" height="500"/>
-----------------------------------------------------------------------------------
_**Flutter doctor:-**_
```
[β] Flutter (Channel dev, v1.13.0, on Linux, locale en_GB.UTF-8)
β’ Flutter version 1.13.0 at /home/neville/Projects/flutter
β’ Framework revision 09126abb22 (3 months ago), 2019-12-03 17:43:00 -0800
β’ Engine revision 6179380243
β’ Dart version 2.7.0 (build 2.7.0-dev.2.1 a4d799c402)
[β] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
β’ Android SDK at /home/neville/Android/Sdk
β’ Android NDK location not configured (optional; useful for native profiling support)
β’ Platform android-29, build-tools 29.0.2
β’ Java binary at: /home/neville/Projects/android-studio/jre/bin/java
β’ Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405)
β’ All Android licenses accepted.
[β] Android Studio (version 3.5)
β’ Android Studio at /home/neville/Projects/android-studio
β’ Flutter plugin version 42.0.1
β’ Dart plugin version 191.8593
β’ Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405)
[β] VS Code (version 1.41.1)
β’ VS Code at /usr/share/code
β’ Flutter extension version 3.8.1
[β] Connected device (1 available)
β’ Mi A2 β’ f04cdaad β’ android-arm64 β’ Android 9 (API 28)
β’ No issues found!
```
--------------------------------------------------------------------------------------
_**Following is the code:-**_
<details>
<summary>sample code </summary>
```
import 'dart:async';
import 'package:flutter/material.dart';
import 'package:flutter_widgets/flutter_widgets.dart';
import 'package:video_player/video_player.dart';
class VideoPlayerScreen extends StatefulWidget {
final String videoUrl;
VideoPlayerScreen({@required this.videoUrl, Key key}) : super(key: key);
@override
_VideoPlayerScreenState createState() => _VideoPlayerScreenState();
}
class _VideoPlayerScreenState extends State {
VideoPlayerController _controller;
Future _initializeVideoPlayerFuture;
bool _volumeUp = true;
var _scaffoldKey = new GlobalKey();
var a;
@override
void initState() {
// Create and store the VideoPlayerController. The VideoPlayerController
// offers several different constructors to play videos from assets, files,
// or the internet.
_controller = VideoPlayerController.network(widget.videoUrl);
// Initialize the controller and store the Future for later use.
_initializeVideoPlayerFuture = _controller.initialize();
_controller.addListener(checkIfVideoFinished);
super.initState();
}
void checkIfVideoFinished() {
if (_controller.value.position == _controller.value.duration) {
_controller.removeListener(checkIfVideoFinished);
setState(() {
_controller.pause();
});
}
}
@override
void dispose() {
// Ensure disposing of the VideoPlayerController to free up resources.
_controller.removeListener(checkIfVideoFinished);
_controller.dispose();
super.dispose();
}
@override
Widget build(BuildContext context) {
return VisibilityDetector(
key: _scaffoldKey,
onVisibilityChanged: (VisibilityInfo info) {
if (info.visibleFraction < 1.0) {
if (_controller.value.isPlaying) {
if (this.mounted) {
setState(() {
_controller.pause();
});
}
}
}
// debugPrint( widget.videoUrl + "\n ${info.visibleFraction} of my widget is visible");
},
child: Stack(
children: [
FutureBuilder(
future: _initializeVideoPlayerFuture,
builder: (context, snapshot) {
if (snapshot.connectionState == ConnectionState.done) {
// If the VideoPlayerController has finished initialization, use
// the data it provides to limit the aspect ratio of the video.
return Align(
alignment: Alignment.center,
child: AspectRatio(
aspectRatio: 4 / 3,
child: VideoPlayer(_controller),
),
);
} else {
// If the VideoPlayerController is still initializing, show a
// loading spinner.
return Center(child: CircularProgressIndicator());
}
},
),
Align(
alignment: Alignment.bottomRight,
child: Container(
color: Colors.black87.withOpacity(0.3),
child: Row(
mainAxisSize: MainAxisSize.min,
children: [
IconButton(
icon: Icon(
_controller.value.isPlaying
? Icons.pause
: Icons.play_arrow,
),
color: Colors.white,
onPressed: () {
if (_controller.value.isPlaying) {
setState(() {
_controller.pause();
});
_controller.removeListener(checkIfVideoFinished);
} else {
setState(() {
_controller.play();
});
_controller.addListener(checkIfVideoFinished);
}
},
),
IconButton(
icon: Icon(
_volumeUp ? Icons.volume_up : Icons.volume_off,
),
color: Colors.white,
onPressed: () {
setState(() {
if (_volumeUp) {
_controller.setVolume(0.0);
_volumeUp = false;
} else {
_controller.setVolume(1.0);
_volumeUp = true;
}
});
},
),
],
),
),
),
],
),
);
}
}
```
</details> | platform-android,customer: solaris,p: video_player,package,has reproducible steps,P2,found in release: 2.2,team-android,triaged-android | low | Critical |
569,303,425 | go | x/mobile: build failing when using go modules | ### What version of Go are you using (`go version`)?
<pre>
x/mobile: build failing when using go modules #37048
</pre>
### Does this issue reproduce with the latest release?
yes
### What operating system and processor architecture are you using (`go env`)?
<details><summary><code>go env</code> Output</summary><br><pre>
x/mobile: build failing when using go modules #37048</pre></details>
### What did you do?
gomobile failed with 'nrecognized command line option '-marm'' and second run on same code gives different output ' cannot determine module path for source directory' this issue related to previous one #37048
```
gcc: error: unrecognized command line option '-marm'; did you mean '-mabm'?
```
second run (same command: gomobile bind)
```
gomobile: go build -buildmode=c-shared -o=/tmp/gomobile-work-515390264/android/src/main/jniLibs/armeabi/libgojni.so ./gobind failed: exit status 1
go: cannot determine module path for source directory /tmp/gomobile-work-515390264/src (outside GOPATH, module path must be specified)
Example usage:
'go mod init example.com/m' to initialize a v0 or v1 module
'go mod init example.com/m/v2' to initialize a v2 module
Run 'go help mod init' for more information.
```
commands:
```
# git clone -b dev https://gitlab.com/axet/libtorrent
# gomobile bind
``` | NeedsInvestigation,mobile | low | Critical |
569,305,490 | go | x/net/http2: client can't fully utilize network resource | <!--
Please answer these questions before submitting your issue. Thanks!
For questions please use one of our forums: https://github.com/golang/go/wiki/Questions
-->
### What version of Go are you using (`go version`)?
<pre>
$ go version
go version go1.13.6 darwin/amd64
</pre>
### Does this issue reproduce with the latest release?
Yes
### What operating system and processor architecture are you using (`go env`)?
<details><summary><code>go env</code> Output</summary><br><pre>
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/jayden/Library/Caches/go-build"
GOENV="/Users/jayden/Library/Application Support/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GONOPROXY=""
GONOSUMDB=""
GOOS="darwin"
GOPATH="/Users/jayden/Workspace/GoProject"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/darwin_amd64"
GCCGO="gccgo"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD="/Users/jayden/Workspace/GoProject/src/golang.org/x/net/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/j1/94761d9d49j6gz5p55375sbr0000gn/T/go-build875938892=/tmp/go-build -gno-record-gcc-switches -fno-common"
</pre></details>
### What did you do?
I ran an http2 webdav server and I made a client with golang x/net/http2 for a test.
The client uploaded a 1 MB file infinitely with a few hundred goroutine.
MaxConcurrentStreams of the server was 100 and StrictMaxConcurrentStreams of the client was false.
I measured the throughput between the server and the client on AWS.
And network bandwidth between the server and the client was 150 Gbps in the infrastructure level.
### What did you expect to see?
I expected that the throughput would be around 150 Gbps.
### What did you see instead?
The measured throughput was 90 Gbps.
### Proposal
I figured out what caused this. I modified the http2 connection pool a little as shown in the below link.
(https://github.com/ochanism/net/commit/b2cc93d427fb3b5dc0bc42be8c8943d76f35eaf3)
With the above code, I could achieve 150 Gbps throughput.
For achieving high throughput, multiple TCP connections are needed.
But the current version of the http2 connection pool increases TCP connections only when there is no available TCP connection (CurrentMaxStreams == MaxConcurrentStreams for all the connections).
I reduced MaxConcurrentStreams value at the server-side, but the number of TCP connections wasn't increased than I expected.
So I added a MinConcurrentConns field to http2 Transport.
MinConcurrentConns is the minimum number of TCP connections and ClientConnPool tries to maintain MinConcurrentConns TCP connections at least. If 0, ClientConnPool creates a TCP connection only when needed.
Please review my proposal.
| NeedsInvestigation | low | Critical |
569,308,363 | rust | Scoping rules for tail expressions leads to unexpected compiler error | <!--
Thank you for filing a bug report! π Please provide a short summary of the bug,
along with any information you feel relevant to replicating the bug.
-->
I tried this code: [playground](https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=efbf3a046a8d1801cc3559ba28331368)
```rust
use tokio::sync::{Mutex, RwLock};
struct InnerUser {
file_handle: Mutex<u64>,
}
struct Foo(RwLock<InnerUser>);
impl Foo {
async fn try_set_lock0(&self) -> Result<(), u32> {
let guard = self.0.read().await;
if let Ok(_) = guard.file_handle.try_lock() {
Ok(())
} else {
Err(2)
}
}
async fn try_set_lock1(&self) -> Result<(), u32> {
let guard = self.0.read().await;
let ret = if let Ok(_) = guard.file_handle.try_lock() {
Ok(())
} else {
Err(2)
};
ret
}
}
```
I expected to see this happen:
compile success
Instead, this happened:
the first function report error
```
Compiling playground v0.0.1 (/playground)
error[E0597]: `guard` does not live long enough
--> src/lib.rs:12:24
|
12 | if let Ok(_) = guard.file_handle.try_lock() {
| ^^^^^-----------------------
| |
| borrowed value does not live long enough
| a temporary with access to the borrow is created here ...
...
17 | }
| -
| |
| `guard` dropped here while still borrowed
| ... and the borrow might be used here, when that temporary is dropped and runs the destructor for type `std::result::Result<tokio::sync::mutex::MutexGuard<'_, u64>, tokio::sync::mutex::TryLockError>`
|
= note: The temporary is part of an expression at the end of a block. Consider forcing this temporary to be dropped sooner, before the block's local variables are dropped. For example, you could save the expression's value in a new local variable `x` and then make `x` be the expression at the end of the block.
error: aborting due to previous error
For more information about this error, try `rustc --explain E0597`.
error: could not compile `playground`.
To learn more, run the command again with --verbose.
```
### Meta
<!--
If you're using the stable version of the compiler, you should also check if the
bug also exists in the beta or nightly versions.
-->
`rustc --version --verbose`:
```
rustc 1.43.0-nightly (8aa9d2014 2020-02-21)
binary: rustc
commit-hash: 8aa9d2014f4e5258f83b907e8431c59a33acdae7
commit-date: 2020-02-21
host: x86_64-unknown-linux-gnu
release: 1.43.0-nightly
LLVM version: 9.0
playground is stable 1.41.0
```
| T-lang,A-maybe-future-edition | low | Critical |
569,314,543 | flutter | Textfield content disapears when text is too long |
http://pub.waves.pw/ms/textfield.mp4
[β] Flutter (Channel stable, v1.12.13+hotfix.8, on Linux, locale en_US.UTF-8)
β’ Flutter version 1.12.13+hotfix.8 at /home/renan/code/flutter
β’ Framework revision 0b8abb4724 (11 days ago), 2020-02-11 11:44:36 -0800
β’ Engine revision e1e6ced81d
β’ Dart version 2.7.0
[β] Android toolchain - develop for Android devices (Android SDK version 29.0.3)
β’ Android SDK at /home/renan/Android/Sdk
β’ Android NDK location not configured (optional; useful for native profiling support)
β’ Platform android-29, build-tools 29.0.3
β’ Java binary at: /home/renan/code/android-studio/jre/bin/java
β’ Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405)
β’ All Android licenses accepted.
[β] Android Studio (version 3.5)
β’ Android Studio at /home/renan/code/android-studio
β’ Flutter plugin version 43.0.1
β’ Dart plugin version 191.8593
β’ Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405)
[β] VS Code (version 1.42.1)
β’ VS Code at /usr/share/code
β’ Flutter extension version 3.8.1
[β] Connected device (1 available)
β’ Pixel 3a β’ 9BCAY1J68Q β’ android-arm64 β’ Android 10 (API 29)
β’ No issues found!
| a: text input,c: regression,framework,f: material design,has reproducible steps,found in release: 3.3,found in release: 3.7,team-text-input | medium | Critical |
569,321,994 | flutter | Need to find how much of a long word could fit in one line before an unnatural line break | As described in issue #35994, there are a number of use cases for doing non rectangular LTR or RTL text layout. Although not convenient, it is possible to do custom text layout by breaking a string into short runs and measuring each run as a `Paragraph` itself before painting it at some desired location. A word/line breaker would make this easier (see issue #50171), but for general cases breaking at a space works OK.
A problem arises, though, when there is text run that is longer than the available length for the line. Take the following example:
```
aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa
```
There are no spaces to break at. That means that you have to measure every character or use some algorithm to test chunks of various lengths to see how much of it will fit. An unnatural break will be inserted at that location. The rest of the run will continue onto the next line.
A further complication is that some languages (like Mongolian and Arabic) use different size glyphs depending on the context. For example, here is a Mongolian word rendered correctly on the left, but the same word with the characters as they would look in isolation.
The size is obviously different so simply taking the sum of the size of each character is not a viable option to find the length. Even taking a substring of the long word and measuring it would be different because the character at the break point would think it was at a final rather than a medial position and thus return the wrong size. A workaround would be to insert a Zero Width Joiner at the break point before measuring, but this is a lot of extra work compared to the feature request below.
## Feature request
It would be very useful to have a feature like Android's `Paint.breakText` (see [example](https://stackoverflow.com/questions/45253574/does-paint-breaktext-include-the-character-at-the-maxwidth)). You feed it a string and a max length, and it tells you how many characters of that string will fit within the specified length. | a: text input,framework,a: typography,c: proposal,P3,team-framework,triaged-framework | low | Major |
569,329,186 | godot | Camera near clip value can't be negative in inspector | **Godot version:**
3.2
**OS/device including version:**
Win 10 / Dell Precision 4700
**Issue description:**
I was unable to set the camera near clipping value to a negative number resulting in a visible clip problem. Negative values are prohibited by the inspector but are settable via .set_znear(-1000). I believe the editor should allow negative values as a negative near clip is desirable for setting up an isometric camera.
**Steps to reproduce:**
1. Add a camera to a scene
2. Set perspective to orthagonal
3. Attempt to enter a negative number in a camera's near clip field in the godot editor. The value mins at 0.01 instead of allowing a negative value
**Minimal reproduction project:**
not applicable
Thank you for your consideration of this change and thank you for a fantastic game engine. | enhancement,topic:rendering,topic:3d | medium | Major |
569,333,341 | godot | C# ToSignal() leading to possible crashes in release builds | **Godot version:**
3.2 Stable (Mono)
**OS/device including version:**
Windows 10
**Issue description:**
When an instance is disposed while a function is awaiting within in, it can lead to the game crashing with a System.ObjectDisposedException.
After looking through the source code it appears like the await call will continue executing in release builds (leading to the crash later down the road), however in debug builds it simply halts with an error message. This inconsistency has caused errors in release builds that were otherwise harder to trace during development. I believe it would be much more beneficial if ToSignal() would always stop executing in both debug and release mode, as the alternative fix to this issue would be to clutter your code with calls to `Object.IsInstanceValid()` after every `await` statement.
**Steps to reproduce:**
Simply free (or queue free) a node in which a ToSignal() call is currently awaiting. After the ToSignal() call completes, accessing any of the nodes methods will result in the game crashing in release builds.
**Minimal reproduction project:**
[project.zip](https://github.com/godotengine/godot/files/4239387/project.zip)
| bug,topic:dotnet | low | Critical |
569,365,913 | flutter | [google_maps_flutter] Please clarify why API KEY in source code is OK | For those familiar with [API Key Best Practices](https://developers.google.com/maps/api-key-best-practices), the instructions for [Android](https://pub.dev/packages/google_maps_flutter#android) and [iOS](https://pub.dev/packages/google_maps_flutter#ios) make some nervous because it basically instructs them to store an API KEY in the source tree when there is an explicit rule against this practice: [Do not store API keys or signing secrets in files inside your application's source tree](https://developers.google.com/maps/api-key-best-practices#no_store_apikey).
Can the **documentation** be revised to explain why this is OK? | d: stackoverflow,p: maps,package,team-ecosystem,P3,triaged-ecosystem | medium | Critical |
569,368,631 | pytorch | torch.rand() not having same values on using torch.manual_seed(0) | ```
print(torch.rand(batch_size, classes))
print(torch.rand(batch_size, classes))
```
printing it same, twice
This does not produce the same results on setting the seed `torch.manual_seed(0)` | triaged,module: random | low | Minor |
569,378,684 | go | cmd/go: build -o dir ./... should build (and discard) non main packages | <!-- Please answer these questions before submitting your issue. Thanks! -->
### What version of Go are you using (`go version`)?
<pre>
$ go version
go version go1.14rc1 linux/amd64
</pre>
### Does this issue reproduce with the latest release?
Yes.
### What operating system and processor architecture are you using (`go env`)?
<details><summary><code>go env</code> Output</summary><br><pre>
$ go env
GO111MODULE="on"
GOARCH="amd64"
GOBIN="/home/manlio/.local/bin"
GOCACHE="/home/manlio/.cache/go-build"
GOENV="/home/manlio/.config/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/home/manlio/.local/lib/go:/home/manlio/src/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/home/manlio/sdk/go1.14rc1"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/home/manlio/sdk/go1.14rc1/pkg/tool/linux_amd64"
GCCGO="gccgo"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="/dev/null"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build397314077=/tmp/go-build -gno-record-gcc-switches"
GOROOT/bin/go version: go version go1.14rc1 linux/amd64
GOROOT/bin/go tool compile -V: compile version go1.14rc1
uname -sr: Linux 5.5.4-arch1-1
/usr/lib/libc.so.6: GNU C Library (GNU libc) stable release version 2.31.
gdb --version: GNU gdb (GDB) 9.1
</pre></details>
### What did you do?
I have a module, with a *main* package in the module root directory and another package in a subdirectory.
A `.go` file in the nested package has a syntax error.
I ran the following commands
```
go build ./...
```
```
go build -o build/ ./...
```
### What did you expect to see?
Both commands to report an error
```
# github.com/perillo/go-init/internal/data
internal/data/data.go:12:25: syntax error: unexpected { after top level declaration
```
### What did you see instead?
Only the first command reports the syntax error.
| NeedsDecision | medium | Critical |
569,391,640 | godot | Editor Settings > Run > Window Placement > Screen: Doesn't Work | ___
***Bugsquad note:** This issue has been confirmed several times already. No need to confirm it further.*
___
**Godot version:**
v3.2.stable.official
**OS/device including version:**
macOS Catalina Version 10.15.2
**Issue description:**
I want to use the "Editor Settings > Run > Window Placement > Screen" setting to make Godot run my game on a specific screen, specifically my laptop. However, no matter what I change the setting to, the game runs on my external monitor.
**Steps to reproduce:**
1. Use external monitor.
2. Change Editor Settings > Run > Window Placement > Screen to any setting.
3. Game always runs on external monitor, not laptop, when using Cmd + B shortcut.
**Minimal reproduction project:**
Any project with one scene.
| bug,topic:editor,confirmed | low | Critical |
569,392,141 | rust | instance_def_size_estimate is not that good at estimating | when trying to see what the problem was with https://github.com/rust-lang/rust/issues/66617
I noticed that the llvm-ir did not match the estimate e.g. core::ptr::drop_in_place
actual number of llvm-ir lines 17170 and the estimated size 24 so 715x larger then estimated.
this results in that when the CGUs shall be merged the CGU that contains these functions is merged multipel times and result in one CGU that is mush larger then the other and due to this the compile time is longer then needed.
have seen that especially core::ptr::drop_in_place have many x to smal estimates in real crates also.
I used a debug build of rustc to be able to trace and used the example from https://github.com/rust-lang/rust/issues/66617
`RUSTC_LOG=rustc_mir::monomorphize::partitioning=debug rustc +stage2 --emit=llvm-ir -Cno-prepopulate-passes main.rs` to get llvm-ir and see the estimates.
I expected the estimate to be nere the actual number of llvm-ir lines for the functions.
one strange thing is that there is a lot of estimates that is 0 and that is not that common to have so feels like faults.
also some estimates is larger then the lines of llvm-ir e.g. `actual: 5370 Estimated: 9129 diff: -3759 alloc::alloc::box_free`
the rustc version is built from 03d2f5cd6c634b1fdcd26b036009aa4dce37fdfc
<details><summary>Some more not that good estimates</summary>
<p>
```
actual: 1074 Estimated: 1432 diff: -358 core::ptr::unique::Unique<T>::cast
actual: 46 Estimated: 34 diff: 12 core::ptr::slice_from_raw_parts_mut
actual: 14 Estimated: 10 diff: 4 core::alloc::Layout::from_size_align_unchecked
actual: 68 Estimated: 48 diff: 20 <alloc::vec::Vec<T> as core::ops::index::IndexMut<I>>::index_mut
actual: 20 Estimated: 13 diff: 7 core::num::<impl usize>::saturating_mul
actual: 22 Estimated: 34 diff: -12 <alloc::vec::Vec<T> as core::ops::deref::DerefMut>::deref_mut
actual: 5 Estimated: 8 diff: -3 <alloc::alloc::Global as core::alloc::AllocRef>::dealloc
actual: 5 Estimated: 3 diff: 2 core::alloc::Layout::align
actual: 6 Estimated: 10 diff: -4 <alloc::raw_vec::RawVec<T,A> as core::ops::drop::Drop>::drop
actual: 10 Estimated: 6 diff: 4 alloc::raw_vec::RawVec<T,A>::ptr
actual: 5370 Estimated: 9129 diff: -3759 alloc::alloc::box_free
actual: 14 Estimated: 24 diff: -10 core::slice::<impl core::ops::index::IndexMut<I> for [T]>::index_mut
actual: 18 Estimated: 32 diff: -14 alloc::vec::Vec<T>::as_mut_ptr
actual: 18 Estimated: 10 diff: 8 main2::main
actual: 10 Estimated: 18 diff: -8 core::ptr::mut_ptr::<impl *mut T>::is_null
actual: 10 Estimated: 18 diff: -8 core::ptr::const_ptr::<impl *const T>::is_null
actual: 362 Estimated: 728 diff: -366 core::ptr::unique::Unique<T>::as_ptr
actual: 6 Estimated: 13 diff: -7 core::ptr::unique::Unique<T>::new_unchecked
actual: 716 Estimated: 1611 diff: -895 core::ptr::unique::Unique<T>::as_ref
actual: 44 Estimated: 100 diff: -56 core::slice::from_raw_parts_mut
actual: 13 Estimated: 30 diff: -17 core::ptr::non_null::NonNull<T>::new_unchecked
actual: 13 Estimated: 32 diff: -19 <alloc::vec::Vec<T> as core::ops::drop::Drop>::drop
actual: 7 Estimated: 18 diff: -11 std::rt::lang_start
actual: 4 Estimated: 12 diff: -8 core::ptr::non_null::NonNull<T>::as_ptr
actual: 5 Estimated: 1 diff: 4 core::ops::function::FnOnce::call_once{{vtable.shim}}
actual: 10 Estimated: 0 diff: 10 core::mem::size_of
actual: 10 Estimated: 0 diff: 10 core::mem::align_of
actual: 23 Estimated: 1 diff: 22 core::ops::function::FnOnce::call_once
actual: 17170 Estimated: 24 diff: 17146 core::ptr::drop_in_place
```
</p>
</details>
@rustbot modify labels to +I-compiletime
cc @michaelwoerister | A-codegen,I-compiletime,T-compiler,C-bug | low | Critical |
569,396,936 | vscode | Find/replace icons are not intuitive | Issue Type: <b>Bug</b>
Related to my feedback on find/replace behavior (#91210), the dialog is also difficult to use because of its reliance on mystifying icons over labeled buttons.
* Several icons are just variants of `Aa` and `Ab` and `AB` etc. which are hard to keep straight without tool tips
* The "find in selection" icon doesn't convey selection
* Replacement options are hidden behind a generic disclosure triangle
* "Match whole word" doesn't convey much; there are 3 lines and I don't know what any of them represents
* "Replace" vs "Replace all" is reasonably intuitive but I'm not sure why "replace all" is differentiated with multiple characters being replaced rather than just multiple occurrences.
Aside from its icon, I'm not sure why "find in selection" is over to the right by the controls for navigating between occurrences, rather than an option that controls search behavior like "ignore case".
I also noticed that some button tooltips are in Title Case and others are in Sentence case, not sure if there is a reason for that.
VS Code version: Code 1.42.1 (c47d83b293181d9be64f27ff093689e8e7aed054, 2020-02-11T14:44:27.652Z)
OS version: Darwin x64 19.3.0 | feature-request,ux,editor-find | medium | Critical |
569,415,721 | flutter | flutter run --profile -d chrome sourcemaps sometimes do not work? | Apologies if I'm opening a duplicate. I couldn't find one.
```
[β] Flutter (Channel master, v1.15.4-pre.134, on Mac OS X 10.15.2 19C57, locale en-US)
β’ Flutter version 1.15.4-pre.134 at /Users/eseidel/Projects/flutter/flutter
β’ Framework revision bf8e2c1449 (26 hours ago), 2020-02-21 14:21:25 -0800
β’ Engine revision f2f8c342be
β’ Dart version 2.8.0 (build 2.8.0-dev.9.0 0f141be8bd)
```
@jonahwilliams mentioned to me on Friday that this was fixed. But at least the scenario I'm trying doesn't seem to be. This is not critical, just me attempting to come to a common understanding. :)
`flutter run -d chrome --profile` (e.g. inside flutter/samples/gallery) eseidel/samples@d51689bb7d7f93c65276a0531d19dcb87f98ced7 is a version of flutter/samples fixed to work with master.
Then record a profile from the inspector (performance tab).
Now try and click on one of the (obfuscated) names and view their source.
404s, e.g.:
Could not load content for http://localhost:54394/flutter/bin/cache/flutter_web_sdk/lib/_engine/engine/surface/surface.dart : HTTP status code: 404
Could not load content for http://localhost:54394/flutter/packages/flutter/lib/src/rendering/binding.dart : HTTP status code: 404
Browsing around the list of source files *does* work. At least for the files in the project.
Also using examples in the flutter/flutter repository seems to work? e.g. if you repeat the same experiment with flutter/flutter/examples/gallery those source links seem to work? There the links are different, e.g.
http://localhost:55447/packages/flutter/lib/src/rendering/object.dart
http://localhost:55447/packages/flutter/lib/src/rendering/proxy_box.dart
| tool,platform-web,P2,team-web,triaged-web | low | Major |
569,421,719 | godot | Index doesn't work for get_rotation and get_translation boxes in Visual Script, in Godot 3.2 | **Godot version:**
3.2
**OS/device including version:**
Windows 10
**Issue description:**
Normally, when I change ' index ' for get_rotation and get_translation in Godot 3.1 Visual scripting, it changes the default output from a vector3, to a float, like the x-value for translation . . But, that button doesn't work anymore, changing the index doesn't work . . it's still a vector3, instead . . .
**Steps to reproduce:**
**Minimal reproduction project:**
It's just really tough, when used to it working in 3.1, it not works in 3.2 . . | bug,confirmed,topic:visualscript | low | Minor |
569,422,871 | pytorch | /usr/bin/x86_64-linux-gnu-ld: warning: libcusparse.so.10.0, needed by /pytorch_master/build/lib/libtorch_cuda.so, not found (try using -rpath or -rpath-link) | ```
undefined reference to `[email protected]'
/pytorch_master/build/lib/libtorch_cuda.so: undefined reference to `[email protected]'
/pytorch_master/build/lib/libtorch_cuda.so: undefined reference to `[email protected]'
pytorch_master/build/lib/libtorch_cuda.so: undefined reference to `[email protected]'
/pytorch_master/build/lib/libtorch_cuda.so: undefined reference to `[email protected]'
/pytorch_master/build/lib/libtorch_cuda.so: undefined reference to `[email protected]'
```
while:
```
> locate libcusparse.so.10.0 1 master!1 master!
/usr/local/cuda-10.0/lib64/libcusparse.so.10.0
/usr/local/cuda-10.0/lib64/libcusparse.so.10.0.130
```
And my cuda lib64 path already in bashrc.
cc @ngimel | module: build,module: cuda,triaged | low | Major |
569,436,000 | TypeScript | When an index signature is not available, encourage using a more specific type to index the type. | ## Search Terms
index signature, keyof, domain: error messages
Vaguely related:
https://github.com/Microsoft/TypeScript/issues/14951
## Suggestion
When there is a type error because of a missing `string` index signature, add a suggestion of:
"Did you mean to use a more specific type such as `keyof Thing` instead of `string`?"
Only show this message:
- if the type used to index is within the same scope
- the object being indexed is not empty
## Use Cases
Take the following example:
```tsx
interface Person {
name: string;
phone: string;
}
declare const person: Person;
const get = (person: Person, key: string) => {
return person[key];
};
get(person, "name");
```
The error message here is:
```
Element implicitly has an 'any' type because expression of type 'string' can't be used to index type 'Person'.
No index signature with a parameter of type 'string' was found on type 'Person'.
```
This is technically correct! However, many people read this error message to mean "add an index signature to `Person`," rather than advising them to use a more specific type than `string`, like `keyof Person`. Adding the index signature suppresses the error, making it seem like the correct solution.
## Where this doesn't work
There are some cases where this advice would not make sense:
```
// Did you mean to use a more specific type such as `keyof Number` instead of `string`?
1["a" as string]
```
Other cases I can think of so far:
- Empty objects, especially from `reduce` (suppress for empty objects)
- Indexing an object by number (only do this for strings?)
- `Object.keys` and `Object.entries` as discussed many, many times (require the indexing type to be in the same scope)
## Checklist
My suggestion meets these guidelines:
* [X] This wouldn't be a breaking change in existing TypeScript/JavaScript code
* [X] This wouldn't change the runtime behavior of existing JavaScript code
* [X] This could be implemented without emitting different JS based on the types of the expressions
* [X] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
* [X] This feature would agree with the rest of [TypeScript's Design Goals](https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals).
| Suggestion,Awaiting More Feedback | medium | Critical |
569,471,001 | go | cmd/go: list_ambiguous_path test fails when Windows language is not english | ```
$ go version
go version devel +ebe49b2c29 Sun Feb 23 01:23:41 2020 +0000 windows/amd6
```
The `TestScript/list_ambiguous_path` test in `cmd/go` fails when the Windows language is set to something different from English, because the test hardcodes the missing file error message, which is localized.
An example failure from a system with the language set to Italian:
```
--- FAIL: TestScript (0.01s)
--- FAIL: TestScript/list_ambiguous_path (0.36s)
script_test.go:193:
# Ensures that we can correctly list package patterns ending in '.go'.
# See golang.org/issue/34653.
# A single pattern for a package ending in '.go'. (0.060s)
# Multiple patterns for packages including one ending in '.go'. (0.057s)
# A single pattern for a Go file. (0.144s)
# A single typo-ed pattern for a Go file. This should
# treat the wrong pattern as if it were a package. (0.049s)
# Multiple patterns for Go files with a typo. This should
# treat the wrong pattern as if it were a non-existint file. (0.035s)
> ! go list ./foo.go/a.go ./foo.go/b.go
[stderr]
CreateFile ./foo.go/b.go: Impossibile trovare il file specificato.
[exit status 1]
> [plan9] stderr 'stat ./foo.go/b.go: ''./foo.go/b.go'' does not exist'
> [windows] stderr './foo.go/b.go: The system cannot find the file specified'
FAIL: testdata\script\list_ambiguous_path.txt:26: no match for `(?m)./foo.go/b.go: The system cannot find the file specified` found in stderr
FAIL
FAIL cmd/go 229.859s
```
This test is run by `all.bat`, which means that `all.bat` will not complete successfully on a non-english Windows machine.
cc @Helcaraxan (which added the test) and @bcmills | Testing,NeedsFix | low | Critical |
569,476,766 | pytorch | Some module info is missing in nested graph for tensorboard | ## π Bug
<!-- A clear and concise description of what the bug is. -->
I'm currently doing some NN visualization project, which needs me to retrieve the precise module structure.
## To Reproduce
The output of the following code snippet is:
```python
import json
import torch
import torch.nn as nn
from torch.utils.tensorboard._pytorch_graph import graph
from google.protobuf import json_format
class MyModule(nn.Module):
def __init__(self):
super().__init__()
self.module = nn.ModuleList([
nn.Linear(5, 3),
nn.Linear(3, 1)
])
def forward(self, x):
x = self.module[0](x)
x = self.module[1](x)
return x
module = MyModule()
result, _ = graph(module, torch.randn(5, 5))
result = json_format.MessageToDict(result)
for node in result["node"]:
node["attr"] = "..."
print(json.dumps(result, sort_keys=True, indent=2))
```
```json
{
"node": [
{
"attr": "...",
"name": "input/input.1",
"op": "IO Node"
},
{
"attr": "...",
"input": [
"MyModule/Linear[1]/46"
],
"name": "output/output.1",
"op": "IO Node"
},
{
"attr": "...",
"input": [
"MyModule/ModuleList[module]/Linear[0]/weight/26"
],
"name": "MyModule/ModuleList[module]/Linear[0]/bias/35",
"op": "prim::GetAttr"
},
{
"attr": "...",
"input": [
"MyModule/ModuleList[module]/Linear[0]/weight/26"
],
"name": "MyModule/ModuleList[module]/Linear[0]/weight/36",
"op": "prim::GetAttr"
},
{
"attr": "...",
"input": [
"MyModule/ModuleList[module]/Linear[0]/weight/36"
],
"name": "MyModule/Linear[0]/37",
"op": "aten::t"
},
{
"attr": "...",
"name": "MyModule/Linear[0]/38",
"op": "prim::Constant"
},
{
"attr": "...",
"name": "MyModule/Linear[0]/39",
"op": "prim::Constant"
},
{
"attr": "...",
"input": [
"MyModule/ModuleList[module]/Linear[0]/bias/35",
"input/input.1",
"MyModule/Linear[0]/37",
"MyModule/Linear[0]/38",
"MyModule/Linear[0]/39"
],
"name": "MyModule/Linear[0]/input",
"op": "aten::addmm"
},
{
"attr": "...",
"input": [
"MyModule/ModuleList[module]/Linear[1]/weight/30"
],
"name": "MyModule/ModuleList[module]/Linear[1]/bias/41",
"op": "prim::GetAttr"
},
{
"attr": "...",
"input": [
"MyModule/ModuleList[module]/Linear[1]/weight/30"
],
"name": "MyModule/ModuleList[module]/Linear[1]/weight/42",
"op": "prim::GetAttr"
},
{
"attr": "...",
"input": [
"MyModule/ModuleList[module]/Linear[1]/weight/42"
],
"name": "MyModule/Linear[1]/43",
"op": "aten::t"
},
{
"attr": "...",
"name": "MyModule/Linear[1]/44",
"op": "prim::Constant"
},
{
"attr": "...",
"name": "MyModule/Linear[1]/45",
"op": "prim::Constant"
},
{
"attr": "...",
"input": [
"MyModule/ModuleList[module]/Linear[1]/bias/41",
"MyModule/Linear[0]/input",
"MyModule/Linear[1]/43",
"MyModule/Linear[1]/44",
"MyModule/Linear[1]/45"
],
"name": "MyModule/Linear[1]/46",
"op": "aten::addmm"
}
],
"versions": {
"producer": 22
}
}
```
Notice that there is no module as `MyModule/Linear[1]/46` in my model. It should be `MyModule/ModuleList[module]/Linear[1]/46`.
## Expected behavior
Actually, the cause of this problem is that there are some levels of modules missing in the jit trace. But since each level of jit trace is a full path, the workaround is easy: modify the last lines of `parse` function of `_pytorch_graph` into:
```python
for node in nodes_py.nodes_op:
module_aliases = node.scopeName.split('/')[-1].split('.')
module_name = ''
for i, alias in enumerate(module_aliases):
if i == 0:
module_name = alias
node.scopeName = base_name
else:
module_name += '.' + alias
node.scopeName += '/' + (alias_to_name[module_name] if module_name in alias_to_name else alias)
nodes_py.populate_namespace_from_OP_to_IO()
return nodes_py.to_proto()
```
The code reads info after the last slash only, and use dot as break to retrieve the info from each level. Now it works as expected.
```json
{
"node": [
{
"attr": "...",
"name": "input/input.1",
"op": "IO Node"
},
{
"attr": "...",
"input": [
"MyModule/ModuleList[module]/Linear[1]/46"
],
"name": "output/output.1",
"op": "IO Node"
},
{
"attr": "...",
"input": [
"MyModule/ModuleList[module]/Linear[0]/weight/26"
],
"name": "MyModule/ModuleList[module]/Linear[0]/bias/35",
"op": "prim::GetAttr"
},
{
"attr": "...",
"input": [
"MyModule/ModuleList[module]/Linear[0]/weight/26"
],
"name": "MyModule/ModuleList[module]/Linear[0]/weight/36",
"op": "prim::GetAttr"
},
{
"attr": "...",
"input": [
"MyModule/ModuleList[module]/Linear[0]/weight/36"
],
"name": "MyModule/ModuleList[module]/Linear[0]/37",
"op": "aten::t"
},
{
"attr": "...",
"name": "MyModule/ModuleList[module]/Linear[0]/38",
"op": "prim::Constant"
},
{
"attr": "...",
"name": "MyModule/ModuleList[module]/Linear[0]/39",
"op": "prim::Constant"
},
{
"attr": "...",
"input": [
"MyModule/ModuleList[module]/Linear[0]/bias/35",
"input/input.1",
"MyModule/ModuleList[module]/Linear[0]/37",
"MyModule/ModuleList[module]/Linear[0]/38",
"MyModule/ModuleList[module]/Linear[0]/39"
],
"name": "MyModule/ModuleList[module]/Linear[0]/input",
"op": "aten::addmm"
},
{
"attr": "...",
"input": [
"MyModule/ModuleList[module]/Linear[1]/weight/30"
],
"name": "MyModule/ModuleList[module]/Linear[1]/bias/41",
"op": "prim::GetAttr"
},
{
"attr": "...",
"input": [
"MyModule/ModuleList[module]/Linear[1]/weight/30"
],
"name": "MyModule/ModuleList[module]/Linear[1]/weight/42",
"op": "prim::GetAttr"
},
{
"attr": "...",
"input": [
"MyModule/ModuleList[module]/Linear[1]/weight/42"
],
"name": "MyModule/ModuleList[module]/Linear[1]/43",
"op": "aten::t"
},
{
"attr": "...",
"name": "MyModule/ModuleList[module]/Linear[1]/44",
"op": "prim::Constant"
},
{
"attr": "...",
"name": "MyModule/ModuleList[module]/Linear[1]/45",
"op": "prim::Constant"
},
{
"attr": "...",
"input": [
"MyModule/ModuleList[module]/Linear[1]/bias/41",
"MyModule/ModuleList[module]/Linear[0]/input",
"MyModule/ModuleList[module]/Linear[1]/43",
"MyModule/ModuleList[module]/Linear[1]/44",
"MyModule/ModuleList[module]/Linear[1]/45"
],
"name": "MyModule/ModuleList[module]/Linear[1]/46",
"op": "aten::addmm"
}
]
}
```
<!-- A clear and concise description of what you expected to happen. -->
## Environment
It's not important.
## Additional context
<!-- Add any other context about the problem here. -->
I think the root cause lies in jit.trace, which might be worth investigation. Or it's by design, in which case it should be fixed in support for tensorboard.
This issue is similar to #30812, but I double-checked: it's a different issue.
| triaged,module: tensorboard | low | Critical |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.