id
int64
393k
2.82B
repo
stringclasses
68 values
title
stringlengths
1
936
body
stringlengths
0
256k
βŒ€
labels
stringlengths
2
508
priority
stringclasses
3 values
severity
stringclasses
3 values
563,397,168
rust
arbitrary self types causes unexpected error messages
This example: ```rust #![feature(arbitrary_self_types)] trait Test<T: core::ops::Deref<Target = Self>> { fn is_some(self: T); } fn f() { let x = Some(2); if x.is_some() { println!("Some"); } } ``` [Playground link](https://play.rust-lang.org/?version=nightly&mode=debug&edition=2018&gist=83f8fd48766d3bcd61212a70b6db86df) gives the error ``` error[E0277]: the trait bound `std::option::Option<{integer}>: std::ops::Deref` is not satisfied --> src/lib.rs:8:10 | 8 | if x.is_some() { | ^^^^^^^ the trait `std::ops::Deref` is not implemented for `std::option::Option<{integer}>` error[E0308]: mismatched types --> src/lib.rs:8:8 | 8 | if x.is_some() { | ^^^^^^^^^^^ expected `bool`, found `()` error: aborting due to 2 previous errors ``` rather than an error because the `Test` trait is not implemented. This is presumably just a case where improved diagnostics would be good. The [inherent `is_some` method](https://doc.rust-lang.org/std/option/enum.Option.html#method.is_some) winds up not triggering because it requires auto-ref rather than being passed "by value". _Originally posted by @tguser402 in https://github.com/rust-lang/rust/issues/66312#issuecomment-568805751_
C-enhancement,A-diagnostics,T-compiler,F-arbitrary_self_types,D-confusing,D-papercut
low
Critical
563,439,971
rust
Clarify "cannot find macro `X` in this scope"
I always forget that program order matters for macro definitions. In the [example](https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=0e2900e51a17037b753c2c451e12146b), I get the error: ``` error: cannot find macro `five_times` in this scope ``` And inevitably I spend a long time trying to debug it when I eventually remember that for `macro_use`, program order matters. If the compiler error message provided a hint like "macro `five_times` exists but is defined after the code attempting to use it. try reordering the use statements" (or choose better phrasing), that'd save a lot of time.
C-enhancement,A-diagnostics,A-resolve,A-macros,T-compiler
low
Critical
563,460,149
flutter
[web][safari] unskip safari semantics tests
Bunch of tests are skipped for semantics in Safari in the following files. We should either skip them or change them to work in in Safari. (note: there is a chance that the browser has a bug for the tests methods use case) semantics_test.dart semantics_helper_test.dart
a: tests,team,framework,engine,a: accessibility,platform-web,browser: safari-macos,P2,team-web,triaged-web
low
Critical
563,479,106
flutter
Video player plugin should support WebVTT closed captions file format.
<!-- Thank you for using Flutter! If you are looking for support, please check out our documentation or consider asking a question on Stack Overflow: * https://flutter.dev/ * https://api.flutter.dev/ * https://stackoverflow.com/questions/tagged/flutter?sort=frequent If you have found a bug or if our documentation doesn't have an answer to what you're looking for, then fill our the template below. Please read our guide to filing a bug first: https://flutter.dev/docs/resources/bug-reports --> ## Use case This file format is commonly used on the web. https://github.com/flutter/flutter/issues/25388 was resolved, but the only supported file type right now is SubRip. More specifically, when the `video_player` plugin is used to display [HLS](https://en.wikipedia.org/wiki/HTTP_Live_Streaming), we want the ability to read captions from the stream and display them in our app. Example HLS with captions: https://developer.apple.com/streaming/examples/advanced-stream-fmp4.html <!-- Please tell us the problem you are running into that led to you wanting a new feature. Is your feature request related to a problem? Please give a clear and concise description of what the problem is. Describe alternative solutions you've considered. Is there a package on pub.dev/flutter that already solves this? --> ## Proposal <!-- Briefly but precisely describe what you would like Flutter to be able to do. Consider attaching images showing what you are imagining. Does this have to be provided by Flutter directly, or can it be provided by a package on pub.dev/flutter? If so, maybe consider implementing and publishing such a package rather than filing a bug. --> We should write a subclass of `ClosedCaptionFile` in the `video_player` plugin that can read closed caption files in WebVTT format. We also _may_ need to modify the player to support reading captions on the go, as a stream while the video file is being streamed.
c: new feature,a: accessibility,p: video_player,package,c: proposal,team-ecosystem,P3,triaged-ecosystem
medium
Critical
563,480,734
flutter
[web][safari] unskip safari text related tests
Bunch of tests are skipped for text/measurement in Safari in the following files. We should either skip them or change them to work in in Safari. (note: there is a chance that the browser has a bug for the tests methods use case) - [x] text_test.dart - [ ] paragraph_test.dart - [ ] measurement_test.dart (80% was failing so the entire file is skipped) Text editing has another issue.
a: tests,team,framework,a: typography,platform-web,browser: safari-macos,P2,team-web,triaged-web
low
Critical
563,488,436
flutter
[web][safari] unskip safari text editing tests
Some methods in text_editing_test.dart are skipped in Safari. We should either skip them or change them to work in in Safari. (note: there is a chance that the browser has a bug for the tests methods use case)
a: tests,a: text input,team,framework,platform-web,browser: safari-macos,P2,team-web,triaged-web
low
Critical
563,503,301
flutter
Change backgroundColor of CupertinoActionSheet
is it possible to add in the future a parameter `backgroundColor` or something like that to change the backgroundColor of the `CupertinoActionSheet`? Actually you can only switch between two colors.
framework,f: cupertino,d: stackoverflow,c: proposal,team-design,triaged-design
low
Major
563,509,700
go
crypto/x509: certificate validation in Windows fails to validate IP in SAN
<!-- Please answer these questions before submitting your issue. Thanks! For questions please use one of our forums: https://github.com/golang/go/wiki/Questions --> ### What version of Go are you using (`go version`)? <pre> $ go version go version go1.13.5 darwin/amd64 </pre> ### Does this issue reproduce with the latest release? Yes ### What operating system and processor architecture are you using (`go env`)? <details><summary><code>go env</code> Output</summary><br><pre> $ go env GO111MODULE="" GOARCH="amd64" GOBIN="" GOCACHE="/Users/ganni/Library/Caches/go-build" GOENV="/Users/ganni/Library/Application Support/go/env" GOEXE="" GOFLAGS="" GOHOSTARCH="amd64" GOHOSTOS="darwin" GONOPROXY="" GONOSUMDB="" GOOS="darwin" GOPATH="/Users/ganni/.gvm/pkgsets/go1.13.5/global" GOPRIVATE="" GOPROXY="https://proxy.golang.org,direct" GOROOT="/Users/ganni/.gvm/gos/go1.13.5" GOSUMDB="sum.golang.org" GOTMPDIR="" GOTOOLDIR="/Users/ganni/.gvm/gos/go1.13.5/pkg/tool/darwin_amd64" GCCGO="gccgo" AR="ar" CC="clang" CXX="clang++" CGO_ENABLED="1" GOMOD="" CGO_CFLAGS="-g -O2" CGO_CPPFLAGS="" CGO_CXXFLAGS="-g -O2" CGO_FFLAGS="-g -O2" CGO_LDFLAGS="-g -O2" PKG_CONFIG="pkg-config" GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/jk/kkbbm14x25l9hj_xj1rb4scm002zdg/T/go-build540477719=/tmp/go-build -gno-record-gcc-switches -fno-common" </pre></details> ### What did you do? I ran the following quick program to reproduce it: ``` package main import ( "fmt" "io/ioutil" "net/http" "os" "time" ) func main() { client := http.Client{ Timeout: 5 * time.Second, } resp, err := client.Get("https://192.168.210.129") if err != nil { fmt.Println(err) os.Exit(1) return } defer resp.Body.Close() body, err := ioutil.ReadAll(resp.Body) if err != nil { fmt.Println(err) os.Exit(1) return } fmt.Printf("Response:\n\n%s", string(body)) } ``` Where `192.168.210.129` is a custom server using a self-signed certificate. The notable aspects of this cert are that I'm connecting via IP (which is not present in the CN) and it is only present in the `IP Address` field of the SAN, like so: ``` IP Address=192.168.210.129 ``` When I compile the binary to run on a Windows box, I run the following: ``` GOOS=windows GOARCH=386 go build -o quicktest.exe main.go ``` ### What did you expect to see? I expect to see a response from the server. This server is healthy and I can access it from my browser, so I expect to see an HTML output from the last line. ### What did you see instead? I see the following output while running: ``` PS C:\> C:\quicktest.exe Get https://192.168.210.129: x509: certificate is valid for 192.168.210.129, not 192.168.210.129 ``` The interesting part is that it that's the same IP address in both notes. I then ran a modified version of `go` to add a `panic` near https://sourcegraph.com/github.com/golang/[email protected]/-/blob/src/crypto/x509/root_windows.go#L129, changing: ``` Β  if status.Error != 0 { Β  switch status.Error { Β  case syscall.CERT_E_EXPIRED: Β  return CertificateInvalidError{c, Expired, ""} Β  case syscall.CERT_E_CN_NO_MATCH: Β  return HostnameError{c, opts.DNSName} ``` to ``` Β  if status.Error != 0 { Β  switch status.Error { Β  case syscall.CERT_E_EXPIRED: Β  return CertificateInvalidError{c, Expired, ""} Β  case syscall.CERT_E_CN_NO_MATCH: panic("failed here") Β  // return HostnameError{c, opts.DNSName} ``` and see the following stack trace to verify this is indeed where it fails, which is Windows-specific. ``` Windows PowerShell Copyright (C) 2016 Microsoft Corporation. All rights reserved. PS C:\> & 'C:\quicktestcustom.exe' panic: failed here goroutine 21 [running]: crypto/x509.checkChainSSLServerPolicy(0x128cc2c0, 0xb2d7b8, 0x128adb6c, 0xb14850, 0x128adab8) /code/github.com/golang/go-darwin-amd64-bootstrap/src/crypto/x509/root_windows.go:130 +0x2c7 crypto/x509.(*Certificate).systemVerify(0x128cc2c0, 0x128adb6c, 0x0, 0x0, 0x0, 0x0, 0x0) /code/github.com/golang/go-darwin-amd64-bootstrap/src/crypto/x509/root_windows.go:213 +0x652 crypto/x509.(*Certificate).Verify(0x128cc2c0, 0x1289a280, 0xf, 0x128f65c0, 0x0, 0x526d9c8, 0xbf88e6b7, 0x112bdfd, 0x0, 0 x814560, ...) /code/github.com/golang/go-darwin-amd64-bootstrap/src/crypto/x509/verify.go:750 +0x5b6 crypto/tls.(*Conn).verifyServerCertificate(0x128fc000, 0x12892320, 0x1, 0x1, 0x3eb, 0x0) /code/github.com/golang/go-darwin-amd64-bootstrap/src/crypto/tls/handshake_client.go:815 +0x1e4 crypto/tls.(*clientHandshakeState).doFullHandshake(0x128adec8, 0x128ba0e0, 0x68) /code/github.com/golang/go-darwin-amd64-bootstrap/src/crypto/tls/handshake_client.go:452 +0x136c crypto/tls.(*clientHandshakeState).handshake(0x128adec8, 0x128a26c0, 0x0) /code/github.com/golang/go-darwin-amd64-bootstrap/src/crypto/tls/handshake_client.go:397 +0x343 crypto/tls.(*Conn).clientHandshake(0x128fc000, 0x0, 0x0) /code/github.com/golang/go-darwin-amd64-bootstrap/src/crypto/tls/handshake_client.go:206 +0x47a crypto/tls.(*Conn).Handshake(0x128fc000, 0x0, 0x0) /code/github.com/golang/go-darwin-amd64-bootstrap/src/crypto/tls/conn.go:1340 +0xe0 net/http.(*persistConn).addTLS.func2(0x0, 0x128fc000, 0x128f4400, 0x128f43c0) /code/github.com/golang/go-darwin-amd64-bootstrap/src/net/http/transport.go:1453 +0x34 created by net/http.(*persistConn).addTLS /code/github.com/golang/go-darwin-amd64-bootstrap/src/net/http/transport.go:1449 +0x175 ``` I also further validated I do not see such issues on Linux or Mac machines. For additional debugging help, I should also mention I only have access to one specific Windows machine that I tested with at the time, so I'm not sure if this is apparent on other Windows versions. My Windows version is: `Windows Server 2012 R2 Standard`
OS-Windows,NeedsInvestigation
low
Critical
563,567,124
TypeScript
Composite projects: support strict dependencies
Google (and Bazel rules_typescript) use a special-purpose TypeScript compiler. One of the reasons for this is we want to enforce strict dependencies. Strict dependencies means you may only import or reference symbols declared in a project you explicitly declare to be an input. This is an essential property in a large monorepo as a defense against accidental coupling between projects. For example we might have three directories, A B and C: ``` alexeagle@alexeagle:~/Projects/repro_strict_deps$ cat A/a.ts export const a = 'hello'; alexeagle@alexeagle:~/Projects/repro_strict_deps$ cat A/tsconfig.json { "compilerOptions": { "composite": true } } ``` ``` alexeagle@alexeagle:~/Projects/repro_strict_deps$ cat B/b.ts import {a} from '../A/a'; export function sayHello(f: string) { console.log(a + f); } alexeagle@alexeagle:~/Projects/repro_strict_deps$ cat B/tsconfig.json { "compilerOptions": { "composite": true, }, "references": [ {"path": "../A"} ] } ``` ``` alexeagle@alexeagle:~/Projects/repro_strict_deps$ cat C/c.ts import {a} from '../A/a'; // SHOULD FAIL HERE import {sayHello} from '../B/b'; sayHello('world'); console.error(a); alexeagle@alexeagle:~/Projects/repro_strict_deps$ cat C/tsconfig.json { "references": [ // NO REF TO A {"path": "../B"} ] } ``` Let's say we work on library B. We decide we no longer need to depend on A, so we remove the dependency, but this breaks users such as C. This is a serious impediment to good code practices because our dependency on A leaked to users who reference its symbols without declaring their own dependency. In a big monorepo, the breakage of removing a dependency can prevent ever cleaning them up We would like to propose a strictness setting when used with Project References, such that imports (or ambient references) from transitive dependencies should be disallowed. /cc @evmar @josephperrott
Suggestion,In Discussion
low
Critical
563,642,183
go
cmd/compile: error has incorrect column number
<!-- Please answer these questions before submitting your issue. Thanks! For questions please use one of our forums: https://github.com/golang/go/wiki/Questions --> ### What version of Go are you using (`go version`)? <pre> $ go version 1.13.7 </pre> ### Does this issue reproduce with the latest release? Yes ### What operating system and processor architecture are you using (`go env`)? <details><summary><code>go env</code> Output</summary><br><pre> $ go env GOHOSTARCH="amd64" GOHOSTOS="darwin" GONOPROXY="" GONOSUMDB="" GOOS="darwin" GOPATH="/Users/pdq/gocode" GOPRIVATE="" GOPROXY="https://proxy.golang.org,direct" GOROOT="/usr/local/Cellar/go/1.13.7" GOSUMDB="sum.golang.org" GOTMPDIR="" GOTOOLDIR="/usr/local/Cellar/go/1.13.7/pkg/tool/darwin_amd64" GCCGO="gccgo" AR="ar" CC="clang" CXX="clang++" CGO_ENABLED="1" GOMOD="" CGO_CFLAGS="-g -O2" CGO_CPPFLAGS="" CGO_CXXFLAGS="-g -O2" CGO_FFLAGS="-g -O2" CGO_LDFLAGS="-g -O2" PKG_CONFIG="pkg-config" GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/mv/slwhmwcj03d0npjtlsnjcm2m0000gn/T/go-build196033875=/tmp/go-build -gno-record-gcc-switches -fno-common" pdq@quackbook-air ~/v/simscope $ </pre></details> ### What did you do? Playground: https://play.golang.org/p/DyuvyvPwrv6 ``` package main type ABC struct { A string } func hello(first string, second string, third bool) { } func main() { var abc ABC hello("hello", "world", abc) } ``` ### What did you expect to see? ``` ./prog.go:12:24: cannot use abc (type ABC) as type bool in argument to hello ``` ### What did you see instead? ``` ./prog.go:12:16: cannot use abc (type ABC) as type bool in argument to hello ``` NOTE: I removed leading whitespace in the source code to eliminate ambiguity. The error is pointing to the second argument column ("world" on column 12) instead of the third argument column (abc on column 24).
NeedsInvestigation,compiler/runtime
low
Critical
563,648,947
flutter
Cache shaders on Fuchsia
On Fuchsia, a Flutter runner is shared across multiple applications. We should use a single persistent cache for the Skia shaders for each Flutter runner, so that we only compile each shader once per version of the engine, even across multiple apps.
customer: fuchsia,engine,dependency: fuchsia,c: performance,platform-fuchsia,perf: speed,P2,team-engine,triaged-engine
low
Major
563,659,792
flutter
FloatingActionButton flickers on Hero animation
I have a list of images in a `SliverList` with a `FloatingActionButton` on the bottom-right corner. When the user click's any image on the `SliverList`, the image animates to a new `Route` where the image goes behind the `AppBar` on this new page. I am using a `Hero` widget to make the animation from the `SliverList` item to the `AppBar` `flexibleSpace`. The problem happens when the clicked image is behind the `FloatingActionButton` on the first page and the user clicks the back button on the second page. When the user clicks the image on the `SliverList` the image animates fine to the next page, but when it goes back the image transitions from the top (the `AppBar`) to the bottom right in front of the `FloatingActionButton`, while the `FloatingActionButton fades-in as the second page fades-out, and then the `Hero` widget suddenly replaces the source image with the destination image, as the source is on top of the `FloatingActionButton` and the destination is behind, the end result is the `FloatingActionButton` flickering in place, which goes against all the soft transitions that happened before. So in a nutshell, as we go back we see the `FloatingActionButton` fading-in while the image moves covering it then suddenly it appears on top of the image.
framework,a: animation,f: material design,has reproducible steps,found in release: 2.10,found in release: 2.13,team-design,triaged-design
low
Major
563,729,629
pytorch
[v1.5] Python/C++ API parity master tracking task
Achieving API parity between our Python and C++ frontend is crucial for broadening the number of language communities PyTorch can address. By the PyTorch 1.5 release, we will provide the following improvements to the PyTorch C++ frontend: **Python/C++ API Parity:** - [x] torch.nn modules and functional (tracking issue: https://github.com/pytorch/pytorch/issues/25883) - [x] RNN (https://github.com/pytorch/pytorch/pull/34322) - [x] LSTM (https://github.com/pytorch/pytorch/pull/34322) - [x] GRU (https://github.com/pytorch/pytorch/pull/34322) - [x] RNNCell (https://github.com/pytorch/pytorch/pull/34400) - [x] LSTMCell (https://github.com/pytorch/pytorch/pull/34400) - [x] GRUCell (https://github.com/pytorch/pytorch/pull/34400) - [x] AdaptiveLogSoftmaxWithLoss (https://github.com/pytorch/pytorch/pull/29076) - [x] PackedSequence (https://github.com/pytorch/pytorch/pull/33652) - [x] pack_padded_sequence (https://github.com/pytorch/pytorch/pull/33652) - [x] pad_packed_sequence (https://github.com/pytorch/pytorch/pull/33652) - [x] pad_sequence (https://github.com/pytorch/pytorch/pull/33652) - [x] pack_sequence (https://github.com/pytorch/pytorch/pull/33652) - [ ] Python/C++ API parity test for torch.nn modules and functional - [x] Fix AdaptiveAvgPool{2,3}d and AdaptiveMaxPool{2,3}d implementation (https://github.com/pytorch/pytorch/pull/35022) - [x] Fix Conv and ConvTranspose implementation (https://github.com/pytorch/pytorch/pull/35023) - [x] Fix fractional_max_pool3d_with_indices implementation (https://github.com/pytorch/pytorch/pull/35024) - [x] Fix F::interpolate and torch::nn::Upsample implementation (https://github.com/pytorch/pytorch/pull/35025) - [x] Add inplace tests for several torch::nn modules / functionals (#35147) - [x] Renaming: MultiLabelMarginLossFuncOptions -> MultilabelMarginLossFuncOptions, MultiLabelSoftMarginLossFuncOptions -> MultilabelSoftMarginLossFuncOptions (#35163) - [ ] Turn on parity test (https://github.com/pytorch/pytorch/pull/35189, https://github.com/pytorch/pytorch/pull/35190) - [ ] torch.optim optimizers (tracking issue: https://github.com/pytorch/pytorch/issues/28440, make sure to test that the new design doesn't break serialization BC) - [x] tensor multi-dim indexing API - [x] https://github.com/pytorch/pytorch/pull/32841 - [x] https://github.com/pytorch/pytorch/pull/30426 - [x] https://github.com/pytorch/pytorch/pull/30427 - [x] C++ tensor autograd API (tracking issue: https://github.com/pytorch/pytorch/issues/25874). Remaining items: - [x] grad_fn (https://github.com/pytorch/pytorch/pull/28287) - [x] register_hook (https://github.com/pytorch/pytorch/pull/28287) - [x] retain_grad (https://github.com/pytorch/pytorch/pull/33349) - [x] _base (https://github.com/pytorch/pytorch/pull/33316) **Deprecation** - [x] Remove deprecated torch::nn::BatchNorm / FeatureDropout / modules_ordered_dict and torch::nn::init::Nonlinearity / FanMode (https://github.com/pytorch/pytorch/pull/34508) **Bug fixes:** - [x] Allow skipping default arguments in module's forward method when module is used in Sequential (PR: https://github.com/pytorch/pytorch/pull/33027) - [x] ModuleList compile error: error: 'begin' was not declared in this scope (Issue: https://github.com/pytorch/pytorch/issues/32414, PR: https://github.com/pytorch/pytorch/pull/34463) - [x] C++ nn::FractionalMaxPool2d/3d output_ratio option is integer, should be double (Issue: https://github.com/pytorch/pytorch/issues/33240, PR: https://github.com/pytorch/pytorch/pull/33304) - [x] Remove `using namespace torch::autograd` from header files (Issue: https://github.com/pytorch/pytorch/issues/34371. PR: https://github.com/pytorch/pytorch/pull/34423) **Docs:** - [x] For each `torch::nn` layer, document how to use `*Options` to specify options (ideally right above `torch::nn` layer doc) (https://github.com/pytorch/pytorch/pull/34522) - [x] For each `torch::nn` functional, document how to use `*Options` to specify options (ideally right above `torch::nn` functional doc) (https://github.com/pytorch/pytorch/pull/34688) (https://github.com/pytorch/pytorch/pull/34752) (ETA: 3/13) - [x] Fix torch::Tensor doc generation (Issue: https://github.com/pytorch/pytorch/issues/25845. PR: https://github.com/pytorch/pytorch/pull/34467) - [ ] How to use C++ tensor multi-dim indexing (ETA: 4/3) - [ ] Maybe a table to show the translation between two languages **Tutorials:** - [ ] Autograd in C++ (ETA: 4/3) - [ ] Basic autograd operations (https://pytorch.org/tutorials/beginner/blitz/autograd_tutorial.html, https://pytorch.org/tutorials/beginner/examples_autograd/two_layer_net_autograd.html?highlight=autograd) - [ ] How to use C++ custom autograd function (https://pytorch.org/docs/stable/notes/extending.html#extending-torch-autograd) - [ ] How to use `at::Tensor::register_hook` - [ ] How to compute higher-order gradients in C++ (e.g. issue: https://github.com/pytorch/pytorch/issues/18173) **Blog post:** - [ ] C++ frontend revamp (ETA: 4/3) cc @yf225 @gchanan
module: cpp,triaged
low
Critical
563,766,574
angular
Angular 9: projectable nodes change position
<!--πŸ”…πŸ”…πŸ”…πŸ”…πŸ”…πŸ”…πŸ”…πŸ”…πŸ”…πŸ”…πŸ”…πŸ”…πŸ”…πŸ”…πŸ”…πŸ”…πŸ”…πŸ”…πŸ”…πŸ”…πŸ”…πŸ”…πŸ”…πŸ”…πŸ”…πŸ”…πŸ”…πŸ”…πŸ”…πŸ”…πŸ”… Oh hi there! πŸ˜„ To expedite issue processing please search open and closed issues before submitting a new one. Existing issues often contain information about workarounds, resolution, or progress updates. πŸ”…πŸ”…πŸ”…πŸ”…πŸ”…πŸ”…πŸ”…πŸ”…πŸ”…πŸ”…πŸ”…πŸ”…πŸ”…πŸ”…πŸ”…πŸ”…πŸ”…πŸ”…πŸ”…πŸ”…πŸ”…πŸ”…πŸ”…πŸ”…πŸ”…πŸ”…πŸ”…πŸ”…πŸ”…πŸ”…πŸ”…πŸ”…πŸ”…--> # 🐞 bug report ### Is this a regression? <!-- Did this behavior use to work in the previous version? --> <!-- ✍️--> Yes, the previous version in which this bug was not present was: 8 ### Description If you create a template with multiple `ng-content` and some of them under `ngIf` directive, strange behavior happens. Seems like the projectables nodes change their position and display in the wrong placeholders. ## πŸ”¬ Minimal Reproduction <!-- Please create and share minimal reproduction of the issue starting with this template: https://stackblitz.com/fork/angular-issue-repro2 --> https://stackblitz.com/edit/angular-ivy-whjpes?file=src%2Fapp%2Fapp.component.ts In the given link you can see that both `Header text` and `Content text` are placed in the wrong positions: `Content text` displays in the div with class `header`, while `Header text` displays in the div with class `content`. If you remove `ngIf` everything works fine. <!-- If StackBlitz is not suitable for reproduction of your issue, please create a minimal GitHub repository with the reproduction of the issue. A good way to make a minimal reproduction is to create a new app via `ng new repro-app` and add the minimum possible code to show the problem. Share the link to the repo below along with step-by-step instructions to reproduce the problem, as well as expected and actual behavior. Issues that don't have enough info and can't be reproduced will be closed. You can read more about issue submission guidelines here: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#-submitting-an-issue --> ## 🌍 Your Environment **Angular Version:** Angular v.9 of all packages
type: bug/fix,freq1: low,area: core,state: confirmed,core: content projection,core: dynamic view creation,P4
low
Critical
563,778,813
flutter
Get properties of widget using flutter driver
Hello guys, I want to get some properties of a widget (color, hintText, onTap, ...) by using flutter driver. I tried to use `.getWidgetDiagnostics()` or `.getRenderTree()` or `.getRenderObjectDiagnostics()`, none of them include the property value I want. Could you help to achieve this ? Thanks in advanced.
c: new feature,framework,t: flutter driver,P3,team-framework,triaged-framework
low
Minor
563,792,768
godot
Exporting selected scenes to HTML5 does not export project audio bus
**Godot version:** v3.2 **OS/device including version:** Windows 10 v1909 **Issue description:** Exporting selected scenes to HTML5 does not export project audio bus file (*.tres). Which means `AudioEffectInstance.get_magnitude_for_frequency_range` doesn't work on HTML5 unless the user exports all resources in the project, or manually adds `*.tres` to the "Filters to export non-resource files/folders". **Steps to reproduce:** Create a new project that uses AudioEffectInstance.get_magnitude_for_frequency_range, add a new audio bus, and export to HTML5 by selecting only the scene file.
bug,topic:editor,confirmed,topic:audio,topic:export
low
Major
563,889,512
scrcpy
Turning screen off (mirroring) kills brightness adjustment
When I start `scrcpy` with the `--turn-screen-off` command line option, or if I use `ctrl-o` keyboard shortcut, once running to keep the mirroring working while turning the screen off, then **any subsequent screen brightness change is no more taken in account until I reboot**. No matter what I do after: * Changing brightness manually * Turning off and on adaptive brightness The screen brightness will remain what it was before the `scrcpy` session. And this, until I reboot which eventually restores the mechanism. If I run `scrcpy` without passing the command line option or issuing the `ctrl-o` keyboard shortcut, everything is fine from brightness adjustment point of view... I didn't notice this initially, or at least didn't make the link as clear as it is now. This is on _Samsung S9_ running [/e/](https://e.foundation/) (basically the same as [LineageOS](https://lineageos.org/)) based on Oreo , but a friend of mine running [LineageOS](https://lineageos.org/) on a _Samsung S7_ do not face the same issue...
screenoff
low
Minor
563,893,694
go
image/color: documentation doesn't include links to relevant color theory resources
### What version of Go are you using (`go version`)? <pre> $ go version 1.13.7 </pre> ### Does this issue reproduce with the latest release? Yes: https://tip.golang.org/pkg/image/color/ ### What did you expect to see? The `image/color` relies on some color theory. But no pointers are given to learn about that theory. Here are a few questions for which the documentation should give answers or even just hints: * What is Alpha? * What is the difference between alpha-premultiplied and non-alpha-premultiplied (some answer exists in doc for type [RGBA](https://tip.golang.org/pkg/image/color/#RGBA), but more in overview would be helpful) and when should one be used). Also, no examples. That would be useful to understand [Model](https://tip.golang.org/pkg/image/color/#Model). ### What did you see instead? The [package overview section](https://tip.golang.org/pkg/image/color/#pkg-overview) is a single sentence: > Package color implements a basic color library.
Documentation,NeedsInvestigation
low
Minor
563,911,380
godot
Godot Editor and game freezes when using .gdns file
**Godot version:** 3.2 **OS/device including version:** Ubuntu 19.10 **Issue description:** I'm trying to include this module [TTSDriver.zip](https://github.com/godotengine/godot/files/4191420/TTSDriver.zip) The godot editor freezes when put in the background. Game also freeze when trying to quit with the close button. **Steps to reproduce:** Include the file given in a project - run the app and try to quit it or put the godot editor in the background and come back to it Code doesn't matter because even if I don't preload it the issue occures anyway The module [source](https://github.com/bruvzg/godot_tts) The problem goes away if i rename the TTSDriver.gdns to TTSDriver.gdns.back (but I can't use it anymore in the code ;-) )
bug,topic:editor,topic:gdextension,crash
low
Minor
563,936,392
godot
"Auto Key" not auto keying when changing values from inspector
**Godot version:** v3.2 **OS/device including version:** Windows 10 **Issue description:** ![image](https://user-images.githubusercontent.com/37254287/74330758-047a7980-4d71-11ea-968a-134b43b90462.png) With Auto Key enabled, along with the other transforms, it only works when you animate with move, rotate and scale tools. but if you change the values in the inspector, it doesn't auto key those values. I would scale with the tool, and then punch in accurate numbers in the inspector, but it does not auto key from the inspector. **Steps to reproduce:** 1. Add your animation player, create your animation track, enable auto key. 2. Animate using Inspector. **Minimal reproduction project:** -
bug,topic:editor
low
Minor
563,966,829
vscode
Support custom QuickPick filter logic
Currently the `QuickPick` filter logic supports wild cards and which parts of the item to search in but not things like switched up word order or regex. [An issue](https://github.com/brunnerh/insert-unicode/issues/13) was opened for one of my extensions asking for a more lenient search, which does not seem possible with the current API. Rather than adding a lot of options specifying exactly how the filtering behaves it might be easier and more sensible to provide a custom filter callback and maybe a filter delay option. The delay would trigger the filter logic only `n` milliseconds after the user has last typed, in case the filter logic is complex or there are many items (- i have 33k -) causing long filter times. Suggested interface for the options: ```ts interface QuickPickOptions { // ... /** * Time in milliseconds to wait after last user input * before filtering the list. * @default 0 */ filterDelay: number, /** * Optional filter callback which overrides the default filter * behavior. The callback is called for every item in the list * with the current user input. * @default undefined */ filterCallback?: (item: QuickPickItem | string, filterText: string) => boolean, } ``` I had a look at handling a quick pick "manually" by using `createQuickPick` but it also filters completely automatically. --- Maybe `QuickPickOptions` could also be made generic. It already has the `onDidSelectItem` property which uses a union for the item type instead of a generic. Then functions like `showQuickPick<T extends QuickPickItem>` could propagate their generic type to the options argument.
feature-request,quick-pick
low
Major
563,986,569
flutter
[google_maps_flutter] Plans for adapting Maps SDK Utility Library for google_maps_flutter
## Use case Adape the existing Maps SDK Utility Libraries on [Android](https://github.com/googlemaps/android-maps-utils) and [iOS](https://github.com/googlemaps/google-maps-ios-utils) Adapting the existing utility library from both native platforms will allow: - Rendering KML and GeoJSON - Rendering Heatmap - Other features from the utility libraries ## Proposal #### Approach 1: To create a separate plugin, which depends on the existing `google_maps_flutter` Since the existing utility only requires a reference to the map view, I think is the easiest approach. I have try to build a plugin which depends on the `google_maps_flutter`. However, it seems impossible to get a reference on the MapView, since the plugin passes a `GoogleMapFactory` directly to flutter and no way of getting the MapView reference. #### Approach 2: Add utility implementation to the main `google_map_flutter` library. However, this seems to be an approach which contradicts the motivation of the existing separate native utility libraries. Does the Flutter team currently have any plans for adapting the utility libraries?
c: new feature,p: maps,package,c: proposal,team-ecosystem,P3,triaged-ecosystem
medium
Major
564,080,826
rust
Tracking issue for target_feature 1.1 RFC
This is a tracking issue for the RFC "target_feature 1.1" (rust-lang/rfcs#2396). Issues: https://github.com/rust-lang/rust/labels/F-target_feature_11 ## People *Last updated in Mar 2023:* * Shepherd: ~~gnzlbg~~ @workingjubilee (person who can help answer tricky questions that arise during implementation) * Lang team liaison: @joshtriplett (main point of contact from lang team) ## Step - [x] Implement the RFC: https://github.com/rust-lang/rust/pull/69274 - [ ] Adjust documentation: https://github.com/rust-lang/reference/pull/1181 - [x] Stabilization PR ([see instructions on rustc-guide][stabilization-guide]) - [x] Revert? https://github.com/rust-lang/rust/pull/108654 - I suppose we're off the end of the script, here. Bugs to fix: - [x] https://github.com/rust-lang/rust/issues/108645 - [x] https://github.com/rust-lang/rust/issues/108646 - [x] https://github.com/rust-lang/rust/issues/108655 - [ ] https://github.com/rust-lang/rust/issues/116558 - [x] https://github.com/rust-lang/rust/issues/131058 - [ ] Re-stabilization PR: https://github.com/rust-lang/rust/pull/134090 [stabilization-guide]: https://rust-lang.github.io/rustc-guide/stabilization_guide.html#stabilization-pr [doc-guide]: https://rust-lang.github.io/rustc-guide/stabilization_guide.html#documentation-prs ## Unresolved questions * ~~https://github.com/rust-lang/rust/issues/72012 -- soundness hole where safe target-feature functions implement the `Fn` traits.~~ * ~~#73631 -- behavior of closures and target-features~~ <!-- TRIAGEBOT_START --> <!-- TRIAGEBOT_ASSIGN_START --> <!-- TRIAGEBOT_ASSIGN_DATA_START$${"user":null}$$TRIAGEBOT_ASSIGN_DATA_END --> <!-- TRIAGEBOT_ASSIGN_END --> <!-- TRIAGEBOT_END -->
T-lang,B-unstable,B-RFC-implemented,C-tracking-issue,F-target_feature_11,S-tracking-ready-to-stabilize,A-target-feature
medium
Critical
564,091,110
rust
Tracking Issue for `std::cell::{Ref, RefMut}::leak`
#68712 adds methods to convert `RefCell` guards `Ref`/`RefMut` into references with the lifetime of the underlying cell. The feature gate for the issue is `#![feature(cell_leak)]`. ### Unresolved Questions - [ ] Should similar methods be provided for `MutexGuard` and `RwLockReadGuard`/`RwLockWriteGuard`? - [ ] Should `unsafe` methods be added to forcefully revert a leak? - [ ] For `undo_leak`, would it make more sense not to return a reference (i.e., separate this from `get_mut`)?
T-libs-api,B-unstable,C-tracking-issue,Libs-Tracked
low
Major
564,140,402
pytorch
[feature request] Add "groups" argument to nn.Fold and nn.Unfold
## πŸš€ Feature Add a `groups` argument to the `Fold` and `Unfold` modules (and the corresponding functions in `functional`) ## Motivation Currently it is a little bit cumbersome to implement e.g. a custom `AvgPool2d` or `MaxPool2d` filter using `Fold` and `Unfold`, as the channel information is not retained. For an input of shape `[B, C, H, W]` `Fold` will output an array of `[B, #pixels_per_window, #windows]` and it is cumbersome to divide that up into the channels again in this stage. ## Pitch Adding a `group` argument (just like in the `Convxd` modules) would simplify that (by choosing `groups=C`), and provide a natural extension of these modules. I'd suggest for `Fold` to output a shape of `[B, groups, #pixels_per_window, #windows]` instead. ## Alternatives I don't think there are any really elegant alternatives. `Fold` and `Unfold` are provide to implement custom filtering and pooling functionality. ## Additional context none
feature,module: nn,triaged
low
Minor
564,140,642
flutter
Move "flutter update-packages" command to dev
The flutter update packages command is only used to initialize/upgrade/track dependencies for the flutter repo. If it is accidentally invoked by a user, they may put their repository into a bad state which requires either resetting it with git or re-downloading. To guard against this, we should move the logic of this command to dev, and leave a breadcrumb in the tool to the new location. @zanderso
team,tool,c: proposal,P3,team-tool,triaged-tool
low
Minor
564,202,741
flutter
[fuchsia] Have a way to specify the observatory port in Flutter runner
I wasn't able to find a canonical example that does this, so I think this is not wired in as of today. This would require us passing some parameter to the Dart isolate when we construct it. cc: @kf6gpe
customer: fuchsia,framework,dependency: fuchsia,platform-fuchsia,P2,team-framework,triaged-framework
low
Minor
564,210,873
create-react-app
all file names lowercase - use hyphens instead of camelcase
Strange mixture of camelcase and hyphenated files when I used: ``` npx create-react-app . --typescript ``` ![Screenshot from 2020-02-12 11-15-19](https://user-images.githubusercontent.com/11139560/74368738-15cf8000-4d89-11ea-99b5-557c2aa0cc55.png) I would recommend only lowercase filenames - the technical reason is that macos is case insensitive and linux is not. so macos fs won't see file renamings easily when using git etc. people that know will know what I am talking about
issue: proposal,needs triage
low
Major
564,225,160
pytorch
PyTorch 1.4.0 CUDA initialization error with CPU-only (multiprocessing) on Python 3.7.5
## Bug Using only the CPU device, PyTorch 1.4.0 crashes on Python 3.7.5 when training a neural network on the main process and then training a different network on child processes. ## To Reproduce Steps to reproduce the behavior: 1. Train a neural network on the parent process 2. Create 5 child processes and train the neural network on them, sleeping to wait for background activity 3. Observe the error **Code to Reproduce** ```import random from multiprocessing import Process, Queue import time import torch import torch.nn as nn import torch.optim as optim print("PyTorch: {}".format(torch.__version__)) def init_weights(m): if type(m) == nn.Linear: m.weight.data.uniform_() m.bias.data.uniform_() def do_neural_stuff(): # Initialize the network fcffnn = nn.Sequential( nn.Linear(1, 10), nn.Sigmoid(), nn.Linear(10, 10), nn.Sigmoid(), nn.Linear(10, 2) ) fcffnn.apply(init_weights) # Run the network loss_f = nn.CrossEntropyLoss() opt = optim.Adam(fcffnn.parameters(), lr = 3e-4, weight_decay = 0.001) # Compute loss, backpropagate, adjust params along neg error gradient output = fcffnn(torch.tensor([0], dtype=torch.float)) loss = loss_f(output.view(1, 2), torch.tensor([1], dtype=torch.long)) fcffnn.zero_grad() loss.backward() opt.step() # Run the network on the parent process do_neural_stuff() # PyTorch works as expected when this line is commented out def parallelModelRunnerProc(proc_nb, response_queue): print("Forked Process {}".format(proc_nb)) do_neural_stuff() # This is important -- without the sleep(), the threads exit # without ever crashing due to a native error in this simplified example time.sleep(5) r_queue.put(True) # 1) Run the network on 5 child processes # 2) Wait for background activity (CUDA initialization -- even though it is not asked for) # 3) Observe and report error r_queue = Queue() servers = [] nb_responses = 0 child_ct = 5 for proc_nb in range(child_ct): server = Process(target=parallelModelRunnerProc, args=(proc_nb, r_queue)) server.start() servers.append(server) while nb_responses < child_ct: nb_dead = sum([not x.is_alive() for x in servers]) if not r_queue.empty(): r_queue.get() nb_responses += 1 if nb_dead > nb_responses: raise Exception("Something died unexpectedly") ``` **Program Output** ``` PyTorch: 1.4.0 terminate called after throwing an instance of 'c10::Error' what(): CUDA error: initialization error (setDevice at /pytorch/c10/cuda/impl/CUDAGuardImpl.h:42) frame #0: c10::Error::Error(c10::SourceLocation, std::string const&) + 0x33 (0x7fe417f65193 in /home/nick.roth/ml_python/lib/python3.7/site-packages/torch/lib/libc10.so) frame #1: <unknown function> + 0xd0c8 (0x7fe4181980c8 in /home/nick.roth/ml_python/lib/python3.7/site-packages/torch/lib/libc10_cuda.so) frame #2: torch::autograd::Engine::set_device(int) + 0x159 (0x7fe3bd8a8fd9 in /home/nick.roth/ml_python/lib/python3.7/site-packages/torch/lib/libtorch.so) frame #3: torch::autograd::Engine::thread_init(int) + 0x1a (0x7fe3bd8a995a in /home/nick.roth/ml_python/lib/python3.7/site-packages/torch/lib/libtorch.so) frame #4: torch::autograd::python::PythonEngine::thread_init(int) + 0x2a (0x7fe40449891a in /home/nick.roth/ml_python/lib/python3.7/site-packages/torch/lib/libtorch_python.so) frame #5: <unknown function> + 0xedef (0x7fe418b80def in /home/nick.roth/ml_python/lib/python3.7/site-packages/torch/_C.cpython-37m-x86_64-linux-gnu.so) frame #6: <unknown function> + 0x76db (0x7fe41ca896db in /lib/x86_64-linux-gnu/libpthread.so.0) frame #7: clone + 0x3f (0x7fe41c7b288f in /lib/x86_64-linux-gnu/libc.so.6) terminate called after throwing an instance of 'c10::Error' what(): CUDA error: initialization error (setDevice at /pytorch/c10/cuda/impl/CUDAGuardImpl.h:42) frame #0: c10::Error::Error(c10::SourceLocation, std::string const&) + 0x33 (0x7fe417f65193 in /home/nick.roth/ml_python/lib/python3.7/site-packages/torch/lib/libc10.so) frame #1: <unknown function> + 0xd0c8 (0x7fe4181980c8 in /home/nick.roth/ml_python/lib/python3.7/site-packages/torch/lib/libc10_cuda.so) frame #2: torch::autograd::Engine::set_device(int) + 0x159 (0x7fe3bd8a8fd9 in /home/nick.roth/ml_python/lib/python3.7/site-packages/torch/lib/libtorch.so) frame #3: torch::autograd::Engine::thread_init(int) + 0x1a (0x7fe3bd8a995a in /home/nick.roth/ml_python/lib/python3.7/site-packages/torch/lib/libtorch.so) frame #4: torch::autograd::python::PythonEngine::thread_init(int) + 0x2a (0x7fe40449891a in /home/nick.roth/ml_python/lib/python3.7/site-packages/torch/lib/libtorch_python.so) frame #5: <unknown function> + 0xedef (0x7fe418b80def in /home/nick.roth/ml_python/lib/python3.7/site-packages/torch/_C.cpython-37m-x86_64-linux-gnu.so) frame #6: <unknown function> + 0x76db (0x7fe41ca896db in /lib/x86_64-linux-gnu/libpthread.so.0) frame #7: clone + 0x3f (0x7fe41c7b288f in /lib/x86_64-linux-gnu/libc.so.6) terminate called after throwing an instance of 'c10::Error' what(): CUDA error: initialization error (setDevice at /pytorch/c10/cuda/impl/CUDAGuardImpl.h:42) frame #0: c10::Error::Error(c10::SourceLocation, std::string const&) + 0x33 (0x7fe417f65193 in /home/nick.roth/ml_python/lib/python3.7/site-packages/torch/lib/libc10.so) frame #1: <unknown function> + 0xd0c8 (0x7fe4181980c8 in /home/nick.roth/ml_python/lib/python3.7/site-packages/torch/lib/libc10_cuda.so) frame #2: torch::autograd::Engine::set_device(int) + 0x159 (0x7fe3bd8a8fd9 in /home/nick.roth/ml_python/lib/python3.7/site-packages/torch/lib/libtorch.so) frame #3: torch::autograd::Engine::thread_init(int) + 0x1a (0x7fe3bd8a995a in /home/nick.roth/ml_python/lib/python3.7/site-packages/torch/lib/libtorch.so) frame #4: torch::autograd::python::PythonEngine::thread_init(int) + 0x2a (0x7fe40449891a in /home/nick.roth/ml_python/lib/python3.7/site-packages/torch/lib/libtorch_python.so) frame #5: <unknown function> + 0xedef (0x7fe418b80def in /home/nick.roth/ml_python/lib/python3.7/site-packages/torch/_C.cpython-37m-x86_64-linux-gnu.so) frame #6: <unknown function> + 0x76db (0x7fe41ca896db in /lib/x86_64-linux-gnu/libpthread.so.0) frame #7: clone + 0x3f (0x7fe41c7b288f in /lib/x86_64-linux-gnu/libc.so.6) terminate called after throwing an instance of 'c10::Error' what(): CUDA error: initialization error (setDevice at /pytorch/c10/cuda/impl/CUDAGuardImpl.h:42) frame #0: c10::Error::Error(c10::SourceLocation, std::string const&) + 0x33 (0x7fe417f65193 in /home/nick.roth/ml_python/lib/python3.7/site-packages/torch/lib/libc10.so) frame #1: <unknown function> + 0xd0c8 (0x7fe4181980c8 in /home/nick.roth/ml_python/lib/python3.7/site-packages/torch/lib/libc10_cuda.so) frame #2: torch::autograd::Engine::set_device(int) + 0x159 (0x7fe3bd8a8fd9 in /home/nick.roth/ml_python/lib/python3.7/site-packages/torch/lib/libtorch.so) frame #3: torch::autograd::Engine::thread_init(int) + 0x1a (0x7fe3bd8a995a in /home/nick.roth/ml_python/lib/python3.7/site-packages/torch/lib/libtorch.so) frame #4: torch::autograd::python::PythonEngine::thread_init(int) + 0x2a (0x7fe40449891a in /home/nick.roth/ml_python/lib/python3.7/site-packages/torch/lib/libtorch_python.so) frame #5: <unknown function> + 0xedef (0x7fe418b80def in /home/nick.roth/ml_python/lib/python3.7/site-packages/torch/_C.cpython-37m-x86_64-linux-gnu.so) frame #6: <unknown function> + 0x76db (0x7fe41ca896db in /lib/x86_64-linux-gnu/libpthread.so.0) frame #7: clone + 0x3f (0x7fe41c7b288f in /lib/x86_64-linux-gnu/libc.so.6) terminate called after throwing an instance of 'c10::Error' what(): CUDA error: initialization error (setDevice at /pytorch/c10/cuda/impl/CUDAGuardImpl.h:42) frame #0: c10::Error::Error(c10::SourceLocation, std::string const&) + 0x33 (0x7fe417f65193 in /home/nick.roth/ml_python/lib/python3.7/site-packages/torch/lib/libc10.so) frame #1: <unknown function> + 0xd0c8 (0x7fe4181980c8 in /home/nick.roth/ml_python/lib/python3.7/site-packages/torch/lib/libc10_cuda.so) frame #2: torch::autograd::Engine::set_device(int) + 0x159 (0x7fe3bd8a8fd9 in /home/nick.roth/ml_python/lib/python3.7/site-packages/torch/lib/libtorch.so) frame #3: torch::autograd::Engine::thread_init(int) + 0x1a (0x7fe3bd8a995a in /home/nick.roth/ml_python/lib/python3.7/site-packages/torch/lib/libtorch.so) frame #4: torch::autograd::python::PythonEngine::thread_init(int) + 0x2a (0x7fe40449891a in /home/nick.roth/ml_python/lib/python3.7/site-packages/torch/lib/libtorch_python.so) frame #5: <unknown function> + 0xedef (0x7fe418b80def in /home/nick.roth/ml_python/lib/python3.7/site-packages/torch/_C.cpython-37m-x86_64-linux-gnu.so) frame #6: <unknown function> + 0x76db (0x7fe41ca896db in /lib/x86_64-linux-gnu/libpthread.so.0) frame #7: clone + 0x3f (0x7fe41c7b288f in /lib/x86_64-linux-gnu/libc.so.6) Traceback (most recent call last): File "pytorch_crash.py", line 69, in <module> raise Exception("Something died unexpectedly") Exception: Something died unexpectedly ``` ## Expected behavior PyTorch should be usable on both child and parent processes if the CUDA device is never used. ## Environment ``` PyTorch version: 1.4.0 Is debug build: No CUDA used to build PyTorch: 10.1 OS: Ubuntu 18.04.4 LTS GCC version: (Ubuntu 7.4.0-1ubuntu1~18.04.1) 7.4.0 CMake version: Could not collect Python version: 3.7 Is CUDA available: Yes CUDA runtime version: Could not collect GPU models and configuration: GPU 0: Tesla V100-SXM2-16GB Nvidia driver version: 435.21 cuDNN version: Could not collect Versions of relevant libraries: [pip3] numpy==1.18.1 [pip3] torch==1.4.0 [pip3] torchvision==0.5.0 [conda] Could not collect ``` CUDA version is 10.1 based on output from `nvidia-smi`. PyTorch was installed on a virtualenv using pip. The machine used to reproduce this bug is an AWS p3.2xlarge instance with CUDA support provided by nvidia-driver-435 and nvidia-utils-435 packages. The box was deployed in the `us-west-2` AWS region with the `ubuntu/images/hvm-ssd/ubuntu-bionic-18.04-amd64-server-20190212.1 (ami-005bdb005fb00e791)` base image. ## Additional context Similar reports to this exist, but they either lack reproducibility or are classified as user error since the programmer attempts to use CUDA on multiple processes in a tree. See #30900, #2517 and #3491. In our environment, using `spawn` instead of `fork` to create the child processes does not resolve the issue. cc @ezyang @SsnL @albanD @zou3519 @gqchen @ngimel
module: autograd,module: cuda,triaged
low
Critical
564,265,025
pytorch
Core dumps being created when running test_c10d.py and test_multiprocessing_spawn.py
## πŸ› Bug When running `test/distributed/test_c10d.py` and `test/test_multiprocessing_spawn.py` in Power CI (and when run on my local Power system), some core files appear in the repo even though all the tests pass. I dug a little deeper and it looks like they're being caused by `NcclErrorHandlingTest.test_nccl_errors_blocking_abort` and `ForkTest.test_terminate_signal`. Both of these tests seem to be testing that terminating processes exit when some errors are thrown or a signal is sent. When running in CI, `.jenkins/pytorch/test.sh` checks that the repository is clean every tests are run. Isn't it reasonable to expect that these tests cases would create core dumps sometimes? I've only seen this on Power. `NcclErrorHandlingTest.test_nccl_errors_blocking_abort` seems to be passing fine on x86 without creating any core dumps, but `ForkTest.test_terminate_signal` isn't run on x86 CI. ## To Reproduce Steps to reproduce the behavior: 1. Build latest master 2. Run `test/test_multiprocessing_spawn.py` and `test/distributed/test_c10d.py`. 3. These should create core dumps in the directory you ran the tests from. 4. When run in CI with `.jenkins/pytorch/test.sh`, creating core dumps causes the script to fail. <!-- If you have a code sample, error messages, stack traces, please provide it here as well --> ## Expected behavior Either no core dumps should be created, or if it's okay for those test cases to create core dumps, the `.jenkins/pytorch/test.sh` script should somehow account for that.
module: tests,triaged
low
Critical
564,278,963
TypeScript
Preserve type aliases on implement interface
<!-- 🚨 STOP 🚨 𝗦𝗧𝗒𝗣 🚨 𝑺𝑻𝑢𝑷 🚨 Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Even if you think you've found a *bug*, please read the FAQ first, especially the Common "Bugs" That Aren't Bugs section! Please help us by doing the following steps before logging an issue: * Search: https://github.com/Microsoft/TypeScript/search?type=Issues * Read the FAQ: https://github.com/Microsoft/TypeScript/wiki/FAQ Please fill in the *entire* template below. --> From https://github.com/microsoft/vscode/issues/90061 <!-- Please try to reproduce the issue with the latest published version. It may have already been fixed. For npm: `typescript@next` This is also the 'Nightly' version in the playground: http://www.typescriptlang.org/play/?ts=Nightly --> **TypeScript Version:** 3.8.1-rc <!-- Search terms you tried before logging this (so others can find this issue more easily) --> **Search Terms:** - quick fix - implement interface **Repo** ```ts export type UrlString = string; export type UUID = string; export interface I_IdToUrlMapper { mapIdToUrl(id: UUID): UrlString mapUrlToId(url: UrlString): UUID } export class IdToUrlMapper implements I_IdToUrlMapper { } ``` Run implement interface on `IdToUrlMapper ` **Expected behavior:** Type aliases are preserved ```ts export class IdToUrlMapper implements I_IdToUrlMapper { mapIdToUrl(id: UUID): UrlString { throw new Error("Method not implemented."); } mapUrlToId(url: UrlString): UUID { throw new Error("Method not implemented."); } } ``` **Actual behavior:** Both methods use `string`: ```ts export class IdToUrlMapper implements I_IdToUrlMapper { mapIdToUrl(id: string): string { throw new Error("Method not implemented."); } mapUrlToId(url: string): string { throw new Error("Method not implemented."); } } ``` **Related Issues** - https://github.com/microsoft/TypeScript/issues/34778
Suggestion,Experience Enhancement
low
Critical
564,312,388
godot
Scaled CanvasLayer reports wrong area to child nodes
**Godot version:** 3.2 **OS/device including version:** Windows 10 **Issue description:** When a `CanvasLayer` is scaled, it's children get the viewport size when requesting their parent's area size. This means that a scaled `CanvasLayer`'s children will anchor wrong. ![CanvasLayerBug](https://user-images.githubusercontent.com/9751923/74382629-ffd2b700-4daa-11ea-9abe-fc6bb86b545a.gif) **Steps to reproduce:** 1. Create a `2DNode` scene 2. Add a `CanvasLayer` with `scale` set to `(2,2)` 3. Add a `Control` as a child of the `CanvasLayer` and set it's Layout to `Full Rect` Note that the control is now twice the size of the actual viewport. **Minimal reproduction project:** https://github.com/cgbeutler/godot_bugs_CanvasLayerScaleAnchorsBug
bug,topic:gui
low
Critical
564,320,841
rust
Conflicting error messages for HRTB in `impl Trait`
Rust declares the lifetime `'a` is both undeclared and that it is a shadowing declaration ```rust #[derive(Debug)] struct Ctx<'d> { phantom: std::marker::PhantomData<&'d ()> } fn map<'c, 'd: 'c>(ctx: &'c mut Ctx<'d>, data: Vec<()>) -> impl for<'a> Iterator<Item = ()> + 'a where 'c: 'a { data.into_iter().inspect(|t| println!("{:?}", ctx)) } ``` My more complicated example is trying to use the `&'c mut Ctx<'d>` reference in one of the closures passed to `Iterator::map()` so I need to somehow incorporate the lifetime `'c` into the return type. Instead I get this confusing error: ``` error[E0261]: use of undeclared lifetime name `'a` --> src/lib.rs:5:95 | 5 | fn map<'c, 'd: 'c>(ctx: &'c mut Ctx<'d>, data: Vec<()>) -> impl for<'a> Iterator<Item = ()> + 'a where 'c: 'a { | ^^ undeclared lifetime error[E0496]: lifetime name `'a` shadows a lifetime name that is already in scope --> src/lib.rs:5:69 | 5 | fn map<'c, 'd: 'c>(ctx: &'c mut Ctx<'d>, data: Vec<()>) -> impl for<'a> Iterator<Item = ()> + 'a where 'c: 'a { | ^^ -- first declared here | | | lifetime 'a already in scope error[E0261]: use of undeclared lifetime name `'a` --> src/lib.rs:5:108 | 5 | fn map<'c, 'd: 'c>(ctx: &'c mut Ctx<'d>, data: Vec<()>) -> impl for<'a> Iterator<Item = ()> + 'a where 'c: 'a { | ^^ undeclared lifetime error: aborting due to 3 previous errors ``` You'll notice the `help` text of the first error says "undeclared lifetime" but the `help` of the second says "first declared here" and then gives a bogus "already in scope" hint.
A-diagnostics,A-lifetimes,T-compiler,A-impl-trait,C-bug
low
Critical
564,341,984
flutter
Failed to extract manifest from APK // aapt.EXE stop working.
I installed flutter and dart then tried to test the default app of flutter on web and it worked well. Then tried to test the app on my own phone i get that error : windows [Version 10.0.17763.1039] (c) 2018 Microsoft Corporation. All rights reserved. D:\tests\flutter_appd>flutter run Launching lib\main.dart on STK LX1 in debug mode... Running Gradle task 'assembleDebug'... Running Gradle task 'assembleDebug'... Done 117.9s √ Built build\app\outputs\apk\debug\app-debug.apk. After this step i got a message saying that " aapt.EXE stop working " then Failed to extract manifest from APK: ProcessException: The command failed Command: C:\Users\User\AppData\Local\Android\sdk\build-t ools\28.0.3\aapt dump xmltree D:\tests\flutter_appd\build\app\outputs\apk\app.apk AndroidManifest.xml. Problem building Android application: see above error(s). thank you.
platform-android,tool,t: gradle,P2,team-android,triaged-android
low
Critical
564,345,337
node
HTTP 1.1 fallback for HTTP 2 client
I discussed this a while back with @jasnell and I forget where it all landed and what was needed. I’d like to make it so that [`bent`](https://github.com/mikeal/bent) uses HTTP2 when available and falls back to HTTP 1.1 transparently when it’s not available. This should be possible, the standard was certainly designed that way, but I can’t find any examples of doing this in Node.js and the core http client libraries are totally separate. It could just be a documentation issue but I think there might actually be some missing API in order to make it work.
http,http2
medium
Major
564,365,374
TypeScript
[Breaking Change] Typescript 3.7 converts reference paths to tsconfig specified paths breaking multi-project compiles.
<!-- 🚨 STOP 🚨 𝗦𝗧𝗒𝗣 🚨 𝑺𝑻𝑢𝑷 🚨 Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Even if you think you've found a *bug*, please read the FAQ first, especially the Common "Bugs" That Aren't Bugs section! Please help us by doing the following steps before logging an issue: * Search: https://github.com/Microsoft/TypeScript/search?type=Issues * Read the FAQ: https://github.com/Microsoft/TypeScript/wiki/FAQ Please fill in the *entire* template below. --> Typescript is replacing part of a relative path with one of the paths specified in tsconfig's path section. This is breaking the projects that rely on this file as they cannot resolve the path. <!-- Please try to reproduce the issue with the latest published version. It may have already been fixed. For npm: `typescript@next` This is also the 'Nightly' version in the playground: http://www.typescriptlang.org/play/?ts=Nightly --> **TypeScript Version:** 3.7 **Visual Studio Version:** Community 2017 <!-- Search terms you tried before logging this (so others can find this issue more easily) --> **Search Terms:** Typescirpt paths tsconfig reference paths alias. **Code** In the client project at `folder\folder\file.ts` ```ts /// <reference path="../../External/Knockout/index.d.ts" /> ``` Becomes (in ClientDeclarations) `folder\folder\file.d.ts`: ```ts /// <reference types="@Client/external/knockout/index" /> ``` My tsconfig file (folder names with sensitive information are replaced with `***`) ```json { "compileOnSave": true, "compilerOptions": { "module": "amd", "target": "es6", "lib": [ "es6", "dom" ], "sourceMap": true, "strict": true, "build": true, "declaration": true, "declarationDir": "../ClientDeclarations", "baseUrl": "./", "paths": { "@Common/*": [ "../Common/*" ], "@Server/*": [ "../ServerDeclarations/*" ], "@Client/*": [ "./*"] } }, "include": [ "./*", "./External/***/koco.ts", "./External/***/kocss.ts", "./External/***/kopath.ts" ], "exclude": [ "node_modules" ], "references": [ { "path": "../Common" } ] } ``` **Expected behavior:** The path should not be transformed during output. **Actual behavior:** The path is transformed to include an `@Client` reference, which my dependant projects can't resolve. **This did not happen in tsc 3.4**. Additionally all of the casing is altered - meaning that this path would not resolve on linux machines. **Related Issues:** <!-- Did you find other bugs that looked similar? --> I haven't been able to find any - probably because what I'm trying to look for is called a "path" (in tsconfig) which is a highly overloaded term, making searching for anything related to it almost impossible. It would be nice to call it something like a "path alias" so that searching for related issues was easier.
Needs Investigation
low
Critical
564,419,616
pytorch
Uninitialised value was created by a stack allocation, reported by valgrind
``` ==17== Memcheck, a memory error detector ==17== Copyright (C) 2002-2017, and GNU GPL'd, by Julian Seward et al. ==17== Using Valgrind-3.15.0 and LibVEX; rerun with -h for copyright info ==17== Command: ros/src/inference_api/test_graph_pytorch ==17== ==17== Warning: set address range perms: large range [0x14dfa000, 0x373f0000) (defined) ==17== Warning: set address range perms: large range [0x5ddf4000, 0x72c1b000) (defined) 2020-02-13 03:23:28.469999: I external/org_tensorflow/tensorflow/stream_executor/platform/default/dso_loader.cc:42] Successfully opened dynamic library libcudart.so.10.0 2020-02-13 03:23:30.154755: I external/org_tensorflow/tensorflow/stream_executor/platform/default/dso_loader.cc:42] Successfully opened dynamic library libcudart.so.10.0 ==17== Conditional jump or move depends on uninitialised value(s) ==17== at 0x4B7E905: IValue (ivalue.h:66) ==17== by 0x4B7E905: optional (Optional.h:401) ==17== by 0x4B7E905: c10::Argument::Argument(c10::Argument const&) (function_schema.h:34) ==17== by 0x4B7DD97: construct<c10::Argument, c10::Argument &> (memory:1825) ==17== by 0x4B7DD97: __construct<c10::Argument, c10::Argument &> (memory:1717) ==17== by 0x4B7DD97: construct<c10::Argument, c10::Argument &> (memory:1560) ==17== by 0x4B7DD97: __construct_range_forward<c10::Argument *, c10::Argument *> (memory:1645) ==17== by 0x4B7DD97: __construct_at_end<c10::Argument *> (vector:1074) ==17== by 0x4B7DD97: std::__1::vector<c10::Argument, std::__1::allocator<c10::Argument> >::vector(std::__1::vector<c10::Argument, std::__1::allocator<c10::Argument> > const&) (vector:1257) ==17== by 0x12AC2F6B: c10::FunctionSchema::FunctionSchema(c10::FunctionSchema const&) (function_schema.h:132) ==17== by 0x139D366A: c10::RegisterOperators::registerOp_(c10::RegisterOperators::Options&&) (op_registration.cpp:138) ==17== by 0x139D247D: c10::RegisterOperators::checkSchemaAndRegisterOp_(c10::RegisterOperators::Options&&) (op_registration.cpp:59) ==17== by 0x138BF44D: op (op_registration.h:455) ==17== by 0x138BF44D: __cxx_global_var_init (Copy.cpp:168) ==17== by 0x138BF44D: _GLOBAL__sub_I_Copy.cpp (Copy.cpp:0) ==17== by 0x4010732: call_init (dl-init.c:72) ==17== by 0x4010732: _dl_init (dl-init.c:119) ==17== by 0x40010C9: ??? (in /lib/x86_64-linux-gnu/ld-2.27.so) ==17== Uninitialised value was created by a stack allocation ==17== at 0x12DAD3CD: torch::jit::script::(anonymous namespace)::SchemaParser::parseArgument(unsigned long, bool, bool) (function_schema_parser.cpp:112) ==17== { <insert_a_suppression_name_here> Memcheck:Cond fun:IValue fun:optional fun:_ZN3c108ArgumentC2ERKS0_ fun:construct<c10::Argument, c10::Argument &> fun:__construct<c10::Argument, c10::Argument &> fun:construct<c10::Argument, c10::Argument &> fun:__construct_range_forward<c10::Argument *, c10::Argument *> fun:__construct_at_end<c10::Argument *> fun:_ZNSt3__16vectorIN3c108ArgumentENS_9allocatorIS2_EEEC2ERKS5_ fun:_ZN3c1014FunctionSchemaC2ERKS0_ fun:_ZN3c1017RegisterOperators11registerOp_EONS0_7OptionsE fun:_ZN3c1017RegisterOperators25checkSchemaAndRegisterOp_EONS0_7OptionsE fun:op fun:__cxx_global_var_init fun:_GLOBAL__sub_I_Copy.cpp fun:call_init fun:_dl_init obj:/lib/x86_64-linux-gnu/ld-2.27.so } ==17== ==17== Exit program on first error (--exit-on-first-error=yes) ``` cc @ezyang @gchanan @zou3519 @suo
triage review,oncall: jit,triaged
low
Critical
564,438,945
node
readline hangs the process on Win10
<!-- Thank you for reporting an issue. This issue tracker is for bugs and issues found within Node.js core. If you require more general support please file an issue on our help repo. https://github.com/nodejs/help Please fill in as much of the template below as you're able. Version: output of `node -v` Platform: output of `uname -a` (UNIX), or version and 32 or 64-bit (Windows) Subsystem: if known, please specify affected core module name --> * **Version**: node v13.8.0 * **Platform**: Win 10 64-bit * **Subsystem**: Git For Windows 2.25.0, mintty 3.1.0 (x86_64-pc-msys) ### What steps will reproduce the bug? ``` #!/usr/bin/env node const readline = require('readline').createInterface({ input: process.stdin, output: process.stdout }); readline.question('> ', answer => { console.log('answer', answer); readline.close(); }); ``` Running the above relying on the hash-bang/she-bang, `./readline.js`, will make it hang. Running the above using node, `node readline.js`, everything works as expected ### How often does it reproduce? Is there a required condition? Always ### What is the expected behavior? The program should exit back to the shell after the user has pressed <kbd>Enter</kbd> ### What do you see instead? The program hangs and I can't kill it either by Ctrl+D nor Ctrl+C ### Additional information A workaround is to wrap the `close()` call in a `setTimeout` like so ``` #!/usr/bin/env node const readline = require('readline').createInterface({ input: process.stdin, output: process.stdout }); readline.question('> ', answer => { console.log('answer', answer); setTimeout(() => readline.close()); }); ``` This comment is similar, but that one states that it works in Win 10. That is not my experience. https://github.com/nodejs/node/issues/17495#issuecomment-414333565
readline,windows
low
Critical
564,463,879
angular
QueryList change not emitted when using ChangeDetectionStrategy.OnPush
# 🐞 bug report ### Affected Package angular 9.0.1 ### Is this a regression? don't know. ### Description when OnPush and @ViewChildren('something in ng-template') and the template be used in a sibling component. the QueryList.change won't fire ![image](https://user-images.githubusercontent.com/8691013/74405947-5f8f9780-4e69-11ea-9964-d5cc4c78cc58.png) ## πŸ”¬ Minimal Reproduction 1. git clone https://github.com/keatkeat87/angular-viewchild-onpush-issue 2. yarn install 3. ng serve --open 4. F12 open console 5. click "append button" (will see the log 'list.changes', this is correct) 6. go to file 'autocomplete.component.ts' 7. uncomment 'changeDetection: ChangeDetectionStrategy.OnPush' 8. refresh and click "append button" again (list.changes no fire any more, this is incorrect) ## 🌍 Your Environment **Angular Version:** Angular CLI: 9.0.2 Node: 12.14.0 OS: win32 x64 Angular: 9.0.1 ... animations, common, compiler, compiler-cli, core, forms ... language-service, platform-browser, platform-browser-dynamic ... router Ivy Workspace: Yes Package Version ----------------------------------------------------------- @angular-devkit/architect 0.900.2 @angular-devkit/build-angular 0.900.2 @angular-devkit/build-optimizer 0.900.2 @angular-devkit/build-webpack 0.900.2 @angular-devkit/core 9.0.2 @angular-devkit/schematics 9.0.2 @angular/cli 9.0.2 @ngtools/webpack 9.0.2 @schematics/angular 9.0.2 @schematics/update 0.900.2 rxjs 6.5.4 typescript 3.7.5 webpack 4.41.2
type: bug/fix,freq1: low,area: core,state: confirmed,core: queries,core: change detection,P4
low
Critical
564,492,235
go
x/tools/gopls: support for bazel-based projects
### What version of Go are you using (`go version`)? <pre> $ go version go version go1.13.1 linux/amd64 </pre> ### Does this issue reproduce with the latest release? n/a ### What operating system and processor architecture are you using (`go env`)? n/a ### What did you do? Wrote a project with bazel with .go files and .proto files. The protobufs generate go code, which I'm not sure how to make understandable to gopls. Code completion for this code does not work in VSCode. ### What did you expect to see? 1. Documentation of how to set up a Bazel-based project in the [User guide](https://github.com/golang/tools/blob/master/gopls/doc/user.md). 2. An example project that works and loads in an IDE like VS Code ### What did you see instead? Scattered information on the level of support and no example projects. ### Related links: 1. https://github.com/bazelbuild/rules_go/issues/512 - main source of updates on gopackagesdriver progress 2. https://github.com/bazelbuild/rules_go/wiki/Editor-and-tool-integration: Design doc for gopackagesdriver - I'm not sure how accurate this is 3. https://github.com/microsoft/vscode-go/issues/2755 - gopls support for GOPACKAGESDRIVER in VS Code 4. https://github.com/bazelbuild/rules_go/issues/393 - editor integration issue for rules_go 5. https://github.com/golang/go/issues/34341 - documentation request for GOPACKAGESDRIVER 6. Code: [jmhodges/rules_go/go/tools/gopackagesdriver](https://github.com/jmhodges/rules_go/tree/a710386e6956baa4a83d73d406c8d0255354818b/go/tools/gopackagesdriver), [gopackagesdriver in rules_go feature branch](https://github.com/bazelbuild/rules_go/tree/feature/gopackagesdriver/go/tools/gopackagesdriver), [tools/go/packages/external.go](https://github.com/golang/tools/blob/master/go/packages/external.go) seems to implement the external packages driver
FeatureRequest,gopls,Tools
medium
Major
564,510,520
go
testing: when using a custom TestMain, m.Run does not return if one of the tests it runs panics
<!-- Please answer these questions before submitting your issue. Thanks! For questions please use one of our forums: https://github.com/golang/go/wiki/Questions --> ### What version of Go are you using (`go version`)? <pre> $ go version go version go1.13.7 darwin/amd64 </pre> ### Does this issue reproduce with the latest release? Yes ### What operating system and processor architecture are you using (`go env`)? <details><summary><code>go env</code> Output</summary><br><pre> $ go env GO111MODULE="" GOARCH="amd64" GOBIN="" GOCACHE="/Users/yury/Library/Caches/go-build" GOENV="/Users/yury/Library/Application Support/go/env" GOEXE="" GOFLAGS="" GOHOSTARCH="amd64" GOHOSTOS="darwin" GONOPROXY="" GONOSUMDB="" GOOS="darwin" GOPATH="/Users/yury/go" GOPRIVATE="" GOPROXY="https://proxy.golang.org,direct" GOROOT="/usr/local/go" GOSUMDB="sum.golang.org" GOTMPDIR="" GOTOOLDIR="/usr/local/go/pkg/tool/darwin_amd64" GCCGO="gccgo" AR="ar" CC="clang" CXX="clang++" CGO_ENABLED="1" GOMOD="/Users/yury/go/src/github.com/orlangure/myproject/go.mod" CGO_CFLAGS="-g -O2" CGO_CPPFLAGS="" CGO_CXXFLAGS="-g -O2" CGO_FFLAGS="-g -O2" CGO_LDFLAGS="-g -O2" PKG_CONFIG="pkg-config" GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/p1/rjgq2gp55pj58ckbsn94yfz80000gn/T/go-build564127360=/tmp/go-build -gno-record-gcc-switches -fno-common" </pre></details> ### What did you do? I wrote a function, a test for it, and `TestMain` to perform setup and teardown for testing this function: main.go ```go package main import "fmt" func main() { fmt.Println("vim-go") } func p() { panic("foo") } ``` p_test.go ```go package main import "testing" func TestP(t *testing.T) { p() } ``` main_test.go ```go package main import ( "fmt" "os" "testing" ) func TestMain(m *testing.M) { os.Exit(testMain(m)) } func testMain(m *testing.M) int { setup() defer teardown() return m.Run() } func setup() { fmt.Println("setting up") } func teardown() { fmt.Println("tearing down") } ``` ### What did you expect to see? I expected to see "setting up" and "tearing down" at some point, and a panic "foo" message with a stack trace. ### What did you see instead? Only setup and panic output appeared: ``` setting up --- FAIL: TestP (0.00s) panic: foo [recovered] panic: foo goroutine 19 [running]: testing.tRunner.func1(0xc0000b6100) /usr/local/go/src/testing/testing.go:874 +0x3a3 panic(0x1111220, 0x116b4d0) /usr/local/go/src/runtime/panic.go:679 +0x1b2 akeyless.io/akeyless-main-repo/go/src/t.p(...) ... FAIL ``` The program probably called `os.Exit` at some point while running the tests, or panicked in a separate go routine with no way for me to recover. I would expect both setup and teardown functions to be called at some point.
NeedsInvestigation
medium
Critical
564,510,568
pytorch
iOS libtorch superpoint model bug
c++ mac libtorch SuperPoint model forward is success, c++ ios libtorch SuperPoint model forward is loss. forward image size 640x480, ios print coordinates.total() is zero, is loss, mac print coordinates.total() not zero, is success. libtorch info: cpu mode version 1.4.0 code: ``` auto qengines = at::globalContext().supportedQEngines(); if (std::find(qengines.begin(), qengines.end(), at::QEngine::QNNPACK) != qengines.end()) { at::globalContext().setQEngine(at::QEngine::QNNPACK); } module = std::make_shared<torch::jit::script::Module>(torch::jit::load(modelPath)); module->eval(); cv::cvtColor(img, img, CV_BGR2GRAY); std::vector<torch::jit::IValue> input; torch::Tensor x = torch::from_blob(img.data, {1, 1, img.rows, img.cols}, at::kByte).toType(at::kFloat) / 255; torch::autograd::AutoGradMode guard(false); at::AutoNonVariableTypeMode non_var_type_mode(true); input.push_back(x); // inference auto outputs = module->forward(input).toTuple(); torch::Tensor semi = outputs->elements()[0].toTensor(); torch::Tensor coarse_desc = outputs->elements()[1].toTensor(); // std::cout << semi << std::endl; const int CELL = 8; // Deal with feature points locations semi = semi.squeeze(); torch::Tensor dense = semi.exp(); dense = dense / (dense.sum(0) + 0.00001); torch::Tensor nodust = dense.slice(0, 0, dense.size(0) - 1); int Hc = img.rows / CELL; int Wc = img.cols / CELL; nodust = nodust.transpose(0, 1).transpose(1, 2); torch::Tensor heatmap = nodust.reshape({Hc, Wc, CELL, CELL}); heatmap = heatmap.transpose(1, 2); heatmap = heatmap.reshape({Hc * CELL, Wc * CELL}); torch::Tensor heatmap_cpu = heatmap.to(torch::kCPU, /*non_blocking=*/true); // Eigen::Map<Eigen::MatrixXf> eig_heatmap(heatmap_cpu.data<float>(), // heatmap.size(0), heatmap.size(1)); cv::Mat mat_heatmap(heatmap_cpu.size(0), heatmap_cpu.size(1), CV_32F, heatmap_cpu.data<float>()); /** * Filtered to binary mat first and than get non zero value coordinates * cv::threshold(src, dst, threshold, max_binary_value, threshold_type) * threshold_type: 0, Binary * 1, Binary Inverted * 2, Threshold Truncated * 3, Threshold to Zero * 4, Threshold to Zero Inverted */ cv::Mat bin_mat; cv::threshold(mat_heatmap, bin_mat, 0.015, 1, 0); bin_mat.convertTo(bin_mat, CV_8UC1); cv::Mat coordinates; cv::findNonZero(bin_mat, coordinates); printf("size: %d\n",coordinates.total()); ``` **model download:** [super_point_scripted_model.pt.zip](https://github.com/pytorch/pytorch/files/4197136/super_point_scripted_model.pt.zip) about SuperPoint: https://github.com/MagicLeapResearch/SuperPointPretrainedNetwork cc @ezyang
module: macos,oncall: mobile,module: ios,shadow review
low
Critical
564,516,833
PowerToys
"App Starter" PowerToy (with Virtual Desktop support)
### tl;dr: "App Starter" PowerToy Please implement a PowerToy which **automatically starts a list of user defined Apps** on "User Click" or "Windows 10 Startup" ( ...with the possibility to move the apps automatically to Virtual Desktops including predefined window positions.) *See the end of this post for main features and optional ones.* ### l;prn: (long; please read nevertheless) ;) People who work professional with Windows 10 often use and rely on many applications nowadays. (Browser, Mail-Clients, Programming IDEs, GitHub Client, various Messengers, Password-Manager, SFTP-Clients, aso.) After a new start of Windows 10, they have to start them one-by-one by hand. At the moment, there is no convenient and simple way to start all needed apps automatically. (Win32/UWP/BAT) That's time consuming. Also at the moment, there is no way to move the apps automatically to predefined virtual desktops. Virtual Desktop support is unbelievable handy for people working on Laptops. **Feature request:** Build a tool to manage the auto start of predefined scripts + virtual desktop support. ![autostart-apps_power-toy](https://user-images.githubusercontent.com/827658/74411046-b92c9d80-4e3a-11ea-9030-3164442704a1.jpg) ### Current workaround (without Virtual Desktop support) - See screenshot. At the moment you can build a bat-file. (Limitation: No Virtual Desktop support, Hard to get correct ID for UWP apps.) **For simple Win32 Apps, users can** easily build a small bat script file containing something like the below. This will start all Apps included in the bat file with one click. ``` ECHO - Starting... PHPStorm (PHP IDE) cd "C:\Program Files\JetBrains\PhpStorm 2019.1\bin\" explorer.exe phpstorm64.exe ``` **Unfortunately this doesn't work with UWP Apps.** The bat entry should look like below. Simple, but its not so easy to find the correct PackageFamilyName and Executable ID from the AppxManifest. ``` ECHO - Starting... OneNote (Note taking) explorer.exe shell:appsFolder\Microsoft.Office.OneNote_8wekyb3d8bbwe!microsoft.onenoteim ``` ### Main features of the "App Starter" PowerToy: - App-selector (Win32/UWP/BAT), which adds an app to the list of apps to start. - How to execute the "App Starter" PowerToy list? "On click" or on "Windows 10 start". - Optional "Start selected App on Virtual Desktop X and Position Y". ### Optional/Additional nice-to-have features for a "App Starter" PowerToy: - App-Starter profiles (Working / Gaming / ... ) - "Comment field" to add some description for the app / bat / command. (See screenshot) - Allow to add inline command line commands within the app-selector field (...or extra field, if "command" option is selected) - Auto-Startup "countdown" popup on Windows 10 startup: `The "App Starter" PowerToy "Working" will be started in 3 seconds. [Start now | Manage | Cancel]` ("Manage" opens Power Toys GUI)
Idea-New PowerToy,Product-Virtual Desktop
low
Major
564,519,225
rust
Unhelpful suggestion for "cannot infer type" error
<!-- Thank you for filing a bug report! πŸ› Please provide a short summary of the bug, along with any information you feel relevant to replicating the bug. --> I tried this code: ```rust fn main() { let map: HashMap<i32, i32, _> = HashMap::from_iter(vec![(1, 1), (2, 2)].into_iter()); } ``` I expected to see this happen: when run `cargo check`, it should says ``` --> src/main.rs:30:14 | 30 | let map: HashMap<i32, i32, _> = HashMap::from_iter(vec![(1, 1), (2, 2)].into_iter()); | --- ^^^^^^^^^^^^^^^^^^^^ cannot infer type | | | consider change `HashMap<i32, i32, _>` to `HashMap<i32, i32>` because it has a default type, or specify a detail type. ``` Instead, this happened: ``` --> src/main.rs:30:14 | 30 | let map: HashMap<i32, i32, _> = HashMap::from_iter(vec![(1, 1), (2, 2)].into_iter()); | --- ^^^^^^^^^^^^^^^^^^^^ cannot infer type | | | consider giving `map` the explicit type `std::collections::HashMap<i32, i32, _>`, with the type parameters specified ``` ### Meta <!-- If you're using the stable version of the compiler, you should also check if the bug also exists in the beta or nightly versions. --> `rustc --version --verbose`: ``` ustc 1.43.0-nightly (a1912f2e8 2020-02-12) binary: rustc commit-hash: a1912f2e89b77cfe2a0e64b96f444848fe4e2d49 commit-date: 2020-02-12 host: x86_64-unknown-linux-gnu release: 1.43.0-nightly LLVM version: 9.0 ```
C-enhancement,A-diagnostics,T-compiler,A-suggestion-diagnostics
low
Critical
564,608,304
TypeScript
JSDoc @this/@lends/@namespace tags are ignored inside Object
<b>MyElement.d.ts</b> ```ts declare class MyElement { constructor(target: Element); target: Element } ``` <b>MyElement.js</b> `@this` on globally defined function works as expected, Ctrl+Space shows the correct type of target - Element! ![image](https://user-images.githubusercontent.com/6419937/74323355-71ecd100-4d96-11ea-93d8-64a79434a1de.png) `@this` before function in the object doesn't take into account! ![image](https://user-images.githubusercontent.com/6419937/74324433-158ab100-4d98-11ea-94dc-6ab4923ed95d.png) `@lends` before the object itself is also not taken into account! ![image](https://user-images.githubusercontent.com/6419937/74324780-9ba6f780-4d98-11ea-9eba-5e1f84950fff.png) the same with `@namespace` ![image](https://user-images.githubusercontent.com/6419937/74324680-70240d00-4d98-11ea-96b3-df002531d414.png) I couldn't find the way to point the correct "this" type for function in objects. VS Code version: Code 1.42.0 (ae08d5460b5a45169385ff3fd44208f431992451, 2020-02-06T10:51:33.119Z) OS version: Darwin x64 19.3.0 <details> <summary>System Info</summary> |Item|Value| |---|---| |CPUs|Intel(R) Core(TM) i9-9900K CPU @ 3.60GHz (16 x 3600)| |GPU Status|2d_canvas: enabled<br>flash_3d: enabled<br>flash_stage3d: enabled<br>flash_stage3d_baseline: enabled<br>gpu_compositing: enabled<br>metal: disabled_off<br>multiple_raster_threads: enabled_on<br>oop_rasterization: disabled_off<br>protected_video_decode: unavailable_off<br>rasterization: enabled<br>skia_renderer: disabled_off<br>surface_control: disabled_off<br>surface_synchronization: enabled_on<br>video_decode: enabled<br>viz_display_compositor: enabled_on<br>viz_hit_test_surface_layer: disabled_off<br>webgl: enabled<br>webgl2: enabled| |Load (avg)|1, 1, 1| |Memory (System)|32.00GB (7.02GB free)| |Process Argv|| |Screen Reader|no| |VM|0%| </details>Extensions: none <!-- generated by issue reporter -->
Bug,Domain: JSDoc
low
Major
564,633,576
go
x/sys/unix: If mips64le termios Ispeed and Ospeed can work
<!-- Please answer these questions before submitting your issue. Thanks! For questions please use one of our forums: https://github.com/golang/go/wiki/Questions --> In mips64le , The Termios struct doesn't has member Ospeed or Ispeed struct termios { tcflag_t c_iflag; /* input mode flags */ tcflag_t c_oflag; /* output mode flags */ tcflag_t c_cflag; /* control mode flags */ tcflag_t c_lflag; /* local mode flags */ cc_t c_line; /* line discipline */ cc_t c_cc[NCCS]; /* control characters */ }; In golang/sys/unix/ztypes_linux_mips64le.go, I found this define Termios struct { Iflag uint32 Oflag uint32 Cflag uint32 Lflag uint32 Line uint8 Cc [23]uint8 Ispeed uint32 Ospeed uint32 } Will the member Ispped and Ospeed can work ? ### What version of Go are you using (`go version`)? <pre> $ go version go version go1.13.3 linux/mips64le </pre> ### Does this issue reproduce with the latest release? I think so ### What operating system and processor architecture are you using (`go env`)? <details><summary><code>go env</code> Output</summary><br><pre> $ go env GO111MODULE="" GOARCH="mips64le" GOBIN="" GOCACHE="/home/jlzhang/.cache/go-build" GOENV="/home/jlzhang/.config/go/env" GOEXE="" GOFLAGS="" GOHOSTARCH="mips64le" GOHOSTOS="linux" GONOPROXY="" GONOSUMDB="" GOOS="linux" GOPATH="/home/jlzhang/go" GOPRIVATE="" GOPROXY="direct" GOROOT="/usr/lib/golang" GOSUMDB="off" GOTMPDIR="" GOTOOLDIR="/usr/lib/golang/pkg/tool/linux_mips64le" GCCGO="gccgo" GOMIPS64="hardfloat" AR="ar" CC="gcc" CXX="g++" CGO_ENABLED="0" GOMOD="" CGO_CFLAGS="-g -O2" CGO_CPPFLAGS="" CGO_CXXFLAGS="-g -O2" CGO_FFLAGS="-g -O2" CGO_LDFLAGS="-g -O2" PKG_CONFIG="pkg-config" GOGCCFLAGS="-fPIC -mabi=64 -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build438676280=/tmp/go-build -gno-record-gcc-switches" </pre></details> ### What did you do? I use termios ,but can not work. I found the diffrent between syscall and unix <!-- If possible, provide a recipe for reproducing the error. A complete runnable program is good. A link on play.golang.org is best. --> no ### What did you expect to see? no ### What did you see instead? no
NeedsDecision
low
Critical
564,634,755
TypeScript
Type not narrowed by === when equivalent type guard works
**TypeScript Version:** 3.7.5, also tested on 3.9.0-dev.20200212 **Search Terms:** equals, type guard, type parameter, narrowing **Code** ```ts type AorB = 'a' | 'b'; function isA(t: AorB): t is 'a' { return t === 'a'; } function test<T extends AorB>(arg: T) { if (isA(arg)) { let a1: T & 'a' = arg; // ok } if (arg === 'a') { let a2: T & 'a' = arg; // error } } ``` **Expected behavior:** The condition `arg === 'a'` should narrow the type of `arg` to `T & 'a'` in the second `if` block, in the same way as the equivalent type guard function does. **Actual behavior:** The type of `arg` is not narrowed in the second `if` block. **Playground Link:** [Playground Link](http://www.typescriptlang.org/play/?ts=3.9.0-dev.20200212&ssl=15&ssc=1&pln=7&pc=1#code/C4TwDgpgBAgg9gJwEJQLxQOQEMNQD6YBGGA3AFBkBmArgHYDGwAlnLVEwM4wAUwAXLERIAlAODsOmHFADeZKFAQRg1BG3GpNU0mQC+FGg2asowCB2AAeACpQIADzO0AJpPjIAfNywIA5gOthWXl2SihuTh4fX2EguQUFABtlKCwARgCoADJtNFS-EigAeiKoOABrEP0FJjDvPzQtbAw4kKSUrAAmTJzmvOjCkrsEBEQqvTIgA) **Related Issues:** N/A
Bug,Rescheduled
low
Critical
564,634,903
angular
Hierarchical injectors @Host() decorator explanation incomplete
# πŸ“š Docs or angular.io bug report ### Description The description of the @Host() decorator is the same as the description of the @Self() decorator. Because the FlowerService is provided in the component itself, the @Host() decorator has no purpose in the example, without @SkipSelf() the FlowerService will always come from the provider declared on the HostComponent. It also fails to explain the difference between @Self() and @Host() because the example given for @Host() has the component as its own host, This is expanded upon much further down the page, but is also explained far better in https://angular.io/guide/dependency-injection-in-action#make-a-dependency-optional-and-limit-search-with-host The description of @Self() also confusingly says "@Self() tells the injector to stop searching in the current host element.". ### What's the affected URL? https://angular.io/guide/hierarchical-dependency-injection#host
help wanted,freq1: low,area: core,core: di,P4,bug,area: docs
low
Critical
564,667,328
flutter
Consider handling non-utf8 decoding errors from File.readAsString in ErrorHandlingFileSystem
## Steps to Reproduce Hello, my project works fine, but today it's crashing when run pub get and i just sending the crash report as oriented after crash. The only thing i've make in this file `android\local.properties` was add a new line with a TODO comment as you can see below: ```gradle sdk.dir=C:\\Users\\Wemerson\\AppData\\Local\\Android\\Sdk flutter.sdk=D:\\Flutter flutter.buildMode=debug flutter.versionName=1.0.0 flutter.versionCode=1 google.map.key = -------------------------------- # TODO: Add Keys/senhas Γ s chaves SHA1/SHA256 do app quando for para produΓ§Γ£o See crash report below... ``` Flutter crash report; please file at https://github.com/flutter/flutter/issues. ## command flutter --no-color packages get ## exception FileSystemException: FileSystemException: Failed to decode data using encoding 'utf-8', path = 'D:\DadosImportantes\dev\Projetos\Pixeldev\sca\mobile\android\local.properties' ``` #0 _File._tryDecode (dart:io/file_impl.dart:574:7) #1 _File.readAsStringSync (dart:io/file_impl.dart:594:7) #2 ForwardingFile.readAsStringSync (package:file/src/forwarding/forwarding_file.dart:103:16) #3 new SettingsFile.parseFromFile (package:flutter_tools/src/base/utils.dart:204:36) #4 updateLocalProperties (package:flutter_tools/src/android/gradle_utils.dart:225:29) #5 AndroidProject.ensureReadyForPlatformSpecificTooling (package:flutter_tools/src/project.dart:599:5) #6 FlutterProject.ensureReadyForPlatformSpecificTooling (package:flutter_tools/src/project.dart:210:21) #7 PackagesGetCommand.runCommand (package:flutter_tools/src/commands/packages.dart:130:23) <asynchronous suspension> #8 FlutterCommand.verifyThenRunCommand (package:flutter_tools/src/runner/flutter_command.dart:615:18) #9 _asyncThenWrapperHelper.<anonymous closure> (dart:async-patch/async_patch.dart:73:64) #10 _rootRunUnary (dart:async/zone.dart:1134:38) #11 _CustomZone.runUnary (dart:async/zone.dart:1031:19) #12 _FutureListener.handleValue (dart:async/future_impl.dart:139:18) #13 Future._propagateToListeners.handleValueCallback (dart:async/future_impl.dart:680:45) #14 Future._propagateToListeners (dart:async/future_impl.dart:709:32) #15 Future._completeWithValue (dart:async/future_impl.dart:524:5) #16 Future._asyncComplete.<anonymous closure> (dart:async/future_impl.dart:554:7) #17 _rootRun (dart:async/zone.dart:1126:13) #18 _CustomZone.run (dart:async/zone.dart:1023:19) #19 _CustomZone.runGuarded (dart:async/zone.dart:925:7) #20 _CustomZone.bindCallbackGuarded.<anonymous closure> (dart:async/zone.dart:965:23) #21 _microtaskLoop (dart:async/schedule_microtask.dart:43:21) #22 _startMicrotaskLoop (dart:async/schedule_microtask.dart:52:5) #23 _runPendingImmediateCallback (dart:isolate-patch/isolate_patch.dart:118:13) #24 _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:175:5) ``` ## flutter doctor ``` [βœ“] Flutter (Channel stable, v1.12.13+hotfix.5, on Microsoft Windows [versão 10.0.17763.678], locale pt-BR) β€’ Flutter version 1.12.13+hotfix.5 at D:\Flutter β€’ Framework revision 27321ebbad (9 weeks ago), 2019-12-10 18:15:01 -0800 β€’ Engine revision 2994f7e1e6 β€’ Dart version 2.7.0 [βœ“] Android toolchain - develop for Android devices (Android SDK version 29.0.2) β€’ Android SDK at C:/Users/Wemerson/AppData/Local/Android/Sdk β€’ Android NDK location not configured (optional; useful for native profiling support) β€’ Platform android-29, build-tools 29.0.2 β€’ ANDROID_HOME = C:/Users/Wemerson/AppData/Local/Android/Sdk β€’ Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java β€’ Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b03) β€’ All Android licenses accepted. [βœ“] Android Studio (version 3.5) β€’ Android Studio at C:\Program Files\Android\Android Studio β€’ Flutter plugin version 43.0.1 β€’ Dart plugin version 191.8593 β€’ Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b03) [βœ“] VS Code (version 1.42.0) β€’ VS Code at C:\Users\Wemerson\AppData\Local\Programs\Microsoft VS Code β€’ Flutter extension version 3.8.1 [!] Connected device ! No devices available ! Doctor found issues in 1 category. ``` ```
c: crash,tool,a: quality,P2,team-tool,triaged-tool
low
Critical
564,693,649
material-ui
Accessibility [Menu]: Screen readers initially not announcing first menuItem in a menu
- [ X ] The issue is present in the latest release. - [ X ] I have searched the [issues](https://github.com/mui-org/material-ui/issues) of this repository and believe that this is not a duplicate. ## Current Behavior 😯 When the user opens a menu, the screen reader does not announce the focussed/first item within the menu. ## Expected Behavior πŸ€” Once a user opens a menu, the first menuItem that is focussed should be announced by the screen reader. ## Steps to Reproduce πŸ•Ή https://codesandbox.io/s/mui-icon-button-menu-gomtg Steps: With the relevant screen readers enabled: 1. Tab to the Icon Button 2. Press Space or Enter to Open the menu 3. Once opened, notice that the first item in the list does not get announced by the relevant screen readers ## Context πŸ”¦ It would be great if the relevant screen readers could announce the text of the first menu item once the menu is opened. ## Your Environment 🌎 | Tech | Version | | ----------- | ------- | | OS | windows 8, 10 | | Material-UI | v4.7.0 | | React | v16.12.0 | | Browser | Chrome | | Screenreader | Jaws, ChromeVox |
accessibility,component: menu
low
Major
564,701,847
material-ui
[Menu] iOS Voiceover focus trapped after selecting a menuItem
- [ X ] The issue is present in the latest release. - [ X ] I have searched the [issues](https://github.com/mui-org/material-ui/issues) of this repository and believe that this is not a duplicate. ## Current Behavior 😯 With voiceover enabled on iOS, when the user opens a menu and selects an option, the menu closes as expected however the focus gets trapped on the selected menu item even though the menu has closed. ## Expected Behavior πŸ€” Once a user opens and selects a menuItem, the menu should close and focus should go back to the Menu Button ## Steps to Reproduce πŸ•Ή https://codesandbox.io/s/mui-icon-button-menu-gomtg Steps: With voiceover enabled on iOS: 1. Navigate to Icon Menu Button 2. Double-tap to open the menu 3. Swipe to Select an option from the menu 3. Notice that the menu closes and the focus gets stuck on the selected menu item even though the menu is closed ## Context πŸ”¦ It would be great if the focus would shift back to the Menu button. ## Your Environment 🌎 | Tech | Version | | ----------- | ------- | | OS | iOs 13.1.2 | | Material-UI | v4.7.0 | | React | v16.12.0 | | Browser | Safari | | Screenreader | VoiceOver |
accessibility,component: menu
low
Minor
564,720,247
rust
Weird error message when pub crate is implemented on inner mod
<!-- Thank you for filing a bug report! πŸ› Please provide a short summary of the bug, along with any information you feel relevant to replicate the bug. --> When an inner mod publicly re-exports function,enum or struct with the `pub(crate)` attribute a non-clear error is showed by cargo check and cargo build. consider a crate lib with the following tree: ``` tst/ src/ lib.rs tmod/ mod.rs Cargo.toml ``` where the lib.rs correctly declare the mod `tmod` as following: ```rust // lib.rs mod tmod; ``` and the mod.rs content is the following: ```rust // mod.rs pub use magic::magic; pub use magic::Magic; pub use magic::Emagic; pub mod magic { pub(crate) fn magic() {} pub(crate) struct Magic; pub(crate) enum EMagic {} } ``` I expected to see this happen: I suppose that the correct behavior should be an error message showing me that the `(crate)` attribute is erroneously located on the inner mod and the `pub use` re-exporting lines of the mod.rs file have to be rewritten as `pub(crate) use ...`. But I'm not sure about that, the [rust lang reference](https://doc.rust-lang.org/reference/visibility-and-privacy.html) doesn't cover this case, maybe even a successfully build should be fine. Instead, this happened: cargo check and cargo build both shows this unhelpful error: ``` error[E0364]: `magic` is private, and cannot be re-exported --> src/tmod/mod.rs:3:9 | 3 | pub use magic::magic; | ^^^^^^^^^^^^ | note: consider marking `magic` as `pub` in the imported module --> src/tmod/mod.rs:3:9 | 3 | pub use magic::magic; | ^^^^^^^^^^^^ error[E0364]: `Magic` is private, and cannot be re-exported --> src/tmod/mod.rs:4:9 | 4 | pub use magic::Magic; | ^^^^^^^^^^^^ | note: consider marking `Magic` as `pub` in the imported module --> src/tmod/mod.rs:4:9 | 4 | pub use magic::Magic; | ^^^^^^^^^^^^ error[E0365]: `EMagic` is private, and cannot be re-exported --> src/tmod/mod.rs:5:9 | 5 | pub use magic::EMagic; | ^^^^^^^^^^^^^ re-export of private `EMagic` | = note: consider declaring type or module `EMagic` with `pub` ``` note that changing the mod.rs file to publicly re-exports the inner mod items with (crate) attribute as follows: ```rust pub(crate) use magic::magic; pub mod magic { pub fn magic() {} } ``` or even as follows: ```rust pub(crate) use magic::magic; pub mod magic { pub(crate) fn magic() {} } ``` works fine and build the crate succefully. ### Meta <!-- If you're using the stable version of the compiler, you should also check if the bug also exists in the beta or nightly versions. --> this happens on both stable and nigtly releases `rustup show` ``` Default host: x86_64-unknown-linux-gnu rustup home: /home/alex/.rustup installed toolchains -------------------- stable-x86_64-unknown-linux-gnu (default) nightly-x86_64-unknown-linux-gnu active toolchain ---------------- stable-x86_64-unknown-linux-gnu (default) rustc 1.41.0 (5e1a79984 2020-01-27) ``` `rustc --version --verbose`: ``` rustc 1.41.0 (5e1a79984 2020-01-27) binary: rustc commit-hash: 5e1a799842ba6ed4a57e91f7ab9435947482f7d8 commit-date: 2020-01-27 host: x86_64-unknown-linux-gnu release: 1.41.0 LLVM version: 9.0 ```
A-diagnostics,T-compiler,C-bug,A-suggestion-diagnostics
low
Critical
564,724,305
rust
better warning when passing format string and variable in wrong order to format/println
I accidentally came up with something like this ````rust fn main() { let greeting = "hello world"; println!(greeting, "{}"); } ```` rustc suggested ```` error: format argument must be a string literal --> src/main.rs:4:14 | 4 | println!(greeting, "{}"); | ^^^^^^^^ | help: you might be missing a string literal to format with | 4 | println!("{} {}", greeting, "{}"); | ^^^^^^^^ ```` but it would be better to suggested swapping the order of `greeting` and `"{}"` in the case that the format-string is valid. ``` help: did you intend to swap the variable and format-string? | 4| println!("{}", greeting); | ````
C-enhancement,A-diagnostics,T-compiler,A-suggestion-diagnostics
low
Critical
564,730,662
go
encoding/xml: Decoder allocates (and does not release) memory for every control <?...?> encountered
<!-- Please answer these questions before submitting your issue. Thanks! For questions please use one of our forums: https://github.com/golang/go/wiki/Questions --> ### What version of Go are you using (`go version`)? <pre> $ go version go version go1.13.7 linux/amd64 </pre> ### Does this issue reproduce with the latest release? Yes ### What operating system and processor architecture are you using (`go env`)? <details><summary><code>go env</code> Output</summary><br><pre> $ go env GO111MODULE="" GOARCH="amd64" GOBIN="" GOCACHE="/home/jcrawford/.cache/go-build" GOENV="/home/jcrawford/.config/go/env" GOEXE="" GOFLAGS="" GOHOSTARCH="amd64" GOHOSTOS="linux" GONOPROXY="" GONOSUMDB="" GOOS="linux" GOPATH="/home/jcrawford/git/gowork" GOPRIVATE="" GOPROXY="https://proxy.golang.org,direct" GOROOT="/home/jcrawford/opt/go" GOSUMDB="sum.golang.org" GOTMPDIR="" GOTOOLDIR="/home/jcrawford/opt/go/pkg/tool/linux_amd64" GCCGO="gccgo" AR="ar" CC="gcc" CXX="g++" CGO_ENABLED="1" GOMOD="/home/jcrawford/git/djtest/go.mod" CGO_CFLAGS="-g -O2" CGO_CPPFLAGS="" CGO_CXXFLAGS="-g -O2" CGO_FFLAGS="-g -O2" CGO_LDFLAGS="-g -O2" PKG_CONFIG="pkg-config" GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build917252283=/tmp/go-build -gno-record-gcc-switches" </pre></details> ### What did you do? <!-- If possible, provide a recipe for reproducing the error. A complete runnable program is good. A link on play.golang.org is best. --> Parse an xml file that includes multiple `<?xml version="1.0" encoding="ISO-8859-1" ?>` control tags in the same file. For each encountered tag, a new reader will be created and will _not_ be released (see below for details). It is possible to trigger this with a degenerate xml consisting of _only_ repeated tags. As an example, I created a file of ~400kb in size containing 9030 lines of: ``` $ head bad.xml <?xml version="1.0" encoding="ISO-8859-1" ?> <?xml version="1.0" encoding="ISO-8859-1" ?> <?xml version="1.0" encoding="ISO-8859-1" ?> <?xml version="1.0" encoding="ISO-8859-1" ?> ``` ```go package main import ( "encoding/xml" "golang.org/x/net/html/charset" "io" "os" "runtime/pprof" ) func main() { path := "bad.xml" f, err := os.Open(path) if err != nil { panic(err) } dec := xml.NewDecoder(f) dec.CharsetReader = charset.NewReaderLabel type Unused struct{} for { var value Unused err = dec.Decode(&value) if err == io.EOF { break } } heapOut, err := os.Create("heap") if err != nil { panic(err) } pprof.WriteHeapProfile(heapOut) } ``` ### What did you expect to see? Memory usage somewhat constant ### What did you see instead? Memory usage grows for every `<?...?>` tag encountered. Profiling the heap with pprof, the problem appears to be that for every `<?...?>` tag encountered in `xml.Decoder.rawToken`, a new `*charset.Reader` is created through `charset.NewReaderLabel`. The decoder then switches to this new reader with `xml.Decoder.switchToReader` (and also wraps it in another `*bufio.Reader`). However, it looks like references to the previous readers (created when we encountered previous `<?...?>` tags) are never garbage collected. As a result, parsing a large file with enough `<?...?>` can exhaust the system memory. As an example, running `go tool pprof heap` on the heap file produced above shows 44 MB of usage for the 9030 line example (which was ~400kb in size) ``` (pprof) top Showing nodes accounting for 44.67MB, 100% of 44.67MB total Showing top 10 nodes out of 12 flat flat% sum% cum cum% 25.10MB 56.18% 56.18% 25.10MB 56.18% golang.org/x/text/transform.NewReader 19.58MB 43.82% 100% 19.58MB 43.82% bufio.NewReaderSize 0 0% 100% 19.58MB 43.82% bufio.NewReader 0 0% 100% 44.67MB 100% encoding/xml.(*Decoder).Decode 0 0% 100% 44.67MB 100% encoding/xml.(*Decoder).DecodeElement 0 0% 100% 44.67MB 100% encoding/xml.(*Decoder).Token 0 0% 100% 44.67MB 100% encoding/xml.(*Decoder).rawToken 0 0% 100% 19.58MB 43.82% encoding/xml.(*Decoder).switchToReader 0 0% 100% 44.67MB 100% encoding/xml.(*Decoder).unmarshal 0 0% 100% 25.10MB 56.18% golang.org/x/net/html/charset.NewReaderLabel ```
NeedsInvestigation
low
Critical
564,754,337
vscode
Git - Git does not show gutters unless file is opened from changed files tab
Version: 1.42.0 (system setup) Commit: ae08d5460b5a45169385ff3fd44208f431992451 Date: 2020-02-06T10:51:34.058Z Electron: 6.1.6 Chrome: 76.0.3809.146 Node.js: 12.4.0 V8: 7.6.303.31-electron.0 OS: Windows_NT x64 10.0.18362 Steps to Reproduce: 1. The steps to reproduce are exactly the same as Bug# https://github.com/Microsoft/vscode/issues/41642. However, I haven't tried changing settings in settings.json file. I'm unable to paste GIFs here since that is against my company policy. Expected result: gutters should be visible when a git tracked files has changes Actual result: gutters are only visible when the file is opened the way it is depicted in #41642 Does this issue occur when all extensions are disabled?: Yes (only gitlens was installed) More info: The log below is from GitLens, but I feel that the issue is VSCode Git itself. Thus, opening it here. Both gutters and line blames in gitlens start working as soon as I open the file from the changes tab by right clicking on Open File. GitLens log: > [2020-02-12 22:43:51:347] [251] GitService.getRepoPath [2020-02-12 22:43:51:347] [252] GitService.getRepository [2020-02-12 22:43:51:465] [c:/_repos/some_path] git ls-files -- foo/bar/lib/some_folder/some_file.rb β€’ 116 ms [2020-02-12 22:43:51:465] [257] **GitService.isTracked returned false** β€’ 116 ms [2020-02-12 22:43:51:465] [252] GitService.getRepository returned undefined β€’ 117 ms [2020-02-12 22:43:51:562] [c:\_repos\some_path\foo\bar\lib\some_folder] git rev-parse --show-toplevel β€’ 96 ms [2020-02-12 22:43:51:562] [251] GitService.getRepoPath returned c:/_repos/some_path β€’ 214 ms [2020-02-12 22:43:51:562] [259] GitService.getRepository [2020-02-12 22:43:51:562] [259] GitService.getRepository returned c:/_repos/some_path β€’ 0 ms [2020-02-12 22:43:51:650] [c:/_repos/some_path] git ls-files -- c:\_repos\some_path\foo\bar\lib\some_folder\some_file.rb β€’ 87 ms [2020-02-12 22:43:51:650] [25a] GitService.isTracked returned false β€’ 87 ms [2020-02-12 22:43:57:132] [272] GitService.isTracked returned false β€’ 0 ms [2020-02-12 22:43:57:909] [286] GitService.isTracked returned false β€’ 0 ms [2020-02-12 22:44:10:276] [2ae] GitService.getRepoPath [2020-02-12 22:44:10:276] [2af] GitService.getRepository <------------------ This is where I right clicked and selected Open File from the changes tab -----------------> [2020-02-12 22:44:10:404] [c:/_repos/some_path] git ls-files -- foo/bar/lib/some_folder/some_file.rb β€’ 126 ms [2020-02-12 22:44:10:404] [2b0] **GitService.isTracked returned true** β€’ 126 ms [2020-02-12 22:44:10:404] [2af] GitService.getRepository returned c:/_repos/some_path β€’ 128 ms [2020-02-12 22:44:10:404] [2ae] GitService.getRepoPath returned c:/_repos/some_path β€’ 129 ms [2020-02-12 22:44:10:405] [2b1] GitService.getRepository [2020-02-12 22:44:10:405] [2b1] GitService.getRepository returned c:/_repos/some_path β€’ 0 ms [2020-02-12 22:44:10:504] [c:/_repos/some_path] git ls-files -- c:\_repos\some_path\foo\bar\lib\some_folder\some_file.rb β€’ 98 ms [2020-02-12 22:44:10:504] [2b2] GitService.isTracked returned true β€’ 99 ms [2020-02-12 22:44:10:506] [2b3] GitService.getBlameForFile [2020-02-12 22:44:10:509] [2b4] GitService.isTracked returned true β€’ 0 ms [2020-02-12 22:44:10:531] [2b5] GitService.getBlameForLine [2020-02-12 22:44:10:531] [2b6] GitService.getBlameForFile [2020-02-12 22:44:10:622] [c:/_repos/some_path] git blame --root --incremental -- foo/bar/lib/some_folder/some_file.rb β€’ 112 ms [2020-02-12 22:44:10:623] [2b7] GitService.getCurrentUser [2020-02-12 22:44:10:623] [2b7] GitService.getCurrentUser completed β€’ 0 ms [2020-02-12 22:44:10:628] [2b3] GitService.getBlameForFile completed β€’ 122 ms [2020-02-12 22:44:10:628] [2b6] GitService.getBlameForFile completed β€’ 96 ms [2020-02-12 22:44:10:628] GitCodeLensProvider.provideCodeLenses: β€” 54 symbol(s) found [2020-02-12 22:44:10:632] [2b5] GitService.getBlameForLine completed β€’ 101 ms [2020-02-12 22:44:14:796] [2c2] GitService.getBlameForLine [2020-02-12 22:44:14:796] [2c3] GitService.getBlameForFile [2020-02-12 22:44:14:797] [2c3] GitService.getBlameForFile completed β€’ 0 ms [2020-02-12 22:44:14:797] [2c2] GitService.getBlameForLine completed β€’ 0 ms My git config: > diff.astextplain.textconv=astextplain > filter.lfs.clean=git-lfs clean -- %f > filter.lfs.smudge=git-lfs smudge -- %f > filter.lfs.process=git-lfs filter-process > filter.lfs.required=true > http.sslbackend=openssl > http.sslcainfo=C:/Program Files/Git/mingw64/ssl/certs/ca-bundle.crt > core.autocrlf=false > core.fscache=true > core.symlinks=false > core.editor="C:\\Program Files\\Microsoft VS Code\\Code.exe" --wait > credential.helper=manager
bug,git
medium
Critical
564,779,415
flutter
The widget doesn't rebuild on animation end in web
Hi Team, I am creating a custom scroll view, where I can host three views and reusing the view for infinity swiping and for swiping I have using tween animation and animation controller and it works fine as expected in the mobile platform, but it doesn't work as expected in the web. I have attached the sample and the steps to reproduce the issue are following by: [flutter_app_panel.zip](https://github.com/flutter/flutter/files/4199301/flutter_app_panel.zip) 1. Run the attached sample on mobile 2. It will display a view with text second view 3. Swipe the view in right to left and it displays a view with the third view 4. Now, swipe again now, the view displays as the first view 5. And swipe again will show the second view and swiping further continue as mentioned. 6. Now, run the sample on the web, and follow the steps mentioned above 7. It doesn't work as same as on mobile. The Flutter doctor -v output is following by ``` [√] Flutter (Channel beta, v1.14.6, on Microsoft Windows [Version 10.0.17763.973], locale en-US) β€’ Flutter version 1.14.6 at C:\src\flutter β€’ Framework revision fabeb2a16f (2 weeks ago), 2020-01-28 07:56:51 -0800 β€’ Engine revision c4229bfbba β€’ Dart version 2.8.0 (build 2.8.0-dev.5.0 fc3af737c7) [√] Android toolchain - develop for Android devices (Android SDK version 29.0.0) β€’ Android SDK at C:\Users\ArunsivaRengaraju\AppData\Local\Android\sdk β€’ Android NDK location not configured (optional; useful for native profiling support) β€’ Platform android-29, build-tools 29.0.0 β€’ Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java β€’ Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b03) β€’ All Android licenses accepted. [√] Chrome - develop for the web β€’ Chrome at C:\Program Files (x86)\Google\Chrome\Application\chrome.exe [√] Android Studio (version 3.5) β€’ Android Studio at C:\Program Files\Android\Android Studio β€’ Flutter plugin version 42.1.1 β€’ Dart plugin version 191.8593 β€’ Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b03) [√] Connected device (3 available) β€’ Redmi Note 4 β€’ 6318aa1a0104 β€’ android-arm64 β€’ Android 7.0 (API 24) β€’ Chrome β€’ chrome β€’ web-javascript β€’ Google Chrome 79.0.3945.130 β€’ Web Server β€’ web-server β€’ web-javascript β€’ Flutter Tools β€’ No issues found! ``` <details> <summary>flutter run --verbose</summary> ``` [ +26 ms] executing: [C:\src\flutter/] git -c log.showSignature=false log -n 1 --pretty=format:%H [+3734 ms] Exit code 0 from: git -c log.showSignature=false log -n 1 --pretty=format:%H [ +5 ms] fabeb2a16f1d008ab8230f450c49141d35669798 [ +2 ms] executing: [C:\src\flutter/] git describe --match v*.*.* --first-parent --long --tags [+5018 ms] Exit code 0 from: git describe --match v*.*.* --first-parent --long --tags [ +2 ms] v1.14.6-0-gfabeb2a16 [ +26 ms] executing: [C:\src\flutter/] git rev-parse --abbrev-ref --symbolic @{u} [+5035 ms] Exit code 0 from: git rev-parse --abbrev-ref --symbolic @{u} [ +1 ms] origin/beta [ +1 ms] executing: [C:\src\flutter/] git ls-remote --get-url origin [+5058 ms] Exit code 0 from: git ls-remote --get-url origin [ +1 ms] https://github.com/flutter/flutter.git [+5176 ms] executing: [C:\src\flutter/] git rev-parse --abbrev-ref HEAD [+5039 ms] Exit code 0 from: git rev-parse --abbrev-ref HEAD [ +2 ms] beta [+2040 ms] Artifact Instance of 'AndroidMavenArtifacts' is not required, skipping update. [ ] Artifact Instance of 'AndroidGenSnapshotArtifacts' is not required, skipping update. [ ] Artifact Instance of 'AndroidInternalBuildArtifacts' is not required, skipping update. [ ] Artifact Instance of 'IOSEngineArtifacts' is not required, skipping update. [ ] Artifact Instance of 'FlutterWebSdk' is not required, skipping update. [ +4 ms] Artifact Instance of 'WindowsEngineArtifacts' is not required, skipping update. [ ] Artifact Instance of 'MacOSEngineArtifacts' is not required, skipping update. [ ] Artifact Instance of 'LinuxEngineArtifacts' is not required, skipping update. [ ] Artifact Instance of 'LinuxFuchsiaSDKArtifacts' is not required, skipping update. [ ] Artifact Instance of 'FlutterRunnerSDKArtifacts' is not required, skipping update. [ ] Artifact Instance of 'FlutterRunnerDebugSymbols' is not required, skipping update. [ +32 ms] executing: C:\Users\ArunsivaRengaraju\AppData\Local\Android\sdk\platform-tools\adb.exe devices -l [+3987 ms] Exit code 0 from: C:\Users\ArunsivaRengaraju\AppData\Local\Android\sdk\platform-tools\adb.exe devices -l [ +2 ms] List of devices attached 6318aa1a0104 device product:mido model:Redmi_Note_4 device:mido transport_id:2 [ +48 ms] C:\Users\ArunsivaRengaraju\AppData\Local\Android\sdk\platform-tools\adb.exe -s 6318aa1a0104 shell getprop [+3155 ms] Artifact Instance of 'AndroidMavenArtifacts' is not required, skipping update. [ +10 ms] Artifact Instance of 'AndroidInternalBuildArtifacts' is not required, skipping update. [ +3 ms] Artifact Instance of 'IOSEngineArtifacts' is not required, skipping update. [ +7 ms] Artifact Instance of 'WindowsEngineArtifacts' is not required, skipping update. [ +1 ms] Artifact Instance of 'MacOSEngineArtifacts' is not required, skipping update. [ ] Artifact Instance of 'LinuxEngineArtifacts' is not required, skipping update. [ ] Artifact Instance of 'LinuxFuchsiaSDKArtifacts' is not required, skipping update. [ ] Artifact Instance of 'MacOSFuchsiaSDKArtifacts' is not required, skipping update. [ ] Artifact Instance of 'FlutterRunnerSDKArtifacts' is not required, skipping update. [ ] Artifact Instance of 'FlutterRunnerDebugSymbols' is not required, skipping update. [ +232 ms] Generating C:\Users\ArunsivaRengaraju\AndroidStudioProjects\flutter_app_panel\android\app\src\main\java\io\flutter\plugins\GeneratedPluginRegistrant.java [ +56 ms] ro.hardware = qcom [ +56 ms] Launching lib\main.dart on Redmi Note 4 in debug mode... [ +21 ms] executing: C:\Users\ArunsivaRengaraju\AppData\Local\Android\sdk\build-tools\29.0.0\aapt dump xmltree C:\Users\ArunsivaRengaraju\AndroidStudioProjects\flutter_app_panel\build\app\outputs\apk\app.apk AndroidManifest.xml [+2636 ms] Exit code 0 from: C:\Users\ArunsivaRengaraju\AppData\Local\Android\sdk\build-tools\29.0.0\aapt dump xmltree C:\Users\ArunsivaRengaraju\AndroidStudioProjects\flutter_app_panel\build\app\outputs\apk\app.apk AndroidManifest.xml [ +2 ms] N: android=http://schemas.android.com/apk/res/android E: manifest (line=2) A: android:versionCode(0x0101021b)=(type 0x10)0x1 A: android:versionName(0x0101021c)="1.0.0" (Raw: "1.0.0") A: android:compileSdkVersion(0x01010572)=(type 0x10)0x1c A: android:compileSdkVersionCodename(0x01010573)="9" (Raw: "9") A: package="com.example.flutter_app_panel" (Raw: "com.example.flutter_app_panel") A: platformBuildVersionCode=(type 0x10)0x1 A: platformBuildVersionName="1.0.0" (Raw: "1.0.0") E: uses-sdk (line=7) A: android:minSdkVersion(0x0101020c)=(type 0x10)0x10 A: android:targetSdkVersion(0x01010270)=(type 0x10)0x1c E: uses-permission (line=14) A: android:name(0x01010003)="android.permission.INTERNET" (Raw: "android.permission.INTERNET") E: application (line=22) A: android:label(0x01010001)="flutter_app_panel" (Raw: "flutter_app_panel") A: android:icon(0x01010002)=@0x7f080000 A: android:name(0x01010003)="io.flutter.app.FlutterApplication" (Raw: "io.flutter.app.FlutterApplication") A: android:debuggable(0x0101000f)=(type 0x12)0xffffffff A: android:appComponentFactory(0x0101057a)="android.support.v4.app.CoreComponentFactory" (Raw: "android.support.v4.app.CoreComponentFactory") E: activity (line=28) A: android:theme(0x01010000)=@0x7f0a0000 A: android:name(0x01010003)="com.example.flutter_app_panel.MainActivity" (Raw: "com.example.flutter_app_panel.MainActivity") A: android:launchMode(0x0101001d)=(type 0x10)0x1 A: android:configChanges(0x0101001f)=(type 0x11)0x400037b4 A: android:windowSoftInputMode(0x0101022b)=(type 0x11)0x10 A: android:hardwareAccelerated(0x010102d3)=(type 0x12)0xffffffff E: meta-data (line=42) A: android:name(0x01010003)="io.flutter.app.android.SplashScreenUntilFirstFrame" (Raw: "io.flutter.app.android.SplashScreenUntilFirstFrame") A: android:value(0x01010024)=(type 0x12)0xffffffff E: intent-filter (line=46) E: action (line=47) A: android:name(0x01010003)="android.intent.action.MAIN" (Raw: "android.intent.action.MAIN") E: category (line=49) A: android:name(0x01010003)="android.intent.category.LAUNCHER" (Raw: "android.intent.category.LAUNCHER") [ +8 ms] executing: C:\Users\ArunsivaRengaraju\AppData\Local\Android\sdk\platform-tools\adb.exe -s 6318aa1a0104 shell -x logcat -v time -t 1 [+3064 ms] Exit code 0 from: C:\Users\ArunsivaRengaraju\AppData\Local\Android\sdk\platform-tools\adb.exe -s 6318aa1a0104 shell -x logcat -v time -t 1 [ +4 ms] --------- beginning of main 02-14 15:47:02.314 I/MSM-irqbalance( 860): Decided to move IRQ164 from CPU3 [P:0] to CPU4 [P:1] (banned) [ +21 ms] executing: C:\Users\ArunsivaRengaraju\AppData\Local\Android\sdk\platform-tools\adb.exe version [ +5 ms] executing: C:\Users\ArunsivaRengaraju\AppData\Local\Android\sdk\platform-tools\adb.exe -s 6318aa1a0104 logcat -v time -T 02-14 15:47:02.314 [+3074 ms] Android Debug Bridge version 1.0.41 Version 29.0.1-5644136 Installed as C:\Users\ArunsivaRengaraju\AppData\Local\Android\sdk\platform-tools\adb.exe [ +6 ms] executing: C:\Users\ArunsivaRengaraju\AppData\Local\Android\sdk\platform-tools\adb.exe start-server [+2064 ms] Building APK [ +33 ms] [!] Your app isn't using AndroidX. [ +1 ms] To avoid potential build failures, you can quickly migrate your app by following the steps on https://goo.gl/CP92wY. [ +14 ms] Running Gradle task 'assembleDebug'... [ +4 ms] gradle.properties already sets `android.enableR8` [ +9 ms] Using gradle from C:\Users\ArunsivaRengaraju\AndroidStudioProjects\flutter_app_panel\android\gradlew.bat. [ +1 ms] C:\Users\ArunsivaRengaraju\AndroidStudioProjects\flutter_app_panel\android\gradlew.bat mode: 33279 rwxrwxrwx. [ +13 ms] executing: C:\Program Files\Android\Android Studio\jre\bin\java -version [+4018 ms] Exit code 0 from: C:\Program Files\Android\Android Studio\jre\bin\java -version [ +2 ms] openjdk version "1.8.0_202-release" OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b03) OpenJDK 64-Bit Server VM (build 25.202-b03, mixed mode) [ +11 ms] executing: [C:\Users\ArunsivaRengaraju\AndroidStudioProjects\flutter_app_panel\android/] C:\Users\ArunsivaRengaraju\AndroidStudioProjects\flutter_app_panel\android\gradlew.bat -Pverbose=true -Ptarget=C:\Users\ArunsivaRengaraju\AndroidStudioProjects\flutter_app_panel\lib\main.dart -Ptrack-widget-creation=true -Pfilesystem-scheme=org-dartlang-root -Ptarget-platform=android-arm64 assembleDebug [+4989 ms] > Configure project :app [ +1 ms] WARNING: The option setting 'android.enableR8=true' is experimental and unsupported. [ +1 ms] The current default is 'false' [ +1 ms] Consider disabling R8 by removing 'android.enableR8=true' from your gradle.properties before publishing your app. [+14772 ms] > Task :app:compileFlutterBuildDebug [ +1 ms] [ +23 ms] executing: [C:\src\flutter/] git -c log.showSignature=false log -n 1 --pretty=format:%H [+4712 ms] [+4701 ms] Exit code 0 from: git -c log.showSignature=false log -n 1 --pretty=format:%H [ +4 ms] [ +1 ms] fabeb2a16f1d008ab8230f450c49141d35669798 [ +2 ms] [ ] executing: [C:\src\flutter/] git describe --match v*.*.* --first-parent --long --tags [+5088 ms] [+5107 ms] Exit code 0 from: git describe --match v*.*.* --first-parent --long --tags [ +1 ms] [ ] v1.14.6-0-gfabeb2a16 [ +1 ms] [ +10 ms] executing: [C:\src\flutter/] git rev-parse --abbrev-ref --symbolic @{u} [+5096 ms] [+5079 ms] Exit code 0 from: git rev-parse --abbrev-ref --symbolic @{u} [ +2 ms] [ ] origin/beta [ +1 ms] [ ] executing: [C:\src\flutter/] git ls-remote --get-url origin [+5087 ms] [+5071 ms] Exit code 0 from: git ls-remote --get-url origin [ +1 ms] [ ] https://github.com/flutter/flutter.git [+5097 ms] [+5157 ms] executing: [C:\src\flutter/] git rev-parse --abbrev-ref HEAD [+5001 ms] [+5002 ms] Exit code 0 from: git rev-parse --abbrev-ref HEAD [ +2 ms] [ ] beta [ +103 ms] [ +33 ms] Artifact Instance of 'AndroidMavenArtifacts' is not required, skipping update. [ +1 ms] [ ] Artifact Instance of 'AndroidGenSnapshotArtifacts' is not required, skipping update. [ +1 ms] [ ] Artifact Instance of 'AndroidInternalBuildArtifacts' is not required, skipping update. [ +1 ms] [ ] Artifact Instance of 'IOSEngineArtifacts' is not required, skipping update. [ +1 ms] [ ] Artifact Instance of 'FlutterWebSdk' is not required, skipping update. [ +1 ms] [ +4 ms] Artifact Instance of 'WindowsEngineArtifacts' is not required, skipping update. [ +1 ms] [ ] Artifact Instance of 'MacOSEngineArtifacts' is not required, skipping update. [ +1 ms] [ ] Artifact Instance of 'LinuxEngineArtifacts' is not required, skipping update. [ ] [ ] Artifact Instance of 'LinuxFuchsiaSDKArtifacts' is not required, skipping update. [ ] [ ] Artifact Instance of 'MacOSFuchsiaSDKArtifacts' is not required, skipping update. [ ] [ ] Artifact Instance of 'FlutterRunnerSDKArtifacts' is not required, skipping update. [ ] [ ] Artifact Instance of 'FlutterRunnerDebugSymbols' is not required, skipping update. [ ] [ +17 ms] Artifact Instance of 'MaterialFonts' is not required, skipping update. [ ] [ ] Artifact Instance of 'GradleWrapper' is not required, skipping update. [ +1 ms] [ ] Artifact Instance of 'AndroidMavenArtifacts' is not required, skipping update. [ ] [ ] Artifact Instance of 'AndroidGenSnapshotArtifacts' is not required, skipping update. [ +1 ms] [ ] Artifact Instance of 'AndroidInternalBuildArtifacts' is not required, skipping update. [ ] [ ] Artifact Instance of 'IOSEngineArtifacts' is not required, skipping update. [ ] [ ] Artifact Instance of 'FlutterWebSdk' is not required, skipping update. [ ] [ ] Artifact Instance of 'FlutterSdk' is not required, skipping update. [ ] [ ] Artifact Instance of 'WindowsEngineArtifacts' is not required, skipping update. [ ] [ ] Artifact Instance of 'MacOSEngineArtifacts' is not required, skipping update. [ ] [ ] Artifact Instance of 'LinuxEngineArtifacts' is not required, skipping update. [ +1 ms] [ ] Artifact Instance of 'LinuxFuchsiaSDKArtifacts' is not required, skipping update. [ ] [ ] Artifact Instance of 'MacOSFuchsiaSDKArtifacts' is not required, skipping update. [ ] [ ] Artifact Instance of 'FlutterRunnerSDKArtifacts' is not required, skipping update. [ ] [ ] Artifact Instance of 'FlutterRunnerDebugSymbols' is not required, skipping update. [ ] [ ] Artifact Instance of 'IosUsbArtifacts' is not required, skipping update. [ ] [ ] Artifact Instance of 'IosUsbArtifacts' is not required, skipping update. [ ] [ ] Artifact Instance of 'IosUsbArtifacts' is not required, skipping update. [ ] [ ] Artifact Instance of 'IosUsbArtifacts' is not required, skipping update. [ ] [ ] Artifact Instance of 'IosUsbArtifacts' is not required, skipping update. [ +1 ms] [ ] Artifact Instance of 'IosUsbArtifacts' is not required, skipping update. [ +1 ms] [ ] Artifact Instance of 'IosUsbArtifacts' is not required, skipping update. [ +1 ms] [ ] Artifact Instance of 'FontSubsetArtifacts' is not required, skipping update. [ +84 ms] [ +81 ms] Initializing file store [ +1 ms] [ +30 ms] Done initializing file store [+1573 ms] [+1582 ms] Skipping target: kernel_snapshot [ +100 ms] [ +101 ms] debug_android_application: Starting due to {InvalidatedReason.outputMissing} [ +900 ms] [ +863 ms] debug_android_application: Complete [ +1 ms] [ +23 ms] Persisting file store [ +1 ms] [ +18 ms] Done persisting file store [ +1 ms] [ +3 ms] build succeeded. [ +1 ms] [ +21 ms] "flutter assemble" took 7,776ms. [+3320 ms] > Task :app:packLibsflutterBuildDebug UP-TO-DATE [ +192 ms] > Task :app:checkDebugClasspath UP-TO-DATE [ +4 ms] > Task :app:preBuild UP-TO-DATE [ +1 ms] > Task :app:preDebugBuild UP-TO-DATE [ ] > Task :app:compileDebugAidl NO-SOURCE [ +75 ms] > Task :app:compileDebugRenderscript UP-TO-DATE [ +1 ms] > Task :app:checkDebugManifest UP-TO-DATE [ +1 ms] > Task :app:generateDebugBuildConfig UP-TO-DATE [ ] > Task :app:prepareLintJar UP-TO-DATE [ +1 ms] > Task :app:cleanMergeDebugAssets [ ] > Task :app:mergeDebugShaders UP-TO-DATE [ +1 ms] > Task :app:compileDebugShaders UP-TO-DATE [ ] > Task :app:generateDebugAssets UP-TO-DATE [ ] > Task :app:mergeDebugAssets [ +698 ms] > Task :app:copyFlutterAssetsDebug [ +4 ms] > Task :app:mainApkListPersistenceDebug UP-TO-DATE [ +1 ms] > Task :app:generateDebugResValues UP-TO-DATE [ +2 ms] > Task :app:generateDebugResources UP-TO-DATE [ ] > Task :app:mergeDebugResources UP-TO-DATE [ +2 ms] > Task :app:createDebugCompatibleScreenManifests UP-TO-DATE [ +1 ms] > Task :app:processDebugManifest UP-TO-DATE [ +1 ms] > Task :app:splitsDiscoveryTaskDebug UP-TO-DATE [ ] > Task :app:processDebugResources UP-TO-DATE [ ] > Task :app:generateDebugSources UP-TO-DATE [ +76 ms] > Task :app:javaPreCompileDebug UP-TO-DATE [ +1 ms] > Task :app:compileDebugJavaWithJavac UP-TO-DATE [ ] > Task :app:compileDebugNdk NO-SOURCE [ ] > Task :app:compileDebugSources UP-TO-DATE [ +99 ms] > Task :app:transformClassesWithDexBuilderForDebug UP-TO-DATE [ +6 ms] > Task :app:transformDexArchiveWithExternalLibsDexMergerForDebug UP-TO-DATE [ +2 ms] > Task :app:transformDexArchiveWithDexMergerForDebug UP-TO-DATE [ +3 ms] > Task :app:mergeDebugJniLibFolders UP-TO-DATE [ +2 ms] > Task :app:transformNativeLibsWithMergeJniLibsForDebug UP-TO-DATE [ +1 ms] > Task :app:checkDebugLibraries UP-TO-DATE [ +3 ms] > Task :app:processDebugJavaRes NO-SOURCE [ +1 ms] > Task :app:transformResourcesWithMergeJavaResForDebug UP-TO-DATE [ +50 ms] > Task :app:validateSigningDebug UP-TO-DATE [ +2 ms] > Task :app:packageDebug UP-TO-DATE [ +1 ms] > Task :app:assembleDebug UP-TO-DATE [ ] BUILD SUCCESSFUL in 55s [ ] 31 actionable tasks: 4 executed, 27 up-to-date [+4727 ms] Running Gradle task 'assembleDebug'... (completed in 66.0s) [ +60 ms] calculateSha: LocalDirectory: 'C:\Users\ArunsivaRengaraju\AndroidStudioProjects\flutter_app_panel\build\app\outputs\apk'/app.apk [ +83 ms] calculateSha: reading file took 80us [ +885 ms] calculateSha: computing sha took 884us [ +14 ms] √ Built build\app\outputs\apk\debug\app-debug.apk. [ +23 ms] executing: C:\Users\ArunsivaRengaraju\AppData\Local\Android\sdk\build-tools\29.0.0\aapt dump xmltree C:\Users\ArunsivaRengaraju\AndroidStudioProjects\flutter_app_panel\build\app\outputs\apk\app.apk AndroidManifest.xml [+2999 ms] Exit code 0 from: C:\Users\ArunsivaRengaraju\AppData\Local\Android\sdk\build-tools\29.0.0\aapt dump xmltree C:\Users\ArunsivaRengaraju\AndroidStudioProjects\flutter_app_panel\build\app\outputs\apk\app.apk AndroidManifest.xml [ +5 ms] N: android=http://schemas.android.com/apk/res/android E: manifest (line=2) A: android:versionCode(0x0101021b)=(type 0x10)0x1 A: android:versionName(0x0101021c)="1.0.0" (Raw: "1.0.0") A: android:compileSdkVersion(0x01010572)=(type 0x10)0x1c A: android:compileSdkVersionCodename(0x01010573)="9" (Raw: "9") A: package="com.example.flutter_app_panel" (Raw: "com.example.flutter_app_panel") A: platformBuildVersionCode=(type 0x10)0x1 A: platformBuildVersionName="1.0.0" (Raw: "1.0.0") E: uses-sdk (line=7) A: android:minSdkVersion(0x0101020c)=(type 0x10)0x10 A: android:targetSdkVersion(0x01010270)=(type 0x10)0x1c E: uses-permission (line=14) A: android:name(0x01010003)="android.permission.INTERNET" (Raw: "android.permission.INTERNET") E: application (line=22) A: android:label(0x01010001)="flutter_app_panel" (Raw: "flutter_app_panel") A: android:icon(0x01010002)=@0x7f080000 A: android:name(0x01010003)="io.flutter.app.FlutterApplication" (Raw: "io.flutter.app.FlutterApplication") A: android:debuggable(0x0101000f)=(type 0x12)0xffffffff A: android:appComponentFactory(0x0101057a)="android.support.v4.app.CoreComponentFactory" (Raw: "android.support.v4.app.CoreComponentFactory") E: activity (line=28) A: android:theme(0x01010000)=@0x7f0a0000 A: android:name(0x01010003)="com.example.flutter_app_panel.MainActivity" (Raw: "com.example.flutter_app_panel.MainActivity") A: android:launchMode(0x0101001d)=(type 0x10)0x1 A: android:configChanges(0x0101001f)=(type 0x11)0x400037b4 A: android:windowSoftInputMode(0x0101022b)=(type 0x11)0x10 A: android:hardwareAccelerated(0x010102d3)=(type 0x12)0xffffffff E: meta-data (line=42) A: android:name(0x01010003)="io.flutter.app.android.SplashScreenUntilFirstFrame" (Raw: "io.flutter.app.android.SplashScreenUntilFirstFrame") A: android:value(0x01010024)=(type 0x12)0xffffffff E: intent-filter (line=46) E: action (line=47) A: android:name(0x01010003)="android.intent.action.MAIN" (Raw: "android.intent.action.MAIN") E: category (line=49) A: android:name(0x01010003)="android.intent.category.LAUNCHER" (Raw: "android.intent.category.LAUNCHER") [ +9 ms] Stopping app 'app.apk' on Redmi Note 4. [ +3 ms] executing: C:\Users\ArunsivaRengaraju\AppData\Local\Android\sdk\platform-tools\adb.exe -s 6318aa1a0104 shell am force-stop com.example.flutter_app_panel [+3034 ms] executing: C:\Users\ArunsivaRengaraju\AppData\Local\Android\sdk\platform-tools\adb.exe -s 6318aa1a0104 shell pm list packages com.example.flutter_app_panel [+3039 ms] Installing APK. [ +13 ms] executing: C:\Users\ArunsivaRengaraju\AppData\Local\Android\sdk\platform-tools\adb.exe version [+3059 ms] Android Debug Bridge version 1.0.41 Version 29.0.1-5644136 Installed as C:\Users\ArunsivaRengaraju\AppData\Local\Android\sdk\platform-tools\adb.exe [ +6 ms] executing: C:\Users\ArunsivaRengaraju\AppData\Local\Android\sdk\platform-tools\adb.exe start-server [+2996 ms] Installing build\app\outputs\apk\app.apk... [ +4 ms] executing: C:\Users\ArunsivaRengaraju\AppData\Local\Android\sdk\platform-tools\adb.exe -s 6318aa1a0104 install -t -r C:\Users\ArunsivaRengaraju\AndroidStudioProjects\flutter_app_panel\build\app\outputs\apk\app.apk [+10701 ms] Performing Streamed Install Success [ +2 ms] Installing build\app\outputs\apk\app.apk... (completed in 10.7s) [ +5 ms] executing: C:\Users\ArunsivaRengaraju\AppData\Local\Android\sdk\platform-tools\adb.exe -s 6318aa1a0104 shell echo -n 0f1c62a473e877e88947d2e3f92cd1130ca3dc51 > /data/local/tmp/sky.com.example.flutter_app_panel.sha1 [+2040 ms] Redmi Note 4 startApp [ +7 ms] executing: C:\Users\ArunsivaRengaraju\AppData\Local\Android\sdk\platform-tools\adb.exe -s 6318aa1a0104 shell am start -a android.intent.action.RUN -f 0x20000000 --ez enable-background-compilation true --ez enable-dart-profiling true --ez enable-checked-mode true --ez verify-entry-points true com.example.flutter_app_panel/com.example.flutter_app_panel.MainActivity [+3047 ms] Starting: Intent { act=android.intent.action.RUN flg=0x20000000 cmp=com.example.flutter_app_panel/.MainActivity (has extras) } [ +1 ms] Waiting for observatory port to be available... [ +215 ms] Observatory URL on device: http://127.0.0.1:44280/pdXkxI1nLjI=/ [ +9 ms] executing: C:\Users\ArunsivaRengaraju\AppData\Local\Android\sdk\platform-tools\adb.exe -s 6318aa1a0104 forward tcp:0 tcp:44280 [+1802 ms] 63819 [ +1 ms] Forwarded host port 63819 to device port 44280 for Observatory [ +10 ms] Connecting to service protocol: http://127.0.0.1:63819/pdXkxI1nLjI=/ [ +459 ms] Successfully connected to service protocol: http://127.0.0.1:63819/pdXkxI1nLjI=/ [ +13 ms] Sending to VM service: getVM({}) [ +21 ms] Result: {type: VM, name: vm, architectureBits: 64, hostCPU: Qualcomm Technologies, Inc MSM8953, operatingSystem: android, targetCPU: arm64, version: 2.8.0-dev.5.0.flutter-fc3af737c7 (Fri Jan 24 09:53:26 2020 +0000) on "android_arm64", _profilerMode: VM, _... [ +24 ms] Sending to VM service: getIsolate({isolateId: isolates/2231208233335395}) [ +9 ms] Sending to VM service: _flutter.listViews({}) [ +27 ms] Result: {type: FlutterViewList, views: [{type: FlutterView, id: _flutterView/0x7fac04f820, isolate: {type: @Isolate, fixedId: true, id: isolates/2231208233335395, name: main.dart$main-2231208233335395, number: 2231208233335395}}]} [ +6 ms] DevFS: Creating new filesystem on the device (null) [ +1 ms] Sending to VM service: _createDevFS({fsName: flutter_app_panel}) [ +14 ms] Result: {type: Isolate, id: isolates/2231208233335395, name: main, number: 2231208233335395, _originNumber: 2231208233335395, startTime: 1581675529061, _heaps: {new: {type: HeapSpace, name: new, vmName: Scavenger, collections: 2, avgCollectionPeriodMillis... [ +71 ms] Result: {type: FileSystem, name: flutter_app_panel, uri: file:///data/user/0/com.example.flutter_app_panel/code_cache/flutter_app_panelMDGDVY/flutter_app_panel/} [ +2 ms] DevFS: Created new filesystem on the device (file:///data/user/0/com.example.flutter_app_panel/code_cache/flutter_app_panelMDGDVY/flutter_app_panel/) [ +6 ms] Updating assets [ +138 ms] Syncing files to device Redmi Note 4... [ +2 ms] Scanning asset files [ +2 ms] <- reset [ ] Compiling dart to kernel with 0 updated files [ +9 ms] C:\src\flutter\bin\cache\dart-sdk\bin\dart.exe C:\src\flutter\bin\cache\artifacts\engine\windows-x64\frontend_server.dart.snapshot --sdk-root C:\src\flutter\bin\cache\artifacts\engine\common\flutter_patched_sdk/ --incremental --target=flutter -Ddart.developer.causal_async_stacks=true --output-dill C:\Users\ARUNSI~1\AppData\Local\Temp\flutter_tool.3348f773-4f13-11ea-a892-98541b03ab78\app.dill --packages C:\Users\ArunsivaRengaraju\AndroidStudioProjects\flutter_app_panel\.packages -Ddart.vm.profile=false -Ddart.vm.product=false --bytecode-options=source-positions,local-var-info,debugger-stops,instance-field-initializers,keep-unreachable-code,avoid-closure-call-instructions --enable-asserts --track-widget-creation --filesystem-scheme org-dartlang-root [ +196 ms] <- compile package:flutter_app_panel/main.dart [+9698 ms] Updating files [ +192 ms] DevFS: Sync finished [ +2 ms] Syncing files to device Redmi Note 4... (completed in 10,103ms, longer than expected) [ +1 ms] Synced 0.9MB. [ +1 ms] Sending to VM service: _flutter.listViews({}) [ +6 ms] Result: {type: FlutterViewList, views: [{type: FlutterView, id: _flutterView/0x7fac04f820, isolate: {type: @Isolate, fixedId: true, id: isolates/2231208233335395, name: main.dart$main-2231208233335395, number: 2231208233335395}}]} [ +1 ms] <- accept [ ] Connected to _flutterView/0x7fac04f820. [ +2 ms] Flutter run key commands. [ +3 ms] r Hot reload. οΏ½οΏ½οΏ½ [ +2 ms] R Hot restart. [ +1 ms] h Repeat this help message. [ +1 ms] d Detach (terminate "flutter run" but leave application running). [ +1 ms] q Quit (terminate the application on the device). [ ] An Observatory debugger and profiler on Redmi Note 4 is available at: http://127.0.0.1:63819/pdXkxI1nLjI=/ ``` </details> Regards, Arun Siva R
framework,f: scrolling,platform-web,has reproducible steps,P2,found in release: 3.3,found in release: 3.5,team-web,triaged-web
low
Critical
564,784,511
scrcpy
addressing devices using transport id instead of serial
Greetings, is there any existing way implemented to address several devices connected via USB with their transport id instead of serial? In my development of a custom AOSP ROM i have an issue with distinct devices having the same serial when adb lists them (but different transport id). ADB allows addressing devices with `-t transport_id` and it works fine for most adb commands except scrcpy which always errors with "more than one device" because i cannot specify -t in it's internal adb call. Using `scrcpy -s serial` is not an option because it consistently chooses the first of the two (or more) devices because they all have the same serial. example: ``` adb devices -l serial1111 device usb:3-3 product:msm8953_64 model:msm8953_for_arm64 device:msm8953_64 transport_id:1 serial1111 device usb:3-4 product:msm8953_64 model:msm8953_for_arm64 device:msm8953_64 transport_id:2 ``` Right now i can work around around the issue by making a wrapper script that calls the real adb with `adb -t my_transport_id` internally (and by placing it first in PATH scrcpy will use it as if it was the adb binary) but it might be useful if it's not complicated to implement addressing by transport id directly within scrcpy.
feature request
low
Critical
564,784,666
TypeScript
Package dependencies and The inferred type of ... cannot be named without a reference to ...
Hello, as a POC, I created a repository dedicated to this issue, to show how it is happening! Repository: https://github.com/nogueira7egend/ts-symlink-error/ Please check it and follow the instructions that are on README! Best regards **TypeScript Version:** 3.7.5 **Actual behavior:** <img width="1639" alt="Captura de ecrã 2020-02-04, às 17 45 45" src="https://user-images.githubusercontent.com/20382354/74453034-c452ee00-4e79-11ea-852d-3fbdf61dae39.png"> **Playground Link:** https://github.com/nogueira7egend/ts-symlink-error/ **Related Issues:** #29808
Needs Investigation
low
Critical
564,792,746
create-react-app
Using url in SCSS mixin in another file doesn't import files correctly
Reopened from #7777, which was closed because the fix was supposedly released in 3.3.1, but it is still broken. ### Describe the bug Using an SCSS mixin (located in another file) that uses the url function makes the file unable to be found. Example: ```scss // src/scss/mixins.scss @mixin next-gen-image ($file-name, $fallback-ext) { .webp-supported & { background-image: url('#{$file-name}.webp'); } .webp-not-supported & { background-image: url('#{$file-name}.#{$fallback-ext}'); } } ``` ```scss // src/jsx/routes/Home.scss @import './../../scss/mixins'; .my-class { @include next-gen-image('some-image', 'jpg'); } ``` This should try to lookup `src/jsx/routes/some-image.webp` and `src/jsx/routes/some-image.jpg` but it instead tries to look for `src/scss/some-image.webp` and `src/scss/some-image.jpg` respectively. This was working prior to 3.1.x. ### Did you try recovering your dependencies? yes node version: v10.16.3 npm version: 6.13.7 ### Which terms did you search for in User Guide? - scss - sass nothing regarding this issue came up ### Environment ``` ➜ create-react-app-issue-7598 git:(master) βœ— npx create-react-app --info npx: installed 99 in 6.073s Environment Info: current version of create-react-app: 3.3.1 running from /Users/dak/.npm/_npx/67157/lib/node_modules/create-react-app System: OS: macOS High Sierra 10.13.4 CPU: (8) x64 Intel(R) Core(TM) i7-4770HQ CPU @ 2.20GHz Binaries: Node: 10.16.3 - ~/.nvm/versions/node/v10.16.3/bin/node Yarn: 1.15.2 - /usr/local/bin/yarn npm: 6.13.7 - ~/.nvm/versions/node/v10.16.3/bin/npm Browsers: Chrome: 80.0.3987.100 Firefox: 72.0.2 Safari: 11.1 npmPackages: react: 16.12.0 => 16.12.0 react-dom: 16.12.0 => 16.12.0 react-scripts: 3.3.1 => 3.3.1 npmGlobalPackages: create-react-app: Not Found ``` ### Steps to reproduce See: https://github.com/Dakkers/create-react-app-issue-7598 ### Expected behavior See: https://github.com/Dakkers/create-react-app-issue-7598 ### Actual behavior See: https://github.com/Dakkers/create-react-app-issue-7598 ### Reproducible demo https://github.com/Dakkers/create-react-app-issue-7598
issue: bug report
medium
Critical
564,808,006
vscode
Allow ThemeIcon in WebviewPanel.iconPath
Issue Type: <b>Feature Request</b> You can only pass an Uri or an object containing Uris to WebviewPanel.iconPath, while iconPath on QuickInputButton and TreeItem also supports ThemeIcon. This would increase codicon reusability. VS Code version: Code 1.42.0 (ae08d5460b5a45169385ff3fd44208f431992451, 2020-02-06T10:51:34.058Z) OS version: Windows_NT x64 10.0.18362 <!-- generated by issue reporter -->
help wanted,feature-request,api,webview,icons-product
low
Major
564,809,123
pytorch
Training got stuck due to timeout from dataloader
The same training script works well with Pytorch 1.4 before. Trying to test some new stuff in master branch (built from source), but training always got stuck after a few hundreds iterations without triggering any error info. If I ctrl-C it, it was traced down to some timeout function in dataloader. Again the same training code and configuration worked well with 1.4. Any clue? Iteration 198: train = 1.8057, g_train = 0.9733, t_train = 0.8221, kl_train = 1.02579618 Iteration 199: train = 0.9988, g_train = 0.2920, t_train = 0.6974, kl_train = 0.93473649 Iteration 200: train = 1.3745, g_train = 0.4477, t_train = 0.9169, kl_train = 0.99940717 saved tex images for 200 Iteration 201: train = 1.1959, g_train = 0.3795, t_train = 0.8027, kl_train = 1.37421489 ^CTraceback (most recent call last): ...... ...... File "/mnt/home/xxxx/anaconda3/envs/pytorch-py36/lib/python3.6/site-packages/torch/utils/data/dataloader.py", line 345, in __next__ data = self._next_data() File "/mnt/home/xxxx/anaconda3/envs/pytorch-py36/lib/python3.6/site-packages/torch/utils/data/dataloader.py", line 841, in _next_data idx, data = self._get_data() File "/mnt/home/xxxx/anaconda3/envs/pytorch-py36/lib/python3.6/site-packages/torch/utils/data/dataloader.py", line 808, in _get_data success, data = self._try_get_data() File "/mnt/home/xxxx/anaconda3/envs/pytorch-py36/lib/python3.6/site-packages/torch/utils/data/dataloader.py", line 761, in _try_get_data data = self._data_queue.get(timeout=timeout) File "/mnt/home/xxxx/anaconda3/envs/pytorch-py36/lib/python3.6/multiprocessing/queues.py", line 104, in get if not self._poll(timeout): File "/mnt/home/xxxx/anaconda3/envs/pytorch-py36/lib/python3.6/multiprocessing/connection.py", line 257, in poll return self._poll(timeout) File "/mnt/home/xxxx/anaconda3/envs/pytorch-py36/lib/python3.6/multiprocessing/connection.py", line 414, in _poll r = wait([self], timeout) File "/mnt/home/xxxx/anaconda3/envs/pytorch-py36/lib/python3.6/multiprocessing/connection.py", line 911, in wait ready = selector.select(timeout) File "/mnt/home/xxxx/anaconda3/envs/pytorch-py36/lib/python3.6/selectors.py", line 376, in select fd_event_list = self._poll.poll(timeout) KeyboardInterrupt - PyTorch Version (e.g., 1.0): 1.5.0a0+ab14375 - OS (e.g., Linux): Linux - How you installed PyTorch (`conda`, `pip`, source): source - Build command you used (if compiling from source): USE_MPI=OFF python setup.py install - Python version: 3.6 - CUDA/cuDNN version: 9.0 Thanks in advance! cc @SsnL @VitalyFedyunin @ngimel
module: performance,module: dataloader,triaged
medium
Critical
564,812,364
rust
The "type_alias_impl_trait" feature has problems handling lifetime parameters.
<!-- Thank you for filing a bug report! πŸ› Please provide a short summary of the bug, along with any information you feel relevant to replicating the bug. --> I was starting with this function (which does compile on nightly): ```rust #![feature(unboxed_closures)] #![feature(type_alias_impl_trait)] fn curry<'a, A: 'a, B, C, F: Fn(A, B) -> C> (f: &'a F) -> impl Fn<(A,), Output = impl FnOnce(B) -> C + 'a> + 'a { move |a| move |b| f(a,b) } ``` and wanted to give a name to its return type. The straightforward approach seems to be _(please correct me if the "right" way to do this is different)_: ```rust #![feature(unboxed_closures)] #![feature(type_alias_impl_trait)] type Curried<'a, A: 'a, B, C, F: Fn(A, B) -> C> = impl Fn<(A,), Output = impl FnOnce(B) -> C + 'a> + 'a; fn curry<'a, A: 'a, B, C, F: Fn(A, B) -> C> (f: &'a F) -> Curried<'a, A, B, C, F> { move |a| move |b| f(a,b) } ``` But the compiler is currently unhappy with the lifetimes. I'm getting the following. ``` error: cannot infer an appropriate lifetime --> src/main.rs:11:5 | 6 | = impl Fn<(A,), Output = impl FnOnce(B) -> C + 'a> + 'a; | ------------------------ this return type evaluates to the `'static` lifetime... ... 11 | move |a| move |b| f(a,b) | ^^^^^^^^^^^^^^^^^^^^^^^^ ...but this borrow... | note: ...can't outlive the lifetime `'a` as defined on the function body at 8:10 --> src/main.rs:8:10 | 8 | fn curry<'a, A: 'a, B, C, F: Fn(A, B) -> C> (f: &'a F) | ^^ help: you can add a bound to the return type to make it last less than `'static` and match the lifetime `'a` as defined on the function body at 8:10 | 9 | -> Curried<'a, A, B, C, F> + '_ | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ error: cannot infer an appropriate lifetime --> src/main.rs:11:14 | 6 | = impl Fn<(A,), Output = impl FnOnce(B) -> C + 'a> + 'a; | ------------------------ this return type evaluates to the `'static` lifetime... ... 11 | move |a| move |b| f(a,b) | ^^^^^^^^^^^^^^^ ...but this borrow... | note: ...can't outlive the lifetime `'a` as defined on the function body at 8:10 --> src/main.rs:8:10 | 8 | fn curry<'a, A: 'a, B, C, F: Fn(A, B) -> C> (f: &'a F) | ^^ help: you can add a bound to the return type to make it last less than `'static` and match the lifetime `'a` as defined on the function body at 8:10 | 9 | -> Curried<'a, A, B, C, F> + '_ | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ error: aborting due to 2 previous errors ``` It works without the lifetimes (i.e. after removing parametrization over 'a and replacing all occurrences of 'a with 'static), like this: ```rust #![feature(unboxed_closures)] #![feature(type_alias_impl_trait)] type Curried<A: 'static, B, C, F: Fn(A, B) -> C> = impl Fn<(A,), Output = impl FnOnce(B) -> C + 'static> + 'static; fn curry<A: 'static, B, C, F: Fn(A, B) -> C> (f: &'static F) -> Curried<A, B, C, F> { move |a| move |b| f(a,b) } use std::ops::Add; fn main() { let x = curry(&i32::add)(1)(2); println!("{}", x); // prints "3" } ``` ### Meta <!-- If you're using the stable version of the compiler, you should also check if the bug also exists in the beta or nightly versions. --> Current behavior only since #67844 was fixed (after `nightly-2020-02-14`). Before that, this code triggered an ICE.
A-lifetimes,E-needs-test,A-closures,T-compiler,C-bug,F-type_alias_impl_trait
low
Critical
564,823,904
pytorch
[feature request] torch.expand to not require unsqueeze and match -1 to existing dimensions if tensor.shape.count(-1) == tensor.ndim
```python torch.rand(2).expand(-1, 3) #RuntimeError: The expanded size of the tensor (3) must match the existing size (2) at non-singleton dimension 1. Target sizes: [-1, 3]. Tensor sizes: [2] torch.rand(2).unsqueeze(-1).expand(-1, 3) # works ``` Docs: ``` Passing -1 as the size for a dimension means not changing the size of that dimension. Tensor can be also expanded to a larger number of dimensions, and the new ones will be appended at the front. For the new dimensions, the size cannot be set to -1. ``` Here I'm asking a new dimension at the end, not in the front. So it's not perfectly clear why it doesn't like leading -1. If number of -1's is equal to the number of dimensions in the original tensor, the leading -1 limitation could be alleviated?
triaged,enhancement
low
Critical
564,852,967
pytorch
Don't take TensorOptions by reference
The class was explicitly designed to be two words large, we should pass it by value. cc @yf225
module: cpp,triaged
low
Minor
564,861,071
pytorch
torch::var_out and dimnames
## πŸ› Bug Using `torch::var_out` in the C++ API with dimnames instead of the index of the dimension seems to return the standard deviation instead of the variance. ## To Reproduce Running the following program: ``` #include <torch/torch.h> #include <iostream> int main() { auto d = torch::Dimname::fromSymbol(torch::Symbol::dimname("a")); std::vector<torch::Dimname> ds; ds.push_back(d); auto x = torch::rand(100, ds); auto y = torch::zeros(1); torch::var_out(y, x, {0}); std::cout << y << std::endl; auto z = torch::zeros(1); torch::var_out(z, x, ds); std::cout << z << std::endl; } ``` Returns: ``` (base) dfalbel@Daniels-MacBook-Pro build % ./example-app Warning: Named tensors and all their associated APIs are an experimental feature and subject to change. Please do not use them for anything important until they are released as stable. (operator() at ../c10/core/TensorImpl.h:845) 0.073097 [ CPUFloatType{} ] 0.270365 [ CPUFloatType{} ] ``` Since: ``` sqrt(0.073097) [1] 0.2703646 ``` It seems that when using dimnames `torch_var_out` is returning the standard deviation. ## Expected behavior Expected both values to be identical. ## Environment I am using Pytorch C++ 1.4 - downloaded from here: https://download.pytorch.org/libtorch/cpu/libtorch-macos-1.4.0.zip on MacOS cc @yf225 @zou3519
module: cpp,triaged,module: named tensor
low
Critical
564,873,603
terminal
Consider adding a WT_PROFILE env var pointing to settings file
If the settings UI is not planned until after 1.0, then I strongly recommend adding an environment variable with the path to the json settings file, so it can be edited with the editor of choice (vi, notepad, nano, emacs, whatever) from within the shell of choice without burning brain calories trying to find it buried in AppData. Also: Relying on the GUI menu is, well, unreliable, due to there being no guarantee of a valid file association for json files. We've already got `WT_SESSION` env var -- something like `WT_PROFILE` would be useful. Then from within cmd or powershell, I can easily edit settings with my preferred editor, or interactively using `$settings = gc $env:WT_PROFILE | convertto-json` and flipping settings on the object model directly before saving it back out.
Issue-Feature,Help Wanted,Area-Settings,Product-Terminal
medium
Critical
564,933,791
go
x/tools/gopls: show message with link to debug server with -debug=:0
currently we ask users to supply flags such as `-port` and `-rpc.trace` and restart gopls when debugging is needed. Please consider turning on the debug port by default and make some traces available. - Port number needs to be picked up randomly - so we will need a way for the client to ask gopls about the debug port location. - May need too allow opt-out.
help wanted,NeedsFix,gopls,Tools
low
Critical
564,939,488
terminal
Calling wt from cmd for working directory "C:\" causes an error
Hi, I was testing the new command line options to open a Windows Terminal for a specified working directory. When calling `wt new-tab -d "C:\"` from PowerShell this seems to work. Calling the same command from cmd however will print the error message `[error 0x8007010b when launching `powershell.exe']` in the newly opened Windows Terminal instance. Using the "-p" option to launch a different shell will provoke the same error message for the executable associated with the specified profile name. # Environment ```none Windows build number: Microsoft Windows [Version 10.0.18363.657] Windows Terminal version: 0.9.433.0 ``` # Steps to reproduce Call `wt new-tab -d "C:\"` from cmd. # Expected behavior Open a new Windows Terminal tab with path `C:\` set as the current working directory. # Actual behavior Opens a Windows Terminal instance with the message: ``[error 0x8007010b when launching `powershell.exe']``
Issue-Bug,Product-Terminal,Priority-2,Area-Commandline
medium
Critical
564,943,115
angular
`preserveWhitespaces`: false cause i18n interpolation placeholder to be different from xi18n
<!--πŸ”…πŸ”…πŸ”…πŸ”…πŸ”…πŸ”…πŸ”…πŸ”…πŸ”…πŸ”…πŸ”…πŸ”…πŸ”…πŸ”…πŸ”…πŸ”…πŸ”…πŸ”…πŸ”…πŸ”…πŸ”…πŸ”…πŸ”…πŸ”…πŸ”…πŸ”…πŸ”…πŸ”…πŸ”…πŸ”…πŸ”… Oh hi there! πŸ˜„ To expedite issue processing please search open and closed issues before submitting a new one. Existing issues often contain information about workarounds, resolution, or progress updates. πŸ”…πŸ”…πŸ”…πŸ”…πŸ”…πŸ”…πŸ”…πŸ”…πŸ”…πŸ”…πŸ”…πŸ”…πŸ”…πŸ”…πŸ”…πŸ”…πŸ”…πŸ”…πŸ”…πŸ”…πŸ”…πŸ”…πŸ”…πŸ”…πŸ”…πŸ”…πŸ”…πŸ”…πŸ”…πŸ”…πŸ”…πŸ”…πŸ”…--> # 🐞 bug report ### Affected Package <!-- Can you pin-point one or more @angular/* packages as the source of the bug? --> The issue is caused by package `@angular/compiler` ### Is this a regression? <!-- Did this behavior use to work in the previous version? --> Yes, the previous version in which this bug was not present was: 8.2.12 ### Description If I have this template: ```html <div>{{ name }} and {{ name }}</div> ``` `ng xi18n` will cause the first interpolation to be `INTERPOLATION` and the second one to be `INTERPOLATION_1`. (Notice that the second has an extra whitespace.) After that, if you run `ng build --localize`, the remove whitespace thingy will kick in and the second pass of `I18nMetaVisitor` will cause the second interpolation to be just `INTERPOLATION`, as indicated here: https://github.com/angular/angular/blob/b2222e7e02a05544c9b0e414c4258751209459ee/packages/compiler/src/render3/view/template.ts#L1974-L1990 That means the `INTERPOLATION_1` won't match and it will error as indicated here: https://github.com/angular/angular/blob/b2222e7e02a05544c9b0e414c4258751209459ee/packages/localize/src/utils/src/translations.ts#L67-L72 Another example of template that will cause this issue: ```html <div>{{ name | thePipe }} and {{ name | thePipe }} </div> ``` (Notice the newline.) ## πŸ”¬ Minimal Reproduction https://github.com/sarunint/ng-i18n-preserveWhitespaces ## πŸ”₯ Exception or Error <pre><code> No placeholder found with name INTERPOLATION_1 in message "songNormalInstruction" (" {$INTERPOLATION} แΰΈ₯ΰΈ° {$INTERPOLATION} "). </code></pre> ## 🌍 Your Environment **Angular Version:** <pre><code> Angular CLI: 9.0.2 Node: 12.15.0 OS: linux x64 Angular: 9.0.1 ... animations, common, compiler, compiler-cli, core, forms ... language-service, localize, platform-browser ... platform-browser-dynamic, router Ivy Workspace: Yes Package Version ----------------------------------------------------------- @angular-devkit/architect 0.900.2 @angular-devkit/build-angular 0.900.2 @angular-devkit/build-optimizer 0.900.2 @angular-devkit/build-webpack 0.900.2 @angular-devkit/core 9.0.2 @angular-devkit/schematics 9.0.2 @angular/cli 9.0.2 @ngtools/webpack 9.0.2 @schematics/angular 9.0.2 @schematics/update 0.900.2 rxjs 6.5.4 typescript 3.7.5 webpack 4.41.2 </code></pre> **Anything else relevant?** May be related to #26276
type: bug/fix,area: i18n,workaround1: obvious,freq1: low,area: compiler,state: confirmed,P3
low
Critical
564,945,661
storybook
vue addon-docs display prop values in prop table.
**Is your feature request related to a problem? Please describe.** I'm not sure if this is already possible, but I have looked around and tried a bunch of different options, but I would like the possible values for a component prop to show up in the prop table in docs. _This may already be possible, but it seems that all of my jsdoc comments are being pulled except for the @values field. Please point me in the right direction if so._ **Describe the solution you'd like** Grab @values from jsdoc on component and display in addon-docs prop table. Displaying under the description would be nice, or another column all together. **Describe alternatives you've considered** It looks like this may be possible by describing the props with PropTypes in your story, but since I am using, Vue, that would be an extra dependency that only gets used for this feature. JSDoc has @values so it would be nice to have that pulled in as well. **Are you able to assist bring the feature to reality?** Possibly. If someone could point me in the right direction **Additional context** Here is the image that shows what I would like: ![Example](https://raw.githubusercontent.com/storybookjs/storybook/master/addons/docs/docs/media/docspage-hero.png) It shows the possible values in the description. This is from the docs documentation so it looks like it may be possible, but just not working for me.
feature request,vue,addon: docs,block: props
low
Major
564,949,600
terminal
Cannot find info on hosting terminal in another app.
We need documentation on hosting the console. Project templates would be very helpful.
Issue-Docs,Area-TerminalControl,Product-Meta
medium
Major
564,961,644
rust
Incorrect trait-object warning when returning a type-alias-impl-trait
The following code: ```rust #![feature(type_alias_impl_trait)] type Foo = impl Copy; fn bar(val: &u8) -> Foo + 'static { true } ``` produces the following messages: ``` error[E0404]: expected trait, found opaque type `Foo` --> src/lib.rs:4:21 | 4 | fn bar(val: &u8) -> Foo + 'static { | ^^^ not a trait warning: trait objects without an explicit `dyn` are deprecated --> src/lib.rs:4:21 | 4 | fn bar(val: &u8) -> Foo + 'static { | ^^^^^^^^^^^^^ help: use `dyn`: `dyn Foo + 'static` | = note: `#[warn(bare_trait_objects)]` on by default ``` The error message is correct - `Foo` is not a trait, so writing `+ 'static` makes no sense. However, the warning message is completely inapplicable - `Foo` is not a trait, so adding `dyn` will just produce a different error. We should suppress this warning if the user didn't actually write down the name of a trait.
A-lints,T-compiler,C-bug,F-type_alias_impl_trait,D-invalid-suggestion,A-trait-objects
low
Critical
564,987,078
flutter
Allow Hero to define it's Overlay level
This is the `Hero` animation I want to achieve: ![image](https://user-images.githubusercontent.com/8120472/74483838-16a20800-4e96-11ea-9ca9-a4c2fe9b11b5.png) The green rectangle flies to the second screen, landing BEHIND the rounded-square purple grid. As far as I know, if I do this right now the `Hero` will land on top of the grid and then it will flicker for a frame appearing behind the grid. I could use a `flightShuttleBuilder` but this will turn things a lot more complicated, I will have to animate the fade-in of the grid myself, I will have to create the grid in 2 screens, too much stuff to take care for just one animation. I think cases like this could be simplified if there was a way to tag which `Overlay` the `Hero` should be rendered into, so the grid could tagged to be at the top `Overlay`, the `Hero` at the `Overlay` behind it, and the rest of the UI below.
c: new feature,framework,a: animation,f: routes,P3,team-framework,triaged-framework
high
Critical
565,006,270
TypeScript
Exported type merged with 'export * as namespace...' only exports type meaning.
> Previously I liked using TS namespaces and declaration merging for creating FP-style modules, without needing the `MyModule.T` convention: > > ```ts > export type Foobar = { } > > export namespace Foobar { > export function doStuff(foobar: Foobar) { } > } > ``` > > ```ts > import { Foobar } from './Foobar' > > Foobar.doStuff(fb) > ``` > > Namespaces are not really the way to go any more, babel doesn't support them, they probably aren't tree-shakeable etc. But I was hoping that the `export * as ns` syntax could be > used as a replacement, like this: > > ```ts > export type Foobar = import('./Foobar').Foobar > > // Or: > // export type { Foobar } from './Foobar' > > export * as Foobar from './Foobar' > ``` > > This seems to pass the nightly compiler, but the compiler only knows that Foobar is re-exported as a type, not a value. It would be great if the compiler could merge them into a combined value & type like with namespaces. _Originally posted by @katis in https://github.com/microsoft/TypeScript/issues/4813#issuecomment-577284794_
Bug
low
Minor
565,006,596
rust
rustc fails to resolve an associated type when using Self: Trait<A> in a method of a trait
<!-- Thank you for filing a bug report! πŸ› Please provide a short summary of the bug, along with any information you feel relevant to replicating the bug. --> _Somewhat_ minimal reproducible code: ```rust pub trait Foo<L> { type Repr; fn foo(repr: &Self::Repr); } pub trait Bar { fn bar<L>(repr: &Self::Repr) where Self: Foo<L>; } // now let’s implement Bar for a type #[derive(Debug)] pub struct Hello { pub handle: u32, } impl<L> Foo<L> for u32 { type Repr = Hello; fn foo(repr: &Self::Repr) { println!("{:?}", repr); } } // the weird things start here; notice how we need <Self as Base<L>> here impl Bar for u32 { fn bar<L>(repr: &<Self as Foo<L>>::Repr) where Self: Foo<L>, { println!( "{}", repr.handle // <- opaque type here //unsafe { std::mem::transmute::<_, &Hello>(repr) }.handle // <- current workaround :() ); } } fn main() { let h = Hello { handle: 3 }; u32::bar::<()>(&h); } ``` I expected to see this happen: code should compile just fine. Instead, this happened: result from _rustc_: ``` error[E0609]: no field `handle` on type `&<u32 as Foo<L>>::Repr` --> src/main.rs:52:18 | 52 | repr.handle // <- opaque type here | ^^^^^^ error: aborting due to previous error ``` ### Meta <!-- If you're using the stable version of the compiler, you should also check if the bug also exists in the beta or nightly versions. --> Bug present in both _stable_ and _nightly_ (I haven’t tested _beta_ but I guess it’s there too). `rustc --version --verbose`: ``` rustc 1.41.0 (5e1a79984 2020-01-27) binary: rustc commit-hash: 5e1a799842ba6ed4a57e91f7ab9435947482f7d8 commit-date: 2020-01-27 host: x86_64-unknown-linux-gnu release: 1.41.0 LLVM version: 9.0 ``` <details><summary>Backtrace</summary> <p> ``` N/A ``` </p> </details>
A-associated-items,T-compiler,C-bug
low
Critical
565,020,528
PowerToys
[PowerRename] Allow changing of other attributes in a batch
# Summary of the new feature/enhancement Do not know the feasibility of this feature, but why to stop with the filenames, ideally it will also detect if all files have the same extension, read the writable properties of the files and allow to change them in batch. Example for jpg, allow changing the subject, ratings, tags, date taken ... for mp4 files, authors, year, genre, parental ratings... # Proposed technical implementation details (optional) - Detect if all files have the same extension and properties/details. - When clicking on the PowerRenam offer the option to apply it to the filename or any other field detected.
Idea-Enhancement,Help Wanted,Product-PowerRename,Cost-Large
low
Minor
565,048,427
pytorch
Creating Torch tensors slows OpenCV video reading a lot
## πŸ› Bug I am developing a system that samples frames from videos and runs them through a deep network. When I profiled the code I noticed that OpenCV read videos much slower than expected. Compared to a naive program that only grabs frames and does nothing else, this program spends x2 more time grabbing frames. I managed to figure out a simple condition to trigger this slowing: to create a torch tensor of size >= 100000 whenever I sampled a frame. Something like ```python magic_tensor = torch.zeros(100000) ``` I can use any shape (e.g. 100000x1, 320x320), and even any data type (e.g. uint8, float64). The turning point is exactly 100000, as 99999 won't trigger the slowing. Making a larger tensor or creating more tensors don't deteriorate the speed further. Creating such an array slows the all cv2.grab() function calls in a short period of time. If I call time.sleep(1) to sleep for 1 second after I create an array, subsequent video reading is not affected at all. When this experiment is performed in the main thread, video reading takes roughly 1.4x time of the baseline. However, when it is performed in a new thread (this is my use case), the time is about 2.4x of the baseline. ## To Reproduce The code below will perform three experiments to show the issue. The `read_video_test(filename, use_magic_code)` function samples every 30th frame from a video. When `use_magic_code` is `True`, after a frame retrieval of the magic tensor is created, which will slows the grabbing. In reality this is the place I send the images to the deep network. The three experiments are as follows: * Baseline. `read_video_test` is performed without creating torch tensor. * Reproduction in the main thread. This slows the video reading by ~50%. * Reproduction in a new thread. This slows the video reading by ~150%. The test video I use has size of 1920x1080 and is about 20s long. I can reproduce it on other videos too, including videos of different duration and of different resolution (e.g. 360p). Enabling or disabling CUDA seems has not influence on this issue. ```python import threading import time import cv2 import torch def read_video_test(filename, use_magic_code): cap = cv2.VideoCapture(filename) assert cap.isOpened() frame_idx = 0 total_grab_time = 0 total_time = time.time() while cap.isOpened(): # --------- Measure the grabbing time --------- grab_time = time.time() ret = cap.grab() grab_time = time.time() - grab_time total_grab_time += grab_time # --------------------------------- if not ret: break if not frame_idx % 30: # decode every 30th frame ret, frame = cap.retrieve() if use_magic_code: # magic code: # trigger condition: size >= 100000, regardless of data type magic_tensor = torch.zeros(100000, dtype=torch.int8) frame_idx += 1 total_time = time.time() - total_time print("total time: {:.4}, cap.grab() took {:.4}s".format( total_time, total_grab_time)) if __name__ == '__main__': test_vid = "data/VID_20190407_170747.mp4" # 1.0x time Baseline print('Exp#1: baseline, torch code disabled') read_video_test(test_vid, False) print("------------------------------------") # 1.4x time print('Exp#2: main thread execution, torch code enabled') read_video_test(test_vid, True) print("------------------------------------") # 2.4x time print('Exp#3: new thread execution, torch code enabled') t = threading.Thread( target=read_video_test, args=(test_vid, True)) t.start() t.join() print("------------------------------------") ``` ## Result ``` Exp#1: baseline, torch code disabled total time: 1.41, cap.grab() took 1.279s ------------------------------------ Exp#2: main thread execution, torch code enabled total time: 1.963, cap.grab() took 1.841s ------------------------------------ Exp#3: new thread execution, torch code enabled total time: 3.594, cap.grab() took 3.389s ------------------------------------ ``` Ideally there should not be any difference ## Environment PyTorch version: 1.2.0 Is debug build: No CUDA used to build PyTorch: 10.0.130 OS: Ubuntu 16.04.6 LTS GCC version: (Ubuntu 5.4.0-6ubuntu1~16.04.12) 5.4.0 20160609 CMake version: version 3.5.1 Python version: 3.7 Is CUDA available: Yes CUDA runtime version: Could not collect GPU models and configuration: GPU 0: Tesla P100-PCIE-16GB Nvidia driver version: 410.48 cuDNN version: /usr/lib/x86_64-linux-gnu/libcudnn.so.7.6.4 Versions of relevant libraries: opencv 3.4.2 py37h6fd60c2_1 [pip] numpy==1.17.2 [pip] torch==1.2.0 [pip] torchsummary==1.5.1 [pip] torchvision==0.4.0a0 [conda] _pytorch_select 0.2 gpu_0 [conda] blas 1.0 mkl [conda] mkl 2019.4 243 [conda] mkl-service 2.3.0 py37he904b0f_0 [conda] mkl_fft 1.0.14 py37ha843d7b_0 [conda] mkl_random 1.1.0 py37hd6b4f25_0 [conda] pytorch 1.2.0 cuda100py37h938c94c_0 [conda] torchsummary 1.5.1 pypi_0 pypi [conda] torchvision 0.4.0 cuda100py37hecfc37a_0 I am able to reproduce it on a google cloud server and my laptop. Both have the same software configuration. ## Additional context <!-- Add any other context about the problem here. --> cc @VitalyFedyunin @ngimel
module: performance,triaged,module: multithreading
low
Critical
565,060,102
flutter
Flutter Gradle plugin improvements
Review by @cmwarrington: line 103: addfluttertasks can happen eagerly (or atleast IIUC on the configuration of the android plugin) See for an example of how to do this see internal example. line 323: Trigger from application of AGP, rather than afterEvaluate line 329-330 - use .all rather than .each and .whenObjectAdded line 366 Trigger from application of AGP, rather than afterEvaluate line 705 : Cross project configuration is going away - It's not obvious to me looking at the code why you can't just add asset sources - your compile task can output assets into a build directory, and while we don't have a registerGeneratedAssets (we will have something like that soonish), you can just add that directory as an asset source directory, and make the prebuild task depend on it. line 707 : trigger from application of AGP, rather than afterEvaluate
tool,t: gradle,dependency: android,P2,team-tool,triaged-tool
low
Minor
565,092,802
go
proposal: x/crypto/ocsp: Return ocsp.Request from CreateRequest instead of []byte
The `ocsp.CreateRequest` function returns an OCSP request as a `[]byte`. It would be helpful to instead have it return `ocsp.Request`, which can then be marshalled into `[]byte` if needed. My specific use case is implementing a cache for OCSP responses. Per https://community.digicert.com/en/blogs.entry.html/2015/02/26/what-is-ocsp.html, the cache key should be the `CertID` sequence for the OCSP request (issueNameHash + issueKeyHash + serialNumber). All of these fields are calculated in `ocsp.CreateRequest` but because that function returns a `[]byte`, accessing them after it's been called would require an additional call to `ocsp.ParseRequest`, which seems wasteful. I'm not sure what the stability guarantee is for the x/crypto/ocsp library, but if changing the return type for the existing function isn't feasible, perhaps a new function could be added or the existing function could be deprecated and split into two functions.
Proposal,Proposal-Crypto
low
Minor
565,096,246
vscode
Add support for premium extensions
This was previously raised in #36577 but that is closed and locked. Rather than reopen it please allow this one to be a backlog candidate at least, so interested folk can upvote it.
feature-request
medium
Critical
565,117,331
deno
Support a pty interface
Deno should support forking of pty interfaces (psuedo terminals) which would allow Deno workloads to be able to "pretend" to be a terminal, which can allow Deno workloads to be a terminal emulator or allow certain programs to think a Deno workload is an terminal to send it control sequences. Node.js Prior art: https://github.com/microsoft/node-pty (which is used to provide the terminal interface in VSCode) Likely this crate can be used: https://docs.rs/portable-pty/0.2.0/portable_pty/ which provides Linux/Mac and Windows support. cc/ @Lerc
cli,suggestion,help wanted
medium
Major
565,182,293
rust
Disambiguate method call for impl on dyn Trait
```rust pub trait Error: Debug + Display { fn source(&self) -> Option<&(dyn Error + 'static)> { None } fn chain(&self) -> Chain<'_> where Self: Sized + 'static { Chain { current: Some(self), } } } impl dyn Error + 'static { fn chain(&self) -> Chain<'_> { Chain { current: Some(self), } } } ``` Seems like the compiler tries the trait method for an `dyn Error + 'static` even though it does not work, because of !Sized and does not consider taking the `impl dyn Error + 'static`. Playground: https://play.rust-lang.org/?version=nightly&mode=debug&edition=2018&gist=a6845b426451f1d7a5105a9bd3a00499 error: ``` error[E0034]: multiple applicable items in scope --> src/main.rs:82:28 | 82 | let mut iter = dyn_err.chain(); | --------^^^^^-- | | | | | multiple `chain` found | help: disambiguate the method call for candidate #2: `Error::chain(&dyn_err)` | note: candidate #1 is defined in an impl for the type `(dyn Error + 'static)` --> src/main.rs:16:5 | 16 | fn chain(&self) -> Chain<'_> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ note: candidate #2 is defined in the trait `Error` --> src/main.rs:8:5 | 8 | fn chain(&self) -> Chain<'_> where Self: Sized + 'static { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ```
A-trait-system,T-lang,C-bug
low
Critical
565,228,738
terminal
Documentation of use of ConPTY together with STARTF_USESTDHANDLES is lacking.
<!-- Briefly describe which document needs to be corrected and why. --> All existing documentation of ConPTY seem to only mention the case where stdin, stdout and stderr are all to be connected to the pty and no STARTF_USESTDHANDLES. The only mention that the proper value to have in StartupInfo.hStdInput et al when STARTF_USESTDHANDLES is active is NULL is indirectly in the documentation for GetStdHandle(). Using STARTF_USESTDHANDLES is useful if you want to keep stdout and stderr separate or want to redirect one of them to eg a file. An explicit mention in conjunction with STARTUPINFOA and/or PROC_THREAD_ATTRIBUTE_PSEUDOCONSOLE would be appreciated. Thanks.
Help Wanted,Issue-Docs,Product-Conpty,Area-Server
low
Minor
565,233,430
material-ui
[docs-infra] `@mui/icons-material` in-editor preview
## Summary πŸ’‘ Having a preview of the icons in the editor is similar to having autocomplete available for the API. Our icons explorer is definitely helpful and better if you need inspiration. But if you know what kind of icon you want then in-editor preview should boost productivity. ## Examples 🌈 1. link to icons explorer in SvgIcon.d.ts jsdoc 2. This shows a preview (vscode) when hovering over an imported icon ```ts import SvgIcon from '@material-ui/core/SvgIcon'; /** * Preview: ![LockIcon](https://fonts.gstatic.com/s/i/materialicons/lock/v4/24px.svg) */ declare const LockIcon: typeof SvgIcon; export default LockIcon; ``` credit to @leMaik for the markdown idea. ![icon-preview](https://user-images.githubusercontent.com/12292047/74522654-e8ffa200-4f1b-11ea-9410-46c119965c88.png) 3. Show icon preview in autocomplete (probably requires IDE extension) ## Motivation πŸ”¦ Seemed like a useful thing to have to me. Each of the examples can be explored further and implemented by whomever is looking for some work to do.
new feature,discussion,package: icons,ready to take,scope: docs-infra
low
Major
565,259,371
terminal
Drag & Drop Tabs to create a Pane
<!-- 🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨 I ACKNOWLEDGE THE FOLLOWING BEFORE PROCEEDING: 1. If I delete this entire template and go my own path, the core team may close my issue without further explanation or engagement. 2. If I list multiple bugs/concerns in this one issue, the core team may close my issue without further explanation or engagement. 3. If I write an issue that has many duplicates, the core team may close my issue without further explanation or engagement (and without necessarily spending time to find the exact duplicate ID number). 4. If I leave the title incomplete when filing the issue, the core team may close my issue without further explanation or engagement. 5. If I file something completely blank in the body, the core team may close my issue without further explanation or engagement. All good? Then proceed! --> # Description of the new feature/enhancement The current way of splitting panes using written commands or shortcuts is awesome but difficult to discover. There is already some drag & drop support for reordering tabs. It would be awesome to be able to drag & drop a tab to split a pane in the previous tab. An exemple of user interaction sequence: - Open Windows terminal: it shows a single tab with a single pane with powershell - Hit ctrl+shift+3 to open a ubuntu tab - drag the ubuntu tab > it shows me the previous tab (powershell) - using my mouse I can move the ubuntu tab into sensitive zones an preview the resulting split (a bit like Visual Studio/code UI) - I can then drop, and get a nice splitted pane. Optionally, show a popup saying "Want to automate that ? click here to copy an automation script to your clipboard", which would copy a script that would do the same thing. # Proposed technical implementation details (optional) Well, I am sure it is possible to do that by writing some code :)
Issue-Feature,Area-UserInterface,Product-Terminal
high
Critical
565,266,859
pytorch
how-to-adjust-learning-rate using libtorch
## ❓ Questions and Help ### Please note that this issue tracker is not a help form and this issue will be closed. We have a set of [listed resources available on the website](https://pytorch.org/resources). Our primary means of support is our discussion forum: - [Discussion Forum](https://discuss.pytorch.org/)
triaged
low
Minor
565,291,934
pytorch
malloc(): memory corruption (fast)
## πŸ› Bug I use the official Docker Images of Pytorch. When I try train my model using the DataParallel module, and during the training it's randomly crash, by segfault. Without DataParallel I get no error. ## To Reproduce Steps to reproduce the behavior: 1. Start to train a model, using data DataParallel on 2 GPUs Example of model (Sequential order) : - nn.Embedding() - nn.LSTM(bidirectionnal=True) - nn.Linear() Loss used : - BCEWithlogitsloss Optimizer : - Adam ``` *** Error in '/opt/conda/bin/python': malloc(): memory corruption (fast): 0x000055a9cabee518 *** ======= Backtrace: ========= /lib/x86_64-linux-gnu/libc.so.6(+0x777e5)[0x7f6094b627e5] /lib/x86_64-linux-gnu/libc.so.6(+0x82651)[0x7f6094b6d651] /lib/x86_64-linux-gnu/libc.so.6(__libc_malloc+0x54)[0x7f6094b6f184] /usr/lib/x86_64-linux-gnu/libstdc++.so.6(_Znwm+0x18)[0x7f60848a5e78] /opt/conda/lib/python3.6/site-packages/torch/lib/libc10_cuda.so(+0x1af81)[0x7f603c2b3f81] /opt/conda/lib/python3.6/site-packages/torch/lib/libc10_cuda.so(+0x1cd5e)[0x7f603c2b5d5e] /opt/conda/lib/python3.6/site-packages/torch/lib/libtorch.so(_ZN2at6native10empty_cudaEN3c108ArrayRefIlEERKNS1_13Tenso rOptionsENS1_8optionalINS1_12MemoryFormatEEE+0x284)[0x7f6042151094] /opt/conda/lib/python3.6/site-packages/torch/lib/libtorch.so(+0x455b8d8)[0x7f6040a218d8] /opt/conda/lib/python3.6/site-packages/torch/lib/libtorch.so(+0x1eedc47)[0x7f603e3b3c47] /opt/conda/lib/python3.6/site-packages/torch/lib/libtorch.so(+0x3ead8a5)[0x7f60403738a5] /opt/conda/lib/python3.6/site-packages/torch/lib/libtorch.so(+0x1eedc47)[0x7f603e3b3c47] /opt/conda/lib/python3.6/site-packages/torch/lib/libtorch.so(+0x1c5e1c0)[0x7f603e1241c0] /opt/conda/lib/python3.6/site-packages/torch/lib/libtorch.so(_ZN2at6native5zerosEN3c108ArrayRefIlEERKNS1_13TensorOptio nsE+0x25)[0x7f603e12dea5] /opt/conda/lib/python3.6/site-packages/torch/lib/libtorch.so(+0x1fa1a83)[0x7f603e467a83] /opt/conda/lib/python3.6/site-packages/torch/lib/libtorch.so(+0x3d912ce)[0x7f60402572ce] /opt/conda/lib/python3.6/site-packages/torch/lib/libtorch.so(+0x1fe5819)[0x7f603e4ab819] /opt/conda/lib/python3.6/site-packages/torch/lib/libtorch.so(+0x37c6c3b)[0x7f603fc8cc3b] /opt/conda/lib/python3.6/site-packages/torch/lib/libtorch.so(_ZN5torch8autograd9generated13SliceBackward5applyEOSt6vec torIN2at6TensorESaIS5_EE+0x111)[0x7f603fc8f6e1] /opt/conda/lib/python3.6/site-packages/torch/lib/libtorch.so(+0x3fb3106)[0x7f6040479106] /opt/conda/lib/python3.6/site-packages/torch/lib/libtorch.so(_ZN5torch8autograd6Engine17evaluate_functionERSt10shared_ ptrINS0_9GraphTaskEEPNS0_4NodeERNS0_11InputBufferE+0x1373)[0x7f6040475563] /opt/conda/lib/python3.6/site-packages/torch/lib/libtorch.so(_ZN5torch8autograd6Engine11thread_mainERKSt10shared_ptrIN S0_9GraphTaskEEb+0x4b2)[0x7f6040476192] /opt/conda/lib/python3.6/site-packages/torch/lib/libtorch.so(_ZN5torch8autograd6Engine11thread_initEi+0x39)[0x7f604046 fa89] /opt/conda/lib/python3.6/site-packages/torch/lib/libtorch_python.so(_ZN5torch8autograd6python12PythonEngine11thread_in itEi+0x2a)[0x7f60851f7dea] /opt/conda/lib/python3.6/site-packages/torch/_C.cpython-36m-x86_64-linux-gnu.so(+0xedef)[0x7f6085e21def] /lib/x86_64-linux-gnu/libpthread.so.0(+0x76ba)[0x7f6094ebc6ba] /lib/x86_64-linux-gnu/libc.so.6(clone+0x6d)[0x7f6094bf241d] ``` ## Expected behavior Train normaly, and save the model ## Environment PyTorch version: 1.4.0+cu100 Is debug build: No CUDA used to build PyTorch: 10.0 OS: Ubuntu 16.04.5 LTS GCC version: (Ubuntu 5.4.0-6ubuntu1~16.04.11) 5.4.0 20160609 CMake version: Could not collect Python version: 3.6 Is CUDA available: Yes CUDA runtime version: Could not collect GPU models and configuration: GPU 0: Tesla V100-PCIE-32GB GPU 1: Tesla V100-PCIE-32GB Nvidia driver version: 410.79 cuDNN version: Could not collect Versions of relevant libraries: [pip] numpy==1.15.4 [pip] numpydoc==0.9.2 [pip] pytorch-pretrained-bert==0.6.2 [pip] pytorch-transformers==1.1.0 [pip] torch==1.4.0+cu100 [pip] torchcontrib==0.0.2 [pip] torchfile==0.1.0 [pip] torchtext==0.4.0 [pip] torchvision==0.5.0+cu100 [conda] blas 1.0 mkl [conda] mkl 2019.1 144 [conda] mkl_fft 1.0.10 py36ha843d7b_0 [conda] mkl_random 1.0.2 py36hd81dba3_0 [conda] pytorch-pretrained-bert 0.6.2 pypi_0 pypi [conda] pytorch-transformers 1.1.0 pypi_0 pypi [conda] torch 1.4.0+cu100 pypi_0 pypi [conda] torchcontrib 0.0.2 pypi_0 pypi [conda] torchfile 0.1.0 pypi_0 pypi [conda] torchtext 0.4.0 pypi_0 pypi [conda] torchvision 0.5.0+cu100 pypi_0 pypi ## Additional context <!-- Add any other context about the problem here. -->
triaged,module: data parallel
low
Critical
565,354,605
vscode
Support tmux control mode (-CC flag)
Issue Type: <b>Feature Request</b> I saw the suggestion from @roblourens to use tmux in microsoft/vscode-remote-release#1185 That's mostly good, however has a few issues: - `code` command doesn't work inside tmux. - no GUI support - the built-in tab management and split panes then aren't usable. - scrolling doesn't work (control codes not sent to the terminal?) I'd love to see support for tmux's control mode (tmux -CC) - then vscode could use its native tab/window management and sessions would be persisted between app opens/closes. Extension version: 0.36.0 VS Code version: Code - Insiders 1.34.0-insider (daf71423252a707b8e396e8afa8102b717f8213b, 2019-05-06T22:07:35.830Z) OS version: Darwin x64 18.7.0 Remote OS version: Linux x64 5.2.17-1rodete3-amd64 <!-- generated by issue reporter -->
feature-request,terminal-persistence,terminal-input
high
Critical
565,375,135
vue
Hydration fails when write like "<div><span>123</span>{{value}}</div>" in the template and the data "value" is a empty string
### Version 2.6.11 ### Reproduction link [https://codepen.io/deqwin/pen/wvaMxoO](https://codepen.io/deqwin/pen/wvaMxoO) ### Steps to reproduce open the reproduction above and you will see a red vue warning in the console ### What is expected? a successful hydration ### What is actually happening? the hydration fails and the app re-renders absolutely --- this looks like the problem caused by the empty text node (src/core/vdom/patch.js line:646) <!-- generated by vue-issues. DO NOT REMOVE -->
bug,has PR,feat:ssr
low
Minor
565,424,441
rust
Trait bounds were not satisfied
I'm not sure if this is a compiler bug, but since I didn't get any answers on StackOverflow I'd try to add an issue here. I tried this code: ```rust use futures_util::compat::Future01CompatExt; use gluon::{ new_vm, vm::api::{FunctionRef, Getable, Pushable, VmType}, ThreadExt, }; pub type Error = gluon::Error; pub struct Script<'vm, 'value, In, Out> where In: VmType + Pushable<'vm>, Out: VmType + Getable<'vm, 'value> + Send + Sync, { vm: gluon::RootedThread, } impl<'vm, 'value, In, Out> Script<'vm, 'value, In, Out> where In: VmType + Pushable<'vm>, Out: VmType + Getable<'vm, 'value> + Send + Sync, { pub fn read(text: &str) -> Result<Script<In, Out>, Error> { let mut vm = new_vm(); vm.run_io(true); vm.load_script("main", text).map(|()| Script { vm: vm }) } pub async fn run(&mut self, input: &In) -> Result<Out, Error> { let func: FunctionRef<fn(In) -> Out> = self.vm.get_global("main")?; return func.call_async(input).compat().await; } } ``` As you can see I explicitly bound `In` and `Out` with the needed traits, but still get "trait bounds were not satisfied" error. `rustc --version --verbose`: ``` rustc 1.41.0 binary: rustc commit-hash: unknown commit-date: unknown host: x86_64-alpine-linux-musl release: 1.41.0 LLVM version: 9.0 ```
C-enhancement,A-diagnostics,A-lifetimes,T-compiler,E-needs-mcve
low
Critical
565,436,793
godot
Vulkan: Some MeshInstances that are children of a Skeleton are invisible; Were visible in 3.2
**Godot version:** Master Branch, Latest Commit: 282c8dda98ab4fae1f35fc4b796978950cb3c000 **OS/device including version:** Windows 10, Version 1909, 2020 Cumulative Update. GTX 1070 TI, 442.19 Drivers. **Issue description:** While checking if an import plugin of mine worked with 4.0, I noticed that MeshInstance nodes that are children of a skeleton node are usually invisible. I have not been able to determine why any given MeshInstance will be invisible or not. The import works perfectly in 3.2, but not in 4.0 (only script change was SpatialMaterial to StandardMaterial3D). I also confirmed that creating a new skeleton and adding a MeshInstance child would not display the MeshInstance, but that may be caused by the lack of bones in a new skeleton node. Saving the MeshInstance nodes as scenes shows that the Meshes and MeshInstances display properly without the Skeleton node. I have tried toggling settings in both the Meshes and their Material to no effect. I have found an exception to this rule in an imported file, but I was unable to determine what made it different from the other MeshInstances. I have attached my log file below. Please ignore the failed texture import errors, as they are not used by any assets in my project. I have also included two of the most frequent errors below. ``` ERROR: Condition "!F" is true. Continuing. at: RasterizerScene::InstanceBase::clean_up_dependencies (E:\Repositories\godot\servers/visual/rasterizer.h:185) - Condition "!F" is true. Continuing. ERROR: Condition "bs > sbs" is true. Continuing. at: RasterizerStorageRD::mesh_get_aabb (servers\visual\rasterizer_rd\rasterizer_storage_rd.cpp:2064) - Condition "bs > sbs" is true. Continuing. ``` [log-2020-02-14-10-52-39.txt](https://github.com/godotengine/godot/files/4205462/log-2020-02-14-10-52-39.txt) **Steps to reproduce:** Can be reproduced by adding a MeshInstance as a child of a skeleton, but the error there may be due to the skeleton having no bones instead of the above issue. **Minimal reproduction project:** [Invisible Mesh Demonstration.zip](https://github.com/godotengine/godot/files/4205489/Invisible.Mesh.Demonstration.zip) Example of import in Godot 3.2: ![3 2Import](https://user-images.githubusercontent.com/59899175/74548667-4ac00c00-4f1c-11ea-9d60-6acb8f594283.PNG)
bug,topic:rendering,confirmed,topic:3d
low
Critical
565,437,525
go
cmd/go: behavior of go list ... is not documented in module mode
`go help packages` documents the special path `all` both for *gopath* and *module* mode: ``` "all" expands to all packages found in all the GOPATH trees. For example, 'go list all' lists all the packages on the local system. When using modules, "all" expands to all packages in the main module and their dependencies, including dependencies needed by tests of any of those. ``` However the `...` pattern is documented only for *gopath* module: ``` An import path is a pattern if it includes one or more "..." wildcards, each of which can match any string, including the empty string and strings containing slashes. Such a pattern expands to all package directories found in the GOPATH trees with names matching the patterns. ``` How is the `...` pattern supposed to work in *module* mode? As a test, I ran `go list ... | wc -l ` inside the `github.com/golang/mod` (`golang.org/x/mod`) directory with different versions of the *go* tool. The directory is outside GOPATH. The results are: - `go1.11.13`: 501 - `go1.12.16`: 526 - `go1.13.8`: 632 - `go1.14rc1`: 634 As a side note, how can I tell `go list` to list **only** packages in the *main* module?
Documentation,NeedsInvestigation,GoCommand,modules
medium
Major
565,452,333
terminal
Minor artifacts on characters when using custom display scaling (like 130%)
<!-- 🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨 I ACKNOWLEDGE THE FOLLOWING BEFORE PROCEEDING: 1. If I delete this entire template and go my own path, the core team may close my issue without further explanation or engagement. 2. If I list multiple bugs/concerns in this one issue, the core team may close my issue without further explanation or engagement. 3. If I write an issue that has many duplicates, the core team may close my issue without further explanation or engagement (and without necessarily spending time to find the exact duplicate ID number). 4. If I leave the title incomplete when filing the issue, the core team may close my issue without further explanation or engagement. 5. If I file something completely blank in the body, the core team may close my issue without further explanation or engagement. All good? Then proceed! --> <!-- This bug tracker is monitored by Windows Terminal development team and other technical folks. **Important: When reporting BSODs or security issues, DO NOT attach memory dumps, logs, or traces to Github issues**. Instead, send dumps/traces to [email protected], referencing this GitHub issue. If this is an application crash, please also provide a Feedback Hub submission link so we can find your diagnostic data on the backend. Use the category "Apps > Windows Terminal (Preview)" and choose "Share My Feedback" after submission to get the link. Please use this form and describe your issue, concisely but precisely, with as much detail as possible. --> # Environment ```none Windows build number: [run `[Environment]::OSVersion` for powershell, or `ver` for cmd] Windows Terminal version (if applicable): Any other software? ``` Microsoft Windows NT 10.0.18362.0 Windows Terminal (Preview) Version: 0.9.433.0 # Steps to reproduce <!-- A description of how to trigger this bug. --> * set display scaling to some custom setting. I use 130% * launch Windows Terminal # Expected behavior fonts are scaled together with the rest of the system <!-- A description of what you're expecting, possibly containing screenshots or reference material. --> # Actual behavior fonts are scaled weirdly with wrong size and visible artefacts compare those screenshots. 1. regular Windows console using Consolas 16pt. everything's fine here <img src="https://ch3301files.storage.live.com/y4mvQqK8lX12c92wD2yKl8AWFCR4-OiImP9YaP5lHtm_4Ch-8VF1auHa30RaN7Zf37o13Co0qLbQ1cLcfSyHy5HI_mZgjDAD4oXJDdXMWUDsBC35Se2RnLgVndI_fX3GDyXD4BWmI68MDglG73nB6Izn4ZhkSyc2xHCMsVJPKCxbFQqwmD0-P0dtvly_I_XRZ7Vmept7qQXhOkvbo29JWEMVg/powershell.png?psid=1&width=822&height=166"> 2. Windows Terminal using Consolas 16pt. somehow this 16pt is much larger <img src="https://ch3301files.storage.live.com/y4mRt95zvzlVTVU1ssdoIhMNddwaRCKxr934xZ-_H3xDAcKCfdjg7HdysSwr2l2r_Ma3hpzT1Bci4o5gubOo8WzZCaHoC3GC9uEYcWOTBN1voN902x53KxRTieEHP1TrzSihUah8TB45lHH0L0skr6HbwTD7fHZMo4bmBCnLtcQLBT3KtzOq5O53bCFVwu_EQiPabpnAb95c99_hH705ooThA/wt16.png?psid=1&width=1274&height=257"> 3. Windows Terminal using Consolas 11 pt (almost matches size in Windows console). notice broken fonts <img src="https://ch3301files.storage.live.com/y4mFizZJYEVbhkeV8exgekvRcxudjIsm4JCT96bj-1NSkcgSSiRXoVccsmShMyPFeCQYMzxP0xMy7YHRVzFZ_25g74KefwoZFUHzgCiu9rRTzenhwPPTO1abAU-zvzXuqwX6CyG1vXNRDch5Mni4-rGCNg8p5np3AGtDkVZjctGFjwEspM3j_dABLpMDgzd9VdZPFfiItFantyjDE_w5JMw2g/wt11.png?psid=1&width=856&height=191"> font rendering has visible artifacts on almost all letters, very notable on `Ρ‰`, `ΠΉ`, `Π·`, `Π±`, `Ρ€`, `Ρ‡` and even English `a` and `e`. the screenshot is a lossless PNG, that's how Windows Terminal display those in real life. <!-- What's actually happening? -->
Area-Rendering,Area-Fonts,Issue-Bug,Product-Terminal,Priority-3
medium
Critical
565,453,186
flutter
Testing a MultiFrameImageStreamCompleter is really hard.
Nearly all of our image related tests right now use a SingleFrame completer or otherwise mock out the completion. If a user wants to actually test using a MultiFrame completer, it generally just doesn't work, I believe because of a mix of real and fake async work. It would be nice to make this a better testing experience, and in particular to allow a test to drive the completer to a specific frame for golden testing - for example, to do testing of a widget that displays a multi-frame gif. /cc @jamesderlin
a: tests,c: new feature,framework,a: images,P3,team-framework,triaged-framework
low
Minor
565,453,343
flutter
Feature request: Add a flag to `flutter run` & `flutter logs` to filter output
After https://github.com/flutter/flutter/pull/45743, we stopped filtering log output (by the string `flutter` both because it broke benchmark tasks and because it obscured when the app crashed. The downside is that the logs are much noisier. This should be configurable by a flag. For more context, see: https://github.com/flutter/flutter/issues/50628
platform-android,tool,P3,team-android,triaged-android
medium
Critical
565,481,813
TypeScript
Provide type coverage metrics
<!-- 🚨 STOP 🚨 𝗦𝗧𝗒𝗣 🚨 𝑺𝑻𝑢𝑷 🚨 Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Please help us by doing the following steps before logging an issue: * Search: https://github.com/Microsoft/TypeScript/search?type=Issues * Read the FAQ, especially the "Common Feature Requests" section: https://github.com/Microsoft/TypeScript/wiki/FAQ --> ## Search Terms - type coverage - flow coverage <!-- List of keywords you searched for before creating this issue. Write them down here so that others can find this suggestion more easily --> ## Suggestion I'd love it if TypeScript had a tool to capture type coverage metrics, similar to Flow's [Type Coverage](https://flow.org/en/docs/cli/coverage/) feature. That coverage data could be used by IDEs (again, currently supported by Flow) to highlight gaps in type coverage. Basically, it should tell us which parts of our code are being evaluated as `any`. Assuming it would work like Flow's feature, this could be a separate `tsc` option or separate cli command. Theirs works for single files and also offers a `batch-coverage` command for checking directories / whole projects, etc. <!-- A summary of what you'd like to see added or changed --> ## Use Cases - The Type Coverage metric could be used much like test coverage info, helping us to identify gaps in our typing (particularly unexpected gaps caused by insufficient type definitions from library code). <!-- What do you want to use this for? What shortcomings exist with current approaches? --> ## Examples <!-- Show how this would be used and what the behavior would be --> ## Checklist My suggestion meets these guidelines: * [x] This wouldn't be a breaking change in existing TypeScript/JavaScript code * [x] This wouldn't change the runtime behavior of existing JavaScript code * [x] This could be implemented without emitting different JS based on the types of the expressions * [x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.) * [x] This feature would agree with the rest of [TypeScript's Design Goals](https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals).
Suggestion,Awaiting More Feedback
low
Critical
565,486,984
flutter
Make E2E use a custom test reporter so that invoking test() will work.
Invoking test() won't result in failures being reported. We could address this with either 1. Improving documentation 1. Do something clever with with imports (Dart provides mechanisms for hiding, showing, and aliasing of symbols) to get an app-facing test method that wraps testWidgets without causing compile errors. 1. Hook into package:test instead of package:flutter_test at a different layer.
a: tests,framework,d: api docs,f: integration_test,P2,team-framework,triaged-framework
low
Critical
565,504,985
flutter
Update e2e and espresso plugin docs to require using dependency instead of dev_dependency
See discussion on https://github.com/flutter/flutter/pull/45816 If we aren't registering plugins coming from dev_dependency, we'll have to use dependency. I think this won't be a huge issue since it should only be a dependency for the example app. We should also update the plugins' versions to 1.0.0 with this change because it increases the potential for version conflicts and it will be hard to make a breaking update to 1.0 going forward.
a: tests,framework,d: api docs,f: integration_test,P2,p: espresso,team-framework,triaged-framework
low
Minor
565,505,957
opencv
Failing tests for Split layer (IE)
<!-- If you have a question rather than reporting a bug please go to http://answers.opencv.org where you get much faster responses. If you need further assistance please read [How To Contribute](https://github.com/opencv/opencv/wiki/How_to_contribute). Please: * Read the documentation to test with the latest developer build. * Check if other person has already created the same issue to avoid duplicates. You can comment on it if there already is an issue. * Try to be as detailed as possible in your report. * Report only one problem per created issue. This is a template helping you to create an issue which can be processed as quickly as possible. This is the bug reporting section for the OpenCV library. --> This issue aims to fix the tests which are failing for `split` layer in ONNXImporter. The problem was discovered while working on https://github.com/opencv/opencv/pull/16424 Specifically see, https://github.com/opencv/opencv/pull/16424#issuecomment-585985320 Please comment more such failing tests if you come across any. ##### System information (version) <!-- Example - OpenCV => 3.1 - Operating System / Platform => Windows 64 Bit - Compiler => Visual Studio 2015 --> - OpenCV => :grey_question: - Operating System / Platform => :grey_question: - Compiler => :grey_question: ##### Detailed description <!-- your description --> ##### Steps to reproduce <!-- to add code example fence it with triple backticks and optional file extension ```.cpp // C++ code example ``` or attach as .txt or .zip file -->
category: dnn
low
Critical
565,517,326
pytorch
[jit] `Node` callstack is incorrect
After applying #33352, ```python import torch import torch.nn as nn import pprint class MyNet(nn.Module): def __init__(self): super(MyNet, self).__init__() self.conv = nn.Conv2d(1, 6, 5, 1, 2) self.maxpool = nn.MaxPool2d(2, 2) def forward(self, x): x = self.conv(x) x = self.maxpool(x) return x model = MyNet() torch._C._jit_set_inline_everything_mode(True) script = torch.jit.script(model) for node in script.graph.nodes(): if node.kind() == "aten::conv2d": pprint.pprint(node.callstack()) ``` outputs ``` ['__torch__.torch.nn.modules.pooling.MaxPool2d.forward', '__torch__.torch.nn.modules.conv.Conv2d.forward', '__torch__.torch.nn.modules.conv.Conv2d._conv_forward'] ``` which includes `MaxPool2d.forward` but probably shouldn't cc @suo
oncall: jit,triaged
low
Minor