id
int64 393k
2.82B
| repo
stringclasses 68
values | title
stringlengths 1
936
| body
stringlengths 0
256k
β | labels
stringlengths 2
508
| priority
stringclasses 3
values | severity
stringclasses 3
values |
|---|---|---|---|---|---|---|
561,580,522 | rust | Coroutines should be able to implement `for<'a> Coroutine<&'a mut T>` | With https://github.com/rust-lang/rust/pull/68524, the `Coroutine` trait has gained a type parameter for the resume argument. Currently, this parameter will not be inferred to a type with late-bound regions. In some cases, this is required for soundness. For example, this coroutine stores the resume argument across a `yield`, which means that it can not accept arbitrary lifetimes in it:
```rust
let coro = |arg: &mut bool| {
yield ();
*arg = true;
};
```
This coroutine ends up implementing `Coroutine<&'x mut bool>` with a specific `'x`, not `for<'x> Generator<&'x mut bool>`.
However, if the resume argument *doesn't* get stored inside the generator state, it should be fine for the coroutine to implement `for<'x> Coroutine<&'x mut bool>` instead.
This is already how closures behave, since they can also store their arguments inside upvars, so it shouldn't be terribly difficult to extend this to coroutines. It would be good to come up with lots of test cases beforehand though (perhaps inspired by the tests for closures). | C-enhancement,T-compiler,A-coroutines,F-coroutines | medium | Critical |
561,591,031 | rust | Different NaN types on mipsel and mips64el than on most other architectures | The following tests fail on mipsel and mips64el architectures while succeeding most others.
```rust
#[cfg(test)]
mod tests {
#[test]
fn min() {
assert_eq!(1f64.min(std::f64::NAN), 1f64);
}
#[test]
fn max() {
assert_eq!(1f64.max(std::f64::NAN), 1f64);
}
}
```
It succeeded on mipsel up to stable 1.36.0 rustc, and started failing in 1.37.0 and newer. I'll attempt to use [cargo-bisect-rustc](https://github.com/rust-lang/cargo-bisect-rustc) track down the exact nightly version that introduced the change (might take some time because it's a qemu vm that is rather slow).
https://github.com/rust-lang/rust/issues/52897#issuecomment-582514493 was where the initial discussion started, but it seems to be worth a separate issue instead of creating noise there.
It looks as if the failing platforms have a signaling NAN (sNAN) in opposite to the succeeding ones with a quiet NAN (qNAN). | O-MIPS,T-libs-api,T-compiler,C-bug | low | Major |
561,605,419 | godot | Godot Standard version crashes when opening project created with Godot Mono version. | **Godot version:** 3.2 Standard
**OS/device including version:** Ubuntu 19.10
**Issue description:** When opening a project using Godot Standard version that contains a C# script that listens to a signal, Godot crashes.
Specifically, there is a null pointer dereference, because the `Ref<Script>(script)->` operator returns a null pointer when called here:
https://github.com/godotengine/godot/blob/00f46452b0206afe6aca79b0c4cd4a205f99067b/core/object.cpp#L1439
It returns a null pointer, because when trying to cast the script object pointer to a `Script` pointer here:
https://github.com/godotengine/godot/blob/00f46452b0206afe6aca79b0c4cd4a205f99067b/core/object.h#L598-L610
In the Standard version, the C# script object is a `TextFile`, which is not derived from `Script`. In the Mono version, the C# script object is a `CSharpScript`, which is derived from `Script`. Therefore, in the Standard version, `dynamic_cast<Script *>()` returns a null pointer.
**Steps to reproduce:** Use Godot Mono version to create a project with a C# script that connects to a signal. Open the project with Godot Standard version.
**Expected behaviour:** Warn the user that the project is a Mono project and cannot be edited with Godot Standard version.
**Minimal reproduction project:**
[Crash CSharp Script.zip](https://github.com/godotengine/godot/files/4170702/Crash.CSharp.Script.zip)
| bug,topic:core,crash | low | Critical |
561,638,527 | tensorflow | tf.data.Dataset unusable with steps_per_epoch standard training loop | **System information**
- Have I written custom code (as opposed to using a stock example script provided in TensorFlow): No
- OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Linux Mint
- TensorFlow installed from (source or binary): binary
- TensorFlow version (use command below): 2.1.0
- Python version: 3.7.4
**Describe the current behavior**
This is the underlying issue for https://github.com/tensorflow/tensorflow/issues/36153
Basically:
- `Dataset` can be used as/converted to an iterator
- Once the iterator reaches the end of the dataset it does not restart -> Yields no more samples
- `steps_per_epoch` for the `fit` method of a keras model can be used to specify the number of batches to run per epoch, more exactly: The number of times the iterator is advanced/dereferenced
- `steps_per_epoch` is required for e.g. if not the full dataset should be traversed. Either due to external requirements or to avoid using the trailing (incomplete) batch.
- `steps_per_epoch` is absolutely required to be set for `MultiWorkerMirroredStrategy`: https://www.tensorflow.org/tutorials/distribute/multi_worker_with_keras#train_the_model_with_multiworkermirroredstrategy
- Whether to recreate an iterator for each epoch out of the dataset is determined by `DatasetAdapter.should_recreate_iterator` at https://github.com/tensorflow/tensorflow/blob/v2.1.0/tensorflow/python/keras/engine/training_v2.py#L241-L242
- Note that the iterator absolutely must be recreated for all common use cases:
- Iterate over full dataset
- Iterate over full dataset except incomplete trailing batch
- Iterate over a random subset of the full dataset per epoch
- Not to be recreated for: Infinite datasets. **Maybe** If the full dataset should be consumed over multiple epochs. But why? What should happen if the dataset is exhausted after some epoch? Usually restart, right?
In the current TF (2.1.0) the implementation of `DatasetAdapter.should_recreate_iterator` is: `return self.get_size() is not None or steps_per_epoch is None`: https://github.com/tensorflow/tensorflow/blob/v2.1.0/tensorflow/python/keras/engine/data_adapter.py#L208
This is **wrong**. For datasets the size is always None (see https://github.com/tensorflow/tensorflow/issues/36531 which intends for this to be changed) and as motivated above having `steps_per_epoch` set is a common use case but the iterator should still be recreated on each epoch.
This was recently changed to ` (self._user_steps is None or cardinality.cardinality(self._dataset).numpy() == self._user_steps)` https://github.com/tensorflow/tensorflow/commit/6be131d0860559954c42685a87c63f16cebb2185#diff-f8dd40712ac721c1b363e1a1ec44c1a3R741-R747
This is also **wrong**. Again assume `_user_steps` is set (see above reasoning): First the `cardinality` might be unknown, e.g. for any TFDS dataset (and `TFRecordDataset`) it is unknown. I guess due to use of `interleave` in the dataset reader. Second even if the size was known it may not be equal to the number of steps. Common example: Skipping the last batch.
**Describe the expected behavior**
This is a design issue and hence hard to resolve.
In general it would be best to eliminate the UNKNOWN size of a dataset. But when reading data line-by-line from a file it might not be known upfront. So the user has to input the size of the dataset or specify explicitly `AUTO` which would iterate over the whole dataset once to get the number of samples. This can be costly but should not be possible in general (e.g. TFDS knows the number of samples)
I think the sanest approach would be to default to recreating the iterator on each epoch UNLESS the dataset is known to be infinite. This might still be wrong for cases I can't imagine right now but is correct for all cases I can think of. Maybe even allow the user to specify this, but this default is IMO way better than the current.
The other approach would be to recreate the iterator when it runs out of data after starting an epoch. This would partially solve the issue, but fails for:
- Omitting the trailing batch: It would yield the incomplete batch from the last epoch first, but that should be skipped.
- Using only some random samples per batch but wanting to shuffle before each batch: It would happily consume the rest of the samples and not see the samples used in an earlier epoch until it runs out of data
With the UNKNOWN size fixed, one could also fix the check at https://github.com/tensorflow/tensorflow/commit/6be131d0860559954c42685a87c63f16cebb2185#diff-f8dd40712ac721c1b363e1a1ec44c1a3R741-R747 to check if `_user_steps` yields 1 epoch (and optional trailing batches) by using `size // steps == 1` which would be better than the previous approach (recreate iterator when out of data) as the use case with of Omitting the trailing batch is covered. But it would fail for the other.
So my suggestion would to
- (optional) avoid UNKNOWN sizes
- recreate iterators unless dataset is infinite by default
- allow the user to overwrite this explicitly, maybe via `with_options` of the dataset
**Code to reproduce the issue**
Some reduced example code based on e.g. https://www.tensorflow.org/tutorials/distribute/multi_worker_with_keras#train_the_model_with_multiworkermirroredstrategy
```
import tensorflow as tf
import tensorflow_datasets as tfds
import tensorflow as tf
from tensorflow.python.data.experimental.ops import cardinality
import numpy as np
tfds.disable_progress_bar()
# Scaling MNIST data from (0, 255] to (0., 1.]
def scale(image, label):
image = tf.cast(image, tf.float32)
image /= 255
return image, label
def build_and_compile_cnn_model():
model = tf.keras.Sequential([
tf.keras.layers.Conv2D(32,
3,
activation='relu',
input_shape=(28, 28, 1)),
tf.keras.layers.MaxPooling2D(),
tf.keras.layers.Flatten(),
tf.keras.layers.Dense(64, activation='relu'),
tf.keras.layers.Dense(10, activation='softmax')
])
model.compile(loss=tf.keras.losses.sparse_categorical_crossentropy,
optimizer=tf.keras.optimizers.SGD(learning_rate=0.001),
metrics=['accuracy'])
return model
BATCH_SIZE = 64
if False:
examples = np.ones([10*BATCH_SIZE,28,28,1])
labels = np.ones([examples.shape[0]])
dataset = tf.data.Dataset.from_tensor_slices((examples, labels))
num_examples = examples.shape[0]
else:
datasets, info = tfds.load(name='mnist', with_info=True, as_supervised=True)
dataset = datasets['test']
num_examples = info.splits['test'].num_examples
x = dataset.map(scale).cache().shuffle(10000).batch(BATCH_SIZE)
model = build_and_compile_cnn_model()
card = cardinality.cardinality(x)
num_batches = sum(1 for _ in x)
full_batches = num_examples // BATCH_SIZE
print("Samples: %s\nBatches: %s (%s full)\nCardinality: %s" % (num_examples, num_batches, full_batches, card))
model.fit(x=x, epochs=2, steps_per_epoch=full_batches)
```
**Other info / logs**
There is a warning:
> WARNING:tensorflow:Your input ran out of data; interrupting training. Make sure that your dataset or generator can generate at least `steps_per_epoch * epochs` batches (in this case, 312 batches). You may need to use the repeat() function when building your dataset.
It seems that adding `repeat()` and hence creating an infinite dataset is a viable option. However the docu also states
> In TF 1.X, the idiomatic way to create epochs was through the `repeat` transformation:
> In TF 2.0, `tf.data.Dataset` objects are Python iterables which makes it possible to also create epochs through Python iteration:
So it seems that it should not be required and as per above explanation the return value of `DatasetAdapter.should_recreate_iterator` is not correct. | stat:awaiting tensorflower,type:bug,comp:data,TF 2.10 | medium | Major |
561,650,019 | pytorch | F.max_pool*d/F.min_pool*d should support integer dtypes and bool tensors | max_pool and min_pool are dilation and erosion operations which can be convenient in postprocessing, so binary masks input can happen in practice
Error: `RuntimeError: "max_pool2d_with_indices_out_cuda_frame" not implemented for 'Int'`
cc @heitorschueroff | triaged,module: pooling,function request | low | Critical |
561,660,726 | vscode | Explore line-end-rendering of code lenses | This is about exploring to render code lenses not interleaved with source text but at the end line source lines. The reasoning is that it might impact code structure less but at the cost of discoverability, e.g with long lines code lens won't be visible by default. This is an exploration with unknown outcome and any result will surely be configurable so that existing behaviour can be kept the way it is today. | feature-request,code-lens | medium | Critical |
561,666,546 | vue | $http.delete shows warning "avoid using JavaScript unary operator as property name" | ### Version
2.6.11
### Reproduction link
[https://codepen.io/frOracle/pen/vYOEEVW](https://codepen.io/frOracle/pen/vYOEEVW)
### Steps to reproduce
use $http.delete in @click
### What is expected?
$http.delete is a function, not unary operator
### What is actually happening?
a warning "avoid using JavaScript unary operator as property name"
---
Related https://github.com/vuejs/vue/issues/5464
<!-- generated by vue-issues. DO NOT REMOVE --> | improvement,has workaround,warnings,feat:compiler | low | Minor |
561,676,405 | rust | Confusing additional warnings when hitting bindings_with_variant_name | We're working through a Rust training from Ferrous at my company and one of my colleagues wrote some code that hit the `bindings_with_variant_name` warning. A reduced testcase looks like ([on playground](https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=56cdb3e0474225c306c8a1ccd1272e3c)):
```rust
pub enum E {
One,
Two,
}
pub fn f(e: E) -> u32 {
match e {
One => 1,
Two => 2,
}
}
```
If you build this code you get the good `bindings_with_variant_name` warnings and then a slew of other warnings. My colleague got lost in the sea of warnings and didn't notice the ones at the top that explained the problem directly:
```
Compiling playground v0.0.1 (/playground)
warning[E0170]: pattern binding `One` is named the same as one of the variants of the type `E`
--> src/lib.rs:8:9
|
8 | One => 1,
| ^^^ help: to match on the variant, qualify the path: `E::One`
|
= note: `#[warn(bindings_with_variant_name)]` on by default
warning[E0170]: pattern binding `Two` is named the same as one of the variants of the type `E`
--> src/lib.rs:9:9
|
9 | Two => 2,
| ^^^ help: to match on the variant, qualify the path: `E::Two`
warning: unreachable pattern
--> src/lib.rs:9:9
|
8 | One => 1,
| --- matches any value
9 | Two => 2,
| ^^^ unreachable pattern
|
= note: `#[warn(unreachable_patterns)]` on by default
warning: unused variable: `One`
--> src/lib.rs:8:9
|
8 | One => 1,
| ^^^ help: consider prefixing with an underscore: `_One`
|
= note: `#[warn(unused_variables)]` on by default
warning: unused variable: `Two`
--> src/lib.rs:9:9
|
9 | Two => 2,
| ^^^ help: consider prefixing with an underscore: `_Two`
warning: variable `One` should have a snake case name
--> src/lib.rs:8:9
|
8 | One => 1,
| ^^^ help: convert the identifier to snake case (notice the capitalization): `one`
|
= note: `#[warn(non_snake_case)]` on by default
warning: variable `Two` should have a snake case name
--> src/lib.rs:9:9
|
9 | Two => 2,
| ^^^ help: convert the identifier to snake case: `two`
Finished dev [unoptimized + debuginfo] target(s) in 0.55s
```
It'd be great if we could suppress those latter warnings in this case since we've already told the user what the exact problem is.
cc @estebank @skade | C-enhancement,A-diagnostics,T-compiler | low | Critical |
561,710,779 | pytorch | test_baddbmm_cpu_float32 fails locally for me when built with DEBUG=1 | ```
======================================================================
FAIL: test_baddbmm_cpu_float32 (__main__.TestTorchDeviceTypeCPU)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/data/users/ezyang/pytorch-tmp/torch/testing/_internal/common_device_type.py", line 197, in instantiated_test
result = test(self, device_arg, dtype)
File "/data/users/ezyang/pytorch-tmp/torch/testing/_internal/common_device_type.py", line 389, in only_fn
return fn(slf, device, *args, **kwargs)
File "test/test_torch.py", line 13558, in test_baddbmm
self.assertEqual(res4, res * 3)
File "/data/users/ezyang/pytorch-tmp/torch/testing/_internal/common_utils.py", line 862, in assertEqual
assertTensorsEqual(x, y)
File "/data/users/ezyang/pytorch-tmp/torch/testing/_internal/common_utils.py", line 832, in assertTensorsEqual
self.assertLessEqual(max_err, prec, message)
AssertionError: tensor(1.3351e-05) not less than or equal to 1e-05 :
----------------------------------------------------------------------
```
Version information:
```
Collecting environment information...
PyTorch version: 1.5.0a0+35b1486
Is debug build: Yes
CUDA used to build PyTorch: None
OS: CentOS Linux 7 (Core)
GCC version: (GCC) 7.3.1 20180303 (Red Hat 7.3.1-5)
CMake version: version 3.14.0
Python version: 3.8
Is CUDA available: No
CUDA runtime version: No CUDA
GPU models and configuration: No CUDA
Nvidia driver version: No CUDA
cuDNN version: No CUDA
Versions of relevant libraries:
[pip] numpy==1.17.4
[pip] torch==1.5.0a0+35b1486
[conda] blas 1.0 mkl
[conda] magma-cuda80 2.3.0 1 soumith
[conda] mkl 2019.4 243
[conda] mkl-service 2.3.0 py38he904b0f_0
[conda] mkl_fft 1.0.15 py38ha843d7b_0
[conda] mkl_random 1.1.0 py38h962f231_0
[conda] torch 1.5.0a0+35b1486 dev_0 <develop>
```
cc @ezyang @gchanan @zou3519 | module: tests,triaged,small | low | Critical |
561,734,397 | flutter | TabBar Ripple flows outside of tabs |
<img src="https://user-images.githubusercontent.com/22423754/74045476-d4d71480-49f2-11ea-840a-45fd539d4812.jpg" width="300" height="600" />
On tab press splash color show outside tab. It should be not show outside `ClipRRect`.
```dart
import 'package:flutter/cupertino.dart';
import 'package:flutter/material.dart';
import 'dart:ui';
import 'Widgets/CustomDrawer.dart';
void main() {
runApp(MainApp());
}
const Color primary = Color(0xffe93735);
const Color secondry = Color(0xffF7B6B5);
class MainApp extends StatelessWidget {
@override
Widget build(BuildContext context) {
// TODO: implement build
return MaterialApp(
theme: ThemeData(
primaryColor: Color(0xffe93735),
primaryColorDark: Color(0xffe93735),
primarySwatch: Colors.yellow,
accentColor: Color(0xffe93735),
iconTheme: IconThemeData(
color: Color(0xffe93735),
),
backgroundColor: Color(0xffeeeeee),
buttonTheme: ButtonThemeData(
buttonColor: Color(0xffe93735),
textTheme: ButtonTextTheme.accent),
floatingActionButtonTheme: FloatingActionButtonThemeData(
backgroundColor: Color(0xffe93735),
foregroundColor: Colors.white,
),
textTheme: TextTheme(
button: TextStyle(
color: Colors.green, // This is not working.
fontSize: 30.0))),
home: LandingPage(),
);
}
}
class LandingPage extends StatefulWidget {
@override
State<StatefulWidget> createState() {
// TODO: implement createState
return LandingPageState();
}
}
class LandingPageState extends State<LandingPage>
with SingleTickerProviderStateMixin {
String activeView = "MESSAGE";
TabController tabController;
changeActiveView(String active) {
setState(() {
activeView = active;
});
}
@override
void initState() {
// TODO: implement initState
super.initState();
tabController = TabController(length: 3, vsync: this);
}
@override
Widget build(BuildContext context) {
Size size = MediaQuery.of(context).size;
// TODO: implement build
return Scaffold(
backgroundColor: Colors.black,
drawer: Drawer(child: CustomDrawer(
onTap: (String value) {
changeActiveView(value);
Navigator.pop(context);
},
)),
appBar: AppBar(
title: Text("ΰͺ΅ΰͺΎΰͺ€ΰ«..."),
),
body: Stack(
children: <Widget>[
TabBarView(
controller: tabController,
children: <Widget>[
Container(
child: Text("Message"),
),
Container(
child: Text("Images"),
),
Container(
child: Text("Video"),
)
],
),
Positioned(
bottom: 20,
left: (size.width - (size.width/1.2)),
child: ClipRRect(
borderRadius: BorderRadius.circular(30),
child: Container(
height: 50,
width: MediaQuery.of(context).size.width/1.5,
color: Colors.white,
child: CustomTabView(controller: tabController,),
),
),
),
],
)
);
}
}
class CustomTabView extends StatelessWidget{
TabController controller;
CustomTabView({this.controller});
@override
Widget build(BuildContext context) {
// TODO: implement build
return ClipRRect(
borderRadius: BorderRadius.circular(30),
child: TabBar(
indicatorColor: Colors.transparent,
unselectedLabelColor: primary,
indicator: BoxDecoration(
color: primary,
borderRadius: BorderRadius.circular(30)
),
controller: controller,
tabs: <Widget>[
Tab(
child: Icon(Icons.chat),
),
Tab(
child: Icon(Icons.photo_library),
),
Tab(
child: Icon(Icons.video_library),
)
],
),
);
}
}
``` | framework,f: material design,a: quality,has reproducible steps,found in release: 3.3,found in release: 3.7,team-design,triaged-design | low | Major |
561,736,032 | material-ui | [Drawer] Mini variant with SwipableDrawer | There's an example in the [docs](https://material-ui.com/components/drawers/#mini-variant-drawer) on how to make a small drawer with only icons shown that can be expanded to its full width.
Super useful on small screens. Unfortunately, this doesn't seem possible to implement with SwipableDrawer.
- [x] I have searched the [issues](https://github.com/mui-org/material-ui/issues) of this repository and believe that this is not a duplicate.
## Summary π‘
If there was a way to keep the content of the swipable drawer in the dom when it's closed, then a similar example to that in the docs could be used.
## Motivation π¦
Mini drawers are useful on small screens. Small screens usually have touch capabilities so people naturally want to open/close drawers by swiping.
| new feature,component: drawer | low | Minor |
561,748,612 | rust | Borrow scope for pattern matches - again | This issue seems to be similar to [this one](https://stackoverflow.com/questions/23328702/rust-cannot-move-out-of-self-because-it-is-borrowed-error), but the referenced issue #6379, does not solve it:
[playground](https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=a80be0555b914552ed2071ebbf642610)
```rs
enum Either<A,B> {
Left(A),
Right(B)
}
enum Tree<'a, A, B> {
ALeaf(A),
BLeaf(B),
ABranch(&'a mut Tree<'a, A, B>, A),
BBranch(&'a mut Tree<'a, A, B>, B)
}
impl<'a, A: PartialOrd, B> Tree<'a, A ,B> {
fn deep_fetch(&mut self, value: Either<A, B>) -> Result<&mut Self, (&mut Self, Either<A,B>)> {
match (self, value) {
(Tree::ABranch(ref mut a, ref v), Either::Left(vv)) if v > &vv => {
a.deep_fetch(Either::Left(vv))
}
(this, _v) => Err((this, _v))
}
}
}
```
```
error[E0505]: cannot move out of `_` because it is borrowed
--> src/lib.rs:20:14
|
14 | fn deep_fetch(&mut self, value: Either<A, B>) -> Result<&mut Self, (&mut Self, Either<A,B>)> {
| - let's call the lifetime of this reference `'1`
15 | match (&mut *self, value) {
16 | (Tree::ABranch(ref mut a, ref v), Either::Left(vv)) if v > &vv => {
| --------- borrow of value occurs here
17 | a.deep_fetch(Either::Left(vv))
| ------------------------------ returning this value requires that borrow lasts for `'1`
...
20 | (this, _v) => Err((this, _v))
| ^^^^ move out of value occurs here
``` | A-borrow-checker,T-compiler,C-bug,fixed-by-polonius | low | Critical |
561,759,818 | go | x/tools/go/packages: loader doesn't handle/recognize "context canceled" error | <!--
Please answer these questions before submitting your issue. Thanks!
For questions please use one of our forums: https://github.com/golang/go/wiki/Questions
-->
### What version of Go are you using (`go version`)?
<pre>
$ go version
go version go1.13.7 linux/amd64
</pre>
### Does this issue reproduce with the latest release?
yes
### What operating system and processor architecture are you using (`go env`)?
<details><summary><code>go env</code> Output</summary><br><pre>
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/mm/.cache/go-build"
GOENV="/home/mm/.config/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/home/mm/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="/home/mm/go/src/github.com/mmirolim/gtr/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build542977077=/tmp/go-build -gno-record-gcc-switches"
</pre></details>
### What did you do?
I used packages.Load function with Config.Context set. If context canceled and packages.loader in loadPackage function, appendError prints "internal error" message
https://github.com/golang/tools/blob/master/go/packages/packages.go#L791
<!--
If possible, provide a recipe for reproducing the error.
A complete runnable program is good.
A link on play.golang.org is best.
-->
To reproduce error, we can inject delay in loader.loadRecursive/loadPackage function and
modify testParseFileModifyAST, set context to config, which will be canceled before delay in loader.
https://github.com/golang/tools/blob/master/go/packages/packages_test.go#L870
### What did you expect to see?
no error messages in stdout
### What did you see instead?
..... many lines of ...
2020/02/07 16:18:23 internal error: error "context canceled" (*errors.errorString) without position
.....
| NeedsInvestigation,Tools | low | Critical |
561,826,344 | TypeScript | TS Spec doesn't match implementation re method signature definitions | [TS Spec Β§ 3.9.5](https://github.com/Microsoft/TypeScript/blob/master/doc/spec.md#395-method-signatures) says:
> A method signature of the form
>```ts
> f < T1, T2, ... > ( p1, p2, ... ) : R
>```
>is equivalent to the property declaration
>```ts
>f : { < T1, T2, ... > ( p1, p2, ... ) : R }
>```
But this is not the case with `--strictFunctionTypes`:
```ts
interface IFoo1 {
bar(baz?: number): void
}
class Foo1 implements IFoo1 {
bar: (baz: number) => void = (n) => void 0;
}
interface IFoo2 {
bar: { (baz?: number): void }
}
class Foo2 implements IFoo2 {
bar: (baz: number) => void = (n) => void 0; // err: Property 'bar' in type 'Foo2' is not assignable to the same property in base type 'IFoo2'.
}
```
I understand that the method bivarience in general is intentional as per the [PR](https://github.com/Microsoft/TypeScript/pull/18654):
>With this PR we introduce a --strictFunctionTypes mode in which function type parameter positions are checked contravariantly instead of bivariantly. *The stricter checking applies to all function types, except those originating in method or construcor declarations*
But it would be nice if the spec didn't state the syntaxes were equivalent when they aren't. | Docs | low | Major |
561,833,350 | TypeScript | Default values for jsconfig.json override extended values | **TypeScript Version:** 3.8.0-dev.20200207
**Search Terms:** jsconfig extend override defaults
**Code**
```jsonc
// a/jsconfig.json
{
"files": ["test.js"],
"compilerOptions": {
"maxNodeModuleJsDepth": 0
}
}
```
```jsonc
// b/jsconfig.json
{
"extends": "../a/jsconfig.json"
}
```
```javascript
// a/test.js
console.log("hello");
```
**Reproduce**
```bash
mkdir -p a b
echo '{"files":["test.js"],"compilerOptions":{"maxNodeModuleJsDepth":0}}' > a/jsconfig.json
echo '{"extends":"../a/jsconfig.json"}' > b/jsconfig.json
echo 'console.log("hello");' > a/test.js
```
```bash
npx tsc -p a/jsconfig.json --showConfig
npx tsc -p b/jsconfig.json --showConfig
```
**Expected behavior:**
Both implied configs A and B have `compilerOptions.maxNodeModuleJsDepth: 0`.
**Actual behavior:**
Implied config A has `compilerOptions.maxNodeModuleJsDepth: 0`.
Implied config B has `compilerOptions.maxNodeModuleJsDepth: 2`.
Output:
```json
{
"compilerOptions": {
"allowJs": true,
"maxNodeModuleJsDepth": 0,
"allowSyntheticDefaultImports": true,
"skipLibCheck": true,
"noEmit": true
},
"files": [
"./test.js"
]
}
{
"compilerOptions": {
"allowJs": true,
"maxNodeModuleJsDepth": 2,
"allowSyntheticDefaultImports": true,
"skipLibCheck": true,
"noEmit": true
},
"files": [
"../a/test.js"
]
}
```
Implied config B has `maxNodeModuleJsDepth: 2` despite it extending config A which explicitly sets `maxNodeModuleJsDepth: 0`.
**Possible cause**
This may be caused by the default values for config files named `jsconfig.json` overriding the values from the extended config. `maxNodeModuleJsDepth: 2` is one of the default values. See: [/src/compiler/commandLineParser.ts#L2459](https://github.com/microsoft/TypeScript/blob/master/src/compiler/commandLineParser.ts#L2690)
**Solution**
Default values for `jsconfig.json` config files should not override values **explicitly** defined by the extended configs.
**Workaround**
Explicitly set the following values in config files named `jsconfig.json` that extend other configs with non-default values:
- `allowJs`
- `maxNodeModuleJsDepth`
- `allowSyntheticDefaultImports`
- `skipLibCheck`
- `noEmit` | Bug | low | Minor |
561,837,689 | rust | Tests in panic=abort can hang if test spawns a subprocess | If a test (running in a subprocess, because panic=abort) spawns a sub-subprocess which inherits its stdout or stderr handles, and the sub-subprocess does not exit when the test does, the test framework will hang. This is because [`wait_with_output`](https://github.com/rust-lang/rust/blob/fb29dfcc9ada6ed10308b6e7f405569f61a9af0b/src/libstd/process.rs#L1469-L1491) waits for all stdio handles to be closed.
```
libtest runner (waits for unit test stdio to close)
|
| Stdio::piped
|
unit test process (exits, but stdio is now shared with subproc)
||
|| Stdio::inherit
||
"leaked" subprocess (sticks around forever)
```
Some tests spawn subprocesses, and it can be hard (particularly with panic=abort) to ensure that they are all cleaned up when the test succeeds or fails. In these cases, it would be best not to hang. Hanging is unexpected, and hard to debug. | A-libtest,C-bug,T-libs | low | Critical |
561,864,203 | flutter | Web engine: find the best way to apply static CSS properties | There are several CSS properties that we set on nearly every element we create, such as `position:absolute` and `transform-origin: 0 0 0`. Currently we do this in an ad hoc fashion. We also sometimes reassign these repeatedly to the same value (particularly `transform-origin`). For example, there are 13 places that set `transform-origin: 0 0 0`. Consider finding a more centralized method for setting up elements using the fastest method available. For example:
* Have a shared function that initializes newly elements.
* Use a style sheet that applies shared static properties.
/cc @mdebbar | engine,platform-web,c: proposal,c: rendering,P2,team-web,triaged-web | low | Minor |
561,896,520 | go | x/pkgsite: README images should be proxied to protect user privacy | The overview page links directly to images referenced from the readme markdown. These references allow third parties to track users on pkg.go.dev.
Github proxies images referenced from the readme to prevent such tracking. See the following for more information:
- https://github.blog/2014-01-28-proxying-user-images/
- https://help.github.com/en/github/authenticating-to-github/about-anonymized-image-urls
pkg.go.dev should do the same.
### What is the URL of the page with the issue?
https://pkg.go.dev/github.com/labstack/echo?tab=overview and many other ?tab=overview pages.
### What did you do?
I visited the page.
### What did you expect to see?
I expected to see requests to pkg.go.dev and it's trusted partners.
### What did you see instead?
I saw image requests to sourcegraph.com, img.sheilds.go and goreportcard.com.
| NeedsInvestigation,pkgsite,pkgsite/frontend | low | Minor |
561,904,687 | pytorch | InlineAutodiffSubgraphs in JIT inlines non-differentiable custom groups unexpectedly. | ## π Bug
## Issue description
It appears that the `InlineAutodiffSubgraphs` pass inlines non-differentiable custom groups unexpectedly. As a result, `.backward(...)` cannot be executed on the output from the forward computation.
To fix this issue, `canRunWithAutograd` in `torch/csrc/jit/passes/inline_autodiff_subgraphs.cpp` needs to be updated as shown below:
<pre><code>bool canRunWithAutograd(Node* node) {
return (node->kind().is_prim() && node->kind() != prim::FusionGroup) ||
node->kind().is_aten();
}</code></pre>
## Code example
Consider the following code example:
<pre><code>model = torchvision.models.resnet18().eval().to(dtype=torch.float, device='cuda')
x = torch.randn(2, 3, 224, 224, dtype=torch.float, device='cuda', requires_grad=True)
x_ = x.clone().detach().requires_grad_(True)
traced = torch.jit.trace(model, x_, check_trace=False)
out = model(x)
tout = traced(x_)
print(traced.graph_for(x_))
print(out)
print(tout)
out.backward(torch.ones(2, 1000, dtype=float, device='cuda'))
tout.backward(torch.ones(2, 1000, dtype=float, device='cuda'))
print(x.grad)
print(x_.grad)
</code></pre>
Without a custom pass, this works fine and `tout` is printed out as
<pre><code>tensor([[-1.7074, 0.4159, 1.1330, ..., 1.2971, -0.7362, 0.6159],
[-1.7468, 0.4392, 1.1862, ..., 1.1875, -0.6431, 0.6839]],
device='cuda:0', grad_fn=<DifferentiableGraphBackward>)
</code></pre>
But with a custom pass enabled, I get the error
<pre><code>RuntimeError: element 0 of tensors does not require grad and does not have a grad_fn</code></pre>
and `tout` is printed out without `grad_fn` as
<pre><code>tensor([[ 0.2352, 0.9813, -0.5402, ..., -1.0934, 0.7645, -1.1978],
[ 0.4200, 0.8891, -0.5688, ..., -1.0392, 0.7479, -1.2435]],
device='cuda:0')
</code></pre>
With the custom pass, one of the two `prim::DifferentiableGraph` is inlined in the graph making custom groups appear as differentiable groups.
## System Info
PyTorch version: 1.3.0a0+ee77ccb
Is debug build: No
CUDA used to build PyTorch: 10.1.243
OS: Ubuntu 18.04.4 LTS
GCC version: (Ubuntu 7.4.0-1ubuntu1~18.04.1) 7.4.0
CMake version: version 3.14.0
Python version: 3.7
Is CUDA available: Yes
CUDA runtime version: Could not collect
GPU models and configuration: GPU 0: Quadro GV100
Nvidia driver version: 440.33.01
cuDNN version: Could not collect
Versions of relevant libraries:
[pip] numpy==1.16.4
[pip] torch==1.3.0a0+ee77ccb
[pip] torchvision==0.4.2
[conda] blas 1.0 mkl
[conda] mkl 2019.4 243
[conda] mkl-include 2019.4 243
[conda] mkl-service 2.3.0 py37he904b0f_0
[conda] mkl_fft 1.0.15 py37ha843d7b_0
[conda] mkl_random 1.1.0 py37hd6b4f25_0
[conda] torch 1.3.0a0+ee77ccb dev_0 <develop>
[conda] torchvision 0.4.2 pypi_0 pypi
cc @suo | oncall: jit,module: custom-operators,actionable | low | Critical |
561,905,315 | flutter | Fix the discrepancy between WidgetTester.pumpWidget() and runApp() | @yjbanov:
> The first frame of an app (launched via `runApp()`) is preceded by a `BuildOwner.buildScope()` without laying out the scene, while the first frame of a test (the first invocation of `WidgetTester.pumpWidget()`) does perform layout. Therefore, code that attempts to access layout information can fail depending on which environment it runs in.
For reference and more context, please see https://github.com/flutter/flutter/pull/48922 | a: tests,framework,P2,team-framework,triaged-framework | low | Minor |
561,911,005 | pytorch | Move the custom pass execution back to the beginning of runNondiffOptimization | ## π Bug
This is about the JIT compilation.
https://github.com/pytorch/pytorch/pull/29256 moved the execution of custom passes to the end of `runNondiffOptimization`.
This change has an adverse effect on a custom pass that we have been working on. With this change, our custom pass cannot see the graph in the original form and can only see the nodes that are not taken by the fusion pass. This limits the efficacy of our custom pass.
I believe that we are not the only one affected by this change. And due to this issue, we have decided not to move to PyTorch 1.4.
## Environment
PyTorch version: 1.3.0a0+ee77ccb
Is debug build: No
CUDA used to build PyTorch: 10.1.243
OS: Ubuntu 18.04.4 LTS
GCC version: (Ubuntu 7.4.0-1ubuntu1~18.04.1) 7.4.0
CMake version: version 3.14.0
Python version: 3.7
Is CUDA available: Yes
CUDA runtime version: Could not collect
GPU models and configuration: GPU 0: Quadro GV100
Nvidia driver version: 440.33.01
cuDNN version: Could not collect
Versions of relevant libraries:
[pip] numpy==1.16.4
[pip] torch==1.3.0a0+ee77ccb
[pip] torchvision==0.4.2
[conda] blas 1.0 mkl
[conda] mkl 2019.4 243
[conda] mkl-include 2019.4 243
[conda] mkl-service 2.3.0 py37he904b0f_0
[conda] mkl_fft 1.0.15 py37ha843d7b_0
[conda] mkl_random 1.1.0 py37hd6b4f25_0
[conda] torch 1.3.0a0+ee77ccb dev_0
[conda] torchvision 0.4.2 pypi_0 pypi
cc @suo @apaszke | oncall: jit,triaged | low | Critical |
561,913,760 | flutter | Add golden test for safe area with transparency | Create a framework golden test that launches an Android `FlutterActivity` with transparency enabled. The golden test should ensure that safe area is respected.
The embedding change that lead to this ticket is here:
https://github.com/flutter/engine/pull/16208 | a: tests,platform-android,engine,e: embedder,c: proposal,P2,team-android,triaged-android | low | Minor |
561,913,939 | flutter | When Testing Accessibility, Text Contrast Tests Do Not Always Give Right Results | <!-- Thank you for using Flutter!
If you are looking for support, please check out our documentation
or consider asking a question on Stack Overflow:
* https://flutter.dev/
* https://api.flutter.dev/
* https://stackoverflow.com/questions/tagged/flutter?sort=frequent
If you have found a bug or if our documentation doesn't have an answer
to what you're looking for, then fill our the template below. Please read
our guide to filing a bug first: https://flutter.dev/docs/resources/bug-reports
-->
## Steps to Reproduce
<!-- You must include full steps to reproduce so that we can reproduce the problem. -->
1. Checkout the file `packages/flutter_test/test/accessibility_test.dart` from the following branch.
- https://github.com/pennzht/flutter/tree/contrast-test-issue
- This file contains some additional tests for color contrast.
- Alternatively, you can add the tests (see the **Additional Tests** section below) to `packages/flutter_test/test/accessibility_test.dart`.
- You can use tests in this file to test your own implementations for `packages/flutter_test/lib/src/accessibility.dart`.
2. Go to the path `packages/flutter_test` and run `flutter test test/accessibility_test.dart`
**Expected results:** <!-- what did you want to see? -->
- All tests should pass.
* During a color contrast test, all text widgets which *contribute to semantics* should be tested for their color contrast ratio, including children of `MergeSemantics` widgets. Text widgets that do not contribute to semantics should be skipped.
**Actual results:** <!-- what did you see? -->
- The following tests fail:
* text contrast guideline white text on white background with merge semantics
* white and black text on white
* black and white text on white
* irrelevant text
* irrelevant button
## Related Solutions
May be fixed by #48868
<details>
<summary>Logs</summary>
* Some personal information has been << REMOVED >>.
<!--
Run your application with `flutter run --verbose` and attach all the
log output below between the lines with the backticks. If there is an
exception, please see if the error message includes enough information
to explain how to solve the issue.
-->
* The following log is for `flutter test --verbose test/accessibility_test.dart`.
```
<< REMOVED >>-macbookpro:flutter_test << REMOVED >>$ flutter test --verbose test/accessibility_test.dart
[ +22 ms] executing: [/Users/<< REMOVED >>/Documents/f/flutter/] git -c log.showSignature=false log -n 1 --pretty=format:%H
[ +28 ms] Exit code 0 from: git -c log.showSignature=false log -n 1 --pretty=format:%H
[ ] << REMOVED >>
[ ] executing: [/Users/<< REMOVED >>/Documents/f/flutter/] git describe --match v*.*.* --first-parent --long --tags
[ +20 ms] Exit code 0 from: git describe --match v*.*.* --first-parent --long --tags
[ ] v1.15.2-31-<< REMOVED >>
[ +7 ms] executing: [/Users/<< REMOVED >>/Documents/f/flutter/] git rev-parse --abbrev-ref --symbolic @{u}
[ +5 ms] Exit code 128 from: git rev-parse --abbrev-ref --symbolic @{u}
[ ] fatal: no upstream configured for branch 'contrast-test-issue'
[ +18 ms] Artifact Instance of 'MaterialFonts' is not required, skipping update.
[ ] Artifact Instance of 'GradleWrapper' is not required, skipping update.
[ ] Artifact Instance of 'AndroidMavenArtifacts' is not required, skipping update.
[ ] Artifact Instance of 'AndroidGenSnapshotArtifacts' is not required, skipping update.
[ ] Artifact Instance of 'AndroidInternalBuildArtifacts' is not required, skipping update.
[ ] Artifact Instance of 'IOSEngineArtifacts' is not required, skipping update.
[ ] Artifact Instance of 'FlutterWebSdk' is not required, skipping update.
[ ] Artifact Instance of 'FlutterSdk' is not required, skipping update.
[ ] Artifact Instance of 'WindowsEngineArtifacts' is not required, skipping update.
[ ] Artifact Instance of 'MacOSEngineArtifacts' is not required, skipping update.
[ ] Artifact Instance of 'LinuxEngineArtifacts' is not required, skipping update.
[ ] Artifact Instance of 'LinuxFuchsiaSDKArtifacts' is not required, skipping update.
[ ] Artifact Instance of 'MacOSFuchsiaSDKArtifacts' is not required, skipping update.
[ ] Artifact Instance of 'FlutterRunnerSDKArtifacts' is not required, skipping update.
[ ] Artifact Instance of 'FlutterRunnerDebugSymbols' is not required, skipping update.
[ ] Artifact Instance of 'IosUsbArtifacts' is not required, skipping update.
[ ] Artifact Instance of 'IosUsbArtifacts' is not required, skipping update.
[ ] Artifact Instance of 'IosUsbArtifacts' is not required, skipping update.
[ ] Artifact Instance of 'IosUsbArtifacts' is not required, skipping update.
[ ] Artifact Instance of 'IosUsbArtifacts' is not required, skipping update.
[ ] Artifact Instance of 'IosUsbArtifacts' is not required, skipping update.
[ ] Artifact Instance of 'IosUsbArtifacts' is not required, skipping update.
[ ] Artifact Instance of 'FontSubsetArtifacts' is not required, skipping update.
[ +64 ms] running test package with arguments: [-r, compact, --concurrency=10, --test-randomize-ordering-seed=0, --,
/Users/<< REMOVED >>/Documents/f/flutter/packages/flutter_test/test/accessibility_test.dart]
00:00 +0: loading /Users/<< REMOVED >>/Documents/f/flutter/packages/flutter_test/test/accessibility_test.dart [ +167 ms] test 0: starting test /Users/<< REMOVED >>/Documents/f/flutter/packages/flutter_test/test/accessibility_test.dart
[ +17 ms] test 0: starting shell process
[ +4 ms] Stopping scan for flutter_test_config.dart; found project root at
/Users/<< REMOVED >>/Documents/f/flutter/packages/flutter_test
[ +7 ms] Compiler will use the following file as its incremental dill file:
/var/folders/3l/<< REMOVED >>/T/flutter_test_compiler.2XrLZx/output.dill
[ ] Listening to compiler controller...
[ +2 ms] Compiling /var/folders/3l/<< REMOVED >>/T/flutter_test_listener.D4nwqe/listener.dart
[ +13 ms] /Users/<< REMOVED >>/Documents/f/flutter/bin/cache/dart-sdk/bin/dart
/Users/<< REMOVED >>/Documents/f/flutter/bin/cache/artifacts/engine/darwin-x64/frontend_server.dart.snapshot --sdk-root
/Users/<< REMOVED >>/Documents/f/flutter/bin/cache/artifacts/engine/common/flutter_patched_sdk/ --incremental --target=flutter
-Ddart.developer.causal_async_stacks=true --output-dill
/var/folders/3l/<< REMOVED >>/T/flutter_test_compiler.2XrLZx/output.dill --packages
/Users/<< REMOVED >>/Documents/f/flutter/packages/flutter_test/.packages -Ddart.vm.profile=false -Ddart.vm.product=false
--bytecode-options=source-positions,local-var-info,debugger-stops,instance-field-initializers,keep-unreachable-code,avoid-closure-cal
l-instructions --enable-asserts --track-widget-creation --initialize-from-dill
/Users/<< REMOVED >>/Documents/f/flutter/packages/flutter_test/build/testfile.dill.track.dill
[ +18 ms] <- compile /var/folders/3l/<< REMOVED >>/T/flutter_test_listener.D4nwqe/listener.dart
00:06 +0: loading /Users/<< REMOVED >>/Documents/f/flutter/packages/flutter_test/test/accessibility_test.dart [+6105 ms] <- accept
[ ] <- reset
[ ] Compiling /var/folders/3l/<< REMOVED >>/T/flutter_test_listener.D4nwqe/listener.dart took 6138ms
[ +1 ms] /Users/<< REMOVED >>/Documents/f/flutter/bin/cache/artifacts/engine/darwin-x64/flutter_tester --disable-observatory
--enable-checked-mode --verify-entry-points --enable-software-rendering --skia-deterministic-rendering --enable-dart-profiling
--non-interactive --use-test-fonts --packages=/Users/<< REMOVED >>/Documents/f/flutter/packages/flutter_test/.packages
/var/folders/3l/<< REMOVED >>/T/flutter_test_listener.D4nwqe/listener.dart.dill
[ +1 ms] Using this directory for fonts configuration: /var/folders/3l/<< REMOVED >>/T/flutter_test_fonts.bkjW2N
[ +7 ms] test 0: awaiting initial result for pid 18541
[ +351 ms] test 0: process with pid 18541 connected to test harness
[ ] test 0: awaiting test result for pid 18541
00:07 +0: text contrast guideline white text on white background with merge semantics
βββ‘ EXCEPTION CAUGHT BY FLUTTER TEST FRAMEWORK βββββββββββββββββββββββββββββββββββββββββββββββββββββ
The following TestFailure object was thrown running a test:
Expected: Does not Text contrast should follow WCAG guidelines
Actual: <Instance of 'WidgetTester'>
Which: Failed
When the exception was thrown, this was the stack:
#0 fail (package:test_api/src/frontend/expect.dart:153:30)
#1 _expect.<anonymous closure> (package:test_api/src/frontend/expect.dart:127:9)
#13 _DoesNotMatchAccessibilityGuideline.matchAsync (package:flutter_test/src/matchers.dart)
<asynchronous suspension>
#14 _expect (package:test_api/src/frontend/expect.dart:116:26)
#15 expectLater (package:test_api/src/frontend/expect.dart:75:5)
#16 expectLater (package:flutter_test/src/widget_tester.dart:385:10)
#17 main.<anonymous closure>.<anonymous closure> (file:///Users/<< REMOVED >>/Documents/f/flutter/packages/flutter_test/test/accessibility_test.dart:35:13)
<asynchronous suspension>
#18 testWidgets.<anonymous closure>.<anonymous closure> (package:flutter_test/src/widget_tester.dart:140:29)
<asynchronous suspension>
#19 TestWidgetsFlutterBinding._runTestBody (package:flutter_test/src/binding.dart:706:19)
<asynchronous suspension>
#22 TestWidgetsFlutterBinding._runTest (package:flutter_test/src/binding.dart:686:14)
#23 AutomatedTestWidgetsFlutterBinding.runTest.<anonymous closure> (package:flutter_test/src/binding.dart:1086:24)
#29 AutomatedTestWidgetsFlutterBinding.runTest (package:flutter_test/src/binding.dart:1083:15)
#30 testWidgets.<anonymous closure> (package:flutter_test/src/widget_tester.dart:133:24)
#31 Declarer.test.<anonymous closure>.<anonymous closure>.<anonymous closure> (package:test_api/src/backend/declarer.dart:171:27)
<asynchronous suspension>
#32 Invoker.waitForOutstandingCallbacks.<anonymous closure> (package:test_api/src/backend/invoker.dart:242:15)
#37 Invoker.waitForOutstandingCallbacks (package:test_api/src/backend/invoker.dart:239:5)
#38 Declarer.test.<anonymous closure>.<anonymous closure> (package:test_api/src/backend/declarer.dart:169:33)
#43 Declarer.test.<anonymous closure> (package:test_api/src/backend/declarer.dart:168:13)
#44 Invoker._onRun.<anonymous closure>.<anonymous closure>.<anonymous closure>.<anonymous closure> (package:test_api/src/backend/invoker.dart:392:25)
(elided 42 frames from class _FakeAsync, class _RawReceivePortImpl, class _Timer, dart:async, dart:async-patch, and package:stack_trace)
The test description was:
white text on white background with merge semantics
ββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββ
00:07 +0 -1: text contrast guideline white text on white background with merge semantics [E]
Test failed. See exception logs above.
The test description was: white text on white background with merge semantics
00:08 +36 -1: white and black text on white
βββ‘ EXCEPTION CAUGHT BY FLUTTER TEST FRAMEWORK βββββββββββββββββββββββββββββββββββββββββββββββββββββ
The following TestFailure object was thrown running a test:
Expected: Does not Text contrast should follow WCAG guidelines
Actual: <Instance of 'WidgetTester'>
Which: Failed
When the exception was thrown, this was the stack:
#0 fail (package:test_api/src/frontend/expect.dart:153:30)
#1 _expect.<anonymous closure> (package:test_api/src/frontend/expect.dart:127:9)
#13 _DoesNotMatchAccessibilityGuideline.matchAsync (package:flutter_test/src/matchers.dart)
<asynchronous suspension>
#14 _expect (package:test_api/src/frontend/expect.dart:116:26)
#15 expectLater (package:test_api/src/frontend/expect.dart:75:5)
#16 expectLater (package:flutter_test/src/widget_tester.dart:385:10)
#17 main.<anonymous closure> (file:///Users/<< REMOVED >>/Documents/f/flutter/packages/flutter_test/test/accessibility_test.dart:698:11)
<asynchronous suspension>
#18 testWidgets.<anonymous closure>.<anonymous closure> (package:flutter_test/src/widget_tester.dart:140:29)
<asynchronous suspension>
#19 TestWidgetsFlutterBinding._runTestBody (package:flutter_test/src/binding.dart:706:19)
<asynchronous suspension>
#22 TestWidgetsFlutterBinding._runTest (package:flutter_test/src/binding.dart:686:14)
#23 AutomatedTestWidgetsFlutterBinding.runTest.<anonymous closure> (package:flutter_test/src/binding.dart:1086:24)
#29 AutomatedTestWidgetsFlutterBinding.runTest (package:flutter_test/src/binding.dart:1083:15)
#30 testWidgets.<anonymous closure> (package:flutter_test/src/widget_tester.dart:133:24)
#31 Declarer.test.<anonymous closure>.<anonymous closure>.<anonymous closure> (package:test_api/src/backend/declarer.dart:171:27)
<asynchronous suspension>
#32 Invoker.waitForOutstandingCallbacks.<anonymous closure> (package:test_api/src/backend/invoker.dart:242:15)
#37 Invoker.waitForOutstandingCallbacks (package:test_api/src/backend/invoker.dart:239:5)
#38 Declarer.test.<anonymous closure>.<anonymous closure> (package:test_api/src/backend/declarer.dart:169:33)
#43 Declarer.test.<anonymous closure> (package:test_api/src/backend/declarer.dart:168:13)
#44 Invoker._onRun.<anonymous closure>.<anonymous closure>.<anonymous closure>.<anonymous closure> (package:test_api/src/backend/invoker.dart:392:25)
(elided 42 frames from class _FakeAsync, class _RawReceivePortImpl, class _Timer, dart:async, dart:async-patch, and package:stack_trace)
The test description was:
white and black text on white
ββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββ
00:08 +36 -2: white and black text on white [E]
Test failed. See exception logs above.
The test description was: white and black text on white
00:08 +36 -2: black and white text on white
βββ‘ EXCEPTION CAUGHT BY FLUTTER TEST FRAMEWORK βββββββββββββββββββββββββββββββββββββββββββββββββββββ
The following TestFailure object was thrown running a test:
Expected: Does not Text contrast should follow WCAG guidelines
Actual: <Instance of 'WidgetTester'>
Which: Failed
When the exception was thrown, this was the stack:
#0 fail (package:test_api/src/frontend/expect.dart:153:30)
#1 _expect.<anonymous closure> (package:test_api/src/frontend/expect.dart:127:9)
#13 _DoesNotMatchAccessibilityGuideline.matchAsync (package:flutter_test/src/matchers.dart)
<asynchronous suspension>
#14 _expect (package:test_api/src/frontend/expect.dart:116:26)
#15 expectLater (package:test_api/src/frontend/expect.dart:75:5)
#16 expectLater (package:flutter_test/src/widget_tester.dart:385:10)
#17 main.<anonymous closure> (file:///Users/<< REMOVED >>/Documents/f/flutter/packages/flutter_test/test/accessibility_test.dart:722:11)
<asynchronous suspension>
#18 testWidgets.<anonymous closure>.<anonymous closure> (package:flutter_test/src/widget_tester.dart:140:29)
<asynchronous suspension>
#19 TestWidgetsFlutterBinding._runTestBody (package:flutter_test/src/binding.dart:706:19)
<asynchronous suspension>
#22 TestWidgetsFlutterBinding._runTest (package:flutter_test/src/binding.dart:686:14)
#23 AutomatedTestWidgetsFlutterBinding.runTest.<anonymous closure> (package:flutter_test/src/binding.dart:1086:24)
#29 AutomatedTestWidgetsFlutterBinding.runTest (package:flutter_test/src/binding.dart:1083:15)
#30 testWidgets.<anonymous closure> (package:flutter_test/src/widget_tester.dart:133:24)
#31 Declarer.test.<anonymous closure>.<anonymous closure>.<anonymous closure> (package:test_api/src/backend/declarer.dart:171:27)
<asynchronous suspension>
#32 Invoker.waitForOutstandingCallbacks.<anonymous closure> (package:test_api/src/backend/invoker.dart:242:15)
#37 Invoker.waitForOutstandingCallbacks (package:test_api/src/backend/invoker.dart:239:5)
#38 Declarer.test.<anonymous closure>.<anonymous closure> (package:test_api/src/backend/declarer.dart:169:33)
#43 Declarer.test.<anonymous closure> (package:test_api/src/backend/declarer.dart:168:13)
#44 Invoker._onRun.<anonymous closure>.<anonymous closure>.<anonymous closure>.<anonymous closure> (package:test_api/src/backend/invoker.dart:392:25)
(elided 42 frames from class _FakeAsync, class _RawReceivePortImpl, class _Timer, dart:async, dart:async-patch, and package:stack_trace)
The test description was:
black and white text on white
ββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββ
00:08 +36 -3: black and white text on white [E]
Test failed. See exception logs above.
The test description was: black and white text on white
00:08 +36 -3: irrelevant text
βββ‘ EXCEPTION CAUGHT BY FLUTTER TEST FRAMEWORK βββββββββββββββββββββββββββββββββββββββββββββββββββββ
The following TestFailure object was thrown running a test:
Expected: Text contrast should follow WCAG guidelines
Actual: <Instance of 'WidgetTester'>
Which: Multiple nodes with the same label: One
When the exception was thrown, this was the stack:
#0 fail (package:test_api/src/frontend/expect.dart:153:30)
#1 _expect.<anonymous closure> (package:test_api/src/frontend/expect.dart:127:9)
#13 _MatchesAccessibilityGuideline.matchAsync (package:flutter_test/src/matchers.dart)
<asynchronous suspension>
#14 _expect (package:test_api/src/frontend/expect.dart:116:26)
#15 expectLater (package:test_api/src/frontend/expect.dart:75:5)
#16 expectLater (package:flutter_test/src/widget_tester.dart:385:10)
#17 main.<anonymous closure> (file:///Users/<< REMOVED >>/Documents/f/flutter/packages/flutter_test/test/accessibility_test.dart:748:11)
<asynchronous suspension>
#18 testWidgets.<anonymous closure>.<anonymous closure> (package:flutter_test/src/widget_tester.dart:140:29)
<asynchronous suspension>
#19 TestWidgetsFlutterBinding._runTestBody (package:flutter_test/src/binding.dart:706:19)
<asynchronous suspension>
#22 TestWidgetsFlutterBinding._runTest (package:flutter_test/src/binding.dart:686:14)
#23 AutomatedTestWidgetsFlutterBinding.runTest.<anonymous closure> (package:flutter_test/src/binding.dart:1086:24)
#29 AutomatedTestWidgetsFlutterBinding.runTest (package:flutter_test/src/binding.dart:1083:15)
#30 testWidgets.<anonymous closure> (package:flutter_test/src/widget_tester.dart:133:24)
#31 Declarer.test.<anonymous closure>.<anonymous closure>.<anonymous closure> (package:test_api/src/backend/declarer.dart:171:27)
<asynchronous suspension>
#32 Invoker.waitForOutstandingCallbacks.<anonymous closure> (package:test_api/src/backend/invoker.dart:242:15)
#37 Invoker.waitForOutstandingCallbacks (package:test_api/src/backend/invoker.dart:239:5)
#38 Declarer.test.<anonymous closure>.<anonymous closure> (package:test_api/src/backend/declarer.dart:169:33)
#43 Declarer.test.<anonymous closure> (package:test_api/src/backend/declarer.dart:168:13)
#44 Invoker._onRun.<anonymous closure>.<anonymous closure>.<anonymous closure>.<anonymous closure> (package:test_api/src/backend/invoker.dart:392:25)
(elided 42 frames from class _FakeAsync, class _RawReceivePortImpl, class _Timer, dart:async, dart:async-patch, and package:stack_trace)
The test description was:
irrelevant text
ββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββ
00:08 +36 -4: irrelevant text [E]
Test failed. See exception logs above.
The test description was: irrelevant text
00:08 +37 -4: irrelevant button
βββ‘ EXCEPTION CAUGHT BY FLUTTER TEST FRAMEWORK βββββββββββββββββββββββββββββββββββββββββββββββββββββ
The following TestFailure object was thrown running a test:
Expected: Text contrast should follow WCAG guidelines
Actual: <Instance of 'WidgetTester'>
Which: Multiple nodes with the same label: One
When the exception was thrown, this was the stack:
#0 fail (package:test_api/src/frontend/expect.dart:153:30)
#1 _expect.<anonymous closure> (package:test_api/src/frontend/expect.dart:127:9)
#13 _MatchesAccessibilityGuideline.matchAsync (package:flutter_test/src/matchers.dart)
<asynchronous suspension>
#14 _expect (package:test_api/src/frontend/expect.dart:116:26)
#15 expectLater (package:test_api/src/frontend/expect.dart:75:5)
#16 expectLater (package:flutter_test/src/widget_tester.dart:385:10)
#17 main.<anonymous closure> (file:///Users/<< REMOVED >>/Documents/f/flutter/packages/flutter_test/test/accessibility_test.dart:800:11)
<asynchronous suspension>
#18 testWidgets.<anonymous closure>.<anonymous closure> (package:flutter_test/src/widget_tester.dart:140:29)
<asynchronous suspension>
#19 TestWidgetsFlutterBinding._runTestBody (package:flutter_test/src/binding.dart:706:19)
<asynchronous suspension>
#22 TestWidgetsFlutterBinding._runTest (package:flutter_test/src/binding.dart:686:14)
#23 AutomatedTestWidgetsFlutterBinding.runTest.<anonymous closure> (package:flutter_test/src/binding.dart:1086:24)
#29 AutomatedTestWidgetsFlutterBinding.runTest (package:flutter_test/src/binding.dart:1083:15)
#30 testWidgets.<anonymous closure> (package:flutter_test/src/widget_tester.dart:133:24)
#31 Declarer.test.<anonymous closure>.<anonymous closure>.<anonymous closure> (package:test_api/src/backend/declarer.dart:171:27)
<asynchronous suspension>
#32 Invoker.waitForOutstandingCallbacks.<anonymous closure> (package:test_api/src/backend/invoker.dart:242:15)
#37 Invoker.waitForOutstandingCallbacks (package:test_api/src/backend/invoker.dart:239:5)
#38 Declarer.test.<anonymous closure>.<anonymous closure> (package:test_api/src/backend/declarer.dart:169:33)
#43 Declarer.test.<anonymous closure> (package:test_api/src/backend/declarer.dart:168:13)
#44 Invoker._onRun.<anonymous closure>.<anonymous closure>.<anonymous closure>.<anonymous closure> (package:test_api/src/backend/invoker.dart:392:25)
(elided 42 frames from class _FakeAsync, class _RawReceivePortImpl, class _Timer, dart:async, dart:async-patch, and package:stack_trace)
The test description was:
irrelevant button
ββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββ
00:08 +37 -5: irrelevant button [E]
Test failed. See exception logs above.
The test description was: irrelevant button
00:08 +39 -5: black and white text, without MergeSemantics [+2229 ms] test 0: process with pid 18541 no longer needed by test harness
[ ] test 0: cleaning up...
[ ] test 0: ensuring end-of-process for shell
[ +20 ms] test 0: deleting temporary directory
[ +2 ms] test 0: shutting down test harness socket server
[ +2 ms] test 0: finished
00:08 +39 -5: Some tests failed.
[ +15 ms] Deleting /var/folders/3l/<< REMOVED >>/T/flutter_test_compiler.2XrLZx...
[ +4 ms] killing pid 18527
[ +50 ms] Deleting /var/folders/3l/<< REMOVED >>/T/flutter_test_fonts.bkjW2N...
[ +5 ms] test package returned with exit code 1
#0 throwToolExit (package:flutter_tools/src/base/common.dart:14:3)
#1 TestCommand.runCommand (package:flutter_tools/src/commands/test.dart:271:7)
<asynchronous suspension>
#2 AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:150:29)
#3 _rootRun (dart:async/zone.dart:1126:13)
#4 _CustomZone.run (dart:async/zone.dart:1023:19)
#5 _runZoned (dart:async/zone.dart:1518:10)
#6 runZoned (dart:async/zone.dart:1465:12)
#7 AppContext.run (package:flutter_tools/src/base/context.dart:149:18)
#8 FastFlutterCommand.run (package:flutter_tools/src/runner/flutter_command.dart:877:20)
#9 CommandRunner.runCommand (package:args/command_runner.dart:197:27)
#10 FlutterCommandRunner.runCommand.<anonymous closure> (package:flutter_tools/src/runner/flutter_command_runner.dart:338:21)
<asynchronous suspension>
#11 AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:150:29)
#12 _rootRun (dart:async/zone.dart:1126:13)
#13 _CustomZone.run (dart:async/zone.dart:1023:19)
#14 _runZoned (dart:async/zone.dart:1518:10)
#15 runZoned (dart:async/zone.dart:1465:12)
#16 AppContext.run (package:flutter_tools/src/base/context.dart:149:18)
#17 FlutterCommandRunner.runCommand (package:flutter_tools/src/runner/flutter_command_runner.dart:288:19)
#18 CommandRunner.run.<anonymous closure> (package:args/command_runner.dart:112:25)
#19 new Future.sync (dart:async/future.dart:224:31)
#20 CommandRunner.run (package:args/command_runner.dart:112:14)
#21 FlutterCommandRunner.run (package:flutter_tools/src/runner/flutter_command_runner.dart:231:18)
#22 run.<anonymous closure>.<anonymous closure> (package:flutter_tools/runner.dart:64:22)
#23 _rootRun (dart:async/zone.dart:1126:13)
#24 _CustomZone.run (dart:async/zone.dart:1023:19)
#25 _runZoned (dart:async/zone.dart:1518:10)
#26 runZoned (dart:async/zone.dart:1502:12)
#27 run.<anonymous closure> (package:flutter_tools/runner.dart:62:18)
<asynchronous suspension>
#28 AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:150:29)
#29 _rootRun (dart:async/zone.dart:1126:13)
#30 _CustomZone.run (dart:async/zone.dart:1023:19)
#31 _runZoned (dart:async/zone.dart:1518:10)
#32 runZoned (dart:async/zone.dart:1465:12)
#33 AppContext.run (package:flutter_tools/src/base/context.dart:149:18)
#34 runInContext (package:flutter_tools/src/context_runner.dart:64:24)
#35 run (package:flutter_tools/runner.dart:51:10)
#36 main (package:flutter_tools/executable.dart:65:9)
#37 main (file:///Users/<< REMOVED >>/Documents/f/flutter/packages/flutter_tools/bin/flutter_tools.dart:8:3)
#38 _startIsolate.<anonymous closure> (dart:isolate-patch/isolate_patch.dart:299:32)
#39 _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:168:12)
[ +12 ms] executing: [/Users/<< REMOVED >>/Documents/f/flutter/] git rev-parse --abbrev-ref HEAD
[ +7 ms] Exit code 0 from: git rev-parse --abbrev-ref HEAD
[ ] contrast-test-issue
<< REMOVED >>-macbookpro:flutter_test << REMOVED >>$
```
<!--
Run `flutter analyze` and attach any output of that command below.
If there are any analysis errors, try resolving them before filing this issue.
-->
```
<< REMOVED >>-macbookpro:flutter_test << REMOVED >>$ flutter analyze
Analyzing flutter_test...
No issues found! (ran in 1.7s)
<< REMOVED >>-macbookpro:flutter_test << REMOVED >>$
```
<!-- Finally, paste the output of running `flutter doctor -v` here. -->
```
<< REMOVED >>-macbookpro:flutter_test << REMOVED >>$ flutter doctor -v
Downloading android-arm-profile/darwin-x64 tools... 1.0s
Downloading android-arm-release/darwin-x64 tools... 1.0s
Downloading android-arm64-profile/darwin-x64 tools... 0.8s
Downloading android-arm64-release/darwin-x64 tools... 0.8s
Downloading android-x64-profile/darwin-x64 tools... 0.8s
Downloading android-x64-release/darwin-x64 tools... 0.7s
[β] Flutter (Channel unknown, v1.15.3-pre.30, on Mac OS X 10.14.6 18G2022, locale en-DE)
β’ Flutter version 1.15.3-pre.30 at /Users/<< REMOVED >>/Documents/f/flutter
β’ Framework revision << REMOVED >> (10 minutes ago), 2020-02-07 23:50:53 +0100
β’ Engine revision << REMOVED >>
β’ Dart version 2.8.0 (build 2.8.0-dev.7.0 << REMOVED >>)
[β] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
β’ Android SDK at /Users/<< REMOVED >>/Library/Android/sdk
β’ Android NDK location not configured (optional; useful for native profiling support)
β’ Platform android-29, build-tools 29.0.2
β’ Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
β’ Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405)
β’ All Android licenses accepted.
[β] Xcode - develop for iOS and macOS (Xcode 11.2.1)
β’ Xcode at /Applications/Xcode 11.2.1.app/Contents/Developer
β’ Xcode 11.2.1, Build version 11B500
β’ CocoaPods version 1.7.5
[β] Chrome - develop for the web
β’ Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome
[β] Android Studio (version 3.5)
β’ Android Studio at /Applications/Android Studio.app/Contents
β’ Flutter plugin version 39.0.3
β’ Dart plugin version 191.8423
β’ Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405)
[β] Connected device (3 available)
β’ macOS β’ macOS β’ darwin-x64 β’ Mac OS X 10.14.6 18G2022
β’ Chrome β’ chrome β’ web-javascript β’ Google Chrome 80.0.3987.87
β’ Web Server β’ web-server β’ web-javascript β’ Flutter Tools
β’ No issues found!
<< REMOVED >>-macbookpro:flutter_test << REMOVED >>$
```
</details>
## Additional Tests
<details>
<summary>Additional tests</summary>
```dart
testWidgets('white text on white background with merge semantics', (WidgetTester tester) async {
final SemanticsHandle handle = tester.ensureSemantics();
await tester.pumpWidget(MaterialApp(
home: Scaffold(
backgroundColor: Colors.white,
body: Center(
child: MergeSemantics(
child: Column(
mainAxisAlignment: MainAxisAlignment.center,
children: const <Widget>[
Text(
'I am text one',
style: TextStyle(color: Colors.white),
),
Text(
'And I am text two',
style: TextStyle(color: Colors.white),
),
],
),
),
),
),
));
await expectLater(tester, doesNotMeetGuideline(textContrastGuideline));
handle.dispose();
});
testWidgets('black text on white background with merge semantics', (WidgetTester tester) async {
final SemanticsHandle handle = tester.ensureSemantics();
await tester.pumpWidget(MaterialApp(
home: Scaffold(
backgroundColor: Colors.white,
body: Center(
child: MergeSemantics(
child: Column(
mainAxisAlignment: MainAxisAlignment.center,
children: const <Widget>[
Text(
'I am text one',
style: TextStyle(color: Colors.black),
),
Text(
'And I am text two',
style: TextStyle(color: Colors.black),
),
],
),
),
),
),
));
await expectLater(tester, meetsGuideline(textContrastGuideline));
handle.dispose();
});
testWidgets('white text on white', (WidgetTester tester) async {
final SemanticsHandle handle = tester.ensureSemantics();
await tester.pumpWidget(
MaterialApp(
theme: ThemeData.light(),
home: Scaffold(
backgroundColor: Colors.white,
body: Center(
child: MergeSemantics(
child: Column(
children: const <Widget>[
Text('White', style: TextStyle(color: Colors.white)),
]
),
),
),
),
));
await expectLater(tester, doesNotMeetGuideline(textContrastGuideline));
handle.dispose();
});
testWidgets('white and black text on white', (WidgetTester tester) async {
final SemanticsHandle handle = tester.ensureSemantics();
await tester.pumpWidget(
MaterialApp(
theme: ThemeData.light(),
home: Scaffold(
backgroundColor: Colors.white,
body: Center(
child: MergeSemantics(
child: Column(
children: const <Widget>[
Text('White', style: TextStyle(color: Colors.white)),
SizedBox(height: 30),
Text('Black', style: TextStyle(color: Colors.black)),
]
),
),
),
),
));
await expectLater(tester, doesNotMeetGuideline(textContrastGuideline));
handle.dispose();
});
testWidgets('black and white text on white', (WidgetTester tester) async {
final SemanticsHandle handle = tester.ensureSemantics();
await tester.pumpWidget(
MaterialApp(
theme: ThemeData.light(),
home: Scaffold(
backgroundColor: Colors.white,
body: Center(
child: MergeSemantics(
child: Column(
children: const <Widget>[
Text('Black', style: TextStyle(color: Colors.black)),
SizedBox(height: 30),
Text('White', style: TextStyle(color: Colors.white)),
]
),
),
),
),
));
await expectLater(tester, doesNotMeetGuideline(textContrastGuideline));
handle.dispose();
});
testWidgets('irrelevant text', (WidgetTester tester) async {
final SemanticsHandle handle = tester.ensureSemantics();
await tester.pumpWidget(
MaterialApp(
theme: ThemeData.light(),
home: Scaffold(
backgroundColor: Colors.white,
body: Center(
child: Column(
children: const <Widget>[
ExcludeSemantics(
child: Text('One', style: TextStyle(color: Colors.white)),
),
SizedBox(height: 30),
MergeSemantics(
child: Text('One', style: TextStyle(color: Colors.black)),
)
],
),
),
),
));
await expectLater(tester, meetsGuideline(textContrastGuideline));
handle.dispose();
});
testWidgets('irrelevant text - passing', (WidgetTester tester) async {
final SemanticsHandle handle = tester.ensureSemantics();
await tester.pumpWidget(
MaterialApp(
theme: ThemeData.light(),
home: Scaffold(
backgroundColor: Colors.white,
body: Center(
child: Column(
children: const <Widget>[
ExcludeSemantics(
child: Text('Two', style: TextStyle(color: Colors.white)),
),
SizedBox(height: 30),
MergeSemantics(
child: Text('One', style: TextStyle(color: Colors.black)),
)
],
),
),
),
));
await expectLater(tester, meetsGuideline(textContrastGuideline));
handle.dispose();
});
testWidgets('irrelevant button', (WidgetTester tester) async {
final SemanticsHandle handle = tester.ensureSemantics();
await tester.pumpWidget(
MaterialApp(
theme: ThemeData.light(),
home: Scaffold(
backgroundColor: Colors.white,
body: Center(
child: Column(
children: const <Widget>[
ExcludeSemantics(
child: FlatButton(child: Text('One'), onPressed: null),
),
SizedBox(height: 30),
MergeSemantics(
child: Text('One', style: TextStyle(color: Colors.black)),
)
],
),
),
),
));
await expectLater(tester, meetsGuideline(textContrastGuideline));
handle.dispose();
});
testWidgets('irrelevant button - passing', (WidgetTester tester) async {
final SemanticsHandle handle = tester.ensureSemantics();
await tester.pumpWidget(
MaterialApp(
theme: ThemeData.light(),
home: Scaffold(
backgroundColor: Colors.white,
body: Center(
child: Column(
children: const <Widget>[
ExcludeSemantics(
child: FlatButton(child: Text('Two'), onPressed: null),
),
SizedBox(height: 30),
MergeSemantics(
child: Text('One', style: TextStyle(color: Colors.black)),
)
],
),
),
),
));
await expectLater(tester, meetsGuideline(textContrastGuideline));
handle.dispose();
});
testWidgets('black and white text, without MergeSemantics', (WidgetTester tester) async {
final SemanticsHandle handle = tester.ensureSemantics();
await tester.pumpWidget(
MaterialApp(
theme: ThemeData.light(),
home: Scaffold(
backgroundColor: Colors.white,
body: Center(
child: Column(
children: const <Widget>[
ExcludeSemantics(
child: Text('One', style: TextStyle(color: Colors.black)),
),
SizedBox(height: 30),
Text('One', style: TextStyle(color: Colors.white)),
],
),
),
),
));
await expectLater(tester, doesNotMeetGuideline(textContrastGuideline));
handle.dispose();
});
```
</details>
| a: tests,framework,a: accessibility,P2,team-framework,triaged-framework | low | Critical |
561,920,208 | godot | Vsync with compositor causes FPS fluctuation when maximized on 144Hz monitor | **Godot version:**
3.2 (Mono)
**OS/device including version:**
- Windows 10
- NVidia GTX 1060
**Issue description:**
After turning on VSync and VSync with compositor, the game sometimes stutters every ~2 seconds and gets stuck in a constant battle between 60 and 80-70 fps.
- I'm using one 144Hz monitor, and two 60Hz monitors
- The issue only seems to be present when the game is maximized on the 144Hz monitor, and as explained above causes the FPS to constantly switch between 60 and 80-70
- Running in fullscreen on the 144Hz monitor locks the FPS at 144Hz (which is to be expected)
- Running on any of the 60Hz monitors locks the FPS at 60Hz (which is to be expected)
- Running a debug or release build does not fix the issue
It's happening in every scene of my game, including the static title screen, which leads me to believe the game itself has minimal if any effect on the stutters.
The FPS debugger as well as an in-game FPS label show the FPS fluctuating until I moved the game to a 60Hz monitor, after which the FPS is correctly locked at 60.
**Steps to reproduce:**
- Run game maximized on 144Hz monitor and observe stutters
- Run game maximized on 60Hz monitor and stutters won't be present
- Run game fullscreen on 144Hz monitor and stutters won't be present either | bug,topic:rendering | low | Critical |
561,920,401 | godot | Mono build crash on Android when ProjectSettings/mono/profiler/enabled is set to true | **Godot version:**
Godot_v3.2-stable_mono_win64
**OS/device including version:**
Android
**Issue description:**
When exporting to Android (I did so using the little Android icon at the top right after connecting my device), the game won't start when ProjectSettings/mono/profiler/enabled is set true. Have confirmed this on an empty project
**Steps to reproduce:**
1. Create a new project
2. Set ProjectSettings/mono/profiler/enabled to true
3. Export for Android
4. Run on device
**Minimal reproduction project:**
Can be done with an empty project | bug,platform:android,confirmed,topic:dotnet | low | Critical |
561,925,472 | pytorch | [RFC] Add ability to get all remote parameters when constructing DistributedOptimizer. | ## π Feature
Currently with model parallel/RPC based training, the user is required to themselves pass in all parameters, as RRefs that participated in the backwards pass and pass those into the DistributedOptimizer. This requires the user to always add 1-2 boilerplate functions to their training code, see the tutorial by @mrshenli (https://pytorch.org/tutorials/intermediate/rpc_tutorial.html). This could be an even worse UX if it is recursive, such as if the forward pass went from node A --> B --> C and the Dist optimizer needs to be created on C.
After a discussion with @mrshenli , we think it might be feasible to provide this API ourselves. It would be tricky since we would need to know all RRefs that have parameters that need to be optimized, and discover those ourselves. The following design was proposed by @mrshenli :
`get_all_remote_params(model: nn.Module)`
1. model.get_parameters() to create local rrefs
2. vars(model) to get all attributes and pick out all RRef attributes. Then we visit all OwnerRRefs to recursively do this.
With this the user could build the DistributedOptimizer without writing code that needs to discover all parameter RRefs themselves.
Interested in feedback on what this API/implementation could look like.
cc @pietern @mrshenli @pritamdamania87 @zhaojuanmao @satgera @gqchen @aazzolini @rohan-varma @xush6528 @jjlilley @osalpekar | triaged,module: rpc | low | Minor |
561,943,318 | youtube-dl | Euscreen.eu | - [x] I'm reporting a new site support request
- [x] I've verified that I'm running youtube-dl version **2020.01.24**
- [x] I've checked that all provided URLs are alive and playable in a browser
- [x] I've checked that none of provided URLs violate any copyrights
- [x] I've searched the bugtracker for similar site support requests including closed ones
- Single video: http://euscreen.eu/item.html?id=EUS_C8664133069B4AC7B5AC68549FD44510
- Single video: http://euscreen.eu/item.html?id=EUS_3AB03731FD5070D4E118D8DB42BEF59D
- Playlist: http://www.euscreen.eu/search.html?activeFields={"provider":["RAI"]}
EUscreen is a website that provides free access to Europe's television heritage through videos, articles, images and audio from European audiovisual archives and broadcasters.
It's possible only one transfer per ip works simultaneously.
Also changing user agent to android might be required.
Playlists (search results) seem to use javascript to load more results.
Later edit: I discovered that it uses multiple stream sources (found at least 2) depending on provider of media. For example one is this open directory: https://euscreen.orf.at/content/ hosted by the provider of media itself. Others use this more complicated one:
http://lod.euscreen.eu/data/EUS_3C6BD32E727B4B1E807C7CB976A22C8F.rdf -> 329493_03_20060412_Catastrophes_tschernobyl_EUscreen_4-3.mp4 - > http://euscreen.eu/item.html?id=EUS_3C6BD32E727B4B1E807C7CB976A22C8F -> stream10.noterik.com/progressive/stream10/domain/euscreen/user/eu_dw/video/199/rawvideo/1/raw.mp4?ticket=53388157
It's a custom ticket based file/streaming server, which is open source. You can find it here:
https://github.com/Noterik/Carl
https://www.slideshare.net/nisv_rd/html-5-a-security-solution-for-euxcreenxl - on page 9 of this slide you can see the basic outline of how it works.
The ticket uses a cookie/source ip combo probably, has an expiration, and is probably limited to one connection at time. Hope someone can get it to work. | site-support-request | low | Critical |
561,954,604 | godot | Script editor gets upset if an autoload singleton references itself explicitly by name | **Godot version:**
3.2 stable
**OS/device including version:**
Windows 10 x64
**Issue description:**
When an autoload has a field element that is explicitly referred to within the autoload script, for example an autoload named `global` with a field `test`, and inside the script, it references itself like `global.test` (probably requires a design-time evaluation), this can eventually cause problems for other scripts which reference the value. Scripts which reference this autoload by name in any way will all show the same error, an error similar to "Couldn't fully load the script (Possible cyclic reference?)". Despite this, the game I observed this problem in could still run without issues.
This issue appeared when first opening my game in 3.2; the last version of Godot the project was opened in was 3.1.1 stable.
**Steps to reproduce:**
Unfortunately, I was unable to reproduce this after fixing the initial problem described above and removing the reference to `global` within my autoload. In order to clear the error message, I had to close and re-open the project. I imagine the issue occurs when first loading the project and may be more difficult to reproduce as a result.
It's unclear if this is a bug or a feature. It may still be considered undesired behavior if an autoload is *supposed* to understand explicit references to itself are to the singleton and not a cyclic reference. If 3.2 implemented better cyclic resource checking, this may be a side effect of it, but it may also be a problem in the order of loading resources for the purpose of building a "map" of values for autocomplete / validation. | bug,topic:gdscript | low | Critical |
561,969,521 | go | encoding/xml: decoding a>b>c decoration syntax should support namespaces | <!--
Please answer these questions before submitting your issue. Thanks!
For questions please use one of our forums: https://github.com/golang/go/wiki/Questions
-->
### What version of Go are you using (`go version`)?
<pre>
$ go version
go version 1.13.5 windows/amd64
</pre>
### Does this issue reproduce with the latest release?
Yes, behaves same on 1.13.7
### What operating system and processor architecture are you using (`go env`)?
Windows/amd64 but this is repeatable at least on linux
<details><summary><code>go env</code> Output</summary><br><pre>
$ go env
</pre></details>
### What did you do?
I set up a struct with
I set up this set of structures
```
type myGetValueResponseEnvelope struct {
XMLName xml.Name `xml:"http://schemas.xmlsoap.org/soap/envelope/ Envelope"`
Body myGetValueResponseBody
}
type myGetValueResponseBody struct {
XMLName xml.Name `xml:"http://schemas.xmlsoap.org/soap/envelope/ Body"`
Value string `xml:"getValueResponse>getValueReturn"`
}
```
to decode this XML:
```
<?xml version="1.0" encoding="utf-8"?>
<soapenv:Envelope xmlns:soapenv="http://schemas.xmlsoap.org/soap/envelope/" xmlns:xsd="http://www.w3.org/2001/XMLSchema" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">
<soapenv:Body>
<getValueResponse soapenv:encodingStyle="http://schemas.xmlsoap.org/soap/encoding/">
<getValueReturn xsi:type="xsd:string">69.1</getValueReturn>
</getValueResponse>
</soapenv:Body>
</soapenv:Envelope>
```
but I wanted to eliminate the second object by using a>b>c syntax. Note though that the soapenv namespace is as far as Body but not farther. So I attempted this
```
type myGetValueResponseEnvelope struct {
XMLName xml.Name `xml:"http://schemas.xmlsoap.org/soap/envelope/ Envelope"`
Value string `xml:"http//schemas.xmlsoap.org/soap/envelope Envelope>getValueResponse>getValueReturn"`
}
```
but it doesn't SEEM with a>b>c syntax that there's any way to have namespaces in all or (in my case) part of the xpath.
I can just eliminate the namespace requirement on Body and it actually decodes just fine, so this isn't an urgent issue at the moment, but some day I may want to be more selective. Regardless it seems the answer would be to split on > then ' ' then process it as usual.
| ExpertNeeded,NeedsInvestigation | low | Minor |
562,002,148 | godot | FileDialog does not place its elements correctly with the theme used in Godot Editor (?) | **Godot version:** 3.2-stable
**OS/device including version:** Debian Buster amd64
**Issue description:**
This is a minor UI nitpick, but I guess it may cause other similar (theming?) problems.
When used in an editor plugin, FileDialog does not place its items correctly (depends on the theme?).
**Steps to reproduce:**
- Use FileDialog in an editor plugin
- Set mydialog.dialog_text to something
- Set mydialog.rect_size to something (or mydialog.set_size() - by the way, what's the difference and what should be used?)
- The last line of the dialog text will be obscured by the other window elements.
- If you make it resizable and resize it with your mouse, the problem fixes itself.
**Workarounds**:
- Add a newline at the end of dialog_text
- Or use popup_centered(newsize) instead of set_size(newsize)
**Minimal reproduction project:**
Create an editor plugin and paste this into its main script:
```
tool
extends EditorPlugin
var button
var dialog
func _enter_tree():
button = Button.new()
button.text = "TEST"
add_control_to_container(EditorPlugin.CONTAINER_TOOLBAR, button)
dialog = FileDialog.new()
dialog.dialog_text = "Enter a path to something:\n(Or don't. I don't care)"
dialog.mode = FileDialog.MODE_OPEN_FILE
dialog.resizable = true
# Choose either one
dialog.rect_size = Vector2(400, 300)
# dialog.set_size(Vector2(400, 300))
button.add_child(dialog)
button.connect("pressed", dialog, "popup_centered")
func _exit_tree():
button.queue_free()
```
And click the "TEST" button.
Expected result:
Actual result:
But after we pull on it a little:
 | bug,topic:editor,confirmed,topic:gui | low | Minor |
562,006,465 | pytorch | [feature request] make torch.multinomial behaviour compliant with rnn output dimension | ## Issue description
torch.multinomial only works on single and double dimension tensors, without giving ability for choosing probability dimension.
Thus, multinomial is not directly usable on rnn output tensor, which has three dimensions (the third one being the probability dimension).
A practical improvement would be to allow torch.multinomial to work on the third dimension of any 3-dimension tensorr, in order to get the action for every batch sample and every sequence time.
A more generic improvement would be to make it work regardless of the input tensor dimension, by allowing to choose probability dimension in a new 'dim=' parameter.
On the following example, multinomial is used on a 3-dimension tensor.
There is no crash, but the result is a 1-dimension tensor of size SEQ_SIZE, as if dimension 2 & 3 had been flattened into one single dimension.
The expected results would have been a SEQ_SIZE x BATCH_SIZE tensor.
## Code example
```python
import torch
class Network(torch.nn.Module):
def __init__(self,input_size,hidden_size,output_size):
super(Network,self).__init__()
self.gru = torch.nn.GRU(input_size,hidden_size)
self.softmax = torch.nn.functional.softmax
self.multinomial = torch.multinomial
def forward(self,input,hidden):
output,hidden = self.gru(input,hidden)
policy = self.softmax(output,dim=2)
action = self.multinomial(policy,num_samples=1)
return hidden,policy,action
SEQ_SIZE = 100
BATCH_SIZE = 20
INPUT_SIZE = 10
HIDDEN_SIZE = 20
OUTPUT_SIZE = 15
network = Network(INPUT_SIZE,HIDDEN_SIZE,OUTPUT_SIZE)
input = torch.rand(SEQ_SIZE,BATCH_SIZE,INPUT_SIZE)
hidden = torch.rand(1,BATCH_SIZE,HIDDEN_SIZE)
hidden,policy,action = network(input,hidden)
print(policy.size())
print(action.size())
```
## System Info
PyTorch version: 1.0.1
Is debug build: No
CUDA used to build PyTorch: None
OS: Microsoft Windows 10 Professionnel
GCC version: Could not collect
CMake version: Could not collect
Python version: 3.7
Is CUDA available: No
CUDA runtime version: No CUDA
GPU models and configuration: No CUDA
Nvidia driver version: No CUDA
cuDNN version: No CUDA
Versions of relevant libraries:
[pip] numpy==1.16.5
[pip] numpydoc==0.9.1
[pip] torch==1.0.1
[conda] _pytorch_select 1.1.0 cpu
[conda] _tflow_select 2.3.0 mkl
[conda] blas 1.0 mkl
[conda] libmklml 2019.0.5 0
[conda] mkl 2019.4 245
[conda] mkl-service 2.3.0 py37hb782905_0
[conda] mkl_fft 1.0.14 py37h14836fe_0
[conda] mkl_random 1.1.0 py37h675688f_0
[conda] pytorch 1.0.1 cpu_py37h39a92a0_0
[conda] tensorflow 2.0.0 mkl_py37he1bbcac_0
[conda] tensorflow-base 2.0.0 mkl_py37hd1d5974_0
cc @fritzo @neerajprad @alicanb @vishwakftw @ezyang @SsnL @gchanan | module: distributions,module: bc-breaking,feature,triaged | low | Critical |
562,014,551 | rust | Audit src/rustllvm/RustWrapper.cpp for C APIs that are now in upstream LLVM. | Specifically, functions which are implemented in the oldest supported LLVM version.
- [x] LLVMRustSetComdat => Comdat.h https://github.com/rust-lang/rust/pull/131876
- [ ] LLVMRustModuleBuffer => Core.h::LLVMMemoryBufferRef
- [ ] LLVMRustDI* => Debuginfo.h::LLVMDI*
We can also consider to polyfill some functions that are available in our fork, but not in some older supported version, using the same name and signature, instead of our own.
cc @alexcrichton @nagisa @nikic @hanna-kruppe | C-cleanup,A-LLVM,T-compiler | low | Critical |
562,030,787 | godot | FileDialog minor UI inconveniences | **Godot version:** 3.2-stable
**OS/device including version:** Debian Buster amd64
**Issue description:**
Currently, FileDialog behaves very differently from what you would expect in any other system file dialog. With a few minor changes, it would be much more "pleasant to use". Those don't deserve separate issues because it's all one thing - "Fix FileDialog design".
- "Open" button state (enabled/disabed) is determined by selection only, not by what's typed.
This is pretty confusing. Currently, the "Open" button is disabled when nothing is selected, and enabled when you select something. This leads to a lot of confusion when coupled with typing things manually. I can type the file name in the bottom LineEdit, but "Open" is still disabled. But I can press "Enter", and it will work. Or I can select a file and then type a nonexistent filename - the button is enabled, but clicking it does nothing. My suggestion is: either disable the button "properly" (when nothing is selected AND there is no text in LineEdit), or don't disable it at all (error checking is already there, so it won't be any worse).
- Entering a full path/name manually (instead of navigating to it) should work.
For example, the dialog is asking you to locate a certain file on your filesystem. Typing "/usr/bin/myfile" is MUCH faster than navigating to that file, especially with folders containing a lot of files. Currently, typing a filename is possible, but typing a full path+name does not work.
- Typing a path and hitting "Enter" should navigate to this path.
Currently, it is possible to type the path in the top LineEdit to navigate there, but not in the bottom one. So we have to click the top one, delete everything there (no "Clear" button!), enter the path, then click the bottom one, enter the file name, wonder why "Open" is still not active, and hit "Enter" hoping for the best.
Some of those may be tricky to implement considering various modes of the same FileDialog, but we can have a discussion here about it. Maybe there are other "usually present" features I have missed.
I've tried to tackle such a "cosmetic polish" myself, but no, I can't handle C++ in an unfamiliar project... | enhancement,usability,topic:gui | low | Critical |
562,038,587 | svelte | Strange behaviour with interrupted crossfade transitions | Similar to https://github.com/sveltejs/svelte/issues/3398
Here is a very basic setup to test for the crossfade transition:
https://svelte.dev/repl/7b633681d5a849968771c4fe9b7e7536?version=3.18.1
The duration is set to `2s` so you have time to interrupt the transition by clicking a second time on the button.
On the first interruption, the transition is working as expected: the forward transition stops, and the backward transition starts where the forward transition stopped.
However, on second and following interruptions, the transition isn't smooth anymore. The crossfade fallback is called for the forward transition, and the backward transition doesn't start where the transition was stopped, but where it was stopped in the first interruption.
You will have to reload the script to observe the expected behaviour again. | bug | low | Minor |
562,046,676 | next.js | Swipe back on mobile browser with getInitialProps flickers the previous page | # Bug report
## Describe the bug
On mobile browsers (tested with Chrome and Firefox), swiping back or forward on a dynamic page (one that gets data from `getInitialProps`) will sometimes "flash" the previous page while the content is loading. [Here is a video](https://share.getcloudapp.com/2NurgWDe) that shows the problem.
## To Reproduce
1. Create a next.js app with the following pages:
`index.js`
```
import Link from "next/link";
export default function Index() {
return (
<div>
<p><Link href="data"><a>Link</a></Link></p>
</div>
);
}
```
`data.js`
```
const Index = props => {
return (
<div>
<h1>Test mobile back</h1>
<ul>
{props.data.map(name => (
<li key={name}>
<a>{name}</a>
</li>
))}
</ul>
</div>
)
};
function sleep(ms) {
return new Promise((resolve) => {
setTimeout(resolve, ms);
});
}
Index.getInitialProps = async function() {
await sleep(1000)
return {
data: ["one", "two", "three", "four", "five", "six"]
};
};
export default Index;
```
2. Run it, and access it with a mobile browser.
3. Click on the link, you are now on a page with "one", "two"...
4. Swipe back
5. Now swipe forward. Notice the "flash" of the previous screen.
Now, add `"seven"` to the data returned in `data.js`, and notice the problem doesn't happen anymore
## Expected behavior
No flash of the previous page when swiping forward or backward on mobile browser. [This is what happens now](https://share.getcloudapp.com/2NurgWDe) vs [this is what should happen](https://share.getcloudapp.com/p9u5vYDA)
## System information
- OS: MacOS
- Browser (if applies): Mobile Safari, chrome and firefox
- Version of Next.js: 9.2.1
| good first issue,Navigation | medium | Critical |
562,058,655 | go | x/exp/apidiff: resolution of type aliases depends on type names | ```go
package v1
type T interface { F() }
func F(T) {}
```
```go
package v2
import "example.com/x/common"
type T = common.T2
func F(T) {}
```
```go
package common
type T2 interface { F() }
```
```shell
$ apidiff example.com/x/v1 example.com/x/v2
Incompatible changes:
- F: changed from func(T) to func(example.com/x/common.T2)
- T: changed from T to example.com/x/common.T2
```
This is obviously wrong: `v1` and `v2` have identical APIs; we've just extracted the `v2.T` type into a separate package.
At first I thought apidiff wasn't keeping track of type aliases, but if I keep the exact same API but keep the *name* of the type the same (`common.T`, not `common.T2`) then it reports no API change. | NeedsInvestigation | low | Minor |
562,064,480 | material-ui | [Switch] ref attribute is not the root element | - [x] The issue is present in the latest release.
- [x] I have searched the [issues](https://github.com/mui-org/material-ui/issues) of this repository and believe that this is not a duplicate.
## Current Behavior π―
When attempting to use the width of a Switch component, I don't get the width of the surrounding span.
## Expected Behavior π€
When getting the offsetWidth of the Switch's ref, it should be the width of the entire component.
## Steps to Reproduce πΉ
Attempt to use the ref component and retrieve the width. Set a component to marginLeft to share that width. (I've also reset the margin).
https://codesandbox.io/s/gifted-joliot-gxzni
## Context π¦
I would expect the helper text to align with the label of the switch (see codesandbox example)
I noticed that the ref was pointing to SpanBase: https://github.com/mui-org/material-ui/blob/7f4b81ffb7b76f73319b38f1b9f287f43c74e6d0/packages/material-ui/src/Switch/Switch.js#L162-L187
Perhaps the ref should be the span and an 'innerRef' would point to the SpanBase? I'm unsure of the right way forward. Maybe I'm misinterpreting what "root" should be, however I would like to get the width of the Switch itself, parent span CSS included.
## Your Environment π
| Tech | Version |
| ----------- | ------- |
| Material-UI | v4.9.1 |
| React | v16.12.0 |
| Browser | Chrome |
| bug π,breaking change,component: switch | low | Major |
562,069,465 | flutter | [google_sign_in] Retrieve authorization code instead of token | ## Use case
- I want to implement `Google sign in` in my app with an option to specify the `responseType="code"` to get an authorization code. (it's not token, not access token!)
- Click on the `Google sign in` button will bring up a popup window for user to select account. After user select one and the window closes, you'll get the code from the button's callback function.
- Send this code to backend server's JWT endpoint. And use JWT token to access protected resources.
## Proposal
- Provide an option in SignIn function to specify responseType like in [react-google-login](https://github.com/anthonyjgrove/react-google-login) | p: google_sign_in,package,c: proposal,team-ecosystem,P3,triaged-ecosystem | low | Minor |
562,072,178 | rust | MIR SourceScopes stay around even when all their uses were removed. | We already have a testcase, namely [`simplify_try`](https://github.com/rust-lang/rust/blob/85ffd44d3d86214fc06be4add039e26f85261a2b/src/test/mir-opt/simplify_try.rs), which replaces enough of the original body to make some `SourceScope`s unused.
However, despite no statements/terminators using those scopes anymore, they stick around.
The fact that they're gone is in itself a problem (debuginfo is lost, see comments on #66282), but we could argue that `SourceScope`s only used in unreachable code should still be removed, e.g.:
```rust
if false {
let x = 123;
}
```
There is no reason to have debuginfo for `x` tracked anywhere once the `x = 123;` block is removed.
@rust-lang/wg-mir-opt
| A-debuginfo,C-enhancement,P-low,T-compiler,A-MIR | low | Critical |
562,073,500 | vscode | Allow to use decorations in quick input (e.g. for editors picker) | For the recently used menu (which is bound to <kbd>Ctrl</kbd> + <kbd>Tab</kbd>) I would like to see git decoration status (modified/untracked/...) just like they work for **OPEN EDITORS** View.
 | feature-request,file-decorations,quick-open | medium | Major |
562,075,008 | pytorch | QNNPACK: GNU aarch64 assembler does not support 4s on neon mov | Unlike clang, GNU assembler does not support 4s type on neon mov and gives these errors:
> 8x8-dq-aarch64-neon.S: Assembler messages:
> 8x8-dq-aarch64-neon.S:657:
> Error: operand mismatch -- `mov V8.4s,V9.4s'
> Info: did you mean this?
> Info: mov v8.8b, v9.8b
> Info: other valid variant(s):
> Info: mov v8.16b, v9.16b
Changing to 16b fixes the issue. | oncall: mobile | low | Critical |
562,077,754 | TypeScript | `typescript.SymbolTable` does not properly implement the ES6 Map interface | <!-- π¨ STOP π¨ π¦π§π’π£ π¨ πΊπ»πΆπ· π¨
Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Even if you think you've found a *bug*, please read the FAQ first, especially the Common "Bugs" That Aren't Bugs section!
Please help us by doing the following steps before logging an issue:
* Search: https://github.com/Microsoft/TypeScript/search?type=Issues
* Read the FAQ: https://github.com/Microsoft/TypeScript/wiki/FAQ
Please fill in the *entire* template below.
-->
<!--
Please try to reproduce the issue with the latest published version. It may have already been fixed.
For npm: `typescript@next`
This is also the 'Nightly' version in the playground: http://www.typescriptlang.org/play/?ts=Nightly
-->
**TypeScript Version:** 3.7.3
The [`typescript.SymbolTable`] is like an ES6 `Map` -- typescript.d.ts [describes it](https://github.com/microsoft/TypeScript/blob/master/lib/typescript.d.ts#L2317) as 'based on the ES6 Map interface'.
However, the underlying interface[ `typescript.UnderscoreEscapedMap`] does not implement the [`Map`] interface, or the [`Iterable`], or [`Iterator`] protocols. This means it's not possible to iterate over properly without shim code, which varies from manually implementing the Iterator protocol (annoying!) to overriding the type with `as Map<ts.__String, ts.Symbol>` (bad!).
<details>
<summary>Code Example</summary>
```typescript
import * as ts from "typescript";
const p = ts.createProgram(["t.d.ts"], {});
const c = p.getTypeChecker();
p.getSourceFiles().map(f => {
f.forEachChild(n => {
if (!ts.isModuleDeclaration(n)) return;
const s = c.getSymbolAtLocation(n.name);
if (!s) return;
const scanMembers = (s: ts.Symbol) => {
if (s.valueDeclaration === undefined)
console.log("missing valueDeclaration on", s.getName());
type m = Iterator<any>
if (!s.exports) return;
if (!(Symbol.iterator in s.exports))
return console.log("not iterable", s.getName())
for (let [/*name*/, member] of (s.exports as Map<ts.__String, ts.Symbol>)) {
scanMembers(member);
}
}
scanMembers(s);
})
})
```
</details>
`typescript.UnderscoreEscapedMap` is not recognized as a `Map` due to `clear()`, `delete()`, `set()`, `[Symbol.toStringTag]` and `[Symbol.iterator]` being `undefined.`
<details>
<summary>Testing map assertion</summary>
```typescript
// Type 'ReadonlyUnderscoreEscapedMap<any>' is missing the following properties
// from type 'Map<any, any>': clear, delete, set, [Symbol.iterator],
// [Symbol.toStringTag] ts(2739)
const x: Map<any, any> = void 0 as any as ts.ReadonlyUnderscoreEscapedMap<any>
```
</details>
Perhaps this is a compiler internals issue, as using `as Map<ts.__String, ts.Symbol>` makes `SymbolTable`s work without issue. If it's not, the fix should be as simple as replacing [`typescript.UnderscoreEscapedMap`] with `Map` and [`typescript.ReadonlyUnderscoreEscapedMap`] with `ReadonlyMap`.
[`typescript.ReadonlyUnderscoreEscapedMap`]: https://github.com/microsoft/TypeScript/blob/master/lib/typescript.d.ts#L2302
[`typescript.UnderscoreEscapedMap`]: https://github.com/microsoft/TypeScript/blob/master/lib/typescript.d.ts#L2312
[`typescript.SymbolTable`]: https://github.com/microsoft/TypeScript/blob/master/lib/typescript.d.ts#L2318
[`Map`]: https://github.com/microsoft/TypeScript/blob/master/lib/lib.es2015.collection.d.ts#L21
[`Iterable`]: https://github.com/microsoft/TypeScript/blob/master/lib/lib.es2015.iterable.d.ts#L50
[`Iterator`]: https://github.com/microsoft/TypeScript/blob/master/lib/lib.es2015.iterable.d.ts#L43
<!-- Search terms you tried before logging this (so others can find this issue more easily) -->
**Search Terms:**
**Code**
```ts
import * as ts from "typescript";
const p = ts.createProgram(["t.d.ts"], {});
const c = p.getTypeChecker();
p.getSourceFiles().map(f => {
f.forEachChild(n => {
if (!ts.isModuleDeclaration(n)) return;
const s = c.getSymbolAtLocation(n.name);
if (!s) return;
const scanMembers = (s: ts.Symbol) => {
if (s.valueDeclaration === undefined)
console.log("missing valueDeclaration on", s.getName());
type m = Iterator<any>
if (!s.exports) return;
if (!(Symbol.iterator in s.exports))
return console.log("not iterable", s.getName())
// error!!
for (let [/*name*/, member] of s.exports) {
scanMembers(member);
}
}
scanMembers(s);
})
})
```
**Expected behavior:**
It should be possible to iterate over a `typescript.SymbolTable`.
**Actual behavior:**
`typescript.SymbolTable` is considered not iterable.
| Suggestion,API,Awaiting More Feedback | low | Critical |
562,086,685 | go | proposal: spec: simplify error handling - error passing with "pass" | # Introduction
For the most part, I like the simplicity of error handling in Go, but I would very much like a less verbose way to pass errors.
Passing errors should still be explicit and simple enough to understand. This proposal builds on top of the many existing proposals and suggestions, and attempts to fix the problems in the [proposed try built-in](https://github.com/golang/go/issues/32437) see [design doc](https://github.com/golang/proposal/blob/master/design/32437-try-builtin.md). Please read the original proposal if you haven't already some of the questions may already be answered there.
Would you consider yourself a novice, intermediate, or experienced Go programmer?
- I have been using Go almost exclusively for the past two years, and I have been a developer for the past 10 years.
What other languages do you have experience with?
- C, Java, C#, Python, Javascript, Typescript, Kotlin, Prolog, Rust, PHP ... and others that I don't remember.
Would this change make Go easier or harder to learn, and why?
- It may make Go slightly harder to learn because its an additional keyword.
Who does this proposal help, and why?
- This proposal helps all Go developers in their daily use of the language because it makes error handling less verbose.
# Proposal
### What is the proposed change?
Adding a new keyword `pass`.
pass expr
Pass statements may only be used inside a function with at least one result parameter where the last result is of type error.
Pass statements take an expression. The expression can be a simple error value. It can also be a function
or a method call that returns an error.
Calling `pass` with any other type or a different context will result in a compile-time error.
If the result of the expression is `nil`, `pass` will not perform any action, and execution continues.
If the result of the expression `!= nil`, `pass` will return from the function.
- For unnamed result parameters, `pass` assumes their default "zero" values.
- For named result parameters, `pass` will return the value they already have.
This works similar to the proposed `try` built-in.
**Is this change backward compatible?**
Yes.
**Show example code before and after the change.**
A simple example:
before:
f, err := os.Open(filename)
if err != nil {
return ..., err
}
defer f.Close()
after:
f, err := os.Open(filename)
pass err
defer f.Close()
In the example above, if the value of err is `nil`. it is equivalent to calling `pass` in the following way (does not perform any action):
pass nil
Consequently, the following is expected to work with `pass` (passing a new error)
pass errors.New("some error")
Since `pass` accepts an expression that must be evaluated to an `error` . We can create handlers without any additional changes to the language.
For example, the following [`errors.Wrap()`](https://github.com/pkg/errors/blob/614d223910a179a466c1767a985424175c39b465/errors.go#L184) function works with `pass`.
// Wrap returns an error annotating err with a stack trace
// at the point Wrap is called, and the supplied message.
// If err is nil, Wrap returns nil.
func Wrap(err error, message string) error {
if err == nil {
return nil
}
err = &withMessage{
cause: err,
msg: message,
}
return &withStack{
err,
callers(),
}
}
Because `Wrap` returns `nil` when `err == nil`, you can use it to wrap errors:
f, err := os.Open(filename)
pass errors.Wrap(err, "couldn't open file")
the following does not perform any action (because `Wrap` will return `nil`):
pass errors.Wrap(nil, "this pass will not return")
You can define any function that takes an error to add logging, context, stack traces ... etc.
func Foo(err Error) error {
if err == nil {
return nil
}
// wrap the error or return a new error
}
To use it
f, err := os.Open(filename)
pass Foo(err)
`pass` is designed specifically for passing errors and nothing else.
### Other examples:
(Example updated to better reflect different usages of `pass`)
Here's an example in practice. Code from [`codehost.newCodeRepo()`](https://github.com/golang/go/blob/3f51350c706c8ff663f12867bcfec98aa9fc46bf/src/cmd/go/internal/modfetch/codehost/git.go#L72) (found by searching for `err != nil` - comments removed)
This example shows when it's possible to use `pass`, and how it may look like in the real world.
before:
func newGitRepo(remote string, localOK bool) (Repo, error) {
r := &gitRepo{remote: remote}
if strings.Contains(remote, "://") {
var err error
r.dir, r.mu.Path, err = WorkDir(gitWorkDirType, r.remote)
if err != nil {
return nil, err
}
unlock, err := r.mu.Lock()
if err != nil {
return nil, err
}
defer unlock()
if _, err := os.Stat(filepath.Join(r.dir, "objects")); err != nil {
if _, err := Run(r.dir, "git", "init", "--bare"); err != nil {
os.RemoveAll(r.dir)
return nil, err
}
if _, err := Run(r.dir, "git", "remote", "add", "origin", "--", r.remote); err != nil {
os.RemoveAll(r.dir)
return nil, err
}
}
r.remoteURL = r.remote
r.remote = "origin"
} else {
if strings.Contains(remote, ":") {
return nil, fmt.Errorf("git remote cannot use host:path syntax")
}
if !localOK {
return nil, fmt.Errorf("git remote must not be local directory")
}
r.local = true
info, err := os.Stat(remote)
if err != nil {
return nil, err
}
if !info.IsDir() {
return nil, fmt.Errorf("%s exists but is not a directory", remote)
}
r.dir = remote
r.mu.Path = r.dir + ".lock"
}
return r, nil
}
after:
func newGitRepo(remote string, localOK bool) (Repo, error) {
r := &gitRepo{remote: remote}
if strings.Contains(remote, "://") {
var err error
r.dir, r.mu.Path, err = WorkDir(gitWorkDirType, r.remote)
pass err
unlock, err := r.mu.Lock()
pass err
defer unlock()
if _, err := os.Stat(filepath.Join(r.dir, "objects")); err != nil {
if _, err := Run(r.dir, "git", "init", "--bare"); err != nil {
os.RemoveAll(r.dir)
pass err
}
if _, err := Run(r.dir, "git", "remote", "add", "origin", "--", r.remote); err != nil {
os.RemoveAll(r.dir)
pass err
}
}
r.remoteURL = r.remote
r.remote = "origin"
} else {
if strings.Contains(remote, ":") {
pass fmt.Errorf("git remote cannot use host:path syntax")
}
if !localOK {
pass fmt.Errorf("git remote must not be local directory")
}
r.local = true
info, err := os.Stat(remote)
pass err
if !info.IsDir() {
pass fmt.Errorf("%s exists but is not a directory", remote)
}
r.dir = remote
r.mu.Path = r.dir + ".lock"
}
return r, nil
}
### What is the cost of this proposal? (Every language change has a cost).
* How many tools (such as vet, gopls, gofmt, goimports, etc.) would be affected?
Because this is a new keyword, I'm not sure how much some of these tools would be affected,
but they shouldn't need any significant changes.
* What is the compile time cost?
Compile time cost may be affected because the compiler may need to
perform additional optimizations to function or method calls used with `pass`.
* What is the run time cost?
This depends on the implementation. Simple expressions like this:
pass err
should have equivalent runtime cost to the current `err != nil`.
However, function or method calls will add run time cost and this will largely depend on the implementation.
### Can you describe a possible implementation?
For the simple case, the compiler may be able to expand `pass` statements
pass err
to
if err != nil {
return result paramters ...
}
For function or method calls there maybe a better way to do it
possibly inline these calls for common cases?
### How would the language spec change?
The new keyword `pass` must be added to the language spec with a more formal definition.
### Orthogonality: how does this change interact or overlap with existing features?
In some cases, `pass` may overlap with a `return` statement.
func someFunc() error {
if cond {
pass errors.New("some error")
}
...
instead of
func someFunc() error {
if cond {
return errors.New("some error")
}
...
It may not be clear which keyword should be used here.
`pass` is only useful in these cases when there is multiple result parameters.
func someFunc() (int, int, error) {
if cond {
pass errors.New("some error")
}
...
instead of
func someFunc() (int, int, error) {
if cond {
return 0, 0, errors.New("some error")
}
...
(Edited to make example more clear)
### Is the goal of this change a performance improvement?
No
### Does this affect error handling?
Yes, here is the following advantages of `pass` and how it may differ [from other proposals](https://github.com/golang/go/issues?utf8=%E2%9C%93&q=label%3Aerror-handling).
#### Advantages to using `pass`
* `pass` is still explicit.
* Supports wrapping errors and using simple handlers without new keywords such `handle` ... etc.
* it makes it easier to scan code. Avoids confusing `err == nil` with `err != nil`. Since `pass` only returns when error is not `nil` in all cases.
* should work fairly easily with existing error handling libraries.
* should work with breakpoints
* much less verbose.
* Fairly simple to understand.
### Is this about generics?
No
Edit: Updated to follow [the template](https://go.googlesource.com/proposal/+/refs/heads/master/go2-language-changes.md) | LanguageChange,Proposal,error-handling,LanguageChangeReview | high | Critical |
562,086,706 | godot | iOS export completely overwrites directories | **Godot version:**
3.2
**OS/device including version:**
macOS 10.15.2
**Issue description:**
I accidentally exported an iOS project out to the same directory my game project was in. Because the names were the same, it overwrote my entire game directory without warning.
**Steps to reproduce:**
Export iOS project to parent directory containing game project, save as same name. Instead of throwing a warning up or just adding files to the directory, it overwrites everything. | bug,platform:ios,topic:editor,topic:porting,confirmed | low | Major |
562,090,963 | rust | rust-mingw is missing libssp* | The GCC compiler that comes with rust-mingw understands `-fstack-protector-strong` and emits stack-protector code, but the build further fails to link with messages like:
```
C:\Users\task_1581171456\repo\git-core\libcinnabar.a(cinnabar-fast-import.o):cinnabar-fast-import.c:(.text+0x291): undefined reference to `__stack_chk_fail'
```
The missing symbol is normally added by `gcc` to the `ld` command line via `-lssp_nonshared -lssp`, when it's passed `-fstack-protector-strong` during linking. Adding `-fstack-protector-strong` via `RUSTFLAGS=-Clink-arg=-fstack-protector-strong` doesn't actually work because of `-nostdlib` that rust adds on its own, but `RUSTFLAGS=-Clink-arg=-lssp_nonshared -Clink-arg=-lssp` doesn't work either because libssp* is not provided by rust-mingw. | O-windows-gnu,T-infra,C-bug | low | Major |
562,092,380 | rust | Can't use ASAN with Xcode clang | When building rust code with `-Zsanitizer=address` and following through with `-fsanitize=address` for C/C++ code that might be compiled by build scripts, the build ends up failing with (using Xcode 11.3 on travis):
```
= note: Undefined symbols for architecture x86_64:
"___asan_version_mismatch_check_apple_1100", referenced from:
_asan.module_ctor in libcinnabar.a(cinnabar-fast-import.o)
_asan.module_ctor in libcinnabar.a(cinnabar-helper.o)
_asan.module_ctor in libcinnabar.a(cinnabar-notes.o)
_asan.module_ctor in libcinnabar.a(cinnabar-util.o)
_asan.module_ctor in libcinnabar.a(hg-bundle.o)
_asan.module_ctor in libcinnabar.a(hg-connect.o)
_asan.module_ctor in libcinnabar.a(hg-connect-http.o)
...
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
```
There's probably nothing rust can do about it, so this is more about SEOing for people who might hit the same problem. | A-linkage,O-macos,T-compiler,A-sanitizers,C-bug | low | Critical |
562,095,542 | go | sync: shrink types in sync package | # Proposal: shrink types in sync package
## Current API
The types in the sync package make use of semaphore operations provided by the runtime package. Specifically, they use the following two APIs
`semacquire(s *uint32)`: waits until `*s > 0` and atomically decrements it.
`semrelease(s *uint32)`: atomically increments `*s` and notifies any goroutine blocked in a `semacquire` (if any).
Each semaphore logically manages a queue of goroutines. The sync types store their atomically-modified state separate from their semaphores; for this reason, semaphores have to support out-of-order operations (e.g. when unlocking a `sync.Mutex`, you could have a `semrelease` show up to the semaphore 'before' a corresponding `semacquire`). The separation into atomic state and semaphores also results in the sync types having a larger memory footprint.
## Proposed new API
Let's consider a slightly different API for queueing and dequeueing goroutines.
`semqueue(s *uint32, mask uint32, cmp uint32, bit uint8) bool`: checks `(*s & mask) == cmp`; if false, will immediately return false (indicating 'barging'). Otherwise, puts the calling goroutine to sleep; if this goroutine is the first to sleep for the given `s` and `bit`, will also perform `*s = *s | (1 << bit)`.
`semdequeue(s *uint32, bit uint8, dequeueAll bool) int`: wakes up 1 goroutine sleeping on a corresponding `semqueue` call with a matching `s` and `bit` (or all, if `dequeueAll` is true). If there are no more goroutines sleeping, then will unset the corresponding `bit` in `*s`: `*s = *s & ^(1 << bit)`. Returns the number of woken goroutines.
Notes about this API:
The names listed above are placeholders (other suggestions welcome).
All of the operations for the given function are atomic (by making use of a lock keyed on `s`).
Also, the real signatures will likely need to be more complicated to support mutex profiling, and FIFO vs LIFO queueing.
## Benefits
Given this kind of API, I believe we could shrink the types in the `sync` package. This is because this new API only ever modifies a single bit in an atomic word, so all the other bits are available to store atomic state. We can manage multiple logical queues using the same 4-byte atomic word; this will allow it to handle types like `sync.RWMutex` that have a queue for readers and a queue for writers. Here are the possible savings for reimplementing various types in the `sync` package:
| Type | Current Size (bytes) | New Size (bytes) |
| --- | --- | --- |
| `sync.Once` | 12 | 4 |
| `sync.Mutex` | 8 | 4 |
| `sync.RWMutex` | 24 | 4 |
These are the ones I'm fairly confident about. I also think we can shrink `sync.Waitgroup`, and `sync.Cond` (the former from 12 bytes to 4 bytes, and I think we can shave off 28 bytes from the latter), but I'm less sure of these two as I'm unfamiliar with their implementations.
Also, while this isn't the goal, I think this might also improve the performance of `(*sync.RWMutex).Unlock`. It currently repeatedly calls `semrelease` in a loop to wake readers, acquiring and releasing locks for each iteration. The API above offers batch dequeue functionality, which will allow us to avoid a number of atomic operations.
## Backwards Compatibility
This is only modifying internal details of the Go runtime, so from that perspective it should be backwards compatible. There are two other considerations here:
If any users are carefully sizing their types to avoid false sharing or to align with cache-line boundaries, changing the size of types in `sync` could be problematic for them.
There are users who are using `go:linkname` to directly invoke `semacquire` and `semrelease`. See [gVisor](https://github.com/google/gvisor/blob/17b9f5e66238bde1e4ed3bd9e5fb67342c8b58ec/pkg/sync/downgradable_rwmutex_unsafe.go#L27) for an example of this. So, even if we convert all uses in the standard library, we will likely want to have these functions stick around for a little while.
## Edits
- Reordered types in order of implementation simplicity
- Increased size of `sync.RWMutex` from 4 to 8 bytes (see comments for explanation)
- Decreased size of `sync.RWMutex` back down to 4 bytes (see comments for explanation) | NeedsDecision | medium | Major |
562,098,537 | TypeScript | Feat: Non-Detail view for Error Messages | ## Suggestion
The following is a case where I'm missing a single field from an object:
<img width="354" alt="Screen Shot 2020-02-08 at 6 08 45 PM" src="https://user-images.githubusercontent.com/14002040/74093917-47e99500-4a9e-11ea-886a-78759f601d50.png">
<img width="925" alt="Screen Shot 2020-02-08 at 6 08 57 PM" src="https://user-images.githubusercontent.com/14002040/74093918-48822b80-4a9e-11ea-8948-3f3933822fc7.png">
<img width="401" alt="Screen Shot 2020-02-08 at 6 09 02 PM" src="https://user-images.githubusercontent.com/14002040/74093919-4a4bef00-4a9e-11ea-94b6-2a47e92c79ea.png">
The amount of detail in this error message is very useful for extreme scenarios, but in a general day to day scenario, it's a bit overwhelming.
It would be really nice to have detailed messages like this hidden behind a "See More" item, and instead show the simplest form of the error. In this case the error could be
```
missing prop "fields" of type "object"
```
I don't need to know what the object type is, or what the parent type is. I can just get that error message later.
## Use Cases
Almost 100% of the errors I get in TypeScript would be improved by this. It's very rare that I want to know all the information, and almost always that I just want a simple reminder of what tiny slip up it is.
## Checklist
My suggestion meets these guidelines:
* [x] This wouldn't be a breaking change in existing TypeScript/JavaScript code
* [x] This wouldn't change the runtime behavior of existing JavaScript code
* [x] This could be implemented without emitting different JS based on the types of the expressions
* [x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
* [x] This feature would agree with the rest of [TypeScript's Design Goals](https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals).
| Suggestion,Needs Proposal | low | Critical |
562,116,340 | TypeScript | Control flow doesn't affect spreaded properties | **TypeScript Version:** 3.7.4
<!-- Search terms you tried before logging this (so others can find this issue more easily) -->
**Search Terms:** `react required props`
**Code**
```tsx
import React from 'react'
type Props = {
foo?: string
}
const Example = (props: Props) => (
<>
{/* [bug?] Throws an error about required prop, despite null check */}
{props.foo && <Component {...props} />}
{/* Shows an error, as expected, because lack of null-check */}
<Component {...{ ...props, foo: props.foo }} />
{/* Workaround 1: No error */}
{props.foo && <Component {...{ ...props, foo: props.foo }} />}
{/* Shows an error, as expected, because lack of null-check */}
<Component {...props} foo={props.foo} />
{/* Workaround 2: No error */}
{props.foo && <Component {...props} foo={props.foo} />}
</>
)
const Component = ({ foo }: Required<Props>) => <p>{foo}</p>
export default Example
```
**Expected behavior:**
TypeScript would detect that we're inside a null check, and treat the checked property as non-nullish.
**Actual behavior:**
TypeScript doesn't notice that the checked property is non-null, because it's inside an object spread.
As a workaround, the null-check will still work if the property is explicitly added to the spread object (workaround 1) or explicitly passed as a prop (workaround 2).
| Bug | low | Critical |
562,120,484 | opencv | Problem for Simple Alpha Blending | <!--
If you have a question rather than reporting a bug please go to http://answers.opencv.org where you get much faster responses.
If you need further assistance please read [How To Contribute](https://github.com/opencv/opencv/wiki/How_to_contribute).
Please:
* Read the documentation to test with the latest developer build.
* Check if other person has already created the same issue to avoid duplicates. You can comment on it if there already is an issue.
* Try to be as detailed as possible in your report.
* Report only one problem per created issue.
This is a template helping you to create an issue which can be processed as quickly as possible. This is the bug reporting section for the OpenCV library.
-->
##### System information (version)
<!-- Example
- OpenCV => 3.1
- Operating System / Platform => Windows 64 Bit
- Compiler => Visual Studio 2015
-->
- OpenCV => 4.2.0
- Operating System / Platform => Windows 64 Bit
- Compiler => Visual Studio 2019
##### Detailed description
<!-- your description -->
If running following the code for alpha blending, it output following results.
```cpp
#include <opencv2/opencv.hpp>
int main( int argc, char* argv[] )
{
// Read Image
cv::Mat src = cv::imread( "lena.jpg" );
// Alpha Blend with Blue, Green, and Red
double alpha = 0.6;
double beta = 1.0 - alpha;
cv::Mat blend_b = alpha * src + beta * cv::Scalar( 255, 0, 0 ); // Blue (issue case!)
cv::Mat blend_g = alpha * src + beta * cv::Scalar( 0, 255, 0 ); // Green
cv::Mat blend_r = alpha * src + beta * cv::Scalar( 0, 0, 255 ); // Red
// Show Image
cv::imshow( "src" , src );
cv::imshow( "blue" , blend_b );
cv::imshow( "green", blend_g );
cv::imshow( "red" , blend_r );
cv::waitKey( 0 );
return 0;
}
```
The output of alpha blending with green and red is correct result.
These turned greenish color and reddish color.
But, the output of alpha blending with blue has become whitish color.
It is not expected output. It should turn to bluish color.
If changes blend color to the close to blue such as <code>cv::Scalar(255, 1, 0)</code> (just add one to green), it turn correctly to bluish color.
```cpp
cv::Mat blend_b = alpha * src + beta * cv::Scalar( 255, 1, 0 ); // Close to Blue
```
##### Related issues
This seems to be related to this issue #14738.
I think this is due to the difference between calculation results of cv::Mat and cv::MatExpr.
Therefore, I know that this issue can be avoided by changing to following code.
```patch
- cv::Mat blend_b = alpha * src + beta * cv::Scalar( 255, 0, 0 ); // Blue
+ cv::Mat blend_b = cv::Mat( alpha * src ) + beta * cv::Scalar( 255, 0, 0 ); // Blue
```
But, I think this is a bug of corner case. It should be fixed.
What do you think? Thanks, | bug,category: core,affected: 3.4,confirmed | medium | Critical |
562,137,182 | pytorch | Python package using CMake | ## π Feature
<!-- A clear and concise description of the feature proposal -->
Use existing CMake build to create a python .whl file
## Motivation
The CMake build is clear and well documented. It would be helpful if a corresponding Python WHL package is built using the existing CMake script.
<!-- Please outline the motivation for the proposal. Is your feature request related to a problem? e.g., I'm always frustrated when [...]. If this is related to another GitHub issue, please link here too -->
The python build is esoteric in nature. This will benefit users who are prone to building CMake using a GUI rather than a command line approach.
## Pitch
<!-- A clear and concise description of what you want to happen. -->
If "build python package" is selected in CMake, then , during sudo make install, the python files and associated binaries and libraries should be installed in the /usr/local/lib/x86_64/python3/dist_packages folder. Currently, only the "caffe2" python binding is installed
## Alternatives
<!-- A clear and concise description of any alternative solutions or features you've considered, if any. -->
## Additional context
<!-- Add any other context or screenshots about the feature request here. -->
| module: build,low priority,triaged,enhancement | low | Major |
562,158,978 | flutter | Request: locator for labelText in flutter driver | Hi please could you help.
When using a form - there is attribute 'labeltext' which is the default text . There is currently no way to extract this I tried using Gettext but this does pull it. Please can you advise. | c: new feature,tool,t: flutter driver,P3,team-tool,triaged-tool | low | Minor |
562,169,486 | TypeScript | Let type identifiers co-exist with import namespace identifiers | ## Search Terms
Modules, export, import
## Suggestion
It would be convienent if type identifiers could co-exist with import namespace identifiers.
## Use Cases
A common pattern is to have a module where the module name is the same as the main type exported by that module.
## Examples
Consider this module:
**result.ts**
```ts
export type Result<TError, TValue> =
| { readonly type: "Ok"; readonly value: TValue }
| { readonly type: "Err"; readonly error: TError };
export function Ok<TValue>(value: TValue): Result<never, TValue> {
return { type: "Ok", value };
}
export function Err<TError>(error: TError): Result<TError, never> {
return { type: "Err", error };
}
// .. more functions to work with the Result type
```
Now consider a consumer of this moudule:
```ts
import * as Result from "./result";
export function itsOk(): Result.Result<string, string> {
const ok: Result.Result<string, string> = Result.Ok("");
const err: Result.Result<string, string> = Result.Err("");
return ok;
}
```
There are execessive type annotations in this example but the point is that it is annoying ot have to refer to the type `Result` as `Result.Result`. I would like to refer to the type as only `Result` but still have functions related to the module in a `Result` namespace.
I was reading about the new `import type` syntax in 3.8 and thought I might get away with something like this:
```ts
import * as Result from "./result";
import type { Result } from "./result";
export function itsOk(): Result<string, string> {
const ok: Result<string, string> = Result.Ok("")
const err: Result<string, string> = Result.Err("")
return ok;
}
```
This fails because there are duplicate identifiers. Typescript does allow duplicate identifiers that live either 100% in the type world or 100% in the concrete world. But imported namespace objects (`import * as`) lives in both worlds so it does not currently work. Specifically namespace object can contain both types and concrete things.
However I think typescript should be able to infer from usage if I'm referring the type or the namespace when using it in a place where types can be used. If what is referenced could be found by looking at the usage then duplicate identifiers could be allowed. I believe some other languages does it this way.
In this example the type used does not have a dot so it is referring to the imported type rather than the imported namespace.
```ts
const ok: Result<string, string> = ..
```
In this example the type used has a dot so it is referring to the namespace object.
```ts
const ok: Result.OtherType = ..
```
I think this is not related to the ECMA standard for modules and import/export but rather something typescript decide how to handle because it is fully in the "type world" which gets erased when emitted to js.
## Checklist
My suggestion meets these guidelines:
- [x] This wouldn't be a breaking change in existing TypeScript/JavaScript code
- [x] This wouldn't change the runtime behavior of existing JavaScript code
- [x] This could be implemented without emitting different JS based on the types of the expressions
- [x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
- [x] This feature would agree with the rest of [TypeScript's Design Goals](https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals).
| Suggestion,In Discussion | low | Critical |
562,179,915 | rust | Add `with_exact_size` and `with_size_hint` to `Iterator` | Usually iterator adaptors do a fine job at keeping information about the length of an iterator. But once you throw something like `filter` in your iterator chain, the lower bound is 0, meaning that collecting into a collection can't properly pre-allocate. Also, some iterator adaptors (like `chain`) cannot implemented `ExactSizeIterator` although in many real world cases, the size is perfectly known.
Currently, working around those limitations is often tedious and requires quite a bit of additional code. I think it would be a lot nicer to just add a `.with_exact_size(27)` somewhere into your chain. So I'd like to propose adding the following to `Iterator`:
- **`fn with_size_hint(self, lower: usize, upper: Option<usize>) -> SizeHint`**
- `SizeHint` would implement `Iterator::size_hint` with the given values, forwarding all other methods to the inner iterator (and implementing the same traits)
- **`fn with_exact_size(self, size: usize) -> ExactSize`**
- `ExactSize` would implement `ExactSizeIterator` with the given value and override `Iterator::size_hint`. All other methods are forwarded to the inner iterator (and implementing the same traits, plus `ExactSizeIterator`)
I would have created this as a PR, but I'm short on time and wanted to hear some opinions first. | T-libs-api,C-feature-request,A-iterators | low | Major |
562,192,035 | node | HTTP2 Server Upgrade listener undocumented | - All versions that have HTTP2 and HTTPS* implemented
- Documentation problem
The code below shows what is up. I wonder what could be the reason that it works even-tough it is undocumented even in the typescript definitions that come with npm.
I would say this is due to C++ inheritance from HTTPServer to HTTPSServer and HTTP2Server, but no idea, someone could look into it to make sure.
```
const server = http2.createServer({
allowHTTP1: true
});
server.on('upgrade', (request, socket, head) => {
// This does work, but no documentation anywhere (internet, TS definitions, ancestor classes neither)
// (One could add as ws upgrade handler here)
});
```
**Edit:** apparently it is undocumented in the node HTTPS Server as well. | doc,http2 | low | Minor |
562,215,369 | angular | Angular IVY Animation issue - element is not getting removed | # π bug report
### Affected Package
Angular animations in combination with IVY, and maybe some other stuff mixed in. Unkown because unable to reproduce in stackblitz.
### Is this a regression?
Yeah, sort of, I don't have the issue pre-IVY
### Description
2 screenshots above.
The first one has this as DOM:
the class combination-container can only happen once (it's in an *ngIf).
But in combination with
it seems that somehow, the previous elements are not removed.
I've tried my best to reproduce the situation in a stackblitz:
https://stackblitz.com/edit/components-issue-tdugpz?file=src%2Fapp%2Fcontainer.ts
with the minimal component logic I have. But I don't succeed. In the stackblitz it works but in the application it doesn't.
It happens when the elements are changed while you're in the first tab. So it seems to have to with the fact that the fadein animation is running while the element is not on screen.
If I remove the fadein animation, the elements are correctly removed.
## π¬ Minimal Reproduction
<!--
Please create and share minimal reproduction of the issue starting with this template: https://stackblitz.com/fork/angular-issue-repro2
-->
https://stackblitz.com/edit/components-issue-tdugpz?file=src%2Fapp%2Fcontainer.ts
=> failed reproduction, but shows the hierarchy where I have the issue.
## π₯ Exception or Error
None
**Angular Version:**
9.0.0
cli 9.0.1
| type: bug/fix,area: animations,freq2: medium,regression,state: confirmed,P2 | low | Critical |
562,230,829 | go | x/mobile: add option to pass in gobind | ```zsh
% ~/go/bin/gomobile bind -target iOS ./lib
```
will not work until you set PATH environment variable which points to `gobind`.
It is something that I don't expect.
I expect that `~/go/bin/gomobile init` will fix all issues and everything will be fine.
Could you add option to set path to binary `gobind`?
```zsh
% ~/go/bin/gomobile bind -bin ~/go/bin/gobind -target iOS ./lib
``` | NeedsInvestigation,mobile | low | Minor |
562,231,124 | youtube-dl | New site: riksdagen.se | <!--
######################################################################
WARNING!
IGNORING THE FOLLOWING TEMPLATE WILL RESULT IN ISSUE CLOSED AS INCOMPLETE
######################################################################
-->
## Checklist
<!--
Carefully read and work through this check list in order to prevent the most common mistakes and misuse of youtube-dl:
- First of, make sure you are using the latest version of youtube-dl. Run `youtube-dl --version` and ensure your version is 2020.01.24. If it's not, see https://yt-dl.org/update on how to update. Issues with outdated version will be REJECTED.
- Make sure that all provided video/audio/playlist URLs (if any) are alive and playable in a browser.
- Make sure that site you are requesting is not dedicated to copyright infringement, see https://yt-dl.org/copyright-infringement. youtube-dl does not support such sites. In order for site support request to be accepted all provided example URLs should not violate any copyrights.
- Search the bugtracker for similar site support requests: http://yt-dl.org/search-issues. DO NOT post duplicates.
- Finally, put x into all relevant boxes (like this [x])
-->
- [x] I'm reporting a new site support request
- [x] I've verified that I'm running youtube-dl version **2020.01.24**
- [x] I've checked that all provided URLs are alive and playable in a browser
- [x] I've checked that none of provided URLs violate any copyrights
- [x] I've searched the bugtracker for similar site support requests including closed ones
## Example URLs
<!--
Provide all kinds of example URLs support for which should be included. Replace following example URLs by yours.
-->
- Single video: https://www.riksdagen.se/sv/webb-tv/video/interpellationsdebatt/lararnas-arbetsmiljo-_H710286
- Single video: https://www.riksdagen.se/sv/webb-tv/video/oppen-utfragning/oppen-utfragning-infor-den-forskningspolitiska_H7C220200130ou1
## Description
<!--
Provide any additional information.
If work on your issue requires account credentials please provide them or explain how one can obtain them.
-->
The ID can be extracted from the last part in the URL (after the _) or in some places in the HTML code. The ID can then be appended to "https://www.riksdagen.se/api/videostream/get/" to get a JSON file that contains the video URL.
Example bash function that does the job:
```
function riksdagen {
json=https://www.riksdagen.se/api/videostream/get/$(echo $1 | sed 's/.*_//');
video=$(curl $json | jq -r '.videodata[0].streams.files[0].downloadfileurl');
mpv $video
}
``` | site-support-request | low | Critical |
562,231,254 | godot | Import Crash entire project, can't open project again | **Godot version:**
3.2
**OS/device including version:**
Windows 10
**Issue description:**
**Steps to reproduce:**
After try to change and set import default to some texture file .png
at FileSystem Dock, i suddenly get crash and I can't open my project anymore, it was load into project about 1-2 second and then get crashed, I have to using video record to capture this error
| bug,discussion,topic:core | low | Critical |
562,237,046 | excalidraw | disable/improve text creation via double-click with shape tools | Currently, double-click creates text even with non-selection tools. This often results in creating a tiny element (e.g. rectangle) just before you create the text element:
It's also problematic with multi-point tools (arrows, lines).
We should either disable this for non-selection tools, or employ a heuristic such as removing last shape created within a given threshold (e.g. 600ms) before the text element.
There's also a problem when you double-click with a non-selection tool when the tools are locked. This may warrant a separate issue, though. | bug,discussion | low | Major |
562,237,678 | godot | Region taken from AtlasTexture is inaccurate if taken from edge | **Godot version:**
3.2.stable.official
**OS/device including version:**
Windows 10
**Issue description:**
I've seen a few instances where extracting a manually defined region from an `AtlasTexture` "extends" pixels found at the edges of the texture. See attached image for an idea of what I mean here.
**Steps to reproduce:**
Add a Sprite to a scene and then manually define a region from an `AtlasTexture` for the sprite's texture. Be sure the defined region is at the top edge of the atlas. Now, manually extend the region *above* the (apparent) top edge of the atlas. The sprite will show a smear of pixels extending from the ones that touch the top edge (I think?).
**Minimal reproduction project:**
| topic:rendering,documentation | low | Minor |
562,255,585 | flutter | google_maps_flutter: Reliable zoom callback | ## Use case
The callback onCameraMove sometimes doesn't fire if the map is zoomed, but the map center remains unchanged. I don't know whether onCameraMove is supposed to be called only when the center changes, however I'd like to have a callback that reliably tells me when the zoom level has changed.
## Proposal
Either call onCameraMove also when only the zoom level changes or implement a new callback, e.g. onZoomChanged.
| c: new feature,p: maps,package,c: proposal,team-ecosystem,P3,triaged-ecosystem | low | Minor |
562,255,897 | flutter | google_maps_flutter: Restrict zoom level visibility of map features | ## Use case
I'd like to show polygons/markers/lines only within a specific zoom level range, e.g. when zoom is greater than 18.0.
## Proposal
Add fields to map features minZoom/maxZoom.
| c: new feature,p: maps,package,c: proposal,team-ecosystem,P3,triaged-ecosystem | low | Minor |
562,266,405 | flutter | Flutter CLI parsable output (JSON) | ## Use case
I run multiple simulators to test different resolutions and platforms at once and I want to be able to target `flutter run -d ... ` at each of them independently. Using `flutter run -d all` is not convenient as the console log becomes unusable. So my work set up is to have multiple terminal tabs/windows with independent `flutter run -d ....` running in each and I want to automate that.
To initiate the script I need to run `flutter devices` and parse its output which is quite difficult to do.
## Proposal
Add an `--output json` to flutter CLI which will dump the information to standard out without human-friendly annotations and decorations.
Related issues:
1. https://github.com/flutter/flutter/issues/14134
2. https://github.com/flutter/flutter/issues/44034
| c: new feature,tool,P3,team-tool,triaged-tool | low | Minor |
562,299,698 | flutter | Failed to xcodebuild against multiple iOS devices: Build service could not start build operation: unknown error while handling message: Could not acquire lock at path `Path(str: ".../DerivedData/.../...-Workspace.lock")` | <!-- Thank you for using Flutter!
If you are looking for support, please check out our documentation
or consider asking a question on Stack Overflow:
* https://flutter.dev/
* https://api.flutter.dev/
* https://stackoverflow.com/questions/tagged/flutter?sort=frequent
If you have found a bug or if our documentation doesn't have an answer
to what you're looking for, then fill our the template below. Please read
our guide to filing a bug first: https://flutter.dev/docs/resources/bug-reports
-->
I'm trying to debugging my application with iPhone and iPad simulators. But, application only launched on one simulator.
## Steps to Reproduce
<!-- Please tell us exactly how to reproduce the problem you are running into. -->
This is my `launch.json`
```
{
// Use IntelliSense to learn about possible attributes.
// Hover to view descriptions of existing attributes.
// For more information, visit: https://go.microsoft.com/fwlink/?linkid=830387
"version": "0.2.0",
"configurations": [
{
"name": "Current Device",
"request": "launch",
"type": "dart"
},
{
"name": "iPhone 11",
"request": "launch",
"type": "dart",
"deviceId": "iPhone 11"
},
{
"name": "iPad",
"request": "launch",
"type": "dart",
"deviceId": "iPad"
}
],
"compounds": [
{
"name": "iOS",
"configurations": [
"iPhone 11",
"iPad"
]
}
]
}
```
## Logs
<!--
Include the full logs of the commands you are running between the lines
with the backticks below. If you are running any "flutter" commands,
please include the output of running them with "--verbose"; for example,
the output of running "flutter --verbose create foo".
-->
```
Launching lib/main.dart on iPhone 11 in debug mode...
Xcode build done. 1.9s
Failed to build iOS app
Error output from Xcode build:
β³
** BUILD FAILED **
Xcode's output:
β³
note: Using new build system
error: Build service could not start build operation: unknown error while handling message: Could not acquire lock at path `Path(str: "/Users/ekasetiawans/Library/Developer/Xcode/DerivedData/Runner-cvnxrdslexqanxgifauwqwadpzrb/Build/Intermediates.noindex/XCBuildData/PIFCache/WORKSPACE@v11_mod=1579070672.0_hash=6162b33aa8199599d972cf41ab25bc47_subobjects=B549A30C3B2425E52674E89430410CE0-Workspace.lock")`
Could not build the application for the simulator.
Error launching application on iPhone 11.
Exited (sigterm)
```
<!-- If possible, paste the output of running `flutter doctor -v` here. -->
```
```
| platform-ios,tool,P3,team-ios,triaged-ios | medium | Critical |
562,561,153 | material-ui | [Drawer]Tooltip to appear on hover, click and mousedown over icons of Mini Variant Drawer | <!-- Provide a general summary of the feature in the Title above -->
<!--
Thank you very much for contributing to Material-UI by creating an issue! β€οΈ
To avoid duplicate issues we ask you to check off the following list.
-->
<!-- Checked checkbox should look like this: [x] -->
- [x] I have searched the [issues](https://github.com/mui-org/material-ui/issues) of this repository and believe that this is not a duplicate.
## Summary π‘
<!-- Describe how it should work. -->
A tooltip to appear on hover, click and mousedown over button icons of the Mini Variant Drawer to give the title or description (or both) of the buttons purpose.
Maybe just include Material UI's tool tip example as part of the Mini Variant Drawer example if it's easy to do (on at least one of the icons).
I am open to expanding this feature request to all or multiple components too. Just looking for suggestions now.
If this is more of a Support issue than a Feature Request, I am willing to edit this issue for such. Just let me know.
## Examples π
<!--
Provide a link to the Material design specification, other implementations,
or screenshots of the expected behavior.
-->
I managed to add [Material UI Tooltip](https://material-ui.com/components/tooltips/#tooltip) into [sandbox example](https://codesandbox.io/s/material-demo-mg169) of the Mini Variant Drawer. It's easy to set up but needs more styling because there is too much space between the popup box and icon on hover.
Facebook's example would be a good milestone to reach with this.
<img width="208" alt="Screenshot 2020-02-10 at 15 01 03" src="https://user-images.githubusercontent.com/22279028/74161034-3f1bcf00-4c16-11ea-801a-d2006c08bea1.png">
## Motivation π¦
<!--
What are you trying to accomplish? How has the lack of this feature affected you?
Providing context helps us come up with a solution that is most useful in the real world.
-->
I think it could be a useful feature to demonstrate. Especially when you only have so much space for your buttons with little description. It will provide an optional feature for more clarity.
The case of the Mini Variant Drawer (when closed) is a good example of this.
It could add more clarity. Keep it as an optional feature for this component.
Willing to create a PR on this and try it myself. | docs | low | Minor |
562,584,539 | godot | InspectorPlugin.can_handle(arg) can receive objects which are not exposed to GdScript | **Godot version:**
40d1b0bfdb62d24d72f1f0102a7caf6f1c14e595
**OS/device including version:**
Ubuntu 18.04 64bit
**Issue description:**
When we create InspectorPlugin and we implement `can_handle(arg_obj)` function, I would expect the argument will be an Object (like its mentioned in docs). But it seems it's not always a case, in my particular case it was an instance of SectionedInspectorFilter (class which is not exposed to GdScript in the first place). I'm not 100% sure but I think this is an undesired behavior.
This makes such implementations of `can_handle()` improper:
```
func can_handle(in_object):
return "some_property" in in_object
```
If we will use that concrete implementation, then when navigating inside of Editor Settings, we will experience a flood of such warnings:
`core/project_settings.cpp:209 - Property not found: application/config/some_property`
**Steps to reproduce:**
Short way:
1. Download reproduction project
2. Open Editor settings, notice there is a flood of `core/project_settings.cpp:209 - Property not found: application/config/some_property` warnings in the editor output
3. It can be fixed/worked around by correcting res://addons/com.plugin.issue/InspectorPlugin.gd `can_handle(arg)` implementation
Long way (general steps):
1. Create new Plugin and inspector plugin.
2. Inside InspectorPlugin implement can_handle method:
```
func can_handle(in_object):
return "some_property" in in_object
```
3. Register inspector plugin inside the Plugin
4. Open Editor settings and take a look at console output, there should be a lot of `core/project_settings.cpp:209 - Property not found: application/config/some_property` errors
**Minimal reproduction project:**
[inspector_plugin_can_handle_issue.zip](https://github.com/godotengine/godot/files/4181191/inspector_plugin_can_handle_issue.zip)
| bug,confirmed,topic:plugin | low | Critical |
562,641,994 | go | x/mobile/bind: function with argument of type declared in same package skipped after binding | ### What version of Go are you using (`go version`)?
<pre>
$ go version
go version go1.13.7 linux/amd64
</pre>
### Does this issue reproduce with the latest release?
Yes.
### What operating system and processor architecture are you using (`go env`)?
<details><summary><code>go env</code> Output</summary><br><pre>
$ go env
GO111MODULE="on"
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/user/.cache/go-build"
GOENV="/home/user/.config/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/home/user/go"
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/snap/go/current"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/snap/go/current/pkg/tool/linux_amd64"
GCCGO="gccgo"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build676544878=/tmp/go-build -gno-record-gcc-switches"
</pre></details>
### What did you do?
<!--
If possible, provide a recipe for reproducing the error.
A complete runnable program is good.
A link on play.golang.org is best.
-->
```
type Item struct {
Label string
}
func UseItem(item Item) {}
```
```
$ gomobile bind -o Item.aar -v -target=android github.com/my/repo/mobile/pkg
```
### What did you expect to see?
function UseItem() is working normally after bind
### What did you see instead?
After unzipping the `.jar` file I can see inside it file with:
```
// skipped function UseItem with unsupported parameter or return types
``` | NeedsInvestigation,mobile | low | Critical |
562,642,758 | rust | Rustdoc: prioritize matches with same casing in search results | It would be convenient if [the results] for a lowercase `filter` showed exact match `filter` before `Filter`, and vice versa.
[the results]: https://docs.rs/futures/0.3.4/futures/index.html?search=filter
| T-rustdoc,C-enhancement,A-rustdoc-search | low | Major |
562,647,338 | godot | Viewport node doesn't display configuration warning | **Godot version:** 3.2
**OS/device including version:** N/A
**Issue description:**
A non-configured or incorrectly configured `Viewport` node doesn't display configuration warning.
I encountered this issue when attempting to re-create the [node tree described here](https://old.reddit.com/r/godot/comments/ezamrx/input_and_unhandled_input_never_run/fgp36in/) (as "Spatial>TextureRect>Viewport>[level entities]") while trying to troubleshoot for the original poster. It wasn't immediately obvious that `TextureRect` needed a `ViewportTexture` assigned with a node path to the `Viewport` node--complicated further by the other `Viewport` node related issues.
**Steps to reproduce:**
1. Create the following node tree:
```
Node
|_ TextureRect (first without, then with `ViewportTexture` configured with `Viewport` node)
|_Viewport
```
2. Note that before the `ViewportTexture` is added & configured no warning message is displayed but the viewport is not (apparently) used.
3. Note that without the following node tree there is no warning that `ViewportContainer` may be required for correct operation:
```
Node
|_ TextureRect (with `ViewportTexture` configured with `Viewport` node)
|_ViewportContainer
|_Viewport
```
The original warning message in `Viewport::get_configuration_warning()` has been commented out: https://github.com/godotengine/godot/blob/7ada59efb79f64882305c26c3a155385e5dcc05c/scene/main/viewport.cpp#L2983-L2991
The commenting out appears to have occurred as part of [this large GLES3 renderer-related commit](https://github.com/godotengine/godot/commit/22d83bc9f655d5ae7a1b49709c4c1b663725daf5#diff-b0e269beca0e7df95d035998c40ecb64L2585).
AFAICT at least some of configuration warning is still valid (perhaps with a change to mention "Viewport Texture" instead/also?).
**Minimal reproduction project:** N/A
| bug,topic:editor,confirmed,usability | low | Minor |
562,806,840 | flutter | Expose all ViewportMetrics to flutter embedder | ## Use case
content size doesn't match surface size on all platforms. On Android for example the space needs to be made for the statusbar and keyboard.
## Proposal
Extend `FlutterWindowMetricsEvent` with `physicalViewInsetTop` and `physicalViewInsetBottom`. | c: new feature,engine,e: embedder,a: platform-views,c: proposal,P3,team-engine,triaged-engine | low | Minor |
562,815,838 | flutter | Find a better way to configure the web runner's temporary artifacts | The web runner wants to host the entrypoint under a non-file scheme URI (org-dartlang-app) to help DWDS find the right entrypoint. I've implemented this so far by adding an `addFileSystemRoot` method to the compiler, but this isn't the right long term approach.
Ideally we would correctly configure the compiler when setting up the resident runner. Then this method could be removed | tool,c: proposal,P3,team-tool,triaged-tool | low | Minor |
562,822,669 | PowerToys | [Shortcut Guide] Keyshortcut changes based on OS version, Narrator is incorrect on 19h1+ | on 19h1 and above, Narrator is incorrect. The guide shows Win+Enter when it is now win+ctrl+enter
#179 has correct mappings and calls the diff out now | Issue-Bug,Product-Shortcut Guide,Priority-3 | low | Minor |
562,845,321 | flutter | Make it easier to dynamically load snapshot data | We should be able to let users more easily dynamically load vm_snapshot_data and isolate_snapshot_data to avoid including it in the base distribution. This can reduce base distribution size, but would also require the user to host their own infra to supply it. We would also have to come up with some idea about when to do this and how much it impacts startup latency. | tool,engine,c: performance,a: size,perf: app size,P2,team-engine,triaged-engine | low | Minor |
562,858,580 | flutter | Flutter maps navigate for drive mode like Google maps | Drive Mode on widget Maps in flutter, can you support for this? | c: new feature,p: maps,package,c: proposal,team-ecosystem,P3,triaged-ecosystem | low | Minor |
562,889,152 | flutter | `flutter run --profile -d web-server` requires hard-refresh between recompiles | ## Steps to Reproduce
In Chrome with DevTools closed, or DevTools open but "Disable Cache" on the "Network" tab unchecked, do the following:
1. Run any Web app using `flutter run --profile -d web-server`.
2. Make a change in your code.
3. Hit `R` for hot restart
4. Watch the tool recompile the code then say `Recompile complete. Page requires refresh.`
5. Soft-refresh the page (by hitting the refresh button of Ctrl + r). Make sure is not a hard refresh (e.g. Ctrl + Shift + r).
**Expected results:**
Code changes should apply.
**Actual results:**
Code changes do not apply. You are looking at the old app.
## Details
This is happening as of version 9bc0e6a991cbbe2bfe8328eacb62f6320b8d6812.
| tool,platform-web,P2,team-web,triaged-web | low | Major |
562,905,085 | youtube-dl | RUTube LiST Download | <!--
######################################################################
WARNING!
IGNORING THE FOLLOWING TEMPLATE WILL RESULT IN ISSUE CLOSED AS INCOMPLETE
######################################################################
-->
## Checklist
<!--
Carefully read and work through this check list in order to prevent the most common mistakes and misuse of youtube-dl:
- First of, make sure you are using the latest version of youtube-dl. Run `youtube-dl --version` and ensure your version is 2020.01.24. If it's not, see https://yt-dl.org/update on how to update. Issues with outdated version will be REJECTED.
- Search the bugtracker for similar site feature requests: http://yt-dl.org/search-issues. DO NOT post duplicates.
- Finally, put x into all relevant boxes (like this [x])
-->
- [X] I'm reporting a site feature request
- [X] I've verified that I'm running youtube-dl version **2020.01.24**
- [X] I've searched the bugtracker for similar site feature requests including closed ones
## Description
<!--
Provide an explanation of your site feature request in an arbitrary form. Please make sure the description is worded well enough to be understood, see https://github.com/ytdl-org/youtube-dl#is-the-description-of-the-issue-itself-sufficient. Provide any additional information, suggested solution and as much context and examples as possible.
-->
Hey YT-DL Team,
I'm trying to find an Solution to download Videos from RuTube which are listed as "LiST" Videos such as this one: https://rutube.ru/video/73562a2a2a3782b6584827a1edee0c13/
I've tried it in different ways so far but didn't found any solution, the Source Code of the Videos firstly brought me to this Embedded Version: https://rutube.ru/play/embed/12911618
But still i'm not able to Download it, also the Embedded Version just brought me to this link: https://sx.your-resistance-is-futile.com/0d4ba620/BB88qw4PrMrgLSa6FurReY9FF2fs1AnwrQbw8WuSB5J57SAh7525AQU/5oEpWgg6r2VHScS2kKx3UJ49YZu2eq29cDpkcUSwJAxY2NwH4YyabvtAb4jbjiCNQQ2LfP6HZZtuAai3TfhVTyuZAMA4feiE1pDAjvCnW4av1dMpPCEZeofqz6UEix1WEnjwN3VJSGtzChbg4R1fWjS1VcBw3M5z6wyvsqRQtyEpd12cVS9cDaQKgQJ6Dnu19aaPVHYLMcrWR5494MiJ822Fr7mXATueQsj7V71twK26pnMHi4WHUNVPHu18u3oX3nz1mSQbypLqu4c6o6wKVJ2fwjcKVAY43LU2AwDQNv4WN9psmqnn1A83ABaSubb6uQ1UUfJPh8Mj66va6434cnYGhDv2Ju2gedimc1Y751qchC9nZt6yGCwwoaiLukFitiUTKsRCaAiC8uX7Cz3vLPFDeLuu7MUq9UJYL6KvkSYrs39fYwhG3ePrL26QYQaNNaXGR1LcMSUwfyCmbD9qMWHeVEybgABaYQqTkC1gXmwmJvU9VwUjRVSzh21F6fyLCt9sUtFqMen3K5ca4Ruce8gJ4V6XusczmxuL4NghVdKZZ6XHFSRsrymFew1NgwX7BLzKNEGqdTuRTwk7Nh9o44LPntm1jYMSsCtakkhUTi1hmJLbsqfManchc3GrfaGChAX5cFyoUXw7NF4LmqT3Hag9qTXeDrFLm2tFN9bJ2HtmRWP4wgovQ9s2uRJnQpoFVhZFEmza645Xz2aeFnLLYTWsK51EkztchBVLTwUcQWCEuiLqTy9bJJQnQsQZPEahXTDCcDtJ8B8PFiUNaaZ7n5wXu512snNmQ6mQFQsQ2EQb4x2Boitd3fbdZLpxuVw1c1xGtXViTjnVLafJvAFNUpxgFLmUNpM4j72ngYkthLK3rR9GXRo4hHbdW3VCaQaJoQPHZCXtxpmfUMSX16TCNP1utxeEXrfFivUQTZCxVoynRi8dVp5h83Gh6NRUWBKGHVHJAbuBpY3cH8bdaXtYawjdzrn26pdzLKRJJWTVPmzCQ9zukVjENZxErD
Seems to be encoded? Is there no possibility to download the M3U8 or MP4? :(
| account-needed,outdated-version | low | Critical |
562,915,289 | pytorch | TensorIterator does not work with different input/output types | ## π Bug
TensorIterator expects all the inputs and outputs to have the same type. This prevents us from using TensorIterator for operations like quantized batchnorm, where the input is quantized (quint8) but the alpha (scale) and beta (shift) values are in float.
## To Reproduce
Steps to reproduce the behavior:
1. Create a TensorIterator op that has different input/output dtypes
2. build pytorch
Example -
```
AT_DISPATCH_QINT_TYPES(input.scalar_type(), "qbatch_norm", [&]() {
using Vec = Vec256<quint8>;
cpu_kernel_vec(
iter,
[&] (uint8_t in, float a, float b) -> quint8 {
long quantized_down = out_zero_point +
std::lrintf(a * (in - in_zero_point) + b);
if (ReluFused) { // static if
quantized_down = std::max<long>(quantized_down, out_zero_point);
}
return quint8(std::min<long>(
std::max<long>(quantized_down, std::numeric_limits<uint8_t>::min()),
std::numeric_limits<uint8_t>::max()));
},
[&] (Vec in, Vec256<float> a, Vec256<float> b) -> Vec {
...
});
});
```
You should see compile error of the type -
```
In file included from aten/src/ATen/native/quantized/cpu/kernels/QuantizedOpKernels.cpp.AVX2.cpp:5:
../aten/src/ATen/native/cpu/Loops.h:70:10: error: no viable conversion from returned value of type 'tuple<[...], Vec256<c10::quint8>, Vec256<c10::quint8>>' to function return type 'tuple<[...], Vec256<float>, Vec256<float>>'
return std::make_tuple(
^~~~~~~~~~~~~~~~
../aten/src/ATen/native/cpu/Loops.h:80:10: note: in instantiation of function template specialization 'at::native::(anonymous namespace)::dereference_vec_impl<function_traits<(lambda at aten/src/ATen/native/quantized/cpu/kernels/QuantizedOpKernels.cpp.AVX2.cpp:992:5)>, 0, 1, 2>' requested here
return dereference_vec_impl<traits>(data, opt_scalar, S, i, Indices{});
^
../aten/src/ATen/native/cpu/Loops.h:149:18: note: in instantiation of function template specialization 'at::native::(anonymous namespace)::dereference_vec<function_traits<(lambda at aten/src/ATen/native/quantized/cpu/kernels/QuantizedOpKernels.cpp.AVX2.cpp:992:5)> >' requested here
auto args1 = dereference_vec<traits>(&data[1], opt_scalar, S, i);
^
../aten/src/ATen/native/cpu/Loops.h:211:14: note: in instantiation of function template specialization 'at::native::(anonymous namespace)::vectorized_loop<(lambda at aten/src/ATen/native/quantized/cpu/kernels/QuantizedOpKernels.cpp.AVX2.cpp:992:5), (lambda at aten/src/ATen/native/quantized/cpu/kernels/QuantizedOpKernels.cpp.AVX2.cpp:992:5)>' requested here
return vectorized_loop(data, n, 0, std::forward<func_t>(op), std::forward<vec_func_t>(vop));
^
```
## Expected behavior
Allow different types for input and output tensors.
Specifically, don't restrict the type to be dependent on the return type - https://github.com/pytorch/pytorch/blob/master/aten/src/ATen/native/cpu/Loops.h#L137
cc @jamesr66a, @raghuramank100 | triaged,enhancement,module: vectorization,module: TensorIterator | low | Critical |
562,916,644 | TypeScript | Auto import generates wrong module specifier for `a/index.ts` when `a.ts` exists | <!-- π¨ STOP π¨ π¦π§π’π£ π¨ πΊπ»πΆπ· π¨
Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Even if you think you've found a *bug*, please read the FAQ first, especially the Common "Bugs" That Aren't Bugs section!
Please help us by doing the following steps before logging an issue:
* Search: https://github.com/Microsoft/TypeScript/search?type=Issues
* Read the FAQ: https://github.com/Microsoft/TypeScript/wiki/FAQ
Please fill in the *entire* template below.
-->
<!--
Please try to reproduce the issue with the latest published version. It may have already been fixed.
For npm: `typescript@next`
This is also the 'Nightly' version in the playground: http://www.typescriptlang.org/play/?ts=Nightly
-->
**TypeScript Version:** 3.8.1-rc
<!-- Search terms you tried before logging this (so others can find this issue more easily) -->
**Search Terms:** auto import index
**Code**
```ts
// tsconfig.json
{
"compilerOptions": {
"module": "commonjs" // ensures `importModuleSpecifierEnding` defaults to `Ending.Minimal`
}
}
// a/index.ts
export const aIndex = 0;
// a.ts
export {}
// index.ts
aIndex/* auto-import here */
```
**Expected behavior:**
Module specifier from auto-import is `"./a/index"`
**Actual behavior:**
Module specifier is `"./a"`
**Related Issues:** #36725 #24779
| Bug,Fix Available,Domain: Auto-import,Rescheduled | low | Critical |
562,920,602 | flutter | Add powershell version to the checks in flutter doctor | Hi
I think that this command option need to check the PowerShell version (Windows)
and if it is not at the correct version, it must declare it as an open issue.
When I installed flutter form this file flutter_windows_v1.12.13+hotfix.7-stable
I got an error while doing "flutter upgrade" command (the dart sdk....), and it took me some time to understand that my PowerShell version in lower than the required version
Shlomo
| c: new feature,tool,t: flutter doctor,a: first hour,P2,team-tool,triaged-tool | low | Critical |
562,958,064 | flutter | Add --min-coverage option to flutter test --coverage | I think in test_coverage 0.4.2, we will have a --min-coverage option, so I can add to my CI script for example, `pub run test_coverage --min-coverage 100`.
Please add a similar feature to `flutter test --coverage`, so that CI scripts can easily error out if coverage drops below a threshold. | a: tests,c: new feature,tool,P2,team-tool,triaged-tool | low | Critical |
563,000,113 | TypeScript | feature request: public the TransformationContext.addDiagnostic and read them in the compiler and transpileModule | ## Search Terms
custom transformer diagnostic
## Suggestion
mark the method `addDiagnostic` in `TransformationContext` as public and read the diagnostic result in the compiler
## Use Cases
I'm writing a custom transformer. In some cases, the transform will fail but I don't want to throw an Error. I want to add my error to the diagnostics.
## Examples
I have tried to call the `addDiagnostic` by as any
```ts
function createDiagnosticForNodeInSourceFile(
ts: ts,
sourceFile: SourceFile,
node: Node,
message: DiagnosticMessage,
arg0?: string | number,
arg1?: string | number,
arg2?: string | number,
arg3?: string | number,
): DiagnosticWithLocation | undefined {
return (ts as any).createDiagnosticForNodeInSourceFile?.(sourceFile, node, message, arg0, arg1, arg2, arg3)
}
function appendDiagnosticMessageForNode(context: TransformationContext, diag: DiagnosticWithLocation | undefined) {
if (!diag) return false
const _context = internalTransformationContext(context)
if (!_context.addDiagnostic) return false
_context.addDiagnostic(diag)
return true
function internalTransformationContext(
context: TransformationContext,
): TransformationContext & { addDiagnostic?(diag: DiagnosticWithLocation): void } {
return context as any
}
}
```
But that doesn't work. After digging into the source code, I found that it seems like the diagnostics only read in the `dts` generating.
## Checklist
My suggestion meets these guidelines:
* [x] This wouldn't be a breaking change in existing TypeScript/JavaScript code
* [x] This wouldn't change the runtime behavior of existing JavaScript code
* [x] This could be implemented without emitting different JS based on the types of the expressions
* [x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
* [x] This feature would agree with the rest of [TypeScript's Design Goals](https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals).
| Suggestion,In Discussion | low | Critical |
563,014,173 | vscode | Add ability for before decorations to indent (stretch across) word wrapped lines | Refs: https://github.com/eamodio/vscode-gitlens/issues/930
I've gotten this report numerous times with GitLens' "gutter" blame annotations and there really isn't much I can do to fix/deal with this.
Can anything be done here? | feature-request,editor-wrapping | low | Minor |
563,075,887 | angular | Support for dynamic Angular Elements / Webcomponents (with Renderers) | # π feature request
### Relevant Package
The functionality relates to the `@angular/platform-browser` package as this is the package which implements `DomRendererFactory2` and `DefaultDomRenderer2`
### Description
Angular Elements and Webcomponents in general represent great solution for various [real world use cases](https://angular-extensions.github.io/elements/#/docs/use-cases#sub-applications) like...
* sub-applications - ability to deploy library independently which will update all consumers without need to rebuild these consumer SPAs because lib is only referenced by url (as Angular Element bundle)
* microfrontends ( runtime-configurable )
Usual approach to consuming Angular Elements and Web components leaves us with 2 options:
1. eager loading + standard Angular template binding `<some-element [prop]="value">`
2. lazy loading + imperative component creation and props / event binding `document.createElement('some-element');` ...
The library `@angular-extensions/elements` solves this by enabling both **lazy loading** and **standard Angular template binding** `<some-element *axLazyElement="bundle.js" [prop]="value">` and this works with both ViewEngine and IVY...
### Dynamic element use case
In previous section we're committing to element being `<some-element>` by hard-coding it into template of the consumer Angular component. What if we wanted to support loading element configuration at runtime (eg from backend) to enable fully dynamic microfrontends?
As it turns out this works too (at least for the ViewEngine) so it is possible to write `<ax-lazy-element *axLazyElementDynamic="'some-element'; url: 'bundle.js'" [prop]="value"></ax-lazy-element>`.
The bundle will be lazy loaded, and then the element will be rendered as `<some-element>`.
The only thing needed to do that is to override value of the `tagName` in the `TemplateRef` of the `*axLazyElemendDynamic` directive and Angular will render desired element supporting our use case.
Now this does NOT work with IVY since in IVY template is an function.
Rob @robwormald gave me hint that it should be possible to override `Renderer` (or use custom) to hook into rendering and override element there.
### The Issue
It is possible to achieve that with render BUT:
* currently both `DomRendererFactory2` and `DefaultDomRenderer2` are private so it is NOT possible to extend them and hence I would need to re-implement the whole renderer which sounds pretty excessive and hard to maintain
* PLUS as far as I am aware the render API changed [older NRWL article](https://blog.nrwl.io/experiments-with-angular-renderers-c5f647d4fd9e) so there is no more `RootRenderer` ?
### Current [solution](https://github.com/angular-extensions/elements/blob/master/projects/elements/src/lib/lazy-elements/lazy-element-dynamic/lazy-element-dynamic.directive.ts#L71-L80)
Play around with **live demo** (which serves both lib and demo and rebuilds on changes to any of them) using this one liner `git clone https://github.com/angular-extensions/elements.git elements && cd elements && npm ci && npm start` once it runs, please navigate to `Examples > Dynamic` to see it in action.
```typescript
@Directive({
selector: '[axLazyElementDynamic]'
})
export class LazyElementDynamicDirective implements OnInit {
@Input('axLazyElementDynamic') tag: string;
@Input('axLazyElementDynamicUrl') url: string;
constructor(
@Inject(DOCUMENT) private document: Document,
private renderer: Renderer2,
private cdr: ChangeDetectorRef,
private template: TemplateRef<any>,
private elementsLoaderService: LazyElementsLoaderService
) {}
ngOnInit() {
this.elementsLoaderService
.loadElement(this.url)
.then(() => {
this.vcr.clear();
const originalCreateElement = this.renderer.createElement;
this.renderer.createElement = (name: string, namespace: string) => { // temporary override
if (name === 'ax-lazy-element') {
name = this.tag;
}
return this.document.createElement(name);
};
this.vcr.createEmbeddedView(this.template);
this.renderer.createElement = originalCreateElement;
this.cdr.markForCheck();
})
}
}
```
### Describe the solution you'd like
Probably being able to easily extend default renderer and being able to register it like we're used to with interceptors or control value accessors.
I would like to give people option (or do it for them behind the scenes) to do
```typescript
@NgModule({
import: [LazyElementsModule],
providers: [{ provide: Renderer, useClass: LazyElementsRenderer }]
})
export class AppModule {}
export class LazyElementsRenderer extends DefaultDomRenderer2 {
constructor(...args) {
this.super(...args);
}
createElement() {
// override logic and change tag name if necessary
}
}
```
### Describe alternatives you've considered
I spent quite some time trying to override tag inside of template function without success
| feature,area: core,area: elements,feature: under consideration | medium | Major |
563,080,531 | pytorch | Loading pretrained model | Hi,
Recently i have converted a detectron model using the tools/convert_pkl_to_pb.py from Detetron repo which results in model_init.pb, model.pb and model.pbtxt. Then, i try to load the pretrained model following this tutorial (https://github.com/facebookarchive/tutorials/blob/master/Loading_Pretrained_Models.ipynb). By, following through the tutorial, i was able to make predictions using the provided model. However, when i try with the converted model, the following error occurs.
```
[E operator.cc:203] Cannot find operator schema for BatchPermutation. Will skip schema checking.
Traceback (most recent call last):
File "infer.py", line 153, in <module>
p = workspace.Predictor(init_net, predict_net)
File "/opt/conda/lib/python3.6/site-packages/caffe2/python/workspace.py", line 186, in Predictor
return C.Predictor(StringifyProto(init_net), StringifyProto(predict_net))
RuntimeError: [enforce fail at operator.cc:273] op. Cannot create operator of type 'BatchPermutation' on the device 'CUDA'. Verify that implementation for the corresponding device exist. It might also happen if the binary is not linked with the operator implementation code. If Python frontend is used it might happen if dyndep.InitOpsLibrary call is missing. Operator def: input: "roi_feat_shuffled" input: "rois_idx_restore_int32_gpu_0" output: "roi_feat" name: "" type: "BatchPermutation" device_option { device_type: 1 device_id: 0 }
frame #0: c10::ThrowEnforceNotMet(char const*, int, char const*, std::string const&, void const*) + 0x5b (0x7fd70bf1341b in /opt/conda/lib/python3.6/site-packages/caffe2/python/../../torch/lib/libc10.so)
frame #1: caffe2::CreateOperator(caffe2::OperatorDef const&, caffe2::Workspace*, int) + 0xc14 (0x7fd70eaec084 in /opt/conda/lib/python3.6/site-packages/caffe2/python/../../torch/lib/libtorch.so)
frame #2: caffe2::SimpleNet::SimpleNet(std::shared_ptr<caffe2::NetDef const> const&, caffe2::Workspace*) + 0x2e0 (0x7fd70eae4040 in /opt/conda/lib/python3.6/site-packages/caffe2/python/../../torch/lib/libtorch.so)
frame #3: <unknown function> + 0x278338e (0x7fd70eae638e in /opt/conda/lib/python3.6/site-packages/caffe2/python/../../torch/lib/libtorch.so)
frame #4: std::_Function_handler<std::unique_ptr<caffe2::NetBase, std::default_delete<caffe2::NetBase> > (std::shared_ptr<caffe2::NetDef const> const&, caffe2::Workspace*), std::unique_ptr<caffe2::NetBase, std::default_delete<caffe2::NetBase> > (*)(std::shared_ptr<caffe2::NetDef const> const&, caffe2::Workspace*)>::_M_invoke(std::_Any_data const&, std::shared_ptr<caffe2::NetDef const> const&, caffe2::Workspace*&&) + 0xf (0x7fd70eabaf7f in /opt/conda/lib/python3.6/site-packages/caffe2/python/../../torch/lib/libtorch.so)
frame #5: caffe2::CreateNet(std::shared_ptr<caffe2::NetDef const> const&, caffe2::Workspace*) + 0x464 (0x7fd70eaacb74 in /opt/conda/lib/python3.6/site-packages/caffe2/python/../../torch/lib/libtorch.so)
frame #6: caffe2::Workspace::CreateNet(std::shared_ptr<caffe2::NetDef const> const&, bool) + 0xfe (0x7fd70eb297ee in /opt/conda/lib/python3.6/site-packages/caffe2/python/../../torch/lib/libtorch.so)
frame #7: caffe2::Predictor::Predictor(caffe2::PredictorConfig) + 0x323 (0x7fd70edbb853 in /opt/conda/lib/python3.6/site-packages/caffe2/python/../../torch/lib/libtorch.so)
frame #8: <unknown function> + 0x4f8a5 (0x7fd73e1298a5 in /opt/conda/lib/python3.6/site-packages/caffe2/python/caffe2_pybind11_state_gpu.cpython-36m-x86_64-linux-gnu.so)
frame #9: <unknown function> + 0x4fb77 (0x7fd73e129b77 in /opt/conda/lib/python3.6/site-packages/caffe2/python/caffe2_pybind11_state_gpu.cpython-36m-x86_64-linux-gnu.so)
frame #10: <unknown function> + 0x95696 (0x7fd73e16f696 in /opt/conda/lib/python3.6/site-packages/caffe2/python/caffe2_pybind11_state_gpu.cpython-36m-x86_64-linux-gnu.so)
<omitting python frames>
frame #30: __libc_start_main + 0xf0 (0x7fd76da8e830 in /lib/x86_64-linux-gnu/libc.so.6)
```
Anyone knows why this happen?
Thanks | caffe2 | low | Critical |
563,098,573 | terminal | Screen flicker when Terminal is opened on top of Skype window | <!--
π¨π¨π¨π¨π¨π¨π¨π¨π¨π¨
I ACKNOWLEDGE THE FOLLOWING BEFORE PROCEEDING:
1. If I delete this entire template and go my own path, the core team may close my issue without further explanation or engagement.
2. If I list multiple bugs/concerns in this one issue, the core team may close my issue without further explanation or engagement.
3. If I write an issue that has many duplicates, the core team may close my issue without further explanation or engagement (and without necessarily spending time to find the exact duplicate ID number).
4. If I leave the title incomplete when filing the issue, the core team may close my issue without further explanation or engagement.
5. If I file something completely blank in the body, the core team may close my issue without further explanation or engagement.
All good? Then proceed!
-->
<!--
This bug tracker is monitored by Windows Terminal development team and other technical folks.
**Important: When reporting BSODs or security issues, DO NOT attach memory dumps, logs, or traces to Github issues**.
Instead, send dumps/traces to [email protected], referencing this GitHub issue.
If this is an application crash, please also provide a Feedback Hub submission link so we can find your diagnostic data on the backend. Use the category "Apps > Windows Terminal (Preview)" and choose "Share My Feedback" after submission to get the link.
Please use this form and describe your issue, concisely but precisely, with as much detail as possible.
-->
# Environment
```none
Windows build number: 10.0.18363 (Windows 10 1909)
Windows Terminal version (if applicable): 0.8.10261.0 (latest Windows Store release)
Built-in Skype app: 14.56.102.0
GPU: Intel HD 530 (desktop skylake) using drivers 100.7463-100.7755, running dual-monitor setup at 1080p each
```
# Steps to reproduce
Open Skype and maximize the window, open Windows Terminal with any profile that is using acrylic effect (I have it set at 0.75 for cmd, for example), observe flicker on repaint.
Not sure if relevant, but I have animated emojis visible in the skype window.
You can also have other legacy windows between skype and terminal (placing some modern app in-between can stop this issue)
# Expected behavior
Repaint is unnoticeable
# Actual behavior
Screen flickers
| Area-Rendering,Issue-Bug,Area-UserInterface,Product-Terminal,Priority-3 | low | Critical |
563,110,155 | rust | `r#` stripped from raw idents in lint and `type annotations needed` error | This code
```rust
fn r<r#trait>() {}
fn main() {
r();
}
```
([Playground](https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=a12ec17055cf3c08f4b6d59b31969dfc))
Gives incorrect warning and error for type declared using raw identifiers:
```
warning: type parameter `trait` should have an upper camel case name
--> src/main.rs:1:6
|
1 | fn r<r#trait>() {}
| ^^^^^^^ help: convert the identifier to upper camel case: `Trait`
|
= note: `#[warn(non_camel_case_types)]` on by default
error[E0282]: type annotations needed
--> src/main.rs:4:5
|
4 | r();
| ^ cannot infer type for type parameter `trait`
error: aborting due to previous error
For more information about this error, try `rustc --explain E0282`.
error: could not compile `playground`.
```
NOTE: This is about the diagnostics not including the `r#` in each case. | A-diagnostics,T-compiler,C-bug,D-papercut,D-incorrect | low | Critical |
563,110,178 | rust | Incorrect help message for type declared on struct using raw identifier | This code
```rust
struct r#struct<r#fn>;
fn main() {}
```
([Playground](https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=67fec620c3f519c8b8f8b13f209b0a1e))
Produces incorrect help message:
```
Compiling playground v0.0.1 (/playground)
warning: type `struct` should have an upper camel case name
--> src/main.rs:1:8
|
1 | struct r#struct<r#fn>;
| ^^^^^^^^ help: convert the identifier to upper camel case: `Struct`
|
= note: `#[warn(non_camel_case_types)]` on by default
warning: type parameter `fn` should have an upper camel case name
--> src/main.rs:1:17
|
1 | struct r#struct<r#fn>;
| ^^^^ help: convert the identifier to upper camel case: `Fn`
error[E0392]: parameter `fn` is never used
--> src/main.rs:1:17
|
1 | struct r#struct<r#fn>;
| ^^^^ unused parameter
|
= help: consider removing `fn`, referring to it in a field, or using a marker such as `std::marker::PhantomData`
error: aborting due to previous error
For more information about this error, try `rustc --explain E0392`.
error: could not compile `playground`.
To learn more, run the command again with --verbose.
``` | C-enhancement,A-diagnostics,T-compiler | low | Critical |
563,147,739 | pytorch | [feature request] [dataloader] Introduce Dataset.__collate__ | And use it if `collate_fn` is unspecified and `dataset.__collate__` is specified. This makes sense, because batch collation logic is very often tied to `__getitem__` return values interface
(As a workaround I currently create separately a `dataset` instance and then pass `collate_fn = dataset.collate_fn`. This prevents from creating `DataLoader(MyDataset())` in a single line)
cc @SsnL | module: dataloader,triaged,enhancement,needs research | medium | Major |
563,148,845 | godot | Outputs of multiple instances of Godot get mixed up | **Godot version:**
3.2-stable
**OS/device including version:**
Windows 10 (10.0.18362 Build 18362)
**Issue description:**
When at least two instances of Godot are open, and you run both instances with the debugger attached, one will always have its debugger removed and there is a chance that the output shows the output from the other instance. (~10% of the time).
**Steps to reproduce:**
Open 2 different projects at once with different print statements. Run both projects in a reasonably close timescale and observe both outputs.
| bug,topic:editor | low | Critical |
563,148,904 | vue-element-admin | Vue.js 3.0 future support | I am looking to begin using this project but would like some clarification on how the project will evolve when vue 3.0 is released.
Will the project update its vue version? Do you foresee any breaking changes?
How hard would you see the migration/update effort being for those who build on this template now but want to adopt vue 3.0 in the future?
| in plan | low | Minor |
563,160,268 | angular | Injected ngControl doesn't contain control property in Angular 9 | # π bug report
### Affected Package
`import { NgControl } from '@angular/forms';`
### Is this a regression?
I believe that this is an Ivy compiler issue
### Description
Injected `ngControl` doesn't contain `control` property in Angular 9.
## π¬ Minimal Reproduction
```html
<mat-checkbox formControlName="locked" name="locked" class="m-t-5"
[opDisabled]="!(isEditing && isLocked)">
<span>{{ 'User.Locked' | translate }}</span>
</mat-checkbox>
```
This doesn't work:
```typescript
import { Directive, Input } from '@angular/core';
import { NgControl } from '@angular/forms';
@Directive({
selector: '[opDisabled]'
})
export class DisabledDirective {
@Input()
set opDisabled(condition: boolean) {
const action = condition ? 'disable' : 'enable';
this.ngControl.control[action]();
}
constructor(private ngControl: NgControl) {}
}
```
This works:
```typescript
import { Directive, Input } from '@angular/core';
import { NgControl } from '@angular/forms';
@Directive({
selector: '[opDisabled]'
})
export class DisabledDirective {
@Input()
set opDisabled(condition: boolean) {
const action = condition ? 'disable' : 'enable';
setTimeout(() => this.ngControl.control[action]());
}
constructor(private ngControl: NgControl) {}
}
```
## π₯ Exception or Error
<pre><code>
core.js:5828 ERROR TypeError: Cannot read property 'disable' of undefined
</code></pre>
The `control` property is `undefined` and It looks like the it gets appended asynchronously to the injected `ngControl`, that's why the `setTimeout(() => {...})` workaround seems to work. Is this by design or is it a bug?
There is a similar issue reported [#32522](https://github.com/angular/angular/issues/32522), but locked due to inactivity, without any solutions mentioned in the comments.
## π Your Environment
**Angular Version:**
<pre><code>
_ _ ____ _ ___
/ \ _ __ __ _ _ _| | __ _ _ __ / ___| | |_ _|
/ β³ \ | '_ \ / _` | | | | |/ _` | '__| | | | | | |
/ ___ \| | | | (_| | |_| | | (_| | | | |___| |___ | |
/_/ \_\_| |_|\__, |\__,_|_|\__,_|_| \____|_____|___|
|___/
Angular CLI: 9.0.1
Node: 13.3.0
OS: darwin x64
Angular: 9.0.0
... animations, cdk, common, compiler, compiler-cli, core, forms
... language-service, material, platform-browser
... platform-browser-dynamic, router
Ivy Workspace: Yes
Package Version
-----------------------------------------------------------
@angular-devkit/architect 0.900.1
@angular-devkit/build-angular 0.900.1
@angular-devkit/build-optimizer 0.900.1
@angular-devkit/build-webpack 0.900.1
@angular-devkit/core 9.0.1
@angular-devkit/schematics 9.0.1
@angular/cli 9.0.1
@angular/flex-layout 9.0.0-beta.29
@ngtools/webpack 9.0.1
@schematics/angular 9.0.1
@schematics/update 0.900.1
rxjs 6.5.4
typescript 3.7.5
webpack 4.41.2
</code></pre> | area: forms,P4 | medium | Critical |
563,185,664 | flutter | Android: Extend WidgetsBindingObserver to allow listening on onWindowFocusChanged | ## Use case
On the Dart side I would like to know if the user pulled down the statusbar on Android. According to [this SO answer](https://stackoverflow.com/a/50662025/1800695) this can be achieved with [`onWindowFocusChanged`](https://developer.android.com/reference/android/app/Activity.html?is-external=true#onWindowFocusChanged(boolean)).
I searched for the Flutter equivalent, but could not find any resources on this. I was hoping the [`WidgetsBindingObserver`](https://api.flutter.dev/flutter/widgets/WidgetsBindingObserver-class.html) had this implemented, but unfortunately not. And I can't find any pub.dev package either.
## Proposal
I would propose that the [`WidgetsBindingObserver`](https://api.flutter.dev/flutter/widgets/WidgetsBindingObserver-class.html) also has a method to listen to the [`onWindowFocusChanged`](https://developer.android.com/reference/android/app/Activity.html?is-external=true#onWindowFocusChanged(boolean)). For example like `didChangeAppLifecycleState` add a new method `didChangeWindowFocus`.
| c: new feature,platform-android,framework,would be a good package,c: proposal,P3,team-android,triaged-android | low | Major |
563,187,971 | rust | Non-deterministic perf.rust-lang.org runs (e.g. syn-opt). | https://perf.rust-lang.org/detailed-query.html?commit=e369f6b617bc5124ec5d02626dc1c821589e6eb3&base_commit=4d1241f5158ffd66730e094d8f199ed654ed52ae&benchmark=syn-opt&run_name=patched%20incremental:%20println
This perf run was expected to be a no-op, but appears to have resulted in slightly less queries being run (2 def_span and 2 metadata reads).
cc @eddyb | T-compiler,C-bug,A-reproducibility | medium | Critical |
563,258,362 | terminal | Add Toolbar for WSL OS instances | Please add a left toolbar ([for example like Opera browsers' toolbar](https://cdn-production-opera-website.operacdn.com/staticfiles/assets/images/main/computer/computer-hero.00fc91be943c.png)) to open WSL OS in single click.
| Issue-Feature,Area-UserInterface,Area-Extensibility,Product-Terminal | low | Minor |
563,275,019 | godot | iOS uses more RAM than other platforms when using large AtlasTextures | **Godot version:** 3.2
**OS/device including version:** IOS (iphone 6, iphone x)
**Issue description:**
Im use big atlas 2048x2048, LOSSY 0.7
IOS uses too much memory.
More than android and windows
I do not like the fact that applications on iOS (arm, arm64, x86, x86_64) weigh minimum ~40 mb
(*.a file weight 193mb, all arch)
p.s. andoid apk size min ~15-20mb
android ~200mb peak (Im used cat /adb shell "cat /proc/meminfo")
windows ~190mb
apple in xcode ~300mb (Memory warnings appear)
| bug,platform:ios,topic:porting,needs testing | medium | Critical |
563,360,856 | rust | Lifetime elision doesn't work right with nested self receivers. | <!--
Thank you for filing a bug report! π Please provide a short summary of the bug,
along with any information you feel relevant to replicating the bug.
-->
Seems like lifetime elision doesn't work quite right with nested self receivers. The error messages are also misleading. Of course this can be worked around by providing the annotation in the code
```rust
use std::rc::Rc;
struct S {
val: String,
}
impl S {
// error[E0623]: lifetime mismatch
// --> src/lib.rs:9:9
// |
// 8 | fn rc1(self: &Rc<Self>, _s: &str) -> &str {
// | --------- ----
// | |
// | this parameter and the return type are declared with different lifetimes...
// 9 | self.val.as_ref()
// | ^^^^^^^^^^^^^^^^^ ...but data from `self` is returned here
fn rc1(self: &Rc<Self>, _s: &str) -> &str {
self.val.as_ref()
}
// error[E0106]: missing lifetime specifier
// --> src/lib.rs:11:32
// |
// 11 | fn rc2(self: &Rc<Self>) -> &str {
// | ^ help: consider giving it a 'static lifetime: `&'static`
// |
// = help: this function's return type contains a borrowed value, but there is no value for it to be borrowed from
fn rc2(self: &Rc<Self>) -> &str {
self.val.as_ref()
}
// Compiles fine
fn ref1(&self, _s: &str) -> &str {
self.val.as_ref()
}
// Compiles fine
fn ref2(&self) -> &str {
self.val.as_ref()
}
}
```
#64325 | A-lifetimes,T-lang,T-compiler,C-bug | low | Critical |
563,375,372 | rust | Confusing E0495 error explanation | Consider example.
The error explanation is very confusing for me:
1. Its not obvious what is the problem and what I can do for solving it
2. There are confusing why Rust explains that '&&Foo' is both expected and found:
~~~
= note: expected `&&Foo`
found `&&Foo`
~~~
```rust
#![feature(trait_alias)]
#![feature(generator_trait)]
#![feature(generators)]
use std::ops::Generator;
trait MyGenerator = Generator<Yield = (), Return = ()>;
trait Bar {
fn bar(&self) -> Box<dyn MyGenerator>;
}
struct Foo;
impl Bar for Foo {
fn bar(&self) -> Box<dyn MyGenerator> {
Box::new(|| {
let _x = self;
yield;
})
}
}
```
([Playground](https://play.rust-lang.org/?version=nightly&mode=debug&edition=2018&gist=32ff6f1912ba199046ac323a7613fbc1))
Errors:
```
Compiling playground v0.0.1 (/playground)
error[E0495]: cannot infer an appropriate lifetime due to conflicting requirements
--> src/lib.rs:16:18
|
16 | Box::new(|| {
| __________________^
17 | | let _x = self;
18 | | yield;
19 | | })
| |_________^
|
note: first, the lifetime cannot outlive the anonymous lifetime #1 defined on the method body at 15:5...
--> src/lib.rs:15:5
|
15 | / fn bar(&self) -> Box<dyn MyGenerator> {
16 | | Box::new(|| {
17 | | let _x = self;
18 | | yield;
19 | | })
20 | | }
| |_____^
note: ...so that the types are compatible
--> src/lib.rs:16:18
|
16 | Box::new(|| {
| __________________^
17 | | let _x = self;
18 | | yield;
19 | | })
| |_________^
= note: expected `&&Foo`
found `&&Foo`
= note: but, the lifetime must be valid for the static lifetime...
note: ...so that the expression is assignable
--> src/lib.rs:16:9
|
16 | / Box::new(|| {
17 | | let _x = self;
18 | | yield;
19 | | })
| |__________^
= note: expected `std::boxed::Box<(dyn std::ops::Generator<Yield = (), Return = ()> + 'static)>`
found `std::boxed::Box<dyn std::ops::Generator<Yield = (), Return = ()>>`
error: aborting due to previous error
For more information about this error, try `rustc --explain E0495`.
error: could not compile `playground`.
To learn more, run the command again with --verbose.
``` | C-enhancement,A-diagnostics,A-lifetimes,T-compiler | low | Critical |
563,381,414 | go | cmd/go: error not reported for packages in vendor/ in module mode, without vendoring | ### What version of Go are you using (`go version`)?
<pre>
$ go version
go version go1.13.7 darwin/amd64
</pre>
### Does this issue reproduce with the latest release?
Yes, also reproduces with 1.14rc1.
### What operating system and processor architecture are you using (`go env`)?
<details><summary><code>go env</code> Output</summary><br><pre>
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/jayconrod/Library/Caches/go-build"
GOENV="/Users/jayconrod/Library/Application Support/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GONOPROXY=""
GONOSUMDB=""
GOOS="darwin"
GOPATH="/Users/jayconrod/go"
GOPRIVATE=""
GOPROXY="direct"
GOROOT="/opt/go/installed"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/opt/go/installed/pkg/tool/darwin_amd64"
GCCGO="gccgo"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD="/Users/jayconrod/Code/test/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/rq/x0692kqj6ml8cvrhcqh5bswc008xj1/T/go-build248121802=/tmp/go-build -gno-record-gcc-switches -fno-common"
</pre></details>
### What did you do?
Created a regular package in a directory named `vendor`, not created with `go mod vendor`, not using `-mod=vendor`.
```
! go list -deps example.com/m
-- go.mod --
module example.com/m
go 1.14
-- use.go --
package use
import (
_ "example.com/m/vendor"
_ "example.com/m/vendor/x"
)
-- vendor/vendor.go --
package vendor
-- vendor/x/x.go --
package x
```
### What did you expect to see?
Errors reported for packages in `vendor/` when `-mod=vendor` is not active.
These are being treated as regular packages. Other modules won't be able to import these packages, since vendor directories are excluded from module zip files.
### What did you see instead?
`go list` treats these like regular packages:
```
$ go list -deps example.com/m
example.com/m/vendor
example.com/m/vendor/x
example.com/m
```
cc @matloob @bcmills
| NeedsFix,GoCommand,modules | low | Critical |
563,394,309 | scrcpy | Icon/Favicon/Logo for scrcpy? | Is there a logo for scrcpy that I can use on [the subreddit](https://www.reddit.com/r/scrcpy)? | icon | low | Minor |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.