id
int64 393k
2.82B
| repo
stringclasses 68
values | title
stringlengths 1
936
| body
stringlengths 0
256k
⌀ | labels
stringlengths 2
508
| priority
stringclasses 3
values | severity
stringclasses 3
values |
|---|---|---|---|---|---|---|
572,162,086 | PowerToys | Desktop Icon "Zones" with headers for organization (aka fences) | # Summary of the new feature/enhancement
Some users want ta arange/group there icons on desktop. There are som tools to create group elements on the desktop. Would be nice to have this integrated into PowerToys that the user don't need another application.
# Proposed technical implementation details (optional)
The new PowerToy should show rectangles on desktop on which the user can arrange the icons. The position of icon and group elements should be saved over reboots. It would be nice too, if the the rectangles could be named and coloured. (If other poeple have more ideas for this feature please post them.)
A example what I mean is shown in this foto:
(Stardock Fences, https://www.stardock.com/products/fences/) | Idea-New PowerToy | medium | Critical |
572,173,861 | rust | Clearer error for failed tests which returned a Result Err() | <!-- Thanks for filing a 🐛 bug report 😄! -->
**Problem**
I have a test function which returns a `Result<...>` as a convenient way of testing failable methods. For example:
```rust
#[test]
fn exampletest() -> Result<(), std::io::Error> {
let f = std::fs::File::open("/root/nonexistantfile")?;
assert_eq!(example_method(&f), 0);
Ok(())
}
```
The test started failing for whatever reason, and the `cargo test` output looked like this:
```
$ cargo test
Compiling confusing v0.1.0 (/Users/dbr/confusing)
Finished test [unoptimized + debuginfo] target(s) in 0.42s
Running target/debug/deps/confusing-3ccdc020a15819b0
running 1 test
test exampletest ... FAILED
failures:
---- exampletest stdout ----
Error: Os { code: 2, kind: NotFound, message: "No such file or directory" }
thread 'exampletest' panicked at 'assertion failed: `(left == right)`
left: `1`,
right: `0`: the test returned a termination value with a non-zero status code (1) which indicates a failure', src/libtest/lib.rs:196:5
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
failures:
exampletest
test result: FAILED. 0 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out
error: test failed, to rerun pass '--bin confusing'
```
Not reading the output properly, I interpreted the `panicked at 'assertion failed: ...` as being a failure from my `assert_eq!` and started trying to work out why my `example_method` was returning 0.
I also tried running the tests under a debugger, but the backtrace only pointed at the test closure rather than the probelmatic line:
```
...
13: std::panicking::begin_panic_fmt
at src/libstd/panicking.rs:328
14: test::assert_test_result
at ./<::std::macros::panic macros>:9
15: confusing::exampletest::{{closure}}
at src/main.rs:6
16: core::ops::function::FnOnce::call_once
at /rustc/73528e339aae0f17a15ffa49a8ac608f50c6cf14/src/libcore/ops/function.rs:227
```
..where src/main.rs:6 is the line `fn exampletest() -> Result<(), std::io::Error> {`
**Steps**
<!-- The steps to reproduce the bug. -->
1. Write a test case returning a `Result<...>`
2. Have the test case fail by returning `Err(...)`
3. Misread the output!
**Possible Solution(s)**
I think there are two aspects to this:
First is the panic message from the assert is talking about "internal" details - the exit code of the test. The fact the test (I assume) runs as a process and the exit-code is used to determine failure isn't something I was thinking about while writing/debugging the test.
For this, I think it would help a lot to just simplify the panic message from saying
```
thread 'exampletest' panicked at 'assertion failed: `(left == right)`
left: `1`,
right: `0`: the test returned a termination value with a non-zero status code (1) which indicates a failure', src/libtest/lib.rs:196:5
```
to something more concise like:
```
thread 'exampletest' panicked at 'the test exited with non-zero exit code (1) which indicates a failure', src/libtest/lib.rs:196:5
```
Second part I'm not so clear about, but it seems like the Result isn't being handled specially - the `Err` is just being turned into an exit code, then asserted later. Since the panic comes from this assertion, the backtrace doesn't reference the actual line which failed.
This is different to if I had, say, used `.unwrap()` instead of `?`:
```
...
16: core::result::Result<T,E>::unwrap
at /rustc/73528e339aae0f17a15ffa49a8ac608f50c6cf14/src/libcore/result.rs:933
17: confusing::exampletest
at src/main.rs:7
18: confusing::exampletest::{{closure}}
at src/main.rs:6
19: core::ops::function::FnOnce::call_once
at /rustc/73528e339aae0f17a15ffa49a8ac608f50c6cf14/src/libcore/ops/function.rs:227
...
```
where line 7 is the problem-causing line `let _f = std::fs::File::open("/root/nonexistantfile").unwrap();` - it would be nice if using `?` resulted in a similar traceback
**Notes**
Output of `cargo version`:
```$ cargo version
cargo 1.40.0 (bc8e4c8be 2019-11-22)
```
```
$ rustup show
Default host: x86_64-apple-darwin
rustup home: /Users/dbr/.rustup
installed toolchains
--------------------
stable-x86_64-apple-darwin
nightly-x86_64-apple-darwin
installed targets for active toolchain
--------------------------------------
arm-unknown-linux-musleabihf
wasm32-unknown-unknown
x86_64-apple-darwin
active toolchain
----------------
stable-x86_64-apple-darwin (default)
rustc 1.40.0 (73528e339 2019-12-16)
```
| C-enhancement,T-compiler,A-libtest | low | Critical |
572,196,732 | go | cmd/compile: a flaw in algebraic simplification rules inside Go compiler | <!--
Please answer these questions before submitting your issue. Thanks!
For questions please use one of our forums: https://github.com/golang/go/wiki/Questions
-->
### What version of Go are you using (`go version`)?
<pre>
$ go version
go version go1.14 windows/amd64
</pre>
### Does this issue reproduce with the latest release?
Yes.
### What operating system and processor architecture are you using (`go env`)?
<details><summary><code>go env</code> Output</summary><br><pre>
$ go env
set GO111MODULE= set GOARCH=amd64 set GOBIN= set GOCACHE=C:\Users\Peter\AppData\Local\go-build set GOENV=C:\Users\Peter\AppData\Roaming\go\env set GOEXE=.exe set GOFLAGS= set GOHOSTARCH=amd64 set GOHOSTOS=windows set GOINSECURE= set GONOPROXY= set GONOSUMDB= set GOOS=windows set GOPATH=C:\Users\Peter\go set GOPRIVATE= set GOPROXY=https://proxy.golang.org,direct set GOROOT=D:\Programs\Go set GOSUMDB=sum.golang.org set GOTMPDIR= set GOTOOLDIR=D:\Programs\Go\pkg\tool\windows_amd64 set GCCGO=gccgo set AR=ar set CC=gcc set CXX=g++ set CGO_ENABLED=1 set GOMOD= set CGO_CFLAGS=-g -O2 set CGO_CPPFLAGS= set CGO_CXXFLAGS=-g -O2 set CGO_FFLAGS=-g -O2 set CGO_LDFLAGS=-g -O2 set PKG_CONFIG=pkg-config set GOGCCFLAGS=-m64 -mthreads -fmessage-length=0 -fdebug-prefix-map=C:\Users\Peter\AppData\Local\Temp\go-build872647486=/tmp/go-build -gno-record-gcc-switches
</pre></details>
### What did you do?
<!--
If possible, provide a recipe for reproducing the error.
A complete runnable program is good.
A link on play.golang.org is best.
-->
<pre>
package main
func foo(x int, y int, z int, abc int) int {
return (((((1000 - x) + y) - z) - 10) + abc) - 42;
}
</pre>
### What did you expect to see?
I was expecting to see "abc - x + y - z + 948" as the result.
### What did you see instead?
<pre>
"".foo STEXT nosplit size=46 args=0x28 locals=0x0
0x0000 00000 (1.go:5) TEXT "".foo(SB), NOSPLIT|ABIInternal, $0-40
0x0000 00000 (1.go:5) PCDATA $0, $-2
0x0000 00000 (1.go:5) PCDATA $1, $-2
0x0000 00000 (1.go:5) FUNCDATA $0, gclocals·33cdeccccebe80329f1fdbee7f5874cb(SB)
0x0000 00000 (1.go:5) FUNCDATA $1, gclocals·33cdeccccebe80329f1fdbee7f5874cb(SB)
0x0000 00000 (1.go:5) FUNCDATA $2, gclocals·33cdeccccebe80329f1fdbee7f5874cb(SB)
0x0000 00000 (1.go:6) PCDATA $0, $0
0x0000 00000 (1.go:6) PCDATA $1, $0
0x0000 00000 (1.go:6) MOVQ "".y+16(SP), AX
0x0005 00005 (1.go:6) MOVQ "".x+8(SP), CX
0x000a 00010 (1.go:6) SUBQ CX, AX
0x000d 00013 (1.go:6) ADDQ $1000, AX
0x0013 00019 (1.go:6) MOVQ "".z+24(SP), CX
0x0018 00024 (1.go:6) SUBQ CX, AX
0x001b 00027 (1.go:6) MOVQ "".abc+32(SP), CX
0x0020 00032 (1.go:6) LEAQ (CX)(AX*1), AX
0x0024 00036 (1.go:6) LEAQ -52(AX), AX
0x0028 00040 (1.go:6) MOVQ AX, "".~r4+40(SP)
0x002d 00045 (1.go:6) RET
</pre>
So clearly there is a room for improvement in rules of algebraic simplifications of the compiler.
I suggest to add/replace just a few of reassociate rules in the file "https://github.com/golang/go/blob/master/src/cmd/compile/internal/ssa/gen/generic.rules". I made my own set of rules for add/sub combinations which could be used here:
<pre>
# x + (C - z) -> C + (x - z)
# x - (z - C) -> C + (x - z)
# x - (z + C) -> (x - z) - C
# x - (C - z) -> (x + z) - C
# (x + C) - z -> C + (x - z)
# (C - x) - z -> C - (x - z)
# C + (D - x) -> (C + D) - x
# C + (x - D) -> (C - D) + x
# C - (x - D) -> (C + D) - x
# C - (D - x) -> (C - D) + x
</pre>
I've tested them with my own compiler tools. Hope you will find them useful! | Performance,NeedsInvestigation,compiler/runtime | low | Critical |
572,206,001 | pytorch | Torchscript incompatible with torch.cat for tensor lists | ## 🐛 Bug
Torch.cat throws error for tensor lists when used within torchscript
## To Reproduce
Here is a minimal example to reproduce the bug
```
import torch
import torch.nn as nn
"""
Smallest working bug for torch.cat torchscript
"""
class Model(nn.Module):
"""dummy model for showing error"""
def __init__(self):
super(Model, self).__init__()
pass
def forward(self):
a = torch.rand([6, 1, 12])
b = torch.rand([6, 1, 12])
out = torch.cat([a, b], axis=2)
return out
if __name__ == '__main__':
model = Model()
print(model()) # works
torch.jit.script(model) # throws error
```
Steps to reproduce the behavior:
1. run the code shown above in a pytorch python env
This is the error message provided:
```
File "/home/anil/.conda/envs/rnn/lib/python3.7/site-packages/torch/jit/__init__.py", line 1423, in _create_methods_from_stubs
self._c._create_methods(self, defs, rcbs, defaults)
RuntimeError:
Arguments for call are not valid.
The following operator variants are available:
aten::cat(Tensor[] tensors, int dim=0) -> (Tensor):
Keyword argument axis unknown.
aten::cat.out(Tensor[] tensors, int dim=0, *, Tensor(a!) out) -> (Tensor(a!)):
Argument out not provided.
The original call is:
at smallest_working_bug_torch_cat_torchscript.py:19:14
def forward(self):
a = torch.rand([6, 1, 12])
b = torch.rand([6, 1, 12])
out = torch.cat([a, b], axis=2)
~~~~~~~~~ <--- HERE
return out
```
## Expected behavior
torch.cat is expected to work seamlessly within torchscript if it works outside of it.
## Environment
PyTorch version: 1.3.1
Is debug build: No
CUDA used to build PyTorch: 10.1.243
OS: Ubuntu 18.04.4 LTS
GCC version: (Ubuntu 7.4.0-1ubuntu1~18.04.1) 7.4.0
CMake version: version 3.15.5
Python version: 3.7
Is CUDA available: Yes
CUDA runtime version: Could not collect
GPU models and configuration: GPU 0: GeForce RTX 2080 Ti
Nvidia driver version: 440.59
cuDNN version: Could not collect
Versions of relevant libraries:
[pip] Could not collect
[conda] blas 1.0 mkl
[conda] botorch 0.2.1 pypi_0 pypi
[conda] cuda100 1.0 0 pytorch
[conda] gpytorch 1.0.1 pypi_0 pypi
[conda] mkl 2019.4 243
[conda] mkl-service 2.3.0 py37he904b0f_0
[conda] mkl_fft 1.0.14 py37ha843d7b_0
[conda] mkl_random 1.1.0 py37hd6b4f25_0
[conda] pytorch 1.3.1 py3.7_cuda10.1.243_cudnn7.6.3_0 pytorch
[conda] torchvision 0.4.2 py37_cu101 pytorch
cc @suo | oncall: jit,triaged | low | Critical |
572,227,820 | flutter | Inconsistency in BackdropFilter across web browsers | The `BackdropFilter` has inconsistent behaviour/output across different web browsers.
## Steps to Reproduce
You can reproduce the issue with below code
```dart
String url =
'https://flutter.dev/assets/flutter-lockup-c13da9c9303e26b8d5fc208d2a1fa20c1ef47eb021ecadf27046dea04c0cebf6.png';
void main() => runApp(
MaterialApp(
home: Scaffold(
body: Center(
child: Container(
//to set the margin of the container
margin: const EdgeInsets.all(20.0),
width: 350,
height: 300,
decoration: BoxDecoration(
image: DecorationImage(
image: NetworkImage(url),
fit: BoxFit.contain,
),
),
child: BackdropFilter(
filter: ImageFilter.blur(sigmaX: 2, sigmaY: 2),
child: Container(
color: Colors.black.withOpacity(0),
),
),
),
),
),
),
);
```
Chrome: Version 80.0.3987.122 (Official Build) (64-bit)
Firefox: Version 73.0.1 (64-bit)
| framework,a: quality,platform-web,e: web_html,has reproducible steps,browser: firefox,P3,found in release: 3.7,found in release: 3.10,team-web,triaged-web | low | Minor |
572,251,971 | flutter | Warn on `flutter build` if there's a newer hotfix available | ## Use case
Our data shows that a sizable minority of stable channel installs aren't running the latest hotfix. As of 2/27, 20% of users are running the original `1.12.13+hotfix.5` release, even though it's nearly three months old; 2% are running the pulled `1.12.13+hotfix.6`, and 15% are running the `1.12.13+hotfix.7` release. (`1.12.13+hotfix.8` is the latest.) These older releases include known crashing bugs that will reduce stability of shipping apps. As a general principle, we'd strongly encourage developers on the stable channel to use the latest available hotfix for app store ingestion, to avoid them unwittingly pushing apps with higher crash rates to their customers.
Users may have been trained that "an upgrade means API breakages", and we could probably be intelligent about nudging them more strongly towards _hotfix updates_ (that only contain critical fixes).
## Proposal
There are a variety of things we could do here. One idea is to check on `flutter build` whether there's a later hotfix available, and if so provide a warning that a later hotfix is available. This would be similar to the warning when running `flutter build` on the `master` channel.
@tvolkert also suggested:
> We may also want to provide the facility in the tool to say "upgrade to pick up patch releases / hotfixes only" | tool,a: quality,customer: product,c: proposal,P3,team-tool,triaged-tool | low | Critical |
572,281,538 | pytorch | [jit] Python arg parser / TorchScript incompatibilities | Certain parts of the Python arg parser aren't mirrored in the jit, for example
```python
a = torch.ones(2, 2)
b = torch.ones(2, 2)
def fn(a, b):
torch.cat([a, b], axis=1)
fn(a, b) # works
torch.jit.script(fn) # fails
```
See https://discuss.pytorch.org/t/torch-cat-throws-error-for-tensor-list-when-compiling-with-torchscript/71317/2 for details.
cc @suo | oncall: jit,triaged | low | Critical |
572,287,980 | pytorch | Libtorch segfault when used with libqpOASES | ## 🐛 Bug
I'm trying to use pytorch C++ to solve an optimization problem formulated as quadratic program solved with qpOASES, but it seems like some sort of linking error related to BLAS is triggering a segfault. Not sure if this is strictly a libtorch problem (or the bazel linker setup) but it's a bit over my head so any guidance would be greatly appreciated
## To Reproduce
As far as I can tell all that needs to be done to reproduce this is to link against qpOASES and libtorch in the same binary using Bazel. I can try to provide a minimal example if that would be helpful.
Here's an ASan output for the segfault (you can see the sgemm_ call looks like it's inside libqpOASES):
```
==29495==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x61200020abc0 at pc 0x7f103e407e2d bp 0x7f10273d3f90 sp 0x7f10273d3738
WRITE of size 17179869440 at 0x61200020abc0 thread T5 (control)
#0 0x7f103e407e2c (/usr/lib/x86_64-linux-gnu/libasan.so.5+0x66e2c)
#1 0x7f103da0fd7f in sgemm_ (/home/pedro/control/.bazel-cache/f7ef1140462b94ef7f70149772f48db7/execroot/__main__/bazel-out/k8-dbg-asan/bin/src/../_solib_k8/_U_S_Ssrc_Ssolvers_Squadratic_Uprogramming_SqpOASES_CqpOASES_Ulib___Usrc_Ssolvers_Squadratic_Uprogramming_SqpOASES/libqpOASES.so+0x5ed7f)
#2 0x7f102fbb8f70 in THFloatBlas_gemm (/home/pedro/control/.bazel-cache/f7ef1140462b94ef7f70149772f48db7/execroot/__main__/bazel-out/k8-dbg-asan/bin/src/../_solib_k8/_U@pytorch_S_S_Cpytorch___Uexternal_Spytorch_Slibtorch_Slib/libtorch.so+0x16d4f70)
#3 0x7f102f8a098d in THFloatTensor_addmmImpl(c10::TensorImpl*, c10::TensorImpl*, c10::TensorImpl*, c10::TensorImpl*, float, float) [clone .constprop.789] (/home/pedro/control/.bazel-cache/f7ef1140462b94ef7f70149772f48db7/execroot/__main__/bazel-out/k8-dbg-asan/bin/src/../_solib_k8/_U@pytorch_S_S_Cpytorch___Uexternal_Spytorch_Slibtorch_Slib/libtorch.so+0x13bc98d)
#4 0x7f102f8a0dfe in THFloatTensor_addmm (/home/pedro/control/.bazel-cache/f7ef1140462b94ef7f70149772f48db7/execroot/__main__/bazel-out/k8-dbg-asan/bin/src/../_solib_k8/_U@pytorch_S_S_Cpytorch___Uexternal_Spytorch_Slibtorch_Slib/libtorch.so+0x13bcdfe)
#5 0x7f102f753775 in at::native::legacy::cpu::_th_mm(at::Tensor const&, at::Tensor const&) (/home/pedro/control/.bazel-cache/f7ef1140462b94ef7f70149772f48db7/execroot/__main__/bazel-out/k8-dbg-asan/bin/src/../_solib_k8/_U@pytorch_S_S_Cpytorch___Uexternal_Spytorch_Slibtorch_Slib/libtorch.so+0x126f775)
#6 0x7f102f69bc8b in at::CPUType::(anonymous namespace)::mm(at::Tensor const&, at::Tensor const&) (/home/pedro/control/.bazel-cache/f7ef1140462b94ef7f70149772f48db7/execroot/__main__/bazel-out/k8-dbg-asan/bin/src/../_solib_k8/_U@pytorch_S_S_Cpytorch___Uexternal_Spytorch_Slibtorch_Slib/libtorch.so+0x11b7c8b)
#7 0x7f102f6a0eb3 in c10::detail::wrap_kernel_functor_unboxed_<c10::detail::WrapRuntimeKernelFunctor_<at::Tensor (*)(at::Tensor const&, at::Tensor const&), at::Tensor, c10::guts::typelist::typelist<at::Tensor const&, at::Tensor const&> >, at::Tensor (at::Tensor const&, at::Tensor const&)>::call(c10::OperatorKernel*, at::Tensor const&, at::Tensor const&) (/home/pedro/control/.bazel-cache/f7ef1140462b94ef7f70149772f48db7/execroot/__main__/bazel-out/k8-dbg-asan/bin/src/../_solib_k8/_U@pytorch_S_S_Cpytorch___Uexternal_Spytorch_Slibtorch_Slib/libtorch.so+0x11bceb3)
#8 0x7f102f13bcd4 in std::result_of<c10::Dispatcher::callUnboxed<at::Tensor, at::Tensor const&, at::Tensor const&>(c10::OperatorHandle const&, at::Tensor const&, at::Tensor const&) const::{lambda(c10::DispatchTable const&)#1} (c10::DispatchTable const&)>::type c10::LeftRight<c10::DispatchTable>::read<c10::Dispatcher::callUnboxed<at::Tensor, at::Tensor const&, at::Tensor const&>(c10::OperatorHandle const&, at::Tensor const&, at::Tensor const&) const::{lambda(c10::DispatchTable const&)#1}>(c10::Dispatcher::callUnboxed<at::Tensor, at::Tensor const&, at::Tensor const&>(c10::OperatorHandle const&, at::Tensor const&, at::Tensor const&) const::{lambda(c10::DispatchTable const&)#1}&&) const (/home/pedro/control/.bazel-cache/f7ef1140462b94ef7f70149772f48db7/execroot/__main__/bazel-out/k8-dbg-asan/bin/src/../_solib_k8/_U@pytorch_S_S_Cpytorch___Uexternal_Spytorch_Slibtorch_Slib/libtorch.so+0xc57cd4)
#9 0x7f10315eadb8 in torch::autograd::VariableType::(anonymous namespace)::mm(at::Tensor const&, at::Tensor const&) (/home/pedro/control/.bazel-cache/f7ef1140462b94ef7f70149772f48db7/execroot/__main__/bazel-out/k8-dbg-asan/bin/src/../_solib_k8/_U@pytorch_S_S_Cpytorch___Uexternal_Spytorch_Slibtorch_Slib/libtorch.so+0x3106db8)
#10 0x7f102f6a0eb3 in c10::detail::wrap_kernel_functor_unboxed_<c10::detail::WrapRuntimeKernelFunctor_<at::Tensor (*)(at::Tensor const&, at::Tensor const&), at::Tensor, c10::guts::typelist::typelist<at::Tensor const&, at::Tensor const&> >, at::Tensor (at::Tensor const&, at::Tensor const&)>::call(c10::OperatorKernel*, at::Tensor const&, at::Tensor const&) (/home/pedro/control/.bazel-cache/f7ef1140462b94ef7f70149772f48db7/execroot/__main__/bazel-out/k8-dbg-asan/bin/src/../_solib_k8/_U@pytorch_S_S_Cpytorch___Uexternal_Spytorch_Slibtorch_Slib/libtorch.so+0x11bceb3)
#11 0x7f102f13bcd4 in std::result_of<c10::Dispatcher::callUnboxed<at::Tensor, at::Tensor const&, at::Tensor const&>(c10::OperatorHandle const&, at::Tensor const&, at::Tensor const&) const::{lambda(c10::DispatchTable const&)#1} (c10::DispatchTable const&)>::type c10::LeftRight<c10::DispatchTable>::read<c10::Dispatcher::callUnboxed<at::Tensor, at::Tensor const&, at::Tensor const&>(c10::OperatorHandle const&, at::Tensor const&, at::Tensor const&) const::{lambda(c10::DispatchTable const&)#1}>(c10::Dispatcher::callUnboxed<at::Tensor, at::Tensor const&, at::Tensor const&>(c10::OperatorHandle const&, at::Tensor const&, at::Tensor const&) const::{lambda(c10::DispatchTable const&)#1}&&) const (/home/pedro/control/.bazel-cache/f7ef1140462b94ef7f70149772f48db7/execroot/__main__/bazel-out/k8-dbg-asan/bin/src/../_solib_k8/_U@pytorch_S_S_Cpytorch___Uexternal_Spytorch_Slibtorch_Slib/libtorch.so+0xc57cd4)
#12 0x7f102f21535e in at::Tensor::mm(at::Tensor const&) const (/home/pedro/control/.bazel-cache/f7ef1140462b94ef7f70149772f48db7/execroot/__main__/bazel-out/k8-dbg-asan/bin/src/../_solib_k8/_U@pytorch_S_S_Cpytorch___Uexternal_Spytorch_Slibtorch_Slib/libtorch.so+0xd3135e)
#13 0x7f102f201043 in at::native::matmul(c10::optional<at::Tensor>, at::Tensor const&, at::Tensor const&) (/home/pedro/control/.bazel-cache/f7ef1140462b94ef7f70149772f48db7/execroot/__main__/bazel-out/k8-dbg-asan/bin/src/../_solib_k8/_U@pytorch_S_S_Cpytorch___Uexternal_Spytorch_Slibtorch_Slib/libtorch.so+0xd1d043)
#14 0x7f102f2026e9 in at::native::matmul(at::Tensor const&, at::Tensor const&) (/home/pedro/control/.bazel-cache/f7ef1140462b94ef7f70149772f48db7/execroot/__main__/bazel-out/k8-dbg-asan/bin/src/../_solib_k8/_U@pytorch_S_S_Cpytorch___Uexternal_Spytorch_Slibtorch_Slib/libtorch.so+0xd1e6e9)
#15 0x7f102f777db4 in at::TypeDefault::matmul(at::Tensor const&, at::Tensor const&) (/home/pedro/control/.bazel-cache/f7ef1140462b94ef7f70149772f48db7/execroot/__main__/bazel-out/k8-dbg-asan/bin/src/../_solib_k8/_U@pytorch_S_S_Cpytorch___Uexternal_Spytorch_Slibtorch_Slib/libtorch.so+0x1293db4)
#16 0x7f103132667d in torch::autograd::VariableType::(anonymous namespace)::matmul(at::Tensor const&, at::Tensor const&) (/home/pedro/control/.bazel-cache/f7ef1140462b94ef7f70149772f48db7/execroot/__main__/bazel-out/k8-dbg-asan/bin/src/../_solib_k8/_U@pytorch_S_S_Cpytorch___Uexternal_Spytorch_Slibtorch_Slib/libtorch.so+0x2e4267d)
#17 0x7f102f6a0eb3 in c10::detail::wrap_kernel_functor_unboxed_<c10::detail::WrapRuntimeKernelFunctor_<at::Tensor (*)(at::Tensor const&, at::Tensor const&), at::Tensor, c10::guts::typelist::typelist<at::Tensor const&, at::Tensor const&> >, at::Tensor (at::Tensor const&, at::Tensor const&)>::call(c10::OperatorKernel*, at::Tensor const&, at::Tensor const&) (/home/pedro/control/.bazel-cache/f7ef1140462b94ef7f70149772f48db7/execroot/__main__/bazel-out/k8-dbg-asan/bin/src/../_solib_k8/_U@pytorch_S_S_Cpytorch___Uexternal_Spytorch_Slibtorch_Slib/libtorch.so+0x11bceb3)
#18 0x7f1031c053ce in torch::nn::functional::linear(at::Tensor const&, at::Tensor const&, at::Tensor const&) (/home/pedro/control/.bazel-cache/f7ef1140462b94ef7f70149772f48db7/execroot/__main__/bazel-out/k8-dbg-asan/bin/src/../_solib_k8/_U@pytorch_S_S_Cpytorch___Uexternal_Spytorch_Slibtorch_Slib/libtorch.so+0x37213ce)
#19 0x7f1031c048fd in torch::nn::LinearImpl::forward(at::Tensor const&) (/home/pedro/control/.bazel-cache/f7ef1140462b94ef7f70149772f48db7/execroot/__main__/bazel-out/k8-dbg-asan/bin/src/../_solib_k8/_U@pytorch_S_S_Cpytorch___Uexternal_Spytorch_Slibtorch_Slib/libtorch.so+0x37208fd)
...
#29 0x5597db8a8efa in _M_invoke<0> /usr/include/c++/9/thread:244
#30 0x5597db8a8efa in operator() /usr/include/c++/9/thread:251
#31 0x5597db8a8efa in _M_run /usr/include/c++/9/thread:195
#32 0x7f103e09186f (/usr/lib/x86_64-linux-gnu/libstdc++.so.6+0xd086f)
#33 0x7f102e0c86da in start_thread /build/glibc-OTsEL5/glibc-2.27/nptl/pthread_create.c:463
#34 0x7f102dbd988e in __clone (/lib/x86_64-linux-gnu/libc.so.6+0x12188e)
0x61200020abc0 is located 0 bytes to the right of 256-byte region [0x61200020aac0,0x61200020abc0)
allocated by thread T5 (control) here:
#0 0x7f103e4ade0d in posix_memalign (/usr/lib/x86_64-linux-gnu/libasan.so.5+0x10ce0d)
#1 0x7f103d53cd57 in c10::alloc_cpu(unsigned long) (/home/pedro/control/.bazel-cache/f7ef1140462b94ef7f70149772f48db7/execroot/__main__/bazel-out/k8-dbg-asan/bin/src/../_solib_k8/_U@pytorch_S_S_Cpytorch___Uexternal_Spytorch_Slibtorch_Slib/libc10.so+0x10d57)
Thread T5 (control) created by T0 (ar-control) here:
#0 0x7f103e3dae71 in __interceptor_pthread_create (/usr/lib/x86_64-linux-gnu/libasan.so.5+0x39e71)
#1 0x7f103e091b04 in std::thread::_M_start_thread(std::unique_ptr<std::thread::_State, std::default_delete<std::thread::_State> >, void (*)()) (/usr/lib/x86_64-linux-gnu/libstdc++.so.6+0xd0b04)
...
#4 0x5597d8f8fa65 in main src/main.cpp:133
#5 0x7f102dad9b96 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21b96)
SUMMARY: AddressSanitizer: heap-buffer-overflow (/usr/lib/x86_64-linux-gnu/libasan.so.5+0x66e2c)
Shadow bytes around the buggy address:
0x0c2480039520: fa fa fa fa fa fa fa fa 00 00 00 00 00 00 00 00
0x0c2480039530: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
0x0c2480039540: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
0x0c2480039550: fa fa fa fa fa fa fa fa 00 00 00 00 00 00 00 00
0x0c2480039560: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
=>0x0c2480039570: 00 00 00 00 00 00 00 00[fa]fa fa fa fa fa fa fa
0x0c2480039580: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
0x0c2480039590: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
0x0c24800395a0: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
0x0c24800395b0: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
0x0c24800395c0: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
Shadow byte legend (one shadow byte represents 8 application bytes):
Addressable: 00
Partially addressable: 01 02 03 04 05 06 07
Heap left redzone: fa
Freed heap region: fd
Stack left redzone: f1
Stack mid redzone: f2
Stack right redzone: f3
Stack after return: f5
Stack use after scope: f8
Global redzone: f9
Global init order: f6
Poisoned by user: f7
Container overflow: fc
Array cookie: ac
Intra object redzone: bb
ASan internal: fe
Left alloca redzone: ca
Right alloca redzone: cb
Shadow gap: cc
==29495==ABORTING
```
## Environment
- PyTorch Version (e.g., 1.0): 1.4.0, cpu-only, cxx11 abi
- OS (e.g., Linux): Ubuntu 18.04
- How you installed PyTorch (`conda`, `pip`, source): CPU only release binary
- Build command you used (if compiling from source): n/a
- Python version: n/a
- CUDA/cuDNN version: none
- GPU models and configuration: none
| module: build,triaged | low | Critical |
572,302,932 | flutter | TextSpan could use Tooltip support | It would be really useful to add tooltip property to a TextSpan so you can pass a tooltip to the particular part of the text | c: new feature,framework,good first issue,P3,team-framework,triaged-framework | medium | Major |
572,313,881 | vscode | Diagnostic link hovers should show target | From https://github.com/microsoft/vscode/issues/11847
I know we have the trusted link infrastructure but I would like to see the target of a diagnostic code link if possible, would it be possible to show the link in the tooltip when I hover it?
I can't think of any other places where there is no way to tell where the link goes before clicking it and that makes me nervous about clicking it. | feature-request,error-list,languages-diagnostics | low | Minor |
572,354,165 | pytorch | Docs for uniform_ don't make any sense | It says `P(x) = 1/(to - from)` but this formula is only true for discrete types (also there needs to be a condition on x anyway)
cc @fritzo @neerajprad @alicanb @vishwakftw | module: distributions,triaged | low | Major |
572,364,785 | godot | Vulkan: Editor hang when syncing bones to polygons in 2D IK | **Godot version:** master (947a6636f70ea5a051efd6e470147072f2bc7f13)
**OS/device including version:** mac OS 10.15.2
**Issue description:** Editor hangs when syncing bones to polygons in 2D IK. Seems to be stuck in infinite loop at `rasterizer_canvas_rd.cpp`:888
```
at: _render_item (servers/visual/rasterizer_rd/rasterizer_canvas_rd.cpp:888)
2020-02-27 22:07:29.922442+0100 godot.osx.tools.64[31375:1025108] ERROR: Condition "!pb" is true. Continuing.
at: _render_item (servers/visual/rasterizer_rd/rasterizer_canvas_rd.cpp:888)
ERROR: Condition "!pb" is true. Continuing.
```
**Steps to reproduce:**
1. Open attached project
2. Open `Person` scene
3. Select ArmRR polygon
4. Open the `uv` dialog
5. Go to `Bones` and click `Sync Bones to Polygons`
6. Select the bone for the arm
7. Select the add influence icon (white circle) and start drawing over the polygon
**Minimal reproduction project:**
[ik2d.zip](https://github.com/godotengine/godot/files/4264088/ik2d.zip)
| bug,topic:rendering,topic:editor | low | Critical |
572,369,236 | storybook | A11y Addon error option | **Is your feature request related to a problem? Please describe.**
Can we pass some extra options in the a11y addon to allow for errors to be passed actively to the component viewer (like an eslint error)?
**Describe the solution you'd like**
The axe tooling already provides the detail/content we would need, and it would be awesome to have errors "stop" development (see screenshot below) based on the level (Serious, Moderate, etc.) - options something like:
```
error: true,
errorLevel: 'Serious'
```
**Describe alternatives you've considered**
CLI tests (duplicate efforts), storyshots testing (don't really need jest, etc. just for this)
**Are you able to assist bring the feature to reality?**
Myself or the team I work with may be able to help but wasn't sure if this was a desired/possible feature.
**Additional context**
<img width="959" alt="Screen Shot 2020-02-27 at 3 21 26 PM" src="https://user-images.githubusercontent.com/18293479/75487854-dbfb9d80-5974-11ea-9d19-5fe8cce092d4.png">
| feature request,addon: a11y | low | Critical |
572,449,524 | godot | Export Windows: Rightclick on Taskbar icon of exported game says "Godot Engine" | **Godot version:** 3.2.stable
**OS/device including version:** Win 64
**Issue description:**
Right clicking on the Taskbar Icon of the exported game says "Godot Engine" instead of the game name.
Hovering over the taskbar icon correctly shows the Project Name (as set in the Project Settings), equally correct is the name in the window when the game does not run in fullscreen mode.
**Steps to reproduce:**
Export game to Windows, right click on the taskbar icon. | bug,platform:windows,topic:porting | low | Major |
572,562,445 | godot | Spinbox still can be clicked even when mouse_filter set to Ignore | **Godot version:**
Godot 3.2.stable
**OS/device including version:**
Windows 10
**Issue description:**
The lineedit part of the spinbox still can be clicked even when mouse_filter set to Ignore. All element of the spinbox should not receive input when mouse_filter set to Ignore.
**Steps to reproduce:**
Make new scene
Add spinbox
Set the mouse_filter to Ignore
Click and also edit the spinbox
**Minimal reproduction project:**
Just do reproduction step. | bug,topic:gui | low | Minor |
572,588,910 | flutter | A discrete RangeSlider is not draggable inside a ListView. | A **RangeSlider** is awesome. But when its discrete version **is put inside a ListView**, an annoying bug arises. For simplicity, let's say we're using the Left-to-Right directionality.
1) Let's visually cut the Starting Thumb vertically on 2 halves: if you touch its right half and begin to drag this thumb to the right - it doesn't start to move...
2) The same happens with the Ending Thumb, if you touch its left half and begin to drag it to the left.
```
import 'package:flutter/material.dart';
class SimpleTest extends StatelessWidget {
@override
Widget build(BuildContext context) {
return Scaffold(
body: ListView(
padding: const EdgeInsets.only(top: 100.0),
children: <Widget>[
RangeTest(),
],
),
);
}
}
class RangeTest extends StatefulWidget {
@override
_RangeTestState createState() => _RangeTestState();
}
class _RangeTestState extends State<RangeTest> {
var _values = RangeValues(2.0, 8.0);
@override
Widget build(BuildContext context) {
return RangeSlider(
values: _values,
onChanged: (rangeValues) => setState(() {
_values = rangeValues;
}),
min: 0.0,
max: 10.0,
divisions: 10,
);
}
}
```
| framework,f: material design,has reproducible steps,found in release: 3.7,team-design,triaged-design | medium | Critical |
572,626,250 | go | x/net/proxy: SOCKS5 Timeout is not working properly | After successful connection to the proxy timeout doesn't work any more. So it's hanging a long time trying to connect from proxy to an "addr" endpoint (I suppose).
It' would be good to have a global socket timeout option.
### What version of Go are you using (`go version`)?
1.13
### Does this issue reproduce with the latest release?
Yes
### What operating system and processor architecture are you using (`go env`)?
<details><summary><code>go env</code> Output</summary><br><pre>
$ go env
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/root666/.cache/go-build"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/home/root666/work/go/"
GOPROXY=""
GORACE=""
GOROOT="/usr/local/go"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build754930586=/tmp/go-build -gno-record-gcc-switches"
</pre></details>
</pre></details>
### What did you do?
```Go
func Client(socks, addr string) (net.Conn, error) {
dialer, err := proxy.SOCKS5("tcp", socks, nil, &net.Dialer{Timeout: 3 * time.Second})
if err != nil {
return nil, err
}
conn, err := dialer.Dial("tcp", addr)
if err != nil {
return nil, err
}
return conn, err
}
```
### What did you expect to see?
Timeout with 3 seconds
### What did you see instead?
Timeout more then 10 seconds.
| NeedsInvestigation | low | Critical |
572,629,755 | ant-design | Keyboard navigation not working for "Tree" component, as is working for TreeSelect component | - [x] I have searched the [issues](https://github.com/ant-design/ant-design/issues) of this repository and believe that this is not a duplicate.
### Reproduction link
[https://codepen.io/benjaminr-ps/pen/eYNWMye?editors=0010](https://codepen.io/benjaminr-ps/pen/eYNWMye?editors=0010)
### Steps to reproduce
Declare a Tree component. with treeData at least defined.
### What is expected?
Using the keyboard arrow keys, up-down-left-right, will let you navigate through the tree, by changing the selected item, or expand/collapse an item.
### What is actually happening?
The keyboard arrow keys are not funtional.
It might only affect the srollbar usage.
| Environment | Info |
|---|---|
| antd | 4.0.0 |
| React | ^16.12.0 |
| System | Windows 10 |
| Browser | Firefox 73.0.1; Chrome 80.0.3987.122 |
---
The TreeSelect component uses internally the Tree component, and supports somehow the keyboard navigation.
<!-- generated by ant-design-issue-helper. DO NOT REMOVE --> | Inactive,⌨️ Accessibility | low | Minor |
572,634,848 | TypeScript | "Infer types from usage" not consider js object initializer | **TypeScript Version:** Nightly
**Search Terms:** infer types from usage
**Code**
```ts
function foo(/*infer parameters from usage 'here'*/x) {
let obj1: { a: string } = { a: '' }
obj1.a = x;
let obj2: { a: boolean } = { a: true };
obj2.a = x;
bar({ a: x });
}
function bar(obj: { a: object }) {
}
```
**Expected behavior:**
`foo` become to `foo(x: string|boolean|object)`
**Actual behavior:**
`foo` become to `foo(x: string|boolean)`
**Playground Link:** [Playground](http://www.typescriptlang.org/play/?ts=3.9.0-dev.20200227#code/GYVwdgxgLglg9mABMOcAUAPAlIg3gWACgBIAGwFMpE4AjAKwEYAuPRAQxYGcoAnGMAOaIAvogC8rDogDk0kUWK1GAOjbjEGANwKKVJQCYWudixqoKbJKInGpvEORHaSB1eq0KabHmlssMIljOwkREoJCwCIhePkpGJtT05NCBeEQhhEA)
| Suggestion,Experience Enhancement | low | Minor |
572,644,440 | rust | Later use of borrow is not explained if it happens in case of panic | This code:
```rust
struct DropRef<'a>(&'a String);
impl<'a> Drop for DropRef<'a> {
fn drop(&mut self) {}
}
fn bar(mut x: String) {
let a = DropRef(&x);
let b = &mut x;
panic!();
}
```
Produces the error:
```
error[E0502]: cannot borrow `x` as mutable because it is also borrowed as immutable
--> src/lib.rs:11:13
|
10 | let a = DropRef(&x);
| -- immutable borrow occurs here
11 | let b = &mut x;
| ^^^^^^ mutable borrow occurs here
```
It does not explain where the immutable borrow is used later. If you remove the `panic!();`, then you get an error with the explanation included:
```
error[E0502]: cannot borrow `x` as mutable because it is also borrowed as immutable
--> src/lib.rs:11:13
|
10 | let a = DropRef(&x);
| -- immutable borrow occurs here
11 | let b = &mut x;
| ^^^^^^ mutable borrow occurs here
12 | // panic!();
13 | }
| - immutable borrow might be used here, when `a` is dropped and runs the `Drop` code for type `DropRef`
```
### Meta
Rust version 1.41.1 (current version in rust playground).
Same happens on beta and nightly. | C-enhancement,A-diagnostics,A-borrow-checker,T-compiler | low | Critical |
572,646,463 | TypeScript | Any type is inferred when function input parameter is set to some value | **TypeScript Version:** 3.8.2
<!-- Search terms you tried before logging this (so others can find this issue more easily) -->
**Search Terms:** any type is inferred
**Code**
```ts
interface ContinuationQueryResult<T> {
documents: T[];
continuation?: string;
}
function abc(continuation?: string): Promise<ContinuationQueryResult<string>> {
return <any>undefined;
}
async function test() {
// When not explicitly set to undefined type is inferred correctly.
let continuation: string | undefined = undefined;
do {
const summaries = await abc(continuation);
continuation = summaries.continuation;
} while (continuation)
}
```
**Expected behavior:**
Type of summaries variable should be `ContinuationQueryResult<string>`.
**Actual behavior:**
summaries variable is inferred as any.
**Playground Link:** https://www.typescriptlang.org/play/#code/JYOwLgpgTgZghgYwgAgMIHtygK5zMTARW2gE8AlCAZ2wBswAeAFQD5kBvAWAChk-kAJugTYAthHBUAXMiYBtALoBuHv2QJM+ELnyYA-DKpgooAOYruAXx48Y2EAl0hkcAEYIAFBqza8BEAbIRiYgpgCUMgAKUOiiwFQQDBg+Ov7EZJQ09AzBZixsXLz8UBBg2FDODHAgpCz2AhAwoBACFtbcPHBUpA7Idg5OyJBGHmEcqvwA9JPIAOoAFhLIIOhgyBAAHgAOtMAIwGC0pEGlQ+jI9Y3NAkOkWyjxyKAw0CU3GlAljkcAdBN8tFO3i0qUwhmMZmQAB8LiAGk0QC1kABeWHw64Wf6Cc6FNRqbxGIJiURwEzUFEuADucAOLncXk0OD8mDCmKKePUjN8g1RNFEJLJVB+wKZTgsaksyEp82AgOQDJSzJAYR4liAA
**Related Issues:** | Bug | low | Minor |
572,660,709 | go | cmd/go: a /.. after a ... in an importpath pattern is confusing | <!-- Please answer these questions before submitting your issue. Thanks! -->
### What version of Go are you using (`go version`)?
<pre>
$ go version
go version go1.14 linux/amd64
</pre>
### Does this issue reproduce with the latest release?
Yes. It also reproduces with all versions of `go` (tested up to `go1.5`).
### What operating system and processor architecture are you using (`go env`)?
<details><summary><code>go env</code> Output</summary><br><pre>
$ go env
GO111MODULE="on"
GOARCH="amd64"
GOBIN="/home/manlio/.local/bin"
GOCACHE="/home/manlio/.cache/go-build"
GOENV="/home/manlio/.config/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GONOPROXY="github.com/perillo/go-init"
GONOSUMDB="github.com/perillo/go-init"
GOOS="linux"
GOPATH="/home/manlio/.local/lib/go:/home/manlio/src/go"
GOPRIVATE="github.com/perillo/go-init"
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/lib/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/lib/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="/dev/null"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build295792619=/tmp/go-build -gno-record-gcc-switches"
GOROOT/bin/go version: go version go1.14 linux/amd64
GOROOT/bin/go tool compile -V: compile version go1.14
uname -sr: Linux 5.5.6-arch1-1
/usr/lib/libc.so.6: GNU C Library (GNU libc) stable release version 2.31.
gdb --version: GNU gdb (GDB) 9.1
</pre></details>
### What did you do?
From inside the root directory of a module:
```
$ mkdir build
$ cd build
$ go list .../../
can't load package: package .: no Go files in /home/manlio/src/go/src/github.com/perillo/atexit/build
$ go list .../../../ [0]
github.com/perillo/atexit
```
How are `/..` interpreted when after a `...` in a pattern?
| help wanted,NeedsFix | low | Critical |
572,727,309 | TypeScript | Bug: strictNullChecks + object spread + computed key | <!-- 🚨 STOP 🚨 𝗦𝗧𝗢𝗣 🚨 𝑺𝑻𝑶𝑷 🚨
Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Even if you think you've found a *bug*, please read the FAQ first, especially the Common "Bugs" That Aren't Bugs section!
Please help us by doing the following steps before logging an issue:
* Search: https://github.com/Microsoft/TypeScript/search?type=Issues
* Read the FAQ: https://github.com/Microsoft/TypeScript/wiki/FAQ
Please fill in the *entire* template below.
-->
**TypeScript Version:** 3.8.2
<!-- Search terms you tried before logging this (so others can find this issue more easily) -->
**Search Terms:**
* strictNullChecks
* object spread
* computed key
**Code**
```ts
const b = { a: 'hello' };
const key: string = 'hello';
const a: Record<string, string> = { ...b, [key]: undefined };
```
**Expected behavior:**
Type check fails
**Actual behavior:**
No Typecheck error.
It is interesting that if we remove explicit `string` type for `key` the code is not compilable as expected.
**Playground Link:**
https://www.typescriptlang.org/play/?ssl=1&ssc=1&pln=4&pc=1#code/MYewdgzgLgBARjAvDA3jAhgLhgcgBYCmANkSDjAL4DcAsAFCiSwDWBAnttAE4CWYA5klyESZWg3DQM2AEoFQXACYAebn34AaGGoEA+IWgB0xuFoDarNgF1sAVzCKCAMz4FFlcUA
| Bug | low | Critical |
572,767,185 | react-native | Missing NSLocationAlwaysUsageDescription in Info.plist without any GeoLocation Usage in 0.61.5 (ITMS-90683) | Description:
I am getting E-Mail from Apple after submitting to App Store Connect regarding ITMS-90683. It basically says that I have to include `NSLocationAlwaysUsageDescription` and `NSLocationWhenInUseUsageDescription` in my Info.plist because they say that my
> app's code references one or more APIs that access sensitive user data.
Now, I do not use any of react natives geolocation functions. I have scanned my whole repo for anything regarding these APIs, and the only thing which came up was `RCTConvert+CoreLocation.h` (https://github.com/facebook/react-native/blob/master/React/Views/RCTConvert%2BCoreLocation.h) and it's ".m" file. These do import "CoreLocation", which could be enough to trigger this E-Mail, as suggested [here](https://github.com/facebook/react-native/issues/20879#issuecomment-592505530).
See this issue for explaining the whole background: https://github.com/facebook/react-native/issues/20879.
React Native version:
```
System:
OS: macOS Mojave 10.14.6
CPU: (8) x64 Intel(R) Core(TM) i7-4980HQ CPU @ 2.80GHz
Memory: 22.33 MB / 16.00 GB
Shell: 5.3 - /bin/zsh
Binaries:
Node: 12.12.0 - /usr/local/bin/node
npm: 6.13.6 - /usr/local/bin/npm
Watchman: 4.9.0 - /usr/local/bin/watchman
SDKs:
iOS SDK:
Platforms: iOS 13.2, DriverKit 19.0, macOS 10.15, tvOS 13.2, watchOS 6.1
Android SDK:
API Levels: 28, 29
Build Tools: 28.0.3, 29.0.2
System Images: android-28 | Intel x86 Atom_64, android-29 | Google APIs Intel x86 Atom
IDEs:
Android Studio: 3.5 AI-191.8026.42.35.5977832
Xcode: 11.3.1/11C504 - /usr/bin/xcodebuild
npmPackages:
react: 16.9.0 => 16.9.0
react-native: 0.61.5 => 0.61.5
npmGlobalPackages:
react-native-eject: 0.1.2
```
## Steps To Reproduce
1. Bootstrap a clean react native app.
2. Submit it to App Store connect.
## Expected Results
As Geolocation was supposed to be extracted from the core, I wonder why I still get this warning. I do not consider adding the mentioned values in my plist, as I expect that it will most likely show on some user facing screen that the app is using location services when it is definitely not.
| Platform: iOS,API: Geolocation,Impact: App Rejected,Never gets stale | low | Major |
572,793,843 | kubernetes | Pulling/Extracting docker image continues after removing the pod | <!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks!
If the matter is security related, please disclose it privately via https://kubernetes.io/security/
-->
**What happened**:
If you create pod with a large docker image and delete it without waiting for it to start, then kubelet will continue to download and unpack the image for the deleted pod
**What you expected to happen**:
abort pulling/extracting docker image if pod will be deleted
**How to reproduce it (as minimally and precisely as possible)**:
Create pod with a large docker image and delete it without waiting for it to start
**Anything else we need to know?**:
**Environment**:
- Kubernetes version (use `kubectl version`): 1.17.2
- Cloud provider or hardware configuration: baremetal
- OS (e.g: `cat /etc/os-release`): 18.04.3 LTS (Bionic Beaver)
- Kernel (e.g. `uname -a`): 5.3.0-40-generic
- Install tools:
- Network plugin and version (if this is a network-related bug):
- Others:
| kind/bug,priority/backlog,area/kubelet,sig/node,priority/important-longterm,lifecycle/frozen,triage/accepted | medium | Critical |
572,810,596 | flutter | Test in flutter template app should be commented out | When a developer creates a new Flutter app, there's a test included. Most developers probably don't notice this test and it's immediately going to start failing when they start changing the app. The same applies to plugins.
If we commented out the actual logic of the test code, we could achieve our goal of helping developers learn how to write tests without having failing tests. This would make it easier to tell whether a project that is failing its tests is doing so because it has no tests written or if it has real tests that are broken. | a: tests,tool,P3,team-tool,triaged-tool | low | Critical |
572,811,049 | PowerToys | [FZ Editor] Allow margin syntax for Show Space Around Zones | Having space around the zones is great!
However, I really don't want any spaces at the top and bottom of the zones. To make everyone happy, can you enable margin syntax for the "space around zones" feature?
i.e. I want to be able to enter 10 5 15 5 in the space textbox and the system should do:
top margin is 10px
right margin is 5px
bottom margin is 15px
left margin is 5px | Idea-Enhancement,FancyZones-Editor,FancyZones-Layouts,Product-FancyZones | low | Major |
572,819,381 | flutter | pushNamedAndRemoveUntil doesn't reach route under drawer | <!-- Thank you for using Flutter!
If you are looking for support, please check out our documentation
or consider asking a question on Stack Overflow:
* https://flutter.dev/
* https://api.flutter.dev/
* https://stackoverflow.com/questions/tagged/flutter?sort=frequent
If you have found a bug or if our documentation doesn't have an answer
to what you're looking for, then fill our the template below. Please read
our guide to filing a bug first: https://flutter.dev/docs/resources/bug-reports
-->
## Steps to Reproduce
<!-- You must include full steps to reproduce so that we can reproduce the problem. -->
lib/main.dart
```dart
import 'package:flutter/material.dart';
void main() => runApp(MyApp());
class MyApp extends StatelessWidget {
// This widget is the root of your application.
@override
Widget build(BuildContext context) {
return MaterialApp(
title: 'Flutter Demo',
home: MyHomePage(title: 'Flutter Demo Home Page'),
routes: {
'front': (_) => MyHomePage(),
'apage': (_) => APage(),
'bpage': (_) => BPage(),
},
);
}
}
class MyHomePage extends StatefulWidget {
MyHomePage({Key key, this.title}) : super(key: key);
final String title;
@override
_MyHomePageState createState() => _MyHomePageState();
}
class _MyHomePageState extends State<MyHomePage> {
@override
Widget build(BuildContext context) {
return Scaffold(
drawer: Drawer(
child: ListView(
children: <Widget>[
DrawerHeader(
child: Text('Drawer Header'),
),
ListTile(
title: Text('go to apage'),
onTap: () {
Navigator.of(context).pushNamed('apage');
},
),
],
),
),
appBar: AppBar(
title: Text(widget.title),
),
body: Center(
child:
Text(
'home',
),
),
);
}
}
class APage extends StatefulWidget {
APage();
@override
_APageState createState() => _APageState();
}
class _APageState extends State<APage> {
@override
Widget build(BuildContext context) {
return Scaffold(
appBar: AppBar(title: Text('APage')),
body: Center(
child: FlatButton(
onPressed: () {
Navigator.of(context).pushNamedAndRemoveUntil(
'bpage', ModalRoute.withName('front'));
},
child: Text('Press to go bpage and remove apage.'))));
}
}
class BPage extends StatefulWidget {
BPage();
@override
_BPageState createState() => _BPageState();
}
class _BPageState extends State<BPage> {
@override
Widget build(BuildContext context) {
return Scaffold(
appBar: AppBar(title: Text('BPage')), body: Center(child: Text('abc')));
}
}
```
**reproduce step
1. click to open the drawer.
2. click the item to go to apage.
3. click the flatbutton to `pushNamedAndRemoveUntil('bpage', ModalRoute.withName('front'));`
**Expected results:** <!-- what did you want to see? -->
There should be a back button at top left in b page.
**Actual results:** <!-- what did you see? -->
The front page was removed, so there is no back button.
I find that when the drawer is open, the front route's `willHandlePopInternally` is true, so the code below
[code](https://github.com/flutter/flutter/blob/master/packages/flutter/lib/src/widgets/routes.dart#L883~L885) will return false, so the front route will be pop.
```dart
/// Returns a predicate that's true if the route has the specified name and if
/// popping the route will not yield the same route, i.e. if the route's
/// [willHandlePopInternally] property is false.
///
/// This function is typically used with [Navigator.popUntil()].
static RoutePredicate withName(String name) {
return (Route<dynamic> route) {
return !route.willHandlePopInternally
&& route is ModalRoute
&& route.settings.name == name;
};
}
```
I know that i can use change the drawer button action like this to avoid this, but i think it's wried...
```dart
ListTile(
title: Text('go to apage'),
onTap: () {
Navigator.of(context).pop(); //add this to pop drawer first.
Navigator.of(context).pushNamed('apage');
},
```
so should we change the statement sequence ? judge the route name first ?
I'm not sure will it affect other features like some route has localhistory..
```
return route.settings.name == name
&& !route.willHandlePopInternally
&& route is ModalRoute;
```
<details>
<summary>Logs</summary>
```
flutter doctor -v
[✓] Flutter (Channel stable, v1.12.13+hotfix.8, on Mac OS X 10.15.3 19D76,
locale zh-Hans-CN)
• Flutter version 1.12.13+hotfix.8 at /Users/wdjwxh/code/flutter
• Framework revision 0b8abb4724 (2 weeks ago), 2020-02-11 11:44:36 -0800
• Engine revision e1e6ced81d
• Dart version 2.7.0
[✓] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
• Android SDK at /Users/wdjwxh/Library/Android/sdk
• Android NDK location not configured (optional; useful for native profiling
support)
• Platform android-28, build-tools 28.0.3
• Java binary at: /Applications/Android
Studio.app/Contents/jre/jdk/Contents/Home/bin/java
• Java version OpenJDK Runtime Environment (build
1.8.0_152-release-1136-b06)
• All Android licenses accepted.
[✓] Xcode - develop for iOS and macOS (Xcode 11.3.1)
• Xcode at /Applications/Xcode.app/Contents/Developer
• Xcode 11.3.1, Build version 11C504
• CocoaPods version 1.9.0
[!] Android Studio (version 3.2)
• Android Studio at /Applications/Android Studio.app/Contents
✗ Flutter plugin not installed; this adds Flutter specific functionality.
✗ Dart plugin not installed; this adds Dart specific functionality.
• Java version OpenJDK Runtime Environment (build
1.8.0_152-release-1136-b06)
[✓] VS Code (version 1.42.1)
• VS Code at /Applications/Visual Studio Code.app/Contents
• Flutter extension version 3.8.1
[✓] Connected device (1 available)
• iPhone 11 Pro • 12819EA7-67B2-4541-B697-7EF1A7640A04 • ios •
com.apple.CoreSimulator.SimRuntime.iOS-13-3 (simulator)
! Doctor found issues in 1 category.
```
</details>
| framework,f: material design,f: routes,has reproducible steps,P2,found in release: 3.0,found in release: 3.1,team-design,triaged-design | low | Critical |
572,830,322 | svelte | How to contribute to Svelte? | Hi,
I want to contribute to svelte. Can anyone help me to get started. Is there any starter guide?
I am a software engineer from India who works on React, Angular. | meta,temp-stale,documentation | low | Major |
572,849,911 | node | Strange resolving order using "node ." to start an app | <!--
Thank you for reporting an issue.
This issue tracker is for bugs and issues found within Node.js core.
If you require more general support please file an issue on our help
repo. https://github.com/nodejs/help
Please fill in as much of the template below as you're able.
Version: output of `node -v`
Platform: output of `uname -a` (UNIX), or version and 32 or 64-bit (Windows)
Subsystem: if known, please specify affected core module name
-->
* **Version**: v12.13.0
* **Platform**: Windows 10 64 bit
* **Subsystem**:
### What steps will reproduce the bug?
<!--
Enter details about your bug, preferably a simple code snippet that can be
run using `node` directly without installing third-party dependencies.
-->
There's a weird behaviour where you execute `node .` within a directory `<dir>`, and `../<dir>.js` will be required before any other file.
This behaviour doesn't happen for "require"
/app.js
```
console.log('app');
```
/app/index.js
```
console.log('index');
```
Make sure your CWD is `/app` and then run `node .`
You will see `app` printed out.
### How often does it reproduce? Is there a required condition?
Every time
### What is the expected behavior?
I'd expect `index` to be printed out. I'd never expect, in any case, for `app` to be printed.
The order i'd expect (if i have this correct) would be "main" from package.json if it exists, then index.js.
With the current file set-up, and a "main" in package.json pointing to a different file, this is still ignored.
<!--
If possible please provide textual output instead of screenshots.
-->
### What do you see instead?
<!--
If possible please provide textual output instead of screenshots.
-->
`app`
### Additional information
<!--
Tell us anything else you think we should know.
-->
| module | low | Critical |
572,852,825 | go | x/exp/cmd/gorelease: report when packages can't be loaded without replace, exclude | `replace` and `exclude` directives can be used in `go.mod` files to temporarily work around problems in dependencies while they are fixed upstream. They're also used in local development. `replace` and `exclude` only apply within the main module, so if a module can't be used by another without `replace` and `exclude` directives, it shouldn't be released.
`gorelease` currently loads type information for packages without `replace` and `exclude` directives and reports errors. If it sees errors, it should try loading *with* `replace` and `exclude` directives. If that succeeds, `gorelease` should note that as a possible cause for errors. | NeedsFix,FeatureRequest,modules,Tools | low | Critical |
572,854,114 | go | x/exp/cmd/gorelease: support -json and -f flags | `gorelease` prints its findings to stdout as plain text. The report format may change over time and can't be safely read by tools.
`gorelease` should accept `-json` and `-f` flags, which should produce either JSON or `text/template` output. | NeedsFix,FeatureRequest,modules,Tools | low | Major |
572,865,026 | go | x/exp/cmd/gorelease: positional arguments should specify packages to compare | Currently, `gorelease` compares APIs of all non-main, non-internal packages within a module. This is a sensible default.
In some cases, the API of a module's `internal` packages should be checked, since it's consumed by nested modules. For example, packages in `cloud.google.com/go/internal` are used in `cloud.google.com/go/storage`.
In other cases, non-internal packages should not be checked. For example, authors probably don't care about incompatible changes in packages in an `experimental` or `unstable` directory.
`gorelease` should accept a list of package paths or patterns as positional arguments. When specified, only these packages would be checked (`main` packages would still be excluded, since they can't be imported). | NeedsFix,FeatureRequest,modules,Tools | low | Minor |
572,900,872 | flutter | Elements in the AppBar should be easy customizable in fontSize and iconSize | What I want:
Change Size of appbar including size of the title and all icons and kepp them aligned vertically.
Workaround see:
https://stackoverflow.com/questions/60443198/how-can-i-change-the-size-of-the-standard-hamburger-menu-icon-of-a-drawer-in-flu/60443308?noredirect=1#comment106951922_60443308
Solution is complicated and usefull features like standard action icons (back, menu) won't work anymore in an easy way... changing the size in the theme would be much easier and could be used globally in the app.
| c: new feature,framework,f: material design,c: proposal,P3,workaround available,team-design,triaged-design | low | Minor |
572,901,951 | material-ui | [Select] NVDA does not announce helper text | This may be captured more broadly by issue #15597
When focus is brought to a (non native) select widget, NVDA announces the label and the value but not the helper text.
NVDA announces native select widgets as expected (value, label, and helper text).
- [x] The issue is present in the latest release.
- [x] I have searched the [issues](https://github.com/mui-org/material-ui/issues) of this repository and believe that this is not a duplicate.
## Steps to Reproduce 🕹
The code sandbox is taken from the Material-UI [docs](https://material-ui.com/components/text-fields/)
https://lu6rp.csb.app/
Steps:
1. Using NVDA, bring focus to the "Select". The label and value is announced but not the helper text.
2. Then bring focus to the "Native Select". The label, value, and helper text is announced - illustrating the expected behaviour
| accessibility,component: select | low | Minor |
572,937,217 | go | x/pkgsite: automate fetching of new versions of Go standard library | This issue is related to #37002, but limited in scope to just the Go standard library.
When a new version of Go is released, it takes a manual action to add it to pkg.go.dev. This can and should be automated, so that it happens as soon as a new Go version is released.
/cc @julieqiu @jba @cagedmantis @toothrot @FiloSottile | NeedsInvestigation,FeatureRequest,pkgsite | low | Minor |
572,948,917 | flutter | Update flutter docs for LiveTestWidgetsFlutterBinding | Right now `LiveTestWidgetsFlutterBinding` looks like it's a solution for app developers, but it's primarily for use in testing the Flutter framework itself. We should update the documentation to push Flutter app and plugin authors to use appropriate alternatives. | a: tests,framework,d: api docs,P2,team-framework,triaged-framework | low | Minor |
573,002,534 | godot | propagate_notification method is inconsistent: not calling _enter_tree, but calling _ready | **Godot version:**
3.2 stable
**OS/device including version:**
Win 10
**Issue description:**
The issue is that calling `propagate_notification` method does not call `_enter_tree`, but it does call `_ready`. However, the `_notification` virtual method does receive all these notifications, it's just that the `_enter_tree` method is not called. The issue seems to be the same on tool and game side.
Note that the `propagate_call` method works perfectly, but by design it doesn't alarm any notifications and only calls the last extended (overridden) methods - not those of the inherited classes. Similarly if you explicitly call `_enter_tree` on a Node, it will only call the last method - unlike the `_notification` call that does go through the whole chain of inheritance.
The net result of all this, is that there seems to be no general way of calling `_enter_tree` on a Node, so that it would also call it on the inherited classes. However the whole chain does get called "normally" when a node enters the tree and becomes ready, and you can do this for `_ready` (even using the convenient `propagate_notification`), so there really should be a way to do this - to avoid hacky scripting.
**Update**:
Sorry, the earlier confusion about switching scene tabs - a crucial typo while debugging.
**Steps to reproduce:**
- See the minimal reproduction project.
- See what happens when opening up the project (everything is correct).
- See what happens when clicking the different "Test" properties on the inspector on the root node: The `_enter_tree` method never gets called on the Kid.gd (only on the KidExtended.gd).
**Minimal reproduction project:**
[PropagationProblem.zip](https://github.com/godotengine/godot/files/4269248/PropagationProblem.zip)
| bug,topic:core | low | Critical |
573,038,427 | TypeScript | Object intellisense doesn't work properly when parameter is unioned with a non-object | <!-- 🚨 STOP 🚨 𝗦𝗧𝗢𝗣 🚨 𝑺𝑻𝑶𝑷 🚨
Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Even if you think you've found a *bug*, please read the FAQ first, especially the Common "Bugs" That Aren't Bugs section!
Please help us by doing the following steps before logging an issue:
* Search: https://github.com/Microsoft/TypeScript/search?type=Issues
* Read the FAQ: https://github.com/Microsoft/TypeScript/wiki/FAQ
Please fill in the *entire* template below.
-->
<!--
Please try to reproduce the issue with the latest published version. It may have already been fixed.
For npm: `typescript@next`
This is also the 'Nightly' version in the playground: http://www.typescriptlang.org/play/?ts=Nightly
-->
**TypeScript Version:** 3.8.2
<!-- Search terms you tried before logging this (so others can find this issue more easily) -->
**Search Terms:**
**Code**
```ts
declare function expectsConfig1(a: { x?: string }): void;
declare function expectsConfig2(a: { x?: string } | undefined): void;
expectsConfig1({});
expectsConfig2({});
```
**Expected behavior:** both should prompt you with `x` as a key
**Actual behavior:** only the first does
**Playground Link:** <!-- A link to a TypeScript Playground "Share" link which demonstrates this behavior --> n/a, playground doesn't support this intellisense at all. [Here it is anyway, though.](https://www.typescriptlang.org/play/?ts=3.9.0-dev.20200227#code/CYUwxgNghgTiAEAzArgOzAFwJYHtXxAA8AHcDAZwGE9EsBzARgAooAueAb3kIH53yMMLKjrwAvgEp2ANxxZgAbgBQoSLAQp02PARJkqNegCYW7Lr36DhosfAA+8NKFqoQwKfFnzlRUpgOotIxMHJI+ev7UgcYhYUA)
**Related Issues:** <!-- Did you find other bugs that looked similar? -->
| Bug,Domain: Completion Lists | low | Critical |
573,045,602 | storybook | Embed MDX Docs into Gatsby | **Is your feature request related to a problem? Please describe.**
So I noticed in this blog post [here](https://medium.com/storybookjs/rich-docs-with-storybook-mdx-61bc145ae7bc#78bb) that it mentions being able to embed the new mdx docs into gatsby at some point. But I went looking for some reference to that here in github that I could try to subscribe to and keep an eye on and didn't see anything. Is it still on the radar at all?
**Describe the solution you'd like**
Being able to embed the MDX docs into gatsby.
**Describe alternatives you've considered**
We've been playing with embedding the storybook iframe setup into gatsby already with some success, but if there's a built-in way to do something similar with the storybook MDX docs that would be really useful.
**Are you able to assist bring the feature to reality?**
Probably not. | feature request,addon: docs,mdx | low | Minor |
573,057,166 | pytorch | TensorPipes RPC Agent CUDA Support | ## 🚀 Feature
CUDA support would require the following items:
- Support memory allocation and communication for GPUs.
- Update RPC API to support args placement and result placement on CUDA devices.
- Update `RRef.to_here()` to accept device placement arguments
cc @ngimel @pietern @mrshenli @pritamdamania87 @zhaojuanmao @satgera @gqchen @aazzolini @rohan-varma @xush6528 @jjlilley @osalpekar | module: cuda,triaged,module: rpc | low | Minor |
573,058,742 | go | runtime: ensuring support of debug.asyncpreemptoff | This came up during a routinely scheduled meeting between the Delve team and folks from the Go team and it was suggested by @heschik to open an issue about this to ensure it stays on folks minds.
Delve leverages the `debug.asyncpreemptoff` in order to disable the functionality on Windows [[0]] (where it won't play well with debuggers) and may use it on other platforms as well to disable the functionality when run under Delve [[1]] [[2]].
This issue is mostly to get feedback and assurance that we can rely on this feature for the foreseeable future.
[0]: https://github.com/golang/go/issues/36494
[1]: https://github.com/golang/go/issues/37528
[2]: https://github.com/go-delve/delve/issues/1905 | NeedsInvestigation,compiler/runtime | low | Critical |
573,059,894 | pytorch | Initialize TensorPipe RPC Agent Transport | ## 🚀 Feature
Allow the Tensorpipes RPC Agent to be initialized with any underlying transport (shm, libuv, thrift, TLS, etc.) This may need to be added as an option to the RPC Backend Options to initialize from Python.
cc @pietern @mrshenli @pritamdamania87 @zhaojuanmao @satgera @gqchen @aazzolini @rohan-varma @xush6528 @jjlilley @osalpekar | triaged,module: rpc | low | Minor |
573,060,431 | pytorch | TensorPipes RPC Agent Listener shortcut | ## 🚀 Feature
Support an optimization in the TensorPipes RPC Agent listener when sending a message to yourself. This is similar to an optimization in the ProcessGroupAgent `listenLoopInternal`.
cc @pietern @mrshenli @pritamdamania87 @zhaojuanmao @satgera @gqchen @aazzolini @rohan-varma @xush6528 @jjlilley @osalpekar | triaged,module: rpc | low | Minor |
573,066,561 | node | ConsumeHTTP2Data Assertion error | v10.16.3
OS X Catalina 10.15.3 (Darwin imac2019.lan 19.3.0 Darwin Kernel Version 19.3.0: Thu Jan 9 20:58:23 PST 2020; root:xnu-6153.81.5~1/RELEASE_X86_64 x86_64)
My app will run for an hour before it dies with the error below. What does it mean please?
```
.nvm/versions/node/v10.16.3/bin/node[84392]: ../src/node_http2.cc:893:ssize_t node::http2::Http2Session::ConsumeHTTP2Data(): Assertion `(flags_ & SESSION_STATE_READING_STOPPED) != (0)' failed.
1: 0x10003d035 node::Abort() [/Users/user/.nvm/versions/node/v10.16.3/bin/node]
2: 0x10003c057 node::AddEnvironmentCleanupHook(v8::Isolate*, void (*)(void*), void*) [/Users/user/.nvm/versions/node/v10.16.3/bin/node]
3: 0x100081b34 node::http2::Http2Session::ConsumeHTTP2Data() [/Users/user/.nvm/versions/node/v10.16.3/bin/node]
4: 0x10008484e node::http2::Http2Session::OnStreamRead(long, uv_buf_t const&) [/Users/user/.nvm/versions/node/v10.16.3/bin/node]
5: 0x10013a258 node::TLSWrap::ClearOut() [/Users/user/.nvm/versions/node/v10.16.3/bin/node]
6: 0x10013b86e node::TLSWrap::OnStreamRead(long, uv_buf_t const&) [/Users/user/.nvm/versions/node/v10.16.3/bin/node]
7: 0x1000efaca node::LibuvStreamWrap::OnUvRead(long, uv_buf_t const*) [/Users/user/.nvm/versions/node/v10.16.3/bin/node]
8: 0x1009be83f uv__stream_io [/Users/user/.nvm/versions/node/v10.16.3/bin/node]
9: 0x1009c60fb uv__io_poll [/Users/user/.nvm/versions/node/v10.16.3/bin/node]
10: 0x1009b6139 uv_run [/Users/user/.nvm/versions/node/v10.16.3/bin/node]
11: 0x100044831 node::Start(v8::Isolate*, node::IsolateData*, std::__1::vector<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::allocator<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > > > const&, std::__1::vector<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::allocator<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > > > const&) [/Users/user/.nvm/versions/node/v10.16.3/bin/node]
12: 0x100043d3c node::Start(uv_loop_s*, std::__1::vector<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::allocator<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > > > const&, std::__1::vector<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::allocator<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > > > const&) [/Users/user/.nvm/versions/node/v10.16.3/bin/node]
13: 0x100043886 node::Start(int, char**) [/Users/user/.nvm/versions/node/v10.16.3/bin/node]
15: 0x2
```
| http2 | low | Critical |
573,073,937 | pytorch | TensorPipes RPC Agent Message Acknowledgements | ## 🚀 Feature
Since TensorPipes RPC Agent will support a `result_placement` argument, which allows the receiver to send the computed result to a worker that's not necessarily the sender, we must ensure that the sender receives confirmation of message success/failure.
For example, if CPU0 sends a message to CPU1, and indicates that the result should be sent to GPU0, then GPU0 must indicate to CPU0 that the message was received. This would likely require that we have longer timeouts for such messages.
Furthermore if the result must be placed on multiple devices, the original sender must ensure each of the machines receiving the result confirms successful message completion.
cc @pietern @mrshenli @pritamdamania87 @zhaojuanmao @satgera @gqchen @aazzolini @rohan-varma @xush6528 @jjlilley @osalpekar | triaged,module: rpc | low | Critical |
573,074,134 | flutter | CupertinoNavigationBar doesn't perform a hero transition if the first route is a "fullscreenDialog" route | <!-- Thank you for using Flutter!
If you are looking for support, please check out our documentation
or consider asking a question on Stack Overflow:
* https://flutter.dev/
* https://api.flutter.dev/
* https://stackoverflow.com/questions/tagged/flutter?sort=frequent
If you have found a bug or if our documentation doesn't have an answer
to what you're looking for, then fill our the template below. Please read
our guide to filing a bug first: https://flutter.dev/docs/resources/bug-reports
-->
## Steps to Reproduce
<!-- You must include full steps to reproduce so that we can reproduce the problem. -->
1. Create a `CupertinoApp`
2. Create a `CupertinoPageScaffold` as `home` for `CupertinoApp`
3. Present another `CupertinoPageScaffold` using `CupertinoPageRoute` with `fullscreenDialog` set to true
4. Present another `CupertinoPageScaffold` using `CupertinoPageRoute` with default settings. Hero animation is not performed
**Expected results:** <!-- what did you want to see? -->
The native app always performs the hero animation
**Actual results:** <!-- what did you see? -->
Hero animation is not performed the first time. The page just slides over from the right.
### Flutter project file
<details>
<summary>main.dart</summary>
```dart
import 'package:flutter/cupertino.dart';
import 'package:flutter/material.dart';
void main() => runApp(MyApp());
class MyApp extends StatelessWidget {
// This widget is the root of your application.
@override
Widget build(BuildContext context) {
return CupertinoApp(
home: CupertinoPage(),
);
}
}
class CupertinoPage extends StatelessWidget {
const CupertinoPage({
Key key,
}) : super(key: key);
@override
Widget build(BuildContext context) {
return CupertinoPageScaffold(
navigationBar: CupertinoNavigationBar(
middle: Text("Hero"),
),
child: Container(
child: Center(
child: Row(
mainAxisAlignment: MainAxisAlignment.center,
children: [
CupertinoButton(
child: Text("Push"),
onPressed: () {
Navigator.of(context)
.push(CupertinoPageRoute(builder: (context) {
return CupertinoPage();
}));
},
),
CupertinoButton(
child: Text("Present"),
onPressed: () {
Navigator.of(context).push(CupertinoPageRoute(
builder: (context) {
return CupertinoPage();
},
fullscreenDialog: true,
));
})
],
),
),
),
);
}
}
```
</details>
### iOS native project file
<details>
<summary>ViewController.swift</summary>
```
//
// ViewController.swift
// heropoc_native
//
// Created by Roman Tkachenko on 2/28/20.
// Copyright © 2020 Roman Tkachenko. All rights reserved.
//
import UIKit
class ViewController: UIViewController {
override func viewDidLoad() {
super.viewDidLoad()
self.view.backgroundColor = .white
self.title = "Native Hero"
let container = UIView()
container.translatesAutoresizingMaskIntoConstraints = false
self.view.addSubview(container)
container.centerYAnchor.constraint(equalTo: self.view.centerYAnchor).isActive = true
container.centerXAnchor.constraint(equalTo: self.view.centerXAnchor).isActive = true
let pushButton = UIButton.init(type: .system)
pushButton.translatesAutoresizingMaskIntoConstraints = false
pushButton.setTitle("Push", for: .normal)
pushButton.addTarget(self, action: #selector(self.push), for: .touchUpInside)
container.addSubview(pushButton)
pushButton.leadingAnchor.constraint(equalTo: container.leadingAnchor).isActive = true
pushButton.topAnchor.constraint(equalTo: container.topAnchor).isActive = true
pushButton.bottomAnchor.constraint(equalTo: container.bottomAnchor).isActive = true
let presentButton = UIButton.init(type: .system)
presentButton.translatesAutoresizingMaskIntoConstraints = false
presentButton.setTitle("Present", for: .normal)
presentButton.addTarget(self, action: #selector(self.presentScreen), for: .touchUpInside)
container.addSubview(presentButton)
presentButton.leadingAnchor.constraint(equalTo: pushButton.trailingAnchor, constant: 30).isActive = true
presentButton.centerYAnchor.constraint(equalTo: pushButton.centerYAnchor).isActive = true
presentButton.trailingAnchor.constraint(equalTo: container.trailingAnchor).isActive = true
}
@objc
private dynamic func push() {
self.navigationController?.pushViewController(ViewController(), animated: true)
}
@objc
private dynamic func presentScreen() {
let vc = ViewController()
vc.navigationItem.leftBarButtonItem = UIBarButtonItem.init(title: "close", style: .done, target: self, action: #selector(self.close))
let nav = UINavigationController(rootViewController: vc)
nav.modalPresentationStyle = .fullScreen
self.present(nav, animated: true, completion: nil)
}
@objc
private dynamic func close() {
self.dismiss(animated: true, completion: nil)
}
}
```
</details>
<details>
<summary>Logs</summary>
<!-- Finally, paste the output of running `flutter doctor -v` here. -->
```
/Users/rtkachenko/development/flutter/bin/flutter doctor --verbose
[✓] Flutter (Channel stable, v1.12.13+hotfix.8, on Mac OS X 10.15.1 19B88, locale en-US)
• Flutter version 1.12.13+hotfix.8 at /Users/rtkachenko/development/flutter
• Framework revision 0b8abb4724 (2 weeks ago), 2020-02-11 11:44:36 -0800
• Engine revision e1e6ced81d
• Dart version 2.7.0
[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
• Android SDK at /Users/rtkachenko/Library/Android/sdk
• Android NDK location not configured (optional; useful for native profiling support)
• Platform android-29, build-tools 29.0.2
• Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
• Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405)
• All Android licenses accepted.
[✓] Xcode - develop for iOS and macOS (Xcode 11.3.1)
• Xcode at /Applications/Xcode.app/Contents/Developer
• Xcode 11.3.1, Build version 11C504
• CocoaPods version 1.8.4
[✓] Android Studio (version 3.5)
• Android Studio at /Applications/Android Studio.app/Contents
• Flutter plugin version 43.0.1
• Dart plugin version 191.8593
• Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405)
[✓] Connected device (1 available)
• iPhone 8 • 6D169821-C1BC-4FDF-9EF4-39DD014AA182 • ios • com.apple.CoreSimulator.SimRuntime.iOS-13-3 (simulator)
```
• No issues found!
</details>
| framework,f: cupertino,f: routes,has reproducible steps,P2,found in release: 3.3,found in release: 3.7,team-design,triaged-design | low | Critical |
573,076,645 | TypeScript | Typecheck multiple module formats at once | (The other side of #15833)
## Search Terms
typecheck multiple module formats
## Suggestion
For projects that compile to multiple output formats - e.g. different `module` outputs - it would be useful to have typechecking able to emit errors for multiple formats at once.
The reason that duplicate typechecking is needed is that typechecking is slightly different based on the module - e.g. for commonjs / AMD, `export =` and `import foo = require(...)` are both legal, whereas in ESNext they are not; ESNext has `import.meta` and in some cases, top level `await`, that AMD/Commonjs don't support. So no single `module` target has the strictest typechecking.
The benefits are:
- save CPU time
- no need for running typecheck multiple times and get most errors duplicated between them
On it's own, I'm not sure it'll make a ton of sense - e.g. in `compilerOptions` the `module` field could take an array of modules, or we could use a new field for this; though together with emit for multiple module types (#15833) we could keep the invariant that tsc typechecks with the same module(s) that it emits.
## Use Cases
If I compile my code to both AMD and ESNext, typechecking only as AMD or only as ESNext, does not guarantee my code is valid for the other module format - an `export =` will fail ESNext typechecking, whereas an `import.meta` will fail AMD typechecking; so there's no single strictest typecheck mode; as is to guarantee correctness, I need to typecheck against all the module formats we emit, and then any type errors in e.g. function bodies would get repeated in both typechecks. Deduping these errors would be the main benefit.
| Suggestion,Awaiting More Feedback | low | Critical |
573,077,875 | flutter | Document how to run profile/release from Xcode | In order to get Xcode use the correct debug/profile/release mode, the Generated.xcconfig file should include `FLUTTER_BUILD_MODE=xxx`.
A correct one would like like:
```
// This is a generated file; do not edit or check into version control.
FLUTTER_ROOT=/Users/liyuqian/flutter/flutter
FLUTTER_APPLICATION_PATH=/Users/liyuqian/flutter/test/webp
FLUTTER_TARGET=/Users/liyuqian/flutter/test/webp/lib/main.dart
FLUTTER_BUILD_DIR=build
SYMROOT=${SOURCE_ROOT}/../build/ios
FLUTTER_FRAMEWORK_DIR=/Users/liyuqian/flutter/flutter/bin/cache/artifacts/engine/ios-profile
FLUTTER_BUILD_NAME=1.0.0
FLUTTER_BUILD_NUMBER=1
TRACK_WIDGET_CREATION=true
FLUTTER_BUILD_MODE=profile
```
However, currently the Flutter tools are generating
```
// This is a generated file; do not edit or check into version control.
FLUTTER_ROOT=/Users/liyuqian/flutter/flutter
FLUTTER_APPLICATION_PATH=/Users/liyuqian/flutter/test/webp
FLUTTER_TARGET=/Users/liyuqian/flutter/test/webp/lib/main.dart
FLUTTER_BUILD_DIR=build
SYMROOT=${SOURCE_ROOT}/../build/ios
FLUTTER_FRAMEWORK_DIR=/Users/liyuqian/flutter/flutter/bin/cache/artifacts/engine/ios-profile
FLUTTER_BUILD_NAME=1.0.0
FLUTTER_BUILD_NUMBER=1
TRACK_WIDGET_CREATION=true
``` | platform-ios,tool,d: api docs,a: build,P3,team-ios,triaged-ios | medium | Critical |
573,079,739 | pytorch | TensorPipes RPC Agent Multiple Placement Retries | ## 🚀 Feature
Since multiple machines can receive the result of a remote operation, it is possible that only some of these replies fail. We have 2 options for dealing with message failures:
- We mark the original future as complete only if all the recipients received the result. We can maintain a list on the sender of the recipients that received the result, and only retry those that failed.
- We have separate futures for each recipient, and each of these futures can be polled individually on whether that recipient successfully received the result.
cc @pietern @mrshenli @pritamdamania87 @zhaojuanmao @satgera @gqchen @aazzolini @rohan-varma @xush6528 @jjlilley @osalpekar | triaged,module: rpc | low | Critical |
573,080,364 | pytorch | TensorPipes RPC Agent Default Args/Result Device Mapping | ## 🚀 Feature
The planned RPC change to accommodate TensorPipes involves adding arguments to specify machines for results and arguments placement. We should give users the option to supply a default mapping which we can default to when an explicit mapping is not given, or if a partial mapping is given.
This mapping would include 2 items:
- a results placement dictionary to specify which machines each sub-field from the result should be placed on
- an args placement tuple of dictionaries, where each dictionary corresponds to the machine mapping for the sub-fields of one arg
cc @pietern @mrshenli @pritamdamania87 @zhaojuanmao @satgera @gqchen @aazzolini @rohan-varma @xush6528 @jjlilley @osalpekar | triaged,module: rpc | low | Minor |
573,094,640 | pytorch | ModuleList doesn't support slicing in TorchScript | ## 🐛 Bug
Slicing a ModuleList works in eager mode, but fails to script.
## To Reproduce
```
class MyModule(torch.nn.Module):
def __init__(self):
super().__init__()
self.mods = torch.nn.ModuleList([
torch.nn.Identity(),
torch.nn.Identity(),
])
def forward(self, arg):
for good_mod in self.mods[:-1]:
arg = good_mod(arg)
return arg
m = MyModule()
print(m(0))
torch.jit.script(m)
0
---------------------------------------------------------------------------
RuntimeError Traceback (most recent call last)
<ipython-input-94-45a56232649d> in <module>
14 m = MyModule()
15 print(m(0))
---> 16 torch.jit.script(m)
[...]
RuntimeError:
Arguments for call are not valid.
The following variants are available:
aten::slice.Tensor(Tensor(a) self, int dim=0, int start=0, int end=9223372036854775807, int step=1) -> (Tensor(a)):
Expected a value of type 'Tensor' for argument 'self' but instead found type '__torch__.torch.nn.modules.container.___torch_mangle_26.ModuleList'.
[...]
The original call is:
File "<ipython-input-94-45a56232649d>", line 10
def forward(self, arg):
for good_mod in self.mods[:-1]:
~~~~~~~~~~~~~ <--- HERE
arg = good_mod(arg)
return arg
```
## Environment
```
Collecting environment information...
PyTorch version: 1.5.0.dev20200226+cpu
Is debug build: No
CUDA used to build PyTorch: None
OS: Fedora release 30 (Thirty)
GCC version: (GCC) 9.1.1 20190503 (Red Hat 9.1.1-1)
CMake version: version 3.14.4
Python version: 3.7
Is CUDA available: No
CUDA runtime version: No CUDA
GPU models and configuration: No CUDA
Nvidia driver version: No CUDA
cuDNN version: No CUDA
Versions of relevant libraries:
[pip3] numpy==1.17.0
[pip3] pytorch-pretrained-bert==0.6.2
[pip3] torch==1.2.0
[pip3] torchtext==0.4.0
[conda] Could not collect
```
## Additional context
Look, folks. I don't write these models. I just need to get them running on mobile.
I'm currently working around this by tracing the model because it has no data-dependent control flow.
cc @suo | oncall: jit | low | Critical |
573,114,124 | godot | move_child() does not correctly refresh Texturebutton overlap priority when they are children of Node2Ds | **Godot version:** v3.2.stable.official
**OS/device including version:** PC, Microsoft Windows 10 Home 10.0.1.18362
**Issue description:** When using Nodes containing TextureButtons with overlapping areas, the first button to receive input should be determined by which is lowest in the tree. When reordering these nodes (for instance, to account for changed positions along the y axis), move_child is not sufficient to make Godot recalculate overlapping priority -- it will place the nodes into the correct hierarchy and draw them correctly, but overlapping buttons will behave inconsistently. If this sorting step is completed as part of the _ready() method it will correctly behave, but at any time following that it is necessary to remove and re-add the texturebutton with remove_child and add_child to make it function correctly. This makes me think it's something to do with an update function or tree entering signal that add_child has but move_child lacks. It just seems weird to me that re-adding a node is the way to fix this, there must be some other solution for updating the node hierarchy.
**Steps to reproduce:**
Create a scene with a main node and several child nodes that each contain a TextureButton that overlaps with at least one other Texturebutton.
Sort the nodes by y position and reorder them accordingly at any point **after** _ready() has been called.
Click on overlapped portions of buttons. Some buttons 'beneath' others (higher in the tree) will receive the signal instead of the visually intended button.
**Minimal reproduction project:**
[ProblemReproduction1.zip](https://github.com/godotengine/godot/files/4269744/ProblemReproduction1.zip)
Open and run the project. Press 'R' to shuffle and sort the nodes by height. Clicking on overlapped portions will behave contrary to the expected results provided by the tree output in the console, i.e the click priority will always be Blue , Green , Red.
Uncomment the refreshNode() call in sortNodes() in the SortingNode.
Repeat the process, noting how now the overlapping is correct and the physically lowest node is always the 'top' button and gets any clicks, even when overlapping. | bug,topic:gui | low | Minor |
573,121,335 | godot | Input.set_use_accumulated_input(false) broken? | **Godot version:**
v3.2.stable.official
**OS/device including version:**
Linux Mint Cinnamon 19.3
also tested on: Windows 10 some new build
**Issue description:**
Input is only sent once per frame by _input(event), but i want to use the input in the moment it is triggered, without having to wait to the next frame.
So I tried "Input.set_use_accumulated_input(false)", but _input(event) is still called once per frame.
Is this a bug or is set_use_accumulated_input supposed to do something else?
There is not much in the documentation about this method.
**Steps to reproduce:**
The minimal project is set to use vsync and count the time in micro-seconds from the start of the last frame to the delivery of the input event. The measurement is displayed at the top lefthand side of the window.
The event is set to InputEventMouseButton but can also be changed.
Input.set_use_accumulated_input() is set to false.
You can set vsync off, but with vsync on it's easier to see, that the time is roughly the same with every mouse-button pressed, instead of evenly distributed from 0 to the frametime in µseconds.
If it's the same all the time, that means _input(event) is only called once per frame.
On a 60Hz display, vsync enabled, the measured time is, but shouldn't be all the time, about 16667µs.
**Minimal reproduction project:**
[inputLatency.zip](https://github.com/godotengine/godot/files/4269822/inputLatency.zip)
| bug,platform:windows,topic:input | low | Critical |
573,135,309 | godot | Index inspector menu does not work for get_rotation(self) and get_translation(self) in Godot 3.2 | **Godot version:**
Godot 3.2
**OS/device including version:**
Windows 10
**Issue description:**
In Godot 3.1 when one made a get_rotation() or get_translation() node in visual script, and clicked the ' index ' in the inspector, one could change the output from the standard vector3 ( vc3 visual script node output ) to x, y, or z-index, see picture . . In Godot 3.2 when one tries that, the output doesn't becomes a float, for the given axis, but stays a vc3, so one has to make a deconstruct, to get the value one wants, it was much easier in Godot 3.1, for beginners . .
Here's a 1 minute video, that shows it . .
https://www.youtube.com/watch?v=LwRf3WVFX5U
So you can see what I mean, it's weird, 3.1 was better . .
**Steps to reproduce:**
See the video . . .
**Minimal reproduction project:**
I don't know what that is . .
Thanks, J. Brooks . . | topic:visualscript | low | Minor |
573,157,712 | opencv | [Feature Reuqest] draw dash rectangle support | Add a line type of dashed in rectangle drawing fuction. | feature,category: imgproc,priority: low | low | Minor |
573,170,996 | go | x/build/maintner: make it easy for interested clients to subscribe/watch for new Go releases | There are many clients that might be interested in knowing when a new Go release is tagged, in order to take some automated action. One recent example is pkg.go.dev (see issue #37568), but there are plenty of others.
Maintner already tracks the Go repository and knows when any tags are made. Interested clients can use a maintner client (either a normal one, or a tail-only client) to easily get notified and take appropriate action.
It should be helpful to make this easier to discover and use. /cc @julieqiu @toothrot @cagedmantis
Perhaps it can be done by adding an example to [maintner](https://pkg.go.dev/golang.org/x/build/maintner) package documentation. Here's a starting point for an example that uses [`maintner.TailNetworkMutationSource`](https://pkg.go.dev/golang.org/x/build/maintner#TailNetworkMutationSource) to watch for all new tags created in the main Go repository and printing them to stdout:
```Go
// Tail events from the maintner server in a loop.
for {
err := maintner.TailNetworkMutationSource(context.Background(), godata.Server, func(e maintner.MutationStreamEvent) error {
if e.Err != nil {
log.Printf("# ignoring err: %v\n", e.Err)
time.Sleep(5 * time.Second)
return nil
}
m := e.Mutation
if m.Gerrit == nil || m.Gerrit.Project != "go.googlesource.com/go" {
// Not a Gerrit event, or not the main Go repo. Skip.
return nil
}
for _, r := range m.Gerrit.Refs {
if !strings.HasPrefix(r.Ref, "refs/tags/") {
// Not a tag. Skip.
continue
}
fmt.Printf("new tag in go repo: name=%q sha1=%q\n", r.Ref[len("refs/tags/"):], r.Sha1)
}
return nil
})
log.Printf("tail error: %v; restarting\n", err)
time.Sleep(time.Second)
}
```
Using a full maintner client or [`maintner.NewNetworkMutationSource`](https://pkg.go.dev/golang.org/x/build/maintner#NewNetworkMutationSource) is a little more involved because it requires preserving state, which means writing to disk or another place. But this option can be investigated too.
Finally, we can consider exposing this functionality via a higher level API, but I think it should be easier to prototype this before committing to a public API that's hard to change. | Documentation,Builders,NeedsInvestigation,FeatureRequest | low | Critical |
573,171,280 | pytorch | _broadcast_coalesced_reshape doesn't respect zero-size tensor | ## 🐛 Bug
_broadcast_coalesced_reshape doesn't respect zero-size tensor
## To Reproduce
```
import torch
from torch.nn.parallel.replicate import _broadcast_coalesced_reshape
_broadcast_coalesced_reshape([torch.zeros(1,1).cuda(0)], [0,1], True)
# [[tensor([[0.]], device='cuda:0')], [tensor([[0.]], device='cuda:1')]]
_broadcast_coalesced_reshape([torch.zeros(0,1).cuda(0)], [0,1], True)
# [[tensor([], device='cuda:0', size=(0, 1))], []]
```
## Expected behavior
[[tensor([], device='cuda:0', size=(0, 1))], [tensor([], device='cuda:1', size=(0, 1))]]
## Environment
PyTorch version: 1.4.0
Is debug build: No
CUDA used to build PyTorch: 10.1
OS: CentOS Linux 7 (Core)
GCC version: (GCC) 4.9.4
CMake version: version 2.8.12.2
Python version: 3.7
Is CUDA available: No
CUDA runtime version: 10.1.243
GPU models and configuration:
GPU 0: GeForce GTX 1080 Ti
GPU 1: GeForce GTX 1080 Ti
Nvidia driver version: 418.43
cuDNN version: Could not collect
Versions of relevant libraries:
[pip] detectron-pytorch==0.1
[pip] numpy==1.17.2
[pip] numpydoc==0.9.1
[pip] torch==1.4.0
[pip] torchvision==0.5.0
[conda] blas 1.0 mkl
[conda] detectron-pytorch 0.1 dev_0 <develop>
[conda] mkl 2019.4 243
[conda] mkl-service 2.3.0 py37he904b0f_0
[conda] mkl_fft 1.0.14 py37ha843d7b_0
[conda] mkl_random 1.1.0 py37hd6b4f25_0
[conda] pytorch 1.4.0 py3.7_cuda10.1.243_cudnn7.6.3_0 pytorch
[conda] torchvision 0.5.0 py37_cu101 pytorch
| triaged,small,module: data parallel | low | Critical |
573,177,286 | rust | Return value from const_trait_impl did not promote to constant? | I tried this code:
```rust
#![feature(const_trait_impl)]
#![feature(const_fn)]
use std::marker::PhantomData;
trait ConstDefault {
fn const_default() -> Self;
}
impl const ConstDefault for u8 {
fn const_default() -> Self { 0 }
}
const fn foo() -> &'static u8 {
&u8::const_default()
}
```
I expected to see this happen: This should pass compile if i'm not mistaken.
Instead, this happened: The const value promotion did not happen.
cc @ecstatic-morse @oli-obk
| A-diagnostics,T-compiler,A-const-eval,A-suggestion-diagnostics,D-newcomer-roadblock,A-const-prop | low | Major |
573,185,109 | terminal | Terminal can't create pseudoconsoles when condrv isn't loaded [Error 0xd000003a] | <!--
🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨
I ACKNOWLEDGE THE FOLLOWING BEFORE PROCEEDING:
1. If I delete this entire template and go my own path, the core team may close my issue without further explanation or engagement.
2. If I list multiple bugs/concerns in this one issue, the core team may close my issue without further explanation or engagement.
3. If I write an issue that has many duplicates, the core team may close my issue without further explanation or engagement (and without necessarily spending time to find the exact duplicate ID number).
4. If I leave the title incomplete when filing the issue, the core team may close my issue without further explanation or engagement.
5. If I file something completely blank in the body, the core team may close my issue without further explanation or engagement.
All good? Then proceed!
-->
<!--
This bug tracker is monitored by Windows Terminal development team and other technical folks.
**Important: When reporting BSODs or security issues, DO NOT attach memory dumps, logs, or traces to Github issues**.
Instead, send dumps/traces to [email protected], referencing this GitHub issue.
If this is an application crash, please also provide a Feedback Hub submission link so we can find your diagnostic data on the backend. Use the category "Apps > Windows Terminal (Preview)" and choose "Share My Feedback" after submission to get the link.
Please use this form and describe your issue, concisely but precisely, with as much detail as possible.
-->
# Environment
```none
Windows build number: 0.9.433.0
Windows Terminal version (if applicable): 0.9.433.0
Running within VirtualBox VM.
```
# Steps to reproduce
Start Windows Terminal after reboot.
# Expected behavior
Powershell starts.
# Actual behavior
Powershell does not start. Following messaged displayed - _Error 0xd000003a when launching 'powershell.exe'_. Starting Powershell directly, which opens without a problem, and then opening Powershell in Windows Terminal fixes the problem.
The following is my PATH:
```
C:\Windows\system32
C:\Windows
C:\Windows\System32\Wbem
C:\Windows\System32\WindowsPowerShell\v1.0\
C:\Windows\System32\OpenSSH\
C:\Users\Darren\AppData\Local\Microsoft\WindowsApps
C:\Python27\ArcGIS10.8
C:\Program Files\ArcGIS\Pro\bin\Python\Scripts
```
Similar issue with Command and similar resolution. | Help Wanted,Product-Conpty,Area-Server,Issue-Bug,Priority-2,good first issue | medium | Critical |
573,217,137 | youtube-dl | Add paramountnetwork.es and .it | - [x] I'm reporting a new site support request
- [x] I've verified that I'm running youtube-dl version **2020.02.16**
- [x] I've checked that all provided URLs are alive and playable in a browser
- [x] I've checked that none of provided URLs violate any copyrights
- [x] I've searched the bugtracker for similar site support requests including closed ones
## Example URLs
For paramountnetwork.es spain
# movies
https://www.paramountnetwork.es/peliculas
#series
https://www.paramountnetwork.es/episodios/2ykj1q/los-misterios-de-murdoch-el-ladron-de-besos-temporada-4-ep-12
For the italian version there is a request already, I think both use same tech.
https://github.com/ytdl-org/youtube-dl/issues/23295
## Description
European network different domains probably same tech .es .it
| site-support-request | low | Critical |
573,259,988 | youtube-dl | Add site https://www.ixigua.com/ | <!--
######################################################################
WARNING!
IGNORING THE FOLLOWING TEMPLATE WILL RESULT IN ISSUE CLOSED AS INCOMPLETE
######################################################################
-->
## Checklist
<!--
Carefully read and work through this check list in order to prevent the most common mistakes and misuse of youtube-dl:
- First of, make sure you are using the latest version of youtube-dl. Run `youtube-dl --version` and ensure your version is 2020.02.16. If it's not, see https://yt-dl.org/update on how to update. Issues with outdated version will be REJECTED.
- Make sure that all provided video/audio/playlist URLs (if any) are alive and playable in a browser.
- Make sure that site you are requesting is not dedicated to copyright infringement, see https://yt-dl.org/copyright-infringement. youtube-dl does not support such sites. In order for site support request to be accepted all provided example URLs should not violate any copyrights.
- Search the bugtracker for similar site support requests: http://yt-dl.org/search-issues. DO NOT post duplicates.
- Finally, put x into all relevant boxes (like this [x])
-->
- [x] I'm reporting a new site support request
- [x] I've verified that I'm running youtube-dl version **2020.02.16**
- [x] I've checked that all provided URLs are alive and playable in a browser
- [x] I've checked that none of provided URLs violate any copyrights
- [x] I've searched the bugtracker for similar site support requests including closed ones
## Example URLs
<!--
Provide all kinds of example URLs support for which should be included. Replace following example URLs by yours.
-->
- Private video: https://www.ixigua.com/i6798508841601335820/
- Single video: https://www.ixigua.com/i6699344434779128328/
- User playlist: https://www.ixigua.com/home/83570835528/
## Description
<!--
Provide any additional information.
If work on your issue requires account credentials please provide them or explain how one can obtain them.
-->
Api to get video like this
https://vas.snssdk.com/video/openapi/v1/...
Video in ['dynamic_video_list'] => b64decode(main_url) => real url
This is the video I have how to decode private video https://drive.google.com/file/d/1OysTwJHkas9R5gQlWXuHHj5PEc27WpQ9/view
And i used https://www.bento4.com/ to decode video
But i don't know how to do it in python3.x
| site-support-request,yt-dlp | low | Critical |
573,260,938 | TypeScript | Reference to the function expression identifier in it's body has different symbol | **TypeScript Version:** 3.8.2, 3.9.0-dev.20200229
<!-- Search terms you tried before logging this (so others can find this issue more easily) -->
**Search Terms:**
**Code**
```ts
const ts = require('typescript');
const content = 'const x = function y() { y }';
const host = ts.createCompilerHost({});
const originalReadFile = host.readFile;
host.readFile = fileName => (fileName === 'main.ts' ? content : originalReadFile(fileName));
const program = ts.createProgram({ host, rootNames: ['main.ts'], options: { types: [] } });
program.getSemanticDiagnostics();
const typeChecker = program.getDiagnosticsProducingTypeChecker();
const sourceFile = program.getSourceFile('main.ts');
const fn = sourceFile.statements[0].declarationList.declarations[0].initializer;
const y = fn.name;
const yInBody = fn.body.statements[0].expression.expression;
const ySymbol = typeChecker.getSymbolAtLocation(y);
const yInBodySymbol = typeChecker.getSymbolAtLocation(yInBody);
console.log(ySymbol === yInBodySymbol);
```
**Expected behavior:**
`y` identifier in function name and `y` reference in it's body to have the same symbol
**Actual behavior:**
They have different symbols.
Few notes:
- It wasn't the case in 3.7.5
- It's not the case when `program.getSemanticDiagnostics()` is not called or a non-diagnostics-producing type checker is used (ref #28584)
- It happens only with function expression, i.e. `const content = 'function y() { y }'` works as expected
**Playground Link:** <!-- A link to a TypeScript Playground "Share" link which demonstrates this behavior -->
**Related Issues:** <!-- Did you find other bugs that looked similar? -->
| Bug,API | low | Critical |
573,317,313 | opencv | ORB computes features much slower on 4.2.0, compared to 4.0.1 | Using default ORB constructor and computing only descriptors
```
cv::Ptr<cv::Feature2D> dsc = cv::ORB::create();
dsc->compute(image, keypoints, descriptors)
```
yields different timings in version 4.0.1 and 4.2.0
It will take time to generate full test results, because I noticed issue in my work project, so I firstly will describe it in words.
On version 4.2.0 descriptors are computed with mean of `25 ms` for function `compute()`
I've used opencv 4.2.0 with defaults suggested by cmake:
```
CPU_BASELINE: SSE3
CPU_DISPATCH:STRING=SSE4_1;SSE4_2;AVX;FP16;AVX2;AVX512_SKX
```
Then I tried this configuration:
```
CPU_BASELINE: SSE4.2
CPU_DISPATCH:STRING=AVX2
```
and this:
```
CPU_BASELINE: SSE3
CPU_DISPATCH:STRING=
```
All of them yielded same mean around `25 ms`.
I then builded opencv 4.0.1 with
```
CPU_BASELINE: SSE3
CPU_DISPATCH:STRING=
```
and this configuration gives me mean of `10 ms` The same as on PC of my colleague who uses opencv 4.0.1 with SSE3
Build I used is `Release x64, CMake 3.15.3, generator Visual Studio 14 2015. Windows 10, Intel CPU i7 6700k`.
Also as shows Visual Studio profiler, main time is spend in Gaussian Blur function(around 80% of time execution of `compute()`)
So I wonder what could be the reason? I did not noticed ORB algorithm changes in opencv changes log, and do not have ideas how to find difference at this point. | incomplete,needs investigation | low | Major |
573,398,375 | rust | Moving a method from struct impl to trait causes performance degradation | Hi all, thanks for all the work on the rust project!
I tried this code:
```rust
use std::time::Instant;
fn main() {
let finder = OddFinderOne;
let start_time = Instant::now();
let result = find_nth_odd(finder, 1_000_000_000);
let elapsed_time = start_time.elapsed().as_millis();
println!("{} in {} ms", result, elapsed_time);
}
fn find_nth_odd(odd_finder: OddFinderOne, n: u64) -> u64 {
let mut i = 0;
let mut odd_count = 0;
while odd_count != n {
i += 1;
if odd_finder.is_odd(i) {
odd_count += 1;
}
}
i
}
trait OddFinder {
fn is_odd(&self, n: u64) -> bool;
}
struct OddFinderOne;
impl OddFinder for OddFinderOne {
fn is_odd(&self, n: u64) -> bool {
n % 2 == 1
}
}
```
I expected it to perform similarly to this code:
```rust
use std::time::Instant;
fn main() {
let finder = OddFinder;
let start_time = Instant::now();
let result = find_nth_odd(finder, 1_000_000_000);
let elapsed_time = start_time.elapsed().as_millis();
println!("{} in {} ms", result, elapsed_time);
}
fn find_nth_odd(odd_finder: OddFinder, n: u64) -> u64 {
let mut i = 0;
let mut odd_count = 0;
while odd_count != n {
i += 1;
if odd_finder.is_odd(i) {
odd_count += 1;
}
}
i
}
struct OddFinder;
impl OddFinder {
fn is_odd(&self, n: u64) -> bool {
n % 2 == 1
}
}
```
Instead, this happened:
The version with the `is_odd` method defined directly on the struct completes in 1032 ms, while the version where `is_odd` is defined as part of the trait completes in 1340 ms. I would expect this abstraction to be zero cost, since the `find_nth_odd` method in both cases is defined as taking the concrete struct as an argument (as opposed to a trait object).
### Meta
`rustc --version --verbose`:
```
rustc 1.41.0 (5e1a79984 2020-01-27)
binary: rustc
commit-hash: 5e1a799842ba6ed4a57e91f7ab9435947482f7d8
commit-date: 2020-01-27
host: x86_64-unknown-linux-gnu
release: 1.41.0
LLVM version: 9.0
```
`rustc +nightly --version --verbose`
```
rustc 1.43.0-nightly (0eb878d2a 2020-02-28)
binary: rustc
commit-hash: 0eb878d2aa6e3a1cb315f3f328681b26bb4bffdb
commit-date: 2020-02-28
host: x86_64-unknown-linux-gnu
release: 1.43.0-nightly
LLVM version: 9.0
```
I see the same behavior with both the latest stable and nightly compilers. I run both version of the program in release mode. The reported performance numbers have proven to be very repeatable.
Let me know if I can provide any additional useful information. You can find my repo containing this benchmark code at the link below.
https://github.com/JoshMcguigan/cost-of-indirection | I-slow,A-codegen,T-compiler,C-bug | medium | Major |
573,403,152 | rust | Docs suggest implemting try_fold on std::iter::iterator, which is not possible due to Try being unstable | `std::iter::Iterator` docs has this "Note to implementors" on [`try_fold`](https://doc.rust-lang.org/std/iter/trait.Iterator.html#method.try_fold):
> Most of the other (forward) methods have default implementations in terms of this one, so try to implement this explicitly if it can do something better than the default for loop implementation.
But this isn't actually possible to do in stable due to the `Try` trait being unsable. The type bounds cannot be specified correctly to match the iterator definition. | C-enhancement,T-libs-api,A-docs,A-iterators | low | Minor |
573,429,913 | flutter | `Slider` has a slight a lag when drag | 1. It looks like the default slider widget in Flutter has a slight lag when being moved. It's definitely nothing terrible BUT slow enough to notice it doesn't feel native on iOS. Just check how iOS slider should behave by going e.g. to iPhone Settings->Screen and Brightness -> Change Brightness by sliding.
Sliding a native iOS slider is instant whereas sliding a Flutter slider is with a (slight) lag.
<details>
<summary>2. Code Sample </summary>
```
import 'package:flutter/material.dart';
void main() => runApp(MyApp());
class MyApp extends StatelessWidget {
// This widget is the root of your application.
@override
Widget build(BuildContext context) {
return MaterialApp(
title: 'Flutter Demo',
theme: ThemeData(
primarySwatch: Colors.blue,
),
home: MyHomePage(title: 'Flutter Demo Home Page'),
);
}
}
class MyHomePage extends StatefulWidget {
MyHomePage({Key key, this.title}) : super(key: key);
final String title;
@override
_MyHomePageState createState() => _MyHomePageState();
}
class _MyHomePageState extends State<MyHomePage> {
int height = 170;
Widget build(BuildContext context) {
return Scaffold(
appBar: AppBar(
title: Text(widget.title),
),
body: Center(
child: Slider(
min: 150.0,
max: 180.0,
value: height.toDouble(),
divisions: 30,
onChanged: (double newValue) {
setState(() {
height = newValue.toInt();
});
},
),
), // This trailing comma makes auto-formatting nicer for build methods.
);
}
}
```
</details>
3. https://photos.app.goo.gl/mcSbDNyoPJYwYrns8
## Details
<!--
1. Please tell us exactly how to reproduce the problem you are running into.
2. Please attach a small application (ideally just one main.dart file) that
reproduces the problem. You could use https://gist.github.com/ for this.
3. Switch flutter to master channel and run this app on a physical device
using profile mode with Skia tracing enabled, as follows:
flutter channel master
flutter run --profile --trace-skia
Then press ‘P’ to enable the performance overlay.
The bleeding edge master channel is encouraged here because Flutter is
constantly fixing bugs and improving its performance. Your problem in an
older Flutter version may have already been solved in the master channel.
4. Record a video of the performance issue using another phone so we
can have an intuitive understanding of what happened. Don’t use
"adb screenrecord", as that affects the performance of the profile run.
5. Open Observatory and save a timeline trace of the performance issue
so we know which functions might be causing it. See "How to Collect
and Read Timeline Traces" on this blog post:
https://medium.com/flutter-io/profiling-flutter-applications-using-the-timeline-a1a434964af03#a499
-->
<!--
Please tell us which target platform(s) the problem occurs (Android / iOS / Web / macOS / Linux / Windows)
Which target OS version, for Web, browser, is the test system running?
Does the problem occur on emulator/simulator as well as on physical devices?
-->
**Target Platform:**
iOS
**Target OS version/browser:**
13.3.1
**Devices:**
iPhone XR
## Logs
<!--
Run `flutter analyze` and attach any output of that command below.
If there are any analysis errors, try resolving them before filing this issue.
-->
Analyzing flutter_app_slider_experiment...
No issues found! (ran in 2.2s)
<!-- Finally, paste the output of running `flutter doctor -v` here, with your device plugged in. -->
[✓] Flutter (Channel master, v1.15.4-pre.241, on Mac OS X 10.15.3 19D76, locale es-ES)
• Flutter version 1.15.4-pre.241 at /Users/tomas/Developer/flutter
• Framework revision 1d3fcfd6ca (5 hours ago), 2020-02-29 10:01:18 -0800
• Engine revision 755e2b559d
• Dart version 2.8.0 (build 2.8.0-dev.10.0 09bbd3cca5)
[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.3)
• Android SDK at /Users/tomas/Library/Android/sdk
• Android NDK location not configured (optional; useful for native profiling support)
• Platform android-29, build-tools 29.0.3
• Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
• Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405)
• All Android licenses accepted.
[✓] Xcode - develop for iOS and macOS (Xcode 11.3.1)
• Xcode at /Applications/Xcode.app/Contents/Developer
• Xcode 11.3.1, Build version 11C504
• CocoaPods version 1.8.4
[✓] Android Studio (version 3.5)
• Android Studio at /Applications/Android Studio.app/Contents
• Flutter plugin version 43.0.1
• Dart plugin version 191.8593
• Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405)
[✓] Connected device (1 available)
• iPhone • 00008020-000415840E50003A • ios • iOS 13.3.1
• No issues found!
| framework,f: material design,a: fidelity,has reproducible steps,P2,found in release: 3.3,found in release: 3.7,team-design,triaged-design | low | Critical |
573,432,277 | electron | Support all actions that can be triggered via menu roles to be triggered programmatically too | I think pretty much all actions that can be triggered via a menu item that has a special `role` property should be able to be triggered programmatically too, the reason is that for apps like VSCode that implement a custom menubar and/or a command palette you want to be able to show there all actions that you can show in the native menus by using the special `role` property.
So here's a list of all current roles, with an emoji indicating if they can be triggered programmatically or not, with a possible way to trigger them programmatically, to the best of my knowledge:
---
- ~~**appMenu**~~: this role doesn't actually trigger an action.
- ~~**fileMenu**~~: this role doesn't actually trigger an action.
- ~~**editMenu**~~: this role doesn't actually trigger an action.
- ~~**viewMenu**~~: this role doesn't actually trigger an action.
- ~~**windowMenu**~~: this role doesn't actually trigger an action.
- ~~**help**~~: this role doesn't actually trigger an action.
- ~~**services**~~: No need for APIs for this.
- ~~**window**~~: this role doesn't actually trigger an action.
---
- ✅ **undo**: `document.execCommand ( 'undo' )`.
- ✅ **redo**: `document.execCommand ( 'redo' )`.
- ✅ **cut**: `document.execCommand ( 'cut' )`.
- ✅ **copy**: `document.execCommand ( 'copy' )`.
- ✅ **paste**: `document.execCommand ( 'paste' )`.
- ❌ **pasteAndMatchStyle**
- ✅ **delete**: `document.execCommand ( 'delete' )`.
- ✅ **selectAll**: `document.execCommand ( 'selectAll' )`.
---
- ✅ **reload**: `BrowserWindow#webContents#reload`.
- ✅ **forceReload**: `BrowserWindow#webContents#reloadIgnoringCache`.
- ✅ **minimize**: `BrowserWindow#minimize`.
- ✅ **close**: `window.close ()`.
- ✅ **togglefullscreen**: `BrowserWindow#setFullScreen` + `BrowserWindow#isFullScreen`.
- A `BrowserWindow#toggleFullscreen` method would be nice to have.
- ✅ **toggleDevTools**: `BrowserWindow#webContents#toggleDevTools`.
- ✅ **resetZoom**: `document.documentElement.style.zoom = 1`.
- ✅ **zoomIn**: `document.documentElement.style.zoom = Number ( document.documentElement.style.zoom || 1 ) + .1`.
- ✅ **zoomOut**: `document.documentElement.style.zoom = Number ( document.documentElement.style.zoom || 1 ) - .1`.
---
- ✅ **about**: `app.showAboutPanel`
- ✅ **quit**: `app.quit`
- ❌ **startSpeaking**: Maybe an applescript could be used for this, but this feature probably be provided by Electron itself.
- ❌ **stopSpeaking**: Maybe an applescript could be used for this, but this feature probably be provided by Electron itself.
- ❌ **zoom**: Maybe an applescript could be used for this, but this feature probably be provided by Electron itself.
- ❌ **recentDocuments**
- ✅ **clearRecentDocuments** `app.clearRecentDocuments`
---
- ❌ **hide**
- `BrowserWindow#getAllWindows` doesn't return the devtools window.
- Once I call `BrowserWindow#hide` I can't show up the window anymore for some reason, Dock -> Show All Windows doesn't show it.
- A `BrowserWindow.hideAll` could be nice to have.
- ❌ **hideOthers**: Maybe an applescript could be used for this, but this feature probably be provided by Electron itself.
- ❌ **unhide**: Maybe an applescript could be used for this, but this feature probably be provided by Electron itself.
- This role doesn't seem to have a great name, it seems the inverse of the `hide` role, but `hide` hides only our Electron app, while `unhide` unhides everything.
- ❌ **front**: Maybe `BrowserWindow#focus` could be called on all windows retrieved via `BrowserWindow#getAllWindows` for this, but `BrowserWindow#getAllWindows` doesn't actually return all windows (no devtools, and there's no method for changing the visibility of the devtools window).
- ✅ **mergeAllWindows**: `BrowserWindow#mergeAllWindows`.
---
- ✅ **selectNextTab**: `BrowserWindow#selectNextTab`.
- ✅ **selectPreviousTab**: `BrowserWindow#selectPreviousTab`.
- ✅ **toggleTabBar**: `BrowserWindow#toggleTabbar`.
- ✅ **moveTabToNewWindow**: `BrowserWindow#moveTabToNewWindow`.
---
It'd be nice if the actions that can currently only be triggered via a menu item with the appropriate role could be triggered programmatically too. | enhancement :sparkles: | low | Minor |
573,445,741 | flutter | [maps] showMarkerInfoWindow doesn't update fast enough | A stated. Add a marker to your markers list for your GoogleMap, then try to show that InfoWindow, it will give you a null ref as the marker is not actually in the controllers list yet, for whatever reason. It eventually does show up in there but I'm not sure what the delay is. | c: performance,p: maps,package,perf: speed,team-ecosystem,has reproducible steps,P2,found in release: 2.2,triaged-ecosystem | low | Major |
573,447,398 | godot | Can't assign variant from `unsigned long` on OSX and JavaScript builds | Using latest 3.2 branch of Godot, my module no longer compiles on OSX due to an error about converting `unsigned long` to `Variant`.
Compiling on Windows and Linux works fine.
See https://github.com/Zylann/godot_voxel/issues/170
And https://github.com/Zylann/voxelgame/issues/72
Is it something that got changed recently? | bug,platform:macos,topic:buildsystem | low | Critical |
573,464,171 | flutter | Add isBottomSheetOpen parameter. | We have a [ScaffoldState.isDrawerOpen](https://api.flutter.dev/flutter/material/ScaffoldState/isDrawerOpen.html) property amongst others, which are based on if the corresponding methods are called on ScaffoldState. Can we add one for if a BottomSheet is being displayed? | c: new feature,framework,f: material design,c: proposal,P3,team-design,triaged-design | low | Major |
573,466,421 | flutter | Add onClosing parameter to ScaffoldState.showBottomSheet | The BottomSheet widget has an onClosing parameter we can set, but it's suggested to just use the function provided and [it says](https://api.flutter.dev/flutter/material/ScaffoldState/showBottomSheet.html) that a BottomSheet becomes the parent of the widget.
When it's done automatically for us, we don't get the option to set the value of `onClosing`. Can this be exposed for us?
A [current workaround](https://stackoverflow.com/questions/51909218/can-you-listen-for-showbottomsheet-on-close) is to await the `PersistantBottomSheetController.closed` future, which is a little clunky. | c: new feature,framework,f: material design,c: proposal,P3,team-design,triaged-design | low | Minor |
573,486,872 | rust | Regression in error message quality for macro_rules involving $:ident | Between nightly-2020-02-28 and nightly-2020-02-29 I observed that macro errors which used to point to a specific problematic identifier token now point equivocally to the entire macro invocation. See https://github.com/dtolnay/tt-call/commit/364468e51f460e0dc41475659432b964035b4a2e.
The issue minimizes to:
```rust
macro_rules! nothing_expected {
() => {};
}
macro_rules! repro {
($ident:ident) => {
nothing_expected!($ident);
};
}
repro!(T);
```
Before; points to `T`:
```console
error: no rules expected the token `T`
--> src/main.rs:11:8
|
1 | macro_rules! nothing_expected {
| ----------------------------- when calling this macro
...
11 | repro!(T);
| ^ no rules expected this token in macro call
```
After; does not point to `T`:
```console
error: no rules expected the token `T`
--> src/main.rs:7:27
|
1 | macro_rules! nothing_expected {
| ----------------------------- when calling this macro
...
7 | nothing_expected!($ident);
| ^^^^^^ no rules expected this token in macro call
...
11 | repro!(T);
| ---------- in this macro invocation
|
= note: this error originates in a macro (in Nightly builds, run with -Z macro-backtrace for more info)
```
The applicable commit range is https://github.com/rust-lang/rust/compare/6d69caba110c0c2fb90180df1cbc8be5033b91d4...0eb878d2aa6e3a1cb315f3f328681b26bb4bffdb.
The most relevant looking PR in that range is https://github.com/rust-lang/rust/pull/69384. @petrochenkov @Centril | C-enhancement,A-diagnostics,P-medium,A-macros,T-compiler,regression-from-stable-to-stable | low | Critical |
573,496,416 | terminal | Support fullscreening with Win+Shift+Enter | Hello, I know this app will full-screen with `Alt`+`Enter` and `F11`
Please add a new keyboard shortcut for full-screen: `Win`+`Shift`+`Enter`
Why?! Because all universal apps became full-screen with `Win`+`Shift`+`Enter`
Thanks. | Area-UserInterface,Product-Terminal,Issue-Task | low | Major |
573,501,257 | ant-design | Form.List support `noRecord` | - [] I have searched the [issues](https://github.com/ant-design/ant-design/issues) of this repository and believe that this is not a duplicate.
### Reproduction link
[](https://codesandbox.io/s/antd-formlist-reproduction-jd281)
### Steps to reproduce
1. 在列表xxx中输入非法值123
2. 列表选择【隐藏】
3. 点击【提交】
4. 规则校验不会校验列表xxx字段的值，但是getFieldsValue()和onFinish的值仍旧包含
```
{
list: [
...,
xxx: "123",
],
}
```
### What is expected?
`Form.List`内的`Form.Item`隐藏后在收集值时可以符合页面表现
当`<Form.List>`中的`<Form.Item name={[index, "xxx"]}>`不渲染时
收集值应不包含`list[index].xxx`。
`<Form.List>`中的`<Form.Item name={[index, "xxx"]}>`
应该等同于直接在
`<Form>`内书写`<Form.Item name={["list", index, "xxx"]}>`
去作为数据绑定
而不能因为是`Form.List`的子元素，表单项
`<Form.Item name={[index, "xxx"]}>`
的显隐变化在收集值时就被忽略掉。
`<Form.Item name={[index, "xxx"]}>`
不渲染时，收集的值应该为
```
{
list: [
type: "2",
],
}
```
而非
```
{
list: [
type: "2",
xxx: "123",
],
}
```
### What is actually happening?
`<Form.List>`中的`<Form.Item name={[index, "xxx"]}>`在未渲染时，值仍然被收集。
| Environment | Info |
|---|---|
| antd | 4.0.0 |
| React | latest |
| System | Windows10 |
| Browser | Chrome80 |
---
在#21713 中并未解决我说的问题
<!-- generated by ant-design-issue-helper. DO NOT REMOVE --> | 💡 Feature Request,Inactive,4.x | medium | Critical |
573,507,152 | youtube-dl | Hotstar ffmpeg Invalid data found when processing input | `[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['-v', '-k', '-f', 'bestvideo[height<=360]+bestaudio', 'https://www.hotstar.com/in/shikara-trailer/1260016799']
[debug] Encodings: locale UTF-8, fs utf-8, out utf-8, pref UTF-8
[debug] youtube-dl version 2020.02.16
[debug] Python version 3.8.1 (CPython) - Linux-3.18.71-perf-g7b625a0-armv7l-with-libc
[debug] exe versions: ffmpeg 4.2.2, ffprobe 4.2.2
[debug] Proxy map: {}
[hotstar] 1260016799: Downloading webpage
[hotstar] 1260016799: Downloading JSON metadata
[hotstar] 1260016799: Downloading m3u8 information
[hotstar] 1260016799: Downloading m3u8 information
[hotstar] 1260016799: Downloading MPD manifest
[hotstar] 1260016799: Downloading m3u8 information
[hotstar] 1260016799: Downloading m3u8 information
[hotstar] 1260016799: Downloading MPD manifest
[hotstar] 1260016799: Downloading m3u8 information
[hotstar] 1260016799: Downloading MPD manifest
[hotstar] 1260016799: Downloading m3u8 information
[hotstar] 1260016799: Downloading m3u8 information
[hotstar] 1260016799: Downloading MPD manifest
[debug] Invoking downloader on 'https://hses2.akamaized.net/videos/hotstarint/shikaratrailer/1260016799/1578426668634/ef31c1fb7dc8f8b33ce92d0a4fb8c736/video/avc1/3/index.m3u8'
[hlsnative] Downloading m3u8 manifest
[hlsnative] Total fragments: 38
[download] Destination: Shikara - Trailer-1260016799.fhls-271-2.mp4
[download] 0.2% of ~555.42KiB at Unknown speed ETA 04:02
[download] 0.5% of ~555.42KiB at 2.69MiB/s ETA 01:20
[download] 1.3% of ~555.42KiB at 4.57MiB/s ETA 00:34
[download] 2.6% of ~555.42KiB at 1.59MiB/s ETA 00:16
[download] 2.6% of ~555.42KiB at 1.59MiB/s ETA 00:16
[download] 1.3% of ~1.13MiB at 1.59MiB/s ETA 01:03
[download] 1.5% of ~1.13MiB at 1.59MiB/s ETA 00:56
[download] 1.9% of ~1.13MiB at 5.29MiB/s ETA 00:45
[download] 2.6% of ~1.13MiB at 5.61MiB/s ETA 00:33
[download] 3.9% of ~1.13MiB at 8.45MiB/s ETA 00:21
[download] 5.3% of ~1.13MiB at 696.45KiB/s ETA 00:16
[download] 5.3% of ~1.13MiB at 696.45KiB/s ETA 00:16
[download] 3.6% of ~1.69MiB at 696.45KiB/s ETA 00:36
[download] 3.7% of ~1.69MiB at 696.45KiB/s ETA 00:35
[download] 3.9% of ~1.69MiB at 6.07MiB/s ETA 00:33
[download] 4.4% of ~1.69MiB at 1.99MiB/s ETA 00:29
[download] 5.3% of ~1.69MiB at 3.69MiB/s ETA 00:24
[download] 7.2% of ~1.69MiB at 1001.49KiB/s ETA 00:18
[download] 7.9% of ~1.69MiB at 1.15MiB/s ETA 00:16
[download] 7.9% of ~1.69MiB at 1.15MiB/s ETA 00:16
[download] 7.0% of ~1.91MiB at 1.15MiB/s ETA 00:24
[download] 7.1% of ~1.91MiB at 1.15MiB/s ETA 00:24
[download] 7.3% of ~1.91MiB at 6.03MiB/s ETA 00:23
[download] 7.7% of ~1.91MiB at 6.62MiB/s ETA 00:22
[download] 8.6% of ~1.91MiB at 10.91MiB/s ETA 00:20
[download] 10.2% of ~1.91MiB at 853.88KiB/s ETA 00:17
[download] 10.5% of ~1.91MiB at 919.99KiB/s ETA 00:16
[download] 10.5% of ~1.91MiB at 919.99KiB/s ETA 00:16
[download] 10.0% of ~2.02MiB at 919.99KiB/s ETA 00:22
[download] 10.1% of ~2.02MiB at 959.87KiB/s ETA 00:22
[download] 10.3% of ~2.02MiB at 1.90MiB/s ETA 00:21
[download] 10.7% of ~2.02MiB at 1.66MiB/s ETA 00:20
[download] 11.4% of ~2.02MiB at 3.19MiB/s ETA 00:19
[download] 13.0% of ~2.02MiB at 797.95KiB/s ETA 00:17
[download] 13.2% of ~2.02MiB at 831.98KiB/s ETA 00:16
[download] 13.2% of ~2.02MiB at 831.98KiB/s ETA 00:16
[download] 12.7% of ~2.11MiB at 831.98KiB/s ETA 00:20
[download] 12.7% of ~2.11MiB at 818.88KiB/s ETA 00:20
[download] 12.9% of ~2.11MiB at 1.33MiB/s ETA 00:20
[download] 13.3% of ~2.11MiB at 2.38MiB/s ETA 00:19
[download] 14.0% of ~2.11MiB at 4.44MiB/s ETA 00:18
[download] 15.5% of ~2.11MiB at 924.60KiB/s ETA 00:16
[download] 15.8% of ~2.11MiB at 989.19KiB/s ETA 00:16
[download] 15.8% of ~2.11MiB at 989.19KiB/s ETA 00:16
[download] 15.9% of ~2.10MiB at 989.19KiB/s ETA 00:18
[download] 16.0% of ~2.10MiB at 1.29MiB/s ETA 00:18
[download] 16.2% of ~2.10MiB at 2.34MiB/s ETA 00:18
[download] 16.5% of ~2.10MiB at 3.64MiB/s ETA 00:17
[download] 17.3% of ~2.10MiB at 4.04MiB/s ETA 00:16
[download] 18.4% of ~2.10MiB at 869.63KiB/s ETA 00:15
[download] 18.4% of ~2.10MiB at 869.63KiB/s ETA 00:15
[download] 17.4% of ~2.24MiB at 869.63KiB/s ETA 00:19
[download] 17.5% of ~2.24MiB at 2.39MiB/s ETA 00:19
[download] 17.6% of ~2.24MiB at 4.17MiB/s ETA 00:18
[download] 18.0% of ~2.24MiB at 1.78MiB/s ETA 00:18
[download] 18.7% of ~2.24MiB at 3.41MiB/s ETA 00:17
[download] 20.1% of ~2.24MiB at 903.96KiB/s ETA 00:16
[download] 21.1% of ~2.24MiB at 1.12MiB/s ETA 00:15
[download] 21.1% of ~2.24MiB at 1.12MiB/s ETA 00:15
[download] 19.4% of ~2.44MiB at 1.12MiB/s ETA 00:18
[download] 19.4% of ~2.44MiB at 1.60MiB/s ETA 00:18
[download] 19.6% of ~2.44MiB at 2.97MiB/s ETA 00:18
[download] 19.9% of ~2.44MiB at 2.10MiB/s ETA 00:18
[download] 20.6% of ~2.44MiB at 3.68MiB/s ETA 00:17
[download] 21.8% of ~2.44MiB at 1.01MiB/s ETA 00:16
[download] 23.7% of ~2.44MiB at 1.39MiB/s ETA 00:14
[download] 23.7% of ~2.44MiB at 1.39MiB/s ETA 00:14
[download] 22.8% of ~2.54MiB at 1.39MiB/s ETA 00:17
[download] 22.9% of ~2.54MiB at 2.74MiB/s ETA 00:17
[download] 23.0% of ~2.54MiB at 4.84MiB/s ETA 00:16
[download] 23.3% of ~2.54MiB at 2.06MiB/s ETA 00:16
[download] 24.0% of ~2.54MiB at 3.88MiB/s ETA 00:16
[download] 25.2% of ~2.54MiB at 607.87KiB/s ETA 00:15
[download] 26.3% of ~2.54MiB at 837.75KiB/s ETA 00:14
[download] 26.3% of ~2.54MiB at 837.75KiB/s ETA 00:14
[download] 24.9% of ~2.68MiB at 837.75KiB/s ETA 00:17
[download] 25.0% of ~2.68MiB at 2.30MiB/s ETA 00:17
[download] 25.1% of ~2.68MiB at 3.94MiB/s ETA 00:17
[download] 25.4% of ~2.68MiB at 5.49MiB/s ETA 00:16
[download] 26.0% of ~2.68MiB at 7.94MiB/s ETA 00:16
[download] 27.1% of ~2.68MiB at 989.14KiB/s ETA 00:15
[download] 28.9% of ~2.68MiB at 1.04MiB/s ETA 00:14
[download] 28.9% of ~2.68MiB at 1.04MiB/s ETA 00:14
[download] 26.3% of ~2.96MiB at 720.67KiB/s ETA 00:19
[download] 26.4% of ~2.96MiB at 8.67KiB/s ETA 00:20
[download] 26.5% of ~2.96MiB at 20.13KiB/s ETA 00:20
[download] 26.8% of ~2.96MiB at 42.08KiB/s ETA 00:19
[download] 27.3% of ~2.96MiB at 86.54KiB/s ETA 00:19
[download] 28.4% of ~2.96MiB at 142.98KiB/s ETA 00:18
[download] 30.5% of ~2.96MiB at 237.80KiB/s ETA 00:16
[download] 31.6% of ~2.96MiB at 283.51KiB/s ETA 00:16
[download] 31.6% of ~2.96MiB at 283.51KiB/s ETA 00:16
[download] 30.6% of ~3.06MiB at 283.51KiB/s ETA 00:18
[download] 30.6% of ~3.06MiB at 1.72MiB/s ETA 00:18
[download] 30.8% of ~3.06MiB at 2.89MiB/s ETA 00:17
[download] 31.0% of ~3.06MiB at 4.07MiB/s ETA 00:17
[download] 31.5% of ~3.06MiB at 3.94MiB/s ETA 00:17
[download] 32.5% of ~3.06MiB at 809.59KiB/s ETA 00:16
[download] 34.2% of ~3.06MiB at 956.14KiB/s ETA 00:15
[download] 34.2% of ~3.06MiB at 956.14KiB/s ETA 00:15
[download] 34.2% of ~3.06MiB at 947.65KiB/s ETA 00:16
[download] 34.3% of ~3.06MiB at 1.13MiB/s ETA 00:16
[download] 34.4% of ~3.06MiB at 1.90MiB/s ETA 00:16
[download] 34.6% of ~3.06MiB at 1.04MiB/s ETA 00:16
[download] 35.1% of ~3.06MiB at 1.94MiB/s ETA 00:15
[download] 36.2% of ~3.06MiB at 827.68KiB/s ETA 00:15
[download] 36.8% of ~3.06MiB at 1019.36KiB/s ETA 00:14
[download] 36.8% of ~3.06MiB at 1019.36KiB/s ETA 00:14
[download] 37.0% of ~3.05MiB at 1019.36KiB/s ETA 00:15
[download] 37.0% of ~3.05MiB at 2.19MiB/s ETA 00:15
[download] 37.2% of ~3.05MiB at 3.65MiB/s ETA 00:15
[download] 37.4% of ~3.05MiB at 4.77MiB/s ETA 00:15
[download] 37.9% of ~3.05MiB at 7.88MiB/s ETA 00:14
[download] 39.0% of ~3.05MiB at 962.22KiB/s ETA 00:14
[download] 39.5% of ~3.05MiB at 1.12MiB/s ETA 00:13
[download] 39.5% of ~3.05MiB at 1.12MiB/s ETA 00:13
[download] 38.4% of ~3.14MiB at 1.12MiB/s ETA 00:15
[download] 38.5% of ~3.14MiB at 873.03KiB/s ETA 00:15
[download] 38.6% of ~3.14MiB at 1.66MiB/s ETA 00:15
[download] 38.9% of ~3.14MiB at 1.40MiB/s ETA 00:14
[download] 39.4% of ~3.14MiB at 2.64MiB/s ETA 00:14
[download] 40.4% of ~3.14MiB at 810.78KiB/s ETA 00:14
[download] 42.1% of ~3.14MiB at 954.25KiB/s ETA 00:13
[download] 42.1% of ~3.14MiB at 954.25KiB/s ETA 00:13
[download] 40.5% of ~3.26MiB at 954.25KiB/s ETA 00:14
[download] 40.6% of ~3.26MiB at 1.99MiB/s ETA 00:14
[download] 40.7% of ~3.26MiB at 3.47MiB/s ETA 00:14
[download] 41.0% of ~3.26MiB at 4.88MiB/s ETA 00:14
[download] 41.4% of ~3.26MiB at 5.35MiB/s ETA 00:14
[download] 42.4% of ~3.26MiB at 805.18KiB/s ETA 00:13
[download] 44.3% of ~3.26MiB at 887.99KiB/s ETA 00:12
[download] 44.7% of ~3.26MiB at 941.26KiB/s ETA 00:12
[download] 44.7% of ~3.26MiB at 941.26KiB/s ETA 00:12
[download] 43.7% of ~3.35MiB at 734.68KiB/s ETA 00:13
[download] 43.7% of ~3.35MiB at 33.63KiB/s ETA 00:13
[download] 43.8% of ~3.35MiB at 77.22KiB/s ETA 00:13
[download] 44.1% of ~3.35MiB at 161.01KiB/s ETA 00:13
[download] 44.5% of ~3.35MiB at 327.07KiB/s ETA 00:13
[download] 45.5% of ~3.35MiB at 649.20KiB/s ETA 00:12
[download] 47.3% of ~3.35MiB at 1000.69KiB/s ETA 00:11
[download] 47.4% of ~3.35MiB at 987.51KiB/s ETA 00:11
[download] 47.4% of ~3.35MiB at 987.51KiB/s ETA 00:11
[download] 46.3% of ~3.43MiB at 987.51KiB/s ETA 00:12
[download] 46.3% of ~3.43MiB at 1.21MiB/s ETA 00:12
[download] 46.4% of ~3.43MiB at 1.96MiB/s ETA 00:12
[download] 46.6% of ~3.43MiB at 2.37MiB/s ETA 00:12
[download] 47.1% of ~3.43MiB at 3.96MiB/s ETA 00:12
[download] 48.0% of ~3.43MiB at 785.54KiB/s ETA 00:12
[download] 49.8% of ~3.43MiB at 903.82KiB/s ETA 00:11
[download] 50.0% of ~3.43MiB at 920.57KiB/s ETA 00:11
[download] 50.0% of ~3.43MiB at 920.57KiB/s ETA 00:11
[download] 48.0% of ~3.57MiB at 87.17KiB/s ETA 00:12
[download] 48.1% of ~3.57MiB at 245.38KiB/s ETA 00:12
[download] 48.2% of ~3.57MiB at 553.18KiB/s ETA 00:12
[download] 48.4% of ~3.57MiB at 1.09MiB/s ETA 00:12
[download] 48.8% of ~3.57MiB at 2.17MiB/s ETA 00:12
[download] 49.7% of ~3.57MiB at 640.42KiB/s ETA 00:11
[download] 51.5% of ~3.57MiB at 697.51KiB/s ETA 00:11
[download] 52.6% of ~3.57MiB at 753.38KiB/s ETA 00:10
[download] 52.6% of ~3.57MiB at 753.38KiB/s ETA 00:10
[download] 52.4% of ~3.59MiB at 753.38KiB/s ETA 00:11
[download] 52.4% of ~3.59MiB at 1.48MiB/s ETA 00:11
[download] 52.5% of ~3.59MiB at 2.53MiB/s ETA 00:11
[download] 52.8% of ~3.59MiB at 1.09MiB/s ETA 00:11
[download] 53.2% of ~3.59MiB at 2.08MiB/s ETA 00:10
[download] 54.1% of ~3.59MiB at 887.21KiB/s ETA 00:10
[download] 55.3% of ~3.59MiB at 1.22MiB/s ETA 00:10
[download] 55.3% of ~3.59MiB at 1.22MiB/s ETA 00:10
[download] 53.8% of ~3.69MiB at 974.97KiB/s ETA 00:11
[download] 53.9% of ~3.69MiB at 1.09MiB/s ETA 00:11
[download] 54.0% of ~3.69MiB at 1.86MiB/s ETA 00:11
[download] 54.2% of ~3.69MiB at 1.08MiB/s ETA 00:10
[download] 54.6% of ~3.69MiB at 2.02MiB/s ETA 00:10
[download] 55.4% of ~3.69MiB at 870.36KiB/s ETA 00:10
[download] 57.1% of ~3.69MiB at 915.96KiB/s ETA 00:09
[download] 57.9% of ~3.69MiB at 966.17KiB/s ETA 00:09
[download] 57.9% of ~3.69MiB at 966.17KiB/s ETA 00:09
[download] 58.4% of ~3.66MiB at 966.17KiB/s ETA 00:09
[download] 58.5% of ~3.66MiB at 750.41KiB/s ETA 00:09
[download] 58.6% of ~3.66MiB at 1.47MiB/s ETA 00:09
[download] 58.8% of ~3.66MiB at 1.22MiB/s ETA 00:09
[download] 59.2% of ~3.66MiB at 2.35MiB/s ETA 00:09
[download] 60.1% of ~3.66MiB at 788.02KiB/s ETA 00:09
[download] 60.5% of ~3.66MiB at 966.54KiB/s ETA 00:08
[download] 60.5% of ~3.66MiB at 966.54KiB/s ETA 00:08
[download] 58.7% of ~3.77MiB at 934.77KiB/s ETA 00:10
[download] 58.8% of ~3.77MiB at 1.11MiB/s ETA 00:10
[download] 58.9% of ~3.77MiB at 1.83MiB/s ETA 00:10
[download] 59.1% of ~3.77MiB at 1.01MiB/s ETA 00:09
[download] 59.5% of ~3.77MiB at 1.90MiB/s ETA 00:09
[download] 60.3% of ~3.77MiB at 971.72KiB/s ETA 00:09
[download] 62.0% of ~3.77MiB at 1.11MiB/s ETA 00:08
[download] 63.2% of ~3.77MiB at 1.10MiB/s ETA 00:08
[download] 63.2% of ~3.77MiB at 1.10MiB/s ETA 00:08
[download] 62.4% of ~3.82MiB at 1.10MiB/s ETA 00:09
[download] 62.5% of ~3.82MiB at 2.05MiB/s ETA 00:09
[download] 62.6% of ~3.82MiB at 3.40MiB/s ETA 00:08
[download] 62.8% of ~3.82MiB at 1.37MiB/s ETA 00:08
[download] 63.2% of ~3.82MiB at 2.59MiB/s ETA 00:08
[download] 64.0% of ~3.82MiB at 742.24KiB/s ETA 00:08
[download] 65.7% of ~3.82MiB at 942.32KiB/s ETA 00:07
[download] 65.8% of ~3.82MiB at 957.66KiB/s ETA 00:07
[download] 65.8% of ~3.82MiB at 957.66KiB/s ETA 00:07
[download] 64.8% of ~3.88MiB at 957.66KiB/s ETA 00:08
[download] 64.8% of ~3.88MiB at 1.01MiB/s ETA 00:08
[download] 64.9% of ~3.88MiB at 1.97MiB/s ETA 00:08
[download] 65.1% of ~3.88MiB at 1.31MiB/s ETA 00:08
[download] 65.5% of ~3.88MiB at 2.49MiB/s ETA 00:08
[download] 66.3% of ~3.88MiB at 826.62KiB/s ETA 00:07
[download] 68.0% of ~3.88MiB at 947.53KiB/s ETA 00:07
[download] 68.4% of ~3.88MiB at 981.65KiB/s ETA 00:07
[download] 68.4% of ~3.88MiB at 981.65KiB/s ETA 00:07
[download] 69.0% of ~3.85MiB at 981.65KiB/s ETA 00:07
[download] 69.0% of ~3.85MiB at 1.04MiB/s ETA 00:07
[download] 69.1% of ~3.85MiB at 1.72MiB/s ETA 00:07
[download] 69.3% of ~3.85MiB at 1.14MiB/s ETA 00:07
[download] 69.8% of ~3.85MiB at 2.12MiB/s ETA 00:07
[download] 70.6% of ~3.85MiB at 751.89KiB/s ETA 00:06
[download] 71.1% of ~3.85MiB at 931.93KiB/s ETA 00:06
[download] 71.1% of ~3.85MiB at 931.93KiB/s ETA 00:06
[download] 70.1% of ~3.90MiB at 931.93KiB/s ETA 00:07
[download] 70.2% of ~3.90MiB at 369.24KiB/s ETA 00:07
[download] 70.3% of ~3.90MiB at 791.36KiB/s ETA 00:07
[download] 70.5% of ~3.90MiB at 1.49MiB/s ETA 00:07
[download] 70.9% of ~3.90MiB at 2.09MiB/s ETA 00:07
[download] 71.7% of ~3.90MiB at 839.05KiB/s ETA 00:07
[download] 73.3% of ~3.90MiB at 988.32KiB/s ETA 00:06
[download] 73.7% of ~3.90MiB at 1012.34KiB/s ETA 00:06
[download] 73.7% of ~3.90MiB at 1012.34KiB/s ETA 00:06
[download] 72.6% of ~3.96MiB at 1012.34KiB/s ETA 00:07
[download] 72.7% of ~3.96MiB at 1.75MiB/s ETA 00:06
[download] 72.8% of ~3.96MiB at 2.94MiB/s ETA 00:06
[download] 73.0% of ~3.96MiB at 4.04MiB/s ETA 00:06
[download] 73.4% of ~3.96MiB at 4.86MiB/s ETA 00:06
[download] 74.2% of ~3.96MiB at 801.19KiB/s ETA 00:06
[download] 75.7% of ~3.96MiB at 874.02KiB/s ETA 00:06
[download] 76.3% of ~3.96MiB at 983.11KiB/s ETA 00:05
[download] 76.3% of ~3.96MiB at 983.11KiB/s ETA 00:05
[download] 76.7% of ~3.94MiB at 983.11KiB/s ETA 00:05
[download] 76.8% of ~3.94MiB at 2.13MiB/s ETA 00:05
[download] 76.9% of ~3.94MiB at 3.71MiB/s ETA 00:05
[download] 77.1% of ~3.94MiB at 2.16MiB/s ETA 00:05
[download] 77.5% of ~3.94MiB at 4.06MiB/s ETA 00:05
[download] 78.3% of ~3.94MiB at 945.94KiB/s ETA 00:05
[download] 78.9% of ~3.94MiB at 1.27MiB/s ETA 00:05
[download] 78.9% of ~3.94MiB at 1.27MiB/s ETA 00:05
[download] 78.5% of ~3.96MiB at 1.27MiB/s ETA 00:05
[download] 78.6% of ~3.96MiB at 396.41KiB/s ETA 00:05
[download] 78.7% of ~3.96MiB at 836.73KiB/s ETA 00:05
[download] 78.9% of ~3.96MiB at 1.09MiB/s ETA 00:05
[download] 79.3% of ~3.96MiB at 2.09MiB/s ETA 00:05
[download] 80.1% of ~3.96MiB at 809.87KiB/s ETA 00:04
[download] 81.6% of ~3.96MiB at 877.70KiB/s ETA 00:04
[download] 81.6% of ~3.96MiB at 877.70KiB/s ETA 00:04
[download] 81.9% of ~3.95MiB at 834.52KiB/s ETA 00:04
[download] 81.9% of ~3.95MiB at 617.29KiB/s ETA 00:04
[download] 82.0% of ~3.95MiB at 1.15MiB/s ETA 00:04
[download] 82.2% of ~3.95MiB at 1.85MiB/s ETA 00:04
[download] 82.6% of ~3.95MiB at 2.27MiB/s ETA 00:04
[download] 83.4% of ~3.95MiB at 163.04KiB/s ETA 00:04
[download] 84.2% of ~3.95MiB at 231.34KiB/s ETA 00:03
[download] 84.2% of ~3.95MiB at 231.34KiB/s ETA 00:03
[download] 84.7% of ~3.92MiB at 231.34KiB/s ETA 00:03
[download] 84.8% of ~3.92MiB at 103.37KiB/s ETA 00:03
[download] 84.9% of ~3.92MiB at 235.85KiB/s ETA 00:03
[download] 85.1% of ~3.92MiB at 486.78KiB/s ETA 00:03
[download] 85.5% of ~3.92MiB at 963.06KiB/s ETA 00:03
[download] 86.3% of ~3.92MiB at 651.94KiB/s ETA 00:03
[download] 86.8% of ~3.92MiB at 843.51KiB/s ETA 00:03
[download] 86.8% of ~3.92MiB at 843.51KiB/s ETA 00:03
[download] 87.7% of ~3.89MiB at 843.51KiB/s ETA 00:03
[download] 87.7% of ~3.89MiB at 279.29KiB/s ETA 00:03
[download] 87.8% of ~3.89MiB at 563.35KiB/s ETA 00:03
[download] 88.0% of ~3.89MiB at 677.41KiB/s ETA 00:03
[download] 88.4% of ~3.89MiB at 1.19MiB/s ETA 00:03
[download] 89.2% of ~3.89MiB at 916.38KiB/s ETA 00:02
[download] 89.5% of ~3.89MiB at 1.01MiB/s ETA 00:02
[download] 89.5% of ~3.89MiB at 1.01MiB/s ETA 00:02
[download] 90.4% of ~3.85MiB at 1.01MiB/s ETA 00:02
[download] 90.5% of ~3.85MiB at 789.79KiB/s ETA 00:02
[download] 90.6% of ~3.85MiB at 1.44MiB/s ETA 00:02
[download] 90.8% of ~3.85MiB at 2.49MiB/s ETA 00:02
[download] 91.2% of ~3.85MiB at 4.37MiB/s ETA 00:02
[download] 92.0% of ~3.85MiB at 815.94KiB/s ETA 00:02
[download] 92.1% of ~3.85MiB at 869.13KiB/s ETA 00:02
[download] 92.1% of ~3.85MiB at 869.13KiB/s ETA 00:02
[download] 93.5% of ~3.79MiB at 869.13KiB/s ETA 00:01
[download] 93.6% of ~3.79MiB at 1.19MiB/s ETA 00:01
[download] 93.7% of ~3.79MiB at 1.96MiB/s ETA 00:01
[download] 93.9% of ~3.79MiB at 2.54MiB/s ETA 00:01
[download] 94.3% of ~3.79MiB at 4.20MiB/s ETA 00:01
[download] 94.7% of ~3.79MiB at 993.74KiB/s ETA 00:01
[download] 94.7% of ~3.79MiB at 993.74KiB/s ETA 00:01
[download] 96.5% of ~3.73MiB at 993.74KiB/s ETA 00:00
[download] 96.5% of ~3.73MiB at 245.09KiB/s ETA 00:00
[download] 96.6% of ~3.73MiB at 521.89KiB/s ETA 00:00
[download] 96.8% of ~3.73MiB at 715.69KiB/s ETA 00:00
[download] 97.3% of ~3.73MiB at 1.33MiB/s ETA 00:00
[download] 97.4% of ~3.73MiB at 1.37MiB/s ETA 00:00
[download] 97.4% of ~3.73MiB at 1.37MiB/s ETA 00:00
[download] 99.4% of ~3.65MiB at 953.68KiB/s ETA 00:00
[download] 99.4% of ~3.65MiB at 1.12MiB/s ETA 00:00
[download] 99.5% of ~3.65MiB at 1.88MiB/s ETA 00:00
[download] 99.8% of ~3.65MiB at 1.05MiB/s ETA 00:00
[download] 100.0% of ~3.65MiB at 1.43MiB/s ETA 00:00
[download] 100.0% of ~3.65MiB at 1.43MiB/s ETA 00:00
[download] 100% of 3.65MiB in 00:25
[debug] Invoking downloader on 'https://hses2.akamaized.net/videos/hotstarint/shikaratrailer/1260016799/1578426668634/edc756c36c7b14454395240bcd9e3276/master-phone.mpd?hdnea=st=1583044443~exp=1583048043~acl=/*~hmac=18b36782d6f7c93a4f8d7c726f45dbdd6601855a14d1604cff427ad39080c590'
[dashsegments] Total fragments: 39
[download] Destination: Shikara - Trailer-1260016799.fdash-audio_und_mp4a_2-3.m4a
[download] 2.6% of ~25.40KiB at 573.47KiB/s ETA 00:15
[download] 2.6% of ~25.40KiB at 573.47KiB/s ETA 00:15
[download] 0.3% of ~608.58KiB at 573.47KiB/s ETA 05:38
[download] 0.6% of ~608.58KiB at 1.36MiB/s ETA 02:32
[download] 1.3% of ~608.58KiB at 2.21MiB/s ETA 01:12
[download] 2.6% of ~608.58KiB at 1.25MiB/s ETA 00:35
[download] 5.1% of ~608.58KiB at 2.06MiB/s ETA 00:17
[download] 5.1% of ~608.58KiB at 2.06MiB/s ETA 00:17
[download] 3.9% of ~825.74KiB at 2.06MiB/s ETA 00:36
[download] 4.1% of ~825.74KiB at 1.36MiB/s ETA 00:34
[download] 4.6% of ~825.74KiB at 2.19MiB/s ETA 00:30
[download] 5.6% of ~825.74KiB at 1.06MiB/s ETA 00:25
[download] 7.5% of ~825.74KiB at 1.95MiB/s ETA 00:18
[download] 7.7% of ~825.74KiB at 1.77MiB/s ETA 00:17
[download] 7.7% of ~825.74KiB at 1.77MiB/s ETA 00:17
[download] 6.9% of ~932.02KiB at 988.52KiB/s ETA 00:31
[download] 7.1% of ~932.02KiB at 1.36MiB/s ETA 00:30
[download] 7.6% of ~932.02KiB at 2.16MiB/s ETA 00:28
[download] 8.4% of ~932.02KiB at 1.34MiB/s ETA 00:25
[download] 10.1% of ~932.02KiB at 2.43MiB/s ETA 00:21
[download] 10.3% of ~932.02KiB at 2.13MiB/s ETA 00:20
[download] 10.3% of ~932.02KiB at 2.13MiB/s ETA 00:20
[download] 9.7% of ~998.61KiB at 2.13MiB/s ETA 00:29
[download] 9.9% of ~998.61KiB at 2.41MiB/s ETA 00:28
[download] 10.3% of ~998.61KiB at 3.80MiB/s ETA 00:27
[download] 11.1% of ~998.61KiB at 1.78MiB/s ETA 00:25
[download] 12.7% of ~998.61KiB at 3.22MiB/s ETA 00:21
[download] 12.8% of ~998.61KiB at 2.91MiB/s ETA 00:21
[download] 12.8% of ~998.61KiB at 2.91MiB/s ETA 00:21
[download] 12.4% of ~1.02MiB at 990.39KiB/s ETA 00:25
[download] 12.6% of ~1.02MiB at 1.32MiB/s ETA 00:24
[download] 13.0% of ~1.02MiB at 2.12MiB/s ETA 00:24
[download] 13.7% of ~1.02MiB at 1.30MiB/s ETA 00:22
[download] 15.3% of ~1.02MiB at 2.39MiB/s ETA 00:19
[download] 15.4% of ~1.02MiB at 2.11MiB/s ETA 00:19
[download] 15.4% of ~1.02MiB at 2.11MiB/s ETA 00:19
[download] 15.0% of ~1.05MiB at 999.36KiB/s ETA 00:24
[download] 15.2% of ~1.05MiB at 1.17MiB/s ETA 00:24
[download] 15.6% of ~1.05MiB at 1.82MiB/s ETA 00:23
[download] 16.3% of ~1.05MiB at 1.10MiB/s ETA 00:22
[download] 17.8% of ~1.05MiB at 1.97MiB/s ETA 00:19
[download] 17.9% of ~1.05MiB at 1.67MiB/s ETA 00:19
[download] 17.9% of ~1.05MiB at 1.67MiB/s ETA 00:19
[download] 17.7% of ~1.07MiB at 1.67MiB/s ETA 00:22
[download] 17.8% of ~1.07MiB at 1.36MiB/s ETA 00:21
[download] 18.2% of ~1.07MiB at 2.20MiB/s ETA 00:21
[download] 18.9% of ~1.07MiB at 1.06MiB/s ETA 00:20
[download] 20.4% of ~1.07MiB at 1.98MiB/s ETA 00:18
[download] 20.5% of ~1.07MiB at 1.79MiB/s ETA 00:18
[download] 20.5% of ~1.07MiB at 1.79MiB/s ETA 00:18
[download] 20.3% of ~1.09MiB at 1.79MiB/s ETA 00:20
[download] 20.4% of ~1.09MiB at 1.29MiB/s ETA 00:20
[download] 20.8% of ~1.09MiB at 2.13MiB/s ETA 00:19
[download] 21.5% of ~1.09MiB at 1.10MiB/s ETA 00:19
[download] 23.0% of ~1.09MiB at 2.02MiB/s ETA 00:17
[download] 23.1% of ~1.09MiB at 1.83MiB/s ETA 00:17
[download] 23.1% of ~1.09MiB at 1.83MiB/s ETA 00:17
[download] 22.9% of ~1.10MiB at 1.83MiB/s ETA 00:19
[download] 23.1% of ~1.10MiB at 1.35MiB/s ETA 00:19
[download] 23.4% of ~1.10MiB at 2.14MiB/s ETA 00:18
[download] 24.1% of ~1.10MiB at 1.09MiB/s ETA 00:18
[download] 25.5% of ~1.10MiB at 2.03MiB/s ETA 00:16
[download] 25.6% of ~1.10MiB at 1.83MiB/s ETA 00:16
[download] 25.6% of ~1.10MiB at 1.83MiB/s ETA 00:16
[download] 25.4% of ~1.11MiB at 1.83MiB/s ETA 00:19
[download] 25.6% of ~1.11MiB at 1.38MiB/s ETA 00:19
[download] 26.0% of ~1.11MiB at 2.19MiB/s ETA 00:19
[download] 26.7% of ~1.11MiB at 1.33MiB/s ETA 00:18
[download] 28.1% of ~1.11MiB at 2.43MiB/s ETA 00:17
[download] 28.2% of ~1.11MiB at 2.14MiB/s ETA 00:17
[download] 28.2% of ~1.11MiB at 2.14MiB/s ETA 00:17
[download] 28.1% of ~1.12MiB at 2.14MiB/s ETA 00:18
[download] 28.2% of ~1.12MiB at 1.49MiB/s ETA 00:18
[download] 28.6% of ~1.12MiB at 2.35MiB/s ETA 00:17
[download] 29.3% of ~1.12MiB at 1.28MiB/s ETA 00:17
[download] 30.7% of ~1.12MiB at 2.36MiB/s ETA 00:16
[download] 30.8% of ~1.12MiB at 2.10MiB/s ETA 00:16
[download] 30.8% of ~1.12MiB at 2.10MiB/s ETA 00:16
[download] 30.6% of ~1.13MiB at 2.10MiB/s ETA 00:17
[download] 30.8% of ~1.13MiB at 1.44MiB/s ETA 00:16
[download] 31.1% of ~1.13MiB at 2.24MiB/s ETA 00:16
[download] 31.8% of ~1.13MiB at 3.06MiB/s ETA 00:16
[download] 33.2% of ~1.13MiB at 4.94MiB/s ETA 00:15
[download] 33.3% of ~1.13MiB at 3.79MiB/s ETA 00:15
[download] 33.3% of ~1.13MiB at 3.79MiB/s ETA 00:15
[download] 33.2% of ~1.14MiB at 3.79MiB/s ETA 00:16
[download] 33.4% of ~1.14MiB at 1.38MiB/s ETA 00:15
[download] 33.7% of ~1.14MiB at 2.17MiB/s ETA 00:15
[download] 34.4% of ~1.14MiB at 1.42MiB/s ETA 00:15
[download] 35.8% of ~1.14MiB at 2.56MiB/s ETA 00:14
[download] 35.9% of ~1.14MiB at 2.24MiB/s ETA 00:14
[download] 35.9% of ~1.14MiB at 2.24MiB/s ETA 00:14
[download] 35.8% of ~1.15MiB at 996.51KiB/s ETA 00:15
[download] 36.0% of ~1.15MiB at 1.26MiB/s ETA 00:14
[download] 36.3% of ~1.15MiB at 2.09MiB/s ETA 00:14
[download] 37.0% of ~1.15MiB at 1.08MiB/s ETA 00:14
[download] 38.4% of ~1.15MiB at 2.01MiB/s ETA 00:13
[download] 38.5% of ~1.15MiB at 1.80MiB/s ETA 00:13
[download] 38.5% of ~1.15MiB at 1.80MiB/s ETA 00:13
[download] 38.4% of ~1.15MiB at 987.82KiB/s ETA 00:14
[download] 38.5% of ~1.15MiB at 1.28MiB/s ETA 00:14
[download] 38.9% of ~1.15MiB at 2.07MiB/s ETA 00:13
[download] 39.6% of ~1.15MiB at 1.29MiB/s ETA 00:13
[download] 40.9% of ~1.15MiB at 2.36MiB/s ETA 00:12
[download] 41.0% of ~1.15MiB at 2.08MiB/s ETA 00:12
[download] 41.0% of ~1.15MiB at 2.08MiB/s ETA 00:12
[download] 40.9% of ~1.16MiB at 2.08MiB/s ETA 00:13
[download] 41.1% of ~1.16MiB at 1.37MiB/s ETA 00:13
[download] 41.4% of ~1.16MiB at 2.21MiB/s ETA 00:13
[download] 42.1% of ~1.16MiB at 1.10MiB/s ETA 00:12
[download] 43.5% of ~1.16MiB at 2.04MiB/s ETA 00:12
[download] 43.6% of ~1.16MiB at 1.79MiB/s ETA 00:12
[download] 43.6% of ~1.16MiB at 1.79MiB/s ETA 00:12
[download] 43.5% of ~1.16MiB at 914.79KiB/s ETA 00:12
[download] 43.7% of ~1.16MiB at 1.27MiB/s ETA 00:12
[download] 44.0% of ~1.16MiB at 2.07MiB/s ETA 00:12
[download] 44.7% of ~1.16MiB at 1.21MiB/s ETA 00:12
[download] 46.1% of ~1.16MiB at 2.19MiB/s ETA 00:11
[download] 46.2% of ~1.16MiB at 1.93MiB/s ETA 00:11
[download] 46.2% of ~1.16MiB at 1.93MiB/s ETA 00:11
[download] 46.1% of ~1.16MiB at 959.79KiB/s ETA 00:11
[download] 46.2% of ~1.16MiB at 1.25MiB/s ETA 00:11
[download] 46.6% of ~1.16MiB at 1.98MiB/s ETA 00:11
[download] 47.3% of ~1.16MiB at 1.11MiB/s ETA 00:11
[download] 48.6% of ~1.16MiB at 2.05MiB/s ETA 00:10
[download] 48.7% of ~1.16MiB at 1.84MiB/s ETA 00:10
[download] 48.7% of ~1.16MiB at 1.84MiB/s ETA 00:10
[download] 48.7% of ~1.17MiB at 1.84MiB/s ETA 00:11
[download] 48.8% of ~1.17MiB at 1.38MiB/s ETA 00:11
[download] 49.2% of ~1.17MiB at 2.22MiB/s ETA 00:11
[download] 49.8% of ~1.17MiB at 1.13MiB/s ETA 00:10
[download] 51.2% of ~1.17MiB at 2.10MiB/s ETA 00:10
[download] 51.3% of ~1.17MiB at 1.89MiB/s ETA 00:10
[download] 51.3% of ~1.17MiB at 1.89MiB/s ETA 00:10
[download] 51.2% of ~1.17MiB at 1.89MiB/s ETA 00:10
[download] 51.4% of ~1.17MiB at 1.89MiB/s ETA 00:10
[download] 51.7% of ~1.17MiB at 5.32MiB/s ETA 00:10
[download] 52.4% of ~1.17MiB at 2.04MiB/s ETA 00:10
[download] 53.7% of ~1.17MiB at 3.86MiB/s ETA 00:09
[download] 53.8% of ~1.17MiB at 3.63MiB/s ETA 00:09
[download] 53.8% of ~1.17MiB at 3.63MiB/s ETA 00:09
[download] 53.8% of ~1.17MiB at 3.63MiB/s ETA 00:09
[download] 54.0% of ~1.17MiB at 1.37MiB/s ETA 00:09
[download] 54.3% of ~1.17MiB at 2.23MiB/s ETA 00:09
[download] 55.0% of ~1.17MiB at 1.06MiB/s ETA 00:09
[download] 56.3% of ~1.17MiB at 1.97MiB/s ETA 00:08
[download] 56.4% of ~1.17MiB at 1.79MiB/s ETA 00:08
[download] 56.4% of ~1.17MiB at 1.79MiB/s ETA 00:08
[download] 56.4% of ~1.18MiB at 1.79MiB/s ETA 00:09
[download] 56.5% of ~1.18MiB at 1.39MiB/s ETA 00:09
[download] 56.9% of ~1.18MiB at 2.24MiB/s ETA 00:09
[download] 57.5% of ~1.18MiB at 1.07MiB/s ETA 00:08
[download] 58.9% of ~1.18MiB at 1.99MiB/s ETA 00:08
[download] 59.0% of ~1.18MiB at 1.83MiB/s ETA 00:08
[download] 59.0% of ~1.18MiB at 1.83MiB/s ETA 00:08
[download] 58.9% of ~1.18MiB at 981.12KiB/s ETA 00:08
[download] 59.1% of ~1.18MiB at 1.37MiB/s ETA 00:08
[download] 59.4% of ~1.18MiB at 2.23MiB/s ETA 00:08
[download] 60.1% of ~1.18MiB at 1.10MiB/s ETA 00:08
[download] 61.4% of ~1.18MiB at 2.04MiB/s ETA 00:07
[download] 61.5% of ~1.18MiB at 1.85MiB/s ETA 00:07
[download] 61.5% of ~1.18MiB at 1.85MiB/s ETA 00:07
[download] 61.5% of ~1.18MiB at 1.85MiB/s ETA 00:08
[download] 61.7% of ~1.18MiB at 1.41MiB/s ETA 00:08
[download] 62.0% of ~1.18MiB at 2.14MiB/s ETA 00:07
[download] 62.7% of ~1.18MiB at 1.24MiB/s ETA 00:07
[download] 64.0% of ~1.18MiB at 2.27MiB/s ETA 00:07
[download] 64.1% of ~1.18MiB at 2.03MiB/s ETA 00:07
[download] 64.1% of ~1.18MiB at 2.03MiB/s ETA 00:07
[download] 64.1% of ~1.18MiB at 982.73KiB/s ETA 00:07
[download] 64.3% of ~1.18MiB at 1.32MiB/s ETA 00:07
[download] 64.6% of ~1.18MiB at 2.16MiB/s ETA 00:07
[download] 65.2% of ~1.18MiB at 1.09MiB/s ETA 00:07
[download] 66.6% of ~1.18MiB at 2.04MiB/s ETA 00:06
[download] 66.7% of ~1.18MiB at 1.84MiB/s ETA 00:06
[download] 66.7% of ~1.18MiB at 1.84MiB/s ETA 00:06
[download] 66.6% of ~1.18MiB at 1.84MiB/s ETA 00:06
[download] 66.8% of ~1.18MiB at 1.36MiB/s ETA 00:06
[download] 67.1% of ~1.18MiB at 2.20MiB/s ETA 00:06
[download] 67.8% of ~1.18MiB at 1.20MiB/s ETA 00:06
[download] 69.1% of ~1.18MiB at 2.22MiB/s ETA 00:06
[download] 69.2% of ~1.18MiB at 1.99MiB/s ETA 00:06
[download] 69.2% of ~1.18MiB at 1.99MiB/s ETA 00:06
[download] 69.2% of ~1.18MiB at 1.99MiB/s ETA 00:06
[download] 69.4% of ~1.18MiB at 1.32MiB/s ETA 00:06
[download] 69.7% of ~1.18MiB at 2.13MiB/s ETA 00:06
[download] 70.4% of ~1.18MiB at 1.04MiB/s ETA 00:06
[download] 71.7% of ~1.18MiB at 1.90MiB/s ETA 00:05
[download] 71.8% of ~1.18MiB at 1.71MiB/s ETA 00:05
[download] 71.8% of ~1.18MiB at 1.71MiB/s ETA 00:05
[download] 71.8% of ~1.19MiB at 1.71MiB/s ETA 00:05
[download] 71.9% of ~1.19MiB at 1.71MiB/s ETA 00:05
[download] 72.3% of ~1.19MiB at 5.89MiB/s ETA 00:05
[download] 72.9% of ~1.19MiB at 6.39MiB/s ETA 00:05
[download] 74.3% of ~1.19MiB at 10.72MiB/s ETA 00:05
[download] 74.4% of ~1.19MiB at 8.78MiB/s ETA 00:05
[download] 74.4% of ~1.19MiB at 8.78MiB/s ETA 00:05
[download] 74.4% of ~1.19MiB at 926.71KiB/s ETA 00:05
[download] 74.5% of ~1.19MiB at 1.23MiB/s ETA 00:05
[download] 74.8% of ~1.19MiB at 1.94MiB/s ETA 00:05
[download] 75.5% of ~1.19MiB at 2.25MiB/s ETA 00:04
[download] 76.8% of ~1.19MiB at 3.81MiB/s ETA 00:04
[download] 76.9% of ~1.19MiB at 3.08MiB/s ETA 00:04
[download] 76.9% of ~1.19MiB at 3.08MiB/s ETA 00:04
[download] 76.9% of ~1.19MiB at 3.08MiB/s ETA 00:04
[download] 77.1% of ~1.19MiB at 1.44MiB/s ETA 00:04
[download] 77.4% of ~1.19MiB at 2.24MiB/s ETA 00:04
[download] 78.1% of ~1.19MiB at 1.08MiB/s ETA 00:04
[download] 79.4% of ~1.19MiB at 2.01MiB/s ETA 00:04
[download] 79.5% of ~1.19MiB at 1.82MiB/s ETA 00:04
[download] 79.5% of ~1.19MiB at 1.82MiB/s ETA 00:04
[download] 79.5% of ~1.19MiB at 959.14KiB/s ETA 00:04
[download] 79.7% of ~1.19MiB at 1.17MiB/s ETA 00:04
[download] 80.0% of ~1.19MiB at 1.92MiB/s ETA 00:04
[download] 80.6% of ~1.19MiB at 1.03MiB/s ETA 00:03
[download] 81.9% of ~1.19MiB at 1.90MiB/s ETA 00:03
[download] 82.1% of ~1.19MiB at 1.73MiB/s ETA 00:03
[download] 82.1% of ~1.19MiB at 1.73MiB/s ETA 00:03
[download] 82.1% of ~1.19MiB at 1.73MiB/s ETA 00:03
[download] 82.2% of ~1.19MiB at 1.39MiB/s ETA 00:03
[download] 82.5% of ~1.19MiB at 2.26MiB/s ETA 00:03
[download] 83.2% of ~1.19MiB at 1.10MiB/s ETA 00:03
[download] 84.5% of ~1.19MiB at 2.05MiB/s ETA 00:03
[download] 84.6% of ~1.19MiB at 1.85MiB/s ETA 00:03
[download] 84.6% of ~1.19MiB at 1.85MiB/s ETA 00:03
[download] 84.6% of ~1.19MiB at 938.32KiB/s ETA 00:03
[download] 84.8% of ~1.19MiB at 1.27MiB/s ETA 00:03
[download] 85.1% of ~1.19MiB at 2.07MiB/s ETA 00:02
[download] 85.8% of ~1.19MiB at 1.21MiB/s ETA 00:02
[download] 87.1% of ~1.19MiB at 2.22MiB/s ETA 00:02
[download] 87.2% of ~1.19MiB at 1.96MiB/s ETA 00:02
[download] 87.2% of ~1.19MiB at 1.96MiB/s ETA 00:02
[download] 87.2% of ~1.19MiB at 1.96MiB/s ETA 00:02
[download] 87.3% of ~1.19MiB at 1.24MiB/s ETA 00:02
[download] 87.7% of ~1.19MiB at 2.02MiB/s ETA 00:02
[download] 88.3% of ~1.19MiB at 1.05MiB/s ETA 00:02
[download] 89.6% of ~1.19MiB at 1009.49KiB/s ETA 00:02
[download] 89.7% of ~1.19MiB at 973.03KiB/s ETA 00:02
[download] 89.7% of ~1.19MiB at 973.03KiB/s ETA 00:02
[download] 89.8% of ~1.19MiB at 973.03KiB/s ETA 00:02
[download] 89.9% of ~1.19MiB at 1.36MiB/s ETA 00:02
[download] 90.2% of ~1.19MiB at 2.20MiB/s ETA 00:01
[download] 90.9% of ~1.19MiB at 1.05MiB/s ETA 00:01
[download] 92.2% of ~1.19MiB at 1.97MiB/s ETA 00:01
[download] 92.3% of ~1.19MiB at 1.78MiB/s ETA 00:01
[download] 92.3% of ~1.19MiB at 1.78MiB/s ETA 00:01
[download] 92.3% of ~1.20MiB at 1.78MiB/s ETA 00:01
[download] 92.5% of ~1.20MiB at 1.42MiB/s ETA 00:01
[download] 92.8% of ~1.20MiB at 2.28MiB/s ETA 00:01
[download] 93.4% of ~1.20MiB at 1.11MiB/s ETA 00:01
[download] 94.8% of ~1.20MiB at 2.07MiB/s ETA 00:01
[download] 94.9% of ~1.20MiB at 1.89MiB/s ETA 00:00
[download] 94.9% of ~1.20MiB at 1.89MiB/s ETA 00:00
[download] 94.9% of ~1.20MiB at 679.02KiB/s ETA 00:01
[download] 95.1% of ~1.20MiB at 970.68KiB/s ETA 00:00
[download] 95.4% of ~1.20MiB at 1.65MiB/s ETA 00:00
[download] 96.0% of ~1.20MiB at 980.56KiB/s ETA 00:00
[download] 97.3% of ~1.20MiB at 1.79MiB/s ETA 00:00
[download] 97.4% of ~1.20MiB at 1.62MiB/s ETA 00:00
[download] 97.4% of ~1.20MiB at 1.62MiB/s ETA 00:00
[download] 99.7% of ~1.17MiB at 956.51KiB/s ETA 00:00
[download] 99.8% of ~1.17MiB at 1.30MiB/s ETA 00:00
[download] 100.0% of ~1.17MiB at 1.10MiB/s ETA 00:00
[download] 100.0% of ~1.17MiB at 1.10MiB/s ETA 00:00
[download] 100% of 1.17MiB in 00:19
[ffmpeg] Merging formats into "Shikara - Trailer-1260016799.mp4"
[debug] ffmpeg command line: ffmpeg -y -loglevel repeat+info -i 'file:Shikara - Trailer-1260016799.fhls-271-2.mp4' -i 'file:Shikara - Trailer-1260016799.fdash-audio_und_mp4a_2-3.m4a' -c copy -map 0:v:0 -map 1:a:0 'file:Shikara - Trailer-1260016799.temp.mp4'
ERROR: file:Shikara - Trailer-1260016799.fhls-271-2.mp4: Invalid data found when processing input
Traceback (most recent call last):
File "/data/data/com.termux/files/usr/lib/python3.8/site-packages/youtube_dl/YoutubeDL.py", line 2064, in post_process
files_to_delete, info = pp.run(info)
File "/data/data/com.termux/files/usr/lib/python3.8/site-packages/youtube_dl/postprocessor/ffmpeg.py", line 512, in run
self.run_ffmpeg_multiple_files(info['__files_to_merge'], temp_filename, args)
File "/data/data/com.termux/files/usr/lib/python3.8/site-packages/youtube_dl/postprocessor/ffmpeg.py", line 235, in run_ffmpeg_multiple_files
raise FFmpegPostProcessorError(msg)
youtube_dl.postprocessor.ffmpeg.FFmpegPostProcessorError: file:Shikara - Trailer-1260016799.fhls-271-2.mp4: Invalid data found when processing input
` | geo-restricted | low | Critical |
573,524,691 | nvm | Allow other package managers for `default-packages` installation | I have recently switched to [pnpm](https://pnpm.js.org/en/) and would like to install my default global packages to be installed with it instead of `npm` to avoid alias issues. Same goes for people that prefers `yarn`. | feature requests | low | Major |
573,541,957 | TypeScript | Inference for Object.isPrototypeOf() | Hi, I am wondering would be possible to infer types for [isPrototypeOf()](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/isPrototypeOf) function same way as it's done with `instanceof` operator? So we could narrow type of argument if it's been created using `Object.create(proto)` function and its type would be something like `typeof proto` if check is fulfilled.
## Search Terms
<!-- List of keywords you searched for before creating this issue. Write them down here so that others can find this suggestion more easily -->
isPrototypeOf
## Examples
<!-- Show how this would be used and what the behavior would be -->
```
if (object instanceof HTMLAnchorElement) {
console.log(object.href);
}
if (HTMLAnchorElement.prototype.isPrototypeOf(object)) {
console.log(object.href);
}
```
## Checklist
My suggestion meets these guidelines:
* [ ] This wouldn't be a breaking change in existing TypeScript/JavaScript code
* [ ] This wouldn't change the runtime behavior of existing JavaScript code
* [ ] This could be implemented without emitting different JS based on the types of the expressions
* [ ] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
* [x] This feature would agree with the rest of [TypeScript's Design Goals](https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals).
| Suggestion,Awaiting More Feedback | low | Minor |
573,544,434 | TypeScript | A mixin class must have a constructor with a single rest parameter of type 'any[]'. | <!-- 🚨 STOP 🚨 𝗦𝗧𝗢𝗣 🚨 𝑺𝑻𝑶𝑷 🚨
Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Even if you think you've found a *bug*, please read the FAQ first, especially the Common "Bugs" That Aren't Bugs section!
Please help us by doing the following steps before logging an issue:
* Search: https://github.com/Microsoft/TypeScript/search?type=Issues
* Read the FAQ: https://github.com/Microsoft/TypeScript/wiki/FAQ
Please fill in the *entire* template below.
-->
<!--
Please try to reproduce the issue with the latest published version. It may have already been fixed.
For npm: `typescript@next`
This is also the 'Nightly' version in the playground: http://www.typescriptlang.org/play/?ts=Nightly
-->
**TypeScript Version:** 3.8.2
<!-- Search terms you tried before logging this (so others can find this issue more easily) -->
**Search Terms:** "A mixin class must have a constructor with a single rest parameter of type 'any[]'."
**Code**
```ts
export type Constructor<T = {}> = new (...a: any[]) => T;
export function DataMixin<TBase extends Constructor<{}>>(
superclass: TBase
) {
return class DataClass<TData> extends superclass {
data: TData = null;
};
}
export function QueryMixin<TBase extends Constructor<{}>>(
superclass: TBase
) {
return class QueryClass<TData> extends DataMixin<TBase>(superclass)<TData> {
query(): TData {
return this.data;
}
};
}
```
**Expected behavior:**
I'd expect this to compile without error
**Actual behavior:**
```error TS2545: A mixin class must have a constructor with a single rest parameter of type 'any[]'.```
**Playground Link:** [Playground Link](http://www.typescriptlang.org/play/?strictNullChecks=false&ts=3.9.0-dev.20200228#code/KYDwDg9gTgLgBDAnmYcDCEB2BnGUCuAxjNADwAqcAvHAN4C+AfNXJsAO5wAUAdHwIYAuOP0yIA2gF0AlNWbkA3AFgAUKtCRYcAGb5MxAJZY4AEX4x+AWQMgDmCgCF+2VKBjBMAE2zosuAsRkDIyMXKpwcNj4KFCEADbO2MLkTi6qsrThcFDAMPhQmHDxiabm-GgJ2NgUZhbMbh7ekdHAsZU+mSoREZ5lybX8LJj4cXHKXXD04-Sq6uDQ8Lr6MEaFAIr4rYjWtvYpzq4g7l4+GDh4RCRQpMGhWVExxVXJqcDpdFk5eQVF7XAbWwqiRqZXqR0aPgGOzsjgOoQerSe2GkILqHwmEQAjpsoIguNJ+mV0d1ul98oUYAALAzYHi9CzjEkzCZTVTMoA)
**Related Issues:** https://github.com/Microsoft/TypeScript/issues/16390
| Bug | medium | Critical |
573,556,847 | godot | apply_impulse, add_force sometimes makes the RigidBody fly away. | **Godot version:**
3.2 release
**OS/device including version:**
Ubuntu 19.10
**Issue description:**
I have a FPS game shooting a lot of bullets (instanced, not raycasting) and on the method "do_damage" I apply impulse to a RigidBody when it get hit from bullet.
The problem is that the RigidBody sometimes (and more than sometimes) receive an extreme impulse. An insane one. But when I check the values (printing it to output) the numbers of the impulse and the used offset is correct. So the problem is outside of my gdscript code.
**How to reproduce**
To reproduce put some box with RigidBody and make a weapon to shoot bullets as KinematicBody. Use move_and_collide on the bullet and apply impulse to the box (only one time) when it hit.
The behaviour occurs too sometimes without the use of apply_impulse.
Make sure to don't let the RigidBody sleep (uncheck "Can Sleep").
Test it only with the box and the bullets. Don't use apply impulse and sometimes the box will fly as if it was impulsed by something. But how? if there are no apply_impulse in any place?
Well, I guess it is some bug on the bullet engine. | bug,topic:physics | low | Critical |
573,560,041 | TypeScript | Allow mixin constructor have parameters before rest parameter | ## Search Terms
mixin, constructor parameters
## Suggestion
Allow mixin constructor have parameters before rest parameter and infer the combination between mixin parameters.
## Use Cases
The following js code is completely valid and functional. However with the actual mixin constructor constraints we can't reproduce this in Typescript.
```js
const mixin1 = (base) => class Mixin1 extends base {
constructor(m1v1, m1v2, ...args) {
super(...args);
this.m1v1 = m1v1;
this.m1v2 = m1v2;
}
};
const mixin2 = (base) => class Mixin2 extends base {
constructor(m2v1, m2v2, ...args) {
super(...args);
this.m2v1 = m2v1;
this.m2v2 = m2v2;
}
};
class Base {
constructor(v1, v2) {
this.v1 = v1;
this.v2 = v2;
}
}
class C1 extends mixin1(Base) {
}
class C2 extends mixin2(Base) {
}
class C3 extends mixin2(mixin1(Base)) {
}
console.log(new C1("m1v1", true, 1, {}));
console.log(new C2(false, 2, 1, {}));
console.log(new C3(false, 2, "m1v1", true, 1, {}));
```
## Examples
Same code expected work in ts with constructor inference.
```ts
type Constructor = new (...args: any[]) => object;
const mixin1 = <T extends Constructor>(base: T) =>
class Mixin1 extends base {
m1v1: string;
m1v2: boolean;
constructor(m1v1: string, m1v2: boolean, ...args: any[]) {
super(...args);
this.m1v1 = m1v1;
this.m1v2 = m1v2;
}
}
const mixin2 = <T extends Constructor>(base: T) =>
class Mixin2 extends base {
m2v1: boolean;
m2v2: number;
constructor(m2v1: boolean, m2v2: number, ...args: any[]) {
super(...args);
this.m2v1 = m2v1;
this.m2v2 = m2v2;
}
}
class Base {
v1: number;
v2: object;
constructor(v1: number, v2: object) {
this.v1 = v1;
this.v2 = v2;
}
}
class C1 extends mixin1(Base) {
}
class C2 extends mixin2(Base) {
}
class C3 extends mixin2(mixin1(Base)) {
}
console.log(new C1("m1v1", true, 1, { })); // infer mixin1 and Base parameters: [string, boolean, number, object]
console.log(new C2(false, 2, 1, { })); // infer mixin2 and Base parameters: [boolean, number, number, object]
console.log(new C3(false, 2, "m1v1", true, 1, { })); // infer mixin2, mixin1 and Base parameters: [boolean, number, string, boolean, number, object]
```
## Checklist
My suggestion meets these guidelines:
* [x] This wouldn't be a breaking change in existing TypeScript/JavaScript code
* [x] This wouldn't change the runtime behavior of existing JavaScript code
* [x] This could be implemented without emitting different JS based on the types of the expressions
* [x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
* [x] This feature would agree with the rest of [TypeScript's Design Goals](https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals).
| Suggestion,Awaiting More Feedback | low | Major |
573,566,853 | pytorch | Torchscript Inference with DLL Creation | ## Issue description
I am developing in Windows 10 with Visual Studio 2019 and am trying to create a callable DLL. I created a simple C++ test project running the basic Torchscript example, and it seems to work fine. I then try to create a callable DLL and seem to run into
## Code example
`
#include "pch.h"
#include <torch/script.h>
#include <torch/torch.h>
#include <memory>
#include <iomanip>
#include <iostream>
#include <fstream>
extern "C"
{
__declspec(dllexport) void PerformInference() {
// Load up GPU stuff
torch::DeviceType device_type;
if (torch::cuda::is_available()) {
std::cout << "CUDA available! Training on GPU." << std::endl;
device_type = torch::kCUDA;
}
else {
std::cout << "Training on CPU." << std::endl;
device_type = torch::kCPU;
}
torch::Device device(device_type);
torch::jit::script::Module module;
std::cout << "Attempting to load resnet model.." << std::endl;
try {
// Deserialize the ScriptModule from a file using torch::jit::load().
module = torch::jit::load("C:\\PyTorchPictureTest\\Model\\traced_resnet_model_pretrained.pt");
std::cout << "Successfully loaded resnet model" << std::endl;
module.to(at::kCUDA);
std::cout << "Moved model to gpu" << std::endl;
std::vector<torch::jit::IValue> inputs;
inputs.push_back(torch::ones({ 1, 3, 224, 224 }).to(torch::kCUDA));
torch::Tensor out_tensor = module.forward(inputs).toTensor();
std::cout << out_tensor << '\n';
torch::Tensor out_tensor_cpu = out_tensor.to(torch::kCPU);
torch::Tensor out_tensor_cpu2 = out_tensor.cpu();
std::cout << "\n" << std::endl;
std::cout << out_tensor.sizes() << std::endl;
std::cout << out_tensor.sizes()[0] << std::endl;
std::cout << out_tensor.sizes()[1] << std::endl;
std::cout << "\n" << std::endl;
// Write tensor to file
std::ofstream myfile("example.txt");
if (myfile.is_open())
{
for (int i = 0; i < out_tensor.sizes()[1] - 1; i++) {
myfile << out_tensor[0][i].item<float_t>() << "\n";
}
myfile << out_tensor[0][out_tensor.sizes()[1] - 1].item<float_t>() << "\n";
myfile.close();
}
else std::cout << "Unable to open file";
}
catch (const c10::Error & e) {
std::cerr << "error loading the model\n";
return -1;
}
}
}
`
## Errors generated
1297 Errors
A few listed below
interned_strings.h, line 374: Code E0040, expected an identifier
TensorBody.h, line 607: Code E0106, invalid type for bit field
TensorBody.h, line 610: Code E0106, invalid type for bit field
TensorBody.h, line 620: Code E0757, member "at::Tensor::int64_t" is not a type name
## Library information and build dependencies
- LibTorch C++
- OS: Windows 10
- PyTorch version: 1.4.0, downloaded pre-built binaries from PyTorch Website (did not build from source)
- Python version:
- CUDA/cuDNN version: CUDA 10.1
- Other: Visual Studio 2019
Again, when I run the same code as a Visual C++ project, it seems to run fine.
For my DLL project, I have used the same project file template to create another DLL (one that does not use LibTorch C++) and it seems to work fine.
I would appreciate any insight. Thanks in advance.
cc @suo | oncall: jit | low | Critical |
573,576,630 | TypeScript | Stripping types should include ts-ignore comments | **TypeScript Version:** 3.8 latest, playground
**Search Terms:** remove ts-ignore comment
**Code**
```ts
// this is a comment that should be kept
const message: string = 'hello world';
// the below ts-ignore comment should be removed, since it has no meaning in a non-TS context
// @ts-ignore
console.log(message);
```
**Expected behavior:**
ts-ignore comment is stripped, other comments are kept.
**Actual behavior:**
all comments are kept including ts-ignore comments.
**Playground Link:** https://www.typescriptlang.org/play/#code/PTAEBcAsEsGdTqAhqAxgewLaYKYDtwJIlDZJ0BXAGwBNQAjHUAaxwAdwAoDPWQ3WLCQBzHAC5QfAE7Q8w0AF5QAckg4qVdKADu6KbWUBuTiCJNGm7RFgBaaMLx6mGbPlLlqJsAAFwt+45SONzovOhUOAB0msIAFAJCogCUhkA
**Related Issues:**
| Suggestion,Awaiting More Feedback | low | Major |
573,580,672 | flutter | Make an AnimatedList.seperated() constructor | <!-- Thank you for using Flutter!
If you are looking for support, please check out our documentation
or consider asking a question on Stack Overflow:
* https://flutter.dev/
* https://api.flutter.dev/
* https://stackoverflow.com/questions/tagged/flutter?sort=frequent
If you have found a bug or if our documentation doesn't have an answer
to what you're looking for, then fill our the template below. Please read
our guide to filing a bug first: https://flutter.dev/docs/resources/bug-reports
-->
## Use case
A seperated `AnimatedList` would be very useful for great UI's, and we don't have to use tiles (or whatever widget) all jumbled together.
I am using the [`firestore_ui`](https://pub.dev/packages/firestore_ui) package and noticed that they only used an `AnimatedList` and I was wondering if an `AnimatedList.seperated()` constructor existed so I could fork the package and add it but it turns out there isn't.
<!--
Please tell us the problem you are running into that led to you wanting
a new feature.
Is your feature request related to a problem? Please give a clear and
concise description of what the problem is.
Describe alternative solutions you've considered. Is there a package
on pub.dev/flutter that already solves this?
-->
## Proposal
Add an `AnimatedList.seperated()` constructor like `ListView` has so we can place a spacer like a `SizedBox` with a defined height.
<!--
Briefly but precisely describe what you would like Flutter to be able to do.
Consider attaching images showing what you are imagining.
Does this have to be provided by Flutter directly, or can it be provided
by a package on pub.dev/flutter? If so, maybe consider implementing and
publishing such a package rather than filing a bug.
-->
## Workaround
If you're using a `Container`, you can add a bottom margin so instead of this:
You get:
| framework,a: animation,c: proposal,P3,team-framework,triaged-framework | low | Critical |
573,584,782 | godot | get_angle_to() flickering rotation | **Godot version:**
3.2 stable
**OS/device including version:**
- Windows 10
- Fedora Linux 31
**Issue description:**
Using get_angle_to() in `_physics_process` or `_process` results in flickering rotation
**Steps to reproduce:**
Just add to the script:
```
func _physics_process(delta):
rotation = get_angle_to(Vector2(0, 0))
```
**Minimal reproduction project:**
None | bug,topic:core,confirmed | low | Minor |
573,605,526 | godot | Assets should be imported before running plugins and tool scripts | **Godot version:** 3.2 stable
**OS/device including version:** Ubuntu, but likely applies elsewhere.
**Issue description:**
If I delete `.import` and load the [2.5D demo projects](https://github.com/godotengine/godot-demo-projects/pull/315), I get this error:
Unable to load addon script from path: 'res://addons/node25d/node25d_plugin.gd' There seems to be an error in the code, please check the syntax.
However, if I then restart Godot, it works fine.
I think the root of the problem is that the assets are currently imported after (or at the same time as) the plugins are ran. This causes the scripts to fail the first time, so it's really annoying.
To fix this issue, Godot should import all assets before attempting to run plugins or other scripts.
EDIT: Actually, it's not so simple. Some scripts we want to run before importing assets. For example, scripts that extend the GLTF importer need to be run before GLTF files are imported. So we need some kind of dependency system that determines which assets a script needs to be imported before running. Or maybe as a quick fix we can force simple PNG/JPEG/etc files to import before scripts, and have more complex models wait to import? I'm not sure, it's a tricky situation.
| bug,topic:editor,confirmed,topic:plugin,topic:import | low | Critical |
573,620,649 | vscode | Minify dependencies and remove junk files | The shipped dependencies, available under macOS at `/Applications/Visual Studio Code.app/Contents/Resources/app/node_modules.asar`, are unminified and all sorts of junk files are in there (readmes, licenses...).
Minifying everything and avoiding shipping unnecessary files seems like a fairly decent optimization opportunity. | feature-request,perf,engineering | low | Minor |
573,629,427 | godot | Compile error: The filename or extension is too long | **Godot version:
3.2.1 custom build
**OS/device including version:**
Windows 10
**Issue description:**
This happen when i'm using this command:
scons platform=android target=release android_arch=arm64v8
| platform:android,topic:buildsystem | low | Critical |
573,649,367 | flutter | Reusing state logic is either too verbose or too difficult | [.](https://github.com/flutter/flutter/issues/51752#issuecomment-675844037)
Related to the discussion around hooks #25280
TL;DR: It is difficult to reuse `State` logic. We either end up with a complex and deeply nested `build` method or have to copy-paste the logic across multiple widgets.
It is neither possible to reuse such logic through mixins nor functions.
# Problem
Reusing a `State` logic across multiple `StatefulWidget` is very difficult, as soon as that logic relies on multiple life-cycles.
A typical example would be the logic of creating a `TextEditingController` (but also `AnimationController`, implicit animations, and many more). That logic consists of multiple steps:
- defining a variable on `State`.
```dart
TextEditingController controller;
```
- creating the controller (usually inside initState), with potentially a default value:
```dart
@override
void initState() {
super.initState();
controller = TextEditingController(text: 'Hello world');
}
```
- disposed the controller when the `State` is disposed:
```dart
@override
void dispose() {
controller.dispose();
super.dispose();
}
```
- doing whatever we want with that variable inside `build`.
- (optional) expose that property on `debugFillProperties`:
```dart
void debugFillProperties(DiagnosticPropertiesBuilder properties) {
super.debugFillProperties(properties);
properties.add(DiagnosticsProperty('controller', controller));
}
```
This, in itself, is not complex. The problem starts when we want to scale that approach.
A typical Flutter app may have dozens of text-fields, which means this logic is duplicated multiple times.
Copy-pasting this logic everywhere "works", but creates a weakness in our code:
- it can be easy to forget to rewrite one of the steps (like forgetting to call `dispose`)
- it adds a lot of noise in the code
## The Mixin issue
The first attempt at factorizing this logic would be to use a mixin:
```dart
mixin TextEditingControllerMixin<T extends StatefulWidget> on State<T> {
TextEditingController get textEditingController => _textEditingController;
TextEditingController _textEditingController;
@override
void initState() {
super.initState();
_textEditingController = TextEditingController();
}
@override
void dispose() {
_textEditingController.dispose();
super.dispose();
}
@override
void debugFillProperties(DiagnosticPropertiesBuilder properties) {
super.debugFillProperties(properties);
properties.add(DiagnosticsProperty('textEditingController', textEditingController));
}
}
```
Then used this way:
```dart
class Example extends StatefulWidget {
@override
_ExampleState createState() => _ExampleState();
}
class _ExampleState extends State<Example>
with TextEditingControllerMixin<Example> {
@override
Widget build(BuildContext context) {
return TextField(
controller: textEditingController,
);
}
}
```
But this has different flaws:
- A mixin can be used only once per class. If our `StatefulWidget` needs multiple `TextEditingController`, then we cannot use the mixin approach anymore.
- The "state" declared by the mixin may conflict with another mixin or the `State` itself.
More specifically, if two mixins declare a member using the same name, there will be a conflict.
Worst-case scenario, if the conflicting members have the same type, this will silently fail.
This makes mixins both un-ideal and too dangerous to be a true solution.
## Using the "builder" pattern
Another solution may be to use the same pattern as `StreamBuilder` & co.
We can make a `TextEditingControllerBuilder` widget, which manages that controller. Then our `build` method can use it freely.
Such a widget would be usually implemented this way:
```dart
class TextEditingControllerBuilder extends StatefulWidget {
const TextEditingControllerBuilder({Key key, this.builder}) : super(key: key);
final Widget Function(BuildContext, TextEditingController) builder;
@override
_TextEditingControllerBuilderState createState() =>
_TextEditingControllerBuilderState();
}
class _TextEditingControllerBuilderState
extends State<TextEditingControllerBuilder> {
TextEditingController textEditingController;
@override
void debugFillProperties(DiagnosticPropertiesBuilder properties) {
super.debugFillProperties(properties);
properties.add(
DiagnosticsProperty('textEditingController', textEditingController));
}
@override
void dispose() {
textEditingController.dispose();
super.dispose();
}
@override
Widget build(BuildContext context) {
return widget.builder(context, textEditingController);
}
}
```
Then used as such:
```dart
class Example extends StatelessWidget {
@override
Widget build(BuildContext context) {
return TextEditingControllerBuilder(
builder: (context, controller) {
return TextField(
controller: controller,
);
},
);
}
}
```
This solves the issues encountered with mixins. But it creates other issues.
- The usage is very verbose. That's effectively 4 lines of code + two levels of indentation for a single variable declaration.
This is even worse if we want to use it multiple times. While we can create a `TextEditingControllerBuilder` inside another once, this drastically decrease the code readability:
```dart
@override
Widget build(BuildContext context) {
return TextEditingControllerBuilder(
builder: (context, controller1) {
return TextEditingControllerBuilder(
builder: (context, controller2) {
return Column(
children: <Widget>[
TextField(controller: controller1),
TextField(controller: controller2),
],
);
},
);
},
);
}
```
That's a very indented code just to declare two variables.
- This adds some overhead as we have an extra `State` and `Element` instance.
- It is difficult to use the `TextEditingController` outside of `build`.
If we want a `State` life-cycles to perform some operation on those controllers, then we will need a `GlobalKey` to access them. For example:
```dart
class Example extends StatefulWidget {
@override
_ExampleState createState() => _ExampleState();
}
class _ExampleState extends State<Example> {
final textEditingControllerKey =
GlobalKey<_TextEditingControllerBuilderState>();
@override
void didUpdateWidget(Example oldWidget) {
super.didUpdateWidget(oldWidget);
if (something) {
textEditingControllerKey.currentState.textEditingController.clear();
}
}
@override
Widget build(BuildContext context) {
return TextEditingControllerBuilder(
key: textEditingControllerKey,
builder: (context, controller) {
return TextField(controller: controller);
},
);
}
}
```
| c: new feature,framework,dependency: dart,customer: crowd,c: proposal,P3,team-framework,triaged-framework | high | Critical |
573,666,685 | terminal | Feature request: wt.exe should display shortcut icon in taskbar | # Description of the new feature/enhancement
<!--
A clear and concise description of what the problem is that the new feature would solve.
Describe why and how a user would use this new functionality (if applicable).
-->
With a shortcut I can assign a `wt.exe` configuration per shortcut. But when the shortcut is run the `wt.exe` icon is shown not the shortcut icon.
This makes it hard to choose configurations short of opening each `wt.exe` window.
`cmd.exe` is an example of doing this well, it displays the icon of the shortcut when it is run. And each shortcut gets their own icon set in the taskbar for all windows started with that shortcut.
This would make it easy to set up specialized configs of `wt.exe` and be able to navigate between them easily.
This is similar to:
- #1871, but is not required to be dynamic.
- #1868, but is not about changing any escape sequences
## `cmd.exe` example
`cmd.exe` essentially has this feature. This should be able to be replicated by the Windows Terminal?
Create a **shortcut1**, target: `C:\Windows\System32\cmd.exe`
Add it's own icon. (Icon1)
Create a **shortcut2** target: `C:\Windows\System32\cmd.exe`
Add it's own icon. (Icon2)
1. Start shortcut1, Icon1 displays in the taskbar.
2. Start shortcut2, Icon2 displays in the taskbar even though it is just a 2nd instance of cmd.exe.
Here is a screenshot:
What you are looking at:
2 separate `cmd.exe` sessions on the left & 2 different `bash.exe` sessions on the right. Each with their own taskbar icon. Very easy to choose the right session from the taskbar.
| Issue-Feature,Area-Settings,Product-Terminal,Priority-3 | medium | Major |
573,666,836 | youtube-dl | Add sonuma.be | <!--
######################################################################
WARNING!
IGNORING THE FOLLOWING TEMPLATE WILL RESULT IN ISSUE CLOSED AS INCOMPLETE
######################################################################
-->
## Checklist
<!--
Carefully read and work through this check list in order to prevent the most common mistakes and misuse of youtube-dl:
- First of, make sure you are using the latest version of youtube-dl. Run `youtube-dl --version` and ensure your version is 2020.03.01. If it's not, see https://yt-dl.org/update on how to update. Issues with outdated version will be REJECTED.
- Make sure that all provided video/audio/playlist URLs (if any) are alive and playable in a browser.
- Make sure that site you are requesting is not dedicated to copyright infringement, see https://yt-dl.org/copyright-infringement. youtube-dl does not support such sites. In order for site support request to be accepted all provided example URLs should not violate any copyrights.
- Search the bugtracker for similar site support requests: http://yt-dl.org/search-issues. DO NOT post duplicates.
- Finally, put x into all relevant boxes (like this [x])
-->
- [x] I'm reporting a new site support request
- [x] I've verified that I'm running youtube-dl version **2020.03.01**
- [x] I've checked that all provided URLs are alive and playable in a browser
- [x] I've checked that none of provided URLs violate any copyrights
- [x] I've searched the bugtracker for similar site support requests including closed ones
## Example URLs
<!--
Provide all kinds of example URLs support for which should be included. Replace following example URLs by yours.
-->
- Single video: https://www.sonuma.be/archive/roulez-jeunesse
- Playlist: https://www.sonuma.be/thesaurus/collection-striptease
## Description
<!--
Provide any additional information.
If work on your issue requires account credentials please provide them or explain how one can obtain them.
-->
This is Belgium's public TV and radio archive.
Videos can be grabbed using a firefox extension (Video DownloadHelper for example). They're hosted on a CDN, infomaniak.ch. No credentials necessary | site-support-request | low | Critical |
573,686,577 | TypeScript | Docs - I am able to add new add new items to top level scope, contrary to what doc mention. | **Search Terms:** Documentation
**Typescript Version:** 3.5.3
Documentation [here](http://www.typescriptlang.org/docs/handbook/release-notes/typescript-1-8.html#augmenting-globalmodule-scope-from-modules) and [here](http://www.typescriptlang.org/docs/handbook/declaration-merging.html#global-augmentation) mention, "Neither module augmentations nor global augmentations can add new items to the top level scope - they can only “patch” existing declarations.", however I am able to "add new items".
```
//file-a.ts
import * as moment from 'moment';
declare module "moment" {
interface GoblyGoop {
name: string;
}
}
let y: moment.GoblyGoop;
//file-b.ts
import * as moment from 'moment';
let y: moment.GoblyGoop;
``` | Docs | low | Minor |
573,695,194 | flutter | How to implement a promotion in in_app_purchase plugin? | <!-- Thank you for using Flutter!
Please check out our documentation first:
* https://flutter.dev/
* https://api.flutter.dev/
If you can't find the answer there, please consider asking a question on
the Stack Overflow Web site:
* https://stackoverflow.com/questions/tagged/flutter?sort=frequent
Please don't file a GitHub issue for support requests. GitHub issues are
for tracking defects in the product. If you file a bug asking for help, we
will consider this a request for a documentation update.
-->
I use `in_app_purchase` package (https://pub.dev/packages/in_app_purchase) in my Flutter app. However, I still have no idea about implementing a promotion, like what documented here (for Android): https://developer.android.com/google/play/billing/billing_promo.
So, how to implement promotion in Flutter with this plugin? Please also add repo for working example. Thank you in advance.
| d: examples,p: in_app_purchase,package,team-ecosystem,P3,triaged-ecosystem | low | Critical |
573,703,478 | godot | Engine registers F8 when [ ´w ] typed. | **Godot version:** v3.2.stable.official
**OS/device including version:** Windows 7 Service Pack 1
**Issue description:** While the game is playing, if you press the spanish accent key (´) and later w, the game crashes. Also happens when both are pressed at the same time. The only key affected by this is the W key.
Notes: In any text editor with a spanish configuration, the accent key is pressed before a vocal in order to write a vocal character with an accent (á ´é í ó ú). If after the ´ a consonant is pressed, the result is the accent followed by the character (´q ´t ´p ´l ´k ´m ´b ...). If the accent is pressed two times it writes ´´ .
**Steps to reproduce:** To reproduce this bug you need a spanish keyboard layout that supports accent. If you configure and english keyboard with this layout, the key could be the semicolon [;:] (as told by http://en.key-test.ru/ ). Otherwise the key will be somewhere at the right of the letters.
- Open a new project and create a new scene.
- Play the game.
- Pres the accent key.
- Press W
-- Then the game should crash.
Note that in an inverted order or with any other key combination this bug doesn't happens.
For additional info: The keymap in the project settings identifies the accent ky pressed once as semicolon, but [ ´´ ] as "Launchmail".
**Minimal reproduction project:** This issue happens on a new empty project as on a long developed. However, here is a file just in case.
[launchmail key bug project.zip](https://github.com/godotengine/godot/files/4273386/launchmail.key.bug.project.zip)
| bug,platform:windows,confirmed,usability,topic:input | low | Critical |
573,739,173 | pytorch | Model loaded in C++ runtime is not thread safe | WARNING: ThreadSanitizer: data race (pid=17) Read of size 8 at 0x7fd6718c2ea0 by thread T2:
```#0 std::__1::shared_ptr<at::CPUGenerator>::get() const external/clang/include/c++/v1/memory:3800:49 (libexternal_Spytorch_Slibaten.so+0x37dba2)
#1 at::detail::getDefaultCPUGenerator() external/pytorch/aten/src/ATen/CPUGenerator.cpp:27:26 (libexternal_Spytorch_Slibaten.so+0x37dba2)
#2 THFloatTensor_uniform external/pytorch/aten/src/TH/generic/THTensorRandom.cpp:81:73 (libexternal_Spytorch_Slibaten.so+0x1801ace)
#3 at::native::legacy::cpu::_th_uniform_(at::Tensor&, double, double, at::Generator*) bazel-out/k8-dbg-tsan/bin/external/pytorch/ATen/LegacyTHFunctionsCPU.cpp:9339:13 (libexternal_Spytorch_Slibaten.so+0x1a165cf)
#4 at::CPUType::(anonymous namespace)::uniform_(at::Tensor&, double, double, at::Generator*) bazel-out/k8-dbg-tsan/bin/external/pytorch/ATen/CPUType.cpp:2079:12 (libexternal_Spytorch_Slibaten.so+0x192487f)
#5 c10::detail::WrapRuntimeKernelFunctor_<at::Tensor& (*)(at::Tensor&, double, double, at::Generator*), at::Tensor&, c10::guts::typelist::typelist<at::Tensor&, double, double, at::Generator*> >::operator()(at::Tensor&, double, double, at::Generator*) external/pytorch/aten/src/ATen/core/boxing/kernel_lambda.h:23:14 (libexternal_Spytorch_Slibpytorch.so+0x1321734)
#6 c10::detail::wrap_kernel_functor_unboxed_<c10::detail::WrapRuntimeKernelFunctor_<at::Tensor& (*)(at::Tensor&, double, double, at::Generator*), at::Tensor&, c10::guts::typelist::typelist<at::Tensor&, double, double, at::Generator*> >, at::Tensor& (at::Tensor&, double, double, at::Generator*)>::call(c10::OperatorKernel*, at::Tensor&, double, double, at::Generator*) external/pytorch/aten/src/ATen/core/boxing/kernel_functor.h:262:14 (libexternal_Spytorch_Slibpytorch.so+0x1321734)
#7 at::Tensor& c10::KernelFunction::callUnboxed<at::Tensor&, at::Tensor&, double, double, at::Generator*>(c10::OperatorHandle const&, at::Tensor&, double, double, at::Generator*) const external/pytorch/aten/src/ATen/core/boxing/KernelFunction_impl.h:62:16 (libexternal_Spytorch_Slibpytorch.so+0x8d4c21)
#8 at::Tensor& c10::Dispatcher::callUnboxed<at::Tensor&, at::Tensor&, double, double, at::Generator*>(c10::OperatorHandle const&, at::Tensor&, double, double, at::Generator*) const external/pytorch/aten/src/ATen/core/dispatch/Dispatcher.h:179:26 (libexternal_Spytorch_Slibpytorch.so+0x954957)
#9 at::Tensor& c10::OperatorHandle::callUnboxed<at::Tensor&, at::Tensor&, double, double, at::Generator*>(at::Tensor&, double, double, at::Generator*) const external/pytorch/aten/src/ATen/core/dispatch/Dispatcher.h:154:41 (libexternal_Spytorch_Slibpytorch.so+0x954957)
#10 at::Tensor::uniform_(double, double, at::Generator*) const bazel-out/k8-dbg-tsan/bin/external/pytorch/ATen/core/TensorMethods.h:4653:15 (libexternal_Spytorch_Slibpytorch.so+0x954957)
#11 at::native::rand(c10::ArrayRef<long>, at::Generator*, c10::TensorOptions const&) external/pytorch/aten/src/ATen/native/TensorFactories.cpp:441:17 (libexternal_Spytorch_Slibaten.so+0x9155fb)
#12 at::native::rand(c10::ArrayRef<long>, c10::TensorOptions const&) external/pytorch/aten/src/ATen/native/TensorFactories.cpp:436:10 (libexternal_Spytorch_Slibaten.so+0x915572)
#13 at::TypeDefault::rand(c10::ArrayRef<long>, c10::TensorOptions const&) bazel-out/k8-dbg-tsan/bin/external/pytorch/ATen/TypeDefault.cpp:3284:12 (libexternal_Spytorch_Slibaten.so+0x1a80570)
#14 c10::detail::WrapRuntimeKernelFunctor_<at::Tensor (*)(c10::ArrayRef<long>, c10::TensorOptions const&), at::Tensor, c10::guts::typelist::typelist<c10::ArrayRef<long>, c10::TensorOptions const&> >::operator()(c10::ArrayRef<long>, c10::TensorOptions const&) external/pytorch/aten/src/ATen/core/boxing/kernel_lambda.h:23:14 (libexternal_Spytorch_Slibpytorch.so+0x132b8bd)
#15 c10::detail::wrap_kernel_functor_unboxed_<c10::detail::WrapRuntimeKernelFunctor_<at::Tensor (*)(c10::ArrayRef<long>, c10::TensorOptions const&), at::Tensor, c10::guts::typelist::typelist<c10::ArrayRef<long>, c10::TensorOptions const&> >, at::Tensor (c10::ArrayRef<long>, c10::TensorOptions const&)>::call(c10::OperatorKernel*, c10::ArrayRef<long>, c10::TensorOptions const&) external/pytorch/aten/src/ATen/core/boxing/kernel_functor.h:262:14 (libexternal_Spytorch_Slibpytorch.so+0x132b8bd)
#16 at::Tensor c10::KernelFunction::callUnboxed<at::Tensor, c10::ArrayRef<long>, c10::TensorOptions const&>(c10::OperatorHandle const&, c10::ArrayRef<long>, c10::TensorOptions const&) const external/pytorch/aten/src/ATen/core/boxing/KernelFunction_impl.h:62:16 (test_pytorch+0xd1fcb)
#17 at::Tensor c10::Dispatcher::callUnboxed<at::Tensor, c10::ArrayRef<long>, c10::TensorOptions const&>(c10::OperatorHandle const&, c10::ArrayRef<long>, c10::TensorOptions const&) const external/pytorch/aten/src/ATen/core/dispatch/Dispatcher.h:179:26 (test_pytorch+0xcf638)
#18 at::Tensor c10::OperatorHandle::callUnboxed<at::Tensor, c10::ArrayRef<long>, c10::TensorOptions const&>(c10::ArrayRef<long>, c10::TensorOptions const&) const external/pytorch/aten/src/ATen/core/dispatch/Dispatcher.h:154:41 (test_pytorch+0xcf638)
#19 at::rand(c10::ArrayRef<long>, c10::TensorOptions const&) bazel-out/k8-dbg-tsan/bin/external/pytorch/ATen/Functions.h:6638:15 (libros_Ssrc_Sa_Ulibtorch_Uuser_Sliba_Ulibtorch_Uuser.so+0x16794)
#20 torch::rand(c10::ArrayRef<long>, c10::TensorOptions const&)::'lambda'()::operator()() const bazel-out/k8-dbg-tsan/bin/external/pytorch/torch/csrc/autograd/generated/variable_factories.h:534:12 (libros_Ssrc_Sa_Ulibtorch_Uuser_Sliba_Ulibtorch_Uuser.so+0x16794)
#21 torch::rand(c10::ArrayRef<long>, c10::TensorOptions const&) bazel-out/k8-dbg-tsan/bin/external/pytorch/torch/csrc/autograd/generated/variable_factories.h:532:23 (libros_Ssrc_Sa_Ulibtorch_Uuser_Sliba_Ulibtorch_Uuser.so+0x12194)
#22 a_libtorch_user::ALibtorchUser::call_inference(int) ros/src/a_libtorch_user/src/ALibtorchUser.cpp:32:26 (libros_Ssrc_Sa_Ulibtorch_Uuser_Sliba_Ulibtorch_Uuser.so+0x10bf7)
#23 decltype(*(std::__1::forward<a_libtorch_user::ALibtorchUser*>(fp0)).*fp(std::__1::forward<int>(fp1))) std::__1::__invoke<void (a_libtorch_user::ALibtorchUser::*)(int), a_libtorch_user::ALibtorchUser*, int, void>(void (a_libtorch_user::ALibtorchUser::*&&)(int), a_libtorch_user::ALibtorchUser*&&, int&&) external/clang/include/c++/v1/type_traits:3471:1 (libros_Ssrc_Sa_Ulibtorch_Uuser_Sliba_Ulibtorch_Uuser.so+0x267ed)
#24 void std::__1::__thread_execute<std::__1::unique_ptr<std::__1::__thread_struct, std::__1::default_delete<std::__1::__thread_struct> >, void (a_libtorch_user::ALibtorchUser::*)(int), a_libtorch_user::ALibtorchUser*, int, 2ul, 3ul>(std::__1::tuple<std::__1::unique_ptr<std::__1::__thread_struct, std::__1::default_delete<std::__1::__thread_struct> >, void (a_libtorch_user::ALibtorchUser::*)(int), a_libtorch_user::ALibtorchUser*, int>&, std::__1::__tuple_indices<2ul, 3ul>) external/clang/include/c++/v1/thread:277:5 (libros_Ssrc_Sa_Ulibtorch_Uuser_Sliba_Ulibtorch_Uuser.so+0x267ed)
#25 void* std::__1::__thread_proxy<std::__1::tuple<std::__1::unique_ptr<std::__1::__thread_struct, std::__1::default_delete<std::__1::__thread_struct> >, void (a_libtorch_user::ALibtorchUser::*)(int), a_libtorch_user::ALibtorchUser*, int> >(void*) external/clang/include/c++/v1/thread:287:5 (libros_Ssrc_Sa_Ulibtorch_Uuser_Sliba_Ulibtorch_Uuser.so+0x267ed)```
test.cpp
--------
void call_inference() {
int batch_size = 100;
torch::Tensor data = torch::rand({batch_size, 100, 30}).to(device);
torch::Tensor h0 = torch::rand({1, batch_size, 256}).to(device);
torch::Tensor c0 = torch::rand({1, batch_size, 256}).to(device);
module.run_method("forward", data, h0, c0);
}
...
for (int32_t i = 0; i < n; i++) {
std::thread t(&all_inference, i);
}
```
cc @yf225 | module: cpp,triaged,module: sanitizers | low | Minor |
573,769,265 | neovim | Langmap doesn't work for key combinations | <!-- Before reporting: search existing issues and check the FAQ. -->
- `nvim --version`: 0.4.3
- `vim -u DEFAULTS` (version: ) behaves differently? N/A
- Operating system/version: Fedora 31
- GUI name/version: neovim-gtk 0.3.0
### Steps to reproduce using `nvim -u NORC`
```
nvim-gtk -- -u NORC
:set langmap=цw,уe
```
Type something and try using <kbd>ц</kbd> in normal mode and <kbd>Ctrl</kbd>+<kbd>ц</kbd> in insert mode. Try using <kbd>Ctrl</kbd>+<kbd>у</kbd> in normal mode.
### Actual behaviour
<kbd>ц</kbd> gets remapped to <kbd>w</kbd>, <kbd>Ctrl</kbd>+<kbd>ц</kbd> does not get remapped to <kbd>Ctrl</kbd>+<kbd>w</kbd> and <kbd>Ctrl</kbd>+<kbd>у</kbd> results in the same action as just <kbd>e</kbd>. Explicitly mapping `<C-ц>` to `<C-w>` and `<C-у>` to `<C-e>` solves the issue.
### Expected behaviour
<kbd>Ctrl</kbd>+<kbd>ц</kbd> is remapped to <kbd>Ctrl</kbd>+<kbd>w</kbd> just like <kbd>ц</kbd> is remapped to <kbd>w</kbd>. Same goes for <kbd>Ctrl</kbd>+<kbd>у</kbd>, <kbd>Alt</kbd>+<kbd>ц</kbd> and so on, according to the `langmap`.
### Additional info
On terminals this isn't an issue because they remap cyrillic key combinations to english key combinations on their own. However, neovim-gtk (and possibly other GUIs) doesn't. I initially made an issue there: https://github.com/daa84/neovim-gtk/issues/227, but I feel that this should work in neovim out of the box. | bug | low | Minor |
573,799,470 | TypeScript | Inspect interface composition hierarchy and its full set of members | <!-- 🚨 STOP 🚨 𝗦𝗧𝗢𝗣 🚨 𝑺𝑻𝑶𝑷 🚨
Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker.
Please help us by doing the following steps before logging an issue:
* Search: https://github.com/Microsoft/TypeScript/search?type=Issues
* Read the FAQ, especially the "Common Feature Requests" section: https://github.com/Microsoft/TypeScript/wiki/FAQ
-->
## Search Terms
interface extends hierarchy, interface extends tree, interface tree
<!-- List of keywords you searched for before creating this issue. Write them down here so that others can find this suggestion more easily -->
## Suggestion
<!-- A summary of what you'd like to see added or changed -->
Inspired by the recently introduced function call tree, I would like to propose a similar kind of feature allowing for easy inspection of an `interface`'s hierarchical composition of other interfaces.
## Use Cases
Interfaces are great for dependency inversion and its `extends` allows for interface segregation. This proposed inspection feature would add the kind of super fluffy developer experience that encourages both principles to be used more liberally.
Currently, when the segregated interfaces are finally composed at some kind of top level and one needs to provide all required functionalities, one would need to keep checking what members are still missing. If a member turns up by surprise, it would take _recursive_ Ctrl+click through _all_ subjects of `extends` to see where that unexpected member is required. This alone is off-putting when one deals with a complex project and would like to keep unit dependencies as small as possible.
With this proposed inspector, one would be able write a unit module, quoting its dependent interfaces without needing to worry that the final composition way up would be hard to trace. There would be very little temptation/excuse to define some kind of God-interface, whose only one or two members are used by any module at a time.
(FWIW in my projects I'm already pursuing dependency inversion in full force and it pays great maintainability dividends. Even with the recursive click-through it is still significantly easier to reason with IMO than God interfaces.)
<!--
What do you want to use this for?
What shortcomings exist with current approaches?
-->
## Examples
<!-- Show how this would be used and what the behavior would be -->
For instance, for something like this (in reality, these interfaces would likely live in different files):
```ts
interface A { /* ... */ }
interface B { /* ... */ }
interface C extends A { /* ... */ }
interface D extends B { /* ... */ }
interface E extends C, D { /* ... */ }
```
would give rise to this tree upon inspecting `E`:
```
E
+- C
| +- A
+- D
| +- B
+- A
+- B
```
plus a view that shows all effective members of `E`.
I'm not sure how the listing of members would work precisely, but for starters it would be good to be able to use it to answer questions like:
1. What methods do I now expect to provide?
2. Why do I have to implement method `X`? (For those familiar with Yarn, it would be like `yarn why` on an interface member.)
I'm sure others can come up with more suggestions on the desirable dev-experience around the core idea.
## Checklist
My suggestion meets these guidelines:
* [x] This wouldn't be a breaking change in existing TypeScript/JavaScript code
* [x] This wouldn't change the runtime behavior of existing JavaScript code
* [x] This could be implemented without emitting different JS based on the types of the expressions
* [x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
* [x] This feature would agree with the rest of [TypeScript's Design Goals](https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals).
| Suggestion,Awaiting More Feedback | low | Critical |
573,816,300 | godot | Inconsistent global and local space in editor | Hi,
I have some problems to move objects in global or local space inside the editor.
The editor tooltip for the Translation property shows, that this is the local translation. But, if I rotate my object and change e.g. the z axis value, it seems to move in global space. The axis are shown correctly, If I activate the local transform mode. I hope the screenshots will explain the problem more
| documentation | low | Major |
573,855,523 | go | net: IPv6 network does not contain IPv4 to IPv6 translated addresses | ### What version of Go are you using (`go version`)?
1.14
### Does this issue reproduce with the latest release?
Yes
### What operating system and processor architecture are you using (`go env`)?
All operating system and processor architectures
### What did you do?
https://play.golang.org/p/IN-TOcROQnr
```go
// "8.8.8.8" translated to IPv6, same as net.ParseIP("8.8.8.8")
ip := net.ParseIP("0:0:0:0:0:ffff:808:808")
_, ipv4, _ := net.ParseCIDR("0.0.0.0/0")
fmt.Println(ipv4.Contains(ip)) // true
_, ipv6, _ := net.ParseCIDR("::/0")
fmt.Println(ipv6.Contains(ip)) // why it says false?
_, translated, _ := net.ParseCIDR("::ffff:0:0/96")
fmt.Println(translated.Contains(ip)) // true
```
### What did you expect to see?
```
true
true
true
```
### What did you see instead?
```
true
false
true
```
| NeedsInvestigation | low | Minor |
573,867,397 | pytorch | libtorch.so file size is very large | ## 🐛 Bug
The library size of torch is very large (~267MB without CUDA, 1.2 GB with CUDA).
This can be caused by using a library like Intel IPP similar to this opencv bug.
https://github.com/opencv/opencv/issues/15177
This limits the use of pytorch models in small environments (without CUDA).
## To Reproduce
Steps to reproduce the behavior:
1. Download the libtorch C++ library
<!-- If you have a code sample, error messages, stack traces, please provide it here as well -->
## Expected behavior
Library size without CUDA should be a lot less than that. or at least providing libtorch_tiny or ways to create it.
<!-- A clear and concise description of what you expected to happen. -->
## Environment
- PyTorch Version: 1.4
- OS: Linux
cc @ezyang @gchanan @zou3519 @bdhirsh @heitorschueroff @seemethere @malfet @walterddr @yf225 @glaringlee | high priority,module: binaries,module: cpp,triaged,oncall: mobile,quansight-nack | medium | Critical |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.