commit_msg
stringlengths 1
24.2k
| commit_hash
stringlengths 2
84
⌀ | project
stringlengths 2
40
| source
stringclasses 4
values | labels
int64 0
1
| repo_url
stringlengths 26
70
⌀ | commit_url
stringlengths 74
118
⌀ | commit_date
stringlengths 25
25
⌀ |
|---|---|---|---|---|---|---|---|
Rethrow cross-site exceptions as security errors
BUG=530301
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1339023002
git-svn-id: svn://svn.chromium.org/blink/trunk@202211 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | 051023a269e548c5da19246c7db6e9870dac2f69 | chrome | bigvul | 1 | null | null | null |
Add search bar to Android password settings
By enabling the feature PasswordSearch, a search icon will appear in the
action bar in Chrome > Settings > Save Passwords.
Clicking the icon will trigger a search box that hides non-password
views.
Every newly typed letter will instantly filter passwords which
don't contain the query. Ignores case.
Update: instead of adding a new white icon, the ic_search is recolored.
Update: merged with WIP crrev/c/868213
Bug: 794108
Change-Id: I9b4e3c7754bb5b0cc56e3156a746bcbf44aa5bd3
Reviewed-on: https://chromium-review.googlesource.com/866830
Commit-Queue: Friedrich Horschig <[email protected]>
Reviewed-by: Maxim Kolosovskiy <[email protected]>
Reviewed-by: Theresa <[email protected]>
Cr-Commit-Position: refs/heads/master@{#531891} | 03c9198815cc223325fd43182a7121de6f85b01e | chrome | bigvul | 1 | null | null | null |
Prevent leaking PDF data cross-origin
BUG=520422
Review URL: https://codereview.chromium.org/1311973002
Cr-Commit-Position: refs/heads/master@{#345267} | fff450abc4e2fb330ba700547a8e6a7b0fb90a6e | chrome | bigvul | 1 | null | null | null |
Implement the LitePage Integration Test with ChromeDriver
BUG=680567
Review-Url: https://codereview.chromium.org/2717563002
Cr-Commit-Position: refs/heads/master@{#453279} | e72a513a6c84075089ecda0570ce658d0b45f6dd | chrome | bigvul | 1 | null | null | null |
Geolocation: extract struct Geoposition out of geolocation.mojom
This CL extracts the struct Geoposition out of geolocation.mojom
into a file on its own. No new code.
Bug:
Change-Id: I6350537ccd19d1da0b02f3c8489fa39a06740376
Reviewed-on: https://chromium-review.googlesource.com/543577
Reviewed-by: Colin Blundell <[email protected]>
Reviewed-by: Tom Sepez <[email protected]>
Commit-Queue: Miguel Casas <[email protected]>
Cr-Commit-Position: refs/heads/master@{#481777} | a5015e84b97fe94e43c3d46f26c2b0480345bb80 | chrome | bigvul | 1 | null | null | null |
Avoid Showing rotation change notification when source is accelerometer
BUG=717252
TEST=Manually rotate device with accelerometer and observe there's no notification
Review-Url: https://codereview.chromium.org/2853113005
Cr-Commit-Position: refs/heads/master@{#469058} | 31b81d4cf8b6a063391839816c82fc61c8272e53 | chrome | bigvul | 1 | null | null | null |
gpu: Use GetUniformSetup computed result size.
[email protected]
BUG=468936
Review URL: https://codereview.chromium.org/1016193003
Cr-Commit-Position: refs/heads/master@{#321489} | 181c7400b2bf50ba02ac77149749fb419b4d4797 | chrome | bigvul | 1 | null | null | null |
Use correct context when throwing an exception
BUG=453979
[email protected]
Review URL: https://codereview.chromium.org/895553002
git-svn-id: svn://svn.chromium.org/blink/trunk@189325 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | 6d067124e87295721c62a77f0610e4b37f6098ad | chrome | bigvul | 1 | null | null | null |
VisibleSelection::nonBoundaryShadowTreeRootNode should return null when its anchor is a shadow root
TEST=Automated. Added ua-shadow-select-all-crash.html.
BUG=447906
Review URL: https://codereview.chromium.org/848843002
git-svn-id: svn://svn.chromium.org/blink/trunk@188788 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | 1be560402876e236d05f5cb4c1cc3f5387d4b289 | chrome | bigvul | 1 | null | null | null |
[Presentation API] Add layout test for connection.close() and fix test failures
Add layout test.
1-UA connection.close() hits NOTREACHED() in PresentationConnection::didChangeState(). Use PresentationConnection::didClose() instead.
BUG=697719
Review-Url: https://codereview.chromium.org/2730123003
Cr-Commit-Position: refs/heads/master@{#455225} | 0c08ed56a3e5089b3cc4094e83daae196a6300c4 | chrome | bigvul | 1 | null | null | null |
Cleanup and remove dead code in SetFocusedElement
This early-out was added in:
https://crrev.com/ce8ea3446283965c7eabab592cbffe223b1cf2bc
Back then, we applied fragment focus in LayoutUpdated() which could
cause this issue. This got cleaned up in:
https://crrev.com/45236fd563e9df53dc45579be1f3d0b4784885a2
so that focus is no longer applied after layout.
+Cleanup: Goto considered harmful
Bug: 795381
Change-Id: Ifeb4d2e03e872fd48cca6720b1d4de36ad1ecbb7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524417
Commit-Queue: David Bokan <[email protected]>
Reviewed-by: Stefan Zager <[email protected]>
Cr-Commit-Position: refs/heads/master@{#641101} | c3957448cfc6e299165196a33cd954b790875fdb | chrome | bigvul | 1 | null | null | null |
Fix DCHECK in account reconcilor when MultiLogin is enabled.
Bug:None
Change-Id: I8cb214541bacdae49e55cd87737fa8aa40ed1928
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1535881
Reviewed-by: David Roger <[email protected]>
Commit-Queue: Mihai Sardarescu <[email protected]>
Cr-Commit-Position: refs/heads/master@{#643357} | 0c65ca92b162f3d6dff2ec6571df629592ec32f2 | chrome | bigvul | 1 | null | null | null |
Only copy the Elevation Service executable for Google Chrome builds.
BUG=180589,833687
Change-Id: I4af08c2124ea8857f2ad860c268913b87297da7a
Reviewed-on: https://chromium-review.googlesource.com/c/1373131
Reviewed-by: Sorin Jianu <[email protected]>
Reviewed-by: Greg Thompson <[email protected]>
Commit-Queue: S. Ganesh <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616386} | 06fa2ca5a3ca56601aa9d901c23a674c3c2d6977 | chrome | bigvul | 1 | null | null | null |
[Extensions] More bindings hardening
Revision 83a4b3aa72d98fe4176b4a54c8cea227ed966570 missed a few
(c/r/resources/extensions).
BUG=468931
BUG=591164
Review URL: https://codereview.chromium.org/1840453002
Cr-Commit-Position: refs/heads/master@{#383541} | 180e7e74926ea32ac039821926542452d1201c5e | chrome | bigvul | 1 | null | null | null |
[Mac] Fix Issue to Exit Fullscreen
Ensure that the browser exits fullscreen if toggleFullscreen was called
during the transition to fullscreen.
BUG=579934
Review-Url: https://codereview.chromium.org/2053343003
Cr-Commit-Position: refs/heads/master@{#399506} | 104e5ad762f4d2fcf04a33ff8471d77d7b8678bb | chrome | bigvul | 1 | null | null | null |
[BGPT] Correctly set scrolls_outer_viewport bit
I noticed in debugging that the scroll tree never had an outer viewport.
Some investigation shows that we never hooked up the bit to the root
scroller.
Sure enough, before this CL, we don't perform the URL bar adjustment
correctly. This CL sets the bit based on the root scroller and fixes the
issue. Also added the scrolls_inner|outer_viewport bits to the debugging
output to make this easier to see.
Bug: 947879
Change-Id: I5a450aa2642a64f8db004c97c0e744d196e91009
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546540
Reviewed-by: Philip Rogers <[email protected]>
Commit-Queue: David Bokan <[email protected]>
Cr-Commit-Position: refs/heads/master@{#646394} | 9fbe5ca8091b6b42b0fe770ed088cdcf6ef144b7 | chrome | bigvul | 1 | null | null | null |
Always call UpdateCompositedScrollOffset, not just for the root layer
Bug: 927560
Change-Id: I1d5522aae4f11dd3f5b8947bb089bac1bf19bdb4
Reviewed-on: https://chromium-review.googlesource.com/c/1452701
Reviewed-by: Chris Harrelson <[email protected]>
Commit-Queue: Mason Freed <[email protected]>
Cr-Commit-Position: refs/heads/master@{#628942} | 5472db1c7eca35822219d03be5c817d9a9258c11 | chrome | bigvul | 1 | null | null | null |
Roll third_party/ink to 228585062
Bug: 902646
Change-Id: Ie15feae6a49fd6b0217513267843e0e7341eb965
Reviewed-on: https://chromium-review.googlesource.com/c/1404216
Reviewed-by: Darren Shen <[email protected]>
Commit-Queue: dstockwell <[email protected]>
Cr-Commit-Position: refs/heads/master@{#621362} | e4c9bcfdfd70ee7fde9af110ba439da8970af94a | chrome | bigvul | 1 | null | null | null |
Migrate ServiceProcessControl tests off of QuitCurrent*Deprecated().
Bug: 844016
Change-Id: I9403b850456c8ee06cd2539f7cec9599302e81a0
Reviewed-on: https://chromium-review.googlesource.com/1126576
Commit-Queue: Wez <[email protected]>
Reviewed-by: Avi Drissman <[email protected]>
Cr-Commit-Position: refs/heads/master@{#573131} | 53262b5285efbbfdbbcc17fbf5200890f1ee295c | chrome | bigvul | 1 | null | null | null |
Print Preview: Preserve settings when possible on destination changes
If the destination updates, preserve the user's settings if the
destination supports them. Otherwise, and in the case of initialization
without sticky settings (e.g. kiosk public sessions), use the printer
default.
Bug: 936396
Change-Id: Ie07fd94afe413323c19f13948ebc1715e888e7ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1474437
Commit-Queue: Rebekah Potter <[email protected]>
Reviewed-by: Demetrios Papadopoulos <[email protected]>
Cr-Commit-Position: refs/heads/master@{#637963} | 0dab95c5377907e3caed9a0faaf74bde12e0e841 | chrome | bigvul | 1 | null | null | null |
Reenable browse:news:cnn:2018 on go devices.
Bug: 931866
Change-Id: Iad447daafcae5486529784fd40686f517fab1ec7
Reviewed-on: https://chromium-review.googlesource.com/c/1482955
Auto-Submit: Carlos Caballero <[email protected]>
Reviewed-by: Juan Antonio Navarro Pérez <[email protected]>
Commit-Queue: Juan Antonio Navarro Pérez <[email protected]>
Cr-Commit-Position: refs/heads/master@{#634716} | 332c2d8dbd29c918c49ddb9d4ee2ad1193ccf96c | chrome | bigvul | 1 | null | null | null |
Fix memory leak in ChooserContextBase::GetGrantedObjects.
Bug: 854329
Change-Id: Ia163d503a4207859cd41c847c9d5f67e77580fbc
Reviewed-on: https://chromium-review.googlesource.com/c/1456080
Reviewed-by: Balazs Engedy <[email protected]>
Reviewed-by: Raymes Khoury <[email protected]>
Commit-Queue: Marek Haranczyk <[email protected]>
Cr-Commit-Position: refs/heads/master@{#629919} | 47ae3dfdee9a0796a079cd4eadf2f75b34f257ae | chrome | bigvul | 1 | null | null | null |
Tracing: Connect to service on startup
Temporary workaround for flaky tests introduced by
https://chromium-review.googlesource.com/c/chromium/src/+/1439082
[email protected]
Bug: 928410, 928363
Change-Id: I0dcf20cbdf91a7beea167a220ba9ef7e0604c1ab
Reviewed-on: https://chromium-review.googlesource.com/c/1452767
Reviewed-by: oysteine <[email protected]>
Reviewed-by: Eric Seckler <[email protected]>
Reviewed-by: Aaron Gable <[email protected]>
Commit-Queue: oysteine <[email protected]>
Cr-Commit-Position: refs/heads/master@{#631052} | 20a9e39a925dd0fb183acb61bb7b87f29abea83f | chrome | bigvul | 1 | null | null | null |
Roll PDFium ea3ff9e..a72ab5e
https://pdfium.googlesource.com/pdfium.git/+log/ea3ff9e..a72ab5e
BUG=62625,603490,633002,633381
[email protected]
Review-Url: https://codereview.chromium.org/2216503002
Cr-Commit-Position: refs/heads/master@{#409771} | aa065d9fed77b8cbdfe327b573e2f683c1ad6d6b | chrome | bigvul | 1 | null | null | null |
Prefer SyncService over ProfileSyncService in foreign_session_helper
SyncService is the interface, ProfileSyncService is the concrete
implementation. Generally no clients should need to use the conrete
implementation - for one, testing will be much easier once everyone
uses the interface only.
Bug: 924508
Change-Id: Ia210665f8f02512053d1a60d627dea0f22758387
Reviewed-on: https://chromium-review.googlesource.com/c/1461119
Auto-Submit: Marc Treib <[email protected]>
Commit-Queue: Yaron Friedman <[email protected]>
Reviewed-by: Yaron Friedman <[email protected]>
Cr-Commit-Position: refs/heads/master@{#630662} | 32a9879fc01c24f9216bb2975200ab8a4afac80c | chrome | bigvul | 1 | null | null | null |
Ignore filtered event if an event matcher cannot be added.
BUG=625404
Review-Url: https://codereview.chromium.org/2236133002
Cr-Commit-Position: refs/heads/master@{#411472} | ba011d9f8322c62633a069a59c2c5525e3ff46cc | chrome | bigvul | 1 | null | null | null |
Roll PDFium 135b998..b6befb2
https://pdfium.googlesource.com/pdfium.git/+log/135b998..b6befb2
BUG=635008,634716,632622
[email protected]
Review-Url: https://codereview.chromium.org/2226163003
Cr-Commit-Position: refs/heads/master@{#410544} | 66235aa45c0b0dcc0b875e4ade2747cf6b195ee4 | chrome | bigvul | 1 | null | null | null |
Position info (item n of m) incorrect if hidden focusable items in list
Bug: 836997
Change-Id: I971fa7076f72d51829b36af8e379260d48ca25ec
Reviewed-on: https://chromium-review.googlesource.com/c/1450235
Commit-Queue: Aaron Leventhal <[email protected]>
Reviewed-by: Nektarios Paisios <[email protected]>
Cr-Commit-Position: refs/heads/master@{#628890} | 6a310d99a741f9ba5e4e537c5ec49d3adbe5876f | chrome | bigvul | 1 | null | null | null |
Roll PDFium 32e693f..135b998
https://pdfium.googlesource.com/pdfium.git/+log/32e693f..135b998
BUG=628304,628890
[email protected]
Review-Url: https://codereview.chromium.org/2223573002
Cr-Commit-Position: refs/heads/master@{#410182} | 2b7d329e0a69e97cd3dc2bf267fb96e40a7880a4 | chrome | bigvul | 1 | null | null | null |
[Mfill Android] Rename Action in accessory to BarItem
This CL shouldn't change any behavior or appearance at all.
The name action is generic and slightly misleading as it gives the
impression that every item in the accessory bar maps to a native,
recorded action.
This is not entirely true as the items in the bar can actually differ
from these which becomes more clear in https://crrev.com/c/1407194 when
bar items like the tab switchers make their debut.
Minor non-functional linter errors are fixed while touching these files.
Bug: None
Change-Id: I3f4484df440c5b8c7d399ebdd133c5c67bb071ab
Reviewed-on: https://chromium-review.googlesource.com/c/1406978
Commit-Queue: Friedrich [CET] <[email protected]>
Reviewed-by: Theresa <[email protected]>
Reviewed-by: Ioana Pandele <[email protected]>
Cr-Commit-Position: refs/heads/master@{#622420} | 63555be051ee1f8471c63a4bcafcc6c4904667c4 | chrome | bigvul | 1 | null | null | null |
[iOS] Defer removing empty sections until editing is stopped.
The swipe to delete gesture for UITableView will throw an exception if
the deleted row's section is removed before the animation finishes.
This CL updates ReadingListTableViewController to defer removing empty
sections until self.tableView.editing is reset to NO at the end of the
swipe animation.
Bug: 877425, 877423
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I74e29b761fc8458e8bb9a6dbe643a73b00a8b9a4
Reviewed-on: https://chromium-review.googlesource.com/1198104
Reviewed-by: Olivier Robin <[email protected]>
Commit-Queue: Kurt Horimoto <[email protected]>
Cr-Commit-Position: refs/heads/master@{#589237} | 3133b88a72c61683057d7b1970f68d15b67c0c17 | chrome | bigvul | 1 | null | null | null |
Android omnibox: Force paragraph direction to LTR.
This means that URLs will always be displayed in a left-to-right
context. Right-to-left runs are still rendered as RTL, but will not
cause the whole URL to flip around.
This fixes several spoofing concerns and makes Android's omnibox
consistent with the Views omnibox.
BUG=609680
Review-Url: https://codereview.chromium.org/1988553002
Cr-Commit-Position: refs/heads/master@{#400359} | 3bd33fee094e863e5496ac24714c558bd58d28ef | chrome | bigvul | 1 | null | null | null |
[DevTools] Copy objects from debugger context to inspected context properly.
BUG=637594
Review-Url: https://codereview.chromium.org/2253643002
Cr-Commit-Position: refs/heads/master@{#412436} | 93bc623489bdcfc7e9127614fcfb3258edf3f0f9 | chrome | bigvul | 1 | null | null | null |
Add CPU metrics provider and Add CPU/GPU provider for UKM.
Bug: 907674
Change-Id: I61b88aeac8d2a7ff81d812fa5a267f48203ec7e2
Reviewed-on: https://chromium-review.googlesource.com/c/1381376
Commit-Queue: Nik Bhagat <[email protected]>
Reviewed-by: Robert Kaplow <[email protected]>
Cr-Commit-Position: refs/heads/master@{#618037} | 19b8593007150b9a78da7d13f6e5f8feb10881a7 | chrome | bigvul | 1 | null | null | null |
[Android WebAPK] Send share target information in WebAPK updates
This CL plumbs through share target information for WebAPK updates.
Chromium detects Web Manifest updates (including Web Manifest share
target updates) and requests an update.
Currently, depending on whether the Web Manifest is for an intranet
site, the updated WebAPK would either:
- no longer be able handle share intents (even if the Web Manifest
share target information was not deleted)
- be created with the same share intent handlers as the current WebAPK
(regardless of whether the Web Manifest share target information has
changed).
This CL plumbs through the share target information from
WebApkUpdateDataFetcher#onDataAvailable() to
WebApkUpdateManager::StoreWebApkUpdateRequestToFile()
BUG=912945
Change-Id: Ie416570533abc848eeb23de8c197b44f2a1fd028
Reviewed-on: https://chromium-review.googlesource.com/c/1369709
Commit-Queue: Peter Kotwicz <[email protected]>
Reviewed-by: Dominick Ng <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616429} | 5da127a872b1e2c9fb1cf128ae309b4d6ce4e3ce | chrome | bigvul | 1 | null | null | null |
Disable IframeNavigateToInaccessible test on Site Isolation FYI bots.
BUG=576867
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
Review-Url: https://codereview.chromium.org/2026163002
Cr-Commit-Position: refs/heads/master@{#397068} | a4a128d5c500528e70139c14c51bb326fe357746 | chrome | bigvul | 1 | null | null | null |
Changing scrim color when the box is focused
Bug: 934465
Change-Id: I2147c3c8a4a6a68f6f8382b320c1cf61ac8758ca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531726
Reviewed-by: Theresa <[email protected]>
Reviewed-by: Becky Zhou <[email protected]>
Commit-Queue: Sinan Sahin <[email protected]>
Cr-Commit-Position: refs/heads/master@{#642598} | b1d432f84225c1c809f3d9eecba24727068a1b37 | chrome | bigvul | 1 | null | null | null |
Blink-in-JS should not run micro tasks
If Blink-in-JS runs micro tasks, there's a risk of causing a UXSS bug
(see 645211 for concrete steps).
This CL makes Blink-in-JS use callInternalFunction (instead of callFunction)
to avoid running micro tasks after Blink-in-JS' callbacks.
BUG=645211
Review-Url: https://codereview.chromium.org/2330843002
Cr-Commit-Position: refs/heads/master@{#417874} | 0a242b6c8a66ee530d5b68c74dfabe74e6415d45 | chrome | bigvul | 1 | null | null | null |
[AF] Prevent Logging Password Values to Console
Before sending over to be logged by DevTools, filter out DOM nodes that
have a type attribute equal to "password", and that are not empty.
Bug: 934609
Change-Id: I147ad0c2bad13cc50394f4b5ff2f4bfb7293114b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506498
Commit-Queue: Sebastien Lalancette <[email protected]>
Reviewed-by: Vadym Doroshenko <[email protected]>
Reviewed-by: Mathieu Perreault <[email protected]>
Cr-Commit-Position: refs/heads/master@{#638615} | 89f296b34f4f33e048848c06da08fc9271b30bc9 | chrome | bigvul | 1 | null | null | null |
Refactor the AppController implementation into a KeyedService.
This is necessary to guarantee that the AppController will not outlive
the AppServiceProxy, which could happen before during Profile destruction.
Bug: 945427
Change-Id: I9e2089799e38d5a70a4a9aa66df5319113e7809e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542336
Reviewed-by: Michael Giuffrida <[email protected]>
Commit-Queue: Lucas Tenório <[email protected]>
Cr-Commit-Position: refs/heads/master@{#645122} | 8cfe2463cec6835c7b0b73dcb2ab2edaf035e3f9 | chrome | bigvul | 1 | null | null | null |
Roll PDFium d8cc503..6f10254
https://pdfium.googlesource.com/pdfium.git/+log/d8cc503..6f10254
BUG=630654
[email protected]
Review-Url: https://codereview.chromium.org/2190853004
Cr-Commit-Position: refs/heads/master@{#408419} | 436bf1c042b07d2fee38c430de5232b7b5d688e6 | chrome | bigvul | 1 | null | null | null |
[Autofill] Remove AutofillPopupViewViews and associated feature.
Bug: 906135,831603
Change-Id: I3c982f8b3ffb4928c7c878e74e10113999106499
Reviewed-on: https://chromium-review.googlesource.com/c/1387124
Reviewed-by: Robert Kaplow <[email protected]>
Reviewed-by: Vasilii Sukhanov <[email protected]>
Reviewed-by: Fabio Tirelo <[email protected]>
Reviewed-by: Tommy Martino <[email protected]>
Commit-Queue: Mathieu Perreault <[email protected]>
Cr-Commit-Position: refs/heads/master@{#621360} | f2d26633cbd50735ac2af30436888b71ac0abad3 | chrome | bigvul | 1 | null | null | null |
Convert Uses of base::RepeatingCallback<>::Equals to Use == or != in //base
Staging this change because some conversions will have semantic changes.
BUG=937566
Change-Id: I2d4950624c0fab00e107814421a161e43da965cc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507245
Reviewed-by: Gabriel Charette <[email protected]>
Commit-Queue: Gabriel Charette <[email protected]>
Cr-Commit-Position: refs/heads/master@{#639702} | 4e4c9b553ae124ed9bb60356e2ecff9106abddd0 | chrome | bigvul | 1 | null | null | null |
WebUI[MD-refresh]: replace paper-input with cr-input in cert-manager elements.
Bug: 832177
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Iac35742ffba55c0645a67f6a84813643076bd0e7
Reviewed-on: https://chromium-review.googlesource.com/1090003
Commit-Queue: Scott Chen <[email protected]>
Reviewed-by: Demetrios Papadopoulos <[email protected]>
Cr-Commit-Position: refs/heads/master@{#565760} | 34e6c6afd8c6242e9a094782e739743da471e75a | chrome | bigvul | 1 | null | null | null |
Check CORS policy on redirect in TextTrackLoader
BUG=633885
TEST=new case in http/tests/security/text-track-crossorigin.html
Review-Url: https://codereview.chromium.org/2367583002
Cr-Commit-Position: refs/heads/master@{#421919} | e99cc8e5a48ff4978d401c48a64f06649f647f3f | chrome | bigvul | 1 | null | null | null |
[GCPW] Disallow sign in of consumer accounts when mdm is enabled.
Unless the registry key "mdm_aca" is explicitly set to 1, always
fail sign in of consumer accounts when mdm enrollment is enabled.
Consumer accounts are defined as accounts with gmail.com or
googlemail.com domain.
Bug: 944049
Change-Id: Icb822f3737d90931de16a8d3317616dd2b159edd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1532903
Commit-Queue: Tien Mai <[email protected]>
Reviewed-by: Roger Tawa <[email protected]>
Cr-Commit-Position: refs/heads/master@{#646278} | 2440e872debd68ae7c2a8bf9ddb34df2cce378cd | chrome | bigvul | 1 | null | null | null |
Update reopen tab in-product help histogram expiry
We are tentatively aiming for a M75 full stable launch. Bumping the
expiry to M76 will allow us to still get data from Canary/Dev after
M75 branch.
Bug: 945576, 887991
Change-Id: I35cd8c4d55a20bf724a5e532607c8d3f4a83ea47
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539136
Auto-Submit: Collin Baker <[email protected]>
Reviewed-by: Jesse Doherty <[email protected]>
Commit-Queue: Jesse Doherty <[email protected]>
Cr-Commit-Position: refs/heads/master@{#644963} | bde99319fc83e96d6e3258f04c33b4a3e633a70c | chrome | bigvul | 1 | null | null | null |
Prevent interpretating userinfo as url scheme when editing bookmarks
Chrome's Edit Bookmark dialog formats urls for display such that a
url of http://javascript:[email protected] is later converted to a
javascript url scheme, allowing persistence of a script injection
attack within the user's bookmarks.
This fix prevents such misinterpretations by always showing the
scheme when a userinfo component is present within the url.
BUG=639126
Review-Url: https://codereview.chromium.org/2368593002
Cr-Commit-Position: refs/heads/master@{#422467} | fa34e547d6ee25ea0692436ba7462ed0a0ef45f4 | chrome | bigvul | 1 | null | null | null |
Improve Type @IntDef
Before CL: @IntDef was declaring COUNT inside @IntDef (as one of values) and this is different from other @IntDef (they use NUM_ENTRIES outside @IntDef)
After CL: COUNT/NUM_ENTRIES is removed at all because is not required at all
BUG=919666
Change-Id: I31eb7afffe7d95632142d0fbe2728dd7b590101e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1512635
Commit-Queue: Marcin Wiącek <[email protected]>
Reviewed-by: Friedrich [CET] <[email protected]>
Cr-Commit-Position: refs/heads/master@{#639658} | 95f564731a0379ed01a04775140730ef0d462ff9 | chrome | bigvul | 1 | null | null | null |
Clear Shill stub config in offline file manager tests
The Shill stub client fakes ethernet and wifi connections during
testing. Clear its config during offline tests to simulate a lack of
network connectivity.
As a side effect, fileManagerPrivate.getDriveConnectionState will no
longer need to be stubbed out, as it will now think the device is
offline and return the appropriate result.
Bug: 925272
Change-Id: Idd6cb44325cfde4991d3b1e64185a28e8655c733
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578149
Commit-Queue: Austin Tankiang <[email protected]>
Reviewed-by: Sam McNally <[email protected]>
Cr-Commit-Position: refs/heads/master@{#654782} | d4e0a7273cd8d7a9ee667ad5b5c8aad0f5f59251 | chrome | bigvul | 1 | null | null | null |
Extract generation logic from the accessory controller into a separate one
This change adds a controller that is responsible for mediating
communication between ChromePasswordManagerClient and
PasswordAccessoryController for password generation. It is also
responsible for managing the modal dialog used to present the generated
password.
In the future it will make it easier to add manual generation to the
password accessory.
Bug: 845458
Change-Id: I0adbb2de9b9f5012745ae3963154f7d3247b3051
Reviewed-on: https://chromium-review.googlesource.com/c/1448181
Commit-Queue: Ioana Pandele <[email protected]>
Reviewed-by: Fabio Tirelo <[email protected]>
Reviewed-by: Vasilii Sukhanov <[email protected]>
Reviewed-by: Friedrich [CET] <[email protected]>
Cr-Commit-Position: refs/heads/master@{#629542} | 961d0cda4cfc3bcf04aa48ccc32772d63af12d9b | chrome | bigvul | 1 | null | null | null |
[s13n] Move account_consistency_method.cc/h files to 'shared' target
This CL moves account_consistency_method.cc/h from the signin
component's 'internals' GN target to its 'shared' GN target as
it has only an enum.
Bug: 925345
Change-Id: I10873fba052a879d53f373b7b905c0aa4d472bc2
Reviewed-on: https://chromium-review.googlesource.com/c/1442039
Reviewed-by: Colin Blundell <[email protected]>
Reviewed-by: David Roger <[email protected]>
Commit-Queue: Julie Jeongeun Kim <[email protected]>
Cr-Commit-Position: refs/heads/master@{#626948} | 184f81c73eaa33c8719e1f683ccd02c9e4249ccd | chrome | bigvul | 1 | null | null | null |
Roll PDFium cfb31d6..2f6d148
https://pdfium.googlesource.com/pdfium.git/+log/cfb31d6..2f6d148
BUG=625541,625823
Review-Url: https://codereview.chromium.org/2128163002
Cr-Commit-Position: refs/heads/master@{#404047} | 95adc31201fd4d1f3b9ec96a62993e64d3273ed9 | chrome | bigvul | 1 | null | null | null |
Roll PDFium 2fad11a..df6ec80
https://pdfium.googlesource.com/pdfium.git/+log/2fad11a..df6ec80
BUG=612918,619405,621094
[email protected]
Review-Url: https://codereview.chromium.org/2078383003
Cr-Commit-Position: refs/heads/master@{#400811} | f7014ec458435b22a73f4a085e50764444351ee9 | chrome | bigvul | 1 | null | null | null |
Run `xcrun simctl erase all` to fix DVTCoreSimulatorAdditionsErrorDomain error
for xcodebuild runner.
Bug: 922290
Change-Id: I13611f4a5840d3fb6f1e9dd685396695f9a5a2a3
Reviewed-on: https://chromium-review.googlesource.com/c/1413596
Reviewed-by: Sergey Berezin <[email protected]>
Reviewed-by: Justin Cohen <[email protected]>
Commit-Queue: Maksym Onufriienko <[email protected]>
Cr-Commit-Position: refs/heads/master@{#623406} | 9a93acf4adfbe03a7a0cf5b27275835fe14c7412 | chrome | bigvul | 1 | null | null | null |
Use base::size rather than arraysize in third_party/zlib/.
This is purely a mechanical change; there is no intended behavior change.
BUG=837308
[email protected]
Change-Id: I1d226c45e473949a8af47311a6e089e5d9df10b4
Reviewed-on: https://chromium-review.googlesource.com/c/1392748
Commit-Queue: Adam Langley <[email protected]>
Reviewed-by: Adam Langley <[email protected]>
Cr-Commit-Position: refs/heads/master@{#619414} | 7707f82395be87ca3524151c26d3dd2569fec043 | chrome | bigvul | 1 | null | null | null |
[DevTools] Whitelist remoteFrontendUrl and remoteBase params.
This also fixes loadScriptsPromise to not normalize hostname.
BUG=619414,618333
Review-Url: https://codereview.chromium.org/2065823004
Cr-Commit-Position: refs/heads/master@{#400768} | 554517a4587bfb0071bcd3c7eff6645a0b06d72a | chrome | bigvul | 1 | null | null | null |
[Files app] Fix open new window command
Change background page |launcher| namesspace to use var instead of const
to be accessible in the foreground page.
Test: --gtest_filter="KeyboardOperations/FilesAppBrowserTest.Test/keyboardOpenNewWindow*"
Bug: 933302
Change-Id: I6e8cec2fd96034d8376fb247743adf1818c00adf
Reviewed-on: https://chromium-review.googlesource.com/c/1477469
Commit-Queue: Luciano Pacheco <[email protected]>
Commit-Queue: Noel Gordon <[email protected]>
Auto-Submit: Luciano Pacheco <[email protected]>
Reviewed-by: Noel Gordon <[email protected]>
Cr-Commit-Position: refs/heads/master@{#633486} | 0846dce02d4c3b01af714efa70d144eb2ed0d7a9 | chrome | bigvul | 1 | null | null | null |
CrOS Shelf: Get rid of 'split view' mode for shelf background
In the new UI, "maximized" and "split view" are treated the same in
specs, so there is no more need for a separate "split view" mode. This
folds it into the "maximized" mode.
Note that the only thing that _seems_ different in
shelf_background_animator is ShelfBackgroundAnimator::kMaxAlpha (255)
vs kShelfTranslucentMaximizedWindow (254), which should be virtually
impossible to distinguish.
This CL therefore does not have any visual effect (and doesn't
directly fix the linked bug, but is relevant).
Bug: 899289
Change-Id: I60947338176ac15ca016b1ba4edf13d16362cb24
Reviewed-on: https://chromium-review.googlesource.com/c/1469741
Commit-Queue: Xiyuan Xia <[email protected]>
Reviewed-by: Xiyuan Xia <[email protected]>
Auto-Submit: Manu Cornet <[email protected]>
Cr-Commit-Position: refs/heads/master@{#631752} | f2f703241635fa96fa630b83afcc9a330cc21b7e | chrome | bigvul | 1 | null | null | null |
Log the presence of crash reports after running Chrome.
BUG=907979
Change-Id: I8922218a0488eee539a5f3814de3dee9c58e31e0
Reviewed-on: https://chromium-review.googlesource.com/c/1349339
Commit-Queue: Greg Thompson <[email protected]>
Reviewed-by: Roger Tawa <[email protected]>
Cr-Commit-Position: refs/heads/master@{#610600} | 201cbd50bae564e407a5c40f1c35fa92ff55453b | chrome | bigvul | 1 | null | null | null |
[ios] Do not commit invalid URLs during web load.
BUG=622183
Review-Url: https://codereview.chromium.org/2086333003
Cr-Commit-Position: refs/heads/master@{#401761} | c2d2b0f2f74dad0bdef196cf1657f0d584cbe3a7 | chrome | bigvul | 1 | null | null | null |
[Extensions] Rework inline installation observation
Instead of observing through the WebstoreAPI, observe directly in the TabHelper.
This is a great deal less code, more direct, and also fixes a lifetime issue
with the TabHelper being deleted before the inline installation completes.
BUG=613949
Review-Url: https://codereview.chromium.org/2103663002
Cr-Commit-Position: refs/heads/master@{#403188} | d30a8bd191f17b61938fc87890bffc80049b0774 | chrome | bigvul | 1 | null | null | null |
Roll DEPS for sfntly to 468cad5.
[email protected]
BUG=614934
Review-Url: https://codereview.chromium.org/2060023003
Cr-Commit-Position: refs/heads/master@{#399363} | e40502b71c9bd4f548118550952afd5d6a158bc4 | chrome | bigvul | 1 | null | null | null |
[LayoutNG] A few small cleanups in flex code
- Don't use legacy when we don't have to
- Store NGBlockNode instead of NGLayoutInputNode
Bug: 845235
Change-Id: I99e48f7f69e4f53f0391e2cd542e117b501cb7d6
Reviewed-on: https://chromium-review.googlesource.com/c/1379061
Reviewed-by: Christian Biesinger <[email protected]>
Commit-Queue: David Grogan <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616907} | 69ec52bd0b32622770a25952386596ccb4ad6434 | chrome | bigvul | 1 | null | null | null |
Always use FrameNavigationDisabler during DocumentLoader detach.
BUG=617495
Review-Url: https://codereview.chromium.org/2079473002
Cr-Commit-Position: refs/heads/master@{#400558} | be655fd4fb9ab3291a855a939496111674037a2f | chrome | bigvul | 1 | null | null | null |
Add proto fields for new telemetry data
Bug: 916991
Change-Id: Ie7287aeb9c7acc421a82188b0a08dc991343bd76
Reviewed-on: https://chromium-review.googlesource.com/c/1386850
Commit-Queue: Denis Kuznetsov <[email protected]>
Reviewed-by: Julian Pastarmov <[email protected]>
Cr-Commit-Position: refs/heads/master@{#618237} | 20b480d9089200edbb437b8cdc80b1f0f81421f0 | chrome | bigvul | 1 | null | null | null |
Only access a plugin's scriptable object, and not also its prototype chain
BUG=chromium:619166
[email protected]
Review-Url: https://codereview.chromium.org/2084183004
Cr-Commit-Position: refs/heads/master@{#401579} | dbbdebecc3416092a833f8ac14a849500be8a2eb | chrome | bigvul | 1 | null | null | null |
WebBluetooth tests should be owned by content/browser/bluetooth OWNERS
Bug: None
Change-Id: I77b07c01393b54da1fa406eb9908573a104cac60
Reviewed-on: https://chromium-review.googlesource.com/c/1398293
Reviewed-by: Reilly Grant <[email protected]>
Reviewed-by: Robert Ma <[email protected]>
Commit-Queue: Doug Turner <[email protected]>
Cr-Commit-Position: refs/heads/master@{#620553} | 9c654d15a42633537cbf3a9bcc8ba39015893f83 | chrome | bigvul | 1 | null | null | null |
Support pausing media when a context is frozen.
Media is resumed when the context is unpaused. This feature will be used
for bfcache and pausing iframes feature policy.
BUG=907125
Change-Id: Ic3925ea1a4544242b7bf0b9ad8c9cb9f63976bbd
Reviewed-on: https://chromium-review.googlesource.com/c/1410126
Commit-Queue: Dave Tapuska <[email protected]>
Reviewed-by: Kentaro Hara <[email protected]>
Reviewed-by: Mounir Lamouri <[email protected]>
Cr-Commit-Position: refs/heads/master@{#623319} | 3a353ebdb7753a3fbeb401c4c0e0f3358ccbb90b | chrome | bigvul | 1 | null | null | null |
[Cronet] Add info and status to correlate UrlRequestInfo to requests.
Bug: 879208
Change-Id: Ic76e31d1430e6800b1302c3cfb7a8baa76b4643f
Reviewed-on: https://chromium-review.googlesource.com/c/1399054
Commit-Queue: Caleb Raitto <[email protected]>
Reviewed-by: Paul Jensen <[email protected]>
Reviewed-by: Misha Efimov <[email protected]>
Cr-Commit-Position: refs/heads/master@{#623378} | f3463c78b77bc4cefd8e748c4f47a2324515ad47 | chrome | bigvul | 1 | null | null | null |
Remove WebFrame::canHaveSecureChild
To simplify the public API, ServiceWorkerNetworkProvider can do the
parent walk itself.
Follow-up to https://crrev.com/ad1850962644e19.
BUG=607543
Review-Url: https://codereview.chromium.org/2082493002
Cr-Commit-Position: refs/heads/master@{#400896} | 8353baf8d1504dbdd4ad7584ff2466de657521cd | chrome | bigvul | 1 | null | null | null |
Add fuzzing OWNERS as OWNERS of //base/test/*fuzzed_data_provider*.
Bug: 907103
Change-Id: I279bae0438ca9346e74de294d1a1a15a32d4fbec
Reviewed-on: https://chromium-review.googlesource.com/c/1357007
Reviewed-by: Abhishek Arya <[email protected]>
Reviewed-by: Lei Zhang <[email protected]>
Commit-Queue: Abhishek Arya <[email protected]>
Cr-Commit-Position: refs/heads/master@{#613626} | 77ce157f5f3a43c6e7d78e37d778335b5d393c6b | chrome | bigvul | 1 | null | null | null |
Add a histogram (Net.PacResultForStrippedUrl) that estimates how often PAC scripts depend on the URL path.
BUG=593759
Review URL: https://codereview.chromium.org/1797313003
Cr-Commit-Position: refs/heads/master@{#382644} | 183f4bcddd821b4af3f6234ad2e8c371694a9ffb | chrome | bigvul | 1 | null | null | null |
Use document referrer policy when preloading
Previously, preload requests used the referrer policy from meta tags
encountered during scanning, but not from headers delivered with the
page. This CL uses the document's current referrer policy when the
preload scan starts.
BUG=605451
Review-Url: https://codereview.chromium.org/1913983002
Cr-Commit-Position: refs/heads/master@{#390264} | e49d943e9f5f90411313e64d0ae6b646edc85043 | chrome | bigvul | 1 | null | null | null |
Automated Commit: LKGM 11631.0.0 for chromeos.
BUG=762641
[email protected]
Change-Id: Ia4ebed15d53163eace05eaa2997a8111e9f0a6ff
Reviewed-on: https://chromium-review.googlesource.com/c/1429199
Reviewed-by: ChromeOS bot <[email protected]>
Commit-Queue: Ben Pastene <[email protected]>
Cr-Commit-Position: refs/heads/master@{#625393} | 4793abd38544dfc631d694b6eb1a393af15a720c | chrome | bigvul | 1 | null | null | null |
[Explore sites]: Update error page text to be more compliant
Bug: 916771
Change-Id: Ibd0e487410fe5f0c839a3e76582caab8ccf15fe3
Reviewed-on: https://chromium-review.googlesource.com/c/1435474
Auto-Submit: Cathy Li <[email protected]>
Reviewed-by: Peter Williamson <[email protected]>
Commit-Queue: Peter Williamson <[email protected]>
Cr-Commit-Position: refs/heads/master@{#625945} | 87c716d472a3183fd00692378a5ff93dcae1f303 | chrome | bigvul | 1 | null | null | null |
gpu/android : Add support for partial swap with surface control.
Add support for PostSubBuffer to GLSurfaceEGLSurfaceControl. This should
allow the display compositor to draw the minimum sub-rect necessary from
the damage tracking in BufferQueue on the client-side, and also to pass
this damage rect to the framework.
[email protected]
Bug: 926020
Change-Id: I73d3320cab68250d4c6865bf21c5531682d8bf61
Reviewed-on: https://chromium-review.googlesource.com/c/1457467
Commit-Queue: Khushal <[email protected]>
Commit-Queue: Antoine Labour <[email protected]>
Reviewed-by: Antoine Labour <[email protected]>
Auto-Submit: Khushal <[email protected]>
Cr-Commit-Position: refs/heads/master@{#629852} | 4afb628e068367d5b73440537555902cd12416f8 | chrome | bigvul | 1 | null | null | null |
OomIntervention opt-out should work properly with 'show original'
OomIntervention should not be re-triggered on the same page if the user declines the intervention once.
This CL fixes the bug.
Bug: 889131, 887119
Change-Id: Idb9eebb2bb9f79756b63f0e010fe018ba5c490e8
Reviewed-on: https://chromium-review.googlesource.com/1245019
Commit-Queue: Yuzu Saijo <[email protected]>
Reviewed-by: Kentaro Hara <[email protected]>
Cr-Commit-Position: refs/heads/master@{#594574} | 84fbaf8414b4911ef122557d1518b50f79c2eaef | chrome | bigvul | 1 | null | null | null |
Check that RWHI isn't deleted manually while owned by a scoped_ptr in RVHI
BUG=590284
Review URL: https://codereview.chromium.org/1747183002
Cr-Commit-Position: refs/heads/master@{#378844} | e5787005a9004d7be289cc649c6ae4f3051996cd | chrome | bigvul | 1 | null | null | null |
Cache csi info before passing it to JS setters.
JS setters invalidate the pointers frame, data_source and document_state.
BUG=590455
Review URL: https://codereview.chromium.org/1751553002
Cr-Commit-Position: refs/heads/master@{#379047} | 9d92ff158726601ae5c044d62050614f076eaae4 | chrome | bigvul | 1 | null | null | null |
Roll ANGLE 00f394e..0c0d800
https://chromium.googlesource.com/angle/angle.git/+log/00f394e..0c0d800
BUG=593448,598944,595836,590870
[email protected]
TEST=bots
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.linux:linux_optional_gpu_tests_rel
Review URL: https://codereview.chromium.org/1849013003
Cr-Commit-Position: refs/heads/master@{#384777} | 6a5b73fc8615892260d6f47242d1d6a642e3dcfc | chrome | bigvul | 1 | null | null | null |
Roll src/third_party/webrtc 343f4144bee5..38537edf5979 (1 commits)
https://webrtc.googlesource.com/src.git/+log/343f4144bee5..38537edf5979
git log 343f4144bee5..38537edf5979 --date=short --no-merges --format='%ad %ae %s'
2018-10-08 [email protected] Fix visibility of api/units build targets.
Created with:
gclient setdep -r src/third_party/webrtc@38537edf5979
The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng
BUG=chromium:None
[email protected]
Change-Id: Iae03139a2686a23b284608af3602b3ff46892282
Reviewed-on: https://chromium-review.googlesource.com/c/1267682
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/master@{#597518} | b2965f7024948cf814df76803c3579b883da3095 | chrome | bigvul | 1 | null | null | null |
Fix content_shell with network service enabled not loading pages.
This regressed in my earlier cl r528763.
This is a reland of r547221.
Bug: 833612
Change-Id: I4c2649414d42773f2530e1abe5912a04fcd0ed9b
Reviewed-on: https://chromium-review.googlesource.com/1064702
Reviewed-by: Jay Civelli <[email protected]>
Commit-Queue: John Abd-El-Malek <[email protected]>
Cr-Commit-Position: refs/heads/master@{#560011} | 925dad6467cd7a2b79322378eafa43d06371b081 | chrome | bigvul | 1 | null | null | null |
Fix PPB_Flash_MessageLoop.
This CL suspends script callbacks and resource loads while running nested message loop using PPB_Flash_MessageLoop.
BUG=569496
Review URL: https://codereview.chromium.org/1559113002
Cr-Commit-Position: refs/heads/master@{#374529} | dd77c2a41c72589d929db0592565125ca629fb2c | chrome | bigvul | 1 | null | null | null |
Remove UMA.CreatePersistentHistogram.Result
This histogram isn't showing anything meaningful and the problems it
could show are better observed by looking at the allocators directly.
Bug: 831013
Change-Id: Ibe968597758230192e53a7675e7390e968c9e5b9
Reviewed-on: https://chromium-review.googlesource.com/1008047
Commit-Queue: Brian White <[email protected]>
Reviewed-by: Alexei Svitkine <[email protected]>
Cr-Commit-Position: refs/heads/master@{#549986} | 3f38b2253b19f9f9595f79fb92bfb5077e7b1959 | chrome | bigvul | 1 | null | null | null |
Fix detached Attr nodes interaction with NodeIterator
- Don't register NodeIterator to document when attaching to Attr node.
-- NodeIterator is registered to its document to receive updateForNodeRemoval notifications.
-- However it wouldn't make sense on Attr nodes, as they never have children.
BUG=572537
Review URL: https://codereview.chromium.org/1577213003
Cr-Commit-Position: refs/heads/master@{#369687} | eb750a539e4856ba9042abdf39ae9da58fa3ae63 | chrome | bigvul | 1 | null | null | null |
gfx: Add GpuFence::Wait() method
Provide a GpuFence::Wait() method to hide the implementation details of
waiting for a GpuFence object.
Bug: 828393
Change-Id: I2153ebcb4b8cca6bb43c827fb0a9740f6a6cc221
Reviewed-on: https://chromium-review.googlesource.com/1021513
Reviewed-by: David Reveman <[email protected]>
Reviewed-by: Antoine Labour <[email protected]>
Commit-Queue: Daniele Castagna <[email protected]>
Cr-Commit-Position: refs/heads/master@{#559292} | 922160eddcb34ca26c834c2a0b0e65269358f0bf | chrome | bigvul | 1 | null | null | null |
Fix re-entrancy and lifetime issue in RenderFrameObserverNatives::OnDocumentElementCreated
BUG=585268,568130
Review URL: https://codereview.chromium.org/1684953002
Cr-Commit-Position: refs/heads/master@{#374758} | 5a15b72a270b514cd442872221a788a303bdaa88 | chrome | bigvul | 1 | null | null | null |
[fuchsia] Implement browser tests for WebRunner Context service.
Tests may interact with the WebRunner FIDL services and the underlying
browser objects for end to end testing of service and browser
functionality.
* Add a browser test launcher main() for WebRunner.
* Add some simple navigation tests.
* Wire up GoBack()/GoForward() FIDL calls.
* Add embedded test server resources and initialization logic.
* Add missing deletion & notification calls to BrowserContext dtor.
* Use FIDL events for navigation state changes.
* Bug fixes:
** Move BrowserContext and Screen deletion to PostMainMessageLoopRun(),
so that they may use the MessageLoop during teardown.
** Fix Frame dtor to allow for null WindowTreeHosts (headless case)
** Fix std::move logic in Frame ctor which lead to no WebContents
observer being registered.
Bug: 871594
Change-Id: I36bcbd2436d534d366c6be4eeb54b9f9feadd1ac
Reviewed-on: https://chromium-review.googlesource.com/1164539
Commit-Queue: Kevin Marshall <[email protected]>
Reviewed-by: Wez <[email protected]>
Reviewed-by: Fabrice de Gans-Riberi <[email protected]>
Reviewed-by: Scott Violet <[email protected]>
Cr-Commit-Position: refs/heads/master@{#584155} | 6a60f01228557982e6508c5919cc21fcfddf110b | chrome | bigvul | 1 | null | null | null |
third_party/libpng: update to 1.2.54
[email protected]
BUG=560291
Review URL: https://codereview.chromium.org/1467263003
Cr-Commit-Position: refs/heads/master@{#362298} | 7f3d85b096f66870a15b37c2f40b219b2e292693 | chrome | bigvul | 1 | null | null | null |
[ChromeDriver] Re-enable Java goBack/goForward tests
The following two Java tests no longer appear to be flaky:
PageLoadingTest.testShouldBeAbleToNavigateBackInTheBrowserHistoryInPresenceOfIframes
PageLoadingTest.testShouldBeAbleToNavigateBackInTheBrowserHistory
Bug: chromedriver:653
Change-Id: Iaa0f991a2a3ee785a7505da77e82738622857950
Reviewed-on: https://chromium-review.googlesource.com/1040307
Reviewed-by: Jonathon Kereliuk <[email protected]>
Commit-Queue: John Chen <[email protected]>
Cr-Commit-Position: refs/heads/master@{#555544} | dd3d87d399131dccd5586d33a5bcaeac25b49951 | chrome | bigvul | 1 | null | null | null |
[VK] Enable virtual keyboard UKM by default on M70.
Launch was approved.
Bug: 752657
Change-Id: I01ac04040b8b928c27512d203667dda234588153
Reviewed-on: https://chromium-review.googlesource.com/1184659
Reviewed-by: Scott Violet <[email protected]>
Commit-Queue: Darren Shen <[email protected]>
Cr-Commit-Position: refs/heads/master@{#585282} | 4a7b10c29d7b0e477a43448d1462178f95c891f9 | chrome | bigvul | 1 | null | null | null |
cros: Check initial auth type when showing views login.
Bug: 859611
Change-Id: I0298db9bbf4aed6bd40600aef2e1c5794e8cd058
Reviewed-on: https://chromium-review.googlesource.com/1123056
Reviewed-by: Xiaoyin Hu <[email protected]>
Commit-Queue: Jacob Dufault <[email protected]>
Cr-Commit-Position: refs/heads/master@{#572224} | c66b1fc49870c514b1c1e8b53498153176d7ec2b | chrome | bigvul | 1 | null | null | null |
Make the webstore inline install dialog be tab-modal
Also clean up a few minor lint errors while I'm in here.
BUG=550047
Review URL: https://codereview.chromium.org/1496033003
Cr-Commit-Position: refs/heads/master@{#363925} | 0a1c15fecb1240ab909e1431b6127410c3b380e0 | chrome | bigvul | 1 | null | null | null |
Don't call WebContents::DownloadImage() callback if the WebContents were deleted
BUG=583718
Review URL: https://codereview.chromium.org/1685343004
Cr-Commit-Position: refs/heads/master@{#375700} | 75ca8ffd7bd7c58ace1144df05e1307d8d707662 | chrome | bigvul | 1 | null | null | null |
Blacklist KeyboardOverlayUIBrowserTest on mash
Blacklist this flaky test for single_process_mash_browser_test.
Keyboard overlay is slated to be removed soon.
Bug: 884216
Test: verify filter file locally
Change-Id: I48c7cc0de3648c9a5445d502f3fe08f436631605
Reviewed-on: https://chromium-review.googlesource.com/1227139
Reviewed-by: James Cook <[email protected]>
Reviewed-by: Ben Pastene <[email protected]>
Commit-Queue: Vladislav Kaznacheev <[email protected]>
Cr-Commit-Position: refs/heads/master@{#591402} | 1a223b59d41262c061121f7281b47abe4012a939 | chrome | bigvul | 1 | null | null | null |
Change ReadWriteLock to Lock+ConditionVariable in TaskService
There are non-trivial performance implications of using shared
SRWLocking on Windows as more state has to be checked.
Since there are only two uses of the ReadWriteLock in Chromium after
over 1 year, the decision is to remove it.
BUG=758721
Change-Id: I84d1987d7b624a89e896eb37184ee50845c39d80
Reviewed-on: https://chromium-review.googlesource.com/634423
Commit-Queue: Robert Liao <[email protected]>
Reviewed-by: Takashi Toyoshima <[email protected]>
Reviewed-by: Francois Doray <[email protected]>
Cr-Commit-Position: refs/heads/master@{#497632} | 94fef6e2a56ef5b3ed0dc0fd94e6ad52267067fb | chrome | bigvul | 1 | null | null | null |
Connect the LocalDB to TabManager.
Bug: 773382
Change-Id: Iec8fe5226ee175105d51f300f30b4865478ac099
Reviewed-on: https://chromium-review.googlesource.com/1118611
Commit-Queue: Sébastien Marchand <[email protected]>
Reviewed-by: François Doray <[email protected]>
Cr-Commit-Position: refs/heads/master@{#572871} | 7394cf6f43d7a86630d3eb1c728fd63c621b5530 | chrome | bigvul | 1 | null | null | null |
Reset virtual time state in scrollbar tests
This prevents ScrollbarTestWithVirtualTimer from polluting global state
for tests following it.
Bug: 791742
Change-Id: Iae3440451833408a6a5bd24b3319b307cd6d3547
Reviewed-on: https://chromium-review.googlesource.com/969582
Commit-Queue: David Bokan <[email protected]>
Reviewed-by: Alex Clarke <[email protected]>
Cr-Commit-Position: refs/heads/master@{#544691} | 02a4180d7d533fab4df07d355ec029e719e353af | chrome | bigvul | 1 | null | null | null |
Allocate a FrameSinkId for RenderWidgetHostViewAura in mus+ash
RenderWidgetHostViewChildFrame expects its parent to have a valid
FrameSinkId. Make sure RenderWidgetHostViewAura has a FrameSinkId even
if DelegatedFrameHost is not used (in mus+ash).
BUG=706553
[email protected]
Review-Url: https://codereview.chromium.org/2847253003
Cr-Commit-Position: refs/heads/master@{#468179} | b399a05453d7b3e2dfdec67865fefe6953bcc59e | chrome | bigvul | 1 | null | null | null |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.