commit_msg
stringlengths 1
24.2k
| commit_hash
stringlengths 2
84
⌀ | project
stringlengths 2
40
| source
stringclasses 4
values | labels
int64 0
1
| repo_url
stringlengths 26
70
⌀ | commit_url
stringlengths 74
118
⌀ | commit_date
stringlengths 25
25
⌀ |
|---|---|---|---|---|---|---|---|
Cache all chrome.loadTimes info before passing them to setters.
The setters can invalidate the pointers frame, data_source and document_state.
BUG=549251
Review URL: https://codereview.chromium.org/1422753007
Cr-Commit-Position: refs/heads/master@{#357201} | 4026d85fcded8c4ee5113cb1bd1a7e8149e03827 | chrome | bigvul | 1 | null | null | null |
Support negative timestamps of TextTrackCue
Ensure proper behaviour for negative timestamps of TextTrackCue.
1. Cues with negative startTime should become active from 0s.
2. Cues with negative startTime and endTime should never be active.
Bug: 314032
Change-Id: Ib53710e58be0be770c933ea8c3c4709a0e5dec0d
Reviewed-on: https://chromium-review.googlesource.com/863270
Commit-Queue: srirama chandra sekhar <[email protected]>
Reviewed-by: Fredrik Söderquist <[email protected]>
Cr-Commit-Position: refs/heads/master@{#529012} | 53f1c0f95e568d4b6b184904f98cfde2833c603c | chrome | bigvul | 1 | null | null | null |
Roll PDFium 3acb1ef..24c1eec
https://pdfium.googlesource.com/pdfium.git/+log/3acb1ef..24c1eec
BUG=457480,497355
[email protected]
Review URL: https://codereview.chromium.org/1397173005
Cr-Commit-Position: refs/heads/master@{#353919} | e7df2d7d0c7a185834722cea42589caefd44da96 | chrome | bigvul | 1 | null | null | null |
Fix an optimisation in ContainerNode::notifyNodeInsertedInternal
[email protected]
BUG=544020
Review URL: https://codereview.chromium.org/1420653003
Cr-Commit-Position: refs/heads/master@{#355240} | eb4d5d9ab41449b79fcf6f84d8983be2b12bd490 | chrome | bigvul | 1 | null | null | null |
Roll PDFium a398ca6..3acb1ef
https://pdfium.googlesource.com/pdfium.git/+log/a398ca6..3acb1ef
BUG=497357,541323,514891
[email protected]
Review URL: https://codereview.chromium.org/1403563002
Cr-Commit-Position: refs/heads/master@{#353405} | 1ef74c77625095af2d15ef993859b93157750447 | chrome | bigvul | 1 | null | null | null |
This patch implements a mechanism for more granular link URL permissions (filtering on scheme/host). This fixes the bug that allowed PDFs to have working links to any "chrome://" URLs.
BUG=528505,226927
Review URL: https://codereview.chromium.org/1362433002
Cr-Commit-Position: refs/heads/master@{#351705} | 1eefa26e1795192c5a347a1e1e7a99e88c47f9c4 | chrome | bigvul | 1 | null | null | null |
Fix UAF in Origin Info Bubble and permission settings UI.
In addition to fixing the UAF, will this also fix the problem of the bubble
showing over the previous tab (if the bubble is open when the tab it was opened
for closes).
BUG=490492
TBR=tedchoc
Review URL: https://codereview.chromium.org/1317443002
Cr-Commit-Position: refs/heads/master@{#346023} | f2cba0d13b3a6d76dedede66731e5ca253d3b2af | chrome | bigvul | 1 | null | null | null |
Fix the win64 GN build after r351207.
BUG=497302
[email protected]
Review URL: https://codereview.chromium.org/1373143002
Cr-Commit-Position: refs/heads/master@{#351236} | d02508f8c010b1415f5f1521a6f4cee260d1f8a9 | chrome | bigvul | 1 | null | null | null |
Don't change Document load progress in any page dismissal events.
This can confuse the logic for blocking modal dialogs.
BUG=536652
Review URL: https://codereview.chromium.org/1373113002
Cr-Commit-Position: refs/heads/master@{#351419} | e1e0c4301aaa8228e362f2409dbde2d4d1896866 | chrome | bigvul | 1 | null | null | null |
crazy linker: Alter search for zip EOCD start
When loading directly from APK, begin searching backwards
for the zip EOCD record signature at size of EOCD record
bytes before the end of the file.
BUG=537205
[email protected]
Review URL: https://codereview.chromium.org/1390553002 .
Cr-Commit-Position: refs/heads/master@{#352577} | d9e316238aee59acf665d80b544cf4e1edfd3349 | chrome | bigvul | 1 | null | null | null |
Escape "--" in the page URL at page serialization
This patch makes page serializer to escape the page URL embed into a HTML
comment of result HTML[1] to avoid inserting text as HTML from URL by
introducing a static member function |PageSerialzier::markOfTheWebDeclaration()|
for sharing it between |PageSerialzier| and |WebPageSerialzier| classes.
[1] We use following format for serialized HTML:
saved from url=(${lengthOfURL})${URL}
BUG=503217
TEST=webkit_unit_tests --gtest_filter=PageSerializerTest.markOfTheWebDeclaration
TEST=webkit_unit_tests --gtest_filter=WebPageSerializerTest.fromUrlWithMinusMinu
Review URL: https://codereview.chromium.org/1371323003
Cr-Commit-Position: refs/heads/master@{#351736} | a81593e7f162428585832ac8f6e71f75592b53e7 | chrome | bigvul | 1 | null | null | null |
Improve presubmit message for QuitWhenIdleClosure().
Also makes this error about deprecated functions into a warning. The problems
with using these are not so severe they should block uploads.
BUG=none
TEST=none
Change-Id: I94e6cc900e23d8f3371aace9386a80829906083b
Reviewed-on: https://chromium-review.googlesource.com/902448
Reviewed-by: Daniel Cheng <[email protected]>
Commit-Queue: Peter Kasting <[email protected]>
Cr-Commit-Position: refs/heads/master@{#534542} | 9e7ccfa5678bd4f7e12b46b1480f8b924360fb47 | chrome | bigvul | 1 | null | null | null |
Disallow CSP source * matching of data:, blob:, and filesystem: URLs
The CSP spec specifically excludes matching of data:, blob:, and
filesystem: URLs with the source '*' wildcard. This adds checks to make
sure that doesn't happen, along with tests.
BUG=534570
[email protected]
Review URL: https://codereview.chromium.org/1361763005
Cr-Commit-Position: refs/heads/master@{#350950} | 5d0e9f824e05523e03dabc0e341b9f8f17a72bb0 | chrome | bigvul | 1 | null | null | null |
Reland "[CI] Make paint property nodes non-ref-counted"
This reverts commit 887383b30842d9d9006e11bb6932660a3cb5b1b7.
Reason for revert: Retry in M69.
Original change's description:
> Revert "[CI] Make paint property nodes non-ref-counted"
>
> This reverts commit 70fc0b018c9517558b7aa2be00edf2debb449123.
>
> Reason for revert: Caused bugs found by clusterfuzz
>
> Original change's description:
> > [CI] Make paint property nodes non-ref-counted
> >
> > Now all paint property nodes are owned by ObjectPaintProperties
> > (and LocalFrameView temporarily before removing non-RLS mode).
> > Others just use raw pointers or references.
> >
> > Bug: 833496
> > Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> > Change-Id: I2d544fe153bb94698623248748df63c8aa2081ae
> > Reviewed-on: https://chromium-review.googlesource.com/1031101
> > Reviewed-by: Tien-Ren Chen <[email protected]>
> > Commit-Queue: Xianzhu Wang <[email protected]>
> > Cr-Commit-Position: refs/heads/master@{#554626}
>
> [email protected],[email protected],[email protected]
>
> Change-Id: I02bb50d6744cb81a797246a0116b677e80a3c69f
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 833496,837932,837943
> Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> Reviewed-on: https://chromium-review.googlesource.com/1034292
> Reviewed-by: Xianzhu Wang <[email protected]>
> Commit-Queue: Xianzhu Wang <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#554653}
[email protected],[email protected],[email protected]
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: 833496, 837932, 837943
Change-Id: I0b4ef70db1f1f211ba97c30d617225355c750992
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Reviewed-on: https://chromium-review.googlesource.com/1083491
Commit-Queue: Xianzhu Wang <[email protected]>
Reviewed-by: Xianzhu Wang <[email protected]>
Cr-Commit-Position: refs/heads/master@{#563930} | f911e11e7f6b5c0d6f5ee694a9871de6619889f7 | chrome | bigvul | 1 | null | null | null |
parserInsertBefore: Bail out if the parent no longer contains the child.
nextChild may be removed from the DOM tree during the
|parserRemoveChild(*newChild)| call which triggers unload events of newChild's
descendant iframes. In order to maintain the integrity of the DOM tree, the
insertion of newChild must be aborted in this case.
This patch adds a return statement that rectifies the behavior in this
edge case.
BUG=519558
Review URL: https://codereview.chromium.org/1283263002
git-svn-id: svn://svn.chromium.org/blink/trunk@200690 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | c71a21e6dda9025c2bf823c5aab791c2ae8cdfc2 | chrome | bigvul | 1 | null | null | null |
Roll PDFium 20fc82e..b8a0747
https://pdfium.googlesource.com/pdfium.git/+log/20fc82e..b8a0747
BUG=507316,537780,538103
[email protected]
Review URL: https://codereview.chromium.org/1381113003
Cr-Commit-Position: refs/heads/master@{#352125} | 552422a88a1f9e50191588b03b6b284611911500 | chrome | bigvul | 1 | null | null | null |
Fix crash during EmbeddedWorkerInstance startup sequence failures
Once EWInstance startup calls the callback, it's possible that the
underlying ServiceWorkerVersion is destroyed, hence destroying
|this|. We must guard against that.
Also some failure points in the startup sequence weren't calling
OnStopped() as expected.
BUG=529520, 531345
Review URL: https://codereview.chromium.org/1327723005
Cr-Commit-Position: refs/heads/master@{#349368} | 37b83877e63f62f8aebb337494f1116539182bdf | chrome | bigvul | 1 | null | null | null |
Roll PDFium 7c9e452..640c395
https://pdfium.googlesource.com/pdfium.git/+log/7c9e452..640c395
BUG=522131
[email protected]
Review URL: https://codereview.chromium.org/1307343004
Cr-Commit-Position: refs/heads/master@{#347271} | b68f5c2b1cf7fe850312b49804af3a14472aa021 | chrome | bigvul | 1 | null | null | null |
Skip failing css-timing LayoutTests
Tests:
* external/wpt/css/css-timing/frames-timing-functions-output.html
* external/wpt/css/css-timing/frames-timing-functions-syntax.html
* external/wpt/css/css-timing/step-timing-functions-output.html
TBR=rjwright
Bug: 781171
Change-Id: I0799893780778304acb62a33b4694c58de0a6de0
Reviewed-on: https://chromium-review.googlesource.com/754143
Commit-Queue: meade_UTC10 <[email protected]>
Reviewed-by: Renée Wright <[email protected]>
Reviewed-by: meade_UTC10 <[email protected]>
Cr-Commit-Position: refs/heads/master@{#514076} | aa6e017b0fb87bc373294f28f5bf2541d240210b | chrome | bigvul | 1 | null | null | null |
Roll ANGLE 1e94979..4001e1d
https://chromium.googlesource.com/angle/angle.git/+log/1e94979..4001e1d
BUG=519642,522557
TEST=bots
Review URL: https://codereview.chromium.org/1313433004
Cr-Commit-Position: refs/heads/master@{#345179} | d8cd310f60278b06beee8be328a1d402be06d1dc | chrome | bigvul | 1 | null | null | null |
Add compression regression collector.
This tests hits a test page and
computes the compression rate for each of the resource types on it.
These metrics are then output to the console. After metrics from several
releases have been manually captured from the console, his test be
changed to check compression rates against the known good rates, and
alert if they fall outside a tolerance.
BUG=687216
Review-Url: https://codereview.chromium.org/2666963002
Cr-Commit-Position: refs/heads/master@{#447860} | 649a683e91abd33796fdaf787bce9bb7ef33cec4 | chrome | bigvul | 1 | null | null | null |
Fix detach with open()ed document leaving parent loading indefinitely
Change-Id: I26c2a054b9f1e5eb076acd677e1223058825f6d6
Bug: 803416
Test: fast/loader/document-open-iframe-then-detach.html
Change-Id: I26c2a054b9f1e5eb076acd677e1223058825f6d6
Reviewed-on: https://chromium-review.googlesource.com/887298
Reviewed-by: Mike West <[email protected]>
Commit-Queue: Nate Chapin <[email protected]>
Cr-Commit-Position: refs/heads/master@{#532967} | fd506b0ac6c7846ae45b5034044fe85c28ee68ac | chrome | bigvul | 1 | null | null | null |
Update some disabled browser tests with crbug link for network service
This CL categorizes some disabled browser tests with service worker
related crbug link since they have similar stack trace.
This CL also enables a browser test that runs successfully when using
network service.
Bug: 769401
Change-Id: Icaeaad7c39c45b702bbf4a7e06ea40fbd2ff1985
Reviewed-on: https://chromium-review.googlesource.com/738876
Commit-Queue: Jun Cai <[email protected]>
Reviewed-by: Yuzhu Shen <[email protected]>
Cr-Commit-Position: refs/heads/master@{#512678} | c0c5c85acca945eb3399fb000b6b1bbdb5b2ab4e | chrome | bigvul | 1 | null | null | null |
MacViews: Enable secure text input for password Textfields.
In Cocoa the NSTextInputContext automatically enables secure text input
when activated and it's in the secure text entry mode.
RenderWidgetHostViewMac did the similar thing for ages following the
WebKit example.
views::Textfield needs to do the same thing in a fashion that's
sycnrhonized with RenderWidgetHostViewMac, otherwise the race conditions
are possible when the Textfield gets focus, activates the secure text
input mode and the RWHVM loses focus immediately afterwards and disables
the secure text input instead of leaving it in the enabled state.
BUG=818133,677220
Change-Id: I6db6c4b59e4a1a72cbb7f8c7056f71b04a3df08b
Reviewed-on: https://chromium-review.googlesource.com/943064
Commit-Queue: Michail Pishchagin <[email protected]>
Reviewed-by: Pavel Feldman <[email protected]>
Reviewed-by: Avi Drissman <[email protected]>
Reviewed-by: Peter Kasting <[email protected]>
Cr-Commit-Position: refs/heads/master@{#542517} | f1574f25e1402e748bf2bd7e28ce3dd96ceb1ca4 | chrome | bigvul | 1 | null | null | null |
Make RenderViewTests clean up all RenderViews.
As of crrev.com/c/814994/, the RenderViewTest harness gives tests the
ability to open additional windows, but previously RenderViewTest::TearDown
did not clean up these additional windows, so their WebFrameSchedulerImpls
were not getting destructed during shutdown.
RenderViewTest::TearDown now sends a ViewMsg_Close to all open views.
Bug: 801184
Change-Id: Ibe153b1946bd04c2004904b6df978142be0f7b22
Reviewed-on: https://chromium-review.googlesource.com/866771
Reviewed-by: Alexander Timin <[email protected]>
Reviewed-by: Yuzu Saijo <[email protected]>
Reviewed-by: Scott Violet <[email protected]>
Commit-Queue: Balazs Engedy <[email protected]>
Cr-Commit-Position: refs/heads/master@{#529489} | f197c1c2b441da15274e2c17a928d7760b0bb260 | chrome | bigvul | 1 | null | null | null |
[ChromeDriver] Disabling test MobileEmulationCapabilityTest.testDeviceMetricsWithDeviceWidth
Test testDeviceMetricsWithDeviceWidth occasionally fails in Chromedriver test automation on Linux build bot.
Bug: chromedriver:2132
Change-Id: If38097aee1ada7c7e7b7e7832e9643279a14011c
Reviewed-on: https://chromium-review.googlesource.com/769156
Reviewed-by: John Chen <[email protected]>
Commit-Queue: Artur Khachatryan <[email protected]>
Cr-Commit-Position: refs/heads/master@{#516377} | 5a3e9ad904d0e9e0ce43c2bcd9fc23fa3f3ec042 | chrome | bigvul | 1 | null | null | null |
Add ASSERT() to avoid accidental leaking ServiceWorkerContainer to cross origin context.
BUG=522791
Review URL: https://codereview.chromium.org/1305903007
git-svn-id: svn://svn.chromium.org/blink/trunk@201889 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | 7ee897723127d0b8fecc5e67d45e20179c760e6e | chrome | bigvul | 1 | null | null | null |
Clarify the byte ordering and premultiplied-ness of the Pepper 2D data.
BUG=none
TEST=none (no code change)
Review URL: http://codereview.chromium.org/524074
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35918 0039d316-1c4b-4281-b951-d872f2087c98 | d8fcf77c1946a7c5eaa8907f50a7e5df163a1a41 | chrome | bigvul | 1 | null | null | null |
Introduce RunLoop::Type::NESTABLE_TASKS_ALLOWED to replace MessageLoop::ScopedNestableTaskAllower.
(as well as MessageLoop::SetNestableTasksAllowed())
Surveying usage: the scoped object is always instantiated right before
RunLoop().Run(). The intent is really to allow nestable tasks in that
RunLoop so it's better to explicitly label that RunLoop as such and it
allows us to break the last dependency that forced some RunLoop users
to use MessageLoop APIs.
There's also the odd case of allowing nestable tasks for loops that are
reentrant from a native task (without going through RunLoop), these
are the minority but will have to be handled (after cleaning up the
majority of cases that are RunLoop induced).
As highlighted by robliao@ in https://chromium-review.googlesource.com/c/600517
(which was merged in this CL).
[email protected]
Bug: 750779
Change-Id: I43d122c93ec903cff3a6fe7b77ec461ea0656448
Reviewed-on: https://chromium-review.googlesource.com/594713
Commit-Queue: Gabriel Charette <[email protected]>
Reviewed-by: Robert Liao <[email protected]>
Reviewed-by: danakj <[email protected]>
Cr-Commit-Position: refs/heads/master@{#492263} | 3ff403eecdd23a39853a4ebca52023fbba6c5d00 | chrome | bigvul | 1 | null | null | null |
Crash on nested IPC handlers in PrintWebViewHelper
Class is not designed to handle nested IPC. Regular flows also does not
expect them. Still during printing of plugging them may show message
boxes and start nested message loops.
For now we are going just crash. If stats show us that this case is
frequent we will have to do something more complicated.
BUG=502562
Review URL: https://codereview.chromium.org/1228693002
Cr-Commit-Position: refs/heads/master@{#338100} | 8fa5a358cb32085b51daf92df8fd4a79b3931f81 | chrome | bigvul | 1 | null | null | null |
Clean up Android DownloadManager code as most download now go through Chrome Network stack
The only exception is OMA DRM download.
And it only applies to context menu download interception.
Clean up the remaining unused code now.
BUG=647755
Review-Url: https://codereview.chromium.org/2371773003
Cr-Commit-Position: refs/heads/master@{#421332} | 5fc08cfb098acce49344d2e89cc27c915903f81c | chrome | bigvul | 1 | null | null | null |
Hide requests in an extension from other extensions
BUG=510802
Review URL: https://codereview.chromium.org/1267183003
Cr-Commit-Position: refs/heads/master@{#341939} | 86154b409eed6ea7f9177f6bf576e76533ab2f7b | chrome | bigvul | 1 | null | null | null |
DevTools: Port some network tests.
Bug: 667560
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I196707ea89f0c2b1b372a57b53f866fe4f03d76f
Reviewed-on: https://chromium-review.googlesource.com/783820
Commit-Queue: Eugene Ostroukhov <[email protected]>
Reviewed-by: Will Chen <[email protected]>
Cr-Commit-Position: refs/heads/master@{#518827} | 6be50e67f9f812d412eace7fad217d5eac16ca94 | chrome | bigvul | 1 | null | null | null |
Disable forwarding tasks to the Blink scheduler
Disable forwarding tasks to the Blink scheduler to avoid some
regressions which it has introduced.
BUG=391005,415758,415478,412714,416362,416827,417608
[email protected]
Review URL: https://codereview.chromium.org/609483002
Cr-Commit-Position: refs/heads/master@{#296916} | 1810bb5cec9026c64fc34fbbb8fafd01263241d2 | chrome | bigvul | 1 | null | null | null |
Use pdf compositor service for printing when OOPIF is enabled
When OOPIF is enabled (by site-per-process flag or
top-document-isolation feature), use the pdf compositor service for
converting PaintRecord to PDF on renderers.
In the future, this will make compositing PDF from multiple renderers
possible.
[email protected]
BUG=455764
Change-Id: I3c28f03f4358e4228239fe1a33384f85e7716e8f
Reviewed-on: https://chromium-review.googlesource.com/699765
Commit-Queue: Wei Li <[email protected]>
Reviewed-by: Daniel Cheng <[email protected]>
Reviewed-by: Lei Zhang <[email protected]>
Cr-Commit-Position: refs/heads/master@{#511616} | 9c391ac04f9ac478c8b0e43b359c2b43a6c892ab | chrome | bigvul | 1 | null | null | null |
Fix nullptr crash in IsSiteMuted
This CL adds a nullptr check in IsSiteMuted to prevent a crash on Mac.
Bug: 797647
Change-Id: Ic36f0fb39f2dbdf49d2bec9e548a4a6e339dc9a2
Reviewed-on: https://chromium-review.googlesource.com/848245
Reviewed-by: Mounir Lamouri <[email protected]>
Reviewed-by: Yuri Wiitala <[email protected]>
Commit-Queue: Tommy Steimel <[email protected]>
Cr-Commit-Position: refs/heads/master@{#526825} | 616568a633a3e2ae10537d14d3944d87ec382b8f | chrome | bigvul | 1 | null | null | null |
Fixed volume slider element event handling
MediaControlVolumeSliderElement::defaultEventHandler has making
redundant calls to setVolume() & setMuted() on mouse activity. E.g. if
a mouse click changed the slider position, the above calls were made 4
times, once for each of these events: mousedown, input, mouseup,
DOMActive, click. This crack got exposed when PointerEvents are enabled
by default on M55, adding pointermove, pointerdown & pointerup to the
list.
This CL fixes the code to trigger the calls to setVolume() & setMuted()
only when the slider position is changed. Also added pointer events to
certain lists of mouse events in the code.
BUG=677900
Review-Url: https://codereview.chromium.org/2622273003
Cr-Commit-Position: refs/heads/master@{#446032} | 74fce5949bdf05a92c2bc0bd98e6e3e977c55376 | chrome | bigvul | 1 | null | null | null |
Fix AutoplayUmaHelper when autoplay is initiated from multiple sources
This CL makes AutoplayUmaHelper to handle the case where the page
autoplays by both attribute and play() method. Therefore we can avoid
counting the metrics into the wrong bucket.
BUG=699176
Review-Url: https://codereview.chromium.org/2767093002
Cr-Commit-Position: refs/heads/master@{#459215} | 3d3dfcd34e38fcecaa1ff14bcd12cbc98259f36c | chrome | bigvul | 1 | null | null | null |
Switch to equalIgnoringASCIICase throughout modules/accessibility
BUG=627682
Review-Url: https://codereview.chromium.org/2793913007
Cr-Commit-Position: refs/heads/master@{#461858} | d27468a832d5316884bd02f459cbf493697fd7e1 | chrome | bigvul | 1 | null | null | null |
Add a validator for intent:// URLs.
BUG=462843,482113
Review URL: https://codereview.chromium.org/1059413004
Cr-Commit-Position: refs/heads/master@{#327613} | e8b8c72eb8eb462c52a707c556d53d350bbd408d | chrome | bigvul | 1 | null | null | null |
[Chromecast] Add net unit tests to automated tests.
BUG=internal b/38321725
Review-Url: https://codereview.chromium.org/2886893004
Cr-Commit-Position: refs/heads/master@{#472614} | a2bc3db508d2a5bc022041c4de0b801384a2b17c | chrome | bigvul | 1 | null | null | null |
Add a dismissModals method to ContentSuggestions
This CL implements the dismissModals method needed by the
NewTabPagePanelProtocol, and merges the existing ones with it.
BUG=700375
Change-Id: I95ff37f649fb6a1e6ab29d3f3ed917d74883c80d
Reviewed-on: https://chromium-review.googlesource.com/558873
Reviewed-by: Louis Romero <[email protected]>
Commit-Queue: Gauthier Ambard <[email protected]>
Cr-Commit-Position: refs/heads/master@{#483981} | a90919df755b28d06305e1ecad9032322b054624 | chrome | bigvul | 1 | null | null | null |
media: Support hosting mojo CDM in a standalone service
Currently when mojo CDM is enabled it is hosted in the MediaService
running in the process specified by "mojo_media_host". However, on
some platforms we need to run mojo CDM and other mojo media services in
different processes. For example, on desktop platforms, we want to run
mojo video decoder in the GPU process, but run the mojo CDM in the
utility process.
This CL adds a new build flag "enable_standalone_cdm_service". When
enabled, the mojo CDM service will be hosted in a standalone "cdm"
service running in the utility process. All other mojo media services
will sill be hosted in the "media" servie running in the process
specified by "mojo_media_host".
BUG=664364
TEST=Encrypted media browser tests using mojo CDM is still working.
Change-Id: I95be6e05adc9ebcff966b26958ef1d7becdfb487
Reviewed-on: https://chromium-review.googlesource.com/567172
Commit-Queue: Xiaohan Wang <[email protected]>
Reviewed-by: Daniel Cheng <[email protected]>
Reviewed-by: John Abd-El-Malek <[email protected]>
Reviewed-by: Dan Sanders <[email protected]>
Cr-Commit-Position: refs/heads/master@{#486947} | bc1f34b9be509f1404f0bb1ba1947614d5f0bcd1 | chrome | bigvul | 1 | null | null | null |
Correctly keep track of isolates for microtask execution
BUG=487155
[email protected]
Review URL: https://codereview.chromium.org/1161823002
git-svn-id: svn://svn.chromium.org/blink/trunk@195985 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | dff368031150a1033a1a3c913f8857679a0279be | chrome | bigvul | 1 | null | null | null |
Roll material-design-icons to 5ab428852e35dc177a8c37a2df9dc9ccf768c65a.
Commit 5ab428852e35dc177a8c37a2df9dc9ccf768c65a adds Contents.json for
all .imageset in the material-design-icons that are required for asset
catalog compilation.
Add //third_party/material_design_icons:ic_touch_app as a dependency
of //remoting/ios/app/resources:assets as it is now fixed.
Bug: 734054
Change-Id: Icc4e484ba1ed22c1af06a4c074b3d0cf0ba00bf9
Reviewed-on: https://chromium-review.googlesource.com/576037
Reviewed-by: Yuwei Huang <[email protected]>
Commit-Queue: Scott Nichols <[email protected]>
Cr-Commit-Position: refs/heads/master@{#487928} | d45469f31c9c353f72a4de9df46360e7f23077e9 | chrome | bigvul | 1 | null | null | null |
Fix crash happens when VK tray is clicked after VK is disabled.
Bug: 749989
Test: manually
Change-Id: I547151f5950e07e3669d0f13ce41b951cd354f4f
Reviewed-on: https://chromium-review.googlesource.com/593434
Reviewed-by: Mitsuru Oshima <[email protected]>
Reviewed-by: Keigo Oka <[email protected]>
Commit-Queue: Keigo Oka <[email protected]>
Cr-Commit-Position: refs/heads/master@{#492052} | d10065ae8b87f4eefe50d756f9c3464832c40bcf | chrome | bigvul | 1 | null | null | null |
Print Preview: Fix WebUI Event name
Incorrect event name was used when registering the listener, so the
event was never received.
Bug: 753942
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ie58dacc705632f90857bf8fb19139d7f967e1684
Reviewed-on: https://chromium-review.googlesource.com/609093
Reviewed-by: Demetrios Papadopoulos <[email protected]>
Commit-Queue: Rebekah Potter <[email protected]>
Cr-Commit-Position: refs/heads/master@{#493243} | 168bd826fe11a44238a169ef953447db0c0e4841 | chrome | bigvul | 1 | null | null | null |
Add a test that getModuleSystem() doesn't work cross origin
BUG=504011
[email protected]
[email protected]
Review URL: https://codereview.chromium.org/1241443004
Cr-Commit-Position: refs/heads/master@{#338663} | 7923c2a2c443d98c432864e361b1d090f0c911ca | chrome | bigvul | 1 | null | null | null |
Local NTP: add smoke tests for doodles
Split LogoService into LogoService interface and LogoServiceImpl to make
it easier to provide fake data to the test.
Bug: 768419
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I84639189d2db1b24a2e139936c99369352bab587
Reviewed-on: https://chromium-review.googlesource.com/690198
Reviewed-by: Sylvain Defresne <[email protected]>
Reviewed-by: Marc Treib <[email protected]>
Commit-Queue: Chris Pickel <[email protected]>
Cr-Commit-Position: refs/heads/master@{#505374} | deaa07bec5d105ffc546d37eba3da4cba341fc03 | chrome | bigvul | 1 | null | null | null |
Add PPAPI test mock headers to *.isolate files.
This should have been part of https://codereview.chromium.org/1136493003.
BUG=419383
Review URL: https://codereview.chromium.org/1139913002
Cr-Commit-Position: refs/heads/master@{#329390} | f479194866c3d9e08ef245ed0fdd5b9771ce6195 | chrome | bigvul | 1 | null | null | null |
Roll ICU from 5788e2736b3bc to f1ad7f9ba957
Summary of changes available at:
https://chromium.googlesource.com/chromium/deps/icu/+log/5788e27..f1ad7f9
BUG=444573
TEST=See the bug
TBR=inferno
Review URL: https://codereview.chromium.org/1157143002
Cr-Commit-Position: refs/heads/master@{#331437} | 886e691e17018818b7fc0978bcbe9a85436b506c | chrome | bigvul | 1 | null | null | null |
Network traffic annotation added to extensions::image_writer::WriteFromUrlOperation.
Network traffic annotation is added to network request of extensions::image_writer::WriteFromUrlOperation.
BUG=656607
Review-Url: https://codereview.chromium.org/2691963002
Cr-Commit-Position: refs/heads/master@{#451456} | 4e7c52b4577b682be39ad617ceb5d98a32279939 | chrome | bigvul | 1 | null | null | null |
When serializing accessibility tree, skip invalid children.
See bug for specific repro in the wild, but essentially we need to check
if the child is valid just before serializing, and not trust the list of
children of a node.
BUG=479743
Review URL: https://codereview.chromium.org/1144363004
Cr-Commit-Position: refs/heads/master@{#332748} | 8dc07f045c6287da3404fa8e0fd8b1b3960afbfa | chrome | bigvul | 1 | null | null | null |
Correctly reset FP in RFHI whenever origin changes
Bug: 713364
Change-Id: Id8bb923750e20f3db6fc9358b1d44120513ac95f
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
Change-Id: Id8bb923750e20f3db6fc9358b1d44120513ac95f
Reviewed-on: https://chromium-review.googlesource.com/482380
Commit-Queue: Ian Clelland <[email protected]>
Reviewed-by: Charles Reis <[email protected]>
Cr-Commit-Position: refs/heads/master@{#466778} | 784f56a9c97a838448dd23f9bdc7c05fe8e639b3 | chrome | bigvul | 1 | null | null | null |
[reland] Do not set default wallpaper unless it should do so.
[email protected], [email protected]
Bug: 751382
Change-Id: Id0793dfe467f737526a95b1e66ed01fbb8860bda
Reviewed-on: https://chromium-review.googlesource.com/619754
Commit-Queue: Xiaoqian Dai <[email protected]>
Reviewed-by: Alexander Alekseev <[email protected]>
Reviewed-by: Biao She <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#498325}
Reviewed-on: https://chromium-review.googlesource.com/646430
Cr-Commit-Position: refs/heads/master@{#498982} | 39595f8d4dffcb644d438106dcb64a30c139ff0e | chrome | bigvul | 1 | null | null | null |
Refine paint test using Reference Tests
Since this test confirms partially selected text is styled with
::selection, rewrite as ref test for readability and stability.
Bug: 739062
Change-Id: Idfe83255aaee2e2da77cac27929a73fc23a64ae6
Reviewed-on: https://chromium-review.googlesource.com/735299
Reviewed-by: Yoshifumi Inoue <[email protected]>
Commit-Queue: Yoichi Osato <[email protected]>
Cr-Commit-Position: refs/heads/master@{#512110} | d12359d46a29b8a357d84dc0a1e8c6dbba56a671 | chrome | bigvul | 1 | null | null | null |
Add component fields to OWNERS for layout tests.
BUG=
Review-Url: https://codereview.chromium.org/2902763002
Cr-Commit-Position: refs/heads/master@{#474029} | bdcae45e4652e4f6c606388996a5efc43f5308b4 | chrome | bigvul | 1 | null | null | null |
MD-Settings: A11y - Label power source and stylus drop downs.
[email protected]
BUG=710691
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2817973002
Cr-Commit-Position: refs/heads/master@{#464552} | 4f4530109b8b68643c6a3afbb239e21580d46a8a | chrome | bigvul | 1 | null | null | null |
Move ImageLoader timer to frame-specific TaskRunnerTimer.
Move ImageLoader timer m_derefElementTimer to frame-specific TaskRunnerTimer.
This associates it with the frame's Networking timer task queue.
BUG=624694
Review-Url: https://codereview.chromium.org/2642103002
Cr-Commit-Position: refs/heads/master@{#444927} | ce1a9c0e454b08c96ca73788a1b4dccb405ce027 | chrome | bigvul | 1 | null | null | null |
Mark fast/spatial-navigation/snav-z-index.html as flaky.
BUG=724567
[email protected]
NOTRY=true
Review-Url: https://codereview.chromium.org/2898463002
Cr-Commit-Position: refs/heads/master@{#473253} | edd966f42e17c86c7658b9e3464838162640e18d | chrome | bigvul | 1 | null | null | null |
Update helper classes in usb_device_handle_unittest for OnceCallback
Helper classes in usb_device_handle_unittest.cc don't fit to OnceCallback
migration, as they are copied and passed to others.
This CL updates them to pass new callbacks for each use to avoid the
copy of callbacks.
Bug: 714018
Change-Id: Ifb70901439ae92b6b049b84534283c39ebc40ee0
Reviewed-on: https://chromium-review.googlesource.com/527549
Reviewed-by: Ken Rockot <[email protected]>
Commit-Queue: Taiju Tsuiki <[email protected]>
Cr-Commit-Position: refs/heads/master@{#478549} | b72c008d3c36bb39d9b13225b42f18aff0aa4c8e | chrome | bigvul | 1 | null | null | null |
Explicitly enforce values size in feColorMatrix.
[email protected]
BUG=468519
Review URL: https://codereview.chromium.org/1075413002
git-svn-id: svn://svn.chromium.org/blink/trunk@193571 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | c1edcafcbe5b8fa20d7e1adb2d1a5322924d8df0 | chrome | bigvul | 1 | null | null | null |
Switching AudioOutputAuthorizationHandler from using AudioManager interface to AudioSystem one.
BUG=672468
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2692203003
Cr-Commit-Position: refs/heads/master@{#450939} | 04ff52bb66284467ccb43d90800013b89ee8db75 | chrome | bigvul | 1 | null | null | null |
WebVR: fix initial vsync
Applications sometimes use window.rAF while not presenting, then switch to
vrDisplay.rAF after presentation starts. Depending on the animation loop's
timing, this can cause a race condition where presentation has been started
but there's no vrDisplay.rAF pending yet. Ensure there's at least vsync
being processed after presentation starts so that a queued window.rAF
can run and schedule a vrDisplay.rAF.
BUG=711789
Review-Url: https://codereview.chromium.org/2848483003
Cr-Commit-Position: refs/heads/master@{#468167} | 262e77a72493e36e8006aeeba1c7497a42ee5ad9 | chrome | bigvul | 1 | null | null | null |
Add tests for closing a frame within the scope of a getusermedia callback.
BUG=472617, 474370
Review URL: https://codereview.chromium.org/1073783003
Cr-Commit-Position: refs/heads/master@{#324633} | 64aae326a6b32fdfba377dc5e060fd4713a2295b | chrome | bigvul | 1 | null | null | null |
Percent-encode illegal characters in Android page info popup URL
This prevents whitespace and non-ASCII characters from being displayed in
the url, stopping attacks where a carefully crafted URL can be used
to display a message in the popup.
BUG=466351
Review URL: https://codereview.chromium.org/1011383005
Cr-Commit-Position: refs/heads/master@{#322296} | b1130cfc5dca2d5f01edafd7d50f795f391ab904 | chrome | bigvul | 1 | null | null | null |
Always initialize |m_totalWidth| in HarfBuzzShaper::shape.
[email protected]
BUG=476647
Review URL: https://codereview.chromium.org/1108663003
git-svn-id: svn://svn.chromium.org/blink/trunk@194541 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | d8fccaec4e73a9120074293c1997f963f810c9dd | chrome | bigvul | 1 | null | null | null |
Photo Picker dialog: Add UMA for file enumeration.
BUG=656015
Review-Url: https://codereview.chromium.org/2933173003
Cr-Commit-Position: refs/heads/master@{#479162} | 9fc9d951c4b4757038d8ae9dbeafd43bea88aab3 | chrome | bigvul | 1 | null | null | null |
Add PersistenceDelegate to HostCache
PersistenceDelegate is a new interface for persisting the contents of
the HostCache. This commit includes the interface itself, the logic in
HostCache for interacting with it, and a mock implementation of the
interface for testing. It does not include support for immediate data
removal since that won't be needed for the currently planned use case.
BUG=605149
Review-Url: https://codereview.chromium.org/2943143002
Cr-Commit-Position: refs/heads/master@{#481015} | 7c28e7988fef9bb3e03027226bd199736d99abc3 | chrome | bigvul | 1 | null | null | null |
Move Editor::Transpose() out of Editor class
This patch moves |Editor::Transpose()| out of |Editor| class as preparation of
expanding it into |ExecutTranspose()| in "EditorCommand.cpp" to make |Editor|
class simpler for improving code health.
Following patch will expand |Transpose()| into |ExecutTranspose()|.
Bug: 672405
Change-Id: Icde253623f31813d2b4517c4da7d4798bd5fadf6
Reviewed-on: https://chromium-review.googlesource.com/583880
Reviewed-by: Xiaocheng Hu <[email protected]>
Commit-Queue: Yoshifumi Inoue <[email protected]>
Cr-Commit-Position: refs/heads/master@{#489518} | 8ea5693d5cf304e56174bb6b65412f04209904db | chrome | bigvul | 1 | null | null | null |
Gate support for certain EOTFs/primaries/matrices on color management / hdr flags
Creates a new class VideoColorSpace specifically for encoding color spaces
according to ISO/IEC 23001-8.
Plumb this color space through from parsing to validation.
BUG=687627
Review-Url: https://codereview.chromium.org/2742113002
Cr-Commit-Position: refs/heads/master@{#456518} | 2fb4f2c9c461551d43fdfa28ef4c960da81a47dd | chrome | bigvul | 1 | null | null | null |
Output silence if the MediaElementAudioSourceNode has a different origin
See http://webaudio.github.io/web-audio-api/#security-with-mediaelementaudiosourcenode-and-cross-origin-resources
Two new tests added for the same origin and a cross origin source.
BUG=313939
Review URL: https://codereview.chromium.org/520433002
git-svn-id: svn://svn.chromium.org/blink/trunk@189527 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | 6834289784ed45b5524de0fb7ef43ae283b0d6d3 | chrome | bigvul | 1 | null | null | null |
Add unittests for different transport security state generator components.
BUG=595493
Review-Url: https://codereview.chromium.org/2775053002
Cr-Commit-Position: refs/heads/master@{#461191} | b9aca9d06e2948b32e03c1986ec4b47b66ee50dd | chrome | bigvul | 1 | null | null | null |
DevTools: align tabbed pane close tab buttons.
BUG=674868
Review-Url: https://codereview.chromium.org/2649973004
Cr-Commit-Position: refs/heads/master@{#445808} | b720c4913146533c718b8d5a1e0308780d871833 | chrome | bigvul | 1 | null | null | null |
ur_ls -> urls in ResourceFetcher
Blink Reformat miss? fix
BUG=675877
Review-Url: https://codereview.chromium.org/2809103002
Cr-Commit-Position: refs/heads/master@{#463599} | 4fdb2b3ebb31e39852fb1bc20fcdf3b5e4de382e | chrome | bigvul | 1 | null | null | null |
Make Surface creation lazy for OffscreenCanvasFrameReceiverImpl
This CL shifts the SurfaceFactory pointer and SurfaceFactoryClient implementation
from OffscreenCanvasSurfaceImpl to OffscreenCanvasFrameReceiverImpl to
facilitate resource handling after compositor frame is submitted. As a result,
surface on browser is lazily created (only happened on the first commit()).
BUG=563852
Review-Url: https://codereview.chromium.org/2333133003
Cr-Commit-Position: refs/heads/master@{#418402} | a3987c8b93d3abbba6ea4e438493bf996fff66b7 | chrome | bigvul | 1 | null | null | null |
Roll src/third_party/pdfium/ 213f01205..bf9104d58 (15 commits)
https://pdfium.googlesource.com/pdfium.git/+log/213f01205a77..bf9104d5825d
$ git log 213f01205..bf9104d58 --date=short --no-merges --format='%ad %ae %s'
2017-03-30 tsepez vswprintf() part 1: move code, create helper function.
2017-03-30 dsinclair Move CXFA_XMLParser to CFDE_XMLParser
2017-03-30 thestig Fix some nits in the javascript util code.
2017-03-30 dsinclair Add some calls to MakeUnique
2017-03-30 dsinclair Move core/fxcrt XML files to core/fxcrt/xml
2017-03-30 tsepez Avoid one more instance of the anti-pattern in 706346.
2017-03-30 npm Libtiff security upstream patches
2017-03-30 dsinclair Rename tto/fde_textout to cfde_textout
2017-03-30 dsinclair Move CFX files into fxcrt
2017-03-30 thakis Revert "Enable Wshift-negative-value in PDFium."
2017-03-30 tsepez Protect against premature mask destruction in CFX_ClipRgn::IntersectRect
2017-03-30 drott Remove unnecessary FreeType include.
2017-03-30 dsinclair Rename FDE files to match contents.
2017-03-30 drott Fix Chromium XFA build
2017-03-30 dsinclair Rename fgas_stream to ifgas_stream
Created with:
roll-dep src/third_party/pdfium
BUG=507717,706346,706824,706824
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls
[email protected]
Review-Url: https://codereview.chromium.org/2787763003
Cr-Commit-Position: refs/heads/master@{#460917} | 026a2f4a1f023de9bf72674db9c88cdcf651418e | chrome | bigvul | 1 | null | null | null |
Copy LoginReputationClientRequest/Response protos
Copy LoginReputationClientRequest and LoginReputationClientResponse
protos from google3 to chrome/common/safe_browsing/csd.proto
BUG=698899
Review-Url: https://codereview.chromium.org/2733963003
Cr-Commit-Position: refs/heads/master@{#455215} | 0fd4e054da246f044d62d18b626ff4afa68b7b72 | chrome | bigvul | 1 | null | null | null |
Hide the "Open PDF in Reader" bubble on navigations.
BUG=444957
Review URL: https://codereview.chromium.org/831283002
Cr-Commit-Position: refs/heads/master@{#310167} | 432eb007ad1d67d12d2a9d69a0f6e78b9efee9b1 | chrome | bigvul | 1 | null | null | null |
Add string resources for MD Ash network detailed view
Includes messages for when:
- a network connection is connecting;
- a network connection is connected;
- a cellular network is not activated;
- a VPN network may be monitored.
Also includes the title for cellular section.
BUG=none
TEST=
Committed: https://crrev.com/31b1215a3979bf9cee3206141a1970bb84afb775
Review-Url: https://codereview.chromium.org/2478713002
Cr-Original-Commit-Position: refs/heads/master@{#429750}
Cr-Commit-Position: refs/heads/master@{#429838} | e40a4ae160c26f4104a4c00cb1e8532d269cf0ec | chrome | bigvul | 1 | null | null | null |
Disable ash configuring display when running mash.
When running ash inside of mash_shell on a device, DisplayConfigurator
will request a NativeDisplayDelegate from Ozone. Ozone is initialized
only in the mus process, not in the ash process, so ash crashes at this
point.
Add accessor for configure_display_ to avoid crashing. The default
display size can be set via command line with --ash-host-window-bounds
flag until a better solution exists.
BUG=590096
Review URL: https://codereview.chromium.org/1782093003
Cr-Commit-Position: refs/heads/master@{#380663} | de485eb849be99305925de2257da3b85325df2fd | chrome | bigvul | 1 | null | null | null |
Provide experimental contextual suggestions when current URL comes from a google domain.
The counts for the Omnibox.ZeroSuggestRequests historgram are 35% smaller for groups that are running under the ZeroSuggestRedirectToChrome flag. Note that previous to this CL, a request was not made when the user was visiting an HTTPS page and the domain of the current was different from that of the service providing zero suggestions. This CL addresses this restrictions by making sure that requests are sent to the experimental service when Google is the default search engine AND the same request was validated to be sent to Google.
BUG=692471
Review-Url: https://codereview.chromium.org/2915163003
Cr-Commit-Position: refs/heads/master@{#476786} | 3f71619ec516f553c69a08bf373dcde14e86d08f | chrome | bigvul | 1 | null | null | null |
MidiManagerUsb should not trust indices provided by renderer.
MidiManagerUsb::DispatchSendMidiData takes |port_index| parameter. As it is
provided by a renderer possibly under the control of an attacker, we must
validate the given index before using it.
BUG=456516
Review URL: https://codereview.chromium.org/907793002
Cr-Commit-Position: refs/heads/master@{#315303} | 5576cbc1d3e214dfbb5d3ffcdbe82aa8ba0088fc | chrome | bigvul | 1 | null | null | null |
[Blink>Media] Allow autoplay muted on Android by default
There was a mistake causing autoplay muted is shipped on Android
but it will be disabled if the chromium embedder doesn't specify
content setting for "AllowAutoplay" preference. This CL makes the
AllowAutoplay preference true by default so that it is allowed by
embedders (including AndroidWebView) unless they explicitly
disable it.
Intent to ship:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/Q1cnzNI2GpI/AL_eyUNABgAJ
BUG=689018
Review-Url: https://codereview.chromium.org/2677173002
Cr-Commit-Position: refs/heads/master@{#448423} | faaa2fd0a05f1622d9a8806da118d4f3b602e707 | chrome | bigvul | 1 | null | null | null |
Add data usage tracking for chrome services
Add data usage tracking for captive portal, web resource and signin services
BUG=655749
Review-Url: https://codereview.chromium.org/2643013004
Cr-Commit-Position: refs/heads/master@{#445810} | a81c185f34b34ef8410239506825b185b332c00b | chrome | bigvul | 1 | null | null | null |
Allow serialization of empty bluetooth uuids.
This change allows the passing WTF::Optional<String> types as
bluetooth.mojom.UUID optional parameter without needing to ensure the passed
object isn't empty.
BUG=None
R=juncai, dcheng
Review-Url: https://codereview.chromium.org/2646613003
Cr-Commit-Position: refs/heads/master@{#445809} | 2bceda4948deeaed0a5a99305d0d488eb952f64f | chrome | bigvul | 1 | null | null | null |
Reload frame in V8Window::namedPropertyGetterCustom after js call
[email protected]
BUG=454954
Review URL: https://codereview.chromium.org/901053006
git-svn-id: svn://svn.chromium.org/blink/trunk@189574 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | 82eeef54780833a29e88c5677a7cfa11205a9878 | chrome | bigvul | 1 | null | null | null |
Turn a bunch of ASSERTs into graceful failures when compiling listeners
BUG=456192
[email protected]
Review URL: https://codereview.chromium.org/906193002
git-svn-id: svn://svn.chromium.org/blink/trunk@189796 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | fc81fcf38edd250876cc384a6ed5567e1b2999e4 | chrome | bigvul | 1 | null | null | null |
Make Sber1/2 pref metrics into Nullable Booleans so we can track how often these prefs are unset.
BUG=699139
Review-Url: https://codereview.chromium.org/2739643003
Cr-Commit-Position: refs/heads/master@{#456059} | 53f40b0658b240dd7397a58b29b083631519735f | chrome | bigvul | 1 | null | null | null |
Fix handling of broken GIFs with weird frame sizes
Code didn't handle well if a GIF frame has dimension greater than the
"screen" dimension. This will break deferred image decoding.
This change reports the size as final only when the first frame is
encountered.
Added a test to verify this behavior. Frame size reported by the decoder
should be constant.
BUG=437651
[email protected], [email protected]
Review URL: https://codereview.chromium.org/813943003
git-svn-id: svn://svn.chromium.org/blink/trunk@188423 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | 4f9c9adef4036aff60b734b4a0045c43c320fe1d | chrome | bigvul | 1 | null | null | null |
Make TypingCommand::insertText() to take SelectionInDOMTree instead of VisibleSelection
This patch makes |TypingCommand::insertText()| to take |SelectionInDOMTree|
instead of |VisibleSelection| to reduce usage of |VisibleSelection| for
improving code health.
BUG=657237
TEST=n/a
Review-Url: https://codereview.chromium.org/2733183002
Cr-Commit-Position: refs/heads/master@{#455368} | a69c7b5d863dacbb08bfaa04359e3bc0bb4470dc | chrome | bigvul | 1 | null | null | null |
adds entry for AutofillCreditCardPopupLayout
BUG=664367
Review-Url: https://codereview.chromium.org/2671993004
Cr-Commit-Position: refs/heads/master@{#448082} | db2e0b4e38736f3898cedbdfc30e9cf0d099a45c | chrome | bigvul | 1 | null | null | null |
PermissionUtil::GetPermissionType needs to handle MIDI
After the recent PermissionManager's change, it calls
GetPermissionType even for CONTENT_SETTING_TYPE_MIDI.
BUG=697771
Review-Url: https://codereview.chromium.org/2730693002
Cr-Commit-Position: refs/heads/master@{#454231} | b0d271768d0a592227d753f4cf60399c4dd2af4f | chrome | bigvul | 1 | null | null | null |
[ios] Moves find-in-page code out of Tab and into FindTabHelper.
BUG=681867
Review-Url: https://codereview.chromium.org/2654433007
Cr-Commit-Position: refs/heads/master@{#449610} | b2bf3cb69cae29c1dc85f23a18f2f36587290c1e | chrome | bigvul | 1 | null | null | null |
Rename MostVisitedSites.MostVisitedURLsObserver to Observer.
BUG=677672
Review-Url: https://codereview.chromium.org/2697543002
Cr-Commit-Position: refs/heads/master@{#449958} | 5c6e9372daae557d6857f02888e84363eeff9be9 | chrome | bigvul | 1 | null | null | null |
[Field Trial] Update the testing config for AutofillCreditCardSigninPromo
EnabledThree is the chosen config for launch.
BUG=625310
Review-Url: https://codereview.chromium.org/2647293008
Cr-Commit-Position: refs/heads/master@{#446033} | a217c3919cd836eff52872b84c4e7e1605405748 | chrome | bigvul | 1 | null | null | null |
Suppress a WebGL2 flaky test on Linux AMD R7 240
conformance2/textures/image_bitmap_from_video/
tex-2d-rgba32f-rgba-float.html
BUG=701138
[email protected]
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2753643002
Cr-Commit-Position: refs/heads/master@{#456841} | 7f5d55a7e2e1ca2cdc10b3cd7e38685f87215584 | chrome | bigvul | 1 | null | null | null |
NTP: cap number of notifications/day
1 by default; Finch-configurable.
BUG=689465
Review-Url: https://codereview.chromium.org/2691023002
Cr-Commit-Position: refs/heads/master@{#450389} | 59512d1ea20d8e85555ecb743ee29ba90016656d | chrome | bigvul | 1 | null | null | null |
Roll HarfBuzz to 1.4.1
Includes support for specifying OpenType 1.8 font variations axis
parameters.
Baseline updates due to expected advance width differences for some
Khmer combining marks, as well as combining marks placement in
combination with ligatures, due to HarfBuzz commit 1a0f4aa6dfee69236b4.
BUG=679305
Review-Url: https://codereview.chromium.org/2622553002
Cr-Commit-Position: refs/heads/master@{#444707} | f2dc38825cce54c0b87841a420afbd71453d506b | chrome | bigvul | 1 | null | null | null |
Sanitize headers in Proxy Authentication Required responses
BUG=431504
Review URL: https://codereview.chromium.org/769043003
Cr-Commit-Position: refs/heads/master@{#310014} | 7933c117fd16b192e70609c331641e9112af5e42 | chrome | bigvul | 1 | null | null | null |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.