commit_msg
stringlengths 1
24.2k
| commit_hash
stringlengths 2
84
⌀ | project
stringlengths 2
40
| source
stringclasses 4
values | labels
int64 0
1
| repo_url
stringlengths 26
70
⌀ | commit_url
stringlengths 74
118
⌀ | commit_date
stringlengths 25
25
⌀ |
|---|---|---|---|---|---|---|---|
omnibox: Remove unregistered NOTIFICATION_BOOKMARK_MODEL_LOADED from action_box test.
BUG=144783
[email protected]
Review URL: https://chromiumcodereview.appspot.com/12038057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@178760 0039d316-1c4b-4281-b951-d872f2087c98 | d89d8abed92a7d6932ee3015a7ab77e16fc03d79 | chrome | bigvul | 1 | null | null | null |
Fix heap-use-after-free in BookmarksIOFunction::ShowSelectFileDialog.
BUG=177410
Review URL: https://chromiumcodereview.appspot.com/12326086
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184586 0039d316-1c4b-4281-b951-d872f2087c98 | 12baa2097220e33c12b60aa5e6da6701637761bf | chrome | bigvul | 1 | null | null | null |
Ensure extensions and the Chrome Web Store are loaded in new BrowsingInstances.
BUG=174943
TEST=Can't post message to CWS. See bug for repro steps.
Review URL: https://chromiumcodereview.appspot.com/12301013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184208 0039d316-1c4b-4281-b951-d872f2087c98 | e9841fbdaf41b4a2baaa413f94d5c0197f9261f4 | chrome | bigvul | 1 | null | null | null |
Revert cross-origin auth prompt blocking.
BUG=174129
Review URL: https://chromiumcodereview.appspot.com/12183030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181113 0039d316-1c4b-4281-b951-d872f2087c98 | 28aaa72a03df96fa1934876b0efbbc7e6b4b38af | chrome | bigvul | 1 | null | null | null |
Convert line endings of zoom-img-preserveAspectRatio-support-1.html to unix
BUG=345027
[email protected]
Review URL: https://codereview.chromium.org/211903002
git-svn-id: svn://svn.chromium.org/blink/trunk@169981 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | 14aeb712e033389cbb9d620754d7c59d625fc834 | chrome | bigvul | 1 | null | null | null |
Screen Orientation: use OrientationLockType enum for lockOrientation().
BUG=162827
Review URL: https://codereview.chromium.org/204653002
git-svn-id: svn://svn.chromium.org/blink/trunk@169972 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | a9ca2310c6e68ad8dc39d6b54ca9ea10867ed8a1 | chrome | bigvul | 1 | null | null | null |
Telemetry: Add more tests to the top_25 page set.
BUG=158323
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/11280184
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@169765 0039d316-1c4b-4281-b951-d872f2087c98 | fff23a24401ad0932f8c689c954b7f21478d30d0 | chrome | bigvul | 1 | null | null | null |
Check prefs before allowing extension file access in the permissions API.
[email protected]
BUG=169632
Review URL: https://chromiumcodereview.appspot.com/11884008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176853 0039d316-1c4b-4281-b951-d872f2087c98 | e21bdfb9c758ac411012ad84f83d26d3f7dd69fb | chrome | bigvul | 1 | null | null | null |
Do not pass URLs in onUpdated events to extensions unless they have the
"tabs" permission.
BUG=168442
Review URL: https://chromiumcodereview.appspot.com/11824004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176406 0039d316-1c4b-4281-b951-d872f2087c98 | f7ae1f7a918f1973dca241a7a23169906eaf4fe3 | chrome | bigvul | 1 | null | null | null |
Copy-paste preserves <embed> tags containing active content.
BUG=112325
Enable webkit preference for Chromium to disallow unsafe plugin pasting.
Review URL: https://chromiumcodereview.appspot.com/11884025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176856 0039d316-1c4b-4281-b951-d872f2087c98 | 52a30db57ecec68bb3b25fdc3de5e9bee7b80ed7 | chrome | bigvul | 1 | null | null | null |
Remove SpeechSynthesis runtime flag (status=stable)
BUG=402536
Review URL: https://codereview.chromium.org/482273005
git-svn-id: svn://svn.chromium.org/blink/trunk@180763 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | faceb51d5058e1159835a4b0cd65081bb0a9de1e | chrome | bigvul | 1 | null | null | null |
Fix the do-not-repaint-if-scrolling-composited-layers layout tests.
With https://codereview.chromium.org/303253004/, Glenn fixed the issue
that had prevented these layout tests from succeeding: that has-
block-selection-gaps-bounds depended on a paint in order to be valid.
With his CL, we know if we have selection gaps based solely on style
information. The test expectation had to be modified slightly due to a
harmless error related to contiguous selection (the selection in the
test is, in fact, contiguous).
BUG=353827
Review URL: https://codereview.chromium.org/353483003
git-svn-id: svn://svn.chromium.org/blink/trunk@176882 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | 4b230ee6f0d970dfd1166fe87c059fc1466fd79d | chrome | bigvul | 1 | null | null | null |
[refactor] Remove WEBCRYPTO_HAS_ERROR_TYPE ifdef.
BUG=245025
Review URL: https://codereview.chromium.org/259233003
git-svn-id: svn://svn.chromium.org/blink/trunk@172926 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | 0d173104d584327b12c2d091f9e5350ad304127c | chrome | bigvul | 1 | null | null | null |
Separate repaint and layout requirements of StyleDifference (Step 1)
Previously StyleDifference was an enum that proximately bigger values
imply smaller values (e.g. StyleDifferenceLayout implies
StyleDifferenceRepaint). This causes unnecessary repaints in some cases
on layout change.
Convert StyleDifference to a structure containing relatively independent
flags.
This change doesn't directly improve the result, but can make further
repaint optimizations possible.
Step 1 doesn't change any functionality. RenderStyle still generate the
legacy StyleDifference enum when comparing styles and convert the result
to the new StyleDifference. Implicit requirements are not handled during
the conversion.
Converted call sites to use the new StyleDifference according to the
following conversion rules:
- diff == StyleDifferenceEqual (&& !context) => diff.hasNoChange()
- diff == StyleDifferenceRepaint => diff.needsRepaintObjectOnly()
- diff == StyleDifferenceRepaintLayer => diff.needsRepaintLayer()
- diff == StyleDifferenceRepaint || diff == StyleDifferenceRepaintLayer => diff.needsRepaintLayer()
- diff >= StyleDifferenceRepaint => diff.needsRepaint() || diff.needsLayout()
- diff >= StyleDifferenceRepaintLayer => diff.needsRepaintLayer() || diff.needsLayout()
- diff > StyleDifferenceRepaintLayer => diff.needsLayout()
- diff == StyleDifferencePositionedMovementLayoutOnly => diff.needsPositionedMovementLayoutOnly()
- diff == StyleDifferenceLayout => diff.needsFullLayout()
BUG=358460
TEST=All existing layout tests.
[email protected], [email protected], [email protected]
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171983
Review URL: https://codereview.chromium.org/236203020
git-svn-id: svn://svn.chromium.org/blink/trunk@172331 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | b2b21468c1f7f08b30a7c1755316f6026c50eb2a | chrome | bigvul | 1 | null | null | null |
Add columns for count and size of live objects to "Allcations" view
Added "Live Count" and "Live Size" columns to the "Allocations" view. This allows to compare total amount of objects allocated by given function with the number of objects that are still live.
BUG=277984
[email protected]
Review URL: https://codereview.chromium.org/180533010
git-svn-id: svn://svn.chromium.org/blink/trunk@168982 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | 5039704ae2411c4b919dd72b4cbcf6ab7bb9ecd7 | chrome | bigvul | 1 | null | null | null |
Blink roll 174877:174895
http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=174878:174895&mode=html
[email protected],[email protected],[email protected]
BUG=
Review URL: https://codereview.chromium.org/303693003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273120 0039d316-1c4b-4281-b951-d872f2087c98 | 060a95fbd69b1cffab6670165dd8edffec5109c0 | chrome | bigvul | 1 | null | null | null |
DevTools: Fix removing folders from workspaces
BUG=373762
Review URL: https://codereview.chromium.org/288923009
git-svn-id: svn://svn.chromium.org/blink/trunk@174150 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | 133ed74d3e13d76903bbe511087119db49afdf9a | chrome | bigvul | 1 | null | null | null |
Check for appropriate bindings in process-per-site mode.
BUG=174059
TEST=See bug for repro steps.
Review URL: https://chromiumcodereview.appspot.com/12188025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181386 0039d316-1c4b-4281-b951-d872f2087c98 | c3efb8738ab59766c88855ad62c812af78490c04 | chrome | bigvul | 1 | null | null | null |
[content shell] reset the CWD after each layout test
BUG=111316
[email protected]
Review URL: https://codereview.chromium.org/11633017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173906 0039d316-1c4b-4281-b951-d872f2087c98 | 537abce1bcf7378e760e904d6e5540a02a2fca9f | chrome | bigvul | 1 | null | null | null |
Follow-on fixes and naming changes for https://codereview.chromium.org/12086077/
BUG=172573
Review URL: https://codereview.chromium.org/12177018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180600 0039d316-1c4b-4281-b951-d872f2087c98 | ac8bd041b81e46e4e4fcd5021aaa5499703952e6 | chrome | bigvul | 1 | null | null | null |
WebDatabase: check path traversal in origin_identifier
BUG=172264
Review URL: https://chromiumcodereview.appspot.com/12212091
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@183141 0039d316-1c4b-4281-b951-d872f2087c98 | ccfb891dc0c936a8806d663fe6581bf659761819 | chrome | bigvul | 1 | null | null | null |
Disable compositor thread input handling on windows
BUG=160122
Review URL: https://chromiumcodereview.appspot.com/11946019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@177369 0039d316-1c4b-4281-b951-d872f2087c98 | 70cff275010b33dbab628f837d76364359065b79 | chrome | bigvul | 1 | null | null | null |
Web Animations: Temporary fix for performance regression in transition tests
This patch adds a flag to Player::setStartTime to permit it to only call
update() instead of serviceAnimations() (as per previous behaviour). We
intend to in the near future replace the serviceAnimations calls with a
deferred timing update system. Note that update() here is not correct in
general as we may need to ask the timeline to request frame callbacks.
BUG=340511
Review URL: https://codereview.chromium.org/155303002
git-svn-id: svn://svn.chromium.org/blink/trunk@166473 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | 75f1a0ebf09d110642f19dd4e389004e949a7828 | chrome | bigvul | 1 | null | null | null |
Remove parent* arg from GDataEntry ctor.
* Remove static FromDocumentEntry from GDataEntry, GDataFile, GDataDirectory. Replace with InitFromDocumentEntry.
* Move common code from GDataFile::InitFromDocumentEntry and GDataDirectory::InitFromDocumentEntry to GDataEntry::InitFromDocumentEntry.
* Add GDataDirectoryService::FromDocumentEntry and use this everywhere.
* Make ctors of GDataFile, GDataDirectory private, so these must be created by GDataDirectoryService's CreateGDataFile and
CreateGDataDirectory. Make GDataEntry ctor protected.
BUG=141494
TEST=unit tests.
Review URL: https://chromiumcodereview.appspot.com/10854083
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151008 0039d316-1c4b-4281-b951-d872f2087c98 | dd3b6fe574edad231c01c78e4647a74c38dc4178 | chrome | bigvul | 1 | null | null | null |
Filter more incoming URLs in the CreateWindow path.
BUG=170532
Review URL: https://chromiumcodereview.appspot.com/12036002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@178728 0039d316-1c4b-4281-b951-d872f2087c98 | 7f48b71cb22bb2fc9fcec2013e9eaff55381a43d | chrome | bigvul | 1 | null | null | null |
Check the content setting type is valid.
BUG=169770
Review URL: https://codereview.chromium.org/11875013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176687 0039d316-1c4b-4281-b951-d872f2087c98 | 85f2fcc7b577362dd1def5895d60ea70d6e6b8d0 | chrome | bigvul | 1 | null | null | null |
Validate that paths don't contain embedded NULLs at deserialization.
BUG=166867
Review URL: https://chromiumcodereview.appspot.com/11743009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@174935 0039d316-1c4b-4281-b951-d872f2087c98 | 10cbaf017570ba6454174c55b844647aa6a9b3b4 | chrome | bigvul | 1 | null | null | null |
Avoids crash in WebRTC audio clients for 96kHz render rate on Mac OSX.
TBR=xians
BUG=166523
TEST=Misc set of WebRTC audio clients on Mac.
Review URL: https://codereview.chromium.org/11773017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175323 0039d316-1c4b-4281-b951-d872f2087c98 | f96f1f27d9bc16b1a045c4fb5c8a8a82f73ece59 | chrome | bigvul | 1 | null | null | null |
Generate version resources for Chrome Frame using the same machinery as Chrome itself.
Including generated files from within .rc files doesn't work since there's no dependency tracking going on.
BUG=155714
TEST=none
Review URL: https://chromiumcodereview.appspot.com/11147012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162494 0039d316-1c4b-4281-b951-d872f2087c98 | 06ea095ddbb86641d36383ba7f943888de05e747 | chrome | bigvul | 1 | null | null | null |
Beware of print-read inconsistency when serializing GURLs.
BUG=165622
Review URL: https://chromiumcodereview.appspot.com/11576038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173583 0039d316-1c4b-4281-b951-d872f2087c98 | 74aaa70032784e7cf00256821f29b2b53edb6589 | chrome | bigvul | 1 | null | null | null |
Add QuicStream and friends to QUIC code.
Fix bug in tests that caused failures.
Revert 165859
First Landed as 165858
Review URL: https://chromiumcodereview.appspot.com/11367082
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@165864 0039d316-1c4b-4281-b951-d872f2087c98 | 9c0b13574dc0ddeb502d7ed92ba10f7981da6736 | chrome | bigvul | 1 | null | null | null |
Remove TabContents from TabStripModelObserver::TabDetachedAt.
BUG=107201
TEST=no visible change
Review URL: https://chromiumcodereview.appspot.com/11293205
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167122 0039d316-1c4b-4281-b951-d872f2087c98 | e89cfcb9090e8c98129ae9160c513f504db74599 | chrome | bigvul | 1 | null | null | null |
Improve validation when creating audio streams.
BUG=166795
Review URL: https://codereview.chromium.org/11647012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173981 0039d316-1c4b-4281-b951-d872f2087c98 | 503bea2643350c6378de5f7a268b85cf2480e1ac | chrome | bigvul | 1 | null | null | null |
Delete apparently unused geolocation declarations and include.
BUG=336263
Review URL: https://codereview.chromium.org/139743014
git-svn-id: svn://svn.chromium.org/blink/trunk@165601 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | 8ea3a5c06218fa42d25c3aa0a4ab57153e178523 | chrome | bigvul | 1 | null | null | null |
Blink roll 165526:165538
http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=165527:165538&mode=html
TBR=
BUG=
Review URL: https://codereview.chromium.org/137953006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@246452 0039d316-1c4b-4281-b951-d872f2087c98 | 0d4b90f87d7ee602d6cfebf85a62c9019a2f9494 | chrome | bigvul | 1 | null | null | null |
Protect AudioRendererAlgorithm from invalid step sizes.
BUG=165430
TEST=unittests and asan pass.
Review URL: https://codereview.chromium.org/11573023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173249 0039d316-1c4b-4281-b951-d872f2087c98 | 802ecdb9cee0d66fe546bdf24e98150f8f716ad8 | chrome | bigvul | 1 | null | null | null |
Revert 164565 - sync: make scheduling logic and job ownership more obvious.
Revert Reason - see bug 158313
- inlines (and removes) SaveJob, to perform only the relevant "saving" bits
where needed. As it turns out, most of it was only necessary for ShouldRunJob
(which I'd like to rename, as it's destructive), and it's a lot easier to read
what's happening and why. Note also removed TODO at SaveJob callsites.
- inlines (and removes) InitOrCoalescePendingJob to perform only the relevant
bits at each callsite.
- pulls SyncSessionJob into a class, to handle basic responsibilities that need
the job Purpose + session (like "Succeeded()" and "Finish") that were previously
strewn about and partially copy/pasted in the scheduler.
- meticulously transfers ownership (removes linked_ptr usage!) of jobs instead
of making many implicit struct copies, as it resulted in non-obvious behavior.
To do this, ownership is given to the scheduling mechanism (the MessageLoop for
ScheduleSyncSessionJob, WaitInterval::timer for canary jobs), instead of jobs
sitting around without knowing whether they're scheduled or not. There are a
few cases where we can't actually "schedule" a job -- which wasn't even obvious
from the old code, and other interesting revelations, like fact that we were
actually pre-empt nudge canary jobs and "unscheduling" them in certain cases.
- removes DoPendingJobIfPossible, since it is no longer needed for
DoCanaryJob/Unthrottle cases, and make the behavior more explicit in the other
cases (mode-switch and SCM error change), see TakePendingJobForCurrentMode.
- removes the ability to create jobs as canary, since this wasn't needed and
was adding complexity (see DoCanaryJob / GrantCanaryPrivilege).
- removes retry_scheduled as it wasn't used anywhere
- adds lots of comments.
Also discovered that THROTTLED intervals seem to never fire a canary job with
today's code (broken), config jobs are immune to per-data-type throttling, and
the had_nudge allowance was defeated by extra IsBackingOff check in
ScheduleNudgeImpl (see comment on review).
BUG=
Review URL: https://chromiumcodereview.appspot.com/10917234
[email protected]
Review URL: https://codereview.chromium.org/11347027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@164780 0039d316-1c4b-4281-b951-d872f2087c98 | 592ca89ecd826dac82b837e5e2085d8c3cfbe22e | chrome | bigvul | 1 | null | null | null |
Fix integer overflow in Windows shared memory handling.
BUG=164490
Review URL: https://codereview.chromium.org/11450016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171369 0039d316-1c4b-4281-b951-d872f2087c98 | 935cb0dee7696d70880f96a71bf5687411bb8cb9 | chrome | bigvul | 1 | null | null | null |
Fix OS_MACOS typos. Should be OS_MACOSX.
BUG=163208
TEST=none
Review URL: https://codereview.chromium.org/12829005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@189130 0039d316-1c4b-4281-b951-d872f2087c98 | 0d7717faeaef5b72434632c95c78bee4883e2573 | chrome | bigvul | 1 | null | null | null |
Validate and report peer's PID to WorkerProcessIpcDelegate so it will be able to duplicate handles to and from the worker process.
As a side effect WorkerProcessLauncher::Delegate is now responsible for retrieving the client's PID and deciding whether a launch failed due to a permanent error condition.
BUG=134694
Review URL: https://chromiumcodereview.appspot.com/11143025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162778 0039d316-1c4b-4281-b951-d872f2087c98 | b15c87071f906301bccc824ce013966ca93998c7 | chrome | bigvul | 1 | null | null | null |
Simplify browser test for DNT
BUG=150771
Review URL: https://chromiumcodereview.appspot.com/11189056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162776 0039d316-1c4b-4281-b951-d872f2087c98 | 24950cb67304ad09ee05e32c3ffa5e07f52f0b8c | chrome | bigvul | 1 | null | null | null |
Revert 162155 "This review merges the two existing page serializ..."
Change r162155 broke the world even though it was landed using the CQ.
> This review merges the two existing page serializers, WebPageSerializerImpl and
> PageSerializer, into one, PageSerializer. In addition to this it moves all
> the old tests from WebPageNewSerializerTest and WebPageSerializerTest to the
> PageSerializerTest structure and splits out one test for MHTML into a new
> MHTMLTest file.
>
> Saving as 'Webpage, Complete', 'Webpage, HTML Only' and as MHTML when the
> 'Save Page as MHTML' flag is enabled now uses the same code, and should thus
> have the same feature set. Meaning that both modes now should be a bit better.
>
> Detailed list of changes:
>
> - PageSerializerTest: Prepare for more DTD test
> - PageSerializerTest: Remove now unneccesary input image test
> - PageSerializerTest: Remove unused WebPageSerializer/Impl code
> - PageSerializerTest: Move data URI morph test
> - PageSerializerTest: Move data URI test
> - PageSerializerTest: Move namespace test
> - PageSerializerTest: Move SVG Image test
> - MHTMLTest: Move MHTML specific test to own test file
> - PageSerializerTest: Delete duplicate XML header test
> - PageSerializerTest: Move blank frame test
> - PageSerializerTest: Move CSS test
> - PageSerializerTest: Add frameset/frame test
> - PageSerializerTest: Move old iframe test
> - PageSerializerTest: Move old elements test
> - Use PageSerizer for saving web pages
> - PageSerializerTest: Test for rewriting links
> - PageSerializer: Add rewrite link accumulator
> - PageSerializer: Serialize images in iframes/frames src
> - PageSerializer: XHTML fix for meta tags
> - PageSerializer: Add presentation CSS
> - PageSerializer: Rename out parameter
>
> BUG=
> [email protected]
>
> Review URL: https://codereview.chromium.org/68613003
[email protected]
Review URL: https://codereview.chromium.org/73673003
git-svn-id: svn://svn.chromium.org/blink/trunk@162156 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | 7f0126ff011142c8619b10a6e64d04d1745c503a | chrome | bigvul | 1 | null | null | null |
Remove the Simple Default Stylesheet, it's just a foot-gun.
We've been bitten by the Simple Default Stylesheet being out
of sync with the real html.css twice this week.
The Simple Default Stylesheet was invented years ago for Mac:
http://trac.webkit.org/changeset/36135
It nicely handles the case where you just want to create
a single WebView and parse some simple HTML either without
styling said HTML, or only to display a small string, etc.
Note that this optimization/complexity *only* helps for the
very first document, since the default stylesheets are
all static (process-global) variables. Since any real page
on the internet uses a tag not covered by the simple default
stylesheet, not real load benefits from this optimization.
Only uses of WebView which were just rendering small bits
of text might have benefited from this. about:blank would
also have used this sheet.
This was a common application for some uses of WebView back
in those days. These days, even with WebView on Android,
there are likely much larger overheads than parsing the
html.css stylesheet, so making it required seems like the
right tradeoff of code-simplicity for this case.
BUG=319556
Review URL: https://codereview.chromium.org/73723005
git-svn-id: svn://svn.chromium.org/blink/trunk@162153 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | 4d17163f4b66be517dc49019a029e5ddbd45078c | chrome | bigvul | 1 | null | null | null |
File permission fix: now we selectively grant read permission for Sandboxed files
We also need to check the read permission and call GrantReadFile() for
sandboxed files for CreateSnapshotFile().
BUG=162114
TEST=manual
Review URL: https://codereview.chromium.org/11280231
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170181 0039d316-1c4b-4281-b951-d872f2087c98 | d123966ec156cd2f92fdada36be39694641b479e | chrome | bigvul | 1 | null | null | null |
Verify lfFaceName is NUL terminated in IPC deserializer.
BUG=162066
Review URL: https://chromiumcodereview.appspot.com/11416115
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@168937 0039d316-1c4b-4281-b951-d872f2087c98 | 2e02cfe89cbffc8a0bc1bdaee9efe930fd55e376 | chrome | bigvul | 1 | null | null | null |
DevTools: show message informing about required reload for some device emulation features.
BUG=316608
Review URL: https://codereview.chromium.org/66683003
git-svn-id: svn://svn.chromium.org/blink/trunk@161836 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | c4f2483763d274de352768cbec9dfad705b62059 | chrome | bigvul | 1 | null | null | null |
Remove now-passing test from expectations.
TBR=eae
BUG=231880
Review URL: https://codereview.chromium.org/37653002
git-svn-id: svn://svn.chromium.org/blink/trunk@160380 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | 879f876e7a00026dde58e3a49886ea79b6ff18ee | chrome | bigvul | 1 | null | null | null |
Blink roll 154375:154485
http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=154376:154485&mode=html
TBR=
BUG=
Review URL: https://codereview.chromium.org/19672005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212333 0039d316-1c4b-4281-b951-d872f2087c98 | dd1bb8f7923aef4307eac04e4839bde50f815a9e | chrome | bigvul | 1 | null | null | null |
DevTools: Update LiveLocations whenever Sass UISourceCodes are added
BUG=260226
[email protected]
Review URL: https://codereview.chromium.org/19173002
git-svn-id: svn://svn.chromium.org/blink/trunk@154283 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | ba4bc023d7c3328cf8c6a6da6b5c4ba88f7bf5a7 | chrome | bigvul | 1 | null | null | null |
Don't retain reference to ChromeGeolocationPermissionContext
ChromeGeolocationPermissionContext owns
GeolocationInfoBarQueueController, so make sure that the callback
passed to GeolocationInfoBarQueueController doesn't increase the
reference count on ChromeGeolocationPermissionContext (which
https://chromiumcodereview.appspot.com/11072012 accidentally does).
TBR=bulach
BUG=152921
TEST=unittest:chrome_geolocation_permission_context on memory.fyi bot
Review URL: https://chromiumcodereview.appspot.com/11087030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@160881 0039d316-1c4b-4281-b951-d872f2087c98 | 8c7c42f5cd3d3cab81fad08b1159106184fa0c47 | chrome | bigvul | 1 | null | null | null |
Progressive JPEG outputScanlines() calls should handle failure
outputScanlines() can fail and delete |this|, so any attempt to access
members thereafter should be avoided. Copy the decoder pointer member,
and use that copy to detect and handle the failure case.
BUG=232763
[email protected]
Review URL: https://codereview.chromium.org/14844003
git-svn-id: svn://svn.chromium.org/blink/trunk@150545 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | f7038db6ef172459f14b1b67a5155b8dd210be0f | chrome | bigvul | 1 | null | null | null |
[BlackBerry] GraphicsLayer: rename notifySyncRequired to notifyFlushRequired
https://bugs.webkit.org/show_bug.cgi?id=111997
Patch by Alberto Garcia <[email protected]> on 2013-03-11
Reviewed by Rob Buis.
This changed in r130439 but the old name was introduced again by
mistake in r144465.
* platform/graphics/blackberry/GraphicsLayerBlackBerry.h:
(WebCore::GraphicsLayerBlackBerry::notifyFlushRequired):
* platform/graphics/blackberry/LayerWebKitThread.cpp:
(WebCore::LayerWebKitThread::setNeedsCommit):
git-svn-id: svn://svn.chromium.org/blink/trunk@145363 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | d333e22282bd4bdaa2864980cd45c272f206a44c | chrome | bigvul | 1 | null | null | null |
Make shared memory segments writable only by their rightful owners.
BUG=143859
TEST=Chrome's UI still works on Linux and Chrome OS
Review URL: https://chromiumcodereview.appspot.com/10854242
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158289 0039d316-1c4b-4281-b951-d872f2087c98 | 0bd1a6ddb5fb23dfea3e72d60e5e8df4cf5826bc | chrome | bigvul | 1 | null | null | null |
Rename BaseClickableWithKeyInputType.{cpp,h} to KeyboardClickableInputTypeView.{cpp,h}
This CL has no behavior changes.
BUG=243714
Review URL: https://codereview.chromium.org/1921213002
Cr-Commit-Position: refs/heads/master@{#389734} | 02973649bf72b15c31a96c558466b2b41a9a472e | chrome | bigvul | 1 | null | null | null |
Create Test Expectation lines automatically from failing test results.
BUG=625254
Review-Url: https://codereview.chromium.org/2136723002
Cr-Commit-Position: refs/heads/master@{#406868} | 22c2cad13b358a133ae399532ce910c1ebb96073 | chrome | bigvul | 1 | null | null | null |
binding: Removes unused code in templates/attributes.cpp.
Faking {{cpp_class}} and {{c8_class}} doesn't make sense.
Probably it made sense before the introduction of virtual
ScriptWrappable::wrap().
Checking the existence of window->document() doesn't seem
making sense to me, and CQ tests seem passing without the
check.
BUG=
Review-Url: https://codereview.chromium.org/2268433002
Cr-Commit-Position: refs/heads/master@{#413375} | 7a6d81a8544c595331b50a17f8c0b11feca2f029 | chrome | bigvul | 1 | null | null | null |
Sysroot: Update install-sysroot.py
And minor fixes
BUG=638394
Review-Url: https://codereview.chromium.org/2277633002
Cr-Commit-Position: refs/heads/master@{#414504} | fda138a9b26e5edd158f2b33155827f14649bd5e | chrome | bigvul | 1 | null | null | null |
Drive out additional flakiness of TouchAction browser test.
It is relatively stable but it has flaked a couple of times specifically
with this:
Actual: 44
Expected: distance.y()
Which is: 45
I presume that the failure is either we aren't waiting for the additional
frame or a subpixel scrolling problem. As a speculative fix wait for the
pixel item we are waiting to scroll for.
BUG=376668
Review-Url: https://codereview.chromium.org/2281613002
Cr-Commit-Position: refs/heads/master@{#414525} | 137458c8680c51fe9d3984ded2ef50a45a667b8b | chrome | bigvul | 1 | null | null | null |
Replace fixed string uses of AddHeaderFromString
Uses of AddHeaderFromString() with a static string may as well be
replaced with SetHeader(). Do so.
BUG=None
Review-Url: https://codereview.chromium.org/2236933005
Cr-Commit-Position: refs/heads/master@{#418161} | 9965adea952e84c925de418e971b204dfda7d6e0 | chrome | bigvul | 1 | null | null | null |
Add ThreadChecker for Ozone X11 GPU.
Ensure Ozone X11 tests the same thread constraints we have in Ozone GBM.
BUG=none
Review-Url: https://codereview.chromium.org/2366643002
Cr-Commit-Position: refs/heads/master@{#421817} | 0d77de2f5334b6d560487c5fd696178a3bfc3551 | chrome | bigvul | 1 | null | null | null |
Pepper: Access PepperMediaDeviceManager through a WeakPtr
Its lifetime is scoped to the RenderFrame, and it might go away before the
hosts that refer to it.
BUG=423030
Review URL: https://codereview.chromium.org/653243003
Cr-Commit-Position: refs/heads/master@{#299897} | 3a2cf7d1376ae33054b878232fb38b8fbed29e31 | chrome | bigvul | 1 | null | null | null |
DevTools: continue recording network activity after load
BUG=569557
Review-Url: https://codereview.chromium.org/2392553003
Cr-Commit-Position: refs/heads/master@{#423703} | dd84f83120d1ea13b61d3551f6b8134dde933f5d | chrome | bigvul | 1 | null | null | null |
Tests for CL 647933003.
BUG=424453
Review URL: https://codereview.chromium.org/653283007
Cr-Commit-Position: refs/heads/master@{#302374} | bed415634f57baf1e74d94d133b251fab330919e | chrome | bigvul | 1 | null | null | null |
Add extra checks to avoid integer overflow.
BUG=425980
TEST=no crash with ASAN
Review URL: https://codereview.chromium.org/659743004
Cr-Commit-Position: refs/heads/master@{#301249} | b2006ac87cec58363090e7d5e10d5d9e3bbda9f9 | chrome | bigvul | 1 | null | null | null |
DocumentThreadableLoader: Add guards for sync notifyFinished() in setResource()
In loadRequest(), setResource() can call clear() synchronously:
DocumentThreadableLoader::clear()
DocumentThreadableLoader::handleError()
Resource::didAddClient()
RawResource::didAddClient()
and thus |m_client| can be null while resource() isn't null after setResource(),
causing crashes (Issue 595964).
This CL checks whether |*this| is destructed and
whether |m_client| is null after setResource().
BUG=595964
Review-Url: https://codereview.chromium.org/1902683002
Cr-Commit-Position: refs/heads/master@{#391001} | 2571533bbb5b554ff47205c8ef1513ccc0817c3e | chrome | bigvul | 1 | null | null | null |
WPT: Request to import domparsing, domxpath, and innerText.
BUG=651752, 651757, 573309
NOTRY=true
Review-Url: https://codereview.chromium.org/2516983003
Cr-Commit-Position: refs/heads/master@{#433500} | 63d26d050ffc4707fabaef0cac4206f8118cea45 | chrome | bigvul | 1 | null | null | null |
sync compositor: pass simple gfx types by const ref
See bug for reasoning
BUG=159273
Review URL: https://codereview.chromium.org/1417893006
Cr-Commit-Position: refs/heads/master@{#356653} | 6d9425ec7badda912555d46ea7abcfab81fdd9b9 | chrome | bigvul | 1 | null | null | null |
Enable MB for the 'precise64' bot on the official.desktop master.
[email protected]
[email protected]
BUG=554999
Review URL: https://codereview.chromium.org/1433353008 .
Cr-Commit-Position: refs/heads/master@{#359454} | 207da960337041d9eff123ad31d537e175288829 | chrome | bigvul | 1 | null | null | null |
Rename the ANGLE test spec to match the new master name.
BUG=504872
Review URL: https://codereview.chromium.org/1313883007
Cr-Commit-Position: refs/heads/master@{#346192} | d2c76fcea781690c2ffe6c03ee5aa313e45b275d | chrome | bigvul | 1 | null | null | null |
Add MIPS version of YIELD_PROCESSOR in a arch-independent way.
Also adds CPU(MIPS), CPU(MIPS64) to CPU.h
BUG=564657
Review URL: https://codereview.chromium.org/1501533004
Cr-Commit-Position: refs/heads/master@{#364065} | 63d2b3e07e7487d8b2435d14c4148097fa1b13ca | chrome | bigvul | 1 | null | null | null |
Allow the cast tray to function as expected when the installed extension is missing API methods.
BUG=489445
Review URL: https://codereview.chromium.org/1145833003
Cr-Commit-Position: refs/heads/master@{#330663} | 1924f747637265f563892b8f56a64391f6208194 | chrome | bigvul | 1 | null | null | null |
Do not attempt to open a channel to a plugin in Plugin Data Remover if there are no plugins available.
BUG=485886
Review URL: https://codereview.chromium.org/1144353003
Cr-Commit-Position: refs/heads/master@{#331168} | 2327c7044eeabc2e70700ff7f752e4b2e2978657 | chrome | bigvul | 1 | null | null | null |
Notification actions may have an icon url.
This is behind a runtime flag for two reasons:
* The implementation is incomplete.
* We're still evaluating the API design.
Intent to Implement and Ship: Notification Action Icons
https://groups.google.com/a/chromium.org/d/msg/blink-dev/IM0HxOP7HOA/y8tu6iq1CgAJ
BUG=581336
Review URL: https://codereview.chromium.org/1644573002
Cr-Commit-Position: refs/heads/master@{#374649} | 4a3e17c874bc4c4c90e5b0f8ec568520964695d4 | chrome | bigvul | 1 | null | null | null |
Remove base/move.h
It's the same thing as DISALLOW_COPY_AND_ASSIGN now anyway.
BUG=566182
Committed: https://crrev.com/bb5161ab7ad524a9bced788f8099e786946f3a44
Review-Url: https://codereview.chromium.org/2038273002
Cr-Original-Commit-Position: refs/heads/master@{#398237}
Cr-Commit-Position: refs/heads/master@{#398384} | 1a2fd6cd9275d2fdd909c2f867ae57744bfa4e49 | chrome | bigvul | 1 | null | null | null |
Hide sections by default in settings browser tests
BUG=none
[email protected]
Review-Url: https://codereview.chromium.org/2073073004
Cr-Commit-Position: refs/heads/master@{#400476} | 69d556efff99f5d4d218d3fdb0b5d498b4c0a588 | chrome | bigvul | 1 | null | null | null |
Defer call to updateWidgetPositions() outside of RenderLayerScrollableArea.
updateWidgetPositions() can destroy the render tree, so it should never
be called from inside RenderLayerScrollableArea. Leaving it there allows
for the potential of use-after-free bugs.
BUG=402407
[email protected]
Review URL: https://codereview.chromium.org/490473003
git-svn-id: svn://svn.chromium.org/blink/trunk@180681 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | 11a4cc4a6d6e665d9a118fada4b7c658d6f70d95 | chrome | bigvul | 1 | null | null | null |
[Third Party] Add ow2-asm jars to Chromium.
These jars are dependencies for Robolectric 3.0.
BUG=522043
Review-Url: https://codereview.chromium.org/2049563002
Cr-Commit-Position: refs/heads/master@{#403276} | 0466de340a7a064c46bff03dbf2da2024342de32 | chrome | bigvul | 1 | null | null | null |
Bind key for toggleBrailleCaptions
BUG=617668
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2066633002
Cr-Commit-Position: refs/heads/master@{#399655} | ae57a55d4e10ca7d613cbdfceaf834b64dfe9c7d | chrome | bigvul | 1 | null | null | null |
exo: Reduce side-effects of dynamic activation code.
This code exists for clients that need to managed their own system
modal dialogs. Since the addition of the remote surface API we
can limit the impact of this to surfaces created for system modal
container.
BUG=29528396
Review-Url: https://codereview.chromium.org/2084023003
Cr-Commit-Position: refs/heads/master@{#401115} | 05c619eb6e7dac046afc72c0d5381856f87fb421 | chrome | bigvul | 1 | null | null | null |
Add text-combine-upright-compression-007.html into TestExpectations and LeakExpectations
BUG=594309,553838
TBR=cbiesinger
Review-Url: https://codereview.chromium.org/2115773002
Cr-Commit-Position: refs/heads/master@{#403409} | 183615d125816b996710f8aa282c42bdeb73168e | chrome | bigvul | 1 | null | null | null |
[Sync] Android: test that opening sync settings doesn't start backend.
BUG=480604
Review URL: https://codereview.chromium.org/1223163002
Cr-Commit-Position: refs/heads/master@{#338538} | fa16e7990bcbe4c1234bc62df0330f8bcece07fe | chrome | bigvul | 1 | null | null | null |
Saved addresses and credit cards can be removed from md-settings.
BUG=607348,607347
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2008273003
Cr-Commit-Position: refs/heads/master@{#396544} | ea2730123956cc7cd538919573330f7c3dccb493 | chrome | bigvul | 1 | null | null | null |
Let PDFium handle event when there is not yet a visible page.
Speculative fix for 415307. CF will confirm.
The stack trace for that bug indicates an attempt to index by -1, which is consistent with no visible page.
BUG=415307
Review URL: https://codereview.chromium.org/560133004
Cr-Commit-Position: refs/heads/master@{#295421} | 9b04ffd8e7a07e9b2947fe5b71acf85dff38a63f | chrome | bigvul | 1 | null | null | null |
Fix expectations for debian deps.
The change is due to launching LTO ([1], [2]) on Linux, which eliminated
some of the unused symbols deps, thus decreasing the effective version
of libdbus-1-3 Chrome depends on.
BUG=453195
[1] http://llvm.org/docs/LinkTimeOptimization.html
[2] https://codereview.chromium.org/2003733004
(actually try bots had run; the line below is to bypass a slow flaky bot)
NOTRY=true
Review-Url: https://codereview.chromium.org/2003143002
Cr-Commit-Position: refs/heads/master@{#395411} | 0fe758fd6d99cadd1a533018e5ccce602a8b6cd5 | chrome | bigvul | 1 | null | null | null |
[Contextual Search] Change "Now on Tap" to "Contextual Cards"
BUG=644934
Review-Url: https://codereview.chromium.org/2361163003
Cr-Commit-Position: refs/heads/master@{#420899} | c0947dabeaa10da67798c1bbc668dca4b280cad5 | chrome | bigvul | 1 | null | null | null |
Roll WebGL 3d0e045..2e13422
https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/3d0e045..2e13422
BUG=
TEST=bots
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2310243003
Cr-Commit-Position: refs/heads/master@{#417329} | 4fa6dcdc7ef0f0bf608a40a4c3d01eca5a724142 | chrome | bigvul | 1 | null | null | null |
Flip 'Google Chrome Mac' builder on chromium.chrome back to GYP.
Looks like dump_syms is broken ...
[email protected], [email protected]
NOTRY=true
BUG=622406
Review-Url: https://codereview.chromium.org/2083383004
Cr-Commit-Position: refs/heads/master@{#401362} | 2daffdccc85520a52ddfaaf8739b3d08517ff1a9 | chrome | bigvul | 1 | null | null | null |
Remove blink::ReadableStream
This CL removes two stable runtime enabled flags
- ResponseConstructedWithReadableStream
- ResponseBodyWithV8ExtraStream
and related code including blink::ReadableStream.
BUG=613435
Review-Url: https://codereview.chromium.org/2227403002
Cr-Commit-Position: refs/heads/master@{#411014} | d800220da9f744779f1989e2092c88770adcd20a | chrome | bigvul | 1 | null | null | null |
ozone: fix crash when running video decode unittests.
In GLSurfaceOzoneSurfacelessSurfaceImpl::Destroy, if the previous
context was NULL, do not make it current.
BUG=chromium:602921
TEST=Run vda unittests on oak.
Review URL: https://codereview.chromium.org/1887563002
Cr-Commit-Position: refs/heads/master@{#386988} | 2f663de43634c1197a7a2ed8afc12cb6dc565bd0 | chrome | bigvul | 1 | null | null | null |
SVG: Moving animating <svg> to other iframe should not crash.
Moving SVGSVGElement with its SMILTimeContainer already started caused crash before this patch.
|SVGDocumentExtentions::startAnimations()| calls begin() against all SMILTimeContainers in the document, but the SMILTimeContainer for <svg> moved from other document may be already started.
BUG=369860
Review URL: https://codereview.chromium.org/290353002
git-svn-id: svn://svn.chromium.org/blink/trunk@174338 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | f592cf6a66b63decc7e7093b36501229a5de1f1d | chrome | bigvul | 1 | null | null | null |
[Extensions UI Mac] Fix a bug with popped out actions' highlighted state
Fix a bug where popped out actions wouldn't clear their highlighted
state and add a couple of tests to protect against regression.
BUG=601249
Review URL: https://codereview.chromium.org/1888133002
Cr-Commit-Position: refs/heads/master@{#387389} | e3a55f8fe3980f561aaba28e1a593d7ad020653b | chrome | bigvul | 1 | null | null | null |
Don't allow null bytes in hosts of host permissions.
BUG=390624
TEST=Load the sample manifest from the bug, comment #9. It should fail to load.
Review URL: https://codereview.chromium.org/416263002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285492 0039d316-1c4b-4281-b951-d872f2087c98 | 80d5aa4a1de9107d1442480b8ea9ba06feff2be2 | chrome | bigvul | 1 | null | null | null |
Replace further questionable HashMap::add usages in bindings
BUG=390928
[email protected]
Review URL: https://codereview.chromium.org/411273002
git-svn-id: svn://svn.chromium.org/blink/trunk@178823 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | d10a8dac48d3a9467e81c62cb45208344f4542db | chrome | bigvul | 1 | null | null | null |
Have the Debugger extension api check that it has access to the tab
Check PermissionsData::CanAccessTab() prior to attaching the debugger.
BUG=367567
Review URL: https://codereview.chromium.org/352523003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280354 0039d316-1c4b-4281-b951-d872f2087c98 | 684a212a93141908bcc10f4bc57f3edb53d2d21f | chrome | bigvul | 1 | null | null | null |
Framebuffer clear() needs to consider the situation some draw buffers are disabled.
This is when we expose DrawBuffers extension.
BUG=376951
TEST=the attached test case, webgl conformance
[email protected],[email protected]
Review URL: https://codereview.chromium.org/315283002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275338 0039d316-1c4b-4281-b951-d872f2087c98 | ee7579229ff7e9e5ae28bf53aea069251499d7da | chrome | bigvul | 1 | null | null | null |
Initialize value since calculateFinalValues may fail to do so.
Fix threading issue where updateCoefficientsIfNecessary was not always
called from the audio thread. This causes the value not to be
initialized.
Thus,
o Initialize the variable to some value, just in case.
o Split updateCoefficientsIfNecessary into two functions with the code
that sets the coefficients pulled out in to the new function
updateCoefficients.
o Simplify updateCoefficientsIfNecessary since useSmoothing was always
true, and forceUpdate is not longer needed.
o Add process lock to prevent the audio thread from updating the
coefficients while they are being read in the main thread. The audio
thread will update them the next time around.
o Make getFrequencyResponse set the lock while reading the
coefficients of the biquad in preparation for computing the
frequency response.
BUG=389219
Review URL: https://codereview.chromium.org/354213002
git-svn-id: svn://svn.chromium.org/blink/trunk@177250 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | c391f54a210dd792f140650b886e92480d8eaf9e | chrome | bigvul | 1 | null | null | null |
Remove clock resolution page load histograms.
These were temporary metrics intended to understand whether high/low
resolution clocks adversely impact page load metrics. After collecting a few
months of data it was determined that clock resolution doesn't adversely
impact our metrics, and it that these histograms were no longer needed.
BUG=394757
Review-Url: https://codereview.chromium.org/2155143003
Cr-Commit-Position: refs/heads/master@{#406143} | 4843d98517bd37e5940cd04627c6cfd2ac774d11 | chrome | bigvul | 1 | null | null | null |
Log extra information when the SSL handshake completes.
I've gotten pretty good at extracting this from the logs when there is
data associated with it, but it's kind of silly to have to do that.
BUG=484695
Review-Url: https://codereview.chromium.org/1928713002
Cr-Commit-Position: refs/heads/master@{#390174} | 281d13f018a313672f4117971bf03986de99b481 | chrome | bigvul | 1 | null | null | null |
Deflake inspector/layers/layer-compositing-reasons.html
BUG=618693
Review-Url: https://codereview.chromium.org/2048133004
Cr-Commit-Position: refs/heads/master@{#398925} | 6f680f548f24b12a47c17f0701545a1b2dfb7ae2 | chrome | bigvul | 1 | null | null | null |
Avoid using forced layout to trigger paint invalidation for SVG containers
Currently, SVG containers in the LayoutObject hierarchy force layout of
their children if the transform changes. The main reason for this is to
trigger paint invalidation of the subtree. In some cases - changes to the
scale factor - there are other reasons to trigger layout, like computing
a new scale factor for <text> or re-layout nodes with non-scaling stroke.
Compute a "scale-factor change" in addition to the "transform change"
already computed, then use this new signal to determine if layout should
be forced for the subtree. Trigger paint invalidation using the
LayoutObject flags instead.
The downside to this is that paint invalidation will walk into "hidden"
containers which rarely require repaint (since they are not technically
visible). This will hopefully be rectified in a follow-up CL.
For the testcase from 603850, this essentially eliminates the cost of
layout (from ~350ms to ~0ms on authors machine; layout cost is related
to text metrics recalculation), bumping frame rate significantly.
BUG=603956,603850
Review-Url: https://codereview.chromium.org/1996543002
Cr-Commit-Position: refs/heads/master@{#400950} | 44f1431b20c16d8f8da0ce8ff7bbf2adddcdd785 | chrome | bigvul | 1 | null | null | null |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.