commit_msg
stringlengths 1
24.2k
| commit_hash
stringlengths 2
84
⌀ | project
stringlengths 2
40
| source
stringclasses 4
values | labels
int64 0
1
| repo_url
stringlengths 26
70
⌀ | commit_url
stringlengths 74
118
⌀ | commit_date
stringlengths 25
25
⌀ |
|---|---|---|---|---|---|---|---|
[BlackBerry] Enable scoped style for BlackBerry.
https://bugs.webkit.org/show_bug.cgi?id=90418
Reviewed by Rob Buis.
.:
* Source/cmake/OptionsBlackBerry.cmake:
* Source/cmakeconfig.h.cmake:
Tools:
* Scripts/webkitperl/FeatureList.pm:
git-svn-id: svn://svn.chromium.org/blink/trunk@121726 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | 91a3a6fd03fb2427c9f3f3844137cfa955c80c01 | chrome | bigvul | 1 | null | null | null |
aura: Disable clipboard tests until aura has clipboard support.
BUG=97845
TEST=gfx_unittests
Review URL: http://codereview.chromium.org/8342050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106413 0039d316-1c4b-4281-b951-d872f2087c98 | 15fff4ca66b57004289d7a8f4de72a93526717b0 | chrome | bigvul | 1 | null | null | null |
Introduce background.scripts feature for extension manifests.
This optimizes for the common use case where background pages
just include a reference to one or more script files and no
additional HTML.
BUG=107791
Review URL: http://codereview.chromium.org/9150008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117110 0039d316-1c4b-4281-b951-d872f2087c98 | a03d4448faf2c40f4ef444a88cb9aace5b98e8c4 | chrome | bigvul | 1 | null | null | null |
Webkit roll 121899:122095
TBR=
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com/10692121
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145648 0039d316-1c4b-4281-b951-d872f2087c98 | a949d58cb45fad8852c1a96b31913d45c520de12 | chrome | bigvul | 1 | null | null | null |
Use XFixes to update the clipboard sequence number.
BUG=73478
TEST=manual testing
Review URL: http://codereview.chromium.org/8501002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109528 0039d316-1c4b-4281-b951-d872f2087c98 | 1a828911013ff501b87aacc5b555e470b31f2909 | chrome | bigvul | 1 | null | null | null |
Trivial ppapi/c headers changes
Trivial changes to C headers for consistency with generated code
prior to throwing the switch.
TEST= tryserver
BUG= http://code.google.com/p/chromium/issues/detail?id=76271
Review URL: http://codereview.chromium.org/7360008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92550 0039d316-1c4b-4281-b951-d872f2087c98 | c7eb5178d897f48850fe8ba8ee7a5b4095825095 | chrome | bigvul | 1 | null | null | null |
[V8] Remove unused methods in V8Proxy
https://bugs.webkit.org/show_bug.cgi?id=93106
Reviewed by Adam Barth.
In preparation for removing V8Proxy, we can remove unused methods in V8Proxy.
No tests. No change in behavior.
* bindings/v8/V8Proxy.h:
(V8Proxy):
git-svn-id: svn://svn.chromium.org/blink/trunk@124630 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | 4c69e5e58bdf8717140328e5528325af56e7211e | chrome | bigvul | 1 | null | null | null |
[Qt] Remove an unnecessary masking from swapBgrToRgb()
https://bugs.webkit.org/show_bug.cgi?id=103630
Reviewed by Zoltan Herczeg.
Get rid of a masking command in swapBgrToRgb() to speed up a little bit.
* platform/graphics/qt/GraphicsContext3DQt.cpp:
(WebCore::swapBgrToRgb):
git-svn-id: svn://svn.chromium.org/blink/trunk@136375 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | 04915c26ea193247b8a29aa24bfa34578ef5d39e | chrome | bigvul | 1 | null | null | null |
Adding missing browser/ui/views/find_bar_host_aura.cc
[email protected]
BUG=97131
TEST=none
Review URL: http://codereview.chromium.org/8136026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104056 0039d316-1c4b-4281-b951-d872f2087c98 | dd56d3c6adf5abba717a6868dde0e13de74d0af6 | chrome | bigvul | 1 | null | null | null |
Fix uninitialized variables in HarfBuzzShaperBase
https://bugs.webkit.org/show_bug.cgi?id=79546
Reviewed by Dirk Pranke.
These were introduced in r108733.
* platform/graphics/harfbuzz/HarfBuzzShaperBase.cpp:
(WebCore::HarfBuzzShaperBase::HarfBuzzShaperBase):
git-svn-id: svn://svn.chromium.org/blink/trunk@108871 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | b712795852f9d6073e062680e280634290c4ba5d | chrome | bigvul | 1 | null | null | null |
Implement methods for pairing of bluetooth devices.
BUG=chromium:100392,chromium:102139
TEST=
Review URL: http://codereview.chromium.org/8495018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109094 0039d316-1c4b-4281-b951-d872f2087c98 | 0a38f71865b63025dce4de1f8cca71979c48d14d | chrome | bigvul | 1 | null | null | null |
Change omnibox behavior when stripping javascript schema to navigate after stripping the schema on drag drop.
BUG=109245
TEST=N/A
Review URL: http://codereview.chromium.org/9116016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116692 0039d316-1c4b-4281-b951-d872f2087c98 | 0c14577c9905bd8161159ec7eaac810c594508d0 | chrome | bigvul | 1 | null | null | null |
Fix null deref when walking cert chain.
BUG=109664
TEST=N/A
Review URL: http://codereview.chromium.org/9150013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117080 0039d316-1c4b-4281-b951-d872f2087c98 | 7352baf29ac44d23cd580c2edfa8faf4e140a480 | chrome | bigvul | 1 | null | null | null |
return early from ProcessRawBytesWithSeperators() when data length is 0
BUG=109717
TEST=N/A
Review URL: http://codereview.chromium.org/9169028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117241 0039d316-1c4b-4281-b951-d872f2087c98 | 76e6e7c63aaa8e30e4143b8db9fc7d754812e718 | chrome | bigvul | 1 | null | null | null |
[chromium] Remove an obsolete comment about features.gypi
https://bugs.webkit.org/show_bug.cgi?id=76643
There can be only one features.gypi.
Reviewed by James Robinson.
* JavaScriptCore.gyp/JavaScriptCore.gyp:
git-svn-id: svn://svn.chromium.org/blink/trunk@105459 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | 98fb7de43d5e3e597afb35b6335cf72e9d962bdd | chrome | bigvul | 1 | null | null | null |
Roll over ICU to 113543
Fix buffer overflow in _canonicalize.
Upstream bug is http://bugs.icu-project.org/trac/ticket/8984
The actual fix is at
http://codereview.chromium.org/8822005
BUG=chromium:106441
TBR=falken
Review URL: http://codereview.chromium.org/8873031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113644 0039d316-1c4b-4281-b951-d872f2087c98 | c30f4209b183623ddad8e08ee332ee1decf84c55 | chrome | bigvul | 1 | null | null | null |
Rolling FFmpeg DEPS 118716:118948.
TBR=inferno
BUG=108416
Review URL: https://chromiumcodereview.appspot.com/9234011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118985 0039d316-1c4b-4281-b951-d872f2087c98 | 14c2a48633ddcd2300a89e0fe89ec40a919585dd | chrome | bigvul | 1 | null | null | null |
Disables PanelBrowserTest.MinimizeTwoPanelsWithoutTabbedWindow on
windows as it's causing other interactive ui tests to fail.
BUG=103253
[email protected]
[email protected]
Review URL: http://codereview.chromium.org/8467025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108901 0039d316-1c4b-4281-b951-d872f2087c98 | 0008e75b613a252c8a5e2cca58c8376bf0e0a6a8 | chrome | bigvul | 1 | null | null | null |
Unreviewed, rolling out r142736.
http://trac.webkit.org/changeset/142736
https://bugs.webkit.org/show_bug.cgi?id=109716
Broke ABI, nightly builds crash on launch (Requested by ap on
#webkit).
Patch by Sheriff Bot <[email protected]> on 2013-02-13
Source/WebKit2:
* Shared/APIClientTraits.cpp:
(WebKit):
* Shared/APIClientTraits.h:
* UIProcess/API/C/WKPage.h:
* UIProcess/API/gtk/WebKitLoaderClient.cpp:
(attachLoaderClientToView):
* WebProcess/InjectedBundle/API/c/WKBundlePage.h:
* WebProcess/qt/QtBuiltinBundlePage.cpp:
(WebKit::QtBuiltinBundlePage::QtBuiltinBundlePage):
Tools:
* MiniBrowser/mac/WK2BrowserWindowController.m:
(-[WK2BrowserWindowController awakeFromNib]):
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::InjectedBundlePage):
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::createWebViewWithOptions):
git-svn-id: svn://svn.chromium.org/blink/trunk@142762 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | dc3857aac17be72c96f28d860d875235b3be349a | chrome | bigvul | 1 | null | null | null |
Remove support for the DispatchOnConnectionQueue message attribute
https://bugs.webkit.org/show_bug.cgi?id=109743
Reviewed by Sam Weinig.
* Platform/CoreIPC/HandleMessage.h:
(CoreIPC):
* Scripts/webkit2/messages.py:
(handler_function):
(generate_message_handler):
* Scripts/webkit2/messages_unittest.py:
git-svn-id: svn://svn.chromium.org/blink/trunk@142783 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | 4f1d5a494d4fdd0bbdf07576426b063678340822 | chrome | bigvul | 1 | null | null | null |
Fix issue with pattern parsing in xsltCompilePatternInternal.
Import pattern parsing fix for commit: http://git.gnome.org/browse/libxslt/commit/?id=fe5a4fa33eb85bce3253ed3742b1ea6c4b59b41b
BUG=110277
Review URL: https://chromiumcodereview.appspot.com/9275001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118654 0039d316-1c4b-4281-b951-d872f2087c98 | 094c773bb6c144f07b004ff3d1886100f157f4f6 | chrome | bigvul | 1 | null | null | null |
Offline state detection for linux, using new D-Bus library.
Relanding with fix for component build: use NET_EXPORT_PRIVATE
in network_change_notifier_linux.h.
BUG=53473
TEST=see attachment on bug 7469
[email protected]
Review URL: http://codereview.chromium.org/8575013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110374 0039d316-1c4b-4281-b951-d872f2087c98 | ae66a48d272b1fdc8bf475b107ae11d95edc91f9 | chrome | bigvul | 1 | null | null | null |
Unreviewed, rolling out r110559.
http://trac.webkit.org/changeset/110559
https://bugs.webkit.org/show_bug.cgi?id=81142
Broke Dromaeo tests (Requested by rniwa on #webkit).
Patch by Sheriff Bot <[email protected]> on 2012-03-14
* Dromaeo/resources/dromaeorunner.js:
(.):
git-svn-id: svn://svn.chromium.org/blink/trunk@110746 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | 6ef85761c106eb851ec331d61aad6d28fa01c15c | chrome | bigvul | 1 | null | null | null |
[skia] not all convex paths are convex, so recompute convexity for the problematic ones
https://bugs.webkit.org/show_bug.cgi?id=75960
Reviewed by Stephen White.
No new tests.
See related chrome issue
http://code.google.com/p/chromium/issues/detail?id=108605
* platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::setPathFromConvexPoints):
git-svn-id: svn://svn.chromium.org/blink/trunk@104609 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | 58ffd25567098d8ce9443b7c977382929d163b3d | chrome | bigvul | 1 | null | null | null |
Access ChromotingHost::clients_ only on network thread.
Previously ChromotingHost was doing some work on the main thread and
some on the network thread. |clients_| and some other members were
accessed without lock on both of these threads. Moved most of the
ChromotingHost activity to the network thread to avoid possible
race conditions.
BUG=96325
TEST=Chromoting works
Review URL: http://codereview.chromium.org/8495024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109556 0039d316-1c4b-4281-b951-d872f2087c98 | a46bcef82b29d30836a0f26226e3d4aca4fa9612 | chrome | bigvul | 1 | null | null | null |
Don't delete the current NavigationEntry when leaving an interstitial page.
BUG=107182
TEST=See bug
Review URL: http://codereview.chromium.org/8976014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115189 0039d316-1c4b-4281-b951-d872f2087c98 | 6a13a6c2fbae0b3269743e6a141fdfe0d9ec9793 | chrome | bigvul | 1 | null | null | null |
REGRESSION (r105401-105403): Blue flash on css border transition
https://bugs.webkit.org/show_bug.cgi?id=77491
Reviewed by Simon Fraser.
Source/WebCore:
The new blend function added with r105403 takes unsigned as parameters therefore
we have to be careful to not overflow in case the to is less than from (animating
from 400 to 0 for example).
Test: animations/animation-border-overflow.html
* platform/animation/AnimationUtilities.h:
(WebCore::blend):
LayoutTests:
* animations/animation-border-overflow-expected.txt: Added.
* animations/animation-border-overflow.html: Added.
git-svn-id: svn://svn.chromium.org/blink/trunk@106672 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | cd06fcea76ad449f655af55fcc1e4bb07f2cd009 | chrome | bigvul | 1 | null | null | null |
Pull entity fix from upstream.
BUG=107128
Review URL: http://codereview.chromium.org/9072008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116175 0039d316-1c4b-4281-b951-d872f2087c98 | d82b03d21f7e581f9206ef1fec4959ae7b06b8eb | chrome | bigvul | 1 | null | null | null |
Avoid an overflow in harfbuzz-myanmar.c
Adds a guard to prevent invalid assignment.
BUG=108006
TEST=manually with ASAN.
Review URL: http://codereview.chromium.org/8997001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115859 0039d316-1c4b-4281-b951-d872f2087c98 | 2953a669ec0a32a25c6250d34bf895ec0eb63d27 | chrome | bigvul | 1 | null | null | null |
[EFL] fast/frames/frame-crash-with-page-cache.html is crashing
https://bugs.webkit.org/show_bug.cgi?id=85879
Patch by Mikhail Pozdnyakov <[email protected]> on 2012-05-17
Reviewed by Noam Rosenthal.
Source/WebKit/efl:
_ewk_frame_smart_del() is considering now that the frame can be present in cache.
loader()->detachFromParent() is only applied for the main frame.
loader()->cancelAndClear() is not used anymore.
* ewk/ewk_frame.cpp:
(_ewk_frame_smart_del):
LayoutTests:
* platform/efl/test_expectations.txt: Removed fast/frames/frame-crash-with-page-cache.html.
git-svn-id: svn://svn.chromium.org/blink/trunk@117409 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | b2dfe7c175fb21263f06eb586f1ed235482a3281 | chrome | bigvul | 1 | null | null | null |
[i18n-fixlet] Make strings branding specific in extension code.
IDS_EXTENSIONS_UNINSTALL
IDS_EXTENSIONS_INCOGNITO_WARNING
IDS_EXTENSION_INSTALLED_HEADING
IDS_EXTENSION_ALERT_ITEM_EXTERNAL And fix a $1 $1 bug.
IDS_EXTENSION_INLINE_INSTALL_PROMPT_TITLE
BUG=NONE
TEST=NONE
Review URL: http://codereview.chromium.org/9107061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118018 0039d316-1c4b-4281-b951-d872f2087c98 | 6b5f83842b5edb5d4bd6684b196b3630c6769731 | chrome | bigvul | 1 | null | null | null |
sync: remove Chrome OS specific logic to deal with flimflam shutdown / sync race.
No longer necessary as the ProfileSyncService now aborts sync network traffic on shutdown.
BUG=chromium-os:20841
Review URL: http://codereview.chromium.org/9358007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120912 0039d316-1c4b-4281-b951-d872f2087c98 | d6cc2749d2f90acc2d92a526c1d2cbebbc101a19 | chrome | bigvul | 1 | null | null | null |
Inherits SupportsWeakPtr<T> instead of having WeakPtrFactory<T>
This change refines r137676.
BUG=122654
TEST=browser_test
Review URL: https://chromiumcodereview.appspot.com/10332233
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@139771 0039d316-1c4b-4281-b951-d872f2087c98 | 5385c44d9634d00b1cec2abf0fe7290d4205c7b0 | chrome | bigvul | 1 | null | null | null |
[Qt][WK2] There's no way to test the gesture tap on WTR
https://bugs.webkit.org/show_bug.cgi?id=92895
Reviewed by Kenneth Rohde Christiansen.
Source/WebKit2:
Add an instance of QtViewportHandler to QQuickWebViewPrivate, so it's
now available on mobile and desktop modes, as a side effect gesture tap
events can now be created and sent to WebCore.
This is needed to test tap gestures and to get tap gestures working
when you have a WebView (in desktop mode) on notebooks equipped with
touch screens.
* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::onComponentComplete):
(QQuickWebViewFlickablePrivate::onComponentComplete): Implementation
moved to QQuickWebViewPrivate::onComponentComplete.
* UIProcess/API/qt/qquickwebview_p_p.h:
(QQuickWebViewPrivate):
(QQuickWebViewFlickablePrivate):
Tools:
WTR doesn't create the QQuickItem from C++, not from QML, so a call
to componentComplete() was added to mimic the QML behaviour.
* WebKitTestRunner/qt/PlatformWebViewQt.cpp:
(WTR::PlatformWebView::PlatformWebView):
git-svn-id: svn://svn.chromium.org/blink/trunk@124625 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | 89e4098439f73cb5c16996511cbfdb171a26e173 | chrome | bigvul | 1 | null | null | null |
Http cache: Test deleting an entry with a pending_entry when
adding the truncated flag.
BUG=125159
TEST=net_unittests
Review URL: https://chromiumcodereview.appspot.com/10356113
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@139331 0039d316-1c4b-4281-b951-d872f2087c98 | 9f4633c617ef393ba4709cba7d8fa23101b64025 | chrome | bigvul | 1 | null | null | null |
Fix icon returned for HQP matches; the two icons were reversed.
BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9695022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126296 0039d316-1c4b-4281-b951-d872f2087c98 | f3030ed0e4a5832b62dc0d434c08be21203fd17b | chrome | bigvul | 1 | null | null | null |
Skipping css3/flexbox/flexitem.html.
https://bugs.webkit.org/show_bug.cgi?id=94723.
Patch by Mark Lam <[email protected]> on 2012-08-22
Reviewed by Simon Fraser.
* platform/mac/Skipped:
git-svn-id: svn://svn.chromium.org/blink/trunk@126337 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | 9f5bd739c3b8a02f05ce688adaf570b35a751310 | chrome | bigvul | 1 | null | null | null |
chmod -x some of the new Chrome To Mobile files.
crrev.com/126343 mistakenly added files with the executable bit.
chrome/browser/ui/views/location_bar/chrome_to_mobile_view.h|cc look ok.
http://build.chromium.org/p/chromium/builders/Linux/builds/21220/steps/check_perms/logs/stdio
TBR=sky
BUG=102709
TEST=check_perms passes.
Review URL: https://chromiumcodereview.appspot.com/9693034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126350 0039d316-1c4b-4281-b951-d872f2087c98 | 70bb0e36d0a0fef6afb8353f26f7562bf79f2032 | chrome | bigvul | 1 | null | null | null |
Do not require DevTools extension resources to be white-listed in manifest.
Currently, resources used by DevTools extensions need to be white-listed as web_accessible_resources in manifest. This is quite inconvenitent and appears to be an overkill, given the fact that DevTools front-end is
(a) trusted and
(b) picky on the frames it loads.
This change adds resources that belong to DevTools extensions and are being loaded into a DevTools front-end page to the list of exceptions from web_accessible_resources check.
BUG=none
TEST=DevToolsExtensionTest.*
Review URL: https://chromiumcodereview.appspot.com/9663076
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126378 0039d316-1c4b-4281-b951-d872f2087c98 | 23a52bd208885df236cde3ad2cd162b094c0bbe4 | chrome | bigvul | 1 | null | null | null |
Fix unittests build with disable_nacl=1
BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9721009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127349 0039d316-1c4b-4281-b951-d872f2087c98 | d4421f54c53212824d59d2763b8d4e3f231e3434 | chrome | bigvul | 1 | null | null | null |
[Qt] Fix debug Windows build
https://bugs.webkit.org/show_bug.cgi?id=96008
Reviewed by Tor Arne Vestbø.
Add a few more files to the AllInOne configuration to reduce the number of object files
and their total size, allowing a debug build with MSVC again.
* Target.pri:
git-svn-id: svn://svn.chromium.org/blink/trunk@127819 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | fd4b6444f5dc40c49b33fe1f60a7ae493d7418fe | chrome | bigvul | 1 | null | null | null |
[chromium] We should accelerate all transformations, except when we must blend matrices that cannot be decomposed.
https://bugs.webkit.org/show_bug.cgi?id=95855
Reviewed by James Robinson.
Source/Platform:
WebTransformOperations are now able to report if they can successfully blend.
WebTransformationMatrix::blend now returns a bool if blending would fail.
* chromium/public/WebTransformOperations.h:
(WebTransformOperations):
* chromium/public/WebTransformationMatrix.h:
(WebTransformationMatrix):
Source/WebCore:
WebTransformOperations are now able to report if they can successfully blend.
WebTransformationMatrix::blend now returns a bool if blending would fail.
Unit tests:
AnimationTranslationUtilTest.createTransformAnimationWithNonDecomposableMatrix
AnimationTranslationUtilTest.createTransformAnimationWithNonInvertibleTransform
* platform/chromium/support/WebTransformOperations.cpp:
(WebKit::blendTransformOperations):
(WebKit::WebTransformOperations::blend):
(WebKit::WebTransformOperations::canBlendWith):
(WebKit):
(WebKit::WebTransformOperations::blendInternal):
* platform/chromium/support/WebTransformationMatrix.cpp:
(WebKit::WebTransformationMatrix::blend):
* platform/graphics/chromium/AnimationTranslationUtil.cpp:
(WebCore::WebTransformAnimationCurve):
Source/WebKit/chromium:
Added the following unit tests:
AnimationTranslationUtilTest.createTransformAnimationWithNonDecomposableMatrix
AnimationTranslationUtilTest.createTransformAnimationWithNonInvertibleTransform
* tests/AnimationTranslationUtilTest.cpp:
(WebKit::TEST):
(WebKit):
git-svn-id: svn://svn.chromium.org/blink/trunk@127868 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | 3c036ca040c114c077e13c35baaea78e2ddbaf61 | chrome | bigvul | 1 | null | null | null |
Implement new overlay style for options pages.
I've attached screenshots in the bug. The changes covered in this CL are:
- background radial gradient.
- dialog panel animation when clicking on modally blocked area.
- text color
- title font size.
- x close button visuals and placement.
- size and placement of action buttons.
- dialog internal padding.
- border radius
- drop shadow
BUG=116312
TEST=Test the new dialogs on the options page.
Review URL: https://chromiumcodereview.appspot.com/9625006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126414 0039d316-1c4b-4281-b951-d872f2087c98 | 8f4c71d7b3d0bd2be71986742faec10df1edbf38 | chrome | bigvul | 1 | null | null | null |
Unreviewed. Getting rid of Windows specific results because CSS3 flexbox has been re-enabled here: https://bugs.webkit.org/show_bug.cgi?id=95382
* platform/win/fast/css/getComputedStyle/computed-style-expected.txt: Removed.
* platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Removed.
git-svn-id: svn://svn.chromium.org/blink/trunk@127331 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | 8ba4467ff49b84b46ba189a9211f147c53634c58 | chrome | bigvul | 1 | null | null | null |
[chromium] Chromium Linux EWS bots and CQ bots are flaky
https://bugs.webkit.org/show_bug.cgi?id=96041
Unreviewed, trying to get the cr-linux ews into a usable state.
* platform/chromium/TestExpectations: mark 2 http cache tests as flaky
git-svn-id: svn://svn.chromium.org/blink/trunk@127883 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | f78310a2b267f9b4e8fcdc0647994527566d8e0e | chrome | bigvul | 1 | null | null | null |
Ash: Fix fullscreen window bounds
I was computing the non-client frame top border height incorrectly for fullscreen windows, so it was trying to draw a few pixels of transparent non-client border.
BUG=118774
TEST=visual
Review URL: http://codereview.chromium.org/9810014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128014 0039d316-1c4b-4281-b951-d872f2087c98 | 7ee3acb08d9de663e5ec3148ee98b666cd32ad82 | chrome | bigvul | 1 | null | null | null |
successCallback of ResolveLocalFileSystemURL should not be optional.
https://bugs.webkit.org/show_bug.cgi?id=94802
Patch by Taiju Tsuiki <[email protected]> on 2012-09-09
Reviewed by Kent Tamura.
Spec says it should not optional.
http://www.w3.org/TR/file-system-api/#widl-LocalFileSystem-resolveLocalFileSystemURL-void-DOMString-url-EntryCallback-successCallback-ErrorCallback-errorCallback
Source/WebCore:
Tests: fast/filesystem/entry-points-missing-arguments.html
* Modules/filesystem/DOMWindowFileSystem.idl:
* Modules/filesystem/WorkerContextFileSystem.idl:
LayoutTests:
* fast/filesystem/entry-points-missing-arguments-expected.txt: Added.
* fast/filesystem/entry-points-missing-arguments.html: Added.
* fast/filesystem/filesystem-no-callback-null-ptr-crash.html:
git-svn-id: svn://svn.chromium.org/blink/trunk@128018 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | ededfa807a7467e9b81c77e3ff5fda20d5d790c0 | chrome | bigvul | 1 | null | null | null |
Give the media context an ftp job factory; prevent a browser crash.
BUG=112983
TEST=none
Review URL: http://codereview.chromium.org/9372002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@121378 0039d316-1c4b-4281-b951-d872f2087c98 | d6b061bf189e0661a3d94d89dbcb2e6f70b433da | chrome | bigvul | 1 | null | null | null |
Allow browser to handle all WebUI navigations.
BUG=113496
TEST="Google Dashboard" link in Sync settings loads in new process.
Review URL: http://codereview.chromium.org/9663045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126949 0039d316-1c4b-4281-b951-d872f2087c98 | 744c2a2d90c3c9a33c818e1ea4b7ccb5010663a0 | chrome | bigvul | 1 | null | null | null |
[REGRESSION] Refreshed autofill popup renders garbage
https://bugs.webkit.org/show_bug.cgi?id=83255
http://code.google.com/p/chromium/issues/detail?id=118374
The code used to update only the PopupContainer coordinates as if they were the coordinates relative
to the root view. Instead, a WebWidget positioned relative to the screen origin holds the PopupContainer,
so it is the WebWidget that should be positioned in PopupContainer::refresh(), and the PopupContainer's
location should be (0, 0) (and their sizes should always be equal).
Reviewed by Kent Tamura.
No new tests, as the popup appearance is not testable in WebKit.
* platform/chromium/PopupContainer.cpp:
(WebCore::PopupContainer::layoutAndCalculateWidgetRect): Variable renamed.
(WebCore::PopupContainer::showPopup): Use m_originalFrameRect rather than frameRect()
for passing into chromeClient.
(WebCore::PopupContainer::showInRect): Set up the correct frameRect() for the container.
(WebCore::PopupContainer::refresh): Resize the container and position the WebWidget correctly.
* platform/chromium/PopupContainer.h:
(PopupContainer):
git-svn-id: svn://svn.chromium.org/blink/trunk@113418 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | c7e50b5ef454efd6ab9527d795442c213eeb6afa | chrome | bigvul | 1 | null | null | null |
Use a new scheme for swapping out RenderViews.
BUG=118664
TEST=none
Review URL: http://codereview.chromium.org/9720004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127986 0039d316-1c4b-4281-b951-d872f2087c98 | 58436a1770176ece2c02b28a57bba2a89db5d58b | chrome | bigvul | 1 | null | null | null |
Lands http://codereview.chromium.org/9316065/ for Marja. I reviewed
this, so I'm using TBR to land it.
Don't crash if multiple SessionRestoreImpl:s refer to the same
Profile.
It shouldn't ever happen but it seems to happen anyway.
BUG=111238
TEST=NONE
[email protected]
[email protected]
Review URL: https://chromiumcodereview.appspot.com/9343005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120648 0039d316-1c4b-4281-b951-d872f2087c98 | 1dab554a7e795dac34313e2f7dbe4325628d12d4 | chrome | bigvul | 1 | null | null | null |
[Uber page] Sub-page overlaps the text of the uber navigation pane
BUG=111880
[email protected]
TEST=Sub pages look OK on both wide and narrow monitors.
Review URL: http://codereview.chromium.org/9348005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120711 0039d316-1c4b-4281-b951-d872f2087c98 | 53fb9327f16cc04fa541731a1c44cae9c4d2e684 | chrome | bigvul | 1 | null | null | null |
[cros] Bubble font family fix.
BUG=chromium-os:113315
TEST=Manual: see bug description.
Review URL: https://chromiumcodereview.appspot.com/9375008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@121223 0039d316-1c4b-4281-b951-d872f2087c98 | 29b52da8a1c8de2c9c712d3d8ac6397d25425e55 | chrome | bigvul | 1 | null | null | null |
Add DCHECK to ensure IndexedDBDispatcher doesn't get re-created.
This could happen if there are IDB objects that survive the call to
didStopWorkerRunLoop.
BUG=121734
TEST=
Review URL: http://codereview.chromium.org/9999035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131679 0039d316-1c4b-4281-b951-d872f2087c98 | cc7cde43832b547cdab856fe1bedc9514ca38e13 | chrome | bigvul | 1 | null | null | null |
[Android] sending an extra to the DRT apk so that DRT can be run in a seperate thread
https://bugs.webkit.org/show_bug.cgi?id=90831
Patch by Min Qin <[email protected]> on 2012-07-11
Reviewed by Adam Barth.
On android, DRT needs to run in a background thread to avoid ANR.
However, the java tests are running on UI thread by default.
We need to send an intent extra to the apk so that it can run on a sub thread.
* Scripts/webkitpy/layout_tests/port/chromium_android.py:
(ChromiumAndroidDriver._start_once):
git-svn-id: svn://svn.chromium.org/blink/trunk@122337 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | bf68fb7c20d54a14460ed886d803b5f0e69fa429 | chrome | bigvul | 1 | null | null | null |
Unreviewed gardening, marked chromium test as flaky.
https://bugs.webkit.org/show_bug.cgi?id=91252
* platform/chromium/TestExpectations:
git-svn-id: svn://svn.chromium.org/blink/trunk@122585 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | 62796d475406887ddde0b7050f06b9c1cd3e5675 | chrome | bigvul | 1 | null | null | null |
Add setters for the aura gesture recognizer constants.
BUG=113227
TEST=none
Review URL: http://codereview.chromium.org/9372040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@122586 0039d316-1c4b-4281-b951-d872f2087c98 | b8573aa643b03a59f4e2c99c72d3511a11cfb0b6 | chrome | bigvul | 1 | null | null | null |
Suppress leak in BasicNetworkManager in remoting test
[email protected]
BUG=115647
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9460005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123481 0039d316-1c4b-4281-b951-d872f2087c98 | 939327f2c4d9d9e8e6e48251c4444ffd830fbbec | chrome | bigvul | 1 | null | null | null |
GTK: Stop listening to gtk signals in the omnibox before destroying the model.
BUG=123530
TEST=none
Review URL: http://codereview.chromium.org/10103012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132498 0039d316-1c4b-4281-b951-d872f2087c98 | 9fe90fe465e046a219411b192d8b08086faae39c | chrome | bigvul | 1 | null | null | null |
Metrics for measuring how much overhead reading compressed content states adds.
BUG=104293
TEST=NONE
Review URL: https://chromiumcodereview.appspot.com/9426039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123733 0039d316-1c4b-4281-b951-d872f2087c98 | 027429ee5abe6e2fb5e3b2b4542f0a6fe0dbc12d | chrome | bigvul | 1 | null | null | null |
Fixing mock_chrome.js
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com/9496007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124182 0039d316-1c4b-4281-b951-d872f2087c98 | 7c2dc71e489b94bfb6793d47e87909654bcb1f9d | chrome | bigvul | 1 | null | null | null |
Always use sentence casing in uber page.
BUG=115539
Review URL: https://chromiumcodereview.appspot.com/9466034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124216 0039d316-1c4b-4281-b951-d872f2087c98 | 8a0f990d4a22d1d6a6c1ba37227321b7729f40fe | chrome | bigvul | 1 | null | null | null |
[GTK] Inspector should set a default attached height before being attached
https://bugs.webkit.org/show_bug.cgi?id=90767
Reviewed by Xan Lopez.
We are currently using the minimum attached height in
WebKitWebViewBase as the default height for the inspector when
attached. It would be easier for WebKitWebViewBase and embedders
implementing attach() if the inspector already had an attached
height set when it's being attached.
* UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseContainerAdd): Don't initialize
inspectorViewHeight.
(webkitWebViewBaseSetInspectorViewHeight): Allow to set the
inspector view height before having an inpector view, but only
queue a resize when the view already has an inspector view.
* UIProcess/API/gtk/tests/TestInspector.cpp:
(testInspectorDefault):
(testInspectorManualAttachDetach):
* UIProcess/gtk/WebInspectorProxyGtk.cpp:
(WebKit::WebInspectorProxy::platformAttach): Set the default
attached height before attach the inspector view.
git-svn-id: svn://svn.chromium.org/blink/trunk@124479 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | 3bbc818ed1a7b63b8290bbde9ae975956748cb8a | chrome | bigvul | 1 | null | null | null |
Remove '.' from end of warning for 'privacy' extension permission.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/9550002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124652 0039d316-1c4b-4281-b951-d872f2087c98 | 020dc9b4840ef1e702ca0a1f8575abd042b2dd27 | chrome | bigvul | 1 | null | null | null |
Always write data to new buffer in SimulateAttrib0
This is to work around linux nvidia driver bug.
TEST=asan
BUG=118970
Review URL: http://codereview.chromium.org/10019003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131538 0039d316-1c4b-4281-b951-d872f2087c98 | 8f0b86c2fc77fca1508d81314f864011abe25f04 | chrome | bigvul | 1 | null | null | null |
Fix XPointer bug.
BUG=125462
[email protected]
[email protected]
Review URL: https://chromiumcodereview.appspot.com/10344022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135174 0039d316-1c4b-4281-b951-d872f2087c98 | 4c46d7a5b0af9b7d320e709291b270ab7cf07e83 | chrome | bigvul | 1 | null | null | null |
Relands cl 16982 as it wasn't the cause of the build breakage. Here's
the description for that cl:
Lands http://codereview.chromium.org/115505 for bug
http://crbug.com/4030 for tyoshino.
BUG=http://crbug.com/4030
TEST=make sure control-w dismisses bookmark manager.
Review URL: http://codereview.chromium.org/113902
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16987 0039d316-1c4b-4281-b951-d872f2087c98 | 3da579b85a36e95c03d06b7c4ce9d618af4107bf | chrome | bigvul | 1 | null | null | null |
Pull follow-up tweak from upstream.
BUG=116162
Review URL: http://codereview.chromium.org/9546033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125311 0039d316-1c4b-4281-b951-d872f2087c98 | 4cf106cdb83dd6b35d3b26d06cc67d1d2d99041e | chrome | bigvul | 1 | null | null | null |
cleanup: Use IsTextInputTypeNone() in OnInputMethodChanged().
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/8986010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116461 0039d316-1c4b-4281-b951-d872f2087c98 | d66c757a9a434f48069b114fb49191e4790f9038 | chrome | bigvul | 1 | null | null | null |
Fix mismanagement in handling of temporary scanline for vertical flip.
BUG=116637
TEST=manual test from bug report with ASAN
Review URL: https://chromiumcodereview.appspot.com/9617038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125301 0039d316-1c4b-4281-b951-d872f2087c98 | 64681e22e73e3325e06e6e5e8ef81995b4a306cc | chrome | bigvul | 1 | null | null | null |
chromeos: Move audio, power, and UI files into subdirs.
This moves more files from chrome/browser/chromeos/ into
subdirectories.
BUG=chromium-os:22896
TEST=did chrome os builds both with and without aura
TBR=sky
Review URL: http://codereview.chromium.org/9125006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116746 0039d316-1c4b-4281-b951-d872f2087c98 | c442b3eda2f1fdd4d1d4864c34c43cbaf223acae | chrome | bigvul | 1 | null | null | null |
Add unit test for AllowBindings check.
BUG=117418
TEST=none
Review URL: http://codereview.chromium.org/9701038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126929 0039d316-1c4b-4281-b951-d872f2087c98 | 8ae91350332f188ef711228aa61b7809b74aa3a7 | chrome | bigvul | 1 | null | null | null |
[V8] Pass Isolate to throwNotEnoughArgumentsError()
https://bugs.webkit.org/show_bug.cgi?id=86983
Reviewed by Adam Barth.
The objective is to pass Isolate around in V8 bindings.
This patch passes Isolate to throwNotEnoughArgumentsError().
No tests. No change in behavior.
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateArgumentsCountCheck):
(GenerateEventConstructorCallback):
* bindings/scripts/test/V8/V8Float64Array.cpp:
(WebCore::Float64ArrayV8Internal::fooCallback):
* bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
(WebCore::TestActiveDOMObjectV8Internal::excitingFunctionCallback):
(WebCore::TestActiveDOMObjectV8Internal::postMessageCallback):
* bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:
(WebCore::TestCustomNamedGetterV8Internal::anotherFunctionCallback):
* bindings/scripts/test/V8/V8TestEventConstructor.cpp:
(WebCore::V8TestEventConstructor::constructorCallback):
* bindings/scripts/test/V8/V8TestEventTarget.cpp:
(WebCore::TestEventTargetV8Internal::itemCallback):
(WebCore::TestEventTargetV8Internal::dispatchEventCallback):
* bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore::TestInterfaceV8Internal::supplementalMethod2Callback):
(WebCore::V8TestInterface::constructorCallback):
* bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
(WebCore::TestMediaQueryListListenerV8Internal::methodCallback):
* bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
(WebCore::V8TestNamedConstructorConstructorCallback):
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjV8Internal::voidMethodWithArgsCallback):
(WebCore::TestObjV8Internal::intMethodWithArgsCallback):
(WebCore::TestObjV8Internal::objMethodWithArgsCallback):
(WebCore::TestObjV8Internal::methodWithSequenceArgCallback):
(WebCore::TestObjV8Internal::methodReturningSequenceCallback):
(WebCore::TestObjV8Internal::methodThatRequiresAllArgsAndThrowsCallback):
(WebCore::TestObjV8Internal::serializedValueCallback):
(WebCore::TestObjV8Internal::idbKeyCallback):
(WebCore::TestObjV8Internal::optionsObjectCallback):
(WebCore::TestObjV8Internal::methodWithNonOptionalArgAndOptionalArgCallback):
(WebCore::TestObjV8Internal::methodWithNonOptionalArgAndTwoOptionalArgsCallback):
(WebCore::TestObjV8Internal::methodWithCallbackArgCallback):
(WebCore::TestObjV8Internal::methodWithNonCallbackArgAndCallbackArgCallback):
(WebCore::TestObjV8Internal::overloadedMethod1Callback):
(WebCore::TestObjV8Internal::overloadedMethod2Callback):
(WebCore::TestObjV8Internal::overloadedMethod3Callback):
(WebCore::TestObjV8Internal::overloadedMethod4Callback):
(WebCore::TestObjV8Internal::overloadedMethod5Callback):
(WebCore::TestObjV8Internal::overloadedMethod6Callback):
(WebCore::TestObjV8Internal::overloadedMethod7Callback):
(WebCore::TestObjV8Internal::overloadedMethod11Callback):
(WebCore::TestObjV8Internal::overloadedMethod12Callback):
(WebCore::TestObjV8Internal::enabledAtRuntimeMethod1Callback):
(WebCore::TestObjV8Internal::enabledAtRuntimeMethod2Callback):
(WebCore::TestObjV8Internal::convert1Callback):
(WebCore::TestObjV8Internal::convert2Callback):
(WebCore::TestObjV8Internal::convert3Callback):
(WebCore::TestObjV8Internal::convert4Callback):
(WebCore::TestObjV8Internal::convert5Callback):
(WebCore::TestObjV8Internal::strictFunctionCallback):
(WebCore::V8TestObj::constructorCallback):
* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore::TestSerializedScriptValueInterfaceV8Internal::acceptTransferListCallback):
(WebCore::V8TestSerializedScriptValueInterface::constructorCallback):
* bindings/v8/ScriptController.cpp:
(WebCore::setValueAndClosePopupCallback):
* bindings/v8/V8Proxy.cpp:
(WebCore::V8Proxy::throwNotEnoughArgumentsError):
* bindings/v8/V8Proxy.h:
(V8Proxy):
* bindings/v8/custom/V8AudioContextCustom.cpp:
(WebCore::V8AudioContext::constructorCallback):
* bindings/v8/custom/V8DataViewCustom.cpp:
(WebCore::V8DataView::getInt8Callback):
(WebCore::V8DataView::getUint8Callback):
(WebCore::V8DataView::setInt8Callback):
(WebCore::V8DataView::setUint8Callback):
* bindings/v8/custom/V8DirectoryEntryCustom.cpp:
(WebCore::V8DirectoryEntry::getDirectoryCallback):
(WebCore::V8DirectoryEntry::getFileCallback):
* bindings/v8/custom/V8IntentConstructor.cpp:
(WebCore::V8Intent::constructorCallback):
* bindings/v8/custom/V8SVGLengthCustom.cpp:
(WebCore::V8SVGLength::convertToSpecifiedUnitsCallback):
* bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
(WebCore::getObjectParameter):
(WebCore::V8WebGLRenderingContext::getAttachedShadersCallback):
(WebCore::V8WebGLRenderingContext::getExtensionCallback):
(WebCore::V8WebGLRenderingContext::getFramebufferAttachmentParameterCallback):
(WebCore::V8WebGLRenderingContext::getParameterCallback):
(WebCore::V8WebGLRenderingContext::getProgramParameterCallback):
(WebCore::V8WebGLRenderingContext::getShaderParameterCallback):
(WebCore::V8WebGLRenderingContext::getUniformCallback):
(WebCore::vertexAttribAndUniformHelperf):
(WebCore::uniformHelperi):
(WebCore::uniformMatrixHelper):
* bindings/v8/custom/V8WebKitMutationObserverCustom.cpp:
(WebCore::V8WebKitMutationObserver::constructorCallback):
(WebCore::V8WebKitMutationObserver::observeCallback):
* bindings/v8/custom/V8WebSocketCustom.cpp:
(WebCore::V8WebSocket::constructorCallback):
(WebCore::V8WebSocket::sendCallback):
* bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
(WebCore::V8XMLHttpRequest::openCallback):
git-svn-id: svn://svn.chromium.org/blink/trunk@117736 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | e9372a1bfd3588a80fcf49aa07321f0971dd6091 | chrome | bigvul | 1 | null | null | null |
[perf-test] Add a binding benchmark for div.getAttribute()
https://bugs.webkit.org/show_bug.cgi?id=86814
Reviewed by Ryosuke Niwa.
We should remove Bindings/dom-attributes.html and instead add more
reasonable micro benchmarks by classifying DOM binding call paths.
This patch adds a benchmark for div.getAttribute(). This benchmark
covers 'getAttribute' in Dromaeo/dom-attr.html, and other DOM methods
that return a String.
Test results in my Linux desktop:
RESULT Bindings: get-attribute= 250.088158538 runs/s
median= 250.469728765 runs/s, stdev= 4.66551901315 runs/s, min= 240.673886883 runs/s, max= 256.739409499 runs/s
RESULT Bindings: get-attribute= 250.209764698 runs/s
median= 250.626959986 runs/s, stdev= 4.12030002477 runs/s, min= 241.254523522 runs/s, max= 255.102040816 runs/s
RESULT Bindings: get-attribute= 248.907532887 runs/s
median= 250.312891114 runs/s, stdev= 3.23173125874 runs/s, min= 240.673886883 runs/s, max= 251.572327044 runs/s
RESULT Bindings: get-attribute= 250.243680844 runs/s
median= 250.783797637 runs/s, stdev= 4.19327170024 runs/s, min= 240.963855422 runs/s, max= 255.102040816 runs/s
RESULT Bindings: get-attribute= 245.329046608 runs/s
median= 244.948040416 runs/s, stdev= 2.24314248534 runs/s, min= 240.384615385 runs/s, max= 248.756218905 runs/s
* Bindings/get-attribute.html: Added.
git-svn-id: svn://svn.chromium.org/blink/trunk@117550 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | 8fe074eec64f6942976acdd9dcd499bea36da2bd | chrome | bigvul | 1 | null | null | null |
Use GURL::Replacements to trim query and ref from URL
BUG=108648
TEST=no
Review URL: http://codereview.chromium.org/9120011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116960 0039d316-1c4b-4281-b951-d872f2087c98 | 22503495dc014e883d1041f6b9d883a1a53f3e55 | chrome | bigvul | 1 | null | null | null |
Suppress race in ChromeBrowserMainParts::SetupFieldTrials
[email protected]
BUG=109863
TEST=waterfall.sh
Review URL: http://codereview.chromium.org/9188006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117226 0039d316-1c4b-4281-b951-d872f2087c98 | 8a1b329c314a90e199b7b6b516a8edc2dfecc065 | chrome | bigvul | 1 | null | null | null |
Don't put the error URL in the chrome:// scheme.
BUG=117230
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9632002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125635 0039d316-1c4b-4281-b951-d872f2087c98 | 67e38708af8e99569365326e378b806088c83f5a | chrome | bigvul | 1 | null | null | null |
content: Refactor ChildThreadImpl::Options
Refactor the way options are passed to ChildThreadImpl to make the
call sites easier to read and to make it easier to add a task runner
parameter later.
BUG=444764
Review URL: https://codereview.chromium.org/974933002
Cr-Commit-Position: refs/heads/master@{#319117} | f28ccd0b2709832d05156bd107d29d48a4a440cc | chrome | bigvul | 1 | null | null | null |
Update example bug for browser memory corruption in severity guidelines
319125 is a straightforward browser memory corruption bug where an IPC
handler blindly trusts data from the renderer, forgetting that one of
the types of data that can be set is a raw pointer ^_^
Change-Id: I14a37f1882c06edc56e5d4d2f7c1d0444869bec4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790480
Commit-Queue: Daniel Cheng <[email protected]>
Reviewed-by: Max Moroz <[email protected]>
Reviewed-by: Emily Stark <[email protected]>
Cr-Commit-Position: refs/heads/master@{#694943} | 62a44a8fbce598d9924c36a54088045e68a169c7 | chrome | bigvul | 1 | null | null | null |
During redirects in the one click sign in flow, check the current URL
instead of original URL to validate gaia http headers.
BUG=307159
Review URL: https://codereview.chromium.org/77343002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236563 0039d316-1c4b-4281-b951-d872f2087c98 | 50370b3c98047bdc80184ff87a502edc5c597d3a | chrome | bigvul | 1 | null | null | null |
Revert "Load web contents after tab is created."
This reverts commit 4c55f398def3214369aefa9f2f2e8f5940d3799d.
BUG=432562
[email protected],[email protected],[email protected]
Review URL: https://codereview.chromium.org/894003005
Cr-Commit-Position: refs/heads/master@{#314469} | 6b96dd532af164a73f2aac757bafff58211aca2c | chrome | bigvul | 1 | null | null | null |
Clear out some minor TODOs.
BUG=none
Review URL: https://codereview.chromium.org/1047063002
Cr-Commit-Position: refs/heads/master@{#322959} | 5cfe3023574666663d970ce48cdbc8ed15ce61d9 | chrome | bigvul | 1 | null | null | null |
Add the network service as a data dependency of html_viewer for Android.
The corresponding desktop CL: https://codereview.chromium.org/1090753002
BUG=NONE
TEST=Building html_viewer from scratch also builds the network service.
[email protected]
Review URL: https://codereview.chromium.org/1097503002
Cr-Commit-Position: refs/heads/master@{#325501} | 96626920573e30a2cd02040b7ccec2c56f38b4db | chrome | bigvul | 1 | null | null | null |
base: Fix/add header #ifndef guards.
Header guards should be defined based on the path and file name of the
header file. Some headers have it wrong, some are missing the guards,
and some just have the matching comment wrong.
R=Nico
BUG=464816
Review URL: https://codereview.chromium.org/985003004
Cr-Commit-Position: refs/heads/master@{#319722} | 301b392761fd8f66f3a701ab1dd011c6e7a55e19 | chrome | bigvul | 1 | null | null | null |
Update AffiliationFetcher to use new Affiliation API wire format.
The new format is not backward compatible with the old one, therefore this CL updates the client side protobuf definitions to be in line with the API definition. However, this CL does not yet make use of any additional fields introduced in the new wire format.
BUG=437865
Review URL: https://codereview.chromium.org/996613002
Cr-Commit-Position: refs/heads/master@{#319860} | 516abadc2553489ce28faeea4917280032fbe91d | chrome | bigvul | 1 | null | null | null |
Add logging to figure out which IPC we're failing to deserialize in RenderFrame.
BUG=369553
[email protected]
Review URL: https://codereview.chromium.org/263833020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268565 0039d316-1c4b-4281-b951-d872f2087c98 | 4039d2fcaab746b6c20017ba9bb51c3a2403a76c | chrome | bigvul | 1 | null | null | null |
Remove --disable-app-shims.
App shims have been enabled by default for 3 milestones
(since r242711).
BUG=350161
Review URL: https://codereview.chromium.org/298953002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272786 0039d316-1c4b-4281-b951-d872f2087c98 | 438b99bc730bc665eedfc62c4eb864c981e5c65f | chrome | bigvul | 1 | null | null | null |
Make the policy fetch for first time login blocking
The CL makes policy fetching for first time login blocking for all users, except the ones that are known to be non-enterprise users.
BUG=334584
Review URL: https://codereview.chromium.org/330843002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282925 0039d316-1c4b-4281-b951-d872f2087c98 | 9fd9d629fcf836bb0d6210015d33a299cf6bca34 | chrome | bigvul | 1 | null | null | null |
Fix tracking of the id attribute string if it is shared across elements.
The patch to remove AtomicStringImpl:
http://src.chromium.org/viewvc/blink?view=rev&rev=154790
Exposed a lifetime issue with strings for id attributes. We simply need to use
AtomicString.
BUG=290566
Review URL: https://codereview.chromium.org/33793004
git-svn-id: svn://svn.chromium.org/blink/trunk@160250 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | 36773850210becda3d76f27285ecd899fafdfc72 | chrome | bigvul | 1 | null | null | null |
Notify nodes removal to Range/Selection after dispatching blur and mutation event
This patch changes notifying nodes removal to Range/Selection after dispatching blur and mutation event. In willRemoveChildren(), like willRemoveChild(); r115686 did same change, although it didn't change willRemoveChildren().
The issue 295010, use-after-free, is caused by setting removed node to Selection in mutation event handler.
BUG=295010
TEST=LayoutTests/fast/dom/Range/range-created-during-remove-children.html, LayoutTests/editing/selection/selection-change-in-mutation-event-by-remove-children.html, LayoutTests/editing/selection/selection-change-in-blur-event-by-remove-children.html
[email protected]
Review URL: https://codereview.chromium.org/25389004
git-svn-id: svn://svn.chromium.org/blink/trunk@159007 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | f084d7007f67809ef116ee6b11f251bf3c9ed895 | chrome | bigvul | 1 | null | null | null |
Cancel JavaScript dialogs when an interstitial appears.
BUG=295695
TEST=See bug for repro steps.
Review URL: https://chromiumcodereview.appspot.com/24360011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225026 0039d316-1c4b-4281-b951-d872f2087c98 | 90fb08ed0146c9beacfd4dde98a20fc45419fff3 | chrome | bigvul | 1 | null | null | null |
Content Shell: Move shell_layout_tests_android into layout_tests/.
BUG=420994
Review URL: https://codereview.chromium.org/661743002
Cr-Commit-Position: refs/heads/master@{#299892} | d6805d0d1d21976cf16d0237d9091f7eebea4ea5 | chrome | bigvul | 1 | null | null | null |
Add flag --require-audio-hardware-for-testing.
When enabled, tests that require audio hardware will fail if the system
doesn't provide it. Otherwise, they will silently succeed.
TEST=media_unittests (and AudioInputTests with !InputDevicesAvailable())
BUG=432624
Review URL: https://codereview.chromium.org/914483002
Cr-Commit-Position: refs/heads/master@{#315823} | b0ddebe2ea0b00c272af7820b9c108c4438f5b88 | chrome | bigvul | 1 | null | null | null |
Add test fast/images/55.html
[email protected]
BUG=258723
Review URL: https://codereview.chromium.org/27135003
git-svn-id: svn://svn.chromium.org/blink/trunk@159561 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | 7525c48236905b36a2f0ba515573ddef8f6c30a0 | chrome | bigvul | 1 | null | null | null |
Convert ARRAYSIZE_UNSAFE -> arraysize in base/.
[email protected]
BUG=423134
Review URL: https://codereview.chromium.org/656033009
Cr-Commit-Position: refs/heads/master@{#299835} | 805eabb91d386c86bd64336c7643f6dfa864151d | chrome | bigvul | 1 | null | null | null |
Adding tracking to verify the theory that jankiness of ExtensionMessageFilter::OnExtensionAddListener is because of the observer invocation.
BUG=401560, 417106
Review URL: https://codereview.chromium.org/600213002
Cr-Commit-Position: refs/heads/master@{#296804} | a19e4877974a6a0cfc53f92c1496a8f995fe2614 | chrome | bigvul | 1 | null | null | null |
Don't dispatch events when XHR is set to sync mode
Any of readystatechange, progress, abort, error, timeout and loadend
event are not specified to be dispatched in sync mode in the latest
spec. Just an exception corresponding to the failure is thrown.
Clean up for readability done in this CL
- factor out dispatchEventAndLoadEnd calling code
- make didTimeout() private
- give error handling methods more descriptive names
- set m_exceptionCode in failure type specific methods
-- Note that for didFailRedirectCheck, m_exceptionCode was not set
in networkError(), but was set at the end of createRequest()
This CL is prep for fixing crbug.com/292422
BUG=292422
Review URL: https://chromiumcodereview.appspot.com/24225002
git-svn-id: svn://svn.chromium.org/blink/trunk@158046 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | aa1a102f73565feeb1d121d0d6c9524bebcdd75f | chrome | bigvul | 1 | null | null | null |
Remove false assertion in ApplyBlockElementCommand::formatSelection()
Note: This patch is preparation of fixing issue 294456.
This patch removes false assertion in ApplyBlockElementCommand::formatSelection(), when contents of being indent is modified, e.g. mutation event, |endOfNextParagraph| can hold removed contents.
BUG=294456
TEST=n/a
[email protected]
Review URL: https://codereview.chromium.org/25657004
git-svn-id: svn://svn.chromium.org/blink/trunk@158701 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | e1524692d362e607e806569147096dfb8c38cb6a | chrome | bigvul | 1 | null | null | null |
Fix a crash in HTMLFormElement::prepareForSubmission.
BUG=297478
TEST=automated with ASAN.
Review URL: https://chromiumcodereview.appspot.com/24910003
git-svn-id: svn://svn.chromium.org/blink/trunk@158428 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | 4d77eed905ce1d00361282e8822a2a3be61d25c0 | chrome | bigvul | 1 | null | null | null |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.