commit_msg
stringlengths
1
24.2k
commit_hash
stringlengths
2
84
project
stringlengths
2
40
source
stringclasses
4 values
labels
int64
0
1
repo_url
stringlengths
26
70
commit_url
stringlengths
74
118
commit_date
stringlengths
25
25
Fix threading races on ConvolverNode::m_reverb in ConvolverNode::latencyFrames() According to the crash report (https://cluster-fuzz.appspot.com/testcase?key=6515787040817152), ConvolverNode::m_reverb races between ConvolverNode::latencyFrames() and ConvolverNode::setBuffer(). This CL adds a proper lock for ConvolverNode::m_reverb. BUG=223962 No tests because the crash depends on threading races and thus not reproducible. Review URL: https://chromiumcodereview.appspot.com/23514037 git-svn-id: svn://svn.chromium.org/blink/trunk@157245 bbb929c8-8fbe-4397-9dbb-9b2b20218538
94bb8861ec61b4ebcce8a4489be2cf7e2a055d90
chrome
bigvul
1
null
null
null
Remove dependency of TranslateInfobarDelegate on profile This CL uses TranslateTabHelper instead of Profile and also cleans up some unused code and irrelevant dependencies. BUG=371845 Review URL: https://codereview.chromium.org/286973003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270758 0039d316-1c4b-4281-b951-d872f2087c98
603af455b5641671b18d7d7d166630341d71b63f
chrome
bigvul
1
null
null
null
[OriginChip] Re-enable the chip as necessary when switching tabs. BUG=369500 Review URL: https://codereview.chromium.org/292493003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271161 0039d316-1c4b-4281-b951-d872f2087c98
c2364e0ce42878a2177c6f4cf7adb3c715b777c1
chrome
bigvul
1
null
null
null
Suspend shared timers while blockingly closing databases BUG=388771 [email protected] Review URL: https://codereview.chromium.org/409863002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284785 0039d316-1c4b-4281-b951-d872f2087c98
c4a4dfb26615b5ef5e9dcc730ef43f70ce9202e2
chrome
bigvul
1
null
null
null
Cleanups in ScreenOrientationDispatcherHost. BUG=None Review URL: https://codereview.chromium.org/408213003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284786 0039d316-1c4b-4281-b951-d872f2087c98
bcc265132e3d9b62c6c49facbf849575c615d1e3
chrome
bigvul
1
null
null
null
The User Manager tutorial should disable pods in the single pod case too BUG=357500 TEST=Delete all your profiles, start chrome with --new-profile-management. From the avatar bubble, choose "Not Person 1". The user manager should come up, it should display a tutorial to the side, and the only user pod showing should be disabled and slightly opaque. Review URL: https://codereview.chromium.org/217293003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260667 0039d316-1c4b-4281-b951-d872f2087c98
e72e4401cd9c6683816e5f452bb4514b18b21655
chrome
bigvul
1
null
null
null
Call didAccessInitialDocument when javascript: URLs are used. BUG=265221 TEST=See bug for repro. Review URL: https://chromiumcodereview.appspot.com/22572004 git-svn-id: svn://svn.chromium.org/blink/trunk@155790 bbb929c8-8fbe-4397-9dbb-9b2b20218538
7edf2c655761e7505950013e62c89e3bd2f7e6dc
chrome
bigvul
1
null
null
null
Added LayoutTest for use-after-free regression with bidi isolates. BUG=265838 Review URL: https://chromiumcodereview.appspot.com/23137012 git-svn-id: svn://svn.chromium.org/blink/trunk@156580 bbb929c8-8fbe-4397-9dbb-9b2b20218538
d79eee2ffdc979779e96b4cf5db4720d44f01835
chrome
bigvul
1
null
null
null
Update containtingIsolate to go back all the way to top isolate from current root, rather than stopping at the first isolate it finds. This works because the current root is always updated with each isolate run. BUG=279277 Review URL: https://chromiumcodereview.appspot.com/23972003 git-svn-id: svn://svn.chromium.org/blink/trunk@157268 bbb929c8-8fbe-4397-9dbb-9b2b20218538
248a92c21c20c14b5983680c50e1d8b73fc79a2f
chrome
bigvul
1
null
null
null
Rollback option put behind the flag. BUG=368860 Review URL: https://codereview.chromium.org/267393011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269753 0039d316-1c4b-4281-b951-d872f2087c98
90556c5c9d0a274cc823b713544e9b6064e205cd
chrome
bigvul
1
null
null
null
Avoid reparsing an XSLT stylesheet after the first failure. Certain libxslt versions appear to leave the doc in an invalid state when parsing fails. We should cache this result and avoid re-parsing. (The test cannot be converted to text-only due to its invalid stylesheet). [email protected],[email protected],[email protected] BUG=271939 Review URL: https://chromiumcodereview.appspot.com/23103007 git-svn-id: svn://svn.chromium.org/blink/trunk@156248 bbb929c8-8fbe-4397-9dbb-9b2b20218538
0220f39fac21d169a834ef91de362f4169f2eef5
chrome
bigvul
1
null
null
null
[Mac] Add interactive App Shim test. This test creates shims in the user data dir and actually starts them up and expects them to connect to the IPC socket. BUG=168080 Review URL: https://codereview.chromium.org/316493002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276368 0039d316-1c4b-4281-b951-d872f2087c98
384daf4d199e8ee29356a2aa61e6915caf5a7100
chrome
bigvul
1
null
null
null
Added unit test for new portion of GetMetaInfo API BUG=383600 Review URL: https://codereview.chromium.org/348833003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278908 0039d316-1c4b-4281-b951-d872f2087c98
5b998565255a504887c6d2e90d11001a00c9d6da
chrome
bigvul
1
null
null
null
ColorChooserWin::End should act like the dialog has closed This is only a problem on Windows. When the page closes itself while the color chooser dialog is open, ColorChooserDialog::DidCloseDialog was called after the listener has been destroyed. ColorChooserWin::End() will not actually close the color chooser dialog (because we can't) but act like it did so we can do the necessary cleanup. BUG=279263 [email protected], [email protected] Review URL: https://codereview.chromium.org/23785003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220639 0039d316-1c4b-4281-b951-d872f2087c98
5ecc8d42ff888ff8b459df566208e7e01a3be5ba
chrome
bigvul
1
null
null
null
Delete unneeded pending entries in DidFailProvisionalLoad to prevent a spoof. BUG=280512 BUG=278899 TEST=See bug for repro steps. Review URL: https://chromiumcodereview.appspot.com/23978003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222146 0039d316-1c4b-4281-b951-d872f2087c98
b12eb22a27110f49a2ad54b9e4ffd0ccb6cf9ce9
chrome
bigvul
1
null
null
null
Don't wait to notify client of spoof attempt if a modal dialog is created. BUG=281256 TEST=See bug for repro steps. Review URL: https://chromiumcodereview.appspot.com/23620020 git-svn-id: svn://svn.chromium.org/blink/trunk@157196 bbb929c8-8fbe-4397-9dbb-9b2b20218538
47a054e9ad826421b789097d82b44c102ab6ac97
chrome
bigvul
1
null
null
null
Don't read past the end of the impulseResponse array BUG=281480 Review URL: https://chromiumcodereview.appspot.com/23689004 git-svn-id: svn://svn.chromium.org/blink/trunk@157007 bbb929c8-8fbe-4397-9dbb-9b2b20218538
6bdf46c517fd12674ffc61d827dc8987e67f0334
chrome
bigvul
1
null
null
null
Update rasterized_and_record_micro to use results.AddValue(...) BUG=391943 Review URL: https://codereview.chromium.org/376183005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282088 0039d316-1c4b-4281-b951-d872f2087c98
917004483901fec2682b27b6061de64244ece947
chrome
bigvul
1
null
null
null
Fix OOB read when parsing protocol-relative URLs BUG=285742 Review URL: https://chromiumcodereview.appspot.com/23902014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223735 0039d316-1c4b-4281-b951-d872f2087c98
3ca8e38ff57e83fcce76f9b54cd8f8bfa09c34ad
chrome
bigvul
1
null
null
null
repairs CopyFromCompositingSurface in HighDPI This CL removes the DIP=>Pixel transform in DelegatedFrameHost::CopyFromCompositingSurface(), because said transformation seems to be happening later in the copy logic and is currently being applied twice. BUG=397708 Review URL: https://codereview.chromium.org/421293002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@286414 0039d316-1c4b-4281-b951-d872f2087c98
1228817ab04a14df53b5a8446085f9c03bf6e964
chrome
bigvul
1
null
null
null
Reland r286968: The CL borrows ShareDialog from Files.app and add it to Gallery. Previous Review URL: https://codereview.chromium.org/431293002 BUG=374667 TEST=manually [email protected], [email protected] Review URL: https://codereview.chromium.org/433733004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@286975 0039d316-1c4b-4281-b951-d872f2087c98
47cf56b8b8c6ddbbbe9d4d342fbd8ffe7b7bb87b
chrome
bigvul
1
null
null
null
[Android] Properly validate potentially null InputDevice As InputDevice.getDevice() makes no guarantees that the returned device will be non-null, always validate the return value before using in a meaningful way as a Gamepad device. BUG=421168 Review URL: https://codereview.chromium.org/644783003 Cr-Commit-Position: refs/heads/master@{#299016}
55f9a7718acb7e0e44d61d6ea55a91179d774ce0
chrome
bigvul
1
null
null
null
exclude Aes tests in net_unittests and content_unittests with Dr.Memory [email protected], [email protected] BUG=drm-i#1561 Review URL: https://codereview.chromium.org/323863002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275803 0039d316-1c4b-4281-b951-d872f2087c98
653ed3224389f99dec01a41614c1533c1e4dbac3
chrome
bigvul
1
null
null
null
AX: Calendar Picker: Add AX labels to MonthPopupButton and CalendarNavigationButtons. This CL adds no new tests. Will add tests after a Chromium change for string resource. BUG=123896 Review URL: https://codereview.chromium.org/552163002 git-svn-id: svn://svn.chromium.org/blink/trunk@181617 bbb929c8-8fbe-4397-9dbb-9b2b20218538
bd3392a1f8b95bf0b0ee3821bc3245d743fb1337
chrome
bigvul
1
null
null
null
Posix: fix named SHM mappings permissions. Make sure that named mappings in /dev/shm/ aren't created with broad permissions. BUG=254159 [email protected], [email protected] Review URL: https://codereview.chromium.org/17779002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@209814 0039d316-1c4b-4281-b951-d872f2087c98
afb848acb43ba316097ab4fddfa38dbd80bc6a71
chrome
bigvul
1
null
null
null
Removed pinch viewport scroll offset distribution The associated change in Blink makes the pinch viewport a proper ScrollableArea meaning the normal path for synchronizing layer scroll offsets is used. This is a 2 sided patch, the other CL: https://codereview.chromium.org/199253002/ BUG=349941 Review URL: https://codereview.chromium.org/210543002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260105 0039d316-1c4b-4281-b951-d872f2087c98
87a082c5137a63dedb3fe5b1f48f75dcd1fd780c
chrome
bigvul
1
null
null
null
Enforce the maximum length of the folder name in UI. BUG=355797 [email protected] Review URL: https://codereview.chromium.org/203863005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260156 0039d316-1c4b-4281-b951-d872f2087c98
92029a982fac85a4ebb614a825012a2e9ee84ef3
chrome
bigvul
1
null
null
null
Cleanup after transition to new attestation dbus methods. The methods with the 'New' suffix are temporary and will soon be removed. BUG=chromium:243605 TEST=manual Review URL: https://codereview.chromium.org/213413009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260428 0039d316-1c4b-4281-b951-d872f2087c98
ed5c0b5ff5cec5a12235b868d0f3ba7e0c0f2a24
chrome
bigvul
1
null
null
null
Pass ui::LatencyInfo correct with unified gesture detector on Aura. BUG=379812 TEST=GestureRecognizerTest.LatencyPassedFromTouchEvent Review URL: https://codereview.chromium.org/309823002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274602 0039d316-1c4b-4281-b951-d872f2087c98
01924fbe6c0e0f059ca46a03f9f6b2670ae3e0fa
chrome
bigvul
1
null
null
null
Test assignment to indexed window properties The actual bug here was fixed in V8, but we should have a test at the Blink layer too. R=adamk BUG=257748 Review URL: https://chromiumcodereview.appspot.com/19923006 git-svn-id: svn://svn.chromium.org/blink/trunk@154714 bbb929c8-8fbe-4397-9dbb-9b2b20218538
d1617103b0fb2c6cf29f5c7ca491e03cbf2fcfd0
chrome
bigvul
1
null
null
null
Disable AutofillInteractiveTest.OnChangeAfterAutofill test. Failing due to http://src.chromium.org/viewvc/blink?view=revision&revision=170278. BUG=353691 [email protected], [email protected] Review URL: https://codereview.chromium.org/216853002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260106 0039d316-1c4b-4281-b951-d872f2087c98
dbbcd55a666ab8389d5d223994a95a59ad20dd13
chrome
bigvul
1
null
null
null
Fix crash due to unexpected Node deletion during MutationObserver registration book-keeping R=inferno BUG=260165 Review URL: https://chromiumcodereview.appspot.com/19303002 git-svn-id: svn://svn.chromium.org/blink/trunk@154264 bbb929c8-8fbe-4397-9dbb-9b2b20218538
afea522e2f80f56fed7e54bd3d2070da358f42f2
chrome
bigvul
1
null
null
null
Set Attr.ownerDocument in Element#setAttributeNode() Attr objects can move across documents by setAttributeNode(). So It needs to reset ownerDocument through TreeScopeAdoptr::adoptIfNeeded(). BUG=248950 TEST=set-attribute-node-from-iframe.html Review URL: https://chromiumcodereview.appspot.com/17583003 git-svn-id: svn://svn.chromium.org/blink/trunk@152938 bbb929c8-8fbe-4397-9dbb-9b2b20218538
4ac8bc08e3306f38a5ab3e551aef6ad43753579c
chrome
bigvul
1
null
null
null
<webview>: Update format for local file access in manifest.json The new format is: "webview" : { "partitions" : [ { "name" : "foo*", "accessible_resources" : ["a.html", "b.html"] }, { "name" : "bar", "accessible_resources" : ["a.html", "c.html"] } ] } BUG=340291 Review URL: https://codereview.chromium.org/151923005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@249640 0039d316-1c4b-4281-b951-d872f2087c98
2aa406a8b4577103e7b933c75ec0e372830f20fe
chrome
bigvul
1
null
null
null
Fix reentrance of BaseMultipleFieldsDateAndTimeInputType::destroyShadowSubtree. destroyShadowSubtree could dispatch 'blur' event unexpectedly because element()->focused() had incorrect information. We make sure it has correct information by checking if the UA shadow root contains the focused element. BUG=257353 Review URL: https://chromiumcodereview.appspot.com/19067004 git-svn-id: svn://svn.chromium.org/blink/trunk@154086 bbb929c8-8fbe-4397-9dbb-9b2b20218538
79cfdeb5fbe79fa2604d37fba467f371cb436bc3
chrome
bigvul
1
null
null
null
Linux: Add yet another workaround to keep 32-bit linkers from going OOM. (try 2) BUG=358546 [email protected] Review URL: https://codereview.chromium.org/225093005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261701 0039d316-1c4b-4281-b951-d872f2087c98
f10a164b2bd928c3cc27d4d8cdc0ca1d9d09e2c0
chrome
bigvul
1
null
null
null
Refactor to support default Bluetooth pairing delegate In order to support a default pairing delegate we need to move the agent service provider delegate implementation from BluetoothDevice to BluetoothAdapter while retaining the existing API. BUG=338492 TEST=device_unittests, unit_tests, browser_tests Review URL: https://codereview.chromium.org/148293003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252216 0039d316-1c4b-4281-b951-d872f2087c98
d358f57009b85fb7440208afa5ba87636b491889
chrome
bigvul
1
null
null
null
Display confirmation dialog for untrusted signins BUG=252062 Review URL: https://chromiumcodereview.appspot.com/17482002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@208520 0039d316-1c4b-4281-b951-d872f2087c98
afbc71b7a78ac99810a6b22b2b0a2e85dde18794
chrome
bigvul
1
null
null
null
Fix syncing of NPAPI plugins. This fix adds a check for |plugin| permission while syncing NPAPI plugins. BUG=252034 Review URL: https://chromiumcodereview.appspot.com/16816024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207830 0039d316-1c4b-4281-b951-d872f2087c98
8c95ab0b50f8a257514f9647929267e62b1e611d
chrome
bigvul
1
null
null
null
Remove stale comment about Chrome Frame. BUG=316496 NOTRY=true [email protected] Review URL: https://codereview.chromium.org/138053005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245153 0039d316-1c4b-4281-b951-d872f2087c98
2d308fc6c8c0fd86510a6f4415d8b247ceb454e6
chrome
bigvul
1
null
null
null
Revert a workaround commit for a Use-After-Free crash. Revert a workaround commit r20158 for a Use-After-Free issue (http://crbug.com/244746) because a cleaner CL r207218 is landed. URLRequestContext does not inherit SupportsWeakPtr now. R=mmenke BUG=244746 Review URL: https://chromiumcodereview.appspot.com/16870008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207811 0039d316-1c4b-4281-b951-d872f2087c98
ca8cc70b2de822b939f87effc7c2b83bac280a44
chrome
bigvul
1
null
null
null
net: don't process truncated headers on HTTPS connections. This change causes us to not process any headers unless they are correctly terminated with a \r\n\r\n sequence. BUG=244260 Review URL: https://chromiumcodereview.appspot.com/15688012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202927 0039d316-1c4b-4281-b951-d872f2087c98
9c18dbcb79e5f700c453d1ac01fb6d8768e4844a
chrome
bigvul
1
null
null
null
cc: Simplify raster task completion notification logic (Relanding after missing activation bug fixed in https://codereview.chromium.org/131763003/) Previously the pixel buffer raster worker pool used a combination of polling and explicit notifications from the raster worker pool to decide when to tell the client about the completion of 1) all tasks or 2) the subset of tasks required for activation. This patch simplifies the logic by only triggering the notification based on the OnRasterTasksFinished and OnRasterTasksRequiredForActivationFinished calls from the worker pool. BUG=307841,331534 Review URL: https://codereview.chromium.org/99873007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243991 0039d316-1c4b-4281-b951-d872f2087c98
db97b49fdd856f33bd810db4564c6f2cc14be71a
chrome
bigvul
1
null
null
null
Setting input.x-webkit-speech should not cause focus change In r150866, we introduced element()->focus() in destroyShadowSubtree() to retain focus on <input> when its type attribute gets changed. But when x-webkit-speech attribute is changed, the element is detached before calling destroyShadowSubtree() and element()->focus() failed This patch moves detach() after destroyShadowSubtree() to fix the problem. BUG=243818 TEST=fast/forms/input-type-change-focusout.html NOTRY=true Review URL: https://chromiumcodereview.appspot.com/16084005 git-svn-id: svn://svn.chromium.org/blink/trunk@151444 bbb929c8-8fbe-4397-9dbb-9b2b20218538
bb9cfb0aba25f4b13e57bdd4a9fac80ba071e7b9
chrome
bigvul
1
null
null
null
Allow sandboxed OS X processes to open /dev/urandom Match Linux/POSIX and Windows in allowing sandboxed processes access to OS entropy (RtlGenRandom on Win, /dev/urandom on Linux/POSIX). BUG=242702 R=jeremy [email protected], [email protected] Review URL: https://chromiumcodereview.appspot.com/15637004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202267 0039d316-1c4b-4281-b951-d872f2087c98
0847a72a829a980801b75b1722c1a03847cd8e4f
chrome
bigvul
1
null
null
null
Protect WebURLLoaderImpl::Context while receiving responses. A client's didReceiveResponse can cancel a request; by protecting the Context we avoid a use after free in this case. Interestingly, we really had very good warning about this problem, see https://codereview.chromium.org/11900002/ back in January. R=darin BUG=241139 Review URL: https://chromiumcodereview.appspot.com/15738007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202821 0039d316-1c4b-4281-b951-d872f2087c98
370bd9b522d2ccd4a3113d6c93d30cdf8ca502ef
chrome
bigvul
1
null
null
null
DevTools: handle devtools renderer unresponsiveness during beforeunload event interception This patch fixes the crash which happenes under the following conditions: 1. DevTools window is in undocked state 2. DevTools renderer is unresponsive 3. User attempts to close inspected page BUG=322380 Review URL: https://codereview.chromium.org/84883002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@237611 0039d316-1c4b-4281-b951-d872f2087c98
c0da7c1c6e9ffe5006e146b6426f987238d4bf2e
chrome
bigvul
1
null
null
null
Updating expectations after https://src.chromium.org/viewvc/blink?view=rev&revision=150456 TBR=pdr BUG=233848 Review URL: https://codereview.chromium.org/15733009 git-svn-id: svn://svn.chromium.org/blink/trunk@151015 bbb929c8-8fbe-4397-9dbb-9b2b20218538
a620e0ac86bfaa6ebfd1e55aea33a2e1d2f56989
chrome
bigvul
1
null
null
null
Don't allow extensions to take screenshots of interstitial pages. Branched from https://codereview.chromium.org/14885004/ which is trying to test it. BUG=229504 Review URL: https://chromiumcodereview.appspot.com/14954004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198297 0039d316-1c4b-4281-b951-d872f2087c98
016da29386308754274675e65fdb73cf9d59dc2d
chrome
bigvul
1
null
null
null
libxml: XML_PARSER_EOF checks from upstream BUG=229019 TBR=cpu Review URL: https://chromiumcodereview.appspot.com/14053009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@196804 0039d316-1c4b-4281-b951-d872f2087c98
d0947db40187f4708c58e64cbd6013faf9eddeed
chrome
bigvul
1
null
null
null
Implement range reading for NetworkReaderProxy. The feature is not yet actually used, but will be used for range reading of DriveFileStreamReader. BUG=127129 TEST=Ran unit_tests Review URL: https://chromiumcodereview.appspot.com/14493008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@196636 0039d316-1c4b-4281-b951-d872f2087c98
57fb5393bf051c590769c9b5723d5a9f4090a4cc
chrome
bigvul
1
null
null
null
Upgrade a TextIterator ASSERT to a RELEASE_ASSERT as a defensive measure. BUG=156930,177197 [email protected] Review URL: https://codereview.chromium.org/15057010 git-svn-id: svn://svn.chromium.org/blink/trunk@150123 bbb929c8-8fbe-4397-9dbb-9b2b20218538
09fbb829eab7ee25e90bb4e9c2f4973c6c62d0f3
chrome
bigvul
1
null
null
null
drive: Stop calling OnChangeListLoadComplete() if DirectoryFetchInfo is not empty Call LoadAfterLoadDirectory() instead. BUG=333164 TEST=unit_tests Review URL: https://codereview.chromium.org/132503004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244406 0039d316-1c4b-4281-b951-d872f2087c98
d57ecffa058b2af3b0678c43dce75f731550bbce
chrome
bigvul
1
null
null
null
Make the content setting for webcam/mic sticky for Pepper requests. This makes the content setting sticky for webcam/mic requests from Pepper from non-https origins. BUG=249335 [email protected], [email protected] Review URL: https://codereview.chromium.org/17060006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@206479 0039d316-1c4b-4281-b951-d872f2087c98
69827e08e9e0a30ce452589705d7336edaffd490
chrome
bigvul
1
null
null
null
Fix infinite loading for small images in Files.app. When images are small and the same as thumbnails, then the onload callback is not called. This patch fixes this by explicitely clearing the src attribute before any load. TEST=Follow the bug's repro steps on Drive. The image should load fast. BUG=248235 Review URL: https://chromiumcodereview.appspot.com/16124013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205782 0039d316-1c4b-4281-b951-d872f2087c98
c0e65d015f233b15a2dbf751e958fabc5d802322
chrome
bigvul
1
null
null
null
Wire InstallFinished and add some InstallEvent.waitUntil tests BUG=285976 TEST=content_browsertests:ServiceWorkerVersionBrowserTest.Install* Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=250804 Review URL: https://codereview.chromium.org/153553008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250936 0039d316-1c4b-4281-b951-d872f2087c98
a5333583f14284a411abac2fef7caed889a8bba3
chrome
bigvul
1
null
null
null
GetFileHandleForProcess should check for INVALID_HANDLE_VALUE BUG=243339 [email protected] Review URL: https://codereview.chromium.org/16020004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202207 0039d316-1c4b-4281-b951-d872f2087c98
6f62e3b41fe9ef708aa8c990dd814ae91d68f2f4
chrome
bigvul
1
null
null
null
Add security comment for the InjectedScriptHost. BUG=242322 [email protected] Review URL: https://codereview.chromium.org/15808005 git-svn-id: svn://svn.chromium.org/blink/trunk@151122 bbb929c8-8fbe-4397-9dbb-9b2b20218538
482ed745fb07a9642504fae676ab901ee79c73dc
chrome
bigvul
1
null
null
null
Map posix error codes in bind better, and fix one windows mapping. r=wtc BUG=330233 Review URL: https://codereview.chromium.org/101193008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242224 0039d316-1c4b-4281-b951-d872f2087c98
e68fafe04d29810cebe8d25554863b0cae4c1356
chrome
bigvul
1
null
null
null
Error event was fired synchronously blowing away the input element from underneath. Remove the FIXME and fire it asynchronously using errorEventSender(). BUG=240124 Review URL: https://chromiumcodereview.appspot.com/14741011 git-svn-id: svn://svn.chromium.org/blink/trunk@150232 bbb929c8-8fbe-4397-9dbb-9b2b20218538
7d085fbb43b21e959900b94f191588fd10546a94
chrome
bigvul
1
null
null
null
Added daily UMA for non-data-reduction-proxy data usage when the proxy is enabled. BUG=325325 Review URL: https://codereview.chromium.org/106113002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239897 0039d316-1c4b-4281-b951-d872f2087c98
828eab2216a765dea92575c290421c115b8ad028
chrome
bigvul
1
null
null
null
Named access checks on DOMWindow miss navigator The design of the named access check is very fragile. Instead of doing the access check at the same time as the access, we need to check access in a separate operation using different parameters. Worse, we need to implement a part of the access check as a blacklist of dangerous properties. This CL expands the blacklist slightly by adding in the real named properties from the DOMWindow instance to the current list (which included the real named properties of the shadow object). In the longer term, we should investigate whether we can change the V8 API to let us do the access check in the same callback as the property access itself. BUG=237022 Review URL: https://chromiumcodereview.appspot.com/15346002 git-svn-id: svn://svn.chromium.org/blink/trunk@150616 bbb929c8-8fbe-4397-9dbb-9b2b20218538
4801ff6578b3976731b13657715dcbe916c6a221
chrome
bigvul
1
null
null
null
Revert 225538 "Leaking locale changes is a Very Bad Idea." > Leaking locale changes is a Very Bad Idea. > > BUG=298893,298900 > TEST=tests stop failing > [email protected] > > Review URL: https://codereview.chromium.org/24809002 [email protected] Review URL: https://codereview.chromium.org/24815002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225546 0039d316-1c4b-4281-b951-d872f2087c98
9308eb92bdd3c17a39632e5c9eecb6cc2283897b
chrome
bigvul
1
null
null
null
Upgrade old app host to new app launcher on startup This patch is a continuation of https://codereview.chromium.org/16805002/. BUG=248825 Review URL: https://chromiumcodereview.appspot.com/17022015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@209604 0039d316-1c4b-4281-b951-d872f2087c98
508b89a64ab700aa09f21fc666a5588b47360eab
chrome
bigvul
1
null
null
null
Fix crash in CreateAuthenticatorFactory(). CreateAuthenticatorFactory() is called asynchronously, but it didn't handle the case when it's called after host object is destroyed. BUG=150644 Review URL: https://codereview.chromium.org/11090036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@161077 0039d316-1c4b-4281-b951-d872f2087c98
a3b76c8c13ea6b228122440f48c61b66d20443dd
chrome
bigvul
1
null
null
null
Don't call SSL read/write callbacks after an SSL socket is deleted BUG=232633 R=wtc Review URL: https://chromiumcodereview.appspot.com/14981005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@199806 0039d316-1c4b-4281-b951-d872f2087c98
be90ba35ee62e29d5440124dd11068a3e741ba5f
chrome
bigvul
1
null
null
null
Android: stash the binding status in ChildProcessConnection upon disconnection. This patch makes ChildProcessConnection stash the status of its oom bindings when the connection disconnects (closes unexpectedly) and exposes this status in ChildProcessConnection::isOomProtectedOrWasWhenDied(). This value in turn is stashed in the BindingManager when the connection reference is cleared. These two layers of stashing ensure that queries about the oom binding status are answered correctly on every stage of renderer crash, including after the connection is cleared and removed from ChildProcessLauncher. In return we can drop counting of the oom bindings in BindingManager - eliminating duplication and simplifying the logic. BUG=294947 Review URL: https://codereview.chromium.org/102303002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239134 0039d316-1c4b-4281-b951-d872f2087c98
c70071d1b25ef0100452c3ce305911276174ae71
chrome
bigvul
1
null
null
null
shell_aura: Set child to root window size, not host size The host size is in pixels and the root window size is in scaled pixels. So, using the pixel size may make the child window much larger than the root window (and screen). Fix this by matching the root window size. BUG=335713 TEST=ozone content_shell with --force-device-scale-factor=2 Review URL: https://codereview.chromium.org/141853003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@246389 0039d316-1c4b-4281-b951-d872f2087c98
26160ce25e305d686ca5df192378d2f5310ca0ee
chrome
bigvul
1
null
null
null
DIAL (Discovery and Launch protocol) extension API skeleton. This implements the skeleton for a new Chrome extension API for local device discovery. The API will first be restricted to whitelisted extensions only. The API will allow extensions to receive events from a DIAL service running within Chrome which notifies of devices being discovered on the local network. Spec available here: https://docs.google.com/a/google.com/document/d/14FI-VKWrsMG7pIy3trgM3ybnKS-o5TULkt8itiBNXlQ/edit BUG=163288 [email protected] Review URL: https://chromiumcodereview.appspot.com/11444020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@172243 0039d316-1c4b-4281-b951-d872f2087c98
0f05aa7e29cf814a204830c82ba2619f9c636894
chrome
bigvul
1
null
null
null
Add permission checks for PPB_Buffer. BUG=116317 TEST=browser_tests Review URL: https://chromiumcodereview.appspot.com/11446075 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171951 0039d316-1c4b-4281-b951-d872f2087c98
7df06970ff05d4b412534f6deea89c9b9ac4be67
chrome
bigvul
1
null
null
null
Disable some more query compositingState asserts. This gets the tests passing again on Mac. See the bug for the stacktrace. A future patch will need to actually fix the incorrect reading of compositingState. BUG=343179 Review URL: https://codereview.chromium.org/162153002 git-svn-id: svn://svn.chromium.org/blink/trunk@167069 bbb929c8-8fbe-4397-9dbb-9b2b20218538
634c5943f46abe8c6280079f6d394dfee08c3c8f
chrome
bigvul
1
null
null
null
Add HTMLFormControlElement::supportsAutofocus to fix a FIXME comment. This virtual function should return true if the form control can hanlde 'autofocucs' attribute if it is specified. Note: HTMLInputElement::supportsAutofocus reuses InputType::isInteractiveContent because interactiveness is required for autofocus capability. BUG=none TEST=none; no behavior changes. Review URL: https://codereview.chromium.org/143343003 git-svn-id: svn://svn.chromium.org/blink/trunk@165432 bbb929c8-8fbe-4397-9dbb-9b2b20218538
25f9415f43d607d3d01f542f067e3cc471983e6b
chrome
bigvul
1
null
null
null
Disable failing WebGL Field pyauto-based perf test on all platforms. BUG=132797 TEST=None NOTRY=true Review URL: https://chromiumcodereview.appspot.com/10540161 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142169 0039d316-1c4b-4281-b951-d872f2087c98
0fdf268ee945968dfa81e44ec017030add608613
chrome
bigvul
1
null
null
null
[4/4] Process clearBrowserCahce/cookies commands in browser. BUG=366585 Review URL: https://codereview.chromium.org/251183005 git-svn-id: svn://svn.chromium.org/blink/trunk@172984 bbb929c8-8fbe-4397-9dbb-9b2b20218538
4c39b8e5670c4a0f2bb06008502ebb0c4fe322e0
chrome
bigvul
1
null
null
null
Tighten restrictions on hosted apps calling extension APIs Only allow component apps to make any API calls, and for them only allow the namespaces they explicitly have permission for (plus chrome.test - I need to see if I can rework some WebStore tests to remove even this). BUG=172369 Review URL: https://chromiumcodereview.appspot.com/12095095 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180426 0039d316-1c4b-4281-b951-d872f2087c98
f335421145bb7f82c60fb9d61babcd6ce2e4b21e
chrome
bigvul
1
null
null
null
Implement TextureImageTransportSurface using texture mailbox This has a couple of advantages: - allow tearing down and recreating the UI parent context without losing the renderer contexts - do not require a context to be able to generate textures when creating the GLSurfaceHandle - clearer ownership semantics that potentially allows for more robust and easier lost context handling/thumbnailing/etc., since a texture is at any given time owned by either: UI parent, mailbox, or TextureImageTransportSurface - simplify frontbuffer protection logic; the frontbuffer textures are now owned by RWHV where they are refcounted The TextureImageTransportSurface informs RenderWidgetHostView of the mailbox names for the front- and backbuffer textures by associating them with a surface_handle (1 or 2) in the AcceleratedSurfaceNew message. During SwapBuffers() or PostSubBuffer() cycles, it then uses produceTextureCHROMIUM() and consumeTextureCHROMIUM() to transfer ownership between renderer and browser compositor. RWHV sends back the surface_handle of the buffer being returned with the Swap ACK (or 0 if no buffer is being returned in which case TextureImageTransportSurface will allocate a new texture - note that this could be used to simply keep textures for thumbnailing). BUG=154815,139616 [email protected] Review URL: https://chromiumcodereview.appspot.com/11194042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171569 0039d316-1c4b-4281-b951-d872f2087c98
18d67244984a574ba2dd8779faabc0e3e34f4b76
chrome
bigvul
1
null
null
null
Blink roll 171065:171077 http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=171065:171077&mode=html BUG= Review URL: https://codereview.chromium.org/229093002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262533 0039d316-1c4b-4281-b951-d872f2087c98
19fb4369b673d8c8a130d7c7fb2fd1251328bee4
chrome
bigvul
1
null
null
null
Mark fast/js/const.html for rebaseline, and fix illegal javascript in rubberband test [email protected] BUG= Review URL: https://codereview.chromium.org/224833006 git-svn-id: svn://svn.chromium.org/blink/trunk@170836 bbb929c8-8fbe-4397-9dbb-9b2b20218538
3034f8c3cf3779d5864d5323cd0a151f79308fea
chrome
bigvul
1
null
null
null
For "Dangerous" file type, no user gesture will bypass the download warning. BUG=170569 Review URL: https://codereview.chromium.org/12039015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@178072 0039d316-1c4b-4281-b951-d872f2087c98
1538367452b549d929aabb13d54c85ab99f65cd3
chrome
bigvul
1
null
null
null
Fix crash when creating an ImageBitmap from an invalid canvas BUG=354356 Review URL: https://codereview.chromium.org/211313003 git-svn-id: svn://svn.chromium.org/blink/trunk@169973 bbb929c8-8fbe-4397-9dbb-9b2b20218538
e9c887a80115ddc5c011380f132fe4b36359caf0
chrome
bigvul
1
null
null
null
Check for a negative integer properly. BUG=169966 Review URL: https://chromiumcodereview.appspot.com/11892002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176879 0039d316-1c4b-4281-b951-d872f2087c98
d443be6fdfe17ca4f3ff1843ded362ff0cd01096
chrome
bigvul
1
null
null
null
Avoid integer overflows in BlobURLRequestJob. BUG=169685 Review URL: https://chromiumcodereview.appspot.com/12047012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@179154 0039d316-1c4b-4281-b951-d872f2087c98
58936737b65052775b67b1409b87edbbbc09f72b
chrome
bigvul
1
null
null
null
Fix crash with mismatched vector sizes. BUG=169295 Review URL: https://codereview.chromium.org/11817050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176252 0039d316-1c4b-4281-b951-d872f2087c98
3b2943f5d343f5da393b99fe9efe6cefc6856aa1
chrome
bigvul
1
null
null
null
IPC: defend against excessive number of submenu entries in PPAPI message. BUG=168710 Review URL: https://codereview.chromium.org/11794037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175576 0039d316-1c4b-4281-b951-d872f2087c98
42d87b0bec018634ec81a72d3b265f3138d75e1d
chrome
bigvul
1
null
null
null
DevTools: remove references to modules/device_orientation from core BUG=340221 Review URL: https://codereview.chromium.org/150913003 git-svn-id: svn://svn.chromium.org/blink/trunk@166493 bbb929c8-8fbe-4397-9dbb-9b2b20218538
da5e5f78f02bc0af5ddc5694090defbef7853af1
chrome
bigvul
1
null
null
null
Blink roll 165830:165836 http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=165831:165836&mode=html TBR= BUG= Review URL: https://codereview.chromium.org/136753010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247220 0039d316-1c4b-4281-b951-d872f2087c98
9568632948d1e96777d3fcc023f35283f7998c0e
chrome
bigvul
1
null
null
null
Don't use gradient for strips on network panel. BUG=335095 Review URL: https://codereview.chromium.org/145643002 git-svn-id: svn://svn.chromium.org/blink/trunk@165747 bbb929c8-8fbe-4397-9dbb-9b2b20218538
013213b56835d1d6d5f2981665ae2618a47a8ebf
chrome
bigvul
1
null
null
null
inspector/profiler/heap-snapshot-loader.html is still flaky BUG=330617 [email protected] Review URL: https://codereview.chromium.org/136103005 git-svn-id: svn://svn.chromium.org/blink/trunk@164958 bbb929c8-8fbe-4397-9dbb-9b2b20218538
e4e65d90ea643a7f46a3cb6ae9f59795e8a47d4c
chrome
bigvul
1
null
null
null
Sizes going across an IPC should be uint32. BUG=164946 Review URL: https://chromiumcodereview.appspot.com/11472038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171944 0039d316-1c4b-4281-b951-d872f2087c98
0ab5fab4939150bd0f30ada8a4bf6eb0f69d66c1
chrome
bigvul
1
null
null
null
Apply 'x-content-type-options' check to dynamically inserted script. BUG=348581 Review URL: https://codereview.chromium.org/185593011 git-svn-id: svn://svn.chromium.org/blink/trunk@168570 bbb929c8-8fbe-4397-9dbb-9b2b20218538
ed6f4545a2a345697e07908c887333f5bdcc97a3
chrome
bigvul
1
null
null
null
Update FFmpeg DEPS for security fix. Pulls in: fe7d549 Update README for security fix. 9d8789e vorbisdec: Check bark_map_size. c81a7da Explicitly set cygwin_msvs_shell on BUG=168473 TEST=unittests, manual. TBR=scherkus Review URL: https://chromiumcodereview.appspot.com/11889018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176861 0039d316-1c4b-4281-b951-d872f2087c98
6130e7b6da93abf7b3fabd12591e8d5ccb16b2c9
chrome
bigvul
1
null
null
null
Fix creating target paths in file_util_posix CopyDirectory. BUG=167840 Review URL: https://chromiumcodereview.appspot.com/11773018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176659 0039d316-1c4b-4281-b951-d872f2087c98
23803a58e481e464a787e4b2c461af9e62f03905
chrome
bigvul
1
null
null
null
Fix uninitialized access in QuicConnectionHelperTest BUG=159928 Review URL: https://chromiumcodereview.appspot.com/11360153 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166708 0039d316-1c4b-4281-b951-d872f2087c98
58c433b2426f8d23ad27f1976635506ee3643034
chrome
bigvul
1
null
null
null
Roll webkit version to 47277 BUG=none TEST=none Review URL: http://codereview.chromium.org/165537 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23446 0039d316-1c4b-4281-b951-d872f2087c98
d77579aada159a16969b48b247a1802564ba24ac
chrome
bigvul
1
null
null
null
Roll deps to pull in googleurl 183, which fixes a typo that caused a memory error. BUG=164643 Review URL: https://chromiumcodereview.appspot.com/12088032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@179645 0039d316-1c4b-4281-b951-d872f2087c98
b6a0cf748001e05cf048bff7b62daea50f0fcfdc
chrome
bigvul
1
null
null
null
Roll Opus DEPS 165487:173498. BUG=160480 Review URL: https://chromiumcodereview.appspot.com/11617015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173837 0039d316-1c4b-4281-b951-d872f2087c98
48bd56a2e1d715c94570c1c44ae1fd1e8778c837
chrome
bigvul
1
null
null
null
Roll ICU DEPS. TBR=tsepez BUG=152442 Review URL: https://chromiumcodereview.appspot.com/11607014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173696 0039d316-1c4b-4281-b951-d872f2087c98
e8cf6decd19f8e0391171f25a8948d3b324ec172
chrome
bigvul
1
null
null
null
Web Animations API: Ship Element.animate As proposed on blink-dev[1]. Note this doesn't flip any virtual/stable tests as a canary version of animate was enabled in r171017[2]. [1] https://groups.google.com/a/chromium.org/d/msg/blink-dev/SWxBI0uPvUE/iZCNwoN3nKEJ [2] https://src.chromium.org/viewvc/blink?revision=171017&view=revision BUG=360469 Review URL: https://codereview.chromium.org/248223003 git-svn-id: svn://svn.chromium.org/blink/trunk@172342 bbb929c8-8fbe-4397-9dbb-9b2b20218538
863f56d3c6cd49278a5e74a698f8a5371d066452
chrome
bigvul
1
null
null
null
Oilpan: Ship Oilpan for SyncCallbackHelper, CreateFileResult and CallbackWrapper in filesystem/ These are leftovers when we shipped Oilpan for filesystem/ once. BUG=340522 Review URL: https://codereview.chromium.org/501263003 git-svn-id: svn://svn.chromium.org/blink/trunk@180909 bbb929c8-8fbe-4397-9dbb-9b2b20218538
02c8303512ebed345011f7b545e2f418799be2f0
chrome
bigvul
1
null
null
null
Let the browser handle external navigations from DevTools. BUG=180555 Review URL: https://chromiumcodereview.appspot.com/12531004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@186793 0039d316-1c4b-4281-b951-d872f2087c98
0a57375ad73780e61e1770a9d88b0529b0dbd33b
chrome
bigvul
1
null
null
null