commit_msg
stringlengths 1
24.2k
| commit_hash
stringlengths 2
84
⌀ | project
stringlengths 2
40
| source
stringclasses 4
values | labels
int64 0
1
| repo_url
stringlengths 26
70
⌀ | commit_url
stringlengths 74
118
⌀ | commit_date
stringlengths 25
25
⌀ |
|---|---|---|---|---|---|---|---|
Enforce SVG image security rules
SVG images have unique security rules that prevent them from loading
any external resources. This patch enforces these rules in
ResourceFetcher::canRequest for all non-data-uri resources. This locks
down our SVG resource handling and fixes two security bugs.
In the case of SVG images that reference other images, we had a bug
where a cached subresource would be used directly from the cache.
This has been fixed because the canRequest check occurs before we use
cached resources.
In the case of SVG images that use CSS imports, we had a bug where
imports were blindly requested. This has been fixed by stopping all
non-data-uri requests in SVG images.
With this patch we now match Gecko's behavior on both testcases.
BUG=380885, 382296
Review URL: https://codereview.chromium.org/320763002
git-svn-id: svn://svn.chromium.org/blink/trunk@176084 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | ee281f7cac9df44fe241a37f188b28be8845ded0 | chrome | bigvul | 1 | null | null | null |
Don't link application support into shell client library
We have some application support code stuffed in
services/shell/public/cpp which exports symbols to be
fixed up at runtime by the runner for early process
initialization. Any dependents will in turn export these
symbols, often unnecessarily.
This removes these sources from the public/cpp target
and introduces a new application_support target for
Mojo binaries to link against.
BUG=611911
[email protected]
Review-Url: https://codereview.chromium.org/1978083004
Cr-Commit-Position: refs/heads/master@{#393765} | e98fa42ceeeb3b146186cf2676109190aece9881 | chrome | bigvul | 1 | null | null | null |
[FileAPI] Clean up WebFileSystemImpl before Blink shutdown
WebFileSystemImpl should not outlive V8 instance, since it may have references to V8.
This CL ensures it deleted before Blink shutdown.
BUG=369525
Review URL: https://codereview.chromium.org/270633009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269345 0039d316-1c4b-4281-b951-d872f2087c98 | f14efc560a12a513696d6396413b138879dabd7a | chrome | bigvul | 1 | null | null | null |
These can post callbacks which re-enter into SpdyWriteQueue.
BUG=369539
Review URL: https://codereview.chromium.org/265933007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268730 0039d316-1c4b-4281-b951-d872f2087c98 | 2025798e133f9adc49b65d017dbb5cb2c5cc74c9 | chrome | bigvul | 1 | null | null | null |
System Clipboard: Remove extraneous check for bitmap.getPixels()
Bug 369621 originally led to this check being introduced via
https://codereview.chromium.org/289573002/patch/40001/50002, but after
https://crrev.com/c/1345809, I'm not sure that it's still necessary.
This change succeeds when tested against the "minimized test case" provided in
crbug.com/369621 's description, but I'm unsure how to make the minimized test
case fail, so this doesn't prove that the change would succeed against the
fuzzer's test case (which originally filed the bug).
As I'm unable to view the relevant fuzzer test case, (see crbug.com/918705),
I don't know exactly what may have caused the fuzzer to fail. Therefore,
I've added a CHECK for the time being, so that we will be notified in canary
if my assumption was incorrect.
Bug: 369621
Change-Id: Ie9b47a4b38ba1ed47624de776015728e541d27f7
Reviewed-on: https://chromium-review.googlesource.com/c/1393436
Reviewed-by: Daniel Cheng <[email protected]>
Reviewed-by: Kai Ninomiya <[email protected]>
Reviewed-by: Victor Costan <[email protected]>
Commit-Queue: Victor Costan <[email protected]>
Cr-Commit-Position: refs/heads/master@{#619591} | 0b694217046d6b2bfa5814676e8615c18e6a45ff | chrome | bigvul | 1 | null | null | null |
Replicate FFmpeg's video frame allocation strategy.
This should avoid accidental overreads and overwrites due to our
VideoFrame's not being as large as FFmpeg expects.
BUG=368980
TEST=new regression test
Review URL: https://codereview.chromium.org/270193002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268831 0039d316-1c4b-4281-b951-d872f2087c98 | 96e8ffb4e805c7266a2fc1fbe0e470052019bad9 | chrome | bigvul | 1 | null | null | null |
Changing the media notification stop icon
Changing the old-styled stop icon for Chrome's media notifications from
'x' to square.
BUG=549719
Review URL: https://codereview.chromium.org/1412063010
Cr-Commit-Position: refs/heads/master@{#358038} | fcdad2be07cb19e9f58b451599d14d2ff0b7b235 | chrome | bigvul | 1 | null | null | null |
Only loop when AccountIdProvider can be used.
Do not loop when AccountIdProvider can not be used. Instead, send out notifications to clear previous requests, and set state to SEEDING_NOT_STARTED to allow upcoming requests trigger the operation. Verified by manually uninstall Google play service updates to make AccountIdProvider can not be used.
BUG=533311,532560
Review URL: https://codereview.chromium.org/1355023002
Cr-Commit-Position: refs/heads/master@{#349898} | 7405a6243d55d229a2a6f13ad7396108a3f85ddd | chrome | bigvul | 1 | null | null | null |
Tracing: Add support for PII whitelisting of individual trace event arguments
R=dsinclair,shatch
BUG=546093
Review URL: https://codereview.chromium.org/1415013003
Cr-Commit-Position: refs/heads/master@{#356690} | 870f3e99a1282023753fe8d8aed90879cbc6838f | chrome | bigvul | 1 | null | null | null |
real_word_impact: Rename dump-render-tree switch to run-layout-test.
As the later is the preferred name and the former is the deprecated and
will be removed soon.
BUG=453252
[email protected]
Review URL: https://codereview.chromium.org/1356013002
Cr-Commit-Position: refs/heads/master@{#349903} | 42941dfd847a26070d8efc397268dd0ed759309c | chrome | bigvul | 1 | null | null | null |
Roll FreeType to 2.6.1 + 1.
Immediately after the VER-2-6-1 release is a desired bugfix.
Roll to get it.
List of changes can be seen at:
https://chromium.googlesource.com/chromium/src/third_party/freetype2/+log/8cabd919ca..30fe5e762e06
BUG=chromium:534621
Review URL: https://codereview.chromium.org/1394513002
Cr-Commit-Position: refs/heads/master@{#352851} | 4b6ff31958559ba8165ba7619ebeceb128e64002 | chrome | bigvul | 1 | null | null | null |
Fix syntax.
BUG=
[email protected]
Review URL: https://codereview.chromium.org/1369383002
Cr-Commit-Position: refs/heads/master@{#351103} | 83d4c623c6ff356c793092884dbd74b9da2a5d2d | chrome | bigvul | 1 | null | null | null |
Simplify xcode_settings block in common.gypi a bit.
- Mac builds are always 64-bit nowaydays
- Collapse two adjacent OS==ios conditions
No intended behavior change.
BUG=none
Review URL: https://codereview.chromium.org/1557823002
Cr-Commit-Position: refs/heads/master@{#367314} | ea6bdacc04396d48bd80fc40cf490ad238d88e4d | chrome | bigvul | 1 | null | null | null |
Fix crash if utterance is garbage-collected before speech ends.
BUG=359130,348863
Review URL: https://codereview.chromium.org/228133002
git-svn-id: svn://svn.chromium.org/blink/trunk@171077 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | 9a3dbf43f97aa7cb6b4399f9b11ce1de20f0680f | chrome | bigvul | 1 | null | null | null |
Auto-rebaseline for r360391
https://chromium.googlesource.com/chromium/src/+/122865bf
BUG=373502
[email protected]
Review URL: https://codereview.chromium.org/1454233002 .
Cr-Commit-Position: refs/heads/master@{#360429} | 1c15fc813aa3534443bba09275dfda9cf7dde6cd | chrome | bigvul | 1 | null | null | null |
Open distiller UI setting through JavaScript
This change adds support for opening the android view distiller
settings from JavaScript via "distiller.openSettings". To avoid
passing numerous objects into the DomDistillerViewerSource, the
ExternalFeedbackReporter has been refactored into a generic UI
handle that is responsible for any interaction between Chrome and
Android specific controls and the distiller component.
The actual UI in the page is not yet implemented.
BUG=
Review URL: https://codereview.chromium.org/1386043002
Cr-Commit-Position: refs/heads/master@{#354123} | dcd10462fb49c72544719c490238f3a35edf3fc6 | chrome | bigvul | 1 | null | null | null |
StackSamplingProfiler: walk a copy of the stack
Changes the stack walking strategy to copy the stack while the target
thread is suspended, then walk the copy of the stack after the thread
has been resumed. This avoids deadlock on locks taken by
RtlLookupFunctionEntry when walking the actual stack while the target
thread is suspended.
BUG=528129
Review URL: https://codereview.chromium.org/1367633002
Cr-Commit-Position: refs/heads/master@{#353004} | 0fb75f1e468fe9054be3b3d3d5b9bf9a66e4199d | chrome | bigvul | 1 | null | null | null |
Fix integer overflow in software compositor
Ensure that the size mapped from the renderer
process for the software frame is not less than
expected due to integer overflow.
BUG=348332
Review URL: https://codereview.chromium.org/196283018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257417 0039d316-1c4b-4281-b951-d872f2087c98 | ea994548ed483e234a6fadd0cbdfa10d58b75cef | chrome | bigvul | 1 | null | null | null |
Move variations prefs into the variations component
These prefs are used by variations code that is targeted for componentization.
BUG=382865
TBR=thakis
Review URL: https://codereview.chromium.org/1265423003
Cr-Commit-Position: refs/heads/master@{#343661} | 7cb8e1ae121cf6b14aa0a59cc708de630c0ef965 | chrome | bigvul | 1 | null | null | null |
Do not update attributes in HTMLBodyElement::insertedInto.
Use didNotifySubtreeInsertionsToDocument instead.
BUG=356095
TEST=automated
[email protected]
Review URL: https://codereview.chromium.org/212793007
git-svn-id: svn://svn.chromium.org/blink/trunk@170216 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | d22bd7ecd1cc576a1a586ee59d5e08d7eee6cdf3 | chrome | bigvul | 1 | null | null | null |
[MD settings] adding c++ side of clear browsing data
This CL is based on options version of same code/feature.
The counter and notification about incognito is not
yet included.
BUG=532739
Review URL: https://codereview.chromium.org/1367533003
Cr-Commit-Position: refs/heads/master@{#350434} | 31b2ef216cb19fb5cec60eb507d3b2b0d30cd648 | chrome | bigvul | 1 | null | null | null |
bluetooth: Add EXPORT macro to BluetoothAdapter::Observer.
Component build requires EXPORT macro when code from content
utilizes this class, as used in upcoming
https://codereview.chromium.org/1125133005
BUG=489330
Review URL: https://codereview.chromium.org/1140813004
Cr-Commit-Position: refs/heads/master@{#330626} | ad1b429e966f9f0fcaceb60938c7a00fe36c5cb1 | chrome | bigvul | 1 | null | null | null |
[Blob] [Perf] Reduced max blob size to allow lazy garbage collection.
BUG=506615
Review URL: https://codereview.chromium.org/1221193007
Cr-Commit-Position: refs/heads/master@{#337746} | 586dd807291bbdcbd82a30f514411737c8388941 | chrome | bigvul | 1 | null | null | null |
Add bsvc.dll to Chrome's Browser's Blacklist
Also add two older values to dllhash.
BUG=
Review URL: https://codereview.chromium.org/1110123002
Cr-Commit-Position: refs/heads/master@{#327295} | 056966e85df9d132d6ff8bcc5f68ad0eef7750e2 | chrome | bigvul | 1 | null | null | null |
Add filtering of IPC messages when RenderFrameHost is swapped out.
BUG=351815
Review URL: https://codereview.chromium.org/205543002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@258521 0039d316-1c4b-4281-b951-d872f2087c98 | da9a32b9e282c1653bb6b5c1b8c89a1970905f21 | chrome | bigvul | 1 | null | null | null |
window.atob() returns wrong value when given a string container only white spaces
window.atob() returns wrong value when given a string container only white
spaces. The reason was that base64DecodeInternal() was calling Vector::grow()
before the loop but failed to call Vector::shrink() in case of early return.
R=
BUG=357332
Review URL: https://codereview.chromium.org/215833002
git-svn-id: svn://svn.chromium.org/blink/trunk@170264 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | 91b27188b728e90c651c55a985d23ad0c26eb662 | chrome | bigvul | 1 | null | null | null |
Add a unit test that filenames aren't unintentionally converted to URLs.
Also fixes two issues in OSExchangeDataProviderWin:
- It used a disjoint set of clipboard formats when handling
GetUrl(..., true /* filename conversion */) vs GetFilenames(...), so the
actual returned results would vary depending on which one was called.
- It incorrectly used ::DragFinish() instead of ::ReleaseStgMedium().
::DragFinish() is only meant to be used in conjunction with WM_DROPFILES.
BUG=346135
Review URL: https://codereview.chromium.org/380553002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283226 0039d316-1c4b-4281-b951-d872f2087c98 | e93dc535728da259ec16d1c3cc393f80b25f64ae | chrome | bigvul | 1 | null | null | null |
RendererWebColorChooserImpl shouldn't be destroyed by RenderViewObserver::OnDestruct
RenderWebColorChooserImpl is owned by blink::ColorChooserUIController so it should not be destroyed in RenderViewObserver::OnDestruct
BUG=342735
Review URL: https://codereview.chromium.org/181233006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255276 0039d316-1c4b-4281-b951-d872f2087c98 | c0be143193b370e1e1ee268e480f15f2684e1d66 | chrome | bigvul | 1 | null | null | null |
Use invalidation sets for :read-only and :read-write.
Gets rid of SubtreeStyleChange which relies on sibling tree recalcs.
[email protected],[email protected]
BUG=557440
Review URL: https://codereview.chromium.org/1454003002
Cr-Commit-Position: refs/heads/master@{#360298} | 30b0f37300f8d671d29d91102ec7f475ed4cf7fe | chrome | bigvul | 1 | null | null | null |
MacViews: Implement a Menu style to match Yosemite
Menus in MacViews currently look like Mavericks. Yosemite menus are
darker, more transparent and blur the background. The first two are
straightforward. To blur, use CGSSetWindowBackgroundBlurRadius(), which
is also present in 10.6. However, the new style will only be used when
running on Yosemite or later.
When stepping up the transparency on the canvas background, subpixel AA
became a mess. For a nice fix, use a solid canvas background but make
the CALayer hosting the compositor translucent instead.
BUG=522365
Review URL: https://codereview.chromium.org/1314113003
Cr-Commit-Position: refs/heads/master@{#345820} | cf934a2f15606819f9d5f214f6b36c129fadb9ac | chrome | bigvul | 1 | null | null | null |
Fix more aspects of the NaCl build configs.
As part of the un-forking of the NaCl GN build configs, we need
to be a little more careful about which NaCl toolchains are considered
to be "clang" or not and whether some of the clang-specific compiler
settings need to be applied in the NaCl contexts.
Also, remove more stray references to the old Nacl build configs.
[email protected], [email protected], [email protected]
BUG=433528
Review URL: https://codereview.chromium.org/1307653008
Cr-Commit-Position: refs/heads/master@{#347262} | b8c6bf7592cf6cb412f2d3f151bc29bd96ee7380 | chrome | bigvul | 1 | null | null | null |
Allow automatic search engine detection on https
BUG=521128
Review URL: https://codereview.chromium.org/1393113002
Cr-Commit-Position: refs/heads/master@{#352982} | 3454ed7b88318dcd4539c6e1a50d27b0ca535686 | chrome | bigvul | 1 | null | null | null |
Shutdown Timebomb - In canary, get a callstack if it takes longer than
10 minutes. In Dev, get callstack if it takes longer than 20 minutes.
In Beta (50 minutes) and Stable (100 minutes) it is same as before.
BUG=519321
[email protected]
Review URL: https://codereview.chromium.org/1409333005
Cr-Commit-Position: refs/heads/master@{#355586} | 9ad7483d8e7c20e9f1a5a08d00150fb51899f14c | chrome | bigvul | 1 | null | null | null |
Use a new field trial group to enable the SWReporter
BUG=533484
Review URL: https://codereview.chromium.org/1376803002
Cr-Commit-Position: refs/heads/master@{#351788} | 3e5dae3b38fdb566fb2b7183e810b82eb3ce6f21 | chrome | bigvul | 1 | null | null | null |
[CSS Grid Layout] Implement auto-margins alignment of grid items
The Grid Layout spec states that we must center items with auto margins,
so it will absorb any positive free space, both horiontal and vertical.
https://drafts.csswg.org/css-grid/#auto-margins
Besides, auto-margins imply that any alignment property in the same axis
will have no effect
BUG=79180, 249451, 376823
Review URL: https://codereview.chromium.org/1298623002
Cr-Commit-Position: refs/heads/master@{#351796} | 68a823dcd4e9c63a0d324bc96695fd010d734d87 | chrome | bigvul | 1 | null | null | null |
Adding omnibox to components on iOS.
BUG=459705
Review URL: https://codereview.chromium.org/1380073002
Cr-Commit-Position: refs/heads/master@{#351811} | 22171413466e1c3673022c572f06180e386481a7 | chrome | bigvul | 1 | null | null | null |
Add bounds validation to AsyncPixelTransfersCompletedQuery::End
BUG=351852
[email protected], [email protected]
Review URL: https://codereview.chromium.org/198253002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256723 0039d316-1c4b-4281-b951-d872f2087c98 | b71fc042e1124cda2ab51dfdacc2362da62779a6 | chrome | bigvul | 1 | null | null | null |
Create PaintChunk and begin writing code to build paint chunks.
BUG=537409
Review URL: https://codereview.chromium.org/1379883003
Cr-Commit-Position: refs/heads/master@{#352369} | 55136969558bd7d8b3456cd1447442a5425fd9df | chrome | bigvul | 1 | null | null | null |
document.location bindings fix
BUG=352374
[email protected]
Review URL: https://codereview.chromium.org/196343011
git-svn-id: svn://svn.chromium.org/blink/trunk@169176 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | f85a87ec670ad0fce9d98d90c9a705b72a288154 | chrome | bigvul | 1 | null | null | null |
Refactor ui::Clipboard::ObjectMap sanitization in ClipboardMsgFilter.
BUG=352395
[email protected]
[email protected]
Review URL: https://codereview.chromium.org/200523004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257164 0039d316-1c4b-4281-b951-d872f2087c98 | 5b0d76edd5d6d4054b2e1263e23c852226c5f701 | chrome | bigvul | 1 | null | null | null |
Enable testing of WebRTC IP Permission Finch
BUG=538815
Review URL: https://codereview.chromium.org/1380893005
Cr-Commit-Position: refs/heads/master@{#352420} | efce5aa89bc5ac68f96184e44c4bb4b8c3a985e8 | chrome | bigvul | 1 | null | null | null |
Consistently check if a block can handle pagination strut propagation.
https://codereview.chromium.org/1360753002 got it right for inline child
layout, but did nothing for block child layout.
BUG=329421
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1387553002
Cr-Commit-Position: refs/heads/master@{#352429} | ce70785c73a2b7cf2b34de0d8439ca31929b4743 | chrome | bigvul | 1 | null | null | null |
Connect WebUSB client interface to the devices app
This provides a basic WebUSB client interface in
content/renderer. Most of the interface is unimplemented,
but this CL hooks up navigator.usb.getDevices() to the
browser's Mojo devices app to enumerate available USB
devices.
BUG=492204
Review URL: https://codereview.chromium.org/1293253002
Cr-Commit-Position: refs/heads/master@{#344881} | d926098e2e2be270c80a5ba25ab8a611b80b8556 | chrome | bigvul | 1 | null | null | null |
Add cross-origin BindingsSecurity checks to 'EventTarget::dispatchEvent'.
BUG=342618
Review URL: https://codereview.chromium.org/150203016
git-svn-id: svn://svn.chromium.org/blink/trunk@166999 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | 1842dcb929820618efbc5fabda7c82d08846c25a | chrome | bigvul | 1 | null | null | null |
Move smart deploy to tristate.
BUG=
Review URL: https://codereview.chromium.org/1149383006
Cr-Commit-Position: refs/heads/master@{#333058} | 318530d771586b39056c0da7b8bdad03469a0dc4 | chrome | bigvul | 1 | null | null | null |
Remove fallback when requesting a single USB interface.
This reverts commit 2d475d0ed37bf8f19385537ad31e361f1b21624b. The
permission broker now supports opening devices that are partially
claimed through the OpenPath method and RequestPathAccess will always
fail for these devices so the fallback path from RequestPathAccess to
OpenPath is always taken.
BUG=500057
Review URL: https://codereview.chromium.org/1227313003
Cr-Commit-Position: refs/heads/master@{#338354} | 0ebe983f1cfdd383a4954127f564b83a4fe4992f | chrome | bigvul | 1 | null | null | null |
content: Rename webkit_test_helpers.{cc,h} to blink_test_helpers.{cc,h}
Now that webkit/ is gone, we are preparing ourselves for the merge of
third_party/WebKit into //blink.
BUG=None
BUG=content_shell && content_unittests
[email protected]
Review URL: https://codereview.chromium.org/1118183003
Cr-Commit-Position: refs/heads/master@{#328202} | 685c3980d31b5199924086b8c93a1ce751d24733 | chrome | bigvul | 1 | null | null | null |
Re-land: telemetry: Add a page set for blink's memory usage measurement
Added decorator as a workaround for crbug.com/532075
Original description:
The page set will be used as metrics for tracking memory
reduction efforts on Blink. Details can be found at [1].
[1] https://docs.google.com/document/d/1zlGQkwkWEu5LUg-CrZHHRuhDtZcuvrRv8bjdC8-noaU/edit?usp=sharing
TBR=nednguyen,perezju
BUG=524338
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_nexus5_perf_bisect
Review URL: https://codereview.chromium.org/1343193002
Cr-Commit-Position: refs/heads/master@{#349079} | ee2e4879fc7df806647427ea9a7553c183de9702 | chrome | bigvul | 1 | null | null | null |
Add a setDebugDirtyRegion() feature to the client.
Calling remoting.clientSession.setDebugDirtyRegion(true) enables
rendering of each frame's dirty region with an purple, translucent
overlay.
Currently the dirty region is re-rendered immediately for each frame,
with no linger nor fade-out behaviour.
BUG=427659
Review URL: https://codereview.chromium.org/932013002
Cr-Commit-Position: refs/heads/master@{#317496} | dde871628c04863cf5992cb17e3e40f2ba576279 | chrome | bigvul | 1 | null | null | null |
cc: Make the PictureLayerImpl raster source null until commit.
No need to make a raster source that is never used.
R=enne, vmpstr
BUG=387116
Review URL: https://codereview.chromium.org/809433003
Cr-Commit-Position: refs/heads/master@{#308466} | d193f6bb5aa5bdc05e07f314abacf7d7bc466d3d | chrome | bigvul | 1 | null | null | null |
Add more non client Windows messages to the list of messages not being sent to the renderer.
Turns out we get WM_NCLBUTTONDOWN/UP messages at times which go to the renderer and are not acked causing the
unresponsive renderer dialog to show up in Desktop Chrome Aura.
BUG=335248
[email protected]
TBR=jam
Review URL: https://codereview.chromium.org/141103004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245949 0039d316-1c4b-4281-b951-d872f2087c98 | 8f883f2b12f68fed993671dce7fb5fb91f2229aa | chrome | bigvul | 1 | null | null | null |
Relanding this as this caused layout tests failures on Win7 due to the call to ShowScrollBars being incorrectly deleted
in the HWNDMessageHandler::OnSize for a regular WM_SIZE. Added that call back. The rest of the CL is exactly the same as
the previous one. TBR'ing sky.
Don't set the scroll styles (WS_VSCROLL and WS_HSCROLL) for WS_POPUP windows.
This causes issues with select boxes on Windows 7 where hovering at the end of the window returns the scroll WM_NCHITTEST
codes. Works fine on Windows 8. In any case we don't want the scrolling styles set on windows other than the main Chrome window
which is the only window which should be receive mousewheel messages.
I moved the scroll style setting code from the HWNDMessageHandler::OnCreate function to HWNDMessageHandler::Init function as that
would prevent the initial WM_SIZE message from hiding the scrollbar. The other change is to hide the scrollbars and readd the
scroll styles if we are sizing the window, when the sizing completes. Basically when we receive the WM_EXITSIZEMOVE message.
For normal sizing operations we continue to do this in WM_SIZE as before.
From testing on my thinkpad with Win7, desktop with Win7 and Win8 this works well
BUG=334454, 334541
TBR=sky
Review URL: https://codereview.chromium.org/133273020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245289 0039d316-1c4b-4281-b951-d872f2087c98 | 2513dd6b9abb188c1c666609aa9c24a498e1dba4 | chrome | bigvul | 1 | null | null | null |
Scheduler/child/TimeSource could be replaced with base/time/DefaultTickClock.
They both are totally same and TimeSource is removed.
BUG=494892
[email protected], [email protected]
Review URL: https://codereview.chromium.org/1163143002
Cr-Commit-Position: refs/heads/master@{#333035} | 76f36a8362a3e817cc3ec721d591f2f8878dc0c7 | chrome | bigvul | 1 | null | null | null |
Avoid drawing SVG image content when the image is of zero size.
R=pdr
BUG=330420
Review URL: https://codereview.chromium.org/109753004
git-svn-id: svn://svn.chromium.org/blink/trunk@164536 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | 70bcb6b3396a395e871e10b2ff883d92b8218e9f | chrome | bigvul | 1 | null | null | null |
Add partial magnifier to ash palette.
The partial magnifier will magnify a small portion of the screen, similar to a spyglass.
TEST=./out/Release/ash_unittests --gtest_filter=PartialMagnificationControllerTest.*
[email protected]
BUG=616112
Review-Url: https://codereview.chromium.org/2239553002
Cr-Commit-Position: refs/heads/master@{#414124} | 62b8b6e168a12263aab6b88dbef0b900cc37309f | chrome | bigvul | 1 | null | null | null |
Fix crash when resizing a view destroys the render tree
This is a simple fix for not holding a renderer across FrameView
resizes. Calling view->resize() can destroy renderers so this patch
updates SVGImage::setContainerSize to query the renderer after the
resize is complete. A similar issue does not exist for the dom tree
which is not destroyed.
BUG=344492
Review URL: https://codereview.chromium.org/178043006
git-svn-id: svn://svn.chromium.org/blink/trunk@168113 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | cace1e6998293b9b025d4bbdaf5cb5b6a1c2efb4 | chrome | bigvul | 1 | null | null | null |
One polymer_config.js to rule them all.
[email protected],[email protected],[email protected]
BUG=425626
Review URL: https://codereview.chromium.org/1224783005
Cr-Commit-Position: refs/heads/master@{#337882} | fb5dce12f0462056fc9f66967b0f7b2b7bcd88f5 | chrome | bigvul | 1 | null | null | null |
PPB_Flash.Navigate(): Disallow certain HTTP request headers.
With this CL, PPB_Flash.Navigate() fails the operation with
PP_ERROR_NOACCESS if the request headers contain non-simple headers.
BUG=332023
TEST=None
Review URL: https://codereview.chromium.org/136393004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@249114 0039d316-1c4b-4281-b951-d872f2087c98 | 59296d9276ffcc8bced092828210748d2ed19ab0 | chrome | bigvul | 1 | null | null | null |
[Android WebView] Fix a couple of typos
Fix a couple of typos in variable names/commentary introduced in:
https://codereview.chromium.org/1315633003/
No functional effect.
BUG=156062
Review URL: https://codereview.chromium.org/1331943002
Cr-Commit-Position: refs/heads/master@{#348175} | 201d2ae4d50a755f3b4ba799c00590cfa2fe3b93 | chrome | bigvul | 1 | null | null | null |
Use the host coordinate when comparing to host window bounds.
I somehow overlooked this and the test was not strict enough to catch this.
BUG=521919
TEST=Updated ScreenPositionControllerTest.ConvertHostPointToScreenHiDPI so that it fails without the patch.
Review URL: https://codereview.chromium.org/1293373002
Cr-Commit-Position: refs/heads/master@{#344186} | c21d7ac13d69cbadbbb5b2dc147be1933d52147a | chrome | bigvul | 1 | null | null | null |
Add missing null-check in OverscrollControllerAndroid::Animate()
Without it, there's a crash when running with
disable-overscroll-edge-effect switch.
BUG=501472
Review URL: https://codereview.chromium.org/1195453003
Cr-Commit-Position: refs/heads/master@{#334897} | e3de7fc7dbb642ed034afa1c1fed70a748a60f35 | chrome | bigvul | 1 | null | null | null |
Make WebContentsDelegate::OpenColorChooser return NULL on failure
Changing WebContentsDelegate::OpenColorChooser to return NULL on failure so we don't put the same ColorChooser into two scoped_ptrs(WebContentsImpl::color_chooser_)
BUG=331790
Review URL: https://codereview.chromium.org/128053002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244710 0039d316-1c4b-4281-b951-d872f2087c98 | 820957a3386e960334be3b93b48636e749d38ea3 | chrome | bigvul | 1 | null | null | null |
[SVG] Handle non-SVGAnimateElement results in calculateAnimatedValue()
Currently, SVGAnimateElement::calculateAnimatedValue() assumes that the
result element is a subtype of SVGAnimateElement, but that is not always
the case: SMILTimeContainer::updateAnimations() may pick an
SVGAnimateMotionElement for the result.
This CL is a workaround - we should take a good look at the SVG
animation type hierarchy and figure out why this is needed.
BUG=333176
[email protected]
Review URL: https://codereview.chromium.org/133893005
git-svn-id: svn://svn.chromium.org/blink/trunk@165009 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | 8876cdc1294b2a10be1724a04f864c542e2d9b6f | chrome | bigvul | 1 | null | null | null |
HPACK: Check pseudo-header order in decoder.
Treat a header block with a pseudo-header field following a regular one as
malformed, as required by HTTP/2 draft-14 Section 8.1.2.1.
This lands server change 74067938 by bnc.
BUG=400336
Review URL: https://codereview.chromium.org/531253004
Cr-Commit-Position: refs/heads/master@{#293534} | 37f06e622f3122a0f456fa8017d832f7e08b7457 | chrome | bigvul | 1 | null | null | null |
XSSAuditor takes post body from current request, not the original request.
In the face of a redirect, the information in the original body can't be
reflected in the final page, when we redirect from post to get, since the
get has no body. And for a 307-style redirect from post to post, the body
will appear in the final post.
This avoids some false positives and also the possibility of some info
leaks from the original post.
BUG=331725
[email protected]
Review URL: https://codereview.chromium.org/128823003
git-svn-id: svn://svn.chromium.org/blink/trunk@164749 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | 64bebe14963d4059d2e5fdba3c8879b83acc39d0 | chrome | bigvul | 1 | null | null | null |
De-flake and re-enable a chrome.searchEnginesPrivate api test.
By checking the list of search engines, and only asserting against the one with
the expected name, we remove the dependency on order. This should get rid of
flakiness.
BUG=481924
Review URL: https://codereview.chromium.org/1121113002
Cr-Commit-Position: refs/heads/master@{#331060} | 93c46cf417786f10d88c7153993370b1610c56b8 | chrome | bigvul | 1 | null | null | null |
Revert of Start all children in their own PID namespace. (patchset #14 id:360001 of https://codereview.chromium.org/868233011/)
Reason for revert:
Appears to cause system lockups on Chrome OS. See crbug.com/471878
Original issue's description:
> Start all children in their own PID namespace.
>
> BUG=460972
>
> Committed: https://crrev.com/4557699fbb30704f76c68b906d2656d2e322572c
> Cr-Commit-Position: refs/heads/master@{#322660}
[email protected],[email protected],[email protected]
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=460972
Review URL: https://codereview.chromium.org/1041163003
Cr-Commit-Position: refs/heads/master@{#322891} | 591f7ec686f9550fc4332b6cf7c3f0ea0544d558 | chrome | bigvul | 1 | null | null | null |
OpenSSL: don't allow the server certificate to change during renegotiation.
This mirrors r229611, but for OpenSSL.
BUG=306959
Review URL: https://codereview.chromium.org/177143004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254022 0039d316-1c4b-4281-b951-d872f2087c98 | b051cdb6465736e7233cd22b807e255554378206 | chrome | bigvul | 1 | null | null | null |
Add the SandboxedDMGParser and wire it up to the DownloadProtectionService.
BUG=496898,464083
[email protected], [email protected], [email protected], [email protected]
Review URL: https://codereview.chromium.org/1299223006 .
Cr-Commit-Position: refs/heads/master@{#344876} | 23cbfc1d685fa7389e88588584e02786820d4d26 | chrome | bigvul | 1 | null | null | null |
libyuv roll from 978 to 979. libyuv.gyp fix for ios sim which is intel not arm, fixing a link error.
BUG=none
TEST=try bot=ios_dbg_simulator
[email protected]
Review URL: https://codereview.chromium.org/152993003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@249502 0039d316-1c4b-4281-b951-d872f2087c98 | fb612ea97da6d058f017248c24efed2f0a958ad5 | chrome | bigvul | 1 | null | null | null |
Fix a crash when a form control is in a past naems map of a demoted form element.
Note that we wanted to add the protector in FormAssociatedElement::setForm(),
but we couldn't do it because it is called from the constructor.
BUG=326854
TEST=automated.
Review URL: https://codereview.chromium.org/105693013
git-svn-id: svn://svn.chromium.org/blink/trunk@163680 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | fc343fd48badc0158dc2bb763e9a8b9342f3cb6f | chrome | bigvul | 1 | null | null | null |
Added shill histogram to UMA
Added the Network.Shill.Wifi.SignalAtDisconnect histogram to UMA. This
histogram was developed previously, but was not added to UMA.
BUG=476674
Review URL: https://codereview.chromium.org/1080133002
Cr-Commit-Position: refs/heads/master@{#324969} | 05c38f692a085aeb811bc867b78393441928d8ad | chrome | bigvul | 1 | null | null | null |
Keeps the histograms in sync with the IME extension code.
BUG=367631
TEST=None
Review URL: https://codereview.chromium.org/1031573002
Cr-Commit-Position: refs/heads/master@{#321940} | 82497cf91e8f90e52d0250985f6bb99fbec65f95 | chrome | bigvul | 1 | null | null | null |
Roll buildtools from 93b32d0 -> d4dd4f79 to get a new GN build.
This picks up:
Roll the GN binaries to #318791.
Roll the GN binaries from 317120:318791 (from git 74add9fc39
to 3d7a60db).
This fixes 'gn clean' and picks up some new features for
introspections (see #317159).
[email protected]
BUG=430215
Review URL: https://codereview.chromium.org/965963002
Cr-Commit-Position: refs/heads/master@{#318952} | 162dd1a3d5b634a988884a290eaaa5d8a31c6a71 | chrome | bigvul | 1 | null | null | null |
[Extensions] Add GetInstalledExtension() method to ExtensionRegistry
This CL adds GetInstalledExtension() method to ExtensionRegistry and
uses it instead of deprecated ExtensionService::GetInstalledExtension()
in chrome/browser/ui/app_list/.
Part of removing the deprecated GetInstalledExtension() call
from the ExtensionService.
BUG=489687
Review URL: https://codereview.chromium.org/1130353010
Cr-Commit-Position: refs/heads/master@{#333036} | db93178bcaaf7e99ebb18bd51fa99b2feaf47e1f | chrome | bigvul | 1 | null | null | null |
Add InputMethodObserver support into InputMethodBase
This is a preparation CL to fix issue 164964.
Following observer callbacks are defined but not yet
supported by ui::InputMethodBase and its sub classes.
- InputMethodObserver::OnCaretBoundsChanged
- InputMethodObserver::OnInputLocaleChanged
This CL makes these callbacks functional for each
sub class of ui::InputMethodBase.
BUG=164964
TEST=ui_unittests --gtest_filter=InputMethodBaseTest.*
Review URL: https://codereview.chromium.org/48393003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@231563 0039d316-1c4b-4281-b951-d872f2087c98 | 364fb6e517fc4fbc8196a4afba4f77b3d5300c3e | chrome | bigvul | 1 | null | null | null |
Add support for horizontal mouse wheel messages in Windows Desktop Aura.
This is simply a matter of recognizing the WM_MOUSEHWHEEL message as a valid mouse wheel message.
Tested this on web pages with horizontal scrollbars and it works well.
BUG=332797
[email protected], sky
Review URL: https://codereview.chromium.org/140653006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245651 0039d316-1c4b-4281-b951-d872f2087c98 | 87c15175997b0103166020d79fe9048dcf4025f4 | chrome | bigvul | 1 | null | null | null |
Don't populate URL data in WebDropData when dragging files.
This is considered a potential security issue as well, since it leaks
filesystem paths.
BUG=332579
Review URL: https://codereview.chromium.org/135633002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244538 0039d316-1c4b-4281-b951-d872f2087c98 | 1161a49d663dd395bd639549c2dfe7324f847938 | chrome | bigvul | 1 | null | null | null |
webview: Initialize synchronous compositor after first activation.
Drawing before the first activation produces no results but can cause
cc DCHECKs to fail. To prevent this SynchronousCompositorImpl doesn't
register with it's client until the first activation.
BUG=492815
Review URL: https://codereview.chromium.org/1150423003
Cr-Commit-Position: refs/heads/master@{#332334} | 0e3d721470add955c056e3051614f58c7220e85b | chrome | bigvul | 1 | null | null | null |
[Android] Change how we write command line files for gtest APKs.
BUG=
Review URL: https://codereview.chromium.org/748143003
Cr-Commit-Position: refs/heads/master@{#305432} | 97526f65334edee6340b715d48d4f24041ffd5f7 | chrome | bigvul | 1 | null | null | null |
Moved guest_view_registry to GuestViewManager and made it an instance map
This change allows for the change towards moving GuestViewManager to components
and implementing an extensions specific GuestViewManager that installs extensions-specific
guest types.
BUG=444869
Review URL: https://codereview.chromium.org/1096623002
Cr-Commit-Position: refs/heads/master@{#325919} | 21d4d15a81b030f522fef29a0429f08a70220f68 | chrome | bigvul | 1 | null | null | null |
ozone: evdev: Add a couple more trace events
Add trace event inside each read notification for evdev.
BUG=none
TEST=chrome://tracing in link_freon
Review URL: https://codereview.chromium.org/1110693003
Cr-Commit-Position: refs/heads/master@{#327110} | c4363d1ca65494cb7b271625e1ff6541a9f593c9 | chrome | bigvul | 1 | null | null | null |
Move supports-high-dpi flag into registry.
Calls to SetProcessDpiAwareness need to happen immediately when the app starts. Specifically, before user profile settings have been initialized.
This patch moves the --supports-high-dpi into the registry.
BUG=339152, 149881, 160457
Review URL: https://codereview.chromium.org/153403003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256811 0039d316-1c4b-4281-b951-d872f2087c98 | a0fe4d88137213aa24fbb16fd7eec34533345c9b | chrome | bigvul | 1 | null | null | null |
[sql] Stats gathering for sql/ APIs.
Generate stats for how many SQL statements are executed, how many
results they return, and how many changes they make. Generate timing
values for how long is spent doing all queries, doing updating
operations, doing autocommit updates, and commiting transactions.
The goal of these metrics is to quantify results of decisions like
enabling write-ahead log or memory-mapped I/O.
BUG=489788,489444
Review URL: https://codereview.chromium.org/1145833002
Cr-Commit-Position: refs/heads/master@{#332503} | 58b8df8572e25ff91b3073213651aed4ebd675b5 | chrome | bigvul | 1 | null | null | null |
Address NewApi warning in device/battery.
This moves the Lollipop-specific code in BatteryStatusManager into a
separate method and annotates it with @TargetApi(LOLLIPOP) so appease
Android lint.
BUG=411461
Review URL: https://codereview.chromium.org/975963003
Cr-Commit-Position: refs/heads/master@{#319115} | ad10b9efa0237699081d15c931ecf26820460c16 | chrome | bigvul | 1 | null | null | null |
Do not use wrapper for link in win cross build
This is follow up of
https://chromium.googlesource.com/chromium/src/+/f7d47b7e8c03400343d4b6753ff79ade9d09ca68
This CL specifies libpath explicitly for LIB directories.
Bug: 854849, 787903
Change-Id: I9b65b0c0980af1f7eb4ece2ffbb31d8bde44e7ce
Reviewed-on: https://chromium-review.googlesource.com/1109452
Commit-Queue: Takuto Ikuta <[email protected]>
Reviewed-by: Nico Weber <[email protected]>
Cr-Commit-Position: refs/heads/master@{#569486} | 054eb9147e0a877d52410a18c948035fa6062381 | chrome | bigvul | 1 | null | null | null |
Remove unused section in build file.
Bug: 812974
Change-Id: If3b39236ddc753f8ef3f8caab4b8c2a5b12497fd
Reviewed-on: https://chromium-review.googlesource.com/988799
Commit-Queue: Fabrice de Gans-Riberi <[email protected]>
Commit-Queue: Sergey Ulanov <[email protected]>
Reviewed-by: Sergey Ulanov <[email protected]>
Reviewed-by: Tommi <[email protected]>
Cr-Commit-Position: refs/heads/master@{#548273} | 58f84d059486796cc3652797eab5eab997720cad | chrome | bigvul | 1 | null | null | null |
Slightly simplify fuzzer_test by using gn's new-ish not_needed() function.
No intended behavior change.
Bug: none
Change-Id: I1191d7dd55108a4ae9fdab19ee299bf6c6c08ec2
Reviewed-on: https://chromium-review.googlesource.com/1055749
Reviewed-by: Max Moroz <[email protected]>
Commit-Queue: Nico Weber <[email protected]>
Cr-Commit-Position: refs/heads/master@{#557981} | 3a035998dfcdcb0856f3b7b8e87b3bba0f1ab0be | chrome | bigvul | 1 | null | null | null |
Make WebPageSerializerImpl to escape URL attribute values in result.
This patch makes |WebPageSerializerImpl| to escape URL attribute values rather
than directly output URL attribute values into result.
BUG=542054
TEST=webkit_unit_tests --gtest_filter=WebPageSerializerTest.URLAttributeValues
Review URL: https://codereview.chromium.org/1398453005
Cr-Commit-Position: refs/heads/master@{#353712} | b770d85e37b2d0e248f04cf20606a2f3871ef039 | chrome | bigvul | 1 | null | null | null |
Add a fake DriveFS launcher client.
Using DriveFS requires building and deploying ChromeOS. Add a client for
the fake DriveFS launcher to allow the use of a real DriveFS from a
ChromeOS chroot to be used with a target_os="chromeos" build of chrome.
This connects to the fake DriveFS launcher using mojo over a unix domain
socket named by a command-line flag, using the launcher to create
DriveFS instances.
Bug: 848126
Change-Id: I22dcca154d41bda196dd7c1782bb503f6bcba5b1
Reviewed-on: https://chromium-review.googlesource.com/1098434
Reviewed-by: Xiyuan Xia <[email protected]>
Commit-Queue: Sam McNally <[email protected]>
Cr-Commit-Position: refs/heads/master@{#567513} | 7e995b26a5a503adefc0ad40435f7e16a45434c2 | chrome | bigvul | 1 | null | null | null |
AppCache: fix a browser crashing bug that can happen during updates.
BUG=558589
Review URL: https://codereview.chromium.org/1463463003
Cr-Commit-Position: refs/heads/master@{#360967} | e5c298b780737c53fa9aae44d6fef522931d88b0 | chrome | bigvul | 1 | null | null | null |
Fix possible map::end() dereference in AppCacheUpdateJob triggered by a compromised renderer.
BUG=551044
Review URL: https://codereview.chromium.org/1418783005
Cr-Commit-Position: refs/heads/master@{#358815} | 2cb006bc9d3ad16353ed49c2b75faea618156d0f | chrome | bigvul | 1 | null | null | null |
AppCache: Use WeakPtr<> to fix a potential uaf bug.
BUG=554908
Review URL: https://codereview.chromium.org/1441683004
Cr-Commit-Position: refs/heads/master@{#359930} | 4b5eefe562bd45c059f5dd93079450db5610788a | chrome | bigvul | 1 | null | null | null |
Change Document::detach() to RELEASE_ASSERT all subframes are gone.
BUG=556724,577105
Review URL: https://codereview.chromium.org/1667573002
Cr-Commit-Position: refs/heads/master@{#373642} | 4c8b008f055f79e622344627fed7f820375a4f01 | chrome | bigvul | 1 | null | null | null |
Fixing names of password_manager kEnableManualFallbacksFilling feature.
Fixing names of password_manager kEnableManualFallbacksFilling feature
as per the naming convention.
Bug: 785953
Change-Id: I4a4baa1649fe9f02c3783a5e4c40bc75e717cc03
Reviewed-on: https://chromium-review.googlesource.com/900566
Reviewed-by: Vaclav Brozek <[email protected]>
Commit-Queue: NIKHIL SAHNI <[email protected]>
Cr-Commit-Position: refs/heads/master@{#534923} | 33c5e0a9db05dbd2f7793c23ac23b7aa6a556c05 | chrome | bigvul | 1 | null | null | null |
Roll src/third_party/webrtc/ 8d9dcb1c8..12eb85881 (27 commits)
https://webrtc.googlesource.com/src.git/+log/8d9dcb1c8935..12eb85881c86
$ git log 8d9dcb1c8..12eb85881 --date=short --no-merges --format='%ad %ae %s'
Created with:
roll-dep src/third_party/webrtc
BUG=None,None,None
The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg
[email protected]
Change-Id: I4a9593a5506beb7a1e89cb67da61c089a69405db
Reviewed-on: https://chromium-review.googlesource.com/951891
Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#541206} | a539348351ac085469042d099ddf61e148caa770 | chrome | bigvul | 1 | null | null | null |
move_blink_source.py: Update _PATH_RULES_SPECIFIER in check-webkit-style.
It is a list of exceptional rules, and contains some Source/ paths.
Bug: 578345
Change-Id: I17e65d35c4809b9c91217db086e1af10d82dea54
Reviewed-on: https://chromium-review.googlesource.com/974605
Commit-Queue: Kent Tamura <[email protected]>
Reviewed-by: Quinten Yearsley <[email protected]>
Cr-Commit-Position: refs/heads/master@{#544991} | 2fb181b5a614066d0cac76768e823686e3b03b4c | chrome | bigvul | 1 | null | null | null |
Open Offline Pages in CCT from Downloads Home.
When the respective feature flag is enabled, offline pages opened from
the Downloads Home will use CCT instead of normal tabs.
Bug: 824807
Change-Id: I6d968b8b0c51aaeb7f26332c7ada9f927e151a65
Reviewed-on: https://chromium-review.googlesource.com/977321
Commit-Queue: Carlos Knippschild <[email protected]>
Reviewed-by: Ted Choc <[email protected]>
Reviewed-by: Bernhard Bauer <[email protected]>
Reviewed-by: Jian Li <[email protected]>
Cr-Commit-Position: refs/heads/master@{#546545} | 0b1b7baa4695c945a1b0bea1f0636f1219139e8e | chrome | bigvul | 1 | null | null | null |
Reland "[Fuchsia] Use Netstack FIDL interface to get network interfaces."
This is a reland of b29fc269716e556be6b4e999bb4b24332cc43c6e
Original change's description:
> [Fuchsia] Use Netstack FIDL interface to get network interfaces.
>
> 1. Updated FILD GN template to generate and compile tables file, FIDL
> generated code was failing to link without them.
> 2. Updated GetNetworkList() for Fuchsia to FIDL API instead of ioctl().
>
> Bug: 831384
> Change-Id: Ib90303a5110a465ea5f2bad787a7b63a2bf13f61
> Reviewed-on: https://chromium-review.googlesource.com/1023124
> Commit-Queue: Sergey Ulanov <[email protected]>
> Reviewed-by: James Robinson <[email protected]>
> Reviewed-by: Matt Menke <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#554868}
[email protected]
Bug: 831384
Change-Id: Iabb29661680b835b947b2780d169e204fd5e2559
Reviewed-on: https://chromium-review.googlesource.com/1036484
Commit-Queue: Sergey Ulanov <[email protected]>
Reviewed-by: Kevin Marshall <[email protected]>
Cr-Commit-Position: refs/heads/master@{#554946} | f7b2214a08547e0d28b1a2fef3c19ee0f9febd19 | chrome | bigvul | 1 | null | null | null |
Move SelectionTemplate::is_handle_visible_ to FrameSelection
This patch moves |is_handle_visible_| to |FrameSelection| from |SelectionTemplate|
since handle visibility is used only for setting |FrameSelection|, hence it is
a redundant member variable of |SelectionTemplate|.
Bug: 742093
Change-Id: I3add4da3844fb40be34dcb4d4b46b5fa6fed1d7e
Reviewed-on: https://chromium-review.googlesource.com/595389
Commit-Queue: Yoshifumi Inoue <[email protected]>
Reviewed-by: Xiaocheng Hu <[email protected]>
Reviewed-by: Kent Tamura <[email protected]>
Cr-Commit-Position: refs/heads/master@{#491660} | 33827275411b33371e7bb750cce20f11de85002d | chrome | bigvul | 1 | null | null | null |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.