commit_msg
stringlengths 1
24.2k
| commit_hash
stringlengths 2
84
⌀ | project
stringlengths 2
40
| source
stringclasses 4
values | labels
int64 0
1
| repo_url
stringlengths 26
70
⌀ | commit_url
stringlengths 74
118
⌀ | commit_date
stringlengths 25
25
⌀ |
|---|---|---|---|---|---|---|---|
mac: Fix a nesting bug in http://crrev.com/87141
BUG=none
TEST=none
TBR=mark
Review URL: http://codereview.chromium.org/7087016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87148 0039d316-1c4b-4281-b951-d872f2087c98 | 22362c7358df89e2c0c94c4dd43ecfe90ac3da27 | chrome | bigvul | 1 | null | null | null |
Use URLFetcher::Create instead of new in http_bridge.cc.
This change modified http_bridge so that it uses a factory to construct
the URLFetcher. Moreover, it modified sync_backend_host_unittest.cc to
use an URLFetcher factory which will prevent access to www.example.com during
the test.
BUG=none
TEST=sync_backend_host_unittest.cc
Review URL: http://codereview.chromium.org/7053011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87227 0039d316-1c4b-4281-b951-d872f2087c98 | a6e146b4a369b31afa4c4323cc813dcbe0ef0c2b | chrome | bigvul | 1 | null | null | null |
Remove minimum and maximum scroll position as they are no
longer required due to changes in ScrollViewBase.
https://bugs.webkit.org/show_bug.cgi?id=87298
Patch by Genevieve Mak <[email protected]> on 2012-05-23
Reviewed by Antonio Gomes.
* WebKitSupport/InRegionScrollableArea.cpp:
(BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea):
* WebKitSupport/InRegionScrollableArea.h:
(InRegionScrollableArea):
git-svn-id: svn://svn.chromium.org/blink/trunk@118233 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | 3057be01bcbbd1d0938afb489e18f2ca6d9b8229 | chrome | bigvul | 1 | null | null | null |
There are too many poorly named functions to create a fragment from markup
https://bugs.webkit.org/show_bug.cgi?id=87339
Reviewed by Eric Seidel.
Source/WebCore:
Moved all functions that create a fragment from markup to markup.h/cpp.
There should be no behavioral change.
* dom/Range.cpp:
(WebCore::Range::createContextualFragment):
* dom/Range.h: Removed createDocumentFragmentForElement.
* dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::setInnerHTML):
* editing/markup.cpp:
(WebCore::createFragmentFromMarkup):
(WebCore::createFragmentForInnerOuterHTML): Renamed from createFragmentFromSource.
(WebCore::createFragmentForTransformToFragment): Moved from XSLTProcessor.
(WebCore::removeElementPreservingChildren): Moved from Range.
(WebCore::createContextualFragment): Ditto.
* editing/markup.h:
* html/HTMLElement.cpp:
(WebCore::HTMLElement::setInnerHTML):
(WebCore::HTMLElement::setOuterHTML):
(WebCore::HTMLElement::insertAdjacentHTML):
* inspector/DOMPatchSupport.cpp:
(WebCore::DOMPatchSupport::patchNode): Added a FIXME since this code should be using
one of the functions listed in markup.h
* xml/XSLTProcessor.cpp:
(WebCore::XSLTProcessor::transformToFragment):
Source/WebKit/qt:
Replace calls to Range::createDocumentFragmentForElement by calls to
createContextualDocumentFragment.
* Api/qwebelement.cpp:
(QWebElement::appendInside):
(QWebElement::prependInside):
(QWebElement::prependOutside):
(QWebElement::appendOutside):
(QWebElement::encloseContentsWith):
(QWebElement::encloseWith):
git-svn-id: svn://svn.chromium.org/blink/trunk@118414 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | 73edae623529f04c668268de49d00324b96166a2 | chrome | bigvul | 1 | null | null | null |
check-webkit-style script cannot running in Chinese windows.
https://bugs.webkit.org/show_bug.cgi?id=87548
Patch by Xueqing Huang <[email protected]> on 2013-01-16
Reviewed by Darin Adler.
* Scripts/webkitpy/common/system/platforminfo.py:
(PlatformInfo._win_version_tuple_from_cmd):
git-svn-id: svn://svn.chromium.org/blink/trunk@139924 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | f31296f931b57bf0e7c15f6e60acc427b2824686 | chrome | bigvul | 1 | null | null | null |
Add support for the "uploadrequired" attribute for Autofill query responses
BUG=84693
TEST=unit_tests --gtest_filter=AutofillDownloadTest.QueryAndUploadTest
Review URL: http://codereview.chromium.org/6969090
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87729 0039d316-1c4b-4281-b951-d872f2087c98 | 80742f2ffeb9e90cd85cbee27acb9f924ffebd16 | chrome | bigvul | 1 | null | null | null |
Prevent navigation to chrome-devtools: and chrome-internal: schemas from http
BUG=87815
Review URL: http://codereview.chromium.org/7275032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91002 0039d316-1c4b-4281-b951-d872f2087c98 | ce891a86763d3540e2612be26938a6163310efe0 | chrome | bigvul | 1 | null | null | null |
2011-06-02 Joone Hur <[email protected]>
Reviewed by Martin Robinson.
[GTK] Only load dictionaries if spell check is enabled
https://bugs.webkit.org/show_bug.cgi?id=32879
We don't need to call enchant if enable-spell-checking is false.
* webkit/webkitwebview.cpp:
(webkit_web_view_update_settings): Skip loading dictionaries when enable-spell-checking is false.
(webkit_web_view_settings_notify): Ditto.
git-svn-id: svn://svn.chromium.org/blink/trunk@87925 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | 5a2de6455f565783c73e53eae2c8b953e7d48520 | chrome | bigvul | 1 | null | null | null |
2011-06-08 Alexander Pavlov <[email protected]>
Reviewed by Yury Semikhatsky.
Web Inspector: node selection is slow in the Elements panel.
https://bugs.webkit.org/show_bug.cgi?id=60813
* http/tests/inspector/inspect-iframe-from-different-domain.html:
* inspector/elements/elements-delete-inline-style.html:
* inspector/elements/elements-panel-styles.html:
* inspector/styles/styles-add-invalid-property.html:
* inspector/styles/styles-cancel-editing.html:
* inspector/styles/styles-commit-editing.html:
* inspector/styles/styles-computed-trace.html:
* inspector/styles/styles-disable-inherited.html:
* inspector/styles/styles-disable-then-change.html:
* inspector/styles/styles-disable-then-delete.html:
* inspector/styles/styles-disable-then-enable.html:
* inspector/styles/styles-iframe.html:
* inspector/styles/styles-update-from-js-expected.txt:
* inspector/styles/styles-update-from-js.html:
* inspector/styles/styles-url-linkify.html:
2011-06-08 Alexander Pavlov <[email protected]>
Reviewed by Yury Semikhatsky.
Web Inspector: node selection is slow in the Elements panel.
https://bugs.webkit.org/show_bug.cgi?id=60813
Schedule full style updates rather than request all node styles from the backend immediately.
* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylesSidebarPane.prototype.update.reloadAllStyles):
(WebInspector.StylesSidebarPane.prototype.update):
git-svn-id: svn://svn.chromium.org/blink/trunk@88337 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | f3c73feb5fa49300cada382dd9304442a5674c74 | chrome | bigvul | 1 | null | null | null |
In chromedriver, add /log url to get the contents of the chromedriver log
remotely. Also add a 'chrome.verbose' boolean startup option.
Remove usage of VLOG(1) in chromedriver. We do not need as complicated
logging as in Chrome.
BUG=85241
TEST=none
Review URL: http://codereview.chromium.org/7104085
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88591 0039d316-1c4b-4281-b951-d872f2087c98 | 4ab22cfc619ee8ff17a8c50e289ec3b30731ceba | chrome | bigvul | 1 | null | null | null |
Add OVERRIDE to ui::TreeModelObserver overridden methods.
BUG=None
TEST=None
[email protected]
Review URL: http://codereview.chromium.org/7046093
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88827 0039d316-1c4b-4281-b951-d872f2087c98 | 48f2ec5c24570c9b96bb2798a9ffe956117c5066 | chrome | bigvul | 1 | null | null | null |
Now ignores obsolete sync nodes without visit transitions.
Also removed assertion that was erroneously triggered by obsolete sync nodes.
BUG=none
TEST=run chrome against a database that contains obsolete typed url sync nodes.
Review URL: http://codereview.chromium.org/7129069
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88846 0039d316-1c4b-4281-b951-d872f2087c98 | f837b6744eb9ca9d8e4f2e93d9118bf787ca5e24 | chrome | bigvul | 1 | null | null | null |
Initial implementation of DisconnectWindow on Linux.
BUG=None
TEST=Manual
Review URL: http://codereview.chromium.org/7089016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88889 0039d316-1c4b-4281-b951-d872f2087c98 | 456405f87033ee64c6862ef814f1f6a4e52585bd | chrome | bigvul | 1 | null | null | null |
Remove use of libcros from InputMethodLibrary.
BUG=chromium-os:16238
TEST==confirm that input methods work as before on the netbook. Also confirm that the chrome builds and works on the desktop as before.
Review URL: http://codereview.chromium.org/7003086
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89142 0039d316-1c4b-4281-b951-d872f2087c98 | dc7b094a338c6c521f918f478e993f0f74bbea0d | chrome | bigvul | 1 | null | null | null |
Disable pyauto tests causing browser crash in Debug builds
BUG=86456
[email protected]
TEST=
Review URL: http://codereview.chromium.org/7185029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89520 0039d316-1c4b-4281-b951-d872f2087c98 | 3652e6bc1b90a1dddc22e491c2c0221b2d6f5bd0 | chrome | bigvul | 1 | null | null | null |
2011-06-30 Mikhail Naganov <[email protected]>
Reviewed by Yury Semikhatsky.
Web Inspector: [Chromium] Fix heap snapshots in a remote debugging session from Safari.
https://bugs.webkit.org/show_bug.cgi?id=63703
* inspector/front-end/HeapSnapshotWorker.js:
(.Function.prototype.bind.return.bound):
(.Function.prototype.bind):
git-svn-id: svn://svn.chromium.org/blink/trunk@90222 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | b0ce1496c71721bebd69de4b1a842c5977708d12 | chrome | bigvul | 1 | null | null | null |
Fix invalid read in ppapi code
BUG=77493
TEST=attached test
Review URL: http://codereview.chromium.org/6883059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82172 0039d316-1c4b-4281-b951-d872f2087c98 | bf04ad0dae9f4f479f90fd2b38f634ffbaf434b4 | chrome | bigvul | 1 | null | null | null |
wstring: remove wstring version of SplitString
Retry of r84336.
BUG=23581
Review URL: http://codereview.chromium.org/6930047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84355 0039d316-1c4b-4281-b951-d872f2087c98 | dabd6f450e9594a8962ef6f79447a8bfdc1c9f05 | chrome | bigvul | 1 | null | null | null |
iwyu: Include callback_old.h where appropriate, final.
BUG=82098
TEST=none
Review URL: http://codereview.chromium.org/7003003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85003 0039d316-1c4b-4281-b951-d872f2087c98 | 60cc89e8d2e761dea28bb9e4cf9ebbad516bff09 | chrome | bigvul | 1 | null | null | null |
[JSC] Implement a helper method createNotEnoughArgumentsError()
https://bugs.webkit.org/show_bug.cgi?id=85102
Reviewed by Geoffrey Garen.
In bug 84787, kbr@ requested to avoid hard-coding
createTypeError(exec, "Not enough arguments") here and there.
This patch implements createNotEnoughArgumentsError(exec)
and uses it in JSC bindings.
c.f. a corresponding bug for V8 bindings is bug 85097.
Source/JavaScriptCore:
* runtime/Error.cpp:
(JSC::createNotEnoughArgumentsError):
(JSC):
* runtime/Error.h:
(JSC):
Source/WebCore:
Test: bindings/scripts/test/TestObj.idl
* bindings/scripts/CodeGeneratorJS.pm: Modified as described above.
(GenerateArgumentsCountCheck):
* bindings/js/JSDataViewCustom.cpp: Ditto.
(WebCore::getDataViewMember):
(WebCore::setDataViewMember):
* bindings/js/JSDeprecatedPeerConnectionCustom.cpp:
(WebCore::JSDeprecatedPeerConnectionConstructor::constructJSDeprecatedPeerConnection):
* bindings/js/JSDirectoryEntryCustom.cpp:
(WebCore::JSDirectoryEntry::getFile):
(WebCore::JSDirectoryEntry::getDirectory):
* bindings/js/JSSharedWorkerCustom.cpp:
(WebCore::JSSharedWorkerConstructor::constructJSSharedWorker):
* bindings/js/JSWebKitMutationObserverCustom.cpp:
(WebCore::JSWebKitMutationObserverConstructor::constructJSWebKitMutationObserver):
(WebCore::JSWebKitMutationObserver::observe):
* bindings/js/JSWorkerCustom.cpp:
(WebCore::JSWorkerConstructor::constructJSWorker):
* bindings/scripts/test/JS/JSFloat64Array.cpp: Updated run-bindings-tests.
(WebCore::jsFloat64ArrayPrototypeFunctionFoo):
* bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:
(WebCore::jsTestActiveDOMObjectPrototypeFunctionExcitingFunction):
(WebCore::jsTestActiveDOMObjectPrototypeFunctionPostMessage):
* bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp:
(WebCore::jsTestCustomNamedGetterPrototypeFunctionAnotherFunction):
* bindings/scripts/test/JS/JSTestEventTarget.cpp:
(WebCore::jsTestEventTargetPrototypeFunctionItem):
(WebCore::jsTestEventTargetPrototypeFunctionAddEventListener):
(WebCore::jsTestEventTargetPrototypeFunctionRemoveEventListener):
(WebCore::jsTestEventTargetPrototypeFunctionDispatchEvent):
* bindings/scripts/test/JS/JSTestInterface.cpp:
(WebCore::JSTestInterfaceConstructor::constructJSTestInterface):
(WebCore::jsTestInterfacePrototypeFunctionSupplementalMethod2):
* bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
(WebCore::jsTestMediaQueryListListenerPrototypeFunctionMethod):
* bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
(WebCore::JSTestNamedConstructorNamedConstructor::constructJSTestNamedConstructor):
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::JSTestObjConstructor::constructJSTestObj):
(WebCore::jsTestObjPrototypeFunctionVoidMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionIntMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionObjMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionMethodWithSequenceArg):
(WebCore::jsTestObjPrototypeFunctionMethodReturningSequence):
(WebCore::jsTestObjPrototypeFunctionMethodThatRequiresAllArgsAndThrows):
(WebCore::jsTestObjPrototypeFunctionSerializedValue):
(WebCore::jsTestObjPrototypeFunctionIdbKey):
(WebCore::jsTestObjPrototypeFunctionOptionsObject):
(WebCore::jsTestObjPrototypeFunctionAddEventListener):
(WebCore::jsTestObjPrototypeFunctionRemoveEventListener):
(WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndOptionalArg):
(WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndTwoOptionalArgs):
(WebCore::jsTestObjPrototypeFunctionMethodWithCallbackArg):
(WebCore::jsTestObjPrototypeFunctionMethodWithNonCallbackArgAndCallbackArg):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod1):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod2):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod3):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod4):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod5):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod6):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod7):
(WebCore::jsTestObjConstructorFunctionClassMethod2):
(WebCore::jsTestObjConstructorFunctionOverloadedMethod11):
(WebCore::jsTestObjConstructorFunctionOverloadedMethod12):
(WebCore::jsTestObjPrototypeFunctionMethodWithUnsignedLongArray):
(WebCore::jsTestObjPrototypeFunctionConvert1):
(WebCore::jsTestObjPrototypeFunctionConvert2):
(WebCore::jsTestObjPrototypeFunctionConvert3):
(WebCore::jsTestObjPrototypeFunctionConvert4):
(WebCore::jsTestObjPrototypeFunctionConvert5):
(WebCore::jsTestObjPrototypeFunctionStrictFunction):
* bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
(WebCore::JSTestSerializedScriptValueInterfaceConstructor::constructJSTestSerializedScriptValueInterface):
(WebCore::jsTestSerializedScriptValueInterfacePrototypeFunctionAcceptTransferList):
git-svn-id: svn://svn.chromium.org/blink/trunk@115536 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | b944f670bb7a8a919daac497a4ea0536c954c201 | chrome | bigvul | 1 | null | null | null |
2011-04-28 Gabor Rapcsanyi <[email protected]>
Reviewed by Csaba Osztrogonác.
[Qt] Add ARM specific Skipped list
https://bugs.webkit.org/show_bug.cgi?id=59680
* platform/qt-arm/Skipped: Added.
2011-04-28 Gabor Rapcsanyi <[email protected]>
Reviewed by Csaba Osztrogonác.
[Qt] Add ARM specific Skipped list
https://bugs.webkit.org/show_bug.cgi?id=59680
* Scripts/old-run-webkit-tests:
* Scripts/webkitdirs.pm:
git-svn-id: svn://svn.chromium.org/blink/trunk@85177 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | 0b64fff8da9b0681180a123fcd5cb41ff0c7008e | chrome | bigvul | 1 | null | null | null |
Enable HistoryModelWorker by default, now that bug 69561 is fixed.
BUG=69561
TEST=Run sync manually and run integration tests, sync should not crash.
Review URL: http://codereview.chromium.org/7016007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85211 0039d316-1c4b-4281-b951-d872f2087c98 | bf381d8a02c3d272d4dd879ac719d8993dfb5ad6 | chrome | bigvul | 1 | null | null | null |
cros: The next 100 clang plugin errors.
BUG=none
TEST=none
TBR=dpolukhin
Review URL: http://codereview.chromium.org/7022008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85418 0039d316-1c4b-4281-b951-d872f2087c98 | e755d9faf5c7d75a8ea290892cb1b5cc07c412ec | chrome | bigvul | 1 | null | null | null |
PPAPI: Add context menu events.
BUG=50984
TEST=none
Review URL: http://codereview.chromium.org/6257011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72189 0039d316-1c4b-4281-b951-d872f2087c98 | db5523bcb7e0419955172709c241a188ab94e8e0 | chrome | bigvul | 1 | null | null | null |
compositing/tiling/crash-reparent-tiled-layer.html is flakey
https://bugs.webkit.org/show_bug.cgi?id=82546
Mark this test as flakey in test_expectations
* platform/mac/test_expectations.txt:
git-svn-id: svn://svn.chromium.org/blink/trunk@112468 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | c3e51cacd84fd72933d1b0cfa65ca63a6103be26 | chrome | bigvul | 1 | null | null | null |
Move UILayoutTest.MediaUILayoutTest valgrind suppression into shared suppressions file.
BUG=53825
TEST=should still be suppressed
TBR=timurrrr
Review URL: http://codereview.chromium.org/6897047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82873 0039d316-1c4b-4281-b951-d872f2087c98 | 0155d5910b6c03b7943503296cc63dc35a2dfea0 | chrome | bigvul | 1 | null | null | null |
Make NotifyHeadersComplete the last call in the function.
BUG=82903
Review URL: http://codereview.chromium.org/7038017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85719 0039d316-1c4b-4281-b951-d872f2087c98 | 957973753ec4159003ff7930d946b7e89c7e09f3 | chrome | bigvul | 1 | null | null | null |
WebKit2: Support window bounce when panning.
https://bugs.webkit.org/show_bug.cgi?id=58065
<rdar://problem/9244367>
Reviewed by Adam Roben.
Make gestureDidScroll synchronous, as once we scroll, we need to know
whether or not we are at the beginning or end of the scrollable document.
If we are at either end of the scrollable document, we call the Windows 7
API to bounce the window to give an indication that you are past an end
of the document.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::gestureDidScroll): Pass a boolean for the reply, and return it.
* UIProcess/WebPageProxy.h:
* UIProcess/win/WebView.cpp:
(WebKit::WebView::WebView): Inititalize a new variable.
(WebKit::WebView::onGesture): Once we send the message to scroll, check if have gone to
an end of the document, and if we have, bounce the window.
* UIProcess/win/WebView.h:
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/WebPage.messages.in: GestureDidScroll is now sync.
* WebProcess/WebPage/win/WebPageWin.cpp:
(WebKit::WebPage::gestureDidScroll): When we are done scrolling, check if we have a vertical
scrollbar and if we are at the beginning or the end of the scrollable document.
git-svn-id: svn://svn.chromium.org/blink/trunk@83197 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | df831400bcb63db4259b5858281b1727ba972a2a | chrome | bigvul | 1 | null | null | null |
Add comments explaining the IPv6 fallback logic in TransportConnectJob.
BUG=81686
TEST=none.
Review URL: http://codereview.chromium.org/7015056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85375 0039d316-1c4b-4281-b951-d872f2087c98 | 1332c24d517e472758aae7e25301752561da6bc5 | chrome | bigvul | 1 | null | null | null |
Copy setup.exe rather than moving it since it is created outside of the target directory heirarchy (regression introduced in r75899).
BUG=82424
TEST=Install system-level Chrome as some admin user X. Switch to admin user Y and try to uninstall.
[email protected]
Review URL: http://codereview.chromium.org/7011018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85159 0039d316-1c4b-4281-b951-d872f2087c98 | 45bae236b03f577ed6682ef4c7ef3ee006de5e5a | chrome | bigvul | 1 | null | null | null |
Source/WebCore: Fix for bug 64046 - Wrong image height in absolutely positioned div in
relatively positioned parent with bottom padding.
https://bugs.webkit.org/show_bug.cgi?id=64046
Patch by Kulanthaivel Palanichamy <[email protected]> on 2011-07-21
Reviewed by David Hyatt.
Test: fast/css/absolute-child-with-percent-height-inside-relative-parent.html
* rendering/RenderBox.cpp:
(WebCore::RenderBox::availableLogicalHeightUsing):
LayoutTests: Test to cover absolutely positioned child with percentage height
in relatively positioned parent with bottom padding.
https://bugs.webkit.org/show_bug.cgi?id=64046
Patch by Kulanthaivel Palanichamy <[email protected]> on 2011-07-21
Reviewed by David Hyatt.
* fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.txt: Added.
* fast/css/absolute-child-with-percent-height-inside-relative-parent.html: Added.
git-svn-id: svn://svn.chromium.org/blink/trunk@91533 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | 5fd35e5359c6345b8709695cd71fba307318e6aa | chrome | bigvul | 1 | null | null | null |
[Qt][WK2] Allow transparent WebViews
https://bugs.webkit.org/show_bug.cgi?id=80608
Reviewed by Tor Arne Vestbø.
Added support for transparentBackground in QQuickWebViewExperimental.
This uses the existing drawsTransparentBackground property in WebKit2.
Also, changed LayerTreeHostQt to set the contentsOpaque flag when the root layer changes,
otherwise the change doesn't take effect.
A new API test was added.
* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::setTransparentBackground):
(QQuickWebViewPrivate::transparentBackground):
(QQuickWebViewExperimental::transparentBackground):
(QQuickWebViewExperimental::setTransparentBackground):
* UIProcess/API/qt/qquickwebview_p.h:
* UIProcess/API/qt/qquickwebview_p_p.h:
(QQuickWebViewPrivate):
* UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp:
(tst_QQuickWebView):
(tst_QQuickWebView::transparentWebViews):
* WebProcess/WebPage/qt/LayerTreeHostQt.cpp:
(WebKit::LayerTreeHostQt::LayerTreeHostQt):
(WebKit::LayerTreeHostQt::setRootCompositingLayer):
git-svn-id: svn://svn.chromium.org/blink/trunk@110254 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | 1777aa6484af15014b8691082a8c3075418786f5 | chrome | bigvul | 1 | null | null | null |
chromeos: Replace copy-and-pasted code with macros.
This replaces a bunch of duplicated-per-library cros
function definitions and comments.
BUG=none
TEST=built it
Review URL: http://codereview.chromium.org/6086007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70070 0039d316-1c4b-4281-b951-d872f2087c98 | b3ae5db129f88dae153880e84bdabea8ce2ca89b | chrome | bigvul | 1 | null | null | null |
Fix null-termination on string copy in debug-on-start code.
BUG=73740
Review URL: http://codereview.chromium.org/6549019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75629 0039d316-1c4b-4281-b951-d872f2087c98 | 514f93279494ec4448b34a7aeeff27eccaae983f | chrome | bigvul | 1 | null | null | null |
Make ToUpper and ToLower properly handle embedded NULLs in the input.
BUG=72517
TEST=included unit test
Review URL: http://codereview.chromium.org/6625046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77502 0039d316-1c4b-4281-b951-d872f2087c98 | 0934e35f418895925345d059490e27d643db1133 | chrome | bigvul | 1 | null | null | null |
Add support for autofill server experiments
BUG=none
TEST=unit_tests --gtest_filter=AutoFillMetricsTest.QualityMetricsWithExperimentId:AutoFillQueryXmlParserTest.ParseExperimentId
Review URL: http://codereview.chromium.org/6260027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73216 0039d316-1c4b-4281-b951-d872f2087c98 | 5f372f899b8709dac700710b5f0f90959dcf9ecb | chrome | bigvul | 1 | null | null | null |
Add more remoting team members to watch list. Update with +watch for easier filtering.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6308022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73595 0039d316-1c4b-4281-b951-d872f2087c98 | e06acea54d8b11e4b3735099aa3ce98bae676e76 | chrome | bigvul | 1 | null | null | null |
2010-12-23 Alexander Pavlov <[email protected]>
Reviewed by Joseph Pecoraro.
Web Inspector: Can't backspace from CSS value to CSS key field
https://bugs.webkit.org/show_bug.cgi?id=51476
* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylePropertyTreeElement.prototype.):
(WebInspector.StylePropertyTreeElement.prototype):
git-svn-id: svn://svn.chromium.org/blink/trunk@74562 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | c13183661f98b29764e3db2fd3a2741dc1f1d086 | chrome | bigvul | 1 | null | null | null |
Suppressing UninitCondition in power library
[email protected]
BUG=73048
TEST=none
Review URL: http://codereview.chromium.org/6480082
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74991 0039d316-1c4b-4281-b951-d872f2087c98 | ea762e1469b44f01163a349914731a7d4e9c46a4 | chrome | bigvul | 1 | null | null | null |
Rename the TabContentWrapper pieces to be "TabHelper"s. (Except for the PasswordManager... for now.) Also, just pre-create them up-front. It saves us effort, as they're all going to be eventually created anyway, so being lazy saves us nothing and creates headaches since the rules about what can be lazy differ from feature to feature.
BUG=71097
TEST=zero visible change
Review URL: http://codereview.chromium.org/6480117
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75170 0039d316-1c4b-4281-b951-d872f2087c98 | c90c6ca59378d7e86d1a2f28fe96bada35df1508 | chrome | bigvul | 1 | null | null | null |
Some Scrollbar functions assume an attached ScrollableArea but can be called without one
https://bugs.webkit.org/show_bug.cgi?id=54262
Reviewed by Dan Bernstein.
Make sure that all calls to the scrollable area are null checked.
* platform/Scrollbar.cpp:
(WebCore::Scrollbar::autoscrollPressedPart):
(WebCore::Scrollbar::moveThumb):
(WebCore::Scrollbar::mouseMoved):
git-svn-id: svn://svn.chromium.org/blink/trunk@78431 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | 294474c162b13937a6474955c6594b3657379c1e | chrome | bigvul | 1 | null | null | null |
2011-07-01 Oliver Hunt <[email protected]>
IE Web Workers demo crashes in JSC::SlotVisitor::visitChildren()
https://bugs.webkit.org/show_bug.cgi?id=63732
Reviewed by Gavin Barraclough.
Initialise the memory at the head of the new storage so that
GC is safe if triggered by reportExtraMemoryCost.
* runtime/JSArray.cpp:
(JSC::JSArray::increaseVectorPrefixLength):
git-svn-id: svn://svn.chromium.org/blink/trunk@90282 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | 0c4225d1e9b23e7071bbf47ada310a9a7e5661a3 | chrome | bigvul | 1 | null | null | null |
Add pyauto tests for Web SQL databases.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/5364002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68263 0039d316-1c4b-4281-b951-d872f2087c98 | be25bc545483881097ba9ba1eadafbcfdaf1f6e7 | chrome | bigvul | 1 | null | null | null |
2010-09-29 Kinuko Yasuda <[email protected]>
Reviewed by Dumitru Daniliuc.
Add removeRecursively to WebKit WebFileSystem API
https://bugs.webkit.org/show_bug.cgi?id=46842
* public/WebFileSystem.h:
(WebKit::WebFileSystem::removeRecursively): Added.
git-svn-id: svn://svn.chromium.org/blink/trunk@68741 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | 5953897b543c68c03343ce490cce1e3e5cff17da | chrome | bigvul | 1 | null | null | null |
[EFL] Change the behavior of ewk_view_scale_set.
https://bugs.webkit.org/show_bug.cgi?id=70078
Reviewed by Eric Seidel.
Remove center point basis zoom alignment from ewk_view_scale_set to call
Page::setPageScaleFactor without any adjustment.
* ewk/ewk_view.cpp:
(ewk_view_scale_set):
* ewk/ewk_view.h:
git-svn-id: svn://svn.chromium.org/blink/trunk@103288 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | ec14f31eca3a51f665432973552ee575635132b3 | chrome | bigvul | 1 | null | null | null |
[gtk] un-break status bubble.
broken in r71858.
BUG=70244
TEST=manual (in and out of --kiosk)
Review URL: http://codereview.chromium.org/6343003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71988 0039d316-1c4b-4281-b951-d872f2087c98 | 20106b615c3d11637864fcd4dd4de3356c858f2c | chrome | bigvul | 1 | null | null | null |
Check that we've got a complete header before accessing its fields.
This patch was prepared by Evgeniy Stepanov ([email protected]) and reviewed
at http://codereview.chromium.org/6353010/
BUG=70376
TEST=none
TBR=darin,willchan
Review URL: http://codereview.chromium.org/6347013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72634 0039d316-1c4b-4281-b951-d872f2087c98 | 137d237f941001695681ed5628a20dec84cd3b86 | chrome | bigvul | 1 | null | null | null |
Web Inspector: do not map scripts generated with document.write to the document resources.
https://bugs.webkit.org/show_bug.cgi?id=71114
Reviewed by Yury Semikhatsky.
* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel):
(WebInspector.DebuggerPresentationModel.prototype._addScript):
(WebInspector.DebuggerPresentationModel.prototype._bindScriptToRawSourceCode):
(WebInspector.DebuggerPresentationModel.prototype.uiSourceCodes):
(WebInspector.DebuggerPresentationModel.prototype.setFormatSource):
(WebInspector.DebuggerPresentationModel.prototype._consoleCleared):
(WebInspector.DebuggerPresentationModel.prototype._rawSourceCodeForScriptWithURL):
(WebInspector.DebuggerPresentationModel.prototype._rawSourceCodeForScript):
(WebInspector.DebuggerPresentationModel.prototype._scriptForRawSourceCode):
(WebInspector.DebuggerPresentationModel.prototype._debuggerReset):
(WebInspector.DebuggerPresentationModel.Linkifier.prototype.reset):
* inspector/front-end/RawSourceCode.js:
(WebInspector.RawSourceCode.prototype._createSourceMapping.didRequestContent.didFormatContent):
(WebInspector.RawSourceCode.prototype._createSourceMapping.didRequestContent):
(WebInspector.RawSourceCode.prototype._createSourceMapping):
* inspector/front-end/Script.js:
(WebInspector.Script.prototype.editSource):
(WebInspector.Script.prototype.isInlineScript):
git-svn-id: svn://svn.chromium.org/blink/trunk@99203 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | d32b6f38dc0c71dfbb3da9292594b7c6f6d4283e | chrome | bigvul | 1 | null | null | null |
Add ALSA support to volume keys
If PulseAudio is running, everything should behave as before, otherwise use ALSA API for adjusting volume. The previous PulseAudioMixer was split into AudioMixerBase and audioMixerPusle, then AudioMixerAlsa was added.
BUG=chromium-os:10470
TEST=Volume keys should work even if pulseaudio disabled
Review URL: http://codereview.chromium.org/5859003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71115 0039d316-1c4b-4281-b951-d872f2087c98 | 51dfe5e3b332bcea02fb4d4c7493ae841106dd9b | chrome | bigvul | 1 | null | null | null |
Revert "OnionSoup: Move mojom files from public/platform/web to public/mojom folder"
This reverts commit e656908dbda6ced2f4743a9b5c2ed926dc6b5b67.
Reason for revert: Appears to cause build failure on Android
[71296/78273] ACTION //content/public/android:content_java__process_prebuilt__bytecode_rewrite(//build/toolchain/android:android_clang_arm)
FAILED: obj/content/public/android/content_java__process_prebuilt-bytecode-rewritten.jar
python ../../build/android/gyp/bytecode_processor.py --script bin/helper/java_bytecode_rewriter [...removed for brevity, see link...]
Missing 2 classes missing in direct classpath. To fix, add GN deps for:
gen/third_party/blink/public/mojom/android_mojo_bindings_java.javac.jar
Traceback (most recent call last):
File "../../build/android/gyp/bytecode_processor.py", line 76, in <module>
sys.exit(main(sys.argv))
File "../../build/android/gyp/bytecode_processor.py", line 72, in main
subprocess.check_call(cmd)
File "/b/swarming/w/ir/cipd_bin_packages/lib/python2.7/subprocess.py", line 186, in check_call
raise CalledProcessError(retcode, cmd)
(https://ci.chromium.org/p/chromium/builders/ci/android-rel/9664)
Original change's description:
> OnionSoup: Move mojom files from public/platform/web to public/mojom folder
>
> This CL moves window_features.mojom, commit_result.mojom,
> devtools_frontend.mojom, selection_menu_behavior.mojom and
> remote_objects.mojom from public/platform/web to public/mojom/
> to gather mojom files to mojom folder and updates paths for these
> mojom files.
>
> Bug: 919393
> Change-Id: If6df031ed39d70e700986bd13a40d0598257e009
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1514434
> Reviewed-by: Scott Violet <[email protected]>
> Reviewed-by: Kentaro Hara <[email protected]>
> Reviewed-by: Kinuko Yasuda <[email protected]>
> Reviewed-by: Dmitry Gozman <[email protected]>
> Commit-Queue: Julie Jeongeun Kim <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#640633}
[email protected],[email protected],[email protected],[email protected],[email protected]
Change-Id: I5744072dbaeffba5706f329838e37d74c065ae27
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 919393
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1523386
Reviewed-by: Fredrik Söderquist <[email protected]>
Commit-Queue: Fredrik Söderquist <[email protected]>
Cr-Commit-Position: refs/heads/master@{#640688} | f84286649c35f951996885aebd0400ea0c3c44cb | chrome | bigvul | 1 | null | null | null |
Use dumpAsText() to avoid an image result being generated
https://bugs.webkit.org/show_bug.cgi?id=71386
Reviewed by Tony Chang.
single-line-must-not-be-split-into-two-pages.html had been producing
a huge image result. What we need is a way by which we can generate a
DumpRenderTree result but do not generate an image even if
--pixel-test option is specified for ./Tools/Scripts/new-run-webkit-tests.
This patch realizes it using dumpAsText() and
window.internals.elementRenderTreeAsText.
* printing/single-line-must-not-be-split-into-two-pages.html: Used dumpAsText() and window.internals.elementRenderTreeAsText.
* platform/chromium-cg-mac-leopard/printing/single-line-must-not-be-split-into-two-pages-expected.png: Removed.
* platform/chromium-cg-mac-snowleopard/printing/single-line-must-not-be-split-into-two-pages-expected.png: Removed.
* platform/chromium-linux/printing/single-line-must-not-be-split-into-two-pages-expected.png: Removed.
* platform/chromium-mac-leopard/printing/single-line-must-not-be-split-into-two-pages-expected.png: Removed.
* platform/chromium-mac-snowleopard/printing/single-line-must-not-be-split-into-two-pages-expected.png: Removed.
* platform/chromium-win/printing/single-line-must-not-be-split-into-two-pages-expected.png: Removed.
* platform/chromium-win/printing/single-line-must-not-be-split-into-two-pages-expected.txt: Updated a test result.
* platform/mac/printing/single-line-must-not-be-split-into-two-pages-expected.txt: Ditto.
git-svn-id: svn://svn.chromium.org/blink/trunk@99772 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | df18d7ad53954822a3b04ca517b7dc14c2f36185 | chrome | bigvul | 1 | null | null | null |
Attempt 2 at fixing crash in ProcessPendingTabs. This differs from the
one you reviewed in that I changed a DCHECK in ProcessPendingTabs to
an if. See the comments there for details (this was triggering a
failure on chromeos).
Description from last attempt:
With the current code, during closing a window with unload handlers if
a tab is disconnected then we delay cleanup by way of PostTask with
the tab being disconnected. During the time between when the
disconnect happens and the task is run the unloader handler sets still
maintain a reference to the tab. If ProcessPendingTabs is invoked
during this window and the tab is deleted, then we can crash.
I'm fixing it by making disconnect remove from the sets immediately,
but delay the call to ProcessPendingTabs. I'm also doing a similar
thing in TabDetachedAt.
BUG=15620
TEST=none
Review URL: http://codereview.chromium.org/6321001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71388 0039d316-1c4b-4281-b951-d872f2087c98 | 08f0d612f2a4039aaf6733d4e8d0a67614941378 | chrome | bigvul | 1 | null | null | null |
[cros] Update OOBE network error message.
BUG=chromium-os:8172
TEST=N/A
Review URL: http://codereview.chromium.org/6303008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71595 0039d316-1c4b-4281-b951-d872f2087c98 | 648cbc15a6830523b3a4eb78d674f059bd2a7ce9 | chrome | bigvul | 1 | null | null | null |
Changes some of the dependencies to remove
client side arrays.
TEST=none
BUG=71717
Review URL: http://codereview.chromium.org/6459013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74392 0039d316-1c4b-4281-b951-d872f2087c98 | a6ea5f60fe65e9da5bd52cb283fd5177c277fff8 | chrome | bigvul | 1 | null | null | null |
[Sync] Tidy up SyncBackendHost interface.
Converted passphrase-related notifications to SyncFrontend methods.
Removed some unneeded parameters from SyncBackendHost constructor.
Moved some function definitions into .cc files.
BUG=None
TEST=unit_tests
Review URL: http://codereview.chromium.org/6380004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71855 0039d316-1c4b-4281-b951-d872f2087c98 | 1a78769eeed2048aa9bb873a197838cc716092be | chrome | bigvul | 1 | null | null | null |
Clean up windows printing workflow.
BUG=none
TEST=printing works after code change.
Review URL: http://codereview.chromium.org/6374004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71960 0039d316-1c4b-4281-b951-d872f2087c98 | af05a799e3f47331fb27a24a8a56f1b1dd47a9c2 | chrome | bigvul | 1 | null | null | null |
[WX] Make FontPlatformData::m_size private
https://bugs.webkit.org/show_bug.cgi?id=72214
Reviewed by Andreas Kling.
Also change the order of member variables to match
the order in the constructor to fix many warnings.
* platform/graphics/wx/FontPlatformData.h:
git-svn-id: svn://svn.chromium.org/blink/trunk@100106 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | 3bbb5be65d8acee1cdd92f3ff214575b1dbaf266 | chrome | bigvul | 1 | null | null | null |
Restore old title in WebViewPlugin only when loading the plugin.
BUG=72437
TEST=see bug for manual test
Review URL: http://codereview.chromium.org/6476006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74428 0039d316-1c4b-4281-b951-d872f2087c98 | 0c5e07b0a63a5aea8ab0c2b50177b4c99e7c9538 | chrome | bigvul | 1 | null | null | null |
Split infobars.{cc,h} into separate pieces for the different classes defined within, so that each piece is shorter and clearer.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6250057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73235 0039d316-1c4b-4281-b951-d872f2087c98 | fc3c351a3d995f73ead5c92354396a7ec2b14e3f | chrome | bigvul | 1 | null | null | null |
REGRESSION(r93902): Can't open external links on gmail
https://bugs.webkit.org/show_bug.cgi?id=67234
<rdar://problem/10053636>
Reviewed by Alexey Proskuryakov.
* Shared/cf/ArgumentCodersCF.cpp:
(CoreIPC::decode):
If we encounter an empty URL string, create an empty url by using NSURL, just
like we do in WebCore when converting an empty KURL to an NSURL.
* WebKit2.xcodeproj/project.pbxproj:
Compile ArgumentCodersCF.cpp as Objective-C++ for now.
git-svn-id: svn://svn.chromium.org/blink/trunk@94246 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | 3c1864079c441ea2e08f882acaaf441f78a6de3d | chrome | bigvul | 1 | null | null | null |
2010-09-22 Adam Barth <[email protected]>
Reviewed by John Sullivan.
New review-page design doesn't include name of reviewer
https://bugs.webkit.org/show_bug.cgi?id=46271
* PrettyPatch/PrettyPatch.rb:
* code-review.js:
git-svn-id: svn://svn.chromium.org/blink/trunk@68120 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | 374fdf67605fd08453122b6e2ff3c08cc4611cf5 | chrome | bigvul | 1 | null | null | null |
Don't offer to translate the devtools.
BUG=63265
TEST=as in bug
Review URL: http://codereview.chromium.org/6011001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69556 0039d316-1c4b-4281-b951-d872f2087c98 | de5aa214ea77b3d2c4ff8a0c58f446896c107ce0 | chrome | bigvul | 1 | null | null | null |
Skip accessibility/menu-list-sends-change-notification.html on Mac.
https://bugs.webkit.org/show_bug.cgi?id=69970
Reviewed by Simon Fraser.
* platform/mac/Skipped:
git-svn-id: svn://svn.chromium.org/blink/trunk@97315 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | 8f8e4b146e8ddd199d71d3d569bc7a9294f0dfd3 | chrome | bigvul | 1 | null | null | null |
https://bugs.webkit.org/show_bug.cgi?id=48246
Reviewed by Sam Weinig.
Make selectionRect() on InlineTextBox give the right value for a vertical line. Selection is still too broken
to test anything though.
* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::selectionRect):
git-svn-id: svn://svn.chromium.org/blink/trunk@70456 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | 2c3d133e93d0455eb64bd96384f317674db79ab5 | chrome | bigvul | 1 | null | null | null |
2010-07-26 Victor Wang <[email protected]>
Unreviewed. Update chromium test expectations fro flaky test.
https://bugs.webkit.org/show_bug.cgi?id=42989
* platform/chromium/test_expectations.txt:
git-svn-id: svn://svn.chromium.org/blink/trunk@64061 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | 2df12ec2213935a82f52b9e9af70023fa8c05635 | chrome | bigvul | 1 | null | null | null |
Fix glGetFramebufferAttachmentParameteriv so it returns
current names for buffers.
TEST=unit_tests and conformance tests
BUG=none
Review URL: http://codereview.chromium.org/3135003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55831 0039d316-1c4b-4281-b951-d872f2087c98 | 74c1ec481b33194dc7a428f2d58fc89640b313ae | chrome | bigvul | 1 | null | null | null |
DevTools: enable two sanity tests (fixed upstream)
BUG=53406
Review URL: http://codereview.chromium.org/3305023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59081 0039d316-1c4b-4281-b951-d872f2087c98 | 7f9cb4b09dee69d7ea5391650b6f68a39e3c5874 | chrome | bigvul | 1 | null | null | null |
SandboxedExtensionUnpacker::ValidateSignature should check for an empty signature
Without an expicit check we crash on a hard int3 when trying to allocate 0 bytes.
BUG=62791
TEST=None.
Review URL: http://codereview.chromium.org/4723007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65821 0039d316-1c4b-4281-b951-d872f2087c98 | ffeada1f2de5281d59ea48c94c4001a568092cd3 | chrome | bigvul | 1 | null | null | null |
2010-07-26 Tony Gentilcore <[email protected]>
Reviewed by Darin Fisher.
Move DocumentLoadTiming struct to a new file
https://bugs.webkit.org/show_bug.cgi?id=42917
Also makes DocumentLoadTiming Noncopyable.
No new tests because no new functionality.
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* loader/DocumentLoadTiming.h: Added.
(WebCore::DocumentLoadTiming::DocumentLoadTiming):
* loader/DocumentLoader.h:
* loader/FrameLoader.cpp:
* loader/FrameLoaderTypes.h:
* loader/MainResourceLoader.cpp:
* page/Timing.cpp:
git-svn-id: svn://svn.chromium.org/blink/trunk@64051 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | 5c9d37f8055700c36b4c9006b0d4d81f4f961a06 | chrome | bigvul | 1 | null | null | null |
[cros] Pass pepper plugin flag for Guest mode quoted.
This change will only work after session_manager change is submitted:
http://codereview.chromium.org/4734002
BUG=chromium-os:7526
TEST=Manual. Flash works in Guest mode.
Review URL: http://codereview.chromium.org/4743001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65669 0039d316-1c4b-4281-b951-d872f2087c98 | 60907d63ce74cbed893473c4e9bb569f47ca0c01 | chrome | bigvul | 1 | null | null | null |
Unreviewed, rolling out r93767.
http://trac.webkit.org/changeset/93767
https://bugs.webkit.org/show_bug.cgi?id=66931
Broke Qt bot. (Requested by yutak on #webkit).
Patch by Sheriff Bot <[email protected]> on 2011-08-25
* Scripts/webkitpy/thirdparty/__init__.py:
git-svn-id: svn://svn.chromium.org/blink/trunk@93776 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | 947f359c405105358cc33a6c2a2ad25deefe73ce | chrome | bigvul | 1 | null | null | null |
Fix indents. I am used to webkit style, so did it wrong in last commit.
BUG=68244
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70637 0039d316-1c4b-4281-b951-d872f2087c98 | cfcce91cfc1a14a91a672ad0f052b86a5c1768a3 | chrome | bigvul | 1 | null | null | null |
Use the lock when accessing the buffer object.
BUG=69195
TEST=play Z-Type for hours :)
Review URL: http://codereview.chromium.org/6157007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71211 0039d316-1c4b-4281-b951-d872f2087c98 | b9866ebc631655c593a2ac60a3c7cf7d217ccf5d | chrome | bigvul | 1 | null | null | null |
Disable tcmalloc profile files.
BUG=154983
[email protected]
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/11087041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@161048 0039d316-1c4b-4281-b951-d872f2087c98 | 7bc64304a46b76928da4149693bb4e60907e54c8 | chrome | bigvul | 1 | null | null | null |
Wipe out QuotaThreadTask.
This is a one of a series of refactoring patches for QuotaManager.
http://codereview.chromium.org/10872054/
http://codereview.chromium.org/10917060/
BUG=139270
Review URL: https://chromiumcodereview.appspot.com/10919070
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154987 0039d316-1c4b-4281-b951-d872f2087c98 | d65b01ca819881a507b5e60c25a2f9caff58cd57 | chrome | bigvul | 1 | null | null | null |
Remove core/platform/win
This CL moves the files to platform/win.
[email protected]
BUG=297477
Review URL: https://codereview.chromium.org/26113005
git-svn-id: svn://svn.chromium.org/blink/trunk@159156 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | f135caea12111ac8fc18c3e3ee8d0c18afab74b3 | chrome | bigvul | 1 | null | null | null |
Initialize renderer color preferences to reasonable defaults.
BUG=158422
TEST=as in bug
Review URL: https://chromiumcodereview.appspot.com/11365096
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166146 0039d316-1c4b-4281-b951-d872f2087c98 | c975c78878fff68e82333f599882a7f73cb721ea | chrome | bigvul | 1 | null | null | null |
Remove Crash expectations from TestExpectations that no longer occur
[email protected]
BUG=86340,168853,238082,243599,256506,256518,258949,260655,306645
Review URL: https://codereview.chromium.org/27748004
git-svn-id: svn://svn.chromium.org/blink/trunk@159896 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | f9d1c5c4736a53fb16321a14f8a104cf7336f097 | chrome | bigvul | 1 | null | null | null |
Blink roll 158623:158632
http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=158624:158632&mode=html
TBR=
BUG=
Review URL: https://codereview.chromium.org/25543002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226275 0039d316-1c4b-4281-b951-d872f2087c98 | 69eef4e59d20d234228b062569452ae5808a537a | chrome | bigvul | 1 | null | null | null |
Tests were marked as Flaky.
BUG=151811,151810
[email protected],[email protected]
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/10968052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158204 0039d316-1c4b-4281-b951-d872f2087c98 | 9e417dae2833230a651989bb4e56b835355dda39 | chrome | bigvul | 1 | null | null | null |
Break path whereby AssociatedURLLoader::~AssociatedURLLoader() is re-entered on top of itself.
BUG=159429
Review URL: https://chromiumcodereview.appspot.com/11359222
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@168150 0039d316-1c4b-4281-b951-d872f2087c98 | a75c45bf1cad925548a75bf88f828443bc8ee27d | chrome | bigvul | 1 | null | null | null |
Restrict the Chromoting client plugin to use by extensions & apps.
BUG=160456
Review URL: https://chromiumcodereview.appspot.com/11365276
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@168289 0039d316-1c4b-4281-b951-d872f2087c98 | 21fdcdd977e8ab479dd99c6d0d2f562dda98261d | chrome | bigvul | 1 | null | null | null |
Revert 231554 "Blink roll 160782:160803"
> Blink roll 160782:160803
>
> http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=160783:160803&mode=html
> TBR=
> BUG=
>
> Review URL: https://codereview.chromium.org/50293003
[email protected]
Review URL: https://codereview.chromium.org/48353009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@231585 0039d316-1c4b-4281-b951-d872f2087c98 | 9792d3fed1e580f5e280d105f981b271fd7a607d | chrome | bigvul | 1 | null | null | null |
Security fix: integer overflow on checking image size
Test is left in another CL (codereview.chromiu,.org/11274036) to avoid conflict there. Hope it's fine.
BUG=160926
Review URL: https://chromiumcodereview.appspot.com/11410081
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167882 0039d316-1c4b-4281-b951-d872f2087c98 | ad103a1564365c95f4ee4f10261f9604f91f686a | chrome | bigvul | 1 | null | null | null |
Move MediaStreamSource to platform/
BUG=297477
Review URL: https://codereview.chromium.org/64593002
git-svn-id: svn://svn.chromium.org/blink/trunk@161639 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | 5defd420a613f2e4769f4c1a38786f4cecdcf173 | chrome | bigvul | 1 | null | null | null |
Apply missing kParentDirectory check
BUG=161564
Review URL: https://chromiumcodereview.appspot.com/11414046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@168692 0039d316-1c4b-4281-b951-d872f2087c98 | 8083841913b8eb8018ae52f67c923f0b3d66c466 | chrome | bigvul | 1 | null | null | null |
Auto-rebaseline for r162805
http://src.chromium.org/viewvc/blink?view=revision&revision=162805
BUG=323880
[email protected]
Review URL: https://codereview.chromium.org/94913002
git-svn-id: svn://svn.chromium.org/blink/trunk@162835 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | 00df34b539768627fdfce51bed2cdf05810e83c4 | chrome | bigvul | 1 | null | null | null |
Fixing cross-process postMessage replies on more than two iterations.
When two frames are replying to each other using event.source across processes,
after the first two replies, things break down. The root cause is that in
RenderViewImpl::GetFrameByMappedID, the lookup was incorrect. It is now
properly searching for the remote frame id and returning the local one.
BUG=153445
Review URL: https://chromiumcodereview.appspot.com/11040015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@159924 0039d316-1c4b-4281-b951-d872f2087c98 | d1a59e4e845a01d7d7b80ef184b672752a9eae4d | chrome | bigvul | 1 | null | null | null |
DevTools: 'Overrides' UI overlay obstructs page and element inspector
BUG=302862
[email protected]
Review URL: https://codereview.chromium.org/40233006
git-svn-id: svn://svn.chromium.org/blink/trunk@160559 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | d4cd2b2c0953ad7e9fa988c234eb9361be80fe81 | chrome | bigvul | 1 | null | null | null |
Remove BlobRegistry indirection since there is only one implementation.
BUG=
Review URL: https://chromiumcodereview.appspot.com/15851008
git-svn-id: svn://svn.chromium.org/blink/trunk@152746 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | d0c31f0342cefc46a3b3d80359a9779d044d4c0d | chrome | bigvul | 1 | null | null | null |
Prevent overflow of width/height of layout overflow rectangle which can cause scroll bar to misfunction.
When a child element is positioned very far away the width/height of layout overflow rectangle may overflow. The patch detects such cases in RenderOverflow::addLayoutOverflow and shift the top/left edges of the rectangle to avoid overflow.
BUG=267462
Review URL: https://chromiumcodereview.appspot.com/22799017
git-svn-id: svn://svn.chromium.org/blink/trunk@156567 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | 30afcc0242bd789a7b67e1ca8fe829640279a3cf | chrome | bigvul | 1 | null | null | null |
DevTools: Show unicode "hair space" as html entity in Dev Tools Elements Panel
The DOM tree should show   instead of an ordinary space
for the Hairspace (\u200a) character.
BUG=232970
Review URL: https://codereview.chromium.org/14236007
git-svn-id: svn://svn.chromium.org/blink/trunk@148638 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | eec1ab47e73c5468a3738bc935f01627b6f47382 | chrome | bigvul | 1 | null | null | null |
Fix clobbered build issue.
[email protected]
NOTRY=true
BUG=269698
Review URL: https://chromiumcodereview.appspot.com/22425005
git-svn-id: svn://svn.chromium.org/blink/trunk@155711 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | 4cc2a2c82e1094c2d2044f4e55ce03ad689bcc42 | chrome | bigvul | 1 | null | null | null |
Add a check to prevent len from going negative in xmlParseAttValueComplex.
BUG=158249
Review URL: https://chromiumcodereview.appspot.com/11343029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@164867 0039d316-1c4b-4281-b951-d872f2087c98 | 6e487b9db2ff0324523a040180f8da42796aeef5 | chrome | bigvul | 1 | null | null | null |
Guard against the same PrintWebViewHelper being re-entered.
BUG=159165
Review URL: https://chromiumcodereview.appspot.com/11367076
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@165821 0039d316-1c4b-4281-b951-d872f2087c98 | b755ebba29dd405d6f1e4cf70f5bc81ffd33b0f6 | chrome | bigvul | 1 | null | null | null |
Refactoring: Move m_mayDisplaySeamlesslyWithParent down to Document
The member is used only in Document, thus no reason to
stay in SecurityContext.
TEST=none
BUG=none
[email protected], abarth, haraken, hayato
Review URL: https://codereview.chromium.org/27615003
git-svn-id: svn://svn.chromium.org/blink/trunk@159829 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | 401d30ef93030afbf7e81e53a11b68fc36194502 | chrome | bigvul | 1 | null | null | null |
Revert 137988 - VAVDA is the hardware video decode accelerator for Chrome on Linux and ChromeOS for Intel CPUs (Sandy Bridge and newer).
This CL enables VAVDA acceleration for ChromeOS, both for HTML5 video and Flash.
The feature is currently hidden behind a command line flag and can be enabled by adding the --enable-vaapi parameter to command line.
BUG=117062
TEST=Manual runs of test streams.
Change-Id: I386e16739e2ef2230f52a0a434971b33d8654699
Review URL: https://chromiumcodereview.appspot.com/9814001
This is causing crbug.com/129103
[email protected]
Review URL: https://chromiumcodereview.appspot.com/10411066
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138208 0039d316-1c4b-4281-b951-d872f2087c98 | 9597042cad54926f50d58f5ada39205eb734d7be | chrome | bigvul | 1 | null | null | null |
Revert r157378 as it caused WebRTC to dereference null pointers when restarting a call.
I've kept my unit test changes intact but disabled until I get a proper fix.
BUG=147499,150805
TBR=henrika
Review URL: https://codereview.chromium.org/10946040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157626 0039d316-1c4b-4281-b951-d872f2087c98 | 6d2aef28cb0b677af468ebf3e32a176a7c37086e | chrome | bigvul | 1 | null | null | null |
Add Drive API parser for About/Apps json
BUG=chromium:127728
TEST=unit_test --gtest_filter="DriveApiParser.*"
Review URL: https://chromiumcodereview.appspot.com/10810070
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148692 0039d316-1c4b-4281-b951-d872f2087c98 | 6bdf093650147311383b38f0ad26d6d0f091b21f | chrome | bigvul | 1 | null | null | null |
SelectElement should remove an option when null is assigned by indexed setter
Fix bug embedded in r151449
see
http://src.chromium.org/viewvc/blink?revision=151449&view=revision
[email protected], [email protected], [email protected]
BUG=262365
TEST=fast/forms/select/select-assign-null.html
Review URL: https://chromiumcodereview.appspot.com/19947008
git-svn-id: svn://svn.chromium.org/blink/trunk@154743 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | 7fa8bd35982700cb2cb6ce22d05128c019a2b587 | chrome | bigvul | 1 | null | null | null |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.