commit_msg
stringlengths 1
24.2k
| commit_hash
stringlengths 2
84
⌀ | project
stringlengths 2
40
| source
stringclasses 4
values | labels
int64 0
1
| repo_url
stringlengths 26
70
⌀ | commit_url
stringlengths 74
118
⌀ | commit_date
stringlengths 25
25
⌀ |
|---|---|---|---|---|---|---|---|
Prevent duplicate certificates in TrustedCertificateIndex
With the separate caching of intermediate certificates in
TrustManagerImpl a given intermediate may be passed into .index multiple
times. Avoid adding the certificate to the list each time.
(cherry-picked from commit d080e064abba665e2dde2a8c113f837ba4d9a85e)
Bug: 26232830
Change-Id: I6bed2c65d9e42e052b9b1b129200a997e7dca745
| 4c9f9c2201116acf790fca25af43995d29980ee0 | android | bigvul | 1 | null | null | null |
Fix security vulnerability: Equalizer command might allow negative indexes
Bug: 32247948
Bug: 32438598
Bug: 32436341
Test: use POC on bug or cts security test
Change-Id: I56a92582687599b5b313dea1abcb8bcb19c7fc0e
(cherry picked from commit 3f37d4ef89f4f0eef9e201c5a91b7b2c77ed1071)
(cherry picked from commit ceb7b2d7a4c4cb8d03f166c61f5c7551c6c760aa)
| d72ea85c78a1a68bf99fd5804ad9784b4102fe57 | android | bigvul | 1 | null | null | null |
Add bound check for rfc_parse_data
Bug: 78288018
Test: manual
Change-Id: I44349cd22c141483d01bce0f5a2131b727d0feb0
(cherry picked from commit 6039cb7225733195192b396ad19c528800feb735)
| 9fe27a9b445f7e911286ed31c1087ceac567736b | android | bigvul | 1 | null | null | null |
Fix a wrong check in rfc_parse_data
Bug: 78288018
Bug: 111436796
Test: manual
Change-Id: I16e6026acbaac230fe1453bbac040d1b75bcea2a
(cherry picked from commit d1ced302cd1066087588c891027b1756be31db46)
| d4a34fefbf292d1e02336e4e272da3ef1e3eef85 | android | bigvul | 1 | null | null | null |
DO NOT MERGE. Extend SQLiteQueryBuilder for update and delete.
Developers often accept selection clauses from untrusted code, and
SQLiteQueryBuilder already supports a "strict" mode to help catch
SQL injection attacks. This change extends the builder to support
update() and delete() calls, so that we can help secure those
selection clauses too.
Bug: 111085900
Test: atest packages/providers/DownloadProvider/tests/
Test: atest cts/tests/app/src/android/app/cts/DownloadManagerTest.java
Test: atest cts/tests/tests/database/src/android/database/sqlite/cts/SQLiteQueryBuilderTest.java
Change-Id: Ib4fc8400f184755ee7e971ab5f2095186341730c
Merged-In: Ib4fc8400f184755ee7e971ab5f2095186341730c
(cherry picked from commit 506994268bc4fa07d8798b7737a2952f74b8fd04)
| ebc250d16c747f4161167b5ff58b3aea88b37acf | android | bigvul | 1 | null | null | null |
DO NOT MERGE. All untrusted selections must go through builder.
When accepting untrusted selections, they must be passed directly
to SQLiteQueryBuilder to ensure that setStrict() can be applied to
check for malicious callers sending unbalanced parentheses. This
means we can't mix local and remote selections; they always need to
be kept separate.
Use newly added SQLiteQueryBuilder functionality to apply strict
detection to update() and delete() calls.
Only allow the owner of a particular download to query the headers
for that download. Only delete headers for a download once we've
confirmed that caller can modify that download.
Test: atest packages/providers/DownloadProvider/tests/
Test: atest cts/tests/app/src/android/app/cts/DownloadManagerTest.java
Bug: 111085900
Change-Id: I9fd8e0d3cf80d7603bf0092f36fe449467090821
Merged-In: I9fd8e0d3cf80d7603bf0092f36fe449467090821
(cherry picked from commit 64b55ea82b1f394369237601ae1f1c78b776aabc)
| e7364907439578ce5334bce20bb03fef2e88b107 | android | bigvul | 1 | null | null | null |
Test for error in handling getters changing element kind.
Bug: 111274046
Test: m -j proxy_resolver_v8_unittest && adb sync && adb shell \
/data/nativetest64/proxy_resolver_v8_unittest/proxy_resolver_v8_unittest
Merged-In: I99def991ebcb7c26ba7ca4b4b31ef1cdeaea7721
Change-Id: I99def991ebcb7c26ba7ca4b4b31ef1cdeaea7721
(cherry picked from commit 59b9b11a462fe3aad313b8538fb98468f22d9095)
| 948d4753664cc4e6b33cc3de634ac8fd5f781382 | android | bigvul | 1 | null | null | null |
Optimise the hit test algorithm
Layout#getOffsetForHorizontal was running in O(n^2) time, where n is the
length of the current line. The method is used when a touch event
happens on a text line, to compute the cursor offset (and the character)
where it happened. Although this is not an issue in common usecases,
where the number of characters on a line is relatively small, this can
be very inefficient as a consequence of Unicode containing 0-width
(invisible) characters. Specifically, there are characters defining the
text direction (LTR or RTL), which cause our algorithm to touch the
worst case quadratic runtime. For example, a person is able to send a
message containing a few visible characters, and also a lot of these
direction changing invisible ones. When the receiver touches the message
(causing the Layout#getOffsetForHorizontal method to be called), the
receiver's application would become not responsive.
This CL optimizes the method to run in O(n) worst case. This is achieved
by computing the measurements of all line prefixes at first, which can
be done in a single pass. Then, all the prefix measurement queries will
be answered in O(1), rather than O(n) as it was happening before.
Bug: 79215201
Test: manual testing
Change-Id: Ib66ef392c19c937718e7101f6d48fac3abe51ad0
Merged-In: Ib66ef392c19c937718e7101f6d48fac3abe51ad0
| 3b6f84b77c30ec0bab5147b0cffc192c86ba2634 | android | bigvul | 1 | null | null | null |
Do not discount a MANUAL_SUBFRAME load just because it involved
some redirects.
R=brettw
BUG=21353
TEST=none
Review URL: http://codereview.chromium.org/246073
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27887 0039d316-1c4b-4281-b951-d872f2087c98 | b9e2ecab97a8a7f3cce06951ab92a3eaef559206 | chrome | bigvul | 1 | null | null | null |
2009-05-04 Kai Brüning <[email protected]>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=24883
24883: Bad success test in parseXMLDocumentFragment in XMLTokenizerLibxml2.cpp
Fixed test whether all the chunk has been processed to correctly count utf8 bytes.
Test: fast/innerHTML/innerHTML-nbsp.xhtml
* dom/XMLTokenizerLibxml2.cpp:
(WebCore::parseXMLDocumentFragment):
git-svn-id: svn://svn.chromium.org/blink/trunk@43195 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | a1ce1b69e269a7e61ea0bf0691b90be0cbe9b4c5 | chrome | bigvul | 1 | null | null | null |
2009-10-23 Chris Evans <[email protected]>
Reviewed by Adam Barth.
Added test for bug 27239 (ignore Refresh for view source mode).
https://bugs.webkit.org/show_bug.cgi?id=27239
* http/tests/security/view-source-no-refresh.html: Added
* http/tests/security/view-source-no-refresh-expected.txt: Added
* http/tests/security/resources/view-source-no-refresh.php: Added
2009-10-23 Chris Evans <[email protected]>
Reviewed by Adam Barth.
Ignore the Refresh header if we're in view source mode.
https://bugs.webkit.org/show_bug.cgi?id=27239
Test: http/tests/security/view-source-no-refresh.html
* loader/FrameLoader.cpp: ignore Refresh in view-source mode.
git-svn-id: svn://svn.chromium.org/blink/trunk@50018 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | befb46ae3385fa13975521e9a2281e35805b339e | chrome | bigvul | 1 | null | null | null |
Turn on SyncedNotifications for Dev, Canary, and Unknown channel
Turning it on in Dev and Canary will allow us to gather feedback during the development process.
BUG=22205
Review URL: https://chromiumcodereview.appspot.com/12617010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190089 0039d316-1c4b-4281-b951-d872f2087c98 | 0b53a1df69a39e0663c9e4d651de402fc3d1d10a | chrome | bigvul | 1 | null | null | null |
2009-10-27 James Robinson <[email protected]>
Reviewed by Darin Fisher.
Ensures that JavaScriptCore/wtf/CurrentTime.cpp is not built in PLATFORM(CHROMIUM) builds.
Chromium uses a different method to calculate the current time than is used in
JavaScriptCore/wtf/CurrentTime.cpp. This can lead to time skew when calls to currentTime() and Chromium's time
function are mixed. In particular, timers can get scheduled in the past which leads to 100% CPU use.
See http://code.google.com/p/chromium/issues/detail?id=25892 for an example.
https://bugs.webkit.org/show_bug.cgi?id=30833
* JavaScriptCore.gyp/JavaScriptCore.gyp:
* wtf/CurrentTime.cpp:
git-svn-id: svn://svn.chromium.org/blink/trunk@50173 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | 94ec1b3d9b6983c021d1e1099b112b1b298b587d | chrome | bigvul | 1 | null | null | null |
2010-12-27 Philippe Normand <[email protected]>
Unreviewed, skip another GTK media test reporting wrong duration,
see bug 51602.
* platform/gtk/Skipped:
git-svn-id: svn://svn.chromium.org/blink/trunk@74682 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | 7cf02788a63cf5fc49d6b1e039abc799f4fa2c5f | chrome | bigvul | 1 | null | null | null |
Rebase ThaiUTF8 unit test.
TEST=unit_tests
BUG=50705
http://codereview.chromium.org/3085005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55257 0039d316-1c4b-4281-b951-d872f2087c98 | b714b8c580cd67b647b339eae3bda6ec598addae | chrome | bigvul | 1 | null | null | null |
REGRESSION (r83928 or before): Some tests failing assertions in MarkStack::internalAppend
/ MarkStack::drain.
https://bugs.webkit.org/show_bug.cgi?id=58657
Add inspector/styles/styles-cancel-editing.html to the Windows XP Skipped list because it
has been crashing under MarkStack::drain on the Windows XP bots.
* platform/win-xp/Skipped:
git-svn-id: svn://svn.chromium.org/blink/trunk@85479 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | 2d6f52a0c2c5536a184338824862b41504c25b89 | chrome | bigvul | 1 | null | null | null |
Apply behaviour change fix from upstream for previous XPath change.
BUG=58731
TEST=NONE
Review URL: http://codereview.chromium.org/4027006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63572 0039d316-1c4b-4281-b951-d872f2087c98 | a44b00c88bc5ea35b5b150217c5fd6e4ce168e58 | chrome | bigvul | 1 | null | null | null |
2011-04-19 Ryosuke Niwa <[email protected]>
Skip the test added by r84264. The bug tracked by
https://bugs.webkit.org/show_bug.cgi?id=58741
* platform/qt/Skipped:
git-svn-id: svn://svn.chromium.org/blink/trunk@84292 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | d715bf24107aef6a311b26da89926d72875d5542 | chrome | bigvul | 1 | null | null | null |
Roll Skia to r607 to pick up font fixes.
BUG=59320
TEST=layout
TBR=senorblanco
Review URL: http://codereview.chromium.org/3838007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63010 0039d316-1c4b-4281-b951-d872f2087c98 | 3926bc91f996e165de9656b1c55ad9ea88c5c707 | chrome | bigvul | 1 | null | null | null |
Extend the suppression for bug 56090 (Valgrind leak in
_ZN11ProfileImpl20CreateWebDataServiceEv)
Extend the suppression for bug 22450 (Memory leak in
URLRequestTestHTTP.UnexpectedServerAuthTest, .ProxyTunnelRedirectTest)
BUG=56090,22450
TBR=timurrrr
Review URL: http://codereview.chromium.org/3416016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60055 0039d316-1c4b-4281-b951-d872f2087c98 | 486f3378bfef5343691f23296b60265b08ea9213 | chrome | bigvul | 1 | null | null | null |
2011-05-06 Dirk Pranke <[email protected]>
Reviewed by Ojan Vafai.
new-run-webkit-tests: crashes in race with crashing DRT
https://bugs.webkit.org/show_bug.cgi?id=60238
This fixes a race where if we wrote the URL to DRT and
DRT crashed immediately, we could get a broken pipe
error back during the write() and not handle it correctly,
causing NRWT to also crash.
* Scripts/webkitpy/layout_tests/port/server_process.py:
* Scripts/webkitpy/layout_tests/port/webkit.py:
git-svn-id: svn://svn.chromium.org/blink/trunk@85982 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | 2f865f946c2c88c38c144c2703ba32fbf504de99 | chrome | bigvul | 1 | null | null | null |
WebKit roll 60327:60341
BUG=none
TEST=none
TBR=tony,pkasting
Review URL: http://codereview.chromium.org/2363001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48469 0039d316-1c4b-4281-b951-d872f2087c98 | f649c5eda1375c0499ba93f2b10f3c573df8c3f8 | chrome | bigvul | 1 | null | null | null |
Added check in page click tracker to ensure events passed in are mouse events
BUG=61255
TEST=None
Review URL: http://codereview.chromium.org/4120011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64510 0039d316-1c4b-4281-b951-d872f2087c98 | 1a5af201a654bf80ce1bd6721b31a97311ae67a6 | chrome | bigvul | 1 | null | null | null |
2011-05-12 Keith Kyzivat <[email protected]>
Reviewed by Csaba Osztrogonác.
[Qt] Arm debug build failing on ARMAssembler::debugOffset()
https://bugs.webkit.org/show_bug.cgi?id=60688
Related to svn rev 85523
* assembler/ARMAssembler.h:
(JSC::ARMAssembler::debugOffset):
git-svn-id: svn://svn.chromium.org/blink/trunk@86316 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | 7217bf5c3074d5dfc91d59edefd2b77dd4edcff2 | chrome | bigvul | 1 | null | null | null |
AutoFill: Record whether the user initiated the form submission and don't save form data if the form was not user-submitted.
BUG=48225
TEST=none
Review URL: http://codereview.chromium.org/2842062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53350 0039d316-1c4b-4281-b951-d872f2087c98 | 59f5e0204cbc0e524b2687fb1beddda82047d16d | chrome | bigvul | 1 | null | null | null |
Unittest fix. Need to put usersubmitted = true for unittests.
BUG=51727
Review URL: http://codereview.chromium.org/3151006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55632 0039d316-1c4b-4281-b951-d872f2087c98 | cf2016d357ca3bc39895c05c691b4def860699e0 | chrome | bigvul | 1 | null | null | null |
AutoFill: Release the cached frame when we receive the frameDestroyed() message
from WebKit.
BUG=48857
TEST=none
Review URL: http://codereview.chromium.org/3173005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55789 0039d316-1c4b-4281-b951-d872f2087c98 | 5041f984669fe3a989a84c348eb838c8f7233f6b | chrome | bigvul | 1 | null | null | null |
Fix crasher with autofill infobar.
The "save credit card" information was deleted by the AutofillManager when the form is submitted but was still pointed to by the TabContents, causing a crasher when navigating.
BUG=50428
TEST=See steps in 56238.
Review URL: http://codereview.chromium.org/3466006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60095 0039d316-1c4b-4281-b951-d872f2087c98 | 0d04639df7a3b2425c671ab08f68eb32b3d04cb1 | chrome | bigvul | 1 | null | null | null |
2010-12-28 Mikhail Naganov <[email protected]>
Reviewed by Pavel Feldman.
[Chromium] Fix memory leak in Profiles tab concerned with heap profiles views.
https://bugs.webkit.org/show_bug.cgi?id=51680
* inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfilesPanel.prototype._reset):
git-svn-id: svn://svn.chromium.org/blink/trunk@74712 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | db180e395cef99181ad578b7dc19352418682424 | chrome | bigvul | 1 | null | null | null |
2011-01-24 Pavel Podivilov <[email protected]>
Reviewed by Pavel Feldman.
Web Inspector: [REGRESSION] AppCache view on resources panel is broken.
https://bugs.webkit.org/show_bug.cgi?id=53002
* inspector/front-end/ApplicationCacheItemsView.js:
(WebInspector.ApplicationCacheItemsView.prototype._update):
* inspector/front-end/DOMAgent.js:
(WebInspector.ApplicationCacheDispatcher.getApplicationCachesAsync):
git-svn-id: svn://svn.chromium.org/blink/trunk@76517 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | 1ecebbeaa6ab16378690500126776dfd2a633e03 | chrome | bigvul | 1 | null | null | null |
Try to fix crash in WebSocketExperimentRunner::DoLoop
Crash in WebSocketExperimentRunner::DoLoop() by access violation write.
I guess WebSocketExperimentRunner is deleted before calling back DoLoop.
I suspect WebSocketExperimentRunner is deleted if some task was finished
with ERR_ABORTED other than Cancel. ERR_ABORTED may happen when SocketStream
closed unexpectedly, so it would not be good to handle Cancel case.
Use next_state_ == STATE_NONE to check the task was cancelled.
BUG=53985
TEST=none
Review URL: http://codereview.chromium.org/3317001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58317 0039d316-1c4b-4281-b951-d872f2087c98 | 97854fdfa143fde639e62aa64a897edab76a8992 | chrome | bigvul | 1 | null | null | null |
2011-02-09 Abhishek Arya <[email protected]>
Reviewed by James Robinson.
[Chromium] Issue 72387: Integer bounds crash in LayerTilerChromium::resizeLayer
https://bugs.webkit.org/show_bug.cgi?id=54132
* platform/graphics/chromium/LayerTilerChromium.cpp:
(WebCore::LayerTilerChromium::resizeLayer):
git-svn-id: svn://svn.chromium.org/blink/trunk@78143 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | 26917dc40fb9dc7ef74fa9e0e8fd221e9b857993 | chrome | bigvul | 1 | null | null | null |
Run worker processes via the zygote.
The following tests fail when using the SUID sandbox because they try to count
processes and the extra sandbox processes throw them off. They pass with this
patch so long as the SUID sandbox isn't invoked (which is the case on the
builders):
WorkerTest.FLAKY_MultipleTabsQueuedSharedWorker
WorkerTest.FLAKY_LimitPerPage
WorkerTest.WorkerClose
WorkerTest.QueuedSharedWorkerShutdown
WorkerTest.FLAKY_QueuedSharedWorkerStartedFromOtherTab
Note that this patch doesn't trigger the seccomp sandbox for worker
processes. That will have to wait for another CL.
BUG=54794
TEST=ui_tests
http://codereview.chromium.org/3312021/show
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59242 0039d316-1c4b-4281-b951-d872f2087c98 | e5368488e2fdad1cf27d6c0fd1031769affbaa5e | chrome | bigvul | 1 | null | null | null |
Don't force callers to be ASCII (when some of them already aren't).
TBR=tfarina
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3137015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56451 0039d316-1c4b-4281-b951-d872f2087c98 | c10688623b331e0c72c502b718cff5016de61f85 | chrome | bigvul | 1 | null | null | null |
OTS roll to r35.
BUG=51070
TBR=agl
Review URL: http://codereview.chromium.org/3156001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55537 0039d316-1c4b-4281-b951-d872f2087c98 | f79b13815f2ed08840b22ecdd9dfefe68ba35fa5 | chrome | bigvul | 1 | null | null | null |
Revert "Modules: Add native library coverage to bundle smoke test"
This reverts commit f4d9d461eddfec5c8343aece233f557ac08c7278.
Reason for revert: Breaks the linker tool chain on both Android build bots:
[14630/20253] SOLINK ./libchrome__combined.so
FAILED: libchrome__combined.so libchrome__combined.so.TOC lib.unstripped/libchrome__combined.so
python "../../build/toolchain/gcc_solink_wrapper.py" --readelf="../../third_party/android_ndk/toolch...(too long)
Stack dump:
0. Program arguments: /b/s/w/ir/cache/builder/src/out/Debug/../../third_party/llvm-build/Release+Asserts/bin/ld.lld @/b/s/w/ir/tmp/t/response-0b11b7.txt
#0 0x0000000000f77cdd (/b/s/w/ir/cache/builder/src/out/Debug/../../third_party/llvm-build/Release+Asserts/bin/ld.lld+0xf77cdd)
clang: error: unable to execute command: Segmentation fault (core dumped)
clang: error: linker command failed due to signal (use -v to see invocation)
https://ci.chromium.org/p/chromium/builders/ci/Android%20arm%20Builder%20%28dbg%29/45400
https://ci.chromium.org/p/chromium/builders/ci/Android%20arm64%20Builder%20%28dbg%29/39610
Original change's description:
> Modules: Add native library coverage to bundle smoke test
>
> - Add a new test case to exercise a native library.
>
> - Generalize the display of the result dialog for multiple test cases.
>
> - Specify a "pass" or "fail" in the results dialog text, to be parsed by
> the test, and also aid in manual testing (where the test activity may
> be spawned manually).
>
> - Component build coverage is stubbed out; it will be added once the
> component build places feature libs in DFMs.
>
> Bug: 989646
> Change-Id: I724d0725f71ad7897ceb7b81d9fe7d22183889ca
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796308
> Commit-Queue: Christopher Grant <[email protected]>
> Reviewed-by: Tibor Goldschwendt <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#696035}
[email protected],[email protected],[email protected]
Change-Id: Iac48461564dac006d57e2fff7c4c705e21022149
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 989646
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1802083
Reviewed-by: Sorin Jianu <[email protected]>
Commit-Queue: Sorin Jianu <[email protected]>
Cr-Commit-Position: refs/heads/master@{#696176} | 28e5bc91f89cec1c98374d78ee95948737452f42 | chrome | bigvul | 1 | null | null | null |
2010-11-16 Pavel Feldman <[email protected]>
Reviewed by Yury Semikhatsky.
Web Inspector: init front-end UI upon DOMContentLoaded, not load event.
https://bugs.webkit.org/show_bug.cgi?id=49596
* inspector/front-end/inspector.js:
(windowLoaded):
git-svn-id: svn://svn.chromium.org/blink/trunk@72102 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | c07975646710f1c892355c04eefa34f763399ed7 | chrome | bigvul | 1 | null | null | null |
Set the original URL for downloads
https://bugs.webkit.org/show_bug.cgi?id=49628
Reviewed by John Sullivan.
WebCore:
Export symbols needed by WebKit2.
* WebCore.exp.in:
WebKit2:
* WebProcess/Downloads/DownloadManager.cpp:
(WebKit::DownloadManager::startDownload):
* WebProcess/Downloads/DownloadManager.h:
startDownload now takes the originating web page.
* WebProcess/Downloads/cf/DownloadCFNet.cpp:
(WebKit::Download::start):
start now takes the originating web page.
* WebProcess/Downloads/mac/DownloadMac.mm:
(WebKit::originatingURL):
(WebKit::setOriginalURLForDownload):
Port code over from WebKit1 that sets the download URL.
(WebKit::Download::start):
Call setOriginalURLForDownload.
* WebProcess/Downloads/qt/DownloadQt.cpp:
(WebKit::Download::start):
start now takes the originating web page.
* WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::startDownload):
Pass the web page to DownloadManager::startDownload.
git-svn-id: svn://svn.chromium.org/blink/trunk@72145 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | 1797c8188e7d42f0adf6ce0e607307cd313e1d7d | chrome | bigvul | 1 | null | null | null |
Build fix following bug #30696.
Patch by Gavin Barraclough <[email protected]> on 2009-10-22
Reviewed by NOBODY (build fix).
* WebCoreSupport/FrameLoaderClientGtk.cpp:
(WebKit::FrameLoaderClient::windowObjectCleared):
* webkit/webkitwebframe.cpp:
(webkit_web_frame_get_global_context):
git-svn-id: svn://svn.chromium.org/blink/trunk@49964 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | a0af50481db56aa780942e8595a20c36b2c34f5c | chrome | bigvul | 1 | null | null | null |
Makes the extension resize gripper only visible when the mouse is over
it.
BUG=45750
TEST=see bug
Review URL: http://codereview.chromium.org/2800022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50515 0039d316-1c4b-4281-b951-d872f2087c98 | f7fdd2894ef51ee234882fa2457bb1f2a8895cbe | chrome | bigvul | 1 | null | null | null |
2009-12-07 Shinichiro Hamaji <[email protected]>
Reviewed by David Levin.
[check-webkit-style] S_OK is a fine identifier
https://bugs.webkit.org/show_bug.cgi?id=32225
* Scripts/modules/cpp_style.py:
* Scripts/modules/cpp_style_unittest.py:
git-svn-id: svn://svn.chromium.org/blink/trunk@51835 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | bba01b563e2cf1777d560b917c2ddfc75d434abd | chrome | bigvul | 1 | null | null | null |
Enable ManifestTest.AppLaunchContainer as it should be passing now.
BUG=47230
TEST=test passes
TBR=robertshield
Review URL: http://codereview.chromium.org/2844016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50553 0039d316-1c4b-4281-b951-d872f2087c98 | 8c3278613079f1c6d858f2b2deb95d8b95dd1789 | chrome | bigvul | 1 | null | null | null |
Fix gcc warning
BUG=51146
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55500 0039d316-1c4b-4281-b951-d872f2087c98 | 537436d7d0ef6690f31de8854886597dddfa1117 | chrome | bigvul | 1 | null | null | null |
ibus-hangul: Use Ctrl+Alt+F9 as a Hanja hot-key instead of F9.
Since F9 is reserved by the window manager on Chrome OS.
BUG=chromium-os:4319
TEST=manually
Review URL: http://codereview.chromium.org/2800039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51654 0039d316-1c4b-4281-b951-d872f2087c98 | 6e094094ed8b96e68b30e8628e8a169719edda27 | chrome | bigvul | 1 | null | null | null |
Changed definition of IntervalTree to contain closed, rather than
open, intervals, and changed back PathProcessor's
AllSegmentsOverlappingY debug routine to report closed intervals. This
fixes more rendering issues with the SVG butterfly.
BUG=none
TEST=samples/gpu2d/regression-tests/orientation-bug-3.html
TBR=apatrick
Review URL: http://codereview.chromium.org/2847049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51670 0039d316-1c4b-4281-b951-d872f2087c98 | f32ac186addb85c49b9bc41c4e84d4ec700a03a5 | chrome | bigvul | 1 | null | null | null |
Clean up calls like "gfx::Rect(0, 0, size().width(), size().height()".
The caller can use the much shorter "gfx::Rect(size())", since gfx::Rect
has a constructor that just takes a Size.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2204001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48283 0039d316-1c4b-4281-b951-d872f2087c98 | ee8d6fd30b022ac2c87b7a190c954e7bb3c9b21e | chrome | bigvul | 1 | null | null | null |
C++ readability change for cindylau.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2090008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48733 0039d316-1c4b-4281-b951-d872f2087c98 | b7e899141194fa27d55a990e38ae8bdcc5183a90 | chrome | bigvul | 1 | null | null | null |
Implement new websocket handshake based on draft-hixie-thewebsocketprotocol-76
BUG=none
TEST=net_unittests passes
Review URL: http://codereview.chromium.org/1108002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42736 0039d316-1c4b-4281-b951-d872f2087c98 | 511d0a0a31a54e0cc0f15cb1b977dc9f9b20f0d3 | chrome | bigvul | 1 | null | null | null |
2010-08-12 Dimitri Glazkov <[email protected]>
Reviewed by Adam Barth.
Ensure that parser doesn't attach children that have been removed by JavaScript event handlers.
https://bugs.webkit.org/show_bug.cgi?id=43813
This patch re-fixes bug 40742 in a way that keeps allowing HTMLLinkElement
to lazy-attach.
* html/HTMLConstructionSite.cpp:
(WebCore::HTMLConstructionSite::attach): Added parent check.
* html/HTMLLinkElement.cpp: Basically undoes changes introduced by r61424.
* html/HTMLLinkElement.h: Ditto.
git-svn-id: svn://svn.chromium.org/blink/trunk@65281 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | 61b77165a1125a80f105f4382a99d9d7a1eb0cf2 | chrome | bigvul | 1 | null | null | null |
Fixing mounting case.
BUG=chromium-os:3292
TEST=none
Review URL: http://codereview.chromium.org/2102013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47866 0039d316-1c4b-4281-b951-d872f2087c98 | 647c3a9f217a9236052e18c7b032669863dd1734 | chrome | bigvul | 1 | null | null | null |
2010-10-26 Kenneth Russell <[email protected]>
Reviewed by Andreas Kling.
Valgrind failure in GraphicsContext3DInternal::reshape
https://bugs.webkit.org/show_bug.cgi?id=48284
* src/WebGraphicsContext3DDefaultImpl.cpp:
(WebKit::WebGraphicsContext3DDefaultImpl::WebGraphicsContext3DDefaultImpl):
git-svn-id: svn://svn.chromium.org/blink/trunk@70534 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | 327585cb0eab0859518643a2d00917081f7e7645 | chrome | bigvul | 1 | null | null | null |
Fix eliding, truncation issues with hostnames in security information dialog for windows, linux platforms resp.
BUG=48597
TEST=None
Review URL: http://codereview.chromium.org/2958002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51972 0039d316-1c4b-4281-b951-d872f2087c98 | d151a5ef5e357e7d7187fcc1aa8fbb6c31f223cb | chrome | bigvul | 1 | null | null | null |
Revert WebKit merge to fix compile break.
BUG=none
TEST=none
TBR=ajwong
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42396 0039d316-1c4b-4281-b951-d872f2087c98 | 78e6ca3e511b6a64472c91d0ad5892d6eb098dde | chrome | bigvul | 1 | null | null | null |
Move the cancellation of blocked requests code from ResourceDispatcherHost::~ResourceDispatcherHost() to ResourceDispatcherHost::OnShutdown().
This causes the requests to be cancelled on the IO thread rather than the UI thread, which is important since cancellation may delete the URLRequest (and URLRequests should not outlive the IO thread).
BUG=39243
Review URL: http://codereview.chromium.org/1213004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42575 0039d316-1c4b-4281-b951-d872f2087c98 | 6c5d779aaf0dec9628da8a20751e95fd09554b14 | chrome | bigvul | 1 | null | null | null |
Instrumented libraries: never run `make install' in parallel.
For some packages this causes flaky failures such as described in
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=42980
BUG=313751
[email protected]
NOTRY=true
Review URL: https://codereview.chromium.org/365923003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281025 0039d316-1c4b-4281-b951-d872f2087c98 | f056eda73653f71dcb7773d20aeac3ea19a58539 | chrome | bigvul | 1 | null | null | null |
2010-08-24 Pavel Podivilov <[email protected]>
Reviewed by Yury Semikhatsky.
Web Inspector: show DOM breakpoints in sidebar pane
https://bugs.webkit.org/show_bug.cgi?id=44424
* inspector/dom-breakpoints.html:
2010-08-24 Pavel Podivilov <[email protected]>
Reviewed by Yury Semikhatsky.
Web Inspector: show DOM breakpoints in sidebar pane
https://bugs.webkit.org/show_bug.cgi?id=44424
* inspector/front-end/BreakpointManager.js:
(WebInspector.BreakpointManager.prototype._setBreakpoint):
(WebInspector.BreakpointManager.prototype._breakpointRemoved):
(WebInspector.BreakpointManager.prototype._setBreakpointOnBackend):
(WebInspector.Breakpoint.prototype.set enabled):
(WebInspector.Breakpoint.prototype.set condition):
(WebInspector.Breakpoint.prototype.remove):
* inspector/front-end/BreakpointsSidebarPane.js:
(WebInspector.BreakpointsSidebarPane):
(WebInspector.BreakpointsSidebarPane.prototype.addBreakpoint):
(WebInspector.BreakpointsSidebarPane.prototype._breakpointRemoved):
(WebInspector.BreakpointsSidebarPane.prototype._contextMenuEventFired):
(WebInspector.BreakpointItem):
(WebInspector.BreakpointItem.prototype.element):
(WebInspector.BreakpointItem.prototype.remove):
(WebInspector.BreakpointItem.prototype._checkboxClicked):
(WebInspector.BreakpointItem.prototype._enableChanged):
(WebInspector.BreakpointItem.prototype._removed):
(WebInspector.JSBreakpointItem):
(WebInspector.JSBreakpointItem.prototype._textChanged):
(WebInspector.DOMBreakpointItem):
(WebInspector.DOMBreakpointItem.prototype.compareTo):
* inspector/front-end/DOMAgent.js:
(WebInspector.DOMBreakpointManager):
(WebInspector.DOMBreakpointManager.prototype.setBreakpoint):
(WebInspector.DOMBreakpointManager.prototype.removeBreakpointsForNode):
(WebInspector.DOMBreakpointManager.prototype._breakpointRemoved):
(WebInspector.DOMBreakpoint):
(WebInspector.DOMBreakpoint.prototype.get enabled):
(WebInspector.DOMBreakpoint.prototype.set enabled):
(WebInspector.DOMBreakpoint.prototype.remove):
* inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel):
(WebInspector.ElementsPanel.prototype.reset):
* inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeElement.prototype._populateTagContextMenu):
* inspector/front-end/ScriptView.js:
(WebInspector.ScriptView):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel):
(WebInspector.ScriptsPanel.prototype._breakpointAdded):
(WebInspector.ScriptsPanel.prototype.reset):
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame):
(WebInspector.SourceFrame.prototype.set visible):
(WebInspector.SourceFrame.prototype.addBreakpoint):
(WebInspector.SourceFrame.prototype._breakpointRemoved):
(WebInspector.SourceFrame.prototype._addBreakpointToSource):
(WebInspector.SourceFrame.prototype._removeBreakpointFromSource):
(WebInspector.SourceFrame.prototype._contextMenu.addConditionalBreakpoint):
(WebInspector.SourceFrame.prototype._contextMenu):
(WebInspector.SourceFrame.prototype._mouseDown):
* inspector/front-end/SourceView.js:
(WebInspector.SourceView):
(WebInspector.SourceView.prototype.updateLocalContent):
* inspector/front-end/inspector.js:
(WebInspector.createJSBreakpointsSidebarPane.breakpointAdded):
(WebInspector.createJSBreakpointsSidebarPane):
(WebInspector.createDOMBreakpointsSidebarPane.breakpointAdded):
(WebInspector.createDOMBreakpointsSidebarPane):
(WebInspector.doLoadedDone):
git-svn-id: svn://svn.chromium.org/blink/trunk@65939 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | 7fbad8ebc8e4181fdef891c3c5b667c11cb6095b | chrome | bigvul | 1 | null | null | null |
https://bugs.webkit.org/show_bug.cgi?id=45164
Reviewed by Dan Bernstein.
REGRESSION: <a><img align=top></a> Clickable area too large
Make sure to clamp hit testing of quirky inline flow boxes the same way we already clamped
painting.
Source/WebCore:
* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::nodeAtPoint):
LayoutTests:
* fast/inline/inline-position-top-align-expected.txt: Added.
* fast/inline/inline-position-top-align.html: Added.
git-svn-id: svn://svn.chromium.org/blink/trunk@81055 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | 04cca6c05e4923f1b91e0dddf053e088456d8645 | chrome | bigvul | 1 | null | null | null |
Add shared images from bookmark manager to chrome://resources/images/
This fixes a bug where we would have missing images in the bookmark manager.
BUG=42817
TEST=Open the bookmark manager. No icons should be missing.
Review URL: http://codereview.chromium.org/1697017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45983 0039d316-1c4b-4281-b951-d872f2087c98 | bbdbe155d5ae70a7d65b39566d5d704b5e442e00 | chrome | bigvul | 1 | null | null | null |
2009-07-24 Jian Li <[email protected]>
Reviewed by Eric Seidel.
[V8] More V8 bindings changes to use ErrorEvent.
https://bugs.webkit.org/show_bug.cgi?id=27630
* bindings/v8/DOMObjectsInclude.h:
* bindings/v8/DerivedSourcesAllInOne.cpp:
* bindings/v8/V8DOMWrapper.cpp:
(WebCore::V8DOMWrapper::convertEventToV8Object):
* bindings/v8/V8Index.cpp:
* bindings/v8/V8Index.h:
git-svn-id: svn://svn.chromium.org/blink/trunk@46360 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | acae973ac6297404fe3c9b389b69bf3c7e62cd19 | chrome | bigvul | 1 | null | null | null |
Don't allow more than one pending print dialog per browser instance.
As a future TODO, it might be nice to limit it per-tab instead of per-app.
BUG=46575
TEST=manual
Review URL: http://codereview.chromium.org/2848011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50203 0039d316-1c4b-4281-b951-d872f2087c98 | ccd0226c79553e318657d6285c2feacebd105996 | chrome | bigvul | 1 | null | null | null |
Set the job name for the print job on the Mac.
BUG=http://crbug.com/29188
TEST=as in bug
Review URL: http://codereview.chromium.org/1997016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47056 0039d316-1c4b-4281-b951-d872f2087c98 | fc790462b4f248712bbc8c3734664dd6b05f80f2 | chrome | bigvul | 1 | null | null | null |
LayoutTests:
Reviewed by Anders.
- test for http://bugzilla.opendarwin.org/show_bug.cgi?id=10202
REGRESSION: Repro crash when loading an empty image document
* fast/tokenizer/image-empty-crash-expected.txt: Added.
* fast/tokenizer/image-empty-crash.html: Added.
WebCore:
Reviewed by Anders.
- fix http://bugzilla.opendarwin.org/show_bug.cgi?id=10202
REGRESSION: Repro crash when loading an empty image document
Test: fast/tokenizer/image-empty-crash.html
* loader/ImageDocument.cpp:
(WebCore::ImageTokenizer::stopParsing): Added null check for m_imageElement.
(WebCore::ImageTokenizer::finish): Ditto.
git-svn-id: svn://svn.chromium.org/blink/trunk@15766 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | b8a29dc352cfcbc8d1d6476b07a483bec18e6808 | chrome | bigvul | 1 | null | null | null |
Only load text fields in the form structure. This prevents us from trying to autofill username/password forms.
BUG=none
TEST=FormStructureTest
TEST=log in to gmail. AutoFill infobar should not show up.
Review URL: http://codereview.chromium.org/661026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39985 0039d316-1c4b-4281-b951-d872f2087c98 | f94e82788f40ca0b6e8ffbbc79948c097de5876f | chrome | bigvul | 1 | null | null | null |
FileReader needs addEventListener
https://bugs.webkit.org/show_bug.cgi?id=42723
Reviewed by Adam Barth.
Source/WebCore:
Test: fast/files/file-reader-event-listener.html
* fileapi/FileReader.idl:
LayoutTests:
* fast/files/file-reader-event-listener-expected.txt: Added.
* fast/files/file-reader-event-listener.html: Added.
git-svn-id: svn://svn.chromium.org/blink/trunk@104180 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | d74b8de894317e6a5472ad112bcf536d81a08999 | chrome | bigvul | 1 | null | null | null |
POSIX: make sure that we never pass directory descriptors into the sandbox.
BUG=43304
http://codereview.chromium.org/2733011/show
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49446 0039d316-1c4b-4281-b951-d872f2087c98 | aac449e7154720b895ff1e7f3497c2ce95ae1a5a | chrome | bigvul | 1 | null | null | null |
Handle CBF_SMBITMAP in the async version of the IPC.
BUG=43307
TEST=NONE
Review URL: http://codereview.chromium.org/1973002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46639 0039d316-1c4b-4281-b951-d872f2087c98 | 7473b624aff7e1db5b22d7a856d1f21509fa04bc | chrome | bigvul | 1 | null | null | null |
Implement NPN_RemoveProperty
https://bugs.webkit.org/show_bug.cgi?id=43315
Reviewed by Sam Weinig.
WebKit2:
* WebProcess/Plugins/NPJSObject.cpp:
(WebKit::NPJSObject::removeProperty):
Try to remove the property.
(WebKit::NPJSObject::npClass):
Add NP_RemoveProperty.
(WebKit::NPJSObject::NP_RemoveProperty):
Call NPJSObject::removeProperty.
* WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
(WebKit::NPN_RemoveProperty):
Call the NPClass::removeProperty function.
WebKitTools:
* DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
Add NPRuntimeRemoveProperty.cpp
* DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
(PluginTest::NPN_GetStringIdentifier):
(PluginTest::NPN_GetIntIdentifier):
(PluginTest::NPN_RemoveProperty):
Add NPN_ helpers.
* DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
Support more NPClass functions.
* DumpRenderTree/TestNetscapePlugIn/Tests/NPRuntimeRemoveProperty.cpp: Added.
(NPRuntimeRemoveProperty::NPRuntimeRemoveProperty):
Test for NPN_RemoveProperty.
(NPRuntimeRemoveProperty::TestObject::hasMethod):
(NPRuntimeRemoveProperty::TestObject::invoke):
Add a testRemoveProperty method.
(NPRuntimeRemoveProperty::NPP_GetValue):
Return the test object.
* DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
* DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
* GNUmakefile.am:
Add NPRuntimeRemoveProperty.cpp
LayoutTests:
Add a test for NPN_RemoveProperty.
* plugins/npruntime/remove-property-expected.txt: Added.
* plugins/npruntime/remove-property.html: Added.
git-svn-id: svn://svn.chromium.org/blink/trunk@64444 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | 93dd81929416a0170935e6eeac03d10aed60df18 | chrome | bigvul | 1 | null | null | null |
Rebaseline tests, affected by fixes to Skia compositing upstream: http://trac.webkit.org/changeset/43902
We actually had wrong baselines and the fixes broke our layout tests :-\
R=senorblanco
BUG=12352
TEST=no layout test regressions.
Review URL: http://codereview.chromium.org/125195
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18504 0039d316-1c4b-4281-b951-d872f2087c98 | f35393928d0846d9275da5e307c24ef6dbcbc3dd | chrome | bigvul | 1 | null | null | null |
Enable SSE2 compilation for ChromeOS.
In practice the <video> tag needs this for faster YUV conversion/filtering.
BUG=19113
TEST=Test youtube html5 with chromeos (not chromiumos). It should not crash, and it should be faster.
Review URL: http://codereview.chromium.org/1553035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44740 0039d316-1c4b-4281-b951-d872f2087c98 | 0183dbb2875dd270d1bf2afde9fca88501d67d37 | chrome | bigvul | 1 | null | null | null |
GTK: allow bookmark manager to MOVE as well as COPY.
BUG=41601
TEST=manual
Review URL: http://codereview.chromium.org/1610035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44955 0039d316-1c4b-4281-b951-d872f2087c98 | 7480de4954fe0ea90dd9e49c4f583f6ea321a55b | chrome | bigvul | 1 | null | null | null |
Canonicalize the url based on Section 6.1 Safe Browsing Spec.
BUG=7713
TEST=SafeBrowsingUtilTest.CanonicalizeUrl
Review URL: http://codereview.chromium.org/1275002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43100 0039d316-1c4b-4281-b951-d872f2087c98 | 69ee9c92af91fdad5aabf0f5696cd0432102985f | chrome | bigvul | 1 | null | null | null |
Reviewed by Tim Hatcher.
Bug 16535: Stylesheets loaded with @import are not editable
http://bugs.webkit.org/show_bug.cgi?id=16535
<rdar://problem/5712899>
Sheets loaded using @import were incorrectly being flagged as non-editable
user agent sheets because their parent sheet doesn't have an ownerNode. We now
check to make sure sheets also don't have a href before restricting their editability.
* page/inspector/StylesSidebarPane.js:
git-svn-id: svn://svn.chromium.org/blink/trunk@30654 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | 3a283acc61a207b3a2b851c8b4a2e2a437741dd8 | chrome | bigvul | 1 | null | null | null |
Removing unnecessary DCHECK from SafeBrowsing interstitial.
BUG=30079
TEST=None.
Review URL: http://codereview.chromium.org/1131003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42049 0039d316-1c4b-4281-b951-d872f2087c98 | 99844692ee805d18d5ee7fd9c62f14d2dffa2e06 | chrome | bigvul | 1 | null | null | null |
Whitespace!
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/652127
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39740 0039d316-1c4b-4281-b951-d872f2087c98 | 0d042152a8807390262609f20c04ba26773f1d7c | chrome | bigvul | 1 | null | null | null |
Revert of Add accelerated VP9 decode infrastructure and an implementation for VA-API. (patchset #7 id:260001 of https://codereview.chromium.org/1318863003/ )
Reason for revert:
I think this patch broke compile step for Chromium Linux ChromeOS MSan Builder.
First failing build:
http://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20Linux%20ChromeOS%20MSan%20Builder/builds/8310
All recent builds:
http://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20Linux%20ChromeOS%20MSan%20Builder?numbuilds=200
Sorry for the revert. I'll re-revert if I'm wrong.
Cheers,
Tommy
Original issue's description:
> Add accelerated VP9 decode infrastructure and an implementation for VA-API.
>
> - Add a hardware/platform-independent VP9Decoder class and related
> infrastructure, implementing AcceleratedVideoDecoder interface. VP9Decoder
> performs the initial stages of the decode process, which are to be done
> on host/in software, such as stream parsing and reference frame management.
>
> - Add a VP9Accelerator interface, used by the VP9Decoder to offload the
> remaining stages of the decode process to hardware. VP9Accelerator
> implementations are platform-specific.
>
> - Add the first implementation of VP9Accelerator - VaapiVP9Accelerator - and
> integrate it with VaapiVideoDecodeAccelerator, for devices which provide
> hardware VP9 acceleration through VA-API. Hook it up to the new
> infrastructure and VP9Decoder.
>
> - Extend Vp9Parser to provide functionality required by VP9Decoder and
> VP9Accelerator, including superframe parsing, handling of loop filter
> and segmentation initialization, state persistence across frames and
> resetting when needed. Also add code calculating segmentation dequants
> and loop filter levels.
>
> - Update vp9_parser_unittest to the new Vp9Parser interface and flow.
>
> TEST=vp9_parser_unittest,vda_unittest,Chrome VP9 playback
> BUG=chrome-os-partner:41469,chrome-os-partner:41470,chromium:525331
> [email protected]
>
> Committed: https://crrev.com/e3cc0a661b8abfdc74f569940949bc1f336ece40
> Cr-Commit-Position: refs/heads/master@{#349312}
[email protected],[email protected],[email protected],[email protected],[email protected]
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chrome-os-partner:41469,chrome-os-partner:41470,chromium:525331
Review URL: https://codereview.chromium.org/1357513002
Cr-Commit-Position: refs/heads/master@{#349443} | 27c68f543e5eba779902447445dfb05ec3f5bf75 | chrome | bigvul | 1 | null | null | null |
2009-04-04 Simon Fraser <[email protected]>
Reviewed by Cameron Zwarich
https://bugs.webkit.org/show_bug.cgi?id=24648
Ensure that mapPoint(const IntPoint&) calls the FloatPoint
version to avoid infinite recursion.
No test because mapPoint(const IntPoint&) isn't ever called
on Mac, so I can't reproduce.
* platform/graphics/transforms/TransformationMatrix.h:
(WebCore::TransformationMatrix::mapPoint):
git-svn-id: svn://svn.chromium.org/blink/trunk@42228 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | b546794ea10ad806e0c07afcc2948b5a3d4db788 | chrome | bigvul | 1 | null | null | null |
Pick up the new svn:ignore for the WebKit directory.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/462006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33572 0039d316-1c4b-4281-b951-d872f2087c98 | 0152b52ad24a092dc966536e8dd7e334482463a0 | chrome | bigvul | 1 | null | null | null |
Improve handling and testing of reparse points.
BUG=28804
TEST=unit tests.
Review URL: http://codereview.chromium.org/553080
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37286 0039d316-1c4b-4281-b951-d872f2087c98 | 4f1f3d0f03c79ddaace56f067cf28a27f9466b7d | chrome | bigvul | 1 | null | null | null |
Fix passing pointers between processes.
BUG=31880
Review URL: http://codereview.chromium.org/558036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37555 0039d316-1c4b-4281-b951-d872f2087c98 | ea3d1d84be3d6f97bf50e76511c9e26af6895533 | chrome | bigvul | 1 | null | null | null |
Add a CHECK when an object tries to remove itself as an observer from NotificationService but no matching entry is found. This is most likely an object being deleted on the wrong thread, and it'll lead to a crash later.
BUG=25354
Review URL: http://codereview.chromium.org/342091
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30801 0039d316-1c4b-4281-b951-d872f2087c98 | 019c7acc36b8893d060684fb3b5deb6156c92b9e | chrome | bigvul | 1 | null | null | null |
Mark XHTML Mobile Profile and WCSS tests as WONTFIX.
Like WML, we are not planning to support these.
R=japhet
TEST=none
BUG=12254
BUG=12310
Review URL: http://codereview.chromium.org/449057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33445 0039d316-1c4b-4281-b951-d872f2087c98 | fd362c138f65673872b572220aec6b15b09caada | chrome | bigvul | 1 | null | null | null |
2010-02-16 Pavel Feldman <[email protected]>
Reviewed by Timothy Hatcher.
Web Inspector: prefer smooth scrolling to instant highlight.
https://bugs.webkit.org/show_bug.cgi?id=34978
* inspector/front-end/TextViewer.js:
(WebInspector.TextViewer):
(WebInspector.TextViewer.prototype._scroll):
(WebInspector.TextChunk):
(WebInspector.TextChunk.prototype._createRow):
* inspector/front-end/textViewer.css:
git-svn-id: svn://svn.chromium.org/blink/trunk@54871 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | cfe3c199a123acbcfbfca60faa2f4bb9ef45d221 | chrome | bigvul | 1 | null | null | null |
2008-08-13 Jan Michael Alonzo <[email protected]>
Reviewed by Holger Freyther.
http://bugs.webkit.org/show_bug.cgi?id=20318
SharedTimerGtk should use G_PRIORITY_DEFAULT_IDLE for g_idle_add
g_idle_add is the same as g_idle_add_full with a priority of
G_PRIORITY_DEFAULT_IDLE, so we can safely use that.
* platform/gtk/SharedTimerGtk.cpp:
(WebCore::setSharedTimerFireTime):
git-svn-id: svn://svn.chromium.org/blink/trunk@35724 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | 482628d8157ded5d6124bcf39c8b5afc7906f72d | chrome | bigvul | 1 | null | null | null |
Mac bookmark mgr: Fix crash after closing incognito window.
BUG=32594
TEST=none (see steps to reproduce)
Review URL: http://codereview.chromium.org/554034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36772 0039d316-1c4b-4281-b951-d872f2087c98 | 811cb260aea2b6edea92e3b900945b55570c75d4 | chrome | bigvul | 1 | null | null | null |
Handle CreateFile() trimming trailing dots and spaces in downloads.
BUG=37007
TEST=unit_tests --gtest_filter=DownloadManagerTest.*
Review URL: http://codereview.chromium.org/660297
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40479 0039d316-1c4b-4281-b951-d872f2087c98 | 223c449d19eb5d889bc828e011c1a23e5d52b4c9 | chrome | bigvul | 1 | null | null | null |
Adds a LayoutTest exclusion to cover differences between GURL and KURL.
Committing on behalf of [email protected]
BUG=37383
TEST=None
[email protected]
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41247 0039d316-1c4b-4281-b951-d872f2087c98 | fece3c739d5a17ab0ad08cc0bdd1e7ddb88b645d | chrome | bigvul | 1 | null | null | null |
Revert 37061 because it caused ui_tests to not finish.
TBR=estade
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/549155
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37075 0039d316-1c4b-4281-b951-d872f2087c98 | 4afa45dfbf11e9334e63aef002cd854ec86f6d44 | chrome | bigvul | 1 | null | null | null |
Bug #: 3275
Submitted by: eseidel
Reviewed by: darin
Test cases for the new XSLTProcessor JS object.
http://bugzilla.opendarwin.org/show_bug.cgi?id=3275
* fast/xsl/xslt-processer-expected.txt: Added.
* fast/xsl/xslt-processer.html: Added.
git-svn-id: svn://svn.chromium.org/blink/trunk@10990 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | ccb43fba0a97c3f5c5f0c1cdaa4662e21555988e | chrome | bigvul | 1 | null | null | null |
Clipboard: Opt out of PNG Encoding filters.
Set the PNG encoder's FilterFlag to kNone from the default kAll.
The clipboard should prefer faster encode time over encode size for image/png,
so set all clipboard image decoding to skip testing of different PNG encoding
filters, which takes a lot of time for not too much compression ratio benefit
in the common case.
Benchmarking with a random-pixel 8k by 4k px image
(https://www.photopea.com/clipboard_img.html), and fZLibLevel = 1, here's some
encode times (seconds) varying flags:
* kNone: 2.98 (trials: 3.00814, 2.98265, 2.99636, 2.9877, 2.96517, 2.99467)
* kSub: 3.03 (trials: 3.02345, 3.04085, 3.00886, 3.0587, 3.03992, 3.02549)
* kAll: 4.12 (trials: 4.12813, 4.12552, 4.08524, 4.13283, 4.15013, 4.11719)
Using kNone would save ~28% encode time over the current kAll.
This will be most visible for pasting of extremely large photos.
Bug: 1004867
Change-Id: I37a848498da425249e57171ae2ca3f0595c6b793
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827953
Commit-Queue: Victor Costan <[email protected]>
Reviewed-by: Victor Costan <[email protected]>
Cr-Commit-Position: refs/heads/master@{#700598} | 123e68f88fd0ed4f7447ba81148f9b619b947c47 | chrome | bigvul | 1 | null | null | null |
[auto] Update FlagExpectations for LayoutNG
Following bot results are included.
12523 12525 12526 12529 12532 12534 12551 12558 12562 12564
12566 12567 12570 12572 12575 12577 12578 12580 12582 12586
12589 12595 12598 12600
5 lines were removed and 3 lines were deflaked by consecutive
results since 12570.
[email protected], [email protected]
NOTRY=true
Bug: 591099
Change-Id: I44bb98fb69c27bad4a647ee547376ca06a2ca4e2
Reviewed-on: https://chromium-review.googlesource.com/c/1369493
Reviewed-by: Koji Ishii <[email protected]>
Commit-Queue: Koji Ishii <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616227} | 40a1942612b58076e3e367028a45d7c6d1e58f27 | chrome | bigvul | 1 | null | null | null |
Remove unexpected pass.
TEST=none
BUG=20450,20458
TBR=abarth
Review URL: http://codereview.chromium.org/434113
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33207 0039d316-1c4b-4281-b951-d872f2087c98 | c0fbaed2be9b4df04c8cc9fe3f5c1c41b3459ca0 | chrome | bigvul | 1 | null | null | null |
Replaces the % character with \x when generating Windows shortcuts via
File->"Create application shortcuts." The \x is converted back to % in
handling the --app switch.
BUG=23693
TEST=None
Review URL: http://codereview.chromium.org/515028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35377 0039d316-1c4b-4281-b951-d872f2087c98 | 790613cb3725005dda8f7fbfaa344a9e99a8f2a8 | chrome | bigvul | 1 | null | null | null |
Fixed crash related to cellular network payment plan retreival.
BUG=chromium-os:8864
TEST=none
Review URL: http://codereview.chromium.org/4690002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65405 0039d316-1c4b-4281-b951-d872f2087c98 | a3e2afaedd8190398ae45ccef34fcdee00fb19aa | chrome | bigvul | 1 | null | null | null |
Linux: Update strings for title case and remove some old strings.
BUG=24701
TEST=ran chrome and looked at the strings
Review URL: http://codereview.chromium.org/366016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31059 0039d316-1c4b-4281-b951-d872f2087c98 | 0ee2a15265896f5206cff63b613297331e4b6c92 | chrome | bigvul | 1 | null | null | null |
New baselines for tests broken by Skia "USE_NEW_BUILDER" flag (SkEdgeBuilder).
BUG=24646
TEST=none
TBR=dglazkov
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33873 0039d316-1c4b-4281-b951-d872f2087c98 | 833c10ef55110071560afc67efc5e32ed1884e24 | chrome | bigvul | 1 | null | null | null |
Suppress two data races in Chromium and a couple of races in libc
BUG=24419,24307
TBR=dank
Review URL: http://codereview.chromium.org/267038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28566 0039d316-1c4b-4281-b951-d872f2087c98 | 9068747c5591866480bd0888e571cc548d6be546 | chrome | bigvul | 1 | null | null | null |
Remove layout tests passing because of r34751.
BUG=29920
TEST=LayoutTests/http/tests/ssl
Review URL: http://codereview.chromium.org/502038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34763 0039d316-1c4b-4281-b951-d872f2087c98 | f8bc33be983c60bdd7de7a34fc76cc7ddd2f7dfd | chrome | bigvul | 1 | null | null | null |
Change notification cmd line enabling to use the new RuntimeEnabledFeatures code.
BUG=25318
TEST=none
Review URL: http://codereview.chromium.org/339093
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30660 0039d316-1c4b-4281-b951-d872f2087c98 | bfa69d49b17f33635c79f79819b90a8d2089c4b3 | chrome | bigvul | 1 | null | null | null |
2008-03-25 Antti Koivisto <[email protected]>
Reviewed by Oliver.
Fix http://bugs.webkit.org/show_bug.cgi?id=18082
REGRESSION (r31287): GMail does not work if user stylesheet is set
Oops, my cache refactoring patch was missing these rather essential lines for
user stylesheets. They would get reloaded repeatedly.
* loader/Cache.cpp:
(WebCore::Cache::requestUserCSSStyleSheet):
git-svn-id: svn://svn.chromium.org/blink/trunk@31307 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | 8d4d589fc7d0a8f2fbb7a468e00f264fe54c7981 | chrome | bigvul | 1 | null | null | null |
Avoid excessive nesting / recursion in browser URL handling.
BUG=31517
TEST=ChildProcessSecurityPolicyTest
Review URL: http://codereview.chromium.org/525038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35585 0039d316-1c4b-4281-b951-d872f2087c98 | 690d0a9175790c4bd3abd066932bc08203c164ca | chrome | bigvul | 1 | null | null | null |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.