commit_msg
stringlengths 1
24.2k
| commit_hash
stringlengths 2
84
⌀ | project
stringlengths 2
40
| source
stringclasses 4
values | labels
int64 0
1
| repo_url
stringlengths 26
70
⌀ | commit_url
stringlengths 74
118
⌀ | commit_date
stringlengths 25
25
⌀ |
|---|---|---|---|---|---|---|---|
Automated Commit: LKGM 12303.0.0 for chromeos.
BUG=762641
[email protected]
Change-Id: Ia89e7c1d11f0a25b6b94d12874a227c6e75873eb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1681362
Reviewed-by: ChromeOS bot <[email protected]>
Commit-Queue: ChromeOS bot <[email protected]>
Cr-Commit-Position: refs/heads/master@{#673264} | 7089634d0ce8f35d7064f38fc6fa8ee048c09908 | chrome | bigvul | 1 | null | null | null |
[filemanager] Open Downloads by default (instead of removable device).
BUG=chromium-os:29914
TEST=manual
Review URL: https://chromiumcodereview.appspot.com/10198010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133674 0039d316-1c4b-4281-b951-d872f2087c98 | cabe64c886b7caba6caa67ca4b4ac7e026431292 | chrome | bigvul | 1 | null | null | null |
GTK: Fix a couple minor popup window icon menu bugs.
BUG=26265,26268
Review URL: http://codereview.chromium.org/360023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31009 0039d316-1c4b-4281-b951-d872f2087c98 | 3290c948762c47292fb388de8318859ee22b6688 | chrome | bigvul | 1 | null | null | null |
Revert "Move assistant icon animation to CompositorAnimationOberver"
This reverts commit 33fc6c64a3b5af5627b7e28874f4583793e74da8.
Reason for revert: One or the other of this CL and https://crrev.com/c/748268 (perhaps both in combination?) broke PaletteTrayTestWithVoiceInteraction.StylusBarrelButtonActivatesHighlighter on Linux ChromiumOS Tests (dbg)(1):
https://uberchromegw.corp.google.com/i/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/31692
The connection to these voice interaction Cls seems pretty clear. I can't identify which one it is, though, so while I apologize for the trouble, I'm going to revert both to ensure that the bot turns green again.
Original change's description:
> Move assistant icon animation to CompositorAnimationOberver
>
> BUG=None
> TEST=locally build and see animation running as before.
>
> Change-Id: I1eb62490108beaaec0795adb4251054c03b364e1
> Reviewed-on: https://chromium-review.googlesource.com/748273
> Commit-Queue: Xiaohui Chen <[email protected]>
> Reviewed-by: Xiyuan Xia <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#513211}
[email protected],[email protected]
Change-Id: I5ef677c189808601f8e357f56a171bf920b10fa0
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: None
Reviewed-on: https://chromium-review.googlesource.com/749851
Reviewed-by: Justin Donnelly <[email protected]>
Commit-Queue: Justin Donnelly <[email protected]>
Cr-Commit-Position: refs/heads/master@{#513272} | 4698aea3e347d67c817d7acebd16054b9f763cfb | chrome | bigvul | 1 | null | null | null |
2010-06-18 Adam Barth <[email protected]>
Reviewed by Darin Adler.
noAccess url schemes block access to inline stylesheets
https://bugs.webkit.org/show_bug.cgi?id=32309
Test that data URLs can access their inline style sheets.
* http/tests/security/data-url-inline.css-expected.txt: Added.
* http/tests/security/data-url-inline.css.html: Added.
2010-06-18 Adam Barth <[email protected]>
Reviewed by Darin Adler.
noAccess url schemes block access to inline stylesheets
https://bugs.webkit.org/show_bug.cgi?id=32309
Instead of using baseURL() to grab the security context we should just
use finalURL directly. When I wrote the original patch that added this
security check, finalURL didn't exist yet.
If finalURL is an empty URL, that means we generated the style sheet
from text that didn't have a URL. It would be slightly safer to store
a bit on CSSStyleSheet indicating whether it came from an inline style
sheet, but I think this check is fairly accurate.
Test: http/tests/security/data-url-inline.css.html
* css/CSSStyleSheet.cpp:
(WebCore::CSSStyleSheet::cssRules):
git-svn-id: svn://svn.chromium.org/blink/trunk@61391 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | 3eb1f512d8646db3a70aaef108a8f5ad8b3f013d | chrome | bigvul | 1 | null | null | null |
WebKit Roll 51237:51253
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/414061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32718 0039d316-1c4b-4281-b951-d872f2087c98 | f2ce17e755566334a1ec5cd06d9df1ba50319df6 | chrome | bigvul | 1 | null | null | null |
Fix integer overflow in sbox
BUG=32915
TEST= unit test included
Review URL: http://codereview.chromium.org/553061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36923 0039d316-1c4b-4281-b951-d872f2087c98 | e9b676190a37d4f1f57cc6b9f2f3bad634449101 | chrome | bigvul | 1 | null | null | null |
Merge icu_46 suppressions for bug 84304 with those for bug 81753
BUG=81753,84304
TBR=glider
Review URL: http://codereview.chromium.org/7492067
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94448 0039d316-1c4b-4281-b951-d872f2087c98 | de66aac8b69c5e9f97905efb662557cfafb9b570 | chrome | bigvul | 1 | null | null | null |
Text Autosizing: Counteract funky window sizing on Android.
https://bugs.webkit.org/show_bug.cgi?id=98809
Reviewed by Adam Barth.
In Chrome for Android, the window sizes provided to WebCore are
currently in physical screen pixels instead of
device-scale-adjusted units. For example window width on a
Galaxy Nexus is 720 instead of 360. Text autosizing expects
device-independent pixels. When Chrome for Android cuts over to
the new coordinate space, it will be tied to the setting
applyPageScaleFactorInCompositor.
No new tests.
* rendering/TextAutosizer.cpp:
(WebCore::TextAutosizer::processSubtree):
git-svn-id: svn://svn.chromium.org/blink/trunk@130866 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | 60c9d8a39e4aa78dd51c236bd1b2c4f17c9d27fe | chrome | bigvul | 1 | null | null | null |
Fix memory error in previous CL.
BUG=100315
BUG=99016
TEST=Memory bots go green
Review URL: http://codereview.chromium.org/8302001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105577 0039d316-1c4b-4281-b951-d872f2087c98 | ff4330a2ca6bf69d24f9f9fb6f12dc81387b205a | chrome | bigvul | 1 | null | null | null |
Layout Test inspector/extensions/extensions-events.html is timing out
https://bugs.webkit.org/show_bug.cgi?id=72966
Unreviewed gardening.
* platform/chromium/test_expectations.txt:
git-svn-id: svn://svn.chromium.org/blink/trunk@101010 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | 0a897162894ccac0dcbdcdd8b510e3df71c4a4dc | chrome | bigvul | 1 | null | null | null |
Linux: Fix crash reporting for GPU and plugin processes.
BUG=96631
TEST=none
Review URL: http://codereview.chromium.org/7931005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101779 0039d316-1c4b-4281-b951-d872f2087c98 | 499f6a610abcf6a057cbb8324f90a07d89f59431 | chrome | bigvul | 1 | null | null | null |
Update v8-i18n project to r7 to fix a stable blocker.
Fix to v8-i18n was submitted in http://codereview.chromium.org/8570009
BUG=104011
TEST=Load crash1.html from bug report and check it doesn't crash browser.
Review URL: http://codereview.chromium.org/8573014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110195 0039d316-1c4b-4281-b951-d872f2087c98 | 9a1a5faa13f9054830f94cc0cd15d4dd5122a76f | chrome | bigvul | 1 | null | null | null |
[Qt] Builds for Mac are tied to the OS system instead of the SDK version.
https://bugs.webkit.org/show_bug.cgi?id=104529
Reviewed by Simon Hausmann.
Using work by Eike Ziller <[email protected]>.
The build system now first tries to assign the correct system libraries
for the SDK being used for Mac builds. If this does not yield any
result, it falls back to using the Mac OS version to determine the
correct library.
No new tests (not applicable).
* WebCore.pri:
git-svn-id: svn://svn.chromium.org/blink/trunk@137139 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | 2156ea103b778a64228413a5bf304e18b741a2f6 | chrome | bigvul | 1 | null | null | null |
Unreviewed, build fix for unused argument warning after r104954.
https://bugs.webkit.org/show_bug.cgi?id=75906
Also fixed up somebody's bad merge in Source/WebCore/ChangeLog.
* html/canvas/WebGLObject.cpp:
(WebCore::WebGLObject::WebGLObject):
git-svn-id: svn://svn.chromium.org/blink/trunk@104959 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | 7d8cefdf6d0e457b7a855c9503684f1058c2a356 | chrome | bigvul | 1 | null | null | null |
Omnibox should be focused on new blank tab creation through AppleScript
BUG=98382
TEST=
Review URL: http://codereview.chromium.org/8133004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107258 0039d316-1c4b-4281-b951-d872f2087c98 | f898d7f8a69faf58b2f8b2077cfaf528050c174d | chrome | bigvul | 1 | null | null | null |
Desist libxml from continuing the parse after a SAX callback has stopped the
parse.
Attempt 2 -- now with less compile fail on Mac / Clang.
BUG=95465
TBR=cdn
TEST=covered by existing tests under ASAN
Review URL: http://codereview.chromium.org/7892003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100953 0039d316-1c4b-4281-b951-d872f2087c98 | 44a637b47793512bfb1d2589d43b8dc492a97629 | chrome | bigvul | 1 | null | null | null |
Don't interpret embeded NULLs in a response header line as a line terminator.
BUG=95992
Review URL: http://codereview.chromium.org/7796025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100863 0039d316-1c4b-4281-b951-d872f2087c98 | 2bcaf4649c1d495072967ea454e8c16dce044705 | chrome | bigvul | 1 | null | null | null |
Coverity; Fixing pass by value bugs.
CID=101466, 101464, 101494, 101495, 101496, 101497
BUG=NONE
TEST=NONE
Review URL: http://codereview.chromium.org/8956046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115399 0039d316-1c4b-4281-b951-d872f2087c98 | 283fb25624bf253d120708152e23cf9143519198 | chrome | bigvul | 1 | null | null | null |
Define DEBUG_GL_COMMANDS only in debug builds.
https://bugs.webkit.org/show_bug.cgi?id=74083
Reviewed by Noam Rosenthal.
No tests added as this change does not affect functionality.
* platform/graphics/opengl/TextureMapperGL.cpp:
git-svn-id: svn://svn.chromium.org/blink/trunk@102359 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | a1f6ba4c1c488be710013f8548ff5513b32a7f3b | chrome | bigvul | 1 | null | null | null |
Retrieve per host storage usage from QuotaManager.
[email protected]
BUG=none
TEST=QuotaManagerTest.GetUsage
Review URL: http://codereview.chromium.org/8079004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103921 0039d316-1c4b-4281-b951-d872f2087c98 | 610f904d8215075c4681be4eb413f4348860bf9f | chrome | bigvul | 1 | null | null | null |
Add CHECKs for file descriptors used in select() by InotifyReaderTask
Since these are used in an fd_set, there's the possibility that invalid file descriptors cause stack overflow/corruption.
BUG=chromium:105162
TEST=No functional changes, compiles and passes tests.
Review URL: http://codereview.chromium.org/8681006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111369 0039d316-1c4b-4281-b951-d872f2087c98 | 77b498aa18e610ed8ac3863ae048573d4f943b16 | chrome | bigvul | 1 | null | null | null |
[chromium] Mark unreachable-overflow-rtl-bug as failing after r103245.
https://bugs.webkit.org/show_bug.cgi?id=74881
Unreviewed gardening.
Also, make expectation file pass linting.
* platform/chromium/test_expectations.txt:
git-svn-id: svn://svn.chromium.org/blink/trunk@103259 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | f69d936b6d5de4f7eae7a305fbdd7a5bf8145992 | chrome | bigvul | 1 | null | null | null |
Revert 102184 - [Sync] use base::Time in sync
Make EntryKernel/Entry/BaseNode use base::Time instead of int64s.
Add sync/util/time.h, with utility functions to manage the sync proto
time format.
Store times on disk in proto format instead of the local system.
This requires a database version bump (to 77).
Update SessionChangeProcessor/SessionModelAssociator
to use base::Time, too.
Remove hackish Now() function.
Remove ZeroFields() function, and instead zero-initialize in EntryKernel::EntryKernel() directly.
BUG=
TEST=
Review URL: http://codereview.chromium.org/7981006
[email protected]
Review URL: http://codereview.chromium.org/7977034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102186 0039d316-1c4b-4281-b951-d872f2087c98 | 19190765882e272a6a2162c89acdb29110f7e3cf | chrome | bigvul | 1 | null | null | null |
Fix print media page size by using the value we compute.
BUG=82472
TEST=NONE (in bug)
Review URL: http://codereview.chromium.org/8344016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106160 0039d316-1c4b-4281-b951-d872f2087c98 | f1a142d29ad1dfaecd3b609051b476440289ec72 | chrome | bigvul | 1 | null | null | null |
Widen suppressionfor 64887
[email protected]
BUG=64887
TEST=none
Review URL: http://codereview.chromium.org/7982036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102154 0039d316-1c4b-4281-b951-d872f2087c98 | e6a4d78c70426f6bce0558fca79b0a38ea12070f | chrome | bigvul | 1 | null | null | null |
More testing for Graphics3D
BUG= none
TEST= ppapi_ppb_graphics3d
Review URL: http://codereview.chromium.org/7888028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101555 0039d316-1c4b-4281-b951-d872f2087c98 | c96312d46205ea82764aba6255ecbb8dd5f57d11 | chrome | bigvul | 1 | null | null | null |
Rolling FFmpeg to r107500.
BUG=101172,100465
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107508 0039d316-1c4b-4281-b951-d872f2087c98 | dc4e69124b214f7f31a08ad4a2fed0e8fd75669d | chrome | bigvul | 1 | null | null | null |
Implement a bubble that appears at the top of the screen when a tab enters
fullscreen mode via webkitRequestFullScreen(), telling the user how to exit
fullscreen.
This is implemented as an NSView rather than an NSWindow because the floating
chrome that appears in presentation mode should overlap the bubble.
Content-initiated fullscreen mode makes use of 'presentation mode' on the Mac:
the mode in which the UI is hidden, accessible by moving the cursor to the top
of the screen. On Snow Leopard, this mode is synonymous with fullscreen mode.
On Lion, however, fullscreen mode does not imply presentation mode: in
non-presentation fullscreen mode, the chrome is permanently shown. It is
possible to switch between presentation mode and fullscreen mode using the
presentation mode UI control.
When a tab initiates fullscreen mode on Lion, we enter presentation mode if not
in presentation mode already. When the user exits fullscreen mode using Chrome
UI (i.e. keyboard shortcuts, menu items, buttons, switching tabs, etc.) we
return the user to the mode they were in before the tab entered fullscreen.
BUG=14471
TEST=Enter fullscreen mode using webkitRequestFullScreen. You should see a bubble pop down from the top of the screen.
Need to test the Lion logic somehow, with no Lion trybots.
BUG=96883
Original review http://codereview.chromium.org/7890056/
TBR=thakis
Review URL: http://codereview.chromium.org/7920024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101624 0039d316-1c4b-4281-b951-d872f2087c98 | 5925dff83699508b5e2735afb0297dfb310e159d | chrome | bigvul | 1 | null | null | null |
Fix print preview workflow to reflect settings of selected printer.
BUG=95110
TEST=none
Review URL: http://codereview.chromium.org/7831041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102242 0039d316-1c4b-4281-b951-d872f2087c98 | c7a90019bf7054145b11d2577b851cf2779d3d79 | chrome | bigvul | 1 | null | null | null |
Fix memory leak in webRequest API in case of invalid parameters
BUG=CID 102461
TEST=no
Review URL: http://codereview.chromium.org/8681004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111780 0039d316-1c4b-4281-b951-d872f2087c98 | d705f79135a19909773c6c080001639ba5d833c9 | chrome | bigvul | 1 | null | null | null |
[Qt] Remove QOpenGL specific code from GraphicsSurfaceGLX.
https://bugs.webkit.org/show_bug.cgi?id=100492
This patch removes most of the QOpenGLContext related code
from GraphicsSurfaceGLX. This allows sharing almost all
GraphicsSurfaceGLX code with EFL, by relying on pure GLX.
Patch by Zeno Albisser <[email protected]> on 2012-10-26
Reviewed by Kenneth Rohde Christiansen.
* platform/graphics/surfaces/qt/GraphicsSurfaceGLX.cpp:
(WebCore::OffScreenRootWindow::get):
(WebCore::OffScreenRootWindow::~OffScreenRootWindow):
(OffScreenRootWindow):
(WebCore):
(WebCore::GraphicsSurfacePrivate::GraphicsSurfacePrivate):
(WebCore::GraphicsSurfacePrivate::createSurface):
(WebCore::GraphicsSurfacePrivate::makeCurrent):
(WebCore::GraphicsSurfacePrivate::doneCurrent):
(WebCore::GraphicsSurfacePrivate::swapBuffers):
(WebCore::GraphicsSurfacePrivate::copyFromTexture):
(GraphicsSurfacePrivate):
(WebCore::resolveGLMethods):
git-svn-id: svn://svn.chromium.org/blink/trunk@132628 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | 4da7eefcaad044a6f919947a2a0e3d4fed87834c | chrome | bigvul | 1 | null | null | null |
sync: ensure sync init path doesn't block on CheckTime
The call to RequestEarlyExit (which calls Abort) only happens if the SyncBackendHost has received the initialization callback from the SyncManager. But during init, the SyncManager could make a call to CheckTime, meaning that call would never be aborted. This patch makes sure to cover that case.
BUG=93829
TEST=None at the moment :(
Review URL: http://codereview.chromium.org/7862011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100543 0039d316-1c4b-4281-b951-d872f2087c98 | 3b7ff00418c0e7593d42e5648ba39397e23fe2f9 | chrome | bigvul | 1 | null | null | null |
Coverity: Fixing pass by value.
CID=101462, 101458, 101437, 101471, 101467
BUG=NONE
TEST=NONE
Review URL: http://codereview.chromium.org/9006023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115257 0039d316-1c4b-4281-b951-d872f2087c98 | 9d02cda7a634fbd6e53d98091f618057f0174387 | chrome | bigvul | 1 | null | null | null |
Add myself to the committers list
https://bugs.webkit.org/show_bug.cgi?id=66941
Reviewed by Andreas Kling.
* Scripts/webkitpy/common/config/committers.py:
git-svn-id: svn://svn.chromium.org/blink/trunk@93788 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | 2f6a44ffa146a1e3408a60395531bba76c8e2154 | chrome | bigvul | 1 | null | null | null |
[WK2] LayerTreeCoordinator should release unused UpdatedAtlases
https://bugs.webkit.org/show_bug.cgi?id=95072
Reviewed by Jocelyn Turcotte.
Release graphic buffers that haven't been used for a while in order to save memory.
This way we can give back memory to the system when no user interaction happens
after a period of time, for example when we are in the background.
* Shared/ShareableBitmap.h:
* WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp:
(WebKit::LayerTreeCoordinator::LayerTreeCoordinator):
(WebKit::LayerTreeCoordinator::beginContentUpdate):
(WebKit):
(WebKit::LayerTreeCoordinator::scheduleReleaseInactiveAtlases):
(WebKit::LayerTreeCoordinator::releaseInactiveAtlasesTimerFired):
* WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.h:
(LayerTreeCoordinator):
* WebProcess/WebPage/UpdateAtlas.cpp:
(WebKit::UpdateAtlas::UpdateAtlas):
(WebKit::UpdateAtlas::didSwapBuffers):
Don't call buildLayoutIfNeeded here. It's enought to call it in beginPaintingOnAvailableBuffer
and this way we can track whether this atlas is used with m_areaAllocator.
(WebKit::UpdateAtlas::beginPaintingOnAvailableBuffer):
* WebProcess/WebPage/UpdateAtlas.h:
(WebKit::UpdateAtlas::addTimeInactive):
(WebKit::UpdateAtlas::isInactive):
(WebKit::UpdateAtlas::isInUse):
(UpdateAtlas):
git-svn-id: svn://svn.chromium.org/blink/trunk@128473 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | d31f450c723ba46b53c1762e51188557447d85fd | chrome | bigvul | 1 | null | null | null |
Roll skia 2034->2051.
Whitespace change: http://codereview.chromium.org/7576017
BUG=NONE
TEST=NONE
Review URL: http://codereview.chromium.org/7575020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95671 0039d316-1c4b-4281-b951-d872f2087c98 | b844a4c59562f28e4ae52d14565b4b6b4fbfccb0 | chrome | bigvul | 1 | null | null | null |
[CSS Shaders] WebKitCSSMixFunctionValue.h needs forward declaration of MemoryObjectInfo
https://bugs.webkit.org/show_bug.cgi?id=96150
Reviewed by George Staikos.
Otherwise files that include it may fail to compile.
No new tests, because this patch implements no new functionality.
* css/WebKitCSSMixFunctionValue.h:
(WebCore):
git-svn-id: svn://svn.chromium.org/blink/trunk@127929 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | f698ce8f7637d75d1816277d5938df8cdb4224d7 | chrome | bigvul | 1 | null | null | null |
Fix a small leak in FileUtilProxy
BUG=none
TEST=green mem bots
Review URL: http://codereview.chromium.org/7669046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97451 0039d316-1c4b-4281-b951-d872f2087c98 | 4c19b042ea31bd393d2265656f94339d1c3d82ff | chrome | bigvul | 1 | null | null | null |
WKProcessGroup can't load injected bundle with file URL
<rdar://problem/12322774>
https://bugs.webkit.org/show_bug.cgi?id=97520
Reviewed by Anders Carlsson.
* UIProcess/API/mac/WKProcessGroup.mm:
(-[WKProcessGroup initWithInjectedBundleURL:]):
Fix typo. We need to pass the string as path, not as a URL.
git-svn-id: svn://svn.chromium.org/blink/trunk@129454 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | dd30287c430063a5ebb4ec5a1dbdac82a9404aab | chrome | bigvul | 1 | null | null | null |
Reset the device policy machinery upon retrying enrollment.
BUG=chromium-os:18208
TEST=See bug description
Review URL: http://codereview.chromium.org/7676005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97615 0039d316-1c4b-4281-b951-d872f2087c98 | 244c78b3f737f2cacab2d212801b0524cbcc3a7b | chrome | bigvul | 1 | null | null | null |
[chromium] Fix shutdown race when posting main thread task to CCThreadProxy and enable tests
https://bugs.webkit.org/show_bug.cgi?id=70161
Reviewed by David Levin.
Source/WebCore:
Adds a weak pointer mechanism to cancel main thread tasks posted to CCThreadProxy instances from the compositor
thread. Previously there was a race condition where main thread tasks could run even after the CCThreadProxy was
destroyed.
This race does not exist in the other direction because when tearing down a CCThreadProxy we first post a quit
task to the compositor thread and then suspend execution of the main thread until all compositor tasks for the
CCThreadProxy have been drained.
Covered by the now-enabled CCLayerTreeHostTest* unit tests.
* WebCore.gypi:
* platform/graphics/chromium/cc/CCScopedMainThreadProxy.h: Added.
(WebCore::CCScopedMainThreadProxy::create):
(WebCore::CCScopedMainThreadProxy::postTask):
(WebCore::CCScopedMainThreadProxy::shutdown):
(WebCore::CCScopedMainThreadProxy::CCScopedMainThreadProxy):
(WebCore::CCScopedMainThreadProxy::runTaskIfNotShutdown):
* platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::CCThreadProxy):
(WebCore::CCThreadProxy::~CCThreadProxy):
(WebCore::CCThreadProxy::createBeginFrameAndCommitTaskOnCCThread):
* platform/graphics/chromium/cc/CCThreadProxy.h:
Source/WebKit/chromium:
Enables the CCLayerTreeHostTest* tests by default. Most tests are run twice in a single thread and multiple
thread configuration. Some tests run only in the multiple thread configuration if they depend on the compositor
thread scheduling draws by itself.
* tests/CCLayerTreeHostTest.cpp:
(::CCLayerTreeHostTest::timeout):
(::CCLayerTreeHostTest::clearTimeout):
(::CCLayerTreeHostTest::CCLayerTreeHostTest):
(::CCLayerTreeHostTest::onEndTest):
(::CCLayerTreeHostTest::TimeoutTask::TimeoutTask):
(::CCLayerTreeHostTest::TimeoutTask::clearTest):
(::CCLayerTreeHostTest::TimeoutTask::~TimeoutTask):
(::CCLayerTreeHostTest::TimeoutTask::Run):
(::CCLayerTreeHostTest::runTest):
(::CCLayerTreeHostTest::doBeginTest):
(::CCLayerTreeHostTestThreadOnly::runTest):
(::CCLayerTreeHostTestSetNeedsRedraw::commitCompleteOnCCThread):
git-svn-id: svn://svn.chromium.org/blink/trunk@97784 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | 88c4913f11967abfd08a8b22b4423710322ac49b | chrome | bigvul | 1 | null | null | null |
Add missing sys/mman.h include on Mac
https://bugs.webkit.org/show_bug.cgi?id=98089
Patch by Jonathan Liu <[email protected]> on 2013-01-16
Reviewed by Darin Adler.
The madvise function and MADV_FREE constant require sys/mman.h.
* jit/ExecutableAllocatorFixedVMPool.cpp:
git-svn-id: svn://svn.chromium.org/blink/trunk@139926 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | a452fc081f4e81befb97cc911ea2391c61d32926 | chrome | bigvul | 1 | null | null | null |
Disable SSLUITest.TestCNInvalidStickiness, flakily hits an assertion.
TBR=rsleevi
BUG=68448, 49377
TEST=browser_tests
Review URL: http://codereview.chromium.org/6178005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70876 0039d316-1c4b-4281-b951-d872f2087c98 | ebaf26ce325e21df4619ab95cc0399bc88f30d05 | chrome | bigvul | 1 | null | null | null |
Infobar Windows Media Player plug-in by default.
BUG=51464
Review URL: http://codereview.chromium.org/7080048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87500 0039d316-1c4b-4281-b951-d872f2087c98 | d662b905d30cec7899bbb15140dcfacd73506167 | chrome | bigvul | 1 | null | null | null |
linux: enable PIE (ASLR) for chrome executable
I had been concerned that this wouldn't work with our -fPIC
bits we build internally, but the difference is actually a
performance once, not a correctness one.
BUG=57908
Review URL: http://codereview.chromium.org/6973032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85286 0039d316-1c4b-4281-b951-d872f2087c98 | b50d56558b267dc558b1e7ee6ab9db7759e68557 | chrome | bigvul | 1 | null | null | null |
Add some more comments, fixing a TODO.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6523031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75070 0039d316-1c4b-4281-b951-d872f2087c98 | 209673231470b1f6aa6b08fe0dc5602737ec2500 | chrome | bigvul | 1 | null | null | null |
PopupMenuClient::multiple() should be const
https://bugs.webkit.org/show_bug.cgi?id=76771
Patch by Benjamin Poulain <[email protected]> on 2012-01-21
Reviewed by Kent Tamura.
* platform/PopupMenuClient.h:
(WebCore::PopupMenuClient::multiple):
* rendering/RenderMenuList.cpp:
(WebCore::RenderMenuList::multiple):
* rendering/RenderMenuList.h:
git-svn-id: svn://svn.chromium.org/blink/trunk@105570 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | 08b630e66e042af3fe80015509b3238c2679ea40 | chrome | bigvul | 1 | null | null | null |
WebKit roll r78320:78427
BUG=none
TEST=canary
TBR=pkasting
Review URL: http://codereview.chromium.org/6475002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74763 0039d316-1c4b-4281-b951-d872f2087c98 | ccb55cf032cdda2a87d86416c04b82ebc1ee8985 | chrome | bigvul | 1 | null | null | null |
chromeos: fix bug where "aw snap" page replaces first tab if it was a NTP when closing window with > 1 tab.
BUG=chromium-os:12088
TEST=verify bug per bug report.
Review URL: http://codereview.chromium.org/6882058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83031 0039d316-1c4b-4281-b951-d872f2087c98 | 2db5a2048dfcacfe5ad4311c2b1e435c4c67febc | chrome | bigvul | 1 | null | null | null |
2011-02-15 Oliver Hunt <[email protected]>
Fix EFL build for
https://bugs.webkit.org/show_bug.cgi?id=54415
* CMakeLists.txt:
git-svn-id: svn://svn.chromium.org/blink/trunk@78639 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | ac9315fc340d984c52a253eb9658544182323d51 | chrome | bigvul | 1 | null | null | null |
Cleanup: Remove the browser_list.h stub file. Part 3/3.
All the includes to it were already updated.
BUG=None
TEST=None
[email protected]
Review URL: http://codereview.chromium.org/6807001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80680 0039d316-1c4b-4281-b951-d872f2087c98 | f92b18a8e69cf7caf93e8ea99c1be542758eaf20 | chrome | bigvul | 1 | null | null | null |
Don't forget the ffmpeg input buffer padding when allocating a codec's
extradata buffer.
BUG=82438
Review URL: http://codereview.chromium.org/7137002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88354 0039d316-1c4b-4281-b951-d872f2087c98 | d304b5ec1b16766ea2cb552a27dc14df848d6a0e | chrome | bigvul | 1 | null | null | null |
[EFL][WK2] Compile webkit1 and webkit2 by default.
https://bugs.webkit.org/show_bug.cgi?id=85041
Patch by Mariusz Grzegorczyk <[email protected]> on 2012-06-06
Reviewed by Chang Shu.
Compile webkit1 and webkit2 while running Tools/Scripts/build-webkit --efl.
Webkit2 build can be skipped by adding --no-webkit2 option to build-webkit script.
* Scripts/build-webkit:
git-svn-id: svn://svn.chromium.org/blink/trunk@119678 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | f052f14d59c8993525bed59bc3983922cbd42819 | chrome | bigvul | 1 | null | null | null |
Fixed bug preventing disabling the default search provider.
BUG=67180
TEST=Set the "DefaultSearchProviderEnabled" policy to false. Type keywords on the omnibox. No searches should be performed.
Review URL: http://codereview.chromium.org/7150012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89219 0039d316-1c4b-4281-b951-d872f2087c98 | f2b010372b588e349972760985d4d6619d2b950d | chrome | bigvul | 1 | null | null | null |
Update a TSan suppression for the misterious UserScriptMaster race
RunScan was renamed to RunLoad
BUG=67957
TBR=glider
TEST=TSan/UI is more stable
Review URL: http://codereview.chromium.org/7195001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89330 0039d316-1c4b-4281-b951-d872f2087c98 | c32c2265e9bc2408461fc387891c1423f820dcc1 | chrome | bigvul | 1 | null | null | null |
Add master.cfg unittest to help migration - pass BuildStep instances instead of BuildStep subclasses
https://bugs.webkit.org/show_bug.cgi?id=89564
Reviewed by Tony Chang.
* BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
(BuildStepsConstructorTest):
(BuildStepsConstructorTest.generateTests):
(BuildStepsConstructorTest.createTest):
(BuildStepsConstructorTest.createTest.doTest):
git-svn-id: svn://svn.chromium.org/blink/trunk@121328 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | 0d24bc2fd6c95fd79153d93995e2f8a0c77d4b33 | chrome | bigvul | 1 | null | null | null |
Use ScopedRunnableMethodFactory in WebSocketJob
Don't post SendPending if it is already posted.
BUG=89795
TEST=none
Review URL: http://codereview.chromium.org/7488007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93599 0039d316-1c4b-4281-b951-d872f2087c98 | 5dc90e57abcc7f0489e7ae09a3e687e9c6f4fad5 | chrome | bigvul | 1 | null | null | null |
Coverity: Add a missing NULL check.
BUG=none
TEST=none
CID=16813
Review URL: http://codereview.chromium.org/7216034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89991 0039d316-1c4b-4281-b951-d872f2087c98 | 52dac009556881941c60d378e34867cdb2fd00a0 | chrome | bigvul | 1 | null | null | null |
Fixing Coverity bugs (DEAD_CODE and PASS_BY_VALUE)
CIDs 16230, 16439, 16610, 16635
BUG=NONE
TEST=NONE
Review URL: http://codereview.chromium.org/7215029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90134 0039d316-1c4b-4281-b951-d872f2087c98 | 87c724d81f0210494211cd36814c4cb2cf4c4bd1 | chrome | bigvul | 1 | null | null | null |
Add check for zero-sized source YUV + tests.
Took the time to clean up said tests for improved coverage.
BUG=90173
TEST=media_unittests
Review URL: http://codereview.chromium.org/7794016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99113 0039d316-1c4b-4281-b951-d872f2087c98 | 7155d7caafd2aa1fb822dc5672c90ea446247e8d | chrome | bigvul | 1 | null | null | null |
Web Inspector: mute the native looks of the selects in the console.
https://bugs.webkit.org/show_bug.cgi?id=91120
Reviewed by Vsevolod Vlasov.
This is necessary for Mac now that we don't use border images for select.
* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView.prototype.get statusBarItems):
(WebInspector.ConsoleView.prototype.addContext):
(WebInspector.ConsoleView.prototype.removeContext):
(WebInspector.ConsoleView.prototype._updateIsolatedWorldSelector):
(WebInspector.ConsoleView.prototype._appendIsolatedContextOption):
(WebInspector.ConsoleView.prototype._currentEvaluationContext):
(WebInspector.ConsoleView.prototype._currentIsolatedContextId):
* inspector/front-end/StatusBarButton.js:
(WebInspector.StatusBarComboBox):
(WebInspector.StatusBarComboBox.prototype.addOption):
(WebInspector.StatusBarComboBox.prototype.removeOption):
(WebInspector.StatusBarComboBox.prototype.removeOptions):
(WebInspector.StatusBarComboBox.prototype.selectedOption):
* inspector/front-end/inspector.css:
(.status-bar-select-container):
(select.status-bar-item):
(.console-context):
git-svn-id: svn://svn.chromium.org/blink/trunk@122557 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | e2ecf8b6e9daa6d4082f2b4f4c1454dbd70605cc | chrome | bigvul | 1 | null | null | null |
Fixed brekage when PureViews are enable but Desktop is not
[email protected]
BUG=none
TEST=chrome starts with --use-pure-views with touchui
Review URL: http://codereview.chromium.org/7210037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91197 0039d316-1c4b-4281-b951-d872f2087c98 | d82e91c46938520466e9d7c695e0bc638fc70970 | chrome | bigvul | 1 | null | null | null |
Workaround for bad driver issue with NVIDIA GeForce 7300 GT on Mac 10.5.
BUG=87283
TEST=Run on a machine with NVIDIA GeForce 7300 GT on Mac 10.5 immediately after booting.
Review URL: http://codereview.chromium.org/7373018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92651 0039d316-1c4b-4281-b951-d872f2087c98 | 108a923ac784e62ca84b45cb6241f77a942e233a | chrome | bigvul | 1 | null | null | null |
Remove DocumentWriter::setDecoder as a grep of WebKit shows no callers
https://bugs.webkit.org/show_bug.cgi?id=67803
Reviewed by Adam Barth.
Smells like dead code.
* loader/DocumentWriter.cpp:
* loader/DocumentWriter.h:
git-svn-id: svn://svn.chromium.org/blink/trunk@94800 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | 061ddbae1ee31476b57ea44a953970ab2fe8aca1 | chrome | bigvul | 1 | null | null | null |
WebKit Roll 92903:92959
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7629013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96552 0039d316-1c4b-4281-b951-d872f2087c98 | b432c14786a4b50a1bf9b77a30af2a36cde59428 | chrome | bigvul | 1 | null | null | null |
Fix _path_to_apache() error reporting
https://bugs.webkit.org/show_bug.cgi?id=66486
Patch by Tom Zakrajsek <[email protected]> on 2011-08-19
Reviewed by Ryosuke Niwa.
* Scripts/webkitpy/layout_tests/port/webkit.py:
git-svn-id: svn://svn.chromium.org/blink/trunk@93416 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | 249475512632ab5f41c2a55aa40865f4666671a7 | chrome | bigvul | 1 | null | null | null |
Track -webkit property usage.
https://bugs.webkit.org/show_bug.cgi?id=93420
Patch by Tab Atkins <[email protected]> on 2012-08-21
Reviewed by Ojan Vafai.
First draft of an attempt to track all usage of -webkit prefixed properties across the web.
This attempt is dumb, but should provide useful data as a first-pass.
I plan to optimize this for better data collection in the future.
No tests added, as this is untestable currently.
It should have zero effect besides histogramming.
* css/CSSParser.cpp:
(WebCore::cssPropertyID):
git-svn-id: svn://svn.chromium.org/blink/trunk@126201 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | b48b22e1a7bae061687a44e13c0dacb02721fc6f | chrome | bigvul | 1 | null | null | null |
Apply libxml fix for undefined namespaces.
BUG=93472
Review URL: http://codereview.chromium.org/7747031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98359 0039d316-1c4b-4281-b951-d872f2087c98 | 3a766e0115e9799db766a88554b9ab12ee5bf2a4 | chrome | bigvul | 1 | null | null | null |
Limit extent of webstore app to just chrome.google.com/webstore.
BUG=93497
TEST=Try installing extensions and apps from the webstore, starting both being
initially logged in, and not.
Review URL: http://codereview.chromium.org/7719003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97986 0039d316-1c4b-4281-b951-d872f2087c98 | 454434f6100cb6a529652a25b5fc181caa7c7f32 | chrome | bigvul | 1 | null | null | null |
https://bugs.webkit.org/show_bug.cgi?id=93587
Node::replaceChild() can create bad DOM topology with MutationEvent, Part 2
Reviewed by Kent Tamura.
Source/WebCore:
This is a followup of r124156. replaceChild() has yet another hidden
MutationEvent trigger. This change added a guard for it.
Test: fast/events/mutation-during-replace-child-2.html
* dom/ContainerNode.cpp:
(WebCore::ContainerNode::replaceChild):
LayoutTests:
* fast/events/mutation-during-replace-child-2-expected.txt: Added.
* fast/events/mutation-during-replace-child-2.html: Added.
git-svn-id: svn://svn.chromium.org/blink/trunk@125237 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | 6c390601f9ee3436bb32f84772977570265982ea | chrome | bigvul | 1 | null | null | null |
DevTools: move DevToolsAgent/Client into content.
BUG=84078
TEST=
Review URL: http://codereview.chromium.org/7461019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93596 0039d316-1c4b-4281-b951-d872f2087c98 | 8262245d384be025f13e2a5b3a03b7e5c98374ce | chrome | bigvul | 1 | null | null | null |
Add missing shortcut keys to the keyboard overlay.
This CL adds the following shortcuts to the keyboard overlay.
* Alt - 1, Alt - 2, .., Alt - 8: go to the window at the specified position
* Alt - 9: go to the last window open
* Ctrl - Forward: switches focus to the next keyboard-accessible pane
* Ctrl - Back: switches focus to the previous keyboard-accessible pane
* Ctrl - Right: move the text cursor to the end of the next word
* Ctrl - Left: move the text cursor to the start of the previous word
* Ctrl - Alt - Z: enable or disable accessibility features
* Ctrl - Shift - Maximize: take a screenshot of the selected region
* Ctrl - Shift - O: open the Bookmark Manager
I also deleted a duplicated entry of "Close window".
BUG=chromium-os:17152
TEST=Manually checked on chromebook
Review URL: http://codereview.chromium.org/7489040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93906 0039d316-1c4b-4281-b951-d872f2087c98 | 5837ee4ab49f2a9f604f9d572df01a832cb446cc | chrome | bigvul | 1 | null | null | null |
Fix compile warning.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7572039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95563 0039d316-1c4b-4281-b951-d872f2087c98 | 5b65968b6c64fa02e74ca6b965bf5998b911e826 | chrome | bigvul | 1 | null | null | null |
Revert "Revert 100494 - Fix bug in SimulateAttrib0."""
TEST=none
BUG=95625
[email protected]
Review URL: http://codereview.chromium.org/7796016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100507 0039d316-1c4b-4281-b951-d872f2087c98 | c13e1da62b5f5f0e6fe8c1f769a5a28415415244 | chrome | bigvul | 1 | null | null | null |
Unreviewed, rolling out r127612, r127660, and r127664.
http://trac.webkit.org/changeset/127612
http://trac.webkit.org/changeset/127660
http://trac.webkit.org/changeset/127664
https://bugs.webkit.org/show_bug.cgi?id=95920
Source/Platform:
* Platform.gypi:
* chromium/public/WebRTCPeerConnectionHandler.h:
(WebKit):
(WebRTCPeerConnectionHandler):
* chromium/public/WebRTCVoidRequest.h: Removed.
Source/WebCore:
* CMakeLists.txt:
* GNUmakefile.list.am:
* Modules/mediastream/RTCErrorCallback.h:
(WebCore):
(RTCErrorCallback):
* Modules/mediastream/RTCErrorCallback.idl:
* Modules/mediastream/RTCPeerConnection.cpp:
(WebCore::RTCPeerConnection::createOffer):
* Modules/mediastream/RTCPeerConnection.h:
(WebCore):
(RTCPeerConnection):
* Modules/mediastream/RTCPeerConnection.idl:
* Modules/mediastream/RTCSessionDescriptionCallback.h:
(WebCore):
(RTCSessionDescriptionCallback):
* Modules/mediastream/RTCSessionDescriptionCallback.idl:
* Modules/mediastream/RTCSessionDescriptionRequestImpl.cpp:
(WebCore::RTCSessionDescriptionRequestImpl::create):
(WebCore::RTCSessionDescriptionRequestImpl::RTCSessionDescriptionRequestImpl):
(WebCore::RTCSessionDescriptionRequestImpl::requestSucceeded):
(WebCore::RTCSessionDescriptionRequestImpl::requestFailed):
(WebCore::RTCSessionDescriptionRequestImpl::clear):
* Modules/mediastream/RTCSessionDescriptionRequestImpl.h:
(RTCSessionDescriptionRequestImpl):
* Modules/mediastream/RTCVoidRequestImpl.cpp: Removed.
* Modules/mediastream/RTCVoidRequestImpl.h: Removed.
* WebCore.gypi:
* platform/chromium/support/WebRTCVoidRequest.cpp: Removed.
* platform/mediastream/RTCPeerConnectionHandler.cpp:
(RTCPeerConnectionHandlerDummy):
(WebCore::RTCPeerConnectionHandlerDummy::RTCPeerConnectionHandlerDummy):
* platform/mediastream/RTCPeerConnectionHandler.h:
(WebCore):
(WebCore::RTCPeerConnectionHandler::~RTCPeerConnectionHandler):
(RTCPeerConnectionHandler):
(WebCore::RTCPeerConnectionHandler::RTCPeerConnectionHandler):
* platform/mediastream/RTCVoidRequest.h: Removed.
* platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.cpp:
* platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.h:
(RTCPeerConnectionHandlerChromium):
Tools:
* DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
(MockWebRTCPeerConnectionHandler::SuccessCallbackTask::SuccessCallbackTask):
(MockWebRTCPeerConnectionHandler::SuccessCallbackTask::runIfValid):
(MockWebRTCPeerConnectionHandler::FailureCallbackTask::FailureCallbackTask):
(MockWebRTCPeerConnectionHandler::FailureCallbackTask::runIfValid):
(MockWebRTCPeerConnectionHandler::createOffer):
* DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
(MockWebRTCPeerConnectionHandler):
(SuccessCallbackTask):
(FailureCallbackTask):
LayoutTests:
* fast/mediastream/RTCPeerConnection-createOffer.html:
* fast/mediastream/RTCPeerConnection-localDescription-expected.txt: Removed.
* fast/mediastream/RTCPeerConnection-localDescription.html: Removed.
* fast/mediastream/RTCPeerConnection-remoteDescription-expected.txt: Removed.
* fast/mediastream/RTCPeerConnection-remoteDescription.html: Removed.
git-svn-id: svn://svn.chromium.org/blink/trunk@127679 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | ab5e55ff333def909d025ac45da9ffa0d88a63f2 | chrome | bigvul | 1 | null | null | null |
Be a little more careful whether something is an URL or a file path.
BUG=72492
Review URL: http://codereview.chromium.org/7572046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95731 0039d316-1c4b-4281-b951-d872f2087c98 | a64c3cf0ab6da24a9a010a45ebe4794422d40c71 | chrome | bigvul | 1 | null | null | null |
2012-04-02 Stephanie Lewis <[email protected]>
run-webkit-tests --root fails if /usr/local/lib/libWebCoreTestSupport.dylib is not installed.
https://bugs.webkit.org/show_bug.cgi?id=82552
Reviewed by Dirk Pranke.
Use DYLD_LIBRARY_PATH so we pick up the libWebCoreTestSupport.dylib located in the root.
* Scripts/webkitpy/layout_tests/port/webkit.py:
(WebKitDriver._start):
git-svn-id: svn://svn.chromium.org/blink/trunk@112948 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | 90d40c781c36fd460cbcf4b3ee92b77df36a8c0d | chrome | bigvul | 1 | null | null | null |
Removes known_crashes.txt SUBSTRING for crbug.com/84872
The reported fix has rolled into chrome:
http://trac.webkit.org/changeset/88216
BUG=84872
TEST=
Review URL: http://codereview.chromium.org/7211012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90557 0039d316-1c4b-4281-b951-d872f2087c98 | 46f53ffa4b19cbe61552ffd7b7486168453e6eb0 | chrome | bigvul | 1 | null | null | null |
Suppress reports on waveOutGetNumDevs and CreateTextServices
TBR=bruening
BUG=DrMemory i#454, i#455
Review URL: http://codereview.chromium.org/7003120
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88670 0039d316-1c4b-4281-b951-d872f2087c98 | 9a7a1f3ff43d10f7b8f5071fdd0d903691bd72ec | chrome | bigvul | 1 | null | null | null |
Fix libxml XPath bug.
BUG=89402
Review URL: http://codereview.chromium.org/7508039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95382 0039d316-1c4b-4281-b951-d872f2087c98 | c9911bc93097a5df5518f5b88e1d5ed5ef275a4d | chrome | bigvul | 1 | null | null | null |
configure.ac has duplicated AC_MSG_RESULT([$enable_sandbox]) and nothing for seamless iframes
https://bugs.webkit.org/show_bug.cgi?id=87453
Reviewed by Eric Seidel.
Report the value of $enable_iframe_seamless rather than $enable_sandbox
after checking whether to enable the iframe seamless option.
* configure.ac:
git-svn-id: svn://svn.chromium.org/blink/trunk@118550 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | 80d94e9f6b103bcf391731f324c935beba9d2e4f | chrome | bigvul | 1 | null | null | null |
Rename isPositioned to isOutOfFlowPositioned for clarity
https://bugs.webkit.org/show_bug.cgi?id=89836
Reviewed by Antti Koivisto.
RenderObject and RenderStyle had an isPositioned() method that was
confusing, because it excluded relative positioning. Rename to
isOutOfFlowPositioned(), which makes it clearer that it only applies
to absolute and fixed positioning.
Simple rename; no behavior change.
Source/WebCore:
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::getPositionOffsetValue):
* css/StyleResolver.cpp:
(WebCore::StyleResolver::collectMatchingRulesForList):
* dom/Text.cpp:
(WebCore::Text::rendererIsNeeded):
* editing/DeleteButtonController.cpp:
(WebCore::isDeletableElement):
* editing/TextIterator.cpp:
(WebCore::shouldEmitNewlinesBeforeAndAfterNode):
* rendering/AutoTableLayout.cpp:
(WebCore::shouldScaleColumns):
* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::addToLine):
(WebCore::InlineFlowBox::placeBoxesInInlineDirection):
(WebCore::InlineFlowBox::requiresIdeographicBaseline):
(WebCore::InlineFlowBox::adjustMaxAscentAndDescent):
(WebCore::InlineFlowBox::computeLogicalBoxHeights):
(WebCore::InlineFlowBox::placeBoxesInBlockDirection):
(WebCore::InlineFlowBox::flipLinesInBlockDirection):
(WebCore::InlineFlowBox::computeOverflow):
(WebCore::InlineFlowBox::computeOverAnnotationAdjustment):
(WebCore::InlineFlowBox::computeUnderAnnotationAdjustment):
* rendering/InlineIterator.h:
(WebCore::isIteratorTarget):
* rendering/LayoutState.cpp:
(WebCore::LayoutState::LayoutState):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::MarginInfo::MarginInfo):
(WebCore::RenderBlock::styleWillChange):
(WebCore::RenderBlock::styleDidChange):
(WebCore::RenderBlock::addChildToContinuation):
(WebCore::RenderBlock::addChildToAnonymousColumnBlocks):
(WebCore::RenderBlock::containingColumnsBlock):
(WebCore::RenderBlock::columnsBlockForSpanningElement):
(WebCore::RenderBlock::addChildIgnoringAnonymousColumnBlocks):
(WebCore::getInlineRun):
(WebCore::RenderBlock::isSelfCollapsingBlock):
(WebCore::RenderBlock::layoutBlock):
(WebCore::RenderBlock::addOverflowFromBlockChildren):
(WebCore::RenderBlock::expandsToEncloseOverhangingFloats):
(WebCore::RenderBlock::handlePositionedChild):
(WebCore::RenderBlock::moveRunInUnderSiblingBlockIfNeeded):
(WebCore::RenderBlock::collapseMargins):
(WebCore::RenderBlock::clearFloatsIfNeeded):
(WebCore::RenderBlock::simplifiedNormalFlowLayout):
(WebCore::RenderBlock::isSelectionRoot):
(WebCore::RenderBlock::blockSelectionGaps):
(WebCore::RenderBlock::clearFloats):
(WebCore::RenderBlock::markAllDescendantsWithFloatsForLayout):
(WebCore::RenderBlock::markSiblingsWithFloatsForLayout):
(WebCore::isChildHitTestCandidate):
(WebCore::InlineMinMaxIterator::next):
(WebCore::RenderBlock::computeBlockPreferredLogicalWidths):
(WebCore::RenderBlock::firstLineBoxBaseline):
(WebCore::RenderBlock::lastLineBoxBaseline):
(WebCore::RenderBlock::updateFirstLetter):
(WebCore::shouldCheckLines):
(WebCore::getHeightForLineCount):
(WebCore::RenderBlock::adjustForBorderFit):
(WebCore::inNormalFlow):
(WebCore::RenderBlock::adjustLinePositionForPagination):
(WebCore::RenderBlock::adjustBlockChildForPagination):
(WebCore::RenderBlock::renderName):
* rendering/RenderBlock.h:
(WebCore::RenderBlock::shouldSkipCreatingRunsForObject):
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::setMarginsForRubyRun):
(WebCore::RenderBlock::computeInlineDirectionPositionsForLine):
(WebCore::RenderBlock::computeBlockDirectionPositionsForLine):
(WebCore::RenderBlock::layoutInlineChildren):
(WebCore::requiresLineBox):
(WebCore::RenderBlock::LineBreaker::skipTrailingWhitespace):
(WebCore::RenderBlock::LineBreaker::skipLeadingWhitespace):
(WebCore::RenderBlock::LineBreaker::nextLineBreak):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::removeFloatingOrPositionedChildFromBlockLists):
(WebCore::RenderBox::styleWillChange):
(WebCore::RenderBox::styleDidChange):
(WebCore::RenderBox::updateBoxModelInfoFromStyle):
(WebCore::RenderBox::offsetFromContainer):
(WebCore::RenderBox::positionLineBox):
(WebCore::RenderBox::computeRectForRepaint):
(WebCore::RenderBox::computeLogicalWidthInRegion):
(WebCore::RenderBox::renderBoxRegionInfo):
(WebCore::RenderBox::computeLogicalHeight):
(WebCore::RenderBox::computePercentageLogicalHeight):
(WebCore::RenderBox::computeReplacedLogicalWidthUsing):
(WebCore::RenderBox::computeReplacedLogicalHeightUsing):
(WebCore::RenderBox::availableLogicalHeightUsing):
(WebCore::percentageLogicalHeightIsResolvable):
* rendering/RenderBox.h:
(WebCore::RenderBox::stretchesToViewport):
(WebCore::RenderBox::isDeprecatedFlexItem):
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::adjustedPositionRelativeToOffsetParent):
(WebCore::RenderBoxModelObject::mapAbsoluteToLocalPoint):
* rendering/RenderBoxModelObject.h:
(WebCore::RenderBoxModelObject::requiresLayer):
* rendering/RenderDeprecatedFlexibleBox.cpp:
(WebCore::childDoesNotAffectWidthOrFlexing):
(WebCore::RenderDeprecatedFlexibleBox::layoutBlock):
(WebCore::RenderDeprecatedFlexibleBox::layoutHorizontalBox):
(WebCore::RenderDeprecatedFlexibleBox::layoutVerticalBox):
(WebCore::RenderDeprecatedFlexibleBox::renderName):
* rendering/RenderFieldset.cpp:
(WebCore::RenderFieldset::findLegend):
* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::computePreferredLogicalWidths):
(WebCore::RenderFlexibleBox::autoMarginOffsetInMainAxis):
(WebCore::RenderFlexibleBox::availableAlignmentSpaceForChild):
(WebCore::RenderFlexibleBox::computeMainAxisPreferredSizes):
(WebCore::RenderFlexibleBox::computeNextFlexLine):
(WebCore::RenderFlexibleBox::resolveFlexibleLengths):
(WebCore::RenderFlexibleBox::prepareChildForPositionedLayout):
(WebCore::RenderFlexibleBox::layoutAndPlaceChildren):
(WebCore::RenderFlexibleBox::layoutColumnReverse):
(WebCore::RenderFlexibleBox::adjustAlignmentForChild):
(WebCore::RenderFlexibleBox::flipForRightToLeftColumn):
* rendering/RenderGrid.cpp:
(WebCore::RenderGrid::renderName):
* rendering/RenderImage.cpp:
(WebCore::RenderImage::computeIntrinsicRatioInformation):
* rendering/RenderInline.cpp:
(WebCore::RenderInline::addChildIgnoringContinuation):
(WebCore::RenderInline::addChildToContinuation):
(WebCore::RenderInline::generateCulledLineBoxRects):
(WebCore):
(WebCore::RenderInline::culledInlineFirstLineBox):
(WebCore::RenderInline::culledInlineLastLineBox):
(WebCore::RenderInline::culledInlineVisualOverflowBoundingBox):
(WebCore::RenderInline::computeRectForRepaint):
(WebCore::RenderInline::dirtyLineBoxes):
* rendering/RenderLayer.cpp:
(WebCore::checkContainingBlockChainForPagination):
(WebCore::RenderLayer::updateLayerPosition):
(WebCore::isPositionedContainer):
(WebCore::RenderLayer::calculateClipRects):
(WebCore::RenderLayer::shouldBeNormalFlowOnly):
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::requiresCompositingForPosition):
* rendering/RenderLineBoxList.cpp:
(WebCore::RenderLineBoxList::dirtyLinesFromChangedChild):
* rendering/RenderListItem.cpp:
(WebCore::getParentOfFirstLineBox):
* rendering/RenderMultiColumnBlock.cpp:
(WebCore::RenderMultiColumnBlock::renderName):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::markContainingBlocksForLayout):
(WebCore::RenderObject::setPreferredLogicalWidthsDirty):
(WebCore::RenderObject::invalidateContainerPreferredLogicalWidths):
(WebCore::RenderObject::styleWillChange):
(WebCore::RenderObject::offsetParent):
* rendering/RenderObject.h:
(WebCore::RenderObject::isOutOfFlowPositioned):
(WebCore::RenderObject::isInFlowPositioned):
(WebCore::RenderObject::hasClip):
(WebCore::RenderObject::isFloatingOrOutOfFlowPositioned):
* rendering/RenderObjectChildList.cpp:
(WebCore::RenderObjectChildList::removeChildNode):
* rendering/RenderReplaced.cpp:
(WebCore::hasAutoHeightOrContainingBlockWithAutoHeight):
* rendering/RenderRubyRun.cpp:
(WebCore::RenderRubyRun::rubyText):
* rendering/RenderTable.cpp:
(WebCore::RenderTable::addChild):
(WebCore::RenderTable::computeLogicalWidth):
(WebCore::RenderTable::layout):
* rendering/style/RenderStyle.h:
Source/WebKit/blackberry:
* Api/WebPage.cpp:
(BlackBerry::WebKit::isPositionedContainer):
(BlackBerry::WebKit::isNonRenderViewFixedPositionedContainer):
(BlackBerry::WebKit::isFixedPositionedContainer):
Source/WebKit2:
* WebProcess/WebPage/qt/LayerTreeHostQt.cpp:
(WebKit::updateOffsetFromViewportForSelf):
git-svn-id: svn://svn.chromium.org/blink/trunk@121123 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | 01e4ee2fda0a5e57a8d0c8cb829022eb84fdff12 | chrome | bigvul | 1 | null | null | null |
Update Autofill scripts for serializing profiles from the webdb.
Support multi-valued profiles, hey!
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7262017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90668 0039d316-1c4b-4281-b951-d872f2087c98 | c1c078b77aab01ffaf888cc850bcbc47eb7629e5 | chrome | bigvul | 1 | null | null | null |
ntp4: show larger favicons in most visited page
extend favicon source to provide larger icons. For now, larger means at most 32x32. Also, the only icon we actually support at this resolution is the default (globe).
BUG=none
TEST=manual
Review URL: http://codereview.chromium.org/7300017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91517 0039d316-1c4b-4281-b951-d872f2087c98 | abbd2f4b36da8c89e6f3002eb84f60064a6ff067 | chrome | bigvul | 1 | null | null | null |
Add chromium_code: 1 to surface.gyp and gl.gyp to pick up -Werror.
It looks like this was dropped accidentally in http://codereview.chromium.org/6718027 (surface.gyp) and http://codereview.chromium.org/6722026 (gl.gyp)
Remove now-redudant code that's implied by chromium_code: 1.
Fix the warnings that have crept in since chromium_code: 1 was removed.
BUG=none
TEST=none
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=91598
Review URL: http://codereview.chromium.org/7227009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91813 0039d316-1c4b-4281-b951-d872f2087c98 | a4b20ed4917f1f6fc83b6375a48e2c3895d43a8a | chrome | bigvul | 1 | null | null | null |
Extend TTS extension API to support richer events returned from the engine
to the client. Previously we just had a completed event; this adds start,
word boundary, sentence boundary, and marker boundary. In addition,
interrupted and canceled, which were previously errors, now become events.
Mac and Windows implementations extended to support as many of these events
as possible.
BUG=67713
BUG=70198
BUG=75106
BUG=83404
TEST=Updates all TTS API tests to be event-based, and adds new tests.
Review URL: http://codereview.chromium.org/6792014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91665 0039d316-1c4b-4281-b951-d872f2087c98 | c63f2b7fe4fe2977f858a8e36d5f48db17eff2e7 | chrome | bigvul | 1 | null | null | null |
Adding tests for new webstore beginInstallWithManifest method.
BUG=75821
TEST=none
Review URL: http://codereview.chromium.org/6900059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83080 0039d316-1c4b-4281-b951-d872f2087c98 | 9eb1fd426a04adac0906c81ed88f1089969702ba | chrome | bigvul | 1 | null | null | null |
Fixing gyp mistake that causes warnings but unfortunately not errors at the
moment.
Introduced in:
r78711 | [email protected]
BUG=None
TEST=None
[email protected],[email protected],[email protected]
[email protected]
Review URL: http://codereview.chromium.org/6685110
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78841 0039d316-1c4b-4281-b951-d872f2087c98 | 724fffdbc7645d74c5b5a4f4bf2f6cc09dd7579b | chrome | bigvul | 1 | null | null | null |
Base: A few more files using BASE_API (for base.dll)
BUG=76996
TEST=none
Review URL: http://codereview.chromium.org/6733031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79426 0039d316-1c4b-4281-b951-d872f2087c98 | 90509cbdde392aa218771f6673b9b5a6600c2b57 | chrome | bigvul | 1 | null | null | null |
Ensure URL is updated after a cross-site navigation is pre-empted by
an "ignored" navigation.
BUG=77507
TEST=NavigationControllerTest.LoadURL_IgnorePreemptsPending
Review URL: http://codereview.chromium.org/6826015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81307 0039d316-1c4b-4281-b951-d872f2087c98 | 20d1c99d9b53a0b2b419aae0075494a9d0b86daf | chrome | bigvul | 1 | null | null | null |
Unrevert: Show the install dialog for the initial load of an unpacked extension
with plugins.
First landing broke some browser tests.
BUG=83273
TEST=in the extensions managmenet page, with developer mode enabled, Load an unpacked extension on an extension with NPAPI plugins. You should get an install dialog.
TBR=mihaip
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87738 0039d316-1c4b-4281-b951-d872f2087c98 | 5fb88938e3210391f8c948f127fd96d9c2979119 | chrome | bigvul | 1 | null | null | null |
Update PrerenderBrowserTests to work with new
PrerenderContents.
Also update PrerenderContents to pass plugin
and HTML5 prerender tests.
BUG=81229
TEST=PrerenderBrowserTests (Once the new code is enabled)
Review URL: http://codereview.chromium.org/6905169
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83841 0039d316-1c4b-4281-b951-d872f2087c98 | 225e7438996c9c939bd239376dfa93e562972cf8 | chrome | bigvul | 1 | null | null | null |
Prevent extensions from defining homepages with schemes other than valid web extents.
BUG=84402
TEST=ExtensionManifestTest.ParseHomepageURLs
Review URL: http://codereview.chromium.org/7089014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87722 0039d316-1c4b-4281-b951-d872f2087c98 | 697cd7e2ce2535696f1b9e5cfb474cc36a734747 | chrome | bigvul | 1 | null | null | null |
[EFL] [DRT] Enable passing sputnik tests
https://bugs.webkit.org/show_bug.cgi?id=84600
Unreviewed, unskip sputnik tests which are passing now.
Patch by Sudarsana Nagineni <[email protected]> on 2012-04-24
* platform/efl/Skipped:
git-svn-id: svn://svn.chromium.org/blink/trunk@115034 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | ea9392d8bd5999c8514fd788ee2ba4c4660aff3a | chrome | bigvul | 1 | null | null | null |
Fix a lock re-entry bug in GpuDataManager::UpdateGpuInfo.
The issue is that the registered callbacks could request GPUInfo, so they could re-enter the lock. Therefore, we should release the lock before we run through callbacks.
BUG=84805
TEST=the issue in 84805 is gone.
Review URL: http://codereview.chromium.org/7054063
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87898 0039d316-1c4b-4281-b951-d872f2087c98 | 9400c64565586091f67d4131850fd0836b18b511 | chrome | bigvul | 1 | null | null | null |
base/i18n: Remove unneeded includes in case_conversion.*
These includes are not needed anymore since r84855.
BUG=None
TEST=None
[email protected]
Review URL: http://codereview.chromium.org/7032008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85559 0039d316-1c4b-4281-b951-d872f2087c98 | b353e6983bdf9bd935b97bb5a7f225f246089fba | chrome | bigvul | 1 | null | null | null |
Maintain a map of all resources in the resource tracker and clear instance back pointers when needed,
BUG=85808
Review URL: http://codereview.chromium.org/7196001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89746 0039d316-1c4b-4281-b951-d872f2087c98 | 55ef04e135edaa9abfbf3647634b11ed57dc49e9 | chrome | bigvul | 1 | null | null | null |
Reviewed by Kevin Ollivier.
[wx] Fix strokeArc and fillRoundedRect drawing, and add clipPath support.
https://bugs.webkit.org/show_bug.cgi?id=60847
git-svn-id: svn://svn.chromium.org/blink/trunk@86502 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | adb3498ca0b69561d8c6b60bab641de4b0e37dbf | chrome | bigvul | 1 | null | null | null |
Roll icu to r90787 to get an upstream regex patch (also independently made by bxx )
BUG=86900
TEST=In debug build, run Chrome and load testcase.htm file (attached to the bug). It should not result in a sad tab.
TBR=jschuh
Review URL: http://codereview.chromium.org/7253044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90794 0039d316-1c4b-4281-b951-d872f2087c98 | 38fd88d538558ad46e9f8ace1e8eeeed48c1548f | chrome | bigvul | 1 | null | null | null |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.