commit_msg
stringlengths
1
24.2k
commit_hash
stringlengths
2
84
project
stringlengths
2
40
source
stringclasses
4 values
labels
int64
0
1
repo_url
stringlengths
26
70
commit_url
stringlengths
74
118
commit_date
stringlengths
25
25
SoftAMR: check output buffer size to avoid overflow. Bug: 27662364 Change-Id: I7b26892c41d6f2e690e77478ab855c2fed1ff6b0
44749eb4f273f0eb681d0fa013e3beef754fa687
android
bigvul
1
null
null
null
Add VPX output buffer size check and handle dead observers more gracefully Bug: 27597103 Change-Id: Id7acb25d5ef69b197da15ec200a9e4f9e7b03518
f9ed2fe6d61259e779a37d4c2d7edb33a1c1f8ba
android
bigvul
1
null
null
null
codecs: check OMX buffer size before use in VP8 encoder. Bug: 27569635 Change-Id: I469573f40e21dc9f4c200749d4f220e3a2d31761
7fd96ebfc4c9da496c59d7c45e1f62be178e626d
android
bigvul
1
null
null
null
Camera3Device: Validate template ID Validate template ID before creating a default request. Bug: 26866110 Bug: 27568958 Change-Id: Ifda457024f1d5c2b1382f189c1a8d5fda852d30d
b04aee833c5cfb6b31b8558350feb14bb1a0f353
android
bigvul
1
null
null
null
NuPlayerStreamListener: NULL and bounds check before memcpy Bug: 27533704 Change-Id: I992a7709b92b1cbc3114c97bec48a3fc5b22ba6e
a2d1d85726aa2a3126e9c331a8e00a8c319c9e2b
android
bigvul
1
null
null
null
Fix issue #27252896: Security Vulnerability -- weak binder Sending transaction to freed BBinder through weak handle can cause use of a (mostly) freed object. We need to try to safely promote to a strong reference first. Change-Id: Ic9c6940fa824980472e94ed2dfeca52a6b0fd342 (cherry picked from commit c11146106f94e07016e8e26e4f8628f9a0c73199)
a59b827869a2ea04022dd225007f29af8d61837a
android
bigvul
1
null
null
null
DO NOT MERGE Check size of pin before replying If a malicious client set a pin that was too long it would overflow the pin code memory. Bug: 27411268 Change-Id: I9197ac6fdaa92a4799dacb6364e04671a39450cc
9b534de2aca5d790c2a1c4d76b545f16137d95dd
android
bigvul
1
null
null
null
Don't demangle symbol names. Bug: http://b/27299236 Change-Id: I26ef47f80d4d6048a316ba51e83365ff65d70439
ad54cfed4516292654c997910839153264ae00a0
android
bigvul
1
null
null
null
Avoid free-before-initialize vulnerability in heap Bug: 27211885 Change-Id: Ib9c93bd9ffdde2a5f8d31a86f06e267dc9c152db
b499389da21d89d32deff500376c5ee4f8f0b04c
android
bigvul
1
null
null
null
Fix stack corruption happening in aacDecoder_drcExtractAndMap() In the aacDecoder_drcExtractAndMap() function, self->numThreads can be used after having exceeded its intended max value, MAX_DRC_THREADS, causing memory to be cleared after the threadBs[MAX_DRC_THREADS] array. The crash is prevented by never using self->numThreads with a value equal to or greater than MAX_DRC_THREADS. A proper fix will be required as there seems to be an issue as to which entry in the threadBs array is meant to be initialized and used. Bug 26751339 Change-Id: I655cc40c35d4206ab72e83b2bdb751be2fe52b5a
5d4405f601fa11a8955fd7611532c982420e4206
android
bigvul
1
null
null
null
Redact Account info from getCurrentSyncs BUG:26094635 If the caller to ContentResolver#getCurrentSyncs does not hold the GET_ACCOUNTS permission, return a SyncInfo object that does not contain any Account information. Change-Id: I5628ebe1f56c8e3f784aaf1b3281e6b829d19314 (cherry picked from commit b63057e698a01dafcefc7ba09b397b0336bba43d)
63363af721650e426db5b0bdfb8b2d4fe36abdb0
android
bigvul
1
null
null
null
Don't allow file attachment from file:///data. Commit 24ed2941ab132e4156bd38f0ab734c81dae8fc2e allows file:// attachment on the /data directory if they are from the same process. This was done to work around applications that shared their internal data file. However, this is bad practice, and other apps should share content:// Uri instead. With this change, Email doesn't allow this anymore. This fixes security issue 199888. Also, add Analytics for these errors compose_errors > send_intent_attachment > data_dir https://code.google.com/p/android/issues/detail?id=199888 b/26989185 Change-Id: I7cae3389f4f7cf5f86600a58c6ccdffaf889d1c3
0d9dfd649bae9c181e3afc5d571903f1eb5dc46f
android
bigvul
1
null
null
null
NPE fix for SyncStorageEngine read authority am: a962d9eba7 am: 339c4f2b05 am: 58048c1f17 * commit '58048c1f17d54166c6a048af2365d17dd32f4d57': NPE fix for SyncStorageEngine read authority
d3383d5bfab296ba3adbc121ff8a7b542bde4afb
android
bigvul
1
null
null
null
DO NOT MERGE - Restrict ability to add call based on device provision status Always return false for canAddCall if device is not yet provisioned. Bug: 26303187 Change-Id: I9c4ebc8b954a79562b2ec83d59314a3fb621ddfb
a06c9a4aef69ae27b951523cf72bf72412bf48fa
android
bigvul
1
null
null
null
Trust CA certificates added for the whole OS only Excludes any CA certificates installed for wifi-only from being used for anything else. Does not take effect retroactively against certs which were already installed. The CAs will continue to be saved to a part of the keystore accessible by services running under WIFI_UID. Bug: 26324357 Bug: 25780055 Change-Id: Ifeb9daf24c9f9a22b2b2daf247d5622c707c9885
70dde9870e9450e10418a32206ac1bb30f036b2c
android
bigvul
1
null
null
null
Don't create tombstone directory. Partial backport of cf79748. Bug: http://b/26403620 Change-Id: Ib877ab6cfab6aef079830c5a50ba81141ead35ee
81df1cc77722000f8d0025c1ab00ced123aa573c
android
bigvul
1
null
null
null
Fix info leak vulnerability of IDrm bug: 26323455 Change-Id: I25bb30d3666ab38d5150496375ed2f55ecb23ba8
5a856f2092f7086aa0fea9ae06b9255befcdcd34
android
bigvul
1
null
null
null
3 uninitialized variables in IOMX.cpp Uninitialized MetadataBufferType pointer in case: SET_INPUT_SURFACE STORE_META_DATA_IN_BUFFERS CREATE_INPUT_SURFACE Fix: initialize them to kMetadataBufferTypeInvalid Bug: 26324358 Change-Id: Ib3bcac9bedc98bc65efa39f67cdbffbd90b374c9
8d87321b704cb3f88e8cae668937d001fd63d5e3
android
bigvul
1
null
null
null
Clear allocation to avoid info leak Bug: 26914474 Change-Id: Ie1a86e86d78058d041149fe599a4996e7f8185cf
1171e7c047bf79e7c93342bb6a812c9edd86aa84
android
bigvul
1
null
null
null
Add SN logging Bug 27046057 Change-Id: Iede7c92e59e60795df1ec7768ebafd6b090f1c27
a40b30f5c43726120bfe69d41ff5aeb31fe1d02a
android
bigvul
1
null
null
null
Patch Exchange Autodiscover Code for Security Issue The change removes the unauthenticated GET fallback attempt for the Autodiscover process. Given that the Autodiscover code is functionally broken and this fallback attempt wouldn't succeed unless an attacker faked a success response, a good way to patch the security issue is to disable the attempt. The change also updates the request content type, disables automatic redirects, and allows for parsing namespaces to help the first two attempts succeed. As this is not meant to be a functional patch but a security patch, there are no further changes to the Autodiscover code. BUG: 26488455 Change-Id: I0fc93c95e755c8fa60e94da5bec4b3b4c49cdfc1
0d1a38b1755efe7ed4e8d7302a24186616bba9b2
android
bigvul
1
null
null
null
Add error logging on invalid cmap - DO NOT MERGE This patch logs instances of fonts with invalid cmap tables. Bug: 25645298 Bug: 26413177 Change-Id: I183985e9784a97a2b4307a22e036382b1fc90e5e
f4785aa1947b8d22d5b19559ef1ca526d98e0e73
android
bigvul
1
null
null
null
IOMX.cpp uninitialized pointer in BnOMX::onTransact This can lead to local code execution in media server. Fix initializes the pointer and checks the error conditions before returning Bug: 26403627 Change-Id: I7fa90682060148448dba01d6acbe3471d1ddb500
25be9ac20db51044e1b09ca67906355e4f328d48
android
bigvul
1
null
null
null
Update SK_CRASH to default to abort(). DO NOT MERGE Bug: 26593930 Change-Id: I091a6668b7f72d8ecfefe0fe8ad2f3d101b36b7b
b36c23b3e6b0b316075cc43e466d44c62508fcac
android
bigvul
1
null
null
null
DO NOT MERGE - Remove deprecated image defines libvpx has always supported the VPX_ prefixed versions of these defines. The unprefixed versions have been removed in the most recent release. https://chromium.googlesource.com/webm/libvpx/+/9cdaa3d72eade9ad162ef8f78a93bd8f85c6de10 BUG=23452792 Change-Id: I8a656f2262f117d7a95271f45100b8c6fd0a470f
5a6788730acfc6fd8f4a6ef89d2c376572a26b55
android
bigvul
1
null
null
null
Improve length checks in DHCP Options parsing of dhcpcd. Bug: 26461634 Change-Id: Ic4c2eb381a6819e181afc8ab13891f3fc58b7deb
1390ace71179f04a09c300ee8d0300aa69d9db09
android
bigvul
1
null
null
null
DO NOT MERGE Remove Porsche car-kit pairing workaround Bug: 26551752 Change-Id: I14c5e3fcda0849874c8a94e48aeb7d09585617e1
c677ee92595335233eb0e7b59809a1a94e7a678a
android
bigvul
1
null
null
null
Fix integer overflows in recovery procedure. Bug: 26960931 Change-Id: Ieae45caccfb4728fcf514f0d920976585d8e6caf (cherry picked from commit 4f2df162c6ab4a71ca86e4b38735b681729c353b)
28a566f7731b4cb76d2a9ba16d997ac5aeb07dad
android
bigvul
1
null
null
null
Use resolved path for both checking and opening. This avoids a race condition where someone can change a symlink target after the security checks have passed. Bug: 26211054 Change-Id: I5842aaecc7b7d417a3b1902957b59b8a1f3c1ccb
bdc831357e7a116bc561d51bf2ddc85ff11c01a9
android
bigvul
1
null
null
null
Fixes creation of incorrect SIP PhoneAccountHandle When a new incoming call occurs in SIP, SipUtil mistakenly uses the Uri handle instead of the profile name to create the PhoneAccountHandle. Since this PhoneAccountHandle is not registered with telecom, it will throw a security exception (as of b/26864502). BUG: 26874216 Change-Id: I27611b45f0834fca328c4cc2b867edaf970f7171
a294ae5342410431a568126183efe86261668b5d
android
bigvul
1
null
null
null
Sanity check IMemory access versus underlying mmap Bug 26877992 Change-Id: Ibbf4b1061e4675e4e96bc944a865b53eaf6984fe
f3199c228aced7858b75a8070b8358c155ae0149
android
bigvul
1
null
null
null
DO NOT MERGE: Further restrict access to socket ioctl commands Remove untrusted/isolated app access to device private commands. Only allow shell user to access unprivileged socket ioctl commands. Bug: 26324307 Bug: 26267358 Change-Id: Iddf1171bc05c7600e0292f925d18d748f13a98f2
57531cacb40682be4b1189c721fd1e7f25bf3786
android
bigvul
1
null
null
null
Return error when there are more mmco params than allocated size Bug: 25818142 Change-Id: I5c1b23985eeca5192b42703c627ca3d060e4e13d
943323f1d9d3dd5c2634deb26cbe72343ca6b3db
android
bigvul
1
null
null
null
Get service by value instead of reference to prevent a cleared service binder from being used. Bug: 26040840 Change-Id: Ifb5483c55b172d3553deb80dbe27f2204b86ecdb
3097f364237fb552871f7639d37a7afa4563e252
android
bigvul
1
null
null
null
Decoder: Fix stack underflow in CAVLC 4x4 parse functions Bug: 26399350 Change-Id: Id768751672a7b093ab6e53d4fc0b3188d470920e
c57fc3703ae2e0d41b1f6580c50015937f2d23c1
android
bigvul
1
null
null
null
post proc : volume listener : fix effect release crash Fix access to deleted effect context in vol_prc_lib_release() Bug: 25753245. Change-Id: I64ca99e4d5d09667be4c8c605f66700b9ae67949 (cherry picked from commit 93ab6fdda7b7557ccb34372670c30fa6178f8426)
ebbb82365172337c6c250c6cac4e326970a9e351
android
bigvul
1
null
null
null
Sonivox: sanity check numSamples. Bug: 26366256 Change-Id: I066888c25035ea4c60c88f316db4508dc4dab6bc
3ac044334c3ff6a61cb4238ff3ddaf17c7efcf49
android
bigvul
1
null
null
null
Also fix out of bounds access for normal read Previous fix accidentally only fixed the fragmented read case. Bug: 27208621 Change-Id: Ie16f1920b84c8aba613842659238fcd5925694ad
7a282fb64fef25349e9d341f102d9cea3bf75baf
android
bigvul
1
null
null
null
Fixed stack buffer overflow Bugfix: 25812590 Moved check for numCoeffs > 64 inside the coeff decode loop Change-Id: I444b77ef2a3da9233ec14bb72ac70b7e2fa56bd1 (cherry picked from commit ff3496c45c571da7eb93d6f9f05758813468fc72)
8b4ed5a23175b7ffa56eea4678db7287f825e985
android
bigvul
1
null
null
null
Fix for handling streams which resulted in negative num_mbs_left Bug: 26070014 Change-Id: Id9f063a2c72a802d991b92abaf00ec687db5bb0f
ba604d336b40fd4bde1622f64d67135bdbd61301
android
bigvul
1
null
null
null
Check permissions on getDeviceId. bug:25778215 Change-Id: Ie27d69e558a8132f6e0c5058aaad1a4ae02bf82f
79eecef63f3ea99688333c19e22813f54d4a31b1
android
bigvul
1
null
null
null
Fix crashes with lots of discovered LE devices When loads of devices are discovered a config file which is too large can be written out, which causes the BT daemon to crash on startup. This limits the number of config entries for unpaired devices which are initialized, and prevents a large number from being saved to the filesystem. Bug: 26071376 Change-Id: I4a74094f57a82b17f94e99a819974b8bc8082184
d77f1999ecece56c1cbb333f4ddc26f0b5bac2c5
android
bigvul
1
null
null
null
IGraphicBufferProducer: fix QUEUE_BUFFER info leak Bug: 26338109 Change-Id: I8a979469bfe1e317ebdefa43685e19f9302baea8
d06421fd37fbb7fd07002e6738fac3a223cb1a62
android
bigvul
1
null
null
null
IGraphicBufferConsumer: fix ATTACH_BUFFER info leak Bug: 26338113 Change-Id: I019c4df2c6adbc944122df96968ddd11a02ebe33
dded8fdbb700d6cc498debc69a780915bc34d755
android
bigvul
1
null
null
null
fix possible overflow in effect wrappers. Add checks on parameter size field in effect command handlers to avoid overflow leading to invalid comparison with min allowed size for command and reply buffers. Bug: 26347509. Change-Id: I20e6a9b6de8e5172b957caa1ac9410b9752efa4d (cherry picked from commit ad1bd92a49d78df6bc6e75bee68c517c1326f3cf)
9e29523b9537983b4c4b205ff868d0b3bca0383b
android
bigvul
1
null
null
null
Camera: Disallow dumping clients directly Camera service dumps should only be initiated through ICameraService::dump. Bug: 26265403 Change-Id: If3ca4718ed74bf33ad8a416192689203029e2803
c9ab2b0bb05a7e19fb057e79b36e232809d70122
android
bigvul
1
null
null
null
Fixed bit stream access to make sure that it is not read beyond the allocated size. Bug: 25765591 Change-Id: I98c23a3c3f84f6710f29bffe5ed73adcf51d47f6
ffab15eb80630dc799eb410855c93525b75233c3
android
bigvul
1
null
null
null
Cache intermediate CA separately Intermediate CAs are cached in order to support servers that fail to sent a complete chain to a root. These certificates should be cached to support these servers but these certificates must not be trusted as trust anchors. Store them separately to prevent confusion between trusted roots and cached intermediates. (cherry-picked from commit 198aca1fb638a2a98e89fb9f284108ad576d0c3b) Bug: 26232830 Change-Id: I520f50729b55fc7412c7d133335bc9e3c190bbf6
c4ab1b959280413fb11bf4fd7f6b4c2ba38bd779
android
bigvul
1
null
null
null
Decoder Update mb count after mb map is set. Bug: 25928803 Change-Id: Iccc58a7dd1c5c6ea656dfca332cfb8dddba4de37
4a524d3a8ae9aa20c36430008e6bd429443f8f1d
android
bigvul
1
null
null
null
Fix out-of-bounds write Bug: 26365349 Change-Id: Ia363d9f8c231cf255dea852e0bbf5ca466c7990b
5403587a74aee2fb57076528c3927851531c8afb
android
bigvul
1
null
null
null
DO NOT MERGE Ensure that the device is provisioned before showing Recents. Bug: 25476219 Change-Id: I5bb9cca74790521de71c0037b4f2421c3d21b3f6
16a76dadcc23a13223e9c2216dad1fe5cad7d6e1
android
bigvul
1
null
null
null
DO NOT MERGE. Prevent recents from coming up when in SUW Bug: 25229538 Change-Id: If4f276d3f7c04fd89011068d90a3c3c60593bc05
84669ca8de55d38073a0dcb01074233b0a417541
android
bigvul
1
null
null
null
Fix security vulnerability in ICrypto DO NOT MERGE b/25800375 Change-Id: I03c9395f7c7de4ac5813a1207452aac57aa39484
22f824feac43d5758f9a70b77f2aca840ba62c3b
android
bigvul
1
null
null
null
DO NOT MERGE SoundPool: add lock for findSample access from SoundPoolThread Sample decoding still occurs in SoundPoolThread without holding the SoundPool lock. Bug: 25781119 Change-Id: I11fde005aa9cf5438e0390a0d2dfe0ec1dd282e8
19c47afbc402542720ddd280e1bbde3b2277b586
android
bigvul
1
null
null
null
Fix use-after-free in wifi_cleanup() Release reference to cmd only after possibly calling getType(). BUG: 25753768 Change-Id: Id2156ce51acec04e8364706cf7eafc7d4adae9eb (cherry picked from commit d7f3cb9915d9ac514393d0ad7767662958054b8f https://googleplex-android-review.git.corp.google.com/#/c/815223)
2c5a4fac8bc8198f6a2635ede776f8de40a0c3e1
android
bigvul
1
null
null
null
Avoid integer overflows in parsing fonts A malformed TTF can cause size calculations to overflow. This patch checks the maximum reasonable value so that the total size fits in 32 bits. It also adds some explicit casting to avoid possible technical undefined behavior when parsing sized unsigned values. Bug: 25645298 Change-Id: Id4716132041a6f4f1fbb73ec4e445391cf7d9616 (cherry picked from commit 183c9ec2800baa2ce099ee260c6cbc6121cf1274)
ed4c8d79153baab7f26562afb8930652dfbf853b
android
bigvul
1
null
null
null
Fix incorrect check of descsz value. Bug: 25187394 (cherry picked from commit 1fa55234d6773e09e3bb934419b5b6cc0df981c9) Change-Id: Idbc9071e8b2b25a062c4e94118808d6e19d443d9
d917514bd6b270df431ea4e781a865764d406120
android
bigvul
1
null
null
null
GenericSource: reset mDrmManagerClient when mDataSource is cleared. Bug: 25070434 Change-Id: Iade3472c496ac42456e42db35e402f7b66416f5b (cherry picked from commit b41fd0d4929f0a89811bafcc4fd944b128f00ce2)
224858e719d045c8554856b12c4ab73d2375cf33
android
bigvul
1
null
null
null
DO NOT MERGE - libstagefright: check requested memory size before allocation for SoftMPEG4Encoder and SoftVPXEncoder. Bug: 25812794 Change-Id: I96dc74734380d462583f6efa33d09946f9532809 (cherry picked from commit 87f8cbb223ee516803dbb99699320c2484cbf3ba) (cherry picked from commit 0462975291796e414891e04bcec9da993914e458)
50270d98e26fa18b20ca88216c3526667b724ba7
android
bigvul
1
null
null
null
mm: fix prctl_set_vma_anon_name prctl_set_vma_anon_name could attempt to set the name across two vmas at the same time due to a typo, which might corrupt the vma list. Fix it to use tmp instead of end to limit the name setting to a single vma at a time. Change-Id: Ie32d8ddb0fd547efbeedd6528acdab5ca5b308b4 Reported-by: Jed Davis <[email protected]> Signed-off-by: Colin Cross <[email protected]>
69bfe2d957d903521d32324190c2754cb073be15
android
bigvul
1
null
null
null
Battery saver: limit notification intents to system UI. Ensure the actions taken by the HUN warnings came from sysui. Bug: 20918350 Change-Id: I8dc02ebdfcc1f60d068bea43e10e350dc566728d
05e0705177d2078fa9f940ce6df723312cfab976
android
bigvul
1
null
null
null
DO NOT MERGE Fix security vulnerability in pre-O rild code. Remove wrong code for setup_data_call. Add check for max address for RIL_DIAL. Bug: 37896655 Test: Manual. Change-Id: I05c027140ae828a2653794fcdd94e1b1a130941b (cherry picked from commit dda24c6557911aa1f4708abbd6b2f20f0e205b9e)
cd5f15f588a5d27e99ba12f057245bfe507f8c42
android
bigvul
1
null
null
null
Enforce policy for camera gesture in keyguard If the admin has disabled the camera for secure keyguards, in addition to removing the bottom-right hand corner camera button do not allow the camera to be opened via the camera gesture either. Bug: 63334090 Merged-In: I104688eaad719528376e2851f837d5956a6a1169 Test: Manually tested launching the camera on secure and non-secure keyguard and non-keyguard, both via camera icon and gesture Change-Id: I104688eaad719528376e2851f837d5956a6a1169 (cherry picked from commit 98ec92375d75630c10595bfcbae184ad7350e2d3)
c574568aaede7f652432deb7707f20ae54bbdf9a
android
bigvul
1
null
null
null
Skip track if verification fails Bug: 62187433 Test: ran poc, CTS Change-Id: Ib9b0b6de88d046d8149e9ea5073d6c40ffec7b0c (cherry picked from commit ef8c7830d838d877e6b37b75b47294b064c79397)
8a3a2f6ea7defe1a81bb32b3c9f3537f84749b9d
android
bigvul
1
null
null
null
Fix slice decrement for skipped slices Test: run the poc with and without the patch Bug: 63045918 Change-Id: I27804d42c55480c25303d1a5dbb43b1d86d7fa94 (cherry picked from commit 272f2c23c8ba8579adb0618b4124163b9bf086fb)
87fb7909c49e6a4510ba86ace1ffc83459c7e1b9
android
bigvul
1
null
null
null
Fix memory leak in OggExtractor Test: added a temporal log and run poc Bug: 63581671 Change-Id: I436a08e54d5e831f9fbdb33c26d15397ce1fbeba (cherry picked from commit 63079e7c8e12cda4eb124fbe565213d30b9ea34c)
d07f5c14e811951ff9b411ceb84e7288e0d04aaf
android
bigvul
1
null
null
null
Check buffer size in useBuffer in software components Test: No more crash from oob read/write with running poc. Bug: 63522430 Change-Id: I232d256eacdfaa9347902fe9b42650999f0d2d85 (cherry picked from commit 4e79910fdb303fd28a37a9401bed1b7fbccb1373)
d834160d9759f1098df692b34e6eeb548f9e317b
android
bigvul
1
null
null
null
Add EFFECT_CMD_SET_PARAM parameter checking to Downmix and Reverb Bug: 63662938 Bug: 63526567 Test: Added CTS tests Change-Id: I8ed398cd62a9f461b0590e37f593daa3d8e4dbc4 (cherry picked from commit 804632afcdda6e80945bf27c384757bda50560cb)
f490fc335772a9b14e78997486f4a572b0594c04
android
bigvul
1
null
null
null
Fix out of bounds access in codebook processing Bug: 62800140 Test: ran poc, CTS Change-Id: I9960d507be62ee0a3b0aa991240951d5a0784f37 (cherry picked from commit 2c4c4bd895f01fdecb90ebdd0412b60608a9ccf0)
eeb4e45d5683f88488c083ecf142dc89bc3f0b47
android
bigvul
1
null
null
null
Fix 'potential memory leak' compiler warning. This CL fixes the following compiler warning: frameworks/av/media/libstagefright/SampleTable.cpp:569:9: warning: Memory allocated by 'new[]' should be deallocated by 'delete[]', not 'delete'. Bug: 33137046 Test: Compiled with change; no warning generated. Change-Id: I29abd90e02bf482fa840d1f7206ebbdacf7dfa37 (cherry picked from commit 158c197b668ad684f92829db6a31bee3aec794ba) (cherry picked from commit 37c428cd521351837fccb6864f509f996820b234)
7fa3f552a6f34ed05c15e64ea30b8eed53f77a41
android
bigvul
1
null
null
null
Fix audio record pre-processing proc_buf_out consistently initialized. intermediate scratch buffers consistently initialized. prevent read failure from overwriting memory. Test: POC, CTS, camera record Bug: 62873231 Change-Id: Ie26e12a419a5819c1c5c3a0bcf1876d6d7aca686 (cherry picked from commit 6d7b330c27efba944817e647955da48e54fd74eb)
7df7ec13b1d222ac3a66797fbe432605ea8f973f
android
bigvul
1
null
null
null
Ensure CTB size > 16 for clips with tiles and width/height >= 4096 For clips with tiles and dimensions >= 4096, CTB size of 16 can result in tile position > 255. This is not supported by the decoder Bug: 37930177 Test: ran poc w/o crashing Change-Id: I2f223a124c4ea9bfd98343343fd010d80a5dd8bd (cherry picked from commit 248e72c7a8c7c382ff4397868a6c7453a6453141)
25c0ffbe6a181b4a373c3c9b421ea449d457e6ed
android
bigvul
1
null
null
null
Fixed Memory Overflow Errors In function impeg2d_dec_p_b_slice, there was no check for num_mbs_left == 0 after skip_mbs function call. Hence, even though it should have returned as an error, it goes ahead to decode the frame and writes beyond the buffer allocated for output. Put a check for the same. Bug: 38207066 Test: before/after execution of PoC on angler/nyc-mr2-dev Change-Id: If4b7bea51032bf2fe2edd03f64a68847aa4f6a00 (cherry picked from commit 2df080153464bf57084d68ba3594e199bc140eb4)
7737780815fe523ad7b0e49456eb75d27a30818a
android
bigvul
1
null
null
null
stagefright: avoid buffer overflow in base64 decoder Bug: 62673128 Change-Id: Id5f04b772aaca3184879bd5bca453ad9e82c7f94 (cherry picked from commit 5e96386ab7a5391185f6b3ed9ea06f3e23ed253b)
552a3b5df2a6876d10da20f72e4cc0d44ac2c790
android
bigvul
1
null
null
null
Disable File.getCanonicalPath caches. File.getCanonicalPath has to always return accurate results in all cases, not doing so has potential security implications. Caches may have stale data if underlaying files were modified by another process or code that's not aware of cannonical path cache. Test: vogar ojluni/src/main/java/java/io/FileSystem.java Bug: 62301183 Change-Id: I76b0ca606405a958ebbc57a8a6c08deb53ea1dfc (cherry picked from commit caed7373b2ed858c864a0c108cffd65d051534f7) (cherry picked from commit fef885586207ca90b7e7b717017075a7afaa3974)
809681f310663288e83587089abb7715c68f6924
android
bigvul
1
null
null
null
Fix security hole in GateKeeperResponse. GateKeeperResponse has inconsistent writeToParcel() and createFromParcel() methods, making it possible for a malicious app to create a Bundle that changes contents after reserialization. Such Bundles can be used to execute Intents with system privileges. This CL changes writeToParcel() to make serialization and deserialization consistent, thus fixing the issue. Bug: 62998805 Test: use the debug app (see bug) Change-Id: Ie1c64172c454c3a4b7a0919eb3454f0e38efcd09 (cherry picked from commit e74cae8f7c3e6b12f2bf2b75427ee8f5b53eca3c)
b87c968e5a41a1a09166199bf54eee12608f3900
android
bigvul
1
null
null
null
Check only allocated mv bufs for releasing from reference When checking mv bufs for releasing from reference, unallocated mv bufs were also checked. This issue was fixed by restricting the loop count to allocated number of mv bufs. Bug: 34896906 Bug: 34819017 Change-Id: If832f590b301f414d4cd5206414efc61a70c17cb (cherry picked from commit 23bfe3e06d53ea749073a5d7ceda84239742b2c2)
913d9e8d93d6b81bb8eac3fc2c1426651f5b259d
android
bigvul
1
null
null
null
Limit vpx decoder to 4K frames Bug: 34360591 Change-Id: If66c3498b9a7052219af2dcaa2ef33e1408a8587 (cherry picked from commit 8c714fb5bb5199f6072595c905d226b6f2e858c0)
698796fc930baecf5c3fdebef17e73d5d9a58bcb
android
bigvul
1
null
null
null
Correct Tiles rows and cols check Bug: 36231493 Bug: 34064500 Change-Id: Ib17b2c68360685c5a2c019e1497612a130f9f76a (cherry picked from commit 07ef4e7138e0e13d61039530358343a19308b188)
ebaa71da6362c497310377df509651974401d258
android
bigvul
1
null
null
null
Validate lengths in HEVC metadata parsing Add code to validate the size parameter passed to HecvParameterSets::addNalUnit(). Previously vulnerable to decrementing an unsigned past 0, yielding a huge result value. Bug: 35467107 Test: ran POC, no crash, emitted new "bad length" log entry Change-Id: Ia169b9edc1e0f7c5302e3c68aa90a54e8863d79e (cherry picked from commit e0dcf097cc029d056926029a29419e1650cbdf1b)
523f6b49c1a2289161f40cf9fe80b92e592e9441
android
bigvul
1
null
null
null
Fix integer overflow and divide-by-zero Bug: 35763994 Test: ran CTS with and without fix Change-Id: If835e97ce578d4fa567e33e349e48fb7b2559e0e (cherry picked from commit 8538a603ef992e75f29336499cb783f3ec19f18c)
36b04932bb93cc3269279282686b439a17a89920
android
bigvul
1
null
null
null
Fix NPDs in h263 decoder Bug: 35269635 Test: decoded PoC with and without patch Change-Id: I636a14360c7801cc5bca63c9cb44d1d235df8fd8 (cherry picked from commit 2ad2a92318a3b9daf78ebcdc597085adbf32600d)
961e5ac5788b52304e64b9a509781beaf5201fb0
android
bigvul
1
null
null
null
Handle error return from ref list in slice hdr parsing The error returned by ref_list function was not handled by the caller parse_slice_header. Bug: 34672748 Change-Id: I55f6cb0e651746e77f7ff3375115894ec3964203 (cherry picked from commit 25206ffa6eeb25f32103e69f893287425ab1bd10)
a1424724a00d62ac5efa0e27953eed66850d662f
android
bigvul
1
null
null
null
codecs: handle onReset() for a few encoders Test: Run PoC binaries Bug: 34749392 Bug: 34705519 Change-Id: I3356eb615b0e79272d71d72578d363671038c6dd
5443b57cc54f2e46b35246637be26a69e9f493e1
android
bigvul
1
null
null
null
Add bounds check in SoftAACEncoder2::onQueueFilled() Original code blindly copied some header information into the user-supplied buffer without checking for sufficient space. The code does check when it gets to filling the data -- it's just the header copies that weren't checked. Bug: 34617444 Test: ran POC before/after Change-Id: I6e80ec90616f6cd02bb8316cd2d6e309b7e4729d (cherry picked from commit 6231243626b8b9c57593b1f0ee417f2c4af4c0aa)
594bf934384920618d2b6ce0bcda1f60144cb3eb
android
bigvul
1
null
null
null
FLACExtractor: copy protect mWriteBuffer Bug: 30895578 Change-Id: I4cba36bbe3502678210e5925181683df9726b431
acc192347665943ca674acf117e4f74a88436922
android
bigvul
1
null
null
null
Decoder: Fixed error handling for dangling fields In case of dangling fields with gaps in frames enabled, field pic in cur_slice was wrongly set to 0. This would cause dangling field to be concealed as a frame, which would result in a number of MB mismatch and hence a hang. Bug: 34097672 Change-Id: Ia9b7f72c4676188c45790b2dfbb4fe2c2d2c01f8 (cherry picked from commit 1a13168ca3510ba91274d10fdee46b3642cc9554)
5c3fd5d93a268abb20ff22f26009535b40db3c7d
android
bigvul
1
null
null
null
Return error if SPS parsing reads more bytes than the nal length Bug: 35039946 Change-Id: Ia97fa8711f313d0029d2b13e6d150d5e46b2bb99 (cherry picked from commit a6c58e18a49a1ea4929f8345b3c59f900d5813f5) (cherry picked from commit 232bbe1908d1dd9f10513d7b8065ecaf5c9a11a6)
45c97f878bee15cd97262fe7f57ecea71990fed7
android
bigvul
1
null
null
null
Return error from cabac init if offset is greater than range When the offset was greater than range, the bitstream was read more than the valid range in leaf-level cabac parsing modules. Error check was added to cabac init to fix this issue. Additionally end of slice and slice error were signalled to suppress further parsing of current slice. Bug: 34897036 Change-Id: I1263f1d1219684ffa6e952c76e5a08e9a933c9d2 (cherry picked from commit 3b175da88a1807d19cdd248b74bce60e57f05c6a) (cherry picked from commit b92314c860d01d754ef579eafe55d7377962b3ba)
bcfc7124f6ef9f1ec128fb2e90de774a5b33d199
android
bigvul
1
null
null
null
Fix out of bounds access Bug: 34618607 Change-Id: I84f0ef948414d0b2d54e8948b6c30b8ae4da2b36 (cherry picked from commit d1c19c57f66d91ea8033c8fa6510a8760a6e663b)
6f1d990ce0f116a205f467d9eb2082795e33872b
android
bigvul
1
null
null
null
Fix in handling header decode errors If header decode was unsuccessful, do not try decoding a frame Also, initialize pic_wd, pic_ht for reinitialization when decoder is created with smaller dimensions Bug: 28886651 Bug: 35219737 Change-Id: I8c06d9052910e47fce2e6fe25ad318d4c83d2c50 (cherry picked from commit 2b9fa9ace2dbedfbac026fc9b6ab6cdac7f68c27) (cherry picked from commit c2395cd7cc0c286a66de674032dd2ed26500aef4)
a86eb798d077b9b25c8f8c77e3c02c2f287c1ce7
android
bigvul
1
null
null
null
resolve merge conflicts of 79cf158c51 to mnc-dev Change-Id: Ied32e83215e386c801c02991a0b2fa4baa25b643
50358a80b1724f6cf1bcdf003e1abf9cc141b122
android
bigvul
1
null
null
null
Error Check for VLD Symbols Read The maximum number of lead zeros in a VLD symbol (17 bits long) is 11. Bug: 34093073 Change-Id: Ifd3f64a3a5199d6e4c33ca65449fc396cfb2f3fc (cherry picked from commit 75e0ad5127752ce37e3fc78a156652e5da435f14)
227c1f829127405e21dab1664393050c652ef71e
android
bigvul
1
null
null
null
Check for Valid Frame Rate in Header Bug: 34093952 Change-Id: I9f009edda84555e8d14b138684a38114fb888bf8 (cherry picked from commit 3f068a4e66cc972cf798c79a196099bd7d3bfceb)
f301cff2c1ddd880d9a2c77b22602a137519867b
android
bigvul
1
null
null
null
Decoder: Fixed initialization of first_slice_in_pic To handle some errors, first_slice_in_pic was being set to 2. This is now cleaned up and first_slice_in_pic is set to 1 only once per pic. This will ensure picture level initializations are done only once even in case of error clips Bug: 33717589 Bug: 33551775 Bug: 33716442 Bug: 33677995 Change-Id: If341436b3cbaa724017eedddd88c2e6fac36d8ba
0b23c81c3dd9ec38f7e6806a3955fed1925541a0
android
bigvul
1
null
null
null
Decoder: Return correct error code for slice header errors Return ERROR_INV_SLICE_HDR_T instead of ERROR_INV_SPS_PPS_T for slice header errors. Bug: 34097915 Change-Id: I45d14a71f2322ff349058baaf65fb0f3c1140fba
9a00f562a612d56e7b2b989d168647db900ba6cf
android
bigvul
1
null
null
null
Decoder: Treat first slice in a picture as part of new picture always This is needed to decode streams with consecutive IDRs. Bug: 34097231 Test: successful run of POC in security bug Change-Id: Ib737a4ef4b8c5bb7a57c90292102dd28af0615fe
8b5fd8f24eba5dd19ab2f80ea11a9125aa882ae2
android
bigvul
1
null
null
null
Fix in returning end of bitstream error for MBAFF In case of MBAFF streams, slices should terminate on even MB boundary. If bytes are exhausted with odd number of MBs decoded for MBAff, then treat that as error. Bug: 33933140 Change-Id: Ifc26b66ff8ebdb3aec5c0d6c512e4cac3f54c5b7
7950bf47b6944546a0aff11a7184947de9591b51
android
bigvul
1
null
null
null
resolve merge conflicts of 3654ad0 to mnc-dr-dev Bug: 33818508 Bug: 34013472 Change-Id: I2e99cbceba1c00555d624e8975522725e362362b
37345554fea84afd446d6d8fbb87feea5a0dde3f
android
bigvul
1
null
null
null
Fix overflow check and check read result Bug: 33861560 Test: build Change-Id: Ia85519766e19a6e37237166f309750b3e8323c4e
9667e3eff2d34c3797c3b529370de47b2c1f1bf6
android
bigvul
1
null
null
null