commit_msg
stringlengths 1
24.2k
| commit_hash
stringlengths 2
84
⌀ | project
stringlengths 2
40
| source
stringclasses 4
values | labels
int64 0
1
| repo_url
stringlengths 26
70
⌀ | commit_url
stringlengths 74
118
⌀ | commit_date
stringlengths 25
25
⌀ |
|---|---|---|---|---|---|---|---|
Custom buttons should only handle accelerators when focused.
BUG=541415
Review URL: https://codereview.chromium.org/1437523005
Cr-Commit-Position: refs/heads/master@{#360130} | 297ae873b471a46929ea39697b121c0b411434ee | chrome | bigvul | 1 | null | null | null |
CSP: Source expressions can no longer lock sites into insecurity.
CSP's matching algorithm has been updated to make clever folks like Yan
slightly less able to gather data on user's behavior based on CSP
reports[1]. This matches Firefox's existing behavior (they apparently
changed this behavior a few months ago, via a happy accident[2]), and
mitigates the CSP-variant of Sniffly[3].
On the dashboard at https://www.chromestatus.com/feature/6653486812889088.
[1]: https://github.com/w3c/webappsec-csp/commit/0e81d81b64c42ca3c81c048161162b9697ff7b60
[2]: https://bugzilla.mozilla.org/show_bug.cgi?id=1218524#c2
[3]: https://bugzilla.mozilla.org/show_bug.cgi?id=1218778#c7
BUG=544765,558232
Review URL: https://codereview.chromium.org/1455973003
Cr-Commit-Position: refs/heads/master@{#360562} | 568075bbc5d16239a5cbdeb579a8768f9836f13e | chrome | bigvul | 1 | null | null | null |
Add assertions that the empty Platform::cryptographicallyRandomValues() overrides are not being used.
These implementations are not safe and look scary if not accompanied by an assertion. Also one of the comments was incorrect.
BUG=552749
Review URL: https://codereview.chromium.org/1419293005
Cr-Commit-Position: refs/heads/master@{#359229} | 0d151e09e13a704e9738ea913d117df7282e6c7d | chrome | bigvul | 1 | null | null | null |
Add SmbUrl class
Adds SmbUrl class which is used to represent Smb URLs. Includes unit
tests.
Bug: 757625
Change-Id: I2105f08a0df55dbaa0d50b1637d419a6cf5335f7
Reviewed-on: https://chromium-review.googlesource.com/1048745
Reviewed-by: Zentaro Kavanagh <[email protected]>
Commit-Queue: Allen Vicencio <[email protected]>
Cr-Commit-Position: refs/heads/master@{#557223} | 9f11faaa13c0238b5d29cfe312149987119bca92 | chrome | bigvul | 1 | null | null | null |
Fix GPU process fallback logic.
1. In GpuProcessHost::OnProcessCrashed() record the process crash first.
This means the GPU mode fallback will happen before a new GPU process
is started.
2. Don't call FallBackToNextGpuMode() if GPU process initialization
fails for an unsandboxed GPU process. The unsandboxed GPU is only
used for collect information and it's failure doesn't indicate a need
to change GPU modes.
Bug: 869419
Change-Id: I8bd0a03268f0ea8809f3df8458d4e6a92db9391f
Reviewed-on: https://chromium-review.googlesource.com/1157164
Reviewed-by: Zhenyao Mo <[email protected]>
Commit-Queue: kylechar <[email protected]>
Cr-Commit-Position: refs/heads/master@{#579625} | b90c7c8c335a2e2a4abdd7bde17a44f92c8b3a54 | chrome | bigvul | 1 | null | null | null |
[Extensions] Expand bindings access checks
BUG=601149
BUG=601073
Review URL: https://codereview.chromium.org/1866103002
Cr-Commit-Position: refs/heads/master@{#387710} | c0569cc04741cccf6548c2169fcc1609d958523f | chrome | bigvul | 1 | null | null | null |
Disable frame navigations during DocumentLoader detach in FrameLoader::startLoad
BUG=613266
Review-Url: https://codereview.chromium.org/2006033002
Cr-Commit-Position: refs/heads/master@{#396241} | 1948aefa8901dca0ccb993753fca00b15d2a6e25 | chrome | bigvul | 1 | null | null | null |
[Extensions] Finish freezing schema
BUG=604901
BUG=603725
BUG=591164
Review URL: https://codereview.chromium.org/1906593002
Cr-Commit-Position: refs/heads/master@{#388945} | 5fb2548448bd1b76a59d941b729d7a7f90d53bc8 | chrome | bigvul | 1 | null | null | null |
[DevTools] Sanitize remoteFrontendUrl for old frontends.
BUG=607939
Review-Url: https://codereview.chromium.org/1983933002
Cr-Commit-Position: refs/heads/master@{#393952} | c5eecf67fd8d5e8d24d2d4d9489753d2c8cf6c59 | chrome | bigvul | 1 | null | null | null |
Create array of extension views without side effects
BUG=608104
Review-Url: https://codereview.chromium.org/1935953002
Cr-Commit-Position: refs/heads/master@{#390961} | aa7a889002dd7a1288cc5e962086e517131fb01e | chrome | bigvul | 1 | null | null | null |
[perf] Add load:search:google:2018 system health story
This CL was created automatically with tools/perf/update_wpr script
Bug: 878390
[email protected]
Change-Id: I65300d654439ed65591691f5881cd8b1002c913c
Reviewed-on: https://chromium-review.googlesource.com/c/1329665
Commit-Queue: Camillo Bruni <[email protected]>
Reviewed-by: Juan Antonio Navarro Pérez <[email protected]>
Cr-Commit-Position: refs/heads/master@{#608101} | 31bdb48c93335949c0c7b739e41de2628205a3cc | chrome | bigvul | 1 | null | null | null |
Update Windows order files ahead of M72 branch
Bug: none
Change-Id: Ic8355b94db77c728535a68fd00947d44422b4604
Reviewed-on: https://chromium-review.googlesource.com/c/1341908
Reviewed-by: Nico Weber <[email protected]>
Commit-Queue: Hans Wennborg <[email protected]>
Cr-Commit-Position: refs/heads/master@{#609260} | 974c5e4a6adbbeb76fef281a17dd59efefa83ce5 | chrome | bigvul | 1 | null | null | null |
P2PQuicStream write functionality.
This adds the P2PQuicStream::WriteData function and adds tests. It also
adds the concept of a write buffered amount, enforcing this at the
P2PQuicStreamImpl.
Bug: 874296
Change-Id: Id02c8aa8d5368a87bb24a2e50dab5ef94bcae131
Reviewed-on: https://chromium-review.googlesource.com/c/1315534
Commit-Queue: Seth Hampson <[email protected]>
Reviewed-by: Henrik Boström <[email protected]>
Cr-Commit-Position: refs/heads/master@{#605766} | 350f7d4b2c76950c8e7271284de84a9756b796e1 | chrome | bigvul | 1 | null | null | null |
Use correct creation context during Iterable.forEach iteration
Use |thisValue| instead of |scriptState->context()->Global()|, since this
is simpler and since Global() actually returns a WindowProxy object that
may change and become incorrect to use as creation context depending on
what the callback function does.
BUG=605910
Review URL: https://codereview.chromium.org/1918763002
Cr-Commit-Position: refs/heads/master@{#389785} | 0cd7a9f853e3cb7c035b4ab9e07a503552267f9d | chrome | bigvul | 1 | null | null | null |
[Nav Experiment] Implement GetVisibleItem().
Also tweaked DCHECK in CRWWebController because |webViewNavigationProxy|
should return nil instead of triggering DCHECK if the underlying web
view is not set.
Bug: 734150
Change-Id: I83b501de1551aca36014a6f2f304230dab0aac69
Reviewed-on: https://chromium-review.googlesource.com/606115
Commit-Queue: Danyao Wang <[email protected]>
Reviewed-by: Kurt Horimoto <[email protected]>
Reviewed-by: Eugene But <[email protected]>
Cr-Commit-Position: refs/heads/master@{#492754} | 3847be90de19869704f4865331e5f9baff7ae5f0 | chrome | bigvul | 1 | null | null | null |
Block a compromised renderer from reusing request ids.
BUG=578882
Review URL: https://codereview.chromium.org/1608573002
Cr-Commit-Position: refs/heads/master@{#372547} | 1af4fada49c4f3890f16daac31d38379a9d782b2 | chrome | bigvul | 1 | null | null | null |
[base] Make dynamic container to static span conversion explicit
This change disallows implicit conversions from dynamic containers to
static spans. This conversion can cause CHECK failures, and thus should
be done carefully. Requiring explicit construction makes it more obvious
when this happens. To aid usability, appropriate base::make_span<size_t>
overloads are added.
Bug: 877931
Change-Id: Id9f526bc57bfd30a52d14df827b0445ca087381d
Reviewed-on: https://chromium-review.googlesource.com/1189985
Reviewed-by: Ryan Sleevi <[email protected]>
Reviewed-by: Balazs Engedy <[email protected]>
Reviewed-by: Daniel Cheng <[email protected]>
Commit-Queue: Jan Wilken Dörrie <[email protected]>
Cr-Commit-Position: refs/heads/master@{#586657} | 9cfe470d793da6e09b966d435c8fa2ba1625d5fe | chrome | bigvul | 1 | null | null | null |
Use install_static::GetAppGuid instead of the hardcoded string in BrandcodeConfigFetcher.
Bug: 769756
Change-Id: Ifdcb0a5145ffad1d563562e2b2ea2390ff074cdc
Reviewed-on: https://chromium-review.googlesource.com/1213178
Reviewed-by: Dominic Battré <[email protected]>
Commit-Queue: Vasilii Sukhanov <[email protected]>
Cr-Commit-Position: refs/heads/master@{#590275} | 7c5aa07be11cd63d953fbe66370c5869a52170bf | chrome | bigvul | 1 | null | null | null |
Roll PDFium 5526501..3cc1802
https://pdfium.googlesource.com/pdfium.git/+log/5526501..3cc1802
[email protected]
BUG=591785,589724
TEST=bots
Review URL: https://codereview.chromium.org/1806673002
Cr-Commit-Position: refs/heads/master@{#381250} | 83dfeae5a988dbd17f11b409f32ef577be02c152 | chrome | bigvul | 1 | null | null | null |
Use an opaque URL rather than an empty URL for request's site for cookies.
Apparently this makes a big difference to the cookie settings backend.
Bug: 881715
Change-Id: Id87fa0c6a858bae6a3f8fff4d6af3f974b00d5e4
Reviewed-on: https://chromium-review.googlesource.com/1212846
Commit-Queue: Mike West <[email protected]>
Reviewed-by: Camille Lamy <[email protected]>
Cr-Commit-Position: refs/heads/master@{#589512} | 8355de453bb4014b74b2db5d7ca38c5664d65d83 | chrome | bigvul | 1 | null | null | null |
Disable rendering.mobile/yahoo_answers_mobile_2018 on webview platforms
Bug:873013
NOTRY=true
[email protected], [email protected]
Change-Id: I191cc697f66945c327c2c8a4bdf5ecb1029e041b
Reviewed-on: https://chromium-review.googlesource.com/1170359
Reviewed-by: Ned Nguyen <[email protected]>
Commit-Queue: Ned Nguyen <[email protected]>
Cr-Commit-Position: refs/heads/master@{#582008} | 815783d185d17e905dfc23cadf240c05c9aff074 | chrome | bigvul | 1 | null | null | null |
Fix a crash when download a DRM file through context menu
This is a regression introduced by
https://codereview.chromium.org/1717783002.
Previously we use URLUtil.guessFileName() to generate file names for
download.
However, to fix crbug/570750, we rely on the native code to pass the
file name.
However, drm download through context menu bypasses the native download
code.
As a result, we need to generate the file name in Java if it is null.
Since content disposition is null, this will not cause the same problem
as reported in crbug/570750.
BUG=608258
Review-Url: https://codereview.chromium.org/2013643002
Cr-Commit-Position: refs/heads/master@{#395750} | 4e33c5d6978752f31ed6702e72e46fdf78cd5565 | chrome | bigvul | 1 | null | null | null |
Revert "Update fontconfig to 6cc99d6a"
This reverts commit e6db40d91d0bd2afeb39f78f6d22404c3525b63c.
Reason for revert:
Findit (https://goo.gl/kROfz5) identified CL at revision 567445 as the
culprit for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2U2ZGI0MGQ5MWQwYmQyYWZlYjM5Zjc4ZjZkMjI0MDRjMzUyNWI2M2MM
Sample Failed Build: https://ci.chromium.org/buildbot/chromium.linux/Linux%20Builder%20%28dbg%29%2832%29/83483
Sample Failed Step: compile
Original change's description:
> Update fontconfig to 6cc99d6a
>
> Changelog [1]. This is necessary to pick up [2] for fixing undefined-shift
> UBSAN errors detected by clusterfuzz, [3] to allow removing a build workaround,
> [4] to fix a bug and clean up some log spam, [5] to fix CFI builds, and [6] to
> fix a use-after-free.
>
> Fontconfig also now requires libuuid as a dependency, so whitelist it as a
> dependency since we statically link fontconfig.
>
> [1] https://chromium.googlesource.com/external/fontconfig/+log/b546940435ebfb0df575bc7a2350d1e913919c34..6cc99d6a82ad67d2f5eac887b28bca13c0dfddde
> [2] https://chromium.googlesource.com/external/fontconfig/+/c60ed9ef66e59584f8b54323018e9e6c69925c7e
> [3] https://chromium.googlesource.com/external/fontconfig/+/b8a225b3c3495942480377b7b3404710c70be914
> [4] https://chromium.googlesource.com/external/fontconfig/+/7ad010e80bdf8e41303e322882ece908f5e04c74
> [5] https://chromium.googlesource.com/external/fontconfig/+/096e8019be595c2224aaabf98da630ee917ee51c
> [6] https://chromium.googlesource.com/external/fontconfig/+/6cc99d6a82ad67d2f5eac887b28bca13c0dfddde
>
> BUG=831146,822737,787020,829890,847323
> TBR=thestig,dnicoara
>
> Change-Id: Ic2d1bd19af8ca131c960a30d09246827c115ccec
> Reviewed-on: https://chromium-review.googlesource.com/1095538
> Commit-Queue: Thomas Anderson <[email protected]>
> Reviewed-by: Thomas Anderson <[email protected]>
> Reviewed-by: Lei Zhang <[email protected]>
> Reviewed-by: Daniel Nicoara <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#567445}
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
BUG=831146,822737,787020,829890,847323
Change-Id: I47d475941350efc76370fa5eb5043c80c5063495
Reviewed-on: https://chromium-review.googlesource.com/1101759
Cr-Commit-Position: refs/heads/master@{#567472} | f5ad97cbf2b2b465dc61d8f93820c7e6cab49e4e | chrome | bigvul | 1 | null | null | null |
Make extensions use a correct same-origin check.
GURL::GetOrigin does not do the right thing for all types of URLs.
BUG=573317
Review URL: https://codereview.chromium.org/1658913002
Cr-Commit-Position: refs/heads/master@{#373381} | 5c437bcc7a51edbef45242c5173cf7871fde2866 | chrome | bigvul | 1 | null | null | null |
[chromium.perf.fyi] Switch android bots to run Chrome.apk
Switching fyi bots from android-chromium to android-chrome.
Bug: 817842
Change-Id: Ic73ae26ff4630b074d3bfd1cc08d7e5b80504e4a
Reviewed-on: https://chromium-review.googlesource.com/c/1299075
Reviewed-by: Emily Hanley <[email protected]>
Reviewed-by: Annie Sullivan <[email protected]>
Commit-Queue: Juan Antonio Navarro Pérez <[email protected]>
Cr-Commit-Position: refs/heads/master@{#602697} | ddbe71f6c0b05435a4d3a5c82e394d660e7d6a6d | chrome | bigvul | 1 | null | null | null |
ImageInputType::ensurePrimaryContent should recreate UA shadow tree.
Once the fallback shadow tree was created, it was never recreated even if
ensurePrimaryContent was called. Such situation happens by updating |src|
attribute.
BUG=589838
Review URL: https://codereview.chromium.org/1732753004
Cr-Commit-Position: refs/heads/master@{#377804} | 2386a6a49ea992a1e859eb0296c1cc53e5772cdb | chrome | bigvul | 1 | null | null | null |
Rephrase IDS_USED_EXISTING_BROWSER
The message erroneously used to say a new window was created, which is
not necessarily the case. It could also be a new tab, or probably
other things depending on what command-line flags are passed.
TEST=$ ( ./chrome & ) ; ./chrome
Bug: none
Change-Id: I03de1c333561c3f728b910a78520da30947d357c
Reviewed-on: https://chromium-review.googlesource.com/1219229
Reviewed-by: Greg Thompson <[email protected]>
Reviewed-by: Nico Weber <[email protected]>
Commit-Queue: Hans Wennborg <[email protected]>
Cr-Commit-Position: refs/heads/master@{#590620} | 573594075458f72254d1af91e2da65ac009053e0 | chrome | bigvul | 1 | null | null | null |
Roll PDFium e4ac336..28de044
https://pdfium.googlesource.com/pdfium.git/+log/e4ac336..28de044
[email protected]
BUG=587227
Review URL: https://codereview.chromium.org/1728813002
Cr-Commit-Position: refs/heads/master@{#377136} | 7045ee0a8b4b19d298c67556ee0b92cd575e1303 | chrome | bigvul | 1 | null | null | null |
[Extensions] Don't allow built-in extensions code to be overridden
BUG=546677
Review URL: https://codereview.chromium.org/1417513003
Cr-Commit-Position: refs/heads/master@{#356654} | 83a4b3aa72d98fe4176b4a54c8cea227ed966570 | chrome | bigvul | 1 | null | null | null |
Cherry pick underflow fix.
BUG=583607
Review URL: https://codereview.chromium.org/1662313002
Cr-Commit-Position: refs/heads/master@{#373736} | 7716418a27d561ee295a99f11fd3865580748de2 | chrome | bigvul | 1 | null | null | null |
Remove some unused includes in headless/
Bug:
Change-Id: Icb5351bb6112fc89e36dab82c15f32887dab9217
Reviewed-on: https://chromium-review.googlesource.com/720594
Reviewed-by: David Vallet <[email protected]>
Commit-Queue: Iris Uy <[email protected]>
Cr-Commit-Position: refs/heads/master@{#509313} | 41cc463ecc5f0ba708a2c8282a7e7208ca7daa57 | chrome | bigvul | 1 | null | null | null |
Roll PDFium 32b639d..4a2aa1a
https://pdfium.googlesource.com/pdfium.git/+log/32b639d..4a2aa1a
[email protected]
BUG=571480
Review URL: https://codereview.chromium.org/1602333002
Cr-Commit-Position: refs/heads/master@{#370257} | d034f8b939b3f53e47dfb3e2675acb223748e02b | chrome | bigvul | 1 | null | null | null |
Roll PDFium bd292ae..32b639d
https://pdfium.googlesource.com/pdfium.git/+log/bd292ae..32b639d
BUG=571479
[email protected]
Review URL: https://codereview.chromium.org/1588023004
Cr-Commit-Position: refs/heads/master@{#369573} | 1ff50baacf794ebc38bde4da1f08da1c0a5b1818 | chrome | bigvul | 1 | null | null | null |
Added Accessibility EG Tests for Download Manager UI.
Added the following tests:
- testAccessibilityOnNotStartedDownloadToolbar
- testAccessibilityOnCompletedDownloadToolbar
Bug: 854232
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I2c49197f02881548cdae817a9753798507ddfc3b
Reviewed-on: https://chromium-review.googlesource.com/1184323
Reviewed-by: Kurt Horimoto <[email protected]>
Commit-Queue: Eugene But <[email protected]>
Cr-Commit-Position: refs/heads/master@{#585517} | b4dc5a2e469b1348240ca9d2ec0385852ee4e5fd | chrome | bigvul | 1 | null | null | null |
cros: Enable some tests in //ash/wm in ash_unittests --mash
For the ones that fail, disable them via filter file instead of in the
code, per our disablement policy.
Bug: 698085, 695556, 698878, 698888, 698093, 698894
Test: ash_unittests --mash
Change-Id: Ic145ab6a95508968d6884d14fac2a3ca08888d26
Reviewed-on: https://chromium-review.googlesource.com/752423
Commit-Queue: James Cook <[email protected]>
Reviewed-by: Steven Bennetts <[email protected]>
Cr-Commit-Position: refs/heads/master@{#513836} | f8675cbb337440a11bf9afb10ea11bae42bb92cb | chrome | bigvul | 1 | null | null | null |
Reset ES3 pixel pack parameters and PIXEL_PACK_BUFFER binding in DrawingBuffer before ReadPixels() and recover them later.
BUG=740603
TEST=new conformance test
[email protected],[email protected]
Change-Id: I3ea54c6cc34f34e249f7c8b9f792d93c5e1958f4
Reviewed-on: https://chromium-review.googlesource.com/570840
Reviewed-by: Antoine Labour <[email protected]>
Reviewed-by: Kenneth Russell <[email protected]>
Commit-Queue: Zhenyao Mo <[email protected]>
Cr-Commit-Position: refs/heads/master@{#486518} | f6ac1dba5e36f338a490752a2cbef3339096d9fe | chrome | bigvul | 1 | null | null | null |
Roll src/third_party/skia/ 71f867c22..6229b1240 (24 commits)
https://skia.googlesource.com/skia.git/+log/71f867c22946..6229b1240aae
$ git log 71f867c22..6229b1240 --date=short --no-merges --format='%ad %ae %s'
2017-07-24 bungeman Control crash ArenaAlloc for unsatisfiable requests.
2017-07-24 robertphillips Fifth small fragment from "Reduce dependence on GrSurface's origin field"
2017-07-24 robertphillips Fourth fragment from "Reduce dependence on GrSurface's origin field"
2017-07-24 mtklein sprinkle more tracing in GM, tests, and ok, and add TRACE_FUNC
2017-07-24 robertphillips Third small fragment from "Reduce dependence on GrSurface's origin field"
2017-07-24 kjlubick Remove Ci20 MIPS devices
2017-07-24 mtklein ok, basic tracing support
2017-07-24 jvanverth Add temporary fix for DrawShadowRec bounds.
2017-07-24 mtklein ok, do not print time or memory use for skipped tests
2017-07-24 brianosman Quick documentation of tracing support in our tools
2017-07-24 brianosman Faster, thread-safe implementation
2017-07-21 reed remove guard for tiling
2017-07-24 bungeman Don't use fonts with many glyphs in fontmgr_bounds.
2017-07-24 mtklein add suggested decode color type to colorspaceinfo
2017-07-24 mtklein Don't write .pdfs in DM on the bots.
2017-07-24 ethannicholas SPIR-V geometry shader support
2017-07-24 bsalomon Make GrProcessorTestFactory be templated on smart ptr class rather than processor class.
2017-07-24 kjlubick Align const pointer casts in SkRect
2017-07-24 bungeman Revert "pass surface to device-manager"
2017-07-18 ethannicholas SPIR-V array constructors
2017-07-21 ethannicholas SPIR-V matrix fixes
2017-07-21 bsalomon Remove unused function GrDrawOp::DumpPipelineInfo
2017-07-21 robertphillips Second small fragment from "Reduce dependence on GrSurface's origin field"
2017-07-22 reed remove (unused?) arcto patheffect
Created with:
roll-dep src/third_party/skia
BUG=747043
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
[email protected]
Change-Id: Iad5299e6ac4f91fff1d0aafc8d9764a5c5acfa45
Reviewed-on: https://chromium-review.googlesource.com/584109
Reviewed-by: Skia Deps Roller <[email protected]>
Commit-Queue: Skia Deps Roller <[email protected]>
Cr-Commit-Position: refs/heads/master@{#489222} | 3627803d756424daa364c12ecee224b0362d564d | chrome | bigvul | 1 | null | null | null |
Desktop Page Info/Harmony: Show close button for internal pages.
The Harmony version of Page Info for internal Chrome pages (chrome://,
chrome-extension:// and view-source:// pages) show a close button. Update the
code to match this.
This patch also adds TestBrowserDialog tests for the latter two cases described
above (internal extension and view source pages).
See screenshot -
https://drive.google.com/file/d/18RZnMiHCu-rCX9N6DLUpu4mkFWguh1xm/view?usp=sharing
Bug: 535074
Change-Id: I55e5f1aa682fd4ec85f7b65ac88f5a4f5906fe53
Reviewed-on: https://chromium-review.googlesource.com/759624
Commit-Queue: Patti <[email protected]>
Reviewed-by: Trent Apted <[email protected]>
Cr-Commit-Position: refs/heads/master@{#516624} | acf2f0799f6f732dd70f45ddd252d773be7afd11 | chrome | bigvul | 1 | null | null | null |
Inherit CSP when we inherit the security origin
This prevents attacks that use main window navigation to get out of the
existing csp constraints such as the related bug
Bug: 747847
Change-Id: I1e57b50da17f65d38088205b0a3c7c49ef2ae4d8
Reviewed-on: https://chromium-review.googlesource.com/592027
Reviewed-by: Mike West <[email protected]>
Commit-Queue: Andy Paicu <[email protected]>
Cr-Commit-Position: refs/heads/master@{#492333} | 0ab2412a104d2f235d7b9fe19d30ef605a410832 | chrome | bigvul | 1 | null | null | null |
bindings: Support "attribute FrozenArray<T>?"
Adds a quick hack to support a case of "attribute FrozenArray<T>?".
Bug: 1028047
Change-Id: Ib3cecc4beb6bcc0fb0dbc667aca595454cc90c86
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933866
Reviewed-by: Hitoshi Yoshida <[email protected]>
Commit-Queue: Yuki Shiino <[email protected]>
Cr-Commit-Position: refs/heads/master@{#718676} | b7277af490d28ac7f802c015bb0ff31395768556 | chrome | bigvul | 1 | null | null | null |
[IndexedDB] Fix Cursor UAF
If the connection is closed before we return a cursor, it dies in
IndexedDBCallbacks::IOThreadHelper::SendSuccessCursor. It's deleted on
the correct thread, but we also need to makes sure to remove it from its
transaction.
To make things simpler, we have the cursor remove itself from its
transaction on destruction.
R: [email protected]
Bug: 728887
Change-Id: I8c76e6195c2490137a05213e47c635d12f4d3dd2
Reviewed-on: https://chromium-review.googlesource.com/526284
Commit-Queue: Daniel Murphy <[email protected]>
Reviewed-by: Victor Costan <[email protected]>
Cr-Commit-Position: refs/heads/master@{#477504} | d007b8b750851fe1b375c463009ea3b24e5c021d | chrome | bigvul | 1 | null | null | null |
Validate in-process plugin instance messages.
Bug: 733548, 733549
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation
Change-Id: Ie5572c7bcafa05399b09c44425ddd5ce9b9e4cba
Reviewed-on: https://chromium-review.googlesource.com/538908
Commit-Queue: Bill Budge <[email protected]>
Reviewed-by: Raymes Khoury <[email protected]>
Cr-Commit-Position: refs/heads/master@{#480696} | 66b99f3fe60dce77f079cc9c07164f6a34dbea37 | chrome | bigvul | 1 | null | null | null |
If JavaScript shows a dialog, cause the page to lose fullscreen.
BUG=670135, 550017, 726761, 728276
Review-Url: https://codereview.chromium.org/2906133004
Cr-Commit-Position: refs/heads/master@{#478884} | 0720b02e4f303ea6b114d4ae9453e3a7ff55f8dc | chrome | bigvul | 1 | null | null | null |
SkiaRenderer: Support changing color space
SkiaOutputSurfaceImpl did not handle the color space changing after it
was created previously. The SkSurfaceCharacterization color space was
only set during the first time Reshape() ran when the charactization is
returned from the GPU thread. If the color space was changed later the
SkSurface and SkDDL color spaces no longer matched and draw failed.
Bug: 1009452
Change-Id: Ib6d2083efc7e7eb6f94782342e92a809b69d6fdc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841811
Reviewed-by: Peng Huang <[email protected]>
Commit-Queue: kylechar <[email protected]>
Cr-Commit-Position: refs/heads/master@{#702946} | 41f5b55ab27da6890af96f2f8f0f6dd5bc6cc93c | chrome | bigvul | 1 | null | null | null |
Roll src/third_party/pdfium/ 957480c17..f0f2a2a52 (4 commits)
https://pdfium.googlesource.com/pdfium.git/+log/957480c17682..f0f2a2a528e1
$ git log 957480c17..f0f2a2a52 --date=short --no-merges --format='%ad %ae %s'
2017-06-13 thestig Fix a buffer overflow in FPDFPage_Flatten().
2017-06-13 thestig Fix some nits in CFFL_InteractiveFormFiller.
2017-06-13 thestig Remove deprecated FPDPage_HasFormFieldAtPoint().
2017-06-13 thestig Fix bad format string in CXFA_FM2JSContext.
Created with:
roll-dep src/third_party/pdfium
BUG=732661,732533
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls
[email protected]
Change-Id: I7e46b976b0bf8b8de2df9e9f77d5ba2957698833
Reviewed-on: https://chromium-review.googlesource.com/534941
Reviewed-by: <[email protected]>
Commit-Queue: <[email protected]>
Cr-Commit-Position: refs/heads/master@{#479430} | 45576f3a4a01bf8095a8934f8851983a93e31825 | chrome | bigvul | 1 | null | null | null |
Roll src/third_party/SPIRV-Tools/src 3e4abc9ac382..12e54dae167c (1 commits)
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/3e4abc9ac382..12e54dae167c
git log 3e4abc9ac382..12e54dae167c --date=short --no-merges --format='%ad %ae %s'
2019-11-12 [email protected] Update Offset to ConstOffset bitmask if operand is constant. (#3024)
Created with:
gclient setdep -r src/third_party/SPIRV-Tools/src@12e54dae167c
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/spirv-tools-chromium-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64
[email protected],[email protected]
Bug: None
Change-Id: I2323c371aadb7bcedc8cf0d889320626154036a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911685
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/master@{#714442} | 70f2da55aa80a2d6dff890139ae39f78c019e4ea | chrome | bigvul | 1 | null | null | null |
Roll src/third_party/skia/ 51b2f1b64..d96ed9d0d (2 commits)
https://skia.googlesource.com/skia.git/+log/51b2f1b64c4d..d96ed9d0def2
$ git log 51b2f1b64..d96ed9d0d --date=short --no-merges --format='%ad %ae %s'
2017-07-11 herb Experimental blur code.
2017-07-11 bungeman Check first deserialized verb of path is a move.
Created with:
roll-dep src/third_party/skia
BUG=740789
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
[email protected]
Change-Id: Ieacea59c9b71b45e1ab7ac21194f69d5bc37e131
Reviewed-on: https://chromium-review.googlesource.com/567813
Reviewed-by: Skia Deps Roller <[email protected]>
Commit-Queue: Skia Deps Roller <[email protected]>
Cr-Commit-Position: refs/heads/master@{#485847} | 55770ba5393da70bdde69f7f30dd9f31a3d576ff | chrome | bigvul | 1 | null | null | null |
Roll Fuchsia SDK from 889609978376 to 889608822076
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
Tbr: [email protected]
Change-Id: I8b455af32e5abe7842b35b726b4f6d7f9ff4bf4c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931164
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/master@{#718292} | 35fa6a3bac35eb0a344077d87e8029fbc9c6735a | chrome | bigvul | 1 | null | null | null |
media: remove base::SharedMemoryHandle usage in v4l2 encoder
This replaces a use of the legacy UnalignedSharedMemory ctor
taking a SharedMemoryHandle with the current ctor taking a
PlatformSharedMemoryRegion.
Bug: 849207
Change-Id: Iea24ebdcd941cf2fa97e19cf2aeac1a18f9773d9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697602
Commit-Queue: Matthew Cary (CET) <[email protected]>
Reviewed-by: Ricky Liang <[email protected]>
Cr-Commit-Position: refs/heads/master@{#681740} | 29734f46c6dc9362783091180c2ee279ad53637f | chrome | bigvul | 1 | null | null | null |
Don't show current RenderWidgetHostView while interstitial is showing.
Also moves interstitial page tracking from RenderFrameHostManager to
WebContents, since interstitial pages are not frame-specific. This was
necessary for subframes to detect if an interstitial page is showing.
BUG=729105
TEST=See comment 13 of bug for repro steps
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
Review-Url: https://codereview.chromium.org/2938313002
Cr-Commit-Position: refs/heads/master@{#480117} | adca986a53b31b6da4cb22f8e755f6856daea89a | chrome | bigvul | 1 | null | null | null |
sqlite: safely move pointer values through SQL.
This lands https://www.sqlite.org/src/timeline?c=d6a44b35 in
third_party/sqlite/src/ and
third_party/sqlite/patches/0013-Add-new-interfaces-sqlite3_bind_pointer-sqlite3_resu.patch
and re-generates third_party/sqlite/amalgamation/* using the script at
third_party/sqlite/google_generate_amalgamation.sh.
The CL also adds a layout test that verifies the patch works as intended.
BUG=742407
Change-Id: I2e1a457459cd2e975e6241b630e7b79c82545981
Reviewed-on: https://chromium-review.googlesource.com/572976
Reviewed-by: Chris Mumford <[email protected]>
Commit-Queue: Victor Costan <[email protected]>
Cr-Commit-Position: refs/heads/master@{#487275} | 3bfe67c9c4b45eb713326aae7a67c8f7390dae08 | chrome | bigvul | 1 | null | null | null |
Disallow Arabic/Hebrew NSMs to come after an unrelated base char.
Arabic NSM(non-spacing mark)s and Hebrew NSMs are allowed to mix with
Latin with the current 'moderately restrictive script mixing policy'.
They're not blocked by BiDi check either because both LTR and RTL labels
can have an NSM.
Block them from coming after an unrelated script (e.g. Latin + Arabic
NSM).
Bug: chromium:729979
Test: components_unittests --gtest_filter=*IDNToUni*
Change-Id: I5b93fbcf76d17121bf1baaa480ef3624424b3317
Reviewed-on: https://chromium-review.googlesource.com/528348
Reviewed-by: Peter Kasting <[email protected]>
Commit-Queue: Jungshik Shin <[email protected]>
Cr-Commit-Position: refs/heads/master@{#478205} | 536f72f4eeb63af895ee489c7244ccf2437cd157 | chrome | bigvul | 1 | null | null | null |
[AW] Dev UI: Use lambda expression for listeners
Bug: N/A
Test: compile and manually tap UI elements to copy
Change-Id: I69690788734f627cd24adff8eb8309817fe0eba6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911753
Auto-Submit: Hazem Ashmawy <[email protected]>
Reviewed-by: Richard Coles <[email protected]>
Commit-Queue: Hazem Ashmawy <[email protected]>
Cr-Commit-Position: refs/heads/master@{#714628} | 23898e8052bfa5a5cbf48d75e7ae97f42de3d86d | chrome | bigvul | 1 | null | null | null |
[Lock Screen Media Controls] Tweak UI based on new mocks
This CL rearranges the different components of the CrOS lock screen
media controls based on the newest mocks. This involves resizing most
of the child views and their spacings. The artwork was also resized
and re-positioned. Additionally, the close button was moved from the
main view to the header row child view.
Artist and title data about the current session will eventually be
placed to the right of the artwork, but right now this space is empty.
See the bug for before and after pictures.
Bug: 991647
Change-Id: I7b97f31982ccf2912bd2564d5241bfd849d21d92
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1746554
Reviewed-by: Xiyuan Xia <[email protected]>
Reviewed-by: Becca Hughes <[email protected]>
Commit-Queue: Mia Bergeron <[email protected]>
Cr-Commit-Position: refs/heads/master@{#686253} | c25b198675380f713a56649c857b4367601d4a3d | chrome | bigvul | 1 | null | null | null |
autofocus: Fix a crash with an autofocus element in a document without browsing context.
ShouldAutofocus() should check existence of the browsing context.
Otherwise, doc.TopFrameOrigin() returns null.
Before crrev.com/695830, ShouldAutofocus() was called only for
rendered elements. That is to say, the document always had
browsing context.
Bug: 1003228
Change-Id: I2a941c34e9707d44869a6d7585dc7fb9f06e3bf4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1800902
Commit-Queue: Kent Tamura <[email protected]>
Reviewed-by: Keishi Hattori <[email protected]>
Cr-Commit-Position: refs/heads/master@{#696291} | 5cb799a393ba9e732f89f687ff3a322b4514ebfb | chrome | bigvul | 1 | null | null | null |
Revert "Creates a WebUI-based Crostini Upgrader"
This reverts commit 29c8bb394dd8b8c03e006efb39ec77fc42f96900.
Reason for revert:
Findit (https://goo.gl/kROfz5) identified CL at revision 717476 as the
culprit for failures in the build cycles as shown on:
https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzI5YzhiYjM5NGRkOGI4YzAzZTAwNmVmYjM5ZWM3N2ZjNDJmOTY5MDAM
Sample Failed Build: https://ci.chromium.org/b/8896211200981346592
Sample Failed Step: compile
Original change's description:
> Creates a WebUI-based Crostini Upgrader
>
> The UI is behind the new crostini-webui-upgrader flag
> (currently disabled by default)
>
> The main areas for review are
>
> calamity@:
> html/js - chrome/browser/chromeos/crostini_upgrader/
> mojo and webui glue classes - chrome/browser/ui/webui/crostini_upgrader/
>
> davidmunro@
> crostini business logic - chrome/browser/chromeos/crostini/
>
> In this CL, the optional container backup stage is stubbed, and will be
> in a subsequent CL.
>
> A suite of unit/browser tests are also currently lacking. I intend them for
> follow-up CLs.
>
>
> Bug: 930901
> Change-Id: Ic52c5242e6c57232ffa6be5d6af65aaff5e8f4ff
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900520
> Commit-Queue: Nicholas Verne <[email protected]>
> Reviewed-by: Sam McNally <[email protected]>
> Reviewed-by: calamity <[email protected]>
> Reviewed-by: Ken Rockot <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#717476}
Change-Id: I704f549216a7d1dc21942fbf6cf4ab9a1d600380
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 930901
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928159
Cr-Commit-Position: refs/heads/master@{#717481} | 48a13696977c4bd082341ac85d942128ba2638e4 | chrome | bigvul | 1 | null | null | null |
[IndexedDB] Fixed transaction use-after-free vuln
Bug: 725032
Change-Id: I689ded6c74d5563403587b149c3f3e02e807e4aa
Reviewed-on: https://chromium-review.googlesource.com/518483
Reviewed-by: Joshua Bell <[email protected]>
Commit-Queue: Daniel Murphy <[email protected]>
Cr-Commit-Position: refs/heads/master@{#475952} | 11601c08e92732d2883af2057c41c17cba890844 | chrome | bigvul | 1 | null | null | null |
Migrate download_protection code to new DM token class.
Migrates RetrieveDMToken calls to use the new BrowserDMToken class.
Bug: 1020296
Change-Id: Icef580e243430d73b6c1c42b273a8540277481d9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904234
Commit-Queue: Dominique Fauteux-Chapleau <[email protected]>
Reviewed-by: Tien Mai <[email protected]>
Reviewed-by: Daniel Rubery <[email protected]>
Cr-Commit-Position: refs/heads/master@{#714196} | 507241119f279c31766bd41c33d6ffb6851e2d7e | chrome | bigvul | 1 | null | null | null |
Downloads WebUI: Convert SearchServiceUnitTest to browser_tests.
This is in preparation of migrating to Polymer3. JS unit tests (V8UnitTest)
have no way currently of loading JS modules within a test context, since
they rely on a chrome://test data source that only exists in a
browser_tests context (WebUIBrowserTest).
Bug: 1022215
Change-Id: Ieb8caa155d3b83567160eb0927f43adbf548b153
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918650
Auto-Submit: Demetrios Papadopoulos <[email protected]>
Reviewed-by: Rebekah Potter <[email protected]>
Commit-Queue: Demetrios Papadopoulos <[email protected]>
Cr-Commit-Position: refs/heads/master@{#715582} | 08c1c7a9801347cb336aef34f2e8fb7480fe96be | chrome | bigvul | 1 | null | null | null |
[AW] Add Variations.RestartsWithStaleSeed metric.
This metric records the number of consecutive times the WebView browser
process starts with a stale seed. It's written when a fresh seed is
loaded after previously loading a stale seed.
Test: Manually verified with logging that the metric was written.
Bug: 1010625
Change-Id: Iadedb45af08d59ecd6662472670f848e8e99a8d9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851126
Commit-Queue: Robbie McElrath <[email protected]>
Reviewed-by: Nate Fischer <[email protected]>
Reviewed-by: Ilya Sherman <[email protected]>
Reviewed-by: Changwan Ryu <[email protected]>
Cr-Commit-Position: refs/heads/master@{#709417} | 9785a8b9672f6f35f5a401a86251c4109eda4175 | chrome | bigvul | 1 | null | null | null |
Decrease sharding of *content_browsertets in cros.
The content_browsertests and non_viz_contentbrowsertests run
3x-5x faster than browser_tests and non_viz_browser_tests
at the 95th percentile on linux-chromeos-rel. On debug, the
pattern is still there, but less pronounced.
Decreasing sharding by ~1/2 on both test suites should help
return some capacity without affectingi runtimes.
Bug: 1025798
Change-Id: I5a5004c92f12c7f0c9f77f2b3ed5679e1ed89d85
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1923031
Commit-Queue: Albert J. Wong <[email protected]>
Auto-Submit: Albert J. Wong <[email protected]>
Reviewed-by: John Budorick <[email protected]>
Cr-Commit-Position: refs/heads/master@{#716474} | 91f1096514fe682fef68bfdaa6aeac7e85e214f2 | chrome | bigvul | 1 | null | null | null |
Settings > Internet: Fix certificate updates and improve selection.
This fixes a bug where certificate updates were not triggering a refresh
in the new mojo based JS.
While testing that I discovered that the current default certificate
selection logic is broken. This is a subtle thing so was not noticed
previously. This fixes the logic, cleans up some code, and adds some
tests.
Bug: 1001598
Change-Id: Ib81d7f6e093e1e5837d5272c848a3422d6a80b5a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825120
Commit-Queue: Steven Bennetts <[email protected]>
Reviewed-by: Kyle Horimoto <[email protected]>
Cr-Commit-Position: refs/heads/master@{#700040} | aff3fcc93614df302e9a853a9e310c21986121c0 | chrome | bigvul | 1 | null | null | null |
CSP: Strip the fragment from reported URLs.
We should have been stripping the fragment from the URL we report for
CSP violations, but we weren't. Now we are, by running the URLs through
`stripURLForUseInReport()`, which implements the stripping algorithm
from CSP2: https://www.w3.org/TR/CSP2/#strip-uri-for-reporting
Eventually, we will migrate more completely to the CSP3 world that
doesn't require such detailed stripping, as it exposes less data to the
reports, but we're not there yet.
BUG=678776
Review-Url: https://codereview.chromium.org/2619783002
Cr-Commit-Position: refs/heads/master@{#458045} | fea16c8b60ff3d0756d5eb392394963b647bc41a | chrome | bigvul | 1 | null | null | null |
Block Tifinagh + Latin mix
BUG=chromium:722639
TEST=components_unittests --gtest_filter=*IDNToU*
Review-Url: https://codereview.chromium.org/2894313002
Cr-Commit-Position: refs/heads/master@{#474199} | ae6f339fba0736224fdca0b96d2bb1cda42d8ad3 | chrome | bigvul | 1 | null | null | null |
Fix error handling in the request sender and url fetcher downloader.
That means handling the network errors by primarily looking at net_error.
Bug: 1028369
Change-Id: I8181bced25f8b56144ea336a03883d0dceea5108
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935428
Reviewed-by: Joshua Pawlicki <[email protected]>
Commit-Queue: Sorin Jianu <[email protected]>
Cr-Commit-Position: refs/heads/master@{#719199} | e7b0b560a8f1c3f1c15a2c7486d212543660b8a6 | chrome | bigvul | 1 | null | null | null |
Origins should be represented as url::Origin (not as GURL).
As pointed out in //docs/security/origin-vs-url.md, origins should be
represented as url::Origin (not as GURL). This CL applies this
guideline to predictor-related code and changes the type of the
following fields from GURL to url::Origin:
- OriginRequestSummary::origin
- PreconnectedRequestStats::origin
- PreconnectRequest::origin
The old code did not depend on any non-origin parts of GURL
(like path and/or query). Therefore, this CL has no intended
behavior change.
Bug: 973885
Change-Id: Idd14590b4834cb9d50c74ed747b595fe1a4ba357
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895167
Commit-Queue: Łukasz Anforowicz <[email protected]>
Reviewed-by: Alex Ilin <[email protected]>
Cr-Commit-Position: refs/heads/master@{#716311} | fec26ff33bf372476a70326f3669a35f34a9d474 | chrome | bigvul | 1 | null | null | null |
Consider scroll-padding when determining scroll anchor node
Scroll anchoring should not anchor to a node that is behind scroll
padding.
Bug: 1010002
Change-Id: Icbd89fb85ea2c97a6de635930a9896f6a87b8f07
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887745
Reviewed-by: Chris Harrelson <[email protected]>
Commit-Queue: Nick Burris <[email protected]>
Cr-Commit-Position: refs/heads/master@{#711020} | a0ae9ed7bc545314dfcd4882db3498fda1808b4f | chrome | bigvul | 1 | null | null | null |
Roll src/third_party/shaderc/src 76ee91e12642..f7e05c734266 (2 commits)
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/76ee91e12642..f7e05c734266
git log 76ee91e12642..f7e05c734266 --date=short --no-merges --format='%ad %ae %s'
2019-11-07 [email protected] Remove deprecated API elements (#870)
2019-11-07 [email protected] Add support and unit test for OpTypeInt, OpTypePointer and OpConstant (#872)
Created with:
gclient setdep -r src/third_party/shaderc/src@f7e05c734266
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/shaderc-chromium-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
[email protected]
Bug: None
Change-Id: I62d60c539c538455fa4da9731d33c16ab9c171ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904625
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/master@{#713686} | 566e432beddd056b28afa5b6b8127397ce97f23d | chrome | bigvul | 1 | null | null | null |
[autofill] Avoid duplicate instances of the SaveCardBubble.
autofill::SaveCardBubbleControllerImpl::ShowBubble() expects
(via DCHECK) to only be called when the save card bubble is
not already visible. This constraint is violated if the user
clicks multiple times on a submit button.
If the underlying page goes away, the last SaveCardBubbleView
created by the controller will be automatically cleaned up,
but any others are left visible on the screen... holding a
refence to a possibly-deleted controller.
This CL early exits the ShowBubbleFor*** and ReshowBubble logic
if the bubble is already visible.
BUG=708819
Review-Url: https://codereview.chromium.org/2862933002
Cr-Commit-Position: refs/heads/master@{#469768} | 8b457840e3512ef8c2af8d966a3edce5c653a835 | chrome | bigvul | 1 | null | null | null |
Roll AFDO from 77.0.3833.0_rc-r1-merged to 77.0.3834.0_rc-r1-merged
This CL may cause a small binary size increase, roughly proportional
to how long it's been since our last AFDO profile roll. For larger
increases (around or exceeding 100KB), please file a bug against
[email protected]. Additional context: https://crbug.com/805539
Please note that, despite rolling to chrome/android, this profile is
used for both Linux and Android.
The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
[email protected]
Change-Id: Id94e976ad1992da564541590c1e6c91df2b453c9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1675685
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/master@{#672008} | 37d09b02d74e3223a5fe2d1547ddd3116582846e | chrome | bigvul | 1 | null | null | null |
Prevent screenshots of the card editor views.
Before this patch, users could take screenshots of the local credit card
editor views, which show the full card number in plain text. (Chrome
does not show the full number of the server cards.)
This patch adds a FLAG_SECURE to the window of the local card editors
for PaymentRequest and autofill. The flag is added for Chrome Beta and
Stable builds to protect regular users. Dev, Canary, and developer
builds do not have the FLAG_SECURE set.
After this patch, users cannot take screenshots of the local card
editor views in Chrome Beta and Stable.
Bug: 721579
Change-Id: I82dcd7c83cec85fb3f8dd58aa7ab25c2826641d0
Reviewed-on: https://chromium-review.googlesource.com/504787
Reviewed-by: Ted Choc <[email protected]>
Commit-Queue: Rouslan Solomakhin <[email protected]>
Cr-Commit-Position: refs/heads/master@{#471807} | 416588f2ea472b4f9273cbd0e40c1d18f71d1cba | chrome | bigvul | 1 | null | null | null |
Add feature and flag to enable incognito Chrome Custom Tabs
kCCTIncognito feature and flag are added to enable/disable incognito
Chrome Custom Tabs. The default is set to disabled.
Bug: 1023759
Change-Id: If32d256e3e9eaa94bcc09f7538c85e2dab53c589
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911201
Reviewed-by: Peter Conn <[email protected]>
Reviewed-by: David Trainor <[email protected]>
Commit-Queue: Ramin Halavati <[email protected]>
Cr-Commit-Position: refs/heads/master@{#714849} | ba7ddcc38946b51a38ab017afaeb013fb038d61c | chrome | bigvul | 1 | null | null | null |
Automated Commit: LKGM 12471.0.0 for chromeos.
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-chrome
BUG=762641
[email protected]
Change-Id: Ib34be9eb0cc6bff70d87c22d2a1ec5b74f951324
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779464
Reviewed-by: ChromeOS bot <[email protected]>
Commit-Queue: ChromeOS bot <[email protected]>
Cr-Commit-Position: refs/heads/master@{#692378} | 0fd46df7b281ed36e8c08d47ac4094a5895781cb | chrome | bigvul | 1 | null | null | null |
wpt-import: TBR current ecosystem infra sheriff
Bug: 755753
Change-Id: I12829ec0a83608219225a799d54609e3b1007d6c
Reviewed-on: https://chromium-review.googlesource.com/729639
Reviewed-by: Robert Ma <[email protected]>
Commit-Queue: Quinten Yearsley <[email protected]>
Cr-Commit-Position: refs/heads/master@{#510955} | a30383079c1f1522d44c6eff31a75cd9a1fefc55 | chrome | bigvul | 1 | null | null | null |
gpu: Disallow use of IOSurfaces for half-float format with swiftshader.
[email protected]
Bug: 998038
Change-Id: Ic31d28938ef205b36657fc7bd297fe8a63d08543
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798052
Commit-Queue: Kenneth Russell <[email protected]>
Reviewed-by: Kenneth Russell <[email protected]>
Auto-Submit: Khushal <[email protected]>
Cr-Commit-Position: refs/heads/master@{#695826} | cbc5d5153b18ea387f4769caa01d1339261f6ed6 | chrome | bigvul | 1 | null | null | null |
Minor adjustments to chrome://safe-browsing
This change fixes the issue with auto-scrolling when you select the
database manager tab, and also adds a border around password protection
pings so you can tell one ping from the other a bit more easily.
Render of two pings: https://screenshot.googleplex.com/4HprtXGmXpg.png
Bug: 984519
Change-Id: Id2fad0cb23c0c142c85a77c2a56e88fda9e7cd68
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790328
Auto-Submit: Daniel Rubery <[email protected]>
Reviewed-by: Varun Khaneja <[email protected]>
Commit-Queue: Varun Khaneja <[email protected]>
Cr-Commit-Position: refs/heads/master@{#694382} | e6b27952a666e7cfedf122b0135428bd2e318bff | chrome | bigvul | 1 | null | null | null |
Replace shenghao with shik in OWNERS list
This CL replaces shenghao with shik in OWNERS and other lists, since
shenghao is leaving CrOS team.
Bug: None
Test: It compiles
Change-Id: Id072c52e10c8044aaa55d2a6b6435bfe1613aab9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1741343
Auto-Submit: Sheng-hao Tsao <[email protected]>
Reviewed-by: Shik Chen <[email protected]>
Commit-Queue: Sheng-hao Tsao <[email protected]>
Cr-Commit-Position: refs/heads/master@{#684684} | 5646013c52faca22cea07b750d42910f5ff9fe29 | chrome | bigvul | 1 | null | null | null |
Block domain labels made of Cyrillic letters that look alike Latin
Block a label made entirely of Latin-look-alike Cyrillic letters when the TLD is not an IDN (i.e. this check is ON only for TLDs like 'com', 'net', 'uk', but not applied for IDN TLDs like рф.
BUG=683314
TEST=components_unittests --gtest_filter=U*IDN*
Review-Url: https://codereview.chromium.org/2683793010
Cr-Commit-Position: refs/heads/master@{#459226} | 08cb718ba7c3961c1006176c9faba0a5841ec792 | chrome | bigvul | 1 | null | null | null |
(Reland) Discard compositor frames from unloaded web content
This is a reland of https://codereview.chromium.org/2707243005/ with a
small change to fix an uninitialized memory error that fails on MSAN
bots.
BUG=672847
[email protected], [email protected]
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_site_isolation
Review-Url: https://codereview.chromium.org/2731283003
Cr-Commit-Position: refs/heads/master@{#454954} | 5d78b84d39bd34bc9fce9d01c0dcd5a22a330d34 | chrome | bigvul | 1 | null | null | null |
Fix for WebViewImpl exposure through bind().
This patch converts all uses of bind() in the GuestView JavaScript
objects to use $Function.bind() instead. This will prevent WebViewImpl (and other objects) from being exposed via overriding bind().
BUG=702896
Review-Url: https://codereview.chromium.org/2781713002
Cr-Commit-Position: refs/heads/master@{#459903} | eddd286de56b219308a2475ad6d2e8fd525aed63 | chrome | bigvul | 1 | null | null | null |
Roll src/third_party/skia/ a392dbaa9..e0a34e7dc (5 commits)
https://skia.googlesource.com/skia.git/+log/a392dbaa998e..e0a34e7dcddf
$ git log a392dbaa9..e0a34e7dc --date=short --no-merges --format='%ad %ae %s'
2017-03-17 bungeman Only set dw antialias mode to grayscale for A8.
2017-03-17 bsalomon Make dstreadshuffle not crash in with --preAbandonGpuContext and look better in 565
2017-03-16 herb Fix overflow bug in slow span.
2017-03-17 brianosman Add highp to specular lighting intermediate to fix iOS bots
2017-03-17 reed Revert[2] "More SkVertices implementation work""
Created with:
roll-dep src/third_party/skia
BUG=700836
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
[email protected]
Change-Id: If977d3dd51fa89e8273373f248aa2b3ee82eceb4
Reviewed-on: https://chromium-review.googlesource.com/456491
Reviewed-by: Skia Deps Roller <[email protected]>
Commit-Queue: Skia Deps Roller <[email protected]>
Cr-Commit-Position: refs/heads/master@{#457816} | a30eb8104246637502cad02cdc8bbd2cc8566abe | chrome | bigvul | 1 | null | null | null |
Custom state: Make the feature experimental state
Bug: 1012098
Change-Id: I266825bc3482fbc82c00fa9ef96d7b269c03a4fd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852345
Reviewed-by: Rakina Zata Amni <[email protected]>
Commit-Queue: Kent Tamura <[email protected]>
Cr-Commit-Position: refs/heads/master@{#704560} | c89b6cabf6e2797fd98e5284d3404e5438f88c92 | chrome | bigvul | 1 | null | null | null |
Port some css-multicol interpolation tests to WPT
Bug: 900581
Change-Id: Ia92d41788e13e7fb496b3e426d54622320f137cb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769306
Reviewed-by: Xida Chen <[email protected]>
Commit-Queue: Stephen McGruer <[email protected]>
Cr-Commit-Position: refs/heads/master@{#690821} | b79915caaf3844f7461ec37ed606aff454445ecc | chrome | bigvul | 1 | null | null | null |
media/gpu/test: ImageProcessorClient: Use bytes for width and height in libyuv::CopyPlane()
|width| is in bytes in libyuv::CopyPlane(). We formerly pass width in pixels.
This should matter when a pixel format is used whose pixel is composed of
more than one bytes.
Bug: None
Test: image_processor_test
Change-Id: I98e90be70c8d0128319172d4d19f3a8017b65d78
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553129
Commit-Queue: Hirokazu Honda <[email protected]>
Reviewed-by: Alexandre Courbot <[email protected]>
Cr-Commit-Position: refs/heads/master@{#648117} | 83588d6ed473f923a46484958d440da0b8a51b1b | chrome | bigvul | 1 | null | null | null |
Prevent regular mode session startup pref type turning to default.
When user loses past session tabs of regular mode after
invoking a new window from the incognito mode.
This was happening because the SessionStartUpPref type was being set
to default, from last, for regular user mode. This was happening in
the RestoreIfNecessary method where the restoration was taking place
for users whose SessionStartUpPref type was set to last.
The fix was to make the protocol of changing the pref type to
default more explicit to incognito users and not regular users
of pref type last.
Bug: 481373
Change-Id: I96efb4cf196949312181c83c6dcd45986ddded13
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774441
Reviewed-by: Tommy Martino <[email protected]>
Reviewed-by: Ramin Halavati <[email protected]>
Commit-Queue: Rohit Agarwal <[email protected]>
Cr-Commit-Position: refs/heads/master@{#691726} | 7a0dee9d17d0ee7fd1b40b017442f4952384a7c2 | chrome | bigvul | 1 | null | null | null |
chrome_repack_locales: compress .pak files on Chrome OS
For trivial change to resource_bundle.cc:
[email protected]
Bug: 1017864
Change-Id: I2afbfa8e02f952d03b36112e0093af92753876ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883292
Commit-Queue: Steven Bennetts <[email protected]>
Reviewed-by: Andrew Grieve <[email protected]>
Cr-Commit-Position: refs/heads/master@{#713205} | 173424428734518b3de79f2df26de8c8f540351c | chrome | bigvul | 1 | null | null | null |
Fix the crash after clamshell -> tablet transition in overview mode.
This CL just reverted some changes that were made in
https://chromium-review.googlesource.com/c/chromium/src/+/1658955. In
that CL, we changed the clamshell <-> tablet transition when clamshell
split view mode is enabled, however, we should keep the old behavior
unchanged if the feature is not enabled, i.e., overview should be ended
if it's active before the transition. Otherwise, it will cause a nullptr
dereference crash since |split_view_drag_indicators_| is not created in
clamshell overview and will be used in tablet overview.
Bug: 982507
Change-Id: I238fe9472648a446cff4ab992150658c228714dd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1705474
Commit-Queue: Xiaoqian Dai <[email protected]>
Reviewed-by: Mitsuru Oshima (Slow - on/off site) <[email protected]>
Cr-Commit-Position: refs/heads/master@{#679306} | 13e1002277287ed0090b2ca76c2d01545e677935 | chrome | bigvul | 1 | null | null | null |
Properly clean up in PrintViewManager::RenderFrameCreated().
BUG=694382,698622
Review-Url: https://codereview.chromium.org/2742853003
Cr-Commit-Position: refs/heads/master@{#457363} | 746da1cc6b2fbc2f725934542eedc49b41e5f17b | chrome | bigvul | 1 | null | null | null |
Reland Update axe-core to v3.3.2
This change updates the version of axe-core to the latest released
version. As part of picking up the latest version, the following
additional changes were made:
1) axe-core removed the 'href-no-hash' rule, so that been removed
from the test list.
2) Several 'link-in-text-block' tests started failing with
axe-core v3.0.2 (and later). These tests do pass in v3.0.1, but
are disabled as part of this change.
- CrManagementA11yTest.SimpleTest_link_in_text_block
- CrManagementA11yTestWithExtension.
ExtensionSection_link_in_text_block
- CrostiniAccessibilityTest.CROSTINI_link_in_text_block
- CrExtensionsA11yTest.NoExtensions_link_in_text_block
- MultideviceA11yTest.MULTIDEVICE_link_in_text_block
- MultideviceFeaturesA11yTest.
MULTIDEVICE_FEATURES_ACCESSIBILITY_link_in_text_block
3) One 'heading-order' test started failing in v3.0.0 (and later).
This tests does pass in V2.4.2, but is disabled as part of this
change.
- CrExtensionsA11yTestWithMultipleExensions.
WithExtensions_heading_order
4) Several DevTools a11y tests were failing. This change either
updates the baseline or excludes the rule depending upon the
test/rule itself.
- http/tests/devtools/a11y-axe-core/basic-a11y-test.js
- http/tests/devtools/a11y-axe-core/console-a11y-test.js
- http/tests/devtools/a11y-axe-core/memory/heap-profiler-a11y-test.js
- http/tests/devtools/a11y-axe-core/sources/dom-breakpoints-pane-a11y-test.js
I spent some time investigating the test failures, and it looks
like axe-core is highlighting legitimate product issues.
Change-Id: I0ef08cdace91250936f83705fb3cd0fbb35bed4b
Bug: 984817
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809407
Commit-Queue: Mike Jackson <[email protected]>
Reviewed-by: Yang Guo <[email protected]>
Reviewed-by: Hector Carmona <[email protected]>
Cr-Commit-Position: refs/heads/master@{#699166} | de35a0973ddba93070fa647b5c664077cef128be | chrome | bigvul | 1 | null | null | null |
Search the entire subtree when looking for the end of an inline continuation chain.
Inlines may be nested, so we may not find the last inline in the chain as a
direct child of the anonymous blocks. We need to search the entire subtree.
Don't do this with anonymous blocks that wrap block children (the block-level
DOM children of the inline-level objects), though. We're not going to find
anything interesting there.
This fix is speculative; the original bug report didn't come with a test case.
BUG=662767
Review-Url: https://codereview.chromium.org/2738503004
Cr-Commit-Position: refs/heads/master@{#455420} | e72c8c06b956706b54648589f807086d17340831 | chrome | bigvul | 1 | null | null | null |
ime-service: Delete InputEngine.ProcessText.
It is deprecated and no longer used.
Bug: 1009903
Change-Id: I6774a4506bd0bb41a5d1a5909a40a2a781564b16
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833029
Auto-Submit: Darren Shen <[email protected]>
Reviewed-by: Chris Palmer <[email protected]>
Reviewed-by: Keith Lee <[email protected]>
Reviewed-by: Shu Chen <[email protected]>
Commit-Queue: Darren Shen <[email protected]>
Cr-Commit-Position: refs/heads/master@{#705445} | 2ad6b02cbf13d8f9dce50340e966ba413cb66b1c | chrome | bigvul | 1 | null | null | null |
[Android][TouchToFill] Use FindPasswordInfoForElement for triggering
Use for TouchToFill the same triggering logic that is used for regular
suggestions.
Bug: 1010233
Change-Id: I111d4eac4ce94dd94b86097b6b6c98e08875e11a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834230
Commit-Queue: Boris Sazonov <[email protected]>
Reviewed-by: Vadym Doroshenko <[email protected]>
Cr-Commit-Position: refs/heads/master@{#702058} | 5c895ed26b096468eea6baa6584f2df65905b76b | chrome | bigvul | 1 | null | null | null |
Fix the data race of VideoTrackRecorder::Encoder::pause_
|pause_| can be set on the main thread and read on the io thread
at the same time. Declaring |pause_| as an atomic variable
solves the data race problem.
Fuzzer report: https://clusterfuzz.com/testcase?key=5766664522432512
Bug: 988327
Change-Id: Idd43e9d932dc96900b46a09c8b46ba4337505880
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722952
Commit-Queue: Miyoung Shin <[email protected]>
Reviewed-by: Guido Urdaneta <[email protected]>
Cr-Commit-Position: refs/heads/master@{#682194} | c0873d7969789b0a77911430ed4f337b8764d182 | chrome | bigvul | 1 | null | null | null |
Fix Preload Tab title & Favicon not updated proprely
ReplaceWebState is the method called by prerender service to replace
the old web state with the pre rendered webState.
Implement WebStateReplaced of WebStateListObserver which will
replace the title and the favicon of the tabview.
Bug: 980899
Change-Id: I0c70d0f404a020db19f7e0bd723c3c88c8eb79a6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722191
Commit-Queue: Mohammad Refaat <[email protected]>
Auto-Submit: Mohammad Refaat <[email protected]>
Reviewed-by: Rohit Rao <[email protected]>
Cr-Commit-Position: refs/heads/master@{#682020} | 3f6aa0d9246169fa0ea045c95a5019074e5b407a | chrome | bigvul | 1 | null | null | null |
Ignore updatePipBounds before initial bounds is set
When PIP enter/exit transition happens, window state change and
initial bounds change are committed in the same commit. However,
as state change is applied first in OnPreWidgetCommit and the
bounds is update later, if updatePipBounds is called between the
gap, it ends up returning a wrong bounds based on the previous
bounds.
Currently, there are two callstacks that end up triggering
updatePipBounds between the gap: (i) The state change causes
OnWindowAddedToLayout and updatePipBounds is called in OnWMEvent,
(ii) updatePipBounds is called in UpdatePipState to prevent it
from being placed under some system ui.
As it doesn't make sense to call updatePipBounds before the first
bounds is not set, this CL adds a boolean to defer updatePipBounds.
position.
Bug: b130782006
Test: Got VLC into PIP and confirmed it was placed at the correct
Change-Id: I5b9f3644bfb2533fd3f905bc09d49708a5d08a90
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578719
Commit-Queue: Kazuki Takise <[email protected]>
Auto-Submit: Kazuki Takise <[email protected]>
Reviewed-by: Mitsuru Oshima <[email protected]>
Cr-Commit-Position: refs/heads/master@{#668724} | 9c90f2cec381a0460e3879eb8efd14bac4488dbe | chrome | bigvul | 1 | null | null | null |
Android: Mock ModuleInstaller in tests
- Split ModuleInstaller to ModuleInstallerImpl and its interface.
- Remove //components/module_installer/../src-test
- Create a new ModuleInstallerRule to use in tests.
- Update bytecode rewriting to use getInstance().
- Remove dependency on arcore in chrome_test_java (used on Kitkat).
Bug: 981084
Change-Id: I7909fe67fa29bdb0e5c787faf4293600283421ea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1687303
Commit-Queue: Peter Wen <[email protected]>
Reviewed-by: Eric Stevenson <[email protected]>
Reviewed-by: Tibor Goldschwendt <[email protected]>
Reviewed-by: Andrew Grieve <[email protected]>
Auto-Submit: Peter Wen <[email protected]>
Cr-Commit-Position: refs/heads/master@{#676623} | 7db51ac349f66b3cf716c1338c3b401380f45b4b | chrome | bigvul | 1 | null | null | null |
Roll src/third_party/pdfium/ 8fa82794f..96f482c9c (2 commits).
https://pdfium.googlesource.com/pdfium.git/+log/8fa82794ffc2..96f482c9cd3c
$ git log 8fa82794f..96f482c9c --date=short --no-merges --format='%ad %ae %s'
2017-01-11 dsinclair Convert FDE CSS enums to enum classes.
2017-01-11 npm Really fix m_nb_mct_records calculation in opj_j2k_read_mct
BUG=678461,680102
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls
[email protected]
Review-Url: https://codereview.chromium.org/2623103004
Cr-Commit-Position: refs/heads/master@{#443057} | 68e998adb1ea9fd998afd4dafd372d3d4729a54b | chrome | bigvul | 1 | null | null | null |
Add DumpWithoutCrashing in RendererDidNavigateToExistingPage
This is intended to be reverted after investigating the linked bug.
BUG=688425
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
Review-Url: https://codereview.chromium.org/2701523004
Cr-Commit-Position: refs/heads/master@{#450900} | c32cd2069ae8062b52e5b7b1faf5936bd71a583a | chrome | bigvul | 1 | null | null | null |
Add reporting for DLP deep scanning
For each triggered rule in the DLP response, we report the download as
violating that rule.
This also implements the UnsafeReportingEnabled enterprise policy, which
controls whether or not we do any reporting.
Bug: 980777
Change-Id: I48100cfb4dd5aa92ed80da1f34e64a6e393be2fa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772381
Commit-Queue: Daniel Rubery <[email protected]>
Reviewed-by: Karan Bhatia <[email protected]>
Reviewed-by: Roger Tawa <[email protected]>
Cr-Commit-Position: refs/heads/master@{#691371} | 61033ac5120da29aea6db205f5157d679c49edfc | chrome | bigvul | 1 | null | null | null |
Added swarming dimensions to fuchsia-fyi-arm64-rel.
Added dimensions so that fuchsia-fyi-arm64-rel will run on bots with these dimensions.
Bug: 968819
Change-Id: Iea1295e0d691d631031e497425a0d9e9b3ec0a52
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710201
Commit-Queue: Karen Qian <[email protected]>
Reviewed-by: Stephen Martinis <[email protected]>
Cr-Commit-Position: refs/heads/master@{#679640} | 5af39bd167241a85649dae16a872f52d9d1a9919 | chrome | bigvul | 1 | null | null | null |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.