commit_msg
stringlengths 1
24.2k
| commit_hash
stringlengths 2
84
⌀ | project
stringlengths 2
40
| source
stringclasses 4
values | labels
int64 0
1
| repo_url
stringlengths 26
70
⌀ | commit_url
stringlengths 74
118
⌀ | commit_date
stringlengths 25
25
⌀ |
|---|---|---|---|---|---|---|---|
Disable all DRP URL fetches when holdback is enabled
Disable secure proxy checker, warmup url fetcher
and client config fetch when the client is in DRP
(Data Reduction Proxy) holdback.
This CL does not disable pingbacks when client is in the
holdback, but the pingback code is going away soon.
Change-Id: Icbb59d814d1452123869c609e0770d1439c1db51
Bug: 984964
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1709965
Commit-Queue: Tarun Bansal <[email protected]>
Reviewed-by: Robert Ogden <[email protected]>
Cr-Commit-Position: refs/heads/master@{#679649} | 69b4b9ef7455753b12c3efe4eec71647e6fb1da1 | chrome | bigvul | 1 | null | null | null |
[sensors] Add explicit [Exposed=Window] to interfaces
The DeviceMotionEventAcceleration and DeviceMotionEventRotationRate
interfaces were missing an explicit [Exposed=Window] attribute. This was
added to the specification in,
https://github.com/w3c/deviceorientation/pull/79
Bug: 792432
Change-Id: I5a185b1d2aa8cb0fc5022dfb80e7188fab0f083d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773545
Reviewed-by: Tim Volodine <[email protected]>
Commit-Queue: Reilly Grant <[email protected]>
Cr-Commit-Position: refs/heads/master@{#691323} | faf2c7fde0d73eb0264c373c86e8e2abea9daa58 | chrome | bigvul | 1 | null | null | null |
Fix spacing of text/button in settings sync promo
Add horizontal margin to the button.
Bug: 933755
Change-Id: I74423dbf88a69c8577a47a29502a3b75f9dc4cf0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529285
Reviewed-by: David Roger <[email protected]>
Commit-Queue: Thomas Tangl <[email protected]>
Cr-Commit-Position: refs/heads/master@{#642490} | a7ad0633da514a61b28ffa75611eb14825fef07f | chrome | bigvul | 1 | null | null | null |
Revert "Add explicit flag for compositor scrollbar injected gestures"
This reverts commit d9a56afcbdf9850bc39bb3edb56d07d11a1eb2b2.
Reason for revert:
Findit (https://goo.gl/kROfz5) identified CL at revision 669086 as the
culprit for flakes in the build cycles as shown on:
https://analysis.chromium.org/p/chromium/flake-portal/analysis/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vZDlhNTZhZmNiZGY5ODUwYmMzOWJiM2VkYjU2ZDA3ZDExYTFlYjJiMgw
Sample Failed Build: https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-rel/25818
Sample Failed Step: content_browsertests on Ubuntu-16.04
Sample Flaky Test: ScrollLatencyScrollbarBrowserTest.ScrollbarThumbDragLatency
Original change's description:
> Add explicit flag for compositor scrollbar injected gestures
>
> The original change to enable scrollbar latency for the composited
> scrollbars incorrectly used an existing member to try and determine
> whether a GestureScrollUpdate was the first one in an injected sequence
> or not. is_first_gesture_scroll_update_ was incorrect because it is only
> updated when input is actually dispatched to InputHandlerProxy, and the
> flag is cleared for all GSUs before the location where it was being
> read.
>
> This bug was missed because of incorrect tests. The
> VerifyRecordedSamplesForHistogram method doesn't actually assert or
> expect anything - the return value must be inspected.
>
> As part of fixing up the tests, I made a few other changes to get them
> passing consistently across all platforms:
> - turn on main thread scrollbar injection feature (in case it's ever
> turned off we don't want the tests to start failing)
> - enable mock scrollbars
> - disable smooth scrolling
> - don't run scrollbar tests on Android
>
> The composited scrollbar button test is disabled due to a bug in how
> the mock theme reports its button sizes, which throws off the region
> detection in ScrollbarLayerImplBase::IdentifyScrollbarPart (filed
> crbug.com/974063 for this issue).
>
> Change-Id: Ie1a762a5f6ecc264d22f0256db68f141fc76b950
>
> Bug: 954007
> Change-Id: Ib258e08e083e79da90ba2e4e4216e4879cf00cf7
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1652741
> Commit-Queue: Daniel Libby <[email protected]>
> Reviewed-by: David Bokan <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#669086}
Change-Id: Icc743e48fa740fe27f0cb0cfa21b209a696f518c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 954007
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660114
Cr-Commit-Position: refs/heads/master@{#669150} | 14f2111f9cec919a450115ce4914f228effca58e | chrome | bigvul | 1 | null | null | null |
Revert "PageInfo: decouple safe browsing and TLS statii."
This reverts commit ee95bc44021230127c7e6e9a8cf9d3820760f77c.
Reason for revert: suspect causing unit_tests failure on Linux MSAN Tests:
https://ci.chromium.org/p/chromium/builders/ci/Linux%20MSan%20Tests/17649
PageInfoBubbleViewTest.ChangingFlashSettingForSiteIsRemembered
PageInfoBubbleViewTest.EnsureCloseCallback
PageInfoBubbleViewTest.NotificationPermissionRevokeUkm
PageInfoBubbleViewTest.OpenPageInfoBubbleAfterNavigationStart
PageInfoBubbleViewTest.SetPermissionInfo
PageInfoBubbleViewTest.SetPermissionInfoForUsbGuard
PageInfoBubbleViewTest.SetPermissionInfoWithPolicyUsbDevices
PageInfoBubbleViewTest.SetPermissionInfoWithUsbDevice
PageInfoBubbleViewTest.SetPermissionInfoWithUserAndPolicyUsbDevices
PageInfoBubbleViewTest.UpdatingSiteDataRetainsLayout
https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8909718923797040064/+/steps/unit_tests/0/logs/Deterministic_failure:_PageInfoBubbleViewTest.ChangingFlashSettingForSiteIsRemembered__status_CRASH_/0
[ RUN ] PageInfoBubbleViewTest.ChangingFlashSettingForSiteIsRemembered
==9056==WARNING: MemorySanitizer: use-of-uninitialized-value
#0 0x561baaab15ec in PageInfoUI::GetSecurityDescription(PageInfoUI::IdentityInfo const&) const ./../../chrome/browser/ui/page_info/page_info_ui.cc:250:3
#1 0x561bab6a1548 in PageInfoBubbleView::SetIdentityInfo(PageInfoUI::IdentityInfo const&) ./../../chrome/browser/ui/views/page_info/page_info_bubble_view.cc:802:7
#2 0x561baaaab3bb in PageInfo::PresentSiteIdentity() ./../../chrome/browser/ui/page_info/page_info.cc:969:8
#3 0x561baaaa0a21 in PageInfo::PageInfo(PageInfoUI*, Profile*, TabSpecificContentSettings*, content::WebContents*, GURL const&, security_state::SecurityLevel, security_state::VisibleSecurityState const&) ./../../chrome/browser/ui/page_info/page_info.cc:344:3
#4 0x561bab69b6dd in PageInfoBubbleView::PageInfoBubbleView(views::View*, gfx::Rect const&, aura::Window*, Profile*, content::WebContents*, GURL const&, security_state::SecurityLevel, security_state::VisibleSecurityState const&, base::OnceCallback<void (views::Widget::ClosedReason, bool)>) ./../../chrome/browser/ui/views/page_info/page_info_bubble_view.cc:576:24
...
Original change's description:
> PageInfo: decouple safe browsing and TLS statii.
>
> Previously, the Page Info bubble maintained a single variable to
> identify all reasons that a page might have a non-standard status. This
> lead to the display logic making assumptions about, for instance, the
> validity of a certificate when the page was flagged by Safe Browsing.
>
> This CL separates out the Safe Browsing status from the site identity
> status so that the page info bubble can inform the user that the site's
> certificate is invalid, even if it's also flagged by Safe Browsing.
>
> Bug: 869925
> Change-Id: I34107225b4206c8f32771ccd75e9367668d0a72b
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662537
> Reviewed-by: Mustafa Emre Acer <[email protected]>
> Reviewed-by: Bret Sepulveda <[email protected]>
> Auto-Submit: Joe DeBlasio <[email protected]>
> Commit-Queue: Joe DeBlasio <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#671847}
[email protected],[email protected],[email protected]
Change-Id: I8be652952e7276bcc9266124693352e467159cc4
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 869925
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1673985
Reviewed-by: Takashi Sakamoto <[email protected]>
Commit-Queue: Takashi Sakamoto <[email protected]>
Cr-Commit-Position: refs/heads/master@{#671932} | 7cde8513c12a6e8ec5d1d1eb1cfd078d9adad3ef | chrome | bigvul | 1 | null | null | null |
Roll src-internal cac3effba788..ea8664557d2e (1 commits)
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/cac3effba788..ea8664557d2e
Created with:
gclient setdep -r src-internal@ea8664557d2e
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
[email protected]
Bug: chromium:None
Change-Id: Ide663e84c353f52fd8e19038aad32b274e52c88b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797444
Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#695476} | 79fbd456bc6c5988131919f9bcd7bcb62fe9d45a | chrome | bigvul | 1 | null | null | null |
Roll src/third_party/perfetto f50c2ff2f70c..432573ac119d (1 commits)
https://android.googlesource.com/platform/external/perfetto.git/+log/f50c2ff2f70c..432573ac119d
git log f50c2ff2f70c..432573ac119d --date=short --no-merges --format='%ad %ae %s'
2019-08-02 [email protected] Merge "Parse line numbers for llvm-symbolizer."
Created with:
gclient setdep -r src/third_party/perfetto@432573ac119d
The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
[email protected]
Bug: None
Change-Id: I589e96bc4ac9e1b93eef2715b4e136c2570eba30
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733010
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/master@{#683523} | 6f5480f34ac78f6d06380ebf30c7ea6804a7832a | chrome | bigvul | 1 | null | null | null |
bluetooth: Implement getAvailability()
This change implements the getAvailability() method for
navigator.bluetooth as defined in the specification.
Bug: 707640
Change-Id: I9e9b3e7f8ea7f259e975f71cb6d9570e5f04b479
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1651516
Reviewed-by: Chris Harrelson <[email protected]>
Reviewed-by: Giovanni Ortuño Urquidi <[email protected]>
Reviewed-by: Kinuko Yasuda <[email protected]>
Commit-Queue: Ovidio de Jesús Ruiz-Henríquez <[email protected]>
Auto-Submit: Ovidio de Jesús Ruiz-Henríquez <[email protected]>
Cr-Commit-Position: refs/heads/master@{#688987} | 62154472bd2c43e1790dd1bd8a527c1db9118d88 | chrome | bigvul | 1 | null | null | null |
[tools/perf] Provide reason for disabling testValidDump
[email protected]
Bug: 971998
Change-Id: Ifc468d1bcecd09756c15b392d999f8f78499f3b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649500
Reviewed-by: Juan Antonio Navarro Pérez <[email protected]>
Commit-Queue: Juan Antonio Navarro Pérez <[email protected]>
Cr-Commit-Position: refs/heads/master@{#667079} | 9901df6ec87fd5d931e29f7f05c17e2253fc9b6c | chrome | bigvul | 1 | null | null | null |
binding: Sets location[Symbol.toPrimitive].
Let the location objects have Symbol.toPrimitive property
as an unconfiguable own property, so that author scripts
cannot inject nor overwrite it.
BUG=680409
Review-Url: https://codereview.chromium.org/2656973002
Cr-Commit-Position: refs/heads/master@{#446991} | 1f959adce3efa86d7d9560f9642c6ae816f8d81c | chrome | bigvul | 1 | null | null | null |
WebUI: Convert cr-dialog mixins or parts or remove if unused
Bug: 973674
Change-Id: I0c40034a8d0e33ecec992ead0a9068ac2d81ea1f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666278
Reviewed-by: Esmael El-Moslimany <[email protected]>
Commit-Queue: John Lee <[email protected]>
Cr-Commit-Position: refs/heads/master@{#671102} | 353463abd51345350be2cc419e74fd8b3fd062c8 | chrome | bigvul | 1 | null | null | null |
Files app: Fix flakines on checkContextMenuFocus
Some idea of CL:1670408, wait the focus to be in the desired element.
Test: browser_tests --gtest_filter="*checkContextMenuFocus*"
Bug: 936429
Change-Id: I45ef0be5e6b5c0af004fb881fcf676487f013b4c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1679756
Commit-Queue: Noel Gordon <[email protected]>
Auto-Submit: Luciano Pacheco <[email protected]>
Reviewed-by: Noel Gordon <[email protected]>
Cr-Commit-Position: refs/heads/master@{#673170} | 1682384ac6997561230d40655e4c1670f968a862 | chrome | bigvul | 1 | null | null | null |
Don't touch the prototype chain to get the private script controller.
Prior to this patch, private scripts attempted to get the
"privateScriptController" property off the global object without verifying if
the property actually exists on the global. If the property hasn't been set yet,
this operation could descend into the prototype chain and potentially return
a named property from the WindowProperties object, leading to release asserts
and general confusion.
BUG=668552
Review-Url: https://codereview.chromium.org/2529163002
Cr-Commit-Position: refs/heads/master@{#434627} | c093b7a74ddce32dd3b0e0be60f31becc6ce32f9 | chrome | bigvul | 1 | null | null | null |
[Files app] ES6 class for ui/file_manager/file_manager/foreground/js/search_controller.js
Bug: 778674
Change-Id: Id6a3c5a48af4085a74282e7f3f89cc95dd426e0e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1630075
Commit-Queue: Luciano Pacheco <[email protected]>
Auto-Submit: Luciano Pacheco <[email protected]>
Reviewed-by: François Degros <[email protected]>
Cr-Commit-Position: refs/heads/master@{#663476} | ba4cb765f43b572ebfa9047a9a3c9cfb914b02d0 | chrome | bigvul | 1 | null | null | null |
DevTools: move front-end URL handling to DevToolsUIBindingds
BUG=662859
Review-Url: https://codereview.chromium.org/2607833002
Cr-Commit-Position: refs/heads/master@{#440926} | eea3300239f0b53e172a320eb8de59d0bea65f27 | chrome | bigvul | 1 | null | null | null |
DevTools: send proper resource type in Network.RequestWillBeSent
This patch plumbs resoure type into the DispatchWillSendRequest
instrumenation. This allows us to report accurate type in
Network.RequestWillBeSent event, instead of "Other", that we report
today.
BUG=765501
R=dgozman
Change-Id: I0134c08b841e8dd247fdc8ff208bfd51e462709c
Reviewed-on: https://chromium-review.googlesource.com/667504
Reviewed-by: Pavel Feldman <[email protected]>
Reviewed-by: Dmitry Gozman <[email protected]>
Commit-Queue: Andrey Lushnikov <[email protected]>
Cr-Commit-Position: refs/heads/master@{#507936} | 1c40f9042ae2d6ee7483d72998aabb5e73b2ff60 | chrome | bigvul | 1 | null | null | null |
[Payments] Prohibit opening payments UI in background tab.
Before this patch, calling PaymentRequest.show() would bring the
background window to the foreground, which allows a page to open a
pop-under.
This patch adds a check for the browser window being active (in
foreground) in PaymentRequest.show(). If the window is not active (in
background), then PaymentRequest.show() promise is rejected with
"AbortError: User cancelled request." No UI is shown in that case.
After this patch, calling PaymentRequest.show() does not bring the
background window to the foreground, thus preventing opening a pop-under.
Bug: 768230
Change-Id: I2b90f9086ceca5ed7b7bdf8045e44d7e99d566d0
Reviewed-on: https://chromium-review.googlesource.com/681843
Reviewed-by: anthonyvd <[email protected]>
Commit-Queue: Rouslan Solomakhin <[email protected]>
Cr-Commit-Position: refs/heads/master@{#504406} | 5b51043c7c8e7e6b86e68e6d93d95ad24e11cf0e | chrome | bigvul | 1 | null | null | null |
Update Breakpad to 1fc9cc0d0e1dfafb8d29dba8d01f09587d870026
1fc9cc0d0e1dfafb8d29dba8d01f09587d870026 [Breakpad iOS] Add a callback on report upload completion.
8c70c504b241f918e41f28a3102f5ca03475082b Make breakpad_unittests work with Chrome's test runner instead of gtest's
ebab5970b027c8c41eccf67a83883b4bfb736505 Use correct c++ standard library in Xcode project.
Bug: 954175,949098
Change-Id: Ifdc99129956e08dda9feaf8cc7e51fc90ac8184b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1581343
Auto-Submit: Olivier Robin <[email protected]>
Commit-Queue: Mark Mentovai <[email protected]>
Reviewed-by: Mark Mentovai <[email protected]>
Cr-Commit-Position: refs/heads/master@{#653555} | 74fcc702161c86bb63994c4e083c0ab542f9120c | chrome | bigvul | 1 | null | null | null |
Don't focus the location bar for NTP navigations in non-selected tabs.
BUG=677716
TEST=See bug for repro steps.
Review-Url: https://codereview.chromium.org/2624373002
Cr-Commit-Position: refs/heads/master@{#443338} | 8f3a9a68b2dcdd2c54cf49a41ad34729ab576702 | chrome | bigvul | 1 | null | null | null |
Remove unused histograms from the background loader offliner.
Bug: 975512
Change-Id: I87b0a91bed60e3a9e8a1fd9ae9b18cac27a0859f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1683361
Reviewed-by: Cathy Li <[email protected]>
Reviewed-by: Steven Holte <[email protected]>
Commit-Queue: Peter Williamson <[email protected]>
Cr-Commit-Position: refs/heads/master@{#675332} | 35eb28748d45b87695a69eceffaff73a0be476af | chrome | bigvul | 1 | null | null | null |
Enable AudioServiceAudioStreams by default on Mac.
Bug: 845892
Change-Id: I66b0fb77fdc742b9913c2d7d20e0bbc34f66eacc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1680253
Reviewed-by: Steven Holte <[email protected]>
Reviewed-by: Antoine Labour <[email protected]>
Reviewed-by: Bret Sepulveda <[email protected]>
Reviewed-by: Olga Sharonova <[email protected]>
Commit-Queue: Armando Miraglia <[email protected]>
Cr-Commit-Position: refs/heads/master@{#673971} | d57b8c180cd4278c454a84ad38248297cb791cf8 | chrome | bigvul | 1 | null | null | null |
Convert FrameHostMsg_DidAddMessageToConsole to Mojo.
Note: Since this required changing the test
RenderViewImplTest.DispatchBeforeUnloadCanDetachFrame, I manually
re-introduced https://crbug.com/666714 locally (the bug the test was
added for), and reran the test to confirm that it still covers the bug.
Bug: 786836
Change-Id: I110668fa6f0f261fd2ac36bb91a8d8b31c99f4f1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526270
Commit-Queue: Lowell Manners <[email protected]>
Reviewed-by: Daniel Cheng <[email protected]>
Reviewed-by: Camille Lamy <[email protected]>
Cr-Commit-Position: refs/heads/master@{#653137} | f03ea5a5c2ff26e239dfd23e263b15da2d9cee93 | chrome | bigvul | 1 | null | null | null |
Form validation: Do not show validation bubble if the page is invisible.
BUG=673163
Review-Url: https://codereview.chromium.org/2572813003
Cr-Commit-Position: refs/heads/master@{#438476} | a8e17a3031b6ad69c399e5e04dd0084e577097fc | chrome | bigvul | 1 | null | null | null |
Disable all GPU features on GeForce 8600M on macOS.
Rendering corruption is seen on this GPU, which is nearly 10 years
old. Fall back to software rendering.
BUG=676975
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2626973002
Cr-Commit-Position: refs/heads/master@{#442990} | 4ef48a4037ea44d220fbe9f468d3ac659a38f9cb | chrome | bigvul | 1 | null | null | null |
luci: switch 5 builders to builderless machine allocation.
Follow-up to crrev.com/i/1378754
Bug: 864819
Change-Id: I57937a8ee076d499a7e73d041d696ab61df71d56
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1654278
Commit-Queue: Yuly Novikov <[email protected]>
Reviewed-by: John Budorick <[email protected]>
Cr-Commit-Position: refs/heads/master@{#668665} | 31ecb765bb803c9746482ddeb1631e6b5ef3bf80 | chrome | bigvul | 1 | null | null | null |
Remove unused images from c/b/r/ntp4/.
Bug: None
Change-Id: I07e2bdf4d964da38ad7c13504a519300f5005155
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1654548
Commit-Queue: Dan Beam <[email protected]>
Auto-Submit: Demetrios Papadopoulos <[email protected]>
Reviewed-by: Dan Beam <[email protected]>
Cr-Commit-Position: refs/heads/master@{#668653} | 7cdda4ea0003b72f72dc1ad5317d4ca694709691 | chrome | bigvul | 1 | null | null | null |
Roll src/third_party/depot_tools 26af0d34d281..778c7f117aee (1 commits)
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/26af0d34d281..778c7f117aee
git log 26af0d34d281..778c7f117aee --date=short --no-merges --format='%ad %ae %s'
2019-05-28 [email protected] Make tryserver API only update the presentation of its own steps.
Created with:
gclient setdep -r src/third_party/depot_tools@778c7f117aee
The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
BUG=chromium:910369
[email protected]
Change-Id: I72c7bd662cad0470cddbbc9eaaf73a35bee5ccdc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632411
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/master@{#663726} | cc38912ee513a7409d63a168db021c28734348df | chrome | bigvul | 1 | null | null | null |
Update Pixel Expectations for failing Pixel_CanvasLowLatency2D
On Android FYI (Pixel 2) Pixel_CanvasLowLatency2D is consistently failing.
This change sets expectations to fail for the Android qualcomm-adreno-(tm)-540
configuration.
Bug: 966069
Change-Id: I515f745b88e79f278662239197488600088c99ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1630515
Reviewed-by: Yuly Novikov <[email protected]>
Commit-Queue: Jonathan Ross <[email protected]>
Cr-Commit-Position: refs/heads/master@{#663620} | 56af745149e24ef795c92c3177efb3f42ce52607 | chrome | bigvul | 1 | null | null | null |
Convert DCHECKs to CHECKs for histogram types
When a histogram is looked up by name, there is currently a DCHECK that
verifies the type of the stored histogram matches the expected type.
A mismatch represents a significant problem because the returned
HistogramBase is cast to a Histogram in ValidateRangeChecksum,
potentially causing a crash.
This CL converts the DCHECK to a CHECK to prevent the possibility of
type confusion in release builds.
BUG=651443
[email protected]
Review-Url: https://codereview.chromium.org/2381893003
Cr-Commit-Position: refs/heads/master@{#421929} | 03c2e97746a2c471ae136b0c669f8d0c033fe168 | chrome | bigvul | 1 | null | null | null |
Roll src/third_party/ffmpeg/ 239c9f9e2..a77cdbfeb (2 commits).
https://chromium.googlesource.com/chromium/third_party/ffmpeg.git/+log/239c9f9e2754..a77cdbfeb7b6
$ git log 239c9f9e2..a77cdbfeb --date=short --no-merges --format='%ad %ae %s'
2017-02-09 wolenetz lavf/mov.c: Avoid heap allocation wrap in mov_read_uuid
2017-02-08 wolenetz lavf/mov.c: Avoid heap allocation wrap in mov_read_hdlr
Created with:
roll-dep src/third_party/ffmpeg
BUG=643950,643951
[email protected]
Review-Url: https://codereview.chromium.org/2685013005
Cr-Commit-Position: refs/heads/master@{#449497} | 18995b57d57d54ca64ad66a2ff6d89501ea557a6 | chrome | bigvul | 1 | null | null | null |
[wasm] memory/constructor: update evaluation order test
Change-Id: I1b3eee109ed951c7e9d7245bca7900c2e01799af
Bug: v8:8319
Reviewed-on: https://chromium-review.googlesource.com/c/1478791
Reviewed-by: Ben Smith <[email protected]>
Commit-Queue: Sven Sauleau <[email protected]>
Cr-Commit-Position: refs/heads/master@{#634108} | 99a9ebaf2e01cba9f2ea98e9c6c85856056e00a7 | chrome | bigvul | 1 | null | null | null |
[LayoutNG] Take overflow into account when column-balancing.
I didn't check why one test started to pass (it's not a very interesting
test for overflow).
Bug: 829028
Change-Id: I2c2d5fe3ea8c6a87f00df47f81d4158936d8a1bd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742162
Reviewed-by: Ian Kilpatrick <[email protected]>
Commit-Queue: Morten Stenshorne <[email protected]>
Cr-Commit-Position: refs/heads/master@{#685349} | f85716d839636e0814d3309ce1d8f8a2cd1fb9a8 | chrome | bigvul | 1 | null | null | null |
Do not call StaticResource.getBitmap().recycle()
StaticResource.getBitmap() is and should only be called once in its
life cycle. This CL adds an assertion to guarantee this property.
Since StaticResource.getBitmap() would only be called once, it can
release the Bitmap after getBitmap() is called, and it's no longer
necessary to call recycle() on the Bitmap.
Bug: 965580
Change-Id: I070f9530aefea12a6dc72330a10e021103cfdd16
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625901
Commit-Queue: Wei-Yin Chen (陳威尹) <[email protected]>
Reviewed-by: David Trainor <[email protected]>
Cr-Commit-Position: refs/heads/master@{#664411} | 53f3de7e60280b543b7c12b0907edacd3f401b5e | chrome | bigvul | 1 | null | null | null |
Add a note that ThirdPartyBlockingEnabled is always disabled in AD domains.
Requested in b/117660113.
BUG=none
Change-Id: I31b8b22a3d504c78c25f0cd895e29c9da6f8db35
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1584329
Commit-Queue: Julian Pastarmov <[email protected]>
Reviewed-by: Lutz Justen <[email protected]>
Cr-Commit-Position: refs/heads/master@{#658535} | 30e98bde03e4d9f3791c1f17c5b43b62460b0573 | chrome | bigvul | 1 | null | null | null |
Disable webgl_conformance_vulkan_passthrough_tests on Win10 NVIDIA GTX 1660
Already disabled on other Win NVIDIA bots.
TBR=kbr
Bug: 935060
Change-Id: I586be87c12b26ce4e3ac08b83f6094c4efcc63e4
No-try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1591977
Commit-Queue: Yuly Novikov <[email protected]>
Reviewed-by: Yuly Novikov <[email protected]>
Cr-Commit-Position: refs/heads/master@{#655904} | 1a19cc515f4bf99319b102620a61eac936507cc7 | chrome | bigvul | 1 | null | null | null |
[BGPT] Add a fast-path for transform-origin changes.
This patch adds a fast-path for updating composited transform-origin
changes without requiring a PaintArtifactCompositor update. This
closely follows the approach of https://crrev.com/651338.
Bug: 952473
Change-Id: I8b82909c1761a7aa16705813207739d29596b0d0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1580260
Commit-Queue: Philip Rogers <[email protected]>
Auto-Submit: Philip Rogers <[email protected]>
Reviewed-by: vmpstr <[email protected]>
Cr-Commit-Position: refs/heads/master@{#653749} | a7a4c17843aac24470943630137e6f4a4822203f | chrome | bigvul | 1 | null | null | null |
[css-flexbox] Add comment to IntrinsicContentBlockSize
As requested in https://crrev.com/c/1546002
[email protected]
Bug: 945214
Change-Id: I20f6d82971b3a1b4ab632f7ac30db56ff792c36f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546938
Auto-Submit: Christian Biesinger <[email protected]>
Commit-Queue: David Grogan <[email protected]>
Reviewed-by: David Grogan <[email protected]>
Cr-Commit-Position: refs/heads/master@{#646610} | d59b80737d6fe11c8133370d73636c4655cd550b | chrome | bigvul | 1 | null | null | null |
Add boolean to UserIntiatedInfo noting if an input event led to navigation.
Also refactor UkmPageLoadMetricsObserver to use this new boolean to
report the user initiated metric in RecordPageLoadExtraInfoMetrics, so
that it works correctly in the case when the page load failed.
Bug: 925104
Change-Id: Ie08e7d3912cb1da484190d838005e95e57a209ff
Reviewed-on: https://chromium-review.googlesource.com/c/1450460
Commit-Queue: Annie Sullivan <[email protected]>
Reviewed-by: Bryan McQuade <[email protected]>
Cr-Commit-Position: refs/heads/master@{#630870} | e1e67d5d341d82c61cab2c41ff4163f17caf14ae | chrome | bigvul | 1 | null | null | null |
Prevent bad casting in ImageBitmap when calling ArrayBuffer::createOrNull
Currently when ImageBitmap's constructor is invoked, we check whether
dstSize will overflow size_t or not. The problem comes when we call
ArrayBuffer::createOrNull some times in the code.
Both parameters of ArrayBuffer::createOrNull are unsigned. In ImageBitmap
when we call this method, the first parameter is usually width * height.
This could overflow unsigned even if it has been checked safe with size_t,
the reason is that unsigned is a 32-bit value on 64-bit systems, while
size_t is a 64-bit value.
This CL makes a change such that we check whether the dstSize will overflow
unsigned or not. In this case, we can guarantee that createOrNull will not have
any crash.
BUG=664139
Review-Url: https://codereview.chromium.org/2500493002
Cr-Commit-Position: refs/heads/master@{#431936} | d59a4441697f6253e7dc3f7ae5caad6e5fd2c778 | chrome | bigvul | 1 | null | null | null |
infra: Add and use mixins for Goma RBE server settings
[email protected], [email protected], [email protected]
Bug: 945701
Change-Id: I98b2a8a2d644eccde84224171bbe7e9885041046
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539416
Commit-Queue: Simon Que <[email protected]>
Reviewed-by: Takuto Ikuta <[email protected]>
Cr-Commit-Position: refs/heads/master@{#644219} | 58e8d8c6b5211092e7ea0effb1f176e0404aca19 | chrome | bigvul | 1 | null | null | null |
WebUI Dark Mode: fix disabled {cr,settings}-slider contrast for a11y
Screenshot: https://imgur.com/a/ftEBVpS
BUG=953005
Change-Id: Ife36ae9492bdc8d1a22c10dce1f13ea34753998a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578752
Reviewed-by: Dominic Mazzoni <[email protected]>
Commit-Queue: Dan Beam <[email protected]>
Auto-Submit: Dan Beam <[email protected]>
Cr-Commit-Position: refs/heads/master@{#654183} | cc98ddf15b449a1446c5d0918ed470731da74e38 | chrome | bigvul | 1 | null | null | null |
[DevTools] Move sanitize url to devtools_ui.cc.
Compatibility script is not reliable enough.
BUG=653134
Review-Url: https://codereview.chromium.org/2403633002
Cr-Commit-Position: refs/heads/master@{#425814} | f865c2dfddb1d95af3a2467587c62566e3f7dfe4 | chrome | bigvul | 1 | null | null | null |
Add libinteraction to .gn check_targets list
libinteraction is used in certain internal builds.
Bug: b/110808839
Change-Id: I51c29bd0033d608413e97029f288de44b89fc441
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560138
Reviewed-by: John Budorick <[email protected]>
Commit-Queue: Luke Halliwell <[email protected]>
Cr-Commit-Position: refs/heads/master@{#649229} | fd581356a825191ae74b404cf51258109a949567 | chrome | bigvul | 1 | null | null | null |
[Cronet] Rename reportFinished() to reportRequestFinished().
This is the Java-side followup to the rename request in the native API
made here [1].
[1] https://crrev.com/c/1496296/26/components/cronet/native/engine.h#71
Bug: 879208
Change-Id: I0eb0bcc8c7e7f1a2376c271e45f56b9f457c22f2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574227
Reviewed-by: Paul Jensen <[email protected]>
Reviewed-by: Misha Efimov <[email protected]>
Commit-Queue: Caleb Raitto <[email protected]>
Cr-Commit-Position: refs/heads/master@{#652548} | f55a1bb6cb9d06e735902f100b7398ea23f1e027 | chrome | bigvul | 1 | null | null | null |
Revert "Enable camera blob stream when needed"
This reverts commit 10f4b93635e12f9fa0cba1641a10938ca38ed448.
Reason for revert:
Findit (https://goo.gl/kROfz5) identified CL at revision 601492 as the
culprit for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzEwZjRiOTM2MzVlMTJmOWZhMGNiYTE2NDFhMTA5MzhjYTM4ZWQ0NDgM
Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/Linux%20ChromiumOS%20MSan%20Tests/9190
Sample Failed Step: capture_unittests
Original change's description:
> Enable camera blob stream when needed
>
> Since blob stream needs higher resolution, it causes higher cpu loading
> to require higher resolution and resize to smaller resolution.
> In hangout app, we don't need blob stream. Enabling blob stream when
> needed can save a lot of cpu usage.
>
> BUG=b:114676133
> TEST=manually test in apprtc and CCA. make sure picture taking still
> works in CCA.
>
> Change-Id: I9144461bc76627903d0b3b359ce9cf962ff3628c
> Reviewed-on: https://chromium-review.googlesource.com/c/1261242
> Commit-Queue: Heng-ruey Hsu <[email protected]>
> Reviewed-by: Ricky Liang <[email protected]>
> Reviewed-by: Xiaohan Wang <[email protected]>
> Reviewed-by: Robert Sesek <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#601492}
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
BUG=b:114676133
Change-Id: If173ffe9259f7eca849b184806bd56e2a9fbaac4
Reviewed-on: https://chromium-review.googlesource.com/c/1292256
Cr-Commit-Position: refs/heads/master@{#601538} | fff73016a86f9a5990d080dc76058f8528a423f9 | chrome | bigvul | 1 | null | null | null |
[pdf] Defer page unloading in JS callback.
One of the callbacks from PDFium JavaScript into the embedder is to get the
current page number. In Chromium, this will trigger a call to
CalculateMostVisiblePage that method will determine the visible pages and unload
any non-visible pages. But, if the originating JS is on a non-visible page
we'll delete the page and annotations associated with that page. This will
cause issues as we are currently working with those objects when the JavaScript
returns.
This Cl defers the page unloading triggered by getting the most visible page
until the next event is handled by the Chromium embedder.
BUG=chromium:653090
Review-Url: https://codereview.chromium.org/2418533002
Cr-Commit-Position: refs/heads/master@{#424781} | bf6a6765d44b09c64b8c75d749efb84742a250e7 | chrome | bigvul | 1 | null | null | null |
Remove no_size_t_to_int_warning in //ui/message_center
Bug: 167187
Change-Id: Ie7b6c5714567d8486fcc6ce16f17cc418ca6ac30
Reviewed-on: https://chromium-review.googlesource.com/c/1393332
Reviewed-by: Avi Drissman <[email protected]>
Commit-Queue: Avi Drissman <[email protected]>
Cr-Commit-Position: refs/heads/master@{#619463} | 41b1898755898a495792d37dc48508405b1dacc5 | chrome | bigvul | 1 | null | null | null |
Fix PIP window being blank after minimize/show
DesktopWindowTreeHostX11::SetVisible only made the call into
OnNativeWidgetVisibilityChanged when transitioning from shown
to minimized and not vice versa. This is because this change
https://chromium-review.googlesource.com/c/chromium/src/+/1437263
considered IsVisible to be true when minimized, which made
IsVisible always true in this case. This caused layers to be hidden
but never shown again.
This is a reland of:
https://chromium-review.googlesource.com/c/chromium/src/+/1580103
Bug: 949199
Change-Id: I2151cd09e537d8ce8781897f43a3b8e9cec75996
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1584617
Reviewed-by: Scott Violet <[email protected]>
Commit-Queue: enne <[email protected]>
Cr-Commit-Position: refs/heads/master@{#654280} | 0d68cbd77addd38909101f76847deea56de00524 | chrome | bigvul | 1 | null | null | null |
Paint tab groups with the group color.
* The background of TabGroupHeader now uses the group color.
* The backgrounds of tabs in the group are tinted with the group color.
This treatment, along with the colors chosen, are intended to be
a placeholder.
Bug: 905491
Change-Id: Ic808548f8eba23064606e7fb8c9bba281d0d117f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610504
Commit-Queue: Bret Sepulveda <[email protected]>
Reviewed-by: Taylor Bergquist <[email protected]>
Cr-Commit-Position: refs/heads/master@{#660498} | 45d901b56f578a74b19ba0d10fa5c4c467f19303 | chrome | bigvul | 1 | null | null | null |
Add GL_PROGRAM_COMPLETION_QUERY_CHROMIUM
This makes the query of GL_COMPLETION_STATUS_KHR to programs much
cheaper by minimizing the round-trip to the GPU thread.
Bug: 881152, 957001
Change-Id: Iadfa798af29225e752c710ca5c25f50b3dd3101a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1586630
Commit-Queue: Kenneth Russell <[email protected]>
Reviewed-by: Kentaro Hara <[email protected]>
Reviewed-by: Geoff Lang <[email protected]>
Reviewed-by: Kenneth Russell <[email protected]>
Cr-Commit-Position: refs/heads/master@{#657568} | a4150b688a754d3d10d2ca385155b1c95d77d6ae | chrome | bigvul | 1 | null | null | null |
[SendTabToSelf] Added logic to display an infobar for the feature.
This CL is one of many to come. It covers:
* Creation of the infobar from the SendTabToSelfInfoBarController
* Plumbed the call to create the infobar to the native code.
* Open the link when user taps on the link
In follow-up CLs, the following will be done:
* Instantiate the InfobarController in the ChromeActivity
* Listen for Model changes in the Controller
Bug: 949233,963193
Change-Id: I5df1359debb5f0f35c32c2df3b691bf9129cdeb8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604406
Reviewed-by: Tommy Nyquist <[email protected]>
Reviewed-by: Avi Drissman <[email protected]>
Reviewed-by: Mikel Astiz <[email protected]>
Reviewed-by: sebsg <[email protected]>
Reviewed-by: Jeffrey Cohen <[email protected]>
Reviewed-by: Matthew Jones <[email protected]>
Commit-Queue: Tanya Gupta <[email protected]>
Cr-Commit-Position: refs/heads/master@{#660854} | 2a1d9fff62718d7175bf47c7903dda127ee0228c | chrome | bigvul | 1 | null | null | null |
omnibox: experiment with restoring placeholder when caret shows
Shows the "Search Google or type a URL" omnibox placeholder even when
the caret (text edit cursor) is showing / when focused. views::Textfield
works this way, as does <input placeholder="">. Omnibox and the NTP's
"fakebox" are exceptions in this regard and this experiment makes this
more consistent.
[email protected]
BUG=955585
Change-Id: I23c299c0973f2feb43f7a2be3bd3425a80b06c2d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1582315
Commit-Queue: Dan Beam <[email protected]>
Reviewed-by: Tommy Li <[email protected]>
Cr-Commit-Position: refs/heads/master@{#654279} | c6f0d22d508a551a40fc8bd7418941b77435aac3 | chrome | bigvul | 1 | null | null | null |
Drop navigations to NavigationEntry with invalid virtual URLs.
BUG=657720
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
Review-Url: https://codereview.chromium.org/2452443002
Cr-Commit-Position: refs/heads/master@{#428056} | e4ebe078840e65d673722e94f8251b334030b5e8 | chrome | bigvul | 1 | null | null | null |
Explicitly give entered iframes focus
Bug: b:112665662
Change-Id: I6e0d7661d08ba6560b3a6591db1a29073462b116
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577919
Reviewed-by: Anastasia Helfinstein <[email protected]>
Reviewed-by: Dominic Mazzoni <[email protected]>
Commit-Queue: David Tseng <[email protected]>
Cr-Commit-Position: refs/heads/master@{#653034} | 8035452b8c84024bdd90336e3b4586f0c52b8b69 | chrome | bigvul | 1 | null | null | null |
Roll src/third_party/pdfium/ 8779fa857..52ef14e89 (2 commits).
https://pdfium.googlesource.com/pdfium.git/+log/8779fa8578cf..52ef14e8911f
$ git log 8779fa857..52ef14e89 --date=short --no-merges --format='%ad %ae %s'
2016-10-12 ethannicholas added SkSL to Skia build
2016-10-12 dsinclair Convert from int to float values.
BUG=652038
[email protected]
Review-Url: https://codereview.chromium.org/2417653002
Cr-Commit-Position: refs/heads/master@{#424873} | 7db20340321792730c532a8ff9723f1c3ff1e6df | chrome | bigvul | 1 | null | null | null |
pdf: Hide bookmark icon when no bookmarks
The change to display: inline-block in [1] was preventing
the hidden attribute from taking effect.
[1] https://chromium-review.googlesource.com/c/chromium/src/+/1508014
Bug: 939695
Change-Id: Ifb76787827062b478a36615ff0146697d078a7c8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1511101
Auto-Submit: dstockwell <[email protected]>
Commit-Queue: Lei Zhang <[email protected]>
Reviewed-by: Lei Zhang <[email protected]>
Cr-Commit-Position: refs/heads/master@{#639750} | 0d4fbcb1cf80c689b27896e9ab0accc5c336bea2 | chrome | bigvul | 1 | null | null | null |
Enforce form-action CSP even when form.target is present.
BUG=630332
Review-Url: https://codereview.chromium.org/2464123004
Cr-Commit-Position: refs/heads/master@{#429922} | 4ac4aff49c4c539bce6d8a0d8800c01324bb6bc0 | chrome | bigvul | 1 | null | null | null |
Add Android SDK version to crash reports.
Bug: 911669
Change-Id: I62a97d76a0b88099a5a42b93463307f03be9b3e2
Reviewed-on: https://chromium-review.googlesource.com/c/1361104
Reviewed-by: Jochen Eisinger <[email protected]>
Reviewed-by: Peter Conn <[email protected]>
Reviewed-by: Ilya Sherman <[email protected]>
Commit-Queue: Michael van Ouwerkerk <[email protected]>
Cr-Commit-Position: refs/heads/master@{#615851} | a4acc2991a60408f2044b2a3b19817074c04b751 | chrome | bigvul | 1 | null | null | null |
Move IsDataSaverEnabledByUser to be a static method and use it
This method now officially becomes the source of truth that
everything in the code base eventually calls into to determine whether
or not DataSaver is enabled.
Bug: 934399
Change-Id: Iae837b710ace8cc3101188f79d02cbc2d4f0fd93
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1537242
Reviewed-by: Joshua Pawlicki <[email protected]>
Reviewed-by: Tarun Bansal <[email protected]>
Commit-Queue: Robert Ogden <[email protected]>
Cr-Commit-Position: refs/heads/master@{#643948} | c995d4fe5e96f4d6d4a88b7867279b08e72d2579 | chrome | bigvul | 1 | null | null | null |
chrome/browser/ui/webauthn: long domains may cause a line break.
As requested by UX in [1], allow long host names to split a title into
two lines. This allows us to show more of the name before eliding,
although sufficiently long names will still trigger elision.
Screenshot at
https://drive.google.com/open?id=1_V6t2CeZDAVazy3Px-OET2LnB__aEW1r.
[1] https://docs.google.com/presentation/d/1TtxkPUchyVZulqgdMcfui-68B0W-DWaFFVJEffGIbLA/edit#slide=id.g5913c4105f_1_12
Change-Id: I70f6541e0db3e9942239304de43b487a7561ca34
Bug: 870892
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601812
Auto-Submit: Adam Langley <[email protected]>
Commit-Queue: Nina Satragno <[email protected]>
Reviewed-by: Nina Satragno <[email protected]>
Cr-Commit-Position: refs/heads/master@{#658114} | 2f19869af13bbfdcfd682a55c0d2c61c6e102475 | chrome | bigvul | 1 | null | null | null |
Fix missing histograms
Bug: None
Test: None
Change-Id: I74576fdeef30b3672b6e58a967c97c51bde150c9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1615312
Reviewed-by: Steven Holte <[email protected]>
Commit-Queue: Mitsuru Oshima <[email protected]>
Cr-Commit-Position: refs/heads/master@{#660678} | 87fc78f999fc90a2663e3d05d44d40b6d8985305 | chrome | bigvul | 1 | null | null | null |
Ensure that OpenVR only adds placeholder buttons when needed.
The current implementation of the OpenVRGamepadHelper always adds the
optional grip and secondary axes buttons; however, if those buttons are
missing and no additional buttons need to be supported, they should not
be included. A prime example of this is the vive controller, which has
a trigger, a grip, and a touchpad, but no secondary axis button. This
is essentially the controller that the new TestGamepadOptionalData test
builds.
Bug: 964026
Change-Id: I1de93b5bd7bd0d9e75013cf33b8f333e5d70270f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627914
Reviewed-by: Bill Orr <[email protected]>
Commit-Queue: Alexander Cooper <[email protected]>
Cr-Commit-Position: refs/heads/master@{#662843} | 79708b391b2e91d63b5d009ec6202c7d7ededf93 | chrome | bigvul | 1 | null | null | null |
Lock generator_mutex_ inside DecodeFailed
Bug: 962126
We typically lock this mutex before reading or writing to
decode_failed_. Do so in one more place to avoid a data race.
Change-Id: I0248e4dd99defc5ad3d09575096847e6455adfc9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610085
Reviewed-by: Khushal <[email protected]>
Reviewed-by: Stephen Chenney <[email protected]>
Commit-Queue: Stephen Chenney <[email protected]>
Auto-Submit: Leon Scroggins <[email protected]>
Cr-Commit-Position: refs/heads/master@{#659475} | cc7aad3f6b3d6ad7f9a4b1b4f8e983e0eec7bdb6 | chrome | bigvul | 1 | null | null | null |
[DevTools] Handle navigation in console.log
BUG=642496
[email protected]
Review-Url: https://codereview.chromium.org/2318853002
Cr-Commit-Position: refs/heads/master@{#417958} | 37faa2db833127ac9b6d461d8bc49952e557c743 | chrome | bigvul | 1 | null | null | null |
Assert gpu-compositing for all Mac, Linux perf bots, all Win 10 and win 7 nvidia gpu perf
Bug: 771597
Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi
Change-Id: I6c56cc352acf0b00bc526dd032d5f9af5bbc2cd2
Reviewed-on: https://chromium-review.googlesource.com/1135873
Reviewed-by: Kenneth Russell <[email protected]>
Commit-Queue: Ned Nguyen <[email protected]>
Cr-Commit-Position: refs/heads/master@{#574802} | b0aae2d4f29b5a6d59e16260f81d19a8629a7e12 | chrome | bigvul | 1 | null | null | null |
Don't report OnFirstSurfaceActivation for ui::Compositor
Bug: 893850
Change-Id: Iee754cefbd083d0a21a2b672fb8e837eaab81c43
Reviewed-on: https://chromium-review.googlesource.com/c/1293712
Reviewed-by: Antoine Labour <[email protected]>
Commit-Queue: Saman Sami <[email protected]>
Cr-Commit-Position: refs/heads/master@{#601629} | dcd538eb3daf6c52d3ebef0a7afea758f6c657c8 | chrome | bigvul | 1 | null | null | null |
Add keepalive support to drivefs API
In some situations mounting drivefs may take very long time. To
distinguish it from a total hang we send periodic keepalives from drivefs.
BUG=chromium:899746
Change-Id: Iee906651557a8f8eab62d58298f33c7c3e61724e
Reviewed-on: https://chromium-review.googlesource.com/c/1305253
Commit-Queue: Sergei Datsenko <[email protected]>
Reviewed-by: Sam McNally <[email protected]>
Cr-Commit-Position: refs/heads/master@{#603732} | 829f713b4c75ddbe7db806b551f1e3b08bb5e95c | chrome | bigvul | 1 | null | null | null |
When we can't neuter ArrayBuffers, we can't transfer them
Instead, we need to copy
BUG=603987
[email protected]
Review URL: https://codereview.chromium.org/1904913002
Cr-Commit-Position: refs/heads/master@{#388719} | 2400ef7b592c31c9883fd1cd60bdea0622e69db3 | chrome | bigvul | 1 | null | null | null |
Fix HistoryEntry corruption when commit isn't for provisional entry.
BUG=597322
TEST=See bug for repro steps.
Review URL: https://codereview.chromium.org/1848103004
Cr-Commit-Position: refs/heads/master@{#384659} | bb3548ef2fcdb58f9bc638bb5a3c379320fdd0e0 | chrome | bigvul | 1 | null | null | null |
[signin] Add metrics to track the source for refresh token updated events
This CL add a source for update and revoke credentials operations. It then
surfaces the source in the chrome://signin-internals page.
This CL also records the following histograms that track refresh token events:
* Signin.RefreshTokenUpdated.ToValidToken.Source
* Signin.RefreshTokenUpdated.ToInvalidToken.Source
* Signin.RefreshTokenRevoked.Source
These histograms are needed to validate the assumptions of how often tokens
are revoked by the browser and the sources for the token revocations.
Bug: 896182
Change-Id: I2fcab80ee8e5699708e695bc3289fa6d34859a90
Reviewed-on: https://chromium-review.googlesource.com/c/1286464
Reviewed-by: Jochen Eisinger <[email protected]>
Reviewed-by: David Roger <[email protected]>
Reviewed-by: Ilya Sherman <[email protected]>
Commit-Queue: Mihai Sardarescu <[email protected]>
Cr-Commit-Position: refs/heads/master@{#606181} | 282f53ffdc3b1902da86f6a0791af736837efbf8 | chrome | bigvul | 1 | null | null | null |
Revert "[Picture in Picture] Call parent function in OnGestureEvent."
This reverts commit e60d9aef9d1eeeff4e5954ba137ed5009261f626.
Reason for revert: Causes the close button to receive gesture events even when it's not the target of the tap. This causes the PiP window to unexpectedly close.
Bug: 895773
Original change's description:
> [Picture in Picture] Call parent function in OnGestureEvent.
>
> Change-Id: I854654be22abd217c3f8ed557bc3fb9118c557c6
> Reviewed-on: https://chromium-review.googlesource.com/1192326
> Reviewed-by: CJ DiMeglio <[email protected]>
> Commit-Queue: apacible <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#586820}
# Not skipping CQ checks because original CL landed > 1 day ago.
Change-Id: I2f36d78713f0b811a0a2681e09284c394e146a5c
Reviewed-on: https://chromium-review.googlesource.com/c/1318397
Commit-Queue: Tommy Steimel <[email protected]>
Reviewed-by: CJ DiMeglio <[email protected]>
Reviewed-by: Mounir Lamouri <[email protected]>
Cr-Commit-Position: refs/heads/master@{#607039} | fb83de09f2c986ee91741f3a2776feea0e18e3f6 | chrome | bigvul | 1 | null | null | null |
Fix ChromeResourceDispatcherHostDelegateMirrorBrowserTest.MirrorRequestHeader with network service.
The functionality worked, as part of converting DICE, however the test code didn't work since it
depended on accessing the net objects directly. Switch the tests to use the EmbeddedTestServer, to
better match production, which removes the dependency on net/.
Also:
-make GetFilePathWithReplacements replace strings in the mock headers if they're present
-add a global to google_util to ignore ports; that way other tests can be converted without having
to modify each callsite to google_util
Bug: 881976
Change-Id: Ic52023495c1c98c1248025c11cdf37f433fef058
Reviewed-on: https://chromium-review.googlesource.com/c/1328142
Commit-Queue: John Abd-El-Malek <[email protected]>
Reviewed-by: Ramin Halavati <[email protected]>
Reviewed-by: Maks Orlovich <[email protected]>
Reviewed-by: Peter Kasting <[email protected]>
Cr-Commit-Position: refs/heads/master@{#607652} | 8b10115b2410b4bde18e094ad9fb8c5056134c87 | chrome | bigvul | 1 | null | null | null |
Roll src/third_party/pdfium 2585eafdcba3..2aa7e8cbc413 (14 commits)
https://pdfium.googlesource.com/pdfium.git/+log/2585eafdcba3..2aa7e8cbc413
git log 2585eafdcba3..2aa7e8cbc413 --date=short --no-merges --format='%ad %ae %s'
2018-11-15 [email protected] Revert "Track indirect object holder in more CPDF_ objects."
2018-11-15 [email protected] Revert "Slightly simplify CPDF_FontEncoding::Realize()."
2018-11-15 [email protected] Revert "Make orphaning old objects automatic during dictionary set/removal."
2018-11-15 [email protected] Speculative fix for unit test failure under code coverage
2018-11-15 [email protected] Remove some inactive OWNERS.
2018-11-15 [email protected] Better tests for AFSpecial_Format().
2018-11-14 [email protected] Process XFA preamble by inclusion rather than hard-coded strings
2018-11-14 [email protected] Avoid writing out empty streams in CPDF_Stream::WriteTo().
2018-11-14 [email protected] Slightly simplify CPDF_FontEncoding::Realize().
2018-11-14 [email protected] Make orphaning old objects automatic during dictionary set/removal.
2018-11-14 [email protected] Process XFA config by inclusion in place of hard coded strings
2018-11-14 [email protected] Process XFA locale by inclusion rather than hard-coded string.
2018-11-14 [email protected] Track indirect object holder in more CPDF_ objects.
2018-11-14 [email protected] Add some basic CPDF_PSEngine tests.
Created with:
gclient setdep -r src/third_party/pdfium@2aa7e8cbc413
The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
BUG=chromium:901654,chromium:905142,chromium:901654
[email protected]
Change-Id: Id92cee32fc92da023a16e1bd5fe2e24b0752dbb3
Reviewed-on: https://chromium-review.googlesource.com/c/1337641
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/master@{#608494} | dbf62f55172f4b5e6e633b3126ebd4d70f3b2add | chrome | bigvul | 1 | null | null | null |
Roll src/third_party/skia 0c583af06d50..1cb0e3a86df8 (19 commits)
https://skia.googlesource.com/skia.git/+log/0c583af06d50..1cb0e3a86df8
git log 0c583af06d50..1cb0e3a86df8 --date=short --no-merges --format='%ad %ae %s'
2018-10-18 [email protected] Roll skia/third_party/skcms f3e50cfac5bc..1ce6da5c8d99 (1 commits)
2018-10-18 [email protected] Validate allocation size in GrBufferAllocPool using SkSafeMath.
2018-10-18 [email protected] Properly fill in memory in sampled RLE BMPs
2018-10-18 [email protected] Add Bloaty (with demangling) for wasm BuildStats
2018-10-18 [email protected] split out effect deserialization, disable in flutter
2018-10-18 [email protected] Simplify atlas calculation for dimension only
2018-10-18 [email protected] Reland: Widen internal API to support more complex YUV formats
2018-10-18 [email protected] Roll recipe dependencies (trivial).
2018-10-18 [email protected] Blacklist PNGs with CRC errors when using platform
2018-10-18 [email protected] Roll third_party/externals/angle2 25843dd65181..c4765aa78267 (3 commits)
2018-10-18 [email protected] only build non-prod skottie/sksg code in our tree
2018-10-18 [email protected] fix pathops fuzz
2018-10-18 [email protected] Roll third_party/externals/swiftshader 0b3d56aa8983..a9999ce938be (2 commits)
2018-10-18 [email protected] Make GrBufferAllocPool reject very large allocation requests
2018-10-18 [email protected] In makeColorSpace, hoist the null -> sRGB optimization
2018-10-18 [email protected] Revert "Widen internal API to support more complex YUV formats"
2018-10-18 [email protected] Roll third_party/externals/swiftshader e70c3514e5a0..0b3d56aa8983 (2 commits)
2018-10-18 [email protected] Enable validation of sampler object GL functions
2018-10-18 [email protected] Always require a color space on picture-backed images
Created with:
gclient setdep -r src/third_party/skia@1cb0e3a86df8
The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
BUG=chromium:895362
[email protected]
Change-Id: If01f6ada18ffa5f2ec0b3b0e6b808ac4dae198b5
Reviewed-on: https://chromium-review.googlesource.com/c/1289120
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/master@{#600911} | 222d3f43510ca241ec3d781c87c0e974ea846d39 | chrome | bigvul | 1 | null | null | null |
Roll src/third_party/pdfium e835574db56d..333165a2c7b7 (6 commits)
https://pdfium.googlesource.com/pdfium.git/+log/e835574db56d..333165a2c7b7
git log e835574db56d..333165a2c7b7 --date=short --no-merges --format='%ad %ae %s'
2018-10-24 [email protected] Fix CPLW_Wnd ownership model in CFFL_FormFiller.
2018-10-24 [email protected] Clean up CFX_ImageTransformer parameters.
2018-10-24 [email protected] Remove FXDIB_BLEND_UNSUPPORTED.
2018-10-24 [email protected] Initialize CPDF_GeneralState::StateData in the header.
2018-10-24 [email protected] Use ASSERT() consistently. Replace assert() usage.
2018-10-24 [email protected] Assert CPDF_Image::m_pDocument is never nullptr.
Created with:
gclient setdep -r src/third_party/pdfium@333165a2c7b7
The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
BUG=chromium:898531
[email protected]
Change-Id: I943bf7e494b5ae34f5ae7371477f845d78d7271d
Reviewed-on: https://chromium-review.googlesource.com/c/1298283
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/master@{#602592} | 5141c56ec8df7234c01e2576d35dd5c56238d069 | chrome | bigvul | 1 | null | null | null |
Avoid crash when setting rel=stylesheet on <link> in shadow root.
Link elements in shadow roots without rel=stylesheet are currently not
added as stylesheet candidates upon insertion. This causes a crash if
rel=stylesheet is set (and then loaded) later.
[email protected]
Bug: 886753
Change-Id: Ia0de2c1edf43407950f973982ee1c262a909d220
Reviewed-on: https://chromium-review.googlesource.com/1242463
Commit-Queue: Anders Ruud <[email protected]>
Reviewed-by: Rune Lillesveen <[email protected]>
Cr-Commit-Position: refs/heads/master@{#593907} | 2f8e481c12c9e8de107b73508b6c283569d4df5b | chrome | bigvul | 1 | null | null | null |
Fix *StaticBitmapImage ThreadChecker and unaccelerated SkImage destroy
- AcceleratedStaticBitmapImage was misusing ThreadChecker by having its
own detach logic. Using proper DetachThread is simpler, cleaner and
correct.
- UnacceleratedStaticBitmapImage didn't destroy the SkImage in the
proper thread, leading to GrContext/SkSp problems.
Bug: 890576
Change-Id: Ic71e7f7322b0b851774628247aa5256664bc0723
Reviewed-on: https://chromium-review.googlesource.com/c/1307775
Reviewed-by: Gabriel Charette <[email protected]>
Reviewed-by: Jeremy Roman <[email protected]>
Commit-Queue: Fernando Serboncini <[email protected]>
Cr-Commit-Position: refs/heads/master@{#604427} | 78d89fe556cb5dabbc47b4967cdf55e607e29580 | chrome | bigvul | 1 | null | null | null |
[scheduler] Remove implicit fallthrough in switch
Bail out early when a condition in the switch is fulfilled.
This does not change behaviour due to RemoveTaskObserver being no-op when
the task observer is not present in the list.
[email protected]
Bug: 177475
Change-Id: Ibc7772c79f8a8c8a1d63a997dabe1efda5d3a7bd
Reviewed-on: https://chromium-review.googlesource.com/891187
Reviewed-by: Nico Weber <[email protected]>
Commit-Queue: Alexander Timin <[email protected]>
Cr-Commit-Position: refs/heads/master@{#532649} | e34e01b1b0987e418bc22e3ef1cf2e4ecaead264 | chrome | bigvul | 1 | null | null | null |
Check context is attached before creating MediaRecorder
Bug: 896736
Change-Id: I3ccfd2188fb15704af14c8af050e0a5667855d34
Reviewed-on: https://chromium-review.googlesource.com/c/1324231
Commit-Queue: Emircan Uysaler <[email protected]>
Reviewed-by: Miguel Casas <[email protected]>
Cr-Commit-Position: refs/heads/master@{#606242} | f5ef337d8fffd10ab327069467ccaedb843cf9db | chrome | bigvul | 1 | null | null | null |
Add bounds CHECK to UTF-8 decoder memory allocation.
Avoid integer overflow when computing a total buffer size from a base
buffer and small partial sequence buffer.
Bug: 901030
Change-Id: Ic82db2c6af770bd748fb1ec881999d0dfaac30f0
Reviewed-on: https://chromium-review.googlesource.com/c/1313833
Reviewed-by: Chris Palmer <[email protected]>
Commit-Queue: Joshua Bell <[email protected]>
Cr-Commit-Position: refs/heads/master@{#605011} | dae5b388b44dae4dc11668dba210bbb92d72d969 | chrome | bigvul | 1 | null | null | null |
Roll src/third_party/skia 637c06aec7b1..d2916264aae0 (4 commits)
https://skia.googlesource.com/skia.git/+log/637c06aec7b1..d2916264aae0
git log 637c06aec7b1..d2916264aae0 --date=short --no-merges --format='%ad %ae %s'
2018-09-13 [email protected] [infra] Add pubsub emulator to gcloud asset
2018-09-13 [email protected] Defer mip-mapping until lazy proxy instantiation
2018-09-13 [email protected] add a linear gradient to P3 gm
2018-09-13 [email protected] Fix SkPath::reverseAddPath and fuzzing of SkPath enums
Created with:
gclient setdep -r src/third_party/skia@d2916264aae0
The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
BUG=chromium:882423
[email protected]
Change-Id: Icc65a9c71f5c9970e104dad2d7e313a4fa2221b3
Reviewed-on: https://chromium-review.googlesource.com/1224591
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/master@{#591020} | 1e75f8f872e92b7b4615df2f0c47359e3e498175 | chrome | bigvul | 1 | null | null | null |
[DevTools] Do not allow Page.setDownloadBehavior for extensions
Bug: 866426
Change-Id: I71b672978e1a8ec779ede49da16b21198567d3a4
Reviewed-on: https://chromium-review.googlesource.com/c/1270007
Commit-Queue: Dmitry Gozman <[email protected]>
Reviewed-by: Devlin <[email protected]>
Cr-Commit-Position: refs/heads/master@{#598004} | c71d8045ce0592cf3f4290744ab57b23c1d1b4c6 | chrome | bigvul | 1 | null | null | null |
websql: Enable SQLite's defensive mode for WebSQL databases.
The SQLITE_DBCONFIG_DEFENSIVE flag [1] was added in SQLite 3.26 for
applications that run untrusted SQL queries.
[1] https://www.sqlite.org/c3ref/c_dbconfig_defensive.html
Bug: 900910, 910906
Change-Id: Ia749be52b4e03c18df3b25bcb963c7a916fc671a
Reviewed-on: https://chromium-review.googlesource.com/c/1407544
Commit-Queue: Victor Costan <[email protected]>
Reviewed-by: Joshua Bell <[email protected]>
Cr-Commit-Position: refs/heads/master@{#622754} | a06c5187775536a68f035f16cdb8bc47b9bfad24 | chrome | bigvul | 1 | null | null | null |
Lock down blob/filesystem URL creation with a stronger CPSP::CanCommitURL()
ChildProcessSecurityPolicy::CanCommitURL() is a security check that's
supposed to tell whether a given renderer process is allowed to commit
a given URL. It is currently used to validate (1) blob and filesystem
URL creation, and (2) Origin headers. Currently, it has scheme-based
checks that disallow things like web renderers creating
blob/filesystem URLs in chrome-extension: origins, but it cannot stop
one web origin from creating those URLs for another origin.
This CL locks down its use for (1) to also consult
CanAccessDataForOrigin(). With site isolation, this will check origin
locks and ensure that foo.com cannot create blob/filesystem URLs for
other origins.
For now, this CL does not provide the same enforcements for (2),
Origin header validation, which has additional constraints that need
to be solved first (see https://crbug.com/515309).
Bug: 886976, 888001
Change-Id: I743ef05469e4000b2c0bee840022162600cc237f
Reviewed-on: https://chromium-review.googlesource.com/1235343
Commit-Queue: Alex Moshchuk <[email protected]>
Reviewed-by: Charlie Reis <[email protected]>
Cr-Commit-Position: refs/heads/master@{#594914} | 2078096efde1976b0fa9c820df90cedbfb2b13bc | chrome | bigvul | 1 | null | null | null |
Add trace event to sync_sessions::OnReadAllMetadata()
It is likely a cause of janks on UI thread on Android.
Add a trace event to get metrics about the duration.
BUG=902203
Change-Id: I4c4e9c2a20790264b982007ea7ee88ddfa7b972c
Reviewed-on: https://chromium-review.googlesource.com/c/1319369
Reviewed-by: Mikel Astiz <[email protected]>
Commit-Queue: ssid <[email protected]>
Cr-Commit-Position: refs/heads/master@{#606104} | 9004be20a4cfde70456579489258c3aca4ed45a4 | chrome | bigvul | 1 | null | null | null |
Don't preserve NavigationEntry for failed navigations with invalid URLs.
The formatting logic may rewrite such URLs into an unsafe state. This
is a first step before preventing navigations to invalid URLs entirely.
Bug: 850824
Change-Id: I71743bfb4b610d55ce901ee8902125f934a2bb23
Reviewed-on: https://chromium-review.googlesource.com/c/1252942
Reviewed-by: Alex Moshchuk <[email protected]>
Commit-Queue: Charlie Reis <[email protected]>
Cr-Commit-Position: refs/heads/master@{#597304} | 0aa576040704401ae28ea73b862d0b5d84262d51 | chrome | bigvul | 1 | null | null | null |
Fix scroll positioning logic for BiDirection omnibox text.
BUG=881659
Change-Id: Ib1ad439d73b7951603a35fb9760d9cec943f0acd
Reviewed-on: https://chromium-review.googlesource.com/c/1257666
Commit-Queue: Ted Choc <[email protected]>
Reviewed-by: Theresa <[email protected]>
Reviewed-by: Troy Hildebrandt <[email protected]>
Cr-Commit-Position: refs/heads/master@{#596036} | 18c10ae06ccb39b4ff6edc4c40f11127239c4f63 | chrome | bigvul | 1 | null | null | null |
Add a check for disallowing remote frame navigations to local resources.
Previously, RemoteFrame navigations did not perform any renderer-side
checks and relied solely on the browser-side logic to block disallowed
navigations via mechanisms like FilterURL. This means that blocked
remote frame navigations were silently navigated to about:blank
without any console error message.
This CL adds a CanDisplay check to the remote navigation path to match
an equivalent check done for local frame navigations. This way, the
renderer can consistently block disallowed navigations in both cases
and output an error message.
Bug: 894399
Change-Id: I172f68f77c1676f6ca0172d2a6c78f7edc0e3b7a
Reviewed-on: https://chromium-review.googlesource.com/c/1282390
Reviewed-by: Charlie Reis <[email protected]>
Reviewed-by: Nate Chapin <[email protected]>
Commit-Queue: Alex Moshchuk <[email protected]>
Cr-Commit-Position: refs/heads/master@{#601022} | 5f8671e7667b8b133bd3664100012a3906e92d65 | chrome | bigvul | 1 | null | null | null |
Inherit CSP when self-navigating to local-scheme URL
As the linked bug example shows, we should inherit CSP when we navigate
to a local-scheme URL (even if we are in a main browsing context).
Bug: 799747
Change-Id: I8413aa8e8049461ebcf0ffbf7b04c41d1340af02
Reviewed-on: https://chromium-review.googlesource.com/c/1234337
Reviewed-by: Mike West <[email protected]>
Commit-Queue: Andy Paicu <[email protected]>
Cr-Commit-Position: refs/heads/master@{#597889} | d683fb12566eaec180ee0e0506288f46cc7a43e7 | chrome | bigvul | 1 | null | null | null |
Check ancestors when setting an <iframe> navigation's "site for cookies".
Currently, we're setting the "site for cookies" only by looking at the
top-level document. We ought to be verifying that the ancestor frames
are same-site before doing so. We do this correctly in Blink (see
`Document::SiteForCookies`), but didn't do so when navigating in the
browser.
This patch addresses the majority of the problem by walking the ancestor
chain when processing a NavigationRequest. If all the ancestors are
same-site, we set the "site for cookies" to the top-level document's URL.
If they aren't all same-site, we set it to an empty URL to ensure that
we don't send SameSite cookies.
Bug: 833847
Change-Id: Icd77f31fa618fa9f8b59fc3b15e1bed6ee05aabd
Reviewed-on: https://chromium-review.googlesource.com/1025772
Reviewed-by: Alex Moshchuk <[email protected]>
Commit-Queue: Mike West <[email protected]>
Cr-Commit-Position: refs/heads/master@{#553942} | 07fbae50670ea44e35e1d554db1bbece7fe3711f | chrome | bigvul | 1 | null | null | null |
Simplify "WouldTaintOrigin" concept in media/blink
Currently WebMediaPlayer has three predicates:
- DidGetOpaqueResponseFromServiceWorker
- HasSingleSecurityOrigin
- DidPassCORSAccessCheck
. These are used to determine whether the response body is available
for scripts. They are known to be confusing, and actually
MediaElementAudioSourceHandler::WouldTaintOrigin misuses them.
This CL merges the three predicates to one, WouldTaintOrigin, to remove
the confusion. Now the "response type" concept is available and we
don't need a custom CORS check, so this CL removes
BaseAudioContext::WouldTaintOrigin. This CL also renames
URLData::has_opaque_data_ and its (direct and indirect) data accessors
to match the spec.
Bug: 849942, 875153
Change-Id: I6acf50169d7445c4ff614e80ac606f79ee577d2a
Reviewed-on: https://chromium-review.googlesource.com/c/1238098
Reviewed-by: Fredrik Hubinette <[email protected]>
Reviewed-by: Kinuko Yasuda <[email protected]>
Reviewed-by: Raymond Toy <[email protected]>
Commit-Queue: Yutaka Hirano <[email protected]>
Cr-Commit-Position: refs/heads/master@{#598258} | a9cbaa7a40e2b2723cfc2f266c42f4980038a949 | chrome | bigvul | 1 | null | null | null |
Auto-dismiss http auth dialogs on navigation for Android.
BUG=884179
Change-Id: I18287e9c641045d5a74f3804e06ca17485e38957
Reviewed-on: https://chromium-review.googlesource.com/1227482
Commit-Queue: Ted Choc <[email protected]>
Reviewed-by: Yaron Friedman <[email protected]>
Cr-Commit-Position: refs/heads/master@{#591747} | f40a8c947f6f13ea97baa3d7967e033f75587b41 | chrome | bigvul | 1 | null | null | null |
Validate external protocols before launching on Windows
Bug: 889459
Change-Id: Id33ca6444bff1e6dd71b6000823cf6fec09746ef
Reviewed-on: https://chromium-review.googlesource.com/c/1256208
Reviewed-by: Greg Thompson <[email protected]>
Commit-Queue: Mustafa Emre Acer <[email protected]>
Cr-Commit-Position: refs/heads/master@{#597611} | d19a75fc26fd0ab1ce79ef3d1c1c9b3cc1fbd098 | chrome | bigvul | 1 | null | null | null |
Block modifier-letter-voicing character from domain names
This character (ˬ) is easy to miss between other characters. It's one of the three characters from Spacing-Modifier-Letters block that ICU lists in its recommended set in uspoof.cpp. Two of these characters (modifier-letter-turned-comma and modifier-letter-apostrophe) are already blocked in crbug/678812.
Bug: 896717
Change-Id: I24b2b591de8cc7822cd55aa005b15676be91175e
Reviewed-on: https://chromium-review.googlesource.com/c/1303037
Commit-Queue: Mustafa Emre Acer <[email protected]>
Reviewed-by: Tommy Li <[email protected]>
Cr-Commit-Position: refs/heads/master@{#604128} | 4e4fec21ebd26d2ef20ac9f1ca0d2a16329f22bd | chrome | bigvul | 1 | null | null | null |
Roll src/third_party/skia 198b87e5be20..63bc5891e49e (37 commits)
https://skia.googlesource.com/skia.git/+log/198b87e5be20..63bc5891e49e
git log 198b87e5be20..63bc5891e49e --date=short --no-merges --format='%ad %ae %s'
2018-10-17 [email protected] Revert "Remove ancient support for kUnknown_SkColorType in SkBitmapDevice"
2018-10-17 [email protected] SkQP-on-GCE: print exit status in logs
2018-10-17 [email protected] Roll third_party/externals/swiftshader 9b7688491526..847fc0b278f8 (1 commits)
2018-10-16 [email protected] Roll recipe dependencies (trivial).
2018-10-16 [email protected] Roll recipe dependencies (trivial).
2018-10-16 [email protected] Optimize GPU text regen for full pixel position text
2018-10-16 [email protected] Roll third_party/externals/angle2 6eba3c6104f2..d633b1569a21 (1 commits)
2018-10-16 [email protected] SkPDF: refactor generate_page_tree
2018-10-16 [email protected] Reland "Have GrAtlasManager use legacy behavior"
2018-10-16 [email protected] remove unused SK_SUPPORT_LEGACY_TEXT_BLOB
2018-10-16 [email protected] be consistent about int for incReserve
2018-10-16 [email protected] Remove GrColor4f
2018-10-16 [email protected] Add GrGLInterface support for sampler objects and GrGLCaps detection.
2018-10-16 [email protected] Fix uninitialized errors in SkPngCodec
2018-10-16 [email protected] Switch gradients from GrColor4f to SkPMColor4f
2018-10-16 [email protected] Remove ancient support for kUnknown_SkColorType in SkBitmapDevice
2018-10-16 [email protected] Remove SK_LEGACY_XFORM_CANVAS_IN_PICTURE_IMAGES
2018-10-16 [email protected] Remove all remaining GrColor4f (other than gradients)
2018-10-16 [email protected] Roll third_party/externals/swiftshader 518142733c90..9b7688491526 (1 commits)
2018-10-16 [email protected] Revert "remove pathop template"
2018-10-16 [email protected] Roll recipe dependencies (trivial).
2018-10-16 [email protected] Roll skia/third_party/skcms 33ca7b4f7334..fa2161cf791f (1 commits)
2018-10-16 [email protected] remove pathop template
2018-10-16 [email protected] Reland "Preserve pixel config in makeColorSpace of GPU backed images"
2018-10-16 [email protected] fix divides for osfuzz
2018-10-16 [email protected] streamline web documentation
2018-10-16 [email protected] Roll third_party/externals/swiftshader 767b41b1a841..518142733c90 (1 commits)
2018-10-16 [email protected] Re-enable NVPR on flutter.
2018-10-16 [email protected] Add Correctness tests for CanvasKit
2018-10-16 [email protected] Blacklist tests for internal bot
2018-10-16 [email protected] Allow batching of coverage and non-coverage GrTextureOps.
2018-10-16 [email protected] Roll third_party/externals/angle2 a1ac3fe80647..6eba3c6104f2 (1 commits)
2018-10-16 [email protected] Roll recipe dependencies (trivial).
2018-10-16 [email protected] Roll recipe dependencies (trivial).
2018-10-16 [email protected] Roll recipe dependencies (trivial).
2018-10-16 [email protected] Update markdown files
2018-10-16 [email protected] Update go_deps asset
Created with:
gclient setdep -r src/third_party/skia@63bc5891e49e
The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
BUG=chromium:883666
[email protected]
Change-Id: Ieb5b69ac80fc668b3890492e9f19db675c916c71
Reviewed-on: https://chromium-review.googlesource.com/c/1285563
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/master@{#600286} | 19dbaec1a04af630ae6b5fb909a37d56d4c8d4ed | chrome | bigvul | 1 | null | null | null |
Map U+10DE to 3 when checking for confusables
Georgian letter U+10DE (პ) looks similar to the number 3. This cl adds
U+10DE to the mapping to 3 when determining whether to fall back to
punycode when displaying URLs.
Bug: 895207
Change-Id: I49713d7772428f8d364f371850a42913669acc4b
Reviewed-on: https://chromium-review.googlesource.com/c/1284396
Commit-Queue: Livvie Lin <[email protected]>
Reviewed-by: Peter Kasting <[email protected]>
Cr-Commit-Position: refs/heads/master@{#600193} | 01e16ef252070f81b5f61ef4bfc0442422fd5d16 | chrome | bigvul | 1 | null | null | null |
Implicitly bypass localhost when proxying requests.
This aligns Chrome's behavior with the Windows and macOS proxy resolvers (but not Firefox).
Concretely:
* localhost names (as determined by net::IsLocalhost) now implicitly bypass the proxy
* link-local IP addresses implicitly bypass the proxy
The implicit rules are handled by ProxyBypassRules, and it is possible to override them when manually configuring proxy settings (but not when using PAC or auto-detect).
This change also adds support for the "<-loopback>" proxy bypass rule, with similar semantics as it has on Windows (removes the implicit bypass rules for localhost and link-local).
The compatibility risk of this change should be low as proxying through localhost was not universally supported. It is however an idiom used in testing (a number of our own tests had such a dependency). Impacted users can use the "<-loopback>" bypass rule as a workaround.
Bug: 413511, 899126, 901896
Change-Id: I263ca21ef9f12d4759a20cb4751dc3261bda6ac0
Reviewed-on: https://chromium-review.googlesource.com/c/1303626
Commit-Queue: Eric Roman <[email protected]>
Reviewed-by: Dominick Ng <[email protected]>
Reviewed-by: Tarun Bansal <[email protected]>
Reviewed-by: Matt Menke <[email protected]>
Reviewed-by: Sami Kyöstilä <[email protected]>
Cr-Commit-Position: refs/heads/master@{#606112} | da790f920bbc169a6805a4fb83b4c2ab09532d91 | chrome | bigvul | 1 | null | null | null |
Change TemporaryAddressSpoof test to not depend on PDF OpenActions.
OpenActions that navigate to URIs are going to be blocked when
https://pdfium-review.googlesource.com/c/pdfium/+/42731 relands.
It was reverted because this test was breaking and blocking the
pdfium roll into chromium.
The test will now click on a link in the PDF that navigates to the
URI.
Bug: 851821
Change-Id: I49853e99de7b989858b1962ad4a92a4168d4c2db
Reviewed-on: https://chromium-review.googlesource.com/c/1244367
Commit-Queue: Henrique Nakashima <[email protected]>
Reviewed-by: Charlie Reis <[email protected]>
Reviewed-by: Devlin <[email protected]>
Cr-Commit-Position: refs/heads/master@{#596011} | 33b9b0262029fea75c436229f9bdfe74b1937ad2 | chrome | bigvul | 1 | null | null | null |
Fix the regression caused by http://crrev.com/c/1288350.
Bug: 900124,856135
Change-Id: Ie11ad406bd1ea383dc2a83cc8661076309154865
Reviewed-on: https://chromium-review.googlesource.com/c/1317010
Reviewed-by: Lan Wei <[email protected]>
Commit-Queue: Shu Chen <[email protected]>
Cr-Commit-Position: refs/heads/master@{#605282} | 2f0b419df243400f954e11b649f4862a1e0ff367 | chrome | bigvul | 1 | null | null | null |
Prevent renderer initiated back navigation to cancel a browser one.
Renderer initiated back/forward navigations must not be able to cancel ongoing
browser initiated navigation if they are not user initiated.
Note: 'normal' renderer initiated navigation uses the
FrameHost::BeginNavigation() path. A code similar to this patch is done
in NavigatorImpl::OnBeginNavigation().
Test:
-----
Added: NavigationBrowserTest.
* HistoryBackInBeforeUnload
* HistoryBackInBeforeUnloadAfterSetTimeout
* HistoryBackCancelPendingNavigationNoUserGesture
* HistoryBackCancelPendingNavigationUserGesture
Fixed:
* (WPT) .../the-history-interface/traverse_the_history_2.html
* (WPT) .../the-history-interface/traverse_the_history_3.html
* (WPT) .../the-history-interface/traverse_the_history_4.html
* (WPT) .../the-history-interface/traverse_the_history_5.html
Bug: 879965
Change-Id: I1a9bfaaea1ffc219e6c32f6e676b660e746c578c
Reviewed-on: https://chromium-review.googlesource.com/1209744
Commit-Queue: Arthur Sonzogni <[email protected]>
Reviewed-by: Daniel Cheng <[email protected]>
Reviewed-by: Mustaq Ahmed <[email protected]>
Reviewed-by: Camille Lamy <[email protected]>
Reviewed-by: Charlie Reis <[email protected]>
Cr-Commit-Position: refs/heads/master@{#592823} | a7d715ae5b654d1f98669fd979a00282a7229044 | chrome | bigvul | 1 | null | null | null |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.