commit_msg
stringlengths 1
24.2k
| commit_hash
stringlengths 2
84
⌀ | project
stringlengths 2
40
| source
stringclasses 4
values | labels
int64 0
1
| repo_url
stringlengths 26
70
⌀ | commit_url
stringlengths 74
118
⌀ | commit_date
stringlengths 25
25
⌀ |
|---|---|---|---|---|---|---|---|
Strip JavaScript schemas on Linux text drop
When dropping text onto the Omnibox, any leading JavaScript schemes
should be stripped to avoid a "self-XSS" attack. This stripping already
occurs in all cases except when plaintext is dropped on Linux. This CL
corrects that oversight.
Bug: 768910
Change-Id: I43af24ace4a13cf61d15a32eb9382dcdd498a062
Reviewed-on: https://chromium-review.googlesource.com/685638
Reviewed-by: Justin Donnelly <[email protected]>
Commit-Queue: Eric Lawrence <[email protected]>
Cr-Commit-Position: refs/heads/master@{#504695} | 16c719e0e275d2ee5d5c69e4962b744bcaf0fe40 | chrome | bigvul | 1 | null | null | null |
[wasm] Use correct bindings APIs
Use ScriptState::ForCurrentRealm in static methods, instead of
ForRelevantRealm().
Bug: chromium:788453
Change-Id: I63bd25e3f5a4e8d7cbaff945da8df0d71aa65527
Reviewed-on: https://chromium-review.googlesource.com/795096
Commit-Queue: Mircea Trofin <[email protected]>
Reviewed-by: Yuki Shiino <[email protected]>
Reviewed-by: Kentaro Hara <[email protected]>
Cr-Commit-Position: refs/heads/master@{#520174} | c5a59182a8406f67333c283a31f257714f082b7d | chrome | bigvul | 1 | null | null | null |
Roll ICU to 7f873c45
There's only one change in the roll.
https://chromium.googlesource.com/chromium/deps/icu/+log/08cb9568..7f873c45
[email protected]
Bug: 770452
Test: See the bug
Change-Id: I6e9c1b8a7e0d2f013517402e7cd7dd434f398b27
Reviewed-on: https://chromium-review.googlesource.com/709939
Reviewed-by: Jungshik Shin <[email protected]>
Commit-Queue: Jungshik Shin <[email protected]>
Cr-Commit-Position: refs/heads/master@{#507752} | 99d3c8f639b6ea5fb4e7931547c95cfc79b33d48 | chrome | bigvul | 1 | null | null | null |
Fix Stack Buffer Overflow in QuicClientPromisedInfo::OnPromiseHeaders
BUG=777728
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I6a80db88aafdf20c7abd3847404b818565681310
Reviewed-on: https://chromium-review.googlesource.com/748425
Reviewed-by: Zhongyi Shi <[email protected]>
Commit-Queue: Ryan Hamilton <[email protected]>
Cr-Commit-Position: refs/heads/master@{#513105} | 7a6484fa7b7f86ea06749bfc9d10bb67b145140b | chrome | bigvul | 1 | null | null | null |
Remove wpt/fetch/api/request/request-cache* expectations
They now pass.
Bug: 441781
Change-Id: I98dad704808c2ed810ff9d03e0e49200b8e90209
Reviewed-on: https://chromium-review.googlesource.com/762930
Reviewed-by: Adam Rice <[email protected]>
Commit-Queue: Yutaka Hirano <[email protected]>
Cr-Commit-Position: refs/heads/master@{#515501} | 7953fb162063a185f5fa51b4a48ca5292d409b15 | chrome | bigvul | 1 | null | null | null |
Remove some senseless indirection from the Push API code
Four files to call one Java function. Let's just call it directly.
BUG=
Change-Id: I6e988e9a000051dd7e3dd2b517a33a09afc2fff6
Reviewed-on: https://chromium-review.googlesource.com/749147
Reviewed-by: Anita Woodruff <[email protected]>
Commit-Queue: Peter Beverloo <[email protected]>
Cr-Commit-Position: refs/heads/master@{#513464} | 1a90b2996bfd341a04073f0054047073865b485d | chrome | bigvul | 1 | null | null | null |
Roll src/third_party/pdfium/ 574756152..bb2f7e73b (2 commits)
https://pdfium.googlesource.com/pdfium.git/+log/574756152de8..bb2f7e73bef4
$ git log 574756152..bb2f7e73b --date=short --no-merges --format='%ad %ae %s'
2017-09-15 thestig Simplify a couple of CXFA_Node methods.
2017-09-15 rharrison Add ObservedPtrs to KillFocus path
Created with:
roll-dep src/third_party/pdfium
BUG=760455
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls
[email protected]
Change-Id: I5fd7a96a9eaa061fe2efe63434646c9edcb22ecc
Reviewed-on: https://chromium-review.googlesource.com/669307
Reviewed-by: <[email protected]>
Commit-Queue: <[email protected]>
Cr-Commit-Position: refs/heads/master@{#502381} | 517d4150a14d42f32bfc6bcdafce172ab3a47ff4 | chrome | bigvul | 1 | null | null | null |
Roll WebGL 34842fa..12192b9
https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/34842fa..12192b9
BUG=765469, 768969, 769989, 772651
TEST=bots
[email protected], [email protected]
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I180314943cb6427b916790f5ae5bf295c87330ea
Reviewed-on: https://chromium-review.googlesource.com/764818
Commit-Queue: Kenneth Russell <[email protected]>
Reviewed-by: Kenneth Russell <[email protected]>
Cr-Commit-Position: refs/heads/master@{#516218} | 09a81d3609c63f62d4775e087cbefdd7468da170 | chrome | bigvul | 1 | null | null | null |
Keep ScriptProcessorHandler alive across threads
When posting a task from the ScriptProcessorHandler::Process to fire a
process event, we need to keep the handler alive in case the
ScriptProcessorNode goes away (because it has no onaudioprocess
handler) and removes the its handler.
Bug: 765495
Test:
Change-Id: Ib4fa39d7b112c7051897700a1eff9f59a4a7a054
Reviewed-on: https://chromium-review.googlesource.com/677137
Reviewed-by: Hongchan Choi <[email protected]>
Reviewed-by: Kentaro Hara <[email protected]>
Commit-Queue: Raymond Toy <[email protected]>
Cr-Commit-Position: refs/heads/master@{#503629} | 783c28d59c4c748ef9b787d4717882c90c5b227b | chrome | bigvul | 1 | null | null | null |
String for in-product help popup and settings
Bug: 1028095
Change-Id: I795aacd5211a9ba94f325c007698538dfa56000e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934627
Reviewed-by: Vasilii Sukhanov <[email protected]>
Reviewed-by: Dominic Battré <[email protected]>
Commit-Queue: Dominic Battré <[email protected]>
Cr-Commit-Position: refs/heads/master@{#718858} | baac8ed132e87c88164423e921b6b4a4352aae62 | chrome | bigvul | 1 | null | null | null |
Roll libxml to 3939178e4cb797417ff033b1e04ab4b038e224d9
Removes a few patches fixed upstream:
https://git.gnome.org/browse/libxml2/commit/?id=e26630548e7d138d2c560844c43820b6767251e3
https://git.gnome.org/browse/libxml2/commit/?id=94691dc884d1a8ada39f073408b4bb92fe7fe882
Stops using the NOXXE flag which was reverted upstream:
https://git.gnome.org/browse/libxml2/commit/?id=030b1f7a27c22f9237eddca49ec5e620b6258d7d
Changes the patch to uri.c to not add limits.h, which is included
upstream.
Bug: 722079
Change-Id: I4b8449ed33f95de23c54c2cde99970c2df2781ac
Reviewed-on: https://chromium-review.googlesource.com/535233
Reviewed-by: Scott Graham <[email protected]>
Commit-Queue: Dominic Cooney <[email protected]>
Cr-Commit-Position: refs/heads/master@{#480755} | ce1446c00f0fd8f5a3b00727421be2124cb7370f | chrome | bigvul | 1 | null | null | null |
Roll src/third_party/skia/ 15bb26ec7..25954b64c (8 commits)
https://skia.googlesource.com/skia.git/+log/15bb26ec70c9..25954b64c066
$ git log 15bb26ec7..25954b64c --date=short --no-merges --format='%ad %ae %s'
2017-08-15 mtklein explicitly vectorize sk_memset{16,32,64}
2017-08-15 mtklein upstream cr/165303354
2017-08-15 herb Fix bogus math in object allocation.
2017-08-15 fmalita Revert "Fix bogus math in object allocation."
2017-08-15 bungeman Remove SkTypeface::style().
2017-08-15 herb Fix bogus math in object allocation.
2017-08-15 fmalita Skip bilerp for integral-translate-only matrices (!clamp-clamp case)
2017-08-15 brianosman Speed up convexpaths GM in debug builds
Created with:
roll-dep src/third_party/skia
BUG=755391,744109,744109,744674
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
[email protected]
Change-Id: I14e7599bb7b37734099f0984baf5e6488e5b3e10
Reviewed-on: https://chromium-review.googlesource.com/616164
Reviewed-by: Skia Deps Roller <[email protected]>
Commit-Queue: Skia Deps Roller <[email protected]>
Cr-Commit-Position: refs/heads/master@{#494622} | e2b929d9e09c8701f0c07d740f41356a56d75d17 | chrome | bigvul | 1 | null | null | null |
Roll src/third_party/pdfium/ ee1e75790..131c0eb2e (1 commit)
https://pdfium.googlesource.com/pdfium.git/+log/ee1e757902d0..131c0eb2e34e
$ git log ee1e75790..131c0eb2e --date=short --no-merges --format='%ad %ae %s'
2017-09-08 thestig Fix an off by 1 error in TIFF_PredictLine().
Created with:
roll-dep src/third_party/pdfium
BUG=762106
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls
[email protected]
Change-Id: I7d6bba2e7c2c73d247a9390597f2b09e397663e8
Reviewed-on: https://chromium-review.googlesource.com/658400
Reviewed-by: <[email protected]>
Commit-Queue: <[email protected]>
Cr-Commit-Position: refs/heads/master@{#500756} | 60ffdffea2683c732514874a7d3548d5acecf740 | chrome | bigvul | 1 | null | null | null |
If a page shows a popup, end fullscreen.
This was implemented in Blink r159834, but it is susceptible
to a popup/fullscreen race. This CL reverts that implementation
and re-implements it in WebContents.
BUG=752003
TEST=WebContentsImplBrowserTest.PopupsFromJavaScriptEndFullscreen
Change-Id: Ia345cdeda273693c3231ad8f486bebfc3d83927f
Reviewed-on: https://chromium-review.googlesource.com/606987
Commit-Queue: Avi Drissman <[email protected]>
Reviewed-by: Charlie Reis <[email protected]>
Reviewed-by: Philip Jägenstedt <[email protected]>
Cr-Commit-Position: refs/heads/master@{#498171} | ba3b1b344017bbf36283464b51014fad15c2f3f4 | chrome | bigvul | 1 | null | null | null |
CSP now prevents opening javascript url windows when they're not allowed
spec: https://html.spec.whatwg.org/#navigate
which leads to: https://w3c.github.io/webappsec-csp/#should-block-navigation-request
Bug: 756040
Change-Id: I5fd62ebfb6fe1d767694b0ed6cf427c8ea95994a
Reviewed-on: https://chromium-review.googlesource.com/632580
Reviewed-by: Mike West <[email protected]>
Commit-Queue: Andy Paicu <[email protected]>
Cr-Commit-Position: refs/heads/master@{#497338} | 7d803fd8bbb8a2f3b626851a5ce58244efa0798a | chrome | bigvul | 1 | null | null | null |
Roll src/third_party/skia/ 7f754260f..71c05ead1 (12 commits)
https://skia.googlesource.com/skia.git/+log/7f754260f7fc..71c05ead16d2
$ git log 7f754260f..71c05ead1 --date=short --no-merges --format='%ad %ae %s'
2017-09-08 angle-deps-roller Roll skia/third_party/externals/angle2/ ec3a9cbb5..6f0c17c7d (1 commit)
2017-09-08 egdaniel Revert "Remove isMipMapped from GrSurfaceDesc" and follow up find exact scratch CL
2017-09-08 mtklein Don't allow iteration through non-finite points.
2017-09-07 csmartdalton CCPR: Check for flat lines before crunching on curves
2017-09-08 jvanverth Revert "Revert "Add multitexture support to text and path shaders""
2017-09-08 mtklein update SkJumper stages to clang 5
2017-09-08 egdaniel Update GrResourceCache changeUniqueKey to stay in valid state after each step
2017-09-08 brianosman Skip making a surface context when doing threaded SW paths
2017-09-08 jvanverth Revert "Add multitexture support to text and path shaders"
2017-09-08 bsalomon Revert "Revert "Make TextureOp use multitexturing to batch draws of different SkImages.""
2017-09-07 benjaminwagner Update NexusPlayers to Android O PR6.
2017-09-08 angle-deps-roller Roll skia/third_party/externals/angle2/ 95644f92d..ec3a9cbb5 (2 commits)
Created with:
roll-dep src/third_party/skia
BUG=756563
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
[email protected]
Change-Id: I0eea71e1b58665b82f47e65e6c80446f6b3affbc
Reviewed-on: https://chromium-review.googlesource.com/658262
Reviewed-by: Skia Deps Roller <[email protected]>
Commit-Queue: Skia Deps Roller <[email protected]>
Cr-Commit-Position: refs/heads/master@{#500706} | 76782217f4c8dd3bfbdfd2a2fd522bef01b48f37 | chrome | bigvul | 1 | null | null | null |
mac: Make RWHVMac::ClearCompositorFrame clear locks
Ensure that the BrowserCompositorMac not hold on to a compositor lock
when requested to clear its compositor frame. This lock may be held
indefinitely (if the renderer hangs) and so the frame will never be
cleared.
Bug: 739621
Change-Id: I15d0e82bdf632f3379a48e959f198afb8a4ac218
Reviewed-on: https://chromium-review.googlesource.com/608239
Commit-Queue: ccameron chromium <[email protected]>
Reviewed-by: Ken Buchanan <[email protected]>
Cr-Commit-Position: refs/heads/master@{#493563} | 5788690fb1395dc672ff9b3385dbfb1180ed710a | chrome | bigvul | 1 | null | null | null |
IDN display: Block U+0307 after i or U+0131
U+0307 (dot above) after i, j, l, or U+0131 (dotless i) would be
very hard to see if possible at all. This is not blocked
by the 'repeated diacritic' check because i is not decomposed
into dotless-i + U+0307. So, it has to be blocked separately.
Also, change the indentation in the output of
idn_test_case_generator.py .
This change blocks 80+ domains out of a million IDNs in .com TLD.
BUG=750239
TEST=components_unittests --gtest_filter=*IDN*
Change-Id: I4950aeb7aa080f92e38a2b5dea46ef4e5c25b65b
Reviewed-on: https://chromium-review.googlesource.com/607907
Reviewed-by: Peter Kasting <[email protected]>
Reviewed-by: Tom Sepez <[email protected]>
Reviewed-by: Matt Giuca <[email protected]>
Commit-Queue: Jungshik Shin <[email protected]>
Cr-Commit-Position: refs/heads/master@{#502987} | 1f6acd54ee3765d5c1a6f14fc31ddd4a74145314 | chrome | bigvul | 1 | null | null | null |
[Extensions] Update navigations across hypothetical extension extents
Update code to treat navigations across hypothetical extension extents
(e.g. for nonexistent extensions) the same as we do for navigations
crossing installed extension extents.
Bug: 598265
Change-Id: Ibdf2f563ce1fd108ead279077901020a24de732b
Reviewed-on: https://chromium-review.googlesource.com/617180
Commit-Queue: Devlin <[email protected]>
Reviewed-by: Alex Moshchuk <[email protected]>
Reviewed-by: Nasko Oskov <[email protected]>
Cr-Commit-Position: refs/heads/master@{#495779} | f1afce25b3f94d8bddec69b08ffbc29b989ad844 | chrome | bigvul | 1 | null | null | null |
Scroll time columns to the 2nd half to allow users to scroll up.
Since in the time picker each column has the list of cells doubled we can
start with each column scrolled to the middle in order to allow scrolling up.
The new behavior is validated by time-picker-appearance-wheel.html and other
existing tests.
Bug: 1021343
Change-Id: I65b04f3f1fec79c2efc75f54a7798726c6ab1200
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907522
Commit-Queue: Ionel Popescu <[email protected]>
Reviewed-by: Kent Tamura <[email protected]>
Reviewed-by: Mason Freed <[email protected]>
Cr-Commit-Position: refs/heads/master@{#714401} | d3196799aca6bb9f79beba2484fcdfeed5295d4f | chrome | bigvul | 1 | null | null | null |
[DevTools] Use no-referrer for DevTools links
Bug: 732751
Change-Id: I77753120e2424203dedcc7bc0847fb67f87fe2b2
Reviewed-on: https://chromium-review.googlesource.com/615021
Reviewed-by: Andrey Kosyakov <[email protected]>
Commit-Queue: Dmitry Gozman <[email protected]>
Cr-Commit-Position: refs/heads/master@{#494413} | a8ef19900d003ff7078fe4fcec8f63496b18f0dc | chrome | bigvul | 1 | null | null | null |
Ensure IDN domains are in punycode format in extension host permissions
Today in extension dialogs and bubbles, IDN domains in host permissions
are not displayed in punycode format. There is a low security risk that
granting such permission would allow extensions to interact with pages
using spoofy IDN domains. Note that this does not affect the omnibox,
which would represent the origin properly.
To address this issue, this CL converts IDN domains in host permissions
to punycode format.
Bug: 745580
Change-Id: Ifc04030fae645f8a78ac8fde170660f2d514acce
Reviewed-on: https://chromium-review.googlesource.com/644140
Commit-Queue: catmullings <[email protected]>
Reviewed-by: Istiaque Ahmed <[email protected]>
Reviewed-by: Tommy Li <[email protected]>
Cr-Commit-Position: refs/heads/master@{#499090} | 504e0c45030f76bffda93f0857e7595216d6e7a4 | chrome | bigvul | 1 | null | null | null |
Convert MediaTrackConstraints to a ScriptValue
IDLDictionaries such as MediaTrackConstraints should not be stored on
the heap which would happen when binding one as a parameter to a
callback. This change converts the object to a ScriptValue ahead of
time. This is fine because the value will be passed to a
ScriptPromiseResolver that will converted it to a V8 value if it
isn't already.
Bug: 759457
Change-Id: I3009a0f7711cc264aeaae07a36c18a6db8c915c8
Reviewed-on: https://chromium-review.googlesource.com/701358
Reviewed-by: Kentaro Hara <[email protected]>
Commit-Queue: Reilly Grant <[email protected]>
Cr-Commit-Position: refs/heads/master@{#507177} | 84ca1ee18bbc32f3cb035d071e8271e064dfd4d7 | chrome | bigvul | 1 | null | null | null |
Further reorganize code flow in ComputeInlineBoxPosition
This patch moves the atomic inline handling code before the block flow
handling code, so that there is no longer fall through from block flow
to atomic inline.
Bug: 771398
Change-Id: Idb4013e5616a2e81a13f4c6829c3afb2b86faa68
Reviewed-on: https://chromium-review.googlesource.com/775550
Commit-Queue: Yoshifumi Inoue <[email protected]>
Reviewed-by: Yoshifumi Inoue <[email protected]>
Cr-Commit-Position: refs/heads/master@{#517766} | 965bbf35c6645b47427b236cf49d696faf7d306a | chrome | bigvul | 1 | null | null | null |
[Payment Handler] Don't wait for response from closed payment app.
Before this patch, tapping the back button on top of the payment handler
window on desktop would not affect the |response_helper_|, which would
continue waiting for a response from the payment app. The service worker
of the closed payment app could timeout after 5 minutes and invoke the
|response_helper_|. Depending on what else the user did afterwards, in
the best case scenario, the payment sheet would display a "Transaction
failed" error message. In the worst case scenario, the
|response_helper_| would be used after free.
This patch clears the |response_helper_| in the PaymentRequestState and
in the ServiceWorkerPaymentInstrument after the payment app is closed.
After this patch, the cancelled payment app does not show "Transaction
failed" and does not use memory after it was freed.
Bug: 956597
Change-Id: I64134b911a4f8c154cb56d537a8243a68a806394
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1588682
Reviewed-by: anthonyvd <[email protected]>
Commit-Queue: Rouslan Solomakhin <[email protected]>
Cr-Commit-Position: refs/heads/master@{#654995} | 761d65ebcac0cdb730fd27b87e207201ac38e3b4 | chrome | bigvul | 1 | null | null | null |
Early return if a download Id is already used when creating a download
This is protect against download Id overflow and use-after-free
issue.
BUG=958533
Change-Id: I2c183493cb09106686df9822b3987bfb95bcf720
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1591485
Reviewed-by: Xing Liu <[email protected]>
Commit-Queue: Min Qin <[email protected]>
Cr-Commit-Position: refs/heads/master@{#656910} | 17368442aec0f48859a3561ae5e441175c7041ba | chrome | bigvul | 1 | null | null | null |
WebUI: Include cr/ui/grid.js only on ChromeOS.
Not used in any other platform.
Bug: None
Change-Id: I13cb2550ee38a828d8d266aeea5a8aa04695b54e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638915
Auto-Submit: Demetrios Papadopoulos <[email protected]>
Reviewed-by: Esmael El-Moslimany <[email protected]>
Commit-Queue: Demetrios Papadopoulos <[email protected]>
Cr-Commit-Position: refs/heads/master@{#665766} | 3142c79c09a123dc1512f9de5d89a22fcfcac0de | chrome | bigvul | 1 | null | null | null |
[XHR] Use response tainting to calculate CORS-exposed header-name list
XHR uses the same-originness of the request origin and the destination
URL to calculate the CORS-exposed header-name list, which leads to
wrong results with redirects. Use response tainting as specced.
Bug: 959390
Change-Id: Iec448dfe7d2b47d00f0f471391eb7918a1fe7bc4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598949
Reviewed-by: Takashi Toyoshima <[email protected]>
Commit-Queue: Yutaka Hirano <[email protected]>
Cr-Commit-Position: refs/heads/master@{#657626} | 08cc019f3f8c86d24330b4e3770bc2674000937c | chrome | bigvul | 1 | null | null | null |
Make permission dialogs tab-modal
This change addresses issue where permission dialog stays visible after
javastript code on the page opened different origin in a new tab.
After switching to tab-modal dialog, navigation in different tab will
cause ModalDialogManager to dismiss currently opened dialog.
BUG=945067
[email protected]
Change-Id: I942f8163087b4a6e952a635f48833203256d184e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565445
Reviewed-by: Becky Zhou <[email protected]>
Reviewed-by: Dominick Ng <[email protected]>
Commit-Queue: Pavel Yatsuk <[email protected]>
Cr-Commit-Position: refs/heads/master@{#651085} | 472688b229fb8193756bda744e107512ffcfac2c | chrome | bigvul | 1 | null | null | null |
[ios] Only update navItem url on didFinish when hosts match.
Don't update navigationItem url's in didFinish if host's don't match.
Bug: 962368
Change-Id: I92e52d435d3b137b09bf7ff9729bdc886eabb786
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613926
Reviewed-by: Danyao Wang <[email protected]>
Reviewed-by: Ali Juma <[email protected]>
Reviewed-by: Eugene But <[email protected]>
Commit-Queue: Justin Cohen <[email protected]>
Cr-Commit-Position: refs/heads/master@{#660111} | df499b7e59a62b038678500112da30a21a5536a0 | chrome | bigvul | 1 | null | null | null |
[Chrome Modern] Fixes RTL SuggestionView padding issue
Bug: 808171
Change-Id: I8ca5eeb07e263b96dde502551f8d70ee7dd3de74
Reviewed-on: https://chromium-review.googlesource.com/947342
Reviewed-by: Theresa <[email protected]>
Reviewed-by: Yusuf Ozuysal <[email protected]>
Commit-Queue: Daniel Park <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540900} | 33ab1fd4e5582e8c046b9c9559fcb25dd75298be | chrome | bigvul | 1 | null | null | null |
Reland "AppCache: Add padding to cross-origin responses."
This is a reland of 85b389caa7d725cdd31f59e9a2b79ff54804b7b7
Initialized CacheRecord::padding_size to 0.
Original change's description:
> AppCache: Add padding to cross-origin responses.
>
> Bug: 918293
> Change-Id: I4f16640f06feac009d6bbbb624951da6d2669f6c
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1488059
> Commit-Queue: Staphany Park <[email protected]>
> Reviewed-by: Victor Costan <[email protected]>
> Reviewed-by: Marijn Kruisselbrink <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#644624}
Bug: 918293
Change-Id: Ie1d3f99c7e8a854d33255a4d66243da2ce16441c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539906
Reviewed-by: Victor Costan <[email protected]>
Commit-Queue: Staphany Park <[email protected]>
Cr-Commit-Position: refs/heads/master@{#644719} | 04aaacb936a08d70862d6d9d7e8354721ae46be8 | chrome | bigvul | 1 | null | null | null |
Remove OmniboxCombinedSpeculativeServiceWorker field trial testing config.
The "OmniboxCombinedSpeculativeServiceWorker" study has long expired and
the "OmniboxSpeculativeServiceWorkerStartOnQueryInput" feature has
been enabled by default in r541744.
Bug: 732681
Change-Id: I08175813d67ed834eba31c080e5071248fb4a49e
Reviewed-on: https://chromium-review.googlesource.com/954891
Reviewed-by: Mark Pearson <[email protected]>
Commit-Queue: Matt Falkenhagen <[email protected]>
Cr-Commit-Position: refs/heads/master@{#541917} | 227d97f4d4a8102c77aaea14a4ac07ea9fff7c35 | chrome | bigvul | 1 | null | null | null |
Call CanCaptureVisiblePage in page capture API.
Currently the pageCapture permission allows access
to arbitrary local files and chrome:// pages which
can be a security concern. In order to address this,
the page capture API needs to be changed similar to
the captureVisibleTab API. The API will now only allow
extensions to capture otherwise-restricted URLs if the
user has granted activeTab. In addition, file:// URLs are
only capturable with the "Allow on file URLs" option enabled.
Bug: 893087
Change-Id: I6d6225a3efb70fc033e2e1c031c633869afac624
Reviewed-on: https://chromium-review.googlesource.com/c/1330689
Commit-Queue: Bettina Dea <[email protected]>
Reviewed-by: Devlin <[email protected]>
Reviewed-by: Varun Khaneja <[email protected]>
Cr-Commit-Position: refs/heads/master@{#615248} | 0660e08731fd42076d7242068e9eaed1482b14d5 | chrome | bigvul | 1 | null | null | null |
[url] Make path URL parsing more lax
Parsing the path component of a non-special URL like javascript or data
should not fail for invalid URL characters like \uFFFF. See this bit
in the spec:
https://url.spec.whatwg.org/#cannot-be-a-base-url-path-state
Note: some failing WPTs are added which are because url parsing
replaces invalid characters (e.g. \uFFFF) with the replacement char
\uFFFD, when that isn't in the spec.
Bug: 925614
Change-Id: I450495bfdfa68dc70334ebed16a3ecc0d5737e88
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1551917
Reviewed-by: Mike West <[email protected]>
Commit-Queue: Charlie Harrison <[email protected]>
Cr-Commit-Position: refs/heads/master@{#648155} | 19b1e5e4e1914b5b7464062ec300b817d2bac53d | chrome | bigvul | 1 | null | null | null |
[Android WebView] Remove unused mAdapterLock.
mAdapterLock was meant to be used for glue adapter instances stored in
WebViewChromiumFactoryProvider but using such a lock together with a
lock for Chromium initialization caused deadlocks. In this CL we remove
mAdapterLock since it's no longer used (either upstream or downstream).
Bug: 807332
Change-Id: I7b736942ae7fcbdaefbf888c36d84228154706b8
Reviewed-on: https://chromium-review.googlesource.com/951782
Reviewed-by: Bo <[email protected]>
Commit-Queue: Gustav Sennton <[email protected]>
Cr-Commit-Position: refs/heads/master@{#541151} | 956fb151e8496df183c868fdefd4d2e4c76378a8 | chrome | bigvul | 1 | null | null | null |
sqlite: backport bugfixes for dbfuzz2
Bug: 952406
Change-Id: Icbec429742048d6674828726c96d8e265c41b595
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1568152
Reviewed-by: Chris Mumford <[email protected]>
Commit-Queue: Darwin Huang <[email protected]>
Cr-Commit-Position: refs/heads/master@{#651030} | 517ac71c9ee27f856f9becde8abea7d1604af9d4 | chrome | bigvul | 1 | null | null | null |
[MediaStream] Pass request ID parameters in the right order for OpenDevice()
Prior to this CL, requester_id and page_request_id parameters were
passed in incorrect order from MediaStreamDispatcherHost to
MediaStreamManager for the OpenDevice() operation, which could lead to
errors.
Bug: 948564
Change-Id: Iadcf3fe26adaac50564102138ce212269cf32d62
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1569113
Reviewed-by: Marina Ciocea <[email protected]>
Commit-Queue: Guido Urdaneta <[email protected]>
Cr-Commit-Position: refs/heads/master@{#651255} | cfb022640b5eec337b06f88a485487dc92ca1ac1 | chrome | bigvul | 1 | null | null | null |
[IndexedDB] Fixed force close during pending connection open
During a force close of the database, the connections to that database
are iterated and force closed. The iteration method was not safe to
modification, and if there was a pending connection waiting to open,
that request would execute once all the other connections were
destroyed and create a new connection.
This change changes the iteration method to account for new connections
that are added during the iteration.
[email protected]
Bug: 941746
Change-Id: If1b3137237dc2920ad369d6ac99c963ed9c57d0c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1522330
Commit-Queue: Daniel Murphy <[email protected]>
Reviewed-by: Chase Phillips <[email protected]>
Cr-Commit-Position: refs/heads/master@{#640604} | eaf2e8bce3855d362e53034bd83f0e3aff8714e4 | chrome | bigvul | 1 | null | null | null |
Roll src/third_party/pdfium 9bbc2313bfd2..9384947f47f2 (1 commits)
https://pdfium.googlesource.com/pdfium.git/+log/9bbc2313bfd2..9384947f47f2
git log 9bbc2313bfd2..9384947f47f2 --date=short --no-merges --format='%ad %ae %s'
2019-03-04 [email protected] Do not replace existing objects in CPWL_AppStream::SetAsPushButton
Created with:
gclient setdep -r src/third_party/pdfium@9384947f47f2
The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
BUG=chromium:913320
[email protected]
Change-Id: Ie074e2f575c0cd5b6fc497d08bd6f79eca3e6f83
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1501033
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/master@{#637485} | d8b4303ff94dfe0e1ba7bc38ab2521fe87c7d323 | chrome | bigvul | 1 | null | null | null |
Roll src/third_party/angle f2bf49e20849..3e8a8d5b8567 (2 commits)
https://chromium.googlesource.com/angle/angle.git/+log/f2bf49e20849..3e8a8d5b8567
git log f2bf49e20849..3e8a8d5b8567 --date=short --no-merges --format='%ad %ae %s'
2019-03-21 [email protected] Force new displays on each Windows 7 end2end test.
2019-03-21 [email protected] Work around line loop streaming bug.
Created with:
gclient setdep -r src/third_party/angle@3e8a8d5b8567
The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
BUG=chromium:944454,chromium:943087
[email protected]
Change-Id: I440c87a236ba78746a51bc74ca733e4f2518704d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1534431
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/master@{#643126} | 77bc309e4333f7b8523d4b3fd100cd9027942f80 | chrome | bigvul | 1 | null | null | null |
Make ElementResolveContext hold a ref to the root element's ComputedStyle
Bug: 947029
Change-Id: I167aad139398a808d170f39e72c5eef57f142e11
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556653
Auto-Submit: Alan Cutter <[email protected]>
Commit-Queue: Rune Lillesveen <[email protected]>
Reviewed-by: Rune Lillesveen <[email protected]>
Cr-Commit-Position: refs/heads/master@{#650001} | 09f046d4a935c739f364c531c3b0059121e8a98e | chrome | bigvul | 1 | null | null | null |
Fix a crash on FileChooserImpl
If a renderer process is compromised, and it calls both of
FileChooserImpl::OpenFileChooser() and EnumerateChosenDirectory() via
Mojo, the browser process could crash because ResetOwner() for
the first FileChooserImpl::proxy_ instance was not called. We
should check nullness of proxy_ before updating it.
Bug: 941008
Change-Id: Ie0c1895ec46ce78d40594b543e49e43b420af675
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520509
Reviewed-by: Avi Drissman <[email protected]>
Commit-Queue: Kent Tamura <[email protected]>
Cr-Commit-Position: refs/heads/master@{#640580} | 4a3482693491ac6bb3dd27d591efa3de1d1f1fcf | chrome | bigvul | 1 | null | null | null |
[autofill] Pin preview font-family to a system font
Bug: 916838
Change-Id: I4e874105262f2e15a11a7a18a7afd204e5827400
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1423109
Reviewed-by: Fabio Tirelo <[email protected]>
Reviewed-by: Koji Ishii <[email protected]>
Commit-Queue: Roger McFarlane <[email protected]>
Cr-Commit-Position: refs/heads/master@{#640884} | 0bd10e13a008389ec14bbe7cc95f17d82ea151c1 | chrome | bigvul | 1 | null | null | null |
ServiceWorker: Add WPT to check if CSP sandbox is respected
Bug: 771815
Change-Id: I11dc3cf67e3e40465f612f71fc318fd7061b6581
Reviewed-on: https://chromium-review.googlesource.com/915683
Reviewed-by: Matt Falkenhagen <[email protected]>
Commit-Queue: Makoto Shimazu <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540467} | 4ffad4c407bc6e60b6c2f021a5a26abb8dc438d2 | chrome | bigvul | 1 | null | null | null |
[iOS] Fix progress bar visibility
This CL fixes the progress bar visibility, which could be fooled when
the state was changing too quickly. For example, if the loading state
was changing during the hide animation, the progress bar wasn't shown
again.
Bug: 925598
Change-Id: Ief9d7cff09724467b244fa1aadecc7a41f7ac0ec
Reviewed-on: https://chromium-review.googlesource.com/c/1489238
Reviewed-by: Justin Cohen <[email protected]>
Commit-Queue: Gauthier Ambard <[email protected]>
Cr-Commit-Position: refs/heads/master@{#635981} | b40348af225a6c6bbbc85317437a315df6554f76 | chrome | bigvul | 1 | null | null | null |
Add tests for CORS safety in toDataURL()
Bug: 930057
Change-Id: If4363152bb6a552fe70120b98318de41d87a4952
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1468005
Reviewed-by: Fernando Serboncini <[email protected]>
Commit-Queue: Aaron Krajeski <[email protected]>
Cr-Commit-Position: refs/heads/master@{#643830} | e29b67156925d6a5d28f9a020cc8ffab8cfdfbb6 | chrome | bigvul | 1 | null | null | null |
Roll libxml, libxslt, that fixes a bug
libxslt fixed an issue with type confusion in xmlXPathNextPrecedingSibling.
[email protected]
BUG=930663
Change-Id: Ib8055551b370c7d64957152e0fda57090110dee8
Reviewed-on: https://chromium-review.googlesource.com/c/1477805
Commit-Queue: Stephen Chenney <[email protected]>
Reviewed-by: Daniel Cheng <[email protected]>
Cr-Commit-Position: refs/heads/master@{#634510} | ee86799b2b90cd65e31a42e65fef44c58691285d | chrome | bigvul | 1 | null | null | null |
android: Stop child process in GetTerminationInfo
Android currently abuses TerminationStatus to pass whether process is
"oom protected" rather than whether it has died or not. This confuses
cross-platform code about the state process.
Only TERMINATION_STATUS_STILL_RUNNING is treated as still running, which
android never passes. Also it appears to be ok to kill the process in
getTerminationInfo as it's only called when the child process is dead or
dying. Also posix kills the process on some calls.
Bug: 940245
Change-Id: Id165711848c279bbe77ef8a784c8cf0b14051877
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1516284
Reviewed-by: Robert Sesek <[email protected]>
Reviewed-by: ssid <[email protected]>
Commit-Queue: Bo <[email protected]>
Cr-Commit-Position: refs/heads/master@{#639639} | 37a0e90a956194a066dd31edd5b5ac5045701d31 | chrome | bigvul | 1 | null | null | null |
Roll src/third_party/angle 12b25347dc68..896e7ded5f25 (2 commits)
https://chromium.googlesource.com/angle/angle.git/+log/12b25347dc68..896e7ded5f25
git log 12b25347dc68..896e7ded5f25 --date=short --no-merges --format='%ad %ae %s'
2019-04-04 [email protected] Use compressed internal format as 'format' in tables.
2019-04-04 [email protected] Minor cleanups to copy vertex.
Created with:
gclient setdep -r src/third_party/angle@896e7ded5f25
The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
BUG=chromium:943709
[email protected]
Change-Id: Ib25e71b05301b9dcf879a9212e72effce69ef991
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553659
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/master@{#647847} | d8cb3a5cfade5fd81d42b1507a4a73c0c3ea033a | chrome | bigvul | 1 | null | null | null |
Cleanup media BitReader ReadBits() calls
Initialize temporary values, check return values.
Small tweaks to solution proposed by [email protected].
Bug: 929962
Change-Id: Iaa7da7534174882d040ec7e4c353ba5cd0da5735
Reviewed-on: https://chromium-review.googlesource.com/c/1481085
Commit-Queue: Chrome Cunningham <[email protected]>
Reviewed-by: Dan Sanders <[email protected]>
Cr-Commit-Position: refs/heads/master@{#634889} | 929f77d4173022a731ae91218ce6894d20f87f35 | chrome | bigvul | 1 | null | null | null |
[DevTools] Escape exclamation points in copy as curl
Bug: 919356
Change-Id: I8b7769f6d6fef258f31dd16367d54b505284a7d8
Reviewed-on: https://chromium-review.googlesource.com/c/1437265
Commit-Queue: Joey Arhar <[email protected]>
Reviewed-by: Dmitry Gozman <[email protected]>
Cr-Commit-Position: refs/heads/master@{#626211} | 0745e0e497bd0c9fd422c824eca50e91abe333c5 | chrome | bigvul | 1 | null | null | null |
Roll src/third_party/pdfium 762247be1246..1ec1b5c17001 (32 commits)
https://pdfium.googlesource.com/pdfium.git/+log/762247be1246..1ec1b5c17001
git log 762247be1246..1ec1b5c17001 --date=short --no-merges --format='%ad %ae %s'
2019-02-08 [email protected] Fix non-standalone build.
2019-02-08 [email protected] Add JavaScript test for CJX_Tree object.
2019-02-08 [email protected] Clean up CFX_RTFBreak::GetDisplayPos() and its caller.
2019-02-08 [email protected] Break circular dependency between xfa/fxfa and xfa/fgas.
2019-02-08 [email protected] Add JavaScript test for CXJ_Model object.
2019-02-08 [email protected] Initialize CPDF_TextPageFind members in the header.
2019-02-08 [email protected] Roll build/ 213e0a3a3..a721f3327 (131 commits)
2019-02-08 [email protected] Reorder hooks to run in a particular order.
2019-02-08 [email protected] Add JavasScript test for CJX_Container methods.
2019-02-08 [email protected] Add JavaScript test for CJX_Node object.
2019-02-07 [email protected] Roll third_party/googletest/src/ 879ac092f..5ec7f0c4a (111 commits)
2019-02-07 [email protected] Roll tools/clang/ 05973b6a9..b23f5a073 (4 commits)
2019-02-07 [email protected] Fix some nits in CFX_FontMgr.
2019-02-07 [email protected] Reland "Add --jitless to recommended v8 flags."
2019-02-07 [email protected] Roll v8/ 817547547..73d4f6ca5 (395 commits)
2019-02-07 [email protected] Roll tools/clang/ 3a16568a5..05973b6a9 (8 commits)
2019-02-07 [email protected] Change pdfium_fuzzer to use render flags.
2019-02-07 [email protected] Consolidate various GetInteger() functions in fuzzers.
2019-02-07 [email protected] Use UnownedPtr in TextGlyphPos.
2019-02-07 [email protected] Limit image positions/sizes in CPDF_ImageRenderer.
2019-02-07 [email protected] Use TextGlyphPos::GetOrigin() in GetGlyphsBBox().
2019-02-07 [email protected] Add JavaScript test for CJX_Subform object.
2019-02-07 [email protected] Roll buildtools/ 2f02e1f36..6fbda1b24 (1 commit)
2019-02-07 [email protected] Check for integer overflows in AdjustGlyphSpace().
2019-02-07 [email protected] Add FPDFSysFontInfoEmbedderTest.
2019-02-07 [email protected] Correctly handle integer overflows in DrawNormalText().
2019-02-07 [email protected] Use TextGlyphPos::GetOrigin() in more places.
2019-02-07 [email protected] image_diff: respect use_system_zlib build argument
2019-02-07 [email protected] Consolidate calculations into TextGlyphPos::GetOrigin().
2019-02-07 [email protected] Roll third_party/depot_tools/ ddbeac1c0..06d1040fa (178 commits; 76 trivial rolls)
2019-02-07 [email protected] Remove a few semicolons.
2019-02-07 [email protected] Roll build and clang.
Created with:
gclient setdep -r src/third_party/pdfium@1ec1b5c17001
The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
BUG=chromium:584393,chromium:662325,chromium:919640,chromium:914983,chromium:919635,chromium:926235,chromium:929475
[email protected]
Change-Id: I8ed183579daed640fcb7fe2a1f31ff59cc81d03d
Reviewed-on: https://chromium-review.googlesource.com/c/1461152
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/master@{#630534} | dfa3bea5f1a205d33a822a935ee2a57d22607ada | chrome | bigvul | 1 | null | null | null |
When turning a download into a navigation, navigate the right frame
Code changes from Nate Chapin <[email protected]>
Bug: 926105
Change-Id: I098599394e6ebe7d2fce5af838014297a337d294
Reviewed-on: https://chromium-review.googlesource.com/c/1454962
Reviewed-by: Camille Lamy <[email protected]>
Commit-Queue: Jochen Eisinger <[email protected]>
Cr-Commit-Position: refs/heads/master@{#629547} | 2f81d000fdb5331121cba7ff81dfaaec25b520a5 | chrome | bigvul | 1 | null | null | null |
Prevent WindowClient.navigate() from cancelling a browser-initiated navigation.
Otherwise, a service worker can prevent you from navigating where you
want to go via the omnibox.
Note: this is similar to WebContentsImpl::OnGoToEntryAtOffset() for
renderer-initiated history navigations.
Bug: 930154
Change-Id: I3a687ccc8ba4420d2369adb24f63c2702bdeeff1
Reviewed-on: https://chromium-review.googlesource.com/c/1477454
Commit-Queue: Matt Falkenhagen <[email protected]>
Commit-Queue: Arthur Sonzogni <[email protected]>
Reviewed-by: Arthur Sonzogni <[email protected]>
Auto-Submit: Matt Falkenhagen <[email protected]>
Cr-Commit-Position: refs/heads/master@{#633231} | e8bf23bbbc3976d6a3418a7298a39bbf35c7beb3 | chrome | bigvul | 1 | null | null | null |
Clean up CanvasResourceDispatcher on finalizer
We may have pending mojo messages after GC, so we want to drop the
dispatcher as soon as possible.
Bug: 929757,913964
Change-Id: I5789bcbb55aada4a74c67a28758f07686f8911c0
Reviewed-on: https://chromium-review.googlesource.com/c/1489175
Reviewed-by: Ken Rockot <[email protected]>
Commit-Queue: Ken Rockot <[email protected]>
Commit-Queue: Fernando Serboncini <[email protected]>
Auto-Submit: Fernando Serboncini <[email protected]>
Cr-Commit-Position: refs/heads/master@{#635833} | 6a7063ae61cf031630b48bdcdb09863ffc199962 | chrome | bigvul | 1 | null | null | null |
[FileSystem] Harden against overflows of OperationID a bit better.
Rather than having a UAF when OperationID overflows instead overwrite
the old operation with the new one. Can still cause weirdness, but at
least won't result in UAF. Also update OperationID to uint64_t to
make sure we don't overflow to begin with.
Bug: 925864
Change-Id: Ifdf3fa0935ab5ea8802d91bba39601f02b0dbdc9
Reviewed-on: https://chromium-review.googlesource.com/c/1441498
Commit-Queue: Marijn Kruisselbrink <[email protected]>
Reviewed-by: Victor Costan <[email protected]>
Cr-Commit-Position: refs/heads/master@{#627115} | b38064dbb21aaf32151073dcb7d594b240c68f73 | chrome | bigvul | 1 | null | null | null |
Web MIDI: Make TaskService and MidiManagerWin integer-overflow-proof
TaskService and MidiManagerWin uses int to identify the instance,
but this change makes it int64_t and improve them to fail gracefully
without shutting-down the browser due to CHECK failures.
For practical use, the original int is enough and it's impossible
to overflow the instance ID unless attackers success to run their code
for several months on an occupied active processor.
Bug: 921581
Change-Id: I62c7cd737ab3d3969e372bb394e60381473eaa58
Reviewed-on: https://chromium-review.googlesource.com/c/1449483
Reviewed-by: Yutaka Hirano <[email protected]>
Commit-Queue: Takashi Toyoshima <[email protected]>
Cr-Commit-Position: refs/heads/master@{#631175} | c3fe3dc27d10a53a54bb5231b6fce07318af952f | chrome | bigvul | 1 | null | null | null |
Move user activation check to RemoteFrame::Navigate's callers.
Currently RemoteFrame::Navigate is the user of
Frame::HasTransientUserActivation that passes a RemoteFrame*, and
it seems wrong because the user activation (user gesture) needed by
the navigation should belong to the LocalFrame that initiated the
navigation.
Follow-up CLs after this one will update UserActivation code in
Frame to take a LocalFrame* instead of a Frame*, and get rid of
redundant IPCs.
Bug: 811414
Change-Id: I771c1694043edb54374a44213d16715d9c7da704
Reviewed-on: https://chromium-review.googlesource.com/914736
Commit-Queue: Mustaq Ahmed <[email protected]>
Reviewed-by: Daniel Cheng <[email protected]>
Cr-Commit-Position: refs/heads/master@{#536728} | 88fcb3a6899d77b64195423333ad81a00803f997 | chrome | bigvul | 1 | null | null | null |
arc: add test for blocking incognito windows in screenshot
BUG=778852
TEST=ArcVoiceInteractionFrameworkServiceUnittest.
CapturingScreenshotBlocksIncognitoWindows
Change-Id: I0bfa5a486759783d7c8926a309c6b5da9b02dcc6
Reviewed-on: https://chromium-review.googlesource.com/914983
Commit-Queue: Muyuan Li <[email protected]>
Reviewed-by: Luis Hector Chavez <[email protected]>
Cr-Commit-Position: refs/heads/master@{#536438} | 227851d714bdc081de4c7e81669420380fa6c000 | chrome | bigvul | 1 | null | null | null |
Update chrome.dashboardPrivate API match
Bug: 937487
Change-Id: I2d985e28c56d4a7626e3d0c11a8be6d31499a66b
Reviewed-on: https://chromium-review.googlesource.com/c/1497631
Reviewed-by: Devlin <[email protected]>
Commit-Queue: Christopher Thompson <[email protected]>
Cr-Commit-Position: refs/heads/master@{#637049} | 1b661f83324b837ac34725c639d998d6ff23ff1d | chrome | bigvul | 1 | null | null | null |
Show an error page if a URL redirects to a javascript: URL.
BUG=935175
Change-Id: Id4a9198d5dff823bc3d324b9de9bff2ee86dc499
Reviewed-on: https://chromium-review.googlesource.com/c/1488152
Commit-Queue: Charlie Reis <[email protected]>
Reviewed-by: Arthur Sonzogni <[email protected]>
Cr-Commit-Position: refs/heads/master@{#635848} | 56b512399a5c2221ba4812f5170f3f8dc352cd74 | chrome | bigvul | 1 | null | null | null |
WebUI: Update Polymer iron-collapse, iron-overlay-behavior to 2.x.
Bug: 738611
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I7f3649304443c82c7604d4ba4c9e2ef0b966c5f1
Reviewed-on: https://chromium-review.googlesource.com/919643
Reviewed-by: Hector Carmona <[email protected]>
Commit-Queue: Demetrios Papadopoulos <[email protected]>
Cr-Commit-Position: refs/heads/master@{#536919} | 2c8502d301e410b09c8b5859268fc297814fbdbb | chrome | bigvul | 1 | null | null | null |
[GuestView] - Introduce MimeHandlerViewAttachHelper
This CL is for the most part a mechanical change which extracts almost
all the frame-based MimeHandlerView code out of
ExtensionsGuestViewMessageFilter. This change both removes the current
clutter form EGVMF as well as fixesa race introduced when the
frame-based logic was added to EGVMF. The reason for the race was that
EGVMF is destroyed on IO thread but all the access to it (for
frame-based MHV) are from UI.
[email protected],[email protected]
Bug: 659750, 896679, 911161, 918861
Change-Id: I6474b870e4d56daa68be03637bb633665d9f9dda
Reviewed-on: https://chromium-review.googlesource.com/c/1401451
Commit-Queue: Ehsan Karamad <[email protected]>
Reviewed-by: James MacLean <[email protected]>
Reviewed-by: Ehsan Karamad <[email protected]>
Cr-Commit-Position: refs/heads/master@{#621155} | 5bb223676defeba9c44a5ce42460c86e24561e73 | chrome | bigvul | 1 | null | null | null |
Fixing BadMessageCallback usage by SessionStorage
TBR: [email protected]
Bug: 916523
Change-Id: I027cc818cfba917906844ad2ec0edd7fa4761bd1
Reviewed-on: https://chromium-review.googlesource.com/c/1401604
Commit-Queue: Daniel Murphy <[email protected]>
Reviewed-by: Marijn Kruisselbrink <[email protected]>
Reviewed-by: Ken Rockot <[email protected]>
Cr-Commit-Position: refs/heads/master@{#621772} | ba169c14aa9cc2efd708a878ae21ff34f3898fe0 | chrome | bigvul | 1 | null | null | null |
Roll src/third_party/skia 36c4fb3fa1bc..6f27489c6502 (3 commits)
https://skia.googlesource.com/skia.git/+log/36c4fb3fa1bc..6f27489c6502
git log 36c4fb3fa1bc..6f27489c6502 --date=short --no-merges --format='%ad %ae %s'
2018-12-18 [email protected] Use SkFont for managing distance field text
2018-12-18 [email protected] Remove window rects flag from GrInternalSurfaceFlags.
2018-12-18 [email protected] add regression test for stale fLastMoveToIndex
Created with:
gclient setdep -r src/third_party/skia@6f27489c6502
The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
BUG=chromium:883596
[email protected]
Change-Id: I153371f5fecf50c441c0076699a5dd24ab481369
Reviewed-on: https://chromium-review.googlesource.com/c/1382761
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/master@{#617620} | d154dc02ff4cb383a6b4f0782ea71c121b03578c | chrome | bigvul | 1 | null | null | null |
Inherit the navigation initiator when navigating instead of the parent/opener
Spec PR: https://github.com/w3c/webappsec-csp/pull/358
Bug: 905301, 894228, 836148
Change-Id: I43ada2266d42d1cd56dbe3c6dd89d115e878a83a
Reviewed-on: https://chromium-review.googlesource.com/c/1314633
Commit-Queue: Andy Paicu <[email protected]>
Reviewed-by: Mike West <[email protected]>
Cr-Commit-Position: refs/heads/master@{#610850} | 108147dfd1ea159fd3632ef92ccc4ab8952980c7 | chrome | bigvul | 1 | null | null | null |
[iOS] Fixed omnibox state being corrupted after presenting js alert
This CL fixes a bug where the omnibox state would be incorrect after
presenting a javascript alert in the middle of opening a new tab.
The root cause is that the omnibox focus methods are called in the
middle of a previous animation, so they were ignored. To fix this, we
store the expected final state of the omnibox, and set the state to that
after the animations finish.
Bug: 921390
Change-Id: Ibd4e8e857621344e4397153400e6dc4b43617c5c
Reviewed-on: https://chromium-review.googlesource.com/c/1434285
Commit-Queue: Robbie Gibson <[email protected]>
Reviewed-by: Stepan Khapugin <[email protected]>
Cr-Commit-Position: refs/heads/master@{#626618} | df5b958678c91506562ccea5088ebefe473fc785 | chrome | bigvul | 1 | null | null | null |
Add kOpenerNavigationDownloadCrossOriginNoGesture to UKM whitelist
Bug: 632514
Change-Id: Ibd09c4d8635873e02f9b484ec720b71ae6e3588f
Reviewed-on: https://chromium-review.googlesource.com/c/1399521
Reviewed-by: Bryan McQuade <[email protected]>
Commit-Queue: Charlie Harrison <[email protected]>
Cr-Commit-Position: refs/heads/master@{#620513} | 12348a12a8b108baedee2ddbda99948029d363ed | chrome | bigvul | 1 | null | null | null |
Check the source browsing context's CSP in Location::SetLocation prior to dispatching a navigation to a `javascript:` URL.
Makes `javascript:` navigations via window.location.href compliant with
https://html.spec.whatwg.org/#navigate, which states that the source
browsing context must be checked (rather than the current browsing
context).
Bug: 909865
Change-Id: Id6aef6eef56865e164816c67eb9fe07ea1cb1b4e
Reviewed-on: https://chromium-review.googlesource.com/c/1359823
Reviewed-by: Andy Paicu <[email protected]>
Reviewed-by: Mike West <[email protected]>
Commit-Queue: Andrew Comminos <[email protected]>
Cr-Commit-Position: refs/heads/master@{#614451} | 0e3b0c22a5c596bdc24a391b3f02952c1c3e4f1b | chrome | bigvul | 1 | null | null | null |
Ignore switches following "--" when parsing a command line.
BUG=933004
[email protected]
Change-Id: I911be4cbfc38a4d41dec85d85f7fe0f50ddca392
Reviewed-on: https://chromium-review.googlesource.com/c/1481210
Auto-Submit: Greg Thompson <[email protected]>
Commit-Queue: Julian Pastarmov <[email protected]>
Reviewed-by: Julian Pastarmov <[email protected]>
Cr-Commit-Position: refs/heads/master@{#634604} | 08965161257ab9aeef9a3548c1cd1a44525dc562 | chrome | bigvul | 1 | null | null | null |
FileReader: Make a copy of the ArrayBuffer when returning partial results.
This is to avoid accidentally ending up with multiple references to the
same underlying ArrayBuffer. The extra performance overhead of this is
minimal as usage of partial results is very rare anyway (as can be seen
on https://www.chromestatus.com/metrics/feature/timeline/popularity/2158).
Bug: 936448
Change-Id: Icd1081adc1c889829fe7fa4af9cf4440097e8854
Reviewed-on: https://chromium-review.googlesource.com/c/1492873
Commit-Queue: Marijn Kruisselbrink <[email protected]>
Reviewed-by: Adam Klein <[email protected]>
Cr-Commit-Position: refs/heads/master@{#636251} | ba9748e78ec7e9c0d594e7edf7b2c07ea2a90449 | chrome | bigvul | 1 | null | null | null |
Fix a bug in network_session_configurator.cc in which support for HTTPS URLS in QUIC proxies was always set to false.
BUG=914497
Change-Id: I56ad16088168302598bb448553ba32795eee3756
Reviewed-on: https://chromium-review.googlesource.com/c/1417356
Auto-Submit: Ryan Hamilton <[email protected]>
Commit-Queue: Zhongyi Shi <[email protected]>
Reviewed-by: Zhongyi Shi <[email protected]>
Cr-Commit-Position: refs/heads/master@{#623763} | fd2335678e96c34d14f4b20f0d9613dfbd1ccdb4 | chrome | bigvul | 1 | null | null | null |
Roll src/third_party/pdfium 7c39bf7b87f8..1929d6e1d44e (16 commits)
https://pdfium.googlesource.com/pdfium.git/+log/7c39bf7b87f8..1929d6e1d44e
git log 7c39bf7b87f8..1929d6e1d44e --date=short --no-merges --format='%ad %ae %s'
2018-10-15 [email protected] Split pdfium_embeddertests sources.
2018-10-15 [email protected] Move fx_skia_device_unittest.cpp to pdfium_embeddertests.
2018-10-15 [email protected] Split pdfium_unittests sources.
2018-10-15 [email protected] Split public/ headers into their own source_set.
2018-10-15 [email protected] Restrict fxcrt's visibility to third_party.
2018-10-15 [email protected] Clone dict before iteration in CJS_Document::get_info
2018-10-15 [email protected] Use CropBox instead of ArtBox or TrimBox
2018-10-15 [email protected] Convert %s -> %ls for wide string error format.
2018-10-15 [email protected] Make core/ pass gn check.
2018-10-15 [email protected] Use more UnownedPtr in CPDF_FormControl.
2018-10-15 [email protected] Move CPDF_ModuleMgr methods into cpdf_modulemgr.cpp.
2018-10-15 [email protected] Make ":pdfium" pass gn check.
2018-10-15 [email protected] Stop shadowing codec memory size with CCodec_ProgressiveDecoder::m_SrcSize
2018-10-15 [email protected] Make fxjs/ pass gn check.
2018-10-15 [email protected] Make fpdfsdk/ pass gn check.
2018-10-15 [email protected] Make xfa/ pass gn check.
Created with:
gclient setdep -r src/third_party/pdfium@1929d6e1d44e
The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
BUG=chromium:895152,chromium:409670,chromium:895009
[email protected]
Change-Id: I95c8a745294172817f98cc2e21f0110bd5b978cf
Reviewed-on: https://chromium-review.googlesource.com/c/1282322
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/master@{#599835} | 5817b2f8c0d0e184e78bebb8b343688154df5856 | chrome | bigvul | 1 | null | null | null |
Fix SVG crash for v0 distribution into foreignObject.
We require a parent element to be an SVG element for non-svg-root
elements in order to create a LayoutObject for them. However, we checked
the light tree parent element, not the flat tree one which is the parent
for the layout tree construction. Note that this is just an issue in
Shadow DOM v0 since v1 does not allow shadow roots on SVG elements.
Bug: 915469
Change-Id: Id81843abad08814fae747b5bc81c09666583f130
Reviewed-on: https://chromium-review.googlesource.com/c/1382494
Reviewed-by: Fredrik Söderquist <[email protected]>
Commit-Queue: Rune Lillesveen <[email protected]>
Cr-Commit-Position: refs/heads/master@{#617487} | 032c3339bfb454c65ce38e7eafe49a54bac83073 | chrome | bigvul | 1 | null | null | null |
Fix UAP in ImageBitmapLoader/FileReaderLoader
FileReaderLoader stores its client as a raw pointer, so in cases like
ImageBitmapLoader where the FileReaderLoaderClient really is garbage
collected we have to make sure to destroy the FileReaderLoader when
the ExecutionContext that owns it is destroyed.
Bug: 913970
Change-Id: I40b02115367cf7bf5bbbbb8e9b57874d2510f861
Reviewed-on: https://chromium-review.googlesource.com/c/1374511
Reviewed-by: Jeremy Roman <[email protected]>
Commit-Queue: Marijn Kruisselbrink <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616342} | 419c4bfbfb94849ed30dcab7c3aaf67afe238b27 | chrome | bigvul | 1 | null | null | null |
Fix crashes in RenderFrameImpl::OnSelectPopupMenuItem(s)
ExternalPopupMenu::DidSelectItem(s) can delete the RenderFrameImpl.
We need to reset external_popup_menu_ before calling it.
Bug: 912211
Change-Id: Ia9a628e144464a2ebb14ab77d3a693fd5cead6fc
Reviewed-on: https://chromium-review.googlesource.com/c/1381325
Commit-Queue: Kent Tamura <[email protected]>
Reviewed-by: Avi Drissman <[email protected]>
Cr-Commit-Position: refs/heads/master@{#618026} | 5405341d5cc268a0b2ff0678bd78ddda0892e7ea | chrome | bigvul | 1 | null | null | null |
Check weak pointers in RTCPeerConnectionHandler::WebRtcSetDescriptionObserverImpl
Bug: 912074
Change-Id: I8ba86751f5d5bf12db51520f985ef0d3dae63ed8
Reviewed-on: https://chromium-review.googlesource.com/c/1411916
Commit-Queue: Guido Urdaneta <[email protected]>
Reviewed-by: Henrik Boström <[email protected]>
Cr-Commit-Position: refs/heads/master@{#622945} | 3514a77e7fa2e5b8bfe5d98af22964bbd69d680f | chrome | bigvul | 1 | null | null | null |
Roll src/third_party/pdfium ab688385cfbd..a69842065243 (5 commits)
https://pdfium.googlesource.com/pdfium.git/+log/ab688385cfbd..a69842065243
git log ab688385cfbd..a69842065243 --date=short --no-merges --format='%ad %ae %s'
2018-11-01 [email protected] Update third_party/yasm/BUILD.gn.
2018-11-01 [email protected] Roll third_party/skia/ edc6ea7a9..b98fb5b08 (131 commits; 1 trivial rolls)
2018-11-01 [email protected] Roll third_party/skia/ ffbcc3fad..edc6ea7a9 (1 commit)
2018-11-01 [email protected] Make CPDF_ContentMarkItem stop caching the properties dict.
2018-11-01 [email protected] Remove notion of file writing from CFX_GlobalData
Created with:
gclient setdep -r src/third_party/pdfium@a69842065243
The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
BUG=chromium:900552
[email protected]
Change-Id: Iaa3e70c669163835e43a0ca57563cd4406d90b3d
Reviewed-on: https://chromium-review.googlesource.com/c/1313032
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/master@{#604650} | 02cff454e822c3abb7b04566f7ab9e08d264b3fa | chrome | bigvul | 1 | null | null | null |
Roll src/third_party/libvpx/source/libvpx/ 18d260d13..d8f89c49e (2 commits)
https://chromium.googlesource.com/webm/libvpx.git/+log/18d260d13f2b..d8f89c49e17b
$ git log 18d260d13..d8f89c49e --date=short --no-merges --format='%ad %ae %s'
2018-12-14 jianj vp8: Fix potential use-after-free in mfqe.
2018-12-13 sdeng Remove unused code in tiny_ssim
Created with:
roll-dep src/third_party/libvpx/source/libvpx
[email protected]
BUG=913246
Change-Id: I886386eaf644c2c5c85234451c5fd53a042920a2
Reviewed-on: https://chromium-review.googlesource.com/c/1380536
Commit-Queue: Johann Koenig <[email protected]>
Reviewed-by: Johann Koenig <[email protected]>
Cr-Commit-Position: refs/heads/master@{#617232} | e98039d222ec63c6cc76600f7bccbbb8ff8c1dc3 | chrome | bigvul | 1 | null | null | null |
Disable FileSystemManager::CreateWriter if WritableFiles isn't enabled.
Bug: 922677
Change-Id: Ib16137cbabb2ec07f1ffc0484722f1d9cc533404
Reviewed-on: https://chromium-review.googlesource.com/c/1416570
Commit-Queue: Marijn Kruisselbrink <[email protected]>
Reviewed-by: Victor Costan <[email protected]>
Cr-Commit-Position: refs/heads/master@{#623552} | f045c704568e9cf6279b3cbccbec6d86c35f8a13 | chrome | bigvul | 1 | null | null | null |
Only enable tracing broadcasts on debug Android.
Don't register the tracing broadcast receiver unless we're on a debug
build of the OS. Regular usage of tracing should be using the DevTools
API, not the old adb_profile_chrome script that uses this broadcast.
Bug: 898816, 922627
Change-Id: Ibf172dab29da878000ab60f48bed6e1862aa35e8
Reviewed-on: https://chromium-review.googlesource.com/c/1416171
Reviewed-by: Bo <[email protected]>
Reviewed-by: Eric Seckler <[email protected]>
Reviewed-by: Sami Kyöstilä <[email protected]>
Commit-Queue: Richard Coles <[email protected]>
Cr-Commit-Position: refs/heads/master@{#623691} | f68b18e1ec1cadb432998d3ccc084e0a8c1ae5cd | chrome | bigvul | 1 | null | null | null |
[Payment Request][Desktop] Prevent use after free.
Before this patch, a compromised renderer on desktop could make IPC
methods into Payment Request in an unexpected ordering and cause use
after free in the browser.
This patch will disconnect the IPC pipes if:
- Init() is called more than once.
- Any other method is called before Init().
- Show() is called more than once.
- Retry(), UpdateWith(), NoupdatedPaymentDetails(), Abort(), or
Complete() are called before Show().
This patch re-orders the IPC methods in payment_request.cc to match the
order in payment_request.h, which eases verifying correctness of their
error handling.
This patch prints more errors to the developer console, if available, to
improve debuggability by web developers, who rarely check where LOG
prints.
After this patch, unexpected ordering of calls into the Payment Request
IPC from the renderer to the browser on desktop will print an error in
the developer console and disconnect the IPC pipes. The binary might
increase slightly in size because more logs are included in the release
version instead of being stripped at compile time.
Bug: 912947
Change-Id: Iac2131181c64cd49b4e5ec99f4b4a8ae5d8df57a
Reviewed-on: https://chromium-review.googlesource.com/c/1370198
Reviewed-by: anthonyvd <[email protected]>
Commit-Queue: Rouslan Solomakhin <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616822} | 2706470a422dec8f4ae2538e80f0e7e3c4f4f7f6 | chrome | bigvul | 1 | null | null | null |
Make MediaStreamDispatcherHost per-request instead of per-frame.
Instead of having RenderFrameHost own a single MSDH to handle all
requests from a frame, MSDH objects will be owned by a strong binding.
A consequence of this is that an additional requester ID is added to
requests to MediaStreamManager, so that an MSDH is able to cancel only
requests generated by it.
In practice, MSDH will continue to be per frame in most cases since
each frame normally makes a single request for an MSDH object.
This fixes a lifetime issue caused by the IO thread executing tasks
after the RenderFrameHost dies.
Drive-by: Fix some minor lint issues.
Bug: 912520
Change-Id: I52742ffc98b9fc57ce8e6f5093a61aed86d3e516
Reviewed-on: https://chromium-review.googlesource.com/c/1369799
Reviewed-by: Emircan Uysaler <[email protected]>
Reviewed-by: Ken Buchanan <[email protected]>
Reviewed-by: Olga Sharonova <[email protected]>
Commit-Queue: Guido Urdaneta <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616347} | 971548cdca2d4c0a6fedd3db0c94372c2a27eac3 | chrome | bigvul | 1 | null | null | null |
rm flag and rebaseline
Bug: 899689
Change-Id: Ie69dda53e3be3b2ec1113cea5f763e2e016f26bd
Reviewed-on: https://chromium-review.googlesource.com/c/1358693
Commit-Queue: Mike Reed <[email protected]>
Reviewed-by: Florin Malita <[email protected]>
Cr-Commit-Position: refs/heads/master@{#613288} | 4e59d6660a2bbbf17b6582b45848782b92371250 | chrome | bigvul | 1 | null | null | null |
WPT: service worker: canvas tainting with two images from the same URL
This adds a test that does the following:
- Writes to a canvas with a cors same-origin image
- Writes to a canvas with a cors cross-origin image from the same URL
- Tests that the canvas is tainted after the second step.
Bug: 907047
Change-Id: Ie231b442eb9b55c642b3957c065555e6f4997a83
Reviewed-on: https://chromium-review.googlesource.com/c/1347952
Commit-Queue: Matt Falkenhagen <[email protected]>
Reviewed-by: Makoto Shimazu <[email protected]>
Cr-Commit-Position: refs/heads/master@{#610356} | 48d01db7e4858ad06cebaea89aa55575ee1bdd42 | chrome | bigvul | 1 | null | null | null |
Filter focus for buttons when there are overlays on top
Bug: 902427
Change-Id: Ida893cf41478976f4d3784091a79385db69ef1f0
Reviewed-on: https://chromium-review.googlesource.com/c/1324450
Reviewed-by: Ted Choc <[email protected]>
Commit-Queue: Becky Zhou <[email protected]>
Cr-Commit-Position: refs/heads/master@{#606212} | 0d7b74a398de964f71cf79eb216de001e0a9a3d5 | chrome | bigvul | 1 | null | null | null |
[DevTools] Guard DOM.setFileInputFiles under MayAffectLocalFiles
Bug: 805557
Change-Id: Ib6f37ec6e1d091ee54621cc0c5c44f1a6beab10f
Reviewed-on: https://chromium-review.googlesource.com/c/1334847
Reviewed-by: Pavel Feldman <[email protected]>
Commit-Queue: Dmitry Gozman <[email protected]>
Cr-Commit-Position: refs/heads/master@{#607902} | 7aaf7e9031ee16b9d4212fa0bc03d94713b3261b | chrome | bigvul | 1 | null | null | null |
Fix crash in RunInfo::NumGraphemes
Fix crash in NumGraphemes when called with an invalid end char position.
Bug: 913975
Test: fast/text/international/ar_tab_selection_crash.html
Change-Id: I93a94ba04e3e02b10ac8ef4186cf606b7df5c859
Reviewed-on: https://chromium-review.googlesource.com/c/1374630
Commit-Queue: Koji Ishii <[email protected]>
Reviewed-by: Koji Ishii <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616145} | 8c7054864ea9b70015351b17376b8515296efb8f | chrome | bigvul | 1 | null | null | null |
Validate glClearBuffer*v function |buffer| param on the client side
Otherwise we could read out-of-bounds even if an invalid |buffer| is passed
in and in theory we should not read the buffer at all.
BUG=908749
TEST=gl_tests in ASAN build
[email protected]
Change-Id: I94b69b56ce3358ff9bfc0e21f0618aec4371d1ec
Reviewed-on: https://chromium-review.googlesource.com/c/1354571
Reviewed-by: Antoine Labour <[email protected]>
Commit-Queue: Zhenyao Mo <[email protected]>
Cr-Commit-Position: refs/heads/master@{#612023} | 5f8761dd073c4ddd3b5aea8d95a2717e7b6e36e5 | chrome | bigvul | 1 | null | null | null |
Roll SwiftShader 8f20452..a972758
https://swiftshader.googlesource.com/SwiftShader.git/+log/8f20452..a972758
BUG=chromium:904265
TEST=bots
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I6b5a14c70cc6f3324542923b95bf2f1a87b336cc
Reviewed-on: https://chromium-review.googlesource.com/c/1355524
Reviewed-by: Alexis Hétu <[email protected]>
Commit-Queue: Nicolas Capens <[email protected]>
Cr-Commit-Position: refs/heads/master@{#612385} | dfe266e269441ae61b64272e5550d44a2c3f7faf | chrome | bigvul | 1 | null | null | null |
Add .desktop file to download_file_types.asciipb
.desktop files act as shortcuts on Linux, allowing arbitrary code
execution. We should send pings for these files.
Bug: 904182
Change-Id: Ibc26141fb180e843e1ffaf3f78717a9109d2fa9a
Reviewed-on: https://chromium-review.googlesource.com/c/1344552
Reviewed-by: Varun Khaneja <[email protected]>
Commit-Queue: Daniel Rubery <[email protected]>
Cr-Commit-Position: refs/heads/master@{#611272} | b32471d5abb3b3a4fe56e1dd79871400b51a0cca | chrome | bigvul | 1 | null | null | null |
Mapping several Indic characters to confusables.
A number of characters from several Indian scripts are confusable,
especially with numbers. This change maps these characters to their
ASCII lookalike to allow fallback to punycode when displaying probable
spoofing URLs.
Bug: 849421
Bug: 892646
Bug: 896722
Change-Id: I6d463642f3541454dc39bf4b32b8291417697c52
Reviewed-on: https://chromium-review.googlesource.com/c/1295179
Reviewed-by: Tommy Li <[email protected]>
Commit-Queue: Joe DeBlasio <[email protected]>
Cr-Commit-Position: refs/heads/master@{#602032} | af38308b7112bdfbc0cfcc27f966314accc471d0 | chrome | bigvul | 1 | null | null | null |
Include U+0517 in set of Cyrillic/Latin lookalikes.
Cyrillic letter U+0517 (ԗ) looks somewhat similar to the Latin letter p.
This CL adds this character to the set of Cyrillic characters that look
like Latin characters. Domains made up entirely of Cyrillic/Latin
lookalikes are displayed as punycode in URLs.
Bug: 863663
Change-Id: I4340c48d124c9c4cd3d3b5d0f9d3865d709e082d
Reviewed-on: https://chromium-review.googlesource.com/c/1286825
Commit-Queue: Joe DeBlasio <[email protected]>
Commit-Queue: Peter Kasting <[email protected]>
Reviewed-by: Peter Kasting <[email protected]>
Cr-Commit-Position: refs/heads/master@{#600582} | 4d666348de3f67d5cb7b5401f0f69f6b9d3719eb | chrome | bigvul | 1 | null | null | null |
Disable setxattr calls from quarantine subsystem on Chrome OS.
BUG=733943
Change-Id: I6e743469a8dc91536e180ecf4ff0df0cf427037c
Reviewed-on: https://chromium-review.googlesource.com/c/1380571
Commit-Queue: Will Harris <[email protected]>
Reviewed-by: Raymes Khoury <[email protected]>
Reviewed-by: David Trainor <[email protected]>
Reviewed-by: Thiemo Nagel <[email protected]>
Cr-Commit-Position: refs/heads/master@{#617961} | 2f01a0cb03732fdb982dd42786d95736322d2241 | chrome | bigvul | 1 | null | null | null |
[Extensions] Have URLPattern::Contains() properly check schemes
Have URLPattern::Contains() properly check the schemes of the patterns
when evaluating if one pattern contains another. This is important in
order to prevent extensions from requesting chrome:-scheme permissions
via the permissions API when <all_urls> is specified as an optional
permission.
Bug: 859600,918470
Change-Id: If04d945ad0c939e84a80d83502c0f84b6ef0923d
Reviewed-on: https://chromium-review.googlesource.com/c/1396561
Commit-Queue: Devlin <[email protected]>
Reviewed-by: Karan Bhatia <[email protected]>
Cr-Commit-Position: refs/heads/master@{#621410} | e13eb21898c7eba584f680e3d17ca1b9e28bc505 | chrome | bigvul | 1 | null | null | null |
service worker: Make navigate/openWindow go through more security checks.
WindowClient.navigate() and Clients.openWindow() were implemented in
a way that directly navigated to the URL without going through
some checks that the normal navigation path goes through. This CL
attempts to fix that:
- WindowClient.navigate() now goes through Navigator::RequestOpenURL()
instead of directly through WebContents::OpenURL().
- Clients.openWindow() now calls more ContentBrowserClient functions
for manipulating the navigation before invoking
ContentBrowserClient::OpenURL().
Bug: 904219
Change-Id: Ic38978aee98c09834fdbbc240164068faa3fd4f5
Reviewed-on: https://chromium-review.googlesource.com/c/1345686
Commit-Queue: Matt Falkenhagen <[email protected]>
Reviewed-by: Arthur Sonzogni <[email protected]>
Reviewed-by: Kinuko Yasuda <[email protected]>
Cr-Commit-Position: refs/heads/master@{#610753} | 18c5c5dcef9cfccff64f0c23f920ef22822271a9 | chrome | bigvul | 1 | null | null | null |
mac: Do not let synthetic events toggle "Allow JavaScript From AppleEvents"
Bug: 891697
Change-Id: I49eb77963515637df739c9d2ce83530d4e21cf15
Reviewed-on: https://chromium-review.googlesource.com/c/1308771
Reviewed-by: Elly Fong-Jones <[email protected]>
Commit-Queue: Robert Sesek <[email protected]>
Cr-Commit-Position: refs/heads/master@{#604268} | 0328261c41b1b7495e1d4d4cf958f41a08aff38b | chrome | bigvul | 1 | null | null | null |
[DevTools] Fix request preview for URI encoded html
Bug: 895081
Change-Id: I49c6131e1cc432e470e4b04353282d3ebebcb063
Reviewed-on: https://chromium-review.googlesource.com/c/1286758
Reviewed-by: Dmitry Gozman <[email protected]>
Commit-Queue: Joey Arhar <[email protected]>
Cr-Commit-Position: refs/heads/master@{#601792} | 0238c6b5064859f39ff5f6d3265712093934b2a7 | chrome | bigvul | 1 | null | null | null |
Make {First,Last}AssignedNode() be aware of Incremental Shadow DOM
Prevent a possible wrong usage of {First,Last}AssignedNode().
Bug: 776656
Change-Id: I5d84b062c92cd89e40e3c051ae08bcefea658d25
Reviewed-on: https://chromium-review.googlesource.com/896725
Reviewed-by: Takayoshi Kochi <[email protected]>
Reviewed-by: Rune Lillesveen <[email protected]>
Commit-Queue: Hayato Ito <[email protected]>
Cr-Commit-Position: refs/heads/master@{#533898} | 3509b4a360edec9f566ae5d3cb5fe16878845a70 | chrome | bigvul | 1 | null | null | null |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.