commit_msg
stringlengths 1
24.2k
| commit_hash
stringlengths 2
84
⌀ | project
stringlengths 2
40
| source
stringclasses 4
values | labels
int64 0
1
| repo_url
stringlengths 26
70
⌀ | commit_url
stringlengths 74
118
⌀ | commit_date
stringlengths 25
25
⌀ |
|---|---|---|---|---|---|---|---|
Harden gpu::SizedResult against overflow
Use CheckedNumerics to prevent silent uint32_t overflow.
Bug: 905336, 905459
Change-Id: Ie518def9063143ef2393be566419a209f68f0dce
Reviewed-on: https://chromium-review.googlesource.com/c/1336083
Reviewed-by: Kenneth Russell <[email protected]>
Reviewed-by: Abhishek Arya <[email protected]>
Commit-Queue: Antoine Labour <[email protected]>
Cr-Commit-Position: refs/heads/master@{#608184} | ae5822065fc801142b4d0c312b2d718985a0bd97 | chrome | bigvul | 1 | null | null | null |
Roll src/third_party/skia c5c3df66430a..73be50da2a1f (6 commits)
https://skia.googlesource.com/skia.git/+log/c5c3df66430a..73be50da2a1f
git log c5c3df66430a..73be50da2a1f --date=short --no-merges --format='%ad %ae %s'
2018-06-22 [email protected] flush to zero tiny radii
2018-06-22 [email protected] Reland "Implement onMakeClone(const SkFontArguments& args) in class SkTypeface_fontconfig."
2018-06-22 [email protected] Revert "Implement onMakeClone(const SkFontArguments& args) in class SkTypeface_fontconfig."
2018-06-22 [email protected] Roll recipe dependencies (trivial).
2018-06-22 swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/swiftshader 932640b2d9cd..41b7748432ef (1 commits)
2018-06-22 [email protected] ccpr: Cache paths with >=50% visibility
Created with:
gclient setdep -r src/third_party/skia@73be50da2a1f
The AutoRoll server is located here: https://autoroll.skia.org
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
BUG=chromium:850350
[email protected]
Change-Id: If796430eb5b441f4e984e7e76df09b731eb35e33
Reviewed-on: https://chromium-review.googlesource.com/1112230
Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#569853} | 44982312083ebb2b3d2ccc713046add5fe458e73 | chrome | bigvul | 1 | null | null | null |
Validate all incoming WebGLObjects.
A few entry points were missing the correct validation.
Tested with improved conformance tests in
https://github.com/KhronosGroup/WebGL/pull/2654 .
Bug: 848914
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ib98a61cc5bf378d1b3338b04acd7e1bc4c2fe008
Reviewed-on: https://chromium-review.googlesource.com/1086718
Reviewed-by: Kai Ninomiya <[email protected]>
Reviewed-by: Antoine Labour <[email protected]>
Commit-Queue: Kenneth Russell <[email protected]>
Cr-Commit-Position: refs/heads/master@{#565016} | 98095c718d7580b5d6715e5bfd8698234ecb4470 | chrome | bigvul | 1 | null | null | null |
Roll src/third_party/libvpx/source/libvpx/ 36825590b..2b08f8907 (3 commits)
https://chromium.googlesource.com/webm/libvpx.git/+log/36825590ba67..2b08f89076d1
$ git log 36825590b..2b08f8907 --date=short --no-merges --format='%ad %ae %s'
2018-05-25 marpan vp9-realtime: Move frame dropper to after scene detection.
2018-05-28 marpan vp9-svc: Fix to allowed value of max_consec_drop.
2018-05-23 jianj VP8: Fix use-after-free in postproc.
Created with:
roll-dep src/third_party/libvpx/source/libvpx
[email protected]
BUG=842265
Change-Id: I3accf4ed9e8ce3ad6277c5ba9f34f380d4bb4f76
Reviewed-on: https://chromium-review.googlesource.com/1076899
Reviewed-by: Johann Koenig <[email protected]>
Commit-Queue: Jerome Jiang <[email protected]>
Cr-Commit-Position: refs/heads/master@{#562607} | 17eb61099e1b47fdcce709cffedec412a51f4a1f | chrome | bigvul | 1 | null | null | null |
Add paste menu item to the gear menu.
Test: browser_tests --gtest_filter=GearMenu*
Bug: 796815
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Iab214e1e4e991518e8c8c02a37ebd7a5c93e93f3
Reviewed-on: https://chromium-review.googlesource.com/841962
Commit-Queue: Tatsuhisa Yamaguchi <[email protected]>
Reviewed-by: Naoki Fukino <[email protected]>
Cr-Commit-Position: refs/heads/master@{#531484} | 77e995d28edc6fb303ceb1d596fdf17b046c3ef6 | chrome | bigvul | 1 | null | null | null |
Roll src/third_party/webrtc/ ef75ebef5..f8d8d6d00 (39 commits)
https://webrtc.googlesource.com/src.git/+log/ef75ebef5520..f8d8d6d00c16
$ git log ef75ebef5..f8d8d6d00 --date=short --no-merges --format='%ad %ae %s'
Created with:
roll-dep src/third_party/webrtc
BUG=chromium:840536,chromium:755660,chromium:755660,chromium:755660,chromium:None,chromium:None,chromium:None,chromium:None,chromium:836790,chromium:None,chromium:None,chromium:None,chromium:None,chromium:None
The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
[email protected]
Change-Id: Iec936924677ed8093fba2631fdef8a0041ad403c
Reviewed-on: https://chromium-review.googlesource.com/1064318
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#559607} | a37b9be2202fae823677bd09849dd7a3be506b7d | chrome | bigvul | 1 | null | null | null |
[oilpan] Fix GCInfoTable for multiple threads
Previously, grow and access from different threads could lead to a race
on the table backing; see bug.
- Rework the table to work on an existing reservation.
- Commit upon growing, avoiding any copies.
Drive-by: Fix over-allocation of table.
Bug: chromium:841280
Change-Id: I329cb6f40091e14e8c05334ba1104a9440c31d43
Reviewed-on: https://chromium-review.googlesource.com/1061525
Commit-Queue: Michael Lippautz <[email protected]>
Reviewed-by: Kentaro Hara <[email protected]>
Cr-Commit-Position: refs/heads/master@{#560434} | 20b65d00ca3d8696430e22efad7485366f8c3a21 | chrome | bigvul | 1 | null | null | null |
Fix timing allow check algorithm for service workers
This CL uses the OriginalURLViaServiceWorker() in the timing allow check
algorithm if the response WasFetchedViaServiceWorker(). This way, if a
service worker changes a same origin request to become cross origin,
then the timing allow check algorithm will still fail.
resource-timing-worker.js is changed so it avoids an empty Response,
which is an odd case in terms of same origin checks.
Bug: 837275
Change-Id: I7e497a6fcc2ee14244121b915ca5f5cceded417a
Reviewed-on: https://chromium-review.googlesource.com/1038229
Commit-Queue: Nicolás Peña Moreno <[email protected]>
Reviewed-by: Yoav Weiss <[email protected]>
Reviewed-by: Timothy Dresser <[email protected]>
Cr-Commit-Position: refs/heads/master@{#555476} | 01b42e2bc2aac531b17596729ae4e5c223ae7124 | chrome | bigvul | 1 | null | null | null |
[iOS] Suppress dialogs with an invalid request URL
JavaScript dialogs depend on the frame's source request to populate
JavaScript alerts with host information so that the user is aware of
which page is showing the dialog. If this information is unavailable,
it is unsafe to show the dialog to the user, as it could be used to
trick users into supplying data to a malicious page.
Bug: 839822
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I351b93294179224d5a4ba1ee01d53104c124de8e
Reviewed-on: https://chromium-review.googlesource.com/1058170
Commit-Queue: Kurt Horimoto <[email protected]>
Reviewed-by: Eugene But <[email protected]>
Cr-Commit-Position: refs/heads/master@{#558581} | c12ce092c44a325d78baaa9679ecfe7370fd1fe3 | chrome | bigvul | 1 | null | null | null |
Redirect should not circumvent same-origin restrictions
Check whether we have access to the audio data when the format is set.
At this point we have enough information to determine this. The old approach
based on when the src was changed was incorrect because at the point, we
only know the new src; none of the response headers have been read yet.
This new approach also removes the incorrect message reported in 619114.
Bug: 826552, 619114
Change-Id: I95119b3a1e399c05d0fbd2da71f87967978efff6
Reviewed-on: https://chromium-review.googlesource.com/1069540
Commit-Queue: Raymond Toy <[email protected]>
Reviewed-by: Yutaka Hirano <[email protected]>
Reviewed-by: Hongchan Choi <[email protected]>
Cr-Commit-Position: refs/heads/master@{#564313} | 761c75d2d607638ff53c764b4925bcca9be601d8 | chrome | bigvul | 1 | null | null | null |
fix incorrect TexImage3D params w/ UNPACK_IMAGE_HEIGHT
Bug: 804123
Test: http://github.com/KhronosGroup/WebGL/pull/2646
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ifbce9b93f0b35817881e1e34930cbac22a1e8b98
Reviewed-on: https://chromium-review.googlesource.com/1053573
Reviewed-by: Kenneth Russell <[email protected]>
Commit-Queue: Kai Ninomiya <[email protected]>
Cr-Commit-Position: refs/heads/master@{#558962} | b43de74aa37a65c608308a122098204ab9c2702f | chrome | bigvul | 1 | null | null | null |
Add confusability mapping entries for Myanmar and Georgian
U+10D5 (ვ), U+1012 (ဒ) => 3
Bug: 847242, 849398
Test: components_unittests --gtest_filter=*IDN*
Change-Id: I9abb8560cf1c9e8e5e8d89980780b89461f7be52
Reviewed-on: https://chromium-review.googlesource.com/1091430
Reviewed-by: Peter Kasting <[email protected]>
Commit-Queue: Mustafa Emre Acer <[email protected]>
Cr-Commit-Position: refs/heads/master@{#565709} | d616695bd68610e75b90d734d72d42534bf01b82 | chrome | bigvul | 1 | null | null | null |
Disallow access to opaque CSS responses.
Bug: 848786
Change-Id: Ie53fbf644afdd76d7c65649a05c939c63d89b4ec
Reviewed-on: https://chromium-review.googlesource.com/1088335
Reviewed-by: Kouhei Ueno <[email protected]>
Commit-Queue: Matt Falkenhagen <[email protected]>
Cr-Commit-Position: refs/heads/master@{#565537} | 0c45ffd2a1b2b6b91aaaac989ad10a76765083c6 | chrome | bigvul | 1 | null | null | null |
Preserve renderer-initiated bit when reloading in a new process.
BUG=847718
TEST=See bug for repro steps.
Change-Id: I6c3461793fbb23f1a4d731dc27b4e77312f29227
Reviewed-on: https://chromium-review.googlesource.com/1080235
Commit-Queue: Charlie Reis <[email protected]>
Reviewed-by: Nasko Oskov <[email protected]>
Cr-Commit-Position: refs/heads/master@{#563312} | 4391ff2884fe15b8d609bd6d3af61aacf8ad52a1 | chrome | bigvul | 1 | null | null | null |
Add a few more confusability mapping entries
U+0153(œ) => ce
U+00E6(æ), U+04D5 (ӕ) => ae
U+0499(ҙ) => 3
U+0525(ԥ) => n
Bug: 835554, 826019, 836885
Test: components_unittests --gtest_filter=*IDN*
Change-Id: Ic89211f70359d3d67cc25c1805b426b72cdb16ae
Reviewed-on: https://chromium-review.googlesource.com/1055894
Commit-Queue: Jungshik Shin <[email protected]>
Reviewed-by: Peter Kasting <[email protected]>
Cr-Commit-Position: refs/heads/master@{#558928} | f8bc31acf099873ebc623e92908477f2e99c17f6 | chrome | bigvul | 1 | null | null | null |
Add Lao/Thai spoofable entries
U+0E1E (พ) => w
U+0E9E (ພ) => w
U+0E9F (ຟ) => w
U+0EA3 (ຣ) => s
U+0EAE (ຮ) => s
U+0E1A (บ) => u
U+0E9A (ບ) => u
Note that U+0E1F(ฟ) and U+0E23 (ร) were added a while ago.
BUG=833143
TEST=components_unittests --gtest_filter=*IDN*
Change-Id: I882e7d272cdca1d80aa23be94b4d7906ff8653c1
Reviewed-on: https://chromium-review.googlesource.com/1058710
Reviewed-by: Peter Kasting <[email protected]>
Commit-Queue: Jungshik Shin <[email protected]>
Cr-Commit-Position: refs/heads/master@{#562565} | 8ac035c31d42cedcc2a772d7765622dc9f406240 | chrome | bigvul | 1 | null | null | null |
Disable metalayer tool when assistant is not available
BUG=b:68664196
TEST=unit tests and manually check on device
Change-Id: If4c997a048ffc7ec3afa3e9ab2199f8c2b140c7a
Reviewed-on: https://chromium-review.googlesource.com/828265
Reviewed-by: Vladislav Kaznacheev <[email protected]>
Reviewed-by: Jenny Zhang <[email protected]>
Commit-Queue: Xiaohui Chen <[email protected]>
Cr-Commit-Position: refs/heads/master@{#524881} | c9450503817e3575a8acb049371b592863e6d555 | chrome | bigvul | 1 | null | null | null |
[Extensions UI] Initially disabled OK button for extension install prompts and enable them after a 500 ms time period.
BUG=394518
Review-Url: https://codereview.chromium.org/2716353003
Cr-Commit-Position: refs/heads/master@{#461933} | 303d78445257d1eec726c4ebadb3517cb16c8c09 | chrome | bigvul | 1 | null | null | null |
Roll src/third_party/pdfium 5ff09fb5ee90..6aa2190f70a8 (1 commits)
https://pdfium.googlesource.com/pdfium.git/+log/5ff09fb5ee90..6aa2190f70a8
git log 5ff09fb5ee90..6aa2190f70a8 --date=short --no-merges --format='%ad %ae %s'
2018-07-12 [email protected] Use JSGetObject() in even more places.
Created with:
gclient setdep -r src/third_party/pdfium@6aa2190f70a8
The AutoRoll server is located here: https://pdfium-roll.skia.org
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
BUG=chromium:862059
[email protected]
Change-Id: I1f8681742658f04204fb7df938c0667e814d84c6
Reviewed-on: https://chromium-review.googlesource.com/1134951
Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#574556} | df1df391ec8f9534d21219ea753c260c4357588b | chrome | bigvul | 1 | null | null | null |
chrome.bluetoothSocket: Fix regression in send()
In https://crrev.com/c/997098, params_ was changed to a local variable,
but it needs to last longer than that since net::WrappedIOBuffer may use
the data after the local variable goes out of scope.
This CL changed it back to be an instance variable.
Bug: 851799
Change-Id: I392f8acaef4c6473d6ea4fbee7209445aa09112e
Reviewed-on: https://chromium-review.googlesource.com/1103676
Reviewed-by: Toni Barzic <[email protected]>
Commit-Queue: Sonny Sasaka <[email protected]>
Cr-Commit-Position: refs/heads/master@{#568137} | c5c6320f80159dc41dffc3cfbf0298925c7dcf1b | chrome | bigvul | 1 | null | null | null |
Roll SwiftShader c8403ec..cbb80f5
https://swiftshader.googlesource.com/SwiftShader.git/+log/c8403ec..cbb80f5
BUG=chromium:835299,chromium:825545
[email protected]
TEST=bots
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_chromium_cfi_rel_ng;luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: Ic37afa51eaa67f7a61902d2a3e2d8227065ae909
Reviewed-on: https://chromium-review.googlesource.com/1066397
Reviewed-by: Alexis Hétu <[email protected]>
Commit-Queue: Nicolas Capens <[email protected]>
Cr-Commit-Position: refs/heads/master@{#560042} | 997bfdbc7f496a31e1675680d6b8ca098cd3884c | chrome | bigvul | 1 | null | null | null |
[iOS] Add common files used for JS overlay UI.
Bug: 941745
Change-Id: I5740baabe69011dd57bb9a9e68b7f84fa6a0a8f6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637745
Commit-Queue: Kurt Horimoto <[email protected]>
Reviewed-by: Mike Dougherty <[email protected]>
Cr-Commit-Position: refs/heads/master@{#666824} | def2963f36b722a0c03e6bafdfaa4062b7ec4d16 | chrome | bigvul | 1 | null | null | null |
defeat cors attacks on audio/video tags
Neutralize error messages and fire no progress events
until media metadata has been loaded for media loaded
from cross-origin locations.
Bug: 828265, 826187
Change-Id: Iaf15ef38676403687d6a913cbdc84f2d70a6f5c6
Reviewed-on: https://chromium-review.googlesource.com/1015794
Reviewed-by: Mounir Lamouri <[email protected]>
Reviewed-by: Dale Curtis <[email protected]>
Commit-Queue: Fredrik Hubinette <[email protected]>
Cr-Commit-Position: refs/heads/master@{#557312} | 4504a474c069d07104237d0c03bfce7b29a42de6 | chrome | bigvul | 1 | null | null | null |
Allow to specify elide behavior for confrim infobar message
Used in "<extension name> is debugging this browser" infobar.
Bug: 823194
Change-Id: Iff6627097c020cccca8f7cc3e21a803a41fd8f2c
Reviewed-on: https://chromium-review.googlesource.com/1048064
Commit-Queue: Dmitry Gozman <[email protected]>
Reviewed-by: Devlin <[email protected]>
Reviewed-by: Peter Kasting <[email protected]>
Cr-Commit-Position: refs/heads/master@{#557245} | fbeba958bb83c05ec8cc54e285a4a9ca10d1b311 | chrome | bigvul | 1 | null | null | null |
Extensions: Add test coverage for an extensions ability to embed file iframes.
This CL adds test coverage regarding an extension frame's ability to embed a
file frame. This ensures than an extension can only embed a file frame if it has
explicit file access and host permissions to the file scheme.
BUG=816685
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I8d167d9a8629ffece29d44bee4bd6db2ef988b02
Reviewed-on: https://chromium-review.googlesource.com/1003762
Commit-Queue: Karan Bhatia <[email protected]>
Reviewed-by: Devlin <[email protected]>
Cr-Commit-Position: refs/heads/master@{#551267} | f020de9f4788d81c05f0a4947dabfdb777604cc6 | chrome | bigvul | 1 | null | null | null |
Network servicification: Plumb ResourceContext through WebRequestProxyingURLLoaderFactory.
This CL plumbs the ResourceContext to the WebRequestInfo structure through
WebRequestProxyingURLLoaderFactory. This is necessary to fix
NTPInterceptionWebRequestAPITest.NTPRendererRequestsHidden for the network
servicification path.
BUG=797461, 721414
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I2957c1ece0f8f7b44f15156aeb5e554b3a91ff01
Reviewed-on: https://chromium-review.googlesource.com/1029549
Reviewed-by: Ken Rockot <[email protected]>
Commit-Queue: Karan Bhatia <[email protected]>
Cr-Commit-Position: refs/heads/master@{#554556} | 53d030a18b1965c20878d6300738ed29c3bfdd08 | chrome | bigvul | 1 | null | null | null |
[Fetch API] Fix redirect leak on "no-cors" requests
The spec issue is now fixed, and this CL follows the spec change[1].
1: https://github.com/whatwg/fetch/commit/14858d3e9402285a7ff3b5e47a22896ff3adc95d
Bug: 791324
Change-Id: Ic3e3955f43578b38fc44a5a6b2a1b43d56a2becb
Reviewed-on: https://chromium-review.googlesource.com/1023613
Reviewed-by: Tsuyoshi Horo <[email protected]>
Commit-Queue: Yutaka Hirano <[email protected]>
Cr-Commit-Position: refs/heads/master@{#552964} | a62f913109fc1566230f5963bbf69ee65274ebc8 | chrome | bigvul | 1 | null | null | null |
Refactor ScrollableShelf on |space_for_icons_|
|space_for_icons_| indicates the available space in scrollable shelf
to accommodate shelf icons. Now it is an integer type. Replace it with
gfx::Rect.
Bug: 997807
Change-Id: I4f9ba3206bd69dfdaf50894de46239e676db6454
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1801326
Commit-Queue: Andrew Xu <[email protected]>
Reviewed-by: Manu Cornet <[email protected]>
Reviewed-by: Xiyuan Xia <[email protected]>
Cr-Commit-Position: refs/heads/master@{#696446} | dfd28b1909358445e838fb0fdf3995c77a420aa8 | chrome | bigvul | 1 | null | null | null |
Fix a typo in a web platform test for fetch/integrity
The test has succeeded unexpectedly, so this CL also adds an
expectation file.
Bug: 812667
Change-Id: I649a7663c54f83ccb951c5a4bf075b588908b088
Reviewed-on: https://chromium-review.googlesource.com/948184
Commit-Queue: Yutaka Hirano <[email protected]>
Reviewed-by: Matt Falkenhagen <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540789} | 5a4aa3bcaf8a52637ef445b2d2d6112364984122 | chrome | bigvul | 1 | null | null | null |
Don't downcast DownloadManagerDelegate to ChromeDownloadManagerDelegate.
DownloadManager has public SetDelegate method and tests and or other subsystems
can install their own implementations of the delegate.
Bug: 805905
Change-Id: Iecf1e0aceada0e1048bed1e2d2ceb29ca64295b8
TBR: tests updated to follow the API change.
Reviewed-on: https://chromium-review.googlesource.com/894702
Reviewed-by: David Vallet <[email protected]>
Reviewed-by: Min Qin <[email protected]>
Cr-Commit-Position: refs/heads/master@{#533515} | cbb2c0940d4e3914ccd74f6466ff4cb9e50e0e86 | chrome | bigvul | 1 | null | null | null |
Always mark content downloaded by devtools delegate as potentially dangerous
Bug: 805445
Change-Id: I7051f519205e178db57e23320ab979f8fa9ce38b
Reviewed-on: https://chromium-review.googlesource.com/894782
Commit-Queue: David Vallet <[email protected]>
Reviewed-by: Pavel Feldman <[email protected]>
Cr-Commit-Position: refs/heads/master@{#533215} | 81ad563077484d112e544347da87c09dd2ba0af8 | chrome | bigvul | 1 | null | null | null |
Do not crash while reentrantly appending to style element.
When a node is inserted into a container, it is notified via
::InsertedInto. However, a node may request a second notification via
DidNotifySubtreeInsertionsToDocument, which occurs after all the children
have been notified as well. *StyleElement is currently using this
second notification.
This causes a problem, because *ScriptElement is using the same mechanism,
which in turn means that scripts can execute before the state of
*StyleElements are properly updated.
This patch avoids ::DidNotifySubtreeInsertionsToDocument, and instead
processes the stylesheet in ::InsertedInto. The original reason for using
::DidNotifySubtreeInsertionsToDocument in the first place appears to be
invalid now, as the test case is still passing.
[email protected], [email protected]
Bug: 853709, 847570
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ic0b5fa611044c78c5745cf26870a747f88920a14
Reviewed-on: https://chromium-review.googlesource.com/1104347
Commit-Queue: Anders Ruud <[email protected]>
Reviewed-by: Rune Lillesveen <[email protected]>
Cr-Commit-Position: refs/heads/master@{#568368} | 2bf635c28effa427a270f4fc45df84ed344f411c | chrome | bigvul | 1 | null | null | null |
Inform destination handler if execution context is gone.
When the execution context is being destroyed, inform the destination
handler of that so that we don't try to access the execution context
that is in the process of going away.
This CL only handles the specific case in bug 848306, and is a simple
fix for that issue. This really needs to be fixed in a better way, but
that requires significant design work.
Bug: 848306
Test: Manually run repro case and see that it doesn't happen
Change-Id: I89a4d397af15a823d9c25ef814195706f7b30b21
Reviewed-on: https://chromium-review.googlesource.com/1138722
Commit-Queue: Raymond Toy <[email protected]>
Reviewed-by: Hongchan Choi <[email protected]>
Reviewed-by: Kentaro Hara <[email protected]>
Cr-Commit-Position: refs/heads/master@{#575459} | e3af3e7e4ff664d70d04b64e0a1890c259cf90f5 | chrome | bigvul | 1 | null | null | null |
Audio thread should not access destination node
The AudioDestinationNode is an object managed by Oilpan so the audio
thread should not access it. However, the audio thread needs
information (currentTime, etc) from the destination node. So instead
of accessing the audio destination handler (a scoped_refptr) via the
destination node, add a new member to the base audio context that
holds onto the destination handler.
The destination handler is not an oilpan object and lives at least as
long as the base audio context.
Bug: 860626, 860522, 863951
Test: Test case from 860522 doesn't crash on asan build
Change-Id: I3add844d4eb8fdc7e05b89292938b843a0abbb99
Reviewed-on: https://chromium-review.googlesource.com/1138974
Commit-Queue: Raymond Toy <[email protected]>
Reviewed-by: Hongchan Choi <[email protected]>
Cr-Commit-Position: refs/heads/master@{#575509} | ca1156974cbe707fd023a00ae62104528833a44e | chrome | bigvul | 1 | null | null | null |
[mojo-core] Validate data pipe endpoint metadata
Ensures that we don't blindly trust specified buffer size and offset
metadata when deserializing data pipe consumer and producer handles.
Bug: 877182
Change-Id: I30f3eceafb5cee06284c2714d08357ef911d6fd9
Reviewed-on: https://chromium-review.googlesource.com/1192922
Reviewed-by: Reilly Grant <[email protected]>
Commit-Queue: Ken Rockot <[email protected]>
Cr-Commit-Position: refs/heads/master@{#586704} | 66e24a8793615bd9d5c238b1745b093090e1f72d | chrome | bigvul | 1 | null | null | null |
Roll SwiftShader 419e8a7..57776df
https://swiftshader.googlesource.com/SwiftShader.git/+log/419e8a7..57776df
BUG=chromium:847094 chromium:848238
[email protected]
TEST=bots
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_chromium_cfi_rel_ng;luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: Ib1ad80065f888a0aab0f9a4b13143967b0ca5a57
Reviewed-on: https://chromium-review.googlesource.com/1085483
Commit-Queue: Alexis Hétu <[email protected]>
Reviewed-by: Alexis Hétu <[email protected]>
Cr-Commit-Position: refs/heads/master@{#564288} | c1d1d91f0d74adaef3aff961a313a8b9c6a5aedf | chrome | bigvul | 1 | null | null | null |
Roll src/third_party/skia faef514..9f752aa (20 commits)
https://skia.googlesource.com/skia.git/+log/faef514..9f752aa
git log faef514..9f752aa --date=short --no-merges --format='%ad %ae %s'
2018-06-07 [email protected] tweak SkArenaAlloc comments, parameter names
2018-06-07 [email protected] switch fiddle examples to call MakeFromTexture with RGBA
2018-06-07 [email protected] SkFontMgr_DirectWrite::onMakeFromStreamArgs works on win 7
2018-06-07 [email protected] remove unused stat tracking from SkArenaAlloc
2018-06-07 [email protected] Defer Sample setup to onOnceBeforeDraw.
2018-06-07 [email protected] Revert "Require mips to be allocated at texture creation time and disable late allocations."
2018-06-07 skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll skia/third_party/skcms 0fdd840..1be9889 (1 commits)
2018-06-07 [email protected] Revert "Change persp dftext to only antialiased"
2018-06-07 [email protected] Remove GrGLSLFragProcs typedef. Use unique_ptr to for GrGLSLFragmentProcessor ownership.
2018-06-07 [email protected] Require mips to be allocated at texture creation time and disable late allocations.
2018-06-07 [email protected] Add SkTypeface::makeClone.
2018-06-07 [email protected] remove "srgb" config from DM,nanobench
2018-06-07 [email protected] fonts: Hook up FallbackTextHelper to font remoting.
2018-06-07 [email protected] Add checks to make sure we don't overflow 32 bit int in GPU path renderers.
2018-06-07 [email protected] Change persp dftext to only antialiased
2018-06-07 [email protected] Add guard around GrVkBackendContext::Create function.
2018-06-07 [email protected] Remove unused GrObjectMemoryPool
2018-06-07 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 2bd1fab..ea17575 (1 commits)
2018-06-07 [email protected] require std::is_trivially_destructible
2018-06-07 [email protected] Implement SkFontMgr_DirectWrite::onMakeFromStreamArgs function.
Created with:
gclient setdep -r src/third_party/skia@9f752aa
The AutoRoll server is located here: https://autoroll.skia.org
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
BUG=chromium:848716
[email protected]
Change-Id: I060ba6ef2896dfce86b931a3802da1cadac2758e
Reviewed-on: https://chromium-review.googlesource.com/1091812
Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#565506} | 67f3f0ce955fd170a3d471dc1458e8ca8d5984c5 | chrome | bigvul | 1 | null | null | null |
Roll src/third_party/webrtc d39ce8d45bc9..bf7463b88f7b (6 commits)
https://webrtc.googlesource.com/src.git/+log/d39ce8d45bc9..bf7463b88f7b
git log d39ce8d45bc9..bf7463b88f7b --date=short --no-merges --format='%ad %ae %s'
2018-07-06 [email protected] Android: Update tests to use new SurfaceTextureHelper interface
2018-07-06 [email protected] Stop using VideoCodec.targetBitrate for vp8 screenshare config
2018-07-06 [email protected] Allow AGC2 level estimation in AgcManagerDirect.
2018-07-06 [email protected] Making PacketDuration always consistent with Decode in FakeDecodeFromFile.
2018-07-06 [email protected] Break out Agc code from audio_processing.
2018-07-06 [email protected] Unwrap TL0 pic index to avoid having to work with a wrapped number.
Created with:
gclient setdep -r src/third_party/webrtc@bf7463b88f7b
The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
BUG=chromium:None,chromium:855211
[email protected]
Change-Id: I5b6356d26e6778d8544acf20696845d290ae7138
Reviewed-on: https://chromium-review.googlesource.com/1128100
Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#573041} | c0716372f1993e29afb1cbf3b700057f834678bc | chrome | bigvul | 1 | null | null | null |
Fix HasSingleSecurityOrigin for HLS
HLS manifests can request segments from a different origin than the
original manifest's origin. We do not inspect HLS manifests within
Chromium, and instead delegate to Android's MediaPlayer. This means we
need to be conservative, and always assume segments might come from a
different origin. HasSingleSecurityOrigin should always return false
when decoding HLS.
Bug: 864283
Change-Id: Ie16849ac6f29ae7eaa9caf342ad0509a226228ef
Reviewed-on: https://chromium-review.googlesource.com/1142691
Reviewed-by: Dale Curtis <[email protected]>
Reviewed-by: Dominick Ng <[email protected]>
Commit-Queue: Thomas Guilbert <[email protected]>
Cr-Commit-Position: refs/heads/master@{#576378} | 153f8457c7867d5c9b627c11b52f5de0671d2fff | chrome | bigvul | 1 | null | null | null |
Use unique processes for data URLs on restore.
Data URLs are usually put into the process that created them, but this
info is not tracked after a tab restore. Ensure that they do not end up
in the parent frame's process (or each other's process), in case they
are malicious.
BUG=863069
Change-Id: Ib391f90c7bdf28a0a9c057c5cc7918c10aed968b
Reviewed-on: https://chromium-review.googlesource.com/1150767
Reviewed-by: Alex Moshchuk <[email protected]>
Reviewed-by: Lei Zhang <[email protected]>
Commit-Queue: Charlie Reis <[email protected]>
Cr-Commit-Position: refs/heads/master@{#581023} | 0bb3f5c715eb66bb5c1fb05fd81d902ca57f33ca | chrome | bigvul | 1 | null | null | null |
Avoid sharing process for blob URLs with null origin.
Previously, when a frame with a unique origin, such as from a data
URL, created a blob URL, the blob URL looked like blob:null/guid and
resulted in a site URL of "blob:" when navigated to. This incorrectly
allowed all such blob URLs to share a process, even if they were
created by different sites.
This CL changes the site URL assigned in such cases to be the full
blob URL, which includes the GUID. This avoids process sharing for
all blob URLs with unique origins.
This fix is conservative in the sense that it would also isolate
different blob URLs created by the same unique origin from each other.
This case isn't expected to be common, so it's unlikely to affect
process count. There's ongoing work to maintain a GUID for unique
origins, so longer-term, we could try using that to track down the
creator and potentially use that GUID in the site URL instead of the
blob URL's GUID, to avoid unnecessary process isolation in scenarios
like this.
Note that as part of this, we discovered a bug where data URLs aren't
able to script blob URLs that they create: https://crbug.com/865254.
This scripting bug should be fixed independently of this CL, and as
far as we can tell, this CL doesn't regress scripting cases like this
further.
Bug: 863623
Change-Id: Ib50407adbba3d5ee0cf6d72d3df7f8d8f24684ee
Reviewed-on: https://chromium-review.googlesource.com/1142389
Commit-Queue: Alex Moshchuk <[email protected]>
Reviewed-by: Charlie Reis <[email protected]>
Cr-Commit-Position: refs/heads/master@{#576318} | b1f87486936ca0d6d9abf4d3b9b423a9c976fd59 | chrome | bigvul | 1 | null | null | null |
Roll src/third_party/pdfium f22b4e2f6682..c15c0b3a1e9a (3 commits)
https://pdfium.googlesource.com/pdfium.git/+log/f22b4e2f6682..c15c0b3a1e9a
git log f22b4e2f6682..c15c0b3a1e9a --date=short --no-merges --format='%ad %ae %s'
2018-07-18 [email protected] Roll third_party/skia/ af7700265..588f87967 (1391 commits; 41 trivial rolls)
2018-07-18 [email protected] Handle wrong tag element count in littlecms.
2018-07-18 [email protected] Add pdfium::span::as_bytes() and as_writable_bytes().
Created with:
gclient setdep -r src/third_party/pdfium@c15c0b3a1e9a
The AutoRoll server is located here: https://pdfium-roll.skia.org
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
BUG=chromium:864932
[email protected]
Change-Id: If7555664cbb89a71e68d034eacbb6b6be0e87415
Reviewed-on: https://chromium-review.googlesource.com/1142172
Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#576322} | 30ce134f3d94e8addd51f007a468af9ac626af9f | chrome | bigvul | 1 | null | null | null |
Remove RequireCSSExtensionForFile runtime enabled flag.
The feature has long since been stable (since M64) and doesn't seem
to be a need for this flag.
BUG=788936
Change-Id: I666390b869289c328acb4a2daa5bf4154e1702c0
Reviewed-on: https://chromium-review.googlesource.com/c/1324143
Reviewed-by: Mike West <[email protected]>
Reviewed-by: Camille Lamy <[email protected]>
Commit-Queue: Dave Tapuska <[email protected]>
Cr-Commit-Position: refs/heads/master@{#607329} | d913f72b4875cf0814fc3f03ad7c00642097c4a4 | chrome | bigvul | 1 | null | null | null |
Roll src/third_party/pdfium 2563fc3895f2..0562ff4f6e2e (2 commits)
https://pdfium.googlesource.com/pdfium.git/+log/2563fc3895f2..0562ff4f6e2e
git log 2563fc3895f2..0562ff4f6e2e --date=short --no-merges --format='%ad %ae %s'
2018-08-01 [email protected] Bounds check lineSrc in JBig2_Image.cpp.
2018-08-01 [email protected] Add in support for using .evt in make_expected.sh
Created with:
gclient setdep -r src/third_party/pdfium@0562ff4f6e2e
The AutoRoll server is located here: https://pdfium-roll.skia.org
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
BUG=chromium:867501
[email protected]
Change-Id: I9e03617e8c2be4be678a25c82fac6bff19e722ae
Reviewed-on: https://chromium-review.googlesource.com/1159241
Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#579968} | 0cb45daf738064de834f2c048e37dafffc700ae3 | chrome | bigvul | 1 | null | null | null |
Don't reset TabDownloadState on history back/forward
Currently performing forward/backward on a tab will reset the TabDownloadState.
Which allows javascript code to do trigger multiple downloads.
This CL disables that behavior by not resetting the TabDownloadState on
forward/back.
It is still possible to reset the TabDownloadState through user gesture
or using browser initiated download.
BUG=848535
Change-Id: I7f9bf6e8fb759b4dcddf5ac0c214e8c6c9f48863
Reviewed-on: https://chromium-review.googlesource.com/1108959
Commit-Queue: Min Qin <[email protected]>
Reviewed-by: Xing Liu <[email protected]>
Cr-Commit-Position: refs/heads/master@{#574437} | 01a6365651e0b1e9896b251411a18a4ab5a4306d | chrome | bigvul | 1 | null | null | null |
Only allow downloading in response to real keyboard modifiers
BUG=848531
Change-Id: I97554c8d312243b55647f1376945aee32dbd95bf
Reviewed-on: https://chromium-review.googlesource.com/1082216
Reviewed-by: Mike West <[email protected]>
Commit-Queue: Jochen Eisinger <[email protected]>
Cr-Commit-Position: refs/heads/master@{#564051} | 4379a7fcff8190aa7ba72307b398161c32102c52 | chrome | bigvul | 1 | null | null | null |
Prevent sandboxed documents from reusing the default window
Bug: 377995
Change-Id: Iff66c6d214dfd0cb7ea9c80f83afeedfff703541
Reviewed-on: https://chromium-review.googlesource.com/983558
Commit-Queue: Andy Paicu <[email protected]>
Reviewed-by: Daniel Cheng <[email protected]>
Cr-Commit-Position: refs/heads/master@{#567663} | 90f878780cce9c4b0475fcea14d91b8f510cce11 | chrome | bigvul | 1 | null | null | null |
[AF] Don't simplify/dedupe suggestions for (partially) filled sections.
Since Autofill does not fill field by field anymore, this simplifying
and deduping of suggestions is not useful anymore.
Bug: 858820
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I36f7cfe425a0bdbf5ba7503a3d96773b405cc19b
Reviewed-on: https://chromium-review.googlesource.com/1128255
Reviewed-by: Roger McFarlane <[email protected]>
Commit-Queue: Sebastien Seguin-Gagnon <[email protected]>
Cr-Commit-Position: refs/heads/master@{#573315} | b025e82307a8490501bb030266cd955c391abcb7 | chrome | bigvul | 1 | null | null | null |
Ensure device choosers are closed on navigation
The requestDevice() IPCs can race with navigation. This change ensures
that choosers are closed on navigation and adds browser tests to
exercise this for Web Bluetooth and WebUSB.
Bug: 723503
Change-Id: I66760161220e17bd2be9309cca228d161fe76e9c
Reviewed-on: https://chromium-review.googlesource.com/1099961
Commit-Queue: Reilly Grant <[email protected]>
Reviewed-by: Michael Wasserman <[email protected]>
Reviewed-by: Jeffrey Yasskin <[email protected]>
Cr-Commit-Position: refs/heads/master@{#569900} | 2c6ce192cb3fb7bfbc3f3f862926dcb65c3891b4 | chrome | bigvul | 1 | null | null | null |
Mac: turn popups into new tabs while in fullscreen.
It's platform convention to show popups as new tabs while in
non-HTML5 fullscreen. (Popups cause tabs to lose HTML5 fullscreen.)
This was implemented for Cocoa in a BrowserWindow override, but
it makes sense to just stick it into Browser and remove a ton
of override code put in just to support this.
BUG=858929, 868416
TEST=as in bugs
Change-Id: I43471f242813ec1159d9c690bab73dab3e610b7d
Reviewed-on: https://chromium-review.googlesource.com/1153455
Reviewed-by: Sidney San Martín <[email protected]>
Commit-Queue: Avi Drissman <[email protected]>
Cr-Commit-Position: refs/heads/master@{#578755} | c552cd7b8a0862f6b3c8c6a07f98bda3721101eb | chrome | bigvul | 1 | null | null | null |
Take default system font size from PlatformFont
The default font returned by Skia should take the initial size from the
default value kDefaultBaseFontSize specified in PlatformFont.
[email protected], [email protected]
[email protected]
Bug: 944227
Change-Id: I6b230b80c349abbe5968edb3cebdd6e89db4c4a6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642738
Reviewed-by: Robert Liao <[email protected]>
Reviewed-by: Alexei Svitkine <[email protected]>
Commit-Queue: Etienne Bergeron <[email protected]>
Cr-Commit-Position: refs/heads/master@{#666299} | 7c3bb2970fd0890df611b1d8b345b60b1978c2d7 | chrome | bigvul | 1 | null | null | null |
Roll src/third_party/webrtc 5795489e83ad..58c79f66dd3a (6 commits)
https://webrtc.googlesource.com/src.git/+log/5795489e83ad..58c79f66dd3a
git log 5795489e83ad..58c79f66dd3a --date=short --no-merges --format='%ad %ae %s'
2018-07-12 [email protected] Add saza to fuzzer owners
2018-07-12 [email protected] Temporarly disable KSVC perf tests on Mac because of crashes
2018-07-12 [email protected] Removing -Wno-reorder from audio_device.
2018-07-12 [email protected] Fix buffer overflow in ulpfec recovery
2018-07-12 [email protected] Fix handling invalid empty red packets
2018-07-12 [email protected] Roll chromium_revision 720dadbc21..efbdada3f7 (574387:574489)
Created with:
gclient setdep -r src/third_party/webrtc@58c79f66dd3a
The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
BUG=chromium:None,chromium:856823,chromium:856823,chromium:None
[email protected]
Change-Id: I2e736098249694bb9480b4f170b065e60ddd44a2
Reviewed-on: https://chromium-review.googlesource.com/1134949
Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#574543} | 8e1637ff7a416934beedc7a637455779b85f6042 | chrome | bigvul | 1 | null | null | null |
Set Cancel as the default button for the external protocol dialog.
This ensures that users holding down the Enter or Space key cannot
accidentally trigger an external protocol launch.
BUG=865202
Change-Id: I2cec7b3c216b80641200c97dec2517a66b4e0b24
Reviewed-on: https://chromium-review.googlesource.com/1142705
Commit-Queue: Dominick Ng <[email protected]>
Reviewed-by: Trent Apted <[email protected]>
Cr-Commit-Position: refs/heads/master@{#576340} | ca025d47d93664b3dcce6b7cbe9ea58b7d085cd4 | chrome | bigvul | 1 | null | null | null |
Extensions: Prevent content script injection in the New tab Page.
r487664 disallowed content script injection in the New Tab Page. However, the
check in RendererPermissionsPolicyDelegate::IsRestrictedUrl for the same, might
not work due to the following reasons:
- There might be a race between checking if the extension can inject the
script and setting the new tab url in the renderer (SearchBouncer).
- The New Tab page url in the SearchBouncer might be set incorrectly due to
incorrect handling of multiple profiles by InstantService.
Fix this by checking if the current renderer process is an Instant (NTP)
renderer. This should work since the NTP renderer process should not be shared
with other sites.
BUG=844428, 662610
Change-Id: I45f6b27fb2680d3b8df6e1da223452ffee09b0d8
Reviewed-on: https://chromium-review.googlesource.com/1068607
Reviewed-by: Devlin <[email protected]>
Commit-Queue: Karan Bhatia <[email protected]>
Cr-Commit-Position: refs/heads/master@{#563031} | 8247b125c7b6888dc1c3932e19d6d8fe5a74a460 | chrome | bigvul | 1 | null | null | null |
Fix heap-use-after-free by using weak factory instead of Unretained
Bug: 856578
Change-Id: Ifb2a1b7e6c22e1af36e12eedba72427f51d925b9
Reviewed-on: https://chromium-review.googlesource.com/1114617
Reviewed-by: Hector Dearman <[email protected]>
Commit-Queue: Hector Dearman <[email protected]>
Cr-Commit-Position: refs/heads/master@{#571528} | fa76a9f7ef6a028f83f97c181b150ecfd2b13be1 | chrome | bigvul | 1 | null | null | null |
Revert "Make test_env.py compatible w/ Python 3"
This reverts commit 1102f12d8e3317d18baae355789e893aba57a325.
Reason for revert: it is breaking stuff on several Mac bots.
[E2019-09-12T12:28:01.848585-07:00 31162 0 annotate.go:241] goroutine 1:
[E2019-09-12T12:28:01.848653-07:00 31162 0 annotate.go:241] #0 go.chromium.org/luci/vpython/python/find.go:93 - python.Find()
[E2019-09-12T12:28:01.848672-07:00 31162 0 annotate.go:241] annotation #0:
[E2019-09-12T12:28:01.848683-07:00 31162 0 annotate.go:241] reason: no Python found
[E2019-09-12T12:28:01.848692-07:00 31162 0 annotate.go:241] annotation #1:
[E2019-09-12T12:28:01.848701-07:00 31162 0 annotate.go:241] reason: could not find appropriate executable for: "python3.8"
[E2019-09-12T12:28:01.848709-07:00 31162 0 annotate.go:241] annotation #2:
[E2019-09-12T12:28:01.848725-07:00 31162 0 annotate.go:241] reason: could not find target in system
[E2019-09-12T12:28:01.848739-07:00 31162 0 annotate.go:241] internal reason: target(python3.8)/dirs([/b/s/w/ir/.swarming_module /b/s/w/ir/.swarming_module/cpython/bin /b/s/w/ir/.swarming_module/cpython3/bin /b/s/cipd_cache/bin /opt/local/bin /opt/local/sbin /usr/local/sbin /usr/local/git/bin /usr/local/bin /usr/sbin /usr/bin /sbin /bin])
[E2019-09-12T12:28:01.848764-07:00 31162 0 annotate.go:241]
[E2019-09-12T12:28:01.848774-07:00 31162 0 annotate.go:241] #1 go.chromium.org/luci/vpython/venv/config.go:272 - venv.(*Config).resolvePythonInterpreter()
[E2019-09-12T12:28:01.848785-07:00 31162 0 annotate.go:241] reason: could not find Python for: 3.8.0
[E2019-09-12T12:28:01.848799-07:00 31162 0 annotate.go:241]
[E2019-09-12T12:28:01.848808-07:00 31162 0 annotate.go:241] #2 go.chromium.org/luci/vpython/venv/config.go:187 - venv.(*Config).makeEnv()
[E2019-09-12T12:28:01.848822-07:00 31162 0 annotate.go:241] reason: failed to resolve system Python interpreter
Original change's description:
> Make test_env.py compatible w/ Python 3
>
> Makes test_env.py compatible with both Python 2 and 3. Also adds a very
> simple test to ensure that it remains compatible until some other test
> switches to Python 3.
>
> As a side effect of adding the test, also makes
> testing/scripts/common.py compatible with Python 3 since it's
> necessary for running isolated scripts.
>
> Bug: 898348
> Change-Id: Ib58cf4c4f85df60a432764d7f744bc3fee09ae3a
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796525
> Reviewed-by: Dirk Pranke <[email protected]>
> Commit-Queue: Brian Sheedy <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#695825}
[email protected],[email protected]
Change-Id: I80fb04b1a224db48b53865e871f39b6364a785b0
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 898348
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1802095
Reviewed-by: Sorin Jianu <[email protected]>
Commit-Queue: Sorin Jianu <[email protected]>
Cr-Commit-Position: refs/heads/master@{#696156} | e11c98574bf650ed3845440327bfc01988a57bd1 | chrome | bigvul | 1 | null | null | null |
Verify that header values set from Blink don't contain '\n'.
Because that would be silly.
Bug: 845961
Change-Id: I69de2cb093a3629de63c48652c9499f7387b8334
Reviewed-on: https://chromium-review.googlesource.com/1109757
Commit-Queue: Mike West <[email protected]>
Reviewed-by: Daniel Cheng <[email protected]>
Cr-Commit-Position: refs/heads/master@{#570206} | fa68dcfd12e376aa880b3193a77b896e6c54efdf | chrome | bigvul | 1 | null | null | null |
Fix use-after-free in FileReaderLoader.
Anything that calls out to client_ can cause FileReaderLoader to be
destroyed, so make sure to check for that situation.
Bug: 835639
Change-Id: I57533d41b7118c06da17abec28bbf301e1f50646
Reviewed-on: https://chromium-review.googlesource.com/1024450
Commit-Queue: Marijn Kruisselbrink <[email protected]>
Commit-Queue: Daniel Murphy <[email protected]>
Reviewed-by: Daniel Murphy <[email protected]>
Cr-Commit-Position: refs/heads/master@{#552807} | a261ea1c56ef16fc0fc4af1e440feb302d577716 | chrome | bigvul | 1 | null | null | null |
ReadableStreamBytesConsumer should check read results
ReadableStreamBytesConsumer expected that the results from
ReadableStreamReaderDefaultRead should be Promise<Object> because that
is provided from ReadableStream provided by blink, but it's possible to
inject arbitrary values with the promise assimilation.
This CL adds additional checks for such injection.
Bug: 840320
Change-Id: I7b3c6a8bfcf563dd860b133ff0295dd7a5d5fea5
Reviewed-on: https://chromium-review.googlesource.com/1049413
Commit-Queue: Yutaka Hirano <[email protected]>
Reviewed-by: Adam Rice <[email protected]>
Cr-Commit-Position: refs/heads/master@{#556751} | 7712d138374a92c4d2f3b05cdc86d1a7a523702b | chrome | bigvul | 1 | null | null | null |
Remove libusb-Windows support for HID devices
This patch removes the Windows-specific support in libusb that provided
a translation between the WinUSB API and the HID API. Applications
currently depending on this using the chrome.usb API should switch to
using the chrome.hid API.
Bug: 818592
Change-Id: I82ee6ccdcbccc21d2910dc62845c7785e78b64f6
Reviewed-on: https://chromium-review.googlesource.com/951635
Reviewed-by: Ken Rockot <[email protected]>
Commit-Queue: Reilly Grant <[email protected]>
Cr-Commit-Position: refs/heads/master@{#541265} | ac149a8d4371c0e01e0934fdd57b09e86f96b5b9 | chrome | bigvul | 1 | null | null | null |
Roll src/third_party/skia/ ee84fe1e6..ba5b5f517 (3 commits)
https://skia.googlesource.com/skia.git/+log/ee84fe1e6484..ba5b5f517168
$ git log ee84fe1e6..ba5b5f517 --date=short --no-merges --format='%ad %ae %s'
2018-05-18 reed harden line2d effect
2018-05-18 herb Add rules for cmake 3.11 to not error
2018-05-18 reed tweak conservative bounds value to save aberrant cubic
Created with:
roll-dep src/third_party/skia
BUG=chromium:844457
The AutoRoll server is located here: https://autoroll.skia.org
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
[email protected]
Change-Id: I1cf1c8862775f8a3e3b0fdbc8ef840a2f4d703d9
Reviewed-on: https://chromium-review.googlesource.com/1066783
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#560122} | b332617ddd273f27682d3d75442a12fb6f02ab1e | chrome | bigvul | 1 | null | null | null |
[IndexedDB] Fixing early destruction of connection during forceclose
Patch is as small as possible for merging.
Bug: 842990
Change-Id: I9968ffee1bf3279e61e1ec13e4d541f713caf12f
Reviewed-on: https://chromium-review.googlesource.com/1062935
Commit-Queue: Daniel Murphy <[email protected]>
Commit-Queue: Victor Costan <[email protected]>
Reviewed-by: Victor Costan <[email protected]>
Cr-Commit-Position: refs/heads/master@{#559383} | 28044cb7ef4488e7278c2b80f0e3a2c3707d03b6 | chrome | bigvul | 1 | null | null | null |
Crash on unexpected URL change.
Bug: 841105
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I4471a98cdef13e54b790ebcd565d59c67dba8bfd
Reviewed-on: https://chromium-review.googlesource.com/1054196
Reviewed-by: Rohit Rao <[email protected]>
Reviewed-by: Danyao Wang <[email protected]>
Commit-Queue: Eugene But <[email protected]>
Cr-Commit-Position: refs/heads/master@{#558760} | ba1815a412382038e41adc189134fcb1b75784aa | chrome | bigvul | 1 | null | null | null |
Roll src/third_party/webrtc/ 01042067b..a1f566b28 (14 commits)
https://webrtc.googlesource.com/src.git/+log/01042067beb1..a1f566b28a69
$ git log 01042067b..a1f566b28 --date=short --no-merges --format='%ad %ae %s'
Created with:
roll-dep src/third_party/webrtc
BUG=chromium:838672,chromium:None,chromium:755920
The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
[email protected]
Change-Id: I2bfdb1d8fa2b497d772d58cf21d7e3c1d1a67c5f
Reviewed-on: https://chromium-review.googlesource.com/1042493
Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#555790} | 213a35ad18a045cba0b1edb22f33dfc8d91c8681 | chrome | bigvul | 1 | null | null | null |
Revert "Roll src/third_party/webrtc/ 823f9135f..d5ef6ff25 (15 commits)"
This reverts commit 71098015063adea710cce4616686d08d65fc1940.
Reason for revert: ios build is still broken.
https://ci.chromium.org/buildbot/chromium.mac/ios-device-xcode-clang/59679
Original change's description:
> Roll src/third_party/webrtc/ 823f9135f..d5ef6ff25 (15 commits)
>
> https://webrtc.googlesource.com/src.git/+log/823f9135f858..d5ef6ff258da
>
> $ git log 823f9135f..d5ef6ff25 --date=short --no-merges --format='%ad %ae %s'
>
> Created with:
> roll-dep src/third_party/webrtc
> BUG=chromium:None,chromium:None,chromium:840347,chromium:839860,chromium:838402
>
>
> The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org
>
> Documentation for the AutoRoller is here:
> https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
>
> If the roll is causing failures, please contact the current sheriff, who should
> be CC'd on the roll, and stop the roller if necessary.
>
>
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
> [email protected]
>
> Change-Id: Ibaedd51469f75941f90aed9f4ba6bb686cd79f6c
> Reviewed-on: https://chromium-review.googlesource.com/1048112
> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
> Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
> Cr-Commit-Position: refs/heads/master@{#556561}
TBR=webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com,[email protected]
Change-Id: I2823387c7aadad799befbf88cc5b4503a379dd3c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:None, chromium:840347, chromium:839860, chromium:838402
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
Reviewed-on: https://chromium-review.googlesource.com/1049345
Commit-Queue: Kunihiko Sakamoto <[email protected]>
Reviewed-by: Kunihiko Sakamoto <[email protected]>
Cr-Commit-Position: refs/heads/master@{#556675} | d1429ef7c2699d69eec780f6f8beba5ecab9e312 | chrome | bigvul | 1 | null | null | null |
Fix wrapping behavior of description text in omnibox suggestion
This regression is introduced by
https://chromium-review.googlesource.com/c/chromium/src/+/827033
The description text should not wrap.
Bug: NONE
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Iaac5e6176e1730853406602835d61fe1e80ec0d0
Reviewed-on: https://chromium-review.googlesource.com/839960
Reviewed-by: Christopher Grant <[email protected]>
Commit-Queue: Biao She <[email protected]>
Cr-Commit-Position: refs/heads/master@{#525806} | a79e1bbb765af34d446e42d34cd00a312b381113 | chrome | bigvul | 1 | null | null | null |
Map U+04CF to lowercase L as well.
U+04CF (ӏ) has the confusability skeleton of 'i' (lowercase
I), but it can be confused for 'l' (lowercase L) or '1' (digit) if rendered
in some fonts.
If a host name contains it, calculate the confusability skeleton
twice, once with the default mapping to 'i' (lowercase I) and the 2nd
time with an alternative mapping to 'l'. Mapping them to 'l' (lowercase L)
also gets it treated as similar to digit 1 because the confusability
skeleton of digit 1 is 'l'.
Bug: 817247
Test: components_unittests --gtest_filter=*IDN*
Change-Id: I7442b950c9457eea285e17f01d1f43c9acc5d79c
Reviewed-on: https://chromium-review.googlesource.com/974165
Commit-Queue: Jungshik Shin <[email protected]>
Reviewed-by: Peter Kasting <[email protected]>
Reviewed-by: Eric Lawrence <[email protected]>
Cr-Commit-Position: refs/heads/master@{#551263} | f9b56bc54fdff5981dba39a707489c3ca9980fac | chrome | bigvul | 1 | null | null | null |
Fix the |name| of PerformanceNavigationTiming
Previously, the |name| of a PerformanceNavigationTiming entry was the initial
URL (the request URL). After this CL, it is the response URL, so for example
a url of the form 'redirect?location=newLoc' will have 'newLoc' as the |name|.
Bug: 797465
Change-Id: Icab53ad8027d066422562c82bcf0354c264fea40
Reviewed-on: https://chromium-review.googlesource.com/996579
Reviewed-by: Yoav Weiss <[email protected]>
Commit-Queue: Nicolás Peña Moreno <[email protected]>
Cr-Commit-Position: refs/heads/master@{#548773} | 87e204e0aaf7445afbd0d50af6849d857517ae70 | chrome | bigvul | 1 | null | null | null |
Force a flush of drawing to the widget when a dialog is shown.
BUG=823353
TEST=as in bug
Change-Id: I5da777068fc29c5638ef02d50e59d5d7b2729260
Reviewed-on: https://chromium-review.googlesource.com/971661
Reviewed-by: Ken Buchanan <[email protected]>
Commit-Queue: Avi Drissman <[email protected]>
Cr-Commit-Position: refs/heads/master@{#544518} | 2ccbb407dccc976ae4bdbaa5ff2f777f4eb0723b | chrome | bigvul | 1 | null | null | null |
[PaintWorklet] Do not paint when paint target is associated with a link
When the target element of a paint worklet has an associated link, then
the 'paint' function will be invoked when the link's href is changed
from a visited URL to an unvisited URL (or vice versa).
This CL changes the behavior by detecting whether the target element
of a paint worklet has an associated link or not. If it does, then don't
paint.
[email protected]
Bug: 835589
Change-Id: I5fdf85685f863c960a6f48cc9a345dda787bece1
Reviewed-on: https://chromium-review.googlesource.com/1035524
Reviewed-by: Xida Chen <[email protected]>
Reviewed-by: Ian Kilpatrick <[email protected]>
Reviewed-by: Stephen McGruer <[email protected]>
Commit-Queue: Xida Chen <[email protected]>
Cr-Commit-Position: refs/heads/master@{#555788} | 67d9b414fa64448abc398ae9fc57c3ddf5de5998 | chrome | bigvul | 1 | null | null | null |
[Extensions] Restrict tabs.captureVisibleTab()
Modify the permissions for tabs.captureVisibleTab(). Instead of just
checking for <all_urls> and assuming its safe, do the following:
- If the page is a "normal" web page (e.g., http/https), allow the
capture if the extension has activeTab granted or <all_urls>.
- If the page is a file page (file:///), allow the capture if the
extension has file access *and* either of the <all_urls> or
activeTab permissions.
- If the page is a chrome:// page, allow the capture only if the
extension has activeTab granted.
Bug: 810220
Change-Id: I1e2f71281e2f331d641ba0e435df10d66d721304
Reviewed-on: https://chromium-review.googlesource.com/981195
Commit-Queue: Devlin <[email protected]>
Reviewed-by: Karan Bhatia <[email protected]>
Cr-Commit-Position: refs/heads/master@{#548891} | 0aca6bc05a263ea9eafee515fc6ba14da94c1964 | chrome | bigvul | 1 | null | null | null |
[DevTools] Do not create target handler for restricted sessions
Bug: 805224
Change-Id: I08528e44e79d0a097cfe72ab4949dda538efd098
Reviewed-on: https://chromium-review.googlesource.com/988695
Reviewed-by: Pavel Feldman <[email protected]>
Commit-Queue: Dmitry Gozman <[email protected]>
Cr-Commit-Position: refs/heads/master@{#547496} | 46f5cfb6414c04b65cba4ec59ca992f338934fc9 | chrome | bigvul | 1 | null | null | null |
[DevTools] Do not allow chrome.debugger to attach to web ui pages
If the page navigates to web ui, we force detach the debugger extension.
[email protected]
Bug: 798222
Change-Id: Idb46c2f59e839388397a8dfa6ce2e2a897698df3
Reviewed-on: https://chromium-review.googlesource.com/935961
Commit-Queue: Dmitry Gozman <[email protected]>
Reviewed-by: Devlin <[email protected]>
Reviewed-by: Pavel Feldman <[email protected]>
Reviewed-by: Nasko Oskov <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540916} | 2aec794f26098c7a361c27d7c8f57119631cca8a | chrome | bigvul | 1 | null | null | null |
Fix Credential Management API Store() for existing Credentials
This changes fixes the Credential Management API to correctly handle
storing of already existing credentials. In the previous version
`preferred_match()` was updated, which is not necessarily the credential
selected by the user.
Bug: 795878
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I269f465861f44cdd784f0ce077e755191d3bd7bd
Reviewed-on: https://chromium-review.googlesource.com/843022
Commit-Queue: Jan Wilken Dörrie <[email protected]>
Reviewed-by: Balazs Engedy <[email protected]>
Reviewed-by: Jochen Eisinger <[email protected]>
Reviewed-by: Maxim Kolosovskiy <[email protected]>
Cr-Commit-Position: refs/heads/master@{#526313} | 1f35b6980f600ec93e167118c21959d5cbd7c5c4 | chrome | bigvul | 1 | null | null | null |
Add the method to check if offline archive is in internal dir
Bug: 758690
Change-Id: I8bb4283fc40a87fa7a87df2c7e513e2e16903290
Reviewed-on: https://chromium-review.googlesource.com/828049
Reviewed-by: Filip Gorski <[email protected]>
Commit-Queue: Jian Li <[email protected]>
Cr-Commit-Position: refs/heads/master@{#524232} | 9f6510f20ccd794c4a71d5779ae802241e6e3f9b | chrome | bigvul | 1 | null | null | null |
HTML parser: Fix "HTML integration point" implementation in HTMLTreeBuilderSimulator.
HTMLTreeBuilderSimulator assumed only <foreignObject> as an HTML
integration point. This CL adds <annotation-xml>, <desc>, and SVG
<title>.
Bug: 805924
Change-Id: I6793d9163d4c6bc8bf0790415baedddaac7a1fc2
Reviewed-on: https://chromium-review.googlesource.com/964038
Commit-Queue: Kent Tamura <[email protected]>
Reviewed-by: Kouhei Ueno <[email protected]>
Cr-Commit-Position: refs/heads/master@{#543634} | 133bc5c262b2555af223263452e9875a95db9eb7 | chrome | bigvul | 1 | null | null | null |
[css-typed-om] Use create* helper functions in tests.
Currently, to test style property maps, we have to set up some divs
in the body with the test styles. Each test case would then query the
style maps of these divs.
To simplify things, we add two helper functions: createInlineStyleMap
and createComputedStyleMap. Each take a string containing css and will
return an inline/computed StylePropertyMap with that css. This adds
greater isolation between test cases, simplifies tests, and will
help write succinct tests for the declared style property map, which
has a lot of boilerplate.
Bug: 774887
Change-Id: I0ffc571e37601fea02f9d27ef458e3c569ba58cf
Reviewed-on: https://chromium-review.googlesource.com/835887
Reviewed-by: nainar <[email protected]>
Commit-Queue: Darren Shen <[email protected]>
Cr-Commit-Position: refs/heads/master@{#526429} | fbf25ea941bf9f15aa1558c9606d25ef87fd2cfe | chrome | bigvul | 1 | null | null | null |
Apply ExtensionNavigationThrottle filesystem/blob checks to all frames.
BUG=836858
Change-Id: I34333a72501129fd40b5a9aa6378c9f35f1e7fc2
Reviewed-on: https://chromium-review.googlesource.com/1028511
Reviewed-by: Devlin <[email protected]>
Reviewed-by: Alex Moshchuk <[email protected]>
Reviewed-by: Nick Carter <[email protected]>
Commit-Queue: Charlie Reis <[email protected]>
Cr-Commit-Position: refs/heads/master@{#553867} | 7614790c80996d32a28218f4d1605b0908e9ddf6 | chrome | bigvul | 1 | null | null | null |
Roll src/third_party/pdfium/ fbecb9a51..e06880f8e (2 commits)
https://pdfium.googlesource.com/pdfium.git/+log/fbecb9a5150d..e06880f8eb98
$ git log fbecb9a51..e06880f8e --date=short --no-merges --format='%ad %ae %s'
2018-04-18 thestig Fix integer overflow in shading drawing code.
2018-04-18 tsepez Always build JS Runtime stubs even if V8 present.
Created with:
roll-dep src/third_party/pdfium
BUG=chromium:833721
The AutoRoll server is located here: https://pdfium-roll.skia.org
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
[email protected]
Change-Id: I5f24866aeca19c08d4e8f0459180c5b617263dc6
Reviewed-on: https://chromium-review.googlesource.com/1018119
Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#551912} | 1b7273d7a120c7e558287ce6878e8d96d40e3de7 | chrome | bigvul | 1 | null | null | null |
[MemCache] Fix bug while iterating LRU list in range doom
This is exact same thing as https://chromium-review.googlesource.com/c/chromium/src/+/987919
but on explicit mass-erase rather than eviction.
Thanks to nedwilliamson@ (on gmail) for the report and testcase.
Bug: 831963
Change-Id: I96a46700c1f058f7feebe038bcf983dc40eb7102
Reviewed-on: https://chromium-review.googlesource.com/1014023
Commit-Queue: Maks Orlovich <[email protected]>
Reviewed-by: Josh Karlin <[email protected]>
Cr-Commit-Position: refs/heads/master@{#551205} | 9ab771022535b499e4d7a7f12fa6c60a294f7de4 | chrome | bigvul | 1 | null | null | null |
Don't update PageState for a SiteInstance mismatch.
BUG=766262
TEST=See bug for repro.
Change-Id: Ifb087b687acd40d8963ef436c9ea82ca2d960117
Reviewed-on: https://chromium-review.googlesource.com/674808
Commit-Queue: Charlie Reis (OOO until 9/25) <[email protected]>
Reviewed-by: Łukasz Anforowicz <[email protected]>
Cr-Commit-Position: refs/heads/master@{#503297} | c050720e317e5223bcbdcaafb816befa789ceaa9 | chrome | bigvul | 1 | null | null | null |
Replace base::MakeUnique with std::make_unique in net/.
base/memory/ptr_util.h includes will be cleaned up later.
Bug: 755727
Change-Id: Ibaf46f05c9b02b76f9a91e819984b087a8c0d434
Reviewed-on: https://chromium-review.googlesource.com/627300
Commit-Queue: Jeremy Roman <[email protected]>
Reviewed-by: Daniel Cheng <[email protected]>
Reviewed-by: Bence Béky <[email protected]>
Cr-Commit-Position: refs/heads/master@{#498123} | 0579ed631fb37de5704b54ed2ee466bf29630ad0 | chrome | bigvul | 1 | null | null | null |
[Extensions] Harden against bindings interception
There's more we can do but this is a start.
BUG=590275
BUG=590118
Review URL: https://codereview.chromium.org/1748943002
Cr-Commit-Position: refs/heads/master@{#378621} | 75b803b1c81ed9fa5513cbff550232b4fb915e7b | chrome | bigvul | 1 | null | null | null |
[perf] Add load:news:nytimes:2018 system health story
Bug: 878390
Change-Id: I7dd274d816f8833bdabe890628b92f701612ffed
Reviewed-on: https://chromium-review.googlesource.com/c/1264659
Reviewed-by: Juan Antonio Navarro Pérez <[email protected]>
Commit-Queue: Ulan Degenbaev <[email protected]>
Cr-Commit-Position: refs/heads/master@{#597532} | f0e3fbfaed015301ad64bf4362eedc554076ef8c | chrome | bigvul | 1 | null | null | null |
[Extensions] Add more bindings access checks
BUG=598165
Review URL: https://codereview.chromium.org/1854983002
Cr-Commit-Position: refs/heads/master@{#385282} | 14ff9d0cded8ae8032ef027d1f33c6666a695019 | chrome | bigvul | 1 | null | null | null |
Fix one implicit 64-bit -> 32-bit implicit conversion in a PPAPI test.
../../ppapi/tests/test_url_loader.cc:877:11: warning: implicit conversion loses integer precision: 'int64_t' (aka 'long long') to 'int32_t' (aka 'int') [-Wshorten-64-to-32]
total_bytes_to_be_received);
^~~~~~~~~~~~~~~~~~~~~~~~~~
BUG=879657
Change-Id: I152f456368131fe7a2891ff0c97bf83f26ef0906
Reviewed-on: https://chromium-review.googlesource.com/c/1220173
Commit-Queue: Raymes Khoury <[email protected]>
Reviewed-by: Raymes Khoury <[email protected]>
Cr-Commit-Position: refs/heads/master@{#600182} | b276d0570cc816bfe25b431f2ee9bc265a6ad478 | chrome | bigvul | 1 | null | null | null |
Ensure Custom Tab intents opened by WebAPKs are treated like link navigations.
On Android, Chrome is responsible for handling external protocols and
determining if an external activity should be launched. When an
installed WebAPK opens a Chrome Custom Tab for an out of scope link, the
external protocol handling code was not being triggered for links like
mailto: and tel:, resulting in a broken CCT launch to the mailto: link
containing a blank page. This issue was caused by two reasons:
1. The navigation type for the Custom Tab intent was set to
PageTransition.FROM_API, indicating it came from an external intent.
This would trigger a code path that explicitly avoided launching an
external program.
2. Once (1) was addressed, the lack of a user gesture on the resulting
navigation created by the intent also blocked external program
launch.
This CL fixes both issues by introducing a new Custom Tab extra indicating
whether a Custom Tab intent came from a WebAPK. When this extra is
present, we do not set the FROM_API transition type, and we add a user
gesture on the resulting new tab navigation. This essentially passes on
the user gesture that must have been present to create the new tab in
the first place, mimicking the behaviour that should be present when
not in a standalone window.
BUG=792990
Change-Id: Ifad590228b10fa7a09c1c34611124957ba857ac1
Reviewed-on: https://chromium-review.googlesource.com/c/1270204
Reviewed-by: Yaron Friedman <[email protected]>
Reviewed-by: Peter Conn <[email protected]>
Commit-Queue: Dominick Ng <[email protected]>
Cr-Commit-Position: refs/heads/master@{#602970} | b63b45e4c49bf9af674e09d9bd362a1a10ee6bff | chrome | bigvul | 1 | null | null | null |
Allow origin lock for WebUI pages.
Returning true for WebUI pages in DoesSiteRequireDedicatedProcess helps
to keep enforcing a SiteInstance swap during chrome://foo ->
chrome://bar navigation, even after relaxing
BrowsingInstance::GetSiteInstanceForURL to consider RPH::IsSuitableHost
(see https://crrev.com/c/783470 for that fixes process sharing in
isolated(b(c),d(c)) scenario).
I've manually tested this CL by visiting the following URLs:
- chrome://welcome/
- chrome://settings
- chrome://extensions
- chrome://history
- chrome://help and chrome://chrome (both redirect to chrome://settings/help)
Bug: 510588, 847127
Change-Id: I55073bce00f32cb8bc5c1c91034438ff9a3f8971
Reviewed-on: https://chromium-review.googlesource.com/1237392
Commit-Queue: Łukasz Anforowicz <[email protected]>
Reviewed-by: François Doray <[email protected]>
Reviewed-by: Nasko Oskov <[email protected]>
Reviewed-by: Avi Drissman <[email protected]>
Cr-Commit-Position: refs/heads/master@{#595259} | 1f5ad409dbf5334523931df37598ea49e9849c87 | chrome | bigvul | 1 | null | null | null |
V8ValueConverter::ToV8Value should not trigger setters
BUG=606390
Review URL: https://codereview.chromium.org/1918793003
Cr-Commit-Position: refs/heads/master@{#390045} | b5bdf3778209179111c9f865af00940e74aa20e7 | chrome | bigvul | 1 | null | null | null |
📰 Add a notifications settings page for pre-O devices.
Bug: 746227
Change-Id: Icb5831b25c8c3a05625b6a286264307b95c96b5b
Reviewed-on: https://chromium-review.googlesource.com/589848
Commit-Queue: Peter Conn <[email protected]>
Reviewed-by: Bernhard Bauer <[email protected]>
Cr-Commit-Position: refs/heads/master@{#492596} | 81d73a47253db336c6fb2cbfe853e7e85f67afeb | chrome | bigvul | 1 | null | null | null |
Roll PDFium 8b45eb1..3cbb6fb
https://pdfium.googlesource.com/pdfium.git/+log/8b45eb1..3cbb6fb
BUG=613160
[email protected]
Review-Url: https://codereview.chromium.org/1999153002
Cr-Commit-Position: refs/heads/master@{#395117} | 3a89e0aab29cebcfe1f559387215c4b10be86b76 | chrome | bigvul | 1 | null | null | null |
Check CSP before registering ServiceWorkers
Service Worker registrations should be subject to the same CSP checks as
other workers. The spec doesn't say this explicitly
(https://www.w3.org/TR/CSP2/#directive-child-src-workers says "Worker or
SharedWorker constructors"), but it seems to be in the spirit of things,
and it matches Firefox's behavior.
BUG=579801
Review URL: https://codereview.chromium.org/1861253004
Cr-Commit-Position: refs/heads/master@{#385775} | 5289a5d4c98681e9a0f2d28da0c7aa35e282db57 | chrome | bigvul | 1 | null | null | null |
Roll libxslt to 891681e3e948f31732229f53cb6db7215f740fc7
BUG=583156,583171
Review URL: https://codereview.chromium.org/1853083002
Cr-Commit-Position: refs/heads/master@{#385338} | 96dbafe288dbe2f0cc45fa3c39daf6d0c37acbab | chrome | bigvul | 1 | null | null | null |
Roll src/third_party/pdfium aea4bca2621b..a6b07058f952 (5 commits)
https://pdfium.googlesource.com/pdfium.git/+log/aea4bca2621b..a6b07058f952
git log aea4bca2621b..a6b07058f952 --date=short --no-merges --format='%ad %ae %s'
2019-09-04 [email protected] Add a test for glyph path rendering.
2019-09-04 [email protected] Add a pixel test for a fixed JBIG2 bug.
2019-09-04 [email protected] Remove CRLF line endings from link_annots.in.
2019-09-03 [email protected] Roll third_party/freetype/src/ 9adc3b35f..543a3b939 (31 commits)
2019-08-28 [email protected] Add embedder tests for progressive render public APIs
Created with:
gclient setdep -r src/third_party/pdfium@a6b07058f952
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pdfium-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
[email protected]
Bug: chromium:601362,chromium:963885
Change-Id: Ib95fe39d0b40e4f159dd0dd4493b6bc4070d53d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783561
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/master@{#693391} | 0cec9dcb0f83536a041d4db4bd741ccd43100fa8 | chrome | bigvul | 1 | null | null | null |
Clear |composing_text_| after CommitText() is called.
|composing_text_| of InputConnectionImpl should be cleared after
CommitText() is called. Otherwise, FinishComposingText() will commit the
same text twice.
Bug: 899736
Test: unit_tests
Change-Id: Idb22d968ffe95d946789fbe62454e8e79cb0b384
Reviewed-on: https://chromium-review.googlesource.com/c/1304773
Commit-Queue: Yusuke Sato <[email protected]>
Reviewed-by: Yusuke Sato <[email protected]>
Cr-Commit-Position: refs/heads/master@{#603518} | e3e16497d0d5639fb3257305ea369ba4ab8ba210 | chrome | bigvul | 1 | null | null | null |
Create Crostini Feature and Flag for Crostini USB support
Adds feature for Mounting Usbs into Crostini.
Bug: 891381, 899568
Change-Id: I36f5cdf88d2901b24c9ef83671418fae64f275ad
Reviewed-on: https://chromium-review.googlesource.com/c/1301095
Commit-Queue: Josh Pratt <[email protected]>
Reviewed-by: Nicholas Verne <[email protected]>
Reviewed-by: Ben Wells <[email protected]>
Cr-Commit-Position: refs/heads/master@{#603748} | 57cea39f336a9465aafdec373867b9c36de9394c | chrome | bigvul | 1 | null | null | null |
Disable flaky {...}update-registration-with-type.https.html tests.
virtual/outofblink-cors/external/wpt/service-workers/service-worker/update-registration-with-type.https.html
virtual/service-worker-servicification/external/wpt/service-workers/service-worker/update-registration-with-type.https.html
virtual/outofblink-cors-ns/external/wpt/service-workers/service-worker/update-registration-with-type.https.html
[email protected]
NOTRY=true
Bug: 901317
Change-Id: I7e8dc6a90cbcf6c13dfe1bddee15c56880138466
Reviewed-on: https://chromium-review.googlesource.com/c/1314493
Commit-Queue: vitaliii <[email protected]>
Reviewed-by: vitaliii <[email protected]>
Cr-Commit-Position: refs/heads/master@{#604897} | d2dd2a041859ff586a8a3407c74dfc929ed4008a | chrome | bigvul | 1 | null | null | null |
Use 0xFE opacity for sheld in maximized state.
This is a workaround. Using fully opaque color somehow
causes the content clipping on the arc content window.
It'll be investigated separately.
Bug: 901538
Test: manual.
Change-Id: Ifee1ccdeb3e877008f33ef62ba1dd5024bb4b196
Reviewed-on: https://chromium-review.googlesource.com/c/1324393
Reviewed-by: Alex Newcomer <[email protected]>
Commit-Queue: Mitsuru Oshima <[email protected]>
Cr-Commit-Position: refs/heads/master@{#606185} | bc8967075ab8cf77627863845dc4a3af22b47f88 | chrome | bigvul | 1 | null | null | null |
Remove WeakPtrFactory from PasswordAutofillAgent
Unlike in AutofillAgent, the factory is no longer used in PAA.
[email protected]
BUG=609010,609007,608100,608101,433486
Review-Url: https://codereview.chromium.org/1945723003
Cr-Commit-Position: refs/heads/master@{#391475} | 9de81f45c73a8f9f215fc234a6adfe087b0eab74 | chrome | bigvul | 1 | null | null | null |
Roll PDFium e5984e9..461129e
https://pdfium.googlesource.com/pdfium.git/+log/e5984e9..461129e
BUG=401189, 601362, 602046
[email protected]
Review URL: https://codereview.chromium.org/1878943005
Cr-Commit-Position: refs/heads/master@{#386844} | 96b1d62776fbe12940581493cb8537f2ba926bec | chrome | bigvul | 1 | null | null | null |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.