id
int64 393k
2.82B
| repo
stringclasses 68
values | title
stringlengths 1
936
| body
stringlengths 0
256k
β | labels
stringlengths 2
508
| priority
stringclasses 3
values | severity
stringclasses 3
values |
|---|---|---|---|---|---|---|
651,695,126 |
go
|
html/template: unexpected semantic differences compared to text/template
|
I ported the text/template tests over to html/template and discovered some semantic differences between the two that I did not expect.
In html/template:
- Missing values format as empty strings, while in text/template they format as `<no value>`. For example:
- {"map .NO", "{{.MSI.NO}}", "<no value>", tVal, true},
+ {"map .NO", "{{.MSI.NO}}", "", tVal, true}, // NOTE: <no value> in text/template
- {"empty nil", "{{.Empty0}}", "<no value>", tVal, true},
+ {"empty nil", "{{.Empty0}}", "", tVal, true}, // NOTE: <no value> in text/template
and so on
- Missing values passed explicitly to the html escaper format as `<nil>` instead of `<no value>`:
- {"html untyped nil", `{{html .Empty0}}`, "<no value>", tVal, true},
+ {"html untyped nil", `{{html .Empty0}}`, "<nil>", tVal, true}, // NOTE: "<no value>" in text/template
- Given an addressable struct field with a pointer-receiver String method, the String method is not used (in text/template it is):
- {"V{6666}.String()", "-{{.V0}}-", "-<6666>-", tVal, true},
+ {"V{6666}.String()", "-{{.V0}}-", "-{6666}-", tVal, true}, // NOTE: -<6666>- in text/template
- Given an addressable struct field with a pointer-receiver Error method, the Error method is not used (in text/template it is):
- {"W{888}.Error()", "-{{.W0}}-", "-[888]-", tVal, true},
+ {"W{888}.Error()", "-{{.W0}}-", "-{888}-", tVal, true}, // NOTE: -[888] in text/template
- TestExecuteOnNewTemplate crashes on all the cases from #11379.
- TestMessageForExecuteEmpty shows a different error message:
- template: empty: "empty" is an incomplete or empty template
+ template: "empty" is an incomplete or empty template
- TestIssue31810 fails (βcheck that a parenthesized first argument behaves properlyβ, for #31810).
- TestTemplateLookUp (for #10910, #10926) fails. Lookup returns non-nil values for undefined templates.
- Calling `Parse("")` does not overwrite the text of a previous template parse, as it does in text/template.
See TestEmptyTemplate, specifically the last case in the table:
{[]string{"{{.}}", ""}, "twice", ""},
The `<no value>` change looks like it may possibly be intentional. All the others look like bugs.
/cc @robpike
|
NeedsInvestigation
|
low
|
Critical
|
651,697,178 |
terminal
|
Epic: Settings UI Completion
|
_written and maintained by @carlos-zamora_
Settings UI Issue: #1564
Settings UI PR: #8048
Settings UI Spec & Design: #6720
Now that it has merged to main, there are a few follow-up items to work on. This scenario tracks follow-up tasks from that PR, and other features we are committing to for Windows Terminal v2.
## Features
- [x] **Profile/ColorScheme should have an Add/Rename/Delete option**
- PR #8403
- [x] **SettingsContainer**
- ~Implement #8269 (tracked in #8804 )~ PR #8919
- Add hyperlinks (navigate to source)
- Add hyperlinks for read-only pages (i.e. profile generators)
- [x] **Terminal Appearance Preview** (#9122)
- Embed a `TermControl` in the "Appearance" tab of a Profile page. This `TermControl` should update as you make changes to your `Profile`
- A similar thing should be done to the ColorSchemes page
- [x] **FontFace as a ~TextBox~ ComboBox**
- FontFace would be easier to select if it was a ComboBox of supported fonts. The list should only include (or at least denote) monospace fonts.
- [x] #9121 "Add a profile" page
## Styling
- [X] **Custom Enum Ordering** (PR #8784 )
- Some enum lists (i.e. Font Weight), are not intuitively ordered.
## Tasks
- [x] Document how to add a setting ("AddASetting.md")
- [ ] Deduplicate Browse button logic
- [ ] #8452 Polish `TabBase`
- [ ] Remove visibility hacks (i.e. acrylic opacity slider), and use ProfileViewModel instead
- [x] #8746: Finalize localization changes (#8777)
- [x] #8764: Polish Profile page
- [x] #8765: Polish ColorSchemes page
- [x] #8899: Automation Properties
- [x] #9075: initialPosition, centerOnLaunch
## Bugs
- [X] JSON change --> crash
- ~open SUI --> open JSON --> edit retro effects in JSON --> save file --> cry because the app crashed~
- No longer getting a repro on main (6b2ae625). 990e06b4 's changes to the refresh mechanism may have fixed this?
- [x] #8747: delete new profile --> crash
- [x] #8748: delete newly (un)hidden profile --> crash
- [x] #8756: Rename color scheme should update profile
- [x] #13451
## Backlog
- [ ] Settings UI reformats settings.json in an hard to read way #8991
- [ ] **Home Page** #9120
- Add a Home page that can present release notes, docs, and any other helpful information for Windows Terminal
- [ ] #8639 Import Color Scheme
- [ ] **Search**
- #7370 has a rough implementation of Search in MainPage.xaml ([link](https://github.com/microsoft/terminal/blob/a305c0d9689a87140a1fdd69520068e25d5fee80/src/cascadia/TerminalSettingsEditor/MainPage.xaml#L29))
- Needs to be localizable
- [ ] **Detect unsaved changes**
- Update the warning label and Discard/Apply buttons appropriately
- #12424
|
Product-Terminal,Issue-Scenario,Area-SettingsUI
|
low
|
Critical
|
651,709,268 |
godot
|
EditorPlugin.make_visible() is called multiple times when selecting a node handled by the plugin
|
Godot 3.2.2
Windows 10 64 bits
I made a plugin which can handle `Spatial`, and I noticed that when I select an object (here a `Spatial` node), Godot calls `make_visible()` multiple times: once `make_visible(true)`, then `make_visible(false)`, then `make_visible(true)` again.
This is wasting calls to a function that potentially does heavy lifting, especially knowing that `make_visible()` is currently the only way to cleanup heavy resources when the user is assumed to have deselected all objects handled by the plugin.
Repro:
[PluginMakeVisibleTwice.zip](https://github.com/godotengine/godot/files/4880408/PluginMakeVisibleTwice.zip)
Open project, open `main.tscn`, select the `Spatial` node. Notice 3 prints in the console.
If you select the `Node`, only 1 print occurs which is correct. But if you select the `Spatial` again it's getting 3 prints again which is not expected.
Could be related to https://github.com/godotengine/godot/issues/6459#issuecomment-653980413, but not directly because I found this *while* I was making an actual repro for that linked comment.
|
bug,topic:editor,topic:plugin
|
low
|
Minor
|
651,719,019 |
rust
|
ICE trying to link corrupt/bogus static library
|
<!--
Thank you for finding an Internal Compiler Error! π§ If possible, try to provide
a minimal verifiable example. You can read "Rust Bug Minimization Patterns" for
how to create smaller examples.
http://blog.pnkfx.org/blog/2019/11/18/rust-bug-minimization-patterns/
-->
This is a pretty weird one; we bumped into this due to a bad combination of Linux Docker containers running with mounted volumes on a Mac host and trying to build with stale artifacts. I made a repo that reproduces this ICE at https://github.com/jgallagher-cs/rustc-ice.
We have a C file (`foo.c` in the reproducer repo) that was compiled into a library on Linux (a CentOS 6 Docker container, although I suspect that doesn't matter too much):
```
gcc -c foo.c -o foo.o
ar cr libfoo.a foo.o
```
The library file itself was then copied to a Mac (running Catalina), where `foo.c` was recompiled and `ar` was used again to update `libfoo.a`:
```
clang -c foo.c -o foo.o
ar cr libfoo.a foo.o # NOTE: updates the linux libfoo.a
```
I very much doubt this should work and don't know enough about the archive format (and the differences between Linux and Mac `ar` implementations) to know exactly what's going wrong, but if you then try to link this library on a Mac with rustc, I hit an ICE.
### Code
No Rust code is involved here other than a build script instructing cargo to link a library; e.g.,
```Rust
fn main() {
println!("cargo:rustc-link-search=foo-mac");
println!("cargo:rustc-link-lib=static=foo");
}
```
### Meta
<!--
If you're using the stable version of the compiler, you should also check if the
bug also exists in the beta or nightly versions.
-->
`rustc --version --verbose`:
```
rustc 1.44.0 (49cae5576 2020-06-01)
binary: rustc
commit-hash: 49cae55760da0a43428eba73abcb659bb70cf2e4
commit-date: 2020-06-01
host: x86_64-apple-darwin
release: 1.44.0
LLVM version: 9.0
```
I believe a coworker confirmed the same ICE on 1.44.1.
### Error output
```
thread 'rustc' panicked at 'called `Option::unwrap()` on a `None` value', src/librustc_codegen_llvm/back/archive.rs:274:33
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
error: internal compiler error: unexpected panic
note: the compiler unexpectedly panicked. this is a bug.
note: we would appreciate a bug report: https://github.com/rust-lang/rust/blob/master/CONTRIBUTING.md#bug-reports
note: rustc 1.44.0 (49cae5576 2020-06-01) running on x86_64-apple-darwin
note: compiler flags: -C debuginfo=2 -C incremental --crate-type lib
note: some of the compiler flags provided by cargo are hidden
error: could not compile `rustc-ice`.
To learn more, run the command again with --verbose.
```
<!--
Include a backtrace in the code block by setting `RUST_BACKTRACE=1` in your
environment. E.g. `RUST_BACKTRACE=1 cargo build`.
-->
<details><summary><strong>Backtrace</strong></summary>
<p>
```
stack backtrace:
0: <std::sys_common::backtrace::_print::DisplayBacktrace as core::fmt::Display>::fmt
1: core::fmt::write
2: std::io::Write::write_fmt
3: std::panicking::default_hook::{{closure}}
4: std::panicking::default_hook
5: rustc_driver::report_ice
6: std::panicking::rust_panic_with_hook
7: rust_begin_unwind
8: core::panicking::panic_fmt
9: core::panicking::panic
10: <rustc_codegen_llvm::back::archive::LlvmArchiveBuilder as rustc_codegen_ssa::back::archive::ArchiveBuilder>::build
11: rustc_session::utils::<impl rustc_session::session::Session>::time
12: <rustc_codegen_llvm::LlvmCodegenBackend as rustc_codegen_ssa::traits::backend::CodegenBackend>::link
13: rustc_interface::queries::Linker::link
14: rustc_interface::interface::run_compiler_in_existing_thread_pool
15: scoped_tls::ScopedKey<T>::set
16: rustc_ast::attr::with_globals
```
</p>
</details>
|
A-linkage,I-ICE,T-compiler,C-bug
|
low
|
Critical
|
651,720,861 |
godot
|
EditorPlugin.make_visible() is called multiple times when already visible and selecting another object the plugin handles
|
Godot 3.2.2
Windows 10 64 bits
As a continuation of https://github.com/godotengine/godot/issues/6459#issuecomment-653980413
I made a plugin which can edit a specific object with a graph editor. Selecting that object shows it (throught `make_visible`), and clicking on a `GraphNode` may allow to inspect properties of a sub-object using the inspector, similar to how `VisualScript` works. I made it so my plugin handles both object types, so my expectation was that it would not be made invisible when I select back and forth between these objects.
The problem is, when I use `inspect()`, Godot calls `make_visible()` on my plugin *4 times in a row*, with alternating visibilities. Not only this is a waste as I cleanup my UI when my plugin is hidden, but even if I don't cleanup anything, hiding the `GraphEdit` breaks its input management, causing nodes to stick to the mouse, box selections to never end or to never be shown. It's basically unusable.
I would have expected `make_visible()` to not be called *at all*, because I edited another sub-object my plugin also handles.
Repro:
[PluginInspectMakeVisible.zip](https://github.com/godotengine/godot/files/4880478/PluginInspectMakeVisible.zip)
Here I chose `Sprite` and `GraphNode` for the sake of testing, in reality my objects are different.
- Open main.tscn
- Select `Sprite`: the graph editor should open in the bottom panel, with 2 sample graphnodes in it
- Select one of the graphnodes: observe the node sticks to the mouse unexpectedly.
- Observe in the console that 7 `make_visible` prints happened:
3 prints due to https://github.com/godotengine/godot/issues/40165
```
Called make_visible True (1)
Called make_visible False (2)
Called make_visible True (3)
```
4 additional prints from the present issue, due to selecting the second handled object:
```
Called make_visible False (4)
Called make_visible True (5)
Called make_visible False (6)
Called make_visible True (7)
```
I expected just one in total, `make_visible(true)`.
|
bug,topic:editor,confirmed,topic:plugin
|
low
|
Minor
|
651,753,454 |
pytorch
|
out= resizing (and restriding) behavior is confusing
|
Today in PyTorch we may resize and restride tensors provided to as arguments to `out`. For example:
```
a = torch.tensor([1, 2, 3])
b = torch.tensor([4, 5, 6])
out = torch.empty(2)
torch.add(a, b, out=out)
: tensor([5., 7., 9.])
```
Here a tensor of two elements is provided as the out argument, but the tensor returned has three elements.
This behavior is silent and (anecdotally) a frequent cause of user confusion.
I would like to propose we deprecate the current behavior and implement the following:
- Tensors with no elements passed to the out argument are treated as references, and PyTorch may allocate storage to hold the results of the operation and assign it to the given tensor
- Tensors with more than zero elements cannot be resized or restrided
The first behavior is a common pattern internally in PyTorch, and is useful when dealing with operators like masked_select where the size of the output is difficult to determine without running the operation. The second behavior is inconsistent with NumPy, which supports broadcasting to out tensors:
```
a = np.array([1])
b = np.array([2])
out = np.empty(3)
np.add(a, b, out=out)
: array([3., 3., 3.])
```
The NumPy behavior may be confusing, however. Also, throwing a runtime error instead of supporting NumPy behavior is an acceptable inconsistency, and it gives PyTorch the option to implement NumPy-like behavior in the future without it being a BC-breaking change.
@ngimel @VitalyFedyunin @ezyang @albanD
cc @mruberry @rgommers @ezyang @gchanan @SsnL
|
module: bc-breaking,triaged,module: numpy,module: safe resize,topic: bc breaking
|
medium
|
Critical
|
651,775,069 |
svelte
|
Support for "High Order Component" / Wrapper / Forwarding
|
**Is your feature request related to a problem? Please describe.**
I want to build a "transparent" lazy-loading component. This component should load a target component asynchronously, and when ready, delegate everything to this target.
This lazy-component should be generic: it should work for every target component. Moreover, I don't want the consumer of the component to know there is this wrapper, it should be "transparent" for it.
Today, it doesn't seem to be possible to build such "wrapper" because :
- There is no API to forwards slots to the delegate ;
- There is no API to forwards events to the delegate ;
- There is no API to forwards "bind" from the parent to the delegate ;
There is various issues about this :
#2837 about forwardings events ;
#1824 and #4295 about forwardings slots ;
I found nothing about "binding" forwardings.
#4647 is about a loadable component, closed because "svelte-loadable" can implements this issue. however, it's false because it doesn't supports slots or events.
**Describe the solution you'd like**
An official way/api to "wrapper" transparently another component.
**Describe alternatives you've considered**
I am able to prototype such wrapper with internals API, however I am not able to forwards binding from parent to child :
```html
<svelte:component this={cpn} {...slotsProps} {...$$restProps} bind:this={instance}/>
<script>
import { get_current_component } from 'svelte/internal';
export let provider;
const slotsProps = {"$$slots":$$props.$$slots, "$$scope":$$props.$$scope};
const self = get_current_component();
let cpn;
let instance;
provider().then(result => cpn = result);
$: if (instance) {
for (let [type, listeners] of Object.entries(self.$$.callbacks)) {
instance.$on(type, (e) => {
listeners.forEach(l => l(e));
});
}
}
</script>
```
**How important is this feature to you?**
I can't today implements this kind of component. I'd like to "wrap" heavyweight components without updating or adding loading logic to every consumer.
|
feature request,temp-stale
|
low
|
Major
|
651,795,043 |
go
|
x/pkgsite: include experiments in the cache key
|
The active experiments should be part of the cache key, so a cached page is only displayed if the experiments are the same.
|
NeedsInvestigation,pkgsite
|
low
|
Minor
|
651,798,608 |
TypeScript
|
Auto-completions from global type definitions don't work without initial text
|
*TS Template added by @mjbvz*
**TypeScript Version**: 3.9.6
**Search Terms**
- untitled
- suggest / suggestions
---
I'm not sure if this is the right place to open the issue (I also don't know where the TS language server is on github), so if it isn't, move the issue to the right place please :)
Steps to Reproduce:
1. Open a new untitled file
2. Set the syntax to javascript
3. Paste the following code:
```js
/**
* @type {import('webpack').Configuration}
*/
module.exports = {
};
```
4. Ctrl+click the word `Configuration` to jump to the type definitions file, and make sure it is the one that comes with VSCode (on Windows it's `%LOCALAPPDATA%\Microsoft\TypeScript\3.9\node_modules\@types\webpack\index.d.ts`).
5. Go back to the untitled file, and place the cursor inside the braces of the exports object
6. Trigger autocompletion popup using <kbd>Ctrl</kbd>+<kbd>Space</kbd>
7. Only snippets and words from the current file are suggested, instead of members from the type definition.
8. Close the popup using <kbd>Escape</kbd>
9. Type <kbd>m</kbd>
10. The completions for `mode` and `module` appear, from the type definition.
If you repeat this with a saved file inside a folder with `@types/webpack` installed in `node_modules`, the autocompletion will show all the members as expected.
- VS Code Version: Code - Insiders 1.47.0-insider (376d9d9d785ccca128fdbb16f001446d0ad64d32, 2020-07-03T10:27:06.804Z)
- OS Version: Windows_NT x64 10.0.18363
Does this issue occur when all extensions are disabled?: Yes
|
Bug,Domain: Completion Lists
|
low
|
Minor
|
651,853,157 |
opencv
|
setMouseCallback() causes "error: (-27:Null pointer) NULL window handler" in Python / on PyPi version 4.3.0.36
|
##### System information (version)
- OpenCV => 4.3.0.36
- Operating System / Platform => Ubuntu 18.04 64 Bit
- Compiler => Unknown (installed from PyPi on Python 3.6.8)
##### Detailed description
This is a bug triggered on `cv2.setMouseCallback` and seemingly the QT backend, which reports the following error when running the code below:
`cv2.error: OpenCV(4.3.0) /io/opencv/modules/highgui/src/window_QT.cpp:717: error: (-27:Null pointer) NULL window handler in function 'cvSetMouseCallback'`
When running the sample code below, this error occurs *sometimes* when running the code, while other times the code runs just fine. I also tried adding a `time.sleep(1.0)`, or `cv2.imshow("image", arr)`, between the `cv2.namedWindow` and `cv2.setMouseCallback` calls, but it doesn't seem to change the symptoms.
I believe that this is a specific problem with the PyPi version of OpenCV `4.3.0.36`. When I installed `4.2.0.34` instead, the symptom does not occur.
##### Steps to reproduce
```bash
cd ~
/usr/bin/python3 -m venv cvtest
source cvtest/bin/activate
pip install --upgrade pip
pip install opencv-python==4.3.0.36
```
```python
# Code from official docs: https://docs.opencv.org/master/db/d5b/tutorial_py_mouse_handling.html
import numpy as np
import cv2 as cv
# mouse callback function
def draw_circle(event,x,y,flags,param):
if event == cv.EVENT_LBUTTONDBLCLK:
cv.circle(img,(x,y),100,(255,0,0),-1)
# Create a black image, a window and bind the function to window
img = np.zeros((512,512,3), np.uint8)
cv.namedWindow('image')
cv.setMouseCallback('image',draw_circle)
while(1):
cv.imshow('image',img)
if cv.waitKey(20) & 0xFF == 27:
break
cv.destroyAllWindows()
```
##### Issue submission checklist
- [x] I report the issue, it's not a question
- [x] I checked the problem with documentation, FAQ, open issues,
answers.opencv.org, Stack Overflow, etc and have not found solution
- [x] I updated to latest OpenCV version and the issue is still there
- [x] There is reproducer code and related data files: videos, images, onnx, etc
|
category: python bindings,category: highgui-gui,incomplete
|
low
|
Critical
|
651,858,279 |
opencv
|
projectpoints distortion handling (and possibly ignore some points in the projection)
|
##### System information (version)
Example
- OpenCV => 4.3
- Operating System / Platform => Ubuntu
- Compiler => gcc version 4.8.5
##### Detailed description
I'm opening this issue after the question I put a couple of days ago in the answers website.
I'll copy here only the relevant part of the question related to my answer, since after a couple of days thinking about it I do not really believe there is a "real" error in the code, but rather a simplification or something that nobody thought about simply because is a very specific application.
To recap, I was trying to project 3D points to an image that has still the distortion and for some reason I don't want to correct the distortion before applying the projection, you can find more details on the question (this is the link to the question: https://answers.opencv.org/question/231939/projectpoints-distortion ). The important thing is that I have the intrinsic and extrinsic parameters of the system.
I used the _projectpoints_ routine for this process and I have found what I initially thought as a bug in the code, that is, 3D points that appear in a "random" way in the image plane. In my first attempt to understand what was going on, I've created a 3D plane in front of the camera and used the system parameters to project them; then I gradually started to move this plane near the camera. The following images are the result of this experiment
As you can see, as the plane come closer than a certain threshold, some points start to come back into the image plane.
Now, as you can read in the answer's post, the fact was even more strange because there're some opened questions in the answer's website saying ([like this one](https://answers.opencv.org/question/227094/cvprojectpoints-giving-bad-results-when-undistorted-2d-projections-are-far/)) stating that in some cases using less distortion coefficients does not introduce "errors".
I've been digging into the OpenCV code, compiling all the necessary in debug mode and doing a step-by-step debuggin session of the same implementation I previously had in Python now in C++ ([here is the code](https://github.com/trigal/calib-test/blob/master/projectpoints.cpp)).
My conclusion is that is not a real bug, it is simply the way in which the routine works. But, there's the issue of "returning" points, or whatever name we want to give to those points.
The fact is that those "strange" points of the images above are nothing less than these ones I've created using a much higher value for K4 (the 5th element of distorsion) in the following image:
The issue than can be translated into: can we find a way to automagically remove those points behind some kind of, let's say, distortion limit?
I don't really know how to simply do that, maybe the jacobian evaluated for every point can be used, or maybe not, but certainly it would be an interesting extension of the current behavior of this function.
At this time, I do not have time to investigate for an elegant solution and my way to solve this issue was just to compare the position of the distorsion-free point (using all K's set to zero) and checking whether the point falls inside a specific region, but this is a way too trivial workaround for a real issue.
To summarize the issue, I think that the following two gifs can explain better than all my words.
OpenCV code without any "extra" filtering:
Same code but with some workaround before drawing the points
##### Steps to reproduce
The link to reproduce the code is here: https://github.com/trigal/calib-test/blob/master/projectpoints.cpp and you'll see the super trivial workaround I've used to exclude those points that are coming back to the image plane. Kitti is the image (I'm using images from the KITTI dataset), and the trick is just to check whether the points without the distortion are too far from the image plane limits, and since there is a 1-1 correspondence between the points with/without the distortion, I can simply select those I think are good.
```.cpp
double x_offset = -150;
double y_offset = -150;
if (
((imagePointsUndistort.at(i).x>.00+x_offset) && (imagePointsUndistort.at(i).y>0.0+y_offset)) &&
((imagePointsUndistort.at(i).x<kitti.size[1]-x_offset) && (imagePointsUndistort.at(i).y<kitti.size[0]-y_offset))
)
```
Bests,
Augusto
##### Issue submission checklist
- [X] I report the issue, it's not a question
<!--
OpenCV team works with answers.opencv.org, Stack Overflow and other communities
to discuss problems. Tickets with question without real issue statement will be
closed.
-->
- [X] I checked the problem with documentation, FAQ, open issues,
answers.opencv.org, Stack Overflow, etc and have not found solution
<!--
Places to check:
* OpenCV documentation: https://docs.opencv.org
* FAQ page: https://github.com/opencv/opencv/wiki/FAQ
* OpenCV forum: https://answers.opencv.org
* OpenCV issue tracker: https://github.com/opencv/opencv/issues?q=is%3Aissue
* Stack Overflow branch: https://stackoverflow.com/questions/tagged/opencv
-->
- [X] I updated to latest OpenCV version and the issue is still there
<!--
master branch for OpenCV 4.x and 3.4 branch for OpenCV 3.x releases.
OpenCV team supports only latest release for each branch.
The ticket is closed, if the problem is not reproduced with modern version.
-->
- [X] There is reproducer code and related data files: videos, images, onnx, etc
<!--
The best reproducer -- test case for OpenCV that we can add to the library.
Recommendations for media files and binary files:
* Try to reproduce the issue with images and videos in opencv_extra repository
to reduce attachment size
* Use PNG for images, if you report some CV related bug, but not image reader
issue
* Attach the image as archite to the ticket, if you report some reader issue.
Image hosting services compress images and it breaks the repro code.
* Provide ONNX file for some public model or ONNX file with with random weights,
if you report ONNX parsing or handling issue. Architecture details diagram
from netron tool can be very useful too. See https://lutzroeder.github.io/netron/
-->
|
category: calib3d,RFC
|
low
|
Critical
|
651,861,885 |
youtube-dl
|
Apple iTunes Podcasts support request
|
<!--
######################################################################
WARNING!
IGNORING THE FOLLOWING TEMPLATE WILL RESULT IN ISSUE CLOSED AS INCOMPLETE
######################################################################
-->
## Checklist
<!--
Carefully read and work through this check list in order to prevent the most common mistakes and misuse of youtube-dl:
- First of, make sure you are using the latest version of youtube-dl. Run `youtube-dl --version` and ensure your version is 2020.06.16.1. If it's not, see https://yt-dl.org/update on how to update. Issues with outdated version will be REJECTED.
- Make sure that all provided video/audio/playlist URLs (if any) are alive and playable in a browser.
- Make sure that site you are requesting is not dedicated to copyright infringement, see https://yt-dl.org/copyright-infringement. youtube-dl does not support such sites. In order for site support request to be accepted all provided example URLs should not violate any copyrights.
- Search the bugtracker for similar site support requests: http://yt-dl.org/search-issues. DO NOT post duplicates.
- Finally, put x into all relevant boxes (like this [x])
-->
- [x] I'm reporting a new site support request
- [x] I've verified that I'm running youtube-dl version **2020.06.16.1**
- [x] I've checked that all provided URLs are alive and playable in a browser
- [x] I've checked that none of provided URLs violate any copyrights
- [x] I've searched the bugtracker for similar site support requests including closed ones
## Example URLs
<!--
Provide all kinds of example URLs support for which should be included. Replace following example URLs by yours.
-->
Individual podcasts:
https://podcasts.apple.com/us/podcast/207-whitney-webb-returns/id1135137367?i=1000482637777
https://podcasts.apple.com/us/podcast/1502-russell-peters/id360084272?i=1000482401298
https://podcasts.apple.com/us/podcast/s03-episode-09-some-time-when-everything-has-changed/id917918570?i=1000423902129
Directory:
https://podcasts.apple.com/us/podcast/serial/id917918570
## Description
<!--
Provide any additional information.
If work on your issue requires account credentials please provide them or explain how one can obtain them.
-->
WRITE DESCRIPTION HERE
I would like to be able to download podcasts that are listed in Apple's Podcasts directory. You can play them from their website by clicking the play button. However, `youtube-dl` cannot download them.
|
site-support-request
|
low
|
Critical
|
651,864,453 |
TypeScript
|
IntelliSense Import Stops Working After One Import
|
*TS Template added by @mjbvz*
**TypeScript Version**: 3.9.5
**Search Terms**
- npm link
- linux
- auto import
---
<!-- β οΈβ οΈ Do Not Delete This! bug_report_template β οΈβ οΈ -->
<!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ -->
<!-- Please search existing issues to avoid creating duplicates. -->
<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: https://code.visualstudio.com/insiders/ -->
<!-- Use Help > Report Issue to prefill these. -->
- VSCode Version: 1.46.1
- OS Version: Linux x64 5.3.0-61-generic snap
Steps to Reproduce:
I created a stripped down repo: [https://github.com/shcca/vscode](https://github.com/shcca/vscode)
1. `npm install`
2. `cd packages/cli`
3. `npm link ../core`
4. *packages/core/test.ts* and enter/save:
```typescript
export const helloWorld1 = () => {}
```
5. *packages/cli/deploy.ts* and add at the top:
```typescript
import { helloWorld1 } from 'core'
```
6. *packages/cli/deploy.ts*, within the handler function, add/save:
```typescript
helloWorld1()
```
7. *packages/core/test.ts*, add/save:
```typescript
export const helloWorld2 = () => {}
```
8. *packages/core/deploy.ts*, under *helloWorld1()*, enter *helloWorld2()*.
IntelliSense doesn't pick up on helloWorld2(). The only way to get it work is to restart VSCode, but then helloWorld3() wouldn't work. This is something that broke recently because I've been working in this project structure for a while with no issues.
<!-- Launch with `code --disable-extensions` to check. -->
Does this issue occur when all extensions are disabled?: Yes
|
Needs Investigation,Rescheduled
|
low
|
Critical
|
651,865,796 |
pytorch
|
Human-readable names and operations for TorchScript model graphs
|
<mirroring an internal FB Task on GH for consolidation of issue tracking>
For visualization and debugging purposes, we'd like to be able to parse the graph of a TorchScript model and display it in an easy-to-understand format in TensorBoard.
For regular models, we trace the model, inline the graph, and parse it, resulting in the visualization shown in the image attached to this task.
Having similar functionality for TorchScript models would be very valuable and would allow our tool to work for every kind of PyTorch model. Some potential ways to accomplish this would be through callstacks or scope-names, but we are open to new solutions as well.
cc @suo @gmagogsfm
|
triage review,oncall: jit,TSUsability,TSRootCause:PoorIRVisibility
|
low
|
Critical
|
651,893,747 |
flutter
|
Draggable's feedback cannot access InheritedWidgets because it doesn't share the same BuildContext as Draggable
|
Here is a code example of the problem:
https://dartpad.dev/9b23c8bdfbe53e41bbeba2f055f88eff
If you replace the line with `Text("blah")` with `DataMessage()` then `Draggable` works. The problem is a widget that uses a `InheritedWidget.dependOnInheritedWidgetOfExactType` will return null for the `feedback` case. Nowhere in the documentation says this should be the case.
I expected `InheritedWidget.dependOnInheritedWidgetOfExactType` to not return `null` as I thought it was part of the widget tree. Is this not the case?
|
framework,f: material design,has reproducible steps,a: null-safety,P2,found in release: 3.3,found in release: 3.7,team-design,triaged-design
|
low
|
Major
|
651,911,312 |
flutter
|
flutter video player udp protocol not working
|
I have a `udp` stream like this `udp://192.168.54.23:2500`
but `flutter video player` not accepting the `udp stream`. it only accepts `tcp stream`.
How do i play this `udp` video stream in player ?
__`flutter doctor -v output`__
```dart
[β] Flutter (Channel stable, v1.17.5, on Microsoft Windows [Version 10.0.18363.900], locale en-US)
β’ Flutter version 1.17.5 at C:\flutter
β’ Framework revision 8af6b2f038 (6 days ago), 2020-06-30 12:53:55 -0700
β’ Engine revision ee76268252
β’ Dart version 2.8.4
[β] Android toolchain - develop for Android devices (Android SDK version 29.0.3)
β’ Android SDK at C:\Users\premi\AppData\Local\Android\Sdk
β’ Platform android-29, build-tools 29.0.3
β’ ANDROID_HOME = C:\Users\premi\AppData\Local\Android\Sdk
β’ Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
β’ Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)
β’ All Android licenses accepted.
[β] Android Studio (version 4.0)
β’ Android Studio at C:\Program Files\Android\Android Studio
β’ Flutter plugin version 47.1.2
β’ Dart plugin version 193.7361
β’ Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)
[β] Connected device (1 available)
β’ E β’ G350RT058157000F β’ android-arm64 β’ Android 8.1.0 (API 27)
β’ No issues found!
```
|
c: new feature,p: video_player,package,team-ecosystem,P3,triaged-ecosystem
|
low
|
Major
|
651,932,129 |
TypeScript
|
tsserver should implement the Language Server Protocol
|
## Search Terms
language server protocol
## Suggestion
> As the language server protocol ( https://github.com/Microsoft/language-server-protocol ) is getting more and more popularity and clients ( https://github.com/Microsoft/language-server-protocol/wiki/Protocol-Implementations ), it would be very useful to have the tsserver implement this protocol.
This is a duplicate of issue #11274, which the OP closed because at that time, there existed two reasonable-looking LSP implementations for TypeScript.
But the times have changed. The Theia IDE now uses a VS Code extension for its TypeScript needs, and in the last eighteen months, Sourcegraph's server has received exactly one update by a sentient person.
There continue to be requests for LSP support within #11724 despite its Closed status. The OP has expressed no interest in revisiting the issue.
## Use Cases
It would be useful to programmers who use TypeScript but don't use VS Code.
## Checklist
My suggestion meets these guidelines:
* [x] This wouldn't be a breaking change in existing TypeScript/JavaScript code
* [x] This wouldn't change the runtime behavior of existing JavaScript code
* [x] This could be implemented without emitting different JS based on the types of the expressions
* [x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
* [x] This feature would agree with the rest of [TypeScript's Design Goals](https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals).
|
Suggestion,Committed,Domain: TSServer
|
high
|
Critical
|
651,991,269 |
youtube-dl
|
Request for option to prevent archiving of generic identifiers like "default, init, manifest, master"
|
<!--
######################################################################
WARNING!
IGNORING THE FOLLOWING TEMPLATE WILL RESULT IN ISSUE CLOSED AS INCOMPLETE
######################################################################
-->
## Checklist
<!--
Carefully read and work through this check list in order to prevent the most common mistakes and misuse of youtube-dl:
- First of, make sure you are using the latest version of youtube-dl. Run `youtube-dl --version` and ensure your version is 2020.06.16.1. If it's not, see https://yt-dl.org/update on how to update. Issues with outdated version will be REJECTED.
- Search the bugtracker for similar feature requests: http://yt-dl.org/search-issues. DO NOT post duplicates.
- Finally, put x into all relevant boxes (like this [x])
-->
- [x] I'm reporting a feature request
- [x] I've verified that I'm running youtube-dl version **2020.06.16.1**
- [x] I've searched the bugtracker for similar feature requests including closed ones
## Description
<!--
Provide an explanation of your issue in an arbitrary form. Please make sure the description is worded well enough to be understood, see https://github.com/ytdl-org/youtube-dl#is-the-description-of-the-issue-itself-sufficient. Provide any additional information, suggested solution and as much context and examples as possible.
-->
For those of us that use youtube-dl to download from sites that don't have extractors (and also use the `--download-archive`), we frequently hit situations were "generic master" or similar is archived. This makes recurring site or even different site downloads cumbersome because we frequently will have to edit the archive file to remove pseudo duplicates.
Personally, I see this as a default built-in ignore since ideally, only unique names should be added to the archive. Problematic archived generic names I've encountered:
generic default
generic master
generic init
generic manifest
Thank you for your consideration!
|
request
|
low
|
Critical
|
652,080,430 |
rust
|
Strange .cloned() error message mentioning iterators
|
I'm unsure why the error message for this code mentions iterators; there aren't any, I thought.
```rust
fn main() {
Some(1).cloned();
}
```
([Playground](https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=5de4c57cd625e8482d579c226cb0c74e))
Errors:
```
Compiling playground v0.0.1 (/playground)
error[E0599]: no method named `cloned` found for enum `std::option::Option<{integer}>` in the current scope
--> src/main.rs:2:13
|
2 | Some(1).cloned();
| ^^^^^^ method not found in `std::option::Option<{integer}>`
|
= note: the method `cloned` exists but the following trait bounds were not satisfied:
`std::option::Option<{integer}>: std::iter::Iterator`
which is required by `&mut std::option::Option<{integer}>: std::iter::Iterator`
error: aborting due to previous error
For more information about this error, try `rustc --explain E0599`.
error: could not compile `playground`.
To learn more, run the command again with --verbose.
```
|
C-enhancement,A-diagnostics,A-trait-system,T-compiler,D-confusing,D-papercut,D-newcomer-roadblock
|
low
|
Critical
|
652,111,511 |
PowerToys
|
Photoshop Documents (PSD, PSB, AI, etc) Preview on Explorer Add-ons
|
# Summary of the new feature/enhancement
Add support to preview of PSD too. Generally, this is a request to support more file types.
I want to be able to preview PSDs like a photo.
|
Help Wanted,Product-File Explorer
|
high
|
Critical
|
652,113,397 |
flutter
|
iOS archived version problem after releasing to TestFlight using XCode 11.4/11.5
|
<!-- Thank you for using Flutter!
If you are looking for support, please check out our documentation
or consider asking a question on Stack Overflow:
* https://flutter.dev/
* https://api.flutter.dev/
* https://stackoverflow.com/questions/tagged/flutter?sort=frequent
If you have found a bug or if our documentation doesn't have an answer
to what you're looking for, then fill our the template below. Please read
our guide to filing a bug first: https://flutter.dev/docs/resources/bug-reports
-->
## Steps to Reproduce
<!-- You must include full steps to reproduce so that we can reproduce the problem. -->
1. Install XCode 11.4 or 11.5.
2. Upload an iOS app using embedded Flutter module and calling native C++ code through dart::ffi to TestFlight.
3. Try showing the view which calls native library lookup method. <!-- describe how to reproduce the problem -->
**Expected results:** <!-- what did you want to see? -->
I have a native iOS app written in Objective-C which also uses some native C++ code. I've integrated a Flutter module into the app and used dart::ffi to call C++ within the Flutter module. Everything was working fine until I've update XCode to version 11.4. Now the native dart::ffi calls work only if I upload the app to the device using XCode, but they stop working when I archive the app, upload it to the AppStore and download it using TestFlight.
**Actual results:** <!-- what did you see? -->
<details>
<summary>Logs</summary>
<!--
Run your application with `flutter run --verbose` and attach all the
log output below between the lines with the backticks. If there is an
exception, please see if the error message includes enough information
to explain how to solve the issue.
-->
<!--
Run `flutter analyze` and attach any output of that command below.
If there are any analysis errors, try resolving them before filing this issue.
-->
<!-- Finally, paste the output of running `flutter doctor -v` here. -->
[β] Flutter (Channel stable, v1.17.5, on Mac OS X 10.15.5 19F101, locale pl-PL)
β’ Flutter version 1.17.5
β’ Framework revision 8af6b2f038 (7 days ago), 2020-06-30 12:53:55 -0700
β’ Engine revision ee76268252
β’ Dart version 2.8.4
[β] Xcode - develop for iOS and macOS (Xcode 11.5)
β’ Xcode at /Applications/Xcode.app/Contents/Developer
β’ Xcode 11.5, Build version 11E608c
β’ CocoaPods version 1.8.4
</details>
|
platform-ios,tool,P2,team-ios,triaged-ios
|
low
|
Critical
|
652,169,370 |
scrcpy
|
Build on ubuntu 20.04 failed
|
he Meson build system
```
Version: 0.53.2
Source dir: /home/kenneth/Projects/scrcpy
Build dir: /home/kenneth/Projects/scrcpy/build_test
Build type: native build
Project name: scrcpy
Project version: 1.14
Appending CFLAGS from environment: '-march=nocona -mtune=haswell -ftree-vectorize -fPIC -fstack-protector-strong -fno-plt -O2 -pipe'
Appending LDFLAGS from environment: ['-Wl,-O2', '-Wl,--sort-common', '-Wl,--as-needed', '-Wl,-z,relro', '-Wl,-z,now']
Appending CPPFLAGS from environment: '-DNDEBUG -D_FORTIFY_SOURCE=2 -O2'
Appending CFLAGS from environment: '-march=nocona -mtune=haswell -ftree-vectorize -fPIC -fstack-protector-strong -fno-plt -O2 -pipe'
Appending LDFLAGS from environment: ['-Wl,-O2', '-Wl,--sort-common', '-Wl,--as-needed', '-Wl,-z,relro', '-Wl,-z,now']
Appending CPPFLAGS from environment: '-DNDEBUG -D_FORTIFY_SOURCE=2 -O2'
C compiler for the host machine: /home/kenneth/anaconda3/bin/x86_64-conda_cos6-linux-gnu-cc (gcc 7.2.0 "x86_64-conda_cos6-linux-gnu-cc (crosstool-NG fa8859cb) 7.2.0")
C linker for the host machine: /home/kenneth/anaconda3/bin/x86_64-conda_cos6-linux-gnu-cc ld.bfd 2.28.1
Host machine cpu family: x86_64
Host machine cpu: x86_64
Found pkg-config: /usr/bin/pkg-config (0.29.1)
Run-time dependency libavformat found: YES 58.29.100
Run-time dependency libavcodec found: YES 58.54.100
Run-time dependency libavutil found: YES 56.31.100
Run-time dependency sdl2 found: YES 2.0.10
Configuring config.h using configuration
Program ./scripts/build-wrapper.sh found: YES (/home/kenneth/Projects/scrcpy/server/./scripts/build-wrapper.sh)
Build targets in project: 10
Found ninja-1.10.0 at /usr/bin/ninja
ninja: Entering directory `build_test'
[1/47] Compiling C object 'app/a172ced@@scrcpy@exe/src_controller.c.o'.
FAILED: app/a172ced@@scrcpy@exe/src_controller.c.o
/home/kenneth/anaconda3/bin/x86_64-conda_cos6-linux-gnu-cc -Iapp/a172ced@@scrcpy@exe -Iapp -I../app -I../app/src -I/usr/include/x86_64-linux-gnu -I/usr/include/SDL2 -fdiagnostics-color=always -fsanitize=address -fno-omit-frame-pointer -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -std=c11 -g -march=nocona -mtune=haswell -ftree-vectorize -fPIC -fstack-protector-strong -fno-plt -O2 -DNDEBUG -D_FORTIFY_SOURCE=2 -O2 -D_REENTRANT -MD -MQ 'app/a172ced@@scrcpy@exe/src_controller.c.o' -MF 'app/a172ced@@scrcpy@exe/src_controller.c.o.d' -o 'app/a172ced@@scrcpy@exe/src_controller.c.o' -c ../app/src/controller.c
In file included from ../app/src/controller.c:1:0:
../app/src/controller.h:5:10: fatal error: SDL2/SDL_mutex.h: No such file or directory
#include <SDL2/SDL_mutex.h>
^~~~~~~~~~~~~~~~~~
compilation terminated.
[2/47] Compiling C object 'app/a172ced@@scrcpy@exe/src_cli.c.o'.
FAILED: app/a172ced@@scrcpy@exe/src_cli.c.o
/home/kenneth/anaconda3/bin/x86_64-conda_cos6-linux-gnu-cc -Iapp/a172ced@@scrcpy@exe -Iapp -I../app -I../app/src -I/usr/include/x86_64-linux-gnu -I/usr/include/SDL2 -fdiagnostics-color=always -fsanitize=address -fno-omit-frame-pointer -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -std=c11 -g -march=nocona -mtune=haswell -ftree-vectorize -fPIC -fstack-protector-strong -fno-plt -O2 -DNDEBUG -D_FORTIFY_SOURCE=2 -O2 -D_REENTRANT -MD -MQ 'app/a172ced@@scrcpy@exe/src_cli.c.o' -MF 'app/a172ced@@scrcpy@exe/src_cli.c.o.d' -o 'app/a172ced@@scrcpy@exe/src_cli.c.o' -c ../app/src/cli.c
In file included from /home/kenneth/anaconda3/x86_64-conda_cos6-linux-gnu/sysroot/usr/include/features.h:356:0,
from /home/kenneth/anaconda3/x86_64-conda_cos6-linux-gnu/sysroot/usr/include/stdint.h:26,
from /home/kenneth/anaconda3/lib/gcc/x86_64-conda_cos6-linux-gnu/7.2.0/include/stdint.h:9,
from ../app/src/scrcpy.h:5,
from ../app/src/cli.h:7,
from ../app/src/cli.c:1:
/usr/include/x86_64-linux-gnu/sys/cdefs.h:492:49: error: missing binary operator before token "("
#if __GNUC_PREREQ (4,8) || __glibc_clang_prereq (3,5)
^
In file included from ../app/src/input_manager.h:8:0,
from ../app/src/scrcpy.h:9,
from ../app/src/cli.h:7,
from ../app/src/cli.c:1:
../app/src/controller.h:5:10: fatal error: SDL2/SDL_mutex.h: No such file or directory
#include <SDL2/SDL_mutex.h>
^~~~~~~~~~~~~~~~~~
compilation terminated.
[3/47] Compiling C object 'app/a172ced@@scrcpy@exe/src_main.c.o'.
FAILED: app/a172ced@@scrcpy@exe/src_main.c.o
/home/kenneth/anaconda3/bin/x86_64-conda_cos6-linux-gnu-cc -Iapp/a172ced@@scrcpy@exe -Iapp -I../app -I../app/src -I/usr/include/x86_64-linux-gnu -I/usr/include/SDL2 -fdiagnostics-color=always -fsanitize=address -fno-omit-frame-pointer -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -std=c11 -g -march=nocona -mtune=haswell -ftree-vectorize -fPIC -fstack-protector-strong -fno-plt -O2 -DNDEBUG -D_FORTIFY_SOURCE=2 -O2 -D_REENTRANT -MD -MQ 'app/a172ced@@scrcpy@exe/src_main.c.o' -MF 'app/a172ced@@scrcpy@exe/src_main.c.o.d' -o 'app/a172ced@@scrcpy@exe/src_main.c.o' -c ../app/src/main.c
In file included from /home/kenneth/anaconda3/x86_64-conda_cos6-linux-gnu/sysroot/usr/include/features.h:356:0,
from /home/kenneth/anaconda3/x86_64-conda_cos6-linux-gnu/sysroot/usr/include/stdint.h:26,
from /home/kenneth/anaconda3/lib/gcc/x86_64-conda_cos6-linux-gnu/7.2.0/include/stdint.h:9,
from ../app/src/scrcpy.h:5,
from ../app/src/main.c:1:
/usr/include/x86_64-linux-gnu/sys/cdefs.h:492:49: error: missing binary operator before token "("
#if __GNUC_PREREQ (4,8) || __glibc_clang_prereq (3,5)
```
|
build
|
low
|
Critical
|
652,271,959 |
pytorch
|
Cannot define v_dim in MultiheadAttention
|
## π Bug
I am trying to define the dimensions of features of the values in the multiheaded attention operation. However, when I set this value it raises an AssertionError.
## To Reproduce
```
emb_dim = 10
num_heads = 1
v_dim = 4
multihead_attn = nn.MultiheadAttention(emb_dim, num_heads=num_heads, vdim=v_dim)
query = torch.rand(10, 2, emb_dim)
key = torch.rand(10, 2, emb_dim)
values = torch.rand(10, 2, emb_dim)
multihead_attn(query, key, values)
```
This raises the AssertionError
```
v_proj_weight_non_opt = torch.jit._unwrap_optional(v_proj_weight)
len1, len2 = v_proj_weight_non_opt.size()
assert len1 == embed_dim and len2 == value.size(-1)
```
## Expected behavior
I would expect this to run without raising any issues, as defining the dimensionality of features in the values should be a valid operation.
## Environment
- PyTorch Version (e.g., 1.0): 1.5.1
- OS (e.g., Linux): macOS Mojave
- How you installed PyTorch (`conda`, `pip`, source): conda
- Build command you used (if compiling from source): -
- Python version: 3.7.7
- CUDA/cuDNN version: -
- GPU models and configuration: -
- Any other relevant information: -
## Additional context
Perhaps this is not a bug and I am misinterpreting something, but in this case the error messaged could better defined.
cc @albanD @mruberry
|
module: nn,triaged
|
low
|
Critical
|
652,276,000 |
react-native
|
useWindowDimensions() returns swapped height and width in iOS
|
## Description
When tested with iPad simulator, the `useWindowDimensions(...)` hook returns incorrect width and height.
## React Native version:
Run `react-native info` in your terminal and copy the results here.
```bash
info Fetching system and libraries information...
System:
OS: macOS 10.15.5
CPU: (4) x64 Intel(R) Core(TM) i5-4278U CPU @ 2.60GHz
Memory: 24.79 MB / 8.00 GB
Shell: 5.7.1 - /bin/zsh
Binaries:
Node: 12.18.0 - /var/folders/k_/twn4fnrn6g56kn0xjlkp3zx00000gn/T/yarn--1594122179123-0.9086048405049534/node
Yarn: 1.22.4 - /var/folders/k_/twn4fnrn6g56kn0xjlkp3zx00000gn/T/yarn--1594122179123-0.9086048405049534/yarn
npm: 6.14.5 - /usr/local/bin/npm
Watchman: Not Found
Managers:
CocoaPods: 1.9.3 - /usr/local/bin/pod
SDKs:
iOS SDK:
Platforms: iOS 13.5, DriverKit 19.0, macOS 10.15, tvOS 13.4, watchOS 6.2
Android SDK:
API Levels: 23, 26, 28, 29
Build Tools: 27.0.3, 28.0.3, 29.0.2, 30.0.0
System Images: android-29 | Google Play Intel x86 Atom
Android NDK: Not Found
IDEs:
Android Studio: 4.0 AI-193.6911.18.40.6514223
Xcode: 11.5/11E608c - /usr/bin/xcodebuild
Languages:
Java: 1.8.0_242-release - /usr/bin/javac
Python: 2.7.16 - /usr/bin/python
npmPackages:
@react-native-community/cli: Not Found
react: 16.11.0 => 16.11.0
react-native: ^0.62.2 => 0.62.2
npmGlobalPackages:
*react-native*: Not Found
β¨ Done in 11.68s.
```
## Steps To Reproduce
Provide a detailed list of steps that reproduce the issue.
1. Use `react-native init` to create a new project.
2. Edit `App.js` with the following code
```jsx
import React from "react";
import { Text, View, useWindowDimensions } from "react-native";
export const App = () => {
const { width, height } = useWindowDimensions();
return (
<View
style={{
width: "100%",
height: "100%",
alignItems: "center",
justifyContent: "center",
}}
>
<Text>{width > height ? "landscape" : "portrait"}</Text>
<Text>{`width: ${width}, height: ${height}`}</Text>
</View>
);
};
```
## Expected Results
1. At the first time I rotate the simulator to *landscape*, it should display `"landscape"` instead of nothing happens.
2. At the second time the simulator rotates back to portrait position, it should render `"portrait"` on the screen.
3. At the second time I rotate from portrait to landscape, it should display `"landscape"` instead of `"portrait"`.
## Snack, code example, screenshot, or link to a repository:
It is not easy to show device orientation features in snack, I'll attach screen recordings below.
You may download the original video to pause for the rendered text.
[Screen Recording 2020-07-07 at 7.39.07 PM.zip](https://github.com/facebook/react-native/files/4884736/Screen.Recording.2020-07-07.at.7.39.07.PM.zip)
|
Platform: iOS,API: Dimensions,Never gets stale
|
medium
|
Critical
|
652,342,409 |
flutter
|
Camera retuning this error Error waiting to drain: Connection timed out (-110))
|
I am using the camera plugin version [camera: ^0.5.8+2] and one of our app users Is getting this error.
```
CameraException(CameraAccess, CAMERA_ERROR (3): waitUntilIdle:1656: Camera 1: Error waiting to drain: Connection timed out (-110))
```
Model details are as follows:
{"model":"SM-J720F","platform":"Android",,"version":"10167","manufacturer":"samsung","serial":"unknown",}
Please help. Regarding this, I am getting this error almost every day.
|
e: device-specific,platform-android,p: camera,package,P2,team-android,triaged-android
|
low
|
Critical
|
652,358,009 |
terminal
|
Allow the user to set the minimum window size
|
<!--
π¨π¨π¨π¨π¨π¨π¨π¨π¨π¨
I ACKNOWLEDGE THE FOLLOWING BEFORE PROCEEDING:
1. If I delete this entire template and go my own path, the core team may close my issue without further explanation or engagement.
2. If I list multiple bugs/concerns in this one issue, the core team may close my issue without further explanation or engagement.
3. If I write an issue that has many duplicates, the core team may close my issue without further explanation or engagement (and without necessarily spending time to find the exact duplicate ID number).
4. If I leave the title incomplete when filing the issue, the core team may close my issue without further explanation or engagement.
5. If I file something completely blank in the body, the core team may close my issue without further explanation or engagement.
All good? Then proceed!
-->
# Description of the new feature/enhancement
Create an option "disable window resizing" or "fixed minimum window size" in global settings.
<!--
A clear and concise description of what the problem is that the new feature would solve.
Describe why and how a user would use this new functionality (if applicable).
-->
# Proposed technical implementation details (optional)
Window Resizing Settings
Property name: enableWindowResizing
Necessity: Optional
Accepts: true, false
Default value: true
_________________________ OR __________________________________
Fixed Minimum Window Size
Property name: minimumWindowSize
Necessity: Optional
Accepts: Dimensions - rows,columns
Default value: 30,120
<!--
A clear and concise description of what you want to happen.
-->
|
Help Wanted,Area-Settings,Product-Terminal,Issue-Task,Priority-3,good first issue
|
medium
|
Critical
|
652,390,398 |
go
|
runtime: deprecate SetCPUProfileRate and replace body with panic
|
Long ago we had runtime.SetCPUProfileRate and runtime.CPUProfile as the interface to profiling. And runtime/pprof was layered on top of them. At some point we realized that this was not a good enough interface, and we made the runtime export hooks directly to runtime/pprof.
We marked CPUProfile deprecated and replaced the body with a panic.
But we forgot to do the same to SetCPUProfileRate. The result is that today this function is documented as if it is useful, when in fact it is not. We should mark it deprecated and replace the body with a panic, same as CPUProfile, leaving a back-door hook for runtime/pprof.
|
NeedsFix,compiler/runtime
|
low
|
Major
|
652,404,248 |
go
|
x/pkgsite: add function to set up frontend server
|
There are several places in the code where we set up a `frontend.NewServer`:
- `cmd/frontend`: https://github.com/golang/pkgsite/blob/master/cmd/frontend/main.go#L94-L123
- `internal/frontend/server_test.go`: https://github.com/golang/pkgsite/blob/master/internal/frontend/server_test.go#L990-L1031
- `internal/testing/integration/frontend_test.go`: https://github.com/golang/pkgsite/blob/master/internal/testing/integration/frontend_test.go#L155-L167
It would be useful to factor out shared parts of this code to reduce duplication.
|
NeedsFix,pkgsite
|
low
|
Minor
|
652,443,991 |
java-design-patterns
|
View Helper pattern
|
Description:
The View Helper design pattern aims to separate the business logic from the presentation layer by using helper components to handle processing and formatting. This enhances the maintainability and modularity of the code by promoting a clear separation of concerns.
Main Elements of the Pattern:
- **View Helper**: A component that performs complex formatting or data processing tasks.
- **Controller**: Directs the request to the appropriate View Helper and subsequently to the view.
- **View**: Renders the final output using data prepared by the View Helper.
References:
1. [View Helper Design Pattern - Oracle](https://www.oracle.com/java/technologies/viewhelper.html)
2. [Java Design Patterns - Project Contribution Guidelines](https://github.com/iluwatar/java-design-patterns/wiki)
Acceptance Criteria:
1. Create a View Helper class that handles data formatting or processing tasks.
2. Ensure the Controller directs requests to the appropriate View Helper.
3. Implement a view that utilizes the data provided by the View Helper to render the final output.
|
epic: pattern,type: feature
|
low
|
Major
|
652,447,752 |
java-design-patterns
|
Asynchronous Page pattern
|
**Description:**
The Asynchronous Page Design Pattern allows for the decoupling of long-running tasks from the main flow of a web page, providing a more responsive and interactive user experience. This pattern is particularly useful for web applications where certain operations, like data retrieval or processing, can take a significant amount of time and would otherwise block the user interface.
Main elements of the pattern:
- **Client-Side Asynchronous Call:** Initiate an asynchronous request from the client side using JavaScript (AJAX, Fetch API, etc.).
- **Server-Side Processing:** Handle the asynchronous request on the server side, processing the task in a non-blocking manner.
- **Polling or Callback Mechanism:** Update the client with the status of the request, either through polling, long-polling, or server-sent events.
- **User Feedback:** Provide immediate feedback to the user, indicating that the request is being processed, and update the UI once the processing is complete.
**References:**
1. [Java Design Patterns - Contribution Guidelines](https://github.com/iluwatar/java-design-patterns/wiki)
2. [Asynchronous Page Design Pattern - Google Books](https://books.google.fi/books?id=x-7_W0P9KGsC&printsec=frontcover&hl=fi&source=gbs_ge_summary_r&cad=0#v=onepage&q&f=false)
**Acceptance Criteria:**
1. Implement a client-side example demonstrating the initiation of an asynchronous request and handling the response.
2. Develop a server-side component that processes the asynchronous request in a non-blocking manner and communicates the status back to the client.
3. Provide clear documentation and usage instructions, including code comments and a README file explaining how to run and test the implementation.
|
info: help wanted,epic: pattern,type: feature
|
low
|
Minor
|
652,448,695 |
java-design-patterns
|
Caching Filter pattern
|
**Description:**
The Caching Filter design pattern aims to improve the performance and scalability of an application by caching the results of expensive operations and reusing them for identical subsequent requests. This pattern is particularly useful in scenarios where the same data is frequently requested, and the cost of recomputing the data is high.
**Main Elements of the Pattern:**
1. **Filter:** Intercepts requests and checks if a cached response is available.
2. **Cache Store:** A storage mechanism for saving and retrieving cached data.
3. **Cache Key:** A unique identifier for caching entries based on request parameters.
4. **Expiration Policy:** Defines how long cached data is considered valid.
5. **Cache Miss Handler:** Fetches data from the original source when a cache miss occurs and populates the cache.
**References:**
- [Java Design Patterns Project Wiki](https://github.com/iluwatar/java-design-patterns/wiki)
- [J2EE Design Patterns](https://books.google.fi/books?id=x-7_W0P9KGsC&printsec=frontcover&hl=fi&source=gbs_ge_summary_r&cad=0#v=onepage&q&f=false)
**Acceptance Criteria:**
1. Implement a basic Caching Filter that can intercept requests and check for cached responses.
2. Develop a simple cache store with a configurable expiration policy.
3. Ensure comprehensive unit tests are provided to validate the correct functionality of the caching mechanism.
|
info: help wanted,epic: pattern,type: feature
|
low
|
Major
|
652,453,335 |
java-design-patterns
|
Data Transfer Hash pattern
|
**Description:**
The Data Transfer Hash design pattern is used to transfer a large amount of data between different parts of a system or across systems. This pattern uses a hash map to store data as key-value pairs, which facilitates easy data retrieval and manipulation. The primary elements of this pattern include:
- **Data Container:** A hash map or dictionary to store the data.
- **Serialization/Deserialization:** Methods to convert data to and from the hash map format.
- **Encapsulation:** Ensuring that the data structure hides its implementation details and exposes only necessary interfaces for interaction.
- **Efficiency:** Optimization for quick data access and manipulation.
**References:**
1. Data Transfer Hash Design Pattern - [Link to Book](https://books.google.fi/books?id=x-7_W0P9KGsC&printsec=frontcover&hl=fi&source=gbs_ge_summary_r&cad=0#v=onepage&q&f=false)
2. Project Contribution Guidelines - [Github Wiki](https://github.com/iluwatar/java-design-patterns/wiki)
**Acceptance Criteria:**
1. Implement a hash map-based data container with appropriate methods for adding, retrieving, and removing data.
2. Include serialization and deserialization methods for converting the data container to and from a transferable format.
3. Ensure the implementation adheres to the project's coding standards and passes all existing unit tests.
|
epic: pattern,type: feature
|
low
|
Major
|
652,454,991 |
java-design-patterns
|
DAO Factory pattern
|
**Description:**
The DAO (Data Access Object) Factory design pattern is used to abstract and encapsulate all access to the data source, providing a clean separation between the business logic and the data access logic. This pattern enables the application to switch between different data sources and provides a mechanism to manage the data access objects efficiently.
Main elements of the pattern:
- **DAO Interface:** Defines the standard operations to be performed on a model object(s).
- **Concrete DAO Class:** Implements the DAO interface and handles the CRUD operations with the data source.
- **DAO Factory Interface:** Provides a way to get the appropriate DAO based on the data source.
- **Concrete DAO Factory Class:** Implements the DAO Factory interface and returns instances of the specific DAO.
**References:**
1. [DAO Factory Design Pattern - Oracle](https://www.oracle.com/java/technologies/dataaccessobject.html)
2. [Java Design Patterns - DAO](https://github.com/iluwatar/java-design-patterns/wiki)
**Acceptance Criteria:**
1. Implement the DAO interface and at least one concrete DAO class for a model object.
2. Create a DAO Factory interface and a concrete implementation of the DAO Factory that returns instances of the concrete DAO.
3. Ensure that the implementation is well-documented and includes unit tests for the DAO methods and factory.
|
info: help wanted,epic: pattern,type: feature
|
medium
|
Major
|
652,457,671 |
java-design-patterns
|
Procedure Access Object pattern
|
### Description:
Implement the Procedure Access Object (PAO) design pattern in the project. The PAO pattern centralizes the logic to access stored procedures in the database, providing a uniform interface for executing these procedures. This helps in decoupling the business logic from the data access logic, promoting a cleaner and more modular design.
### Main elements of the Procedure Access Object pattern:
- **Centralized Procedure Access**: All stored procedure calls are centralized in a single class or a set of classes.
- **Uniform Interface**: Provides a consistent interface for executing stored procedures, making it easier to manage and call these procedures from different parts of the application.
- **Decoupling**: Separates the business logic from the data access logic, ensuring a more modular and maintainable codebase.
### References:
- [Procedure Access Object Design Pattern](https://www.oreilly.com/library/view/j2ee-design-patterns/0596004273/re19.html)
- [Project Contribution Guidelines](https://github.com/iluwatar/java-design-patterns/wiki)
### Acceptance Criteria:
1. Implement a class or set of classes to centralize stored procedure calls, ensuring they follow the PAO pattern.
2. Provide a consistent and uniform interface for executing stored procedures.
3. Ensure the new PAO classes are well-documented and include examples demonstrating their use in the project.
|
info: help wanted,epic: pattern,type: feature
|
low
|
Minor
|
652,458,236 |
java-design-patterns
|
PK Block Generator pattern
|
## Description
The PK Block Generator design pattern is a structural pattern that allows for efficient and modular generation of blocks of code or data. This pattern is particularly useful in scenarios where blocks of data need to be generated dynamically based on varying input parameters. The main elements of the PK Block Generator design pattern include:
1. **Generator Interface**: Defines the interface for creating blocks.
2. **Concrete Generator**: Implements the generator interface to create specific types of blocks.
3. **Block Class**: Represents the blocks that are generated.
4. **Client**: Uses the generator to create blocks as needed.
## References
1. [PK Block Generator Design Pattern - Google Books](https://books.google.fi/books?id=x-7_W0P9KGsC&printsec=frontcover&hl=fi&source=gbs_ge_summary_r&cad=0#v=onepage&q&f=false)
2. [Java Design Patterns - Contribution Guidelines](https://github.com/iluwatar/java-design-patterns/wiki)
## Acceptance Criteria
1. **Implementation of Generator Interface**: Develop a generator interface that defines methods for block creation.
2. **Creation of Concrete Generators**: Implement at least one concrete generator that creates a specific type of block.
3. **Client Integration**: Demonstrate the use of the generator in a client class, ensuring that blocks are generated dynamically based on input parameters.
|
info: help wanted,epic: pattern,type: feature
|
low
|
Minor
|
652,459,096 |
java-design-patterns
|
Stored Procedures for Primary Keys pattern
|
**Description:**
Implement the Stored Procedures for Primary Keys design pattern. This pattern centralizes the creation of primary key values in a database through stored procedures. The primary objective is to ensure unique and sequential key generation across different parts of an application. By utilizing stored procedures, this pattern enhances consistency, simplifies key management, and can improve performance by reducing the logic required in the application layer for key generation.
**Main Elements:**
1. **Centralized Key Generation**: Use stored procedures to generate primary key values, ensuring uniqueness and sequential order.
2. **Database Consistency**: Maintain consistent key generation across different application modules.
3. **Simplified Application Logic**: Offload key generation logic from the application layer to the database.
4. **Performance Optimization**: Reduce the overhead of key generation logic in the application, potentially improving overall performance.
**References:**
- [Project Contribution Guidelines](https://github.com/iluwatar/java-design-patterns/wiki)
- [Stored Procedures for Primary Keys Design Pattern - Source](https://books.google.fi/books?id=x-7_W0P9KGsC&printsec=frontcover&hl=fi&source=gbs_ge_summary_r&cad=0#v=onepage&q&f=false)
**Acceptance Criteria:**
1. A stored procedure is created in the database to handle the generation of primary keys.
2. The application layer is modified to call the stored procedure for primary key generation instead of generating keys within the application code.
3. Comprehensive tests are implemented to ensure that the stored procedure generates unique and sequential primary key values and that the integration with the application is seamless.
|
info: help wanted,epic: pattern,type: feature
|
low
|
Major
|
652,461,269 |
java-design-patterns
|
Tuple Table pattern
|
**Description:**
The Tuple Table design pattern is a structural pattern that provides a flexible way to manage complex data structures. It is used to store and manipulate a collection of tuples (fixed-size collections of elements) in a tabular format. This pattern is particularly useful when dealing with databases or any system that requires the efficient handling of structured data.
**Main elements of the Tuple Table pattern:**
1. **Tuple:** A finite ordered list of elements.
2. **Table:** A collection of tuples organized in rows and columns, similar to a database table.
3. **Schema:** Defines the structure of the tuples within the table, specifying the types and order of elements.
4. **Operations:** Functions to add, remove, update, and query tuples within the table.
5. **Flexibility:** Ability to handle different types of data within the same table by defining appropriate schemas.
**References:**
1. Tuple Table pattern overview: [Google Books Reference](https://books.google.fi/books?id=x-7_W0P9KGsC&printsec=frontcover&hl=fi&source=gbs_ge_summary_r&cad=0#v=onepage&q&f=false)
2. Project contribution guidelines: [GitHub Contribution Guidelines](https://github.com/iluwatar/java-design-patterns/wiki)
**Acceptance Criteria:**
1. Implement the Tuple Table pattern with a clear definition of tuples, table, and schema.
2. Provide basic operations for managing tuples within the table, including addition, removal, update, and querying of tuples.
3. Ensure comprehensive unit tests are included to verify the correct implementation of the pattern.
|
info: help wanted,epic: pattern,type: feature
|
low
|
Minor
|
652,468,132 |
java-design-patterns
|
Service Adapter pattern
|
### Description:
The Service Adapter design pattern aims to provide a bridge between different interfaces, enabling them to work together seamlessly. This pattern involves creating an adapter class that translates one interface for a class into an interface compatible with another class. The key elements of the pattern include:
1. **Client:** The class that requires the target interface.
2. **Target Interface:** The interface needed by the client.
3. **Service Interface:** The existing interface provided by the service.
4. **Adapter:** The class that implements the target interface and translates the requests from the client into calls to the service interface.
This pattern is particularly useful in scenarios where there is a need to integrate with third-party services or legacy systems with incompatible interfaces.
### References:
- [J2EE Design Patterns](https://books.google.fi/books?id=x-7_W0P9KGsC&printsec=frontcover&hl=fi&source=gbs_ge_summary_r&cad=0#v=onepage&q&f=false)
- [Project Contribution Guidelines](https://github.com/iluwatar/java-design-patterns/wiki)
Acceptance Criteria:
1. An adapter class that implements the target interface and translates client requests to the service interface.
2. Unit tests demonstrating the correct functionality of the adapter, ensuring it properly translates and forwards requests.
3. Comprehensive documentation explaining the implemented design pattern, including class diagrams and usage examples.
|
epic: pattern,type: feature
|
low
|
Minor
|
652,470,794 |
java-design-patterns
|
Transactional Context pattern
|
### Description
Implement the Transactional Context design pattern which ensures that a set of operations are executed within a transaction context, maintaining atomicity, consistency, isolation, and durability (ACID properties). This pattern is essential for managing transactions in complex systems, providing a mechanism to rollback in case of failures, and ensuring that data remains consistent.
Main elements of the pattern include:
- **Transaction**: Represents the transaction boundary, containing operations to commit or rollback changes.
- **Transactional Context**: Maintains the state of the transaction, coordinating the operations and ensuring that they adhere to ACID properties.
- **Transaction Manager**: Manages the lifecycle of transactions, including beginning, committing, and rolling back transactions.
- **Operations**: The individual operations that need to be executed within the transaction context.
### References
- [Java Design Patterns Project Contribution Guidelines](https://github.com/iluwatar/java-design-patterns/wiki)
- [Transactional Context Design Pattern](https://books.google.fi/books?id=x-7_W0P9KGsC&printsec=frontcover&hl=fi&source=gbs_ge_summary_r&cad=0#v=onepage&q&f=false)
### Acceptance Criteria
1. Implement classes for Transaction, Transactional Context, Transaction Manager, and Operations as described in the pattern.
2. Ensure that the implementation adheres to the ACID properties.
3. Provide unit tests demonstrating the correct behavior of the transactional context, including scenarios for commit and rollback.
|
epic: pattern,type: feature
|
low
|
Critical
|
652,473,107 |
java-design-patterns
|
Lock Manager pattern
|
**Description:**
The Lock Manager design pattern is a concurrency control mechanism used to manage access to shared resources in a multi-threaded environment. This pattern ensures that multiple processes or threads do not simultaneously access a shared resource in a way that causes conflicts. The key elements of the Lock Manager design pattern include:
1. **Lock Management:** Centralized control for acquiring and releasing locks on resources.
2. **Lock Types:** Different types of locks, such as read and write locks, to manage varying levels of access control.
3. **Deadlock Detection and Resolution:** Mechanisms to detect and handle deadlocks.
4. **Lock Granularity:** Ability to define locks at different levels of granularity, such as fine-grained or coarse-grained locks.
**References:**
- [Lock Manager Design Pattern - Google Books](https://books.google.fi/books?id=x-7_W0P9KGsC&printsec=frontcover&hl=fi&source=gbs_ge_summary_r&cad=0#v=onepage&q&f=false)
- [Project Contribution Guidelines](https://github.com/iluwatar/java-design-patterns/wiki)
**Acceptance Criteria:**
1. Implement a Lock Manager class that supports acquiring and releasing locks with read and write permissions.
2. Integrate deadlock detection and resolution within the Lock Manager.
3. Provide unit tests demonstrating the correct functionality of the Lock Manager, including scenarios for deadlock detection and handling.
|
info: help wanted,epic: pattern,type: feature
|
low
|
Major
|
652,483,468 |
go
|
crypto/x509: check the Key Usage extension
|
We currently ignore the Key Usage extension because some old roots had gotten it wrong. Things probably improved by now and we can take a stab at following the spec again. AFAIK other verifiers do check them.
|
NeedsFix
|
low
|
Major
|
652,490,519 |
java-design-patterns
|
Coarse-Grained Lock pattern
|
## Description
The Coarse-Grained Lock design pattern is a concurrency control strategy where a single lock is used to protect a large portion of code or multiple related resources. This approach simplifies lock management by reducing the number of locks needed and minimizing the potential for deadlocks. However, it can reduce concurrency as the coarse-grained lock may force threads to wait even when they could safely proceed.
### Main Elements of the Pattern:
- **Single Lock Mechanism**: One lock protects a large code segment or multiple resources.
- **Simplicity**: Easier to implement and manage compared to fine-grained locks.
- **Reduced Concurrency**: May lead to lower parallelism as threads may be unnecessarily blocked.
### Implementation Steps:
1. Identify the critical section or related resources that require protection.
2. Implement a single lock to guard the entire critical section or group of resources.
3. Ensure that the lock is acquired at the beginning and released at the end of the critical section.
## References
- [Coarse-Grained Lock](https://martinfowler.com/eaaCatalog/coarseGrainedLock.html)
- [Java Design Patterns - Contribution Guidelines](https://github.com/iluwatar/java-design-patterns/wiki)
- [Youtube](https://www.youtube.com/watch?v=-35OPiQwd8k)
## Acceptance Criteria
1. Implement a Coarse-Grained Lock in a chosen example within the project.
2. Ensure the implementation follows the contribution guidelines provided in the project repository.
3. Include comprehensive unit tests demonstrating the effectiveness and correctness of the Coarse-Grained Lock implementation.
|
epic: pattern,type: feature
|
low
|
Minor
|
652,495,267 |
java-design-patterns
|
Database Session State pattern
|
### Description:
The Database Session State design pattern is used to manage user session data by storing it in a relational database. This pattern is particularly useful for maintaining session state across multiple servers in a web farm or distributed system, ensuring consistency and reliability.
### Main Elements of the Pattern:
- **Session Data Storage**: Store user session data in a relational database.
- **Session Identifier**: Use a unique session identifier to fetch and update session data.
- **Database Operations**: Implement CRUD operations to manage session data.
- **Session Expiry**: Handle session expiration and cleanup of stale data.
- **Concurrency Handling**: Ensure thread-safe operations and handle concurrent access to session data.
### References:
1. [Martin Fowler - Database Session State](https://martinfowler.com/eaaCatalog/databaseSessionState.html)
2. [YouTube Video on Database Session State](https://www.youtube.com/watch?v=nXBNY7GK--A)
3. [Java Design Patterns - Contribution Guidelines](https://github.com/iluwatar/java-design-patterns/wiki)
### Acceptance Criteria:
1. Implement a robust solution for storing and retrieving session data from a relational database.
2. Ensure proper handling of session identifiers, session expiration, and cleanup mechanisms.
3. Provide comprehensive documentation and examples demonstrating the usage of the Database Session State pattern in the project.
|
epic: pattern,type: feature
|
low
|
Minor
|
652,495,755 |
java-design-patterns
|
Dependent Mapping pattern
|
**Description:**
The Dependent Mapping design pattern is used to handle situations where the mapping of one object depends on the mapping of another object. This pattern is particularly useful in scenarios where there are complex relationships between objects and their corresponding database tables. It ensures that dependent objects are mapped correctly and consistently, maintaining the integrity of the data and the relationships between the objects.
Key elements of the Dependent Mapping design pattern include:
1. **Dependent Mapper:** This component is responsible for mapping the dependent objects. It coordinates with the main mapper to ensure that dependent objects are correctly mapped and persisted.
2. **Main Mapper:** The primary mapper that interacts with the database. It delegates the mapping of dependent objects to the dependent mapper.
3. **Relationship Handling:** Proper handling of relationships between the main object and its dependent objects to ensure data integrity and consistency.
4. **Transaction Management:** Ensuring that operations involving dependent objects are part of the same transaction to maintain atomicity.
**References:**
- [Martin Fowler's Dependent Mapping](https://martinfowler.com/eaaCatalog/dependentMapping.html)
- [Source Code Examples on Dependent Mapping Pattern](https://www.sourcecodeexamples.net/2018/05/dependent-mapping-pattern.html)
- [Project Contribution Guidelines](https://github.com/iluwatar/java-design-patterns/wiki)
**Acceptance Criteria:**
1. Implement the Dependent Mapper and Main Mapper classes that demonstrate the mapping and persistence of dependent objects.
2. Ensure that the relationship between the main object and dependent objects is correctly handled, with appropriate unit tests to verify the integrity and consistency of the data.
3. Include comprehensive documentation and examples within the codebase to illustrate the usage and benefits of the Dependent Mapping design pattern.
|
info: help wanted,epic: pattern,type: feature
|
low
|
Major
|
652,496,538 |
vscode
|
Hover widget should restrict height when it's too large
|
Context: https://github.com/microsoft/vscode/issues/97496#issuecomment-652651297
|
bug,help wanted,workbench-hover
|
low
|
Minor
|
652,498,689 |
java-design-patterns
|
Foreign Key Mapping pattern
|
**Description:**
The Foreign Key Mapping design pattern is used to maintain relationships between tables in a relational database by using foreign keys. This pattern helps in establishing and enforcing referential integrity between related entities. The implementation of this pattern typically involves:
1. Adding foreign key columns in the child table that reference primary keys in the parent table.
2. Ensuring the foreign key constraints are properly defined and maintained.
3. Managing the relationships and ensuring the consistency of data through CRUD operations.
This pattern is essential for ensuring data integrity and facilitating efficient data retrieval in relational database systems.
**References:**
- [Martin Fowler: Foreign Key Mapping](https://martinfowler.com/eaaCatalog/foreignKeyMapping.html)
- [Source Code Examples: Foreign Key Mapping Pattern](https://www.sourcecodeexamples.net/2018/05/foreign-key-mapping-pattern.html)
**Acceptance Criteria:**
1. A new implementation of the Foreign Key Mapping pattern is added to the project, including appropriate classes and database schema.
2. Unit tests are written to cover all CRUD operations, ensuring that referential integrity is maintained.
3. Documentation is updated to explain the Foreign Key Mapping pattern, including code examples and usage guidelines.
|
epic: pattern,type: feature
|
low
|
Major
|
652,500,087 |
java-design-patterns
|
Identity Field pattern
|
### Description
The Identity Field design pattern ensures that each object in a system has a unique identifier, which can be used to track the object independently of its database representation. This pattern is particularly useful in systems where objects need to be reconstituted from a persistent storage medium, ensuring that each object retains its unique identity across different sessions and operations.
**Main Elements of the Pattern:**
1. **Unique Identifier:** Each object is assigned a unique identifier, typically a primary key in the database.
2. **Field Mapping:** The identifier field in the object corresponds to a unique column in the database table.
3. **Object Persistence:** Ensures that the unique identifier is consistently used when saving and retrieving objects from the database.
### References
- [Martin Fowler's Identity Field](https://martinfowler.com/eaaCatalog/identityField.html)
- [Source Code Examples - Identity Field Pattern](https://www.sourcecodeexamples.net/2018/05/identity-field-pattern.html)
- [Project Contribution Guidelines](https://github.com/iluwatar/java-design-patterns/wiki)
### Acceptance Criteria
1. **Unique Identifier Implementation:** Each domain object must have a unique identifier field that maps to the primary key in the database.
2. **Persistence Mechanism:** Implement a mechanism to ensure that objects are saved and retrieved using their unique identifiers, maintaining consistent identity across sessions.
3. **Unit Tests:** Provide comprehensive unit tests to validate the correct assignment, persistence, and retrieval of the unique identifiers for domain objects.
|
epic: pattern,type: feature
|
medium
|
Major
|
652,500,799 |
svelte
|
Restriction of one top level style block causing issues
|
**Is your feature request related to a problem? Please describe.**
I've created a tool which preprocesses HTML and scans class names for functional CSS. This CSS is then translated into styles using CSS variables which are inserted into the HTML using style blocks. A unique class name is also added to the element so the styles are tied to the element.
This is problematic in Svelte however, because it requires there to be only one style block. I'm aware there have been some discussions on this before but I can't remember what the outcome was and if it's intended to only support one top-level style block.
**Describe the solution you'd like**
Ideally, I think you should be able to use more than one style block. This is what native HTML supports and I would expect to be able to drop a style block anywhere and for it to still work. I think in this case, the error handling is doing more harm than good. In the case of this preprocessor, there isn't any need for Svelte to be able to support the style blocks it adds, other than just passing it to the browser. This error is intended to make Svelte users aware that only the top-level style block will be supported but then denies the ability to process the file because more than one style block exists in the source code.
Alternatively, an easier way to solve this using a preprocessor would also be welcomed. Like the ability to traverse preprocessor content source code easier.
**Describe alternatives you've considered**
I've tried to create a workaround for this by combining all the style blocks created by my preprocessor and applying them as one style block but it's not easy and I encounter quite a challenges.
The first is I need to convert the content provided by the `svelte.preprocess` API into something that's easier to work with. Then I search for all the style tags, merge their contents together and prepend it to the beginning of the document.
But in converting the content from a string to a syntax tree using a library like Cheerio it causes some issues converting back to a string, for example, it escapes some symbols like ampersands.
I also have the additional burden that the library I'm using to implement my tool has a [conflict with some Svelte syntax](https://github.com/phtmlorg/phtml/issues/8), so for now, I can't use pHTML on every component.
This is the progress I've made so far for combining all style blocks into one through a preprocessor.
```js
markup({ content, filename }) {
// Need to implement way code fence pHTML for now because of syntax issue
return phtmlUtilityClass.process(content, { from: filename }).then(result => {
let $ = cheerio.load(result.html)
styleBlocks.push($('style').html())
var styleTag = $('style')
styleTag.remove()
$('body').prepend(`<style>${styleBlocks.join('')}</style>`)
let newHTML = $('body').html()
return { code: newHTML, map: null }
});
}
```
**How important is this feature to you?**
Fairly important, it's blocking me from integrating my CSS framework into Svelte. But I'm likely to be in the minority for use cases. I use style blocks for live previewing of styles in some projects so I'm not looking forward to coming up against this issue there also.
I'm open to any other alternatives for how I could work around this.
**Additional context**
You can view a work in progress of the project I'm trying to create. https://github.com/limitlessloop/phtml-utility-class/tree/version-3
Just referencing this issue where multiple style blocks were also being discussed.
https://github.com/sveltejs/svelte/issues/2762
|
feature request,stale-bot,compiler,temp-stale
|
low
|
Critical
|
652,501,467 |
java-design-patterns
|
Implicit Lock pattern
|
## Description
The Implicit Lock design pattern ensures that only one thread can execute a particular section of code at a time without requiring explicit lock management by the developer. This is particularly useful in environments where multiple threads need to interact with shared resources, preventing data corruption and ensuring consistency. The pattern leverages synchronized methods or blocks to manage concurrent access automatically, simplifying the code and reducing the likelihood of concurrency-related bugs.
### Main Elements:
1. **Synchronization**: Use of synchronized methods or blocks to control access to critical sections of code.
2. **Automatic Lock Management**: The pattern abstracts lock management away from the developer, reducing the risk of errors.
3. **Concurrency Control**: Ensures that only one thread can execute the synchronized section at a time, preventing race conditions.
### References:
- [Martin Fowler's Catalog](https://martinfowler.com/eaaCatalog/implicitLock.html)
- [YouTube Explanation](https://www.youtube.com/watch?v=kDck7QuFzzg)
- [Project Contribution Guidelines](https://github.com/iluwatar/java-design-patterns/wiki)
### Acceptance Criteria:
1. Implement the Implicit Lock design pattern using synchronized methods or blocks in a new module.
2. Ensure thorough unit tests are created to validate the concurrency control and proper functioning of the pattern.
3. Update documentation to include an explanation of the Implicit Lock pattern, how it is implemented, and example use cases.
|
epic: pattern,type: feature
|
low
|
Critical
|
652,503,684 |
java-design-patterns
|
Layer Supertype pattern
|
### Description:
The Layer Supertype design pattern is used to provide a common base class for all objects in a particular layer. This pattern simplifies code maintenance and enforces consistency across similar objects. By implementing a layer supertype, we can centralize common behaviors and properties, reduce code duplication, and facilitate easier modifications and extensions in the future.
### Main elements of the pattern:
1. **Layer Supertype**: A common abstract base class or interface that provides shared methods and properties for all classes in the same layer.
2. **Inheritance**: Concrete classes inherit from the layer supertype to gain common functionality.
3. **Separation of Concerns**: This pattern helps in maintaining a clear separation between different layers of the application, making the code more modular and easier to manage.
### References:
- [Martin Fowler: Layer Supertype](https://martinfowler.com/eaaCatalog/layerSupertype.html)
- [Prashant Brall: Layer Supertype Pattern](https://prashantbrall.wordpress.com/2011/10/25/layer-supertype-pattern/)
### Acceptance Criteria:
1. Create an abstract base class or interface for the chosen layer (e.g., Service Layer, DAO Layer) that includes common properties and methods.
2. Refactor existing classes in the chosen layer to inherit from the new layer supertype, ensuring they implement or utilize the common functionality.
3. Update documentation and examples to demonstrate the use and benefits of the Layer Supertype pattern in the project.
|
epic: pattern,type: feature
|
low
|
Major
|
652,510,264 |
java-design-patterns
|
Pessimistic Offline Lock pattern
|
### Description
The Pessimistic Offline Lock design pattern ensures that only one process can access a particular resource at a time, preventing concurrent modifications and ensuring data consistency. This pattern is particularly useful in distributed systems where multiple processes might attempt to modify the same data. By locking resources before making changes, this pattern avoids conflicts and maintains data integrity.
Main elements of the pattern:
- **Lock Management**: Implement a mechanism to acquire and release locks on resources.
- **Transaction Handling**: Ensure that the locks are managed within the scope of transactions to avoid deadlocks and ensure that resources are properly released.
- **Conflict Resolution**: Define strategies to handle situations where a lock cannot be acquired immediately, such as retry mechanisms or user notifications.
### References
- [Pessimistic Offline Lock - Martin Fowler](https://martinfowler.com/eaaCatalog/pessimisticOfflineLock.html)
- [Patterns of Enterprise Application Architecture - Page 303](https://books.google.fi/books?id=vqTfNFDzzdIC&pg=PA303#v=onepage&q&f=false)
- [Java Design Patterns - Contribution Guidelines](https://github.com/iluwatar/java-design-patterns/wiki)
### Acceptance Criteria
1. Implement a lock management system that allows resources to be locked and unlocked by processes.
2. Ensure that the lock management is integrated with transaction handling to maintain data consistency and avoid deadlocks.
3. Document the implemented pattern with code examples and usage instructions in accordance with the project's contribution guidelines.
|
epic: pattern,type: feature
|
low
|
Major
|
652,511,133 |
java-design-patterns
|
Query Object pattern
|
### Description:
The Query Object design pattern encapsulates database queries as objects, allowing for the creation and reuse of complex queries in a more readable and maintainable manner. This pattern separates query construction from execution, promoting single responsibility and enhancing code maintainability. It is particularly useful in systems where queries are complex and frequently changing.
### Main Elements:
1. **Query Object**: Encapsulates the query logic. It contains methods to build and customize the query.
2. **Execution Method**: A method to execute the query built by the Query Object.
3. **Criteria Handling**: Mechanisms to add, remove, and combine query criteria dynamically.
4. **Reusability**: Queries can be reused across different parts of the application.
### References:
- [Martin Fowler's Query Object](https://martinfowler.com/eaaCatalog/queryObject.html)
- [Patterns of Enterprise Application Architecture by Martin Fowler (page 303)](https://books.google.fi/books?id=vqTfNFDzzdIC&pg=PA303#v=onepage&q&f=false)
- [Hojjat's Blog on Query Object Pattern](https://www.hojjatk.com/2018/08/query-object-pattern.html)
### Acceptance Criteria:
1. Implement a basic Query Object that can construct and execute simple queries.
2. Ensure the Query Object can handle dynamic criteria additions, removals, and combinations.
3. Provide examples and documentation demonstrating the usage and benefits of the Query Object design pattern.
|
epic: pattern,type: feature
|
low
|
Major
|
652,512,179 |
java-design-patterns
|
Record Set pattern
|
### Description:
Implement the Record Set design pattern to facilitate operations on a collection of records, akin to a database result set. This pattern allows for easy manipulation, retrieval, and iteration of records within a software system. The Record Set pattern is particularly useful for applications that require interaction with a large volume of records or need to provide an abstraction layer for database operations.
### Main Elements of the Pattern:
- **RecordSet Interface**: Defines methods for manipulating and accessing records, such as querying, updating, and iterating over the collection.
- **ConcreteRecordSet**: Implements the RecordSet interface, providing concrete behavior for the methods defined.
- **Record**: Represents a single entry within the RecordSet, encapsulating the data and behaviors specific to a record.
- **Cursor/Iterator**: Facilitates traversal over the records in the RecordSet, allowing clients to navigate through the records efficiently.
- **Operations**: Methods for filtering, sorting, and aggregating records within the RecordSet.
### References:
- [C2 Wiki: Record Set](https://wiki.c2.com/?RecordSet)
- [Google Books: P of EAA](https://books.google.fi/books?id=vqTfNFDzzdIC&pg=PA303#v=onepage&q&f=false)
- [Java Design Patterns Project Contribution Guidelines](https://github.com/iluwatar/java-design-patterns/wiki)
Acceptance Criteria:
1. Implement a RecordSet interface with methods for common operations such as querying, updating, and iterating records.
2. Create a ConcreteRecordSet class that provides the implementation for the RecordSet interface.
3. Include unit tests to validate the functionality of the RecordSet implementation, ensuring that all methods behave as expected.
|
epic: pattern,type: feature
|
low
|
Major
|
652,514,223 |
java-design-patterns
|
Remote Facade pattern
|
### Description:
The Remote Facade design pattern is an architectural pattern used to provide a coarse-grained interface to a set of fine-grained objects in a distributed system. This pattern helps to reduce the number of remote calls, thus improving performance and encapsulating the complexities of interactions between remote objects.
Key elements of the Remote Facade design pattern include:
- **Facade Interface**: A high-level interface that aggregates multiple operations into a single call, minimizing the number of remote calls required.
- **Service Layer**: A layer where the facade resides, providing a simplified interface to the underlying subsystem.
- **DTO (Data Transfer Object)**: Objects that carry data between processes to reduce the number of method calls.
- **Remote Communication**: Mechanisms like RMI, web services, or other remote communication protocols to interact with remote objects.
### References:
1. [Martin Fowler's Remote Facade](https://martinfowler.com/eaaCatalog/remoteFacade.html)
2. [StackOverflow: Remote Facade Pattern vs. Facade Pattern](https://stackoverflow.com/questions/20527419/remote-facade-pattern-vs-facade-pattern)
3. [YouTube: Remote Facade Pattern](https://www.youtube.com/watch?v=fBSiUo_cVDQ)
4. [Patterns of Enterprise Application Architecture by Martin Fowler (Google Books)](https://books.google.fi/books?id=vqTfNFDzzdIC&pg=PA303#v=onepage&q&f=false)
### Acceptance Criteria:
1. Implement a Remote Facade that provides a simplified interface for a set of operations on a remote subsystem.
2. Ensure the facade uses Data Transfer Objects (DTOs) to encapsulate data and reduce the number of remote method calls.
3. Document the Remote Facade implementation with appropriate usage examples and ensure it adheres to the project's contribution guidelines.
Link to project contribution guidelines: [Contribution Guidelines](https://github.com/iluwatar/java-design-patterns/wiki)
|
epic: pattern,type: feature
|
low
|
Major
|
652,515,006 |
java-design-patterns
|
Row Data Gateway pattern
|
### Description:
The Row Data Gateway pattern provides an object-oriented interface to a single row in a database table, encapsulating the database access logic within a gateway class. This pattern allows for a clear separation between business logic and database operations, enabling more maintainable and testable code.
#### Main Elements of the Pattern:
1. **Gateway Class**: Represents a single row in the database, providing methods for CRUD (Create, Read, Update, Delete) operations.
2. **Database Access Encapsulation**: Database queries and updates are encapsulated within the gateway class, abstracting the underlying database interaction.
3. **Separation of Concerns**: Business logic is separated from database access logic, promoting clean code architecture.
4. **Consistency**: Ensures data consistency by managing row-level data operations through the gateway class.
### References:
1. [Row Data Gateway - Wikipedia](https://en.wikipedia.org/wiki/Row_data_gateway)
2. [Row Data Gateway - Martin Fowler](https://martinfowler.com/eaaCatalog/rowDataGateway.html)
3. [Patterns of Enterprise Application Architecture by Martin Fowler](https://books.google.fi/books?id=vqTfNFDzzdIC&pg=PA303#v=onepage&q&f=false)
4. [Project Contribution Guidelines](https://github.com/iluwatar/java-design-patterns/wiki)
5. [Row Data Gateway](https://www.sourcecodeexamples.net/2018/04/row-data-gateway.html)
### Acceptance Criteria:
1. Create a gateway class representing a single row in a database table, with methods for Create, Read, Update, and Delete operations.
2. Ensure that the gateway class encapsulates all database access logic, separating it from the business logic.
3. Provide unit tests demonstrating the functionality of the gateway class, including CRUD operations and data consistency.
|
epic: pattern,type: feature
|
low
|
Major
|
652,517,016 |
java-design-patterns
|
Server Session State pattern
|
### Description:
Implement the Server Session State design pattern, which involves maintaining a user's session state on the server. This pattern helps manage user session data efficiently in a scalable and secure manner. The main elements of the pattern include:
- **Session State Management:** Store user session data on the server, reducing the amount of data transferred between client and server.
- **Scalability:** Ensure the system can handle a large number of sessions efficiently by managing session data in a scalable manner.
- **Security:** Protect session data from unauthorized access and ensure it is handled securely.
### References:
- [Martin Fowler's Server Session State](https://martinfowler.com/eaaCatalog/serverSessionState.html)
- [P of EAA](https://books.google.fi/books?id=vqTfNFDzzdIC&pg=PA303#v=onepage&q&f=false)
- [Project Contribution Guidelines](https://github.com/iluwatar/java-design-patterns/wiki)
Acceptance Criteria:
1. Implement a server-side session state management system that can handle session data storage and retrieval.
2. Ensure the system is scalable and can manage a large number of user sessions efficiently.
3. Implement security measures to protect session data from unauthorized access and ensure secure handling of session information.
|
epic: pattern,type: feature
|
low
|
Minor
|
652,519,663 |
java-design-patterns
|
Table Data Gateway pattern
|
### Description:
The Table Data Gateway pattern provides a way to encapsulate all the SQL operations for a single table or view within a gateway class. This pattern allows for a single point of access to the data in a table, ensuring a clean separation between the database and the application logic. The key elements of the Table Data Gateway pattern include:
- **Gateway Class:** Encapsulates the database access logic for a specific table or view.
- **CRUD Operations:** Methods for Create, Read, Update, and Delete operations.
- **Separation of Concerns:** Decouples the SQL queries from the application logic, promoting single responsibility and easier maintenance.
- **Reusability:** Reusable and testable components that centralize data access logic.
### References:
1. Martin Fowler's Table Data Gateway: [https://www.martinfowler.com/eaaCatalog/tableDataGateway.html](https://www.martinfowler.com/eaaCatalog/tableDataGateway.html)
2. Wikipedia: Table Data Gateway: [https://en.wikipedia.org/wiki/Table_data_gateway](https://en.wikipedia.org/wiki/Table_data_gateway)
3. Source Code Examples: Table Data Gateway: [https://www.sourcecodeexamples.net/2018/04/table-data-gateway.html](https://www.sourcecodeexamples.net/2018/04/table-data-gateway.html)
4. [P of EAA](https://books.google.fi/books?id=vqTfNFDzzdIC&pg=PA303#v=onepage&q&f=false)
### Acceptance Criteria:
1. Implement a gateway class that encapsulates SQL operations for a specific table.
2. Include methods for Create, Read, Update, and Delete operations within the gateway class.
3. Ensure that the gateway class is well-documented and includes unit tests to verify its functionality.
|
info: help wanted,epic: pattern,type: feature
|
low
|
Major
|
652,521,930 |
go
|
cmd/vet: structtag field repeats json warning with valid override
|
### What version of Go are you using (`go version`)?
<pre>
$ go version
go version go1.14.1 darwin/amd64
</pre>
### Does this issue reproduce with the latest release?
Yes
### What operating system and processor architecture are you using (`go env`)?
<details><summary><code>go env</code> Output</summary><br><pre>
$ go env
GO111MODULE="on"
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/[XX]/Library/Caches/go-build"
GOENV="/Users/[XX]/Library/Application Support/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOINSECURE=""
GONOPROXY=""
GONOSUMDB=""
GOOS="darwin"
GOPATH="/Users/[XX]/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/Cellar/go/1.14.1/libexec"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/Cellar/go/1.14.1/libexec/pkg/tool/darwin_amd64"
GCCGO="gccgo"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD="/dev/null"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/w9/kv18_grs18x65fyzv1p5mvk00000gn/T/go-build893878327=/tmp/go-build -gno-record-gcc-switches -fno-common"
</pre></details>
### What did you do?
When embedding two structs with duplicate JSON tags, e.g.:
```
type A struct {
name string `json:"name"`
... // additional fields
}
type B struct {
name string `json:"name"`
... // additional fields
}
type C struct {
A
B // raises go vet structtag warning
}
```
A `structtag` warning is raised by go vet. I think a reasonable workaround to the warning is to override the duplicate-tag on the top level, per extra rules here: https://golang.org/pkg/encoding/json/#Marshal, e.g.
```
type C struct {
A
B
name string `json:"name"`
}
```
But `go vet` still raises the warning.
**Note** I did add the flag `-structtag=false` as a workaround but there are cases where I would like to be alerted, but only when no override has been set
### What did you expect to see?
`go vet` treats top-level `structtag` overrides as a valid solution and no longer raises a warning.
### What did you see instead?
`go vet` ignores the top-level override, resulting in `structtag: struct field X repeats json tag "[X]" also at XXXX.go:XXX (govet)`
|
NeedsInvestigation,Tools,Analysis
|
low
|
Critical
|
652,522,524 |
java-design-patterns
|
Transform View pattern
|
**Description:**
The Transform View design pattern is a method used to separate the presentation and business logic layers in software development. This pattern involves transforming data from the model into a format suitable for rendering in the view. The key elements of this pattern include:
1. **Data Transformation:** The primary function is to transform raw data from the model into a suitable format for the view.
2. **Separation of Concerns:** This pattern promotes a clean separation between the business logic and the presentation layer, ensuring that changes in the data model do not directly impact the view.
3. **Reusability:** Transformations can be reused across different views, promoting DRY (Don't Repeat Yourself) principles and making the codebase easier to maintain.
**References:**
- [Transform View - Martin Fowler](https://www.martinfowler.com/eaaCatalog/transformView.html)
- [Patterns of Enterprise Application Architecture - Page 303](https://books.google.fi/books?id=vqTfNFDzzdIC&pg=PA303#v=onepage&q&f=false)
- [Project Contribution Guidelines](https://github.com/iluwatar/java-design-patterns/wiki)
**Acceptance Criteria:**
1. Implement a Transform View pattern that clearly separates the data transformation logic from the view rendering logic.
2. Ensure the implementation includes at least one example demonstrating the transformation of a data model into a view format.
3. Document the implementation and provide usage instructions and examples in the project README file.
|
epic: pattern,type: feature
|
low
|
Major
|
652,523,759 |
java-design-patterns
|
Two Step View pattern
|
### Description:
The Two Step View design pattern is used to separate the process of generating dynamic web content into two distinct phases: data preparation and data presentation. This separation allows for more modular, maintainable, and testable code. The pattern is particularly useful for web applications with complex presentation logic, where it can help to simplify the development and maintenance of views.
Main Elements of the Pattern:
1. **Data Preparation Phase**: In this phase, the raw data is collected and processed into a form that is suitable for rendering. This usually involves gathering data from various sources, performing necessary computations, and organizing it into a structured format.
2. **Presentation Phase**: This phase takes the prepared data and applies a template to generate the final HTML or other output formats. The template defines how the data should be displayed, separating the concerns of data structure and visual presentation.
### References:
- [Martin Fowler's Catalog on Two Step View](https://martinfowler.com/eaaCatalog/twoStepView.html)
- [Patterns of Enterprise Application Architecture by Martin Fowler (Page 303)](https://books.google.fi/books?id=vqTfNFDzzdIC&pg=PA303#v=onepage&q&f=false)
- [Ranjitha Balaraman's Blog on Two Step View](https://ranjithabalaraman.wordpress.com/category/patterns-of-enterprise-application-architecture/web-presentation-pattern/two-step-view/)
- [Thierry Roussel's Notes on HTML Renderer](http://thierryroussel.free.fr/java/books/martinfowler/www.martinfowler.com/isa/htmlRenderer.html)
Acceptance Criteria:
1. Implement the Two Step View pattern by creating a distinct data preparation phase and a presentation phase in the web application.
2. Ensure that the data preparation logic is separated from the presentation logic to promote modularity and maintainability.
3. Provide unit tests to verify the correctness of both the data preparation and presentation phases, ensuring that they work correctly independently and together.
|
epic: pattern,type: feature
|
low
|
Major
|
652,526,305 |
go
|
x/website, x/pkgsite: net/http.ServeMux.Handle example reads poorly if shown as a complete program
|
<!--
Please answer these questions before submitting your issue. Thanks!
For questions please use one of our forums: https://github.com/golang/go/wiki/Questions
-->
### What version of Go are you using (`go version`)?
<pre>
$ go version
go version go1.14.4 darwin/amd64
</pre>
### Does this issue reproduce with the latest release?
In current package documentation at https://golang.org/pkg/net/http/#example_ServeMux_Handle
### What operating system and processor architecture are you using (`go env`)?
<details><summary><code>go env</code> Output</summary><br><pre>
$ go env
GOARCH="amd64"
GOOS="darwin"
</pre></details>
<!--
If possible, provide a recipe for reproducing the error.
A complete runnable program is good.
A link on play.golang.org is best.
-->
### What did you expect to see?
Expected example to initiate http.ListenAndServe or equivalent with new ServeMux
<pre>
package main
import (
"fmt"
"log"
"net/http"
)
type apiHandler struct{}
func (apiHandler) ServeHTTP(http.ResponseWriter, *http.Request) {}
func main() {
mux := http.NewServeMux()
mux.Handle("/api/", apiHandler{})
mux.HandleFunc("/", func(w http.ResponseWriter, req *http.Request) {
// The "/" pattern matches everything, so we need to check
// that we're at the root here.
if req.URL.Path != "/" {
http.NotFound(w, req)
return
}
fmt.Fprintf(w, "Welcome to the home page!")
})
log.Fatal(http.ListenAndServe(":8080", mux))
}
</pre>
### What did you see instead?
The example immediately exits without serving
<pre>
package main
import (
"fmt"
"net/http"
)
type apiHandler struct{}
func (apiHandler) ServeHTTP(http.ResponseWriter, *http.Request) {}
func main() {
mux := http.NewServeMux()
mux.Handle("/api/", apiHandler{})
mux.HandleFunc("/", func(w http.ResponseWriter, req *http.Request) {
// The "/" pattern matches everything, so we need to check
// that we're at the root here.
if req.URL.Path != "/" {
http.NotFound(w, req)
return
}
fmt.Fprintf(w, "Welcome to the home page!")
})
}
</pre>
I'd be happy to work on this for my first contribution if accepted
|
Documentation,NeedsInvestigation
|
low
|
Critical
|
652,531,582 |
electron
|
Distinguish hard and soft reloads from the "devtools-reload-page" event
|
### Problem Description
It should be possible to understand if the user wanted a soft or a hard reload from the "devtools-reload-page" event, so that it can be hijacked and the correct kind of reload can be then re-triggered.
### Proposed Solution
Either adding a property for this to the emitted event, or adding a "devtools-hard-reload-page" event, but the latter would be a backwards incompatible change as it wouldn't make sense to emit both events.
### Alternatives Considered
I'm not sure this can be done in other ways, maybe one can inject some custom shortcuts detection logic into the devtools webcontents but that'd be crazy.
|
enhancement :sparkles:
|
low
|
Minor
|
652,535,717 |
pytorch
|
Add a function to convert SyncBatchNorm layers back to BatchNorm Layers
|
`SyncBatchNorm` provides a classmethod to convert `BatchNorm` layers to `SyncBatchNorm` layers:
https://github.com/pytorch/pytorch/blob/881c1adfcd916b6cd5de91bc343eb86aff88cc80/torch/nn/modules/batchnorm.py#L510-L556
It will be helpful to provide an API to do the reverse conversion as well.
cc @albanD @mruberry @ayush29feb
|
module: bootcamp,feature,module: nn,triaged
|
low
|
Major
|
652,593,775 |
flutter
|
[Web] RenderParagraph.getBoxesForSelection broken test
|
[Skip Audit]
These two tests are broken based on incorrect results from `RenderParagraph.getBoxesForSelection`:
Test:
https://github.com/flutter/flutter/blob/8ed8b06ac5a1028e689d87592543880882a516da/packages/flutter/test/rendering/paragraph_test.dart#L56
Result:
```
03:34 +511 ~23 -2: /tmp/flutter sdk/packages/flutter/test/rendering/paragraph_test.dart: getBoxesForSelection control test [E]
Expected: true
Actual: <false>
package:dart-sdk/lib/_internal/js_dev_runtime/private/ddc_runtime/errors.dart 214:49 throw_
package:test_api expect$
package:flutter_test/src/widget_tester.dart 369:3 expect$
paragraph_test.dart 74:5 <fn>
package:test_api <fn>
package:dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 45:50 <fn>
package:stack_trace <fn>
package:dart-sdk/lib/async/zone.dart 1198:47 _rootRunUnary
package:dart-sdk/lib/async/zone.dart 1100:19 runUnary
package:dart-sdk/lib/async/future_impl.dart 143:18 handleValue
package:dart-sdk/lib/async/future_impl.dart 696:44 handleValueCallback
package:dart-sdk/lib/async/future_impl.dart 725:32 _propagateToListeners
package:dart-sdk/lib/async/future_impl.dart 393:9 <fn>
package:stack_trace <fn>
package:dart-sdk/lib/async/zone.dart 1190:13 _rootRun
package:dart-sdk/lib/async/zone.dart 1093:19 run
package:dart-sdk/lib/async/zone.dart 997:7 runGuarded
package:dart-sdk/lib/async/zone.dart 1037:23 callback
package:dart-sdk/lib/async/schedule_microtask.dart 41:11 _microtaskLoop
package:dart-sdk/lib/async/schedule_microtask.dart 50:5 _startMicrotaskLoop
package:dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 166:15 <fn>
===== asynchronous gap ===========================
package:dart-sdk/lib/async/zone.dart 1121:19 registerUnaryCallback
package:dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 67:19 _async
package:test_api <fn>
package:dart-sdk/lib/async/zone.dart 1190:13 _rootRun
package:dart-sdk/lib/async/zone.dart 1093:19 run
package:dart-sdk/lib/async/zone.dart 1629:67 _runZoned
package:dart-sdk/lib/async/zone.dart 1550:10 runZoned
package:test_api <fn>
package:dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 84:54 runBody
package:dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 123:12 _async
package:test_api <fn>
package:dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 84:54 runBody
package:dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 123:12 _async
package:test_api <fn>
package:dart-sdk/lib/async/zone.dart 1190:13 _rootRun
package:dart-sdk/lib/async/zone.dart 1093:19 run
package:dart-sdk/lib/async/zone.dart 1629:67 _runZoned
package:dart-sdk/lib/async/zone.dart 1550:10 runZoned
package:test_api <fn>
package:dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 45:50 <fn>
package:stack_trace <fn>
package:dart-sdk/lib/async/zone.dart 1198:47 _rootRunUnary
package:dart-sdk/lib/async/zone.dart 1100:19 runUnary
package:dart-sdk/lib/async/future_impl.dart 143:18 handleValue
package:dart-sdk/lib/async/future_impl.dart 696:44 handleValueCallback
package:dart-sdk/lib/async/future_impl.dart 725:32 _propagateToListeners
package:dart-sdk/lib/async/future_impl.dart 519:7 [_complete]
package:dart-sdk/lib/async/future.dart 175:15 <fn>
package:stack_trace <fn>
package:dart-sdk/lib/async/zone.dart 1182:47 _rootRun
package:dart-sdk/lib/async/zone.dart 1093:19 run
package:dart-sdk/lib/async/zone.dart 997:7 runGuarded
package:dart-sdk/lib/async/zone.dart 1037:23 <fn>
package:stack_trace <fn>
package:dart-sdk/lib/async/zone.dart 1190:13 _rootRun
package:dart-sdk/lib/async/zone.dart 1093:19 run
package:dart-sdk/lib/async/zone.dart 1021:23 <fn>
package:dart-sdk/lib/_internal/js_dev_runtime/private/isolate_helper.dart 48:19 internalCallback
===== asynchronous gap ===========================
package:dart-sdk/lib/async/zone.dart 1121:19 registerUnaryCallback
package:dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 67:19 _async
package:test_api <fn>
package:dart-sdk/lib/async/zone.dart 1190:13 _rootRun
package:dart-sdk/lib/async/zone.dart 1093:19 run
package:dart-sdk/lib/async/zone.dart 1629:67 _runZoned
package:dart-sdk/lib/async/zone.dart 1550:10 runZoned
package:stack_trace <fn>
package:dart-sdk/lib/async/zone.dart 1190:13 _rootRun
package:dart-sdk/lib/async/zone.dart 1093:19 run
package:dart-sdk/lib/async/zone.dart 1629:67 _runZoned
package:dart-sdk/lib/async/zone.dart 1550:10 runZoned
package:test_api <fn>
package:dart-sdk/lib/async/zone.dart 1190:13 _rootRun
package:dart-sdk/lib/async/zone.dart 1093:19 run
package:dart-sdk/lib/async/zone.dart 1629:67 _runZoned
package:dart-sdk/lib/async/zone.dart 1550:10 runZoned
package:test_api <fn>
package:dart-sdk/lib/async/zone.dart 1198:47 _rootRunUnary
package:dart-sdk/lib/async/zone.dart 1100:19 runUnary
package:dart-sdk/lib/async/zone.dart 1005:7 runUnaryGuarded
package:dart-sdk/lib/async/stream_impl.dart 357:11 [_sendData]
package:dart-sdk/lib/async/stream_impl.dart 285:7 [_add]
package:dart-sdk/lib/async/stream_controller.dart 808:19 [_sendData]
package:dart-sdk/lib/async/stream_controller.dart 682:7 [_add]
package:dart-sdk/lib/async/stream_controller.dart 624:5 add
package:dart-sdk/lib/async/zone.dart 1206:13 _rootRunUnary
package:dart-sdk/lib/async/zone.dart 1100:19 runUnary
package:dart-sdk/lib/async/zone.dart 1005:7 runUnaryGuarded
package:dart-sdk/lib/async/stream_impl.dart 357:11 [_sendData]
package:dart-sdk/lib/async/stream_impl.dart 285:7 [_add]
package:dart-sdk/lib/async/stream_controller.dart 808:19 [_sendData]
package:dart-sdk/lib/async/stream_controller.dart 682:7 [_add]
package:dart-sdk/lib/async/stream_controller.dart 624:5 add
package:dart-sdk/lib/async/stream_controller.dart 900:13 add
package:stream_channel <fn>
package:dart-sdk/lib/async/zone.dart 1384:10 runUnaryGuarded
package:dart-sdk/lib/async/stream_impl.dart 357:11 [_sendData]
package:dart-sdk/lib/async/stream_impl.dart 285:7 [_add]
package:dart-sdk/lib/async/stream_controller.dart 808:19 [_sendData]
package:dart-sdk/lib/async/stream_controller.dart 682:7 [_add]
package:dart-sdk/lib/async/stream_controller.dart 624:5 add
package:dart-sdk/lib/async/zone.dart 1384:10 runUnaryGuarded
package:dart-sdk/lib/async/stream_impl.dart 357:11 [_sendData]
package:dart-sdk/lib/async/stream_impl.dart 285:7 [_add]
package:dart-sdk/lib/async/stream_controller.dart 808:19 [_sendData]
package:dart-sdk/lib/async/stream_controller.dart 682:7 [_add]
package:dart-sdk/lib/async/stream_controller.dart 624:5 add
package:dart-sdk/lib/async/stream_controller.dart 900:13 add
package:dart-sdk/lib/async/zone.dart 1384:10 runUnaryGuarded
package:dart-sdk/lib/async/stream_impl.dart 357:11 [_sendData]
package:dart-sdk/lib/async/stream_impl.dart 285:7 [_add]
package:dart-sdk/lib/async/stream_controller.dart 808:19 [_sendData]
package:dart-sdk/lib/async/stream_controller.dart 682:7 [_add]
package:dart-sdk/lib/async/stream_controller.dart 624:5 add
package:dart-sdk/lib/async/zone.dart 1384:10 runUnaryGuarded
package:dart-sdk/lib/async/stream_impl.dart 357:11 [_sendData]
package:dart-sdk/lib/async/stream_impl.dart 285:7 [_add]
package:dart-sdk/lib/async/stream_controller.dart 808:19 [_sendData]
package:dart-sdk/lib/async/stream_controller.dart 682:7 [_add]
package:dart-sdk/lib/async/stream_controller.dart 624:5 add
package:dart-sdk/lib/async/stream_controller.dart 900:13 add
package:stream_channel add
paragraph_test.dart.browser_test.dart 52:17 <fn>
package:dart-sdk/lib/_internal/js_dev_runtime/private/ddc_runtime/operations.dart 324:14 _checkAndCall
package:dart-sdk/lib/_internal/js_dev_runtime/private/ddc_runtime/operations.dart 329:39 dcall
package:dart-sdk/lib/html/dart2js/html_dart2js.dart 37188:58 <fn>
```
Test:
https://github.com/flutter/flutter/blob/8ed8b06ac5a1028e689d87592543880882a516da/packages/flutter/test/rendering/paragraph_test.dart#L232
Result:
```
03:35 +512 ~23 -6: /tmp/flutter sdk/packages/flutter/test/rendering/paragraph_test.dart: nested TextSpans in paragraph handle textScaleFactor correctly. [E]
Expected: <4>
Actual: <142>
package:dart-sdk/lib/_internal/js_dev_runtime/private/ddc_runtime/errors.dart 214:49 throw_
package:test_api expect$
package:flutter_test/src/widget_tester.dart 369:3 expect$
paragraph_test.dart 271:5 <fn>
package:test_api <fn>
package:dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 45:50 <fn>
package:stack_trace <fn>
package:dart-sdk/lib/async/zone.dart 1198:47 _rootRunUnary
package:dart-sdk/lib/async/zone.dart 1100:19 runUnary
package:dart-sdk/lib/async/future_impl.dart 143:18 handleValue
package:dart-sdk/lib/async/future_impl.dart 696:44 handleValueCallback
package:dart-sdk/lib/async/future_impl.dart 725:32 _propagateToListeners
package:dart-sdk/lib/async/future_impl.dart 393:9 <fn>
package:stack_trace <fn>
package:dart-sdk/lib/async/zone.dart 1190:13 _rootRun
package:dart-sdk/lib/async/zone.dart 1093:19 run
package:dart-sdk/lib/async/zone.dart 997:7 runGuarded
package:dart-sdk/lib/async/zone.dart 1037:23 callback
package:dart-sdk/lib/async/schedule_microtask.dart 41:11 _microtaskLoop
package:dart-sdk/lib/async/schedule_microtask.dart 50:5 _startMicrotaskLoop
package:dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 166:15 <fn>
===== asynchronous gap ===========================
package:dart-sdk/lib/async/zone.dart 1121:19 registerUnaryCallback
package:dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 67:19 _async
package:test_api <fn>
package:dart-sdk/lib/async/zone.dart 1190:13 _rootRun
package:dart-sdk/lib/async/zone.dart 1093:19 run
package:dart-sdk/lib/async/zone.dart 1629:67 _runZoned
package:dart-sdk/lib/async/zone.dart 1550:10 runZoned
package:test_api <fn>
package:dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 84:54 runBody
package:dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 123:12 _async
package:test_api <fn>
package:dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 84:54 runBody
package:dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 123:12 _async
package:test_api <fn>
package:dart-sdk/lib/async/zone.dart 1190:13 _rootRun
package:dart-sdk/lib/async/zone.dart 1093:19 run
package:dart-sdk/lib/async/zone.dart 1629:67 _runZoned
package:dart-sdk/lib/async/zone.dart 1550:10 runZoned
package:test_api <fn>
package:dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 45:50 <fn>
package:stack_trace <fn>
package:dart-sdk/lib/async/zone.dart 1198:47 _rootRunUnary
package:dart-sdk/lib/async/zone.dart 1100:19 runUnary
package:dart-sdk/lib/async/future_impl.dart 143:18 handleValue
package:dart-sdk/lib/async/future_impl.dart 696:44 handleValueCallback
package:dart-sdk/lib/async/future_impl.dart 725:32 _propagateToListeners
package:dart-sdk/lib/async/future_impl.dart 519:7 [_complete]
package:dart-sdk/lib/async/future.dart 175:15 <fn>
package:stack_trace <fn>
package:dart-sdk/lib/async/zone.dart 1182:47 _rootRun
package:dart-sdk/lib/async/zone.dart 1093:19 run
package:dart-sdk/lib/async/zone.dart 997:7 runGuarded
package:dart-sdk/lib/async/zone.dart 1037:23 <fn>
package:stack_trace <fn>
package:dart-sdk/lib/async/zone.dart 1190:13 _rootRun
package:dart-sdk/lib/async/zone.dart 1093:19 run
package:dart-sdk/lib/async/zone.dart 1021:23 <fn>
package:dart-sdk/lib/_internal/js_dev_runtime/private/isolate_helper.dart 48:19 internalCallback
===== asynchronous gap ===========================
package:dart-sdk/lib/async/zone.dart 1121:19 registerUnaryCallback
package:dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 67:19 _async
package:test_api <fn>
package:dart-sdk/lib/async/zone.dart 1190:13 _rootRun
package:dart-sdk/lib/async/zone.dart 1093:19 run
package:dart-sdk/lib/async/zone.dart 1629:67 _runZoned
package:dart-sdk/lib/async/zone.dart 1550:10 runZoned
package:stack_trace <fn>
package:dart-sdk/lib/async/zone.dart 1190:13 _rootRun
package:dart-sdk/lib/async/zone.dart 1093:19 run
package:dart-sdk/lib/async/zone.dart 1629:67 _runZoned
package:dart-sdk/lib/async/zone.dart 1550:10 runZoned
package:test_api <fn>
package:dart-sdk/lib/async/zone.dart 1190:13 _rootRun
package:dart-sdk/lib/async/zone.dart 1093:19 run
package:dart-sdk/lib/async/zone.dart 1629:67 _runZoned
package:dart-sdk/lib/async/zone.dart 1550:10 runZoned
package:test_api <fn>
package:dart-sdk/lib/async/zone.dart 1198:47 _rootRunUnary
package:dart-sdk/lib/async/zone.dart 1100:19 runUnary
package:dart-sdk/lib/async/zone.dart 1005:7 runUnaryGuarded
package:dart-sdk/lib/async/stream_impl.dart 357:11 [_sendData]
package:dart-sdk/lib/async/stream_impl.dart 285:7 [_add]
package:dart-sdk/lib/async/stream_controller.dart 808:19 [_sendData]
package:dart-sdk/lib/async/stream_controller.dart 682:7 [_add]
package:dart-sdk/lib/async/stream_controller.dart 624:5 add
package:dart-sdk/lib/async/zone.dart 1206:13 _rootRunUnary
package:dart-sdk/lib/async/zone.dart 1100:19 runUnary
package:dart-sdk/lib/async/zone.dart 1005:7 runUnaryGuarded
package:dart-sdk/lib/async/stream_impl.dart 357:11 [_sendData]
package:dart-sdk/lib/async/stream_impl.dart 285:7 [_add]
package:dart-sdk/lib/async/stream_controller.dart 808:19 [_sendData]
package:dart-sdk/lib/async/stream_controller.dart 682:7 [_add]
package:dart-sdk/lib/async/stream_controller.dart 624:5 add
package:dart-sdk/lib/async/stream_controller.dart 900:13 add
package:stream_channel <fn>
package:dart-sdk/lib/async/zone.dart 1384:10 runUnaryGuarded
package:dart-sdk/lib/async/stream_impl.dart 357:11 [_sendData]
package:dart-sdk/lib/async/stream_impl.dart 285:7 [_add]
package:dart-sdk/lib/async/stream_controller.dart 808:19 [_sendData]
package:dart-sdk/lib/async/stream_controller.dart 682:7 [_add]
package:dart-sdk/lib/async/stream_controller.dart 624:5 add
package:dart-sdk/lib/async/zone.dart 1384:10 runUnaryGuarded
package:dart-sdk/lib/async/stream_impl.dart 357:11 [_sendData]
package:dart-sdk/lib/async/stream_impl.dart 285:7 [_add]
package:dart-sdk/lib/async/stream_controller.dart 808:19 [_sendData]
package:dart-sdk/lib/async/stream_controller.dart 682:7 [_add]
package:dart-sdk/lib/async/stream_controller.dart 624:5 add
package:dart-sdk/lib/async/stream_controller.dart 900:13 add
package:dart-sdk/lib/async/zone.dart 1384:10 runUnaryGuarded
package:dart-sdk/lib/async/stream_impl.dart 357:11 [_sendData]
package:dart-sdk/lib/async/stream_impl.dart 285:7 [_add]
package:dart-sdk/lib/async/stream_controller.dart 808:19 [_sendData]
package:dart-sdk/lib/async/stream_controller.dart 682:7 [_add]
package:dart-sdk/lib/async/stream_controller.dart 624:5 add
package:dart-sdk/lib/async/zone.dart 1384:10 runUnaryGuarded
package:dart-sdk/lib/async/stream_impl.dart 357:11 [_sendData]
package:dart-sdk/lib/async/stream_impl.dart 285:7 [_add]
package:dart-sdk/lib/async/stream_controller.dart 808:19 [_sendData]
package:dart-sdk/lib/async/stream_controller.dart 682:7 [_add]
package:dart-sdk/lib/async/stream_controller.dart 624:5 add
package:dart-sdk/lib/async/stream_controller.dart 900:13 add
package:stream_channel add
paragraph_test.dart.browser_test.dart 52:17 <fn>
package:dart-sdk/lib/_internal/js_dev_runtime/private/ddc_runtime/operations.dart 324:14 _checkAndCall
package:dart-sdk/lib/_internal/js_dev_runtime/private/ddc_runtime/operations.dart 329:39 dcall
package:dart-sdk/lib/html/dart2js/html_dart2js.dart 37188:58 <fn>
```
flutter doctor
```
[β] Flutter (Channel master, 1.19.0-4.0.pre.42, on Mac OS X 10.15.4 19E287, locale en-US)
β’ Flutter version 1.19.0-4.0.pre.42 at /Users/katelovett/github/flutter
β’ Framework revision bc8d0f5706 (21 hours ago), 2020-07-06 15:57:59 -0700
β’ Engine revision f8bbcc396b
β’ Dart version 2.9.0 (build 2.9.0-20.0.dev c190fc3a31)
[β] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
β’ Android SDK at /Users/katelovett/Library/Android/sdk
β’ Platform android-28, build-tools 28.0.3
β’ Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
β’ Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1343-b01)
β’ All Android licenses accepted.
[β] Xcode - develop for iOS and macOS (Xcode 11.3.1)
β’ Xcode at /Applications/Xcode.app/Contents/Developer
β’ Xcode 11.3.1, Build version 11C505
β’ CocoaPods version 1.9.1
[β] Android Studio (version 3.4)
β’ Android Studio at /Applications/Android Studio.app/Contents
β’ Flutter plugin version 36.1.1
β’ Dart plugin version 183.6270
β’ Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1343-b01)
[β] VS Code (version 1.45.1)
β’ VS Code at /Applications/Visual Studio Code.app/Contents
β’ Flutter extension version 3.12.1
[β] Connected device (1 available)
β’ iPhone 11 Pro Max (mobile) β’ A8FFA716-A67B-4468-B92B-F2B61F2306A0 β’ ios β’ com.apple.CoreSimulator.SimRuntime.iOS-13-3
(simulator)
β’ No issues found!
```
|
a: tests,framework,a: typography,platform-web,P3,team-web,triaged-web
|
low
|
Critical
|
652,595,907 |
flutter
|
[Web] RenderParagraph.getWordBoundary broken test
|
[Skip audit]
The following test is broken on web based on an incorrect result from RenderParagraph.getWordBoundary
Test:
https://github.com/flutter/flutter/blob/8ed8b06ac5a1028e689d87592543880882a516da/packages/flutter/test/rendering/paragraph_test.dart#L79
Result:
```
03:34 +511 ~23 -3: /tmp/flutter sdk/packages/flutter/test/rendering/paragraph_test.dart: getWordBoundary control test [E]
Expected: ' '
Actual: 'I '
Which: is different.
Expected:
Actual: I
^
Differ at offset 0
package:dart-sdk/lib/_internal/js_dev_runtime/private/ddc_runtime/errors.dart 214:49 throw_
package:test_api expect$
package:flutter_test/src/widget_tester.dart 369:3 expect$
paragraph_test.dart 88:5 <fn>
package:test_api <fn>
package:dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 45:50 <fn>
package:stack_trace <fn>
package:dart-sdk/lib/async/zone.dart 1198:47 _rootRunUnary
package:dart-sdk/lib/async/zone.dart 1100:19 runUnary
package:dart-sdk/lib/async/future_impl.dart 143:18 handleValue
package:dart-sdk/lib/async/future_impl.dart 696:44 handleValueCallback
package:dart-sdk/lib/async/future_impl.dart 725:32 _propagateToListeners
package:dart-sdk/lib/async/future_impl.dart 393:9 <fn>
package:stack_trace <fn>
package:dart-sdk/lib/async/zone.dart 1190:13 _rootRun
package:dart-sdk/lib/async/zone.dart 1093:19 run
package:dart-sdk/lib/async/zone.dart 997:7 runGuarded
package:dart-sdk/lib/async/zone.dart 1037:23 callback
package:dart-sdk/lib/async/schedule_microtask.dart 41:11 _microtaskLoop
package:dart-sdk/lib/async/schedule_microtask.dart 50:5 _startMicrotaskLoop
package:dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 166:15 <fn>
===== asynchronous gap ===========================
package:dart-sdk/lib/async/zone.dart 1121:19 registerUnaryCallback
package:dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 67:19 _async
package:test_api <fn>
package:dart-sdk/lib/async/zone.dart 1190:13 _rootRun
package:dart-sdk/lib/async/zone.dart 1093:19 run
package:dart-sdk/lib/async/zone.dart 1629:67 _runZoned
package:dart-sdk/lib/async/zone.dart 1550:10 runZoned
package:test_api <fn>
package:dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 84:54 runBody
package:dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 123:12 _async
package:test_api <fn>
package:dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 84:54 runBody
package:dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 123:12 _async
package:test_api <fn>
package:dart-sdk/lib/async/zone.dart 1190:13 _rootRun
package:dart-sdk/lib/async/zone.dart 1093:19 run
package:dart-sdk/lib/async/zone.dart 1629:67 _runZoned
package:dart-sdk/lib/async/zone.dart 1550:10 runZoned
package:test_api <fn>
package:dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 45:50 <fn>
package:stack_trace <fn>
package:dart-sdk/lib/async/zone.dart 1198:47 _rootRunUnary
package:dart-sdk/lib/async/zone.dart 1100:19 runUnary
package:dart-sdk/lib/async/future_impl.dart 143:18 handleValue
package:dart-sdk/lib/async/future_impl.dart 696:44 handleValueCallback
package:dart-sdk/lib/async/future_impl.dart 725:32 _propagateToListeners
package:dart-sdk/lib/async/future_impl.dart 519:7 [_complete]
package:dart-sdk/lib/async/future.dart 175:15 <fn>
package:stack_trace <fn>
package:dart-sdk/lib/async/zone.dart 1182:47 _rootRun
package:dart-sdk/lib/async/zone.dart 1093:19 run
package:dart-sdk/lib/async/zone.dart 997:7 runGuarded
package:dart-sdk/lib/async/zone.dart 1037:23 <fn>
package:stack_trace <fn>
package:dart-sdk/lib/async/zone.dart 1190:13 _rootRun
package:dart-sdk/lib/async/zone.dart 1093:19 run
package:dart-sdk/lib/async/zone.dart 1021:23 <fn>
package:dart-sdk/lib/_internal/js_dev_runtime/private/isolate_helper.dart 48:19 internalCallback
===== asynchronous gap ===========================
package:dart-sdk/lib/async/zone.dart 1121:19 registerUnaryCallback
package:dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 67:19 _async
package:test_api <fn>
package:dart-sdk/lib/async/zone.dart 1190:13 _rootRun
package:dart-sdk/lib/async/zone.dart 1093:19 run
package:dart-sdk/lib/async/zone.dart 1629:67 _runZoned
package:dart-sdk/lib/async/zone.dart 1550:10 runZoned
package:stack_trace <fn>
package:dart-sdk/lib/async/zone.dart 1190:13 _rootRun
package:dart-sdk/lib/async/zone.dart 1093:19 run
package:dart-sdk/lib/async/zone.dart 1629:67 _runZoned
package:dart-sdk/lib/async/zone.dart 1550:10 runZoned
package:test_api <fn>
package:dart-sdk/lib/async/zone.dart 1190:13 _rootRun
package:dart-sdk/lib/async/zone.dart 1093:19 run
package:dart-sdk/lib/async/zone.dart 1629:67 _runZoned
package:dart-sdk/lib/async/zone.dart 1550:10 runZoned
package:test_api <fn>
package:dart-sdk/lib/async/zone.dart 1198:47 _rootRunUnary
package:dart-sdk/lib/async/zone.dart 1100:19 runUnary
package:dart-sdk/lib/async/zone.dart 1005:7 runUnaryGuarded
package:dart-sdk/lib/async/stream_impl.dart 357:11 [_sendData]
package:dart-sdk/lib/async/stream_impl.dart 285:7 [_add]
package:dart-sdk/lib/async/stream_controller.dart 808:19 [_sendData]
package:dart-sdk/lib/async/stream_controller.dart 682:7 [_add]
package:dart-sdk/lib/async/stream_controller.dart 624:5 add
package:dart-sdk/lib/async/zone.dart 1206:13 _rootRunUnary
package:dart-sdk/lib/async/zone.dart 1100:19 runUnary
package:dart-sdk/lib/async/zone.dart 1005:7 runUnaryGuarded
package:dart-sdk/lib/async/stream_impl.dart 357:11 [_sendData]
package:dart-sdk/lib/async/stream_impl.dart 285:7 [_add]
package:dart-sdk/lib/async/stream_controller.dart 808:19 [_sendData]
package:dart-sdk/lib/async/stream_controller.dart 682:7 [_add]
package:dart-sdk/lib/async/stream_controller.dart 624:5 add
package:dart-sdk/lib/async/stream_controller.dart 900:13 add
package:stream_channel <fn>
package:dart-sdk/lib/async/zone.dart 1384:10 runUnaryGuarded
package:dart-sdk/lib/async/stream_impl.dart 357:11 [_sendData]
package:dart-sdk/lib/async/stream_impl.dart 285:7 [_add]
package:dart-sdk/lib/async/stream_controller.dart 808:19 [_sendData]
package:dart-sdk/lib/async/stream_controller.dart 682:7 [_add]
package:dart-sdk/lib/async/stream_controller.dart 624:5 add
package:dart-sdk/lib/async/zone.dart 1384:10 runUnaryGuarded
package:dart-sdk/lib/async/stream_impl.dart 357:11 [_sendData]
package:dart-sdk/lib/async/stream_impl.dart 285:7 [_add]
package:dart-sdk/lib/async/stream_controller.dart 808:19 [_sendData]
package:dart-sdk/lib/async/stream_controller.dart 682:7 [_add]
package:dart-sdk/lib/async/stream_controller.dart 624:5 add
package:dart-sdk/lib/async/stream_controller.dart 900:13 add
package:dart-sdk/lib/async/zone.dart 1384:10 runUnaryGuarded
package:dart-sdk/lib/async/stream_impl.dart 357:11 [_sendData]
package:dart-sdk/lib/async/stream_impl.dart 285:7 [_add]
package:dart-sdk/lib/async/stream_controller.dart 808:19 [_sendData]
package:dart-sdk/lib/async/stream_controller.dart 682:7 [_add]
package:dart-sdk/lib/async/stream_controller.dart 624:5 add
package:dart-sdk/lib/async/zone.dart 1384:10 runUnaryGuarded
package:dart-sdk/lib/async/stream_impl.dart 357:11 [_sendData]
package:dart-sdk/lib/async/stream_impl.dart 285:7 [_add]
package:dart-sdk/lib/async/stream_controller.dart 808:19 [_sendData]
package:dart-sdk/lib/async/stream_controller.dart 682:7 [_add]
package:dart-sdk/lib/async/stream_controller.dart 624:5 add
package:dart-sdk/lib/async/stream_controller.dart 900:13 add
package:stream_channel add
paragraph_test.dart.browser_test.dart 52:17 <fn>
package:dart-sdk/lib/_internal/js_dev_runtime/private/ddc_runtime/operations.dart 324:14 _checkAndCall
package:dart-sdk/lib/_internal/js_dev_runtime/private/ddc_runtime/operations.dart 329:39 dcall
package:dart-sdk/lib/html/dart2js/html_dart2js.dart 37188:58 <fn>
```
flutter doctor:
```
[β] Flutter (Channel master, 1.19.0-4.0.pre.42, on Mac OS X 10.15.4 19E287, locale en-US)
β’ Flutter version 1.19.0-4.0.pre.42 at /Users/katelovett/github/flutter
β’ Framework revision bc8d0f5706 (21 hours ago), 2020-07-06 15:57:59 -0700
β’ Engine revision f8bbcc396b
β’ Dart version 2.9.0 (build 2.9.0-20.0.dev c190fc3a31)
[β] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
β’ Android SDK at /Users/katelovett/Library/Android/sdk
β’ Platform android-28, build-tools 28.0.3
β’ Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
β’ Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1343-b01)
β’ All Android licenses accepted.
[β] Xcode - develop for iOS and macOS (Xcode 11.3.1)
β’ Xcode at /Applications/Xcode.app/Contents/Developer
β’ Xcode 11.3.1, Build version 11C505
β’ CocoaPods version 1.9.1
[β] Android Studio (version 3.4)
β’ Android Studio at /Applications/Android Studio.app/Contents
β’ Flutter plugin version 36.1.1
β’ Dart plugin version 183.6270
β’ Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1343-b01)
[β] VS Code (version 1.45.1)
β’ VS Code at /Applications/Visual Studio Code.app/Contents
β’ Flutter extension version 3.12.1
[β] Connected device (1 available)
β’ iPhone 11 Pro Max (mobile) β’ A8FFA716-A67B-4468-B92B-F2B61F2306A0 β’ ios β’ com.apple.CoreSimulator.SimRuntime.iOS-13-3
(simulator)
β’ No issues found!
```
|
a: tests,framework,a: typography,platform-web,P3,team-web,triaged-web
|
low
|
Critical
|
652,598,753 |
flutter
|
[Web] RenderParagraph.size broken tests
|
[Skip audit]
The following two tests are broken based on an incorrect result from RenderParagraph.size. RenderParagraph.maxLines appears to be related.
Test:
https://github.com/flutter/flutter/blob/8ed8b06ac5a1028e689d87592543880882a516da/packages/flutter/test/rendering/paragraph_test.dart#L96
Result:
```
03:35 +511 ~23 -4: /tmp/flutter sdk/packages/flutter/test/rendering/paragraph_test.dart: overflow test [E]
Expected: <30>
Actual: <20>
package:dart-sdk/lib/_internal/js_dev_runtime/private/ddc_runtime/errors.dart 214:49 throw_
package:test_api expect$
package:flutter_test/src/widget_tester.dart 369:3 expect$
paragraph_test.dart 130:5 <fn>
package:test_api <fn>
package:dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 45:50 <fn>
package:stack_trace <fn>
package:dart-sdk/lib/async/zone.dart 1198:47 _rootRunUnary
package:dart-sdk/lib/async/zone.dart 1100:19 runUnary
package:dart-sdk/lib/async/future_impl.dart 143:18 handleValue
package:dart-sdk/lib/async/future_impl.dart 696:44 handleValueCallback
package:dart-sdk/lib/async/future_impl.dart 725:32 _propagateToListeners
package:dart-sdk/lib/async/future_impl.dart 393:9 <fn>
package:stack_trace <fn>
package:dart-sdk/lib/async/zone.dart 1190:13 _rootRun
package:dart-sdk/lib/async/zone.dart 1093:19 run
package:dart-sdk/lib/async/zone.dart 997:7 runGuarded
package:dart-sdk/lib/async/zone.dart 1037:23 callback
package:dart-sdk/lib/async/schedule_microtask.dart 41:11 _microtaskLoop
package:dart-sdk/lib/async/schedule_microtask.dart 50:5 _startMicrotaskLoop
package:dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 166:15 <fn>
===== asynchronous gap ===========================
package:dart-sdk/lib/async/zone.dart 1121:19 registerUnaryCallback
package:dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 67:19 _async
package:test_api <fn>
package:dart-sdk/lib/async/zone.dart 1190:13 _rootRun
package:dart-sdk/lib/async/zone.dart 1093:19 run
package:dart-sdk/lib/async/zone.dart 1629:67 _runZoned
package:dart-sdk/lib/async/zone.dart 1550:10 runZoned
package:test_api <fn>
package:dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 84:54 runBody
package:dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 123:12 _async
package:test_api <fn>
package:dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 84:54 runBody
package:dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 123:12 _async
package:test_api <fn>
package:dart-sdk/lib/async/zone.dart 1190:13 _rootRun
package:dart-sdk/lib/async/zone.dart 1093:19 run
package:dart-sdk/lib/async/zone.dart 1629:67 _runZoned
package:dart-sdk/lib/async/zone.dart 1550:10 runZoned
package:test_api <fn>
package:dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 45:50 <fn>
package:stack_trace <fn>
package:dart-sdk/lib/async/zone.dart 1198:47 _rootRunUnary
package:dart-sdk/lib/async/zone.dart 1100:19 runUnary
package:dart-sdk/lib/async/future_impl.dart 143:18 handleValue
package:dart-sdk/lib/async/future_impl.dart 696:44 handleValueCallback
package:dart-sdk/lib/async/future_impl.dart 725:32 _propagateToListeners
package:dart-sdk/lib/async/future_impl.dart 519:7 [_complete]
package:dart-sdk/lib/async/future.dart 175:15 <fn>
package:stack_trace <fn>
package:dart-sdk/lib/async/zone.dart 1182:47 _rootRun
package:dart-sdk/lib/async/zone.dart 1093:19 run
package:dart-sdk/lib/async/zone.dart 997:7 runGuarded
package:dart-sdk/lib/async/zone.dart 1037:23 <fn>
package:stack_trace <fn>
package:dart-sdk/lib/async/zone.dart 1190:13 _rootRun
package:dart-sdk/lib/async/zone.dart 1093:19 run
package:dart-sdk/lib/async/zone.dart 1021:23 <fn>
package:dart-sdk/lib/_internal/js_dev_runtime/private/isolate_helper.dart 48:19 internalCallback
===== asynchronous gap ===========================
package:dart-sdk/lib/async/zone.dart 1121:19 registerUnaryCallback
package:dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 67:19 _async
package:test_api <fn>
package:dart-sdk/lib/async/zone.dart 1190:13 _rootRun
package:dart-sdk/lib/async/zone.dart 1093:19 run
package:dart-sdk/lib/async/zone.dart 1629:67 _runZoned
package:dart-sdk/lib/async/zone.dart 1550:10 runZoned
package:stack_trace <fn>
package:dart-sdk/lib/async/zone.dart 1190:13 _rootRun
package:dart-sdk/lib/async/zone.dart 1093:19 run
package:dart-sdk/lib/async/zone.dart 1629:67 _runZoned
package:dart-sdk/lib/async/zone.dart 1550:10 runZoned
package:test_api <fn>
package:dart-sdk/lib/async/zone.dart 1190:13 _rootRun
package:dart-sdk/lib/async/zone.dart 1093:19 run
package:dart-sdk/lib/async/zone.dart 1629:67 _runZoned
package:dart-sdk/lib/async/zone.dart 1550:10 runZoned
package:test_api <fn>
package:dart-sdk/lib/async/zone.dart 1198:47 _rootRunUnary
package:dart-sdk/lib/async/zone.dart 1100:19 runUnary
package:dart-sdk/lib/async/zone.dart 1005:7 runUnaryGuarded
package:dart-sdk/lib/async/stream_impl.dart 357:11 [_sendData]
package:dart-sdk/lib/async/stream_impl.dart 285:7 [_add]
package:dart-sdk/lib/async/stream_controller.dart 808:19 [_sendData]
package:dart-sdk/lib/async/stream_controller.dart 682:7 [_add]
package:dart-sdk/lib/async/stream_controller.dart 624:5 add
package:dart-sdk/lib/async/zone.dart 1206:13 _rootRunUnary
package:dart-sdk/lib/async/zone.dart 1100:19 runUnary
package:dart-sdk/lib/async/zone.dart 1005:7 runUnaryGuarded
package:dart-sdk/lib/async/stream_impl.dart 357:11 [_sendData]
package:dart-sdk/lib/async/stream_impl.dart 285:7 [_add]
package:dart-sdk/lib/async/stream_controller.dart 808:19 [_sendData]
package:dart-sdk/lib/async/stream_controller.dart 682:7 [_add]
package:dart-sdk/lib/async/stream_controller.dart 624:5 add
package:dart-sdk/lib/async/stream_controller.dart 900:13 add
package:stream_channel <fn>
package:dart-sdk/lib/async/zone.dart 1384:10 runUnaryGuarded
package:dart-sdk/lib/async/stream_impl.dart 357:11 [_sendData]
package:dart-sdk/lib/async/stream_impl.dart 285:7 [_add]
package:dart-sdk/lib/async/stream_controller.dart 808:19 [_sendData]
package:dart-sdk/lib/async/stream_controller.dart 682:7 [_add]
package:dart-sdk/lib/async/stream_controller.dart 624:5 add
package:dart-sdk/lib/async/zone.dart 1384:10 runUnaryGuarded
package:dart-sdk/lib/async/stream_impl.dart 357:11 [_sendData]
package:dart-sdk/lib/async/stream_impl.dart 285:7 [_add]
package:dart-sdk/lib/async/stream_controller.dart 808:19 [_sendData]
package:dart-sdk/lib/async/stream_controller.dart 682:7 [_add]
package:dart-sdk/lib/async/stream_controller.dart 624:5 add
package:dart-sdk/lib/async/stream_controller.dart 900:13 add
package:dart-sdk/lib/async/zone.dart 1384:10 runUnaryGuarded
package:dart-sdk/lib/async/stream_impl.dart 357:11 [_sendData]
package:dart-sdk/lib/async/stream_impl.dart 285:7 [_add]
package:dart-sdk/lib/async/stream_controller.dart 808:19 [_sendData]
package:dart-sdk/lib/async/stream_controller.dart 682:7 [_add]
package:dart-sdk/lib/async/stream_controller.dart 624:5 add
package:dart-sdk/lib/async/zone.dart 1384:10 runUnaryGuarded
package:dart-sdk/lib/async/stream_impl.dart 357:11 [_sendData]
package:dart-sdk/lib/async/stream_impl.dart 285:7 [_add]
package:dart-sdk/lib/async/stream_controller.dart 808:19 [_sendData]
package:dart-sdk/lib/async/stream_controller.dart 682:7 [_add]
package:dart-sdk/lib/async/stream_controller.dart 624:5 add
package:dart-sdk/lib/async/stream_controller.dart 900:13 add
package:stream_channel add
paragraph_test.dart.browser_test.dart 52:17 <fn>
package:dart-sdk/lib/_internal/js_dev_runtime/private/ddc_runtime/operations.dart 324:14 _checkAndCall
package:dart-sdk/lib/_internal/js_dev_runtime/private/ddc_runtime/operations.dart 329:39 dcall
package:dart-sdk/lib/html/dart2js/html_dart2js.dart 37188:58 <fn>
```
Test:
https://github.com/flutter/flutter/blob/8ed8b06ac5a1028e689d87592543880882a516da/packages/flutter/test/rendering/paragraph_test.dart#L172
Result:
```
03:35 +511 ~23 -5: /tmp/flutter sdk/packages/flutter/test/rendering/paragraph_test.dart: maxLines [E]
Expected: <130>
Actual: <132>
package:dart-sdk/lib/_internal/js_dev_runtime/private/ddc_runtime/errors.dart 214:49 throw_
package:test_api expect$
package:flutter_test/src/widget_tester.dart 369:3 expect$
paragraph_test.dart 187:5 <fn>
package:test_api <fn>
package:dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 45:50 <fn>
package:stack_trace <fn>
package:dart-sdk/lib/async/zone.dart 1198:47 _rootRunUnary
package:dart-sdk/lib/async/zone.dart 1100:19 runUnary
package:dart-sdk/lib/async/future_impl.dart 143:18 handleValue
package:dart-sdk/lib/async/future_impl.dart 696:44 handleValueCallback
package:dart-sdk/lib/async/future_impl.dart 725:32 _propagateToListeners
package:dart-sdk/lib/async/future_impl.dart 393:9 <fn>
package:stack_trace <fn>
package:dart-sdk/lib/async/zone.dart 1190:13 _rootRun
package:dart-sdk/lib/async/zone.dart 1093:19 run
package:dart-sdk/lib/async/zone.dart 997:7 runGuarded
package:dart-sdk/lib/async/zone.dart 1037:23 callback
package:dart-sdk/lib/async/schedule_microtask.dart 41:11 _microtaskLoop
package:dart-sdk/lib/async/schedule_microtask.dart 50:5 _startMicrotaskLoop
package:dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 166:15 <fn>
===== asynchronous gap ===========================
package:dart-sdk/lib/async/zone.dart 1121:19 registerUnaryCallback
package:dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 67:19 _async
package:test_api <fn>
package:dart-sdk/lib/async/zone.dart 1190:13 _rootRun
package:dart-sdk/lib/async/zone.dart 1093:19 run
package:dart-sdk/lib/async/zone.dart 1629:67 _runZoned
package:dart-sdk/lib/async/zone.dart 1550:10 runZoned
package:test_api <fn>
package:dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 84:54 runBody
package:dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 123:12 _async
package:test_api <fn>
package:dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 84:54 runBody
package:dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 123:12 _async
package:test_api <fn>
package:dart-sdk/lib/async/zone.dart 1190:13 _rootRun
package:dart-sdk/lib/async/zone.dart 1093:19 run
package:dart-sdk/lib/async/zone.dart 1629:67 _runZoned
package:dart-sdk/lib/async/zone.dart 1550:10 runZoned
package:test_api <fn>
package:dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 45:50 <fn>
package:stack_trace <fn>
package:dart-sdk/lib/async/zone.dart 1198:47 _rootRunUnary
package:dart-sdk/lib/async/zone.dart 1100:19 runUnary
package:dart-sdk/lib/async/future_impl.dart 143:18 handleValue
package:dart-sdk/lib/async/future_impl.dart 696:44 handleValueCallback
package:dart-sdk/lib/async/future_impl.dart 725:32 _propagateToListeners
package:dart-sdk/lib/async/future_impl.dart 519:7 [_complete]
package:dart-sdk/lib/async/future.dart 175:15 <fn>
package:stack_trace <fn>
package:dart-sdk/lib/async/zone.dart 1182:47 _rootRun
package:dart-sdk/lib/async/zone.dart 1093:19 run
package:dart-sdk/lib/async/zone.dart 997:7 runGuarded
package:dart-sdk/lib/async/zone.dart 1037:23 <fn>
package:stack_trace <fn>
package:dart-sdk/lib/async/zone.dart 1190:13 _rootRun
package:dart-sdk/lib/async/zone.dart 1093:19 run
package:dart-sdk/lib/async/zone.dart 1021:23 <fn>
package:dart-sdk/lib/_internal/js_dev_runtime/private/isolate_helper.dart 48:19 internalCallback
===== asynchronous gap ===========================
package:dart-sdk/lib/async/zone.dart 1121:19 registerUnaryCallback
package:dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 67:19 _async
package:test_api <fn>
package:dart-sdk/lib/async/zone.dart 1190:13 _rootRun
package:dart-sdk/lib/async/zone.dart 1093:19 run
package:dart-sdk/lib/async/zone.dart 1629:67 _runZoned
package:dart-sdk/lib/async/zone.dart 1550:10 runZoned
package:stack_trace <fn>
package:dart-sdk/lib/async/zone.dart 1190:13 _rootRun
package:dart-sdk/lib/async/zone.dart 1093:19 run
package:dart-sdk/lib/async/zone.dart 1629:67 _runZoned
package:dart-sdk/lib/async/zone.dart 1550:10 runZoned
package:test_api <fn>
package:dart-sdk/lib/async/zone.dart 1190:13 _rootRun
package:dart-sdk/lib/async/zone.dart 1093:19 run
package:dart-sdk/lib/async/zone.dart 1629:67 _runZoned
package:dart-sdk/lib/async/zone.dart 1550:10 runZoned
package:test_api <fn>
package:dart-sdk/lib/async/zone.dart 1198:47 _rootRunUnary
package:dart-sdk/lib/async/zone.dart 1100:19 runUnary
package:dart-sdk/lib/async/zone.dart 1005:7 runUnaryGuarded
package:dart-sdk/lib/async/stream_impl.dart 357:11 [_sendData]
package:dart-sdk/lib/async/stream_impl.dart 285:7 [_add]
package:dart-sdk/lib/async/stream_controller.dart 808:19 [_sendData]
package:dart-sdk/lib/async/stream_controller.dart 682:7 [_add]
package:dart-sdk/lib/async/stream_controller.dart 624:5 add
package:dart-sdk/lib/async/zone.dart 1206:13 _rootRunUnary
package:dart-sdk/lib/async/zone.dart 1100:19 runUnary
package:dart-sdk/lib/async/zone.dart 1005:7 runUnaryGuarded
package:dart-sdk/lib/async/stream_impl.dart 357:11 [_sendData]
package:dart-sdk/lib/async/stream_impl.dart 285:7 [_add]
package:dart-sdk/lib/async/stream_controller.dart 808:19 [_sendData]
package:dart-sdk/lib/async/stream_controller.dart 682:7 [_add]
package:dart-sdk/lib/async/stream_controller.dart 624:5 add
package:dart-sdk/lib/async/stream_controller.dart 900:13 add
package:stream_channel <fn>
package:dart-sdk/lib/async/zone.dart 1384:10 runUnaryGuarded
package:dart-sdk/lib/async/stream_impl.dart 357:11 [_sendData]
package:dart-sdk/lib/async/stream_impl.dart 285:7 [_add]
package:dart-sdk/lib/async/stream_controller.dart 808:19 [_sendData]
package:dart-sdk/lib/async/stream_controller.dart 682:7 [_add]
package:dart-sdk/lib/async/stream_controller.dart 624:5 add
package:dart-sdk/lib/async/zone.dart 1384:10 runUnaryGuarded
package:dart-sdk/lib/async/stream_impl.dart 357:11 [_sendData]
package:dart-sdk/lib/async/stream_impl.dart 285:7 [_add]
package:dart-sdk/lib/async/stream_controller.dart 808:19 [_sendData]
package:dart-sdk/lib/async/stream_controller.dart 682:7 [_add]
package:dart-sdk/lib/async/stream_controller.dart 624:5 add
package:dart-sdk/lib/async/stream_controller.dart 900:13 add
package:dart-sdk/lib/async/zone.dart 1384:10 runUnaryGuarded
package:dart-sdk/lib/async/stream_impl.dart 357:11 [_sendData]
package:dart-sdk/lib/async/stream_impl.dart 285:7 [_add]
package:dart-sdk/lib/async/stream_controller.dart 808:19 [_sendData]
package:dart-sdk/lib/async/stream_controller.dart 682:7 [_add]
package:dart-sdk/lib/async/stream_controller.dart 624:5 add
package:dart-sdk/lib/async/zone.dart 1384:10 runUnaryGuarded
package:dart-sdk/lib/async/stream_impl.dart 357:11 [_sendData]
package:dart-sdk/lib/async/stream_impl.dart 285:7 [_add]
package:dart-sdk/lib/async/stream_controller.dart 808:19 [_sendData]
package:dart-sdk/lib/async/stream_controller.dart 682:7 [_add]
package:dart-sdk/lib/async/stream_controller.dart 624:5 add
package:dart-sdk/lib/async/stream_controller.dart 900:13 add
package:stream_channel add
paragraph_test.dart.browser_test.dart 52:17 <fn>
package:dart-sdk/lib/_internal/js_dev_runtime/private/ddc_runtime/operations.dart 324:14 _checkAndCall
package:dart-sdk/lib/_internal/js_dev_runtime/private/ddc_runtime/operations.dart 329:39 dcall
package:dart-sdk/lib/html/dart2js/html_dart2js.dart 37188:58 <fn>
```
flutter doctor:
```
[β] Flutter (Channel master, 1.19.0-4.0.pre.42, on Mac OS X 10.15.4 19E287, locale en-US)
β’ Flutter version 1.19.0-4.0.pre.42 at /Users/katelovett/github/flutter
β’ Framework revision bc8d0f5706 (21 hours ago), 2020-07-06 15:57:59 -0700
β’ Engine revision f8bbcc396b
β’ Dart version 2.9.0 (build 2.9.0-20.0.dev c190fc3a31)
[β] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
β’ Android SDK at /Users/katelovett/Library/Android/sdk
β’ Platform android-28, build-tools 28.0.3
β’ Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
β’ Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1343-b01)
β’ All Android licenses accepted.
[β] Xcode - develop for iOS and macOS (Xcode 11.3.1)
β’ Xcode at /Applications/Xcode.app/Contents/Developer
β’ Xcode 11.3.1, Build version 11C505
β’ CocoaPods version 1.9.1
[β] Android Studio (version 3.4)
β’ Android Studio at /Applications/Android Studio.app/Contents
β’ Flutter plugin version 36.1.1
β’ Dart plugin version 183.6270
β’ Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1343-b01)
[β] VS Code (version 1.45.1)
β’ VS Code at /Applications/Visual Studio Code.app/Contents
β’ Flutter extension version 3.12.1
[β] Connected device (1 available)
β’ iPhone 11 Pro Max (mobile) β’ A8FFA716-A67B-4468-B92B-F2B61F2306A0 β’ ios β’ com.apple.CoreSimulator.SimRuntime.iOS-13-3
(simulator)
β’ No issues found!
```
|
a: tests,framework,a: typography,platform-web,P3,team-web,triaged-web
|
low
|
Critical
|
652,604,196 |
flutter
|
[Web] RenderParagraph fails to drawFrame in broken tests
|
[Skip audit]
The following tests break while laying out the RenderParagraph. They all have similar stack traces, including one below for the four of them.
Tests:
https://github.com/flutter/flutter/blob/8ed8b06ac5a1028e689d87592543880882a516da/packages/flutter/test/rendering/paragraph_test.dart#L331
https://github.com/flutter/flutter/blob/8ed8b06ac5a1028e689d87592543880882a516da/packages/flutter/test/rendering/paragraph_test.dart#L370
https://github.com/flutter/flutter/blob/8ed8b06ac5a1028e689d87592543880882a516da/packages/flutter/test/rendering/paragraph_test.dart#L423
https://github.com/flutter/flutter/blob/8ed8b06ac5a1028e689d87592543880882a516da/packages/flutter/test/rendering/paragraph_test.dart#L437
Result:
```
03:36 +514 ~23 -7: /tmp/flutter sdk/packages/flutter/test/rendering/paragraph_test.dart: inline widgets multiline test
Another exception was thrown: LateInitializationError: Field '_placeholderCount' has not been initialized.
Another exception was thrown: Assertion failed: file:///tmp/scratch_spaceDZSBBL/packages/flutter/src/rendering/box.dart:1696:12
Another exception was thrown: Assertion failed: file:///tmp/scratch_spaceDZSBBL/packages/flutter/src/rendering/shifted_box.dart:324:12
Another exception was thrown: LateInitializationError: Field '_placeholderCount' has not been initialized.
Another exception was thrown: Assertion failed: file:///tmp/scratch_spaceDZSBBL/packages/flutter/src/rendering/box.dart:1696:12
Another exception was thrown: Assertion failed: file:///tmp/scratch_spaceDZSBBL/packages/flutter/src/rendering/shifted_box.dart:324:12
03:36 +514 ~23 -8: /tmp/flutter sdk/packages/flutter/test/rendering/paragraph_test.dart: inline widgets multiline test [E]
Caught error while rendering frame. See preceding logs for details.
package:dart-sdk/lib/_internal/js_dev_runtime/private/ddc_runtime/errors.dart 214:49 throw_
package:test_api fail
rendering_tester.dart 123:11 drawFrame
rendering_tester.dart 188:12 pumpFrame
rendering_tester.dart 172:3 layout
paragraph_test.dart 399:5 <fn>
package:test_api <fn>
package:dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 45:50 <fn>
package:stack_trace <fn>
package:dart-sdk/lib/async/zone.dart 1198:47 _rootRunUnary
package:dart-sdk/lib/async/zone.dart 1100:19 runUnary
package:dart-sdk/lib/async/future_impl.dart 143:18 handleValue
package:dart-sdk/lib/async/future_impl.dart 696:44 handleValueCallback
package:dart-sdk/lib/async/future_impl.dart 725:32 _propagateToListeners
package:dart-sdk/lib/async/future_impl.dart 393:9 <fn>
package:stack_trace <fn>
package:dart-sdk/lib/async/zone.dart 1190:13 _rootRun
package:dart-sdk/lib/async/zone.dart 1093:19 run
package:dart-sdk/lib/async/zone.dart 997:7 runGuarded
package:dart-sdk/lib/async/zone.dart 1037:23 callback
package:dart-sdk/lib/async/schedule_microtask.dart 41:11 _microtaskLoop
package:dart-sdk/lib/async/schedule_microtask.dart 50:5 _startMicrotaskLoop
package:dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 166:15 <fn>
===== asynchronous gap ===========================
package:dart-sdk/lib/async/zone.dart 1121:19 registerUnaryCallback
package:dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 67:19 _async
package:test_api <fn>
package:dart-sdk/lib/async/zone.dart 1190:13 _rootRun
package:dart-sdk/lib/async/zone.dart 1093:19 run
package:dart-sdk/lib/async/zone.dart 1629:67 _runZoned
package:dart-sdk/lib/async/zone.dart 1550:10 runZoned
package:test_api <fn>
package:dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 84:54 runBody
package:dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 123:12 _async
package:test_api <fn>
package:dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 84:54 runBody
package:dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 123:12 _async
package:test_api <fn>
package:dart-sdk/lib/async/zone.dart 1190:13 _rootRun
package:dart-sdk/lib/async/zone.dart 1093:19 run
package:dart-sdk/lib/async/zone.dart 1629:67 _runZoned
package:dart-sdk/lib/async/zone.dart 1550:10 runZoned
package:test_api <fn>
package:dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 45:50 <fn>
package:stack_trace <fn>
package:dart-sdk/lib/async/zone.dart 1198:47 _rootRunUnary
package:dart-sdk/lib/async/zone.dart 1100:19 runUnary
package:dart-sdk/lib/async/future_impl.dart 143:18 handleValue
package:dart-sdk/lib/async/future_impl.dart 696:44 handleValueCallback
package:dart-sdk/lib/async/future_impl.dart 725:32 _propagateToListeners
package:dart-sdk/lib/async/future_impl.dart 519:7 [_complete]
package:dart-sdk/lib/async/future.dart 175:15 <fn>
package:stack_trace <fn>
package:dart-sdk/lib/async/zone.dart 1182:47 _rootRun
package:dart-sdk/lib/async/zone.dart 1093:19 run
package:dart-sdk/lib/async/zone.dart 997:7 runGuarded
package:dart-sdk/lib/async/zone.dart 1037:23 <fn>
package:stack_trace <fn>
package:dart-sdk/lib/async/zone.dart 1190:13 _rootRun
package:dart-sdk/lib/async/zone.dart 1093:19 run
package:dart-sdk/lib/async/zone.dart 1021:23 <fn>
package:dart-sdk/lib/_internal/js_dev_runtime/private/isolate_helper.dart 48:19 internalCallback
===== asynchronous gap ===========================
package:dart-sdk/lib/async/zone.dart 1121:19 registerUnaryCallback
package:dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 67:19 _async
package:test_api <fn>
package:dart-sdk/lib/async/zone.dart 1190:13 _rootRun
package:dart-sdk/lib/async/zone.dart 1093:19 run
package:dart-sdk/lib/async/zone.dart 1629:67 _runZoned
package:dart-sdk/lib/async/zone.dart 1550:10 runZoned
package:stack_trace <fn>
package:dart-sdk/lib/async/zone.dart 1190:13 _rootRun
package:dart-sdk/lib/async/zone.dart 1093:19 run
package:dart-sdk/lib/async/zone.dart 1629:67 _runZoned
package:dart-sdk/lib/async/zone.dart 1550:10 runZoned
package:test_api <fn>
package:dart-sdk/lib/async/zone.dart 1190:13 _rootRun
package:dart-sdk/lib/async/zone.dart 1093:19 run
package:dart-sdk/lib/async/zone.dart 1629:67 _runZoned
package:dart-sdk/lib/async/zone.dart 1550:10 runZoned
package:test_api <fn>
package:dart-sdk/lib/async/zone.dart 1198:47 _rootRunUnary
package:dart-sdk/lib/async/zone.dart 1100:19 runUnary
package:dart-sdk/lib/async/zone.dart 1005:7 runUnaryGuarded
package:dart-sdk/lib/async/stream_impl.dart 357:11 [_sendData]
package:dart-sdk/lib/async/stream_impl.dart 285:7 [_add]
package:dart-sdk/lib/async/stream_controller.dart 808:19 [_sendData]
package:dart-sdk/lib/async/stream_controller.dart 682:7 [_add]
package:dart-sdk/lib/async/stream_controller.dart 624:5 add
package:dart-sdk/lib/async/zone.dart 1206:13 _rootRunUnary
package:dart-sdk/lib/async/zone.dart 1100:19 runUnary
package:dart-sdk/lib/async/zone.dart 1005:7 runUnaryGuarded
package:dart-sdk/lib/async/stream_impl.dart 357:11 [_sendData]
package:dart-sdk/lib/async/stream_impl.dart 285:7 [_add]
package:dart-sdk/lib/async/stream_controller.dart 808:19 [_sendData]
package:dart-sdk/lib/async/stream_controller.dart 682:7 [_add]
package:dart-sdk/lib/async/stream_controller.dart 624:5 add
package:dart-sdk/lib/async/stream_controller.dart 900:13 add
package:stream_channel <fn>
package:dart-sdk/lib/async/zone.dart 1384:10 runUnaryGuarded
package:dart-sdk/lib/async/stream_impl.dart 357:11 [_sendData]
package:dart-sdk/lib/async/stream_impl.dart 285:7 [_add]
package:dart-sdk/lib/async/stream_controller.dart 808:19 [_sendData]
package:dart-sdk/lib/async/stream_controller.dart 682:7 [_add]
package:dart-sdk/lib/async/stream_controller.dart 624:5 add
package:dart-sdk/lib/async/zone.dart 1384:10 runUnaryGuarded
package:dart-sdk/lib/async/stream_impl.dart 357:11 [_sendData]
package:dart-sdk/lib/async/stream_impl.dart 285:7 [_add]
package:dart-sdk/lib/async/stream_controller.dart 808:19 [_sendData]
package:dart-sdk/lib/async/stream_controller.dart 682:7 [_add]
package:dart-sdk/lib/async/stream_controller.dart 624:5 add
package:dart-sdk/lib/async/stream_controller.dart 900:13 add
package:dart-sdk/lib/async/zone.dart 1384:10 runUnaryGuarded
package:dart-sdk/lib/async/stream_impl.dart 357:11 [_sendData]
package:dart-sdk/lib/async/stream_impl.dart 285:7 [_add]
package:dart-sdk/lib/async/stream_controller.dart 808:19 [_sendData]
package:dart-sdk/lib/async/stream_controller.dart 682:7 [_add]
package:dart-sdk/lib/async/stream_controller.dart 624:5 add
package:dart-sdk/lib/async/zone.dart 1384:10 runUnaryGuarded
package:dart-sdk/lib/async/stream_impl.dart 357:11 [_sendData]
package:dart-sdk/lib/async/stream_impl.dart 285:7 [_add]
package:dart-sdk/lib/async/stream_controller.dart 808:19 [_sendData]
package:dart-sdk/lib/async/stream_controller.dart 682:7 [_add]
package:dart-sdk/lib/async/stream_controller.dart 624:5 add
package:dart-sdk/lib/async/stream_controller.dart 900:13 add
package:stream_channel add
paragraph_test.dart.browser_test.dart 52:17 <fn>
package:dart-sdk/lib/_internal/js_dev_runtime/private/ddc_runtime/operations.dart 324:14 _checkAndCall
package:dart-sdk/lib/_internal/js_dev_runtime/private/ddc_runtime/operations.dart 329:39 dcall
package:dart-sdk/lib/html/dart2js/html_dart2js.dart 37188:58 <fn>
```
flutter doctor:
```
[β] Flutter (Channel master, 1.19.0-4.0.pre.42, on Mac OS X 10.15.4 19E287, locale en-US)
β’ Flutter version 1.19.0-4.0.pre.42 at /Users/katelovett/github/flutter
β’ Framework revision bc8d0f5706 (21 hours ago), 2020-07-06 15:57:59 -0700
β’ Engine revision f8bbcc396b
β’ Dart version 2.9.0 (build 2.9.0-20.0.dev c190fc3a31)
[β] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
β’ Android SDK at /Users/katelovett/Library/Android/sdk
β’ Platform android-28, build-tools 28.0.3
β’ Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
β’ Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1343-b01)
β’ All Android licenses accepted.
[β] Xcode - develop for iOS and macOS (Xcode 11.3.1)
β’ Xcode at /Applications/Xcode.app/Contents/Developer
β’ Xcode 11.3.1, Build version 11C505
β’ CocoaPods version 1.9.1
[β] Android Studio (version 3.4)
β’ Android Studio at /Applications/Android Studio.app/Contents
β’ Flutter plugin version 36.1.1
β’ Dart plugin version 183.6270
β’ Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1343-b01)
[β] VS Code (version 1.45.1)
β’ VS Code at /Applications/Visual Studio Code.app/Contents
β’ Flutter extension version 3.12.1
[β] Connected device (1 available)
β’ iPhone 11 Pro Max (mobile) β’ A8FFA716-A67B-4468-B92B-F2B61F2306A0 β’ ios β’ com.apple.CoreSimulator.SimRuntime.iOS-13-3
(simulator)
β’ No issues found!
```
|
a: tests,framework,a: typography,platform-web,P3,team-web,triaged-web
|
low
|
Critical
|
652,614,574 |
go
|
cmd/compile: unnecessary nil pointer check
|
```
package main
type T [8]byte
func f(p *T, i int) byte {
return p[i]
}
```
This code generates a nil pointer check on `p`.
```
0x000e 00014 (/Users/khr/gowork/tmp1.go:6) MOVQ "".p+32(SP), DX
0x0013 00019 (/Users/khr/gowork/tmp1.go:6) TESTB AL, (DX) <- nil pointer check
0x0015 00021 (/Users/khr/gowork/tmp1.go:6) MOVQ "".i+40(SP), AX
0x001a 00026 (/Users/khr/gowork/tmp1.go:6) NOP
0x0020 00032 (/Users/khr/gowork/tmp1.go:6) CMPQ AX, $8
0x0024 00036 (/Users/khr/gowork/tmp1.go:6) JCC 56 <- bounds check
0x0026 00038 (/Users/khr/gowork/tmp1.go:6) MOVBLZX (DX)(AX*1), AX
0x002a 00042 (/Users/khr/gowork/tmp1.go:6) MOVB AL, "".~r2+48(SP)
0x002e 00046 (/Users/khr/gowork/tmp1.go:6) MOVQ 16(SP), BP
0x0033 00051 (/Users/khr/gowork/tmp1.go:6) ADDQ $24, SP
0x0037 00055 (/Users/khr/gowork/tmp1.go:6) RET
```
We don't really need a nil pointer check, as the index is bounded by the bounds check.
We can subsume the nil pointer check into the load.
This would require the nil pointer pass to know that indexes are bounded for indexed loads, so it can prove that the load still occurs in the zero page even with the largest possible index.
Maybe we need to keep some information from the prove pass around somehow?
|
Performance,NeedsInvestigation,compiler/runtime
|
low
|
Minor
|
652,615,058 |
flutter
|
[Web] Key simulation does not work on web
|
[Skip audit]
Following up on this comment from skipped test:
https://github.com/flutter/flutter/blob/8ed8b06ac5a1028e689d87592543880882a516da/packages/flutter/test/rendering/editable_test.dart#L938
I wasn't able to find another issue referencing key simulation support for web.
This appears to affect these 4 skipped tests:
https://github.com/flutter/flutter/blob/8ed8b06ac5a1028e689d87592543880882a516da/packages/flutter/test/rendering/editable_test.dart#L891
https://github.com/flutter/flutter/blob/8ed8b06ac5a1028e689d87592543880882a516da/packages/flutter/test/rendering/editable_test.dart#L841
https://github.com/flutter/flutter/blob/8ed8b06ac5a1028e689d87592543880882a516da/packages/flutter/test/rendering/editable_test.dart#L791
https://github.com/flutter/flutter/blob/8ed8b06ac5a1028e689d87592543880882a516da/packages/flutter/test/rendering/editable_test.dart#L742
Result:
```
02:26 +228 ~5 -6: /tmp/flutter sdk/packages/flutter/test/rendering/editable_test.dart: arrow keys and delete handle grapheme clusters correctly [E]
NoSuchMethodError: invalid member on null: 'isCollapsed'
editable_test.dart 876:28 <fn>
package:dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 45:50 <fn>
package:stack_trace <fn>
package:dart-sdk/lib/async/zone.dart 1198:47 _rootRunUnary
package:dart-sdk/lib/async/zone.dart 1100:19 runUnary
package:dart-sdk/lib/async/future_impl.dart 143:18 handleValue
package:dart-sdk/lib/async/future_impl.dart 696:44 handleValueCallback
package:dart-sdk/lib/async/future_impl.dart 725:32 _propagateToListeners
package:dart-sdk/lib/async/future_impl.dart 529:5 [_completeWithValue]
package:dart-sdk/lib/async/future_impl.dart 567:7 <fn>
package:stack_trace <fn>
package:dart-sdk/lib/async/zone.dart 1190:13 _rootRun
package:dart-sdk/lib/async/zone.dart 1093:19 run
package:dart-sdk/lib/async/zone.dart 997:7 runGuarded
package:dart-sdk/lib/async/zone.dart 1037:23 callback
package:dart-sdk/lib/async/schedule_microtask.dart 41:11 _microtaskLoop
package:dart-sdk/lib/async/schedule_microtask.dart 50:5 _startMicrotaskLoop
package:dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 166:15 <fn>
===== asynchronous gap ===========================
package:dart-sdk/lib/async/zone.dart 1121:19 registerUnaryCallback
package:dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 67:19 _async
editable_test.dart 841:68 <fn>
package:test_api <fn>
package:dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 45:50 <fn>
package:stack_trace <fn>
package:dart-sdk/lib/async/zone.dart 1198:47 _rootRunUnary
package:dart-sdk/lib/async/zone.dart 1100:19 runUnary
package:dart-sdk/lib/async/future_impl.dart 143:18 handleValue
package:dart-sdk/lib/async/future_impl.dart 696:44 handleValueCallback
package:dart-sdk/lib/async/future_impl.dart 725:32 _propagateToListeners
package:dart-sdk/lib/async/future_impl.dart 393:9 <fn>
package:stack_trace <fn>
package:dart-sdk/lib/async/zone.dart 1190:13 _rootRun
package:dart-sdk/lib/async/zone.dart 1093:19 run
package:dart-sdk/lib/async/zone.dart 997:7 runGuarded
package:dart-sdk/lib/async/zone.dart 1037:23 callback
package:dart-sdk/lib/async/schedule_microtask.dart 41:11 _microtaskLoop
package:dart-sdk/lib/async/schedule_microtask.dart 50:5 _startMicrotaskLoop
package:dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 166:15 <fn>
===== asynchronous gap ===========================
package:dart-sdk/lib/async/zone.dart 1121:19 registerUnaryCallback
package:dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 67:19 _async
package:test_api <fn>
package:dart-sdk/lib/async/zone.dart 1190:13 _rootRun
package:dart-sdk/lib/async/zone.dart 1093:19 run
package:dart-sdk/lib/async/zone.dart 1629:67 _runZoned
package:dart-sdk/lib/async/zone.dart 1550:10 runZoned
package:test_api <fn>
package:dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 84:54 runBody
package:dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 123:12 _async
package:test_api <fn>
package:dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 84:54 runBody
package:dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 123:12 _async
package:test_api <fn>
package:dart-sdk/lib/async/zone.dart 1190:13 _rootRun
package:dart-sdk/lib/async/zone.dart 1093:19 run
package:dart-sdk/lib/async/zone.dart 1629:67 _runZoned
package:dart-sdk/lib/async/zone.dart 1550:10 runZoned
package:test_api <fn>
package:dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 45:50 <fn>
package:stack_trace <fn>
package:dart-sdk/lib/async/zone.dart 1198:47 _rootRunUnary
package:dart-sdk/lib/async/zone.dart 1100:19 runUnary
package:dart-sdk/lib/async/future_impl.dart 143:18 handleValue
package:dart-sdk/lib/async/future_impl.dart 696:44 handleValueCallback
package:dart-sdk/lib/async/future_impl.dart 725:32 _propagateToListeners
package:dart-sdk/lib/async/future_impl.dart 519:7 [_complete]
package:dart-sdk/lib/async/future.dart 175:15 <fn>
package:stack_trace <fn>
package:dart-sdk/lib/async/zone.dart 1182:47 _rootRun
package:dart-sdk/lib/async/zone.dart 1093:19 run
package:dart-sdk/lib/async/zone.dart 997:7 runGuarded
package:dart-sdk/lib/async/zone.dart 1037:23 <fn>
package:stack_trace <fn>
package:dart-sdk/lib/async/zone.dart 1190:13 _rootRun
package:dart-sdk/lib/async/zone.dart 1093:19 run
package:dart-sdk/lib/async/zone.dart 1021:23 <fn>
package:dart-sdk/lib/_internal/js_dev_runtime/private/isolate_helper.dart 48:19 internalCallback
===== asynchronous gap ===========================
package:dart-sdk/lib/async/zone.dart 1121:19 registerUnaryCallback
package:dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 67:19 _async
package:test_api <fn>
package:dart-sdk/lib/async/zone.dart 1190:13 _rootRun
package:dart-sdk/lib/async/zone.dart 1093:19 run
package:dart-sdk/lib/async/zone.dart 1629:67 _runZoned
package:dart-sdk/lib/async/zone.dart 1550:10 runZoned
package:stack_trace <fn>
package:dart-sdk/lib/async/zone.dart 1190:13 _rootRun
package:dart-sdk/lib/async/zone.dart 1093:19 run
package:dart-sdk/lib/async/zone.dart 1629:67 _runZoned
package:dart-sdk/lib/async/zone.dart 1550:10 runZoned
package:test_api <fn>
package:dart-sdk/lib/async/zone.dart 1190:13 _rootRun
package:dart-sdk/lib/async/zone.dart 1093:19 run
package:dart-sdk/lib/async/zone.dart 1629:67 _runZoned
package:dart-sdk/lib/async/zone.dart 1550:10 runZoned
package:test_api <fn>
package:dart-sdk/lib/async/zone.dart 1198:47 _rootRunUnary
package:dart-sdk/lib/async/zone.dart 1100:19 runUnary
package:dart-sdk/lib/async/zone.dart 1005:7 runUnaryGuarded
package:dart-sdk/lib/async/stream_impl.dart 357:11 [_sendData]
package:dart-sdk/lib/async/stream_impl.dart 285:7 [_add]
package:dart-sdk/lib/async/stream_controller.dart 808:19 [_sendData]
package:dart-sdk/lib/async/stream_controller.dart 682:7 [_add]
package:dart-sdk/lib/async/stream_controller.dart 624:5 add
package:dart-sdk/lib/async/zone.dart 1206:13 _rootRunUnary
package:dart-sdk/lib/async/zone.dart 1100:19 runUnary
package:dart-sdk/lib/async/zone.dart 1005:7 runUnaryGuarded
package:dart-sdk/lib/async/stream_impl.dart 357:11 [_sendData]
package:dart-sdk/lib/async/stream_impl.dart 285:7 [_add]
package:dart-sdk/lib/async/stream_controller.dart 808:19 [_sendData]
package:dart-sdk/lib/async/stream_controller.dart 682:7 [_add]
package:dart-sdk/lib/async/stream_controller.dart 624:5 add
package:dart-sdk/lib/async/stream_controller.dart 900:13 add
package:stream_channel <fn>
package:dart-sdk/lib/async/zone.dart 1384:10 runUnaryGuarded
package:dart-sdk/lib/async/stream_impl.dart 357:11 [_sendData]
package:dart-sdk/lib/async/stream_impl.dart 285:7 [_add]
package:dart-sdk/lib/async/stream_controller.dart 808:19 [_sendData]
package:dart-sdk/lib/async/stream_controller.dart 682:7 [_add]
package:dart-sdk/lib/async/stream_controller.dart 624:5 add
package:dart-sdk/lib/async/zone.dart 1384:10 runUnaryGuarded
package:dart-sdk/lib/async/stream_impl.dart 357:11 [_sendData]
package:dart-sdk/lib/async/stream_impl.dart 285:7 [_add]
package:dart-sdk/lib/async/stream_controller.dart 808:19 [_sendData]
package:dart-sdk/lib/async/stream_controller.dart 682:7 [_add]
package:dart-sdk/lib/async/stream_controller.dart 624:5 add
package:dart-sdk/lib/async/stream_controller.dart 900:13 add
package:dart-sdk/lib/async/zone.dart 1384:10 runUnaryGuarded
package:dart-sdk/lib/async/stream_impl.dart 357:11 [_sendData]
package:dart-sdk/lib/async/stream_impl.dart 285:7 [_add]
package:dart-sdk/lib/async/stream_controller.dart 808:19 [_sendData]
package:dart-sdk/lib/async/stream_controller.dart 682:7 [_add]
package:dart-sdk/lib/async/stream_controller.dart 624:5 add
package:dart-sdk/lib/async/zone.dart 1384:10 runUnaryGuarded
package:dart-sdk/lib/async/stream_impl.dart 357:11 [_sendData]
package:dart-sdk/lib/async/stream_impl.dart 285:7 [_add]
package:dart-sdk/lib/async/stream_controller.dart 808:19 [_sendData]
package:dart-sdk/lib/async/stream_controller.dart 682:7 [_add]
package:dart-sdk/lib/async/stream_controller.dart 624:5 add
package:dart-sdk/lib/async/stream_controller.dart 900:13 add
package:stream_channel add
editable_test.dart.browser_test.dart 52:17 <fn>
package:dart-sdk/lib/_internal/js_dev_runtime/private/ddc_runtime/operations.dart 324:14 _checkAndCall
package:dart-sdk/lib/_internal/js_dev_runtime/private/ddc_runtime/operations.dart 329:39 dcall
package:dart-sdk/lib/html/dart2js/html_dart2js.dart 37188:58 <fn>
```
flutter doctor
```
[β] Flutter (Channel master, 1.19.0-4.0.pre.42, on Mac OS X 10.15.4 19E287, locale en-US)
β’ Flutter version 1.19.0-4.0.pre.42 at /Users/katelovett/github/flutter
β’ Framework revision bc8d0f5706 (21 hours ago), 2020-07-06 15:57:59 -0700
β’ Engine revision f8bbcc396b
β’ Dart version 2.9.0 (build 2.9.0-20.0.dev c190fc3a31)
[β] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
β’ Android SDK at /Users/katelovett/Library/Android/sdk
β’ Platform android-28, build-tools 28.0.3
β’ Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
β’ Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1343-b01)
β’ All Android licenses accepted.
[β] Xcode - develop for iOS and macOS (Xcode 11.3.1)
β’ Xcode at /Applications/Xcode.app/Contents/Developer
β’ Xcode 11.3.1, Build version 11C505
β’ CocoaPods version 1.9.1
[β] Android Studio (version 3.4)
β’ Android Studio at /Applications/Android Studio.app/Contents
β’ Flutter plugin version 36.1.1
β’ Dart plugin version 183.6270
β’ Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1343-b01)
[β] VS Code (version 1.45.1)
β’ VS Code at /Applications/Visual Studio Code.app/Contents
β’ Flutter extension version 3.12.1
[β] Connected device (1 available)
β’ iPhone 11 Pro Max (mobile) β’ A8FFA716-A67B-4468-B92B-F2B61F2306A0 β’ ios β’ com.apple.CoreSimulator.SimRuntime.iOS-13-3
(simulator)
β’ No issues found!
```
|
a: tests,a: text input,team,framework,platform-web,P3,c: tech-debt,team: skip-test,team-web,triaged-web
|
low
|
Critical
|
652,618,415 |
flutter
|
Support motionEventIds in android_view test
|
a: tests,engine,a: platform-views,P2,team-engine,triaged-engine
|
low
|
Minor
|
|
652,657,408 |
flutter
|
[Web] RawKeyEvent valid assertion broken in tests
|
[Skip Audit]
These two tests are broken for web. They should assert due to invalid unicodeScalarValues.
Tests:
https://github.com/flutter/flutter/blob/8ed8b06ac5a1028e689d87592543880882a516da/packages/flutter/test/services/raw_keyboard_test.dart#L1100
https://github.com/flutter/flutter/blob/8ed8b06ac5a1028e689d87592543880882a516da/packages/flutter/test/services/raw_keyboard_test.dart#L1283
Result:
```
01:55 +232 -8: /tmp/flutter sdk/packages/flutter/test/services/raw_keyboard_test.dart: RawKeyEventDataLinux-GTK Code points with more than three Unicode scalar values are not allowed [E]
Expected: throws <Instance of 'AssertionError'>
Actual: <Closure: () => void from: () => _createFailingKey()>
Which: returned <null>
package:dart-sdk/lib/_internal/js_dev_runtime/private/ddc_runtime/errors.dart 214:49 throw_
package:test_api expect$
package:flutter_test/src/widget_tester.dart 369:3 expect$
raw_keyboard_test.dart 1299:7 <fn>
package:test_api <fn>
package:dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 45:50 <fn>
package:stack_trace <fn>
package:dart-sdk/lib/async/zone.dart 1198:47 _rootRunUnary
package:dart-sdk/lib/async/zone.dart 1100:19 runUnary
package:dart-sdk/lib/async/future_impl.dart 143:18 handleValue
package:dart-sdk/lib/async/future_impl.dart 696:44 handleValueCallback
package:dart-sdk/lib/async/future_impl.dart 725:32 _propagateToListeners
package:dart-sdk/lib/async/future_impl.dart 393:9 <fn>
package:stack_trace <fn>
package:dart-sdk/lib/async/zone.dart 1190:13 _rootRun
package:dart-sdk/lib/async/zone.dart 1093:19 run
package:dart-sdk/lib/async/zone.dart 997:7 runGuarded
package:dart-sdk/lib/async/zone.dart 1037:23 callback
package:dart-sdk/lib/async/schedule_microtask.dart 41:11 _microtaskLoop
package:dart-sdk/lib/async/schedule_microtask.dart 50:5 _startMicrotaskLoop
package:dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 166:15 <fn>
===== asynchronous gap ===========================
package:dart-sdk/lib/async/zone.dart 1121:19 registerUnaryCallback
package:dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 67:19 _async
package:test_api <fn>
package:dart-sdk/lib/async/zone.dart 1190:13 _rootRun
package:dart-sdk/lib/async/zone.dart 1093:19 run
package:dart-sdk/lib/async/zone.dart 1629:67 _runZoned
package:dart-sdk/lib/async/zone.dart 1550:10 runZoned
package:test_api <fn>
package:dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 84:54 runBody
package:dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 123:12 _async
package:test_api <fn>
package:dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 84:54 runBody
package:dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 123:12 _async
package:test_api <fn>
package:dart-sdk/lib/async/zone.dart 1190:13 _rootRun
package:dart-sdk/lib/async/zone.dart 1093:19 run
package:dart-sdk/lib/async/zone.dart 1629:67 _runZoned
package:dart-sdk/lib/async/zone.dart 1550:10 runZoned
package:test_api <fn>
package:dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 45:50 <fn>
package:stack_trace <fn>
package:dart-sdk/lib/async/zone.dart 1198:47 _rootRunUnary
package:dart-sdk/lib/async/zone.dart 1100:19 runUnary
package:dart-sdk/lib/async/future_impl.dart 143:18 handleValue
package:dart-sdk/lib/async/future_impl.dart 696:44 handleValueCallback
package:dart-sdk/lib/async/future_impl.dart 725:32 _propagateToListeners
package:dart-sdk/lib/async/future_impl.dart 519:7 [_complete]
package:dart-sdk/lib/async/future.dart 175:15 <fn>
package:stack_trace <fn>
package:dart-sdk/lib/async/zone.dart 1182:47 _rootRun
package:dart-sdk/lib/async/zone.dart 1093:19 run
package:dart-sdk/lib/async/zone.dart 997:7 runGuarded
package:dart-sdk/lib/async/zone.dart 1037:23 <fn>
package:stack_trace <fn>
package:dart-sdk/lib/async/zone.dart 1190:13 _rootRun
package:dart-sdk/lib/async/zone.dart 1093:19 run
package:dart-sdk/lib/async/zone.dart 1021:23 <fn>
package:dart-sdk/lib/_internal/js_dev_runtime/private/isolate_helper.dart 48:19 internalCallback
===== asynchronous gap ===========================
package:dart-sdk/lib/async/zone.dart 1121:19 registerUnaryCallback
package:dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 67:19 _async
package:test_api <fn>
package:dart-sdk/lib/async/zone.dart 1190:13 _rootRun
package:dart-sdk/lib/async/zone.dart 1093:19 run
package:dart-sdk/lib/async/zone.dart 1629:67 _runZoned
package:dart-sdk/lib/async/zone.dart 1550:10 runZoned
package:stack_trace <fn>
package:dart-sdk/lib/async/zone.dart 1190:13 _rootRun
package:dart-sdk/lib/async/zone.dart 1093:19 run
package:dart-sdk/lib/async/zone.dart 1629:67 _runZoned
package:dart-sdk/lib/async/zone.dart 1550:10 runZoned
package:test_api <fn>
package:dart-sdk/lib/async/zone.dart 1190:13 _rootRun
package:dart-sdk/lib/async/zone.dart 1093:19 run
package:dart-sdk/lib/async/zone.dart 1629:67 _runZoned
package:dart-sdk/lib/async/zone.dart 1550:10 runZoned
package:test_api <fn>
package:dart-sdk/lib/async/zone.dart 1198:47 _rootRunUnary
package:dart-sdk/lib/async/zone.dart 1100:19 runUnary
package:dart-sdk/lib/async/zone.dart 1005:7 runUnaryGuarded
package:dart-sdk/lib/async/stream_impl.dart 357:11 [_sendData]
package:dart-sdk/lib/async/stream_impl.dart 285:7 [_add]
package:dart-sdk/lib/async/stream_controller.dart 808:19 [_sendData]
package:dart-sdk/lib/async/stream_controller.dart 682:7 [_add]
package:dart-sdk/lib/async/stream_controller.dart 624:5 add
package:dart-sdk/lib/async/zone.dart 1206:13 _rootRunUnary
package:dart-sdk/lib/async/zone.dart 1100:19 runUnary
package:dart-sdk/lib/async/zone.dart 1005:7 runUnaryGuarded
package:dart-sdk/lib/async/stream_impl.dart 357:11 [_sendData]
package:dart-sdk/lib/async/stream_impl.dart 285:7 [_add]
package:dart-sdk/lib/async/stream_controller.dart 808:19 [_sendData]
package:dart-sdk/lib/async/stream_controller.dart 682:7 [_add]
package:dart-sdk/lib/async/stream_controller.dart 624:5 add
package:dart-sdk/lib/async/stream_controller.dart 900:13 add
package:stream_channel <fn>
package:dart-sdk/lib/async/zone.dart 1384:10 runUnaryGuarded
package:dart-sdk/lib/async/stream_impl.dart 357:11 [_sendData]
package:dart-sdk/lib/async/stream_impl.dart 285:7 [_add]
package:dart-sdk/lib/async/stream_controller.dart 808:19 [_sendData]
package:dart-sdk/lib/async/stream_controller.dart 682:7 [_add]
package:dart-sdk/lib/async/stream_controller.dart 624:5 add
package:dart-sdk/lib/async/zone.dart 1384:10 runUnaryGuarded
package:dart-sdk/lib/async/stream_impl.dart 357:11 [_sendData]
package:dart-sdk/lib/async/stream_impl.dart 285:7 [_add]
package:dart-sdk/lib/async/stream_controller.dart 808:19 [_sendData]
package:dart-sdk/lib/async/stream_controller.dart 682:7 [_add]
package:dart-sdk/lib/async/stream_controller.dart 624:5 add
package:dart-sdk/lib/async/stream_controller.dart 900:13 add
package:dart-sdk/lib/async/zone.dart 1384:10 runUnaryGuarded
package:dart-sdk/lib/async/stream_impl.dart 357:11 [_sendData]
package:dart-sdk/lib/async/stream_impl.dart 285:7 [_add]
package:dart-sdk/lib/async/stream_controller.dart 808:19 [_sendData]
package:dart-sdk/lib/async/stream_controller.dart 682:7 [_add]
package:dart-sdk/lib/async/stream_controller.dart 624:5 add
package:dart-sdk/lib/async/zone.dart 1384:10 runUnaryGuarded
package:dart-sdk/lib/async/stream_impl.dart 357:11 [_sendData]
package:dart-sdk/lib/async/stream_impl.dart 285:7 [_add]
package:dart-sdk/lib/async/stream_controller.dart 808:19 [_sendData]
package:dart-sdk/lib/async/stream_controller.dart 682:7 [_add]
package:dart-sdk/lib/async/stream_controller.dart 624:5 add
package:dart-sdk/lib/async/stream_controller.dart 900:13 add
package:stream_channel add
raw_keyboard_test.dart.browser_test.dart 52:17 <fn>
package:dart-sdk/lib/_internal/js_dev_runtime/private/ddc_runtime/operations.dart 324:14 _checkAndCall
package:dart-sdk/lib/_internal/js_dev_runtime/private/ddc_runtime/operations.dart 329:39 dcall
package:dart-sdk/lib/html/dart2js/html_dart2js.dart 37188:58 <fn>
```
flutter doctor:
```
[β] Flutter (Channel master, 1.20.0-3.0.pre.140, on Mac OS X 10.15.4 19E287, locale en-US)
β’ Flutter version 1.20.0-3.0.pre.140 at /Users/katelovett/github/flutter
β’ Framework revision 71632cfb72 (18 minutes ago), 2020-07-07 14:05:01 -0700
β’ Engine revision f22ac9da9c
β’ Dart version 2.9.0 (build 2.9.0-20.0.dev 69aba23371)
[β] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
β’ Android SDK at /Users/katelovett/Library/Android/sdk
β’ Platform android-28, build-tools 28.0.3
β’ Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
β’ Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1343-b01)
β’ All Android licenses accepted.
[β] Xcode - develop for iOS and macOS (Xcode 11.3.1)
β’ Xcode at /Applications/Xcode.app/Contents/Developer
β’ Xcode 11.3.1, Build version 11C505
β’ CocoaPods version 1.9.1
[β] Android Studio (version 3.4)
β’ Android Studio at /Applications/Android Studio.app/Contents
β’ Flutter plugin version 36.1.1
β’ Dart plugin version 183.6270
β’ Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1343-b01)
[β] VS Code (version 1.45.1)
β’ VS Code at /Applications/Visual Studio Code.app/Contents
β’ Flutter extension version 3.12.1
[β] Connected device (1 available)
β’ iPhone 11 Pro Max (mobile) β’ A8FFA716-A67B-4468-B92B-F2B61F2306A0 β’ ios β’ com.apple.CoreSimulator.SimRuntime.iOS-13-3
(simulator)
β’ No issues found!
```
|
a: tests,a: text input,team,framework,platform-web,P3,c: tech-debt,team: skip-test,team-web,triaged-web
|
low
|
Critical
|
652,664,013 |
go
|
x/net/html: doesnt support attributes without values ie <script async "foo.js">
|
<!--
Please answer these questions before submitting your issue. Thanks!
For questions please use one of our forums: https://github.com/golang/go/wiki/Questions
-->
### What version of Go are you using (`go version`)?
<pre>
$ go version
go version go1.14.4 windows/amd64
</pre>
### Does this issue reproduce with the latest release?
yes
### What operating system and processor architecture are you using (`go env`)?
<details><summary><code>go env</code> Output</summary><br><pre>
$ go env
set GO111MODULE=
set GOARCH=amd64
set GOBIN=
set GOCACHE=C:\Users\rhaksi\AppData\Local\go-build
set GOENV=C:\Users\rhaksi\AppData\Roaming\go\env
set GOEXE=.exe
set GOFLAGS=
set GOHOSTARCH=amd64
set GOHOSTOS=windows
set GOINSECURE=
set GONOPROXY=
set GONOSUMDB=
set GOOS=windows
set GOPATH=C:\Users\rhaksi\go
set GOPRIVATE=
set GOPROXY=https://proxy.golang.org,direct
set GOROOT=c:\go
set GOSUMDB=sum.golang.org
set GOTMPDIR=
set GOTOOLDIR=c:\go\pkg\tool\windows_amd64
set GCCGO=gccgo
set AR=ar
set CC=gcc
set CXX=g++
set CGO_ENABLED=1
set GOMOD=C:\dev\bitbucket\kidoz-team\bidder-server\go.mod
set CGO_CFLAGS=-g -O2
set CGO_CPPFLAGS=
set CGO_CXXFLAGS=-g -O2
set CGO_FFLAGS=-g -O2
set CGO_LDFLAGS=-g -O2
set PKG_CONFIG=pkg-config
set GOGCCFLAGS=-m64 -mthreads -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=C:\Users\rhaksi\AppData\Local\Temp\go-build383668822=/tmp/go-build -gno-record-gcc-switches
</pre></details>
### What did you do?
```
markup := `<!DOCTYPE html>
<html>
<head>
<title>.</title>
</head>
<body>
<script async src="test.js"></script>
</body>
</html>
`
r := strings.NewReader(markup)
doc, err := html.Parse(r)
if err != nil {
return
}
var writer bytes.Buffer
err = html.Render(&writer, doc)
if err != nil {
return
}
fmt.Println(writer.String())
```
<!--
If possible, provide a recipe for reproducing the error.
A complete runnable program is good.
A link on play.golang.org is best.
-->
### What did you expect to see?
The async attribute should have no value.
```
<html>
<head>
<title>.</title>
</head>
<body>
<script async src="test.js"></script>
</body>
</html>
```
### What did you see instead?
The async attribute is rendered with an extra ="" added to it.
```
<html>
<head>
<title>.</title>
</head>
<body>
<script async="" src="test.js"></script>
</body>
</html>
```
async is one of the 25 boolean attributes, it should be either present (value of true) or absent (value of false), and shouldnt have a value assigned.
```
The Boolean Attributes
allowfullscreen
allowpaymentrequest
async
autofocus
autoplay
checked
controls
default
disabled
formnovalidate
hidden
ismap
itemscope
loop
multiple
muted
nomodule
novalidate
open
playsinline
readonly
required
reversed
selected
truespeed
```
|
NeedsInvestigation
|
low
|
Critical
|
652,677,095 |
kubernetes
|
dnsConfig applies RFC-1123 too broadly to searches
|
<!-- Please only use this template for submitting enhancement requests -->
**What would you like to be added**:
RFC-1123 defines restrictions to host names. In Kubernetes, these restrictions are also
applied to object names.
However, for search strings in dnsConfig, names that are perfectly valid according
to [RFC 2181 Section 11](https://tools.ietf.org/html/rfc2181#section-11) are rejected.
An example of this is using underscores in a subdomain:
```yaml
apiVersion: v1
kind: Pod
metadata:
namespace: default
name: dns-example
spec:
containers:
- name: test
image: nginx
dnsPolicy: "None"
dnsConfig:
nameservers:
- 1.2.3.4
searches:
- abc_d.example.com
```
Since this is specifying a DNS search string specifically and not the name of an object
in Kubernetes, it seems like this check could be relaxed to allow names that comply with RFC 2181.
Instead this gives the following error:
```
The Pod "dns-example" is invalid: spec.dnsConfig.searches[0]: Invalid value: "abc_d.example.com": a DNS-1123 subdomain must consist of lower case alphanumeric characters, '-' or '.', and must start and end with an alphanumeric character (e.g. 'example.com', regex used for validation is '[a-z0-9]([-a-z0-9]*[a-z0-9])?(\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*')
```
**Why is this needed**:
Workloads that rely on short names can take time to change, which is why the dnsConfig is useful. However, in our case most of the names we need in the search have an underscore. Our current work-around is to re-write resolv.conf from inside the pod.
|
sig/network,kind/feature,triage/accepted
|
medium
|
Critical
|
652,712,832 |
pytorch
|
max_pool2d always compute indices even when it's not required
|
https://github.com/pytorch/pytorch/blob/bdc00196d1b63a339a5b9b6aaec44cefe069a6ea/aten/src/ATen/native/Pooling.cpp#L145-L147
Proposed fix by @albanD :
- if the user explicitly calls, it, they must have a good reason to ask for the indices.
- If they call `torch.max_pool2d`, then in the implementation of this in "ATen/native/Pooling.cpp", we should only use "max_pool2d_with_indices" if the input requires grad. (and add a new kernel that does not return the indices to use in the other case)
cc @albanD @mruberry
|
module: nn,triaged,enhancement,module: pooling
|
low
|
Minor
|
652,719,255 |
pytorch
|
DDP should provide an option for not touching grad of locally unused params
|
## π Bug
<!-- A clear and concise description of what the bug is. -->
For multi task training with different ranks running different tasks, parameters of inactive tasks are unused locally, even though used globally. By default DDP would allreduce these parameters and update all with the mean of grad across all ranks. Such grad update could trigger the weight decay with some optimizers (such as SGD) even for those inactive tasks on rank. Such weight update would propagate to ranks running active tasks and eventually pollute the grad there.
## To Reproduce
Steps to reproduce the behavior:
1. Have two ranks R1 and R2. Both of them load the same model.
1. R1 runs task A branch and R2 runs task B branch.
1. After the first iteration, we would see B's grad on R1 and A's grad on R2 get updated.
<!-- If you have a code sample, error messages, stack traces, please provide it here as well -->
## Expected behavior
<!-- A clear and concise description of what you expected to happen. -->
B's grad on R1 and A's grad on R2 should never get updated as task B is inactive on R1 and task A is inactive on R2.
cc @pietern @mrshenli @pritamdamania87 @zhaojuanmao @satgera @rohan-varma @gqchen @aazzolini @xush6528 @osalpekar @jiayisuse @agolynski
|
oncall: distributed,feature,triaged
|
medium
|
Critical
|
652,735,479 |
flutter
|
Don't strip binaries in unoptimized modes.
|
This should aid debugging as the symbols will be available directly to debuggers. Today, the unstripped variants are present in the `exe.unstripped` directory. Developers who work on the engine have to manually point their tools to this location.
One potential issue with this is that I am not completely sure if unopt binaries are distributed to cloud buckets. Switching to unstripped binaries in unopt may increase the size of those artifacts. If this is the case, the artifacts must be derived from opt builds anyway.
|
c: new feature,engine,P3,team-engine,triaged-engine
|
low
|
Critical
|
652,757,118 |
pytorch
|
Missing Code for Audio Classification Tutorial
|
## π Documentation
It looks as though the code is missing for the [Audio Classification Tutorial](https://pytorch.org/tutorials/beginner/audio_classifier_tutorial.html). I didn't see code in the html document or at the [linked GitHib url](https://github.com/pytorch/tutorials/blob/master/beginner_source/audio_classifier_tutorial.py).
This is what I see:
<img width="1440" alt="Screenshot 2020-07-08 at 7 57 09 AM" src="https://user-images.githubusercontent.com/6405428/86857353-e7b05b00-c0f0-11ea-998a-845795efefb8.png">
cc @jlin27
|
module: docs,triaged
|
low
|
Minor
|
652,763,802 |
flutter
|
Imbalanced calls to PlatformView::NotifyCreated and NotifyDestroyed will cause unnecessary surface re-creation.
|
Today, the Flutter engine platform view expects that calls to NotifyCreated and NotifyDestroyed are balanced. However, at least the iOS embedding might call NotifyCreated multiple times. This leads to re-creation of the surface and synchronization of all Flutter engine managed threads. This is unnecessary and slows down application foregrounding and must be optimized either in the embedding or in the platform agnostic platform view layer.
|
engine,c: performance,P2,team-engine,triaged-engine
|
low
|
Major
|
652,770,366 |
rust
|
Re-exported tuple struct changes field visibility depending on how it is imported
|
I think this is a bug in the compiler, but if that isn't the case, it is at least a diagnostics bug that should definitely be addressed. The error message is very confusing and doesn't indicate the actual issue that needs to be addressed. Here's a fairly minimal reproduction: ([Rust Playground](https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=ddfa095ba95882b6c8098712e5d54c5d))
```rust
pub use foo::*;
mod foo {
pub struct Foo(u32);
mod a {
use super::Foo;
pub fn func_a() {
let _foo = Foo(1);
}
}
mod b {
use crate::Foo;
pub fn func_b() {
let _foo = Foo(1);
}
}
}
```
Module `a` compiles with no issues and in module `b` we get the error:
```
error[E0423]: expected function, tuple struct or tuple variant, found struct `Foo`
--> src/lib.rs:18:24
|
18 | let _foo = Foo(1);
| ^^^
error: aborting due to previous error
```
The code in module `a` and module `b` is almost identical. The only difference is that `b` imports `crate::Foo` and `a` imports `super::Foo`. My understanding is that the field of `Foo` should be visible to both `a` and `b` because it is defined in a parent module. This should be the case regardless of how it is imported.
Interestingly, the key seems to be the fact that `Foo` is re-exported from another module. This code works with no issues:
```rust
pub struct Foo(u32);
mod a {
use super::Foo;
pub fn func_a() {
let _foo = Foo(1);
}
}
mod b {
use crate::Foo;
pub fn func_b() {
let _foo = Foo(1);
}
}
```
How you import the type only seems to matter if you're importing a re-exported version of it.
If this turns out to be expected behaviour, I still think we should definitely change the error message to properly describe what's going on. I imagine that someone who is less familiar with Rust's name resolution would get very stuck on something like this.
### Meta
The playground link above uses stable Rust 1.44.1 but I was using nightly when I ran into this:
`rustc --version --verbose`:
```
$ rustc --version --verbose
rustc 1.46.0-nightly (2753fab7c 2020-07-05)
binary: rustc
commit-hash: 2753fab7ce3647033146b07c8b6c9f4856a910b0
commit-date: 2020-07-05
host: x86_64-unknown-linux-gnu
release: 1.46.0-nightly
LLVM version: 10.0
```
|
C-enhancement,A-diagnostics,A-resolve,T-compiler
|
low
|
Critical
|
652,839,807 |
go
|
x/tools/go/analysis/passes/shadow/cmd/shadow: fixing shadowed errs results in code more likely to cause errors
|
<!--
Please answer these questions before submitting your issue. Thanks!
For questions please use one of our forums: https://github.com/golang/go/wiki/Questions
-->
### What version of Go are you using (`go version`)?
<pre>
$ go version
Go 1.14.4
</pre>
### Does this issue reproduce with the latest release?
Yes
### What operating system and processor architecture are you using (`go env`)?
<details><summary><code>go env</code> Output</summary><br><pre>
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN="/home/leighmcculloch/local/bin"
GOCACHE="/home/leighmcculloch/.cache/go-build"
GOENV="/home/leighmcculloch/.config/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/home/leighmcculloch/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/home/leighmcculloch/local/bin/go/1.14.4"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/home/leighmcculloch/local/bin/go/1.14.4/pkg/tool/linux_amd64"
GCCGO="gccgo"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build157507746=/tmp/go-build -gno-record-gcc-switches"
</pre></details>
### What did you do?
Fixed code according to the shadow analyzer, I renamed a variable from `err` to be distinguishable from another variable also named `err` that was in a higher scope.
### What did you expect to see?
I expected using unique names for variables in nested scopes to be a best practice since the shadow analyzer recommends it.
### What did you see instead?
I'm experiencing that renaming `err` variables in code is more likely to create more human errors than to use shadowed `err`variables.
In Go code my colleagues and I have seen we have definitely found value in renaming shadowed variables, it's actually caught some bugs for us on a couple occassions, but when it comes to errors the opposite has been true. On one occasion the error lived on for a while in production code. Code had been written, a shadow was detected, a variable was renamed, the scope was removed and then this was the bug and fix when we discovered the bug that had been created by the attempt to not shadow: https://github.com/stellar/go/pull/2469. I've caught myself on another occasion making the same mistake. This might just be my weakness but I suspect others might make the same mistake as me.
This issue isn't about that specific issue but rather treating a shadowed `err` can easily create buggy code because developers may be accustomed to seeing the error named `err`, making it really easy to forget that in this one rare scope the error is named `dbErr` and to do things like return the error from the wrong scope.
### Proposal
Make `err` of type `error` an exception to the shadow checker. The shadow checker already makes several exceptions on the basis of those patterns being common and idiomatic. This is another one of those patterns.
cc @stamblerre
|
NeedsInvestigation,Tools,Analysis
|
low
|
Critical
|
652,965,824 |
flutter
|
[proposal] ability to change text overflow on the TextField
|
If the user inputs more text than can fit into the available space of a single line `TextFormField`, then end of the text is simply cropped.
In debug mode, an overflow warning is also displayed on screen.
Unlike the `Text` widget however, the `TextFormField` does not have an `overflow` parameter so that we can for example show an ellipsis in this situation.
Implementing `overflow` handling for the `TextFormField` will allow us to give valuable visual feedback to users.
|
a: text input,c: new feature,framework,f: material design,c: proposal,P2,team-text-input,triaged-text-input
|
low
|
Critical
|
653,018,178 |
youtube-dl
|
Please add poptv.com
|
<!--
######################################################################
WARNING!
IGNORING THE FOLLOWING TEMPLATE WILL RESULT IN ISSUE CLOSED AS INCOMPLETE
######################################################################
-->
## Checklist
<!--
Carefully read and work through this check list in order to prevent the most common mistakes and misuse of youtube-dl:
- First of, make sure you are using the latest version of youtube-dl. Run `youtube-dl --version` and ensure your version is 2020.06.16.1. If it's not, see https://yt-dl.org/update on how to update. Issues with outdated version will be REJECTED.
- Make sure that all provided video/audio/playlist URLs (if any) are alive and playable in a browser.
- Make sure that site you are requesting is not dedicated to copyright infringement, see https://yt-dl.org/copyright-infringement. youtube-dl does not support such sites. In order for site support request to be accepted all provided example URLs should not violate any copyrights.
- Search the bugtracker for similar site support requests: http://yt-dl.org/search-issues. DO NOT post duplicates.
- Finally, put x into all relevant boxes (like this [x])
-->
- [x ] I'm reporting a new site support request
- [x ] I've verified that I'm running youtube-dl version **2020.06.16.1**
- [x] I've checked that all provided URLs are alive and playable in a browser
- [x ] I've checked that none of provided URLs violate any copyrights
- [x ] I've searched the bugtracker for similar site support requests including closed ones
## Example URLs
<!--
Provide all kinds of example URLs support for which should be included. Replace following example URLs by yours.
-->
- Playlist: https://www.poptv.com/schittscreek/fullepisodes
- Playlist: https://www.poptv.com/thestorybehind/fullepisodes
- Playlist: https://www.poptv.com/schittscreek/exclusives
## Description
<!--
It seems that there are no individual links for each video. I am using --ap-mso and have legitimate credentials.
-->
WRITE DESCRIPTION HERE
|
site-support-request
|
low
|
Critical
|
653,074,614 |
neovim
|
provide VertSplitNC for splits not adjacent to the current window
|
I currently use different highlights for `StatusLine` and `StatusLineNC`, to brighten the status line of the current window, making it easy to see at a glance.
I'd love to do the same for the vertical splits surrounding the current window and non-current windows, making the former brighter than the latter.
The highlight `VertSplit` defines the highlight for the vertical split. I'd love to have a separate highlight `VertSplitNC`, used for any vertical split not adjacent to the current window.
- `nvim --version`:
```
NVIM v0.4.3
Build type: Release
LuaJIT 2.1.0-beta3
Compilation: /usr/bin/cc -g -O2 -fdebug-prefix-map=/build/neovim-xAEA75/neovim-0.4.3=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=1 -DDISABLE_LOG -Wdate-time -D_FORTIFY_SOURCE=1 -O2 -DNDEBUG -DMIN_LOG_LEVEL=3 -Wall -Wextra -pedantic -Wno-unused-parameter -Wstrict-prototypes -std=gnu99 -Wshadow -Wconversion -Wmissing-prototypes -Wimplicit-fallthrough -Wvla -fstack-protector-strong -fdiagnostics-color=always -DINCLUDE_GENERATED_DECLARATIONS -D_GNU_SOURCE -DNVIM_MSGPACK_HAS_FLOAT32 -DNVIM_UNIBI_HAS_VAR_FROM -I/build/neovim-xAEA75/neovim-0.4.3/build/config -I/build/neovim-xAEA75/neovim-0.4.3/src -I/usr/include -I/usr/include/lua5.1 -I/build/neovim-xAEA75/neovim-0.4.3/build/src/nvim/auto -I/build/neovim-xAEA75/neovim-0.4.3/build/include
Compiled by [email protected]
Features: +acl +iconv +tui
See ":help feature-compile"
system vimrc file: "$VIM/sysinit.vim"
fall-back for $VIM: "/usr/share/nvim"
Run :checkhealth for more info
```
- `vim -u DEFAULTS` (version: ) behaves differently? No
- Operating system/version: Debian, latest unstable
- Terminal name/version: `GNOME Terminal 3.36.2 using VTE 0.60.3`
- `$TERM`: `xterm-256color`
|
enhancement,highlight
|
low
|
Critical
|
653,086,268 |
godot
|
Android build is (sometimes) missing referenced .NET assemblies
|
**Godot version:**
3.2.1
(3.2.2 has some breaking changes so I have not updated yet)
**OS/device including version:**
Ubuntu 20.04 LTS
Linux devtop-home 5.4.0-40-generic #44-Ubuntu SMP Tue Jun 23 00:01:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Multiple version of Android
**Issue description:**
In my project reference some nuget packages, for example:
protobuf-net
netmq
Newtonsoft.Json
**Steps to reproduce:**
Create an empty project with C# support.
Add said nuget packages, export the APK
**Minimal reproduction project:**
The project I attached actually works... (but so does my other project sometimes)
If you open the APK you can see protobuf-net is there, whereas in my other apk it is not.
[AssemblyIssueSample.zip](https://github.com/godotengine/godot/files/4889294/AssemblyIssueSample.zip)
If you look at the screenshot, you will see the content of 2 APK files. One does not include the protobuf-net assembly.
I do not know what triggers the issue.
Logcat:
```
8 15:42:13.246 5553 5588 E mono : Unhandled Exception:
07-08 15:42:13.246 5553 5588 E mono : System.IO.FileNotFoundException: Could not load file or assembly 'protobuf-net, Version=2.4.0.0, Culture=neutral, PublicKeyToken=257b51d87d2e4d67' or one of its dependencies.
07-08 15:42:13.246 5553 5588 E mono : File name: 'protobuf-net, Version=2.4.0.0, Culture=neutral, PublicKeyToken=257b51d87d2e4d67'
07-08 15:42:13.246 5553 5588 E mono : at (wrapper managed-to-native) System.MonoCustomAttrs.IsDefinedInternal(System.Reflection.ICustomAttributeProvider,System.Type)
07-08 15:42:13.246 5553 5588 E mono : at System.MonoCustomAttrs.IsDefined (System.Reflection.ICustomAttributeProvider obj, System.Type attributeType, System.Boolean inherit) [0x00027] in <d27d4d20107845ca9569511318b19517>:0
07-08 15:42:13.246 5553 5588 E mono : at System.RuntimeType.IsDefined (System.Type attributeType, System.Boolean inherit) [0x00038] in <d27d4d20107845ca9569511318b19517>:0
07-08 15:42:13.246 5553 5588 E mono : at System.Enum.InternalFormat (System.RuntimeType eT, System.Object value) [0x00000] in <d27d4d20107845ca9569511318b19517>:0
07-08 15:42:13.246 5553 5588 E mono : at System.Enum.ToString () [0x00011] in <d27d4d20107845ca9569511318b19517>:0
07-08 15:42:13.246 5553 5588 E mono : at DebugLabel._Process (System.Single delta) [0x0000d] in <dac6cfdc1ab24ae5b528571459958f73>:0
07-08 15:49:17.312 6303 6343 I godot : Godot Engine v3.2.1.stable.mono.official - https://godotengine.org
07-08 15:49:17.474 6303 6343 I godot : Mono: Logfile is: /data/data/com.sample.mygame/files/mono/mono_logs/2020_07_08 15.49.17 (6303).txt
07-08 15:49:17.630 6303 6343 E godot : At: modules/mono/csharp_script.cpp:3187:reload() - Condition "!obj_type" is true. Returned: ERR_BUG
07-08 15:49:17.666 6303 6343 E godot : At: modules/mono/csharp_script.cpp:2915:can_instance() - Method failed. Returning: __null
07-08 15:49:18.130 6303 6343 E mono :
07-08 15:49:18.130 6303 6343 E mono : Unhandled Exception:
07-08 15:49:18.130 6303 6343 E mono : System.IO.FileNotFoundException: Could not load file or assembly 'protobuf-net, Version=2.4.0.0, Culture=neutral, PublicKeyToken=257b51d87d2e4d67' or one of its dependencies.
07-08 15:49:18.130 6303 6343 E mono : File name: 'protobuf-net, Version=2.4.0.0, Culture=neutral, PublicKeyToken=257b51d87d2e4d67'
07-08 15:49:18.130 6303 6343 E mono : at (wrapper managed-to-native) System.MonoCustomAttrs.IsDefinedInternal(System.Reflection.ICustomAttributeProvider,System.Type)
07-08 15:49:18.130 6303 6343 E mono : at System.MonoCustomAttrs.IsDefined (System.Reflection.ICustomAttributeProvider obj, System.Type attributeType, System.Boolean inherit) [0x00027] in <d27d4d20107845ca9569511318b19517>:0
07-08 15:49:18.130 6303 6343 E mono : at System.RuntimeType.IsDefined (System.Type attributeType, System.Boolean inherit) [0x00038] in <d27d4d20107845ca9569511318b19517>:0
07-08 15:49:18.130 6303 6343 E mono : at System.Enum.InternalFormat (System.RuntimeType eT, System.Object value) [0x00000] in <d27d4d20107845ca9569511318b19517>:0
07-08 15:49:18.130 6303 6343 E mono : at System.Enum.ToString () [0x00011] in <d27d4d20107845ca9569511318b19517>:0
07-08 15:49:18.130 6303 6343 E mono : at DebugLabel._Process (System.Single delta) [0x0000d] in <1c508adea2bd49df979fb8fbfb68771a>:0
```
I think if something goes wrong during the export process it stops adding assemblies
but still produces the APK.
|
bug,platform:android,topic:porting,topic:dotnet
|
low
|
Critical
|
653,119,217 |
flutter
|
Debug WebSocket - make it throw exception with more extra information
|
Thanks very much for this wonderful library!
<!-- Thank you for using Flutter!
If you are looking for support, please check out our documentation
or consider asking a question on Stack Overflow:
* https://flutter.dev/
* https://api.flutter.dev/
* https://stackoverflow.com/questions/tagged/flutter?sort=frequent
If you have found a bug or if our documentation doesn't have an answer
to what you're looking for, then fill our the template below. Please read
our guide to filing a bug first: https://flutter.dev/docs/resources/bug-reports
-->
## Use case
For instance, when the http response is not expected when connecting, an error with message `Connection to '$uri' was not upgraded to websocket` is thrown. However, I want to see the details - does it return 404? 401? 500? is there any response body giving some hints where the request goes wrong? All these does not appear :(
**An alternative:** Since I am just debugging, it is OK to just temporarily modify the source code. However, I am having difficulty modifying the source code. I modified the `.../cache/dart-sdk/lib/_http/websocket_impl.dart` adding some prints, and restart the app (even re-run Xcode build), but nothing happened... *It is also very acceptable if I could modify the source code.*
<!--
Please tell us the problem you are running into that led to you wanting
a new feature.
Is your feature request related to a problem? Please give a clear and
concise description of what the problem is.
Describe alternative solutions you've considered. Is there a package
on pub.dev/flutter that already solves this?
-->
## Proposal
When throwing exception, give more information, such as the response code, the response body, etc.
<!--
Briefly but precisely describe what you would like Flutter to be able to do.
Consider attaching images showing what you are imagining.
Does this have to be provided by Flutter directly, or can it be provided
by a package on pub.dev/flutter? If so, maybe consider implementing and
publishing such a package rather than filing a bug.
-->
|
engine,dependency: dart,c: proposal,a: error message,P3,team-engine,triaged-engine
|
low
|
Critical
|
653,125,086 |
tensorflow
|
Autograph applied to Keras Custom Loss during Eager Execution
|
**System information**
- Have I written custom code (as opposed to using a stock example script provided in TensorFlow): Yes
- OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Windows 10, x64
- TensorFlow installed from (source or binary): binary (pip)
- TensorFlow version (use command below): TF 2.4.0.dev20200707
- Python version: 3.7
- CUDA/cuDNN version: 10.1 / 7.6
- GPU model and memory: Bug appears on several computers with different GPU
**Describe the current behavior**
Tensorflow applies AutoGraph to keras custom loss even in eager execution, meaning that we can't debug the loss anymore (unless using tf.print). This did not happen in previous versions of Tensorflow.
Notice that it both happens when run_eagerly is set to True in model.compile() and when tf.config.run_functions_eagerly is set to True.
**Describe the expected behavior**
When run_eagerly=True is passed to the model during compilation, we should expect Tensorflow to run eagerly in the loss function.
**Standalone code to reproduce the issue**
```
import numpy as np
import tensorflow as tf
from tensorflow import keras
# Custom Model. Autograph is not applied in eager execution so debugging is possible.
class CustomModel(keras.models.Model):
def __init__(self):
super(CustomModel, self).__init__()
self.layer = tf.keras.layers.Dense(3) # Can debug here
def call(self, inputs, training=None, mask=None):
x = self.layer(inputs) # Can debug here
return x
# Custom Loss. AutoGraph is applied in eager execution so debugging is impossible.
class CustomLoss(keras.losses.Loss):
def call(self, y_true, y_pred):
x = tf.reduce_mean(tf.abs(y_pred-y_true)) # Cannot debug here
return x
if __name__ == '__main__':
data = np.random.random((1000, 3)).astype(np.float32)
model = CustomModel()
model.compile(loss=CustomLoss(), run_eagerly=True)
model.fit(x=data, y=data, batch_size=32)
```
**Other info / logs** Include any logs or source code that would be helpful to
diagnose the problem. If including tracebacks, please include the full
traceback. Large logs and files should be attached.
|
type:bug,comp:keras,comp:autograph,TF 2.2
|
medium
|
Critical
|
653,138,420 |
angular
|
[Ivy] Animation events @trigger.start and @trigger.done are emitted after ngOnDestroy
|
<!--π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
Oh hi there! π
To expedite issue processing please search open and closed issues before submitting a new one.
Existing issues often contain information about workarounds, resolution, or progress updates.
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
-->
# π bug report
### Affected Package
<!-- Can you pin-point one or more @angular/* packages as the source of the bug? -->
<!-- βοΈedit: --> The issue is caused by package @angular/animations
### Is this a regression?
<!-- Did this behavior use to work in the previous version? -->
<!-- βοΈ--> Yes, the previous version in which this bug was not present was: 9, 10 with Ivy disabled
### Description
With Ivy enabled, (@animation.start) and (@animation.done) are emitted even after component has been destroyed. To check that without Ivy, you can set the "enableIvy" flag to "false".
Expected behavior: Animation is not triggered after component has been destroyed.
## π¬ Minimal Reproduction
<!--
Please create and share minimal reproduction of the issue starting with this template: https://stackblitz.com/fork/angular-ivy
-->
<!-- βοΈ-->
[Stackblitz demo](https://stackblitz.com/edit/angular-ivy-dwdtff)
**Steps to reproduce:**
1. Open console
2. Click "Destroy hello component" button.
AR: There are onAnimationStartEvent and onAnimationDoneEvent log messages after ngOnDestroy.
ER: There is not any log messages after ngOnDestroy.
3. Set "enableIvy" to "false" (Page will be reloaded)
4. Click "Destroy hello component" button.
AR = ER: There is not any log messages after ngOnDestroy.
<!--
If StackBlitz is not suitable for reproduction of your issue, please create a minimal GitHub repository with the reproduction of the issue.
A good way to make a minimal reproduction is to create a new app via `ng new repro-app` and add the minimum possible code to show the problem.
Share the link to the repo below along with step-by-step instructions to reproduce the problem, as well as expected and actual behavior.
Issues that don't have enough info and can't be reproduced will be closed.
You can read more about issue submission guidelines here: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#-submitting-an-issue
-->
## π Your Environment
**Angular Version:**
<pre><code>
Angular CLI: 9.1.9
Node: 12.13.0
OS: win32 x64
Angular: 9.1.11
... animations, common, compiler, compiler-cli, core, forms
... language-service, platform-browser, platform-browser-dynamic
... router
Ivy Workspace: Yes
Package Version
-----------------------------------------------------------
@angular-devkit/architect 0.901.9
@angular-devkit/build-angular 0.1000.0
@angular-devkit/build-optimizer 0.1000.0
@angular-devkit/build-webpack 0.1000.0
@angular-devkit/core 7.3.10
@angular-devkit/schematics 7.3.10
@angular/cdk 7.3.7
@angular/cli 9.1.9
@ngtools/webpack 10.0.0
@schematics/angular 9.1.9
@schematics/update 0.901.9
rxjs 6.5.5
typescript 3.8.3
webpack 4.43.0
</code></pre>
|
area: animations,state: confirmed,P3
|
low
|
Critical
|
653,146,510 |
flutter
|
Allow text wrapping behavior to be controlled
|
when the word is very long, the text wrap will be not good.
at web, we can use `word-break: break-all;` to solve it.
so, can flutter add the feature?
## Use case
```dart
MaterialApp(
theme: new ThemeData(),
home: Scaffold(
body: Center(
child: Container(
width: 100.0,
child: Text.rich(
TextSpan(text: 'δΈζinformation spropaganda accomplishment accomplishment'),
),
),
),
),
)
```
like this, between two long word, there is very large spacing.
## Proposal
please add new params `wordBreak` to `TextSpan`, let word wrap at end of line, instead of end of word.
|
c: new feature,framework,engine,a: typography,P3,team-engine,triaged-engine
|
medium
|
Critical
|
653,148,528 |
flutter
|
Failed to apply plugin [id 'com.android.internal.version-check']
|
Hello,
I am experiencing issues building an android application on flutter. The IOS app complies with no problems.
The issue seems to be along the lines of Gradle versioning for the third-party flutter plugin. However, the plugin itself shouldn't be a problem because (I) I can import it in an empty project without issues, (II) if I remove it, then another plugin fails along the similar lines.
```
FAILURE: Build failed with an exception.
* Where:
Build file '/Users/rsirokov/.pub-cache/hosted/pub.dartlang.org/devicelocale-0.3.1/android/build.gradle' line: 22
* What went wrong:
A problem occurred evaluating root project 'devicelocale'.
> Failed to apply plugin [id 'com.android.internal.version-check']
> Minimum supported Gradle version is 5.6.4. Current version is 5.6.2. If using the gradle wrapper, try editing the distributionUrl in /Users/rsirokov/.pub-cache/hosted/pub.dartlang.org/devicelocale-0.3.1/android/gradle/wrapper/gradle-wrapper.properties to gradle-5.6.4-all.zip
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.
* Get more help at https://help.gradle.org
BUILD FAILED in 6s
Exception: The plugin devicelocale could not be built due to the issue above.
```
Tried:
- `flutter pub cache repair`;
- `flutter pub upgrade`;
- Different versions of Gradle for the main project;
- Switched to Flutter stable channel of 1.17.4;
- Android Studio -> File -> Invalidate Cache and Restart.
The aforementioned log proposes a solution to switch Gradle version in the plugin's project directory. However, I don't think this would be a good idea since this directory, `.pub-cache`, is handled automatically by package manager and any manual change could make it only worse.
## Steps to Reproduce
Not sure how to reproduce it. Have it in the full-size project. The minimal one with the specified plugin doesn't have any issues.
<details>
<summary>Logs</summary>
```
[β] Flutter (Channel stable, v1.17.4, on Mac OS X 10.15.4 19E287, locale en-NO)
β’ Flutter version 1.17.4 at /Users/rsirokov/Projects/Plugins/flutter
β’ Framework revision 1ad9baa8b9 (3 weeks ago), 2020-06-17 14:41:16 -0700
β’ Engine revision ee76268252
β’ Dart version 2.8.4
[β] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
β’ Android SDK at /Users/rsirokov/Library/Android/sdk
β’ Platform android-30, build-tools 29.0.2
β’ Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
β’ Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)
β’ All Android licenses accepted.
[β] Xcode - develop for iOS and macOS (Xcode 11.5)
β’ Xcode at /Applications/Xcode.app/Contents/Developer
β’ Xcode 11.5, Build version 11E608c
β’ CocoaPods version 1.9.3
[β] Android Studio (version 4.0)
β’ Android Studio at /Applications/Android Studio.app/Contents
β’ Flutter plugin version 47.1.2
β’ Dart plugin version 193.7361
β’ Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)
[β] IntelliJ IDEA Ultimate Edition (version 2019.1.3)
β’ IntelliJ at /Applications/IntelliJ IDEA.app
β’ Flutter plugin version 39.0.3
β’ Dart plugin version 191.8423
[β] Connected device (1 available)
β’ Android SDK built for x86 β’ emulator-5554 β’ android-x86 β’ Android 10 (API 29) (emulator)
β’ No issues found!
```
</details>
|
c: crash,platform-android,tool,a: build,P3,a: plugins,team-android,triaged-android
|
medium
|
Critical
|
653,243,074 |
PowerToys
|
[FancyZones] Only snap near top of the screen.
|
Title sort of says it all. I use/used windock and I was able to configure it to only snap when I was near the top of the monitor. This allowed me to drag windows around and have them not snap without having to hold shift. As an example I opened the calculator and tried to move it and it immediately filled out the entire zone it was in.
I would suggest being able to configure it, though for myself I only use the top.
|
Idea-Enhancement,FancyZones-Dragging&UI,Product-FancyZones
|
low
|
Minor
|
653,256,349 |
vscode
|
Investigate use of ts external project for notebooks
|
There is https://github.com/Microsoft/TypeScript/wiki/Standalone-Server-%28tsserver%29#external-project which seems to allow us to support JS and TS in notebooks - in the sense of a notebook is a project (see https://github.com/microsoft/notebook-extension-samples/blob/master/notebook-language-guide/notebook-language-guide.md)
We should explore how well this works for notebooks and if it would be a good case of language service being notebooks-friendly.
|
feature-request,typescript,notebook
|
low
|
Minor
|
653,259,637 |
vscode
|
Zooming with Ctrl+MouseWheel doesn't update configuration
|
Issue Type: <b>Bug</b>
Zooming with Ctrl+MouseWheel doesn't update the configuration `window.zoomLevel`, `editor.fontSize` or `editor.lineHeight` and there is no `editor.fontZoomLevel` configuration so if there is anything on an extension that depends on it, it won't work properly.
From what I've seen in the code the Ctrl+MouseWheel zoom applies a multiplier to fontSize and lineHeight directly on the browser but doesn't update the configuration after making that change.
From what I've checked there is also no way for an extension to subscribe to this zoom change event.
**My use case and problem with this is:** I have a TextEditorDecoration that depends on the fontSize and lineHeight (I'm trying to mimic an half block cursor), it works fine if you zoom with Ctrl++, Ctrl+- or Ctrl+=, but it won't behave correctly if you zoom with Ctrl+MouseWheel because none of this options will be updated.
VS Code version: Code 1.46.1 (cd9ea6488829f560dc949a8b2fb789f3cdc05f5d, 2020-06-17T21:13:20.174Z)
OS version: Windows_NT x64 10.0.18363
<details>
<summary>System Info</summary>
|Item|Value|
|---|---|
|CPUs|Intel(R) Core(TM) i7-6700HQ CPU @ 2.60GHz (8 x 2592)|
|GPU Status|2d_canvas: enabled<br>flash_3d: enabled<br>flash_stage3d: enabled<br>flash_stage3d_baseline: enabled<br>gpu_compositing: enabled<br>multiple_raster_threads: enabled_on<br>oop_rasterization: disabled_off<br>protected_video_decode: unavailable_off<br>rasterization: enabled<br>skia_renderer: disabled_off_ok<br>video_decode: enabled<br>viz_display_compositor: enabled_on<br>viz_hit_test_surface_layer: disabled_off_ok<br>webgl: enabled<br>webgl2: enabled|
|Load (avg)|undefined|
|Memory (System)|15.90GB (2.73GB free)|
|Process Argv|.|
|Screen Reader|no|
|VM|0%|
</details>
<!-- generated by issue reporter -->
|
feature-request,editor-core
|
low
|
Critical
|
653,300,140 |
flutter
|
FloatingActionButtonAnimator getRotationAnimation issue
|
**Issue #25123 already open but @NBTX is unable to reopen it, please make sure to check it out.**
> ## Steps to Reproduce
> 1. Create a MaterialApp and Scaffold
> 2. Try to apply a `floatingActionButtonAnimation`
> 3. The results are ignored.
>
> ## Logs
> ```shell
> [ ] Connected to _flutterView/0x7336838c18.
> [ +3 ms] π₯ To hot reload changes while running, press "r". To hot restart (and rebuild state), press "R".
> [ ] An Observatory debugger and profiler on Pixel 2 is available at: http://127.0.0.1:49684/
> [ ] For a more detailed help message, press "h". To detach, press "d"; to quit, press "q".
> ```
>
> No analysis errors.
>
> ```
> [β] Flutter (Channel beta, v1.0.0, on Mac OS X 10.14 18A391, locale en-GB)
> β’ Flutter version 1.0.0 at /Users/NBTX/development/flutter
> β’ Framework revision 5391447fae (9 days ago), 2018-11-29 19:41:26 -0800
> β’ Engine revision 7375a0f414
> β’ Dart version 2.1.0 (build 2.1.0-dev.9.4 f9ebf21297)
>
> [β] Android toolchain - develop for Android devices (Android SDK 28.0.3)
> β’ Android SDK at /Users/NBTX/Library/Android/sdk
> β’ Android NDK location not configured (optional; useful for native profiling support)
> β’ Platform android-28, build-tools 28.0.3
> β’ Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
> β’ Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1136-b06)
> β’ All Android licenses accepted.
>
> [β] iOS toolchain - develop for iOS devices (Xcode 10.1)
> β’ Xcode at /Applications/Xcode.app/Contents/Developer
> β’ Xcode 10.1, Build version 10B61
> β’ ios-deploy 2.0.0
> β’ CocoaPods version 1.5.3
>
> [β] Android Studio (version 3.2)
> β’ Android Studio at /Applications/Android Studio.app/Contents
> β’ Flutter plugin version 29.0.2
> β’ Dart plugin version 181.5540.11
> β’ Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1136-b06)
>
> [β] IntelliJ IDEA Ultimate Edition (version 2018.2.4)
> β’ IntelliJ at /Applications/IntelliJ IDEA.app
> β’ Flutter plugin version 29.1.3
> β’ Dart plugin version 182.4999
>
> [β] Connected device (1 available)
> β’ ...
>
> β’ No issues found!
> ```
## And here is @cohortor's suggested solution.
> I would kindly like to revisit and reopen this issue. IMHO the problem is in `scaffold.dart` -> `_FloatingActionButtonTransitionState` -> `_updateAnimations()`.
>
> In particular, `_entranceTurnTween` is always applied, rotating the FAB by `kFloatingActionButtonTurnInterval` (currently 0.125, i.e. 45 degrees). Changing this value to 0.0 stops FAB rotation.
>
> DISCUSSION:
>
> The previously suggested "solution":
>
> ```
> @override
> Animation<double> getRotationAnimation({Animation<double> parent}) {
> return Tween<double>(begin: 0.0, end: 1.0).animate(parent);
> }
> ```
>
> 1. should actually result in a rotation animation that rotates the FAB through a full circle,
> 2. in my case (FAB placed horizontally centered) results in a 45deg FAB rotation the first time the FAB is shown, followed by no rotation during subsequent hides/shows.
>
> The final value of the rotation is determined by the FAB's current and previous locations, the animation controller's state, and also the final `TrainHopping` animation, which right now is responsible for chaining the previously mentioned `_entranceTurnTween`'s hardcoded values.
>
> PROPOSED SOLUTION:
>
> Fix/remove the application of `_entranceTurnTween` on the FAB.
|
framework,a: animation,f: material design,has reproducible steps,P2,found in release: 3.3,found in release: 3.6,team-design,triaged-design
|
low
|
Critical
|
653,351,359 |
pytorch
|
TORCH_CUDA_ARCH_LIST deprecation warning
|
## π Bug
During build with `TORCH_CUDA_ARCH_LIST=5.2 python setup.py install` a warning is shown:
```
In the future we will require one to explicitly pass TORCH_CUDA_ARCH_LIST
to cmake instead of implicitly setting it as an env variable. This will
become a FATAL_ERROR in future version of pytorch.
```
However as it seems to be impossible to pass options directly to the invoked cmake this cannot be fixed.
## Expected behavior
No warning/error is shown
cc @malfet
|
module: build,triaged,enhancement
|
low
|
Critical
|
653,389,743 |
TypeScript
|
TypeScript doesn't error on late definition/initialization of variables from outside an async closure.
|
**TypeScript Version:** 4.0-beta and Nightly (as of writing)
<!-- Search terms you tried before logging this (so others can find this issue more easily) -->
**Search Terms:** async closure variable initialization
**Code**
```ts
async function doSomething(): Promise<void> {
const x = setTimeout(() => {
const a = someVar + 1;
}, 5000)
await doSomethingSlowly();
const someVar = 5;
}
```
**Expected behavior:**
There should be an error on ```const a = someVar + 1;``` since someVar may not have been initialized.
**Actual behavior:**
No error/warning with any settings that I could find.
**Playground Link:** [link](https://www.typescriptlang.org/play/?ts=Nightly#code/IYZwngdgxgBAZgV2gFwJYHsIwCboMroC2ApsgBaoQDmeANugO61gAUAlAFwwAKATkahDEAPADd0qbAD4YAbwBQMJTF6kEvCAG55AX3nzQkWIhQYsuAiXKUq7LnwFCxE6XMXKomEMhgAPGAC8MELIACqoJOgIyCzsgTIKykkwnhDeMMCBwUTEAGrAvDAA1DAAjNpJOgA0MACsAAyNbPpJwAzAqD4WOdbUdIzM7NruSqnpIDn5hUG12jpAA)
**Related Issues:**
**Comments**
I see folks hit this every so often and it feels like something the TypeScript compiler could help warn against, in a similar way that [2448 and 2454 error](https://www.typescriptlang.org/play/#code/MYewdgzgLgBAZiEMC8MBGBDATjA1DAVgG4AoUSWTHVARiKA).
|
Suggestion,Awaiting More Feedback
|
low
|
Critical
|
653,413,708 |
kubernetes
|
Investigate use of e2e framework's flake report
|
The e2e test framework, has a flake report utility https://github.com/kubernetes/kubernetes/blob/master/test/e2e/framework/flake_reporting_util.go.
As far as we know, there is no current usage of this utility but it is mentioned as useful for https://github.com/kubernetes/kubernetes/issues/66239.
We should investigate this and evaluate what we can do with the e2e test framework.
/kind cleanup
/sig testing
/area e2e-test-framework
/priority important-longterm
|
kind/cleanup,kind/feature,help wanted,sig/testing,priority/important-longterm,lifecycle/frozen,area/e2e-test-framework
|
low
|
Major
|
653,418,057 |
rust
|
Unique references to temporary empty arrays are not actually unique
|
```rust
fn two_muts<T>(a: &mut [T], b: &mut [T]) {
assert_ne!(a.as_ptr(), b.as_ptr());
}
fn main() {
two_muts::<u8>(&mut [], &mut []);
}
```
I expected this code to compile and exit without effect; instead, I get an assertion error. It seems that, when passing in unique references to temporary empty slices, the underlying pointers nonetheless alias.
I expected all such pointers to never alias; this even holds when replacing `[T]` above with the ZST `[T; 0]`, which makes it significantly more worrying, since it does *not* hold for the same code using `()`.
I don't know if this behavior is *actually* specified, but I'd like an answer to whether this is a miscompilation or (un)documented implementation-defined behavior. At any rate, I wonder if it would be a good idea to make this behavior consistent for all ZST temporaries...
Also, I aught to mention that this is about ZSTs lying in *distinct allocations*. For a type such as `((), ())`, we expect the two unit values to have the same addresses. The closest mention of this I could find in the nomicon to this was the implementation of `Vec<()>`, but that's still regarding same-allocation references, so that didn't give me a particularly satisfying answer.
### Meta
This issue is reproducible on latest beta and nightly.
I could not find an issue corresponding to this bug; feel free to close as duplicate.
|
T-compiler,C-bug,A-array
|
low
|
Critical
|
653,422,166 |
TypeScript
|
Unmet parameter type in function call is misleading the compiler when those parameters involve inherited interfaces
|
<!-- π¨ STOP π¨ STOP π¨ STOP π¨
Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Even if you think you've found a *bug*, please read the FAQ first, especially the Common "Bugs" That Aren't Bugs section!
Please help us by doing the following steps before logging an issue:
* Search: https://github.com/Microsoft/TypeScript/search?type=Issues
* Read the FAQ: https://github.com/Microsoft/TypeScript/wiki/FAQ
Please fill in the *entire* template below.
-->
<!--
Please try to reproduce the issue with the latest published version. It may have already been fixed.
For npm: `typescript@next`
This is also the 'Nightly' version in the playground: http://www.typescriptlang.org/play/?ts=Nightly
-->
**TypeScript Version:** 3.8.x, 3.9.x, Nightly
<!-- Search terms you tried before logging this (so others can find this issue more easily) -->
**Search Terms:**
- TS2322 wrong
- Incorrect error TS2322
- TS2322 Type is missing the following properties from type
- Parent interface is missing properties of child
**Code**
```ts
interface I1 {
id: string;
i1prop1: string;
}
interface I2<T> {
id: keyof T & string;
i2prop1: string;
}
interface FnParams<T extends I1> {
param1: I2<T>[];
param2: T[];
param3: keyof T & string;
param4: string;
}
const fn1 = <T extends I1>(args: FnParams<T>) => {
// whatever use of args
};
interface I4 extends I1 {
i4prop1: string;
}
const val1: I2<I4>[] = [
{ id: "id", i2prop1: "lorem" },
{ id: "i1prop1", i2prop1: "ipsum" },
];
const val2 = [
{ id: "id1", i1prop1: "lorem", i4prop1: "ipsum" },
{ id: "id2", i1prop1: "lorem", i4prop1: "ipsum" },
];
fn1({
param1: val1,
param2: val2,
param3: "i1prop1",
});
```
**Expected behavior:**
- Error is highlighted on the entire object given as function argument as it is missing `param4` property
- `TS2345`(-like) error pointing to `FnParams` unmet, something like
> Argument of type '{ param1: I2<I4>[]; param2: I4[]; param3: string; }' is not assignable to parameter of type 'FnParams<T extends I1>'. Property 'param4' is missing in type '{ param1: I2<I4>[]; param2: I4[]; param3: string; }' but required in type 'FnParams<T extends I1>'.
**Actual behavior:**
- Error is highlighted on `param1` which value is correct as per `param1`'s expected type
- `TS2322` error saying
> Type 'I2<I4>[]' is not assignable to type 'I2<I1>[]'. Type 'I2<I4>' is not assignable to type 'I2<I1>. Property 'i4prop1' is missing in type 'I1' but required in type 'I4'.
Note that to fix the error I just need to set `param4` on the object passed in `fn1()` which does nothing to have with the error reported by the compiler:
```typescript
fn1({
param1: val1,
param2: val2,
param3: "i1prop1",
param4: "having this set fix the error which is normal",
});
```
**Playground Link:** [Provided](https://www.typescriptlang.org/play/#code/JYOwLgpgTgZghgYwgAgJIEZkG8BQz-LAAmAXMgM5hSgDmA3HgcOgA5QD2L6Zl1I9OAL44coSLEQpUAJgA8AFQB82RvmJkA1hACe7GMnnIAZBSq0GBQtLadupvgOGjw0eEmQAxEAAU4UOAC25ArIEAAekCBE5GjoyriWLH6BdjIKigDaALoWBEn+AdJk8tm5+PmBAMyaOnoGxvbmqsgVAQAsPGb8DE4I7CCUyDAgmAC8yCHhkdGxigAUfjTkZF6+BcFKAJTIo-HNAPT7yADuABZwkABu0MgAruQodYvkeIIMzuJuUm2hERBRMQwKkswDaNi4nQcPREfQGYGQlzgABtUnJUG1MlkdsgMs0sIRSMgAETEIkAGis4LsRKR7CgEACROQgjJeIJZBJrA4XHJlO51OALHIt0ZzNZORh-UGiKRRTQbWy2Nxlnx6mJxHQvOYVI5tPpjIpoJ16qFIqZLLZapJRGkWq5tl1dIZWrB-I5guFootEpww3QcwSeWSATsMvQrMSwblMukEaDBWq6vtPNZgk2dCAA)
<details><summary><b>Output</b></summary>
```ts
"use strict";
const fn1 = (args) => {
// whatever use of args
};
const val1 = [
{ id: "id", i2prop1: "lorem" },
{ id: "i1prop1", i2prop1: "ipsum" },
];
const val2 = [
{ id: "id1", i1prop1: "lorem", i4prop1: "ipsum" },
{ id: "id2", i1prop1: "lorem", i4prop1: "ipsum" },
];
fn1({
param1: val1,
param2: val2,
param3: "i1prop1",
});
```
</details>
<details><summary><b>Compiler Options</b></summary>
```json
{
"compilerOptions": {
"noImplicitAny": true,
"strictNullChecks": true,
"strictFunctionTypes": true,
"strictPropertyInitialization": true,
"strictBindCallApply": true,
"noImplicitThis": true,
"noImplicitReturns": true,
"useDefineForClassFields": false,
"alwaysStrict": true,
"allowUnreachableCode": false,
"allowUnusedLabels": false,
"downlevelIteration": false,
"noEmitHelpers": false,
"noLib": false,
"noStrictGenericChecks": false,
"noUnusedLocals": false,
"noUnusedParameters": false,
"esModuleInterop": true,
"preserveConstEnums": false,
"removeComments": false,
"skipLibCheck": false,
"checkJs": false,
"allowJs": false,
"declaration": true,
"experimentalDecorators": false,
"emitDecoratorMetadata": false,
"target": "ES2017",
"module": "ESNext"
}
}
```
</details>
|
Bug
|
low
|
Critical
|
653,460,341 |
godot
|
GlobalTransform being called from nowhere on node not in tree.
|
**Godot version:**
3.2.2
**OS/device including version:**
Windows 10; C#
**Issue description:**
When I debug and example project: I create 3 nodes unnatached to the scene tree. I then try to set a boolean on these nodes in a seperate thread, but this seems to break execution:
https://i.gyazo.com/3f1fb76572edbb55949417dcc77c057c.png
`E 0:00:04.826 get_global_transform: Condition "!is_inside_tree()" is true. Returned: Transform()
<C++ Source> scene/3d/spatial.cpp:268 @ get_global_transform()
<Stack Trace> :0 @ void Godot.NativeCalls.godot_icall_0_19(IntPtr , IntPtr , Godot.Transform& )()
Spatial.cs:314 @ Godot.Transform Godot.Spatial.GetGlobalTransform()()
Spatial.cs:42 @ Godot.Transform Godot.Spatial.get_GlobalTransform()()
NodeManagerTest.cs:28 @ void NodeManagerTest.<_Ready>b__2_0()()
:0 @ void System.Threading.Tasks.Task.InnerInvoke()()
:0 @ void System.Threading.Tasks.Task.Execute()()
:0 @ void System.Threading.Tasks.Task.ExecutionContextCallback(System.Object )()
:0 @ void System.Threading.ExecutionContext.RunInternal(System.Threading.ExecutionContext , System.Threading.ContextCallback , System.Object , Boolean )()
:0 @ void System.Threading.ExecutionContext.Run(System.Threading.ExecutionContext , System.Threading.ContextCallback , System.Object , Boolean )()
:0 @ void System.Threading.Tasks.Task.ExecuteWithThreadLocal(System.Threading.Tasks.Task& )()
:0 @ Boolean System.Threading.Tasks.Task.ExecuteEntry(Boolean )()
:0 @ void System.Threading.Tasks.Task.System.Threading.IThreadPoolWorkItem.ExecuteWorkItem()()
:0 @ Boolean System.Threading.ThreadPoolWorkQueue.Dispatch()()
:0 @ Boolean System.Threading._ThreadPoolWaitCallback.PerformWaitCallback()()
`
**Steps to reproduce:**
Simply debug though the solution with a breakpoint. If you don't debug, the issue seems to occur silently.
**Minimal reproduction project:**
Example Project: https://github.com/SuperMeip/Godot-globallocation-issue
|
bug,topic:dotnet
|
low
|
Critical
|
653,461,418 |
TypeScript
|
Property does not exist on `globalThis` immediately after declaring it
|
**Code**
```ts
declare module "buf" {
global {
class Buffer {}
}
import Buf = globalThis.Buffer;
export { Buf as Buffer };
}
```
**Expected behavior:**
No errors.
**Actual behavior:**
`Property 'Buffer' does not exist on type 'typeof globalThis'.`
**[Playground Link](https://www.typescriptlang.org/play/?ssl=1&ssc=1&pln=5&pc=18#code/CYUwxgNghgTiAEBbA9sArhBAiARmgZlvAN4CwAUPFfAOYTI5QQkXVvyRQDOX8AQgXwgYJAL6tq48hKoBLRAAdkMAC78C8ALy16jCABUAFrK4A6AfiEwA3DPggAHktUl1+eNzdX4o2+VFAA)**
|
Suggestion
|
low
|
Critical
|
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.