id
int64
393k
2.82B
repo
stringclasses
68 values
title
stringlengths
1
936
body
stringlengths
0
256k
βŒ€
labels
stringlengths
2
508
priority
stringclasses
3 values
severity
stringclasses
3 values
655,113,886
rust
Array of tuples containing functions trip on type inference?
<!-- Thank you for filing a bug report! πŸ› Please provide a short summary of the bug, along with any information you feel relevant to replicating the bug. --> Consider the following code: ```rust fn foo(_s: &mut [u8]) {} fn bar(_s: &mut [u8]) {} fn main() { let _works = [foo, bar]; //let _doesnt_work = [(foo,), (bar,)]; let _explicit_works: [(fn(&mut[u8]),);2] = [(foo,), (bar,)]; } ``` I expected the second assignment to be equivalent to the third. Instead, compilation fails with: ``` error[E0308]: mismatched types --> src/main.rs:7:34 | 7 | let _doesnt_work = [(foo,), (bar,)]; | ^^^ expected fn item, found a different fn item | = note: expected fn item `for<'r> fn(&'r mut [u8]) {foo}` found fn item `for<'r> fn(&'r mut [u8]) {bar}` ``` Nightly has a better error message: ``` = note: expected fn item `for<'r> fn(&'r mut [u8]) {foo}` found fn item `for<'r> fn(&'r mut [u8]) {bar}` = note: different `fn` items always have unique types, even if their signatures are the same = help: change the expected type to be function pointer `for<'r> fn(&'r mut [u8])` = help: if the expected type is due to type inference, cast the expected `fn` to a function pointer: `foo as for<'r> fn(&'r mut [u8])` ``` But with that clarification, I'd actually expect the first assignement to fail with the same error, but it doesn't.
T-compiler,A-inference,C-bug
low
Critical
655,115,220
PowerToys
[PowerRename] Advanced string formatting
# Summary of the new feature/enhancement PowerRename isn't quite powerful enough for my use case. In an effort to restrain myself from writing a competing tool, I would like to propose the following feature to PowerRename: Advanced String Formatting ![image](https://user-images.githubusercontent.com/9853156/87214128-1a787000-c2f8-11ea-9a82-a13169bcb5d6.png) <!-- A clear and concise description of what the problem is that the new feature would solve. Describe why and how a user would use this new functionality (if applicable). --> # Proposed technical implementation details (optional) Essentially, this feature would be powered by the C++ [fmt ](https://github.com/fmtlib/fmt) library. PowerRename will make available (at least) the following pre-defined format variables: - `{fullname}` - full file name (i.e. "lorem.pdf") - `{name}` - name without the extension (i.e. "lorem") - `{ext}` - extension (i.e. "pdf") - `{enum}` - current enum value If both "Enumerate Items" _and_ "Use Advanced String Formatting" are checked, the user has the option of specifying the starting enum value and the step. If they specify a letter instead of a number as the starting enum value, it would increment the letter (i.e. A,B,C,D). The other beauty of this, is that `fmt` is extremely powerful with its bracket expressions. This would take PowerRename to the next level. For example, you could do: `0x{enum:04x} - {fullname}` with starting value `15`, step `1` you would get: ``` 0x000F - lorem.pdf 0x0010 - ipseum.pdf ... ``` In short, it brings the full power of `fmt` to PowerRename So I guess this is kind of two features, but they synergize pretty well. This would also likely close a few existing issues: - #644 - #3814 I am willing to implement this and open a PR for it. However, I don't want to attempt making a PR without someone's blessing. <!-- A clear and concise description of what you want to happen. -->
Idea-Enhancement,Product-PowerRename
low
Major
655,127,105
excalidraw
Grid mode: Allow dot-sized circles
The smallest circle in grid mode you can make is diameter 1. It would be nice to allow a small circle to represent a dot: <img width="388" alt="Screen Shot 2020-07-10 at 20 47 23" src="https://user-images.githubusercontent.com/1473433/87215770-91a90680-c2ee-11ea-8496-32e4a170c679.png"> This is easier than making a tiny line (which works already when dragging, and also when using multi-point because subsequent points don't snap to the grid). Related to #1810
enhancement
low
Minor
655,131,919
neovim
'completefilterfunc'
# Intro We had a discussion about this on gitter the other day, see https://gitter.im/neovim/neovim?at=5f07781c46c75b1e5e3524ff Presently, all insert mode completion is based on exact prefix matches. This works great when you have a small list of candidates but as soon as your list of candidates grows large, it becomes frustrating to narrow down. You have to either type the exact prefix yourself or navigate the huge list. I propose we add a new option `fuzzy` to `completeopt` that will enable fuzzy completion in all completion modes. i.e omnifunc, file completion and keyword completion would all become fuzzy. This would make it much simpler to narrow the completion list when it becomes large and is a standard feature found in nearly every other modern editor. I am *not* proposing this become default as we want to avoid surprising existing users. # Why can't this be implemented with a plugin? The gitter link above discusses this in more detail but the problem is that plugins can only fetch the initial candidates fuzzily. As you type more characters, neovim narrows down the list of candidates itself instead of consulting whatever plugin is providing completions. Thus, as you type more characters, you have to provide the exact prefix to narrow down the list. It may seem to work if you have autocomplete enabled in which case when the list is narrowed down to zero candidates, the plugin will repopulate the list with new candidates based on fuzzy matching but this results in awkward flickering. See https://github.com/neovim/neovim/pull/8184#issuecomment-377431559 # Implementation We discussed that the current matching implementation is written in C and so difficult to extend. To implement this feature, it may be a good idea to switch the matching implementation to lua first and then add a fuzzy completoept. I'm not 100% sure as it may be easier to write only the fuzzy matching implementation in lua or reuse https://github.com/neovim/neovim/pull/8184/files which imports [fzy](https://github.com/jhawthorn/fzy). Please let me know how you think this is best implemented. I'm happy to lead this feature so feel free to assign me. I probably won't get to it soon though so if anyone else would like to take it off my hands, please feel free. cc @Shougo @clason @fsouza
enhancement,complexity:high,core
medium
Critical
655,148,154
terminal
Copy on Select ignore trailing whitespaces
# Description of the new feature/enhancement While copying on select, auto ignore trailing whitespaces on each line. # Why? In my `.vimrc`, I draw 80 column and 120 column line via background color like this: ![image](https://user-images.githubusercontent.com/841969/87218091-388ab280-c382-11ea-8df3-8b37e0ff85d5.png) ```vim function! SetColumnWarnOnResized() highlight Normal ctermbg=NONE if &columns > 120 let &colorcolumn="81,".join(range(120, &columns), ",") " Set the column warns on 80 and 120+ else let &colorcolumn="81" " Set the column warns on 80 endif endfunction au VimResized * call SetColumnWarnOnResized() call SetColumnWarnOnResized() ``` When I select and copy these words in the screenshot above, Windows Terminal will fill my clipboard with many whitespaces like this (notice that wired whitespaces): ``` Some texts here... And here... Notice the 80 col line in my vim ---------------------------------------------> And the 120 col line ================================================================================================> ``` And this only happend sometimes (not always), I don't know if this is a bug? # Related issues This issues may relatives to these issues: * #2944 * #3088
Issue-Bug,Area-TerminalControl,Product-Terminal,Priority-2
low
Critical
655,206,985
node
http2 crash on h2spec check
* **Version**: ``` PS C:\> node --version v14.5.0 ``` * **Platform**: ``` Microsoft Windows [Version 10.0.17763.1294] ``` ### What steps will reproduce the bug? 1. Just run a demo http2 server ```js const fs = require('fs'); const server = require('http2').createSecureServer({ cert: fs.readFileSync('localhost-cert.pem'), key: fs.readFileSync('localhost-privkey.pem') }); server.on('error', (err) => console.error(err)); server.on('stream', (stream, headers) => { stream.respond({ 'content-type': 'application/json', ':status': 200 }); stream.end('{"hello":"world"}'); }); server.listen(8181); ``` 2. run h2spec - https://github.com/summerwind/h2spec/releases/tag/v2.5.0 ``` PS C:\> h2spec --version Version: 2.5.0 (8b58a5e5cc9590ac7a470dc1c01065ae575bbf25) PS C:\> h2spec.exe -kt -p 8181 Generic tests for HTTP/2 server 1. Starting HTTP/2 βœ” 1: Sends a client connection preface 2. Streams and Multiplexing βœ” 1: Sends a PRIORITY frame on idle stream βœ” 2: Sends a WINDOW_UPDATE frame on half-closed (remote) stream βœ” 3: Sends a PRIORITY frame on half-closed (remote) stream βœ” 4: Sends a RST_STREAM frame on half-closed (remote) stream βœ” 5: Sends a PRIORITY frame on closed stream 3. Frame Definitions 3.1. DATA βœ” 1: Sends a DATA frame βœ” 2: Sends multiple DATA frames βœ” 3: Sends a DATA frame with padding 3.2. HEADERS βœ” 1: Sends a HEADERS frame βœ” 2: Sends a HEADERS frame with padding βœ” 3: Sends a HEADERS frame with priority 3.3. PRIORITY βœ” 1: Sends a PRIORITY frame with priority 1 βœ” 2: Sends a PRIORITY frame with priority 256 βœ” 3: Sends a PRIORITY frame with stream dependency βœ” 4: Sends a PRIORITY frame with exclusive βœ” 5: Sends a PRIORITY frame for an idle stream, then send a HEADER frame for a lower stream ID 3.4. RST_STREAM βœ” 1: Sends a RST_STREAM frame 3.5. SETTINGS βœ” 1: Sends a SETTINGS frame 3.7. PING βœ” 1: Sends a PING frame 3.8. GOAWAY βœ” 1: Sends a GOAWAY frame 3.9. WINDOW_UPDATE βœ” 1: Sends a WINDOW_UPDATE frame with stream ID 0 βœ” 2: Sends a WINDOW_UPDATE frame with stream ID 1 3.10. CONTINUATION βœ” 1: Sends a CONTINUATION frame βœ” 2: Sends multiple CONTINUATION frames 4. HTTP Message Exchanges βœ” 1: Sends a GET request Γ— 2: Sends a HEAD request -> The endpoint MUST respond to the request. Expected: HEADERS Frame (stream_id:1) Actual: Connection closed Γ— 3: Sends a POST request Error: dial tcp 127.0.0.1:8181: connectex: No connection could be made because the target machine actively refused it. PS C:\> h2spec --version Version: 2.5.0 (8b58a5e5cc9590ac7a470dc1c01065ae575bbf25) ``` 3. nodejs crashed ```js PS C:\> node .\index.js events.js:291 throw er; // Unhandled 'error' event ^ Error [ERR_STREAM_WRITE_AFTER_END]: write after end at ServerHttp2Stream.Writable.write (_stream_writable.js:292:11) at ServerHttp2Stream.Writable.end (_stream_writable.js:555:10) at Http2SecureServer.<anonymous> (C:\var\vcs\git\misc\scratch\nodejs\node-h2-demo\index.js:18:10) at Http2SecureServer.emit (events.js:314:20) at ServerHttp2Session.sessionOnStream (internal/http2/core.js:2769:19) at ServerHttp2Session.emit (events.js:314:20) at emit (internal/http2/core.js:291:8) at processTicksAndRejections (internal/process/task_queues.js:83:22) Emitted 'error' event on ServerHttp2Stream instance at: at emitErrorNT (internal/streams/destroy.js:100:8) at processTicksAndRejections (internal/process/task_queues.js:80:21) { code: 'ERR_STREAM_WRITE_AFTER_END' } ``` ### How often does it reproduce? Is there a required condition? It crashed every time. ### What is the expected behavior? h2spec should be passed all tests. At least the node js process should not crash. ### What do you see instead? node js process crashed every time.
http2
low
Critical
655,216,403
PowerToys
[Run] UAC dialog box doesn't get focus after hitting enter on "Run As Administrator" button
``` Windows build number: 10.0.19041.329 PowerToys version: v0.19.1 PowerToy module for which you are reporting the bug (if applicable): Run ``` # Steps to reproduce 1. Set UAC Settings to "Do not Dim" 2. Launch PowerToys Run 3. Type name of any program that you would like to start 4. Hit "tab" button in order to focus on "Run As Administrator" button or use `Ctrl + Shift + Enter` shortcut # Expected behavior "User Account Control" dialog box appears with the action button "No" focussed. So you can use your keyboard to press either button on the UAC dialog box. # Actual behavior "User Account Control" dialog box appears above the PowerToys search box but the UAC dialog itself doesn't get focussed. The PowerToys Run search box stays focussed. So you cannot use your keyboard to press any button on the UAC dialog box. If you run any program from the Windows Start Menu the UAC dialog gets focussed right after you hit the "Run As Administrator" button. # Screenshots ![Hvf0jA1cl7](https://user-images.githubusercontent.com/290543/87225579-dd16ef80-c396-11ea-99b3-1e5a2290a721.gif)
Issue-Bug,Product-PowerToys Run,Priority-3
low
Critical
655,223,460
godot
Build error with MSYS2/mingw64, uses wrong path to windres.exe
<!-- Please search existing issues for potential duplicates before filing yours: https://github.com/godotengine/godot/issues?q=is%3Aissue --> **Godot version:** <!-- Specify commit hash if using non-official build. --> git master branch。 **OS/device including version:** <!-- Specify GPU model, drivers, and the backend (GLES2, GLES3, Vulkan) if graphics-related. --> windows 1903; msys2 - mingw64; ``` $ gcc -v Using built-in specs. COLLECT_GCC=C:\msys64\mingw64\bin\gcc.exe COLLECT_LTO_WRAPPER=C:/msys64/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/10.1.0/lto-wrapper.exe Target: x86_64-w64-mingw32 Configured with: ../gcc-10.1.0/configure --prefix=/mingw64 --with-local-prefix=/mingw64/local --build=x86_64-w64-mingw32 --host=x86_64-w64-mingw32 --target=x86_64-w64-mingw32 --with-native-system-header-dir=/mingw64/x86_64-w64-mingw32/include --libexecdir=/mingw64/lib --enable-bootstrap --with-arch=x86-64 --with-tune=generic --enable-languages=c,lto,c++,fortran,ada,objc,obj-c++ --enable-shared --enable-static --enable-libatomic --enable-threads=posix --enable-graphite --enable-fully-dynamic-string --enable-libstdcxx-filesystem-ts=yes --enable-libstdcxx-time=yes --disable-libstdcxx-pch --disable-libstdcxx-debug --disable-isl-version-check --enable-lto --enable-libgomp --disable-multilib --enable-checking=release --disable-rpath --disable-win32-registry --disable-nls --disable-werror --disable-symvers --disable-plugin --with-libiconv --with-system-zlib --with-gmp=/mingw64 --with-mpfr=/mingw64 --with-mpc=/mingw64 --with-isl=/mingw64 --with-pkgversion='Rev3, Built by MSYS2 project' --with-bugurl=https://sourceforge.net/projects/msys2 --with-gnu-as --with-gnu-ld Thread model: posix Supported LTO compression algorithms: zlib zstd gcc version 10.1.0 (Rev3, Built by MSYS2 project) ``` ``` $ scons -v SCons by Steven Knight et al.: script: v3.1.2.bee7caf9defd6e108fc2998a2520ddb36a967691, 2019-12-17 02:07:09, by bdeegan on octodog engine: v3.1.2.bee7caf9defd6e108fc2998a2520ddb36a967691, 2019-12-17 02:07:09, by bdeegan on octodog engine path: ['/usr/lib/python3.8/site-packages/SCons'] Copyright (c) 2001 - 2019 The SCons Foundation ``` ``` $ python --version Python 3.8.3 ``` **Issue description:** <!-- What happened, and what was expected. --> build error. **Steps to reproduce:** ``` $ scons platform=windows use_mingw=yes scons: Reading SConscript files ... Package x11 was not found in the pkg-config search path. Perhaps you should add the directory containing `x11.pc' to the PKG_CONFIG_PATH environment variable No package 'x11' found Configuring for Windows: target=debug, bits=default Using MinGW Checking for C header file mntent.h... no scons: done reading SConscript files. scons: Building targets ... [Initial build] Compiling ==> platform/windows/godot_windows.cpp [Initial build] Compiling ==> platform/windows/crash_handler_windows.cpp [Initial build] Compiling ==> platform/windows/os_windows.cpp [Initial build] Compiling ==> platform/windows/display_server_windows.cpp platform/windows/display_server_windows.cpp:432:2: warning: #warning touchscreen not working [-Wcpp] 432 | #warning touchscreen not working | ^~~~~~~ [Initial build] Compiling ==> platform/windows/key_mapping_windows.cpp [Initial build] Compiling ==> platform/windows/joypad_windows.cpp [Initial build] Compiling ==> platform/windows/windows_terminal_logger.cpp [Initial build] Compiling ==> platform/windows/vulkan_context_win.cpp [Initial build] Compiling ==> platform/windows/context_gl_windows.cpp [Initial build] build_res_file(["platform/windows/godot_res.windows.tools.64.o"], ["platform/windows/godot_res.rc"]) scons: *** [platform/windows/godot_res.windows.tools.64.o] Error 1 scons: building terminated because of errors. ``` **Minimal reproduction project:** <!-- A small Godot project which reproduces the issue. Drag and drop a zip archive to upload it. -->
bug,platform:windows,topic:buildsystem
low
Critical
655,241,980
rust
consider disallowing setting target_family if target_os=none
Should setting target_family require also setting target_os? Currently, the `x86_64-linux-kernel` target sets target_family to "unix", but the os is "none". This is the only target which sets the family without the os. This can make it a little confusing/awkward when writing `cfg` expressions to properly cover targets such as these (sometimes the check for os="none" needs to appear before the family). In practice today this isn't an issue because libcore, liballoc, and compiler_builtins do not ever check the family. AFAIK, the family doesn't have any other effects other than the `cfg` settings. This issue came up during #74033 where I was adjusting some `cfg` expressions for building std for Cargo. I do not know if Cargo's build-std will ever support `x86_64-linux-kernel`, but I'd like to try to cover as many targets as possible and avoid special cases if they are not necessary. @eddyb had some [suggestions](https://github.com/rust-lang/rust/pull/74033#discussion_r453144971) which I'll copy here: > Does the Linux kernel even have an UNIX API inside of itself? That doesn't sound right but maybe I just haven't seen it before. > > (To be clear, I'm thinking that family="unix" is as valid for inside an OS kernel as os="thatosname" - if os="none" is used then surely there should also not be a family? Maybe we should enforce that the family is derived from the OS name and therefore means "OS family") cc @joshtriplett who I think might know a little about the `x86_64-linux-kernel` target, and @alex who introduced the target. Perhaps they can shed some light why "unix" was chosen.
A-codegen,O-bare-metal
medium
Major
655,246,901
godot
Creating a trimesh static body from a mesh with blend shapes does not take blend shapes into account
**Godot version:** 3.2.2 **OS/device including version:** Linux Mint 20 OpenGL ES 3.0 Renderer: GeForce 940MX/PCIe/SSE2 **Issue description:** When you have a model imported with blend shapes, and you create a trimesh static body from it, it ignores the blend shape settings you have provided and creates the static body as if all keys were 0. So this is my model: ![image](https://user-images.githubusercontent.com/7745457/87229831-caf37c00-c3ab-11ea-94a2-3ca232227dc3.png) But this is the collision shape: ![Screenshot from 2020-07-11 19-22-42](https://user-images.githubusercontent.com/7745457/87229865-068e4600-c3ac-11ea-9eb2-990dad5ac242.png) **Little project:** Open `res://level/lvl1.tscn` for the mesh [snowball.zip](https://github.com/godotengine/godot/files/4907314/snowball.zip)
enhancement,topic:core,topic:editor,confirmed
low
Minor
655,253,093
vscode
Add support for SteppingGranularity in the UI
Having https://github.com/microsoft/vscode/issues/90793 is fantastic (and we just shipped a version of the Julia extension that supports [this feature](https://www.julia-vscode.org/docs/v0.17/release-notes/v0_17/#Support-for-step-in-targets-in-the-debugger-1)). So now I'm of course wondering whether we could also have built-in support for `SteppingGranularity` from the DAP in the UI? :)
feature-request,debug
medium
Critical
655,255,238
godot
Wrapping is inconsistent in control nodes
**Godot version:** v3.2.2.stable.official **Issue description:** The wrapping reacts different in different nodes when the last character(s) on the line are spaces. They all seem to have a different approach/method when wrapping. ![ISSUE](https://user-images.githubusercontent.com/52723367/87230772-49ebb300-c3b2-11ea-97d8-4467df68edca.png) (I have used the exact same string on each one, and btw they occupy the same width) The expected behaviour is to all nodes "react"/have the same output/format with the exact same string/text. In my case, I needed some nodes to overlap and react the same as a TextEdit. But when the wrap reacts different, breaks it: ![demo](https://user-images.githubusercontent.com/52723367/87230906-2f660980-c3b3-11ea-95cb-71b7fdcd0459.png) **Steps to reproduce:** Add different text nodes (TextEdit, label, etc) wich ocuppies the same width and put a text with some spaces at the end of the line (when the wrapping should take effect). And see the different results in different nodes. (But I've made a small project, wich is faster) **Minimal reproduction project:** [InconsistentWrap.zip](https://github.com/godotengine/godot/files/4907384/InconsistentWrap.zip)
bug,topic:gui
low
Minor
655,260,859
rust
Unexpected panic building debug target for tonic crate, on armv7
`cargo build` fails with a compiler error when compiling the tonic crate on a Raspberry Pi (armv7). `cargo build --release` succeeds, and building a debug target succeeds on other architectures. <!-- Thank you for finding an Internal Compiler Error! 🧊 If possible, try to provide a minimal verifiable example. You can read "Rust Bug Minimization Patterns" for how to create smaller examples. http://blog.pnkfx.org/blog/2019/11/18/rust-bug-minimization-patterns/ --> ### Code `tonic = "0.2"` is a dependency. Tonic's state in Cargo.lock is: ``` [[package]] name = "tonic" version = "0.2.1" source = "registry+https://github.com/rust-lang/crates.io-index" checksum = "4afef9ce97ea39593992cf3fa00ff33b1ad5eb07665b31355df63a690e38c736" ``` ### Meta <!-- If you're using the stable version of the compiler, you should also check if the bug also exists in the beta or nightly versions. --> `rustc --version --verbose`: ``` rustc 1.44.1 (c7087fe00 2020-06-17) binary: rustc commit-hash: c7087fe00d2ba919df1d813c040a5d47e43b0fe7 commit-date: 2020-06-17 host: armv7-unknown-linux-gnueabihf release: 1.44.1 LLVM version: 9.0 ``` ### Error output ``` cargo build Compiling tonic v0.2.1 thread 'rustc' panicked at 'no name in item_ident', src/librustc_metadata/rmeta/decoder.rs:660:24 stack backtrace: 0: 0x7198f0bc - backtrace::backtrace::libunwind::trace::h11ac3ac0d74302ad at /cargo/registry/src/github.com-1ecc6299db9ec823/backtrace-0.3.46/src/backtrace/libunwind.rs:86 1: 0x7198f0bc - backtrace::backtrace::trace_unsynchronized::hdf62c917e9b2ef6e at /cargo/registry/src/github.com-1ecc6299db9ec823/backtrace-0.3.46/src/backtrace/mod.rs:66 2: 0x7198f0bc - std::sys_common::backtrace::_print_fmt::h0bfe64f9222ce2f3 at src/libstd/sys_common/backtrace.rs:78 3: 0x7198f0bc - <std::sys_common::backtrace::_print::DisplayBacktrace as core::fmt::Display>::fmt::h1215cde72a82cc12 at src/libstd/sys_common/backtrace.rs:59 4: 0x719c3a38 - core::fmt::write::h6236afb532da25eb at src/libcore/fmt/mod.rs:1069 5: 0x71981200 - std::io::Write::write_fmt::h9a6af9b5531b16e1 at src/libstd/io/mod.rs:1504 6: 0x71993c5c - std::sys_common::backtrace::_print::h4580c18962130b5c at src/libstd/sys_common/backtrace.rs:62 7: 0x71993c5c - std::sys_common::backtrace::print::he77ad506192e88b6 at src/libstd/sys_common/backtrace.rs:49 8: 0x71993c5c - std::panicking::default_hook::{{closure}}::h4563d9a366d32d4d at src/libstd/panicking.rs:198 9: 0x71993914 - std::panicking::default_hook::h73d18278dcd23830 at src/libstd/panicking.rs:218 10: 0x71d88680 - rustc_driver::report_ice::hdee5593caf9f2a4d 11: 0x71994374 - std::panicking::rust_panic_with_hook::h164a10eb665809d3 at src/libstd/panicking.rs:515 12: 0x71993fa8 - rust_begin_unwind at src/libstd/panicking.rs:419 13: 0x719c001c - core::panicking::panic_fmt::hc42ca5828f8f3331 at src/libcore/panicking.rs:111 14: 0x719bfc60 - core::option::expect_failed::h7c9d5072a576e290 at src/libcore/option.rs:1260 15: 0x74c1a4b0 - rustc_metadata::rmeta::decoder::<impl rustc_metadata::creader::CrateMetadataRef>::item_ident::h1e7a5981242482de 16: 0x74b00928 - <core::iter::adapters::Map<I,F> as core::iter::traits::iterator::Iterator>::fold::hb1963ac093435d67 17: 0x74c15e3c - rustc_metadata::rmeta::decoder::cstore_impl::<impl rustc_metadata::creader::CStore>::struct_field_names_untracked::h6efd1899fe2b5069 18: 0x73fbf648 - rustc_resolve::build_reduced_graph::BuildReducedGraphVisitor::build_reduced_graph_for_external_crate_res::hecbbde89bbee3fda 19: 0x7404df24 - rustc_resolve::Resolver::resolutions::h2f6f7d07f53b570d 20: 0x74037e24 - rustc_resolve::imports::<impl rustc_resolve::Resolver>::resolve_ident_in_module_unadjusted_ext::hdb8823839984132b 21: 0x74050700 - rustc_resolve::Resolver::resolve_ident_in_module_ext::h80b7134a6bc040fc 22: 0x7403ac48 - rustc_resolve::imports::ImportResolver::resolve_import::{{closure}}::hf0d99a9e9db6637d 23: 0x73f99c88 - rustc_resolve::imports::ImportResolver::resolve_imports::h5e2c840b70dbf842 24: 0x7403cc50 - rustc_resolve::macros::<impl rustc_expand::base::Resolver for rustc_resolve::Resolver>::resolve_imports::h9e73e7e41f49dc0e 25: 0x74dd07c4 - rustc_expand::expand::MacroExpander::fully_expand_fragment::h85c4caf18e2b912c 26: 0x74dcffac - rustc_expand::expand::MacroExpander::expand_crate::he8d946de4a244787 27: 0x7203d398 - rustc_session::utils::<impl rustc_session::session::Session>::time::h9ea925d1846ab204 28: 0x72097804 - rustc_interface::passes::configure_and_expand_inner::h68c79f1f5e94993d 29: 0x7201e85c - rustc_interface::passes::configure_and_expand::{{closure}}::hd0f8d74f2054835e 30: 0x72009ddc - rustc_data_structures::box_region::PinnedGenerator<I,A,R>::new::ha7835f89edb6e576 31: 0x72096b4c - rustc_interface::passes::configure_and_expand::hc941f962e455593c 32: 0x720e80dc - rustc_interface::queries::Queries::expansion::h4b199728d4409dbd 33: 0x71eb00f0 - rustc_interface::interface::run_compiler_in_existing_thread_pool::h6a513a83086f1dc1 34: 0x71d914c8 - scoped_tls::ScopedKey<T>::set::h14880974a2d9ed06 35: 0x71d8ee20 - rustc_ast::attr::with_globals::hadcb0e7aba072992 36: 0x71d9b0dc - std::sys_common::backtrace::__rust_begin_short_backtrace::hd86ffecd76139a10 37: 0x71eb33f8 - core::ops::function::FnOnce::call_once{{vtable.shim}}::h7109e48681c2cee6 38: 0x719a1748 - <alloc::boxed::Box<F> as core::ops::function::FnOnce<A>>::call_once::h1c3beb23b66aaaa9 at /rustc/c7087fe00d2ba919df1d813c040a5d47e43b0fe7/src/liballoc/boxed.rs:1008 39: 0x719a1748 - <alloc::boxed::Box<F> as core::ops::function::FnOnce<A>>::call_once::h97bc9ba054374f8f at /rustc/c7087fe00d2ba919df1d813c040a5d47e43b0fe7/src/liballoc/boxed.rs:1008 40: 0x719a1748 - std::sys::unix::thread::Thread::new::thread_start::h4bc05a65c7f95744 at src/libstd/sys/unix/thread.rs:87 error: internal compiler error: unexpected panic note: the compiler unexpectedly panicked. this is a bug. note: we would appreciate a bug report: https://github.com/rust-lang/rust/blob/master/CONTRIBUTING.md#bug-reports note: rustc 1.44.1 (c7087fe00 2020-06-17) running on armv7-unknown-linux-gnueabihf note: compiler flags: -C debuginfo=2 --crate-type lib note: some of the compiler flags provided by cargo are hidden query stack during panic: end of query stack error: could not compile `tonic`. To learn more, run the command again with --verbose. ``` </p> </details>
I-ICE,A-metadata,O-Arm,T-compiler,C-bug
low
Critical
655,263,963
flutter
[flutter_tools] flutter doctor does not recognize portapps version of Intellij
I used to have a portable development environment, having a IntelliJ IDEA Ultimate installed in a external SSD drive (https://portapps.io/app/intellij-idea-ultimate-portable/). The problem is when I run "flutter doctor -v", the flutter doesn't recognise the portable version (and I initially understand, because is not in the default directory). But the problem is that I haven't a option to do manually the search. The command "flutter config --android-studio-dir" doesn't work even if I use a Android Studio portable. I have everything configured correctly in my external drive, including all system environment variables. Here is my current "flutter doctor -v" output: `[√] Flutter (Channel stable, v1.17.5, on Microsoft Windows [Version 10.0.18363.900], locale en-GB) β€’ Flutter version 1.17.5 at Z:\SDK\Flutter β€’ Framework revision 8af6b2f038 (10 days ago), 2020-06-30 12:53:55 -0700 β€’ Engine revision ee76268252 β€’ Dart version 2.8.4 [√] Android toolchain - develop for Android devices (Android SDK version 30.0.1) β€’ Android SDK at Z:\SDK\Android β€’ Platform android-30, build-tools 30.0.1 β€’ ANDROID_HOME = Z:\SDK\Android β€’ Java binary at: Z:\SDK\OpenJDK\bin\java β€’ Java version OpenJDK Runtime Environment (AdoptOpenJDK)(build 1.8.0_252-b09) β€’ All Android licenses accepted. [!] Android Studio (not installed) β€’ Android Studio not found; download from https://developer.android.com/studio/index.html (or visit https://flutter.dev/docs/get-started/install/windows#android-setup for detailed instructions). [!] Connected device ! No devices available ! Doctor found issues in 2 categories.`
tool,t: flutter doctor,P3,team-tool,triaged-tool
low
Major
655,269,399
pytorch
ConvTranspose1d layer behaviour under different channel numbers
## πŸ“š Documentation Documentation for [ConvTranspose1d layer](https://pytorch.org/docs/master/generated/torch.nn.ConvTranspose1d.html) does not contain even brief explanation of how channels are treated and how number of channels affect processing. Same goes for [Conv1d layer](https://pytorch.org/docs/master/generated/torch.nn.Conv1d.html) but it was at least covered in [this discussion](https://discuss.pytorch.org/t/understanding-convolution-1d-output-and-input/30764/2) and is somewhat more obvious. With transposed convolution it is easy to find dozens of sites, books and animations explainig how it happens but I have not found a single mention that happens when there is multiple input channels and how they are reduced to single output channel. There are several questions on discuss.pytorch.org which seem relevant: 1. https://discuss.pytorch.org/t/how-to-use-torch-nn-convtranspose1d-to-take-the-derivative-of-torch-nn-conv1d-function/32620 2. https://discuss.pytorch.org/t/upsampling-convtranspose2d-getting-the-original-tensor-size/51936 3. https://discuss.pytorch.org/t/understanding-conv2d-and-convtranspose2d/42142 4. https://discuss.pytorch.org/t/convtranspose2d-weight-shape/52528 In the end, I just created ConvTranspose1d layer, feed it with constant values and hypothesized that it: 1. applies transposed convolution to each input channel independently 2. sum results for each channels, adds bias and push it to output channel 3. multiple output channels just use different set of kernels and produce different values cc @jlin27
module: docs,module: convolution,triaged
low
Minor
655,270,286
deno
[Feature Request] Native API for "controlling terminal" stream
In some cases, such as a [Git Credential Helper](https://git-scm.com/docs/gitcredentials#_custom_helpers), a script needs to get both program arguments through stdin, and prompt the user for data. In Linux, this is done by opening [/dev/tty](https://linux.die.net/man/4/tty) which is, according to the manpage, a handle to the process' _controlling terminal_, which is a separate stream from stdin. I have also noticed that Deno currently has no handle in its API for such a stream, so for now there's no cross-platform/native solution to this. My suggestion is adding a `Deno.tty` handle to Deno's API, similar to the `Deno.stdin` handle, to allow for cross-platform usage of this feature. Edit: On further research, according to [this page](http://blade.nagaokaut.ac.jp/cgi-bin/scat.rb/ruby/ruby-talk/146259) from the bottom of the internet, something like this could work easily for mac, linux and windows. Edit2: On even [further research](https://en.wikipedia.org/wiki/Device_file#PC_DOS,_TOS,_OS/2,_and_Windows), i got the wrong Windows device name. Edited in the code snippet. ``` //Within the Deno namespace: export const tty = Deno.build.os === "windows"?await Deno.open("CON:"):await Deno.open("/dev/tty"); ```
cli,public API,suggestion
low
Minor
655,273,499
bitcoin
Use of C++ undefined behavior in various `IteratorComparators`
**Expected behavior** All C++ code to be 100% using legal C++ and not UB which can lead to subtle bugs if not now, then perhaps in the future. **Actual behavior** Use of undefined behavior in at least two places: - https://github.com/bitcoin/bitcoin/blob/42fe6aad326f62c7e6ea12ee873149257f67ce5d/src/net_processing.cpp#L227 - https://github.com/bitcoin/bitcoin/blob/42fe6aad326f62c7e6ea12ee873149257f67ce5d/src/miner.h#L67 **Background** Please see this part of the C++ specification: https://en.cppreference.com/w/cpp/language/operator_comparison In particular I will quote the relevant section here: > If two pointers are not specified to compare greater or compare equal, the result of the comparison is unspecified. The result may be nondeterministic, and need not be consistent even for multiple evaluations of the same expression with the same operands in the same execution of the program: ```c++ int x, y; bool f(int* p, int* q) { return p < q; } assert(f(&x, &y) == f(&x, &y)); // may fire in a conforming implementation ``` Note that in the above-linked section (which I admit is difficult to decipher) -- pointers are only specified to have a legal `<` or `>` comparison operations if the objects they point to either belong to the same array, or if the objects they point to live basically as members in the same object (i.e. as class members). *This is unlike in C*. The code will compile.. it will run -- but like the above section states, and the above sample program illustrates -- the results may be non-deterministic! In practice it appears the code works in bitcoin for all known compilers and platforms -- but is not guaranteed to do so forever and may lead to subtle bugs in the future as compilers evolve or as `libstdc++` evolves.
Bug
low
Critical
655,276,144
go
proposal: sizeof: add bit sizes
See the tail of the (open) [CL 242018](https://go-review.googlesource.com/c/go/+/242018) for the (approved) proposal #29982. There are a number of use cases where bits, not bytes as `unsafe.Sizeof` and `sizeof.Xxx` speak in, are really useful and it is a shame that you have to manually derive them, `const UintBits = sizeof.Uint * 8`, as this is error prone. Instead we should expose constants for bit sizes too: ```go package sizeof const ( bitsSize = size * 8 // 32 or 64 BitsBool = 8 BitsByte = Uint8 BitsComplex64 = 64 BitsComplex128 = 128 BitsFloat32 = 32 BitsFloat64 = 64 BitsInt = bitsSize BitsUint8 = 8 BitsInt16 = 16 BitsInt32 = 32 BitsInt64 = 64 BitsRune = BitsInt32 BitsUint = bitSize BitsUint8 = 8 BitsUint16 = 16 BitsUint32 = 32 BitsUint64 = 64 BitsUintptr = bitSize ) ``` We could derive `BitsXxx` from `Xxx * 8`, but the current format seems more terse and intuitive. As well, the names could use a suffix, `XxxBits`, instead of the current prefix, since we get custom ordering for blocked constants, but to me, prefixes displays better and follows other standard library conventions: `http.StatusXxx` and `xxx.ErrYyy`. Depending on the use case, we could instead export a constant or function for deriving these values. While the former is still prone to user error, it should be intuitive for users familiar with `time.Duration`. The latter seems like a blocker because functions cannot be compile time constant: ```go // Bits stores the number of bits in a byte. // // This is useful for converting byte type sizes into bits: // const UintBits = sizeof.Uint * sizeof.Bits const Bits = 8 ``` ```go // Bits converts byte sizes into bits. // // This is useful for converting byte type sizes into bits: // var UintBits = sizeof.Bits(sizeof.Uint) func Bits(bytes int) int { return bytes * 8 } ```
Proposal,Proposal-Hold
low
Critical
655,277,883
go
proposal: sizeof: add synthetic, pointer-like types
The (approved) proposal #29982, excludes complex and dynamic types from the new `sizeof` package. For primitive, value-like types (structs and arrays), this is in required, since they are of variable length. But synthetic, pointer-like types (channels, functions, interfaces, maps, slices, and strings) instead point to their data and are of constant size. Can we add the following types: ```go package sizeof const ( Channel = Uintptr Function = Uintptr Int = Uint Interface = Uintptr * 2 Map = Uintptr Slice = Uintptr + Int*2 String = Uintptr + Int ) ``` Technically one can calculate the `unsafe.Sizeof` any of these types today, but the intention of the `sizeof` package is to make that unsafe interface less necessary. Furthermore, while these types are more complex, we can add test cases to ensure that new architectures or changes to the implementation of these types are reflected in `sizeof`.
Proposal
low
Major
655,293,755
neovim
terminal-cursor disappears after quitting ranger and newsboat in nvim-terminal
- `nvim --version`: 0.4.3 - `vim -u DEFAULTS` (version: 8.2) behaves differently? No - Operating system/version: Arch Linux - Terminal name/version: xterm 357 - `$TERM`: xterm ### Steps to reproduce using `nvim -u NORC` with `newsboat` 1. `nvim -u NORC +te` 2. `i` 3. `echo url > urls` 4. `newsboat -u urls` 5. `q` ### Steps to reproduce using `nvim -u NORC` with `ranger` 1. `nvim -u NORC +te` 2. `i` 3. `ranger` 4. open a file 5. `:q<cr>` (close nvim) 6. `q` (close ranger) ### Actual behavior The cursor in the nvim-terminal is not visible anymore. It can be unhidden by executing ``` echo -en "\e[?25h" ``` ### Expected behavior The cursor should be visible after exiting newsboat. ### Notes Might be related #2708
bug,status:blocked-external,terminal
low
Minor
655,304,171
terminal
Scenario: Improved support for different graphics renditions [VT, SGR]
## Supported | Attribute | Standard | Stored | Rendered | As of | Notes | | --- | --- | --- | --- | --- | --- | | `1` Intensity (Bright) | VT100 | βœ” | βœ” | Always | | | `1` Intensity (Bold Weight) | VT100 | βœ” | βœ” | v1.10 | #109, #5682, https://github.com/microsoft/terminal/issues/2916#issuecomment-544880423 | | `2` Faint | ECMA-48 2nd | βœ” | βœ” | v1.3 | #6703 / #6873 | | `3` Italic | ECMA-48 2nd | βœ” | βœ” | v1.9 | #5461 | | `4` Underline | ECMA-48 2nd | βœ” | βœ” | Always | #6911<br />_as of v1.3, underline is rendered per font metrics_ | | `5` Blink | VT100 | βœ” | βœ” | v1.4 | #7388 | | `7` Reverse Video | VT100 | βœ” | βœ” | Always | | | `8` Conceal/Invisible | ECMA-48 2nd | βœ” | βœ” | v1.3 | #6876 | | `9` Crossed Out | ECMA-48 2nd | βœ” | βœ” | v1.3 | #6205 | | `21` Doubly Underlined | ECMA-48 3rd | βœ” | βœ” | v1.3 | #2916 | | `53` Overline | ECMA-48 4th | βœ” | βœ” | v1.2 | #6000 | ## Unsupported, Planned | Attribute | Standard | Stored | Rendered | Notes | | --- | --- | --- | --- | --- | | Fancy Underlines<br>(kitty) | _none_ | ❌ | ❌ | #7228 | ## Unsupported, Unplanned | Attribute | Standard | Stored | Rendered | Notes | | --- | --- | --- | --- | --- | | Extended Fonts<br>(mintty) | _none_ | ❌ | ❌ | #6779, _unplanned_ | ## Miscellaneous Related Issues * [ ] #4321 pursuant to ITU T.416 (ISO-8613-6), we should support (prefer?) `:` for subparameter separators instead of `;` * ("semicolon delimiters" are non-standard for SGR `38`, `48`; see terminfo [here](https://invisible-island.net/ncurses/terminfo.src.html#tic-xterm_direct))
Product-Conhost,Area-Rendering,Area-VT,Product-Terminal,Issue-Scenario
low
Major
655,306,522
excalidraw
Context menu is breaking zoom on mobile
This is not super easy to repro, but I eventually always get it: 1. Double tap to start text 2. Use two fingers to zoom out 3. Try until you get the context menu shown 4. Now zoom is broken and you can’t zoom back in https://www.dropbox.com/s/yerpgypb4a3oj5k/Video%20Jul%2011%2C%2017%2049%2027.mp4?dl=0
bug
low
Critical
655,317,651
flutter
[tool_crash] tool crashes running windows desktop on exit
## Command ``` flutter run -d windows -v -t .\lib\src\generator_2.dart ``` ## Steps to Reproduce Run windows desktop application, this happens occasionally during a quit. The kernel files might still be in use, so this deletion needs to be either delayed until app termination or allowed to fail ## Logs FileSystemException: Deletion failed, OS Error: The process cannot access the file because it is being used by another process. , errno = 32 ``` #0 _Directory._deleteSync (dart:io/directory_impl.dart:201:7) #1 FileSystemEntity.deleteSync (dart:io/file_system_entity.dart:458:47) #2 ForwardingFileSystemEntity.deleteSync (package:file/src/forwarding/forwarding_file_system_entity.dart:72:16) #3 ResidentRunner.preExit (package:flutter_tools/src/resident_runner.dart:1264:25) #4 HotRunner.preExit (package:flutter_tools/src/run_hot.dart:1152:17) <asynchronous suspension> #5 ResidentRunner.exit (package:flutter_tools/src/resident_runner.dart:947:11) <asynchronous suspension> #6 TerminalHandler._commonTerminalInputHandler (package:flutter_tools/src/resident_runner.dart:1500:30) #7 TerminalHandler.processTerminalInput (package:flutter_tools/src/resident_runner.dart:1584:13) #8 _rootRunUnary (dart:async/zone.dart:1198:47) #9 _CustomZone.runUnary (dart:async/zone.dart:1100:19) #10 _CustomZone.runUnaryGuarded (dart:async/zone.dart:1005:7) #11 _BufferingStreamSubscription._sendData (dart:async/stream_impl.dart:357:11) #12 _BufferingStreamSubscription._add (dart:async/stream_impl.dart:285:7) #13 _SyncBroadcastStreamController._sendData (dart:async/broadcast_stream_controller.dart:385:25) #14 _BroadcastStreamController.add (dart:async/broadcast_stream_controller.dart:250:5) #15 _AsBroadcastStreamController.add (dart:async/broadcast_stream_controller.dart:484:11) #16 _rootRunUnary (dart:async/zone.dart:1198:47) #17 _CustomZone.runUnary (dart:async/zone.dart:1100:19) #18 _CustomZone.runUnaryGuarded (dart:async/zone.dart:1005:7) #19 _BufferingStreamSubscription._sendData (dart:async/stream_impl.dart:357:11) #20 _BufferingStreamSubscription._add (dart:async/stream_impl.dart:285:7) #21 _SinkTransformerStreamSubscription._add (dart:async/stream_transformers.dart:69:11) #22 _EventSinkWrapper.add (dart:async/stream_transformers.dart:15:11) ``` ``` [βœ“] Flutter (Channel unknown, 1.20.0-8.0.pre.57, on Microsoft Windows [Version 10.0.18363.900], locale en-US) β€’ Flutter version 1.20.0-8.0.pre.57 at C:\Users\Jonah\flutter β€’ Framework revision 8bd2e6585b (7 hours ago), 2020-07-11 12:15:19 -0700 β€’ Engine revision 9b3e3410f0 β€’ Dart version 2.9.0 (build 2.9.0-21.0.dev 06cb010247) [βœ“] Android toolchain - develop for Android devices (Android SDK version 29.0.3) β€’ Android SDK at C:\Users\Jonah\AppData\Local\Android\sdk β€’ Platform android-29, build-tools 29.0.3 β€’ ANDROID_HOME = C:\Users\Jonah\AppData\Local\Android\sdk β€’ Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java β€’ Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b04) β€’ All Android licenses accepted. [βœ“] Chrome - develop for the web β€’ Chrome at C:\Program Files (x86)\Google\Chrome\Application\chrome.exe [βœ“] Visual Studio - develop for Windows (Visual Studio Community 2019 16.5.4) β€’ Visual Studio at C:\Program Files (x86)\Microsoft Visual Studio\2019\Community β€’ Visual Studio Community 2019 version 16.5.30011.22 β€’ Windows 10 SDK version 10.0.18362.0 [!] Android Studio (version 3.6) β€’ Android Studio at C:\Program Files\Android\Android Studio βœ— Flutter plugin not installed; this adds Flutter specific functionality. βœ— Dart plugin not installed; this adds Dart specific functionality. β€’ Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b04) [βœ“] VS Code (version 1.47.0) β€’ VS Code at C:\Users\Jonah\AppData\Local\Programs\Microsoft VS Code β€’ Flutter extension version 3.12.2 [βœ“] Connected device (4 available) β€’ Windows (desktop) β€’ windows β€’ windows-x64 β€’ Microsoft Windows [Version 10.0.18363.900] β€’ Web Server (web) β€’ web-server β€’ web-javascript β€’ Flutter Tools β€’ Chrome (web) β€’ chrome β€’ web-javascript β€’ Google Chrome 83.0.4103.116 β€’ Edge (web) β€’ edge β€’ web-javascript β€’ Microsoft Edge 83.0.478.58 ! Doctor found issues in 1 category. ``` ## Flutter Application Metadata **Type**: app **Version**: 1.0.0+1 **Material**: false **Android X**: false **Module**: false **Plugin**: false **Android package**: null **iOS bundle identifier**: null **Creation channel**: master **Creation framework version**: 8b9935a5a8857c3146fedf33d744f8b31b35540a
c: crash,tool,P2,team-tool,triaged-tool
low
Critical
655,323,211
go
crypto: import fiat-crypto implementations
The fiat-crypto project (https://github.com/mit-plv/fiat-crypto) generates formally-verified, high-performance modular arithmetic implementations, useful for crypto primitives like Curve25519, Poly1305, and the NIST ECC curves that are used within the Go standard library. They're currently working on a Go backend. BoringSSL has imported their implementations for Curve25519 and P-256: https://boringssl.googlesource.com/boringssl/+/master/third_party/fiat/ At https://go-review.googlesource.com/c/crypto/+/242177, I've uploaded a WIP CL that imports their Curve25519 implementation (w/ minor tweaks), and demonstrates a significant performance improvement over the current "generic" implementation. (The existing amd64 assembly implementation is still considerably faster though.) This proposal is to import and make use of those implementations. Open questions: 1. Which algorithms should be imported? BoringSSL only imports two. Should we import more? 2. Do we import both 32-bit and 64-bit implementations? We could import just one implementation and still get a performance speedup (e.g., 386 sees a -10% performance boost with curve25519_fiat_64.go, and amd64 sees a -30% boost with curve25519_fiat_32.go), but they do better still with the CPU-appropriate implementations (-30% for 386 w/ 32-bit, and -61% for amd64 w/ 64-bit). 3. How should the code be imported? E.g., should it be separated into a third_party or vendor directory with its own LICENSE file like how BoringSSL does it? /cc @agl @FiloSottile
Proposal,Proposal-Accepted,Proposal-Crypto
high
Major
655,345,001
go
x/image/webp: WebP decode contrast issue
# What version of Go are you using (`go version`)? <pre> go version go1.13.7 windows/amd64 </pre> ### Does this issue reproduce with the latest release? Yes. ### What operating system and processor architecture are you using (`go env`)? <details><summary><code>go env</code> Output</summary><br><pre> $ go env set GO111MODULE=off set GOARCH=amd64 set GOBIN= set GOCACHE=C:\Users\Alpha\AppData\Local\go-build set GOENV=C:\Users\Alpha\AppData\Roaming\go\env set GOEXE=.exe set GOFLAGS= set GOHOSTARCH=amd64 set GOHOSTOS=windows set GONOPROXY= set GONOSUMDB= set GOOS=windows set GOPATH=C:\Users\Alpha\go set GOPRIVATE= set GOPROXY=https://proxy.golang.org,direct set GOROOT=c:\go set GOSUMDB=sum.golang.org set GOTMPDIR= set GOTOOLDIR=c:\go\pkg\tool\windows_amd64 set GCCGO=gccgo set AR=ar set CC=gcc set CXX=g++ set CGO_ENABLED=1 set GOMOD= set CGO_CFLAGS=-g -O2 set CGO_CPPFLAGS= set CGO_CXXFLAGS=-g -O2 set CGO_FFLAGS=-g -O2 set CGO_LDFLAGS=-g -O2 set PKG_CONFIG=pkg-config set GOGCCFLAGS=-m64 -mthreads -fmessage-length=0 -fdebug-prefix-map=C:\Users\Alpha\AppData\Local\Temp\go-build034800510=/tmp/go-build -gno-record-gcc-switches </pre></details> ### What did you do? I opened up a webp using go, and saved it back to png, The output was different from the source. Other golang webp decoding packages parsed it correctly. ```go package main import ( "image" "image/png" "os" // you can swap between these two libs, chai2010 is okay "golang.org/x/image/webp" //"github.com/chai2010/webp" ) func main() { tileStream, _ := os.Open("full.webp") tile, _ := webp.Decode(tileStream) defer tileStream.Close() outputStream, _ := os.Create("full.png") png.Encode(outputStream, tile) defer outputStream.Close() } ``` ### What did you expect to see? ![b(1)](https://user-images.githubusercontent.com/8333794/87240839-924cb480-c436-11ea-97de-b0bf0f4566f9.png) This is the source image, notice the details and the clarity. ### What did you see instead? ![full](https://user-images.githubusercontent.com/8333794/87240846-9c6eb300-c436-11ea-9299-20f99656d459.png) This is the converted, the details are dimmed, the contrast is lower. Other webp decoding libs maintain the contrast.
NeedsInvestigation
medium
Critical
655,353,616
material-ui
[theme] Remove hardcoded breakpoints
<!-- Provide a general summary of the issue in the Title above --> There are several places in the codebase where breakpoints are hardcoded. Since we have the ability to override breakpoints, we should not have hardcoded values in the code <!-- Thank you very much for contributing to Material-UI by creating an issue! ❀️ To avoid duplicate issues we ask you to check off the following list. --> <!-- Checked checkbox should look like this: [x] --> - [x] The issue is present in the latest release. - [x] I have searched the [issues](https://github.com/mui-org/material-ui/issues) of this repository and believe that this is not a duplicate. ## Current Behavior 😯 1. PropTypes ```javascript PropTypes.oneOf(['xs', 'sm', 'md', 'lg', 'xl']), PropTypes.arrayOf(PropTypes.oneOf(['xs', 'sm', 'md', 'lg', 'xl'])), ``` 2. Styles ```javascript [theme.breakpoints.only('xs')]: { ... } ``` 3. Functions in withWidth.js ```javascript import { breakpointKeys } from '../styles/createBreakpoints'; function isWidthUp(...){ return breakpointKeys.indexOf(...) } function isWidthDown(...){ return breakpointKeys.indexOf(...) } ``` ## Expected Behavior πŸ€” 1. PropTypes ```javascript PropTypes.string PropTypes.arrayOf(PropTypes.string), ``` 2. Styles a) Use a media query only if there is such a breakpoint in the theme ```javascript [theme.breakpoints.only(theme.breakpoints.keys['xs'] ?? 0)]: { ... } ``` b) Add a new property `alias` to `createBreakpoints` function to match breakpoints ```javascript createBreakpoints({ values: { tablet: 640, laptop: 1024, desktop: 1280, }, alias: { xs: 'tablet', sm: 'tablet', }, } }) ``` 3. Functions in withWidth.js a) Show the necessity for breakpoints Remove `import { breakpointKeys } from '../styles/createBreakpoints'`; ```javascript function isWidthUp(breakpoints, breakpoint, width, inclusive = true){ .. } ``` b) Add breakpoints to options implicitly ```javascript import { breakpointKeys } from '../styles/createBreakpoints' function isWidthUp(breakpoint, width, opts = {}) { let {breakpoints = breakpointKeys, inclusive = true } = opts; ... } ``` ## Your Environment 🌎 <!-- Include as many relevant details about the environment with which you experienced the bug. If you encounter issues with typescript please include version and tsconfig. --> | Tech | Version | | ----------- | ------- | | Material-UI | v4.11.0 |
new feature,package: material-ui,design
low
Critical
655,360,303
opencv
Memory allocation in Win/MacOS
Win 10, OpenCV e3d502310f6ae0cad79f3474b9ea2b25705985f9. MacOS 10.14.6. This ```` std::shared_ptr<SIFT> sift = SIFT::create(); ```` code throw exception ```` OpenCV(4.4.0-pre) E:\Lib_prebuild\opencv\source\opencv\modules\core\src\alloc.cpp:73: error: (-4:Insufficient memory) Failed to allocate 13107200000 bytes in function 'cv::OutOfMemoryError' ```` in Windows, but works fine on the same PC in MacOS VBox. At the time of running this code in Windows about 30 Gb RAM was free, and Windows was rebooted before run (so I think RAM was not fragmented). 10 GB RAM was provided for the MacOS virtual machine. Processed image size is 32000 x 26500. This exception also throws with SURF.
feature,category: features2d
low
Critical
655,372,736
react-native
[Android] TextInput's padding is ignored when sibling suspends
Sorry if I had to re-use the same title of [this other issue](https://github.com/facebook/react-native/issues/27307) but basically I find that issue well written (except for a useful repro that could be there) and so there was no reason to modify it. ### Be warned when using the examples because the changes you apply to the code may autorefresh and the padding gets applied in this way too, so you would not notice the bug. In fact I've put up a setTimeout of 6 seconds that directly trigger a rerender showing you that with the new string the padding gets applied ## Description This issue is in **Android only**. If a TextInput has paddingLeft applied and has sibling component(s) which uses suspense, on the first render the padding won't be applied. If the parent component rerenders, then the padding is applied. Though the parent rerendering is common when using controlled components, it is not when using uncontrolled components (I discovered this and it's very noticeable with react-hook-form which uses uncontrolled components). ## React Native version: ``` info Fetching system and libraries information... System: OS: macOS 10.15.5 CPU: (4) x64 Intel(R) Core(TM) i5-6500 CPU @ 3.20GHz Memory: 3.99 GB / 16.00 GB Shell: 5.7.1 - /bin/zsh Binaries: Node: 14.4.0 - ~/.nvm/versions/node/v14.4.0/bin/node Yarn: 1.22.4 - /usr/local/bin/yarn npm: 6.14.5 - ~/.nvm/versions/node/v14.4.0/bin/npm Watchman: Not Found Managers: CocoaPods: 1.9.3 - /usr/local/bin/pod SDKs: iOS SDK: Platforms: iOS 13.5, DriverKit 19.0, macOS 10.15, tvOS 13.4, watchOS 6.2 Android SDK: API Levels: 28, 29, 30 Build Tools: 28.0.3, 30.0.0 System Images: android-30 | Google Play Intel x86 Atom Android NDK: Not Found IDEs: Android Studio: 4.0 AI-193.6911.18.40.6514223 Xcode: 11.5/11E608c - /usr/bin/xcodebuild Languages: Java: 1.8.0_252 - /usr/bin/javac Python: 2.7.16 - /usr/bin/python npmPackages: @react-native-community/cli: Not Found react: 16.13.1 => 16.13.1 react-native: 0.63.0 => 0.63.0 npmGlobalPackages: *react-native*: Not Found ``` ## Steps To Reproduce Provide a detailed list of steps that reproduce the issue. 1. Create a suspending component 2. Place a TextInput with a paddingLeft as a sibling of the suspending component 3. Watch the padding not getting applied on first render ## Expected Results I expect the padding to be applied immediately on first render. ## Snack, code example, screenshot, or link to a repository: Here you have the snack link: https://snack.expo.io/zYq9TXJ0w Here a repo to repro this on your local env based on rn init with react-native -v 0.63.0: https://github.com/giacomocerquone/rn_textinput_padding_suspense_bug_android Before rerender triggered by setTimeout: ![Screenshot_1594549843](https://user-images.githubusercontent.com/9303791/87244347-dcd12f80-c43c-11ea-9e5c-942575a519a5.png) After rerender triggered by setTimeout: ![Screenshot_1594549848](https://user-images.githubusercontent.com/9303791/87244349-df338980-c43c-11ea-809e-8ba88bf834e0.png)
Component: TextInput,Platform: Android,Needs: Triage :mag:
medium
Critical
655,375,433
rust
Tracking Issue for raw slice getters (slice_ptr_get)
This is a tracking issue for indexing methods on raw slices: `get_unchecked(_mut)` and `as_(mut_/non_null_)ptr` on raw slices (mutable and const raw pointers and `NonNull`). The feature gate for the issue is `#![feature(slice_ptr_get)]`. ### Public API ```rust impl<T> *mut [T] { pub const fn as_mut_ptr(self) -> *mut T {} pub unsafe fn get_unchecked_mut<I>(self, index: I) -> *mut I::Output where I: SliceIndex<[T]>; } impl<T> *const [T] { pub const fn as_ptr(self) -> *const T {} pub unsafe fn get_unchecked<I>(self, index: I) -> *const I::Output where I: SliceIndex<[T]>; } impl<T> NonNull<[T]> { pub const fn as_non_null_ptr(self) -> NonNull<T> {} pub const fn as_mut_ptr(self) -> *mut T {} pub unsafe fn get_unchecked_mut<I>(self, index: I) -> NonNull<I::Output> where I: SliceIndex<[T]>; } ``` ### History / Steps - [x] Initial PR: https://github.com/rust-lang/rust/pull/73986 - [x] Add `NonNull::as_mut_ptr`: https://github.com/rust-lang/rust/pull/75248 - [ ] Final commenting period (FCP) - [ ] Stabilization PR ### Open questions * Potential blockers: https://github.com/rust-lang/rust/issues/73987, https://github.com/rust-lang/rust/issues/74679 * Should this use `arbitrary_self_types` (https://github.com/rust-lang/rfcs/pull/3519)
T-libs-api,B-unstable,C-tracking-issue,A-slice,Libs-Tracked,Libs-Small,A-raw-pointers
medium
Critical
655,379,135
godot
[Bullet] Bullet physics PhysicsDirectBodyState.get_total_gravity() returns Vector3(0, 0, 0) in the first physics frame.
<!-- Please search existing issues for potential duplicates before filing yours: https://github.com/godotengine/godot/issues?q=is%3Aissue --> **Godot version:** Version 3.2.2 stable <!-- Specify commit hash if using non-official build. --> **OS/device including version:** GPU: AMD RX 580 driver - 20.4.2 OS: Windows 10 10.0.18363 <!-- Specify GPU model, drivers, and the backend (GLES2, GLES3, Vulkan) if graphics-related. --> **Issue description:** This issue is physics related. In theory, adding a force equal to the weight of an object in the opposite direction of gravity should counteract the force of gravity, making it suspend in mid air. However, in practice the objects gains a small but very noticeable upward velocity of 0.1633... When this is done with using the `state.get_total_gravity()` to get the force to counteract gravity, everything works fine. After printing both values (weight and total gravity's Y) their value is 9.8 and -9.8 respectively (for an object with mass 1) The absolute values of these two variables are practically the same but they yield a different result. <!-- What happened, and what was expected. --> **Steps to reproduce:** Create an object with a RigidBody call `add_central_force()` with it's weight as the Y value. Notice how the objects gains a velocity of 0.1633... Then do the same with but inside the `_integrate_forces()` call, using the negative of the `get_total_gravity()` as the counter force. Notice how the object is stationary (as expected). **Minimal reproduction project:** [PhysicsExample.zip](https://github.com/godotengine/godot/files/4908366/PhysicsExample.zip) <!-- A small Godot project which reproduces the issue. Drag and drop a zip archive to upload it. -->
bug,topic:physics
low
Minor
655,382,784
flutter
[google_maps_flutter] setMapStyle takes time to load, user is presented with blank map view
I'm using a custom map style for the Google Maps Flutter package. Implemented with this code ```dart void _onMapCreated(GoogleMapController controller) { setState(() { _mapController = controller; _mapController.setMapStyle(_mapStyle).whenComplete(() { showMap = true; }); });} ``` Current "problem" (more like an imperfection): the style is set after the map is loaded, so the user first gets a white screen, then the standard Google Maps style and after all that the custom style. This happens very fast, but there is a noticeable "flash". Especially when you're using a dark mode map style. What I tried: 1. putting with Stack a black container on top of the google map widget (that' visible when showMap is set to false), so I can set the bool showMap to true if everything is loaded. Doesn't work because whenComplete get's fired when the setMapStyle is almost done (so there's still a flash). (tested in debug). Solutions I could think of with the current possibilities: loading the google maps widget in the background on another screen, so when the user taps on the screen that has the google map widget, the map is already fully loaded. I tried an approach to this with the cupertinotabbar and a statefull widget (with the google maps widget inside, that has keepAliveClientMixin enabled) and stack but the map kept reloading. Are there other approaches to this? A nice feature would be: Possibility to set a map style before the map is created Or if the above feature is really difficult / almost impossible to implement: Possibility to set a background color when the map isn't loaded yet (currently this color is white and has a big contrast with custom map style's that are darker).
p: maps,package,team-ecosystem,has reproducible steps,P2,found in release: 1.21,found in release: 2.0,found in release: 2.3,triaged-ecosystem
low
Critical
655,393,657
rust
MaybeUninit::assume_init optimizes poorly
In #74254 we observed that returning expr.assume_init() from a function unexpectedly inhibits the return value from being constructed in place up front. https://rust.godbolt.org/z/hr77qM ```rust #![allow(deprecated)] use std::mem::{self, MaybeUninit}; use std::ptr; type T = String; const N: usize = 2; // fast pub fn a() -> [T; N] { Default::default() } // fast pub fn b() -> [T; N] { unsafe { // ignore the UB for now let mut array: [T; N] = mem::uninitialized(); for slot in &mut array { ptr::write(slot, T::default()); } array } } // slow pub fn c() -> [T; N] { let mut array: MaybeUninit<[T; N]> = MaybeUninit::uninit(); unsafe { // ignore the UB for now // ordinarily would cast to &mut [MaybeUninit<T>; N] // but here we try to minimize difference from `b` let slots = &mut *array.as_mut_ptr(); for slot in slots { ptr::write(slot, T::default()); } array.assume_init() } } ``` Notice that in the slow function the return value is constructed exactly the same as in both of the fast functions (6 instructions) except in the wrong place, then relocated from \[rsp-48\] to \[rdi\] :cry: (12 instructions). ```asm example::a: mov rax, rdi mov qword ptr [rdi], 1 vxorps xmm0, xmm0, xmm0 vmovups xmmword ptr [rdi + 8], xmm0 mov qword ptr [rdi + 24], 1 vmovups xmmword ptr [rdi + 32], xmm0 ret example::b: mov rax, rdi mov qword ptr [rdi], 1 vxorps xmm0, xmm0, xmm0 vmovups xmmword ptr [rdi + 8], xmm0 mov qword ptr [rdi + 24], 1 vmovups xmmword ptr [rdi + 32], xmm0 ret example::c: sub rsp, 48 mov rax, rdi mov qword ptr [rsp], 1 vxorps xmm0, xmm0, xmm0 vmovups xmmword ptr [rsp + 8], xmm0 mov qword ptr [rsp + 24], 1 vmovups xmmword ptr [rsp + 32], xmm0 mov rcx, qword ptr [rsp] mov qword ptr [rdi], rcx vmovups xmm0, xmmword ptr [rsp + 8] vmovups xmmword ptr [rdi + 8], xmm0 mov rcx, qword ptr [rsp + 24] mov qword ptr [rdi + 24], rcx mov rcx, qword ptr [rsp + 16] mov qword ptr [rdi + 16], rcx mov rcx, qword ptr [rsp + 24] mov qword ptr [rdi + 24], rcx vmovups xmm0, xmmword ptr [rsp + 32] vmovups xmmword ptr [rdi + 32], xmm0 add rsp, 48 ret ```
I-slow,A-codegen,E-needs-test,T-compiler
low
Major
655,398,016
rust
Allow `unsafe` modifier before control flow blocks like `unsafe match`, `unsafe loop`, etc.
# Motivation I don't know why we not yet allow unsafe before: `match`, `loop`, `while`, `for` (1). I agree that `unsafe if` is ambiguous as we don't know for sure if the unsafe is applied to only the first `if` or all other `else` clauses. Not allowing `unsafe` modifier before (1) makes people have to indent the code for no other benefits. ```rust unsafe fn foo<T>(t: T) -> T { unimplemented!() } fn bar<T>(t: T, yes: bool) -> Option<T> { unsafe { match yes { true => Some(foo(t)), false => None, } } } ``` With allowing `unsafe` modifier: ```rust fn bar<T>(t: T, yes: bool) -> Option<T> { unsafe match yes { true => Some(foo(t)), false => None, } } ``` # Downsides * Allow `unsafe` modifier makes grepping for `unsafe {` is not enough for finding all unsafe blocks in functions/methods. * This may be overused because when there are no need to indent code for too long, people may not split unsafe blocks to smaller scope. cc @RalfJung
T-lang,C-feature-request
low
Minor
655,401,959
storybook
addon-docs [6.0.0-rc3]: skip option in dynamic source rendering not doing anything
**Describe the bug** Upgraded from an older beta version of storybook 6 to the latest rc, and found some issues related to the new dynamic source rendering feature, introduced in pull request #11332 My sb setup is somewhat complicated, using custom decorators to setup the company-internal framework neded to display my components in storybook. When viewing the source in docs, i would like to show only the code originating from the story and not the decorators. To this end, I looked around in the storybook source (jsxDecorator.ts) and found that there is an option 'skip' that does what i need. However, this option does not seem to have any effect on the 'show code' output in docs. It does seem to be running the related code though, as I can for example trigger a warning in the console if I set the skip option too high. Other options, like showFunctions, seem to be working fine. **To Reproduce** Steps to reproduce the behavior: 1. Use latest 6.0.0 storybook rc release 2. Set the skip-parameter as following `export default { title: "Components/TestComponent", parameters: { jsx: { skip: 1 }, }, };` for any story where the story source is nested, for example `<OuterComponent> <InnerComponent>Test</InnerComponent> </OuterComponent> ` 3. Open the story in docs mode and click view source 4. Source is the same regardless of skip-parameter. **Expected behavior** The output source should be stripped of its outermost containing element in the case of skip = 1. **Screenshots** If applicable, add screenshots to help explain your problem. **Code snippets** If applicable, add code samples to help explain your problem. **System:** Environment Info: System: OS: Windows 10 10.0.18363 CPU: (8) x64 Intel(R) Core(TM) i7-8650U CPU @ 1.90GHz Binaries: Node: 14.5.0 - C:\Program Files\nodejs\node.EXE Yarn: 1.22.4 - C:\Program Files (x86)\Yarn\bin\yarn.CMD npm: 6.14.5 - C:\Program Files\nodejs\npm.CMD Browsers: Edge: 44.18362.449.0 npmPackages: @storybook/addon-controls: ^6.0.0-beta.29 => 6.0.0-rc.3 @storybook/addon-docs: ^6.0.0-beta.23 => 6.0.0-rc.3 @storybook/addon-jest: ^6.0.0-beta.23 => 6.0.0-rc.3 @storybook/addon-knobs: ^6.0.0-beta.23 => 6.0.0-rc.3 @storybook/addons: ^6.0.0-beta.23 => 6.0.0-rc.3 @storybook/react: ^6.0.0-beta.23 => 6.0.0-rc.3 **Additional context** Add any other context about the problem here.
bug,addon: docs,block: source
low
Critical
655,405,494
storybook
addon-docs [6.0.0-rc3]: child render props not showing with dynamic source rendering
**Describe the bug** In order to show my components in storybook, I use a custom decorator to setup an internal framework. A part of this internal framework is wrapping story code with a component utilizing child render props. However, this does not seem to work with dynamic source rendering, since the source output that I get cuts off at the component utilizing child render props. **To Reproduce** Steps to reproduce the behavior: 1. Wrap a story with a component utilizing child render props (more common in a decorator than an actual story i suppose) 2. Open the component in docs mode, and view source 3. Only the wrapping component is shown in output, not the containing elements. **Expected behavior** Both wrapping component and child components shown. At least this would be desirable when using a wrapper as I'm describing, not sure if there are cases when this is not desirable? **Screenshots** Story code: ![bild](https://user-images.githubusercontent.com/1229038/87247999-5544ea00-c457-11ea-90dc-94ed2affe475.png) Output source: ![bild](https://user-images.githubusercontent.com/1229038/87248028-79083000-c457-11ea-8b13-c72ed558e406.png) **Code snippets** If applicable, add code samples to help explain your problem. **System:** Environment Info: System: OS: Windows 10 10.0.18363 CPU: (8) x64 Intel(R) Core(TM) i7-8650U CPU @ 1.90GHz Binaries: Node: 14.5.0 - C:\Program Files\nodejs\node.EXE Yarn: 1.22.4 - C:\Program Files (x86)\Yarn\bin\yarn.CMD npm: 6.14.5 - C:\Program Files\nodejs\npm.CMD Browsers: Edge: 44.18362.449.0 npmPackages: @storybook/addon-controls: ^6.0.0-beta.29 => 6.0.0-rc.3 @storybook/addon-docs: ^6.0.0-beta.23 => 6.0.0-rc.3 @storybook/addon-jest: ^6.0.0-beta.23 => 6.0.0-rc.3 @storybook/addon-knobs: ^6.0.0-beta.23 => 6.0.0-rc.3 @storybook/addons: ^6.0.0-beta.23 => 6.0.0-rc.3 @storybook/react: ^6.0.0-beta.23 => 6.0.0-rc.3 **Additional context** Add any other context about the problem here.
bug,has workaround,addon: docs,block: source
low
Critical
655,409,969
pytorch
SGD documentatiuon detail on g_{t+1}
## πŸ“š Documentation In the docs https://pytorch.org/docs/master/optim.html#torch.optim.SGD and and inside the class https://pytorch.org/docs/stable/_modules/torch/optim/sgd.html#SGD I notice v_{t+1} & = \mu * v_{t} + g_{t+1}, p_{t+1} & = p_{t} - \text{lr} * v_{t+1}, But consulting the "On the importance of initialization and momentum in deep learning" by Sutskever et al the update rule for the `v_{t+1}` should be written in this way v_{t+1} & = \mu * v_{t} + g_{t}, that is the gradient `g` is taken at the moment `t` and not `t+1`. Am I wrong? cc @vincentqb
module: optimizer,triaged
low
Minor
655,413,173
pytorch
[discussion] Comparison operator chaining
This is not supported by NumPy, but maybe this could produce a BoolTensor instead. It seems to me that Python converts this code to an if statement, and hence the error about conversion to bool. If that's the case, then my proposal can't be implemented: https://www.python.org/dev/peps/pep-0535/, and probably there wouldn't be even any savings from fusion. But maybe someone from PyTorch could join the PEP discussion, if this is considered interesting. ```python import torch, numpy x = 0.3 print(0 < x < 0.5) # True x = torch.rand(10) print(0 < x < 0.5) # RuntimeError: bool value of Tensor with more than one value is ambiguous x = numpy.random.rand(10) print(0 < x < 0.5) # ValueError: The truth value of an array with more than one element is ambiguous. Use a.any() or a.all() ``` cc @izdeby
triaged,enhancement,module: boolean tensor
low
Critical
655,413,426
rust
validate rust-analyzer licenses
License validation (https://github.com/rust-lang/rust/blob/master/src/tools/tidy/src/deps.rs) for rust-analyzer is currently not being done. I think it would probably be good to include it in the license checks, just to double-check that something inappropriate doesn't slip in. I manually checked them, and they seem ok at this point. It would be helpful if the ra crates themselves included a license field in their Cargo.toml for automatic validation. cc @matklad
T-core,A-meta,A-licensing
low
Minor
655,439,861
godot
Crash importing possibly empty/corrupted .wav
<!-- Please search existing issues for potential duplicates before filing yours: https://github.com/godotengine/godot/issues?q=is%3Aissue --> **Godot version:** <!-- Specify commit hash if using non-official build. --> 3.2.2.stable.custom_build.0fe60f842 **OS/device including version:** <!-- Specify GPU model, drivers, and the backend (GLES2, GLES3, Vulkan) if graphics-related. --> Linux 5.7.7-arch1-1 **Issue description:** <!-- What happened, and what was expected. --> I tried to generate a voice clip using [espeak](https://github.com/espeak-ng/espeak-ng/). There's probably something else wrong, as I hear nothing when I play back the file with `mplayer`. However, this file completely crashed Godot, which isn't ideal even if it is corrupted. **Steps to reproduce:** 1. Create a .wav file using [espeak](https://github.com/espeak-ng/espeak-ng/): ``` espeak "Target Acquired!" -v en-us -p 0 -s 210 -g 1 --stdout > target_acquired.wav ``` 2. Move `target_acquired.wav` into a godot project directory 3. Open the project, see godot try to auto-import the wav 4. Godot crashes **Minimal reproduction project:** <!-- A small Godot project which reproduces the issue. Drag and drop a zip archive to upload it. --> This includes the offending file: [example.zip](https://github.com/godotengine/godot/files/4908918/example.zip)
bug,confirmed,topic:audio,topic:import,crash
low
Critical
655,440,524
electron
Windows Toast notifications activation issues
<!-- As an open source project with a dedicated but small maintainer team, it can sometimes take a long time for issues to be addressed so please be patient and we will get back to you as soon as we can. --> ### Preflight Checklist <!-- Please ensure you've completed the following steps by replacing [ ] with [x]--> * [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project. * [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to. * [x] I have searched the issue tracker for a feature request that matches the one I want to file, without success. ### Problem Description <!-- Is your feature request related to a problem? Please add a clear and concise description of what the problem is. --> The way toast notifications support is implemented on Windows doesn't feel quite right. The main issue I see is that it doesn't integrate well with Windows Action Center. I can highlight the following Action Center integration issues: 1. Once notification is displayed and moves to the Action Center, click events are not delivered to the app. 2. Notifications don't persist in the Action Center. If you open the Action Center once notification is displayed, you'll see the notification there, but the next time you open it - you'll see that notification is missing. 3. App can't be activated from the Action Center, i.e. when notification is clicked app window is not being brought to the foreground, and when app isn't running you can't start it by clicking on notification. There are several issues which mention the problems I described above: #20415 #21610 There were more issues closed as they were reported on an older electron versions. All this makes the app which uses electron toast notifications feel broken. I know that some people use userland packages like [electron-windows-notifications](https://github.com/felixrieseberg/electron-windows-notifications) and [electron-windows-interactive-notifications](https://github.com/felixrieseberg/electron-windows-interactive-notifications) as they implement full support of toasts on Windows. I looked in the code which implements toast notifications on Windows here: https://github.com/electron/electron/blob/master/shell/browser/notifications/win/windows_toast_notification.cc I see that it doesn't implement COM Activator. Besides that the way activation callback is registered, is going to work only when the process is running, it can't start the process from notification click. ### Proposed Solution <!-- Describe the solution you'd like in a clear and concise manner --> There are a few examples from Microsoft which mention how to implement that correctly: https://docs.microsoft.com/en-us/windows/uwp/design/shell/tiles-and-notifications/send-local-toast-desktop https://docs.microsoft.com/en-us/windows/uwp/design/shell/tiles-and-notifications/send-local-toast-desktop-cpp-wrl I propose to implement COM activator and expose APIs for activator registration in Windows registry and configuring app shortcut with activator GUID. It might also be required to update toast XML with `launch` property of `toast` element. Also, it will be required to update [electron-squirrel-startup](https://www.npmjs.com/package/electron-squirrel-startup) and [electron-winstaller](https://www.npmjs.com/package/electron-winstaller) packages to automatically handle registration mentioned above. On a related note, I think it would also be good to allow specifying user data string, which will be attached to toast XML and can be passed back along with `click` event. As I have prior experience with toast notifications implementation in another app on C++, I would like to implement a Pull Request for that ### Alternatives Considered <!-- A clear and concise description of any alternative solutions or features you've considered. --> As an alternative it's also possible to implement activation using `protocol` activation type. This way it will be required to register custom protocol handler which will be used to activate the app, but COM components registration stuff won't be required. ### Additional Information <!-- Add any other context about the problem here. --> I would highly appreciate any feedback from other electron contributors before I start working on the PR for that: opinions on the solution proposed, thoughts about complications of installation process. Also would be good to understand the reasoning behind implementation of notification support this way instead of implementing COM activator or protocol activation.
enhancement :sparkles:,platform/windows
low
Critical
655,442,412
godot
c# build logging not working
after months of working on a project I'm completely unable to continue working as my project suddenly refuses to run in the godot editor, citing build failure but the view logs button doesn't work, and building in visual studio succeeds! so there is no way to run my project nor to discover the cause of the alleged error! I tried getting help on the discord c# channel but eventually was advised to submit a ticket here in short, my project builds in visual studio (for Mac) but wont run in godot, (after running ok for months) ![image](https://user-images.githubusercontent.com/68197715/87252670-deb2e700-c46c-11ea-85fc-42ae76382e2c.png) ![image](https://user-images.githubusercontent.com/68197715/87252704-1faafb80-c46d-11ea-9248-873094f71640.png) ![image](https://user-images.githubusercontent.com/68197715/87252752-816b6580-c46d-11ea-99fc-6050a56da534.png)
bug,topic:dotnet
low
Critical
655,444,284
youtube-dl
Add support for PorCore
<!-- ###################################################################### WARNING! IGNORING THE FOLLOWING TEMPLATE WILL RESULT IN ISSUE CLOSED AS INCOMPLETE ###################################################################### --> ## Checklist <!-- Carefully read and work through this check list in order to prevent the most common mistakes and misuse of youtube-dl: - First of, make sure you are using the latest version of youtube-dl. Run `youtube-dl --version` and ensure your version is 2020.06.16.1. If it's not, see https://yt-dl.org/update on how to update. Issues with outdated version will be REJECTED. - Make sure that all provided video/audio/playlist URLs (if any) are alive and playable in a browser. - Make sure that site you are requesting is not dedicated to copyright infringement, see https://yt-dl.org/copyright-infringement. youtube-dl does not support such sites. In order for site support request to be accepted all provided example URLs should not violate any copyrights. - Search the bugtracker for similar site support requests: http://yt-dl.org/search-issues. DO NOT post duplicates. - Finally, put x into all relevant boxes (like this [x]) --> - [x] I'm reporting a new site support request - [x] I've verified that I'm running youtube-dl version **2020.06.16.1** - [x] I've checked that all provided URLs are alive and playable in a browser - [x] I've checked that none of provided URLs violate any copyrights - [x] I've searched the bugtracker for similar site support requests including closed ones ## Example URLs <!-- Provide all kinds of example URLs support for which should be included. Replace following example URLs by yours. --> - Single video: https://porcore.com/video/915/the-capture-of-the-asuka/ - Single video: https://porcore.com/video/1026/las-plagas/ - Single video: https://porcore.com/video/1080/no-gods-no-kings/ - Playlist: Site does NOT provide playlist facility. ## Description <!-- Provide any additional information. If work on your issue requires account credentials please provide them or explain how one can obtain them. --> Site seems to be a completely free site; no registration/login page is available at all. Some video makers seem to use this site to publish their videos. (The following is copied from the site's About page) Porcore has been started in the end of 2016 as a new project devoted to non-stardad and non-usual porn videos, which are created with computer graphics only! Initially, it began as a spin-off from Gamcore, which contained both sex games and sex videos. Currently there is absolutely no relation to any other projects and Porcore is living on his own. Porcore is about virtual sex videos only!
site-support-request
low
Critical
655,461,212
go
path/filepath: fix EvalSymLinks documentation
### What version of Go are you using (`go version`)? 1.14.4 ### What operating system and processor architecture are you using (`go env`)? Windows ### What did you do? Read the docs. ### What did you expect to see? Documentation to the effect that most applications on all operating systems should not use this API, unless they write complex additional logic to resolve just those links that they are interested in (e.g. searching through one volume only, although this API cannot reliably enable this specific scenario) or responsible for (e.g. system administration software). ### What did you see instead? `EvalSymLinks` intending to resolve all links in the path that it receives as argument, without any hint in the documentation that this might introduce issues due to system reconfigurations, amongst others. ### What do you propose to fix this? I propose documentation changes as the best solution for `EvalSymLinks` short of deleting this API altogether, which is not possible today since deleting or no-op'ing this API as proposed in #40104 violates go policies. #### `EvalSymLink` violates what Wikipedia calls the **[Fundamental Theorem of Software Engineering](https://en.wikipedia.org/wiki/Fundamental_theorem_of_software_engineering)** EvalSymLinks is not suitable for most applications on any operating system because it unconditionally undoes all indirections for a given path. This is a violation of the principle mentioned which states (in my wording more applicable here): > Any problem in software can be solved by adding another layer of indirection. `EvalSymLinks` always resolves all indirections, even those that might have been introduced to fix operational issues affecting the particular application using this API, or which might have been introduced to solve administrative problems on a system that applications should generally remain unaware of - such as disk full situations. I quote from Microsoft documentation: [Mounted Folders - Win32 apps | Microsoft Docs](https://docs.microsoft.com/en-us/windows/win32/fileio/volume-mount-points) > Neither users nor applications need information about the target volume on which a specific file is located. This API gives software no options to pick and choose to remove only those indirections that they are aware of, are designed to resolve, or have responsibility for. #### Practical reasons for most developers not to use `EvalSymLinks` Certainly on Windows, the practical usefulness and applicability of this API for most applications is severely limited by the following four facts: * **Most users do not expect to ever see resolved paths** On the contrary, especially those users that might *in some situations* want to see resolved paths may configure links for the specific purpose of abbreviating paths that they frequently use, in which case resolving links and showing them to the user is a severe and annoying usability issue beyond what it in most situations normally already is. Applications should hence always remember the path they were configured or started with and generally only ever show that to the user. I champion that this point stands firmly on any operating system besides Windows. * **Volume access paths and UNC mappings could change at any time** No reboot is necessary to create, change or delete junctions or links. Such events might hence invalidate results of `EvalSymLinks` at any time. No notification is given about such changes, unless the application specifically registers for them. But this is an advanced feature which is nontrivial to implement and test, even though go has/if go would have first-class support for this scenario. * **Access paths and mappings could be modified - including deleted - while files are in use that were opened using that access path** The path through which files or directories on a volume are accessible might hence change at a moments notice, even while the application is using files or directories whose access path(s) changed and the application might continue to open handles to the access path(s) it was configured with on another volume, while the application remains unaware, if it does not use the `EvalSymLinks` API, or if it takes care not to cache the result of `EvalSymLinks` in any way. * **Volume access paths and UNC mappings do not have to be created with a drive letter** And if they do, they do not need to point at the root of the drive with that letter (`Z:\`). This might be surprising to any developer that is not intimately aware of Windows internals and will produce issues as soon as they do not consistently use API that is itself properly aware of and tested thoroughly to work on Windows. Similar expectations and issues may arise about paths that require the use of the `\\?\` prefix, which complicates all operations with paths further, including long paths and volume GUID paths which `EvalSymLinks` may also introduce in any application on any machine. It is fair to note that `EvalSymLinks` is not the only source of such paths and Windows applications should be prepared to deal with them regardless of whether they use `EvalSymLinks` - such paths might even be introduced by user input directly, or through the operating system working directory at application start, or be intermittently visible while the system is being reconfigured. #### `EvalSymLinks` cannot be used to identify volumes in applicable advanced scenario's Finally, this API by design and as documented can on Windows not identify the volume on which a file or directory resides. Besides resolving UNC mappings, again only in advanced scenario's, this is - for as far as I have been able to identify - about the only situation where the above arguments against the use of `EvalSymLinks` may not always apply for all applications. Paths with a drive letter never identify volumes. Drive letters may in some trivial system configurations happen to correspond to identifiable volumes, but this can not and must never be relied upon. `EvalSymLink` definition, documentation and behavior on Windows reinforces this wrong assumption. That `EvalSymLinks` is of very limited use on Windows is strikingly evidenced by the configuration provided to reproduce issue #40176. This configuration is of particular interest, since `EvalSymLinks` provides here exactly zero information to the caller. Any path the application requests to be resolved will result in the exact path provided to `EvalSymLinks`, since the reparse point resolves to the exact same path as that of the directory that points to it. (before making the path relative and cleaning it, perhaps against statements in the documentation if the fact that an absolute link was resolved might have been lost - and a conforming result might confuse anyone) In fact, until #40095 is part of go, `EvalSymLinks` is completely unable to identify volumes on 64-bit Windows and other Windows installations that use GPT partitioning at all. With this fix, it is only able to do so if the volume happens to have its volume GUID path as its *only* access path. However now this is merely accidental, due to a fortunate side effect of Windows system architecture. On Windows systems that do not use GPT partitioning, or on (external) disks that do not use GPT, identifying volumes is simply not possible with a path alone, neither before nor after calling `EvalSymLinks`. ### How concretely do you propose to fix this? Change the documentation of `EvalSymLinks` in `src\path\filepath\path.go` to read: ``` // EvalSymlinks returns the path name after the evaluation of any symbolic // links. // If path is relative the result will be relative to the current directory, // unless one of the components is an absolute symbolic link. // EvalSymlinks calls Clean on the result. // Use of this function is unsuitable for the vast majority of applications. // This function always resolves all links on path, but links may have // been created to solve administrative problems of which // most applications should remain unaware. // Most applications should only resolve specific links that they // require to resolve, use the result immediately, forget the result // and never show the result to the user. // On Windows, the result is not stable and must not be cached // or stored in any way, resolving links may introduce complexities that // the application must be prepared to deal with and the result // does not identify the volume that a file or directory resides on. func EvalSymlinks(path string) (string, error) { return evalSymlinks(path) } ```
Documentation,OS-Windows,NeedsInvestigation
low
Critical
655,461,556
godot
Line2D editor and list of points in inspector are out of sync
<!-- Please search existing issues for potential duplicates before filing yours: https://github.com/godotengine/godot/issues?q=is%3Aissue --> **Godot version:** 4.0 dev: a474926aca8a5da810f8cf546902c6da7286b254 **OS/device including version:** Manjaro Linux x64, but that is not really relevant. **Issue description:** <!-- What happened, and what was expected. --> **Steps to reproduce:** 1) Create a new 2D scene 2) Add a Line2D 3) Open list of Points in the inspector 4) Create some points of the line (not in inspector, but in 2D view with edit buttons) 5) Observe that (any) changes made in the 2D view are not reflected in the inspector. 6) Close the list of points in inspector and open it again. Notice that all the changes are now here. 7) Do some more changes in the 2D view. 8) Notice, that they are still not being reflected in the inspector. 9) Delete some random point from the inspector. 10) Notice that the line changed. The points in inspector are now applied. Any changes made in 7) are lost. 11) Start deleting some more random points from the inspector 12) Observe, that all the changes does immediately apply to the Line2D itself, but not always to the orange overlay editing line. 13) Move the mouse to 2D view. Notice, that as soon as the mouse moved above the 2D view, the editing overlay line get in sync with the Line2D itself. **Conclusion and code investigation** The problem here is, that there are two places in the editor, that are editing the same vector of points. The list of points in the inspector and the Line2DEditor plugin. They both set the Line2D's set_points(...), which triggers it's update(...) method which updates Line2D's gfx, but there is not update towards either inspector, and/or Line2DEditor. This is my second attept to dive into the source code, so I am not 100% sure how exactly this should be resolved. Probably some signal that both inspector and Line2DEditor subscribe to? Anyway, I am opening this issue, rather than attempting to fix it myself.
bug,topic:editor
low
Minor
655,484,161
rust
Please impl Debug for other ABI fn types
Right now Debug is implemented for `fn` and `extern "C" fn` of all sorts of return types and argument counts. However, other ABIs (particularly `extern "system" fn`) cannot Debug print.
C-enhancement,T-libs-api
low
Critical
655,487,169
rust
Inefficient codegen with leading/ trailing zeros result manipulation.
As demonstrated in the two cases below, the compiler fails to produce optimal code for the equal branch. I'm assuming that it doesn't recognize the 64 as a constant and thus misses the opportunity to perform the stated manipulations at compile time. https://play.rust-lang.org/?version=nightly&mode=release&edition=2018&gist=d0c7af74498a9db149fa92c1b0c4d178 ```rust pub fn case_1(x: u64) -> u32 { x.leading_zeros() / 8 + 1 } pub fn case_2(x: u64) -> u32 { x.trailing_zeros() / 8 + 1 } ``` Generated assembly: ```asm playground::case_1: # @playground::case_1 # %bb.0: testq %rdi, %rdi je .LBB0_1 # %bb.2: bsrq %rdi, %rax xorq $63, %rax shrl $3, %eax addl $1, %eax retq .LBB0_1: movl $64, %eax shrl $3, %eax addl $1, %eax retq ``` Instead I would expect: ```asm playground::case_1: # @playground::case_1 # %bb.0: testq %rdi, %rdi je .LBB0_1 # %bb.2: bsrq %rdi, %rax xorq $63, %rax shrl $3, %eax addl $1, %eax retq .LBB0_1: movl $9, %eax retq ``` `case_2` output using `trailing_zeros` is comparable.
A-LLVM,I-slow,T-compiler
low
Minor
655,490,815
pytorch
torch.combinations() - Tried to allocate 7869836414.81 GiB
## πŸ› Bug <!-- A clear and concise description of what the bug is. --> When using `torch.combinations(list, r=len(list))` with the `r` value set to the length of the list, I get a `CUDA out of memory error` for values where the length of the list is higher than `9`, even though `torch.combinations(list, r=len(list))` should just return the list itself. Link to the PyTorch Forum Issue: https://discuss.pytorch.org/t/tried-to-allocate-7869836414-81-gib/88880 ## To Reproduce Steps to reproduce the behavior: ``` for i in range(1, 20): values = torch.arange(i) combinations = torch.combinations(values, r=i) print(combinations) ``` <!-- If you have a code sample, error messages, stack traces, please provide it here as well --> For a list of length 23: `CUDA out of memory error. Tried to allocate 7869836414.81 GiB (...)` ## Expected behavior <!-- A clear and concise description of what you expected to happen. --> `torch.combinations()` should return the list itself, when the `r` value is set to the length of the list. ## Environment Please copy and paste the output from our [environment collection script](https://raw.githubusercontent.com/pytorch/pytorch/master/torch/utils/collect_env.py) (or fill out the checklist below manually). You can get the script and run it with: ``` wget https://raw.githubusercontent.com/pytorch/pytorch/master/torch/utils/collect_env.py # For security purposes, please check the contents of collect_env.py before running it. python collect_env.py ``` - PyTorch Version (e.g., 1.0): 1.5.0 - OS (e.g., Linux): Ubuntu 20.04 - How you installed PyTorch (`conda`, `pip`, source): pip - Build command you used (if compiling from source): - Python version: 3.6.2 - CUDA/cuDNN version: Cua compilation tools, release 10.1, V10.1.243 - GPU models and configuration: RTX 2080 cc @ngimel
module: cuda,module: memory usage,triaged
low
Critical
655,500,658
flutter
Vertical linear gradient on TextStyle not rendering as gradient
<!-- Thank you for using Flutter! If you are looking for support, please check out our documentation or consider asking a question on Stack Overflow: * https://flutter.dev/ * https://api.flutter.dev/ * https://stackoverflow.com/questions/tagged/flutter?sort=frequent If you have found a bug or if our documentation doesn't have an answer to what you're looking for, then fill our the template below. Please read our guide to filing a bug first: https://flutter.dev/docs/resources/bug-reports --> I'm having trouble with vertical linear gradients on TextStyle. The behavior seems to be different between Flutter v1.12.13+hotfix.9 (tested hotfix.5 - hotfix.9) and v1.17.5 (tested 1.17.0 - 5), but in either version the gradients do not worked as expected. ## Steps to Reproduce 1. Starting with Flutter v1.12.13+hotfix.9, run `flutter create bug`. 2. Update the lib/main.dart with this code: ``` import 'package:flutter/material.dart'; import 'dart:ui' as ui; void main() { runApp(MyApp()); } class MyApp extends StatelessWidget { @override Widget build(BuildContext context) { return MaterialApp( title: 'TextStyle Gradient Bug', theme: ThemeData(), home: Scaffold( body: Center( child: Column( crossAxisAlignment: CrossAxisAlignment.center, mainAxisAlignment: MainAxisAlignment.center, children: <Widget>[ // At fontSize 73, shows as solid red in v1.17 and v1.12 - no vertical gradient. Text( 'dart:ui 73', style: TextStyle( fontSize: 73, fontStyle: FontStyle.normal, fontWeight: FontWeight.bold, foreground: Paint() ..shader = ui.Gradient.linear(Offset.zero, Offset(0, 73), [Colors.yellow, Colors.red])), ), // Only difference between this style and the one of above is the fontSize, but it shows as solid // yellow in v1.17 and solid red in v1.12 - no vertical gradient. Text( 'dart:ui 74', style: TextStyle( fontSize: 74, fontStyle: FontStyle.normal, fontWeight: FontWeight.bold, foreground: Paint() ..shader = ui.Gradient.linear(Offset.zero, Offset(0, 73), [Colors.yellow, Colors.red])), ), // This one changes the gradient 'to' to negative and we get the desired vertical gradient in v1.17, // but only yellow in v1.12 Text( 'dart:ui -73', style: TextStyle( fontSize: 74, fontStyle: FontStyle.normal, fontWeight: FontWeight.bold, foreground: Paint() ..shader = ui.Gradient.linear(Offset.zero, Offset(0, -73), [Colors.yellow, Colors.red])), ), // This one changes the gradient 'to' to negative and we get the desired vertical gradient in 1.17, // but only yellow in v1.12 Text( 'dart:ui -74', style: TextStyle( fontSize: 74, fontStyle: FontStyle.normal, fontWeight: FontWeight.bold, foreground: Paint() ..shader = ui.Gradient.linear(Offset.zero, Offset(0, -73), [Colors.yellow, Colors.red])), ), // A diagonal gradient works, unlike a vertical gradient Text( 'dart:ui d74', style: TextStyle( fontSize: 74, fontStyle: FontStyle.normal, fontWeight: FontWeight.bold, foreground: Paint() ..shader = ui.Gradient.linear(Offset(0, 73), Offset(411, 0), [Colors.yellow, Colors.red])), ), // Same diagonal gradient created with Flutter's LinearGradient Text( 'Flutter d74', style: TextStyle( fontSize: 74, fontStyle: FontStyle.normal, fontWeight: FontWeight.bold, foreground: Paint() ..shader = LinearGradient( begin: Alignment.bottomLeft, end: Alignment.topRight, colors: [Colors.yellow, Colors.red]).createShader(Rect.fromLTWH(0, 0, 411, 73))), ), // Vertical gradient fails - just yellow on v1.12, and solid red on v1.17 Text( 'Flutter v74', style: TextStyle( fontSize: 74, fontStyle: FontStyle.normal, fontWeight: FontWeight.bold, foreground: Paint() ..shader = LinearGradient( begin: Alignment.bottomCenter, end: Alignment.topCenter, colors: [Colors.yellow, Colors.red]).createShader(Rect.fromLTWH(0, 0, 411, 73))), ), ], ), ), ), ); } } ``` 3. Run the app on Android using an Android 9 API 28 emulator on Ubuntu Linux and take a screenshot. 4. Change your Flutter SDK version to v1.17.5 and rebuild/re-run on the same emulator and take a screenshot. 5. Run again on a physical Pixel 3 XL running Android 10. **Expected results:** 1. Expected vertical linear gradients running from yellow on top to red on the bottom for the text "dart:ui 73" and "dart:ui 74". 2. Expected vertical linear gradients running from red on top to yellow on the bottom for the text "dart:ui -73" and "dart:ui -74". 3. Expected diagonal linear gradients running bottom left to top right from yellow to red for "dart:ui d74" and "Flutter d74". 4. Expected vertical linear gradient running from bottom to top, yellow to red for "Flutter v74". **Actual results:** For Flutter v1.12.13+hotfix.9 on the emulator, I see: <img src="https://user-images.githubusercontent.com/1719665/87258816-26853e80-c46c-11ea-8a36-f422037cc6a9.png" width ="300"> - "dart:ui 73" and "dart:ui 74" are solid red - "dart:ui -73" and "dart:ui -74" are solid yellow - "dart:ui d74" and "Flutter d74" seem to have horizontal (maybe diagonal?) gradients running left to right. - "Flutter v74" is solid yellow For Flutter v1.17.5 on the emulator, I see different results (a little better, but still not correct): <img src="https://user-images.githubusercontent.com/1719665/87259149-c5129f00-c46e-11ea-95ae-0e17061cef60.png" width ="300"> - "dart:ui 73" is solid red - `*` "dart:ui 74" is solid yellow - the only difference between this and "dart:ui 73" is the fontSize. - `*` "dart:ui -73" and "dart:ui -74" work as expected. The only difference between these and the previous two are that the y offset is negative. - "dart:ui d74" and "Flutter d74" seem to have horizontal (maybe diagonal?) gradients running left to right. - `*` "Flutter v74" is solid red The items marked `*` above differ from the v1.12.13 results. Finally for the physical Pixel 3 XL scenario running the Flutter v1.17.5 version, appears to look like v1.12.13 results: <img src="https://user-images.githubusercontent.com/1719665/87259264-9ea13380-c46f-11ea-9ba5-1afc9bfd6d07.png" width ="300"> <details> <!-- Run `flutter analyze` and attach any output of that command below. If there are any analysis errors, try resolving them before filing this issue. --> ``` flutter analyze Analyzing gradient_bug_demo_1_12... No issues found! (ran in 5.0s) ``` <!-- Finally, paste the output of running `flutter doctor -v` here. --> Flutter doctor with Flutter v1.12.13: ``` βœ“] Flutter (Channel unknown, v1.12.13+hotfix.9, on Linux, locale en_US.UTF-8) β€’ Flutter version 1.12.13+hotfix.9 at /home/dsyrstad/Flutter/flutter β€’ Framework revision f139b11009 (3 months ago), 2020-03-30 13:57:30 -0700 β€’ Engine revision af51afceb8 β€’ Dart version 2.7.2 [βœ“] Android toolchain - develop for Android devices (Android SDK version 29.0.0) β€’ Android SDK at /home/dsyrstad/Android/Sdk β€’ Android NDK location not configured (optional; useful for native profiling support) β€’ Platform android-29, build-tools 29.0.0 β€’ ANDROID_SDK_ROOT = /home/dsyrstad/Android/Sdk β€’ Java binary at: /home/dsyrstad/AndroidStudio/android-studio/jre/bin/java β€’ Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405) β€’ All Android licenses accepted. [βœ“] Android Studio (version 3.5) β€’ Android Studio at /home/dsyrstad/AndroidStudio/android-studio β€’ Flutter plugin version 42.1.1 β€’ Dart plugin version 191.8593 β€’ Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405) [βœ“] IntelliJ IDEA Ultimate Edition (version 2019.3) β€’ IntelliJ at /home/dsyrstad/IntelliJ/idea-latest β€’ Flutter plugin version 45.1.2 β€’ Dart plugin version 193.6911.31 [βœ“] IntelliJ IDEA Ultimate Edition (version 2019.1) β€’ IntelliJ at /home/dsyrstad/IntelliJ/idea-IU-181.4668.68 β€’ Flutter plugin version 39.0.3 β€’ Dart plugin version 191.8423 [βœ“] Connected device (2 available) β€’ Pixel 3 XL β€’ 192.168.86.28:5555 β€’ android-arm64 β€’ Android 10 (API 29) β€’ AOSP on IA Emulator β€’ emulator-5554 β€’ android-x86 β€’ Android 9 (API 28) (emulator) β€’ No issues found! ``` Flutter doctor with Flutter v1.17.5: ``` [βœ“] Flutter (Channel stable, v1.17.5, on Linux, locale en_US.UTF-8) β€’ Flutter version 1.17.5 at /home/dsyrstad/Flutter/flutter β€’ Framework revision 8af6b2f038 (12 days ago), 2020-06-30 12:53:55 -0700 β€’ Engine revision ee76268252 β€’ Dart version 2.8.4 [βœ“] Android toolchain - develop for Android devices (Android SDK version 29.0.0) β€’ Android SDK at /home/dsyrstad/Android/Sdk β€’ Platform android-29, build-tools 29.0.0 β€’ ANDROID_SDK_ROOT = /home/dsyrstad/Android/Sdk β€’ Java binary at: /home/dsyrstad/AndroidStudio/android-studio/jre/bin/java β€’ Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405) β€’ All Android licenses accepted. [βœ“] Android Studio (version 3.5) β€’ Android Studio at /home/dsyrstad/AndroidStudio/android-studio β€’ Flutter plugin version 42.1.1 β€’ Dart plugin version 191.8593 β€’ Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405) [βœ“] IntelliJ IDEA Ultimate Edition (version 2019.3) β€’ IntelliJ at /home/dsyrstad/IntelliJ/idea-latest β€’ Flutter plugin version 45.1.2 β€’ Dart plugin version 193.6911.31 [βœ“] IntelliJ IDEA Ultimate Edition (version 2019.1) β€’ IntelliJ at /home/dsyrstad/IntelliJ/idea-IU-181.4668.68 β€’ Flutter plugin version 39.0.3 β€’ Dart plugin version 191.8423 [βœ“] Connected device (2 available) β€’ Pixel 3 XL β€’ 192.168.86.28:5555 β€’ android-arm64 β€’ Android 10 (API 29) β€’ AOSP on IA Emulator β€’ emulator-5554 β€’ android-x86 β€’ Android 9 (API 28) (emulator) β€’ No issues found! ``` </details>
engine,dependency: dart,a: typography,c: rendering,has reproducible steps,P2,found in release: 3.3,found in release: 3.7,team-engine,triaged-engine
low
Critical
655,564,341
godot
Resource with sub-resources which is saved to disk by code has it's values reset by changes made in the editor when the project starts
I know the title is a bit of a mess... I don't know how to better explain it. **Godot version:** 3.2.2 stable **OS/device including version:** Win 10 **Issue description / Steps to reproduce:** 1. Create a script which makes and saves a resource with a sub-resource on startup. Like so: ``` extends Node2D var icon = preload("res://icon.png") func _ready() -> void: # Don't run the code straight away yield(get_tree().create_timer(2), "timeout") # Animated texture - the resource we will eventually save var at = AnimatedTexture.new() # Create an image texture so it's data is stored within the resource var imgtex = ImageTexture.new() imgtex.create_from_image(icon.get_data(), 5) # Set the texture at.set_frame_texture(0,imgtex) # Save the resource var path = "res://animtex.tres" var err = ResourceSaver.save(path, at, 6) print(err) print("Done!") ``` 2. Run the project. 3. Open the created resource (animtex.tres) in a text editor like VS Code. 4. Note that for the subresource ImageTexture, flags = 5 5. Now, go into the editor, open the animated texture and make the flags on the texture of frame 0 "Mipmaps" only (i.e. value of 1) 6. Save the resource, and note that in VS Code the value has updated to flags = 1 7. Run the game again. 8. Check VS Code, Values are back to flags = 5 9. Close the game 10. Open the game again 11. **When you open the game, for the first 2 seconds the values go back to flags = 1**, until the code which re-saves the resource is run again. 12. It seems like restarting the engine makes it go away... but in some cases it doesn't (unable to reproduce). If the file is being overwritten, why is it being re-saved when starting the game? Does the editor cache resources and then re-save them on startup or something? **Minimal reproduction project:** [ResourceSavingBug.zip](https://github.com/godotengine/godot/files/4910538/ResourceSavingBug.zip)
bug,topic:editor
low
Critical
655,604,041
godot
Mono editor crashes if profiling is enabled
Im using the Mono 3.2.2 stable version (Downloaded from official site) on Ubuntu 20.04. (In the past using older versions of ubuntu or linux mint or debian or arch it also had this issue with identical errors.) If I ever have any source tied to the project file, the next boot up always has a crash. I can reproduce by starting up a new project, adding some source to it, then saving and closing godot then re-opening the project. It pops up for like a second then always crashes. From a new project here are some of the infos I get. (In console when opening the project): ``` * Assertion at log.c:1567, condition `!thread__->busy && "Why are we trying to write a new event while already writing one?"' not met ================================================================= Native Crash Reporting ================================================================= Got a SIGABRT while executing native code. This usually indicates a fatal error in the mono runtime or one of the native libraries used by your application. ================================================================= ================================================================= Native stacktrace: ================================================================= 0xd20004 - /opt/godot-3.2/Godot_v3.2.2-mono.64 : (null) 0xd2037c - /opt/godot-3.2/Godot_v3.2.2-mono.64 : (null) 0xd12e28 - /opt/godot-3.2/Godot_v3.2.2-mono.64 : (null) 0xd1f65f - /opt/godot-3.2/Godot_v3.2.2-mono.64 : (null) 0x7fce5b8813c0 - /lib/x86_64-linux-gnu/libpthread.so.0 : (null) 0x7fce5b56018b - /lib/x86_64-linux-gnu/libc.so.6 : gsignal 0x7fce5b53f859 - /lib/x86_64-linux-gnu/libc.so.6 : abort 0x7fce51f897a5 - /opt/godot-3.2/GodotSharp/Mono/lib/libmono-profiler-log.so : (null) 0x7fce51f9803e - /opt/godot-3.2/GodotSharp/Mono/lib/libmono-profiler-log.so : (null) 0x7fce51f98540 - /opt/godot-3.2/GodotSharp/Mono/lib/libmono-profiler-log.so : monoeg_assertion_message 0x7fce51f8c781 - /opt/godot-3.2/GodotSharp/Mono/lib/libmono-profiler-log.so : (null) 0xe6a835 - /opt/godot-3.2/Godot_v3.2.2-mono.64 : (null) 0xe8091f - /opt/godot-3.2/Godot_v3.2.2-mono.64 : (null) 0xe5bec8 - /opt/godot-3.2/Godot_v3.2.2-mono.64 : (null) 0xea5c62 - /opt/godot-3.2/Godot_v3.2.2-mono.64 : (null) 0xeac987 - /opt/godot-3.2/Godot_v3.2.2-mono.64 : mono_thread_attach 0x306844e - /opt/godot-3.2/Godot_v3.2.2-mono.64 : _ZN11GDMonoUtils21attach_current_threadEv 0x30684e5 - /opt/godot-3.2/Godot_v3.2.2-mono.64 : _ZN11GDMonoUtils17ScopeThreadAttachC1Ev 0x2ebc905 - /opt/godot-3.2/Godot_v3.2.2-mono.64 : _ZN12CSharpScript6reloadEb 0x2e6b404 - /opt/godot-3.2/Godot_v3.2.2-mono.64 : _ZN32ResourceFormatLoaderCSharpScript4loadERK6StringS2_P5Error 0x1174cab - /opt/godot-3.2/Godot_v3.2.2-mono.64 : _ZN14ResourceLoader5_loadERK6StringS2_S2_bP5Error 0x117531d - /opt/godot-3.2/Godot_v3.2.2-mono.64 : _ZN14ResourceLoader4loadERK6StringS2_bP5Error 0x271623e - /opt/godot-3.2/Godot_v3.2.2-mono.64 : _ZNK30EditorResourcePreviewGenerator18generate_from_pathERK6StringRK7Vector2 0x2661588 - /opt/godot-3.2/Godot_v3.2.2-mono.64 : _ZN21EditorResourcePreview17_generate_previewER3RefI12ImageTextureES3_RKNS_9QueueItemERK6String 0x2705c68 - /opt/godot-3.2/Godot_v3.2.2-mono.64 : _ZN21EditorResourcePreview7_threadEv 0x2a86da5 - /opt/godot-3.2/Godot_v3.2.2-mono.64 : _ZN11ThreadPosix15thread_callbackEPv 0x7fce5b875609 - /lib/x86_64-linux-gnu/libpthread.so.0 : (null) 0x7fce5b63c103 - /lib/x86_64-linux-gnu/libc.so.6 : clone ================================================================= Telemetry Dumper: ================================================================= Pkilling 0x7fce3593e700 from 0x7fce3521d700 Pkilling 0x7fce51e5f700 from 0x7fce3521d700 Pkilling 0x7fce50392700 from 0x7fce3521d700 Pkilling 0x7fce367fc700 from 0x7fce3521d700 Pkilling 0x7fce36ffd700 from 0x7fce3521d700 Pkilling 0x7fce377fe700 from 0x7fce3521d700 * Assertion: should not be reached at threads.c:6258 * Assertion at log.c:1567, condition `!thread__->busy && "Why are we trying to write a new event while already writing one?"' not met (In the crash log file): Config attempting to parse: '/opt/godot-3.2/GodotSharp/Mono/etc/mono/config'. (in domain Mono, info) Config attempting to parse: '/home/spiceywolf/.mono/config'. (in domain Mono, info) Image addref mscorlib[0x67aa8f0] (asmctx DEFAULT) -> /opt/godot-3.2/GodotSharp/Mono/lib/mono/4.5/mscorlib.dll[0x67a94b0]: 2 (in domain Mono, info) Prepared to set up assembly 'mscorlib' (/opt/godot-3.2/GodotSharp/Mono/lib/mono/4.5/mscorlib.dll) (in domain Mono, info) AOT: image '/opt/godot-3.2/GodotSharp/Mono/lib/mono/4.5/mscorlib.dll.so' not found: /opt/godot-3.2/GodotSharp/Mono/lib/mono/4.5/mscorlib.dll.so: cannot open shared object file: No such file or directory (in domain Mono, info) AOT: image '/opt/godot-3.2/GodotSharp/Mono/lib/mono/aot-cache/amd64/mscorlib.dll.so' not found: /opt/godot-3.2/GodotSharp/Mono/lib/mono/aot-cache/amd64/mscorlib.dll.so: cannot open shared object file: No such file or directory (in domain Mono, info) Assembly mscorlib[0x67aa8f0] added to domain GodotEngine.RootDomain, ref_count=1 (in domain Mono, info) Assembly mscorlib[0x67aa8f0] added to domain GodotEngine.Domain.Scripts, ref_count=2 (in domain Mono, info) Image addref GodotSharp[0x6f038d0] (asmctx DEFAULT) -> /home/spiceywolf/Projects/Godot/Projects/Engines/Lunar/Source/Client/.mono/assemblies/Debug/GodotSharp.dll[0x68bd940]: 2 (in domain Mono, info) Prepared to set up assembly 'GodotSharp' (/home/spiceywolf/Projects/Godot/Projects/Engines/Lunar/Source/Client/.mono/assemblies/Debug/GodotSharp.dll) (in domain Mono, info) Assembly GodotSharp[0x6f038d0] added to domain GodotEngine.Domain.Scripts, ref_count=1 (in domain Mono, info) Loading reference 0 of /home/spiceywolf/Projects/Godot/Projects/Engines/Lunar/Source/Client/.mono/assemblies/Debug/GodotSharp.dll asmctx DEFAULT, looking for mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089 (in domain Mono, info) Config attempting to parse: ''. (in domain Mono, info) Assembly Ref addref GodotSharp[0x6f038d0] -> mscorlib[0x67aa8f0]: 3 (in domain Mono, info) Image addref GodotSharpEditor[0x68c5110] (asmctx DEFAULT) -> /home/spiceywolf/Projects/Godot/Projects/Engines/Lunar/Source/Client/.mono/assemblies/Debug/GodotSharpEditor.dll[0x68cad60]: 2 (in domain Mono, info) Prepared to set up assembly 'GodotSharpEditor' (/home/spiceywolf/Projects/Godot/Projects/Engines/Lunar/Source/Client/.mono/assemblies/Debug/GodotSharpEditor.dll) (in domain Mono, info) Assembly GodotSharpEditor[0x68c5110] added to domain GodotEngine.Domain.Scripts, ref_count=1 (in domain Mono, info) Loading reference 0 of /home/spiceywolf/Projects/Godot/Projects/Engines/Lunar/Source/Client/.mono/assemblies/Debug/GodotSharpEditor.dll asmctx DEFAULT, looking for mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089 (in domain Mono, info) Assembly Ref addref GodotSharpEditor[0x68c5110] -> mscorlib[0x67aa8f0]: 4 (in domain Mono, info) Loading reference 2 of /home/spiceywolf/Projects/Godot/Projects/Engines/Lunar/Source/Client/.mono/assemblies/Debug/GodotSharp.dll asmctx DEFAULT, looking for System, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089 (in domain Mono, info) Image addref System[0x68e2f50] (asmctx DEFAULT) -> /opt/godot-3.2/GodotSharp/Mono/lib/mono/4.5/System.dll[0x68da100]: 2 (in domain Mono, info) Prepared to set up assembly 'System' (/opt/godot-3.2/GodotSharp/Mono/lib/mono/4.5/System.dll) (in domain Mono, info) Assembly System[0x68e2f50] added to domain GodotEngine.Domain.Scripts, ref_count=1 (in domain Mono, info) Assembly Ref addref GodotSharp[0x6f038d0] -> System[0x68e2f50]: 2 (in domain Mono, info) Loading reference 0 of /opt/godot-3.2/GodotSharp/Mono/lib/mono/4.5/System.dll asmctx DEFAULT, looking for mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089 (in domain Mono, info) Assembly Ref addref System[0x68e2f50] -> mscorlib[0x67aa8f0]: 5 (in domain Mono, info) Loading reference 2 of /opt/godot-3.2/GodotSharp/Mono/lib/mono/4.5/System.dll asmctx DEFAULT, looking for System.Configuration, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a (in domain Mono, info) Image addref System.Configuration[0x6bf2c80] (asmctx DEFAULT) -> /opt/godot-3.2/GodotSharp/Mono/lib/mono/4.5/System.Configuration.dll[0x6bfd540]: 2 (in domain Mono, info) Prepared to set up assembly 'System.Configuration' (/opt/godot-3.2/GodotSharp/Mono/lib/mono/4.5/System.Configuration.dll) (in domain Mono, info) Assembly System.Configuration[0x6bf2c80] added to domain GodotEngine.Domain.Scripts, ref_count=1 (in domain Mono, info) Assembly Ref addref System[0x68e2f50] -> System.Configuration[0x6bf2c80]: 2 (in domain Mono, info) Loading reference 0 of /opt/godot-3.2/GodotSharp/Mono/lib/mono/4.5/System.Configuration.dll asmctx DEFAULT, looking for mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089 (in domain Mono, info) Assembly Ref addref System.Configuration[0x6bf2c80] -> mscorlib[0x67aa8f0]: 6 (in domain Mono, info) Loading reference 2 of /opt/godot-3.2/GodotSharp/Mono/lib/mono/4.5/System.Configuration.dll asmctx DEFAULT, looking for System, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089 (in domain Mono, info) Assembly Ref addref System.Configuration[0x6bf2c80] -> System[0x68e2f50]: 3 (in domain Mono, info) Loading reference 1 of /opt/godot-3.2/GodotSharp/Mono/lib/mono/4.5/System.Configuration.dll asmctx DEFAULT, looking for System.Xml, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089 (in domain Mono, info) Image addref System.Xml[0x6c07520] (asmctx DEFAULT) -> /opt/godot-3.2/GodotSharp/Mono/lib/mono/4.5/System.Xml.dll[0x6c066f0]: 2 (in domain Mono, info) Prepared to set up assembly 'System.Xml' (/opt/godot-3.2/GodotSharp/Mono/lib/mono/4.5/System.Xml.dll) (in domain Mono, info) Assembly System.Xml[0x6c07520] added to domain GodotEngine.Domain.Scripts, ref_count=1 (in domain Mono, info) Assembly Ref addref System.Configuration[0x6bf2c80] -> System.Xml[0x6c07520]: 2 (in domain Mono, info) Loading reference 0 of /opt/godot-3.2/GodotSharp/Mono/lib/mono/4.5/System.Xml.dll asmctx DEFAULT, looking for mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089 (in domain Mono, info) Assembly Ref addref System.Xml[0x6c07520] -> mscorlib[0x67aa8f0]: 7 (in domain Mono, info) DllImport attempting to load: '/opt/godot-3.2/GodotSharp/Mono/lib/../lib/libmono-native.so'. (in domain Mono, info) DllImport loaded library '/opt/godot-3.2/GodotSharp/Mono/lib/../lib/libmono-native.so'. (in domain Mono, info) DllImport searching in: '/opt/godot-3.2/GodotSharp/Mono/lib/../lib/libmono-native.so' ('/opt/godot-3.2/GodotSharp/Mono/lib/../lib/libmono-native.so'). (in domain Mono, info) Searching for 'SystemNative_GetNonCryptographicallySecureRandomBytes'. (in domain Mono, info) Probing 'SystemNative_GetNonCryptographicallySecureRandomBytes'. (in domain Mono, info) Found as 'SystemNative_GetNonCryptographicallySecureRandomBytes'. (in domain Mono, info) DllImport searching in: '/opt/godot-3.2/GodotSharp/Mono/lib/../lib/libmono-native.so' ('/opt/godot-3.2/GodotSharp/Mono/lib/../lib/libmono-native.so'). (in domain Mono, info) Searching for 'SystemNative_Stat2'. (in domain Mono, info) Probing 'SystemNative_Stat2'. (in domain Mono, info) Found as 'SystemNative_Stat2'. (in domain Mono, info) DllImport searching in: '/opt/godot-3.2/GodotSharp/Mono/lib/../lib/libmono-native.so' ('/opt/godot-3.2/GodotSharp/Mono/lib/../lib/libmono-native.so'). (in domain Mono, info) Searching for 'SystemNative_LStat2'. (in domain Mono, info) Probing 'SystemNative_LStat2'. (in domain Mono, info) Found as 'SystemNative_LStat2'. (in domain Mono, info) DllImport searching in: '/opt/godot-3.2/GodotSharp/Mono/lib/../lib/libmono-native.so' ('/opt/godot-3.2/GodotSharp/Mono/lib/../lib/libmono-native.so'). (in domain Mono, info) Searching for 'SystemNative_ConvertErrorPlatformToPal'. (in domain Mono, info) Probing 'SystemNative_ConvertErrorPlatformToPal'. (in domain Mono, info) Found as 'SystemNative_ConvertErrorPlatformToPal'. (in domain Mono, info) Loading reference 2 of /opt/godot-3.2/GodotSharp/Mono/lib/mono/4.5/System.Xml.dll asmctx DEFAULT, looking for System, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089 (in domain Mono, info) Assembly Ref addref System.Xml[0x6c07520] -> System[0x68e2f50]: 4 (in domain Mono, info) Loading reference 3 of /opt/godot-3.2/GodotSharp/Mono/lib/mono/4.5/System.dll asmctx DEFAULT, looking for System.Xml, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089 (in domain Mono, info) Assembly Ref addref System[0x68e2f50] -> System.Xml[0x6c07520]: 3 (in domain Mono, info) Image addref GodotTools[0x7054170] (asmctx DEFAULT) -> /opt/godot-3.2/GodotSharp/Tools/GodotTools.dll[0x70811e0]: 2 (in domain Mono, info) Prepared to set up assembly 'GodotTools' (/opt/godot-3.2/GodotSharp/Tools/GodotTools.dll) (in domain Mono, info) Assembly GodotTools[0x7054170] added to domain GodotEngine.Domain.Scripts, ref_count=1 (in domain Mono, info) Image addref GodotTools.ProjectEditor[0x603a220] (asmctx DEFAULT) -> /opt/godot-3.2/GodotSharp/Tools/GodotTools.ProjectEditor.dll[0x7081910]: 2 (in domain Mono, info) Prepared to set up assembly 'GodotTools.ProjectEditor' (/opt/godot-3.2/GodotSharp/Tools/GodotTools.ProjectEditor.dll) (in domain Mono, info) Assembly GodotTools.ProjectEditor[0x603a220] added to domain GodotEngine.Domain.Scripts, ref_count=1 (in domain Mono, info) Assembly Loader probing location: '/opt/godot-3.2/GodotSharp/Mono/lib/Client.dll'. (in domain Mono, info) Assembly Loader probing location: '/opt/godot-3.2/GodotSharp/Mono/lib/mono/4.5//Facades/Client.dll'. (in domain Mono, info) Assembly Loader probing location: '/opt/godot-3.2/GodotSharp/Mono/lib/Client.exe'. (in domain Mono, info) Assembly Loader probing location: '/opt/godot-3.2/GodotSharp/Mono/lib/mono/4.5//Facades/Client.exe'. (in domain Mono, info) Loading reference 2 of /opt/godot-3.2/GodotSharp/Tools/GodotTools.dll asmctx DEFAULT, looking for GodotSharpEditor, Version=1.0.7482.11424, Culture=neutral, PublicKeyToken=null (in domain Mono, info) Assembly Ref addref GodotTools[0x7054170] -> GodotSharpEditor[0x68c5110]: 2 (in domain Mono, info) Loading reference 1 of /home/spiceywolf/Projects/Godot/Projects/Engines/Lunar/Source/Client/.mono/assemblies/Debug/GodotSharpEditor.dll asmctx DEFAULT, looking for GodotSharp, Version=1.0.7482.11423, Culture=neutral, PublicKeyToken=null (in domain Mono, info) Assembly Ref addref GodotSharpEditor[0x68c5110] -> GodotSharp[0x6f038d0]: 2 (in domain Mono, info) Loading reference 1 of /opt/godot-3.2/GodotSharp/Tools/GodotTools.dll asmctx DEFAULT, looking for GodotSharp, Version=1.0.7482.11423, Culture=neutral, PublicKeyToken=null (in domain Mono, info) Assembly Ref addref GodotTools[0x7054170] -> GodotSharp[0x6f038d0]: 3 (in domain Mono, info) Loading reference 0 of /opt/godot-3.2/GodotSharp/Tools/GodotTools.dll asmctx DEFAULT, looking for mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089 (in domain Mono, info) Assembly Ref addref GodotTools[0x7054170] -> mscorlib[0x67aa8f0]: 8 (in domain Mono, info) Loading reference 3 of /opt/godot-3.2/GodotSharp/Tools/GodotTools.dll asmctx DEFAULT, looking for GodotTools.ProjectEditor, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null (in domain Mono, info) Assembly Ref addref GodotTools[0x7054170] -> GodotTools.ProjectEditor[0x603a220]: 2 (in domain Mono, info) Loading reference 0 of /opt/godot-3.2/GodotSharp/Tools/GodotTools.ProjectEditor.dll asmctx DEFAULT, looking for mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089 (in domain Mono, info) Assembly Ref addref GodotTools.ProjectEditor[0x603a220] -> mscorlib[0x67aa8f0]: 9 (in domain Mono, info) Loading reference 3 of /opt/godot-3.2/GodotSharp/Tools/GodotTools.ProjectEditor.dll asmctx DEFAULT, looking for Microsoft.Build, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a (in domain Mono, info) Image addref Microsoft.Build[0xf925340] (asmctx DEFAULT) -> /opt/godot-3.2/GodotSharp/Mono/lib/mono/4.5/Microsoft.Build.dll[0xf85fa80]: 2 (in domain Mono, info) Prepared to set up assembly 'Microsoft.Build' (/opt/godot-3.2/GodotSharp/Mono/lib/mono/4.5/Microsoft.Build.dll) (in domain Mono, info) Assembly Microsoft.Build[0xf925340] added to domain GodotEngine.Domain.Scripts, ref_count=1 (in domain Mono, info) Assembly Ref addref GodotTools.ProjectEditor[0x603a220] -> Microsoft.Build[0xf925340]: 2 (in domain Mono, info) Loading reference 0 of /opt/godot-3.2/GodotSharp/Mono/lib/mono/4.5/Microsoft.Build.dll asmctx DEFAULT, looking for mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089 (in domain Mono, info) Assembly Ref addref Microsoft.Build[0xf925340] -> mscorlib[0x67aa8f0]: 10 (in domain Mono, info) Loading reference 7 of /opt/godot-3.2/GodotSharp/Tools/GodotTools.dll asmctx DEFAULT, looking for GodotTools.Core, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null (in domain Mono, info) Image addref GodotTools.Core[0xf863680] (asmctx DEFAULT) -> /opt/godot-3.2/GodotSharp/Tools/GodotTools.Core.dll[0xf863ba0]: 2 (in domain Mono, info) Prepared to set up assembly 'GodotTools.Core' (/opt/godot-3.2/GodotSharp/Tools/GodotTools.Core.dll) (in domain Mono, info) Assembly GodotTools.Core[0xf863680] added to domain GodotEngine.Domain.Scripts, ref_count=1 (in domain Mono, info) Assembly Ref addref GodotTools[0x7054170] -> GodotTools.Core[0xf863680]: 2 (in domain Mono, info) Loading reference 0 of /opt/godot-3.2/GodotSharp/Tools/GodotTools.Core.dll asmctx DEFAULT, looking for mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089 (in domain Mono, info) Assembly Ref addref GodotTools.Core[0xf863680] -> mscorlib[0x67aa8f0]: 11 (in domain Mono, info) Loading reference 1 of /opt/godot-3.2/GodotSharp/Tools/GodotTools.ProjectEditor.dll asmctx DEFAULT, looking for System, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089 (in domain Mono, info) Assembly Ref addref GodotTools.ProjectEditor[0x603a220] -> System[0x68e2f50]: 5 (in domain Mono, info) Loading reference 2 of /opt/godot-3.2/GodotSharp/Tools/GodotTools.ProjectEditor.dll asmctx DEFAULT, looking for System.Core, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089 (in domain Mono, info) Image addref System.Core[0xf8d5e90] (asmctx DEFAULT) -> /opt/godot-3.2/GodotSharp/Mono/lib/mono/4.5/System.Core.dll[0xf8d50c0]: 2 (in domain Mono, info) Prepared to set up assembly 'System.Core' (/opt/godot-3.2/GodotSharp/Mono/lib/mono/4.5/System.Core.dll) (in domain Mono, info) Assembly System.Core[0xf8d5e90] added to domain GodotEngine.Domain.Scripts, ref_count=1 (in domain Mono, info) Assembly Ref addref GodotTools.ProjectEditor[0x603a220] -> System.Core[0xf8d5e90]: 2 (in domain Mono, info) Loading reference 0 of /opt/godot-3.2/GodotSharp/Mono/lib/mono/4.5/System.Core.dll asmctx DEFAULT, looking for mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089 (in domain Mono, info) Assembly Ref addref System.Core[0xf8d5e90] -> mscorlib[0x67aa8f0]: 12 (in domain Mono, info) Loading reference 5 of /opt/godot-3.2/GodotSharp/Tools/GodotTools.ProjectEditor.dll asmctx DEFAULT, looking for GodotTools.Core, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null (in domain Mono, info) Assembly Ref addref GodotTools.ProjectEditor[0x603a220] -> GodotTools.Core[0xf863680]: 3 (in domain Mono, info) Loading reference 3 of /opt/godot-3.2/GodotSharp/Mono/lib/mono/4.5/Microsoft.Build.dll asmctx DEFAULT, looking for System, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089 (in domain Mono, info) Assembly Ref addref Microsoft.Build[0xf925340] -> System[0x68e2f50]: 6 (in domain Mono, info) Loading reference 2 of /opt/godot-3.2/GodotSharp/Mono/lib/mono/4.5/Microsoft.Build.dll asmctx DEFAULT, looking for System.Xml, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089 (in domain Mono, info) Assembly Ref addref Microsoft.Build[0xf925340] -> System.Xml[0x6c07520]: 4 (in domain Mono, info) Loading reference 1 of /opt/godot-3.2/GodotSharp/Mono/lib/mono/4.5/Microsoft.Build.dll asmctx DEFAULT, looking for Microsoft.Build.Framework, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a (in domain Mono, info) Image addref Microsoft.Build.Framework[0xf97d980] (asmctx DEFAULT) -> /opt/godot-3.2/GodotSharp/Mono/lib/mono/4.5/Microsoft.Build.Framework.dll[0xf97cb70]: 2 (in domain Mono, info) Prepared to set up assembly 'Microsoft.Build.Framework' (/opt/godot-3.2/GodotSharp/Mono/lib/mono/4.5/Microsoft.Build.Framework.dll) (in domain Mono, info) Assembly Microsoft.Build.Framework[0xf97d980] added to domain GodotEngine.Domain.Scripts, ref_count=1 (in domain Mono, info) Assembly Ref addref Microsoft.Build[0xf925340] -> Microsoft.Build.Framework[0xf97d980]: 2 (in domain Mono, info) Loading reference 4 of /opt/godot-3.2/GodotSharp/Mono/lib/mono/4.5/Microsoft.Build.dll asmctx DEFAULT, looking for System.Core, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089 (in domain Mono, info) Assembly Ref addref Microsoft.Build[0xf925340] -> System.Core[0xf8d5e90]: 3 (in domain Mono, info) Loading reference 8 of /opt/godot-3.2/GodotSharp/Tools/GodotTools.dll asmctx DEFAULT, looking for System.Core, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089 (in domain Mono, info) Assembly Ref addref GodotTools[0x7054170] -> System.Core[0xf8d5e90]: 4 (in domain Mono, info) Loading reference 5 of /opt/godot-3.2/GodotSharp/Tools/GodotTools.dll asmctx DEFAULT, looking for GodotTools.IdeMessaging, Version=1.1.0.0, Culture=neutral, PublicKeyToken=null (in domain Mono, info) Image addref GodotTools.IdeMessaging[0x6fc14d0] (asmctx DEFAULT) -> /opt/godot-3.2/GodotSharp/Tools/GodotTools.IdeMessaging.dll[0x6fc0380]: 2 (in domain Mono, info) Prepared to set up assembly 'GodotTools.IdeMessaging' (/opt/godot-3.2/GodotSharp/Tools/GodotTools.IdeMessaging.dll) (in domain Mono, info) Assembly GodotTools.IdeMessaging[0x6fc14d0] added to domain GodotEngine.Domain.Scripts, ref_count=1 (in domain Mono, info) Assembly Ref addref GodotTools[0x7054170] -> GodotTools.IdeMessaging[0x6fc14d0]: 2 (in domain Mono, info) Loading reference 4 of /opt/godot-3.2/GodotSharp/Tools/GodotTools.dll asmctx DEFAULT, looking for System, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089 (in domain Mono, info) Assembly Ref addref GodotTools[0x7054170] -> System[0x68e2f50]: 7 (in domain Mono, info) Loading reference 0 of /opt/godot-3.2/GodotSharp/Tools/GodotTools.IdeMessaging.dll asmctx DEFAULT, looking for netstandard, Version=2.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51 (in domain Mono, info) Image addref netstandard[0xfa22f90] (asmctx DEFAULT) -> /opt/godot-3.2/GodotSharp/Mono/lib/mono/4.5/Facades/netstandard.dll[0xfa21d20]: 2 (in domain Mono, info) Prepared to set up assembly 'netstandard' (/opt/godot-3.2/GodotSharp/Mono/lib/mono/4.5/Facades/netstandard.dll) (in domain Mono, info) Assembly netstandard[0xfa22f90] added to domain GodotEngine.Domain.Scripts, ref_count=1 (in domain Mono, info) Assembly Ref addref GodotTools.IdeMessaging[0x6fc14d0] -> netstandard[0xfa22f90]: 2 (in domain Mono, info) Loading reference 0 of /opt/godot-3.2/GodotSharp/Mono/lib/mono/4.5/Facades/netstandard.dll asmctx DEFAULT, looking for mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089 (in domain Mono, info) Assembly Ref addref netstandard[0xfa22f90] -> mscorlib[0x67aa8f0]: 13 (in domain Mono, info) Loading reference 2 of /opt/godot-3.2/GodotSharp/Mono/lib/mono/4.5/Facades/netstandard.dll asmctx DEFAULT, looking for System, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089 (in domain Mono, info) Assembly Ref addref netstandard[0xfa22f90] -> System[0x68e2f50]: 8 (in domain Mono, info) DllImport searching in: '/opt/godot-3.2/GodotSharp/Mono/lib/../lib/libmono-native.so' ('/opt/godot-3.2/GodotSharp/Mono/lib/../lib/libmono-native.so'). (in domain Mono, info) Searching for 'SystemNative_MkDir'. (in domain Mono, info) Probing 'SystemNative_MkDir'. (in domain Mono, info) Found as 'SystemNative_MkDir'. (in domain Mono, info) DllImport attempting to load: 'libc.so.6'. (in domain Mono, info) DllImport error loading library '/opt/godot-3.2/GodotSharp/Mono/lib/mono/4.5/libc.so.6': '/opt/godot-3.2/GodotSharp/Mono/lib/mono/4.5/libc.so.6: cannot open shared object file: No such file or directory'. (in domain Mono, info) DllImport error loading library '/opt/godot-3.2/GodotSharp/Mono/lib/mono/4.5/libc.so.6.so': '/opt/godot-3.2/GodotSharp/Mono/lib/mono/4.5/libc.so.6.so: cannot open shared object file: No such file or directory'. (in domain Mono, info) DllImport error loading library '/opt/godot-3.2/GodotSharp/Mono/lib/mono/4.5/libc.so.6.so': '/opt/godot-3.2/GodotSharp/Mono/lib/mono/4.5/libc.so.6.so: cannot open shared object file: No such file or directory'. (in domain Mono, info) DllImport error loading library '/opt/lib/libc.so.6': '/opt/lib/libc.so.6: cannot open shared object file: No such file or directory'. (in domain Mono, info) DllImport error loading library '/opt/lib/libc.so.6.so': '/opt/lib/libc.so.6.so: cannot open shared object file: No such file or directory'. (in domain Mono, info) DllImport error loading library '/opt/lib/libc.so.6.so': '/opt/lib/libc.so.6.so: cannot open shared object file: No such file or directory'. (in domain Mono, info) DllImport loaded library 'libc.so.6'. (in domain Mono, info) DllImport searching in: 'libc.so.6' ('libc.so.6'). (in domain Mono, info) Searching for 'uname'. (in domain Mono, info) Probing 'uname'. (in domain Mono, info) Found as 'uname'. (in domain Mono, info) DllImport searching in: 'libc.so.6' ('libc.so.6'). (in domain Mono, info) Searching for 'getifaddrs'. (in domain Mono, info) Probing 'getifaddrs'. (in domain Mono, info) Found as 'getifaddrs'. (in domain Mono, info) DllImport searching in: 'libc.so.6' ('libc.so.6'). (in domain Mono, info) Searching for 'freeifaddrs'. (in domain Mono, info) Probing 'freeifaddrs'. (in domain Mono, info) Found as 'freeifaddrs'. (in domain Mono, info) Loading reference 1 of /home/spiceywolf/Projects/Godot/Projects/Engines/Lunar/Source/Client/.mono/assemblies/Debug/GodotSharp.dll asmctx DEFAULT, looking for System.Core, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089 (in domain Mono, info) ``` To the best of my understanding, it would seem the target problem would probably be related to the thing trying to load the mono files as .dll.so instead of just .dll which .dll.so files dont exist in that folder -- if that may be any hint to the issue.
bug,topic:editor,confirmed,topic:dotnet,crash
low
Critical
655,610,316
pytorch
torch.nn.parallel.scatter_gather.gather can't gather outputs that are dataclasses
## πŸ› Bug `torch.nn.parallel.scatter_gather.gather` can't gather outputs that are `dataclasses` ## To Reproduce Steps to reproduce the behavior: ``` from dataclasses import dataclass # base model outputs class in transformers class ModelOutput: def to_tuple(self): return tuple(getattr(self, f) for f in self.__dataclass_fields__.keys() if getattr(self, f, None) is not None) def to_dict(self): return {f: getattr(self, f) for f in self.__dataclass_fields__.keys() if getattr(self, f, None) is not None} def __getitem__(self, i): return self.to_dict()[i] if isinstance(i, str) else self.to_tuple()[i] def __len__(self): return len(self.to_tuple()) @dataclass class X1(ModelOutput): foo: torch.FloatTensor bar: torch.FloatTensor x1 = X1(torch.tensor(1., device="cuda:0"), torch.tensor(2., device="cuda:0")) x2 = X1(torch.tensor(3., device="cuda:1"), torch.tensor(4., device="cuda:1")) outputs = [x1, x2] from torch.nn.parallel.scatter_gather import gather gather(outputs, 0) ``` Error: ``` TypeError: __init__() missing 1 required positional argument: 'bar' ``` as it fails to detect dataclass as dict, it skips over it and calls the class with wrong arguments, sending just the first argument. <!-- If you have a code sample, error messages, stack traces, please provide it here as well --> ## Expected behavior Should handle `dataclass` `outputs` as `dict` transparently The following implementation fixes this simple example (but see later that it doesn't always work). Not sure whether pytorch's requirements include `dataclasses`: ``` import dataclasses def gather(outputs, target_device, dim=0): r""" Gathers tensors from different GPUs on a specified device (-1 means the CPU). """ def gather_map(outputs): out = outputs[0] if dataclasses.is_dataclass(out): outputs = [dataclasses.asdict(out) for out in outputs] out = outputs[0] if isinstance(out, torch.Tensor): return Gather.apply(target_device, dim, *outputs) if out is None: return None if isinstance(out, dict): if not all((len(out) == len(d) for d in outputs)): raise ValueError('All dicts must have the same number of keys') return type(out)(((k, gather_map([d[k] for d in outputs])) for k in out)) return type(out)(map(gather_map, zip(*outputs))) # Recursive function calls like this create reference cycles. # Setting the function to None clears the refcycle. try: res = gather_map(outputs) finally: gather_map = None return res ``` The lack of dataclasses outputs support was detected in transformers: https://github.com/huggingface/transformers/issues/5693#issuecomment-657325298 I saw that named tuples also have this issue: https://github.com/pytorch/vision/issues/1048 ## Environment ``` Collecting environment information... PyTorch version: 1.5.1 Is debug build: No CUDA used to build PyTorch: 10.2 OS: Ubuntu 18.04.4 LTS GCC version: (Ubuntu 7.5.0-3ubuntu1~18.04) 7.5.0 CMake version: version 3.10.2 Python version: 3.7 Is CUDA available: Yes CUDA runtime version: 10.0.130 GPU models and configuration: GPU 0: GeForce GTX TITAN X GPU 1: GeForce GTX TITAN X Nvidia driver version: 440.95.01 cuDNN version: /usr/lib/x86_64-linux-gnu/libcudnn.so.7.6.5 Versions of relevant libraries: [pip3] numpy==1.13.3 [conda] blas 1.0 mkl [conda] cudatoolkit 10.2.89 hfd86e86_1 [conda] mkl 2020.0 166 [conda] mkl-service 2.3.0 py37he904b0f_0 [conda] mkl_fft 1.0.15 py37ha843d7b_0 [conda] mkl_random 1.1.0 py37hd6b4f25_0 [conda] numpy 1.18.1 pypi_0 pypi [conda] numpy-base 1.18.1 py37hde5b4d6_1 [conda] numpydoc 0.9.2 py_0 [conda] pytorch 1.5.1 py3.7_cuda10.2.89_cudnn7.6.5_0 pytorch [conda] pytorch-lightning 0.7.6 pypi_0 pypi [conda] pytorch-nlp 0.5.0 pypi_0 pypi [conda] pytorch-pretrained-bert 0.6.2 pypi_0 pypi [conda] pytorch-transformers 1.1.0 pypi_0 pypi [conda] torch 1.5.0 pypi_0 pypi [conda] torchtext 0.5.1 pypi_0 pypi [conda] torchvision 0.6.1 py37_cu102 pytorch ``` cc @pietern @mrshenli @pritamdamania87 @zhaojuanmao @satgera @rohan-varma @gqchen @aazzolini @xush6528 @osalpekar @jiayisuse @agolynski
oncall: distributed,triaged,module: data parallel
low
Critical
655,610,686
pytorch
Reference the randomness issue in DataLoader & Dataset documentation.
Old title: Random seed of numpy is reset to the same value inside DataLoader workers ## πŸ› Bug <!-- A clear and concise description of what the bug is. --> I’m using an IterableDataset inside a DataLoader (with multiple workers). My IterableDataset code calls numpy.random functions. In each epoch and for each worker, I noticed the sequence of values returned by numpy.random functions is exactly the same. This is unexpected since numpy would normally seed the random generator when it is initialized. Example use case: the IterableDataset uses numpy.random to choose image crops - expected to be, well, *random*, not exactly the same for each image for each epoch. Note: this happens without calling torch.manual_seed() or numpy.random.seed(), and without doing anything to make things deterministic. Even if determinism is the default PyTorch policy, the workers should not get re-seeded each epoch. ## To Reproduce <!-- If you have a code sample, error messages, stack traces, please provide it here as well --> ``` import torch import numpy as np from torch.utils.data import DataLoader, Dataset class TestIterableDataset(torch.utils.data.IterableDataset): def __init__(self): super(TestIterableDataset).__init__() def __iter__(self): worker_info = torch.utils.data.get_worker_info() for n in range(10): yield(worker_info.id, np.random.randint(1000000)) ds = TestIterableDataset() for worker_id, number in DataLoader(ds, batch_size=4, num_workers=2): print(worker_id, number) for worker_id, number in DataLoader(ds, batch_size=4, num_workers=2): print(worker_id, number) ``` This prints the same result every time it is run, and the same sequence of random numbers from each worker: ``` # tensor([0, 0, 0, 0]) tensor([ 68669, 230721, 801136, 274196]) # tensor([1, 1, 1, 1]) tensor([ 68669, 230721, 801136, 274196]) # tensor([0, 0, 0, 0]) tensor([617084, 429589, 436968, 718987]) # tensor([1, 1, 1, 1]) tensor([617084, 429589, 436968, 718987]) # tensor([0, 0]) tensor([150977, 59469]) # tensor([1, 1]) tensor([150977, 59469]) ``` ## Expected behavior <!-- A clear and concise description of what you expected to happen. --> Numpy random generator would seed itself from /dev/urandom when RandomState is initialized (different in each worker). ## Environment PyTorch version: 1.5.0 Is debug build: No CUDA used to build PyTorch: 10.1 OS: Ubuntu 18.04.4 LTS GCC version: (Ubuntu 7.5.0-3ubuntu1~18.04) 7.5.0 CMake version: version 3.13.3 Python version: 3.6 Is CUDA available: Yes CUDA runtime version: 10.0.130 GPU models and configuration: GPU 0: Tesla T4 Nvidia driver version: 440.33.01 cuDNN version: Probably one of the following: /usr/local/cuda-10.1/targets/x86_64-linux/lib/libcudnn.so.7.6.5 /usr/local/cuda-10.2/targets/x86_64-linux/lib/libcudnn.so.7.6.5 Versions of relevant libraries: [pip3] numpy==1.15.4 [conda] blas 1.0 mkl [conda] cudatoolkit 10.1.243 h6bb024c_0 [conda] mkl 2020.0 166 [conda] mkl-service 2.3.0 py36he904b0f_0 [conda] mkl_fft 1.0.15 py36ha843d7b_0 [conda] mkl_random 1.1.0 py36hd6b4f25_0 [conda] numpy 1.18.1 py36h4f9e942_0 [conda] numpy-base 1.18.1 py36hde5b4d6_1 [conda] numpydoc 0.9.2 py_0 [conda] pytorch 1.5.0 py3.6_cuda10.1.243_cudnn7.6.3_0 pytorch [conda] torchvision 0.6.0 py36_cu101 pytorch [conda] torchviz 0.0.1 pypi_0 pypi cc @SsnL @VitalyFedyunin @jlin27
module: docs,module: dataloader,triaged
low
Critical
655,611,530
material-ui
[SelectField][material-next] Introduce new component
Minimum example of React Material-UI with the only TextField component imported - result bundle size is 250Kb! https://github.com/pqr/react-mui-treeshake-does-not-work webpack-bundle-analyzer shows everything is imported, nothing is tree shaked. According to documentation https://material-ui.com/guides/minimizing-bundle-size/ tree-shaking should work, quote: > Tree-shaking of Material-UI works out of the box in modern frameworks. Material-UI exposes its full API on the top-level material-ui import. If you're using ES6 modules and a bundler that supports tree-shaking (webpack >= 2.x, parcel with a flag) you can safely use named imports and still get an optimised bundle size automatically: ``` import { Button, TextField } from '@material-ui/core'; ``` But as shown in this minimum example it does not work out of the box. I did several experiments, read through issues and StackOverflow and failed to find a solution. - [+] The issue is present in the latest release. - [+] I have searched the [issues](https://github.com/mui-org/material-ui/issues) of this repository and believe that this is not a duplicate. ## Current Behavior 😯 Bundle size of minimum app with the only TextField imported is about 250Kb, everything is included into bundle (analized with webpack-bundle-analyzer ## Expected Behavior πŸ€” Bundle should not contain any code not related to the only imported TextField, tree shake to be working ## Steps to Reproduce πŸ•Ή ``` git clone [email protected]:pqr/react-mui-treeshake-does-not-work.git cd react-mui-treeshake-does-not-work npm install npm run build npm run analyze ``` ## Your Environment 🌎 | Tech | Version | | ----------- | ------- | | Material-UI | v4.11 | | React | 16.13.1 | | Browser | Any | | TypeScript | No | | Webpack | 4.43 |
performance,breaking change,component: select
low
Critical
655,663,028
flutter
[in_app_purchase] An Active Subscription List iOS
### Question Is there a way to get an active subscription list on iOS using in_app_purchase plugin?
platform-ios,d: api docs,p: in_app_purchase,package,P3,team-ios,triaged-ios
low
Major
655,713,337
flutter
Allow to set the width of a TextFormField
**The problem:** There is no way to set the width of a TextFormField without setting the width of the error text underneath it. **Alternative Solutions:** - I've tried wrapping a TextFormField in a SizedBox to set its width. Problem is, the error text in red underneath the field gets the same width, so the error text doesn't look good (see attached photo). - I've tried creating a custom widget (subclass of StatelessWidget) which will be a wrapper to TextFormField and that accepts a width property. In the build method, I put the TextFormField in a column and add my own Text widget to that column. The custom text should have shown depending on the state of the FormField. Problem is, there is no way to get the FormFieldState. - At last, I managed to solve it by simply copying and pasting TextFormField code to a new file and making the changes from the previous bullet in order to create my own custom generic TextFormField with the required feature. Problem is, if you ever update TextFormField's code, I'll have to be in synced. **Proposal:** Add a "width" property to TextFormField. It's possible to make it backwards compatible in case it's null. ![tempFileForShare_20200712-183850](https://user-images.githubusercontent.com/42715466/87290654-f0e16380-c506-11ea-8073-0fabf7f6332d.jpg)
a: text input,c: new feature,framework,f: material design,a: quality,c: proposal,P3,team-text-input,triaged-text-input
low
Critical
655,713,880
youtube-dl
How to download a channel videos with sorted by max view counts?
Hello. I would like to download certain channel videos with the order of most viewed songs. How can I achieve that? The channel has so many videos so lets say i need only top 200 viewed videos
question
low
Minor
655,740,895
svelte
Binding spread attributes
**Is your feature request related to a problem? Please describe.** I try, to create some component, and i would like use spread attributes. However we can't bind this kind of attributes. Tha's why I think about a solution **Describe the solution you'd like** bind spread like bind:{...attributes} **Describe alternatives you've considered** I don't an other alternatives **How important is this feature to you?** I think it's important, but it's not like a principal feature. **Additional context** Add any other context or screenshots about the feature request here.
feature request
low
Major
655,802,024
godot
get_viewport().size does not resize after going to full screen without waiting x frames
**Godot version:** 3.2.2 Stable **Issue description:** When you switch in full screen and then resize the viewportΒ get_viewport().size, it does not always work. I found that waiting x frames seem to solve the issue. - On mac, in this minimal project, I don't need to wait frames. But in my real project, in need to wait one. - On windows, you need to wait 2 frames - On Linux, you need to wait 3 frames (I tried with two different computer) **Steps to reproduce:** Execute the minimal project, the viewport should be pixelated (320, 180). I added a variable "use_hack", if you want to try my ugly fix. **Minimal reproduction project:** [bugViewport.zip](https://github.com/godotengine/godot/files/4912322/bugViewport.zip)
bug,topic:core,topic:rendering
low
Critical
655,849,569
pytorch
Distributed tests fail with pytest
## πŸ› Bug This might be similar or the same as #19177. I'm getting test failures in the distributed tests. The failing tests are: ``` DistributedDataParallelTest.test_accumulate_gradients_module DistributedDataParallelTest.test_accumulate_gradients_no_sync DistributedDataParallelTest.test_arbitrary_forward_return_value DistributedDataParallelTest.test_ddp_multi_device_module_config DistributedDataParallelTest.test_failure_recovery DistributedDataParallelTest.test_find_unused_parameters_kwarg DistributedDataParallelTest.test_fp16 DistributedDataParallelTest.test_global_local_unused_params_grad DistributedDataParallelTest.test_gloo_backend_1gpu_module_device_ids_integer_list DistributedDataParallelTest.test_gloo_backend_1gpu_module_device_ids_torch_device_list DistributedDataParallelTest.test_gloo_backend_2gpu_module DistributedDataParallelTest.test_gloo_backend_cpu_module DistributedDataParallelTest.test_grad_layout_1devicemodule_1replicaperprocess DistributedDataParallelTest.test_grad_layout_2devicemodule DistributedDataParallelTest.test_ignored_output DistributedDataParallelTest.test_ignored_output_with_unused_parameters DistributedDataParallelTest.test_multiple_outputs_multiple_backward DistributedDataParallelTest.test_nccl_backend_1gpu_module_device_ids_integer_list DistributedDataParallelTest.test_nccl_backend_1gpu_module_device_ids_torch_device_list DistributedDataParallelTest.test_nccl_backend_2gpu_module DistributedDataParallelTest.test_no_grad DistributedDataParallelTest.test_param_layout_mismatch_error DistributedDataParallelTest.test_sparse_gradients CommTest.test_broadcast_coalesced_gloo_cuda CommTest.test_broadcast_coalesced_nccl ``` ## To Reproduce Steps to reproduce the behavior: 1. `cd test && python run_test.py --verbose --pytest -x test_cpp_extensions_aot_no_ninja test_cpp_extensions_aot_ninja test_cpp_extensions_jit` Using pytest to avoid spurious failures in other tests which go away using pytest. The excluded ones fail on POWER9. The logs are pretty much mangled (likely due to parallel processes writing to stdout), but what I could see are `RuntimeError: CUDA error: initialization error` messages. ## Environment PyTorch version: 1.6.0-rc2 Is debug build: N/A CUDA used to build PyTorch: N/A OS: Red Hat Enterprise Linux Server release 7.6 (Maipo) GCC version: (GCC) 8.3.0 CMake version: version 3.15.3 Python version: 3.7 Is CUDA available: N/A CUDA runtime version: 10.1.243 GPU models and configuration: GPU 0: Tesla V100-SXM2-32GB GPU 1: Tesla V100-SXM2-32GB GPU 2: Tesla V100-SXM2-32GB GPU 3: Tesla V100-SXM2-32GB GPU 4: Tesla V100-SXM2-32GB GPU 5: Tesla V100-SXM2-32GB Nvidia driver version: 440.64.00 cuDNN version: Could not collect Versions of relevant libraries: [pip3] numpy==1.17.3 [conda] Could not collect ## Additional context This is on a POWER9 node. Currently testing on an x86 node using the same software versions. Edit: Getting the same errors on an x86 node with K80s cc @pietern @mrshenli @pritamdamania87 @zhaojuanmao @satgera @rohan-varma @gqchen @aazzolini @xush6528 @osalpekar @jiayisuse @agolynski
oncall: distributed,triaged
low
Critical
655,856,620
TypeScript
Allow to overwrite generic templates
## Search Terms - overwrite generic this type - overwrite template argument - class overwrite generic - overwrite type generic ## Suggestion Allow to overwrite generic type templates. ## Use Cases I'm currently developing a modular ORM and query builder, where especially in the query builder part it would be necessary to overwrite a generic template argument. ## Examples Here's a super simple example of a query builder. The `select` method should return a new instance of `Query` but with a different subset of `T` (since it limits the fields being selected). ```typescript interface Entity {} class Query<T extends Entity> { findOne(): T; select(names: (keyof T)[]): this<Partial<T>>; //doesn't work } interface User { username: string; group: string; created: Date; } const item: User = new Query<User>().findOne(); const item: Partial<User> = new Query<User>().select(['username']).findOne(); ``` This is just to demonstrate the use case. You could of course further describe the type of `select` by using `Pick` etc, but I wanted to keep it simple. Please note that I could return `Query<Partial<T>>` instead, but that would break class inheritance. To my awareness this use case can't be covered with the newest TypeScript version. Another use case I had: ```typescript interface Query<T> { findOne(): T; } interface AdapterInterface { createQuery<T extends Entity>(classType: Constructor<T>): Query<T>; } class Database<A extends AdapterInterface> { constructor (private adapter: A) {} // here is the magic with the return type, which doesn't work, but is necessary since // `T` of A['createQuery'] needs to be inferred from query<T>. query<T extends Entity>(classType: Constructor<T>): ReturnType<A['createQuery']><T> { return this.adapter.createQuery(classType); } } class MyAdapterQuery<T> extends Query<T> { additionalMethod(): this; } class MyAdapter { createQuery<T extends Entity>(classType: Constructor<T>): MyAdapterQuery<T> { return new MyAdapterQuery<T>(); } } const database = new Database(new MyAdapter); database.query(User).additionalMethod(); ``` ## Checklist My suggestion meets these guidelines: * [X] This wouldn't be a breaking change in existing TypeScript/JavaScript code * [X] This wouldn't change the runtime behavior of existing JavaScript code * [X] This could be implemented without emitting different JS based on the types of the expressions * [X] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.) * [X] This feature would agree with the rest of [TypeScript's Design Goals](https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals).
Suggestion,Needs Proposal
low
Minor
655,877,366
thefuck
[Bug] Key error when running thefuck on termux
( I will be crossposting it to termux's issues as well because I don't know if it's a problem with termux https://github.com/termux/termux-app/issues/1646 ) <!-- If you have any issue with The Fuck, sorry about that, but we will do what we can to fix that. Actually, maybe we already have, so first thing to do is to update The Fuck and see if the bug is still there. --> <!-- If it is (sorry again), check if the problem has not already been reported and if not, just open an issue on [GitHub](https://github.com/nvbn/thefuck) with the following basic information: --> The output of `thefuck --version` (something like `The Fuck 3.1 using Python 3.5.0 and Bash 4.4.12(1)-release`): Can't run this, I get an error. Your system (Debian 7, ArchLinux, Windows, etc.): Debian (Termux on Android 10, Pixel 3) How to reproduce the bug: run: thefuck --version or alternatively, run: thefuck -h The output of The Fuck with `THEFUCK_DEBUG=true` exported (typically execute `export THEFUCK_DEBUG=true` in your shell before The Fuck): ``` Traceback (most recent call last): File "/data/data/com.termux/files/usr/lib/python3.8/site-packages/psutil/_common.py", line 405, in wrapper return cache[key] KeyError: (('/proc',), frozenset()) During handling of the above exception, another exception occurred: Traceback (most recent call last): File "/data/data/com.termux/files/usr/lib/python3.8/site-packages/psutil/_pslinux.py", line 309, in <module> set_scputimes_ntuple("/proc") File "/data/data/com.termux/files/usr/lib/python3.8/site-packages/psutil/_common.py", line 407, in wrapper ret = cache[key] = fun(*args, **kwargs) File "/data/data/com.termux/files/usr/lib/python3.8/site-packages/psutil/_pslinux.py", line 276, in set_scputimes_ntuple with open_binary('%s/stat' % procfs_path) as f: File "/data/data/com.termux/files/usr/lib/python3.8/site-packages/psutil/_common.py", line 713, in open_binary return open(fname, "rb", **kwargs) PermissionError: [Errno 13] Permission denied: '/proc/stat' Traceback (most recent call last): File "/data/data/com.termux/files/usr/lib/python3.8/site-packages/psutil/_pslinux.py", line 1516, in wrapper return fun(self, *args, **kwargs) File "/data/data/com.termux/files/usr/lib/python3.8/site-packages/psutil/_pslinux.py", line 1734, in create_time bt = BOOT_TIME or boot_time() File "/data/data/com.termux/files/usr/lib/python3.8/site-packages/psutil/_pslinux.py", line 1435, in boot_time with open_binary(path) as f: File "/data/data/com.termux/files/usr/lib/python3.8/site-packages/psutil/_common.py", line 713, in open_binary return open(fname, "rb", **kwargs) PermissionError: [Errno 13] Permission denied: '/proc/stat' During handling of the above exception, another exception occurred: Traceback (most recent call last): File "/data/data/com.termux/files/usr/bin/thefuck", line 5, in <module> from thefuck.entrypoints.main import main File "/data/data/com.termux/files/usr/lib/python3.8/site-packages/thefuck/entrypoints/main.py", line 11, in <module> from ..shells import shell # noqa: E402 File "/data/data/com.termux/files/usr/lib/python3.8/site-packages/thefuck/shells/__init__.py", line 52, in <module> shell = _get_shell_from_env() or _get_shell_from_proc() File "/data/data/com.termux/files/usr/lib/python3.8/site-packages/thefuck/shells/__init__.py", line 45, in _get_shell_from_proc proc = proc.parent() File "/data/data/com.termux/files/usr/lib/python3.8/site-packages/psutil/__init__.py", line 561, in parent ctime = self.create_time() File "/data/data/com.termux/files/usr/lib/python3.8/site-packages/psutil/__init__.py", line 723, in create_time self._create_time = self._proc.create_time() File "/data/data/com.termux/files/usr/lib/python3.8/site-packages/psutil/_pslinux.py", line 1518, in wrapper raise AccessDenied(self.pid, self._name) psutil.AccessDenied: psutil.AccessDenied (pid=13945, name='thefuck') ``` If the bug only appears with a specific application, the output of that application and its version: (N/A) Anything else you think is relevant: I'm using zsh as my shell, and my phone isn't rooted. <!-- It's only with enough information that we can do something to fix the problem. -->
documentation
medium
Critical
655,878,133
opencv
A possible bug in stereobm.cpp
##### System information (version) - OpenCV => 4.2 - Operating System / Platform => Linux 64 Bit - Compiler => gcc ##### Detailed description I found the parabola interpolation used in the stereobm is quite weird. `if( 0 < mind && mind < ndisp - 1 ) { int p = sad[mind+1], n = sad[mind-1]; d = p + n - 2*sad[mind] + std::abs(p - n); dptr[y*dstep] = dispDescale<dType>(ndisp - mind - 1 + mindisp, p-n, d); }` I found the standard function of the parabola interpolation should be min_d = d-(f(d+1)-f(d-1))/(2*(f(d-1)-2*f(d)+f(d+1))) I don't know why the std::abs(p-n) is added and there is a 2 in the denominator is missing. ##### Steps to reproduce <!-- to add code example fence it with triple backticks and optional file extension ```.cpp // C++ code example ``` or attach as .txt or .zip file --> ##### Issue submission checklist - [ ] I report the issue, it's not a question <!-- OpenCV team works with answers.opencv.org, Stack Overflow and other communities to discuss problems. Tickets with question without real issue statement will be closed. --> - [x] I checked the problem with documentation, FAQ, open issues, answers.opencv.org, Stack Overflow, etc and have not found solution <!-- Places to check: * OpenCV documentation: https://docs.opencv.org * FAQ page: https://github.com/opencv/opencv/wiki/FAQ * OpenCV forum: https://answers.opencv.org * OpenCV issue tracker: https://github.com/opencv/opencv/issues?q=is%3Aissue * Stack Overflow branch: https://stackoverflow.com/questions/tagged/opencv --> - [x] I updated to latest OpenCV version and the issue is still there <!-- master branch for OpenCV 4.x and 3.4 branch for OpenCV 3.x releases. OpenCV team supports only latest release for each branch. The ticket is closed, if the problem is not reproduced with modern version. --> - [ ] There is reproducer code and related data files: videos, images, onnx, etc <!-- The best reproducer -- test case for OpenCV that we can add to the library. Recommendations for media files and binary files: * Try to reproduce the issue with images and videos in opencv_extra repository to reduce attachment size * Use PNG for images, if you report some CV related bug, but not image reader issue * Attach the image as archite to the ticket, if you report some reader issue. Image hosting services compress images and it breaks the repro code. * Provide ONNX file for some public model or ONNX file with with random weights, if you report ONNX parsing or handling issue. Architecture details diagram from netron tool can be very useful too. See https://lutzroeder.github.io/netron/ -->
question (invalid tracker),incomplete
low
Critical
655,946,431
flutter
"flutter pub get" does not terminate when killed
This came up in https://github.com/Dart-Code/Dart-Code/issues/2612. If you run `flutter pub get` and try to kill it programatically (similar to how Dart-Code would if you clicked the Cancel button on the dialog), the process doesn't terminate. To repro, you can use this script which creates a `pubspec.yaml` with an invalid package name, which puts Flutter into an endless loop of retries (which is discussed in https://github.com/dart-lang/pub/issues/2242), and then tries to kill it - however it does not stop. I repro'd this using latest Flutter master today. ```dart import 'dart:io'; import 'package:path/path.dart' as path; Future<void> main() async { // Create a temp project final projectFolder = Directory(path.join(Directory.systemTemp.path, 'flutter_pub_test')) ..createSync(recursive: true); // Write a pubspec with a bad package name File(path.join(projectFolder.path, 'pubspec.yaml')) ..writeAsStringSync('name: sample\n' "environment:\n sdk: '>=2.10.0 <3.0.0'\n" 'dependencies:\n not_a_real_package:'); // Run "flutter pub get" and print any stdout/stderr output final proc = await Process.start( 'flutter', ['pub', 'get'], workingDirectory: projectFolder.path, ); proc.stdout.listen((s) => print(String.fromCharCodes(s))); proc.stderr.listen((s) => print(String.fromCharCodes(s))); // Kill the process and wait for it to end await Future.delayed(Duration(seconds: 2)); print('Killing process!'); proc.kill(); print('Waiting for exit!'); await proc.exitCode; } ``` Output: ``` Running "flutter pub get" in flutter_pub_test... Because sample depends on not_a_real_package any which doesn't exist (could not find package not_a_real_package at https://pub.dartlang.org), version solving failed. pub get failed (server unavailable) -- attempting retry 1 in 1 second... Killing process! Waiting for exit! Because sample depends on not_a_real_package any which doesn't exist (could not find package not_a_real_package at https://pub.dartlang.org), version solving failed. pub get failed (server unavailable) -- attempting retry 2 in 2 seconds... Because sample depends on not_a_real_package any which doesn't exist (could not find package not_a_real_package at https://pub.dartlang.org), version solving failed. pub get failed (server unavailable) -- attempting retry 3 in 4 seconds... Because sample depends on not_a_real_package any which doesn't exist (could not find package not_a_real_package at https://pub.dartlang.org), version solving failed. pub get failed (server unavailable) -- attempting retry 4 in 8 seconds... // etc. ``` This results in orphaned processes being left around forever if the user ever saves pubspec with an invalid package name. I thought it might have been related to https://github.com/dart-lang/sdk/issues/42092, however that seems to have been included in this version of Flutter but it's still not fixed. (it's very possible this is a similar issue to we have elsewhere, where sending kill signals to a shell-executed process is unreliable.. we get around this in may places by emitting some JSON with the pid and adding that to the list of things to terminate - however `pub get` doesn't have a machine mode to add that too).
tool,P2,team-tool,triaged-tool
low
Critical
655,953,349
terminal
Add a global mechanism for refering to actions
Spec: #6902, [#6899 - Action IDs.md](https://github.com/microsoft/terminal/blob/main/doc/specs/%236899%20-%20Action%20IDs/%236899%20-%20Action%20IDs.md) > As we come to rely more on actions being a mechanism by which the user defines > "do something in the Terminal", we'll want to make it even easier for users to > re-use the actions that they've already defined, as to reduce duplicated json as > much as possible. This spec proposes a mechanism by which actions could be > uniquely identifiable, so that the user could refer to bindings in other > contexts without needing to replicate an entire json blob. > ![](https://github.com/microsoft/terminal/raw/main/doc/specs/%236899%20-%20Action%20IDs/data-mockup-actions-and-ids-and-keys.png)
Issue-Feature,Area-Settings,Product-Terminal
low
Minor
655,955,700
terminal
Epic: Introduce Actions page to the Settings UI
_written and maintained by @carlos-zamora_ ## Description A largely missing part of the Settings UI is actions. This will allow the user to customize their command palette and key bindings without the need to go into the JSON. Much like the implementation plan for the Settings UI, there are many moving pieces to this that are outside of the `TerminalSettingsEditor` project: - [x] #8100: Inheritance for actions - enables ability to track where an action came from - PR #9621 - [x] serialization for actions - step 1: general serialization - step 2: only serialize meaningful changes into settings.json (don't serialize the whole thing) - PR #9926 - [x] Design Settings UI representation - PR #9427 - [x] Implement proposed design - Foundation (PR #9949) - delete a key binding - set the key chord for a key binding - miscellaneous work (i.e. keyboard navigation, accessibility, etc...) - Set Action - change the action for a key binding (PR #10220) - add a new key binding (PR #10550) Some follow-up work items: - [x] Key chord editor/listener - Instead of parsing key chord text, it'd be nice if we could listen for key chords. - Inspiration: We should take a look at how PowerToys got around this problem. - Inspiration: An old version of SUI also had this implemented (back during the hackathon). - PR #10652 - [ ] "the unbound bug" - Edit `switchToTab` to `win+shift+q`. Save. Edit `switchToTab` to `ctrl+shift+t`. - `"unbound": "win+shift+q"` appears but doesn't need to exist. - [ ] `Actions::_GetContainerIndexByKeyChord` optimization - We're just doing a O(n) search for a matching key chord, but we could technically do this much faster. - The list is already sorted by command name, so if we... 1. use `GetActionByKeyChord()` to get the `Command` 2. perform a binary search on the list using `Command::Name()` (assuming it has a name) - we should be able to accomplish this search in O(log n) time (usually)' - **Performance** - [ ] Clicking Actions in the left bar of Settings takes about 3 seconds to load and doesn't cache/keep it - [ ] #11341 Bugs: - Settings Model: - [X] #10365: not serializing top-level "iterateOn" commands! (PR #10373) - [x] `GetKeyBindingForAction` doesn't always find the given action (PR #10341) - Settings UI: - [x] #10406: Edit button on actions page is invisible with light theme ## References #7175 should be kept in mind during this design.
Product-Terminal,Issue-Scenario,Area-SettingsUI
low
Critical
656,009,306
TypeScript
inferFromUsage JSDoc Quick fix breaks return function pattern
<!-- 🚨 STOP 🚨 STOP 🚨 STOP 🚨 Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Even if you think you've found a *bug*, please read the FAQ first, especially the Common "Bugs" That Aren't Bugs section! Please help us by doing the following steps before logging an issue: * Search: https://github.com/Microsoft/TypeScript/search?type=Issues * Read the FAQ: https://github.com/Microsoft/TypeScript/wiki/FAQ Please fill in the *entire* template below. --> <!-- Please try to reproduce the issue with the latest published version. It may have already been fixed. For npm: `typescript@next` This is also the 'Nightly' version in the playground: http://www.typescriptlang.org/play/?ts=Nightly --> **TypeScript Version:** 4.0.0-dev.20200712 and 3.9.6 **Visual Studio Code Version:** 1.47.0 <!-- Search terms you tried before logging this (so others can find this issue more easily) --> **Search Terms:** https://github.com/microsoft/TypeScript/issues?q=is%3Aissue+is%3Aopen+"Quick+fix"+"return+function" When clicking "Quick Fix..." in vscode for the anonymous function in `reduceUntil` leads to broken behaviour and `reduceUntil` returns `undefined`. You can play with the code at [repl.it](https://repl.it/@dotnetCarpenter/ThirstyGruesomeComputing#index.js) **Code** ```js /** * @param {{(): boolean; (arg0: any): any}} predicate */ function reduceUntil (predicate) { let stop = false return function(accu, x) { if (accu.length === 0) stop = false // reset if new accu if (predicate(x)) stop = true // stop when true if (stop) return accu // return the accumulated return accu + x // append next value to accu } } ``` **Expected behavior:** ```js /** * @param {{ (): boolean; (arg0: any): any; }} predicate */ function reduceUntil (predicate) { let stop = false return /** @type {(accu: string, x: string) => string} */ function (accu, x) { if (accu.length === 0) stop = false // reset if new accu if (predicate(x)) stop = true // stop when true if (stop) return accu // return the accumulated return accu + x // append next value to accu } } ``` **Actual behavior:** ```js /** * @param {{ (): boolean; (arg0: any): any; }} predicate */ function reduceUntil (predicate) { let stop = false return /** * @param {string | any[]} accu * @param {any} x */ function (accu, x) { if (accu.length === 0) stop = false // reset if new accu if (predicate(x)) stop = true // stop when true if (stop) return accu // return the accumulated return accu + x // append next value to accu } } ``` _The above refactoring is b0rken and `reduceUntil` will now return `undefined`._ **Playground Link:** <!-- A link to a TypeScript Playground "Share" link which demonstrates this behavior --> Another accepted documentation refactoring would be to move the type definition to the @return section of the outer function as shown here: https://www.staging-typescript.org/play?useJavaScript=true#code/PQKhCgAIUgBAHAhgJ0QW0gb0wCgJQBckARgPakA2ApogHYDckOKA5gAxF0Cehk3Avv0jxkVACYBLAMaIALlSgxYo2QFdktAM5ZmUqaqKbZyCbRYAaSAA9Dx0yzyQAvAD5IRk2aGixqqVWRFYHAAM1VaKVkJUlpIHz8qAFVaKIocEXFpOSpHTChIAupZd1lSeGdIEMQKTQUCgpV1WLCIqJjdfUsrXPz6+okQpkQ9VQA6ajNZAAtnJydINkcjMoqqmqpIYGA4qlrigchaKgB3PhHevsgD9J8s+RxupdLy+eNVDa2SleOpqli3uqXArXZbwRyNDRnfSbbYQ-6-KGqNCqCjZMQXPpwxGQADU1gAkJ9EPB4H8xIcqFZigA3arvSClREXfjgfhAA **Related Issues:** <!-- Did you find other bugs that looked similar? --> https://github.com/microsoft/vscode/issues/102399 https://github.com/microsoft/TypeScript/issues/31836
Bug,Help Wanted
low
Critical
656,018,594
go
proposal: cmd/go: add a sub command to manage authentication
### The current state The Go command utilitizes the ~/.netrc file, both implicitly and explicitly, to authenticate against remote servers when downloading Go code. Go uses ~/.netrc implicitly when using "direct" downloads because git uses libcurl to fetch dependencies through https which in turn uses the ~/.netrc file to forward credentials. Go uses ~/.netrc explicitly when authenticating against a GOPROXY server by looking for a matching "machine" URL with a valid login and password and forwards those credentials as a BasicAuth header. ### Problem statement A Go programmer who wants to set their credentials (whether against a proxy or VCS) must know how to create/edit the .netrc file in their home directory manually. This is has a few problems: 1. It is not well documented. The only place I can find a mention of the .netrc file is in the [Go FAQ](https://golang.org/doc/faq#git_https) and that is because I was explicitly looking for it. 2. It is not a good UX: you have to learn/follow the netrc syntax to configure your credentials. Furthermore, Go does not validate the .netrc syntax for you. For example, `machine myproxy.com login mytoken` silently fails and does not send the credentials to `myproxy.com` unless I explicitly put `machine myproxy.com login myuser password mytoken`. On the other hand, `machine github.com login mytoken` works just fine for VCS authentication (since this is handled by git and libcurl directly and not by Go) 3. Most importantly, I found that newcomers to Go find this confusing and hard to deal with in comparison to other languages: #### Many languages and tools abstract authentication management in their command line: 1. NodeJS has `npm login`, `npm logout`, and `npm config set|get` which all manage the `~/.npmrc` file. 2. Ruby has `gem signin` and `gem signout` to manage credentials as well (`~/.gem/credentials`) 3. Dart's `pub` command line lets you manage `~/.pub-cache/credentials.json` through an interactive browser that signs in to a Google account when running `pub publish` and it also has `pub signout` to remove those credentials. 4. Docker (though not a language but certainly has a registry) has `docker login` and `docker logout` 5. gcloud (though not a language) can also manage the credentials on the filesystem via `gcloud auth login` and can be static or interactive And the list goes on. ### Proposal Go should provide a more pleasant, and less error prone, way to configure user's credentials for downloading private module dependencies. Specifically, Go should be able to create and edit the ~/.netrc file without the user's direct manipulation of it. Go should be able to add/edit/remove specific lines in the ~/.netrc through the Go command line. #### Examples **Please note**: The following syntax is arbitrary and can definitely be changed. This proposal is more about getting agreement that we should let the Go command manage the .netrc file and is _not_ picky about what the syntax will look like. That said, suggestion on what the command syntax would look like is welcome here. 1. Login to github.com ``` $ go auth login -host=github.com -user=marwan-at-work -password=myToken $ cat ~/.netrc machine github.com login marwan-at-work password myToken ``` ``` $ echo "myToken" | go auth login -host=myproxy.com -user=marwan --password-stdin $ cat ~/.netrc machine github.com login marwan-at-work password myToken machine myproxy.com login marwan password myToken ``` 2. Logout of github.com ``` $ go auth logout github.com $ cat ~/.netrc machine myproxy.com login marwan password myToken ``` 3. List current authentications ``` $ go auth list # or go list auth ``` cc: @heschik @bcmills @jayconrod (I added the modules label, but I don't think it's exclusively for modules so I'm not sure what other label this might fit into) Thank you!
Proposal,Proposal-Hold,modules
medium
Critical
656,035,461
pytorch
[jit] support for torch.distributed primitives
## πŸš€ Feature The [`torch.distributed`](https://pytorch.org/docs/stable/distributed.html) package provides PyTorch support and communication primitives for multiprocess parallelism across several computation nodes running on one or more machines. It is the new basis for the `DistributedDataParallel` wrapper class, which provides a higher-level toolkit for performing synchronous distributed training. An internal request is that we extend TorchScript to support the `torch.distributed` package, so that people can use the distributed communication primitives within a TorchScript program. cc @suo @gmagogsfm
oncall: jit,weeks
medium
Major
656,038,603
rust
Putting braces around match arm with macro call and trait resolution breaks parser
<!-- Thank you for filing a bug report! πŸ› Please provide a short summary of the bug, along with any information you feel relevant to replicating the bug. --> I tried this code: ```rust struct X; macro_rules! foo { () => (X); } fn foo(a: u32) { let _: Option<X> = match a { // This obviously works 0 => X.into(), // This works as well 1 => foo!{}.into(), // This does not _ => { foo!{}.into() }, }; } ``` I expected to see this happen: The code for the default match arm parses successfully just like the others. Instead, this happened: It errors for the default match arm, because of the braces. This happens on every stable and nightly i've tested. This is a minimal reproducer from a program using quote, which gets constantly broken because rustfmt tries to format the actually longer line into a block. ### Meta <!-- If you're using the stable version of the compiler, you should also check if the bug also exists in the beta or nightly versions. --> Playground [stable](https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=bcaef315a0aca327cd8b3dc7cfa53868), [nightly](https://play.rust-lang.org/?version=nightly&mode=debug&edition=2018&gist=a882ba179d1e1da92bb90086e50986f3) `rustc --version --verbose`: ``` rustc 1.45.0-nightly (7ced01a73 2020-04-30) binary: rustc commit-hash: 7ced01a730e8fc1bae2f8d4369c26812c0484da4 commit-date: 2020-04-30 host: x86_64-unknown-linux-gnu release: 1.45.0-nightly LLVM version: 9.0 ```
A-macros,C-bug
low
Critical
656,064,883
PowerToys
[KBM] Allow for programming of the secondary value of NUMPAD keys
# Summary of the new feature/enhancement NUMPAD keys can produce 2 different key presses depending on if you have NUMLOCK enabled or not. E.g. NUMPAD 0 can either type the number 0 or NUMPADINSERT (notice this is different from the regular INSERT, even though they more or less perform the same action). <!-- A clear and concise description of what the problem is that the new feature would solve. Describe why and how a user would use this new functionality (if applicable). --> I want to use the secondary key value attached to NUMPAD keys and still be able to use the 6 functions keys to the left of the numpad separately (i.e., INS, HOME, PGUP, DEL, END, PGDN). So, if I use NUMPADINSERT (while NUMLOCK is OFF) for media play/pause, it plays/pauses my media and the INSERT key (physically to the left of the NUMPAD) is not affected. # Proposed technical implementation details (optional) In AutoHotKey the keycode I use is - "NumpadIns" keys, here are some other possible keycode values that might be useful: - https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/keyCode - https://keycode.info/ <!-- A clear and concise description of what you want to happen. --> Would love to see this implemented as I think this can make the numpad doubly useful.
Idea-Enhancement,Product-Keyboard Shortcut Manager
low
Minor
656,069,350
PowerToys
Change playback source with hotkey
# Summary of the new feature/enhancement A hotkey that changes the playback source on your computer. Makes swapping between playback sources quick and easy into a single hotkey, sometimes I use headphones and other times my speakers, I currently use [https://soundswitch.aaflalo.me/](SoundSwitch) to do this. <!-- A clear and concise description of what the problem is that the new feature would solve. Describe why and how a user would use this new functionality (if applicable). --> It would allow for quick switching between playback sources and I think it matches this projects goal of performing common actions and making it as simple as possible. # Proposed technical implementation details (optional) Maybe the [https://github.com/Belphemur/SoundSwitch](SoundSwitch Github) can be useful. <!-- A clear and concise description of what you want to happen. --> I would love to see implementation as I think it matches this projects goal and is extremely useful.
Help Wanted,Idea-New PowerToy,Resolution-Built into Windows
high
Critical
656,117,311
flutter
Autofill a page without interacting with its text fields
Some (web) autofill services let the user autofill the current page in the extension's dropdown menu, so those extensions need to know the text fields ahead of time, even before any of the text fields gets the focus. Extracted from https://github.com/flutter/flutter/issues/61301
a: text input,c: new feature,framework,P3,team-framework,triaged-framework
low
Major
656,137,409
go
x/tools/gopls: support LocationLink for relevant requests
When requesting `textDocument/definition` gopls returns a [Location](https://github.com/golang/tools/blob/f8240f79c3d38bbbe93f1da8118267168124b29b/internal/lsp/definition.go#L24). This FR is about supporting returning a LocationLink instead for clients that support it (a client capability). Rationale: some editors/plugins can use this to support previewing the entire function on hover. See https://github.com/neovim/neovim/issues/12218 and https://github.com/neovim/neovim/pull/12368 for an in-depth description. In terms of other language servers that do this, it looks like [rust-analyzer](https://github.com/ul/kak-lsp/issues/164) does it as well. All (current) LSP actions that can return `LocationLink`'s: * `textDocument/declaration` * `textDocument/definition` * `textDocument/typeDefinition`
help wanted,FeatureRequest,gopls,Tools
low
Minor
656,189,829
pytorch
[RFC] Device Placement API for RPC
## Goal As of v1.6, `torch.distributed.rpc` only accepts CPU tensors. Applications have to first move the tensor to CPU and then pass it to RPC APIs. This is both inconvenient and slow. The original reason for enforcing CPU tensors is to avoid invalid devices on the destination process. The RPC device placement API aims at (partly) addressing this issue by allowing applications to configure the device mapping on caller and callee. Note that this proposal focuses on changes in API and RPC agents. There will be separate efforts in the comm layer and the distributed autograd engine to improve its efficiency. ## API We can add one `map_location` argument to [`RpcBackendOptions`](https://pytorch.org/docs/master/rpc.html#torch.distributed.rpc.RpcBackendOptions). The example below shows how to configure this field. ```python rpc.init_rpc( "worker0", rank=0, world_size=2, backend=rpc.BackendType.TENSORPIPE, rpc_backend_options=rpc.TensorPipeRpcBackendOptions( num_worker_threads=8, rpc_timeout=20, # 20 second timeout map_location={ "worker1": { "cpu": "cuda:0", "cuda:0": "cuda:1" }, "worker2": { "cpu": "cuda:1", "cuda:0": "cuda:2" } } ) ) x = torch.zeros(2).to(0) y = torch.ones(2).to(0) # x and y will be materialized on "cuda:1" in "worker1". # the return value z will be materialized on "cuda:0" on "worker0", # which is defined by the inverse of the mapping specified by "worker0" z = rpc.rpc_sync("worker1", torch.add, args=(x, y)) # x and y will be materialized on "cuda:2" in "worker2". # the return value z will be materialized on "cuda:0" on "worker0". z = rpc.rpc_sync("worker2", torch.add, args=(x, y)) rpc.shutdown() ``` In this proposal, we only aim to add default `map_location`. If necessary, we can add the per-RPC `map_location` later. This is only intended to be added to the `TensorPipe` backend. `ProcessGroup` backend will throw an exception is this field is specified. ### Device Placement for Return Value There are a few options here. * Option 1: we can use the inverse of the `map_location` to place tensors in the return value. * Option 2: we can add another `return_map_location` for this purpose. * Option 3: use the `map_location` defined on the destination to send return values. The downside of Option 3 is that the caller cannot fully control the behavior of its own RPC. Imagine a Parameter-Server training application with one PS with multiple trainers. Option 3 would requre the PS to define the `map_location` entry for all trainers, which is cumbersome. So it might be more convenient for applications to use Option 1 or 2. As the first version, we can go with Option 1, and when we see requests for Option 2, we can add a `return_map_location` and use entries defined there to override the inverse of `map_location`, so that there will be no BC issue. ## Implementation In the `init_rpc` call, all processes will use the initialized RPC to communicate `map_location` to make sure that there are no invalid devices. If there is any in any process, all processes will throw an error. This `map_location` will be stored in the agent and not necessary to modify `Message` structure. As there is no remote device type yet, agent will first use integers to store devices, -1 for CPU. cc @pietern @mrshenli @pritamdamania87 @zhaojuanmao @satgera @gqchen @aazzolini @rohan-varma @xush6528 @jjlilley @osalpekar @jiayisuse @lw @beauby
feature,triaged,module: rpc,module: tensorpipe
low
Critical
656,191,550
PowerToys
[FancyZones] Quicky switch between layouts with the scroll wheel while dragging a window
I sometimes like to keep my windows in a 3 columns, sometimes 2, sometimes 2 that are not equal width. It would be awesome to be able to quickly switch between layouts. Im thinking while dragging a window and holding shift to see the zones, using the scroll wheel would cycle through the layouts created on that monitor. Thanks!
Idea-Enhancement,FancyZones-Dragging&UI,Product-FancyZones
low
Major
656,193,050
vscode
No way for an extension to tell have vscode suggest .JSON when user saves file if it is not the main extension for json files
Issue Type: <b>Bug</b> See https://github.com/microsoft/vscode-azurearmtools/issues/809 (Save dialog for arm-template files should suggest saving with JSON extension like json files do) 1. Install https://marketplace.visualstudio.com/items?itemName=msazurermtools.azurerm-vscode-tools 2. Create a new file (don't save) 3. Change the language to "ARM Resource Manager Template" 4. CTRL+S !) the dialog doesn't give a suggestion for extension EXPECTED: vscode should suggest .JSON for the extension, but there appears to be no way to get that to happen. MORE INFO: Our package.json info looks like this for the arm-template language id: ``` "languages": [ { "id": "arm-template", "aliases": [ "Azure Resource Manager Template" ], "configuration": "dist/grammars/jsonc.arm.language-configuration.json" } ], ``` I can't put .json as our extension, because if I do, then *all* json files opened will use the arm-template language. Rather, we manually switch to arm-template when we detect a specific schema in a json file (`https://schema.management.azure.com/schemas/2019-04-01/deploymentTemplate.json#`). This is the mechanism that we were told to use because vscode doesn't provide a way to detect language ID based on any content past the first line (see https://github.com/microsoft/vscode/issues/69868#issuecomment-490084449). Unfortunately, that means vscode doesn't know we're associated with json files. VS Code version: Code - Insiders 1.48.0-insider (e7920dce7bfd0b707ebfc0a5379c6edd2233e475, 2020-07-10T11:55:11.286Z) OS version: Darwin x64 19.5.0 <details> <summary>System Info</summary> |Item|Value| |---|---| |CPUs|Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz (12 x 2600)| |GPU Status|2d_canvas: enabled<br>flash_3d: enabled<br>flash_stage3d: enabled<br>flash_stage3d_baseline: enabled<br>gpu_compositing: enabled<br>metal: disabled_off<br>multiple_raster_threads: enabled_on<br>oop_rasterization: disabled_off<br>opengl: enabled_on<br>protected_video_decode: unavailable_off<br>rasterization: enabled<br>skia_renderer: disabled_off_ok<br>video_decode: enabled<br>viz_display_compositor: enabled_on<br>webgl: enabled<br>webgl2: enabled| |Load (avg)|3, 3, 3| |Memory (System)|16.00GB (0.80GB free)| |Process Argv|| |Screen Reader|no| |VM|0%| </details><details><summary>Extensions (5)</summary> Extension|Author (truncated)|Version ---|---|--- gitlens|eam|10.2.2 todo-tree|Gru|0.0.178 vscode-dotnet-runtime|ms-|0.1.2 vscode-typescript-tslint-plugin|ms-|1.2.3 vscode-todo-highlight|way|1.0.4 </details> <!-- generated by issue reporter -->
feature-request,languages-basic
low
Critical
656,220,752
flutter
[Windows] Add mouse cursor "vertical arrow" IDC_UPARROW and other missing cursors
All system mouse cursors from Win32 have been included except for one, `IDC_UPARROW`, whose description goes "a vertical arrow". The reason it is not included is naming. Flutter's system mouse cursors follow a naming convention based on the cursors's usage instead of appearance, which deems `verticalArrow` inappropriate. However this cursor is so rare that I'm not aware of any use cases. If you find this cursor necessary, comment below with a use case (or better, a name) and we can discuss adding this cursor. Related: * https://github.com/flutter/flutter/issues/139692 ------------ Edit: More missing cursors are found, see https://github.com/flutter/flutter/issues/61397#issuecomment-2455627182
c: new feature,framework,platform-windows,a: desktop,a: mouse,P3,team-windows,triaged-windows
low
Minor
656,222,940
TypeScript
Incorrect type allowed in returned object
#### Version 4.0.0-beta / 3.9.5 / 3.9.2 / Nightly ##### Code ``` type V = { p1?: "*" | { p11: object }; p2?: "*" | { p22: object }; } type T = { p3?: "*" | { p33: object }; p4?: "*" | { p44: object }; } type Pt = { [key: string]: ( V | T | "*") } | "*"; type Args = { a1: any, a2: any }; type P = (a: Args) => (Pt | Promise<Pt>); let p: P = async (a: Args) => { return { a: "*", b: { p4: 22, /* Only if these two are removed then p4 will fail the check */ p1: "*", p2: "*" } } }; ``` #### Expected behaviour `p4: 22` should be caught as an incorrect type #### Actual behavior `p4: 22` passes the type check. If the last two properties (p1 and p2) are commented out then `p4: 22` fails the type check; #### Playground links [3.9.2](https://www.typescriptlang.org/play/?ssl=23&ssc=76&pln=25&pc=20#code/C4TwDgpgBAalC8UDeAoK6pgIwH4BcUARAFSFQA+ymWWBA9gEYBWEAxsFAL4DcaGYAJnxFSFKoIH1mbDjxScUKUJCgAVBMj7owAZmEkylJJh06pLdl14ZMAFn2ijd2+ZlX5i5dAAKHRMYBtAGsIEAIAZ2AAJwBLADsAcwBdAgAKWDF1SgMASi4xA14lcGgAQSiE8I1jAENaKBq4kAAaBskGpvcvKG8NVJqCcsq8+AA+KFTfMW8ougBbGPCIAB5fUZyigBsIDjACXsQa8JA41gmBqCHwkfHULSgonYBXKLjNGxsLg2b7mwYCVAfIF2AgCAQ-X7AgD0xCgAHk4psQFAYgAzKDAAAWECWGIA7nQGo8HhA5nQAG4QAAmGOxbzAtigeJim02UFRNRZtOgrGxrCCUGIUMhQOwBG+Io+gnFpElChsCh4QA)
Bug
low
Minor
656,229,056
flutter
Check failed: task_runners_.GetUITaskRunner()->RunsTasksOnCurrentThread()
I ran the ScenariosTests with tsan (I don't think that's related except that maybe it messed with some timing) and it crashed AFTER the tests were done: ``` Test Suite 'All tests' passed at 2020-07-13 16:35:48.663. Executed 5 tests, with 0 failures (0 unexpected) in 6.007 (6.017) seconds 2020-07-13 16:35:48.671724-0700 Scenarios[18957:27995988] flutter: flutter/system = {"type":"memoryPressure"} 2020-07-13 16:35:48.672007-0700 Scenarios[18957:27995988] [VERBOSE-3:shell.cc(1029)] Check failed: task_runners_.GetUITaskRunner()->RunsTasksOnCurrentThread(). CoreSimulator 725.10 - Device: iPhone 8 (563EA154-D457-4CE8-8F0D-D5B9DF05F619) - Runtime: iOS 14.0 (18A5319g) - DeviceType: iPhone 8 (lldb) bt * thread #39, name = 'Test engine for poppable_screen.5.ui', stop reason = signal SIGABRT frame #0: 0x000000010a43933a libsystem_kernel.dylib`__pthread_kill + 10 frame #1: 0x000000010a57be60 libsystem_pthread.dylib`pthread_kill + 430 frame #2: 0x00000001010f88c1 libclang_rt.tsan_iossim_dynamic.dylib`wrap_pthread_kill + 321 frame #3: 0x000000010a18fc54 libsystem_c.dylib`abort + 120 frame #4: 0x00000001010f7c7c libclang_rt.tsan_iossim_dynamic.dylib`wrap_abort + 108 frame #5: 0x000000010319e405 Flutter`fml::LogMessage::~LogMessage(this=0x00007e80015ec878) at logging.cc:92:5 frame #6: 0x000000010319e555 Flutter`fml::LogMessage::~LogMessage(this=0x00007e80015ec878) at logging.cc:63:27 * frame #7: 0x0000000104271b59 Flutter`flutter::Shell::OnEngineHandlePlatformMessage(this=0x00007b7000056800, message=RefPtr<flutter::PlatformMessage> @ 0x00007e80015ecb48) at shell.cc:1029:3 frame #8: 0x0000000104210746 Flutter`flutter::Engine::HandlePlatformMessage(this=0x00007b70000b0000, message=RefPtr<flutter::PlatformMessage> @ 0x00007e80015ecb80) at engine.cc:468:15 frame #9: 0x000000010486ba6d Flutter`flutter::RuntimeController::HandlePlatformMessage(this=0x00007b5800090000, message=<unavailable>) at runtime_controller.cc:304:11 frame #10: 0x000000010468ccca Flutter`flutter::(anonymous namespace)::SendPlatformMessage(window=0x00007b78000c2418, name="flutter/system", callback=0x00007b6c00001938, data_handle=0x00007b78000c2428) at window.cc:121:37 frame #11: 0x000000010468cd8a Flutter`tonic::DartDispatcher<tonic::IndicesHolder<0ul, 1ul, 2ul, 3ul>, _Dart_Handle* (*)(_Dart_Handle*, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, _Dart_Handle*, _Dart_Handle*)>::Dispatch(this=0x00007e80015eccd8, func=(Flutter`flutter::(anonymous namespace)::SendPlatformMessage(_Dart_Handle*, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, _Dart_Handle*, _Dart_Handle*) at window.cc:101))(_Dart_Handle*, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, _Dart_Handle*, _Dart_Handle*)) at dart_args.h:131:16 frame #12: 0x000000010468cabb Flutter`void tonic::DartCallStatic<_Dart_Handle* (*)(_Dart_Handle*, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, _Dart_Handle*, _Dart_Handle*)>(func=(Flutter`flutter::(anonymous namespace)::SendPlatformMessage(_Dart_Handle*, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, _Dart_Handle*, _Dart_Handle*) at window.cc:101), args=0x00007e80015ecdc0)(_Dart_Handle*, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, _Dart_Handle*, _Dart_Handle*), _Dart_NativeArguments*) at dart_args.h:214:11 frame #13: 0x000000010468c30c Flutter`flutter::(anonymous namespace)::_SendPlatformMessage(args=0x00007e80015ecdc0) at window.cc:131:3 frame #14: 0x000000010496d231 Flutter`dart::NativeEntry::AutoScopeNativeCallWrapperNoStackCheck(args=0x00007e80015ecdc0, func=(Flutter`flutter::(anonymous namespace)::_SendPlatformMessage(_Dart_NativeArguments*) at window.cc:130))(_Dart_NativeArguments*)) at native_entry.cc:217:7 frame #15: 0x0000000134e014a4 frame #16: 0x000000013c126bcc frame #17: 0x000000013c1268d3 frame #18: 0x000000013c149b3f frame #19: 0x000000013c12b247 frame #20: 0x000000013c12aa0d frame #21: 0x000000013c1287de frame #22: 0x000000013c128330 frame #23: 0x000000013c127f14 frame #24: 0x000000013c123697 frame #25: 0x000000013c1233bd frame #26: 0x000000013c122853 frame #27: 0x000000013c127cc5 frame #28: 0x000000013c127b5f frame #29: 0x000000013c127236 frame #30: 0x0000000134e016ef frame #31: 0x00000001048fecb2 Flutter`dart::DartEntry::InvokeCode(code=0x0000000134d84ae1, arguments_descriptor=0x00007b78000c3730, arguments=0x00007b78000c36a0, thread=0x0000000134d87d11) at dart_entry.cc:205:7 frame #32: 0x00000001048fea17 Flutter`dart::DartEntry::InvokeFunction(function=0x00007b78000c36f0, arguments=<unavailable>, arguments_descriptor=<unavailable>, current_sp=<unavailable>) at dart_entry.cc:171:10 frame #33: 0x00000001049ab62f Flutter`dart::Library::Invoke(this=0x00007b78000c3690, function_name=0x00007b78000c3680, args=0x00007b78000c36a0, arg_names=0x00007b6c00001588, respect_reflectable=false, check_is_entrypoint=<unavailable>) const at object.cc:12522:10 frame #34: 0x0000000104cffecc Flutter`::Dart_Invoke(target=<unavailable>, name=<unavailable>, number_of_arguments=<unavailable>, arguments=<unavailable>) at dart_api_impl.cc:4650:16 frame #35: 0x0000000104321300 Flutter`tonic::DartInvokeField(target=0x00007b78000c0068, name="_dispatchPlatformMessage", args=([0] = 0x00007b78000c3020, [1] = 0x00007b78000c3018, [2] = 0x00007b78000c3028)) at dart_invoke.cc:16:10 frame #36: 0x000000010468b108 Flutter`flutter::Window::DispatchPlatformMessage(this=0x00007b3800047420, message=RefPtr<flutter::PlatformMessage> @ 0x00007e80015eda48) at window.cc:299:7 frame #37: 0x000000010486b666 Flutter`flutter::RuntimeController::DispatchPlatformMessage(this=0x00007b5800090000, message=RefPtr<flutter::PlatformMessage> @ 0x00007e80015edbf0) at runtime_controller.cc:245:13 frame #38: 0x0000000104211039 Flutter`flutter::Engine::DispatchPlatformMessage(this=0x00007b70000b0000, message=RefPtr<flutter::PlatformMessage> @ 0x00007e80015edc20) at engine.cc:303:28 frame #39: 0x00000001042b9432 Flutter`flutter::Shell::OnPlatformViewDispatchPlatformMessage(this=0x00007b0c00083ee8)::$_21::operator()() const at shell.cc:804:19 frame #40: 0x00000001042b93ad Flutter`decltype(__f=0x00007b0c00083ee8)::$_21&>(fp)()) std::__1::__invoke<flutter::Shell::OnPlatformViewDispatchPlatformMessage(fml::RefPtr<flutter::PlatformMessage>)::$_21&>(flutter::Shell::OnPlatformViewDispatchPlatformMessage(fml::RefPtr<flutter::PlatformMessage>)::$_21&) at type_traits:3545:1 frame #41: 0x00000001042b935d Flutter`void std::__1::__invoke_void_return_wrapper<void>::__call<flutter::Shell::OnPlatformViewDispatchPlatformMessage(__args=0x00007b0c00083ee8)::$_21&>(flutter::Shell::OnPlatformViewDispatchPlatformMessage(fml::RefPtr<flutter::PlatformMessage>)::$_21&) at __functional_base:348:9 frame #42: 0x00000001042b932d Flutter`std::__1::__function::__alloc_func<flutter::Shell::OnPlatformViewDispatchPlatformMessage(fml::RefPtr<flutter::PlatformMessage>)::$_21, std::__1::allocator<flutter::Shell::OnPlatformViewDispatchPlatformMessage(fml::RefPtr<flutter::PlatformMessage>)::$_21>, void ()>::operator(this=0x00007b0c00083ee8)() at functional:1550:16 frame #43: 0x00000001042b81ae Flutter`std::__1::__function::__func<flutter::Shell::OnPlatformViewDispatchPlatformMessage(fml::RefPtr<flutter::PlatformMessage>)::$_21, std::__1::allocator<flutter::Shell::OnPlatformViewDispatchPlatformMessage(fml::RefPtr<flutter::PlatformMessage>)::$_21>, void ()>::operator(this=0x00007b0c00083ee0)() at functional:1724:12 frame #44: 0x000000010318a975 Flutter`std::__1::__function::__value_func<void ()>::operator(this=0x00007b0c000a2930)() const at functional:1877:16 frame #45: 0x0000000103188a75 Flutter`std::__1::function<void ()>::operator(this= Lambda in File shell.cc at Line 802)() const at functional:2549:12 frame #46: 0x00000001031a68f2 Flutter`fml::MessageLoopImpl::FlushTasks(this=0x00007b100003c580, type=kAll) at message_loop_impl.cc:127:5 frame #47: 0x00000001031a67ca Flutter`fml::MessageLoopImpl::RunExpiredTasksNow(this=0x00007b100003c580) at message_loop_impl.cc:137:3 frame #48: 0x00000001031c5885 Flutter`fml::MessageLoopDarwin::OnTimerFire(timer=0x00007b300006ffc0, loop=0x00007b100003c580) at message_loop_darwin.mm:75:11 frame #49: 0x00000001027ea868 CoreFoundation`__CFRUNLOOP_IS_CALLING_OUT_TO_A_TIMER_CALLBACK_FUNCTION__ + 20 frame #50: 0x00000001027ea3e4 CoreFoundation`__CFRunLoopDoTimer + 870 frame #51: 0x00000001027e9af3 CoreFoundation`__CFRunLoopDoTimers + 243 frame #52: 0x00000001027e45fb CoreFoundation`__CFRunLoopRun + 1933 frame #53: 0x00000001027e3aba CoreFoundation`CFRunLoopRunSpecific + 538 frame #54: 0x00000001031c5bbd Flutter`fml::MessageLoopDarwin::Run(this=0x00007b100003c580) at message_loop_darwin.mm:46:20 frame #55: 0x00000001031a6715 Flutter`fml::MessageLoopImpl::DoRun(this=0x00007b100003c580) at message_loop_impl.cc:96:3 frame #56: 0x00000001031a4dfd Flutter`fml::MessageLoop::Run(this=0x00007b040000a4c0) at message_loop.cc:49:10 frame #57: 0x00000001031be164 Flutter`fml::Thread::Thread(this=0x00007b0c000854a8)::$_0::operator()() const at thread.cc:34:10 frame #58: 0x00000001031be09d Flutter`decltype(__f=0x00007b0c000854a8)::$_0>(fp)()) std::__1::__invoke<fml::Thread::Thread(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&)::$_0>(fml::Thread::Thread(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&)::$_0&&) at type_traits:3545:1 frame #59: 0x00000001031be005 Flutter`void std::__1::__thread_execute<std::__1::unique_ptr<std::__1::__thread_struct, std::__1::default_delete<std::__1::__thread_struct> >, fml::Thread::Thread(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&)::$_0>(__t=size=2, (null)=__tuple_indices<> @ 0x00007e80015eff38)::$_0>&, std::__1::__tuple_indices<>) at thread:273:5 frame #60: 0x00000001031bd85b Flutter`void* std::__1::__thread_proxy<std::__1::tuple<std::__1::unique_ptr<std::__1::__thread_struct, std::__1::default_delete<std::__1::__thread_struct> >, fml::Thread::Thread(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&)::$_0> >(__vp=0x00007b0c000854a0) at thread:284:5 frame #61: 0x00000001010f512c libclang_rt.tsan_iossim_dynamic.dylib`__tsan_thread_start_func + 140 frame #62: 0x000000010a57c109 libsystem_pthread.dylib`_pthread_start + 148 frame #63: 0x000000010a577b8b libsystem_pthread.dylib`thread_start + 15 ``` memoryPressure notification? Running Xcode 12 beta 2.
platform-ios,engine,P2,team-ios,triaged-ios
low
Critical
656,232,214
TypeScript
Ability to replace return type of function type
<!-- 🚨 STOP 🚨 𝗦𝗧𝗒𝗣 🚨 𝑺𝑻𝑢𝑷 🚨 Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Please help us by doing the following steps before logging an issue: * Search: https://github.com/Microsoft/TypeScript/search?type=Issues * Read the FAQ, especially the "Common Feature Requests" section: https://github.com/Microsoft/TypeScript/wiki/FAQ --> ## Search Terms * replace return type * parameters generic ## Suggestion I would like to be able to replace just the return type of a function with a utility type, like `WithReturn<F, R>`. I'm not 100% sure this is needed, but it seems like using `(...args: Parameters<F>) => R` is not sufficient because any generics in `F` are lost. ## Use Cases My use case is a utility function that captures the arguments to a function to allow it to be called later. ## Examples ```ts export const defer = <F extends (...args: any) => any>(f: F) => (( ...args: Parameters<F> ) => ({ function: f, args, })) /* as any as F */; const map = <T, R>(array: Array<T>, f: (i: T) => R) => array.map(f); const deferredMap = defer(map); let r = deferredMap([1], (i: number) => 2); // error now: Type 'unknown' is not assignable to type 'number'.(2345) r.args; // error if defer returns F ``` Right now there's an error because the generics to `map()` are lost when using `Parameters`. Playground: https://www.typescriptlang.org/play/?ssl=13&ssc=1&pln=1&pc=1#code/KYDwDg9gTgLgBAYwgOwM7wCbAGbCnAXjgB4AxOUGYZDVOACgDpmBDKAc1QC44XkBPAJSEAfLwEj62HqWEEx9egCg4cZozaceABTYsAtsCpRUZEUrkKA3irjYArsgQwAlih7YANLc2pvAX0FhAHoAKl46Pn4IuHJQ4IBuJSUkNHh9FjBCEgAVTzgAJUk2KBZ+HgBBKFL+YhyRfOkGFx4cy0L2krLGDLApQSTU9DgsXGrgDABZTOzRvHpegeSAGyM4fCI58anM+gBtAEYAXXz6Frhke30AIzx2gCYlqA0OVCSgA ## Checklist My suggestion meets these guidelines: * [x] This wouldn't be a breaking change in existing TypeScript/JavaScript code * [x] This wouldn't change the runtime behavior of existing JavaScript code * [x] This could be implemented without emitting different JS based on the types of the expressions * [x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.) * [x] This feature would agree with the rest of [TypeScript's Design Goals](https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals).
Suggestion,Awaiting More Feedback
low
Critical
656,249,590
node
Passing a URL instance with a CONNECT method results in an invalid path
* **Version**: >=v10.21.0 * **Platform**: Linux solus 5.6.18-156.current #1 SMP PREEMPT Sun Jun 21 07:16:38 UTC 2020 x86_64 GNU/Linux * **Subsystem**: http, https, url ### What steps will reproduce the bug? ```js const http = require('http'); const server = http.createServer(); server.on('connect', (request, stream) => { console.log(request.url); stream.end('HTTP/1.1 501 Not Implemented\r\n\r\n'); }); server.listen(error => { if (error) { throw error; } const url = new URL(`http://localhost:${server.address().port}/example.com`); const request = http.request(url, {method: 'CONNECT'}).end(); request.once('connect', response => { response.destroy(); server.close(); }); }); ``` ### How often does it reproduce? Is there a required condition? Always. ### What is the expected behavior? ``` example.com ``` ### What do you see instead? ``` /example.com ``` ### Additional information There is a workaround for this: ```diff -const request = http.request(url, {method: 'CONNECT'}).end(); +const request = http.request({ + hostname: url.hostname, + port: url.port, + path: 'example.com', + method: 'CONNECT' +}).end(); ``` /cc @yovanoc
http
low
Critical
656,298,982
godot
Editing labels seem to be buggy
**Godot version:** 3.2.2 **OS/device including version:** MacOS **Issue description:** There seem to be two issues with the **Label** node as follows (possibly related): 1) Renaming a label node does not rename the first time. Renaming a second time causes it to be renamed but add a number after it. For example if I rename "Label" to "Label5" it will stay as "Label". If I again rename it to "Label5" it will rename it to Label6". 2) If I click on a **Label** in the **Scene** section, it shows up **Inspector** section without any of the properties set. The property names are also all shown in red. However, if I select the label in the main editor by clicking on it, then it shows correctly in the **Inspector** window. Note: I also posted a third label issue earlier today which I think is unrelated. **Minimal reproduction project:** Please see attached sample. [KWGodot001-debug.zip](https://github.com/godotengine/godot/files/4916401/KWGodot001-debug.zip)
bug,topic:editor,topic:gui
low
Critical
656,304,569
pytorch
Large overhead (7 microseconds) for PyTorch operation
## πŸ› Bug Hi, I am new to PyTorch so apologies if I am missing something obvious! My use case involves narrow models with small input dimension (<100). After noticing slower training time than expected, I did some profiling and found that there seems to be an overhead of ~7 microseconds for the simplest tensor operations. ``` import torch import time x = torch.ones(1, requires_grad=True) start = time.time() for _ in range(1000000): y = 2*x print(time.time() - start) ``` gives an output of 6.8 seconds for 1 million operations. It is only a bit faster with `requires_grad=False` (still 5 microseconds per operation). Some research into PyTorch overhead turned up this thread from 2017: https://github.com/pytorch/pytorch/issues/2518, which discusses a fix that was intended to reduce overhead down to 1 microsecond. Has there been a regression since then? Is it feasible to reduce this overhead / is this in the roadmap for PyTorch? Curious to better understand why the overhead is as large as it is; even with dynamic memory allocations to expand the compute graph I would expect something on the order of hundreds of nanoseconds. Thank you for your time! cc @VitalyFedyunin @ngimel
module: performance,triaged
low
Critical
656,432,886
godot
Safe save fails way too often
Couldn't find any potential dupes. **Godot version:** 3.2.1.stable 3.2.2.stable These two versions of Godot are the only ones I've ever used, and it happens on both of them. **OS/device including version:** Microsoft Windows NT Version 10.0.18363.900 running on an Intel Core i3 and integrated graphics, This is not a visual problem. **Issue description:** I keep experiencing a certain issue, and I'm getting sick of it. It happens sometimes when I do one or more of these things: - Run the project - Export the project - Save a change while it's running - Save a change while it's not running (although it happens less often when not running!) - Adding a file to the project The issue I'm experiencing is this: `ERROR: Safe save failed. This may be a permissions problem, but also may happen because you are running a paranoid antivirus. If this is the case, please switch to Windows Defender or disable the 'safe save' option in editor settings. This makes it work, but increases the risk of file corruption in a crash.` Firstly, no, Switching to Windows Defender doesn't solve the issue. Secondly, my antivirus isn't picking up Godot. And lastly, disabling safe save doesn't help. What I think the issue is is that it's trying to write to a file that's in use. **Steps to reproduce:** I think you have the best chance at getting this when saving a change to scene X while it's using scene X. **Minimal reproduction project:** N/A
bug,platform:windows,topic:editor,confirmed
medium
Critical
656,467,347
pytorch
About the description of the mathematical formula of nn.RNN, I think it is wrong
## πŸ“š Documentation ![image](https://user-images.githubusercontent.com/33288114/87407914-60ce1780-c5f5-11ea-80eb-4fdb8c374463.png) This formula confuses me because this formula does not look like a matrix formula. I can't determine whether W or x is a matrix or a vector.I think your formula does not consider the consistency of matrix dimensions. According to the relevant weights and input dimensions provided by the official documentation , I think the correct formula should be: ![image](https://user-images.githubusercontent.com/33288114/87409139-1e0d3f00-c5f7-11ea-953e-3fe0ffcb727f.png) cc @jlin27
module: docs,triaged
low
Minor
656,505,777
flutter
[engine] Inconsistent documents of build env on Windows host
**Should `GYP_MSVS_VERSION` be empty, `2017` or `2019`?** - compiling-for-windows According to https://github.com/flutter/flutter/wiki/Compiling-the-engine#compiling-for-windows, there no need for `GYP_MSVS_VERSION` ```cmd DEPOT_TOOLS_WIN_TOOLCHAIN=0 GYP_MSVS_OVERRIDE_PATH="C:\Program Files (x86)/Microsoft Visual Studio/2019/Community" (or your location for Visual Studio) WINDOWSSDKDIR="C:\Program Files (x86)\Windows Kits\10" (or your location for Windows Kits) ``` - compiling-for-the-web-on-windows According to https://github.com/flutter/flutter/wiki/Compiling-the-engine#compiling-for-the-web-on-windows, there a version conflict in `GYP_MSVS_OVERRIDE_PATH` and `GYP_MSVS_VERSION` ```cmd GYP_MSVS_OVERRIDE_PATH = "C:\Program Files (x86)\Microsoft Visual Studio\2019\Community" GYP_MSVS_VERSION = 2017 ``` - buildroot/build/vs_toolchain.py As to https://github.com/flutter/buildroot/blob/f9331b6af6e690516a2ffdc14622c768977e3c97/build/vs_toolchain.py#L93-L97, `GYP_MSVS_VERSION` could be inferred from `GetVisualStudioVersion()` and left `empty` ```python elif sys.platform == 'win32' and not depot_tools_win_toolchain: if not 'GYP_MSVS_OVERRIDE_PATH' in os.environ: os.environ['GYP_MSVS_OVERRIDE_PATH'] = DetectVisualStudioPath() if not 'GYP_MSVS_VERSION' in os.environ: os.environ['GYP_MSVS_VERSION'] = GetVisualStudioVersion() ```
engine,platform-windows,P2,team-engine,triaged-engine
low
Major
656,519,778
godot
Crash when running project while renaming AnimationTree nodes
**Godot version:** 3.2 **OS/device including version:** Windows 10 64-bit **Issue description:** If you run the project while you are in the middle of renaming/have renamed (but not committed) an AnimationTree graph node, the editor will crash. (Saving the project with CTRL-S while still inside the field also will not commit the new name, it'll still crash) **Steps to reproduce:** - Create a simple AnimationTree node and add any subnode - Alter the name, hit F5 while the text field is still focused
bug,topic:editor,confirmed,crash,topic:animation
low
Critical
656,521,409
TypeScript
Experimental Decorators don't work in `export` statements
<!-- 🚨 STOP 🚨 STOP 🚨 STOP 🚨 Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Even if you think you've found a *bug*, please read the FAQ first, especially the Common "Bugs" That Aren't Bugs section! Please help us by doing the following steps before logging an issue: * Search: https://github.com/Microsoft/TypeScript/search?type=Issues * Read the FAQ: https://github.com/Microsoft/TypeScript/wiki/FAQ Please fill in the *entire* template below. --> <!-- Please try to reproduce the issue with the latest published version. It may have already been fixed. For npm: `typescript@next` This is also the 'Nightly' version in the playground: http://www.typescriptlang.org/play/?ts=Nightly --> **TypeScript Version:** JavaScript + ESNext **Search Terms:** export+experimental+decorators+export **Code** ```js export default @x class A { } ``` [❌ ] The above does not work. ```js @x class A {} export default A; ``` [πŸ‘Œ ] It does work when going with the old syntax, that is splitting `export` statement and `class` expression. I.e. this works fine: **Expected behavior:** The syntax should be valid, according to [@babel/plugin-proposal-decorators](https://babeljs.io/docs/en/babel-plugin-proposal-decorators#decoratorsbeforeexport), which is also in line with tc39, [as discussed here](https://github.com/tc39/proposal-decorators/issues/69). **Actual behavior:** The first `@` raises: > Expression expected. ts(1109) **Playground Link:** <!-- A link to a TypeScript Playground "Share" link which demonstrates this behavior --> https://www.typescriptlang.org/play/?target=99&ts=4.0.0-dev.20200714&useJavaScript=true#code/KYDwDg9gTgLgBAE2AMwIYFcA2MBQABGVAcwAoByYAYwFsBaUMTVASwDtgoyBKfGYaxqj7kAPAmYA3AHwiA9OOncclJgGdVcALIBPAMIQBcUH1YINAZUzNqcAN44AvkA **Related Issues:** <!-- Did you find other bugs that looked similar? --> I previously posted on VSCode issues and was sent here: * https://github.com/microsoft/vscode/issues/102386
Suggestion,Waiting for TC39
low
Critical
656,523,682
godot
Particles2D and CPUParticles2D's `preprocess` property does nothing
<!-- Please search existing issues for potential duplicates before filing yours: https://github.com/godotengine/godot/issues?q=is%3Aissue --> Probably related to #34610 **Godot version:** <!-- Specify commit hash if using non-official build. --> 3.2.2 **OS/device including version:** Windows 10, GTX1070 **Issue description:** particles (CPU or GPU) preprocessing has no effect. **Steps to reproduce:** create particles and run **Minimal reproduction project:** [test_particle_preprocess.zip](https://github.com/godotengine/godot/files/4918295/test_particle_preprocess.zip)
bug,topic:particles
low
Major
656,529,137
godot
Godot file manger is shown upside-down (Y flipped) and icons are missing [Oracle VM]
<!-- Please search existing issues for potential duplicates before filing yours: https://github.com/godotengine/godot/issues?q=is%3Aissue --> **Godot version:** v3.2.2.stable.official (reproducible also v3.2.1.stable.official) **OS/device including version:** Virtual box 6.1: Host Win10 x64, Guest Win10 x64 (on the guest Linux Ubuntu 18.04 is not reproducible) Godot Engine v3.2.2.stable.official - https://godotengine.org OpenGL ES 2.0 Renderer: SVGA3D; build: RELEASE; OpenGL ES 2.0 Batching: ON **Issue description:** The file manager is shown upside-down with strange localization. ![image](https://user-images.githubusercontent.com/3696772/87418738-7ed65080-c5d2-11ea-871c-72b734347f8b.png) **Steps to reproduce:** Just run Godot. **Minimal reproduction project:** Just run Godot.
bug,platform:windows,topic:rendering,confirmed,topic:thirdparty
low
Major
656,557,397
rust
Borrow compilation error with `vec.swap(0, vec.len() - 1)`, while `vec.push(vec.len())` works.
I tried compiling this code (here is the [playgound link](https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=041100f41b68065df13e143d640893a0)): ```rust fn main() { let mut vec = vec![]; vec.push(vec.len()); vec.push(vec.len() - 1); // This works! vec.swap(0, vec.len() - 1); // Error } ``` I expected a **Successful compilation**, but _this_ happened: ``` error[E0502]: cannot borrow `vec` as immutable because it is also borrowed as mutable ``` ```rust --> src/main.rs:6:17 | 6 | vec.swap(0, vec.len() - 1); | --- ---- ^^^ immutable borrow occurs here | | | | | mutable borrow later used by call | mutable borrow occurs here ``` Note 1: that the line above the error also contains `vec.len()`, but it compiles. Note 2: `vec.swap(0, vec.len());` produces the same error (nothing to do with ` - 1`). ### Meta `rustc --version --verbose`: ``` rustc 1.44.1 binary: rustc commit-hash: unknown commit-date: unknown host: x86_64-unknown-linux-gnu release: 1.44.1 LLVM version: 10.0 ``` Also confirmed in the [playground](https://play.rust-lang.org/) against _Nightly_ and _Beta_.
A-borrow-checker,T-compiler,C-bug
low
Critical
656,584,532
pytorch
Bottleneck when publishing the model using flask about 3 times slower.
## πŸ› Bug When I publish the model using flask, it takes 3 times longer than the normal run. My model takes about 36 sec to run, but when I converted it to an API it took 122 sec ## To Reproduce I've confirmed this problem when running your launched model at the tutorials [here](https://pytorch.org/tutorials/intermediate/flask_rest_api_tutorial.html). The result of the profiling is the python3.7/site-packages/torch/nn/modules/conv.py file is the one which take the most time (and hence 3 duplicates of the time when it's an API) Steps to reproduce the behavior: 1. Calculate the time the function `get_prediction` (in the link above) takes when it's an API (for me was 0.6 sec) 1. Comment the API code and call the `get_prediction` function normally with passing an image 1. Calculate the time of the last step (for me was 0.2 sec) <!-- If you have a code sample, error messages, stack traces, please provide it here as well --> ## Expected behavior I was expecting that both have a close running time, not 3x time ## Environment Collecting environment information... PyTorch version: 1.2.0 Is debug build: No CUDA used to build PyTorch: 10.0.130 OS: Ubuntu 18.04.4 LTS GCC version: (Ubuntu 7.5.0-3ubuntu1~18.04) 7.5.0 CMake version: version 3.10.2 Python version: 3.7 Is CUDA available: No CUDA runtime version: No CUDA GPU models and configuration: No CUDA Nvidia driver version: No CUDA cuDNN version: No CUDA Versions of relevant libraries: [pip] numpy==1.18.1 [pip] torch==1.2.0 [pip] torchvision==0.4.0a0 [conda] _pytorch_select 0.2 gpu_0 [conda] blas 1.0 mkl [conda] cudatoolkit 10.0.130 0 [conda] mkl 2020.1 217 [conda] mkl-service 2.3.0 py37he904b0f_0 [conda] mkl_fft 1.0.15 py37ha843d7b_0 [conda] mkl_random 1.1.1 py37h0573a6f_0 [conda] numpy 1.18.1 py37h4f9e942_0 [conda] numpy-base 1.18.1 py37hde5b4d6_1 [conda] pytorch 1.2.0 cuda100py37h938c94c_0 [conda] torchvision 0.4.0 cuda100py37hecfc37a_0 cc @VitalyFedyunin @ngimel
module: performance,module: cpu,triaged
low
Critical
656,585,555
go
runtime/pprof: provide method to dump cpu profile as plain text
### What version of Go are you using (`go version`)? <pre> $ go version go version go1.13.12 darwin/amd64 </pre> ### Does this issue reproduce with the latest release? Y ### What operating system and processor architecture are you using (`go env`)? <details><summary><code>go env</code> Output</summary><br><pre> $ go env </pre></details> ### What did you do? use runtime/pprof to dump cpu/mem/goroutine profile. ### What did you expect to see? All types of profiles should have plain text output, eg I can write memory or any other profile as plain text: ```go pprof.Lookup("heap").WriteTo(&buf, 1) ``` But it's really hard to get a plain text CPU profile, especially when there is no executable go or pprof binary and no internet connection. ### What did you see instead? There is no way to dump cpu profile directly in plain text.
NeedsInvestigation,compiler/runtime
low
Minor
656,604,833
flutter
Requesting vertical/horizontal split layout widget
I came across flutter devtools project, @DaveShuckerow did implement [split widget](https://github.com/flutter/devtools/commit/4384ed3cf23a2cb30d4be108fc40ad2049a4db22) that looks like Qsplitter provided by QT
c: new feature,framework,c: proposal,P3,team-framework,triaged-framework
low
Minor
656,623,158
pytorch
test_jit.py fails on Power
## πŸ› Bug Various tests from test_jit.py fail on Power. This might be related to #41186 as some tests have similar names to the ones failing there. The failing tests are: - test_solve_batched_broadcast_A_cpu (__main__.TestJitGeneratedAutogradCPU) - test_solve_batched_broadcast_b_cpu (__main__.TestJitGeneratedAutogradCPU) - test_solve_batched_cpu (__main__.TestJitGeneratedAutogradCPU) - test_solve_batched_dims_cpu (__main__.TestJitGeneratedAutogradCPU) - test_solve_cpu (__main__.TestJitGeneratedAutogradCPU) - test_nn_conv_transpose3d (__main__.TestJitGeneratedFunctional) - test_dcgan_models (jit.test_models.TestModels) - test_vae (jit.test_models.TestModels) ## To Reproduce Steps to reproduce the behavior: 1. python run_tests.py The errors are a bit more descriptive as in the other issue. Some examples: ``` AssertionError: False is not true : Tensors failed to compare as equal! With rtol=1e-07 and atol=1e-07, found 9 element(s) (out of 100) whose difference(s) exceeded the margin of error (including 0 nan comparisons). The greatest difference was 1.7090110120655737 (2.232483364960445 vs. 0.5234723528948716), which occurred at index (0, 1, 4, 4). AssertionError: False is not true : Tensors failed to compare as equal! With rtol=1e-07 and atol=1e-07, found 5 element(s) (out of 100) whose difference(s) exceeded the margin of error (including 0 nan comparisons). The greatest difference was 0.6121940686973842 (1.2383958096589895 vs. 0.6262017409616053), which occurred at index (0, 0, 4, 2). AssertionError: False is not true : Tensors failed to compare as equal! With rtol=1e-07 and atol=1e-07, found 13927 element(s) (out of 18225) whose difference(s) exceeded the margin of error (including 0 nan comparisons). The greatest difference was 47.19980373887701 (46.73646571072269 vs. -0.4633380281543156), which occurred at index (3, 4, 3, 4, 4). ``` The failing tests are not consistently the same and (opposed to #41186) this doesn't get solved by using pytest instead. ## Environment PyTorch version: 1.6.0-rc2 Is debug build: No CUDA used to build PyTorch: 10.1 OS: Red Hat Enterprise Linux Server release 7.6 (Maipo) GCC version: (GCC) 8.3.0 CMake version: Could not collect Python version: 3.7 Is CUDA available: Yes CUDA runtime version: 10.1.243 GPU models and configuration: GPU 0: Tesla V100-SXM2-32GB GPU 1: Tesla V100-SXM2-32GB GPU 2: Tesla V100-SXM2-32GB GPU 3: Tesla V100-SXM2-32GB GPU 4: Tesla V100-SXM2-32GB GPU 5: Tesla V100-SXM2-32GB Nvidia driver version: 440.64.00 cuDNN version: Could not collect Versions of relevant libraries: [pip3] numpy==1.17.3 [pip3] torch==1.6.0 cc @suo @gmagogsfm
oncall: jit,triaged
low
Critical
656,755,345
godot
Certain child node properties not editable in the inspector while parent node is being animated
**Godot version:** 3.2.2-stable **OS/device including version:** Windows 10 AMD Radeon Vega 10 Graphics Using GLES2 graphics **Issue description:** A Sprite's position is being animated by an AnimatedPlayer node and a CPUParticles2D node is a child of that sprite, and moves along with it. While the animation is playing, certain properties of the particles node aren't editable in the inspector. They can be selected but are immediately deselected. When the animation is stopped, the properties behave like normal. The uneditable properties I tried belong to a Gradient created in the particles Color/ColorRamp property. i.e. if I click on either of the Gradient's PoolColorArray colors, the color picker appears for a split second and then disappears. In my experience any other properties of the CPUParticles2D node work like normal, even while the animation is playing. ![godot_bug](https://user-images.githubusercontent.com/57452270/87453146-b986bb80-c5c7-11ea-9978-4f2597c51168.gif)
bug,topic:editor
low
Critical
656,764,208
tensorflow
Windows - tensorflow.python.framework.errors_impl.UnknownError: Failed to rename:
**System information** OS Name: Microsoft Windows 10 Enterprise OS Version: 10.0.17763 N/A Build 17763 TensorFlow installed using 'conda'. tensorflow v2.2.0-rc4-8-g2b96f3662b 2.2.0 Python 3.6.10 |Anaconda, Inc.| (default, Jan 7 2020, 15:18:16) [MSC v.1916 64 bit (AMD64)] on win32 **Describe the current behavior** Saving checkpoint files from tensorflow is failing on Windows 10. ``` Traceback (most recent call last): File "C:\Users\<redacted>\Miniconda3\envs\<redacted>\lib\runpy.py", line 193, in _run_module_as_main "__main__", mod_spec) File "C:\Users\<redacted>\Miniconda3\envs\<redacted>\lib\runpy.py", line 85, in _run_code exec(code, run_globals) File "C:\Git\<redacted>\tests\integration\validate_train_model.py", line 216, in <module> main() File "C:\Git\<redacted>\tests\integration\validate_train_model.py", line 176, in main fig_save_freq = fig_save_freq) File "c:\git\<redacted>\src\pointnet\model.py", line 640, in fit self.save_best_model() File "c:\git\<redacted>\src\pointnet\model.py", line 493, in save_best_model check_interval = False) File "C:\Users\<redacted>\Miniconda3\envs\<redacted>\lib\site-packages\tensorflow\python\training\checkpoint_management.py", line 823, in save self._record_state() File "C:\Users\<redacted>\Miniconda3\envs\<redacted>\lib\site-packages\tensorflow\python\training\checkpoint_management.py", line 728, in _record_state save_relative_paths=True) File "C:\Users\<redacted>\Miniconda3\envs\<redacted>\lib\site-packages\tensorflow\python\training\checkpoint_management.py", line 248, in update_checkpoint_state_internal text_format.MessageToString(ckpt)) File "C:\Users\<redacted>\Miniconda3\envs\<redacted>\lib\site-packages\tensorflow\python\lib\io\file_io.py", line 532, in atomic_write_string_to_file rename(temp_pathname, filename, overwrite) File "C:\Users\<redacted>\Miniconda3\envs\<redacted>\lib\site-packages\tensorflow\python\lib\io\file_io.py", line 491, in rename rename_v2(oldname, newname, overwrite) File "C:\Users\<redacted>\Miniconda3\envs\<redacted>\lib\site-packages\tensorflow\python\lib\io\file_io.py", line 508, in rename_v2 compat.as_bytes(src), compat.as_bytes(dst), overwrite) tensorflow.python.framework.errors_impl.UnknownError: Failed to rename: tests\files\checkpoints\0000_00_00_00_00_00\checkpoint.tmpc6ee5d6bc5a445c884bba8c3acadf01f to: tests\files\checkpoints\0000_00_00_00_00_00\checkpoint : Access is denied. ; Input/output error ``` Problem traced to: tensorflow.python.lib.io.file_io, line 532, function atomic_write_string_to_file From debugging, tensorflow attempts to create, then overwrite a file while saving a checkpoint. For some reason, the 'overwrite' parameter, although set to True, does nothing. This causes the rename to fail (since the file seems to get created earlier in the checkpoint save process). We tried deleting the 'checkpoint' file before the 'save', but the checkpoint file that it's trying to overwrite appears to be created as a part of the 'save' call. I was able to get checkpoint saving working again by modifying atomic_write_string_to_file as follows. My change checks for existence of the rename target and deletes it using os.remove if overwrite is True, rather than relying on the tensorflow custom machinery that doesn't seem to be working: ```python def atomic_write_string_to_file(filename, contents, overwrite=True): if not has_atomic_move(filename): write_string_to_file(filename, contents) else: temp_pathname = filename + ".tmp" + uuid.uuid4().hex write_string_to_file(temp_pathname, contents) try: if overwrite and os.path.exists(filename): os.remove(filename) rename(temp_pathname, filename, overwrite) except errors.OpError: delete_file(temp_pathname) raise ``` The stack trace we got suggested that this is the same issue as someone was reporting for tensorflow.models: https://github.com/tensorflow/models/issues/4177 **Describe the expected behavior** We should be able to successfully save a checkpoint on Windows 10.
type:bug,comp:gpu,TF 2.5
medium
Critical
656,776,454
TypeScript
`void` parameter type produced from generic inference doesn't allow skipping as argument
<!-- Please try to reproduce the issue with the latest published version. It may have already been fixed. For npm: `typescript@next` This is also the 'Nightly' version in the playground: http://www.typescriptlang.org/play/?ts=Nightly --> **TypeScript Version:** 3.7.2, 3.9.6, 4.0.0-beta <!-- Search terms you tried before logging this (so others can find this issue more easily) --> **Search Terms:** overload, void, indexed void, implicit void **Code** ```ts class Hooks<TMap extends Record<string, any>> { one(a: keyof TMap, b: void) { } two<K extends keyof TMap>(a: K, b: TMap[K]) { } } const h = new Hooks<{foo: void}>() h.one('foo'); // OK h.two('foo'); // Expected 2 arguments, but got 1.(2554) ``` **Expected behavior:** both methods can be called with only one argument **Actual behavior:** `TMap[K]` that is resolved to `void` does not allow skip argument Although, this one works as expected: ```ts // v1 works interface EvtMap { one: string; two: void; } const createMethod = <N extends keyof EvtMap>(eventName: N) => (ctx: EvtMap[N]) => null; createMethod('one')(''); createMethod('two')(); // v2 fails interface EvtMap { one: string; two: void; } const createMethod = <EvtMap>() => <N extends keyof EvtMap>(eventName: N, ctx: EvtMap[N]) => null; createMethod<EvtMap>()('one', ''); createMethod<EvtMap>()('two'); // generic method fails interface TMap { foo: void } class Hooks { one(a: keyof TMap, b: void) { } two<K extends keyof TMap>(a: K, b: TMap[K]) { } } const h = new Hooks() h.one('foo'); // OK h.two('foo'); // Expected 2 arguments, but got 1.(2554) ``` **Playground Link:** - [generic class](https://www.typescriptlang.org/play/?target=1&ts=4.0.0-beta#code/MYGwhgzhAEASD28DWEA8AVAsmADtApgB4Au+AdgCYwBK+w8AThahMQwJZkDmANNGGQCeAPmHQA3tACwAKGjzo8MvgAUYAFzQk+QfABm0LLj4AjTQDd47CgEoJ0AL6yF0YgHd4qANIES5Klo6+obYOMJqml6mmkY4ANpeALp2kk4yabL0ZKzQABbQALzQym5wiCioknqIFlYUjuE2srK5AHRKqgDk1fCdNgDcLa3u8CrdiH39QA) fails - [generic method](https://www.typescriptlang.org/play/?target=1&ts=4.0.0-beta&ssl=4&ssc=12&pln=4&pc=46#code/JYOwLgpgTgZghgYwgAgCoFk4AdkG9kCwAUMqcjAPYUBcyAbhcACbEC+xCANnAM4-IAJKgGt++YmWQUQEABRxawiAE8KMNJiwAaZACNaDZgEo8ydiTJgA7hQA8AaWQQAHpBBN+S1eozYAfPK09jr6GtgA2vYAuib45uYI0jxgyAAWyAC8yDJWgiI8skbEqQB00nIA5JQUFUYA3MgA9I3IAPL2xSXWFLJVVLUNzcgAos5YEAiQTMgATMhwUADmAK4AthDgPCHLKYsUKQCMJbIzAKynACxGQA) fails - [Creator function v1](https://www.typescriptlang.org/play/?target=1&ts=4.0.0-beta#code/JYOwLgpgTgZghgYwgAgKIDcwFk4AdkDeAsAFDLnID2IEAXMgM5hSgDmA3KRcmAO6X10lYABNOJAL6lSCak2QIoEOJCwQwAC0ojkAXmQAeAHLIIAD0ggRDZAGsIAT0ow0mHLgB8ACgjoI4IzgAWzpkIwBKPQ8uCi8EMDN6DGw8AG0jAF1I3Q9kEABXABtC8RklFQg1TW0vAHJqCFrwuqbxRWVVdS0ROr5KJq9w9iA) works - [Creator function v2](https://www.typescriptlang.org/play/index.html?ssl=10&ssc=31&pln=1&pc=1#code/JYOwLgpgTgZghgYwgAgKIDcwFk4AdkDeAsAFDLnID2IEAXMgM5hSgDmA3KRcmAO6X10lYABNOJAL6lSCak2QIoEOJCwQwAC0ojkAXmQAeDNjwA+ABQBKPaa4UDAOWQQAHpBAiGyANYQAnpQwaJg4uBYQ6BDgDnAAtnTIDgA0CmAu9MahANoOALrWuqbIIACuADZl4jJKKhBqmtpGIWZW5gDk1BBtKW1tluKKyqrqWiJNJmGtbXyUfexAA) fails **Related Issues:** <!-- Did you find other bugs that looked similar? --> Not found My [StackOverflow question](https://stackoverflow.com/questions/62884329/typescript-method-overloads) Rationale for the pattern: semi-dynamic event management engine. [Example](https://www.typescriptlang.org/play/#code/MYGwhgzhAEASD28DWEA8AVAsmADtApgB4Au+AdgCYwBK+w8AThahMQwJZkDmANNGGQCeAPmHQA3tACwAKGjzoEAK4AjCMA4r8qANIES5KtCT5B8AGbQsuYQAp8AN3LEAcmAC2+AFzQdfYGAgICpgwEg+tvRkpCQ+1jgA2joAugCU0AC8Yg7w7BTpkgC+sgrQFOwQOGDEwAAWuvqklDAmZpbxdo7Obp4+ftBRMcRx2IkpBdDFMlOynKQM5qH40JiCAKJO0TDiJQog8GAUAMrEYAzD0Dl5u-L7hwBiYOwgPpL4DAyMmPhQYFzeijYnC4kxu0DuFDWlFeZWqYB8AEEPmBBAAhJTmczvUHTWSyKKsaC1TLQMj4ADucEQKFQqw2zggdlSeJktQAdMo1Bp2FpbAByCEnM7EPl8WzpLISSapADcsnZnPUmnw-IhUIoougtjAErEkgJ8BA+DZ+y42rZFDh6UKspZ7PKlWqdVVB2Op3OfNtrItFSqNVqLsO6s1kktpx8ZMpSIYKPRmPetgAjAAmADM1q9sgA9FnoPAyABaCj4dwCCiNQzQObvRbAZYWAibYgQWbRGtLFbrJvbMECdil4jsfNC84wwe9UlKdxaBh8HCfHA+Vgcbh8ByBJQApRkJBkeDksg40p9gdDsjqsf9gFkKczucLpdA1eXDdbnd7g84mbexXc3l8k9qjPEcRTFHVMj1AZ8wgQ1jVNc153gHA+DANl1xATcMzlH9VCVHkVQAsh+yA-NgzA3UpQNI0TXgM1UPHfAsNkIA)
Bug
low
Critical
656,776,467
flutter
[Flutter Web] shows blank page, no errors in chrome console and flutter console
I am new to flutter web. I am using the default counter program. But, I get blank page in chrome and there are no errors in chrome console and flutter console. ## Logs ### flutter run -d chrome: ``` Launching lib\main.dart on Chrome in debug mode... Syncing files to device Chrome... 16,903ms (!) ### flutter run -d chrome -v [ +219 ms] executing: [E:\Softwares\flutter/] git -c log.showSignature=false log -n 1 --pretty=format:%H [ +147 ms] Exit code 0 from: git -c log.showSignature=false log -n 1 --pretty=format:%H [ +1 ms] ce55e42f2b6d1f174a4e6326bb19d4af971301be [ +1 ms] executing: [E:\Softwares\flutter/] git tag --contains HEAD [ +312 ms] Exit code 0 from: git tag --contains HEAD [ +3 ms] executing: [E:\Softwares\flutter/] git describe --match *.*.*-*.*.pre --first-parent --long --tags [ +98 ms] Exit code 0 from: git describe --match *.*.*-*.*.pre --first-parent --long --tags [ +1 ms] 1.20.0-7.0.pre-80-gce55e42f2 [ +13 ms] executing: [E:\Softwares\flutter/] git rev-parse --abbrev-ref --symbolic @{u} [ +115 ms] Exit code 0 from: git rev-parse --abbrev-ref --symbolic @{u} [ +1 ms] origin/master [ +1 ms] executing: [E:\Softwares\flutter/] git ls-remote --get-url origin [ +81 ms] Exit code 0 from: git ls-remote --get-url origin [ +1 ms] https://github.com/flutter/flutter.git [ +490 ms] executing: [E:\Softwares\flutter/] git rev-parse --abbrev-ref HEAD [ +84 ms] Exit code 0 from: git rev-parse --abbrev-ref HEAD [ +1 ms] master [ +118 ms] Artifact Instance of 'AndroidMavenArtifacts' is not required, skipping update. [ +1 ms] Artifact Instance of 'AndroidGenSnapshotArtifacts' is not required, skipping update. [ ] Artifact Instance of 'AndroidInternalBuildArtifacts' is not required, skipping update. [ +1 ms] Artifact Instance of 'IOSEngineArtifacts' is not required, skipping update. [ ] Artifact Instance of 'FlutterWebSdk' is not required, skipping update. [ +7 ms] Artifact Instance of 'WindowsEngineArtifacts' is not required, skipping update. [ +27 ms] Artifact Instance of 'MacOSEngineArtifacts' is not required, skipping update. [ +1 ms] Artifact Instance of 'LinuxEngineArtifacts' is not required, skipping update. [ ] Artifact Instance of 'LinuxFuchsiaSDKArtifacts' is not required, skipping update. [ +31 ms] Artifact Instance of 'MacOSFuchsiaSDKArtifacts' is not required, skipping update. [ ] Artifact Instance of 'FlutterRunnerSDKArtifacts' is not required, skipping update. [ ] Artifact Instance of 'FlutterRunnerDebugSymbols' is not required, skipping update. [ +48 ms] executing: E:\Softwares\sdk\platform-tools\adb.exe devices -l [ +149 ms] List of devices attached [ +11 ms] Artifact Instance of 'AndroidMavenArtifacts' is not required, skipping update. [ +9 ms] Artifact Instance of 'AndroidGenSnapshotArtifacts' is not required, skipping update. [ +2 ms] Artifact Instance of 'AndroidInternalBuildArtifacts' is not required, skipping update. [ +22 ms] Artifact Instance of 'IOSEngineArtifacts' is not required, skipping update. [ +5 ms] Artifact Instance of 'WindowsEngineArtifacts' is not required, skipping update. [ ] Artifact Instance of 'MacOSEngineArtifacts' is not required, skipping update. [ ] Artifact Instance of 'LinuxEngineArtifacts' is not required, skipping update. [ ] Artifact Instance of 'LinuxFuchsiaSDKArtifacts' is not required, skipping update. [ ] Artifact Instance of 'MacOSFuchsiaSDKArtifacts' is not required, skipping update. [ ] Artifact Instance of 'FlutterRunnerSDKArtifacts' is not required, skipping update. [ ] Artifact Instance of 'FlutterRunnerDebugSymbols' is not required, skipping update. [+2018 ms] Generating E:\Personal_Project\attempt\android\app\src\main\java\io\flutter\plugins\GeneratedPluginRegistrant.java [ +208 ms] Launching lib\main.dart on Chrome in debug mode... [ +222 ms] Updating assets [+4835 ms] Syncing files to device Chrome... [ +152 ms] Generating E:\Personal_Project\attempt\android\app\src\main\java\io\flutter\plugins\GeneratedPluginRegistrant.java [ +99 ms] <- reset [ +12 ms] E:\Softwares\flutter\bin\cache\dart-sdk\bin\dart.exe --disable-dart-dev E:\Softwares\flutter\bin\cache\artifacts\engine\windows-x64\frontend_server.dart.snapshot --sdk-root E:\Softwares\flutter\bin\cache\flutter_web_sdk/ --incremental --target=dartdevc --debugger-module-names --experimental-emit-debug-metadata -Ddart.developer.causal_async_stacks=true --output-dill C:\Users\Arjun\AppData\Local\Temp\flutter_tools.291f60d8\flutter_tool.8885aaa0\app.dill --libraries-spec file:///E:/Softwares/flutter/bin/cache/flutter_web_sdk/libraries.json --packages .packages -Ddart.vm.profile=false -Ddart.vm.product=false --bytecode-options=source-positions,local-var-info,debugger-stops,instance-field-initializers,keep-unreachable-code,avoid-closure-call-instructions --enable-asserts --track-widget-creation --filesystem-root C:\Users\Arjun\AppData\Local\Temp\flutter_tools.291f60d8\flutter_tools.945f70a3 --filesystem-scheme org-dartlang-app --initialize-from-dill build\cache.dill.track.dill --platform file:///E:/Softwares/flutter/bin/cache/flutter_web_sdk/kernel/flutter_ddc_sdk.dill [ +58 ms] <- compile org-dartlang-app:/web_entrypoint.dart [+31558 ms] Syncing files to device Chrome... (completed in 31,867ms, longer than expected) [ +1 ms] Synced 23.7MB. [ +1 ms] <- accept [ +1 ms] Caching compiled dill [+4734 ms] [CHROME]: [ +2 ms] [CHROME]:DevTools listening on ws://127.0.0.1:57598/devtools/browser/5f326541-6e8b-445d-91e2-31c872b346f2 ``` ### flutter doctor -v ``` [√] Flutter (Channel master, 1.20.0-8.0.pre.80, on Microsoft Windows [Version 10.0.18362.900], locale en-IN) β€’ Flutter version 1.20.0-8.0.pre.80 at E:\Softwares\flutter β€’ Framework revision ce55e42f2b (5 hours ago), 2020-07-14 07:40:29 -0400 β€’ Engine revision 1e23309a38 β€’ Dart version 2.9.0 (build 2.9.0-21.0.dev f997d62a6d) [√] Android toolchain - develop for Android devices (Android SDK version 30.0.1) β€’ Android SDK at E:\Softwares\sdk β€’ Platform android-30, build-tools 30.0.1 β€’ ANDROID_HOME = E:\Softwares\sdk β€’ Java binary at: E:\Softwares\Android\jre\bin\java β€’ Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01) β€’ All Android licenses accepted. [√] Chrome - develop for the web β€’ Chrome at C:\Program Files (x86)\Google\Chrome\Application\chrome.exe [√] Android Studio (version 4.0) β€’ Android Studio at E:\Softwares\Android β€’ Flutter plugin version 47.1.2 β€’ Dart plugin version 193.7361 β€’ Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01) [√] Connected device (3 available) β€’ Web Server (web) β€’ web-server β€’ web-javascript β€’ Flutter Tools β€’ Chrome (web) β€’ chrome β€’ web-javascript β€’ Google Chrome 83.0.4103.116 β€’ Edge (web) β€’ edge β€’ web-javascript β€’ Microsoft Edge 83.0.478.61 ``` Please see the issue and reply ASAP.....
c: regression,engine,platform-windows,a: first hour,a: debugging,platform-web,P2,team-web,triaged-web
low
Critical
656,782,988
pytorch
[jit] `set` builtin support
We support `List` and `Dict`, we should support `Set` as well. This is a low-pri request from PyPER. cc @suo @gmagogsfm
oncall: jit,weeks,TSUsability,TSRootCause:UnsupportedConstructs
low
Minor