id
int64
393k
2.82B
repo
stringclasses
68 values
title
stringlengths
1
936
body
stringlengths
0
256k
labels
stringlengths
2
508
priority
stringclasses
3 values
severity
stringclasses
3 values
647,340,040
PowerToys
Date in minimized traybar
Show the date in the traybar when the taskbar is minimized. Idea: stack it horizontally instead of vertically Minimized ![image](https://user-images.githubusercontent.com/4655466/86006277-04280580-ba16-11ea-8fd4-8f282fe4a583.png) Default ![image](https://user-images.githubusercontent.com/4655466/86006217-f1adcc00-ba15-11ea-9fcd-375809d771a5.png)
Idea-New PowerToy,Product-Tweak UI Design
low
Major
647,402,602
go
cmd/compile: create cheapdeadcode
There are a number of places in the SSA pipeline where it would produce better code if we could run deadcode. However, deadcode is expensive. I suspect we could create a cheaper, only slightly less effective version of deadcode: * Instead of building a full value liveness graph, eliminate only values that have v.Uses == 0. * Continue eliminating dead blocks. One complication is line number handling, which currently depends on an ordering map which is created while building the full value liveness graph. I am not sure how best to address this; I find the existing code confusing. Perhaps @dr2chase has ideas. We could use it in more places; we could probably also replace many uses of the full deadcode pass with it. I suspect this would end up improving both compiled code quality and compiler performance. This is a reminder issue to investigate this. It's probably not a good introduction to the compiler, but help is definitely welcome!
Performance,ToolSpeed,NeedsInvestigation,compiler/runtime
low
Major
647,433,651
godot
Issue on (AMD?) Mac when you use a viewport as panorama sky (GLES3)
**Godot version:** tested on 3.1/3.2 **OS/device including version:** Mac OS Catalina with Radeon Pro 560X : Bug Mac OS Catalina HD5000 : OK **Issue description:** The following project works on mac (igpu)/ windows / linux. However on mac with amd GPU, there is an ambiant green light ![Greenbug](https://i.ibb.co/K7gmnvv/issue-mac.jpg) **Minimal reproduction project:** [GreenIssue.zip](https://github.com/godotengine/godot/files/4846165/GreenIssue.zip) **Update** I wasn't able to reproduce the bug on mac IGPU on a minimal project. However, in my game, I just noticed I have a similar problem on igpu mac. I don't know why it not happens on the minimal project. This time, when you use the viewport as a panorama, you don't have a green light, but black everywhere. I think the problem is affecting all Macs. ![Igpu mac](https://i.ibb.co/Bgpg2Y0/Capture-d-e-cran-2020-06-29-a-17-15-33.png)
bug,platform:macos,topic:rendering
low
Critical
647,486,221
PowerToys
[Run] Option to change/remember the search window location/position
# I would like to be able to change the position of PowerToys Run search window I think a search function in the middle of the screen is never a good idea. The user should be able to freely access the desktop while searching. The feature I would add, would allow the user to pick a permanent location on their screen for the search window to appear. Giving the user more customization. --> # Simply using the same mechanic used with custom FancyZone selection would suffice. In the powerToys settings under 'PowerToys Run' the user can click a 'Customize search bar location' button. When clicked they can move a grey box representing the search bar to any position on the desktop. -->
Idea-Enhancement,Help Wanted,Product-PowerToys Run,Area-User Interface,Priority-3,Planning-Consideration
medium
Major
647,500,888
godot
Custom resource properties disappears from resource inspector after moving and editing source file
**Godot version:** 3.2.1-3.2.2 **OS/device including version:** MacOS Mojave **Issue description:** Custom resource properties disappear from resource inspector after moving and editing source file **Steps to reproduce:** 1. Create a folder structure, like this "folder_1/folder_2", in the root of the project 2. In folder_1 make new some_resource.gd file with contents: ``` gdscript class_name SomeResource extends Resource export (float) var test_1 export (int) var test_2 ``` 3. make a new resource of type SomeResource in the same folder, export variables should be seen in resource inspector 4. close some_resource.gd file 5. move some_resource.gd file to folder_1/folder_2 6. edit some_resource.gd, delete ``` export (int) var test_2 ``` 7. export variables should disappear from resource inspector **Minimal reproduction project:** [DELETE.zip](https://github.com/godotengine/godot/files/4846610/DELETE.zip)
bug,topic:editor
low
Minor
647,530,783
vscode
Stuck while trying to install plugins in WSL using corporate proxy
<!-- ⚠️⚠️ Do Not Delete This! bug_report_template ⚠️⚠️ --> <!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ --> <!-- Please search existing issues to avoid creating duplicates. --> <!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: https://code.visualstudio.com/insiders/ --> <!-- Use Help > Report Issue to prefill these. --> - VSCode Version: 1.46.1 - OS Version: Win10 2004 - Tried both using WSL1 and WSL2, both running Ubuntu 20.04 I'm running code behind a corporate network, have http_proxy and https_proxy (on both Windows and WSL set to the respective proxy server. Internet access is both working for Windows (and plugin install, too) and from WSL side (except the code plugin installation. Maybe I missed the instructions on how to operate visual studio code with WSL + proxy? Steps to Reproduce: 1. Open vscode from WSL: `code .` 2. Try installing any of the already installed plugins into WSL, e.g. git lens 3. After clicking the button labelled 'Install in WSL: &lt;wsl name&gt;' mostly nothing happens. Sometimes the button text changes to 'Installing' for some time - however it will be then stuck there. There's no progress or error message in any case. I checked the local and remote extensions host log, too - with trace enabled: For WSL1 the following entries could be found in the log: ```txt [2020-06-29 18:25:53.882] [remoteagent] [trace] ExtensionManagementService.refreshReportedCache [2020-06-29 18:25:53.882] [remoteagent] [trace] RequestService#request https://az764295.vo.msecnd.net/extensions/marketplace.json [2020-06-29 18:26:29.562] [remoteagent] [trace] Started scanning system extensions [2020-06-29 18:26:29.562] [remoteagent] [trace] Started scanning user extensions [2020-06-29 18:26:29.564] [remoteagent] [trace] Scanned user extensions: 0 [2020-06-29 18:26:29.611] [remoteagent] [trace] {"errno":-2,"code":"ENOENT","syscall":"open","path":"/home/fooUser/.vscode-server/bin/cd9ea6488829f560dc949a8b2fb789f3cdc05f5d/extensions/node_modules/package.json"} ``` For WSL2 the same looked like: ```txt [2020-06-29 18:24:31.296] [remoteagent] [trace] {"errno":-2,"code":"ENOENT","syscall":"open","path":"/root/.vscode-server/bin/cd9ea6488829f560dc949a8b2fb789f3cdc05f5d/extensions/node_modules/package.json"} [2020-06-29 18:24:31.300] [remoteagent] [trace] Scanned system extensions: 30 [2020-06-29 18:24:43.700] [remoteagent] [trace] ExtensionManagementService.refreshReportedCache [2020-06-29 18:24:43.701] [remoteagent] [trace] RequestService#request https://az764295.vo.msecnd.net/extensions/marketplace.json [2020-06-29 18:29:13.672] [remoteagent] [trace] Started scanning user extensions [2020-06-29 18:29:13.673] [remoteagent] [trace] Scanned user extensions: 0 [2020-06-29 18:31:04.845] [remoteagent] [trace] Started scanning system extensions ``` I checked the trace log after starting code using `--log=trace` - there seem to be some errors during the plugin discovery - however I'm not sure. I attached a slightly modified version (replaced my user name - and left only the tail of the log) of the log. [sharedprocess.log](https://github.com/microsoft/vscode/files/4846713/sharedprocess.log) <!-- Launch with `code --disable-extensions` to check. --> Does this issue occur when all extensions are disabled?: n/a
bug,proxy,remote
medium
Critical
647,536,217
godot
Crash on freed reference trying to emit "completed" signal
**Godot version:** 3.2.2 **OS/device including version:** macOS 10.14.6 **Issue description:** I'm seeing a crash that appears to be related to an invalid reference to a GDScriptFunctionState trying to emit a "completed" signal. I've got a long-running recursive function that I'm trying get to run across frames. Here's the basic setup. Basically I call a function to kick it off and store the continuation: ```gdscript func start_expensive_calculation(): _frame_start = OS.get_ticks_usec() _continuation = expensive_function(rootNode) ``` Then the expensive function itself: ```gdscript func expensive_function(treeNode): # frameBudget = 10000 if OS.get_ticks_usec() - _frame_start > frameBudget: yield() if treeNode._child: var child_run = expensive_function(treeNode._child) while child_run is GDScriptFunctionState: yield() child_run = child_run.resume() do_expensive_calculation() ``` Then every frame while it's still running, I resume it. ```gdscript func _process(_delta: float): if _continuation: _frame_start = OS.get_ticks_usec() _continuation = _continuation.resume() ``` All of this works fine in [a little toy project I made](https://github.com/sjml/godot_continuation), but in my larger scale project where the function is actually doing meaningful work, there are occasional crashes. (They go away if I make the frame budget check always return true, so it's definitely related to how I'm doing the continuation.) The macOS crash reporter was pointing to EXC\_BAD\_ACCESS in `Object::emit_signal(StringName const&, Variant const**, int)`. Running a debug version of Godot, I found that the signal it's trying to emit is `"completed"`, but it can't find it because the `hash_table` member of the reference's `signal_map` is trashed. ([The engine code checks that it's not null](https://github.com/godotengine/godot/blob/3.2/core/hash_map.h#L315), but since it *is* pointing to something, it [tries to access it](https://github.com/godotengine/godot/blob/3.2/core/hash_map.h#L186) and then fails.) I'm guessing something about the way I'm calling resume and then storing the result back into the original variable is leading to the `GDScriptFunctionState` getting cleaned up before it can emit its signal, but the emitting code doesn't know that it's now getting called on garbage data. I don't know if the engine code needs to add a check here, or if I should be more careful in my GDSCript usage -- is there a better approach to setting up a continuation of a recursive function? **Steps to reproduce:** I haven't been able to figure out exactly what conditions trigger it. I happens in web exports almost immediately, but on the macOS native build it seems a bit more random. (The whole process will run fine anywhere between 5-20 times, then crash on the next attempt.) **Minimal reproduction project:** Attached. On my mac, it crashes about 2/3 of the time when run from the editor. On a web export, it crashes almost immediately 100% of the time in Firefox. (And usually after a single refresh in Chrome.) As I said, I'm very willing to admit that I'm doing something wrong here, but it should still be tough to crash the engine just using (even abusing) GDScript. [CrashOnEmit.zip](https://github.com/godotengine/godot/files/4852824/CrashOnEmit.zip)
bug,topic:gdscript,confirmed,crash
low
Critical
647,560,961
electron
Add click event to BrowserWindow
### Preflight Checklist * [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project. * [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to. * [x] I have searched the issue tracker for a feature request that matches the one I want to file, without success. ### Problem Description I want to be able to intercept click events for a `BrowserWindow` (or `WebContents`), so that I can prevent a timeout. The page in my app checks for activities, but this doesn't work for cross-domain iframes (the `'click'` event won't bubble out of the iframe), so I want to detect this at the window level. This will also allow me to intercept clicks on the titlebar and shell of the window. ### Proposed Solution Add `'click'` event for the `BrowserWindow` or `WebContents` that detects all types of clicks (left, middle, right clicks on the entire window) ### Alternatives Considered Otherwise, I have to hook each Windows message that I care about and handle this myself: ``` win.hookWindowMessage(0x0202, () => { preventTimeout(); return 0; }); ```
enhancement :sparkles:,component/BrowserWindow
low
Minor
647,574,304
flutter
Flutter Analyzer crashes multiples times when running medium/large apps
Okay, Flutter Analyzer most likely doesn't crash at all if my app scale is small. When my app scales up to medium, it begins crashing several times (5-10 times a day), every restart takes 1-2 mins. I'm basically can't do anything while it restarting. Can we make this a top priority issue? Cause it really slows down dev time, a lot?
c: crash,tool,dependency: dart,P2,team-tool,triaged-tool
low
Critical
647,580,086
flutter
Investigate using SIMD to improve performance of common Matrix operations
## Background SIMD (Single Instruction Multiple Data) works by providing specialized instructions for large 128 bit (or more) registers that provide the potential for greater parallelism. For example, the current matrix equality code in Flutter is roughly: ```dart return a.storage[0] == b.storage[0] && a.storage[1] == b.storage[1] && a.storage[2] == b.storage[2] && a.storage[3] == b.storage[3] && a.storage[4] == b.storage[4] && a.storage[5] == b.storage[5] && a.storage[6] == b.storage[6] && a.storage[7] == b.storage[7] && a.storage[8] == b.storage[8] && a.storage[9] == b.storage[9] && a.storage[10] == b.storage[10] && a.storage[11] == b.storage[11] && a.storage[12] == b.storage[12] && a.storage[13] == b.storage[13] && a.storage[14] == b.storage[14] && a.storage[15] == b.storage[15]; ``` Simplifying a bit, with a 4x4 matrix we need to perform 16 comparisons. With SIMD, many of these comparisons can be run at the same time. Given a matrix where the columns are represented by the [`Float32x4`](https://api.flutter.dev/flutter/dart-typed_data/Float32x4-class.html) type, it can instead be written like: ```dart Int32x4 col0Equals = column0.equal(other.column0); Int32x4 col1Equals = column1.equal(other.column1); Int32x4 col2Equals = column2.equal(other.column2); Int32x4 col3Equals = column3.equal(other.column3); Int32x4 temp = col0Equals & col1Equals & col2Equals & col3Equals; return temp.signMask == 15; ``` While 16 comparisons are still performed, these are now done 4 at a time. Generally, performing a SIMD operation in Dart should be about 3x faster than the equivalent scalar code. While SIMD was never adopted in JavaScript*, Flutter applications on mobile/desktop could take advantage of it. The most obvious cases in Flutter are the matrix operations required during layout, transforms, semantics, and hit testing. Beyond matrix operations, SIMD has been applied to a number of other domains such as parsing/deserialization, like [simdjson](https://github.com/simdjson/simdjson). * _Though WASM might:_ https://v8.dev/features/simd ## Overview I implemented several of the most common operations in flutter using SIMD types and compared them to their vector_math equivalents: matrix multiplication, inversion, matrix equality, and point transformation. I then measured the performance using the benchmark scripts in https://github.com/jonahwilliams/flutter/commit/77475d6495b1eeee48db679152299caf861b2d57 ### Pixel 4 (arm64) Results Inversion: SIMD 47% faster than vector math. Multiplication: SIMD 350% faster than vector math. Equality: SIMD 2600 % slower than vector math. Transform Point: SIMD 13% faster than vector math ### macOS (x86_64) Results Inversion: SIMD 21% slower than vector math (250% faster than vector math - implementation 2). Multiplication: SIMD 350% faster than vector math. Equality: SIMD 74 % faster than vector math. Transform Point: SIMD identical to vector math The slower inversion code on x86_64 is due to using an ARM focused implementation. A separate investigation which ported the inversion code from the [TC39 SIMD benchmark](https://github.com/tc39/ecmascript_simd/blob/master/src/benchmarks/inverse4x4.js) found it was 2.5X faster than vector_math. The extreme slowdown in equality checks on ARM devices is due to an [inefficient emulation](https://github.com/dart-lang/sdk/issues/41950) of signMask in Dart. ## Next Steps A larger investigation would be required to determine how significant any performance improvements would be at a macro level, or whether the existing use of Matrix4 types could be changed with a breaking change process. Converting Matrix4 types to SIMD on the fly might have overhead that outweighs any performance gained. The loss of precision might also impact rendering in unknown ways. This investigation would be constrained to desktop devices unless https://github.com/dart-lang/sdk/issues/41950 was also fixed. ## Resources The diff https://github.com/flutter/flutter/compare/master...jonahwilliams:simd_integration contains implementations of the matrix operations above as well as the benchmark. NN: There are separate Intel and ARM matrix inversion algorithms that must be used for performance reasons. _Originally investigated via go/simd-in-flutter, this document is not available widely so the full text has been transported here_.
framework,c: performance,perf: speed,P3,team-framework,triaged-framework
low
Major
647,592,163
flutter
Flutter Logo typeface is not on-brand
The text [is rendered in Roboto](https://github.com/flutter/flutter/blob/4d7525f05c05a6df0b29396bc9eb78c3bf1e9f89/packages/flutter/lib/src/painting/flutter_logo.dart#L268), yet this font is unavailable on certain platforms and is not the Product Sans font that is specified for the logotype. I took a few screenshots: FlutterLogo widget on iPhone (looks like font fallback to San Francisco, colors wrong) ![image](https://user-images.githubusercontent.com/2319867/86043948-40e80280-b9fe-11ea-9941-045db32297c6.png) FlutterLogo widget on web (looks like font is Roboto, colors wrong): ![image](https://user-images.githubusercontent.com/2319867/86044021-5ceba400-b9fe-11ea-9664-6ffb2db31b3c.png) Flutter logo in go/flutter-logo: ![image](https://user-images.githubusercontent.com/2319867/86044088-77258200-b9fe-11ea-90e5-4864eac09844.png) I think we need to convert it to vector art, rather than use random fonts that may or may not be present on a given device. Also see https://github.com/flutter/flutter/issues/16713, which addresses a separate issue relating to the color of the 'F' marque.
framework,a: quality,has reproducible steps,P2,found in release: 3.3,found in release: 3.6,team-framework,triaged-framework
low
Minor
647,621,271
godot
Graph node and mouse wheel scroll.
**Godot version:** 3.* **OS/device including version:** Any? **Issue description:** Graph node in visual script and shader script... ![image](https://user-images.githubusercontent.com/22836285/86048299-f6e03a80-ba58-11ea-90ff-319679551a23.png) if grab it and start move to another position, and scroll (GraphEdit) with mouse wheel... problem with offset. Graph node not change position to mouse position when scroll (vertical and horizontal with "Shift+ mouse wheel"). **Steps to reproduce:** Start move graph node and scroll with mouse. P.S. small proposal: maybe add feature - when move it to corners, then starting scroll. it improve usability.
bug,topic:gui
low
Minor
647,634,526
flutter
bug(FlexibleSpaceBar): titlePadding incorrect on iPhone 11 in landscape
<!-- Thank you for using Flutter! If you are looking for support, please check out our documentation or consider asking a question on Stack Overflow: * https://flutter.dev/ * https://api.flutter.dev/ * https://stackoverflow.com/questions/tagged/flutter?sort=frequent If you have found a bug or if our documentation doesn't have an answer to what you're looking for, then fill our the template below. Please read our guide to filing a bug first: https://flutter.dev/docs/resources/bug-reports --> ## Steps to Reproduce <!-- You must include full steps to reproduce so that we can reproduce the problem. --> 1. Run `flutter create bug`. 2. Update the files as follows: ```dart static const double _appBarHeight = 256.0; ... SliverAppBar( expandedHeight: _appBarHeight, pinned: true, flexibleSpace: FlexibleSpaceBar( title: Text('name'), centerTitle: false, ), ), ``` **Expected results:** <!-- what did you want to see? --> Title shouldn't overlap the back button. Ideally, only landscape mode on devices with the camera bump would add extra padding. **Actual results:** <!-- what did you see? --> Title is overlaps the back button. Portrait is fine, but landscape doesn't account for the extra padding due to the iPhone's camera bump: ![IMG_0535](https://user-images.githubusercontent.com/6323077/86045073-09d31a80-ba19-11ea-9aa1-f2543bc4db8a.jpg) Portrait, for comparison: ![IMG_0536](https://user-images.githubusercontent.com/6323077/86045068-093a8400-ba19-11ea-932c-554b256035c2.jpg) <details> <summary>Logs</summary> <!-- Run your application with `flutter run --verbose` and attach all the log output below between the lines with the backticks. If there is an exception, please see if the error message includes enough information to explain how to solve the issue. --> ``` ``` <!-- Run `flutter analyze` and attach any output of that command below. If there are any analysis errors, try resolving them before filing this issue. --> ``` ``` <!-- Finally, paste the output of running `flutter doctor -v` here. --> ``` chris@Shem tipr % flutter doctor -v [✓] Flutter (Channel stable, v1.17.4, on Mac OS X 10.15.5 19F101, locale en-US) • Flutter version 1.17.4 at /Users/chris/dev/flutter • Framework revision 1ad9baa8b9 (12 days ago), 2020-06-17 14:41:16 -0700 • Engine revision ee76268252 • Dart version 2.8.4 [!] Android toolchain - develop for Android devices (Android SDK version 29.0.3) • Android SDK at /Users/chris/Library/Android/sdk • Platform android-29, build-tools 29.0.3 • Java binary at: /Users/chris/Library/Application Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/193.6514223/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593) ! Some Android licenses not accepted. To resolve this, run: flutter doctor --android-licenses [✓] Xcode - develop for iOS and macOS (Xcode 11.5) • Xcode at /Applications/Xcode.app/Contents/Developer • Xcode 11.5, Build version 11E608c • CocoaPods version 1.9.3 [✓] Android Studio (version 4.0) • Android Studio at /Users/chris/Library/Application Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/193.6514223/Android Studio.app/Contents • Flutter plugin version 46.0.2 • Dart plugin version 193.7361 • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593) [!] IntelliJ IDEA Ultimate Edition (version 2020.1.2) • IntelliJ at /Users/chris/Applications/JetBrains Toolbox/IntelliJ IDEA Ultimate.app ✗ Flutter plugin not installed; this adds Flutter specific functionality. ✗ Dart plugin not installed; this adds Dart specific functionality. • For information about installing plugins, see https://flutter.dev/intellij-setup/#installing-the-plugins [✓] VS Code (version 1.46.1) • VS Code at /Applications/Visual Studio Code.app/Contents • Flutter extension version 3.12.0 [✓] Connected device (1 available) • Eli • 00008030-001E2D343CA2802E • ios • iOS 13.5.1 ! Doctor found issues in 2 categories. ``` </details>
platform-ios,framework,f: material design,has reproducible steps,P3,found in release: 3.0,found in release: 3.1,workaround available,team-design,triaged-design
low
Critical
647,649,775
flutter
Performance and Crashing with InteractiveViewer Widget on flutter web/mobile web.
@justinmc would you mind taking a look at scale and pan performance on web / mobile web, especially when text is used? May even be an opportunity for a test/benchmark. I used statsfl (https://pub.dev/packages/statsfl) (to easily benchmark across mobile and desktop web browsers), your above column/row example, and added an appbar to increase the row/column count and disable/enable text. On chrome mobile, LG G7 ThinQ, issues are immediately apparent with text enabled and a crash can instantly be induced by scaling. FPS issues with scroll and scale start around 75x75 if text is disabled, jank is severe around 150x150, and crash prone around 300x300. On chrome with my decently specced PC, an FPS drop can be seen immediately when scrolling with text enable, but scaling can maintain 60fps. At 10x10 scaling performance is impacted, severe at 20x20, and crash prone on anything above 30x30. Without text performance issues start at 20x20, but the issue does not become severe until over 100x100. ## Steps to Reproduce Click/tap the buttons on the app bar to increase the column/row count, disable/enable text, or disable/enable color. `pubspec` add for easy fps ` statsfl: ^1.0.0+2` `main` ``` import 'package:flutter/material.dart'; import 'package:statsfl/statsfl.dart'; void main() { runApp(MyApp()); } class MyApp extends StatelessWidget { // This widget is the root of your application. @override Widget build(BuildContext context) { return MaterialApp( title: 'Flutter Demo', theme: ThemeData( // This is the theme of your application. // // Try running your application with "flutter run". You'll see the // application has a blue toolbar. Then, without quitting the app, try // changing the primarySwatch below to Colors.green and then invoke // "hot reload" (press "r" in the console where you ran "flutter run", // or simply save your changes to "hot reload" in a Flutter IDE). // Notice that the counter didn't reset back to zero; the application // is not restarted. primarySwatch: Colors.blue, // This makes the visual density adapt to the platform that you run // the app on. For desktop platforms, the controls will be smaller and // closer together (more dense) than on mobile platforms. visualDensity: VisualDensity.adaptivePlatformDensity, ), home: StatsFl( isEnabled: true, child: MyHomePage(title: 'Flutter Demo Home Page'), )); } } class MyHomePage extends StatefulWidget { MyHomePage({Key key, this.title}) : super(key: key); // This widget is the home page of your application. It is stateful, meaning // that it has a State object (defined below) that contains fields that affect // how it looks. // This class is the configuration for the state. It holds the values (in this // case the title) provided by the parent (in this case the App widget) and // used by the build method of the State. Fields in a Widget subclass are // always marked "final". final String title; @override _MyHomePageState createState() => _MyHomePageState(); } class _MyHomePageState extends State<MyHomePage> { int _rowCount = 5; int _columnCount = 5; bool _text = true; bool _color = true; @override Widget build(BuildContext context) { // This method is rerun every time setState is called, for instance as done // by the _incrementCounter method above. // // The Flutter framework has been optimized to make rerunning build methods // fast, so that you can just rebuild anything that needs updating rather // than having to individually change instances of widgets. return Scaffold( appBar: AppBar( title: Text("Column: $_columnCount\nRow: $_rowCount"), actions: [ IconButton( icon: Icon(Icons.add), onPressed: () { setState(() { _rowCount += 5; _columnCount += 5; }); }), IconButton( icon: Icon(Icons.format_paint), onPressed: () { setState(() { _color = !_color; }); }), IconButton( icon: Icon(Icons.text_fields), onPressed: () { setState(() { _text = !_text; }); }) ], ), body: InteractiveViewer( scaleEnabled: true, panEnabled: true, constrained: false, child: Table( columnWidths: <int, TableColumnWidth>{ for (int column = 0; column < _columnCount; column++) column: const FixedColumnWidth(300.0), }, children: <TableRow>[ for (int row = 0; row < _rowCount; row++) TableRow( children: <Widget>[ for (int column = 0; column < _columnCount; column++) Container( child: _text ? Text("Column: $_columnCount\nRow: $_rowCount") : null, height: 100, color: _color ? row % 2 + column % 2 == 1 ? Colors.red.withOpacity(0.5) : Colors.green.withOpacity(0.5) : null), ], ), ], )), // This trailing comma makes auto-formatting nicer for build methods. ); } } ``` ``` Doctor found issues in 1 category. [√] Flutter (Channel master, 1.20.0-1.0.pre.90, on Microsoft Windows [Version 10.0.17758.4], locale en-US) • Flutter version 1.20.0-1.0.pre.90 at C:\src\flutter • Framework revision 42e02d60d3 (23 hours ago), 2020-06-17 10:57:40 -0700 • Engine revision 965fbbed17 • Dart version 2.9.0 (build 2.9.0-14.0.dev 2b917f5b6a) [!] Android toolchain - develop for Android devices (Android SDK version 29.0.1) • Android SDK at C:\Users\Miche\AppData\Local\Android\sdk • Platform android-29, build-tools 29.0.1 • Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01) X Android license status unknown. Try re-installing or updating your Android SDK Manager. See https://developer.android.com/studio/#downloads or visit https://flutter.dev/docs/get-started/install/windows#android-setup for detailed instructions. [√] Chrome - develop for the web • Chrome at C:\Program Files (x86)\Google\Chrome\Application\chrome.exe [√] Android Studio (version 4.0) • Android Studio at C:\Program Files\Android\Android Studio • Flutter plugin version 46.0.2 • Dart plugin version 193.7361 • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01) [√] VS Code (version 1.46.0) • VS Code at C:\Users\Miche\AppData\Local\Programs\Microsoft VS Code • Flutter extension version 3.11.0 [√] Connected device (2 available) • Web Server • web-server • web-javascript • Flutter Tools • Chrome • chrome • web-javascript • Google Chrome 83.0.4103.106 ``` edit: added counts to title
c: crash,engine,c: performance,platform-web,has reproducible steps,P2,found in release: 3.7,found in release: 3.9,team-web,triaged-web
low
Critical
647,669,756
TypeScript
Allow to find references of the actual type
I feel it is impossible with TS to find all calls to a method of a type that is defined in a very generic interface, such as `dispose`: ![image](https://user-images.githubusercontent.com/900690/84394289-08be8280-abfd-11ea-9e3a-777f3613e8f1.png) This makes it basically impossible to find all references of e.g. the `dispose` method of `EditorInput`. Is there something we can do? My current only workaround is to remove all interfaces temporarily so that the `dispose` method does not come in from a generic interface. Maybe the references viewlet could group by type? //cc @jrieken
Suggestion,Needs Proposal
low
Major
647,692,757
pytorch
Custom c++ extension build process doesn't preserve color from compiler
When I work on torchvision I would like to see color from my compiler, but I don't have it. cc @yf225 @glaringlee
module: cpp-extensions,module: cpp,triaged,better-engineering
low
Minor
647,707,453
flutter
Decommission the flutter_tools commands shard
Currently the commands shard is a bit of a hodge-podge, the tests it contains either make use of real commands (invoking flutter re-entrantly, running the analyzer) or they are just _really confused unit tests_ that are non-hermetic (that is, significant functionality is mocked out without being completely hermetic). Any tests that are clearly unit tests should be refactored to actually be hermetic and moved to the general.shard. Any integration tests should be more clearly marked as such and moved to the the integration.shard.
team,tool,P2,team-tool,triaged-tool
low
Minor
647,716,087
pytorch
torch::autograd::Function should set AutoNonVariableTypeMode when running forward
Currently, it does not, which means you cannot write idiomatic redispatch as: ``` static torch::autograd::variable_list forward( torch::autograd::AutogradContext* ctx, torch::autograd::Variable input, torch::autograd::Variable rois, ...) { ctx->saved_data["spatial_scale"] = spatial_scale; ... // at::AutoNonVariableTypeMode g; auto result = roi_align( input, rois, ... ``` You have to add the AutoNonVariableTypeMode guard yourself. This should have been taken care of in Function. cc @ezyang @SsnL @albanD @zou3519 @gqchen
module: autograd,triaged
low
Major
647,766,806
flutter
CupertinoRefreshIndicator needs a pop in animation when it triggers
minor fidelity issues with `CupertinoRefreshIndicator`: native behavior (iOS 13.5, slow-mo), around 7 second mark ![native](https://user-images.githubusercontent.com/31859944/84831507-485fe280-afe0-11ea-8576-d216e106f4d3.gif)
framework,a: fidelity,f: cupertino,P2,team-design,triaged-design
low
Major
647,796,546
pytorch
RuntimeError: rois.device().is_cpu() ASSERT FAILED at /vision/torchvision/csrc/cpu/ROIAlign_cpu.cpp:386
## 🐛 Bug <!-- A clear and concise description of what the bug is. --> ``` /run/media/xxx/works/python/github/mmdetection/mmdet/core/bbox/transforms.py:161: TracerWarning: Converting a tensor to a Python boolean might cause the trace to be incorrect. We can't record the data flow of Python values, so this value will be treated as a constant in the future. This means that the trace might not generalize to other inputs! if bboxes.size(0) > 0: /run/media/xxx/works/python/github/mmdetection/mmdet/core/bbox/transforms.py:162: TracerWarning: new_full is a legacy constructor and is not supported in the JIT. img_inds = bboxes.new_full((bboxes.size(0), 1), img_id) /run/media/xxx/works/python/github/mmdetection/mmdet/models/roi_extractors/single_level.py:98: TracerWarning: new_zeros is a legacy constructor and is not supported in the JIT. rois.size(0), self.out_channels, *out_size) /run/media/xxx/works/python/github/mmdetection/mmdet/models/roi_extractors/single_level.py:103: TracerWarning: Converting a tensor to a Python boolean might cause the trace to be incorrect. We can't record the data flow of Python values, so this value will be treated as a constant in the future. This means that the trace might not generalize to other inputs! if inds.any(): Traceback (most recent call last): File "/run/media/xxx/works/python/github/mmdetection/tools/pytorch2onnx.py", line 123, in <module> main() File "/run/media/xxx/works/python/github/mmdetection/tools/pytorch2onnx.py", line 115, in main onnx_model = export_onnx_model(model, (input_data, ), args.passes) File "/run/media/xxx/works/python/github/mmdetection/tools/pytorch2onnx.py", line 42, in export_onnx_model operator_export_type=OperatorExportTypes.ONNX_ATEN_FALLBACK, File "/home/xxx/anaconda3/envs/cv-env/lib/python3.6/site-packages/torch/onnx/__init__.py", line 25, in export return utils.export(*args, **kwargs) File "/home/xxx/anaconda3/envs/cv-env/lib/python3.6/site-packages/torch/onnx/utils.py", line 131, in export strip_doc_string=strip_doc_string) File "/home/xxx/anaconda3/envs/cv-env/lib/python3.6/site-packages/torch/onnx/utils.py", line 363, in _export _retain_param_name, do_constant_folding) File "/home/xxx/anaconda3/envs/cv-env/lib/python3.6/site-packages/torch/onnx/utils.py", line 266, in _model_to_graph graph, torch_out = _trace_and_get_graph_from_model(model, args, training) File "/home/xxx/anaconda3/envs/cv-env/lib/python3.6/site-packages/torch/onnx/utils.py", line 225, in _trace_and_get_graph_from_model trace, torch_out = torch.jit.get_trace_graph(model, args, _force_outplace=True) File "/home/xxx/anaconda3/envs/cv-env/lib/python3.6/site-packages/torch/jit/__init__.py", line 231, in get_trace_graph return LegacyTracedModule(f, _force_outplace, return_inputs)(*args, **kwargs) File "/home/xxx/anaconda3/envs/cv-env/lib/python3.6/site-packages/torch/nn/modules/module.py", line 493, in __call__ result = self.forward(*input, **kwargs) File "/home/xxx/anaconda3/envs/cv-env/lib/python3.6/site-packages/torch/jit/__init__.py", line 294, in forward out = self.inner(*trace_inputs) File "/home/xxx/anaconda3/envs/cv-env/lib/python3.6/site-packages/torch/nn/modules/module.py", line 491, in __call__ result = self._slow_forward(*input, **kwargs) File "/home/xxx/anaconda3/envs/cv-env/lib/python3.6/site-packages/torch/nn/modules/module.py", line 481, in _slow_forward result = self.forward(*input, **kwargs) File "/run/media/xxx/works/python/github/mmdetection/mmdet/models/detectors/cascade_rcnn.py", line 135, in forward_dummy x[:self.bbox_roi_extractor[i].num_inputs], rois) File "/home/xxx/anaconda3/envs/cv-env/lib/python3.6/site-packages/torch/nn/modules/module.py", line 491, in __call__ result = self._slow_forward(*input, **kwargs) File "/home/xxx/anaconda3/envs/cv-env/lib/python3.6/site-packages/torch/nn/modules/module.py", line 481, in _slow_forward result = self.forward(*input, **kwargs) File "/run/media/xxx/works/python/github/mmdetection/mmdet/core/fp16/decorators.py", line 127, in new_func return old_func(*args, **kwargs) File "/run/media/xxx/works/python/github/mmdetection/mmdet/models/roi_extractors/single_level.py", line 105, in forward roi_feats_t = self.roi_layers[i](feats[i], rois_) File "/home/xxx/anaconda3/envs/cv-env/lib/python3.6/site-packages/torch/nn/modules/module.py", line 491, in __call__ result = self._slow_forward(*input, **kwargs) File "/home/xxx/anaconda3/envs/cv-env/lib/python3.6/site-packages/torch/nn/modules/module.py", line 481, in _slow_forward result = self.forward(*input, **kwargs) File "/run/media/xxx/works/python/github/mmdetection/mmdet/ops/roi_align/roi_align.py", line 77, in forward self.spatial_scale, self.sample_num) File "/home/xxx/anaconda3/envs/cv-env/lib/python3.6/site-packages/torchvision/ops/roi_align.py", line 67, in roi_align return _RoIAlignFunction.apply(input, rois, output_size, spatial_scale, sampling_ratio) File "/home/xxx/anaconda3/envs/cv-env/lib/python3.6/site-packages/torchvision/ops/roi_align.py", line 23, in forward output_size[0], output_size[1], sampling_ratio) RuntimeError: rois.device().is_cpu() ASSERT FAILED at /vision/torchvision/csrc/cpu/ROIAlign_cpu.cpp:386, please report a bug to PyTorch. rois must be a CPU tensor (ROIAlign_forward_cpu at /vision/torchvision/csrc/cpu/ROIAlign_cpu.cpp:386) frame #0: std::function<std::string ()>::operator()() const + 0x11 (0x7f9e573bc441 in /home/xxx/anaconda3/envs/cv-env/lib/python3.6/site-packages/torch/lib/libc10.so) frame #1: c10::Error::Error(c10::SourceLocation, std::string const&) + 0x2a (0x7f9e573bbd7a in /home/xxx/anaconda3/envs/cv-env/lib/python3.6/site-packages/torch/lib/libc10.so) frame #2: ROIAlign_forward_cpu(at::Tensor const&, at::Tensor const&, float, int, int, int) + 0x269 (0x7f9df8c454d7 in /home/xxx/anaconda3/envs/cv-env/lib/python3.6/site-packages/torchvision/_C.cpython-36m-x86_64-linux-gnu.so) frame #3: ROIAlign_forward(at::Tensor const&, at::Tensor const&, float, int, int, int) + 0x92 (0x7f9df8c0d60c in /home/xxx/anaconda3/envs/cv-env/lib/python3.6/site-packages/torchvision/_C.cpython-36m-x86_64-linux-gnu.so) frame #4: <unknown function> + 0x7f75e (0x7f9df8c3375e in /home/xxx/anaconda3/envs/cv-env/lib/python3.6/site-packages/torchvision/_C.cpython-36m-x86_64-linux-gnu.so) frame #5: <unknown function> + 0x7b4c7 (0x7f9df8c2f4c7 in /home/xxx/anaconda3/envs/cv-env/lib/python3.6/site-packages/torchvision/_C.cpython-36m-x86_64-linux-gnu.so) frame #6: <unknown function> + 0x76114 (0x7f9df8c2a114 in /home/xxx/anaconda3/envs/cv-env/lib/python3.6/site-packages/torchvision/_C.cpython-36m-x86_64-linux-gnu.so) frame #7: <unknown function> + 0x763b1 (0x7f9df8c2a3b1 in /home/xxx/anaconda3/envs/cv-env/lib/python3.6/site-packages/torchvision/_C.cpython-36m-x86_64-linux-gnu.so) frame #8: <unknown function> + 0x65bc4 (0x7f9df8c19bc4 in /home/xxx/anaconda3/envs/cv-env/lib/python3.6/site-packages/torchvision/_C.cpython-36m-x86_64-linux-gnu.so) <omitting python frames> frame #15: THPFunction_apply(_object*, _object*) + 0x6b1 (0x7f9e3a384481 in /home/xxx/anaconda3/envs/cv-env/lib/python3.6/site-packages/torch/lib/libtorch_python.so) ``` ## To Reproduce Steps to reproduce the behavior: 1. `python /run/media/xxx/works/python/github/mmdetection/tools/pytorch2onnx.py configs/cascade_rcnn_r50_fpn_1x.py work_dirs/cascade_rcnn_r50_fpn_1xh/latest.pth --out model.onnx` <!-- If you have a code sample, error messages, stack traces, please provide it here as well --> ## Expected behavior <!-- A clear and concise description of what you expected to happen. --> I am performing torch model to onnx ## Environment ``` PyTorch version: 1.1.0 Is debug build: No CUDA used to build PyTorch: 9.0.176 OS: Manjaro Linux GCC version: (GCC) 7.2.1 20180116 CMake version: Could not collect Python version: 3.6 Is CUDA available: Yes CUDA runtime version: 10.0.130 GPU models and configuration: GPU 0: GeForce GTX 1050 with Max-Q Design Nvidia driver version: 440.82 cuDNN version: Could not collect Versions of relevant libraries: [pip3] numpy==1.12.1 [pip3] numpydoc==0.6.0 [conda] numpy 1.18.1 pypi_0 pypi [conda] torch 1.1.0 pypi_0 pypi [conda] torchvision 0.3.0 pypi_0 pypi ``` ## Additional context <!-- Add any other context about the problem here. --> cc @fmassa
triaged,module: vision
low
Critical
647,802,281
flutter
Editing engine.version can result in a bricked install when the Dart SDK is unable to be downloaded and requires deletion of bin/cache to resolve.
## Logs Changed bin\internal\engine.version to `f6a95deb733b43732941758df209380570b2ec18` ``` flutter upgrade Checking Dart SDK version... Downloading Dart SDK from Flutter engine f6a95deb733b43732941758df209380570b2ec18... Downloading the Dart SDK using the BITS service failed, retrying with WebRequest... Invoke-WebRequest : NoSuchKeyThe specified key does not exist.No such object: flutter_infra/flutter/f6a95deb733b43732941758df209380570b2ec18/dart-sdk-windows-x64.zip At C:\src\flutter\bin\internal\update_dart_sdk.ps1:68 char:5 + Invoke-WebRequest -Uri $dartSdkUrl -OutFile $dartSdkZip + ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ + CategoryInfo : InvalidOperation: (System.Net.HttpWebRequest:HttpWebRequest) [Invoke-WebRequest], WebExc eption + FullyQualifiedErrorId : WebCmdletWebResponseException,Microsoft.PowerShell.Commands.InvokeWebRequestCommand Error: Unable to update Dart SDK. Retrying... ``` changed back to previous hash `fc725775253ef4808680260b362ca35154f49e64` and received `The system cannot find the path specified.`. Had to delete cache to restore flutter to a working state. cc @christopherfujino
c: crash,tool,dependency: dart,P2,team-tool,triaged-tool
low
Critical
647,852,092
pytorch
Quantization support for F.Softmax
## 🚀 Feature Support the F.Softmax in quantization model ## Motivation sometimes we need to add 2 tensors in quantized model, we could use torch.nn.quantized.FloatFunctional() , however sometimes we need F.Softmax on classification, then there is no such support, and the output is not within [0,1], it is not a big problem, but nice to support it. cc @jerryzh168 @jianyuh @dzhulgakov @raghuramank100 @jamesr66a @vkuzo
oncall: quantization,low priority,triaged
low
Major
647,911,666
pytorch
Sparse Convolutional support
hi,when pytorch can support sparse convolution in pytroch master?thanks. cc @vincentqb
module: sparse,triaged
low
Minor
647,914,786
TypeScript
importsNotUsedAsValues = error should apply to export statements
**TypeScript Version:** 3.9.2 **Search Terms:** importsNotUsedAsValues, error, export **Code** ```ts import { Interface } from "./module"; export { Interface } from "./module"; ``` With a `"importsNotUsedAsValues"` set to `"error"`. **Expected behavior:** `tsc` would error on the export statement. **Actual behavior:** `tsc` does not error on the export statement, it only errors on the import statement. TypeScript, by default, would elide both statements in the compile and should error in the same way. **Playground Link:** N/A
Suggestion,In Discussion
low
Critical
647,969,442
TypeScript
Object is possibly undefined after undefined check on readonly property
<!-- 🚨 STOP 🚨 STOP 🚨 STOP 🚨 Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Even if you think you've found a *bug*, please read the FAQ first, especially the Common "Bugs" That Aren't Bugs section! Please help us by doing the following steps before logging an issue: * Search: https://github.com/Microsoft/TypeScript/search?type=Issues * Read the FAQ: https://github.com/Microsoft/TypeScript/wiki/FAQ Please fill in the *entire* template below. --> <!-- Please try to reproduce the issue with the latest published version. It may have already been fixed. For npm: `typescript@next` This is also the 'Nightly' version in the playground: http://www.typescriptlang.org/play/?ts=Nightly --> **TypeScript Version:** 3.7.4, 3.9.2 <!-- Search terms you tried before logging this (so others can find this issue more easily) --> **Search Terms:** Object is possibly undefined undefined readonly callback **Code** ```ts class Test { private readonly testProperty?: { value: number }; public constructor(testProperty: { value: number }) { this.testProperty = testProperty; } public method() { if (this.testProperty) { Promise.resolve().then(() => this.testProperty.value); //Object is possibly undefined } } } ``` **Expected behavior:** testProperty should not be resolved as possibly undefined as this is not possible in this scenario as the property has already been checked and it is marked as readonly. **Actual behavior:** testProperty is possibly undefined, requiring another undefined check. **Playground Link:** <!-- A link to a TypeScript Playground "Share" link which demonstrates this behavior --> https://www.typescriptlang.org/play/#code/MYGwhgzhAEAqCmEAu0DeAoa0AOAnAlgG5hLzS7xgAmA9gHYgCe0pyACrjdvLkowPwAuNNGIgArvGF1xAWwBGPaAF8A3Jhzj5IfMGjB6yXOOBIauABSskHLjz7DUosBKnQZCpcoCUaDViQAC3wIADprW25eZgBeFkQbTii+dSxldA1sLR09WXggmioLXwwsLHwAM2grYLCIpPtGEv8y21kQ+FCKCBoQQnhi8MD4Ogti6BiAPhZa8ITIxtCxSW9VaAB6dYB5eQAreFNoEJwaKHxtZnE6KngK-Dp4Khb0tPRlIA **Related Issues:** <!-- Did you find other bugs that looked similar? --> Similar issues but these i understand why TypeScript would report an error, in my case the property is readonly so it seems like a bug to me. https://github.com/microsoft/TypeScript/issues/38053 https://github.com/microsoft/TypeScript/issues/11498
Suggestion,Experience Enhancement
low
Critical
648,002,179
youtube-dl
www.xmegadrive.com
<!-- ###################################################################### WARNING! IGNORING THE FOLLOWING TEMPLATE WILL RESULT IN ISSUE CLOSED AS INCOMPLETE ###################################################################### --> ## Checklist <!-- Carefully read and work through this check list in order to prevent the most common mistakes and misuse of youtube-dl: - First of, make sure you are using the latest version of youtube-dl. Run `youtube-dl --version` and ensure your version is 2020.06.16.1. If it's not, see https://yt-dl.org/update on how to update. Issues with outdated version will be REJECTED. - Make sure that all provided video/audio/playlist URLs (if any) are alive and playable in a browser. - Make sure that site you are requesting is not dedicated to copyright infringement, see https://yt-dl.org/copyright-infringement. youtube-dl does not support such sites. In order for site support request to be accepted all provided example URLs should not violate any copyrights. - Search the bugtracker for similar site support requests: http://yt-dl.org/search-issues. DO NOT post duplicates. - Finally, put x into all relevant boxes (like this [x]) --> - [x] I'm reporting a new site support request - [x] I've verified that I'm running youtube-dl version **2020.06.16.1** - [x] I've checked that all provided URLs are alive and playable in a browser - [x] I've checked that none of provided URLs violate any copyrights - [x] I've searched the bugtracker for similar site support requests including closed ones ## Example URLs <!-- Provide all kinds of example URLs support for which should be included. Replace following example URLs by yours. --> - Single video: https://www.xmegadrive.com/videos/goddess-amanda-they-make-you-weak/ - Playlist: https://www.xmegadrive.com/playlists/204/cei5/ ## Description <!-- Provide any additional information. If work on your issue requires account credentials please provide them or explain how one can obtain them. --> you do not need to be logged in to view or download the videos
site-support-request,nsfw
low
Critical
648,018,930
pytorch
Enhance supported types of functional.pad
## 🚀 Feature Currently, `torch.nn.functional.pad` does not support input tensors with dtype other than float32 or float64 for modes "replicate" and "reflect". Method execution fails with error, for example : ``` RuntimeError: "replication_pad2d_cpu" not implemented for 'Long' ``` Feature request is to improve the support for other types like uint8, long, etc ## Alternatives We still can cast to float, perform the operation and recast back after to the original dtype. ## Additional context Torchvision: https://github.com/pytorch/vision/issues/2350 cc @albanD @mruberry @fmassa **EDIT:** I can work on this issue if we agree that this feature is useful and is needed to be done.
module: nn,triaged,enhancement,module: numpy
low
Critical
648,022,319
opencv
Parsing error (Failed to parse NetParameter file: yolov3-spp.weights) in cv::dnn::dnn4_v20200310::readNetFromDarknet
##### System information (version) <!-- Example - OpenCV => 4.3 - Operating System / Platform => Windows 64 Bit - Compiler => Visual Studio 2017 --> I can currently use the DNN module to call **Darknet's yolov3.weights**, but when I call **yolov3-spp.weights**, such an **error** occurs. I want to know is it because of the incompatibility of opencv? Is there a way to avoid this error? Has anyone tried calling the v3-spp model? In addition, when I use **readNetFromONNX**, any ONNX model **cannot be read**, including **yolov3-spp.onnx** and any model in the **ONNX model library**.
question (invalid tracker),category: dnn
low
Critical
648,086,037
rust
[Missed optimization?] Having many if branches that all check for Some(_) is slower than pre-destructuring the Some before the if section
If you compile the following code in play.rust-lang.org to LLVM IR in release mode, it will generate 135 lines of LLVM code. ```rust pub fn has_start(board_idx: usize, start_idx: Option<usize>) -> Option<usize> { match board_idx { 0 => { if start_idx == Some(0) { return Some(0) }; if start_idx == Some(15) { return Some(3) }; } 1 => if start_idx == Some(1) { return Some(0) }, 2 => if start_idx == Some(2) { return Some(0) }, 3 => if start_idx == Some(3) { return Some(0) }, 4 => { if start_idx == Some(4) { return Some(0) }; if start_idx == Some(5) { return Some(1) }; } 5 => if start_idx == Some(14) { return Some(3) }, 9 => if start_idx == Some(6) { return Some(1) }, 10 => { if start_idx == Some(13) { return Some(3) }; if start_idx == Some(12) { return Some(2) }; } 11 => if start_idx == Some(11) { return Some(2) }, 12 => if start_idx == Some(10) { return Some(2) }, 13 => if start_idx == Some(9) { return Some(2) }, 14 => { if start_idx == Some(8) { return Some(2) }; if start_idx == Some(7) { return Some(2) }; } _ => { return None } } None } ``` However, if you pre-destructure the Some, as in the following example, you now generate only 109 lines of LLVM code. ```rust pub fn has_start(board_idx: usize, start_idx: Option<usize>) -> Option<usize> { if let Some(start) = start_idx { match board_idx { 0 => { if start == 0 { return Some(0) }; if start == 15 { return Some(3) }; } 1 => if start == 1 { return Some(0) }, 2 => if start == 2 { return Some(0) }, 3 => if start == 3 { return Some(0) }, 4 => { if start == 4 { return Some(0) }; if start == 5 { return Some(1) }; } 5 => if start == 14 { return Some(3) }, 9 => if start == 6 { return Some(1) }, 10 => { if start == 13 { return Some(3) }; if start == 12 { return Some(2) }; } 11 => if start == 11 { return Some(2) }, 12 => if start == 10 { return Some(2) }, 13 => if start == 9 { return Some(2) }, 14 => { if start == 8 { return Some(2) }; if start == 7 { return Some(2) }; } _ => { return None } } } None } ``` Seems like a relatively simple opportunity for optimisation behind the scenes?
C-enhancement,A-codegen,T-compiler,I-heavy,C-optimization
low
Major
648,092,934
godot
Don't allow exporting a project if no main scene is defined
<!-- Please search existing issues for potential duplicates before filing yours: https://github.com/godotengine/godot/issues?q=is%3Aissue --> **Godot version:** <!-- Specify commit hash if using non-official build. --> godot 3.2.2-stable **OS/device including version:** <!-- Specify GPU model, drivers, and the backend (GLES2, GLES3, Vulkan) if graphics-related. --> Windows, gles2 **Issue description:** <!-- What happened, and what was expected. --> When exporting a game with no selected main scene, exported game crashes on start **Steps to reproduce:** Not select a main scene and then export to windows **Minimal reproduction project:** <!-- A small Godot project which reproduces the issue. Drag and drop a zip archive to upload it. -->
bug,topic:editor,topic:porting,confirmed
low
Critical
648,150,930
pytorch
Incremental version of pca_lowrank
## 🚀 Feature An incremental version of pca_lowrank - processing a mini-batch of samples in each iteration. Similar to sklearn.decomposition.IncrementalPCA(), but in GPU. ## Motivation The current implementation processes all the data in one go and can run quickly only if all the data fits into the GPU memory. ## Pitch It is sometimes needed to perform PCA on a large dataset of images. Doing it in GPU using pytorch is great, but currently limited by GPU memory. An incremental version will allow processing large datasets. ## Alternatives Doing PCA in CPU using sklearn :( cc @ngimel
feature,module: cuda,triaged,function request
low
Major
648,155,054
flutter
Xcode 11.5 archive build failed flutter: Multiple commands produce GoogleUtilities.framework
I try to take these steps: "Product" -> "Archive" to unload the application to testers, but when these steps are performed, this error is constantly displayed: Multiple commands produce '/Users/user/Library/Developer/Xcode/DerivedData/Runner-dpjgfafimzpddicamlmtfyiidicx/Build/Intermediates.noindex/ArchiveIntermediates/Runner/IntermediateBuildFilesPath/UninstalledProducts/iphoneos/GoogleUtilities.framework': 1) Target 'GoogleUtilities-00567490' has create directory command with output '/Users/user/Library/Developer/Xcode/DerivedData/Runner-dpjgfafimzpddicamlmtfyiidicx/Build/Intermediates.noindex/ArchiveIntermediates/Runner/IntermediateBuildFilesPath/UninstalledProducts/iphoneos/GoogleUtilities.framework' 2) Target 'GoogleUtilities-Environment-Logger-UserDefaults' has create directory command with output '/Users/user/Library/Developer/Xcode/DerivedData/Runner-dpjgfafimzpddicamlmtfyiidicx/Build/Intermediates.noindex/ArchiveIntermediates/Runner/IntermediateBuildFilesPath/UninstalledProducts/iphoneos/GoogleUtilities.framework' **Flutter doctor:** ``` [✓] Flutter (Channel stable, v1.17.4, on Mac OS X 10.15.4 19E287, locale ru-RU) • Flutter version 1.17.4 at /Users/user/dev/flutter • Framework revision 1ad9baa8b9 (13 days ago), 2020-06-17 14:41:16 -0700 • Engine revision ee76268252 • Dart version 2.8.4 [✓] Android toolchain - develop for Android devices (Android SDK version 29.0.3) • Android SDK at /Users/user/Library/Android/sdk • Platform android-29, build-tools 29.0.3 • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593) [✓] Xcode - develop for iOS and macOS (Xcode 11.5) • Xcode at /Applications/Xcode.app/Contents/Developer • Xcode 11.5, Build version 11E608c • CocoaPods version 1.9.1 [✓] Android Studio (version 4.0) • Android Studio at /Applications/Android Studio.app/Contents • Flutter plugin version 46.0.1 • Dart plugin version 192.8052 • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593) [✓] VS Code (version 1.46.1) • VS Code at /Users/user/Applications/Visual Studio Code.app/Contents • Flutter extension version 3.12.0 [✓] Connected device (1 available) • iPhone (Илья) • 6cd3a4fb82220c402eee2444a3db70abb14b53ab • ios • iOS 13.5.1 ``` I also tried to do the actions that were described in other Issue, but nothing helped, the error was still there I tried to set in the settings of the build Use legacy system, it did not help :(
platform-ios,tool,t: xcode,P3,c: fatal crash,team-ios,triaged-ios
low
Critical
648,169,773
flutter
Short lines with stroke cap and mask filter are not drawn
<!-- Thank you for using Flutter! If you are looking for support, please check out our documentation or consider asking a question on Stack Overflow: * https://flutter.dev/ * https://api.flutter.dev/ * https://stackoverflow.com/questions/tagged/flutter?sort=frequent If you have found a bug or if our documentation doesn't have an answer to what you're looking for, then fill our the template below. Please read our guide to filing a bug first: https://flutter.dev/docs/resources/bug-reports --> ## Steps to Reproduce ``` import 'package:flutter/material.dart'; void main() { runApp(MyApp()); } class MyApp extends StatelessWidget { @override Widget build(BuildContext context) { return Center(child: CustomPaint(size: Size(32, 32), painter: MyCustomPainter())); } } class MyCustomPainter extends CustomPainter { @override void paint(Canvas canvas, Size size) { Paint bgPaint = Paint() ..color = Colors.white ..style = PaintingStyle.fill; canvas.drawRect(Offset.zero & size, bgPaint); Paint paint = Paint() ..color = Colors.black ..style = PaintingStyle.stroke ..strokeWidth = 2.5 ..strokeCap = StrokeCap.round ..maskFilter = MaskFilter.blur(BlurStyle.normal, 0.09); canvas.drawLine(Offset(8, 5), Offset(8, 25), paint); canvas.drawLine(Offset(24, 5), Offset(24, 20), paint); } @override bool shouldRepaint(CustomPainter oldDelegate) => true; } ``` The problem could be reproduced on an Android emulator and a physical Android device. **Expected results:** Two vertical lines should be drawn. **Actual results:** The shorter line is not drawn: ![grafik](https://user-images.githubusercontent.com/34420883/86129194-97c70800-bae2-11ea-8bfc-d1da10c4eab0.png) If the default stroke cap or the default mask filter is used in the code above, both lines are drawn as expected. If a larger sigma value is used for the blur filter, the shorter line is also drawn. <details> <summary>Logs</summary> <!-- Run your application with `flutter run --verbose` and attach all the log output below between the lines with the backticks. If there is an exception, please see if the error message includes enough information to explain how to solve the issue. --> ``` [ +16 ms] executing: [D:\Flutter/] git -c log.showSignature=false log -n 1 --pretty=format:%H [ +52 ms] Exit code 0 from: git -c log.showSignature=false log -n 1 --pretty=format:%H [ ] 1ad9baa8b99a2897c20f9e6e54d3b9b359ade314 [ ] executing: [D:\Flutter/] git tag --contains HEAD [ +170 ms] Exit code 0 from: git tag --contains HEAD [ +2 ms] 1.17.4 [ +13 ms] executing: [D:\Flutter/] git rev-parse --abbrev-ref --symbolic @{u} [ +29 ms] Exit code 0 from: git rev-parse --abbrev-ref --symbolic @{u} [ ] origin/stable [ ] executing: [D:\Flutter/] git ls-remote --get-url origin [ +25 ms] Exit code 0 from: git ls-remote --get-url origin [ ] https://github.com/flutter/flutter.git [ +76 ms] executing: [D:\Flutter/] git rev-parse --abbrev-ref HEAD [ +26 ms] Exit code 0 from: git rev-parse --abbrev-ref HEAD [ ] stable [ +32 ms] Artifact Instance of 'AndroidMavenArtifacts' is not required, skipping update. [ ] Artifact Instance of 'AndroidGenSnapshotArtifacts' is not required, skipping update. [ ] Artifact Instance of 'AndroidInternalBuildArtifacts' is not required, skipping update. [ ] Artifact Instance of 'IOSEngineArtifacts' is not required, skipping update. [ ] Artifact Instance of 'FlutterWebSdk' is not required, skipping update. [ +2 ms] Artifact Instance of 'WindowsEngineArtifacts' is not required, skipping update. [ ] Artifact Instance of 'MacOSEngineArtifacts' is not required, skipping update. [ ] Artifact Instance of 'LinuxEngineArtifacts' is not required, skipping update. [ ] Artifact Instance of 'LinuxFuchsiaSDKArtifacts' is not required, skipping update. [ ] Artifact Instance of 'MacOSFuchsiaSDKArtifacts' is not required, skipping update. [ ] Artifact Instance of 'FlutterRunnerSDKArtifacts' is not required, skipping update. [ ] Artifact Instance of 'FlutterRunnerDebugSymbols' is not required, skipping update. [ +13 ms] executing: C:\Users\thomas\AppData\Local\Android\sdk\platform-tools\adb.exe devices -l [ +33 ms] List of devices attached emulator-5554 device product:sdk_gphone_x86 model:Android_SDK_built_for_x86 device:generic_x86 transport_id:1 [ +5 ms] C:\Users\thomas\AppData\Local\Android\sdk\platform-tools\adb.exe -s emulator-5554 shell getprop [ +37 ms] Artifact Instance of 'AndroidMavenArtifacts' is not required, skipping update. [ +3 ms] Artifact Instance of 'AndroidInternalBuildArtifacts' is not required, skipping update. [ ] Artifact Instance of 'IOSEngineArtifacts' is not required, skipping update. [ ] Artifact Instance of 'FlutterWebSdk' is not required, skipping update. [ +1 ms] Artifact Instance of 'WindowsEngineArtifacts' is not required, skipping update. [ ] Artifact Instance of 'MacOSEngineArtifacts' is not required, skipping update. [ ] Artifact Instance of 'LinuxEngineArtifacts' is not required, skipping update. [ ] Artifact Instance of 'LinuxFuchsiaSDKArtifacts' is not required, skipping update. [ ] Artifact Instance of 'MacOSFuchsiaSDKArtifacts' is not required, skipping update. [ ] Artifact Instance of 'FlutterRunnerSDKArtifacts' is not required, skipping update. [ ] Artifact Instance of 'FlutterRunnerDebugSymbols' is not required, skipping update. [ +139 ms] Generating D:\Entwicklung\Flutter\bug\android\app\src\main\java\io\flutter\plugins\GeneratedPluginRegistrant.java [ +25 ms] ro.hardware = ranchu [ +29 ms] Using hardware rendering with device Android SDK built for x86. If you get graphics artifacts, consider enabling software rendering with "--enable-software-rendering". [ +20 ms] Launching lib\main.dart on Android SDK built for x86 in debug mode... [ +7 ms] D:\Flutter\bin\cache\dart-sdk\bin\dart.exe D:\Flutter\bin\cache\artifacts\engine\windows-x64\frontend_server.dart.snapshot --sdk-root D:\Flutter\bin\cache\artifacts\engine\common\flutter_patched_sdk/ --incremental --target=flutter --debugger-module-names -Ddart.developer.causal_async_stacks=true --output-dill C:\Users\thomas\AppData\Local\Temp\flutter_tool.25bc1a12-bad2-11ea-bdc3-00d86118a499\app.dill --packages D:\Entwicklung\Flutter\bug\.packages -Ddart.vm.profile=false -Ddart.vm.product=false --bytecode-options=source-positions,local-var-info,debugger-stops,instance-field-initializers,keep-unreachable-code,avoid-closure-call-instructions --enable-asserts --track-widget-creation --filesystem-scheme org-dartlang-root [ +11 ms] executing: C:\Users\thomas\AppData\Local\Android\sdk\build-tools\29.0.3\aapt dump xmltree D:\Entwicklung\Flutter\bug\build\app\outputs\apk\app.apk AndroidManifest.xml [ +10 ms] Exit code 0 from: C:\Users\thomas\AppData\Local\Android\sdk\build-tools\29.0.3\aapt dump xmltree D:\Entwicklung\Flutter\bug\build\app\outputs\apk\app.apk AndroidManifest.xml [ ] N: android=http://schemas.android.com/apk/res/android E: manifest (line=2) A: android:versionCode(0x0101021b)=(type 0x10)0x1 A: android:versionName(0x0101021c)="1.0.0" (Raw: "1.0.0") A: android:compileSdkVersion(0x01010572)=(type 0x10)0x1c A: android:compileSdkVersionCodename(0x01010573)="9" (Raw: "9") A: package="com.example.bug" (Raw: "com.example.bug") A: platformBuildVersionCode=(type 0x10)0x1c A: platformBuildVersionName=(type 0x10)0x9 E: uses-sdk (line=7) A: android:minSdkVersion(0x0101020c)=(type 0x10)0x10 A: android:targetSdkVersion(0x01010270)=(type 0x10)0x1c E: uses-permission (line=14) A: android:name(0x01010003)="android.permission.INTERNET" (Raw: "android.permission.INTERNET") E: application (line=22) A: android:label(0x01010001)="bug" (Raw: "bug") A: android:icon(0x01010002)=@0x7f080000 A: android:name(0x01010003)="io.flutter.app.FlutterApplication" (Raw: "io.flutter.app.FlutterApplication") A: android:debuggable(0x0101000f)=(type 0x12)0xffffffff A: android:appComponentFactory(0x0101057a)="androidx.core.app.CoreComponentFactory" (Raw: "androidx.core.app.CoreComponentFactory") E: activity (line=28) A: android:theme(0x01010000)=@0x7f0a0000 A: android:name(0x01010003)="com.example.bug.MainActivity" (Raw: "com.example.bug.MainActivity") A: android:launchMode(0x0101001d)=(type 0x10)0x1 A: android:configChanges(0x0101001f)=(type 0x11)0x40003fb4 A: android:windowSoftInputMode(0x0101022b)=(type 0x11)0x10 A: android:hardwareAccelerated(0x010102d3)=(type 0x12)0xffffffff E: meta-data (line=42) A: android:name(0x01010003)="io.flutter.embedding.android.NormalTheme" (Raw: "io.flutter.embedding.android.NormalTheme") A: android:resource(0x01010025)=@0x7f0a0001 E: meta-data (line=52) A: android:name(0x01010003)="io.flutter.embedding.android.SplashScreenDrawable" (Raw: "io.flutter.embedding.android.SplashScreenDrawable") A: android:resource(0x01010025)=@0x7f040000 E: intent-filter (line=56) E: action (line=57) A: android:name(0x01010003)="android.intent.action.MAIN" (Raw: "android.intent.action.MAIN") E: category (line=59) A: android:name(0x01010003)="android.intent.category.LAUNCHER" (Raw: "android.intent.category.LAUNCHER") E: meta-data (line=66) A: android:name(0x01010003)="flutterEmbedding" (Raw: "flutterEmbedding") A: android:value(0x01010024)=(type 0x10)0x2 [ +6 ms] executing: C:\Users\thomas\AppData\Local\Android\sdk\platform-tools\adb.exe -s emulator-5554 shell -x logcat -v time -t 1 [ +33 ms] Exit code 0 from: C:\Users\thomas\AppData\Local\Android\sdk\platform-tools\adb.exe -s emulator-5554 shell -x logcat -v time -t 1 [ ] --------- beginning of main 06-30 13:03:53.615 E/GnssHAL_GnssInterface( 1794): gnssSvStatusCb: b: input svInfo.flags is 8 [ +13 ms] <- compile package:bug/main.dart [ +8 ms] executing: C:\Users\thomas\AppData\Local\Android\sdk\platform-tools\adb.exe version [ +29 ms] Android Debug Bridge version 1.0.41 Version 29.0.6-6198805 Installed as C:\Users\thomas\AppData\Local\Android\sdk\platform-tools\adb.exe [ +2 ms] executing: C:\Users\thomas\AppData\Local\Android\sdk\platform-tools\adb.exe start-server [ +18 ms] Building APK [ +16 ms] Running Gradle task 'assembleDebug'... [ +2 ms] gradle.properties already sets `android.enableR8` [ +3 ms] Using gradle from D:\Entwicklung\Flutter\bug\android\gradlew.bat. [ +1 ms] D:\Entwicklung\Flutter\bug\android\gradlew.bat mode: 33279 rwxrwxrwx. [ +7 ms] executing: C:\Program Files\Android\Android Studio\jre\bin\java -version [ +75 ms] Exit code 0 from: C:\Program Files\Android\Android Studio\jre\bin\java -version [ ] openjdk version "1.8.0_212-release" OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b04) OpenJDK 64-Bit Server VM (build 25.212-b04, mixed mode) [ +3 ms] executing: [D:\Entwicklung\Flutter\bug\android/] D:\Entwicklung\Flutter\bug\android\gradlew.bat -Pverbose=true -Ptarget-platform=android-x86 -Ptarget=D:\Entwicklung\Flutter\bug\lib\main.dart -Ptrack-widget-creation=true -Pfilesystem-scheme=org-dartlang-root assembleDebug [ +910 ms] > Task :app:compileFlutterBuildDebug UP-TO-DATE [ +1 ms] > Task :app:packLibsflutterBuildDebug UP-TO-DATE [ ] > Task :app:preBuild UP-TO-DATE [ ] > Task :app:preDebugBuild UP-TO-DATE [ ] > Task :app:checkDebugManifest UP-TO-DATE [ ] > Task :app:generateDebugBuildConfig UP-TO-DATE [ +82 ms] > Task :app:cleanMergeDebugAssets [ +1 ms] > Task :app:compileDebugAidl NO-SOURCE [ ] > Task :app:compileDebugRenderscript NO-SOURCE [ ] > Task :app:mergeDebugShaders UP-TO-DATE [ ] > Task :app:compileDebugShaders UP-TO-DATE [ ] > Task :app:generateDebugAssets UP-TO-DATE [ ] > Task :app:mergeDebugAssets [ +96 ms] > Task :app:copyFlutterAssetsDebug [ +1 ms] > Task :app:mainApkListPersistenceDebug UP-TO-DATE [ +1 ms] > Task :app:generateDebugResValues UP-TO-DATE [ ] > Task :app:generateDebugResources UP-TO-DATE [ +2 ms] > Task :app:mergeDebugResources UP-TO-DATE [ +1 ms] > Task :app:createDebugCompatibleScreenManifests UP-TO-DATE [ ] > Task :app:processDebugManifest UP-TO-DATE [ +1 ms] > Task :app:processDebugResources UP-TO-DATE [ +1 ms] > Task :app:compileDebugKotlin UP-TO-DATE [ +89 ms] > Task :app:javaPreCompileDebug UP-TO-DATE [ +1 ms] > Task :app:compileDebugJavaWithJavac UP-TO-DATE [ ] > Task :app:compileDebugSources UP-TO-DATE [ ] > Task :app:processDebugJavaRes NO-SOURCE [ ] > Task :app:mergeDebugJavaResource UP-TO-DATE [ ] > Task :app:checkDebugDuplicateClasses UP-TO-DATE [ ] > Task :app:transformClassesWithDexBuilderForDebug UP-TO-DATE [ ] > Task :app:desugarDebugFileDependencies UP-TO-DATE [ ] > Task :app:mergeExtDexDebug UP-TO-DATE [ ] > Task :app:mergeDexDebug UP-TO-DATE [ ] > Task :app:validateSigningDebug UP-TO-DATE [ ] > Task :app:signingConfigWriterDebug UP-TO-DATE [ ] > Task :app:mergeDebugJniLibFolders UP-TO-DATE [ ] > Task :app:mergeDebugNativeLibs UP-TO-DATE [ ] > Task :app:stripDebugDebugSymbols UP-TO-DATE [ ] Compatible side by side NDK version was not found. [ +2 ms] > Task :app:packageDebug UP-TO-DATE [ +11 ms] > Task :app:assembleDebug [ ] BUILD SUCCESSFUL in 1s [ ] 31 actionable tasks: 4 executed, 27 up-to-date [ +355 ms] Running Gradle task 'assembleDebug'... (completed in 1,7s) [ +25 ms] calculateSha: LocalDirectory: 'D:\Entwicklung\Flutter\bug\build\app\outputs\apk'/app.apk [ +43 ms] calculateSha: reading file took 41us [ +343 ms] calculateSha: computing sha took 342us [ +6 ms] √ Built build\app\outputs\apk\debug\app-debug.apk. [ +3 ms] executing: C:\Users\thomas\AppData\Local\Android\sdk\build-tools\29.0.3\aapt dump xmltree D:\Entwicklung\Flutter\bug\build\app\outputs\apk\app.apk AndroidManifest.xml [ +15 ms] Exit code 0 from: C:\Users\thomas\AppData\Local\Android\sdk\build-tools\29.0.3\aapt dump xmltree D:\Entwicklung\Flutter\bug\build\app\outputs\apk\app.apk AndroidManifest.xml [ ] N: android=http://schemas.android.com/apk/res/android E: manifest (line=2) A: android:versionCode(0x0101021b)=(type 0x10)0x1 A: android:versionName(0x0101021c)="1.0.0" (Raw: "1.0.0") A: android:compileSdkVersion(0x01010572)=(type 0x10)0x1c A: android:compileSdkVersionCodename(0x01010573)="9" (Raw: "9") A: package="com.example.bug" (Raw: "com.example.bug") A: platformBuildVersionCode=(type 0x10)0x1c A: platformBuildVersionName=(type 0x10)0x9 E: uses-sdk (line=7) A: android:minSdkVersion(0x0101020c)=(type 0x10)0x10 A: android:targetSdkVersion(0x01010270)=(type 0x10)0x1c E: uses-permission (line=14) A: android:name(0x01010003)="android.permission.INTERNET" (Raw: "android.permission.INTERNET") E: application (line=22) A: android:label(0x01010001)="bug" (Raw: "bug") A: android:icon(0x01010002)=@0x7f080000 A: android:name(0x01010003)="io.flutter.app.FlutterApplication" (Raw: "io.flutter.app.FlutterApplication") A: android:debuggable(0x0101000f)=(type 0x12)0xffffffff A: android:appComponentFactory(0x0101057a)="androidx.core.app.CoreComponentFactory" (Raw: "androidx.core.app.CoreComponentFactory") E: activity (line=28) A: android:theme(0x01010000)=@0x7f0a0000 A: android:name(0x01010003)="com.example.bug.MainActivity" (Raw: "com.example.bug.MainActivity") A: android:launchMode(0x0101001d)=(type 0x10)0x1 A: android:configChanges(0x0101001f)=(type 0x11)0x40003fb4 A: android:windowSoftInputMode(0x0101022b)=(type 0x11)0x10 A: android:hardwareAccelerated(0x010102d3)=(type 0x12)0xffffffff E: meta-data (line=42) A: android:name(0x01010003)="io.flutter.embedding.android.NormalTheme" (Raw: "io.flutter.embedding.android.NormalTheme") A: android:resource(0x01010025)=@0x7f0a0001 E: meta-data (line=52) A: android:name(0x01010003)="io.flutter.embedding.android.SplashScreenDrawable" (Raw: "io.flutter.embedding.android.SplashScreenDrawable") A: android:resource(0x01010025)=@0x7f040000 E: intent-filter (line=56) E: action (line=57) A: android:name(0x01010003)="android.intent.action.MAIN" (Raw: "android.intent.action.MAIN") E: category (line=59) A: android:name(0x01010003)="android.intent.category.LAUNCHER" (Raw: "android.intent.category.LAUNCHER") E: meta-data (line=66) A: android:name(0x01010003)="flutterEmbedding" (Raw: "flutterEmbedding") A: android:value(0x01010024)=(type 0x10)0x2 [ +2 ms] Stopping app 'app.apk' on Android SDK built for x86. [ ] executing: C:\Users\thomas\AppData\Local\Android\sdk\platform-tools\adb.exe -s emulator-5554 shell am force-stop com.example.bug [ +44 ms] executing: C:\Users\thomas\AppData\Local\Android\sdk\platform-tools\adb.exe -s emulator-5554 shell pm list packages com.example.bug [ +36 ms] package:com.example.bug [ +3 ms] executing: C:\Users\thomas\AppData\Local\Android\sdk\platform-tools\adb.exe -s emulator-5554 shell cat /data/local/tmp/sky.com.example.bug.sha1 [ +28 ms] e1d68da61ae180c9f8e3341a962ec44d421c5550 [ +1 ms] Latest build already installed. [ ] Android SDK built for x86 startApp [ +2 ms] executing: C:\Users\thomas\AppData\Local\Android\sdk\platform-tools\adb.exe -s emulator-5554 shell am start -a android.intent.action.RUN -f 0x20000000 --ez enable-background-compilation true --ez enable-dart-profiling true --ez enable-checked-mode true --ez verify-entry-points true com.example.bug/com.example.bug.MainActivity [ +47 ms] Starting: Intent { act=android.intent.action.RUN flg=0x20000000 cmp=com.example.bug/.MainActivity (has extras) } [ ] Waiting for observatory port to be available... [ +658 ms] Observatory URL on device: http://127.0.0.1:38551/hgAEv0skVtI=/ [ +2 ms] executing: C:\Users\thomas\AppData\Local\Android\sdk\platform-tools\adb.exe -s emulator-5554 forward tcp:0 tcp:38551 [ +20 ms] 64160 [ ] Forwarded host port 64160 to device port 38551 for Observatory [+1558 ms] Connecting to service protocol: http://127.0.0.1:64160/hgAEv0skVtI=/ [ +175 ms] Successfully connected to service protocol: http://127.0.0.1:64160/hgAEv0skVtI=/ [ +3 ms] Sending to VM service: getVM({}) [ +7 ms] Result: {type: VM, name: vm, architectureBits: 32, hostCPU: AMD Ryzen 7 2700X Eight-Core Processor, operatingSystem: android, targetCPU: ia32, version: 2.8.4 (stable) (Wed Jun 3 12:26:04 2020 +0200) on "android_ia32", _profilerMode: VM, _nativeZoneMemoryU... [ +6 ms] Sending to VM service: getIsolate({isolateId: isolates/1206993167345315}) [ +4 ms] Sending to VM service: _flutter.listViews({}) [ +10 ms] Result: {type: FlutterViewList, views: [{type: FlutterView, id: _flutterView/0xed332210, isolate: {type: @Isolate, fixedId: true, id: isolates/1206993167345315, name: main.dart$main-1206993167345315, number: 1206993167345315}}]} [ +4 ms] DevFS: Creating new filesystem on the device (null) [ +1 ms] Sending to VM service: _createDevFS({fsName: bug}) [ +14 ms] Result: {type: Isolate, id: isolates/1206993167345315, name: main, number: 1206993167345315, _originNumber: 1206993167345315, startTime: 1593522236478, _heaps: {new: {type: HeapSpace, name: new, vmName: Scavenger, collections: 3, avgCollectionPeriodMillis... [ +10 ms] Result: {type: FileSystem, name: bug, uri: file:///data/user/0/com.example.bug/code_cache/bugCDVXAU/bug/} [ ] DevFS: Created new filesystem on the device (file:///data/user/0/com.example.bug/code_cache/bugCDVXAU/bug/) [ +1 ms] Updating assets [ +62 ms] Syncing files to device Android SDK built for x86... [ +1 ms] Scanning asset files [ +1 ms] <- reset [ ] Compiling dart to kernel with 0 updated files [ +1 ms] <- recompile package:bug/main.dart 83f61f81-46cf-491b-944b-4929440d1f11 [ ] <- 83f61f81-46cf-491b-944b-4929440d1f11 [ +74 ms] Updating files [ +97 ms] DevFS: Sync finished [ +1 ms] Syncing files to device Android SDK built for x86... (completed in 178ms) [ ] Synced 0.9MB. [ +1 ms] Sending to VM service: _flutter.listViews({}) [ +4 ms] Result: {type: FlutterViewList, views: [{type: FlutterView, id: _flutterView/0xed332210, isolate: {type: @Isolate, fixedId: true, id: isolates/1206993167345315, name: main.dart$main-1206993167345315, number: 1206993167345315}}]} [ +1 ms] <- accept [ ] Connected to _flutterView/0xed332210. [ +1 ms] Flutter run key commands. [ +2 ms] r Hot reload. [ ] R Hot restart. [ ] h Repeat this help message. [ ] d Detach (terminate "flutter run" but leave application running). [ ] c Clear the screen [ ] q Quit (terminate the application on the device). [ +1 ms] An Observatory debugger and profiler on Android SDK built for x86 is available at: http://127.0.0.1:64160/hgAEv0skVtI=/ ``` <!-- Run `flutter analyze` and attach any output of that command below. If there are any analysis errors, try resolving them before filing this issue. --> ``` Analyzing bug... No issues found! (ran in 10.3s) ``` <!-- Finally, paste the output of running `flutter doctor -v` here. --> ``` [√] Flutter (Channel stable, v1.17.4, on Microsoft Windows [Version 10.0.18363.900], locale de-AT) • Flutter version 1.17.4 at D:\Flutter • Framework revision 1ad9baa8b9 (13 days ago), 2020-06-17 14:41:16 -0700 • Engine revision ee76268252 • Dart version 2.8.4 [√] Android toolchain - develop for Android devices (Android SDK version 29.0.3) • Android SDK at C:\Users\thomas\AppData\Local\Android\sdk • Platform android-29, build-tools 29.0.3 • Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java • Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b04) • All Android licenses accepted. [√] Android Studio (version 3.6) • Android Studio at C:\Program Files\Android\Android Studio • Flutter plugin version 45.1.1 • Dart plugin version 192.8052 • Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b04) [√] IntelliJ IDEA Ultimate Edition (version 2019.1) • IntelliJ at C:\Program Files\JetBrains\IntelliJ IDEA 2019.1 • Flutter plugin version 35.2.2 • Dart plugin version 191.6183.88 [√] VS Code (version 1.42.1) • VS Code at C:\Users\thomas\AppData\Local\Programs\Microsoft VS Code • Flutter extension version 3.8.1 [√] Connected device (1 available) • Android SDK built for x86 • emulator-5554 • android-x86 • Android 10 (API 29) (emulator) • No issues found! ``` </details>
platform-android,engine,dependency: skia,c: rendering,has reproducible steps,P2,found in release: 3.3,found in release: 3.7,team-android,triaged-android
low
Critical
648,210,558
angular
EVENT_MANAGER_PLUGINS injection order
<!--🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅 Oh hi there! 😄 To expedite issue processing please search open and closed issues before submitting a new one. Existing issues often contain information about workarounds, resolution, or progress updates. 🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅--> # 🐞 bug report ### Affected Package <!-- Can you pin-point one or more @angular/* packages as the source of the bug? --> <!-- ✍️edit: --> The issue is caused by package @angular/platform-browser ### Is this a regression? <!-- Did this behavior use to work in the previous version? --> <!-- ✍️--> No ### Description <!-- ✍️--> If I provide my own EventManagerPlugins with multi token EVENT_MANAGER_PLUGINS in a module of my library, order of modules matters - if BrowserModule appears after my module in upmost App module then DomEventsPlugin is injected after my plugins and events never reach my plugins, see this line here: https://github.com/angular/angular/blob/10.0.1/packages/platform-browser/src/dom/events/dom_events.ts#L20 ## 🔬 Minimal Reproduction <!-- Please create and share minimal reproduction of the issue starting with this template: https://stackblitz.com/fork/angular-ivy --> <!-- ✍️--> https://stackblitz.com/edit/angular-event-plugins-bug <!-- If StackBlitz is not suitable for reproduction of your issue, please create a minimal GitHub repository with the reproduction of the issue. A good way to make a minimal reproduction is to create a new app via `ng new repro-app` and add the minimum possible code to show the problem. Share the link to the repo below along with step-by-step instructions to reproduce the problem, as well as expected and actual behavior. Issues that don't have enough info and can't be reproduced will be closed. You can read more about issue submission guidelines here: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#-submitting-an-issue --> ## 🔥 Exception or Error No exceptions, plugins just never work ## 🌍 Your Environment **Angular Version:** <pre><code>Probably every version </code></pre> **Anything else relevant?** <!-- ✍️Is this a browser specific issue? If so, please specify the browser and version. --> <!-- ✍️Do any of these matter: operating system, IDE, package manager, HTTP server, ...? If so, please mention it below. -->
area: core,core: event listeners,P4
low
Critical
648,258,250
react
Profiler dev tools suggestion: in "ranked" view, add a way to group/aggregate component instances
(Deleted template as this is a suggestion, not a bug.) In the profiler's "ranked" view, when there are many instances of a single component, there's no way to answer the question "how much time did this component spend rendering _across all instances_. For example, here I have a component called `PhotoLink` which is used in many places across the tree. The "ranked" view shows us that each render is very cheap, but it does not tell us the aggregate cost of this component. Perhaps we could add something to dev tools to group/aggregate component instances? ![image](https://user-images.githubusercontent.com/921609/86143237-170d0980-baec-11ea-891e-636bbe73d3f5.png)
Type: Discussion,Component: Developer Tools
medium
Critical
648,260,670
flutter
Android HomeScreen Shortcut issue with Flutter
Hi, As you know, Flutter provides a mechanism for Dart to communicate with Native. You can call native code through dart, or you can call Dart code in native. There is such a situation, I do not know if you have encountered: Add a desktop shortcut on the Android platform, click the desktop shortcut to call the code logic of dart, if the application is already running, there is no problem at this time. But if you kill the application and then click on the desktop shortcut, it will not work in this case. (From the log, when I click the shortcut, class of native Application has called to create, but not with flutter engine) How can I implement native and dart communication in this situation? Thanks, Andy
platform-android,engine,d: stackoverflow,P2,team-android,triaged-android
low
Minor
648,291,076
go
x/playground: output caching stops working after some time passes
It looks like #31889 has regressed. The same snippet can be used to observe it, re-running this program produces successful but different output each time: ``` https://play.golang.org/p/979rn6Bd7QN ``` I've noticed this when sharing a snippet (/cc @julieqiu) where a timeout due to a large dependency would happen occasionally. Usually, with output caching, getting it to succeed once makes it possible to share the snippet without risk of timeout because it no longer needs to execute again, but that wasn't the case. /cc @toothrot @cagedmantis @andybons
NeedsInvestigation
low
Minor
648,342,219
pytorch
Encoding dimension argument for F.one_hot
## 🚀 Feature `dim` argument in `F.one_hot(tensor, dim=1, num_classes=-1)` ## Motivation via the [discussion on one-hot encoding](https://discuss.pytorch.org/t/pytocrh-way-for-one-hot-encoding-multiclass-target-variable/68321/8?u=stalhabukhari) at discuss.pytorch.org: Output from `F.one_hot` yields a tensor in the NHWC format, which needs to be transposed to convert into PyTorch's NCHW format. A `dim` argument, which specifies where the encoding (channel) dimension would emerge, will avoid this extra operation. Cc: @ptrblck cc @VitalyFedyunin @jamesr66a @ppwwyyxx
module: bootcamp,triaged,enhancement,module: memory format
low
Major
648,350,786
flutter
batch entrypoint adds measureable overhead to flutter_tool startup on Windows
The flutter.bat script seems to add about 200ms of overhead to the startup on windows. This does not seem to be a general script overhead, but a slowness in batch. It might be possible to reduce this overhead by doing some operations in a different shell (powershell?) while still retaining a minimal batch entrypoint. Initially discovered in https://github.com/flutter/flutter/pull/60112 > I looked into the performance issues on windows. I believe this is entirely caused by 1) slower tool operations on windows and 2) slower startup scripts on windows. > > For reference, If I make the following diff to the flutter tool: > > diff --git a/packages/flutter_tools/lib/executable.dart b/packages/flutter_tools/lib/executable.dart > index a7dcfbceed..12557ffd9b 100644 > --- a/packages/flutter_tools/lib/executable.dart > +++ b/packages/flutter_tools/lib/executable.dart > @@ -57,6 +57,7 @@ import 'src/web/web_runner.dart'; > /// > /// This function is intended to be used from the `flutter` command line tool. > Future<void> main(List<String> args) async { > + return; > final bool verbose = args.contains('-v') || args.contains('--verbose'); > > final bool doctor = (args.isNotEmpty && args.first == 'doctor') || > And then run the executable directly with Measure-Command { ./bin/cache/flutter_tools.exe }, the resulting execution time is approximately 24 ms. Running through bin/flutter.bat brings this up to 270 ms. Removing the early return brings it up further to 500 ms. > > Separate from this capability, I will need to dig into the entry-point script changes to see if we can get some of this performance back
tool,c: performance,platform-windows,P3,team-tool,triaged-tool
low
Major
648,400,033
terminal
Automatically add the release notes to Store page
<!-- 🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨 I ACKNOWLEDGE THE FOLLOWING BEFORE PROCEEDING: 1. If I delete this entire template and go my own path, the core team may close my issue without further explanation or engagement. 2. If I list multiple bugs/concerns in this one issue, the core team may close my issue without further explanation or engagement. 3. If I write an issue that has many duplicates, the core team may close my issue without further explanation or engagement (and without necessarily spending time to find the exact duplicate ID number). 4. If I leave the title incomplete when filing the issue, the core team may close my issue without further explanation or engagement. 5. If I file something completely blank in the body, the core team may close my issue without further explanation or engagement. All good? Then proceed! --> # Description of the new feature/enhancement <!-- A clear and concise description of what the problem is that the new feature would solve. Describe why and how a user would use this new functionality (if applicable). --> Automatically add the release notes to Store page # Proposed technical implementation details (optional) <!-- A clear and concise description of what you want to happen. --> update the release scripts to update the data for store when it is published. Also in Publisher Info add a link to the releases page probably call it "Windows Terminal release history"
Issue-Docs,Area-Build,Product-Meta
low
Critical
648,414,951
flutter
Extra vertical padding surrounding DropdownButtonFormField when compared to TextField
This issue was original reported by @cassioseffrin in https://github.com/flutter/flutter/issues/46844#issuecomment-651816889 ------------- @shihaohong take a look: ![Screen Shot 2020-06-30 at 10 58 17](https://user-images.githubusercontent.com/13109831/86135113-c59b5500-bac0-11ea-9f08-a745c586a112.png) the 1st field (price) is a common TextField with OutlineInputBorder border; the 2nd field (unit) is a DropdownButtonFormField with OutlineInputBorder border; Even with isDense=true there is an extra padding (8 pixes in total: 4 on top, 4 on bottom) between the labelText and the widget that wraps the labelText and the Icon in dropdown.dart line 1284 there is a method that calculates the height, the result is 24 if I set it to 16 the DropdownButtonFormField render the same height of the TextField, however I think it's not correct to set it as a constant. I can't figure out where this 8 pixels of extra padding were created. Line 1284 of dropdown.dart. ``` double get _denseButtonHeight { final double fontSize = _textStyle.fontSize ?? Theme.of(context).textTheme.subtitle1.fontSize; return math.max(fontSize, math.max(widget.iconSize, _kDenseButtonHeight)); } ``` I am in last stable release of Flutter (Channel stable, v1.17.4) ------------- @HansMuller, I don't think it's related to #59196, in this case the Text height is exactly the same. I actually have made a correction in the widget dropdown.dart, just 1 line of code. May I could make a PR? The problem is the icon size calculation, the resulting height is stretching all the DropdownButtonFormField: see the results, both components are now with exactly the same height. ![Screen Shot 2020-06-30 at 14 44 21](https://user-images.githubusercontent.com/13109831/86159400-ab716f00-bae0-11ea-9092-b31dd6f2b28c.png) Here without debug paint: ![Screen Shot 2020-06-30 at 15 04 14](https://user-images.githubusercontent.com/13109831/86161051-1623aa00-bae3-11ea-90b7-fc1a90eed0a4.png)
framework,f: material design,a: quality,has reproducible steps,P2,found in release: 3.3,found in release: 3.6,team-design,triaged-design
low
Critical
648,441,580
rust
Comprison of `TypeId`s in const context
Is there any way to compare 2 `TypeId`s in `const` context? (It's possible to _create_ them in `const` context, and it's even [soon to be stabilized](https://github.com/rust-lang/rust/pull/72488)) What I want is a static check for type (un)equality without `auto trait`s: ```rust // will fail with index out of bounds if T == U const _: () = [()][(TypeId::of::<T>() == TypeId::of::<U>()) as usize]; ``` (this exact code currently fails to compile with "calls in constants are limited to constant functions, tuple structs and tuple variants" error, because `==` isn't `const`) Maybe it's a good idea to add API like the following to TypeId? ```rust impl TypeId { const fn eq(&self, rhs: &Self) -> bool { self.t == rhs.t } } ``` I could work on this, though I haven't seen similar apps in std, so I wanted to ask about it before doing anything.
S-blocked,A-const-eval
low
Critical
648,442,244
go
x/text/message: documentation for i18n HTML template example?
Hi, I would like to see an example for translated `html/template` with `x/text/message`. Here's my current attempt with two different calling styles (free to use): ```go package main import ( "bytes" "fmt" "golang.org/x/text/language" "golang.org/x/text/message" "golang.org/x/text/message/catalog" "html/template" ) type TrPage struct { contents string trcat catalog.Catalog } type TrTemplate struct { funcs template.FuncMap base string // Base template as string pages map[string]TrPage // Pages which uses base template } func New(base string, funcs template.FuncMap) (TrTemplate, error) { return TrTemplate{ base: `{{define "base"}}` + base + `{{end}}`, pages: make(map[string]TrPage), funcs: funcs, }, nil } func (t *TrTemplate) AddPage(name string, template string, translations catalog.Catalog) error { tp := TrPage{ contents: `{{define "content"}}` + template + `{{end}}`, trcat: translations, } t.pages[name] = tp return nil } func (t *TrTemplate) Render(templatename string, language language.Tag, data interface{}) (out string, err error) { var tmp bytes.Buffer tpl := template.New(``) tpl.Funcs(t.funcs) tpl.Funcs(template.FuncMap{ // Translate inside template `T`: func(s string, a ...interface{}) template.HTML { pr := message.NewPrinter(language, message.Catalog(t.pages[templatename].trcat)) return template.HTML(pr.Sprintf(s, a)) }, }) _, err = tpl.Parse(t.base) if err != nil { return ``, err } _, err = tpl.Parse(t.pages[templatename].contents) if err != nil { return ``, err } err = tpl.ExecuteTemplate(&tmp, `base`, data) if err != nil { return ``, err } return tmp.String(), nil } type myBaseStruct struct { Title string // Base title Language string C interface{} // per-page content variables } type myAboutPageStruct struct { User string Msg string } func main() { // Common functions for templates (for example CSRF generation) funcs := template.FuncMap{ } basetpl, err := New(baseHTML, funcs) if err != nil { panic(err) } // Translate template to this language useLanguage := language.Finnish //useLanguage := language.English // Front page frontpageCat := catalog.NewBuilder( catalog.Fallback(useLanguage), ) basetpl.AddPage(`frontpage`, frontpageHTML, frontpageCat) // About page aboutCat := catalog.NewBuilder( catalog.Fallback(useLanguage), ) aboutCat.SetString(language.Finnish, `about_page_user`, `Tietoa käyttäjästä %s`) aboutCat.SetString(language.English, `about_page_user`, `Information about user %s`) basetpl.AddPage(`about`, aboutHTML, aboutCat) printer := message.NewPrinter(useLanguage, message.Catalog(aboutCat)) out, err := basetpl.Render(`about`, useLanguage, myBaseStruct{ Title: `yay title`, Language: useLanguage.String(), C: myAboutPageStruct{ // Style 1 User: `test user`, // Style 2 Msg: printer.Sprintf(`about_page_user`, `test`), }, }) if err != nil { panic(err) } fmt.Print(out) } var baseHTML = ` <!DOCTYPE html> <html lang="{{.Language}}"> <head> <meta charset="UTF-8"> <title>{{.Title}}</title> </head> <body> This is base Content: {{template "content" .C}} </body> </html> ` var aboutHTML = ` <div> <!-- Style 1 --> {{T "about_page_user" "{{.User}}" }} <!-- Style 2 --> {{.Msg}} </div> ` var frontpageHTML = ` <div> This is frontpage </div> ` ``` Which calling style is recommended or is there third option? Style 1 also doesn't evaluate `{{.User}}` to `test user` (I don't know how). I would like to see style 1 to be used. Also the parser for `html/template` is hidden as `internal` so you can't build nice automated translated token gatherer script for these kind of tasks to find all `T` calling functions and dump those to a translation file. Are there plans to open it up? I would also like to see example for when you have to add some HTML to a translation such as: someCatalog.SetString(language.Finnish, `about_page_user`, `Tietoa käyttäjästä %s`) and `%s` is for example `<a href="/foo">{{.User}}</a>`.
Documentation,NeedsInvestigation
low
Critical
648,459,341
godot
Signal method gets called within the editor and returns "not found" error
This bug is similar to Godot #13070 which was closed two years ago. **Godot version:** v3.2.2.stable.official **OS/device including version:** Windows 8 Desktop **Issue description:** By adding a making a Godot script listen to signals on a tool script, Godot calls it on the editor and returns the error: ``` ERROR: emit_signal: Error calling method from signal 'melodic_changed': 'Control (RootNode.gd)::_on_ScriptNode_melodic_changed': Method not found.. At: core/object.cpp:1260 ``` Script: ``` tool extends LineEdit # Setting this 'melodic' value in the editor causes console errors. export (String) var melodic: String setget set_melodic signal melodic_changed func set_melodic(new_melodic: String) -> void: emit_signal("melodic_changed") ``` **Steps to reproduce:** Create a tool script, and a non-tool script. Have the tool script emit a signal which the non-tool script listens to. Add an `emit_signal` call to a setter, so that you can emit the signal in the editor. The console will report an error when the signal is emitted. **Minimal reproduction project:** [signal-errors.zip](https://github.com/godotengine/godot/files/4854165/signal-errors.zip) `ScriptNode` has a `melodic` property; editing this property in the Godot editor causes errors in the console.
bug,topic:editor
low
Critical
648,480,354
electron
macOS: ability to determine when app is being quit from the Dock icon
<!-- As an open source project with a dedicated but small maintainer team, it can sometimes take a long time for issues to be addressed so please be patient and we will get back to you as soon as we can. --> ### Preflight Checklist <!-- Please ensure you've completed the following steps by replacing [ ] with [x]--> * [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project. * [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to. * [x] I have searched the issue tracker for a feature request that matches the one I want to file, without success. ### Problem Description <!-- Is your feature request related to a problem? Please add a clear and concise description of what the problem is. --> My team is working on an app that makes use of Electron's Tray functionality. One of the desired behaviors that we have for macOS is that the user should have an option they can enable called "Run in Background After Quitting". When the option is enabled, if the user selects the Quit option from the dock or the application menu, then the app should close all open windows, hide the dock icon, and continue to do work in the background with the Tray icon still visible. Selecting the Quit option from the Tray menu will completely quit the app. The way we initially implemented this is to have a flag that gets set when the user quits from the Tray, and if the flag is not set when the before-quit event is emitted then we prevent the app from quitting and instead we just close all open windows and hide the dock icon. However, this causes issues because it will also prevent the app from quitting in undesired scenarios, such as when the user tries to close the app from Activity Monitor, or when there is an app store update. Ideally we could flip the logic so that we will allow the app to quit unless the app is quit from the dock or the application menu, however with Electron there doesn't seem to be a way to differentiate between the app being told to quit because the user selected "Quit" from the dock icon, and the app being told to quit because e.g. the user is trying to install an app store update while the app is running. ### Proposed Solution <!-- Describe the solution you'd like in a clear and concise manner --> To resolve our problem I think we would need Electron to somehow expose a way for us to determine when the app is being quit from the dock icon. I am not overly familiar with Cocoa or the inner-workings of Electron, but perhaps Electron could implement [applicationShouldTerminate()](https://developer.apple.com/documentation/appkit/nsapplicationdelegate/1428642-applicationshouldterminate?language=objc) on the [Electron app delegate](https://github.com/electron/electron/blob/master/shell/browser/mac/electron_application_delegate.mm) and set a flag or emit an event when the app is being quit from the dock. This StackOverflow post describes how to determine when a Cocoa app is being quit from the dock: https://stackoverflow.com/a/57102139 ### Alternatives Considered <!-- A clear and concise description of any alternative solutions or features you've considered. --> We have investigated using a native Node add-on to determine when the app is quitting from the dock, but we have been unsuccessful thus far. It is unclear if it is even possible to implement this behavior using a native add-on since it appears necessary to implement `applicationShouldTerminate()`, which I think would have to be defined in Electron's app delegate. ### Additional Information <!-- Add any other context about the problem here. --> N/A
enhancement :sparkles:
low
Minor
648,528,231
go
x/pkgsite: remove legacyconversions
Replace the legacyconversions.RiskilyXXX calls with something safe.
NeedsFix,pkgsite
low
Minor
648,579,217
go
x/pkgsite: display struct field & interface method doc comments in a less code-ish way?
Apologies if this is something that's been suggested a million times, but... while I like the pkg.go.dev docs UI better than godoc.org, it keeps the same way of presenting struct and interface documentation, which I find awkward. The definitions are displayed literally as Go code, with all the doc comments looking like just that: code comments. To me, there are several problems with this: 1. It's unlike how any of the other doc content is displayed. Everything else is formatted as paragraphs of text, with distinct headings. 2. In particular, the comment lines are rendered exactly as is, so if there's a too-long line you'll have to scroll right, and if the developer manually wrapped some lines much shorter than others it looks pretty ragged. All other doc content is rendered as wrapping paragraphs. 3. Other than linking the names of types, none of the usual godoc formatting is applied: in particular, code examples look just like the other comment lines except for the extra indentation, and URLs are not linked. 4. While the HTML does contain anchor IDs for these items, there's no visible indication of that - you would have to inspect the page source or make assumptions about how the anchors correspond to the symbol names. I can't think of any conceptual reason why the doc comments for struct fields and interface methods should be treated so differently from types and implementation methods. If someone really wants to see what these definitions look like in their original Go code format, there's already a link to the source code right there. <!-- Please answer these questions before submitting your issue. Thanks! --> ### What is the URL of the page with the issue? Any page with a struct or an interface on it, for instance [this](https://pkg.go.dev/gopkg.in/launchdarkly/go-server-sdk.v5?tab=doc#Config) or [this](https://pkg.go.dev/gopkg.in/launchdarkly/go-server-sdk.v5/interfaces?tab=doc#DataStore). ### What is your user agent? Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/83.0.4103.106 Safari/537.36 ### Screenshot ![image](https://user-images.githubusercontent.com/35503443/86188336-2b083980-baf3-11ea-86a5-508ff873cb74.png) ### What did you do? Viewed the documentation for some structs and interfaces. ### What did you expect to see? No particular expectations, but it would've been nice to see something other than the way godoc.org does it. ### What did you see instead? A block of Go code, the same way godoc.org does it.
NeedsInvestigation,FeatureRequest,pkgsite,UX
low
Major
648,588,268
TypeScript
Should we set '"types": []' for 'tsc init'?
Very few people understand the automatic `@types` inclusion behavior, it often [causes packages to conflict](https://github.com/microsoft/TypeScript/issues/32273), and [it is often a program construction performance foot-gun](https://github.com/microsoft/TypeScript/wiki/Performance#controlling-types-inclusion). Maybe we should output a field like this in `compilerOptions`. ```json5 // Add packages with global definitions that can't be imported here. // Remove entirely to auto-include all '@types' packages. "types": [] ``` What do others here think?
Suggestion,In Discussion,Committed
low
Major
648,633,982
excalidraw
Can't open scene made in Firefox Developer Edition in Firefox (regular edition)
I use Firefox Developer Edition for work and Firefox (regular edition) for personal use on the same machine (macOS). I drew something in the Dev Edition, grabbed the link then tried to open in Firefox and received this error. <img width="787" alt="image" src="https://user-images.githubusercontent.com/3806031/86198503-9a3e5780-bb0c-11ea-8760-d8829c775a8b.png"> Note: opening the scene in Safari works fine. ### Scene content ``` {"excalidraw":[{"id":"WrEMSnYpiGbsXxbk_---6","type":"text","x":316.5,"y":358,"width":649,"height":24,"angle":0,"strokeColor":"#000000","backgroundColor":"transparent","fillStyle":"hachure","strokeWidth":1,"roughness":1,"opacity":100,"seed":2109172165,"version":2,"versionNonce":1797308683,"isDeleted":false,"text":"https://excalidraw.com/#json=5753229396672512,HuVR-T5hcB22xkoaUw1_rA","font":"20px Virgil","textAlign":"left","baseline":17}],"excalidraw-state":{"elementType":"selection","elementLocked":false,"exportBackground":true,"shouldAddWatermark":false,"currentItemStrokeColor":"#000000","currentItemBackgroundColor":"transparent","currentItemFillStyle":"hachure","currentItemStrokeWidth":1,"currentItemRoughness":1,"currentItemOpacity":100,"currentItemFont":"20px Virgil","currentItemTextAlign":"left","viewBackgroundColor":"#ffffff","scrollX":0,"scrollY":0,"cursorX":0,"cursorY":0,"cursorButton":"up","scrolledOutside":false,"name":"Untitled-2020-06-30-1957","username":"","zoom":1,"openMenu":null,"lastPointerDownWith":"mouse","selectedElementIds":{"WrEMSnYpiGbsXxbk_---6":true},"shouldCacheIgnoreZoom":false,"zenModeEnabled":false},"i18nextLng":"en"} ``` ### Sentry Error ID ddc0b9b5eaf641db96bf9990a26d3aa2
bug
low
Critical
648,661,517
youtube-dl
weibo site support
<!-- ###################################################################### WARNING! IGNORING THE FOLLOWING TEMPLATE WILL RESULT IN ISSUE CLOSED AS INCOMPLETE ###################################################################### --> ## Checklist <!-- Carefully read and work through this check list in order to prevent the most common mistakes and misuse of youtube-dl: - First of, make sure you are using the latest version of youtube-dl. Run `youtube-dl --version` and ensure your version is 2020.06.16.1. If it's not, see https://yt-dl.org/update on how to update. Issues with outdated version will be REJECTED. - Make sure that all provided video/audio/playlist URLs (if any) are alive and playable in a browser. - Make sure that site you are requesting is not dedicated to copyright infringement, see https://yt-dl.org/copyright-infringement. youtube-dl does not support such sites. In order for site support request to be accepted all provided example URLs should not violate any copyrights. - Search the bugtracker for similar site support requests: http://yt-dl.org/search-issues. DO NOT post duplicates. - Finally, put x into all relevant boxes (like this [x]) --> - [x] I'm reporting a new site support request - [x] I've verified that I'm running youtube-dl version **2020.06.16.1** - [x] I've checked that all provided URLs are alive and playable in a browser - [x] I've checked that none of provided URLs violate any copyrights - [ ] I've searched the bugtracker for similar site support requests including closed ones ## Example URLs <!-- Provide all kinds of example URLs support for which should be included. Replace following example URLs by yours. --> - Single video: https://www.weibo.com/tv/show/1034:4521639308623891?from=old_pc_videoshow - Single video: https://weibo.com/tv/show/1034:4521604705615885 more: https://weibo.com/tv/show/1034:4521591862657045?from=old_pc_videoshow https://www.weibo.com/tv/show/1034:4521632778092567?from=old_pc_videoshow ## Description <!-- Provide any additional information. If work on your issue requires account credentials please provide them or explain how one can obtain them. --> Here is the error log: ``` youtube-dl --cookies c:\cookies.txt https://www.weibo.com/tv/show/1034:4521639308623891?from=old_pc_videoshow [generic] 1034:4521639308623891?from=old_pc_videoshow: Requesting header WARNING: Falling back on generic information extractor. [generic] 1034:4521639308623891?from=old_pc_videoshow: Downloading webpage [generic] 1034:4521639308623891?from=old_pc_videoshow: Extracting information ERROR: Unsupported URL: https://www.weibo.com/tv/show/1034:4521639308623891?from=old_pc_videoshow ``` weibo is a very popular short video site. please add support. Much appreciated!
site-support-request
low
Critical
648,705,608
youtube-dl
https://www.loveliffathome.com/
<!-- ###################################################################### WARNING! IGNORING THE FOLLOWING TEMPLATE WILL RESULT IN ISSUE CLOSED AS INCOMPLETE ###################################################################### --> ## Checklist <!-- Carefully read and work through this check list in order to prevent the most common mistakes and misuse of youtube-dl: - First of, make sure you are using the latest version of youtube-dl. Run `youtube-dl --version` and ensure your version is 2020.06.16.1. If it's not, see https://yt-dl.org/update on how to update. Issues with outdated version will be REJECTED. - Make sure that all provided video/audio/playlist URLs (if any) are alive and playable in a browser. - Make sure that site you are requesting is not dedicated to copyright infringement, see https://yt-dl.org/copyright-infringement. youtube-dl does not support such sites. In order for site support request to be accepted all provided example URLs should not violate any copyrights. - Search the bugtracker for similar site support requests: http://yt-dl.org/search-issues. DO NOT post duplicates. - Finally, put x into all relevant boxes (like this [x]) --> - [x] I'm reporting a new site support request - [x] I've verified that I'm running youtube-dl version **2020.06.16.1** - [x] I've checked that all provided URLs are alive and playable in a browser - [ ] I've checked that none of provided URLs violate any copyrights - [ ] I've searched the bugtracker for similar site support requests including closed ones ## Example URLs <!-- Provide all kinds of example URLs support for which should be included. Replace following example URLs by yours. --> - Single video: https://www.youtube.com/watch?v=BaW_jenozKc - Single video: https://youtu.be/BaW_jenozKc - Playlist: https://www.youtube.com/playlist?list=PL4lCao7KL_QFVb7Iudeipvc2BCavECqzc ## Description <!-- Provide any additional information. If work on your issue requires account credentials please provide them or explain how one can obtain them. --> WRITE DESCRIPTION HERE Correct me if I'm unable to adhere to the norms of submitting a request (First time to github). **So, I'm trying to download a short movie from the link below,** https://www.loveliffathome.com/film/khidki-window/ **The command I'm passing is,** youtube-dl --cookies C:\Users\somes\Downloads\youtube-dl\cookies.txt --geo-bypass-country US https://www.loveliffathome.com/film/khidki-window/ **The error received for the command is mentioned below,** [generic] khidki-window: Requesting header WARNING: Falling back on generic information extractor. [generic] khidki-window: Downloading webpage [generic] khidki-window: Extracting information ERROR: Unsupported URL: https://www.loveliffathome.com/film/khidki-window/ **The movie is has a time-limit of 24 hours ending at 02:10 am (IST), i.e. after 12 hours.** _It would be really kind if someone could help me out._
site-support-request
low
Critical
648,738,904
react-native
After update to MIUI 12,Text is cut off
## Description After update to MIUI 12, Text is cut off. ![image](https://user-images.githubusercontent.com/3433961/86214160-5d766d00-bbad-11ea-9668-b11786bc8825.png) the actual text is QQ,but only Q is displayed ## React Native version: React Native version: 0.60.5 model: MI 10 Pro android:10 MIUI:12.0.1 Fingerprint -> Xiaomi/cmi/cmi:10/QKQ1.191117.002/V12.0.1.0.QJACNXM:user/release-keys ## Steps To Reproduce updrade XiaoMi Phone's system to MIUI 12 ## Expected Results full text is expected to display,like below ![image](https://user-images.githubusercontent.com/3433961/86214415-bfcf6d80-bbad-11ea-9e38-f1ed600d1840.png)
Component: Text,Needs: Triage :mag:
medium
Major
648,751,718
pytorch
Build pytorch with cuda11
I want to measure the performance of pytorch with cuda11. But looks magma is incompatible with CUDA11: https://bugs.archlinux.org/task/67094 I wonder if we can build pytorch with cuda11 now, or need to wait for magma support for CUDA 11? Will pytorch get bad performance magma MAGMA with CUDA 11? cc @malfet @ngimel
module: build,module: cuda,triaged
low
Critical
648,780,971
vscode
Quick open: Include symbols should not block the search based on filename
<!-- ⚠️⚠️ Do Not Delete This! bug_report_template ⚠️⚠️ --> <!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ --> <!-- Please search existing issues to avoid creating duplicates. --> <!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: https://code.visualstudio.com/insiders/ --> <!-- Use Help > Report Issue to prefill these. --> Version: 1.47.0-insider (user setup) Commit: b9d7ec9ff367a8e59fe4cc2abee605a55be180e8 Date: 2020-06-20T00:08:33.687Z Electron: 7.3.1 Chrome: 78.0.3904.130 Node.js: 12.8.1 V8: 7.8.279.23-electron.0 OS: Windows_NT x64 10.0.18363 Steps to Reproduce: 1. Open "search.quickOpen.includeSymbols" 2. Search(Ctrl+P) in a big project (for example, typescript) by filename 3. Expected: filename comes first, then the slow symbol search joins the result later. 4. Actual: The symbol search blocks the filename search and no results appear in a long time. <!-- Launch with `code --disable-extensions` to check. --> Does this issue occur when all extensions are disabled?: Yes
feature-request,workspace-symbols,quick-open
medium
Critical
648,818,286
material-ui
[MobileStepper] Add ability to maintain the 3 dots exactly at center of the whole stepper width, whatever is the width of "Back" and "Next"
<!-- Provide a general summary of the feature in the Title above --> In you demo page https://material-ui.com/components/steppers/#dots you use words "Back" and "Next", plus an icon for each, so the width of these buttons are exactly the same, so we see 3 dots exactly at middle of the Stepper container. But if you change the labels by let's say "Previous" and "Next" (or change locale of these labels), then the buttons width is not the same, and the 3 dots move a bit to the right and so they are not centered anymore with the whole Stepper container. <!-- Thank you very much for contributing to Material-UI by creating an issue! ❤️ To avoid duplicate issues we ask you to check off the following list. --> <!-- Checked checkbox should look like this: [x] --> - [x] I have searched the [issues](https://github.com/mui-org/material-ui/issues) of this repository and believe that this is not a duplicate. ## Summary 💡 <!-- Describe how it should work. --> You could add an option to let developer decide if dots should: * current behaviour: maintain exactly the same space between: ** `Back` to 3 dots (on the left side of stepper) ** 3 dots to `Next` (on the right side of stepper) OR * new behaviour: remain always at middle of stepper ## Examples 🌈 <!-- Provide a link to the Material design specification, other implementations, or screenshots of the expected behavior. --> ``` import MobileStepper from '@material-ui/core/MobileStepper'; export default function DotsCenteredMobileStepper() { ... return ( <MobileStepper ... variant="dots" dotPosition="centered" nextButton={ <Button ... > Next </Button> } backButton={ <Button ... > Back </Button> } /> ); } ``` ## Motivation 🔦 <!-- What are you trying to accomplish? How has the lack of this feature affected you? Providing context helps us come up with a solution that is most useful in the real world. --> This option would help to: * set dot position exactly at the middle of Stepper, so in some cases it could help container design, for example to do some alignment * maintain position of dots if Back/Next buttons label are changing during navigation through steps
new feature,component: stepper
low
Minor
648,838,288
rust
SIGSEGV when compiling for target wasm32-unknown-unknown with LLVM target feature 'multivalue'
I tried this code: ```rust pub fn f() -> ! { panic!(""); } ``` With compiler invocation: `rustc --crate-type lib mytest.rs --target wasm32-unknown-unknown -C target-feature=+multivalue` I expected to see this happen: no failure Instead, this happened: ``` Segmentation fault (core dumped) ``` ### Meta `rustc --version --verbose`: ``` rustc 1.46.0-nightly (16957bd4d 2020-06-30) binary: rustc commit-hash: 16957bd4d3a5377263f76ed74c572aad8e4b7e59 commit-date: 2020-06-30 host: x86_64-unknown-linux-gnu release: 1.46.0-nightly LLVM version: 10.0 ``` <details><summary>Backtrace</summary> <p> No backtrace. </p> </details> Can also be reproduced on godbolt with current nightly: https://godbolt.org/z/Pqg986 Also, there is no crash when the feature is not enabled (not mentioned at all or `-C target-feature=-multivalue`), or when I build with `-O`.
I-crash,E-needs-test,T-compiler,O-wasm,C-bug
low
Critical
648,852,377
godot
mouse_entered/exited signal not emitted on call to raise
<!-- Please search existing issues for potential duplicates before filing yours: https://github.com/godotengine/godot/issues?q=is%3Aissue --> **Godot version:** <!-- Specify commit hash if using non-official build. --> 3.2.2.stable **OS/device including version:** <!-- Specify GPU model, drivers, and the backend (GLES2, GLES3, Vulkan) if graphics-related. --> Ubuntu 19.10 OpenGL ES 3.0 Renderer: GeForce GTX 1660 Ti/PCIe/SSE2 **Issue description:** <!-- What happened, and what was expected. --> If you re-order control nodes (with raise or move_child) and if this results in the mouse pointer being over a different control node now the mouse_entered/exited signals are not emitted immediately. This only happens when you start to move the mouse. **Steps to reproduce:** See the uploaded project below. Place the mouse pointer in the overlapping area between the two panels. Then press X. This will raise the lower panel. The output in the debug console should be: > exited: Second Control > entered: First Control This indeed happens, but only after the mouse is moved. It should happen immediately instead. **Minimal reproduction project:** <!-- A small Godot project which reproduces the issue. Drag and drop a zip archive to upload it. --> [godot.zip](https://github.com/godotengine/godot/files/4857105/godot.zip)
bug,confirmed,topic:input,topic:gui
low
Critical
648,885,913
rust
Add SVH based symbol to dylibs
Any upstream dylib and executable can then require that symbol to be present to prevent mixing up different versions of a dylib at runtime. This symbol only needs to exist for dylibs, not cdylibs or rlibs. See https://internals.rust-lang.org/t/stability-of-dylibs-per-compiler-release/12648/10 for the discussion about this. @rustbot modify labels: +C-enhancement +T-compiler
C-enhancement,T-compiler
low
Major
648,894,126
youtube-dl
How to download subtitles only once?
<!-- ###################################################################### WARNING! IGNORING THE FOLLOWING TEMPLATE WILL RESULT IN ISSUE CLOSED AS INCOMPLETE ###################################################################### --> ## Checklist <!-- Carefully read and work through this check list in order to prevent the most common mistakes and misuse of youtube-dl: - Look through the README (http://yt-dl.org/readme) and FAQ (http://yt-dl.org/faq) for similar questions - Search the bugtracker for similar questions: http://yt-dl.org/search-issues - Finally, put x into all relevant boxes (like this [x]) --> - [x] I'm asking a question - [x] I've looked through the README and FAQ for similar questions - [x] I've searched the bugtracker for similar questions including closed ones ## Question <!-- Ask your question in an arbitrary form. Please make sure it's worded well enough to be understood, see https://github.com/ytdl-org/youtube-dl#is-the-description-of-the-issue-itself-sufficient. --> Hello guys. I'm downloading a video with subtitles using following parameters: youtube-dl -f 137,bestaudio --write-sub --write-auto-sub --all-subs myYTlink Since I'm downloading video and audio files separately, I've noticed youtube-dl downloads subtitles twice: First time - when download starts; Second time - when video download finishes and audio file download starts How can I fix this? Any advice is appreciated. I assume there is some syntax solution for this with []^ symbols.
question
low
Critical
648,900,831
terminal
Data URI scheme support for images in settings.json
# Description of the new feature/enhancement It would be great to be able to set image files (like `icon` or `backgroundImage`) in settings.json using data URI scheme. This could be useful when making backups or clones of Windows terminal settings, when syncing them with other devices, etc., especially when our custom profiles are concerned. # Proposed technical implementation details An example fragment from settings.json for a custom `icon`: ``` { "guid": "{7895828e-1e14-4068-89b4-582567b7495e}", "name": "MySQL", "commandline": "wsl.exe mysql -u username -p", "hidden": false, "icon": "data:image/png;base64,iVBORw0KG..............goAJRU5ErkJggg==" } ```
Help Wanted,Area-Settings,Product-Terminal,Issue-Task,Priority-2
low
Minor
648,927,566
flutter
iOS Notification center wrong AppLifecycleState triggered
## Steps to Reproduce <!-- You must include full steps to reproduce so that we can reproduce the problem. --> 1. Build a flutter app with a `WidgetsBindingObserver`. 2. If you open the notification center, `AppLifecycleState.resumed` is triggered. (Unexpected behaviour) 3. If you close the notification center `AppLifecycleState.resumed` is triggered. (Expected behaviour) 2. If you open the control center, `AppLifecycleState.inaktive` is triggered. (Expected behaviour) 3. If you close the control center `AppLifecycleState.resumed` is triggered. (Expected behaviour) The device I testet with was an `iPhone 11` with `iOS 13.5.1`. **Expected results:** Opening the notification center triggers `AppLifecycleState.inactive`. **Actual results:** Opening the notification center triggers `AppLifecycleState.resumed`.
platform-ios,engine,has reproducible steps,P2,found in release: 3.3,found in release: 3.6,team-ios,triaged-ios
low
Major
648,949,150
PowerToys
Command Line Accessible PowerToys Settings
# Summary of the new feature/enhancement Currently, PowerToys Settings can only be accessed by right-clicking the icon in the notification tray and choosing Settings. This creates a context switch for users who predominantly use the keyboard as they are required to reach for the mouse. I'd like to see a command-line option to access the PowerToys settings to accommodate these types of users. It also opens the option of using PowerToys without the need to have File Explorer running. # Proposed technical implementation details (optional) The primary option of fulfilling this request would be to make a simple executable available that invokes the PowerToys Settings applet but an alternative option may be to reuse the relaunch functionality of PowerToys to display the settings applet instead of currently displaying an error that an existing instance is already running.
Idea-Enhancement,Product-Settings
medium
Critical
648,987,545
opencv
Support palette-based images in imwrite (Compression does not seem to be working for PNG images)
##### System information (version) <!-- Example - OpenCV => 4.2 - Operating System / Platform => Windows 64 Bit - Compiler => Visual Studio 2017 --> - OpenCV => JavaCV version that I am using - 1.5.3 - Operating System / Platform => :grey_question: - Compiler => Java 11 ##### Detailed description I m trying to compress the PNG images , and have tried to use different COMPRESSION algorithm , but the image file size remains the same. The image I m using is https://upload.wikimedia.org/wikipedia/commons/d/d7/Astro_4D_stars_proper_radial_g_b_8mag_big.png Before resize length 1966656 After resize length IMWRITE_PNG_STRATEGY_HUFFMAN_ONLY - 6355730 After resize length IMWRITE_PNG_STRATEGY_FILTERED - 6355730 After resize length IMWRITE_PNG_STRATEGY_FIXED 6355730 After resize length IMWRITE_PNG_STRATEGY_RLE 6355730 The resizing(decreasing the dimension) is increasing the size of the image after the first log. ##### Steps to reproduce I am using Java for this- ``` resizeByThird(sourceImage: Path, destinationImage: Path) { val sourceImageMat = imread(sourceImage.toString()) val resizedImage = Mat() resize(sourceImageMat, resizedImage, Size(3840, 2208)) println(sourceImage.toFile().length()) val params: IntArray = intArrayOf(IMWRITE_PNG_STRATEGY_HUFFMAN_ONLY) imwrite(destinationImage.toString(), resizedImage, params) println(destinationImage.toFile().length()) } ``` I discussed this on the community channel- https://answers.opencv.org/question/231829/compression-algo-not-helpful-in-png-cases/ ##### Issue submission checklist - [ ] I report the issue, it's not a question <!-- OpenCV team works with answers.opencv.org, Stack Overflow and other communities to discuss problems. Tickets with question without real issue statement will be closed. --> - [ ] I checked the problem with documentation, FAQ, open issues, answers.opencv.org, Stack Overflow, etc and have not found solution <!-- Places to check: * OpenCV documentation: https://docs.opencv.org * FAQ page: https://github.com/opencv/opencv/wiki/FAQ * OpenCV forum: https://answers.opencv.org * OpenCV issue tracker: https://github.com/opencv/opencv/issues?q=is%3Aissue * Stack Overflow branch: https://stackoverflow.com/questions/tagged/opencv --> - [ ] I updated to latest OpenCV version and the issue is still there <!-- master branch for OpenCV 4.x and 3.4 branch for OpenCV 3.x releases. OpenCV team supports only latest release for each branch. The ticket is closed, if the problem is not reproduced with modern version. --> - [ ] There is reproducer code and related data files: videos, images, onnx, etc <!-- The best reproducer -- test case for OpenCV that we can add to the library. Recommendations for media files and binary files: * Try to reproduce the issue with images and videos in opencv_extra repository to reduce attachment size * Use PNG for images, if you report some CV related bug, but not image reader issue * Attach the image as archite to the ticket, if you report some reader issue. Image hosting services compress images and it breaks the repro code. * Provide ONNX file for some public model or ONNX file with with random weights, if you report ONNX parsing or handling issue. Architecture details diagram from netron tool can be very useful too. See https://lutzroeder.github.io/netron/ -->
feature,priority: low,category: imgcodecs
low
Critical
648,989,294
pytorch
Option to allow loading state dict with mismatching shapes.
## 🚀 Feature My proposal is to include a flag in `Module.load_state_dict` to allow loading of weights that have mismatching shapes. Similarly to the [`strict`](https://github.com/pytorch/pytorch/blob/master/torch/nn/modules/module.py#L939-L941) flag, it will allow loading of state dicts where there is a correspondence in weight names, but the weights might not all match. The weights that don't match are not loaded. ## Motivation My case where this is useful is object detection / segmentation. I often use an existing trained model as a starting point to train a new model (for example, using a Pascal VOC trained detection model to start training a COCO detection model). The names of the layers and weights are identical between the two models, but the number of classes and therefore the shapes of some weights are different. However copying all weights that do have matching shapes will help set a better starting point for training the new model. ## Pitch Best to show this PR : https://github.com/pytorch/pytorch/pull/39144 ## Alternatives Include this functionality in the existing `strict` flag. ## Additional context Note that I also added this to Keras and indirectly also in Tensorflow: https://www.tensorflow.org/api_docs/python/tf/keras/Model#load_weights There the flag is called `skip_mismatch`. cc @albanD @mruberry @jbschlosser @walterddr
module: nn,module: serialization,triaged,enhancement
high
Critical
649,011,994
rust
rustdoc: please show `doc` attribute info in search results
When showing the main listing of functions in a module the `doc` attribute info is shown in front of the short function description. However, when you use the search to filter to just functions with a particular substring, the listing of search results doesn't show that `doc` info. Please improve the search result display to show the additional info.
T-rustdoc,C-feature-request,A-rustdoc-search,F-doc_cfg
low
Minor
649,036,157
flutter
[google_maps_flutter] Add callback for click on google poi's on the map
It would be nice to have a callback when the user clicks a poi on the map. See: https://developers.google.com/maps/documentation/ios-sdk/reference/protocol_g_m_s_map_view_delegate-p#ac06974bfbebd2ff859b5f93c86fe3845 and https://developers.google.com/maps/documentation/android-sdk/reference/com/google/android/libraries/maps/GoogleMap.OnPoiClickListener
c: new feature,p: maps,package,c: proposal,team-ecosystem,P3,has partial patch,triaged-ecosystem
medium
Critical
649,040,805
opencv
INTER_CUBIC should default to Catmull-Rom interpolation
OpenCV currently hard codes [A=-0.75](https://github.com/opencv/opencv/blob/cf2a3c8e7430cc92569dd7f114609f9377b12d9e/modules/imgproc/src/resize.cpp#L909), which for some can results in some excessive ringing to give a pretence of sharpness. The Catmull-Rom cubic interpolation with A=-0.5 is the mathematically more correct choice, and a preferred one by many other image processing/computer graphics implementations of bicubic interpolation. See http://www.imagemagick.org/Usage/filter/#cubics for more discussion and more background [here](https://doi.org/10.1109/5.993400) and [here](https://doi.org/10.1109/42.7784). To enable original functionality, the 'A' parameter could also be exposed in the API. In any case, the documentation should be clear about what interpolation is meant by INTER_CUBIC, as it can be many different things.
feature,category: imgproc,category: documentation,effort: few weeks
low
Minor
649,057,746
vscode
Tweak peek inside notebooks
@isidorn had shared this with me a while back * have a notebook * run reference search or F8 for errors <img width="913" alt="Screenshot 2020-07-01 at 17 04 56" src="https://user-images.githubusercontent.com/1794099/86259989-ffea1c80-bbbc-11ea-8357-81be4fbd07c9.png"> Issues/suggestion: * there are many lines for peek and for the focus border * the peek editor has some whitespace at its left and right side * instead of lines we should experiment with more background color, e,g drop the outline and only use background
feature-request,ux,polish,notebook-cell-editor
low
Critical
649,083,032
storybook
ERROR TypeError: Class constructor EventEmitter_ cannot be invoked without 'new'
Hi @shilman , After upgrading to Angular 10, I am getting this error while displaying kendo grid on storybook - ERROR TypeError: Class constructor EventEmitter_ cannot be invoked without 'new' ![image](https://user-images.githubusercontent.com/20925856/86260499-a7ffe580-bbbd-11ea-9887-a7e71b55628b.png) Do you think this is because of incompatible version of storybook with Angular 10? If so, could you please suggest what version to use? Storybook version that I am using - 5.3.18 This can be reproduced here - https://github.com/aishwaryasharma14/grid.git Thanks in advance!
question / support,help wanted,has workaround,angular
low
Critical
649,101,000
vscode
Git - File watcher events should respect `.gitignore`
<!-- ⚠️⚠️ Do Not Delete This! bug_report_template ⚠️⚠️ --> <!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ --> <!-- Please search existing issues to avoid creating duplicates. --> <!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: https://code.visualstudio.com/insiders/ --> <!-- Use Help > Report Issue to prefill these. --> Version: 1.46.1 Commit: cd9ea6488829f560dc949a8b2fb789f3cdc05f5d Date: 2020-06-17T21:17:14.222Z Electron: 7.3.1 Chrome: 78.0.3904.130 Node.js: 12.8.1 V8: 7.8.279.23-electron.0 OS: Darwin x64 19.5.0 Steps to Reproduce: 1. This is an exact regression of https://github.com/Microsoft/vscode/issues/33309. All of the details filed there are found the bug I just experienced. I'm unable to reopen that bug, so filing a new one here. 2. The only way I've found to stop the repeated polling of git is to remove the additional workspace root(s) and only have one. <!-- Launch with `code --disable-extensions` to check. --> Does this issue occur when all extensions are disabled?: Yes
help wanted,feature-request,git
low
Critical
649,117,611
youtube-dl
Stop recording trough python
- [x] I'm asking a question - [x] I've looked through the README and FAQ for similar questions - [x] I've searched the bugtracker for similar questions including closed ones Im writing a python script, and for few hours I'm looking for a way to stop recording when a certain condition is fulfilled (if the file size is bigger then X mb or if variable == someting) but I didn't find a solution. Is ffmpeg just stops the thread until the stream is over or until I stop it menually?
question
low
Critical
649,124,230
TypeScript
Assertion function methods complains about missing annotation even with explicit annotation
This may be working as intended but the error message is at least unclear for this case. It's not obvious why explicit annotation with a Union is different than explicit annotation with a class type. **TypeScript Version:** 3.9.4 <!-- Search terms you tried before logging this (so others can find this issue more easily) --> **Search Terms:** - assertion function union - assertion function **Code** ```ts type Pet = Cat | Dog; type Filter<V extends Pet, T extends 'dog' | 'cat' > = V extends { type: T } ? V : never abstract class Base { abstract type: 'dog' | 'cat' assert<T extends 'dog' | 'cat'>(this: Pet, type: T): asserts this is Filter<Pet, T> { if (this.type === type) return throw new Error('nope') } } class Dog extends Base { type = 'dog' as const bark() { } } class Cat extends Base { type = 'cat' as const meow() { } } const a: Pet = new Dog() as any const b: Dog = new Dog() as any a.assert('dog') a.bark() b.assert('dog') b.bark() ``` **Expected behavior:** `a.assert()` to narrow the type and not complain about an explicit type annotation **Actual behavior:** `a.asserts` is marked as implicitly typed **Playground Link:** <!-- A link to a TypeScript Playground "Share" link which demonstrates this behavior --> https://www.typescriptlang.org/play/index.html?ssl=38&ssc=9&pln=3&pc=1#code/LAKFBcE8AcFMAIAKtzwLzwMIENUB94ARAewHMBuUCGBAMQEsAbcWAJwB4A1eWADxYB2AEwDOSFABp4AFR79YwsQHIhZJfAJKAxrnUA+dPG59Bo+AG94UOAC4Z8AL7wA-Efh2BsAG5sqIbABGIuCs2FqoWozYImIAQtEI5qDwKfCBwaHhVjR2Kmoa8Nq6qcnwpSnRImzg7LImCmZ5pOqaOuBKegAU4AAW9CJ2yOBS1rB20gCUdpXVYr398AsMzGzsQ1LSBhblqSn0AGbw3X0iAHSj6GgYoxPwrCgArqwCO7u9rMQA7vCe3wCirA+rE6SgExDgSgmOwcoBhYBA+weAnC9GIAjSMWq0hotTkpmUqmaBSK7S6XkGkmythkUwxVVY4DEXkWYmWLA46xkWySIF2ByOXnONEu1xot3u4CeL15qXeXx+sH+gOIwNB4NgkNhfkilSIZDxDTiCW2MpSFwwTXU0XgWjRwR2AWwrAA1p1bpY4U5dilQDqYlhcAbFPB4lUUjy3sKLW0rWJbQJ7ab4ABbWBfN0WRxa+G+u2obAU1AYX560gZ63YASQXMJ1ABOwkUiGEuN8tiSvV+HYU4zBkgwma-ynR0ut1+AI9zF9y1QkATkeu2dAA **Related Issues:** <!-- Did you find other bugs that looked similar? --> #36931 #37241
Suggestion,Awaiting More Feedback
low
Critical
649,124,999
rust
Formalize SVH stability for a specific release and target
The Rust compiler does a pretty good job at generating strict version hashes that are stable for a given combination of the compiler revision, target, and the inputs, disregarding extraneous variation like the absolute path of the build directory. This can be confirmed by a [test](https://github.com/mzabaluev/github-actions-playground/actions/runs/153838631). As outlined [in this discussion](https://internals.rust-lang.org/t/stability-of-dylibs-per-compiler-release/12648), if this stability is committed to as a feature, it would enable stabilized use of Rust dylib crates in revision-controlled sandbox environments like Flatpak.
A-linkage,T-compiler,C-feature-request,A-reproducibility
low
Minor
649,144,994
rust
Remove `fn pretty_printing_compatibility_hack `
https://github.com/rust-lang/rust/pull/73345 adds a hack to support some older versions of `proc-macro-hack` and `procedural-masquerade` which included incorrect asserts. The hack detects some specific enums used by those crates literally by their names and names of their variants. Using newer versions of those crates fixes the issues - `proc-macro-hack` requires a major version bump so it doesn't happen automatically - for `procedural-masquerade` only a bugfix version update is required, so `cargo update` should do the job, but the old version is fixed in hundreds of `Cargo.lock`s according to crater. This hack needs to be removed eventually. Now it's July 1 2020, so on July 1 2021 or later we need to run crater once more to estimate the use of these old versions again. Then we could assume that crates not updating from outdated versions for so long are not maintained and we can break them and remove the hack.
C-cleanup,A-pretty,A-macros,T-compiler,A-proc-macros,A-proc-macro-back-compat
low
Critical
649,149,002
pytorch
[JIT] Infer type of argument foo = None to be Optional[Tensor]
A pretty common pattern in PyTorch code is to write things like: ``` def forward(self, src, src_mask, tgt_in, pos=None): ``` (this example taken from `stanza/models/common/seq2seq_model.py` in https://github.com/stanfordnlp/stanza) When I script functions like this, I have to add the annotation `pos: Optional[Tensor]` manually. But it seems very modest and easy for JIT to extend its special case (where it default infers all arguments to be Tensor): if an argument has default argument None, then we infer its type to be Optional[Tensor]. cc @ezyang @gchanan @zou3519 @bdhirsh @jbschlosser @gmagogsfm @suo
high priority,triage review,oncall: jit
low
Major
649,167,163
pytorch
[JIT] cannot statically infer the expected size of a list in this context for positional arguments to Tensor.view()
This program doesn't work: ``` import torch.jit @torch.jit.script def f(x, y): return x.view(*y.size()) ``` however, if you remove the asterisk, it is ok. I have seen this in the wild as `x.view(20, *y.size())` as a convenient away to avoid tuple concatenation. The explicit tuple form works (`x.view((20,) + y.size())`) cc @suo @gmagogsfm
oncall: jit,weeks,TSUsability,TSRootCause:UnsupportedConstructs
low
Major
649,180,503
ant-design
DatePicker control - Narrator should announce dates or month when user navigate through calendar using keyboard
![calendar_accessibility](https://user-images.githubusercontent.com/64444288/86277637-e54b7f80-bb8b-11ea-87bd-11eb233481d8.PNG) - [x] I have searched the [issues](https://github.com/ant-design/ant-design/issues) of this repository and believe that this is not a duplicate. ### Reproduction link [![Edit on CodeSandbox](https://codesandbox.io/static/img/play-codesandbox.svg)](https://codesandbox.io/s/igmjw) ### Steps to reproduce 1. Open the code sandbox link 2. Start windows narrator 3. Navigate to DatePicker control using tab and hit enter which will open the calendar 4. Press tab and arrow keys to navigate through dates or month 5. It seems that narrator do not announce the dates or month in the calendar 6. Aria label needs be added in the calendar and windows narrator should announce the date or month when user navigate through calendar using keyboard. ### What is expected? Aria label needs be added in the calendar and windows narrator should announce the date or month when user navigate through each date or month using keyboard. ### What is actually happening? Windows narrator not announcing date or month in DatePicker control using keyboard. | Environment | Info | |---|---| | antd | 4.4.0 | | React | 16.12.0 | | System | Windows 10 | | Browser | Edge Version 81.0.416.72 (Official build) (64-bit) or Chorme Version 81.0.4044.138 (Official Build) (64-bit) | <!-- generated by ant-design-issue-helper. DO NOT REMOVE -->
Inactive,⌨️ Accessibility
low
Minor
649,190,271
flutter
Add Widget that recreates Scaffold's layout properties at the screen-level OR add built-in communication to update a Scaffold's layout properties
<!-- Thank you for using Flutter! If you are looking for support, please check out our documentation or consider asking a question on Stack Overflow: * https://flutter.dev/ * https://api.flutter.dev/ * https://stackoverflow.com/questions/tagged/flutter?sort=frequent If you have found a bug or if our documentation doesn't have an answer to what you're looking for, then fill our the template below. Please read our guide to filing a bug first: https://flutter.dev/docs/resources/bug-reports --> ## Use case The `Scaffold` widget's documentation clearly states that it is intended to be used as a top-level container for `MaterialApp`. As such, the Flutter team recommends updating the single `Scaffold` widget when changes are needed for the `AppBar`, `BottomNavigation`, `FloatingActionButton`, and `BottomSheet`. Right away this involves implementing a communication mechanism to be 'called' every-time a new screen is navigated to. I understand why having a single `Scaffold` makes sense as far as calls to ``` showSnackBar(), showBottomSheet(), ``` etc. However I feel like most developers end up using a `Stack` or some other layout widget when implementing screen-level FABs, AppBars, etc. either to save the trouble of implementing a communication mechanism to the top-level `Scaffold` or because it is a more direct solution. And some developers don't read the documentation altogether and just nest Scaffolds because they simply want the all-in-one layout capabilities it offers. <!-- Please tell us the problem you are running into that led to you wanting a new feature. Is your feature request related to a problem? Please give a clear and concise description of what the problem is. Describe alternative solutions you've considered. Is there a package on pub.dev/flutter that already solves this? --> ## Proposal Add a new widget that provides only the layout capabilities of a `Scaffold`, while not including the properties that require a `Scaffold` to be top-level. Something like this could be called a `ScreenFrame` and gives developers a proper way of 'nesting' this layout behaviour without needing to communicate with the app's primary `Scaffold`. ``` ScreenFrame( floatingActionButton: appBar: bottomSheet: bottomBar: body: ) ``` The main issue lies in the fact that an app's screens are not inherently constrained to a single set of these properties, yet Flutter adds screen-level properties to the `Scaffold` widget even though it is top-level. **If for some reason this is not possible or is considered an anti-pattern, I really believe there should be built-in functionality to communicate with the top-level Scaffold's layout widgets. For Example:** ``` Scaffold.of(context).setAppBar() Scaffold.of(context).setFAB() ``` <!-- Briefly but precisely describe what you would like Flutter to be able to do. Consider attaching images showing what you are imagining. Does this have to be provided by Flutter directly, or can it be provided by a package on pub.dev/flutter? If so, maybe consider implementing and publishing such a package rather than filing a bug. -->
c: new feature,framework,f: material design,c: proposal,P3,team-design,triaged-design
low
Critical
649,221,176
TypeScript
Officially document type checking behavior for operators WRT bigint
## Search Terms bigint operator type checking ## Suggestion I'd like to see official documentation of the design decision TS has made regarding type checking of operators now that bigint is in play. ## Use Cases The closure-compiler team is currently working on our support for BigInt. We want to make sure the type design choices we make there are compatible with TS going forward. It appears that right now when you perform an arithmetic operation on 2 `any` values, TS infers the result to be of type `number`, even in ESNext mode where one might expect the result to be `number|bigint`. https://www.typescriptlang.org/play/?target=99#code/DYUwLgBAhgXNB2BPCBeCBGeBuAUKSARnFEqhtnuBAMZwECWA5vfJGlBAFQQFZA I am inclined to do the same for closure-compiler, but I'd first like to make sure that this behavior was an intentional design choice for TS and not an oversight/bug that is likely to change in the near future. My point of view on this is that logically the `*` operator (for example) is overloaded, so there are really 2 versions of it. 1. The original `*` can take anything (except `bigint`), and always returns a `number`. 2. The new `bigint * bigint` version, which always returns a `bigint`, or throws an exception if one operand is not a `bigint`. The compiler should assume it's dealing with #1, unless type information indicates it is seeing #2. Insisting that all operands be clearly typed as `bigint` if you want `bigint` results prevents users from crossing the streams and accidentally mixing `bigint` and `number` values in computations. ## Examples 1. What is the result type of `bigint|number * bigint|number`? I expect `bigint|number` with no error message, since you may want to write methods that are intentionally meant to work for either case. 2. What is the result type of `bigint * any`? I expect the `bottom/can't happen` type, and an error message since we can't be sure that the right operand will be a `bigint` at runtime. 3. What is the result type of `any * any`? I expect `number` (current TS behavior), because it's undesirable for old code to suddenly think it might have a `bigint`, and new code should be explicit about using `bigint` to avoid runtime errors. ## Checklist My suggestion meets these guidelines: * [ X ] This wouldn't be a breaking change in existing TypeScript/JavaScript code * [ X ] This wouldn't change the runtime behavior of existing JavaScript code * [ X ] This could be implemented without emitting different JS based on the types of the expressions * [ X ] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.) * [ X ] This feature would agree with the rest of [TypeScript's Design Goals](https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals).
Discussion
low
Critical
649,224,616
flutter
[web] link to a Specific Line or Paragraph on a web page
<!-- Thank you for using Flutter! If you are looking for support, please check out our documentation or consider asking a question on Stack Overflow: * https://flutter.dev/ * https://api.flutter.dev/ * https://stackoverflow.com/questions/tagged/flutter?sort=frequent If you have found a bug or if our documentation doesn't have an answer to what you're looking for, then fill our the template below. Please read our guide to filing a bug first: https://flutter.dev/docs/resources/bug-reports --> ## Use case How do I get the ability to reference to a particular part of the page (a paragraph or a tab) in Flutter web. In traditional web url, this is made possible by anchoring the div to be references with a #. For e.g. in the link https://cloud.google.com/customers/featured/paypal#take-the-next-step, the link takes as directly to the div that is tagged as take-the-next-step Is there a way to do this in Flutter Web yet ? ## Proposal <!-- Briefly but precisely describe what you would like Flutter to be able to do. Consider attaching images showing what you are imagining. Does this have to be provided by Flutter directly, or can it be provided by a package on pub.dev/flutter? If so, maybe consider implementing and publishing such a package rather than filing a bug. -->
c: new feature,framework,platform-web,P3,team-web,triaged-web
low
Critical
649,244,245
pytorch
Allow TLS to keep distributed autograd context alive
As of today, we release the distributed autograd context when exiting the context manager: https://github.com/pytorch/pytorch/blob/c71ec1c717e5b225f28ef3bacde416c69f3c4d77/torch/distributed/autograd/__init__.py#L32-L37 As a result, the following code wouldn't work, as when running the `run_backward` callback function, the distributed autograd context might have been released. ```python class Model(nn.Module): def forward(self, x): return ps_rref.rpc_async().foward(x) with dist_autograd.context() as context_id: def run_backward(out_fut): dist_autograd.backward(context_id, [loss_fn(out_fut.wait(), label)] model(x).then(run_backward) ``` ### Pitch Instead of always releasing the distributed autograd context on exit the scope, we can manage its lifetime using a `shared_ptr` or other reference counting methods. Then, we can let the TLS own a copy of the `shared_ptr` to the context. So that callbacks can still access the context if necessary. Another option might be expanding `context_id` into a custom type whose lifetime dictates the distributed autograd context's lifetime. This feature will be useful to parallelize the backward pass in pipeline parallel applications. cc @pietern @mrshenli @pritamdamania87 @zhaojuanmao @satgera @gqchen @aazzolini @rohan-varma @xush6528 @jjlilley @osalpekar @jiayisuse
feature,triaged,module: rpc
low
Minor
649,302,589
pytorch
JIT fuser result of dropout doesn't fully match eager mode
Running this test with legacy executor should repro: ``` def test_dropout_cuda(self): # Dropout AD is dispatched to _fused_dropout in CUDA case, # which is not included in TestJitGeneratedFunctional x = torch.ones((4, 4)).cuda().requires_grad_() with enable_profiling_mode_for_profiling_tests(): @torch.jit.script def func(x): return torch.nn.functional.dropout(x) with freeze_rng_state(): out = func(x) #grad = torch.autograd.grad(out.sum(), x) with freeze_rng_state(): out_ref = torch.nn.functional.dropout(x) #grad_ref = torch.autograd.grad(out_ref.sum(), x) print("out=", out) print("out_ref=",out_ref) self.assertEqual(out, out_ref) self.assertEqual(grad, grad_ref) ``` cc: @ngimel @Krovatkin cc @suo @gmagogsfm
oncall: jit,triaged
low
Minor
649,321,647
flutter
[video_player] [RFC] Add "muted" attribute to Video Player API?
For videos to auto-play on the web, they must start "muted". The current video player platform interface API does not have a direct way of setting a "muted" attribute [other than assuming that volume 0.0 means "muted"](https://github.com/flutter/plugins/pull/2819#discussion_r437626495). Does the Video Player plugin need a "muted" attribute, as mentioned in the discussion above? Or is the web workaround "acceptable"?
c: new feature,p: video_player,package,team-ecosystem,P3,triaged-ecosystem
low
Major
649,328,367
TypeScript
Add refactoring option to convert between function declaration and function variable
<!-- 🚨 STOP 🚨 𝗦𝗧𝗢𝗣 🚨 𝑺𝑻𝑶𝑷 🚨 Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Please help us by doing the following steps before logging an issue: * Search: https://github.com/Microsoft/TypeScript/search?type=Issues * Read the FAQ, especially the "Common Feature Requests" section: https://github.com/Microsoft/TypeScript/wiki/FAQ --> ## Search Terms - refactor function declaration - refactor to arrow function ## Suggestion <!-- A summary of what you'd like to see added or changed --> Consider adding refactoring from ```ts const fn = (x: number): number => { return x + 1 } ``` into ```ts function fn(x: number): number { return x + 1 } ``` and vice-versa. ## Use Cases <!-- What do you want to use this for? What shortcomings exist with current approaches? --> I found myself doing this refactor by hand many times. I think the main use cases are: * Project has code style which enforces one of the above, and you're pasting some other code. * Particular function declaration simply looks better when written as block-less arrow function. * After refactoring an arrow function to a variable in current scope, it always picks the arrow style, but it could be written as a declaration as well. ## Examples <!-- Show how this would be used and what the behavior would be --> Don't know if viable, but here it goes: ```tsx export const Component: React.FC<Props> = props => { return <h1>Hello, {props.name}</h1> } export function Component(props: Props) { return <h1>Hello, {props.name}</h1> } ``` ## Checklist My suggestion meets these guidelines: * [x] This wouldn't be a breaking change in existing TypeScript/JavaScript code * [x] This wouldn't change the runtime behavior of existing JavaScript code * [x] This could be implemented without emitting different JS based on the types of the expressions * [x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.) * [x] This feature would agree with the rest of [TypeScript's Design Goals](https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals).
Suggestion,Awaiting More Feedback
low
Critical
649,333,504
go
runtime: idle GC interferes with auto-scaling
### What version of Go are you using (`go version`)? <pre> $ go version go version go1.14 linux/amd64 </pre> But this has been true for years. ### What did you do? Run a mostly-idle application in a container with CPU limits under a mechanism that monitors CPU use and increases the job's CPU reservation if it appears to be too little. Specifically, this was observed with a latency-sensitive policy that looked at high percentile usage sampled over a short time period. ### What did you expect to see? Since the application is mostly idle, a small CPU reservation should be adequate and the auto-scaler should not need to grow that reservation. ### What did you see instead? Because the garbage collector attempts to use any idle cores up to GOMAXPROCS, even an otherwise mostly idle application will see periodic spikes of CPU activity. These will happen at least every 2 minutes if not more frequently. In this case, the auto-scaler's policy was sensitive enough that these spikes caused it to grow the job's CPU reservation. However, then the garbage collector uses all of the new CPU reservation. This leads to a feedback cycle where the auto-scaler continually grows the reservation. See also #17969, https://github.com/golang/go/issues/14812#issuecomment-518902192. /cc @mknyszek ### Thoughts We've been thinking for a while now that idle GC may be more trouble than it's worth. The idea was to speed up the mark phase, so the write barrier is on for less time and we allocate black for less time. However, if an application is mostly idle, then it's not very sensitive to the (very small) performance impact of the write barrier and probably doesn't produce much floating garbage from allocate-black; and if an application isn't mostly idle, then it's not benefiting from idle GC anyway.
NeedsDecision,compiler/runtime
medium
Major
649,338,073
pytorch
Improve error messaging when using dictionaries as inputs to a trace
## 🚀 Feature ## Motivation The JIT tracer supports using dictionaries as input, like: ``` import torch from typing import Dict class TestModule(torch.nn.Module): def __init__(self): super(TestModule, self).__init__() def forward(self, dict_input): return dict_input['x'] input_1 = {'x': torch.tensor(1)} m = TestModule() m_traced = torch.jit.trace(m, (input_1, )) ``` However, the tracer "burns in" the structure of the dict (more precisely, it inlines all keys as constants and burns in the value types). The resulting graph looks like: ``` graph(%self : __torch__.TestModule, %2 : Dict(str, Tensor)): %3 : str = prim::Constant[value="x"]() %4 : Long() = aten::__getitem__(%2, %3) return (%4) ``` If you try to use a dictionary with a different key, you will get a very opaque error message ``` input_2 = {'y': torch.tensor(1)} m_traced(input_2) Traceback (most recent call last): File "/private/home/suo/scratch/test.py", line 27, in <module> m_traced(input_2) File "/scratch/suo/pytorch/torch/nn/modules/module.py", line 722, in _call_impl result = self.forward(*input, **kwargs) RuntimeError: The following operation failed in the TorchScript interpreter. Traceback of TorchScript (most recent call last): /scratch/suo/pytorch/torch/jit/__init__.py(1108): trace_module /scratch/suo/pytorch/torch/jit/__init__.py(954): trace /private/home/suo/scratch/test.py(24): <module> RuntimeError: KeyError: x ``` We ought to improve the error messaging here, with reference to the expected structure and how it's different from the structure the user passed in. cc @suo @gmagogsfm
oncall: jit,triaged,enhancement
low
Critical
649,351,637
youtube-dl
Unsupported URL on vod.canalplus.com
<!-- ###################################################################### WARNING! IGNORING THE FOLLOWING TEMPLATE WILL RESULT IN ISSUE CLOSED AS INCOMPLETE ###################################################################### --> ## Checklist <!-- Carefully read and work through this check list in order to prevent the most common mistakes and misuse of youtube-dl: - First of, make sure you are using the latest version of youtube-dl. Run `youtube-dl --version` and ensure your version is 2020.06.16.1. If it's not, see https://yt-dl.org/update on how to update. Issues with outdated version will be REJECTED. - Make sure that all provided video/audio/playlist URLs (if any) are alive and playable in a browser. - Make sure that all URLs and arguments with special characters are properly quoted or escaped as explained in http://yt-dl.org/escape. - Search the bugtracker for similar issues: http://yt-dl.org/search-issues. DO NOT post duplicates. - Finally, put x into all relevant boxes (like this [x]) --> - [x] I'm reporting a broken site support - [x] I've verified that I'm running youtube-dl version **2020.06.16.1** - [x] I've checked that all provided URLs are alive and playable in a browser - [x] I've checked that all URLs and arguments with special characters are properly quoted or escaped - [x] I've searched the bugtracker for similar issues including closed ones ## Verbose log <!-- Provide the complete verbose output of youtube-dl that clearly demonstrates the problem. Add the `-v` flag to your command line you run youtube-dl with (`youtube-dl -v <your command line>`), copy the WHOLE output and insert it below. It should look similar to this: [debug] System config: [] [debug] User config: [] [debug] Command-line args: [u'-v', u'http://www.youtube.com/watch?v=BaW_jenozKcj'] [debug] Encodings: locale cp1251, fs mbcs, out cp866, pref cp1251 [debug] youtube-dl version 2020.06.16.1 [debug] Python version 2.7.11 - Windows-2003Server-5.2.3790-SP2 [debug] exe versions: ffmpeg N-75573-g1d0487f, ffprobe N-75573-g1d0487f, rtmpdump 2.4 [debug] Proxy map: {} <more lines> --> ``` [debug] System config: [] [debug] User config: [] [debug] Custom config: [] [debug] Command-line args: ['-v', '-u', 'PRIVATE', '-p', 'PRIVATE', 'https://vod.canalplus.com/cinema/au-dela-des-cimes/h/433703_40099'] [debug] Encodings: locale UTF-8, fs utf-8, out UTF-8, pref UTF-8 [debug] youtube-dl version 2020.06.16.1 [debug] Python version 3.7.3 (CPython) - Darwin-19.0.0-x86_64-i386-64bit [debug] exe versions: rtmpdump 2.4 [debug] Proxy map: {} [generic] 433703_40099: Requesting header WARNING: Falling back on generic information extractor. [generic] 433703_40099: Downloading webpage [generic] 433703_40099: Extracting information ERROR: Unsupported URL: https://vod.canalplus.com/cinema/au-dela-des-cimes/h/433703_40099 Traceback (most recent call last): File "/Users/Malik/anaconda3/lib/python3.7/site-packages/youtube_dl/YoutubeDL.py", line 797, in extract_info ie_result = ie.extract(url) File "/Users/Malik/anaconda3/lib/python3.7/site-packages/youtube_dl/extractor/common.py", line 530, in extract ie_result = self._real_extract(url) File "/Users/Malik/anaconda3/lib/python3.7/site-packages/youtube_dl/extractor/generic.py", line 3382, in _real_extract raise UnsupportedError(url) youtube_dl.utils.UnsupportedError: Unsupported URL: https://vod.canalplus.com/cinema/au-dela-des-cimes/h/433703_40099 ``` ## Description <!-- Provide an explanation of your issue in an arbitrary form. Provide any additional information, suggested solution and as much context and examples as possible. If work on your issue requires account credentials please provide them or explain how one can obtain them. --> I had to use my credentials in order to play, and therefore to try to download the video. Thanks.
geo-restricted,account-needed
low
Critical
649,393,433
tensorflow
“Layer is not connected” issue while accessing intermediate layer from custom callback if model is built by sub-classing
**System information** - Have I written custom code (as opposed to using a stock example script provided in TensorFlow): Yes - OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Linux Ubuntu 18.04.2 LTS - Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device: N/A - TensorFlow installed from (source or binary): Binary - TensorFlow version (use command below): v2.2.0-rc4-8-g2b96f3662b 2.2.0 - Python version: Python 3.7.3 - Bazel version (if compiling from source): N/A - GCC/Compiler version (if compiling from source): N/A - CUDA/cuDNN version: CUDA 10.2 - GPU model and memory: NVIDIA TITAN X (Pascal), ~12GB **Describe the current behavior** I've a simple model and need access of intermediate layers within a custom callback to get intermediate predictions. If I build the model by sub-classing, I get the error `AttributeError: Layer dense is not connected`. **Describe the expected behavior** It shouldn't cause any error and be able to get predictions using intermediate layers. **Standalone code to reproduce the issue** ``` import tensorflow as tf import numpy as np X = np.ones((8,16)) y = np.sum(X, axis=1) class CustomCallback(tf.keras.callbacks.Callback): def on_epoch_end(self, epoch, logs=None): get_output = tf.keras.backend.function( inputs = self.model.layers[0].input, outputs = self.model.layers[1].output ) print("\nLayer output: ", get_output(X)) class Model(tf.keras.Model): def build(self, input_shape): self.dense1 = tf.keras.layers.Dense(units=32) self.dense2 = tf.keras.layers.Dense(units=1) def call(self, input_tensor): x = self.dense1(input_tensor) x = self.dense2(x) return x model = Model() model.compile(optimizer='adam',loss='mean_squared_error', metrics='accuracy') model.fit(X,y, epochs=2, callbacks=[CustomCallback()]) ``` **Other info / logs** Traceback: ```--------------------------------------------------------------------------- AttributeError Traceback (most recent call last) <ipython-input-3-dd6e118e08d6> in <module> 11 model = Model() 12 model.compile(optimizer='adam',loss='mean_squared_error', metrics='accuracy') ---> 13 model.fit(X,y, epochs=2, callbacks=[CustomCallback()]) /opt/anaconda3/envs/brats/lib/python3.7/site-packages/tensorflow/python/keras/engine/training.py in _method_wrapper(self, *args, **kwargs) 64 def _method_wrapper(self, *args, **kwargs): 65 if not self._in_multi_worker_mode(): # pylint: disable=protected-access ---> 66 return method(self, *args, **kwargs) 67 68 # Running inside `run_distribute_coordinator` already. /opt/anaconda3/envs/brats/lib/python3.7/site-packages/tensorflow/python/keras/engine/training.py in fit(self, x, y, batch_size, epochs, verbose, callbacks, validation_split, validation_data, shuffle, class_weight, sample_weight, initial_epoch, steps_per_epoch, validation_steps, validation_batch_size, validation_freq, max_queue_size, workers, use_multiprocessing) 874 epoch_logs.update(val_logs) 875 --> 876 callbacks.on_epoch_end(epoch, epoch_logs) 877 if self.stop_training: 878 break /opt/anaconda3/envs/brats/lib/python3.7/site-packages/tensorflow/python/keras/callbacks.py in on_epoch_end(self, epoch, logs) 363 logs = self._process_logs(logs) 364 for callback in self.callbacks: --> 365 callback.on_epoch_end(epoch, logs) 366 367 def on_train_batch_begin(self, batch, logs=None): <ipython-input-2-a1f33c1e2e52> in on_epoch_end(self, epoch, logs) 8 def on_epoch_end(self, epoch, logs=None): 9 get_output = tf.keras.backend.function( ---> 10 inputs = self.model.layers[0].input, 11 outputs = self.model.layers[1].output 12 ) /opt/anaconda3/envs/brats/lib/python3.7/site-packages/tensorflow/python/keras/engine/base_layer.py in input(self) 1806 if not self._inbound_nodes: 1807 raise AttributeError('Layer ' + self.name + -> 1808 ' is not connected, no input to return.') 1809 return self._get_node_attribute_at_index(0, 'input_tensors', 'input') 1810 AttributeError: Layer dense is not connected, no input to return. ``` If I build the model using functional API as shown below, it works fine: ``` initial = tf.keras.layers.Input((16,)) x = tf.keras.layers.Dense(units=32)(initial) final = tf.keras.layers.Dense(units=1)(x) model = tf.keras.Model(initial, final) model.compile(optimizer='adam',loss='mean_squared_error', metrics='accuracy') model.fit(X,y, epochs=2, callbacks=[CustomCallback()]) ``` [Here's](https://stackoverflow.com/q/62668398/2679778) the stackoverflow question I created on the same issue.
stat:awaiting tensorflower,type:bug,comp:keras,TF 2.11
low
Critical
649,423,223
PowerToys
Trigger FancyZone for windows that are dragged not by the TitleBar.
# Summary of the new feature/enhancement I have the script at my PC, written on AutoHotkey, which allows me to Move Windows using Any It Parts. This functionality mapped to Middle Mouse Button. FancyZone feature works only if I drag window by TitleBar. It would be nice if we could make it work with any dragged window. Not sure if it possible at all, but may be you have some ideas.
Idea-Enhancement,Product-FancyZones,Issue-DCR
low
Minor
649,423,555
vscode
Git - Timeline produces confusing results on with merged branch
I just merged a branch into another branch, then looked at a change in the Timeline view. I was confused that it shows a diff that doesn't match what that commit should have had, but I think it makes sense if it is diffing that version of the file with the previous commit that shows in the flattened view in the Timeline. (where the previous commit is not actually the parent commit of the one I'm looking at). If I look at the commit history in gitlens and look at that commit/file, I see the expected diff. Is that by design?
bug,git,timeline,timeline-git
low
Minor
649,435,069
pytorch
[FR] torch.floor/ceil should support output int dtype
``` In [21]: x Out[21]: tensor([[2, 0, 1], [1, 2, 2]]) In [22]: torch.floor(torch.randn(2,3)*10, out=x) --------------------------------------------------------------------------- RuntimeError Traceback (most recent call last) <ipython-input-22-d7f2bdd35edf> in <module> ----> 1 torch.floor(torch.randn(2,3)*10, out=x) RuntimeError: result type Float can't be cast to the desired output type Long ``` Ideally, a `dtype` option should also be added. cc @nairbv
triaged,enhancement,module: type promotion
low
Critical
649,525,948
vscode
[themes] 'Generate Color Theme From Current Settings' omits semantic token settings
Issue Type: <b>Bug</b> 1. Launch the semantic-tokens-sample extension. 2. Follow the README.md instructions to add `editor.semanticTokenColorCustomizations` to your settings. 3. Run the `Developer: Generate Color Theme From Current Settings` command. 4. Review the generated color theme document but find no sign of your semantic token color customizations. VS Code version: Code - Insiders 1.47.0-insider (b16b467d3e03e1a1ae05b5836e4e5a5af504e86d, 2020-07-01T05:32:07.483Z) OS version: Windows_NT x64 10.0.18363 <!-- generated by issue reporter -->
feature-request,themes
low
Critical
649,619,800
terminal
Something wrong with the vim colorshemes
<!-- 🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨 I ACKNOWLEDGE THE FOLLOWING BEFORE PROCEEDING: 1. If I delete this entire template and go my own path, the core team may close my issue without further explanation or engagement. 2. If I list multiple bugs/concerns in this one issue, the core team may close my issue without further explanation or engagement. 3. If I write an issue that has many duplicates, the core team may close my issue without further explanation or engagement (and without necessarily spending time to find the exact duplicate ID number). 4. If I leave the title incomplete when filing the issue, the core team may close my issue without further explanation or engagement. 5. If I file something completely blank in the body, the core team may close my issue without further explanation or engagement. All good? Then proceed! --> <!-- This bug tracker is monitored by Windows Terminal development team and other technical folks. **Important: When reporting BSODs or security issues, DO NOT attach memory dumps, logs, or traces to Github issues**. Instead, send dumps/traces to [email protected], referencing this GitHub issue. If this is an application crash, please also provide a Feedback Hub submission link so we can find your diagnostic data on the backend. Use the category "Apps > Windows Terminal (Preview)" and choose "Share My Feedback" after submission to get the link. Please use this form and describe your issue, concisely but precisely, with as much detail as possible. --> # Environment ```none Windows build number: 10.0.19042.0 Windows Terminal version (if applicable): 1.0.1811.0 VIM: 8.2 ``` # Steps to reproduce <!-- A description of how to trigger this bug. --> I installed [onedark.vim](https://github.com/joshdick/onedark.vim) colorscheme for vim. But the colorscheme doesn't work correctly as I saw on my Mac. By the way, I am using the Terminal colorscheme `snazzy`. Here's it's config: ```json { "name": "Snazzy", "black": "#000000", "red": "#fc4346", "green": "#50fb7c", "yellow": "#f0fb8c", "blue": "#49baff", "purple": "#fc4cb4", "cyan": "#8be9fe", "white": "#ededec", "brightBlack": "#555555", "brightRed": "#fc4346", "brightGreen": "#50fb7c", "brightYellow": "#f0fb8c", "brightBlue": "#49baff", "brightPurple": "#fc4cb4", "brightCyan": "#8be9fe", "brightWhite": "#ededec", "background": "#1e1f29", "foreground": "#ebece6" } ``` ```json "acrylicOpacity": 0.7, "colorScheme" : "Snazzy", "cursorColor" : "#000000", "fontFace" : "MesloLGL Nerd Font", "useAcrylic": true ``` # Expected behavior <!-- A description of what you're expecting, possibly containing screenshots or reference material. --> This is what `onedark.vim` really looks like: ![](https://raw.githubusercontent.com/joshdick/onedark.vim/master/img/readme_header.png) # Actual behavior <!-- What's actually happening? --> But it looks like this here: ![image](https://user-images.githubusercontent.com/25583228/86315265-49d60f80-bc5c-11ea-83a9-532e27284362.png)
Resolution-External,Area-VT,Issue-Bug,Product-Terminal,Priority-3
low
Critical
649,619,940
TypeScript
@deprecated strikethrough doesn't appear in many cases, such as JSX elements, const arrow functions, or properties.
**TypeScript Version:** 4.0.0-dev.20200701 **VS Code Version:** 1.47.0-insider commit: b16b467d3e **Search Terms:** deprecated **Code** ```ts /** @deprecated */ type Props = { /** @deprecated */ old: string, new: string, } /** @deprecated */ const Component = (props: Props) => <div />; <Component old="old" new="new" /> /** @deprecated */ type Options = { /** @deprecated */ old: string; new: string; } /** @deprecated */ const deprecatedFunction = (options: Options) => {} deprecatedFunction({ old: "", new: "hi", }); ``` **Expected behavior:** All deprecated usages have strikethrough styles: `<Component>`, the `old` prop on `Component`, `deprecatedFunction`, `old` **Actual behavior:** Only `props` and `options` have strikethrough styles. ![Screenshot - 7_1_2020 , 9_07_19 PM](https://user-images.githubusercontent.com/1399894/86315427-f5d91580-bbde-11ea-9ba5-2e405358b809.png) **Playground Link:** <!-- A link to a TypeScript Playground "Share" link which demonstrates this behavior --> Strikethrough isn't visible here, but `...` is (just like stable VS Code vs. Insiders). https://www.typescriptlang.org/play/?jsx=2&ts=4.0.0-beta&ssl=29&ssc=1&pln=1&pc=1#code/JYWwDg9gTgLgBAJQKYEMDG8BmUIjgIilQ3wG4AocgegCoa4ABAEyTCLRRiSbhqvJgBPMEjgAFHGADOcALxwA3uThxa9Zq3aduvfiogAbJgC44UmFGAA7AOYAaZXCtIA7qfOXbDgL6U1jFjYkDi4ePnI0CCtzOABhXEhnK3h5AAo2CGlTCUypAEo5AD44AB4mYAA3VUKKchL48CikZLhDJll8NvwnVw7nF26qQr86AM1g7TD+IRE4AHkwGGAomXklFX8NIJCdcP0jdwtrGwoVfsPPE-JfalGtrVDdCJX4QIfuADEAVysMZas5HBUpklitTAtQdECrJigobm8JqFvr9Ial1q0DgR8A4zq5TPgABbAbHXPIUIA **Related Issues:** None (feature is new to 4.0)
Bug,Fix Available,Rescheduled
medium
Critical
649,631,142
opencv
OpenCV with OpenCL on i.mx6quad plus(arm cortex a9)
##### System information (version) - OpenCV => 4.3 - Operating System / Platform => Linux version 4.9.11 - Compiler => arm-poky-linux-gnueabi-g++ - Operating System / Platform => i.mx6 quad plus sabresd ##### Detailed description Hi I build OpenCV-4.3.0 as shown below ``` General configuration for OpenCV 4.3.0 ===================================== Version control: unknown Extra modules: Location (extra): /home/sonic/opencv/opencv_contrib-4.3.0/modules Version control (extra): unknown Platform: Timestamp: 2020-04-17T00:27:08Z Host: Linux 4.15.0-96-generic x86_64 Target: Linux 1 arm CMake: 3.10.2 CMake generator: Unix Makefiles CMake build tool: /usr/bin/make Configuration: Release CPU/HW features: Baseline: VFPV3 NEON requested: DETECT required: VFPV3 NEON C/C++: Built as dynamic libs?: YES C++ standard: 11 C++ Compiler: /opt/fsl-imx-fb/3.14.52-1.1.1/sysroots/i686-pokysdk-linux/usr/bin/arm-poky-linux-gnueabi/arm-poky-linux-gnueabi-g++ (ver 4.9.2) C++ flags (Release): --sysroot=/opt/fsl-imx-fb/3.14.52-1.1.1/sysroots/cortexa9hf-vfp-neon-poky-linux-gnueabi -march=armv7-a -mfpu=neon -mfloat-abi=hard -mcpu=cortex-a9 --sysroot=/opt/fsl-imx-G C++ flags (Debug): --sysroot=/opt/fsl-imx-fb/3.14.52-1.1.1/sysroots/cortexa9hf-vfp-neon-poky-linux-gnueabi -march=armv7-a -mfpu=neon -mfloat-abi=hard -mcpu=cortex-a9 --sysroot=/opt/fsl-imx-G C Compiler: /opt/fsl-imx-fb/3.14.52-1.1.1/sysroots/i686-pokysdk-linux/usr/bin/arm-poky-linux-gnueabi/arm-poky-linux-gnueabi-gcc C flags (Release): --sysroot=/opt/fsl-imx-fb/3.14.52-1.1.1/sysroots/cortexa9hf-vfp-neon-poky-linux-gnueabi -march=armv7-a -mfpu=neon -mfloat-abi=hard -mcpu=cortex-a9 --sysroot=/opt/fsl-imx-G C flags (Debug): --sysroot=/opt/fsl-imx-fb/3.14.52-1.1.1/sysroots/cortexa9hf-vfp-neon-poky-linux-gnueabi -march=armv7-a -mfpu=neon -mfloat-abi=hard -mcpu=cortex-a9 --sysroot=/opt/fsl-imx-G Linker flags (Release): -Wl,--gc-sections -Wl,--as-needed Linker flags (Debug): -Wl,--gc-sections -Wl,--as-needed ccache: NO Precompiled headers: NO Extra dependencies: dl m pthread rt 3rdparty dependencies: OpenCV modules: To be built: aruco bgsegm bioinspired calib3d ccalib core datasets dnn dnn_objdetect dnn_superres dpm face features2d flann fuzzy gapi hfs highgui img_hash imgcodecs imgproc intensityo Disabled: world Disabled by dependency: - Unavailable: alphamat cnn_3dobj cudaarithm cudabgsegm cudacodec cudafeatures2d cudafilters cudaimgproc cudalegacy cudaobjdetect cudaoptflow cudastereo cudawarping cudev cvv freetype hz Applications: perf_tests apps Documentation: NO Non-free algorithms: YES GUI: GTK+: NO Media I/O: ZLib: build (ver 1.2.11) JPEG: libjpeg-turbo (ver 2.0.4-62) WEBP: build (ver encoder: 0x020f) PNG: build (ver 1.6.37) TIFF: build (ver 42 - 4.0.10) JPEG 2000: build Jasper (ver 1.900.1) HDR: YES SUNRASTER: YES PXM: YES PFM: YES Video I/O: DC1394: NO FFMPEG: NO avcodec: NO avformat: NO avutil: NO swscale: NO avresample: NO GStreamer: NO v4l/v4l2: YES (linux/videodev2.h) Parallel framework: pthreads Trace: YES (with Intel ITT) Other third-party libraries: Lapack: NO Custom HAL: YES (carotene (ver 0.0.1)) Protobuf: build (3.5.1) OpenCL: YES (no extra features) Include path: /home/sonic/opencv/opencv-4.3.0-i.mx6/3rdparty/include/opencl/1.2 Link libraries: Dynamic load Python (for build): /usr/bin/python2.7 Install to: /home/sonic/opencv/opencv-4.3.0-i.mx6/build/install ``` My first question , Is the "Target: Linux 1 arm" means 1 core? My processor has quad core. If it means 1 core. I want to use quad core. what shold I do? And I installed opencv-4.3.0 on my board. it works well except when using OpenCL. Here are OpenCL information as shown below ``` - Device 0 --- Name : Vivante OpenCL Device GC3000.5450.0000 Availability : 1 Image Support : 1 OpenCL C version : OpenCL C 1.1 ``` my code ``` const string tensorflowConfigFile = "models/ssdlite_mobilenet_v3_face_graph.pbtxt"; const string tensorflowWeightFile = "models/ssdlite_mobilenet_v3_face_frozen_inference_graph.pb"; int FACE_CNN_INPUT_SIZE = 140; int cam = 0; int main (int argc, char **argv){ Net face_net = readNetFromTensorflow(tensorflowWeightFile, tensorflowConfigFile); VideoCapture cap(cam); cap.set(CAP_PROP_FRAME_WIDTH, 640); Mat frame; UMat resized_img; double tt_send = 0; if(!ocl::haveOpenCL()) { cout << "can not use OpenCL" << endl; } ocl::Context context; if(!context.create(ocl::Device::TYPE_GPU)) { cout << " can not create context" << endl; } cout << context.ndevices() << "GPU device (s) detected" << endl; for(size_t i = 0; i < context.ndevices(); i++) { ocl::Device device = context.device(i); cout << "- Device " << i << " ---" << endl; cout << "Name : " << device.name() << endl; cout << "Availability : " << device.available() << endl; cout << "Image Support : " << device.imageSupport() << endl; cout << "OpenCL C version : " << device.OpenCL_C_Version() << endl; } ocl::Device(context.device(0)); ocl::setUseOpenCL(true); cout << getBuildInformation().c_str() << endl; while(cap.isOpened()){ double t = getTickCount(); cap >> frame; if(frame.empty()) break; flip(frame, frame, 1); resize(frame, frame, Size(FACE_CNN_INPUT_SIZE,FACE_CNN_INPUT_SIZE)); resized_img = frame.getUMat(ACCESS_READ); } return 0; } ``` I got this error `what(): OpenCV(4.3.0) /home/sonic/opencv/opencv-4.3.0-i.mx6/modules/core/src/ocl.cpp:4957: error: (-215:Assertion failed) u->origdata == data && "Details: https://github.com/opencv/opencv/issues/6293"'` ##### Issue submission checklist - [ ] I report the issue, it's not a question <!-- OpenCV team works with answers.opencv.org, Stack Overflow and other communities to discuss problems. Tickets with question without real issue statement will be closed. --> - [ v ] I checked the problem with documentation, FAQ, open issues, answers.opencv.org, Stack Overflow, etc and have not found solution <!-- Places to check: * OpenCV documentation: https://docs.opencv.org * FAQ page: https://github.com/opencv/opencv/wiki/FAQ * OpenCV forum: https://answers.opencv.org * OpenCV issue tracker: https://github.com/opencv/opencv/issues?q=is%3Aissue * Stack Overflow branch: https://stackoverflow.com/questions/tagged/opencv --> - [ v ] I updated to latest OpenCV version and the issue is still there <!-- master branch for OpenCV 4.x and 3.4 branch for OpenCV 3.x releases. OpenCV team supports only latest release for each branch. The ticket is closed, if the problem is not reproduced with modern version. --> - [ ] There is reproducer code and related data files: videos, images, onnx, etc <!-- The best reproducer -- test case for OpenCV that we can add to the library. Recommendations for media files and binary files: * Try to reproduce the issue with images and videos in opencv_extra repository to reduce attachment size * Use PNG for images, if you report some CV related bug, but not image reader issue * Attach the image as archite to the ticket, if you report some reader issue. Image hosting services compress images and it breaks the repro code. * Provide ONNX file for some public model or ONNX file with with random weights, if you report ONNX parsing or handling issue. Architecture details diagram from netron tool can be very useful too. See https://lutzroeder.github.io/netron/ -->
category: ocl,category: 3rdparty
low
Critical
649,661,156
flutter
[ios] Initializing google map with 'n' markers takes O(n) time to add and blocks the UI during this period
## Details Adding / initializing **'n'** markers on google map takes **O(n)** time, and the UI remains freezed during this period. I tested initializing with `10` , `100`, `500` and `1000` markers. While adding `10` markers was pretty fast , the delay increased along with the number of markers with 1000 markers taking almost 5-15 seconds ! (in profile mode). The same code works fine on android , with no delay and is independent of size 'n'. The app reported no delay even in the debug mode. My android app is already live on Play store and no performance issue has been reported so far. The issue is only with ios. **Devices Tested :** - iPhone 5S (v 12.x) - ios Simulator (v 13.x) **Build Modes Tested :** - debug - profile **Package**: `google_maps_flutter 0.5.28+1` **Code Snippet** : ``` Marker getMarkerForStation(Station s, {String infoText}) { return Marker( markerId: MarkerId(s.id), infoWindow: infoText == null ? InfoWindow.noText : InfoWindow(title: infoText), draggable: false, position: LatLng(s.geoLocation.latitude, s.geoLocation.longitude), onTap: () => _onTapExistingMarker(s) } Widget _map(BuildContext context, List<Station> quickViewStations) { var _stationMarkers = Set.of(showStations.map((s) => getMarkerForStation(s))); return GoogleMap( markers: _stationMarkers, mapType: MapType.normal, myLocationEnabled: true, myLocationButtonEnabled: false, onMapCreated: _onMapCreated, mapToolbarEnabled: false, initialCameraPosition: CameraPosition( target: _currentDeviceLocation, zoom: 16.0, ), onCameraMove: _onCameraMove, } ``` <!-- 1. Please tell us exactly how to reproduce the problem you are running into, and how you measured the performance. 2. Please attach a small application (ideally just one main.dart file) that reproduces the problem. You could use https://gist.github.com/ for this. 3. Switch flutter to master channel and run this app on a physical device using profile or release mode. Verify that the performance issue can be reproduced there. The bleeding edge master channel is encouraged here because Flutter is constantly fixing bugs and improving its performance. Your problem in an older Flutter version may have already been solved in the master channel. --> <!-- Please tell us which target platform(s) the problem occurs (Android / iOS / Web / macOS / Linux / Windows) Which target OS version, for Web, browser, is the test system running? Does the problem occur on emulator/simulator as well as on physical devices? --> **Target Platform:** ios **Target OS version/browser:** 12 and above **Devices:** ios mobile device / simulator ## Logs <!-- Run `flutter analyze` and attach any output of that command below. If there are any analysis errors, try resolving them before filing this issue. --> ``` Analyzing cng-eco-connect-flutter... No issues found! (ran in 5.4s) ``` <!-- Finally, paste the output of running `flutter doctor -v` here, with your device plugged in. --> ``` [✓] Flutter (Channel master, 1.20.0-3.0.pre.51, on Mac OS X 10.15.4 19E2269, locale en-IN) • Flutter version 1.20.0-3.0.pre.51 at /Users/bhavyalathabandaru/Documents/Flutter/flutter • Framework revision c68758fab1 (6 days ago), 2020-06-24 21:23:02 -0700 • Engine revision 0c14126211 • Dart version 2.9.0 (build 2.9.0-18.0.dev d8eb844e5d) [!] Android toolchain - develop for Android devices (Android SDK version 30.0.0) • Android SDK at /Users/bhavyalathabandaru/Library/Android/sdk • Platform android-30, build-tools 30.0.0 • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593) ✗ Android licenses not accepted. To resolve this, run: flutter doctor --android-licenses [✓] Xcode - develop for iOS and macOS (Xcode 11.5) • Xcode at /Applications/Xcode.app/Contents/Developer • Xcode 11.5, Build version 11E608c • CocoaPods version 1.9.3 [✓] Android Studio (version 4.0) • Android Studio at /Applications/Android Studio.app/Contents • Flutter plugin version 46.0.2 • Dart plugin version 193.7361 • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593) [✓] Connected device (2 available) • Bhavya i5s • 18dd1363a73d63042f402aa6f63b812fc966a094 • ios • iOS 12.4.4 • iPhone SE (2nd generation) • 6C4BF3A7-8EC1-4E94-9BCA-850A3F41D170 • ios • com.apple.CoreSimulator.SimRuntime.iOS-13-5 (simulator) ! Doctor found issues in 1 category. ```
platform-ios,engine,c: performance,customer: crowd,p: maps,package,has reproducible steps,P2,found in release: 3.9,team-ios,triaged-ios
low
Critical
649,728,581
flutter
[proposal] Pigeon should use Protobuf to share data between "HostApi" and "FlutterApi"
Hi all, the following proposal is largely inspired by this great [article](https://www.freecodecamp.org/news/flutter-platform-channels-with-protobuf-e895e533dfb7/) from @truongsinh ## Use case Common issues with platform channel data transfer: - FlutterStandardTypedData issues - often require to cast data - frequent loss of type-safety - loss of performance with List<dynamic>, Map<String,dynamic> ## Proposal Use [protobuf](https://pub.dev/packages/protobuf) as default for [pigeon](https://pub.dev/packages/pigeon)'s platform channel communication. ## Extras - [grpc](https://pub.dev/packages/grpc) uses `protobuf`, the proposed implementation would make very easy to cache data on native side from a `grpc` client - AFAIK [flutterfire](https://github.com/FirebaseExtended/flutterfire) uses a grpc client on the native side the proposed implementation should lead to better performance and stability cc @gaaclarke as requested in the `feedback` tab of [pigeon readme](https://pub.dev/packages/pigeon#-readme-tab-) Thank you
c: new feature,package,c: proposal,team-ecosystem,p: pigeon,P3,triaged-ecosystem
low
Major
649,745,016
rust
Ability from the top-level of the compilation not to mark #[no_mangle] items exported from shared library
Firefox currently builds all its Rust code into a static artifact called `gkrust` which is then statically linked, with cross-language LTO, with C++ artifacts to form the shippable `libxul.so/dylib/dll`. Upon examining the exported symbols of `libxul`, the FFI functions that are meant for internal glue between Rust and C++ show up. This is a problem for two reasons: 1. It's a binary size issue, because cross-language LTO is supposed to inline the FFI functions into their callers. However, having them exported means also keeping those copies around. Also, unused FFI functions can't be eliminated as dead code. 2. It gives problematic third-party software more opportunities to hook into `libxul` in unsupported ways. Since there's a variety of third-party crates that go into `libxul`, it wouldn't be practical to reannotate each FFI function. Therefore, please add a way from the top level of the Rust compilation to turn off the shared library export metadata generation for `#[no_mangle]` items.
A-linkage,T-compiler
medium
Critical
649,782,783
pytorch
will you support SRU on mobile?
## ❓ Questions and Help Now I have a nlp model contained SRU, but it seems that pytorch cannot deploy SRU on the Android.
module: android,oncall: mobile
low
Minor
649,862,048
rust
Denying a const_err lint can hide the root cause site
The following code snippet does not show the `T::ASSERT` site unless the `const_err` lint is allowed or set to warn only. I'm guessing the error on `T::ASSERT` is happening during codegen. ```rust trait ZstAssert: Sized { const ASSERT: () = [()][(std::mem::size_of::<Self>() != 0) as usize]; } impl<T> ZstAssert for T {} fn foo<T>() { #[allow(path_statements)] { T::ASSERT } } fn main() { foo::<u32>(); } ``` ([Playground](https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=8650768cf9e123ef174e12a3973847c2)) Errors: ``` Compiling playground v0.0.1 (/playground) error: any use of this value will cause an error --> src/main.rs:2:24 | 2 | const ASSERT: () = [()][(std::mem::size_of::<Self>() != 0) as usize]; | -------------------^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- | | | index out of bounds: the len is 1 but the index is 1 | = note: `#[deny(const_err)]` on by default error: aborting due to previous error error: could not compile `playground`. To learn more, run the command again with --verbose. ```
A-diagnostics,T-compiler,C-bug,A-const-eval
low
Critical