id
int64 393k
2.82B
| repo
stringclasses 68
values | title
stringlengths 1
936
| body
stringlengths 0
256k
⌀ | labels
stringlengths 2
508
| priority
stringclasses 3
values | severity
stringclasses 3
values |
|---|---|---|---|---|---|---|
604,234,328 |
flutter
|
Flutter run fails when using a plugin with a renamed Android package
|
Moved from https://github.com/dart-lang/pub/issues/2413 as requested
Originally thought this was an issue with Flutter run failing when using a git SSH plugin dependency (https://github.com/flutter/flutter/issues/53387). After further investigation, it was caused due to a rename of the Android package name within the plugin. It seems like the underscore is required even though there are no issues with the example app, only when importing into another app via pubspec.
While trying to figure out what was happening, I changed the dependency on this to file path instead of SSH and got a different error message. It was looking for lib/main.dart for some reason (don't have the logs sorry). However the library had lib/observable_session.dart instead as was generated. Renaming this had a different error again. Not sure what would happen with a pub.dev one either.
It would be nice if it was possible to do this, not sure why the end of the android package has to match the plugin name. But a warning would also be great, took me a good few days to figure out what was causing it to not run as there was nothing related in the error messages.
# What I changed from the generated plugin
I renamed the package from `com.fssi.business.observable_session` to `com.fssi.business.observablesession` in the following places
- Fille android/src/main/AndroidManifest.xml
- Package/directory android/src/main/kotlin/com/fssi/business/observable_session to ... observablesession
- Pubspec name remained `observable_session` however flutter/plugin/platforms/android/package updated to `com.fssi.business.observablesession`
---
## Plugin pubspec.yaml
```yaml
name: observable_session
description: Observable session storage
version: 0.1.0
environment:
sdk: ">=2.7.1 <3.0.0"
flutter: ">=1.14.6"
dependencies:
flutter:
sdk: flutter
meta: ^1.1.8
equatable: ^1.1.1
pedantic: ^1.9.0
dev_dependencies:
test: ^1.6.0
flutter_test:
sdk: flutter
flutter:
plugin:
platforms:
android:
package: com.fssi.business.observablesession
pluginClass: ObservableSessionPlugin
```
## App pubspec.yaml (Git URLs removed)
```yaml
name: android_launcher
description: Flutter based Android launcher for dedicated devices.
version: 1.0.0+1
environment:
sdk: ">=2.7.1 <3.0.0"
dependencies:
flutter:
sdk: flutter
data_state:
git: <private git url>
http: ^0.12.0+4
meta: ^1.1.8
observable_session:
git: <private git url>
provider: ^4.0.4
sap_oauth2:
git: <private git url>
simple_animations: ^1.3.11
dev_dependencies:
flutter_test:
sdk: flutter
effective_dart: ^1.2.1
flutter:
uses-material-design: true
assets:
- assets/
```
## Logs
<details>
<summary>logs</summary>
```console
C:\dev\projects\android-launcher>flutter run -v
[ +22 ms] executing: [C:\dev\flutter/] git -c log.showSignature=false log -n 1 --pretty=format:%H
[ +44 ms] Exit code 0 from: git -c log.showSignature=false log -n 1 --pretty=format:%H
[ ] 2294d75bfa8d067ba90230c0fc2268f3636d7584
[ ] executing: [C:\dev\flutter/] git fetch https://github.com/flutter/flutter.git --tags
[+2407 ms] Exit code 0 from: git fetch https://github.com/flutter/flutter.git --tags
[ +1 ms] From https://github.com/flutter/flutter
* branch HEAD -> FETCH_HEAD
[ ] executing: [C:\dev\flutter/] git describe --match v*.*.* --first-parent --long --tags
[ +45 ms] Exit code 0 from: git describe --match v*.*.* --first-parent --long --tags
[ ] v1.15.17-0-g2294d75bfa
[ +4 ms] executing: [C:\dev\flutter/] git rev-parse --abbrev-ref --symbolic @{u}
[ +25 ms] Exit code 0 from: git rev-parse --abbrev-ref --symbolic @{u}
[ ] origin/beta
[ ] executing: [C:\dev\flutter/] git ls-remote --get-url origin
[ +22 ms] Exit code 0 from: git ls-remote --get-url origin
[ ] https://github.com/flutter/flutter.git
[ +54 ms] executing: [C:\dev\flutter/] git rev-parse --abbrev-ref HEAD
[ +23 ms] Exit code 0 from: git rev-parse --abbrev-ref HEAD
[ ] beta
[ +26 ms] Artifact Instance of 'AndroidMavenArtifacts' is not required, skipping update.
[ ] Artifact Instance of 'AndroidGenSnapshotArtifacts' is not required, skipping update.
[ ] Artifact Instance of 'AndroidInternalBuildArtifacts' is not required, skipping update.
[ ] Artifact Instance of 'IOSEngineArtifacts' is not required, skipping update.
[ ] Artifact Instance of 'FlutterWebSdk' is not required, skipping update.
[ +2 ms] Artifact Instance of 'WindowsEngineArtifacts' is not required, skipping update.
[ ] Artifact Instance of 'MacOSEngineArtifacts' is not required, skipping update.
[ ] Artifact Instance of 'LinuxEngineArtifacts' is not required, skipping update.
[ ] Artifact Instance of 'LinuxFuchsiaSDKArtifacts' is not required, skipping update.
[ ] Artifact Instance of 'MacOSFuchsiaSDKArtifacts' is not required, skipping update.
[ ] Artifact Instance of 'FlutterRunnerSDKArtifacts' is not required, skipping update.
[ ] Artifact Instance of 'FlutterRunnerDebugSymbols' is not required, skipping update.
[ +23 ms] executing: C:\dev\android\sdk\platform-tools\adb.exe devices -l
[ +17 ms] Exit code 0 from: C:\dev\android\sdk\platform-tools\adb.exe devices -l
[ ] List of devices attached
17005522509652 device product:TC51 model:TC51 device:TC51 transport_id:1
[ +7 ms] C:\dev\android\sdk\platform-tools\adb.exe -s 17005522509652 shell getprop
[ +289 ms] Artifact Instance of 'AndroidMavenArtifacts' is not required, skipping update.
[ +7 ms] Artifact Instance of 'AndroidInternalBuildArtifacts' is not required, skipping update.
[ ] Artifact Instance of 'IOSEngineArtifacts' is not required, skipping update.
[ +5 ms] Artifact Instance of 'WindowsEngineArtifacts' is not required, skipping update.
[ +1 ms] Artifact Instance of 'MacOSEngineArtifacts' is not required, skipping update.
[ +1 ms] Artifact Instance of 'LinuxEngineArtifacts' is not required, skipping update.
[ +1 ms] Artifact Instance of 'LinuxFuchsiaSDKArtifacts' is not required, skipping update.
[ ] Artifact Instance of 'MacOSFuchsiaSDKArtifacts' is not required, skipping update.
[ ] Artifact Instance of 'FlutterRunnerSDKArtifacts' is not required, skipping update.
[ ] Artifact Instance of 'FlutterRunnerDebugSymbols' is not required, skipping update.
[ +74 ms] Found plugin observable_session at C:\dev\flutter\.pub-cache\git\observable-session-303db1f443873157e8fe06013725d62fcfd1f816\
[ +55 ms] Found plugin observable_session at C:\dev\flutter\.pub-cache\git\observable-session-303db1f443873157e8fe06013725d62fcfd1f816\
[ +37 ms] Generating C:\dev\projects\android-launcher\android\app\src\main\java\io\flutter\plugins\GeneratedPluginRegistrant.java
[ +18 ms] ro.hardware = qcom
[ +26 ms] Launching lib\main.dart on TC51 in debug mode...
[ +6 ms] C:\dev\flutter\bin\cache\dart-sdk\bin\dart.exe C:\dev\flutter\bin\cache\artifacts\engine\windows-x64\frontend_server.dart.snapshot --sdk-root C:\dev\flutter\bin\cache\artifacts\engine\common\flutter_patched_sdk/ --incremental --target=flutter -Ddart.developer.causal_async_stacks=true --output-dill
C:\Users\AARONW~1\AppData\Local\Temp\flutter_tool.6586c658-6fd3-11ea-98c3-7085c27b0566\app.dill --packages C:\dev\projects\android-launcher\.packages -Ddart.vm.profile=false -Ddart.vm.product=false --bytecode-options=source-positions,local-var-info,debugger-stops,instance-field-initializers,keep-unreachable-code,avoid-closure-call-instructions
--enable-asserts --track-widget-creation --filesystem-scheme org-dartlang-root
[ +14 ms] executing: C:\dev\android\sdk\platform-tools\adb.exe -s 17005522509652 shell -x logcat -v time -t 1
[ +83 ms] Exit code 0 from: C:\dev\android\sdk\platform-tools\adb.exe -s 17005522509652 shell -x logcat -v time -t 1
[ +2 ms] --------- beginning of main
03-27 15:33:55.681 I/zygote64( 7411): Successfully killed process cgroup uid 1000 pid 6842 in 0ms
[ +23 ms] executing: C:\dev\android\sdk\platform-tools\adb.exe version
[ +5 ms] executing: C:\dev\android\sdk\platform-tools\adb.exe -s 17005522509652 logcat -v time -T 03-27 15:33:55.681
[ +23 ms] <- compile package:android_launcher/main.dart
[ +52 ms] Android Debug Bridge version 1.0.41
Version 29.0.6-6198805
Installed as C:\dev\android\sdk\platform-tools\adb.exe
[ +2 ms] executing: C:\dev\android\sdk\platform-tools\adb.exe start-server
[ +18 ms] Building APK
[ +13 ms] Running Gradle task 'assembleDebug'...
[ +1 ms] gradle.properties already sets `android.enableR8`
[ +2 ms] Using gradle from C:\dev\projects\android-launcher\android\gradlew.bat.
[ ] C:\dev\projects\android-launcher\android\gradlew.bat mode: 33279 rwxrwxrwx.
[ +5 ms] executing: C:\Program Files\Android\Android Studio\jre\bin\java -version
[ +77 ms] Exit code 0 from: C:\Program Files\Android\Android Studio\jre\bin\java -version
[ ] openjdk version "1.8.0_212-release"
OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b04)
OpenJDK 64-Bit Server VM (build 25.212-b04, mixed mode)
[ +1 ms] executing: C:\Program Files\Android Studio\jre\bin\java -version
[ +68 ms] Exit code 0 from: C:\Program Files\Android Studio\jre\bin\java -version
[ ] openjdk version "1.8.0_152-release"
OpenJDK Runtime Environment (build 1.8.0_152-release-1136-b06)
OpenJDK 64-Bit Server VM (build 25.152-b06, mixed mode)
[ +2 ms] executing: [C:\dev\projects\android-launcher\android/] C:\dev\projects\android-launcher\android\gradlew.bat -Pverbose=true -Ptarget-platform=android-arm64 -Ptarget=C:\dev\projects\android-launcher\lib\main.dart -Ptrack-widget-creation=true -Pfilesystem-scheme=org-dartlang-root assembleDebug
[ +993 ms] > Configure project :app
[ ] WARNING: The option 'android.enableR8' is deprecated and should not be used anymore.
[ ] It will be removed in a future version of the Android Gradle plugin, and will no longer allow you to disable R8.
[+2189 ms] > Task :app:compileFlutterBuildDebug
[ +1 ms] [ +16 ms] executing: [C:\dev\flutter/] git -c log.showSignature=false log -n 1 --pretty=format:%H
[ ] [ +45 ms] Exit code 0 from: git -c log.showSignature=false log -n 1 --pretty=format:%H
[ ] [ ] 2294d75bfa8d067ba90230c0fc2268f3636d7584
[ ] [ ] executing: [C:\dev\flutter/] git fetch https://github.com/flutter/flutter.git --tags
[+1897 ms] [+2397 ms] Exit code 0 from: git fetch https://github.com/flutter/flutter.git --tags
[ ] [ ] From https://github.com/flutter/flutter
[ ] * branch HEAD -> FETCH_HEAD
[ ] [ ] executing: [C:\dev\flutter/] git describe --match v*.*.* --first-parent --long --tags
[ ] [ +47 ms] Exit code 0 from: git describe --match v*.*.* --first-parent --long --tags
[ ] [ ] v1.15.17-0-g2294d75bfa
[ ] [ +5 ms] executing: [C:\dev\flutter/] git rev-parse --abbrev-ref --symbolic @{u}
[ +97 ms] [ +25 ms] Exit code 0 from: git rev-parse --abbrev-ref --symbolic @{u}
[ ] [ ] origin/beta
[ ] [ ] executing: [C:\dev\flutter/] git ls-remote --get-url origin
[ ] [ +22 ms] Exit code 0 from: git ls-remote --get-url origin
[ ] [ ] https://github.com/flutter/flutter.git
[ ] [ +54 ms] executing: [C:\dev\flutter/] git rev-parse --abbrev-ref HEAD
[ +98 ms] [ +23 ms] Exit code 0 from: git rev-parse --abbrev-ref HEAD
[ ] [ ] beta
[ ] [ +14 ms] Artifact Instance of 'AndroidMavenArtifacts' is not required, skipping update.
[ ] [ ] Artifact Instance of 'AndroidGenSnapshotArtifacts' is not required, skipping update.
[ ] [ ] Artifact Instance of 'AndroidInternalBuildArtifacts' is not required, skipping update.
[ ] [ ] Artifact Instance of 'IOSEngineArtifacts' is not required, skipping update.
[ ] [ ] Artifact Instance of 'FlutterWebSdk' is not required, skipping update.
[ ] [ +2 ms] Artifact Instance of 'WindowsEngineArtifacts' is not required, skipping update.
[ ] [ ] Artifact Instance of 'MacOSEngineArtifacts' is not required, skipping update.
[ ] [ ] Artifact Instance of 'LinuxEngineArtifacts' is not required, skipping update.
[ ] [ ] Artifact Instance of 'LinuxFuchsiaSDKArtifacts' is not required, skipping update.
[ ] [ ] Artifact Instance of 'MacOSFuchsiaSDKArtifacts' is not required, skipping update.
[ ] [ ] Artifact Instance of 'FlutterRunnerSDKArtifacts' is not required, skipping update.
[ ] [ ] Artifact Instance of 'FlutterRunnerDebugSymbols' is not required, skipping update.
[ ] [ +7 ms] Artifact Instance of 'MaterialFonts' is not required, skipping update.
[ ] [ ] Artifact Instance of 'GradleWrapper' is not required, skipping update.
[ ] [ ] Artifact Instance of 'AndroidMavenArtifacts' is not required, skipping update.
[ ] [ ] Artifact Instance of 'AndroidGenSnapshotArtifacts' is not required, skipping update.
[ ] [ ] Artifact Instance of 'AndroidInternalBuildArtifacts' is not required, skipping update.
[ ] [ ] Artifact Instance of 'IOSEngineArtifacts' is not required, skipping update.
[ ] [ ] Artifact Instance of 'FlutterWebSdk' is not required, skipping update.
[ ] [ ] Artifact Instance of 'FlutterSdk' is not required, skipping update.
[ ] [ ] Artifact Instance of 'WindowsEngineArtifacts' is not required, skipping update.
[ ] [ ] Artifact Instance of 'MacOSEngineArtifacts' is not required, skipping update.
[ ] [ ] Artifact Instance of 'LinuxEngineArtifacts' is not required, skipping update.
[ ] [ ] Artifact Instance of 'LinuxFuchsiaSDKArtifacts' is not required, skipping update.
[ ] [ ] Artifact Instance of 'MacOSFuchsiaSDKArtifacts' is not required, skipping update.
[ +1 ms] [ ] Artifact Instance of 'FlutterRunnerSDKArtifacts' is not required, skipping update.
[ ] [ ] Artifact Instance of 'FlutterRunnerDebugSymbols' is not required, skipping update.
[ ] [ ] Artifact Instance of 'IosUsbArtifacts' is not required, skipping update.
[ ] [ ] Artifact Instance of 'IosUsbArtifacts' is not required, skipping update.
[ ] [ ] Artifact Instance of 'IosUsbArtifacts' is not required, skipping update.
[ ] [ ] Artifact Instance of 'IosUsbArtifacts' is not required, skipping update.
[ ] [ ] Artifact Instance of 'IosUsbArtifacts' is not required, skipping update.
[ ] [ ] Artifact Instance of 'FontSubsetArtifacts' is not required, skipping update.
[ +78 ms] [ +60 ms] Initializing file store
[ ] [ +16 ms] Done initializing file store
[+1098 ms] [+1096 ms] Skipping target: kernel_snapshot
[ +100 ms] [ +121 ms] debug_android_application: Starting due to {InvalidatedReason.outputMissing}
[ +100 ms] [ +122 ms] debug_android_application: Complete
[ ] [ +12 ms] Persisting file store
[ ] [ +9 ms] Done persisting file store
[ ] [ +3 ms] build succeeded.
[ ] [ +10 ms] "flutter assemble" took 1,503ms.
[ +96 ms] > Task :app:packLibsflutterBuildDebug UP-TO-DATE
[ ] > Task :app:preBuild UP-TO-DATE
[ ] > Task :app:preDebugBuild UP-TO-DATE
[+1999 ms] > Task :observable_session:compileFlutterBuildDebug
[ +1 ms] [ +9 ms] executing: [C:\dev\flutter/] git -c log.showSignature=false log -n 1 --pretty=format:%H
[ +2 ms] [ +44 ms] Exit code 0 from: git -c log.showSignature=false log -n 1 --pretty=format:%H
[ +1 ms] [ ] 2294d75bfa8d067ba90230c0fc2268f3636d7584
[ +1 ms] [ ] executing: [C:\dev\flutter/] git fetch https://github.com/flutter/flutter.git --tags
[+1892 ms] [+2458 ms] Exit code 0 from: git fetch https://github.com/flutter/flutter.git --tags
[ ] [ ] From https://github.com/flutter/flutter
[ ] * branch HEAD -> FETCH_HEAD
[ ] [ ] executing: [C:\dev\flutter/] git describe --match v*.*.* --first-parent --long --tags
[ +98 ms] [ +45 ms] Exit code 0 from: git describe --match v*.*.* --first-parent --long --tags
[ ] [ ] v1.15.17-0-g2294d75bfa
[ ] [ +5 ms] executing: [C:\dev\flutter/] git rev-parse --abbrev-ref --symbolic @{u}
[ ] [ +25 ms] Exit code 0 from: git rev-parse --abbrev-ref --symbolic @{u}
[ ] [ ] origin/beta
[ ] [ ] executing: [C:\dev\flutter/] git ls-remote --get-url origin
[ ] [ +22 ms] Exit code 0 from: git ls-remote --get-url origin
[ ] [ ] https://github.com/flutter/flutter.git
[ +97 ms] [ +53 ms] executing: [C:\dev\flutter/] git rev-parse --abbrev-ref HEAD
[ ] [ +23 ms] Exit code 0 from: git rev-parse --abbrev-ref HEAD
[ ] [ ] beta
[ ] [ +13 ms] Artifact Instance of 'AndroidMavenArtifacts' is not required, skipping update.
[ ] [ ] Artifact Instance of 'AndroidGenSnapshotArtifacts' is not required, skipping update.
[ ] [ ] Artifact Instance of 'AndroidInternalBuildArtifacts' is not required, skipping update.
[ ] [ ] Artifact Instance of 'IOSEngineArtifacts' is not required, skipping update.
[ ] [ ] Artifact Instance of 'FlutterWebSdk' is not required, skipping update.
[ ] [ +2 ms] Artifact Instance of 'WindowsEngineArtifacts' is not required, skipping update.
[ ] [ ] Artifact Instance of 'MacOSEngineArtifacts' is not required, skipping update.
[ ] [ ] Artifact Instance of 'LinuxEngineArtifacts' is not required, skipping update.
[ ] [ ] Artifact Instance of 'LinuxFuchsiaSDKArtifacts' is not required, skipping update.
[ ] [ ] Artifact Instance of 'MacOSFuchsiaSDKArtifacts' is not required, skipping update.
[ ] [ ] Artifact Instance of 'FlutterRunnerSDKArtifacts' is not required, skipping update.
[ ] [ ] Artifact Instance of 'FlutterRunnerDebugSymbols' is not required, skipping update.
[ ] [ +6 ms] Artifact Instance of 'MaterialFonts' is not required, skipping update.
[ ] [ ] Artifact Instance of 'GradleWrapper' is not required, skipping update.
[ ] [ ] Artifact Instance of 'AndroidMavenArtifacts' is not required, skipping update.
[ ] [ ] Artifact Instance of 'AndroidGenSnapshotArtifacts' is not required, skipping update.
[ ] [ ] Artifact Instance of 'AndroidInternalBuildArtifacts' is not required, skipping update.
[ ] [ ] Artifact Instance of 'IOSEngineArtifacts' is not required, skipping update.
[ ] [ ] Artifact Instance of 'FlutterWebSdk' is not required, skipping update.
[ ] [ ] Artifact Instance of 'FlutterSdk' is not required, skipping update.
[ ] [ ] Artifact Instance of 'WindowsEngineArtifacts' is not required, skipping update.
[ ] [ ] Artifact Instance of 'MacOSEngineArtifacts' is not required, skipping update.
[ ] [ ] Artifact Instance of 'LinuxEngineArtifacts' is not required, skipping update.
[ ] [ ] Artifact Instance of 'LinuxFuchsiaSDKArtifacts' is not required, skipping update.
[ ] [ ] Artifact Instance of 'MacOSFuchsiaSDKArtifacts' is not required, skipping update.
[ ] [ ] Artifact Instance of 'FlutterRunnerSDKArtifacts' is not required, skipping update.
[ +1 ms] [ ] Artifact Instance of 'FlutterRunnerDebugSymbols' is not required, skipping update.
[ ] [ ] Artifact Instance of 'IosUsbArtifacts' is not required, skipping update.
[ ] [ ] Artifact Instance of 'IosUsbArtifacts' is not required, skipping update.
[ ] [ ] Artifact Instance of 'IosUsbArtifacts' is not required, skipping update.
[ ] [ ] Artifact Instance of 'IosUsbArtifacts' is not required, skipping update.
[ ] [ ] Artifact Instance of 'IosUsbArtifacts' is not required, skipping update.
[ ] [ ] Artifact Instance of 'FontSubsetArtifacts' is not required, skipping update.
[ +82 ms] [ +59 ms] Initializing file store
[ ] [ +1 ms] Done initializing file store
[ ] [ +14 ms] kernel_snapshot: Starting due to {}
[ ] [ +11 ms] Persisting file store
[ ] [ +3 ms] Done persisting file store
[ ] [ +6 ms] "flutter assemble" took 147ms.
[ +1 ms] [ +1 ms] Target kernel_snapshot failed: FileSystemException: Cannot open file, path = 'C:\dev\flutter\.pub-cache\git\observable-session-303db1f443873157e8fe06013725d62fcfd1f816\.packages' (OS Error: The system cannot find the file specified.
[ +1 ms] , errno = 2)
[ ] build failed.
[ ] #0 throwToolExit (package:flutter_tools/src/base/common.dart:14:3)
[ ] #1 AssembleCommand.runCommand (package:flutter_tools/src/commands/assemble.dart:193:7)
[ ] #2 _rootRunUnary (dart:async/zone.dart:1134:38)
[ ] #3 _CustomZone.runUnary (dart:async/zone.dart:1031:19)
[ ] #4 _FutureListener.handleValue (dart:async/future_impl.dart:140:18)
[ ] #5 Future._propagateToListeners.handleValueCallback (dart:async/future_impl.dart:682:45)
[ ] #6 Future._propagateToListeners (dart:async/future_impl.dart:711:32)
[ ] #7 Future._completeWithValue (dart:async/future_impl.dart:526:5)
[ ] #8 _AsyncAwaitCompleter.complete (dart:async-patch/async_patch.dart:34:15)
[ ] #9 _completeOnAsyncReturn (dart:async-patch/async_patch.dart:293:13)
[ ] #10 BuildSystem.build (package:flutter_tools/src/build_system/build_system.dart)
[ ] #11 _rootRunUnary (dart:async/zone.dart:1134:38)
[ ] #12 _CustomZone.runUnary (dart:async/zone.dart:1031:19)
[ ] #13 _FutureListener.handleValue (dart:async/future_impl.dart:140:18)
[ ] #14 Future._propagateToListeners.handleValueCallback (dart:async/future_impl.dart:682:45)
[ ] #15 Future._propagateToListeners (dart:async/future_impl.dart:711:32)
[ ] #16 Future._completeWithValue (dart:async/future_impl.dart:526:5)
[ ] #17 _AsyncAwaitCompleter.complete (dart:async-patch/async_patch.dart:34:15)
[ ] #18 _completeOnAsyncReturn (dart:async-patch/async_patch.dart:293:13)
[ ] #19 _BuildInstance.invokeTarget (package:flutter_tools/src/build_system/build_system.dart)
[ ] #20 _rootRunUnary (dart:async/zone.dart:1134:38)
[ ] #21 _CustomZone.runUnary (dart:async/zone.dart:1031:19)
[ ] #22 _FutureListener.handleValue (dart:async/future_impl.dart:140:18)
[ ] #23 Future._propagateToListeners.handleValueCallback (dart:async/future_impl.dart:682:45)
[ ] #24 Future._propagateToListeners (dart:async/future_impl.dart:711:32)
[ ] #25 Future._completeWithValue (dart:async/future_impl.dart:526:5)
[ ] #26 Future.wait.<anonymous closure> (dart:async/future.dart:400:22)
[ ] #27 _rootRunUnary (dart:async/zone.dart:1134:38)
[ ] #28 _CustomZone.runUnary (dart:async/zone.dart:1031:19)
[ ] #29 _FutureListener.handleValue (dart:async/future_impl.dart:140:18)
[ ] #30 Future._propagateToListeners.handleValueCallback (dart:async/future_impl.dart:682:45)
[ ] #31 Future._propagateToListeners (dart:async/future_impl.dart:711:32)
[ ] #32 Future._completeWithValue (dart:async/future_impl.dart:526:5)
[ ] #33 _AsyncAwaitCompleter.complete (dart:async-patch/async_patch.dart:34:15)
[ ] #34 _completeOnAsyncReturn (dart:async-patch/async_patch.dart:293:13)
[ ] #35 _BuildInstance._invokeInternal (package:flutter_tools/src/build_system/build_system.dart)
[ ] #36 _asyncErrorWrapperHelper.<anonymous closure> (dart:async-patch/async_patch.dart:82:45)
[ ] #37 _rootRunBinary (dart:async/zone.dart:1146:38)
[ ] #38 _CustomZone.runBinary (dart:async/zone.dart:1039:19)
[ ] #39 _FutureListener.handleError (dart:async/future_impl.dart:154:20)
[ ] #40 Future._propagateToListeners.handleError (dart:async/future_impl.dart:694:47)
[ ] #41 Future._propagateToListeners (dart:async/future_impl.dart:715:24)
[ ] #42 Future._completeError (dart:async/future_impl.dart:534:5)
[ ] #43 _AsyncAwaitCompleter.completeError (dart:async-patch/async_patch.dart:40:15)
[ ] #44 KernelSnapshot.build (package:flutter_tools/src/build_system/targets/dart.dart)
[ ] #45 _asyncErrorWrapperHelper.<anonymous closure> (dart:async-patch/async_patch.dart:82:45)
[ ] #46 _rootRunBinary (dart:async/zone.dart:1146:38)
[ ] #47 _CustomZone.runBinary (dart:async/zone.dart:1039:19)
[ ] #48 _FutureListener.handleError (dart:async/future_impl.dart:154:20)
[ ] #49 Future._propagateToListeners.handleError (dart:async/future_impl.dart:694:47)
[ ] #50 Future._propagateToListeners (dart:async/future_impl.dart:715:24)
[ ] #51 Future._completeError (dart:async/future_impl.dart:534:5)
[ ] #52 Future._asyncCompleteError.<anonymous closure> (dart:async/future_impl.dart:582:7)
[ ] #53 _rootRun (dart:async/zone.dart:1126:13)
[ ] #54 _CustomZone.run (dart:async/zone.dart:1023:19)
[ ] #55 _CustomZone.runGuarded (dart:async/zone.dart:925:7)
[ ] #56 _CustomZone.bindCallbackGuarded.<anonymous closure> (dart:async/zone.dart:965:23)
[ ] #57 _microtaskLoop (dart:async/schedule_microtask.dart:43:21)
[ ] #58 _startMicrotaskLoop (dart:async/schedule_microtask.dart:52:5)
[ ] #59 _runPendingImmediateCallback (dart:isolate-patch/isolate_patch.dart:118:13)
[ ] #60 _Timer._runTimers (dart:isolate-patch/timer_impl.dart:405:11)
[ ] #61 _Timer._handleMessage (dart:isolate-patch/timer_impl.dart:429:5)
[ ] #62 _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:168:12)
[ ] > Task :observable_session:compileFlutterBuildDebug FAILED
[ ] 3 actionable tasks: 2 executed, 1 up-to-date
[ ] FAILURE: Build failed with an exception.
[ ] * Where:
[ ] Script 'C:\dev\flutter\packages\flutter_tools\gradle\flutter.gradle' line: 833
[ ] * What went wrong:
[ +3 ms] Execution failed for task ':observable_session:compileFlutterBuildDebug'.
[ +2 ms] > Process 'command 'C:\dev\flutter\bin\flutter.bat'' finished with non-zero exit value 1
[ ] * Try:
[ ] Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.
[ ] * Get more help at https://help.gradle.org
[ ] BUILD FAILED in 10s
[ +381 ms] Running Gradle task 'assembleDebug'... (completed in 11.6s)
[ +3 ms] Exception: Gradle task assembleDebug failed with exit code 1
[ +1 ms] "flutter run" took 12,460ms.
#0 throwToolExit (package:flutter_tools/src/base/common.dart:14:3)
#1 RunCommand.runCommand (package:flutter_tools/src/commands/run.dart:568:7)
<asynchronous suspension>
#2 FlutterCommand.verifyThenRunCommand (package:flutter_tools/src/runner/flutter_command.dart:711:18)
#3 _rootRunUnary (dart:async/zone.dart:1134:38)
#4 _CustomZone.runUnary (dart:async/zone.dart:1031:19)
#5 _FutureListener.handleValue (dart:async/future_impl.dart:140:18)
#6 Future._propagateToListeners.handleValueCallback (dart:async/future_impl.dart:682:45)
#7 Future._propagateToListeners (dart:async/future_impl.dart:711:32)
#8 Future._completeWithValue (dart:async/future_impl.dart:526:5)
#9 _AsyncAwaitCompleter.complete (dart:async-patch/async_patch.dart:34:15)
#10 _completeOnAsyncReturn (dart:async-patch/async_patch.dart:293:13)
#11 RunCommand.usageValues (package:flutter_tools/src/commands/run.dart)
#12 _rootRunUnary (dart:async/zone.dart:1134:38)
#13 _CustomZone.runUnary (dart:async/zone.dart:1031:19)
#14 _FutureListener.handleValue (dart:async/future_impl.dart:140:18)
#15 Future._propagateToListeners.handleValueCallback (dart:async/future_impl.dart:682:45)
#16 Future._propagateToListeners (dart:async/future_impl.dart:711:32)
#17 Future._completeWithValue (dart:async/future_impl.dart:526:5)
#18 _AsyncAwaitCompleter.complete (dart:async-patch/async_patch.dart:34:15)
#19 _completeOnAsyncReturn (dart:async-patch/async_patch.dart:293:13)
#20 AndroidDevice.isLocalEmulator (package:flutter_tools/src/android/android_device.dart)
#21 _rootRunUnary (dart:async/zone.dart:1134:38)
#22 _CustomZone.runUnary (dart:async/zone.dart:1031:19)
#23 _FutureListener.handleValue (dart:async/future_impl.dart:140:18)
#24 Future._propagateToListeners.handleValueCallback (dart:async/future_impl.dart:682:45)
#25 Future._propagateToListeners (dart:async/future_impl.dart:711:32)
#26 Future._completeWithValue (dart:async/future_impl.dart:526:5)
#27 Future._asyncComplete.<anonymous closure> (dart:async/future_impl.dart:556:7)
#28 _rootRun (dart:async/zone.dart:1126:13)
#29 _CustomZone.run (dart:async/zone.dart:1023:19)
#30 _CustomZone.runGuarded (dart:async/zone.dart:925:7)
#31 _CustomZone.bindCallbackGuarded.<anonymous closure> (dart:async/zone.dart:965:23)
#32 _microtaskLoop (dart:async/schedule_microtask.dart:43:21)
#33 _startMicrotaskLoop (dart:async/schedule_microtask.dart:52:5)
#34 _runPendingImmediateCallback (dart:isolate-patch/isolate_patch.dart:118:13)
#35 _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:169:5)
```
</details>
|
platform-android,tool,d: api docs,P3,team-android,triaged-android
|
low
|
Critical
|
604,240,433 |
flutter
|
Feature Request: Add Screenshots for FloatingActionButtonLocation
|
## Use case
Once merged, PR #51465 will **enable many new FAB Locations** and **introduce ways to create user-defined FAB Locations**.
Screenshots in documentation will be very helpful for developers.
## Proposal
We propose that:
* We add a small screenshot to each FAB Location, illustrating its effect and typical usage.
* We add diagrams to illustrate what each mixin does.
|
a: tests,c: new feature,framework,f: material design,c: proposal,good first issue,P3,team-design,triaged-design
|
low
|
Minor
|
604,241,072 |
angular
|
Improve documentation for boxed values in form control
|
I'm submitting a ...
----------
```
[ ] Regression (behavior that used to work and stopped working in a new release)
[ ] Bug report
[ ] Feature request
[x] Documentation issue or request
[ ] Support request
```
Current behavior ...
----------
https://github.com/angular/angular/blob/acf6075ca9aa92121bb0166b2b7560aeb2c167ff/packages/forms/src/form_builder.ts#L57
and
https://github.com/angular/angular/blob/acf6075ca9aa92121bb0166b2b7560aeb2c167ff/packages/forms/src/form_builder.ts#L105
The documentation about the parameter `formState` in the method `control(..)` and the parameter `controlsConfig` in the method `group(..)` (see line reference) doesn't explain very well how to set it. Additionally, the type hints has presence of `any`s and makes it harder to understand.
Expected behavior
----------
I propose the follow type hints changes to clarify the situation.
For the `formState` type hint:
`string | { value: string, disabled: boolean }`
For the `controlsConfig` type hint:
`{ [key: string]: [string | {value: string, disabled: boolean}, ...any[]] }`
|
type: bug/fix,freq1: low,area: forms,state: confirmed,cross-cutting: types,P4
|
low
|
Critical
|
604,244,563 |
flutter
|
Support Safari as a browser in flutter run
|
Safari currently has a much different devtools API than chrome or edge, but it might be possible to use https://github.com/google/ios-webkit-debug-proxy to proxy the Safari devtools API to a Chrome-Like API. If this works, we might be able to provide a 1st class `flutter run -d safari` experience.
|
c: new feature,tool,platform-web,P3,team-web,triaged-web
|
medium
|
Critical
|
604,249,589 |
flutter
|
Support Firefox as a browser in flutter run
|
The Firefox remote protocol claims to support a subset of the chrome devtools protocol: https://firefox-source-docs.mozilla.org/remote/index.html . If this subset is sufficient, we might be able to connect with out existing chrome devtools logic and have it mostly work. This would allow 1st class support for `flutter run -d firefox`
|
c: new feature,tool,platform-web,P3,team-web,triaged-web
|
high
|
Critical
|
604,317,300 |
rust
|
Lint for #[must_use] on a function that always returns a #[must_use] type
|
I saw someone do this on a `try_from` today, so I figured I'd make an issue.
Repro:
```rust
#[must_use]
pub fn foo() -> Result<(), ()> { Ok(()) }
```
https://play.rust-lang.org/?version=nightly&mode=debug&edition=2018&gist=c03ca4925a9ac4ce9fdda4d2165e6892
The `#[must_use]` on the function there is unnecessary because it always returns `Result`, which is itself `#[must_use]`. So we might consider linting about that.
|
C-enhancement,A-lints,T-lang
|
low
|
Critical
|
604,325,817 |
tensorflow
|
No default summary writer available when using tf.py_function with autograph
|
**System information**
- Have I written custom code (as opposed to using a stock example script provided in TensorFlow): 3.6.8
- OS Platform and Distribution (e.g., Linux Ubuntu 16.04): macOS 10.15.5 Beta
- Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device: n/a
- TensorFlow installed from (source or binary): binary
- TensorFlow version (use command below): 2.1.0
- Python version: 3.6.8
- Bazel version (if compiling from source): n/a
- GCC/Compiler version (if compiling from source): n/a
- CUDA/cuDNN version: n/a
- GPU model and memory: n/a
**Describe the current behavior**
Using `tf.summary` returns `False` inside a `tf.py_function` when using autograph.
**Describe the expected behavior**
`tf.summary` should return `True`.
**Standalone code to reproduce the issue**
```python
import tensorflow as tf
@tf.function
def eager_pyfunc():
def inner_func():
bool_out = tf.summary.scalar('myscalar', tf.constant(32.9))
tf.print(bool_out, name='log-myscalar-success')
tf.py_function(inner_func, [], [], name='log-myscalar')
bool_out2 = tf.summary.scalar('myscalar2', tf.constant(52.3))
tf.print(bool_out2, name='log-myscalar2-success')
with tf.summary.create_file_writer('./logs').as_default():
tf.summary.experimental.set_step(0)
eager_pyfunc()
```
outputs:
```
0
1
```
Removing the `tf.function` outputs:
```
1
1
```
**Other info / logs**
Could be related to https://github.com/tensorflow/tensorflow/issues/26409.
|
comp:tensorboard,stat:awaiting tensorflower,type:bug,TF 2.12
|
low
|
Minor
|
604,337,433 |
rust
|
Tracking issue for generator code quality
|
So far we haven't done many deep dives into the code LLVM produces for generators. I think there's a lot of room for improvement here, both in the compiler and in LLVM.
Issues (please add more as they come up):
- [ ] #71093 unnecessary panicking branch in `foo().await` (vs equivalent `FutureImpl.await`)
Some more ideas are in https://github.com/rust-lang/rust/issues/71093#issuecomment-617448426
Related tracking issues:
- #69826 Generator Memory Usage
- #69663 More precise generator captures
|
A-LLVM,I-slow,metabug,T-compiler,A-coroutines,I-heavy,A-async-await,AsyncAwait-Triaged
|
low
|
Minor
|
604,351,598 |
PowerToys
|
[FancyZones] Win+Ctrl+Arrow to switch focus to adjacent zones
|
# Summary of the new feature/enhancement
In [i3](https://i3wm.org/docs/refcard.html), user can switch focus to adjacent zones in 4 directions using hotkeys (`Mod1 + jkl;`).
# Proposed technical implementation details (optional)
FancyZones can include shortcuts `Win + Ctrl + LEFT/RIGHT` leveraging `MoveWindowIntoZoneByDirection` implementation. The choice of the hotkey is based on Window Walker `WIN + CTRL`.
|
Idea-Enhancement,FancyZones-Dragging&UI,Product-FancyZones
|
high
|
Critical
|
604,355,318 |
go
|
x/playground: return non-200 for timeout errors
|
Timeout errors currently must return a 200 status to be rendered correctly by the Playground javascript. The javascript needs to be updated to also parse 4xx errors correctly, then the playground should be updated to return responses with a correct code. Currently, unsuccessful requests of any kind are treated the same as a 5xx.
This may have implications for the Tour or other places where the playground is used.
Related to #38546
|
NeedsFix
|
low
|
Critical
|
604,372,695 |
vscode
|
Git - VSCode locks git index in AFP repo
|
- VSCode Version: 1.43.2
- OS Version: Darwin 18.7.0 Darwin Kernel Version 18.7.0: Mon Feb 10 21:08:45 PST 2020; root:xnu-4903.278.28~1/RELEASE_X86_64 x86_64 i386
Steps to Reproduce:
1. Open workspace (in this case a LaTeX project)
2. Attempt to run `git add` from a separate terminal window.
Result:
`fatal: Unable to write new index file`
Solution:
Close VSCode workspace.
VSCode appears to be keeping `.git/refs/remotes/origin/master` open. lsof doesn't indicate any locks but git still refuses to update the index until I close the VSCode window.
|
bug,help wanted,git,macos
|
low
|
Major
|
604,390,734 |
flutter
|
[IME] Android InputMethodService onViewClicked callback won't be when clicking TextField
|
## Steps to Reproduce
I am an InputMethod developer，I find Flutter TextField won't invoked by click TextField. It happens in all Flutter Version
In Android Native App, click EditText will call `InputMethodService`'s onViewClicked, let IME develpoers know something is hanppen when user clicked an input area, but in flutter app, this callback won't be invoked.
I think we should add `TextInput.onclicked` method in `TextInputChannel` let IME developers know input area has been clicked.
|
a: text input,platform-android,framework,c: proposal,P3,team-design,triaged-design
|
low
|
Minor
|
604,417,942 |
pytorch
|
copy_ slowness
|
First reported by @roosephu.
This is not really a bug, but `copy_` seems to take too much time, so wanted to open an issue to see if this is expected.
```
from timeit import timeit
import torch
device = 'cpu'
# device = 'cuda'
n = 100
a = torch.zeros(n, n, device=device)
b = torch.zeros(n, n, device=device)
c = torch.zeros(n, n, device=device)
out = torch.zeros(n, n, device=device)
print(timeit('torch.addmm(a, b, c)', globals=globals(), number=100000))
print(timeit('torch.addmm(a, b, c, out=a)', globals=globals(), number=100000))
print(timeit('torch.addmm(a, b, c, out=out)', globals=globals(), number=100000))
print(timeit('torch.addmm(a, b, c, beta=0, out=out)', globals=globals(), number=100000))
```
Output
```
2.577985318377614
1.5019962769001722
2.3356163017451763
1.470768192782998
```
Note the second and fourth lines are much faster only because they skipped a `copy_` here https://github.com/pytorch/pytorch/blob/master/aten/src/TH/generic/THTensorMath.cpp#L54-L62
The `copy_` seems to be super expensive, is this expected?
cc: @ngimel
cc @ngimel @VitalyFedyunin
|
module: performance,module: cuda,triaged
|
low
|
Critical
|
604,422,571 |
go
|
x/tools/present: initial comment line now interpretted as a title
|
The present tool now supports Markdown syntax but also supports the previous present markup syntax. The switch to enable Markdown syntax use is that the first line (the talk title) be preceded with a `# `. Unfortunately, this coincides with the use of `# ` as a comment mark in the old syntax. In some cases, slides may contain copyright notices (I use present for lecture presentations and have done for some years now, so we require copyright notices). This puts the slide syntax into Markdown mode, which subsequently breaks because of the mutually unintelligible syntaxes.
It would be nice if there were a way to prevent present from assuming a `# ` prefix is a note to `present` to use Markdown. Or at the very least a more prominent warning that old slides have a significant risk of being broken (I'm actually happy we now have Markdown, but this will result in a fair bit of work for me to fix in my lecture presentations).
/cc @rsc
|
NeedsInvestigation,Tools
|
low
|
Critical
|
604,439,008 |
go
|
cmd/go: document 'internal' package visibility for module mode
|
<!--
Please answer these questions before submitting your issue. Thanks!
For questions please use one of our forums: https://github.com/golang/go/wiki/Questions
-->
### What version of Go are you using (`go version`)?
<pre>
$ go version
go version go1.14.2
</pre>
### Does this issue reproduce with the latest release?
yes
### What operating system and processor architecture are you using (`go env`)?
<details><summary><code>go env</code> Output</summary><br><pre>
$ go env
</pre></details>
### What did you do?
<!--
If possible, provide a recipe for reproducing the error.
A complete runnable program is good.
A link on play.golang.org is best.
-->
https://play.golang.org/p/tnQdiMMclCx
### What did you expect to see?
I expected the program to compile.
### What did you see instead?
prog.go:7:2: use of internal package example.com/v2/internal/foo not allowed
|
Documentation,help wanted,NeedsFix,GoCommand
|
low
|
Critical
|
604,478,013 |
vscode
|
vscode.workspace.fs.readDirectory() does not get all files (reparse points) under %USERPROFILE%\AppData\Local\Microsoft\WindowsApps
|
(for Python extension use)
<!-- ⚠️⚠️ Do Not Delete This! bug_report_template ⚠️⚠️ -->
<!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ -->
<!-- Please search existing issues to avoid creating duplicates. -->
<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: https://code.visualstudio.com/insiders/ -->
<!-- Use Help > Report Issue to prefill these. -->
- VSCode Version:1.44.2
- OS Version: Microsoft Windows 10 [Version 10.0.18362.778]
Steps to Reproduce:
1. Call `vscode.workspace.fs.readDirectory()` on `"C:\Users\*****\AppData\Local\Microsoft\WindowsApps"`
Notes:
I am not sure if they are regular symlinks, since `dir \a` does not show them as symlinks. They seem to be reparse points:
```
C:\Users\*****\AppData\Local\Microsoft\WindowsApps>dir /a
Volume in drive C is OSDisk
Volume Serial Number is CCED-E58F
Directory of C:\Users\karth\AppData\Local\Microsoft\WindowsApps
04/16/2020 12:51 PM <DIR> .
04/16/2020 12:51 PM <DIR> ..
04/16/2020 12:51 PM <DIR> Backup
03/10/2020 01:15 AM <DIR> CanonicalGroupLimited.UbuntuonWindows_79rhkp1fndgsc
03/24/2020 07:48 PM 0 debian.exe
04/14/2020 11:59 PM 0 GameBarElevatedFT_Alias.exe
04/16/2020 12:51 PM 0 idle.exe
04/16/2020 12:51 PM 0 idle3.8.exe
04/16/2020 12:51 PM 0 idle3.exe
11/09/2019 02:15 AM <DIR> Microsoft.DesktopAppInstaller_8wekyb3d8bbwe
11/13/2019 10:09 AM <DIR> Microsoft.MicrosoftEdge_8wekyb3d8bbwe
04/14/2020 11:59 PM <DIR> Microsoft.XboxGamingOverlay_8wekyb3d8bbwe
11/13/2019 10:09 AM 0 MicrosoftEdge.exe
04/16/2020 12:51 PM 0 pip.exe
04/16/2020 12:51 PM 0 pip3.8.exe
04/16/2020 12:51 PM 0 pip3.exe
04/16/2020 12:51 PM 0 python.exe
04/16/2020 12:51 PM 0 python3.8.exe
04/16/2020 12:51 PM 0 python3.exe
04/16/2020 12:51 PM <DIR> PythonSoftwareFoundation.Python.3.8_qbz5n2kfra8p0
04/16/2020 12:51 PM 0 pythonw.exe
04/16/2020 12:51 PM 0 pythonw3.8.exe
04/16/2020 12:51 PM 0 pythonw3.exe
03/24/2020 07:48 PM <DIR> TheDebianProject.DebianGNULinux_76v4gfsz19hv4
03/10/2020 01:15 AM 0 ubuntu.exe
16 File(s) 0 bytes
9 Dir(s) 42,065,428,480 bytes free
```
|
bug,upstream,file-io,nodejs,upstream-issue-linked
|
low
|
Critical
|
604,484,567 |
pytorch
|
CUDA error: device-side assert triggered @ model.cuda()
|
## 🐛 Bug
I'm trying to run BERT model. However, when I try to tell pytorch to run this model on the GPU, using: `model.cuda()`, I got the CUDA error: device-side assert triggered error.
## Detailed error message
```
---------------------------------------------------------------------------
RuntimeError Traceback (most recent call last)
<command-41501> in <module>
10
11 # Tell pytorch to run this model on the GPU.
---> 12 model.cuda()
/databricks/python/lib/python3.7/site-packages/torch/nn/modules/module.py in cuda(self, device)
302 Module: self
303 """
--> 304 return self._apply(lambda t: t.cuda(device))
305
306 def cpu(self):
/databricks/python/lib/python3.7/site-packages/torch/nn/modules/module.py in _apply(self, fn)
199 def _apply(self, fn):
200 for module in self.children():
--> 201 module._apply(fn)
202
203 def compute_should_use_set_data(tensor, tensor_applied):
/databricks/python/lib/python3.7/site-packages/torch/nn/modules/module.py in _apply(self, fn)
199 def _apply(self, fn):
200 for module in self.children():
--> 201 module._apply(fn)
202
203 def compute_should_use_set_data(tensor, tensor_applied):
/databricks/python/lib/python3.7/site-packages/torch/nn/modules/module.py in _apply(self, fn)
199 def _apply(self, fn):
200 for module in self.children():
--> 201 module._apply(fn)
202
203 def compute_should_use_set_data(tensor, tensor_applied):
/databricks/python/lib/python3.7/site-packages/torch/nn/modules/module.py in _apply(self, fn)
221 # `with torch.no_grad():`
222 with torch.no_grad():
--> 223 param_applied = fn(param)
224 should_use_set_data = compute_should_use_set_data(param, param_applied)
225 if should_use_set_data:
/databricks/python/lib/python3.7/site-packages/torch/nn/modules/module.py in <lambda>(t)
302 Module: self
303 """
--> 304 return self._apply(lambda t: t.cuda(device))
305
306 def cpu(self):
RuntimeError: CUDA error: device-side assert triggered
```
## Environmental Parameter
Pytorch version: 1.4.0
cc @ngimel
|
needs reproduction,module: cuda,triaged
|
low
|
Critical
|
604,562,816 |
TypeScript
|
Support parsing TSDoc string comments
|
Hi there!
I had a issue trip around Github and finally ended up here :)
Last issue was: https://github.com/microsoft/vscode/issues/95408
I am using String Literal types to define classnames and would love to populate with some more information.
So basically:
```ts
type TClassnames =
/** Some docs about red-500 */
| 'bg-color-red-500'
/** Some docs about red-600 */
| 'bg-color-red-600'
```
I would expect it to populate the docs on the right side of the intellisense:
<img width="521" alt="Screenshot 2020-02-12 at 07 31 36" src="https://user-images.githubusercontent.com/3956929/74308921-c0d04180-4d69-11ea-8953-48b7da62baa7.png">
This is how we can document with properties:
Which would be amazing to have on string literals.
I thought it was a TSDoc issue, but given this context: https://github.com/microsoft/tsdoc/issues/164, it seems to be VSCode not parsing it... though then it seems to actually be Typescript related?
|
Suggestion,Experience Enhancement
|
high
|
Critical
|
604,618,981 |
rust
|
macro_rules! and empty :vis metavariables
|
Hi.
I founds some bugs, did a research, and created a repository with reproducible examples, README, and instructions. Here is the content of README, and the whole repo is [attached as zip archive](https://github.com/rust-lang/rust/files/4515299/rustc-issues-vis-parse.zip). Code is highly documented, so please take a look. Code snippets and rust-playground are mostly useless, because we'are dealing with proc_macro multi-crate builds.
### Issues with macros and `:vis` meta-variable
I did a lot of experiments, and I think I found three issues at once:
1. Empty :vis meta-variable
According to the [documentation][doc-vis], `:vis` entity in `macro_rules!` should match empty visibility modifier:
`vis:` a possibly empty Visibility qualifier
While this is the case when visibility modifier is followed by some more stuff, it fails on its own:
```rust
macro_rules! q1 {
($visibility:vis) => {}
}
q1!(); // error: unexpected end of macro invocation
```
Followed by stuff:
```
macro_rules! q2 {
($visibility:vis $item:ident) => {}
}
q2!(foobar); // ok
```
Even though, adding ident-only branch still matches the first one (with `:vis`):
```
macro_rules! q3 {
($visibility:vis $item:ident) => {};
($item:ident) => {
compile_error!("Ident-only branch chosen instead of branch with empty vis");
};
}
q3!(foobar); // ok
```
Live rust code of these examples can be found in `./mac/src/q.rs`.
2. Forwarding empty :vis meta-variable
When rustc forwards empty `:vis` meta-variable, it creates an empty `proc_macro::TokenTree::Group` which has no delimiter (`proc_macro::Delimiter::None` aka Ø) nor inner stream content (empty `proc_macro::TokenStream`). While [`None`][doc-Delimiter] delimiters is a documented feature (quoted) "important to preserve operator priorities", they "may not survive roundtrip of a token stream through a string".
That leads to a workaround, but at the cost of losing context and spans of tokens:
```rust
let stream: proc_macro2::TokenStream = /* ... */;
let stream =
stream.to_string()
.parse::<proc_macro2::TokenStream>()
.unwrap();
```
Live rust code using this workaround can be found in `./usage/src/main.rs` (at the bottom) and `./mac/src/lib.rs` (turn the `USE_ROUNDTRIP` switch on).
Also, `quote!` macro does not produce empty groups like that, so it is higly inconsistent behavior.
Unlike `None` delimiter, completely empty group is not documented as a useful feature.
3. Parsing empty group with syn crate
Syn crate is somewhat inconsistent when it comes to parsing empty TokenTree Group.
Steps to reproduce:
1. Enable `mac_with_ident!(bar);` line in `./usage/src/with_ident.rs` by commenting out/removing `#[cfg!(none)]` attribute.
2. Turn off the `USE_ROUNDTRIP` switch in proc macro.
3. Try to build.
As can be seen from the error message `TAG_B: Error("unexpected token")`, `syn::parse2` has no problems parsing `syn::Visibility` out of the ParseStream with single empty group, but it fails to "complete" parsing because `ParseBuffer` is not [considered empty][ParseBuffer::is_empty] (it sees some "tokens" left in the buffer).
### Proposal:
1. Rustc macro matching
Fix rustc macro matching subsystem to accept calls without arguments (e.g. `q!()`) as matching arms with single `:vis` meta-variable (e.g. `macro_rules! q { ($v:vis) => {} }`)
2. Rust macro expansion
Fix rustc macro expansion subsystem to stop forwarding empty `vis` tokens as an empty groups.
3. Syn parser robustness
Regardless of fixed in rustc, syn/proc_macro2 crates should handle those empty groups gracefully AND uniformly.
Probably, skip those blank groups altogether. It's no good that they handle a "blank group" and a "blank group which is followed by stuff" cases differently.
### Meta
`rustc --version --verbose`:
```
rustc 1.42.0 (b8cedc004 2020-03-09)
binary: rustc
commit-hash: b8cedc00407a4c56a3bda1ed605c6fc166655447
commit-date: 2020-03-09
host: x86_64-unknown-linux-gnu
release: 1.42.0
LLVM version: 9.0
OS: Arch Linux
Kernel: x86_64 Linux 5.6.4-arch1-1
```
[doc-vis]: https://doc.rust-lang.org/reference/macros-by-example.html#metavariables
[ParseBuffer::is_empty]: https://docs.rs/syn/1.0.17/syn/parse/struct.ParseBuffer.html#method.is_empty
[doc-Delimiter]: https://doc.rust-lang.org/nightly/proc_macro/enum.Delimiter.html#variant.None
|
A-macros,T-compiler,C-bug
|
low
|
Critical
|
604,658,648 |
flutter
|
Flutter - Set target file base on Android product flavors
|
Currently I am using **Flutter** to build my application.
**Background**
I have followed some guide on building different environments entry files:
https://iirokrankka.com/2018/03/02/separating-build-environments/
which create main_dev.dart and main_prod.dart.
Also I have learnt to build flavor for both iOS and Android: https://medium.com/@salvatoregiordanoo/flavoring-flutter-392aaa875f36
which now I can use --flavor <FLAVOR> in the command to build different flavor application.
Now I have encountered a problem when I try to combine two skills.
**Target Result**
Below is what I would like to achieve:
development flavor -> main_dev.dart entry file
production flavor -> main_prod.dart entry file
Problem Encounter
in iOS side, I can target the entry file in .xcconfig file like following:
```
// ios/Flutter/development.xcconfig
#include "Generated.xcconfig"
FLUTTER_TARGET=lib/main_dev.dart
```
I know I can add -t lib/main_dev.dart after flutter run command.
However I would like to ask if there is any solution to set
the flutter target file in Android side inside flavor config?
Appreciate for any help.
|
c: new feature,platform-android,tool,d: api docs,a: build,P3,team-android,triaged-android
|
low
|
Major
|
604,659,733 |
pytorch
|
Misleading documentation in torch.nn.functional.fold
|
Related to this [discussion](https://discuss.pytorch.org/t/how-to-unfold-a-tensor-into-sliding-windows-and-then-fold-it-back/55890), I would like to report a misleading warning in https://github.com/pytorch/pytorch/blob/master/torch/nn/functional.py#L3676. As far as I can see, there is a mismatch between what the inline docs state, i.e. _"Currently, only 4-D output tensors (batched image-like tensors) are supported"_ and what is actually allowed in the function (3-D tensors).
I am reporting this as an issue in the documentation, but maybe this is also worth considering as a bug, since it feels weird that the 'fold' function doesn't accept 4-D tensors.
|
module: docs,module: nn,triaged
|
low
|
Critical
|
604,662,492 |
opencv
|
Feature request: masked cross-correlation of two images
|
##### Detailed description
Current implementation of template matching allows masked templates, but test images cannot be masked. Supporting test-image masking is really important, and has a lot of applications.
I believe this feature is relatively [easy to implement](https://9c0a87a5-a-62cb3a1a-s-sites.googlegroups.com/site/dirkpadfield/Home/MaskedFFTRegistrationPresentation.pdf?attachauth=ANoY7crwDzRQuLAxdVr7Xjvw1OIeNVEkbHJjUxBDmVNQ-MQ-k4EATlr9XCcDrVofPW1ZvJ0Mf4qP3nYdGw83p9dHKmIjSVG97ikT0dMyMu82RgkEfPwCUIQlFvaRCbHECCwBU_r1s1-AS1vMOZV3TOOUBf0HIYuGZXKAYbbWoz8Jw4D0geYcKqJb1TgmKEno6DTAfJ-egP6sNXtfBdfI1g2TrN6qRcLPx-b74AS_8VObIqH-tTQVx0AlZ1H9yBzwgQgapu98_5Cu&attredirects=0), and there are several open source implementations of it with compatible licenses.
In fact, I already found [an implementation](https://github.com/qedsoftware/masked_normxcorr) that is OpenCV-ready. @vpisarev @alalek What do you think?
|
feature,category: imgproc
|
low
|
Minor
|
604,669,223 |
youtube-dl
|
Please add https://premium.liebscher-bracht.com/
|
<!--
######################################################################
WARNING!
IGNORING THE FOLLOWING TEMPLATE WILL RESULT IN ISSUE CLOSED AS INCOMPLETE
######################################################################
-->
## Checklist
<!--
Carefully read and work through this check list in order to prevent the most common mistakes and misuse of youtube-dl:
- First of, make sure you are using the latest version of youtube-dl. Run `youtube-dl --version` and ensure your version is 2020.03.24. If it's not, see https://yt-dl.org/update on how to update. Issues with outdated version will be REJECTED.
- Make sure that all provided video/audio/playlist URLs (if any) are alive and playable in a browser.
- Make sure that site you are requesting is not dedicated to copyright infringement, see https://yt-dl.org/copyright-infringement. youtube-dl does not support such sites. In order for site support request to be accepted all provided example URLs should not violate any copyrights.
- Search the bugtracker for similar site support requests: http://yt-dl.org/search-issues. DO NOT post duplicates.
- Finally, put x into all relevant boxes (like this [x])
-->
- [x] I'm reporting a new site support request
- [x] I've verified that I'm running youtube-dl version **2020.03.24**
- [x] I've checked that all provided URLs are alive and playable in a browser
- [x] I've checked that none of provided URLs violate any copyrights
- [x] I've searched the bugtracker for similar site support requests including closed ones
<!--
Provide all kinds of example URLs support for which should be included. Replace following example URLs by yours.
-->
- Single video (this one requies a login): https://premium.liebscher-bracht.com/programs/5-minuten-premium-routinen_migranemp4-93e740
- Playlist (does not require login): https://premium.liebscher-bracht.com/programs/dehnubungen-deutschland-hat-rucken-e05e74?categoryId=16347
- Catalog page (all): https://premium.liebscher-bracht.com/catalog
- Catalog page (all free): https://premium.liebscher-bracht.com/categories/category-wPWkkNebtCQ
## Description
This site's content is in german. Some videos are for free (even without login account) and some of them requires a subscription (actually there is a free trial program for now)
<!--
Provide any additional information.
If work on your issue requires account credentials please provide them or explain how one can obtain them.
-->
If needed, login account can be created here: https://premium.liebscher-bracht.com/orders/customer_info?o=26414
Actually 3 month for free. Requires credit card or Paypal on creation and must be terminated before the trial period expires or continued on a paid subscription base.
|
site-support-request
|
low
|
Critical
|
604,671,019 |
terminal
|
Add support for `open-settings` subcommand
|
From the original spec:
> #### `open-settings`
>
> `open-settings [--defaults,-d]`
>
> Open the settings file. If this command is provided alone, it does not open the
> terminal window.
>
> **Parameters**:
> * `--defaults,-d`: Open the `defaults.json` file instead of the `profiles.json`
> file.
|
Product-Terminal,Issue-Task,Area-Commandline
|
low
|
Minor
|
604,671,039 |
terminal
|
Add support for `list-profiles` subcommand
|
From the original spec:
> #### `list-profiles`
>
> `list-profiles [--all,-A] [--showGuids,-g]`
>
> Displays a list of each of the available profiles. Each profile displays it's
> name, separated by newlines.
>
> **Parameters**:
> * `--all,-A`: Show all profiles, including profiles marked `"hidden": true`.
> * `--showGuids,-g`: In addition to showing names, also list each profile's
> guid. These GUIDs should probably be listed _first_ on each line, to make
> parsing output easier.
|
Product-Terminal,Issue-Task,Area-Commandline
|
low
|
Minor
|
604,671,087 |
terminal
|
Add support for `--file,-f configuration_file` for reading a list of commands from a file
|
From the original spec:
> Run these commands in the given Windows Terminal session. Enables opening new
> tabs in already running Windows Terminal windows. See [Future
> Considerations](#Future-Considerations) for more details.
|
Product-Terminal,Issue-Task,Area-Commandline
|
low
|
Minor
|
604,673,423 |
rust
|
Mismatched type error message when `!` (never) used as return
|
<!--
Thank you for filing a bug report! 🐛 Please provide a short summary of the bug,
along with any information you feel relevant to replicating the bug.
-->
I tried this code:
```rust
// Experiment: Dangling Reference
fn main() {
let s:&str = "Hello";
dangling_reference(s);
}
fn dangling_reference(s:&str) -> ! {
}
```
I expected to see this happen:
A suggestion to add `loop{}` inside `dangling_reference(s:&str)` function.
Instead, this happened:
```
mismatched types
expected `!`, found `()`
note: expected type `!`
found unit type `()`rustc(E0308)
main.rs(8, 4): implicitly returns `()` as its body has no tail or `return` expression
main.rs(8, 34): expected `!`, found `()`
```
### Meta
<!--
If you're using the stable version of the compiler, you should also check if the
bug also exists in the beta or nightly versions.
-->
`rustc --version --verbose`:
```
rustc 1.41.0 (5e1a79984 2020-01-27)
binary: rustc
commit-hash: 5e1a799842ba6ed4a57e91f7ab9435947482f7d8
commit-date: 2020-01-27
host: x86_64-unknown-linux-gnu
release: 1.41.0
LLVM version: 9.0
```
<!--
Include a backtrace in the code block by setting `RUST_BACKTRACE=1` in your
environment. E.g. `RUST_BACKTRACE=1 cargo build`.
-->
<details><summary>Backtrace</summary>
<p>
```
$ RUST_BACKTRACE=1 cargo build
Compiling rust_experiment v0.0.1 (/home/jajay/Projects/rust-experiment)
error[E0308]: mismatched types
--> src/main.rs:8:34
|
8 | fn dangling_reference(s:&str) -> ! {
| ------------------ ^ expected `!`, found `()`
| |
| implicitly returns `()` as its body has no tail or `return` expression
|
= note: expected type `!`
found unit type `()`
error: aborting due to previous error
For more information about this error, try `rustc --explain E0308`.
error: could not compile `rust_experiment`.
```
</p>
</details>
|
A-diagnostics,T-compiler,D-papercut
|
low
|
Critical
|
604,732,876 |
angular
|
[i18n] how to best support a library author providing translations for their library
|
We should discuss *how to best support a library author providing translations for their library*.
|
feature,area: i18n,freq1: low,P4,feature: under consideration,area: docs
|
medium
|
Major
|
604,734,359 |
pytorch
|
Deprecated mask fill mask type can causes pages and pages of repeated messages
|
## 🐛 Bug
When I install DrQA, https://github.com/facebookresearch/DrQA , with pytorch 1.4, the mask being provided is legacy, ie torch.uint8. pytorch correctly points out that this is legacy, and should be migrated to dtype torch.bool. However, rather than printing a single warning, it prints pages and pages of warnings, presumably one for each time the masked fill is called. I feel taht the warning should only be printed once. Example partial output:
```
/tmp/pip-req-build-o37zi_pa/aten/src/ATen/native/LegacyDefinitions.cpp:19: UserWarning: masked_fill_ received a mask with dtype torch.uint8, this behavior is now deprecated,please use a mask with dtype torch.bool instead.
/tmp/pip-req-build-o37zi_pa/aten/src/ATen/native/LegacyDefinitions.cpp:19: UserWarning: masked_fill_ received a mask with dtype torch.uint8, this behavior is now deprecated,please use a mask with dtype torch.bool instead.
/tmp/pip-req-build-o37zi_pa/aten/src/ATen/native/LegacyDefinitions.cpp:19: UserWarning: masked_fill_ received a mask with dtype torch.uint8, this behavior is now deprecated,please use a mask with dtype torch.bool instead.
/tmp/pip-req-build-o37zi_pa/aten/src/ATen/native/LegacyDefinitions.cpp:19: UserWarning: masked_fill_ received a mask with dtype torch.uint8, this behavior is now deprecated,please use a mask with dtype torch.bool instead.
/tmp/pip-req-build-o37zi_pa/aten/src/ATen/native/LegacyDefinitions.cpp:19: UserWarning: masked_fill_ received a mask with dtype torch.uint8, this behavior is now deprecated,please use a mask with dtype torch.bool instead.
/tmp/pip-req-build-o37zi_pa/aten/src/ATen/native/LegacyDefinitions.cpp:19: UserWarning: masked_fill_ received a mask with dtype torch.uint8, this behavior is now deprecated,please use a mask with dtype torch.bool instead.
/tmp/pip-req-build-o37zi_pa/aten/src/ATen/native/LegacyDefinitions.cpp:19: UserWarning: masked_fill_ received a mask with dtype torch.uint8, this behavior is now deprecated,please use a mask with dtype torch.bool instead.
/tmp/pip-req-build-o37zi_pa/aten/src/ATen/native/LegacyDefinitions.cpp:19: UserWarning: masked_fill_ received a mask with dtype torch.uint8, this behavior is now deprecated,please use a mask with dtype torch.bool instead.
```
I have logged the masked fill dtype issue at https://github.com/facebookresearch/DrQA/issues/249 . However, I feel taht DrQA cannot simply upgrade this, because will likely break backwards compatibility with earlier torch versions.
I feel that the correct fix is that deprecation warnings should be printed only once per python process.
## To Reproduce
Steps to reproduce the behavior:
1. install DrQA, https://github.com/facebookresearch/DrQA (which is a facebook repo actually...)
1. run, using `python scripts/pipeline/interactive.py --tokenizer regexp`
1. type `process('what is the capital of france?')`
1. watch the spammy deprecation messages...
## Expected behavior
Print the deprecation message once, and then stop.
## Environment
Please copy and paste the output from our
[environment collection script](https://raw.githubusercontent.com/pytorch/pytorch/master/torch/utils/collect_env.py)
(or fill out the checklist below manually).
You can get the script and run it with:
```
wget https://raw.githubusercontent.com/pytorch/pytorch/master/torch/utils/collect_env.py
# For security purposes, please check the contents of collect_env.py before running it.
python collect_env.py
```
- PyTorch Version (e.g., 1.0): 1.4
- OS (e.g., Linux): ubuntu 18.04
- How you installed PyTorch (`conda`, `pip`, source): conda
- Build command you used (if compiling from source): n/a
- Python version: 3.6
- CUDA/cuDNN version: 10.2
- GPU models and configuration: cpu only
- Any other relevant information:
## Additional context
|
triaged
|
low
|
Critical
|
604,737,965 |
pytorch
|
Saved model behaves differently on same data
|
```
def get_model():
model = PointModel()
model.cuda()
logging.info('load model from {}'.format(MODEL_PATH_POINTCNN))
model.load_state_dict(torch.load(MODEL_PATH_POINTCNN)['model_state'])
model.eval()
return model
net = get_model()
inputs = torch.randn(2, 4096, 8).cuda()
for i in range(2):
with torch.no_grad():
y = net(inputs)
print(y)
```
The question is that the above `y` is changed if the pretrained model is loaded, otherwise it is the same. This questions only occur in some network.
|
needs reproduction,module: serialization,triaged
|
low
|
Minor
|
604,738,456 |
pytorch
|
can't wrap two models in the same class
|
## 🐛 Bug
I define a class with model initializer. When I wrap one model with that class
it looks fine, but with two model instances, it does not converge.
Code example:
def wrapper(nn.Module):
def __init__(self, model):
self.model = model
def forward(self, x):
return self.model(x)
model1 = net1()
w_model1 = wrapper(mode1)
model2 = net2()
#when I include this line, w_model1 does not converge.
w_model2 = wrapper(model2)
## To Reproduce
Steps to reproduce the behavior:
1.
1.
1.
<!-- If you have a code sample, error messages, stack traces, please provide it here as well -->
## Expected behavior
<!-- A clear and concise description of what you expected to happen. -->
## Environment
Please copy and paste the output from our
[environment collection script](https://raw.githubusercontent.com/pytorch/pytorch/master/torch/utils/collect_env.py)
(or fill out the checklist below manually).
You can get the script and run it with:
```
wget https://raw.githubusercontent.com/pytorch/pytorch/master/torch/utils/collect_env.py
# For security purposes, please check the contents of collect_env.py before running it.
python collect_env.py
```
- PyTorch Version (e.g., 1.0):
- OS (e.g., Linux): Linux
- How you installed PyTorch (`conda`, `pip`, source): pip
- Build command you used (if compiling from source):
- Python version: 3.7
- CUDA/cuDNN version:
- GPU models and configuration:
- Any other relevant information:
## Additional context
<!-- Add any other context about the problem here. -->
|
needs reproduction,triaged
|
low
|
Critical
|
604,750,848 |
godot
|
Creating new image for ImageTexture logs errors to console
|
**Godot version:**
v3.2.2.rc.custom_build.36a30f681
**OS/device including version:**
Windows 10
**Issue description:**
It is not possible to create new image for ImageTexutre in editor. Errors are logged in console:
` drivers\gles3\rasterizer_storage_gles3.cpp:1097 - Condition "texture->data_size == 0 && !texture->render_target" is true. Returned: Ref<Image>()`
` drivers\gles3\rasterizer_storage_gles3.cpp:832 - Condition "!read.ptr()" is true.`
Also trying to load image shows warning
**Steps to reproduce:**
- Add Sprite node
- Select Sprite
- In Inspector for Sprite pick ImageTexture for Texture property
- Click on ImageTexture to expand it
- Click on [Empty] for Image property
- Click New Image
|
bug,topic:editor,confirmed
|
low
|
Critical
|
604,769,689 |
godot
|
Light Bleeding - Irregulrities in OmniLight/Shadow Atlas
|
**Godot version:**
v3.2.2.beta.custom_build.c7ad8f539
**OS/device including version:**
Linux (GeForce 940M)
**Issue description:**
Light bleeding depending on OmniLight rotation; independent of object position and rotation. It looks like there some kind of irregularities in the *OmniLight sphere*, especially at multiples of 90°:
[video_irregularities_omnilight.zip](https://github.com/godotengine/godot/files/4516164/video_irregularities_omnilight.zip)
In the video I only rotate the green sphere but the light bleeding position on the cube stays there, even if I translate/move the big green sphere.
This effect is not fixable by changing the bias or (indirect)energy of the light.
**Steps to reproduce:**
1. Open the minimal Project: No light bleeding should occur on the cube
2. Set "Project Settings ... -> Rendering -> Quality -> Shadow Atlas -> Size" to 8192: Light bleeding should now occur
3. Reset shadow atlas size to default: Light bleeding still occurs
Every object in the scene is only moved on the world x axis; object translation for y = 0 and z = 0.
Used project settings in the video (for better visibility):
With the default settings the issue seems to be very subtle. I use this kind of setup in one of my prototypes and the issue seems to occur just with different "intensities" (I was looking for the reason why objects behind my planet are still visible)
**Minimal reproduction project:**
[omnilight_project.zip](https://github.com/godotengine/godot/files/4516419/omnilight_project.zip)
|
bug,topic:rendering,topic:3d
|
low
|
Minor
|
604,800,521 |
rust
|
mailgun can stop delivering silently
|
Recently, it has come up that mailgun will suppress sending to a particular email if we bounce (too many times? unclear). We currently have no tracking, and the nature of our mailing lists means that such suppressions are really hard to notice for subscribers.
Infra wants to setup some monitoring so that we get an email or notification through our existing alerting system that this has happened.
|
P-low,T-infra
|
low
|
Minor
|
604,820,244 |
angular
|
Structural directive using selector with format "element[attribute]"
|
<!--🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅
Oh hi there! 😄
To expedite issue processing please search open and closed issues before submitting a new one.
Existing issues often contain information about workarounds, resolution, or progress updates.
🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅-->
# 🐞 bug report
### Affected Package
<!-- Can you pin-point one or more @angular/* packages as the source of the bug? -->
<!-- ✍️edit: --> The issue is related to package @angular/core and @angular/compiler, or if the behavior is by design, then it's a "documentation bug", since this directive selector usage is not said to not work when using directives with the "sugared" asterisk syntax.
### Is this a regression?
<!-- Did this behavior use to work in the previous version? -->
<!-- ✍️--> Not sure
### Description
<!-- ✍️--> When one try to create a structural directive using a selector with format "element[attribute]", Angular does not recognize the directive as valid for the element.
## 🔬 Minimal Reproduction
<!--
Please create and share minimal reproduction of the issue starting with this template: https://stackblitz.com/fork/angular-issue-repro2
-->
<!-- ✍️--> https://angular.io/generated/live-examples/structural-directives/stackblitz.html
Change the selector of directive appUnless to "p[appUnless]"
<!--
If StackBlitz is not suitable for reproduction of your issue, please create a minimal GitHub repository with the reproduction of the issue.
A good way to make a minimal reproduction is to create a new app via `ng new repro-app` and add the minimum possible code to show the problem.
Share the link to the repo below along with step-by-step instructions to reproduce the problem, as well as expected and actual behavior.
Issues that don't have enough info and can't be reproduced will be closed.
You can read more about issue submission guidelines here: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#-submitting-an-issue
-->
## 🔥 Exception or Error
<pre><code>Error in /turbo_modules/@angular/[email protected]/bundles/compiler.umd.js (2724:21)
Template parse errors:
Can't bind to 'appUnless' since it isn't a known property of 'p'.
</code></pre>
## 🌍 Your Environment
(see stackblitz)
|
hotlist: error messages,area: core,core: directive matching,type: confusing,P4
|
low
|
Critical
|
604,830,433 |
excalidraw
|
Intermediate slider changes shouldn't persist in the undo stack
|
1. Select something
2. Change opacity by a slider
3. Undo
Expected: it jumps to the previous "final" value
Actual: it barely changes because each intermediate slider movement is a part of undo stack
|
bug,history
|
low
|
Major
|
604,845,307 |
TypeScript
|
Declaration emit reveals paths within dependency that were not referred to in the source file
|
<!-- 🚨 STOP 🚨 𝗦𝗧𝗢𝗣 🚨 𝑺𝑻𝑶𝑷 🚨
Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Even if you think you've found a *bug*, please read the FAQ first, especially the Common "Bugs" That Aren't Bugs section!
Please help us by doing the following steps before logging an issue:
* Search: https://github.com/Microsoft/TypeScript/search?type=Issues
* Read the FAQ: https://github.com/Microsoft/TypeScript/wiki/FAQ
Please fill in the *entire* template below.
-->
Context:
- Generating declaration files
Declaration emit reveals paths within dependency that were not referred to in the source file:
```ts
export declare const instance: import("dependency/internal-types").TheInterface;
```
This is a problem because changing paths within a dependency can break a dependent package.
**TypeScript Version:** 3.9.0-dev.20200212
<!-- Search terms you tried before logging this (so others can find this issue more easily) -->
**Search Terms:**
- [inline import declaration](https://github.com/microsoft/TypeScript/issues?q=is%3Aissue+is%3Aopen+inline+import+declaration)
- [declaration external relative path](https://github.com/microsoft/TypeScript/issues?q=is%3Aissue+is%3Aopen+declaration+external+relative+path+)
**Code**
`node_modules/@types/dependency/entrypoint.d.ts`
```ts
import { TheInterface } from "./internal-types";
export { TheInterface };
export declare function getInstance(): TheInterface;
```
`node_modules/@types/dependency/internal-types.d.ts`
```ts
export interface TheInterface {}
```
`node_modules/@types/dependency/index.d.ts`
```
// empty - doesn't matter for this example
```
`example.ts`
```ts
import { getInstance } from "dependency/entrypoint";
export const instance = getInstance();
```
`src/app/tsconfig.json`
```json
{
"compilerOptions": {
"declaration": true,
}
}
```
**Expected behavior:**
`example.d.ts`
```ts
export declare const instance: import("dependency/entrypoint").TheInterface;
```
**Actual behavior:**
`example.d.ts`
```ts
export declare const instance: import("dependency/internal-types").TheInterface;
```
It seems that part of the solution could involve having the compiler avoid using relative paths in types (`import("<relativepath>").<typename>`) if the `relativepath` is outside the project.
**Repro Repo:** https://github.com/mheiber/repro-rel-import-inlining
**Related Issues:** <!-- Did you find other bugs that looked similar? -->
- Declaration emit should not inline type definitions - #37151
- Proposal: Bundling TS module type definitions - #4433
**Issue written with the help of**: @rricard, @robpalme and @mkubilayk
|
Needs Investigation,Rescheduled
|
low
|
Critical
|
604,870,588 |
pytorch
|
Result parameters from Single-Process Multi-GPU DDP training on RNN do not match local training
|
The following code passes if `net = nn.Linear(2, 2).cuda()`
```python
ddp = nn.parallel.DistributedDataParallel(
copy.deepcopy(net),
process_group=process_group
)
net_opt = torch.optim.Adam(net.parameters(), lr=0.001)
ddp_opt = torch.optim.Adam(ddp.parameters(), lr=0.001)
for i, j in zip(ddp.parameters(), net.parameters()):
self.assertTrue(i.allclose(j))
for _ in range(1):
net_out = net(*inp)
ddp_out = ddp(*inp)
net_out.sum().backward()
ddp_out.sum().backward()
net_opt.step()
ddp_opt.step()
for i, j in zip(ddp.parameters(), net.parameters()):
self.assertTrue(i.allclose(j))
```
However, if I set `net` to the following RNN model, the final parameter `allclose` check would fail. This requires multiple GPUs to reproduce.
```python
BATCH_SIZE = 4
INPUT_DIM = 256
OUTPUT_DIM = 256
HIDDEN_DIM = 256
N_LAYERS = 3
SEQ_LEN = 100
class Net(nn.Module):
def __init__(self, input_dim, hidden_dim, output_dim, hidden_layers):
super(Net, self).__init__()
self.input_dim = input_dim
self.hidden_dim = hidden_dim
self.output_dim = output_dim
self.hidden_layers = hidden_layers
self.lstm = nn.LSTM(input_dim, hidden_dim, hidden_layers, batch_first=True)
self.h2o = nn.Linear(hidden_dim, output_dim)
def forward(self, x, y):
self.lstm.flatten_parameters()
h_t, _ = self.lstm(x)
output = self.h2o(h_t)
loss = F.mse_loss(output, y)
return loss
net = Net(INPUT_DIM, HIDDEN_DIM, OUTPUT_DIM, N_LAYERS).cuda()
```
But as Single-Process Multi-GPU is not the recommended mode, we might end up getting rid of this mode soon.
cc @pietern @mrshenli @pritamdamania87 @zhaojuanmao @satgera @rohan-varma @gqchen @aazzolini @xush6528 @osalpekar
|
oncall: distributed,triaged
|
low
|
Minor
|
604,892,747 |
TypeScript
|
Recognize property with name defined by constant in Object.defineProperty
|
## Search Terms
defineProperty
https://github.com/microsoft/TypeScript/issues/28694 is touching same domain
## Suggestion
(Note: I'm using TS in JS files, have basically no knowledge about "pure" TS)
Compiler should recognize prototype property added using Object.defineProperty with name defined not only by string constant but also a string variable, e.g.:
```
const propName = 'myProp';
Object.defineProperty(Test.prototype, propName, { get: () => 'myVal' });
```
[Playground Link](https://www.typescriptlang.org/play/?experimentalDecorators=true&target=99&ssl=1&ssc=1&pln=21&pc=50&useJavaScript=true#code/PTAEAcCcHtwU0gFwJZwM6gIYBNt26MgHah4BmxcACjPEgJ6gBQAxgDaZoYAq6ioAb1ABfJgHkARgCs4LRADpylGrASJ6ACl5oFUaIn314AGlAByaEThnTQgOZxEALlAaAlKAC8APlABGETcAblZLHVBEAHdoADlMAFs4L3Mo6DMQyRk5RTgKKxU6dS0+eT0DdRMI6LjE21AHZ1cPH1AAJkCQplCicOJwz1ArSNBtRHcQvoVLOAmehVSg0CWQQf1QSFloOyJkAC98UAlGFmh48DZUSC6VvBPITAMrsgBXIjlkS1JNjURMSAaPAImEslplZAolPlaGpNL9-o5SjBykY4KYzPF6AUbIJ6o4XO4vL4zAA3TBsMwdJiiJgAAVu0FYHC4oAAIpt7ogDkJqSc5l8TgBJPkDIas9kPfDjJj0oU6eQYgqLEErIhrDYnbZ7A5HUAnM7INgIIA)
(included also desired behavior for decorators, but as it's experimental feature, you won't propably even consider it)
I understand it's not always possible to make sure variable with property name is not reassigned during runtime, but it seems that TS compiler can handle detection of "static" variables that have known value during compilation.
## Use Cases
This way we could define class properties using "single source" and not duplicating code. For example a class providing access to key-value pairs object in a dotted notation instead of string values for keys, whilst the object can be used for another purpose.
## Examples
```
// i can use these somewhere else, e.g. as a type
export const defaults = {
one: 1,
two: 2
}
// properties added in defineProperty
export class Test {
// i don't want to repeat myself
one = defaults.one;
/** @param {keyof defaults} key */
get(key) {
return defaults[key];
}
}
Object.keys(defaults).forEach((key) =>
Object.defineProperty(Test.prototype, key, { get: () => defaults[key] })
);
const inst = new Test();
inst.one; // who would not like this?
inst.get('one'); // instead of this
```
[Playground Link](https://www.typescriptlang.org/play/?useJavaScript=true#)
## Checklist
My suggestion meets these guidelines:
* [x] This wouldn't be a breaking change in existing TypeScript/JavaScript code
* [x] This wouldn't change the runtime behavior of existing JavaScript code
* [x] This could be implemented without emitting different JS based on the types of the expressions
* [x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
* [x] This feature would agree with the rest of [TypeScript's Design Goals](https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals).
|
Suggestion,Awaiting More Feedback
|
low
|
Minor
|
604,949,179 |
flutter
|
Define Default Device
|
<!-- Thank you for using Flutter!
If you are looking for support, please check out our documentation
or consider asking a question on Stack Overflow:
* https://flutter.dev/
* https://api.flutter.dev/
* https://stackoverflow.com/questions/tagged/flutter?sort=frequent
If you have found a bug or if our documentation doesn't have an answer
to what you're looking for, then fill our the template below. Please read
our guide to filing a bug first: https://flutter.dev/docs/resources/bug-reports
-->
## Use case
<!--
Please tell us the problem you are running into that led to you wanting
a new feature.
Is your feature request related to a problem? Please give a clear and
concise description of what the problem is.
Describe alternative solutions you've considered. Is there a package
on pub.dev/flutter that already solves this?
-->
Whenever I load up a project and run `flutter run` I sometimes forget to change the device. For projects such as my website where the default platform isn't mobile it is kinda a pain to have to change the device every time.
## Proposal
<!--
Briefly but precisely describe what you would like Flutter to be able to do.
Consider attaching images showing what you are imagining.
Does this have to be provided by Flutter directly, or can it be provided
by a package on pub.dev/flutter? If so, maybe consider implementing and
publishing such a package rather than filing a bug.
-->
Define in your `pubspec.yaml` the default device or platform. For example `default: macOS`
|
c: new feature,tool,P3,team-tool,triaged-tool
|
low
|
Critical
|
604,950,219 |
flutter
|
odd behavior of Link in MemoryFileSystem on windows
|
```
final FileSystem fileSystem = MemoryFileSystem.test();
fileSystem.file('a/b.txt').createSync(recursive: true);
final Link link = fileSystem.link('a/c.txt').createSync('a/b.txt');
print(link.existsSync()); // prints true
print(fileSystem.typeSync('a/c.txt')); // prints "notFound"
```
|
tool,P2,team-tool,triaged-tool
|
low
|
Minor
|
604,970,896 |
pytorch
|
nn.Bilinear cannot be used inside nn.Sequential
|
## 🐛 Bug
Using `nn.Bilinear` inside a `nn.Sequential` raises a `TypeError` because `nn.Sequential` doesn't support multiple inputs.
## To Reproduce
Steps to reproduce the behavior:
```python
import torch
bilinear = torch.nn.Bilinear(4, 8, 12)
bilinear_seq = torch.nn.Sequential(bilinear)
input_1 = torch.zeros((10, 4))
input_2 = torch.zeros((10, 8))
print(f'bilinear output dims: {bilinear(input_1, input_2).shape}')
print(f'sequential bilinear output dims: {bilinear_seq(input_1, input_2).shape}')
```
Output:
```bash
bilinear output dims: torch.Size([10, 12])
---------------------------------------------------------------------------
TypeError Traceback (most recent call last)
in
9 print(f'expected output dims:\n{(10, 12)}')
10 print(f'bilinear output dims:\n{bilinear(input_1, input_2).shape}')
---> 11 print(f'sequential bilinear output dims:\n{bilinear_seq(input_1, input_2).shape}')
~/anaconda3/envs/ae/lib/python3.7/site-packages/torch/nn/modules/module.py in __call__(self, *input, **kwargs)
538 result = self._slow_forward(*input, **kwargs)
539 else:
--> 540 result = self.forward(*input, **kwargs)
541 for hook in self._forward_hooks.values():
542 hook_result = hook(self, input, result)
TypeError: forward() takes 2 positional arguments but 3 were given
```
<!-- If you have a code sample, error messages, stack traces, please provide it here as well -->
## Expected behavior
One would expect `nn.Sequential` to work with any number of inputs as long as the inputs are passed correctly from one module to the next one inside `nn.Sequential`.
## Environment
PyTorch version: 1.5.0.dev20200210+cu100
Is debug build: No
CUDA used to build PyTorch: 10.0
OS: Ubuntu 18.10
GCC version: (Ubuntu 8.3.0-6ubuntu1~18.10.1) 8.3.0
CMake version: version 3.12.1
Python version: 3.7
Is CUDA available: Yes
CUDA runtime version: 10.1.168
GPU models and configuration:
GPU 0: TITAN X (Pascal)
GPU 1: GeForce RTX 2080
Nvidia driver version: 418.67
cuDNN version: Could not collect
Versions of relevant libraries:
[pip3] numpy==1.16.4
[conda] _pytorch_select 0.2 gpu_0
[conda] blas 1.0 mkl
[conda] cudatoolkit 10.0.130 0
[conda] mkl 2019.4 243
[conda] mkl-service 2.3.0 py37he904b0f_0
[conda] mkl_fft 1.0.15 py37ha843d7b_0
[conda] mkl_random 1.1.0 py37hd6b4f25_0
[conda] numpy 1.17.4 py37hc1035e2_0
[conda] numpy-base 1.17.4 py37hde5b4d6_0
[conda] torch 1.5.0.dev20200210+cu100 pypi_0 pypi
[conda] torch-nightly 1.2.0.dev20190805 pypi_0 pypi
[conda] torchsnooper 0.7.1 pypi_0 pypi
[conda] torchvision 0.6.0.dev20200210+cu100 pypi_0 pypi
## Additional context
<!-- Add any other context about the problem here. -->
|
feature,module: nn,triaged
|
low
|
Critical
|
604,971,572 |
youtube-dl
|
Please add Sportsnet.ca
|
<!--
######################################################################
WARNING!
IGNORING THE FOLLOWING TEMPLATE WILL RESULT IN ISSUE CLOSED AS INCOMPLETE
######################################################################
-->
## Checklist
<!--
Carefully read and work through this check list in order to prevent the most common mistakes and misuse of youtube-dl:
- First of, make sure you are using the latest version of youtube-dl. Run `youtube-dl --version` and ensure your version is 2020.03.24. If it's not, see https://yt-dl.org/update on how to update. Issues with outdated version will be REJECTED.
- Make sure that all provided video/audio/playlist URLs (if any) are alive and playable in a browser.
- Make sure that site you are requesting is not dedicated to copyright infringement, see https://yt-dl.org/copyright-infringement. youtube-dl does not support such sites. In order for site support request to be accepted all provided example URLs should not violate any copyrights.
- Search the bugtracker for similar site support requests: http://yt-dl.org/search-issues. DO NOT post duplicates.
- Finally, put x into all relevant boxes (like this [x])
-->
- [x] I'm reporting a new site support request
- [x] I've verified that I'm running youtube-dl version **2020.03.24**
- [x] I've checked that all provided URLs are alive and playable in a browser
- [x] I've checked that none of provided URLs violate any copyrights
- [x] I've searched the bugtracker for similar site support requests including closed ones
## Example URLs
<!--
Provide all kinds of example URLs support for which should be included. Replace following example URLs by yours.
-->
- Single video: https://www.sportsnet.ca/football/nfl/draft-chatter-former-nfl-scout-benjamin-allbright-follow-money/
## Description
<!--
Provide any additional information.
If work on your issue requires account credentials please provide them or explain how one can obtain them.
-->
WRITE DESCRIPTION HERE
youtube-dl https://www.sportsnet.ca/football/nfl/draft-chatter-former-nfl-scout-benjamin-allbright-follow-money/ -v
[debug] System config: []
[debug] User config: ['-o', 'C:\\Users\\Haleigh\\Youtube-dl Videos\\%(upload_date)s-%(uploader)s_-_%(title)s.%(ext)s', '--external-downloader', 'aria2c', '--external-downloader-args', '-j 12 -s 12 -x 12 -k 5M']
[debug] Custom config: []
[debug] Command-line args: ['https://www.sportsnet.ca/football/nfl/draft-chatter-former-nfl-scout-benjamin-allbright-follow-money/', '-v']
[debug] Encodings: locale cp1252, fs mbcs, out cp850, pref cp1252
[debug] youtube-dl version 2020.03.24
[debug] Python version 3.4.4 (CPython) - Windows-10-10.0.18362
[debug] exe versions: ffmpeg 4.2.2, ffprobe 4.2.2, rtmpdump 2.4
[debug] Proxy map: {}
[generic] draft-chatter-former-nfl-scout-benjamin-allbright-follow-money: Requesting header
WARNING: Falling back on generic information extractor.
[generic] draft-chatter-former-nfl-scout-benjamin-allbright-follow-money: Downloading webpage
[generic] draft-chatter-former-nfl-scout-benjamin-allbright-follow-money: Extracting information
[download] Downloading playlist: Draft rumours with former NFL scout Benjamin Allbright | Follow The Money - Sportsnet.ca
[generic] playlist Draft rumours with former NFL scout Benjamin Allbright | Follow The Money - Sportsnet.ca: Collected 1 video ids (downloading 1 of them)
[download] Downloading video 1 of 1
[brightcove:legacy] 6151055776001: Downloading webpage
WARNING: unable to extract player key; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type youtube-dl -U to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
ERROR: Unsupported URL: http://c.brightcove.com/services/viewer/federated_f9/?isVid=1&isUI=1&playerID=3494158530001&autoStart=false&%40videoPlayer=6151055776001
Traceback (most recent call last):
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpjwbwqymm\build\youtube_dl\YoutubeDL.py", line 797, in extract_info
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpjwbwqymm\build\youtube_dl\extractor\common.py", line 530, in extract
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpjwbwqymm\build\youtube_dl\extractor\brightcove.py", line 335, in _real_extract
youtube_dl.utils.UnsupportedError: Unsupported URL: http://c.brightcove.com/services/viewer/federated_f9/?isVid=1&isUI=1&playerID=3494158530001&autoStart=false&%40videoPlayer=6151055776001
|
site-support-request
|
low
|
Critical
|
604,977,699 |
rust
|
All debuginfo tests fail on sparc64 on Linux
|
One of the few remaining issues on sparc64 on Linux are the debuginfo tests, they all fail which is why I assume we're missing some definitions here or there something regarding the debugging part is generally broken:
```
test [debuginfo-gdb] debuginfo/borrowed-c-style-enum.rs ... FAILED
test [debuginfo-gdb] debuginfo/borrowed-enum.rs ... FAILED
test [debuginfo-gdb] debuginfo/borrowed-basic.rs ... FAILED
test [debuginfo-gdb] debuginfo/function-call.rs ... FAILED
test [debuginfo-gdb] debuginfo/generic-enum-with-different-disr-sizes.rs ... FAILED
test [debuginfo-gdb] debuginfo/generic-struct.rs ... FAILED
test [debuginfo-gdb] debuginfo/evec-in-struct.rs ... FAILED
test [debuginfo-gdb] debuginfo/extern-c-fn.rs ... FAILED
test [debuginfo-gdb] debuginfo/gdb-pretty-struct-and-enums.rs ... FAILED
test [debuginfo-gdb] debuginfo/by-value-self-argument-in-trait-impl.rs ... FAILED
test [debuginfo-gdb] debuginfo/generic-struct-style-enum.rs ... FAILED
test [debuginfo-gdb] debuginfo/include_string.rs ... FAILED
test [debuginfo-gdb] debuginfo/generic-tuple-style-enum.rs ... FAILED
test [debuginfo-gdb] debuginfo/lexical-scope-in-unique-closure.rs ... FAILED
test [debuginfo-gdb] debuginfo/lexical-scope-in-stack-closure.rs ... FAILED
test [debuginfo-gdb] debuginfo/lexical-scope-in-match.rs ... FAILED
test [debuginfo-gdb] debuginfo/lexical-scope-in-unconditional-loop.rs ... FAILED
test [debuginfo-gdb] debuginfo/lexical-scope-in-for-loop.rs ... FAILED
test [debuginfo-gdb] debuginfo/destructured-local.rs ... FAILED
test [debuginfo-gdb] debuginfo/lexical-scope-in-while.rs ... FAILED
test [debuginfo-gdb] debuginfo/lexical-scope-in-if.rs ... FAILED
test [debuginfo-gdb] debuginfo/destructured-fn-argument.rs ... FAILED
test [debuginfo-gdb] debuginfo/lexical-scope-with-macro.rs ... FAILED
test [debuginfo-gdb] debuginfo/multi-cgu.rs ... FAILED
test [debuginfo-gdb] debuginfo/multiple-functions-equal-var-names.rs ... FAILED
test [debuginfo-gdb] debuginfo/multiple-functions.rs ... FAILED
test [debuginfo-gdb] debuginfo/shadowed-argument.rs ... FAILED
test [debuginfo-gdb] debuginfo/name-shadowing-and-scope-nesting.rs ... FAILED
test [debuginfo-gdb] debuginfo/static-method-on-struct-and-enum.rs ... FAILED
test [debuginfo-gdb] debuginfo/simd.rs ... FAILED
test [debuginfo-gdb] debuginfo/simple-lexical-scope.rs ... FAILED
test [debuginfo-gdb] debuginfo/shadowed-variable.rs ... FAILED
test [debuginfo-gdb] debuginfo/tuple-style-enum.rs ... FAILED
test [debuginfo-gdb] debuginfo/tuple-in-tuple.rs ... FAILED
test [debuginfo-gdb] debuginfo/tuple-struct.rs ... FAILED
test [debuginfo-gdb] debuginfo/struct-style-enum.rs ... FAILED
test [debuginfo-gdb] debuginfo/var-captured-in-sendable-closure.rs ... FAILED
test [debuginfo-gdb] debuginfo/tuple-in-struct.rs ... FAILED
```
Any pointers where I should start looking?
Full log at: https://buildd.debian.org/status/fetch.php?pkg=rustc&arch=sparc64&ver=1.42.0%2Bdfsg1-1&stamp=1586554512&raw=0
CC @psumbera
|
A-testsuite,A-debuginfo,T-compiler,O-SPARC,C-bug
|
low
|
Critical
|
604,988,271 |
storybook
|
Addon-Docs: Changing the theme via api doesn't persist in Docs
|
**Describe the bug**
I have an addon tool that handles the storybook theme through the api:
```
// inside my addon
api.setOptions ({
theme: themes[base],
});
```
The Storybook matches, but Docs don't change.
Docs works with the dark theme just by adding through addParametes:
```
// config.js
import { themes } from '@storybook/theming';
addParameters({
options: {
theme: themes.dark,
},
```
**Expected behavior**
That when changing the theme through the storybook API, it trigger the Docs theme
**Screenshots**
**System:**
Environment Info:
System:
OS: macOS 10.15.4
CPU: (4) x64 Intel(R) Core(TM) i5-5257U CPU @ 2.70GHz
Binaries:
Node: 10.16.0 - /usr/local/bin/node
Yarn: 1.9.4 - /usr/local/bin/yarn
npm: 6.13.7 - /usr/local/bin/npm
Browsers:
Chrome: 81.0.4044.122
Firefox: 74.0
Safari: 13.1
npmPackages:
@storybook/addon-a11y: ^5.3.18 => 5.3.18
@storybook/addon-actions: ^5.3.18 => 5.3.18
@storybook/addon-docs: ^5.3.18 => 5.3.18
@storybook/addon-knobs: ^5.3.18 => 5.3.18
@storybook/addon-storysource: ^5.3.18 => 5.3.18
@storybook/addon-viewport: ^5.3.18 => 5.3.18
@storybook/addons: ^5.3.18 => 5.3.18
@storybook/react: ^5.3.18 => 5.3.18
@storybook/storybook-deployer: ^2.8.3 => 2.8.5
|
feature request,theming,addon: docs
|
medium
|
Critical
|
605,011,760 |
go
|
x/tools/gopls: autocompletion is appended to typed word
|
#### What did you do?
In VSCode, typed part of a word to autocomplete it, e.g. `cancel`, then selected `cancelCtx`.
#### What did you expect to see?
I expected the current word to be `cancelCtx`.
#### What did you see instead?
Current word became `canccancelCtx`.
#### Build info
Also getting this behaviour with v0.4.0.
```
golang.org/x/tools/gopls v0.3.4
golang.org/x/tools/gopls@(devel)
github.com/BurntSushi/[email protected] h1:WXkYYl6Yr3qBf1K79EBnL4mak0OimBfB0XUf9Vl28OQ=
github.com/sergi/[email protected] h1:Kpca3qRNrduNnOQeazBd0ysaKrUJiIuISHxogkT9RPQ=
golang.org/x/[email protected] h1:WG0RUwxtNT4qqaXX3DPA8zHFNm/D9xaBpxzHt1WcA/E=
golang.org/x/[email protected] h1:8gQV6CLnAEikrhgkHFbMAEhagSSnXWGV915qUMm9mrU=
golang.org/x/[email protected] => ../
golang.org/x/[email protected] h1:/atklqdjdhuosWIl6AIbOeHJjicWYPqR9bpxqxYG2pA=
honnef.co/go/[email protected] h1:sXmLre5bzIR6ypkjXCDI3jHPssRhc8KD/Ome589sc3U=
mvdan.cc/xurls/[email protected] h1:KaMb5GLhlcSX+e+qhbRJODnUUBvlw01jt4yrjFIHAuA=
```
#### Go info
```
go version go1.14 darwin/amd64
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/alex/Library/Caches/go-build"
GOENV="/Users/alex/Library/Application Support/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOINSECURE=""
GONOPROXY="github.com/t11e/*,github.com/sanity-io/gradient"
GONOSUMDB="github.com/t11e/*,github.com/sanity-io/gradient"
GOOS="darwin"
GOPATH="/Users/alex/.go"
GOPRIVATE="github.com/t11e/*,github.com/sanity-io/gradient"
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/opt/go/libexec"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/opt/go/libexec/pkg/tool/darwin_amd64"
GCCGO="gccgo"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD="/Users/alex/Code/golang-tools/gopls/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/qs/wpmg19r12_9_nz7pvvs2_82r0000gn/T/go-build188118376=/tmp/go-build -gno-record-gcc-switches -fno-common"
```
#### VSCode
```
Version: 1.44.2
Commit: ff915844119ce9485abfe8aa9076ec76b5300ddd
Date: 2020-04-16T17:07:18.473Z
Electron: 7.1.11
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Darwin x64 19.3.0
```
VSCode-Go 0.14.1.
#### Log
[gopls.log.gz](https://github.com/golang/go/files/4518601/gopls.log.gz)
|
help wanted,gopls,Tools
|
medium
|
Critical
|
605,034,855 |
go
|
runtime: weird panic while dumping non-pointer struct with wrapped error
|
<!--
Please answer these questions before submitting your issue. Thanks!
For questions please use one of our forums: https://github.com/golang/go/wiki/Questions
-->
### What version of Go are you using (`go version`)?
<pre>
$ go version
go version go1.14.2 linux/amd64
</pre>
### Does this issue reproduce with the latest release?
Yes.
### What operating system and processor architecture are you using (`go env`)?
<details><summary><code>go env</code> Output</summary><br><pre>
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/powerman/.cache/go-build"
GOENV="/home/powerman/.config/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/home/powerman/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/lib/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/lib/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
AR="ar"
CC="x86_64-pc-linux-gnu-gcc"
CXX="x86_64-pc-linux-gnu-g++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build368985502=/tmp/go-build -gno-record-gcc-switches"
</pre></details>
### What did you do?
<!--
If possible, provide a recipe for reproducing the error.
A complete runnable program is good.
A link on play.golang.org is best.
-->
I was running `go test` on my package, which in turn called https://godoc.org/github.com/powerman/check#C.Nil at value returned by https://godoc.org/github.com/powerman/rpc-codec/jsonrpc2#WrapError.
The value itself was implemented this way https://github.com/powerman/rpc-codec/blob/v1.2.0/jsonrpc2/errors.go#L96-L116 and contains valid non-nil wrapped error inside.
Line https://github.com/powerman/rpc-codec/blob/v1.2.0/jsonrpc2/errors.go#L111 generates different panics at different `go test` runs, like these:
- first example:
```
unexpected fault address 0xffffffffffff80a7
fatal error: fault
[signal SIGSEGV: segmentation violation code=0x1 addr=0xffffffffffff80a7 pc=0x7d0474]
```
- second example:
```
fatal error: bulkBarrierPreWrite: unaligned arguments
```
<details><summary>Complete panic one</summary><br><pre>
=== RUN TestGetStr
unexpected fault address 0xffffffffffff80a7
fatal error: fault
[signal SIGSEGV: segmentation violation code=0x1 addr=0xffffffffffff80a7 pc=0x7d0474]
goroutine 37 [running]:
runtime.throw(0x9b6e95, 0x5)
/usr/lib/go/src/runtime/panic.go:1116 +0x72 fp=0xc000135580 sp=0xc000135550 pc=0x436762
runtime.sigpanic()
/usr/lib/go/src/runtime/signal_unix.go:702 +0x3cc fp=0xc0001355b0 sp=0xc000135580 pc=0x44ccdc
github.com/powerman/rpc-codec/jsonrpc2.wrapError.Error(...)
/home/powerman/go/pkg/mod/github.com/powerman/[email protected]/jsonrpc2/errors.go:111
github.com/powerman/rpc-codec/jsonrpc2.(*wrapError).Error(0xc000316150, 0x925800, 0xc000316150)
<autogenerated>:1 +0x44 fp=0xc000135628 sp=0xc0001355b0 pc=0x7d0474
github.com/davecgh/go-spew/spew.handleMethods(0xe0da80, 0xa78160, 0xc0003161b0, 0x94ff20, 0xc000316150, 0x19, 0x0)
/home/powerman/go/pkg/mod/github.com/davecgh/[email protected]/spew/common.go:125 +0x316 fp=0xc000135750 sp=0xc000135628 pc=0x88c646
github.com/davecgh/go-spew/spew.(*dumpState).dump(0xc000135960, 0x94ff20, 0xc000316150, 0x19)
/home/powerman/go/pkg/mod/github.com/davecgh/[email protected]/spew/dump.go:306 +0x1399 fp=0xc0001358f8 sp=0xc000135750 pc=0x8917f9
github.com/davecgh/go-spew/spew.fdump(0xe0da80, 0xa78160, 0xc0003161b0, 0xc000135b48, 0x1, 0x1)
/home/powerman/go/pkg/mod/github.com/davecgh/[email protected]/spew/dump.go:465 +0x159 fp=0xc0001359a0 sp=0xc0001358f8 pc=0x891e79
github.com/davecgh/go-spew/spew.(*ConfigState).Sdump(0xe0da80, 0xc000135b48, 0x1, 0x1, 0xc000135aa8, 0x89ae79)
/home/powerman/go/pkg/mod/github.com/davecgh/[email protected]/spew/config.go:281 +0x78 fp=0xc0001359e8 sp=0xc0001359a0 pc=0x88ed98
github.com/powerman/check.newDump(0x94ff20, 0xc000316150, 0x1, 0xc0003201e0, 0x0, 0xdba748)
/home/powerman/go/pkg/mod/github.com/powerman/[email protected]/dump.go:70 +0x8c fp=0xc000135c08 sp=0xc0001359e8 pc=0x8a602c
github.com/powerman/check.(*C).report(0xc00019c3f0, 0xdba700, 0x0, 0x0, 0x0, 0xdba767, 0x3, 0xc000135dd8, 0x1, 0x1, ...)
/home/powerman/go/pkg/mod/github.com/powerman/[email protected]/check.go:136 +0x12a fp=0xc000135d58 sp=0xc000135c08 pc=0x89af5a
github.com/powerman/check.(*C).report1(0xc00019c3f0, 0x94ff20, 0xc000316150, 0x0, 0x0, 0x0, 0xc000328100, 0x2d)
/home/powerman/go/pkg/mod/github.com/powerman/[email protected]/check.go:204 +0x12c fp=0xc000135df8 sp=0xc000135d58 pc=0x89bfbc
github.com/powerman/check.(*C).Nil(0xc00019c3f0, 0x94ff20, 0xc000316150, 0x0, 0x0, 0x0, 0xc000316150)
/home/powerman/go/pkg/mod/github.com/powerman/[email protected]/check.go:346 +0x97 fp=0xc000135e48 sp=0xc000135df8 pc=0x89cba7
github.com/dentalcpdpro/mono/ms/id/internal/svcid.TestGetStr(0xc0001c4240)
/home/powerman/go/src/github.com/dentalcpdpro/mono/ms/id/internal/svcid/methods_test.go:27 +0x33a fp=0xc000135f80 sp=0xc000135e48 pc=0x8ab57a
testing.tRunner(0xc0001c4240, 0x9e0348)
/usr/lib/go/src/testing/testing.go:991 +0xdc fp=0xc000135fd0 sp=0xc000135f80 pc=0x503b9c
runtime.goexit()
/usr/lib/go/src/runtime/asm_amd64.s:1373 +0x1 fp=0xc000135fd8 sp=0xc000135fd0 pc=0x468631
created by testing.(*T).Run
/usr/lib/go/src/testing/testing.go:1042 +0x357
</pre></details>
<details><summary>Complete panic two</summary><br><pre>
=== RUN TestGetStr
fatal error: bulkBarrierPreWrite: unaligned arguments
goroutine 54 [running]:
runtime.throw(0x9ce74f, 0x28)
/usr/lib/go/src/runtime/panic.go:1116 +0x72 fp=0xc000134e28 sp=0xc000134df8 pc=0x436762
runtime.bulkBarrierPreWrite(0xc00009fec0, 0xffffffffffff80a7, 0x28)
/usr/lib/go/src/runtime/mbitmap.go:610 +0x493 fp=0xc000134eb0 sp=0xc000134e28 pc=0x416e53
runtime.typedmemmove(0x95a5a0, 0xc00009fec0, 0xffffffffffff80a7)
/usr/lib/go/src/runtime/mbarrier.go:161 +0xa1 fp=0xc000134ee8 sp=0xc000134eb0 pc=0x415a71
reflect.typedmemmove(0x95a5a0, 0xc00009fec0, 0xffffffffffff80a7)
/usr/lib/go/src/runtime/mbarrier.go:186 +0x3f fp=0xc000134f10 sp=0xc000134ee8 pc=0x415acf
reflect.packEface(0x95a5a0, 0xffffffffffff80a7, 0x199, 0xc0, 0x2a)
/usr/lib/go/src/reflect/value.go:119 +0x9f fp=0xc000134f50 sp=0xc000134f10 pc=0x492a2f
reflect.valueInterface(0x95a5a0, 0xffffffffffff80a7, 0x199, 0x1, 0x76, 0x10)
/usr/lib/go/src/reflect/value.go:1023 +0xe1 fp=0xc000134fa0 sp=0xc000134f50 pc=0x4965e1
reflect.Value.Interface(...)
/usr/lib/go/src/reflect/value.go:993
fmt.(*pp).printValue(0xc0000c6ea0, 0x95a5a0, 0xffffffffffff80a7, 0x199, 0xffffffff00000076, 0x1)
/usr/lib/go/src/fmt/print.go:726 +0x25ad fp=0xc000135178 sp=0xc000134fa0 pc=0x4dc7ad
fmt.(*pp).printValue(0xc0000c6ea0, 0x916580, 0xffffffffffff80a7, 0x16, 0x76, 0x0)
/usr/lib/go/src/fmt/print.go:880 +0x18be fp=0xc000135350 sp=0xc000135178 pc=0x4dbabe
fmt.(*pp).printArg(0xc0000c6ea0, 0x916580, 0xffffffffffff80a7, 0x10100c000000076)
/usr/lib/go/src/fmt/print.go:716 +0x292 fp=0xc0001353e8 sp=0xc000135350 pc=0x4d9ad2
fmt.(*pp).doPrintf(0xc0000c6ea0, 0x9c1808, 0x13, 0xc0001355b0, 0x2, 0x2)
/usr/lib/go/src/fmt/print.go:1030 +0x15a fp=0xc0001354d0 sp=0xc0001353e8 pc=0x4dd2ca
fmt.Fprintf(0xa79bc0, 0xc000010018, 0x9c1808, 0x13, 0xc0001355b0, 0x2, 0x2, 0x0, 0x8af5e0, 0x92b280)
/usr/lib/go/src/fmt/print.go:204 +0x72 fp=0xc000135538 sp=0xc0001354d0 pc=0x4d6212
fmt.Printf(...)
/usr/lib/go/src/fmt/print.go:213
github.com/powerman/rpc-codec/jsonrpc2.wrapError.Error(0xffffffffffff80a7, 0x950f01, 0x7ffa3e1aa380)
/home/powerman/proj/go/rpc-codec/jsonrpc2/errors.go:111 +0xbf fp=0xc000135600 sp=0xc000135538 pc=0x7cc13f
github.com/powerman/rpc-codec/jsonrpc2.(*wrapError).Error(0xc00009fe00, 0x926800, 0xc00009fe00)
<autogenerated>:1 +0x3c fp=0xc000135628 sp=0xc000135600 pc=0x7d05fc
github.com/davecgh/go-spew/spew.handleMethods(0xe0ea80, 0xa791a0, 0xc00009fe60, 0x950f20, 0xc00009fe00, 0x19, 0x0)
/home/powerman/go/pkg/mod/github.com/davecgh/[email protected]/spew/common.go:125 +0x316 fp=0xc000135750 sp=0xc000135628 pc=0x88c726
github.com/davecgh/go-spew/spew.(*dumpState).dump(0xc000135960, 0x950f20, 0xc00009fe00, 0x19)
/home/powerman/go/pkg/mod/github.com/davecgh/[email protected]/spew/dump.go:306 +0x1399 fp=0xc0001358f8 sp=0xc000135750 pc=0x8918d9
github.com/davecgh/go-spew/spew.fdump(0xe0ea80, 0xa791a0, 0xc00009fe60, 0xc000135b48, 0x1, 0x1)
/home/powerman/go/pkg/mod/github.com/davecgh/[email protected]/spew/dump.go:465 +0x159 fp=0xc0001359a0 sp=0xc0001358f8 pc=0x891f59
github.com/davecgh/go-spew/spew.(*ConfigState).Sdump(0xe0ea80, 0xc000135b48, 0x1, 0x1, 0xc000135aa8, 0x89af59)
/home/powerman/go/pkg/mod/github.com/davecgh/[email protected]/spew/config.go:281 +0x78 fp=0xc0001359e8 sp=0xc0001359a0 pc=0x88ee78
github.com/powerman/check.newDump(0x950f20, 0xc00009fe00, 0x1, 0xc0000a8f20, 0x0, 0xdbb810)
/home/powerman/go/pkg/mod/github.com/powerman/[email protected]/dump.go:70 +0x8c fp=0xc000135c08 sp=0xc0001359e8 pc=0x8a610c
github.com/powerman/check.(*C).report(0xc0000a2530, 0xdbb800, 0x0, 0x0, 0x0, 0xdbb82f, 0x3, 0xc000135dd8, 0x1, 0x1, ...)
/home/powerman/go/pkg/mod/github.com/powerman/[email protected]/check.go:136 +0x12a fp=0xc000135d58 sp=0xc000135c08 pc=0x89b03a
github.com/powerman/check.(*C).report1(0xc0000a2530, 0x950f20, 0xc00009fe00, 0x0, 0x0, 0x0, 0xc0000b8300, 0x2f)
/home/powerman/go/pkg/mod/github.com/powerman/[email protected]/check.go:204 +0x12c fp=0xc000135df8 sp=0xc000135d58 pc=0x89c09c
github.com/powerman/check.(*C).Nil(0xc0000a2530, 0x950f20, 0xc00009fe00, 0x0, 0x0, 0x0, 0xc00009fe00)
/home/powerman/go/pkg/mod/github.com/powerman/[email protected]/check.go:346 +0x97 fp=0xc000135e48 sp=0xc000135df8 pc=0x89cc87
github.com/dentalcpdpro/mono/ms/id/internal/svcid.TestGetStr(0xc0000e4360)
/home/powerman/go/src/github.com/dentalcpdpro/mono/ms/id/internal/svcid/methods_test.go:27 +0x35b fp=0xc000135f80 sp=0xc000135e48 pc=0x8ab67b
testing.tRunner(0xc0000e4360, 0x9e1380)
/usr/lib/go/src/testing/testing.go:991 +0xdc fp=0xc000135fd0 sp=0xc000135f80 pc=0x503b9c
runtime.goexit()
/usr/lib/go/src/runtime/asm_amd64.s:1373 +0x1 fp=0xc000135fd8 sp=0xc000135fd0 pc=0x468631
created by testing.(*T).Run
/usr/lib/go/src/testing/testing.go:1042 +0x357
</pre></details>
### What did you expect to see?
No panic. :)
### What did you see instead?
Panic. :(
### THE WORKAROUND
I was able to work around this issue by changing wrapped error to become a reference: https://github.com/powerman/rpc-codec/commit/c2902e88d7b3fa7ddd0c3b93ea95210b246a1aab
But I don't think something was wrong with my code before that commit, so probably it's a Go bug.
|
NeedsInvestigation,compiler/runtime
|
low
|
Critical
|
605,075,814 |
pytorch
|
Legacy fuser doesn't do remainder consistently with `aten::remainder`
|
## 🐛 Bug
aten::remainder follows numpy.remainder implementation (https://docs.scipy.org/doc/numpy/reference/generated/numpy.remainder.html) Which is not from IEEE remainder -> remainderf (https://en.cppreference.com/w/cpp/numeric/math/remainder)
In legacy fuser, we are using remainderf: https://github.com/pytorch/pytorch/blob/5fc391a6465d1f7197008085bb521b6dfaccc8b3/torch/csrc/jit/codegen/fuser/codegen.cpp#L243
This yields different results between jitted module and torch module.
## To Reproduce
Steps to reproduce the behavior:
```
import torch
def t(x : torch.Tensor, y : torch.Tensor):
o = torch.remainder(x, y)
o = torch.relu(o)
return o
t_jit = torch.jit.script(t)
x = torch.cuda.FloatTensor([-0.8])
y = torch.cuda.FloatTensor([-1.5])
jit_o = t_jit(x, y)
torch.cuda.profiler.start()
jit_o = t_jit(x, y)
torch.cuda.profiler.stop()
o = t(x, y)
print(o, jit_o)
assert(o.allclose(jit_o))
```
cc @suo
|
oncall: jit,triaged
|
low
|
Critical
|
605,081,065 |
pytorch
|
[JIT] Use of global value creates confusing error message
|
```
import torch
XYZ = 3
@torch.jit.script
def foo(x):
return x + XYZ
====
python value of type 'int' cannot be used as a value:
File "global.py", line 7
@torch.jit.script
def foo(x):
return x + XYZ
~~~ <--- HERE
```
"cannot be used as a value" here doesn't really impart any information that would be useful to the user. We should at least improve the error message or make it so that these situations are better supported in our model of the world
cc @suo
|
oncall: jit,triaged,small
|
low
|
Critical
|
605,108,692 |
rust
|
Implement TryInto<CString> for str and String
|
Higher-level FFI wrappers that need to present a `CString` to C don't have a convenient + efficient type to take on the Rust side.
```rust
ffi_string(arg: ???) {
let c_string = CString::new(arg)?;
ffify(c_string.as_ptr());
}
```
* Taking `CString` is cumbersome, as it doesn't work with simple `&str` and requires callers to do the conversion and handle NUL errors.
* Taking `String` or `Vec<u8>` is efficient only if it happens to have spare capacity, but `"foo".to_string()` doesn't have any spare capacity.
* Taking `&str` always needs to allocate.
Taking `impl TryInto<CString>` would be ideal, if that trait was implemented for common string-like types.
|
A-FFI,T-libs-api,C-feature-request
|
low
|
Critical
|
605,126,781 |
pytorch
|
pip install torch==1.4.0 is broken when using CUDA 10.1
|
## 🐛 Bug
The default CUDA version for the PyTorch 1.4.0 wheels is CUDA 10.1, but `pip install` defaults to CUDA 9.2 and does not let you install the 10.1 wheel.
Across Python 2.7, 3.6, 3.7, 3.8:
`pip install -f https://download.pytorch.org/whl/torch_stable.html torch==1.4.0`
will install the `cu92` wheel instead of the `cu101` wheel.
The following command complains that it can't find the requested version
`pip install -f https://download.pytorch.org/whl/torch_stable.html torch==1.4.0+cu101`
This makes sense as the 10.1 wheels for torch 1.4.0 don't have a suffix. Maybe this is related to the 1.5.0 release from yesterday?
## To Reproduce
Steps to reproduce the behavior:
1. `docker run -it --rm python:2.7 /bin/bash` (replacing `2.7` with each python version above)
2. `pip install -f https://download.pytorch.org/whl/torch_stable.html torch==1.4.0`
```
root@40e0b8aa1d83:/# pip install -f https://download.pytorch.org/whl/torch_stable.html torch==1.4.0
Looking in links: https://download.pytorch.org/whl/torch_stable.html
Collecting torch==1.4.0
Downloading https://download.pytorch.org/whl/cu92/torch-1.4.0%2Bcu92-cp38-cp38-linux_x86_64.whl (640.6 MB)
|▌ | 10.3 MB 9.9 MB/s eta 0:01:04^C
ERROR: Operation cancelled by user
root@40e0b8aa1d83:/#
```
3. `pip install -f https://download.pytorch.org/whl/torch_stable.html torch==1.4.0+cu101`
```
root@40e0b8aa1d83:/# pip install -f https://download.pytorch.org/whl/torch_stable.html torch==1.4.0+cu101
Looking in links: https://download.pytorch.org/whl/torch_stable.html
ERROR: Could not find a version that satisfies the requirement torch==1.4.0+cu101 (from versions: 0.1.2, 0.1.2.post1, 0.1.2.post2, 1.4.0, 1.4.0+cpu, 1.4.0+cu100, 1.4.0+cu92, 1.5.0, 1.5.0+cpu, 1.5.0+cu101, 1.5.0+cu92)
ERROR: No matching distribution found for torch==1.4.0+cu101
root@40e0b8aa1d83:/#
```
## Expected behavior
`pip install -f https://download.pytorch.org/whl/torch_stable.html torch==1.4.0`
should install Torch 1.4.0 with CUDA 10.1 support
cc @malfet
|
module: build,triaged
|
low
|
Critical
|
605,155,295 |
go
|
os, x/build: only write permissions 0222 for file result in successful read for linux-amd64
|
Coming here from https://go-review.googlesource.com/c/go/+/229357/3#message-c7922ea647b703faa8e858428f47221a6d921275 and https://storage.googleapis.com/go-build-log/b49db1e9/linux-amd64_454ff41f.log in which we have an odd test failure
```shell
# go run run.go -- fixedbugs/issue36437.go
incorrect output
Expected a non-nil error, but got:
""
want
"open /workdir/tmp/33921360662258/main.go: permission denied\n"
FAIL fixedbugs/issue36437.go 0.291s
2020/04/22 23:32:59 Failed: exit status 1
go tool dist: FAILED
```
in which the relevant test is
```go
package main
import (
"fmt"
"io/ioutil"
"os"
"os/exec"
"path/filepath"
)
func main() {
tmpDir, err := ioutil.TempDir("", "issue36437")
if err != nil {
panic(err)
}
defer os.RemoveAll(tmpDir)
msgOrErr := func(bmsg []byte, err error) string {
msg := string(bmsg)
if msg == "" && err != nil {
msg = err.Error()
}
return msg
}
// 2. Invoke the compiler with a file that we don't have read permissions to.
path := filepath.Join(tmpDir, "main.go")
if err := ioutil.WriteFile(path, []byte("package p"), 0222); err != nil {
panic(err)
}
output, err = exec.Command("go", "tool", "compile", path).CombinedOutput()
want := fmt.Sprintf("open %s: permission denied\n", path)
if g, w := msgOrErr(output, err), want; g != w {
panic(fmt.Sprintf("Expected a non-nil error, but got:\n\t%q\nwant\n\t%q", g, w))
}
}
```
Is this perhaps just a problem with the builder? I'd expect that 0222 would make a file writable but would error on reading; other GOOS-GOARCH combinations work properly but not this one.
|
NeedsInvestigation
|
low
|
Critical
|
605,173,801 |
terminal
|
Background image should (optionally?) render pixel-for-pixel rather than scaling with the system scale
|
# Description of the new feature/enhancement
This might be related to #2370, but it addresses a slightly different problem.
Currently, Windows Terminal scales the background image according to your system UI scale. So, for example, if your UI scale is set to 150% in Windows Settings, and you set a 100×100-pixel background image with `backgroundImageStretchMode: none`, the image will be rendered at 150×150. This might not be what you want, since the scaling will blur sharp edges, and the image will be much larger than you might have expected.
# Proposed technical implementation details (optional)
There should be some way to indicate that we want our background image to render pixel-for-pixel, rather than be enlarged according to the UI scale.
Or else maybe it should simply render pixel-for-pixel by default. This was my expectation; not sure if it matches the expectation of others.
|
Help Wanted,Issue-Bug,Area-TerminalControl,Product-Terminal,Priority-3
|
low
|
Minor
|
605,192,041 |
flutter
|
Consider hiding windows until the engine is active in the desktop runner templates
|
A common request from people trying Flutter on desktop is being able to control initial window size and position from Dart, which makes sense given that application logic for Flutter apps often lives entirely in Dart. Currently, however, the windows are made as part of creating the associated engine, so their initial size is set in the platform (ObjC, C++) code.
The `window_size` FDE plugin (which will eventually be replaced with framework functionality) allows repositioning it, but because of the ordering and the async nature of engine startup, doing that at startup is very ugly; the window is briefly visible with one frame, then jumps to another frame. (This also means that the common desktop functionality of remembering window frames currently has to be done in platform code, not Dart, which is not ideal either.)
A possible solution here would be to have the runner template create the window hidden, and add an early lifecycle event to a system channel which would trigger the window to show. We could include a frame in that message, so that the window would only ever be visible with a frame controlled by Dart code. We could even consider having that message sent only after the first paint is finished to avoid an initial white frame.
This has to be balanced against the fact that it'll make the window slower to show up, but I think that will still be substantially better in most cases. If it's slow enough for that to be an issue, a splash screen that's separate from the window would be a much cleaner user experience (although of course ideally, it should be fast enough that that's not necessary)
Status:
* [x] Windows https://github.com/flutter/flutter/pull/109816
* [ ] macOS
* [ ] Linux
|
engine,platform-mac,platform-windows,platform-linux,c: proposal,a: desktop,P3,team-macos,triaged-macos
|
low
|
Major
|
605,194,907 |
terminal
|
Dynamic Profile Generator for Windows PowerShell
|
# Description of the new feature/enhancement
It'd be nice if the "Windows PowerShell" profile worked like the other profiles, and could be disabled using `disabledProfileSources`.
This would remove the need to carry a 'hidden' overriding profile per #5459, as `disabledProfileSources` made possible for the other profile sources.
# Proposed technical implementation details (optional)
I _guess_ it just needs new `IDynamicProfileGenerator` implementation, that replaces (and slurps up?) the existing Windows PowerShell profile if present, which appears to have a fixed GUID (`{61c54bbd-c2c6-5271-96e7-009a87ff44bf}`), fix the 'pick a default profile' logic, and then remove it from the defaults.json.
If the same thing is done for CMD, then I guess the risk appears of how to handle the case that there are _no_ profiles available, where right now I guess you always have those two profiles, even if somehow they are not usable.
|
Help Wanted,Area-Settings,Product-Terminal,Issue-Task
|
low
|
Minor
|
605,200,542 |
material-ui
|
[TextField] Missing pseudo-classes generates error when overriding <Input>
|
- [x] The issue is present in the latest release.
- [x] I have searched the [issues](https://github.com/mui-org/material-ui/issues) of this repository and believe that this is not a duplicate.
## Current Behavior 😯
Trying to override the CSS class `adornedEnd` or `adornedStart` of `<Input />` generates an error "Material-UI: the key X provided to the classes prop is not implemented in ForwardRef(Input).". When I use a `<FilledInput />` or `<OutlinedInput />` no error is generated.
## Expected Behavior 🤔
The CSS classes of `<Input />` should be consistently with other input components.
## Steps to Reproduce 🕹
Open this [codesandbox](https://codesandbox.io/s/xenodochial-breeze-7oo8l?file=/src/Demo.js) and look at the console.
## Context 🔦
I created a select using `<TextField variant="filled" />`. This select had a clear button as adornment and I used the CSS class to remove the padding. When I changed to the standard variation I got the error.
## Your Environment 🌎
<!--
Include as many relevant details about the environment with which you experienced the bug.
If you encounter issues with typescript please include version and tsconfig.
-->
| Tech | Version |
| ----------- | ------- |
| Material-UI | v4.9.11 |
| React | |
| Browser | |
| TypeScript | |
| etc. | |
Possible fix: Add the missing pseudo-classes and update the TypeScript definitions to match the other input components.
I noticed that all input components wrap the `InputBase`. Should the TS definition use the `InputBaseClassKey` as base? [Input](https://github.com/mui-org/material-ui/blob/master/packages/material-ui/src/Input/Input.d.ts) is different from [OutlinedInput](https://github.com/mui-org/material-ui/blob/master/packages/material-ui/src/OutlinedInput/OutlinedInput.d.ts).
|
bug 🐛,component: text field,ready to take
|
low
|
Critical
|
605,212,071 |
flutter
|
Failed assertion: line 110 pos 12: '_positions.isNotEmpty'
|
I have 5 pieces of data in my Swiper, I have an Index record of the current position, and when I delete the last item, I move the Index forward and delete the last item. This is when the error is reported.
```console
flutter: The following assertion was thrown:
flutter: ScrollController not attached to any scroll views.
flutter: 'package:flutter/src/widgets/scroll_controller.dart':
flutter: Failed assertion: line 110 pos 12: '_positions.isNotEmpty'
flutter:
flutter: Either the assertion indicates an error in the framework itself, or we should provide substantially
flutter: more information in this error message to help you determine and fix the underlying cause.
```
|
framework,f: material design,f: scrolling,customer: wednesday,P2,team-design,triaged-design
|
low
|
Critical
|
605,234,810 |
PowerToys
|
Hide taskbar labels without combining icons
|
# Summary of the new feature/enhancement
Windows doesn't provide an option to hide open apps labels without combining them together. Such a thing would be useful when you want to quickly switch between open windows of the same app.
# Proposed technical implementation details (optional)
A place when I can choose those two options separately: 1. combined or not, 2. show/hide labels.
|
Idea-New PowerToy,Product-Tweak UI Design
|
low
|
Major
|
605,243,445 |
flutter
|
flutter test --coverage --platform=chrome exits unexpectedly
|
I was trying to get test coverage generated by running this command:
`flutter test --coverage --no-test-assets --platform chrome --verbose`
```
07:14 +281 ~2: All tests passed!
[+1636 ms] coverage information collection complete
[ +20 ms] "flutter test" took 4,76,458ms.
#0 throwToolExit (package:flutter_tools/src/base/common.dart:14:3)
#1 TestCommand.runCommand (package:flutter_tools/src/commands/test.dart:275:9)
<asynchronous suspension>
#2 FlutterCommand.verifyThenRunCommand (package:flutter_tools/src/runner/flutter_command.dart:722:18)
#3 _rootRunUnary (dart:async/zone.dart:1192:38)
#4 _CustomZone.runUnary (dart:async/zone.dart:1085:19)
#5 _FutureListener.handleValue (dart:async/future_impl.dart:141:18)
#6 Future._propagateToListeners.handleValueCallback (dart:async/future_impl.dart:682:45)
#7 Future._propagateToListeners (dart:async/future_impl.dart:711:32)
#8 Future._completeWithValue (dart:async/future_impl.dart:526:5)
#9 Future._asyncComplete.<anonymous closure> (dart:async/future_impl.dart:556:7)
#10 _rootRun (dart:async/zone.dart:1184:13)
#11 _CustomZone.run (dart:async/zone.dart:1077:19)
#12 _CustomZone.runGuarded (dart:async/zone.dart:979:7)
#13 _CustomZone.bindCallbackGuarded.<anonymous closure> (dart:async/zone.dart:1019:23)
#14 _microtaskLoop (dart:async/schedule_microtask.dart:43:21)
#15 _startMicrotaskLoop (dart:async/schedule_microtask.dart:52:5)
#16 _runPendingImmediateCallback (dart:isolate-patch/isolate_patch.dart:118:13)
#17 _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:169:5)
```
Ouput of `flutter doctor -v`
```
Downloading android-arm-profile/darwin-x64 tools... 1.1s
Downloading android-arm-release/darwin-x64 tools... 0.8s
Downloading android-arm64-profile/darwin-x64 tools... 1.1s
Downloading android-arm64-release/darwin-x64 tools... 1.0s
Downloading android-x64-profile/darwin-x64 tools... 0.7s
Downloading android-x64-release/darwin-x64 tools... 0.9s
[✓] Flutter (Channel beta, v1.17.0, on Mac OS X 10.14.6 18G1012, locale en-IN)
• Flutter version 1.17.0 at /Users/gogol/Documents/Flutter/flutter
• Framework revision d3ed9ec945 (2 weeks ago), 2020-04-06 14:07:34 -0700
• Engine revision c9506cb8e9
• Dart version 2.8.0 (build 2.8.0-dev.18.0 eea9717938)
[✗] Android toolchain - develop for Android devices
✗ Unable to locate Android SDK.
Install Android Studio from: https://developer.android.com/studio/index.html
On first launch it will assist you in installing the Android SDK components.
(or visit https://flutter.dev/docs/get-started/install/macos#android-setup for detailed instructions).
If the Android SDK has been installed to a custom location, set ANDROID_SDK_ROOT to that location.
You may also want to add it to your PATH environment variable.
[!] Xcode - develop for iOS and macOS (Xcode 10.3)
• Xcode at /Applications/Xcode.app/Contents/Developer
• Xcode 10.3, Build version 10G8
✗ Flutter requires a minimum Xcode version of 11.0.0.
Download the latest version or update via the Mac App Store.
• CocoaPods version 1.8.4
[✓] Chrome - develop for the web
• Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome
[!] Android Studio (not installed)
• Android Studio not found; download from https://developer.android.com/studio/index.html
(or visit https://flutter.dev/docs/get-started/install/macos#android-setup for detailed instructions).
[✓] VS Code (version 1.44.2)
• VS Code at /Applications/Visual Studio Code.app/Contents
• Flutter extension version 3.9.1
[✓] Connected device (2 available)
• Chrome • chrome • web-javascript • Google Chrome 81.0.4044.113
• Web Server • web-server • web-javascript • Flutter Tools
```
|
tool,platform-web,P3,team-web,triaged-web
|
low
|
Major
|
605,325,744 |
pytorch
|
[Design][RFC] RemoteModule API Design
|
# [Design][RFC] RemoteModule API Design
FB internal link, [[Design] RemoteModule](https://fb.quip.com/Rb5bAKee8TQ4)
## Goal
* Provide a wrapper `nn.Module` API that serves these purposes
* Users should feel like using remote module is like using a local module. RPCs are done transparently for users.
* Users can look up if a the parameters and modules that sit on the remote side rather than doing it in an ad-hoc way. (Internal diff that does it in an ad-hoc way, D19954520)
* RemoteModule should be a RRef + helper functions container. It should be able to be copied and sent over RPC. Here is an example use case. Master creates a list of EmbeddingBag Modules on a set of Embedding Servers and refers to them using RemoteModules on Master. Master would want to share this list of RemoteModules to all the Trainers.
* This API as a modeling primitive should be TorchScript compatible.
* The reason is that RPC-supported distributed training (Model-parallel) largely leverages TorchScript to remove Python dependency to avoid Python GIL contention overhead.
* This API need to be able to integrated with autograd profiler
* In distributed model parallel training, how to place remote modules and parameters is better a result of profiling results. Since uses of this API are marks of local/remote pairs in distributed model parallel training, it is naturally the good hooks for profiler.
* A RemoteModule should hold a global unique name for identifying an instance among all remote modules.
## RemoteModule API Example
```
class MyModule(nn.Module):
pass
# Local side is aware of this, Remote side runs this.
def module_creator(args, kwargs) -> ModuleInterfaceXYZ: (An important type var)
my_module = MyModule(*args, **kwargs)
scripted_my_moduel = torch.jit.script(my_module)
return scripted_my_moduel
to = "worker1"
my_module_remote: RemoteModuleInterfaceXYZ = RemoteModule(
to, module_creator, args=(), kwargs={}
)
parameter_rrefs: List[RRef[Tensor]] = my_module_remote.remote_prameters()
ret_fut = my_module_remote.forward_async()
ret = ret_fut.wait()
ret= my_module_remote.forward()
```
## nn.Module New API
* Add API to nn.Module
* nn.Module.**remote_modules**()
* It’s aware of how to get RemoteModules.
* nn.Module.**remote_parameters**()
* It gets all Parameter RRefs from all sub-RemoteModules.
* Note, for the first phase of this project, we don’t want to expose it in PyTorch code API nn.Module. Instead we provide helper functions that serve the same purpose as experimental API under RPC module.
## Challenges imposed on scripting
* RemoteModule initialization should allowed be done in Python. But when it’s done in TorchScript or the Python RemoteModule object got scripted, need to do the following type inference and generation.
* A requirement: Type of the contained ScriptModule must be known on both sides. Expect it’s provided on the “module_creater” return type by user. Check it’s provided by the user. See “module_creator” return type “ModuleInterfaceXYZ” in the above example.
* Generate a “forward” method and necessary schema/types on both local side and remote side, see “LocalForwardTemplate” and “RemoteForwardTemplate” below. Notice JIT Compilation Unit lifetime management and thread safety, because when local side initiates type registration on remote side, remote side might be compiling other global scope ScriptFunctions initiated from importing.
* LocalForwardTemplate doesn’t do computation, but it initiates an RPC. It needs to know how to refer to the RemoteForwardTemplate instance.
* RemoteForwardTemplate is a dynamically-generated RRef method call helper. It’s signature depends on the “forward” method schema of the custom ScriptModule, “ModuleInterfaceXYZ”, which is constructed in the initialization phase above.
## Template
Need to have 2 TorchScript templates
* LocalForwardTemplate
```
def local_forward_async(self: RemoteModuleInterfaceXYZ, ...args_0) -> Future[...args_1]:
return rpc.rpc_async(
to,
remote_forward,
args,
kwargs,
)
def local_foward(self: RemoteModuleInterfaceXYZ, ...args_0) -> ...args_1:
fut = local_forward_async(...)
return fut.wait()
```
* RemoteForwardTemplate
```
def remote_forward(self_rref: RRef[ModuleInterfaceXYZ], ...args_0) -> ...args_1:
self: ModuleInterfaceXYZ = self_rref.local_value()
return self.forward(...args_0)
```
## Working Items
* ~~Get ModuleInterface type from module_creator. Done~~
* ~~Get type strs from ModuleInterface. Done~~
* ~~Instantiate Python code template with type strs inserted. Done~~
* ~~Instantiate template as generated output files. Done~~
* ~~Test scripting the Remote Module. Done~~
* ~~Test 3 ways of constructing RemoteModule. Done~~
* ~~Test forward_async. Done~~
* ~~Test forward_sync. Done~~
* ~~Test foward with kwargs. Done~~
* ~~Setup OSS tests. Done~~
* ~~Resolve ModuleImportError when import CodeTemplate class. Done~~
* ~~Resolve FileNotFoundError seeing after python setup.py install. Done~~
* ~~Cleaning up generated module files to avoid torch package size exploding. Done~~
* ~~Added docstrings and examples to explain how to use the API. Done~~
cc @suo @pietern @mrshenli @pritamdamania87 @zhaojuanmao @satgera @gqchen @aazzolini @rohan-varma @xush6528 @jjlilley @osalpekar
|
oncall: jit,triaged,module: rpc
|
low
|
Critical
|
605,413,017 |
node
|
zlib change broke x86 builds
|
I know we don't officially support x86 anymore but we do publish unofficial-builds x86 and the Snap package has x86 support too. But I've just noticed they haven't been building, I suppose since zlib was switched out:
```
cc -o /build/node/parts/node/build/out/Release/obj.target/zlib/deps/zlib/contrib/optimizations/inflate.o ../deps/zlib/contrib/optimizations/inflate.c '-DV8_DEPRECATION_WARNINGS' '-DV8_IMMINENT_DEPRECATION_WARNINGS' '-D__STDC_FORMAT_MACROS' '-DOPENSSL_NO_PINSHARED' '-DOPENSSL_THREADS' '-DHAVE_HIDDEN' '-DADLER32_SIMD_SSSE3' '-DINFLATE_CHUNK_SIMD_SSE2' '-DCRC32_SIMD_SSE42_PCLMUL' -I../deps/zlib -pthread -Wall -Wextra -Wno-unused-parameter -m32 -O3 -fno-omit-frame-pointer -MMD -MF /build/node/parts/node/build/out/Release/.deps//build/node/parts/node/build/out/Release/obj.target/zlib/deps/zlib/contrib/optimizations/inflate.o.d.raw -c
In file included from ../deps/zlib/contrib/optimizations/inffast_chunk.c:10:0:
../deps/zlib/contrib/optimizations/chunkcopy.h: In function ‘loadchunk’:
../deps/zlib/contrib/optimizations/chunkcopy.h:52:5: warning: SSE vector return without SSE enabled changes the ABI [-Wpsabi]
const unsigned char FAR* s) {
^
In file included from ../deps/zlib/contrib/optimizations/inflate.c:87:0:
../deps/zlib/contrib/optimizations/chunkcopy.h: In function ‘loadchunk’:
../deps/zlib/contrib/optimizations/chunkcopy.h:52:5: warning: SSE vector return without SSE enabled changes the ABI [-Wpsabi]
const unsigned char FAR* s) {
^
In file included from ../deps/zlib/contrib/optimizations/chunkcopy.h:32:0,
from ../deps/zlib/contrib/optimizations/inffast_chunk.c:10:
../deps/zlib/contrib/optimizations/chunkcopy.h: In function ‘v_load64_dup’:
/usr/lib/gcc/i686-linux-gnu/5/include/emmintrin.h:625:1: error: inlining failed in call to always_inline ‘_mm_set1_epi64x’: target specific option mismatch
_mm_set1_epi64x (long long __A)
^
In file included from ../deps/zlib/contrib/optimizations/inffast_chunk.c:10:0:
../deps/zlib/contrib/optimizations/chunkcopy.h:215:10: error: called from here
return _mm_set1_epi64x(i64);
^
make[1]: *** [/build/node/parts/node/build/out/Release/obj.target/zlib/deps/zlib/contrib/optimizations/inffast_chunk.o] Error 1
make[1]: *** Waiting for unfinished jobs....
deps/zlib/zlib.target.mk:109: recipe for target '/build/node/parts/node/build/out/Release/obj.target/zlib/deps/zlib/contrib/optimizations/inffast_chunk.o' failed
In file included from ../deps/zlib/contrib/optimizations/chunkcopy.h:32:0,
from ../deps/zlib/contrib/optimizations/inflate.c:87:
../deps/zlib/contrib/optimizations/chunkcopy.h: In function ‘v_load64_dup’:
/usr/lib/gcc/i686-linux-gnu/5/include/emmintrin.h:625:1: error: inlining failed in call to always_inline ‘_mm_set1_epi64x’: target specific option mismatch
_mm_set1_epi64x (long long __A)
^
In file included from ../deps/zlib/contrib/optimizations/inflate.c:87:0:
../deps/zlib/contrib/optimizations/chunkcopy.h:215:10: error: called from here
return _mm_set1_epi64x(i64);
^
make[1]: *** [/build/node/parts/node/build/out/Release/obj.target/zlib/deps/zlib/contrib/optimizations/inflate.o] Error 1
deps/zlib/zlib.target.mk:109: recipe for target '/build/node/parts/node/build/out/Release/obj.target/zlib/deps/zlib/contrib/optimizations/inflate.o' failed
rm 73eb81ec782978e9e5a9028cb1d0640d4778b4fe.intermediate
make: *** [node] Error 2
Makefile:101: recipe for target 'node' failed
```
I suspect there might be a not-too-difficult fix to restore support here, maybe bypassing an optimisation that was added? We still have x86 users so I'm sure a fix will be appreciated if we can come up with one.
|
zlib,build
|
low
|
Critical
|
605,435,418 |
youtube-dl
|
Please add support for https://www.rtp.pt/play/p7170/e468013/estudarcomautonomia
|
## Checklist
- [X] I'm reporting a new site support request
- [X] I've verified that I'm running youtube-dl version **2020.03.24**
- [X] I've checked that all provided URLs are alive and playable in a browser
- [ ] I've checked that none of provided URLs violate any copyrights
- [ ] I've searched the bugtracker for similar site support requests including closed ones
## Example URLs
- Playlist: https://www.rtp.pt/play/p7170/e468013/estudarcomautonomia
## Description
lessons to K12 from national portuguese chanel
|
site-support-request
|
low
|
Critical
|
605,442,468 |
terminal
|
Can't drag the window using the pixels on top of the screen over a tab
|
# Environment
Windows build number: Microsoft Windows [version 10.0.18363.778]
Windows Terminal version (if applicable): 0.10.781.0
# Steps to reproduce
1. Maximize the terminal window
2. Open a lot of tabs to fill the title bar
3. Try to drag the window using the title bar, placing the mouse above one of the tabs (top of the screen)
# Expected behavior
The window should un-maximize and begin to move with the mouse, just like every other window.
# Actual behavior
The window doesn't move at all.
|
Area-UserInterface,Product-Terminal,Issue-Task
|
low
|
Major
|
605,452,016 |
godot
|
`minimum_size_changed()` stops working after getting in a locked state
|
**Godot version:** v3.2.1.stable.official (should be the same for master)
**OS/device including version:** Arch Linux 5.6.6-arch1-1 x86_64
**Issue description:** `minimum_size_changed()` stops working after getting in a locked state
**Steps to reproduce:**
Open minimal reproduction project and run.
Push first button with code:
```gdscript
# in scene:
container.call_deferred("remove_child", label)
label.minimum_size_changed()
```
[control.cpp#L2565-L2589](https://github.com/godotengine/godot/blob/3.2/scene/gui/control.cpp#L2565-L2589) :
```cpp
// in core
data.updating_last_minimum_size = true;
MessageQueue::get_singleton()->push_call(this, "_update_minimum_size");
```
Then push second button
```gdscript
# in scene
container.add_child(label)
```
Push the third button
```gdscript
# in scene
label.text = "large banana"
```
```cpp
// in core
// same lines as above, my guess:
if (data.updating_last_minimum_size)
return;
```
The size of the label doesn't adapt to its content. It is expected that it does adapt.
To resolve, push the fourth button:
```gdscript
# in scene
label._update_minimum_size()
```
[control.cpp#L296](https://github.com/godotengine/godot/blob/3.2/scene/gui/control.cpp#L296) :
```cpp
// in core
data.updating_last_minimum_size = false;
```
Then push the fifth button:
```gdscript
# in scene
label.text = "large apple"
```
Now the label size changed again as expected.
**Minimal reproduction project:**
[issue_minimum_size.zip](https://github.com/godotengine/godot/files/4521973/issue_minimum_size.zip)
**workaround**
Hooking the `_update_minimum_size()` function to the `node_added` signal seems to workaround the issue:
```gdscript
func _ready():
get_tree().connect("node_added", self, "workaround")
func workaround(node):
if node is Control:
node.call_deferred('_update_minimum_size')
```
|
bug,topic:gui
|
low
|
Minor
|
605,455,798 |
go
|
x/mobile: adding an assets/icon.png erases the app label
|
`go version go1.13.5 linux/amd64`
I added an icon asset to the network example from the gomobile examples directory. It did get an icon (yay!), but the program name became `org.golang.app.GoNativeActivity` instead of network.
|
NeedsInvestigation,mobile
|
low
|
Minor
|
605,466,609 |
rust
|
`for<'a> Send` is distinct from `Send`?
|
This code fails to compile with a pretty strange error:
```rust
use std::future::Future;
use std::pin::Pin;
use std::io::Read;
trait Service<R> {
type Response;
type Error;
type Future: Future<Output = Result<Self::Response, Self::Error>>;
fn call(&mut self, req: R) -> Self::Future;
}
struct BorrowerService<S> {
service: Option<S>,
}
impl<S> Service<Box<dyn Read + Sync + Send>> for BorrowerService<S>
where
for<'b> S: Service<&'b (dyn Read + 'static + Sync + Send), Response = i32, Error = ()> + 'static + Send,
for<'b> <S as Service<&'b (dyn Read + 'static + Sync + Send)>>::Future: Send,
{
type Response = i32;
type Error = ();
type Future = Pin<Box<dyn Future<Output = Result<i32, ()>> + Send>>;
fn call(&mut self, req: Box<dyn Read + Sync + Send>) -> Self::Future {
let mut service = self.service.take().unwrap();
Box::pin(async move {
service.call(&req).await
})
}
}
```
```
error[E0308]: mismatched types
--> src/lib.rs:28:9
|
28 | / Box::pin(async move {
29 | | service.call(&req).await
30 | | })
| |__________^ one type is more general than the other
|
= note: expected type `std::marker::Send`
found type `for<'b> std::marker::Send`
```
The use of the trait object appears to be important - if I replace that with e.g. `String`, it compiles just fine:
```rust
use std::future::Future;
use std::pin::Pin;
trait Service<R> {
type Response;
type Error;
type Future: Future<Output = Result<Self::Response, Self::Error>>;
fn call(&mut self, req: R) -> Self::Future;
}
struct BorrowerService<S> {
service: Option<S>,
}
impl<S> Service<Box<String>> for BorrowerService<S>
where
for<'b> S: Service<&'b String, Response = i32, Error = ()> + 'static + Send,
for<'b> <S as Service<&'b String>>::Future: Send,
{
type Response = i32;
type Error = ();
type Future = Pin<Box<dyn Future<Output = Result<i32, ()>> + Send>>;
fn call(&mut self, req: Box<String>) -> Self::Future {
let mut service = self.service.take().unwrap();
Box::pin(async move {
service.call(&req).await
})
}
}
```
|
A-lifetimes,A-trait-system,T-compiler,C-bug
|
low
|
Critical
|
605,472,511 |
rust
|
Address CTFE perf regression introduced by #71005
|
In an effort to treat the return place `_0` more closely to regular locals, #71005 has removed some optimizations that avoid allocating memory for locals when there's only a return place. This regresses the [CTFE stress test](https://github.com/rust-lang/rustc-perf/blob/master/collector/benchmarks/ctfe-stress-4/src/lib.rs) by around 8%.
It would be good to gain the lost performance back. https://github.com/rust-lang/rust/pull/71005#discussion_r412263905 contains some ideas for how to do that.
|
C-enhancement,I-compiletime,T-compiler,A-const-eval,C-optimization
|
low
|
Major
|
605,475,949 |
pytorch
|
Propagation of channels-last layout leads to massive slowdowns in 1.5 compared to 1.4
|
## 🐛 Bug
Backpropagation through `tensor.permute()` is a lot slower in pytorch 1.5 compared to pytorch 1.4.
I'm not exactly sure what is causing this, but it seems like a bug.(?)
## To Reproduce
Run following file with pytorch 1.4 and pytorch 1.5. (You might have to adjust the number of iterations or size of the input tensor if it takes too much or too little time)
```
import torch
import torch.nn as nn
class Perm(nn.Module):
def __init__(self):
super().__init__()
self.s = nn.Parameter(torch.tensor([1.0]))
def forward(self, x):
y = x.mean(dim=(2, 3), keepdim=True) # = torch.nn.functional.adaptive_avg_pool2d(x, output_size=(1, 1))
y = y.permute(0, 2, 3, 1) # channels to last dim
y = y*self.s # without this, there is next to no difference
y = y.permute(0, 3, 1, 2) # channels back to second dim
y = x * y
return y
device = torch.device('cuda:0') # can be changed to 'cpu'
net = Perm().to(device)
opt = torch.optim.Adam(params=net.parameters(), lr=0.001)
def train(device=device, iters=10):
x = torch.zeros((10, 64, 256, 256)).to(device)
for k in range(iters):
y = net(x).sum()
opt.zero_grad()
y.backward()
opt.step()
if __name__ == '__main__':
import timeit
print(timeit.timeit("train()", setup="from __main__ import train", number=10))
```
## Expected behavior
I expected both versions to have a similar run time, but in v1.5 we have a ~4x slowdown.
* Runtime on cpu: v1.4: 5.07s / v1.5: 21.5s
* Runtime on gpu: v1.4: 0.665s/ v1.5: 3.31s
## Environment
- PyTorch Version (e.g., 1.0): 1.4 and 1.5
- OS (e.g., Linux): Ubuntu 18.04
- How you installed PyTorch (`conda`, `pip`, source): conda
- Build command you used (if compiling from source): -
- Python version: 3.7
- CUDA/cuDNN version: 10.1
- GPU models and configuration: nvidia P6000
- Any other relevant information: -
## Additional context
<!-- Add any other context about the problem here. -->
cc @ezyang @gchanan @zou3519 @SsnL @albanD @gqchen @VitalyFedyunin @jamesr66a @ngimel
|
module: performance,module: internals,triaged,module: memory format
|
low
|
Critical
|
605,508,099 |
godot
|
Optional GDNative libraries not available on some platforms always trigger errors in the editor
|
Godot 3.2.1
The title can be misleading, but here is the situation:
It is possible to not specify some platforms in a GDNative library if those platforms aren't supported natively.
I have a plugin containing such optional GDNative library to speed things up under specific platforms that I support. To keep the plugin working on other platforms, I fallback on a GDScript implementation, which I handle in code by deciding wether or not to load such library, and alternating between implementations of the same class (without type hints): https://github.com/Zylann/godot_heightmap_plugin/blob/master/addons/zylann.hterrain/native/factory.gd
This works well so far.
But the problem is, the editor still tries to *load* the `gdnlib` or `gdns` resources even on platforms where the library is not supported, which systematically causes confusing errors in the console even when the plugin actually works fine: https://github.com/Zylann/godot_heightmap_plugin/issues/156
Worse, unsupported editor versions would try to load the present library and also fail doing so due to potential ABI differences.
Here is what I suspect:
- Generating thumbnails? I see no point in loading the library for that
- Checking for global class names? I also see no point in that, such information could be available in text form inside the gdns file, without needing to load the library
- Preloading? I don't use any of that *on purpose*.
- Other?
At least Godot should only attempt to load the library when it actually can.
|
bug,topic:editor,topic:gdextension
|
low
|
Critical
|
605,568,215 |
godot
|
Doppler Effect Cuts off at Certain Speed
|
**Godot version:**
v3.2.2.beta.custom_build.c7ad8f539
**OS/device including version:**
Linux
**Issue description:**
When using the Doppler effect on an AudioStreamPlayer3D the audio gets cut off, when the object its used on reaches a certain speed.
This video shows a cube accelerating towards the camera, while playing a rocket engine sound. At the ~3rd second the Doppler effect stops abruptly.
[doppler_audio_bug.zip](https://github.com/godotengine/godot/files/4522883/doppler_audio_bug.zip)
**Steps to reproduce:**
1. Add AudioStreamPlayer3D to RigidBody
2. Continue to call add_central_force() on the object while playing a sound with doppler_tracking activated (Idle or Physics).
**Minimal reproduction project:**
[doppler_audio_bug.zip](https://github.com/godotengine/godot/files/4522917/doppler_audio_bug.zip)
|
bug,topic:audio,topic:3d
|
low
|
Critical
|
605,595,010 |
pytorch
|
Cuda profiler + DataParallel + manual profiling start = strange profiling overhead pattern
|
I learn a transformer language model (reusing fairseq components with my own training loop). I use DataParallel for multi-gpu. I tried two variants for kicking off the CUDA profiler:
1. `nvprof -s -f -o profile.sqlite --log-file profile.txt -- python3 ...`
2. `nvprof --profile-from-start off -s -f -o profile.sqlite --log-file profile.txt -- python3 ...` and manual `torch.cuda.profiler.start()` call before DataParallel object creation.
One can see that variant 2 has a huge Profiling Overhead pattern line and GPUs 1 and 2 are unused. Everything is okay in variant 1.
I wonder it's an indication of some bug.
nvprof switch `--profile-child-processes` had no effect in this DP setup so I didn't use it for the final repro.
The setup is torch 1.4.0 release running on Ubuntu 18.04, CUDA 10.1.
cc @pietern @mrshenli @pritamdamania87 @zhaojuanmao @satgera @rohan-varma @gqchen @aazzolini @xush6528 @osalpekar
|
oncall: distributed,triaged
|
low
|
Critical
|
605,602,940 |
go
|
x/build: need to be able to rerun TryBots on other people's CLs (and my own)
|
And, also, the UI is misleading, see below.
### What did you do?
In Gerrit, I first run TryBots on a CL (mine or someone else)'s with "Reply" and then I click the "+1" button next to "Run-TryBot". This runs TryBots.
The TryBots run, but with errors that look *probably* unrelated to the CL.
Since I ran TryBots by clicking "+1" in the reply pane, "obviously" the way to do this is to reset the value to zero (the "0" is not dimmed, therefore this is permitted, right?) and then clock "+1" again (worked once, why not again?).
### What did you expect to see?
A second run of the TryBots.
### What did you see instead?
NOT a second run of the TryBots.
I understand that what's actually missing is that (1) we've decided that people need special permission for this operation (2) I lack this permission (3) I should know this by noticing the absence of a button that I never knew existed.
I think we ought to fix the policy unless there's a really good reason not to let people do this, and if we can't fix the policy, we need to fix the UI to avoid people intuiting an unproductive way to spend their time not rerunning TryBots. What I *actually* want is "Rerun failed TryBots" and ideally someone is monitoring that to infer flakiness over time.
My workaround for this is to attempt to do the rerun by hand using a gomote, which is its own fiasco of stale documentation and read-all-the-docs-maybe-you'll-find-a-hint (oops, the hint has gone stale also).
/cc @golang/osp-team
|
Builders,NeedsInvestigation
|
low
|
Critical
|
605,621,906 |
youtube-dl
|
[youku] Segments instead of m3u8
|
<!--
######################################################################
WARNING!
IGNORING THE FOLLOWING TEMPLATE WILL RESULT IN ISSUE CLOSED AS INCOMPLETE
######################################################################
-->
## Checklist
<!--
Carefully read and work through this check list in order to prevent the most common mistakes and misuse of youtube-dl:
- First of, make sure you are using the latest version of youtube-dl. Run `youtube-dl --version` and ensure your version is 2020.03.24. If it's not, see https://yt-dl.org/update on how to update. Issues with outdated version will be REJECTED.
- Search the bugtracker for similar feature requests: http://yt-dl.org/search-issues. DO NOT post duplicates.
- Finally, put x into all relevant boxes (like this [x])
-->
- [x] I'm reporting a feature request
- [x] I've verified that I'm running youtube-dl version **2020.03.24**
- [x] I've searched the bugtracker for similar feature requests including closed ones
## Description
<!--
Provide an explanation of your issue in an arbitrary form. Please make sure the description is worded well enough to be understood, see https://github.com/ytdl-org/youtube-dl#is-the-description-of-the-issue-itself-sufficient. Provide any additional information, suggested solution and as much context and examples as possible.
-->
Currently, the youku extractor only consideres the m3u8 to download the videos, but all videos have segmented mp4 files already included in the json in ``stream.segs.cdn_url``. The m3u8's may have missing keyframes (this was for me the case), so it would be nice to include this method as well, but I am not sure how to edit the module to download all segments.
|
request
|
low
|
Critical
|
605,679,050 |
go
|
cmd/compile: confusing compiler error when using if instead of for with range operator inside anonymous function
|
<!--
Please answer these questions before submitting your issue. Thanks!
For questions please use one of our forums: https://github.com/golang/go/wiki/Questions
-->
### What version of Go are you using (`go version`)?
<pre>
$ go version
go version go1.14.2 linux/amd64
</pre>
### Does this issue reproduce with the latest release?
Yes
### What operating system and processor architecture are you using (`go env`)?
<details><summary><code>go env</code> Output</summary><br><pre>
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/mezimm00/.cache/go-build"
GOENV="/home/mezimm00/.config/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/home/mezimm00/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/lib/go-1.14"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/lib/go-1.14/pkg/tool/linux_amd64"
GCCGO="gccgo"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="/home/mezimm00/machine/src/createI2chart/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build527871476=/tmp/go-build -gno-record-gcc-switches"
</pre></details>
### What did you do?
<!--
If possible, provide a recipe for reproducing the error.
A complete runnable program is good.
A link on play.golang.org is best.
-->
https://play.golang.org/p/DJKZqMtng4S
### What did you expect to see?
syntax error: unexpected range, expecting expression
### What did you see instead?
expression in go must be function call
When I typically see this error it's because I forgot the () on an anonymous function. In this case I didn't though. Instead, this error is reported when there was an error inside the anonymous function; that being using an if instead of the intended for with the range operator.
|
NeedsInvestigation,compiler/runtime
|
low
|
Critical
|
605,699,301 |
pytorch
|
CPU out of bound memory access in CUDA reduction kernel config
|
## 🐛 Bug
In the code https://github.com/pytorch/pytorch/blob/master/aten/src/ATen/native/cuda/Reduce.cuh, there is a
```C++
int64_t dim0;
int64_t dim1;
// Adjust block size to map block width to fastest changing dimension of input
// tensor. This grants the best possible memory accessing pattern, given that
// for non-contiguous tensor with space in between, we cannot have perfect
// memory coalescing.
int64_t fastest_moving_stride;
bool reduction_on_fastest_striding_dimension =
(iter.num_reduce_dims() == iter.ndim()) ||
(iter.strides(/*arg=*/input_index)[0] <
iter.strides(/*arg=*/input_index)[iter.num_reduce_dims()]);
// Notice that dim0 & dim1 does NOT guarantee any launch configuration here!
// dim0 & dim1 are more like the upper bound of the block dimension. The
// actual launch config and reduction scheme is determined by setting values
// to `config.input_mult` and `config.output_mult`.
// We try to max out dim1 so that we have enough threads per CTA to deliver
// performance for larger problem size.
if (reduction_on_fastest_striding_dimension) {
// Map block.x to the fastest reducing dimension. It implies:
// 1. block_x_reduce is required.
// 2. block.y now max out to num_outputs.
dim0 = iter.shape()[0];
dim1 = num_outputs;
fastest_moving_stride = iter.strides(/*arg=*/input_index)[0];
} else {
// Map block.x to the fastest non reducing dimension. It implies:
// 1. block_x_reduce is turned off.
// 2. block.y now max out to inputs_per_output.
dim0 = iter.shape()[iter.num_reduce_dims()];
dim1 = inputs_per_output;
fastest_moving_stride = iter.strides(/*arg=*/input_index)[iter.num_reduce_dims()];
}
```
For the cases where the input is a scalar, we can have `iter.shape()` and `iter.strides()` being empty array, and `iter.shape()[0]` would be an out of bound memory access.
## To Reproduce
No easy reproduce. I only see it cause flaky failures in https://github.com/pytorch/pytorch/pull/37095
```
[]
0
dim0=94599111233572, dim1=1
```
cc @ngimel
|
module: cuda,triaged,module: TensorIterator
|
low
|
Critical
|
605,706,998 |
svelte
|
transition:slide looks different (buggy) on Safari
|
**Describe the bug**
I am using transition:slide in order to slide in a div element after the user presses the button with the arrow pointing down. With Chrome and Firefox on Windows it looks perfect, however on Safari (iPadOS) the inner contents overlap with the button during the transition. Or to be more precise, the inner elements of #lookupAreaContent do not follow the behavior of #lookupAreaContent itself.
**To Reproduce**
Simplified version:
```html
<div>
{#if v_lookupArea}
<div id="lookupAreaContent" transition:slide>
<div>
<a href="https://www.google.com" target="_blank">test 1.</a>
</div>
<div>
<a href="https://www.google.com" target="_blank">test 2.</a>
</div>
<div>
<i>add_circle</i>
</div>
</div>
{/if}
<i on:click={toggleLookupArea}>expand_more</i>
</div>
<script>
import { slide } from "svelte/transition";
let v_lookupArea = false;
function toggleLookupArea(e) {
v_lookupArea = !v_lookupArea;
}
</script>
```
**Expected behavior**
Here is what it looks like on Chrome: [https://streamable.com/crvf1n](https://streamable.com/crvf1n)
And here is the buggy Safari behavior: [https://streamable.com/ldb1gh](https://streamable.com/ldb1gh)
**Information about your Svelte project:**
- Your browser and the version: Chrome 81 (correct), Safari (broken)
- Your operating system: Windows 10 (correct), iPadOS 13.4.1 (broken)
- Svelte version (Please check you can reproduce the issue with the latest release!): 3.20.1
- Whether your project uses Webpack or Rollup: Rollup
**Severity**
It is just a design flaw, nothing major.
|
bug
|
medium
|
Critical
|
605,711,280 |
pytorch
|
Per-cluster biases in AdaptiveLogSoftmaxWithLoss
|
## 🚀 Feature
Add per-cluster biases in addition to the main head bias in Pytorch's implementation of adaptive softmax.
## Motivation
[TransformerXL](https://arxiv.org/abs/1901.02860)'s implementation of adaptive softmax incorporates a bias for all the clusters. It would be nice to have Pytorch at parity with that SOTA.
## Pitch
I would like to add a flag to the class constructor to add per-cluster biases, and then use them in the logprob calculations.
## Additional context
Hugging Face already uses code by @thomwolf that only deviates from Pytorch code in this regard. I can quickly fix up a PR that adds the possibility of cluster biases if this feature is deemed interesting.
|
feature,module: nn,triaged,needs research
|
low
|
Minor
|
605,723,329 |
vscode
|
Can't click to set/clear breakpoint when a gutter decoration exists
|
Here I am using the Bookmarks extension, and you can't click where the bookmark is to set/clear a break point.
If I hit F9 to set the break point it works as I would expect, even with the breakpoint indicator on top of the bookmark one.
|
feature-request,editor-rendering
|
low
|
Major
|
605,724,374 |
vue
|
Add user timing measurement for lifecycle hooks
|
### What problem does this feature solve?
My app had performance issue due to some slow lifecycle hooks.
It would be easy to find an issue like that if `Vue.config.performance` API records lifecycle hooks too.
### What does the proposed API look like?
With `Vue.config.performance = true`, I can observe timings of lifecycle hooks as like `vue <Foo> mounted` in "Timings" section in the devtools as well as current `Vue.config.performance` behavior for init/compile/render/patch events.
<!-- generated by vue-issues. DO NOT REMOVE -->
|
improvement
|
medium
|
Major
|
605,728,590 |
flutter
|
DMLERR_EXECACKTIMEOUT during 'flutter doctor --androids-licenses'
|
## command
`flutter doctor --android-licenses`
## exception
`FileSystemException: FileSystemException: writeFrom failed, path = '' (OS Error: OS Error 16389, errno = 16389)`
```bash
#0 _RandomAccessFile.writeFromSync (dart:io/file_impl.dart:881:7)
#1 _StdConsumer.addStream.<anonymous closure> (dart:io/stdio.dart:310:15)
#2 _rootRunUnary (dart:async/zone.dart:1134:38)
#3 _CustomZone.runUnary (dart:async/zone.dart:1031:19)
#4 _CustomZone.runUnaryGuarded (dart:async/zone.dart:933:7)
#5 _BufferingStreamSubscription._sendData (dart:async/stream_impl.dart:338:11)
#6 _BufferingStreamSubscription._add (dart:async/stream_impl.dart:265:7)
#7 _SyncStreamControllerDispatch._sendData (dart:async/stream_controller.dart:766:19)
#8 _StreamController._add (dart:async/stream_controller.dart:642:7)
#9 _StreamController.add (dart:async/stream_controller.dart:588:5)
#10 _Socket._onData (dart:io-patch/socket_patch.dart:1851:41)
#11 _rootRunUnary (dart:async/zone.dart:1138:13)
#12 _CustomZone.runUnary (dart:async/zone.dart:1031:19)
#13 _CustomZone.runUnaryGuarded (dart:async/zone.dart:933:7)
#14 _BufferingStreamSubscription._sendData (dart:async/stream_impl.dart:338:11)
#15 _BufferingStreamSubscription._add (dart:async/stream_impl.dart:265:7)
#16 _SyncStreamControllerDispatch._sendData (dart:async/stream_controller.dart:766:19)
#17 _StreamController._add (dart:async/stream_controller.dart:642:7)
#18 _StreamController.add (dart:async/stream_controller.dart:588:5)
#19 new _RawSocket.<anonymous closure> (dart:io-patch/socket_patch.dart:1399:33)
#20 _NativeSocket.issueReadEvent.issue (dart:io-patch/socket_patch.dart:919:14)
#21 _microtaskLoop (dart:async/schedule_microtask.dart:43:21)
#22 _startMicrotaskLoop (dart:async/schedule_microtask.dart:52:5)
#23 _runPendingImmediateCallback (dart:isolate-patch/isolate_patch.dart:118:13)
#24 _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:175:5)
```
## flutter doctor
```console
[32m[✓][39m Flutter (Channel stable, v1.12.13+hotfix.9, on Microsoft Windows [Version 10.0.18363.778], locale ko-KR)
[32m•[39m Flutter version 1.12.13+hotfix.9 at C:\Users\Jinwoo\Jinwoo\Programming\flutter
[32m•[39m Framework revision f139b11009 (3 weeks ago), 2020-03-30 13:57:30 -0700
[32m•[39m Engine revision af51afceb8
[32m•[39m Dart version 2.7.2
[33m[!][39m Android toolchain - develop for Android devices (Android SDK version 29.0.3)
[32m•[39m Android SDK at C:\Users\Jinwoo\AppData\Local\Android\sdk
[32m•[39m Android NDK location not configured (optional; useful for native profiling support)
[32m•[39m Platform android-29, build-tools 29.0.3
[32m•[39m Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
[32m•[39m Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b04)
[31m✗[39m Android license status unknown.
Try re-installing or updating your Android SDK Manager.
See https://developer.android.com/studio/#downloads or visit https://flutter.dev/setup/#android-setup for detailed
instructions.
[32m[✓][39m Android Studio (version 3.6)
[32m•[39m Android Studio at C:\Program Files\Android\Android Studio
[32m•[39m Flutter plugin version 45.1.1
[32m•[39m Dart plugin version 192.7761
[32m•[39m Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b04)
[33m[!][39m VS Code, 64-bit edition (version 1.44.1)
[32m•[39m VS Code at C:\Program Files\Microsoft VS Code
[31m✗[39m Flutter extension not installed; install from
https://marketplace.visualstudio.com/items?itemName=Dart-Code.flutter
[32m[✓][39m Connected device (1 available)
[32m•[39m SM J730K • 5200e81ebc9a64d9 • android-arm • Android 9 (API 28)
[33m![39m Doctor found issues in 2 categories.
```
|
c: crash,tool,found in release: 1.12,P2,team-tool,triaged-tool
|
low
|
Critical
|
605,751,227 |
pytorch
|
Enhanced operator context when reporting errors
|
I don't intend to implement this in my first go at a new shape checking API, so I'm writing this down so I don't lose track of it.
Today, when you trigger an error in PyTorch, you get an error, but not information about the inputs that triggered it. For example:
```
>>> torch.zeros(2,3) + torch.zeros(3,2)
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
RuntimeError: The size of tensor a (3) must match the size of tensor b (2) at non-singleton dimension 1
```
Enhanced operator context would mean that we print out abridged information about the operator call that triggered the error in question. So instead you would see:
```
RuntimeError: The size of tensor a (3) must match the size of tensor b (2) at non-singleton dimension 1
In add(self: Tensor[2, 3], other: Tensor[3, 2])
```
## Principles
1. It must be possible to add this error-reporting logic to operators in PyTorch while minimizing boilerplate. It should be obvious and simple how to add operator context to an operator.
2. Context should not provide extraneous information by default. If your error is related to shapes, don't print the dtypes of the input tensors (and vice versa). If you didn't set an argument that has a default, don't print the default of it.
3. Syntax of context should match Python conventions; i.e. don't make up new syntax, everything should make sense to someone who knows how to read Python syntax. (We may use syntax in unusual ways though!)
4. Operator context should apply for all levels of the dispatch stack; e.g., if the profiling or autograd dispatch handlers raise an error, you should still get context for them. Put differently, operator context is based on the *user* interaction with the operator, not the internal details of how the operator is implemented.
## Format proposal
**Basics.**
* Operator context is the string "In opname(...op arguments...)"
* `opname` is the name of the operator as per `native_functions.yaml`. The name includes namespace. The name may not necessarily correspond to the visible Python name, but it should correspond exactly to the exposed name via `torch._C`, and it should be reasonably clear to users what it means.
* Should we include the overload name? Tentatively, I suggest we don't include it.
* Operator arguments describe the arguments that were passed to the operator.
* All arguments are explicitly named, even if they are conventionally passed positionally. So, we say `In add(self: Tensor[2, 3], other: Tensor[3,2])` rather than `In add(Tensor[2, 3], Tensor[3, 2])`.
* If an argument is defaulted in schema, and the setting of the argument matches the default, it is omitted from the printing
* If the argument is a tensor, we do not print the entire tensor, instead we only print its shape, in the format `argname: Tensor[size0, size1, ...]`
* Arguments that are printed by value are printed using equals sign; arguments that are printed by type are printed using colon
Examples:
```
In avg_pool2d(self: Tensor[256, 256], kernel_size=[2, 2])
```
**Context aware Tensor type printing.** Typically, a Tensor is not just a size; it also has a dtype, a layout, maybe it has unusual strides. Following the "do not provide extraneous information by default" guidance, we should not print this information unless it is relevant to the error message in question. I think the best way to control this is to make shape/dtype checking errors more structured, so that the try-catch block can inspect the error to figure out what kind of context it should print. We then have:
* If the error is a shape checking error, print `self: Tensor[20, 20]`
* If the error is a dtype checking error, print `self: Tensor[float32]` (alt: `self: FloatTensor`)
* If the error is relates to strides, print `self: Tensor[size=[20, 20], stride=[20, 1]]`
There should be some mechanism (maybe an environment variable) to verbosely print ALL possibly relevant metadata about the tensors.
## Implementation notes
Operator context will be attached to error messages using the mechanism in #37101. The key question is where we should insert operator context, and what the syntax for specifying operator context should be. We first note that adding operator context is **optional**; there is no harm to forgetting to add context, error messages just are marginally less useful in this case.
We suggest operator context should be specified at the *entry point* to the dispatching stack. So for example, we currently have:
```
// ATen/Functions.h
// aten::add.Tensor(Tensor self, Tensor other, *, Scalar alpha=1) -> Tensor
static inline Tensor add(const Tensor & self, const Tensor & other, Scalar alpha) {
static c10::OperatorHandle op = c10::Dispatcher::singleton()
.findSchemaOrThrow("aten::add", "Tensor");
return op.callUnboxed<Tensor, const Tensor &, const Tensor &, Scalar>(self, other, alpha);
}
```
we suggest extending this definition (and not, e.g., the backend implementation), with the try catch block that adds context:
```
static inline Tensor add(const Tensor & self, const Tensor & other, Scalar alpha) {
static c10::OperatorHandle op = c10::Dispatcher::singleton()
.findSchemaOrThrow("aten::add", "Tensor");
try {
return op.callUnboxed<Tensor, const Tensor &, const Tensor &, Scalar>(self, other, alpha);
} catch (Error& e) {
TORCH_RETHROW(e, op.formatUnboxed<Tensor, const Tensor&, const Tensor&, Scalar>(e, self, other, alpha));
}
}
```
A hypothetical implementation of `formatUnboxed` consults the *schema* accessible from `OperatorHandle` so that it can assess whether or not default arguments should be provided, and to determine the names of the input types. It might be possible to reduce the number of generated templates by doing something like `op.format(e, initializer_list<IValue>{self, other, alpha})` and rely on boxing to provide the input arguments in some uniform representation. (Or perhaps formatting could happen via templating on the spot, and then get assembled together inside the implementation of format.)
If there are other call sites to the operator (e.g., by callBoxed in the JIT), these must provide their own implementations of context addition.
|
triaged,enhancement,module: shape checking
|
low
|
Critical
|
605,754,172 |
godot
|
Godot seems to cause coreaudiod to use excessive CPU time.
|
**Godot version:**
3.2.2
**OS/device including version:**
macOS Catalina (10.15.4), 2020 MacBook Air i7 16gb RAM.
**Issue description:**
Godot seems to cause coreaudiod to use excessive CPU time. This happens even in the project manager and editor which don't need to be using Audio. This is an issues as it causes Godot based software to burn more battery than they need to.
**Steps to reproduce:**
Just start Godot editor and look at the activity monitor, the coreaudiod CPU usage will jump from 0% to ~10%
**Minimal reproduction project:**
N/A
|
bug,platform:macos,confirmed,topic:audio,performance
|
medium
|
Major
|
605,760,710 |
pytorch
|
torch.distributions bug in RelaxedOneHotCategorical.log_prob
|
## 🐛 Bug
I'm a new user so maybe I misunderstood something - but I think I found a bug in torch.distributions.RelaxedOneHotCategorical. I also think I have a fix for it.
I would like to create a batch of n distributions with different temerature parameters. I believe the way to do this is to pass in temperature of size [n,1], and logits of size [n,k] (where k is the number of categories). However, calling log_prob returns an output of size [n,n] rather than [n,1] or just [n]
I believe the fix is to change line 83 of relaxed_categorical.py to:
`
score = (score - score.logsumexp(dim=-1, keepdim=True)).sum(-1, keepdim=True)
`
Also: to access ExpRelaxedCategorical you have to say td.relaxed_categorical.ExpRelaxedCategorical, rather than just td.ExpRelaxedCategorical. Can this be fixed too?
## To Reproduce
```
dist = td.relaxed_categorical.ExpRelaxedCategorical(
temperature=torch.ones(5,1), logits = torch.zeros(5,2)
)
print(dist.log_prob(torch.ones(5,2)/2).shape)
````
<!-- If you have a code sample, error messages, stack traces, please provide it here as well -->
Output is:
```
torch.Size([5, 5])
```
<!-- A clear and concise description of what you expected to happen. -->
I thought it should be torch.Size([5,1]) or torch.Size([5]
## Environment
Collecting environment information...
PyTorch version: 1.4.0
Is debug build: No
CUDA used to build PyTorch: 10.1
OS: Microsoft Windows 10 Pro
GCC version: Could not collect
CMake version: Could not collect
Python version: 3.8
Is CUDA available: No
CUDA runtime version: Could not collect
GPU models and configuration: GPU 0: GeForce GPU
Nvidia driver version: 391.40
cuDNN version: Could not collect
Versions of relevant libraries:
[pip] Could not collect
[conda] blas 1.0 mkl
[conda] cudatoolkit 10.1.243 h74a9793_0
[conda] mkl 2020.0 166
[conda] mkl-service 2.3.0 py38hb782905_0
[conda] mkl_fft 1.0.15 py38h14836fe_0
[conda] mkl_random 1.1.0 py38hf9181ef_0
[conda] numpy 1.18.1 py38h93ca92e_0
[conda] numpy-base 1.18.1 py38hc3f5095_1
[conda] pytorch 1.4.0 py3.8_cuda101_cudnn7_0 pytorch
[conda] torchvision 0.5.0 py38_cu101 pytorch
cc @vincentqb @fritzo @neerajprad @alicanb @vishwakftw
|
module: distributions,triaged
|
low
|
Critical
|
605,780,800 |
TypeScript
|
`Exclude<Exclude<T, null>, undefined>` is not assignable to `Exclude<T, null | undefined>` and vice versa
|
<!-- 🚨 STOP 🚨 𝗦𝗧𝗢𝗣 🚨 𝑺𝑻𝑶𝑷 🚨
Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Even if you think you've found a *bug*, please read the FAQ first, especially the Common "Bugs" That Aren't Bugs section!
Please help us by doing the following steps before logging an issue:
* Search: https://github.com/Microsoft/TypeScript/search?type=Issues
* Read the FAQ: https://github.com/Microsoft/TypeScript/wiki/FAQ
Please fill in the *entire* template below.
-->
**TypeScript Version:** Nightly
<!-- Search terms you tried before logging this (so others can find this issue more easily) -->
**Search Terms:**
typescript nullness inference
**Expected behavior:**
They should be assignable to each other.
**Actual behavior:**
They are not considered assignable to each other.
```
Type 'Exclude<Exclude<T, null>, undefined>' is not assignable to type 'Exclude<T, null | undefined>'.
Type 'Exclude<T, null>' is not assignable to type 'Exclude<T, null | undefined>'.
Type 'T' is not assignable to type 'Exclude<T, null | undefined>'.(2322)
```
and
```
Type 'Exclude<T, null | undefined>' is not assignable to type 'Exclude<Exclude<T, null>, undefined>'.
Type 'T' is not assignable to type 'Exclude<Exclude<T, null>, undefined>'.(2322)
```
<!-- Did you find other bugs that looked similar? -->
**Related Issues:**
N/A
**Code**
```ts
export function f<T>(v: Exclude<Exclude<T, null>, undefined>) {
const w: Exclude<T, null | undefined> = v;
}
export function g<T>(v: Exclude<T, null | undefined>) {
const w: Exclude<Exclude<T, null>, undefined> = v;
}
```
<details><summary><b>Output</b></summary>
```ts
export function f(v) {
const w = v;
}
export function g(v) {
const w = v;
}
```
</details>
<details><summary><b>Compiler Options</b></summary>
```json
{
"compilerOptions": {
"noImplicitAny": true,
"strictNullChecks": true,
"strictFunctionTypes": true,
"strictPropertyInitialization": true,
"strictBindCallApply": true,
"noImplicitThis": true,
"noImplicitReturns": true,
"useDefineForClassFields": false,
"alwaysStrict": true,
"allowUnreachableCode": false,
"allowUnusedLabels": false,
"downlevelIteration": false,
"noEmitHelpers": false,
"noLib": false,
"noStrictGenericChecks": false,
"noUnusedLocals": false,
"noUnusedParameters": false,
"esModuleInterop": true,
"preserveConstEnums": false,
"removeComments": false,
"skipLibCheck": false,
"checkJs": false,
"allowJs": false,
"declaration": true,
"experimentalDecorators": false,
"emitDecoratorMetadata": false,
"target": "ES2017",
"module": "ESNext"
}
}
```
</details>
**Playground Link:** [Provided](https://www.typescriptlang.org/play/?ts=3.9.0-dev.20200422&ssl=4&ssc=1&pln=1&pc=1#code/KYDwDg9gTgLgBAMwK4DsDGMCWEWIDwAqAfABQBuAXHAKIhoA2SAJsHrQ86wQDRwpL16RXqhYJMKYEyIBKOAG8AUHBVw0OAM7wA7lXaMWhXv0FwAPnFHBxk6XAC8cMgG5FAX0WLQkWIlQZsXABzQlJKGjoDLmMBenNLFDEJKVkFZVV1FC04XQiOQ31OIz5Y4QSk2yIHJ1cPRSA)
|
Suggestion,Needs Proposal
|
low
|
Critical
|
605,789,541 |
rust
|
must_use Option::map*
|
We were discussing https://github.com/rust-lang/rust/issues/71368 in the language team meeting today, and it came up that `Option::map` should probably be marked must_use. There are technically valid use cases which do not require using the result (i.e. side-effecting uses), but these are so rare that it seems unlikely that we need to worry about them for the purposes of such a lint.
(Probably other combinators on Option should also be checked).
|
T-libs-api,C-feature-request
|
low
|
Major
|
605,820,914 |
TypeScript
|
Generic interface confuses parameter identifier with symbolic property identifier
|
<!-- 🚨 STOP 🚨 𝗦𝗧𝗢𝗣 🚨 𝑺𝑻𝑶𝑷 🚨
Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Even if you think you've found a *bug*, please read the FAQ first, especially the Common "Bugs" That Aren't Bugs section!
Please help us by doing the following steps before logging an issue:
* Search: https://github.com/Microsoft/TypeScript/search?type=Issues
* Read the FAQ: https://github.com/Microsoft/TypeScript/wiki/FAQ
Please fill in the *entire* template below.
-->
<!--
Please try to reproduce the issue with the latest published version. It may have already been fixed.
For npm: `typescript@next`
This is also the 'Nightly' version in the playground: http://www.typescriptlang.org/play/?ts=Nightly
-->
**TypeScript Version:** 3.9.0-dev.20200422
<!-- Search terms you tried before logging this (so others can find this issue more easily) -->
**Search Terms:**
generic identifier interface parameter enum
**Code**
```ts
enum Enum {
Foo = "Foo"
}
interface Generic1<Foo> {
[Enum.Foo]: Foo;
}
interface Generic2<Bar> {
[Enum.Foo]: Bar;
}
```
**Expected behavior:**
No errors
**Actual behavior:**
Complaint that, within `Generic1`, `Foo` is a duplicated identifier -- supposedly vs `Enum.Foo`, even though they clearly refer to completely different things and are unambiguous symbols.
**Playground Link:** <!-- A link to a TypeScript Playground "Share" link which demonstrates this behavior -->
[here](https://www.typescriptlang.org/play/?ts=3.9.0-dev.20200422&ssl=1&ssc=1&pln=12&pc=1#code/KYOwrgtgBAou1QN4CgpQGIHtNQLxQCItMDkBfZZASxABdgAnAMwEMBjYKAcVEarYCMAHmIA+JKigBtOJAB0xALoAuDNgDc5SjXrN2nHiD5sATEIBCLBuJRoZ8BdhVRLDTRSA)
|
Bug
|
low
|
Critical
|
605,821,766 |
PowerToys
|
Invalid drop down selection in KBM results in a empty selection
|
Currently if the user enters invalid input we just reset the selection to null. We should consider resetting it to the last valid selection.
In the above example, when the warning is shown maybe it could revert back to `F5` instead of an empty selection.
|
Issue-Bug,Product-Keyboard Shortcut Manager,Priority-3
|
low
|
Minor
|
605,855,061 |
TypeScript
|
Emit .d.ts for type-only usage of .d.ts files in a project
|
## Search Terms
type only export import declaration declarations .d.ts 3.8
## Suggestion
When building code has `.d.ts` files written and used internally, the declarations aren't emitted. This makes sense currently because `.d.ts` files aren't compiled. However, it causes typechecking errors when exporting content from the package for external usage, since the declaration isn't included in the compiled output.
`import/export type` made some initial progress for me by removing the types from the compiled JS output. but I believe it would be even more useful to re emit declarations for type only import exports. this would ensure that ambient declarations are included in the final compiled output.
My issue may be incorrect usage of declaration files, which I've only been using due to the external code generation using it. I'm not sure I explained my idea clearly, but I believe my below examples should cover it - please follow up if not.
## Use Cases
I have an existing project that exports declarations generated by an external package from non-JS code. The original code doesn't need to be included, just the types for usage by external consumers. When I want to reexport those declarations, I have to manually copy them over to the build folder after since they disappear. [You can see an example of this here](https://github.com/OffchainLabs/arbitrum/blob/ape-housekeeping/packages/arb-provider-ethers/src/lib/abi/index.ts)
## Examples
given directory structure
```
./src/index.ts
./src/generated.d.ts
```
and usage
```
// ./src/index.ts
import type Foo from './generated.d.ts'
```
the output structure should be
```
./dist/index.js
./dist/index.d.ts
./dist/generated.d.ts
```
## Checklist
My suggestion meets these guidelines:
* [x] This wouldn't be a breaking change in existing TypeScript/JavaScript code
* [x] This wouldn't change the runtime behavior of existing JavaScript code
* [x] This could be implemented without emitting different JS based on the types of the expressions
* [x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
* [x] This feature would agree with the rest of [TypeScript's Design Goals](https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals).
|
Suggestion,Needs Proposal
|
low
|
Critical
|
605,894,970 |
godot
|
Dock plugin with viewport and edit main screen interaction leads to duplicated viewport content
|
**POTENTIALLY NOT A BUG** -> Can be fixed by using Viewport own world
**Godot version:**
3.1.2 Stable official
**OS/device including version:**
Windows 10 latest
**Issue description:**
I was trying to create a plugin (editor dock) that render a 3D model via a viewport. However when both activating the dock and editing the dock scene in the editor, the content of the viewport get duplicated.
Here is an image to explain it, the dock scene contains only one mesh (cube one), but when I open the 3D view (or the 2D one) the cube gets duplicated and there is two of them now. The dock scene is definitely linked to the one we edit, because when I edit the cube position, I see it updating synchronously on the dock. But i'm not sure the duplicated mesh is normal here.
Please note that when I close the dock scene edition tab, **the duplicated mesh disappear**
**Steps to reproduce:**
Create a dock plugin with the following scene :
ViewportContainer
- Viewport
- Mesh
- Camera3D
Then activate the dock and also open the scene in order to edit it, you'll see the duplicated mesh
**Minimal reproduction project:**
[ViewportEditorPluginBug.zip](https://github.com/godotengine/godot/files/4525436/ViewportEditorPluginBug.zip)
|
discussion
|
low
|
Critical
|
605,896,529 |
PowerToys
|
[Run][Shell plugin] There is no auto-complete text suggestion
|
when searching using shell plugin, there is no auto-complete text suggestion.
|
Idea-Enhancement,Product-PowerToys Run,Run-Plugin
|
low
|
Minor
|
605,904,988 |
terminal
|
Smack user in a face with release notes after update
|
<!--
🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨
I ACKNOWLEDGE THE FOLLOWING BEFORE PROCEEDING:
1. If I delete this entire template and go my own path, the core team may close my issue without further explanation or engagement.
2. If I list multiple bugs/concerns in this one issue, the core team may close my issue without further explanation or engagement.
3. If I write an issue that has many duplicates, the core team may close my issue without further explanation or engagement (and without necessarily spending time to find the exact duplicate ID number).
4. If I leave the title incomplete when filing the issue, the core team may close my issue without further explanation or engagement.
5. If I file something completely blank in the body, the core team may close my issue without further explanation or engagement.
All good? Then proceed!
-->
# Description of the new feature/enhancement
Smack user in a face with release notes dialog/view/whatever you feel like appropriate after each update. It should be rather opt in feature as I can imagine not everybody wishes to see those.
It should solve (to some extent) situations like #5458 where breaking changes had limited visibility until user got hit with fallout. And those which run on Windows Store version (like I do) and don't hold their hand on the pulse of latest upcoming changes (just like me) were pretty surprised by it.
<!--
A clear and concise description of what the problem is that the new feature would solve.
Describe why and how a user would use this new functionality (if applicable).
-->
# Proposed technical implementation details (optional)
In perfect world I would love to see it 1-to-1 like VS Code does. Love how they did release notes and call me pervert but I read them from cover to cover every single time. You simply get smacked with new tab with clear and well organized release notes in every time you get updated. I imagine that built in dedicated view like in VS Code may be not quite feasible in reasonable time/budget but opening browser window pointing to release notes will do the job too.
<!--
A clear and concise description of what you want to happen.
-->
|
Issue-Feature,Area-UserInterface,Product-Terminal
|
low
|
Critical
|
605,916,454 |
rust
|
Lint against useless `&mut`
|
In rust-analyzer, I had the following code:
```rust
impl Completions {
pub(crate) fn add_field(
&mut self,
ctx: &CompletionContext,
field: hir::StructField,
ty: &Type,
) {
let is_deprecated = is_deprecated(field, ctx.db);
let mut completion_item = CompletionItem::new(CompletionKind::Reference)
.kind(CompletionItemKind::Field)
.build();
compute_score(&mut completion_item, ctx);
self.add(completion_item);
}
}
pub(crate) fn compute_score(
completion_item: &mut CompletionItem,
ctx: &CompletionContext,
) {
...
}
```
I've changed the `compute_score` function to
```rust
pub(crate) fn compute_score(
completion_item: &CompletionItem,
ctx: &CompletionContext,
) -> Option<CompletionScore> {
...
}
```
After that, the code compiled without warnings, was broken, because `compute_score(&mut completion_item, ctx);` statement no longer did what it was supposed to be doing.
The smell here I think is that we use explicit `&mut`, which gets silently reborrowed to `&`. I think we should lint against, roughly, all programs where `&mut e` expression can be replaced with `&e` without breaking the compilation.
|
A-lints,T-lang,C-feature-request
|
low
|
Critical
|
605,943,592 |
TypeScript
|
Allow this in type guards when type of this is explicitly specified in method signature
|
## Search Terms
"A 'this' type is available only in a non-static member of a class or interface.(2526)" guard
Relevant: #37796 (but this one is different)
## Suggestion
Remove error 2526 in guard condition if type of `this` is specified explicitly using `this: SomeType`.
Since both guard condition and method body work as expected, I assume only the error check needs to be removed.
## Use Cases
Defining a guard without having a class (have some cases where full class would be an overkill).
## Examples
```typescript
({
guard(this: { x?: 1 }): this is { x: 1 } {
return this.x === 1;
}
})
```
https://www.typescriptlang.org/play/index.html?ssl=5&ssc=3&pln=1&pc=1#code/BQbwsAUABDUOYFcCGAnAJsALgCwJYGcAuKEKADwH5iBGKAXwEpicCpXSyb6TJY+oUAU0wIUAOygt8AOjJQAvIqjUA3L1h1IjIA
Note that `this` is not `any` and works perfectly fine in both the method body and the guard:
```
const o = ({
x: 1 as 1|2,
guard(this: { x: 1 | 2 }): this is { x: 1 } {
// body works
return this.x === 1;
}
});
if (o.guard()) {
// guard works
const check: 1 = o.x;
}
```
https://www.typescriptlang.org/play/index.html#code/MYewdgzgLgBCMF4YAoDeBYAUDHMAeAXDAIwwCGEJAPgEwA0WuMA5gK5kBOAJslABYBLCEVT4ipKjBowAvgEoi-ITGWjCJWTAzYmuAPR6YAIxBcAnjADuIDgGsIjXTg4BTKKw5gYSiADo8iAhIxADcjjgyWPJhmFgCAGYoIL5snDxyclrhMAYs7NxWNvbZoJCwwHwuwLbiiHD+MTJAA
Would be good to support guard in `ThisType<>` as well (see #37796), but can be a separate thing.
## Checklist
My suggestion meets these guidelines:
* [x] This wouldn't be a breaking change in existing TypeScript/JavaScript code
* [x] This wouldn't change the runtime behavior of existing JavaScript code
* [x] This could be implemented without emitting different JS based on the types of the expressions
* [x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
* [x] This feature would agree with the rest of [TypeScript's Design Goals](https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals).
|
Suggestion,In Discussion
|
low
|
Critical
|
605,950,220 |
go
|
spec: clarify timing of nil-checks for defer/go statements
|
Test program: https://play.golang.org/p/rDWCdf_ha5w
This program tests various conditions where a deferred function call can panic "early" (i.e., at the time of the defer statement) or "late" (i.e., at the time the deferred function is actually invoked).
When compiled with cmd/compile, it prints "early late early \\\\ early late early \\\\ late".
When compiled with gccgo (edit: 8.0), it prints "**late** late early \\\\ **late** late early \\\\" and then crashes with a fatal error. (Edit: gccgo 10.0.1 prints "late late early \\\\ late late early \\\\ late".)
--
I think cases 2, 3, 5, and 6 where cmd/compile and gccgo agree are correctly implemented.
I think gccgo is wrong to fatally error on case 7. (If for no reason other than because the fatal error says "go of nil func value", but it's a defer statement.)
I'm unsure about cases 1, 4, and 7 otherwise though. I suspect they should all be "early" or all be "late" though.
/cc @griesemer @ianlancetaylor
|
NeedsInvestigation
|
low
|
Critical
|
605,971,028 |
go
|
x/mobile: gomobile init is broken
|
I tried the experimental OpenAL bindings for gomobile but they won't build for Android because the `AL/al.h` header is missing. I don't know how the compilation works, and in a somewhat desperate attempt I installed https://github.com/AerialX/openal-soft-android, but with no success. Should these headers be installed in the Android NDK? I would appreciate some help :) (I saw several issues but AFAIK this is the only way to play audio in gomobile right now).
|
NeedsInvestigation,mobile
|
low
|
Critical
|
605,998,988 |
pytorch
|
Make it harder to make SIOF bugs for torchbind classes referenced by schemas
|
See https://github.com/pytorch/pytorch/pull/34140/files#r414252788
|
triaged,better-engineering
|
low
|
Critical
|
606,001,582 |
terminal
|
After resizing, some previous text content appears unexpectedly.
|
# Environment
```none
Microsoft Windows [Version 10.0.18363.778]
Windows Terminal version (if applicable): Version: 0.11.1121.0
Any other software?
```
# Steps to reproduce
1. type htop
2. enter Alt+enter to Full Screen
3. enter Alt+enter to window mode
4. type q to quit htop
5. Type Enter
6. Type Enter
7. Type Enter
8. Type Enter * N times
# Expected behavior
Just show one and one command prompt.
# Actual behavior
After several Enters, some blue lines appears
|
Area-Output,Issue-Bug,Product-Terminal,Priority-2
|
low
|
Minor
|
606,009,387 |
pytorch
|
RuntimeError: Tried to instantiate class __file__.__file__ but it does not exist! Ensure that it is registered via torch::jit::class_
|
## 🐛 Bug
Input `vars(torch)` got
```
Traceback (most recent call last):
File "C:\Users\myluo\AppData\Local\Programs\Python\Python36\lib\site-packages\IPython\core\formatters.py", line 224, in catch_format_error
r = method(self, *args, **kwargs)
File "C:\Users\myluo\AppData\Local\Programs\Python\Python36\lib\site-packages\IPython\core\formatters.py", line 702, in __call__
printer.pretty(obj)
File "C:\Users\myluo\AppData\Local\Programs\Python\Python36\lib\site-packages\IPython\lib\pretty.py", line 385, in pretty
return self.type_pprinters[cls](obj, self, cycle)
File "C:\Users\myluo\AppData\Local\Programs\Python\Python36\lib\site-packages\IPython\lib\pretty.py", line 620, in inner
p.pretty(obj[key])
File "C:\Users\myluo\AppData\Local\Programs\Python\Python36\lib\site-packages\IPython\lib\pretty.py", line 402, in pretty
return _repr_pprint(obj, self, cycle)
File "C:\Users\myluo\AppData\Local\Programs\Python\Python36\lib\site-packages\IPython\lib\pretty.py", line 697, in _repr_pprint
output = repr(obj)
File "<frozen importlib._bootstrap>", line 302, in _module_repr
File "<frozen importlib._bootstrap>", line 295, in _module_repr
File "C:\Users\myluo\AppData\Local\Programs\Python\Python36\lib\site-packages\torch\_classes.py", line 10, in __getattr__
proxy = torch._C._get_custom_class_python_wrapper(self.name, attr)
RuntimeError: Tried to instantiate class __file__.__file__ but it does not exist! Ensure that it is registered via torch::jit::class_
```
## To Reproduce
Steps to reproduce the behavior:
1. `vars(torch)`
## Expected behavior
Some expected output
## Environment
PyTorch version: 1.5.0+cu101
Is debug build: No
CUDA used to build PyTorch: 10.1
OS: Microsoft Windows 10 企业版
GCC version: Could not collect
CMake version: version 3.12.0-rc3
Python version: 3.6
Is CUDA available: Yes
CUDA runtime version: 10.1.243
GPU models and configuration: GPU 0: GeForce GTX 1070
Nvidia driver version: 426.00
cuDNN version: Could not collect
Versions of relevant libraries:
[pip3] msgpack-numpy==0.4.4.3
[pip3] numpy==1.18.1
[pip3] torch==1.5.0+cu101
[pip3] torchfile==0.1.0
[pip3] torchnet==0.0.4
[pip3] torchstat==0.0.7
[pip3] torchvision==0.6.0+cu101
[conda] Could not collect
## Additional context
<!-- Add any other context about the problem here. -->
cc @suo
|
needs reproduction,oncall: jit,triaged
|
low
|
Critical
|
606,019,476 |
flutter
|
Enable "slow tap" in widget tester
|
Internal: b/139892348
From customer:dream (g3)
An exciting bug that took a lot of digging to debug; onTap being called only intermittently on a widget. It turned out to be because onTapDown I was changing the widget hierarchy from
X -> GestureDetector -> child
to
X -> RipplePainter -> GestureDetector -> child
This caused the GestureDetector to be discarded and rebuilt, which sent onTapCancel - but if you ended the tap within the same frame, it would send onTapUp first, and would work fine.
Which meant it worked fine in unit tests (tester.tap is always within a single pump) and also worked consistently in the simulator (not sure if the simulator groups mouse actions or if it's just that a mouse button is less spongy than a finger on a screen), but worked only about 30-40% of the time on an actual Jasper device.
Feels like it would be worth having a "slowTap" helper function to use in unit tests, to simulate realistic taps and provoke behaviors that would otherwise only reveal themselves too late in production. (Doing tapDown+pump+tapUp).
|
a: tests,c: new feature,framework,customer: dream (g3),c: proposal,P3,team-framework,triaged-framework
|
low
|
Critical
|
606,068,409 |
ant-design
|
TreeSelect树选择再model显示，多选后很多后，IE11下输入框不自动换行
|
- [ ] I have searched the [issues](https://github.com/ant-design/ant-design/issues) of this repository and believe that this is not a duplicate.
### Reproduction link
[https://ant.design/](https://ant.design/)
### Steps to reproduce
TreeSelect树选择再model显示，，多选后很多后，IE11下输入框不自动换行
### What is expected?
输入框内容自动换行
### What is actually happening?
不换行
| Environment | Info |
|---|---|
| antd | 4.1.4 |
| React | 16.8.6 |
| System | win10 |
| Browser | IE11 |
<!-- generated by ant-design-issue-helper. DO NOT REMOVE -->
|
Internet Explorer,Inactive
|
low
|
Minor
|
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.