id
int64 393k
2.82B
| repo
stringclasses 68
values | title
stringlengths 1
936
| body
stringlengths 0
256k
β | labels
stringlengths 2
508
| priority
stringclasses 3
values | severity
stringclasses 3
values |
|---|---|---|---|---|---|---|
600,145,889 |
flutter
|
flavor flag should support multiple values: flutter build apk --flavor channelA,channelB,channelC
|
Can support flutter build apk --flavor channelA,channelB,channelC...
|
c: new feature,tool,P3,team-tool,triaged-tool
|
low
|
Minor
|
600,153,300 |
pytorch
|
RuntimeError: Expected cuda::check_device({sparse_, r_, t, dense}) to be true, but got false.
|
I try to use DataParallel to model ,and i get this.I don't know why and how to fix it οΌis there any suggestion?
I use DataParallel like this:
if cmd_args.mode == 'gpu':
classifier = classifier.cuda()
classifier = nn.DataParallel(classifier)
Exception has occurred: RuntimeError
Caught RuntimeError in replica 1 on device 1.
Original Traceback (most recent call last):
File "/home/server/anaconda3/envs/pytorch1.4/lib/python3.7/site-packages/torch/nn/parallel/parallel_apply.py", line 60, in _worker
output = module(*input, **kwargs)
File "/home/server/anaconda3/envs/pytorch1.4/lib/python3.7/site-packages/torch/nn/modules/module.py", line 532, in __call__
result = self.forward(*input, **kwargs)
File "/home/server/disk/lt/androfcg/classifier.py", line 32, in forward
embed,labels= self.s2v(batch_graph, S2VLIB)
File "/home/server/anaconda3/envs/pytorch1.4/lib/python3.7/site-packages/torch/nn/modules/module.py", line 532, in __call__
result = self.forward(*input, **kwargs)
File "/home/server/disk/lt/androfcg/classifier.py", line 89, in forward
h = self.mean_field(node_feat, n2n_sp)
File "/home/server/disk/lt/androfcg/classifier.py", line 99, in mean_field
input_message = self.w_n2l(node_feat[i])
File "/home/server/anaconda3/envs/pytorch1.4/lib/python3.7/site-packages/torch/nn/modules/module.py", line 532, in __call__
result = self.forward(*input, **kwargs)
File "/home/server/anaconda3/envs/pytorch1.4/lib/python3.7/site-packages/torch/nn/modules/linear.py", line 87, in forward
return F.linear(input, self.weight, self.bias)
File "/home/server/anaconda3/envs/pytorch1.4/lib/python3.7/site-packages/torch/nn/functional.py", line 1370, in linear
ret = torch.addmm(bias, input, weight.t())
RuntimeError: Expected cuda::check_device({sparse_, r_, t, dense}) to be true, but got false. (Could this error message be improved? If so, please report an enhancement request to PyTorch.)
File "/home/server/disk/lt/androfcg/main.py", line 28, in loop_dataset
_, loss, acc = classifier(selected_idx,S2VLIB)
File "/home/server/disk/lt/androfcg/main.py", line 77, in <module>
avg_loss = loop_dataset(S2VLIB, classifier, train_idx, optimizer=optimizer)
|
needs reproduction,triaged,module: data parallel
|
low
|
Critical
|
600,174,329 |
godot
|
_draw() function behaving weirdly when resizing window - even WITHOUT randomize()
|
**Godot version:**
3.2.1
**OS/device including version:**
macOS Catalin 10.15.4 / MacBookPro11,1
**Issue description:**
I have a Godot project with standard configuration. Nothing has been changed.
I wrote a simple line of code in func _draw():
draw_circle(Vector2(rand_range(0, 600), rand_range(0, 600)), rand_range(100, 300), Color(0.39, 0.58, 0.93, 1))
The (possible) problem: When I run the project, then maximise and minimise the window, the circle gets rearranged on the screen randomly even though I haven't used the randomise() function.
Check the screen recording for proof:
[Godot_Draw_Anomaly_without_randomise.mov.zip](https://github.com/godotengine/godot/files/4480434/Godot_Draw_Anomaly_without_randomise.mov.zip)
**Steps to reproduce:**
Use the attached Godot project.
**Minimal reproduction project:**
[Apocalypse Now_without_randomise.zip](https://github.com/godotengine/godot/files/4480423/Apocalypse.Now_without_randomise.zip)
|
documentation,topic:gui
|
low
|
Major
|
600,211,590 |
create-react-app
|
LESS is very good, why not consider supporting it?
|
LESS is very good, why not consider supporting it?
|
issue: proposal,needs triage
|
medium
|
Critical
|
600,223,158 |
pytorch
|
state_dict and load_state_dict methods for DataLoader and Sampler to continue training at specific epoch and batch
|
## π Feature
Based on training checkpoint data, allow training to restart at the epoch and **precise** batch, after the last batch trained on when the training checkpoint data was saved.
## Motivation
I'm training (relatively) large sequence to sequence models (> 100M parameters) with a (relatively large) dataset (1M conversations), using limited training hardware (one machine with 4x 1080Ti); one epoch can easily take 12 hours or (much) longer.
There are situations where I want to restart training based on a training checkpoint I saved during the training process that was stopped before, for some reason. In order to not lose many hours of training time, and to continue in exactly the same way, as if I would if the training process had not stopped, I want to be able to continue at the epoch and **precise** batch, after the last batch trained on when the training checkpoint data was saved.
## Pitch
All relevant components in of a PyTorch training process, such as `nn.Module`s, optimizers and schedulers have `state_dict` and `load_state_dict` methods in order to retrieve and load its states, such that training can be restarted with the exactly the same state as it was stopped.
The only exception, as far as I can tell, is for `DataLoader` and `Sampler`. These (base) classes do not have `state_dict` and `load_state_dict` methods.
It would be very consistent and concise, if a PyTorch user could do the following in order to save and load training state:
1. Get the state of your `DataLoader`s, models, optimizers and schedulers and save it together with any other training process variables (e.g. current epoch and batch index) as a training checkpoint.
2. Load your training checkpoint and subsequently load the state of `DataLoader`s, models, optimizers and schedulers
3. Restart your training loop at the loaded epoch index and batch index and continue training
Please note that it is assumed that the `Sampler` state is nested as a part of the `DataLoader` state.
## Alternatives
`DistributedSampler` has the possibility to set the current epoch, such that the random shuffling of samples is deterministic. However, I can't tell the DataLoader from which specific batch to continue.
Edit:
## Additional thoughts
Assume that `k` of `N` batches of an epoch have been trained on, before training was stopped and a training checkpoint was saved. When the state of a `DataLoader` is reloaded in to an `DataLoader` instance `my_data_loader`, to stay consistent, `len(my_data_loader)` should be the total number of batches in an epoch, `N`.
```
my_sampler = SomeSampler(...)
my_data_loader = torch.utils.data.DataLoader(my_dataset, ... sampler=my_sampler ...)
my_data_loader.load_state_dict(checkpoint['data_loader'])
# Should print the number of batches in a normal epoch, N
print(len(my_data_loader))
```
However, when iterating over batches using the first `iter` object after restarting training:
```
for batch in iter(my_data_loader):
...
```
The number of iterations will be `N-k`, for the last `N-k` batches in the epoch from where we stopped training and saved our training checkpoint. In the next epoch `iter(my_data_loader)` will again yield in the normal `N` batches.
cc @SsnL
|
feature,module: dataloader,triaged
|
medium
|
Critical
|
600,258,027 |
vscode
|
Git - Timeline support for folders
|
<!-- β οΈβ οΈ Do Not Delete This! feature_request_template β οΈβ οΈ -->
<!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ -->
<!-- Please search existing issues to avoid creating duplicates. -->
The timeline should support folders as well: the timeline of a file X is equivalent to `gitk -- X`, and the timeline of a folder X should be equivalent to `gitk -- X`.
|
feature-request,git,timeline,timeline-git
|
medium
|
Major
|
600,291,860 |
godot
|
Mono: mscorlib.dll.so not found
|
Hello,
I have a problem with generating mono glue.
With running command:
_bin/godot.linuxbsd.tools.64.mono --generate-mono-glue modules/mono/glue_
I get an error:
> ERROR: Condition "!valid" is true. returned: false
> at: _populate_object_type_interfaces (modules/mono/editor/bindings_generator.cpp:2401)
Here is the log:
```
Config attempting to parse: '/etc/mono/config'. (in domain Mono, info)
Config attempting to parse: '/home/bartlomiej/.mono/config'. (in domain Mono, info)
Image addref mscorlib[0x91c3c30] (asmctx DEFAULT) -> /usr/lib/mono/4.5/mscorlib.dll[0x91c2780]: 2 (in domain Mono, info)
Prepared to set up assembly 'mscorlib' (/usr/lib/mono/4.5/mscorlib.dll) (in domain Mono, info)
AOT: image '/usr/lib/mono/4.5/mscorlib.dll.so' not found: /usr/lib/mono/4.5/mscorlib.dll.so: cannot open shared object file: No such file or directory (in domain Mono, info)
AOT: module (null) is unusable: not compiled for debugging. (in domain Mono, info)
Assembly mscorlib[0x91c3c30] added to domain GodotEngine.RootDomain, ref_count=1 (in domain Mono, info)
Assembly mscorlib[0x91c3c30] added to domain GodotEngine.Domain.Scripts, ref_count=2 (in domain Mono, info)
```
**Mono version:**
Mono JIT compiler version 6.8.0.105 (tarball Tue Feb 4 21:20:20 UTC 2020)
1. In /usr/lib/mono/4.5/ is only mscorlib.dll file.
2. mscorlib.dll.so is in /usr/lib/mono/aot-cache/amd64/ directory.
3. I tried to move the file from amd64 dir to 4.5 dir, but then I got another error:
```
Config attempting to parse: '/etc/mono/config'. (in domain Mono, info)
Config attempting to parse: '/home/bartlomiej/.mono/config'. (in domain Mono, info)
Image addref mscorlib[0x7d0fdf0] (asmctx DEFAULT) -> /usr/lib/mono/4.5/mscorlib.dll[0x7d0e940]: 2 (in domain Mono, info)
Prepared to set up assembly 'mscorlib' (/usr/lib/mono/4.5/mscorlib.dll) (in domain Mono, info)
AOT: module /usr/lib/mono/4.5/mscorlib.dll.so is unusable: not compiled for debugging. (in domain Mono, info)
Assembly mscorlib[0x7d0fdf0] added to domain GodotEngine.RootDomain, ref_count=1 (in domain Mono, info)
Assembly mscorlib[0x7d0fdf0] added to domain GodotEngine.Domain.Scripts, ref_count=2 (in domain Mono, info)
```
I thought it was because of 'garbage' after previous Mono version.
I totally removed Mono (apt purge) and removed directories /usr/lib/mono & /etc/lib/mono.
Then installed Mono again using https://www.mono-project.com/download/stable/
After couple hours I have no idea what else can I do to fix it.
Does anyone know?
|
topic:buildsystem,topic:dotnet
|
low
|
Critical
|
600,352,453 |
flutter
|
Remote host closed connection during handshake
|
This exception is raised when I'm trying to run `flutter build apk` and it is raised when the command line is trying to access `https://storage.googleapis.com` for some files.
**Things I have tried :-**
- Setup the chinese mirror to see if that resolves the issue but the command line still tries to access `https://storage.googleapis.com` and thus fails.
- Used a VPN and that results in a successful build.
- Tried accessing the link with browser which is also successful.
- Ran
`curl -G https://storage.googleapis.com/download.flutter.io/io/flutter/arm64_v8a_release/1.0.0-
beb8a7ec48f6b980a778d19eeda613635c3897c9/arm64_v8a_release-1.0.0-
beb8a7ec48f6b980a778d19eeda613635c3897c9.pom`
*for which I got the response:*
`curl: (35) schannel: failed to receive handshake, SSL/TLS connection failed`
I should mention that I'm from Bangladesh and it is in my knowledge that somewhere along the chain some kind of misconfiguration is messing with access to `https://storage.googleapis.com`. However I can definitely access `https://storage.googleapis.com` with my browser **and** download the files as well.
e.g :-
( There are multiple lines of the same format. A link followed by issue title. )
```bash
> Could not GET 'https://storage.googleapis.com/download.flutter.io/io/flutter/arm64_v8a_release/1.0.0-beb8a7ec48f6b980a778d19eeda613635c3897c9/arm64_v8a_release-1.0.0-beb8a7ec48f6b980a778d19eeda613635c3897c9.pom'.
> Remote host closed connection during handshake
```
Output for `flutter doctor -v` :-
```
[β] Flutter (Channel dev, v1.18.0-dev.5.0, on Microsoft Windows [Version 10.0.18362.720], locale en-US)
β’ Flutter version 1.18.0-dev.5.0 at G:\flutter
β’ Framework revision 7f56b53de4 (3 days ago), 2020-04-12 12:00:01 -0400
β’ Engine revision beb8a7ec48
β’ Dart version 2.8.0 (build 2.8.0-dev.20.0 89b0f67261)
[β] Android toolchain - develop for Android devices (Android SDK version 29.0.3)
β’ Android SDK at C:\Users\Mushfiqur Rahman\AppData\Local\Android\sdk
β’ Platform android-29, build-tools 29.0.3
β’ Java binary at: G:\Android\Android Studio\jre\bin\java
β’ Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b04)
β’ All Android licenses accepted.
[β] Chrome - develop for the web
β’ Chrome at C:\Program Files (x86)\Google\Chrome\Application\chrome.exe
[β] Android Studio (version 3.6)
β’ Android Studio at G:\Android\Android Studio
β’ Flutter plugin version 45.0.1
β’ Dart plugin version 192.7761
β’ Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b04)
[β] VS Code
β’ VS Code at C:\Users\Mushfiqur Rahman\AppData\Local\Programs\Microsoft VS Code
β’ Flutter extension version 3.9.1
[β] Connected device (3 available)
β’ Redmi Note 5 Pro β’ 192.168.1.161:5555 β’ android-arm64 β’ Android 9 (API 28)
β’ Chrome β’ chrome β’ web-javascript β’ Google Chrome 80.0.3987.163
β’ Web Server β’ web-server β’ web-javascript β’ Flutter Tools
β’ No issues found!
```
|
c: crash,tool,t: gradle,P2,team-tool,triaged-tool
|
low
|
Critical
|
600,399,107 |
youtube-dl
|
How to force use of libfdk_aac
|
Hello,
I miss an option to specify that ffmpeg uses libfdk_aac to encode the aac audio output. When using ffprobe, it says, that audio files are encoded with Lavf58.29.100. I wish to use libfdk instead.
|
question
|
low
|
Minor
|
600,438,737 |
godot
|
No notification for virtual keyboard hide
|
**Godot version:**
3.2.1
**OS/device including version:**
Android 10
**Issue description:**
There is a notification in the MainLoop for
NOTIFICATION_WM_GO_BACK_REQUEST:
and
NOTIFICATION_WM_QUIT_REQUEST:
These notifications try to catch the use of the BACK button. However, when the Virtually Keyboard is open, Godot is not catching the BACK button being pressed.
It looks like the BACK button changes its state when the keyboard is open. Even the icon for the BACK button changes to a down arrow (v). When the virtual keyboard is open, the back button simply hides the keyboard. After the keyboard in hid, the BACK button returns to normal BACK button.
|
enhancement,topic:porting
|
low
|
Minor
|
600,441,137 |
kubernetes
|
idea: More memory efficient watch cache
|
The current watch cache requires apiserver hold at least every item in a collection in memory (otherwise it cannot serve lists from the cache), and more (a history window). This is a large amount of memory consumed.
There's an alternative design that IIRC wasn't possible with etcd2 but should now be possible: catch-up watches.
Instead of serving a list from the cache,
* we'd serve it directly from etcd if it is paginated (which we already do), since paginated requests are relatively cheap.
* But unpaginated list requests will have a max frequency, e.g. 1 / second. All requests for the same list get held for either that amount of time, or until an in-flight etcd list query finishes. Then we serve the same data to all requesting clients. (To make this memory efficient, we may have to do a series of paginated requests against etcd, and stream the results to clients.) This greatly penalizes unpaginated lists, and that's OK IMO.
We'd retain the part of the watch cache that multiplexes a single watch to many watchers. We keep all these watchers at exactly the same revision; as a change comes in, we broadcast it to all watchers.
Now, for a new watch request, we have a problem-- the request might be for revision X, when all the existing watchers are on revision Y.
* If X > Y, add the watcher, and just skip events until the existing watchers catch up.
* If X < Y, add the watcher and begin queueing (not sending) events; do a query from etcd between revisions X and Y (e.g., this could be a watch that we terminate early!). If that's successful, send those to the watcher, then the queued events (if any), then the watcher is caught up.
This is inefficient if there's many revisions that need to be processed for every new watcher. We can help this by keeping a small cache of revisions, so that we have to do fewer and smaller revision queries from etcd (this cache can be arbitrarily small, unlike the cache for supporting LISTs). Alternatively, we could batch these as suggested for lists above.
Here's some challenges with this:
* boundary conditions: lots of opportunity to have an off-by-one error when joining watchers or batching catch-up watch requests. Exhaustive testing can fix this.
* filters: lists from etcd and catch-up watch requests could well end up throwing away much of the events for not matching a filter. This is inefficient and would be worse than the existing design for these queries (the existing design is already pretty bad--aside from targeted queries which have been optimized). The only real (IMO) solution for this problem is to push the selection behavior into the storage layer, but that's super hard.
TL;DR: Our existing cache is about locally reproducing the watch behavior. This proposal is about changing the theoretical nature of this, so that instead we think of it in terms of joining up requests that can share work. It's no longer primarily a cache, it's a smart [singleflight](https://godoc.org/golang.org/x/sync/singleflight).
There's a memory/cpu tradeoff here, at least as long as apiserver has to do the filtering. So, I'm not claiming we should do this immediately, I just want to document the approach. This would let apiserver scale to bigger cluster sizes (where not everything fits in RAM). Which is another way of saying it'd permit some amount of horizontal scaling (add more machines) instead of vertical scaling (add more RAM).
/sig api-machinery
/priority awaiting-more-evidence
|
sig/scalability,priority/awaiting-more-evidence,sig/api-machinery,kind/feature,lifecycle/frozen
|
medium
|
Critical
|
600,475,031 |
youtube-dl
|
ymca360.org site request
|
## Checklist
- [X] I'm reporting a new site support request
- [X] I've verified that I'm running youtube-dl version **2020.03.24**
- [X] I've checked that all provided URLs are alive and playable in a browser
- [X] I've checked that none of provided URLs violate any copyrights
- [X] I've searched the bugtracker for similar site support requests including closed ones
## Example URLs
- Single video: https://ymca360.org/on-demand#/category/22/videos/94
- Single video: https://ymca360.org/on-demand#/category/85/videos/102
## Description
From their FAQ:
"YMCA 360 is an on-demand video platform for our Y community. Weβre bringing you group exercise classes, youth sports classes, wellbeing classes and more to serve you wherever you are. Whether you are at home or on the road, take the Y with you with your favorite classes, instructors and more."
No credentials are required to view these videos.
|
site-support-request
|
low
|
Critical
|
600,482,903 |
flutter
|
onPanStart and onPanEnd doesn't work when there is a PageView widget inside GestureDetector
|
```dart
class Demo extends StatelessWidget {
@override
Widget build(BuildContext context) {
return Scaffold(
appBar: AppBar(title: Text('demo'),),
body: GestureDetector(
onPanCancel: () {
print('pan cancel');
},
onPanDown: (_) {
print('pan down');
},
onPanUpdate: (_) {
print('pan update'); // won't trigger
},
onPanStart: (_) {
print('pan start'); // won't trigger
},
onPanEnd: (_) {
print('pan end'); // won't trigger
},
child: PageView.builder(
itemBuilder: (ctx, index) {
return Container(
height: 100,
color: Colors.blue,
child: Text('$index')
);
},
),
),
);
}
}
```
I want to listen to `PageView`'s `onPanStart` and `onPanEnd` event, but it doesn't work. The code above only triggered `onPanDown` and `onPanCancel`, other event won't fire.
How can I add listener to these events?
|
framework,f: scrolling,f: gestures,has reproducible steps,P2,found in release: 3.7,found in release: 3.10,team-framework,triaged-framework
|
low
|
Major
|
600,484,567 |
go
|
cmd/go/internal/auth: readNetrc: detect exposed .netrc files
|
It is a common practice for security-conscious code to return an error when a file holding secret material is not stored safely.
For example, you may have already encountered an ssh error saying a user's private key has unsafe mode. Similarly, the python netrc library throws an exception when file permissions aren't sufficiently narrow.
Go's internal `readNetrc` does not implement such a check as of `1.14.1`.
|
Security,NeedsDecision,FeatureRequest
|
low
|
Critical
|
600,489,940 |
flutter
|
Do not run CI test_smoke_test when shard name is invalid, fail faster
|
Sometimes (often) I mess up the shard name when I'm running CI tests locally, but it doesn't tell me the shard name is invalid until after ~45 seconds of smoketests. Check the shard name and error out _before_ running the smoketests.
```
$ SHARD=add2app_test dart bots/test.dart
β11:01:02β STARTING ANALYSIS
ββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββ
Running smoketests...
β11:01:02β RUNNING: cd automated_tests; ../../bin/flutter test test_smoke_test/pass_test.dart
β11:01:12β ELAPSED TIME: 9.308s for ../../bin/flutter test test_smoke_test/pass_test.dart in automated_tests
β11:01:12β RUNNING: cd automated_tests; ../../bin/flutter test test_smoke_test/fail_test.dart
β11:01:15β ELAPSED TIME: 3.281s for ../../bin/flutter test test_smoke_test/fail_test.dart in automated_tests
β11:01:15β RUNNING: cd automated_tests; ../../bin/flutter test test_smoke_test/timeout_pass_test.dart
β11:01:20β ELAPSED TIME: 5.515s for ../../bin/flutter test test_smoke_test/timeout_pass_test.dart in automated_tests
β11:01:20β RUNNING: cd automated_tests; ../../bin/flutter test test_smoke_test/timeout_fail_test.dart
β11:01:27β ELAPSED TIME: 6.346s for ../../bin/flutter test test_smoke_test/timeout_fail_test.dart in automated_tests
β11:01:27β RUNNING: cd automated_tests; ../../bin/flutter test test_smoke_test/pending_timer_fail_test.dart
β11:01:30β ELAPSED TIME: 3.442s for ../../bin/flutter test test_smoke_test/pending_timer_fail_test.dart in automated_tests
β11:01:30β RUNNING: cd automated_tests; ../../bin/flutter test test_smoke_test/crash1_test.dart
β11:01:30β RUNNING: cd automated_tests; ../../bin/flutter test test_smoke_test/crash2_test.dart
β11:01:30β RUNNING: cd automated_tests; ../../bin/flutter test test_smoke_test/syntax_error_test.broken_dart
β11:01:30β RUNNING: cd automated_tests; ../../bin/flutter test test_smoke_test/missing_import_test.broken_dart
β11:01:30β RUNNING: cd automated_tests; ../../bin/flutter test test_smoke_test/disallow_error_reporter_modification_test.dart
β11:01:30β RUNNING: cd ../packages/flutter_driver; ../../bin/flutter drive --use-existing-app -t test_driver/failure.dart
β11:01:34β ELAPSED TIME: 3.903s for ../../bin/flutter test test_smoke_test/crash1_test.dart in automated_tests
β11:01:34β ELAPSED TIME: 4.005s for ../../bin/flutter test test_smoke_test/syntax_error_test.broken_dart in automated_tests
β11:01:36β ELAPSED TIME: 5.811s for ../../bin/flutter test test_smoke_test/disallow_error_reporter_modification_test.dart in automated_tests
β11:01:39β ELAPSED TIME: 8.577s for ../../bin/flutter drive --use-existing-app -t test_driver/failure.dart in ../packages/flutter_driver
β11:01:41β ELAPSED TIME: 11.043s for ../../bin/flutter test test_smoke_test/missing_import_test.broken_dart in automated_tests
β11:01:42β ELAPSED TIME: 12.127s for ../../bin/flutter test test_smoke_test/crash2_test.dart in automated_tests
ββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββ
Invalid shard: add2app_test
The available shards are: add_to_app_tests, add_to_app_life_cycle_tests, build_tests, framework_coverage, framework_tests, hostonly_devicelab_tests, tool_coverage, tool_tests, web_tests, web_integration_tests
```
|
a: tests,team,framework,P2,team-framework,triaged-framework
|
low
|
Critical
|
600,502,466 |
go
|
cmd/go/internal/list: Wildcard expansion inside `testdata` does not work
|
<!--
Please answer these questions before submitting your issue. Thanks!
For questions please use one of our forums: https://github.com/golang/go/wiki/Questions
-->
### What version of Go are you using (`go version`)?
<pre>
$ go version
go version go1.14 linux/amd64
</pre>
### Does this issue reproduce with the latest release?
Yes
### What operating system and processor architecture are you using (`go env`)?
<details><summary><code>go env</code> Output</summary><br><pre>
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/tbe/.cache/go-build"
GOENV="/home/tbe/.config/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/home/tbe/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/x86_64-pc-linux-gnu/lib/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/x86_64-pc-linux-gnu/lib/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
AR="ar"
CC="x86_64-pc-linux-gnu-cc"
CXX="x86_64-pc-linux-gnu-c++"
CGO_ENABLED="1"
GOMOD="/home/tbe/repos/go/packagesTest/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="x86_64-pc-linux-gnu-pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build133136046=/tmp/go-build -gno-record-gcc-switches"
</pre></details>
### What did you do?
```
$ go list k8s.io/gengo...
k8s.io/gengo/args
k8s.io/gengo/examples/deepcopy-gen
k8s.io/gengo/examples/deepcopy-gen/generators
k8s.io/gengo/examples/deepcopy-gen/output_tests
[...]
$ go list k8s.io/gengo/testdata/a
k8s.io/gengo/testdata/a
$ go list k8s.io/gengo/testdata/a...
go: warning: "k8s.io/gengo/testdata/a..." matched no packages
$ go list k8s.io/gengo/testdata/a/b
k8s.io/gengo/testdata/a/b
```
### What did you expect to see?
```
$ go list k8s.io/gengo/testdata/a...
k8s.io/gengo/testdata/a
k8s.io/gengo/testdata/a/b
```
### What did you see instead?
see above
While it is a wanted behavior, that `testdata` is excluded from wildcard lists, i't seems rather counter-intuitive, that wildcard expansion _inside_ `testdata` does not work.
|
NeedsInvestigation,GoCommand
|
low
|
Critical
|
600,537,991 |
react
|
Bug: window as new portal will break event delegation
|
<!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
React version: any?
## Steps To Reproduce
1. Button attach to a window portal with window.open
2. Event not triggering
<!--
Your bug will get fixed much faster if we can run your code and it doesn't
have dependencies other than React. Issues without reproduction steps or
code examples may be immediately closed as not actionable.
-->
Link to code example:
```javascript
const { useState, useEffect } = React;
function WindowPortal({ children }) {
const [container, setContainer] = useState(document.createElement('div'));
useEffect(() => {
const newWindow = window.open('', '', 'width=600,height=400,left=200,top=200');
newWindow.document.body.appendChild(container);
});
return ReactDOM.createPortal(children, container);
}
function App() {
const [value, setValue] = useState('unclicked');
const handleClick = () => setValue('clicked');
return (
<div>
<div>Portal Test</div>
<WindowPortal>
<button onClick={handleClick}>{value}</button>
</WindowPortal>
</div>
);
}
ReactDOM.render(
React.createElement(App),
document.getElementById('root')
);
```
<!--
Please provide a CodeSandbox (https://codesandbox.io/s/new), a link to a
repository on GitHub, or provide a minimal code example that reproduces the
problem. You may provide a screenshot of the application if you think it is
relevant to your bug report. Here are some tips for providing a minimal
example: https://stackoverflow.com/help/mcve.
-->
Any event in the new window will not be triggered since all events are bind to the original window. I think react can support a new mode for using native event binding rather than event delegation if it makes sense. [Preact](https://github.com/preactjs/preact) actually uses native browser event and don't use react event delegation system.
## The current behavior
Event not trigger for components in new window
## The expected behavior
Event will trigger
|
Type: Discussion
|
low
|
Critical
|
600,566,166 |
terminal
|
Media and other keys autoscroll the terminal
|
# Description
Keys that aren't meant to insert characters seem to jump the terminal to the bottom where input is being awaited. This includes media buttons.
# Steps to reproduce
Open any terminal tab (tested with both Ubuntu and Powershell) and run anything to fill up the screen (e.g. run `ls` 5 times). Scroll up until the text input area is off the page.
Press any non-typing character that isn't a modifier (tested with "calculator" key, play/pause, and volume control keys)
# Expected Behavior
These keys should have no effect on terminal
# Actual behavior
Terminal scrolls to the bottom of the page where a new line is
In this video I press the mute key or the calculator key, causing the terminal to jump
# Version Info
Windows Terminal
Version: 0.10.781.0
|
Help Wanted,Area-Input,Issue-Bug,Area-TerminalControl,Product-Terminal,Priority-2
|
low
|
Major
|
600,576,123 |
go
|
cmd/compile: allow inlining of open-coded defer calls
|
Inlining happens before SSA conversion, while open-coded defers happen after, thus the open-coded deferred call can never be inlined. It would be nice to fix this.
@danscales:
> It definitely is not trivial, since inlining happens before SSA conversion, whereas there are a bunch of reasons why at least some of the open-coded defer work have to be done during SSA conversion. Among other things, we need to force storing defer args to stack slots and keeping those stacks slots live even though they sometimes appear to be dead (but are actually needed to run the open-coded defers when there is a panic).
@randall77 @aclements
|
Performance,NeedsInvestigation,compiler/runtime
|
low
|
Minor
|
600,580,352 |
godot
|
EditorPlugin edit() is called multiple times when selecting a node
|
Godot 3.2.1
Windows 10 64 bits
I noticed `edit` is called twice, sometimes even 3 times in a row when I select a node my plugin handles. This can have negative impact if heavy lifting is done on in that function.
In my plugin this happens with a custom node type.
Repro:
[EditCalledMultipleTimes.zip](https://github.com/godotengine/godot/files/4483683/EditCalledMultipleTimes.zip)
1) Open main.tscn
2) Click on the `Spatial` node: observe `EDIT` is printed twice.
3) Click on the `Node`: nothing prints as expected
4) Click again on the `Spatial`: observe `EDIT` is printed twice again.
|
bug,topic:editor
|
low
|
Minor
|
600,587,722 |
vue
|
Components slots are not rendered inside svg foreignObject
|
### Version
2.6.11
### Reproduction link
[https://jsfiddle.net/AleksandrasNovikovas/w042x1c8/](https://jsfiddle.net/AleksandrasNovikovas/w042x1c8/)
### Steps to reproduce
Run provided fiddle. There are three svg boxes with foreignObject:
1. contains simple html tags
2. contains simple vue component
3. contains complex (with slot) vue component
### What is expected?
All three boxes should show link and input elements
### What is actually happening?
Third box does not show link and input elements.
---
While inspecting DOM (in chrome or in firefox) you will find that elements of second box and third box are identical.
Problem is their types: (in chome dev console select element and tab properties)
select input element from second box and you will find following list: Object->EventTarget->Node->Element->HTMLElement->HTMLInputElement->input;
select input element from third box and you will find following list: Object->EventTarget->Node->Element->SVGElement->input;
<!-- generated by vue-issues. DO NOT REMOVE -->
|
bug,has PR
|
medium
|
Minor
|
600,593,023 |
flutter
|
flutter run -d web Uncaught Error: Assertion failed: : _debugCurrentBuildTarget == context is not true
|
Problem:
1. My app runs just fine on Android.
And it works fine when "flutter run -d chrome" used, but fails in Chrome when "flutter run -d web"
2. If I simplify it as: MaterialApp(home: Scaffold(body: Center(child: Text("Hi")))) then it works with "flutter run -d web".
I'm really puzzled what is the principal difference between "run -d chrome" and "run -d web"? Why first one works without any problem, and second one does not.
Error in browser console:
```
Uncaught Error: Assertion failed: file:///C:/Programs/flutter/packages/flutter/lib/src/widgets/framework.dart:2611:20
_debugCurrentBuildTarget == context
is not true
at Object.throw_ [as throw] (errors.dart:216)
at Object.assertFailed (errors.dart:26)
at framework.dart:2611
at framework.BuildOwner.new.buildScope (framework.dart:2614)
at RenderObjectToWidgetAdapter.new.attachToRenderTree (binding.dart:1041)
at binding$5.WidgetsFlutterBinding.new.attachRootWidget (binding.dart:921)
at binding.dart:903
at internalCallback (isolate_helper.dart:50)
```
<details>
<summary>Logs</summary>
<!-- Finally, paste the output of running `flutter doctor -v` here. -->
[β] Flutter (Channel dev, v1.18.0-dev.5.0, on Microsoft Windows [Version 10.0.16299.1087], locale en-US)
β’ Flutter version 1.18.0-dev.5.0 at c:\Programs\flutter
β’ Framework revision 7f56b53de4 (3 days ago), 2020-04-12 12:00:01 -0400
β’ Engine revision beb8a7ec48
β’ Dart version 2.8.0 (build 2.8.0-dev.20.0 89b0f67261)
[β] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
β’ Android SDK at C:\Users\sl\AppData\Local\Android\sdk
β’ Platform android-29, build-tools 29.0.2
β’ Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
β’ Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b04)
β’ All Android licenses accepted.
[β] Chrome - develop for the web
β’ Chrome at C:\Program Files (x86)\Google\Chrome\Application\chrome.exe
[!] Android Studio (version 3.6)
β’ Android Studio at C:\Program Files\Android\Android Studio
X Flutter plugin not installed; this adds Flutter specific functionality.
X Dart plugin not installed; this adds Dart specific functionality.
β’ Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b04)
[β] VS Code, 64-bit edition (version 1.44.1)
β’ VS Code at C:\Program Files\Microsoft VS Code
β’ Flutter extension version 3.9.1
[β] Connected device (3 available)
β’ Android SDK built for x86 β’ emulator-5554 β’ android-x86 β’ Android 10 (API 29) (emulator)
β’ Chrome β’ chrome β’ web-javascript β’ Google Chrome 80.0.3987.163
β’ Web Server β’ web-server β’ web-javascript β’ Flutter Tools
! Doctor found issues in 1 category.
</details>
|
c: crash,tool,platform-web,P2,team-web,triaged-web
|
low
|
Critical
|
600,595,914 |
rust
|
Spam in PR checks about skipped builds
|
In some PRs, though not all, we see 7 (!) skipped checks. These are annoying to scroll through.
<img width="759" alt="image" src="https://user-images.githubusercontent.com/5047365/79390205-4bd1e180-7f3d-11ea-8aab-2c0e15845fc1.png">
I don't think this is a blocker, but would be nice to see fixed. It's also concerning that there appears to be some non-determinism (the above output is from #71147, but e.g. #71166 does not have it); IMO making sure we know what the cause of that non-determinism is a blocker, as non-determinism of skipped builds in CI is quite concerning :)
cc @pietroalbini
|
C-enhancement,T-infra,A-github-actions,A-meta
|
low
|
Minor
|
600,603,743 |
PowerToys
|
[FancyZones] 1-pixel gap between adjacent windows
|
# Environment
```
Windows build number: Microsoft Windows [Version 10.0.17763.1158]
PowerToys version: v0.16.1
PowerToy module for which you are reporting the bug (if applicable): FancyZones
```
# Steps to reproduce
Just use templates
# Expected behavior
No gaps between programs
# Actual behavior
1-pixel gap between programs
# Screenshots
|
FancyZones-Layouts,Product-FancyZones
|
high
|
Critical
|
600,636,742 |
angular
|
Extensible Sanitizer
|
# π feature request
### Relevant Package
@angular/core
this line and file are of key interest:
https://github.com/angular/angular/blob/486cade596a57b7c146ae3aa269d69d7d828a6ab/packages/core/src/sanitization/html_sanitizer.ts#L95
### Description
The ability to trust a custom whitelist of HTML tags, attributes, and values with a DOM sanitizer, without bypassing the whole sanitizer.
This would allow preservation of `id`, `style`, data attributes, and other common attributes. These attributes are useful in a variety of use cases for many Angular developers. This issue is a common cause of many GitHub issues, StackOverflow questions, and other indicators that there is a real problem with demand for a secure and flexible solution.
[Related SO 1](https://stackoverflow.com/questions/57400432/angular-how-to-retain-html-id-attribute-when-sanitized)
[Related SO 2](https://stackoverflow.com/questions/39628007/angular2-innerhtml-binding-remove-style-attribute)
[Tutorial on a best practice approach to doing what I am requesting](https://www.intricatecloud.io/2019/10/using-angular-innerhtml-to-display-user-generated-content-without-sacrificing-security/)
this would close a bunch of github issues and resolve many SO questions.
### Describe the solution you'd like
I would like to be able to specify three things to allow keys and values to be sanitized in a SecurityContext.HTML.
This could be implemented as an options argument to DomSanitizer.sanitize, or it could be implemented as a custom SecurityContext, but I will use options object in my description below:
```
trustedFirstParagraph$ = this.translateService
.translate('some-translation-key')
.pipe(map(s => this.domSanitizer.sanitize(SecurityContext.HTML, s, options)));
```
Here, options can be an object with any of three keys:
```
const options = {
trustAttributeKeyExpression: /some-regex-to-trust/,
trustAttributeValueExpression: /some-value-to-trust/,
trustAttribute: (el, key, value): boolean | string[] => {
// arbitrary logic that can return a boolean
// or [string, string] sanitized/transformed [key, value].
}
}
```
`trustAttributeKeyExpression` and `trustAttributeValueExpression` must both match if both are specified. To implement an OR operation, and other more complex algorithms, a developer can use `trustAttribute`.
### Describe alternatives you've considered
1. hiding data inside the class attribute and parsing it
2. using a span or div inside my element which is visually hidden but which I can access through my component dom ref and parse out the value
3. de-DRYing my code and having component-specific content across n components instead of being able to leverage a generic service
|
feature,area: core,core: sanitization,feature: under consideration
|
medium
|
Critical
|
600,640,441 |
go
|
cmd/compile: Eliminate bound checks on access to positive modulo
|
Given something in the form
```go
rem := len(foo) % m
_ = foo[:rem]
```
The compiler currently (1.14) inserts a bound check on `foo[:rem]`, but `0 <= rem <= len(foo)` is guaranteed since `rem` is the modulo of a positive integer.
It would be even nicer if the compiler can figure out the general form `x > 0 β§ r = x % m β 0 β€ r < m`, so that operations like
```go
_ = foo[m]
rem := len(foo) % m
_ = foo[rem]
```
can have the bound check eliminated too.
This sort of expression usually props up when dealing with block-oriented algorithms, such as ciphers:
https://github.com/golang/crypto/blob/0848c9571904fcbcb24543358ca8b5a7dbfde875/chacha20/chacha_generic.go#L213
https://github.com/golang/crypto/blob/0848c9571904fcbcb24543358ca8b5a7dbfde875/poly1305/sum_amd64.go#L42
|
Performance,NeedsInvestigation,compiler/runtime
|
low
|
Major
|
600,676,573 |
TypeScript
|
Type guards doesn't work with iterables for arrays
|
<!-- π¨ STOP π¨ π¦π§π’π£ π¨ πΊπ»πΆπ· π¨
Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Even if you think you've found a *bug*, please read the FAQ first, especially the Common "Bugs" That Aren't Bugs section!
Please help us by doing the following steps before logging an issue:
* Search: https://github.com/Microsoft/TypeScript/search?type=Issues
* Read the FAQ: https://github.com/Microsoft/TypeScript/wiki/FAQ
Please fill in the *entire* template below.
-->
<!--
Please try to reproduce the issue with the latest published version. It may have already been fixed.
For npm: `typescript@next`
This is also the 'Nightly' version in the playground: http://www.typescriptlang.org/play/?ts=Nightly
-->
**TypeScript Version:** 3.7.x-dev.20200410
<!-- Search terms you tried before logging this (so others can find this issue more easily) -->
**Search Terms:**
**Code**
```ts
declare function f(a: any): a is any[];
declare const a: Iterable<number>;
f(a) && a;
```
**Expected behavior:**
Narrowed a's type is number[].
**Actual behavior:**
Narrowed a's type is any[].
**Playground Link:** https://www.typescriptlang.org/play/?ts=3.9.0-dev.20200410&ssl=1&ssc=1&pln=4&pc=11#code/CYUwxgNghgTiAEAzArgOzAFwJYHtVIAooAueKVATwEpSp4sBnMygbQF0BuAKFElgTB4GGMqQCSGEDCgAjCCAA8qZAFsZUgHzcuiIlXgAyA2Q5A
**Related Issues:** #32497 #17002
|
Needs Investigation
|
low
|
Critical
|
600,698,495 |
go
|
proposal: net/http: add `RoundTripperFunc` and `Middleware` for server & client
|
Now, in `net/http`, for server side, we have `Handler` & `HandlerFunc`, `HandlerFunc` is the convenient way for user to define new handler, but in client side, we only have `RoundTripper`, so I proposal to add `RoundTripperFunc` to `net/http`.
```go
// RoundTripperFn implement http.RoundTripper for convenient usage.
type RoundTripperFunc func(request *http.Request) (*http.Response, error)
func (fn RoundTripperFunc) RoundTrip(request *http.Request) (*http.Response, error) { return fn(request) }
```
With this new type, we can easily implement `RoundTripper` interface.
In modern web application, middleware pattern is widely used. With `Middleware` we can add more action before/after handler/request call.
For the server side, we can define `Middleware` or similar:
```go
type Middleware interface {
Next(h http.Handler) http.Handler
}
// MiddlewareFn support wrap function with same signature as Middleware.
type MiddlewareFn func(h http.Handler) http.Handler
func (fn MiddlewareFn) Next(h http.Handler) http.Handler { return fn(h) }
// and compose chains of middleware
// ComposeInterceptor compose interceptors to given http.RoundTripper
func ComposeInterceptor(rt http.RoundTripper, interceptors ...Interceptor) http.RoundTripper {
if len(interceptors) == 0 {
return rt
}
return ComposeInterceptor(interceptors[0].Next(rt), interceptors[1:]...)
}
```
For the client side, we define `Interceptor` or similar:
```go
type Interceptor interface {
Next(fn http.RoundTripper) http.RoundTripper
}
// InterceptorFn implement Interceptor for convenient usage.
type InterceptorFn func(rt http.RoundTripper) http.RoundTripper
func (fn InterceptorFn) Next(rt http.RoundTripper) http.RoundTripper { return fn(rt) }
// and a function compose chains of interceptor
func ComposeInterceptor(rt http.RoundTripper, interceptors ...Interceptor) http.RoundTripper {
if len(interceptors) == 0 {
return rt
}
return ComposeInterceptor(interceptors[0].Next(rt), interceptors[1:]...)
}
```
All the above are not necessary, but can reduce and simplify user's boilerplate code.
Please consider this proposal.
The original code is [middleware](https://github.com/go-board/x-go/blob/master/xnet/xhttp/middleware.go#L18), [interceptor & RoundTripperFunc](https://github.com/go-board/x-go/blob/master/xnet/xhttp/xrequest/interceptor.go#L17)
|
Proposal
|
low
|
Critical
|
600,705,452 |
pytorch
|
Reduction for `torch.int8` is super slow on CUDA
|
## π Bug
Reduction for `torch.int8` is super slow on CUDA
## To Reproduce
```python
import torch
print(torch.__version__)
print()
for i in range(1000):
torch.arange(10000, device='cuda')
def benchmark(dtype, i):
numel = 2 ** i
a = torch.zeros(numel, device='cuda', dtype=dtype)
torch.cuda.synchronize()
%timeit a.sum(); torch.cuda.synchronize()
for dtype in [torch.int8, torch.half, torch.float, torch.double]:
print(dtype)
for i in range(18, 30):
benchmark(dtype, i)
print()
```
gets
```
1.6.0a0+2f5b523
torch.int8
24.1 Β΅s Β± 76.7 ns per loop (mean Β± std. dev. of 7 runs, 10000 loops each)
25 Β΅s Β± 367 ns per loop (mean Β± std. dev. of 7 runs, 10000 loops each)
52.8 Β΅s Β± 67.1 ns per loop (mean Β± std. dev. of 7 runs, 10000 loops each)
88.4 Β΅s Β± 183 ns per loop (mean Β± std. dev. of 7 runs, 10000 loops each)
171 Β΅s Β± 11.5 Β΅s per loop (mean Β± std. dev. of 7 runs, 10000 loops each)
296 Β΅s Β± 6.06 Β΅s per loop (mean Β± std. dev. of 7 runs, 1000 loops each)
568 Β΅s Β± 1.09 Β΅s per loop (mean Β± std. dev. of 7 runs, 1000 loops each)
1.11 ms Β± 752 ns per loop (mean Β± std. dev. of 7 runs, 1000 loops each)
2.22 ms Β± 22.1 Β΅s per loop (mean Β± std. dev. of 7 runs, 100 loops each)
4.55 ms Β± 192 Β΅s per loop (mean Β± std. dev. of 7 runs, 100 loops each)
9.34 ms Β± 1.39 ms per loop (mean Β± std. dev. of 7 runs, 100 loops each)
20.4 ms Β± 200 Β΅s per loop (mean Β± std. dev. of 7 runs, 10 loops each)
torch.float16
16.7 Β΅s Β± 336 ns per loop (mean Β± std. dev. of 7 runs, 100000 loops each)
16.7 Β΅s Β± 30.4 ns per loop (mean Β± std. dev. of 7 runs, 100000 loops each)
17 Β΅s Β± 48.2 ns per loop (mean Β± std. dev. of 7 runs, 100000 loops each)
20.1 Β΅s Β± 193 ns per loop (mean Β± std. dev. of 7 runs, 10000 loops each)
34.2 Β΅s Β± 49.2 ns per loop (mean Β± std. dev. of 7 runs, 10000 loops each)
50.6 Β΅s Β± 122 ns per loop (mean Β± std. dev. of 7 runs, 10000 loops each)
81.9 Β΅s Β± 784 ns per loop (mean Β± std. dev. of 7 runs, 10000 loops each)
151 Β΅s Β± 3.29 Β΅s per loop (mean Β± std. dev. of 7 runs, 10000 loops each)
277 Β΅s Β± 9.18 Β΅s per loop (mean Β± std. dev. of 7 runs, 1000 loops each)
537 Β΅s Β± 17.7 Β΅s per loop (mean Β± std. dev. of 7 runs, 1000 loops each)
1.13 ms Β± 35.4 Β΅s per loop (mean Β± std. dev. of 7 runs, 1000 loops each)
2.11 ms Β± 45.1 Β΅s per loop (mean Β± std. dev. of 7 runs, 100 loops each)
torch.float32
17.5 Β΅s Β± 721 ns per loop (mean Β± std. dev. of 7 runs, 100000 loops each)
17.5 Β΅s Β± 893 ns per loop (mean Β± std. dev. of 7 runs, 100000 loops each)
20.6 Β΅s Β± 523 ns per loop (mean Β± std. dev. of 7 runs, 10000 loops each)
36.9 Β΅s Β± 4.17 Β΅s per loop (mean Β± std. dev. of 7 runs, 10000 loops each)
47.7 Β΅s Β± 797 ns per loop (mean Β± std. dev. of 7 runs, 10000 loops each)
75.6 Β΅s Β± 381 ns per loop (mean Β± std. dev. of 7 runs, 10000 loops each)
148 Β΅s Β± 7.8 Β΅s per loop (mean Β± std. dev. of 7 runs, 10000 loops each)
262 Β΅s Β± 16.4 Β΅s per loop (mean Β± std. dev. of 7 runs, 1000 loops each)
496 Β΅s Β± 13.6 Β΅s per loop (mean Β± std. dev. of 7 runs, 1000 loops each)
1.1 ms Β± 29.2 Β΅s per loop (mean Β± std. dev. of 7 runs, 1000 loops each)
2.23 ms Β± 56.6 Β΅s per loop (mean Β± std. dev. of 7 runs, 100 loops each)
4.05 ms Β± 196 Β΅s per loop (mean Β± std. dev. of 7 runs, 100 loops each)
torch.float64
23.5 Β΅s Β± 331 ns per loop (mean Β± std. dev. of 7 runs, 10000 loops each)
23.5 Β΅s Β± 1.19 Β΅s per loop (mean Β± std. dev. of 7 runs, 10000 loops each)
38.3 Β΅s Β± 1.7 Β΅s per loop (mean Β± std. dev. of 7 runs, 10000 loops each)
57.4 Β΅s Β± 1.92 Β΅s per loop (mean Β± std. dev. of 7 runs, 10000 loops each)
88.2 Β΅s Β± 2.57 Β΅s per loop (mean Β± std. dev. of 7 runs, 10000 loops each)
151 Β΅s Β± 3.16 Β΅s per loop (mean Β± std. dev. of 7 runs, 10000 loops each)
281 Β΅s Β± 6.73 Β΅s per loop (mean Β± std. dev. of 7 runs, 1000 loops each)
507 Β΅s Β± 21.3 Β΅s per loop (mean Β± std. dev. of 7 runs, 1000 loops each)
1.06 ms Β± 30 Β΅s per loop (mean Β± std. dev. of 7 runs, 1000 loops each)
2.03 ms Β± 119 Β΅s per loop (mean Β± std. dev. of 7 runs, 100 loops each)
3.77 ms Β± 31.8 Β΅s per loop (mean Β± std. dev. of 7 runs, 100 loops each)
7.59 ms Β± 51.8 Β΅s per loop (mean Β± std. dev. of 7 runs, 100 loops each)
```
## Environment
```
PyTorch version: 1.6.0a0+2f5b523
Is debug build: No
CUDA used to build PyTorch: 10.2
OS: Arch Linux
GCC version: (Arch Linux 9.3.0-1) 9.3.0
CMake version: version 3.17.1
Python version: 3.8
Is CUDA available: Yes
CUDA runtime version: 10.2.89
GPU models and configuration: GPU 0: GeForce RTX 2080 Ti
Nvidia driver version: 440.82
cuDNN version: /usr/lib/libcudnn.so.7.6.5
Versions of relevant libraries:
[pip3] numpy==1.18.1
[pip3] torch==1.6.0a0+e5746ee
[pip3] torchani==1.3.dev26+g5b3d892.d20200321
[pip3] torchvision==0.6.0+cu101
[conda] Could not collect
```
cc @ngimel @VitalyFedyunin
|
module: performance,module: cuda,triaged,module: TensorIterator
|
low
|
Critical
|
600,706,627 |
flutter
|
Pub get failed - Gradle failed with no route to host
|
I use Android Studio 3.6 on MacosX to develop flutter. My flutter is `Flutter 1.15.17 β’ channel beta β’ https://github.com/flutter/flutter.git`.
When I execute `flutter run`, I got these errors:
```
`Launching lib/main.dart on A0001 in debug mode...
Running Gradle task 'assembleDebug'...
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':app:compileDebugKotlin'.
> Could not resolve all artifacts for configuration ':app:debugCompileClasspath'.
> Could not download armeabi_v7a_debug.jar (io.flutter:armeabi_v7a_debug:1.0.0-5aff3119480996ca014ec0f8d26d74db617b5852)
> Could not get resource 'https://storage.googleapis.com/download.flutter.io/io/flutter/armeabi_v7a_debug/1.0.0-5aff3119480996ca014ec0f8d26d74db617b5852/armeabi_v7a_debug-1.0.0-5aff3119480996ca014ec0f8d26d74db617b5852.jar'.
> Could not GET 'https://storage.googleapis.com/download.flutter.io/io/flutter/armeabi_v7a_debug/1.0.0-5aff3119480996ca014ec0f8d26d74db617b5852/armeabi_v7a_debug-1.0.0-5aff3119480996ca014ec0f8d26d74db617b5852.jar'.
> Connect to storage.googleapis.com:443 [storage.googleapis.com/216.58.200.48, storage.googleapis.com/2404:6800:4008:801:0:0:0:2010] failed: No route to host (connect failed)
> Could not download x86_debug.jar (io.flutter:x86_debug:1.0.0-5aff3119480996ca014ec0f8d26d74db617b5852)
> Could not get resource 'https://storage.googleapis.com/download.flutter.io/io/flutter/x86_debug/1.0.0-5aff3119480996ca014ec0f8d26d74db617b5852/x86_debug-1.0.0-5aff3119480996ca014ec0f8d26d74db617b5852.jar'.
> Could not GET 'https://storage.googleapis.com/download.flutter.io/io/flutter/x86_debug/1.0.0-5aff3119480996ca014ec0f8d26d74db617b5852/x86_debug-1.0.0-5aff3119480996ca014ec0f8d26d74db617b5852.jar'.
> Connect to storage.googleapis.com:443 [storage.googleapis.com/216.58.200.48, storage.googleapis.com/2404:6800:4008:801:0:0:0:2010] failed: No route to host (connect failed)
> Could not download x86_64_debug.jar (io.flutter:x86_64_debug:1.0.0-5aff3119480996ca014ec0f8d26d74db617b5852)
> Could not get resource 'https://storage.googleapis.com/download.flutter.io/io/flutter/x86_64_debug/1.0.0-5aff3119480996ca014ec0f8d26d74db617b5852/x86_64_debug-1.0.0-5aff3119480996ca014ec0f8d26d74db617b5852.jar'.
> Could not GET 'https://storage.googleapis.com/download.flutter.io/io/flutter/x86_64_debug/1.0.0-5aff3119480996ca014ec0f8d26d74db617b5852/x86_64_debug-1.0.0-5aff3119480996ca014ec0f8d26d74db617b5852.jar'.
> Connect to storage.googleapis.com:443 [storage.googleapis.com/216.58.200.48, storage.googleapis.com/2404:6800:4008:801:0:0:0:2010] failed: No route to host (connect failed)
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.
* Get more help at https://help.gradle.org
BUILD FAILED in 1m 59s
Running Gradle task 'assembleDebug'...
Running Gradle task 'assembleDebug'... Done 121.6s (!)
Exception: Gradle task assembleDebug failed with exit code 1`
```
It seems that the Gradle could not download the .jar file. But when copy the url into browser, it can be downloaded without any difficulty.
I'm not sure how to solve this problem. Who can give me some advice? Thanks.
|
c: regression,tool,t: gradle,found in release: 1.17,P2,team-tool,triaged-tool
|
low
|
Critical
|
600,731,981 |
flutter
|
Exhausted heap space, trying to allocate 6442385440 bytes.
|
flutter has exited unexpectedly.
|
c: crash,platform-android,tool,c: performance,platform-windows,t: gradle,perf: memory,P2,team-android,triaged-android
|
low
|
Major
|
600,740,151 |
pytorch
|
variable name N_ conflicts with an internationalization macro in glib
|
## Issue description
Several libraries (incliding glib and wxWidgets) use `N_` as a macro related to internationalization for gettext.
Libtorch unfortunately uses this as a variable name here:
https://github.com/pytorch/pytorch/blob/master/aten/src/ATen/core/function_schema.h#L34
The macro definition from wxwidgets or glib replaces `N_` causing libtorch to fail to compile.
It would be great if libtorch could use a more descriptive name here, but mostly it should avoid using names that conflict with this set of macros:
https://developer.gnome.org/glib/stable/glib-I18N.html
cc @suo @malfet
|
oncall: jit,module: build,triaged
|
low
|
Minor
|
600,744,325 |
flutter
|
"flutter/packages/flutter_tools/gradle/flutter.gradle" hard-coded `:app` host module
|
Hello! I was trying to add Flutter to my existing Android workspace and ran into two problems. One of which sure seems like a bug.
I was following the guide here: βͺhttps://flutter.dev/docs/development/add-to-app/android/project-setup
I couldn't get the "Using Android Studio" steps to work after several clean attempts. I tried the "Manual integration" and "Option B - Depend on the moduleβs source code" steps instead.
1. Follow the instructions
2. Carefully ensure that one follows the "Tip"
`Tip: By default, the host app provides the :app Gradle project. To change the name of this project, set flutter.hostAppProjectName in the Flutter moduleβs gradle.properties file. Finally, include this project in the host appβs settings.gradle file mentioned below.`
3. Android Studio cannot sync with Gradle due to this error message in "Logs" below.
## WORK-AROUND
Edit `flutter/packages/flutter_tools/gradle/flutter.gradle` to replace references to `:app` with the existing app modules identifier. Everything works fine!
- My expectation is I shouldn't have to edit 600+ line scripts built in to the Flutter SDK to complete the bootstrap guide π
## Logs
```
FAILURE: Build failed with an exception.
* Where:
Script '/Users/ejohnson/Voodoo/Apps/flutter/packages/flutter_tools/gradle/flutter.gradle' line: 681
* What went wrong:
A problem occurred configuring root project 'TrainingPeaks-Android'.
> A problem occurred configuring project ':flutter'.
> Failed to notify project evaluation listener.
> assert appProject != null
| |
null false
* Try:
Run with --info or --debug option to get more log output. Run with --scan to get full insights.
* Exception is:
org.gradle.api.ProjectConfigurationException: A problem occurred configuring root project 'TrainingPeaks-Android'.
at org.gradle.configuration.project.LifecycleProjectEvaluator.wrapException(LifecycleProjectEvaluator.java:80)
at org.gradle.configuration.project.LifecycleProjectEvaluator.addConfigurationFailure(LifecycleProjectEvaluator.java:73)
at org.gradle.configuration.project.LifecycleProjectEvaluator.access$600(LifecycleProjectEvaluator.java:53)
at org.gradle.configuration.project.LifecycleProjectEvaluator$NotifyAfterEvaluate.run(LifecycleProjectEvaluator.java:199)
at org.gradle.internal.operations.DefaultBuildOperationExecutor$RunnableBuildOperationWorker.execute(DefaultBuildOperationExecutor.java:402)
at org.gradle.internal.operations.DefaultBuildOperationExecutor$RunnableBuildOperationWorker.execute(DefaultBuildOperationExecutor.java:394)
at org.gradle.internal.operations.DefaultBuildOperationExecutor$1.execute(DefaultBuildOperationExecutor.java:165)
at org.gradle.internal.operations.DefaultBuildOperationExecutor.execute(DefaultBuildOperationExecutor.java:250)
at org.gradle.internal.operations.DefaultBuildOperationExecutor.execute(DefaultBuildOperationExecutor.java:158)
at org.gradle.internal.operations.DefaultBuildOperationExecutor.run(DefaultBuildOperationExecutor.java:92)
at org.gradle.internal.operations.DelegatingBuildOperationExecutor.run(DelegatingBuildOperationExecutor.java:31)
at org.gradle.configuration.project.LifecycleProjectEvaluator$EvaluateProject$1.run(LifecycleProjectEvaluator.java:112)
at org.gradle.internal.Factories$1.create(Factories.java:26)
at org.gradle.internal.work.DefaultWorkerLeaseService.withLocks(DefaultWorkerLeaseService.java:189)
at org.gradle.internal.work.StopShieldingWorkerLeaseService.withLocks(StopShieldingWorkerLeaseService.java:40)
at org.gradle.api.internal.project.DefaultProjectStateRegistry$ProjectStateImpl.withProjectLock(DefaultProjectStateRegistry.java:227)
at org.gradle.api.internal.project.DefaultProjectStateRegistry$ProjectStateImpl.withMutableState(DefaultProjectStateRegistry.java:221)
at org.gradle.api.internal.project.DefaultProjectStateRegistry$ProjectStateImpl.withMutableState(DefaultProjectStateRegistry.java:187)
at org.gradle.configuration.project.LifecycleProjectEvaluator$EvaluateProject.run(LifecycleProjectEvaluator.java:96)
at org.gradle.internal.operations.DefaultBuildOperationExecutor$RunnableBuildOperationWorker.execute(DefaultBuildOperationExecutor.java:402)
at org.gradle.internal.operations.DefaultBuildOperationExecutor$RunnableBuildOperationWorker.execute(DefaultBuildOperationExecutor.java:394)
at org.gradle.internal.operations.DefaultBuildOperationExecutor$1.execute(DefaultBuildOperationExecutor.java:165)
at org.gradle.internal.operations.DefaultBuildOperationExecutor.execute(DefaultBuildOperationExecutor.java:250)
at org.gradle.internal.operations.DefaultBuildOperationExecutor.execute(DefaultBuildOperationExecutor.java:158)
at org.gradle.internal.operations.DefaultBuildOperationExecutor.run(DefaultBuildOperationExecutor.java:92)
at org.gradle.internal.operations.DelegatingBuildOperationExecutor.run(DelegatingBuildOperationExecutor.java:31)
at org.gradle.configuration.project.LifecycleProjectEvaluator.evaluate(LifecycleProjectEvaluator.java:68)
at org.gradle.api.internal.project.DefaultProject.evaluate(DefaultProject.java:693)
at org.gradle.api.internal.project.DefaultProject.evaluate(DefaultProject.java:141)
at org.gradle.execution.TaskPathProjectEvaluator.configure(TaskPathProjectEvaluator.java:36)
at org.gradle.execution.TaskPathProjectEvaluator.configureHierarchy(TaskPathProjectEvaluator.java:62)
at org.gradle.configuration.DefaultProjectsPreparer.prepareProjects(DefaultProjectsPreparer.java:55)
at org.gradle.configuration.BuildOperatingFiringProjectsPreparer$ConfigureBuild.run(BuildOperatingFiringProjectsPreparer.java:52)
at org.gradle.internal.operations.DefaultBuildOperationExecutor$RunnableBuildOperationWorker.execute(DefaultBuildOperationExecutor.java:402)
at org.gradle.internal.operations.DefaultBuildOperationExecutor$RunnableBuildOperationWorker.execute(DefaultBuildOperationExecutor.java:394)
at org.gradle.internal.operations.DefaultBuildOperationExecutor$1.execute(DefaultBuildOperationExecutor.java:165)
at org.gradle.internal.operations.DefaultBuildOperationExecutor.execute(DefaultBuildOperationExecutor.java:250)
at org.gradle.internal.operations.DefaultBuildOperationExecutor.execute(DefaultBuildOperationExecutor.java:158)
at org.gradle.internal.operations.DefaultBuildOperationExecutor.run(DefaultBuildOperationExecutor.java:92)
at org.gradle.internal.operations.DelegatingBuildOperationExecutor.run(DelegatingBuildOperationExecutor.java:31)
at org.gradle.configuration.BuildOperatingFiringProjectsPreparer.prepareProjects(BuildOperatingFiringProjectsPreparer.java:40)
at org.gradle.initialization.DefaultGradleLauncher.prepareProjects(DefaultGradleLauncher.java:198)
at org.gradle.initialization.DefaultGradleLauncher.doClassicBuildStages(DefaultGradleLauncher.java:138)
at org.gradle.initialization.DefaultGradleLauncher.doBuildStages(DefaultGradleLauncher.java:126)
at org.gradle.initialization.DefaultGradleLauncher.getConfiguredBuild(DefaultGradleLauncher.java:100)
at org.gradle.internal.invocation.GradleBuildController$2.execute(GradleBuildController.java:70)
at org.gradle.internal.invocation.GradleBuildController$2.execute(GradleBuildController.java:67)
at org.gradle.internal.invocation.GradleBuildController$3.create(GradleBuildController.java:85)
at org.gradle.internal.invocation.GradleBuildController$3.create(GradleBuildController.java:78)
at org.gradle.internal.work.DefaultWorkerLeaseService.withLocks(DefaultWorkerLeaseService.java:189)
at org.gradle.internal.work.StopShieldingWorkerLeaseService.withLocks(StopShieldingWorkerLeaseService.java:40)
at org.gradle.internal.invocation.GradleBuildController.doBuild(GradleBuildController.java:78)
at org.gradle.internal.invocation.GradleBuildController.configure(GradleBuildController.java:67)
at org.gradle.tooling.internal.provider.runner.ClientProvidedPhasedActionRunner.run(ClientProvidedPhasedActionRunner.java:62)
at org.gradle.launcher.exec.ChainingBuildActionRunner.run(ChainingBuildActionRunner.java:35)
at org.gradle.launcher.exec.ChainingBuildActionRunner.run(ChainingBuildActionRunner.java:35)
at org.gradle.launcher.exec.BuildOutcomeReportingBuildActionRunner.run(BuildOutcomeReportingBuildActionRunner.java:63)
at org.gradle.tooling.internal.provider.ValidatingBuildActionRunner.run(ValidatingBuildActionRunner.java:32)
at org.gradle.launcher.exec.BuildCompletionNotifyingBuildActionRunner.run(BuildCompletionNotifyingBuildActionRunner.java:39)
at org.gradle.launcher.exec.RunAsBuildOperationBuildActionRunner$3.call(RunAsBuildOperationBuildActionRunner.java:51)
at org.gradle.launcher.exec.RunAsBuildOperationBuildActionRunner$3.call(RunAsBuildOperationBuildActionRunner.java:45)
at org.gradle.internal.operations.DefaultBuildOperationExecutor$CallableBuildOperationWorker.execute(DefaultBuildOperationExecutor.java:416)
at org.gradle.internal.operations.DefaultBuildOperationExecutor$CallableBuildOperationWorker.execute(DefaultBuildOperationExecutor.java:406)
at org.gradle.internal.operations.DefaultBuildOperationExecutor$1.execute(DefaultBuildOperationExecutor.java:165)
at org.gradle.internal.operations.DefaultBuildOperationExecutor.execute(DefaultBuildOperationExecutor.java:250)
at org.gradle.internal.operations.DefaultBuildOperationExecutor.execute(DefaultBuildOperationExecutor.java:158)
at org.gradle.internal.operations.DefaultBuildOperationExecutor.call(DefaultBuildOperationExecutor.java:102)
at org.gradle.internal.operations.DelegatingBuildOperationExecutor.call(DelegatingBuildOperationExecutor.java:36)
at org.gradle.launcher.exec.RunAsBuildOperationBuildActionRunner.run(RunAsBuildOperationBuildActionRunner.java:45)
at org.gradle.launcher.exec.InProcessBuildActionExecuter$1.transform(InProcessBuildActionExecuter.java:50)
at org.gradle.launcher.exec.InProcessBuildActionExecuter$1.transform(InProcessBuildActionExecuter.java:47)
at org.gradle.composite.internal.DefaultRootBuildState.run(DefaultRootBuildState.java:78)
at org.gradle.launcher.exec.InProcessBuildActionExecuter.execute(InProcessBuildActionExecuter.java:47)
at org.gradle.launcher.exec.InProcessBuildActionExecuter.execute(InProcessBuildActionExecuter.java:31)
at org.gradle.launcher.exec.BuildTreeScopeBuildActionExecuter.execute(BuildTreeScopeBuildActionExecuter.java:42)
at org.gradle.launcher.exec.BuildTreeScopeBuildActionExecuter.execute(BuildTreeScopeBuildActionExecuter.java:28)
at org.gradle.tooling.internal.provider.ContinuousBuildActionExecuter.execute(ContinuousBuildActionExecuter.java:78)
at org.gradle.tooling.internal.provider.ContinuousBuildActionExecuter.execute(ContinuousBuildActionExecuter.java:52)
at org.gradle.tooling.internal.provider.SubscribableBuildActionExecuter.execute(SubscribableBuildActionExecuter.java:59)
at org.gradle.tooling.internal.provider.SubscribableBuildActionExecuter.execute(SubscribableBuildActionExecuter.java:36)
at org.gradle.tooling.internal.provider.SessionScopeBuildActionExecuter.execute(SessionScopeBuildActionExecuter.java:68)
at org.gradle.tooling.internal.provider.SessionScopeBuildActionExecuter.execute(SessionScopeBuildActionExecuter.java:38)
at org.gradle.tooling.internal.provider.GradleThreadBuildActionExecuter.execute(GradleThreadBuildActionExecuter.java:37)
at org.gradle.tooling.internal.provider.GradleThreadBuildActionExecuter.execute(GradleThreadBuildActionExecuter.java:26)
at org.gradle.tooling.internal.provider.ParallelismConfigurationBuildActionExecuter.execute(ParallelismConfigurationBuildActionExecuter.java:43)
at org.gradle.tooling.internal.provider.ParallelismConfigurationBuildActionExecuter.execute(ParallelismConfigurationBuildActionExecuter.java:29)
at org.gradle.tooling.internal.provider.StartParamsValidatingActionExecuter.execute(StartParamsValidatingActionExecuter.java:60)
at org.gradle.tooling.internal.provider.StartParamsValidatingActionExecuter.execute(StartParamsValidatingActionExecuter.java:32)
at org.gradle.tooling.internal.provider.SessionFailureReportingActionExecuter.execute(SessionFailureReportingActionExecuter.java:55)
at org.gradle.tooling.internal.provider.SessionFailureReportingActionExecuter.execute(SessionFailureReportingActionExecuter.java:41)
at org.gradle.tooling.internal.provider.SetupLoggingActionExecuter.execute(SetupLoggingActionExecuter.java:48)
at org.gradle.tooling.internal.provider.SetupLoggingActionExecuter.execute(SetupLoggingActionExecuter.java:32)
at org.gradle.launcher.daemon.server.exec.ExecuteBuild.doBuild(ExecuteBuild.java:68)
at org.gradle.launcher.daemon.server.exec.BuildCommandOnly.execute(BuildCommandOnly.java:37)
at org.gradle.launcher.daemon.server.api.DaemonCommandExecution.proceed(DaemonCommandExecution.java:104)
at org.gradle.launcher.daemon.server.exec.WatchForDisconnection.execute(WatchForDisconnection.java:39)
at org.gradle.launcher.daemon.server.api.DaemonCommandExecution.proceed(DaemonCommandExecution.java:104)
at org.gradle.launcher.daemon.server.exec.ResetDeprecationLogger.execute(ResetDeprecationLogger.java:27)
at org.gradle.launcher.daemon.server.api.DaemonCommandExecution.proceed(DaemonCommandExecution.java:104)
at org.gradle.launcher.daemon.server.exec.RequestStopIfSingleUsedDaemon.execute(RequestStopIfSingleUsedDaemon.java:35)
at org.gradle.launcher.daemon.server.api.DaemonCommandExecution.proceed(DaemonCommandExecution.java:104)
at org.gradle.launcher.daemon.server.exec.ForwardClientInput$2.create(ForwardClientInput.java:78)
at org.gradle.launcher.daemon.server.exec.ForwardClientInput$2.create(ForwardClientInput.java:75)
at org.gradle.util.Swapper.swap(Swapper.java:38)
at org.gradle.launcher.daemon.server.exec.ForwardClientInput.execute(ForwardClientInput.java:75)
at org.gradle.launcher.daemon.server.api.DaemonCommandExecution.proceed(DaemonCommandExecution.java:104)
at org.gradle.launcher.daemon.server.exec.LogAndCheckHealth.execute(LogAndCheckHealth.java:55)
at org.gradle.launcher.daemon.server.api.DaemonCommandExecution.proceed(DaemonCommandExecution.java:104)
at org.gradle.launcher.daemon.server.exec.LogToClient.doBuild(LogToClient.java:63)
at org.gradle.launcher.daemon.server.exec.BuildCommandOnly.execute(BuildCommandOnly.java:37)
at org.gradle.launcher.daemon.server.api.DaemonCommandExecution.proceed(DaemonCommandExecution.java:104)
at org.gradle.launcher.daemon.server.exec.EstablishBuildEnvironment.doBuild(EstablishBuildEnvironment.java:82)
at org.gradle.launcher.daemon.server.exec.BuildCommandOnly.execute(BuildCommandOnly.java:37)
at org.gradle.launcher.daemon.server.api.DaemonCommandExecution.proceed(DaemonCommandExecution.java:104)
at org.gradle.launcher.daemon.server.exec.StartBuildOrRespondWithBusy$1.run(StartBuildOrRespondWithBusy.java:52)
at org.gradle.launcher.daemon.server.DaemonStateCoordinator$1.run(DaemonStateCoordinator.java:297)
at org.gradle.internal.concurrent.ExecutorPolicy$CatchAndRecordFailures.onExecute(ExecutorPolicy.java:64)
at org.gradle.internal.concurrent.ManagedExecutorImpl$1.run(ManagedExecutorImpl.java:48)
at org.gradle.internal.concurrent.ThreadFactoryImpl$ManagedThreadRunnable.run(ThreadFactoryImpl.java:56)
Caused by: org.gradle.api.ProjectConfigurationException: A problem occurred configuring project ':flutter'.
at org.gradle.configuration.project.LifecycleProjectEvaluator.wrapException(LifecycleProjectEvaluator.java:80)
at org.gradle.configuration.project.LifecycleProjectEvaluator.addConfigurationFailure(LifecycleProjectEvaluator.java:73)
at org.gradle.configuration.project.LifecycleProjectEvaluator.access$600(LifecycleProjectEvaluator.java:53)
at org.gradle.configuration.project.LifecycleProjectEvaluator$NotifyAfterEvaluate.run(LifecycleProjectEvaluator.java:199)
at org.gradle.internal.operations.DefaultBuildOperationExecutor$RunnableBuildOperationWorker.execute(DefaultBuildOperationExecutor.java:402)
at org.gradle.internal.operations.DefaultBuildOperationExecutor$RunnableBuildOperationWorker.execute(DefaultBuildOperationExecutor.java:394)
at org.gradle.internal.operations.DefaultBuildOperationExecutor$1.execute(DefaultBuildOperationExecutor.java:165)
at org.gradle.internal.operations.DefaultBuildOperationExecutor.execute(DefaultBuildOperationExecutor.java:250)
at org.gradle.internal.operations.DefaultBuildOperationExecutor.execute(DefaultBuildOperationExecutor.java:158)
at org.gradle.internal.operations.DefaultBuildOperationExecutor.run(DefaultBuildOperationExecutor.java:92)
at org.gradle.internal.operations.DelegatingBuildOperationExecutor.run(DelegatingBuildOperationExecutor.java:31)
at org.gradle.configuration.project.LifecycleProjectEvaluator$EvaluateProject$1.run(LifecycleProjectEvaluator.java:112)
at org.gradle.internal.Factories$1.create(Factories.java:26)
at org.gradle.internal.work.DefaultWorkerLeaseService.withLocks(DefaultWorkerLeaseService.java:189)
at org.gradle.internal.work.StopShieldingWorkerLeaseService.withLocks(StopShieldingWorkerLeaseService.java:40)
at org.gradle.api.internal.project.DefaultProjectStateRegistry$ProjectStateImpl.withProjectLock(DefaultProjectStateRegistry.java:227)
at org.gradle.api.internal.project.DefaultProjectStateRegistry$ProjectStateImpl.access$700(DefaultProjectStateRegistry.java:144)
at org.gradle.api.internal.project.DefaultProjectStateRegistry$ProjectStateImpl$1.create(DefaultProjectStateRegistry.java:216)
at org.gradle.internal.work.DefaultWorkerLeaseService.withoutLocks(DefaultWorkerLeaseService.java:260)
at org.gradle.internal.work.StopShieldingWorkerLeaseService.withoutLocks(StopShieldingWorkerLeaseService.java:50)
at org.gradle.api.internal.project.DefaultProjectStateRegistry$ProjectStateImpl.withMutableState(DefaultProjectStateRegistry.java:212)
at org.gradle.api.internal.project.DefaultProjectStateRegistry$ProjectStateImpl.withMutableState(DefaultProjectStateRegistry.java:187)
at org.gradle.configuration.project.LifecycleProjectEvaluator$EvaluateProject.run(LifecycleProjectEvaluator.java:96)
at org.gradle.internal.operations.DefaultBuildOperationExecutor$RunnableBuildOperationWorker.execute(DefaultBuildOperationExecutor.java:402)
at org.gradle.internal.operations.DefaultBuildOperationExecutor$RunnableBuildOperationWorker.execute(DefaultBuildOperationExecutor.java:394)
at org.gradle.internal.operations.DefaultBuildOperationExecutor$1.execute(DefaultBuildOperationExecutor.java:165)
at org.gradle.internal.operations.DefaultBuildOperationExecutor.execute(DefaultBuildOperationExecutor.java:250)
at org.gradle.internal.operations.DefaultBuildOperationExecutor.execute(DefaultBuildOperationExecutor.java:158)
at org.gradle.internal.operations.DefaultBuildOperationExecutor.run(DefaultBuildOperationExecutor.java:92)
at org.gradle.internal.operations.DelegatingBuildOperationExecutor.run(DelegatingBuildOperationExecutor.java:31)
at org.gradle.configuration.project.LifecycleProjectEvaluator.evaluate(LifecycleProjectEvaluator.java:68)
at org.gradle.api.internal.project.DefaultProject.evaluate(DefaultProject.java:693)
at org.gradle.api.internal.project.DefaultProject.evaluationDependsOn(DefaultProject.java:773)
at org.gradle.api.internal.project.DefaultProject.evaluationDependsOn(DefaultProject.java:765)
at org.gradle.api.Project$evaluationDependsOn$2.call(Unknown Source)
at include_flutter$_run_closure3$_closure5$_closure6.doCall(include_flutter.groovy:31)
at org.gradle.util.ClosureBackedAction.execute(ClosureBackedAction.java:71)
at org.gradle.util.ConfigureUtil.configureTarget(ConfigureUtil.java:154)
at org.gradle.util.ConfigureUtil.configure(ConfigureUtil.java:105)
at org.gradle.util.ConfigureUtil$WrappedConfigureAction.execute(ConfigureUtil.java:166)
at org.gradle.api.internal.DefaultMutationGuard$2.execute(DefaultMutationGuard.java:42)
at org.gradle.internal.Actions.with(Actions.java:251)
at org.gradle.api.internal.project.BuildOperationCrossProjectConfigurator$2$1.run(BuildOperationCrossProjectConfigurator.java:79)
at org.gradle.internal.operations.DefaultBuildOperationExecutor$RunnableBuildOperationWorker.execute(DefaultBuildOperationExecutor.java:402)
at org.gradle.internal.operations.DefaultBuildOperationExecutor$RunnableBuildOperationWorker.execute(DefaultBuildOperationExecutor.java:394)
at org.gradle.internal.operations.DefaultBuildOperationExecutor$1.execute(DefaultBuildOperationExecutor.java:165)
at org.gradle.internal.operations.DefaultBuildOperationExecutor.execute(DefaultBuildOperationExecutor.java:250)
at org.gradle.internal.operations.DefaultBuildOperationExecutor.execute(DefaultBuildOperationExecutor.java:158)
at org.gradle.internal.operations.DefaultBuildOperationExecutor.run(DefaultBuildOperationExecutor.java:92)
at org.gradle.internal.operations.DelegatingBuildOperationExecutor.run(DelegatingBuildOperationExecutor.java:31)
at org.gradle.api.internal.project.BuildOperationCrossProjectConfigurator$2.run(BuildOperationCrossProjectConfigurator.java:76)
at org.gradle.internal.Factories$1.create(Factories.java:26)
at org.gradle.internal.work.DefaultWorkerLeaseService.withLocks(DefaultWorkerLeaseService.java:189)
at org.gradle.internal.work.StopShieldingWorkerLeaseService.withLocks(StopShieldingWorkerLeaseService.java:40)
at org.gradle.api.internal.project.DefaultProjectStateRegistry$ProjectStateImpl.withProjectLock(DefaultProjectStateRegistry.java:227)
at org.gradle.api.internal.project.DefaultProjectStateRegistry$ProjectStateImpl.access$700(DefaultProjectStateRegistry.java:144)
at org.gradle.api.internal.project.DefaultProjectStateRegistry$ProjectStateImpl$1.create(DefaultProjectStateRegistry.java:216)
at org.gradle.internal.work.DefaultWorkerLeaseService.withoutLocks(DefaultWorkerLeaseService.java:260)
at org.gradle.internal.work.StopShieldingWorkerLeaseService.withoutLocks(StopShieldingWorkerLeaseService.java:50)
at org.gradle.api.internal.project.DefaultProjectStateRegistry$ProjectStateImpl.withMutableState(DefaultProjectStateRegistry.java:212)
at org.gradle.api.internal.project.DefaultProjectStateRegistry$ProjectStateImpl.withMutableState(DefaultProjectStateRegistry.java:187)
at org.gradle.api.internal.project.BuildOperationCrossProjectConfigurator.runProjectConfigureAction(BuildOperationCrossProjectConfigurator.java:73)
at org.gradle.api.internal.project.BuildOperationCrossProjectConfigurator.access$400(BuildOperationCrossProjectConfigurator.java:32)
at org.gradle.api.internal.project.BuildOperationCrossProjectConfigurator$1.doRunProjectConfigure(BuildOperationCrossProjectConfigurator.java:67)
at org.gradle.api.internal.project.BuildOperationCrossProjectConfigurator$BlockConfigureBuildOperation.run(BuildOperationCrossProjectConfigurator.java:121)
at org.gradle.internal.operations.DefaultBuildOperationExecutor$RunnableBuildOperationWorker.execute(DefaultBuildOperationExecutor.java:402)
at org.gradle.internal.operations.DefaultBuildOperationExecutor$RunnableBuildOperationWorker.execute(DefaultBuildOperationExecutor.java:394)
at org.gradle.internal.operations.DefaultBuildOperationExecutor$1.execute(DefaultBuildOperationExecutor.java:165)
at org.gradle.internal.operations.DefaultBuildOperationExecutor.execute(DefaultBuildOperationExecutor.java:250)
at org.gradle.internal.operations.DefaultBuildOperationExecutor.execute(DefaultBuildOperationExecutor.java:158)
at org.gradle.internal.operations.DefaultBuildOperationExecutor.run(DefaultBuildOperationExecutor.java:92)
at org.gradle.internal.operations.DelegatingBuildOperationExecutor.run(DelegatingBuildOperationExecutor.java:31)
at org.gradle.api.internal.project.BuildOperationCrossProjectConfigurator.runBlockConfigureAction(BuildOperationCrossProjectConfigurator.java:64)
at org.gradle.api.internal.project.BuildOperationCrossProjectConfigurator.subprojects(BuildOperationCrossProjectConfigurator.java:49)
at org.gradle.api.internal.project.DefaultProject.subprojects(DefaultProject.java:1149)
at org.gradle.api.Project$subprojects$1.call(Unknown Source)
at include_flutter$_run_closure3$_closure5.doCall(include_flutter.groovy:29)
at org.gradle.configuration.internal.DefaultListenerBuildOperationDecorator$BuildOperationEmittingClosure$1$1.run(DefaultListenerBuildOperationDecorator.java:185)
at org.gradle.configuration.internal.DefaultUserCodeApplicationContext.reapply(DefaultUserCodeApplicationContext.java:60)
at org.gradle.configuration.internal.DefaultListenerBuildOperationDecorator$BuildOperationEmittingClosure$1.run(DefaultListenerBuildOperationDecorator.java:180)
at org.gradle.internal.operations.DefaultBuildOperationExecutor$RunnableBuildOperationWorker.execute(DefaultBuildOperationExecutor.java:402)
at org.gradle.internal.operations.DefaultBuildOperationExecutor$RunnableBuildOperationWorker.execute(DefaultBuildOperationExecutor.java:394)
at org.gradle.internal.operations.DefaultBuildOperationExecutor$1.execute(DefaultBuildOperationExecutor.java:165)
at org.gradle.internal.operations.DefaultBuildOperationExecutor.execute(DefaultBuildOperationExecutor.java:250)
at org.gradle.internal.operations.DefaultBuildOperationExecutor.execute(DefaultBuildOperationExecutor.java:158)
at org.gradle.internal.operations.DefaultBuildOperationExecutor.run(DefaultBuildOperationExecutor.java:92)
at org.gradle.configuration.internal.DefaultListenerBuildOperationDecorator$BuildOperationEmittingClosure.doCall(DefaultListenerBuildOperationDecorator.java:177)
at org.gradle.listener.ClosureBackedMethodInvocationDispatch.dispatch(ClosureBackedMethodInvocationDispatch.java:41)
at org.gradle.listener.ClosureBackedMethodInvocationDispatch.dispatch(ClosureBackedMethodInvocationDispatch.java:25)
at org.gradle.internal.event.AbstractBroadcastDispatch.dispatch(AbstractBroadcastDispatch.java:42)
at org.gradle.internal.event.BroadcastDispatch$SingletonDispatch.dispatch(BroadcastDispatch.java:231)
at org.gradle.internal.event.BroadcastDispatch$SingletonDispatch.dispatch(BroadcastDispatch.java:150)
at org.gradle.internal.event.AbstractBroadcastDispatch.dispatch(AbstractBroadcastDispatch.java:58)
at org.gradle.internal.event.BroadcastDispatch$CompositeDispatch.dispatch(BroadcastDispatch.java:325)
at org.gradle.internal.event.BroadcastDispatch$CompositeDispatch.dispatch(BroadcastDispatch.java:235)
at org.gradle.internal.event.ListenerBroadcast.dispatch(ListenerBroadcast.java:141)
at org.gradle.internal.event.ListenerBroadcast.dispatch(ListenerBroadcast.java:37)
at org.gradle.internal.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:94)
at com.sun.proxy.$Proxy38.afterEvaluate(Unknown Source)
at org.gradle.configuration.project.LifecycleProjectEvaluator$NotifyAfterEvaluate$1.execute(LifecycleProjectEvaluator.java:191)
at org.gradle.configuration.project.LifecycleProjectEvaluator$NotifyAfterEvaluate$1.execute(LifecycleProjectEvaluator.java:188)
at org.gradle.api.internal.project.DefaultProject.stepEvaluationListener(DefaultProject.java:1420)
at org.gradle.configuration.project.LifecycleProjectEvaluator$NotifyAfterEvaluate.run(LifecycleProjectEvaluator.java:197)
... 115 more
Caused by: org.gradle.internal.event.ListenerNotificationException: Failed to notify project evaluation listener.
at org.gradle.internal.event.AbstractBroadcastDispatch.dispatch(AbstractBroadcastDispatch.java:86)
at org.gradle.internal.event.BroadcastDispatch$CompositeDispatch.dispatch(BroadcastDispatch.java:325)
at org.gradle.internal.event.BroadcastDispatch$CompositeDispatch.dispatch(BroadcastDispatch.java:235)
at org.gradle.internal.event.ListenerBroadcast.dispatch(ListenerBroadcast.java:141)
at org.gradle.internal.event.ListenerBroadcast.dispatch(ListenerBroadcast.java:37)
at org.gradle.internal.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:94)
at com.sun.proxy.$Proxy38.afterEvaluate(Unknown Source)
at org.gradle.configuration.project.LifecycleProjectEvaluator$NotifyAfterEvaluate$1.execute(LifecycleProjectEvaluator.java:191)
at org.gradle.configuration.project.LifecycleProjectEvaluator$NotifyAfterEvaluate$1.execute(LifecycleProjectEvaluator.java:188)
at org.gradle.api.internal.project.DefaultProject.stepEvaluationListener(DefaultProject.java:1420)
at org.gradle.configuration.project.LifecycleProjectEvaluator$NotifyAfterEvaluate.run(LifecycleProjectEvaluator.java:197)
... 214 more
Caused by: Assertion failed:
assert appProject != null
| |
null false
at FlutterPlugin$_addFlutterTasks_closure17.doCall(/Users/ejohnson/Voodoo/Apps/flutter/packages/flutter_tools/gradle/flutter.gradle:681)
at org.gradle.util.ClosureBackedAction.execute(ClosureBackedAction.java:71)
at org.gradle.util.ConfigureUtil.configureTarget(ConfigureUtil.java:154)
at org.gradle.util.ConfigureUtil.configure(ConfigureUtil.java:105)
at org.gradle.util.ConfigureUtil$WrappedConfigureAction.execute(ConfigureUtil.java:166)
at org.gradle.api.internal.DefaultDomainObjectCollection.all(DefaultDomainObjectCollection.java:163)
at org.gradle.api.internal.DefaultDomainObjectCollection.all(DefaultDomainObjectCollection.java:198)
at org.gradle.api.DomainObjectCollection$all$1.call(Unknown Source)
at FlutterPlugin.addFlutterTasks(/Users/ejohnson/Voodoo/Apps/flutter/packages/flutter_tools/gradle/flutter.gradle:718)
at org.gradle.configuration.internal.DefaultListenerBuildOperationDecorator$BuildOperationEmittingClosure$1$1.run(DefaultListenerBuildOperationDecorator.java:185)
at org.gradle.configuration.internal.DefaultUserCodeApplicationContext.reapply(DefaultUserCodeApplicationContext.java:60)
at org.gradle.configuration.internal.DefaultListenerBuildOperationDecorator$BuildOperationEmittingClosure$1.run(DefaultListenerBuildOperationDecorator.java:180)
at org.gradle.internal.operations.DefaultBuildOperationExecutor$RunnableBuildOperationWorker.execute(DefaultBuildOperationExecutor.java:402)
at org.gradle.internal.operations.DefaultBuildOperationExecutor$RunnableBuildOperationWorker.execute(DefaultBuildOperationExecutor.java:394)
at org.gradle.internal.operations.DefaultBuildOperationExecutor$1.execute(DefaultBuildOperationExecutor.java:165)
at org.gradle.internal.operations.DefaultBuildOperationExecutor.execute(DefaultBuildOperationExecutor.java:250)
at org.gradle.internal.operations.DefaultBuildOperationExecutor.execute(DefaultBuildOperationExecutor.java:158)
at org.gradle.internal.operations.DefaultBuildOperationExecutor.run(DefaultBuildOperationExecutor.java:92)
at org.gradle.configuration.internal.DefaultListenerBuildOperationDecorator$BuildOperationEmittingClosure.doCall(DefaultListenerBuildOperationDecorator.java:177)
at org.gradle.listener.ClosureBackedMethodInvocationDispatch.dispatch(ClosureBackedMethodInvocationDispatch.java:41)
at org.gradle.listener.ClosureBackedMethodInvocationDispatch.dispatch(ClosureBackedMethodInvocationDispatch.java:25)
at org.gradle.internal.event.AbstractBroadcastDispatch.dispatch(AbstractBroadcastDispatch.java:42)
at org.gradle.internal.event.BroadcastDispatch$SingletonDispatch.dispatch(BroadcastDispatch.java:231)
at org.gradle.internal.event.BroadcastDispatch$SingletonDispatch.dispatch(BroadcastDispatch.java:150)
at org.gradle.internal.event.AbstractBroadcastDispatch.dispatch(AbstractBroadcastDispatch.java:58)
... 224 more
* Get more help at https://help.gradle.org
CONFIGURE FAILED in 342ms
```
|
platform-android,tool,d: api docs,t: gradle,a: existing-apps,P2,team-android,triaged-android
|
low
|
Critical
|
600,812,215 |
flutter
|
Flutter Engine Clang Version
|
I encounter a problem while debugging the engineοΌsingle-step debugging behaves abnormally.
When I take a look at assembly codeοΌit is different between Flutter Clang and Xcode Clang.
For exampleοΌthe assembly code for [FlutterEngine initWithName: project: allowHeadlessExecution]:
[result.zip](https://github.com/flutter/flutter/files/4485466/result.zip)
It looks like that Flutter Clang has more assembly codeοΌ
I am confused nowοΌ
1. What is the difference between the Flutter Clang and Xcode Clang?
2.What is the role of redundant assembly code? Single-step debugging behaves normally when I
use the Xcode Clang.
<!-- Finally, paste the output of running `flutter doctor -v` here. -->
flutter doctor
Doctor summary (to see all details, run flutter doctor -v):
[β] Flutter (Channel unknown, v1.12.13+hotfix.7, on Mac OS X 10.14.6 18G4032, locale
zh-Hans-CN)
[β] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
[β] Xcode - develop for iOS and macOS (Xcode 11.3.1)
[β] Android Studio (version 3.5)
[β] Connected device (1 available)
</details>
Local Engine:
./flutter/tools/gn --runtime-mode=release --unopt
Xcode Clang Version:
Apple clang version 11.0.0 (clang-1100.0.33.17)
Target: x86_64-apple-darwin18.7.0
Thread model: posix
|
engine,d: api docs,a: debugging,customer: bytedance,P2,team-engine,triaged-engine
|
low
|
Critical
|
600,824,521 |
TypeScript
|
TypeScript does not infer the type correctly after two layer Mapped Types.
|
<!-- π¨ STOP π¨ π¦π§π’π£ π¨ πΊπ»πΆπ· π¨
Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Even if you think you've found a *bug*, please read the FAQ first, especially the Common "Bugs" That Aren't Bugs section!
Please help us by doing the following steps before logging an issue:
* Search: https://github.com/Microsoft/TypeScript/search?type=Issues
* Read the FAQ: https://github.com/Microsoft/TypeScript/wiki/FAQ
Please fill in the *entire* template below.
-->
<!--
Please try to reproduce the issue with the latest published version. It may have already been fixed.
For npm: `typescript@next`
This is also the 'Nightly' version in the playground: http://www.typescriptlang.org/play/?ts=Nightly
-->
**TypeScript Version:** 3.9.0-beta
<!-- Search terms you tried before logging this (so others can find this issue more easily) -->
**Search Terms:**
Lookup Types, Mapped Types
**Code**
This is Okay:
```ts
interface APIs {
readonly getUserProfile: {
readonly Parameter: {
readonly id: string;
};
readonly Response: {
'200': {
readonly id: string;
readonly name: string;
readonly gender: boolean;
};
};
};
}
export type ValueType<T extends object> = T[keyof T];
export type PropertyType<T extends object, K extends string> = K extends keyof T
? T[K]
: never;
type MyFetch = {
[operationId in keyof APIs]: (
param: PropertyType<APIs[operationId], 'Parameter'>,
) => Promise<
ValueType<PropertyType<APIs[operationId], 'Response'>>
>;
};
```
And this is Error: *Type 'APIs[server][string]' is not assignable to type 'object'*
```ts
interface APIs {
readonly server1: {
readonly getUserProfile: {
readonly Parameter: {
readonly id: string;
};
readonly Response: {
'200': {
readonly id: string;
readonly name: string;
readonly gender: boolean;
};
};
};
};
}
export type ValueType<T extends object> = T[keyof T];
export type PropertyType<T extends object, K extends string> = K extends keyof T
? T[K]
: never;
type MyFetch = {
[server in keyof APIs]: {
[operationId in keyof APIs[server]]: (
param: PropertyType<APIs[server][operationId], 'Parameter'>,
) => Promise<
ValueType<PropertyType<APIs[server][operationId], 'Response'>>
>;
};
};
```
And this is Ok
```ts
interface APIs {
readonly server1: {
readonly getUserProfile: {
readonly Parameter: {
readonly id: string;
};
readonly Response: {
'200': {
readonly id: string;
readonly name: string;
readonly gender: boolean;
};
};
};
};
}
export type ValueType<T extends object> = T[keyof T];
export type PropertyType<T extends object, K extends string> = K extends keyof T
? T[K]
: never;
type MyFetch = {
[server in keyof APIs]: {
[operationId in keyof APIs[server]]: (
param: PropertyType<{} & APIs[server][operationId], 'Parameter'>,
) => Promise<
ValueType<{} & PropertyType<{} & APIs[server][operationId], 'Response'>>
>;
};
};
```
**Expected behavior:**
remove three `{} & ` and no error.
**Actual behavior:**
**Playground Link:**
[Ok Playground Link 0](https://www.typescriptlang.org/v2/en/play?ts=3.9.0-beta#code/FASwdgLgpgTgZgQwMZQAQEEAKBJAzqgb2FVRigQBMB7MAGwE9UBzKCAVV1kxirhFqgAuQsRKly1Oo0wIYCALatYwomLFlKNBqhAVhuCDHBMA3KJIBfM2o2TtAJSi4ADjU4rzYgOQAmAAx+Xh5qNhJajLr6hsbWISS24ahgCkKoBkZgpp6hmlLMUGAUyqgARlRUAghgsWpWnnWWZhbAwFAAHq4wEKgQ9M5oAGoItACuUAAqfVAAPOOo7dCF+FQlAFZQSBAAfKgAvKjjANoA1lD0vAcAumatHVRdPVOo3FT9XfST-bPzbYsUy2sNhAADSoADSPz++HSxh2+whCwK-1Qp3OcAOogA-AdDmDLqJhGAoAA3WA3Xr9VAAWXoADFWEgABZ7EQkQ6vWAICAgGjYCg6MAos4XLB4S7CAAUnmcsgUwheb16nxmotw7LeXJ5YD5l1BXhkckU0BgXi2wNEAEo9jsXvIQJxpp4hqMJlNpgrYEq3ar1ZzubyKLrUF5HC43FBTVtRFsmiYgA)
[Error Playground Link](https://www.typescriptlang.org/v2/en/play?ts=3.9.0-beta#code/FASwdgLgpgTgZgQwMZQAQEEAKBJAzqgb2FVRigQBMB7MAGwE9VdYA3WARgC5DiTTzqdRgHMoEAKrMYmGFTghaUbkT58ylGg1SYEMBAFsxsZb1Ul1grSArdcEGOGEBuU3wC+Ls-w1DUAJShcAAcaZhMvEgByACYABljI8IjzAU1Ga1t7R09k70tGMAMlJiywZ1cvCzTUUTAKY1QAIyoqRQQwHK8PCtRu1T7elzdgYCgADxCYCFQIeiC0ADUEWgBXKAAVOagAHnXUceg6-CpGgCsoJAgAPlQAXlR1gG0Aayh6OQeAXRdRiaopmZbbSyeZTeibea7fZjQ4UY5nC4QAA0qAA0tDYfg7A4yjd7uiDlAjqhXu84A9eAB+B6PVGfXjcMBQNgwH6zeaoACy9AAYmIkAALO48EiPKQs1DgElvD5YPCfJKiqighAQEA0bAUSVgaVkjA4XBi1iwT4K1AACh6QV0Bm4MmVsFmEJ2csN4pNjwdejVGoonxRkR0ekM0BgkSuSNcAEo7jd7foQMxtj0lqsNlttvbQU6M66jTAWZ9PSqfWBNf7UJEAsFQlBw1dXFcct1ukA)
[Ok Playground Link](https://www.typescriptlang.org/v2/en/play?ts=3.9.0-beta&ssl=30&ssc=40&pln=30&pc=35#code/FASwdgLgpgTgZgQwMZQAQEEAKBJAzqgb2FVRigQBMB7MAGwE9VdYA3WARgC5DiTTzqdRgHMoEAKrMYmGFTghaUbkT58ylGg1SYEMBAFsxsZb1Ul1grSArdcEGOGEBuU3wC+Ls-w1DUAJShcAAcaZhMvEgByACYABljI8IjzAU1Ga1t7R09k70tGMAMlJiywZ1cvCzTUUTAKY1QAIyoqRQQwHK8PCtRu1T7elzdgYCgADxCYCFQIeiC0ADUEWgBXKAAVOagAHnXUceg6-CpGgCsoJAgAPlQAXlR1gG0Aayh6OQeAXRdRiaopmZbbSyeZTeibea7fZjQ4UY5nC4QAA0qAA0tDYfg7A4yjd7uiDlAjqhXu84A9eAB+B6PVGfXjcMBQNgwH6zeaoACy9AAYmIkAALO48EiPKQs1DgElvD5YPCfJKiqighAQEA0bAUSVgaVkjA4XBi1iwT4K1AACh6QV0Bm4MmVsFmEJ2BDcqAAZPq8EaYCzPo8HXo1RqKJ8UZEdHpDNAYJErkjXABKO43e36EDMbY9JarDZbbauj3AwNO-OFz1yw3ik0BlXBsCasOoSIBYKhKBxq6uK45brdIA)
**Related Issues:** <!-- Did you find other bugs that looked similar? -->
https://github.com/pirix-gh/ts-toolbelt/issues/107
|
Needs Investigation
|
low
|
Critical
|
600,829,862 |
create-react-app
|
As the best cli tool for React App, why not add configuration to turn off overlapping iframes?
|
### Is your proposal related to a problem?
This error is what I expected, I do nβt want the iframe to pop up to affect my development, thank you
<!--
Provide a clear and concise description of what the problem is.
For example, "I'm always frustrated when..."
-->
(Write your answer here.)
### Describe the solution you'd like
<!--
Provide a clear and concise description of what you want to happen.
-->
(Describe your proposed solution here.)
### Describe alternatives you've considered
<!--
Let us know about other solutions you've tried or researched.
-->
(Write your answer here.)
### Additional context
<!--
Is there anything else you can add about the proposal?
You might want to link to related issues here, if you haven't already.
-->
(Write your answer here.)
|
issue: proposal,needs triage
|
low
|
Critical
|
600,835,487 |
pytorch
|
Support alpha channel in tensorboard.add_figure
|
## π Bug
When logging images to Tensorboard via `tensorboard.add_figure`, I got really bad text rendering. See below for an example of expected and actual images:
 
After some debugging, I found the solution was to specify a background color in the figure via `plt.figure(facecolor='white')`. Looking further into the PyTorch code, I realise that `torch.utils.tensorboard._utils.figure_to_image()` converts the figure into an RGB image, explicitly stripping the alpha channel in this line:
https://github.com/pytorch/pytorch/blob/f89fc204c62b635efe17f3fcb6fd0ec22129f217/torch/utils/tensorboard/_utils.py#L25
Going further through the code, it seems that `add_figure` simply calls `add_image(figure_to_image(fig))`, which also just takes the image tensor from `figure_to_image(...)` and passes that to a call of `torch.utils.tensorboard.summary.image()`. In that function's docstring, it explicitly states RGBA support:
https://github.com/pytorch/pytorch/blob/f89fc204c62b635efe17f3fcb6fd0ec22129f217/torch/utils/tensorboard/summary.py#L285
As a consequence, I wrote my own `figure_to_image` function, which is identical to PyTorch's, except that it doesn't strip the alpha channel (i.e., I just removed the `[:, :, 0:3]` code from the line cited above). Turns out this works perfectly fine in Tensorboard 2.2.0. Left: old; right: new.
## Question
Was there a specific reason to explicitly strip the alpha channel from the image? Would there be any negative side effects of allowing the alpha channel in `figure_to_image`? Since this function's only use is in `add_figure`, it seems safe to me to add the alpha channel support. Then again, I'm quite certain that the developer who originally wrote this line knew what he or she was doing, so I want to ask here first before creating a PR.
|
module: tensorboard,oncall: visualization
|
low
|
Critical
|
600,846,203 |
vscode
|
${file} - must be the current opened file, but points to the name of output pane
|
Issue Type: <b>Bug</b>
I have a launch configuration that uses predefined variable ${file}. I suppose ${file} must point to the file in the active edit window, but if the cursor is in the output pane, the variable ${file} points to the name of output pane when I press 'F5'.
configuration in launch.json to test:
```
{
"name": "(Windows) Launch",
"type": "cppvsdbg",
"request": "launch",
"program": "cmd",
"args": ["/c","echo", "${file}"],
"stopAtEntry": false,
"cwd": "${workspaceFolder}",
"environment": [],
"externalConsole": false
}
```
VS Code version: Code 1.44.1 (a9f8623ec050e5f0b44cc8ce8204a1455884749f, 2020-04-11T01:48:12.622Z)
OS version: Windows_NT x64 10.0.18363
<details>
<summary>System Info</summary>
|Item|Value|
|---|---|
|CPUs|Intel(R) Core(TM) i5-5200U CPU @ 2.20GHz (4 x 2195)|
|GPU Status|2d_canvas: enabled<br>flash_3d: enabled<br>flash_stage3d: enabled<br>flash_stage3d_baseline: enabled<br>gpu_compositing: enabled<br>multiple_raster_threads: enabled_on<br>oop_rasterization: disabled_off<br>protected_video_decode: unavailable_off<br>rasterization: enabled<br>skia_renderer: disabled_off_ok<br>video_decode: enabled<br>viz_display_compositor: enabled_on<br>viz_hit_test_surface_layer: disabled_off_ok<br>webgl: enabled<br>webgl2: enabled|
|Load (avg)|undefined|
|Memory (System)|7.88GB (1.66GB free)|
|Process Argv|--folder-uri file:///c%3A/work/vms_ide/vms-ide|
|Screen Reader|no|
|VM|50%|
</details><details><summary>Extensions (10)</summary>
Extension|Author (truncated)|Version
---|---|---
Kotlin|mat|1.7.1
vscode-antlr4|mik|2.2.3
csharp|ms-|1.21.17
python|ms-|2020.3.71659
cpptools|ms-|0.27.0
platformio-ide|pla|1.10.0
scala|sca|0.3.9
rst-vscode|tht|3.0.1
sort-lines|Tyr|1.9.0
hex-ascii-converter|yrp|0.0.1
</details>
<!-- generated by issue reporter -->
|
bug,debug,variable-resolving
|
low
|
Critical
|
600,854,294 |
vscode
|
Improve rendering of find matches touching each other
|
Issue Type: <b>Bug</b>
I need to remove some lines of text from about 80 files (every file has about 2000 rows) at the same time. I wanted to use search&replace tool in vs Code(ctrl+shift+f).
And my issue consists of two different problems:
## Problem 1
Given following rows:
```
bΓ½t=elektronickΓ½=zΓ‘silka
bΓ½t=jinΓ½=zpΕ―sob
bΓ½t=poskytovΓ‘nΓ=pozΓ‘ruΔnΓ
bΓ½t=poskytovΓ‘nΓ=servisnΓ
bΓ½t=pozdΔ=tΕetΓ
bΓ½t=pozΓ‘ruΔnΓ
bΓ½t=pozΓ‘ruΔnΓ=servis
bΓ½t=pΕΓsluΕ‘nΓ½=krajskΓ½
bΓ½t=pΕΓsluΕ‘nΓ½=poΕ‘kozenΓ½
bΓ½t=schopnΓ½=dodanΓ½
bΓ½t=servis
bΓ½t=servisnΓ
bΓ½t=servisnΓ=sluΕΎba
bΓ½t=sluΕΎba=zahrnujΓcΓ
bΓ½t=zejmΓ©na=uvedenΓ½
```
where I need to remove whole row with occurence. This works correctly and matches 3+grams:
`^bΓ½t=[^=]+=.*`
This incorrectly matches also 2grams:
`^bΓ½t=[^=]+=.*\n`
Then i thought - ok, I can make some workaround and split it to two regexps which lead to problem 2.
## Problem 2
When I removed all occurences of this `^bΓ½t=[^=]+=.*` from all files, then I needed to remove blank lines. I used the same tool for multi search and replace in all files from the same folder.
I used this regexp `^\n` and the button for replace all (it said about 2000 occurences) didn't do almost anything (changed about 3 files from 80).
Ok I tried to click to replace all button in multisearch window file by file. Reached 3rd file where it stopped to work as well.
Ok if I click fast enough I might be done soon I thought and clicked on replace for each occurence in multisearch window.
And I was terrified when I later found that it instead of deleting blank lines also deleted lines with text. (e.g. `cena=nΓ‘hradnΓ=dΓl`)
VS Code version: Code 1.44.1 (a9f8623ec050e5f0b44cc8ce8204a1455884749f, 2020-04-11T01:48:12.622Z)
OS version: Windows_NT x64 10.0.18363
<details>
<summary>System Info</summary>
|Item|Value|
|---|---|
|CPUs|Intel(R) Core(TM) i7-7700HQ CPU @ 2.80GHz (8 x 2808)|
|GPU Status|2d_canvas: enabled<br>flash_3d: enabled<br>flash_stage3d: enabled<br>flash_stage3d_baseline: enabled<br>gpu_compositing: enabled<br>multiple_raster_threads: enabled_on<br>oop_rasterization: disabled_off<br>protected_video_decode: enabled<br>rasterization: enabled<br>skia_renderer: disabled_off_ok<br>video_decode: enabled<br>viz_display_compositor: enabled_on<br>viz_hit_test_surface_layer: disabled_off_ok<br>webgl: enabled<br>webgl2: enabled|
|Load (avg)|undefined|
|Memory (System)|31.87GB (20.32GB free)|
|Process Argv||
|Screen Reader|no|
|VM|0%|
</details><details><summary>Extensions (14)</summary>
Extension|Author (truncated)|Version
---|---|---
vscode-base64|ada|0.1.0
vscode-markdownlint|Dav|0.34.0
jsonpath-extract|dav|1.2.3
gc-excelviewer|Gra|2.1.34
Angular2|joh|9.1.2
rainbow-csv|mec|1.6.0
vscode-docker|ms-|1.0.0
csharp|ms-|1.21.17
vscode-kubernetes-tools|ms-|1.1.1
python|ms-|2020.3.71659
powershell|ms-|2020.3.0
vscode-typescript-tslint-plugin|ms-|1.2.3
vscode-yaml|red|0.7.2
markdown-all-in-one|yzh|2.8.0
</details>
<!-- generated by issue reporter -->
|
feature-request,ux,editor-find
|
low
|
Critical
|
600,879,590 |
flutter
|
flutter build apk --split-per-abi logs are wrong
|
When running `flutter build apk --split-per-abi`, the logs report only 32bit APK was built, but when you open the output directory, all platforms are built (as expected).
<details>
<summary>Logs</summary>
```
> flutter build apk --split-per-abi
Running Gradle task 'assembleRelease'...
Running Gradle task 'assembleRelease'... Done 114,5s
β Built build\app\outputs\flutter-apk\app-armeabi-v7a-release.apk (10.5MB).
```
```
> flutter doctor -v
[β] Flutter (Channel master, v1.18.0-6.0.pre.42, on Microsoft Windows [VersiΓΒ³n 10.0.18363.778], locale es-ES)
β’ Flutter version 1.18.0-6.0.pre.42 at C:\flutter
β’ Framework revision b8bd09db21 (4 hours ago), 2020-04-15 22:25:32 -0700
β’ Engine revision deef2663ac
β’ Dart version 2.8.0 (build 2.8.0-dev.20.0 c9710e5059)
[β] Android toolchain - develop for Android devices (Android SDK version 29.0.3)
β’ Android SDK at C:\Users\crist\AppData\Local\Android\sdk
β’ Platform android-29, build-tools 29.0.3
β’ Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
β’ Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b04)
β’ All Android licenses accepted.
[β] Chrome - develop for the web
β’ Chrome at C:\Program Files (x86)\Google\Chrome\Application\chrome.exe
[β] Android Studio (version 3.6)
β’ Android Studio at C:\Program Files\Android\Android Studio
β’ Flutter plugin version 46.0.1-dev.1
β’ Dart plugin version 192.7761
β’ Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b04)
[β] Connected device (3 available)
β’ Pixel 3 XL β’ 192.168.1.33:5555 β’ android-arm64 β’ Android 10 (API 29)
β’ Chrome β’ chrome β’ web-javascript β’ Google Chrome 80.0.3987.163
β’ Web Server β’ web-server β’ web-javascript β’ Flutter Tools
β’ No issues found!
```
</details>
|
c: regression,tool,t: gradle,P2,team-tool,triaged-tool
|
low
|
Minor
|
600,906,708 |
godot
|
Godot WebGL export doesn't work on Safari
|
**Godot version:**
3.2.1.stable
**OS/device including version:**
macOS Catalina 10.15.4 / MacBookPro11,1
Safari version: 13.1 (15609.1.20.111.8)
Although this problem happens on the latest version of Safari, I remember that it happened on earlier versions of Safari too.
**Issue description:**
I quickly exported this project to WebGL and uploaded it to itch.io:
https://stone-age-jazz.itch.io/godot-weggl-test
PASSWORD: godot
The project is barebones, standard configuration, nothing has been changed.
The game does not work when running the game from Safari.
The game works when running on Firefox.
The particular error message that I get when trying to run the project in Safari is:
call_indirect to a null table entry (evaluating 'Module["asm"]["Gi"].apply(null,arguments)')
On Safari - desktop:
<img width="1280" alt="Screenshot 2020-04-16 at 16 57 58" src="https://user-images.githubusercontent.com/13488692/79465129-a03f9480-8003-11ea-95ce-e07593fce095.png">
On Firefox - desktop:
<img width="1280" alt="Screenshot 2020-04-16 at 16 58 32" src="https://user-images.githubusercontent.com/13488692/79465215-b4839180-8003-11ea-9f65-428049264ae7.png">
On Chrome - desktop:
<img width="1280" alt="Screenshot 2020-04-16 at 17 33 09" src="https://user-images.githubusercontent.com/13488692/79469155-7b99eb80-8008-11ea-871a-5a982f22b335.png">
On Edge - desktop:
<img width="1280" alt="Screenshot 2020-04-16 at 17 35 27" src="https://user-images.githubusercontent.com/13488692/79469383-c3b90e00-8008-11ea-8539-662eec969a08.png">
On Opera - desktop:
<img width="1280" alt="Screenshot 2020-04-16 at 17 37 10" src="https://user-images.githubusercontent.com/13488692/79469541-fb27ba80-8008-11ea-88f1-11e18efec42a.png">
**Steps to reproduce:**
On macOS, run the game in Safari. It will NOT work.
On macOS, run the game in Firefox. It will work.
On macOS, run the game in Chrome. It will work.
On macOS, run the game in Edge. It will work.
On macOS, run the game in Opera. It will work.
**Minimal reproduction project:**
[Apocalypse Now.zip](https://github.com/godotengine/godot/files/4486467/Apocalypse.Now.zip)
|
bug,platform:macos,topic:porting
|
medium
|
Critical
|
600,920,459 |
TypeScript
|
Distributive as const
|
## Search Terms
as const, widening, literal widening
## Suggestion
Allow to use `as const` on ternary operator as well as others code branches that currently we can't.
## Use Cases
Let's say that we have this code:
```ts
const result = (
value > 5
? { amount: 'many' } as const
: { amount: 'few' } as const
)
```
We need to type `as const` twice. So would be nice if we could type just once:
```ts
const result = (
value > 5
? { amount: 'many' }
: { amount: 'few' }
) as const
```
Currently we can't do that ([playground](https://www.typescriptlang.org/play/?ssl=1&ssc=1&pln=8&pc=1#code/DYUwLgBAbghsCuIIF4IHYCwAobBjA9gHYDOkATiMfMJKgBTYTRyIQB8EArI0xAPwQA3hBgBbfPEJgAXBADkomIQCeciAF8eTWcLESpsuQDMQAdzWasASmxA)).
**It's just a syntax sugar. It won't change anything on `as const`!**
Analogously, maybe we could allow this syntax sugar on function:
```ts
const func = (param: number) => {
if (param > 5) {
return 'many' as const
}
return 'few' as const
}
// would be just...
const func = (param: number): const => {
if (param > 5) {
return 'many'
}
return 'few'
}
```
## Checklist
My suggestion meets these guidelines:
* [x] This wouldn't be a breaking change in existing TypeScript/JavaScript code
* [x] This wouldn't change the runtime behavior of existing JavaScript code
* [x] This could be implemented without emitting different JS based on the types of the expressions
* [x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
* [x] This feature would agree with the rest of [TypeScript's Design Goals](https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals).
|
Suggestion,In Discussion
|
low
|
Major
|
600,930,328 |
material-ui
|
[Select] Fails when using screen reader or keyboard navigation
|
While generally the accessibility functionality of the MUI Multi-select is decent, it would still fail any audit due to inconsistent screen reader behaviour and keyboard navigation. See further details below.
- [x] The issue is present in the latest release.
- [x] I have searched the [issues](https://github.com/mui-org/material-ui/issues) of this repository and believe that this is not a duplicate.
## Current Behaviour π―
### Screen Readers (SR)
#### Win10/Chrome/ChromeVox
When I navigate to the select that has preselected entries, these are not announced to me unless I open the menu and navigate to each of the entries. It is possible to open the menu and select/deselect ok with enter key, space doesnβt work. No instructions for the user either, and the select is announced as a βbuttonβ and Iβm not informed when menu is expanded or collapsed. Not an ideal experience. Would fail an audit.
#### Win10/Chrome/Jaws
Slightly better experience (announces as expanded, gives instructions to navigate list), but JAWS wonβt announce which of the entries have been ticked/selected. You have to close the menu and listen to the chips to determine that. Would fail an audit.
#### Win10/Firefox/NVDA
Can navigate menu using Insert+Space, then arrow keys, however selected entries are not announced, as per above. Would fail an audit.
#### Mac10.14/Chrome/VoiceOver
Shares the same issues as above. Would fail an audit.
#### Overall
- SR doesnβt announce which of the entries have been ticked/selected.
- SR doesnβt allow user to use spacebar to select/check entries.
- SR doesnβt always announce when the listbox has been expanded or collapsed.
- SR doesnβt reliably read the selected entries when the menu is collapsed (e.g. chips)
### Keyboard Navigation
It works with TAB to select, up/down arrow or Enter to open and Enter key to select entry, but doesnβt work with space to select, this would be expected behaviour.
## Expected Behaviour π€
- SR must announce which of the entries have been ticked/selected.
- SR must always announce when the listbox has been expanded or collapsed.
- In keyboard navigation mode and while using SR we must allow user to use spacebar to select/check entries. See HTML5 example: https://www.w3schools.com/tags/tryit.asp?filename=tryhtml_select
## Steps to Reproduce πΉ
Try the following example with the above mentioned screen readers and using the keyboard only: https://cwvg4.csb.app/
## Context π¦
The goal is to meet the WCAG 2.0/2.1 AA standard as legal audit requirement for a learning platform used by millions of students, teachers and administrators.
## Your Environment π
| Tech | Version |
| ----------- | ------- |
| Material-UI | v4.9.10 |
| Browser | Firefox (latest), Chrome (latest) |
| Screen Reader | Jaws, VoiceOver, NVDA, ChromeVox |
| OS | MacOS 10.14, 10.15, Windows 10 |
|
accessibility,component: select
|
medium
|
Major
|
600,953,868 |
ant-design
|
Tree component dosen't work when async loading and virtual scroll are used in combination.
|
- [x] I have searched the [issues](https://github.com/ant-design/ant-design/issues) of this repository and believe that this is not a duplicate.
### Reproduction link
[](https://codesandbox.io/s/unruffled-maxwell-m6bm4)
### Steps to reproduce
1. Expand the first tree node
2. Scroll to the bottom of the tree
3. The second root tree node is not visible
### What is expected?
All nodes in the tree should be visible.
### What is actually happening?
Some nodes (second root node, and Child Node 9) are not being rendered/being rendered outside of the visible area of the component.
| Environment | Info |
|---|---|
| antd | 4.1.3 |
| React | 16.12.0 |
| System | MacOS |
| Browser | Chrome |
---
Everything works as expected after collapsing the first root node, and then later re-expanding it.
<!-- generated by ant-design-issue-helper. DO NOT REMOVE -->
|
π Bug,Inactive
|
low
|
Minor
|
600,996,957 |
pytorch
|
[1.4.1] Cuda build fails
|
Using:
Cuda 10.2
GCC: 7.3.1
Without cuda the build will be done.
```
[ 23%] Building CXX object third_party/gloo/gloo/CMakeFiles/gloo.dir/common/logging.cc.o
c++: error: unrecognized command line option '-faligned-new'
```
[build.log.zip](https://github.com/pytorch/pytorch/files/4486925/build.log.zip)
|
needs reproduction,module: build,triaged
|
low
|
Critical
|
601,080,388 |
flutter
|
State object has a null widget during call to initState.
|
I got a weird error via my error reporting service and it's not helpfull to me at all. So I though you guys could take a look at this and maybe tell me what could be the cause... I have no reproduction code since I have no idea where it could go wrong.
### Error
```
NoSuchMethodError: The getter 'manager' was called on null.
Receiver: null
Tried calling: manager
package:flutter/src/widgets/shortcuts.dart 320 in _ShortcutsState.initState
```
### Formatted stack trace
```
{
"traces":[
{
"Library":"package:flutter/src/widgets/shortcuts.dart",
"Line":320,
"Method":"initState",
"Class":"_ShortcutsState"
},
{
"Library":"package:flutter/src/widgets/framework.dart",
"Line":4355,
"Method":"_firstBuild",
"Class":"StatefulElement"
},
{
"Library":"package:flutter/src/widgets/framework.dart",
"Line":4201,
"Method":"mount",
"Class":"ComponentElement"
},
{
"Library":"package:flutter/src/widgets/framework.dart",
"Line":3194,
"Method":"inflateWidget",
"Class":"Element"
},
{
"Library":"package:flutter/src/widgets/framework.dart",
"Line":2988,
"Method":"updateChild",
"Class":"Element"
},
{
"Library":"package:flutter/src/widgets/framework.dart",
"Line":4243,
"Method":"performRebuild",
"Class":"ComponentElement"
},
{
"Library":"package:flutter/src/widgets/framework.dart",
"Line":3947,
"Method":"rebuild",
"Class":"Element"
},
{
"Library":"package:flutter/src/widgets/framework.dart",
"Line":4206,
"Method":"_firstBuild",
"Class":"ComponentElement"
},
{
"Library":"package:flutter/src/widgets/framework.dart",
"Line":4381,
"Method":"_firstBuild",
"Class":"StatefulElement"
},
{
"Library":"package:flutter/src/widgets/framework.dart",
"Line":4201,
"Method":"mount",
"Class":"ComponentElement"
},
{
"Library":"package:flutter/src/widgets/framework.dart",
"Line":3194,
"Method":"inflateWidget",
"Class":"Element"
},
{
"Library":"package:flutter/src/widgets/framework.dart",
"Line":2988,
"Method":"updateChild",
"Class":"Element"
},
{
"Library":"package:flutter/src/widgets/framework.dart",
"Line":4243,
"Method":"performRebuild",
"Class":"ComponentElement"
},
{
"Library":"package:flutter/src/widgets/framework.dart",
"Line":3947,
"Method":"rebuild",
"Class":"Element"
},
{
"Library":"package:flutter/src/widgets/framework.dart",
"Line":4206,
"Method":"_firstBuild",
"Class":"ComponentElement"
},
{
"Library":"package:flutter/src/widgets/framework.dart",
"Line":4201,
"Method":"mount",
"Class":"ComponentElement"
},
{
"Library":"package:flutter/src/widgets/framework.dart",
"Line":3194,
"Method":"inflateWidget",
"Class":"Element"
},
{
"Library":"package:flutter/src/widgets/framework.dart",
"Line":2988,
"Method":"updateChild",
"Class":"Element"
},
{
"Library":"package:flutter/src/widgets/framework.dart",
"Line":4243,
"Method":"performRebuild",
"Class":"ComponentElement"
},
{
"Library":"package:flutter/src/widgets/framework.dart",
"Line":3947,
"Method":"rebuild",
"Class":"Element"
},
{
"Library":"package:flutter/src/widgets/framework.dart",
"Line":4206,
"Method":"_firstBuild",
"Class":"ComponentElement"
},
{
"Library":"package:flutter/src/widgets/framework.dart",
"Line":4381,
"Method":"_firstBuild",
"Class":"StatefulElement"
},
{
"Library":"package:flutter/src/widgets/framework.dart",
"Line":4201,
"Method":"mount",
"Class":"ComponentElement"
},
{
"Library":"package:flutter/src/widgets/framework.dart",
"Line":3194,
"Method":"inflateWidget",
"Class":"Element"
},
{
"Library":"package:flutter/src/widgets/framework.dart",
"Line":2988,
"Method":"updateChild",
"Class":"Element"
},
{
"Library":"package:flutter/src/widgets/framework.dart",
"Line":4243,
"Method":"performRebuild",
"Class":"ComponentElement"
},
{
"Library":"package:flutter/src/widgets/framework.dart",
"Line":3947,
"Method":"rebuild",
"Class":"Element"
},
{
"Library":"package:flutter/src/widgets/framework.dart",
"Line":2432,
"Method":"buildScope",
"Class":"BuildOwner"
},
{
"Library":"package:flutter/src/widgets/binding.dart",
"Line":773,
"Method":"drawFrame",
"Class":"WidgetsBinding"
},
{
"Library":"package:flutter/src/rendering/binding.dart",
"Line":283,
"Method":"_handlePersistentFrameCallback",
"Class":"RendererBinding"
},
{
"Library":"package:flutter/src/scheduler/binding.dart",
"Line":1102,
"Method":"_invokeFrameCallback",
"Class":"SchedulerBinding"
},
{
"Library":"package:flutter/src/scheduler/binding.dart",
"Line":1041,
"Method":"handleDrawFrame",
"Class":"SchedulerBinding"
},
{
"Library":"package:flutter/src/scheduler/binding.dart",
"Line":850,
"Method":"scheduleWarmUpFrame.<fn>",
"Class":"SchedulerBinding"
},
{
"Library":"dart:async/zone.dart",
"Line":1122,
"Method":"_rootRun",
"Class":null
},
{
"Library":"dart:async/zone.dart",
"Line":1023,
"Method":"run",
"Class":"_CustomZone"
},
{
"Library":"dart:async/zone.dart",
"Line":925,
"Method":"runGuarded",
"Class":"_CustomZone"
},
{
"Library":"dart:async/zone.dart",
"Line":965,
"Method":"bindCallbackGuarded.<fn>",
"Class":"_CustomZone"
},
{
"Library":"dart:async/zone.dart",
"Line":1126,
"Method":"_rootRun",
"Class":null
},
{
"Library":"dart:async/zone.dart",
"Line":1023,
"Method":"run",
"Class":"_CustomZone"
},
{
"Library":"dart:async/zone.dart",
"Line":949,
"Method":"bindCallback.<fn>",
"Class":"_CustomZone"
},
{
"Library":"dart:async-patch/timer_patch.dart",
"Line":23,
"Method":"_createTimer.<fn>",
"Class":"Timer"
},
{
"Library":"dart:isolate-patch/timer_impl.dart",
"Line":384,
"Method":"_runTimers",
"Class":"_Timer"
},
{
"Library":"dart:isolate-patch/timer_impl.dart",
"Line":418,
"Method":"_handleMessage",
"Class":"_Timer"
},
{
"Library":"dart:isolate-patch/isolate_patch.dart",
"Line":174,
"Method":"_handleMessage",
"Class":"_RawReceivePortImpl"
}
]
}
```
### Error occured on devices
- Samsung SM-A320FL (Android 8.0.0)
### flutter doctor -v
```
[β] Flutter (Channel stable, v1.12.13+hotfix.9, on Microsoft Windows [Version 10.0.18363.720], locale bs-Latn-BA)
β’ Flutter version 1.12.13+hotfix.9 at C:\Programs\Flutter
β’ Framework revision f139b11009 (2 weeks ago), 2020-03-30 13:57:30 -0700
β’ Engine revision af51afceb8
β’ Dart version 2.7.2
[β] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
β’ Android SDK at C:\Users\Anis\AppData\Local\Android\Sdk
β’ Android NDK location not configured (optional; useful for native profiling support)
β’ Platform android-29, build-tools 29.0.2
β’ ANDROID_HOME = C:\Users\Anis\AppData\Local\Android\Sdk
β’ Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
β’ Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b04)
β’ All Android licenses accepted.
[β] Android Studio (version 3.6)
β’ Android Studio at C:\Program Files\Android\Android Studio
β’ Flutter plugin version 44.0.2
β’ Dart plugin version 192.7761
β’ Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b04)
[β] IntelliJ IDEA Community Edition (version 2018.2)
β’ IntelliJ at C:\Program Files\JetBrains\IntelliJ IDEA Community Edition 2018.2.2
β’ Flutter plugin version 28.0.4
β’ Dart plugin version 182.4323.44
[β] IntelliJ IDEA Community Edition (version 2019.3)
β’ IntelliJ at C:\Program Files\JetBrains\IntelliJ IDEA Community Edition 2018.3
β’ Flutter plugin version 45.0.2
β’ Dart plugin version 193.6911.31
[β] VS Code, 64-bit edition (version 1.38.1)
β’ VS Code at C:\Program Files\Microsoft VS Code
β’ Flutter extension version 3.7.1
[β] Connected device (1 available)
β’ ANE LX1 β’ 9WV4C19131006232 β’ android-arm64 β’ Android 9 (API 28)
β’ No issues found!
```
|
c: crash,platform-android,framework,a: error message,a: production,P2,team-android,triaged-android
|
low
|
Critical
|
601,219,169 |
TypeScript
|
Provide `declare` keyword support for class methods
|
<!-- π¨ STOP π¨ π¦π§π’π£ π¨ πΊπ»πΆπ· π¨
Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker.
Please help us by doing the following steps before logging an issue:
* Search: https://github.com/Microsoft/TypeScript/search?type=Issues
* Read the FAQ, especially the "Common Feature Requests" section: https://github.com/Microsoft/TypeScript/wiki/FAQ
-->
## Search Terms
<!-- List of keywords you searched for before creating this issue. Write them down here so that others can find this suggestion more easily -->
declare, class, method
## Suggestion
<!-- A summary of what you'd like to see added or changed -->
I know that `declare` keyword already support class properties. I've wonder if it is possiable to bring the support to class methods as well?
## Use Cases
<!--
What do you want to use this for?
What shortcomings exist with current approaches?
-->
You override a method `a`, and there are some other methods that return the return value of `a`.
## Examples
<!-- Show how this would be used and what the behavior would be -->
This is just a simple example describing my idea.
```typescript
class BaseTag
{
constructor(tag: string) {...}
static fromString(tag: string): BaseTag
{
return new BaseTag(tag);
}
static fromNumber(tag: number): BaseTag
{
return this.fromString(tag.toString());
}
}
class ExtendedTag extends BaseTag
{
static fromString(tag: string): ExtendedTag
{
return new BaseTag(`Tag: ${ tag}`);
}
declare static fromNumber(tag: number): ExtendedTag;
// // Without `declare` support
// static fromNumber(tag: number): ExtendedTag
// {
// return super.fromString(tag) as unknown as ExtendedTag;
// }
}
```
## Checklist
My suggestion meets these guidelines:
* [x] This wouldn't be a breaking change in existing TypeScript/JavaScript code
* [x] This wouldn't change the runtime behavior of existing JavaScript code
* [x] This could be implemented without emitting different JS based on the types of the expressions
* [x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
* [x] This feature would agree with the rest of [TypeScript's Design Goals](https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals).
|
Suggestion,Awaiting More Feedback
|
low
|
Critical
|
601,240,057 |
three.js
|
Animation jump when timeScale changes sign in the first loop when using LoopPingPong mode
|
Hi I'm testing this lovely library and i've found a bug.
I have an animation in a pingpong way.
When i click on it, the mixer.timeScale is switched between 1 and -1.
In the **first** loop, at the first click, the animation jumps straight to the end and start going in reverse mode. The others loops are fine.
Looking at the code, it seems to be coming from there :
https://github.com/mrdoob/three.js/blob/eb8639016466f0066714f7c1c0c67a59898979e0/src/animation/AnimationAction.js#L545-L567
`if ( deltaTime >= 0 ) `
Should be changed because if delta is negative, then it jumps to the end of animation instead of goinf in reverse mode!
`if ( deltaTime * timeDirection >= 0 ) `
Here is the full stack to change the caller :
https://github.com/mrdoob/three.js/blob/eb8639016466f0066714f7c1c0c67a59898979e0/src/animation/AnimationAction.js#L330
https://github.com/mrdoob/three.js/blob/eb8639016466f0066714f7c1c0c67a59898979e0/src/animation/AnimationAction.js#L366
Adding timeDirection to
https://github.com/mrdoob/three.js/blob/eb8639016466f0066714f7c1c0c67a59898979e0/src/animation/AnimationAction.js#L487
|
Bug
|
low
|
Critical
|
601,246,892 |
rust
|
Misleading error message originating from the fact that closure types are not inferred being polymorphic over lifetimes. (And related errors in need of improvement.)
|
The following code produces an error message that doesnβt at all explain the actual problem.
```rust
fn foo() -> &'static str {
let identity = |x| x;
let result = identity("result!");
let local_string: String = "local".into();
let _ = identity(&local_string);
result
}
```
([Playground](https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=b38bbf2da51154080363926cbb21143d))
Errors:
```
Compiling playground v0.0.1 (/playground)
error[E0515]: cannot return value referencing local variable `local_string`
--> src/lib.rs:7:5
|
5 | let _ = identity(&local_string);
| ------------- `local_string` is borrowed here
6 |
7 | result
| ^^^^^^ returns a value referencing data owned by the current function
error: aborting due to previous error
For more information about this error, try `rustc --explain E0515`.
error: could not compile `playground`.
To learn more, run the command again with --verbose.
```
In particular looking at this statement β βreturns a value referencing data owned by the current functionβ β thatβs just _not what is going on here_.
What really is going on here (as far as I can tell) is that `identity` is inferred as some closure implementing `Fn(A) -> A` for `A` to be determined, then the first call `identity("result!")` tells the type inference that `A` is `&'a str` for some `'a` to be determined, and finally `identity(&local_string)` already knows to apply unsized coercion and typechecks nailing `'a` down to the lifetime of `local_string`. This means `result` is an `&'a str` with that same lifetime.
A bit less confusing of an error message but still suboptimal IMO is what you get when trying to use a closure truly polymorphically:
```rust
fn foo() {
let identity = |x| x;
identity(1u8);
identity(1u16);
}
```
([Playground](https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=4277c8cc1d67fab42fdb8330756b4055))
Errors:
```
Compiling playground v0.0.1 (/playground)
error[E0308]: mismatched types
--> src/lib.rs:4:14
|
4 | identity(1u16);
| ^^^^ expected `u8`, found `u16`
|
help: change the type of the numeric literal from `u16` to `u8`
|
4 | identity(1u8);
| ^^^
error: aborting due to previous error
For more information about this error, try `rustc --explain E0308`.
error: could not compile `playground`.
To learn more, run the command again with --verbose.
```
I think this could be improved by a message explaining where the expected type `u8` comes from.
<br></br><br></br>
Back to the original example.. in my opinion it would be nice if the example would not error at all. After all the following _does_ work:
```rust
fn str_closure<F: Fn(&str) -> &str>(f: F) -> F { f }
fn foo() -> &'static str {
let identity = str_closure(|x| x);
let result = identity("result!");
let local_string: String = "local".into();
let _ = identity(&local_string);
result
}
```
However, this again doesnβt work:
```rust
fn str_closure<F: Fn(&str) -> &str>(f: F) -> F { f }
fn foo() -> &'static str {
let closure = |x| x;
let identity = str_closure(closure);
let result = identity("result!");
let local_string: String = "local".into();
let _ = identity(&local_string);
result
}
```
<br></br><br></br>
Finally, on the topic of _trying to get more polymorphism out of closures than they support_, I ran into this error message (which I could move into a separate issue if you guys think that itβs completely unrelated):
```rust
fn f<A>() -> A { unimplemented!() }
fn foo() {
let _ = f;
}
```
([Playground](https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=e7a932c7d50e8e7638a57b2373cf9b35))
Errors:
```
Compiling playground v0.0.1 (/playground)
error[E0282]: type annotations needed for `fn() -> A {f::<A>}`
--> src/lib.rs:3:13
|
3 | let _ = f;
| - ^ cannot infer type for type parameter `A` declared on the function `f`
| |
| consider giving this pattern the explicit type `fn() -> A {f::<A>}`, where the type parameter `A` is specified
error: aborting due to previous error
For more information about this error, try `rustc --explain E0282`.
error: could not compile `playground`.
To learn more, run the command again with --verbose.
```
Which is just weird, because: What is this `fn() -> A {f::<A>}` syntax supposed to mean?
@rustbot modify labels to T-compiler, T-lang, A-diagnostics, D-incorrect, D-terse, D-papercut, C-bug, C-enhancement, A-closures, A-inference.
|
A-diagnostics,A-closures,T-lang,T-compiler,A-inference,D-papercut,D-terse
|
low
|
Critical
|
601,298,667 |
godot
|
Timer time_left is wrong before it started
|
**Godot version:**
3.2.1
**OS/device including version:**
Windows 10 Home 1909
**Issue description:**
If you create a Timer in code, set its wait time and want to get it, it will return 0 before its start.
**Steps to reproduce:**
var timer = Timer.new()
func _ready():
timer.set_wait_time(3)
print(timer.time_left)
**Minimal reproduction project:**
|
discussion,topic:core
|
low
|
Major
|
601,323,350 |
pytorch
|
Custom Generators don't work in JIT
|
[Unboxed dispatch handles Generator](https://github.com/pytorch/pytorch/blob/e29348f8283ffa6be5915abb46f280fce5d64ce4/aten/src/ATen/core/dispatch/DispatchKeyExtractor.h#L67-L76), i.e. it looks at Generator arguments to make the dispatch decision, but [boxed dispatch does not](https://github.com/pytorch/pytorch/blob/e29348f8283ffa6be5915abb46f280fce5d64ce4/aten/src/ATen/core/dispatch/DispatchKeyExtractor.h#L122-L137).
This means that custom PRNGs will work in eager mode currently, but they won't work in scripted models.
Potential ways of fixing this:
- Remove Generator from unboxed dispatch too and find a different way to handle Generators, for example
- make it a custom class and add overloads for different generator types
- or use an approach similar to BackendSelect
- or add support for Generator to boxed dispatch to make the current approach work with JIT (note that this might have a perf impact because the dispatch function gets larger and less likely to get inlined).
cc @suo @bhosmer @ezyang @pbelevich @dzhulgakov @zdevito
|
triaged
|
low
|
Minor
|
601,325,586 |
bitcoin
|
build: Use Xcode .xip as Guix input
|
It seems to me that the [manual extraction](https://github.com/bitcoin/bitcoin/tree/master/contrib/macdeploy#sdk-extraction) of `MacOSX10.*.sdk.tar.gz` can be a source of fragility, confusion, and non-determinism.
Perhaps what we could do going forward is to have the unmodified Xcode `.xip` as the Gitian input, and perform the extraction inside the Gitian environment. This has the additional benefit of the `.xip` being trivially deterministic (and thus easy to compare) as long as people are downloading the same version.
|
macOS,Build system
|
low
|
Major
|
601,336,093 |
PowerToys
|
[KBM] Edit window should use ListView for displaying the mappings
|
We should use a similar ListView control as SettingsV2
|
Help Wanted,Product-Keyboard Shortcut Manager,Area-User Interface,Priority-1,Area-Accessibility,Cost-Medium,Status-Blocked,Issue-Task
|
medium
|
Critical
|
601,358,533 |
flutter
|
Slider DPAD support for Android TV
|
I am trying to use slider in a video player on Android TV app, testing on Nvidia Shield TV
just upgraded master, with the #53945 change i can now use the slider with remote d-pad, but there are some issues with DPAD on Android TV platform with remote dpad arrow keys:
- slider once focused can't unfocus / move to other widget buttons on screen...
- DPAD left and bottom rewinds, right and top forwards but DPAD could be left: rewind, right: forward, top and bottom moves to other widgets...
Also I think another enhancement would be great to add onPressed() to Slider.
use case is a video player where the slider button press pauses / plays video (this is how youtube android tv app functions..)
Thanks !!
related:
https://github.com/flutter/flutter/pull/53945
|
c: new feature,framework,engine,f: material design,a: accessibility,c: proposal,P3,team-design,triaged-design
|
low
|
Major
|
601,361,750 |
rust
|
Tracking Issue for `wasi_ext`
|
<!--
Thank you for creating a tracking issue! π Tracking issues are for tracking a
feature from implementation to stabilisation. Make sure to include the relevant
RFC for the feature if it has one. Otherwise provide a short summary of the
feature and link any relevant PRs or issues, and remove any sections that are
not relevant to the feature.
Remember to add team labels to the tracking issue.
For a language team feature, this would e.g., be `T-lang`.
Such a feature should also be labeled with e.g., `F-my_feature`.
This label is used to associate issues (e.g., bugs and design questions) to the feature.
-->
The feature gate for the issue is `#![feature(wasi_ext)]`.
### About tracking issues
Tracking issues are used to record the overall progress of implementation.
They are also uses as hubs connecting to other relevant issues, e.g., bugs or open design questions.
A tracking issue is however *not* meant for large scale discussion, questions, or bug reports about a feature.
Instead, open a dedicated issue for the specific matter and add the relevant feature gate label.
### Steps
<!--
Include each step required to complete the feature. Typically this is a PR
implementing a feature, followed by a PR that stabilises the feature. However
for larger features an implementation could be broken up into multiple PRs.
-->
- [ ] Adjust documentation ([see instructions on rustc-dev-guide][doc-guide])
- [ ] Stabilization PR ([see instructions on rustc-dev-guide][stabilization-guide])
[stabilization-guide]: https://rustc-dev-guide.rust-lang.org/stabilization_guide.html#stabilization-pr
[doc-guide]: https://rustc-dev-guide.rust-lang.org/stabilization_guide.html#documentation-prs
### Unresolved Questions
<!--
Include any open questions that need to be answered before the feature can be
stabilised.
-->
When should this be stabilized? Is wasi as a specification stable enough for wasi-specific APIs to be included in std?
### Implementation history
#59619
|
T-libs-api,B-unstable,O-wasm,C-tracking-issue,Libs-Tracked
|
low
|
Critical
|
601,362,693 |
pytorch
|
Custom class type name is very wordy
|
Right now, I have to write:
```
m.def("take_an_instance(__torch__.torch.classes._TorchScriptTesting._PickleTester x) -> Tensor Y", take_an_instance);
```
(taken from `test_custom_class`.). This is pretty wordy. It would be better if it was shorter.
cc @suo @smessmer @jamesr66a
|
oncall: jit,triaged
|
low
|
Minor
|
601,400,530 |
youtube-dl
|
Proxer.me
|
<!--
######################################################################
WARNING!
IGNORING THE FOLLOWING TEMPLATE WILL RESULT IN ISSUE CLOSED AS INCOMPLETE
######################################################################
-->
## Checklist
<!--
Carefully read and work through this check list in order to prevent the most common mistakes and misuse of youtube-dl:
- First of, make sure you are using the latest version of youtube-dl. Run `youtube-dl --version` and ensure your version is 2020.03.24. If it's not, see https://yt-dl.org/update on how to update. Issues with outdated version will be REJECTED.
- Make sure that all provided video/audio/playlist URLs (if any) are alive and playable in a browser.
- Make sure that site you are requesting is not dedicated to copyright infringement, see https://yt-dl.org/copyright-infringement. youtube-dl does not support such sites. In order for site support request to be accepted all provided example URLs should not violate any copyrights.
- Search the bugtracker for similar site support requests: http://yt-dl.org/search-issues. DO NOT post duplicates.
- Finally, put x into all relevant boxes (like this [x])
-->
- [x ] I'm reporting a new site support request
- [x ] I've verified that I'm running youtube-dl version **2020.03.24**
- [x ] I've checked that all provided URLs are alive and playable in a browser
- [ x] I've checked that none of provided URLs violate any copyrights
- [ x] I've searched the bugtracker for similar site support requests including closed ones
## Example URLs
<!--
Provide all kinds of example URLs support for which should be included. Replace following example URLs by yours.
-->
- Single video: https://proxer.me/watch/32071/1/engsub
- Single Video: https://proxer.me/watch/4167/1/engsub
## Description
<!--
Provide any additional information.
If work on your issue requires account credentials please provide them or explain how one can obtain them.
-->
If you login you see the embeded Video of the Proxer Stream and i would like to download them..
|
site-support-request
|
low
|
Critical
|
601,413,889 |
opencv
|
JS: Easier access to opencv.js file
|
##### System information (version)
n/a
##### Detailed description
Feature request for lowering the barrier to entry for adopting OpenCV.js by providing an official prebuilt `opencv.js` file.
I am currently involved in a project to introduce new coders to libraries like OpenCV.js. The target audience are new coders who are primarily familiar with JavaScript.
While I have managed to follow the steps to utilize Emscripten to build `opencv.js`, I feel that the steps remain a little intimidating for novices.
I am not clear if this is solely dependent on the efforts in #15315.
Or if it can be a zipped resource on the project website or hosted in a GitHub repo.
##### Steps to reproduce
- Visit [OpenCV.js tutorials](https://docs.opencv.org/4.3.0/df/df7/tutorial_js_table_of_contents_setup.html)
- Expected: download link, GitHub repo, or npm package for opencv.js
- Actual: Emscripten build steps that require environment configuration or Docker configuration
##### Issue submission checklist
- [x] I report the issue, it's not a question
- [x] I checked the problem with documentation, FAQ, open issues,
answers.opencv.org, Stack Overflow, etc and have not found solution
- [x] I updated to latest OpenCV version and the issue is still there
- [ ] There is reproducer code and related data files: videos, images, onnx, etc
|
category: javascript (js)
|
low
|
Minor
|
601,416,377 |
pytorch
|
return_index option for torch.unique
|
## π Feature
`return_index` option for [torch.unique](https://pytorch.org/docs/stable/torch.html#torch.unique) which behaves like [numpy.unique](https://docs.scipy.org/doc/numpy/reference/generated/numpy.unique.html).
I have a tensor `a = [10, 20, 10, 30]` and a tensor `b = [100, 200, 100, 300]`.
I want to take the unique elements of `a` (`[10, 20, 30]`), but also get the corresponding elements of `b` (`[100, 200, 300]`). Having the above feature would allow me to use the return indices to index directly to `b` for this.
Is this on the roadmap? Or are there alternative ways of achieving this?
Thank you!
cc @mruberry @rgommers
|
triaged,enhancement,module: numpy,function request
|
medium
|
Critical
|
601,474,072 |
material-ui
|
[material-ui][docs] Add Accessibility section to all component demo pages
|
- [x] I have searched the [issues](https://github.com/mui-org/material-ui/issues) of this repository and believe that this is not a duplicate.
## Summary π‘
Many components' documentation contains an Accessibility section that tells you how to make sure your components are Accessible, but some components don't contain this section.
For the sections that don't contain Accessibility, it isn't clear if that means that the component is accessible without any special measures, or if it isn't accessible at all.
It would be helpful if each component had an Accessibility section that says which is the case:
* Component is accessible without extra work.
* Component requires special measures to make accessible.
* Component is not accessible.
## Examples π
See
https://material-ui.com/components/tables/#accessibility
vs
https://material-ui.com/components/popper/
## Motivation π¦
I want to make sure I only use accessible components in my development.
|
docs,accessibility,package: material-ui,enhancement
|
low
|
Major
|
601,504,401 |
rust
|
Feature Request: saturating_add(Duration) for SystemTime / Instant
|
Both `SystemTime` and `Instant` have `checked_add(Duration)`, but no `saturating_add(Duration)`.
This seems like an omission, as when doing math operations on time, a developer has to choose between:
1. allowing for the (hopefully very remote) potential for overflows
1. determining what to do with the `None` case of the `checked_add()`
1. letting it `checked_add(long_duration).unwrap()` panic after an overflow
Given that the `SystemTime` and `Instant` both opaquely wrap a platform-dependent structure, it's not clear what "far future" values are valid on a given platform (e.g. issue #44394), and what values a developer could correctly use with `checked_add(long_duration).unwrap_or(...?)`.
|
T-libs-api,C-feature-request,A-time
|
low
|
Major
|
601,512,485 |
godot
|
Multiple selection reimport with different 'import as' not working
|
**Godot version:**
3.2.1
**OS/device including version:**
Windows 10.
**Issue description:**
If you multi-select pngs and change the 'import as' type and hit 'reimport' it will ignore the new type selected.
**Steps to reproduce:**
Duplicate icon.png in an empty project, select both icons, change 'import as' to 'bitmap' for example and hit reimport. It will be imported as texture when the editor reopens.
PD: It doesn't make a difference that icon.png is not black&white.
**Minimal reproduction project:**
|
bug,topic:editor,topic:import
|
low
|
Minor
|
601,523,193 |
pytorch
|
When you try to register a kernel that make boxed from unboxed functor doesn't support you get a horrible error message
|
Here's what you get if you try to register a `aten::resize_` kernel without unboxed only
```
In file included from ../aten/src/ATen/core/boxing/KernelFunction_impl.h:2, [218/92024]
from ../aten/src/ATen/core/boxing/KernelFunction.h:216, from ../aten/src/ATen/core/dispatch/DispatchTable.h:9, from ../aten/src/ATen/core/dispatch/OperatorEntry.h:3,
from ../aten/src/ATen/core/dispatch/Dispatcher.h:3, from aten/src/ATen/core/TensorMethods.h:10, from ../aten/src/ATen/Tensor.h:12, from ../aten/src/ATen/Context.h:4,
from ../aten/src/ATen/ATen.h:5, from ../aten/src/ATen/native/quantized/cpu/tensor_operators.cpp:1: ../aten/src/ATen/core/boxing/impl/make_boxed_from_unboxed_functor.h: In instantiation of βstatic void c10::impl::m
ake_boxed_from_unboxed_functor<KernelFunctor, AllowDeprecatedTypes, typename std::enable_if<(! std::is_same<void,
typename c10::guts::infer_function_traits<Functor>::type::return_type>::value), void>::type>::call(c10::OperatorKernel*, const c10::OperatorHandle&, c10::Stack*) [with KernelFunctor = c10::impl::detail::WrapFunctionIntoRuntimeFu
nctor_<at::Tensor& (*)(at::Tensor&, c10::ArrayRef<long int>, c10::optional<c10::MemoryFormat>), at::Tensor&, c10::
guts::typelist::typelist<at::Tensor&, c10::ArrayRef<long int>, c10::optional<c10::MemoryFormat> > >; bool AllowDep
recatedTypes = false; c10::Stack = std::vector<c10::IValue>]β: ../aten/src/ATen/core/boxing/KernelFunction_impl.h:87:9: required from βstatic c10::KernelFunction c10::KernelFu
nction::makeFromUnboxedFunctor(std::unique_ptr<c10::OperatorKernel>) [with bool AllowLegacyTypes = false; KernelFu
nctor = c10::impl::detail::WrapFunctionIntoRuntimeFunctor_<at::Tensor& (*)(at::Tensor&, c10::ArrayRef<long int>, c
10::optional<c10::MemoryFormat>), at::Tensor&, c10::guts::typelist::typelist<at::Tensor&, c10::ArrayRef<long int>,
c10::optional<c10::MemoryFormat> > >]β
../aten/src/ATen/core/boxing/KernelFunction_impl.h:138:114: required from βstatic c10::KernelFunction c10::Kerne
lFunction::makeFromUnboxedRuntimeFunction(FuncType*) [with bool AllowLegacyTypes = false; FuncType = at::Tensor&(a
t::Tensor&, c10::ArrayRef<long int>, c10::optional<c10::MemoryFormat>)]β
../aten/src/ATen/core/op_registration/op_registration.h:655:64: required from βc10::CppFunction::CppFunction(Fun
c*, std::enable_if_t<c10::guts::is_function_type<FuncType>::value, std::nullptr_t>) [with Func = at::Tensor&(at::T
ensor&, c10::ArrayRef<long int>, c10::optional<c10::MemoryFormat>); std::enable_if_t<c10::guts::is_function_type<F
uncType>::value, std::nullptr_t> = std::nullptr_t]β
../aten/src/ATen/core/op_registration/op_registration.h:886:17: required from βc10::Library& c10::Library::impl(
const char*, Func&&) & [with Func = at::Tensor& (&)(at::Tensor&, c10::ArrayRef<long int>, c10::optional<c10::MemoryFormat>)]β
../aten/src/ATen/native/quantized/cpu/tensor_operators.cpp:83:42: required from here
../aten/src/ATen/core/boxing/impl/make_boxed_from_unboxed_functor.h:253:115: error: cannot bind non-const lvalue r
eference of type βat::Tensor&β to an rvalue of type βstd::remove_reference<at::Tensor&>::typeβ {aka βat::Tensorβ}
push_outputs<typename guts::infer_function_traits_t<KernelFunctor>::return_type, AllowDeprecatedTypes>::call(std::move(output), stack);
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
~^~~~~~~~~~~~~~~~~~~~~~~~~~
../aten/src/ATen/core/boxing/impl/make_boxed_from_unboxed_functor.h:224:17: note: initializing argument 1 of βst
atic void c10::impl::push_outputs<OutputType, AllowDeprecatedTypes>::call(OutputType&&, c10::Stack*) [with OutputT
ype = at::Tensor&; bool AllowDeprecatedTypes = false; c10::Stack = std::vector<c10::IValue>]β
static void call(OutputType&& output, Stack* stack) {
^~~~
../aten/src/ATen/core/boxing/impl/make_boxed_from_unboxed_functor.h: In instantiation of βstatic void c10::impl::p
ush_outputs<OutputType, AllowDeprecatedTypes>::call(OutputType&&, c10::Stack*) [with OutputType = at::Tensor&; boo
l AllowDeprecatedTypes = false; c10::Stack = std::vector<c10::IValue>]β:
../aten/src/ATen/core/boxing/impl/make_boxed_from_unboxed_functor.h:253:115: required from βstatic void c10::imp
l::make_boxed_from_unboxed_functor<KernelFunctor, AllowDeprecatedTypes, typename std::enable_if<(! std::is_same<vo
id, typename c10::guts::infer_function_traits<Functor>::type::return_type>::value), void>::type>::call(c10::Operat
orKernel*, const c10::OperatorHandle&, c10::Stack*) [with KernelFunctor = c10::impl::detail::WrapFunctionIntoRunti
meFunctor_<at::Tensor& (*)(at::Tensor&, c10::ArrayRef<long int>, c10::optional<c10::MemoryFormat>), at::Tensor&, c
10::guts::typelist::typelist<at::Tensor&, c10::ArrayRef<long int>, c10::optional<c10::MemoryFormat> > >; bool Allo
wDeprecatedTypes = false; c10::Stack = std::vector<c10::IValue>]β
```
This issue is probably not quite mooted if we support everything, because there still might be cases where a user will pass in an argument we don't understand.
cc @smessmer
|
triaged
|
low
|
Critical
|
601,538,435 |
pytorch
|
Clearer guidance on when to define an operator as a method on torchbind'ed class versus standalone function
|
I noticed in the xnnpack binding code that there was a bunch of stuff like this:
```
.op("prepacked::linear_clamp_run(Tensor X,"
" __torch__.torch.classes.xnnpack.LinearOpContext W_prepack) -> Tensor Y",
torch::RegisterOperators::options()
.aliasAnalysis(at::AliasAnalysisKind::PURE_FUNCTION)
.kernel<internal::linear::LinearClampRun>(
DispatchKey::CPU))
```
then the implementation of LinearClampRun is
```
Tensor LinearClampRun::operator()(
const Tensor& input,
const c10::intrusive_ptr<xnnpack::LinearOpContext>& op_context) {
return op_context->run(input);
}
```
To me, this screams like `run` should have been a method on `LinearOpContext`. It is not, per the torchbind:
```
torch::jit::class_<LinearOpContext> register_packed_linear_op_context_class() {
static auto register_linear_op_context_class =
torch::jit::class_<LinearOpContext>("xnnpack", "LinearOpContext")
.def_pickle(
[](const c10::intrusive_ptr<LinearOpContext>& op_context)
-> SerializationTypeLinearPrePack { // __getstate__
return op_context->unpack();
},
[](SerializationTypeLinearPrePack state)
-> c10::intrusive_ptr<LinearOpContext> { // __setstate__
return createLinearClampPrePackOpContext(
std::move(std::get<0>(state)),
std::move(std::get<1>(state)),
std::move(std::get<2>(state)),
std::move(std::get<3>(state)));
});
return register_linear_op_context_class;
```
Should it be a method? Is there some reason it was written as a function here?
cc @jamesr66a @kimishpatel
|
triaged
|
low
|
Major
|
601,543,466 |
flutter
|
Directional navigation key binding defaults should be limited to those platforms that use it.
|
<!-- Thank you for using Flutter!
If you are looking for support, please check out our documentation
or consider asking a question on Stack Overflow:
* https://flutter.dev/
* https://api.flutter.dev/
* https://stackoverflow.com/questions/tagged/flutter?sort=frequent
If you have found a bug or if our documentation doesn't have an answer
to what you're looking for, then fill our the template below. Please read
our guide to filing a bug first: https://flutter.dev/docs/resources/bug-reports
-->
When running the fluter devtools on macos, I'm seeing strange key handling behavior. There are extra key actions that I don't see on flutter web. Some discussion of the issue, with screenshots, is at https://github.com/flutter/devtools/issues/1769. But essentially:
I'm adding row selection and keyboard navigation to a custom widget TreeTable ([built here](https://github.com/flutter/devtools/blob/ae483b098ec65941f457bf545bdc9059f6537231/packages/devtools_app/lib/src/flutter/table.dart#L363)). I'm explicitly [handling the arrow up/down keys](https://github.com/flutter/devtools/blob/ae483b098ec65941f457bf545bdc9059f6537231/packages/devtools_app/lib/src/flutter/table.dart#L427) to move the selection and scroll the view. But on macos I see scrolling that is not caused by my handler, and also a kind of ghost selected row (see the screenshots in https://github.com/flutter/devtools/issues/1769) not caused by me (the color is different than the one I am using). Also, sometimes after clicking on a row the arrow keys will start cycling through the top-level tabs (Inspector, timeline) instead of the rows in the table.
In a nutshell there is some code handling the up/down arrow keys in a way that I don't understand, can't control, and can't predict. It also does not happen when I run via flutter web which leads me to believe it's a bug in the macos platform code.
The PR that introduced keyboard navigation is here: https://github.com/flutter/devtools/pull/1810
## Steps to Reproduce
$git clone [email protected]:flutter/devtools.git
$cd devtools/packages/devtools_app
$flutter run -d macos
1. Enter the url of another running flutter app
2. Click on the "info" tab
3. Click "performance"
4. Record performance data
5. Click on the "call tree" tab
6. Click inside the call tree table
7. navigate up/down with the arrow keys.
8. Compare with the behavior when running with `-d web`
**Expected results:** <!-- what did you want to see? -->
I expect the arrow up/down keys to cause the window to scroll only when the selection reaches the bottom or top of the viewport. I expect there to be only 1 selected row. I expect that pressing the arrow up/down keys should not escape the treetable and start cycling the top-level tabs of the viewport.
**Actual results:** <!-- what did you see? -->
See the examples at https://github.com/flutter/devtools/issues/1769
<details>
<summary>Logs</summary>
<!--
Run your application with `flutter run --verbose` and attach all the
log output below between the lines with the backticks. If there is an
exception, please see if the error message includes enough information
to explain how to solve the issue.
-->
```
I captured the logs, but they're really verbose (1600 lines). LMK if there is a better way to provide them besides pasting the whole thing into this issue.
```
<!--
Run `flutter analyze` and attach any output of that command below.
If there are any analysis errors, try resolving them before filing this issue.
-->
```
gmoothart-macbookpro2:devtools_app gmoothart$ flutter analyze
Analyzing devtools_app...
warning β’ The include file ../../analysis_options.yaml in /Users/gmoothart/dev/devtools/packages/devtools_app/analysis_options.yaml cannot be found β’
analysis_options.yaml:1:11 β’ include_file_not_found
info β’ Prefer declaring const constructors on `@immutable` classes β’ bug/lib/main.dart:35:3 β’ prefer_const_constructors_in_immutables
info β’ Prefer const with constant constructors β’ bug/lib/main.dart:100:13 β’ prefer_const_constructors
info β’ Prefer const with constant constructors β’ bug/lib/main.dart:113:16 β’ prefer_const_constructors
4 issues found. (ran in 20.1s)
```
<!-- Finally, paste the output of running `flutter doctor -v` here. -->
```
gmoothart-macbookpro2:devtools_app gmoothart$ flutter doctor -v
[β] Flutter (Channel master, v1.18.0-6.0.pre.51, on Mac OS X 10.15.3 19D76, locale en-US)
β’ Flutter version 1.18.0-6.0.pre.51 at /Users/gmoothart/dev/flutter
β’ Framework revision 20803507fd (3 minutes ago), 2020-04-16 14:36:42 -0700
β’ Engine revision deef2663ac
β’ Dart version 2.8.0 (build 2.8.0-dev.20.0 c9710e5059)
[β] Android toolchain - develop for Android devices
β Unable to locate Android SDK.
Install Android Studio from: https://developer.android.com/studio/index.html
On first launch it will assist you in installing the Android SDK components.
(or visit https://flutter.dev/docs/get-started/install/macos#android-setup for detailed instructions).
If the Android SDK has been installed to a custom location, set ANDROID_SDK_ROOT to that location.
You may also want to add it to your PATH environment variable.
[β] Xcode - develop for iOS and macOS (Xcode 11.4)
β’ Xcode at /Applications/Xcode.app/Contents/Developer
β’ Xcode 11.4, Build version 11E146
β’ CocoaPods version 1.9.1
[β] Chrome - develop for the web
β’ Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome
[!] Android Studio (not installed)
β’ Android Studio not found; download from https://developer.android.com/studio/index.html
(or visit https://flutter.dev/docs/get-started/install/macos#android-setup for detailed instructions).
[β] IntelliJ IDEA Community Edition (version 2019.3.4)
β’ IntelliJ at /Applications/IntelliJ IDEA CE.app
β’ Flutter plugin version 44.0.3
β’ Dart plugin version 193.6911.31
[β] VS Code (version 1.43.2)
β’ VS Code at /Applications/Visual Studio Code.app/Contents
β’ Flutter extension version 3.4.1
[β] Connected device (3 available)
β’ macOS β’ macOS β’ darwin-x64 β’ Mac OS X 10.15.3 19D76
β’ Chrome β’ chrome β’ web-javascript β’ Google Chrome 80.0.3987.163
β’ Web Server β’ web-server β’ web-javascript β’ Flutter Tools
! Doctor found issues in 2 categories.
```
</details>
|
framework,platform-mac,a: desktop,d: devtools,P2,team-text-input,triaged-text-input
|
low
|
Critical
|
601,557,500 |
material-ui
|
[Autocomplete] unexpectly changes field value on mouse hover
|
<!-- Provide a general summary of the issue in the Title above -->
An `Autocomplete` component with `freeSolo` and `autoSelect` changes the field value by simply hovering the mouse over the dropdown menu and then bluring the field.
<!--
Thank you very much for contributing to Material-UI by creating an issue! β€οΈ
To avoid duplicate issues we ask you to check off the following list.
-->
<!-- Checked checkbox should look like this: [x] -->
- [X] The issue is present in the latest release.
- [X] I have searched the [issues](https://github.com/mui-org/material-ui/issues) of this repository and believe that this is not a duplicate.
## Current Behavior π―
<!-- Describe what happens instead of the expected behavior. -->
The problem is illustrated in this sandbox: https://codesandbox.io/s/trusting-dewdney-cvj7ss?file=/src/App.js
In the first field, click the popup arrow icon to open the dropdown menu, then hover the mouse down such that menu items are successively highlighted. Continue to move mouse down outside of the menu area and click anywhere to blur the field.
The field value (and associated state) will be changed to the last menu item that was hovered (and highlighted).
## Expected Behavior π€
<!-- Describe what should happen. -->
As the user hasn't made any selection in the dropdown menu, the field value shouldn't change.
## Context π¦
<!--
What are you trying to accomplish? How has this issue affected you?
Providing context helps us come up with a solution that is most useful in the real world.
-->
The use case is to create a free text entry with a set of suggested values for quick entry.
## Your Environment π
<!--
Include as many relevant details about the environment with which you experienced the bug.
If you encounter issues with typescript please include version and tsconfig.
-->
| Tech | Version |
| ----------- | ------- |
| Material-UI | v4.9.10 |
| Material-UI lab | v4.0.0-alpha.49 |
| React | 16.12.0 |
|
bug π,component: autocomplete,ready to take
|
medium
|
Critical
|
601,575,937 |
rust
|
Error bootstrapping on CentOS
|
It looks like the bootstrapper does not use `cmake3` on CentOS (i.e., CMake 3.x) but instead `cmake` (i.e., version 2.x). This results in the error `CMake 3.4.3 or higher is required. You are running version 2.8.12.2`. The fix would seem to be obvious: check for `cmake3` before falling back to `cmake`.
Relevant section of console output:
```
Finished release [optimized + debuginfo] target(s) in 49.26s
Copying stage0 std from stage0 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
Building LLVM for x86_64-unknown-linux-gnu
running: "cmake" "/home/alexreg/src/rust-devel/trait-upcasting/src/llvm-project/llvm" "-DLLVM_ENABLE_ASSERTIONS=ON" "-DLLVM_TARGETS_TO_BUILD=AArch64;ARM;Hexagon;MSP430;Mips;NVPTX;PowerPC;RISCV;Sparc;SystemZ;WebAssembly;X86" "-DLLVM_EXPERIMENTAL_TARGETS_TO_BUILD=" "-DLLVM_INCLUDE_EXAMPLES=OFF" "-DLLVM_INCLUDE_TESTS=OFF" "-DLLVM_INCLUDE_DOCS=OFF" "-DLLVM_INCLUDE_BENCHMARKS=OFF" "-DLLVM_ENABLE_ZLIB=OFF" "-DWITH_POLLY=OFF" "-DLLVM_ENABLE_TERMINFO=OFF" "-DLLVM_ENABLE_LIBEDIT=OFF" "-DLLVM_ENABLE_BINDINGS=OFF" "-DLLVM_ENABLE_Z3_SOLVER=OFF" "-DLLVM_PARALLEL_COMPILE_JOBS=32" "-DLLVM_TARGET_ARCH=x86_64" "-DLLVM_DEFAULT_TARGET_TRIPLE=x86_64-unknown-linux-gnu" "-DLLVM_LINK_LLVM_DYLIB=ON" "-DLLVM_ENABLE_LIBXML2=OFF" "-DLLVM_VERSION_SUFFIX=-rust-dev" "-DPYTHON_EXECUTABLE=/usr/bin/python" "-DCMAKE_INSTALL_MESSAGE=LAZY" "-DCMAKE_C_COMPILER=cc" "-DCMAKE_CXX_COMPILER=c++" "-DCMAKE_C_FLAGS=-ffunction-sections -fdata-sections -fPIC -m64" "-DCMAKE_CXX_FLAGS=-ffunction-sections -fdata-sections -fPIC -m64" "-DCMAKE_INSTALL_PREFIX=/home/alexreg/src/rust-devel/trait-upcasting/build/x86_64-unknown-linux-gnu/llvm" "-DCMAKE_BUILD_TYPE=Release"
CMake Error at CMakeLists.txt:3 (cmake_minimum_required):
CMake 3.4.3 or higher is required. You are running version 2.8.12.2
-- Configuring incomplete, errors occurred!
thread 'main' panicked at '
command did not execute successfully, got: exit code: 1
build script failed, must exit now', /home/alexreg/.cargo/registry/src/github.com-1ecc6299db9ec823/cmake-0.1.42/src/lib.rs:861:5
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
finished in 0.027
failed to run: /home/alexreg/src/rust-devel/trait-upcasting/build/bootstrap/debug/bootstrap -i test src/test/ui/traits/trait-upcasting
Build completed unsuccessfully in 0:01:59
```
|
O-linux,T-bootstrap,C-bug
|
low
|
Critical
|
601,609,174 |
rust
|
Don't generate unnecessary cleanup blocks for calls that cannot unwind
|
Per @nagisa [here](https://github.com/rust-lang/rust/pull/70467#discussion_r409245992):
> Cleanup blocks should not be reach codegen in the first place for calls of functions that cannot unwind. This can happen either during MIR construction or afterwards in some clean-up pass.
|
C-enhancement,T-compiler,A-MIR
|
low
|
Minor
|
601,613,443 |
go
|
cmd/gofmt: inconsistent indentation with comments in switch
|
### What version of Go are you using (`go version`)?
<pre>
$ go version
go version go1.14.2 linux/amd64
</pre>
### Does this issue reproduce with the latest release?
yes, also in the playground
### What operating system and processor architecture are you using (`go env`)?
<details><summary><code>go env</code> Output</summary><br><pre>
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/arccy/.cache/go-build"
GOENV="/home/arccy/.config/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/home/arccy/data/xdg/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/lib/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/lib/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="/home/arccy/testrepo-82/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build346952514=/tmp/go-build -gno-record-gcc-switches"
</pre></details>
### What did you do?
write inconsistently indented code/comments in a switch
https://play.golang.org/p/QWIBPjclreK
```go
package main
func a() {
switch "" {
case "a":
// a comment
case "b":
}
}
func b() {
switch "" {
case "a":
// a comment
case "b":
}
}
```
### What did you expect to see?
consistently indented comments
```go
package main
func a() {
switch "" {
case "a":
// a comment
case "b":
}
}
func b() {
switch "" {
case "a":
// a comment
case "b":
}
}
```
### What did you see instead?
```go
package main
func a() {
switch "" {
case "a":
// a comment
case "b":
}
}
func b() {
switch "" {
case "a":
// a comment
case "b":
}
}
```
### observations
this does not happen when the comment and the case below it are indented by the same number of whitespace characters, so the below formats properly
```go
package main
func a() {
switch "" {
case "a":
// leading single space
case "b": // leading tab
}
}
```
|
NeedsInvestigation
|
low
|
Critical
|
601,629,962 |
youtube-dl
|
When meta data is added to the video, channel URL and Video URL should be added as well.
|
If you look up a video's details on windows 7(My OS) there's a Author URL, and a Promotion URL data field.
The Author's URL could be the Youtube Channel's URL address, and the Promotion URL could be the video's URL link.
|
request
|
low
|
Minor
|
601,641,602 |
TypeScript
|
"Find all references" not working for JSDoc @callback
|
*TS Template added by @mjbvz*
**TypeScript Version**: 3.8.3
**Search Terms**
- jsdoc
- find all references
---
Issue Type: <b>Bug</b>
**Steps to reproduce**
Create file called Interfaces.js with the following content:
```
/**
* @typedef {Object} Config
* @property {String} Title
* @property {String} Description
*/
/**
* @callback RequestCallback
* @param {any} json
*/
```
Create a file called index.js which consumes the types from Interfaces.js:
```
/** @typedef {import("./Interfaces").Config} Config */
/** @typedef {import("./Interfaces").RequestCallback} Callback */
```
Make sure both files have been saved to the same folder.
Now right-click the _Config_ type in Interfaces.js and click "Find all references". It works.
Right-click the RequestCallback type in interfaces.js and click "Find all references". It does NOT return any matches, even though we obviously have one.
VS Code version: Code 1.44.1 (a9f8623ec050e5f0b44cc8ce8204a1455884749f, 2020-04-11T01:47:00.296Z)
OS version: Darwin x64 18.7.0
<details>
<summary>System Info</summary>
|Item|Value|
|---|---|
|CPUs|Intel(R) Core(TM) i7-4770HQ CPU @ 2.20GHz (8 x 2200)|
|GPU Status|2d_canvas: enabled<br>flash_3d: enabled<br>flash_stage3d: enabled<br>flash_stage3d_baseline: enabled<br>gpu_compositing: enabled<br>metal: disabled_off<br>multiple_raster_threads: enabled_on<br>oop_rasterization: disabled_off<br>protected_video_decode: unavailable_off<br>rasterization: enabled<br>skia_renderer: disabled_off_ok<br>video_decode: enabled<br>viz_display_compositor: enabled_on<br>viz_hit_test_surface_layer: disabled_off_ok<br>webgl: enabled<br>webgl2: enabled|
|Load (avg)|2, 2, 2|
|Memory (System)|16.00GB (2.08GB free)|
|Process Argv||
|Screen Reader|no|
|VM|0%|
</details><details><summary>Extensions (6)</summary>
Extension|Author (truncated)|Version
---|---|---
vscode-eslint|dba|2.1.3
php-debug|fel|1.13.0
php-intellisense|fel|2.3.14
phpcs|ika|1.0.5
php-docblocker|nei|2.1.0
vscode-graphql|Pri|0.2.14
</details>
<!-- generated by issue reporter -->
|
Bug
|
low
|
Critical
|
601,648,980 |
TypeScript
|
Refactorings can change formatting of multiline parameter lists
|
<!-- π¨ STOP π¨ π¦π§π’π£ π¨ πΊπ»πΆπ· π¨
Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Even if you think you've found a *bug*, please read the FAQ first, especially the Common "Bugs" That Aren't Bugs section!
Please help us by doing the following steps before logging an issue:
* Search: https://github.com/Microsoft/TypeScript/search?type=Issues
* Read the FAQ: https://github.com/Microsoft/TypeScript/wiki/FAQ
Please fill in the *entire* template below.
-->
<!--
Please try to reproduce the issue with the latest published version. It may have already been fixed.
For npm: `typescript@next`
This is also the 'Nightly' version in the playground: http://www.typescriptlang.org/play/?ts=Nightly
-->
**TypeScript Version:** 3.7.x-dev.201xxxxx
<!-- Search terms you tried before logging this (so others can find this issue more easily) -->
**Search Terms:**
- refactor / refactoring
**Code**
For the TS:
```ts
const Foo = class {
constructor(
private readonly a = 1,
) {
// noop
}
}
```
1. Select the entire class and run `extract to function`
(this bug also happens with normal classes using `move to new file`)
**Bug:**
The new class changes the formatting by putting the closing `)` of the constructor on the same line:
```ts
const Foo = newFunction()
function newFunction() {
return class {
constructor(
private readonly a = 1) {
}
};
}
```
We use multiline constructor parameter lists fairly heavily in VS Code so we often hit this when we use the `move to new file` refactoring
|
Bug,Domain: Refactorings
|
low
|
Critical
|
601,680,463 |
vscode
|
Add support for `font-stretch`
|
<!-- β οΈβ οΈ Do Not Delete This! bug_report_template β οΈβ οΈ -->
<!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ -->
<!-- Please search existing issues to avoid creating duplicates. -->
<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: https://code.visualstudio.com/insiders/ -->
<!-- Use Help > Report Issue to prefill these. -->
- VSCode Version: 1.44.1
- OS Version: windows_NT x64 10.0.18363
Steps to Reproduce:
1. set font is iosevka extended (it is Monospaced font),
2. it not Monospaced font in display.
<!-- Launch with `code --disable-extensions` to check. -->
Does this issue occur when all extensions are disabled?: Yes/No
yes
p.s.: [iosevka](https://github.com/be5invis/Iosevka)
|
feature-request,font-rendering
|
high
|
Critical
|
601,756,774 |
pytorch
|
[1.4.1] Intel MPI libs not found.
|
When try to build using the Intel MKL and MPI libs, only the MKL part is found and used.
[log.zip](https://github.com/pytorch/pytorch/files/4491496/log.zip)
Here the build logs.
cc @gujinghui @PenghuiCheng @XiaobingSuper @jianyuh
|
module: build,triaged,module: mkldnn
|
low
|
Minor
|
601,938,563 |
rust
|
perf slowdown from #70831 (remove a stack frame from .await calls)
|
Post-merge [perf results](https://perf.rust-lang.org/compare.html?start=534a41a32952d36ec73656357777ebbea707aeb4&end=4e4d49d60fd696c4036d438292673a2d7fd34519&stat=instructions:u) are 100% restricted to `await-call-tree`, and it's more clearly >1% now, post-https://github.com/rust-lang/rustc-perf/pull/645 (cc @Mark-Simulacrum).
Presumably we consider that test a stress test and we're fine with the 1-5% slowdown?
cc @rust-lang/wg-async-foundations
_Originally posted by @eddyb in https://github.com/rust-lang/rust/pull/70831#issuecomment-614911483_
|
P-medium,I-compiletime,T-compiler,A-async-await,AsyncAwait-Triaged
|
low
|
Major
|
601,976,939 |
create-react-app
|
[eslint-config-react-app] Recommended way of config integration with ESLint, TypeScript, Prettier and VS Code
|
<!--
Provide a clear and concise description of what the problem is.
For example, "I'm always frustrated when..."
-->
People use VS Code a lot. It is also recommended in the docs, but it is not explained on how to configure it together with ESLint, Prettier & TypeScript together with `eslint-config-react-app`.
Every two months there is a new Medium article for this topic, as the configuration/dependencies always change. Wouldn't it be nice if CRA had an official documentation on how to integrate all these with a step-by-step tutorial on the CRA website?
### Describe the solution you'd like
<!--
Provide a clear and concise description of what you want to happen.
-->
I would like the [docs](https://create-react-app.dev/docs/setting-up-your-editor) to provide all the steps needed to integrate `eslint-config-react-app` and the additional features in their development setup.
Two major parts:
- What do I need to configure manually in the files of my CRA project? (e. g. `.eslintrc.js`)
Do I need additional dependencies? How to integrate other ESLint plugins?
- What do I need to configure manually in my VS Code setup? (e. g. for the ESLint plugin (`dbaeumer.vscode-eslint` or the Prettier plugin)
Possible combinations that are most common:
| No. | CRA dependencies | eslint-config-react-app | Prettier | TypeScript |
|-----|-----|-------------------------|----------|------------|
| 1 | x | x | | |
| 2 | x | x | x | |
| 3 | x | x | x | x |
For ESLint and Prettier, there should be an explanation not only how to combine the configurations, but also on how to actually use the configuration in VS Code. Also, when using Prettier, you need to make sure that its rules don't conflict with ESLint rules.
The following is the configuration I'm running with right now for ESLint + TypeScript + Prettier (thanks, @robertcoopercode):
```javascript
module.exports = {
parser: "@typescript-eslint/parser",
extends: [
"react-app", // Uses the recommended rules Create React App
"plugin:@typescript-eslint/recommended", // Uses the recommended rules from @typescript-eslint/eslint-plugin
"prettier/@typescript-eslint", // Uses eslint-config-prettier to disable ESLint rules from @typescript-eslint/eslint-plugin that would conflict with prettier
"plugin:prettier/recommended" // Should be last in the list. Enables eslint-plugin-prettier and eslint-config-prettier. This will display prettier errors as ESLint errors. Make sure this is always the last configuration in the extends array.
],
parserOptions: {
ecmaFeatures: {
jsx: true // Allows for the parsing of JSX
},
ecmaVersion: 2018, // Allows for the parsing of modern ECMAScript features
sourceType: "module" // Allows for the use of imports
},
rules: {},
settings: {
react: {
version: "detect" // Tells eslint-plugin-react to automatically detect the version of React to use
}
}
};
```
It's a hassle to keep all the configuration up to date and that, in my opinion, is what CRA should try to solve.
### Describe alternatives you've considered
<!--
Let us know about other solutions you've tried or researched.
-->
A possible alternative to requiring manual changes in the config files would be a CLI tool that automatically creates/modifies them. An explanation on how to integrate with VS Code would still be needed on the website though.
### UPDATE
[I decided to create a website on my own](https://github.com/facebook/create-react-app/issues/8849#issuecomment-683471144), feel free to check it out and contribute:
Website: [https://eslintconfig.dev](https://eslintconfig.dev)
Repo: [https://github.com/bennettdams/eslintconfig.dev](https://github.com/bennettdams/eslintconfig.dev)
|
issue: proposal,needs triage
|
high
|
Critical
|
601,980,581 |
godot
|
Need package/description check for UWP exports in can_export()
|
**Godot version:** Godot 3.2.1.stable Windows 64 (non-mono)
**OS/device including version:**
Microsoft Windows [Version 10.0.19041.207] (build 2004) 64bit
**Issue description:**
When creating a new export configuration for UWP, there are a number of fields that are indicated as required or invalid before you can export. Currently there is a discrepancy between these checks and reality, where you can not install a signed APPX file if the description length is 0. Therefore, there should be an additional check added to **platform/uwp/export/export.cpp:can_export()** that checks that the "package/description" field length is greater than zero.
**Steps to reproduce:**
1. Create a do nothing project with a single node scene. Create an export configuration that satisfies all the settings while keeping the description blank.
2. Export UWP/APPX
3. Sign the APPX with signtool as indicated by the Godot documentation
4. Install the APPX via Powershell: `Add-AppxPackage C:\path\project.appx`
This description requirement can be seen enforced (via XML schema verification) in the Powershell Add-AppxPackage cmdlet:
```
Add-AppxPackage : Deployment failed with HRESULT: 0x80080204, The Appx package's manifest is invalid.
error 0xC00CE169: App manifest validation error: The app manifest must be valid as per schema: Line 19, Column 147,
Reason: '' violates minLength constraint of '1'.
The attribute 'Description' with value '' failed to parse.
NOTE: For additional information, look for [ActivityId] 25eed3ef-1376-0005-5d5c-81267613d601 in the Event Log or use
the command line Get-AppPackageLog -ActivityID 25eed3ef-1376-0005-5d5c-81267613d601
At line:1 char:1
+ Add-AppxPackage C:\projects\playground\NullProject\NullProject.appx
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+ CategoryInfo : NotSpecified: (C:\projects\pla...ullProject.appx:String) [Add-AppxPackage], Exception
+ FullyQualifiedErrorId : DeploymentError,Microsoft.Windows.Appx.PackageManager.Commands.AddAppxPackageCommand
```
|
bug,topic:editor,topic:porting,platform:uwp
|
low
|
Critical
|
602,033,323 |
vue
|
In Firefox, radiobuttons with `required` and `v-model` are marked as invalid immediately
|
### Version
2.6.11
### Reproduction link
[https://jsfiddle.net/t1po5sdh/](https://jsfiddle.net/t1po5sdh/)
### Steps to reproduce
In Firefox 75.0, I get the two radio buttons marked as invalid (i.e. surrounded by a red border) immediately on pageload. This does not happen if I either remove `required` or `v-model`
### What is expected?
The radios should only be marked as invalid after form submission - as with other required input controls.
### What is actually happening?
See above
---
I've been observing this for years already.
<!-- generated by vue-issues. DO NOT REMOVE -->
|
browser quirks
|
medium
|
Minor
|
602,061,080 |
neovim
|
UX: ":edit *.js" should suggest :next
|
### Actual behaviour
When simply trying to edit some additional files I often type `:e *.js` or something similar; this almost ALWAYS results in `E77: Too many file names`.
### Expected behaviour
It's pretty clear what the user wants in this situation; they want to open the files as buffers! I'm sure there are legacy reasons for this error, but it's a pretty poor experience these days that probably doesn't need to stick around. (at least with `set hidden` enabled)
I've learned I can run `:next *.js` which has the behaviour I want, but `next` is a pretty unintuitive name and I don't really see a reason to have more than one command for this functionality.
In the worst case, perhaps we could simply add a note saying `Maybe you meant to use :next` to the error message? It took a bit of digging to find that solution and I'd love it if others didn't need to do the same.
Thanks for all your work everyone!
|
enhancement,complexity:low,core
|
low
|
Critical
|
602,071,044 |
pytorch
|
c++: error: unrecognized command line option '-Wthread-safety'
|
## π Bug
Attempting to build pytorch on RHEL7 using gcc 9.2.0 Get error
Run Build Command(s):/foo/miniconda3/bin/ninja cmTC_d3507
[1/2] Building CXX object CMakeFiles/cmTC_d3507.dir/src.cxx.o
FAILED: CMakeFiles/cmTC_d3507.dir/src.cxx.o
/foo/gcc/9.2.0/bin/c++ -Wno-deprecated -fvisibility-inlines-hidden -std=c++11 -Wall -Wextra -Wshadow -pedantic -pedantic-errors -Wfloat-equal -fstrict-aliasing -Wno-deprecated-declarations -Wstrict-aliasing -DHAVE_CXX_FLAG_WTHREAD_SAFETY -Wthread-safety -Wthread-safety -o CMakeFiles/cmTC_d3507.dir/src.cxx.o -c src.cxx
c++: error: unrecognized command line option '-Wthread-safety'
c++: error: unrecognized command line option '-Wthread-safety'
ninja: build stopped: subcommand failed.
## To Reproduce
Steps to reproduce the behavior:
1. gcc: 9.2.0
1. python: 3.7.5
1. conda: 4.8.3
1. Follow directions at https://github.com/pytorch/pytorch#from-source
1. python setup.py install
Run Build Command(s):/foo/miniconda3/bin/ninja cmTC_d3507
[1/2] Building CXX object CMakeFiles/cmTC_d3507.dir/src.cxx.o
FAILED: CMakeFiles/cmTC_d3507.dir/src.cxx.o
/foo/gcc/9.2.0/bin/c++ -Wno-deprecated -fvisibility-inlines-hidden -std=c++11 -Wall -Wextra -Wshadow -pedantic -pedantic-errors -Wfloat-equal -fstrict-aliasing -Wno-deprecated-declarations -Wstrict-aliasing -DHAVE_CXX_FLAG_WTHREAD_SAFETY -Wthread-safety -Wthread-safety -o CMakeFiles/cmTC_d3507.dir/src.cxx.o -c src.cxx
c++: error: unrecognized command line option '-Wthread-safety'
c++: error: unrecognized command line option '-Wthread-safety'
ninja: build stopped: subcommand failed.
## Expected behavior
PyTorch to build
## Environment
Please copy and paste the output from our
[environment collection script](https://raw.githubusercontent.com/pytorch/pytorch/master/torch/utils/collect_env.py)
(or fill out the checklist below manually).
You can get the script and run it with:
```
wget https://raw.githubusercontent.com/pytorch/pytorch/master/torch/utils/collect_env.py
# For security purposes, please check the contents of collect_env.py before running it.
python collect_env.py
```
- PyTorch Version (e.g., 1.0): 1.4
- OS (e.g., Linux): Linux
- How you installed PyTorch (`conda`, `pip`, source): source
- Build command you used (if compiling from source): python setup.py install
- Python version: 3.7.5
- CUDA/cuDNN version: 10.2
- GPU models and configuration:
- Any other relevant information: gcc 9.2.0
Collecting environment information...
PyTorch version: N/A
Is debug build: N/A
CUDA used to build PyTorch: N/A
OS: Red Hat Enterprise Linux Server release 7.7 (Maipo)
GCC version: (GCC) 9.2.0
CMake version: version 3.14.0
Python version: 3.7
Is CUDA available: N/A
CUDA runtime version: 10.2.89
GPU models and configuration: GPU 0: Tesla T4
Nvidia driver version: 440.33.01
cuDNN version: Could not collect
Versions of relevant libraries:
[pip3] numpy==1.18.1
[conda] magma-cuda102 2.5.2 1 pytorch
[conda] mkl 2020.0 166
[conda] mkl-include 2020.0 166 conda-forge
[conda] numpy 1.18.1 py37h8960a57_1 conda-forge
## Additional context
<!-- Add any other context about the problem here. -->
|
module: build,triaged
|
low
|
Critical
|
602,117,616 |
three.js
|
TransformControls accelerate if the camera moves while transforming
|
I first noticed this when scaling things, where the effect magnitude is insane (the box I was scaling was pushing the player away, the camera reacted to player moving, and the feedback caused TransformControls to blow the box up). However, the similar effect happens to positioning - see [here](https://jsfiddle.net/03uvag65/): the camera follows x, if you move he box in y direction, it is fine, but if you move in x direction - the light speed is no longer the limit.
Not sure if this counts as bug; if it does not - what do I do, @arodic ?
|
Needs Investigation
|
low
|
Critical
|
602,135,875 |
PowerToys
|
Add current folder to PATH
|
### Summary of the new feature/enhancement
It would be nice to have a context menu button to the current folder to the Windows PATH.
### Proposed technical implementation details (optional)
https://stackoverflow.com/questions/31269312/adding-a-shell-context-menu-item-so-that-i-can-add-folder-to-path-by-right-click/48414700#48414700
|
Help Wanted,Idea-New PowerToy
|
low
|
Major
|
602,147,414 |
youtube-dl
|
add easyload.io
|
<!--
######################################################################
WARNING!
IGNORING THE FOLLOWING TEMPLATE WILL RESULT IN ISSUE CLOSED AS INCOMPLETE
######################################################################
-->
## Checklist
<!--
Carefully read and work through this check list in order to prevent the most common mistakes and misuse of youtube-dl:
- First of, make sure you are using the latest version of youtube-dl. Run `youtube-dl --version` and ensure your version is 2020.03.24. If it's not, see https://yt-dl.org/update on how to update. Issues with outdated version will be REJECTED.
- Make sure that all provided video/audio/playlist URLs (if any) are alive and playable in a browser.
- Make sure that site you are requesting is not dedicated to copyright infringement, see https://yt-dl.org/copyright-infringement. youtube-dl does not support such sites. In order for site support request to be accepted all provided example URLs should not violate any copyrights.
- Search the bugtracker for similar site support requests: http://yt-dl.org/search-issues. DO NOT post duplicates.
- Finally, put x into all relevant boxes (like this [x])
-->
- [x] I'm reporting a new site support request
- [x] I've verified that I'm running youtube-dl version **2020.03.24**
- [x] I've checked that all provided URLs are alive and playable in a browser
- [x] I've checked that none of provided URLs violate any copyrights
- [x] I've searched the bugtracker for similar site support requests including closed ones
## Example URLs
<!--
Provide all kinds of example URLs support for which should be included. Replace following example URLs by yours.
-->
- Single video: https://easyload.io/f/xRlPG65Nq7/index_mp4_mp4
## Description
<!--
Provide any additional information.
If work on your issue requires account credentials please provide them or explain how one can obtain them.
-->
please add easyload.io
|
site-support-request
|
low
|
Critical
|
602,173,006 |
svelte
|
outroing if_blocks cannot receive updates
|
outroing if_blocks will not receive any update from the tick they get outroed on
`render_simple` :
https://svelte.dev/repl/3abed636ab2d456882e49b1db35c677f?version=3.20.1
`render_compound` :
https://svelte.dev/repl/5e950ff7951f4afc9b627aa9832fae5b?version=3.20.1
`render_simple` does have the following comment in the compiler
```
// no `p()` here β we don't want to update outroing nodes,
// as that will typically result in glitching
```
it's been there since the initial commit 2 years ago
~~I don't really see why it couldn't be fixed, might give it a try in a few days~~
|
bug,temp-stale,transition/animation
|
low
|
Major
|
602,175,292 |
PowerToys
|
[Run] Intro / exit animations
|
right now it is Visible / not visible. We need a quick, fade in / out.
Same should be list results.
1. Guessing, .66 sec for fade in / out. Snappy but not slow.
2. This has to be handled on WPF side due to WinUI transparency issues.
|
Idea-Enhancement,Product-PowerToys Run,Area-User Interface,External Dependency-WinUI 3,Status-Blocked
|
medium
|
Major
|
602,177,964 |
rust
|
unwrap branches are not optimized away.
|
When creating a structure which has a variant type, and that this type is wrapped as an `Option<T>`, the `unwrap` branch cannot be removed by LLVM, even after proving that the only path reachable is the `Some(β¦)` case and never the `None` case.
I tried this code:
https://github.com/mozilla-spidermonkey/jsparagus/blob/330722aaa4f7c6f39422b7daae7084ea8cbcbead/crates/parser/src/queue_stack.rs#L141-L153
Calling the previous function as:
```
assert!(self.top != 0);
let v = self.pop().unwrap();
```
This hint LLVM that the `self.top == 0` branch does not need to be generated. However, the unwrap condition remains as the `None` value is folded within the variant and that LLVM does not know about it.
I think the Rust compiler should give range analysis information that the `None` value would never be part of the variant, and as such let LLVM remove the unwrapping condition from the generated code.
### Meta
Tested with both `rustc --version --verbose`:
```
rustc 1.42.0 (b8cedc004 2020-03-09)
binary: rustc
commit-hash: b8cedc00407a4c56a3bda1ed605c6fc166655447
commit-date: 2020-03-09
host: x86_64-unknown-linux-gnu
release: 1.42.0
LLVM version: 9.0
```
and
```
rustc 1.44.0-nightly (7f3df5772 2020-04-16)
binary: rustc
commit-hash: 7f3df5772439eee1c512ed2eb540beef1124d236
commit-date: 2020-04-16
host: x86_64-unknown-linux-gnu
release: 1.44.0-nightly
LLVM version: 9.0
```
|
A-LLVM,I-slow,T-compiler,C-bug,E-needs-mcve
|
low
|
Major
|
602,190,712 |
rust
|
Duplicate crate macros failing to differentiate
|
Here is a reproduction:
https://github.com/LucioFranco/rustc-duplicate-macro-bug/
I've added comments on how to trigger the bug. But it looks like if we have one crate but two versions imported into the same project. Aka using cargo's rename feature, then rust picks up that if we use one of the macros that the other one even if its from a different version is the same. Commenting out the tower01 `assert_request_eq` allows the second one to compile properly. If its not commented out the `tower03` version will fail to compile because it is attempting to use the `tower01` version which doesn't await the inner future.
### Meta
This happens currently on `rustc 1.42.0 (b8cedc004 2020-03-09)` but not on a newer nightly `cargo 1.44.0-nightly (390e8f245 2020-04-07)`. So this has probably been fixed but I couldn't find any issue for this specific problem.
</p>
</details>
|
E-needs-test,A-macros,T-compiler,C-bug
|
low
|
Critical
|
602,238,588 |
electron
|
Clipboard: improved support for reading images
|
Some context: I'm writing a note-taking app, and one of the most requested feature for it has been to be able to paste images that were copied in the clipboard directly into notes.
I'd like to implement this feature as perfectly as I can, but as far as I can tell the current set of related APIs that Electron provides have a few limitations that don't allow me to implement this very well.
### Issue 1 - `clipboard.readImage` - Non existent image
Even if there are no images in the clipboard, `clipboard.readImage` still returns a `NativeImage` instance.
I don't see for what reason anyone would ever want one of these useless images returned when the clipboard contains no images, but more importantly this behavior seems to be undocumented in the docs, that mention that this function returns "The image content in the clipboard.".
I think this method should instead return either `null` or `undefined` when there are no images in the clipboard. If this can't be changed for whatever reason then it should be mentioned in the docs that a 0x0 image will be returned if no actual image has been found in the clipboard.
### Issue 2 - `NativeImage.toDataURL` - Unexpected conversion
`NativeImage` objects have a bunch of `.toFORMAT` methods, but only one `toDataURL` method, and the docs say that `toDataURL` returns "The data URL of the image", so given how any image can be encoded in a data url I would have expected the image-specific format would have been preserved, e.g. "the" data url of a gif should begin with `data:image/gif`, but instead it begins with `data:image/png` according to this method, basically this function is converting images to pngs regarding of their original format, so for any gif the returned data url is not the data url that encodes that image at all, but the data url of a possible way to convert that image to png, which is not what I was expecting.
### Issue 3 - `clipboard.readImage` - Preserving original data
It should be possible to retrieve the raw buffer that encodes the image found in the clipboard in order not to loose any information or alter the image in any way.
Most notably there are no methods for retrieving copied images as GIF or SVG, which makes it fundamentally impossible right now, as of Electron v8.2.2, for animated gifs or vector images to be copied in any reasonable way.
The provided methods for converting to PNG and JPG are also problematic, I don't want to convert a PNG image the user copied in the clipboard to JPG or viceversa, in order to not introduce any artifacts and in general in order to not alter the copied image at all. Additionally the `toJPEG` method asks me for a quality factor, I just want the image in the original quality, that doesn't seem possible today.
---
TL;DR: I would really like a function that just returns the extension, mime type and buffer of the image copied in the clipboard, with no alterations whatsoever, if these information is available.
|
enhancement :sparkles:
|
low
|
Minor
|
602,253,094 |
go
|
proxy.golang.org: sometimes rate limits @master package refreshes beyond documented "one minute"
|
https://proxy.golang.org/ says:
> After one minute for caches to expire, the go command will see that tagged version. If this doesn't work for you, please file an issue.
It's been minutes since I tagged a new version of `inet.af/netaddr` but it's not showing up:
```
$ go get inet.af/[email protected]
go get inet.af/[email protected]: no matching versions for query "v0.1"
$ go get inet.af/[email protected]
go get inet.af/[email protected]: inet.af/[email protected]: invalid version: unknown revision 0.1
$ git ls-remote [email protected]:inetaf/netaddr
f9e5bcc2d6eadfc6fd7937983711a17b511b954f HEAD
f9e5bcc2d6eadfc6fd7937983711a17b511b954f refs/heads/master
...
f9e5bcc2d6eadfc6fd7937983711a17b511b954f refs/tags/v0.1
```
Am I holding it wrong?
https://godoc.org/inet.af/netaddr is updated at least. Its refresh is instant.
/cc @hyangah @heschik
|
Documentation,NeedsInvestigation,proxy.golang.org
|
low
|
Major
|
602,257,984 |
godot
|
GLES2 - shadows does not work
|
Godot Engine v3.2.2.beta.custom_build.4e70279b5
Android 4.4 GPU VideoCore IV HW
```
GLES: Broadcom, VideoCore IV HW, OpenGL ES 2.0
GL_EXT_debug_marker GL_OES_compressed_ETC1_RGB8_texture GL_OES_compressed_paletted_texture GL_OES_texture_npot GL_OES_depth24 GL_OES_vertex_half_float GL_OES_EGL_image GL_OES_EGL_image_external GL_EXT_discard_framebuffer GL_OES_rgb8_rgba8 GL_OES_depth32 GL_OES_packed_depth_stencil GL_EXT_texture_format_BGRA8888 GL_APPLE_rgb_422
EGL:
EGL_KHR_image EGL_KHR_image_base EGL_KHR_image_pixmap EGL_KHR_vg_parent_image EGL_KHR_lock_surface EGL_ANDROID_image_native_buffer EGL_ANDROID_swap_rectangle EGL_ANDROID_image_native_buffer
```
On device log gives
```
**ERROR**: Directional shadow framebuffer status invalid
At: drivers\gles2\rasterizer_scene_gles2.cpp:4026:initialize() - Directional shadow framebuffer status invalid
```
**Issue description:**
When lights have no shadows enabled, then scene is rendered ok.
When lights shadows are enabled then everything turns very dark.
**Steps to reproduce:**
Use example project attached, turn shadow option in light node's on and off
**Minimal reproduction project:**
[VideoCore-1.zip](https://github.com/godotengine/godot/files/4495433/VideoCore-1.zip)
|
bug,platform:android,topic:rendering,topic:3d
|
low
|
Critical
|
602,258,141 |
go
|
cmd/vet: flag use of .Timeout() after Set*Deadline()
|
In #31449 it was decided to make deadline expiration return a newly-defined error, as checking `net.OpError.Timeout()` also detects keepalive failures. Keepalives were enabled by default for TCP clients in 1.12 and servers in 1.13, breaking some code setting deadlines longer than the keepalive period (which varies with platform).
This means that .Timeout() use after Set*Deadline() should be changed to look for the new error, since that is not a reliable way to check for deadline-expired.
I suggest _go vet_ flag use of .Timeout() after Set*Deadline(). That will generate reports for existing code, but perhaps that's better than leaving code broken due to the keepalive problem.
Triage: milestone should be 1.15
@gopherbot add NeedsDecision
|
NeedsDecision,Analysis
|
low
|
Critical
|
602,260,729 |
terminal
|
Scenario: The Command Palette
|
##### [Original issue: #2046] [Original Spec: #2193] [v2 Spec: #5674] [Spec Addendum 1: #6532]
<details>
<summary>TODO for initial PR</summary>
* [x] The list view items should be clickable
* [x] The list should be sorted by weight, then _alphabetically_
* [x] There should be stronger weighting for consecutive chars. Case in point: the `sett` example below
* [x] If you click on a list view item, focus enters the list view item, and then you can't hit enter to select it.
* [x] tests tests tests tests.
* [x] The auto gen names should probably only have the first letter capitalized - I bet if I do that I'll have to revert it during the PR... hmm...
</details>
## v2.0 Follow-up work
### Tasks
* [ ] Don't localize command names on the command palette #7039
* [ ] Add a setting to display Command Palette ActionMode entries in MRU order #6647
* [x] Add nested commands to the Command Palette #3994
* [x] Command palette entries should have optional icons #6644
* [x] A nested cmdpal menu should show the parent command above the list of commands #7265
* [x] Add support for commands iterable on color schemes #7329
* [x] Command Palette: Add support for commandline mode #6677
* [x] Make keys in the command palette look like actual keys, like in VS Code #6645
* [x] Command palette search results should bold the matching text #6646
* [x] `commandPalette` keybinding should close the palette when it's open #6679
* [x] Add "recent commands' to Command Palette in commandline mode #8296
* [x] Make the Command Line Mode easier to access #8322 (make a argument to `toggleCommandPalette` to go straight to the commandline mode)
### Bugs
* [ ] ~`_compareCommandNames` should use locale-aware string comparisons #6953~ This is going to be done by #7039 actually.
* [ ] Command Palette search algorithm needs to prioritize "longest substring" match, may need multiple passes #6693
* [ ] #7911 [Screen Reader-Command Palette]-Narrator focus is not in sync while navigating using arrow keys in suggestion list after searching for any command.
* [x] #7907 [Screen Reader-Command Palette]:-Screen reader is not announcing the suggestions when user searches for the commands.
* [x] #13457 The "go back" button should pop only one layer of the stack, not go all the way back to the root (https://github.com/microsoft/terminal/pull/8051#issuecomment-722045813)
* [x] NewTab won't leave the Command Palette #7441
* [x] #7915 [Visual requirement-Command Palette]-Luminosity ratio is 4.046:1 which is less than 4.5:1 for the shortcut text appended to the Commands.
* [x] #7914 [Functional-Command Palette]- User is not able to perform action using shortcuts when command palette is open.
* [x] #7913 [Screen Reader-Command Palette]-Narrator focus moves separately onto the shortcut text which is appended to the command.
* [x] #7912 [Usable-Command Palette]-Keyboard shortcuts are not included in the sub menu of New Tab list item.
* [x] #7910 [Functional-Command Palette]- User is not able to move back from the New Tab sub menu as there is no functionality provided to move out of Sub menu.
* [x] #7908 [Screen Reader-Command Palette]-Screen reader user will not be able to identify the purpose of New Tab control if role and state are not appropriate.
* [x] Overlapping text in Command Palette submenu after deleting ">" #10140
## Related, but indirectly
* [x] Add an action that runs other actions (action chaining)? #5970
* [ ] New icons for UI elements #6867
* [x] Add a shortcut action for switching to a specific color scheme #5401
* [x] Enable sending input to the Terminal with a keybinding #3799
* [x] Megathread: Sometimes, focus moves weirdly #6680
- [x] Launching "Find" from Command Palette doesn't focus the search box #6662
## Backlog work
* [ ] Consider refactoring CommandPalette + Switcher => LiveFilteringListView #7285
* [ ] Allow commands with user-defined names to be hidden from cmdpal #7179
* [ ] Add auto-suggestion to the Command-Palette wt arguments #7570
* [ ] Code Health: Consider checking we are not in the opening state, by hooking both `Opening` and `Open` events
* [ ] Code Health: The explicit implementation (in `CommandPalette::_lostFocusHandler`) can be generalized by checking if the focused element is a descendant of palette
* [ ] Additional commands could be previewable #9818
* [ ] Using --window in a wt action should do what you'd expect #10146
* [ ] Allow binding keys to a nested action, to open the palette directly to it's children #10209
* [x] #11026
* [ ] ~Keep the Command Palette around after executing a command #7011~
* [x] Nested previewable commands don't "cancel" when you navigate up the nesting stack #10165
* [x] Preview what actions will be run in commandline mode of the CmdPal #8344
* [x] Provide realtime commandline parsing feedback in the commandline mode of the command palette #7284
* [x] Allow commands to be previewed in the command palette #6689
* [x] #11049
|
Area-UserInterface,Product-Terminal,Issue-Scenario,Area-CmdPal
|
low
|
Critical
|
602,266,077 |
rust
|
Consider removing `ProjectionElem::Index`
|
It is the only projection element that uses another local besides the place's base local, and requires special care in many circumstances. All other `ProjectionElem`s perform static operations that do not depend on runtime values.
In https://github.com/rust-lang/rust/pull/71003, I initially did not handle this special case, which would have resulted in an unsound optimization. The visitor logic for them was also broken (fixed in https://github.com/rust-lang/rust/pull/71013) because it was missing a special case.
I'm not sure what to adequately replace them with. It seems like `Rvalue::Index` would be a reasonable choice, but it might have other drawbacks.
cc @rust-lang/wg-mir-opt
|
C-cleanup,T-compiler,A-MIR
|
low
|
Critical
|
602,267,255 |
react
|
Bug: Nested SuspenseList may display fallbacks while the component is loaded on re-render
|
<!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
**React version:** 0.0.0-experimental-e5d06e34b
Hoping this can be helpful for you. Here is what looks to be a bug with concurrent mode and nested SuspenseList.
## Steps To Reproduce
_In concurrent mode only_
0. Setup
Let's suppose we have three components `<A />` (**not** lazy loaded), `<B />` (**not** lazy loaded) and `<C />` (lazy loaded).
In other words:
```jsx
import A from './A';
import B from './B';
const C = React.lazy(() => import('./C'));
```
1. Render
```jsx
render(
<SuspenseList key="1" revealOrder="forwards">
<SuspenseList key="1.1" revealOrder="forwards">
<Suspense key="1.1.a" fallback={<div>Loading A</div>}>
<A />
</Suspense>
</SuspenseList>
</SuspenseList>
)
```
2. Update the component (component now shows A, B, and C)
```jsx
render(
<SuspenseList key="1" revealOrder="forwards">
<SuspenseList key="1.1" revealOrder="forwards">
<Suspense key="1.1.a" fallback={<div>Loading A</div>}>
<A />
</Suspense>
<Suspense key="1.1.b" fallback={<div>Loading B</div>}>
<B />
</Suspense>
<Suspense key="1.1.c" fallback={<div>Loading C</div>}>
<C />
</Suspense>
</SuspenseList>
</SuspenseList>
)
```
3. Output is: `A / Loading B / Loading C`. While `B` has already been loaded (not lazy loaded). If I understand well the behaviour of `forwards` I would have expect to have `A / B / Loading C` instead.
Please note that the behaviour is not the same if I do not use nested `<SuspenseList />`.
<!--
Your bug will get fixed much faster if we can run your code and it doesn't
have dependencies other than React. Issues without reproduction steps or
code examples may be immediately closed as not actionable.
-->
CodeSandbox: https://codesandbox.io/s/mutable-rain-3ikor
GitHub pages repro: https://dubzzz.github.io/react-suspenselist-bug/build/
GitHub pages source code: https://github.com/dubzzz/react-suspenselist-bug
<!--
Please provide a CodeSandbox (https://codesandbox.io/s/new), a link to a
repository on GitHub, or provide a minimal code example that reproduces the
problem. You may provide a screenshot of the application if you think it is
relevant to your bug report. Here are some tips for providing a minimal
example: https://stackoverflow.com/help/mcve.
-->
## The current behavior
Output is: `A / Loading B / Loading C` with nested `SuspenseList`
## The expected behavior
Output is: `A / B / Loading C` with nested `SuspenseList`
**How did I found this bug?**
This _potential bug_ has been discovered while I was trying to run property based tests based on [fast-check](https://github.com/dubzzz/fast-check/) against React library.
See https://github.com/dubzzz/react/commit/e2cb4776ea3634fab2021d83cb8259bde03c0f3a
|
Type: Needs Investigation,Component: Concurrent Features
|
low
|
Critical
|
602,268,395 |
godot
|
Undeterministic AtlasTexture Ordering in Saved Scene File With Multiple Row Spritesheets
|
**Godot version:**
3.2.1
**OS/device including version:**
Windows 10
**Issue description:**
When having AtlasTextures in a scene, the regions and/or ordering of them in the scene file gets changed on every save whether or not anything has been changed. This only seems to occur if a sprite sheet has multiple vertical rows. The saving behaviour seems to be non deterministic.
This causes issues with version control as a file will change irregardless of if anyone has actually made a change to the scene, and is a big headache when it comes to merge conflicts.
**Steps to reproduce:**
Open reproduction project, save, and close.
**Minimal reproduction project:**
[AtlasTextureText.zip](https://github.com/godotengine/godot/files/4495546/AtlasTextureText.zip)
This project contains a git repository showing the changes that occur over three commits.
|
bug,confirmed,topic:import
|
low
|
Minor
|
602,351,905 |
PowerToys
|
[KBM] Some character keys have the same display name but different codes
|
An example of this is `/`. There are two keys which display `/` on the UI now (on the keyboard one is near RShift and the other is on the numpad). We should try adding some identifier to distinguish them like `NumPad /` for example. The issue with hardcoding that in is that it may not translate well to other languages.
|
Product-Keyboard Shortcut Manager
|
low
|
Major
|
602,384,637 |
go
|
runtime: support SSE2 memmove on older amd64 hardware
|
**Background**
In pursuit of some database work I've been doing, I encountered a strange corner of Go. Inserting into packed segments of memory can be expensive due to the special, backwards `runtime.memmove` call required. (eg: `copy(x[n:], x); copy(x[:n], newdata)`
When compared to a similar C++/glibc implementation of the same operation, the glibc one was about twice as fast on my hardware (a Xeon E5 v1, Sandy Bridge) to the Go implementation.
Come to find out, that while the Xeon E5v1s have AVX instructions, they have a slower per-cycle data path. That explains why Go 1.14 has the following code restriction for Intel "Bridge families":
https://github.com/golang/go/blob/go1.14.2/src/runtime/cpuflags_amd64.go#L23
This hardware issue was present until Haswell Xeons (E5v3) which happily (and quickly) use the AVX.
glibc concurs. In a `perf` report of the C++ insertion logic, it's using GNU's __memcpy_sse2_unaligned.
Which is interesting -- because Go doesn't have the equivalent. `gccgo` will use glibc and get the same performance as C++/glibc.
**Proposal**
Add an SSE2-optimized path for `runtime.memmove`, at least when backwards copying. This would only affect/benefit older hardware (roughly, Xeons from [Nehalem, Haswell) ). Newer systems wouldn't notice at all.
I went ahead and implemented it; but the README said to file an issue for inclusion first, so here we are (my first issue!)
**Measurements**
I wrote a test package and harness to try a bunch of copy methods. Using SSE2 for the forward path as well didn't gain much over the baseline currently in Go 1.14, but for the backward path it was substantially faster.
Forcing AVX on Sandy Bridge functioned, and varied in speed, but was slower than expected (and slower than SSE2-paths) and especially slower when the non-temporal moves got involved.
The biggest win came in the backwards path alone.
So I implemented the backwards path only on my branch of the Go runtime and here's some preliminary highlights:
```
...
MemmoveUnalignedDstBackwards/256-32 20.6GB/s Β±22% 19.9GB/s Β±14% ~ (p=0.753 n=11+4)
MemmoveUnalignedDstBackwards/512-32 7.22GB/s Β±31% 23.39GB/s Β±21% +223.72% (p=0.001 n=11+4)
MemmoveUnalignedDstBackwards/1024-32 11.3GB/s Β±21% 28.1GB/s Β±16% +149.36% (p=0.001 n=11+4)
MemmoveUnalignedDstBackwards/2048-32 13.6GB/s Β±17% 28.5GB/s Β±12% +108.86% (p=0.001 n=11+4)
MemmoveUnalignedDstBackwards/4096-32 16.7GB/s Β±19% 35.3GB/s Β±16% +110.93% (p=0.001 n=11+4)
```
I figured compiling and benchmarking other packages from the wild with my patch would be interesting, and sure enough...
Using [bbolt](https://github.com/etcd-io/bbolt) 's B-Tree write benchmark:
```
$ ./bbolt-orig bench -write-mode rnd -count 100000
# Write 11.688323313s (116.883Β΅s/op) (8555 op/sec)
# Read 1.002042799s (36ns/op) (27777777 op/sec)
$ ./bbolt-sse2 bench -write-mode rnd -count 100000
# Write 8.114154792s (81.141Β΅s/op) (12324 op/sec)
# Read 1.002062417s (36ns/op) (27777777 op/sec)
```
|
Performance,NeedsInvestigation,compiler/runtime
|
low
|
Major
|
602,388,334 |
ant-design
|
Form add defaultValidateMessages.i18n language
|
- [x] I have searched the [issues](https://github.com/ant-design/ant-design/issues) of this repository and believe that this is not a duplicate.
### What problem does this feature solve?
For #6082
example: https://github.com/ant-design/ant-design/blob/acbbbfebc2c378b8fac6297ca2bb693228f3be13/components/locale/zh_CN.ts#L86-L135
Todo:
- [ ] fi_FI
- [ ] hu_HU
- [ ] hy_AM
- [ ] kmr_IQ
- [ ] ku_IQ
- [ ] lv_LV
- [ ] mk_MK
- [ ] sl_SI
<summary>Finished</summary>
- [x] en_GB #24404
- [x] en_US #23859
- [x] fa_IR #23926
- [x] ru_RU #24219
- [x] zh_CN #23165
- [x] zh_HK #25731
- [x] zh_TW #24065
- [x] pt_BR #24518
- [x] he_IL #24716
- [x] ko_KR #24783
- [x] tr_TR #25100
- [x] ja_JP #25244
- [x] nb_NO #25374
- [x] es_ES #25460
- [x] ar_EG #25587
- [x] ca_ES #25583
- [x] de_DE #25823
- [x] th_TH #26906
- [x] hr_HR #28458
- [x] fr_FR #29839
- [x] sv_SE #29896
- [x] nl_BE #30389
- [x] nl_NL #30389
- [x] sr_RS #30401
- [x] ro_RO #30419
- [x] hi_IN #30541
- [x] bn_BD #31257
- [x] ur_PK #31346
- [x] ml_IN #31521
- [x] ka_GE #32106
- [x] pl_PL #32896
- [x] et_EE #33005
- [x] sk_SK #34061
- [x] az_AZ #36967
- [x] cs_CZ #37388
- [x] by_BY #27028
- [x] ga_IE #24609
- [x] gl_ES #26015
- [x] kk_KZ #27589
- [x] km_KH #32853
- [x] lt_LT #26312
- [x] si_LK #36149
- [x] tk_TK #35605
- [x] uk_UA #35430
- [x] pt_PT #37857
- [x] it_IT #38108
- [x] uz_UZ #39353 #39556
- [x] fr_BE #39415
- [x] fr_CA #39416
- [x] ta_IN #39936
- [x] vi_VN #40992
- [x] bg_BG #42203
- [x] da_DK #46493
- [x] is_IS #48104
- [x] id_ID #48287
- [x] ms_MY #49353
- [x] mn_MN #49373
- [x] ne_NP #49492
- [x] kn_IN #49860
- [x] el_GR #50825
### What does the proposed API look like?
None
<!-- generated by ant-design-issue-helper. DO NOT REMOVE -->
|
help wanted,Inactive,good first issue
|
medium
|
Major
|
602,393,111 |
terminal
|
Create separate UIA parent objects for standard and alt conhost buffers
|
<!--
π¨π¨π¨π¨π¨π¨π¨π¨π¨π¨
I ACKNOWLEDGE THE FOLLOWING BEFORE PROCEEDING:
1. If I delete this entire template and go my own path, the core team may close my issue without further explanation or engagement.
2. If I list multiple bugs/concerns in this one issue, the core team may close my issue without further explanation or engagement.
3. If I write an issue that has many duplicates, the core team may close my issue without further explanation or engagement (and without necessarily spending time to find the exact duplicate ID number).
4. If I leave the title incomplete when filing the issue, the core team may close my issue without further explanation or engagement.
5. If I file something completely blank in the body, the core team may close my issue without further explanation or engagement.
All good? Then proceed!
-->
# Description of the new feature/enhancement
In https://github.com/microsoft/terminal/issues/5309#issuecomment-615040262:
> Ideally, in the long term, we would have different UIA parent objects for the different text buffers.
This would make things much better for UIA clients like NVDA.
<!--
A clear and concise description of what the problem is that the new feature would solve.
Describe why and how a user would use this new functionality (if applicable).
-->
|
Product-Conhost,Area-Accessibility,Issue-Task,Priority-2
|
low
|
Critical
|
602,399,197 |
go
|
x/pkgsite: provide multiple "copy to clipboard" options
|
<!--
Please answer these questions before submitting your issue. Thanks!
For questions, please email [email protected].
-->
### What is the URL of the page with the issue?
Any package page (e.g. https://pkg.go.dev/github.com/sirupsen/logrus?tab=doc)
### What is your user agent?
<!--
You can find your user agent here:
https://www.whatismybrowser.com/detect/what-is-my-user-agent
-->
Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/81.0.4044.92 Safari/537.36
### Screenshot
<!--
Please paste a screenshot of the page.
-->
<img width="879" alt="Screen Shot 2020-04-18 at 3 24 01 AM" src="https://user-images.githubusercontent.com/115761/79631038-2bb04700-8124-11ea-9d8b-98a0850e8ec2.png">
### What did you do?
<!--
If possible, provide a recipe for reproducing the error.
-->
Click the "Copy path to clipboard" button
### What did you expect to see?
`github.com/sirupsen/logrus` on my clipboard
### What did you see instead?
`import "github.com/sirupsen/logrus"` on my clipboard
I almost never want an import statement; I want something I can copy into a `go get` command in my terminal. Plus all the UI indicates it's a path, not an import statement.
|
NeedsInvestigation,FeatureRequest,pkgsite,UX
|
medium
|
Critical
|
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.