id
int64
393k
2.82B
repo
stringclasses
68 values
title
stringlengths
1
936
body
stringlengths
0
256k
โŒ€
labels
stringlengths
2
508
priority
stringclasses
3 values
severity
stringclasses
3 values
602,405,237
PowerToys
Please File Explorer support previewing the contents of zip without unarchived
like BetterZip for QuickLook in macOS
Idea-Enhancement,Product-File Explorer
low
Major
602,407,902
ant-design
Toggle dark with @media (prefers-color-scheme: dark) such like ThemeProvider
- [ ] I have searched the [issues](https://github.com/ant-design/ant-design/issues) of this repository and believe that this is not a duplicate. ### What problem does this feature solve? The theme color changes according to the system theme ไธป้ข˜่‰ฒๆ นๆฎ็ณป็ปŸไธป้ข˜ๅ˜ๆข ### What does the proposed API look like? ```js import 'antd/dist/antd.dark.css' ``` ๅŠ ่ฝฝ่ฟ™ไธชๆ ทๅผๅŽ๏ผŒๅนถไธๆ˜ฏ็›ดๆŽฅๅบ”็”จๅˆฐๅ…จๅฑ€๏ผŒ่€Œๆ˜ฏๅฏไปฅ้€š่ฟ‡ไธ€ไธช็ฑปๅ๏ผŒๆฏ”ๅฆ‚ `<body class="dark">`ๆฅๅˆ‡ๆขไธป้ข˜ใ€‚ ๅ†ๆˆ–่€…ๆ˜ฏๆŠŠ less ้ขœ่‰ฒๅ˜้‡ๆšด้œฒๅˆฐ css var ```css :root { --red: #ff6347; --yellow: #ffc107; --blue: #6495ed; } @media screen and (prefers-color-scheme: dark) { :root { color: #ddd; --red: #ad1a00; --blue: #1346a4; } } ``` <!-- generated by ant-design-issue-helper. DO NOT REMOVE -->
๐Ÿ’ก Feature Request,Inactive
high
Critical
602,424,951
flutter
[video_player] video render a green bar and wrong size
First of all.Forgive my poor english. I found that video_player render a green bar and wrong size when i play the high resolution video especially 1920*1080. The video resolution is 16:9,Containers width is 800 and height is 600.As u can see,The first video render a huge green bar and fill the container.The second video just covered the border and rendered a wrong size. ![IMG_8243](https://user-images.githubusercontent.com/27856388/79634522-77eb9d80-819d-11ea-929a-f74ac09ab03b.JPG) ![IMG_8244](https://user-images.githubusercontent.com/27856388/79634582-d57fea00-819d-11ea-8ca7-2fc484f76490.JPG) It confused me that video play error on some device but correct on others.It shows also on the plugin [ijkPlayer]( https://github.com/befovy/ijkplayer). I think it may be caught by the systems or hardware the system is the Android 7.1.I can not find any way to solve the problem.Waiting for u replay.Thx. There is my code ```dart class VideoSourceWidget extends StatefulWidget { Source source; Function endFun; Function errFun; VideoSourceWidget({Key key, this.source, this.endFun, this.errFun}) : super(key: key); @override _VideoSourceWidgetState createState() => _VideoSourceWidgetState(); } class _VideoSourceWidgetState extends State<VideoSourceWidget> { VideoPlayerController _controller; var listener; bool isErr = false; String errMsg = ""; @override void initState() { // TODO: implement initState super.initState(); _controller = VideoPlayerController.file(File(widget.source.res)) ..initialize().then((_) { if (widget.source.voice == 1) _controller.setVolume(1.0); else _controller.setVolume(0.0); _controller.play(); setState(() {}); }); listener = () { if (_controller.value.hasError) { setState(() { isErr = true; errMsg = _controller.value.errorDescription; }); // if (widget.endFun != null) { // _controller.removeListener(listener); // widget.errFun(); // } } var _duration = _controller.value.duration ?? Duration(hours: 1); var _remaining = _duration - _controller.value.position; if (_remaining.inMilliseconds == 0) { if (widget.endFun != null) { _controller.removeListener(listener); widget.endFun(); } } }; _controller.addListener(listener); } @override void dispose() { // TODO: implement dispose super.dispose(); if (_controller.value.isPlaying) { if (_controller.hasListeners) _controller.removeListener(listener); _controller.pause(); } _controller.dispose(); _controller = null; // player.release(); } @override Widget build(BuildContext context) { // TODO: implement build return isErr ? Container( child: Text(errMsg), ) : _controller.value.initialized ? Container( child: Center( child: AspectRatio( aspectRatio: _controller.value.aspectRatio, child: VideoPlayer(_controller,), ), ), decoration: BoxDecoration(border: Border.all(width:1.0, color:Colors.red)) ) // ? FittedBox(fit: BoxFit.fitWidth, child: VideoPlayer(_controller)) : Container(); } } ``` flutter doctor returns ``` [โœ“] Flutter (Channel unknown, v1.14.6, on Mac OS X 10.14.4 18E226, locale zh-Hans-CN) โ€ข Flutter version 1.14.6 at /Users/qitianle/Desktop/flutter โ€ข Framework revision fabeb2a16f (3 months ago), 2020-01-28 07:56:51 -0800 โ€ข Engine revision c4229bfbba โ€ข Dart version 2.8.0 (build 2.8.0-dev.5.0 fc3af737c7) [โœ“] Android toolchain - develop for Android devices (Android SDK version 29.0.3) โ€ข Android SDK at /Users/qitianle/Library/Android/sdk โ€ข Android NDK location not configured (optional; useful for native profiling support) โ€ข Platform android-29, build-tools 29.0.3 โ€ข ANDROID_HOME = /Users/qitianle/Library/Android/sdk โ€ข Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java โ€ข Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b4-5784211) โ€ข All Android licenses accepted. [!] Xcode - develop for iOS and macOS (Xcode 10.2.1) โ€ข Xcode at /Applications/Xcode.app/Contents/Developer โ€ข Xcode 10.2.1, Build version 10E1001 โœ— CocoaPods installed but not initialized. CocoaPods is used to retrieve the iOS and macOS platform side's plugin code that responds to your plugin usage on the Dart side. Without CocoaPods, plugins will not work on iOS or macOS. For more info, see https://flutter.dev/platform-plugins To initialize CocoaPods, run: pod setup once to finalize CocoaPods' installation. [โœ“] Android Studio (version 3.6) โ€ข Android Studio at /Applications/Android Studio.app/Contents โ€ข Flutter plugin version 45.1.1 โ€ข Dart plugin version 192.7761 โ€ข Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b4-5784211) [โœ“] VS Code (version 1.44.2) โ€ข VS Code at /Applications/Visual Studio Code.app/Contents โ€ข Flutter extension version 3.9.1 [โœ“] Connected device (2 available) โ€ข ASK AL00x โ€ข BGR6R20403000901 โ€ข android-arm64 โ€ข Android 9 (API 28) โ€ข mooncell mid โ€ข M662DZBS4T โ€ข android-arm64 โ€ข Android 7.1.2 (API 25) ``` and there is my pubsec.yaml ```yamlname: guardian description: A new Flutter application. # The following defines the version and build number for your application. # A version number is three numbers separated by dots, like 1.2.43 # followed by an optional build number separated by a +. # Both the version and the builder number may be overridden in flutter # build by specifying --build-name and --build-number, respectively. # In Android, build-name is used as versionName while build-number used as versionCode. # Read more about Android versioning at https://developer.android.com/studio/publish/versioning # In iOS, build-name is used as CFBundleShortVersionString while build-number used as CFBundleVersion. # Read more about iOS versioning at # https://developer.apple.com/library/archive/documentation/General/Reference/InfoPlistKeyReference/Articles/CoreFoundationKeys.html version: 2.0.20 environment: sdk: ">=2.1.0 <3.0.0" dependencies: flutter: sdk: flutter # The following adds the Cupertino Icons font to your application. # Use with the CupertinoIcons class for iOS style icons. cupertino_icons: ^0.1.2 video_player: ^0.10.6 flutter_redux: ^0.5.3 event_bus: ^1.1.1 intl: ^0.15.8 native_pdf_view: ^2.2.0 flutter_sequence_animation: ^3.0.1 http: ^0.12.0+2 # fijkplayer: ^0.7.1 dev_dependencies: flutter_test: sdk: flutter # For information on the generic Dart part of this file, see the # following page: https://dart.dev/tools/pub/pubspec # The following section is specific to Flutter. flutter: # The following line ensures that the Material Icons font is # included with your application, so that you can use the icons in # the material Icons class. uses-material-design: true # To add assets to your application, add an assets section, like this: assets: - assets/logo.png - assets/ # An image asset can refer to one or more resolution-specific "variants", see # https://flutter.dev/assets-and-images/#resolution-aware. # For details regarding adding assets from package dependencies, see # https://flutter.dev/assets-and-images/#from-packages # To add custom fonts to your application, add a fonts section here, # in this "flutter" section. Each entry in this list should have a # "family" key with the font family name, and a "fonts" key with a # list giving the asset and other descriptors for the font. For # example: # fonts: # - family: Schyler # fonts: # - asset: fonts/Schyler-Regular.ttf # - asset: fonts/Schyler-Italic.ttf # style: italic # - family: Trajan Pro # fonts: # - asset: fonts/TrajanPro.ttf # - asset: fonts/TrajanPro_Bold.ttf # weight: 700 # # For details regarding fonts from package dependencies, # see https://flutter.dev/custom-fonts/#from-packages ```
platform-android,engine,a: video,a: quality,p: video_player,package,P2,team-android,triaged-android
low
Critical
602,442,546
TypeScript
Allow `this` in constructor parameter
## Search Terms type, this, constructor, TS2526 ## Suggestion Currently, this code fails with `A 'this' type is available only in a non-static member of a class or interface.ts(2526)`: ```ts class MyClass { private props: { baz: string }; constructor(props: this["props"]) { this.props = props; } } ``` It would be awesome if `this` could be supported in constructor arguments. ## Use Cases This is very useful for react components, as demonstrated in the following example. More general, sometimes a class extends a generic base class which requires generic data for initialization. If the super class also wants to do some initialization, it needs to pass this generic argument down to its base class. As constructor arguments must be typed, the type of this generic argument must be explicitly stated in the super class. In those cases, it is very practical to use `this` to refer to a field of that base class that has the right type. ## Examples ```ts class MyComponent extends React.Component<{ title: string; }> { constructor(props: this["props"]) { super(props); // ... } } ``` ## Current Workarounds ```ts class MyComponent extends React.Component<{ title: string; }> { constructor(props: MyComponent["props"]) { super(props); // ... } } ``` This only works if the base class declares a static `props` member. Also, it has the downside that you must write out the name of the current class. This obfuscates the fact that it refers itself. ## Checklist My suggestion meets these guidelines: * [x] This wouldn't be a breaking change in existing TypeScript/JavaScript code * [x] This wouldn't change the runtime behavior of existing JavaScript code * [x] This could be implemented without emitting different JS based on the types of the expressions * [x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.) * [x] This feature would agree with the rest of [TypeScript's Design Goals](https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals).
Suggestion,Awaiting More Feedback
medium
Critical
602,442,711
rust
Implement a function that creates a Cow<'_, CStr> from a slice of bytes
I've been working on FFI-bindings for a C library and I ran into an issue where `CString::new()` would fail if there's a 0-byte. I was left with three options: 1) Let the users of my crate deal with `NulError`, which makes it less ergonomic, IMO; 2) Just unwrap the Result under the hood and document the possible panic; 3) When `CString::new()` fails, call `CStr::from_bytes_with_nul()` using `NulError::nul_position()`, wrap both `Ok` and `Err` branches in `Cow::from()`. I found the third option to be the most ergonomic and that's what I went with. Of course you could argue that it's sort of a leaky abstraction because users are expected to understand that C-libraries usually read until the 0-byte. But an interior 0-byte in a Rust string is not really a common case, is it? So, what do you guys think, is this something worthy of being a part of `std::ffi`? I already made the changes locally and I'd be happy to make a PR. However, I can't come up with a good name, so far I called it `CString::from_slice()` but I don't think it's fitting.
T-libs-api,C-feature-request
low
Critical
602,448,233
vue
nextTick implementation breaks with core-js@3 Promise polyfill on Tizen 2016
### Version 2.6.11 ### Steps to reproduce Just cross-linking the issues here, it was opened in core-js repo: https://github.com/zloirock/core-js/issues/814 The reproduction is not easily doable as it requires a Samsung Tizen 2016 device (which I have because I develop specifically for TVs). ### What is expected? UI updates correctly after events ### What is actually happening? UI will only update if another task is queue. --- In the nextTick implementation there's a check for `isIOS` to trigger an extra `setTimeout` which, while hacky, works also for Tizen 2016. Perhaps a PR could be made adding an exception for Samsung Tizen as well? <!-- generated by vue-issues. DO NOT REMOVE -->
need repro,browser quirks
low
Major
602,453,736
rust
const_err does not trigger on associated constants
I tried this code: ```rust pub struct Foo; pub const FOO: Foo = Foo::new(1); impl Foo { pub const FOO: Self = Self::new(1); pub const fn new(i: usize) -> Foo { [][i] = 5; Foo } } ``` I expected to see this happen: Both `FOO` and `Foo::FOO` should trigger `const_err` errors. Instead, this happened: Only `FOO` was marked with `const_err` ### Meta Checked on current stable (1.42) and nightly (2020-04-17) on the playground
T-lang,T-compiler,C-bug,A-const-eval
low
Critical
602,465,545
TypeScript
Intellisense should show internals of an interface declaration on hover
## Search Terms - intellisense interface - intellisense interface expand ## Suggestion I'm trying to re-open and start a discussion around #32616 and #12920, which were closed as "working as intended". It may well be the case, but it would be useful if Interfaces were expanded by default just as Type Aliases are. Is there a hard reason impeding this I'm not seeing? What are the metrics saying that "in general interfaces are longer"? Today Interfaces and Type Aliases offer almost the same features and they are for the most part interchangeable (especially for typing objects, see: https://stackoverflow.com/a/52682220/416714) I understand there is a discussion around expandable hints (#25784). Would that be the occasion to bring expanded-by-default Interfaces? ## Examples When hovering over a Type: <img width="340" alt="Screenshot 2020-04-18 at 15 44 41" src="https://user-images.githubusercontent.com/736316/79639547-cfcdd880-818c-11ea-8008-c2f22b2ef88f.png"> When hovering over an Interface: <img width="340" alt="Screenshot 2020-04-18 at 15 45 01" src="https://user-images.githubusercontent.com/736316/79639557-de1bf480-818c-11ea-8ad7-ca9f5ab04012.png"> ## Checklist My suggestion meets these guidelines: * [x] This wouldn't be a breaking change in existing TypeScript/JavaScript code * [x] This wouldn't change the runtime behavior of existing JavaScript code * [x] This could be implemented without emitting different JS based on the types of the expressions * [x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.) * [x] This feature would agree with the rest of [TypeScript's Design Goals](https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals).
Suggestion,In Discussion,Domain: Quick Info,Experimentation Needed
high
Critical
602,492,242
flutter
Show Dart SDK version details in Flutter Doctor summary output
<!-- Thank you for using Flutter! If you are looking for support, please check out our documentation or consider asking a question on Stack Overflow: * https://flutter.dev/ * https://api.flutter.dev/ * https://stackoverflow.com/questions/tagged/flutter?sort=frequent If you have found a bug or if our documentation doesn't have an answer to what you're looking for, then fill our the template below. Please read our guide to filing a bug first: https://flutter.dev/docs/resources/bug-reports --> ## Use case This information would be extremely useful to quickly check whether third-party packages are compatible with the project's current Dart SDK. It does show up on the detailed output (with the `-v` flag), but a mention of the Dart SDK version in the summary would be time-saving. <!-- Please tell us the problem you are running into that led to you wanting a new feature. Is your feature request related to a problem? Please give a clear and concise description of what the problem is. Describe alternative solutions you've considered. Is there a package on pub.dev/flutter that already solves this? --> ## Proposal `flutter doctor` summary should also include the Dart SDK version info along with the Flutter version info. Currently the Flutter section looks like: ``` [โˆš] Flutter (Channel master, v1.18.0-6.0.pre.26, on Microsoft Windows [Version 10.0.18363.592], locale <locale>) ``` It could include the Dart SDK version in a manner similar to this: ``` [โˆš] Flutter (Channel master, v1.18.0-6.0.pre.26, Dart SDK v2.8.0-dev.20.0, on Microsoft Windows [Version 10.0.18363.592], locale <locale>)
c: new feature,tool,c: proposal,P3,team-tool,triaged-tool
low
Critical
602,495,499
godot
Impossible to instantiate a scene file as node through drag-and-drop
**Godot version:** v3.2.1-stable-x11 **OS/device including version:** Linux Fedora 31 **Issue description:** After adding a GLB file (3D export in glTF binary format) to my project folder, I faced inconsistent behaviour from Godot when trying to instantiate it in my scene. - the file was perfectly fine as Godot was able to open it in a standalone view through double-click in the file explorer panel - the file had a red cross icon in the file explorer panel with no explanation regarding what was wrong - I was unable to drag-and-drop the file to my scene's tree view But: - I was able to instantiate it by clicking the link-shaped button ("instance a scene file as a node") in the scene tree view's toolbar - since then, the file has a movie clap icon and I can drag and drop it to the scene tree view However: - when pressing the play button, the game launches correctly and works fine but Godot shows an alert message box in the editor saying "requested file format unknown: glb" **Steps to reproduce:** (I'm currently taking part in a game jam so I will try to provide this later if and only if the bug is not deemed to be an error on my end or expected behaviour somehow, as I'm new to Godot.) **Minimal reproduction project:** (see note above)
bug,topic:editor
low
Critical
602,510,358
pytorch
Stochasticity for DistributedDataParallel on CPU but not on GPU
## ๐Ÿ› Bug When I run my DDP model on the GPU using a specific seed, I get identical results time after time. But when I run the same DDP model on the CPU using the same seed, I get different results each time. I am setting the seed within the child process, near its beginning, using the following code: torch.manual_seed(args.seed) np.random.seed(args.seed) I also tried setting the seed inside the model, before it goes into its training loop. No luck. ## To Reproduce Steps to reproduce the behavior: 1.Run the model via DDP on the GPU using a specific seed, three times, saving the output into different files each time. Confirm the output is identical across all three files. 2.Run the same model via DDP on the CPU using a specific seed, three times, saving the output into different files each time. Confirm the output is different across all three files. <!-- If you have a code sample, error messages, stack traces, please provide it here as well --> ## Expected behavior The output should be the same each time for a given seed, on a given device. I do not expect CPU and GPU output to match each other, but I do expect all GPU output to match itself, and the same for all CPU output. <!-- A clear and concise description of what you expected to happen. --> ## Environment PyTorch version: 1.4.0 Is debug build: No CUDA used to build PyTorch: 10.1 OS: Ubuntu 18.04.3 LTS GCC version: (Ubuntu 7.5.0-3ubuntu1~18.04) 7.5.0 CMake version: version 3.10.2 Python version: 3.6 Is CUDA available: Yes CUDA runtime version: 10.0.130 GPU models and configuration: GPU 0: GeForce RTX 2080 Ti GPU 1: GeForce RTX 2080 Ti GPU 2: GeForce RTX 2080 Ti GPU 3: GeForce RTX 2080 Ti Nvidia driver version: 418.74 cuDNN version: /usr/lib/x86_64-linux-gnu/libcudnn.so.7.6.2 Versions of relevant libraries: [pip3] numpy==1.18.1 [pip3] torch==1.4.0 [conda] numpy 1.17.2 py36h95a1406_0 conda-forge ## Additional context <!-- Add any other context about the problem here. --> cc @ezyang @gchanan @zou3519 @pietern @mrshenli @pritamdamania87 @zhaojuanmao @satgera @rohan-varma @gqchen @aazzolini @xush6528 @osalpekar
high priority,needs reproduction,oncall: distributed,triaged,module: determinism,module: data parallel
medium
Critical
602,526,240
pytorch
Memory leak upon exception for interactive consoles
## ๐Ÿ› Bug If I run PyTorch code in an interactive console such as the python interpreter or ipython, then PyTorch leaks memory when a function call on a `torch.nn.Module` raises an exception that propagates to the top level. Running `torch.cuda.clear_cache()` does not clear this memory, and I have observed cases where even catching the exception and running `del(model)` does not clear the memory. ## To Reproduce In the Python interpreter, run: ``` import torch class Blah(torch.nn.Module): def __init__(self): super().__init__() self.params = torch.nn.Linear(30000, 30000) def forward(self, vals): val = self.params(vals) raise RuntimeError("Oopsies") b = Blah().to('cuda'); b.forward(torch.zeros(30000).to('cuda')) torch.cuda.empty_cache() b = Blah().to('cuda'); b.forward(torch.zeros(30000).to('cuda')) torch.cuda.empty_cache() ``` Repeat the last line as needed until GPU memory is exhausted. Continuing further results in main memory being exhausted. <!-- If you have a code sample, error messages, stack traces, please provide it here as well --> ## Expected behavior GPU (and regular) memory is cleared once `b` becomes out of scope after each exception, and I am allowed to run the last line arbitrarily many times. <!-- A clear and concise description of what you expected to happen. --> ## Environment ``` Collecting environment information... PyTorch version: 1.4.0 Is debug build: No CUDA used to build PyTorch: 10.1 OS: Ubuntu 18.04.4 LTS GCC version: (Ubuntu 7.5.0-3ubuntu1~18.04) 7.5.0 CMake version: version 3.17.1 Python version: 3.6 Is CUDA available: Yes CUDA runtime version: 10.0.130 GPU models and configuration: GPU 0: GeForce GTX 1060 with Max-Q Design Nvidia driver version: 440.64 cuDNN version: Could not collect Versions of relevant libraries: [pip] Could not collect [conda] Could not collect ``` ## Additional context Fixing this bug is important for people who debug models interactively. Otherwise they'll have to repeatedly restart the console or kernel, or get an unexpected memory thrashing problem in the middle of their work. <!-- Add any other context about the problem here. -->
module: memory usage,triaged
low
Critical
602,609,166
three.js
FirstPersonControls doesn't support (0,0,1) as camera up.
Hey all, Not sure if bug or feature so I'm starting with making the issue first. Having `Object3D.defaultup` set to anything other than `new Vector3(0,1,0)` and by extension `camera.up`, results in jarring camera behaviour when controlled by the `FirstPersonController`.
Enhancement
low
Critical
602,650,231
pytorch
pytorch and c++ inference disagree
## ๐Ÿ› Bug <!-- A clear and concise description of what the bug is. --> The output from a traced model using (1) python and (2) c++ are different. xpost: https://discuss.pytorch.org/t/c-and-pytorch-inference-discrepancy/77388?u=jonrbates ## To Reproduce Steps to reproduce the behavior: **1. Create model in python** ``` import torch from transformers import GPT2LMHeadModel model = GPT2LMHeadModel.from_pretrained("distilgpt2", pad_token_id=50256, torchscript=True) traced_model = torch.jit.trace(model, [torch.tensor([[464, 6842, 1816, 625, 262, 8598, 284, 766]])]) torch.jit.save(traced_model, "traced_distilgpt2.pt") ``` **2. Inference in pytorch** ``` loaded_model = torch.jit.load("traced_distilgpt2.pt") outputs = loaded_model(torch.tensor([[464, 6842, 1816, 625, 262, 8598, 284, 766]])) torch.max(outputs[0],2) >> torch.return_types.max(values=tensor([[-26.7050, -53.3268, -66.3666, -50.1084, -54.8050, -72.4056, -55.2586,-63.5215]], grad_fn=<MaxBackward0>), indices=tensor([[ 383, 373, 319, 262, 1353, 290, 262, 262]])) torch.min(outputs[0][:, :, :],2) >>torch.return_types.min( values=tensor([[ -47.3794, -77.6341, -95.8365, -75.3026, -81.6899, -103.6701, -83.0335, -93.0259]], grad_fn=<MinBackward0>), indices=tensor([[ 154, 7134, 31204, 22997, 10298, 31204, 22997, 31573]])) ``` **3. Inference in c** ``` int main(int argc, const char* argv[]) { torch::jit::script::Module module; module = torch::jit::load(argv[1]); std::cout << "Model loaded.\n"; module.eval(); // just in case? torch::Tensor x = torch::tensor({464, 6842, 1816, 625, 262, 8598, 284, 766}, torch::dtype(torch::kInt64)).reshape({8, 1}); std::vector<torch::jit::IValue> inputs; inputs.push_back(x); // Execute the model and turn its output into a tensor (all_encoder_layers). torch::Tensor out = module.forward(inputs).toTuple()->elements()[0].toTensor(); auto z = torch::max(out, /*dim=*/2); std::cout << std::get<0>(z) << '\n'; std::cout << std::get<1>(z) << '\n'; z = torch::min(out, /*dim=*/2); std::cout << std::get<0>(z) << '\n'; std::cout << std::get<1>(z) << '\n'; return 0; } ``` Output from running c exe (with argv[1] = "traced_distilgpt2.pt") : ``` -26.7050 -28.0251 -29.0539 -28.2608 -26.3226 -28.0652 -26.8328 -28.5087 [ Variable[CPUFloatType]{8,1} ] 383 383 383 383 383 383 383 383 [ Variable[CPULongType]{8,1} ] -47.3794 -48.2470 -49.5565 -49.0826 -46.3104 -48.5934 -47.3013 -49.1308 [ Variable[CPUFloatType]{8,1} ] 154 154 154 154 154 154 154 154 [ Variable[CPULongType]{8,1} ] ``` <!-- If you have a code sample, error messages, stack traces, please provide it here as well --> ## Expected behavior The models agree for the first token (position=0) but for positions 1-7 the encoder outputs disagree. All outputs should be equal. <!-- --> ## Environment (Pytorch) PyTorch version: 1.4.0 Is debug build: No CUDA used to build PyTorch: 10.1 OS: Microsoft Windows 10 Pro GCC version: (x86_64-posix-seh-rev0, Built by MinGW-W64 project) 5.4.0 CMake version: version 3.14.0 Python version: 3.7 Is CUDA available: Yes CUDA runtime version: 10.0.130 GPU models and configuration: GPU 0: Quadro M500M Nvidia driver version: 442.23 cuDNN version: C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v10.0\bin\cudnn64_7.dll Versions of relevant libraries: [pip] Could not collect [conda] _tflow_select 2.3.0 mkl [conda] blas 1.0 mkl [conda] cudatoolkit 10.1.243 h74a9793_0 [conda] libmklml 2019.0.5 0 [conda] mkl 2019.4 245 [conda] mkl-include 2020.0 166 [conda] mkl-service 2.3.0 py37hb782905_0 [conda] mkl_fft 1.0.14 py37h14836fe_0 [conda] mkl_random 1.1.0 py37h675688f_0 [conda] numpy 1.16.5 py37h19fb1c0_0 [conda] numpy-base 1.16.5 py37hc3f5095_0 [conda] numpydoc 0.9.1 py_0 [conda] pytorch 1.4.0 py3.7_cuda101_cudnn7_0 pytorch [conda] tensorflow 2.1.0 mkl_py37ha977152_0 [conda] tensorflow-base 2.1.0 mkl_py37h230818c_0 [conda] torchvision 0.5.0 py37_cu101 pytorch ## Environment (C++) PyTorch version: N/A Is debug build: N/A CUDA used to build PyTorch: N/A OS: Ubuntu 18.04.4 LTS GCC version: (Ubuntu 7.5.0-3ubuntu1~18.04) 7.5.0 CMake version: version 3.10.2 Python version: 2.7 Is CUDA available: N/A CUDA runtime version: Could not collect GPU models and configuration: Could not collect Nvidia driver version: Could not collect cuDNN version: Could not collect Versions of relevant libraries: [pip] Could not collect [conda] Could not collect cc @yf225
module: cpp,triaged
low
Critical
602,671,032
go
cmd/go: override semantics break e.g. GOFLAGS=-ldflags
I was asked to post this as a separate issue in https://github.com/golang/go/issues/26849#issuecomment-615950020, so here goes: Comment https://github.com/golang/go/issues/26849#issuecomment-454481195 already touches upon the override semantics issue (`-ldflags=-w -ldflags=-s` results in only `-s`), but since that example would likely be fixed by quoting changes, Iโ€™d like to stress another nuance not addressed by quoting: the current override behavior makes setting `-ldflags` in `GOFLAGS` impossible when the `go` tool command lines contain an explicit `-ldflags` flag. For my use-case, I want to set the ELF interpreter in my build system, so I figured Iโ€™d set the `GOFLAGS` environment variable like so: ``` GOFLAGS="-ldflags=-extldflags=-Wl,--dynamic-linker=/ro/glibc-amd64-2.31-4/out/lib/ld-linux-x86-64.so.2" ``` This works in general, but breaks as soon as the software in question specifies its own ldflags on the command line, like e.g. [containerd does in its Makefile](https://github.com/containerd/containerd/blob/3282a1c14cd98c124970e448f6d1a9fe5ae0b9b8/Makefile#L100). Itโ€™s easy to verify this: ``` GOFLAGS=-ldflags=-invalid go build # fails GOFLAGS=-ldflags=-invalid go build -ldflags=-s # does not fail ``` Notably, from C build systems, Iโ€™m used to LDFLAGS generally being extended, never overridden. For my use-case, Iโ€™m currently setting `-Wl,--dynamic-linker` in `CGO_LDFLAGS` instead. Not entirely sure how reliable that is longer-term, but it seems to work with the packages I currently care about.
NeedsInvestigation
low
Major
602,685,061
flutter
Google maps plugin spams the logs
## Steps to Reproduce Add the google maps plugin and create a widget according to the tutorial. **Expected results:** <!-- what did you want to see? --> No log mesages, Or logmessages that are relevant to the library user **Actual results:** <!-- what did you see? --> ``` D/EGL_emulation( 4990): eglMakeCurrent: 0xe736f380: ver 2 0 (tinfo 0xdbc284a0) D/EGL_emulation( 4990): eglMakeCurrent: 0xe7301560: ver 1 0 (tinfo 0xc4630550) D/HostConnection( 4990): HostConnection::get() New Host Connection established 0xdbc3de60, tid 5143 D/HostConnection( 4990): HostComposition ext ANDROID_EMU_CHECKSUM_HELPER_v1 ANDROID_EMU_dma_v1 ANDROID_EMU_direct_mem ANDROID_EMU_host_composition_v1 ANDROID_EMU_host_composition_v2 ANDROID_EMU_vulkan ANDROID_EMU_deferred_vulkan_commands ANDROID_EMU_vulkan_null_optional_strings ANDROID_EMU_vulkan_create_resources_with_requirements ANDROID_EMU_YUV420_888_to_NV21 ANDROID_EMU_YUV_Cache ANDROID_EMU_async_unmap_buffer GL_OES_vertex_array_object GL_KHR_texture_compression_astc_ldr ANDROID_EMU_gles_max_version_2 W/sseltrackingap( 4990): Accessing hidden method Lsun/misc/Unsafe;->putObject(Ljava/lang/Object;JLjava/lang/Object;)V (greylist, linking, allowed) W/sseltrackingap( 4990): Accessing hidden method Lsun/misc/Unsafe;->putObject(Ljava/lang/Object;JLjava/lang/Object;)V (greylist, linking, allowed) W/sseltrackingap( 4990): Accessing hidden method Lsun/misc/Unsafe;->putObject(Ljava/lang/Object;JLjava/lang/Object;)V (greylist, linking, allowed) ``` <!-- Finally, paste the output of running `flutter doctor -v` here. --> <details> <summary>flutter doctor -v</summary> ```bash [โœ“] Flutter (Channel stable, v1.12.13+hotfix.9, on Linux, locale en_US.UTF-8) โ€ข Flutter version 1.12.13+hotfix.9 at /home/.../flutter โ€ข Framework revision f139b11009 (3 weeks ago), 2020-03-30 13:57:30 -0700 โ€ข Engine revision af51afceb8 โ€ข Dart version 2.7.2 [โœ“] Android toolchain - develop for Android devices (Android SDK version 29.0.3) โ€ข Android SDK at /home/.../Android/Sdk โ€ข Android NDK location not configured (optional; useful for native profiling support) โ€ข Platform android-29, build-tools 29.0.3 โ€ข Java binary at: /home/.../android-studio-ide-192.6308749-linux/android-studio/jre/bin/java โ€ข Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b4-5784211) โ€ข All Android licenses accepted. [โœ“] Android Studio (version 3.6) โ€ข Android Studio at /home/.../android-studio-ide-192.6308749-linux/android-studio โ€ข Flutter plugin version 45.1.1 โ€ข Dart plugin version 192.7761 โ€ข Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b4-5784211) [โœ“] Connected device (1 available) โ€ข Android SDK built for x86 โ€ข emulator-5554 โ€ข android-x86 โ€ข Android 10 (API 29) (emulator) </details> ``` </details>
platform-android,p: maps,package,has reproducible steps,P3,found in release: 1.22,found in release: 1.26,found in release: 2.0,found in release: 2.3,team-android,triaged-android
low
Major
602,690,733
godot
It's possible to create double 2D polygon points
**Godot version:** 3.2.1 **Issue description:** This is related to #36024, but it's a bit different. Basically, 2D polygon editor allows you to create double points, i.e. you can double click somewhere and it will create two points at the same spot. IMO this should not be allowed, I mean having consecutive points at the same position. It might be useful only for non-consecutive points. The reason I'm bringing this up is that it's easy to accidentally double click a point, which sometimes causes convex decomposition error, making the polygon unusable. There's no way to tell which point is doubled, so you need to go through all of them and check for wrong numbering. This probably only happens with grid snap enabled, normally there's low chance of this happening (but you can still create two _very close_ points). (also not sure how to label this, as it technically might not be a "true" bug)
discussion,topic:editor
low
Critical
602,697,510
PowerToys
[peek/preview pane] support epub
# Summary of the new feature/enhancement It would be great to get a **previsualization**, at least the the cover page, of **epub** files in the **File Explorer** PowerToys / peek
Idea-New PowerToy,Product-File Explorer
low
Major
602,768,603
flutter
Slow initial build time due to "skipping target" inefficient hashFiles computation.
<!-- Thank you for using Flutter! If you are looking for support, please check out our documentation or consider asking a question on Stack Overflow: * https://flutter.dev/ * https://api.flutter.dev/ * https://stackoverflow.com/questions/tagged/flutter?sort=frequent If you have found a bug or if our documentation doesn't have an answer to what you're looking for, then fill our the template below. Please read our guide to filing a bug first: https://flutter.dev/docs/resources/bug-reports --> ## Steps to Reproduce <!-- Please tell us exactly how to reproduce the problem you are running into. --> 1. flutter create p1 2. cd p1 3. flutter run -d linux OR flutter run -d windows OR (I guess mac, anything else) I won't include logs, just the first lines of "flutter doctor -v" [โœ“] Flutter (Channel master, v1.18.0-6.0.pre.82, on Linux, locale en_US.UTF-8) โ€ข Flutter version 1.18.0-6.0.pre.82 at /home/malkia/p/flutter/flutter โ€ข Framework revision f35b673f2b (20 hours ago), 2020-04-19 02:45:01 +0530 โ€ข Engine revision a5e0b2f2f2 โ€ข Dart version 2.9.0 (build 2.9.0-1.0.dev 5b19445d9c) I've dig a little, and found out that calling, "flutter run -d linux" (or possibly other platforms) maybe slow due to the "skipping target" step: https://github.com/flutter/flutter/blob/cb8bafb38df02f63edaea76e0dc7a74380f47ce8/packages/flutter_tools/lib/src/build_system/build_system.dart#L684 calling computeChanges() here: https://github.com/flutter/flutter/blob/cb8bafb38df02f63edaea76e0dc7a74380f47ce8/packages/flutter_tools/lib/src/build_system/build_system.dart#L907 calling later hashFIles() https://github.com/flutter/flutter/blob/cb8bafb38df02f63edaea76e0dc7a74380f47ce8/packages/flutter_tools/lib/src/build_system/build_system.dart#L981 calling _hashFile(), which (function just down below): final Digest digest = md5.convert(await file.readAsBytes()); I believe this is the cause of slowdown, and have put some more findings here: https://www.reddit.com/r/FlutterDev/comments/g31c2e/what_are_the_common_problems_you_are_facing_while/fnw96ku/?context=3
tool,c: performance,P2,team-tool,triaged-tool
low
Critical
602,768,665
rust
`unused_parens` should lint superfluous parentheses on the LHS of an assignment
<!-- Thank you for filing a bug report! ๐Ÿ› Please provide a short summary of the bug, along with any information you feel relevant to replicating the bug. --> I tried this code: ```rust #[deny(unused_parens)] fn main() { let mut a = 5; (((((a))))) = 6; } ``` I expected to see this happen: the compiler should reject this because there are unused parentheses on the left-hand side of the assignment. Instead, this happened: the code compiled without errors. ### Meta This bug exists on current stable, beta and nightly.
A-lints,T-compiler,C-bug,L-unused_parens
low
Critical
602,770,942
go
x/tools/gopls: show unimported completions for symbol names
See the original discussion on https://github.com/microsoft/vscode-go/issues/1846. /cc @heschik @muirdm
FeatureRequest,gopls,Tools
low
Minor
602,779,209
youtube-dl
The option to download all video files to a central location, then have youtube-dl automatically create folders for playlists, and create shortcuts of the videos from the main folder and place them in the playlist folders.
ERROR: type should be string, got "\r\nhttps://www.youtube.com/user/ForgottenWeapons/playlists\r\n\r\nSay you want to archive that channel.\r\n\r\nThat channel has a \r\n\r\nSemi Auto pistol video play list\r\n\r\n&\r\n\r\nBeretta firearm video play list\r\n\r\nThose two play lists would have some of the same videos located in both play lists.\r\n\r\nRather than to duplicate say a 2gb file for 2 or more play lists, youtube-DL could download one file in the main folder, then create a shortcut in each of the playlists that the video is found to be in.\r\n\r\n"
request
low
Minor
602,787,949
godot
Press Enter on Remove will start the engine
**Godot version:** 3.2.2 beta 1 **OS/device including version:** Ubuntu 19.10 **Issue description:** If you click remove project from start GUI, it will start the engine instead of removing the project ![removebug](https://user-images.githubusercontent.com/58845030/79696345-82b43a00-8252-11ea-922b-33e67fb576fc.gif) **Steps to reproduce:** * Open the engine * On project selection, select a project * Click remove * Instead of clicking to remove , press ENTER **Minimal reproduction project:** N/A
bug,topic:editor,usability
low
Critical
602,792,939
youtube-dl
[Feature request] Add a possibility to use ffmpeg (instead of AtomicParsey) to embed thumbnail in downloaded video
<!-- ###################################################################### WARNING! IGNORING THE FOLLOWING TEMPLATE WILL RESULT IN ISSUE CLOSED AS INCOMPLETE ###################################################################### --> ## Checklist <!-- Carefully read and work through this check list in order to prevent the most common mistakes and misuse of youtube-dl: - First of, make sure you are using the latest version of youtube-dl. Run `youtube-dl --version` and ensure your version is 2020.03.24. If it's not, see https://yt-dl.org/update on how to update. Issues with outdated version will be REJECTED. - Search the bugtracker for similar feature requests: http://yt-dl.org/search-issues. DO NOT post duplicates. - Finally, put x into all relevant boxes (like this [x]) --> - [x] I'm reporting a feature request - [x] I've verified that I'm running youtube-dl version **2020.03.24** - [x] I've searched the bugtracker for similar feature requests including closed ones ## Description <!-- Provide an explanation of your issue in an arbitrary form. Please make sure the description is worded well enough to be understood, see https://github.com/ytdl-org/youtube-dl#is-the-description-of-the-issue-itself-sufficient. Provide any additional information, suggested solution and as much context and examples as possible. --> Hi, Since version 4, `ffmpeg` is able to embed thumbnail in mp4 files : See https://www.ffmpeg.org/ffmpeg.html#Main-options and : https://stackoverflow.com/q/54717175/5649639 I cannot build/find `AtomicParsley` for SailfishOS, can you please add the possibility to use `ffmpeg` (instead of `AtomicParsley`) to embed thumbnail in downloaded video ? Thanks a lot to your team for your great amount of work for this great tool I use everyday (along with `mpv`:-) )
request
medium
Critical
602,818,872
godot
PopupMenu doesn't focus first item after gettting focus
**Godot version:** 3.2.2 Beta1 / 3.2.1 **OS/device including version:** Windows 10 **Issue description:** PopupMenu doesn't allow to set focused item and doesn't focus first item after getting focus **Steps to reproduce:** 1. Create PopupMenu 2. Call GrabFocus() on it or focus it via keyboard (for example if it's under current control you'd have to press down arrow twice instead of just once).
enhancement,topic:gui
low
Minor
602,824,252
flutter
`flutter test` fills tmpfs and fails with: (OS Error: No space left on device, errno = 28)
After developing for some time and running tests regularly, `flutter test` will eventually fail with: ``` flutter test 00:01 +0 -1: loading /home/nion/app/test/AuthenticationService_test.dart [E] FileSystemException: Cannot copy file to '/run/user/1000/flutter_test_listener.SYBRHD/listener.dart.dill', path = '/run/user/1000/flutter_test_compiler.AWQONU/output.dill' (OS Error: No space left on device, errno = 28) dart:io/file_impl.dart 338:9 _File.copy.<fn> package:stack_trace/src/stack_zone_specification.dart 129:26 StackZoneSpecification._registerUnaryCallback.<fn>.<fn> package:stack_trace/src/stack_zone_specification.dart 209:15 StackZoneSpecification._run package:stack_trace/src/stack_zone_specification.dart 129:14 StackZoneSpecification._registerUnaryCallback.<fn> dart:async/zone.dart 1134:38 _rootRunUnary dart:async/zone.dart 1031:19 _CustomZone.runUnary dart:async/future_impl.dart 139:18 _FutureListener.handleValue dart:async/future_impl.dart 680:45 Future._propagateToListeners.handleValueCallback dart:async/future_impl.dart 709:32 Future._propagateToListeners dart:async/future_impl.dart 524:5 Future._completeWithValue dart:async/future_impl.dart 554:7 Future._asyncComplete.<fn> package:stack_trace/src/stack_zone_specification.dart 209:15 StackZoneSpecification._run package:stack_trace/src/stack_zone_specification.dart 119:48 StackZoneSpecification._registerCallback.<fn> dart:async/zone.dart 1126:13 _rootRun dart:async/zone.dart 1023:19 _CustomZone.run dart:async/zone.dart 925:7 _CustomZone.runGuarded dart:async/zone.dart 965:23 _CustomZone.bindCallbackGuarded.<fn> dart:async/schedule_microtask.dart 43:21 _microtaskLoop dart:async/schedule_microtask.dart 52:5 _startMicrotaskLoop dart:isolate-patch/isolate_patch.dart 118:13 _runPendingImmediateCallback dart:isolate-patch/isolate_patch.dart 175:5 _RawReceivePortImpl._handleMessage ===== asynchronous gap =========================== dart:async/zone.dart 1055:19 _CustomZone.registerUnaryCallback dart:async/future_impl.dart 275:23 Future.then dart:io/file_impl.dart 336:57 _File.copy package:file/src/forwarding/forwarding_file.dart 27:66 ForwardingFile.copy package:flutter_tools/src/test/test_compiler.dart 157:56 TestCompiler._onCompilationRequest ===== asynchronous gap =========================== dart:async/zone.dart 1055:19 _CustomZone.registerUnaryCallback dart:async-patch/async_patch.dart 73:23 _asyncThenWrapperHelper package:flutter_tools/src/test/test_compiler.dart TestCompiler._onCompilationRequest package:stack_trace/src/stack_zone_specification.dart 129:26 StackZoneSpecification._registerUnaryCallback.<fn>.<fn> package:stack_trace/src/stack_zone_specification.dart 209:15 StackZoneSpecification._run package:stack_trace/src/stack_zone_specification.dart 129:14 StackZoneSpecification._registerUnaryCallback.<fn> dart:async/zone.dart 1134:38 _rootRunUnary dart:async/zone.dart 1031:19 _CustomZone.runUnary dart:async/zone.dart 933:7 _CustomZone.runUnaryGuarded dart:async/stream_impl.dart 338:11 _BufferingStreamSubscription._sendData dart:async/stream_impl.dart 593:14 _DelayedData.perform dart:async/stream_impl.dart 709:11 _StreamImplEvents.handleNext dart:async/stream_impl.dart 669:7 _PendingEvents.schedule.<fn> package:stack_trace/src/stack_zone_specification.dart 209:15 StackZoneSpecification._run package:stack_trace/src/stack_zone_specification.dart 119:48 StackZoneSpecification._registerCallback.<fn> dart:async/zone.dart 1122:38 _rootRun dart:async/zone.dart 1023:19 _CustomZone.run dart:async/zone.dart 925:7 _CustomZone.runGuarded dart:async/zone.dart 965:23 _CustomZone.bindCallbackGuarded.<fn> package:stack_trace/src/stack_zone_specification.dart 209:15 StackZoneSpecification._run package:stack_trace/src/stack_zone_specification.dart 119:48 StackZoneSpecification._registerCallback.<fn> dart:async/zone.dart 1126:13 _rootRun dart:async/zone.dart 1023:19 _CustomZone.run dart:async/zone.dart 925:7 _CustomZone.runGuarded dart:async/zone.dart 965:23 _CustomZone.bindCallbackGuarded.<fn> dart:async/schedule_microtask.dart 43:21 _microtaskLoop dart:async/schedule_microtask.dart 52:5 _startMicrotaskLoop dart:isolate-patch/timer_impl.dart 393:30 _Timer._runTimers dart:isolate-patch/timer_impl.dart 418:5 _Timer._handleMessage dart:isolate-patch/isolate_patch.dart 174:12 _RawReceivePortImpl._handleMessage ===== asynchronous gap =========================== dart:async/zone.dart 1055:19 _CustomZone.registerUnaryCallback dart:async/stream_impl.dart 141:21 _BufferingStreamSubscription.onData dart:async/stream_impl.dart 114:10 new _BufferingStreamSubscription dart:async/stream_controller.dart 840:9 new _ControllerSubscription dart:async/stream_controller.dart 672:51 _StreamController._subscribe dart:async/stream_controller.dart 820:19 _ControllerStream._createSubscription dart:async/stream_impl.dart 474:9 _StreamImpl.listen package:flutter_tools/src/test/test_compiler.dart 54:31 new TestCompiler package:flutter_tools/src/test/flutter_platform.dart 459:22 FlutterPlatform._startTest ===== asynchronous gap =========================== dart:async/zone.dart 1055:19 _CustomZone.registerUnaryCallback dart:async-patch/async_patch.dart 73:23 _asyncThenWrapperHelper package:flutter_tools/src/test/flutter_platform.dart FlutterPlatform._startTest package:flutter_tools/src/test/flutter_platform.dart 368:36 FlutterPlatform.loadChannel package:flutter_tools/src/test/flutter_platform.dart 321:46 FlutterPlatform.load package:test_core/src/runner/loader.dart 224:36 Loader.loadFile.<fn> ===== asynchronous gap =========================== dart:async/zone.dart 1055:19 _CustomZone.registerUnaryCallback dart:async-patch/async_patch.dart 73:23 _asyncThenWrapperHelper package:test_core/src/runner/loader.dart Loader.loadFile.<fn> package:test_core/src/runner/load_suite.dart 98:31 new LoadSuite.<fn>.<fn> package:test_api/src/utils.dart 241:5 invoke package:test_core/src/runner/load_suite.dart 97:7 new LoadSuite.<fn> package:test_api/src/backend/invoker.dart 392:25 Invoker._onRun.<fn>.<fn>.<fn>.<fn> dart:async/future.dart 176:37 new Future.<fn> package:stack_trace/src/stack_zone_specification.dart 209:15 StackZoneSpecification._run package:stack_trace/src/stack_zone_specification.dart 119:48 StackZoneSpecification._registerCallback.<fn> dart:async/zone.dart 1122:38 _rootRun dart:async/zone.dart 1023:19 _CustomZone.run dart:async/zone.dart 925:7 _CustomZone.runGuarded dart:async/zone.dart 965:23 _CustomZone.bindCallbackGuarded.<fn> package:stack_trace/src/stack_zone_specification.dart 209:15 StackZoneSpecification._run package:stack_trace/src/stack_zone_specification.dart 119:48 StackZoneSpecification._registerCallback.<fn> dart:async/zone.dart 1126:13 _rootRun dart:async/zone.dart 1023:19 _CustomZone.run dart:async/zone.dart 949:23 _CustomZone.bindCallback.<fn> dart:async-patch/timer_patch.dart 23:15 Timer._createTimer.<fn> dart:isolate-patch/timer_impl.dart 384:19 _Timer._runTimers dart:isolate-patch/timer_impl.dart 418:5 _Timer._handleMessage dart:isolate-patch/isolate_patch.dart 174:12 _RawReceivePortImpl._handleMessage ===== asynchronous gap =========================== dart:async/zone.dart 1047:19 _CustomZone.registerCallback dart:async/zone.dart 964:22 _CustomZone.bindCallbackGuarded dart:async/timer.dart 54:45 new Timer dart:async/timer.dart 91:9 Timer.run dart:async/future.dart 174:11 new Future package:test_api/src/backend/invoker.dart 391:21 Invoker._onRun.<fn>.<fn>.<fn> dart:async/zone.dart 1126:13 _rootRun dart:async/zone.dart 1023:19 _CustomZone.run dart:async/zone.dart 1518:10 _runZoned dart:async/zone.dart 1465:12 runZoned package:test_api/src/backend/invoker.dart 378:9 Invoker._onRun.<fn>.<fn> dart:async/zone.dart 1126:13 _rootRun dart:async/zone.dart 1023:19 _CustomZone.run dart:async/zone.dart 1518:10 _runZoned dart:async/zone.dart 1465:12 runZoned package:test_api/src/backend/invoker.dart 144:7 Invoker.guard package:test_api/src/backend/invoker.dart 428:15 Invoker._guardIfGuarded package:test_api/src/backend/invoker.dart 377:7 Invoker._onRun.<fn> package:stack_trace/src/chain.dart 101:24 Chain.capture.<fn> dart:async/zone.dart 1126:13 _rootRun dart:async/zone.dart 1023:19 _CustomZone.run dart:async/zone.dart 1518:10 _runZoned dart:async/zone.dart 1465:12 runZoned package:stack_trace/src/chain.dart 99:12 Chain.capture package:test_api/src/backend/invoker.dart 376:11 Invoker._onRun package:test_api/src/backend/live_test_controller.dart 185:5 LiveTestController._run package:test_api/src/backend/live_test_controller.dart 40:37 _LiveTest.run dart:async/future.dart 202:37 new Future.microtask.<fn> dart:async/zone.dart 1122:38 _rootRun dart:async/zone.dart 1023:19 _CustomZone.run dart:async/zone.dart 925:7 _CustomZone.runGuarded dart:async/zone.dart 965:23 _CustomZone.bindCallbackGuarded.<fn> dart:async/zone.dart 1126:13 _rootRun dart:async/zone.dart 1023:19 _CustomZone.run dart:async/zone.dart 925:7 _CustomZone.runGuarded dart:async/zone.dart 965:23 _CustomZone.bindCallbackGuarded.<fn> dart:async/schedule_microtask.dart 43:21 _microtaskLoop dart:async/schedule_microtask.dart 52:5 _startMicrotaskLoop dart:isolate-patch/isolate_patch.dart 118:13 _runPendingImmediateCallback dart:isolate-patch/isolate_patch.dart 175:5 _RawReceivePortImpl._handleMessage ``` Tests in other test files (that should also be run as part of `flutter test`) simply take forever to load and seem to never timeout and I have to abort the tests manually. This issues persist until I go into `/run/user/1000` and remove all `flutter_*` folders, each being roughly 30mb big (my `/run/user/1000` tmpfs is 1.6G big which gets regularly filled up by the `flutter_*` folders): ``` --- /run/user/1000 -------------------------------------------------------------------------------------- 29.7 MiB [##########] /flutter_test_listener.XCCOIR 29.7 MiB [##########] /flutter_test_listener.CTVXFD 29.7 MiB [##########] /flutter_test_listener.QCBHYO 29.7 MiB [##########] /flutter_test_listener.YMKBQX 29.7 MiB [##########] /flutter_test_listener.CKULEK 29.7 MiB [######### ] /flutter_test_compiler.MWGKUL 29.7 MiB [######### ] /flutter_test_compiler.KTBNBO 29.7 MiB [######### ] /flutter_test_compiler.GDMGUG 29.7 MiB [######### ] /flutter_test_compiler.ICDFSA 29.7 MiB [######### ] /flutter_test_compiler.WWPTMM 29.7 MiB [######### ] /flutter_test_listener.WMWUWC 29.7 MiB [######### ] /flutter_test_listener.MQGSTX 29.7 MiB [######### ] /flutter_test_listener.MMQYMK 29.7 MiB [######### ] /flutter_test_compiler.PVUKKD 29.7 MiB [######### ] /flutter_test_listener.MBTQSW 29.7 MiB [######### ] /flutter_test_listener.XXOVBN 29.7 MiB [######### ] /flutter_test_listener.DVKTNI 29.7 MiB [######### ] /flutter_test_compiler.XWFCBA 29.7 MiB [######### ] /flutter_test_compiler.NUXDRO 29.7 MiB [######### ] /flutter_test_compiler.SYTFAA 29.2 MiB [######### ] /flutter_test_listener.CVBVQU 29.2 MiB [######### ] /flutter_test_listener.EQKLNR 29.2 MiB [######### ] /flutter_test_listener.NZXUNW 29.2 MiB [######### ] /flutter_test_listener.NOCCDZ 29.2 MiB [######### ] /flutter_test_listener.TGCJUF 29.2 MiB [######### ] /flutter_test_listener.FJDMCF 29.2 MiB [######### ] /flutter_test_listener.FMDYEV 29.2 MiB [######### ] /flutter_test_listener.QWOBMK 29.2 MiB [######### ] /flutter_test_listener.FNAEJD 29.2 MiB [######### ] /flutter_test_listener.NYVLFJ 29.2 MiB [######### ] /flutter_test_listener.IOISXB 29.2 MiB [######### ] /flutter_test_listener.NOLBMZ 29.2 MiB [######### ] /flutter_test_listener.NJYGQQ 29.2 MiB [######### ] /flutter_test_listener.JRLFOO 29.2 MiB [######### ] /flutter_test_compiler.HRLUJQ 29.2 MiB [######### ] /flutter_test_compiler.XHTQSU 29.2 MiB [######### ] /flutter_test_compiler.EUIHIE 29.2 MiB [######### ] /flutter_test_compiler.FMRWVA 29.2 MiB [######### ] /flutter_test_compiler.EYGDFA 29.2 MiB [######### ] /flutter_test_compiler.FAUSGC 29.2 MiB [######### ] /flutter_test_compiler.LXGSJF 29.2 MiB [######### ] /flutter_test_compiler.REZYVZ 29.2 MiB [######### ] /flutter_test_compiler.DWVOAO 29.2 MiB [######### ] /flutter_test_compiler.ONQVWH 29.2 MiB [######### ] /flutter_test_compiler.YXEYOF 29.2 MiB [######### ] /flutter_test_compiler.PDKVGU 29.2 MiB [######### ] /flutter_test_compiler.GSENCF 29.2 MiB [######### ] /flutter_test_compiler.SXRVMN 25.1 MiB [######## ] /flutter_tool.NQKBLU 25.1 MiB [######## ] /flutter_tool.LFMOOO 23.8 MiB [######## ] /flutter_test_compiler.PWDCXU ``` `/run/user/1000` is `XDG_RUNTIME_DIR`, which the flutter tools probably uses to store temporary files. It seems like (sometimes?) those are not removed when the test ends and thus they will eventually fill up all available space in the tmpfs. flutter doctor -v: ``` [ +28 ms] executing: [/nix/store/bxyz9r12vvlg2n37kmpk2rqjxi4s70gj-flutter-stable-1.12.13+hotfix.8-unwrapped/] git -c log.showSignature=false log -n 1 --pretty=format:%H [ +25 ms] Exit code 0 from: git -c log.showSignature=false log -n 1 --pretty=format:%H [ ] 0b8abb4724aa590dd0f429683339b1e045a1594d [ ] executing: [/nix/store/bxyz9r12vvlg2n37kmpk2rqjxi4s70gj-flutter-stable-1.12.13+hotfix.8-unwrapped/] git describe --match v*.*.* --first-parent --long --tags [ +9 ms] Exit code 0 from: git describe --match v*.*.* --first-parent --long --tags [ ] v1.12.13+hotfix.8-0-g0b8abb472 [ +4 ms] executing: [/nix/store/bxyz9r12vvlg2n37kmpk2rqjxi4s70gj-flutter-stable-1.12.13+hotfix.8-unwrapped/] git rev-parse --abbrev-ref HEAD [ +7 ms] Exit code 0 from: git rev-parse --abbrev-ref HEAD [ ] stable [ +29 ms] Artifact Instance of 'AndroidMavenArtifacts' is not required, skipping update. [ +3 ms] Artifact Instance of 'AndroidInternalBuildArtifacts' is not required, skipping update. [ ] Artifact Instance of 'IOSEngineArtifacts' is not required, skipping update. [ ] Artifact Instance of 'FlutterWebSdk' is not required, skipping update. [ +1 ms] Artifact Instance of 'WindowsEngineArtifacts' is not required, skipping update. [ ] Artifact Instance of 'MacOSEngineArtifacts' is not required, skipping update. [ ] Artifact Instance of 'LinuxEngineArtifacts' is not required, skipping update. [ ] Artifact Instance of 'LinuxFuchsiaSDKArtifacts' is not required, skipping update. [ ] Artifact Instance of 'MacOSFuchsiaSDKArtifacts' is not required, skipping update. [ ] Artifact Instance of 'FlutterRunnerSDKArtifacts' is not required, skipping update. [ ] Artifact Instance of 'FlutterRunnerDebugSymbols' is not required, skipping update. [ +21 ms] executing: /nix/store/3b7qf6qz9wxn74fwzrs04srsi227m3hv-android-studio-stable-3.6.1.0-unwrapped/jre/bin/java -version [ +50 ms] Exit code 0 from: /nix/store/3b7qf6qz9wxn74fwzrs04srsi227m3hv-android-studio-stable-3.6.1.0-unwrapped/jre/bin/java -version [ +1 ms] openjdk version "1.8.0_212-release" OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b4-5784211) OpenJDK 64-Bit Server VM (build 25.212-b4-5784211, mixed mode) [ +16 ms] executing: [/nix/store/bxyz9r12vvlg2n37kmpk2rqjxi4s70gj-flutter-stable-1.12.13+hotfix.8-unwrapped/] git rev-parse --abbrev-ref --symbolic @{u} [ +8 ms] Exit code 0 from: git rev-parse --abbrev-ref --symbolic @{u} [ ] origin/stable [ ] executing: [/nix/store/bxyz9r12vvlg2n37kmpk2rqjxi4s70gj-flutter-stable-1.12.13+hotfix.8-unwrapped/] git ls-remote --get-url origin [ +7 ms] Exit code 0 from: git ls-remote --get-url origin [ ] https://github.com/flutter/flutter.git [ +15 ms] executing: [/nix/store/bxyz9r12vvlg2n37kmpk2rqjxi4s70gj-flutter-stable-1.12.13+hotfix.8-unwrapped/] git -c log.showSignature=false log -n 1 --pretty=format:%ar [ +10 ms] Exit code 0 from: git -c log.showSignature=false log -n 1 --pretty=format:%ar [ ] 10 weeks ago [ +13 ms] executing: /home/nion/.cache/flutter/artifacts/engine/android-arm-profile/linux-x64/gen_snapshot [ +20 ms] Exit code 255 from: /home/nion/.cache/flutter/artifacts/engine/android-arm-profile/linux-x64/gen_snapshot [ ] At least one input is required Usage: gen_snapshot [<vm-flags>] [<options>] <dart-kernel-file> Common options: --help Display this message (add --verbose for information about all VM options). --version Print the VM version. To create a core snapshot: --snapshot_kind=core --vm_snapshot_data=<output-file> --isolate_snapshot_data=<output-file> <dart-kernel-file> To create an AOT application snapshot as assembly suitable for compilation as a static or dynamic library: --snapshot_kind=app-aot-assembly --assembly=<output-file> [--obfuscate] [--save-obfuscation-map=<map-filename>] <dart-kernel-file> To create an AOT application snapshot as an ELF shared library: --snapshot_kind=app-aot-elf --elf=<output-file> [--strip] [--obfuscate] [--save-obfuscation-map=<map-filename>] <dart-kernel-file> AOT snapshots can be obfuscated: that is all identifiers will be renamed during compilation. This mode is enabled with --obfuscate flag. Mapping between original and obfuscated names can be serialized as a JSON array using --save-obfuscation-map=<filename> option. See dartbug.com/30524 for implementation details and limitations of the obfuscation pass. [ +19 ms] executing: /nix/store/3b7qf6qz9wxn74fwzrs04srsi227m3hv-android-studio-stable-3.6.1.0-unwrapped/jre/bin/java -version [ +44 ms] Exit code 0 from: /nix/store/3b7qf6qz9wxn74fwzrs04srsi227m3hv-android-studio-stable-3.6.1.0-unwrapped/jre/bin/java -version [ ] openjdk version "1.8.0_212-release" OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b4-5784211) OpenJDK 64-Bit Server VM (build 25.212-b4-5784211, mixed mode) [ +2 ms] java -version โฃฝ[ +89 ms] executing: /home/nion/opt/android-sdk/platform-tools/adb devices -l [ +8 ms] Exit code 0 from: /home/nion/opt/android-sdk/platform-tools/adb devices -l [ ] List of devices attached [ +4 ms] [โœ“] Flutter (Channel stable, v1.12.13+hotfix.8, on Linux, locale en_US.UTF-8) [ +1 ms] โ€ข Flutter version 1.12.13+hotfix.8 at /nix/store/bxyz9r12vvlg2n37kmpk2rqjxi4s70gj-flutter-stable-1.12.13+hotfix.8-unwrapped [ ] โ€ข Framework revision 0b8abb4724 (10 weeks ago), 2020-02-11 11:44:36 -0800 [ ] โ€ข Engine revision e1e6ced81d [ ] โ€ข Dart version 2.7.0 โฃฝ[ +10 ms] executing: /home/nion/opt/android-sdk/platform-tools/adb devices -l [ +40 ms] List of devices attached [ +26 ms] executing: /home/nion/opt/android-sdk/tools/bin/sdkmanager --licenses [+2957 ms] [โœ“] Android toolchain - develop for Android devices (Android SDK version 29.0.3) [ ] โ€ข Android SDK at /home/nion/opt/android-sdk [ ] โ€ข Android NDK location not configured (optional; useful for native profiling support) [ ] โ€ข Platform android-29, build-tools 29.0.3 [ ] โ€ข ANDROID_HOME = /home/nion/opt/android-sdk [ ] โ€ข Java binary at: /nix/store/3b7qf6qz9wxn74fwzrs04srsi227m3hv-android-studio-stable-3.6.1.0-unwrapped/jre/bin/java [ ] โ€ข Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b4-5784211) [ ] โ€ข All Android licenses accepted. [ ] [โœ“] Android Studio (version 3.6) [ ] โ€ข Android Studio at /nix/store/3b7qf6qz9wxn74fwzrs04srsi227m3hv-android-studio-stable-3.6.1.0-unwrapped [ ] โ€ข Flutter plugin version 45.0.1 [ ] โ€ข Dart plugin version 192.7761 [ ] โ€ข Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b4-5784211) [ ] [!] Connected device [ ] ! No devices available [ ] ! Doctor found issues in 1 category. [ +7 ms] "flutter doctor" took 3,470ms. ```
a: tests,c: crash,tool,a: quality,P2,team-tool,triaged-tool
low
Critical
602,865,213
youtube-dl
Please add support for Docubay.com
<!-- ###################################################################### WARNING! IGNORING THE FOLLOWING TEMPLATE WILL RESULT IN ISSUE CLOSED AS INCOMPLETE ###################################################################### --> ## Checklist <!-- Carefully read and work through this check list in order to prevent the most common mistakes and misuse of youtube-dl: - First of, make sure you are using the latest version of youtube-dl. Run `youtube-dl --version` and ensure your version is 2020.03.24. If it's not, see https://yt-dl.org/update on how to update. Issues with outdated version will be REJECTED. - Make sure that all provided video/audio/playlist URLs (if any) are alive and playable in a browser. - Make sure that site you are requesting is not dedicated to copyright infringement, see https://yt-dl.org/copyright-infringement. youtube-dl does not support such sites. In order for site support request to be accepted all provided example URLs should not violate any copyrights. - Search the bugtracker for similar site support requests: http://yt-dl.org/search-issues. DO NOT post duplicates. - Finally, put x into all relevant boxes (like this [x]) --> - [x] I'm reporting a new site support request - [x] I've verified that I'm running youtube-dl version **2020.03.24** - [x] I've checked that all provided URLs are alive and playable in a browser - [x] I've checked that none of provided URLs violate any copyrights - [x] I've searched the bugtracker for similar site support requests including closed ones ## Example URLs <!-- Provide all kinds of example URLs support for which should be included. Replace following example URLs by yours. --> - Single video: https://www.docubay.com/last-shop-standing/ ## Description <!-- Provide any additional information. If work on your issue requires account credentials please provide them or explain how one can obtain them. --> This is a great on line indie documentaries source, so I believe it is going to be great adding support for this site as well. Thank you.
site-support-request
low
Critical
602,896,907
pytorch
jit.script leads to RuntimeError: attribute lookup is not defined on python value of type in some cases
## ๐Ÿ› Bug <!-- A clear and concise description of what the bug is. --> ``torch.jit.script`` sometimes leads to ``RuntimeError: attribute lookup is not defined on python value of type [some python object name]``. Not sure is this a bug or I am misusing jit.script since I know very little of jit in pytorch. Anyway, please see the reproduce demo below. ## To Reproduce ```python # backend.py import torch class bk: def __init__(self): pass def trace(self, a): return torch.trace(a) bkd = bk() ``` ```python # test1.py import backend import torch @torch.jit.script def f(a): return backend.bkd.trace(a) ``` ```python # test2.py import backend import torch @torch.jit.script def f(a): return backend.bk().trace(a) ``` ``python3 test2.py`` gives no error while ``python3 test1.py`` will raise ``` RuntimeError: attribute lookup is not defined on python value of type 'bk': File "", line 6 @torch.jit.script def f(a): return backend.bkd.trace(a) ~~~~~~~~~~~~~~~~~ <--- HERE ``` If this is due to my misunderstanding of pytorch.jit, please give me some suggestions on how to fix test1.py instead of claim new ``bk`` object within ``f``. <!-- If you have a code sample, error messages, stack traces, please provide it here as well --> ## Expected behavior <!-- A clear and concise description of what you expected to happen. --> ## Environment Please copy and paste the output from our [environment collection script](https://raw.githubusercontent.com/pytorch/pytorch/master/torch/utils/collect_env.py) (or fill out the checklist below manually). You can get the script and run it with: ``` wget https://raw.githubusercontent.com/pytorch/pytorch/master/torch/utils/collect_env.py # For security purposes, please check the contents of collect_env.py before running it. python collect_env.py ``` - PyTorch Version (e.g., 1.0): 1.4.0 - OS (e.g., Linux): macOS10.14.4 - How you installed PyTorch (`conda`, `pip`, source): pip - Build command you used (if compiling from source): - Python version: 3.6 - CUDA/cuDNN version: - GPU models and configuration: - Any other relevant information: ## Additional context <!-- Add any other context about the problem here. --> cc @suo
triage review,oncall: jit,triaged,small
low
Critical
602,915,523
excalidraw
Feature Request: Allow basic prototyping functionality
Based on [this Tweet](https://twitter.com/Vjeux/status/1248116161830506497). Maybe this is out-of-scope for excalidraw, but it would be nice if: 1. It could support basic prototyping functionality (like adding click handlers, transition to a new "screen", and so on). 2. It could support creating a shared library of components programmatically (e.g. in order to share stuff like custom buttons).
enhancement,discussion
low
Minor
602,992,468
pytorch
Problem with c10/utils/variant.h
## ๐Ÿ› Bug Hi I've encountered a problem with the code in "c10/utils/variant.h" while trying to build a C++ application. I've created a simple test program to explain the problem. The code Iโ€™m trying to build is the following one ```cpp //Include standard libraries #include <iostream> //Define namespace data //This can be included for example by another header file namespace data { } //Include torch library #include <torch/torch.h> int main(int argc, char* argv[]) { std::cout << torch::randn({3, 3}) << std::endl; return 0; } ``` The CMakeLists.txt is ``` cmake_minimum_required(VERSION 3.0 FATAL_ERROR) project(test_variant) find_package(Torch REQUIRED) add_executable(test_variant main.cpp) target_link_libraries(test_variant "${TORCH_LIBRARIES}") set_property(TARGET test_variant PROPERTY CXX_STANDARD 14) ``` Iโ€™ve added an empty โ€œdataโ€ namespace to better explain the problem. When I build the example I get a lot of errors like ``` ~/test_variant/libtorch/include/c10/util/variant.h:2519:7: error: invalid use of โ€˜voidโ€™ AUTO_RETURN(v && holds_alternative<I>(*v) ``` Iโ€™ve looked inside the file and it seems that the problem is the statement (line 1165 c10/utils/variant.h) ``` AUTO_REFREF_RETURN(recursive_union::get_alt( data(lib::forward<V>(v)), in_place_index_t<I>{})) ``` Where โ€œdataโ€ is incorrectly detected as the namespace Iโ€™ve added before the <torch/torch.h> inclusion. I think it should refer to the โ€œdataโ€ function which can be found in the same file at line 1743 (I tried to change its name and indeed the error is solved). Could this be an issue or itโ€™s something Iโ€™m doing wrong in my code? Thank you very much for your help ## Environment - PyTorch Version (e.g., 1.0): LibTorch 1.4.0 - OS (e.g., Linux): Ubuntu 16.04 (default compiler) - How you installed PyTorch (`conda`, `pip`, source): pre-built libraries - Build command you used (if compiling from source): N/A - Python version: N/A - CUDA/cuDNN version: N/A - GPU models and configuration: N/A - Any other relevant information: cpu mode only cc @yf225
module: cpp,triaged
low
Critical
603,037,858
pytorch
jit trace failed due to "failed to differentiate `prim::ListConstruct`"
## ๐Ÿ› Bug Failed to generate grad graph by using jit trace, error as following: RuntimeError: failed to differentiate `prim::ListConstruct` Could you help to check it please? ## To Reproduce <!-- If you have a code sample, error messages, stack traces, please provide it here as well --> ``` import torch import torch.nn as nn import torch.nn.functional as F class Net(nn.Module): def __init__(self): super(Net, self).__init__() def forward(self, x): x = F.relu(x) z = torch.cat([x, x]) return torch.sigmoid(z) n = Net() example_forward_input = torch.rand([2,3], requires_grad=True) model_script = torch.jit.trace(n, example_forward_input) lowered_graph,_ = torch._C._jit_pass_lower_graph(model_script.graph, model_script._c) grad = torch._C._jit_differentiate(lowered_graph) ``` ## Expected behavior generate grad graph. ## Environment Please copy and paste the output from our Collecting environment information... PyTorch version: 1.4.0a0+59402f5 Is debug build: No CUDA used to build PyTorch: None OS: CentOS Linux 7 (Core) GCC version: (GCC) 7.2.1 20170829 (Red Hat 7.2.1-1) CMake version: version 3.14.0 Python version: 3.6 Is CUDA available: No CUDA runtime version: No CUDA GPU models and configuration: No CUDA Nvidia driver version: No CUDA cuDNN version: No CUDA Versions of relevant libraries: [pip] numpy==1.16.3 [pip] numpydoc==0.7.0 [pip] torch==1.4.0a0+59402f5 [pip] torchviz==0.0.1 [environment collection script](https://raw.githubusercontent.com/pytorch/pytorch/master/torch/utils/collect_env.py) (or fill out the checklist below manually). You can get the script and run it with: ``` wget https://raw.githubusercontent.com/pytorch/pytorch/master/torch/utils/collect_env.py # For security purposes, please check the contents of collect_env.py before running it. python collect_env.py ``` - PyTorch Version (e.g., 1.0): - OS (e.g., Linux): - How you installed PyTorch (`conda`, `pip`, source): - Build command you used (if compiling from source): - Python version: - CUDA/cuDNN version: - GPU models and configuration: - Any other relevant information: ## Additional context <!-- Add any other context about the problem here. --> cc @suo
oncall: jit,triaged
low
Critical
603,064,786
rust
Poor error message when using crate in macro_rules
Hello, I wrote a macro and I forget using `$crate`, I wrote `crate` instead. The macro works fine in my lib but when I use it in another crate (or in examples code), I have a compilation error (itโ€™s normal) but the error message doesnโ€™t help me to find the problem. I tried this code: ```rust #[macro_export] macro_rules! a_macro { () => { crate::Foo {} }; } pub struct Foo {} #[cfg(test)] mod test { #[test] fn bar() { crate::a_macro!(); } } ``` ```rust fn main() { test::a_macro!(); } ``` I expected to see this happen: a message teeling me to use `$crate` instead of `crate` (or maybe a warning teeling itโ€™s not a good idea using `crate` in a exported macro). Instead, this happened: ``` error[E0422]: cannot find struct, variant or union type `Foo` in module `crate` --> examples/test.rs:2:5 | 2 | test::a_macro!(); | ^^^^^^^^^^^^^^^^^ not found in `crate` | = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) help: possible candidate is found in another module, you can import it into scope | 1 | use test::Foo; | ``` And if i use the crate name instead of `crate`, the example works but test doesnโ€™t: ``` error[E0433]: failed to resolve: use of undeclared type or module `test` --> src/lib.rs:4:9 | 4 | test::Foo {} | ^^^^ use of undeclared type or module `test` ... 14 | crate::a_macro!(); | ------------------ in this macro invocation ``` ### Meta `rustc --version --verbose`: ``` rustc 1.42.0 (b8cedc004 2020-03-09) binary: rustc commit-hash: b8cedc00407a4c56a3bda1ed605c6fc166655447 commit-date: 2020-03-09 host: x86_64-unknown-linux-gnu release: 1.42.0 LLVM version: 9.0 ```
A-diagnostics,A-resolve,A-macros,T-compiler,D-terse
low
Critical
603,124,416
TypeScript
Type of function field of union object types not inferred correctly when infer is based on undefined type
**TypeScript Version:** 3.7.x-dev.201xxxxx <!-- Search terms you tried before logging this (so others can find this issue more easily) --> **Search Terms:** union types, react prop union object type, union type infer **Code** ```ts import React from 'react' type Props = { name: string; } & ( | { isValid: true, onChange?: (valid: true) => void } | { isValid?: false, onChange?: (valid: false) => void } ) const a: Props = { name: "Eddie", isValid: true, onChange: (e) => { // type of e is true โœ… } } const b: Props = { name: "Eddie", isValid: false, onChange: (e) => { // type of e is false โœ… } } const c: Props = { name: "Eddie", onChange: (e) => { // type of e is any โŒ } } ``` [Playground Link](https://www.typescriptlang.org/play?ts=3.9.0-beta#code/JYWwDg9gTgLgBAJQKYEMDG8BmUIjgcilQ3wChSYBPMJOABRzAGc4BeOAb1LjgDsUQSAFxwmMKMF4BzANykAvnABkcABTc4AH05xgTAGooANsAAmI8QFckAGjgReAYQAWKaUgD8I1QDdjZiyhrAEo2AD44HwgzOHkNbQ5dA39TLzhMYyZbeydXdzTfFJEMoyzQ1giomLjg8jQHMTgUEQYIZjZODR5+QREAIgBRU1NgJD6bLqTDE3M4K1tJhxc3KWE1JHKIrh4dnYB6PbnqWghMOFo9OaDaQFBySbi40nreRoAjFsYWdm2dnrXB4ajcaTPTTALpTILXZLPKrbwbcKdXa7A5HGj2M4XFglLJwO67B51BrwNAfNpfJG-AT-IYjMYTaG5FZrVQIiqU5FwVFUdGnc5JJq8ShwQAy5PcFOQgA) **Expected behavior:** Typescript infers the type of the `e` argument correctly. It works without a problem when the inferred value is not a function. like this example: [Playground Link](https://www.typescriptlang.org/play?ts=3.9.0-beta#code/JYWwDg9gTgLgBAJQKYEMDG8BmUIjgcilQ3wChSYBPMJOABRzAGc4BeOAb1LjgDsUQSAFxwmMKMF4BzANykAvnABkcABTc4AH05xgTAGooANsAAmI8QFckAGjgA3Y2YtRrceRu0ddBp6YD8IpjGTLYOfoFwwUah7qQAlORoELxicCgiDBDMbJwaPPyCIgBEAKKmpsBIxTb5PoYm5nBWtnWOjS5uAPRdcA1mogAWEJZGpnAARrQtcICg5ApJKWkTmYws7Fw8BQLCcGUVVTV1ev1N0aG1W+EdUSG0PX1+QyNjk7TntPMepMmp8GirbLrPJXQq7faVaqXLbtZy3GL3XqnZ6jcZTeGxL7kIA) **Actual behavior:** Typescript infers the type of the `e` argument as any.
Bug
low
Minor
603,141,757
godot
Godot generates PVRTC-compressed texture with all zeros
**Godot version:** Godot 3.2.2.beta1 **OS/device including version:** MacOSX 10.14.6 (18G95) **Issue description:** Set texture VRAM compressed, enable pvrtc compression. Reimport texture, after GDST header it contains only zeros. Original file: ![background](https://user-images.githubusercontent.com/1177068/79743861-041cd280-830e-11ea-8804-b4732dd2168c.png) Compressed file: [background.png-14973fd1de8b151436931643db6aa461.pvrtc.stex.zip](https://github.com/godotengine/godot/files/4502921/background.png-14973fd1de8b151436931643db6aa461.pvrtc.stex.zip) **Steps to reproduce:** **Minimal reproduction project:**
bug,platform:ios,topic:editor,topic:porting,topic:import
low
Major
603,179,715
ant-design
Modal็š„้™ๆ€ๆ–นๆณ•ๅœจShadowDOMไธญๆŒ‰้’ฎ็‚นๅ‡ปๆ— ๆ•ˆ
- [x] I have searched the [issues](https://github.com/ant-design/ant-design/issues) of this repository and believe that this is not a duplicate. ### What problem does this feature solve? Modal็š„้™ๆ€ๆ–นๆณ•ๅœจShadowDOMไธญๆŒ‰้’ฎ็‚นๅ‡ปๆ— ๆ•ˆ DEMO๏ผš[https://chuyb.csb.app/](https://chuyb.csb.app/) ไปฃ็ ๏ผš[https://codesandbox.io/s/shadowdom-antd-modal-func-chuyb](https://codesandbox.io/s/shadowdom-antd-modal-func-chuyb) ### What does the proposed API look like? 1. ไฟฎๆ”นconfirm.tsx๏ผŒๆไพ›ๅ…จๅฑ€่ฎพ็ฝฎgetContainerๆ–นๆณ• ```javascript // ๆไพ›ๅ…จๅฑ€่ฎพ็ฝฎgetContainerๆ–นๆณ• let funcConfig: ModalFuncProps; export const setFuncConfig = (config: ModalFuncProps) => { funcConfig = config; } ``` ไฟฎๆ”นindex.tsx๏ผŒๅขžๅŠ ้™ๆ€ๆ–นๆณ•setFuncConfig ```javascript Modal.setFuncConfig = setFuncConfig; ``` 2. ไฟฎๆ”นconfirm.tsx๏ผŒไฟฎๆ”นconfirmไธญๆธฒๆŸ“ๅฎนๅ™จdiv็š„่Žทๅ–ๆ–นๅผ ```javascript function getFuncContainer(containerFn: GetContainer) { let funcContainer: HTMLElement = containerFn as HTMLElement; if (typeof containerFn === 'function') { funcContainer = containerFn(); } else if (typeof containerFn === 'string') { funcContainer = document.querySelector(containerFn); } return funcContainer; } export default function confirm(config: ModalFuncProps) { // eslint-disable-next-line no-use-before-define let currentConfig = { ...funcConfig, ...config, close, visible: true } as any; const div = document.createElement('div'); const containerFn = currentConfig.getContainer; if (containerFn) { const root: HTMLElement = getFuncContainer(containerFn); root.appendChild(div); } else { document.body.appendChild(div); } ``` <!-- generated by ant-design-issue-helper. DO NOT REMOVE -->
Inactive
low
Minor
603,219,401
TypeScript
Feature Request: In JS, check if the non-widened type of an object property satisfies type constraints
<!-- ๐Ÿšจ STOP ๐Ÿšจ ๐—ฆ๐—ง๐—ข๐—ฃ ๐Ÿšจ ๐‘บ๐‘ป๐‘ถ๐‘ท ๐Ÿšจ Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Please help us by doing the following steps before logging an issue: * Search: https://github.com/Microsoft/TypeScript/search?type=Issues * Read the FAQ, especially the "Common Feature Requests" section: https://github.com/Microsoft/TypeScript/wiki/FAQ --> ## Search Terms javascript as const, expando literal ## Suggestion I am providing declaration files that are mainly consumed by JS projects. The API I'm writing these declaration files for is very strict in what it accepts and I am mirroring that in the declarations. Users often stumble across assignments that seem perfectly valid, but are not accepted by TypeScript. The reason is the widening from literal types to `string`. Here's a (dumbed down) example: ```js /** @param {{prop1: "a" | "b"}} arg */ function foo(arg) {} const arg = {}; arg.prop1 = "a"; foo(arg); // error here: string is not compatible with "a" | "b". const arg2 = { prop1: "b" }; foo(arg2); // Also an error ``` While in TypeScript, I can just put `as const` behind the assignment, there's no such thing in JS. Therefore I propose that when type-checking such constructs, the implicit literal type (here: `prop1: "a"`, resp. `prop1: "b"`) is taken into account. ## Use Cases Simplifying usage of strictly-typed libraries from JavaScript. Many JS users don't know what to do with those kinds of error messages and assume that there's a bug in the library or type definitions. ## Examples Here's how it could work: ```js const arg2 = { prop1: "b" }; foo(arg2); // should be fine, arg2.prop1 should be considered as literal `"b"` for this call arg2.prop1 = "a"; foo(arg2); // should still be fine, CFA should know that prop1 is of type `"a"` arg2.prop1 = someFunctionThatReturnsString(); foo(arg2); // should be an error, since prop1 can now be any string arg2.prop1 = "a"; foo(arg2); // should be fine again, since the last assignment was the literal `"a"` ``` ## Checklist My suggestion meets these guidelines: * [x] This wouldn't be a breaking change in existing TypeScript/JavaScript code - **It would change existing behavior, but I would argue it is not breaking.** * [x] This wouldn't change the runtime behavior of existing JavaScript code * [x] This could be implemented without emitting different JS based on the types of the expressions * [x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.) * [x] This feature would agree with the rest of [TypeScript's Design Goals](https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals).
Suggestion,In Discussion
low
Critical
603,236,908
rust
Fields should not alias Vec content.
I tried this code ( https://rust.godbolt.org/z/GuvQi9 ), which mutates a field while reading the content of a buffer. ```rust use std::vec::Vec; pub fn foo(v: &mut Vec<usize>) -> usize { assert!(v.len() > 2); let s1 = v.pop().unwrap(); let s2 = v.pop().unwrap(); s1 + s2 } ``` Here the assertion is capable of removing the branches which are within the `pop` function, to make a branch-less function apart from the assertion code: ``` [โ€ฆ] mov rcx, qword ptr [rdi + 16] [โ€ฆ] lea rax, [rcx - 1] mov qword ptr [rdi + 16], rax [โ€ฆ] lea rsi, [rcx - 2] mov qword ptr [rdi + 16], rsi [โ€ฆ] ``` However, the generated code still contains a spill of the `len` field of the vector for each pop-ed value which is used. The reason is that LLVM does not know whether the read type can alias or not the field which is being written to. This aliasing reason is inconsistent with the fact that the `len` field from which the value which is written back to memory is aliased in the `rcx` register. I would have expected the generated code to contain a single update of the `len` field, instead of 2. Testing with `-C opt-level=3` does not change the result. ### Meta Tested with both `rustc --version --verbose`: ``` rustc 1.42.0 (b8cedc004 2020-03-09) binary: rustc commit-hash: b8cedc00407a4c56a3bda1ed605c6fc166655447 commit-date: 2020-03-09 host: x86_64-unknown-linux-gnu release: 1.42.0 LLVM version: 9.0 ``` and ``` rustc 1.44.0-nightly (7f3df5772 2020-04-16) binary: rustc commit-hash: 7f3df5772439eee1c512ed2eb540beef1124d236 commit-date: 2020-04-16 host: x86_64-unknown-linux-gnu release: 1.44.0-nightly LLVM version: 9.0 ``` edit: remove the `-Zmutable_noalias` as this seems to optimize this minimized test case. https://github.com/rust-lang/rust/issues/71354#issuecomment-617105118
A-LLVM,I-slow,C-enhancement,A-codegen,T-compiler,C-optimization
low
Major
603,259,767
scrcpy
package h264 output as video capture device for use by other apps
I would like to use scrcopy output in other apps, as video capture device. For example this would allow to use instagram app video effects camera and then feed it to skype, zoom, twitch, obs, etc. There is already part of the solution (as I see it, could be wrong of course) in ws-scrcopy fork (websocket server). Maybe could process it with v4l2loopback tools to make virtual "videocam" in linux. unfortunately do not know of similar library in windows. but there are windows apps, e.g. xsplit-vcam or chromacam - which create such devices on windows too. but there is a code for obs plugin that simulates virtual webcam under Windows. https://github.com/CatxFish/obs-virtual-cam ![image](https://user-images.githubusercontent.com/13075980/79759741-bdd46d00-8327-11ea-912e-7e0afaf18a79.png) ![image](https://i.ytimg.com/vi/ns8IXRTw9PI/maxresdefault.jpg)
feature request,webcam
low
Major
603,271,404
go
runtime: "fatal: systemstack called from unexpected goroutine" on armv6
<!-- Please answer these questions before submitting your issue. Thanks! For questions please use one of our forums: https://github.com/golang/go/wiki/Questions --> Note: I am using karalabe's xgo for compiling to ARM6 ### What version of Go are you using (`go version`)? <pre> $ go version go version go1.12.17 linux/amd64 </pre> ### Does this issue reproduce with the latest release? Yes, 1.12.17 and 1.14.0 both seem affected. ### What did you do? Cross-compile application with github.com/mattn/go-sqlite3 as only import to armv6, with CGO_ENABLED=1 Code: ```golang package main import _ "github.com/mattn/go-sqlite3" func main() { println("Hello") } ``` Longer story is that my host OS is macOS, so I am using karalabe/go-1.12.12 by default, as target. However, I have also tested this on [go-1.12.17](https://github.com/chenrui333/xgo/blob/go-1.14/docker/go-1.12.17/Dockerfile) (`cd docker/go-1.12.17 && docker build -t karalabe/xgo-1.12.17`) and the latest, 1.14.0 (`cd docker/go-1.14.0 && docker build -t karalabe/xgo-1.14.0`), but no difference. I am able to get Segfault on three occasions: 1. use code without gomod, output of built executable will be `Segmentation fault` 2. use code with gomod (only `go get github.com/mattn/go-sqlite3` as package), output of executable will be `Segmentation fault` 3. use code with gomod (only `go get github.com/mattn/[email protected]` as package), output of executable will be `fatal: systemstack called from unexpected goroutineSegmentation fault` ## Building ### Test environment Raspberry Pi Zero (not W). Building through cross-compilation because of no internet. ``` pi@raspberrypi:~ $ cat /proc/cpuinfo processor : 0 model name : ARMv6-compatible processor rev 7 (v6l) BogoMIPS : 997.08 Features : half thumb fastmult vfp edsp java tls CPU implementer : 0x41 CPU architecture: 7 CPU variant : 0x0 CPU part : 0xb76 CPU revision : 7 Hardware : BCM2835 Revision : 900093 Serial : 0000000088a33a5e pi@raspberrypi:~ $ uname -a Linux raspberrypi 4.14.98+ #1200 Tue Feb 12 20:11:02 GMT 2019 armv6l GNU/Linux ``` ### Not using gomod Build code: ``` $ mkdir diamondo25 && cd diamondo25 # write the main.go file from the code above $ nano main.go $ docker run -it -v $PWD:/code/ -w /code/ --entrypoint bash karalabe/xgo-1.12.17 root@91db62d6dde7:/code# export CC=arm-linux-gnueabihf-gcc-5 GOOS=linux GOARCH=arm GOARM=6 CGO_ENABLED=1 root@91db62d6dde7:/code# CGO_CFLAGS='-march=armv6' CGO_CXXFLAGS='-march=armv6' go install std root@91db62d6dde7:/code# go get github.com/mattn/go-sqlite3 root@91db62d6dde7:/code# go build -o hello . root@91db62d6dde7:/code# exit ``` There's now a `hello` executable in the 'diamondo25' folder. Copy the binary to a armv6l box. Running the executable SEGFAULTs right away: ``` pi@raspberrypi:~ $ ./hello Segmentation fault pi@raspberrypi:~ $ file hello hello: ELF 32-bit LSB executable, ARM, EABI5 version 1 (SYSV), dynamically linked, interpreter /lib/ld-linux-armhf.so.3, for GNU/Linux 3.2.0, BuildID[sha1]=c60aae380bfbd3f2292bfa0a5718ecaece5cb328, not stripped ``` GDB doesn't help much: ``` pi@raspberrypi:~ $ gdb hello GNU gdb (Raspbian 7.12-6) 7.12.0.20161007-git Copyright (C) 2016 Free Software Foundation, Inc. License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html> This is free software: you are free to change and redistribute it. There is NO WARRANTY, to the extent permitted by law. Type "show copying" and "show warranty" for details. This GDB was configured as "arm-linux-gnueabihf". Type "show configuration" for configuration details. For bug reporting instructions, please see: <http://www.gnu.org/software/gdb/bugs/>. Find the GDB manual and other documentation resources online at: <http://www.gnu.org/software/gdb/documentation/>. For help, type "help". Type "apropos word" to search for commands related to "word"... Reading symbols from hello...done. warning: Missing auto-load script at offset 0 in section .debug_gdb_scripts of file /home/pi/hello. Use `info auto-load python-scripts [REGEXP]' to list them. (gdb) r Starting program: /home/pi/hello [Thread debugging using libthread_db enabled] Using host libthread_db library "/lib/arm-linux-gnueabihf/libthread_db.so.1". Program received signal SIGSEGV, Segmentation fault. runtime.tracebackHexdump (stk=..., frame=0xbefffeb8, bad=3204447949) at /usr/local/go/src/runtime/traceback.go:992 992 /usr/local/go/src/runtime/traceback.go: No such file or directory. (gdb) bt #0 runtime.tracebackHexdump (stk=..., frame=0xbefffeb8, bad=3204447949) at /usr/local/go/src/runtime/traceback.go:992 #1 0x00000000 in ?? () Backtrace stopped: previous frame identical to this frame (corrupt stack?) ``` ### Using gomod ``` $ mkdir diamondo25_gomod && cd diamondo25_gomod # write the main.go file from the code above $ nano main.go $ docker run -it -v $PWD:/code/ -w /code/ --entrypoint bash karalabe/xgo-1.12.17 root@e35c28fde210:/code# go mod init hello go: creating new go.mod: module hello root@e35c28fde210:/code# go get github.com/mattn/go-sqlite3 go: finding github.com/mattn/go-sqlite3 v2.0.3+incompatible go: downloading github.com/mattn/go-sqlite3 v2.0.3+incompatible go: extracting github.com/mattn/go-sqlite3 v2.0.3+incompatible root@e35c28fde210:/code# export CC=arm-linux-gnueabihf-gcc-5 GOOS=linux GOARCH=arm GOARM=6 CGO_ENABLED=1 root@e35c28fde210:/code# CGO_CFLAGS='-march=armv6' CGO_CXXFLAGS='-march=armv6' go install std root@e35c28fde210:/code# go build -o hello . # Keep open for next variant ``` There's now a `hello` executable in the 'diamondo25_gomod' folder. The building of this executable took longer than the previous, no-gomod variant. Running this also reports `Segmentation fault` ### Using gomod with [email protected] Using the docker container shell, change the go-sqlite3 module to v1.11.0 ``` root@e35c28fde210:/code# go get github.com/mattn/[email protected] go: finding github.com/mattn/go-sqlite3 v1.11.0 go: downloading github.com/mattn/go-sqlite3 v1.11.0 go: extracting github.com/mattn/go-sqlite3 v1.11.0 root@c1619b650cc7:/code# go build -o hello . ``` Now, copying and running this executable will throw the `fatal: systemstack called from unexpected goroutineSegmentation fault` error: ``` pi@raspberrypi:~ $ ./hello fatal: systemstack called from unexpected goroutineSegmentation fault ``` GDB reports different info this time: ``` pi@raspberrypi:~ $ gdb hello GNU gdb (Raspbian 7.12-6) 7.12.0.20161007-git Copyright (C) 2016 Free Software Foundation, Inc. License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html> This is free software: you are free to change and redistribute it. There is NO WARRANTY, to the extent permitted by law. Type "show copying" and "show warranty" for details. This GDB was configured as "arm-linux-gnueabihf". Type "show configuration" for configuration details. For bug reporting instructions, please see: <http://www.gnu.org/software/gdb/bugs/>. Find the GDB manual and other documentation resources online at: <http://www.gnu.org/software/gdb/documentation/>. For help, type "help". Type "apropos word" to search for commands related to "word"... Reading symbols from hello... done. warning: Missing auto-load script at offset 0 in section .debug_gdb_scripts of file /home/pi/hello. Use `info auto-load python-scripts [REGEXP]' to list them. (gdb) r Starting program: /home/pi/hello [Thread debugging using libthread_db enabled] Using host libthread_db library "/lib/arm-linux-gnueabihf/libthread_db.so.1". fatal: systemstack called from unexpected goroutine Program received signal SIGSEGV, Segmentation fault. runtime.abort () at /usr/local/go/src/runtime/asm_arm.s:801 801 /usr/local/go/src/runtime/asm_arm.s: No such file or directory. (gdb) bt #0 runtime.abort () at /usr/local/go/src/runtime/asm_arm.s:801 #1 0x00063a48 in runtime.badsystemstack () at /usr/local/go/src/runtime/stubs.go:62 #2 0x00049748 in runtime.throw (s=...) at /usr/local/go/src/runtime/panic.go:610 #3 0x00000012 in ?? () Backtrace stopped: previous frame identical to this frame (corrupt stack?) ``` It is unclear where it really crashes, as it never reports the stack. I think this is causing the fatal exception.
NeedsInvestigation,compiler/runtime
low
Critical
603,275,525
terminal
"Peek" button to show screen behind Terminal
I'd like a **Peek** button on the TitleBar near the new tab **`+`** button or the minimize **`-`** button, just like Aero Peek. If you guys are redoing the composition work then please consider adding it to the TitleBar. So that when I hover over it, I can see the screen behind, rather than staying transparent all the time. _Originally posted by @Nirmal4G in https://github.com/microsoft/terminal/issues/603#issuecomment-615954708_
Area-UserInterface,Area-Extensibility,Product-Terminal,Issue-Task
low
Minor
603,278,139
flutter
Flutter Engine compile flag -fno-c++-static-destructors
We met some crashes when the user killed the app. For example: ``` Thread 34: Crashed 0 Flutter 0x000000010bffbe9c _OUTLINED_FUNCTION_6905 (in Flutter) (SkFontHost_mac.cpp:2483) 1 Flutter 0x000000010bdffd64 create_from_CTFontRef(std::__1::unique_ptr<__CTFont const, SkFunctionWrapper<void, void const, &(CFRelease)> >, std::__1::unique_ptr<void const, SkFunctionWrapper<void, void const, &(CFRelease)> >, std::__1::unique_ptr<SkStreamAsset, std::__1::default_delete<SkStreamAsset> >) (in Flutter) (SkFontHost_mac.cpp:782) 2 Flutter 0x000000010be01398 create_from_desc(__CTFontDescriptor const*) (in Flutter) (SkFontHost_mac.cpp:809) 3 Flutter 0x000000010be016c4 SkFontStyleSet_Mac::createTypeface(int) (in Flutter) (SkFontHost_mac.cpp:2449) 4 Flutter 0x000000010bf17318 txt::FontCollection::CreateMinikinFontFamily(sk_sp<SkFontMgr> const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) (in Flutter) (font_collection.cc:218) 5 Flutter 0x000000010bf16578 txt::FontCollection::FindFontFamilyInManagers(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) (in Flutter) (font_collection.cc:193) ``` At the same time the main thread stacktrace is: ``` Thread 0 name: com.apple.main-thread Thread 0: 1 libsystem_c.dylib 0x0000000210d04bb4 ___cxa_finalize_ranges (in libsystem_c.dylib) + 384 2 libsystem_c.dylib 0x0000000210d04ec4 _exit (in libsystem_c.dylib) + 24 3 UIKitCore 0x000000023dca6fec -[UIApplication terminateWithSuccess] (in UIKitCore) + 0 ``` ![image](https://user-images.githubusercontent.com/11627283/79761309-d490b900-8353-11ea-8bd6-9298e3848c5a.png) I think the reason is that 'SkTypefaceCache' has been destructed in main thread while the ui thread continue use it. So maybe: 1. Add '-fno-c++-static-destructors' to the compile flag 2. Or stop the child thread when the app is going to be killed by the user? Maybe I miss something๏ผŒhope to get suggestions from the Flutter team.
c: crash,engine,dependency: skia,customer: bytedance,P2,team-engine,triaged-engine
low
Critical
603,297,775
pytorch
Multiprocess DataLoader with DLPack conversion sometimes corrupts memory
## ๐Ÿ› Bug See the reproduction below for a minimal example. ## To Reproduce ```python import torch from torch.utils.data import Dataset, DataLoader from torch.utils.dlpack import to_dlpack, from_dlpack def collate(a): a = torch.LongTensor(a) acap = to_dlpack(a) b = from_dlpack(acap) assert(torch.equal(a, b)) # passes return a, b loader = DataLoader(dataset=[i for i in range(10000)], batch_size = 2000, collate_fn=collate, shuffle=True, num_workers=10) for i, (a, b) in enumerate(loader): assert torch.equal(a, b) # fails ``` The test fails. **[EDIT]** It only fails in the for loop outside the collate function; the test inside the collate function always passes. ## Expected behavior The test should pass. ## Environment - PyTorch Version (e.g., 1.0): 1.4.0 Release - OS (e.g., Linux): Linux - How you installed PyTorch (`conda`, `pip`, source): pip - Build command you used (if compiling from source): - Python version: 3.7 - CUDA/cuDNN version: 10.1 - GPU models and configuration: GeForce GTX 1070 - Any other relevant information: ## Additional Information The code works when multiprocessing is turned off (i.e. `num_workers=0`). The bug also appears randomly (but not rarely). cc @SsnL
module: multiprocessing,module: serialization,triaged,module: xnnpack
low
Critical
603,307,081
pytorch
JIT string ops and other miscellaneous ops probably shouldn't be in aten namespace
Self explanatory. It would be bc breaking to renamespace them but I feel that things that are not tensor operations shouldn't be dunked in the aten namespace. When we ever renamespace aten to torch, that would be a good opportunity to fix the namespace on these operators too. cc @suo
triage review,oncall: jit,triaged
low
Minor
603,331,023
node
flaky test-dgram-multicast-ssmv6-multi-process on linux
examples of failure from the last weeks masters: - https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/13723/ - https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/13706/ - https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/13640/ - https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/13516/ ```console Error Message [PARENT] sent "First message to send" to ff3e::1234:15000 [PARENT] sent "Second message to send" to ff3e::1234:15000 [PARENT] sent "Third message to send" to ff3e::1234:15000 [PARENT] sent "Fourth message to send" to ff3e::1234:15000 [PARENT] sendSocket closed [PARENT] Responses were not received within 5000 ms. [PARENT] Fail assert.js:142 throw err; ^ AssertionError [ERR_ASSERTION]: Failed at Timeout._onTimeout (/home/iojs/build/workspace/node-test-commit-custom-suites-freestyle/test/internet/test-dgram-multicast-ssmv6-multi-process.js:140:12) at listOnTimeout (internal/timers.js:549:17) at processTimers (internal/timers.js:492:7) { generatedMessage: true, code: 'ERR_ASSERTION', actual: undefined, expected: undefined, operator: 'fail' } ```
dgram,flaky-test
low
Critical
603,345,250
flutter
getPositionForOffset (and maybe getBoxesForRange) on canvas benchmark broken?
The `text_canvas_layout` benchmark seems to change the amount of work it performs per iteration as the benchmark progresses. `getPositionForOffset` is affected for both `single_line` and `multi_line` modes: ![getPositionForOffset](https://user-images.githubusercontent.com/211513/79771119-36650a80-82e3-11ea-8985-f0dc09d0d351.png) ![multi_line-getPositionForOffset](https://user-images.githubusercontent.com/211513/79771282-6dd3b700-82e3-11ea-89a6-fafe50b2311c.png) Most runs of `getBoxesForRange` look OK, e.g.: ![getBoxesForRange-OK](https://user-images.githubusercontent.com/211513/79771501-ba1ef700-82e3-11ea-96d5-3ee7550355fe.png) However, there are runs (particularly `multi_line`) that either have extremely long warm-up period, or are affected by a similar bug to the one affecting `getPositionForOffset`: ![getBoxesForRange-strange](https://user-images.githubusercontent.com/211513/79771715-036f4680-82e4-11ea-92fc-0ebf0e0413fd.png) /cc @mdebbar
framework,engine,c: performance,a: typography,platform-web,team: benchmark,P2,team-web,triaged-web
low
Critical
603,355,259
pytorch
Pull hacked twins out of prim ops
Special-cased codegen for 4 ops to handle optional tensors in JIT is replaced temporarily with handwritten bindings in https://github.com/pytorch/pytorch/pull/36666. These need to be removed ASAP; they're vulnerable to drift from the `native_functions` bindings they were originally derived from. cc @suo
oncall: jit,triaged
low
Minor
603,367,636
godot
Amkette Evo Gamepad Pro 2 controller for android is reporting wrong values for axis
**Godot version:** Godot 3.2.1 **OS/device including version:** Windows 10 Pro **Issue description:** Amkette Evo Gamepad Pro 2 controller for android is reporting wrong values for joypad axis, I have an Xbox one controller which works just fine. **Steps to reproduce:** Connect Amkette Evo Gamepad Pro 2 controller to android and try adding axis input in Input Map and check the values for left and right analog joystick **Minimal reproduction project:**
bug,platform:windows,topic:input
low
Major
603,371,963
youtube-dl
error in tune.pk extractor
<!-- ###################################################################### WARNING! IGNORING THE FOLLOWING TEMPLATE WILL RESULT IN ISSUE CLOSED AS INCOMPLETE ###################################################################### --> ## Checklist <!-- Carefully read and work through this check list in order to prevent the most common mistakes and misuse of youtube-dl: - First of, make sure you are using the latest version of youtube-dl. Run `youtube-dl --version` and ensure your version is 2020.03.24. If it's not, see https://yt-dl.org/update on how to update. Issues with outdated version will be REJECTED. - Make sure that all provided video/audio/playlist URLs (if any) are alive and playable in a browser. - Make sure that all URLs and arguments with special characters are properly quoted or escaped as explained in http://yt-dl.org/escape. - Search the bugtracker for similar issues: http://yt-dl.org/search-issues. DO NOT post duplicates. - Read bugs section in FAQ: http://yt-dl.org/reporting - Finally, put x into all relevant boxes (like this [x]) --> - [x] I'm reporting a broken site support issue - [x] I've verified that I'm running youtube-dl version **2020.03.24** - [x] I've checked that all provided URLs are alive and playable in a browser - [x] I've checked that all URLs and arguments with special characters are properly quoted or escaped - [x] I've searched the bugtracker for similar bug reports including closed ones - [x] I've read bugs section in FAQ ## Verbose log <!-- Provide the complete verbose output of youtube-dl that clearly demonstrates the problem. Add the `-v` flag to your command line you run youtube-dl with (`youtube-dl -v <your command line>`), copy the WHOLE output and insert it below. It should look similar to this: [debug] System config: [] [debug] User config: [] [debug] Command-line args: [u'-v', u'http://www.youtube.com/watch?v=BaW_jenozKcj'] [debug] Encodings: locale cp1251, fs mbcs, out cp866, pref cp1251 [debug] youtube-dl version 2020.03.24 [debug] Python version 2.7.11 - Windows-2003Server-5.2.3790-SP2 [debug] exe versions: ffmpeg N-75573-g1d0487f, ffprobe N-75573-g1d0487f, rtmpdump 2.4 [debug] Proxy map: {} <more lines> --> ``` PASTE VERBOSE LOG HERE ``` youtube-dl "https://tune.pk/video/8763931/ntsfr-mlb-p03e01-arabic" [TunePk] 8763931: Downloading webpage ERROR: Unable to extract tune player; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type youtube-dl -U to update. Be sure to call youtube-dl with the --verbose flag and include its complete output. fehmi@DESKTOP-5NS3UTH:~$ youtube-dl "https://tune.pk/video/8763931/ntsfr-mlb-p03e01-arabic" --verbose [debug] System config: [] [debug] User config: [] [debug] Custom config: [] [debug] Command-line args: [u'https://tune.pk/video/8763931/ntsfr-mlb-p03e01-arabic', u'--verbose'] [debug] Encodings: locale UTF-8, fs UTF-8, out UTF-8, pref UTF-8 [debug] youtube-dl version 2020.03.24 [debug] Python version 2.7.17 (CPython) - Linux-4.4.0-18362-Microsoft-x86_64-with-Ubuntu-18.04-bionic [debug] exe versions: ffmpeg 3.4.6, ffprobe 3.4.6, phantomjs ., rtmpdump 2.4 [debug] Proxy map: {} [TunePk] 8763931: Downloading webpage ERROR: Unable to extract tune player; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type youtube-dl -U to update. Be sure to call youtube-dl with the --verbose flag and include its complete output. Traceback (most recent call last): File "/usr/local/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 797, in extract_info ie_result = ie.extract(url) File "/usr/local/bin/youtube-dl/youtube_dl/extractor/common.py", line 530, in extract ie_result = self._real_extract(url) File "/usr/local/bin/youtube-dl/youtube_dl/extractor/tunepk.py", line 52, in _real_extract r'new\s+TunePlayer\(({.+?})\)\s*;\s*\n', webpage, 'tune player'), File "/usr/local/bin/youtube-dl/youtube_dl/extractor/common.py", line 1005, in _search_regex raise RegexNotFoundError('Unable to extract %s' % _name) RegexNotFoundError: Unable to extract tune player; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type youtube-dl -U to update. Be sure to call youtube-dl with the --verbose flag and include its complete output. ## Description <!-- Provide an explanation of your issue in an arbitrary form. Please make sure the description is worded well enough to be understood, see https://github.com/ytdl-org/youtube-dl#is-the-description-of-the-issue-itself-sufficient. Provide any additional information, suggested solution and as much context and examples as possible. If work on your issue requires account credentials please provide them or explain how one can obtain them. --> can't download video from this page https://tune.pk/video/8763931/ntsfr-mlb-p03e01-arabic WRITE DESCRIPTION HERE
duplicate
low
Critical
603,373,822
rust
Regression in usable type complexity: overflow representing the type `...`
I tried building [the iron example of typed-html](https://github.com/bodil/typed-html/tree/master/examples/iron) (version 810fc820, but it's not changing frequently) the code is heavy with (partially recursive) generic types. With the latest beta (1.43) or stable (1.42), builds succeed; with nightly, they fail with: ``` $ cargo +nightly build --verbose [...] error: overflow representing the type `std::option::Option<&T>` error: aborting due to previous error error: could not compile `typed-html`. Caused by: process didn't exit successfully: `rustc --crate-name typed_html --edition=2018 typed-html/src/lib.rs --error-format=json --json=diagnostic-rendered-ansi --crate-type lib --emit=dep-info,metadata,link -C debuginfo=2 -C metadata=d47a854ad488ad21 -C extra-filename=-d47a854ad488ad21 --out-dir /tmp/typed-html/target/debug/deps -C incremental=/tmp/typed-html/target/debug/incremental -L dependency=/tmp/typed-html/target/debug/deps --extern htmlescape=/tmp/typed-html/target/debug/deps/libhtmlescape-93c9e1d0e3ad1b35.rmeta --extern language_tags=/tmp/typed-html/target/debug/deps/liblanguage_tags-25ca56886cd3e2ae.rmeta --extern mime=/tmp/typed-html/target/debug/deps/libmime-c67f239ef9444378.rmeta --extern proc_macro_hack=/tmp/typed-html/target/debug/deps/libproc_macro_hack-6271c07fb42254ec.so --extern proc_macro_nested=/tmp/typed-html/target/debug/deps/libproc_macro_nested-a84f2a4ba9005aa7.rmeta --extern strum=/tmp/typed-html/target/debug/deps/libstrum-13ea7f88aaf14180.rmeta --extern strum_macros=/tmp/typed-html/target/debug/deps/libstrum_macros-5e348577b435118e.so --extern typed_html_macros=/tmp/typed-html/target/debug/deps/libtyped_html_macros-3ce45005b6c7b859.so` (exit code: 1) ``` The iron example is comparatively simple typed-html usage. I've originally observed the same kind of regression in a [game](https://gitlab.com/chrysn/bloodweb) that uses typed-html. ### Meta This might be an occurrence of #32498; the behavior changing from stable/beta to nightly indicates a new issue and is thus reported anew. `rustc +nightly --version --verbose`: ``` rustc 1.44.0-nightly (dbf8b6bf1 2020-04-19) binary: rustc commit-hash: dbf8b6bf116c7bece2987ff4bd2792f008a6ee77 commit-date: 2020-04-19 host: x86_64-unknown-linux-gnu release: 1.44.0-nightly LLVM version: 9.0 ``` (Running with RUST_BACKTRACE does not change the output.) ### Bisection results I'm running `cargo bisect-rustc` on the code, which has narrowed it down to a regression in nightly-2020-04-10. I'll update this with a more detailled bisection result when it's ready, but that might be a while.
I-crash,P-medium,T-compiler,regression-from-stable-to-stable,C-bug
medium
Critical
603,416,184
svelte
component with transition directive didn't update correctly when store updated
**Describe the bug** When store get updated, I found component with transition directive won't update. It only happens when: * `store.update()` inside Promise `then()` block, if I move `store.update()` call to outside, it works as expected. * transition directive was added in component. **To Reproduce** [demo](https://svelte.dev/repl/421b79b111344633a5f5fbda0b1c2b5f?version=3.20.1) 1. click `tab2` button, text should be updated to `Hello Tab2` (can check console for store detail) 2. click `tab1` button again 3. click `tab2` button again, it now updates. ### work around * go to `Title.svelte`, remove `transition:fade`, rerun it * move store.update() outside of `then()`, rerun it. **Expected behavior** text should be updated. **Severity** small.
bug,temp-stale
low
Critical
603,442,453
flutter
Animate FAB in NavigationRail
Floating Action Buttons will normally animate in/out when added or removed from a Scaffold. When used in a NavigationRail, they disappear / appear instantly. ## Proposal Make the FAB animated when used in a NavigationRail ![ED61642D-9AEF-4095-9B6D-0AC943E1FC62-2639-00018198A6B63A94](https://user-images.githubusercontent.com/1145719/79786200-e47baf00-82f9-11ea-8dcb-91dc5b6e318f.gif) cc: @clocksmith
c: new feature,framework,a: animation,f: material design,c: proposal,P2,team-design,triaged-design
low
Minor
603,463,628
youtube-dl
skillbox.ru
<!-- ###################################################################### WARNING! IGNORING THE FOLLOWING TEMPLATE WILL RESULT IN ISSUE CLOSED AS INCOMPLETE ###################################################################### --> ## Checklist <!-- Carefully read and work through this check list in order to prevent the most common mistakes and misuse of youtube-dl: - First of, make sure you are using the latest version of youtube-dl. Run `youtube-dl --version` and ensure your version is 2020.03.24. If it's not, see https://yt-dl.org/update on how to update. Issues with outdated version will be REJECTED. - Make sure that all provided video/audio/playlist URLs (if any) are alive and playable in a browser. - Make sure that site you are requesting is not dedicated to copyright infringement, see https://yt-dl.org/copyright-infringement. youtube-dl does not support such sites. In order for site support request to be accepted all provided example URLs should not violate any copyrights. - Search the bugtracker for similar site support requests: http://yt-dl.org/search-issues. DO NOT post duplicates. - Finally, put x into all relevant boxes (like this [x]) --> - [x] I'm reporting a new site support request - [x] I've verified that I'm running youtube-dl version **2020.03.24** - [x] I've checked that all provided URLs are alive and playable in a browser - [x] I've checked that none of provided URLs violate any copyrights - [x] I've searched the bugtracker for similar site support requests including closed ones ## Example URLs <!-- Provide all kinds of example URLs support for which should be included. Replace following example URLs by yours. --> - Single video: https://www.youtube.com/watch?v=BaW_jenozKc - Single video: https://youtu.be/BaW_jenozKc - Playlist: https://www.youtube.com/playlist?list=PL4lCao7KL_QFVb7Iudeipvc2BCavECqzc ## Description <!-- Provide any additional information. If work on your issue requires account credentials please provide them or explain how one can obtain them. --> WRITE DESCRIPTION HERE Link to the resource and registration data: https://go.skillbox.ru/course/ps-s-nulya/8871270d-3c40-4353-9873-1c1e4333bd05 login: [email protected] passwd: 1q2w3e4r5t6y Link to m3u8 https://drive.google.com/open?id=1BMA9etLm7gJWqQ2F5DYoArm82jTSldiy Link to log https://drive.google.com/open?id=17P2sBBaN0b4-xyfieO7DGisqBfrduULY
site-support-request
low
Critical
603,471,602
TypeScript
Extract to function should include leading line comment if it is part of user's selection
<!-- ๐Ÿšจ STOP ๐Ÿšจ ๐—ฆ๐—ง๐—ข๐—ฃ ๐Ÿšจ ๐‘บ๐‘ป๐‘ถ๐‘ท ๐Ÿšจ Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Even if you think you've found a *bug*, please read the FAQ first, especially the Common "Bugs" That Aren't Bugs section! Please help us by doing the following steps before logging an issue: * Search: https://github.com/Microsoft/TypeScript/search?type=Issues * Read the FAQ: https://github.com/Microsoft/TypeScript/wiki/FAQ Please fill in the *entire* template below. --> <!-- Please try to reproduce the issue with the latest published version. It may have already been fixed. For npm: `typescript@next` This is also the 'Nightly' version in the playground: http://www.typescriptlang.org/play/?ts=Nightly --> **TypeScript Version:** 3.9.0-dev.20200420 <!-- Search terms you tried before logging this (so others can find this issue more easily) --> **Search Terms:** - extract to function - refactor / refactoring **Repro** ```ts function foo() { // log 1 console.log(1); // log 2 console.log(2); // log 3 console.log(3); } ``` 1. Select a block such as: ``` // log 2 console.log(2); ``` 2. Run the `extract to function` refactoring **Bug:** The extracted function moves over the code but leaves the line comment behind even though it was fully included in the selection: ```ts function foo() { // log 1 console.log(1); // log 2 newFunction(); // log 3 console.log(3); } function newFunction() { console.log(2); } ```
Bug,Help Wanted,Domain: Refactorings
low
Critical
603,484,710
youtube-dl
Please add support for Blod.gr
<!-- ###################################################################### WARNING! IGNORING THE FOLLOWING TEMPLATE WILL RESULT IN ISSUE CLOSED AS INCOMPLETE ###################################################################### --> ## Checklist <!-- Carefully read and work through this check list in order to prevent the most common mistakes and misuse of youtube-dl: - First of, make sure you are using the latest version of youtube-dl. Run `youtube-dl --version` and ensure your version is 2020.03.24. If it's not, see https://yt-dl.org/update on how to update. Issues with outdated version will be REJECTED. - Make sure that all provided video/audio/playlist URLs (if any) are alive and playable in a browser. - Make sure that site you are requesting is not dedicated to copyright infringement, see https://yt-dl.org/copyright-infringement. youtube-dl does not support such sites. In order for site support request to be accepted all provided example URLs should not violate any copyrights. - Search the bugtracker for similar site support requests: http://yt-dl.org/search-issues. DO NOT post duplicates. - Finally, put x into all relevant boxes (like this [x]) --> - [x] I'm reporting a new site support request - [x] I've verified that I'm running youtube-dl version **2020.03.24** - [x] I've checked that all provided URLs are alive and playable in a browser - [x] I've checked that none of provided URLs violate any copyrights - [x] I've searched the bugtracker for similar site support requests including closed ones ## Example URLs <!-- Provide all kinds of example URLs support for which should be included. Replace following example URLs by yours. --> - Single video: https://www.blod.gr/lectures/oi-siopiles-mihanes-tou-thanasi-rentzi-mia-elegeia-gia-ta-biomihanika-sparagmata-kai-topia/ ## Description <!-- Provide any additional information. If work on your issue requires account credentials please provide them or explain how one can obtain them. --> This is a very good site with on-line lectures about art and science, so it would be great if you could add support for this one. Thank you!
site-support-request
low
Critical
603,512,973
godot
Infinite loop in rich_text_label.cpp (ERROR: _process_line: Index line = 0 is out of bounds)
___ ***Bugsquad note:** This issue has been confirmed several times already. No need to confirm it further.* ___ **Godot version:** Godot 3.2.2.beta1 **OS/device including version:** MacOSX 10.14.6 (18G95) **Issue description:** Today all day I'm working on fixing pvrtc and twice my godot did hung up with this errors: ``` At: scene/gui/rich_text_label.cpp:170. ERROR: _process_line: Index line = 0 is out of bounds (l.offset_caches.size() = 0). At: scene/gui/rich_text_label.cpp:170. ERROR: _process_line: Index line = 0 is out of bounds (l.offset_caches.size() = 0). At: scene/gui/rich_text_label.cpp:170. ERROR: _process_line: Index line = 0 is out of bounds (l.offset_caches.size() = 0). At: scene/gui/rich_text_label.cpp:170. ERROR: _process_line: Index line = 0 is out of bounds (l.offset_caches.size() = 0). ``` It repeats in infinite cycle and godot interface is frozen. I can not reproduce it when I want to. But two times it happened. **Steps to reproduce:** **Minimal reproduction project:**
bug,confirmed,topic:gui
medium
Critical
603,553,523
godot
mismatched type on Reference::reference_get_count()
**Godot version:** master 95a1400 **OS/device including version:** Any **Issue description:** In core/reference.cpp, reference_get_count() has the following definition: ``` int Reference::reference_get_count() const { return refcount.get(); } ``` Note: refcount is of type SafeRefCount. In core/safe_refcount.h, SafeRefCount.get() has the definition: ``` _ALWAYS_INLINE_ uint32_t get() const { // nothrow return count; } ``` I recommend changing the signature of reference_get_count() to have the same unsigned-ness to prevent potential integer overflow. (Unless I am missing some subtle design decision.) **Steps to reproduce:** Create an reference object, explicitly reference it a bunch and it should go negative before the underlying reference count does. **Minimal reproduction project:**
bug,discussion,topic:core
low
Minor
603,563,255
godot
Windows Ink Pen Tablet can't minimize maximize or move with top bar
**Godot version:** 3.2 stable **OS/device including version:** Windows 10 **Issue description:** [https://www.dropbox.com/s/lg6tpsox40ushzq/GodotWindowsInkIssues.mkv?dl=0](url) **Steps to reproduce:** turn on windows ink, use try to maximize/minimize or move window using top bar **Minimal reproduction project:** [Uploading GodotWindowsInkBug.zipโ€ฆ]()
platform:windows,topic:input
low
Critical
603,563,361
tensorflow
mixed precision for non-Keras TensorFlow scripts
**System information** - TensorFlow version (you are using): 2.1.0 - Are you willing to contribute it (Yes/No): No (it would take too long for me to learn the low-level functionality of mixed-precision) **Describe the feature and the current behavior/state.** Currently, https://www.tensorflow.org/guide/keras/mixed_precision only works with Keras. **Will this change the current API? How?** The mixed_precision module will either be relocated so that it is not exclusively for Keras, or a new submodule will be created. **Who will benefit with this feature?** Users who want to use mixed-precision but aren't using Keras. **Any Other info.** I'm not sure if this is even possible.
type:feature,comp:apis
low
Major
603,579,610
go
cmd/compile: optimize bits.OnesCount(x) == 1
It'd be nice for the compiler to be able to optimize `bits.OnesCount(x) == 1` to `x&(x-1) != 0 && x != 0`. This is a bit tricky, because by the time we get to the rewrite rules, there's already a branch to check cpu feature availability. If we figure this out, there might be other math/bits function result comparisons we want to optimize. Implementation ideas welcome.
Performance,NeedsInvestigation,compiler/runtime
low
Major
603,583,133
TypeScript
TypeScript 3.9: Type files are behaving like included files
I'm trying to use the new TypeScript code editor support for solution projects and it's working pretty well, but has the issue mentioned in the title. When I add typeRoots or a type file, the referenced file isn't used just to get types from it. Instead, it acts like an included file for that project and the file's type checking follows that project configuration in the editor. tsconfig.json ```json { "files": [], "references": [ { "path": "./tsconfig.client.json" }, { "path": "./tsconfig.server.json" }, { "path": "./tsconfig.shared.json" } ] } ``` tsconfig.base.json ```json { "compilerOptions": { "baseUrl": "./", "composite": true, "declarationDir": "./@types", "emitDeclarationOnly": true, "lib": [ "ES5" ], "target": "ES5", "typeRoots": [ "node_modules/@types/", "lib/types/" ] } } ``` tsconfig.client.json ```json { "extends": "./tsconfig.base.json", "compilerOptions": { "lib": [ "ES6", "DOM" ], "target": "ES6", "types": [ "client", "shared" // This line is the problem ] }, "exclude": [ "lib/types/shared/" ], "include": [ "lib/types/client/" ] } ``` tsconfig.shared.json ```json { "extends": "./tsconfig.base.json", "compilerOptions": { "types": [ "shared" ] }, "include": [ "lib/types/shared/" ] } ``` lib/types/shared/index.d.ts ```typescript type ShouldNotHaveDomLib = Element; // This works, but should output an error ``` It seems like an issue with VSCode as building the project with "tsc --build" does throw the expected error: > lib/types/shared/index.d.ts:1:28 - error TS2304: Cannot find name 'Element'. > >1 type ShouldNotHaveDomLib = Element; I found that removing the "shared" types from tsconfig.client.json made the client types unavaliable as expected, but then made the server ones avaliable, as the "server" project is the second on the reference list. With this, I found a very simple solution: put "shared" project as the first referenced in "tsconfig.json" ```json { "files": [], "references": [ { "path": "./tsconfig.shared.json" }, { "path": "./tsconfig.client.json" }, { "path": "./tsconfig.server.json" } ] } ``` This solves the issue for me and yes, building the shared project first should be the standard, so not a huge deal for people using this project pattern. Still, it still is an unexpected behaviour and there might be some other patterns where this is a bigger issue. I searched for issues here, on TypeScript and Javascript and Typescript Nightly and found nothing, so I apologize if this is a duplicate and/or should be reported to one of those repositories. - VSCode Version: 1.44.2 (testes in latest insider too) - OS Version: Windows 10 19608 Steps to Reproduce: 1. Download the Javascript and Typescript Nightly extension 2. Set up project as above 3. Add some types to types/client/index.d.ts 4. Try to use those types in types/server/index.d.ts Does this issue occur when all extensions are disabled?: No, because I do need the Javascript and Typescript Nightly extension to use TS 3.9 features. However, it still happens while using it with only this extension.
Needs Investigation
low
Critical
603,584,073
rust
Make Option<T> `#[must_use]` if T is
I was recently refactoring some code that originally looked like this (minimized): ``` fn foo() {} async fn bar() { Some(foo()); } ``` bar() was far away from the definition of foo(). I had need to refactor the code so that foo was also async, and so now I had: ``` async fn foo() {} async fn bar() { Some(foo()); } ``` This gives no compiler diagnostic and instead the body of foo is not executed.
P-medium,T-lang,A-async-await,AsyncAwait-Triaged
low
Major
603,614,237
PowerToys
[Run] Move calc engine over to calc.exe (decimal, thousands delimiter etc.)
Once Calculator does https://github.com/microsoft/calculator/issues/526, it would be a great thing to move the engine over to calc's since then we'd be doing exact same calculations.
Idea-Enhancement,Product-PowerToys Run,Run-Plugin
low
Major
603,671,271
flutter
Unable to run "adb", check your Android SDK installation and ANDROID_HOME environment variable
<!-- Thank you for using Flutter! If you are looking for support, please check out our documentation or consider asking a question on Stack Overflow: * https://flutter.dev/ * https://api.flutter.dev/ * https://stackoverflow.com/questions/tagged/flutter?sort=frequent If you have found a bug or if our documentation doesn't have an answer to what you're looking for, then fill our the template below. Please read our guide to filing a bug first: https://flutter.dev/docs/resources/bug-reports --> Everything was fine a couple weeks ago when I last worked on a project. Don't know what caused anything to change. Went back to it to add a package, and `flutter pub get` would fail with `could not un-gzip`. I've tried uninstalling and reinstalling Flutter + Android Studio multiple times already to no luck. I'm able to create a new flutter project using VSCode, but when I run `flutter doctor`, it fails - as well as `flutter pub get` in the project directory I'm trying to work on. *note: I tried installing the latest version of Flutter, installing an older version and upgrading, as well as using the `git clone` method to install ## Logs `flutter pub get` ``` `Could not un-gzip (exit code -1073741819). Error:` `package:pub/src/io.dart 927:7 _extractTarGzWindows.<fn> ===== asynchronous gap =========================== package:pub/src/io.dart 820:20 withTempDir package:pub/src/io.dart 914:10 _extractTarGzWindows package:pub/src/io.dart 842:18 extractTarGz package:pub/src/source/hosted.dart 323:11 BoundHostedSource._download ===== asynchronous gap =========================== package:pub/src/source/hosted.dart 217:13 BoundHostedSource.downloadToSystemCache package:pub/src/entrypoint.dart 388:48 Entrypoint._get.<fn> package:pub/src/http.dart 271:51 withDependencyType package:pub/src/entrypoint.dart 384:12 Entrypoint._get dart:async Future.wait package:pub/src/entrypoint.dart 245:18 Entrypoint.acquireDependencies dart:async _completeOnAsyncReturn package:pub/src/solver/version_solver.dart VersionSolver.solve dart:async _completeOnAsyncReturn package:pub/src/solver/version_solver.dart VersionSolver._result` This is an unexpected error. Please run pub --trace '--verbosity=warning' get --no-precompile and include the logs in an issue on https://github.com/dart-lang/pub/issues/new Running "flutter pub get" in fire_interval_timer... pub get failed (1; and include the logs in an issue on https://github.com/dart-lang/pub/issues/new) ``` `flutter doctor -v` ``` `[!] Flutter (Channel stable, v1.12.13+hotfix.9, on Microsoft Windows [Version 10.0.18363.778], locale en-US) โ€ข Flutter version 1.12.13+hotfix.9 at C:\src\flutter โ€ข Framework revision f139b11009 (3 weeks ago), 2020-03-30 13:57:30 -0700 โ€ข Engine revision af51afceb8 โ€ข Dart version 2.7.2 X Downloaded executables cannot execute on host. See https://github.com/flutter/flutter/issues/6207 for more information` `[โˆš] Android toolchain - develop for Android devices (Android SDK version 29.0.3) โ€ข Android SDK at C:\Users\dag81\AppData\Local\Android\sdk โ€ข Android NDK location not configured (optional; useful for native profiling support) โ€ข Platform android-29, build-tools 29.0.3 โ€ข Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java โ€ข Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b04) โ€ข All Android licenses accepted.` `[โˆš] Android Studio (version 3.6) โ€ข Android Studio at C:\Program Files\Android\Android Studio โ€ข Flutter plugin version 45.1.1 โ€ข Dart plugin version 192.7761 โ€ข Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b04)` `[โˆš] VS Code (version 1.44.2) โ€ข VS Code at C:\Users\dag81\AppData\Local\Programs\Microsoft VS Code โ€ข Flutter extension version 3.9.1` `[โ˜ ] Connected device (the doctor check crashed) X Due to an error, the doctor check did not complete. If the error message below is not helpful, please let us know about this issue at https://github.com/flutter/flutter/issues. X Exception: Unable to run "adb", check your Android SDK installation and ANDROID_HOME environment variable: C:\Users\dag81\AppData\Local\Android\sdk\platform-tools\adb.exe โ€ข #0 throwToolExit (package:flutter_tools/src/base/common.dart:28:3) #1 getAdbDevices (package:flutter_tools/src/android/android_device.dart:731:5) #2 AndroidDevices.pollingGetDevices (package:flutter_tools/src/android/android_device.dart:65:53) #3 PollingDeviceDiscovery.devices (package:flutter_tools/src/device.dart:285:52) #4 DeviceManager.getAllConnectedDevices (package:flutter_tools/src/device.dart:140:46) <asynchronous suspension> #5 DeviceValidator.validate (package:flutter_tools/src/doctor.dart:851:54) #6 asyncGuard.<anonymous closure> (package:flutter_tools/src/base/async_guard.dart:111:32) #7 _rootRun (dart:async/zone.dart:1126:13) #8 _CustomZone.run (dart:async/zone.dart:1023:19) #9 _runZoned (dart:async/zone.dart:1518:10) #10 runZoned (dart:async/zone.dart:1502:12) #11 asyncGuard (package:flutter_tools/src/base/async_guard.dart:109:3) #12 Doctor.startValidatorTasks (package:flutter_tools/src/doctor.dart:158:9) #13 Doctor.diagnose (package:flutter_tools/src/doctor.dart:252:41) #14 _AsyncAwaitCompleter.start (dart:async-patch/async_patch.dart:45:6) #15 Doctor.diagnose (package:flutter_tools/src/doctor.dart:241:24) #16 DoctorCommand.runCommand (package:flutter_tools/src/commands/doctor.dart:59:39) #17 _AsyncAwaitCompleter.start (dart:async-patch/async_patch.dart:45:6) #18 DoctorCommand.runCommand (package:flutter_tools/src/commands/doctor.dart:45:42) #19 FlutterCommand.verifyThenRunCommand (package:flutter_tools/src/runner/flutter_command.dart:615:18) #20 _asyncThenWrapperHelper.<anonymous closure> (dart:async-patch/async_patch.dart:73:64) #21 _rootRunUnary (dart:async/zone.dart:1134:38) #22 _CustomZone.runUnary (dart:async/zone.dart:1031:19) #23 _FutureListener.handleValue (dart:async/future_impl.dart:139:18) #24 Future._propagateToListeners.handleValueCallback (dart:async/future_impl.dart:680:45) #25 Future._propagateToListeners (dart:async/future_impl.dart:709:32) #26 Future._completeWithValue (dart:async/future_impl.dart:524:5) #27 Future._asyncComplete.<anonymous closure> (dart:async/future_impl.dart:554:7) #28 _rootRun (dart:async/zone.dart:1126:13) #29 _CustomZone.run (dart:async/zone.dart:1023:19) #30 _CustomZone.runGuarded (dart:async/zone.dart:925:7) #31 _CustomZone.bindCallbackGuarded.<anonymous closure> (dart:async/zone.dart:965:23) #32 _microtaskLoop (dart:async/schedule_microtask.dart:43:21) #33 _startMicrotaskLoop (dart:async/schedule_microtask.dart:52:5) #34 _runPendingImmediateCallback (dart:isolate-patch/isolate_patch.dart:118:13) #35 _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:175:5)` `! Doctor found issues in 2 categories.` <!-- Include the full logs of the commands you are running between the lines with the backticks below. If you are running any "flutter" commands, please include the output of running them with "--verbose"; for example, the output of running "flutter --verbose create foo". --> ``` ``` <!-- If possible, paste the output of running `flutter doctor -v` here. --> ``` ```
tool,t: flutter doctor,found in release: 1.17,found in release: 1.12,found in release: 1.18,P3,team-tool,triaged-tool
medium
Critical
603,676,578
TypeScript
Evolving any behavior for local function variables
## Search Terms - evolving callback ## Suggestion When you declare a local variable whose type is implicitly `any`, it has an opportunity to ["evolve"][3] before triggering an implicit `any` error: ```ts let x = null; // type is any, but not an error if (Math.random() < 0.5) x = 'hello'; x; // type is string | null ``` My suggestion is to allow a similar behavior for functions whose parameters implicitly have an `any` type. This is currently an error, but there's nothing wrong with the code: ```ts { const mapFn = x => x * x; // Parameter 'x' implicitly has an 'any' type. (7006) [1, 2, 3].map(mapFn); } ``` If `x`'s type were allowed to "evolve" from `any` to `number`, this correct code would type check. Anders doesn't like "spooky action at a distance." But perhaps some limited, self-contained action within a block could solve this problem while avoiding the spookiness? ## Use Cases The loss of contextual types when you factor out a variable is a perennial pain point in TypeScript. See, for example: - [How TypeScript Breaks Referential Transparency][1] - [React+TypeScript Cheatsheet][2] This is felt most acutely with React components, where factoring out a function often forces you to dig through type declarations for fairly complicated event types. See below. ## Examples The `Array.prototype.map` example above is one. Here's an example with a React component. An inline handler requires no explicit types: ```ts function LoggedCell(props: {cellText: string}) { return ( <td onClick={e => { e.stopPropagation(); // do something }}>{props.cellText}</td> ); } ``` Factoring out the callback into a local variable produces a no implicit any error: ```ts function LoggedCell(props: {cellText: string}) { const clickFn = e => { // Parameter 'e' implicitly has an 'any' type.ts(7006) e.stopPropagation(); // .. do something ... }; return ( <td onClick={clickFn}>{props.cellText}</td> ); } ``` You can dig up the parameter type to fix this, but it's a mouthful: ```ts function MyComponent() { const clickFn = (e: React.SyntheticEvent<HTMLTableDataCellElement>) => { e.stopPropagation(); // .. do something ... }; return (<td onClick={clickFn}>Table Cell</td>); } ``` There's nothing really wrong with the middle version. I think it should work. Caveats: - Would this mean the type checker has to go back and type check the function body? Is that possible? Would that break lots of other things? - If you used the callback in two places, would its type have to be the union of the two? Evolving any has this behavior, e.g. if you push a `number` and a `string` onto an array, its type becomes `(number|string)[]`. - Is it OK to return the function? Or let its inferred type "escape" in some other way? - Like the current evolving any, this probably wouldn't work in functions (#35132). So you couldn't use it in a React component that calls `map`, for example: ```ts contents.map(cell => <td onClick={clickFn}>{cell}</td>); ``` ## Checklist My suggestion meets these guidelines: * [ ] This wouldn't be a breaking change in existing TypeScript/JavaScript code This would allow some code that triggers a type error now to pass. Not sure if that's what's meant by "breaking." The code that passes would be code that works correctly at runtime. * [x] This wouldn't change the runtime behavior of existing JavaScript code * [x] This could be implemented without emitting different JS based on the types of the expressions * [x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.) * [x] This feature would agree with the rest of [TypeScript's Design Goals](https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals). [1]: https://blog.logrocket.com/how-typescript-breaks-referential-transparency-7a82c0345f2c/ [2]: https://github.com/typescript-cheatsheets/react-typescript-cheatsheet/blob/master/README.md#forms-and-events [3]: https://effectivetypescript.com/2020/03/09/evolving-any/
Suggestion,In Discussion
low
Critical
603,752,781
create-react-app
Make it possible to build multiple branded web-sites from one codebase, e.g. by making the entry javascript file configurable (i.e. index.js / index.ts)
### Is your proposal related to a problem? I'm working on a codebase that will result in multiple similar deployed applications, but with small differences. At this point in time, only branding is different between the applications, but other differences will come over time. But they will share > 90% of the code base. ### Describe the solution you'd like By allowing you customize which entry point (i.e. 'index.js/index.ts') to use, I could have multiple entry points files: ```javascript // index.brand1.ts import './styles/brand1.scss' import './index.ts' // index.brand.2.ts import './styles.brand2.scss' import './index.ts' ``` As more and more features are distinguished from the different brands, more responsibility of configuration and composition can be moved to the individual entry points. ### Describe alternatives you've considered **Split the application into multiple codebases, sharing a common NPM package with all the reusable components** Although this approach my be the right approach in the future, at the moment it is overkill and will lead to too much complexity in the project setup. **Eject from CRA** The team isn't ready to maintain configuration of react, babel, eslint, tsc, etc. at this point in time. ### Additional context Our current solution is to have pre-build steps, that builds either brand1 or brand2's CSS files, and let the app reference the CSS output. That was the simplest solution that solves our need at the moment. But this approach will become painful once we start to add differences in behaviour, as the codebase would probably become littered with `if (process.env.BRAND_ID === "brand1") ...`
issue: proposal,needs triage
low
Minor
603,772,705
PowerToys
runner: automatic update should notify a user when it failed to get an installer multiple times
Currently we just silently try to redownload the installer after 24 hours without notifying a user. See the original discussion: https://github.com/microsoft/PowerToys/pull/2141#discussion_r411488824
Area-Runner,Area-Quality,Cost-Medium,Issue-Feature
low
Critical
603,794,319
pytorch
pytorch latest update(1.4) broke CosineAnnealingWarmRestarts: T_cur is not define
Hello, maybe i missing something, but my tests failed on CosineAnnealingWarmRestarts creation, the problem is: super(CosineAnnealingWarmRestarts, self).__init__(optimizer, last_epoch) self.T_cur = self.last_epoch the super class call the override step function that use self.T_cur that is not defined. minimal running example: ``` from torch import optim, nn from torch.optim import lr_scheduler model = nn.Conv2d(3, 3, 1) optimizer = optim.SGD(model.parameters(), lr=1.0) for param_group_dict in optimizer.param_groups: param_group_dict["initial_lr"] = param_group_dict["lr"] lr_scheduler.CosineAnnealingWarmRestarts(optimizer=optimizer, T_0=1, last_epoch=0) ``` link at discuss forum : https://discuss.pytorch.org/t/pytorch-latest-update-1-4-broke-cosineannealingwarmrestarts-t-cur-is-not-define/77495/2 cc @vincentqb
module: optimizer,triaged
low
Critical
603,797,610
youtube-dl
Unable to download videos with user and password on Raywenderlich
<!-- ###################################################################### WARNING! IGNORING THE FOLLOWING TEMPLATE WILL RESULT IN ISSUE CLOSED AS INCOMPLETE ###################################################################### --> ## Checklist <!-- Carefully read and work through this check list in order to prevent the most common mistakes and misuse of youtube-dl: - First of, make sure you are using the latest version of youtube-dl. Run `youtube-dl --version` and ensure your version is 2020.03.24. If it's not, see https://yt-dl.org/update on how to update. Issues with outdated version will be REJECTED. - Make sure that all provided video/audio/playlist URLs (if any) are alive and playable in a browser. - Make sure that site you are requesting is not dedicated to copyright infringement, see https://yt-dl.org/copyright-infringement. youtube-dl does not support such sites. In order for site support request to be accepted all provided example URLs should not violate any copyrights. - Search the bugtracker for similar site support requests: http://yt-dl.org/search-issues. DO NOT post duplicates. - Finally, put x into all relevant boxes (like this [x]) --> - [ ] I'm reporting a new site support request - [x] I've verified that I'm running youtube-dl version **2020.03.24** - [x] I've checked that all provided URLs are alive and playable in a browser - [x] I've checked that none of provided URLs violate any copyrights - [x] I've searched the bugtracker for similar site support requests including closed ones ## Example URLs <!-- Provide all kinds of example URLs support for which should be included. Replace following example URLs by yours. --> - Single video: https://www.youtube.com/watch?v=BaW_jenozKc - Single video: https://youtu.be/BaW_jenozKc - Playlist: https://www.youtube.com/playlist?list=PL4lCao7KL_QFVb7Iudeipvc2BCavECqzc ## Description <!-- Provide any additional information. If work on your issue requires account credentials please provide them or explain how one can obtain them. --> WRITE DESCRIPTION HERE ERROR: Unable to download JSON metadata: HTTP Error 403: Forbidden (caused by HTTPError());
site-support-request
low
Critical
603,799,204
go
debug/macho: no SymtabCmd data in *macho.Symtab Load after calling macho.Open()
<!-- Please answer these questions before submitting your issue. Thanks! For questions please use one of our forums: https://github.com/golang/go/wiki/Questions --> ### What version of Go are you using (`go version`)? <pre> $ go version go version go1.14.2 darwin/amd64 </pre> ### Does this issue reproduce with the latest release? Yes. ### What operating system and processor architecture are you using (`go env`)? <details><summary><code>go env</code> Output</summary><br><pre> $ go env GO111MODULE="" GOARCH="amd64" GOBIN="" GOCACHE="/Users/didi/Library/Caches/go-build" GOENV="/Users/didi/Library/Application Support/go/env" GOEXE="" GOFLAGS="" GOHOSTARCH="amd64" GOHOSTOS="darwin" GOINSECURE="" GONOPROXY="" GONOSUMDB="" GOOS="darwin" GOPATH="/Users/didi/dev/source/golang/gopath" GOPRIVATE="" GOPROXY="https://proxy.golang.org,direct" GOROOT="/usr/local/go" GOSUMDB="sum.golang.org" GOTMPDIR="" GOTOOLDIR="/usr/local/go/pkg/tool/darwin_amd64" GCCGO="gccgo" AR="ar" CC="clang" CXX="clang++" CGO_ENABLED="1" GOMOD="" CGO_CFLAGS="-g -O2" CGO_CPPFLAGS="" CGO_CXXFLAGS="-g -O2" CGO_FFLAGS="-g -O2" CGO_LDFLAGS="-g -O2" PKG_CONFIG="pkg-config" GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/n5/26_m50tn4_j2n3gmvt19300h0000gn/T/go-build965858086=/tmp/go-build -gno-record-gcc-switches -fno-common" </pre></details> ### What did you do? <!-- If possible, provide a recipe for reproducing the error. A complete runnable program is good. A link on play.golang.org is best. --> ```go file, _ := macho.Open("xxx.o") // which has Mach-O format with MH_OBJECT type for i, l := range file.Loads { switch lo := l.(type) { case *macho.Symtab: fmt.Println(lo.SymtabCmd) // nothing but zero value } } ``` ### What did you expect to see? Non-zero value of lo.SymtabCmd. ### What did you see instead? Zero value of lo.SymtabCmd. ### Possible causes parseSymtab() function in debug/macho/file.go: ```go ... st := new(Symtab) st.LoadBytes = LoadBytes(cmddat) st.Syms = symtab return st, nil } ``` ignore st.SymtabCmd ? It cound be: ```go ... st := new(Symtab) st.LoadBytes = LoadBytes(cmddat) st.Syms = symtab st.SymtabCmd = *hdr return st, nil } ```
help wanted,NeedsInvestigation
low
Critical
603,809,738
pytorch
[docs] Explain active_bytes in torch.cuda.memory_stats and Cuda Memory Management
In https://pytorch.org/docs/master/cuda.html#torch.cuda.memory_stats difference between "active_bytes" and "allocated_bytes"/"reserved_bytes" is not explained. Active bytes are also not mentioned here: https://pytorch.org/docs/master/notes/cuda.html#cuda-memory-management
module: docs,triaged
low
Minor
603,837,978
godot
Exported C# Negative enum causes console error spam
**Godot version:** Godot_v3.2.1-stable_mono_win64 **OS/device including version:** Windows 10 **Issue description:** In a c# script an enum with a negative value exported to inspector will cause errors to appear in console when a scene is opened or when the node with the script is selected. **Steps to reproduce:** Create a c# script, define an enum with a negative value, export it to inspector, observe the console: ![negativeEnumSpam](https://user-images.githubusercontent.com/37534273/79847632-47d01480-83c0-11ea-92d0-c8dafabd7434.jpg) **Minimal reproduction project:** [NegativeEnumIssue.zip](https://github.com/godotengine/godot/files/4508891/NegativeEnumIssue.zip) Open the project, open SceTest.tscn and check the errors appear in console.
bug,topic:editor,confirmed,topic:dotnet
low
Critical
603,842,203
TypeScript
Region collapse / folding in Visual Studio like done in C# settings
It would be great to support region collapse in TypeScript for Visual Studio like done in C# ![image](https://user-images.githubusercontent.com/13186600/79848471-684c9e80-83c1-11ea-83ea-221cbcfdc44b.png)
Suggestion,Visual Studio,In Discussion
low
Major
603,845,362
create-react-app
Override webpack configuration
### Question I'm always frustrated when I want to override webpack configuration. ### Proposal It would be awesome if the user can provide a webpack.config.js file to rewrite the webpack configuration.
issue: proposal,needs triage
low
Minor
603,850,204
flutter
How to change default entry 'main.dart' in different mode, like debug, staging and release in Add-To-App Android Project
[โœ“] Flutter (Channel stable, v1.12.13+hotfix.9, on Mac OS X 10.15.4 19E287, locale en-CN) โ€ข Flutter version 1.12.13+hotfix.9 at /Users/boostfield/Documents/dev/flutter โ€ข Framework revision f139b11009 (3 weeks ago), 2020-03-30 13:57:30 -0700 โ€ข Engine revision af51afceb8 โ€ข Dart version 2.7.2 [โœ“] Android toolchain - develop for Android devices (Android SDK version 29.0.3) โ€ข Android SDK at /Users/boostfield/Library/Android/sdk โ€ข Android NDK location not configured (optional; useful for native profiling support) โ€ข Platform android-29, build-tools 29.0.3 โ€ข Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java โ€ข Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b4-5784211) โ€ข All Android licenses accepted. [โœ“] Xcode - develop for iOS and macOS (Xcode 11.3.1) โ€ข Xcode at /Applications/Xcode.app/Contents/Developer โ€ข Xcode 11.3.1, Build version 11C504 โ€ข CocoaPods version 1.9.1 [โœ“] Android Studio (version 3.6) โ€ข Android Studio at /Applications/Android Studio.app/Contents โ€ข Flutter plugin version 45.1.1 โ€ข Dart plugin version 192.7761 โ€ข Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b4-5784211) [โœ“] VS Code (version 1.44.2) โ€ข VS Code at /Applications/Visual Studio Code.app/Contents โ€ข Flutter extension version 3.9.1 [โœ“] Connected device (2 available) โ€ข Liar โ€ข ea93d9ada61e97932624e1d3ad91badd9273dc1e โ€ข ios โ€ข iOS 13.3.1 โ€ข iPhone 8 โ€ข 5A5A40C7-926E-4AF2-935A-9C91F6DBD23F โ€ข ios โ€ข com.apple.CoreSimulator.SimRuntime.iOS-13-3 (simulator) โ€ข No issues found!
platform-android,tool,t: gradle,d: examples,a: existing-apps,P3,team-android,triaged-android
low
Critical
603,851,168
vue-element-admin
utils/index.jsๅฏผๅ…ฅelement-uiๆŠฅ้”™
<!-- ๆณจๆ„๏ผšไธบๆ›ดๅฅฝ็š„่งฃๅ†ณไฝ ็š„้—ฎ้ข˜๏ผŒ่ฏทๅ‚่€ƒๆจกๆฟๆไพ›ๅฎŒๆ•ดไฟกๆฏ๏ผŒๅ‡†็กฎๆ่ฟฐ้—ฎ้ข˜๏ผŒไฟกๆฏไธๅ…จ็š„ issue ๅฐ†่ขซๅ…ณ้—ญใ€‚ Note: In order to better solve your problem, please refer to the template to provide complete information, accurately describe the problem, and the incomplete information issue will be closed. --> ## Bug report๏ผˆ้—ฎ้ข˜ๆ่ฟฐ๏ผ‰ utils/index.js ๅฏผๅ…ฅelement-ui, ็„ถๅŽๅฏๅŠจไผšๅคฑ่ดฅ, ๅŽŸๅ› ๆ˜ฏmockๅ†…ๅผ•็”จไบ†param2Objๆ–นๆณ• ``` import { param2Obj } from '../src/utils' ``` #### Steps to reproduce๏ผˆ้—ฎ้ข˜ๅค็Žฐๆญฅ้ชค๏ผ‰ ``` // utils/index.js import { Message } from 'element-ui' // ๅฏผๅ…ฅๆญค่กŒไปฃ็  ``` ไฟฎๆ”นไปฃ็ ๅŽ, ้‡ๅฏ่ฐƒ่ฏ•ๆœๅŠก #### Screenshot or Gif๏ผˆๆˆชๅ›พๆˆ–ๅŠจๆ€ๅ›พ๏ผ‰ ![image](https://user-images.githubusercontent.com/10202760/79848904-4b7d8e80-83f4-11ea-81b3-fcb56fecdb17.png) #### Link to minimal reproduction๏ผˆๆœ€ๅฐๅฏๅœจ็บฟ่ฟ˜ๅŽŸdemo๏ผ‰ ๅŸบไบŽๅฎ˜ๆ–นไพ‹ๅญๅฏๅŠจๅณๅฏ #### ๅปบ่ฎฎ ๅฝ“็„ถๅฏไปฅๅ•็‹ฌๅ†™ไธ€ไธชๆ–‡ไปถ, ไฝ†่ฟ™ไธชๆŠฅ้”™ๅพˆ้šๆ™ฆ, ่ฐƒ่ฏ•่ฟ‡็จ‹ไธญไนŸไธไผšๅ‡บ็Žฐ้”™่ฏฏ, ๅชๆœ‰ไธ‹ๆฌกๅฏๅŠจ่ฐƒ่ฏ•ๆ‰ไผšๅ‘็Žฐ, ๆˆ‘ๆ˜ฏๆ นๆฎcommit็‰ˆๆœฌไธ€็›ดๅ›ž้€€ๅฎšไฝๆ–‡ไปถ, ็„ถๅŽๅฎšไฝ็š„ๅฏผๅŒ…ๆ‰่ƒฝ็Ÿฅ้“้”™่ฏฏๅŽŸๅ› 
enhancement :star:
low
Critical
603,869,986
flutter
flutter console output Chinese garbled in android studio 3.6.1 version
flutter console output Chinese garbled in android studio 3.6.1 version๏ผŒIn Android studio 3.5.3 and previous versions, there is no problem. In the 3.6.1 version, the native project output has no garbled characters, and the compilation format such as jvm has been modified, but only the flutter project will have Chinese garbled characters. ![FastStoneEditor1](https://user-images.githubusercontent.com/25734851/79852910-8500ca80-83f1-11ea-98ae-edd162c4b081.jpg)
c: regression,tool,a: internationalization,a: error message,P2,team-tool,triaged-tool
low
Major
603,880,582
flutter
[camera] Quality of image and video captured from flutter camera package is too dark on Moto G 5S Plus
Quality of image and video captured from flutter camera package is to dark as compared to builtin camera app and even if image_picker packages produce good quality of Image. I am trying to develop custom camera app and I want to control it programmatically like starting video record when app launches and after 1 min stop recording and if user want to stop before 1 min he/she can do it by stop-button widget.
e: device-specific,platform-android,a: quality,p: camera,package,P3,team-android,triaged-android
low
Major
603,937,424
flutter
Change height of GridView row to fixed height
I've noticed that GridView makes each child a square.. I know we can change dynamically height of grid view row by setting childAspectRatio. That however doesn't make it fixed so when the device rotate then the height changed as well In this example I want to have each input next to each other and keep it's height same on all devices and all display orientation. (nobody wants their text input change its height) ``` List<Map<String, dynamic>> list = [ {'description': 'des1'}, {'description': 'des2'}, {'description': 'des3'}, {'description': 'des4'}, {'description': 'des5'}, {'description': 'des6'} ]; class _MaterialScreenState extends State<MaterialScreen> { String text = ''; @override Widget build(BuildContext context) { double height = MediaQuery.of(context).size.height; double width = MediaQuery.of(context).size.width; return Scaffold( body: Column( children: <Widget>[ Text(text), GridView.builder( shrinkWrap: true, itemCount: list.length, gridDelegate: SliverGridDelegateWithFixedCrossAxisCount( crossAxisCount: 5, crossAxisSpacing: 5, mainAxisSpacing: 5, childAspectRatio: width / (height / 4)), itemBuilder: (BuildContext context, int index) { return TextFormField( textAlign: TextAlign.center, onTap: () => setState(() { text = list[index]['description']; }), decoration: InputDecoration( border: OutlineInputBorder(), //isDense: true, contentPadding: EdgeInsets.all(8)), ); }), ], )) ```
c: new feature,framework,f: scrolling,P3,team-framework,triaged-framework
medium
Critical
603,953,095
go
x/tools/gopls: pointer to struct value field/method candidates not offered in type switch
<!-- Please answer these questions before submitting your issue. Thanks! --> ### What version of Go are you using (`go version`)? <pre> $ go version go version devel +801cd7c84d Thu Apr 2 09:00:44 2020 +0000 linux/amd64 $ go list -m golang.org/x/tools golang.org/x/tools v0.0.0-20200408132156-9ee5ef7a2c0d $ go list -m golang.org/x/tools/gopls golang.org/x/tools/gopls v0.0.0-20200408132156-9ee5ef7a2c0d </pre> ### Does this issue reproduce with the latest release? Yes ### What operating system and processor architecture are you using (`go env`)? <details><summary><code>go env</code> Output</summary><br><pre> $ go env GO111MODULE="on" GOARCH="amd64" GOBIN="" GOCACHE="/home/myitcv/.cache/go-build" GOENV="/home/myitcv/.config/go/env" GOEXE="" GOFLAGS="" GOHOSTARCH="amd64" GOHOSTOS="linux" GOINSECURE="" GONOPROXY="" GONOSUMDB="" GOOS="linux" GOPATH="/home/myitcv/gostuff" GOPRIVATE="" GOPROXY="https://proxy.golang.org,direct" GOROOT="/home/myitcv/gos" GOSUMDB="sum.golang.org" GOTMPDIR="" GOTOOLDIR="/home/myitcv/gos/pkg/tool/linux_amd64" GCCGO="gccgo" AR="ar" CC="gcc" CXX="g++" CGO_ENABLED="1" GOMOD="/home/myitcv/gostuff/src/github.com/myitcv/govim/go.mod" CGO_CFLAGS="-g -O2" CGO_CPPFLAGS="" CGO_CXXFLAGS="-g -O2" CGO_FFLAGS="-g -O2" CGO_LDFLAGS="-g -O2" PKG_CONFIG="pkg-config" GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build844088039=/tmp/go-build -gno-record-gcc-switches" </pre></details> ### What did you do? I haven't been able to reduce the example to anything smaller than this unfortunately: ``` -- go.mod -- module mod.com go 1.12 require github.com/yuin/goldmark v1.1.27 -- main.go -- package main import ( "io/ioutil" "github.com/yuin/goldmark" "github.com/yuin/goldmark/ast" "github.com/yuin/goldmark/text" ) func main() { input, err := ioutil.ReadFile("input.md") if err != nil { panic(err) } p := goldmark.DefaultParser() r := text.NewReader(input) node := p.Parse(r) ast.Walk(node, func(n ast.Node, entering bool) (ast.WalkStatus, error) { if !entering { return ast.WalkContinue, nil } switch node := node.(type) { case *ast.HTMLBlock: node. case *ast.FencedCodeBlock: } return ast.WalkContinue, nil }) } ``` Attempting completion after `node.` in the `*ast.HTMLBlock:` case does not give any of the field/method candidates that should be offered for a value of type `*ast.HTMLBlock`. Instead we get: <details><summary>Candidates</summary><br><pre> &protocol.CompletionList{ IsIncomplete: true, Items: { { Label: "node", Kind: 6, Tags: nil, Detail: "*ast.HTMLBlock", Documentation: "", Deprecated: false, Preselect: true, SortText: "00000", FilterText: "node", InsertText: "", InsertTextFormat: 1, TextEdit: &protocol.TextEdit{ Range: protocol.Range{ Start: protocol.Position{Line:24, Character:8}, End: protocol.Position{Line:24, Character:8}, }, NewText: "node", }, AdditionalTextEdits: nil, CommitCharacters: nil, Command: (*protocol.Command)(nil), Data: nil, }, { Label: "entering", Kind: 6, Tags: nil, Detail: "bool", Documentation: "", Deprecated: false, Preselect: false, SortText: "00001", FilterText: "node", InsertText: "", InsertTextFormat: 1, TextEdit: &protocol.TextEdit{ Range: protocol.Range{ Start: protocol.Position{Line:24, Character:8}, End: protocol.Position{Line:24, Character:8}, }, NewText: "entering", }, AdditionalTextEdits: nil, CommitCharacters: nil, Command: (*protocol.Command)(nil), Data: nil, }, { Label: "n", Kind: 6, Tags: nil, Detail: "ast.Node", Documentation: "", Deprecated: false, Preselect: false, SortText: "00002", FilterText: "node", InsertText: "", InsertTextFormat: 1, TextEdit: &protocol.TextEdit{ Range: protocol.Range{ Start: protocol.Position{Line:24, Character:8}, End: protocol.Position{Line:24, Character:8}, }, NewText: "n", }, AdditionalTextEdits: nil, CommitCharacters: nil, Command: (*protocol.Command)(nil), Data: nil, }, { Label: "err", Kind: 6, Tags: nil, Detail: "error", Documentation: "", Deprecated: false, Preselect: false, SortText: "00003", FilterText: "node", InsertText: "", InsertTextFormat: 1, TextEdit: &protocol.TextEdit{ Range: protocol.Range{ Start: protocol.Position{Line:24, Character:8}, End: protocol.Position{Line:24, Character:8}, }, NewText: "err", }, AdditionalTextEdits: nil, CommitCharacters: nil, Command: (*protocol.Command)(nil), Data: nil, }, { Label: "input", Kind: 6, Tags: nil, Detail: "[]byte", Documentation: "", Deprecated: false, Preselect: false, SortText: "00004", FilterText: "node", InsertText: "", InsertTextFormat: 1, TextEdit: &protocol.TextEdit{ Range: protocol.Range{ Start: protocol.Position{Line:24, Character:8}, End: protocol.Position{Line:24, Character:8}, }, NewText: "input", }, AdditionalTextEdits: nil, CommitCharacters: nil, Command: (*protocol.Command)(nil), Data: nil, }, { Label: "p", Kind: 6, Tags: nil, Detail: "parser.Parser", Documentation: "", Deprecated: false, Preselect: false, SortText: "00005", FilterText: "node", InsertText: "", InsertTextFormat: 1, TextEdit: &protocol.TextEdit{ Range: protocol.Range{ Start: protocol.Position{Line:24, Character:8}, End: protocol.Position{Line:24, Character:8}, }, NewText: "p", }, AdditionalTextEdits: nil, CommitCharacters: nil, Command: (*protocol.Command)(nil), Data: nil, }, { Label: "r", Kind: 6, Tags: nil, Detail: "text.Reader", Documentation: "", Deprecated: false, Preselect: false, SortText: "00006", FilterText: "node", InsertText: "", InsertTextFormat: 1, TextEdit: &protocol.TextEdit{ Range: protocol.Range{ Start: protocol.Position{Line:24, Character:8}, End: protocol.Position{Line:24, Character:8}, }, NewText: "r", }, AdditionalTextEdits: nil, CommitCharacters: nil, Command: (*protocol.Command)(nil), Data: nil, }, { Label: "ast", Kind: 9, Tags: nil, Detail: "\"github.com/yuin/goldmark/ast\"", Documentation: "", Deprecated: false, Preselect: false, SortText: "00007", FilterText: "node", InsertText: "", InsertTextFormat: 1, TextEdit: &protocol.TextEdit{ Range: protocol.Range{ Start: protocol.Position{Line:24, Character:8}, End: protocol.Position{Line:24, Character:8}, }, NewText: "ast", }, AdditionalTextEdits: nil, CommitCharacters: nil, Command: (*protocol.Command)(nil), Data: nil, }, { Label: "goldmark", Kind: 9, Tags: nil, Detail: "\"github.com/yuin/goldmark\"", Documentation: "", Deprecated: false, Preselect: false, SortText: "00008", FilterText: "node", InsertText: "", InsertTextFormat: 1, TextEdit: &protocol.TextEdit{ Range: protocol.Range{ Start: protocol.Position{Line:24, Character:8}, End: protocol.Position{Line:24, Character:8}, }, NewText: "goldmark", }, AdditionalTextEdits: nil, CommitCharacters: nil, Command: (*protocol.Command)(nil), Data: nil, }, { Label: "ioutil", Kind: 9, Tags: nil, Detail: "\"io/ioutil\"", Documentation: "", Deprecated: false, Preselect: false, SortText: "00009", FilterText: "node", InsertText: "", InsertTextFormat: 1, TextEdit: &protocol.TextEdit{ Range: protocol.Range{ Start: protocol.Position{Line:24, Character:8}, End: protocol.Position{Line:24, Character:8}, }, NewText: "ioutil", }, AdditionalTextEdits: nil, CommitCharacters: nil, Command: (*protocol.Command)(nil), Data: nil, }, { Label: "text", Kind: 9, Tags: nil, Detail: "\"github.com/yuin/goldmark/text\"", Documentation: "", Deprecated: false, Preselect: false, SortText: "00010", FilterText: "node", InsertText: "", InsertTextFormat: 1, TextEdit: &protocol.TextEdit{ Range: protocol.Range{ Start: protocol.Position{Line:24, Character:8}, End: protocol.Position{Line:24, Character:8}, }, NewText: "text", }, AdditionalTextEdits: nil, CommitCharacters: nil, Command: (*protocol.Command)(nil), Data: nil, }, { Label: "main", Kind: 3, Tags: nil, Detail: "func()", Documentation: "", Deprecated: false, Preselect: false, SortText: "00011", FilterText: "node", InsertText: "", InsertTextFormat: 1, TextEdit: &protocol.TextEdit{ Range: protocol.Range{ Start: protocol.Position{Line:24, Character:8}, End: protocol.Position{Line:24, Character:8}, }, NewText: "main", }, AdditionalTextEdits: nil, CommitCharacters: nil, Command: (*protocol.Command)(nil), Data: nil, }, { Label: "append", Kind: 3, Tags: nil, Detail: "func(slice []Type, elems ...Type) []Type", Documentation: "", Deprecated: false, Preselect: false, SortText: "00012", FilterText: "node", InsertText: "", InsertTextFormat: 1, TextEdit: &protocol.TextEdit{ Range: protocol.Range{ Start: protocol.Position{Line:24, Character:8}, End: protocol.Position{Line:24, Character:8}, }, NewText: "append", }, AdditionalTextEdits: nil, CommitCharacters: nil, Command: (*protocol.Command)(nil), Data: nil, }, { Label: "bool", Kind: 7, Tags: nil, Detail: "", Documentation: "", Deprecated: false, Preselect: false, SortText: "00013", FilterText: "node", InsertText: "", InsertTextFormat: 1, TextEdit: &protocol.TextEdit{ Range: protocol.Range{ Start: protocol.Position{Line:24, Character:8}, End: protocol.Position{Line:24, Character:8}, }, NewText: "bool", }, AdditionalTextEdits: nil, CommitCharacters: nil, Command: (*protocol.Command)(nil), Data: nil, }, { Label: "byte", Kind: 7, Tags: nil, Detail: "", Documentation: "", Deprecated: false, Preselect: false, SortText: "00014", FilterText: "node", InsertText: "", InsertTextFormat: 1, TextEdit: &protocol.TextEdit{ Range: protocol.Range{ Start: protocol.Position{Line:24, Character:8}, End: protocol.Position{Line:24, Character:8}, }, NewText: "byte", }, AdditionalTextEdits: nil, CommitCharacters: nil, Command: (*protocol.Command)(nil), Data: nil, }, { Label: "cap", Kind: 3, Tags: nil, Detail: "func(v Type) int", Documentation: "", Deprecated: false, Preselect: false, SortText: "00015", FilterText: "node", InsertText: "", InsertTextFormat: 1, TextEdit: &protocol.TextEdit{ Range: protocol.Range{ Start: protocol.Position{Line:24, Character:8}, End: protocol.Position{Line:24, Character:8}, }, NewText: "cap", }, AdditionalTextEdits: nil, CommitCharacters: nil, Command: (*protocol.Command)(nil), Data: nil, }, { Label: "close", Kind: 3, Tags: nil, Detail: "func(c chan<- Type)", Documentation: "", Deprecated: false, Preselect: false, SortText: "00016", FilterText: "node", InsertText: "", InsertTextFormat: 1, TextEdit: &protocol.TextEdit{ Range: protocol.Range{ Start: protocol.Position{Line:24, Character:8}, End: protocol.Position{Line:24, Character:8}, }, NewText: "close", }, AdditionalTextEdits: nil, CommitCharacters: nil, Command: (*protocol.Command)(nil), Data: nil, }, { Label: "complex", Kind: 3, Tags: nil, Detail: "func(r float64, i float64) complex128", Documentation: "", Deprecated: false, Preselect: false, SortText: "00017", FilterText: "node", InsertText: "", InsertTextFormat: 1, TextEdit: &protocol.TextEdit{ Range: protocol.Range{ Start: protocol.Position{Line:24, Character:8}, End: protocol.Position{Line:24, Character:8}, }, NewText: "complex", }, AdditionalTextEdits: nil, CommitCharacters: nil, Command: (*protocol.Command)(nil), Data: nil, }, { Label: "complex128", Kind: 7, Tags: nil, Detail: "", Documentation: "", Deprecated: false, Preselect: false, SortText: "00018", FilterText: "node", InsertText: "", InsertTextFormat: 1, TextEdit: &protocol.TextEdit{ Range: protocol.Range{ Start: protocol.Position{Line:24, Character:8}, End: protocol.Position{Line:24, Character:8}, }, NewText: "complex128", }, AdditionalTextEdits: nil, CommitCharacters: nil, Command: (*protocol.Command)(nil), Data: nil, }, { Label: "complex64", Kind: 7, Tags: nil, Detail: "", Documentation: "", Deprecated: false, Preselect: false, SortText: "00019", FilterText: "node", InsertText: "", InsertTextFormat: 1, TextEdit: &protocol.TextEdit{ Range: protocol.Range{ Start: protocol.Position{Line:24, Character:8}, End: protocol.Position{Line:24, Character:8}, }, NewText: "complex64", }, AdditionalTextEdits: nil, CommitCharacters: nil, Command: (*protocol.Command)(nil), Data: nil, }, { Label: "copy", Kind: 3, Tags: nil, Detail: "func(dst []Type, src []Type) int", Documentation: "", Deprecated: false, Preselect: false, SortText: "00020", FilterText: "node", InsertText: "", InsertTextFormat: 1, TextEdit: &protocol.TextEdit{ Range: protocol.Range{ Start: protocol.Position{Line:24, Character:8}, End: protocol.Position{Line:24, Character:8}, }, NewText: "copy", }, AdditionalTextEdits: nil, CommitCharacters: nil, Command: (*protocol.Command)(nil), Data: nil, }, { Label: "delete", Kind: 3, Tags: nil, Detail: "func(m map[Type]Type1, key Type)", Documentation: "", Deprecated: false, Preselect: false, SortText: "00021", FilterText: "node", InsertText: "", InsertTextFormat: 1, TextEdit: &protocol.TextEdit{ Range: protocol.Range{ Start: protocol.Position{Line:24, Character:8}, End: protocol.Position{Line:24, Character:8}, }, NewText: "delete", }, AdditionalTextEdits: nil, CommitCharacters: nil, Command: (*protocol.Command)(nil), Data: nil, }, { Label: "error", Kind: 8, Tags: nil, Detail: "", Documentation: "", Deprecated: false, Preselect: false, SortText: "00022", FilterText: "node", InsertText: "", InsertTextFormat: 1, TextEdit: &protocol.TextEdit{ Range: protocol.Range{ Start: protocol.Position{Line:24, Character:8}, End: protocol.Position{Line:24, Character:8}, }, NewText: "error", }, AdditionalTextEdits: nil, CommitCharacters: nil, Command: (*protocol.Command)(nil), Data: nil, }, { Label: "false", Kind: 21, Tags: nil, Detail: "", Documentation: "", Deprecated: false, Preselect: false, SortText: "00023", FilterText: "node", InsertText: "", InsertTextFormat: 1, TextEdit: &protocol.TextEdit{ Range: protocol.Range{ Start: protocol.Position{Line:24, Character:8}, End: protocol.Position{Line:24, Character:8}, }, NewText: "false", }, AdditionalTextEdits: nil, CommitCharacters: nil, Command: (*protocol.Command)(nil), Data: nil, }, { Label: "float32", Kind: 7, Tags: nil, Detail: "", Documentation: "", Deprecated: false, Preselect: false, SortText: "00024", FilterText: "node", InsertText: "", InsertTextFormat: 1, TextEdit: &protocol.TextEdit{ Range: protocol.Range{ Start: protocol.Position{Line:24, Character:8}, End: protocol.Position{Line:24, Character:8}, }, NewText: "float32", }, AdditionalTextEdits: nil, CommitCharacters: nil, Command: (*protocol.Command)(nil), Data: nil, }, { Label: "float64", Kind: 7, Tags: nil, Detail: "", Documentation: "", Deprecated: false, Preselect: false, SortText: "00025", FilterText: "node", InsertText: "", InsertTextFormat: 1, TextEdit: &protocol.TextEdit{ Range: protocol.Range{ Start: protocol.Position{Line:24, Character:8}, End: protocol.Position{Line:24, Character:8}, }, NewText: "float64", }, AdditionalTextEdits: nil, CommitCharacters: nil, Command: (*protocol.Command)(nil), Data: nil, }, { Label: "imag", Kind: 3, Tags: nil, Detail: "func(c complex128) float64", Documentation: "", Deprecated: false, Preselect: false, SortText: "00026", FilterText: "node", InsertText: "", InsertTextFormat: 1, TextEdit: &protocol.TextEdit{ Range: protocol.Range{ Start: protocol.Position{Line:24, Character:8}, End: protocol.Position{Line:24, Character:8}, }, NewText: "imag", }, AdditionalTextEdits: nil, CommitCharacters: nil, Command: (*protocol.Command)(nil), Data: nil, }, { Label: "int", Kind: 7, Tags: nil, Detail: "", Documentation: "", Deprecated: false, Preselect: false, SortText: "00027", FilterText: "node", InsertText: "", InsertTextFormat: 1, TextEdit: &protocol.TextEdit{ Range: protocol.Range{ Start: protocol.Position{Line:24, Character:8}, End: protocol.Position{Line:24, Character:8}, }, NewText: "int", }, AdditionalTextEdits: nil, CommitCharacters: nil, Command: (*protocol.Command)(nil), Data: nil, }, { Label: "int16", Kind: 7, Tags: nil, Detail: "", Documentation: "", Deprecated: false, Preselect: false, SortText: "00028", FilterText: "node", InsertText: "", InsertTextFormat: 1, TextEdit: &protocol.TextEdit{ Range: protocol.Range{ Start: protocol.Position{Line:24, Character:8}, End: protocol.Position{Line:24, Character:8}, }, NewText: "int16", }, AdditionalTextEdits: nil, CommitCharacters: nil, Command: (*protocol.Command)(nil), Data: nil, }, { Label: "int32", Kind: 7, Tags: nil, Detail: "", Documentation: "", Deprecated: false, Preselect: false, SortText: "00029", FilterText: "node", InsertText: "", InsertTextFormat: 1, TextEdit: &protocol.TextEdit{ Range: protocol.Range{ Start: protocol.Position{Line:24, Character:8}, End: protocol.Position{Line:24, Character:8}, }, NewText: "int32", }, AdditionalTextEdits: nil, CommitCharacters: nil, Command: (*protocol.Command)(nil), Data: nil, }, { Label: "int64", Kind: 7, Tags: nil, Detail: "", Documentation: "", Deprecated: false, Preselect: false, SortText: "00030", FilterText: "node", InsertText: "", InsertTextFormat: 1, TextEdit: &protocol.TextEdit{ Range: protocol.Range{ Start: protocol.Position{Line:24, Character:8}, End: protocol.Position{Line:24, Character:8}, }, NewText: "int64", }, AdditionalTextEdits: nil, CommitCharacters: nil, Command: (*protocol.Command)(nil), Data: nil, }, { Label: "int8", Kind: 7, Tags: nil, Detail: "", Documentation: "", Deprecated: false, Preselect: false, SortText: "00031", FilterText: "node", InsertText: "", InsertTextFormat: 1, TextEdit: &protocol.TextEdit{ Range: protocol.Range{ Start: protocol.Position{Line:24, Character:8}, End: protocol.Position{Line:24, Character:8}, }, NewText: "int8", }, AdditionalTextEdits: nil, CommitCharacters: nil, Command: (*protocol.Command)(nil), Data: nil, }, { Label: "len", Kind: 3, Tags: nil, Detail: "func(v Type) int", Documentation: "", Deprecated: false, Preselect: false, SortText: "00032", FilterText: "node", InsertText: "", InsertTextFormat: 1, TextEdit: &protocol.TextEdit{ Range: protocol.Range{ Start: protocol.Position{Line:24, Character:8}, End: protocol.Position{Line:24, Character:8}, }, NewText: "len", }, AdditionalTextEdits: nil, CommitCharacters: nil, Command: (*protocol.Command)(nil), Data: nil, }, { Label: "make", Kind: 3, Tags: nil, Detail: "func(t Type, size ...int) Type", Documentation: "", Deprecated: false, Preselect: false, SortText: "00033", FilterText: "node", InsertText: "", InsertTextFormat: 1, TextEdit: &protocol.TextEdit{ Range: protocol.Range{ Start: protocol.Position{Line:24, Character:8}, End: protocol.Position{Line:24, Character:8}, }, NewText: "make", }, AdditionalTextEdits: nil, CommitCharacters: nil, Command: (*protocol.Command)(nil), Data: nil, }, { Label: "new", Kind: 3, Tags: nil, Detail: "func(Type) *Type", Documentation: "", Deprecated: false, Preselect: false, SortText: "00034", FilterText: "node", InsertText: "", InsertTextFormat: 1, TextEdit: &protocol.TextEdit{ Range: protocol.Range{ Start: protocol.Position{Line:24, Character:8}, End: protocol.Position{Line:24, Character:8}, }, NewText: "new", }, AdditionalTextEdits: nil, CommitCharacters: nil, Command: (*protocol.Command)(nil), Data: nil, }, { Label: "panic", Kind: 3, Tags: nil, Detail: "func(v interface{})", Documentation: "", Deprecated: false, Preselect: false, SortText: "00035", FilterText: "node", InsertText: "", InsertTextFormat: 1, TextEdit: &protocol.TextEdit{ Range: protocol.Range{ Start: protocol.Position{Line:24, Character:8}, End: protocol.Position{Line:24, Character:8}, }, NewText: "panic", }, AdditionalTextEdits: nil, CommitCharacters: nil, Command: (*protocol.Command)(nil), Data: nil, }, { Label: "print", Kind: 3, Tags: nil, Detail: "func(args ...Type)", Documentation: "", Deprecated: false, Preselect: false, SortText: "00036", FilterText: "node", InsertText: "", InsertTextFormat: 1, TextEdit: &protocol.TextEdit{ Range: protocol.Range{ Start: protocol.Position{Line:24, Character:8}, End: protocol.Position{Line:24, Character:8}, }, NewText: "print", }, AdditionalTextEdits: nil, CommitCharacters: nil, Command: (*protocol.Command)(nil), Data: nil, }, { Label: "println", Kind: 3, Tags: nil, Detail: "func(args ...Type)", Documentation: "", Deprecated: false, Preselect: false, SortText: "00037", FilterText: "node", InsertText: "", InsertTextFormat: 1, TextEdit: &protocol.TextEdit{ Range: protocol.Range{ Start: protocol.Position{Line:24, Character:8}, End: protocol.Position{Line:24, Character:8}, }, NewText: "println", }, AdditionalTextEdits: nil, CommitCharacters: nil, Command: (*protocol.Command)(nil), Data: nil, }, { Label: "real", Kind: 3, Tags: nil, Detail: "func(c complex128) float64", Documentation: "", Deprecated: false, Preselect: false, SortText: "00038", FilterText: "node", InsertText: "", InsertTextFormat: 1, TextEdit: &protocol.TextEdit{ Range: protocol.Range{ Start: protocol.Position{Line:24, Character:8}, End: protocol.Position{Line:24, Character:8}, }, NewText: "real", }, AdditionalTextEdits: nil, CommitCharacters: nil, Command: (*protocol.Command)(nil), Data: nil, }, { Label: "recover", Kind: 3, Tags: nil, Detail: "func() interface{}", Documentation: "", Deprecated: false, Preselect: false, SortText: "00039", FilterText: "node", InsertText: "", InsertTextFormat: 1, TextEdit: &protocol.TextEdit{ Range: protocol.Range{ Start: protocol.Position{Line:24, Character:8}, End: protocol.Position{Line:24, Character:8}, }, NewText: "recover", }, AdditionalTextEdits: nil, CommitCharacters: nil, Command: (*protocol.Command)(nil), Data: nil, }, { Label: "rune", Kind: 7, Tags: nil, Detail: "", Documentation: "", Deprecated: false, Preselect: false, SortText: "00040", FilterText: "node", InsertText: "", InsertTextFormat: 1, TextEdit: &protocol.TextEdit{ Range: protocol.Range{ Start: protocol.Position{Line:24, Character:8}, End: protocol.Position{Line:24, Character:8}, }, NewText: "rune", }, AdditionalTextEdits: nil, CommitCharacters: nil, Command: (*protocol.Command)(nil), Data: nil, }, { Label: "string", Kind: 7, Tags: nil, Detail: "", Documentation: "", Deprecated: false, Preselect: false, SortText: "00041", FilterText: "node", InsertText: "", InsertTextFormat: 1, TextEdit: &protocol.TextEdit{ Range: protocol.Range{ Start: protocol.Position{Line:24, Character:8}, End: protocol.Position{Line:24, Character:8}, }, NewText: "string", }, AdditionalTextEdits: nil, CommitCharacters: nil, Command: (*protocol.Command)(nil), Data: nil, }, { Label: "true", Kind: 21, Tags: nil, Detail: "", Documentation: "", Deprecated: false, Preselect: false, SortText: "00042", FilterText: "node", InsertText: "", InsertTextFormat: 1, TextEdit: &protocol.TextEdit{ Range: protocol.Range{ Start: protocol.Position{Line:24, Character:8}, End: protocol.Position{Line:24, Character:8}, }, NewText: "true", }, AdditionalTextEdits: nil, CommitCharacters: nil, Command: (*protocol.Command)(nil), Data: nil, }, { Label: "uint", Kind: 7, Tags: nil, Detail: "", Documentation: "", Deprecated: false, Preselect: false, SortText: "00043", FilterText: "node", InsertText: "", InsertTextFormat: 1, TextEdit: &protocol.TextEdit{ Range: protocol.Range{ Start: protocol.Position{Line:24, Character:8}, End: protocol.Position{Line:24, Character:8}, }, NewText: "uint", }, AdditionalTextEdits: nil, CommitCharacters: nil, Command: (*protocol.Command)(nil), Data: nil, }, { Label: "uint16", Kind: 7, Tags: nil, Detail: "", Documentation: "", Deprecated: false, Preselect: false, SortText: "00044", FilterText: "node", InsertText: "", InsertTextFormat: 1, TextEdit: &protocol.TextEdit{ Range: protocol.Range{ Start: protocol.Position{Line:24, Character:8}, End: protocol.Position{Line:24, Character:8}, }, NewText: "uint16", }, AdditionalTextEdits: nil, CommitCharacters: nil, Command: (*protocol.Command)(nil), Data: nil, }, { Label: "uint32", Kind: 7, Tags: nil, Detail: "", Documentation: "", Deprecated: false, Preselect: false, SortText: "00045", FilterText: "node", InsertText: "", InsertTextFormat: 1, TextEdit: &protocol.TextEdit{ Range: protocol.Range{ Start: protocol.Position{Line:24, Character:8}, End: protocol.Position{Line:24, Character:8}, }, NewText: "uint32", }, AdditionalTextEdits: nil, CommitCharacters: nil, Command: (*protocol.Command)(nil), Data: nil, }, { Label: "uint64", Kind: 7, Tags: nil, Detail: "", Documentation: "", Deprecated: false, Preselect: false, SortText: "00046", FilterText: "node", InsertText: "", InsertTextFormat: 1, TextEdit: &protocol.TextEdit{ Range: protocol.Range{ Start: protocol.Position{Line:24, Character:8}, End: protocol.Position{Line:24, Character:8}, }, NewText: "uint64", }, AdditionalTextEdits: nil, CommitCharacters: nil, Command: (*protocol.Command)(nil), Data: nil, }, { Label: "uint8", Kind: 7, Tags: nil, Detail: "", Documentation: "", Deprecated: false, Preselect: false, SortText: "00047", FilterText: "node", InsertText: "", InsertTextFormat: 1, TextEdit: &protocol.TextEdit{ Range: protocol.Range{ Start: protocol.Position{Line:24, Character:8}, End: protocol.Position{Line:24, Character:8}, }, NewText: "uint8", }, AdditionalTextEdits: nil, CommitCharacters: nil, Command: (*protocol.Command)(nil), Data: nil, }, { Label: "uintptr", Kind: 7, Tags: nil, Detail: "", Documentation: "", Deprecated: false, Preselect: false, SortText: "00048", FilterText: "node", InsertText: "", InsertTextFormat: 1, TextEdit: &protocol.TextEdit{ Range: protocol.Range{ Start: protocol.Position{Line:24, Character:8}, End: protocol.Position{Line:24, Character:8}, }, NewText: "uintptr", }, AdditionalTextEdits: nil, CommitCharacters: nil, Command: (*protocol.Command)(nil), Data: nil, }, { Label: "nil", Kind: 6, Tags: nil, Detail: "", Documentation: "", Deprecated: false, Preselect: false, SortText: "00049", FilterText: "node", InsertText: "", InsertTextFormat: 1, TextEdit: &protocol.TextEdit{ Range: protocol.Range{ Start: protocol.Position{Line:24, Character:8}, End: protocol.Position{Line:24, Character:8}, }, NewText: "nil", }, AdditionalTextEdits: nil, CommitCharacters: nil, Command: (*protocol.Command)(nil), Data: nil, }, { Label: "atomic", Kind: 9, Tags: nil, Detail: "\"sync/atomic\"", Documentation: "", Deprecated: false, Preselect: false, SortText: "00050", FilterText: "node", InsertText: "", InsertTextFormat: 1, TextEdit: &protocol.TextEdit{ Range: protocol.Range{ Start: protocol.Position{Line:24, Character:8}, End: protocol.Position{Line:24, Character:8}, }, NewText: "atomic", }, AdditionalTextEdits: { { Range: protocol.Range{ Start: protocol.Position{Line:4, Character:0}, End: protocol.Position{Line:4, Character:0}, }, NewText: "\t\"sync/atomic\"\n", }, }, CommitCharacters: nil, Command: (*protocol.Command)(nil), Data: nil, }, { Label: "reflect", Kind: 9, Tags: nil, Detail: "\"reflect\"", Documentation: "", Deprecated: false, Preselect: false, SortText: "00051", FilterText: "node", InsertText: "", InsertTextFormat: 1, TextEdit: &protocol.TextEdit{ Range: protocol.Range{ Start: protocol.Position{Line:24, Character:8}, End: protocol.Position{Line:24, Character:8}, }, NewText: "reflect", }, AdditionalTextEdits: { { Range: protocol.Range{ Start: protocol.Position{Line:4, Character:0}, End: protocol.Position{Line:4, Character:0}, }, NewText: "\t\"reflect\"\n", }, }, CommitCharacters: nil, Command: (*protocol.Command)(nil), Data: nil, }, { Label: "runtime", Kind: 9, Tags: nil, Detail: "\"runtime\"", Documentation: "", Deprecated: false, Preselect: false, SortText: "00052", FilterText: "node", InsertText: "", InsertTextFormat: 1, TextEdit: &protocol.TextEdit{ Range: protocol.Range{ Start: protocol.Position{Line:24, Character:8}, End: protocol.Position{Line:24, Character:8}, }, NewText: "runtime", }, AdditionalTextEdits: { { Range: protocol.Range{ Start: protocol.Position{Line:4, Character:0}, End: protocol.Position{Line:4, Character:0}, }, NewText: "\t\"runtime\"\n", }, }, CommitCharacters: nil, Command: (*protocol.Command)(nil), Data: nil, }, { Label: "utf8", Kind: 9, Tags: nil, Detail: "\"unicode/utf8\"", Documentation: "", Deprecated: false, Preselect: false, SortText: "00053", FilterText: "node", InsertText: "", InsertTextFormat: 1, TextEdit: &protocol.TextEdit{ Range: protocol.Range{ Start: protocol.Position{Line:24, Character:8}, End: protocol.Position{Line:24, Character:8}, }, NewText: "utf8", }, AdditionalTextEdits: { { Range: protocol.Range{ Start: protocol.Position{Line:4, Character:0}, End: protocol.Position{Line:4, Character:0}, }, NewText: "\t\"unicode/utf8\"\n", }, }, CommitCharacters: nil, Command: (*protocol.Command)(nil), Data: nil, }, { Label: "testlog", Kind: 9, Tags: nil, Detail: "\"internal/testlog\"", Documentation: "", Deprecated: false, Preselect: false, SortText: "00054", FilterText: "node", InsertText: "", InsertTextFormat: 1, TextEdit: &protocol.TextEdit{ Range: protocol.Range{ Start: protocol.Position{Line:24, Character:8}, End: protocol.Position{Line:24, Character:8}, }, NewText: "testlog", }, AdditionalTextEdits: { { Range: protocol.Range{ Start: protocol.Position{Line:3, Character:3}, End: protocol.Position{Line:3, Character:3}, }, NewText: "nternal/testlog\"\n\t\"i", }, }, CommitCharacters: nil, Command: (*protocol.Command)(nil), Data: nil, }, }, } </pre></details> ### What did you expect to see? The field/method candidates for the `*ast.HTMLBlock` value. ### What did you see instead? As above --- cc @stamblerre @muirdm FYI @leitzler
help wanted,gopls,Tools
low
Critical
603,959,185
flutter
WebView freeze on iOS 13.4 with HereMaps
There is an issue with webview_flutter and HereMaps on iOS 13.4. First I thought it's related to [this bug](https://github.com/flutter/flutter/issues/53490), but @cyanglaz told me to create an own issue for this bug. When using [this site](https://www.camping.info/en/search-on-map) with a HereMaps integration within a WebView, the WebView is freezed when doing the following: 1. Zoom into the map till you see campsite marker 2. Select a campsite on the map (Non-clustered map marker) 3. Info box appears 4. Clicking on the info box opens the detail page 5. WebView is freezed It's working with older iOS versions, but with 13.4 the bug appears. The back button in the navigation bar still recognize touch inputs. With the [Community Plugin for WebViews](https://pub.dev/packages/flutter_webview_plugin) the map is working on iOS 13.4. Code example: ``` import 'package:flutter/material.dart'; import 'package:webview_flutter/webview_flutter.dart'; void main() => runApp(TestApp()); class TestApp extends StatelessWidget { @override Widget build(BuildContext context) { return MaterialApp( title: "Title", home: Scaffold( appBar: AppBar( title: Text("Title"), leading: IconButton( icon: Icon(Icons.arrow_back_ios), onPressed: () => {}, ), ), body: WebView( initialUrl: 'https://www.camping.info/en/search-on-map', javascriptMode: JavascriptMode.unrestricted, ), ), ); } } ```
platform-ios,p: webview,package,e: OS-version specific,P3,team-ios,triaged-ios
low
Critical
603,999,186
rust
Vec::reserve should use alloc_excess
When calling `reserve()` on a `Vec` whose capacity is zero, afterwards the `capacity()` method always returns the exact argument that was passed to `reserve()`. Even though the contract of `reserve()` allows `Vec` to make the capacity larger than requested, if the previous capacity is zero, `Vec` does not make use of this. When the underlying allocator is bucketed, rounding to the bucket size never wastes memory, so `Vec` should use [`alloc_excess`](https://doc.rust-lang.org/std/alloc/trait.Alloc.html#method.alloc_excess) to make the slop available to the user. Use case: We're going to write at least `best_case` items and at most `worst_case` items, such that `best_case < worst_case`, but we don't know how many items exactly. The common case can be expected to be _close_ to `best_case` but often at least one more. It would make sense to first allocate for `best_case` rounded up to allocator bucket size, then start writing, then if not everything fits, resize to `worst_case`, write the rest, and finally resize to the size actually written and `shrink_to_fit()`. This would guarantee at most three allocations and in the common case one. This issues comes up often with low-level string code.
C-enhancement,A-allocators,A-collections,T-libs-api
low
Major
604,027,945
pytorch
Add a CI configuration to test USE_DISTRIBUTED=0
As reported by #36870, master has been broken for `USE_DISTRIBUTED=0` compile flag for a period of time. Based on the feedbacks from offline discussion, `USE_DISTRIBUTED=0` is very useful for applications that do not need distributed training. Hence, it will be helpful to add a CI configuration to cover this flag. cc @ezyang @seemethere @pietern @mrshenli @pritamdamania87 @zhaojuanmao @satgera @rohan-varma @gqchen @aazzolini @xush6528 @osalpekar
oncall: distributed,module: ci,module: tests,triaged
low
Critical
604,052,094
PowerToys
[FZ Editor] Ability to divide/split zones in half with Canvas based layouts
# Summary of the new feature/enhancement When I am editing a custom layout, I can create a new zone but I can't align the window so that it is exactly halfway in between the edges of my monitor. It would be great if I could resize a new zone to fill the entire screen and then click a button that would divide the selected zone into half (either vertically or horizontally) to create two new zones. The newly created zones will be added to a list of all zones that will appear in the editing dialogue box. Here the user can also delete any zone they select from the list. Also please add the ability to reorder the numbers of each zone by clicking and dragging the Zone number to move it up or down on the list. That way the user can set the order of the cycle and switch through the zones in any particular order they prefer when they type [Windows + L/R Arrow Key]. All these features can be added to the currently existing dialogue box that appears when editing a zone layout. Please see the annotated screenshot below to see a mockup UI of these features. ![Feature UI implementation Mockup](https://user-images.githubusercontent.com/23486090/79878193-2882b880-83bb-11ea-80ca-8f359c92699a.png) [Edit] Wanted to mention a few more things... 1. The "delete button" icon can be added to the row of icons seen in the screenshot. 2. These three buttons (split horz., split vert., delete) only become active with a zone is selected from the list or by clicking the zone window. (e.i. the buttons are greyed-out when no zone is selected) 3. When a zone is selected (either clicking the item in the list or selecting the zone window itself), the editor would highlight that zone window and the corresponding zone list number in blue. It would also bring the selected zone to the foreground. This list feature can solve the problem when zones are overlapping. For example, if I wanted to adjust a zone in the background, I would first have to resize/move the zone in the foreground, so that I am able to select the borders of the zone in the background.
Idea-Enhancement,FancyZones-Editor,Product-FancyZones
low
Major
604,058,501
tensorflow
tf.name_scope with spaces does not raise ValueError in eager execution
**System information** - Have I written custom code (as opposed to using a stock example script provided in TensorFlow): Yes - OS Platform and Distribution (e.g., Linux Ubuntu 16.04): macOS 10.15.5 Beta - Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device: n/a - TensorFlow installed from (source or binary): binary - TensorFlow version (use command below): 2.1.0 - Python version: 3.6.8 - Bazel version (if compiling from source): n/a - GCC/Compiler version (if compiling from source): n/a - CUDA/cuDNN version: n/a - GPU model and memory: n/a **Describe the current behavior** In autograph, `tf.name_scope` does not allow spaces in the string argument. In eager execution, `tf.name_scope` *does* allow spaces in the string argument. **Describe the expected behavior** The constraints on `tf.name_scope` should be the same across eager execution and autograph. **Standalone code to reproduce the issue** ```python import tensorflow as tf # eager execution since there's no @tf.function decorator def graphcry(): myscalar = tf.constant(83.2) # just a random number with tf.name_scope('scalaragain scope'): # doesn't work tf.summary.scalar('scalaragain', data=myscalar) with tf.name_scope('nospace_scope'): # works tf.summary.scalar('nospace', data=myscalar) graphcry() ``` **Other info / logs** CC @jvishnuvardhan, also see #38661
stat:awaiting tensorflower,type:bug,comp:eager,comp:ops,TF 2.9
low
Critical
604,065,440
flutter
System-wide custom keyboards
<!-- Thank you for using Flutter! If you are looking for support, please check out our documentation or consider asking a question on Stack Overflow: * https://flutter.dev/ * https://api.flutter.dev/ * https://stackoverflow.com/questions/tagged/flutter?sort=frequent If you have found a bug or if our documentation doesn't have an answer to what you're looking for, then fill our the template below. Please read our guide to filing a bug first: https://flutter.dev/docs/resources/bug-reports --> ## Use case <!-- Please tell us the problem you are running into that led to you wanting a new feature. Is your feature request related to a problem? Please give a clear and concise description of what the problem is. Describe alternative solutions you've considered. Is there a package on pub.dev/flutter that already solves this? --> I would like to be able to register system-wide custom keyboards (which can be used outside of the application). The [keyboard_actions](https://pub.dev/packages/keyboard_actions) package already allows customizing the keyboard, but does not work system-wide. ## Proposal Add methods to register system-wide keyboards using Flutter.
a: text input,c: new feature,framework,c: proposal,P3,team-framework,triaged-framework
low
Critical
604,069,399
rust
Collect to slice
This is an enhancement suggestion. Beside the current collect() to collection like Vec, Hash, etc, and the future collect to array: https://github.com/rust-lang/rust/pull/69985 I find it useful to also collect to a slice when I don't know at compile-time the exact length of the resulting array, but I know an upper bound of its length. I have adapted the following code from this crate: https://github.com/kchmck/collect_slice https://crates.io/crates/collect_slice ``` trait CollectSlice<'a>: Iterator { fn inner(&mut self, slice: &'a mut [Self::Item]) -> &'a [Self::Item]; fn inner_mut(&mut self, slice: &'a mut [Self::Item]) -> &'a mut [Self::Item]; fn collect_slice(&mut self, slice: &'a mut [Self::Item]) -> &'a [Self::Item] { let result = self.inner(slice); assert!(self.next().is_none()); result } fn collect_slice_mut(&mut self, slice: &'a mut [Self::Item]) -> &'a mut [Self::Item] { let result = self.inner_mut(slice); assert!(self.next().is_none()); result } } impl<I: ?Sized> CollectSlice<'a> for I where I: Iterator { fn inner(&mut self, slice: &'a mut [Self::Item]) -> &'a [Self::Item] { let count = slice.iter_mut().zip(self).fold(0, |count, (dest, item)| { *dest = item; count + 1 }); &slice[.. count] } fn inner_mut(&mut self, slice: &'a mut [Self::Item]) -> &'a mut [Self::Item] { let count = slice.iter_mut().zip(self).fold(0, |count, (dest, item)| { *dest = item; count + 1 }); &mut slice[.. count] } } ``` This code should be improved and simplified. And as in Issue #69985 we could return a Result<> instead, and remove the asserts.
A-collections,T-libs-api,C-feature-request,A-iterators
low
Minor
604,075,377
godot
Unable to run Godot game on 32-bit Debian
Similar to : https://github.com/godotengine/godot/issues/16409 **Godot version:** Editor: Godot_v3.2.1-stable_win64; downloaded from Godot site 20 Apr 2020. Export templates installed through editor 20 Apr 2020. I have not yet attempted the Mono version of Godot due to known 32/64 bit crossover issues. **OS/device including version:** Win10 x64 as editor, Debian 9 i386 and Debian 10 i386 **Issue description:** Sample game (audio output selector) will not run on Debian desktop 32-bit as expected. Clean install of Debian (9 or 10) 32 bit with either Gnome or LXCE X11 desktops errors out on attempted run. Does run in Win64 editor and Win64 exported desktop. For Debian 9, executable complains that GCC > 7.0 is needed. Default package for GCC in Deb9 is 6; hacking through experimental and testing repos no longer works due to release-stable of Deb10. For Debian 10, executable complains that the version of OpenGL is not compatible or too old. **Steps to reproduce:** Export project from Windows Editor as Linux Desktop, x64 not enabled. Copy 2 files from export to Debian machine, cleanly installed. run the .x86 file either as-is or in terminal to observe verbose errors. [changerdemo.zip](https://github.com/godotengine/godot/files/4510816/changerdemo.zip) Please advise if there are workarounds for this; I am not expressly tied to Debian as the linux distro, but am comfortable with it. I am hoping to change over some of my Unity3d projects that are really just 2d gui's to utilize legacy hardware in place a little longer. Thanks, Ted.
bug,platform:linuxbsd,topic:buildsystem
low
Critical
604,086,155
vscode
VoiceOver: Braille display does not track when entering text into an editor
<!-- โš ๏ธโš ๏ธ Do Not Delete This! bug_report_template โš ๏ธโš ๏ธ --> <!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ --> <!-- Please search existing issues to avoid creating duplicates. --> <!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: https://code.visualstudio.com/insiders/ --> <!-- Use Help > Report Issue to prefill these. --> - VSCode Version: 1.45 insiders. - OS Version: MacOS 10.15.4 Steps to Reproduce: 1. Connect a braille display to a Mac and turn on VoiceOver. 2. Open VS Code and a blank file. 3. Type some text into it. * Expected: VoiceOver updates the braille display as you type. * Actual: VoiceOver only updates the display once you press the left or right arrow keys. 4. Delete some text. * Result: Same as with step 3. 5. Press the routing button above some of the typed text. * Expected: Cursor moves to that letter and you can continue editing from that point on. * Actual: Although the braille cursor blinks at that location, the actual caret didn't move, and new edits happen at its previous position. <!-- Launch with `code --disable-extensions` to check. --> Does this issue occur when all extensions are disabled?: Yes This makes it literally impossible to use VS Code with a braille display on Mac. ### More information Investigation shows that this is a Chromium issue. I have reproduced this in Chrome 78 as part of Electron 7.2.x used by VS Code, MS Edge 81, and Chrome Canary 84 with a simple textarea. I have filed [Chromium issue 1073074](https://bugs.chromium.org/p/chromium/issues/detail?id=1073074) for this issue, but leaving this VS Code issue here to track it. CC @isidorn for Accessibility triage. This is going to need an external Chromium fix.
upstream,macos,accessibility,upstream-issue-linked,chromium
low
Critical
604,100,518
pytorch
[RFC] Modularize DistributedDataParallel
## Updated on 12/09/2020 Added more details on implementation plan in [this comment below](https://github.com/pytorch/pytorch/issues/37002#issuecomment-741958753). --------- ## Summary This project aims at decomposing existing `DistributedDataParallel` (DDP) implementation into multiple smaller pluggable and customizable building blocks. So that applications can customize DDP to best serve specific applications. More specifically, each type of individual building block exposes a fixed set of APIs but can implement different algorithms. The new DDP constructor takes building blocks to assemble a DDP instance. Existing DDP API can stay intact and internally calls into the new DDP implementation. This project is motivated by the following requirements: * Enable new features without polluting existing DDP API * Many of the new features would require adding more configurations at initialization. Instead of adding all of them into DDP constructor, these configurations should be self-contained inside the implementation of a building block. * Make DDP/Reducer code more readable * Most of DDP core lives in `reducer.cpp`. It starts from a nicely organized implementation, but as we are gradually adding more features, the growing complexity starts to detrimental to readability. * Allow applications to customize their DDP by picking and extending sub-components * Different applications have vastly different requirements, which we will elaborate in the *Targeted Features* section. Packing everything in one implementation would inevitably leads to unnecessary slowdowns. Instead, applications should be able to just pick the algorithms they need and get rid of those unnecessary complexities. * Add C++ DDP API * Gradually remove legacy features, e.g., `device_ids`, `dim`, `check_reduction`, etc. * `device_ids` is necessary for single-process multi-GPU mode, which is not the recommended mode as GIL contention and the per-iteration scatter and gather could introduce additional overhead. The recommended one process per module replica/device use case does not need `device_ids` or `dim`. * Gradually move DDP from `torch.nn.parallel` to `torch.distributed` * Currently DDP API lives in `torch.nn.parallel` but the core `Reducer` implementation is in the distributed package, which creates a weird dependency that the single-machine package depends on the distributed package. We can resolve this by moving DDP into the `torch.distributed` package. ## Compositional Building Blocks We propose to decompose the main logic of `DistributedDataParallel` into the following four building blocks * **Grad Reader**: responsible for reading grad from the local model, which is done by manipulating DDP hooks, including * Where to read the grad from: e.g., `parameter.grad` or from distributed autograd context. * When to read grad: e.g., `AccumlateGrad` , forward output tensor, etc. * Which grad to expect: e.g., `find_unused_parameters` should skip hooks on unused parameters * **Grad Bucketer**: responsible for organizing grads into buckets, including * How do grads maps to buckets: e.g., static mapping determined at construction time, dynamic mapping based on grad-ready order, etc. * Determine when a bucket is ready for communication * Grad/bucket compression * **Comm Scheduler**: responsible for how to communicate buckets, including * What comm strategy to use: e.g., `AllReduce` or gossip * How to prioritize communication * **Grad Writer**: responsible for writing the communicated grad back to the local model, including * Where to read the grad from: e.g., `parameter.grad` or from distributed autograd context. * Trigger post DDP-grad hooks if there are any: e.g., this is useful to overlap optimizer `step` with DDP communication. ## Targeted New Features * **Mix DDP with RPC** * Use DDP in conjunction with RPC functions. Currently, DDP hook is only registered to the `AccumulateGrad` function and looks for grad from `param.grad`. To support RPC, DDP need to read grad from and write grad to the distributed autograd context. * Compositional building blocks: * Grad Reader * Grad Writer * **Delay Allreduce** * There are certain scenarios where we cannot make assumptions on how many times a `AccumulateGrad` hook will be called or we cannot traverse the real autograd graph from the outputs (e.g., with checkpoints + reused layers). For these cases, we can have a slower version of DDP which does not overlap comm with comp, so that DDP should be able to support all use cases that would work with local autograd. (see https://github.com/pytorch/pytorch/pull/35083) * Compositional building blocks: * Grad Reader * Grad Writer * **Tune parameter to bucket mapping** * This tunes the order of `AllReduce` parameters. Ideally, the `AllReduce` order should be the same as gradient ready order. So that DDP can launch communications as soon as possible. We might have to do some profiling to detect the gradient ready order in the backward pass, and might need to change it over iterations. All processes would need to agree on the mapping, but as the mapping adjustment should occur infrequently, we should be able to afford introducing one more `AllReduce` to achieve consensus. (see https://github.com/pytorch/pytorch/pull/35137) * Compositional building blocks: * Grad Bucketer * **Layer Drop/Skip Comm for Unused Params** * Currently, DDP always `AllReduce` all buckets (i.e., all grads) even if some parameters are not used in the forward pass. Some applications intentionally skip layers to speed up training and prevent overfitting. In some other applications, different inputs might reach different part of the model. Allowing skip unused parameters in the communication as well will help to speed up training. One challenge is that all processes need to have a global consensus on which gradients to skip. (see [paper](https://arxiv.org/pdf/1909.11556.pdf) as one example use case) * Compositional building blocks: * Grad Reader * Grad Bucketer * Grad Writer * **Overlap DDP with optimizer** * Existing DDP enforces a hard barrier between backward and optimizer step. However, this is not necessary, as optimizers should be able to start working as soon as some grad is ready. Therefore, we should allow optimizer step to overlap with DDP backward. * Compositional building blocks: * Grad Writer * **Overlap DDP backward with next forward** * Description: the reason for computing grad is to use the updated parameter in the next iteration. The next forward does not have to be block until all parameter are updated. Instead, it can start as long as the first layer parameters are ready. So we should allow overlapping DDP backward with next iterationโ€™s forward, and only block forward on a layer if its parameter hasnโ€™t been updated yet. * Challenge: API design * Compositional building blocks: * per sub-module pre-forward hooks (to block forward until parameter is updated, this is already available) * **Prioritize and preempt allreduce** * Grads becomes ready in the backward order, but parameters are consumed by the next forward in the opposite order. If we want to overlap backward with next forward well, we need to assign higher priorities to `AllReduce` operations for first layers. However, as buckets for last layers will be ready first, they will start early. Hence, we need some way to implement *preemption* in allreduce operations. (see [paper1](https://dl.acm.org/doi/10.1145/3341301.3359642) and [paper2](https://arxiv.org/abs/1905.03960)) * Compositional building blocks: * Comm Scheduler * **Gossip DDP** * Instead of using `AllReduce` to globally sync gradients, itโ€™s proven that gossip and async param sync also works and can potentially lead to considerable training speedups. * Compositional building blocks: * Comm Scheduler * **Gradient Compression** * Mixed precision training has been proven to help accelerate training considerably. DDP should support this use case as well by allowing use less bits to store and communicate grads. * Compositional building blocks: * Grad Bucketer cc @pietern @mrshenli @pritamdamania87 @zhaojuanmao @satgera @rohan-varma @gqchen @aazzolini @xush6528 @osalpekar
oncall: distributed,feature,triaged
medium
Major
604,104,942
rust
Fix suggestion on DerefMut
<!-- Thank you for filing a bug report! ๐Ÿ› Please provide a short summary of the bug, along with any information you feel relevant to replicating the bug. --> I tried this code: ```rust fn t(n: &mut i32) { n = "42".parse().unwrap(); } ``` I expected to see this happen: Suggestion of `*n = ...`, the correct code would be ```rust fn t(n: &mut i32) { *n = "42".parse().unwrap(); } ``` Instead, this happened: It did not look at mutable deref value and directly show the suggestion ``` error[E0277]: the trait bound `&mut i32: std::str::FromStr` is not satisfied --> src/lib.rs:2:14 | 2 | n = "42".parse().unwrap(); | ^^^^^ the trait `std::str::FromStr` is not implemented for `&mut i32` | = help: the following implementations were found: <i32 as std::str::FromStr> ``` Not sure why but I miss `*` quite often. Link to playground https://play.rust-lang.org/?version=nightly&mode=debug&edition=2018&gist=011e594936166764d011c581d7db107e ### Meta <!-- If you're using the stable version of the compiler, you should also check if the bug also exists in the beta or nightly versions. --> `rustc --version --verbose`: ``` 1.42.0 ```
C-enhancement,A-diagnostics,T-compiler,A-suggestion-diagnostics
low
Critical
604,106,499
kubernetes
Bandwidth efficient watch resumption
Right now, if a watch request uses an RV that's out of the window, we force the client to do a re-list. If we cared about bandwidth between client and apiserver, we could construct a catch-up watch response type that worked like this: * apiserver performs a list. We need to construct two things: the set of all current keys in the list, and the contents of all items which have been modified subsequent to the client's given RV. * We construct a bloom filter from the existing keys. * We send the client the bloom filter and the list of modified items, and finally a bookmark (or other mechanism of letting client delay processing until it has a complete list). * Client reconstructs the current state by deleting any local item not found in the bloom filter, and processing each update message (treating it as an add if the object wasn't previously found locally). Bloom filters can be made [deterministic](https://en.wikipedia.org/wiki/Bloom_filter#Avoiding_false_positives_in_a_finite_universe); we can use the UID, or a hash of the namespace/name, to ensure the universe of possible keys is finite. The choice here implies slightly different reconstruction logic on the client's part (a UID change means the client should process the change as a delete/recreate, if the client cares about such things). The downside of this is only that apiserver still needs to actually do a list. However, it's a) possible to do in-process today if the watch cache is on and b) probably possible to make a query against etcd that would be efficient (it would probably have to be a pair of queries, one for the list of all keys+RV (omit values), and one for the values of sufficiently new keys. If we implemented this, clearly it'd have to be opt-in for the clients, since old clients wouldn't be able to understand this.
sig/api-machinery,kind/feature,lifecycle/frozen
medium
Major
604,107,847
pytorch
RuntimeError: NCCL error in ProcessGroupNCCL.cpp:290, unhandled system error
I came across this error `RuntimeError: NCCL error in ProcessGroupNCCL.cpp:290, unhandled system error` when trying to distribute neural network training to 4 GPUs in a single node with PyTorch 1.2. According to documentation, I tried `export NCCL_DEBUG=INFO` and reran the code. I noticed some weird warnings in the debug output like ``` node08:27106:27302 [0] include/shm.h:27 NCCL WARN Call to shm_open failed : Permission denied node08:27106:27302 [0] NCCL INFO include/shm.h:41 -> 2 node08:27106:27302 [0] include/shm.h:48 NCCL WARN Error while creating shared memory segment nccl-shm-recv-b7948f403864987a-0-3-0 (size 4460544) ``` before the crash. So I give the permission by `sudo chmod 777 /dev/shm` and the problem is gone. Maybe such error can be handled better than just raising a warning in debug output so when users run into an unhandled system error they know where the problem is. cc @pietern @mrshenli @pritamdamania87 @zhaojuanmao @satgera @rohan-varma @gqchen @aazzolini @xush6528 @osalpekar
module: dependency bug,oncall: distributed,triaged,module: nccl
low
Critical
604,128,411
TypeScript
Interoperability with Webpack import statements
Hello! First of all, thank you for your hard and amazing work. The thing is, that Webpack supports more complex import statements than the standard. For example it defines "query" part of the import statements, which looks like this: ```typescript import { something } from './path/to/module?query'; ``` The `./path/to/module` is an actual filesystem path to a referenced module, however, the `?query` is a query part. It allows to configure different loaders for different queries, so the same module could be treated differently in different import statements. For example `import component from './component';` would import the default symbol from the `./component` module normally, however, `import component from './component?raw';` could be used to load the source code of the `./component` file as a string and would put it into `component` variable (this must be configured in Webpack config). This allows to perform very powerful operations on various files and add it to the resulting bundle. We are using it to generate documentation for example. The problem is that TypeScript doesn't understand these "extended" import statements and shows errors during type checking. We have to either put `@ts-ignore` on top of such imports or to use `paths` configuration option to redirect the compiler to a file containing, e.g.: `export default '';`. If TypeScript would support interoperability with extended Webpack import statements it would be very useful in complex projects. By the way, besides "queries", Webpack also allows to [specify loaders inline](https://webpack.js.org/concepts/loaders/#inline). What do you think?
Suggestion,Needs Proposal
low
Critical
604,160,101
pytorch
Make it an error to def() an operator multiple times
Currently in `aten/src/ATen/core/library.cpp` there is a todo: ``` // TODO: Error if an operator is def'ed multiple times. Right now we just // merge everything ``` The relevant backwards compatibility logic is in `aten/src/ATen/core/dispatch/Dispatcher.cpp`: ``` void Dispatcher::checkSchemaCompatibility(const OperatorHandle& op, const FunctionSchema& schema, const std::string& debug) { TORCH_CHECK(op.schema() == schema, "Tried to register multiple operators with the same name and the same overload name but different schemas: ", schema, " (", debug, ") vs ", op.schema(), " (", op.debug(), ")"); if (schema.isDefaultAliasAnalysisKind()) { // [BACKWARDS COMPAT] If the *new* schema is the default alias analysis // kind, for BC, we will accept it. If we don't accept it, most extensions // that override existing operators will stop working (as they generally did // not specify alias information). } else if (op.schema().isDefaultAliasAnalysisKind()) { // [BACKWARDS COMPAT] If you POST-FACTO specify a non-default alias analysis // kind after we already have a schema for a function, bong it in for BC // reasons. op.operatorIterator_->op.updateSchemaAliasAnalysis(schema.aliasAnalysis()); } else { TORCH_CHECK(op.schema().aliasAnalysis() == schema.aliasAnalysis(), "Tried to define the schema for ", toString(op.operator_name()), " with different alias analysis kinds: ", toString(op.schema().aliasAnalysis()), " (", op.debug(), ") vs ", toString(schema.aliasAnalysis()), " (", debug, ")"); } } ``` The desired new form of this code is to make it to make it 100% invalid to def an operator multiple times. This can be done by replacing the if-statement in this function with an unconditional error (and update the error message). Once this is done, there may be some definition sites which now error. You should identify all of these sites and port them to the new API (similar to what was done in #36925), so that there is a single, unique `def()` for it (every old-style `RegisterOperators` call counts as a def, which is why porting will generally help solve the problem). Some of these sites may occur in the mobile-only code, please confer with your bootcamp mentor for more information about how to deal with these if they arise. This task is reserved for bootcamp, please confer with @ezyang before working on it.
module: bootcamp,triaged
low
Critical
604,167,798
excalidraw
Broken rendering of scene on node server
Hi, thanks a lot for this awesome project ! I was testing out the functionality introduced by this PR https://github.com/excalidraw/excalidraw/pull/443 and found that it is broken this master. I verified that after checking out the commit (7f6e1f420e55bb6c6b112accc5dc39deef64605d) it was working as expected. On further debugging I observed that the reason for the errors were a couple of refactoring commits that went after the above change that introduced dependency on `window` and `document` objects, Since the server side render was using the same functions as the normal export, the functionality broke. I wanted to know if there is any ongoing work on this. If not, I was working on fixing this and would like to discuss my approach
discussion
low
Critical
604,192,040
pytorch
Converting to Torch Script: cpp_module does not match nn_module
## ๐Ÿ› Bug When trying to convert a yolov3 model to Torch Script I get the following error: ` File "D:\python\lib\site-packages\torch\nn\modules\module.py", line 576, in __getattr__ type(self).__name__, name)) AttributeError: 'Sequential' object has no attribute 'shortcut_4'` (full stacktrace below) The model itself works fine during training and inferencing. While debugging the conversion of the script, I can clearly see that the network's layers are correct: [https://i.imgur.com/ckx1AaN.png](https://i.imgur.com/ckx1AaN.png) During conversion to Torch Script, the issue is caused by 9th Sequential module , which contains the EmptyLayer with id `shortcut_4` Debugging further, I got to the following function in '**torch.jit._recursive.py**': ``` def create_script_module(nn_module, stubs): check_module_initialized(nn_module) concrete_type = concrete_type_store.get_or_create_concrete_type(nn_module) cpp_module = torch._C._create_module_with_type(concrete_type.jit_type) return create_script_module_impl(nn_module, concrete_type, cpp_module, stubs) ``` I don't understand what exactly is happening but the resulting `cpp_module` variable is created with `shortcut_4` as a property, while it should have `shortcut_8` as shown in the image above, since it is the 9th Module. It seems the `get_or_create_concrete_type` function gets the module created before with property `shortcut_4`. For some reason the cpp_module created from the nn_module has a different key/name, see here: [https://i.imgur.com/eMol4oX.png](https://i.imgur.com/eMol4oX.png) ## To Reproduce Steps to reproduce the behavior: 1. Run the code below: ``` import cv2 import numpy as np import torch import torch.nn as nn def parse_cfg(cfgfile): """ Takes a configuration file Returns a list of blocks. Each blocks describes a block in the neural network to be built. Block is represented as a dictionary in the list """ file = open(cfgfile, 'r') lines = file.read().split('\n') # store the lines in a list lines = [x for x in lines if len(x) > 0] # get read of the empty lines lines = [x for x in lines if x[0] != '#'] lines = [x.rstrip().lstrip() for x in lines] block = {} blocks = [] for line in lines: if line[0] == "[": # This marks the start of a new block if len(block) != 0: blocks.append(block) block = {} block["type"] = line[1:-1].rstrip() else: key, value = line.split("=") block[key.rstrip()] = value.lstrip() blocks.append(block) return blocks def create_modules(blocks): net_info = blocks[0] # Captures the information about the input and pre-processing module_list = nn.ModuleList() index = 0 # indexing blocks helps with implementing route layers (skip connections) prev_filters = 3 output_filters = [] for x in blocks: module = nn.Sequential() if x["type"] == "net": continue # If it's a convolutional layer if x["type"] == "convolutional": # Get the info about the layer activation = x["activation"] if "batch_normalize" in x: batch_normalize = int(x["batch_normalize"]) bias = False else: batch_normalize = 0 bias = True filters = int(x["filters"]) padding = int(x["pad"]) kernel_size = int(x["size"]) stride = int(x["stride"]) if padding: pad = (kernel_size - 1) // 2 else: pad = 0 # Add the convolutional layer conv = nn.Conv2d(prev_filters, filters, kernel_size, stride, pad, bias=bias) module.add_module("conv_{0}".format(index), conv) # Add the Batch Norm Layer if batch_normalize: bn = nn.BatchNorm2d(filters) module.add_module("batch_norm_{0}".format(index), bn) # Check the activation. # It is either Linear or a Leaky ReLU for YOLO if activation == "leaky": activn = nn.LeakyReLU(0.1, inplace=True) module.add_module("leaky_{0}".format(index), activn) # If it's an upsampling layer # We use Bilinear2dUpsampling elif x["type"] == "upsample": stride = int(x["stride"]) upsample = nn.Upsample(scale_factor=2, mode="nearest") module.add_module("upsample_{}".format(index), upsample) # If it is a route layer elif x["type"] == "route": x["layers"] = x["layers"].split(',') # Start of a route start = int(x["layers"][0]) if len(x["layers"]) <= 2: # end, if there exists one. if len(x["layers"]) > 1: end = int(x["layers"][1]) else: end = 0 # Positive anotation if start > 0: start = start - index if end > 0: end = end - index route = EmptyLayer("route_{0}".format(index)) module.add_module("route_{0}".format(index), route) if end < 0: filters = output_filters[index + start] + output_filters[index + end] else: filters = output_filters[index + start] else: # SPP-route route = EmptyLayer("route_{0}".format(index)) module.add_module("route_{0}".format(index), route) filters = output_filters[index + start] + output_filters[index + int(x["layers"][1])] \ + output_filters[index + int(x["layers"][2])] + output_filters[index + int(x["layers"][3])] # shortcut corresponds to skip connection elif x["type"] == "shortcut": shortcut = EmptyLayer("shortcut_{}".format(index)) module.add_module("shortcut_{}".format(index), shortcut) elif x["type"] == "maxpool": stride = int(x["stride"]) size = int(x["size"]) if stride != 1: maxpool = nn.MaxPool2d(size, stride) else: maxpool = MaxPoolStride1(size) module.add_module("maxpool_{}".format(index), maxpool) # Yolo is the detection layer elif x["type"] == "yolo": mask = x["mask"].split(",") mask = [int(x) for x in mask] anchors = x["anchors"].split(",") anchors = [int(a) for a in anchors] anchors = [(anchors[i], anchors[i + 1]) for i in range(0, len(anchors), 2)] anchors = [anchors[i] for i in mask] detection = DetectionLayer(anchors) module.add_module("Detection_{}".format(index), detection) else: pass module_list.append(module) prev_filters = filters output_filters.append(filters) index += 1 return net_info, module_list def convert2cpu(matrix): if matrix.is_cuda: return torch.FloatTensor(matrix.size()).copy_(matrix) else: return matrix def predict_transform(prediction, inp_dim, anchors, num_classes): batch_size = prediction.size(0) stride = inp_dim // prediction.size(2) grid_size = inp_dim // stride bbox_attrs = 5 + num_classes num_anchors = len(anchors) anchors = [(a[0] / stride, a[1] / stride) for a in anchors] prediction = prediction.view(batch_size, bbox_attrs * num_anchors, grid_size * grid_size) prediction = prediction.transpose(1, 2).contiguous() prediction = prediction.view(batch_size, grid_size * grid_size * num_anchors, bbox_attrs) # Sigmoid the centre_X, centre_Y. and object confidencce prediction[:, :, 0] = torch.sigmoid(prediction[:, :, 0]) prediction[:, :, 1] = torch.sigmoid(prediction[:, :, 1]) prediction[:, :, 4] = torch.sigmoid(prediction[:, :, 4]) # Add the center offsets grid_len = np.arange(grid_size) a, b = np.meshgrid(grid_len, grid_len) x_offset = torch.FloatTensor(a).view(-1, 1) y_offset = torch.FloatTensor(b).view(-1, 1) x_y_offset = torch.cat((x_offset, y_offset), 1).repeat(1, num_anchors).view(-1, 2).unsqueeze(0) prediction[:, :, :2] += x_y_offset # log space transform height and the width anchors = torch.FloatTensor(anchors) anchors = anchors.repeat(grid_size * grid_size, 1).unsqueeze(0) prediction[:, :, 2:4] = torch.exp(prediction[:, :, 2:4]) * anchors # Softmax the class scores prediction[:, :, 5: 5 + num_classes] = torch.sigmoid((prediction[:, :, 5: 5 + num_classes])) prediction[:, :, :4] *= stride return prediction class Darknet(nn.Module): def __init__(self, cfgfile, weightfile, input_dim): super(Darknet, self).__init__() self.blocks = parse_cfg(cfgfile) self.net_info, self.module_list = create_modules(self.blocks) self.net_info['height'] = input_dim self.header = torch.IntTensor([0, 0, 0, 0]) self.seen = 0 self.load_weights(weightfile) def forward(self, x): detections = [] modules = self.blocks[1:] outputs = {} # We cache the outputs for the route layer write = 0 for i in range(len(modules)): module_type = (modules[i]["type"]) if module_type == "convolutional" or module_type == "upsample" or module_type == "maxpool": x = self.module_list[i](x) outputs[i] = x elif module_type == "route": layers = modules[i]["layers"] layers = [int(a) for a in layers] if (layers[0]) > 0: layers[0] = layers[0] - i if len(layers) == 1: x = outputs[i + (layers[0])] elif len(layers) == 2: if (layers[1]) > 0: layers[1] = layers[1] - i map1 = outputs[i + layers[0]] map2 = outputs[i + layers[1]] x = torch.cat((map1, map2), 1) elif len(layers) == 4: # SPP map1 = outputs[i + layers[0]] map2 = outputs[i + layers[1]] map3 = outputs[i + layers[2]] map4 = outputs[i + layers[3]] x = torch.cat((map1, map2, map3, map4), 1) outputs[i] = x elif module_type == "shortcut": from_ = int(modules[i]["from"]) x = outputs[i - 1] + outputs[i + from_] outputs[i] = x elif module_type == 'yolo': anchors = self.module_list[i][0].anchors # Get the input dimensions inp_dim = int(self.net_info["height"]) # Get the number of classes num_classes = int(modules[i]["classes"]) # Output the result x = x.data x = predict_transform(x, inp_dim, anchors, num_classes) if type(x) == int: continue if not write: detections = x write = 1 else: detections = torch.cat((detections, x), 1) outputs[i] = outputs[i - 1] return detections def load_weights(self, weightfile): # Open the weights file fp = open(weightfile, "rb") # The first 4 values are header information # 1. Major version number # 2. Minor Version Number # 3. Subversion number # 4. IMages seen header = np.fromfile(fp, dtype=np.int32, count=5) self.header = torch.from_numpy(header) self.seen = self.header[3] # The rest of the values are the weights # Let's load them up weights = np.fromfile(fp, dtype=np.float32) ptr = 0 for i in range(len(self.module_list)): module_type = self.blocks[i + 1]["type"] if module_type == "convolutional": model = self.module_list[i] if "batch_normalize" in self.blocks[i + 1]: batch_normalize = int(self.blocks[i + 1]["batch_normalize"]) else: batch_normalize = 0 conv = model[0] if (batch_normalize): bn = model[1] # Get the number of weights of Batch Norm Layer num_bn_biases = bn.bias.numel() # Load the weights bn_biases = torch.from_numpy(weights[ptr:ptr + num_bn_biases]) ptr += num_bn_biases bn_weights = torch.from_numpy(weights[ptr: ptr + num_bn_biases]) ptr += num_bn_biases bn_running_mean = torch.from_numpy(weights[ptr: ptr + num_bn_biases]) ptr += num_bn_biases bn_running_var = torch.from_numpy(weights[ptr: ptr + num_bn_biases]) ptr += num_bn_biases # Cast the loaded weights into dims of model weights. bn_biases = bn_biases.view_as(bn.bias.data) bn_weights = bn_weights.view_as(bn.weight.data) bn_running_mean = bn_running_mean.view_as(bn.running_mean) bn_running_var = bn_running_var.view_as(bn.running_var) # Copy the data to model bn.bias.data.copy_(bn_biases) bn.weight.data.copy_(bn_weights) bn.running_mean.copy_(bn_running_mean) bn.running_var.copy_(bn_running_var) else: # Number of biases num_biases = conv.bias.numel() # Load the weights conv_biases = torch.from_numpy(weights[ptr: ptr + num_biases]) ptr = ptr + num_biases # reshape the loaded weights according to the dims of the model weights conv_biases = conv_biases.view_as(conv.bias.data) # Finally copy the data conv.bias.data.copy_(conv_biases) # Let us load the weights for the Convolutional layers num_weights = conv.weight.numel() # Do the same as above for weights conv_weights = torch.from_numpy(weights[ptr:ptr + num_weights]) ptr = ptr + num_weights conv_weights = conv_weights.view_as(conv.weight.data) conv.weight.data.copy_(conv_weights) class EmptyLayer(nn.Module): def __init__(self, name): super(EmptyLayer, self).__init__() self.name = name def forward(self, x): return x class DetectionLayer(nn.Module): def __init__(self, anchors): super(DetectionLayer, self).__init__() self.anchors = anchors def forward(self, x, inp_dim, num_classes, confidence): x = x.data prediction = x prediction = predict_transform(prediction, inp_dim, self.anchors, num_classes, confidence) return prediction class MaxPoolStride1(nn.Module): def __init__(self, kernel_size): super(MaxPoolStride1, self).__init__() self.kernel_size = kernel_size self.pad = kernel_size - 1 def forward(self, x): padding = int(self.pad / 2) padded_x = nn.functional.pad(x, (padding, padding, padding, padding), mode="constant", value=0) pooled_x = nn.MaxPool2d(self.kernel_size, 1)(padded_x) return pooled_x def letterbox_image(img, inp_dim): img_w, img_h = img.shape[1], img.shape[0] w, h = inp_dim new_w = int(img_w * min(w / img_w, h / img_h)) new_h = int(img_h * min(w / img_w, h / img_h)) resized_image = cv2.resize(img, (new_w, new_h), interpolation=cv2.INTER_CUBIC) canvas = np.full((inp_dim[1], inp_dim[0], 3), 128) canvas[(h - new_h) // 2:(h - new_h) // 2 + new_h, (w - new_w) // 2:(w - new_w) // 2 + new_w, :] = resized_image return canvas def prep_frame(frame, inp_dim): dim = frame.shape[1], frame.shape[0] dim = torch.FloatTensor(dim).repeat(1, 2) img = (letterbox_image(frame, (inp_dim, inp_dim))) img_ = img[:, :, ::-1].transpose((2, 0, 1)).copy() img_ = torch.from_numpy(img_).float().div(255.0).unsqueeze(0) return img_, dim if __name__ == "__main__": input_dim = 608 img = cv2.imread('test.jpg') image, dimensions = prep_frame(img, input_dim) model = Darknet('/models/yolo/yolov3-spp.cfg', '/models/yolo/yolov3-spp.weights', input_dim) model.eval() script_module = torch.jit.script(model) print(script_module.code) ``` #### Full stacktrace ``` Traceback (most recent call last): File "D:/dev/yolo/script.py", line 228, in <module> script_module = torch.jit.script(model) File "D:\python\lib\site-packages\torch\jit\__init__.py", line 1255, in script return torch.jit._recursive.recursive_script(obj) File "D:\python\lib\site-packages\torch\jit\_recursive.py", line 534, in recursive_script return create_script_module(nn_module, infer_methods_to_compile(nn_module)) File "D:\python\lib\site-packages\torch\jit\_recursive.py", line 296, in create_script_module return create_script_module_impl(nn_module, concrete_type, cpp_module, stubs) File "D:\python\lib\site-packages\torch\jit\_recursive.py", line 336, in create_script_module_impl script_module = torch.jit.RecursiveScriptModule._construct(cpp_module, init_fn) File "D:\python\lib\site-packages\torch\jit\__init__.py", line 1593, in _construct init_fn(script_module) File "D:\python\lib\site-packages\torch\jit\_recursive.py", line 328, in init_fn scripted = recursive_script(orig_value) File "D:\python\lib\site-packages\torch\jit\_recursive.py", line 534, in recursive_script return create_script_module(nn_module, infer_methods_to_compile(nn_module)) File "D:\python\lib\site-packages\torch\jit\_recursive.py", line 296, in create_script_module return create_script_module_impl(nn_module, concrete_type, cpp_module, stubs) File "D:\python\lib\site-packages\torch\jit\_recursive.py", line 336, in create_script_module_impl script_module = torch.jit.RecursiveScriptModule._construct(cpp_module, init_fn) File "D:\python\lib\site-packages\torch\jit\__init__.py", line 1593, in _construct init_fn(script_module) File "D:\python\lib\site-packages\torch\jit\_recursive.py", line 328, in init_fn scripted = recursive_script(orig_value) File "D:\python\lib\site-packages\torch\jit\_recursive.py", line 534, in recursive_script return create_script_module(nn_module, infer_methods_to_compile(nn_module)) File "D:\python\lib\site-packages\torch\jit\_recursive.py", line 296, in create_script_module return create_script_module_impl(nn_module, concrete_type, cpp_module, stubs) File "D:\python\lib\site-packages\torch\jit\_recursive.py", line 336, in create_script_module_impl script_module = torch.jit.RecursiveScriptModule._construct(cpp_module, init_fn) File "D:\python\lib\site-packages\torch\jit\__init__.py", line 1593, in _construct init_fn(script_module) File "D:\python\lib\site-packages\torch\jit\_recursive.py", line 321, in init_fn orig_value = getattr(nn_module, name) File "D:\python\lib\site-packages\torch\nn\modules\module.py", line 576, in __getattr__ type(self).__name__, name)) AttributeError: 'Sequential' object has no attribute 'shortcut_4' ``` ## Expected behavior Script should convert model to Torch Script succesfully. ## Environment PyTorch version: 1.4.0 Is debug build: No CUDA used to build PyTorch: 10.1 OS: Microsoft Windows 10 Pro GCC version: Could not collect CMake version: version 3.17.1 Python version: 3.7 Is CUDA available: Yes CUDA runtime version: 10.2.89 GPU models and configuration: GPU 0: GeForce GTX 980 Nvidia driver version: 441.22 cuDNN version: C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v10.2\bin\cudnn64_7.dll Versions of relevant libraries: [pip3] numpy==1.18.1 [pip3] torch==1.4.0 [pip3] torchfile==0.1.0 [pip3] torchtext==0.4.0 [pip3] torchvision==0.5.0 [conda] Could not collect cc @ezyang @gchanan @zou3519 @suo
high priority,triage review,oncall: jit,triaged
low
Critical
604,194,031
pytorch
Guidance on implementing a new backend
## ๐Ÿš€ Feature <!-- A clear and concise description of the feature proposal --> I'm looking to implement a new backend for mobile (ios GPU compute). The primary goal would be to use this for execution of torchscript modules, but I'm also interested in using the c++ api directly on ios. Iโ€™ve looked through the code enough to know I need to register kernels with the dispatcher and ultimately use the PrivateUse DispatchKey to get the dispatcher to use my kernels. But where things go / how to hook things together has been hard to trace (every time I think I understand the dependency structure between ATen, c10, torch::jit, etc, I see a usage of something that makes me realize I didnโ€™t fully understand it). Is there any examples / docs / guidance of implementing a new backend someone could point to? I looked at the wiki a decent amount but the wiki seems to be a bit _ahead_ of the code, but happy to read through any documentation or more advanced descriptions of the architecture where applicable.
oncall: mobile
low
Major
604,201,355
tensorflow
TPU PyFunction results in UnavailableError: failed to connect to all addresses
**System information** - Have I written custom code (as opposed to using a stock example script provided in TensorFlow): Modified [Colab MNIST guide](https://www.tensorflow.org/guide/tpu) - OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Google Colab - TensorFlow version (use command below): `2.2-rc3` **Describe the current behavior** When processing pipeline for `tf.data.Dataset` contains usage of `tf.py_function` the `UnavailableError: failed to connect to all addresses` is thrown on TPU environment. **Describe the expected behavior** `tf.py_function` is working on TPU environments. **Standalone code to reproduce the issue** [Colab notebook](https://colab.research.google.com/drive/1D7qU4f1FZqieYHdyUezUEFPWoVZZJSxi) with simplified example. In my original code the preprocessing function is more complicated. **Other info / logs** Related issue: [34346](https://github.com/tensorflow/tensorflow/issues/34346). Stacktrace: ``` --------------------------------------------------------------------------- UnavailableError Traceback (most recent call last) /usr/local/lib/python3.6/dist-packages/tensorflow/python/eager/context.py in execution_mode(mode) 1985 ctx.executor = executor_new -> 1986 yield 1987 finally: 14 frames /usr/local/lib/python3.6/dist-packages/tensorflow/python/data/ops/iterator_ops.py in _next_internal(self) 660 except AttributeError: --> 661 return structure.from_compatible_tensor_list(self._element_spec, ret) 662 /usr/local/lib/python3.6/dist-packages/tensorflow/python/data/util/structure.py in from_compatible_tensor_list(element_spec, tensor_list) 229 lambda spec, value: spec._from_compatible_tensor_list(value), --> 230 element_spec, tensor_list) 231 /usr/local/lib/python3.6/dist-packages/tensorflow/python/data/util/structure.py in _from_tensor_list_helper(decode_fn, element_spec, tensor_list) 204 value = tensor_list[i:i + num_flat_values] --> 205 flat_ret.append(decode_fn(component_spec, value)) 206 i += num_flat_values /usr/local/lib/python3.6/dist-packages/tensorflow/python/data/util/structure.py in <lambda>(spec, value) 228 return _from_tensor_list_helper( --> 229 lambda spec, value: spec._from_compatible_tensor_list(value), 230 element_spec, tensor_list) /usr/local/lib/python3.6/dist-packages/tensorflow/python/framework/tensor_spec.py in _from_compatible_tensor_list(self, tensor_list) 176 assert len(tensor_list) == 1 --> 177 tensor_list[0].set_shape(self._shape) 178 return tensor_list[0] /usr/local/lib/python3.6/dist-packages/tensorflow/python/framework/ops.py in set_shape(self, shape) 1103 def set_shape(self, shape): -> 1104 if not self.shape.is_compatible_with(shape): 1105 raise ValueError( /usr/local/lib/python3.6/dist-packages/tensorflow/python/framework/ops.py in shape(self) 1066 except core._NotOkStatusException as e: -> 1067 six.raise_from(core._status_to_exception(e.code, e.message), None) 1068 /usr/local/lib/python3.6/dist-packages/six.py in raise_from(value, from_value) UnavailableError: failed to connect to all addresses Additional GRPC error information: {"created":"@1587494349.376555159","description":"Failed to pick subchannel","file":"third_party/grpc/src/core/ext/filters/client_channel/client_channel.cc","file_line":3959,"referenced_errors":[{"created":"@1587494349.376552078","description":"failed to connect to all addresses","file":"third_party/grpc/src/core/ext/filters/client_channel/lb_policy/pick_first/pick_first.cc","file_line":394,"grpc_status":14}]} During handling of the above exception, another exception occurred: UnavailableError Traceback (most recent call last) <ipython-input-8-f9a6a321af70> in <module>() 1 train_dataset, test_dataset = get_dataset() ----> 2 list(train_dataset.take(1)) /usr/local/lib/python3.6/dist-packages/tensorflow/python/data/ops/iterator_ops.py in __next__(self) 629 630 def __next__(self): # For Python 3 compatibility --> 631 return self.next() 632 633 def _next_internal(self): /usr/local/lib/python3.6/dist-packages/tensorflow/python/data/ops/iterator_ops.py in next(self) 668 """Returns a nested structure of `Tensor`s containing the next element.""" 669 try: --> 670 return self._next_internal() 671 except errors.OutOfRangeError: 672 raise StopIteration /usr/local/lib/python3.6/dist-packages/tensorflow/python/data/ops/iterator_ops.py in _next_internal(self) 659 return self._element_spec._from_compatible_tensor_list(ret) # pylint: disable=protected-access 660 except AttributeError: --> 661 return structure.from_compatible_tensor_list(self._element_spec, ret) 662 663 @property /usr/lib/python3.6/contextlib.py in __exit__(self, type, value, traceback) 97 value = type() 98 try: ---> 99 self.gen.throw(type, value, traceback) 100 except StopIteration as exc: 101 # Suppress StopIteration *unless* it's the same exception that /usr/local/lib/python3.6/dist-packages/tensorflow/python/eager/context.py in execution_mode(mode) 1987 finally: 1988 ctx.executor = executor_old -> 1989 executor_new.wait() 1990 1991 /usr/local/lib/python3.6/dist-packages/tensorflow/python/eager/executor.py in wait(self) 65 def wait(self): 66 """Waits for ops dispatched in this executor to finish.""" ---> 67 pywrap_tfe.TFE_ExecutorWaitForAllPendingNodes(self._handle) 68 69 def clear_error(self): UnavailableError: failed to connect to all addresses Additional GRPC error information: {"created":"@1587494349.376555159","description":"Failed to pick subchannel","file":"third_party/grpc/src/core/ext/filters/client_channel/client_channel.cc","file_line":3959,"referenced_errors":[{"created":"@1587494349.376552078","description":"failed to connect to all addresses","file":"third_party/grpc/src/core/ext/filters/client_channel/lb_policy/pick_first/pick_first.cc","file_line":394,"grpc_status":14}]} ```
stat:awaiting tensorflower,type:bug,comp:tpus,TF 2.9
medium
Critical
604,217,274
flutter
[Web] InputDecorator Test - Expected closure does not match
[From Skip Audit] Here is the broken test: https://github.com/flutter/flutter/blob/45c5250825b07d639a30bca39709b81f6b56c12d/packages/flutter/test/material/input_decorator_test.dart#L3612 Results: ``` 04:21 +597 ~14 -1: /tmp/flutter sdk/packages/flutter/test/material/input_decorator_test.dart: OutlineInputBorder borders scale down to fit when large values are passed in โ•โ•โ•ก EXCEPTION CAUGHT BY FLUTTER TEST FRAMEWORK โ•žโ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ• The following TestFailure object was thrown running a test: Expected: Object or closure painting: 'save()', 'a path with Color(0xff00ff00), PaintingStyle.fill, that contains [Offset(400.0, 0.0), Offset(400.0, 56.0), Offset(0.0, 28.0), Offset(800.0, 28.0), Offset(800.0, 28.0), Offset(772.0, 56.0), Offset(800.0, 28.0), Offset(772.0, 0.0), Offset(0.0, 42.0), Offset(14.0, 56.0), Offset(0.0, 14.0), Offset(14.0, 0.0)] and does not contain [Offset(0.0, 0.0), Offset(800.0, 0.0), Offset(0.0, 56.0), Offset(800.0, 56.0), Offset(800.0, 42.0), Offset(786.0, 800.0), Offset(800.0, 14.0), Offset(786.0, 0.0)]', 'restore()' Actual: _DescendantFinder:<exactly one widget with widget matching predicate (Closure: (Widget) => bool from: w => basic.CustomPaint.is(w)) that has ancestor(s) with widget matching predicate (Closure: (Widget) => bool from: w => dart.str(dart.runtimeType(w)) === "_BorderContainer") (ignoring offstage widgets): CustomPaint(renderObject: RenderCustomPaint#380b8)> Which: did not match the pattern. It called drawPath with a path that unexpectedly did not contain Offset(800.0, 28.0). The stack of the offending call was: package:dart-sdk/lib/_internal/js_dev_runtime/private/ddc_runtime/errors.dart 247:20 get current ../rendering/recording_canvas.dart 89:70 noSuchMethod ../rendering/recording_canvas.dart 90:3 drawPath package:flutter/src/material/input_decorator.dart 98:13 paint package:flutter/src/rendering/custom_paint.dart 531:12 [_paintWithPainter] package:flutter/src/rendering/custom_paint.dart 577:7 paint ../rendering/mock_canvas.dart 516:19 _evaluatePainter ../rendering/mock_canvas.dart 533:12 matches package:test_api/src/frontend/expect.dart 142:17 _expect package:test_api/src/frontend/expect.dart 60:3 expect$ package:flutter_test/src/widget_tester.dart 348:3 expect$ input_decorator_test.dart 3612:5 <fn> package:dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 47:50 onValue package:dart-sdk/lib/async/zone.dart 1192:38 _rootRunUnary package:dart-sdk/lib/async/zone.dart 1085:19 runUnary package:dart-sdk/lib/async/future_impl.dart 141:18 handleValue package:dart-sdk/lib/async/future_impl.dart 682:44 handleValueCallback package:dart-sdk/lib/async/future_impl.dart 711:32 _propagateToListeners package:dart-sdk/lib/async/future_impl.dart 526:5 [_completeWithValue] package:dart-sdk/lib/async/future_impl.dart 556:7 <fn> package:dart-sdk/lib/_internal/js_dev_runtime/private/ddc_runtime/operations.dart 306:14 _checkAndCall package:dart-sdk/lib/_internal/js_dev_runtime/private/ddc_runtime/operations.dart 311:39 dcall package:quiver/testing/src/async/fake_async.dart 265:32 [_drainMicrotasks] package:quiver/testing/src/async/fake_async.dart 164:5 flushMicrotasks package:flutter_test/src/binding.dart 1099:16 <fn> package:dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 86:54 runBody package:dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 125:12 _async package:flutter_test/src/binding.dart 1087:35 <fn> package:dart-sdk/lib/async/future.dart 202:37 <fn> package:dart-sdk/lib/async/zone.dart 1180:38 _rootRun package:dart-sdk/lib/async/zone.dart 1077:19 run package:dart-sdk/lib/async/zone.dart 979:7 runGuarded package:dart-sdk/lib/async/zone.dart 1019:23 <fn> package:dart-sdk/lib/async/zone.dart 1184:13 _rootRun package:dart-sdk/lib/async/zone.dart 1077:19 run package:dart-sdk/lib/async/zone.dart 979:7 runGuarded package:dart-sdk/lib/async/zone.dart 1019:23 callback package:dart-sdk/lib/async/schedule_microtask.dart 43:11 _microtaskLoop package:dart-sdk/lib/async/schedule_microtask.dart 52:5 _startMicrotaskLoop package:dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 168:15 <fn> (elided 7 frames from package:stack_trace) The complete display list was: * save() * drawPath(Path(Subpath(RRect.fromLTRBAndCorners(0.0, 0.0, 800.0, 56.0, topLeft: Radius.circular(100.0), topRight: Radius.circular(200.0), bottomRight: Radius.circular(200.0), bottomLeft: Radius.circular(100.0)))), Paint(Color(0xff00ff00))) * drawPath(Path(Subpath(Ellipse(14.215538847117793, 14.215538847117793, 13.715538847117793, 13.715538847117793)), Subpath(MoveTo(14.215538847117793, 0.5)), Subpath(MoveTo(142.21553884711778, 0.5), LineTo(772, 0.5)), Subpath(Ellipse(772, 28, 27.5, 27.5)), Subpath(MoveTo(799.5, 28), LineTo(799.5, 28)), Subpath(Ellipse(772, 28, 27.5, 27.5), LineTo(14.215538847117793, 55.5)), Subpath(Ellipse(14.215538847117793, 41.78446115288221, 13.715538847117793, 13.715538847117793), LineTo(0.5, 14.215538847117793))), Paint(PaintingStyle.stroke 1; Color(0x8a000000))) * restore() When the exception was thrown, this was the stack: package:dart-sdk/lib/_internal/js_dev_runtime/private/ddc_runtime/errors.dart 195:49 throw_ package:test_api/src/frontend/expect.dart 154:30 fail package:test_api/src/frontend/expect.dart 148:3 _expect package:test_api/src/frontend/expect.dart 60:3 expect$ package:flutter_test/src/widget_tester.dart 348:3 expect$ input_decorator_test.dart 3612:5 <fn> package:dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 47:50 onValue package:dart-sdk/lib/async/zone.dart 1192:38 _rootRunUnary package:dart-sdk/lib/async/zone.dart 1085:19 runUnary package:dart-sdk/lib/async/future_impl.dart 141:18 handleValue package:dart-sdk/lib/async/future_impl.dart 682:44 handleValueCallback package:dart-sdk/lib/async/future_impl.dart 711:32 _propagateToListeners package:dart-sdk/lib/async/future_impl.dart 526:5 [_completeWithValue] package:dart-sdk/lib/async/future_impl.dart 556:7 <fn> package:dart-sdk/lib/_internal/js_dev_runtime/private/ddc_runtime/operations.dart 306:14 _checkAndCall package:dart-sdk/lib/_internal/js_dev_runtime/private/ddc_runtime/operations.dart 311:39 dcall package:quiver/testing/src/async/fake_async.dart 265:32 [_drainMicrotasks] package:quiver/testing/src/async/fake_async.dart 164:5 flushMicrotasks package:flutter_test/src/binding.dart 1099:16 <fn> package:dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 86:54 runBody package:dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 125:12 _async package:flutter_test/src/binding.dart 1087:35 <fn> package:dart-sdk/lib/async/future.dart 202:37 <fn> package:dart-sdk/lib/async/zone.dart 1180:38 _rootRun package:dart-sdk/lib/async/zone.dart 1077:19 run package:dart-sdk/lib/async/zone.dart 979:7 runGuarded package:dart-sdk/lib/async/zone.dart 1019:23 <fn> package:dart-sdk/lib/async/zone.dart 1184:13 _rootRun package:dart-sdk/lib/async/zone.dart 1077:19 run package:dart-sdk/lib/async/zone.dart 979:7 runGuarded package:dart-sdk/lib/async/zone.dart 1019:23 callback package:dart-sdk/lib/async/schedule_microtask.dart 43:11 _microtaskLoop package:dart-sdk/lib/async/schedule_microtask.dart 52:5 _startMicrotaskLoop package:dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 168:15 <fn> (elided 7 frames from package:stack_trace) The test description was: OutlineInputBorder borders scale down to fit when large values are passed in โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ• 04:21 +597 ~14 -2: /tmp/flutter sdk/packages/flutter/test/material/input_decorator_test.dart: OutlineInputBorder borders scale down to fit when large values are passed in [E] Test failed. See exception logs above. The test description was: OutlineInputBorder borders scale down to fit when large values are passed in ```
a: tests,a: text input,team,framework,f: material design,platform-web,P2,team-web,triaged-web
low
Critical
604,217,628
youtube-dl
Site Support Feature Request: G/O Media Website videos (Lifehacker, etc.)
<!-- ###################################################################### WARNING! IGNORING THE FOLLOWING TEMPLATE WILL RESULT IN ISSUE CLOSED AS INCOMPLETE ###################################################################### --> ## Checklist <!-- Carefully read and work through this check list in order to prevent the most common mistakes and misuse of youtube-dl: - First of, make sure you are using the latest version of youtube-dl. Run `youtube-dl --version` and ensure your version is 2020.03.24. If it's not, see https://yt-dl.org/update on how to update. Issues with outdated version will be REJECTED. CHECK - Make sure that all provided video/audio/playlist URLs (if any) are alive and playable in a browser. - Make sure that site you are requesting is not dedicated to copyright infringement, see https://yt-dl.org/copyright-infringement. youtube-dl does not support such sites. In order for site support request to be accepted all provided example URLs should not violate any copyrights. - Search the bugtracker for similar site support requests: http://yt-dl.org/search-issues. DO NOT post duplicates. - Finally, put x into all relevant boxes (like this [x]) --> - [x] I'm reporting a new site support request - [x] I've verified that I'm running youtube-dl version **2020.03.24** - [x] I've checked that all provided URLs are alive and playable in a browser - [x] I've checked that none of provided URLs violate any copyrights - [x] I've searched the bugtracker for similar site support requests including closed ones ## Example URLs <!-- Provide all kinds of example URLs support for which should be included. Replace following example URLs by yours. --> - Single video: https://www.youtube.com/watch?v=BaW_jenozKc - Single video: https://youtu.be/BaW_jenozKc - Playlist: https://www.youtube.com/playlist?list=PL4lCao7KL_QFVb7Iudeipvc2BCavECqzc https://lifehacker.com/can-you-be-happy-in-quarantine-1842964815 ## Description <!-- Provide any additional information. If work on your issue requires account credentials please provide them or explain how one can obtain them. --> WRITE DESCRIPTION HERE LIfehacker videos and other videos produced on G/O Media websites.
site-support-request
low
Critical