id
int64 393k
2.82B
| repo
stringclasses 68
values | title
stringlengths 1
936
| body
stringlengths 0
256k
β | labels
stringlengths 2
508
| priority
stringclasses 3
values | severity
stringclasses 3
values |
|---|---|---|---|---|---|---|
466,228,516 | ant-design | multiple TreeSelect onChange params different | - [ ] I have searched the [issues](https://github.com/ant-design/ant-design/issues) of this repository and believe that this is not a duplicate.
### Reproduction link
[https://codepen.io/Enivia-Q/pen/GbzpPG](https://codepen.io/Enivia-Q/pen/GbzpPG)
### Steps to reproduce
1. check tree nodes from drop-down list
2. delete checked items from input box
3. console.log(extra.allCheckedNodes)
### What is expected?
change from drop-down list and input box but getting different-type nodes list
### What is actually happening?
got same-type node list
| Environment | Info |
|---|---|
| antd | 3.20.1 |
| React | 16.8.6 |
| System | Windows |
| Browser | Chrome 75.0.3770.100 |
<!-- generated by ant-design-issue-helper. DO NOT REMOVE --> | π£ Discussion,Inactive | low | Minor |
466,228,658 | storybook | Addon-backgrounds: Add parameter to enable grid by default | **Is your feature request related to a problem? Please describe.**
No.
**Describe the solution you'd like**
I'd like a new [Options Parameter](https://storybook.js.org/docs/configurations/options-parameter/) to control the initial setting of the "Toggle Background Grid" setting, e.g. `showBackgroundGrid`, so that I can enable it by default.
**Describe alternatives you've considered**
According to https://github.com/storybookjs/storybook/issues/5853#issuecomment-475466382 it looks like it's possible to implement your own grid with the Storybook Background Addon.
**Are you able to assist bring the feature to reality?**
No.
**Additional context**
I think that should be enough info, but let me know if there's anything else I can provide. Thanks!
| feature request,good first issue,help wanted,has workaround,addon: backgrounds | medium | Critical |
466,265,617 | go | gollvm: unable to build etcd | <!-- Please answer these questions before submitting your issue. Thanks! -->
### What version of Go are you using (`go version`)?
<pre>
$ go version
go version go1.12.2 gollvm LLVM 9.0.0svn linux/amd64
</pre>
### Does this issue reproduce with the latest release?
yes
### What operating system and processor architecture are you using (`go env`)?
linux/amd64
### What did you do?
As reported by [email protected]
<pre>
$ git clone https://github.com/etcd-io/etcd.git
$ cd etcd/ && ./build
</pre>
### What did you expect to see?
Successful compilation
### What did you see instead?
<pre>
go build: when using gccgo toolchain, please pass linker flags using -gccgoflags, not -ldflags
# go.etcd.io/etcd/etcdserver/api/rafthttp
#0 0x000055ecc4cfa34a llvm::sys::PrintStackTrace(llvm::raw_ostream&) (/home/yt/LLVMsvn/install/bin/llvm-goc+0xa6c34a)
#1 0x000055ecc4cf8124 llvm::sys::RunSignalHandlers() (/home/yt/LLVMsvn/install/bin/llvm-goc+0xa6a124)
#2 0x000055ecc4cf8262 SignalHandler(int) (/home/yt/LLVMsvn/install/bin/llvm-goc+0xa6a262)
#3 0x00007fbbd49d5890 __restore_rt (/lib/x86_64-linux-gnu/libpthread.so.0+0x12890)
#4 0x000055ecc44f0940 Export::type_index(Type const*) (/home/yt/LLVMsvn/install/bin/llvm-goc+0x262940)
#5 0x000055ecc44f0c31 Export::write_type(Type const*) (/home/yt/LLVMsvn/install/bin/llvm-goc+0x262c31)
#6 0x000055ecc449f2e1 Named_type::do_export(Export*) const (/home/yt/LLVMsvn/install/bin/llvm-goc+0x2112e1)
#7 0x000055ecc44f10ce Export::write_type_definition(Type const*, int) (/home/yt/LLVMsvn/install/bin/llvm-goc+0x2630ce)
#8 0x000055ecc44f1390 Export::write_types(int) (/home/yt/LLVMsvn/install/bin/llvm-goc+0x263390)
#9 0x000055ecc44fcea0 Export::export_globals(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::map<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, Package*, std::less<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::allocator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, Package*> > > const&, std::map<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, Package*, std::less<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::allocator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, Package*> > > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, Import_init_set const&, Bindings const*) (/home/yt/LLVMsvn/install/bin/llvm-goc+0x26eea0)
#10 0x000055ecc4457047 Gogo::do_exports() (/home/yt/LLVMsvn/install/bin/llvm-goc+0x1c9047)
#11 0x000055ecc4441a90 go_parse_input_files(char const**, unsigned int, bool, bool) (/home/yt/LLVMsvn/install/bin/llvm-goc+0x1b3a90)
#12 0x000055ecc442ee69 gollvm::driver::CompileGoImpl::invokeFrontEnd() (/home/yt/LLVMsvn/install/bin/llvm-goc+0x1a0e69)
#13 0x000055ecc4436ee5 gollvm::driver::CompileGoImpl::performAction(gollvm::driver::Compilation&, gollvm::driver::Action const&, llvm::SmallVector<gollvm::driver::Artifact*, 3u> const&, gollvm::driver::Artifact const&) (/home/yt/LLVMsvn/install/bin/llvm-goc+0x1a8ee5)
#14 0x000055ecc442950f gollvm::driver::Driver::processAction(gollvm::driver::Action*, gollvm::driver::Compilation&, bool) (/home/yt/LLVMsvn/install/bin/llvm-goc+0x19b50f)
#15 0x000055ecc44296af gollvm::driver::Driver::processActions(gollvm::driver::Compilation&) (/home/yt/LLVMsvn/install/bin/llvm-goc+0x19b6af)
#16 0x000055ecc43cf403 main (/home/yt/LLVMsvn/install/bin/llvm-goc+0x141403)
#17 0x00007fbbd386db97 __libc_start_main /build/glibc-OTsEL5/glibc-2.27/csu/../csu/libc-start.c:344:0
#18 0x000055ecc442130a _start (/home/yt/LLVMsvn/install/bin/llvm-goc+0x19330a)
Stack dump:
0. Program arguments: /home/yt/LLVMsvn/install/bin/llvm-goc -c -O2 -g -m64 -fdebug-prefix-map=/tmp/go-build979597534=/tmp/go-build -gno-record-gcc-switches -fgo-pkgpath=go.etcd.io/etcd/etcdserver/api/rafthttp -o $WORK/b192/_go_.o -I $WORK/b192/_importcfgroot_ etcdserver/api/rafthttp/coder.go etcdserver/api/rafthttp/doc.go etcdserver/api/rafthttp/http.go etcdserver/api/rafthttp/metrics.go etcdserver/api/rafthttp/msg_codec.go etcdserver/api/rafthttp/msgappv2_codec.go etcdserver/api/rafthttp/peer.go etcdserver/api/rafthttp/peer_status.go etcdserver/api/rafthttp/pipeline.go etcdserver/api/rafthttp/probing_status.go etcdserver/api/rafthttp/remote.go etcdserver/api/rafthttp/snapshot_sender.go etcdserver/api/rafthttp/stream.go etcdserver/api/rafthttp/transport.go etcdserver/api/rafthttp/urlpick.go etcdserver/api/rafthttp/util.go
</pre>
Needs investigation. There have been several changes and bugs in import/export lately; this looks like a new one.
| NeedsInvestigation | low | Critical |
466,272,588 | flutter | Support for Client Certificate in the WebView widget? | <!-- Thank you for using Flutter!
Please check out our documentation first:
* https://flutter.dev/
* https://api.flutter.dev/
If you can't find the answer there, please consider asking a question on
the Stack Overflow Web site:
* https://stackoverflow.com/questions/tagged/flutter?sort=frequent
Please don't file a GitHub issue for support requests. GitHub issues are
for tracking defects in the product. If you file a bug asking for help, we
will consider this a request for a documentation update.
-->
I am trying to use the [WebView widget ](https://pub.dev/packages/webview_flutter), but the URL that am accessing needs a Client Certificate (as the URL is enabled with 2-way SSL).
Does the Flutter WebView widget support passing of the client certificate for 2-way SSL communication? | c: new feature,p: webview,package,team-ecosystem,P3,triaged-ecosystem | medium | Critical |
466,306,095 | flutter | PageView does not have optional scrolling on both ends. | The following widget should have an optional property to add the behaviour of swiping from thirdDay to firstDay and from firstDay to thirdDay. At this point some gimmick needs to be done to have this applied.
```dart
Widget build(BuildContext context) {
return Scaffold(
backgroundColor: Theme.of(context).secondaryHeaderColor,
body: Column(
children: <Widget>[
header(currentPage, _pageController),
Expanded(
child: PageView(
controller: _pageController,
onPageChanged: (index) {
pageChanged(index);
},
children: <Widget>[
firstDay(context),
secondDay(context),
thirdDay(context)
],
),
),
],
),
);
}
``` | c: new feature,framework,f: scrolling,P3,team-framework,triaged-framework | low | Minor |
466,307,959 | rust | Rustdoc should not fail to generate documentation when deep types are involved | Ref. https://github.com/rust-lang/rust/issues/62059
To fix the referenced issue we raised the recursion limit, however if there is a type that exceeds this limit again, we will start failing to generate documentation for the crate in question and all the dependent crates using these deep types again.
rustdoc uses the regular trait selection mechanism to check for auto-traits, so it is not too easy to make rustdoc to ignore those failures and not generate an entry for the implementation in rustdoc instead of erroring.
Ideal behaviour would be a warning during documentation generation and a missing entry in the "Implementors" section. | T-rustdoc,C-bug | low | Critical |
466,321,785 | pytorch | CMAKE_PARSE_IMPLICIT_LINK_INFO Function invoked with incorrect arguments | https://circleci.com/gh/pytorch/pytorch/2160467?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link
```
Jul 09 16:47:24 CMake Error at cmake/Modules/FindOpenMP.cmake:287 (cmake_parse_implicit_link_info):
Jul 09 16:47:24 CMAKE_PARSE_IMPLICIT_LINK_INFO Function invoked with incorrect arguments
Jul 09 16:47:24 for function named: CMAKE_PARSE_IMPLICIT_LINK_INFO
Jul 09 16:47:24 Call Stack (most recent call first):
Jul 09 16:47:24 cmake/Modules/FindOpenMP.cmake:481 (_OPENMP_GET_FLAGS)
Jul 09 16:47:24 cmake/Modules/FindMKL.cmake:172 (FIND_PACKAGE)
Jul 09 16:47:24 cmake/Modules/FindMKL.cmake:265 (CHECK_ALL_LIBRARIES)
Jul 09 16:47:24 cmake/Dependencies.cmake:131 (find_package)
Jul 09 16:47:24 CMakeLists.txt:270 (include)
Jul 09 16:47:24
Jul 09 16:47:24
Jul 09 16:47:24 CMake Error at cmake/Modules/FindOpenMP.cmake:287 (cmake_parse_implicit_link_info):
Jul 09 16:47:24 CMAKE_PARSE_IMPLICIT_LINK_INFO Function invoked with incorrect arguments
Jul 09 16:47:24 for function named: CMAKE_PARSE_IMPLICIT_LINK_INFO
Jul 09 16:47:24 Call Stack (most recent call first):
Jul 09 16:47:24 cmake/Modules/FindOpenMP.cmake:481 (_OPENMP_GET_FLAGS)
Jul 09 16:47:24 cmake/Modules/FindMKL.cmake:172 (FIND_PACKAGE)
Jul 09 16:47:24 cmake/Modules/FindMKL.cmake:265 (CHECK_ALL_LIBRARIES)
Jul 09 16:47:24 cmake/Dependencies.cmake:131 (find_package)
Jul 09 16:47:24 CMakeLists.txt:270 (include)
``` | module: build,triaged,module: flaky-tests,has workaround | low | Critical |
466,360,597 | vue | Cannot bind external web-component's 'value' property as an object | ### Version
2.6.10
### Reproduction link
[https://embed.plnkr.co/2KKE9ixZJLrRB6FUNIou/](https://embed.plnkr.co/2KKE9ixZJLrRB6FUNIou/)
### Steps to reproduce
Steps to reproduce (see the attached plunkr):
1. Create a web-component (not using Vue).
2. Expose a 'value' property in this web component that accepts/returns non-string objects (e.g. a Date object).
3. Instantiate the web component in Vue and bind the property using :value.prop syntax
### What is expected?
The object is passed as is.
### What is actually happening?
The object is converted to string before being set to the web-component 's property.
---
It is more and more common to include third party components written in other frameworks and directly use it in Vue.
However, it seems that the Vue code always expect the 'value' property to be of type string. Let's suppose to import a date selector as ES5 web custom component, that defines the 'value' property to be a Date object.
Vue will always pass this value as string instead. Using a different property name works as expected.
<!-- generated by vue-issues. DO NOT REMOVE --> | has workaround | low | Major |
466,376,417 | go | archive/zip: reject certain invalid archives | This is not a defect report, but a suggestion to review the Zip archive reader with this new and authoritative zipbomb treatise in mind:
https://www.bamsoftware.com/hacks/zipbomb/
| NeedsInvestigation | medium | Major |
466,390,784 | pytorch | DispatchStub should report what operator it failed to find kernel for | In #22681 we get an unhelpful error message because it just says that CUDA kernels is missing, it doesn't say what is missing. It would be good of dispatch stub gave more information. Maybe we can pass in a string constant to the template parameter and update the macro to stringify the struct name to pass in.
cc @cpuhrsch @VitalyFedyunin @colesbury | module: internals,module: cpu,triaged | low | Critical |
466,436,779 | go | cmd/go: go mod init doesn't import nested module, tidy picks older version | In this case, the `glide.lock` file depends on a version of `github.com/hashicorp/consul` that uses modules and submodules. Before `go mod tidy`, we are depending on `v1.5.1`, a commit with date 2019-05-22. After `go mod tidy`, the dependency has regressed to the latest available `api` submodule version, `v1.1.0`, a commit with date 2019-05-08.
This is a dependency regression which could potentially have broken code relying on new features added between the two commits, something that `go mod tidy` shouldn't be able to do.
I suspect that `go mod tidy` needs to use a pseudoversion commit in this case, perhaps `github.com/hashicorp/consul/api v1.1.1-0.20190522201912-40cec98468b8`.
```
% go version
go version devel +a05c132064 Wed Jul 10 15:52:04 2019 +0000 linux/amd64
% ls
glide.lock main.go
% cat glide.lock
hash: 0a6384395a31012cdcb431685f7cbe2ab3e4fb82412f708c491a785002881ed0
updated: 2019-06-05T16:36:27.768346055+02:00
imports:
- name: github.com/hashicorp/consul
version: 40cec98468b829e5cdaacb0629b3e23a028db688
subpackages:
- api
% cat main.go
package main
import _ "github.com/hashicorp/consul/api"
func main() {
}
% go mod init m
go: creating new go.mod: module m
go: copying requirements from glide.lock
% cat go.mod
module m
go 1.13
require github.com/hashicorp/consul v1.5.1
% go mod tidy
% cat go.mod
module m
go 1.13
require (
github.com/hashicorp/consul/api v1.1.0
github.com/hashicorp/go-msgpack v0.5.4 // indirect
github.com/hashicorp/memberlist v0.1.4 // indirect
golang.org/x/crypto v0.0.0-20190325154230-a5d413f7728c // indirect
golang.org/x/net v0.0.0-20190403144856-b630fd6fe46b // indirect
golang.org/x/sync v0.0.0-20190227155943-e225da77a7e6 // indirect
golang.org/x/sys v0.0.0-20190403152447-81d4e9dc473e // indirect
)
``` | NeedsInvestigation,modules | medium | Critical |
466,471,932 | go | archive/zip: provide API for resource limits | Zip unpacking can generate outputs thousands of times larger than the input. We should provide a security API that lets callers limit the resources that can be spent for unpacking untrusted archives.
It might be enough to limit the output size, if CPU and memory are always dependent on it.
See https://www.bamsoftware.com/hacks/zipbomb/ and #33026 | Security,NeedsInvestigation | low | Minor |
466,489,868 | rust | Should Rust still ignore SIGPIPE by default? | Back in 2014, the Rust startup code (which runs before main) started ignoring SIGPIPE by default: https://github.com/rust-lang/rust/pull/13158
This dates back to when Rust had a runtime and a green-threads implementation, and more magic handling of I/O. The pull request mentions that it "brings the behavior inline with libgreen".
This doesn't seem to be documented anywhere, as far as I can tell; at a minimum, this needs documentation.
But I'd like to question whether we should still do this by default. See https://github.com/rust-lang/rust/issues/46016 for some recent discussion of this. This changes the default behavior of pipes from what people might expect when writing UNIX applications. Rust currently resets the signal mask in a child process, but that's only if you use *Rust* to launch the child process rather than calling a library to do so. And in addition to that, signal handlers are process-wide, and people might not expect Rust to change process-wide state like this. This also means that Rust *libraries* will not have the same behavior as Rust *applications*.
Either way, this is something we need to document far better. Some people will want one behavior, and some people will want the other, so whichever we use as the default needs careful documentation and a documented procedure to change it.
EDIT (based on a suggestion from @Centril): Perhaps we could control this with an attribute on `main` or on the top-level module? | A-runtime,T-lang,T-libs-api,A-maybe-future-edition,I-lang-radar | high | Critical |
466,514,712 | vscode | ability to get/set currently selected debug configuration | Currently, we can run `vscode.debug.startDebugging(workspaceFolder, configName)` to run the debugger from the extension. Is there a way to change currently selected debug configuration from the extension? Something like `vscode.debug.changeCurrentDebugger(workspaceFolder, configName)` would be very helpful. | help wanted,feature-request,api,debug | medium | Critical |
466,517,908 | vscode | Tokenization overhaul | The current tokenisation story of VS Code is based on TM grammars, which are pretty powerful, but we are running into their limits if we want to do something more than a top-down scanner can do. Also, once you implement a TM interpreter, you realise how inefficient the way in which regular expressions must be evaluated is and how TM grammars were not meant to do much more than simple colouring using just a few rules... The fact that we now have these complex grammars than end up producing beautiful tokens is more of a testament to the amazing computing power available to us than to the design of the TM grammar semantics.
At the time when TM grammars were introduced and became popular there were no language servers available which understand the semantics of a language. Therefore, TM grammars were also used to colour semantic constructs. The introduction of LSP has brought us language servers for many languages and it we want to leverage this power to reduce the complexity of the tokenizer/classifier. There is already effort under way to specify how such API might look under LSP at https://github.com/microsoft/vscode-languageserver-node/pull/367
In any case, for smarter languages where we offer great extensions, such as for TypeScript or C++, we have noticed two different patterns emerge to try and compensate for these limitations.
---
#### Complex TM grammar approach (TypeScript)
This approach was taken by TypeScript, where we now have immense regular expressions, which are a testament to the smartness of the author, but which are potentially very slow to evaluate on the UI thread:
---
#### Text Editor Decorations (C++)
This approach was taken by C++, where we now receive potentially unbounded amounts of text editor decorations used to represent semantic tokens which are pushed by the C++ extension to correct or enhance the TM grammar. The limits of text editor decorations start to show, I have collected some of the issues under [this query](https://github.com/microsoft/vscode/issues?q=is%3Aopen+is%3Aissue+label%3Asemantic-coloring). Due to their memory cost, complexity, and breadth of usage (i.e. cannot touch the editing logic around them at this point), text editor decorations are not the right tool for this job...
---
Both approaches show that there is a real need for something more, and that folks which care can get really creative and smart in tackling this need even when we lack as a platform. This issue is about overhauling how tokenization works in VS Code and tries to address multiple goals at once:
#### 1. Move tokenization off the UI thread
Today, TM tokenization runs on the UI thread. Even more interesting, we have numerous features (such as typing a `}` or typing `(`, `'`, `"`, etc) where we need to know synchronously, at the time we interpret the typed character if we are in a comment, in a string, in a regex, or somewhere else... So we have code paths were we end up tokenizing the current line synchronously given the line above is tokenized in order to find out what's the exact context that we are in and then we make a decision based on that.
We have looked into this and built a prototype where we removed the synchronous tokenization... Moving this kind of classification off the UI thread entirely would result in severe flakiness... In other words, *sometimes* pressing `'` would insert `'|'` and sometimes only `'|`, in the same file, in the same location, based purely on typing speed and the time it takes to send tokens over from the web worker. Having an editor where typing something does one thing 90% of the time and another thing 10% of the time based on typing speed would IMHO be completely unacceptable.
As a one-off approach, we have written a fast classifier for comments, strings or regexes for TS, in TS. We will experiment to see if this classifier could be used synchronously on the UI thread to determine what to do when typing these characters (`}`, `'`, etc). The challenge here lies with making it incremental (not start from the beginning of the file for each keystroke). Also, since these syntax constructs are "rare" relative to the entire body of text, a line based representation would not be a good one. Even more ideas are that perhaps we shouldn't store the location of strings, comments, etc. but only the save-points between them given the classifier would be fast enough to compute them again.
Another idea circulating was to enable writing monarch classifiers and contributing them from extensions. This would avoid some of the bad design choices of TM, but would still mean evaluating regexes written by extensions on the UI thread. Yet another idea was to have a "fast" TM grammar that only deals with strings, comments and regexes and another normal one for tokens -- again with the same problem of running regexes written by extension on the UI thread. Another idea was to build some base parser, with components such as C-style comments, C-style strings, etc which could be exercised by extensions (i.e. some kind of higher-order constructs than regexes). Or maybe we should just hand write parsers for the top 90% of our languages to detect strings, comments and regexes... We have not yet taken any clear decision as we still need to experiment in this area to learn more...
#### 2. Accept tokens from the extension host (semantic tokenization)
Moving TM grammars off the UI thread is good for reducing our freezes and crashes, but still does not address the fundamental limitations of TM. Here we need to add API such that semantic tokens can be pushed by the extension host. These tokens should very much behave similar to text editor decorations, but have a different implementation where we can represent them with a lot less memory (just 2 or 3 32bit numbers like we do with the other tokens). We should also tweak the way they are adjusted around typing to make most sense for tokens...
They also need to be updateable incrementally and only as needed. There are discussions of using the visible ranges APIs to prioritize the regions which should receive semantic tokens first. We have not yet began drafting an API nor a reference implementation.
#### 3. (low priority) Enable the integration of other tokenization engines
This is just here to remind us to keep in mind that we might want to move away from the inefficient TM grammars completely at one point in the future. There is a lot of love for Tree-Sitter nowadays and we might want to investigate using it, or we might want to roll our own story, since we do actually have a lot of experience in this area...
----
#### Tasks
- [x] write a fast TS classifier of comments, strings, regex (done [here](https://github.com/microsoft/vscode/blob/4e23501dfa0713c8b2ba5aabe360722509f16a2b/src/vs/editor/common/modes/tokenization/typescript.ts) with tests [here](https://github.com/microsoft/vscode/blob/4e23501dfa0713c8b2ba5aabe360722509f16a2b/src/vs/editor/test/node/classification/typescript-test.ts) )
- [ ] integrate the fast TS classifier and use it for synchronous classification instead of the TM engine
- [ ] figure out how to manage checkpoints and produce classifications incrementally
- [x] be able to run TM grammars on a web worker in the rich client
- [ ] be able to run TM grammars on a web worker in the web ui
- [ ] move the TS TM grammar on a web worker and send, in batches, tokens.
- [ ] move the TS TM grammar on a web worker and implement greedy viewport tokenization on it.
- [ ] once we have async TM tokens, it is not that big of a leap to have async semantic tokens, so explore pushing tokens from the extension host:
- [ ] should we write another tokens store that is not line based since these tokens should be more "rare"?
- [ ] how do we manage two tokens stores, one owned by TM, and one owned by the extension host, how do we merge them to give a consistent picture to the editor view?
- [ ] having TM running in a web worker works because we own both the UI side and the worker side of things, so we know to remember the last N edits, until they get confirmed by the web worker, and the web worker knows which lines to retokenize given it trusts the UI side to update tokens around editing in certain ways. How should we spec this? We need to spec how the editor adjusts tokens when editing and how we expect that the extension host pushes new tokens in the edited areas... | feature-request,tokenization,semantic-tokens | high | Critical |
466,526,180 | flutter | Fail gracefully with a helpful message when the cache directory is not/can't be made writable | This can probably happen when we try to lock the cache directory:
https://github.com/flutter/flutter/blob/master/packages/flutter_tools/lib/src/cache.dart#L136
So far this is 7.3% of tool crashes in 1.7.8+hotfix.3. It's hard to tease apart, but file permissions issues, including in the cache, were 23% of crashes in the previous stable release. | c: crash,tool,a: quality,customer: crowd,P2,team-tool,triaged-tool | low | Critical |
466,526,183 | go | cmd/go: unexpected TestScript/get_brace timeout on illumos-amd64-joyent | From the `illumos-amd64-joyent` builder in https://build.golang.org/log/e8f2fee14aa5f386edc64b79dfeba4f092088200:
```
go test proxy running at GOPROXY=http://127.0.0.1:38179/mod
--- FAIL: TestScript (0.00s)
--- FAIL: TestScript/get_brace (443.52s)
script_test.go:191:
# Set up some empty repositories. (6.969s)
# Clone the empty repositories into GOPATH.
# This tells the Go command where to find them: it takes the place of a user's meta-tag redirector. (0.965s)
# Commit contents to the repositories. (1.060s)
# 'go get' should refuse to download or update the confusingly-named repo. (434.441s)
> cd $GOPATH/src/example.com/foo
$WORK/gopath/src/example.com/foo
> ! go get -u 'example.com/{confusing}'
[stderr]
package example.com/{confusing}: example.com/{confusing}: invalid import path: malformed import path "example.com/{confusing}": invalid char '{'
[exit status 1]
> stderr 'invalid char'
> ! go get -u example.com/foo
[signal: interrupt]
FAIL: testdata/script/get_brace.txt:40: test timed out while running command
FAIL
FAIL cmd/go 522.698s
```
I have no idea where all that time went; it's not obvious to me whether this is due to a `cmd/go` bug or an `illumos` kernel or filesystem bug. | Testing,NeedsInvestigation,OS-illumos | low | Critical |
466,543,473 | pytorch | torch.fill_() exists and modifies the input tensor: Expected or bug? | Seems like in-place functions are method only, but torch.fill_() exists, is undocumented, but is declared in both native_functions.yml and derivatives.yaml.
import torch
a = torch.zeros(3)
torch.fill_(a, 1)
print(a)
This prints:
tensor([1., 1., 1.])
Is this expected?
- PyTorch Version (e.g., 1.0): master
cc @ezyang @SsnL @gchanan | module: bc-breaking,triaged,module: deprecation,module: ux | low | Critical |
466,583,846 | rust | Better greedy layout computation for generators | I've been thinking about a new approach for computing the layout of generators, since I merged #59897. Actually, I've been thinking about it before that, but the approach there felt a bit safer to start with.
The idea is that we use the struct layout computation, rather than the enum computation, as a starting point, and add in the fact that fields can overlap. The basic algorithm is simple:
- We iterate through every field, in descending order of alignment and number of conflicts with other fields*.
- For each field, pick the first offset (with respect to its alignment) that it's still allowed to occupy, given the other fields that we've already placed.
Because we're working in descending order of alignment (and alignments are all powers of 2), we should be able to use a "segment-tree-like" data structure with a bitset of fields that are still allowed to be placed at a given position. This means that updating the tree is logarithmic in the number of alignment levels, and so is searching for the first position a field is allowed to occupy.
This greedy algorithm should be an improvement over the current algorithm, which doesn't attempt to overlap any fields that are live across more than one yield in the generator. It also wouldn't force "overlap-zone" fields to always come after "non-overlap" fields, which means we can do a better job of eliminating padding. Finally, the logic should be easier to follow in code than the current optimization (once the data structure is written).
This problem is NP-complete, so there might be better algorithms than this out there. I'd love to hear suggestions!
---
(*) The number of conflicts is the number of other fields in this struct that cannot be overlapped with the current field. The exact heuristic may change. Today, we use number of conflicts to help us decide which fields get to stay in an "overlap zone" and which get kicked out. Then, we use order of alignment to lay out the fields in each zone. | C-enhancement,T-compiler,A-coroutines,I-heavy,C-optimization | low | Major |
466,603,662 | flutter | Remove FlutterBinaryMessenger implementation from FlutterViewController | It's left in there for now to help with the migration away from FlutterViewController publicly being a FlutterBinaryMessenger. Unfortunately if you don't have Werror turned on the change just shows up as a warning. We should have a grace period before we remove it. | team,engine,P2,team-engine,triaged-engine | low | Critical |
466,607,608 | node | There appears to be a bug with the http2 header decoding | <!--
Thank you for reporting a possible bug in Node.js.
Please fill in as much of the template below as you can.
Version: output of `node -v`
Platform: output of `uname -a` (UNIX), or version and 32 or 64-bit (Windows)
Subsystem: if known, please specify the affected core module name
If possible, please provide code that demonstrates the problem, keeping it as
simple and free of external dependencies as you can.
-->
* **Version**: 10.15.3
* **Platform**: node: 10-alpine official docker image
* **Subsystem**: http2
<!-- Please provide more details below this comment. -->
This comes from googleapis/nodejs-datastore#415. It looks like occasionally http2 headers objects are being provided from the `http2` module with invalid and clearly incorrect header keys. For example, some bad headers objects look like these
```
[Object: null prototype] {
':status': 200,
'content-disposition': 'attachment',
'content-type': 'application/grpc',
' pΓΈ0': 'Wed, 10 Jul 2019 23:39:46 GMT',
'alt-svc': 'quic=":443"; ma=2592000; v="46,43,39"'
}
[Object: null prototype] {
':status': 200,
'content-disposition': 'attachment',
'content-type': 'application/grpc',
'A\u0000\u0000\u0000': 'Wed, 10 Jul 2019 22:37:34 GMT',
'alt-svc': 'quic=":443"; ma=2592000; v="46,43,39"'
}
[Object: null prototype] {
':status': 200,
'content-disposition': 'attachment',
'content-type': 'application/grpc',
' ΓΓJ': 'Wed, 10 Jul 2019 23:58:43 GMT',
'alt-svc': 'quic=":443"; ma=2592000; v="46,43,39"'
}
```
while valid headers look like this:
```
[Object: null prototype] {
':status': 200,
'content-disposition': 'attachment',
'content-type': 'application/grpc',
date: 'Wed, 10 Jul 2019 23:05:02 GMT',
'alt-svc': 'quic=":443"; ma=2592000; v="46,43,39"'
}
```
In all of the cases we have seen, it looks like the `date` key is replace with this garbled nonsense. My guess is that it is relevant that that header is the one most likely to be encoded in the format [Literal Header Field Never Indexed β Indexed Name](https://http2.github.io/http2-spec/compression.html#rfc.section.6.2.3) because the value changes with every request. | help wanted,http2 | medium | Critical |
466,628,333 | rust | "Cycle computing supertraits" error could be more helpful | Consider the following code:
```rust
trait Foo<F> {}
trait Bar: Foo<Self::F> {
type F;
}
```
Trying to compile it, we get the following error:
```text
error[E0391]: cycle detected when computing the supertraits of `Bar`
--> src/lib.rs:3:1
|
3 | trait Bar: Foo<Self::F> {
| ^^^^^^^^^^^^^^^^^^^^^^^
|
= note: ...which again requires computing the supertraits of `Bar`, completing the cycle
note: cycle used when collecting item types in top-level module
--> src/lib.rs:3:1
|
3 | trait Bar: Foo<Self::F> {
| ^^^^^^^^^^^^^^^^^^^^^^^
```
To most programmers, this just looks like Rust won't let you have a trait bound which depends on an associated type in the trait being defined. That's what I thought for a long time. But that's not actually true - what's actually going on is that in order to figure out which `F` is being referred to in `Self::F`, the supertraits need to be computed. If we help the compiler out by disambiguating which `F` we mean, the error goes away:
```rust
trait Foo<F> {}
trait Bar: Foo<<Self as Bar>::F> {
type F;
}
```
I suggest that we improve the error message in this case to suggest disambiguating any associated types in trait bounds in order to steer users towards this solution.
<!-- TRIAGEBOT_START -->
<!-- TRIAGEBOT_ASSIGN_START -->
<!-- TRIAGEBOT_ASSIGN_DATA_START$${"user":"naiveai"}$$TRIAGEBOT_ASSIGN_DATA_END -->
<!-- TRIAGEBOT_ASSIGN_END -->
<!-- TRIAGEBOT_END --> | C-enhancement,A-diagnostics,A-trait-system,T-compiler | low | Critical |
466,641,810 | material-ui | When customizing breakpoints with createMuiTheme, only a shallow merged value is created | When customizing breakpoints with createMuiTheme, only a shallow merged value is created
- [x] This is not a v0.x issue. <!-- (v0.x is no longer maintained) -->
- [x] I have searched the [issues](https://github.com/mui-org/material-ui/issues) of this repository and believe that this is not a duplicate.
## Expected Behavior π€
When providing a customized theme object, `createMuiTheme` should deep merge it.
## Current Behavior π―
`createMuiTheme` only shallow merges `breakpoints.value`.
## Steps to Reproduce πΉ
Link: https://codesandbox.io/s/jovial-thunder-hgw6u
## Context π¦
I am sure this is not new in v4 - not sure if this is the intended behaviour, however, when I tried to custom breakpoints by providing a customized theme object to `createMuiTheme` like this:
```
const theme = createMuiTheme({
breakpoints: {
values: {
lg: 1500,
xl: 1300
}
}
});
```
I thought `createMuiTheme` will deep merge the customized theme object with the default values so I thought for the rest of the keys not provided it will fallback to use the default values of:
```
{
xs: 0,
sm: 600,
md: 960
}
```
However I bumped into some bugs and after digging into the source code, I found out that when [`createMuiTheme` calls `createBreakpoints` ](https://github.com/mui-org/material-ui/blob/master/packages/material-ui/src/styles/createBreakpoints.js#L19) it overrides the `value` key inside `breakpoints` completely without merging the respective values.
Therefore, when the display size falls in an undefined value, the withWidth HOC returns some invalid value as well, thus breaking some features relying on `withWidth` such as `<Hidden />`.
Is a deep merge for `createBreakpoints` not implemented due to performance issues? If so, maybe it will be a good idea to document it better, instead of saying
because
> Takes an incomplete theme object and adds the missing parts.
sounds like a deep merge of all keys to me. On top of that the implementation details inside `createMuiTheme` indeed [deepmerge some keys](https://github.com/mui-org/material-ui/blob/master/packages/material-ui/src/styles/createMuiTheme.js#L39), which makes it more confusing.
## Your Environment π
| Tech | Version |
|--------------|---------|
| Material-UI | v4.1.3 |
| React | v16.8.6 |
| new feature,package: material-ui | low | Critical |
466,697,175 | flutter | dependencies cost indicator | ## Use case
When I add a dependency I don't know how much of size it will add to my project
## Proposal
When I run flutter packages get I want to get these packages cost
For example Flutter web it will show to me js cost 14kb
For Flutter Android it will show to me 100kb the total of the package aar, jar, images, java files, and the total size after compiling.
I think it could be by some simple scripts to each platform
| c: new feature,tool,c: performance,a: size,customer: hand,perf: app size,P3,team-tool,triaged-tool | medium | Major |
466,816,419 | TypeScript | "Move to new file" breaks implicit index imports | <!-- π¨ STOP π¨ π¦π§π’π£ π¨ πΊπ»πΆπ· π¨
Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Even if you think you've found a *bug*, please read the FAQ first, especially the Common "Bugs" That Aren't Bugs section!
Please help us by doing the following steps before logging an issue:
* Search: https://github.com/Microsoft/TypeScript/search?type=Issues
* Read the FAQ: https://github.com/Microsoft/TypeScript/wiki/FAQ
Please fill in the *entire* template below.
-->
<!-- Please try to reproduce the issue with `typescript@next`. It may have already been fixed. -->
**TypeScript Version:** 3.5.2
<!-- Search terms you tried before logging this (so others can find this issue more easily) -->
**Search Terms:**
**Code**
```ts
// main.ts
import Component from './Component';
Component;
```
``` ts
// Component/index.ts
const Component = () => { };
export default Component;
```
Now highlight all code in `Component/index.ts`, and select "move to new file".
**Expected behavior:**
- New file `Component/Component.ts` is created
- Import in `main.ts` should still work
In order for the import to still work, TS should do either of the following (IMO):
- `Component/index.ts` re-exports the exports of the new file, so that the import in `main.ts` will work
``` ts
// Component/index.ts
export { default } from './Component';
```
- or, `Component/index.ts` is left empty, and the import in `main.ts` is updated
``` ts
// main.ts
import Component from './Component/Component';
Component;
```
**Actual behavior:**
- New file `Component/Component.ts` is created
- Import in `main.ts` is broken
**Playground Link:** <!-- A link to a TypeScript Playground "Share" link which demonstrates this behavior -->
**Related Issues:** <!-- Did you find other bugs that looked similar? -->
| Bug,Domain: Refactorings | low | Critical |
466,882,451 | rust | improve documentation for AsRef/AsMut | `AsRef`/`AsMut` is fairly common source of changes that result in breaking others' code. Most such changes occur by adding additional `AsRef`/`AsMut` impls, which in turn break type inference that users are unwittingly relying on. According to [Rust's API evolution](https://rust-lang.github.io/rfcs/1105-api-evolution.html), this is, strictly speaking, allowable breakage.
Almost all such instances of code breakage correspond to a _misuse_ of `AsRef`/`AsMut`, by using it situations where there are no constraints to help type inference. Idiomatic use of these traits is typically by specifying them in a context where the target type is known. For example:
```rust
fn foo<T: AsMut<[u8]>>(something: T) {
// this will never fail, because the target type is unambiguous
let my_mutable_slice = something.as_mut();
// ...
}
```
Code like this is robust with respect to additional implementations of `AsMut`.
This issue is about improving the documentation of [`AsRef`](https://doc.rust-lang.org/std/convert/trait.AsRef.html)/[`AsMut`](https://doc.rust-lang.org/std/convert/trait.AsMut.html) to cover these important caveats. Currently, the docs include no mention of what incorrect usage actually is, or the fact that incorrectly using this trait can result in a new Rust compiler failing to compiler your code. (There is an example of correct usage, but no broader discussion of the intricacies of using this trait.) Additionally, the docs, IMO, don't do a good enough job differentiating `AsRef` from `Borrow`. The docs mention some specific differences, but don't cover high level concerns. It's very difficult, even for me, to take the noted differences in the docs and extrapolate that to a heuristic for when I should prefer one over the other.
This issue is motivated by the fallout from #60958, and my own recent experience in dealing with this in https://github.com/BurntSushi/rust-csv/issues/160 (which is particularly subtle). | C-enhancement,T-libs-api,A-docs | low | Major |
466,898,812 | vscode | Have a command that clears all problems that are from tasks. | When a user makes a change to a task and re-runs it, they could end up accumulating problems since the modified task counts as a new task.
One idea is to clear all problems when the task config changes: https://github.com/microsoft/vscode/issues/76108
But that seems too aggressive and we'd be removing problems without telling the user why.
Instead, having a command to clear the task problems is clearer. | feature-request,tasks,polish | medium | Major |
466,899,536 | vscode | Git - Support for gitdir | I use two git repositories within project folder - one is `.git` and second is `.git_dev`. First is for project and second is to track my local config files. I used to work with second via alias `git dev` which stands for `git --git-dir=.git_dev`, but for now I explore ways to list changes within both repos in git sideview.
What I did:
1. I create folder aside the main project folder(consider it `project`) and call it `project_dev`
2. Initialize new repo in new folder with `git init --separate-git-dir ../project/.git_dev`. It creates file `project_dev/.git` with related line.
3. Then create new file within `project_dev` folder and open it in Code. Now I'm able to view changes for both repos, but one called `project_dev` tracks the `project_dev` folder, not the `project`
4. So my next step is to add setting `worktree=/path/to/project` in `.git_dev/cofig`. Now git sideview perfectly represents current changes for `project_dev` aside to main `project`.
And here I run into two issues:
1. if I try to click on changed file in `project_dev` section of sideview, an error occurs with message: `Unable to open 'filename (Working Tree)': Unable to read file (Error: File not found (/path/to/project_dev/filename)).` like it doen't respect setting `worktree` at all.
2. If I reload Code, even if I open file from `project_dev` folder, second repo is not shown. If I remove `worktree` setting, `project_dev` repo is shown again and I have to add `worktree` setting again to get changes properly.
Example repo:
https://github.com/deitry/vscode-two-git-repos-issues
---
So, on the one hand I consider current behaviour as buggy. On the other hand, I make a request to add option to pass as many `--git-dir`s as I want by making it a list:
```
"git.gitdirs: [ ".git", ".git_dev"]
``` | help wanted,feature-request,git | medium | Critical |
466,920,285 | kubernetes | Node VM failure doesn't automatically recreate a pod with attached PV | <!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks!
If the matter is security related, please disclose it privately via https://kubernetes.io/security/
-->
**What happened**:
After a deployment is created with PVC, a node hosting the pod shuts down. After 6 mins timeout, the replacement/new pod is created but cannot come up since the volume is attached to a terminating pod on a shutdown node. To work around this, the volume would be detached from the original pod when it's force deleted.
**What you expected to happen**:
According to the Node VM Failure scenario at https://vmware.github.io/vsphere-storage-for-kubernetes/documentation/high-availability.html, the recovery mechanism is completely automatic. In reality, it requires manual intervention to force delete a pod.
**How to reproduce it (as minimally and precisely as possible)**:
**Anything else we need to know?**:
**Environment**:
- Kubernetes version (use `kubectl version`): v1.12.7-gke.19
- Cloud provider or hardware configuration: vSphere Cloud Provider
- OS (e.g: `cat /etc/os-release`):
- Kernel (e.g. `uname -a`):
- Install tools:
- Network plugin and version (if this is a network-related bug):
- Others:
/sig vmware | kind/bug,priority/important-soon,lifecycle/frozen,area/provider/vmware,sig/cloud-provider | medium | Critical |
466,927,256 | godot | Github CodeQL Support | <!-- Please search existing issues for potential duplicates before filing yours:
https://github.com/godotengine/godot/issues?q=is%3Aissue
-->
**Godot version:**
<!-- Specify commit hash if non-official. -->
Any
**OS/device including version:**
<!-- Specify GPU model and drivers if graphics-related. -->
Any
**Issue description:**
<!-- What happened, and what was expected. -->
https://lgtm.com/projects/g/godotengine/godot/overview/
Shows some errors and warnings. It would be good if Godot had LGTM alert count icon too with AppVeyer, Travis, Triage and Weblate in README.
Ready to close this issue if it seems useless, irrelevant, duplicate or previously discussed.
**Steps to reproduce:**
Visit the links, checkout the errors and warnings.
**Minimal reproduction project:**
<!-- Recommended as it greatly speeds up debugging. Drag and drop a zip archive to upload it. -->
| enhancement,usability,topic:thirdparty | low | Critical |
466,933,549 | rust | Inconsistent `#[link(name = "")]` resolution on Windows | <!-- Thanks for filing a π bug report π! -->
**Background**
We have a Rust project (lets call it `dylib`) where we want to produce a shared library (.dll, .dylib, .so) for various platforms. As part of the build process we also want to verify the provided headers match the library.
To do that we have a separate project `dylib_test`, where we extract C doc tests into individual `generated_nnn.c` files, produce a `generated.rs` file that knows all C tests, and emits a `#[test]` for each, which we then want to run with `cargo test`.
The `dylib` project should only emit a `cdylib`, and the `dylib_test` should only link against that `cdylib`, to make sure the actual .dll, ... works.
**Problem**
When linking against `dylib` from the `dylib_test` crate, the `#[link(name = "dylib")]` attribute behaves inconsistently. On Mac and Linux the attribute works. On Windows, it fails with an
```
error: linking with `link.exe` failed: exit code: 1181
|
= note: "C:\\Program Files (x86)\\Microsoft Visual Studio\\2019\\BuildTools\\VC\\Tools\\MSVC\\14.21.27702\\bin\\HostX64\\x64\\link.exe" "/NOLOGO" "/NXCOMPAT" "/LIBPATH:C:\\Users\\rb\\.rustup\\toolchains\\nightly-2019-07-08-x86_64-pc-windows-msvc\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib" "D:\\Development\\Source\\rust_issues\\target\\debug\\deps\\dylib_test-16b85ad62e2643c4.17sc3p6xub1nskk5.rcgu.o" "D:\\Development\\Source\\rust_issues\\target\\debug\\deps\\dylib_test-16b85ad62e2643c4.1d4yl2ra8f02uq65.rcgu.o" "D:\\Development\\Source\\rust_issues\\target\\debug\\deps\\dylib_test-16b85ad62e2643c4.2boci68ky9pbilmt.rcgu.o" "D:\\Development\\Source\\rust_issues\\target\\debug\\deps\\dylib_test-16b85ad62e2643c4.2kg3da7ad2y6u5t4.rcgu.o" "D:\\Development\\Source\\rust_issues\\target\\debug\\deps\\dylib_test-16b85ad62e2643c4.328elmwbbr69laus.rcgu.o" "D:\\Development\\Source\\rust_issues\\target\\debug\\deps\\dylib_test-16b85ad62e2643c4.3pjpoaqleh1qku54.rcgu.o" "D:\\Development\\Source\\rust_issues\\target\\debug\\deps\\dylib_test-16b85ad62e2643c4.48cxjx0647kyqroa.rcgu.o" "D:\\Development\\Source\\rust_issues\\target\\debug\\deps\\dylib_test-16b85ad62e2643c4.4xn06m0s17xpy7q7.rcgu.o" "D:\\Development\\Source\\rust_issues\\target\\debug\\deps\\dylib_test-16b85ad62e2643c4.bdw34kj2m6ietun.rcgu.o" "D:\\Development\\Source\\rust_issues\\target\\debug\\deps\\dylib_test-16b85ad62e2643c4.dxf6w5mo3hfjrm.rcgu.o" "/OUT:D:\\Development\\Source\\rust_issues\\target\\debug\\deps\\dylib_test-16b85ad62e2643c4.exe" "D:\\Development\\Source\\rust_issues\\target\\debug\\deps\\dylib_test-16b85ad62e2643c4.3tou2046e23p3ckg.rcgu.o" "/OPT:REF,NOICF" "/DEBUG" "/NATVIS:C:\\Users\\rb\\.rustup\\toolchains\\nightly-2019-07-08-x86_64-pc-windows-msvc\\lib\\rustlib\\etc\\intrinsic.natvis" "/NATVIS:C:\\Users\\rb\\.rustup\\toolchains\\nightly-2019-07-08-x86_64-pc-windows-msvc\\lib\\rustlib\\etc\\liballoc.natvis" "/NATVIS:C:\\Users\\rb\\.rustup\\toolchains\\nightly-2019-07-08-x86_64-pc-windows-msvc\\lib\\rustlib\\etc\\libcore.natvis" "/LIBPATH:D:\\Development\\Source\\rust_issues\\target\\debug\\deps" "/LIBPATH:D:\\Development\\Source\\rust_issues\\target\\debug\\build\\dylib_test-df967a17b396e952\\out" "/LIBPATH:C:\\Users\\rb\\.rustup\\toolchains\\nightly-2019-07-08-x86_64-pc-windows-msvc\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib" "dylib.lib" "test_harness.lib" "C:\\Users\\rb\\.rustup\\toolchains\\nightly-2019-07-08-x86_64-pc-windows-msvc\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib\\libtest-5868cd1efdb1a14a.rlib" "C:\\Users\\rb\\.rustup\\toolchains\\nightly-2019-07-08-x86_64-pc-windows-msvc\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib\\libterm-4a1cd4f9337faede.rlib" "C:\\Users\\rb\\.rustup\\toolchains\\nightly-2019-07-08-x86_64-pc-windows-msvc\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib\\libgetopts-c94244661cc3c49c.rlib" "C:\\Users\\rb\\.rustup\\toolchains\\nightly-2019-07-08-x86_64-pc-windows-msvc\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib\\libunicode_width-5d83c260a3fd1c81.rlib" "C:\\Users\\rb\\.rustup\\toolchains\\nightly-2019-07-08-x86_64-pc-windows-msvc\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib\\libstd-69ffdb8026c42481.rlib" "C:\\Users\\rb\\.rustup\\toolchains\\nightly-2019-07-08-x86_64-pc-windows-msvc\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib\\libpanic_unwind-324700ef1bcafc8b.rlib" "C:\\Users\\rb\\.rustup\\toolchains\\nightly-2019-07-08-x86_64-pc-windows-msvc\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib\\libbacktrace-66fccb33cfc77b7d.rlib" "C:\\Users\\rb\\.rustup\\toolchains\\nightly-2019-07-08-x86_64-pc-windows-msvc\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib\\librustc_demangle-429461051376b1a5.rlib" "C:\\Users\\rb\\.rustup\\toolchains\\nightly-2019-07-08-x86_64-pc-windows-msvc\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib\\libhashbrown-16c7dc58d869d64a.rlib" "C:\\Users\\rb\\.rustup\\toolchains\\nightly-2019-07-08-x86_64-pc-windows-msvc\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib\\librustc_std_workspace_alloc-b5f6113de773ee4b.rlib" "C:\\Users\\rb\\.rustup\\toolchains\\nightly-2019-07-08-x86_64-pc-windows-msvc\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib\\libunwind-52ee0b65e04bcb17.rlib" "C:\\Users\\rb\\.rustup\\toolchains\\nightly-2019-07-08-x86_64-pc-windows-msvc\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib\\libcfg_if-eee1f1d0cc78c8f9.rlib" "C:\\Users\\rb\\.rustup\\toolchains\\nightly-2019-07-08-x86_64-pc-windows-msvc\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib\\liblibc-f5bd27a471d11e8c.rlib" "C:\\Users\\rb\\.rustup\\toolchains\\nightly-2019-07-08-x86_64-pc-windows-msvc\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib\\liballoc-bb531cfdfdeadec5.rlib" "C:\\Users\\rb\\.rustup\\toolchains\\nightly-2019-07-08-x86_64-pc-windows-msvc\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib\\librustc_std_workspace_core-48d94702399abeaa.rlib" "C:\\Users\\rb\\.rustup\\toolchains\\nightly-2019-07-08-x86_64-pc-windows-msvc\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib\\libcore-edaeab1200806e65.rlib" "C:\\Users\\rb\\.rustup\\toolchains\\nightly-2019-07-08-x86_64-pc-windows-msvc\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib\\libcompiler_builtins-5cb137db32dc726e.rlib" "kernel32.lib" "advapi32.lib" "ws2_32.lib" "userenv.lib" "msvcrt.lib"
= note: LINK : fatal error LNK1181: cannot open input file 'dylib.lib'
```
I believe this is because Rust on Windows produces a `dylib.dll` and `dylib.dll.lib` (instead of a `dylib.lib`). When then resolving the library Rust apparently isn't aware that to resolve `name="dylib"` it should not only look for the (`dylib.lib`, `dylib.dll`) pair, but instead also for the (`dylib.dll.lib`, `dylib.dll`) pair.
**Steps**
1. Clone https://github.com/ralfbiedert/rust_issues/tree/dylib_issues
2. Run `cargo test` (on Windows)
**Possible Solution(s)**
When given a `#[link(name = "dylib")]`, consider to look for `dylib.dll.lib` on Windows.
The current workaround is to specify `#[link(name = "dylib.dll")]`, but from a cross-platform perspective that feels inconsistent.
**Notes**
Output of `cargo version`:
<!-- Also, any additional context or information you feel may be relevant to the issue. -->
<!-- (e.g rust version, OS platform/distribution/version, target toolchain(s), release channel.. -->
`cargo 1.37.0-nightly (4c1fa54d1 2019-06-24)`
`rustc 1.38.0-nightly (6e310f2ab 2019-07-07)`
`x86_64-pc-windows-msvc` | O-windows-msvc | low | Critical |
466,964,084 | react-native | TextInput prevent scroll on ScrollView | In a too long form, scroll is only available if the touch start outside the `TextInput` fields
React Native version:
```
info Fetching system and libraries information...
System:
OS: Linux 4.15 Ubuntu 18.04.2 LTS (Bionic Beaver)
CPU: (4) x64 Intel(R) Core(TM) i7-6500U CPU @ 2.50GHz
Memory: 1.92 GB / 7.67 GB
Shell: 5.4.2 - /usr/bin/zsh
Binaries:
Node: 8.10.0 - /usr/bin/node
npm: 3.5.2 - /usr/bin/npm
SDKs:
Android SDK:
API Levels: 22, 23, 26, 27, 28
Build Tools: 23.0.1, 27.0.3, 28.0.3
System Images: android-27 | Google APIs Intel x86 Atom, android-28 | Google APIs Intel x86 Atom
npmPackages:
react: 16.8.6 => 16.8.6
react-native: 0.60.0 => 0.60.0
npmGlobalPackages:
react-native-cli: 2.0.1
react-native-debugger: 1.1.0
react-native: 0.59.3
```
## Steps To Reproduce
1. create a ScrollView with `flex: 1`
2. put more TextInputs than your screen can handle
3. try to scroll with your touch starting on a field
Describe what you expected to happen:
I expect the page to scroll
Snack, code example, or link to a repository:
```
<ScrollView style={{ flex: 1, }}>
<TextInput placeholder="test" textAlign='center'/>
<TextInput placeholder="test" textAlign='center'/>
<TextInput placeholder="test" textAlign='center'/>
<TextInput placeholder="test" textAlign='center'/>
<TextInput placeholder="test" textAlign='center'/>
<View style={{ height: 150, }} />
<TextInput placeholder="test" textAlign='center'/>
<TextInput placeholder="test" textAlign='center'/>
<TextInput placeholder="test" textAlign='center'/>
<TextInput placeholder="test" textAlign='center'/>
</ScrollView>
```
snack: https://snack.expo.io/@aiiros/react-native-issue-25594
this is a duplicate of https://github.com/facebook/react-native/issues/15962 which has not yet been answered.
Edit:
Turns out `textAlign='center'` is causing all of this
| Component: TextInput,Platform: Linux,Component: ScrollView,Bug | high | Critical |
467,047,744 | pytorch | [RFC] InstanceNorm default affine value | TL;DR: the default `affine` value is different from the original paper and code, but is probably too old to change. Can we add a note in doc?
I happened to be looking through the original paper on [Instance Normalization](https://arxiv.org/pdf/1701.02096.pdf) and the accompanied [code](https://github.com/DmitryUlyanov/texture_nets/blob/aad2cc6f8a998fedc77b64bdcfe1e2884aa0fb3e/InstanceNormalization.lua#L16-L20). Both seem to indicate that the affine transform should be on **by default**. E.g., quote from the paper:
> Another similarity with BN is that each IN layer is followed by a scaling and bias operator s x+b.
However, since the very beginning of `nn.InstanceNorm*d`'s existence ([this PR](https://github.com/pytorch/pytorch/pull/1283)), `affine=False` is the default.
Is it worthwhile to add a `.. note::` to the doc about this behavior?
Also, cc @DmitryUlyanov , who is the first author of the paper, owner of the original lua code, and the contributor of the PyTorch module. | module: docs,triaged | low | Minor |
467,069,885 | create-react-app | Request for more a-priori documentation for progressive web apps. | ### Is your proposal related to a problem?
It's difficult to gauge the benefit of how and what enabling a service worker will do to an application. For example, my react app that I'm building is looking to be a mobile progressive web app to get the impression of a regular browser app. The app is powered by a backend that is served via a reverse proxy. One feature of the app, a contact list, ideally will front-load all contacts ahead of time, and periodically sync them, allowing the app to be used offline to a certain capacity.
What's particularly difficult here is trying to figure out exactly what happens when a service worker is registered. Are my reverse proxy http requests captured in the traffic? Should I concern myself with building a solution that uses local storage or indexedDB as part of the overall design, or will it be covered by the service worker? How will a scrolling component that lazily loads elements behave if the user hasn't scrolled all the way 'to the bottom' and their app is offline?
It is difficult to answer these questions without having a good understanding of what create-react-app is doing here. After a bit of digging, I found that workbox is used. I've done quite a bit of research on progressive web apps in general; some of the issues that come up; the tooling that is provided by chrome's developer tools.
### Describe the solution you'd like
What I would like to see is a more comprehensive look at what is happening underneath the hood without having to dig around in every nook and cranny in the ecosystem. Particularly, it is difficult because many of the search results involve outdated examples or ejecting the app, which has long-term ramifications on the direction that a create-web-app project goes.
### Describe alternatives you've considered
As I'm in an evaluation period, I'm looking more for information. Ejecting the application and trying to sew technology together manually is currently the only viable-looking alternative. Which is fine, but not preferable. Having the information available to help make an educated and informed decision on whether or not the this is right to me is what's at question here.
Thanks for your time! | issue: proposal | low | Minor |
467,077,718 | rust | Barely noticeable compiler suggestion | ```
fn main() {
let new_service = {
hyper::service::service_fn_ok(unimplemented!())
};
hyper::Server::bind(unimplemented!())
.serve(new_service);
}
```
Compiler error:
```
error[E0277]: expected a `std::ops::Fn<()>` closure, found `hyper::service::service::ServiceFnOk<_, _>`
--> src/main.rs:6:10
|
6 | .serve(new_service);
| ^^^^^ expected an `Fn<()>` closure, found `hyper::service::service::ServiceFnOk<_, _>`
|
= help: the trait `std::ops::Fn<()>` is not implemented for `hyper::service::service::ServiceFnOk<_, _>`
= note: wrap the `hyper::service::service::ServiceFnOk<_, _>` in a closure with no arguments: `|| { /* code */ }
= note: required because of the requirements on the impl of `hyper::service::new_service::NewService` for `hyper::service::service::ServiceFnOk<_, _>`
= note: required because of the requirements on the impl of `hyper::service::make_service::MakeServiceRef<hyper::server::tcp::addr_stream::AddrStream>` for `hyper::service::service::ServiceFnOk<_, _>`
```
I think it's better to improve this note
```
= note: wrap the `hyper::service::service::ServiceFnOk<_, _>` in a closure with no arguments: `|| { /* code */ }
```
So it's more noticeable and readable.
[Playground link](https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=7384234185f560e9c2e27f9566918f57) | C-enhancement,A-diagnostics,T-compiler,A-suggestion-diagnostics,F-on_unimplemented | low | Critical |
467,108,218 | pytorch | assert_no_internal_overlap should pass const char* | Followup to #22729. Quoting @colesbury:
> For older versions of GCC (4.9), const char* is better since otherwise GCC will still construct a std::string for every call. (We ship OSS binaries using GCC 4.9)
https://gcc.godbolt.org/z/0NQtCC | module: internals,triaged | low | Minor |
467,114,399 | rust | warn on running benchmarks in debug mode | libtest-generated benchmark code should issue a warning when benching code that was compiled in debug mode, as this is likely not the intended outcome. At worst the user will be like "gee thanks, Rust, I already know", but at best it will save a lot of time.
## How to reproduce
* Create a benchmark
* Compile with `rustc --test my_benchmark.rs`
* Run with `./my_benchmark --bench`
## Desired outcome
Before the benchmark runs, it should issue a note saying "This benchmark was compiled in debug mode.".
## Actual outcome
No such note is issued. | A-lints,T-compiler,C-feature-request,A-libtest | low | Critical |
467,134,592 | flutter | Document how to write UI tests that interact with native UI elements | Since markers aren't widgets, what is the recommended way to write a widget test which taps a map marker and ensures that the onTap is executed? I didn't see any marker onTap tests in the google maps plugin tests π
Thanks! | a: tests,d: api docs,customer: crowd,p: maps,package,customer: vroom,team-ecosystem,P3,triaged-ecosystem | medium | Critical |
467,139,227 | angular | Animation using query and stagger doesn't properly animate from height: '*' | # π bug report
### Affected Package
<!-- Can you pin-point one or more @angular/* packages as the source of the bug? -->
@angular/animations: 8.1.1
### Is this a regression?
<!-- Did this behavior use to work in the previous version? -->
I'm not sure.
### Description
When attempting to use an animation query with a stagger to animate from an unknown height `height: '*'`, the animation does not work. It works fine when animating from a known height to an unknown height though.
For example, this works correctly:
```
animations: [
trigger('expandCollapse', [
transition('false => true', [
query('.category', [
style({ height: 0 })
]),
query('.category', stagger('150ms', [
animate(
'600ms cubic-bezier(0.25, 0.8, 0.25, 1)',
style({ height: '*' })
)
]), { optional: true })
])
])
```
But this does not:
```
animations: [
trigger('expandCollapse', [
transition('true => false', [
query('.category', stagger('-150ms', [
style({ height: '*' }),
animate(
'600ms cubic-bezier(0.25, 0.8, 0.25, 1)',
style({ height: 0 })
)
]), { optional: true })
])
])
```
## π¬ Minimal Reproduction
https://stackblitz.com/edit/angular-unknown-height-query-animation-bug?file=src/app/app.component.ts
In this example, if you click the "show" button you will see it animate to an unknown height just fine. But, once it's expanded and you click the "hide" button you will see that it doesn't properly animate from an unknown height back to zero.
| type: bug/fix,area: animations,freq2: medium,state: confirmed,P3 | low | Critical |
467,143,446 | pytorch | In-place updating the original value tensor should also update version counter of sparse tensor's values_ tensor | Currently, in-place updating the original value tensor after it's been used to construct a sparse tensor doesn't update version counter of the sparse tensor's `values_` tensor. Consider the following example:
```python
ind = torch.tensor([[0],[1]]).add_(1).sub_(1)
values = torch.tensor([1.]).add_(1).add_(1).sub_(1).sub_(1)
c = torch.sparse_coo_tensor(ind, values).requires_grad_()
grad = torch.sparse_coo_tensor(ind.clone(), values.clone())
d = c.mul(c)
values.add_(1)
d.backward(grad) # This should have thrown an error saying there is version mismatch error for c
```
The reason is that we don't save the values tensor for backward in the sparse tensor constructor:
```cpp
Tensor VariableType::_sparse_coo_tensor_with_dims_and_tensors(int64_t sparse_dim, int64_t dense_dim, IntArrayRef size, const Tensor & indices, const Tensor & values, const TensorOptions & options) {
RECORD_FUNCTION("_sparse_coo_tensor_with_dims_and_tensors", std::vector<c10::IValue>({indices, values}), Function::peek_at_next_sequence_nr());
auto& indices_ = unpack(indices, "indices", 3);
auto& values_ = unpack(values, "values", 4);
auto options_ = TensorOptions(options).is_variable(false);
check_no_requires_grad(indices, "indices");
std::shared_ptr<SparseCooTensorWithDimsAndTensorsBackward> grad_fn;
if (compute_requires_grad( values )) {
grad_fn = std::shared_ptr<SparseCooTensorWithDimsAndTensorsBackward>(new SparseCooTensorWithDimsAndTensorsBackward(), deleteFunction);
grad_fn->set_next_edges(collect_next_edges( values ));
grad_fn->indices_ = SavedVariable(indices, false);
grad_fn->values_sizes = values.sizes().vec();
// We should also save `values` here
}
...
}
``` | module: sparse,module: autograd,triaged | low | Critical |
467,157,437 | TypeScript | JS Typedef merged with default export alias behaves strangely | <!-- π¨ STOP π¨ π¦π§π’π£ π¨ πΊπ»πΆπ· π¨
Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Even if you think you've found a *bug*, please read the FAQ first, especially the Common "Bugs" That Aren't Bugs section!
Please help us by doing the following steps before logging an issue:
* Search: https://github.com/Microsoft/TypeScript/search?type=Issues
* Read the FAQ: https://github.com/Microsoft/TypeScript/wiki/FAQ
Please fill in the *entire* template below.
-->
<!-- Please try to reproduce the issue with `typescript@next`. It may have already been fixed. -->
**TypeScript Version:** 3.4.0-dev.201xxxxx
<!-- Search terms you tried before logging this (so others can find this issue more easily) -->
**Search Terms:**
**Code**
in a TS file:
```ts
import Def from "./file.js"
type Q = Def;
console.log(Def);
```
with `file.js`:
```js
const x = 12;
export {x as default};
/**
* @typedef {string | number} default
*/
```
with `checkJs` and `allowJs` both on, the hover text for `Def` is surprisingly correct:
however the `console.log` is marked as an error, stating:
```
'Def' only refers to a type, but is being used as a value here.
```
**Expected behavior:**
Since the quickinfo shows it's clearly a value (and a value is, in fact, exported), the default import should be usable as a value.
**Actual behavior:**
The default import is not usable as a value without error.
cc @sandersn | Bug,Domain: JavaScript | low | Critical |
467,158,918 | TypeScript | JS typedef merged with default export class behaves strangely | <!-- π¨ STOP π¨ π¦π§π’π£ π¨ πΊπ»πΆπ· π¨
Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Even if you think you've found a *bug*, please read the FAQ first, especially the Common "Bugs" That Aren't Bugs section!
Please help us by doing the following steps before logging an issue:
* Search: https://github.com/Microsoft/TypeScript/search?type=Issues
* Read the FAQ: https://github.com/Microsoft/TypeScript/wiki/FAQ
Please fill in the *entire* template below.
-->
<!-- Please try to reproduce the issue with `typescript@next`. It may have already been fixed. -->
**TypeScript Version:** 3.4.0-dev.201xxxxx
<!-- Search terms you tried before logging this (so others can find this issue more easily) -->
**Search Terms:**
**Code**
```js
class Cls {
x = 12;
static y = "ok"
}
export default Cls;
/**
* @typedef {string | number} default
*/
```
with `checkJs` and `allowJs` on reports no errors, however on usage:
```ts
import Def from "./file.js"
type Q = Def;
console.log(Def);
```
the quick info is pretty comprehensive:
however the `type` usage is equal to `string | number` (okay, maybe that's reasonable, how are a typedef and a class even merging anyway), however there's an error on the value usage:
```
'Def' only refers to a type, but is being used as a value here
```
**Expected behavior:**
An error on the attempted merge (a class and a type alias should be overlapping in symbol flags domains) and for the value usage to resolve to the class, probably.
**Actual behavior:**
The incongruent behavior described above.
cc @sandersn | Bug,Domain: JavaScript | low | Critical |
467,159,931 | TypeScript | JS typedef merged with default modified class errors strangely | <!-- π¨ STOP π¨ π¦π§π’π£ π¨ πΊπ»πΆπ· π¨
Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Even if you think you've found a *bug*, please read the FAQ first, especially the Common "Bugs" That Aren't Bugs section!
Please help us by doing the following steps before logging an issue:
* Search: https://github.com/Microsoft/TypeScript/search?type=Issues
* Read the FAQ: https://github.com/Microsoft/TypeScript/wiki/FAQ
Please fill in the *entire* template below.
-->
<!-- Please try to reproduce the issue with `typescript@next`. It may have already been fixed. -->
**TypeScript Version:** 3.4.0-dev.201xxxxx
<!-- Search terms you tried before logging this (so others can find this issue more easily) -->
**Search Terms:**
**Code**
```js
export default class C {};
/**
* @typedef {string | number} default
*/
```
**Expected behavior:**
An coherent error on attempting to merge a class and a typedef.
**Actual behavior:**
```
Duplicate identifier 'default'.
```
and
```
Duplicate identifier 'C'.
```
on the `default` type alias and class `C`, respectively.
cc @sandersn
| Bug,Domain: Error Messages,Domain: JavaScript | low | Critical |
467,185,744 | pytorch | Getting cuda runtime error (48) with Jetson TX2 when running simple program | ## β Questions and Help
### Please note that this issue tracker is not a help form and this issue will be closed.
We have a set of [listed resources available on the website](https://pytorch.org/resources). Our primary means of support is our discussion forum:
- [Discussion Forum](https://discuss.pytorch.org/)
When running in Jetson TX2 this simple code:
```python
import torch
dev = torch.device("cuda") if torch.cuda.is_available() else torch.device("cpu")
input1 = torch.rand(20, 20, 3).to(dev)
print(input1)
```
I'm getting this output:
```
THCudaCheck FAIL file=/home/nvidia/pytorch/aten/src/THC/generic/THCTensorMath.cu line=238 error=48 : no kernel image is available for execution on the device
Traceback (most recent call last):
File "test_cuda_working.py", line 8, in <module>
print(input1)
File "/usr/local/lib/python2.7/dist-packages/torch/tensor.py", line 63, in __repr__
return torch._tensor_str._str(self).encode(
File "/usr/local/lib/python2.7/dist-packages/torch/_tensor_str.py", line 286, in _str
tensor_str = _tensor_str(self, indent)
File "/usr/local/lib/python2.7/dist-packages/torch/_tensor_str.py", line 204, in _tensor_str
formatter = _Formatter(get_summarized_data(self) if summarize else self)
File "/usr/local/lib/python2.7/dist-packages/torch/_tensor_str.py", line 234, in get_summarized_data
start = [get_summarized_data(self[i]).reshape(-1) for i in range(0, PRINT_OPTS.edgeitems)]
File "/usr/local/lib/python2.7/dist-packages/torch/_tensor_str.py", line 237, in get_summarized_data
return torch.cat((start + end))
RuntimeError: cuda runtime error (48) : no kernel image is available for execution on the device at /home/nvidia/pytorch/aten/src/THC/generic/THCTensorMath.cu:238
```
If I change the code to:
```python
import torch
dev = torch.device("cuda") if torch.cuda.is_available() else torch.device("cpu")
input1 = torch.rand(18, 18, 3).to(dev)
print(input1)
```
It runs perfectly using cuda. Does anyone have an idea why this is happening? | module: cuda,triaged | low | Critical |
467,223,439 | vue | v-bind not update dom in client side when data in client side is different from the server side | ### Version
2.6.10
### Reproduction link
[https://github.com/maunier/nuxt-learning](https://github.com/maunier/nuxt-learning)
### Steps to reproduce
npm install
npm run dev
http://127.0.0.1:8080/
### What is expected?
i expect the div is like this:
```
<div text="isClient">isClient</div>
```
### What is actually happening?
but now it is:
```
<div text="isServer">isClient</div>
```
---
it is not Nuxt's issue, I have tested in my own vue-ssr server without Nuxt, the problem is exsist still. but the that project is not on the github, so i paste the nuxt project's link here
the core code is like this:
```
<div :text="text">{{ text }}</div>
```
```
data () {
return {
text: ''
}
},
created () {
this.text = Vue.prototype.$isServer ? 'isServer' : 'isClient'
},
```
<!-- generated by vue-issues. DO NOT REMOVE --> | bug,has workaround | low | Minor |
467,234,635 | pytorch | Pytorch deadlock from distributed multiprocessing | ## π Bug
Pytorch hangs indefinitely when using distributed multiprocessing with Pytorch 1.1.0 after 77k iterations (77939 and 77940 iterations). In Pytorch 1.0.1.post2, there is no such bug.
It appears to be deadlock.
The following distributed modules combine together in a very nasty way for some reason:
```
import torch.distributed as dist
train_sampler = torch.utils.data.distributed.DistributedSampler(train_data)
dist.init_process_group(backend=args.dist_backend, init_method=args.dist_url, world_size=args.world_size, rank=args.rank)
apex.parallel.DistributedDataParallel(model)
model, optimizer = apex.amp.initialize(model.cuda(), optimizer, opt_level=args.opt_level, keep_batchnorm_fp32=args.keep_batchnorm_fp32, loss_scale=args.loss_scale)
model = apex.parallel.DistributedDataParallel(model)
```
## To Reproduce
Steps to reproduce the behavior:
1. Clone the following repo: [semseg](https://github.com/hszhao/semseg)
2. Use the following config:
3. Run the training script [train.py](https://github.com/hszhao/semseg/blob/master/tool/train.py)
4. Observe that Pytorch will hang indefinitely after the 77,939th iteration.
## Expected behavior
Pytorch should not hang.
## Environment
PyTorch version: 1.1.0
Is debug build: No
CUDA used to build PyTorch: 10.0.130
OS: Ubuntu 18.04.2 LTS
GCC version: (Ubuntu 7.4.0-1ubuntu1~18.04.1) 7.4.0
CMake version: version 3.10.2
Python version: 3.6
Is CUDA available: No
CUDA runtime version: 10.0.130
GPU models and configuration: many
Nvidia driver version:
cuDNN version:
Versions of relevant libraries:
[pip] numpy==1.16.3
[pip] torch==1.1.0
[pip] torchvision==0.3.0
[conda] blas 1.0 mkl
[conda] mkl 2019.3 199
[conda] mkl_fft 1.0.12 py36ha843d7b_0
[conda] mkl_random 1.0.2 py36hd81dba3_0
[conda] pytorch 1.1.0 py3.6_cuda10.0.130_cudnn7.5.1_0 pytorch
[conda] torchvision 0.3.0 py36_cu10.0.130_1 pytorch
## Additional context
Reproduced by multiple users, on multiple GPUs. | oncall: distributed,triaged | low | Critical |
467,254,312 | godot | is_visibility_in_tree() parenting issue with Spatial and CanvasItem | <!-- Please search existing issues for potential duplicates before filing yours:
https://github.com/godotengine/godot/issues?q=is%3Aissue
-->
Further discussion of #22373 and extending to cover Spatial as well.
**Godot version:**
<!-- Specify commit hash if non-official. -->
Current master b6c10c2
**Issue description:**
<!-- What happened, and what was expected. -->
Calling is_visible_in_tree() fails to detect visibility changes higher up in the tree for spatials and canvas items if a parent is a different type (i.e. not derived from the corresponding type).
In the case of spatials data.parent is set to NULL, when the parent is a non-spatial.
**Steps to reproduce:**
_Spatials_: Create a Spatial root node, add a Node child, then another spatial below the child. The visibility of the 2nd spatial will not be affected by toggling the visibility of the root spatial.
_CanvasItems_: Create a Spatial root node, add a Sprite child. The visibility of the sprite isn't affected by toggling the visibility of the parent.
**Minimal reproduction project:**
[Visibility.zip](https://github.com/godotengine/godot/files/3385211/Visibility.zip)
Load the example project. Toggle the root spatial in the editor, it does not change visibility of the ball. View the sprite in 2d view. Toggle the spatial parent of the sprite. It does not affect the visibility of the sprite.
**Discussion:**
I'm pretty new to working on the engine but I was looking at ways of turning off processing when nodes had visibility turned off in the scene graph and I was suggested to use is_visible_in_tree(), as is_visible() is local to the node. I had a look at the source code for spatial:
```
bool Spatial::is_visible_in_tree() const {
const Spatial *s = this;
while (s) {
if (!s->data.visible) {
return false;
}
s = s->data.parent;
}
return true;
}
```
And immediately was concerned what happened if the parent node was not Spatial (or derived). After a test it seemed that the data.parent is set to NULL if you have e.g. a Node as parent to the Spatial, rather than getting a crash. This seems by design and means visibility doesn't pass through here.
After a little look it seems the same applies to CanvasItems:
```
bool CanvasItem::is_visible_in_tree() const {
if (!is_inside_tree())
return false;
const CanvasItem *p = this;
while (p) {
if (!p->visible)
return false;
p = p->get_parent_item();
}
return true;
}
```
where:
```
CanvasItem *CanvasItem::get_parent_item() const {
if (toplevel)
return NULL;
return Object::cast_to<CanvasItem>(get_parent());
}
```
So again traversal stops once it meets a non-canvas item.
I guess my question would be, is this the intended situation, and if so it should be mentioned in the docs? Currently it says:
_CanvasItem_
> bool is_visible_in_tree() const
> Returns true if the node is present in the SceneTree, its visible property is true and its inherited visibility is also true.
_Spatial_
> bool is_visible_in_tree() const
> Returns whether the node is visible, taking into consideration that its parents visibility.
For me, an obvious question is why is visible bool being maintained separately in Spatial and CanvasItem, rather than just being part of the Node (and being able to do this whole traversal via the Node). However I am sure there is some non-obvious design reason for this .. like being able to totally separate the 2d and 3d components of the engine.
Anyway this is just in the hope of some enlightenment, at the least we can simply mention it in the docs. :smile:
Another possibility to remove the need for this in most cases is some kind of method for optional parameters for notifications (i.e. whether being changed to visible, or invisible). Obviously the notification system wants to be as efficient as possible, and passing unused parameters around umpteen times is not a good solution, but you could easily store an optional notification parameter (or several) in the engine to be queried. This would have almost zero cost unless being used. Unless there were issues with multiple threads trying to call notifications at the same time.
You could also simply change the single visibility notification from changed to two alterative notifications for showing and hiding, however this would require changes throughout. | enhancement,discussion,topic:core | low | Critical |
467,255,006 | flutter | Flutter driver guide may need update | The Flutter driver guide provides instructions for executing a Flutter driver test suite from the command line. However, those instructions seem incompatible with the latest versions of Flutter, which list Chrome and Mac OS deployment targets.
Guide:
https://flutter.dev/docs/cookbook/testing/integration/introduction
When running the exact command at the bottom of that guide without an emulator, simulator, or device available, the following error is reported:
```bash
$ flutter drive --target=test_driver/app.dart
Found multiple connected devices:
- macOS
- Chrome
Using device macOS.
Starting application: test_driver/app.dart
Unable to find app name.
[project_path_redacted]/macos/Flutter/ephemeral/.app_filename does
not exist
Oops; flutter has exited unexpectedly.
Sending crash report to Google.
```
Either the instructions should be changed to include a device specification, or a more appropriate error message should be written, or Flutter should re-evaluate how it executes this command. | tool,t: flutter driver,c: proposal,P3,team-tool,triaged-tool | low | Critical |
467,267,407 | flutter | InvokeMethod issue on Android side, MethodChannel and EventChannel must be executed on the main thread | <!-- Thank you for using Flutter!
If you are looking for support, please check out our documentation
or consider asking a question on Stack Overflow:
* https://flutter.dev/
* https://api.flutter.dev/
* https://stackoverflow.com/questions/tagged/flutter?sort=frequent
If you have found a bug or if our documentation doesn't have an answer
to what you're looking for, then fill our the template below. Please read
our guide to filing a bug first: https://flutter.dev/docs/resources/bug-reports
-->
## Steps to Reproduce
<!-- Please tell us exactly how to reproduce the problem you are running into. -->
Currently developing an App in flutter which is communicating with Android through EventChannels and MethodChannels,
got some problem since I updated flutter from 1.5.4 to 1.7.8. So basically my workflow follows this steps.
1. On android side I am waiting for detection of sensor
2. On detection i read it and invoke a method from Flutter
3. Flutter generates a string based on argument, which he returns over method channel
4. When i get the String back on Android side, I use that String and run other methods
5. I send a variable on EventStream sink back to flutter
6. Flutter listens to stream and displays the content
And there are a couple of issues, your invoke method needs to run on MainThread, same goes for pushing variables on EventSink. **Is this a bug in the new version or you just want us to do with a single thread?** Second issue i found was even in the previous version, I simply don't know how and didn't find anything on the internet or your docs about **awaiting results of invokeMethod on Android side**, in flutter you can simply create a Future method and await it, but in Kotlin i don't know how (Currently time racing with Thread.Sleep(50ms)). Any suggestions? Am i doing something wrong?
**I am doing all of this on MainActivity, is this the source of problem?**
I tried to wrap it inside runOnUiThread, but it freezes my UI for the doing, would like to work it as async.
**What are your words on that, what direction will you go next?**
## Logs
<!--
Include the full logs of the commands you are running between the lines
with the backticks below. If you are running any "flutter" commands,
please include the output of running them with "--verbose"; for example,
the output of running "flutter --verbose create foo".
-->
Setting methodCallHandler on Flutter:
_channel.setMethodCallHandler(_checkPassword);
Invoking method on Android:
Log error after update (Same for Invoke method and EventChannel):
```
W/Binder: Caught a RuntimeException from the binder stub implementation.
java.lang.RuntimeException: Methods marked with @UiThread must be executed on the main thread. Current thread: Binder:10473_3
at io.flutter.embedding.engine.FlutterJNI.ensureRunningOnMainThread(FlutterJNI.java:794)
at io.flutter.embedding.engine.FlutterJNI.dispatchPlatformMessage(FlutterJNI.java:684)
at io.flutter.embedding.engine.dart.DartMessenger.send(DartMessenger.java:80)
at io.flutter.embedding.engine.dart.DartExecutor.send(DartExecutor.java:189)
at io.flutter.view.FlutterNativeView.send(FlutterNativeView.java:155)
at io.flutter.view.FlutterView.send(FlutterView.java:750)
at io.flutter.view.FlutterView.send(FlutterView.java:740)
at io.flutter.plugin.common.EventChannel$IncomingStreamRequestHandler$EventSinkImplementation.error(EventChannel.java:235)
at com.tracklegit.mobile.MainActivity.onTagDiscovered(MainActivity.kt:145)
at android.nfc.NfcActivityManager.onTagDiscovered(NfcActivityManager.java:602)
at android.nfc.IAppCallback$Stub.onTransact(IAppCallback.java:83)
at android.os.Binder.execTransact(Binder.java:739)
```
```
<!-- If possible, paste the output of running `flutter doctor -v` here. -->
[β] Flutter (Channel stable, v1.7.8+hotfix.3, on Microsoft Windows [Version 10.0.17763.615], locale sl-SI)
β’ Flutter version 1.7.8+hotfix.3 at D:\Games\flutter
β’ Framework revision b712a172f9 (2 days ago), 2019-07-09 13:14:38 -0700
β’ Engine revision 54ad777fd2
β’ Dart version 2.4.0
[β] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
β’ Android SDK at C:\Users\blazj\AppData\Local\Android\sdk
β’ Android NDK location not configured (optional; useful for native profiling support)
β’ Platform android-28, build-tools 28.0.3
β’ Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
β’ Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1343-b01)
β’ All Android licenses accepted.
[β] Android Studio (version 3.4)
β’ Android Studio at C:\Program Files\Android\Android Studio
β’ Flutter plugin version 37.0.1
β’ Dart plugin version 183.6270
β’ Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1343-b01)
[β] VS Code (version 1.36.1)
β’ VS Code at C:\Users\blazj\AppData\Local\Programs\Microsoft VS Code
β’ Flutter extension version 3.2.0
[β] Connected device (1 available)
β’ SM G950F β’ 988a5c344849314e57 β’ android-arm64 β’ Android 9 (API 28)
β’ No issues found!
```
```
| platform-android,engine,d: api docs,P3,a: plugins,team-android,triaged-android | low | Critical |
467,268,537 | flutter | [webview_flutter] Support spawning new webviews from JS | I hope the webview_flutter plugin can support multiple windows.I need this funcation to login facebook. | c: new feature,p: webview,package,team-ecosystem,P3,triaged-ecosystem | low | Major |
467,279,432 | pytorch | How to use mpi backend without CUDA_aware | We noticed that the MPI backend doesn't support the GPU from the official website,(https://pytorch.org/docs/master/distributed.html), then we complied the Pytorch with USE_MPI=1. The command line is `python3 main.py -a resnet50 --dist-url 'tcp://12.0.50.1:12348' --dist-backend 'mpi' --multiprocessing-distributed --world-size 2 --rank 0 /data/tiny-imagenet-200/`. However, we got the error message "CUDA tensor detected and the MPI used doesn't have CUDA-aware MPI support". I think the GPU-Direct is not enabled if used MPI backend, I don't know why it uses the CUDA tensor and CUDA-aware , seems GPU-Direct route. And how to set the args for avoiding the CUDA-aware. Thank you :) | triaged,module: mpi | low | Critical |
467,311,408 | rust | LLVM ERROR: out of memory with latest nightly (Windows 32bit) | I am trying to upgrade rust nightly in a project of mine and getting `out of memory` errors due to that, only on Windows though.
- old rust version: rustc 1.37.0-nightly (0dc9e9c10 2019-06-15)
- new rust version: rustc 1.38.0-nightly (0b680cfce 2019-07-09)
Build log of the failure on appveyor: https://ci.appveyor.com/project/dignifiedquire/deltachat-core-rust/builds/25928022
The failure occurs consistently when trying to compile the [psl](https://crates.io/crates/psl) crate. | A-LLVM,T-compiler,I-compilemem,C-bug | low | Critical |
467,312,475 | rust | core crate build fails for mips16 instruction set | I am writing bare metal code for a mipsel cpu. Since there is no readily available target for hat in rustc I use `cargo xbuild` to build one from a target specification that I derived from the mipsel linux target. This works great and the resulting code runs on the CPU. The CPU I am using supports mips16 ISA to improve code density. However, when I enable the feature in my target spec I get the follwing error when compiling the core crate:
```
LLVM ERROR: Not supported instr: <MCInst 351 <MCOperand Reg:321> <MCOperand Imm:2147483647> <MCOperand Imm:-1>>
error: Could not compile `core`.
To learn more, run the command again with --verbose.
error: `"/Users/alexander/.rustup/toolchains/nightly-x86_64-apple-darwin/bin/cargo" "rustc" "-p" "alloc" "--release" "--manifest-path" "/var/folders/8g/_rkmq65n0qnf70c41xvp174h0000gn/T/xargo.cfTitdX9TS2Q/Cargo.toml" "--target" "mipsel-unknown-none" "--" "-Z" "force-unstable-if-unmarked"` failed with exit code: Some(101)
make: *** [target/mipsel-unknown-none/release/mipswififw] Error 1
```
This is my spec:
```
{
"llvm-target": "mipsel-unknown-none",
"arch": "mips",
"cpu": "mips32r2",
"data-layout": "e-m:m-p:32:32-i8:8:32-i16:16:32-i64:64-n32-S64",
"executables": true,
"features": "+mips32r2,+mips16,+soft-float",
"linker-flavor": "ld.lld",
"linker": "rust-lld",
"panic-strategy": "abort",
"max-atomic-width": 32,
"os": "none",
"target-c-int-width": "32",
"target-endian": "little",
"target-pointer-width": "32"
}
```
When I remove the mips16 feature the error is gone.
| A-LLVM,O-MIPS,T-compiler,C-bug | low | Critical |
467,312,635 | go | plugin: load plugin crash fatal error: runtime: no plugin module data | <!-- Please answer these questions before submitting your issue. Thanks! -->
### What version of Go are you using (`go version`)?
<pre>
go version go1.11.1 darwin/amd64
</pre>
### Does this issue reproduce with the latest release?
Yes
### What operating system and processor architecture are you using (`go env`)?
<details><summary><code>go env</code> Output</summary><br><pre>
GOARCH="amd64"
GOBIN="/Users/webtom/go/bin"
GOCACHE="/Users/webtom/Library/Caches/go-build"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
GOPATH="/Users/webtom/go"
GOPROXY=""
GORACE=""
GOROOT="/usr/local/go"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/darwin_amd64"
GCCGO="gccgo"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/0t/9w0_mgfs511g4ssg2r38cb240000gn/T/go-build339879137=/tmp/go-build -gno-record-gcc-switches -fno-common"
</pre></details>
### What did you do?
```go
// **notice** build plugin command: go build -o test1.so -buildmode=plugin *.go
// **notice** test1.so and test2.so have the same content and different paths
_, err1 := plugin.Open("test1.so")
fmt.Println(err)
// err1: plugin.Open("./test1.so"): plugin was built with a different version of package errors
_, _ = plugin.Open("test2.so")
// fatal error: runtime: no plugin module data
```
### What did you expect to see?
No crash
### What did you see instead?
fatal error: runtime: no plugin module data
goroutine 1 [running]:
runtime.throw(0x40f2177, 0x1e)
/usr/local/go/src/runtime/panic.go:608 +0x72 fp=0xc000047b00 sp=0xc000047ad0 pc=0x402a602
plugin.lastmoduleinit(0xc00008c480, 0xc00000e038, 0x4302ad0, 0x42, 0x41c7da0)
/usr/local/go/src/runtime/plugin.go:22 +0xc03 fp=0xc000047c28 sp=0xc000047b00 pc=0x402baa3
plugin.open(0x40efb00, 0x10, 0x60, 0x0, 0x0)
/usr/local/go/src/plugin/plugin_dlopen.go:87 +0x3b3 fp=0xc000047ee0 sp=0xc000047c28 pc=0x40b19d3
plugin.Open(0x40efb00, 0x13, 0x2, 0x60, 0x0)
/usr/local/go/src/plugin/plugin.go:32 +0x35 fp=0xc000047f18 sp=0xc000047ee0 pc=0x40b11e5
main.main() | NeedsInvestigation,compiler/runtime | medium | Critical |
467,368,346 | opencv | Convolutional-LSTM models for object Detection on Video with much higher accuracy | ##### System information (version)
<!-- Example
- OpenCV => 4.1.0 - master-branch
- Operating System / Platform => Windows 64 Bit
- Compiler => Visual Studio 2015
-->
- OpenCV => 4.1.0 - master-branch
- Operating System / Platform => Win/Linux
- Compiler => g++ 5.4.0
##### Detailed description
Required implementation of Convolutional-LSTM layer which seems to give a huge increase in accuracy for Detection on Video: https://github.com/AlexeyAB/darknet/issues/3114
It seems that there is already some LSTM implementation: https://github.com/opencv/opencv/blob/22dbcf98c5fc1358bcb4660fe15a9ef8d2b4b388/modules/dnn/src/layers/recurrent_layers.cpp#L83-L349
It should allow to use this **Yolov3-SPP-LSTM** model with new layer `[conv-lstm]` for object detection on Video
* cfg: https://github.com/AlexeyAB/darknet/files/3199654/yolo_v3_spp_lstm.cfg.txt
* weights: https://drive.google.com/open?id=1-lFybALcypqTRtT3pzrrVuCRtDeWjsog
```
[conv_lstm]
batch_normalize=1
size=3
pad=1
output=256
peephole=0
state_constrain=512
activation=leaky
```
Implementation is got from this paper - page 4: https://arxiv.org/pdf/1506.04214v1.pdf
Just:
* `peephole=0` - disables Peephole `W * C`
* `peephole=1` - enables Peephole, but Peephole uses `*` - Convolution instead of `o` - Element-wise-product (Hadamard product), so the weights-file doesn't depend on network resolution (we can change width= and height= in [net]-section without retraining the model) - it seems it is implemented there: https://github.com/opencv/opencv/blob/22dbcf98c5fc1358bcb4660fe15a9ef8d2b4b388/modules/dnn/src/layers/recurrent_layers.cpp#L333-L337
* `state_constrain=512` - the maximum absolute value of `C`-state: https://github.com/AlexeyAB/darknet/blob/5a6afe96d3aa8aed19405577db7dba0ff173c848/src/conv_lstm_layer.c#L523 By default `state_constrain = time_steps * 32` (time_steps param from cfg-file that is used for training only, but state_constrain is used for both Training and Detection), it seems this is `useCellClip`: https://github.com/opencv/opencv/blob/22dbcf98c5fc1358bcb4660fe15a9ef8d2b4b388/modules/dnn/src/layers/recurrent_layers.cpp#L328-L332
There is the same proposal for Pytorch: https://github.com/pytorch/pytorch/issues/1706
With this implementation: https://github.com/AlexeyAB/darknet/blob/5a6afe96d3aa8aed19405577db7dba0ff173c848/src/conv_lstm_layer.c#L852-L929
<!-- your description -->
##### Steps to reproduce
<!-- to add code example fence it with triple backticks and optional file extension
```.cpp
// C++ code example
```
or attach as .txt or .zip file
-->
You can run any of these models `cfg/weights`: https://github.com/AlexeyAB/darknet/issues/3114#issuecomment-494148968
by using this repository: https://github.com/AlexeyAB/darknet
and this command:
`./darknet detector demo data/self_driving.data yolov3-tiny_occlusion_track.cfg yolov3-tiny_occlusion_track_last.weights self_driving_valid.avi -out_filename out_self_driving_valid.avi`
* `self_driving.data`
[self_driving.data.txt](https://github.com/opencv/opencv/files/3386250/self_driving.data.txt)
* `self_driving_valid.avi` file: https://drive.google.com/open?id=1rdxV1hYSQs6MNxBSIO9dNkAiBvb07aun
----
Weights of conv-lstm layer are saved in this order
```
if (l.peephole) {
save_convolutional_weights(*(l.vf), fp);
save_convolutional_weights(*(l.vi), fp);
save_convolutional_weights(*(l.vo), fp);
}
save_convolutional_weights(*(l.wf), fp);
save_convolutional_weights(*(l.wi), fp);
save_convolutional_weights(*(l.wg), fp);
save_convolutional_weights(*(l.wo), fp);
save_convolutional_weights(*(l.uf), fp);
save_convolutional_weights(*(l.ui), fp);
save_convolutional_weights(*(l.ug), fp);
save_convolutional_weights(*(l.uo), fp);
``` | priority: normal,feature,GSoC,category: dnn | low | Major |
467,375,375 | flutter | Emoji Keycap Sequence not supported on iOS | The [Emoji Sequence Data for UTS #51](https://www.unicode.org/Public/emoji/12.0/emoji-sequences.txt) has a section for Keycap sequence which specifies emoji alternatives for #, *, 0, 1, 2, 3, 4, 5, 6, 7, 8 and 9. These are available on the iOS keyboard.
They are all rendered properly as emojis on Android but not on iOS. Instead displaying the leading symbol followed by a box artifact (see screenshots).
## Android
## iOS
## Sample code
```dart
import 'package:flutter/material.dart';
const _emojiKeycapSequence = [
'\u0023\ufe0f\u20e3', // keycap: #
'\u002a\ufe0f\u20e3', // keycap: *
'\u0030\ufe0f\u20e3', // keycap: 0
'\u0031\ufe0f\u20e3', // keycap: 1
'\u0032\ufe0f\u20e3', // keycap: 2
'\u0033\ufe0f\u20e3', // keycap: 3
'\u0034\ufe0f\u20e3', // keycap: 4
'\u0035\ufe0f\u20e3', // keycap: 5
'\u0036\ufe0f\u20e3', // keycap: 6
'\u0037\ufe0f\u20e3', // keycap: 7
'\u0038\ufe0f\u20e3', // keycap: 8
'\u0039\ufe0f\u20e3', // keycap: 9
];
void main() => runApp(MyApp());
class MyApp extends StatelessWidget {
@override
Widget build(BuildContext context) => MaterialApp(
title: 'Flutter Demo',
home: Scaffold(
body: Center(
child: Text(
_emojiKeycapSequence.join(' '),
style: TextStyle(fontSize: 20),
),
),
),
);
}
```
## flutter doctor
```
Doctor summary (to see all details, run flutter doctor -v):
[β] Flutter (Channel stable, v1.7.8+hotfix.3, on Mac OS X 10.14.5 18F132, locale en-SE)
[β] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
[β] Xcode - develop for iOS and macOS (Xcode 10.2.1)
[β] iOS tools - develop for iOS devices
[β] Android Studio (version 3.4)
[β] Connected device (2 available)
β’ No issues found!
```
| platform-ios,engine,customer: alibaba,a: typography,has reproducible steps,P2,found in release: 3.3,found in release: 3.7,team-ios,triaged-ios | low | Major |
467,410,979 | nvm | Option on install to not add path to .profile | Is it possible to prevent the install-script to not add NVM to path in my e.g. ~/.profile? I use a zsh prezto plugin (node) which already does this. | feature requests,installing nvm | low | Major |
467,483,332 | go | proposal: spec: allow conversion between return types and structs | This comes from a conversation in #32941
The goal of this proposal is to allow easy conversion from a function return to a struct with the same field types and order.
This would allow to more easily pass a function result to a channel, without having to manually create temporary variables and filing them up in a struct before it is sent thorough a channel.
Example :
```go
type Pair struct {
i int
s string
}
func F() (int, string) { ... }
func G() chan {
Pair c := make(chan Pair)
go func() { c <- Pair(F()) }()
return c
}
```
Like converting between structs, tags should be ignored | LanguageChange,Proposal,dotdotdot,LanguageChangeReview | medium | Critical |
467,487,228 | pytorch | Port `fmod` operator from the TH code to Aten | `fmod` is the point-wise math operator so porting if from the TH code to Aten (and TensorIterator) expected to be easy. Such migration will help to clean up the code, simplify dispatch as well as provide immediate 2-3x operator performance gain.
Porting guide: https://github.com/pytorch/pytorch/wiki/TH-to-ATen-porting-guide
Example PR with porting of the adaptive_avg_pool2d: https://github.com/pytorch/pytorch/pull/14714
How to use TensorIterator: https://github.com/pytorch/pytorch/wiki/How-to-use-TensorIterator | module: cuda,module: cpu,triaged,module: porting,better-engineering | low | Major |
467,498,365 | rust | tool tidy should error on unused error codes | In `librustc_typeck` the error code `E0074` is unused, that is, this error is never emitted.
The `tidy` tool should detect this and error when this happens. | C-enhancement,T-bootstrap | low | Critical |
467,502,781 | node | fs.access throws permission error while checking W_OK on writable dir | * **Version**: `v10.16.0` (also happening on `v12.6.0`)
* **Platform**: `18.6.0 Darwin Kernel Version 18.6.0` (also happening on `4.15.0-54-generic Ubuntu`)
* **Subsystem**: `fs`
I'm experiencing a rather unexpected behaviour when trying `fs.access` on a directory that's also an NFS shared mount point. The check for `fs.constants.W_OK` throws `Error: EACCES: permission denied, access '/mnt/test/nfs'` even though the directory is writable and permissions seem to be correct for the user running the `node` script process.
Below is a reproduction of what I'm seeing.
```js
const os = require('os');
const path = require('path');
const fs = require('fs');
// Path to the mount directory
const MOUNT_PATH = '/mnt/test/nfs';
const filePath = path.join(MOUNT_PATH, 'foo.txt');
// Write a file
fs.writeFileSync(filePath, 'Hello world!'); // Passes OK
// Read a file
const contents = fs.readFileSync(filePath); // Passes OK
console.log(contents.toString('utf-8')); // 'Hello World!'
// Get stats
os.userInfo();
/*
{
uid: 431,
gid: 433,
username: 'test',
homedir: '/home/test',
shell: '/sbin/nologin'
}
*/
fs.stat(MOUNT_PATH, console.log);
/*
> null Stats {
dev: 52,
mode: 16895, <- '0777' octal
nlink: 1,
uid: 431, <- Correct uid
gid: 433, <- Correct gid
rdev: 0,
blksize: 4096,
ino: 263,
size: 184,
blocks: 0,
atimeMs: 1562948571578.2288,
mtimeMs: 1562897414354.1873,
ctimeMs: 1562897414354.1873,
birthtimeMs: 0,
atime: 2019-07-12T16:22:51.578Z,
mtime: 2019-07-12T02:10:14.354Z,
ctime: 2019-07-12T02:10:14.354Z,
birthtime: 1970-01-01T00:00:00.000Z
}
*/
// Test permissions
fs.access(MOUNT_PATH, fs.constants.R_OK, console.error); // Passes OK
fs.access(MOUNT_PATH, fs.constants.W_OK, console.error);
/*
[Error: EACCES: permission denied, access '/mnt/test/nfs'] {
errno: -13,
code: 'EACCES',
syscall: 'access',
path: '/mnt/test/nfs'
*/
```
This **does not happen on any other directory outside the NFS share**. I stumbled upon the exception when writing a very simple health checker script to test the mount availability for a running web service.
Am I missing something? What's the catch here? Thanks in advance.
| fs | low | Critical |
467,504,542 | TypeScript | Allow '--noEmit' to override 'emitDeclarationOnly' from config. | ## Search Terms
- TS5053
- emitDeclarationOnly
## Suggestion
Using `"emitDeclarationOnly": true` in your `tsconfig.json` prevents you to do typechecking only runs as running `tsc --noEmit` will throw the following error.
```bash
error TS5053: Option 'emitDeclarationOnly' cannot be specified with option 'noEmit'.
```
And the CLI does not look like to have any flag to bypass the error (eg. something like `--noEmitDeclarationOnly`).
I don't see a reason why a `noEmit` cli flag would not take precedence over the `emitDeclarationOnly` from the tsconfig.
## Use Cases
With a project with a `tsconfig.json` set with `emitDeclarationOnly` and using another compiler like babel to produce the built javascript code, you want to be able to both:
- Compile declaration files (running `tsc`)
- Perform typechecking as a test stage (eg. travis) (running `tsc --noEmit`). Especially since you do not use TypeScript to compile (so a build could pass with typings errors).
## Examples
https://github.com/mgcrea/node-influx-syslog
## Checklist
My suggestion meets these guidelines:
* [x] This wouldn't be a breaking change in existing TypeScript/JavaScript code
* [x] This wouldn't change the runtime behavior of existing JavaScript code
* [x] This could be implemented without emitting different JS based on the types of the expressions
* [x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
* [x] This feature would agree with the rest of [TypeScript's Design Goals](https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals).
| Suggestion,Awaiting More Feedback | low | Critical |
467,529,723 | flutter | Get rid of FlushType::kSingle (we don't need to enum even) | Concurrent message loops lie outside of the task runner framework now. We don't need single flush types. | team,engine,P2,team-engine,triaged-engine | low | Minor |
467,535,788 | go | x/website: show current Go version next to download button on homepage | The previous website design had a string with the current version. As part of my workflow, I used to check the website to see if a new version was released, at the same time I was checking if new interesting blog posts were available.
Seems like the new website removed that version string.
Could you please put it back?
Thanks!
| NeedsFix | low | Major |
467,543,882 | flutter | Split pointer enter, exit, and hover callbacks from Listener | ## TL;DR
We propose that pointer enter, exit, and hover callbacks are split from `Listener` into a new class `Mouse`. It is mainly because mouse tracking is unable to support certain features provided by `Listener`, also because `Listener` is often used only for mouse events.
## Problem
### Unable to support `HitTestBehavior.deferToChild`
Although `Listener` is designed to be a all-in-one class for pointer-related callbacks, under the hood it consists of two subsystems: Mouse tracking, represented by `onPointer{Enter,Exit,Hover}` events, are implemented with layer-based hit testing, while pointer events listening, represented by `onPointer{Down,Up,Move}`, are implemented with render-box-based hit testing.
`Listener` also provides a few options, one of them being `HitTestBehavior behavior`, which controls the behavior of hit testing. However, this option is directly passed to `RenderProxyBoxWithHitTestBehavior`, therefore it can not affect layers (hence the layer-based callbacks). Having an option that only affects some of the callbacks is definitely confusing and undesired.
We can try to simulate the behavior in layers (which is planned), but it is technically impossible to simulate `HitTestBehavior.deferToChild`, since child information is related with render objects and is lost when converted to layers.
By splitting `onPointer{Enter,Exit,Hover}` into a separate class, we can provide a different type of behavior that has only two options to avoid this confusion.
### It is often used alone
`Listener.onPointer{Down,Up,Move}` are rarely used directly, instead developers are supposed to use `GestureDetector` when possible, or to create a custom gesture recognizer with `RawGestureDetector`.
On the other hand, `Listener.onPointer{Enter,Exit,Hover}` are currently the only way to track mouse movement. This leads to a common code pattern as the following snippet, where `Listener` is only used for `onPointer{Enter,Exit,Hover}`:
```dart
@override
Widget build(BuildContext context) {
return Listener(
onPointerEnter: _handlePointerEnter,
onPointerExit: _handlePointerExit,
child: GestureDetector(
onTapDown: _handleTapDown,
onTap: _handleTap,
...
child: widget.child,
),
);
}
```
Although we squashed 2 separate subsystems into `Listener`, developers often utilize only one of them. Therefore it might be a better idea to split them for modularity.
### More mouse features are coming
Flutter plans to add more features related to mouse (for example, pointer icons). For features that are built based on the `MouseTracker`, the new APIs will be added to the same place, i.e. `Listener`. By splitting the mouse tracking part out, we keep `Listener` clean for apps that don't plan to support mouse.
## Proposal
Split the mouse tracking part of `RenderPointerListener` into a new class `RenderMouseListener`.
Split the mouse tracking part of `Listener` into a new class `Mouse`. `Listener` will keep `onPointer{Down,Up,Move,Cancel,Signal}` as well as `behavior`.
Rename the mouse tracking callbacks of `Mouse` and `MouseTrackerAnnotation` to `onMouse{Enter,Exit,Hover}` to emphasize the difference.
- I understand that this change is more aggressive and less necessary. Comments are welcome.
`Listener.onPointer{Enter,Exit,Hover}` are preserved for backward compatibility and marked as deprecated.
A proposal PR is https://github.com/flutter/flutter/pull/36217.
## Future plans
New behavior option for mouse tracking will be added in a separate PR after this change.
## Revisions
Previously I proposed to split pointer events (up/down/move/cancel/signal) out while keeping enter/exit/hover in. The current proposal suggest the opposite.
Previously I proposed to call the new class `MouseListener`. The current proposal is calling `Mouse` to accommodate upcoming changes such as pointer icon. | c: new feature,framework,c: API break,f: gestures,c: proposal,P3,team-framework,triaged-framework | low | Major |
467,561,225 | pytorch | TensorImpl de-virtualization | ## Motivation
We want to de-virtualize TensorImpl methods as much as possible, to achieve performance gain for common Tensor methods such as `numel()` / `sizes()` / `dim()`.
## Concerns
XLA relies on TensorImpl methods such as `numel()` / `sizes()` / `dim()` being virtual, so that they can have their own implementation and calculate those values lazily when requested, rather than eagerly when a size change event happens.
## Proposal
1. To support XLA's use case, we should add virtual methods such as `virtual_numel()` / `virtual_sizes()` / `virtual_dim()` to OpaqueTensorImpl, and in TensorImpl we should add conditional branching in `numel()` / `sizes()` / `dim()` to call the opaque virtual methods when the TensorImpl is OpaqueTensorImpl. (We should run benchmarks such as JIT LSTM to make sure adding conditional branching and de-virtualizing `numel()` / `sizes()` / `dim()` doesn't cause perf regression for our CPU / CUDA use cases.)
2. We should ask XLA to move their XLATensorImpl to OpaqueTensorImpl, and ask them to override the opaque methods for their lazy size computation.
3. We should de-virtualize TensorImpl and all of its subclasses in PyTorch core library (example PR: #20909).
cc. @gchanan @colesbury @ailzhang
cc @ezyang @gchanan @zou3519 @jerryzh168 | high priority,module: dependency bug,module: internals,triaged,quansight-nack | low | Major |
467,602,035 | go | make.bash: cannot build toolchain if go.mod recursively exists in some parent directory | Using `go1.12`. That is `GOROOT_BOOTSTRAP` is set to some Go toolchain with module support.
Steps to reproduce:
```
$ go mod init github.com/user/project
$ mkdir -p sub/sub/sub && cd sub/sub/sub
$ curl -s -L https://dl.google.com/go/go1.12.7.src.tar.gz | tar -zxf -
$ cd go/src
$ ./make.bash # this fails
Building Go cmd/dist using /usr/local/go.
Building Go toolchain1 using /usr/local/go.
go: warning: "bootstrap/cmd/..." matched no packages
go tool dist: open /tmp/blah/sub/sub/sub/go/pkg/bootstrap/bin/asm: no such file or directory
$ rm ../../../../../go.mod
$ ./make.bash # this succeeds
```
It seems odd that `./make.bash` should care whether a `go.mod` file exists in any directory above it.
\cc @bcmills | NeedsInvestigation,modules | low | Major |
467,639,184 | rust | Type inference of lambda arguments interferes with borrow checking | It looks like type inference of arguments to a lambda function somehow interferes with borrow checking.
I tried this code: ([playground link](https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=6b018776f5b9055e27776a0072530c0b))
```rust
struct Bar {}
struct Foo {
a: Bar,
}
impl Foo {
fn one(&self) -> Option<&Bar> {
return Some(&self.a);
}
fn two(&mut self) -> Option<Bar> {
return Some(Bar {});
}
}
fn main() {
let mut f = Foo { a: Bar {} };
let test = |_t| {};
match f.one() {
Some(a) => test(a),
None => {}
}
match f.two() {
Some(ref b) => test(b),
None => {}
}
}
```
## I expected to see this happen:
A successful build
## Instead, this happened:
Compilation failed with this error:
```
error[E0502]: cannot borrow `f` as mutable because it is also borrowed as immutable
--> src/lib.rs:27:11
|
22 | match f.one() {
| - immutable borrow occurs here
...
27 | match f.two() {
| ^^^^^^^ mutable borrow occurs here
28 | Some(ref b) => test(b),
| ---- immutable borrow later used here
```
Note that changing line 20 to
```rust
let test = |_t: &Bar| {};
```
results in a successful compilation ([playground link](https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=9a4f487d98be2a891d86236c8551c6a1))
## Meta
`rustc --version --verbose`:
```
rustc 1.36.0 (a53f9df32 2019-07-03)
binary: rustc
commit-hash: a53f9df32fbb0b5f4382caaad8f1a46f36ea887c
commit-date: 2019-07-03
host: x86_64-pc-windows-msvc
release: 1.36.0
LLVM version: 8.0
``` | A-closures,A-borrow-checker,T-compiler,A-inference,C-bug | low | Critical |
467,658,359 | go | crypto/x509/pkix: Name.String() hex-encodes string-type ExtraNames | <!-- Please answer these questions before submitting your issue. Thanks! -->
### What version of Go are you using (`go version`)?
<pre>
$ go version
go version go1.12.6 linux/amd64
</pre>
### Does this issue reproduce with the latest release?
Yes.
### What operating system and processor architecture are you using (`go env`)?
<details><summary><code>go env</code> Output</summary><br><pre>
$ go env
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/jrittner/.cache/go-build"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/home/jrittner/go-workspace"
GOPROXY=""
GORACE=""
GOROOT="/home/jrittner/go"
GOTMPDIR=""
GOTOOLDIR="/home/jrittner/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build691331496=/tmp/go-build -gno-record-gcc-switches"
</pre></details>
### What did you do?
I created a pkix.Name containing a custom ExtraName, and converted it to a string.
https://play.golang.org/p/1hyqwP_RTBs
### What did you expect to see?
1.2.3.4=sample,CN=foobar
### What did you see instead?
1.2.3.4=#130673616d706c65,CN=foobar
This is because Go always hex-encodes the asn.1 encoding of the value, even though RFC 2253 states that the value is supposed to just be used as its own string encoding. https://tools.ietf.org/html/rfc2253#section-2.4
> Otherwise, if the AttributeValue is of a type which has a string
representation, the value is converted first to a UTF-8 string
according to its syntax specification (see for example section 6 of
[4]).
Note that OpenSSL gives the expected output when viewing a certificate or CSR with a custom name. | NeedsInvestigation | medium | Critical |
467,673,967 | node | inspector.open(0, undefined, /* wait */true) won't allow communicating inspector.url() | I'd like to open the first available debugging port and wait for client to attach before I continue execution, so I do:
```js
inspector.open(0, undefined, /* wait */ true);
```
This results in a logical deadlock though: in order to get the `inspector.url()`, I need to continue execution. But execution only continues when connection is established over that exact URL I can't get. It makes me think that `inspector.open` does not really make sense with the `wait === true`.
Could this API be changed to something like below instead?
```js
inspector.open(0, undefined, true, ({url}) => {
clientPipe.send(url); // <-- reports url
});
// <-- blocks execution.
```
@eugeneo, @ak239 | inspector | low | Critical |
467,718,768 | godot | Does UWP export works? | <!-- Please search existing issues for potential duplicates before filing yours:
https://github.com/godotengine/godot/issues?q=is%3Aissue
-->
**Godot version:**
3.1.1
<!-- Specify commit hash if non-official. -->
**OS/device including version:**
Windows 10
<!-- Specify GPU model and drivers if graphics-related. -->
**Issue description:**
Seems UWP export does not work. It is generates damaged file, that I can't run.
And signtool can't sign file.
`C:\Program Files (x86)\Windows Kits\10\App Certification Kit>SignTool sign /fd SHA256 /a /f c:\key.pfx /p x D:\System\Documents\_GODOT\Export\UWP\green_pixel.appx
Done Adding Additional Store
SignTool Error: This file format cannot be signed because it is not recognized.
SignTool Error: An error occurred while attempting to sign: D:\System\Documents\_GODOT\Export\UWP\green_pixel.appx
Number of errors: 1`
**Steps to reproduce:**
Try to export to UWP and run.
**Minimal reproduction project:**
<!-- Recommended as it greatly speeds up debugging. Drag and drop a zip archive to upload it. -->
| bug,topic:porting,confirmed,platform:uwp,topic:export | high | Critical |
467,782,703 | godot | dict2inst does not work on classes with _init parameters | **Godot version:**
Godot Engine v3.1.1.stable.official
**Issue description:**
`dict2inst` does not work on classes with `_init` parameters. A simple fix is to manually initialize the object after it has been created with `.new()`
**Steps to reproduce:**
Create a scene with an external(not built in script). Then run the scene with this in the script:
```gdscript
extends Node2D
class A:
var value
func _init(val):
self.value = val
class B:
var value
func init(val):
self.value = val
func serializeA():
var inst = A.new(1)
var instDict = inst2dict(inst)
var inst2 = dict2inst(instDict)
print("A was serialized and deserialize succesfully")
func serializeB():
var inst = B.new()
B.init(1)
var instDict = inst2dict(inst)
var inst2 = dict2inst(instDict)
print("B was serialized and deserialize succesfully")
func _ready():
serializeA() # this will crash the program
serializeB() # this runs fine
```
``` | bug,topic:gdscript,confirmed,crash | low | Critical |
467,807,043 | TypeScript | Preserve comments with object destructuring assignment | <!-- π¨ STOP π¨ π¦π§π’π£ π¨ πΊπ»πΆπ· π¨
Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Please read the FAQ first, especially the "Common Feature Requests" section.
-->
## Search Terms
<!-- List of keywords you searched for before creating this issue. Write them down here so that others can find this suggestion more easily -->
object destructuring assignment, comment
## Suggestion
<!-- A summary of what you'd like to see added or changed -->
```ts
interface MyInterface {
/**
* I am x
*/
x : number;
/**
* I am y
*/
y : number;
}
declare const myInterface : MyInterface;
const {x, y} = myInterface;
/**
* Expected tooltip to have comment,
* > I am x
*
* Actual: No comment
*/
x;
/**
* Expected tooltip to have comment,
* > I am y
*
* Actual: No comment
*/
y;
/**
* Expected tooltip to have comment,
* > I am x
*
* Actual:
* Tooltip has comment,
* > I am x
*/
myInterface.x;
/**
* Expected tooltip to have comment,
* > I am y
*
* Actual:
* Tooltip has comment,
* > I am y
*/
myInterface.y;
/**
* I am z
*/
const z = 1;
/**
* Expected tooltip to have comment,
* > I am z
*
* Actual:
* Tooltip has comment,
* > I am z
*/
z;
```
[Playground](http://www.typescriptlang.org/play/#code/JYOwLgpgTgZghgYwgAgLIE8CS5rycgbwFgAoZc5AegCprSLzrlNk4BbZAD3oesp-KdkALmQgArmwBG0ANwCqtBciYt2ydMr4L0IsZJlR5JAL6kAJhAQAbOFBQIA9iADOYZGyw5YiFKIzYkD5Ixk6u7gScADQaJsgAvB5eQXgQxqQ0dGRMAKKcAA5WkObIYI6O1mDA+aWOyAAWcABuDo5sbBDgUfRMAHzMrBzc2cg9yACCCGDicNaiAHJ1Tu2dYD38JJzGmWN5hVMQJWUVVTVlDc2tK11j-WocmiNjk9OzC0ttHeDrpOjpJDsRnsiodaidqrULi1kMsvmBuiM7oMuGNnlMZnMxgAVcqVCGNFwwz6rBEqZBI9TDFQbTyBXC+AB0W1IGSUQIKIKOuNOkMa0NhJNuA3UjzJaNemJGOPBNQJROu8KF9w0PxItO8qQZfxZALZZOVAC9VWE3MgDQlkABGf6AsnAg5cmW8y7yuGkvrCjhGp4jF4Y4TY7n4uCEgU3RGes2qg2yIA)
## Use Cases
<!--
What do you want to use this for?
What shortcomings exist with current approaches?
-->
I came across this idea after writing code like this,
```ts
function foo (
{
somePropertyA,
somePropertyB,
somePropertyC,
} : SomeObject
) {
/* Use these properties */
}
```
And I was hazy on the details of what each property was for.
So, I hovered my cursor over the variables `somePropertyA, somePropertyB, somePropertyC` and noticed there were no comments.
I had to go to the declaration of `somePropertyA, somePropertyB, somePropertyC` and look at each property individually.
-----
At the moment, the way to get comments is to just do,
```ts
function foo (
o : SomeObject
) {
/* Use these properties */
}
```
Then the tooltip for `o.somePropertyA, o.somePropertyB, o.somePropertyC` will have comments
## Examples
<!-- Show how this would be used and what the behavior would be -->
See above suggestion
## Checklist
My suggestion meets these guidelines:
* [X] This wouldn't be a breaking change in existing TypeScript/JavaScript code
* [X] This wouldn't change the runtime behavior of existing JavaScript code
* [X] This could be implemented without emitting different JS based on the types of the expressions
* [X] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
* [X] This feature would agree with the rest of [TypeScript's Design Goals](https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals).
| Suggestion,Awaiting More Feedback | low | Critical |
467,818,488 | rust | libstd initialization should check that target-features enabled at compile-time are enabled at run-time | libstd initialization should, at least in debug builds, and probably always, do check for all target-features for which `cfg!(target_feature = "feature")` returns true, that the feature is indeed actually enabled at run-time, e.g., by checking that `is_{target_arch}_feature_detected!("feature")` returns true.
If this check fails, the behavior is undefined, in quiet a serious way, and we should panic with a nice error message explaining the situation, instead of letting the binary continue its hopeless execution. | T-libs-api,C-feature-request | low | Critical |
467,822,434 | flutter | Exception thrown while displaying Text() widgets initialized with empty strings ("") | Hi there,
found this strange bug tryng to display 3 Text() widgets inside a ClipRect().
If any of the initial strings are empty (""), an exception is thrown.
When the strings are initialized with a character, everything is fine...
Test program and log output follow.
## Steps to Reproduce
<details>
<summary>Source code:</summary>
```
import 'package:flutter/material.dart';
void main() => runApp(MyApp());
class MyApp extends StatelessWidget {
// This widget is the root of your application.
@override
Widget build(BuildContext context) {
return MaterialApp(
title: 'Flutter Demo',
theme: ThemeData(
// This is the theme of your application.
//
// Try running your application with "flutter run". You'll see the
// application has a blue toolbar. Then, without quitting the app, try
// changing the primarySwatch below to Colors.green and then invoke
// "hot reload" (press "r" in the console where you ran "flutter run",
// or simply save your changes to "hot reload" in a Flutter IDE).
// Notice that the counter didn't reset back to zero; the application
// is not restarted.
primarySwatch: Colors.blue,
),
home: MyHomePage(title: 'Flutter Demo Home Page'),
);
}
}
class MyHomePage extends StatefulWidget {
MyHomePage({Key key, this.title}) : super(key: key);
// This widget is the home page of your application. It is stateful, meaning
// that it has a State object (defined below) that contains fields that affect
// how it looks.
// This class is the configuration for the state. It holds the values (in this
// case the title) provided by the parent (in this case the App widget) and
// used by the build method of the State. Fields in a Widget subclass are
// always marked "final".
final String title;
@override
_MyHomePageState createState() => _MyHomePageState();
}
class _MyHomePageState extends State<MyHomePage> {
int _counter = 0;
void _incrementCounter() {
setState(() {
// This call to setState tells the Flutter framework that something has
// changed in this State, which causes it to rerun the build method below
// so that the display can reflect the updated values. If we changed
// _counter without calling setState(), then the build method would not be
// called again, and so nothing would appear to happen.
_counter++;
});
}
Widget display(Orientation orientation) {
var valueStyle = TextStyle(
backgroundColor: Colors.black,
color: Colors.lightGreen,
);
var labelStyle = TextStyle(
backgroundColor: Colors.black,
color: Colors.white,
);
var flexDelta = orientation == Orientation.landscape ? 3 : 2;
var text = "";
var label = "";
var labelUnit = "";
var showAltLabel = false;
var display = ClipRRect(
borderRadius: BorderRadius.circular(5),
child: Container(
color: Colors.black,
child: Padding(
padding: const EdgeInsets.all(0),
child: Column(
children: <Widget>[
Expanded(
child: FittedBox(
child: GestureDetector(
onTap: () => showAltLabel = !showAltLabel,
child: Text(
text,
maxLines: 1,
textAlign: TextAlign.end,
style: valueStyle,
),
),
alignment: Alignment.bottomLeft,
fit: BoxFit.contain,
),
flex: 8 - flexDelta,
),
Expanded(
child: Padding(
padding: const EdgeInsets.fromLTRB(4, 1, 4, 0),
child: Row(
children: <Widget>[
Expanded(
child: FittedBox(
child: Text(
label,
textAlign: TextAlign.start,
style: labelStyle,
),
alignment: Alignment.bottomLeft,
),
),
Expanded(
child: FittedBox(
child: Text(
labelUnit,
textAlign: TextAlign.end,
style: labelStyle,
),
alignment: Alignment.bottomRight,
),
),
],
),
),
flex: 1,
),
],
),
),
),
);
return display;
}
@override
Widget build(BuildContext context) {
// This method is rerun every time setState is called, for instance as done
// by the _incrementCounter method above.
//
// The Flutter framework has been optimized to make rerunning build methods
// fast, so that you can just rebuild anything that needs updating rather
// than having to individually change instances of widgets.
return Scaffold(
appBar: AppBar(
// Here we take the value from the MyHomePage object that was created by
// the App.build method, and use it to set our appbar title.
title: Text(widget.title),
),
body: Center(
// Center is a layout widget. It takes a single child and positions it
// in the middle of the parent.
child: Column(
// Column is also layout widget. It takes a list of children and
// arranges them vertically. By default, it sizes itself to fit its
// children horizontally, and tries to be as tall as its parent.
//
// Invoke "debug painting" (press "p" in the console, choose the
// "Toggle Debug Paint" action from the Flutter Inspector in Android
// Studio, or the "Toggle Debug Paint" command in Visual Studio Code)
// to see the wireframe for each widget.
//
// Column has various properties to control how it sizes itself and
// how it positions its children. Here we use mainAxisAlignment to
// center the children vertically; the main axis here is the vertical
// axis because Columns are vertical (the cross axis would be
// horizontal).
mainAxisAlignment: MainAxisAlignment.center,
children: <Widget>[
Text(
'You have pushed the button this many times:',
),
Text(
'$_counter',
style: Theme.of(context).textTheme.display1,
),
Expanded(
child: display(Orientation.portrait),
),
],
),
),
floatingActionButton: FloatingActionButton(
onPressed: _incrementCounter,
tooltip: 'Increment',
child: Icon(Icons.add),
), // This trailing comma makes auto-formatting nicer for build methods.
);
}
}
```
</details>
<details>
<summary>Logs</summary>
```
I/flutter (17586): βββ‘ EXCEPTION CAUGHT BY RENDERING LIBRARY ββββββββββββββββββββββββββββββββββββββββββββββββββββββββββ
I/flutter (17586): The following assertion was thrown during performLayout():
I/flutter (17586): 'package:flutter/src/rendering/box.dart': Failed assertion: line 307 pos 12: 'width > 0.0': is not
I/flutter (17586): true.
I/flutter (17586):
I/flutter (17586): Either the assertion indicates an error in the framework itself, or we should provide substantially
I/flutter (17586): more information in this error message to help you determine and fix the underlying cause.
I/flutter (17586): In either case, please report this assertion by filing a bug on GitHub:
I/flutter (17586): https://github.com/flutter/flutter/issues/new?template=BUG.md
I/flutter (17586):
I/flutter (17586): When the exception was thrown, this was the stack:
I/flutter (17586): #2 BoxConstraints.constrainSizeAndAttemptToPreserveAspectRatio (package:flutter/src/rendering/box.dart:307:12)
I/flutter (17586): #3 RenderFittedBox.performLayout (package:flutter/src/rendering/proxy_box.dart:2252:26)
I/flutter (17586): #4 RenderObject.layout (package:flutter/src/rendering/object.dart:1619:7)
I/flutter (17586): #5 RenderFlex.performLayout (package:flutter/src/rendering/flex.dart:805:17)
I/flutter (17586): #6 RenderObject.layout (package:flutter/src/rendering/object.dart:1619:7)
I/flutter (17586): #7 RenderPadding.performLayout (package:flutter/src/rendering/shifted_box.dart:206:11)
I/flutter (17586): #8 RenderObject.layout (package:flutter/src/rendering/object.dart:1619:7)
I/flutter (17586): #9 _RenderProxyBox&RenderBox&RenderObjectWithChildMixin&RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:105:13)
I/flutter (17586): #10 RenderObject.layout (package:flutter/src/rendering/object.dart:1619:7)
I/flutter (17586): #11 _RenderProxyBox&RenderBox&RenderObjectWithChildMixin&RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:105:13)
I/flutter (17586): #12 _RenderCustomClip.performLayout (package:flutter/src/rendering/proxy_box.dart:1214:11)
I/flutter (17586): #13 RenderObject.layout (package:flutter/src/rendering/object.dart:1619:7)
I/flutter (17586): #14 RenderFlex.performLayout (package:flutter/src/rendering/flex.dart:805:17)
I/flutter (17586): #15 RenderObject.layout (package:flutter/src/rendering/object.dart:1619:7)
I/flutter (17586): #16 RenderPositionedBox.performLayout (package:flutter/src/rendering/shifted_box.dart:392:13)
I/flutter (17586): #17 RenderObject.layout (package:flutter/src/rendering/object.dart:1619:7)
I/flutter (17586): #18 MultiChildLayoutDelegate.layoutChild (package:flutter/src/rendering/custom_layout.dart:142:11)
I/flutter (17586): #19 _ScaffoldLayout.performLayout (package:flutter/src/material/scaffold.dart:443:7)
I/flutter (17586): #20 MultiChildLayoutDelegate._callPerformLayout (package:flutter/src/rendering/custom_layout.dart:212:7)
I/flutter (17586): #21 RenderCustomMultiChildLayoutBox.performLayout (package:flutter/src/rendering/custom_layout.dart:356:14)
I/flutter (17586): #22 RenderObject.layout (package:flutter/src/rendering/object.dart:1619:7)
I/flutter (17586): #23 _RenderProxyBox&RenderBox&RenderObjectWithChildMixin&RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:105:13)
I/flutter (17586): #24 RenderObject.layout (package:flutter/src/rendering/object.dart:1619:7)
I/flutter (17586): #25 _RenderProxyBox&RenderBox&RenderObjectWithChildMixin&RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:105:13)
I/flutter (17586): #26 _RenderCustomClip.performLayout (package:flutter/src/rendering/proxy_box.dart:1214:11)
I/flutter (17586): #27 RenderObject.layout (package:flutter/src/rendering/object.dart:1619:7)
I/flutter (17586): #28 _RenderProxyBox&RenderBox&RenderObjectWithChildMixin&RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:105:13)
I/flutter (17586): #29 RenderObject.layout (package:flutter/src/rendering/object.dart:1619:7)
I/flutter (17586): #30 _RenderProxyBox&RenderBox&RenderObjectWithChildMixin&RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:105:13)
I/flutter (17586): #31 RenderObject.layout (package:flutter/src/rendering/object.dart:1619:7)
I/flutter (17586): #32 _RenderProxyBox&RenderBox&RenderObjectWithChildMixin&RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:105:13)
I/flutter (17586): #33 RenderObject.layout (package:flutter/src/rendering/object.dart:1619:7)
I/flutter (17586): #34 _RenderProxyBox&RenderBox&RenderObjectWithChildMixin&RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:105:13)
I/flutter (17586): #35 RenderObject.layout (package:flutter/src/rendering/object.dart:1619:7)
I/flutter (17586): #36 _RenderProxyBox&RenderBox&RenderObjectWithChildMixin&RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:105:13)
I/flutter (17586): #37 RenderObject.layout (package:flutter/src/rendering/object.dart:1619:7)
I/flutter (17586): #38 _RenderProxyBox&RenderBox&RenderObjectWithChildMixin&RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:105:13)
I/flutter (17586): #39 RenderObject.layout (package:flutter/src/rendering/object.dart:1619:7)
I/flutter (17586): #40 _RenderProxyBox&RenderBox&RenderObjectWithChildMixin&RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:105:13)
I/flutter (17586): #41 RenderObject.layout (package:flutter/src/rendering/object.dart:1619:7)
I/flutter (17586): #42 _RenderProxyBox&RenderBox&RenderObjectWithChildMixin&RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:105:13)
I/flutter (17586): #43 RenderOffstage.performLayout (package:flutter/src/rendering/proxy_box.dart:3076:13)
I/flutter (17586): #44 RenderObject.layout (package:flutter/src/rendering/object.dart:1619:7)
I/flutter (17586): #45 RenderStack.performLayout (package:flutter/src/rendering/stack.dart:510:15)
I/flutter (17586): #46 RenderObject.layout (package:flutter/src/rendering/object.dart:1619:7)
I/flutter (17586): #47 __RenderTheatre&RenderBox&RenderObjectWithChildMixin&RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:105:13)
I/flutter (17586): #48 RenderObject.layout (package:flutter/src/rendering/object.dart:1619:7)
I/flutter (17586): #49 _RenderProxyBox&RenderBox&RenderObjectWithChildMixin&RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:105:13)
I/flutter (17586): #50 RenderObject.layout (package:flutter/src/rendering/object.dart:1619:7)
I/flutter (17586): #51 _RenderProxyBox&RenderBox&RenderObjectWithChildMixin&RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:105:13)
I/flutter (17586): #52 RenderObject.layout (package:flutter/src/rendering/object.dart:1619:7)
I/flutter (17586): #53 _RenderProxyBox&RenderBox&RenderObjectWithChildMixin&RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:105:13)
I/flutter (17586): #54 RenderObject.layout (package:flutter/src/rendering/object.dart:1619:7)
I/flutter (17586): #55 _RenderProxyBox&RenderBox&RenderObjectWithChildMixin&RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:105:13)
I/flutter (17586): #56 RenderObject.layout (package:flutter/src/rendering/object.dart:1619:7)
I/flutter (17586): #57 _RenderProxyBox&RenderBox&RenderObjectWithChildMixin&RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:105:13)
I/flutter (17586): #58 RenderObject.layout (package:flutter/src/rendering/object.dart:1619:7)
I/flutter (17586): #59 RenderView.performLayout (package:flutter/src/rendering/view.dart:151:13)
I/flutter (17586): #60 RenderObject._layoutWithoutResize (package:flutter/src/rendering/object.dart:1496:7)
I/flutter (17586): #61 PipelineOwner.flushLayout (package:flutter/src/rendering/object.dart:765:18)
I/flutter (17586): #62 _WidgetsFlutterBinding&BindingBase&GestureBinding&ServicesBinding&SchedulerBinding&PaintingBinding&SemanticsBinding&RendererBinding.drawFrame (package:flutter/src/rendering/binding.dart:346:19)
I/flutter (17586): #63 _WidgetsFlutterBinding&BindingBase&GestureBinding&ServicesBinding&SchedulerBinding&PaintingBinding&SemanticsBinding&RendererBinding&WidgetsBinding.drawFrame (package:flutter/src/widgets/binding.dart:701:13)
I/flutter (17586): #64 _WidgetsFlutterBinding&BindingBase&GestureBinding&ServicesBinding&SchedulerBinding&PaintingBinding&SemanticsBinding&RendererBinding._handlePersistentFrameCallback (package:flutter/src/rendering/binding.dart:285:5)
I/flutter (17586): #65 _WidgetsFlutterBinding&BindingBase&GestureBinding&ServicesBinding&SchedulerBinding._invokeFrameCallback (package:flutter/src/scheduler/binding.dart:1016:15)
I/flutter (17586): #66 _WidgetsFlutterBinding&BindingBase&GestureBinding&ServicesBinding&SchedulerBinding.handleDrawFrame (package:flutter/src/scheduler/binding.dart:958:9)
I/flutter (17586): #67 _WidgetsFlutterBinding&BindingBase&GestureBinding&ServicesBinding&SchedulerBinding.scheduleWarmUpFrame.<anonymous closure> (package:flutter/src/scheduler/binding.dart:784:7)
I/flutter (17586): #76 _Timer._runTimers (dart:isolate-patch/timer_impl.dart:382:19)
I/flutter (17586): #77 _Timer._handleMessage (dart:isolate-patch/timer_impl.dart:416:5)
I/flutter (17586): #78 _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:172:12)
I/flutter (17586): (elided 10 frames from class _AssertionError, package dart:async, and package dart:async-patch)
I/flutter (17586):
I/flutter (17586): The following RenderObject was being processed when the exception was fired: RenderFittedBox#91341 relayoutBoundary=up7 NEEDS-LAYOUT NEEDS-PAINT NEEDS-COMPOSITING-BITS-UPDATE:
I/flutter (17586): creator: FittedBox β Expanded β Column β Padding β DecoratedBox β Container β ClipRRect β Expanded β
I/flutter (17586): Column β Center β MediaQuery β LayoutId-[<_ScaffoldSlot.body>] β β―
I/flutter (17586): parentData: offset=Offset(0.0, 0.0); flex=6; fit=FlexFit.tight (can use size)
I/flutter (17586): constraints: BoxConstraints(0.0<=w<=392.7, h=515.5)
I/flutter (17586): size: MISSING
I/flutter (17586): fit: contain
I/flutter (17586): alignment: bottomLeft
I/flutter (17586): textDirection: ltr
I/flutter (17586): This RenderObject had the following descendants (showing up to depth 5):
I/flutter (17586): child: RenderSemanticsGestureHandler#4c185 relayoutBoundary=up8 NEEDS-PAINT NEEDS-COMPOSITING-BITS-UPDATE
I/flutter (17586): child: RenderPointerListener#9a7cd relayoutBoundary=up9 NEEDS-PAINT NEEDS-COMPOSITING-BITS-UPDATE
I/flutter (17586): child: RenderParagraph#7202a relayoutBoundary=up10 NEEDS-PAINT
I/flutter (17586): text: TextSpan
I/flutter (17586): ββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββ
I/flutter (17586): Another exception was thrown: RenderBox was not laid out: RenderFittedBox#91341 relayoutBoundary=up7 NEEDS-PAINT NEEDS-COMPOSITING-BITS-UPDATE
I/flutter (17586): Another exception was thrown: RenderBox was not laid out: RenderFlex#166f3 relayoutBoundary=up6 NEEDS-PAINT NEEDS-COMPOSITING-BITS-UPDATE
I/flutter (17586): Another exception was thrown: RenderBox was not laid out: RenderPadding#60e47 relayoutBoundary=up5 NEEDS-PAINT NEEDS-COMPOSITING-BITS-UPDATE
I/flutter (17586): Another exception was thrown: RenderBox was not laid out: RenderDecoratedBox#cefcb relayoutBoundary=up4 NEEDS-PAINT NEEDS-COMPOSITING-BITS-UPDATE
I/flutter (17586): Another exception was thrown: RenderBox was not laid out: RenderClipRRect#8accf relayoutBoundary=up3 NEEDS-PAINT NEEDS-COMPOSITING-BITS-UPDATE
I/flutter (17586): Another exception was thrown: 'package:flutter/src/rendering/shifted_box.dart': Failed assertion: line 321 pos 12: 'child.hasSize': is not true.
I/flutter (17586): Another exception was thrown: NoSuchMethodError: The method '>' was called on null.
```
</details>
```
Analyzing bug_test...
No issues found! (ran in 1.6s)
```
```
Doctor summary (to see all details, run flutter doctor -v):
[β] Flutter (Channel stable, v1.7.8+hotfix.3, on Microsoft Windows [Version 10.0.18362.239], locale it-IT)
[β] Android toolchain - develop for Android devices (Android SDK version 29.0.0)
[β] Android Studio (version 3.4)
[β] Android Studio (version 3.5)
[β] IntelliJ IDEA Community Edition (version 2019.1)
[β] VS Code (version 1.36.1)
[β] Connected device (1 available)
β’ No issues found!
``` | framework,a: typography,a: error message,has reproducible steps,P2,found in release: 3.3,found in release: 3.5,team-framework,triaged-framework | low | Critical |
467,844,172 | TypeScript | Property decorator documentation is inaccurate? | From the [official docs](https://www.typescriptlang.org/docs/handbook/decorators.html#property-decorators) about property decorators:
"The return value is ignored too."
But the following example returns a new descriptor, and it works fine:
```ts
class Greeter {
@logProperty
greeting;
}
function logProperty(target, key): any {
var value;
var getter = function() {
console.log('getter');
return value;
};
var setter = function(newVal) {
value = newVal;
};
return {
get: getter,
set: setter,
enumerable: true,
configurable: true
};
}
const g = new Greeter();
const b = g.greeting;
```
| Docs | low | Major |
467,850,630 | pytorch | [feature request] Log-determinant for symmetric positive definite matrices | ## π Feature
As of now, one cannot leverage the positive-definitiveness of a matrix when computing log-determinants. The current `torch.logdet` works for general square matrices and thus uses LU in forward and SVD in backward.
For SPD matrices it can be implemented more efficiently via a Cholesky decomposition in forward and its inverse in backward. The latter can be computed very efficiently via `torch.cholesky_inverse` (note that its batch variant is not implemented yet: https://github.com/pytorch/pytorch/issues/7500).
CC @vishwakftw
cc @vincentqb @vishwakftw @jianyuh @nikitaved @pearu @mruberry @heitorschueroff | triaged,has workaround,module: linear algebra,function request | medium | Major |
467,857,264 | flutter | RefreshIndicator cannot be canceled on Android | At first, this seems like it could be a duplicate of #9690, however, the actual issue is only mentioned in [this comment](https://github.com/flutter/flutter/issues/9690#issuecomment-347550626).
The user **should be able** to change their mind and push the refresh indicator back up, as can be seen here (native Android app):
In Flutter, however, the refresh indicator gets pushed back up together with the scrollable content.
There is an *even bigger* problem that occurs when the `ListView` content does not require any scrolling, i.e. if it is smaller than the viewport: the overscroll glow takes less dragging than it takes to push the refresh indicator back, which makes it **impossible** to cancel the refresh indicator, which clearly is a bug. And the fact that the refresh indicator *can be partially* pushed back in that case shows that the fact that the refresh indicator gets pushed back with the scrollable content is clearly another bug.
[Here is a Gist](https://gist.github.com/creativecreatorormaybenot/4df2b87ce7ce1d6f82648003098daf67) with the code used for these illustrations.
It suprises me that this has not been fixed for over two years even though it was added to milestones back then. | framework,f: material design,a: quality,has reproducible steps,P2,found in release: 3.7,found in release: 3.9,team-design,triaged-design | low | Critical |
467,887,009 | godot | add_keyword_color in textedit does not works using symbols ([ < > ] ....) | <!-- Please search existing issues for potential duplicates before filing yours:
https://github.com/godotengine/godot/issues?q=is%3Aissue
-->
**Godot version:**
3.1
**OS/device including version:**
Windows 10 64 Bits
**Issue description:**
using command add_keyword_color from textEdit does not works if you use symbols
**Steps to reproduce:**
**Minimal reproduction project:**
```gdscript
var textEdit = $textEdit # node text edit
textEdit.add_keyword_color("[", Color(1,1,0,1)) # Does not works
textEdit.add_keyword_color("<", Color(0,1,1,1)) # Does not works
textEdit.add_keyword_color("A", Color(1,1,0,1)) # This works
textEdit.add_keyword_color("8", Color(1,1,0,1)) # This works
``` | bug,confirmed,topic:gui | low | Major |
467,942,096 | TypeScript | Union not narrowed with `typeof x.y` as a discriminant | <!-- π¨ STOP π¨ π¦π§π’π£ π¨ πΊπ»πΆπ· π¨
Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Even if you think you've found a *bug*, please read the FAQ first, especially the Common "Bugs" That Aren't Bugs section!
Please help us by doing the following steps before logging an issue:
* Search: https://github.com/Microsoft/TypeScript/search?type=Issues
* Read the FAQ: https://github.com/Microsoft/TypeScript/wiki/FAQ
Please fill in the *entire* template below.
-->
<!-- Please try to reproduce the issue with `typescript@next`. It may have already been fixed. -->
**TypeScript Version:** 3.6.0-dev.20190713
<!-- Search terms you tried before logging this (so others can find this issue more easily) -->
**Search Terms:** `TS2339`, `union type object`, `union type property does not exist`
And github suggestions while I was writing the title.
**Code**
```ts
type Test = {
someKey: false
} | {
someKey: {
someKeyInside?: number
},
someKeyThatExistOnlyIfOtherKeyIsNotFalse: string;
};
declare const test: Test;
if (typeof test.someKey === 'object') {
console.log(test.someKeyThatExistOnlyIfOtherKeyIsNotFalse);
}
```
**Expected behavior:**
String in `someKeyThatExistOnlyIfOtherKeyIsNotFalse` should be logged
**Actual behavior:**
```
error TS2339: Property 'someKeyThatExistOnlyIfSomeKeyIsNotFalse' does not exist on type 'Test2'.
Property 'someKeyThatExistOnlyIfSomeKeyIsNotFalse' does not exist on type '{ someKey: false; }'.
29 console.log(test2.someKeyThatExistOnlyIfSomeKeyIsNotFalse); // TS2339: Property 'someKeyThatExistOnlyIfSomeKeyIsNotFalse' does not exist on type '{ someKey: false; }'.
```
**Playground Link:** <!-- A link to a TypeScript Playground "Share" link which demonstrates this behavior -->
https://www.typescriptlang.org/play/index.html#code/C4TwDgpgBAKhDOwCMUC8UDeAoKurwHsBbCAaQhAC4oAzAQwBt4IsBfKAH0xz0JPKrc8w-MTIUAkgDt4ASwAmEalICuRAEYQATj1ysANLtH8KMABZ1gAUQAesxAHkpDEBJoPgZ7QInwAcgTAAGKMzNSIWrJSAOYA3GzxWIoAxgx0WtDJBDLAUMAIyNRwiEiJsjRQABT5JQB0fOIgAJRCeFkyBAwQtQwE0dUFSPViAuaWtvbATi5uHl5aPv6BIUwQTbFQAPSbUA6kAIRsWFigkLAFAExorbgNAtT0q2ycN8aN1NgieNuwXlDZLn+Umg8nKNG0ECkyWgNC0xDy4GgxWQ+jePhkCkydCkUE0UBUUkUNCiEHkQLRFCMwjukgxigA-Mo1JodMIDEYaSAxtY7I5nK53J5vJIlsFQkp8MBIjF4qxEik0hkoO1EHlLkVLmUKtVEQQKjVgBdhiYQGhUOgAOQEdQAKwgyWAFpanza2UIXR6fQGiCNnO5Ez5M0F80WATFq3WWx2MAAyhcAMzxgCc1AACnDIFpQFALX6LDzJtMBXNha5RStmBaoPICAgoFJAlAILzctkEWcLRgKYJHswNqwLbU2EA
Take a look at `type Test1`. The only one difference from `type Test2` is `someKeyInside` should be always defined.
**Related Issues:** <!-- Did you find other bugs that looked similar? -->
- | Bug,Help Wanted,Effort: Moderate | low | Critical |
467,952,350 | opencv | Feature request: Still image capture with dshow/msmf | OpenCV-Python 4.1
Windows 7 64 Bit
The videocapture module currently only supports framegrabbing with the dshow/media foundation api's. Both api's support taking still images with a 'still image pin' [Dshow](https://docs.microsoft.com/en-us/windows/win32/directshow/capturing-an-image-from-a-still-image-pin) or 'takephoto' instruction [MediaFoundation](https://docs.microsoft.com/en-us/windows/win32/api/mfcaptureengine/nf-mfcaptureengine-imfcaptureengine-takephoto) This enables certain webcams (like the surface book pro camera) to take images with much higher resolution (8 MP).
Would it be possible to include this in a future-version of the videocapture module?
| feature,priority: low,category: videoio(camera),platform: win32 | low | Minor |
467,964,319 | vue | dynamic v-slot maybe overwite when used together with v-for on same element | ### Version
2.6.10
### Reproduction link
[https://jsfiddle.net/zrh122/scg6eq1t/](https://jsfiddle.net/zrh122/scg6eq1t/)
### Steps to reproduce
1. open the reproduction link
2. look at the rendered result
### What is expected?
```js
a: a
b: b
```
### What is actually happening?
```js
a:
b: b
```
---
This is an english version of issue #10165.
<!-- generated by vue-issues. DO NOT REMOVE --> | bug,has workaround | medium | Minor |
467,971,193 | TypeScript | Allow constant strings as string literals for dynamic import statements. | ## Search Terms
Use constant string in place of string literal for dynamic import statements.
## Suggestion
Honestly I donβt know if this is a bug or a suggestion.
Is there a way to allow constant string to represent string literals? Iβm thinking this should work, but it doesnβt. For example:
const moduleName = "../../../Project/src/Mod";
async function doSomething() {
var mod = await import(moduleName); // (works only if a string literal at the moment)
}
In the case above, "mod" is of type "any" because the compiler doesn't recognize the string literal in the constant `moduleName` (for literal strings, the types are correctly pulled). I'm not sure if this was an oversight, but it makes sense to allow it, since constant strings cannot be reassigned. The only workaround is to wrap `await import("../../../Project/src/Mod");` in a function:
async function getMod() { return import("../../../Project/src/Mod"); }
async function doSomething() {
var mod = await getMod(); // (method required since const strings cannot be used to import module type)
}
I may also add, it seems very difficult to import namespaces using dynamic imports, which I think is another terrible oversight.
async function doSomething() {
var mod = await import("../../../Project/src/Mod"); // (forced to use a string literal to get typings)
var o: mod.SomeClass; // ERROR, cannot find namespace 'mod'
// var o: InstanceType<typeof mod.SomeClass>; // workaround1
// var o: import("../../../Project/src/Mod").SomeClass; // workaround2 (who wants to keep typing full paths? A const string would be nice here.)
}
That doesn't even make sense. A namespace, while a type, is still a reference under the hood, and thus should still be importable dynamically somehow; perhaps like:
async function doSomething() {
import mod = await import("../../../Project/src/Mod"); // (forced to use a string literal to get typings)
var o: mod.SomeClass;
}
I think all this would aim to better support dynamic imports "on demand" instead of modules forcibly loading every single module when some may not be needed at all, It could also help promote faster initial page loads in many cases. ;)
## Checklist
My suggestion meets these guidelines:
* [x] This wouldn't be a breaking change in existing TypeScript/JavaScript code
* [x] This wouldn't change the runtime behavior of existing JavaScript code
* [x] This could be implemented without emitting different JS based on the types of the expressions
* [x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
* [x] This feature would agree with the rest of [TypeScript's Design Goals](https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals).
| Needs Investigation | medium | Critical |
468,027,297 | opencv | Error while reading DeeplabV3+ xception_65 model in Opencv4.0 | ##### System information (version)
- OpenCV => 4.0
- Operating System / Platform => Ubuntu 16.04
- Compiler => cmake
- Tensorflow => 1.13.1
- Python => 3.5
- protobuf => 3.6.1
##### Detailed description
terminate called after throwing an instance of 'cv::Exception' what(): OpenCV(4.0.0) /home/cas/work/opencv-4.0.0/modules/dnn/src/tensorflow/tf_importer.cpp:1155: error: (-213:The function/feature is not implemented) Unsupported squeeze configuration in function 'populateNet'
##### Steps to reproduce
when i run the codes below, above problem occurred:
```
#include <string>
#include <iostream>
#include <fstream>
#include <opencv2/opencv.hpp>
#include <opencv2/dnn.hpp>
#include <opencv2/dnn/dnn.hpp>
#include <opencv2/imgproc.hpp>
#include <opencv2/highgui.hpp>
#include <opencv2/core/utils/filesystem.hpp>
using namespace std;
using namespace cv;
int main()
{
cv::Mat src;
src = imread("/home/cas/work/readpb_opencv/src/opencv_pb/test_image/33.jpg");
string weights = "/home/cas/work/readpb_opencv/src/opencv_pb/model/step13000.pb";
string prototxt = "/home/cas/work/readpb_opencv/src/opencv_pb/model/step13000_graph.pbtxt";
dnn::Net net = cv::dnn::readNetFromTensorflow(weights, prototxt);
cv::Mat blob = cv::dnn::blobFromImage(src,1.0,cv::Size(640, 480),cv::Scalar(),true,false,CV_8U);
net.setInput(blob);
Mat output = net.forward();
imshow("result",output);
waitKey(0);
return 0;
}
```
the way i get the 'step13000_graph.pbtxt' is :
```
import tensorflow as tf
# Read the graph.
with tf.gfile.FastGFile('/home/cas/work/readpb_opencv/src/opencv_pb/model/step13000.pb','rb') as f:
graph_def = tf.GraphDef()
graph_def.ParseFromString(f.read())
# Remove Const nodes.
for i in reversed(range(len(graph_def.node))):
if graph_def.node[i].op == 'Const':
del graph_def.node[i]
for attr in ['T', 'data_format', 'Tshape', 'N', 'Tidx', 'Tdim',
'use_cudnn_on_gpu', 'Index', 'Tperm', 'is_training',
'Tpaddings']:
if attr in graph_def.node[i].attr:
del graph_def.node[i].attr[attr]
# Save as text.
tf.train.write_graph(graph_def, "", "/home/cas/work/readpb_opencv/src/opencv_pb/model/step13000_graph.pbtxt", as_text=True)
```
Any help in resolving this would be greatly appreciated. Thanks !
| category: dnn | medium | Critical |
468,034,630 | pytorch | CRITICAL:root:Cannot load caffe2.python. Error: DLL load failed: The specified module could not be found. | ## β Questions and Help
I'm installing into a conda env. it is on Windows 10 . No GPU on machine.
I am following instructions from https://caffe2.ai/docs/getting-started.html?platform=windows&configuration=compile
And the build is success.
Then I copy C:\Users\v-hadong\pytorch\build\caffe2\python\caffe2_pybind11_state.pyd to Pythonβs DLL folder C:\Users\v-hadong\AppData\Local\Continuum\anaconda2\envs\caffe2\DLLs\
and then the error is happened as the following picture:
| caffe2 | low | Critical |
468,097,884 | angular | Default Content-type entity header for JSON differs between Angular vs AngularJs | **IMPORTANT**
This is not necessarily a bug. Primarily I am just trying to gather some additional information about different behaviour of AngularJs (`$http`) and Angular (`HttpClient`) APIs.
Please note that I've asked the same question on SO and Gitter but haven't received any answers so I decided to ask it there:
In AngularJs the default `Content-type` for `JSON` request is set like:
`Content-Type: application/json; charset=UTF-8`
This is the part of the AngularJs code that does it:
[http.js](https://github.com/angular/angular.js/blob/6706353a71e3c11c56c0b19be03600dac57aafe1/src/ng/http.js#L333)
... and this is the commit in which `charset=UTF-8` parameter was added:
[angular/angular.js@10f80d7](https://github.com/angular/angular.js/commit/10f80d7d2918f98262090b425ecc294d9518aa7e)
Now in the case of Angular only
`Content-Type: application/json`
is used:
[xhr_backend.ts](https://github.com/angular/angular/blob/f8096d499324cf0961f092944bbaedd05364eea1/packages/http/src/backends/xhr_backend.ts#L165)
Side note:
We've noticed this when migrating from AngularJs (`$http`) to Angular (`HttpClient`).
Does anyone know why this difference?
| type: bug/fix,freq1: low,area: common/http,P4 | low | Critical |
468,101,564 | go | archive/zip: zip64 extra headers problems | ### What version of Go are you using (`go version`)?
<pre>
$ go version
go1.12.1 darwin/amd64
</pre>
### Does this issue reproduce with the latest release?
Yes
### What operating system and processor architecture are you using (`go env`)?
<details><summary><code>go env</code> Output</summary><br><pre>
$ go env
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/philip/Library/Caches/go-build"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
GOPATH="/Users/philip/go"
GOPROXY=""
GORACE=""
GOROOT="/usr/local/go"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/darwin_amd64"
GCCGO="gccgo"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/nd/dfzcj9w53w35kbvytmjwczg80000gn/T/go-build036595790=/tmp/go-build -gno-record-gcc-switches -fno-common"
</pre></details>
### What did you do?
<!--
If possible, provide a recipe for reproducing the error.
A complete runnable program is good.
A link on play.golang.org is best.
-->
Created 2 blank files:
```
$ mkfile -n 5000000000 ~/Desktop/5GB_big_empty_file
$ mkfile -n 5000 ~/Desktop/5KB_small_empty_file
```
Archived them with Go/archive/zip in the EXACT ORDER as above using:
```go
fileHeader := &zip.FileHeader{
Method: zip.Store, // no compression, very important
}
```
Then inspected the result in terminal with zipinfo -v and the contents with [Hex Fiend](https://ridiculousfish.com/hexfiend/):.
Then I tested the archive against all popular unarchivers and spend the last 2 weeks double-checking with their respective developers to confirm the problem:
- [Keka](https://www.keka.io/en/) (checked with aonez [#423](https://github.com/aonez/Keka/issues/423))
- [The Unarchiver](https://theunarchiver.com/) (checked with PaulTaykalo [#100](https://github.com/MacPaw/XADMaster/issues/100))
- [BetterZip](https://macitbetter.com/) (checked with [Robert Rezabek](mailto:[email protected]))
- [7Zip](https://www.7-zip.org/) (checked with Igor Pavlov [#f7ca](https://sourceforge.net/p/sevenzip/discussion/45797/thread/13e7d575/#f7ca))
### What did you expect to see?
Document: https://pkware.cachefly.net/webdocs/casestudies/APPNOTE.TXT
> 4.5.3
> The order of the fields in the zip64 extended
> information record is fixed, but the fields MUST
> only appear if the corresponding Local or Central
> directory record field is set to 0xFFFF or 0xFFFFFFFF.
Not documented here is what to do when the size is EXACTLY 0xFFFFFFFF. But since the main purpose of archiving files is to make them as small as possible, then it makes more sense to NOT add a useless zip64 with a 0 value taking 8 extra data bytes for nothing.
Thus the Central-directory extra fields should contain only 16 and 8 data bytes, [see correct 7zip code](https://github.com/kornelski/7z/blob/a6e2c7e401a3e5976e8522de518a169b0d8a7fac/CPP/7zip/Archive/Zip/ZipOut.cpp#L214), for ONLY the fields > 0xFFFFFFFF:
Entry 1. Only 16 bytes for compressed and uncompressed sizes
```
Central directory entry #1:
---------------------------
5GB_big_empty_file
offset of local header from start of archive: 0
(0000000000000000h) bytes
...
compressed size: 5000000000 bytes
uncompressed size: 5000000000 bytes
...
The central-directory extra field contains:
- A subfield with ID 0x0001 (PKWARE 64-bit sizes) and 16 data bytes:
00 f2 05 2a 01 00 00 00 00 f2 05 2a 01 00 00 00.
```
Entry 2. Only 8 bytes for the offset of local header
```
Central directory entry #2:
---------------------------
5KB_small_empty_file
offset of local header from start of archive: 5000000068
(000000012A05F244h) bytes
...
compressed size: 5000 bytes
uncompressed size: 5000 bytes
...
The central-directory extra field contains:
- A subfield with ID 0x0001 (PKWARE 64-bit sizes) and 8 data bytes:
44 f2 05 2a 01 00 00 00.
```
### What did you see instead?
[Go wrongly adds 24 data bytes in the extra fields for both files](https://github.com/golang/go/blob/89d300b821551c9955414caf3066ae602813f6ea/src/archive/zip/writer.go#L109):
```
Central directory entry #1:
---------------------------
5GB_big_empty_file
offset of local header from start of archive: 0 <= this should NOT be added
(0000000000000000h) bytes
...
compressed size: 5000000000 bytes
uncompressed size: 5000000000 bytes
...
The central-directory extra field contains:
- A subfield with ID 0x0001 (PKWARE 64-bit sizes) and 24 data bytes:
00 f2 05 2a 01 00 00 00 00 f2 05 2a 01 00 00 00 00 00 00 00 00 00 00 00.
Central directory entry #2:
---------------------------
5KB_small_empty_file
offset of local header from start of archive: 5000000081
(000000012A05F251h) bytes
...
compressed size: 5000 bytes <= this should NOT be added
uncompressed size: 5000 bytes <= this should NOT be added
...
The central-directory extra field contains:
- A subfield with ID 0x0001 (PKWARE 64-bit sizes) and 24 data bytes:
88 13 00 00 00 00 00 00 88 13 00 00 00 00 00 00 51 f2 05 2a 01 00 00 00.
```
This causes errors or warning messages in some unarchivers.
### Source code explanation
[src/archive/zip/writer.go#L101](https://github.com/golang/go/blob/89d300b821551c9955414caf3066ae602813f6ea/src/archive/zip/writer.go#L101)
```go
if h.isZip64() || h.offset >= uint32max { // <= This check should be strictly > uint32max
// the file needs a zip64 header. store maxint in both
// 32 bit size fields (and offset later) to signal that the
// zip64 extra header should be used. // <= These 3 fields should NOT be all set together
b.uint32(uint32max) // compressed size // <= set only if h.CompressedSize64 > uint32max
b.uint32(uint32max) // uncompressed size // <= set only if h.UncompressedSize64 > uint32max
// append a zip64 extra block to Extra
var buf [28]byte // 2x uint16 + 3x uint64 // <= These 3x uint64 fields should NOT be all set together
eb := writeBuf(buf[:])
eb.uint16(zip64ExtraID)
eb.uint16(24) // size = 3x uint64 // <= This could be either 8, 16 or 24
eb.uint64(h.UncompressedSize64) // <= set only if h.UncompressedSize64 > uint32max
eb.uint64(h.CompressedSize64) // <= set only if h.CompressedSize64 > uint32max
eb.uint64(h.offset) // <= set only if h.offset > uint32max
h.Extra = append(h.Extra, buf[:]...)
} else {
b.uint32(h.CompressedSize) // <= not needed if checked above
b.uint32(h.UncompressedSize) // <= not needed if checked above
}
```
### Proposed Solution
Replacing the above code with this should solve the problems.
```go
if h.CompressedSize64 > uint32max {
b.uint32(uint32max)
} else {
b.uint32(uint32(h.CompressedSize))
}
if h.UncompressedSize64 > uint32max {
b.uint32(uint32max)
} else {
b.uint32(uint32(h.UncompressedSize))
}
// append a zip64 extra block to Extra
if h.CompressedSize64 > uint32max || h.UncompressedSize > uint32max || h.offset > uint32max {
zip64ExtraSize := uint16(0)
if h.CompressedSize64 > uint32max {
zip64ExtraSize += 8
}
if h.UncompressedSize64 > uint32max {
zip64ExtraSize += 8
}
if h.offset > uint32max {
zip64ExtraSize += 8
}
var buf []byte
buf = make([]byte, 4+zip64ExtraSize) // 2x uint16 + zip64ExtraSize
eb := writeBuf(buf[:])
eb.uint16(zip64ExtraID)
eb.uint16(zip64ExtraSize)
if h.CompressedSize64 > uint32max {
eb.uint64(h.UncompressedSize64)
}
if h.UncompressedSize64 > uint32max {
eb.uint64(h.CompressedSize64)
}
if h.offset > uint32max {
eb.uint64(h.offset)
}
h.Extra = append(h.Extra, buf[:]...)
}
``` | NeedsFix | medium | Critical |
468,120,129 | go | x/net/icmp: Hogs CPU on Windows, doesn't capture packets | <!-- Please answer these questions before submitting your issue. Thanks! -->
### What version of Go are you using (`go version`)?
<pre>
$ go version
go version go1.12.7 windows/amd64
</pre>
### Does this issue reproduce with the latest release?
Yes
### What operating system and processor architecture are you using (`go env`)?
<details><summary><code>go env</code> Output</summary><br><pre>
$ go env
set GOARCH=amd64
set GOBIN=
set GOCACHE=C:\Users\bob\AppData\Local\go-build
set GOEXE=.exe
set GOFLAGS=
set GOHOSTARCH=amd64
set GOHOSTOS=windows
set GOOS=windows
set GOPATH=C:\Users\bob\go
set GOPROXY=
set GORACE=
set GOROOT=C:\Go
set GOTMPDIR=
set GOTOOLDIR=C:\Go\pkg\tool\windows_amd64
set GCCGO=gccgo
set CC=gcc
set CXX=g++
set CGO_ENABLED=1
set GOMOD=
set CGO_CFLAGS=-g -O2
set CGO_CPPFLAGS=
set CGO_CXXFLAGS=-g -O2
set CGO_FFLAGS=-g -O2
set CGO_LDFLAGS=-g -O2
set PKG_CONFIG=pkg-config
set GOGCCFLAGS=-m64 -mthreads -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=C:\Users\bob\AppData\Local\Temp\go-build347592694=/tmp/go-build -gno-record-gcc-switchesv
</pre></details>
### What did you do?
<!--
If possible, provide a recipe for reproducing the error.
A complete runnable program is good.
A link on play.golang.org is best.
-->
I would like to receive all incoming ICMP packets and their payload/message, and once I am able to do that I would like to filter said packets so only specific IP sources and/or payloads/messages are captured and logged.
I would like this to work on both Linux and Windows, but at the moment I am experiencing issues specifically on Windows (works as expected on Linux). Tested on a Window 7 64-bit virtual machine on VirtualBox (running on Arch Linux).
I'm using the code found in the accepted answer for this StackOverflow question, with slight alterations:
https://stackoverflow.com/questions/33345683/how-to-listen-for-icmp-packets
My code (running as Admin):
https://play.golang.org/p/RmuJmXgLKJk
I've replaced the IP address in `ListenPacket()` to the local address of the virtual machine on which I would like to log incoming ICMP packets (`192.168.0.111` in Playground link, also tried `0.0.0.0`).
I've also added `if sourceIP == nil { continue }` so that only ICMP packets containing a source IP are displayed. Without this condition, I was seeing infinite logs displaying an empty message and `nil` source address.
When I ping the virtual machine on which this code is running, the program does not display any messages. Also, the program uses up a lot of CPU (%90-%99) and the machine almost freezes up.
### What did you expect to see?
Logs of ICMP packets with source IP and message. Minimal CPU usage.
### What did you see instead?
With `if sourceIP == nil { continue }`: No logs, program hogs CPU ~%98.
Without `if sourceIP == nil { continue }`: Infinite logs, program uses %10-%20 CPU. | NeedsInvestigation | low | Critical |
468,247,679 | pytorch | Make it easier to bisect on PyTorch | @pietern mentioned recently that he attempted to bisect a bug in 0.4.1, and it was difficult; only 2 out of 10 commits were buildable. It would be helpful if we had some set of scripts or documentation that made it easier to do bisect; e.g., telling us about when build commands changed, or how to work around a symbol error (or fix some Git configuration.)
@fmassa also suggests that if we have nightlies, we can just query for specific dates, and use those builds to test more quickly. @pietern Each build is about 400M for each architecture. So the aggregate size would be a couple of gigabytes; doing this for every commit would be very excessive. | module: build,module: ci,triaged,better-engineering | low | Critical |
468,310,528 | TypeScript | Bug in typing iterable iterator with symbol | <!-- π¨ STOP π¨ π¦π§π’π£ π¨ πΊπ»πΆπ· π¨
Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Even if you think you've found a *bug*, please read the FAQ first, especially the Common "Bugs" That Aren't Bugs section!
Please help us by doing the following steps before logging an issue:
* Search: https://github.com/Microsoft/TypeScript/search?type=Issues
* Read the FAQ: https://github.com/Microsoft/TypeScript/wiki/FAQ
Please fill in the *entire* template below.
-->
<!-- Please try to reproduce the issue with `typescript@next`. It may have already been fixed. -->
**TypeScript Version:** 3.6.0-dev.20190713
<!-- Search terms you tried before logging this (so others can find this issue more easily) -->
**Search Terms:** symbol iterableiterator
**Code**
```ts
const Foo = Symbol()
type FooType = typeof Foo
type SomeType = number | FooType
function giveMeSomeType(): SomeType {
return (Math.random() > 0.5) ? 42 : Foo
}
const it: IterableIterator<SomeType> = [giveMeSomeType()][Symbol.iterator]()
```
**Expected behavior:** local constant `it` is typechecked correctly
**Actual behavior:**
Typechecking fails with error:
```
index.ts:10:7 - error TS2322: Type 'IterableIterator<number | symbol>' is not assignable to type 'IterableIterator<SomeType>'.
Type 'number | symbol' is not assignable to type 'SomeType'.
Type 'symbol' is not assignable to type 'SomeType'.
10 const it: IterableIterator<SomeType> = [giveMeSomeType()][Symbol.iterator]()
```
**Playground Link:** http://www.typescriptlang.org/play/#code/MYewdgzgLgBAYiEMC8MDKBPAtgIxAGwAoBKAKCgwAcBTeRAFSttQppADM6RTyn0Qs1RjRQwwAV1zUATjAA+XYdR4B6FTA4xQ46RFoBDCBEm0oAC32xzASwgx24sMCjXwWkOPwATGNOpQdMBhqa3MZLg1ZCSlpUgcnFzcAc2sAN2oAWWo0ASEmEgAufkElGABvUhgq339AmAAWACZSAF8eUEhYUKKASSgZfRx8aj6BqBBpAB4ckqYAPlEAbRT0rJm8mhIAXUXMXAIAOlCxia2SUiA
**Related Issues:** couldn't find
| Bug | low | Critical |
468,320,275 | pytorch | Difference between dropout2d and dropout3d |
## π Bug
The difference between ``Dropout2d`` and ``Dropout3d`` is not clear. They use exactly same code but different documentation. As in the documentation of ``Dropout2d`` and ``Dropout3d``, they should have different shapes of input, but it seems that they can work for inputs with other shape (dimension > 2). Should we just combine them (a generalized one)? Or at least restrict the input?
<!-- A clear and concise description of what the bug is. -->
## To Reproduce
```
torch.manual_seed(0)
m = nn.Dropout3d(p=0.2)
input = torch.randn(2, 2, 2)
output = m(input)
output
tensor([[[ 1.9262, -0.3668],
[-2.7235, 0.7105]],
[[-1.3557, -1.7482],
[ 0.5042, 1.0475]]])
torch.manual_seed(0)
m = nn.Dropout2d(p=0.2)
input = torch.randn(2, 2, 2)
output = m(input)
output
tensor([[[ 1.9262, -0.3668],
[-2.7235, 0.7105]],
[[-1.3557, -1.7482],
[ 0.5042, 1.0475]]])
```
| module: nn,triaged | low | Critical |
468,328,701 | flutter | Add support in flutter analyze for context messages | As of (https://dart-review.googlesource.com/c/sdk/+/108967) the analysis server is now sending context messages with the diagnostics it reports. They are represented as `DiagnosticMessage` objects attached to the `AnalysisError` objects returned via `analysis.errors`.
These context messages contain additional information that should help users understand the root cause of an issue. The `DiagnosticMessage` contains a textual message, but also contains a location that can be used to find a line to be displayed, support navigation, etc.
It would be great if we could get support for this feature in `flutter analyze`. | c: new feature,tool,a: quality,P3,team-tool,triaged-tool | low | Critical |
468,329,385 | TypeScript | Add a "keep-current" label for PRs that causes the bot to keep them rebased onto `master`, if possible | This way long-running PRs for experiments can get notified when they become out of date with `master`. | Infrastructure | low | Minor |
468,350,941 | go | cmd/go: go mod mvs: explain MVS selection | Actually, I'm not sure if it should be `go mod mvs`, some different subcommand, or rolled into something like `go mod why`. But, what I'd like is something like:
```
$ go mod graph
cloud.google.com/go [email protected]
cloud.google.com/go github.com/foo/[email protected]
cloud.google.com/go google.golang.org/[email protected]
google.golang.org/[email protected] [email protected]
github.com/foo/bar [email protected]
$ go mod mvs
[email protected]
[email protected]
[email protected]
[email protected]
github.com/foo/[email protected]
github.com/foo/[email protected]
google.golang.org/[email protected]
google.golang.org/[email protected]
```
I'm also not sure what the exact output should be. The above's output isn't great because it's not easily combined with things like `go mod graph`. Basically, I'm reaching for a way to get an explanation of which versions of modules were actually picked, and why they were picked. | NeedsInvestigation,FeatureRequest,GoCommand,modules | low | Minor |
468,379,028 | flutter | Update the ui_unittests harness to run Dart code. | Currently, only the `shell_unittests` and `runtime_unittests` can run Dart code. | a: tests,team,engine,P2,team-engine,triaged-engine | low | Minor |
468,379,233 | flutter | Dart tests in the engine should be able to specify dependencies. | Currently, no `pub` dependencies may be specified in engine unit-tests that use Dart. | a: tests,engine,P3,team-engine,triaged-engine | low | Minor |
468,394,071 | flutter | Creating an iOS platform view needs a way to return an error message | Right now [FlutterPlatformViewsFactory](https://github.com/flutter/engine/blob/0fa6f40fcfc1b28d5150d414c147488f3922a99b/shell/platform/darwin/ios/framework/Headers/FlutterPlatformViews.h#L41) does not allow the implemented to return an error message when creating a view. | platform-ios,framework,a: platform-views,c: proposal,a: error message,P2,team-ios,triaged-ios | low | Critical |
468,492,198 | flutter | iOS: Blank screen in running my flutter app in release mode | Currently when running my app either from the terminal through the command `flutter run -d "iPhone" --release` or directly from xcode in release mode I got blank screen, and when inspecting the logs I can find the following error.
`Runner[3296:651656] [VERBOSE-2:engine.cc(116)] Engine run configuration was invalid.
Runner[3296:651656] [VERBOSE-2:FlutterEngine.mm(294)] Could not launch engine with configuration.`
Kindly find below the output of `flutter doctor`
```
- Doctor summary (to see all details, run flutter doctor -v):
- [β] Flutter (Channel stable, v1.2.1, on Mac OS X 10.14.5 18F132, locale en-EG)
- [β] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
- [!] iOS toolchain - develop for iOS devices (Xcode 10.2.1)
- β CocoaPods not installed.
- CocoaPods is used to retrieve the iOS platform side's plugin code that
- responds to your plugin usage on the Dart side.
- Without resolving iOS dependencies with CocoaPods, plugins will not work
- on iOS.
- For more info, see https://flutter.io/platform-plugins
- To install:
- brew install cocoapods
- pod setup
- [β] Android Studio (version 3.2)
- [β] Connected device (2 available)
```
Any help would be appreciated,
thanks in advance :) | c: crash,platform-ios,tool,engine,customer: crowd,t: xcode,P2,team-ios,triaged-ios | low | Critical |
468,526,381 | electron | Disable SIG handler of AtomBrowserMainParts | <!-- As an open source project with a dedicated but small maintainer team, it can sometimes take a long time for issues to be addressed so please be patient and we will get back to you as soon as we can.
-->
### Preflight Checklist
<!-- Please ensure you've completed the following steps by replacing [ ] with [x]-->
* [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [x] I have searched the issue tracker for a feature request that matches the one I want to file, without success.
### Problem Description
<!-- Is your feature request related to a problem? Please add a clear and concise description of what the problem is. -->
There is no API to disable AtomBrowserMainParts' shutdown handlers so that OS or S/W platform already supports own signal handler.
### Proposed Solution
<!-- Describe the solution you'd like in a clear and concise manner -->
By Electron API or By native method (i.e. atom switch)
### Alternatives Considered
<!-- A clear and concise description of any alternative solutions or features you've considered. -->
### Additional Information
<!-- Add any other context about the problem here. -->
| enhancement :sparkles:,pr welcome | low | Minor |
468,541,702 | vscode | TypeScript and intellisense often randomly opens with "if" snippet selected ignoring any properties |
Issue Type: <b>Bug</b>
Declare an interface with some properties. Create a function with parameter type of that interface.
Call function with object declared inside function call. Press CTRL + SPACE and note how *usually* the intellisense prompt will open approximately half way through the options with the "if" snippet selected. The user then has to manually scroll to the top of the list in order to see the properties expected.
```ts
interface Something {
propertyOne: any,
propertyTwo: any,
};
const someFunction = (something: Something) => {};
someFunction({ <focus here and press CTRL + SPACE> });
```
The user then has to scroll to the top:
I suggest that the intellisense menu scrolls to the very top always (why is it currently in the middle, for example). TypeScript has already inferred what properties are available, so it should be a case of fixing the default selected item in the intellisense menu.
VS Code version: Code 1.36.1 (2213894ea0415ee8c85c5eea0d0ff81ecc191529, 2019-07-08T22:59:35.033Z)
OS version: Windows_NT x64 10.0.18362
<details>
<summary>System Info</summary>
|Item|Value|
|---|---|
|CPUs|Intel(R) Xeon(R) CPU E5-1650 v4 @ 3.60GHz (12 x 3592)|
|GPU Status|2d_canvas: enabled<br>flash_3d: enabled<br>flash_stage3d: enabled<br>flash_stage3d_baseline: enabled<br>gpu_compositing: enabled<br>multiple_raster_threads: enabled_on<br>native_gpu_memory_buffers: disabled_software<br>oop_rasterization: unavailable_off<br>protected_video_decode: unavailable_off<br>rasterization: unavailable_off<br>skia_deferred_display_list: disabled_off<br>skia_renderer: disabled_off<br>surface_synchronization: enabled_on<br>video_decode: enabled<br>viz_display_compositor: disabled_off<br>webgl: enabled<br>webgl2: enabled|
|Load (avg)|undefined|
|Memory (System)|15.92GB (4.16GB free)|
|Process Argv|--folder-uri <redacted>
|Screen Reader|no|
|VM|0%|
</details><details><summary>Extensions (26)</summary>
Extension|Author (truncated)|Version
---|---|---
Bookmarks|ale|10.4.4
simple-react-snippets|bur|1.2.2
npm-intellisense|chr|1.3.0
path-intellisense|chr|1.4.2
bracket-pair-colorizer-2|Coe|0.0.28
prettier-vscode|esb|1.9.0
auto-close-tag|for|0.5.6
auto-rename-tag|for|0.1.0
vscode-react-typescript|inf|1.3.0
vscode-peacock|joh|2.4.0
TypeScriptImport|kev|1.17.0
rainbow-csv|mec|1.1.1
vscode-less|mrm|0.6.3
azure-account|ms-|0.8.4
vscode-typescript-tslint-plugin|ms-|1.2.2
vetur|oct|0.21.1
vue-vscode-extensionpack|sdr|0.2.0
vue-vscode-snippets|sdr|1.7.1
ayu|tea|0.18.0
vscode-status-bar-format-toggle|tom|1.5.0
terminal-tabs|Tyr|0.2.0
highlight-matching-tag|vin|0.9.2
WebTemplateStudio-dev-nightly|WAS|0.0.1919601
vscode-import-cost|wix|2.12.0
vscode-jumpy|wma|0.3.1
JavaScriptSnippets|xab|1.7.2
(1 theme extensions excluded)
</details>
<!-- generated by issue reporter --> | snippets,suggest,editor-contrib,under-discussion | low | Critical |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.