id
int64 393k
2.82B
| repo
stringclasses 68
values | title
stringlengths 1
936
| body
stringlengths 0
256k
β | labels
stringlengths 2
508
| priority
stringclasses 3
values | severity
stringclasses 3
values |
|---|---|---|---|---|---|---|
464,402,753 | flutter | Add video_player value isDone | <!-- Thank you for using Flutter!
If you are looking for support, please check out our documentation
or consider asking a question on Stack Overflow:
* https://flutter.dev/
* https://api.flutter.dev/
* https://stackoverflow.com/questions/tagged/flutter?sort=frequent
If you have found a bug or if our documentation doesn't have an answer
to what you're looking for, then fill our the template below. Please read
our guide to filing a bug first: https://flutter.dev/docs/resources/bug-reports
-->
<!--
Please tell us the problem you are running into that led to you wanting
a new feature.
Is your feature request related to a problem? Please give a clear and
concise description of what the problem is.
Describe alternative solutions you've considered. Is there a package
on pub.dev/flutter that already solves this?
-->
Using the example code provided, the FloatingActionButton shows whether the video is paused or playing *unless the video has completed*. Then tapping it neither restarts the video, nor does anything else. I can implement some state tracking that tells me whether it was started and paused, or started and never paused, inferring from the latter that if !isPlaying then it completed.
## Proposal
<!--
Briefly but precisely describe what you would like Flutter to be able to do.
Consider attaching images showing what you are imagining.
Does this have to be provided by Flutter directly, or can it be provided
by a package on pub.dev/flutter? If so, maybe consider implementing and
publishing such a package rather than filing a bug.
-->
Add a VideoPlayerController.value.{isTheEnd | isDone | isFinished) to indicate that the video has finished playing, and is not paused. | c: new feature,p: video_player,package,c: proposal,team-ecosystem,P3,r: duplicate,triaged-ecosystem | low | Critical |
464,402,960 | terminal | Feature Request: Show tab number in tab | <!--
π¨π¨π¨π¨π¨π¨π¨π¨π¨π¨
I ACKNOWLEDGE THE FOLLOWING BEFORE PROCEEDING:
1. If I delete this entire template and go my own path, the core team may close my issue without further explanation or engagement.
2. If I list multiple bugs/concerns in this one issue, the core team may close my issue without further explanation or engagement.
3. If I write an issue that has many duplicates, the core team may close my issue without further explanation or engagement (and without necessarily spending time to find the exact duplicate ID number).
4. If I leave the title incomplete when filing the issue, the core team may close my issue without further explanation or engagement.
5. If I file something completely blank in the body, the core team may close my issue without further explanation or engagement.
All good? Then proceed!
-->
# Summary of the new feature/enhancement
<!--
A clear and concise description of what the problem is that the new feature would solve.
Describe why and how a user would use this new functionality (if applicable).
-->
Show tab number in tab. As we have hotkey `alt+number` to switch between tabs, it would be nice if we can see in advance the tab number displayed in the tab bar. #1147 asked for panes number inside a tab. This request is for the tab number.
# Proposed technical implementation details (optional)
<!--
A clear and concise description of what you want to happen.
-->
Show the tab number in tab before the tab icon.
My terminal version is : 0.2.1831.0 | Issue-Feature,Area-UserInterface,Product-Terminal | low | Critical |
464,403,549 | rust | Pin docs should mention pitfalls of generic code | The [pin module docs](https://doc.rust-lang.org/beta/std/pin/index.html) currently have a note about implementing `Future` combinators:
> When implementing a Future combinator, you will usually need structural pinning for the nested futures, as you need to get pinned references to them to call poll.
However, this can be tricky in the presence of generics. Consider this code.
```rust
use std::future::Future;
use std::task::Context;
use std::pin::Pin;
use std::task::Poll;
use std::marker::{Unpin, PhantomPinned};
mod other_mod {
use super::*;
pub enum DubiousDrop {
First(PhantomPinned),
Second(PhantomPinned)
}
impl Drop for DubiousDrop {
fn drop(&mut self) {
std::mem::forget(std::mem::replace(self, match self {
&mut DubiousDrop::First(_) => DubiousDrop::Second(PhantomPinned),
&mut DubiousDrop::Second(_) => DubiousDrop::First(PhantomPinned)
}))
}
}
impl Future for DubiousDrop {
type Output = ();
fn poll(self: Pin<&mut Self>, _cx: &mut Context) -> Poll<()> {
Poll::Ready(())
}
}
}
struct MyWrapper<F: Future<Output = ()>> {
pub fut: F
}
impl<F: Future<Output = ()>> Future for MyWrapper<F> {
type Output = ();
fn poll(self: Pin<&mut Self>, cx: &mut Context) -> Poll<()> {
// Unsound - we don't know that 'fut' upholds the
// guarantees of 'Pin'
unsafe { self.map_unchecked_mut(|s| &mut s.fut) }.poll(cx)
}
}
fn assert_unpin<T: Unpin>() {}
fn boom(cx: &mut Context) {
// Uncomment to trigger a compilation error
//assert_unpin::<MyWrapper<other_mod::DubiousDrop>>();
let mut wrapper = Box::pin(MyWrapper { fut: other_mod::DubiousDrop::First(PhantomPinned) });
Pin::new(&mut wrapper).poll(cx);
}
fn main() {}
```
Here, we have an enum `DubiousDrop`, whose destructor changes the enum variant. This type is slightly contrived but is perfectly safe (in fact, the entire containing module is safe).
We then implement a simple pass-through future combinator called `MyWrapper`, which simply delegates to a wrapped future using a pin projection. Unfortunately, `MyWrapper` is unsound - it constructs a `Pin<&mut F>` without knowing if `F` upholds the `Pin` guarantees. Our `DubiousDrop` enum explicitly does *not* uphold these guarantees - its destructor invalidates its memory by changing the enum variant, and it is not `Unpin`. Therefore, calling `boom` triggers UB in safe code.
AFAICT, there are two ways to prevent this kind of issue:
1. Require that the wrapped `Future` be `Unpin` (in this case, adding an `F: Unpin` bound to `MyWrapper`. This is the approach taken by types like [futures::future::Select](https://rust-lang-nursery.github.io/futures-api-docs/0.3.0-alpha.17/futures/future/struct.Select.html).
2. Make it unsafe to construct the wrapper/combinator type, and document that the caller must uphold the `Pin` requirements on their type.
However, none of this appears to explicitly documented, and it's fairly subtle. I think it's important for the `std::pin` and `std::pin::Pin` docs to make these requirements very clear, as it seems to be somewhat of a footgun. | C-enhancement,P-medium,T-lang,T-libs-api,A-docs,A-async-await,AsyncAwait-Triaged | low | Critical |
464,414,110 | vscode | Update detects code.exe instances from other users with seperate install folders | Two users on the same Windows machine each with their own version of VS Code installed in different folders.
Both users run VS Code, the update now button is pressed by one user and that user closes his VS Code to finish update.
Error message pops up saying that VS Code is still running, although all instances of that user's VS Code are terminated.
Confirmed that the each user's instances all originate from their own user's install folder.
Expected Results:
Users in multiple user environment with separate install folders can update normally, by checking only for running instances of code.exe that originate from the respective install location. | bug,install-update,windows | low | Critical |
464,470,357 | flutter | AnimatedList moveItem() Function. | ## Use case
When a single item changes index within an AnimatedList, the animations are janky due to the item getting removed, then inserted at another location. Instead of the item performing hero's like animation to fly to its new index.
## Proposal
I propose a method on AnimatedListState.currentState with the following signature.
moveItem(
oldIndex:
newIndex:
itemBuilder
)
oldIndex and newIndex are self explanatory. Item Builder would allow the user to rebuild the item as it is in flux between indexes, for example, to render it at decreased opacity.
The inbuilt main Item Builder could be called once settled in the new Index. Perhaps the Animation parameter could be Zeroed or an optional parameter wasMoved provided to the main itemBuilder to allow it to know When the Animation does not need to be driven..
I will be trying to implement this on top of AnimatedList soon. So hopefully will be able to update with a clearer idea of the implementation and possible pit falls | c: new feature,framework,a: animation,P3,team-framework,triaged-framework | high | Critical |
464,483,096 | go | runtime: raising the number of GOMAXPROCS cause oom | <!-- Please answer these questions before submitting your issue. Thanks! -->
### What version of Go are you using (`go version`)?
<pre>
$ go version
go version go1.12.1 linux/amd64
</pre>
### Does this issue reproduce with the latest release?
yes
### What operating system and processor architecture are you using (`go env`)?
<details><summary><code>go env</code> Output</summary><br><pre>
$ go env
$ go env
GOARCH="amd64"
GOBIN="/home/zhoudazhuang/gobin/"
GOCACHE="/home/zhoudazhuang/.cache/go-build"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/home/zhoudazhuang/db11/jm/pro"
GOPROXY=""
GORACE=""
GOROOT="/home/zhoudazhuang/usr/local/go1.12.1/go"
GOTMPDIR=""
GOTOOLDIR="/home/zhoudazhuang/usr/local/go1.12.1/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build631445118=/tmp/go-build -gno-record-gcc-switches"
</pre></details>
### What did you do?
Raising the number of GOMAXPROCS from 32 to 512.
I have 32 pysical cpu cores.
Because the gc make my server cosing lots of the time. And the idle cpu is much.
So I want to improve the gc performance throught GOMAXPROCS.
But I faild, I got the result that gc cost more time and the server cost more memory.
Even oom finally.
And it seem a long time stw but not from the gc.
runtime scheduler also cause the stw?
Why the memory is rasing ,finnally oom ?
<!--
If possible, provide a recipe for reproducing the error.
A complete runnable program is good.
A link on play.golang.org is best.
-->
### What did you expect to see?
no oom
### What did you see instead?
oom
| NeedsInvestigation,compiler/runtime | low | Critical |
464,527,196 | rust | allow(deprecated) is too coarse-grained, should take a path | https://github.com/rust-lang/rust/commit/007d87f1719e2fcf2ff36aef8b6dc866fa276386 added `allow(deprecated)` in a few places because `mem::uninitialized` is still used. Unfortunately, this allows *all* deprecated items, so by the time someone gets around to fix that, other uses of deprecated items could have crept in.
It would be much better if that could be `allow(deprecated(mem::uninitialized))` or so, to *only* allow the one method without also allowing everything else.
The same applies to `deprecated_in_future`.
I think I saw @Mark-Simulacrum ask for this somewhere recently? Or was it someone else? | A-frontend,A-attributes,A-lints,T-lang,C-feature-request,needs-rfc,L-deprecated | medium | Major |
464,535,244 | create-react-app | react-scripts test --onlyChanged always runs ALL tests instead of only the changed tests, yarn jest --onlyChanged works as expected. | ### Describe the bug
If I run **yarn jest -o**, jest attempts to run 18 tests (out of the 158 in total).
If I run **yarn react-scripts test -o**, jest attempts to run all tests.
If I edit /node_modules/react-scripts/scripts/test.js so that only the following options are passed to Jest: "argv [ '-o' ]" Jest will still attempt to run all the tests so this doesn't seem like a configuration issue.
### Did you try recovering your dependencies?
Yes, 1.16.0
### Which terms did you search for in User Guide?
Jest, --watch, --onlyChanged, -o
### Environment
```
Environment Info:
System:
OS: macOS High Sierra 10.13.6
CPU: (4) x64 Intel(R) Core(TM) i5-7360U CPU @ 2.30GHz
Binaries:
Node: 12.5.0 - ~/.nvm/versions/node/v12.5.0/bin/node
Yarn: 1.16.0 - /usr/local/bin/yarn
npm: 6.9.2 - ~/.nvm/versions/node/v12.5.0/bin/npm
Browsers:
Chrome: Not Found
Firefox: Not Found
Safari: Not Found
npmPackages:
babel-plugin-named-asset-import: 0.3.2
babel-preset-react-app: 9.0.0
confusing-browser-globals: 1.0.7
create-react-app: 3.0.1
eslint-config-react-app: 4.0.1
react: 16.8.6 => 16.8.6
react-app-polyfill: ^0.2.2 => 1.0.1
react-dev-utils: 9.0.1
react-dom: 16.8.6 => 16.8.6
react-error-overlay: 5.1.6
react-scripts: 3.0.1
npmGlobalPackages:
create-react-app: Not Found
```
We're using Typescript.
### Steps to reproduce
I understand that this is hard to reproduce, I'm willing to debug this issue if someone could help me to get started with this issue.
### Expected behavior
If I run **yarn react-scripts test -o**, runs only the relevant tests.
### Actual behavior
If I run **yarn react-scripts test -o**, jest attempts to run all tests.
### Reproducible demo
Will attempt to create one. | issue: bug,issue: needs investigation | low | Critical |
464,558,177 | TypeScript | False positive error report for interface type missing index signature, thus not assignable to object type with `unknown` values. | <!-- π¨ STOP π¨ π¦π§π’π£ π¨ πΊπ»πΆπ· π¨
Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Even if you think you've found a *bug*, please read the FAQ first, especially the Common "Bugs" That Aren't Bugs section!
Please help us by doing the following steps before logging an issue:
* Search: https://github.com/Microsoft/TypeScript/search?type=Issues
* Read the FAQ: https://github.com/Microsoft/TypeScript/wiki/FAQ
Please fill in the *entire* template below.
-->
<!-- Please try to reproduce the issue with `typescript@next`. It may have already been fixed. -->
**TypeScript Version:** 3.6.0-dev.20190704 (`3.4.3` doesn't have this bug)
<!-- Search terms you tried before logging this (so others can find this issue more easily) -->
**Search Terms:**
index signature, unknown, assignable, interface
**Code**
```ts
interface A {
properties?: { [Key: string]: unknown };
}
type Bar = {
key?: "value";
};
interface Baz {
key?: "value";
}
interface B extends A { // ok
properties?: Bar;
}
interface C extends A { // error: Baz is not assignable to { [Key: string]: unknown } -> Index signature is missing
properties?: Baz;
}
```
**Expected behavior:**
No error expected, interface C extends A correctly.
**Actual behavior:**
Error because interface C does not extend interface A
**Playground Link:** <!-- A link to a TypeScript Playground "Share" link which demonstrates this behavior -->
http://www.typescriptlang.org/play/#code/JYOwLgpgTgZghgYwgAgILIN4ChnIA5QD2e0YwEAzgPwBcmyA2gNIQCedFYUoA5gLp0AriADWIQgHcQyAL4BuLDKxYwrEsgBCcKMgC8mHMhFtayAEQA3OABtBEMwvnLQkWIhRaAXgdzHWpyxs7B0VncGh4JE1kCAAPSBAAEwo0egB6NORCEUMCYlJyajotKEcw10iUAGEY+IgklPQMZAyYqCIoYrhvYBTxMGQ4CgpgHhA4ACNrFDBCemY2Di5eAWRhMUlpGWQAWgA+ZABJJLjkEbG4MEEoFF7kAFtekZAeXKISKDJKUy8yoA
**Related Issues:** <!-- Did you find other bugs that looked similar? -->
#30977 (this one is specifically for `enums`)
| Docs | low | Critical |
464,586,322 | rust | `const fn` allows unreachable calls to non-`const` fns | E.g. the following compiles on stable:
```rust
const fn f() {
return;
fn f() {}
f();
}
```
@eddyb notes that this is because we do a "semantic check" and that `f();` is not linked in the CFG.
However, it seems to me that the basic blocks should be there (tho I haven't checked yet...) so you can visit the call to `f();` and ban it.
cc @oli-obk | T-lang,T-compiler,C-bug,A-const-eval | low | Minor |
464,587,734 | go | cmd/go/internal/modfetch: treat malformed versions as βnot foundβ on the proxy path | For Go 1.11 and 1.12, I have in my `go.mod` something like:
```go
replace (
github.com/lxn/walk => golang.zx2c4.com/wireguard/windows pkg/walk
github.com/lxn/win => golang.zx2c4.com/wireguard/windows pkg/walk-win
)
```
I use this to indicate that usage of `github.com/lxn/walk` should be replaced with the latest contents of a branch called `pkg/walk` from `golang.zx2c4.com/wireguard/windows`.
With 1.13beta1, this now breaks with a message:
```
/home/zx2c4/Projects/wireguard-windows/go.mod:16: replace golang.zx2c4.com/wireguard/windows: version "pkg/walk" invalid: version "pkg/walk" invalid: disallowed version string
/home/zx2c4/Projects/wireguard-windows/go.mod:17: replace golang.zx2c4.com/wireguard/windows: version "pkg/walk-win" invalid: version "pkg/walk-win" invalid: disallowed version string
```
This poses a significant problem. | NeedsDecision,modules | high | Critical |
464,612,030 | flutter | Flutter Material Tree Widget | <!-- Thank you for using Flutter!
If you are looking for support, please check out our documentation
or consider asking a question on Stack Overflow:
* https://flutter.dev/
* https://api.flutter.dev/
* https://stackoverflow.com/questions/tagged/flutter?sort=frequent
If you have found a bug or if our documentation doesn't have an answer
to what you're looking for, then fill our the template below. Please read
our guide to filing a bug first: https://flutter.dev/docs/resources/bug-reports
-->
## Use case
<!--
Please tell us the problem you are running into that led to you wanting
a new feature.
Is your feature request related to a problem? Please give a clear and
concise description of what the problem is.
Describe alternative solutions you've considered. Is there a package
on pub.dev/flutter that already solves this?
-->
I would like to see Flutter Material Tree Widget officially supported.
A tree that can be used to display hierarchy data.
## Proposal
<!--
Briefly but precisely describe what you would like Flutter to be able to do.
Consider attaching images showing what you are imagining.
Does this have to be provided by Flutter directly, or can it be provided
by a package on pub.dev/flutter? If so, maybe consider implementing and
publishing such a package rather than filing a bug.
-->
https://material.angular.io/components/tree/examples
| c: new feature,framework,f: material design,P2,team-design,triaged-design | low | Critical |
464,620,102 | rust | O(1) time {Vec,VecDeque}::truncate for trivial drop types and VecDeque::truncate_front | Currently both `Vec`s and `VecDeque`s `truncate` implementations just call `pop_back()` in a loop. When `std::mem::needs_drop::<T>()` is `false` this is pretty inefficient.
Now LLVM *does* [optimize away the loop on `-O3` for `Vec::truncate`](https://rust.godbolt.org/z/WBV3MA), however [this does not happen for `VecDeque::truncate`](https://rust.godbolt.org/z/80GGwx).
Despite [previous complaints](https://github.com/rust-lang/rust/issues/17633#issuecomment-451707138), this exact issue has been [wont-fix](https://github.com/rust-lang/rust/pull/57949#issuecomment-458286725)'d under the unofficial policy that we do not include -O0 exclusive optimizations in rust.
I would like to re-open the discussion with the following observations, in the hope that @alexcrichton might change his mind:
1. No matter the optimization level, the optimization *never* happens for `VecDeque::truncate`.
2. The optimization is not just a constant factor speedup, it's an asymptotic speedup changing an O(n) time operation into O(1) where O(1) could easily be guaranteed. The difference in speed could literally be several orders of magnitude.
3. The optimizer is always fickle and ever-changing. Someone designing an algorithm using default Rust building blocks needs to rely on at least asymptotic complexities not suddenly regressing due to the optimizer not catching some pattern. Updating your Rust compiler should never have a chance to turn an O(n) algorithm into an O(n^2) one.
4. It pushes people towards unsafe code. In the linked complaint above the user ended up using the unsafe `set_len` when the safe `truncate` could've exactly done the job.
In addition to the above, `VecDeque` has `truncate`, but is missing `truncate_front`. If we make these truncate operations O(1) time it should also get a `truncate_front` operation.
Without these changes it is impossible to implement certain algorithms using the default Rust collections for no particular good reason. For example, if I have a `v: VecDeque<f64>` that keeps its elements sorted, it is currently impossible to write a O(log n) time routine that removes all elements less than `x` in `v`. We can find how many elements we need to remove from the front in O(log n) time, but removing them needlessly take O(n) time. | I-slow,C-enhancement,T-libs-api,C-optimization | low | Major |
464,634,676 | rust | Add a way to signal that a snippet is UB/bad in rustdoc | Reading the docs for [MaybeUninit](https://doc.rust-lang.org/std/mem/union.MaybeUninit.html) I noticed that the code snippets that contain code that lead to UB are only identified by comments inside the snippet. This feels like a potential source of copy-paste errors. Maybe there could be a way to highlight a code snippet in a bright red or something to make readers wary that this code should never be used? | T-rustdoc,C-enhancement,C-feature-request | low | Critical |
464,668,710 | flutter | MethodChannel - introduce a way to test it | ## Use case
Writing some tests for a plugin i found that is impossible to test methods that make uses of MethodChannel class.
Looking through Flutter MethodChannel documentation i found that
> Method calls are encoded into binary before being sent, and binary results received are decoded into Dart values.
So i think that the impossibility to test these methods, that uses MethodChannel class, is because the binary is not available while executing test cases.
Test case result will be something like this:
```
package:flutter/src/services/platform_channel.dart 314:7 MethodChannel.invokeMethod
===== asynchronous gap ===========================
dart:async _AsyncAwaitCompleter.completeError
package:flutter/src/services/platform_channel.dart MethodChannel.invokeMethod
===== asynchronous gap ===========================
dart:async _asyncThenWrapperHelper
package:flutter/src/services/platform_channel.dart MethodChannel.invokeMethod
package:flutter_opencv/src/core/scalar.dart 34:34 Scalar.set
MissingPluginException(No implementation found for method set on channel flutter_opencv)
```
I tried running the app while executing tests in debug mode with no success.
I tried duplicating the plugin, changing his name and importing it in the original plugin but it doesn't work.
I found that we can mock method channel method but is not always easy replicating the result of the Method call.
## Proposal
I have no idea how to solve this, but it would be nice if we can achieve, in some way this feature, to make the plugin code more strong and stable.
| a: tests,engine,dependency: dart,a: platform-views,c: proposal,P2,team-engine,triaged-engine | low | Critical |
464,683,966 | pytorch | Eigen Tensor library for convolutions on CPU | ## π Feature
Add option of Eigen Tensor library implementation of convolution on ARM CPU
## Motivation
While convolutions on Intel CPUs are quite fast, there are issues on ARM processors. I tried NNPack which speeds up the default implementation. However TensorFlow is much faster on Raspberry, and also NNabla. The underlying library is Eigen Tensor library which often is even better than ARM compute library.
cc @VitalyFedyunin @ngimel @mruberry | module: performance,module: cpu,module: convolution,triaged,module: arm,function request | low | Minor |
464,728,583 | node | Missing lines when using readline Interface as AsyncIterable | <!--
Thank you for reporting a possible bug in Node.js.
Please fill in as much of the template below as you can.
Version: output of `node -v`
Platform: output of `uname -a` (UNIX), or version and 32 or 64-bit (Windows)
Subsystem: if known, please specify the affected core module name
If possible, please provide code that demonstrates the problem, keeping it as
simple and free of external dependencies as you can.
-->
* **Version**: v12.6.0
* **Platform**: Darwin Admins-MacBook-Pro-6.local 18.6.0 Darwin Kernel Version 18.6.0: Thu Apr 25 23:16:27 PDT 2019; root:xnu-4903.261.4~2/RELEASE_X86_64 x86_64
* **Subsystem**: readline
<!-- Please provide more details below this comment. -->
We were using `readline` to convert a stream that gives bytes to an `AsyncIterable` of lines. We did this by using something like:
```ts
const iterableOfLines = readline.createInterface({ input: streamOfBytes })
```
We would then use this as an `AsyncIterable` (which looks like it [should be supported](https://github.com/nodejs/node/commit/2a7432dadec08bbe7063d84f1aa4a6396807305c)) and write it to a file, but there would sometimes be lines missing. The number of lines missing was inconsistent and we couldn't identify any patterns relating the lines that were missing. They were not different from the rest in any way, they were not always the first or last lines, etc.
Unfortunately, it's hard for me to tell you more because we were unable to write an isolated test that would reliably show this behavior (we noticed it in production).
We are confident that the bug is in `readline` because we replaced the use of it with our own custom function that would convert the bytes to lines, and we consistently get all of the lines every time. | readline | low | Critical |
464,730,073 | flutter | Create public getter for the "messenger" field of methodChannel java class. | ## Use case
We are trying to move from full native to full flutter.
We have a feature that work on android by using foreground service, the ios guy might have the same issue.
While the app's in use i register the plugin with the current flutter native view, pluginRegistry.
When the app is in background i create a flutter native view with background parameter as true.
my method channels are inside of a list, because i may want to have a foreground callback and background callback handling result from the native side.
## Proposal
when i receive the onViewDestroyed callback from PluginRegistry.ViewDestroyListener, i want to get the messenger field of the methodChannel so i can remove the method channel that's no longer of use. but the messenger field is private.
Can we make it public ? | c: new feature,engine,a: platform-views,c: proposal,P3,team-engine,triaged-engine | low | Minor |
464,760,949 | pytorch | CPU torch.exponential_ function may generate 0 which can cause downstream NaN | ## π Bug
torch.exponential_ on the CPU has a small (2^-53) chance of generating 0.
I don't think we document whether torch.exponential_ may return 0, but both the [NumPy](https://docs.scipy.org/doc/numpy/reference/generated/numpy.random.exponential.html) and [TF](https://www.tensorflow.org/api_docs/python/tf/distributions/Exponential) documentation pages don't allow for zero. This is convenient for downstream uses, such as Gumbel-softmax.
The CPU exponential generation function computes `-log(1-uniform())` (always in double-precision). The result is then rounded to the desired data type (e.g. float).
https://github.com/pytorch/pytorch/blob/042da2171e95ae5cf39452ae17a5000a5a24eb85/aten/src/ATen/core/DistributionsHelper.h#L209-L212
If `sample` is `0`, then `log(1.0 - sample)` is also `0`. Note that `sample=1` is also not allowed.
The CUDA generator doesn't have this issue because it shifts the probability mass around zero to log(1-eps).
Related to https://github.com/pytorch/pytorch/issues/22442.
## To Reproduce
I haven't reproduced this behavior. It would be nice to have specific bitstreams for RNG testing that always return specific sequences (such as 0) to test for this sort of behavior. | triaged,module: random | low | Critical |
464,764,976 | go | x/crypto/ssh: add NewControlClientConn | **Update, 23 Feb 2022**: The new API is https://github.com/golang/go/issues/32958#issuecomment-1034079379.
---
<!-- Please answer these questions before submitting your issue. Thanks! -->
### What version of Go are you using (`go version`)?
<pre>
$ go version
go version go1.12.6 linux/amd64
</pre>
### Does this issue reproduce with the latest release?
Yes
### What operating system and processor architecture are you using (`go env`)?
<details><summary><code>go env</code> Output</summary><br><pre>
$ go env
GOARCH="amd64"
GOBIN=""
GOCACHE="/tmp/bazel_shared/gocache"
GOEXE=""
GOFLAGS="-mod=readonly"
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/tmp/bazel_shared/gopath"
GOPROXY="direct"
GORACE=""
GOROOT="/home/cy/.cache/bazel/_bazel_cy/80b33c882b53d18473a4d1179c663f81/external/go_sdk"
GOTMPDIR=""
GOTOOLDIR="/home/cy/.cache/bazel/_bazel_cy/80b33c882b53d18473a4d1179c663f81/external/go_sdk/pkg/tool/linux_amd64"
GCCGO="gccgo"
CC="gcc"
CXX="g++"
CGO_ENABLED="0"
GOMOD="/home/cy/.cache/bazel/_bazel_cy/80b33c882b53d18473a4d1179c663f81/execroot/goslackgo/bazel-out/k8-fastbuild/bin/go.runfiles/goslackgo/go_gocmd_execroot/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build807263343=/tmp/go-build -gno-record-gcc-switches"
</pre></details>
### Proposal: Feature Request
I propose a modification to the x/crypto/ssh library that would allow an application to use this library's implementation of the SSH Connection Protocol (RFC 4254), but provide a separate implementation of the SSH Transport Protocol (RFC 4253).
Concretely this would require adapting the existing `packetConn` interface and exporting it, and then adding a Client constructor that operated on this interface:
<pre>
type Transport interface {
WritePacket([]byte) error
ReadPacket() ([]byte, error)
Close() error
}
func NewClientFromTransport(t Transport) (Conn, <-chan NewChannel, <-chan *Request, error)
</pre>
My immediate use case for this is to implement an application that uses an OpenSSH ControlMaster socket as the transport. However, I can imagine other use cases for this. This proposal is an alternative to https://github.com/golang/go/issues/31874.
| Proposal,Proposal-Accepted,Proposal-Crypto | medium | Critical |
464,792,061 | opencv | Error when call InputArray.getMat() obtained from vector<vector<double>> | OpenCV 3.4.4
OS: Ubuntu 19.04
Code:
```
vector<vector<double>> vv = {{1, 1, 0},
{1, -1, 0},
{-1, -1, 0},
{-1, 1, 0}};
InputArray ia(vv);`
cout << ia.getMat() << endl;`
```
Error:
```
terminate called after throwing an instance of 'cv::Exception'
what(): OpenCV(3.4.4) /home/victor/development/opencv/modules/core/src/matrix_wrap.cpp:79:
error: (-215:Assertion failed) 0 <= i && i < (int)vv.size() in function 'getMat_'
``` | category: core,category: build/install | low | Critical |
464,808,447 | flutter | No clear way to get the number of lines from a Paragraph | If I have some text like this:
```
final text = 'My text line.\nThis ΩΩΩ
Ψ© makes more boxes.\nAnother line.';
```
And when I create a Paragraph (indirectly using TextPainter), then I get something like this:
<img width="304" alt="Screen Shot 2019-07-05 at 6 17 09 PM" src="https://user-images.githubusercontent.com/10300220/60750117-c4405680-9f58-11e9-9d1b-400a1fdb7592.png">
I want to programmatically get the number of lines (and the text in each line). But there is no method for that. There obviously are 4 lines and the engine must know that. Is there a reason that it is hidden from the developer?
My use case is creating a [vertical text layout](https://stackoverflow.com/questions/56782788/vertical-text-widget-for-flutter) where I have to reposition and paint each line myself.
Related Stack Overflow issue: https://stackoverflow.com/questions/54091055/flutter-how-to-get-the-number-of-text-lines | c: new feature,framework,a: typography,P3,team-framework,triaged-framework | low | Minor |
464,819,665 | godot | File Dialog modal closes on hidden file toggle keyboard shortcut after item selected and deselected | <!-- Please search existing issues for potential duplicates before filing yours:
https://github.com/godotengine/godot/issues?q=is%3Aissue
-->
This issue also causes the editor to stay darkened once the modal is closed as per issue #30368
**Godot version:**
<!-- Specify commit hash if non-official. -->
d897131ac555de84afe9ca6845abf87c26957895
**OS/device including version:**
<!-- Specify GPU model and drivers if graphics-related. -->
Arch Linux
**Issue description:**
<!-- What happened, and what was expected. -->
File Dialog modal closes on hidden file toggle keyboard shortcut after item selected and deselected. Expected behavior is a toggle that shows hidden files.
**Steps to reproduce:**
1. Cause the file dialog to open, e.g press load on an empty texture property in a sprite
2. Click on a file in the manager
3. Click on the empty space in the directory, deselecting the file
4. Press the CTRL + H shortcut to toggle visibility of hidden files
The file dialog disappears and the editor stays darkened.
**Minimal reproduction project:**
<!-- Recommended as it greatly speeds up debugging. Drag and drop a zip archive to upload it. -->
[godot-darkened-after-dialog-shortcut.zip](https://github.com/godotengine/godot/files/3364432/godot-darkened-after-dialog-shortcut.zip)
| bug,topic:editor,confirmed | low | Critical |
464,821,004 | vscode | The `cursorWordPart`* commands are limited to editor text, unlike the other `cursorWord`* commands | - VSCode Version: 1.36.0 (system setup)
- OS Version: Windows_NT x64 10.0.18362
Steps to Reproduce:
1. Focus on a non-editor input text field (e.g. execute the command `workbench.action.quickOpen` or `actions.find`, inter alia)
2. Insert the text of the multi-part word "fooBar".
3. Move the cursor to the end of the multi-part word text.
4. Enter your keybinding for the command `cursorWordPartLeft`.
Expected behavior:
* Cursor moves to between "foo" and "Bar", i.e. `foo|Bar`.
Actual behavior:
* No effect.
Notes:
* This limitation appears in all `inputText` contexts other than the `editorText` context.
* This limitation affects all the `cursorWordPart`* commands:
* `cursorWordPartLeft`
* `cursorWordPartLeftSelect`
* `cursorWordPartRight`
* `cursorWordPartRightSelect`
* `cursorWordPartStartLeft`
* `cursorWordPartStartLeftSelect`
* The corresponding whole-word commands (those without the "Part" infix) are not limited, i.e. they function in `inputText` contexts other than the `editorText` context.
Does this issue occur when all extensions are disabled?: Yes
| feature-request,editor-find | medium | Critical |
464,838,569 | material-ui | [docs-infra] Improve Algolia internal search results on mui.com | Listing various points that could be improved for searching our docs. Also documenting unhelpful search results. It's not about implementing all of those but exploring how viable they are or if they have better alternatives.
### Opportunities
- [x] 1. Be able to search inside the content of the page, not just headers.
- [x] 2. Broken UI on blog post, e.g. https://mui.com/blog/v6-beta-pickers/. The style loading logic is broken. mui/material-ui#33731
- [ ] 3. Easy switch between projects, e.g. https://www.mux.com/blog/the-building-blocks-of-great-docs https://github.com/mui/material-ui/issues/41541
<img width="251" alt="Screenshot 2023-02-13 at 22 19 42" src="https://user-images.githubusercontent.com/3165635/218576918-5d41eefa-1a5f-48e0-8cea-6e300040c3a3.png">
or https://twitter.com/delba_oliveira/status/1664323492077256704
- [ ] 4. The search bar in the header blinks when changing pages. This shouldn't happen.
- [x] 5. Remove the `#main-content` noise. Reproduction: search for Alert
<img width="752" alt="Screenshot 2022-06-16 at 12 37 37" src="https://user-images.githubusercontent.com/3165635/191579759-e94b0758-04d5-4ad1-9fb8-097479d761b1.png">
You land on [https://mui.com/material-ui/react-alert/#main-content](https://mui.com/material-ui/react-alert/#main-content). There are tons of links like this in Stack Overflow, we can do better, the UX is confusing, no, it doesn't link an h2, it's the h1.
Fixed by adding:
```js
$("#main-content, #__next").removeAttr("id");
```
In the crawler logic (https://crawler.algolia.com/admin/crawlers/739c29c8-99ea-4945-bd27-17a1df391902/configuration/edit).
- [ ] 6. Implement OpenSearch mui/material-ui#29445
- [x] 7. Index MUI X. e.g. https://mui.com/x/introduction/licensing/ and related pages. It would solve https://github.com/mui/mui-x/pull/5074#discussion_r898210356
- [x] 8. Index MUI System e.g. https://mui.com/system/getting-started/overview/ and related pages. It would solve https://www.algolia.com/apps/TZGZ85B9TB/analytics/no-results/material-ui?from=2022-09-14&to=2022-09-20.
- [x] 9. Move the `product` attribute from the crawler configuration https://crawler.algolia.com/admin/crawlers/739c29c8-99ea-4945-bd27-17a1df391902/configuration/edit to the page, e.g. https://github.com/mui/material-ui/blob/29fd59e746b9d7ceec2e692e26f08bc3fd6c566a/docs/data/joy/components/alert/alert.md?plain=1#L2. It would be simpler. For example, from a docs versioning perspective, it's painful to have to come to Algolia's Crawler to make a change to have things keep working.
- [x] 10. Index MUI Toolpad, e.g. https://mui.com/toolpad/getting-started/overview/
- [ ] 11. Fix moving scrollbar when opening the search (you can test on Windows)
- [ ] 12. Migrate the UI to https://github.com/mui/mui-x/issues/13932
- [x] 13. Duplicate lang property https://www.algolia.com/apps/TZGZ85B9TB/explorer/browse/material-ui?page=1&searchMode=objectID
<img width="238" alt="Screenshot 2022-09-21 at 20 23 35" src="https://user-images.githubusercontent.com/3165635/191581669-c4df93cd-3335-4fcf-9396-615f0159b2be.png">
Likely a conflict between
https://github.com/mui/material-ui/blob/29fd59e746b9d7ceec2e692e26f08bc3fd6c566a/docs/src/modules/components/Head.tsx#L58
and https://docsearch.algolia.com/docs/record-extractor#indexing-content-for-faceting
- [ ] 14. Move `popularity` and `pageRank` configuration from the Crawler UI to the markdown pages.
- [x] 15. Use [`analyticsTags`](https://www.algolia.com/doc/api-reference/api-parameters/analyticsTags/?client=javascript) to so that each product team can filter the analytics in the Algolia admin
<img width="861" alt="Screenshot 2022-09-27 at 12 04 34" src="https://user-images.githubusercontent.com/3165635/192497576-5fca9bb5-87ec-4ca7-b266-c7a522e55163.png">
Fixed in mui/material-ui#37600
- [ ] 16. Implement click analytics to measure the impact of search ranking changes https://github.com/algolia/docsearch/issues/1045
### Fix unhelpful results
- [x] "FilledInput" (top 5 results link to /api/filled-input page)
- [x] "material tabs" | enhancement,scope: docs-infra | low | Critical |
464,843,736 | godot | Error messages when plugins are faulty not normally shown | **Godot version:**
3.1.1
**OS/device including version:**
N/A
**Issue description:**
Related to https://github.com/jebedaia360/Rakugo/issues/153
Attempting to set up Rakugo with Godot, I noticed the plugin.gd script does not work. However by default Godot does not report *why* it failed; it does not tell you what the errors are, unless you are running Godot from the terminal.
*From inside Godot*
*From the terminal*
```
SCRIPT ERROR: GDScript::reload: Parse Error: Identifier 'Rakugo' is not declared in the current scope.
At: res://addons/Rakugo/nodes/rakugo_menu.gd:12.
ERROR: reload: Method/Function Failed, returning: ERR_PARSE_ERROR
At: modules/gdscript/gdscript.cpp:580.
SCRIPT ERROR: GDScript::reload: Parse Error: Could not fully preload the script, possible cyclic reference or compilation error. Use 'load()' instead if a cyclic reference is intended.
At: res://addons/Rakugo/plugin.gd:65.
ERROR: reload: Method/Function Failed, returning: ERR_PARSE_ERROR
At: modules/gdscript/gdscript.cpp:580.
SCRIPT ERROR: GDScript::reload: Parse Error: Identifier 'Rakugo' is not declared in the current scope.
At: res://addons/Rakugo/nodes/rakugo_menu.gd:12.
ERROR: reload: Method/Function Failed, returning: ERR_PARSE_ERROR
At: modules/gdscript/gdscript.cpp:580.
SCRIPT ERROR: GDScript::reload: Parse Error: Could not fully preload the script, possible cyclic reference or compilation error. Use 'load()' instead if a cyclic reference is intended.
At: res://addons/Rakugo/plugin.gd:65.
ERROR: reload: Method/Function Failed, returning: ERR_PARSE_ERROR
At: modules/gdscript/gdscript.cpp:580.
```
**Steps to reproduce:**
Use an addon with a plugin.gd that has an error of some kind.
**Minimal reproduction project:**
In this case, I was using https://github.com/jebedaia360/Rakugo/commit/33b09b6685289f0e3aabf0254064a76b814575c7 | bug,topic:editor,confirmed,usability,topic:plugin | low | Critical |
464,854,120 | rust | Build with clean incremental cache slower than without incremental compilation | ```
$ rustc -V
rustc 1.36.0 (a53f9df32 2019-07-03)
$ git clone https://github.com/bjorn3/fractals
$ cd fractals
$ git checkout 0c4929c80c55cadf3a2576f288bfde463ffb8e18
$ cargo build # build deps
$ # build without incr comp
$ touch src/main; CARGO_INCREMENTAL=0 cargo build
Compiling fractals v0.1.0 (/home/bjorn/Documenten/fractals)
Finished dev [unoptimized + debuginfo] target(s) in 2.74s
$ # incremental cache was thrown away by the previous command; rebuild it
$ touch src/main.rs; CARGO_INCREMENTAL=1 cargo build
Compiling fractals v0.1.0 (/home/bjorn/Documenten/fractals)
Finished dev [unoptimized + debuginfo] target(s) in 13.47s
$ # incremental cache exists. yet the build is slower than without incr comp
$ touch src/main.rs; CARGO_INCREMENTAL=1 cargo build
Compiling fractals v0.1.0 (/home/bjorn/Documenten/fractals)
Finished dev [unoptimized + debuginfo] target(s) in 4.45s
``` | I-compiletime,T-compiler,A-incr-comp,C-bug | low | Critical |
464,856,984 | TypeScript | Allow Inifinity and -Infinity as number literal types | Please accept `Infinity` and `-Infinity` as valid number literal types.
```ts
/** A range of BigInt that may be unbounded, e.g., (-β, 5] */
class BigIntRange {
public min: bigint | -Infinity = 0n; // <= Error!
public max: bigint | Infinity = 1n; // <= Error!
public isValid(): boolean {
return this.min <= this.max;
}
}
```
Currently, This causes a compile error, `'Infinity' refers to a value, but is being used as a type here. (2749)`.
I understand this was once rejected as part of #15135 and #15356, and the given reasons were: 1) difficult to implement, and 2) lacks a compelling use case.
However, while I understand why `NaN` as a literal type is tricky to implement, `NaN` and `Infinity` are not the same. And I have a clear use case for `Infinity` as a meaningful literal type, as shown above.
### Infinity is not tricky to compare
Unlike notorious `NaN` or `-0`, `Infinity` works **just like an ordinary numeric constant** as far as equality is concerned. We don't need a special function like `isNaN()` or `Object.is()`. Ever since the ES5/IE6 era, there has been nothing counter-intuitive:
```ts
Infinity === Infinity // => true
-Infinity === -Infinity // => true
Number.POSITIVE_INFINITY === Infinity // => true
Object.is(-Infinity, Number.NEGATIVE_INFINITY) // => true
10 ** 500 === Infinity // => true (because 10**500 is above Number.MAX_VALUE)
typeof Infinity === 'number' // => true
typeof Number.NEGATIVE_INFINITY === 'number' // => true
// FWIW, comparison works just as expected, too
50 < Infinity // => true
-Infinity < 50; // => true
10n ** 500n < Infinity // => true
Number.MAX_VALUE < Infinity // => true
Infinity < Infinity // => false
```
Most importantly, `Infinity === Infinity` is true (while `NaN === NaN` is false). Unless I'm missing something, predictable equality is all that's required to safely use `Infinity` as a literal type, right? Even though the design note (#15356) says "there is more than one NaN, Infinity, etc", you can think of `Infinity` in JavaScript as "just a fixed number" which happens to be larger than `Number.MAX_VALUE`.
### My use case
[My library](https://www.npmjs.com/package/multi-integer-range) deals with unbounded (aka infinite) integer ranges, and I have been using `Infinity` and `-Infinity` without any issue to denote what they literally mean, _infinity in the mathematical sense_. I have instructed my users to use these interesting constants, too. Recently I started to extend my library to support `bigint` in addition to `number`, and ran into this problem.
You may ask "Why don't you just use string `'Infinity'` or `Symbol('unbounded')`", but `Infinity` is a predefined and predictable constant, and it can be directly compared with any bigint (e.g., `10n ** 1000n < Infinity` is `true`). See how simple the implementation of `isValid` can be in the first example.
PS: Looks like there is a hacky workaround (#31752), but I'd like to see the official support. | Suggestion,Awaiting More Feedback | high | Critical |
464,859,986 | rust | Unnecessary copy when constructing arrays from returned arrays? | I want to construct a big array by concatenating smaller arrays returned by other functions. As a simple example:
```rust
pub fn g(f: &Fn() -> [u64;40]) -> [u64;80] {
let a = f();
let b = f();
let mut ret = [0u64;80];
ret[0..40].copy_from_slice(&a[..]);
ret[40..80].copy_from_slice(&b[..]);
ret
}
```
Rust nightly [generates a call to memcpy](https://godbolt.org/z/XeVwFj).
Is there a way to prevent this memcpy? Am I missing obvious other way to write this function?
Of course one could rewrite the called function `f` to take a `&mut [u64]` instead of returning the array, but that removes compile-time checks on the length and introduces bounds checks. Using `&mut [u64;40]` as an "out" argument solves that problem, but then I don't see a safe way to get two `&mut [u64;40]` into `[u64;80]` without using `transmute`.
(Background: I'm implementing the XMSSMT hash-based signature in Rust, which involves concatenating lots of hashes. The [usual Rust hash library](https://github.com/RustCrypto/hashes) returns an array (actually a `GenericArray`) instead of using a `&mut [u64;...]` parameter which led me to believe that the copy could be optimised away.) | A-LLVM,I-slow,C-enhancement,T-compiler,A-mir-opt,A-mir-opt-nrvo,C-optimization | medium | Major |
464,860,502 | rust | build fails with error[E0463]: can't find crate for `rustc_macros` which `rustc` depends on in rustc_llvm | Hello,
We hit this while compiling rust 1.35.0 -> rust 1.36.0 on x86. This is for the distro package for Alpine Linux. Please note that we're compiling against our own triplets, in this case it's for i586-alpine-linux-musl, see the definition here: https://gist.github.com/6bae5fdcf6bb5a95b3b779ceb2dd79f7
I'm pretty sure that that error is on us - but the error message doesn't really help me solve it, so maybe `x.py`/`configure` should catch this and give a better error message? A pointer in the right direction would certainly be very appreciated :)
See https://cloud.drone.io/alpinelinux/aports/8259/1/1
Thanks | T-bootstrap,O-musl | low | Critical |
464,882,439 | TypeScript | Inconsistent implicit any when referencing destructured variable more than once | **TypeScript Version:** 3.5.2 and 3.5.1
**Search Terms:** TS7022, "missing implicit any", "inconsistent implicit any", "does not have a type annotation", "referenced directly or indirectly in its own initializer"
**Code**
```ts
type Updater<T> = (t: T) => void;
function createUpdater<T>(t: T): [T, Updater<T>] {
return [t, function(newT: T) {}]
}
interface State {
value: number;
increment: (delta: number) => void;
decrement: (delta: number) => void;
}
const [state1, setState1] = createUpdater<State>({
value: 2,
increment: delta => setState1({
...state1,
value: state1.value + delta
}),
decrement: delta => setState1({
...state1,
value: state1.value - delta
})
})
const [state2, setState2]: [State, Updater<State>] = createUpdater<State>({
value: 2,
increment: delta => setState2({
...state2,
value: state2.value + delta
}),
decrement: delta => setState2({
...state2,
value: state2.value - delta
})
})
const [state3, setState3] = createUpdater<State>({
value: 2,
increment: delta => setState3({
...state3,
value: state3.value + delta
}),
decrement: delta => {}
})
```
**Expected behavior:** `setState1` would not trigger an error, **or** `setState3` would trigger an error.
**Actual behavior:** `setState1` triggers an error TS7022, while `setState3` does not.
**Playground Link:** [TypeScript playground link](http://www.typescriptlang.org/play/#code/C4TwDgpgBAqmAmBDYEBOAeAKgPigXigApgAuKTASn1wDcB7AS3gG4AoVgMwFcA7AY2AM6PKH1QRkEOEhQYcxMpTIBtTABpYCSXOwBdKAG9WUE1HHAuqEcuAbu-QcMI8IAd0yKqBgL67W39gYeWQ5EPmgAZWBJQ2NTGkQAGy4IMh4uAFsAIzQ2UyggsQgMiGCyQngIROi0zJzUKjxaRhY4k0qikrKiSurEWuy0RuamNgDWPmEAZ2AoZRnJAEYNKYhgKKX9AiLJaW10DZRsQiN8hOTUqAAmNTaC-nEu0ihe6OooVfXolEWTu-yAHRAhY-W75M5JFJkEEQRYA84pKAAaheVWid28FDBpg6j1Kz1eiHen0OsL+4NMQIBMOW-3ikMuNPhDKgAFpUX0MRR-NyJtNZvNvhAbh81qSrroVKSNHtZAchXp8KJxLstHLScdTvSLmQbndCnjuoTiWKhVdyRSoFSYXrLVAEYyzcyLsiOej8pjse0IJ18WRjU1RV9JOatRTrWaveCHdCnQ62W7EFyeexJjwZnMYQBmFamyRZrbKiQoWVoeWSTV3GPXKMG4p+xMm4MoLMW8PAoU5ukmavZ52IlGErlR3H1o1oomBnw8oA)
**Related Issues:** #6935 (?)
**Note: The only discernable difference in `setState1` and `setState3`, is that `setState1` is called in `state1.decrement` while `setState3` is not called in `state3.decrement`.** However, I'm still learning a lot about TS, and this issue seems like multiple things are at play - so I'm really not confident in my description of the problem (issue title) or my search/comparison of other issues. | Bug | low | Critical |
464,893,554 | terminal | WriteConsoleOutputCharacterA doesn't merge UTF-8 partials in successive calls | <!--
π¨π¨π¨π¨π¨π¨π¨π¨π¨π¨
I ACKNOWLEDGE THE FOLLOWING BEFORE PROCEEDING:
1. If I delete this entire template and go my own path, the core team may close my issue without further explanation or engagement.
2. If I list multiple bugs/concerns in this one issue, the core team may close my issue without further explanation or engagement.
3. If I write an issue that has many duplicates, the core team may close my issue without further explanation or engagement (and without necessarily spending time to find the exact duplicate ID number).
4. If I leave the title incomplete when filing the issue, the core team may close my issue without further explanation or engagement.
5. If I file something completely blank in the body, the core team may close my issue without further explanation or engagement.
All good? Then proceed!
-->
<!--
This bug tracker is monitored by Windows Terminal development team and other technical folks.
**Important: When reporting BSODs or security issues, DO NOT attach memory dumps, logs, or traces to Github issues**.
Instead, send dumps/traces to [email protected], referencing this GitHub issue.
Please use this form and describe your issue, concisely but precisely, with as much detail as possible.
-->
# Environment
```
Windows build number: [run "ver" at a command prompt]
Microsoft Windows [Version 10.0.18362.207]
```
# Steps to reproduce
<!-- A description of how to trigger this bug. -->
If a UTF-8 stream gets buffered in a loop, characters that consume more than one byte may get split at the buffer boundaries. Passing the buffer to `WriteConsoleOutputCharacterA` will corrupt the text because a conversion to UTF-16 is in place where these partials are treated as invalid UTF-8 characters and replaced with with U+FFFD characters.
# Expected behavior
<!-- A description of what you're expecting, possibly containing screenshots or reference material. -->
`WriteConsoleOutputCharacterA` should cache the partials and prepend them to the characters passed at the next call of this function, similar to the behavior of `WriteConsoleA`.
# Actual behavior
<!-- What's actually happening? -->
UTF-8 partials result in corrupted text.
A discussion about this already began in #386 but was rather out of scope in this issue.
| Product-Conhost,Area-Output,Area-Server,Issue-Bug | low | Critical |
464,907,357 | flutter | PageScrollPhysics has weird behavior | `PageScrollPhysics()` has strange behavior across all browsers when scrolling with the mouse view. This can be easily reproduced by creating a ListView with many elements and supplying PageScrollPhysics as an argument to the physics parameter.
GIF Example:
https://gyazo.com/f63a01031ce5e309aa142b20da3c92b5
| framework,f: scrolling,platform-web,a: desktop,a: mouse,has reproducible steps,P2,found in release: 3.7,found in release: 3.9,team-framework,triaged-framework | low | Critical |
464,913,078 | TypeScript | JSDoc type reference doesn't skip leading asterisk | <!-- π¨ STOP π¨ π¦π§π’π£ π¨ πΊπ»πΆπ· π¨
Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Even if you think you've found a *bug*, please read the FAQ first, especially the Common "Bugs" That Aren't Bugs section!
Please help us by doing the following steps before logging an issue:
* Search: https://github.com/Microsoft/TypeScript/search?type=Issues
* Read the FAQ: https://github.com/Microsoft/TypeScript/wiki/FAQ
Please fill in the *entire* template below.
-->
<!-- Please try to reproduce the issue with `typescript@next`. It may have already been fixed. -->
**TypeScript Version:** [email protected]
<!-- Search terms you tried before logging this (so others can find this issue more easily) -->
**Search Terms:**
checkjs
jsdoc
multi-line
multiline
**Code**
```ts
/**
* @returns {
* | 'a'
* | 'b'
* | 'c'
* } - this type is parsed as `any`.
*/
function f() {
return true;
}
```
**Expected behavior:**
Error on incompatible return type.
**Actual behavior:**
No error. The jsdoc return type is parsed as `any`.
**Playground Link:** <!-- A link to a TypeScript Playground "Share" link which demonstrates this behavior -->
Not available.
| Bug | low | Critical |
464,914,377 | youtube-dl | Request for dontmemorise.com | <!--
######################################################################
WARNING!
IGNORING THE FOLLOWING TEMPLATE WILL RESULT IN ISSUE CLOSED AS INCOMPLETE
######################################################################
-->
## Checklist
<!--
Carefully read and work through this check list in order to prevent the most common mistakes and misuse of youtube-dl:
- First of, make sure you are using the latest version of youtube-dl. Run `youtube-dl --version` and ensure your version is 2019.07.02. If it's not, see https://yt-dl.org/update on how to update. Issues with outdated version will be REJECTED.
- Make sure that all provided video/audio/playlist URLs (if any) are alive and playable in a browser.
- Make sure that site you are requesting is not dedicated to copyright infringement, see https://yt-dl.org/copyright-infringement. youtube-dl does not support such sites. In order for site support request to be accepted all provided example URLs should not violate any copyrights.
- Search the bugtracker for similar site support requests: http://yt-dl.org/search-issues. DO NOT post duplicates.
- Finally, put x into all relevant boxes (like this [x])
-->
- [x] I'm reporting a new site support request
- [x] I've verified that I'm running youtube-dl version **2019.07.02**
- [x] I've checked that all provided URLs are alive and playable in a browser
- [x] I've checked that none of provided URLs violate any copyrights
- [x] I've searched the bugtracker for similar site support requests including closed ones
## Example URLs
<!--
Provide all kinds of example URLs support for which should be included. Replace following example URLs by yours.
-->
- Website:
https://dontmemorise.com
- Playlist:
https://dontmemorise.com/course/view.php?id=72
## Description
<!--
Provide any additional information.
If work on your issue requires account credentials please provide them or explain how one can obtain them.
-->
Guys add support for dontmemorise.com | site-support-request | low | Critical |
464,928,865 | TypeScript | Intellisense: optional parameters are too verbose (bar? number | undefined) | ## Search Terms
optional parameters intellisense
## Suggestion
The intellisense for optional parameters is too verbose:
an optional function parameter defined e.g. like this
```typescript
function foo (bar?: number) {
}
```
gets resolved in the intellisense as
```typescript
function foo(bar?: number | undefined): void
```
The optional nature of the `bar` parameter is indicated two times, once with ` number | undefined` type and once with the question mark sign `bar?:`
Proposal:
Just use question mark in intellisense signatures
```typescript
function foo(bar?: number): void
```
## Use Cases
The `| undefined` bloats the length of the function signatures generated by the intellisense. This
makes the signatures too long leading to loss of important information in the intellisense in longer methods (e.g. the return types are shortened...)
## Examples
Here is an example:
```typescript
class IotFileClient {
public async GetFiles(
entityid: string,
params?: {
offset?: number;
limit?: number;
count?: boolean;
order?: string;
filter?: string;
}
): Promise<IotFileModels.IFile> {
return {name: "test"};
}
}
```
This produces the intellisense output like this:
```typescript
(method) IotFileClient.GetFiles(entityid: string, params?: {
offset?: number | undefined;
limit?: number | undefined;
count?: boolean | undefined;
order?: string | undefined;
filter?: string | undefined;
} | undefined): Promise<...>
```
Using only `?:` would reduce the verbosity and leave much more room for the important information e.g. for the return values:
```typescript
(method) IotFileClient.GetFiles(entityid: string, params?: {
offset?: number;
limit?: number;
count?: boolean;
order?: string;
filter?: string;
}): Promise<IotFileModels.IFile>
```
http://www.typescriptlang.org/play/#code/KYDwDg9gTgLgBAOwIYFtgGcxIMbDgSQhgDEBLAG2AFkIATYc9OAbwCg4O5RJY5SEYwKADMcefGUot2nWcjQAuOOhhR+AcwDcMjgF9W+1tnJJ0TQiQrAAwuVLAB0sAFcARnexxTATwSeA4sCWlOgAFDqyXAKkMN6ktEoqagjqADQRslhQqOgA-ErMcBmRHBDCwuhB+YjOKK5CmkUlJXYoMdUItfVQjcUl2BDOAtWuEBCUSAi9zZHQ9FDVSRrTM5zCFIILCksp2quc+rIAlEoAClAQbZUAPBaS1HQM6AB0ElYAfNKrUEHOUAgseTAJQAIkEKhBuj2BwMrFYwiG2BgpAgAOEYzgoVcSC2NTqQiOXyKuiAA
## Checklist
My suggestion meets these guidelines:
* [x] This wouldn't be a breaking change in existing TypeScript/JavaScript code
* [x] This wouldn't change the runtime behavior of existing JavaScript code
* [x] This could be implemented without emitting different JS based on the types of the expressions
* [x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
* [x] This feature would agree with the rest of [TypeScript's Design Goals](https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals).
| Suggestion,In Discussion | low | Minor |
464,935,398 | TypeScript | Show type info of yield | @rbuckton `yield` keyword should show its argument type and return type when a cursor is put on there. | Needs Proposal,Help Wanted,Effort: Moderate,Domain: Quick Info,Experience Enhancement,PursuitFellowship | low | Major |
464,949,961 | flutter | [Feature Request] Implement `Alignment.centerStart` and `Alignment.centerEnd` | ## Screenshot
## Steps to Reproduce
1. make an Align widget with text aligned center to left.
2. change the language of the emulator to Arabic.
```
Positioned.fill(
right: 10,
child: Align(
alignment: Alignment.centerRight,
child: GestureDetector(
child: Text(
Localization.of(context).loginForgot,
textAlign: TextAlign.center,),
),
), )
```
## Expected behaviour
1-Positioned( right: 10 to be left:10 for Arabic RTL
2-Align(alignment: Alignment.centerRight to be Alignment.centerLeft for Arabic RTL
## Logs
```
[β] Flutter (Channel master, v1.8.1-pre.23, on Microsoft Windows [Version 10.0.18362.207], locale en-US)
[β] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
[β] Chrome - develop for the web
[X] Visual Studio - develop for Windows
X Visual Studio not installed; this is necessary for Windows development.
Download at https://visualstudio.microsoft.com/downloads/.
[β] Android Studio (version 3.4)
[!] IntelliJ IDEA Community Edition (version 2019.1)
X Flutter plugin not installed; this adds Flutter specific functionality.
X Dart plugin not installed; this adds Dart specific functionality.
[β] VS Code, 64-bit edition (version 1.36.0)
[β] Connected device (4 available)
```
| c: new feature,framework,P3,team-framework,triaged-framework | low | Minor |
464,951,925 | pytorch | Batched symeig and qr are very slow on GPU | ## π Bug
The recently added batched eigenvalue decomposition via `torch.symeig` is very slow on GPU (pr: https://github.com/pytorch/pytorch/pull/21858, issue: https://github.com/pytorch/pytorch/issues/7500).
## To Reproduce
```python
import torch
a = torch.rand(500, 2, 2)
a = 0.5 * (a + a.transpose(1, 2))
w, _ = torch.symeig(a) # fast (~0.0006s)
a = a.cuda()
w, _ = torch.symeig(a) # slow (~0.9s)
```
## Expected behavior
The GPU variant should be at least as fast as the CPU one. This is an elementary matrix operation and GPUs should be fast at that.
## Environment
PyTorch version: 1.2.0.dev20190707
Is debug build: No
CUDA used to build PyTorch: 9.0.176
OS: Ubuntu 16.04.6 LTS
GCC version: (Ubuntu 5.4.0-6ubuntu1~16.04.11) 5.4.0 20160609
CMake version: version 3.5.1
Python version: 3.7
Is CUDA available: Yes
CUDA runtime version: Could not collect
GPU models and configuration:
GPU 0: GeForce GTX TITAN X
GPU 1: GeForce GTX TITAN X
GPU 2: GeForce GTX TITAN X
GPU 3: GeForce GTX TITAN X
Nvidia driver version: 418.67
cuDNN version: Probably one of the following:
/usr/local/cuda-10.0/targets/x86_64-linux/lib/libcudnn.so.7
/usr/local/cuda-8.0/targets/x86_64-linux/lib/libcudnn.so.5
/usr/local/cuda-9.0/targets/x86_64-linux/lib/libcudnn.so.7.2.1
Versions of relevant libraries:
[pip3] numpy==1.15.1
[conda] mkl 2019.4 243
[conda] pytorch-nightly 1.2.0.dev20190707 py3.7_cuda9.0.176_cudnn7.5.1_0 pytorch
## Additional context
I assume this is not surprising given the following comment (CC @vishwakftw) https://github.com/pytorch/pytorch/blob/bcb5fd8f06292f1bf4b1982b97ed2339c3f49a30/aten/src/ATen/native/cuda/BatchLinearAlgebra.cu#L1208-L1212 but it should nonetheless be fixed. It's not clear to me if that implies there's a bug in MAGMA and whether something is being done about it.
cc @ngimel @vincentqb @vishwakftw @jianyuh @nikitaved @pearu @mruberry @heitorschueroff @VitalyFedyunin | module: performance,module: cuda,triaged,module: linear algebra | medium | Critical |
464,971,758 | svelte | Site: Some parts of the API docs expect readers to have read previous sections | It seems that some parts of the API docs refer back to previous API documentation. This assumes that readers have read the whole thing or are reading in order which is highly unlikely considering it is a reference.
The the [component bindings](https://svelte.dev/docs#bind_component) section was brought to my attention (emphasis mine):
>Components **_also_** support bind:this, allowing you to interact with component instances programmatically.
This is a reference to element bindings (I think, it isn't actually very clear) but there is no link back to that section.
I'm guessing this happens in a few places though, I will try to read through and see where else we are doing it.
We need to either link back to the relevant section or make the documentation entries 'standalone'. I think it makes sense for API Reference entries to have enough information to be useful on their own. This will be one of the places people come when they have a specific problem that they will then search or scan for, making them jump to other parts of the Docs is probably leading to a more frustrating experience. | stale-bot,documentation | low | Minor |
464,984,964 | flutter | TextField should warn on vertical overflow | I tried finding in a lot of resources but unfortunately i could not find a way to align the text vertically centre in a textfield. I also tried using suffixIcon instead of suffix but still not luck. Here is my code :
```
import 'package:flutter/material.dart';
void main() => runApp(MyApp());
class MyApp extends StatelessWidget {
@override
Widget build(BuildContext context) {
return MaterialApp(
home: HomePage(),
);
}
}
class HomePage extends StatefulWidget {
@override
State<StatefulWidget> createState() {
return _HomePageState();
}
}
class _HomePageState extends State<HomePage> {
@override
Widget build(BuildContext context) {
return Scaffold(
appBar: AppBar(
leading: Icon(
Icons.menu,
color: Colors.black,
),
backgroundColor: Colors.white,
title: Container(
margin: EdgeInsets.only(bottom: 10),
child: Image.asset(
"icons/logo.png",
),
),
bottom: PreferredSize(
child: Padding(
padding: EdgeInsets.only(
left: 10,
right: 10,
bottom: 10,
),
child: Container(
height: 40,
child: TextField(
textAlignVertical: TextAlignVertical.center,
textAlign: TextAlign.left,
maxLines: 1,
style: TextStyle(
fontSize: 13,
),
decoration: InputDecoration(
suffixIcon: IconButton(icon: Icon(Icons.search, color: Colors.black,), onPressed: (){}),
border: OutlineInputBorder(
borderSide: BorderSide(
color: Colors.black,
),
borderRadius: BorderRadius.all(Radius.circular(15)),
)
),
),
),
),
preferredSize: Size(MediaQuery.of(context).size.width, 50),
),
),
body: Container(
margin: EdgeInsets.only(top: 11),
child: Column(
children: <Widget>[
Carousel(),
],
),
),
);
}
}
class Carousel extends StatefulWidget {
@override
State<StatefulWidget> createState() {
return _CarouselState();
}
}
class _CarouselState extends State<Carousel> {
List<String> urls = [];
@override
Widget build(BuildContext context) {
return Padding(
padding: EdgeInsets.symmetric(horizontal: 10),
child: Stack(
children: <Widget>[
Image.network(
"someImageUrlHere."),
Positioned(
bottom: 5,
width: MediaQuery.of(context).size.width - 20,
child: Row(
mainAxisAlignment: MainAxisAlignment.center,
children: <Widget>[
Text("β’"),
Text("β’"),
Text("β’"),
Text("β’"),
Text("β’"),
],
),
),
],
),
);
}
}
```
What could be the issue that is causing this problem ? and how can i solve this issue ? | a: text input,framework,a: quality,a: debugging,has reproducible steps,found in release: 1.20,team-text-input | medium | Major |
464,986,942 | pytorch | Double backward 3 times slower for conv2d with padding = 1 | ## π Bug
Hi, I'm trying to compute the jacobian vector product using a trick from https://j-towns.github.io/2017/06/12/A-new-trick.html. This involves computing the gradient twice. It seems like using conv2d with padding =1 slows down the computation by almost 3 times, compared to padding =0:
padding= 0: 2.962866 s
padding=1: 9.922703s
In case only one backward pass is computed both give the same times:
padding =0: 1.056120s
padding = 1: 1.180639s
## To Reproduce
```python
import torch as tr
from torch.autograd import Variable
import torch.nn as nn
from torch import autograd
import time
from copy import deepcopy
from datetime import datetime
startTime = datetime.now()
import torch.nn as nn
import torch.nn.functional as F
from models.resnet import *
tr.backends.cudnn.benchmark=True
class Net(nn.Module):
def __init__(self,padding= 0):
super(Net, self).__init__()
self.conv1 = nn.Conv2d(3, 64, 3,padding=padding)
self.conv2 = nn.Conv2d(64, 64, 3,padding=padding)
def forward(self, x):
out = F.relu(self.conv1(x))
out = F.relu(self.conv2(out))
return out.sum()
def jvp(outputs,variable,direction):
dummy_u = Variable(tr.ones_like(outputs), requires_grad=True)
aux_grad_loss = tr.autograd.grad(outputs = outputs,inputs = variable, grad_outputs=dummy_u, create_graph=True,only_inputs=True)
out = tr.autograd.grad(outputs= aux_grad_loss,inputs = dummy_u,grad_outputs=direction,create_graph=True,only_inputs=True)[0]
return out
device = 'cuda'
dist = tr.distributions.Normal(tr.tensor(4.0,dtype= tr.float32, device = device), tr.tensor(0.5,dtype= tr.float32, device = device))
b_size = 128
num_iter = 100
X = dist.sample([b_size,3,32,32])
print("no padding")
net = Net(padding=0).to(device)
params = list(net.parameters())
directions = deepcopy(params)
torch.cuda.synchronize()
startTime = datetime.now()
for k in range(num_iter):
Y = tr.sum(net(X))
dd = jvp(Y,params,directions)
torch.cuda.synchronize()
print(datetime.now() - startTime)
print("with padding")
net = Net(padding=1).to(device)
params = list(net.parameters())
directions = deepcopy(params)
torch.cuda.synchronize()
startTime = datetime.now()
for k in range(num_iter):
Y = tr.sum(net(X))
dd = jvp(Y,params,directions)
torch.cuda.synchronize()
print(datetime.now() - startTime)
```
## Expected behavior
The computation time should be roughly similar with or without padding.
## Environment
PyTorch version: 1.1.0
Is debug build: No
CUDA used to build PyTorch: 10.0.130
OS: Ubuntu 16.04.5 LTS
GCC version: (crosstool-NG 1.23.0.449-a04d0) 7.3.0
CMake version: version 3.7.2
Python version: 3.7
Is CUDA available: Yes
CUDA runtime version: Could not collect
GPU models and configuration:
GPU 0: Quadro P5000
GPU 1: GeForce RTX 2080
Nvidia driver version: 410.73
cuDNN version: /usr/lib/x86_64-linux-gnu/libcudnn.so.7.3.1
Versions of relevant libraries:
[pip] numpy==1.16.4
[pip] torch==1.1.0
[pip] torchvision==0.3.0
[conda] mkl 2019.4 243
[conda] torch 1.1.0 <pip>
[conda] torchvision 0.3.0 <pip>
Edit [t-vi]: add backticks around source
cc @ezyang @gchanan @zou3519 @jerryzh168 @VitalyFedyunin @ngimel @mruberry | module: dependency bug,module: performance,module: double backwards,module: nn,module: convolution,triaged,has workaround,quansight-nack | low | Critical |
464,995,566 | pytorch | torch.gels runs 100 time slower on gpu than on cpu | I tried gels on both gpu and cpu and measured time elapsed.
`start=time.time()
sol,_=torch.gels(y,x.permute(1,0))[:3] # a,b,d
end=time.time()`
On cpu it only takes ~0.00002 sec, but on gpu it take ~0.003 sec.
Anyone know why? Should it be the case? | module: performance,triaged | low | Major |
465,002,382 | rust | Specific code layout can cause link failure with lto=true | This is the same code layout as #59137, with slightly more of my actual code - turns out that's not the only issue preventing me from using LTO.
I have a three-crate workspace; only two of these crates are relevant for this issue (if the code *ran*, the third would be relevant).
- `parent`, a binary, depending on `shared` and `libloading`, using the latter to load `child`
- `shared`, a library, with `crate-type = ["dylib"]`
- `child`, a library, also with `crate-type = ["dylib"]`. This crate can be deleted without changing the compile behaviour; it is only relevant at runtime.
https://github.com/GinjaNinja32/rust-issues/tree/62479
I expected to see this happen: Successful compile, i.e.
```
$ cargo build --release
Compiling cc v1.0.37
Compiling shared v0.1.0 (/home/nyx/git/rust-issues/shared)
Compiling child v0.1.0 (/home/nyx/git/rust-issues/child)
Compiling libloading v0.5.2
Compiling parent v0.1.0 (/home/nyx/git/rust-issues/parent)
Finished release [optimized] target(s) in 5.62s
```
Instead, this happened: Linking failed:
```
$ cargo build --release
Compiling cc v1.0.37
Compiling shared v0.1.0 (/home/nyx/git/rust-issues/shared)
Compiling child v0.1.0 (/home/nyx/git/rust-issues/child)
Compiling libloading v0.5.2
Compiling parent v0.1.0 (/home/nyx/git/rust-issues/parent)
error: linking with `cc` failed: exit code: 1
|
= note: "cc" "-Wl,--as-needed" "-Wl,-z,noexecstack" "-m64" "-L" "/home/nyx/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib" "/home/nyx/git/rust-issues/target/release/deps/parent-e24cfa8e761d50d8.parent.6gomyrbo-cgu.6.rcgu.o" "-o" "/home/nyx/git/rust-issues/target/release/deps/parent-e24cfa8e761d50d8" "-Wl,--gc-sections" "-pie" "-Wl,-zrelro" "-Wl,-znow" "-Wl,-O1" "-nodefaultlibs" "-L" "/home/nyx/git/rust-issues/target/release/deps" "-L" "/home/nyx/git/rust-issues/target/release/build/libloading-fb9b968fc3777b66/out" "-L" "/home/nyx/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib" "-L" "/home/nyx/git/rust-issues/target/release/deps" "-lshared" "-Wl,-Bstatic" "/tmp/rustcht55QS/liblibloading-6ea24a0114b349f0.rlib" "-Wl,--start-group" "-L" "/home/nyx/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib" "-Wl,-Bdynamic" "-lstd-9895e8982b0a79e7" "-Wl,--end-group" "-Wl,-Bstatic" "/home/nyx/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib/libcompiler_builtins-38e90baf978bc428.rlib" "-Wl,-Bdynamic" "-ldl" "-ldl" "-lrt" "-lpthread" "-lgcc_s" "-lc" "-lm" "-lrt" "-lpthread" "-lutil" "-lutil"
= note: /usr/bin/ld: /home/nyx/git/rust-issues/target/release/deps/parent-e24cfa8e761d50d8.parent.6gomyrbo-cgu.6.rcgu.o: in function `core::ptr::real_drop_in_place':
parent.6gomyrbo-cgu.6:(.text._ZN4core3ptr18real_drop_in_place17ha2fb5a25020df4d8E+0xc): undefined reference to `<libloading::os::unix::Library as core::ops::drop::Drop>::drop'
/usr/bin/ld: /home/nyx/git/rust-issues/target/release/deps/parent-e24cfa8e761d50d8.parent.6gomyrbo-cgu.6.rcgu.o: in function `core::ptr::real_drop_in_place':
parent.6gomyrbo-cgu.6:(.text._ZN4core3ptr18real_drop_in_place17hf2d0808cb9ce830eE+0x2): undefined reference to `<libloading::os::unix::DlerrorMutexGuard as core::ops::drop::Drop>::drop'
/usr/bin/ld: /home/nyx/git/rust-issues/target/release/deps/parent-e24cfa8e761d50d8.parent.6gomyrbo-cgu.6.rcgu.o: in function `parent::main':
parent.6gomyrbo-cgu.6:(.text._ZN6parent4main17h1271b7f81bb8859cE+0x2a): undefined reference to `libloading::util::cstr_cow_from_bytes'
/usr/bin/ld: parent.6gomyrbo-cgu.6:(.text._ZN6parent4main17h1271b7f81bb8859cE+0x68): undefined reference to `libloading::os::unix::DlerrorMutexGuard::new'
/usr/bin/ld: parent.6gomyrbo-cgu.6:(.text._ZN6parent4main17h1271b7f81bb8859cE+0xdc): undefined reference to `<libloading::os::unix::DlerrorMutexGuard as core::ops::drop::Drop>::drop'
/usr/bin/ld: parent.6gomyrbo-cgu.6:(.text._ZN6parent4main17h1271b7f81bb8859cE+0xf3): undefined reference to `<libloading::Library as core::convert::From<libloading::os::unix::Library>>::from'
/usr/bin/ld: parent.6gomyrbo-cgu.6:(.text._ZN6parent4main17h1271b7f81bb8859cE+0x117): undefined reference to `<libloading::Library as core::fmt::Debug>::fmt'
/usr/bin/ld: parent.6gomyrbo-cgu.6:(.text._ZN6parent4main17h1271b7f81bb8859cE+0x163): undefined reference to `<libloading::os::unix::Library as core::ops::drop::Drop>::drop'
/usr/bin/ld: parent.6gomyrbo-cgu.6:(.text._ZN6parent4main17h1271b7f81bb8859cE+0x2a8): undefined reference to `<libloading::os::unix::Library as core::ops::drop::Drop>::drop'
/usr/bin/ld: parent.6gomyrbo-cgu.6:(.text._ZN6parent4main17h1271b7f81bb8859cE+0x2b8): undefined reference to `libloading::util::<impl core::convert::From<libloading::util::NullError> for std::io::error::Error>::from'
/usr/bin/ld: /home/nyx/git/rust-issues/target/release/deps/parent-e24cfa8e761d50d8.parent.6gomyrbo-cgu.6.rcgu.o: in function `core::ptr::real_drop_in_place':
parent.6gomyrbo-cgu.6:(.text._ZN4core3ptr18real_drop_in_place17h414db0f3839003feE+0x2): undefined reference to `<libloading::os::unix::Library as core::ops::drop::Drop>::drop'
collect2: error: ld returned 1 exit status
error: aborting due to previous error
error: Could not compile `parent`.
To learn more, run the command again with --verbose.
```
## Meta
`rustc --version --verbose`:
```
rustc 1.36.0 (a53f9df32 2019-07-03)
binary: rustc
commit-hash: a53f9df32fbb0b5f4382caaad8f1a46f36ea887c
commit-date: 2019-07-03
host: x86_64-unknown-linux-gnu
release: 1.36.0
LLVM version: 8.0
```
(as used above)
also occurs on:
```
rustc 1.38.0-nightly (dfd52ba6a 2019-07-06)
binary: rustc
commit-hash: dfd52ba6ac2262c6b61c59ec86bfd23e4e53d3de
commit-date: 2019-07-06
host: x86_64-unknown-linux-gnu
release: 1.38.0-nightly
LLVM version: 8.0
``` | A-linkage,T-compiler,C-bug | low | Critical |
465,003,141 | terminal | Terminal desperately needs a horizontal scrollbar (similar to Command Prompt) | <hr>
> **Note**: π Pinned comment: **https://github.com/microsoft/terminal/issues/1860#issuecomment-1622136376**
<hr>
# Summary of the new feature/enhancement
Windows Terminal needs to have a configurable horizontal scrollbar (similar to Command Prompt) so that lines longer than the window width are actually readable by scrolling to the right, rather than being a big indecipherable word-wrapped mess as is typically seen on UNIX-like systems.
# Proposed technical implementation details (optional)
Make it so. | Issue-Feature,Resolution-By-Design,Help Wanted,Area-Output,Area-TerminalControl,Product-Terminal | high | Critical |
465,003,380 | flutter | [web/all] PageView shouldn't skip pages | I dislike the current way that PageView works: if you put not-enough force, it gets back to where it is. If you put too much force, it scrolls two pages. This is really evident in this official sample: https://flutter.github.io/samples/filipino_cuisine/ (just drag with your mouse from one corner to next and it will skip one element). It goes from tolerable to intolerable. On apps, if you drag from left to right you trigger the same:
<img src="https://user-images.githubusercontent.com/351125/60774878-2207a680-a0f1-11e9-9ad3-3a94cd269b9d.gif" width="250" />
[feature request] I also wish Flutter could enable carousels ranging from Google Play Games, which is very fluid to ones that go at maximum 1 page ahead, not 2 (which IMO seems like a bug), no matter how strong you push. I know I should probably make another issue for this request, but if someone makes the PageView method that scrolls more modular or etc, could be helpful for implementing something like this:
<img src="https://user-images.githubusercontent.com/351125/60774866-f5538f00-a0f0-11e9-98a5-0119f29b9b5e.gif" width="250" />
I tried subclassing PageScrollPhysics and changing the parameters, but it seems the issue is somewhere else.
Might be related to https://github.com/flutter/flutter/pull/12884. | framework,f: scrolling,f: gestures,c: proposal,has reproducible steps,P3,found in release: 2.10,found in release: 2.13,team-framework,triaged-framework | medium | Critical |
465,009,282 | go | cmd/compile: superfluous MOV instructions | Using `go1.12` on `linux/amd64`
Consider the following benchmark:
```go
var srcString = "1234"
var srcBytes = []byte(srcString)
var dst uint64
// BenchmarkIdeal is the ideal performance parsing a string.
func BenchmarkIdeal(b *testing.B) {
b.ReportAllocs()
for i := 0; i < b.N; i++ {
dst, _ = strconv.ParseUint(srcString, 0, 64)
}
}
// BenchmarkCopy is the performance after copying the input bytes as a string.
// Performance loss is expected.
func BenchmarkCopy(b *testing.B) {
b.ReportAllocs()
for i := 0; i < b.N; i++ {
dst, _ = strconv.ParseUint(string(srcBytes), 0, 64)
}
}
// BenchmarkCast is the performance when using unsafe to cast bytes as a string.
func BenchmarkCast(b *testing.B) {
b.ReportAllocs()
for i := 0; i < b.N; i++ {
dst, _ = strconv.ParseUint(UnsafeString(srcBytes), 0, 64)
}
}
type stringHeader struct {
Data unsafe.Pointer
Len int
}
type sliceHeader struct {
Data unsafe.Pointer
Len int
Cap int
}
func UnsafeString(b []byte) (s string) {
bp := (*sliceHeader)(unsafe.Pointer(&b))
sp := (*stringHeader)(unsafe.Pointer(&s))
sp.Data = bp.Data
sp.Len = bp.Len
return s
}
```
This currently reports the following on my system:
```
BenchmarkIdeal-8 100000000 14.9 ns/op 0 B/op 0 allocs/op
BenchmarkCopy-8 50000000 35.1 ns/op 4 B/op 1 allocs/op
BenchmarkCast-8 100000000 15.7 ns/op 0 B/op 0 allocs/op
```
I expect `BenchmarkIdeal` and `BenchmarkCast` to be the same, but there is a ~1ns loss of performance.
The assembly of the inner loop between `BenchmarkIdeal` and `BenchmarkCast` is:
```diff
- 0x0033 00051 MOVQ "".srcString(SB), AX
- 0x003a 00058 MOVQ "".srcString+8(SB), CX
+ 0x003a 00058 MOVQ "".srcBytes+16(SB), AX
+ 0x0041 00065 MOVQ "".srcBytes(SB), CX
+ 0x0048 00072 MOVQ "".srcBytes+8(SB), DX
+ 0x004f 00079 MOVQ CX, "".b+80(SP)
+ 0x0054 00084 MOVQ DX, "".b+88(SP)
+ 0x0059 00089 MOVQ AX, "".b+96(SP)
+ 0x005e 00094 XORPS X0, X0
+ 0x0061 00097 MOVUPS X0, "".s+64(SP)
+ 0x0066 00102 XCHGL AX, AX
+ 0x0067 00103 MOVQ "".b+80(SP), AX
+ 0x006c 00108 MOVQ AX, "".s+64(SP)
+ 0x0071 00113 MOVQ "".b+88(SP), AX
+ 0x0076 00118 MOVQ AX, "".s+72(SP)
+ 0x007b 00123 MOVQ "".s+64(SP), CX
0x0080 00128 MOVQ CX, (SP)
0x0084 00132 MOVQ AX, 8(SP)
0x0089 00137 MOVQ $0, 16(SP)
0x0092 00146 MOVQ $64, 24(SP)
0x009b 00155 CALL strconv.ParseUint(SB)
0x00a0 00160 MOVQ 32(SP), AX
0x00a5 00165 MOVQ AX, "".dst(SB)
```
It seems that although the call to `UnsafeString` is inlined, the compiler still emits a number of `MOV` instructions that seem superfluous. Ideally, the compiler would emit assembly that is functionally identical to the `BenchmarkIdeal` case. | Performance,NeedsInvestigation,compiler/runtime | low | Major |
465,022,205 | pytorch | Pytorch compilation error on Mac OS | # # π Bug
# # environment
-- operating system: Mac OS 10.13
-- cmake version 3.14.2
-- python version 3.6.5
- clang:
Clang -std = c + + 17
Apple LLVM version 9.1.0 (clang-902.0.39.1)
Target: x86_64 - apple - darwin17.7.0
## installation process
git clone --recursive https://github.com/pytorch/pytorch
cd pytorch
# if you are updating an existing checkout
git submodule sync
git submodule update --init --recursive
# this step is not clear < not executing >
Export CMAKE_PREFIX_PATH = ${CONDA_PREFIX: - "$(dirname $(which conda)) /.. / "}
#Perform this step to install
MACOSX_DEPLOYMENT_TARGET=10.9 CC=clang CXX=clang++ python setup.py install
#Problem specification
The following error occurred during installation! The problem files are: h file, CPP file, c file
How to compile pytorch correctly please help me! Thank you very much!
| module: build,triaged | low | Critical |
465,082,655 | flutter | Make pointer signal event (mouse wheel event) handling configurable in ListView | ## Use case
I have a **reverse** `ListView`, and I can interact with it with a **mouse**. The `ListView` is reverse because I need the viewport to keep displaying the bottom edge while adding animated elements to the list. And in my particular case, I interact with a mouse because it's a Flutter Web project, but I believe mouse interaction is possible with regular Flutter on Android/iOS tablets too.
Scrolling the `ListView` with the mouse wheel scrolls in the direction opposite to the expected one (scrolling down goes up & vice versa, because of the **reverse** prop). So I would like to disable mouse wheel handling.
Wrapping the `ListView` in an `AbsorbPointer` is not a solution, because all pointer events are absorbed (not only the mouse wheel events), so buttons or other interactive widgets within the `ListView` are unusable.
Setting the `ListView` **physics** prop to a `NeverScrollableScrollPhysics` is not a solution either because it only prevents scrolling by drag/touch, but doesn't impact pointer event handling.
## Proposal
I would like the `ListView` to be configurable to prevent or override the pointer signal event handling. The current behaviour is hardcoded in a `Listener` deep down in `ScrollableState` and there seems to be no way to change it.
```
[β] Flutter (Channel stable, v1.5.4-hotfix.2, on Mac OS X 10.14.5 18F132, locale en-KR)
[β] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
[β] iOS toolchain - develop for iOS devices (Xcode 10.2.1)
[β] Android Studio (version 3.4)
[β] VS Code (version 1.35.1)
[β] Connected device (1 available)
```
| framework,f: scrolling,c: proposal,P3,team-framework,triaged-framework | low | Major |
465,119,279 | opencv | multibandblender does not work well | <!--
If you have a question rather than reporting a bug please go to http://answers.opencv.org where you get much faster responses.
If you need further assistance please read [How To Contribute](https://github.com/opencv/opencv/wiki/How_to_contribute).
Please:
* Read the documentation to test with the latest developer build.
* Check if other person has already created the same issue to avoid duplicates. You can comment on it if there already is an issue.
* Try to be as detailed as possible in your report.
* Report only one problem per created issue.
This is a template helping you to create an issue which can be processed as quickly as possible. This is the bug reporting section for the OpenCV library.
-->
##### System information (version)
<!-- Example
- OpenCV => 3.1
- Operating System / Platform => Windows 64 Bit
- Compiler => Visual Studio 2015
-->
- OpenCV => :4.00:
- Operating System / Platform => :window10:
- Compiler => :vs2019:
##### Detailed description
When I used the multibandblender to fuse the image, it was a failure and there were artifacts at the boundary. I read [this answer](https://stackoverflow.com/questions/30044477/how-to-use-multi-band-blender-in-opencv) to solve the problem and it need to shrink the mask(I have done some erode operation). However, when the mask is shrinked , the resulting panorama will have loss of some region (some region become black), how can I solve this problem.
**Details and test data**
Experimental data: the position where the image pixel is not 0, and the corresponding mask position is set to 255.
**imagesοΌ**
**masksοΌ**
**resultοΌ**
Blending after shrinking masksοΌerode operationοΌkernelδΈΊοΌ20*20οΌοΌοΌ
**masksοΌ**
**resultοΌ**
My test data is as below which includes images,masks,corners that multibandblender needs:
[data.zip](https://github.com/opencv/opencv/files/3371567/data.zip)
<!-- your description -->
**my blend functionοΌ**
`void blend(vector<cv::UMat>& panoImgs, vector<cv::Point>& corners, vector<cv::UMat>& panoMasks, cv::UMat& pano)
{
for (int i = 0; i < panoImgs.size(); ++i)
{
panoImgs[i].convertTo(panoImgs[i], CV_16SC3);
}
cv::detail::MultiBandBlender blender;
blender.prepare(cv::Rect(0, 0, panoWidth_, panoWidth_ / 2));
for (int i = 0; i < panoImgs.size(); i++)
{
blender.feed(panoImgs[i], panoMasks[i], corners[i]);
}
cv::Mat panoMask;
blender.blend(pano, panoMask);
}`
| incomplete,needs reproducer | low | Critical |
465,192,739 | terminal | Suggestion: ability for terminals to set their tab icon | #1685 Summary of the new feature/enhancement
The terminal currently provides a way for shells to specify the title:
In the world of web apps, both title and icon can be specified.
It would be useful for shells to be able to specify an icon for their tab for the same reasons:
- Sometimes visuals are more obvious than text. The node.js green gem, or the python logo, or some custom app icon all 'pop' visually more than the equivalent text does
- Terminals can update their icon to indicate specific conditions (a bell should be used for serious differences, but this could be used for more subtle ones, eg, showing a tunnel icon for an ssh tunnel running, then a shell icon if it stops and returns to the prompt)
- If we let terminals specify their title, why not let them specify their icon?
| Issue-Feature,Help Wanted,Area-VT,Product-Terminal | medium | Major |
465,195,390 | TypeScript | How to find/debug what file(s) included given file during typescript compilation | ## Search Terms
<!-- List of keywords you searched for before creating this issue. Write them down here so that others can find this suggestion more easily -->
find why was file included during typescript build
## Suggestion
Be able to find out why a file was checked by TS compiler during a build.
## Use Cases
Sometimes testing files gets somehow mixed into the type checking for dev/prod builds.
## Examples
If a flag `explain-inclusion=FLFolder.mock.ts` is present:
`projects/folder-listing/src/app/services/FLEntities/FLFolder.mock.ts` was included, because it was requested by:
- `projects/folder-listing/src/app/services/FLEntities/FLFolder.ts` at (3:26)
- `projects/folder-listing/src/app/services/main.service.ts` (7:10)
... (Only first level, the developer should repeat the process as needed)
## Checklist
My suggestion meets these guidelines:
* [x] This wouldn't be a breaking change in existing TypeScript/JavaScript code
* [x] This wouldn't change the runtime behavior of existing JavaScript code
* [x] This could be implemented without emitting different JS based on the types of the expressions
* [x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
* [x] This feature would agree with the rest of [TypeScript's Design Goals](https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals).
| Suggestion,In Discussion | low | Critical |
465,198,533 | flutter | flutter run with Multiple, but not All Devices | <!-- Thank you for using Flutter!
If you are looking for support, please check out our documentation
or consider asking a question on Stack Overflow:
* https://flutter.dev/
* https://api.flutter.dev/
* https://stackoverflow.com/questions/tagged/flutter?sort=frequent
If you have found a bug or if our documentation doesn't have an answer
to what you're looking for, then fill our the template below. Please read
our guide to filing a bug first: https://flutter.dev/docs/resources/bug-reports
-->
## Use case
Since Flutter has started to support desktop and web development, it is a good idea to only run multiple, but not all devices in `flutter run`.
For example, I only want to run my Flutter app in iOS simulators and Android emulators, but not `macos` or `chrome`.
<!--
Please tell us the problem you are running into that led to you wanting
a new feature.
Is your feature request related to a problem? Please give a clear and
concise description of what the problem is.
Describe alternative solutions you've considered. Is there a package
on pub.dev/flutter that already solves this?
-->
## Proposal
In `flutter run -d`, either separate device IDs using commas (e.g. `flutter run -d device1,device2,device3`), or allow multiple `-d` flags (e.g. `flutter run -d device1 -d device2 -d device3`).
<!--
Briefly but precisely describe what you would like Flutter to be able to do.
Consider attaching images showing what you are imagining.
Does this have to be provided by Flutter directly, or can it be provided
by a package on pub.dev/flutter? If so, maybe consider implementing and
publishing such a package rather than filing a bug.
-->
| c: new feature,tool,P3,team-tool,triaged-tool | medium | Critical |
465,227,944 | terminal | Display current tab's icon as a badge on the taskbar icon | <!--
π¨π¨π¨π¨π¨π¨π¨π¨π¨π¨
I ACKNOWLEDGE THE FOLLOWING BEFORE PROCEEDING:
1. If I delete this entire template and go my own path, the core team may close my issue without further explanation or engagement.
2. If I list multiple bugs/concerns in this one issue, the core team may close my issue without further explanation or engagement.
3. If I write an issue that has many duplicates, the core team may close my issue without further explanation or engagement (and without necessarily spending time to find the exact duplicate ID number).
4. If I leave the title incomplete when filing the issue, the core team may close my issue without further explanation or engagement.
5. If I file something completely blank in the body, the core team may close my issue without further explanation or engagement.
All good? Then proceed!
-->
I can assign individual icons for each profile, and each tab I open for said profile has that profile's icon on the tab. HOWEVER, the taskbar "button" has the primary app icon on it, which isn't as helpful as having the currently active tab's icon instead. The correct icon provides a visual cue on which taskbar button is "my" button I'm looking for.
<!--
A clear and concise description of what the problem is that the new feature would solve.
Describe why and how a user would use this new functionality (if applicable).
-->
# Proposed technical implementation details (optional)
<!--
A clear and concise description of what you want to happen.
-->
| Issue-Feature,Help Wanted,Area-UserInterface,Product-Terminal | medium | Critical |
465,229,216 | pytorch | [dataloader] Mysterious error when using spawn start_method | Unfortunately, I couldn't find the root cause for the moment. The error disappears when I use the fork start_method. I also can't find what `deco` it refers to.
It seems that some function decorator / wrapping is happening badly, but I can't find what's to blame.: the dataset object can clearly be pickled, as proven by the fork start method.
The error comes from `process.start()` impl for the spawn start method.
```
Traceback (most recent call last):
File "train.py", line 968, in <module>
train(start_epoch, start_iter, start_checkpoint)
File "train.py", line 688, in train
for i, data in enumerate(train_loader, start=from_iter):
File "/miniconda/lib/python3.7/site-packages/torch/utils/data/dataloader.py", line 194, in __iter__
return _DataLoaderIter(self)
File "/miniconda/lib/python3.7/site-packages/torch/utils/data/dataloader.py", line 470, in __init__
w.start()
File "/miniconda/lib/python3.7/multiprocessing/process.py", line 112, in start
self._popen = self._Popen(self)
File "/miniconda/lib/python3.7/multiprocessing/context.py", line 223, in _Popen
return _default_context.get_context().Process._Popen(process_obj)
File "/miniconda/lib/python3.7/multiprocessing/context.py", line 284, in _Popen
return Popen(process_obj)
File "/miniconda/lib/python3.7/multiprocessing/popen_spawn_posix.py", line 32, in __init__
super().__init__(process_obj)
File "/miniconda/lib/python3.7/multiprocessing/popen_fork.py", line 20, in __init__
self._launch(process_obj)
File "/miniconda/lib/python3.7/multiprocessing/popen_spawn_posix.py", line 47, in _launch
reduction.dump(process_obj, fp)
File "/miniconda/lib/python3.7/multiprocessing/reduction.py", line 60, in dump
ForkingPickler(file, protocol).dump(obj)
AttributeError: Can't pickle local object 'deco.<locals>.wrapped'
```
PyTorch version: 1.2.0.dev20190607 | module: dataloader,triaged | low | Critical |
465,229,701 | create-react-app | Error in the demo project, can't do the first run with npm. | ### Describe the bug
The raw project isn't running after the creation:
`
events.js:170
throw er; // Unhandled 'error' event
^
Error: spawn /usr/bin/chromium ENOENT
at Process.ChildProcess._handle.onexit (internal/child_process.js:247:19)
at onErrorNT (internal/child_process.js:429:16)
at processTicksAndRejections (internal/process/task_queues.js:81:17)
Emitted 'error' event at:
at Process.ChildProcess._handle.onexit (internal/child_process.js:253:12)
at onErrorNT (internal/child_process.js:429:16)
at processTicksAndRejections (internal/process/task_queues.js:81:17)
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! [email protected] start: `react-scripts start`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the [email protected] start script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm ERR! A complete log of this run can be found in:
npm ERR! /home/otavio/.npm/_logs/2019-07-08T11_25_15_561Z-debug.log
`
Log of this erros:
`
0 info it worked if it ends with ok
1 verbose cli [ '/usr/bin/node',
1 verbose cli '/usr/lib/node_modules/npm/bin/npm-cli.js',
1 verbose cli 'run',
1 verbose cli 'start',
1 verbose cli '--scripts-prepend-node-path=auto' ]
2 info using [email protected]
3 info using [email protected]
4 verbose run-script [ 'prestart', 'start', 'poststart' ]
5 info lifecycle [email protected]~prestart: [email protected]
6 info lifecycle [email protected]~start: [email protected]
7 verbose lifecycle [email protected]~start: unsafe-perm in lifecycle true
8 verbose lifecycle [email protected]~start: PATH: /usr/lib/node_modules/npm/node_modules/npm-lifecycle/node-gyp-bin:/home/otavio/dfm-front/node_modules/.bin:/home/otavio/.local/bin:/home/otavio/bin:/usr/local/bin:/usr/bin:/bin:/usr/local/sbin:/usr/lib/jvm/default/bin:/usr/bin/site_perl:/usr/bin/vendor_perl:/usr/bin/core_perl
9 verbose lifecycle [email protected]~start: CWD: /home/otavio/dfm-front
10 silly lifecycle [email protected]~start: Args: [ '-c', 'react-scripts start' ]
11 silly lifecycle [email protected]~start: Returned: code: 1 signal: null
12 info lifecycle [email protected]~start: Failed to exec start script
13 verbose stack Error: [email protected] start: `react-scripts start`
13 verbose stack Exit status 1
13 verbose stack at EventEmitter.<anonymous> (/usr/lib/node_modules/npm/node_modules/npm-lifecycle/index.js:301:16)
13 verbose stack at EventEmitter.emit (events.js:193:13)
13 verbose stack at ChildProcess.<anonymous> (/usr/lib/node_modules/npm/node_modules/npm-lifecycle/lib/spawn.js:55:14)
13 verbose stack at ChildProcess.emit (events.js:193:13)
13 verbose stack at maybeClose (internal/child_process.js:999:16)
13 verbose stack at Process.ChildProcess._handle.onexit (internal/child_process.js:266:5)
14 verbose pkgid [email protected]
15 verbose cwd /home/otavio/dfm-front
16 verbose Linux 5.1.16-arch1-1-ARCH
17 verbose argv "/usr/bin/node" "/usr/lib/node_modules/npm/bin/npm-cli.js" "run" "start" "--scripts-prepend-node-path=auto"
18 verbose node v11.15.0
19 verbose npm v6.10.0
20 error code ELIFECYCLE
21 error errno 1
22 error [email protected] start: `react-scripts start`
22 error Exit status 1
23 error Failed at the [email protected] start script.
23 error This is probably not a problem with npm. There is likely additional logging output above.
24 verbose exit [ 1, true ]
`
### Did you try recovering your dependencies?
I tried all the steps suggested however, nothing change. Same error as reported above.
I'm using ONLY npm.
`npm --version = 6.10.0`
`create-react-app 3.0.1`
### Which terms did you search for in User Guide?
`npm ERR! code ELIFECYCLE`
`Error: spawn /usr/bin/chromium ENOENT`
### Environment
System:
OS: Linux 5.1 Antergos Linux
CPU: (8) x64 Intel(R) Core(TM) i7-7700HQ CPU @ 2.80GHz
Binaries:
Node: 11.15.0 - /usr/bin/node
Yarn: Not Found
npm: 6.10.0 - /usr/bin/npm
Browsers:
Chrome: Not Found
Firefox: Not Found
npmPackages:
react: ^16.8.6 => 16.8.6
react-dom: ^16.8.6 => 16.8.6
react-scripts: 3.0.1 => 3.0.1
npmGlobalPackages:
create-react-app: 3.0.1
### Steps to reproduce
<!--
How would you describe your issue to someone who doesnβt know you or your project?
Try to write a sequence of steps that anybody can repeat to see the issue.
-->
1. remove chromium from your system.
2. npx create-react-app anyapp
3. cd anyapp
4. npm run start
### Expected behavior
Start the application fine with the demo page in localhost.
### Actual behavior
It's happening the error posted above.
### Reproducible demo
https://github.com/OtavioLara/dfm-frontend
| issue: proposal | low | Critical |
465,302,757 | go | cmd/go: `go clean <package>` downloads modules | #28680 is fixed and `go clean --modcache` command no longer donwloads modules before cleaning if no argument is given to the command.
Note however 'go clean' accepts packages parameter as an argument(which isn't relevant to `-modcache` but is still meaningful for other purposes of `go clean`). If they are given, `go clean` still downloads the modules and even updates the go.mod file.
<pre>
$ go help clean
usage: go clean [clean flags] [build flags] [packages]
...
$ export GOPATH=$(mktemp -d)
$ go1.13beta1 clean -testcache -cache -modcache
$ go1.13beta1 mod init scratch
go: creating new go.mod: module scratch
$ go1.13beta1 clean golang.org/x/text
go: finding golang.org/x/text v0.3.2
go: downloading golang.org/x/text v0.3.2
go: extracting golang.org/x/text v0.3.2
$ cat go.mod
module scratch
go 1.13
require golang.org/x/text v0.3.2 // indirect
</pre>
And the `go clean -modcache <package>` behaves differently.
<pre>
$ go1.13beta1 clean -modcache golang.org/x/text
$ go1.13beta1 clean -modcache golang.org/x/text
go: downloading golang.org/x/text v0.3.2
go: extracting golang.org/x/text v0.3.2
go: finding golang.org/x/text v0.3.2
</pre> | NeedsInvestigation,modules | low | Minor |
465,320,400 | flutter | [Request] React-like ref for widgets | ## Use case
`GlobalKey` allows other widgets to access to the `State` of a widget. But it comes with many issues:
- It's possible to read the content of a `GlobalKey` inside `build`, which is a very bad practice
- the documentation states that it is not performant
- It's difficult to make `GlobalKey` compile-time safe. There's nothing preventing the following:
```dart
Navigator(key: GlobalKey<FormState>()) // <FormState> doesn't make sense
```
- it can't be used inside a `StatelessWidget` easily without losing composition, example:
```dart
class Foo extends StatelessWidget {
final formKey = GlobalKey<FormState>();
@override
Widget build(BuildContext context) {
return Form(
key: formKey,
child: ...,
);
}
}
```
Such code is bad because if `Foo` gets recreated, then the `GlobalKey` will be recreated, which will destroy the form.
## Proposal
This proposal is about implementing an alternative to `GlobalKey`, to access the state of descendants, that is **not** a `Key`.
It'd be expressed through two things:
- A class `Ref` like so:
```dart
class Ref<T extends State> {
T get state;
}
```
- A new property on `StatefulWidget` is added:
```dart
abstract class StatefulWidget {
const Widget({Key key, Ref ref});
}
```
then all `StatefulWidget` with a public `State` are expected to expose an optional `ref`.
For example, `Form` would do:
```dart
class Form extends StatefulWidget {
Form({Key key, Ref<FormState> ref}): super(key: key, ref: ref);
}
```
Which means a `StatelessWidget` can then do: (without `FormState` being destroyed if the ref change)
```dart
class Foo extends StatelessWidget {
final formRef = Ref<FormState>();
@override
Widget build(BuildContext context) {
return Form(
ref: formRef,
onChanged: () {
// do something with formRef.state
}
child: ...,
);
}
}
```
It'd come with a few rules:
- Accessing `Ref.state` inside `build`, should be strictly forbidden. This can be done through `BuildOwner.debugBuilding`
- The `Ref` associated with a `StatefulWidget` can freely be replaced by another one without having any impact on `State`, as opposed to `Key`
- Subclasses of `StatefulWidget` are expected to specify `T` of `Ref<T>`:
DON'T
```dart
Foo({Ref ref}): super(ref: ref);
```
DO:
```dart
Foo({Ref<FooState> ref}): super(ref: ref);
```
______
This solves all the previously mentioned points because:
- it is a lot more performant then `GlobalKey` since it does nothing else besides storing a reference to `State`.
- it voluntarily can't be read inside `build`
- it can be used inside `StatelessWidget`
- it can be made type-safe, such that the following won't compile:
```dart
Form(ref: Ref<NavigatorState>())
```
| c: new feature,framework,P3,team-framework,triaged-framework | low | Critical |
465,332,842 | TypeScript | Allow configuration of missing property quickfix |
## Search Terms
`property does not exist quickfix `
`quick fix`
`create private property`
`quickfix configuration`
<!-- List of keywords you searched for before creating this issue. Write them down here so that others can find this suggestion more easily -->
## Suggestion
When referencing a property that doesn't exist within a class, you get the error `Property 'foo' does not exist on type 'MyClass'.ts(2339)`. In VS Code you can then do `cmd-.` to get the quickfix option `Declare property 'foo'`. When you select this, a property is declared, but it is created with default visibility.
Based on digging in to the code here:
https://github.com/microsoft/TypeScript/blob/15daf42b2c0bc4f06970c9e4688f1a93bff0f7a0/src/services/codefixes/fixAddMissingMember.ts#L204-L210
it doesn't look like there's anyway to configure this.
It would be really nice if there was a way to configure the quickfix functionality to default to creating properties with a given access modifier (in my case I'd like to default them to `private`). Given the upcoming `#field` [private-named fields stuff](https://github.com/microsoft/TypeScript/pull/30829), it seems like this could also be a useful way to let people decide what they want to use.
## Use Cases
I would like to have the properties created by quickfix all start as private, to encourage writing classes with strong encapsulation.
The current approach requires me to go back and modify the generated declaration every time.
## Examples
Starting code with missing property:
```typescript
export class MyClass {
public constructor(foo: number) {
this.foo = foo;
}
}
```
After applying the quickfix to the line `this.foo = foo;` it becomes:
```typescript
export class MyClass {
foo: number;
public constructor(foo: number) {
this.foo = foo;
}
}
```
but I would like some way to configure it to instead do:
```typescript
export class MyClass {
private foo: number;
public constructor(foo: number) {
this.foo = foo;
}
}
```
## Checklist
My suggestion meets these guidelines:
* [x] This wouldn't be a breaking change in existing TypeScript/JavaScript code
* [x] This wouldn't change the runtime behavior of existing JavaScript code
* [x] This could be implemented without emitting different JS based on the types of the expressions
* [x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
* [x] This feature would agree with the rest of [TypeScript's Design Goals](https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals).
| Suggestion,Awaiting More Feedback | low | Critical |
465,335,704 | rust | The "reached type-length limit" error is not very helpful | This issue is close to #58952, but I think it's different. Feel free to close it if I'm mistaken.
### The issue
Here is the code I am trying to compile: [lovasoa/seamcarving @ f6be585](https://github.com/lovasoa/seamcarving/tree/f6be585a9f21171c8fc15dcca5218c0b761b5cfa).
The compilation fails with :
```
error: reached the type-length limit while instantiating `<std::iter::Once<u32> as std::it...ving::seamfinder::SeamElem), !>>`
```
The issue probably comes from my code, and not from the compiler, but the compiler makes it quite difficult to debug !
The compiler error does not point to a precise place in the code, and does not even print the full name of the type it is trying to instantiate. I only know that is starts with `<std::iter::Once<u32> as std::it` and ends with `ving::seamfinder::SeamElem), !>>`.
Moreover, it notes :
```
note: consider adding a `#![type_length_limit="1814752"]` attribute to your crate
```
... even if the attribute is already there. | A-type-system,C-enhancement,A-diagnostics,T-compiler,A-suggestion-diagnostics,T-types | low | Critical |
465,350,898 | terminal | Incorrect DPI scaling for font preview in shell properties dialog | <!--
π¨π¨π¨π¨π¨π¨π¨π¨π¨π¨
I ACKNOWLEDGE THE FOLLOWING BEFORE PROCEEDING:
1. If I delete this entire template and go my own path, the core team may close my issue without further explanation or engagement.
2. If I list multiple bugs/concerns in this one issue, the core team may close my issue without further explanation or engagement.
3. If I write an issue that has many duplicates, the core team may close my issue without further explanation or engagement (and without necessarily spending time to find the exact duplicate ID number).
4. If I leave the title incomplete when filing the issue, the core team may close my issue without further explanation or engagement.
5. If I file something completely blank in the body, the core team may close my issue without further explanation or engagement.
All good? Then proceed!
-->
<!--
This bug tracker is monitored by Windows Terminal development team and other technical folks.
**Important: When reporting BSODs or security issues, DO NOT attach memory dumps, logs, or traces to Github issues**.
Instead, send dumps/traces to [email protected], referencing this GitHub issue.
Please use this form and describe your issue, concisely but precisely, with as much detail as possible.
-->
# Environment
```none
Windows Build Number: 10.0.18362.207
```
* This issue relates to the built-in conhost.
* Tested on a single monitor system at 200% DPI.
# Description
The font preview shown on the Fonts tab or Colours tab doesn't use the correct DPI scaling when accessed via a shortcut's property dialog. However, the same font preview shown on a console window's property dialog does use the correct scaling.
# Steps to reproduce
1. Set the system DPI scaling to be higher than 100% (I use 200%). Sign in and out if changing.
2. Find or create a shortcut to a console app (e.g. Command Prompt).
3. Open the shortcut's property dialog and go to the Fonts tab or Colours tab.
4. See that the font preview is not correctly scaled for the DPI.
5. Run the console app and open the console window's property dialog.
6. Go to the Fonts tab or Colours tab, and see that the font preview is correctly scaled for the DPI.
| Product-Conhost,Help Wanted,Issue-Bug,Area-UserInterface | low | Critical |
465,382,568 | go | x/net/publicsuffix: EffectiveTLDPlusOne accepts IP Addresses | <!-- Please answer these questions before submitting your issue. Thanks! -->
### What version of Go are you using (`go version`)?
<pre>
$ go version
go version go1.12.4 darwin/amd64
</pre>
### Does this issue reproduce with the latest release?
Yes
### What operating system and processor architecture are you using (`go env`)?
<details><summary><code>go env</code> Output</summary><br><pre>
$ go env
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/x/Library/Caches/go-build"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
GOPATH="/Users/x/go"
GOPROXY=""
GORACE=""
GOROOT="/usr/local/go"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/darwin_amd64"
GCCGO="gccgo"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/hf/v0mqyvgn6h79sjd8c8t7dy540000gn/T/go-build875757611=/tmp/go-build -gno-record-gcc-switches -fno-common"
</pre></details>
### What did you do?
By passing an IP address into this function, I am provided the last index of the Network ID, and the Host ID (3rd & 4th position).
```
package main
import (
"fmt"
"net/url"
"golang.org/x/net/publicsuffix"
)
func main() {
u, _ := url.Parse("http://192.168.1.1/")
fmt.Println(publicsuffix.EffectiveTLDPlusOne(u.Hostname()))
}
```
### What did you expect to see?
An error stating that what was provided was...
* not a valid domain
or
* an IP address
### What did you see instead?
> 1.1 <nil>
Validation should occur to ensure that what is being passed matches the named parameter, `domain`.
Validation is already present: https://github.com/golang/net/blame/da137c7871d730100384dbcf36e6f8fa493aef5b/publicsuffix/list.go#L168
To argue that this function should not be responsible for checking if this is a *valid* domain name would be counterintuitive to L168 linked above.
If this is not the responsibility of this function to ensure what is being passed is actually a domain, then I propose changing the function name to something more similar of what it does.. perhaps `AlphasBetweenLastTwoPeriodsInString` π | NeedsInvestigation | low | Critical |
465,385,805 | vscode | Hirerarchical multi-root layout | Currently, the 'folders' field of a `.code-workspace` configuration file is an array of items, each of them defining a folder. Then, all of these are shown as level-1 items in the default File Explorer. I suggest to support nesting 'folder' items with arrays, which will be layout as level-1, level-2, level-3, etc. For example:
``` json
{
"folders": [
{
"name": "Project A",
"folders": [
{
"path": "prjA/dirA",
"name": "Dir A"
},
{
"path": "prjA/dirB",
"name": "Dir B"
}
]
},
{
"name": "Project B",
"folders": [
{
"path": "prjB/frontend/src",
"name": "Frontend"
}
{
"name": "Backend",
"folders": [
{
"path": "prjB/api",
"name": "API"
},
{
"path": "prjB/lib/src",
"name": "Library"
}
]
}
]
},
{
"path": "common",
"name": "Common"
}
]
}
```
which would translate to the following File Explorer structure:
```
- Project A
- Dir A (prjA/dirA)
- Dir B (prjA/dirB)
- Project B
- Frontend (prjB/frontend/src)
- Backend
- API (prjB/api)
- Library (prjB/lib/src)
- Common (common)
```
---
Related to #74229, I believe that the most straighforward integration with this feature would be an option in the settings to display each level-1 item in a separate File Explorer View.
Alternatively, a `group` field can be added to each item defined in the multi-root configuration file (be it a folder or an array). All the items with the same `group` identifier belong to a separate TreeView.
Ref #76902.
---
Related to #76399, the `group` concept above would translate to an Editor Group. Hence, the shown tabs in a given Editor Group will depend on the 'location' ('group') of the currently active document.
---
Ref #31308.
Ref #43188.
Ref #73312.
Ref #76891. | feature-request,workbench-multiroot | high | Critical |
465,393,914 | flutter | Column and ListView documentation should talk about the "expand or scroll" use case | We have some sample code in SingleChildScrollView that talks about the "expand or scroll" and "center or scroll" cases. There's a link to it from Column, but even I, who added the link, missed it just now when scanning through. We should also have similar examples at ListView showing how to do this kind of thing in the more general "infinite list" case. For example, we should show the use case of "align a button to the bottom of the viewport unless it can scroll in which case pin it to the bottom of the list" (presumably this should be possible using SliverFillRemaining). And the SingleChildScrollView docs should probably have an animation showing what it looks like, next to the sample code.
https://twitter.com/inryaa/status/1147278514879631365
https://master-api.flutter.dev/flutter/widgets/SingleChildScrollView-class.html | framework,f: scrolling,d: api docs,c: proposal,P2,team-framework,triaged-framework | low | Minor |
465,399,796 | go | x/playground: Format button produces a spurious 'invalid module version' error for commit hashes in go.mod | `go` subcommands such as `go mod tidy`, `go test`, and `go build` automatically resolve invalid versions found in the `go.mod` file to valid ones.
However, the Playground's `Format` button does not; instead, it emits an error message like:
```
go.mod:5: invalid module version "1f3472d942ba824034fb77cab6a6cfc1bc8a2c3c": version must be of the form v1.2.3
```
This is probably due to calling out to a `golang.org/x/mod` library instead of running the `go` command directly. (See also https://github.com/golang/go/issues/32955#issuecomment-509277344 and #32614.)
CC @toothrot @dmitshur @ysmolsky | NeedsFix,modules | low | Critical |
465,426,339 | flutter | Animation in sliver renders background in wrong position | ## Steps to Reproduce
When using a `CustomScrollView` with a `AnimatedSize` widget (inside a `SliverToBoxAdapter` -> Column) which resizes based on a simple toggle and below a `Ink` with a background color, the background color is rendered in the wrong place while the `child` of the `Ink` is in the correct place at all times.
I have made a simple app which shows the problem: https://github.com/hpoul/sliver_animation_background/blob/master/lib/main.dart#L77-L91
(once i manually scroll the background renders correctly, it's only happening when the animation is triggered through the `AnimatedSize` widget. The problem only happens with the `CustomScrollView`, putting the `Column` directly into the `body` of the `Scaffold` works as intended.)
(tested on iPhone Xr 12.2 simulator, Android Simulator 8.1 and physical Android Pie device)
## Logs
```
Herbys-MacBook-Pro-2017:sliver_animation_background$ flutter doctor -v
[β] Flutter (Channel master, v1.8.1-pre.23, on Mac OS X 10.14.5 18F132, locale en-AT)
β’ Flutter version 1.8.1-pre.23 at /Users/herbert/dev/flutter/flutter
β’ Framework revision 3bf91b5436 (3 days ago), 2019-07-05 12:59:32 -0700
β’ Engine revision 3c51a7bfff
β’ Dart version 2.5.0 (build 2.5.0-dev.0.0 b5aeaa6796)
[β] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
β’ Android SDK at /Users/herbert/dev/android/sdk
β’ Android NDK location not configured (optional; useful for native profiling support)
β’ Platform android-28, build-tools 28.0.3
β’ Java binary at: /Users/herbert/Library/Application Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/183.5522156/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
β’ Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1343-b01)
β’ All Android licenses accepted.
[β] Xcode - develop for iOS and macOS (Xcode 10.2.1)
β’ Xcode at /Applications/Xcode.app/Contents/Developer
β’ Xcode 10.2.1, Build version 10E1001
β’ CocoaPods version 1.7.3
[β] iOS tools - develop for iOS devices
β’ ios-deploy 1.9.4
[β] Chrome - develop for the web
β’ Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome
[β] Android Studio (version 3.4)
β’ Android Studio at /Applications/Android Studio.app/Contents
β’ Flutter plugin version 36.1.1
β’ Dart plugin version 183.6270
β’ Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1343-b01)
[β] Android Studio (version 3.4)
β’ Android Studio at /Users/herbert/Library/Application Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/183.5522156/Android Studio.app/Contents
β’ Flutter plugin version 36.1.1
β’ Dart plugin version 183.6270
β’ Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1343-b01)
[!] IntelliJ IDEA Ultimate Edition (version 2019.1.3)
β’ IntelliJ at /Users/herbert/Applications/JetBrains Toolbox/IntelliJ IDEA Ultimate.app
β Flutter plugin not installed; this adds Flutter specific functionality.
β’ Dart plugin version 191.7830
β’ For information about installing plugins, see
https://flutter.dev/intellij-setup/#installing-the-plugins
[!] VS Code (version 1.33.1)
β’ VS Code at /Applications/Visual Studio Code.app/Contents
β Flutter extension not installed; install from
https://marketplace.visualstudio.com/items?itemName=Dart-Code.flutter
[β] Connected device (3 available)
β’ iPhone XΚ β’ D78F2299-D9F1-48CD-957C-A5118243E1A9 β’ ios β’ com.apple.CoreSimulator.SimRuntime.iOS-12-2 (simulator)
β’ macOS β’ macOS β’ darwin-x64 β’ Mac OS X 10.14.5 18F132
β’ Chrome β’ chrome β’ web-javascript β’ Google Chrome 76.0.3809.46 beta
``` | framework,a: animation,f: material design,f: scrolling,d: api docs,has reproducible steps,P2,found in release: 3.0,found in release: 3.1,team-design,triaged-design | low | Minor |
465,433,441 | go | x/crypto/ssh: SSH handshake fails over some net.Conn implementations (ex. net.Pipe) | ### What version of Go are you using (`go version`)?
Tested on:
<pre>
go version go1.12 linux/amd64
go version go1.12.4 windows/amd64
</pre>
### Does this issue reproduce with the latest release?
Yes
### What operating system and processor architecture are you using (`go env`)?
linux/windows amd64
### What did you do?
Run the following unit test:
```$ go test -timeout 30s sshproxy -run TestHandshakeOverPipe```
```go
package sshproxy
import (
"log"
"net"
"testing"
"github.com/pkg/errors"
"golang.org/x/crypto/ssh"
)
const (
testUserName = "test-user"
testUserPass = "test-password"
)
var testServerCfg = &ssh.ServerConfig{
PasswordCallback: func(c ssh.ConnMetadata, pass []byte) (*ssh.Permissions, error) {
if c.User() == testUserName && string(pass) == testUserPass {
return nil, nil
}
return nil, errors.Errorf("User %q supplied an incorrect password", c.User())
},
}
var testClientCfg = &ssh.ClientConfig{
User: testUserName,
Auth: []ssh.AuthMethod{
ssh.Password(testUserPass),
},
HostKeyCallback: func(hostname string, remote net.Addr, key ssh.PublicKey) error {
return nil
},
}
func init() {
privateKey, err := ssh.ParsePrivateKey([]byte(testPrivateKey))
if err != nil {
log.Fatalf("Unit test init: Failed to parse private key; Details: %s", err)
}
testServerCfg.AddHostKey(privateKey)
}
func TestHandshakeOverPipe(t *testing.T) {
srvConn, cliConn := net.Pipe()
defer srvConn.Close()
defer cliConn.Close()
errCh := make(chan error, 1)
go func() {
_, _, _, err := ssh.NewServerConn(srvConn, testServerCfg)
errCh <- err
}()
if _, _, _, err := ssh.NewClientConn(cliConn, "localhost", testClientCfg); err != nil {
t.Fatalf("Client SSH handshake failed; Details: %s", err)
} else if err = <-errCh; err != nil {
t.Fatalf("Server SSH handshake failed; Details: %s", err)
}
}
//redacted
//const testPrivateKey = ...
```
### What did you expect to see?
Test pass (_test passes when modified to use a real TCP connection_)
### What did you see instead?
Tests hang with both client and sever writing to write to the ``net.Conn`` during ``ssh.exchangeVersions`` called from ``clientHandshake`` and ``serverHandshake`` respectively.
```
$ go test -timeout 30s sshproxy -run TestHandshakeOverPipe
panic: test timed out after 30s
goroutine 18 [running]:
testing.(*M).startAlarm.func1()
/usr/local/go/src/testing/testing.go:1334 +0xdf
created by time.goFunc
/usr/local/go/src/time/sleep.go:169 +0x44
goroutine 1 [chan receive]:
testing.(*T).Run(0xc0000ee100, 0x659a66, 0x15, 0x663b30, 0x476aa6)
/usr/local/go/src/testing/testing.go:917 +0x37e
testing.runTests.func1(0xc0000ee000)
/usr/local/go/src/testing/testing.go:1157 +0x78
testing.tRunner(0xc0000ee000, 0xc0000a7e30)
/usr/local/go/src/testing/testing.go:865 +0xc0
testing.runTests(0xc00000ed00, 0x80c9a0, 0x2, 0x2, 0x0)
/usr/local/go/src/testing/testing.go:1155 +0x2a9
testing.(*M).Run(0xc0000d8000, 0x0)
/usr/local/go/src/testing/testing.go:1072 +0x162
main.main()
_testmain.go:44 +0x13e
goroutine 6 [select]:
net.(*pipe).write(0xc0000d8100, 0xc0000183a0, 0xc, 0x20, 0x0, 0x0, 0x0)
/usr/local/go/src/net/pipe.go:199 +0x27a
net.(*pipe).Write(0xc0000d8100, 0xc0000183a0, 0xc, 0x20, 0xc, 0xc0000183a0, 0xa)
/usr/local/go/src/net/pipe.go:179 +0x4d
golang.org/x/crypto/ssh.exchangeVersions(0x7f95454b5060, 0xc0000d8100, 0xc000016520, 0xa, 0xa, 0x8, 0x4, 0x4, 0xa, 0xc000042660)
go/pkg/mod/golang.org/x/[email protected]/ssh/transport.go:297 +0xef
golang.org/x/crypto/ssh.(*connection).clientHandshake(0xc0000d8200, 0x656b21, 0x9, 0xc00008eb60, 0xc000082a01, 0xc00006a360)
go/pkg/mod/golang.org/x/[email protected]/ssh/client.go:100 +0xe7
golang.org/x/crypto/ssh.NewClientConn(0x69e200, 0xc0000d8100, 0x656b21, 0x9, 0x810da0, 0xc0000128c0, 0x24, 0x31d, 0x4cd7d0, 0x1, ...)
go/pkg/mod/golang.org/x/[email protected]/ssh/client.go:83 +0xfe
sshproxy.TestHandshakeOverPipe(0xc0000ee100)
sshproxy/tunnel_test.go:60 +0xf3
testing.tRunner(0xc0000ee100, 0x663b30)
/usr/local/go/src/testing/testing.go:865 +0xc0
created by testing.(*T).Run
/usr/local/go/src/testing/testing.go:916 +0x357
goroutine 7 [select]:
net.(*pipe).write(0xc0000d8080, 0xc0000183c0, 0xc, 0x20, 0x0, 0x0, 0x0)
/usr/local/go/src/net/pipe.go:199 +0x27a
net.(*pipe).Write(0xc0000d8080, 0xc0000183c0, 0xc, 0x20, 0xc, 0xc0000183c0, 0xa)
/usr/local/go/src/net/pipe.go:179 +0x4d
golang.org/x/crypto/ssh.exchangeVersions(0x7f95454b5060, 0xc0000d8080, 0xc000016530, 0xa, 0xa, 0xc000042ef8, 0x78, 0x78, 0xc0000d8300, 0x4)
go/pkg/mod/golang.org/x/[email protected]/ssh/transport.go:297 +0xef
golang.org/x/crypto/ssh.(*connection).serverHandshake(0xc0000d8300, 0xc0000f2000, 0x0, 0x0, 0x0)
go/pkg/mod/golang.org/x/[email protected]/ssh/server.go:217 +0x136
golang.org/x/crypto/ssh.NewServerConn(0x69e200, 0xc0000d8080, 0x8109e0, 0x0, 0x0, 0x0, 0x0, 0x0)
go/pkg/mod/golang.org/x/[email protected]/ssh/server.go:182 +0xd6
sshproxy.TestHandshakeOverPipe.func1(0x69e200, 0xc0000d8080, 0xc00006a360)
sshproxy/tunnel_test.go:56 +0x49
created by sshproxy.TestHandshakeOverPipe
sshproxy/tunnel_test.go:55 +0xaf
FAIL sshproxy 30.012s
```
| help wanted,NeedsInvestigation | low | Critical |
465,435,131 | opencv | cv::remap artifacts with bilinear interpolation and cv::UMat | <!--
If you have a question rather than reporting a bug please go to http://answers.opencv.org where you get much faster responses.
If you need further assistance please read [How To Contribute](https://github.com/opencv/opencv/wiki/How_to_contribute).
Please:
* Read the documentation to test with the latest developer build.
* Check if other person has already created the same issue to avoid duplicates. You can comment on it if there already is an issue.
* Try to be as detailed as possible in your report.
* Report only one problem per created issue.
This is a template helping you to create an issue which can be processed as quickly as possible. This is the bug reporting section for the OpenCV library.
-->
##### System information (version)
<!-- Example
- OpenCV => 3.1
- Operating System / Platform =>
- Compiler => GCC 9.1
-->
- OpenCV => 3.4.6 (release) and 3.4.7 (dev) 1e9e2aa95
- Operating System / Platform => Arch Linux
- Compiler => GCC 9.1
##### Detailed description
I use `cv::remap` in combination with `CV_32F` maps to rectify images using a non-standard lens model. With `cv::INTER_LINEAR`, I observe regular artifacts at the left and top borders of the transformed image. The problem does not occur at the right and bottom borders or with `cv::INTER_CUBIC`. Due to the image size, what follows is only the top-left corner of the image transformed using bilinear and bicubic interpolation for comparison purposes. The border color is deliberately set to magenta to illustrate the problem.
Unfortunately, it is not easy to extract a minimum working example due to complexity of the original code. However, I'm providing the values for the x and y coordinate maps for the above image transform:
x:
<details>
```
[-1.2421091, -0.28069085, 0.6807881, 1.6423278, 2.6039281, 3.565589, 4.5273104, 5.4890928, 6.4509354, 7.4128385, 8.3748016, 9.3368254, 10.29891, 11.261054, 12.223259, 13.185524, 14.147849, 15.110234, 16.07268, 17.035185, 17.997751, 18.960375, 19.923061, 20.885805, 21.84861;
-1.2633712, -0.30193734, 0.65955734, 1.6211128, 2.5827289, 3.5444057, 4.5061431, 5.4679408, 6.4297991, 7.3917179, 8.3536968, 9.3157368, 10.277837, 11.239997, 12.202218, 13.164498, 14.12684, 15.08924, 16.051701, 17.014223, 17.976805, 18.939445, 19.902145, 20.864906, 21.827728;
-1.284614, -0.32316425, 0.6383462, 1.5999173, 2.5615492, 3.5232418, 4.4849949, 5.4468083, 6.4086823, 7.3706169, 8.332612, 9.2946672, 10.256783, 11.21896, 12.181195, 13.143492, 14.105849, 15.068266, 16.030743, 16.99328, 17.955877, 18.918533, 19.88125, 20.844027, 21.806864;
-1.305837, -0.34437162, 0.61715454, 1.5787414, 2.5403891, 3.5020971, 4.4638662, 5.4256954, 6.3875852, 7.3495355, 8.3115463, 9.2736177, 10.235749, 11.197941, 12.160193, 13.122505, 14.084878, 15.047311, 16.009804, 16.972357, 17.934969, 18.897642, 19.860374, 20.823166, 21.786018;
-1.3270406, -0.3655594, 0.59598249, 1.5575851, 2.5192485, 3.4809723, 4.4427567, 5.4046021, 6.3665075, 7.3284736, 8.2905006, 9.2525873, 10.214734, 11.176942, 12.13921, 13.101538, 14.063926, 15.026375, 15.988883, 16.951452, 17.91408, 18.876768, 19.839518, 20.802326, 21.765194;
-1.3482244, -0.3867276, 0.57483, 1.5364482, 2.4981272, 3.459867, 4.4216671, 5.3835278, 6.3454494, 7.3074312, 8.2694731, 9.231576, 10.193739, 11.155962, 12.118246, 13.080589, 14.042994, 15.005458, 15.967982, 16.930567, 17.893211, 18.855915, 19.81868, 20.781504, 21.744387;
-1.3693887, -0.40787622, 0.55369705, 1.515331, 2.4770257, 3.438781, 4.4005971, 5.3624735, 6.3244104, 7.2864079, 8.2484665, 9.2105846, 10.172763, 11.135002, 12.097301, 13.059661, 14.02208, 14.984561, 15.947101, 16.9097, 17.87236, 18.835081, 19.797861, 20.7607, 21.7236;
-1.3905334, -0.4290053, 0.53258365, 1.4942333, 2.4559436, 3.4177146, 4.3795462, 5.3414383, 6.3033915, 7.2654047, 8.227478, 9.1896124, 10.151807, 11.114061, 12.076376, 13.038752, 14.001187, 14.963683, 15.926238, 16.888855, 17.85153, 18.814266, 19.777061, 20.739918, 21.702833;
-1.4116585, -0.45011476, 0.51148981, 1.4731551, 2.4348812, 3.396668, 4.3585153, 5.3204231, 6.2823915, 7.2444205, 8.2065096, 9.1686592, 10.13087, 11.09314, 12.05547, 13.017861, 13.980313, 14.942824, 15.905396, 16.868027, 17.830719, 18.79347, 19.756281, 20.719152, 21.682083;
-1.4327641, -0.47120464, 0.49041557, 1.4520966, 2.4138381, 3.3756406, 4.3375034, 5.299427, 6.2614112, 7.2234559, 8.1855602, 9.1477261, 10.109952, 11.072238, 12.034584, 12.996991, 13.959458, 14.921985, 15.884572, 16.847219, 17.809927, 18.772694, 19.735521, 20.698408, 21.661354;
-1.45385, -0.49227494, 0.46936092, 1.4310575, 2.3928149, 3.3546329, 4.3165112, 5.2784505, 6.2404504, 7.2025104, 8.1646309, 9.126812, 10.089054, 11.051355, 12.013718, 12.97614, 13.938622, 14.901165, 15.863768, 16.826431, 17.789154, 18.751936, 19.714779, 20.677683, 21.640644;
-1.4749162, -0.51332563, 0.44832584, 1.410038, 2.3718109, 3.3336446, 4.2955389, 5.2574935, 6.2195091, 7.1815848, 8.1437206, 9.1059179, 10.068175, 11.030493, 11.99287, 12.955308, 13.917807, 14.880364, 15.842983, 16.805662, 17.7684, 18.731199, 19.694057, 20.656977, 21.619953;
-1.495963, -0.53435671, 0.42731035, 1.3890381, 2.3508267, 3.312676, 4.2745857, 5.2365561, 6.1985869, 7.1606784, 8.1228304, 9.085043, 10.047316, 11.009648, 11.972042, 12.934496, 13.89701, 14.859584, 15.822218, 16.784912, 17.747665, 18.71048, 19.673355, 20.636288, 21.599283;
-1.5169901, -0.55536819, 0.40631443, 1.3680578, 2.3298619, 3.2917268, 4.2536521, 5.2156382, 6.1776848, 7.139792, 8.1019592, 9.064187, 10.026476, 10.988825, 11.951233, 12.913703, 13.876232, 14.838821, 15.801472, 16.764181, 17.726952, 18.689781, 19.652672, 20.615622, 21.57863;
-1.5379975, -0.57636011, 0.38533813, 1.347097, 2.3089168, 3.270797, 4.232738, 5.1947398, 6.1568017, 7.1189246, 8.0811081, 9.0433512, 10.005655, 10.968019, 11.930444, 12.892929, 13.855474, 14.818079, 15.780745, 16.743471, 17.706255, 18.669102, 19.632008, 20.594973, 21.557997;
-1.5589852, -0.59733236, 0.3643814, 1.3261559, 2.287991, 3.249887, 4.2118435, 5.173861, 6.1359386, 7.0980768, 8.0602751, 9.0225344, 9.9848547, 10.947234, 11.909675, 12.872175, 13.834736, 14.797357, 15.760037, 16.722778, 17.685579, 18.648441, 19.611362, 20.574343, 21.537384;
-1.5799534, -0.618285, 0.34344429, 1.3052343, 2.2670851, 3.2289965, 4.1909685, 5.1530013, 6.1150947, 7.0772486, 8.039463, 9.0017376, 9.9640722, 10.926468, 11.888924, 12.85144, 13.814016, 14.776652, 15.739349, 16.702106, 17.664923, 18.6278, 19.590736, 20.553734, 21.51679;
-1.6009021, -0.63921803, 0.32252675, 1.2843324, 2.2461987, 3.2081256, 4.1701136, 5.1321616, 6.0942702, 7.0564399, 8.0186701, 8.9809599, 9.9433107, 10.905722, 11.868193, 12.830725, 13.793317, 14.755968, 15.71868, 16.681454, 17.644285, 18.607178, 19.570129, 20.533142, 21.496214;
-1.6218309, -0.66013145, 0.30162886, 1.2634499, 2.2253318, 3.1872742, 4.1492777, 5.1113415, 6.0734658, 7.0356507, 7.9978957, 8.9602013, 9.9225683, 10.884995, 11.847482, 12.810029, 13.772636, 14.735304, 15.698031, 16.66082, 17.623667, 18.586575, 19.549543, 20.512571, 21.475658;
-1.6427402, -0.68102527, 0.28075057, 1.2425871, 2.2044845, 3.1664424, 4.1284614, 5.0905404, 6.0526805, 7.0148807, 7.9771419, 8.9394627, 9.901845, 10.864287, 11.826789, 12.789352, 13.751975, 14.714658, 15.677402, 16.640205, 17.603067, 18.565992, 19.528975, 20.492018, 21.455122;
-1.6636299, -0.70189941, 0.25989187, 1.2217439, 2.1836567, 3.1456304, 4.1076646, 5.0697594, 6.0319147, 6.9941306, 7.9564071, 8.9187441, 9.8811407, 10.843598, 11.806117, 12.768695, 13.731334, 14.694032, 15.656791, 16.61961, 17.582489, 18.545427, 19.508427, 20.471485, 21.434605;
-1.6844999, -0.72275394, 0.23905282, 1.2009203, 2.1628487, 3.1248376, 4.0868874, 5.0489974, 6.0111685, 6.9733996, 7.9356918, 8.8980436, 9.8604565, 10.82293, 11.785463, 12.748057, 13.710711, 14.673426, 15.6362, 16.599033, 17.56193, 18.524883, 19.487898, 20.450972, 21.414106;
-1.7053502, -0.74358881, 0.21823338, 1.1801164, 2.14206, 3.1040645, 4.0661297, 5.0282555, 5.9904418, 6.9526887, 7.9149961, 8.8773642, 9.8397923, 10.80228, 11.76483, 12.727439, 13.690108, 14.652838, 15.615628, 16.578478, 17.541388, 18.504358, 19.467388, 20.430479, 21.393629;
-1.7261809, -0.76440406, 0.19743356, 1.159332, 2.1212912, 3.0833111, 4.0453916, 5.0075331, 5.9697347, 6.9319968, 7.89432, 8.8567028, 9.8191471, 10.781651, 11.744215, 12.706841, 13.669525, 14.63227, 15.595076, 16.557941, 17.520866, 18.483852, 19.446898, 20.410004, 21.373169;
-1.7469919, -0.78519964, 0.17665339, 1.1385672, 2.1005418, 3.0625772, 4.024673, 4.9868298, 5.9490471, 6.911325, 7.8736629, 8.8360615, 9.798521, 10.761041, 11.72362, 12.686261, 13.648961, 14.611722, 15.574543, 16.537424, 17.500364, 18.463366, 19.426426, 20.389547, 21.352728]
```
</details>
y:
<details>
```
[-0.80142921, -0.82269335, -0.84394169, -0.86517435, -0.88639116, -0.90759224, -0.92877752, -0.94994706, -0.97110081, -0.99223876, -1.0133609, -1.0344672, -1.0555578, -1.0766326, -1.0976915, -1.1187347, -1.139762, -1.1607735, -1.1817693, -1.2027491, -1.2237132, -1.2446613, -1.2655938, -1.2865102, -1.307411;
0.16792351, 0.14667894, 0.12545012, 0.10423703, 0.083039708, 0.061858147, 0.040692344, 0.019542305, -0.0015919654, -0.022710463, -0.043813184, -0.064900123, -0.085971281, -0.10702665, -0.12806623, -0.14909001, -0.17009799, -0.19109017, -0.21206655, -0.23302712, -0.25397187, -0.27490079, -0.29581392, -0.31671122, -0.33759266;
1.1373272, 1.1161022, 1.0948929, 1.0736994, 1.0525216, 1.0313596, 1.0102133, 0.98908263, 0.96796787, 0.94686884, 0.92578554, 0.90471804, 0.88366628, 0.86263031, 0.84161007, 0.8206057, 0.79961705, 0.7786442, 0.75768715, 0.73674589, 0.71582043, 0.69491076, 0.67401695, 0.65313888, 0.63227665;
2.1067817, 2.0855763, 2.0643866, 2.0432127, 2.0220544, 2.0009117, 1.979785, 1.958674, 1.9375786, 1.916499, 1.8954352, 1.8743871, 1.8533548, 1.8323382, 1.8113374, 1.7903523, 1.7693831, 1.7484295, 1.7274919, 1.7065699, 1.6856637, 1.6647733, 1.6438987, 1.62304, 1.6021971;
3.0762873, 3.0551014, 3.0339313, 3.0127769, 2.9916379, 2.970515, 2.9494078, 2.9283161, 2.9072404, 2.8861802, 2.8651357, 2.8441072, 2.8230941, 2.8020971, 2.7811155, 2.76015, 2.7392001, 2.7182658, 2.6973474, 2.6764448, 2.6555579, 2.6346869, 2.6138315, 2.5929921, 2.5721684;
4.0458436, 4.0246773, 4.0035267, 3.9823916, 3.9612725, 3.9401691, 3.9190812, 3.8980091, 3.8769529, 3.8559122, 3.8348873, 3.8138781, 3.7928846, 3.7719066, 3.7509446, 3.7299984, 3.7090678, 3.688153, 3.667254, 3.6463706, 3.6255031, 3.6046512, 3.5838153, 3.562995, 3.5421906;
5.0154505, 4.9943037, 4.9731727, 4.9520574, 4.9309578, 4.909874, 4.8888054, 4.867753, 4.8467159, 4.825695, 4.8046894, 4.7836995, 4.7627258, 4.7417674, 4.7208247, 4.6998978, 4.6789865, 4.6580911, 4.6372113, 4.6163473, 4.595499, 4.5746665, 4.5538497, 4.5330486, 4.5122638;
5.9851084, 5.9639812, 5.9428697, 5.9217739, 5.9006939, 5.8796296, 5.8585806, 5.8375478, 5.8165302, 5.7955284, 5.7745423, 5.753572, 5.7326174, 5.7116785, 5.6907554, 5.669848, 5.6489558, 5.6280799, 5.6072197, 5.5863748, 5.565546, 5.5447326, 5.5239353, 5.5031533, 5.4823875;
6.9548168, 6.9337091, 6.9126172, 6.891541, 6.8704805, 6.8494358, 6.8284063, 6.8073931, 6.7863951, 6.7654128, 6.7444463, 6.7234955, 6.7025599, 6.6816406, 6.6607366, 6.6398487, 6.6189761, 6.5981193, 6.5772786, 6.5564532, 6.5356436, 6.5148497, 6.4940715, 6.473309, 6.4525623;
7.9245758, 7.9034882, 7.8824158, 7.8613591, 7.8403182, 7.8192925, 7.7982831, 7.7772889, 7.7563105, 7.7353477, 7.7144008, 7.693469, 7.6725535, 7.6516533, 7.6307688, 7.6099, 7.589047, 7.5682096, 7.5473881, 7.5265822, 7.5057917, 7.4850173, 7.4642582, 7.4435148, 7.4227877;
8.8943853, 8.8733168, 8.8522644, 8.8312273, 8.8102064, 8.7891998, 8.7682104, 8.7472353, 8.7262764, 8.7053337, 8.6844053, 8.6634941, 8.6425972, 8.6217165, 8.600852, 8.5800028, 8.5591688, 8.5383511, 8.5175486, 8.4967613, 8.4759903, 8.4552355, 8.4344959, 8.4137716, 8.3930635;
9.8642454, 9.8431969, 9.8221636, 9.8011465, 9.7801447, 9.7591581, 9.7381878, 9.7172327, 9.6962929, 9.6753693, 9.6544609, 9.6335688, 9.6126919, 9.5918303, 9.5709848, 9.5501547, 9.5293407, 9.5085421, 9.4877596, 9.4669924, 9.4462404, 9.4255047, 9.4047842, 9.384079, 9.36339;
10.834157, 10.813128, 10.792114, 10.771116, 10.750134, 10.729167, 10.708216, 10.687281, 10.666361, 10.645456, 10.624568, 10.603695, 10.582837, 10.561996, 10.541169, 10.520358, 10.499563, 10.478785, 10.458021, 10.437273, 10.41654, 10.395823, 10.375123, 10.354438, 10.333768;
11.804118, 11.783109, 11.762115, 11.741137, 11.720173, 11.699226, 11.678294, 11.657378, 11.636478, 11.615593, 11.594725, 11.573871, 11.553033, 11.53221, 11.511403, 11.490612, 11.469837, 11.449077, 11.428332, 11.407604, 11.386891, 11.366194, 11.345512, 11.324846, 11.304195;
12.77413, 12.753139, 12.732165, 12.711206, 12.690264, 12.669335, 12.648424, 12.627527, 12.606647, 12.585781, 12.564931, 12.544097, 12.523279, 12.502476, 12.481688, 12.460917, 12.440161, 12.41942, 12.398695, 12.377986, 12.357292, 12.336615, 12.315952, 12.295305, 12.274674;
13.744191, 13.723221, 13.702267, 13.681328, 13.660404, 13.639496, 13.618604, 13.597726, 13.576865, 13.556019, 13.535189, 13.514375, 13.493575, 13.472792, 13.452024, 13.431272, 13.410535, 13.389813, 13.369108, 13.348418, 13.327744, 13.307085, 13.286442, 13.265815, 13.245203;
14.714304, 14.693353, 14.672418, 14.651499, 14.630594, 14.609706, 14.588833, 14.567976, 14.547133, 14.526308, 14.505497, 14.484702, 14.463923, 14.443158, 14.42241, 14.401677, 14.38096, 14.360258, 14.339572, 14.318901, 14.298246, 14.277607, 14.256983, 14.236375, 14.215782;
15.684466, 15.663535, 15.64262, 15.62172, 15.600836, 15.579967, 15.559114, 15.538276, 15.517453, 15.496646, 15.475855, 15.455079, 15.434319, 15.413575, 15.392846, 15.372132, 15.351435, 15.330752, 15.310085, 15.289434, 15.268799, 15.248178, 15.227574, 15.206985, 15.186412;
16.654678, 16.633768, 16.612871, 16.591991, 16.571127, 16.550278, 16.529444, 16.508625, 16.487823, 16.467035, 16.446264, 16.425507, 16.404766, 16.384041, 16.363333, 16.342638, 16.32196, 16.301296, 16.280649, 16.260017, 16.239401, 16.2188, 16.198215, 16.177647, 16.157091;
17.624943, 17.60405, 17.583174, 17.562313, 17.541468, 17.520639, 17.499825, 17.479025, 17.458242, 17.437475, 17.416723, 17.395987, 17.375265, 17.354559, 17.333868, 17.313194, 17.292536, 17.271891, 17.251263, 17.230652, 17.210054, 17.189472, 17.168907, 17.148357, 17.127823;
18.595255, 18.574383, 18.553526, 18.532686, 18.51186, 18.491051, 18.470255, 18.449476, 18.428713, 18.407965, 18.387232, 18.366514, 18.345812, 18.325127, 18.304455, 18.2838, 18.263161, 18.242537, 18.221928, 18.201334, 18.180758, 18.160194, 18.139648, 18.119118, 18.098602;
19.565619, 19.544767, 19.52393, 19.503107, 19.482302, 19.461512, 19.440737, 19.419977, 19.399233, 19.378504, 19.35779, 19.337093, 19.31641, 19.295744, 19.275093, 19.254457, 19.233837, 19.213232, 19.192642, 19.17207, 19.15151, 19.130968, 19.110441, 19.08993, 19.069433;
20.536032, 20.5152, 20.494383, 20.473579, 20.452793, 20.432022, 20.411266, 20.390528, 20.369802, 20.349092, 20.3284, 20.307722, 20.287058, 20.266411, 20.245779, 20.225163, 20.204563, 20.183977, 20.163408, 20.142853, 20.122314, 20.101791, 20.081284, 20.060791, 20.040314;
21.506496, 21.485683, 21.464886, 21.444103, 21.423336, 21.402584, 21.381847, 21.361128, 21.340424, 21.319733, 21.299059, 21.2784, 21.257757, 21.237129, 21.216516, 21.195919, 21.175339, 21.154772, 21.134222, 21.113688, 21.093168, 21.072664, 21.052176, 21.031702, 21.011246;
22.477009, 22.456215, 22.435438, 22.414675, 22.393927, 22.373196, 22.35248, 22.331778, 22.311092, 22.290422, 22.269768, 22.249128, 22.228504, 22.207897, 22.187304, 22.166727, 22.146164, 22.125618, 22.105087, 22.084572, 22.064072, 22.043587, 22.023117, 22.002665, 21.982225]
```
</details>
I am able to backtrace the problem to `cv::UMat` usage as input to `cv::remap`. The image does not exhibit any artifacts with `cv::Mat`. | bug,category: imgproc,category: ocl | low | Critical |
465,448,095 | You-Dont-Know-JS | "types & grammar": no more "early ReferenceError" | Update various parts of the text.
There's no such thing as "early ReferenceError" anymore (for things like `0++`); they're all just "early SyntaxError" now. https://github.com/tc39/ecma262/issues/691 | for second edition | medium | Critical |
465,459,268 | pytorch | Autograd profiler memory leak when use_cuda=True | ## π Bug
When using the autograd profiler with `use_cuda=True`, memory usage continuously increases. This behaviour does not occur when `use_cuda=False`.
## To Reproduce
```python
import torch
import torchvision
import psutil
model = torchvision.models.alexnet(pretrained=False).cuda()
x = torch.rand([1, 3, 224, 224]).cuda()
for i in range(10000):
with torch.autograd.profiler.profile(use_cuda=True):
model(x)
if i % 1000 == 0:
print("Iteration: {}, memory: {}".format(i, psutil.virtual_memory()))
```
```text
Iteration: 0, memory: svmem(total=135112507392, available=130796793856, percent=3.2, used=3056013312, free=122434646016, active=7324913664, inactive=3956400128, buffers=608055296, cached=9013792768, shared=9961472, slab=975155200)
Iteration: 1000, memory: svmem(total=135112507392, available=130689802240, percent=3.3, used=3162726400, free=122327621632, active=7371665408, inactive=3956678656, buffers=608055296, cached=9014104064, shared=10240000, slab=978624512)
Iteration: 2000, memory: svmem(total=135112507392, available=130581217280, percent=3.4, used=3271311360, free=122219036672, active=7422038016, inactive=3956678656, buffers=608055296, cached=9014104064, shared=10240000, slab=981524480)
Iteration: 3000, memory: svmem(total=135112507392, available=130470469632, percent=3.4, used=3382059008, free=122108289024, active=7472951296, inactive=3956678656, buffers=608055296, cached=9014104064, shared=10240000, slab=984805376)
Iteration: 4000, memory: svmem(total=135112507392, available=130361843712, percent=3.5, used=3490684928, free=121999663104, active=7523426304, inactive=3956678656, buffers=608055296, cached=9014104064, shared=10240000, slab=988176384)
Iteration: 5000, memory: svmem(total=135112507392, available=130251255808, percent=3.6, used=3601272832, free=121889075200, active=7574122496, inactive=3956678656, buffers=608055296, cached=9014104064, shared=10240000, slab=991485952)
Iteration: 6000, memory: svmem(total=135112507392, available=130140499968, percent=3.7, used=3712028672, free=121778319360, active=7625084928, inactive=3956678656, buffers=608055296, cached=9014104064, shared=10240000, slab=994746368)
Iteration: 7000, memory: svmem(total=135112507392, available=130031747072, percent=3.8, used=3820781568, free=121669558272, active=7675588608, inactive=3956678656, buffers=608055296, cached=9014112256, shared=10240000, slab=998010880)
Iteration: 8000, memory: svmem(total=135112507392, available=129920745472, percent=3.8, used=3931783168, free=121558556672, active=7726501888, inactive=3956678656, buffers=608055296, cached=9014112256, shared=10240000, slab=1001361408)
Iteration: 9000, memory: svmem(total=135112507392, available=129810280448, percent=3.9, used=4042248192, free=121448091648, active=7776731136, inactive=3956678656, buffers=608055296, cached=9014112256, shared=10240000, slab=1004154880)
```
## Expected behavior
System memory usage should stay roughly constant. See output of the code, only no `cuda` tensors and `use_cuda` kwarg is not set.
```python
import torch
import torchvision
import psutil
model = torchvision.models.alexnet(pretrained=False)
x = torch.rand([1, 3, 224, 224])
for i in range(10000):
with torch.autograd.profiler.profile():
model(x)
if i % 1000 == 0:
print("Iteration: {}, memory: {}".format(i, psutil.virtual_memory()))
```
```text
Iteration: 0, memory: svmem(total=135112507392, available=132605038592, percent=1.9, used=1255895040, free=124242784256, active=5647179776, inactive=3943378944, buffers=608104448, cached=9005723648, shared=1847296, slab=968876032)
Iteration: 1000, memory: svmem(total=135112507392, available=132597575680, percent=1.9, used=1263345664, free=124235264000, active=5654331392, inactive=3943436288, buffers=608116736, cached=9005780992, shared=1847296, slab=968986624)
Iteration: 2000, memory: svmem(total=135112507392, available=132597575680, percent=1.9, used=1263353856, free=124235132928, active=5654401024, inactive=3943436288, buffers=608116736, cached=9005903872, shared=1847296, slab=969125888)
Iteration: 3000, memory: svmem(total=135112507392, available=132595933184, percent=1.9, used=1264959488, free=124233482240, active=5655736320, inactive=3943436288, buffers=608120832, cached=9005944832, shared=1847296, slab=969125888)
Iteration: 4000, memory: svmem(total=135112507392, available=132596064256, percent=1.9, used=1264828416, free=124233613312, active=5655764992, inactive=3943436288, buffers=608120832, cached=9005944832, shared=1847296, slab=968994816)
Iteration: 5000, memory: svmem(total=135112507392, available=132591153152, percent=1.9, used=1269780480, free=124228661248, active=5660770304, inactive=3943477248, buffers=608120832, cached=9005944832, shared=1847296, slab=968994816)
Iteration: 6000, memory: svmem(total=135112507392, available=132590772224, percent=1.9, used=1270120448, free=124228272128, active=5660790784, inactive=3943477248, buffers=608120832, cached=9005993984, shared=1847296, slab=969003008)
Iteration: 7000, memory: svmem(total=135112507392, available=132590772224, percent=1.9, used=1270120448, free=124228272128, active=5660852224, inactive=3943477248, buffers=608120832, cached=9005993984, shared=1847296, slab=969003008)
Iteration: 8000, memory: svmem(total=135112507392, available=132589510656, percent=1.9, used=1271422976, free=124226961408, active=5660696576, inactive=3943526400, buffers=608120832, cached=9006002176, shared=1847296, slab=969048064)
Iteration: 9000, memory: svmem(total=135112507392, available=132587188224, percent=1.9, used=1273704448, free=124224638976, active=5664169984, inactive=3943526400, buffers=608124928, cached=9006039040, shared=1847296, slab=969211904)
```
## Environment
PyTorch version: 1.1.0
Is debug build: No
CUDA used to build PyTorch: 9.0.176
OS: Ubuntu 18.04.2 LTS
GCC version: (Ubuntu 7.4.0-1ubuntu1~18.04.1) 7.4.0
CMake version: version 3.10.2
Python version: 3.6
Is CUDA available: Yes
CUDA runtime version: 10.0.130
GPU models and configuration: GPU 0: TITAN Xp
Nvidia driver version: 410.48
cuDNN version: /usr/local/cuda-10.0/targets/x86_64-linux/lib/libcudnn.so.7
Versions of relevant libraries:
[pip3] numpy==1.16.4
[pip3] torch==1.1.0
[pip3] torchprof==0.1.0
[pip3] torchvision==0.3.0
[conda] Could not collect
## Additional context
<!-- Add any other context about the problem here. -->
cc @ezyang @SsnL @albanD @zou3519 @gqchen | needs reproduction,module: autograd,triaged | low | Critical |
465,473,192 | rust | Drop with guaranteed move elision | Today, calling `drop(_1)` results in the following MIR:
```rust
_2 = move _1;
std::mem::drop::<T>(_2) -> [return .., unwind ..];
```
We could instead inline this directly to a MIR drop, with no move. This makes it simpler to do some optimizations in MIR.
This issue specifically tracks having such a `drop` available in HIR lowering; whether or not to bless `std::mem::drop` with this guarantee is up for discussion.
cc @cramertj @withoutboats | C-enhancement,A-destructors,T-compiler,A-MIR,C-optimization | low | Minor |
465,473,451 | godot | Changing scripts in the script editor should reload script | <!-- Please search existing issues for potential duplicates before filing yours:
https://github.com/godotengine/godot/issues?q=is%3Aissue
-->
**Godot version:**
<!-- Specify commit hash if non-official. -->
3.1
**Issue description:**
<!-- What happened, and what was expected. -->
When you open a script in the script editor, by clicking on it in the left pane. The script is not reloaded. Currently a script is only reloaded error checked when you open it from disk (subsequently adding it to the script list), or make a change to its contents.
Lets say you have two scripts, A and B.
Script B uses script A through its class_name, but a script error in script A causes script B to correctly throw a script error/cyclic preload error.
Changing to script A, fixing the error, and changing back to script B does not resolve the error until a change is made to script B. (For example adding a space/new line, then removing it.)
| enhancement,topic:editor | low | Critical |
465,499,035 | flutter | flutter_test is missing the solo feaure | Flutter 1.5.4-1.8.1
Although mentionned in the comment, the `solo` flag is not a parameter of the`test` and `group` function. Here for test:
https://github.com/flutter/flutter/blob/c8f37a2f49a4637b3f896aef4749a343d06d09fb/packages/flutter_test/lib/src/test_compat.dart#L154-L179
| a: tests,c: new feature,framework,P3,team-framework,triaged-framework | low | Major |
465,510,891 | godot | Accessing `global_transform` from a node which is not in the tree causes errors | Godot 3.1.1
I needed to access `global_transform` from nodes in a scene that I haven't added to the scene tree, but that spammed the console with the following errors:
```
ERROR: get_global_transform: Condition ' !is_inside_tree() ' is true. returned: Transform()
At: scene/3d/spatial.cpp:266
```
I don't understand why that's an error? I know it's not in the tree (I actually don't want it to be in that case), but that surely doesn't prevent from getting global transforms *from that branch*? Because otherwise I have to compute it myself, which is silly. | enhancement,discussion,topic:core | low | Critical |
465,512,106 | react | [Umbrella] Memory Leaks | This issue is a summary of issues mentioned in https://github.com/facebook/react/pull/15157.
There are many different ways to create memory leaks with React since we give you access to the imperative power to do so. Most should be dealt with by clean up / unmount functions.
Some could be pure React bugs. Some could be related to the lack of clean up of render phase effects. Others could be related to leaks that exists but the way React works makes them larger than they otherwise would've.
# Resolved
- [x] Land https://github.com/facebook/react/pull/16115 What patterns are actually covered? It can cut down on a potentially larger leak but is that the whole leak? I could imagine some patterns where this is the complete solution but unclear if it's the complete solution for the patterns that people are actually hitting in practice.
# Actionable
I think there are at least two actionable patterns to address from #15157:
- [ ] If a handle on a DOM node is leaked, it takes the React tree with it. This is a fairly easy mistake to make and the effect is pretty high. What we would do here is special case DOM nodes with refs on them, and always detach their back pointer to the React Fiber, if it was ever fully mounted. We currently traverse these trees anyway when they get deleted. We want to stop doing this for most things but for nodes with a ref it seems minor to special case since they typically need to be invoked with null anyway.
- [ ] Investigate the source of the leak in https://github.com/jonnycornwell/potential_react_leak and fix the source of the problem.
# Unresolved
- [ ] Closing over setState/dispatch or class component instances to global state can leak too. Does this pattern warrant special casing too? Under what conditions?
- [ ] It appears Chrome (and maybe other browsers?) may retain inputs due to the Undo Stack (https://github.com/facebook/react/issues/17581)
- [ ] What other issues remain after solving the actionable above? Let's make another pass investigating if people's original issues remain.
# Won't Fix
- Side-effects in class constructor, componentWillMount, componentWillReceiveProps, componentWillUpdate, getDerivedStateFrom... and render that store a reference to anything stateful outside React won't be able to clean up. This is [documented](https://reactjs.org/blog/2018/03/27/update-on-async-rendering.html) in the 16.3 release and is a major design decision as part of the concurrent/suspense/error handling strategy.
- Effects/state retained temporarily in alternate fiber likely won't be fixed short term. This is due to how Fiber uses two trees and swaps between them. This can lead to additional values being retained until that tree gets some work on it to swap again. This was observed in the Hooks release and there are some confusing cases where a destroy function can hold onto more memory than expected in the closure. Typically this is solved by using a custom hook since that gets its own scope/closure.
- Props/child trees retained by alternate children. Similarly, children that was just removed can sometimes between retained by the alternate copy of that. That is until that node gets another update on it which clears out the old children. These cases are fairly unusual and fix themselves eventually as the app lives on. | React Core Team | medium | Critical |
465,514,109 | pytorch | "CrossEntropyLoss" should mention in its name that it takes softmax for target | https://stackoverflow.com/questions/49390842/cross-entropy-in-pytorch
https://discuss.pytorch.org/t/why-does-crossentropyloss-include-the-softmax-function/4420
https://discuss.pytorch.org/t/do-i-need-to-use-softmax-before-nn-crossentropyloss/16739
people keep asking questions like this for the name is not clear | module: nn,module: loss,triaged | low | Minor |
465,520,249 | godot | Scaling down a child/inherited root-scene (enemy scene) does not scale the scene in the top-most scene/level (level scene) | <!-- Please search existing issues for potential duplicates before filing yours:
https://github.com/godotengine/godot/issues?q=is%3Aissue
-->
**Godot version:**
3.1.1 official stable
**OS/device including version:**
Windows 7 SP 1 64bit
**Issue description:**
https://www.youtube.com/watch?v=2L67F8kpJ7k
| bug,topic:import | low | Major |
465,530,373 | node | [C++ Lint Rule] #define indentation is Inconsistent | I was recently going through the source code, trying to familiarize myself with the codebase, and I noticed that there's no consistent rule for how #defines are indented.
For example, in `node_main.cc`, there's no indentation at all [in this](https://github.com/nodejs/node/blob/master/src/node_main.cc#L76:L88) `#ifdef` block.
However, in other places, like `node.h`, [there's a space](https://github.com/nodejs/node/blob/master/src/node.h#L44:L51) between the `#` and the `define` to indicate a kind of indentation.
There also seems to be inconsistency with how many spaces/tabs should go after the #define variable name and the value, as seen [here](https://github.com/nodejs/node/blob/master/src/node.h#L46).
Can we come up with a rule for this and add it to the [C++ Style Guide](https://github.com/nodejs/node/blob/master/CPP_STYLE_GUIDE.md)? Maybe even add a rule to the linter?
To get started with the rules we can to define, some questions are:
1. Should #defines inside of braces be indented?
2. When should `#ifdef X` be used vs. `if defined(X)`?
3. What should the indentation pattern be for `#define`/`#ifdef`/`#if defined`/`#ifndef`? | help wanted,c++ | low | Minor |
465,533,663 | svelte | Svelte suspense (request for comments) | After reading [this issue](https://github.com/sveltejs/svelte/issues/1736), I came up with a [Suspense component for Svelte](https://github.com/brucou/svelte-suspense-component), replicating the behaviour of [React Suspense](https://css-tricks.com/reacts-experimental-suspense-api-will-rock-for-fallback-ui-during-data-fetches/). No React Cache, no throwing promises, no modifying your component to fit a use case, just Svelte component composition. A demo is available in the [corresponding GitHub repository](https://github.com/brucou/svelte-suspense-app). Note that I could not have the demo running in Svelte REPL due to some issues with loading the `axios` package.
The behaviour of the Suspense component is implemented with the [Kingly](https://github.com/brucou/kingly) state machine library. The summary of 'findings' can be found [here](https://brucou.github.io/documentation/v1/examples/svelte%20suspense.html). For info, here is the underlying state machine specifying the suspense behaviour:
The demo showcases the API and I will quickly illustrate it here. The demo consists of loading a gallery of images. The suspense functionality is applied twice: when fetching the remote data containing the image URLs, and then for each image which is subsequently downloaded. While the remote data is fetched, a spinner will display if fetching takes more than a configurable time. Similarly, images placeholder will also display a spinner if downloading the image takes more than a configurable time.
Firstly, the suspense functionality for the remote data fetching is implemented as follows:
```js
<script>
... a bunch of imports
const iTunesUrl = `https://itunes.apple.com/in/rss/topalbums/limit=100/json`;
function fetchAlbums(intents){
const {done, failed} = intents;
axios.get(iTunesUrl)
.then(res => res.data.feed.entry)
.then(done)
.catch(failed)
}
</script>
<div class="app">
<Header />
<div class="albums">
<Suspense task={fetchAlbums} let:data={albums} timeout=10>
<div slot="fallback" class="album-img">
<img alt="loading" src="https://media.giphy.com/media/y1ZBcOGOOtlpC/200.gif" />
</div>
<div slot="error" class="album-img">
<h1>ERROR!</h1>
</div>
<LazyLoadContainer>
{#if albums}
{#each albums as album, i}
<LazyLoad id="{i}">
<Album {album} />
</LazyLoad >
{/each}
{/if }
</LazyLoadContainer>
</Suspense>
</div>
</div>
```
Note that the fetch task and minimum time (`timeout`) before displaying the spinner is passed as parameters of the `Suspense` component, while the fetched data is exposed to the slot component through the `data` property. Note also how the fetching function is passed the `done` and `failed` callback to signal successful completion or error of the remote fetching.
The fallback slot is displayed when the timeout is expired. The error slot is displayed when fetching the data encounters an error.
Secondly, the `Album` component suspense functionality is implemented as follows:
```js
<ul class="album">
<li class="album-item">
<Suspense let:intents={{done, failed}} timeout=0>
<div slot="fallback" class="album-img">
<img alt="loading" src="https://media.giphy.com/media/y1ZBcOGOOtlpC/200.gif" />
</div>
<a href={link} target="blank" class="link">
<img class="album-img"
on:load={done}
src={image}
alt={'itunes' + Math.random()} />
</a>
</Suspense>
</li>
<li class="title album-item">
<a href={link} target="blank" class="link">
{title.slice(0, 20)}..</a></li>
<li class="price album-item">Price:{price}</li>
<li class="date album-item">Released:{formatDate(date, "MMM Do YY")}</li>
</ul>
```
This time the `Suspense` component passes `done` and `failed` callbacks to its children slots. When the image is loaded, the `done` callback is run.
This works well and I believe the API separates well the suspense functionality or concern from the slots. What we basically have is parent and children components communicating through events, except that the event comes included in the callback. As the demo shows, there is also no issues with nesting `Suspense` components.
This GitHub issues has two purposes:
- gettign feedback on the API
- giving feedback on Svelte slot composition
The first point is more about hearing from you guys.
About the second point:
- slot composition is a powerful and flexible mechanism, specially in conjunction with scoped slots
- however, a few things would be nice:
1. ~~being able to operate on the slot as if it were a regular html element. This mean the ability to style a slot with classes or possibly other attributes (`<slot class='...' style='...'> </slot>`).~~ Add some extra attributed to cover **generic** needs, i.e. needs that are **independent of the content of the slot**. To implement the suspense functionality I had to resort to hide the default slot with `display:none`. Unfortunately to do that I had to wrap the slot around a `div` element, which can have side effects depending on the surrounding css. A syntax like `<slot show={show}> </slot>` would have been ideal. After thinking some more, I think that slot cannot be considered as regular HTML elements but as an abstract container for such elements. The operations allowed on slots should be operation on the container, not on the elements directly. Styling or adding classes an abstract container does not carry an obvious meaning, as the container is not a DOM abstraction. The current operations I see existing on the container are `get` (used internally by Svelte to get the slot content), `show` could be another one. The idea is that if you have a Container type, and a Element type, your container is `C<E>`. If you do operations that are independents of `E`, you can do only a few things like use E (`get`), ignore E (don't use the slot), repeat E (not sure how useful that would be), conditionally use E (`show`, of type Maybe<E>). Using any knowledge about the `E` I think leads to crossing abstraction boundaries which might not be a good thing future-wise.
2. [having slots on component just like if components were regular elements](https://github.com/sveltejs/svelte/issues/2080)
3. having dynamic slots. In the `Suspense` component, I use `if/then/else` to pick up the slot to display, which works fine (see code below). It would be nice however to have `<slot name={expression ...}>`:
```html
{#if stillLoading }
<slot name="fallback" dispatch={next} intents={intents} ></slot>
{:else if errorOccurred }
<slot name="error" dispatch={next} intents={intents} data={data}></slot>
{:else if done }
<slot dispatch={next} intents={intents} data={data}></slot>
{/if}
<div class="incognito">
<slot dispatch={next} intents={intents} ></slot>
</div>
```
I am not really strong about the dynamic slots. It might add some complexity that may be best avoided for now. The first and second point however I believe are important for abstraction and composition purposes. My idea is to use Svelte components which only implement behaviour and delegate UI to their children slots (similar to [Vue renderless components](https://css-tricks.com/building-renderless-vue-components/)). Done well, with this technique you end up with logic in logic components, and the view in stateless ui elements.
The technique has additionally important testing benefits (the long read is [here](https://medium.com/dailyjs/user-interfaces-you-can-trust-with-state-machines-49de7fa138a6)).
For instance the behaviour of the `Suspense` state machine can be [tested independently of Svelte](https://github.com/brucou/suspense-fsm/blob/master/tests/oracle-specs.js) - and the browser, and with using a state machine, tests can even be automatically generated (finishing that up at the moment). Last, the state machine library can compile itself away just like Svelte does :-) (the implementation is actually using the [compiled machine](https://github.com/brucou/suspense-fsm/blob/master/src/compiled-fsm.js)).
About testing stateless components, Storybook can be set to good purpose. What do you Svelte experts and non experts think? I am pretty new with Svelte by the way, so if there is any ways to do what I do better, also please let me know.
| feature request | medium | Critical |
465,542,055 | flutter | Could you add similar to the z-index function of CSS to positioned? | Rather than the order of Positioned widget in Stack widget | c: new feature,framework,P3,team-framework,triaged-framework | low | Major |
465,547,929 | rust | Where clause causes type checking to spuriously fail | I have the following code on Rust 1.36.0 Stable ([playground](https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=d0008e38e2daa9c21ff2acc813d67c83)):
```rust
trait Foo<Input> {
type Output;
}
trait Bar {
type Input;
fn baz<F: Foo<Self::Input>>() -> F::Output
where
F::Output: Default;
}
impl<T> Bar for T {
type Input = T;
fn baz<F: Foo<Self::Input>>() -> F::Output
where
F::Output: Default,
{
}
}
```
I would expect this to compile, but Rust seems confused by the fact that, in the `<T as Bar>::baz` implementation, the `F` type parameter is both `Foo<Self::Input>` and `Foo<T>` (`T` and `Self::Input` are the same type) and complains that it expects `F` to also implement `Foo<T>`:
```text
error[E0277]: the trait bound `F: Foo<T>` is not satisfied
--> src/lib.rs:16:5
|
16 | / fn baz<F: Foo<Self::Input>>() -> F::Output
17 | | where
18 | | F::Output: Default,
19 | | {
20 | | }
| |_____^ the trait `Foo<T>` is not implemented for `F`
|
= help: consider adding a `where F: Foo<T>` bound
```
However, following the advice of adding a `Foo<T>` bound, Rust is again confused by thinking that `Foo<Self::Input>` and `Foo<T>` are two different traits:
```text
error[E0221]: ambiguous associated type `Output` in bounds of `F`
--> src/lib.rs:18:9
|
2 | type Output;
| ------------
| |
| ambiguous `Output` from `Foo<T>`
| ambiguous `Output` from `Foo<<T as Bar>::Input>`
...
18 | F::Output: Default,
| ^^^^^^^^^ ambiguous associated type `Output`
error[E0221]: ambiguous associated type `Output` in bounds of `F`
--> src/lib.rs:16:38
|
2 | type Output;
| ------------
| |
| ambiguous `Output` from `Foo<T>`
| ambiguous `Output` from `Foo<<T as Bar>::Input>`
...
16 | fn baz<F: Foo<Self::Input>>() -> F::Output
| ^^^^^^^^^ ambiguous associated type `Output`
```
| A-type-system,A-trait-system,A-associated-items,T-compiler,C-bug,T-types,fixed-by-next-solver | low | Critical |
465,557,208 | vue | Vue does not work properly when setting the SVG style property in a lower version of the android browser | ### Version
2.6.10
### Reproduction link
[https://codepen.io/anon/pen/XLyPJe](https://codepen.io/anon/pen/XLyPJe)
### Steps to reproduce
environment:
- qqBrowser 4.4
- android 4.2.2
- userAgent Mozilla/5.0 (Linux; U; Android 4.2.2; zh-cn; Coolpad 8297 Build/JDQ39) AppleWebKit/533.1 (KHTML, like Gecko)Version/4.0 MQQBrowser/4.4 Mobile Safari/533.1
### What is expected?
render normally
### What is actually happening?
alert
TypeError Cannot set property 'undefined' of null
---
if i remove `style="stroke: #FFDA05;"` on SVG, it will be ok
<!-- generated by vue-issues. DO NOT REMOVE --> | need repro | medium | Critical |
465,565,884 | pytorch | caffe_translator TranslateCrop fails when more than one dimensions is cropped | ## π Bug
Trying to convert Caffe FCN network (uses 2D WxH Crop) and getting error:
`RuntimeError: [enforce fail at c:\work\glow\pytorch\caffe2\operators\slice_op.h:82] dim == -1. 2 vs -1. Currently only possible to slice in 1 dimension.`
I plan to fix this by replacing the current logic in `TranslateCrop`, that builds a multidimensional Slice, with the logic where a multidim Crop is implemented as multiple 1D Slice operators (and approach already seen in some ONNX models).
Before doing this, I would like to hear why `TranslateCrop` has support for multidim slicing that can't get verified - a multidim Crop will always hit that `slice_op.h` assert, right ?
I am wary of changing the implementation (rather than adding my own, under a special case) before understanding the logic behind the current implementation. | caffe2 | low | Critical |
465,590,723 | godot | Possibly security issues found by FlawFinder(Mitre CWE) | **Godot version:**
3.2.dev.custom_build. 56269e2db
**Issue description:**
I recently checked Godot with FlawFinder and it found a lot of possible security issues. Some can be a false positives or informational, but I think that is good to look at it.
Command(go to Godot folder first)
`flawfinder -S -H * > /home/rafal/flawfinder.html`
Report in HTML(just delete txt from file name) - [flawfinder2.html.txt](https://github.com/godotengine/godot/files/3371421/flawfinder2.html.txt)
and QT Creator tasks(also delete txt from file name) - [flawfinder.tasks.txt](https://github.com/godotengine/godot/files/3371426/flawfinder.tasks.txt)
To properly configure and QT Creator tasks, change each `/home/rafal/Pulpit/godot/` in tasks file to your own Godot destination and open QT Creator with parameter `qtcreator filawfinder.tasks` (extension must be exactly `tasks`)
Some of CWE reports
vfprintf: If format strings can be influenced by an attacker, they can be exploited (<a href="http://cwe.mitre.org/data/definitions/134.html">CWE-134</a>). Use a constant for the format specification.
vsnprintf: If format strings can be influenced by an attacker, they can be exploited, and note that sprintf variations do not always \0-terminate (<a href="http://cwe.mitre.org/data/definitions/134.html">CWE-134</a>). Use a constant for the format specification.
sprintf: Does not check for buffer overflows (<a href="http://cwe.mitre.org/data/definitions/120.html">CWE-120</a>). Use sprintf_s, snprintf, or vsnprintf.
readlink: This accepts filename arguments; if an attacker can move those files or change the link content, a race condition results. Also, it does not terminate with ASCII NUL. (<a href="http://cwe.mitre.org/data/definitions/362.html">CWE-362</a>, <a href="http://cwe.mitre.org/data/definitions/20.html">CWE-20</a>). Reconsider approach.
| bug,topic:core | low | Minor |
465,729,766 | go | strings: ToLower gives wrong result for uppercase Ξ£ in the word-final position | <!-- Please answer these questions before submitting your issue. Thanks! -->
### What version of Go are you using (`go version`)?
<pre>
$ go version
go version go1.12.5 darwin/amd64
</pre>
### Does this issue reproduce with the latest release?
yes
### What operating system and processor architecture are you using (`go env`)?
<details><summary><code>go env</code> Output</summary><br><pre>
$ go env
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/k/Library/Caches/go-build"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
GOPATH="/Users/k/go"
GOPROXY=""
GORACE=""
GOROOT="/usr/local/go"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/darwin_amd64"
GCCGO="gccgo"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/kw/93jybvs16_954hytgsq6ld7r0000gn/T/go-build305684975=/tmp/go-build -gno-record-gcc-switches -fno-common"
</pre></details>
### What did you do?
<!--
If possible, provide a recipe for reproducing the error.
A complete runnable program is good.
A link on play.golang.org is best.
-->
https://play.golang.org/p/fEDCPSV7Dqi
### What did you expect to see?
The program output should be `Ξ²οΈΞ΄βοΈΟ` because if you lowercase `Ξ£` at the last position of the word it becomes `Ο`. See https://en.wikipedia.org/wiki/Sigma
> Sigma (uppercase Ξ£, lowercase Ο, lowercase in word-final position Ο;
### What did you see instead?
The output is `Ξ²οΈΞ΄βοΈΟ`.
---
I am not sure it is the only case in all languages when lower case depends on the position. I just faced different behavior with python code:
```python
t = "Ξ²οΈΞβοΈΞ£"
print(t.lower()) # output: Ξ²οΈΞ΄βοΈΟ
``` | NeedsInvestigation | low | Critical |
465,766,485 | godot | Dialog for selecting external editor closes when clicked quickly after enabling external editor (fixed in `master`) | <!-- Please search existing issues for potential duplicates before filing yours:
https://github.com/godotengine/godot/issues?q=is%3Aissue
-->
**Godot version:**
<!-- Specify commit hash if non-official. -->
master https://github.com/godotengine/godot/commit/8d6a95347537c5e3084f269bdf98d1128b67b29b
**OS/device including version:**
<!-- Specify GPU model and drivers if graphics-related. -->
Windows 10 1903 64 bit.
**Issue description:**
<!-- What happened, and what was expected. -->
Dialog for selecting External editor closes when clicked quickly after enabling external editor checkbox.
**Steps to reproduce:**
1. Enable Use External Editor.
2. Quickly, within next 2 or 3 seconds, click the folder button of Select exec.
Dialog will close after a second.
Clicking it again after this, works as as normal i.e, doesn't close it abruptly.
To reproduce again, uncheck and start with 1.
Note: If we wait a few seconds after enabling Use External Editor and then select exec path folder button, the dialog doesn't close.
**Minimal reproduction project:**
<!-- Recommended as it greatly speeds up debugging. Drag and drop a zip archive to upload it. -->
Any project. | bug,topic:editor,confirmed,usability | low | Critical |
465,912,791 | flutter | [Test] Migrate mock_canvas.dart into flutter_test. | ## Use case
As a Flutter user, I want to use the `paints` matcher in my widget tests to verify the color of a `ShapeBorder` being drawn.
This can currently only be done in [the flutter framework](https://github.com/flutter/flutter/blob/a429991a150e7e297d9e9afd303cf6210913b234/packages/flutter/test/material/outline_button_test.dart#L609), because we do not export the [`mock_canvas.dart`](https://github.com/flutter/flutter/blob/master/packages/flutter/test/rendering/mock_canvas.dart) file.
## Proposal
Migrate [`mock_canvas.dart`](https://github.com/flutter/flutter/blob/master/packages/flutter/test/rendering/mock_canvas.dart) into the `flutter_test` package, so that anyone who imports `packages:flutter_test/flutter_test.dart` can use the `paints` matcher in their widget tests.
| a: tests,framework,customer: google,c: proposal,P3,team-framework,triaged-framework | low | Minor |
465,932,829 | vscode | [css] Shorthand properties: show label for each value in hover | <!-- Please search existing issues to avoid creating duplicates. -->
<!-- Describe the feature you'd like. -->
I'd like to have VS Code showing _box-shadow,_ _text-shadow_, _margin_ and _padding_ **options to be filled** while we are using those features, like in Dreamweaver.
...
| feature-request,css-less-scss | low | Major |
465,935,635 | go | cmd/compile: suboptimal code generated for simple integer comparison if-block | ### What version of Go are you using (`go version`)?
<pre>
$ go version
go1.12.7 darwin/amd64
</pre>
### Does this issue reproduce with the latest release?
Yes
### What operating system and processor architecture are you using (`go env`)?
<details><summary><code>go env</code> Output</summary><br><pre>
$ go env
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/stanevt/Library/Caches/go-build"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
GOPATH="/Users/stanevt/go"
GOPROXY=""
GORACE=""
GOROOT="/usr/local/go"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/darwin_amd64"
GCCGO="gccgo"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/zx/b2z35dfn0272q_n6g410wv340000gn/T/go-build707218538=/tmp/go-build -gno-record-gcc-switches -fno-common"
</pre></details>
### What did you do?
The program linked below generates an array of random uint8s and then repeatedly runs a function that finds the second highest value in the array of random uint8s. The logic inside the inner loop is simple, it keeps track of the highest value and the second highest value using an if-else condition.
The problem is that the code generated by the compiler using the naive implementation (shown in max2_slow() in the example) runs slow -- 810 ms for the test. Adding a `continue` statement in the final else block generates better code that runs the test in 540 milliseconds.
For comparison, the same logic as the max2_slow, written in JavaScript runs the same test in 690 ms and it doesn't make a difference if the logic is converted to if-continue.
Just for reference, the same logic in C runs much faster (490ms without loop unrolling, 350 with unrolling), but the C compiler seems to make use of conditional move instructions, which neither Golang nor V8 seem able to generate.
The program:
https://play.golang.org/p/uV2tVrLifCq
(Note that timings will not show in the web based play page, because it does not have a functioning clock)
### What did you expect to see?
I would expect the code generated for the plain if-else condition to run as fast as the code generated by manually adding "continue" statement.
### What did you see instead?
The code generated by the if-else condition runs 50% slower compared to the code with the artificially added `continue` statement.
| Performance,NeedsInvestigation,compiler/runtime | low | Critical |
465,972,877 | go | x/website: lighter text reduces contrast/readability | New design of golang.org uses lighter color for text (#3e4042) and links (#007d9c).
This makes reading more strenuous on the eyes, especially for navigating stdlib docs. | NeedsInvestigation,website | low | Major |
466,008,842 | rust | Tracking issue for Iterator::partition_in_place | ```rust
/// Reorder the elements of this iterator *in-place* according to the given predicate,
/// such that all those that return `true` precede all those that return `false`.
/// Returns the number of `true` elements found.
fn partition_in_place<'a, T: 'a, P>(mut self, ref mut predicate: P) -> usize
where
Self: Sized + DoubleEndedIterator<Item = &'a mut T>,
P: FnMut(&T) -> bool,
```
`feature = "iter_partition_in_place"`
ref: #62278 | T-libs-api,B-unstable,C-tracking-issue,A-iterators,Libs-Tracked,Libs-Small | medium | Critical |
466,009,240 | rust | Tracking issue for Iterator::is_partitioned | ```rust
/// Checks if the elements of this iterator are partitioned according to the given predicate,
/// such that all those that return `true` precede all those that return `false`.
fn is_partitioned<P>(mut self, mut predicate: P) -> bool
where
Self: Sized,
P: FnMut(Self::Item) -> bool,
```
`feature = "iter_is_partitioned"`
ref: #62278
## Unresolved questions
- [ ] Do we want this function at all? (Motivating use cases would be useful.)
- [ ] Would `is_sorted_by_key` already cover all use cases? | T-libs-api,B-unstable,C-tracking-issue,A-iterators,Libs-Tracked | low | Major |
466,023,473 | angular | Service Worker is blocking CSP violation reports | <!--π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
Oh hi there! π
To expedite issue processing please search open and closed issues before submitting a new one.
Existing issues often contain information about workarounds, resolution, or progress updates.
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
-->
# π bug report
### Affected Package
<!-- Can you pin-point one or more @angular/* packages as the source of the bug? -->
<!-- βοΈedit: --> The issue is caused by package @angular/service-worker
### Is this a regression?
<!-- Did this behavior use to work in the previous version? -->
<!-- βοΈ--> Unknown
### Description
<!-- βοΈ--> My page includes a CSP (Content Security Policy) violation. The header specifies a reportURI. When the browser attempts to send the violation report that request is handled by the service worker. The service worker fails to send the report with this error:
`Fetch API cannot load https://mikvah.report-uri.com/r/d/csp/reportOnly. Request mode is "no-cors" but the redirect mode is not "follow".
(anonymous) @ ngsw-worker.js:2709
`
## π¬ Minimal Reproduction
Have a webserver serve an application that creates a CSP violation, for example send a header like:
`content-security-policy-report-only: img-src www.permitted.com; report-uri https://a-diffefrent-domain.com/r/d/csp/reportOnly'
and include an img tag for an image from a different domain (aside from permitted.com)
Ensure that your Angular setup creates a service worker.
Open the page, triggering a violation and a report.
## π₯ Exception or Error
<pre><code>
<!-- If the issue is accompanied by an exception or an error, please share it below: -->
<!-- βοΈ-->
Fetch API cannot load https://mikvah.report-uri.com/r/d/csp/reportOnly. Request mode is "no-cors" but the redirect mode is not "follow".
(anonymous) @ ngsw-worker.js:2709
</code></pre>
## π Your Environment
**Angular Version:**
<pre><code>
<!-- run `ng version` and paste output below -->
<!-- βοΈ-->
_ _ ____ _ ___
/ \ _ __ __ _ _ _| | __ _ _ __ / ___| | |_ _|
/ β³ \ | '_ \ / _` | | | | |/ _` | '__| | | | | | |
/ ___ \| | | | (_| | |_| | | (_| | | | |___| |___ | |
/_/ \_\_| |_|\__, |\__,_|_|\__,_|_| \____|_____|___|
|___/
Angular CLI: 8.1.0
Node: 10.15.3
OS: darwin x64
Angular: 8.1.0
... animations, cli, common, compiler, compiler-cli, core, forms
... language-service, platform-browser, platform-browser-dynamic
... platform-server, router, service-worker
Package Version
-----------------------------------------------------------
@angular-devkit/architect 0.801.0
@angular-devkit/build-angular 0.801.0
@angular-devkit/build-optimizer 0.801.0
@angular-devkit/build-webpack 0.801.0
@angular-devkit/core 8.1.0
@angular-devkit/schematics 8.1.0
@angular/pwa 0.801.0
@ngtools/webpack 8.1.0
@schematics/angular 8.1.0
@schematics/update 0.801.0
rxjs 6.5.2
typescript 3.4.5
webpack 4.35.2
</code></pre>
**Anything else relevant?**
<!-- βοΈIs this a browser specific issue? If so, please specify the browser and version. -->
Google Chrome Version 75.0.3770.100
<!-- βοΈDo any of these matter: operating system, IDE, package manager, HTTP server, ...? If so, please mention it below. -->
| type: bug/fix,help wanted,freq1: low,area: service-worker,cross-cutting: CSP,state: needs more investigation,P3 | low | Critical |
466,037,194 | TypeScript | Refactoring: Generate type annotation from inferred type | ## Search Terms
<!-- List of keywords you searched for before creating this issue. Write them down here so that others can find this suggestion more easily -->
refactoring
quick
fix
add
inferred
type
## Suggestion
VS Code should provide a refactoring command for generating a type annotation.
## Use Cases
In our code base, we use the TSLint's [typedef rule](https://palantir.github.io/tslint/rules/typedef/) to enforce type annotations. For example:
```ts
// TSLINT ERROR
const map = this.getMap();
const value = map.getValue(someKey);
// GOOD
const map: Map<string, CatalogItem> = this.getMap();
const value: CatalogItem = map.getValue(someKey);
```
It's true that these types can usually be inferred by the compiler. However, requiring people to write explicit annotations makes code more readable, especially in situations where IntelliSense is unavailable. For example: When reviewing a GitHub pull request, or printing a Git history, we get no help from IntelliSense.
## Details
VS Code should provide a refactoring command for generating a type annotation. For example, if I right-click on `map` in this code...
```ts
const map = this.getMap();
```
...then I should be able to do `Refactor -> Add Type`, and it will convert it to the good form shown above.
Although this is a super easy operation for the compiler engine, I cannot seem to find an implementation of this feature.
I found a couple projects [typescript-plugin-add-type](https://github.com/cancerberoSgx/typescript-plugins-of-mine/tree/master/typescript-plugin-add-type) and [typescript-plugin-proactive-code-fixes](https://github.com/cancerberoSgx/typescript-plugins-of-mine/tree/master/typescript-plugin-proactive-code-fixes). However, they aren't usable:
- They aren't maintained any more
- The latest release is incompatible with the latest VS Code
- They are modeled as **compiler plugins**
Representing refactoring operations as **compiler plugins** doesn't seem like the best design:
- The refactoring engine will malfunction unless the `npm install` is in a good state, which is not always the case for a project that is "under construction"
- The plugin will have to be added separately to each project. It would be much more convenient to install it once (e.g. a VS Code extension), and then be able to use it anywhere.
Since the implementation is relatively simple, this seems like a good candidate for a built-in feature.
## Checklist
My suggestion meets these guidelines:
* [x] This wouldn't be a breaking change in existing TypeScript/JavaScript code
* [x] This wouldn't change the runtime behavior of existing JavaScript code
* [x] This could be implemented without emitting different JS based on the types of the expressions
* [x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
* [x] This feature would agree with the rest of [TypeScript's Design Goals](https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals).
| Suggestion,Awaiting More Feedback,Domain: Refactorings | low | Critical |
466,045,765 | pytorch | BFloat16 numeric limits should contain more info | BFloat16 numeril limits should contain more info like:
- is_modulo
- is_bounded
- has_denorm
- has_signaling_NaN
- etc.
| triaged,enhancement,module: bfloat16 | low | Minor |
466,047,772 | flutter | iOS integration test dual view crashes | Run the app in https://github.com/flutter/flutter/tree/master/dev/integration_tests/ios_add2app/ios_add2app.xcworkspace
Tap the Dual Flutter View (cold) button. Press either of the POP buttons in the next page.
EXC_BAD_ACCESS | a: tests,team,c: crash,platform-ios,engine,a: existing-apps,P2,team-ios,triaged-ios | low | Critical |
466,057,344 | vue | Wrong definition of the type AsyncComponentFactory | ### Version
2.6.10
### Reproduction link
[https://github.com/vuejs/vue](https://github.com/vuejs/vue)
### Steps to reproduce
1. compare the [AsyncComponentFactory](https://github.com/vuejs/vue/blob/dev/types/options.d.ts) definition with the [document](https://vuejs.org/v2/guide/components-dynamic-async.html#Handling-Loading-State)
### What is expected?
attribute 'component' should be a promise
### What is actually happening?
AsyncComponentPromise
---
I'm looking forward to your solution to this [issue](https://github.com/vuejs/vue/issues/9788)
<!-- generated by vue-issues. DO NOT REMOVE --> | good first issue,typescript,has PR | medium | Critical |
466,082,360 | rust | wasm test failures do not contain error messages | When our tests fail in bors on a wasm target, there is no error message except `RuntimeError: unreachable` ([example](https://dev.azure.com/rust-lang/rust/_build/results?buildId=2616)). There is nothing to print the panic message to the console.
I think this could be fixed by adding [console_error_panic_hook](https://github.com/rustwasm/console_error_panic_hook) as dependency somehow, but I'm not quite sure how to do this.
Here's an example project that sets up this dependency to run with a test: [async-fn-size](https://github.com/Mark-Simulacrum/async-fn-size). Thanks to @Mark-Simulacrum for figuring this out! | A-testsuite,O-wasm,C-bug | low | Critical |
466,157,535 | godot | KinematicBody does not collide with new position of a moved KinematicBody - can tunnel through | **Godot version:** 3.1.1
**OS/device including version:** Windows 8.1
**Issue description:**
If two kinematic bodies move toward each other using move_and_collide() in the same frame, they can intersect, or even tunnel through, since the collision does not seem to take into account the updated position of the KinematicBody that moved first.
**Steps to reproduce:**
Put one kinematic body above the other with space in between. Move the bottom kinematic body up toward the top body using move_and_collide(). In the same physics process frame, move the top body down below the new position of the bottom body. Note that the top body can partially (or even completely, if the movement is large enough) pass through the bottom body without registering a collision.
**Minimal reproduction project:**
[test_broken_collision1.zip](https://github.com/godotengine/godot/files/3376344/test_broken_collision1.zip)
| bug,confirmed,topic:physics | medium | Critical |
466,198,362 | create-react-app | Missing documentation for process.env.CI | The `npm run build` command is affected by the environment variable `CI`, but it is not well documented.
This is what the [existing documentation](https://facebook.github.io/create-react-app/docs/running-tests#continuous-integration) says about it:
> When creating a build of your application with npm run build linter warnings are not checked by default. Like npm test, you can force the build to perform a linter warning check by setting the environment variable CI. If any warnings are encountered then the build fails.
By looking at the source code or playing with the command, there are several side effects:
- Some errors are silenced:
https://github.com/facebook/create-react-app/blob/7b196fa4d6f4a98b93a460440adfef206e214652/test/fixtures/__shared__/util/setup.js#L105
- There is no color in the output anymore
- Another side effect [here](https://github.com/facebook/create-react-app/blob/7b196fa4d6f4a98b93a460440adfef206e214652/test/fixtures/__shared__/util/setup.js#L37)
I believe it would be a good choice to have no undocumented side effect.
---
Use cases where it is a problem:
- I want to master my CI pipeline: I can't just set an environment variable without knowing exactly what it does.
- I want to treat warnings as errors locally and the only option seems to be to set the `CI` option (this is a problem in intslef): I would also like to know what it does and keep the colors in the output.
- The usage of `npm build` don't talk about the envinroment variables, neither does `npm help build`, it is then confusing to see the behavior change between computers.
```
$ npm build -h
npm build [<folder>]
```
Thank you for reading this.
Best,
Simon | issue: proposal | low | Critical |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.