id
int64 393k
2.82B
| repo
stringclasses 68
values | title
stringlengths 1
936
| body
stringlengths 0
256k
⌀ | labels
stringlengths 2
508
| priority
stringclasses 3
values | severity
stringclasses 3
values |
|---|---|---|---|---|---|---|
460,187,698 | opencv | aarch64: libgomp.so.1: cannot allocate memory in static TLS block | Problem is caused by this optional flag: `-DWITH_OPENMP=ON`
Comment with **workaround**: https://github.com/opencv/opencv/issues/14884#issuecomment-706725583
Comment with **investigation**: https://github.com/opencv/opencv/issues/14884#issuecomment-815632861
---
#### Original description
I am compiling opencv from source in order to enable multi-core support on a aarch64 platform.
I am building open cv with the following config:
```
cmake -D CMAKE_BUILD_TYPE=RELEASE -DBUILD_SHARED_LIBS=OFF -DBUILD_EXAMPLES=OFF -DBUILD_opencv_apps=OFF -DBUILD_DOCS=OFF -DBUILD_PERF_TESTS=OFF -DBUILD_TESTS=OFF -DCMAKE_INSTALL_PREFIX=/usr/local -DENABLE_PRECOMPILED_HEADERS=OFF -DWITH_LIBV4L=ON -DWITH_QT=ON -DWITH_OPENGL=ON -DFORCE_VTK=ON -DWITH_TBB=ON -DWITH_GDAL=ON -DWITH_XINE=ON -DWITH_OPENMP=ON -DWITH_GSTREAMER=ON -DWITH_OPENCL=ON -DOPENCV_EXTRA_MODULES_PATH=../../opencv_contrib/modules ../
```
but every time I import it using python, I get the following error. A lot of the results on-line seems to be very vague and/or point towards a bug in gcc 4.2 fixed in 4.3 and I am currently on 8.x provided by debian repo and also 9.0.1 built from upstream source:
```
root@linaro-developer:~# python3
Python 3.7.3 (default, Apr 3 2019, 05:39:12)
[GCC 8.3.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import cv2
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/usr/local/lib/python3.7/dist-packages/cv2/__init__.py", line 89, in <module>
bootstrap()
File "/usr/local/lib/python3.7/dist-packages/cv2/__init__.py", line 79, in bootstrap
import cv2
ImportError: /usr/lib/aarch64-linux-gnu/libgomp.so.1: cannot allocate memory in static TLS block
```
This is on opencv master branch as well as 4.0.1 | needs investigation,platform: arm,category: 3rdparty | medium | Critical |
460,189,894 | TypeScript | feature request: support for mixins composed from other mixins. | ## Search Terms
## Suggestion
At the moment, it seems to be very difficult to compose mixins from other mixins.
Here's an example on StackOverflow: https://stackoverflow.com/questions/56680049
Here's an [example on playground](https://www.typescriptlang.org/play/#code/C4TwDgpgBAwg9gOwM7AE4FcDGw6oDwAqUAvFAIYIgA0UAglBAB7AQIAmS5lA2gLolcQfAHwCEEAO5QAFADp5ZAFx0AlCVEEAsACgdAM3QJsAS0RQAYnDgBZY42MJCDZqw6xEKDNlzDpAITIkCGUCNQBvKB0dKBioVAhgdFQEKEwAG0DOSzhnFnZOAKCoCOjYsr0rAQByCrgq0piAXyjtZt1tAyNgUxSA1Ft7RyImPLd4ZDQsHFRfQuCoUOLI9rL4xOTUjKQCslRc1yyrAYd-QIhw5bKylhRpC4arsswPODSIWTS4AHNpYAALYxIWS1NQAelBMQAEgBRABK0Jo-0BwMqgKgVQoICqJGkDzKbXxLUaQA).
The code:
```ts
type Constructor<T = any, A extends any[] = any[]> = new (...a: A) => T
function FooMixin<T extends Constructor>(Base: T) {
return class Foo extends Base {
foo = 'foo'
}
}
function BarMixin<T extends Constructor>(Base: T) {
return class Bar extends FooMixin(Base) {
test() {
console.log(this.foo) // PROBLEM: this.foo is 'any' =(
}
}
}
```
## Use Cases
To make it simpler to make mixins (and compose them) like we can in plain JavaScript.
I'm porting JavaScript code to TypeScript, and the JavaScript makes great use of mixins (including composing new mixins from other mixins), but the composition ispractically impossible to do in TypeScript without very tedious type casting.
## Examples
Here is the plain JS version of the above example:
```js
function FooMixin(Base) {
return class Foo extends Base {
foo = 'foo'
}
}
function BarMixin(Base) {
// BarMixin is composed with FooMixin
return class Bar extends FooMixin(Base) {
test() {
console.log(this.foo) // this.foo is obviously inherited from FooMixin!
// ^--- This shoud not be an error!
}
}
}
```
It seems to me, that the type checker can realize that the class returned from `FooMixin(Base)` will be a `typeof Foo`. The type system could at least be able to allow the `Bar` class to use methods and properties from `Foo`, despite not knowing what the `Base` class will be.
You can also imagine this problem gets worse with more composition, f.e.
```js
return class Bar extends Foo(Baz(Lorem(Ipsum(Base)))) {
```
It should also be possible to constrain the constructor to inherit from a certain base class. For example, the following doesn't work:
(EDIT: this part may actually be moved to a separate issue)
(EDIT 2: this part seems to be resolved)
```ts
// Think about Custom Elements here:
function FooMixin<T extends typeof HTMLElement>(Base: T) {
return class Foo extends Base {
test() {
this.setAttribute('foo', 'bar')
}
}
}
```
[playground link](http://www.typescriptlang.org/play/#src=function%20FooMixin%3CT%20extends%20typeof%20HTMLElement%3E(Base%3A%20T)%20%7B%20%0D%0A%0D%0A%20%20%20%20return%20class%20Foo%20extends%20Base%20%7B%20%0D%0A%20%20%20%20%20%20%20%20test()%20%7B%0D%0A%20%20%20%20%20%20%20%20%20%20%20%20this.setAttribute('foo'%2C%20'bar')%0D%0A%20%20%20%20%20%20%20%20%7D%0D%0A%20%20%20%20%7D%0D%0A%0D%0A%7D)
As @dragomirtitian pointed out on SO, there are workarounds, but they appear to be very complicated and impractical.
Here's a more realistic example of what I'm doing in JS (and trying to port to TS): I'm using a `Mixin()` helper function, as a type declaration for the following example, which in practice implements things like `Symbol.hasInstance` to check if instances are `instanceof` a given mixin, prevents duplicate mixin applications, and other features, but the types don't work:
```ts
type Constructor<T = any, A extends any[] = any[]> = new (...a: A) => T
type MixinFunction = <TSuper>(baseClass: Constructor<TSuper>) => Constructor<TSuper>
// this function does awesome: ensures mixins aren't applied
// more than once on a prototype chain, sets up Symbol.hasInstance so that
// instanceof checks works with any mixin application, etc.
declare function Mixin<T extends MixinFunction>(
mixinFn: T,
DefaultBase?: Constructor
): ReturnType<T> & {mixin: T}
function FooMixin<T extends Constructor>(Base: T) {
return class Foo extends Base {
foo = 'foo'
}
}
const Foo = Mixin(FooMixin)
type Foo = typeof Foo
function BarMixin<T extends Constructor>(Base: T) {
return class Bar extends Foo.mixin(Base) {
bar = 'bar'
test() {
this.foo = 'foofoo' // should work!
}
}
}
const Bar = Mixin(BarMixin)
class Baz extends Bar {
test() {
this.bar = 'barbar' // should work!
this.foo = 'foofoo' // should work!
}
}
const f: Foo = new Bar()
```
[playground link](http://www.typescriptlang.org/play/#src=type%20Constructor%3CT%20%3D%20any%2C%20A%20extends%20any%5B%5D%20%3D%20any%5B%5D%3E%20%3D%20new%20(...a%3A%20A)%20%3D%3E%20T%0D%0A%0D%0Atype%20MixinFunction%20%3D%20%3CTSuper%3E(baseClass%3A%20Constructor%3CTSuper%3E)%20%3D%3E%20Constructor%3CTSuper%3E%0D%0A%0D%0A%2F%2F%20this%20function%20does%20awesome%3A%20ensures%20mixins%20aren't%20applied%0D%0A%2F%2F%20more%20than%20once%20on%20a%20prototype%20chain%2C%20sets%20up%20Symbol.hasInstance%20so%20that%0D%0A%2F%2F%20instanceof%20checks%20works%20with%20any%20mixin%20application%2C%20etc.%0D%0Adeclare%20function%20Mixin%3CT%20extends%20MixinFunction%3E(%0D%0A%20%20%20%20mixinFn%3A%20T%2C%0D%0A%20%20%20%20DefaultBase%3F%3A%20Constructor%0D%0A)%3A%20ReturnType%3CT%3E%20%26%20%7Bmixin%3A%20T%7D%0D%0A%0D%0Afunction%20FooMixin%3CT%20extends%20Constructor%3E(Base%3A%20T)%20%7B%20%0D%0A%20%20%20%20return%20class%20Foo%20extends%20Base%20%7B%20%0D%0A%20%20%20%20%20%20%20%20foo%20%3D%20'foo'%0D%0A%20%20%20%20%7D%0D%0A%7D%0D%0A%0D%0Aconst%20Foo%20%3D%20Mixin(FooMixin)%0D%0Atype%20Foo%20%3D%20typeof%20Foo%0D%0A%0D%0A%0D%0Afunction%20BarMixin%3CT%20extends%20Constructor%3E(Base%3A%20T)%20%7B%20%0D%0A%20%20%20%20return%20class%20Bar%20extends%20Foo.mixin(Base)%20%7B%0D%0A%20%20%20%20%20%20%20%20bar%20%3D%20'bar'%0D%0A%0D%0A%20%20%20%20%20%20%20%20test()%20%7B%0D%0A%20%20%20%20%20%20%20%20%20%20%20%20this.foo%20%3D%20'foofoo'%20%2F%2F%20should%20work!%0D%0A%20%20%20%20%20%20%20%20%7D%0D%0A%20%20%20%20%7D%0D%0A%7D%0D%0A%0D%0Aconst%20Bar%20%3D%20Mixin(BarMixin)%0D%0A%0D%0Aclass%20Baz%20extends%20Bar%20%7B%0D%0A%0D%0A%20%20%20%20test()%20%7B%0D%0A%20%20%20%20%20%20%20%20this.bar%20%3D%20'barbar'%20%2F%2F%20should%20work!%0D%0A%20%20%20%20%20%20%20%20this.foo%20%3D%20'foofoo'%20%2F%2F%20should%20work!%0D%0A%20%20%20%20%7D%0D%0A%0D%0A%7D%0D%0A%0D%0Aconst%20f%3A%20Foo%20%3D%20new%20Bar())
Is there a way to do this currently, that we may have missed? (cc: @justinfagnani)
## Checklist
My suggestion meets these guidelines:
* [x] This wouldn't be a breaking change in existing TypeScript/JavaScript code
* [x] This wouldn't change the runtime behavior of existing JavaScript code
* [x] This could be implemented without emitting different JS based on the types of the expressions
* [x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
* [x] This feature would agree with the rest of [TypeScript's Design Goals](https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals).
| Suggestion,Awaiting More Feedback | medium | Critical |
460,260,763 | flutter | Official support for Raspberry PI 4 | Would like to see Flutter officially running on the latest **Raspberry PI 4** device. Heard someone ported Flutter on an old Raspberry PI device. But we need official support along with the mobile, desktop and web with minimal configuration setup. This will be a game changer in the competitive field of IOT.
Since Flutter is capable of drawing beautiful UI and performing network operations, I can see an array of possible use cases like **Digital Signage, Ad vending, Self-ordering Kiosk, Home Automation**, etc. Since Raspberry PI is a **low-cost credit card sized** computing board, we developers can make powerful and beautiful apps with **Flutter** at low cost. Of course, **FlutterFire** support will be highly appreciated.
It would be great if the Flutter team can expose the **Raspberry PI native peripheral IO** operations like GPIO, UART, SPI, etc using Dart. This will help to flutter the wings to the outside world.
I can imagine having a cup of coffee from a coffee vending machine by making an online payment from the touch screen app which is connected with the machine, running Flutter on a Raspberry P!
Cc @eseidelGoogle | c: new feature,e: device-specific,engine,customer: crowd,platform-linux,c: proposal,P3,team-engine,triaged-engine | high | Critical |
460,286,358 | TypeScript | Consider inferring class members types by implemented interface members (continuation of #340) | Continuation of #340, #1373, #5749, #6118, #10570, #16944, #23911.
## Why a new issue?
Many previous issues discussed about having contextual types based on **both** extended base class members **and** implemented interface members. This proposal only applies to `implements`, not `extends`.
Discussions in #6118 [ends](https://github.com/microsoft/TypeScript/pull/6118#issuecomment-216595207) with an edge case when a class extends a base class and implements another interface. I think this problem would not occur if the scope is limited to `implements` keyword only, and I believe would be a step forward from having parameters inferred as `any`.
Previous issues have been locked, making it impossible to continue the discussion as time passes.
## Proposal
Using terminology “option 1”, “option 2”, “option 3” referring to this comment: https://github.com/microsoft/TypeScript/issues/10570#issuecomment-296860943
- For members from `extends` keep option 1.
- For members from `implements`:
- Use option 3 for non-function properties that don’t have type annotation.
- Use option 2 for function properties and methods.
## Examples
Code example in the [linked comment](https://github.com/microsoft/TypeScript/pull/6118#issuecomment-216595207):
```ts
class C extends Base.Base implements Contract {
item = createSubitem(); // ⬅️ No type annotation -- inferred as `Subitem`
}
```
Since only the `implements` keyword is considered, `item` will be inferred as `Subitem`.
Example in https://github.com/microsoft/TypeScript/issues/10570#issuecomment-296860943
```ts
interface I {
kind: 'widget' | 'gadget';
}
class C implements I {
kind = 'widget'; // ⬅️ No type annotation -- inferred as 'widget' | 'gadget'
}
// Above behavior is consistent with:
const c: I = {
kind: 'widget' // ⬅️ c.kind is also 'widget' | 'gadget'
}
```
```ts
interface I {
kind: 'widget' | 'gadget';
}
class C implements I {
kind: 'widget' = 'widget'; // ⬅️ Explicit type annotation required to pin as 'widget'
}
```
Example in #16944:
```ts
interface IComponentLifecycle<P> {
componentWillReceiveProps?(nextProps: Readonly<P>, nextContext: any): void;
}
interface IProps {
hello: string;
}
class X implements IComponentLifecycle<IProps> {
componentWillReceiveProps(nextProps) {
// ^ Contextually typed as Readonly<IProps>
}
}
```
Example in #340:
```ts
interface SomeInterface1 {
getThing(x: string): Element;
}
interface SomeInterface2 {
getThing(x: number): HTMLElement;
}
declare class SomeClass implements SomeInterface1, SomeInterface2 {
getThing(x) {
// ^ Contextually inferred from
// (SomeInterface1 & SomeInterface2)['getThing']
// As of TS 3.5, it is an implicit any.
}
}
// Above behavior is consistent with:
const c: SomeInterface1 & SomeInterface2 = {
getThing(x) {
// ^ Implicit any, as of TS 3.5
},
}
```
## Checklist
My suggestion meets these guidelines:
* [x] This wouldn't be a breaking change in existing TypeScript/JavaScript code
* [x] This wouldn't change the runtime behavior of existing JavaScript code
* [x] This could be implemented without emitting different JS based on the types of the expressions
* [x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
* [x] This feature would agree with the rest of [TypeScript's Design Goals](https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals).
| Suggestion,In Discussion | medium | Critical |
460,325,664 | svelte | Change body class via <svelte:body /> | It's just an idea, but it'll be very convenient if we'll able to switch classes on body element like this:
```html
<svelte:body class:profile={isProfilePage} />
``` | feature request,popular | high | Critical |
460,335,705 | vue | Warn if colon shorthand is used on v-if/v-html/etc. | ### What problem does this feature solve?
I just spent way too long debugging something really weird until I realized I accidentally wrote `:v-if` instead of `v-if`.
A warning when wrongly using shorthands like `:` on "native" vue attributes could prevent this bad experience easily.
### What does the proposed API look like?
`:v-if="foo"`
--> console.warn("You specified v-bind:/ v-on: or a corresponding shorthand on a Vue attribute like v-if or similar. Usually this does not make sense.)
<!-- generated by vue-issues. DO NOT REMOVE --> | contribution welcome,feature request,good first issue,has PR,warnings | medium | Critical |
460,342,359 | go | x/tools/gopls: completion offers too many irrelevant candidates in struct literal | <!-- Please answer these questions before submitting your issue. Thanks! -->
### What version of Go are you using (`go version`)?
<pre>
$ go version
go version devel +44c9354c5a Fri Jun 21 05:21:30 2019 +0000 linux/amd64
$ go list -m golang.org/x/tools
golang.org/x/tools v0.0.0-20190620191750-1fa568393b23
$ go list -m golang.org/x/tools/gopls
golang.org/x/tools/gopls v0.0.0-20190620191750-1fa568393b23
</pre>
### Does this issue reproduce with the latest release?
Yes
### What operating system and processor architecture are you using (`go env`)?
<details><summary><code>go env</code> Output</summary><br><pre>
$ go env
GO111MODULE="on"
GOARCH="amd64"
GOBIN="/home/myitcv/gostuff/src/github.com/myitcv/govim/cmd/govim/.bin"
GOCACHE="/home/myitcv/.cache/go-build"
GOENV="/home/myitcv/.config/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/home/myitcv/gostuff"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/home/myitcv/gos"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/home/myitcv/gos/pkg/tool/linux_amd64"
GCCGO="gccgo"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="/home/myitcv/gostuff/src/github.com/myitcv/govim/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build637283533=/tmp/go-build -gno-record-gcc-switches"
</pre></details>
### What did you do?
Consider the following example:
```go
package main
import (
"fmt"
"playground.com/p"
)
func main() {
s := p.S{
// attempt completion
}
fmt.Println(s)
}
-- go.mod --
module playground.com
-- p/p.go --
package p
type S struct {
Name string
Age int
}
```
If completion is attempted at the position of the comment `// attempt completion` the following list of candidates is returned:
```
Name
Age
fmt
p
main()
string
append
bool
byte
cap
close
complex
complex128
complex64
copy
delete 78% ☰ 11/14 ㏑ : 7
error
false
float32
float64
imag
int
int16
int32
int64
int8
iota
len
make
new
nil
panic
print
println
real
recover
rune
true
uint
uint16
uint32
uint64
uint8
uintptr
```
In this case, because `S` is declared in another package, vet will enforce that use of the struct type in a composite literal must be keyed:
https://play.golang.org/p/-H5Fnm5c9zj
Hence I believe the only valid candidates are:
```
Name
Age
```
In any case, if `S` were declared in the same package, the list of candidates is not actually correct: it appears to be the valid key names plus all the predeclared identifiers, plus package-scope identifiers, regardless of whether they are applicable.
My proposal would be that regardless of whether `S` is declared in the current package or not, the list of candidates be limited to the valid key names. This feels like a more sensible default; far less noise in the majority of cases.
I realise this is subjective... so other thoughts welcomed!
---
cc @stamblerre @ianthehat
| help wanted,NeedsInvestigation,gopls | medium | Critical |
460,350,161 | godot | Editor Plugin fails to reference a singleton that is intended to load with itself. | **Godot version:**
3.1.1 stable official x64
**OS/device including version:**
Windows 10 1709 x64
**Issue description:**
Singleton, spawned in editor plugin main file with add_autoload_singleton(), and deleted with remove_autoload_singleton(), prevents to reactivate plugin if it's use was implemented to code in-place and then project reopened.
<img src="https://i.imgur.com/JWq48kj.png" />
**Steps to reproduce:**
1. Create an EditorPlugin.
2. Create singleton file with some variable.
3. Write add_autoload_singleton("SingletonName", "res://singleton_file.gd") to EditorPlugin's _enter_tree().
4. Write remove_autoload_singleton("SingletonName") to EditorPlugin's _exit_tree().
5. Go to Project Settings -> Plugins and activate plugin.
6. Add some use of singleton variables to EditorPlugin's main file, like
`var a = SingletonName.test_var`
7. Go to Project Settings -> Plugins and disable plugin.
8. Return to Project List and reopen project.
9. Go to Project Settings -> Plugins and try to activate plugin.
10. See a warning window and error of absent singleton that is intended to load.
**Workaround:**
Create needed singleton with needed name yourself and THEN activate plugin. It will work.
**Minimal reproduction project:**
http://www.mediafire.com/file/o0qjswb0r074zik/PluginAutoload.zip/file
| bug,confirmed,usability,topic:plugin | low | Critical |
460,365,206 | terminal | Bug: Launching code from the wsl command line shouldn't break tmux. | <!--
This bug tracker is monitored by Windows Terminal development team and other technical folks.
**Important: When reporting BSODs or security issues, DO NOT attach memory dumps, logs, or traces to Github issues**.
Instead, send dumps/traces to [email protected], referencing this GitHub issue.
Please use this form and describe your issue, concisely but precisely, with as much detail as possible.
-->
# Environment
```none
Windows build number: [run "ver" at a command prompt]: 10.0.18362.175
Windows Terminal version (if applicable): 0.2.1715.0
Any other software?
```
# Steps to reproduce
<!-- A description of how to trigger this bug. -->
I'm running `tmux` in `wsl`. When I open vscode in any pane by writing `code .` or `code-insiders .`, the whole tmux display gets mutilated. Starting typing something in one pane starts changing other side panes.
# Expected behavior
<!-- A description of what you're expecting, possibly containing screenshots or reference material. -->
Launching code from the wsl command line shouldn't break tmux.
# Actual behavior
<!-- What's actually happening? -->
The panes get broken - maybe it's a conpty bug, because I also get similar issues when running Alacritty using conpty. I can also intermittently see the cursor jumping between different panes for a brief moment (100ms or so)...
| Area-Output,Issue-Bug,Product-Terminal,Priority-2 | low | Critical |
460,453,023 | material-ui | Support for prefers-reduced-motion | - [x] This is not a v0.x issue. <!-- (v0.x is no longer maintained) -->
- [x] I have searched the [issues](https://github.com/mui-org/material-ui/issues) of this repository and believe that this is not a duplicate.
## Expected Behavior 🤔
The transition components Collapse, Fade, Grow, Slide, and Zoom (and other MUI components with animations) should have reduced motion in their animations, by either disabling the animations altogether or using a simple fade animation, when the prefers-reduced-motion: reduce media query is true.
## Current Behavior 😯
None of the components change behaviour and show the same animation when the media query is true.
## Examples 🌈
Here’s the [MDN doc](https://developer.mozilla.org/en-US/docs/Web/CSS/@media/prefers-reduced-motion) for this media query. It’s supported on Chrome, Firefox, and Safari on Windows, Mac, and iOS.
This [WebKit blog](https://webkit.org/blog/7551/responsive-design-for-motion/) has several examples of how to support this media query.
## Context 🔦
I’m currently adding support for this media query in my web app by disabling page transitions and other custom transitions by using the media query in JSS. But I’m also using MUI’s built-in transition components and there is currently no easy way to disable those animations.
I could use the useMediaQuery hook to modify what my component returns to remove the transition components, but this is quite cumbersome. Supporting this media query directly would make it a lot easier to build more accessible web apps.
| new feature,accessibility | medium | Major |
460,482,639 | flutter | Text widget dynamic amount of lines in a Container or SizedBox with fixed height | I would like a Text to render as many lines as can fit in a parent height. So let's say I have a container with height of 50px and I want a long text inside to render 5 lines and then do ellipsis. But if my Text widget have maxLines: 6 then 6th line will get cut off. I would expect that if 6 lines don't fit it should render 5 lines only. I want it to be dynamic because my container height could be size. I can get it to work using LayoutBuilder or TextPainter but I would expect better way.
Here's example of text being cut off
| c: new feature,framework,P3,team-framework,triaged-framework | low | Minor |
460,499,243 | godot | In ItemList, the text and icon don't have margin and is even rendered outside their row Rect. | Found similar but not same issue with ItemList.
**Godot version:**
<!-- Specify commit hash if non-official. -->
Latest at this time master https://github.com/godotengine/godot/commit/ca084db4aa6d5da8f34fc889d70f1b8e46990b82.
**OS/device including version:**
<!-- Specify GPU model and drivers if graphics-related. -->
Windows 10 1903
**Issue description:**
<!-- What happened, and what was expected. -->
The text and label don't have margin and is even rendered outside their row Rect.
Left ItemList is in ICON_MODE_LEFT; Right ItemList2 is in ICON_MODE_TOP.
Code:
```
var item_list : ItemList = $ItemList
item_list.icon_mode = ItemList.ICON_MODE_LEFT
item_list.add_icon_item(a)
item_list.add_item("Hi",a)
item_list.add_item("Hi")
item_list.add_icon_item(a)
var item_list2 : ItemList = $ItemList2
item_list2.icon_mode = ItemList.ICON_MODE_TOP
item_list2.add_icon_item(a)
item_list2.add_item("Hi",a)
item_list2.add_item("Hi")
item_list2.add_icon_item(a)
```
**Steps to reproduce:**
Run minimal project or add items to ItemList using add_item or add_icon_item.
**Minimal reproduction project:**
<!-- Recommended as it greatly speeds up debugging. Drag and drop a zip archive to upload it. -->
[tests.zip](https://github.com/godotengine/godot/files/3326049/tests.zip)
| bug,topic:gui | low | Critical |
460,539,339 | react | getDerivedStateFromError for Control Flow | Spinoff from https://github.com/facebook/react/pull/15797#issuecomment-504782329.
We might want to offer a way to "bubble" control flow up the tree a la Algebraic Effects. `throw Redirect()` is a canonical example. However, we want them to bypass the normal error boundaries. So it probably needs to be a first-class API. | Type: Feature Request,Component: Reconciler,React Core Team | medium | Critical |
460,540,822 | react | Collapsible Error Dialogs for the Ecosystem | Spinoff from https://github.com/facebook/react/pull/15797#issuecomment-504782329.
Both in React Native and Create React App, redboxes are full screen. But in React, most errors are recoverable. Even with accidental runtime crashes it's useful to look "underneath" to see whether your boundary worked as expected, and to have an idea of the end user experience.
We could solve this with a collapsed-by-default floating error panel that just shows a list of messages. You can click to expand. We could also use this as an opportunity to unify the RN and web designs. | Type: Feature Request,Component: Developer Tools,React Core Team | medium | Critical |
460,542,947 | flutter | iOS platform view clip path: Find a better approximate for conic path | In current PlatformView clipping behavior, clipPath is not completely accurate when the path is a `conic path`. For example [conicTo](https://api.skia.org/classSkPath.html#a9edc41978765cfe9a0b16e9ecf4d276e)
Quartz doesn't support `conic path`. We currently uses quad to approximate conic. This is inaccurate when the weight value is far away from 1. eg. weight = 0.1 or weight = 2.
We need to find a better way to approximate conic path using quartz.
To reproduce:
1. Add a clipPath with conic path widget on top of any PlatformView widget, with a large weight (e.g. weight = 2)
2. Add the same clipPath to a container widget that has the same size with the PlatformView widget.
3. See the visual difference. | platform-ios,engine,a: platform-views,P2,a: plugins,team-ios,triaged-ios | low | Minor |
460,550,077 | flutter | TextField maxLines should be a double, not an int. | We need to be able to define a fractional maximum number of lines for a TextField. When using an integer number of lines, and there is a lot of text, the user will only see a few of the lines and may think that there are no more.
On the contrary, if you define, say 5.5 lines, and there are in fact, say, 10 lines, the user immediately notices that there is more text to the bottom. In other words, half-lines are visual cues to the users that they are able to scroll to see the rest.
It's a **small change** that **improves usability**. To be consistent, I would make minLines also double, although in terms of usability that one is probably not important.
This is NOT a breaking change, and preserves existing maxLines behavior.
Note: I'm the author of https://github.com/flutter/flutter/issues/19105 which was fixed by https://github.com/flutter/flutter/pull/27205
| a: text input,c: new feature,framework,f: material design,good first issue,P3,team-design,triaged-design | low | Major |
460,586,606 | terminal | Add a "tab busy indicator" to show when a tab has belled or has output | # Summary of the new feature/enhancement
if something output to tab which no in view, give it a sign, mean something output in that tab, but you no watch it, has below
green point and blue background mean tab which in your view, green point and white background mean tab no in your view and nothing output in that tab, exclamation mark and white background mean tab no in your view and something output in that tab
# Proposed technical implementation details (optional)
<!--
A clear and concise description of what you want to happen.
-->
| Issue-Feature,Area-UserInterface,Product-Terminal | low | Major |
460,595,927 | pytorch | [doc] nn.Module.forward documentation unclear | ## 📚 Documentation
This note is totally unclear to me. What does it mean? I don't know what should be called afterward. The link doesn't point to a function, just to torch.nn.Module.
| module: docs,module: nn,triaged,enhancement | low | Major |
460,643,619 | go | encoding/json: memoize strings during decode | Part of the motivation for #32593 is the observation in json-iterator/go#376 that when you json decode, many of the same strings appear over and over in the JSON and get copied and reconstructed in the result over and over as well.
We do _not_ want to make the JSON coalesce all the allocated strings into one giant buffer, because then holding on to just one of them holds onto the entire thing.
But it might make sense to add to the decoder state a simple map[[]byte]string and remember which specific byte slices we've already converted to string and reuse those allocated strings instead of doing the same conversions again in a particular Decode or Unmarshal operation.
It's unclear to me whether the map in a Decoder should persist between Decode operations. Probably? That will affect users who put Decoders in a pool or something like that, though. (Solution: don't put decoders in pools.) | Proposal,Proposal-Accepted | high | Critical |
460,643,936 | flutter | Pure Flutter support for Native Ads Advanced | Split off #12114
Users would like to use Flutter widget for rendering AdMob [Native Ads Advanced](https://developers.google.com/admob/android/native/start) ads.
Note: Native Ads Advanced is only available to a limited set of approved app developers(publishers) | c: new feature,package,team-ecosystem,P3,triaged-ecosystem | medium | Critical |
460,652,145 | pytorch | [FYI] Introducing Quantized Tensor | Hello everyone, here is an update about quantized Tensor, we are actively working on brining in more support for quantization in PyTorch, please stay tuned.
https://github.com/pytorch/pytorch/wiki/Introducing-Quantized-Tensor | module: docs,triaged | low | Minor |
460,678,080 | godot | `inst2dict` does not work with objects having no script on them | Godot 3.1.1
The following does not work:
```gdscript
var sprite = Sprite.new()
var d = inst2dict(sprite)
```
Error:
```
Error calling built-in function 'inst2dict': Not a script with an instance
```
Is there a reason why the object must have a script on it? Either way, if it's intented it should also be documented. | bug,discussion,topic:core,confirmed | low | Critical |
460,718,098 | TypeScript | Type named capture groups better | ## Search Terms
named regexp, named capture groups
## Motivation
Currently named capture groups are a bit of a pain in TypeScript:
1. All names are of type string even if the regexp doesn't have that named group.
2. You need to use non-null assertion for `.groups` even when that is the only possibility.
## Suggestion
I propose making `RegExp` higher order on its named capture groups so that `.groups` is well typed.
```ts
// Would have type: RegExp<{ year: string, month: string }>
const date = /(?<year>[0-9]{4})-(?<month>[0-9]{2})/
const match = someString.match(date)
if (match) {
// match.groups type would be { year: string, month: string }
// currently is undefined | { [key: string]: string }
}
// Would have type RegExp<{ year: string, month?: string }>
const optionalMonth = /(?<year>[0-9]{4})(-(?<month>[0-9]{2}))?/
```
## Checklist
My suggestion meets these guidelines:
* [✓] This wouldn't be a breaking change in existing TypeScript/JavaScript code
* [✓] This wouldn't change the runtime behavior of existing JavaScript code
* [✓] This could be implemented without emitting different JS based on the types of the expressions
* [✓] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
* [✓] This feature would agree with the rest of [TypeScript's Design Goals](https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals).
| Suggestion,Awaiting More Feedback | high | Critical |
460,780,562 | pytorch | [libtorch] header warning suppression | ```
libtorch/include/c10/util/logging_is_not_google_glog.h:136:0: warning: "CHECK_GT" redefined
#define CHECK_GT(val1, val2) CHECK_OP(val1, val2, >)
```
How to disable those header file warnings? | triaged,module: build warnings | low | Minor |
460,825,575 | opencv | bug in videoio dshow access violation exception | - OpenCV => 4.1.0
- Operating System / Platform => Windows 7 64 Bit
- Compiler => Visual Studio 2017
my app crashed because of videoio, the call stack is
VCRUNTIME140!MoveSmall **line 430** f:\dd\vctools\crt\vcruntime\src\string\amd64\memcpy.asm
opencv_videoio410!SampleGrabberCallback::SampleCB
qedit!CSampleGrabber::Receive
qedit!CTransformInputPin::Receive
qedit!CBaseInputPin::ReceiveMultiple
qcap!COutputQueue::ThreadProc
qcap!COutputQueue::InitialThreadProc
kernel32!BaseThreadInitThunk
ntdll!RtlUserThreadStart
looking into opencv code
https://github.com/opencv/opencv/blob/master/modules/videoio/src/cap_dshow.cpp
STDMETHODIMP SampleCB(double , IMediaSample *pSample){
if(WaitForSingleObject(hEvent, 0) == WAIT_OBJECT_0) return S_OK;
HRESULT hr = pSample->GetPointer(&ptrBuffer);
if(hr == S_OK){
latestBufferLength = pSample->GetActualDataLength();
if(latestBufferLength == numBytes){
EnterCriticalSection(&critSection);
memcpy(pixels, ptrBuffer, latestBufferLength); // I believe here it happens
newFrame = true;
freezeCheck = 1;
LeaveCriticalSection(&critSection);
SetEvent(hEvent);
}else{
DebugPrintOut("ERROR: SampleCB() - buffer sizes do not match\n");
}
}
return S_OK;
}
I do not know when this method is called I guess while opening the camera stream, for now, It happened just once
| category: videoio,incomplete,platform: win32,needs reproducer,needs investigation | low | Critical |
460,845,065 | PowerToys | Two Monitors screenshot picker | Hello,
I have two Monitors and I want when I press screenshot to give me a picker to select
Option 1: Screenshot for All Monitors
Option 2: Screenshot for either Monitors 1, Monitors 2
Thanks | Idea-New PowerToy | low | Major |
460,860,822 | rust | Adding nom as a dependency to a proc-macro crate with tests results in link error | Long debug session short:
- Having a proc-macro crate with tests works.
- Adding nom 5 as a dependency to a proc-macro crate works.
- Having nom 5 be a dependency in a proc-macro crate with tests does not work.
This might be a known problem; I couldn't find an open issue, though. Even so, error is not user friendly and that should at least be fixed.
<details>
<summary><code>cargo test --verbose</code></summary>
```
Fresh semver-parser v0.7.0
Fresh void v1.0.2
Fresh version_check v0.1.5
Fresh static_assertions v0.2.5
Fresh cfg-if v0.1.9
Fresh semver v0.9.0
Fresh rustc_version v0.2.3
Fresh unreachable v1.0.0
Fresh ryu v0.2.8
Fresh memchr v2.2.0
Fresh stackvector v1.0.6
Fresh lexical-core v0.4.2
Fresh nom v5.0.0
Compiling le-proc-macro v0.1.0 (/Users/pascal/Projekte/rust-proc-macro-test-linking-error/le-proc-macro)
Running `rustc --edition=2018 --crate-name le_proc_macro le-proc-macro/src/lib.rs --color always --crate-type proc-macro --emit=dep-info,link -C prefer-dynamic -C debuginfo=2 -C metadata=88a723aab0e69935 -C extra-filename=-88a723aab0e69935 --out-dir /Users/pascal/.cargo/global-target/debug/deps -C incremental=/Users/pascal/.cargo/global-target/debug/incremental -L dependency=/Users/pascal/.cargo/global-target/debug/deps --extern nom=/Users/pascal/.cargo/global-target/debug/deps/libnom-1f917ff11a098652.rlib -Zsymbol-mangling-version=v0`
Running `rustc --edition=2018 --crate-name le_proc_macro le-proc-macro/src/lib.rs --color always --emit=dep-info,link -C prefer-dynamic -C debuginfo=2 --test -C metadata=a6088ffbe5f8f402 -C extra-filename=-a6088ffbe5f8f402 --out-dir /Users/pascal/.cargo/global-target/debug/deps -C incremental=/Users/pascal/.cargo/global-target/debug/incremental -L dependency=/Users/pascal/.cargo/global-target/debug/deps --extern nom=/Users/pascal/.cargo/global-target/debug/deps/libnom-1f917ff11a098652.rlib -Zsymbol-mangling-version=v0`
warning: unused import: `nom::IResult`
--> le-proc-macro/src/lib.rs:4:5
|
4 | use nom::IResult;
| ^^^^^^^^^^^^
|
= note: #[warn(unused_imports)] on by default
warning: unused import: `nom::IResult`
--> le-proc-macro/src/lib.rs:4:5
|
4 | use nom::IResult;
| ^^^^^^^^^^^^
|
= note: #[warn(unused_imports)] on by default
error: linking with `cc` failed: exit code: 1
|
= note: "cc" "-m64" "-L" "/Users/pascal/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/x86_64-apple-darwin/lib" "/Users/pascal/.cargo/global-target/debug/deps/le_proc_macro-a6088ffbe5f8f402.15tcejuoevmooxrp.rcgu.o" "/Users/pascal/.cargo/global-target/debug/deps/le_proc_macro-a6088ffbe5f8f402.2t5ie6p57602b1hc.rcgu.o" "/Users/pascal/.cargo/global-target/debug/deps/le_proc_macro-a6088ffbe5f8f402.3k5tdhzyfh385jbb.rcgu.o" "/Users/pascal/.cargo/global-target/debug/deps/le_proc_macro-a6088ffbe5f8f402.40gtnqu5cs3dsn54.rcgu.o" "/Users/pascal/.cargo/global-target/debug/deps/le_proc_macro-a6088ffbe5f8f402.4qorxw028kxfrme3.rcgu.o" "/Users/pascal/.cargo/global-target/debug/deps/le_proc_macro-a6088ffbe5f8f402.52k0bg5o47l9e5g5.rcgu.o" "/Users/pascal/.cargo/global-target/debug/deps/le_proc_macro-a6088ffbe5f8f402.al00ie0yzyrbvcs.rcgu.o" "/Users/pascal/.cargo/global-target/debug/deps/le_proc_macro-a6088ffbe5f8f402.mt4xvaos1670dho.rcgu.o" "/Users/pascal/.cargo/global-target/debug/deps/le_proc_macro-a6088ffbe5f8f402.uo2b4vausxznfy0.rcgu.o" "-o" "/Users/pascal/.cargo/global-target/debug/deps/le_proc_macro-a6088ffbe5f8f402" "-Wl,-dead_strip" "-nodefaultlibs" "-L" "/Users/pascal/.cargo/global-target/debug/deps" "-L" "/Users/pascal/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/x86_64-apple-darwin/lib" "-L" "/Users/pascal/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/x86_64-apple-darwin/lib" "-ltest-0d2e540bfeb389c9" "-L" "/Users/pascal/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/x86_64-apple-darwin/lib" "-lterm-9dc2d4db7993fbfd" "/Users/pascal/.cargo/global-target/debug/deps/libnom-1f917ff11a098652.rlib" "-L" "/Users/pascal/.cargo/global-target/debug/deps" "-llexical_core-d715db2534c4793d" "/Users/pascal/.cargo/global-target/debug/deps/libryu-aa307abc73a251bb.rlib" "/Users/pascal/.cargo/global-target/debug/deps/libstackvector-8faea803e8d71d93.rlib" "/Users/pascal/.cargo/global-target/debug/deps/libunreachable-5224a131bd9f1445.rlib" "/Users/pascal/.cargo/global-target/debug/deps/libvoid-196f5b851425c571.rlib" "/Users/pascal/.cargo/global-target/debug/deps/libstatic_assertions-633d173cf8830653.rlib" "/Users/pascal/.cargo/global-target/debug/deps/libcfg_if-3eb3c0e2c877bcb6.rlib" "/Users/pascal/.cargo/global-target/debug/deps/libmemchr-affb19acc32f58a0.rlib" "/Users/pascal/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/x86_64-apple-darwin/lib/libproc_macro-027ee96af4731d93.rlib" "-L" "/Users/pascal/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/x86_64-apple-darwin/lib" "-lstd-a62aa059e97bb248" "/Users/pascal/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/x86_64-apple-darwin/lib/libcompiler_builtins-a62aa322f1655fc7.rlib" "-lSystem" "-lresolv" "-lc" "-lm"
= note: Undefined symbols for architecture x86_64:
"__RNvXsJ_NtCs6GOKu7pHlyt_4core3fmtRlNtB5_5Debug3fmtCs7N6e5JiROWN_12lexical_core", referenced from:
__RINvCsLl3UznTzjj_4test18assert_test_resultuECsfbY9ZosDsBF_13le_proc_macro in le_proc_macro-a6088ffbe5f8f402.al00ie0yzyrbvcs.rcgu.o
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
error: aborting due to previous error
error: Could not compile `le-proc-macro`.
Caused by:
process didn't exit successfully: `rustc --edition=2018 --crate-name le_proc_macro le-proc-macro/src/lib.rs --color always --emit=dep-info,link -C prefer-dynamic -C debuginfo=2 --test -C metadata=a6088ffbe5f8f402 -C extra-filename=-a6088ffbe5f8f402 --out-dir /Users/pascal/.cargo/global-target/debug/deps -C incremental=/Users/pascal/.cargo/global-target/debug/incremental -L dependency=/Users/pascal/.cargo/global-target/debug/deps --extern nom=/Users/pascal/.cargo/global-target/debug/deps/libnom-1f917ff11a098652.rlib -Zsymbol-mangling-version=v0` (exit code: 1)
warning: build failed, waiting for other jobs to finish...
error: build failed
```
</details>
See these commits for a minimal repo: https://github.com/killercup/rust-proc-macro-test-linking-error/commits/master
Tested with `rustc 1.37.0-nightly (7840a0b75 2019-05-31)` and `rustc 1.35.0 (3c235d560 2019-05-20)`.
cc @fry because we originally encountered this issue in https://github.com/fry/memory-offset-match
cc @Geal because he might have done something horrible in nom 5 or one of its dependencies :) | A-linkage,P-medium,A-macros,T-compiler,C-bug,E-needs-mcve,A-proc-macros | medium | Critical |
460,911,232 | pytorch | using multi thread lead to gpu stuck with GPU-util 100% | I tried to inference using multi thread, but gpu stuck with GPU-Util 100%.
The pytorch was builded from source in branch v1.1.0.
But if i install the torch from pip or conda, the some code can work smoothly.
Is there ignore some import process in building?
I followed the guidance：
```
conda install numpy ninja pyyaml mkl mkl-include setuptools cmake cffi typing
conda install -c pytorch magma-cuda100
git clone --recursive --single-branch --branch v1.1.0 https://github.com/pytorch/pytorch.git
cd pytorch
git submodule sync
git submodule update --init --recursive
export CMAKE_PREFIX_PATH=${CONDA_PREFIX:-"$(dirname $(which conda))/../"}
python setup.py install
```
cc @ezyang @gchanan @zou3519 @ngimel | high priority,needs reproduction,module: cuda,triaged,quansight-nack | medium | Critical |
460,920,640 | TypeScript | Dynamic import breaks global onError with requirejs | **TypeScript Version:** 3.2.2
**Search Terms:** dynamic import, requirejs, amd, onerror
**Code**
```ts
import('module').then(()=>{ /* some code*/ });
```
compiled to
```js
new Promise(function (resolve_1, reject_1) {
require(['module'], resolve_1, reject_1);
});
```
If require are called with 3 arguments then require.onError is not fired. _Reject_ should be adeed only in case when we have a _catch_ call after _import_.
**Some propose:**
```ts
//@ts-import-no-reject
import('module').then(()=>{ /* some code*/ });
```
```js
new Promise(function (resolve_1) {
require(['module'], resolve_1);
}); | Needs Investigation | low | Critical |
460,921,142 | go | cmd/compile: debugger jumps around declarations | ### What version of Go are you using (`go version`)?
<pre>
$ go version
go version devel +9bf62783d2 Wed Jun 26 06:27:56 2019 +0000 windo
ws/amd64
</pre>
### Does this issue reproduce with the latest release?
Yes
### What operating system and processor architecture are you using (`go env`)?
<details><summary><code>go env</code> Output</summary>
<pre>
$ go env
set GO111MODULE=on
set GOARCH=amd64
set GOBIN=
set GOCACHE=C:\Users\florin\AppData\Local\go-build
set GOENV=C:\Users\florin\AppData\Roaming\go\env
set GOEXE=.exe
set GOFLAGS=
set GOHOSTARCH=amd64
set GOHOSTOS=windows
set GONOPROXY=
set GONOSUMDB=
set GOOS=windows
set GOPATH=D:\go
set GOPRIVATE=
set GOPROXY=direct
set GOROOT=C:\go-master
set GOSUMDB=sum.golang.org
set GOTMPDIR=
set GOTOOLDIR=C:\go-master\pkg\tool\windows_amd64
set GCCGO=gccgo
set AR=ar
set CC=gcc
set CXX=g++
set CGO_ENABLED=1
set GOMOD=D:\go-samples\debugging\go.mod
set CGO_CFLAGS=-g -O2
set CGO_CPPFLAGS=
set CGO_CXXFLAGS=-g -O2
set CGO_FFLAGS=-g -O2
set CGO_LDFLAGS=-g -O2
set PKG_CONFIG=pkg-config
set GOGCCFLAGS=-m64 -mthreads -fmessage-length=0 -fdebug-prefix-m
ap=C:\Users\florin\AppData\Local\Temp\go-build286245954=/tmp/go-b
uild -gno-record-gcc-switches
</pre></details>
### What did you do?
- use the code at https://github.com/dlsniper/debugging/tree/0cf1692cb8518c1ec982c72d71064ffba1d0ed1c
- use Delve at version 79ad269
- run ` dlv debug main.go `
- invoke the following commands in Delve:
```
b main.go:38
c
n
n
n
n
n
n
```
### What did you expect to see?
I would expect the execution pointer to follow the code and step thru the structure construction as it's defined in the code.
### What did you see instead?
The execution pointer randomly jumps around, like in this video https://youtu.be/0FcDOg5ez4o (and it happens from command line as well as GoLand so it's not an implementation issue for the UI)
| NeedsInvestigation,compiler/runtime | low | Critical |
461,055,734 | go | cmd/go/internal/modfetch: re-evaluate the undocumented proxy behavior in proxyRepo.latest() | Forked from the discussion during the review of https://golang.org/cl/183402
1) undocumented `/@v/list` format
[`proxyRepo.latest()`](https://github.com/golang/go/blob/19690053606dd14dedcf028bb37df79e3e33c003/src/cmd/go/internal/modfetch/proxy.go#L283) assumes `/@v/list` could return a list of version, commit timestamp pairs. This is not documented in the proxy protocol doc, and I am not sure if there is any proxy that's following this format. Please reject the undocumented format or document it.
One of the benefit of preserving this feature is, when this `proxyRepo.latest()` is invoked, the commit timestamp info here is more reliable than the timestamp parsed from the pseudo-version like version string and helps avoiding an extra `proxyRepo.Stat()` call. On the other hand, the code path can be completely eliminated if proxies implement the `/@latest` endpoint, which is also not documented.
2) whether to include pseudo-versions or not in `/@v/list`
The `proxyRepo.latest()` itself is also relying on part of undocumented behavior of `/@v/list`, which is supposed to include pseudo-versions. Before https://golang.org/cl/183402 (pre-1.13), we assumed it's not a good idea to include the pseudo versions in the `/@v/list` output and planned to include that in the proxy protocol spec.
https://go-review.googlesource.com/c/mod/+/176540/5/proxy/server.go#40
// List returns a list of tagged versions of the module identified by path.
// The versions should all be canonical semantic versions
// and formatted in a text listing, one per line.
// Pseudo-versions derived from untagged commits should be omitted.
// The go command exposes this list in 'go list -m -versions' output
// and also uses it to resolve wildcards like 'go get [email protected]'.`
If the spec draft is valid, the `proxyRepo.latest()` implementation doesn't do anything but an extra network round trip for the proxies that follow the spec. If the go command can handle the list output including pseudo-versions, we may want to revisit the decision.
So, I propose either
1) tighten the spec to require the `/@latest` endpoint. Then, remove the code that leads to the `proxyRepo.latest()`, or
2) relax the `/@v/list` format and allow pseudo versions in its output, and document it.
`Option 2)` implies more code to maintain on `cmd/go` side. `Option 1)` implies breakage of proxies that doesn't implement the `/@latest` endpoint.
p.s. having the go command's `proxyRepo.Versions` ensure not to return pseudo versions is a good fix though. | Documentation,NeedsInvestigation,modules | low | Major |
461,066,736 | create-react-app | Looking for a reference documentation to use CRA with (NWB) external modules in the same monorepo | ### Is your proposal related to a problem?
<!--
Provide a clear and concise description of what the problem is.
For example, "I'm always frustrated when..."
-->
Since monorepo support was reverted on v2 release, some of my projects are stuck in pre-release, which is not durable. I need a robust solution to share modules with all the CRA projects of the monorepo, in a dev-friendly way. Looking at CRA issues, it seems that i'm not alone in this situation.
### Describe the solution you'd like
<!--
Provide a clear and concise description of what you want to happen.
-->
@Timer said in the [Completion roadmap for [email protected]](https://github.com/facebook/create-react-app/issues/5024) (5024 - 3) :
"_We're going to revert monorepo support in favor of consuming library packages via nwb and provide excellent documentation on how to do so. This is arguably the best way._"
This documentation would be so useful... Is this still planned?
(And really, thanks for this incredible and really useful work !)
| issue: proposal | low | Minor |
461,080,734 | go | api: document the purpose of and review process for next.txt | @andybons sent me [CL 183919](https://golang.org/cl/183919) and I wasn't quite sure what to do with it:
* The diff from `api/next.txt` to `api/go1.13.txt` was not entirely trivial, but there were no visible failures on the build dashboard indicating any kind of skew (even for the symbols found in `next.txt` that were subsequently removed from the API).
* The final update to `go1.13.txt` goes through @golang/osp-team as part of the release process, but it's not obvious to me what kinds of problems we're supposed to look for.
* The last couple of CLs updating `api/next.txt` were sent between folks very central in the project, with very minimal descriptions and almost no visible discussion on the review thread.
* Some recent CLs have updated `api/next.txt` in the same CL as the API addition itself, but it's not obvious to me which CLs should do the API update simultaneously vs. saving or leaving the update for someone else to review later.
`api/README` doesn't clarify these points very much. Its description of the file is:
> `next.txt` is the only file intended to be mutated. It's a list of
features that may be added to the next version. It only affects
warning output from the `go` `api` tool.
We should expand the `README` file to more clearly describe the purpose and review process for `next.txt`. | Documentation,NeedsInvestigation | low | Critical |
461,085,970 | node | http server respond with inappropriate default headers for `HEAD` method | <!--
Thank you for reporting a possible bug in Node.js.
Please fill in as much of the template below as you can.
Version: output of `node -v`
Platform: output of `uname -a` (UNIX), or version and 32 or 64-bit (Windows)
Subsystem: if known, please specify the affected core module name
If possible, please provide code that demonstrates the problem, keeping it as
simple and free of external dependencies as you can.
-->
* **Version**: >= 10.x
* **Platform**: any
* **Subsystem**: http
<!-- Please provide more details below this comment. -->
To implement a HTTP keep alive mechanism, I use the `http.Agent({ keepAlive: true })` and `http.request({ agent, method, host, port })`.
Everything is ok when the method is `GET` or `TRACE` and others, the agent reuse the TCP connection as I expect.
But when changing the method to `HEAD`, the agent close the connection when server responded.
From the response header, the only different is that: for `HEAD` method, there isn't a `Content-Length: 0` or `Transfer-Encoding: chunked` in the default header (but `GET` has by default), so the HTTP parser think this connection should not be kept alive.
But from the RFC, we can infer that if keep-alive was enabled, either `Content-Length: 0` or `Transfer-Encoding: chunked` should be setted in response header, I think this should be a default behavior.
```js
# server
const http = require("http")
const server = http.createServer((req, res) => {
// res.setHeader("Content-Length", 0)
// res.setHeader("Transfer-Encoding", "chunked")
res.end()
})
server.keepAliveTimeout = 0
server.listen(2333, "x.x.x.x")
```
```js
# client
const http = require("http")
const agent = new http.Agent({
keepAlive: true,
})
request = () => {
const req = http.request({
agent,
host: "x.x.x.x",
port: 2333,
method: 'HEAD',
})
req.end()
}
request()
``` | help wanted,http | low | Critical |
461,093,613 | TypeScript | Language service OOM on lodash DT tests when batch compilation succeeds | Various CI runs on lodash for DefinitelyTyped confirm that batch compilation works fine, but certain language service operations OOM consistently, and the PR doesn’t look particularly costly. This makes me wonder if the language service is doing more work than necessary.
https://github.com/DefinitelyTyped/DefinitelyTyped/pull/36288
Benchmarking logs tell us exactly where the OOM happened, so we should be able to repro in VS Code by checking out `refs/pull/36288/merge` and requesting quick info and/or completions at one of the problem locations: https://dev.azure.com/definitelytyped/DefinitelyTyped/_build/results?buildId=6947 | Bug,Crash | low | Minor |
461,103,154 | godot | Add comments why some code is disabled by false statement | **Godot version:**
3.2 master
**Issue description:**
- [ ] 1. https://github.com/godotengine/godot/blob/8591691b9b7be784606a367142b0b83ecd5975dd/scene/animation/animation_player.cpp#L317-L321
- [ ] 2. https://github.com/godotengine/godot/blob/b16c309f82c77d606472c3c721a1857e323a09e7/servers/audio/effects/audio_effect_compressor.cpp#L89-L93
- [ ] 3. https://github.com/godotengine/godot/blob/521aad3dca45ccc3d914fa3942bc929f4fb18c7d/editor/editor_file_system.cpp#L608-L612
- [ ] 4. https://github.com/godotengine/godot/blob/2935caa13f3623b80a903f8c3349cea48a417c00/scene/3d/baked_lightmap.cpp#L534-L538
| discussion,topic:core | low | Minor |
461,153,979 | pytorch | second derivatives of unfold | ## 🚀 Feature
Backprop through backprop of `torch.nn.functional.unfold`.
## Motivation
I'm trying to research models where I need to use fancy convolutions (e.g. https://discuss.pytorch.org/t/locally-connected-layers/26979) and be able to take the gradient of the gradients. However, currently trying to do this produces
`RuntimeError: derivative for _thnn_im2col_backward is not implemented`
## Alternatives
A possible alternative in the meantime is to use for loops to perform im2col, but this is probably very inefficient.
| triaged,enhancement,module: derivatives | low | Critical |
461,165,284 | pytorch | Handle all IntArrayRef expansions in ATen | See #22032 and #20866 for the rationale and #22073 for an example. | module: nn,triaged,enhancement | low | Minor |
461,178,368 | flutter | `flutter test --start-paused test/material/about_test.dart` will eventually time out | We should remove the timeout that checks that tests connect to the test harness. For example, just now I ran (in //flutter/packages/flutter):
```
flutter test --start-paused test/material/about_test.dart
```
...and then did something else for 6 minutes and when I got back to it, it had timed out, and I had to restart it. It should have just waited forever. | a: tests,team,tool,P2,c: flake,team-tool,triaged-tool | low | Minor |
461,192,979 | flutter | Enforce platform lifecycle in framework | Enforce platform lifecycle in framework.
Based on #35054 (which contains 2 different bugs), it looks like there may be a number of framework behaviors that do not respect the platform lifecycle. Namely, the platform goes to the "inactive" state, but the framework does not update its state accordingly.
Example 1: text input connection does not clear its client when the platform becomes inactive, but it looks like it should.
Examples 2: PageView page snapping animations pause when the app becomes inactive, but remains paused in that position when the app is resumed.
There may be numerous other places where lifecycle is not effectively considered. | platform-android,framework,engine,a: existing-apps,P2,team-android,triaged-android | low | Critical |
461,196,978 | pytorch | Box constraints for optimizers | ## 🚀 Feature
Offer the option to set box constraints for optimizers.
## Motivation
In some applications of reinforcement learning, falling outside of a region correspond to inadmissible actions.
## Alternatives
One can omit the constraints, and hope that the optimal parameters found happen to be within the constraints, without any guarantees.
## Additional context
This was suggested in #938 for torch.optim.lbfgs.
CC @bamos | feature,triaged | low | Major |
461,220,064 | godot | `obj` files are not showing in dependency fix file dialog | Godot 3.1.1
Windows 10 64 bits
I dropped an asset from another project into a new one so I could re-use it. That caused some paths to be wrong, so when I opened the scene Godot asked me to fix dependencies.
However, one of them is an `.obj` model but I wasn't able to pick it, even though it's shown in the file explorer:
And likely other asset types aren't shown given how reduced the extension filter is.
Repro:
[FixDependenciesMissesOBJ.zip](https://github.com/godotengine/godot/files/3332203/FixDependenciesMissesOBJ.zip)
Open `crate.tscn`. | bug,topic:editor,confirmed | low | Minor |
461,270,750 | TypeScript | Super call of non-method incorrectly allowed if target >= ES6 | <!-- 🚨 STOP 🚨 𝗦𝗧𝗢𝗣 🚨 𝑺𝑻𝑶𝑷 🚨
Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Even if you think you've found a *bug*, please read the FAQ first, especially the Common "Bugs" That Aren't Bugs section!
Please help us by doing the following steps before logging an issue:
* Search: https://github.com/Microsoft/TypeScript/search?type=Issues
* Read the FAQ: https://github.com/Microsoft/TypeScript/wiki/FAQ
Please fill in the *entire* template below.
-->
From https://stackoverflow.com/questions/56775734/error-when-calling-super-method-in-a-typescript-create-react-app-project
<!-- Please try to reproduce the issue with `typescript@next`. It may have already been fixed. -->
**TypeScript Version:** 3.6.0-dev.20190624
<!-- Search terms you tried before logging this (so others can find this issue more easily) -->
**Search Terms:**
- es5
- super
- arrow method
**Code**
```ts
class Foo {
public bar = () => { }
}
class SubFoo extends Foo {
public bar = () => { super.bar(); }
}
```
With `target: "es5"`
**Expected behavior:**
No errors. Call to `super` is allowed.
**Actual behavior:**
See error on `super.bar()`
```
Only public and protected methods of the base class are accessible via the 'super' keyword.
```
Everything works fine using normal (non-arrow) methods. It also works with `"target": "es6"`
**Playground Link:** <!-- A link to a TypeScript Playground "Share" link which demonstrates this behavior -->
**Related Issues:** <!-- Did you find other bugs that looked similar? -->
| Bug | low | Critical |
461,275,910 | TypeScript | Support abstract mixin classes. | ## Search Terms
Related, but not completely the same: https://github.com/microsoft/TypeScript/issues/29653
## Suggestion
Allow mixin classes to be abstract.
## Use Cases
For example, by using a mixin, it might require the user to implement a method.
## Examples
```ts
type Constructor<T = any, A extends any[] = any[]> = new (...a: A) => T
function AwesomeMixin<T extends Constructor>(Base: T = Object) {
return abstract class Awesome extends Base {
abstract someMethod(): number
}
}
```
[playground link](http://www.typescriptlang.org/play/#code/C4TwDgpgBAwg9gOwM7AE4FcDGw6oDwAqUAvFAIYIgA0UAglBAB7AQIAmS5lA2gLolcQfAHwCEEAO5QAFADp5ZAFx0AlCVEEAsACgdAM3QJsAS0R0JEJHAC2EALLHGxhIQbNWHWIhQZsuYdIAQmRIEMoEagDeOlCxUKgQwOioCOQARj5k2FCYADYhnLQWVrZuLOycwaFQ0dpx9emZ2SX2iQAWcGzSKsoI6NZpEKgxcQC+OqNAA)
gives:
```
Cannot find name 'abstract'.
```
and
```
Unreachable code detected
```
## Checklist
My suggestion meets these guidelines:
* [x] This wouldn't be a breaking change in existing TypeScript/JavaScript code
* [x] This wouldn't change the runtime behavior of existing JavaScript code
* [x] This could be implemented without emitting different JS based on the types of the expressions
* [x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
* [x] This feature would agree with the rest of [TypeScript's Design Goals](https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals).
| Suggestion,In Discussion | low | Major |
461,282,622 | flutter | Implement Paint.imageFilter for web | See also https://github.com/flutter/flutter/issues/35141 https://github.com/flutter/engine/pull/9508 | c: new feature,engine,platform-web,c: rendering,P3,a: gamedev,team-web,triaged-web | low | Minor |
461,296,893 | godot | Children of GridContainer have same position as parent | **Godot version:**
Tested in 3.1 and 3.1.1
**Issue description:**
<!-- What happened, and what was expected. -->
I'm using a GridContainer to arrange nodes in a grid. However, I want to get the world/global position of each child in that container. When I try to do that with get_global_position() I only get the position of their parent node i.e. the container.
The children of the container are TextureRects. TextureRect doesn't have a global_position or position property. You can access rect_position or rect_global_position from Control (which it inherits from), but as I mentioned, that only gives the position/global_position of the parent (i.e. GridContainer), not the position of the TextureRect itself.
I print out the rect_global_position of all children in the GridContainer node and it only gives the position of the GridContainer i.e. (50, 50). This is despite the fact that I can see the TextureRects are actually placed in a grid. I also tried printing rect_position, which just comes out as (0, 0) for all children.
What's really weird about this is if I inspect the nodes during runtime with the remote debug scene the actual values for those nodes' positions are correct.
Can I extract the global position for each child in a GridContainer? Could this be a bug, or am I just misunderstanding how Control and Container nodes work?
The scene tree is:
- Control (scene root)
- GridContainer
- TextureRect00
- ...
- TextureRect33
**Minimal reproduction project:**
[Control_Container_Bug.zip](https://github.com/godotengine/godot/files/3332813/Control_Container_Bug.zip)
| enhancement,documentation | low | Critical |
461,330,685 | flutter | Parent render objects that fail to layout children in perform layout fail too late | The docs on `performLayout` indicate that parents are _required_ to layout their children in this method, but there are no assertions checking it.
See https://github.com/flutter/flutter/pull/35110, specifically https://github.com/flutter/flutter/pull/35110/commits/4485cdf54cdb894c7fc3fa96ac7db7e85c3c0f7c
We'll catch this if semantics are enabled by default, but maybe there's some way to force render object parents to layout children, e.g. asserting in an `@mustCallSuper` that they've done so. | framework,c: rendering,P3,team-framework,triaged-framework | low | Minor |
461,334,359 | three.js | Feature Suggestion: Support Global Uniforms | I've been using the Line example in a recent project and I've found the `resolution` uniform on `LineMaterial` a bit difficult to work with. It's per-renderer-specific and must be maintained and updated on every LineMaterial if it changes. I know a [comment mentions that the renderer could eventually set it](https://github.com/mrdoob/three.js/blob/dev/examples/js/lines/LineMaterial.js#L11) but it seems like there could be a general solution to this type of issue.
I'm proposing adding a list of global uniforms to the WebGLRenderer that override a given uniform on all materials being rendered:
```js
renderer.uniforms = {
resolution: {
value: new Vector2()
}
};
```
Other uniforms such as environment maps, time incrementing variables, adn lighting variables could benefit from this pattern, as well. Unity implements something similar using the [Shader.SetGlobalFloat()](https://docs.unity3d.com/ScriptReference/Shader.SetGlobalFloat.html) etc functions.
I think my big open questions in the API design would be:
- How can an individual Material _not_ be affected by a global uniform?
- What should happen if the shape of the uniform values does does not match (Vector3 on global value, Vector2 on material)? | Enhancement | medium | Major |
461,361,831 | godot | High GPU usage in editor with active AnimatedSprites | <!-- Please search existing issues for potential duplicates before filing yours:
https://github.com/godotengine/godot/issues?q=is%3Aissue
-->
**Godot version:**
v3.1.1.stable.official
**OS/device including version:**
Windows 10 Pro 1903
Intel HD Graphics 530 (21.20.16.4550)
Nvidia GeForce GTX 960M (430.86)
**Issue description:**
Running Godot on the integrated Intel GPU
1. I have a simple 2D Scene with some Sprite and one AnimatedSprite (3 frames looping at 5fps), every time I switch to that scene tab my GPU usage goes to 90%, if I disable the "Playing" checkbox of the AnimatedSprite, usage goes to 0%.
Also, if I go from the 2D mode to the Script mode GPU usage on that tab is still at 85%.
2. In Script mode, GPU usage is always between 15% and 25%.
Is that normal for an AnimatedSprite to use 90% of the GPU?
Is it not possible to disable rendering when in Script mode?
| bug,topic:editor,confirmed | low | Major |
461,365,335 | opencv | cv2.error: OpenCV(4.1.0) /io/opencv/modules/core/src/persistence.cpp:2046: error: (-215:Assertion failed) isMap() in function 'operator[]' | 
i got this error | category: contrib,needs investigation | low | Critical |
461,365,572 | godot | TreeItem add move up/down function | <!-- Please search existing issues for potential duplicates before filing yours:
https://github.com/godotengine/godot/issues?q=is%3Aissue
-->
**Godot version:**
<!-- Specify commit hash if non-official. -->
3.1
**Issue description:**
<!-- What happened, and what was expected. -->
Right now TreeItem implements move_to_top() and move_to_bottom() to move the item to the first or last position among its siblings.
I would like the ability to move an Item by an arbitrary amount. I am currently building a modding system ala skyrim, and need to ability to move tree items to arbitrary positions in the list.
| enhancement,topic:gui | low | Major |
461,406,808 | rust | match guard is lengthening borrow unexpectedly under NLL | Spawned off of #60914, namely the [regression][cs_review regression] of the [cs_review crate][]
[cs_review regression]: https://crater-reports.s3.amazonaws.com/pr-60914/try%23f45cc3094ee337acd688771b9234318046b0572d/gh/198d.cs_review/log.txt
[cs_review crate]: https://github.com/198d/cs_review
I was looking for examples of soundness issues fixed by NLL for a blog post that I'm working on, and the first crate I looked at stymied me.
Maybe I'm forgetting something crucial, but I would think we might be able to accept this code ([play](https://play.rust-lang.org/?version=nightly&mode=debug&edition=2015&gist=e7323ca65897ebe873e8154a70457dcc)):
```rust
struct Node(String, Option<Box<Node>>, Option<Box<Node>>);
fn main() {
let mut data = Some(Box::new(Node("input1".to_string(), None, None)));
let mut input1 = &mut data;
loop {
match {input1} { // the `{ }` fool AST-borrowck into accepting w/o NLL
&mut Some(ref mut n) if {true} => { input1 = &mut n.1; }
// ~~~~~~~~~ ~~~~~~~~~ combo of 1. borrow, 2. guard, ...
_other => { break; }
// ~~~~~~ ... and 3. move cause NLL to reject
// Why does guard cause borrow last longer than it would otherwise here?
}
}
}
```
Note: I don't think we're going to hit this "regression" too often, because it critically depends on some bug in AST-borrowck where I believe AST-borrowck mishandled `{ ... }` around the match input. Since I do not think that is a common pattern in match inputs, we probably can get away with not addressing this for a while.
| T-compiler,A-NLL,C-bug,NLL-complete,NLL-polonius | low | Critical |
461,475,112 | rust | Incorrect unused lifetime warning after import failure | When building [this commit](https://github.com/RalfJung/rust/commit/9b317bad57f48cf18a921e0655ab05e59fc19c4d) with `./x.py build --stage 0 src/librustc_mir`, I get the following output:
```
error[E0432]: unresolved import `crate::interpret::InterpretCx`
--> src/librustc_mir/const_eval.rs:25:59
|
25 | InterpResult, InterpErrorInfo, InterpError, GlobalId, InterpretCx, StackPopCleanup,
| ^^^^^^^^^^^
| |
| no `InterpretCx` in `interpret`
| help: a similar name exists in the module: `InterpCx`
error[E0432]: unresolved import `crate::interpret::InterpretCx`
--> src/librustc_mir/transform/const_prop.rs:26:11
|
26 | self, InterpretCx, ScalarMaybeUndef, Immediate, OpTy,
| ^^^^^^^^^^^
| |
| no `InterpretCx` in `interpret`
| help: a similar name exists in the module: `InterpCx`
error[E0392]: parameter `'mir` is never used
--> src/librustc_mir/interpret/intern.rs:23:27
|
23 | struct InternVisitor<'rt, 'mir, 'tcx> {
| ^^^^ unused parameter
|
= help: consider removing `'mir` or using a marker such as `std::marker::PhantomData`
error: aborting due to 3 previous errors
```
The first two are expected, that's a mistake I made. The last one is wrong though, `'mir` is used:
```rust
struct InternVisitor<'rt, 'mir, 'tcx> {
/// previously encountered safe references
ref_tracking: &'rt mut RefTracking<(MPlaceTy<'tcx>, Mutability, InternMode)>,
ecx: &'rt mut CompileTimeEvalContext<'mir, 'tcx>, // <-- used here!
/* ... */
}
```
The thing is, it gets used as argument to `CompileTimeEvalContext`, which is defined in `const_eval.rs`, which had an import failure.
So it looks like the "unused lifetime" lint is a bit too aggressive here and considers a lifetime unused because the way it got used referred to a type that was in a failing module -- or so. I tried to minimize this but failed, [here's my last attempt](https://play.rust-lang.org/?version=beta&mode=debug&edition=2018&gist=4f36d638f5b8b39c215b6c2f4c9164a1). But anyway I think this is a bug -- we want the user to look at the actual failure, not at spurious warnings that were caused by the failure. | A-lints,A-lifetimes,T-compiler,C-bug,E-needs-mcve | low | Critical |
461,503,577 | kubernetes | [Tracking Issue] Pain points in using OpenAPIv2 schema | /kind feature
/sig api-machinery
@sttts @roycaihw @kubernetes/sig-api-machinery-misc
- Multi-types support:
- (https://github.com/kubernetes-client/java/issues/86) Delete calls returns actual objects in the response (e.g. when there's remaining finalizers) while the v2 spec says it's returning a status object.
- (https://github.com/kubernetes-client/python/issues/322, https://github.com/kubernetes/kubernetes/issues/62329) IntOrString cannot be correctly described in the v2 spec.
- Enum support
- (https://github.com/kubernetes/kubernetes/issues/60937#issuecomment-394487896) The v2 spec doesn't say about the allowed values for fields like ImagePullPolicy.
- Model inheritance
- make `metav1.TypeMeta` or `metav1.Object` a parent model for the openapi clients
| sig/api-machinery,kind/feature,lifecycle/frozen | low | Major |
461,535,121 | TypeScript | Result of `Object.create(null)` may be passed to template literal | **TypeScript Version:** 3.5.1
**Search Terms:** template string, template literal, Object.create(null)
**Code**
```ts
`${Object.create(null)}`
```
**Expected behavior:** `TypeError`, as the object passed to the template string has no `toString` method in the prototype chain (as it has no prototype chain at all).
**Actual behavior:** Everything goes well in the compiler, but JavaScript reports runtime error (ex. `TypeError: Cannot convert object to primitive value` in Chrome).
**Playground Link:** https://www.typescriptlang.org/play/index.html#code/AYEg3g8gRgVgpgYwC4DoECc4EMlwBQB2ArgDYkCUAvsEA
**Related Issues:**
https://github.com/microsoft/TypeScript/issues/30239
https://github.com/microsoft/TypeScript/issues/1108
| Suggestion,Awaiting More Feedback | low | Critical |
461,562,193 | flutter | `TextField` should receive the callbacks from `TextSelectionGestureDetector` | Currently, the `TextField` only receives the callback `onTap`, which is called after the `_TextFieldState` handles `onSingleTapUp` from its `TextSelectionGestureDetector`. The lack of other callbacks bothers, though.
Besides supporting all the callbacks from `TextSelectionGestureDetector`, the details (e.g. `TapDownDetails`) should also be forwarded, which is not the case with the currently implemented `onTap` callback. | a: text input,c: new feature,framework,f: material design,P3,team-design,triaged-design | low | Minor |
461,587,353 | go | x/tools/go/analysis/passes/nilness: detect wrapping of nil errors | As of `4874f863`, the `nilness` check doesn't seem to trigger on `fmt.Errorf` calls with an error that is proven nil. Example:
```go
func f() error {
exists, err := g()
if err != nil {
return errors.Wrap(err, "error1")
}
if !exists {
return fmt.Errorf("nothing: %w", err)
}
return nil
}
```
Same with the `%v` verb. I feel like most people would not want to actually produce a `nothing: <nil>` or a `nothing: %!w(<nil>)` message here.
Inspired by https://github.com/dominikh/go-tools/issues/529. | NeedsInvestigation,Tools,Analysis | low | Critical |
461,607,503 | rust | Self::call constrains lifetime covariance and/or inference unexpectedly under NLL | Spawned off of #60914, namely the [regression][vc regression] of the version-compare crate
[vc regression]: https://crater-reports.s3.amazonaws.com/pr-60914/try%23f45cc3094ee337acd688771b9234318046b0572d/gh/timvisee.version-compare/log.txt
Look at this ([play](https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=fd8854c0740e05659404819920bd0474)):
```rust
use std::slice::Iter;
pub struct Version<'a> {
parts: Vec<&'a str>,
}
impl<'a> Version<'a> {
pub fn compare(&self, other: &Version) {
Self::compare_iter(self.parts.iter(), other.parts.iter())
}
fn compare_iter(_: Iter<&'a str>, _: Iter<&'a str>) { }
}
```
we get an NLL migration error for it.
* (The use of `Self::compare_iter` is important on line 9; if you replace that with `Version::compare_iter`, then NLL will accept the input.)
* ((Likewise, the input is accepted if you get rid of the `'a`'s in the formal parameters to `fn compare_iter`, but that is perhaps less surprising.))
Why? I'm not sure; at first I thought it made sense, since I assumed that the call to `Self::compare_iter` would force the two arguments to have the same lifetime `'a` that is also attached to the `self` parameter.
But after reflecting on the matter further, I do not understand why we would not have a reborrow here that would allow the call to `compare_iter` to use a shorter lifetime that both inputs can satisfy.
* (Or, wait: Is `std::slice::Iter<T>` not covariant with respect to `T`? I guess I'll need to check that.)
Anyway, this is either a soundness fix of AST borrow-check (which would be great news), or it is an NLL-complete bug for MIR borrow-check.
I just didn't want it to get lost in the shuffle of a blog post I am currently working on. | T-compiler,A-NLL | low | Critical |
461,657,311 | flutter | PageController properties should be more developer-friendly | In https://github.com/flutter/flutter/issues/32639, the developer was having a difficult time trying to configure PageController to their own use case, as PageController.page is difficult to use without diving into its implementation details.
Hence, we should probably improve the PageController API to be more usable by developers and have improved documentation to help. At the very least, `PageController.page` can have improved instructions/documentation. | framework,d: api docs,c: proposal,P2,team-framework,triaged-framework | low | Minor |
461,713,663 | godot | Non-Object Pointers Implicitly Converted to Bool When Used for Variants | When a non-object pointer is used to construct a Variant, that pointer is implicitly converted to a bool.
This is suboptimal, as a pointer may be mistakenly passed to a function that expects a Variant, and the error will only be caught at run-time, if at all.
If that is done, the engine compiles fine, so that the error can only be caught at run-time. It would make it much simpler to catch those issues if a compiler error occurred when an unsupported (i.e. non-object) pointer is provided for the construction of a Variant.
A simple way to fix this issue is to add the following line to the Variant class definition
```
Variant(const void *p_void) = delete;
```
Such a deleted function would result in a compiler error if an unsupported pointer were used to construct a Variant, while the expected Variant functionality would remain unaltered.
To give a concrete example of the benefits of fixing this issue: the error in the current release version (now [fixed in master](https://github.com/godotengine/godot/commit/c1e733466bf8cd1dfe44787247c9ee54f4f85ae6)) which occurred in /gdnative/variant.cpp due to calling Variant::evaluate with *pointers* to Variants as arguments instead of actual Variants would easily have been caught with this fix, so that it would never have made to a release version.
Alas, implementing this particular fix to the issue would require using C++11 for Godot, as that is required for supporting deleted functions. | enhancement,topic:core,confirmed | low | Critical |
461,745,549 | go | proposal: cmd/fix: automate migrations for simple deprecations | (I've mentioned this in passing on #32014 and #27248, but I don't see an actual proposal filed yet — so here it is!)
Over time, the author of a package may notice certain patterns in the usage of their API that they want to make simpler or clearer for users. When that happens, they may suggest that users update their own code to use the new API.
In many cases, the process of updating is nearly trivial, so it would be nice if some tool in the standard distribution could apply those trivial updates mechanically. The [`go fix`](https://tip.golang.org/cmd/fix/) subcommand was used for similar updates to the language itself, so perhaps it could be adapted to work for at least the simple cases.
The very simplest sort of update rewrites a call to some function or use of some variable or constant to instead call some other function or use some other variable, constant, or expression.
To draw some examples from the standard library:
* The comment for `archive/tar.TypeRegA` says to use `TypeReg` instead.
* The comments for `archive/zip.FileHeader.{Compressed,Uncompressed}Size` say to use the corresponding `*64` fields instead.
* The comments for `image.ZR` and `image.ZP` say to use zero struct literals instead.
* The comment for `go/importer.For` says to use `ForCompiler`, and is implemented as a trivial call to `ForCompiler` with an additional argument.
* The comment for the `io.SEEK_*` constants says to use corresponding `io.Seek*` constants instead.
* The comments for `syscall.StringByte{Slice,Ptr}` say to use the corresponding `Byte*FromString` functions, and are implemented as short wrappers around those functions.
Outside the standard library, this pattern can also occur when a package makes a breaking change: if the `v3` API can express all of the same capabilities as `v2`, then `v2` can be implemented as a wrapper around `v3` — and references to the `v2` identifiers can be replaced with direct references to the underlying `v3` identifiers.
----
**See the current proposal details in https://github.com/golang/go/issues/32816#issuecomment-517827465 below.**
Previous draft (prior to https://github.com/golang/go/issues/32816#issuecomment-507721945):
<details>
I propose that we establish a consistent convention to mark these kinds of mechanical replacements, and improve `cmd/fix` to be able to apply them.
I'm not particularly tied to any given convention, but in the spirit of having something concrete to discuss, I propose two tokens, `//go:fix-to` and `//go:forward`, as follows:
* `//go:fix-to EXPR` on a constant or variable indicates that `go fix` should replace occurrences of that constant or variable with the expression `EXPR`. Free variables in the expression are interpreted as package names, and `go fix` may rewrite them to avoid collisions with non-packages.
* `//go:fix-to .EXPR` on struct field indicates that `go fix` should replace references to that field with the given selector expression (which may be a field access OR a method call) on the same value. Free variables are again interpreted as package names. If the expression is a method call, it replaces only reads of the field.
* `//go:forward` on an individual constant or variable indicates that `go fix` should replace the constant or variable with the expression from which it is initialized. If a constant is declared with a type but initialized from an untyped expression, the replacement is wrapped in a conversion to that type.
* `//go:forward` on a `const` or `var` block indicates that *every* identifier within the block should be replaced by the expression from which it is initialized.
* `//go:forward` on a method or function indicates that `go fix` should inline its body at the call site, renaming any local variables and labels as needed to avoid collisions. The function or method must have at most one `return` statement and no `defer` statements.
* `//go:forward` on a type alias indicates that `go fix` should replace references to the alias name with the (immediate) type it aliases.
All of these rewrites must be acyclic: the result of a (transitively applied) rewrite must not refer to the thing being rewritten.
Note that there is a prototype example-based refactoring tool for Go in [`golang.org/x/tools/cmd/eg`](https://godoc.org/golang.org/x/tools/cmd/eg) that supported a broader set of refactoring rules. It might be useful as a starting point.
----
For the above examples, the resulting declarations might look like:
```go
package image
// Deprecated: Use a literal image.Point{} instead.
var ZP = Point{} //go:forward
// Deprecated: Use a literal image.Rectangle{} instead.
var ZR = Rectangle{} //go:forward
```
```go
package importer
// Deprecated: Use ForCompiler, which populates a FileSet
// with the positions of objects created by the importer.
//
//go:forward
func For(compiler string, lookup Lookup) types.Importer {
return ForCompiler(token.NewFileSet(), compiler, lookup)
}
```
```go
package io
// Deprecated: Use io.SeekStart, io.SeekCurrent, and io.SeekEnd.
const (
SEEK_SET int = 0 //go:fix-to io.SeekStart
SEEK_CUR int = 1 //go:fix-to io.SeekCur
SEEK_END int = 2 //go:fix-to io.SeekEnd
)
```
```go
package syscall
// Deprecated: Use ByteSliceFromString instead.
//
//go:forward
func StringByteSlice(s string) []byte {
a, err := ByteSliceFromString(s)
if err != nil {
panic("string with NUL passed to syscall.ByteSliceFromString")
}
return a
}
[…]
```
----
This proposal does not address the `archive/tar` use-case: callers producing archives might be able to transparently migrate from `TypeRegA` to `TypeReg`, but it isn't obvious that callers consuming archives can safely do so.
Nor does this proposal does not address the `archive/zip.FileHeader` use-case: the deprecation there indicates a loss of precision, and the caller should probably be prompted to make related fixes in the surrounding code.
Both of those cases might be addressable with a deeper example-based refactoring tool, but (I claim) are too subtle to handle directly in `go fix`.
</details>
----
CC @marwan-at-work @thepudds @jayconrod @ianthehat @myitcv @cep21
| Proposal,NeedsInvestigation,FeatureRequest,Proposal-FinalCommentPeriod | high | Critical |
461,804,463 | godot | NARROWING_CONVERSION warnings when using `clamp` on an integer | **Godot version:**
v3.1.1.stable.official
**OS/device including version:**
iMac (Retina 5K, 27-inch, 2017)
macOS Mojave (10.14.5)
**Issue description:**
I get a NARROWING_CONVERSION warning - Narrowing conversion (float is converted to int and loses precision) - in the following line:
```
func shake(duration: float, intensity: float = 0.2, frequency: int = 80):
duration = clamp(duration, 0, 4)
intensity = clamp(intensity, 0, 1)
frequency = clamp(frequency, 0, 500) # => Warning: NARROWING_CONVERSION
```
I'm not sure why is there a problem, since my intention is to pass an integer, integer limits, and obtain an integer.
I understand the documentation states that this method returns a `float`, not an `int`, although when testing the output I do get an `int`:
```
print(typeof(clamp(frequency,0,500)) == TYPE_INT) # => TRUE
```
Which is the expected behavior. So all is good, except that it's throwing a warning when I think it shouldn't.
Thank you! | bug,discussion,topic:gdscript,confirmed | low | Major |
461,811,273 | go | x/tools/go/packages: high CPU usage while processing cgo file | <!-- Please answer these questions before submitting your issue. Thanks! -->
### What version of Go are you using (`go version`)?
<pre>
$ go version
go version go1.12.5 linux/amd64
</pre>
### Does this issue reproduce with the latest release?
Yes
### What operating system and processor architecture are you using (`go env`)?
<details><summary><code>go env</code> Output</summary><br><pre>
$ go env
GOARCH="amd64"
GOBIN="/home/radhi/Go/bin"
GOCACHE="/home/radhi/.cache/go-build"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/home/radhi/Go"
GOPROXY=""
GORACE=""
GOROOT="/usr/lib/go"
GOTMPDIR=""
GOTOOLDIR="/usr/lib/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build763115998=/tmp/go-build -gno-record-gcc-switches"
</pre></details>
### What did you do?
This issue is related with [vscode-go#2598](https://github.com/microsoft/vscode-go/issues/2598). While working on cgo project, both `gocode` and `gopls` will use huge amount of CPU when making autocomplete suggestion. It can be seen [here](https://giant.gfycat.com/WateryUnnaturalCrane.webm) for `gocode` and [here](https://giant.gfycat.com/DiligentUglyGrouper.webm) for `gopls`.
After looking around, I found out the reason for this is because both [`gocode`](https://github.com/stamblerre/gocode/blob/81059208699789f992bb4a4a3fedd734e335468d/internal/suggest/suggest.go#L138) and [`gopls`](https://github.com/golang/tools/blob/252024b8295926254bbc18903b9b7d4f0389df2f/internal/lsp/cache/view.go#L118) uses `LoadSyntax` mode, which make `go/packages` run `go list` with `-compiled` flag set to true, which lead to high CPU usage in cgo project.
### What did you expect to see?
The cgo file can be parsed as light as the normal Go code.
### What did you see instead?
The process uses huge amount of CPU. | Performance,NeedsInvestigation,Tools | low | Critical |
461,814,523 | youtube-dl | Unsupported URL: animemusicvideos.org | <!--
######################################################################
WARNING!
IGNORING THE FOLLOWING TEMPLATE WILL RESULT IN ISSUE CLOSED AS INCOMPLETE
######################################################################
-->
## Checklist
<!--
Carefully read and work through this check list in order to prevent the most common mistakes and misuse of youtube-dl:
- First of, make sure you are using the latest version of youtube-dl. Run `youtube-dl --version` and ensure your version is 2019.06.27. If it's not, see https://yt-dl.org/update on how to update. Issues with outdated version will be REJECTED.
- Make sure that all provided video/audio/playlist URLs (if any) are alive and playable in a browser.
- Make sure that site you are requesting is not dedicated to copyright infringement, see https://yt-dl.org/copyright-infringement. youtube-dl does not support such sites. In order for site support request to be accepted all provided example URLs should not violate any copyrights.
- Search the bugtracker for similar site support requests: http://yt-dl.org/search-issues. DO NOT post duplicates.
- Finally, put x into all relevant boxes (like this [x])
-->
- [x] I'm reporting a new site support request
- [x] I've verified that I'm running youtube-dl version **2019.06.27**
- [x] I've checked that all provided URLs are alive and playable in a browser
- [x] I've checked that none of provided URLs violate any copyrights
- [x] I've searched the bugtracker for similar site support requests including closed ones
## Example URLs
<!--
Provide all kinds of example URLs support for which should be included. Replace following example URLs by yours.
-->
- Single video: https://www.animemusicvideos.org/members/members_videoinfo.php?v=19211
| site-support-request | low | Critical |
461,838,932 | pytorch | Training CNNs with deconvolution | ## 🚀 Feature
Implicitly calculate the scatter/covariance matrix of the im2col matrix.
```python
def F(I):
"""
Please help us to do the following implicitly:
"""
X= im2col(I)
[email protected]()/N
return Cov
```
## Motivation
Neural networks are learning from a convolved world! Machine learning is analogous to human learning with blurred/nearsighted vision. Therefore, it is hard. But things are much easier if the machines wear glasses.
https://arxiv.org/abs/1905.11926
Recently we notice that the convolutional networks converge much faster and better by applying a real 'deconvolution'. For example, on the well known CIFAR-10 dataset, with deconv, 20-epoch training achieves the same performance that used to require 100-300 epochs. Tested on over 10 networks on multiple datasets, our improvements over batch norm is similar to batch norm over vanilla training.
There is one step that hinders the speedup. When calculating the kernel for deconvolution, we need to calculate the autocorrelation of the pixels. Currently, we resort to the unfold function which uses excessive memory and more time. The training could be much better and easier if this is done implicitly.
## Pitch
We want this simple modification to be included in pytorch so that the future training of CNNs are more straightforward.
## Alternatives
https://github.com/yechengxi/deconvolution/blob/2aa372fd232ddad08082cb8a1f8ab46b16b28a5b/models/deconv.py#L303
Currently the calculation is implemented in three lines:
```
X = torch.nn.functional.unfold(x, self.kernel_size,self.dilation,self.padding,self.stride).transpose(1, 2).contiguous()
X=X.view(-1,X.shape[-1])
Cov = X.t() @ X / X.shape[0]
```
The world is likely to be very different if these three lines are optimized in the library.
cc @fmassa @vfdev-5 | module: convolution,triaged,module: vision,function request | low | Major |
461,846,134 | pytorch | Integer division by Zero giving large number results instead of NaN/inf on Windows | ## 🐛 Bug
Integer tensors, when divided by zero, is giving large integer values as answers instead of flagging as ZeroDivision error or results as inf/NaN. Float numbers, however, are behaving as expected (returns inf)
For e.g in Numpy, the behavior is to return inf with "RuntimeWarning: divide by zero encountered in true_divide"
## To Reproduce
Steps to reproduce the behavior:
```
1. torch.tensor([3,4,5])/torch.tensor([5,0,1])
>>> tensor([0, 4294967295,5])
2. torch.tensor([3,4,5])/0
>>> tensor([4294967295, 4294967295, 4294967295])
#For floats
3. torch.tensor([3.0,4.0,5.0])/0
>>> tensor([inf, inf, inf]
Comparison to Numpy:
np.array([3,4,5])/0
>>> array([inf, inf, inf])
RuntimeWarning: divide by zero encountered in true_divide
```
- PyTorch Version: '1.1.0'
- OS : Windows
- Installed PyTorch: pip
- Python version: 3.7
- CUDA/cuDNN version: Cuda release 9.0, V9.0.176
- GPU models and configuration: NVIDIA GTX1070
**Update**: The above behavior is seen in JupyterNotebook. On trying from the Python console itself, the process just terminates - which I found out was an issue closed with won'tfix at https://github.com/pytorch/pytorch/issues/8079.
Wondering why the behavior is different in JupyterNotebook!
| module: cpu,triaged | low | Critical |
461,859,226 | TypeScript | Resolve project references from root | <!-- 🚨 STOP 🚨 𝗦𝗧𝗢𝗣 🚨 𝑺𝑻𝑶𝑷 🚨
Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Please read the FAQ first, especially the "Common Feature Requests" section.
-->
## Search Terms
Project reference root resolve.
<!-- List of keywords you searched for before creating this issue. Write them down here so that others can find this suggestion more easily -->
## Suggestion
Resolve project reference paths from root directory of a mono repository.
## Use Cases
We have a large mono-repository with 1000s of sub-packages we want to convert to TS projects. Currently the references between them must be defined as relative paths, leading to configuration like:
```
"references": [
{
"path": "../../../base"
},
{
"path": "../colors"
},
{
"path": "../device_capabilities"
}
],
```
Which is:
* Hard to read and reason about
* Creates noisy diffs when moving packages
Ideally project references could be resolved from the root of the mono-repo project, e.g. `rootDir` or `baseUrl` options.
E.g.:
```
"references": [
{
"path": "base"
},
{
"path": "ui/base/colors"
},
{
"path": "ui/base/device_capabilities"
}
],
```
## Checklist
My suggestion meets these guidelines:
* [x] This wouldn't be a breaking change in existing TypeScript/JavaScript code
* [x] This wouldn't change the runtime behavior of existing JavaScript code
* [x] This could be implemented without emitting different JS based on the types of the expressions
* [x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
* [x] This feature would agree with the rest of [TypeScript's Design Goals](https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals).
| Suggestion,Awaiting More Feedback | low | Critical |
461,867,040 | rust | HRTB prevent mem::transmute and mem::MaybeUninit from working | The following code prevents `mem::MaybeUninit` and `mem::transmute` from creating values.
```rust
trait Ty<'a> {
type V;
}
trait SIter: for<'a> Ty<'a> {
fn f<F>(&self, f: F)
where
F: for<'r> Fn(<Self as Ty<'r>>::V);
}
struct S<I>(I);
impl<'a, I: Ty<'a>> Ty<'a> for S<I> {
type V = <I as Ty<'a>>::V;
}
trait Is<'a> {
type V;
}
impl<'a, T> Is<'a> for T {
type V = T;
}
impl<I: SIter, Item> SIter for S<I>
where
// for<'r> Self: Ty<'r, V = <I as Ty<'r>>::V>,
for<'r> S<I>: Ty<'r, V = Item>,
for<'r> I: Ty<'r, V = Item>,
// for<'r> <Self as Ty<'r>>::V: Is<'r, V = <I as Ty<'r>>::V>,
{
fn f<F>(&self, f: F)
where
F: Fn(<Self as Ty>::V),
{
self.0.f(|item| unsafe {
// let item: <Self as Ty>::V = std::mem::transmute_copy(&item);
let item: <Self as Ty>::V = std::mem::MaybeUninit::uninit().assume_init();
// let item: <Self as Ty>::V = loop {};
f(item)
})
}
}
```
([Playground](https://play.rust-lang.org/?version=nightly&mode=debug&edition=2018&gist=1a2fc7bec9aa84a18b9ab59a1d18167a))
Errors:
```
Compiling playground v0.0.1 (/playground)
error[E0308]: mismatched types
--> src/lib.rs:40:15
|
40 | f(item)
| ^^^^ expected associated type, found type parameter
|
= note: expected type `<S<I> as Ty<'_>>::V`
found type `Item`
error[E0277]: expected a `std::ops::Fn<(Item,)>` closure, found `F`
--> src/lib.rs:40:13
|
40 | f(item)
| ^^^^^^^ expected an `Fn<(Item,)>` closure, found `F`
|
= help: the trait `std::ops::Fn<(Item,)>` is not implemented for `F`
= help: consider adding a `where F: std::ops::Fn<(Item,)>` bound
error: aborting due to 2 previous errors
Some errors have detailed explanations: E0277, E0308.
For more information about an error, try `rustc --explain E0277`.
error: Could not compile `playground`.
To learn more, run the command again with --verbose.
```
The code works fine without any unsafe if I remove all lifetimes from it.
```rust
trait Ty {
type V;
}
trait SIter: Ty {
fn f<F>(&self, f: F)
where
F: Fn(<Self as Ty>::V);
}
struct S<I>(I);
impl<I: Ty> Ty for S<I> {
type V = <I as Ty>::V;
}
// trait Is<'a> {
// type V;
// }
// impl<'a, T> Is<'a> for T {
// type V = T;
// }
impl<I: SIter> SIter for S<I>
where
// for<'r> Self: Ty<'r, V = <I as Ty<'r>>::V>,
// for<'r> S<I>: Ty<'r, V = Item>,
// for<'r> I: Ty<'r, V = Item>,
// for<'r> <Self as Ty<'r>>::V: Is<'r, V = <I as Ty<'r>>::V>,
{
fn f<F>(&self, f: F)
where
F: Fn(<Self as Ty>::V),
{
self.0.f(|item| unsafe {
// let item: <Self as Ty>::V = std::mem::transmute_copy(&item);
// let item: <Self as Ty>::V = std::mem::MaybeUninit::uninit().assume_init();
// let item: <Self as Ty>::V = loop {};
f(item)
})
}
}
```
([Playground](https://play.rust-lang.org/?version=nightly&mode=debug&edition=2018&gist=936da463b2547b9d225f3dc217b3d8af))
| A-trait-system,E-needs-test,T-compiler,C-bug,A-higher-ranked | low | Critical |
461,904,199 | scrcpy | Thank You Very Much For Making this Sir ! | wontfix | low | Minor |
|
462,046,251 | pytorch | Illegal instruction (core dumped) when running in qemu | I had installed Pytorch using Anaconda from pytorch website.
conda install pytorch-cpu torchvision-cpu -c pytorch
I'm getting Illegal instruction (core dumped)
When I start the app using gdb, I get the following error.
I guess something is wrong with libcaffe2.so
Thread 1 "python" received signal SIGILL, Illegal instruction.
0x00007fffa8ec2486 in THFloatVector_normal_fill_AVX2 () from /U01/anaconda3/envs/pyt1/lib/python3.7/site-packages/torch/lib/libcaffe2.so
Machine configuration:
Machine is Ubuntu 18.04.2
```
root@USANZV-MER-DMA485:~# lscpu
Architecture: x86_64
CPU op-mode(s): 32-bit, 64-bit
Byte Order: Little Endian
CPU(s): 16
On-line CPU(s) list: 0-15
Thread(s) per core: 1
Core(s) per socket: 1
Socket(s): 16
NUMA node(s): 1
Vendor ID: GenuineIntel
CPU family: 6
Model: 13
Model name: QEMU Virtual CPU version (cpu64-rhel6)
Stepping: 3
CPU MHz: 2294.598
BogoMIPS: 4589.19
Hypervisor vendor: KVM
Virtualization type: full
L1d cache: 32K
L1i cache: 32K
L2 cache: 4096K
NUMA node0 CPU(s): 0-15
Flags: fpu de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pse36 clflush mmx fxsr sse sse2 syscall nx lm nopl cpuid pni cx16 hypervisor lahf_lm abm pti
root@USANZV-MER-DMA485:~#
```
cc @ezyang @gchanan @zou3519 @VitalyFedyunin | high priority,module: crash,module: cpu,triaged,module: vectorization | medium | Critical |
462,051,063 | pytorch | Reducer bucketing based on autograd profile | ## 🚀 Feature
How gradient tensors are batched together in bucket prior to reducing them across processes is done completely statically today. A user specifies a lower bound on the bucket size and parameters are bucketed accordingly. We can use profile data of the backwards pass to find a bucket assignment that better aligns with the point in time gradients are ready.
## Motivation
In some vision models the last layers have many weights (big fully connected layers) and the first layers have only a few weights (small convolutional layers) The bulk of gradients are computed early during the backwards pass. Conversely the gradient tensors for the first layers are computed last and are relatively small. If the final bucket to reduce is 25MB and we wait for the final 1KB worth of gradients before we start, we may achieve better end to end latency if we instead start reduction sooner, without the final 1KB, and run a separate reduction for the final piece of data. We have hooks in `c10d::Reducer`, as well as the autograd profiler, both of which can be used to generate timing data for the gradient of every parameter. Depending on this timing and the size of the gradients, we can create a bucketing assignment that is a better match for the execution order of autograd and doesn't have a big "latency bubble" after autograd has finished.
## Pitch
* Evaluate applicability of the autograd profiler here. E.g. can we get a mapping of the indices in `model.parameters()` to some relative timestamp their gradient was computed? If not, how easy would it be to add it? (If the autograd profiler cannot be used we can look into adding timing to `c10d::Reducer` directly.)
* Generate a new bucketing assignment based on relative time per parameter as well as the size of the corresponding gradient.
* Distribute the newly computed bucketing order to every participating process. This is done by nvidia/apex as well (cc @mcarilli) where the parameter order is distributed to all processes. If there is mismatch between the order that the model layers/parameters are defined and the order they are used, any approach that closely resembles the autograd order will already be an improved over the naive strategy of simply using definition order.
## Additional context
Stretch goal: generate a number of bucketing assignments and then empirically figure out which one is best for the set of machines the model is running on. | oncall: distributed,feature,triaged | low | Minor |
462,058,762 | rust | Inclusive version of take_while | `Iterator::take_while` stops _before_ the first element where the condition evaluates to `false`. That is the correct behavior given its name, but it makes it difficult to write an iterator that should include the boundary element. In particular consider something like iterating over a [histogram](https://docs.rs/hdrhistogram/), trimming off the tails:
```rust
for v in histogram
.iter_linear(1_000)
.skip_while(|v| v.quantile() < 0.01)
.take_while(|v| v.quantile() < 0.99)
```
This may seem right, but consider an iterator where the elements are such that `v.quantile()` yields this sequence: `[0, 0.02, 0.99]`. Here, the bin that spans `<0.02-0.99]` will be dropped, even though it includes the majority of the samples. What we really want to do is take from the iterator until we have _received_ an element whose `v.quantile() > 0.99`. To write that with `take_while`, we need something like:
```rust
let mut got_true = true;
for v in h
.iter_linear(1_000)
.skip_while(|v| v.quantile() < 0.01)
.take_while(move |v| {
if got_true {
// we've already yielded when condition was true
return false;
}
if v.quantile() > 0.99 {
// this must be the first time condition returns true
// we should yield i, and then no more
got_true = true;
}
// we should keep yielding
true
})
```
Which isn't exactly obvious.
So, I propose we add `Iterator::take_until_inclusive`, which yields elements up to and including the first element for which its argument returns true. The name isn't great, but I'm also struggling to come up with a better one. In some sense, I want the function to communicate that it yields every item it evaluates. Some other possible names if we're willing to invert the boolean: `break_once`, `break_after`, `end_at`, `end_once`, `end_after`.
Thoughts? | T-libs-api,C-feature-request,A-iterators | medium | Critical |
462,059,730 | go | x/tools/go/packages: panic in testParseFileModifyAST | Observed in https://build.golang.org/log/269df758e38c6dcc180de71777773231b6f98014 (on `windows-amd64-2016`):
```
panic: runtime error: index out of range [recovered]
panic: runtime error: index out of range
goroutine 512 [running]:
testing.tRunner.func1(0xc0001bab00)
C:/workdir/go/src/testing/testing.go:830 +0x399
panic(0x6e5800, 0x9959e0)
C:/workdir/go/src/runtime/panic.go:522 +0x1c3
golang.org/x/tools/go/packages_test.testParseFileModifyAST(0xc0001bab00, 0x7a5740, 0x9bbf10)
C:/workdir/gopath/src/golang.org/x/tools/go/packages/packages_test.go:852 +0x4b9
golang.org/x/tools/go/packages/packagestest.TestAll.func1(0xc0001bab00)
C:/workdir/gopath/src/golang.org/x/tools/go/packages/packagestest/export.go:101 +0x6f
testing.tRunner(0xc0001bab00, 0xc000047e60)
C:/workdir/go/src/testing/testing.go:865 +0xc7
created by testing.(*T).Run
C:/workdir/go/src/testing/testing.go:916 +0x361
FAIL golang.org/x/tools/go/packages 17.895s
```
It's not obvious to me whether this is a secondary symptom of the race reported in #31749 or an unrelated bug.
CC @matloob @ianthehat | Testing,NeedsInvestigation,Tools | low | Critical |
462,065,558 | go | x/tools: frequent out-of-memory errors on linux-arm builder | The tests under `golang.org/x/tools` almost always fail on the `linux-arm` builder.
Looking at the build dashboard, the most frequent failure mode (by far) seems to result in errors of the form `fork/exec /workdir/go/bin/go: cannot allocate memory *os.PathError` in the `golang.org/x/tools/internal/lsp` tests:
https://build.golang.org/log/5fb7985054d8b682b81438c385ff16e8325a3aa6
https://build.golang.org/log/e422caa59d35f5c76e097fdadb60407ee2807368
https://build.golang.org/log/3e3e538cf33e70880da37c2dd1c716b733b4b009
https://build.golang.org/log/739f069936cc47cc800b4d898c505e17a9d4a7e1
However, some of the other tests have also flaked with various resource-exhaustion errors:
A similar `cannot allocate memory` failure mode for `golang.org/x/tools/go/internal/gcimporter`:
https://build.golang.org/log/99a21d9e2e1064d08890439b43de987e0bfcdf52
`fatal error: runtime: out of memory` in `golang.org/x/tools/go/ssa`:
https://build.golang.org/log/de56b0ffe0e39b38b9ed449bd0cd382be72eda69
`pthread_create failed: Resource temporarily unavailable` and `no space left on device`:
https://build.golang.org/log/7151dca16e38a6f61051f032b2f6b713253052ac
---
I don't know exactly what the resource footprint of the `linux-arm` builder is (@andybons or @dmitshur might know?), but if the `x/tools` tests are expected to pass within that footprint we may need to dial back the test concurrency on that builder.
CC @ianthehat | Testing,Builders,NeedsInvestigation,Tools | low | Critical |
462,082,328 | go | x/debug/cmd/viewcore: does not build on aix-ppc64 | The `x/debug` build is consistently failing on the `aix-ppc64` builder.
It appears that `x/debug` depends on `github.com/chzyer/readline`, but that package is missing an `aix` implementation.
CC @chzyer @Helflym
```
aix-ppc64 at 67f181bfd84dfd5942fe9a29d8a20c9ce5eb2fea building debug at 621e2d3f35dac46daf912f8d9d2fabd57d022520
:: Running /ramdisk8GB/workdir-host-aix-ppc64-osuosl/go/bin/go with args ["/ramdisk8GB/workdir-host-aix-ppc64-osuosl/go/bin/go" "test" "-short" "golang.org/x/debug/..."] and env ["TERM=dumb" "AUTHSTATE=compat" "SHELL=/usr/bin/ksh" "HOME=/" "USER=root" "PATH=/ramdisk8GB/workdir-host-aix-ppc64-osuosl/go/bin:/opt/freeware/bin:/usr/bin:/etc:/usr/sbin:/usr/ucb:/usr/bin/X11:/sbin:/usr/java7_64/jre/bin:/usr/java7_64/bin" "TZ=CST6CDT" "LANG=en_US" "LOCPATH=/usr/lib/nls/loc" "LC__FASTMSG=true" "ODMDIR=/etc/objrepos" "CLCMD_PASSTHRU=1" "LOGNAME=root" "LOGIN=root" "META_BUILDLET_BINARY_URL=https://storage.googleapis.com/go-builder-data/buildlet.aix-ppc64" "GO_STAGE0_NET_DELAY=300ms" "GO_STAGE0_DL_DELAY=100ms" "NLSPATH=/usr/lib/nls/msg/%L/%N:/usr/lib/nls/msg/%L/%N.cat:/usr/lib/nls/msg/%l.%c/%N:/usr/lib/nls/msg/%l.%c/%N.cat" "WORKDIR=/ramdisk8GB/workdir-host-aix-ppc64-osuosl" "GOROOT_BOOTSTRAP=/ramdisk8GB/workdir-host-aix-ppc64-osuosl/go1.4" "GO_BUILDER_NAME=aix-ppc64" "GOROOT_BOOTSTRAP=/opt/freeware/lib/golang" "PATH=/opt/freeware/bin:/usr/bin:/etc:/usr/sbin:/usr/ucb:/usr/bin/X11:/sbin:/usr/java7_64/jre/bin:/usr/java7_64/bin" "GOROOT=/ramdisk8GB/workdir-host-aix-ppc64-osuosl/go" "GOPATH=/ramdisk8GB/workdir-host-aix-ppc64-osuosl/gopath" "GOPROXY=http://10.240.0.23:30157" "GOPROXY=https://proxy.golang.org" "TMPDIR=/ramdisk8GB/workdir-host-aix-ppc64-osuosl/tmp" "GOCACHE=/ramdisk8GB/workdir-host-aix-ppc64-osuosl/gocache"] in dir /ramdisk8GB/workdir-host-aix-ppc64-osuosl/gopath/src/golang.org/x/debug
go: downloading github.com/spf13/cobra v0.0.3
go: downloading github.com/chzyer/readline v0.0.0-20180603132655-2972be24d48e
go: extracting github.com/chzyer/readline v0.0.0-20180603132655-2972be24d48e
go: extracting github.com/spf13/cobra v0.0.3
go: downloading github.com/spf13/pflag v1.0.3
go: extracting github.com/spf13/pflag v1.0.3
go: finding github.com/chzyer/readline v0.0.0-20180603132655-2972be24d48e
go: finding github.com/spf13/pflag v1.0.3
go: finding github.com/spf13/cobra v0.0.3
# github.com/chzyer/readline
../../../../pkg/mod/github.com/chzyer/[email protected]/utils.go:241:9: undefined: State
ok golang.org/x/debug/internal/core 0.031s
``` | Testing,help wanted,Builders,NeedsInvestigation,OS-AIX | low | Critical |
462,084,500 | go | x/crypto/ssh: test consistently runs out of memory on js-wasm builder | The `golang.org/x/crypto/ssh` test consistently fails on the `js-wasm` builder with the error message `runtime: out of memory: cannot allocate 8192-byte block`.
Can the test be made to fit within the runtime on that architecture? If not, it should be skipped, instead of continuing to fail and potentially masking more serious problems.
CC @hanwen @neelance @FiloSottile | Testing,help wanted,NeedsFix,arch-wasm | low | Critical |
462,085,936 | flutter | Improve error message when trying to run on a device the project doesn't support | `flutter run` should do a check very early on that the project supports the target device, and fail with a clear error message (e.g., `This project doesn't support macOS`). Long-term maybe explicitly trying to run on an unsupported device should run the relevant `flutter create` (or whatever it ends up being called) command to add that platform, but that's a ways out for at least some desktop platforms so we'll need an interim error message.
(See #35215 for an example of the current behavior, where trying to run on macOS is giving `Podfile missing` because that happens to be the first fatal error that's hit.)
CC @jonahwilliams | tool,a: quality,a: error message,P2,team-tool,triaged-tool | low | Critical |
462,086,027 | go | x/net/http2: data race in TestIssue20704Race | A flake observed in `golang.org/x/net/http2` on the `freebsd-amd64-race` builder.
From the name of the test, I'm guessing it's intended to detect and prevent exactly the race in question, so there is probably a serious bug or regression here.
https://build.golang.org/log/e64159dc443157fafd5d63551f3478b309a5f4c0
```
==================
WARNING: DATA RACE
Write at 0x00c0002e6000 by goroutine 87:
runtime.slicecopy()
/tmp/workdir/go/src/runtime/slice.go:197 +0x0
bufio.(*Writer).Write()
/tmp/workdir/go/src/bufio/bufio.go:637 +0x3de
golang.org/x/net/http2.(*responseWriter).write()
/tmp/workdir/gopath/src/golang.org/x/net/http2/server.go:2654 +0x1e0
golang.org/x/net/http2.(*responseWriter).Write()
/tmp/workdir/gopath/src/golang.org/x/net/http2/server.go:2628 +0x70
golang.org/x/net/http2.TestIssue20704Race.func1()
/tmp/workdir/gopath/src/golang.org/x/net/http2/server_test.go:3727 +0x98
net/http.HandlerFunc.ServeHTTP()
/tmp/workdir/go/src/net/http/server.go:2007 +0x51
net/http.serverHandler.ServeHTTP()
/tmp/workdir/go/src/net/http/server.go:2802 +0xce
net/http.initNPNRequest.ServeHTTP()
/tmp/workdir/go/src/net/http/server.go:3374 +0xfc
net/http.(*initNPNRequest).ServeHTTP()
<autogenerated>:1 +0xa6
net/http.Handler.ServeHTTP-fm()
/tmp/workdir/go/src/net/http/server.go:86 +0x64
golang.org/x/net/http2.(*serverConn).runHandler()
/tmp/workdir/gopath/src/golang.org/x/net/http2/server.go:2119 +0xac
Previous read at 0x00c0002e6000 by goroutine 126:
runtime.slicecopy()
/tmp/workdir/go/src/runtime/slice.go:197 +0x0
golang.org/x/net/http2.(*Framer).WriteDataPadded()
/tmp/workdir/gopath/src/golang.org/x/net/http2/frame.go:683 +0x34d
golang.org/x/net/http2.(*writeData).writeFrame()
/tmp/workdir/gopath/src/golang.org/x/net/http2/frame.go:643 +0x11d
golang.org/x/net/http2.(*serverConn).writeFrameAsync()
/tmp/workdir/gopath/src/golang.org/x/net/http2/server.go:765 +0x58
Goroutine 87 (running) created at:
golang.org/x/net/http2.(*serverConn).processHeaders()
/tmp/workdir/gopath/src/golang.org/x/net/http2/server.go:1853 +0x90f
golang.org/x/net/http2.(*serverConn).processFrame()
/tmp/workdir/gopath/src/golang.org/x/net/http2/server.go:1384 +0x40d
golang.org/x/net/http2.(*serverConn).processFrameFromReader()
/tmp/workdir/gopath/src/golang.org/x/net/http2/server.go:1342 +0x7ad
golang.org/x/net/http2.(*serverConn).serve()
/tmp/workdir/gopath/src/golang.org/x/net/http2/server.go:860 +0x12c1
golang.org/x/net/http2.(*Server).ServeConn()
/tmp/workdir/gopath/src/golang.org/x/net/http2/server.go:462 +0xda2
golang.org/x/net/http2.ConfigureServer.func1()
/tmp/workdir/gopath/src/golang.org/x/net/http2/server.go:288 +0x117
net/http.(*conn).serve()
/tmp/workdir/go/src/net/http/server.go:1800 +0x1d35
Goroutine 126 (running) created at:
golang.org/x/net/http2.(*serverConn).startFrameWrite()
/tmp/workdir/gopath/src/golang.org/x/net/http2/server.go:1143 +0x365
golang.org/x/net/http2.(*serverConn).scheduleFrameWrite()
/tmp/workdir/gopath/src/golang.org/x/net/http2/server.go:1244 +0x371
golang.org/x/net/http2.(*serverConn).wroteFrame()
/tmp/workdir/gopath/src/golang.org/x/net/http2/server.go:1205 +0x1dd
golang.org/x/net/http2.(*serverConn).serve()
/tmp/workdir/gopath/src/golang.org/x/net/http2/server.go:858 +0x13ce
golang.org/x/net/http2.(*Server).ServeConn()
/tmp/workdir/gopath/src/golang.org/x/net/http2/server.go:462 +0xda2
golang.org/x/net/http2.ConfigureServer.func1()
/tmp/workdir/gopath/src/golang.org/x/net/http2/server.go:288 +0x117
net/http.(*conn).serve()
/tmp/workdir/go/src/net/http/server.go:1800 +0x1d35
==================
--- FAIL: TestIssue20704Race (4.35s)
testing.go:853: race detected during execution of test
FAIL
FAIL golang.org/x/net/http2 23.036s
```
CC @bradfitz @tombergan | NeedsInvestigation | low | Critical |
462,086,954 | flutter | Switching off network provider on iOS does not immediately stop WebSocket connection | Switching off WiFi or mobile network provider on iOS while websocket connection is alive should cause immediately emitting done(close) event to listening streams. But this does not happen on iOS in contrast to Android.
*Preparations to reproduce the issue:*
1) grab the test code: [github project main.dart](https://github.com/nailgilaziev/ws_change_network_reaction/blob/issue_dartio/lib/main.dart)
2) prepare iOS: I use wifi connection to the internet and mobile connection is off for now. But it doesn't depend on that case. you can use all of combinations: Mobile-on/wifi-off, all providers enabled, etc. Behaviour the same for different network providers and not matter what you use.
*Running scenario:*
1) run and it must connect to echo server - logs show it
2) write "something" and press send - see reaction in logs - all good
3) switch off WiFi on iOS
4) wait reaction in logs...
**Logs**
*on iOS after switching WiFi provider nothing happens*
```
17:24:46.693459 connect to ws://echo.websocket.org requested
17:24:49.312085 connect successfully established
17:25:07.964240 Sended р
17:25:08.282754 ws.listen received = р
// --- WIFI SWITCHED OFF---
// you can wait forever, nothing will happen
```
If you do the same on android, close event emitted to both done listeners:
*on Android after switching off WiFi provider everything works as it should*
```
17:29:08.166856 connect to ws://echo.websocket.org requested
17:29:12.425252 connect successfully established
17:29:39.879199 sended y
17:29:40.267743 ws.listen received = y
// --- WIFI SWITCHED OFF---
17:29:44.711755 ws.listen.onDone called
17:29:44.770376 ws.done.then with details:
closecode 1002 closeReason null readyState 1
```
PS. Why readyState is 1? (open) Is another story and another issue... [dart/sdk issue](https://github.com/dart-lang/sdk/issues/33362)
This behaviour is reproduced in stable channel
```
Flutter 1.5.4-hotfix.2 • channel stable • https://github.com/flutter/flutter.git
Framework • revision 7a4c33425d (9 weeks ago) • 2019-04-29 11:05:24 -0700
Engine • revision 52c7a1e849
Tools • Dart 2.3.0 (build 2.3.0-dev.0.5 a1668566e5)
[✓] Flutter (Channel stable, v1.5.4-hotfix.2, on Mac OS X 10.14.5 18F203, locale en-RU)
[✓] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
[✓] iOS toolchain - develop for iOS devices (Xcode 10.2.1)
[✓] Android Studio (version 3.4)
[✓] IntelliJ IDEA Ultimate Edition (version 2019.1.3)
[✓] Connected device (3 available)
```
And reproduced in master channel too
```
Flutter 1.7.11-pre.45 • channel master • https://github.com/flutter/flutter.git
Framework • revision bbbd240635 (83 minutes ago) • 2019-06-28 04:41:55 -0400
Engine • revision 4aaa1a9488
Tools • Dart 2.4.0
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel master, v1.7.11-pre.45, on Mac OS X 10.14.5 18F203, locale en-RU)
[✓] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
[✓] Xcode - develop for iOS and macOS (Xcode 10.2.1)
[✓] iOS tools - develop for iOS devices
[✓] Chrome - develop for the web
[✓] Android Studio (version 3.4)
[✓] IntelliJ IDEA Ultimate Edition (version 2019.1.3)
[✓] Connected device (5 available)
``` | platform-ios,engine,dependency: dart,has reproducible steps,P3,dependency: dart:io,found in release: 3.3,found in release: 3.7,team-ios,triaged-ios | medium | Major |
462,092,860 | scrcpy | [feature] Add version number | **Suggestion:**
Show the version number in the title bar (the title bar seems like the best option, but somewhere else could also work).
**Why?**
Currently there is no (easy) way to see the version number using the GUI only. Adding it in the title bar would be could be very handy to check if you're on the latest version. | feature request | low | Minor |
462,113,802 | electron | Implement BrowserWindow.setFocusable on Linux | <!-- As an open source project with a dedicated but small maintainer team, it can sometimes take a long time for issues to be addressed so please be patient and we will get back to you as soon as we can.
-->
### Preflight Checklist
<!-- Please ensure you've completed the following steps by replacing [ ] with [x]-->
* [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [x] I have searched the issue tracker for a feature request that matches the one I want to file, without success.
### Problem Description
Currently BrowserWindow.setFocusable is only implemented on Windows. But not on Mac despite the focusable option being available on all platforms.
### Proposed Solution
I have a patch that implements it on Mac. I can take a look to Linux later.
### Alternatives Considered
None
| enhancement :sparkles: | low | Minor |
462,118,330 | pytorch | New Weight Scheduler Concept for Weight Decay | ## 🚀 Feature
Weight decay is used very often. A common strategy is to implicitly use the learning rate scheduler todo so, or to simply shrinking the weights at the end of each iteration by a constant multiplicative factor. However, one could expect to use strategies different from this. In that case, we could have weight schedulers that modify the weights using a syntax and grammar similar to learning rate schedulers already available.
## Motivation
The AdamW code from #21250 does not include the weight scheduler, as mentioned [here](https://github.com/pytorch/pytorch/pull/4429#issuecomment-508951336).
There are also currently a few issues and pull requests about weight schedulers, see below.
## Alternatives
* #4429 suggests modifying the optimizer logic to accept a new parameter `weight_decay` specifying the constant multiplicative factor to use.
* #3740, #21250, #22163 introduce variations on Adam and other optimizers with a corresponding built-in weight decay. #3790 is requesting some of these to be supported.
* We could instead have a new "weight_decay_type" option to those optimizers to switch between common strategies. | feature,module: optimizer,triaged | low | Major |
462,136,392 | terminal | Mouse panning (middle-button scrolling) | # Summary of the new feature/enhancement
Introduce scrolling with middle mouse button, common to browsers/text editors and also available in conhost.
Currently middle mouse button is not used (right?) but there are requests to use it to paste text, so there needs to be a settings for that.
# Proposed technical implementation details (optional)
PR #1523 introduces mechanism to implement scrolling, cursor image has to be replaced with appropriate images. | Help Wanted,Area-Input,Area-TerminalControl,Product-Terminal,Issue-Task,good first issue | low | Major |
462,145,806 | rust | Unable to emit llvm-bc when CARGO_INCREMENTAL is set | When building with the rustc argument to emit an llvm bc file
```cargo rustc -v -- --emit llvm-bc```
Cargo builds successfully but prints the warning
```warning: ignoring emit path because multiple .bc files were produced```
Doing a recursive search for all *.bc files from root, I can see that the bc file I'm wanting was not generated, but there are a lot of bc files in ```./target/debug/incremental/```.
So I turned off incremental building ```export CARGO_INCREMENTAL=0``` and cleared the target directory, then ran the build command again. This time the correct bc file is generated in ```./target/debug/deps``` | T-compiler,A-incr-comp | low | Critical |
462,204,312 | create-react-app | Can not start app using grpc web due to incorrect eslint errors | <!--
Please note that your issue will be fixed much faster if you spend about
half an hour preparing it, including the exact reproduction steps and a demo.
If you're in a hurry or don't feel confident, it's fine to report bugs with
less details, but this makes it less likely they'll get fixed soon.
In either case, please use this template and fill in as many fields below as you can.
Note that we don't provide help for webpack questions after ejecting.
You can find webpack docs at https://webpack.js.org/.
-->
### Desribe the bug
I am creating a react app with grpc-web: https://github.com/grpc/grpc-web
Following the steps described here https://github.com/grpc/grpc-web#how-it-works it generates code for you from the .proto files. If one has a helloworld.proto it would generate a `helloworld_pb.js` file. The file it generates confuses eslint and throws a bunch of `no-undef` errors which fails the build. If I manually add `/* eslint disable no-undef */` to the generated file the App works as expected with grpc-web
Here is the generated file that is causing issues for me: https://gist.github.com/Globegitter/c53de0ba359cea1b2cc7c7cdfb0ac491
I do not want to add the eslint comment there because the file can be regenerated at any time and it also tells you to not manually edit the file.
### Did you try recovering your dependencies?
Yep
### Which terms did you search for in User Guide?
lint
eslint
### Environment
Environment Info:
System:
OS: Linux 4.15 elementary OS 5.0 Juno (Ubuntu 18.04)
CPU: (8) x64 Intel(R) Core(TM) i7-7700HQ CPU @ 2.80GHz
Binaries:
Node: 10.16.0 - /usr/bin/node
Yarn: 1.16.0 - /usr/bin/yarn
npm: 6.9.0 - /usr/bin/npm
Browsers:
Chrome: 75.0.3770.100
Firefox: Not Found
npmPackages:
react: ^16.8.6 => 16.8.6
react-dom: ^16.8.6 => 16.8.6
react-scripts: 3.0.1 => 3.0.1
npmGlobalPackages:
create-react-app: Not Found
### Steps to reproduce
1. Write any react app that imports the file linked in the gist e.g. `import {HelloReply, HelloRequest} from './helloworld_pb';`
2. You can make use of this, instantiate the class etc.
3. See the compilation issue thrown by eslint
4. Add the eslint disable command and see that all works fine as expected
Note: I am using react with typescript here btw, but don't think that makes any difference here.
### Expected behavior
Give me some way to ignore specific files/directories from being linted, or give me an option turn errors into warnings so I can choose to ignore false positives.
### Actual behavior
### Reproducible demo
https://github.com/Globegitter/react-grpc-web | issue: bug | low | Critical |
462,208,322 | go | cmd/go: 'go list -export' doesn't report export data file path when GOROOT is wrong | cc @jayconrod
<pre>
$ go version
go version go1.12 darwin/amd64
</pre>
### Does this issue reproduce with the latest release?
yes
### What operating system and processor architecture are you using (`go env`)?
<details><summary><code>go env</code> Output</summary><br><pre>
$ go env
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/matloob/Library/Caches/go-build"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
GOPATH="/Users/matloob/go"
GOPROXY=""
GORACE=""
GOROOT="/usr/local/go"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/darwin_amd64"
GCCGO="gccgo"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD="/Users/matloob/tools/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/f4/9p58ddnj40x58zchdb36p7lr004_sl/T/go-build504723835=/tmp/go-build -gno-record-gcc-switches -fno-common"
</pre></details>
### What did you do?
I did a `go list` with a GOROOT set to a different Go installations's goroot.
I have Go 1.12 installed in /usr/local/go/bin/go, and something tip-ish installed in $HOME/devgo
if I do a normal `go list -export` of a stdlib package, exports show up fine:
```
matloob-macbookpro2:tools matloob$ /usr/local/go/bin/go list -export -f "{{.Export}}" fmt
/usr/local/go/pkg/darwin_amd64/fmt.a
```
On the other hand running go list with GOROOT set to a different go installation's goroot, the export data is missing:
```
matloob-macbookpro2:tools matloob$ GOROOT=$HOME/devgo /usr/local/go/bin/go list -export -e -json -f "{{.Export}}" fmt
# math/bits
compile: version "devel +6d1aaf143c Tue Jun 25 21:47:04 2019 +0000" does not match go tool version "go1.12"
# unicode/utf8
compile: version "devel +6d1aaf143c Tue Jun 25 21:47:04 2019 +0000" does not match go tool version "go1.12"
# internal/race
compile: version "devel +6d1aaf143c Tue Jun 25 21:47:04 2019 +0000" does not match go tool version "go1.12"
# runtime/internal/sys
compile: version "devel +6d1aaf143c Tue Jun 25 21:47:04 2019 +0000" does not match go tool version "go1.12"
# unicode
compile: version "devel +6d1aaf143c Tue Jun 25 21:47:04 2019 +0000" does not match go tool version "go1.12"
# sync/atomic
compile: version "devel +6d1aaf143c Tue Jun 25 21:47:04 2019 +0000" does not match go tool version "go1.12"
# internal/cpu
compile: version "devel +6d1aaf143c Tue Jun 25 21:47:04 2019 +0000" does not match go tool version "go1.12"
# runtime/internal/atomic
compile: version "devel +6d1aaf143c Tue Jun 25 21:47:04 2019 +0000" does not match go tool version "go1.12"
matloob-macbookpro2:tools matloob$ echo $?
2
```
And the exit status is 2 so at least we know something's wrong.
But it's worse if we do a list -e. The same "warnings" are printed, but the exit status is 0 and an error isn't set on the package
```
matloob-macbookpro2:tools matloob$ GOROOT=$HOME/devgo /usr/local/go/bin/go list -export -e -json fmt
# internal/race
compile: version "devel +6d1aaf143c Tue Jun 25 21:47:04 2019 +0000" does not match go tool version "go1.12"
# math/bits
compile: version "devel +6d1aaf143c Tue Jun 25 21:47:04 2019 +0000" does not match go tool version "go1.12"
# unicode/utf8
compile: version "devel +6d1aaf143c Tue Jun 25 21:47:04 2019 +0000" does not match go tool version "go1.12"
# unicode
compile: version "devel +6d1aaf143c Tue Jun 25 21:47:04 2019 +0000" does not match go tool version "go1.12"
# runtime/internal/sys
compile: version "devel +6d1aaf143c Tue Jun 25 21:47:04 2019 +0000" does not match go tool version "go1.12"
# sync/atomic
compile: version "devel +6d1aaf143c Tue Jun 25 21:47:04 2019 +0000" does not match go tool version "go1.12"
# internal/cpu
compile: version "devel +6d1aaf143c Tue Jun 25 21:47:04 2019 +0000" does not match go tool version "go1.12"
# runtime/internal/atomic
compile: version "devel +6d1aaf143c Tue Jun 25 21:47:04 2019 +0000" does not match go tool version "go1.12"
{
"Dir": "/Users/matloob/devgo/src/fmt",
"ImportPath": "fmt",
"Name": "fmt",
"Doc": "Package fmt implements formatted I/O with functions analogous to C's printf and scanf.",
"Target": "/Users/matloob/devgo/pkg/darwin_amd64/fmt.a",
"Root": "/Users/matloob/devgo",
"Match": [
"fmt"
],
"Goroot": true,
"Standard": true,
"GoFiles": [
"doc.go",
"errors.go",
"format.go",
"print.go",
"scan.go"
],
"Imports": [
"errors",
"internal/fmtsort",
"io",
"math",
"os",
"reflect",
"strconv",
"sync",
"unicode/utf8"
],
"Deps": [
"errors",
"internal/bytealg",
"internal/cpu",
"internal/fmtsort",
"internal/oserror",
"internal/poll",
"internal/race",
"internal/reflectlite",
"internal/syscall/unix",
"internal/testlog",
"io",
"math",
"math/bits",
"os",
"reflect",
"runtime",
"runtime/internal/atomic",
"runtime/internal/math",
"runtime/internal/sys",
"sort",
"strconv",
"sync",
"sync/atomic",
"syscall",
"time",
"unicode",
"unicode/utf8",
"unsafe"
],
"TestGoFiles": [
"export_test.go"
],
"XTestGoFiles": [
"errors_test.go",
"example_test.go",
"fmt_test.go",
"gostringer_example_test.go",
"scan_test.go",
"stringer_example_test.go",
"stringer_test.go"
],
"XTestImports": [
"bufio",
"bytes",
"errors",
"fmt",
"internal/race",
"io",
"math",
"os",
"reflect",
"regexp",
"runtime",
"strings",
"testing",
"testing/iotest",
"time",
"unicode",
"unicode/utf8"
]
}
```
### What did you expect to see?
The ideal situation is that the value GOROOT is ignored. The go command already knows its own GOROOT, and using a different one will break things.
At the least, if go list is going to fail, it should have an error set.
### What did you see instead?
go list -e -json -export succeeds, but has no export data present. | NeedsFix,GoCommand | low | Critical |
462,225,880 | go | cmd/compile: -m output is missing escape information | In #32670 we are considering a new API for golang.org/x/crypto/curve25519. One of the changes I'd like to introduce is not to require the caller to pre-allocate the destination. OTOH, I'd like not to introduce a heap allocation in the process.
I was hoping to be able to use the inliner to inline the variable declaration in the caller, where it has a chance not to escape. I used `-gcflags -m` to verify if it would work.
```
package main
import (
"crypto/subtle"
"errors"
"golang.org/x/crypto/curve25519"
)
func main() {
scalar, point := make([]byte, 32), make([]byte, 32)
res, err := X25519(scalar, point)
if err != nil {
panic(err)
}
println(res)
}
func X25519(scalar, point []byte) ([]byte, error) {
var dst [32]byte
return x25519(&dst, scalar, point)
}
func x25519(dst *[32]byte, scalar, point []byte) ([]byte, error) {
var in, base, zero [32]byte
copy(in[:], scalar)
copy(base[:], point)
curve25519.ScalarMult(dst, &in, &base)
if subtle.ConstantTimeCompare(dst[:], zero[:]) == 1 {
return nil, errors.New("bad input")
}
return dst[:], nil
}
```
In Go 1.12.6 this works as intended. Note `main &dst does not escape`.
```
# play
./inline.go:28:23: inlining call to curve25519.ScalarMult
./inline.go:30:25: inlining call to errors.New
./inline.go:19:6: can inline X25519
./inline.go:12:20: inlining call to X25519
/var/folders/df/mrk3bfz149n8zb5h5p1vp_1m00hbbm/T/go-build156101582/b001/_gomod_.go:6:6: can inline init.0
./inline.go:30:25: error(&errors.errorString literal) escapes to heap
./inline.go:30:25: &errors.errorString literal escapes to heap
./inline.go:24:13: leaking param: dst to result ~r3 level=0
./inline.go:24:28: x25519 scalar does not escape
./inline.go:24:36: x25519 point does not escape
./inline.go:26:9: x25519 in does not escape
./inline.go:27:11: x25519 base does not escape
./inline.go:28:29: x25519 &in does not escape
./inline.go:28:34: x25519 &base does not escape
./inline.go:29:44: x25519 zero does not escape
./inline.go:11:23: main make([]byte, 32) does not escape
./inline.go:11:41: main make([]byte, 32) does not escape
./inline.go:12:20: main &dst does not escape
./inline.go:21:16: &dst escapes to heap
./inline.go:20:6: moved to heap: dst
./inline.go:19:13: X25519 scalar does not escape
./inline.go:19:21: X25519 point does not escape
```
In Go +2f387ac1f3, however, a lot of information is missing from the output. Note that the `&dst escapes to heap` and `main &dst does not escape` lines are gone, along with others.
```
# play
./inline.go:28:23: inlining call to curve25519.ScalarMult
./inline.go:30:25: inlining call to errors.New
./inline.go:19:6: can inline X25519
./inline.go:12:20: inlining call to X25519
./inline.go:24:13: leaking param: dst to result ~r3 level=0
./inline.go:24:28: x25519 scalar does not escape
./inline.go:24:36: x25519 point does not escape
./inline.go:30:25: error(&errors.errorString literal) escapes to heap
./inline.go:30:25: &errors.errorString literal escapes to heap
./inline.go:11:23: main make([]byte, 32) does not escape
./inline.go:11:41: main make([]byte, 32) does not escape
./inline.go:19:13: X25519 scalar does not escape
./inline.go:19:21: X25519 point does not escape
./inline.go:20:6: moved to heap: dst
```
Looking at the SSA it seems the inlined value still doesn't escape, but it's impossible to tell from the `-gcflags -m` output now.
Marking as release-blocker to look into as a regression.
/cc @mdempsky | NeedsInvestigation | medium | Critical |
462,229,774 | TypeScript | Auto import suggestions heavily slows intellisense | **TypeScript Version:** 3.6.0-dev.20190628
**Search Terms:** `auto import` `auto import performance`
**Code**
Enter this into a blank TypeScript project in VSCode:
```ts
import {S3} from 'aws-sdk'
const a: s
```
**Expected behavior:**
Intellisense suggestions to pop up in under 500ms.
**Actual behavior:**
2+ seconds for the suggestions to appear.
After banging my head for a few hours trying to get to the bottom of intellisense slowness(next, insiders, old versions, etc, etc) I narrowed this down to auto import suggestions; disabling this feature removes the delay. I _believe_ tsserver provides this service to VSCode? The aws-sdk does have a huge type surface area.. | Bug | low | Major |
462,233,884 | pytorch | When I run python setup.py install to install Caffe2, I have an error: "No such file or directory: 'nvcc': 'nvcc'" | I can't seem to figure out how to include nvcc as a directory. Obviously I have downloaded CUDA and have CuDNN running too. Can someone please help me? Thank you so much. (I am working on a Mac)
| caffe2,triaged | low | Critical |
462,251,726 | rust | Can't use `impl Fn` to return a closure that returns another closure | While trying to write some currying code using stable (1.35.0), writing a `fn` that returns `impl Fn(T1) -> impl Fn(T2) -> T3` results in a compile error. E.g.
```rust
fn foo(a: i64, b: bool, c: f64) {
println!("{:?} {:?} {:?}", a, b, c)
}
fn foo2(a: i64, b: bool) -> impl Fn(f64) -> () { move |c: f64| foo(a,b,c) }
fn foo1(a: i64) -> impl Fn(bool) -> impl Fn(f64) -> () { move |b: bool| foo2(a,b) }
fn main() {
foo1(1)(true)(2.5);
}
```
results in
```
error[E0562]: `impl Trait` not allowed outside of function and inherent method return types
--> src/main.rs:7:37
|
7 | fn foo1(a: i64) -> impl Fn(bool) -> impl Fn(f64) -> () { move |b: bool| foo2(a,b) }
| ^^^^^^^^^^^^^^^^^^
error: aborting due to previous error
```
The expectation was that this would be allowed as the `impl Fn(f64) -> ()` is part of the function return type of `foo1`. | C-enhancement,A-closures,T-lang,A-impl-trait | low | Critical |
462,264,927 | terminal | Windows Store install fails when default app save location not set to C: | When default new app save location was set to D:, WT would download and attempt to install but then fail with a non-specific error (sorry no screenshot but should be repeatable). Changing the default app save location to C: allowed it to install.
There are a pair of Event Logs describing the event:
```
Fault bucket 1222364994692753289, type 5
Event Name: AppxDeploymentFailureBlue
Response: Not available
Cab Id: 0
Problem signature:
P1: 80073D13
P2: 5
P3: 0
P4: NONE
P5: 10.0.18362.175
P6: 765
P7:
P8:
P9:
P10:
Attached files:
[large number of log paths redacted]
These files may be available here:
\\?\C:\ProgramData\Microsoft\Windows\WER\ReportArchive\NonCritical_80073D13_e3ddba5cc7432f8eac6ff587b7cea67b50cc29f4_00000000_614f2c6e-6497-4c50-998f-0bf772615a9e
Analysis symbol:
Rechecking for solution: 0
Report Id: 614f2c6e-6497-4c50-998f-0bf772615a9e
Report Status: 268435456
Hashed bucket: b966d53c8a39f29fd0f6b67c7e88a789
Cab Guid: 0
```
and
```
Fault bucket 1439638532761225254, type 5
Event Name: StoreAgentDownloadFailure1
Response: Not available
Cab Id: 0
Problem signature:
P1: Acquisition;PTIClient
P2: 80073d13
P3: 18362
P4: 175
P5: Windows.Desktop
P6: 1
P7:
P8:
P9:
P10:
Attached files:
\\?\C:\ProgramData\Microsoft\Windows\WER\Temp\WER195D.tmp.WERInternalMetadata.xml
These files may be available here:
\\?\C:\ProgramData\Microsoft\Windows\WER\ReportArchive\NonCritical_Acquisition;PTIC_2431d4c27ca3d41ba382d17ec8f30eadeab812e_00000000_fd9920f6-19ed-4ead-b665-b667864e43cc
Analysis symbol:
Rechecking for solution: 0
Report Id: fd9920f6-19ed-4ead-b665-b667864e43cc
Report Status: 2147487744
Hashed bucket: 8ef9d1b328f66c23c3fa9f9e36328826
Cab Guid: 0
``` | Resolution-External,Product-Terminal,Needs-Tag-Fix | low | Critical |
462,280,166 | flutter | Please add resource map like Android's R.class in Flutter | ### Please add resource map like Android's R.class in Flutter
create Asserts map to mapping assert like image string file...
| c: new feature,framework,P3,team-framework,triaged-framework | low | Minor |
462,295,358 | pytorch | returned non-zero exit status 2. | I compile pytorch1.1 with TX2(python3.7)
I follow the steps:
1.git clone --recursive https://github.com/pytorch/pytorc
2.cd pytorch
3.git submodule syn
4.git submodule update --init --recursiv
5.python3.7 setup.py install
this is error messages:
nvlink error : entry function '_Z32ncclAllReduceRingLLKernel_sum_u88ncclColl' with max regcount of 80 calls function '_Z29ncclReduceScatterRing_max_f64P14CollectiveArgs' with regcount of 96
nvlink error : entry function '_Z32ncclAllReduceTreeLLKernel_sum_i88ncclColl' with max regcount of 80 calls function '_Z29ncclReduceScatterRing_max_f64P14CollectiveArgs' with regcount of 96
nvlink error : entry function '_Z32ncclAllReduceRingLLKernel_sum_i88ncclColl' with max regcount of 80 calls function '_Z29ncclReduceScatterRing_max_f64P14CollectiveArgs' with regcount of 96
Makefile:68: recipe for target '/home/nvidia/tools/pytorch/build/nccl/obj/collectives/device/devlink.o' failed
make[5]: *** [/home/nvidia/tools/pytorch/build/nccl/obj/collectives/device/devlink.o] Error 255
Makefile:44: recipe for target '/home/nvidia/tools/pytorch/build/nccl/obj/collectives/device/colldevice.a' failed
make[4]: *** [/home/nvidia/tools/pytorch/build/nccl/obj/collectives/device/colldevice.a] Error 2
Makefile:25: recipe for target 'src.build' failed
make[3]: *** [src.build] Error 2
CMakeFiles/nccl_external.dir/build.make:110: recipe for target 'nccl_external-prefix/src/nccl_external-stamp/nccl_external-build' failed
make[2]: *** [nccl_external-prefix/src/nccl_external-stamp/nccl_external-build] Error 2
CMakeFiles/Makefile2:67: recipe for target 'CMakeFiles/nccl_external.dir/all' failed
make[1]: *** [CMakeFiles/nccl_external.dir/all] Error 2
Makefile:138: recipe for target 'all' failed
make: *** [all] Error 2
Traceback (most recent call last):
File "setup.py", line 753, in <module>
build_deps()
File "setup.py", line 327, in build_deps
cmake=cmake)
File "/home/nvidia/tools/pytorch/tools/build_pytorch_libs.py", line 64, in build_caffe2
cmake.build(my_env)
File "/home/nvidia/tools/pytorch/tools/setup_helpers/cmake.py", line 354, in build
self.run(build_args, my_env)
File "/home/nvidia/tools/pytorch/tools/setup_helpers/cmake.py", line 110, in run
check_call(command, cwd=self.build_dir, env=env)
File "/usr/local/lib/python3.7/subprocess.py", line 341, in check_call
raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['cmake', '--build', '.', '--target', 'install', '--config', 'Release', '--', '-j', '6']' returned non-zero exit status 2.
root@tegra-ubuntu:pytorch# echo $?
1
thanks | module: build,triaged | low | Critical |
462,303,346 | godot | Polygons With Bones and Lighting | When you bind a polygon to a bone (Polygon dots are white or gray in the Polygon's bone tab), lighting doesn't affect the polygon. | bug,topic:rendering | low | Major |
462,309,380 | flutter | [google_maps] Allow a `Marker` to be auto selected. | I am looking for way to send list of `Marker`'s to the `GoogleMap` widget where one of the markers would be auto-selected on next draw.
That would allow me to control selection and focus on map's `Marker` from outside of `GoogleMap` widget, for example from list on side drawer, etc.
## Use case
In tablet app, user have list of locations on left side of screen and selection of the item in list would show all markers from list with single one being selected.
That selection of item on `GoogleMap` leads to showing navigation and open in google maps bar on bottom left right:
Currently on user's tapping on marker shows that toolbar on bottom right.
## Proposal
There is couple possibilities to do this:
1. Special property on `GoogleMap` - `selectedMarker: myMarker` that would select the marker.
2. Special boolean property on `Marker` class would read `selected` = true/false. That would indicate which on in `markers:` `List<Marker>` should be selected.
3. Method on `GoogleMapController` to manage `Marker` and their state or selection.
| c: new feature,customer: crowd,p: maps,package,c: proposal,team-ecosystem,P3,triaged-ecosystem | low | Minor |
462,339,749 | flutter | Google Play Pre-Launch Report cannot control Flutter PageView | First of all, I am facing this issue when uploading my Flutter app in Google Play and the automatic Pre-Launch Report tries to "test" my app.
The problem is that I have a First-Start Tutorial based on a Pager that is shown automatically at application startup. And it seems that the Pre-Launch Report cannot control the Flutter Pager because it just stays stuck at this screen.
## Steps to Reproduce
1. Have a flutter application that shows a PageView at startup
2. Upload Application Release to Google Play so that the Pre-Launch Report gets started
3. Check the Pre-Launch Report once it's finished
## Logs
Not present from Google Play Pre-Launch Report
There are also errors reported like this for all the tested devices:
Object Label:
Element Path android:id/content/FlutterView[0]
This object may not have a label that can be used for reading.
Are Flutter applications supported in Google Play Pre-Launch at all at the moment? I found this related issue but it does not have a definite answer: #31670 | a: tests,platform-android,framework,a: release,P3,team-android,triaged-android | medium | Critical |
462,346,669 | TypeScript | Non-exported classes in type declaration files leaking value names | **TypeScript Version:** 3.5.2
**Search Terms:** ambient module declaration export declare class type name
**Code**
In a file called `classes.d.ts`:
```ts
declare class A {}
export declare class B extends A {}
```
In a file called `test.js`:
```js
let a = require('classes').A;
```
In a file called `test.ts`:
```ts
import { A } from './types/classes';
```
**_[NEW]_ Assumptions:**
The following is a list of assumptions I had when originally opening this issue:
1. Type Declaration Files work like modules: once you use `import` or `export` [on a top-level declaration], only explicitly `export`ed declarations are visible externally.
1. Type names declared in a Declaration File are always accessible via `import` types (at least those that are _used_ by `export`ed types.
- E.g. `export class B extends A` exports the type names `A` and `B`, even if `A` was not directly `export`ed.
1. Value names declared in a module-style Declaration File (see `#1` above) are only accessible if explicitly `export`ed.
These assumptions are the result of reading the [documentation](https://www.typescriptlang.org/docs/handbook/declaration-files/deep-dive.html) and working with declaration files. Note that the documentation **_does not_** mention:
1. _All_ declarations in a declaration file are [implicitly exported](https://github.com/microsoft/TypeScript/issues/32182#issuecomment-507006868).
1. Special [and undocumented?] `export {};` syntax causes only explicitly `export`ed declarations to be available by consumers of the declaration file.
I list them here to provide context for the Expected Behavior section.
**Expected behavior:**
In both cases , an Error that name 'A' could be found in module 'classes'.
I expect in this case that TypeScript is capable of resolving the following from the declaration file:
1. The [**Value**](https://www.typescriptlang.org/docs/handbook/declaration-files/deep-dive.html#values) "B".
1. The [**Types**](https://www.typescriptlang.org/docs/handbook/declaration-files/deep-dive.html#types) "A" and "B".
In other words, I should be able to use `import` types to resolve class A, but attempts to _use_ them should fail.
**Actual behavior:**
No compiler error in either case. TypeScript-powered IDEs (e.g. VSCode) happily show that the _full_ non-exported `class A` is available.
In short, a non-exported, declared class should resolve in the same way as an `interface`.
As things stand today, TypeScript erroneously resolves the **Value** "A".
**Playground Link:** NA
**Related Issues:** NA
| Docs | low | Critical |
462,346,693 | pytorch | Label.dim Enforcement Check in AccuracyOp | ## 🐛 Bug
<!-- A clear and concise description of what the bug is. -->
## To Reproduce
Steps to reproduce the behavior:
1. Run CNN, with label.dim() = 2 && label.dim32(1) = 1
<!-- If you have a code sample, error messages, stack traces, please provide it here as well -->
## Expected behavior
<!-- A clear and concise description of what you expected to happen. -->
AccuracyOp.RunOnDevice() should accept "label" tensor with ((dim == 2) && (dim32(1) == 1)) as LabelCrossEntropyOp.RunOnDevice() does.
## Environment
$ python ./collect_env.py
Collecting environment information...
PyTorch version: N/A
Is debug build: N/A
CUDA used to build PyTorch: N/A
OS: Fedora release 27 (Twenty Seven)
GCC version: (GCC) 7.3.1 20180712 (Red Hat 7.3.1-6)
CMake version: version 3.11.2
Python version: 2.7
Is CUDA available: N/A
CUDA runtime version: Could not collect
GPU models and configuration: Could not collect
Nvidia driver version: Could not collect
cuDNN version: Could not collect
Versions of relevant libraries:
[pip] numpy==1.13.3
[pip] torch==1.0.0a0+6ca1d93
[conda] Could not collect
Please copy and paste the output from our
[environment collection script](https://raw.githubusercontent.com/pytorch/pytorch/master/torch/utils/collect_env.py)
(or fill out the checklist below manually).
You can get the script and run it with:
```
wget https://raw.githubusercontent.com/pytorch/pytorch/master/torch/utils/collect_env.py
# For security purposes, please check the contents of collect_env.py before running it.
python collect_env.py
```
- PyTorch Version (e.g., 1.0): caffe2
- OS (e.g., Linux):
- How you installed PyTorch (`conda`, `pip`, source):
- Build command you used (if compiling from source): source
- Python version:2.7
- CUDA/cuDNN version: None
- GPU models and configuration: None
- Any other relevant information:
## Additional context
<!-- Add any other context about the problem here. -->
| caffe2,triaged | low | Critical |
462,347,010 | godot | Animation resources as references aren't clarified well by the editor at design time | **Godot version:**
3.1.1
**Issue description:**
When instancing a scene which inherits from a scene with an `AnimationPlayer`, any changes to animations and animation tracks will affect **all** instances, including deleting animations. This also applies to copied-and-pasted animations and tracks across disparate scenes.
This referencing behavior may be considered unexpected to users, as the default behavior of other node properties is typically local-but-inherited and the `Animation`s' appearance as a reference is obfuscated from the inspector view without explicitly opening it from the animation tab. This behavior also occurs when copying and pasting animations across non-inherited scenes, including the deletion of whole `Animation`s and tracks.
I was meaning to post an issue about this a few months ago when I accidentally nuked a few animations in a game jam due to the byRef copy-paste behavior, but this behavior also occurs on testing with inherited scenes.
Possible workaround: Open each animation in the base scene's AnimationPlayer and set its local_to_scene value to true. This workaround has been untested with copy-pasted animations. | enhancement,topic:editor,confirmed,usability,topic:animation | medium | Major |
462,349,344 | flutter | [Web] RawKeyboardListener does not return correct data | ## Steps to Reproduce
<!--
Please tell us exactly how to reproduce the problem you are running into.
Please attach a small application (ideally just one main.dart file) that
reproduces the problem. You could use https://gist.github.com/ for this.
If the problem is with your application's rendering, then please attach
a screenshot and explain what the problem is.
-->
Gist of code to reproduce the problem:
https://gist.github.com/mjeffw/8f3f57d23b596fde3c1a8dac93a64549
1. Create a flutter web app with a TextField wrapped by a RawKeyboardListener
2. In the onKey callback, check for a specific key using the following code: `if (value.logicalKey == LogicalKeyboardKey.keyA) print('A');`
3. Run the web app and type the expected key. It never matches.
If I print the logicalKey value of the RawKeyEvent, and type the letter 'A', here is the output:
```
dart_sdk.js:18740 LogicalKeyboardKey#00039(keyId: "0x00000039", keyLabel: "9", debugName: "Digit 9")
dart_sdk.js:18740 LogicalKeyboardKey#f1dc1(keyId: "0x1000c018a", keyLabel: null, debugName: "Launch Mail")
dart_sdk.js:18740 LogicalKeyboardKey#f1dc1(keyId: "0x1000c018a", keyLabel: null, debugName: "Launch Mail")
dart_sdk.js:18740 LogicalKeyboardKey#00039(keyId: "0x00000039", keyLabel: "9", debugName: "Digit 9")
```
## Logs
<!--
Run your application with `flutter run --verbose` and attach all the
log output below between the lines with the backticks. If there is an
exception, please see if the error message includes enough information
to explain how to solve the issue.
-->
```
Jeffs-MacBook-Pro-2:flutter_web_rawkeyboardlistener_example jeff$ webdev serve --verbose
[INFO] Connecting to the build daemon...
[INFO] Generating build script...
[INFO] Generating build script completed, took 401ms
[INFO]
[INFO] Starting daemon...
[INFO]BuildDefinition: Initializing inputs
[INFO]BuildDefinition: Reading cached asset graph...
[WARNING]BuildDefinition: Throwing away cached asset graph due to Dart SDK update.
[INFO]BuildDefinition: Cleaning up outputs from previous builds....
[INFO]BuildDefinition: Cleaning up outputs from previous builds. completed, took 136ms
[INFO] Generating build script...
[INFO] Generating build script completed, took 109ms
[INFO]
[INFO] Creating build script snapshot......
[INFO] Creating build script snapshot... completed, took 12.4s
[INFO]
[INFO] Starting daemon...
[INFO]BuildDefinition: Initializing inputs
[INFO]BuildDefinition: Building new asset graph...
[INFO]BuildDefinition: Building new asset graph completed, took 1.5s
[INFO]BuildDefinition: Checking for unexpected pre-existing outputs....
[INFO]BuildDefinition: Checking for unexpected pre-existing outputs. completed, took 2ms
[INFO] Initializing inputs
[INFO] Building new asset graph...
[INFO] Building new asset graph completed, took 1.5s
[INFO]
[INFO] Checking for unexpected pre-existing outputs....
[INFO] Checking for unexpected pre-existing outputs. completed, took 2ms
[INFO]
[INFO] Setting up file watchers...
[INFO] Setting up file watchers completed, took 4ms
[INFO]
[INFO] Registering build targets...
[INFO] Starting initial build...
[INFO] Starting resource servers...
[INFO] Serving `web` on http://127.0.0.1:8080
[INFO] About to build [web]...
[INFO]Build: Running build...
[INFO]Heartbeat: 1.0s elapsed, 89/108 actions completed.
[INFO]Heartbeat: 2.0s elapsed, 285/303 actions completed.
[INFO]Heartbeat: 3.1s elapsed, 517/537 actions completed.
[INFO]Heartbeat: 4.2s elapsed, 694/726 actions completed.
[INFO]Heartbeat: 5.3s elapsed, 694/726 actions completed.
[INFO]Heartbeat: 6.4s elapsed, 705/741 actions completed.
[INFO]Heartbeat: 7.4s elapsed, 716/750 actions completed.
[INFO]Heartbeat: 8.5s elapsed, 720/752 actions completed.
[INFO]Heartbeat: 9.5s elapsed, 722/752 actions completed.
[INFO]Heartbeat: 10.6s elapsed, 726/754 actions completed.
[INFO]Heartbeat: 11.6s elapsed, 731/754 actions completed.
[INFO]Heartbeat: 12.7s elapsed, 734/754 actions completed.
[INFO]Heartbeat: 13.8s elapsed, 737/754 actions completed.
[INFO]Heartbeat: 14.8s elapsed, 739/754 actions completed.
[INFO]Heartbeat: 15.8s elapsed, 740/754 actions completed.
[INFO]Heartbeat: 16.9s elapsed, 740/754 actions completed.
[INFO]Heartbeat: 17.9s elapsed, 742/754 actions completed.
[INFO]Heartbeat: 18.9s elapsed, 743/754 actions completed.
[INFO]Heartbeat: 20.0s elapsed, 744/754 actions completed.
[INFO]Heartbeat: 21.0s elapsed, 745/754 actions completed.
[INFO]Heartbeat: 22.1s elapsed, 748/754 actions completed.
[INFO]Heartbeat: 23.1s elapsed, 750/754 actions completed.
[INFO]Heartbeat: 24.2s elapsed, 750/754 actions completed.
[INFO]Heartbeat: 25.3s elapsed, 752/754 actions completed.
[INFO]Heartbeat: 26.3s elapsed, 752/754 actions completed.
[INFO]Heartbeat: 27.4s elapsed, 752/754 actions completed.
[INFO]Heartbeat: 28.4s elapsed, 752/754 actions completed.
[INFO]Heartbeat: 29.5s elapsed, 752/754 actions completed.
[INFO]Heartbeat: 30.5s elapsed, 754/754 actions completed.
[INFO]Build: Running build completed, took 30.9s
[INFO]Build: Caching finalized dependency graph...
[INFO]Build: Caching finalized dependency graph completed, took 197ms
[INFO]Build: Succeeded after 31.1s with 560 outputs (3266 actions)
[INFO] ----------------------------------------------------------------------------------------------------------------------------------------------------------------
[INFO] About to build [web]...
[INFO]Build: Updating asset graph...
[INFO]Build: Updating asset graph completed, took 12ms
[INFO]Build: Running build...
[INFO]Build: Running build completed, took 359ms
[INFO]Build: Caching finalized dependency graph...
[INFO]Build: Caching finalized dependency graph completed, took 242ms
[INFO]Build: Succeeded after 652ms with 9 outputs (7 actions)
[INFO] ----------------------------------------------------------------------------------------------------------------------------------------------------------------
```
<!--
Run `flutter analyze` and attach any output of that command below.
If there are any analysis errors, try resolving them before filing this issue.
-->
```
flutter analyze
Analyzing flutter_web_rawkeyboardlistener_example...
No issues found! (ran in 2.8s)
```
<!-- Finally, paste the output of running `flutter doctor -v` here. -->
```
Jeffs-MacBook-Pro-2:flutter_web_rawkeyboardlistener_example jeff$ flutter doctor -v
[✓] Flutter (Channel stable, v1.5.4-hotfix.2, on Mac OS X 10.14.5 18F132, locale en-US)
• Flutter version 1.5.4-hotfix.2 at /Users/jeff/Projects/git/flutter
• Framework revision 7a4c33425d (9 weeks ago), 2019-04-29 11:05:24 -0700
• Engine revision 52c7a1e849
• Dart version 2.3.0 (build 2.3.0-dev.0.5 a1668566e5)
[✓] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
• Android SDK at /Users/jeff/Library/Android/sdk
• Android NDK location not configured (optional; useful for native profiling support)
• Platform android-28, build-tools 28.0.3
• Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
• Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1343-b01)
• All Android licenses accepted.
[✓] iOS toolchain - develop for iOS devices (Xcode 10.2.1)
• Xcode at /Applications/Xcode.app/Contents/Developer
• Xcode 10.2.1, Build version 10E1001
• ios-deploy 1.9.4
• CocoaPods version 1.6.1
[✓] Android Studio (version 3.4)
• Android Studio at /Applications/Android Studio.app/Contents
• Flutter plugin version 35.3.1
• Dart plugin version 183.6270
• Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1343-b01)
[✓] IntelliJ IDEA Community Edition (version 2018.3.5)
• IntelliJ at /Applications/IntelliJ IDEA CE.app
• Flutter plugin version 33.4.2
• Dart plugin version 183.5912.23
[✓] VS Code (version 1.35.1)
• VS Code at /Applications/Visual Studio Code.app/Contents
• Flutter extension version 3.2.0
[!] Connected device
! No devices available
! Doctor found issues in 1 category.
``` | a: text input,team,framework,platform-web,P2,c: tech-debt,team: skip-test,team-web,triaged-web | low | Critical |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.