id
int64 393k
2.82B
| repo
stringclasses 68
values | title
stringlengths 1
936
| body
stringlengths 0
256k
⌀ | labels
stringlengths 2
508
| priority
stringclasses 3
values | severity
stringclasses 3
values |
|---|---|---|---|---|---|---|
470,715,713 | create-react-app | Support optimizations for clsx, classnames and similar libraries | ### Is your proposal related to a problem?
No. Proposing supporting this in the babel plugin config https://github.com/merceyz/babel-plugin-optimize-clsx
### Describe the solution you'd like
This plugin just adds optimizations if the existing project is using classnames or clsx. Not sure how to test performance of this change.
| issue: proposal | low | Major |
470,721,362 | go | proposal: spec: add Posit data type | [Posits](https://posithub.org/conga/2019/docs/13/1430-John-Introductory.pdf) are gaining [traction](https://posithub.org/conga/2019/programme) as a replacement and clean improvement over [IEEE 754](https://en.wikipedia.org/wiki/IEEE_754). They offer reasonable dynamic ranges with better accuracy / energy efficiency / speed on many applications. They will probably replace IEEE floats in 5 to 10 years in cpus / gpus / tpus. They have an official [standard](https://posithub.org/docs/posit_standard.pdf).
Adding (experimental) support for posits will position Go 2 in a better place for developers' consideration who want to get better results out of their mathematical calculations in AI, ML, HPC, weather forecasting, astrophysics etc. areas in addition to typical backend programming that Go is already good at. This will possibly enable Go's penetration into scientific computing.
At the moment there is no hw architecture that supports posits, but there are many sw and fpga [implementations](https://posithub.org/docs/PDS/PositEffortsSurvey.html). Initially it could start like [soft-floats](https://gitlab.com/cerlane/SoftPosit). As hw support becomes available, people will reap the benefits. Most floating-point code is readily convertable to posits: just rename data types.
Adding posits is non-trivial and a BIG step. It has to be done incrementally. Also there will possibly be a transition period where hw platforms will have IEEE floats and / or posits.
These are the (incomplete) steps of this proposal:
- add posit8, posit16, posit32, posit64 data types as per the standard
- add conversions from/to other data types
- add "printing/scanning posits" functionality to fmt library
- add math/posit standard library with standard Sine/Tan etc. (posit32)
- add cxposit32, cxposit64, cxposit128 complex number data types
- add math/cmplx/cxposit standard library (cxposit64)
There is a lot to do, so when hw support arrives, Go 2 will be ready to deliver ;) | LanguageChange,Proposal,LanguageChangeReview | medium | Critical |
470,729,717 | godot | Boot splash issue | **Godot version:**
3.1
**OS/device:**
Windows 8, Toshiba Satellite
**Issue description:**
Custom animated splash screens instanced as main scenes (for example, a `CanvasLayer` using an `AnimationPlayer` to play some default animation) will start playing during the built-in Godot boot splash. This means the custom splash will already be in progress by the time the Godot boot splash ends. This is ugly.
It would be nice if the built-in boot splash emitted some kind of signal so you could tell custom splash screens to start animating _after_ the built-in boot splash.
I tried setting the boot splash image to a transparent texture, and also set the bg color to transparent, but `application/boot_splash_bg_color` seems to ignore the alpha setting.
If there's a workaround in the meantime, please let me know.
**Steps to reproduce:**
1. Create a `CanvasLayer` scene with some kind of animation and set this as your main scene.
2. Run the project and notice that the animation is in progress after the the Godot boot splash finishes.
**See also:**
https://godotengine.org/qa/32784/is-there-a-signal-for-splash-screen | bug,topic:core | low | Major |
470,738,050 | angular | isStable, behavior of zone-patch-rxjs? | If I create a new Angular application with `ng new <name>` and just inject ApplicationRef as follow:
```typescript
import { ..., ApplicationRef } from '@angular/core';
export class AppComponent implements OnInit {
constructor(private appRef: ApplicationRef) {}
ngOnInit() {
this.appRef.isStable.subscribe(console.log);
}
}
```
I will get the emitted values [false, true] after app has been initialized, nothing strange.
But, if I then add `import 'zone.js/dist/zone-patch-rxjs'` in polyfills.ts or app.module.ts, previous code will get caught in infinite loop (toggle between emitted values true and false back and forth) and everything will eventually freeze. Is this the expected behavior? I am quite unsure myself | type: bug/fix,area: zones,state: confirmed,P4 | low | Minor |
470,738,116 | angular | Potential bug when used with webextension-polyfill | Hi everyone,
I use Angular 7 to develop a web extension for Firefox and Chrome.
It seems that **ZoneAwarePromise** is causing a weird behavior in Firefox preventing Mozilla **webextension-polyfill** to do it's task.
developer @rpl provided a cause:
> Firefox requires that the `promise `returned by `runtime.onMessage` listener to be a native Promise.
Without Angular, everything works as expected.
You can see the initial issue opened at webextension-polyfill:
https://github.com/mozilla/webextension-polyfill/issues/172
Without webextension-polyfill, it's a nightmare to develop extensions for different browsers.
Without Angular, it's a pain to develop in javascript. I hope I can keep both.
Can someone please help me figure out a solution to this problem, or at least provide some insight?
Steps to reproduce:
**Firefox:**
1. Open "about:debugging"
2. Enable add-on debugging
3. Click "Load temporary Add-on"
4. Select the extension folder
5. Click "Debug"
6. Click on the popup action button in the toolbar
Observed behavior: console immediately shows: "handleResponse undefined"
**Behavior NOT OK**
**Chrome:**
1. Go to extensions
2. "Load unpacked extension"
3. Select the extension folder
4. right click on the popup action button in the toolbar -> "inspect pop-up"
Observed behavior: after 2s console shows: "handleResponse async response from background script"
**Behavior OK**
I attached both the generated extension that you can import in Chrome/Firefox and observe the behavior, as well as the full Angular 7 example project if you need to take a look into the source code.
[dist_ff_promise_bug.zip](https://github.com/angular/zone.js/files/2792843/dist_ff_promise_bug.zip)
[project-ff-bug.zip](https://github.com/angular/zone.js/files/2792846/project-ff-bug.zip)
To generate the extension, you just need to:
```
yarn install
ng build --aot
```
This will generate the **dist** folder ready for import in Chrome/Firefox as an extension. | area: zones,state: needs more investigation,P4 | low | Critical |
470,738,286 | angular | Attempting to change configurable attribute of unconfigurable property | Using iOS' WKWebView in a Cordova app, I get this exception:
> TypeError: Attempting to change configurable attribute of unconfigurable property.
The exception is thrown here:
https://github.com/angular/zone.js/blob/afa1363eb9ae3be506442311a18723a112f9ef8b/lib/browser/property-descriptor.ts#L362
The strange thing is that the exception only occurs once in a while and I don't know how to reproduce it. I assume that there is other code that overwrites the `onreadystatechange` attribute of `XMLHttpRequest.prototype`. At least I'm sure that the property is not configurable when the error occurs. To proof this I set a break point on that line and retrieved the value of `xhrDesc`
```
Object {enumerable: false, configurable: false, get: function, set: function}
```
My suggestion is to either check whether the property is configurable or/and wrap the overwriting code in a try/catch. If it's not or if an exception is thrown, `canPatchViaPropertyDescriptor` could return `false`. | type: bug/fix,area: zones,state: confirmed,P4 | low | Critical |
470,738,370 | angular | Support for history.pushState() | I just found out that history.pushState() is not patched.
I would have expected it to be patched because it's most natural to expect the Angular router to pick up changes to the url from outside of Angular just as well.
For tracking purposes:
In this issue from 2014, btford already outlined History API to be supported by Zone.js: https://github.com/angular/zone.js/issues/9 | area: zones,state: needs more investigation,P4 | low | Major |
470,738,494 | flutter | What do each of the colors in ThemeData and ColorScheme() do? | I'm using `ColorScheme()` to theme my app and set some colors. Here's my code for the theme:
```
colorScheme: ColorScheme(
primary: Colors.red,
onPrimary: Colors.black,
primaryVariant: Colors.orange,
background: Colors.red,
onBackground: Colors.black,
secondary: Colors.red,
onSecondary: Colors.white,
secondaryVariant: Colors.deepOrange,
error: Colors.black,
onError: Colors.white,
surface: Colors.white,
onSurface: Colors.black,
brightness: Brightness.light,
),
// this is the only code in ThemeData.light().copyWith()
```
Here's the relevant documentation: [ColorScheme class](https://api.flutter.dev/flutter/material/ColorScheme-class.html)
**So what do these properties change the color of? Is there a list of which colors affect which widgets?**
By looking at the source of a FAB, I found out that `colorScheme.secondary` changes its background color, and that `colorScheme.onSecondary` should change the icon color, although it's not (what's up with that?). Here's what I found:
```
// floating_action_button.dart
final Color foregroundColor = this.foregroundColor // <-- colorScheme.onSecondary does NOT change FAB icon color
?? floatingActionButtonTheme.foregroundColor
?? theme.accentIconTheme.color
?? theme.colorScheme.onSecondary;
final Color backgroundColor = this.backgroundColor // <-- colorScheme.secondary changes FAB background color
?? floatingActionButtonTheme.backgroundColor
?? theme.colorScheme.secondary;
``` | framework,f: material design,d: api docs,customer: crowd,a: annoyance,P2,team-design,triaged-design,f: theming | low | Critical |
470,745,035 | angular | regression: jasmine.clock() inside fakeAsync() doesn't work anymore since 0.8.21 | This happens in an Angular application.
Simple steps to reproduce
- install Angular CLI
- generate a project with `ng new`
- write the following clock.spec.ts test
```
import { fakeAsync } from '@angular/core/testing';
fdescribe('clock test', () => {
afterEach(() => jasmine.clock().uninstall());
it('should fake the clock in fakeAsync', fakeAsync(() => {
const fakeTime = 12345678;
jasmine.clock().mockDate(new Date(fakeTime));
expect(new Date().getTime()).toBe(fakeTime);
}));
});
```
Run `ng test` to execute the test. It fails when zone.js version 0.8.21 is being used (default dependency to zone.js in package.json is `^0.8.19`, which now resolves to 0.8.21. If you change it to `0.8.20` and execute `npm install`or `yarn install` to make sure the previous version of zone.js is used, the test passes. | area: zones,state: needs more investigation,P3 | medium | Critical |
470,758,419 | node | Improve ERR_INVALID_CHAR error info | **Is your feature request related to a problem? Please describe.**
Recently, I have debug a error with http header
```console
(node:17863) UnhandledPromiseRejectionWarning: TypeError [ERR_INVALID_CHAR]: Invalid character in header content ["cookie"]
at ClientRequest.setHeader (_http_outgoing.js:458:3)
at new ClientRequest (_http_client.js:221:14)
at Object.request (http.js:44:10)
```
I take a very long time to find the invalid character (the root cause is because I put `\n` in the string end, so it failed).
**Describe the solution you'd like**
The error provide more information
**Describe alternatives you've considered**
Hopefully we can change something here to return more info
https://github.com/nodejs/node/blob/ba565a37349e81c9d2402b0c8ef05ab39dca8968/lib/_http_common.js#L227-L230 | http | low | Critical |
470,783,255 | opencv | Opencv-dnn(4.1.0) test_perf_dnn crush in win10 with certain output channel | <!--
If you have a question rather than reporting a bug please go to http://answers.opencv.org where you get much faster responses.
If you need further assistance please read [How To Contribute](https://github.com/opencv/opencv/wiki/How_to_contribute).
Please:
* Read the documentation to test with the latest developer build.
* Check if other person has already created the same issue to avoid duplicates. You can comment on it if there already is an issue.
* Try to be as detailed as possible in your report.
* Report only one problem per created issue.
This is a template helping you to create an issue which can be processed as quickly as possible. This is the bug reporting section for the OpenCV library.
-->
##### System information (version)
- OpenCV => 4.1.0
- Operating System / Platform => Windows 10 64 Bit Version 1903
- Compiler => Visual Studio 2015
##### Detailed description
I have compiled opencv-4.1.0 with opencl in win10. The computer is fitted with 2 nvidia 1080 ti GPUs and the CPU is i7 7700K. I am looking at OPENCV backend with OPENCL target on NVIDIA gpu card.
I tried to run the test_perf_dnn.exe but found some test cases will crush with the error message:
`OpenCV(4.1.0) Error: Assertion failed (u->refcount == 0 && "UMat deallocation error: some derived Mat is still alive") in cv::ocl::OpenCLAllocator::deallocate, file `D:\opencv-4.1.0\modules\core\src\ocl.cpp`, line 4809`
After a bit dig into the code, I found the above mentioned error is generated during calling
CV_Error in the macro CV_OCL_CHECKRESULT in ocl.cpp after calling clEnqueueReadBuffer at line 5062 in `D:\opencv-4.1.0\modules\core\src\ocl.cpp`. By directly output the error message using std::cout rather than call CV_Error, I found that the actual
error causing all these is
`OpenCL error CL_OUT_OF_RESOURCES (-5) during call: clEnqueueReadBuffer(q, handle=000001BC0CB01C00, CL_TRUE, 0, sz=394212, data=000001BC165E3C40, 0, 0, 0)`.
Based on this, I am assuming that the clEnqueueReadBuffer fail causes all the troubles here.
The failed case is
` /* GFLOPS 1.022 x 2 = 2.044 */ {{3, 3}, {{1, 576, 19, 19}}, 273, 1, {1, 1}, {1, 1}, {0, 0}, {0, 0}, "SAME", true, 1021896057.}`
This number 273 is very special and if I put this number to other test case, the clEnqueueReadBuffer will also return -5.
I have been tying to fix this for quite a little time but got no luck. Thank you very much for helping me look at this problem.
| category: ocl,category: dnn | low | Critical |
470,786,962 | rust | Codegen issue (endless recursion) with custom target and +soft-float | The following function causes endless recursion and a stack overflow on our bare metal target, which uses the `soft-float` feature:
```rust
#[no_mangle]
pub extern "C" fn _start() -> ! {
foo(1);
loop {}
}
fn foo(x: isize) -> f64 {
5 as f64 / x as f64
}
```
The target specification looks like this:
```json
{
"llvm-target": "x86_64-unknown-none",
"data-layout": "e-m:e-i64:64-f80:128-n8:16:32:64-S128",
"arch": "x86_64",
"target-endian": "little",
"target-pointer-width": "64",
"target-c-int-width": "32",
"os": "none",
"executables": true,
"linker-flavor": "ld.lld",
"linker": "rust-lld",
"panic-strategy": "abort",
"disable-redzone": true,
"features": "-mmx,-sse,+soft-float"
}
```
The following code is generated:
```
0000000000201000 <_start>:
201000: 50 push rax
201001: bf 01 00 00 00 mov edi,0x1
201006: e8 15 00 00 00 call 201020 <_ZN10playground3foo17hf4a4b11a35677989E>
[…]
0000000000201020 <_ZN10playground3foo17hf4a4b11a35677989E>:
201020: 50 push rax
201021: 48 89 3c 24 mov QWORD PTR [rsp],rdi
201025: 48 8b 3c 24 mov rdi,QWORD PTR [rsp]
201029: e8 22 00 00 00 call 201050 <__floatdidf>
[…]
0000000000201050 <__floatdidf>:
201050: 50 push rax
201051: e8 fa ff ff ff call 201050 <__floatdidf>
201056: 59 pop rcx
[…]
```
The `__floatdidf` function is just an endless recursion that leads to a stack overflow.
I tried debugging it on godbolt, but I don't know how to make it use a custom target. I created a small test project and documented the steps to reproduce at https://github.com/phil-opp/__floatdidf-issue.
cc @adeadman | A-codegen,T-compiler | low | Critical |
470,788,843 | angular | Support for EventSource | Zone.js supports WebSocket, but it doesn't appear to support Server Sent Events (correct me if I'm wrong).
That forces us to wrap our code using NgZone in Angular 2 apps, whereas it works with no extra works if we use WebSockets.
Is the support for EventSource planned?
| feature,area: zones,feature: under consideration | medium | Major |
470,824,281 | svelte | Slide transition inside slide transition breaks outer transition (v3.6.4) | **Describe the bug**
If you have an element A with a transition:slide, and puts another element B with transition:slide inside it, the last child of element A isn't included in the transition. Instead it just pops up at the end of the transition.
This broke with version v3.6.4, as it worked fine up until v3.6.3.
**To Reproduce**
v3.6.3, it's smooth:
https://svelte.dev/repl/c688496562be4624a009ddf25bbf74e4?version=3.6.3
v3.6.4, it's glitchy:
https://svelte.dev/repl/c688496562be4624a009ddf25bbf74e4?version=3.6.4
Note that it doesn't matter which child has the transition on it. It's always going to be the last child glitching out.
**Expected behavior**
I expect all children to slide in together, as it did in v3.6.3.
Alternatively I'd expect the child with the transition on it to slide in when the others are done or something.
**Information about your Svelte project:**
Chrome Version 75.0.3770.142 (Official Build) (64-bit)
macOS 10.13.3
Svelte v3.6.4-v3.6.7 (most recent atm)
Svelte REPL
**Severity**
Just annoying.
**Additional context**
Changes between v3.6.3 and v3.6.4:
https://github.com/sveltejs/svelte/compare/v3.6.3...v3.6.4
| bug,temp-stale | low | Critical |
470,827,671 | youtube-dl | Request for Peloton (onepeloton.com) | <!--
######################################################################
WARNING!
IGNORING THE FOLLOWING TEMPLATE WILL RESULT IN ISSUE CLOSED AS INCOMPLETE
######################################################################
-->
## Checklist
<!--
Carefully read and work through this check list in order to prevent the most common mistakes and misuse of youtube-dl:
- First of, make sure you are using the latest version of youtube-dl. Run `youtube-dl --version` and ensure your version is 2019.07.16. If it's not, see https://yt-dl.org/update on how to update. Issues with outdated version will be REJECTED.
- Make sure that all provided video/audio/playlist URLs (if any) are alive and playable in a browser.
- Make sure that site you are requesting is not dedicated to copyright infringement, see https://yt-dl.org/copyright-infringement. youtube-dl does not support such sites. In order for site support request to be accepted all provided example URLs should not violate any copyrights.
- Search the bugtracker for similar site support requests: http://yt-dl.org/search-issues. DO NOT post duplicates.
- Finally, put x into all relevant boxes (like this [x])
-->
- [x] I'm reporting a new site support request
- [x] I've verified that I'm running youtube-dl version **2019.07.16**
- [x] I've checked that all provided URLs are alive and playable in a browser
- [x] I've checked that none of provided URLs violate any copyrights
- [x] I've searched the bugtracker for similar site support requests including closed ones
## Example URLs
<!--
Provide all kinds of example URLs support for which should be included. Replace the following example URLs by yours.
-->
- Single video: https://members.onepeloton.com/classes/player/8c0e096db35e4340843363e3fa78d6e9
- Single video 2: https://members.onepeloton.com/classes/player/a495cf0139d44d3ea813e925af730cec
## Description
<!--
Provide any additional information.
If work on your issue requires account credentials please provide them or explain how one can obtain them.
-->
I have an account with Peloton, (onepeloton.com) but would like to download classes for when I am without internet for offline viewing. Sign-In page is located at https://members.onepeloton.com/login.
As this site does need credentials, I am happy to do the testing for you or provide results. Just let me know how I can be of help! | site-support-request,account-needed | low | Critical |
470,830,008 | flutter | Create platform view mutation integration tests | We should create an integration test for platform view composition with mutations such as:
clipping, transform, opacity.
The test should generate screenshot with various widget tree that containing a platform view.
The widget trees should be transformed to a layer trees that including clip_xx layers, transform layers, opacity layers and other container layers that is supported by iOS. (Android doesn't need extra implementation for mutations.)
Screenshot testing for iOS platform view is blocked because we didn't have a way to capture screenshots for iOS platform view yet. https://github.com/flutter/flutter/issues/23435
The test should resides in framework/integration/android_view -> when iOS testing is ready, should later rename the file to platform_view
| a: tests,team,framework,a: platform-views,P2,a: plugins,team-framework,triaged-framework | low | Minor |
470,881,933 | flutter | Automatically calculate map bounds from a list of `LatLng` values | Just read the source code. Cannot find a method to build a LatLngBounds from a list of LatLng.
https://developers.google.com/android/reference/com/google/android/gms/maps/model/LatLngBounds.Builder | c: new feature,p: maps,package,c: proposal,team-ecosystem,P3,triaged-ecosystem | medium | Critical |
470,891,176 | pytorch | Deterministic mode for scatter_add operation | This issue comes from the discussion started [here](https://discuss.pytorch.org/t/possible-solution-to-the-reproducibility-issues-using-scatter-add-operation/48989).
## 🚀 Feature
A GPU deterministic mode for scatter_add and similar operations
## Motivation
I know that there is a general idea that non-deterministic algorithms do not have a lot of influence on the results, but, in some cases, there is a huge impact. It is a little bit frustrating not be able to reproduce an experiment even though you have all seeds, random states, init weights and so on saved. Moreover, this behavior sometimes can lead to wrong conclusions, when you are trying new methodologies. For instance, I started this thread because in pytorch_geometric some of the operations are based on non-deterministic implementations of pytorch. As you can see in this [github](https://github.com/rusty1s/pytorch_geometric/issues/446) issue this behavior is impacting the results. At the end this non-deterministic behavior has an impact in other libraries like pytorch geometric, causing the lack of reproducibility.
## Pitch
I would like to be able to have a deterministic mode for the previously mentioned operations.
## Alternatives
I know that the deterministic mode for these kinds of operations will come with a huge runtime trade-off. However, I found this [article](https://people.eecs.berkeley.edu/~hdnguyen/public/papers/ARITH21_Fast_Sum.pdf) that can help with the deterministic mode of scatter_add.
| triaged,module: determinism,function request,module: scatter & gather ops | low | Minor |
470,910,913 | flutter | Explain in project template why FlutterActivity handles all config changes | Add comments in the project template within the Android manifest file that mentions why FlutterActivity handles all config changes.
This is especially true for splash behavior, which either requires explicit FlutterActivity handling of config changes, or requires that the developer provide the same FlutterEngine across configuration changes. | team,engine,P2,team-engine,triaged-engine | low | Minor |
470,917,835 | go | cmd/link: showing many ld warnings of "building for macOS, but linking in object file" | <!-- Please answer these questions before submitting your issue. Thanks! -->
### What version of Go are you using (`go version`)?
<pre>
$ go version go1.12.7 darwin/amd64
</pre>
### Does this issue reproduce with the latest release?
yes
### What operating system and processor architecture are you using (`go env`)?
Mac Mojave 10.14.5
Result of `go env`:
```
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/avence12/Library/Caches/go-build"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
GOPATH="/Users/avence12/.gvm/pkgsets/go1.12.7/global:/Users/avence12/devel/go"
GOPROXY=""
GORACE=""
GOROOT="/Users/avence12/.gvm/gos/go1.12.7"
GOTMPDIR=""
GOTOOLDIR="/Users/avence12/.gvm/gos/go1.12.7/pkg/tool/darwin_amd64"
GCCGO="gccgo"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/9n/_tfc4bt12ps45qjyzh40jt1h0000gn/T/go-build525129295=/tmp/go-build -gno-record-gcc-switches -fno-common"
```
### What did you do?
1. Install and use go1.12.7 by GVM
2. Get into my project and run `go build ./...`
3. The build is successful but seeing lots of ld warning. The same situation when I run `go test ./...`
4. When I setup `export CGO_ENABLED=0`, the warning is gone. However I would like to know how to resolve the issue.
### What did you expect to see?
No ld warnings when `CGO_ENABLED=1`
### What did you see instead?
```
$ go build ./cmd/...
# github.com/avence12/myproj/cmd/client
ld: warning: building for macOS, but linking in object file (/var/folders/9n/_tfc4bt12ps45qjyzh40jt1h0000gn/T/go-link-703159202/go.o) built for
# github.com/avence12/myproj/cmd/server
ld: warning: building for macOS, but linking in object file (/var/folders/9n/_tfc4bt12ps45qjyzh40jt1h0000gn/T/go-link-846047020/go.o) built for
```
| NeedsInvestigation,compiler/runtime | medium | Critical |
470,961,459 | flutter | Text Editor like in web platform |
<img width="941" alt="Screen Shot 2019-07-30 at 4 55 43 PM" src="https://user-images.githubusercontent.com/11361035/62124808-e8d6e680-b2ea-11e9-9bb1-e6478a51d184.png">
| a: text input,c: new feature,framework,P3,team-framework,triaged-framework | low | Minor |
470,969,265 | flutter | Restore a list scroll state switching between tabs is too slow and memory expensive |
## Details
I am ready to publish my first flutter app to read news by category. Every category has a list of posts with title, subtitle, FadeInImage and date. A List powered by RefreshIndicator and paging features. The app works perfect on any device. But I have discovered an issue with restoring scroll state switching between tabs if count of items is about 100+.
Memory usage is huge(example from simple app ).
1. Steps to reproduce
Run an app.
Scroll down to the end of a list of numbers(1k items).
Switch to the next tab and do previous step.
Switch between first and second tabs.
**Actual result:** Tabs switch with a huge delay.
**Expected result:** Tabs should switch with no delay with 60fps.
2. Gist https://gist.github.com/neestell/f2ad6e546610111e68ad418dbc37455c
3. Master channel + profile with skia [video](https://youtu.be/NNXlUwjTzqc)
4. Observatory [dart-timeline-2019-6-22.txt](https://github.com/flutter/flutter/files/3416260/dart-timeline-2019-6-22.txt)
)
## Logs
<!--
Run `flutter analyze` and attach any output of that command below.
If there are any analysis errors, try resolving them before filing this issue.
-->
```
Analyzing tabs_with_long_scroll_content...
No issues found! (ran in 17.8s)
```
<!-- Finally, paste the output of running `flutter doctor -v` here, with your device plugged in. -->
```
MacBook-Air-Dmitriy-Ra:tabs_with_long_scroll_content dmitry$ flutter doctor -v
[✓] Flutter (Channel stable, v1.7.8+hotfix.3, on Mac OS X 10.14.5 18F132, locale ru-RU)
• Flutter version 1.7.8+hotfix.3 at /Volumes/Data/Android/flutter
• Framework revision b712a172f9 (13 days ago), 2019-07-09 13:14:38 -0700
• Engine revision 54ad777fd2
• Dart version 2.4.0
[✓] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
• Android SDK at /Volumes/Data/Android/sdk
• Android NDK location not configured (optional; useful for native profiling support)
• Platform android-28, build-tools 28.0.3
• ANDROID_HOME = /Volumes/Data/Android/sdk
• ANDROID_SDK_ROOT = /Volumes/Data/Android/sdk
• Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
• Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1343-b01)
• All Android licenses accepted.
[✓] Xcode - develop for iOS and macOS (Xcode 10.2.1)
• Xcode at /Volumes/Data/iOS/Xcode.app/Contents/Developer
• Xcode 10.2.1, Build version 10E1001
• CocoaPods version 1.7.1
[✓] iOS tools - develop for iOS devices
• ios-deploy 1.9.4
[✓] Android Studio (version 3.4)
• Android Studio at /Applications/Android Studio.app/Contents
• Flutter plugin version 37.0.1
• Dart plugin version 183.6270
• Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1343-b01)
[✓] Connected device (1 available)
• Pixel 2 • HT7AZ1A00828 • android-arm64 • Android 9 (API 28)
• No issues found!
```
| framework,c: performance,f: scrolling,perf: memory,perf: speed,has reproducible steps,P2,found in release: 3.3,found in release: 3.7,team-framework,triaged-framework | low | Critical |
470,973,026 | rust | Remove padding when code spans/code link spans are adjacent | I used
```markdown
[`Stream`](futures::stream::Stream)`<Item = `[`io::Result`](std::io::Result)`<`[`Bytes`](bytes::Bytes)`>>`
```
in [some crates documentation](https://docs.rs/async-compression/0.1.0-alpha.1/async_compression/) which renders as
There is currently a `0.1em` padding applied inside all code spans causing the spacing to look weird. It seems like adjacent code spans (including ones wrapped inside `<a>`) should have the padding suppressed so they render as if they were one code span. | T-rustdoc,C-feature-request,A-rustdoc-ui | low | Major |
471,013,396 | flutter | Google sign-in without firebase | In most of tutorials on the web, I can see that the plugin google_sign_in doesn't require firebase. In pub page, it is mentioned that the application must be registered in the following link :
https://developers.google.com/mobile/add?platform=android
That link is now redirecting to firebase's homepage. So my question is:
Is it still possible to Sign-in without firebase ? Where should I register the app in that case ? | d: examples,d: stackoverflow,customer: crowd,p: google_sign_in,package,team-ecosystem,P2,triaged-ecosystem | low | Critical |
471,097,424 | pytorch | Can't `torch.sum(tensor, dim)` where `dim >= 64` | ## 🐛 Bug
Can't use TensorIterator reduction functions if the dimension to be reduced over is > 64.
## To Reproduce
```
In [1]: import torch
In [2]: sizes = [1]*65
In [3]: x = torch.randn(sizes)
In [4]: x.sum(0)
Out[4]: tensor([[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[-0.2885]]]]]]]]]]]]]]]]
]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]])
In [5]: x.sum(65)
---------------------------------------------------------------------------
IndexError Traceback (most recent call last)
<ipython-input-5-cfca9db78f16> in <module>()
----> 1 x.sum(65)
IndexError: Dimension out of range (expected to be in range of [-65, 64], but got 65)
In [6]: x.sum(64)
---------------------------------------------------------------------------
RuntimeError Traceback (most recent call last)
<ipython-input-6-6375767cd187> in <module>()
----> 1 x.sum(64)
RuntimeError: bitset::set: __position (which is 64) >= _Nb (which is 64)
```
# Expected behavior
A cleaner error message and documentation about the limitation. | module: error checking,triaged,module: TensorIterator,module: reductions | low | Critical |
471,100,330 | rust | Building shared libraries on Mac requires '-undefined dynamic_lookup' | <!-- Thanks for filing a 🐛 bug report 😄! -->
**Problem**
<!-- A clear and concise description of what the bug is. -->
A shared library used as a plugin will often reference symbols in the host program. These symbols will remain unresolved at build time, but will be resolved at the time the shared library is loaded into the host program.
Cargo on Mac fails to build any shared library that can't resolve the symbols at build time.
<!-- including what currently happens and what you expected to happen. -->
I expect cargo to build a crate containing unresolved symbols successfully; which works fine on ubuntu.
**Steps**
A crate with the following ``Cargo.toml``:
```
[package]
name = "fail"
version = "0.1.0"
authors = ["jefdavi"]
edition = "2018"
[lib]
crate-type = ["cdylib"]
```
and ``src/lib.rs``:
```
extern "C" {
static unresolved: i32;
}
#[no_mangle]
extern fn myfunc() {
unsafe {
println!("{}", unresolved);
}
}
```
**Possible Solution(s)**
<!-- Not obligatory, but suggest a fix/reason for the bug, -->
<!-- or ideas how to implement the addition or change -->
A workaround is to specify:
``
[build]
rustflags = ["-Clink-args=-undefined dynamic_lookup"]
``
in ``.cargo/config``, but that's not acceptable for a crate author (https://github.com/jeff-davis/postgres-extension.rs), who doesn't have control over the crate users' config files.
**Notes**
Output of `cargo version`:
``cargo 1.36.0 (c4fcfb725 2019-05-15)``
``18.6.0 Darwin Kernel Version 18.6.0``
<!-- Also, any additional context or information you feel may be relevant to the issue. -->
<!-- (e.g rust version, OS platform/distribution/version, target toolchain(s), release channel.. -->
| A-linkage,O-macos,T-compiler | low | Critical |
471,112,135 | flutter | Firebase Test Lab Robo Test support | Firebase offer a nice way to test android app automatically (or semi automatically if you provide a Robo Script) called Robo test in their Test Lab section https://firebase.google.com/docs/test-lab/android/robo-ux-test
Would be nice if Flutter application can be test that way too.
Currently when you upload the APK, there is 2 issues:
- it open the app, wait for the first screen to show, then exit the app. It doesn't try to automatically explore the app
- We can't provide a Robo Script because the AS plugin to do that doesn't record anything for a flutter app
That way of testing is quite nice as it doesn't need that much work to actually do something, and firebase allow a large choice of devices. Doing such UI test will help finding UI problem (so it also benefit iOS, desktop and web platform too) | c: new feature,platform-android,customer: crowd,P3,a: plugins,team-android,triaged-android | high | Critical |
471,116,606 | flutter | in_app_purchase plugin - Auto-Renewable Subscription never expires in Sandbox | I've setup an Auto-Renewable Subscription, and was successfully able to purchase it using my sandbox user account (on an actual device).
The problem is that unlike what is described here (Testing Subscription: https://medium.com/swift-india/auto-renewable-subscriptions-for-ios-3a4068f11acd), the subscription doesn't expire. I've waited for more than 2 hours, terminated the app, uninstalled and re-installed it - nothing helped... | customer: crowd,p: in_app_purchase,package,team-ecosystem,P3,triaged-ecosystem | low | Major |
471,119,234 | go | encoding/xml: unexpected behavior of decoder.Skip | <!-- Please answer these questions before submitting your issue. Thanks! -->
### What version of Go are you using (`go version`)?
<pre>
$ go version
go1.12.4 linux/amd64
</pre>
### Does this issue reproduce with the latest release?
Yes
### What operating system and processor architecture are you using (`go env`)?
<details><summary><code>go env</code> Output</summary><br><pre>
$ go env
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/alef/.cache/go-build"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/home/alef/go_ws"
GOPROXY=""
GORACE=""
GOROOT="/usr/local/go"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build838012780=/tmp/go-build -gno-record-gcc-switches"
</pre></details>
### What did you do?
https://play.golang.org/p/-DttEFaM_L9
### What did you expect to see?
<pre>
some value <nil>
some value <nil>
</pre>
### What did you see instead?
<pre>
some value <nil>
XML syntax error on line 1: unexpected end element </tag2>
</pre>
It a lit bit discouraged, what `xml.Skip` not working with `RawToken`, this behavior not mentioned in `xml.Skip` description.
| NeedsInvestigation | low | Critical |
471,138,102 | go | crypto/rsa: RSA key generation is unreasonably slow on MIPS architecture | <!-- Please answer these questions before submitting your issue. Thanks! -->
### What version of Go are you using (`go version`)?
<pre>
$ go version
go version go1.12.7 linux/amd64
</pre>
### Does this issue reproduce with the latest release?
yes
### What operating system and processor architecture are you using (`go env`)?
```
GOARCH="mipsle"
GOOS="linux"
```
### What did you do?
<!--
If possible, provide a recipe for reproducing the error.
A complete runnable program is good.
A link on play.golang.org is best.
-->
Created a simple benchmark for generating RSA keys. Made some adjustments to make the algorithm deterministic, so the benchmark time is independent from the value of the input random seed
rsa_test.go
```go
package rsa_test
import (
"crypto/aes"
"crypto/cipher"
"crypto/rsa"
"io"
"runtime/debug"
"strings"
"testing"
)
type devZero struct{}
func (dz devZero) Read(p []byte) (n int, err error) {
for i, _ := range p {
p[i] = 0
}
return len(p), nil
}
// reader which tries to negate the effect of crypto/internal/randutil/randutil.MaybeReadByte
// https://github.com/golang/go/blob/6269dcdc24d74379d8a609ce886149811020b2cc/src/crypto/internal/randutil/randutil.go#L25
// useful to regain deterministic output of some crypto routines with respect to a fixed pseudo-random stream
// such as https://github.com/golang/go/blob/6269dcdc24d74379d8a609ce886149811020b2cc/src/crypto/rsa/rsa.go#L222
type maybenotReader struct {
io.Reader
}
func (r maybenotReader) Read(p []byte) (n int, err error) {
if strings.Contains(string(debug.Stack()), "crypto/internal/randutil.MaybeReadByte") {
// feed MaybeReadByte with dummy zeroes
for i := range p {
p[i] = 0
}
return len(p), nil
}
return r.Reader.Read(p)
}
var seed = []byte{0x00, 0x01, 0x02, 0x03, 0x04, 0x05, 0x06, 0x07, 0x08, 0x09, 0x0a, 0x0b, 0x0c, 0x0d, 0x0e, 0x0f}
func newDRNG() io.Reader {
block, _ := aes.NewCipher(seed)
stream := cipher.NewCTR(block, make([]byte, 16))
return cipher.StreamReader{S: stream, R: devZero{}}
}
func benchmarkRsaGenerateKey(bits int, b *testing.B) {
for n := 0; n < b.N; n++ {
_, e := rsa.GenerateKey(maybenotReader{newDRNG()}, bits)
if e != nil {
b.Fatal(e)
}
}
}
func BenchmarkRsaGenerateKey1024(b *testing.B) {
benchmarkRsaGenerateKey(1024, b)
}
func BenchmarkRsaGenerateKey2048(b *testing.B) {
benchmarkRsaGenerateKey(2048, b)
}
func BenchmarkRsaGenerateKey4096(b *testing.B) {
benchmarkRsaGenerateKey(4096, b)
}
```
Compile the above and run on a target platform:
```
$ GOARCH=mipsle go test -c -o testmips rsa_test.go
# copy ./testmips to MIPS Linux - I used Debian Stretch in QEMU
$ $ uname -a
Linux debmips 4.9.0-9-4kc-malta #1 Debian 4.9.168-1 (2019-04-12) mips GNU/Linux
```
### What did you expect to see?
Seconds to generate RSA keys
### What did you see instead?
Minutes (closer to hours) to generate 2048 and 4096 RSA keys
```
$ time ./testmips -test.bench=. -test.count 3
goos: linux
goarch: mipsle
BenchmarkRsaGenerateKey1024 1 35798014775 ns/op
BenchmarkRsaGenerateKey1024 1 31147393335 ns/op
BenchmarkRsaGenerateKey1024 1 6627440839 ns/op
BenchmarkRsaGenerateKey2048 1 168812137075 ns/op
BenchmarkRsaGenerateKey2048 1 134741347265 ns/op
BenchmarkRsaGenerateKey2048 1 147304597939 ns/op
BenchmarkRsaGenerateKey4096 1 1039797721543 ns/op
BenchmarkRsaGenerateKey4096 1 823377806776 ns/op
BenchmarkRsaGenerateKey4096 1 623262088403 ns/op
PASS
real 50m11.506s
user 33m49.000s
sys 15m33.744s
```
For comparison, generating 4096-bit key with `openssl` 3 times on the same QEMU instance:
```
$ time for i in 1 2 3; do openssl genpkey -algorithm rsa -pkeyopt rsa_keygen_bits:4096 1>/dev/null; done
........................++++
........................................................................................................++++
.................................++++
....++++
.........................................................................................................................................................................................................................................................................................................................................................................................................................................++++
.....................................++++
real 2m10.133s
user 2m8.800s
sys 0m0.308s
```
### Additional info
It seems the key generation time on MIPS grows disproportionally with the requested key size. Fun fact: for 4096-bit keys it is ~1.75 faster to emulate ARM on MIPS than to run MIPS code directly.
NOTE: for below simulations I used Go `1.10`, because later versions of Go are not `qemu-user` emulator friendly (probably, because of #24656). The test OS in question: Debian Stretch x86_64.
Compile the above test and run under `qemu-mipsel-static` emulator
```
$ GOARCH=mipsle go test -c -o testmips rsa_test.go
$ time qemu-mipsel-static ./testmips -test.bench=. -test.count 3
goos: linux
goarch: mipsle
BenchmarkRsaGenerateKey1024-32 1 5689779179 ns/op
BenchmarkRsaGenerateKey1024-32 1 5625519786 ns/op
BenchmarkRsaGenerateKey1024-32 1 5634661337 ns/op
BenchmarkRsaGenerateKey2048-32 1 89522431701 ns/op
BenchmarkRsaGenerateKey2048-32 1 92388147744 ns/op
BenchmarkRsaGenerateKey2048-32 1 91639958105 ns/op
BenchmarkRsaGenerateKey4096-32 1 589441375945 ns/op
BenchmarkRsaGenerateKey4096-32 1 583990222852 ns/op
BenchmarkRsaGenerateKey4096-32 1 589008197818 ns/op
PASS
real 34m14.872s
user 34m8.239s
sys 0m22.022s
```
Compile the same code, but for arm and run it on `qemu-arm-static` emulator compiled for `mipsle` (which I just downloaded from official Debian MIPS stretch repositories) and running on `qemu-mipsel-static` emulator (double emulation):
```
$ GOARCH=arm go test -c -o testarm rsa_test.go
$ time qemu-mipsel-static ../emuemu/usr/bin/qemu-arm-static ./testarm -test.bench=. -test.count 3
goos: linux
goarch: arm
BenchmarkRsaGenerateKey1024-32 1 8405353927 ns/op
BenchmarkRsaGenerateKey1024-32 1 7890613791 ns/op
BenchmarkRsaGenerateKey1024-32 1 7742888355 ns/op
BenchmarkRsaGenerateKey2048-32 1 84443846429 ns/op
BenchmarkRsaGenerateKey2048-32 1 85332574758 ns/op
BenchmarkRsaGenerateKey2048-32 1 86418695881 ns/op
BenchmarkRsaGenerateKey4096-32 1 332455626256 ns/op
BenchmarkRsaGenerateKey4096-32 1 348751908420 ns/op
BenchmarkRsaGenerateKey4096-32 1 350252575613 ns/op
PASS
real 25m46.399s
user 23m43.629s
sys 8m41.457s
```
As we can see it makes almost no difference for 2048-bit keys with double emulation through arm and 4096-bit keys are even faster when emulated with arm. | Performance,NeedsInvestigation | low | Critical |
471,140,445 | go | path/filepath: Split on a path with more than 1 separator at the start doesn't work on Windows | <!-- Please answer these questions before submitting your issue. Thanks! -->
### What version of Go are you using (`go version`)?
<pre>
$ go version
go version go1.11.4 windows/amd64
</pre>
### Does this issue reproduce with the latest release?
I don't have a working installation of it at the moment.
### What operating system and processor architecture are you using (`go env`)?
<details><summary><code>go env</code> Output</summary><br><pre>
$ go env
set GOARCH=amd64
set GOBIN=
set GOCACHE=C:\Users\vittorio.parrella\AppData\Local\go-build
set GOEXE=.exe
set GOFLAGS=
set GOHOSTARCH=amd64
set GOHOSTOS=windows
set GOOS=windows
set GOPATH=c:\GOPATH\trunk\ETS2
set GOPROXY=
set GORACE=
set GOROOT=C:\Go
set GOTMPDIR=
set GOTOOLDIR=C:\Go\pkg\tool\windows_amd64
set GCCGO=gccgo
set CC=gcc
set CXX=g++
set CGO_ENABLED=1
set GOMOD=
set CGO_CFLAGS=-g -O2
set CGO_CPPFLAGS=
set CGO_CXXFLAGS=-g -O2
set CGO_FFLAGS=-g -O2
set CGO_LDFLAGS=-g -O2
set PKG_CONFIG=pkg-config
set GOGCCFLAGS=-m64 -mthreads -fmessage-length=0 -fdebug-prefix-map=C:\Users\VITTOR~1.PAR\AppData\Local\Temp\2\go-build213636594=/tmp/go-build -gno-record-gcc-switches
</pre></details>
### What did you do?
<pre>
import (
"fmt"
"path"
"path/filepath"
)
func main() {
dir,file := filepath.Split(`C:\test\test.jpg`)
fmt.Println("path: ", dir, " - file: ", file)
// this is the problematic scenario
// seems that if there is more than separator at the start, the split does not work
dir,file = filepath.Split(`\\test/test.jpg`)
fmt.Println("path: ", dir, " - file: ", file)
dir,file = filepath.Split(`\test/test.jpg`)
fmt.Println("path: ", dir, " - file: ", file)
dir,file = filepath.Split(`//test/test.jpg`)
fmt.Println("path: ", dir, " - file: ", file)
// in fact, using path.Clean eliminates the problem
dir,file = filepath.Split(path.Clean(`//test/test.jpg`))
fmt.Println("path: ", dir, " - file: ", file)
}
</pre>
### What did you expect to see?
<pre>
path: C:\test\ - file: test.jpg
path: \\test/ - file: test.jpg
path: \test/ - file: test.jpg
path: ////test/ - file: test.jpg
path: /test/ - file: test.jpg
</pre>
### What did you see instead?
<pre>
path: C:\test\ - file: test.jpg
path: \\test/test.jpg - file:
path: \test/ - file: test.jpg
path: //test/ - file: test.jpg
path: /test/ - file: test.jpg
</pre>
Note:
On linux it seems that the issue does not manifest, the output is as expected (minus the absolute windows path which is ok): https://play.golang.org/p/9PlmyANLFAL
| NeedsInvestigation | low | Critical |
471,153,532 | flutter | Let CupertinoNavigationBar leading/trailing sizing be customizable | The cupertino navigation bar leading width seems limited:
I can not make my widget such as a Row with text and image in side ...... What should I do? | c: new feature,framework,f: cupertino,c: proposal,P3,workaround available,team-design,triaged-design | medium | Major |
471,214,232 | vscode | Scrolling can be improved | Issue Type: <b>Feature Request</b>
when some of my file's size grows when I'm developing, then it becomes more and more hard to scroll.
Little scrolling drag shifts code in screen very large amount up or down, but sometimes I want it to shift only little bit.
This is convenient to do if file contains about under 2000 rows but becomes more and more inconvenient as rows amount grow.
There can be nice solution for that: if holding down Ctrl key while dragging scrollbar button with mouse, then code in screen moves more slowly.
It would be most nice when i move cursor with mouse about 200 pixels up while dragging.
then code in screen moves down about 30 rows.
(Mouse cursor and scrollbar button doesn't need to stay in one place - when cursor moves
example 200px up, then scrollbar button can move example only 50px up)
Thank you :)
I love this program :)
VS Code version: Code 1.36.0 (0f3794b38477eea13fb47fbe15a42798e6129338, 2019-07-03T13:25:46.372Z)
OS version: Windows_NT x64 6.1.7601
<!-- generated by issue reporter --> | feature-request,editor-scrollbar | low | Major |
471,223,322 | go | x/crypto/ssh: listening on remote address blocks indefinitely when address doesn't contain a host part | <!-- Please answer these questions before submitting your issue. Thanks! -->
### What version of Go are you using (`go version`)?
<pre>
$ go version
go version go1.11.2 linux/amd64
</pre>
### What operating system and processor architecture are you using (`go env`)?
<details><summary><code>go env</code> Output</summary><br><pre>
$ go env
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/kanobe/.cache/go-build"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/home/kanobe/src/go"
GOPROXY=""
GORACE=""
GOROOT="/home/kanobe/download/go"
GOTMPDIR=""
GOTOOLDIR="/home/kanobe/download/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build496899549=/tmp/go-build -gno-record-gcc-switches"
</pre></details>
### What did you do?
<!--
If possible, provide a recipe for reproducing the error.
A complete runnable program is good.
A link on play.golang.org is best.
-->
Created an SSH connection using ssh.Dial, and opened a Listener to listen on a port without specifying a host address. Then connected to that port (i.e. using telnet).
This program demonstrates the issue:
<pre>
package main
import (
"io/ioutil"
"log"
"os"
"path"
"golang.org/x/crypto/ssh"
)
func buildSshConfig(user, keyfile string) (conf *ssh.ClientConfig) {
key, err := ioutil.ReadFile(keyfile)
if err != nil {
log.Fatal("unable to build ssh config: ", err)
}
signer, err := ssh.ParsePrivateKey(key)
if err != nil {
log.Fatal("unable to build ssh config: ", err)
}
conf = &ssh.ClientConfig{
User: user,
Auth: []ssh.AuthMethod{
// Use the PublicKeys method for remote authentication.
ssh.PublicKeys(signer),
},
HostKeyCallback: ssh.InsecureIgnoreHostKey(),
}
return
}
func main() {
config := buildSshConfig(os.Getenv("USER"),
path.Join(os.Getenv("HOME"), ".ssh/id_rsa"))
conn, err := ssh.Dial("tcp", "localhost:22", config)
if err != nil {
log.Fatal("unable to connect: ", err)
}
defer conn.Close()
// Request the remote side to open port 8080
l, err := conn.Listen("tcp", ":8080")
if err != nil {
log.Fatal("unable to register tcp forward: ", err)
}
defer l.Close()
log.Println("Calling Accept")
l.Accept()
log.Println("Accept returned")
}
</pre>
### What did you expect to see?
<pre>
Calling Accept
Accept Returned
</pre>
### What did you see instead?
<pre>
Calling Accept
</pre>
### Additional Info
It seems that if the local address is not specified in ssh.Client.Listen, the Accept call blocks indefinitely. For example this line fails in the above program:
<pre>
l, err := conn.Listen("tcp", ":8080")
</pre>
But when changed to this it succeeds:
<pre>
l, err := conn.Listen("tcp", "127.0.0.1:8080")
</pre>
The host may be omitted in net.Listen, so there is precedent for using no host. From net.Listen: "For TCP networks, if the host in the address parameter is empty or a literal unspecified IP address, Listen listens on all available unicast and anycast IP addresses of the local system."
I think at a minimum if host may not be omitted, the documentation should mention that it is not supported, and the Listen call should return an error.
| NeedsInvestigation | low | Critical |
471,261,682 | go | wiki: CodeReviewComments change | Hello,
I suggest an example to be added to explain why interface constructor should return the struct not the interface type itself
The edit to be added on [CodeReviewComments #interfaces](https://github.com/golang/go/wiki/CodeReviewComments/b61e691f208b5b3523cc3fde1870e8ccec4b2170#interfaces)
`Go interfaces generally belong in the package that uses values of the interface type, not the package that implements those values. The implementing package should return concrete (usually pointer or struct) types: that way, new methods can be added to implementations without requiring extensive refactoring, **and this will enable the struct to implement more than one interface and be accepted/evaluated to all of them in different functions** `
The code example
https://play.golang.org/p/zZU0rFzjuEm
```go
// DONOT DO THIS
package main
import ("io")
type Thinger interface {
Thing() bool
}
type defaultThinger struct{ }
func (t defaultThinger) Thing() bool {
return true
}
func (t defaultThinger) Read(p []byte) (n int, err error) {
return 0, nil
}
func NewThinger() Thinger {
return defaultThinger{ }
}
func main() {
testThinger(NewThinger())
// will return cannot use NewThinger() (type Thinger) as type io.Reader in argument to testReader: Thinger does not implement io.Reader (missing Read method)
// if NewThinger() return defaultThinger it will work
testReader(NewThinger())
}
func testReader(r io.Reader) {}
func testThinger(t Thinger) {}
``` | Documentation,NeedsInvestigation | low | Critical |
471,299,272 | rust | -Csave-temps does not retain linker scripts | Rust uses a linker script with gcc linker flavour, adding a flag like this:
```
-Wl,--version-script=/run/user/1000/rustcXt0Huw/list
```
However this file is not preserved even when `-Csave-temps` is specified, making it impossible to really debug linkage issues outside of rustc. | A-linkage,T-compiler,C-bug | low | Critical |
471,359,831 | flutter | `flutter create --help | less` should have better formatting | Related: https://github.com/flutter/flutter/issues/23074, https://github.com/flutter/flutter/issues/36484.
When piping flutter help to a pager, the text becomes less readable. Apparently if you don't pipe help, the output is well formatted.
Here is the output of `flutter create --help | fold -w 80 | pbcopy`. This is to indicate what a user's experience might be like if they ran `flutter create --help | less` on a terminal with 80 width.
```
Create a new Flutter project.
If run on a project that already exists, this will repair the project, recreatin
g any files that are missing.
Usage: flutter create <output directory>
-h, --help Print this usage information.
--[no-]pub Whether to run "flutter pub get" after the projec
t has been created.
(defaults to on)
--[no-]offline When "flutter pub get" is run by the create comma
nd, this indicates whether to run it in offline mode or not. In offline mode, it
will need to have all dependencies already available in the pub cache to succee
d.
--[no-]with-driver-test Also add a flutter_driver dependency and generate
a sample 'flutter drive' test.
-t, --template=<type> Specify the type of project to create.
[app] (default) Generate a Flutter application.
[package] Generate a shareable Flutter project containing m
odular Dart code.
[plugin] Generate a shareable Flutter project containing a
n API in Dart code with a platform-specific implementation for Android, for iOS
code, or for both.
-s, --sample=<id> Specifies the Flutter code sample to use as the m
ain.dart for an application. Implies --template=app. The value should be the sam
ple ID of the desired sample from the API documentation website (http://docs.flu
tter.dev). An example can be found at https://master-api.flutter.dev/flutter/wid
gets/SingleChildScrollView-class.html
--list-samples=<path> Specifies a JSON output file for a listing of Flu
tter code samples that can created with --sample.
--[no-]overwrite When performing operations, overwrite existing fi
les.
--description The description to use for your new Flutter proje
ct. This string ends up in the pubspec.yaml file.
(defaults to "A new Flutter project.")
--org The organization responsible for your new Flutter
project, in reverse domain name notation. This string is used in Java package n
ames and as prefix in the iOS bundle identifier.
(defaults to "com.example")
--project-name The project name for this new Flutter project. Th
is must be a valid dart package name.
-i, --ios-language [objc (default), swift]
-a, --android-language [java (default), kotlin]
--[no-]androidx Generate a project using the AndroidX support lib
raries
Run "flutter help" to see global options.
```
I found a solution, but I ask for your opinion, if this should be the correct solution.
```
> brew install expect
> unbuffer flutter create --help | less
``` | c: new feature,tool,a: quality,c: proposal,P3,team-tool,triaged-tool | low | Minor |
471,382,063 | flutter | Log file for 'flutter run widget_test.dart' | Following the tip here for running widget tests:
https://twitter.com/flutterdev/status/1038114431325163521?lang=en
We would like to be able to store the results of our test to a log file, or if possible create a json file that can be used for reporting.
How do we do this without storing the file to the mobile test device and instead save the logs on our machine?
| a: tests,c: new feature,tool,P3,team-tool,triaged-tool | low | Minor |
471,397,908 | youtube-dl | Linkedin Learning is broken again, extractor error caused by KeyError('JSESSIONID') |
## Checklist
- [x] I'm reporting a broken site support
- [x] I've verified that I'm running youtube-dl version **2019.07.16**
- [x] I've checked that all provided URLs are alive and playable in a browser
- [x] I've checked that all URLs and arguments with special characters are properly quoted or escaped
- [x] I've searched the bugtracker for similar issues including closed ones
## Verbose log
```
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['--cookies', 'cookies.txt', 'https://www.linkedin.com/learning/c-plus-plus-essential-training-2', '--verbose']
[debug] Encodings: locale UTF-8, fs utf-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2019.07.16
[debug] Python version 3.7.3 (CPython) - Darwin-18.7.0-x86_64-i386-64bit
[debug] exe versions: ffmpeg 4.1.4, ffprobe 4.1.4, rtmpdump 2.4
[debug] Proxy map: {}
ERROR: An extractor error has occurred. (caused by KeyError('JSESSIONID')); please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type youtube-dl -U to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
Traceback (most recent call last):
File "/usr/local/bin/youtube-dl/youtube_dl/extractor/common.py", line 530, in extract
ie_result = self._real_extract(url)
File "/usr/local/bin/youtube-dl/youtube_dl/extractor/linkedin.py", line 158, in _real_extract
course_data = self._call_api(course_slug, 'chapters,description,title')
File "/usr/local/bin/youtube-dl/youtube_dl/extractor/linkedin.py", line 36, in _call_api
'Csrf-Token': self._get_cookies(api_url)['JSESSIONID'].value,
KeyError: 'JSESSIONID'
Traceback (most recent call last):
File "/usr/local/bin/youtube-dl/youtube_dl/extractor/common.py", line 530, in extract
ie_result = self._real_extract(url)
File "/usr/local/bin/youtube-dl/youtube_dl/extractor/linkedin.py", line 158, in _real_extract
course_data = self._call_api(course_slug, 'chapters,description,title')
File "/usr/local/bin/youtube-dl/youtube_dl/extractor/linkedin.py", line 36, in _call_api
'Csrf-Token': self._get_cookies(api_url)['JSESSIONID'].value,
KeyError: 'JSESSIONID'
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/usr/local/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 796, in extract_info
ie_result = ie.extract(url)
File "/usr/local/bin/youtube-dl/youtube_dl/extractor/common.py", line 543, in extract
raise ExtractorError('An extractor error has occurred.', cause=e)
youtube_dl.utils.ExtractorError: An extractor error has occurred. (caused by KeyError('JSESSIONID')); please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type youtube-dl -U to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
```
## Description
I think Linkedin-Learning has changed its website design again, which is making `youtube-dl` unable to download any playlists from the website. I was trying the following among others.
```youtube-dl --cookies cookies.txt https://www.linkedin.com/learning/c-plus-plus-essential-training-2```
It fails for every course on Linkedin-Learning. I have an active subscription and I can view the videos online, but having downloaded the cookies after logging in, I wanted to have the course offline. Seems like `youtube-dl` fails to help me there. | account-needed | low | Critical |
471,412,577 | flutter | 'flutter run widget_test.dart' does not end the running process after all the tests have completed. | Following the advise here https://twitter.com/flutterdev/status/1038114431325163521?lang=en does run our widget test on the device. However the process just keeps on running.
Is there any additional info that would end the process after the widget tests are completed?
Thanks.
| a: tests,tool,d: stackoverflow,P3,team-tool,triaged-tool | low | Minor |
471,457,727 | godot | `MenuButton` ignores custom styles because it's `flat` by default | the menubutton's normal style don't seem to be rendering even though it's set to a the same texturestyle as the button below it
| enhancement,discussion,confirmed,topic:gui | low | Major |
471,492,850 | opencv | Opencv with cuda GpuMat::create() call causes access violation | Hi,
**I compiled (debug and release) opencv 4.1.0 with contrib modues and enabled cuda.**
I'm trying to create a GpuMat and upload host data from cv::Mat.
This works properly when running in debug mode. However when I run in release mode (even when turning off optimizations) I get an access violation in the GpuMat::create() function (gpu_mat.cu line 174):
`bool allocSuccess = allocator->allocate(this, rows, cols, esz);`
"Exception thrown: read access violation. this->allocator was 0x21A."
My code for creating the GpuMat:
`cv::Mat raw = cv::Mat(inImg->height, inImg->width, CV_16UC1, inImg->host_data);
g_inImg.create(inImg->height, inImg->width, CV_16UC1);`
The crash is only happens in Release mode.
Do anyone has a clue what could be the reason?
Thank you in advance.
| category: gpu/cuda (contrib),incomplete,needs investigation | low | Critical |
471,509,894 | pytorch | Libtorch with deeplabv3_resnet101 will not forward. | ## 🐛 Bug
When i convert the `deeplabv3_resnet101` model and use it in Libtorch, it gives a segmentation fault on forwarding.
## To Reproduce
Steps to reproduce the behavior:
1. convert the model using python:
```
import torch
import torchvision
from torchvision import models
deeplap_model = models.segmentation.deeplabv3_resnet101(pretrained=True)
deeplap_model.cuda()
deeplap_model.eval()
class wrapper(torch.nn.Module):
def __init__(self, model):
super(wrapper, self).__init__()
self.model = model
def forward(self, input):
results = []
output = self.model(input)
for k, v in output.items():
results.append(v)
return tuple(results)
model = wrapper(deeplap_model)
example = torch.rand(1, 3, 224, 224).cuda()
#example = torch.rand(1, 3, 224, 224)
# Use torch.jit.trace to generate a torch.jit.ScriptModule via tracing.
traced_script_module = torch.jit.trace(model, example)
traced_script_module.save("model.pt")
```
2.
Load the model in c++ and run an image through it.
```
std::shared_ptr<torch::jit::script::Module> module = torch::jit::load("model.pt");
module->to(torch::kCUDA);
assert(module != nullptr);
std::cout << "ok\n";
std::vector<torch::jit::IValue> inputs;
cv::Mat image;
image = cv::imread("pic.jpeg", 1);
cv::Mat image_resized;
cv::resize(image, image_resized, cv::Size(224, 224));
cv::cvtColor(image_resized, image_resized, cv::COLOR_BGR2RGB);
cv::Mat image_resized_float;
image_resized.convertTo(image_resized_float, CV_32F, 1.0 / 255);
auto img_tensor = torch::from_blob(image_resized_float.data, { 1, 224, 224, 3 }, torch::kFloat32);
cout << "img tensor loaded..\n";
img_tensor = img_tensor.permute({ 0, 3, 1, 2 });
img_tensor[0][0] = img_tensor[0][0].sub(0.485).div(0.229);
img_tensor[0][1] = img_tensor[0][1].sub(0.456).div(0.224);
img_tensor[0][2] = img_tensor[0][2].sub(0.406).div(0.225);
// to GPU
img_tensor = img_tensor.to(at::kCUDA);
torch::Tensor out_tensor2 = module->forward({ img_tensor }).toTensor(); //SEGFAULT
```
3.
Try with dummy test data:
```
std::shared_ptr<torch::jit::script::Module> module = torch::jit::load("model.pt");
module->to(torch::kCUDA);
assert(module != nullptr);
std::cout << "ok\n";
std::vector<torch::jit::IValue> inputs;
inputs.emplace_back(torch::rand({ 64, 3, 224, 224 }));
module->forward(inputs).toTensor(); //SEGFAULT
```
## Expected behavior
I would expect that i could run images, or data through the converted model in c++ and see the segmentation results.
## Environment
PyTorch version: 1.1.0
Is debug build: No
CUDA used to build PyTorch: 10.0
OS: Microsoft Windows 10 Home
GCC version: Could not collect
CMake version: version 3.12.3
Python version: 3.7
Is CUDA available: Yes
CUDA runtime version: 10.0.130
GPU models and configuration: Could not collect
Nvidia driver version: Could not collect
cuDNN version: C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v10.0\bin\cudnn64_7.dll
Versions of relevant libraries:
[pip3] numpy==1.16.4
[pip3] torch==1.1.0
[pip3] torchvision==0.3.0
| module: crash,module: cpp,triaged | low | Critical |
471,516,082 | flutter | How to make an aop package (aspectd) in a decent way? | This issue is related to https://github.com/flutter/flutter/pull/35803
Recently, I've developed a package aiming at implement the AOP(aspect oriented programming) feature for dart based on kernel-to-kernel transformation which is available at: https://github.com/alibaba-flutter/aspectd
A design diagram is given below:
Though it is expected to do aop without invasion, there is still one invasion point.
Given an app package(where original codes is given), aspectd requires a new aop package where aop codes are written, so that when compiling the aop package, both app and aop codes can be all compiled into the app.dill.
Henceforth, a hook is needed in the app building process(flutter_tools) so that aop package can be compiled when app package is compiled successfully, both in jit/aot mode.
After the aop package is compiled into dill successfully, a dill transformer is needed to extract the annotations and transform the component object so that aop feature can be implemented as expected.
More generally, different from gradle, design of flutter_tools make it hard for developers if they want to do inject some customized hooks before/after running flutter commands.
It would be better if a generalized way is provided.
Current patching logic to flutter_tools is given below:
a. build_aot.dart
b.build_bundle.dart
c.aspectd.dart
Not a problem as totally new.
cc @jonahwilliams
| c: new feature,tool,customer: alibaba,a: build,P3,team-tool,triaged-tool | medium | Critical |
471,592,684 | rust | Doc comments break proc_macro::SourceFile | Adding a doc comment before a procedural macro invocation causes [`proc_macro::SourceFile::path`](https://doc.rust-lang.org/proc_macro/struct.SourceFile.html#method.path) to return the path to lib.rs or main.rs instead of the actual path. The documentation states that if [`proc_macro::SourceFile::is_real`](https://doc.rust-lang.org/proc_macro/struct.SourceFile.html#method.is_real) returns false, the returned path may not be an actual path on the filesystem, but this is not the case(it returns true and the path is a real path). I originally found the issue in pustaczek/icie@53a9913.
I tried this code:
```rust
// src/lib.rs
pub mod sub;
```
```rust
// src/sub.rs
#[ohnodoc_codegen::sparklify]
pub fn without_doc_comment() -> i32 {
42
}
/// I'm a doc comment!
#[ohnodoc_codegen::sparklify]
pub fn with_doc_comment() -> i32 {
42
}
```
```rust
// ohnodoc-codegen/src/lib.rs
#![feature(proc_macro_span)]
extern crate proc_macro;
use proc_macro::TokenStream;
#[proc_macro_attribute]
pub fn sparklify(_params: TokenStream, item: TokenStream) -> TokenStream {
let source = item.clone().into_iter().next().unwrap().span().source_file();
eprintln!("path = {:?}, is_real = {:?}", source.path(), source.is_real());
item
}
```
I expected to see this happen: during compilation, these two lines are printed to stderr:
```
path = "src/sub.rs", is_real = true
path = "src/sub.rs", is_real = true
```
Instead, this happened: these two lines were printed:
```
path = "src/sub.rs", is_real = true
path = "src/lib.rs", is_real = true
```
## Meta
rustc 1.38.0-nightly (07e0c3651 2019-07-16)
binary: rustc
commit-hash: 07e0c3651ce2a7b326f7678e135d8d5bbbbe5d18
commit-date: 2019-07-16
host: x86_64-unknown-linux-gnu
release: 1.38.0-nightly
LLVM version: 8.0 | A-macros,T-compiler,C-bug | low | Minor |
471,593,929 | create-react-app | errors are coming wen i start | npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! [email protected] start: `react-scripts start`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the [email protected] start script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm ERR! A complete log of this run can be found in:
npm ERR! C:\Users\AnithaHR\AppData\Roaming\npm-cache\_logs\2019-07-23T09_40_13_120Z-debug.log | issue: bug | low | Critical |
471,616,604 | flutter | [webview_flutter] Support injecting `js` script `atDocumentStart` instead of `onload` | I am trying to create a `webview` in flutter so that web browser can inject some `js` code to the document before it loads (`atDocumentStart`).
I have tried several ways, but it always seems to inject the code too late (`onload`).
```dart
final String injectScript = ("some js code");
class WebPage extends StatefulWidget {
WebPage({Key key, this.title}) : super(key: key);
final String title;
@override
_WebPageState createState() => _WebPageState();
}
class _WebPageState extends State<WebPage> {
GlobalKey<ScaffoldState> scaffoldState;
bool isLoading = false;
final assetIdController = TextEditingController(text: "");
bool isValid = true;
static Completer<WebViewController> _webViewController =
Completer<WebViewController>();
@override
void initState() {
super.initState();
}
Widget favoriteButton() {
return FutureBuilder<WebViewController>(
future: _webViewController.future,
builder: (BuildContext context,
AsyncSnapshot<WebViewController> controller) {
if (controller.hasData) {
return FloatingActionButton(
onPressed: () async {
// TOO LATE HERE:
controller.data.evaluateJavascript(injectScript);
},
child: const Icon(Icons.refresh),
);
}
return Container();
});
}
@override
Widget build(BuildContext context) {
return new Scaffold(
key: scaffoldState,
appBar: AppBar(
centerTitle: true,
elevation: 0.0,
iconTheme: IconThemeData(color: Theme.of(context).primaryColor),
backgroundColor: Theme.of(context).canvasColor,
),
backgroundColor: const Color(0xFFF8F8F8),
body: WebView(
initialUrl: 'https://communities-qa.cln.network',
javascriptMode: JavascriptMode.unrestricted,
onWebViewCreated: (WebViewController webViewController) async {
// NOT WORKING HERE:
// await webViewController.evaluateJavascript(injectScript);
_webViewController.complete(webViewController);
},
),
floatingActionButton: favoriteButton(),);
}
}
```
I expect it to load the code before the page (the page relying on the evaluated code to run), but it is either too late or not working. | c: new feature,d: stackoverflow,p: webview,package,team-ecosystem,P3,triaged-ecosystem | low | Major |
471,637,348 | rust | absolute-paths-not-starting-with-crate warning emitted for macros from 2015 edition crates used in 2018 edition crates | See e.g.
```
warning: absolute paths must start with `self`, `super`, `crate`, or an external crate name in the 2018 edition
--> src/lib.rs:156:1
|
156 | / gst_plugin_define!(
157 | | ndi,
158 | | env!("CARGO_PKG_DESCRIPTION"),
159 | | plugin_init,
... |
165 | | env!("BUILD_REL_DATE")
166 | | );
| |__^
|
= note: `-W absolute-paths-not-starting-with-crate` implied by `-W rust-2018-compatibility`
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2018 edition!
= note: for more information, see issue #53130 <https://github.com/rust-lang/rust/issues/53130>
= note: this warning originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
```
The macro in question is declared by a 2015 edition crate and used in a 2018 edition crate.
Right now this is only annoying but if this ever becomes a hard error then using all 2015 crates as dependencies of an 2018 crate will be impossible, which was one of to promises of the editions system. | A-lints,A-macros,T-compiler,C-bug,A-edition-2018 | low | Critical |
471,637,900 | tensorflow | Potential bugs found with static analysis | <em>Please make sure that this is a bug. As per our [GitHub Policy](https://github.com/tensorflow/tensorflow/blob/master/ISSUES.md), we only address code/doc bugs, performance issues, feature requests and build/installation issues on GitHub. tag:bug_template</em>
**System information**
- Have I written custom code (as opposed to using a stock example script provided in TensorFlow): No
- OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Linux Ubuntu 16.04
- Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device: N/A
- TensorFlow installed from (source or binary): Source
- TensorFlow version (use command below): 1.14.0
- Python version: 2.7.12
- Bazel version (if compiling from source): 0.26.1
- GCC/Compiler version (if compiling from source): c++ (Ubuntu 5.4.0-6ubuntu1~16.04.9) 5.4.0 20160609
- CUDA/cuDNN version: N/A
- GPU model and memory: N/A
You can collect some of this information using our environment capture
[script](https://github.com/tensorflow/tensorflow/tree/master/tools/tf_env_collect.sh)
You can also obtain the TensorFlow version with: 1. TF 1.0: `python -c "import
tensorflow as tf; print(tf.GIT_VERSION, tf.VERSION)"` 2. TF 2.0: `python -c
"import tensorflow as tf; print(tf.version.GIT_VERSION, tf.version.VERSION)"`
**Describe the current behavior**
**Issue 1:**
https://github.com/tensorflow/tensorflow/blob/1ee51a3b868a3ccd5f80724f6b9389fd0a9aed07/tensorflow/compiler/tf2xla/functionalize_cond.cc#L445-L447
`dst_copy != nullptr` is checked immediately after `if (dst_copy == nullptr) continue;`. Is one of comparisons supposed to be different, or can the `TF_RET_CHECK` be removed?
**Issue 2:**
https://github.com/tensorflow/tensorflow/blob/9d67841e6c1f852516abf6ff44490b5d5a8331af/tensorflow/contrib/ignite/kernels/dataset/ignite_dataset_iterator.cc#L126-L128
This code is unreachable, because both branches of `if` above return. Either it should be deleted or some part of `if` modified.
**Issue 3:**
https://github.com/tensorflow/tensorflow/blob/514004a2347058214d1e7b13b9769a2abdd06830/tensorflow/core/profiler/rpc/client/capture_profile.cc#L218-L220
The condition is always true. My guess is that `==` is intended instead of `!=`.
**Issue 4:**
https://github.com/tensorflow/tensorflow/blob/9590c4c32dd4346ea5c35673336f5912c6072bf2/tensorflow/core/profiler/internal/tfprof_tensor.h#L55
Should this be `void` since nothing gets returned in any branch?
**Issue 5:**
https://github.com/tensorflow/tensorflow/blob/9380a41290e8fb8b9ea85f614472deab56dbc481/tensorflow/stream_executor/stream_executor_pimpl.cc#L112-L125
`ScopedTracer` doesn't obey the rule of 3, but this `SCOPED_TRACE` macro expands to calling its copy constructor. This should be safe in practice because of copy elision, I believe, but undesirable to rely on. Unfortunately, changing to `auto tracer{MakeScopedTracer(this, &LOC##Begin, &LOC##Complete, ##__VA_ARGS__)};` will infer `initializer_list<...>` (is that right?).
**Describe the expected behavior**
**Code to reproduce the issue**
Provide a reproducible test case that is the bare minimum necessary to generate the problem.
**Other info / logs**
Include any logs or source code that would be helpful to diagnose the problem. If including tracebacks, please include the full traceback. Large logs and files should be attached.
| stat:awaiting tensorflower,type:bug,TF 1.13,comp:core | low | Critical |
471,668,632 | create-react-app | Set webpack cfg devtool property to 'nosources-source-map' | ### Webpack cfg devtool property other than: 'cheap-module-source-map', 'source-map' or false
This is mostly frustrating for production build where I'd like to have possibility to set devtool='nosources-source-map' or other less specific source-map
Now devtool is calculated as below:
```
devtool: isEnvProduction
? shouldUseSourceMap
? 'source-map'
: false
: isEnvDevelopment && 'cheap-module-source-map',
```
so there is no chance to override devtool value either for development nor production mode.
| issue: proposal | low | Major |
471,753,028 | pytorch | Consolidate multiprocessing helpers in distributed tests | We have a few test files where we rely on multiprocessing to setup a distributed context:
* `test/test_c10d.py`
* `test/test_c10d_spawn.py`
* `test/test_distributed.py`
The helpers should be consolidated in a single base test class or set of helper functions.
cc @mrshenli since we spoke about it in person. | oncall: distributed,triaged | low | Minor |
471,753,758 | angular | Hook into router config loading | <!--🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅
Oh hi there! 😄
To expedite issue processing please search open and closed issues before submitting a new one.
Existing issues often contain information about workarounds, resolution, or progress updates.
🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅-->
# 🚀 feature request
### Relevant Package
This feature request is for @angular/router
### Description
[Router.resetConfig](https://angular.io/api/router/Router#resetConfig) allows you to basically post process router at application startup - e.g. replace static placeholders, translate urls, mass add route data etc.). However you don't get a chance to do this for lazy loaded components.
### Describe the solution you'd like
Add some possibility to hook into the `RouterConfigLoader` when routes from the child modules are processed (e.g. a provider that would be called with the routes resolved from the just loaded module's injector - https://github.com/angular/angular/blob/master/packages/router/src/router_config_loader.ts#L43).
### Describe alternatives you've considered
The way to get around this is implemented in [localized-router](https://github.com/Greentube/localize-router): https://github.com/Greentube/localize-router/blob/master/src/localize-router-config-loader.ts. This is a hack in the first place and will not work with the new loadChildren syntax.
The solution which would support also the new syntax is here: https://github.com/gilsdav/ngx-translate-router/blob/master/projects/ngx-translate-router/src/lib/localized-router.ts which is an even bigger hack.
/cc @gilsdav @meeroslav Pls comment if you have any thoughts on this.
| feature,freq1: low,area: router,feature: under consideration,canonical | low | Major |
471,800,025 | pytorch | Unofficial ARMv6, ARMv7, ARMv8 builds | Hello everyone,
just wanted to let you know that I started this repo:
https://github.com/nmilosev/pytorch-arm-builds
which contains builds for ARM devices and some inference tests. Everything is working good, it would maybe be nice to put this link somewhere visible so that people know it exists. I intend to update this with every pytorch and torchvision release.
Hope this is ok.
Thanks for everything! :) | module: build,module: docs,triaged | medium | Major |
471,834,244 | node | Contexts created with vm.createContext() do not define the URL() constructor | <!--
Thank you for reporting a possible bug in Node.js.
Please fill in as much of the template below as you can.
Version: output of `node -v`
Platform: output of `uname -a` (UNIX), or version and 32 or 64-bit (Windows)
Subsystem: if known, please specify the affected core module name
If possible, please provide code that demonstrates the problem, keeping it as
simple and free of external dependencies as you can.
-->
* **Version**: v12.6.0 (also seen in 10.13.0)
* **Platform**: Darwin Davids-MacBook-Pro.local 18.5.0 Darwin Kernel Version 18.5.0: Mon Mar 11 20:40:32 PDT 2019; root:xnu-4903.251.3~3/RELEASE_X86_64 x86_64
* **Subsystem**:
<!-- Please provide more details below this comment. -->
I've created a simple testing framework that runs tests using vm.Script.runInContext(). Now I'm writing tests for code that uses the whatwg URL API. If I use `vm.createContext()`, the created context does not define the URL() constructor. But if I pass in the URL constructor with `vm.createContext({URL})`, then I have a situation where arrays returned by URLSearchParams methods are defined using the Array.prototype object from outside the context, and my tests are trying to compare those to arrays defined inside the context with a different Array.prototype object. So because I have two arrays with different prototypes, `assert.deepStrictEqual()` thinks they are not the same.
I'd argue that the underlying bug here is that URL should be automatically defined in newly created contexts without having to be passed in. Or maybe this is a bug in `assert.deepStrictEqual()` and it is stricter than it ought to be in this cross-context situation?
In any case, here is an example that reproduces the issue for me:
```
const vm = require('vm');
// URL is not defined inside the context, and I can't require it, so
// I need to pass it to the context from outside. But it returns arrays
// using the Array class from outside the context.
let context = vm.createContext({require, URL, externalArray:Array});
let script = new vm.Script(`
const assert = require('assert');
let url = new URL('http://example.com');
url.searchParams.append('x', '1');
url.searchParams.append('x', '2');
let actual = url.searchParams.getAll('x'); // Uses array class from outside
let expected = ['1', '2']; // Uses array class from inside
assert(Array.isArray(actual)); // passes
assert.deepStrictEqual(Array.from(actual), expected); // passes
assert.deepStrictEqual(actual, externalArray.from(expected)); // passes
assert.deepStrictEqual([...actual], expected); // passes
assert.deepStrictEqual(actual, expected); // fails
assert.equal(Object.getPrototypeOf(actual), // also fails
Object.getPrototypeOf(expected));
`);
script.runInContext(context);
```
| vm,feature request,never-stale,realm | medium | Critical |
471,834,311 | vscode | Git - Revert changes on a hunk sometimes corrupt entire files | - VSCode Version: 1.35.1
- OS Version: Fedora 30
- git version: 2.21.0
Steps to Reproduce:
There are no steps to easily reproduce this bug. Once it happens, I can reproduce it until I restart VSCode. Restarting code does "fix" this until it happens again. It has been happening to me about once a month for over a year since well before 1.34.0. I am constantly updating vscode, and the bug constantly keeps happening. When it does happen:
1. I click in the gutter to see the git differences
2. I decide I want to revert that line and then
3. Changes all over the file are applied. While I can "undo", this can be dangerous when I don't notice the entire file was just corrupted.
4. Ctrl+Z and repeating will cause it to happen again and again. So once it happens, it is repeatable until I restart VSCode
I do a lot of git on the CLI, but I can't figure out if I do anything to make this happen. In this particularly well documented case, here's what happened this time:
1. I have been editing a lot of files, adding and committing from the git CLI
1. The git status was clean, no uncommitted changes.
1. I **opened** `executor.py` and I notices that the gutter said I had 7 hunks modified through out the file. I thought that was odd, since I knew my git environment was clean, and so I "viewed" the hunks to see what the changes were.
1. The totality of the changes were from changes that I **committed** on The 22nd, 19th, and 17th
1. I started VSCode at 1:15 PM on July 17th.
1. I believe I also rebased this particular branch on July 17th too. I'm fuzzy on the exact timing for that.
1. I saw the 7 changes, reverted one, and noticed I got this same file corruptuption error that I've been trying to replicate so I can make this issue. I saved:
- The [original file](https://pastebin.com/iFfP0sVA) The file as it was committed on the 22nd
- The [file1](https://pastebin.com/Mt97VErs) after I reverted the very first hunk change, which should have just been a space
- The [file2](https://pastebin.com/w5gA4yv2) after I Ctrl+Z the previous and reverted just the second hunk change
- The [file3](https://pastebin.com/PcFmNvRT) after only the third hunk
- The [file4](https://pastebin.com/ymfZaBNA) after only the forth hunk
If you diff these, you will see that ever hunk that I didn't revert, was duplicated on a later line. This has happened to me several times in the past, and the effects are not always as trivial.
For example, the diff from the original to file1 should be
```
59c59
< 'implementation changed?')
---
> 'implementation changed?')
```
But is instead
```
61c61
< # Is not running nor revoked nor finished :/
---
> 'implementation changed?')
129c129
< if not fut.cancel(): # pragma: no cover
---
> logger.debug1('Celery task "%s" canceled.', ar.id)
137c137
< fut.set_running_or_notify_cancel()
---
> logger.debug1('Celery task "%s" running.', ar.id)
143c143
< # Future is FINISHED
---
> logger.debug1('Celery task "%s" resolved.', ar.id)
148c148
< # Future is FINISHED
---
> logger.debug1('Celery task "%s" resolved with error.', ar.id)
194c194
< pass
---
> except RuntimeError: # pragma: no cover
```
**Notice**: The line numbers are off by 2
Other info:
- I'm working in a submodule, I'm almost always working with submodules
- The "Source Control" pan in VSCode shows the correct branch name for the submodule, `unit19_rebase1`
- I do have GitLens, but this part of vscode is [unrelated to GitLens](https://github.com/eamodio/vscode-gitlens/issues/759)
- The ↻ in the git window doesn't help any.
- I checked out detached head, and now the Source Control Providers area shows the correct sha, not just the branch name. So VSCode does know the right sha, but still produces this error
- I closed the file and opened it again (Leaving VSCode open the whole time) and the problem continues to reproduce.
- Restarting VSCode did make the problem go away (until it happens again)
<!-- Launch with `code --disable-extensions` to check. -->
Does this issue occur when all extensions are disabled?: Cannot test, as this bug is too rare, and restarting makes it go away until the next time it occurs. Currently, I've been running VSCode for 5 days (no sleep or hibernation)
| bug,help wanted,git | low | Critical |
471,838,286 | pytorch | UBSAN failure in test_simple_model (__main__.TestTensorBoardNumpy): runtime error: call to function pybind11::class_<caffe2::GradientWrapper>::dealloc(pybind11::detail::value_and_holder&) through pointer to incorrect function type 'void (*)(pybind11::detail::value_and_holder &)' | ```
Jul 23 16:50:24 test_simple_model (__main__.TestTensorBoardNumpy) ... /var/lib/jenkins/workspace/torch/../third_party/pybind11/include/pybind11/detail/class.h:327:17: runtime error: call to function pybind11::class_<caffe2::GradientWrapper>::dealloc(pybind11::detail::value_and_holder&) through pointer to incorrect function type 'void (*)(pybind11::detail::value_and_holder &)'
Jul 23 16:50:24 (/opt/conda/lib/python3.6/site-packages/caffe2/python/caffe2_pybind11_state.cpython-36m-x86_64-linux-gnu.so+0x3a99f0): note: pybind11::class_<caffe2::GradientWrapper>::dealloc(pybind11::detail::value_and_holder&) defined here
Jul 23 16:50:24 #0 0x7f5fcda660a9 in pybind11::detail::clear_instance(_object*) (/opt/conda/lib/python3.6/site-packages/torch/lib/libtorch_python.so+0xf5a0a9)
Jul 23 16:50:24 #1 0x7f5fcda46928 in pybind11_object_dealloc (/opt/conda/lib/python3.6/site-packages/torch/lib/libtorch_python.so+0xf3a928)
Jul 23 16:50:24 #2 0x55da3270f531 in list_dealloc /tmp/build/80754af9/python_1546130271559/work/Objects/listobject.c:326
Jul 23 16:50:24 #3 0x55da327df477 in _PyEval_EvalFrameDefault /tmp/build/80754af9/python_1546130271559/work/Python/ceval.c:1308
Jul 23 16:50:24 #4 0x55da327afbfd in _PyEval_EvalCodeWithName /tmp/build/80754af9/python_1546130271559/work/Python/ceval.c:4166
Jul 23 16:50:24 #5 0x55da327b0770 in fast_function /tmp/build/80754af9/python_1546130271559/work/Python/ceval.c:4992
Jul 23 16:50:24 #6 0x55da327b6504 in call_function /tmp/build/80754af9/python_1546130271559/work/Python/ceval.c:4872
Jul 23 16:50:24 #7 0x55da327db389 in _PyEval_EvalFrameDefault /tmp/build/80754af9/python_1546130271559/work/Python/ceval.c:3335
Jul 23 16:50:24 #8 0x55da327b053a in _PyFunction_FastCall /tmp/build/80754af9/python_1546130271559/work/Python/ceval.c:4933
Jul 23 16:50:24 #9 0x55da327b053a in fast_function /tmp/build/80754af9/python_1546130271559/work/Python/ceval.c:4968
Jul 23 16:50:24 #10 0x55da327b6504 in call_function /tmp/build/80754af9/python_1546130271559/work/Python/ceval.c:4872
Jul 23 16:50:24 #11 0x55da327db389 in _PyEval_EvalFrameDefault /tmp/build/80754af9/python_1546130271559/work/Python/ceval.c:3335
Jul 23 16:50:24 #12 0x55da327afbfd in _PyEval_EvalCodeWithName /tmp/build/80754af9/python_1546130271559/work/Python/ceval.c:4166
Jul 23 16:50:24 #13 0x55da327b0770 in fast_function /tmp/build/80754af9/python_1546130271559/work/Python/ceval.c:4992
Jul 23 16:50:24 #14 0x55da327b6504 in call_function /tmp/build/80754af9/python_1546130271559/work/Python/ceval.c:4872
Jul 23 16:50:24 #15 0x55da327db389 in _PyEval_EvalFrameDefault /tmp/build/80754af9/python_1546130271559/work/Python/ceval.c:3335
Jul 23 16:50:24 #16 0x55da327b053a in _PyFunction_FastCall /tmp/build/80754af9/python_1546130271559/work/Python/ceval.c:4933
Jul 23 16:50:24 #17 0x55da327b053a in fast_function /tmp/build/80754af9/python_1546130271559/work/Python/ceval.c:4968
Jul 23 16:50:24 #18 0x55da327b6504 in call_function /tmp/build/80754af9/python_1546130271559/work/Python/ceval.c:4872
Jul 23 16:50:24 #19 0x55da327db389 in _PyEval_EvalFrameDefault /tmp/build/80754af9/python_1546130271559/work/Python/ceval.c:3335
Jul 23 16:50:24 #20 0x55da327af8e3 in _PyEval_EvalCodeWithName /tmp/build/80754af9/python_1546130271559/work/Python/ceval.c:4166
Jul 23 16:50:24 #21 0x55da327b0770 in fast_function /tmp/build/80754af9/python_1546130271559/work/Python/ceval.c:4992
Jul 23 16:50:24 #22 0x55da327b6504 in call_function /tmp/build/80754af9/python_1546130271559/work/Python/ceval.c:4872
Jul 23 16:50:24 #23 0x55da327db389 in _PyEval_EvalFrameDefault /tmp/build/80754af9/python_1546130271559/work/Python/ceval.c:3335
Jul 23 16:50:24 #24 0x55da327af8e3 in _PyEval_EvalCodeWithName /tmp/build/80754af9/python_1546130271559/work/Python/ceval.c:4166
Jul 23 16:50:24 #25 0x55da327b0e69 in _PyFunction_FastCallDict /tmp/build/80754af9/python_1546130271559/work/Python/ceval.c:5084
Jul 23 16:50:24 #26 0x55da3272fb0e in _PyObject_FastCallDict /tmp/build/80754af9/python_1546130271559/work/Objects/abstract.c:2310
Jul 23 16:50:24 #27 0x55da327346a2 in _PyObject_Call_Prepend /tmp/build/80754af9/python_1546130271559/work/Objects/abstract.c:2373
Jul 23 16:50:24 #28 0x55da3272f54d in PyObject_Call /tmp/build/80754af9/python_1546130271559/work/Objects/abstract.c:2261
Jul 23 16:50:24 #29 0x55da327dca6b in do_call_core /tmp/build/80754af9/python_1546130271559/work/Python/ceval.c:5120
Jul 23 16:50:24 #30 0x55da327dca6b in _PyEval_EvalFrameDefault /tmp/build/80754af9/python_1546130271559/work/Python/ceval.c:3404
Jul 23 16:50:24 #31 0x55da327af8e3 in _PyEval_EvalCodeWithName /tmp/build/80754af9/python_1546130271559/work/Python/ceval.c:4166
Jul 23 16:50:24 #32 0x55da327b0770 in fast_function /tmp/build/80754af9/python_1546130271559/work/Python/ceval.c:4992
Jul 23 16:50:24 #33 0x55da327b6504 in call_function /tmp/build/80754af9/python_1546130271559/work/Python/ceval.c:4872
Jul 23 16:50:24 #34 0x55da327dc146 in _PyEval_EvalFrameDefault /tmp/build/80754af9/python_1546130271559/work/Python/ceval.c:3351
Jul 23 16:50:24 #35 0x55da327b053a in _PyFunction_FastCall /tmp/build/80754af9/python_1546130271559/work/Python/ceval.c:4933
Jul 23 16:50:24 #36 0x55da327b053a in fast_function /tmp/build/80754af9/python_1546130271559/work/Python/ceval.c:4968
Jul 23 16:50:24 #37 0x55da327b6504 in call_function /tmp/build/80754af9/python_1546130271559/work/Python/ceval.c:4872
Jul 23 16:50:24 #38 0x55da327db389 in _PyEval_EvalFrameDefault /tmp/build/80754af9/python_1546130271559/work/Python/ceval.c:3335
Jul 23 16:50:24 #39 0x55da327af8e3 in _PyEval_EvalCodeWithName /tmp/build/80754af9/python_1546130271559/work/Python/ceval.c:4166
Jul 23 16:50:24 #40 0x55da327b0e69 in _PyFunction_FastCallDict /tmp/build/80754af9/python_1546130271559/work/Python/ceval.c:5084
Jul 23 16:50:24 #41 0x55da3272fb0e in _PyObject_FastCallDict /tmp/build/80754af9/python_1546130271559/work/Objects/abstract.c:2310
Jul 23 16:50:24 #42 0x55da327346a2 in _PyObject_Call_Prepend /tmp/build/80754af9/python_1546130271559/work/Objects/abstract.c:2373
Jul 23 16:50:24 #43 0x55da3272f54d in PyObject_Call /tmp/build/80754af9/python_1546130271559/work/Objects/abstract.c:2261
Jul 23 16:50:24 #44 0x55da327dca6b in do_call_core /tmp/build/80754af9/python_1546130271559/work/Python/ceval.c:5120
Jul 23 16:50:24 #45 0x55da327dca6b in _PyEval_EvalFrameDefault /tmp/build/80754af9/python_1546130271559/work/Python/ceval.c:3404
Jul 23 16:50:24 #46 0x55da327af8e3 in _PyEval_EvalCodeWithName /tmp/build/80754af9/python_1546130271559/work/Python/ceval.c:4166
Jul 23 16:50:24 #47 0x55da327b0c4b in _PyFunction_FastCallDict /tmp/build/80754af9/python_1546130271559/work/Python/ceval.c:5084
Jul 23 16:50:24 #48 0x55da3272fb0e in _PyObject_FastCallDict /tmp/build/80754af9/python_1546130271559/work/Objects/abstract.c:2310
Jul 23 16:50:24 #49 0x55da327346a2 in _PyObject_Call_Prepend /tmp/build/80754af9/python_1546130271559/work/Objects/abstract.c:2373
Jul 23 16:50:24 #50 0x55da3272f54d in PyObject_Call /tmp/build/80754af9/python_1546130271559/work/Objects/abstract.c:2261
Jul 23 16:50:24 #51 0x55da32789a90 in slot_tp_call /tmp/build/80754af9/python_1546130271559/work/Objects/typeobject.c:6207
Jul 23 16:50:24 #52 0x55da3272f92a in _PyObject_FastCallDict /tmp/build/80754af9/python_1546130271559/work/Objects/abstract.c:2331
Jul 23 16:50:24 #53 0x55da327b657d in call_function /tmp/build/80754af9/python_1546130271559/work/Python/ceval.c:4875
Jul 23 16:50:24 #54 0x55da327db389 in _PyEval_EvalFrameDefault /tmp/build/80754af9/python_1546130271559/work/Python/ceval.c:3335
Jul 23 16:50:24 #55 0x55da327af8e3 in _PyEval_EvalCodeWithName /tmp/build/80754af9/python_1546130271559/work/Python/ceval.c:4166
Jul 23 16:50:24 #56 0x55da327b0e69 in _PyFunction_FastCallDict /tmp/build/80754af9/python_1546130271559/work/Python/ceval.c:5084
Jul 23 16:50:24 #57 0x55da3272fb0e in _PyObject_FastCallDict /tmp/build/80754af9/python_1546130271559/work/Objects/abstract.c:2310
Jul 23 16:50:24 #58 0x55da327346a2 in _PyObject_Call_Prepend /tmp/build/80754af9/python_1546130271559/work/Objects/abstract.c:2373
Jul 23 16:50:24 #59 0x55da3272f54d in PyObject_Call /tmp/build/80754af9/python_1546130271559/work/Objects/abstract.c:2261
Jul 23 16:50:24 #60 0x55da327dca6b in do_call_core /tmp/build/80754af9/python_1546130271559/work/Python/ceval.c:5120
Jul 23 16:50:24 #61 0x55da327dca6b in _PyEval_EvalFrameDefault /tmp/build/80754af9/python_1546130271559/work/Python/ceval.c:3404
Jul 23 16:50:24 #62 0x55da327af8e3 in _PyEval_EvalCodeWithName /tmp/build/80754af9/python_1546130271559/work/Python/ceval.c:4166
Jul 23 16:50:24 #63 0x55da327b0c4b in _PyFunction_FastCallDict /tmp/build/80754af9/python_1546130271559/work/Python/ceval.c:5084
Jul 23 16:50:24 #64 0x55da3272fb0e in _PyObject_FastCallDict /tmp/build/80754af9/python_1546130271559/work/Objects/abstract.c:2310
Jul 23 16:50:24 #65 0x55da327346a2 in _PyObject_Call_Prepend /tmp/build/80754af9/python_1546130271559/work/Objects/abstract.c:2373
Jul 23 16:50:24 #66 0x55da3272f54d in PyObject_Call /tmp/build/80754af9/python_1546130271559/work/Objects/abstract.c:2261
Jul 23 16:50:24 #67 0x55da32789a90 in slot_tp_call /tmp/build/80754af9/python_1546130271559/work/Objects/typeobject.c:6207
Jul 23 16:50:24 #68 0x55da3272f92a in _PyObject_FastCallDict /tmp/build/80754af9/python_1546130271559/work/Objects/abstract.c:2331
Jul 23 16:50:24 #69 0x55da327b657d in call_function /tmp/build/80754af9/python_1546130271559/work/Python/ceval.c:4875
Jul 23 16:50:24 #70 0x55da327db389 in _PyEval_EvalFrameDefault /tmp/build/80754af9/python_1546130271559/work/Python/ceval.c:3335
Jul 23 16:50:24 #71 0x55da327af8e3 in _PyEval_EvalCodeWithName /tmp/build/80754af9/python_1546130271559/work/Python/ceval.c:4166
Jul 23 16:50:24 #72 0x55da327b0e69 in _PyFunction_FastCallDict /tmp/build/80754af9/python_1546130271559/work/Python/ceval.c:5084
Jul 23 16:50:24 #73 0x55da3272fb0e in _PyObject_FastCallDict /tmp/build/80754af9/python_1546130271559/work/Objects/abstract.c:2310
Jul 23 16:50:24 #74 0x55da327346a2 in _PyObject_Call_Prepend /tmp/build/80754af9/python_1546130271559/work/Objects/abstract.c:2373
Jul 23 16:50:24 #75 0x55da3272f54d in PyObject_Call /tmp/build/80754af9/python_1546130271559/work/Objects/abstract.c:2261
Jul 23 16:50:24 #76 0x55da327dca6b in do_call_core /tmp/build/80754af9/python_1546130271559/work/Python/ceval.c:5120
Jul 23 16:50:24 #77 0x55da327dca6b in _PyEval_EvalFrameDefault /tmp/build/80754af9/python_1546130271559/work/Python/ceval.c:3404
Jul 23 16:50:24 #78 0x55da327af8e3 in _PyEval_EvalCodeWithName /tmp/build/80754af9/python_1546130271559/work/Python/ceval.c:4166
Jul 23 16:50:24 #79 0x55da327b0c4b in _PyFunction_FastCallDict /tmp/build/80754af9/python_1546130271559/work/Python/ceval.c:5084
Jul 23 16:50:24 #80 0x55da3272fb0e in _PyObject_FastCallDict /tmp/build/80754af9/python_1546130271559/work/Objects/abstract.c:2310
Jul 23 16:50:24 #81 0x55da327346a2 in _PyObject_Call_Prepend /tmp/build/80754af9/python_1546130271559/work/Objects/abstract.c:2373
Jul 23 16:50:24 #82 0x55da3272f54d in PyObject_Call /tmp/build/80754af9/python_1546130271559/work/Objects/abstract.c:2261
Jul 23 16:50:24 #83 0x55da32789a90 in slot_tp_call /tmp/build/80754af9/python_1546130271559/work/Objects/typeobject.c:6207
Jul 23 16:50:24 #84 0x55da3272f92a in _PyObject_FastCallDict /tmp/build/80754af9/python_1546130271559/work/Objects/abstract.c:2331
Jul 23 16:50:24 #85 0x55da327b657d in call_function /tmp/build/80754af9/python_1546130271559/work/Python/ceval.c:4875
Jul 23 16:50:24 #86 0x55da327db389 in _PyEval_EvalFrameDefault /tmp/build/80754af9/python_1546130271559/work/Python/ceval.c:3335
Jul 23 16:50:24 #87 0x55da327b053a in _PyFunction_FastCall /tmp/build/80754af9/python_1546130271559/work/Python/ceval.c:4933
Jul 23 16:50:24 #88 0x55da327b053a in fast_function /tmp/build/80754af9/python_1546130271559/work/Python/ceval.c:4968
Jul 23 16:50:24 #89 0x55da327b6504 in call_function /tmp/build/80754af9/python_1546130271559/work/Python/ceval.c:4872
Jul 23 16:50:24 #90 0x55da327db389 in _PyEval_EvalFrameDefault /tmp/build/80754af9/python_1546130271559/work/Python/ceval.c:3335
Jul 23 16:50:24 #91 0x55da327b053a in _PyFunction_FastCall /tmp/build/80754af9/python_1546130271559/work/Python/ceval.c:4933
Jul 23 16:50:24 #92 0x55da327b053a in fast_function /tmp/build/80754af9/python_1546130271559/work/Python/ceval.c:4968
Jul 23 16:50:24 #93 0x55da327b6504 in call_function /tmp/build/80754af9/python_1546130271559/work/Python/ceval.c:4872
Jul 23 16:50:24 #94 0x55da327db389 in _PyEval_EvalFrameDefault /tmp/build/80754af9/python_1546130271559/work/Python/ceval.c:3335
Jul 23 16:50:24 #95 0x55da327afd70 in _PyEval_EvalCodeWithName /tmp/build/80754af9/python_1546130271559/work/Python/ceval.c:4166
Jul 23 16:50:24 #96 0x55da327b0e69 in _PyFunction_FastCallDict /tmp/build/80754af9/python_1546130271559/work/Python/ceval.c:5084
Jul 23 16:50:24 #97 0x55da3272fb0e in _PyObject_FastCallDict /tmp/build/80754af9/python_1546130271559/work/Objects/abstract.c:2310
Jul 23 16:50:24 #98 0x55da327346a2 in _PyObject_Call_Prepend /tmp/build/80754af9/python_1546130271559/work/Objects/abstract.c:2373
Jul 23 16:50:24 #99 0x55da3272f54d in PyObject_Call /tmp/build/80754af9/python_1546130271559/work/Objects/abstract.c:2261
Jul 23 16:50:24 #100 0x55da327890fa in slot_tp_init /tmp/build/80754af9/python_1546130271559/work/Objects/typeobject.c:6420
Jul 23 16:50:24 #101 0x55da327b6766 in type_call /tmp/build/80754af9/python_1546130271559/work/Objects/typeobject.c:915
Jul 23 16:50:24 #102 0x55da3272f92a in _PyObject_FastCallDict /tmp/build/80754af9/python_1546130271559/work/Objects/abstract.c:2331
Jul 23 16:50:24 #103 0x55da327b0a59 in _PyObject_FastCallKeywords /tmp/build/80754af9/python_1546130271559/work/Objects/abstract.c:2496
Jul 23 16:50:24 #104 0x55da327b657d in call_function /tmp/build/80754af9/python_1546130271559/work/Python/ceval.c:4875
Jul 23 16:50:24 #105 0x55da327dc146 in _PyEval_EvalFrameDefault /tmp/build/80754af9/python_1546130271559/work/Python/ceval.c:3351
Jul 23 16:50:24 #106 0x55da327afbfd in _PyEval_EvalCodeWithName /tmp/build/80754af9/python_1546130271559/work/Python/ceval.c:4166
Jul 23 16:50:24 #107 0x55da327b0770 in fast_function /tmp/build/80754af9/python_1546130271559/work/Python/ceval.c:4992
Jul 23 16:50:24 #108 0x55da327b6504 in call_function /tmp/build/80754af9/python_1546130271559/work/Python/ceval.c:4872
Jul 23 16:50:24 #109 0x55da327db389 in _PyEval_EvalFrameDefault /tmp/build/80754af9/python_1546130271559/work/Python/ceval.c:3335
Jul 23 16:50:24 #110 0x55da327b1288 in _PyEval_EvalCodeWithName /tmp/build/80754af9/python_1546130271559/work/Python/ceval.c:4166
Jul 23 16:50:24 #111 0x55da327b1288 in PyEval_EvalCodeEx /tmp/build/80754af9/python_1546130271559/work/Python/ceval.c:4187
Jul 23 16:50:24 #112 0x55da327b201b in PyEval_EvalCode /tmp/build/80754af9/python_1546130271559/work/Python/ceval.c:731
Jul 23 16:50:24 #113 0x55da328343c3 in run_mod /tmp/build/80754af9/python_1546130271559/work/Python/pythonrun.c:1025
Jul 23 16:50:24 #114 0x55da328347c0 in PyRun_FileExFlags /tmp/build/80754af9/python_1546130271559/work/Python/pythonrun.c:978
Jul 23 16:50:24 #115 0x55da328349c2 in PyRun_SimpleFileExFlags /tmp/build/80754af9/python_1546130271559/work/Python/pythonrun.c:419
Jul 23 16:50:24 #116 0x55da328384b2 in run_file /tmp/build/80754af9/python_1546130271559/work/Modules/main.c:340
Jul 23 16:50:24 #117 0x55da328384b2 in Py_Main /tmp/build/80754af9/python_1546130271559/work/Modules/main.c:811
Jul 23 16:50:24 #118 0x55da3270102d in main /tmp/build/80754af9/python_1546130271559/work/Programs/python.c:69
Jul 23 16:50:24 #119 0x7f5fe181c82f in __libc_start_main /build/glibc-LK5gWL/glibc-2.23/csu/../csu/libc-start.c:291
Jul 23 16:50:24 #120 0x55da327e1e0d in _start /home/rdonnelly/mc/conda-bld/compilers_linux-64_1534865402226/work/.build/src/glibc-2.12.2/csu/../sysdeps/x86_64/elf/start.S:103
Jul 23 16:50:24
Jul 23 16:50:24 SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior /var/lib/jenkins/workspace/torch/../third_party/pybind11/include/pybind11/detail/class.h:327:17 in
```
full log: https://circleci.com/gh/pytorch/pytorch/2255328?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link | module: tests,triaged | low | Critical |
471,840,741 | TypeScript | Narrower (literal) type for Function.prototype.name if function is const | ## Search Terms
<!-- List of keywords you searched for before creating this issue. Write them down here so that others can find this suggestion more easily -->
ES6 function name, const assertions, `as const`, function as const
## Suggestion
I would like to see the `name` property of functions to be available at compile time if the given function is a `const` expression, e.g.:
```typescript
class Test {
public a() { console.log("Test.a"); }
public b() { console.log("Test.b"); }
}
type FunctionWithName<N> = (...args: any[]) => any & { readonly name: N };
function replaceFunction<T, K extends keyof T>(target: T, fn: FunctionWithName<K>) {
target[fn.name] = fn;
}
// proposed inline syntax
let testInstance = new Test();
replaceFunction(testInstance, function a() { console.log("Replacement.a"); })
// proposed "as const" syntax
const newB = function b() {
console.log("Replacement.b");
} as const;
replaceFunction(testInstance, newB);
// example of a compile time error since "c" is not assignable to "a" | "b"
replaceFunction(testInstance, function c() { console.log("Replacement.a"); })
```
## Use Cases
My use case is a function like shown above, where I would like to have static type checking available, without having to specify the extra parameter that specifies the function name to replace, e.g. compare:
```typescript
// current syntax:
replaceFunction(testInstance, "a", function a() { /* ... */ });
// proposed syntax:
replaceFunction(testInstance, function a() { /* ... */ });
```
## Examples
```typescript
let myObject = {
a: () => "a",
b: () => "b"
}
// fictional "mocking" library:
// this syntax can only validate that "a" is in "myObject" through the const "a" parameter
mockingLibrary.mock(myObject, "a", function a() { return "different value" });
// proposed style, using Function.prototype.name
mockingLibrary.mock(myObject, function a() { return "different value" });
```
## Checklist
My suggestion meets these guidelines:
* [x] This wouldn't be a breaking change in existing TypeScript/JavaScript code
* [x] This wouldn't change the runtime behavior of existing JavaScript code
* [x] This could be implemented without emitting different JS based on the types of the expressions
* [x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
* [x] This feature would agree with the rest of [TypeScript's Design Goals](https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals).
| Suggestion,Awaiting More Feedback | low | Critical |
471,878,418 | flutter | [engine] support fragments in PlatformViews | `PlatformView` could have a variation to enable usage of fragments.
## Use case
Google maps plugin has to do a lot of lifecycle work by hand to enable the usage of `MapsView` that relies in a lifecycle. It could be avoided if the `PlatformView` was able to use `MapFragment` or `SupportMapFragment` that already deals with the lifecycle by themselves.
Other usages are libraries that provide a fragment to integrate, but not a view.
## Proposal
Flutter could provide a variation of PlatformView that has a method `getFragment()` instead of `getView()`.
There are a few tricks here as fragments can be committed with backstack or not. But in the simples case of no backstack would already help. | c: new feature,engine,a: platform-views,p: maps,package,c: proposal,P3,team-engine,triaged-engine | low | Major |
471,886,779 | flutter | DartLifecycleTest.ShuttingDownTheVMShutsDownAllIsolates is disabled due to flakiness. | Sample run of failure [is here](https://cirrus-ci.com/task/5709404777742336?command=test_host#L278). It probably indicates unsafe threading during VM shutdown. | a: tests,engine,P2,team-engine,triaged-engine | low | Critical |
471,890,696 | youtube-dl | Support for Sowndhaus | <!--
######################################################################
WARNING!
IGNORING THE FOLLOWING TEMPLATE WILL RESULT IN ISSUE CLOSED AS INCOMPLETE
######################################################################
-->
## Checklist
<!--
Carefully read and work through this check list in order to prevent the most common mistakes and misuse of youtube-dl:
- First of, make sure you are using the latest version of youtube-dl. Run `youtube-dl --version` and ensure your version is 2019.07.16. If it's not, see https://yt-dl.org/update on how to update. Issues with outdated version will be REJECTED.
- Make sure that all provided video/audio/playlist URLs (if any) are alive and playable in a browser.
- Make sure that site you are requesting is not dedicated to copyright infringement, see https://yt-dl.org/copyright-infringement. youtube-dl does not support such sites. In order for site support request to be accepted all provided example URLs should not violate any copyrights.
- Search the bugtracker for similar site support requests: http://yt-dl.org/search-issues. DO NOT post duplicates.
- Finally, put x into all relevant boxes (like this [x])
-->
- [x] I'm reporting a new site support request
- [x] I've verified that I'm running youtube-dl version **2019.07.16**
- [x] I've checked that all provided URLs are alive and playable in a browser
- [x] I've checked that none of provided URLs violate any copyrights
- [x] I've searched the bugtracker for similar site support requests including closed ones
## Example URLs
<!--
Provide all kinds of example URLs support for which should be included. Replace following example URLs by yours.
-->
- Single song: https://sowndhaus.audio/track/10669/quotthrill-herquot-kesha-vs-michael-jackson
- Artist profile: https://sowndhaus.audio/profile/gravedanger
- Filtered artist profile: https://sowndhaus.audio/profile/gravedanger/filter/201907
- Playlist: https://sowndhaus.audio/playlist/775/fran%C3%A7ais
## Description
<!--
Provide any additional information.
If work on your issue requires account credentials please provide them or explain how one can obtain them.
-->
Sowndhaus is a popular website for mashup artists.
| site-support-request | low | Critical |
471,891,608 | ant-design | Could span in Description List work as Grid? Auto floating to next line when the current total is larger than the number of columns | - [x] I have searched the [issues](https://github.com/ant-design/ant-design/issues) of this repository and believe that this is not a duplicate.
### What problem does this feature solve?
First, make the concept of span constantly crossing the whole design.
Secondly, it can be useful when the value of span on each description item is calculated at run time.
### What does the proposed API look like?
```jsx
<Descriptions title="User Info" column={4} layout="vertical">
<Descriptions.Item span={2} label="First Row">1-0</Descriptions.Item>
<Descriptions.Item span={1} label="First Row">1-1</Descriptions.Item>
{/** This item will be settled in second line */}
<Descriptions.Item span={4} label="Second Row">2-0</Descriptions.Item>
</Descriptions>
```
<!-- generated by ant-design-issue-helper. DO NOT REMOVE --> | Inactive | low | Minor |
471,895,616 | bitcoin | Assertion `setBlockIndexCandidates.count(pindex)' failed | This happened on travis as part of a pull request that only modified ATMP logic. So the assertion can likely also be hit on a clean master.
https://travis-ci.org/bitcoin/bitcoin/jobs/562128739#L4513 (in `rpc_invalidateblock.py`) | Bug,Validation | low | Critical |
471,915,167 | godot | High RAM usage | **Godot version:**
<!-- Specify commit hash if non-official. -->
Godot 3.1.1 stable
**OS/device including version:**
<!-- Specify GPU model and drivers if graphics-related. -->
Windows10 Pro 64bit
Intel HD graphics 4600
**Issue description:**
<!-- What happened, and what was expected. -->
On Godot version 3.0.6 stable memory usage was around stable 200-250 but in 3.1 it spiked to 700MB and even higher, i also tested 3.1 alpha versions and it seems to be already happening in Godot 3.1 Alpha1.
**Steps to reproduce:**
Create empty project and open it up.
Seems to be system/hardware specific not reproducible on all systems.
**Minimal reproduction project:**
It's literally just empty project.
<!-- Recommended as it greatly speeds up debugging. Drag and drop a zip archive to upload it. -->
| discussion,topic:core | low | Critical |
471,930,715 | rust | primitive docs should show core/alloc/std accessibility | In #61851, I tried to generate primitive docs in `core`, similar to those in `std`. My main motivation was to clearly see what `f64` methods are available in `core` alone, under `#[no_std]`, since a lot of them require `std` and `libm` support. However, I had trouble making that work because of broken documentation links between `core` and `std`-specific methods.
So I think instead, `rustdoc` could put some kind of marker on primitive methods to indicate what crate added them, so the accessibility is known. Apart from floating point, there are also a few slice methods that are only added in `alloc`. Maybe there are more that I don't know yet! | T-rustdoc,C-enhancement | low | Critical |
471,934,487 | opencv | PyRotationWarper creating incorrectly sized images | - OpenCV = 4.1.0-dev
- Operating System / Platform => Windows 32 Bit
- Compiler => Visual Studio 2017
##### Detailed description
PyRotationWarper in 'affine' mode is incorrectly sizing the outputs. For example, suppose that the input image has shape (300,400) (neglecting channels). If the post-warp image should be scaled up by 10% to (330, 440), the output is incorrectly scaled down by 10% (for example, to 270, 360).
My current mitigation zero-pads the inputs, and the results then fit into the given shape. The amount to zero pad is determined by calling warpRoi using the inverse of the warping matrix. It seems like this step is probably intended. Mitigation code is pasted below. I am eliding the code which performs feature matching and bundle adjustment to provide the camera params.
```.py
warper = cv2.PyRotationWarper('affine', warped_image_scale)
for i in range(len(images)):
cam, img, mask = cameras[i], images[i], masks[i]
K = cv2.UMat(cam.K().astype(np.float32))
R = cv2.UMat(cam.R.astype(np.float32))
if mode == 'affine':
scaleMat = cam.R.copy()
scaleMat[:2,:2] = np.linalg.inv(scaleMat[:2,:2])
scaleMat = cv2.UMat(scaleMat.astype(np.float32))
r, c = img.shape[:2]
newR, newC = warper.warpRoi((r,c), K, scaleMat)[2:]
newR = newR if newR >= r else r
newC = newC if newC >= c else c
blank = np.zeros((newR, newC, 3)).astype(np.uint8)
blank[:r, :c] = img
img = blank
maskBlank = np.zeros((newR, newC)).astype(np.uint8)
maskBlank[:r, :c] = mask
mask = maskBlank
corner, warp = warper.warp(img, K, R, interpMode, borderMode)
_, mask = warper.warp(mask, K, R, interpMode, borderMode)
```
##### Steps to reproduce
cameras, images, and masks are lists of equal length.
```.py
warper = cv2.PyRotationWarper('affine', warped_image_scale)
corners, warpImgs, warpMasks = [], [], []
for i in range(len(images)):
cam, img, mask = cameras[i], images[i], masks[i]
K = cv2.UMat(cam.K().astype(np.float32))
R = cv2.UMat(cam.R.astype(np.float32))
corner, warp = warper.warp(img, K, R, interpMode, borderMode)
_, mask = warper.warp(mask, K, R, interpMode, borderMode)
warp, mask = warp.get(), mask.get()
corners.append(corner)
warpImgs.append(warp)
warpMasks.append(mask)
```
| category: stitching | low | Minor |
471,939,083 | youtube-dl | [Suggestion] Say which ID of a video is unavailable | <!--
######################################################################
WARNING!
IGNORING THE FOLLOWING TEMPLATE WILL RESULT IN ISSUE CLOSED AS INCOMPLETE
######################################################################
-->
## Checklist
<!--
Carefully read and work through this check list in order to prevent the most common mistakes and misuse of youtube-dl:
- First of, make sure you are using the latest version of youtube-dl. Run `youtube-dl --version` and ensure your version is 2019.07.16. If it's not, see https://yt-dl.org/update on how to update. Issues with outdated version will be REJECTED.
- Search the bugtracker for similar feature requests: http://yt-dl.org/search-issues. DO NOT post duplicates.
- Finally, put x into all relevant boxes (like this [x])
-->
- [x] I'm reporting a feature request
- [x] I've verified that I'm running youtube-dl version **2019.07.16**
- [x] I've searched the bugtracker for similar feature requests including closed ones
## Description
<!--
Provide an explanation of your issue in an arbitrary form. Please make sure the description is worded well enough to be understood, see https://github.com/ytdl-org/youtube-dl#is-the-description-of-the-issue-itself-sufficient. Provide any additional information, suggested solution and as much context and examples as possible.
-->
When I run the following:
youtube-dl --get-id https://www.youtube.com/channel/UCN5xN8gIljvWYnsj06V8WbQ
or just any other youtube channel/playlist I might get an
"ERROR: This video is unavailable"
error within the results. That makes sense since some of the videos may be removed. However, I would like to find out what those video IDs are. Maybe something like the following:
"ERROR: This video is unavailable (SDvc3yf_sde)"
| request | low | Critical |
471,966,816 | TypeScript | Add broccoli-typescript-compiler to user test suite | https://github.com/tildeio/broccoli-typescript-compiler | Infrastructure,Fix Available | low | Minor |
472,003,541 | godot | Add the argument 'backwards' in the class AnimatedSprite as a property. | The variable 'backwards' doesn't have a getter neither a setter.
https://github.com/godotengine/godot/blob/master/scene/2d/animated_sprite.cpp#L730
Since the variable is private, right now you can't check if the current animation is playing backwards or not. So i propose adding a getter and setter to 'backwards' to solve this problem.
Also, in the documentation of AnimatedSprite (https://docs.godotengine.org/en/3.1/classes/class_animatedsprite.html#method-descriptions), it says that 'backwards' is a property, but is not present in the list of Properties (https://docs.godotengine.org/en/3.1/classes/class_animatedsprite.html#properties).
| enhancement,documentation | low | Major |
472,018,020 | flutter | Modernizing the "Missing Material" error | To take advantage of the new structured error API and the IDE's capability to display such errors in a concise format, we need to add necessary structure and metadata to the "Missing Material" error at https://github.com/flutter/flutter/blob/master/packages/flutter/lib/src/material/debug.dart#L27.
Here is what the final result could look like when the error is rendered in IntelliJ with an upcoming plugin release:
@jacob314 and @devoncarew have the context. | framework,f: material design,from: study,P2,team-design,triaged-design | low | Critical |
472,130,928 | vscode | [folding] Preserve folded ranges on revert | Editor losing folding status, when we doing git revert changes and scroll to top of the page
| feature-request,editor-folding | low | Minor |
472,151,231 | godot | -Woverloaded-virtual warnings | When adding a GCC warning `-Woverloaded-virtual` I see following warnings:
```
grep 'was hidden' build.log | sort | uniq
./core/os/dir_access.h:74:17: warning: 'virtual String DirAccess::get_next(bool*)' was hidden [-Woverloaded-virtual]
./core/script_language.h:170:18: warning: 'virtual Variant ScriptInstance::call(const StringName&, const Variant&, const Variant&, const Variant&, const Variant&, const Variant&)' was hidden [-Woverloaded-virtual]
./core/script_language.h:172:15: warning: 'virtual void ScriptInstance::call_multilevel(const StringName&, const Variant&, const Variant&, const Variant&, const Variant&, const Variant&)' was hidden [-Woverloaded-virtual]
./editor/plugins/abstract_polygon_2d_editor.h:132:15: warning: 'virtual void AbstractPolygon2DEditor::_action_set_polygon(int, const Variant&)' was hidden [-Woverloaded-virtual]
```
I'm also attaching full build log:
[build.txt](https://github.com/godotengine/godot/files/3425754/build.txt)
Note that the issue can cause serious issues as explained here:
https://isocpp.org/wiki/faq/strange-inheritance#hiding-rule | bug,topic:core,topic:buildsystem | low | Minor |
472,176,960 | pytorch | Add gatherv/allgatherv primitives to support non-equal contribution | ## 🚀 Feature
New operations `gatherv` and `allgatherv` to support gathering tensors of different shapes.
## Motivation
This is not uncommon (e.g. different size batches) and one has to jump through hoops to get this done today. Native support means a better user experience.
## Pitch
We'll add `gatherv` and `allgatherv` functions on the base `ProcessGroup` class and provide an implementation for every backend. The Gloo and MPI backends can implement this natively. The NCCL backend has to perform the padding trick (described below) under the hood to make this work.
## Alternatives
Currently, to do the same, you first need to establish the maximum number of elements across processes. Then you allocate a big output tensor to hold that maximum. Then you pad your local contribution, if necessary. Then you run a conventional gather/allgather. Finally you chop off the padding to get the result. All these steps
## Additional context
See https://discuss.pytorch.org/t/mpi-gatherv-and-mpi-scatterv-feature-request-idea/50878.
cc @pietern @mrshenli @pritamdamania87 @zhaojuanmao @satgera @rohan-varma @gqchen @aazzolini @xush6528 | oncall: distributed,module: bootcamp,feature,triaged | low | Minor |
472,220,639 | kubernetes | Allow for more frequent etcd compaction but still long-enough history in etcd | Currently, the etcd compaction algorithm that we use is as following:
- we store "etcd revision" from the moment of last compaction under a special key in etcd
- then periodically even N seconds/minutes we:
- compare to see if (local compact time) = (remote compact time)
- if yes, we increment both local and remote compact time to "now" and do a compaction
- if not, set local compact time to the remote one
This basically means, that for a given interval, we in etcd we store a history of length roughly between <interval, 2*interval>.
However, this is a significant issue that more frequent compaction means less history in etcd.
So for scalability and performance reasons, we would like to do compaction more frequently, but not necessary reduce amount of history in etcd.
So at the high level, I would like to be able to store a history of length roughly between <(N-1)*interval, N*interval>.
One potential option to do that would be to store last N values in "remote_compact_time", but there are probably better options to do that.
@jpbetz @jingyih @wenjiaswe @mborsz @xiang90 | sig/scalability,area/etcd,sig/api-machinery,kind/feature,lifecycle/frozen,sig/etcd | medium | Major |
472,246,854 | go | cmd/go: prune non-source files in 'go mod vendor' | <!-- Please answer these questions before submitting your issue. Thanks! -->
### What version of Go are you using (`go version`)?
<pre>
$ go version
go version go1.12.7 darwin/amd64
</pre>
### Does this issue reproduce with the latest release?
I would say that the issue is kind of enhancement or feature request rather than a bug. golang/dep has an option to prune non-go files under `vendor` with a config like:
```
[prune]
go-tests = true
unused-packages = true
non-go = true
```
### What operating system and processor architecture are you using (`go env`)?
<details><summary><code>go env</code> Output</summary><br><pre>
$ go env
</pre></details>
### What did you do?
```
# The go mod way:
$ mkdir gomod-example
$ cd gomod-example
$ go mod init github.com/ialidzhikov/gomod-example
```
`main.go`
```go
package main
import (
"fmt"
"github.com/ghodss/yaml"
)
func main() {
j := []byte(`{"name": "John", "age": 30}`)
y, err := yaml.JSONToYAML(j)
if err != nil {
fmt.Printf("err: %v\n", err)
return
}
fmt.Println(string(y))
/* Output:
name: John
age: 30
*/
j2, err := yaml.YAMLToJSON(y)
if err != nil {
fmt.Printf("err: %v\n", err)
return
}
fmt.Println(string(j2))
/* Output:
{"age":30,"name":"John"}
*/
}
```
```
$ go mod vendor
$ go mod tidy
$ ls -a vendor/github.com/ghodss/yaml/
./ ../ .gitignore .travis.yml LICENSE README.md fields.go yaml.go yaml_go110.go
```
Ensure that non-go files as `.gitignore`, `.travis.yml` and others are added under `vendor/` and currently there is no way to clean them.
On the other hand golang/dep with `non-go = true` option:
```
$ mkdir -p $GOPATH/src/github.com/ialidzhikov/dep-example
$ cd $GOPATH/src/github.com/ialidzhikov/dep-example
$ dep init
$ dep ensure -v
$ ls -a vendor/github.com/ghodss/yaml/
./ ../ LICENSE fields.go yaml.go
```
<!--
If possible, provide a recipe for reproducing the error.
A complete runnable program is good.
A link on play.golang.org is best.
-->
### What did you expect to see?
### What did you see instead?
| NeedsInvestigation,modules | low | Critical |
472,295,907 | pytorch | Error while using Libtorch + OpenCV + Qt Creator | I have the following configuration in the .pro file
```
TEMPLATE = app
CONFIG += console c++11
CONFIG -= app_bundle
CONFIG -= qt
CONFIG += thread
SOURCES += main.cpp
INCLUDEPATH += /usr/local/include/opencv4
LIBS += -L/usr/local/lib/
LIBS += -lopencv_core
LIBS += -lopencv_highgui
LIBS += -lopencv_imgproc
LIBS += -lopencv_videoio
QMAKE_CXXFLAGS += -D_GLIBCXX_USE_CXX11_ABI=0
INCLUDEPATH += /path/to/libtorch/include
INCLUDEPATH += /path/to/libtorch/include/torch/csrc/api/include
LIBS += -L/path/to/libtorch/lib
LIBS += -ltorch -lc10
```
OpenCV works absolutely fine **without** "QMAKE_CXXFLAGS += -D_GLIBCXX_USE_CXX11_ABI=**0**". With this, however, I get this following errors:
OpenCV works fine **with** "QMAKE_CXXFLAGS += -D_GLIBCXX_USE_CXX11_ABI=**1**" as well. But it throws a different set of errors:
Setting "QMAKE_CXXFLAGS += -D_GLIBCXX_USE_CXX11_ABI=**0**" has been recommended for Libtorch in most of the forums to avoid the errors above.
What could be a solution or some solutions to work around this?
(I am a newbie to both Libtorch and Qt Creator.) | module: cpp,triaged | low | Critical |
472,350,333 | pytorch | make torch.utils._download_url_from_file public and add a docstring | We have this function https://github.com/pytorch/pytorch/blob/7203612f852e57b3f1667a614444bbb24beec7fb/torch/hub.py#L370-L406 as part of hub.
Expose it public, i.e. remove the `_` prefix, and add a docstring.
Additionally, add special-case handling of Google Drive downloads, as seen here: https://github.com/pytorch/text/blob/master/torchtext/utils.py#L53-L68
This is useful for downstream repos (eg. domain APIs) to standardize on a single function for dataset download.
For example for multiple downstream datasets, we already have so many decentralized / written functions that do the same:
- https://github.com/pytorch/vision/blob/d9830d8688bc2f2fc8070a4688d590c7c0686b27/torchvision/datasets/utils.py#L57-L95
- https://github.com/pytorch/text/blob/master/torchtext/utils.py#L29
- https://github.com/pytorch/audio/blob/master/torchaudio/datasets/vctk.py#L161
- https://github.com/pytorch/audio/blob/master/torchaudio/datasets/yesno.py#L76
cc @jlin27 @mruberry @ailzhang | module: docs,triaged,module: hub,module: ux | low | Minor |
472,353,846 | electron | Override Alt+Space shortcut on Windows | <!-- As an open source project with a dedicated but small maintainer team, it can sometimes take a long time for issues to be addressed so please be patient and we will get back to you as soon as we can.
-->
### Preflight Checklist
<!-- Please ensure you've completed the following steps by replacing [ ] with [x]-->
* [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [x] I have searched the issue tracker for a feature request that matches the one I want to file, without success.
### Problem Description
Currently the `Alt+Space` shortcut opens up native titlebar context menu even if the `accelerator` is registered.
### Proposed Solution
Registering `Alt+Space` shortcut should override Windows shortcut for opening the context menu like in Opera.
| enhancement :sparkles: | low | Minor |
472,383,426 | flutter | Feature request: Setting paragraph distance in Text and TextField | Currently, we have no control over paragraph spacing in both Text and TextField. This feature is important in text stying. | a: text input,c: new feature,framework,f: material design,a: typography,P3,team-framework,triaged-framework | low | Major |
472,383,874 | go | net/http: GET request hangs if "Content-Length" reqest-header field ist set (possible DoS vulnerability) | <!-- Please answer these questions before submitting your issue. Thanks! -->
### What version of Go are you using (`go version`)?
<pre>
PS C:\WINDOWS\System32> go version
go version go1.12.7 windows/amd64
</pre>
### Does this issue reproduce with the latest release?
yes
### What operating system and processor architecture are you using (`go env`)?
<details><summary><code>go env</code> Output</summary><br><pre>
PS C:\WINDOWS\System32> go env
set GOARCH=amd64
set GOBIN=
set GOCACHE=C:\Users\juergen.enge\AppData\Local\go-build
set GOEXE=.exe
set GOFLAGS=
set GOHOSTARCH=amd64
set GOHOSTOS=windows
set GOOS=windows
set GOPATH=C:\daten\go
set GOPROXY=
set GORACE=
set GOROOT=c:\go
set GOTMPDIR=
set GOTOOLDIR=c:\go\pkg\tool\windows_amd64
set GCCGO=gccgo
set CC=gcc
set CXX=g++
set CGO_ENABLED=1
set GOMOD=
set CGO_CFLAGS=-g -O2
set CGO_CPPFLAGS=
set CGO_CXXFLAGS=-g -O2
set CGO_FFLAGS=-g -O2
set CGO_LDFLAGS=-g -O2
set PKG_CONFIG=pkg-config
set GOGCCFLAGS=-m64 -mthreads -fmessage-length=0 -fdebug-prefix-map=C:\Users\JUERGE~1.ENG\AppData\Local\Temp\go-build111174446=/tmp/go-build -gno-record-gcc-switches
</pre></details>
### What did you do?
sending a GET request to the native go http server with "Content-length" request parameter
```
package main
import (
"log"
"net/http"
)
func main() {
server := &http.Server{Addr: "localhost:80"}
log.Fatal(server.ListenAndServe())
}
```
### What did you expect to see?
immediate response with error code 404 page not found (<2ms)
### What did you see instead?
request hangs for very long time (>1min, client kills connection).
### Initial debugging
it seems, that the function call w.finishRequest() in `func (c *conn) serve(ctx context.Context)` from [server.go](https://github.com/golang/go/blob/master/src/net/http/server.go) does not return. There is a problem in flushing the write buffer...
| NeedsInvestigation | low | Critical |
472,391,825 | youtube-dl | Need to download from hulu.jp | <!--
######################################################################
WARNING!
IGNORING THE FOLLOWING TEMPLATE WILL RESULT IN ISSUE CLOSED AS INCOMPLETE
######################################################################
-->
## Checklist
<!--
Carefully read and work through this check list in order to prevent the most common mistakes and misuse of youtube-dl:
- First of, make sure you are using the latest version of youtube-dl. Run `youtube-dl --version` and ensure your version is 2019.07.16. If it's not, see https://yt-dl.org/update on how to update. Issues with outdated version will be REJECTED.
- Make sure that all provided video/audio/playlist URLs (if any) are alive and playable in a browser.
- Make sure that site you are requesting is not dedicated to copyright infringement, see https://yt-dl.org/copyright-infringement. youtube-dl does not support such sites. In order for site support request to be accepted all provided example URLs should not violate any copyrights.
- Search the bugtracker for similar site support requests: http://yt-dl.org/search-issues. DO NOT post duplicates.
- Finally, put x into all relevant boxes (like this [x])
-->
- [x] I'm reporting a new site support request
- [x] I've verified that I'm running youtube-dl version **2019.07.16**
- [x] I've checked that all provided URLs are alive and playable in a browser
- [x] I've checked that none of provided URLs violate any copyrights
- [x] I've searched the bugtracker for similar site support requests including closed ones
## Example URLs
<!--
Provide all kinds of example URLs support for which should be included. Replace following example URLs by yours.
-->
- Single video: https://www.happyon.jp/watch/100000345
- Single video: https://www.happyon.jp/watch/100000345
- Playlist: https://www.happyon.jp/watch/100000345
## Description
<!--
Provide any additional information.
If work on your issue requires account credentials please provide them or explain how one can obtain them.
-->
WRITE DESCRIPTION HERE
| site-support-request | low | Critical |
472,416,784 | flutter | Update flutter_runner to not use Shell::GetEngine | As reported in https://github.com/flutter/flutter/issues/35889, we want to get rid of the shell being able to vend weak pointers to the engine. Fuchsia uses this functionality in a few places that are less trivial to work around. We should update this, probably after flutter_runner is migrated to the engine repo.
see also https://github.com/flutter/engine/pull/9747 | engine,platform-fuchsia,e: embedder,P2,team-engine,triaged-engine | low | Minor |
472,483,967 | rust | Copy trait defeats generator optimization | The following example ([playground](https://play.rust-lang.org/?version=nightly&mode=debug&edition=2018&gist=8ce85f410c979987157e2a0518f065d2)):
```rust
#![feature(generators, generator_trait)]
use std::ops::Generator;
#[derive(Clone)]
struct Foo([u8; 1024]);
fn overlap_foo() -> impl Generator<Yield = (), Return = ()>{
static || {
let x = Foo([0u8; 1024]);
yield;
drop(x);
let y = Foo([0u8; 1024]);
yield;
drop(y);
}
}
#[derive(Clone, Copy)]
struct Bar([u8; 1024]);
fn overlap_bar() -> impl Generator<Yield = (), Return = ()>{
static || {
let x = Bar([0u8; 1024]);
yield;
drop(x);
let y = Bar([0u8; 1024]);
yield;
drop(y);
}
}
fn main() {
dbg!(std::mem::size_of_val(&overlap_foo()));
dbg!(std::mem::size_of_val(&overlap_bar()));
}
```
Outputs:
```
[gen-explicit-drop.rs:34] std::mem::size_of_val(&overlap_foo()) = 1028
[gen-explicit-drop.rs:35] std::mem::size_of_val(&overlap_bar()) = 2052
```
The only difference between Foo and Bar is that Foo is Copy. This defeats the generator optimization implemented in #61922 which considers any local that has been _moved_ from as a candidate for overlap.
Technically, this is semantically consistent with the existing overlap behavior for generators. But making a type `Copy` and getting worse performance is a footgun that we should fix.
This can be fixed with a pass that turns unnecessary copies into moves in MIR. | C-enhancement,T-compiler,A-coroutines,I-heavy,C-optimization | low | Critical |
472,497,671 | angular | [forms] Submitted state on FormGroup in subcomponent is inconsistent | # 🐞 bug report
### Affected Package
The issue concerns @angular/forms
### Is this a regression?
Not that I'm aware of
### Description
Using different approaches to place form controls in subcomponents leads to inconsistent results. See [the stackblitz](https://stackblitz.com/edit/components-issue-form-group-submitted?file=app%2Fapp.component.html) for the different approaches.
Issue originates from https://github.com/angular/components/issues/16360.
## 🔬 Minimal Reproduction
https://stackblitz.com/edit/components-issue-form-group-submitted?file=app%2Fapp.component.html
## 🌍 Your Environment
**Angular Version:**
Angular: ^8.0.0
(can't run `ng version` in a stackblitz)
| type: bug/fix,freq1: low,area: forms,state: confirmed,forms: Controls API,P4 | low | Critical |
472,546,691 | pytorch | QNNpack tests should be skipped on ppc64le (not enabled there) | ## 🐛 Bug
The pytorch tests for QNNpack attempt to run when run on the ppc64le platform, where
QNNpack is not enabled. The tests have no awareness of whether the build was done with USE_QNNPACK=OFF specified. As a consequence, the tests immediately fail.
## To Reproduce
Steps to reproduce the behavior:
1. Build and execute on ppc64le platform, with USE_QNNPACK=OFF.
2. Observe failure of QNNpack tests.
OK, that's not much detail for a reproduce, but basically you can just look at the `test/test_quantized.py` file in the pytorch tree; notice that it skips the QNNpack
tests if IS_WINDOWS is specified, but does not do so for IS_PPC. The fix is simply
to skip these tests for the IS_PPC case also. (Note, IS_PPC is defined in `test/common_utils.py`).
In fact ... I'll submit a PR with this fix.
## Expected behavior
Expected behavior is simply that the QNNpack tests should be skipped when running
on ppc64le.
## Environment
ppc64le platform -- I believe all other environment information is irrelevant beyond this
one platform condition.
## Additional context
I'll submit a PR that handles this for IS_PPC in the same way it is handled for IS_WINDOWS.
I have independently verified that it corrects the issue.
NOTE: The fact is not lost on me that "IS_WINDOWS" is an OS check, while "IS_PPC" is a
platform check, although each is a condition warranting a skip of these tests. Honestly, a
better solution would probably be a feature check instead of cherry-picking specific
systems that should exclude this test set. But for the code as it exists today, the proposed
PR will resolve the issue consistent with its current form.
| module: tests,triaged,better-engineering | low | Critical |
472,584,334 | rust | Async fn doubles argument size | Generator optimization in #60187 by @tmandry reused generator locals, but arguments are still duplicated whenever used across yield points.
For example ([playground](https://play.rust-lang.org/?version=nightly&mode=release&edition=2018&gist=af3e5e9233c45d6397c7b4b3e671f092)):
```rust
#![feature(async_await)]
async fn wait() {}
async fn test(arg: [u8; 8192]) {
wait().await;
drop(arg);
}
fn main() {
println!("{}", std::mem::size_of_val(&test([0; 8192])));
}
```
Expected: 8200
Actual: __16392__
When passing in futures, the future size can grow exponentially ([playground](https://play.rust-lang.org/?version=nightly&mode=release&edition=2018&gist=02a3e685de2b2bf868733e40e56e192b)):
```rust
#![feature(async_await)]
async fn test(_arg: [u8; 8192]) {}
async fn use_future(fut: impl std::future::Future<Output = ()>) {
fut.await
}
fn main() {
println!(
"{}",
std::mem::size_of_val(&use_future(use_future(use_future(use_future(use_future(
use_future(use_future(use_future(use_future(use_future(test(
[0; 8192]
))))))
))))))
);
}
```
Expected: 8236
Actual: __8396796__
I didn't find any note on this. But given how common arguments are used, I think it might be useful if they are included in the optimization. | C-enhancement,T-compiler,A-coroutines,I-heavy,A-async-await,AsyncAwait-Triaged,C-optimization | medium | Major |
472,590,984 | create-react-app | Need help? Visit our Spectrum community. | If you have a general question about Create React App or about building an app with Create React App we encourage you to post on our [Spectrum community](https://spectrum.chat/create-react-app) instead of this issue tracker. The maintainers and other community members can provide help and answer your questions there:
If you're looking for general information on using React, the React docs have a list of resources: https://reactjs.org/community/support.html
If you've discovered a bug or would like to propose a change please open a new issue.
Thanks! | issue: announcement | low | Critical |
472,613,037 | pytorch | [jit] add named tuple as output type to the tracer | There're several requests that want the tracer to support dict as the output. While supporting general dict in tracer is hard, we could instead support named tuple (which values are tensors) as the output of the tracer.
cc @suo | oncall: jit,triaged | low | Minor |
472,630,697 | create-react-app | Create a workflow for sharing scripts for service workers required in public | ### Is your proposal related to a problem?
At present I can't seem to see a clean way to use imports inside the src folder and then have those scripts available to importScripts inside a serviceWorker
The use case I'm up against is sharing an idb store where in src it's easy enough to import the idb library and create an object to initialise and look up store items.
When it then comes to using that with a service worker via importScripts I can't seem to think of a neat way to copy across the idb library code etc short of a post build event but that would then require pulling the src file out of the node_modules folder.
**EG**
`importScripts('/scripts/idb.js');
importScripts('/scripts/idb-store.js');`
**idb-store.js - Located in src**
`import { openDB } from 'idb';
const idbStore = {
db: null,
init: function () {
if (idbStore.db) { return Promise.resolve(idbStore.db); }
return openDB('messages', 1, {
upgrade(db) {
db.createObjectStore('pizzaOrders', { autoIncrement: true, keyPath: 'id' });
}
}).then(function (db) {
return idbStore.db = db;
});
},
pizzaOrders: function (mode) {
return idbStore.init().then(function (db) {
return db.transaction('pizzaOrders', 'readwrite');
})
}
}
export default idbStore;`
I then have to clone that and alter it slightly for use in _public/scripts_ so my service worker can access it:
`var idbStore = {
db: null,
init: function () {
if (idbStore.db) { return Promise.resolve(idbStore.db); }
return openDB('messages', 1, {
upgrade(db) {
db.createObjectStore('pizzaOrders', { autoIncrement: true, keyPath: 'id' });
}
}).then(function (db) {
return idbStore.db = db;
});
},
pizzaOrders: function (mode) {
return idbStore.init().then(function (db) {
return db.transaction('pizzaOrders', 'readwrite');
})
}
}`
The main problem is more so the node module idb I'm then using as I have to make a copy of it to put in the _public/scripts/_ folder so the service worker can use it.
Is there presently a better way?
| issue: proposal | low | Minor |
472,644,186 | three.js | Improving BufferAttribute (maybe) | While working with GLTF loader a fair bit in the past few months I've hit a few issues that seem to be impossible to fix perfectly short of changing parts of the core library. This issue presents the issues and solicits feedback.
Ideally, GLTF loader should be able to create a WebGL buffer for each bufferView that is present in the file. The glTF spec is structured to make this possible through various limitations on alignment and colocated data in a single view. Given a good glTF processor like `gltfpack` you can then achieve a minimum number of WebGL buffers used for the entire scene - for example, one buffer for *everything* (this requires interleaving vertex data), or maybe one buffer per each unique stride (this is commonly how glTF files exported from Sketchfab seem to look). This is independent of the complexity of the scene.
Doing so carries a few benefits - it minimizes the number of buffer objects used to represent the scene, which improves memory consumption, minimizes the cost of switching between geometry buffers during rendering, and in theory unlocks some future accelerated rendering scenarios using multi draw (unfortunately, WEBGL_multi_draw specifically isn't optimal for this, but maybe this can be improved in the future). Additionally, the loading logic can be more straightforward and can become faster for files with lots of meshes.
There are two important features that are required to make this work (see #16802 for what triggered all of this, and GLTFLoader.js for the current somewhat sad workarounds):
- We need to be able to reference the same WebGL buffer from multiple buffer attribute objects, at different byte offsets. This is currently impossible with BufferAttribute. This seems possible with InterleavedBufferAttribute but it doesn't *truly* work because all IBAs that refer to the same IB share the same .count property which breaks various assumptions in various parts of three.js.
- We need to be able to reference the same WebGL buffer from multiple buffer attribute objects with different component types. This is current impossible with BA or IBA - in both cases the backing array on the JS side is a typed array, not an array buffer.
It seems to me that InterleavedBuffer is not pulling its weight. It doesn't solve either of the two problems above - effectively it only works if you want to interleave data of the same component type within a buffer for a single mesh, but doesn't allow mixing component types or packing multiple meshes into a single buffer. WebGL is perfectly capable of all of these, but Three.JS lacks a good interface to this.
Additionally, the fact that there are two different constructs with two different interfaces to represent, conceptually, the exact same thing - an array of typed components used for vertex processing - seems problematic. This results in some number of type checks for which BufferAttribute implementation it is, and not all code can handle both.
Now, if we agree that these problems should be solved, there's still an option of continuing to evolve InterleavedBufferAttribute to support these use cases - it probably involves extending InterleavedBuffer to optionally contain an ArrayBuffer instead of a TypedArray, adding a .count property to InterleavedBufferAttribute that can be set independently, and fixing code that directly works with InterleavedBuffer. If this was done, you'd be able to create InterleavedBuffer objects exclusively in glTF loader.
However, it seems like there's another way to fix this problem - instead of fixing InterleavedBuffer, we can improve BufferAttribute and deprecate InterleavedBuffer instead (it could still potentially exist as a thin wrapper over BufferAttribute to maintain backwards compatibility).
Here's how this could work.
Right now BufferAttribute is created from a typed array. We would add a new Buffer object that can be created from an ArrayBuffer, and a way to create BufferAttribute from a Buffer object with a byte offset and a component type (which would create a typed array for a slice of the buffer object). Existing constructor from a typed array would create a private Buffer object, so existing code would work as is.
BufferAttribute would be extended with a stride; to keep everything working nicely we will require that the stride is divisible by the component size so that it can be expressed in terms of the type of the typed array - this isn't a significant limitation in practice because the largest usable type is 32-bit float, and for various legacy reasons offsets need to be aligned by 4 bytes both in glTF spec and in general use.
Code that directly accesses BufferAttribute.array and isn't aware of the stride will need to be taught about the stride; code that works with BufferAttribute through getX/etc. accessors will continue to work.
After this is done, glTF loader can forget that interleaved buffers exist and create Buffer from each bufferView and BufferAttribute from each geometry accessor. (in glTF specifically there's one more source of inefficiency atm which is the morph target buffer duplication, which I think should be solved at the core level as well but that's a separate discussion) We can then separately deprecate InterleavedBuffer and either just remove it, or reroute IBA & IB methods to work through BA & B - they might just extend these classes and add the relevant functions if necessary.
As a result, three.js can gain a Buffer object that is roughly equal in power to WebGL buffers, glTF loader can stop creating thousands of tiny buffers for scenes with a large number of meshes, and (eventually) the whole "there are two different types of buffer attributes" issue can disappear.
Thoughts? | Suggestion,Design | medium | Major |
472,646,937 | pytorch | dyndep function not working | ## 🐛 Bug
On using the command dyndep.InitOpsLibrary('/usr/local/lib/libcaffe2_detectron_ops_gpu.so') to load libcaffe2_detectron_ops_gpu.so ,the program stucks/hang and even ctrl + c is not working to stop the program. | caffe2 | low | Critical |
472,647,895 | flutter | iOS accessibility focus not returned to textfields after keyboard closed when other widgets are present | ## Steps to Reproduce
1. Enable VoiceOver on iOS
2. Open flutter gallery app and navigate to material > text fields
3. Tap on any textfield, double tap to start editing
4. Dismiss the keyboard with done
5. The accessibility focus does not return to the edited textfield, but move to other widget and start to read (if there's something to read).
e.g
Completes editing name textfield -> starts read Email textfield
Completes editing password textfield -> accessibility focus goes to submit button
This really causes a mess and makes it very difficult to complete multiple text inputs for VoiceOver users. But everything works fine on Android.
## Logs
```
[✓] Flutter (Channel stable, v1.7.8+hotfix.3, on Mac OS X 10.14.5 18F132, locale en-TW)
• Flutter version 1.7.8+hotfix.3
• Framework revision b712a172f9 (2 weeks ago), 2019-07-09 13:14:38 -0700
• Engine revision 54ad777fd2
• Dart version 2.4.0
[✓] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
• Android SDK at /Users/fiona/Dev/android_sdk
• Android NDK location not configured (optional; useful for native profiling support)
• Platform android-28, build-tools 28.0.3
• Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
• Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1343-b01)
• All Android licenses accepted.
[✓] Xcode - develop for iOS and macOS (Xcode 10.2.1)
• Xcode at /Applications/Xcode.app/Contents/Developer
• Xcode 10.2.1, Build version 10E1001
• CocoaPods version 1.7.1
[✓] iOS tools - develop for iOS devices
• ios-deploy 1.9.4
[✓] Android Studio (version 3.4)
• Android Studio at /Applications/Android Studio.app/Contents
• Flutter plugin version 36.1.1
• Dart plugin version 183.6270
• Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1343-b01)
[✓] VS Code (version 1.36.1)
• VS Code at /Applications/Visual Studio Code.app/Contents
• Flutter extension version 3.2.0
[✓] Connected device (1 available)
• iphone X • ios • iOS 12.2
``` | a: text input,platform-ios,framework,f: material design,a: accessibility,has reproducible steps,P2,found in release: 3.3,found in release: 3.6,team-accessibility,triaged-accessibility | low | Minor |
472,703,809 | opencv | CUDA_Legacy/NCV.HypothesesFiltration test failed |
##### System information (version)
- OpenCV => 4.1.0
- Operating System / Platform => Windows 64 Bit
- Compiler => Visual Studio 2015
- CUDA RT => 8.0
- CUDA driver version => 10.0
[----------]
[ GPU INFO ] Run on OS Windows x64.
[----------]
*** CUDA Device Query (Runtime API) version (CUDART static linking) ***
Device count: 1
Device 0: "GeForce GTX 1050"
CUDA Driver Version / Runtime Version 10.0 / 8.0
CUDA Capability Major/Minor version number: 6.1
Total amount of global memory: 4096 MBytes (4294967296 bytes)
GPU Clock Speed: 1.49 GHz
Max Texture Dimension Size (x,y,z) 1D=(131072), 2D=(131072,65536), 3D=(16384,16384,16384)
Max Layered Texture Size (dim) x layers 1D=(32768) x 2048, 2D=(32768,32768) x 2048
Total amount of constant memory: 65536 bytes
Total amount of shared memory per block: 49152 bytes
Total number of registers available per block: 65536
Warp size: 32
Maximum number of threads per block: 1024
Maximum sizes of each dimension of a block: 1024 x 1024 x 64
Maximum sizes of each dimension of a grid: 2147483647 x 65535 x 65535
Maximum memory pitch: 2147483647 bytes
Texture alignment: 512 bytes
Concurrent copy and execution: Yes with 5 copy engine(s)
Run time limit on kernels: Yes
Integrated GPU sharing Host Memory: No
Support host page-locked memory mapping: Yes
Concurrent kernel execution: Yes
Alignment requirement for Surfaces: Yes
Device has ECC support enabled: No
Device is using TCC driver mode: No
Device supports Unified Addressing (UVA): Yes
Device PCI Bus ID / PCI location ID: 1 / 0
Compute Mode:
Default (multiple host threads can use ::cudaSetDevice() with device simultaneously)
deviceQuery, CUDA Driver = CUDART, CUDA Driver Version = 10.0, CUDA Runtime Version = 8.0, NumDevs = 1
##### Detailed description
[==========] Running 12 tests from 5 test cases.
[----------] Global test environment set-up.
...
...
[ RUN ] CUDA_Legacy/NCV.HypothesesFiltration/0, where GetParam() = GeForce GTX 1050
unknown file: error: C++ exception with description "OpenCV(4.1.0) C:\developing\opencv_contribute\opencv_contrib\modules\cudalegacy\src\NCV.cpp:745: error: (-213:The function/feature is not implemented) This functionality requires objdetect module in function 'groupRectangles'
" thrown in the test body.
[ FAILED ] CUDA_Legacy/NCV.HypothesesFiltration/0, where GetParam() = GeForce GTX 1050 (873 ms)
...
...
[----------] Global test environment tear-down
[==========] 12 tests from 5 test cases ran. (17081 ms total)
[ PASSED ] 11 tests.
[ FAILED ] 1 test, listed below:
[ FAILED ] CUDA_Legacy/NCV.HypothesesFiltration/0, where GetParam() = GeForce GTX 1050
##### Steps to reproduce
Build with cudalegacy module but without objdetect module.
Question:
1. Can we disable this test?
2. Should we disable this test while objdetect module is not checked?
| category: gpu/cuda (contrib) | low | Critical |
472,712,119 | flutter | [webview_flutter] Add an option to bypass SSL checks | Hi there..
I'm using the Flutter plugins 'webview_flutter' to load certain url and it works perfectly.. with http or without https .... but there is certains url comes with https was detected having not a valid ssl caused my flutter apps to be blank...
So my questions is...is that possible I can ignored those SSL errors and just proceed with the url using this 'webview_flutter' plugins..anyone got luck with it...or maybe point me in the right direction....
Thanks in advanced | c: new feature,p: webview,package,c: proposal,team-ecosystem,P3,triaged-ecosystem | medium | Critical |
472,740,908 | create-react-app | Allow JSON with comments in jsconfig.json | ### Is your proposal related to a problem?
This is a follow-on from #7248. Right now, we don't support JSONC (JSON with comments) in `jsconfig.json` files.
### Describe the solution you'd like
After a discussion with @iansu, we see two paths:
1. Implement the same solution as we did for TypeScript. This is easy, but would require us making TypeScript a dependency of `react-scripts`.
2. The above, but instead of installing `typescript` as a dependency of `react-scripts`, we would install it to the user's project if they are using a `jsconfig.json` file and don't have `typescript` installed.
Discussion is welcome.
If you're interested in picking this up, please let us know. | issue: proposal,difficulty: medium,contributions: claimed,good first issue | low | Major |
472,748,338 | vscode | [html] auto close tags being inserted before its html content | Issue Type: <b>Bug</b>
Usually, after opening a HTML tag(`<div>`, for example), an auto close tag is immediately inserted (`</div>` in this case) and cursor is positioned between them, so I can continue typing...
but when using "Remote - SSH", since it takes a few mili seconds to auto complete (internet latency, )I open a html tag and continue typing.. and the closing tag is inserted immediately after opening tag, pushing what I have typed till now, outside of the closing tag
but this does not happen if I wait for a while, until the closing tag is inserted..
the former case looks kinda like this:
`<div></div>lorem ipsum`
` <!-- ^ closing tag is inserted here -->`
Extension version: 0.44.2
VS Code version: Code 1.36.1 (2213894ea0415ee8c85c5eea0d0ff81ecc191529, 2019-07-08T22:59:35.033Z)
OS version: Windows_NT x64 10.0.17134
Remote OS version: Linux x64 4.9.0-9-amd64
<!-- generated by issue reporter --> | bug,html | low | Critical |
472,790,092 | flutter | Why TableRow doesn't support center,width and height params? | When I'm using the TableRow widget, I have two problems: how to set the height and center of its children?
Why TableRow doesn't support height and center params?
Now If I want to let the children of TableRow gravity center,I use Align(Center) warpped around the children of TableRow.
If I want to setting the height of the children of TableRow,I use Container(or other widgets supports height params) warpped around the children of TableRow.
But it's very hard to do this. This is my codes now:
```
new TableRow(
decoration: new BoxDecoration(color: Colors.green),
children: [
buildContents("data1"),
buildContents("data2"),
buildContents("data3"),
buildContents("data4"),
],
);
Widget buildContents(String text) {
return new Container(
height: 80,
child: new Align(
alignment: Alignment.center,
child: new Text(text),
),
);
}
```
----
**Changes:**
I want TableRow can add `height` and `alignment` params and `width` params, just like below:
```
new TableRow(
decoration: new BoxDecoration(color: Colors.green),
height:80,
width: 100,
alignment: Alignment.center,
children: [
new Text("data1"),
new Text("data2"),
new Text("data3"),
new Text("data4"),
],
);
``` | c: new feature,framework,P2,team-framework,triaged-framework | low | Critical |
472,846,915 | opencv | Can't read File using cv::FileStorage from files with very long path and filenames | ##### System information (version)
- OpenCV => 4.1
- Operating System / Platform => Windows 10
- Compiler => msvc2015 64 bit
##### Detailed description
I am not able to read a file using cv::FileStorage from a file that has a long path, while reading the file with QFile works fine.
##### Steps to reproduce
```.cpp
QString path = "//server\\abcd\\efghi\\123456\\loooooooooooooooong\\lllllllllllllllllllllllllll\\aaaaaaaaaaaaaaa\\bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb\\cccccccc\\ddddd\\eeeeeeeeeeeeeeee\\fffffffffffffff\\file___________________________________________________________________1.yml";
cv::FileStorage fSettings(path, cv::FileStorage::READ);
if (!fSettings.isOpened())
{
fSettings.release();
//fail
}
else {
//success
}
```
##### Workaround
Read file contents using QFile and pass it to FileStorage
```.cpp
QString path = "//server\\abcd\\efghi\\123456\\loooooooooooooooong\\lllllllllllllllllllllllllll\\aaaaaaaaaaaaaaa\\bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb\\cccccccc\\ddddd\\eeeeeeeeeeeeeeee\\fffffffffffffff\\file___________________________________________________________________1.yml";
QFile f(path);
bool valid = false;
std::string contents = "";
if(!f.open(QFile::ReadOnly))
{
//fail
}
else
{
//success
contents = f.readAll().toStdString();
}
cv::FileStorage fSettings(contents, cv::FileStorage::READ|cv::FileStorage::MEMORY);
if (!fSettings.isOpened())
{
fSettings.release();
//fail
}
else {
//success
}
``` | priority: low,category: core | low | Minor |
472,850,321 | opencv | G-API incomplete documentation | ##### System information (version)
- OpenCV => 4.x
- Operating System / Platform => N.C.
- Compiler => N.C.
##### Detailed description
The documentation for the G-API is incomplete. There is also no example on how to switch between G-API backends (Fluid, GPU, ...)
https://docs.opencv.org/4.0.0/d4/ddd/gapi_impl.html
https://docs.opencv.org/master/d4/ddd/gapi_impl.html
More documentation or hints on how to help documenting this part is very welcome.
Documentation can contain next milestones for G-API and the most important/priority parts that need contributions from the community.
| category: documentation,category: g-api / gapi | low | Minor |
472,858,143 | kubernetes | The vulnerability(CVE-2019-11244) is not completely eliminated | **What happened**:
The PR(https://github.com/kubernetes/kubernetes/pull/77874) seems have fixed [CVE-2019-11244](https://nvd.nist.gov/vuln/detail/CVE-2019-11244).
But I doubt the correction didn't fix completely.
According to the description of [CVE-2019-11244](https://nvd.nist.gov/vuln/detail/CVE-2019-11244):
> In Kubernetes v1.8.x-v1.14.x, schema info is cached by kubectl in the location specified by --cache-dir (defaulting to $HOME/.kube/http-cache), written with world-writeable permissions (rw-rw-rw-). If --cache-dir is specified and pointed at a different location accessible to other users/groups, the written files may be modified by other users/groups and disrupt the kubectl invocation.
The cache file created by kubectl should not be modified by other users/groups, or, to be more accurate, the file can only be modified by the user who runs the process.
But after the correction, the user in the same group still can write the cache file.
In the correction we have made the two changes:
* The path permission changed from `0755` to `0750`. (I think it's ok. Allow user in the same group enter the path but can not modify the path, neither create nor delete a file in this path. Refuse all other users.)
* The cache file permission changed from `0755` to `0660`. (This still allows the user in the same group modify the cache file.)
So, I think the file permission should be `0640`. The user in the same group can only read the file.
**What you expected to happen**:
The cache file can only be modified by the user who runs the process, and the users in the same group can only have read permission.
**How to reproduce it (as minimally and precisely as possible)**:
1. Create a path by root and set permission with `0755`:
`# mkdir -m 0750 myPath0750`
2. Create a file in it by root and set permission with `0660`:
`# touch myPath0750/myFile0660`
`# chmod 0660 myPath0750/myFile0660`
3. Create a new user in root group:
`# useradd -G root -d /home/horen -m horen`
`# passwd horen`
4. Switch to new users and try to modify the file `myPath0750/myFile0660`.
You will see the new user can modify the file.
**Anything else we need to know?**:
I don't know if there a scenario for users in the same group to modify the cache file. Please let me know if there is.
**Environment**:
- Kubernetes version (use `kubectl version`): N/A
- Cloud provider or hardware configuration: N/A
- OS (e.g: `cat /etc/os-release`): CentOS 7.0
- Kernel (e.g. `uname -a`):
- Install tools:
- Network plugin and version (if this is a network-related bug):
- Others:
| kind/bug,area/security,sig/api-machinery,lifecycle/frozen | low | Critical |
472,865,864 | opencv | Crop and resize to work with blobFromImages | <!--
If you have a question rather than reporting a bug please go to http://answers.opencv.org where you get much faster responses.
If you need further assistance please read [How To Contribute](https://github.com/opencv/opencv/wiki/How_to_contribute).
Please:
* Read the documentation to test with the latest developer build.
* Check if other person has already created the same issue to avoid duplicates. You can comment on it if there already is an issue.
* Try to be as detailed as possible in your report.
* Report only one problem per created issue.
This is a template helping you to create an issue which can be processed as quickly as possible. This is the bug reporting section for the OpenCV library.
-->
##### System information (version)
<!-- Example
- OpenCV => 3.1
- Operating System / Platform => Windows 64 Bit
- Compiler => Visual Studio 2015
-->
- OpenCV => 4.1
- Operating System / Platform => Windows 10
- Compiler => none, using python
##### Detailed description
<!-- your description -->
I wanted to use Faster RCNN (which has the crop and resize layer in it) to do infrenece on multi image. I used tensorflow frozen graph and text graph definition to initialize the network. But upon executing net.forward(), an error was rasied saying some part of crop and resize hasnt been implemented.
`The function/feature is not implemented) in function 'cv::dnn::CropAndResizeLayerImpl::getMemoryShapes'`
Is it going to be implemented anytime soon? is it on the roadmap?
##### Steps to reproduce
<!-- to add code example fence it with triple backticks and optional file extension
```.cpp
// C++ code example
```
or attach as .txt or .zip file
-->
This is the general structure of the code used
```py
net = cv2.dnn.readNetFromTensorflow(#...)
#read any 2 images
image = # ...
image2 = #...
blob = cv2.dnn.blobFromImages([image1,image2],# ...)
net.setInput(blob)
output = net.forward()
```
| feature,category: dnn | low | Critical |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.