commit_msg
stringlengths
1
24.2k
commit_hash
stringlengths
2
84
project
stringlengths
2
40
source
stringclasses
4 values
labels
int64
0
1
repo_url
stringlengths
26
70
commit_url
stringlengths
74
118
commit_date
stringlengths
25
25
qcow2: Split qcow2_check_refcounts() Put the code for calculating the reference counts and comparing them during qemu-img check into own functions. Signed-off-by: Max Reitz <[email protected]> Reviewed-by: Benoît Canet <[email protected]> Reviewed-by: Kevin Wolf <[email protected]> Signed-off-by: Kevin Wolf <[email protected]>
6ca56bf5e90aa167395727667d17c699950c545c
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/6ca56bf5e90aa167395727667d17c699950c545c
2014-10-23 15:34:01+02:00
tests: usb: usb-uas hotplug test checks that it's possible to hotplug usb-uas HBA and then if it's possible to hot(un)plug scsi-disk to it. Thest basically covers hot(un)plug on dummy HBAs without means of hot(un)plug notification of the guest. Signed-off-by: Igor Mammedov <[email protected]> Reviewed-by: Paolo Bonzini <[email protected]> Signed-off-by: Andreas Färber <[email protected]>
49cec38591d6fef833cf12873fb4ff9748d0f08b
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/49cec38591d6fef833cf12873fb4ff9748d0f08b
2014-10-15 05:03:13+02:00
blockjob: add block_job_defer_to_main_loop() Block jobs will run in the BlockDriverState's AioContext, which may not always be the QEMU main loop. There are some block layer APIs that are either not thread-safe or risk lock ordering problems. This includes bdrv_unref(), bdrv_close(), and anything that calls bdrv_drain_all(). The block_job_defer_to_main_loop() API allows a block job to schedule a function to run in the main loop with the BlockDriverState AioContext held. This function will be used to perform cleanup and backing chain manipulations in block jobs. Signed-off-by: Stefan Hajnoczi <[email protected]> Reviewed-by: Max Reitz <[email protected]> Message-id: [email protected]
dec7d421f85578b0949292336f784f55ac84812d
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/dec7d421f85578b0949292336f784f55ac84812d
2014-11-03 11:41:49+00:00
snapshot: fix referencing wrong variable in while loop in do_delvm The while loop variabal is "bs1", but "bs" is always passed to bdrv_snapshot_delete_by_id_or_name. Broken in commit a89d89d, v1.7.0. Signed-off-by: Zhang Haoyu <[email protected]> Reviewed-by: Markus Armbruster <[email protected]> Signed-off-by: Stefan Hajnoczi <[email protected]>
af957387547b05ed6dc4d84c10cca42700a7aeda
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/af957387547b05ed6dc4d84c10cca42700a7aeda
2014-10-03 10:30:33+01:00
kvm/valgrind: don't mark memory as initialized since commit 7dda5dc82a77 ("migration: initialize RAM to zero") the guest memory is defined zero. No need to call valgrind on guest memory. This reverts commit 62fe83318d2f ("qemu: Use valgrind annotations to mark kvm guest memory as defined") thus speeding up kvm start if <includedir>/valgrind/valgrind.h is available. Signed-off-by: Christian Borntraeger <[email protected]> Signed-off-by: Paolo Bonzini <[email protected]>
541be9274e8ef227fb1b50ce124fd2cc2dce81a5
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/541be9274e8ef227fb1b50ce124fd2cc2dce81a5
2014-09-26 13:35:08+02:00
qcow2: Check L1/L2/reftable entries for alignment Offsets taken from the L1, L2 and refcount tables are generally assumed to be correctly aligned. However, this cannot be guaranteed if the image has been written to by something different than qemu, thus check all offsets taken from these tables for correct cluster alignment. Signed-off-by: Max Reitz <[email protected]> Reviewed-by: Eric Blake <[email protected]> Message-id: [email protected] Signed-off-by: Stefan Hajnoczi <[email protected]>
a97c67ee6c1546b985c1048c7a1f9e4fc13d9ee1
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/a97c67ee6c1546b985c1048c7a1f9e4fc13d9ee1
2014-09-22 11:39:28+01:00
make check-block: Use default cache modes When qemu-iotests only gave a choice between cache=none and cache=writethrough, we picked cache=none because it was the option that would complete the test in finite time. Some tests could only work for one of the two options and would be skipped with cache=none, but that was an acceptable trade-off at the time. Today, however, qemu-iotests is a bit more flexible than that and you can specify any of the cache modes supported by qemu. The default is writeback, like in qemu, which is fast and (unlike cache=none) compatible with any host filesystem. Test cases that have specific requirements for the cache mode can also specify a different default. In order to get a fast test run that works everywhere and doesn't skip tests that need a different cache mode, not specifying any cache mode and instead relying on the default is the best we can do today. Signed-off-by: Kevin Wolf <[email protected]> Reviewed-by: Markus Armbruster <[email protected]> Message-id: [email protected] Signed-off-by: Stefan Hajnoczi <[email protected]>
d9323e9b20b1a74720f17e81387cffe013d9cf0b
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/d9323e9b20b1a74720f17e81387cffe013d9cf0b
2014-10-03 10:30:33+01:00
spapr: Split memory nodes to power-of-two blocks Linux kernel expects nodes to have power-of-two size and does WARN_ON if this is not the case: [ 0.041456] WARNING: at drivers/base/memory.c:115 which is: === /* Validate blk_sz is a power of 2 and not less than section size */ if ((block_sz & (block_sz - 1)) || (block_sz < MIN_MEMORY_BLOCK_SIZE)) { WARN_ON(1); block_sz = MIN_MEMORY_BLOCK_SIZE; } === This splits memory nodes into set of smaller blocks with a size which is a power of two. This makes sure the start address of every node is aligned to the node size. Signed-off-by: Alexey Kardashevskiy <[email protected]> [agraf: squash windows compile fix in] Signed-off-by: Alexander Graf <[email protected]>
6010818c30ce9c796b4e22fd261fc6fea1cecbfc
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/6010818c30ce9c796b4e22fd261fc6fea1cecbfc
2014-09-08 12:50:48+02:00
nbd: Drop nbd_can_read() There is no variant of aio_set_fd_handler() like qemu_set_fd_handler2(), so we cannot give a can_read() callback function. Instead, unregister the nbd_read() function whenever we cannot read and re-register it as soon as we can read again. All this is hidden behind the functions nbd_set_handlers() (which registers all handlers for the AIO context and file descriptor belonging to the given client), nbd_unset_handlers() (which unregisters them) and nbd_update_can_read() (which checks whether NBD can read for the given client and acts accordingly). Signed-off-by: Max Reitz <[email protected]> Signed-off-by: Stefan Hajnoczi <[email protected]>
958c717df97ea9ca47a2253b8371130fe5f22980
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/958c717df97ea9ca47a2253b8371130fe5f22980
2014-08-29 10:48:45+01:00
CODING_STYLE: Section about conditional statement Yoda conditions lack readability, and QEMU has a strict compiler configuration for checking a common mistake like "if (dev = NULL)". Make it a written rule. Signed-off-by: Gonglei <[email protected]> Reviewed-by: Eric Blake <[email protected]> Signed-off-by: Michael Tokarev <[email protected]>
2bb0020cf97c938f8339c76fa8a0da6353e8d27e
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/2bb0020cf97c938f8339c76fa8a0da6353e8d27e
2014-08-15 18:54:06+04:00
cadence_uart: check for serial backend before using it. This checks that s->chr is not NULL before using it. Signed-off-by: KONRAD Frederic <[email protected]> Reviewed-by: Peter Crosthwaite <[email protected]> Signed-off-by: Peter Maydell <[email protected]>
af52fe862fba686713044efdf9158195f84535ab
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/af52fe862fba686713044efdf9158195f84535ab
2014-07-17 16:36:17+01:00
pci: Use bus master address space for delivering MSI/MSI-X messages The spec says (and real HW confirms this) that, if the bus master bit is 0, the device will not generate any PCI accesses. MSI and MSI-X messages fall among these, so we should use the corresponding address space to deliver them. This will prevent delivery if bus master support is disabled. Cc: [email protected] Signed-off-by: Jan Kiszka <[email protected]> Reviewed-by: Michael S. Tsirkin <[email protected]> Signed-off-by: Michael S. Tsirkin <[email protected]>
cc943c36faa192cd4b32af8fe5edb31894017d35
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/cc943c36faa192cd4b32af8fe5edb31894017d35
2014-08-14 13:20:33+02:00
virtio-rng: implement per-device migration calls While we are here, we also check virtio_load() return value. Signed-off-by: Greg Kurz <[email protected]> Reviewed-by: Alexander Graf <[email protected]> Reviewed-by: Michael S. Tsirkin <[email protected]> Signed-off-by: Michael S. Tsirkin <[email protected]>
3902d49e13c2428bd6381cfdf183103ca4477c1f
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/3902d49e13c2428bd6381cfdf183103ca4477c1f
2014-06-29 19:39:41+03:00
iotests: Source common.env Source common.env in the iotests' check script. Signed-off-by: Max Reitz <[email protected]> Signed-off-by: Kevin Wolf <[email protected]>
7fed1a49ff72a5b794e3723612fa1731844b38f7
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/7fed1a49ff72a5b794e3723612fa1731844b38f7
2014-06-27 20:00:00+02:00
virtio-blk: Fix and clean up the in_sg and out_sg check out_sg is checked by iov_to_buf below, so it can be dropped. Add assert and iov_discard_back around in_sg, as the in_sg is handled in dataplane code. Signed-off-by: Fam Zheng <[email protected]> Reviewed-by: Stefan Hajnoczi <[email protected]> Signed-off-by: Kevin Wolf <[email protected]>
ee17e84830e2e7030d57db5b415719e9022573cd
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/ee17e84830e2e7030d57db5b415719e9022573cd
2014-06-27 18:18:31+02:00
target-ppc: Remove POWER7+ and POWER8E families POWER8E is architecturally equal to POWER8 and POWER7+ is equal to POWER7. Also no user space tool makes any difference for CPU node name in the device tree (such as PowerPC,POWER7@0 vs. PowerPC,POWER7+@0). So there is no point in emulating POWER7+ and POWER8E apart from POWER7 and POWER8. Also, the previos patch implemented multiple PVR mask support per CPU class so POWER7 class now covers both POWER7 and POWER7+ CPUs, same is valid for POWER8/8E. This removes POWER7+ and POWER8E classes. This replaces references to POWER7P/POWER8E families with POWER7/POWER8 families. Signed-off-by: Alexey Kardashevskiy <[email protected]> Signed-off-by: Alexander Graf <[email protected]>
b60c60070c0df4ef01d5c727929fe0e93e6fdd09
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/b60c60070c0df4ef01d5c727929fe0e93e6fdd09
2014-07-08 12:10:36+02:00
target-i386: block migration and savevm if invariant tsc is exposed Invariant TSC documentation mentions that "invariant TSC will run at a constant rate in all ACPI P-, C-. and T-states". This is not the case if migration to a host with different TSC frequency is allowed, or if savevm is performed. So block migration/savevm. Signed-off-by: Marcelo Tosatti <[email protected]> Reviewed-by: Eduardo Habkost <[email protected]> Signed-off-by: Eduardo Habkost <[email protected]> Reviewed-by: Juan Quintela <[email protected]> [AF+mtosatti: Updated error message] Signed-off-by: Andreas Färber <[email protected]>
68bfd0ad4a1dcc4c328d5db85dc746b49c1ec07e
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/68bfd0ad4a1dcc4c328d5db85dc746b49c1ec07e
2014-06-25 23:54:57+02:00
e1000: factor out checking for auto-negotiation availability Also fix minor indentation issues in the surrounding code. Suggested-by: Michael S. Tsirkin <[email protected]> Signed-off-by: Gabriel Somlo <[email protected]> Reviewed-by: Michael S. Tsirkin <[email protected]> Signed-off-by: Michael S. Tsirkin <[email protected]>
d7a4155265416a1c8f3067b59e68bf5fda1d6215
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/d7a4155265416a1c8f3067b59e68bf5fda1d6215
2014-06-23 17:38:00+03:00
target-i386: Support check/enforce flags in TCG mode, too If enforce/check is specified in TCG mode, QEMU will ensure all CPU features are supported by TCG, so no CPU feature is silently disabled. Reviewed-by: Richard Henderson <[email protected]> Signed-off-by: Eduardo Habkost <[email protected]> [AF: Be explicit about TCG vs. !KVM] Signed-off-by: Andreas Färber <[email protected]>
fefb41bf3485a1c9a44c15e382d28035c6fb5f4b
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/fefb41bf3485a1c9a44c15e382d28035c6fb5f4b
2014-06-25 23:54:57+02:00
vmstate-static-checker: script to validate vmstate changes This script compares the vmstate dumps in JSON format as output by QEMU with the -dump-vmstate option. It flags various errors, like version mismatch, sections going away, size mismatches, etc. This script is tolerant of a few changes that do not change the on-wire format, like embedding a few fields within substructs. The script takes -s/--src and -d/--dest parameters, to which filenames are given as arguments. Example: (in a qemu 2.0 tree): ./x86_64-softmmu/qemu-system-x86_64 -dump-vmstate qemu-2.0.json (in a qemu 2.2 tree:) ./x86_64-softmmu/qemu-system-x86_64 -dump-vmstate -M pc-i440fx-2.0 \ qemu-2.2-m2.0.json ./scripts/vmstate-static-checker.py -s qemu-2.0.json -d qemu-2.2-m2.0.json The script also takes a --reverse parameter to switch the src and dest jsons. This is just a shorthand for reversing the src and dest. The --help parameter shows usage information. Signed-off-by: Amit Shah <[email protected]> Signed-off-by: Juan Quintela <[email protected]>
426d1d016a494c978a513afcd03aa000fcbd5b3c
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/426d1d016a494c978a513afcd03aa000fcbd5b3c
2014-06-23 19:14:51+02:00
PPC: e500: Expose kernel load address in dt We want to move to a model where firmware loads our kernel. To achieve this we need to be able to tell firmware where the kernel lies. Let's copy the mechanism we already use for -M pseries and expose the kernel load address and size through the device tree. Signed-off-by: Alexander Graf <[email protected]>
903585dec63ee83bd8149006e31f92ea789b38e3
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/903585dec63ee83bd8149006e31f92ea789b38e3
2014-06-16 13:24:35+02:00
memory: Simplify mr_add_subregion() if-else This if else is not needed. The previous call to memory_region_add (whether _overlap or not) will always set priority and may_overlap to desired values. And its not possible to get here without having called memory_region_add_subregion due to the null guard on parent. So we can just directly call memory_region_add_subregion_common. Signed-off-by: Peter Crosthwaite <[email protected]> Signed-off-by: Paolo Bonzini <[email protected]>
3fb5bf5730b90c08d5d1c027900efae210d9b326
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/3fb5bf5730b90c08d5d1c027900efae210d9b326
2014-06-17 16:07:37+02:00
s390x/kvm: add alternative injection interface Add kvm_s390_{vcpu,floating}_interrupt, which offer the possibility to inject interrupts with larger payloads (when a kvm backend becomes available). Moreover, kvm_s390_floating_interrupt() does no longer have the bogus requirement for a vcpu. Signed-off-by: Cornelia Huck <[email protected]>
66ad0893f07f194b5c8607cb81061b8d7202511c
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/66ad0893f07f194b5c8607cb81061b8d7202511c
2014-06-10 09:50:27+02:00
virtio: allow mapping up to max queue size It's a loop from i < num_sg and the array is VIRTQUEUE_MAX_SIZE - so it's OK if the value read is VIRTQUEUE_MAX_SIZE. Not a big problem in practice as people don't use such big queues, but it's inelegant. Reported-by: "Dr. David Alan Gilbert" <[email protected]> Cc: [email protected] Signed-off-by: Michael S. Tsirkin <[email protected]>
937251408051e0489f78e4db3c92e045b147b38b
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/937251408051e0489f78e4db3c92e045b147b38b
2014-05-12 12:07:21+03:00
spice: fix "info spice" In case no listening address was specified, "info spice" reports "0.0.0.0" as address. Which is incorrect in case spice is listening on ipv6. Replace it by a wildcard "*" to indicate it is not limited to a specific address. Note: Being more specific is not possible without extending the spice-server api. The socket is handled by spice-server not qemu, so qemu can't easily figure the actual socket address. Reported-by: David Jaša <[email protected]> Signed-off-by: Gerd Hoffmann <[email protected]>
4f60af9ac00800d5833f6ec4317535aeaddb1616
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/4f60af9ac00800d5833f6ec4317535aeaddb1616
2014-05-08 10:45:54+02:00
kvm: Fix enable_cap helpers on older gcc Commit 40f1ee27aa1 introduced handy helpers for enable_cap calls on vcpu and vm level. Unfortunately some older gcc versions (4.7.1, 4.6) seem to choke on signedness detection in inline created variables: target-ppc/kvm.c: In function 'kvmppc_booke_watchdog_enable': target-ppc/kvm.c:1302:21: error: comparison of unsigned expression < 0 is always false [-Werror=type-limits] target-ppc/kvm.c: In function 'kvmppc_set_papr': target-ppc/kvm.c:1504:21: error: comparison of unsigned expression < 0 is always false [-Werror=type-limits] However - thanks to Thomas Huth for the suggestion - we can just cast the offending potentially 0 value to a signed type, making the comparison signed. Reviewed-by: Thomas Huth <[email protected]> Acked-by: Cornelia Huck <[email protected]> Signed-off-by: Alexander Graf <[email protected]> Signed-off-by: Cornelia Huck <[email protected]>
61c7bbd236b90da7531fcf957223a2456670d44d
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/61c7bbd236b90da7531fcf957223a2456670d44d
2014-05-20 13:05:57+02:00
block: Check bdrv_getlength() return value in bdrv_make_zero() Signed-off-by: Kevin Wolf <[email protected]> Reviewed-by: Max Reitz <[email protected]>
9ce10c0bdcdd8a36c62e3376fd1de86bc0fb8a2a
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/9ce10c0bdcdd8a36c62e3376fd1de86bc0fb8a2a
2014-04-22 11:57:02+02:00
curl: Fix return from curl_read_cb with invalid state A curl write callback is supposed to return the number of bytes it handled. curl_read_cb would have erroneously reported it had handled all bytes in the event that the internal curl state was invalid. Signed-off-by: Matthew Booth <[email protected]> Tested-by: Richard W.M. Jones <[email protected]> Signed-off-by: Kevin Wolf <[email protected]>
38bbc0a580f9f10570b1d1b5d3e92f0e6feb2970
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/38bbc0a580f9f10570b1d1b5d3e92f0e6feb2970
2014-04-30 16:34:08+02:00
gtk: Don't use deprecated vte_terminal_get_adjustment Guard this with a VTE version check, since I'm not sure if this is backwards compatible. ui/gtk.c: In function ‘gd_vc_init’: ui/gtk.c:1176:5: error: ‘vte_terminal_get_adjustment’ is deprecated (declared at /usr/include/vte-2.90/vte/vtedeprecated.h:101) [-Werror=deprecated-declarations] Signed-off-by: Cole Robinson <[email protected]> Signed-off-by: Gerd Hoffmann <[email protected]>
105923e08c724c2a5561673442bca91ddab83b41
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/105923e08c724c2a5561673442bca91ddab83b41
2014-04-29 10:46:30+02:00
configure: use do_cc when checking for -fstack-protector support MacOSX clang silently swallows unrecognized -f options when doing a link with '-framework' also on the command line, so to detect support for the various -fstack-protector options we must do a plain .c to .o compile, not a complete compile-and-link. Signed-off-by: Peter Maydell <[email protected]> Reviewed-by: Michael S. Tsirkin <[email protected]> Message-id: [email protected]
0a9077ea144a7e6a6f456b94e2d2eaad21e74d34
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/0a9077ea144a7e6a6f456b94e2d2eaad21e74d34
2014-04-10 22:17:47+01:00
Revert "fix return check for KVM_GET_DIRTY_LOG ioctl" This reverts commit b533f658a98325d0e47b36113bd9f5bcc046fdae. The original code was wrong, because effectively it ignored errors from kernel, because kernel does not return -1 on error case but returns -errno, and does not return -EPERM for this particular ioctl. But in some cases kernel actually returned unsuccessful result, namely, when the dirty bitmap in requested slot does not exist it returns -ENOENT. With new code this condition becomes an error when it shouldn't be. Revert that patch instead of fixing it properly this late in the release process. I disagree with this approach, but let's make things move _somewhere_, instead of arguing endlessly whch of the 2 proposed fixes is better. Signed-off-by: Michael Tokarev <[email protected]> Message-id: [email protected] Signed-off-by: Peter Maydell <[email protected]>
50212d6346f33d6e19489e81b025b5c3bb8759be
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/50212d6346f33d6e19489e81b025b5c3bb8759be
2014-04-14 15:40:02+01:00
target-arm: A64: Correctly fault FP/Neon if CPACR.FPEN set For the A64 instruction set, the only FP/Neon disable trap is the CPACR FPEN bits, which may indicate "enabled", "disabled" or "disabled for EL0". Add a bit to the AArch64 tb flags indicating whether FP/Neon access is currently enabled and make the decoder emit code to raise exceptions on use of FP/Neon insns if it is not. We use a new flag in DisasContext rather than borrowing the existing vfp_enabled flag because the A32/T32 decoder is going to need both. Signed-off-by: Peter Maydell <[email protected]> Acked-by: Peter Crosthwaite <[email protected]> --- I'm aware this is a rather hard to review patch; sorry. I have done an exhaustive check that we have fp access checks in all code paths with the aid of the assertions added in the next patch plus the code-coverage hack patch I posted to the list earlier. This patch is correct as of 09e037354 target-arm: A64: Add saturating accumulate ops (USQADD/SUQADD) which was the last of the Neon insns to be added, so assuming no refactoring of the code it should be fine.
8c6afa6ab158467d1938cc92022135bc7a872006
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/8c6afa6ab158467d1938cc92022135bc7a872006
2014-04-17 21:34:03+01:00
arm: translate.c: Fix smlald Instruction The smlald (and probably smlsld) instruction was doing incorrect sign extensions of the operands amongst 64bit result calculation. The instruction psuedo-code is: operand2 = if m_swap then ROR(R[m],16) else R[m]; product1 = SInt(R[n]<15:0>) * SInt(operand2<15:0>); product2 = SInt(R[n]<31:16>) * SInt(operand2<31:16>); result = product1 + product2 + SInt(R[dHi]:R[dLo]); R[dHi] = result<63:32>; R[dLo] = result<31:0>; The result calculation should be done in 64 bit arithmetic, and hence product1 and product2 should be sign extended to 64b before calculation. The current implementation was adding product1 and product2 together then sign-extending the intermediate result leading to false negatives. E.G. if product1 = product2 = 0x4000000, their sum = 0x80000000, which will be incorrectly interpreted as -ve on sign extension. We fix by doing the 64b extensions on both product1 and product2 before any addition/subtraction happens. We also fix where we were possibly incorrectly setting the Q saturation flag for SMLSLD, which the ARM ARM specifically says is not set. Reported-by: Christina Smith <[email protected]> Signed-off-by: Peter Crosthwaite <[email protected]> Reviewed-by: Peter Maydell <[email protected]> Message-id: 2cddb6f5a15be4ab8d2160f3499d128ae93d304d.1397704570.git.peter.crosthwaite@xilinx.com Cc: [email protected] Signed-off-by: Peter Maydell <[email protected]>
33bbd75a7c3321432fe40a8cbacd64619c56138c
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/33bbd75a7c3321432fe40a8cbacd64619c56138c
2014-04-17 21:34:07+01:00
PPC: openpic_kvm: Filter memory events properly Commit 6f1834a2b exposed a bug in openpic_kvm where we don't filter for memory events that only happen to the region we want to know events about. Add proper filtering, fixing the e500plat target with KVM. Signed-off-by: Alexander Graf <[email protected]> Message-id: [email protected] Signed-off-by: Peter Maydell <[email protected]>
87d8354de3560eb705bcee83142d775f703177a6
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/87d8354de3560eb705bcee83142d775f703177a6
2014-04-03 12:43:17+01:00
ui/vnc: fix vmware VGA incompatiblities this fixes invalid rectangle updates observed after commit 12b316d with the vmware VGA driver. The issues occured because the server and client surface update seems to be out of sync at some points and the max width of the surface is not dividable by VNC_DIRTY_BITS_PER_PIXEL (16). Reported-by: Serge Hallyn <[email protected]> Signed-off-by: Peter Lieven <[email protected]> Signed-off-by: Gerd Hoffmann <[email protected]>
2f487a3d40faff1772e14da6b921900915501f9a
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/2f487a3d40faff1772e14da6b921900915501f9a
2014-03-18 08:21:24+01:00
uhci: invalidate queue on device address changes Signed-off-by: Gerd Hoffmann <[email protected]>
c348e481759057c925cce4bf54336f1518b8c702
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/c348e481759057c925cce4bf54336f1518b8c702
2014-02-18 15:39:13+01:00
vvfat: correctly propagate errors Before: $ ./qemu-io-old qemu-io-old> open -r -o driver=vvfat,fat-type=24,dir=i386-softmmu Valid FAT types are only 12, 16 and 32 qemu-io-old: can't open device (null): Could not open image: Invalid argument After: $ ./qemu-io qemu-io> open -r -o driver=vvfat,fat-type=24,dir=i386-softmmu qemu-io: can't open device (null): Valid FAT types are only 12, 16 and 32 Signed-off-by: Paolo Bonzini <[email protected]> Reviewed-by: Fam Zheng <[email protected]> Signed-off-by: Kevin Wolf <[email protected]>
c0f92b526dbd45fc5b539f51b7379156814dafe9
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/c0f92b526dbd45fc5b539f51b7379156814dafe9
2014-02-21 21:02:23+01:00
hw/arm/allwinner-a10: initialize EMAC Signed-off-by: Beniamino Galvani <[email protected]> Reviewed-by: Peter Crosthwaite <[email protected]> Reviewed-by: Peter Maydell <[email protected]> Signed-off-by: Peter Maydell <[email protected]>
db7dfd4c7e4450b10048a53ce67bcac6305ad383
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/db7dfd4c7e4450b10048a53ce67bcac6305ad383
2014-02-08 14:50:48+00:00
tests/.gitignore: Ignore tests/check-qom-interface Signed-off-by: Fam Zheng <[email protected]> Signed-off-by: Michael Tokarev <[email protected]>
b76afd1072e02fe77e09790fbe1e831700976c5f
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/b76afd1072e02fe77e09790fbe1e831700976c5f
2014-02-01 13:56:31+04:00
dataplane: replace iothread object_add() with embedded instance Before IOThread was its own object, each virtio-blk device would create its own internal thread. We need to preserve this behavior for backwards compatibility when users do not specify -device virtio-blk-pci,iothread=<id>. This patch changes how the internal IOThread object is created. Previously we used the monitor object_add() function, which is really a layering violation. The problem is that this needs to assign a name but we don't have a name for this internal object. Generating names for internal objects is a pain but even worse is that they may collide with user-defined names. Paolo Bonzini <[email protected]> suggested that the internal IOThread object should not be named. This way the conflict cannot happen and we no longer need object_add(). One gotcha is that internal IOThread objects will not be listed by the query-iothreads command since they are not named. This is okay though because query-iothreads is new and the internal IOThread is just for backwards compatibility. New users should explicitly define IOThread objects. Reported-by: Christian Borntraeger <[email protected]> Signed-off-by: Stefan Hajnoczi <[email protected]> Reviewed-by: Paolo Bonzini <[email protected]> Tested-by: Christian Borntraeger <[email protected]> Signed-off-by: Kevin Wolf <[email protected]>
54bee5c2b487250dcb8631ddff4307f329ec0541
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/54bee5c2b487250dcb8631ddff4307f329ec0541
2014-04-04 20:48:13+02:00
qemu-io: New command 'sleep' There is no easy way to check that a request correctly waits for a different request. With a sleep command we can at least approximate it. Signed-off-by: Kevin Wolf <[email protected]>
cd33d02a1012e58ee0d3c8259159e8c60cfa0a4d
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/cd33d02a1012e58ee0d3c8259159e8c60cfa0a4d
2014-01-24 17:40:03+01:00
blkdebug: Always call read_config() Move the check whether there actually is a config file into the read_config() function. Signed-off-by: Max Reitz <[email protected]> Reviewed-by: Kevin Wolf <[email protected]> Reviewed-by: Eric Blake <[email protected]> Signed-off-by: Kevin Wolf <[email protected]>
85a040e5485413333da4fcf98bc8b28c92fa623f
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/85a040e5485413333da4fcf98bc8b28c92fa623f
2014-01-22 12:07:17+01:00
vl.c: Abort on unknown -numa option type Abort in case an invalid -numa option is provided, instead of silently ignoring it. Signed-off-by: Eduardo Habkost <[email protected]> Reviewed-by: Eric Blake <[email protected]> Signed-off-by: Anthony Liguori <[email protected]>
12e53a9d59c8cb272a423e1db036324579a3c697
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/12e53a9d59c8cb272a423e1db036324579a3c697
2013-02-04 14:38:33-06:00
tests: Add test for qdict_flatten() Add a test case for qdict_flatten() in tests/check-qdict.c. This test case covers the flattening of subordinate QLists as well. Signed-off-by: Max Reitz <[email protected]> Reviewed-by: Eric Blake <[email protected]> Signed-off-by: Kevin Wolf <[email protected]>
3fb11779ca5f1d601adeb5870ba79e61e81a4cce
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/3fb11779ca5f1d601adeb5870ba79e61e81a4cce
2014-01-22 12:07:18+01:00
vfio-pci: Fix Nvidia MSI ACK through 0x88000 quirk When MSI is enabled on Nvidia GeForce cards the driver seems to acknowledge the interrupt by writing a 0xff byte to the MSI capability ID register using the PCI config space mirror at offset 0x88000 from BAR0. Without this, the device will only fire a single interrupt. VFIO handles the PCI capability ID/next registers as virtual w/o write support, so any write through config space is currently dropped. Add a check for this and allow the write through the BAR window. The registers are read-only anyway. Signed-off-by: Alex Williamson <[email protected]>
96eeeba0db38b856eb2cae0e4a2a620d8d65771a
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/96eeeba0db38b856eb2cae0e4a2a620d8d65771a
2013-12-06 11:16:23-07:00
target-arm: Provide mechanism for getting KVM constants even if not CONFIG_KVM There are a number of places where it would be convenient for ARM code to have working definitions of KVM constants even in code which is compiled with CONFIG_KVM not set. In this situation we can't simply include the kernel KVM headers (which might conflict with host header definitions or not even compile on the compiler we're using) so we have to redefine equivalent constants. Provide a mechanism for doing this and checking that the values match, and use it for the constants we're currently exposing via an ad-hoc mechanism. Signed-off-by: Peter Maydell <[email protected]> Reviewed-by: Christoffer Dall <[email protected]> Message-id: [email protected]
72b0cd35ad3e216a1db7f6a08a2ff65bb577c119
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/72b0cd35ad3e216a1db7f6a08a2ff65bb577c119
2013-12-10 13:28:29+00:00
block: add wrappers for logical block provisioning information This adds 2 wrappers to read the unallocated_blocks_are_zero and can_write_zeroes_with_unmap info from the BDI. The wrappers are required to check for the existence of a backing_hd and if the devices are opened with the correct flags. Reviewed-by: Eric Blake <[email protected]> Signed-off-by: Peter Lieven <[email protected]> Signed-off-by: Stefan Hajnoczi <[email protected]>
4ce786914b745a144a9eda1ea33f3ff98328c527
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/4ce786914b745a144a9eda1ea33f3ff98328c527
2013-11-28 10:30:51+01:00
usb-host-libusb: Detach kernel drivers earlier If we detach the kernel drivers on the first set_config, then they will be still attached when the device gets its initial reset. Causing the drivers to re-initialize the device after the reset, dirtying the device state. Signed-off-by: Hans de Goede <[email protected]> Signed-off-by: Gerd Hoffmann <[email protected]>
f34d5c750897abb3853910ce73f63d88d74dc827
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/f34d5c750897abb3853910ce73f63d88d74dc827
2013-10-22 16:28:49+02:00
tcg: Remove stray semi-colons from target-*/helper.h During GEN_HELPER=1, these are actually stray top-level semi-colons which are technically invalid ISO C, but GCC accepts as an extension. If we added enough __extension__ markers that we could dare use -Wpedantic, we'd see warning: ISO C does not allow extra ‘;’ outside of a function This will become a hard error in the next patch, wherein those ; will appear in the middle of a data structure. Reviewed-by: Peter Maydell <[email protected]> Signed-off-by: Richard Henderson <[email protected]>
f5daeec412b9624ba902bdba26edff88a1694ea6
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/f5daeec412b9624ba902bdba26edff88a1694ea6
2013-10-10 11:43:37-07:00
lsi: check ssid versus sdid only if ssid is valid This prevents some (invalid) error messages on console. Signed-off-by: Hervé Poussineau <[email protected]> Signed-off-by: Paolo Bonzini <[email protected]>
c7ac9f403af37439da0ce650b68bbcb13439768e
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/c7ac9f403af37439da0ce650b68bbcb13439768e
2013-09-16 12:42:18+02:00
pc_q35: Initialize Xen. Signed-off-by: Anthony PERARD <[email protected]> Signed-off-by: Stefano Stabellini <[email protected]> Acked-by: Michael S. Tsirkin <[email protected]>
254c12825f93f405658ca3366cd34f8a8ad23511
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/254c12825f93f405658ca3366cd34f8a8ad23511
2013-09-09 16:24:33+00:00
kvm irqfd: support direct msimessage to irq translation On PPC64 systems MSI Messages are translated to system IRQ in a PCI host bridge. This is already supported for emulated MSI/MSIX but not for irqfd where the current QEMU allocates IRQ numbers from irqchip and maps MSIMessages to IRQ in the host kernel. This adds a new direct mapping flag which tells the kvm_irqchip_add_msi_route() function that a new VIRQ should not be allocated, instead the value from MSIMessage::data should be used. It is up to the platform code to make sure that this contains a valid IRQ number as sPAPR does in spapr_pci.c. Signed-off-by: Alexey Kardashevskiy <[email protected]> Signed-off-by: Paolo Bonzini <[email protected]>
76fe21dedafb0319306bc993f23e7646b139cfe4
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/76fe21dedafb0319306bc993f23e7646b139cfe4
2013-09-20 12:37:52+02:00
qemu-timer: drop outdated signal safety comments host_alarm_handler() is invoked from the signal processing thread (currently the iothread). Previously we did processing in a real signal handler with signalfd and therefore needed signal-safe timer code. Today host_alarm_handler() just marks the alarm timer as expired/pending and notifies the main loop using qemu_notify_event(). Therefore these outdated comments about signal safety can be dropped. Signed-off-by: Stefan Hajnoczi <[email protected]>
da718ceb1730bfe6fea0178df979639b14a0646e
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/da718ceb1730bfe6fea0178df979639b14a0646e
2013-09-18 15:48:33+02:00
checkpatch.pl: Check .cpp files Enable checkpatch.pl to apply the same checks as C source files for C++ files with .cpp extensions. It also adds some exceptions for C++ sources to suppress errors for: - <> used in C++ template arguments (e.g. template <class T>) - :: used to represent namespaces (e.g. SomeClass::method()) - : used in class declaration (e.g. class T : public Super) - ~ used in destructor method name (e.g. T::~T()) - spacing around 'catch' (e.g. catch (...)) Signed-off-by: Tomoki Sekiyama <[email protected]> Reviewed-by: Michael Roth <[email protected]> Signed-off-by: Michael Roth <[email protected]>
69d5d21f90516a8b988a88915865b38e543fc994
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/69d5d21f90516a8b988a88915865b38e543fc994
2013-09-09 14:17:56-05:00
block: Add iops_size to do the iops accounting for a given io size. This feature can be used in case where users are avoiding the iops limit by doing jumbo I/Os hammering the storage backend. Signed-off-by: Benoit Canet <[email protected]> Signed-off-by: Stefan Hajnoczi <[email protected]>
2024c1df43eae0d2e35663da0c6e8c51290a386e
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/2024c1df43eae0d2e35663da0c6e8c51290a386e
2013-09-06 15:25:07+02:00
tcg: Tidy softmmu_template.h Avoid a loop in the tlb_fill path; the fill will either succeed or generate an exception. Inline the slow_ld/st function; it was a complete copy of the main helper except for the actual cross-page unaligned code, and the compiler was inlining it anyway. Add unlikely markers optimizing for the most common case of simple tlb miss. Make sure the compiler can optimize away the unaligned paths for a 1 byte access. Reviewed-by: Aurelien Jarno <[email protected]> Signed-off-by: Richard Henderson <[email protected]>
aac1fb0576e5bea72681e91c38caffc17741eb80
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/aac1fb0576e5bea72681e91c38caffc17741eb80
2013-08-26 13:31:54-07:00
aio / timers: Rename qemu_new_clock and expose clock types Rename qemu_new_clock to qemu_clock_new. Expose clock types. Signed-off-by: Alex Bligh <[email protected]> Signed-off-by: Stefan Hajnoczi <[email protected]>
58ac56b9ad53b006396523639bb7d7043edc56bf
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/58ac56b9ad53b006396523639bb7d7043edc56bf
2013-08-22 15:58:05+02:00
aio / timers: Untangle include files include/qemu/timer.h has no need to include main-loop.h and doing so causes an issue for the next patch. Unfortunately various files assume including timers.h will pull in main-loop.h. Untangle this mess. Signed-off-by: Alex Bligh <[email protected]> Signed-off-by: Stefan Hajnoczi <[email protected]>
6a1751b7aad6e38e9d1ae6bcea72fa28bf6cc5fb
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/6a1751b7aad6e38e9d1ae6bcea72fa28bf6cc5fb
2013-08-22 19:10:27+02:00
vmdk: check l2 table size when opening header.num_gtes_per_gte determines size for L2 table. Check for too big value before using it. Limit to 512M entries (2GB per one L2 table). Signed-off-by: Fam Zheng <[email protected]> Signed-off-by: Kevin Wolf <[email protected]>
f8ce04036e333aae480b1d06d969f6436652633d
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/f8ce04036e333aae480b1d06d969f6436652633d
2013-08-06 15:27:32+02:00
virtio: virtqueue_get_avail_bytes: fix desc_pa when loop over the indirect descriptor table virtqueue_get_avail_bytes: when found a indirect desc, we need loop over it. /* loop over the indirect descriptor table */ indirect = 1; max = vring_desc_len(desc_pa, i) / sizeof(VRingDesc); num_bufs = i = 0; desc_pa = vring_desc_addr(desc_pa, i); But, It init i to 0, then use i to update desc_pa. so we will always get: desc_pa = vring_desc_addr(desc_pa, 0); the last two line should swap. Cc: [email protected] Signed-off-by: Yin Yin <[email protected]> Reviewed-by: Stefan Hajnoczi <[email protected]> Signed-off-by: Michael S. Tsirkin <[email protected]>
1ae2757c6c4525c9b42f408c86818f843bad7418
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/1ae2757c6c4525c9b42f408c86818f843bad7418
2013-08-25 12:52:33+03:00
dump: clamp guest-provided mapping lengths to ramblock sizes Even a trusted & clean-state guest can map more memory than what it was given. Since the vmcore contains RAMBlocks, mapping sizes should be clamped to RAMBlock sizes. Otherwise such oversized mappings can exceed the entire file size, and ELF parsers might refuse even the valid portion of the PT_LOAD entry. Related RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=981582 Signed-off-by: Laszlo Ersek <[email protected]> Signed-off-by: Luiz Capitulino <[email protected]>
2cac260768b9d4253737417ea7501cf2950e257f
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/2cac260768b9d4253737417ea7501cf2950e257f
2013-08-08 11:01:45-04:00
OptsVisitor: introduce basic list modes We're going to need more state while processing a list of repeated options. This change eliminates "repeated_opts_first" and adds a new state variable: list_mode repeated_opts repeated_opts_first -------------- ------------- ------------------- LM_NONE NULL false LM_STARTED non-NULL true LM_IN_PROGRESS non-NULL false Additionally, it is documented that lookup_scalar() and processed(), both called by opts_type_XXX(), are invalid in LM_STARTED -- generated qapi code calls opts_next_list() to allocate the very first link before trying to parse a scalar into it. List mode restrictions are expressed in positive / inclusive form. Signed-off-by: Laszlo Ersek <[email protected]> Tested-by: Wanlong Gao <[email protected]> Signed-off-by: Luiz Capitulino <[email protected]>
d95704341280fc521dc2b16bbbc5858f6647e2c3
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/d95704341280fc521dc2b16bbbc5858f6647e2c3
2013-08-20 11:51:59-04:00
spice: fix display initialization Spice has two display interface implementations: One integrated into the qxl graphics card, and one generic which can operate with every qemu-emulated graphics card. The generic one is activated in case spice is used without qxl. The logic for that only caught the "-vga qxl" case, "-device qxl-vga" goes unnoticed. Fix that by adding a check in the spice interface registration so we'll notice the qxl card no matter how it is created. https://bugzilla.redhat.com/show_bug.cgi?id=981094 Signed-off-by: Gerd Hoffmann <[email protected]>
58ae52a8dc7752e3da9a905678580b4cb8181cdc
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/58ae52a8dc7752e3da9a905678580b4cb8181cdc
2013-07-30 10:25:47+02:00
spapr_rtas: Abstract rtas_start_cpu() with qemu_get_cpu() Instead of looping over all CPUArchState, use a helper to obtain the desired CPUState. Free the "cpu" variable for PowerPCCPU, to access its CPUPPCState. Signed-off-by: Andreas Färber <[email protected]>
c67e216bdf42abfb8505790b2da9562356103976
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/c67e216bdf42abfb8505790b2da9562356103976
2013-06-13 00:11:14+02:00
exec: implement .valid.accepts for subpages Reviewed-by: Richard Henderson <[email protected]> Signed-off-by: Paolo Bonzini <[email protected]>
c353e4cc08a2fce7c505dd0d04512ef3947adff8
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/c353e4cc08a2fce7c505dd0d04512ef3947adff8
2013-05-29 16:27:14+02:00
cpu: Drop unnecessary dynamic casts in *_env_get_cpu() A transition from CPUFooState to FooCPU can be considered safe, just like FooCPU::env access in the opposite direction. The only benefit of the FOO_CPU() casts would be protection against bogus CPUFooState pointers, but then surrounding code would likely break, too. This should slightly improve interrupt etc. performance when going from CPUFooState to FooCPU. For any additional CPU() casts see 3556c233d931ad5ffa46a35cb25cfc057732ebb8 (qom: allow turning cast debugging off). Reported-by: Anthony Liguori <[email protected]> Acked-by: Richard Henderson <[email protected]> Signed-off-by: Andreas Färber <[email protected]>
6e42be7cd10260fd3a006d94f6c870692bf7a2c0
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/6e42be7cd10260fd3a006d94f6c870692bf7a2c0
2013-07-09 21:20:28+02:00
block: move snapshot code in block.c to block/snapshot.c All snapshot related code, except bdrv_snapshot_dump() and bdrv_is_snapshot(), is moved to block/snapshot.c. bdrv_snapshot_dump() will be moved to another file later. bdrv_is_snapshot() is not related with internal snapshot. It also fixes small code style errors reported by check script. Signed-off-by: Wenchao Xia <[email protected]> Signed-off-by: Kevin Wolf <[email protected]>
de08c606f9ddafe647b6843e2b10a6d6030b0fc0
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/de08c606f9ddafe647b6843e2b10a6d6030b0fc0
2013-06-04 13:56:30+02:00
qemu: add castagnoli crc32c checksum algorithm This adds the Castagnoli CRC32C algorithm, using the 0x11EDC6F41 polynomial. This is extracted from the linux kernel cryptographic crc32.c module. The algorithm is based on: Castagnoli93: Guy Castagnoli and Stefan Braeuer and Martin Herrman "Optimization of Cyclic Redundancy-Check Codes with 24 and 32 Parity Bits", IEEE Transactions on Communication, Volume 41, Number 6, June 1993 Signed-off-by: Jeff Cody <[email protected]> Signed-off-by: Stefan Hajnoczi <[email protected]>
8e1b02b8ef2eefcb2ff3855531d7bc2ea71e1fb4
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/8e1b02b8ef2eefcb2ff3855531d7bc2ea71e1fb4
2013-05-03 10:31:58+02:00
bsd-user: OS-agnostic 64-bit SYSCTL types Use existence of type as #ifdef condition rather than FreeBSD-specific version check, as suggested by Patrick Welche. Also handle the signed (CTLTYPE_S64) case identically to the unsigned (CTLTYPE_U64) case, per later patches in the FreeBSD ports tree (emulators/qemu-devel/files/patch-z-arm-bsd-user-001). Signed-off-by: Ed Maste <[email protected]> Signed-off-by: Michael Tokarev <[email protected]>
e6a3ee5f7981e7df40aa581ebc245fd0a7d3bed0
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/e6a3ee5f7981e7df40aa581ebc245fd0a7d3bed0
2013-05-12 13:25:55+04:00
qemu-char: correct return value from chr_read functions Even if a CharDriverState's source is blocked by the front-end, it must not be dropped. The IOWatchPoll that wraps it will take care of adding and removing it to the main loop. Only remove the source when the channel is closed; and in that case, make sure that the wrapping IOWatchPoll is removed too. These should just be theoretical bugs. Signed-off-by: Paolo Bonzini <[email protected]> Message-id: [email protected] Signed-off-by: Anthony Liguori <[email protected]>
cdbf6e165988ab9d7c01da03b9e27bb8ac0c76aa
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/cdbf6e165988ab9d7c01da03b9e27bb8ac0c76aa
2013-04-22 08:52:20-05:00
ccid-card-passthru, dev-smartcard-reader: add debug environment variables Introduces a new utility function: parse_debug_env to avoid code duplication. This overrides whatever debug value is set on the corresponding devices from the command line, and is meant to ease the usage with any management stack. For libvirt you can set environment variables by extending the dom namespace, i.e: <domain type='kvm' id='3' xmlns:qemu='http://libvirt.org/schemas/domain/qemu/1.0'> <qemu:commandline> <qemu:env name='QEMU_CCID_PASSTHRU_DEBUG' value='4'/> <qemu:env name='QEMU_CCID_DEBUG' value='4'/> </qemu:commandline> </domain> Signed-off-by: Alon Levy <[email protected]> Reviewed-by: Marc-André Lureau <[email protected]>
b16352acf3105000e14f194b556e159d5d06cff9
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/b16352acf3105000e14f194b556e159d5d06cff9
2013-04-24 11:47:57+03:00
block: fix BDRV_O_SNAPSHOT protocol detection realpath(3) is used to get an absolute path to the image file when creating a -drive snapshot=on temporary qcow2. This does not work for protocols since their filenames ("proto:foo:...") do not correspond to file system paths. Commit 7c96d46ec245d73fd76726588409f9abe4bd5dc1 ("Let snapshot work with protocols") skipped realpath(3) for protocols. Later on the "raw" format was introduced and broke the check. Use path_has_protocol(filename) to decide if this image uses a protocol or a filename. Reported-by: Richard Jones <[email protected]> Signed-off-by: Stefan Hajnoczi <[email protected]> Signed-off-by: Kevin Wolf <[email protected]>
4d70655bcb852ea0a006d3923f0b0a9c69ff462e
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/4d70655bcb852ea0a006d3923f0b0a9c69ff462e
2013-03-19 11:48:37+01:00
qcow2: introduce check_refcounts_l1/l2() flags The check_refcounts_l1/l2() functions have a check_copied argument to check that the QCOW_O_COPIED flag is consistent with refcount == 1. This should be a bool, not an int. However, the next patch introduces qcow2 fragmentation statistics and also needs to pass an option to check_refcounts_l1/l2(). This is a good opportunity to use an int flags field. Signed-off-by: Stefan Hajnoczi <[email protected]>
801f70445293ec8ed2d78fd92313c2f71fa48ac9
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/801f70445293ec8ed2d78fd92313c2f71fa48ac9
2013-02-22 21:21:09+01:00
vl.c: validate -numa "cpus" parameter properly - Accept empty strings without aborting - Use parse_uint*() to parse numbers - Abort if anything except '-' or end-of-string is found after the first number. - Check for endvalue < value Also change the MAX_CPUMASK_BITS warning message from "A max of %d CPUs are supported in a guest" to "qemu: NUMA: A max of %d VCPUs are supported". Signed-off-by: Eduardo Habkost <[email protected]> Reviewed-by: Eric Blake <[email protected]> Signed-off-by: Anthony Liguori <[email protected]>
c881e20eed4911ab6f8c674f2b1bf225a2cdde71
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/c881e20eed4911ab6f8c674f2b1bf225a2cdde71
2013-02-04 14:38:35-06:00
mac_nvram: QOM'ify MacIO NVRAM It was not qdev'ified before. Turn it into a SysBusDevice and initialize it via static properties. Prepare Old World specific MacIO state and embed the NVRAM state there. Drop macio_nvram_setup_bar() in favor of sysbus_mmio_map() or direct use of Memory API. Signed-off-by: Andreas Färber <[email protected]> Signed-off-by: Alexander Graf <[email protected]>
95ed3b7cf1677dc9f995a6e1fcc7bf377cf94a0e
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/95ed3b7cf1677dc9f995a6e1fcc7bf377cf94a0e
2013-01-25 22:02:54+01:00
PPC: KVM: set has-idle in guest device tree On e500mc, the platform doesn't provide a way for the CPU to go idle. To still not uselessly burn CPU time, expose an idle hypercall to the guest if kvm supports it. Signed-off-by: Stuart Yoder <[email protected]> [agraf: adjust for current code base, add patch description, fix non-kvm case] Signed-off-by: Alexander Graf <[email protected]>
1a61a9ae61cdf7b7d24c3eb711fe772c196c235e
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/1a61a9ae61cdf7b7d24c3eb711fe772c196c235e
2013-01-07 17:37:11+01:00
cpu: Move cpu_index field to CPUState Note that target-alpha accesses this field from TCG, now using a negative offset. Therefore the field is placed last in CPUState. Pass PowerPCCPU to [kvm]ppc_fixup_cpu() to facilitate this change. Move common parts of mips cpu_state_reset() to mips_cpu_reset(). Acked-by: Richard Henderson <[email protected]> (for alpha) [AF: Rebased onto ppc CPU subclasses and openpic changes] Signed-off-by: Andreas Färber <[email protected]>
55e5c2850293547203874098f7cec148ffd12dfa
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/55e5c2850293547203874098f7cec148ffd12dfa
2013-01-15 04:09:13+01:00
qemu-char: eliminate busy waiting on can_read returning zero The character backend refactoring introduced an undesirable busy wait. The busy wait happens if can_read returns zero and there is data available on the character device's file descriptor. Then, the I/O watch will fire continuously and, with TCG, the CPU thread will never run. 1) Char backend asks front end if it can write 2) Front end says no 3) poll() finds the char backend's descriptor is available 4) Goto (1) What we really want is this (note that step 3 avoids the busy wait): 1) Char backend asks front end if it can write 2) Front end says no 3) poll() goes on without char backend's descriptor 4) Goto (1) until qemu_chr_accept_input() called 5) Char backend asks front end if it can write 6) Front end says yes 7) poll() finds the char backend's descriptor is available 8) Backend handler called After this patch, the IOWatchPoll source and the watch source are separated. The IOWatchPoll is simply a hook that runs during the prepare phase on each main loop iteration. The hook adds/removes the actual source depending on the return value from can_read. A simple reproducer is qemu-system-i386 -serial mon:stdio ... followed by banging on the terminal as much as you can. :) Without this patch, emulation will hang. Signed-off-by: Paolo Bonzini <[email protected]> Message-id: [email protected] Signed-off-by: Anthony Liguori <[email protected]>
d185c094b404b4ff392b77d1244c0233da7d53bd
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/d185c094b404b4ff392b77d1244c0233da7d53bd
2013-04-05 12:53:07-05:00
virtio-pci: replace byte swap hack Remove byte swaps by declaring the config space as native endian. Signed-off-by: Blue Swirl <[email protected]>
9807caccd605d09a72495637959568d690e10175
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/9807caccd605d09a72495637959568d690e10175
2013-01-06 08:24:26+00:00
target-s390: Convert FP LOAD COMPLIMENT, NEGATIVE, POSITIVE Signed-off-by: Richard Henderson <[email protected]>
5d7fd045cafeac1831c1999cb9e1251b7906c6b2
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/5d7fd045cafeac1831c1999cb9e1251b7906c6b2
2013-01-05 12:18:41-08:00
openpic: add some bounds checking for IRQ numbers The two checks with abort() guard against potential QEMU-internal problems, but the EOI check stops the guest from causing updates to queue position -1 and other havoc if it writes EOI with no interrupt in service. Signed-off-by: Scott Wood <[email protected]> [agraf: remove hunk in code that didn't get applied yet] Signed-off-by: Alexander Graf <[email protected]>
65b9d0d5659687ebb85b1305ac70b3a84df16e5a
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/65b9d0d5659687ebb85b1305ac70b3a84df16e5a
2013-01-07 17:37:10+01:00
pci: update all users to look in pci/ update all users so we can remove the makefile hack. Signed-off-by: Michael S. Tsirkin <[email protected]>
a2cb15b0ddfa05f81a42d7b65dd0c7c50e420c33
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/a2cb15b0ddfa05f81a42d7b65dd0c7c50e420c33
2012-12-17 13:02:26+02:00
hw/ds1338.c: Ensure state is properly initialized. Signed-off-by: Antoine Mathys <[email protected]> Signed-off-by: Peter Maydell <[email protected]>
ed3d37d287300b7bcdb4605b921e5ec593afd214
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/ed3d37d287300b7bcdb4605b921e5ec593afd214
2012-12-13 14:05:28+00:00
qxl+vnc: register a vm state change handler for dummy spice_server When qxl + vnc are used, a dummy spice_server is initialized. The spice_server has to be told when the VM runstate changes, which is what this patch does. Without it, from qxl_send_events(), the following error message is shown: qxl_send_events: spice-server bug: guest stopped, ignoring Cc: [email protected] Signed-off-by: Uri Lublin <[email protected]> Signed-off-by: Gerd Hoffmann <[email protected]>
938b8a36b65e44c44ca29245437f8d7ac0f826e8
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/938b8a36b65e44c44ca29245437f8d7ac0f826e8
2012-12-17 14:01:32+01:00
xhci: add xhci_port_have_device Factor out the code which checks whenever a usb device is attached to the port in question. No functional change. Signed-off-by: Gerd Hoffmann <[email protected]>
6a32f80f056b577d275268e4f6f3477ba721c94f
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/6a32f80f056b577d275268e4f6f3477ba721c94f
2012-11-01 13:10:09+01:00
virtfs-proxy-helper: use setresuid and setresgid The setfsuid and setfsgid system calls are obscure and they complicate the error checking (that glibc's warn_unused_result "feature" forces us to do). Switch to the standard setresuid and setresgid functions. Signed-off-by: Paolo Bonzini <[email protected] Signed-off-by: Aneesh Kumar K.V <[email protected]>
9fd2ecdc8cb2dc1a8a7c57b6c9c60bc9947b6a73
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/9fd2ecdc8cb2dc1a8a7c57b6c9c60bc9947b6a73
2012-12-05 21:55:54+05:30
main-loop: unify qemu_init_main_loop between QEMU and tools Signed-off-by: Paolo Bonzini <[email protected]>
172061a0a0d98c974ea8d5ed715195237bc44225
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/172061a0a0d98c974ea8d5ed715195237bc44225
2012-10-30 09:18:44+01:00
tests: allow qemu-iotests to be run against nbd backend To do this, we start a qemu-nbd process at _make_test_img and kill it in _cleanup_test_img. $TEST_IMG is changed to point at the TCP server. We also remove the checks for existence of binaries from common.config - they're duplicated in common, and we can make the qemu-nbd check conditional on $IMGPROTO being "nbd" if we do it there. Signed-off-by: Nick Thomas <[email protected]> Acked-by: Paolo Bonzini <[email protected]> Signed-off-by: Kevin Wolf <[email protected]>
a9660664fde89ef2c7bc629eda547a48b288fbb9
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/a9660664fde89ef2c7bc629eda547a48b288fbb9
2012-11-14 18:19:21+01:00
raw-win32: implement native asynchronous I/O With the new support for EventNotifiers in the AIO event loop, we can hook a completion port to every opened file and use asynchronous I/O on them. Wine's support is extremely inefficient, also because it really does the I/O synchronously on regular files. (!) But it works, and it is good to keep the Win32 and POSIX ports as similar as possible. Signed-off-by: Paolo Bonzini <[email protected]>
a27365265cc2fed1178bf25a205e8ee02a9c0caf
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/a27365265cc2fed1178bf25a205e8ee02a9c0caf
2012-10-31 10:38:13+01:00
slirp: Handle more than 65535 blocks in TFTP transfers RFC 1350 does not mention block count roll-over. However, a lot of TFTP servers implement it to be able to transmit big files, so do it also. Current block size is 512 bytes, so TFTP files were limited to 32 MB. Signed-off-by: Hervé Poussineau <[email protected]> Signed-off-by: Jan Kiszka <[email protected]>
4aa401f39e048e71020cceb59f126ab941095a42
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/4aa401f39e048e71020cceb59f126ab941095a42
2012-09-13 12:39:36+02:00
unicore32-softmmu: Make UniCore32 cpuid & exceptions correct and runable This patch initializes the cpuid to exactly correct value because linux kernel will check it. In addition, the exception types are specified in proper situations. Then it could make exceptions generated correctly and timely. Signed-off-by: Guan Xuetao <[email protected]> Signed-off-by: Blue Swirl <[email protected]>
d48813dd7639885339e5e7a8cdf2d0e3ca714e1f
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/d48813dd7639885339e5e7a8cdf2d0e3ca714e1f
2012-08-11 09:36:56+00:00
pci_host: Turn into SysBus-derived QOM type The preceding commits fixed misuses of FROM_SYSBUS() that led people to add a bogus busdev field. For qdev the field order was less relevant but for QOM the PCIHostState field (including the SysBusDevice actually initialized with a value) must be placed first within the state struct. To facilitate accessing the PCIHostState fields, derive all PCI host bridges from TYPE_PCI_HOST_BRIDGE rather than TYPE_SYS_BUS_DEVICE. We can now access PCIHostState QOM-style, with PCI_HOST_BRIDGE() macro. Signed-off-by: Anthony Liguori <[email protected]> Signed-off-by: Wanpeng Li <[email protected]> Signed-off-by: Andreas Färber <[email protected]> Signed-off-by: Andreas Färber <[email protected]> Acked-by: Michael S. Tsirkin <[email protected]> Signed-off-by: Anthony Liguori <[email protected]>
b44ff9d430c5f2b51872f542d9562a15f0061a82
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/b44ff9d430c5f2b51872f542d9562a15f0061a82
2012-08-22 10:47:17-05:00
configure: Don't run Xen compile checks in subshells The Xen compile checks are currently run inside subshells. This is unnecessary and has the effect that if do_cc() exits with an error message then this only causes the subshell to exit, not the whole of configure, which is confusing. Remove the subshells, changing: if ( cat ; compile_prog ) ; then ... to if cat && compile_prog ; then ... Signed-off-by: Peter Maydell <[email protected]> Signed-off-by: Blue Swirl <[email protected]>
69deef089db0d2eb94b7adc6d6ac78a1cf0d5511
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/69deef089db0d2eb94b7adc6d6ac78a1cf0d5511
2012-08-04 13:25:04+00:00
expose QemuOpt and QemuOpts struct definitions to interested parties The only clients should be the existent "qemu-option.c", and the upcoming "qapi/opts-visitor.c". Signed-off-by: Laszlo Ersek <[email protected]> Signed-off-by: Stefan Hajnoczi <[email protected]>
fdb17976fc1b8cff02b52b1054562d220b9208c7
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/fdb17976fc1b8cff02b52b1054562d220b9208c7
2012-07-23 11:55:17+01:00
scsi-disk: removable hard disks support load/eject Support for the LOEJ bit of the START/STOP UNIT command right now is limited to CD-ROMs. This is wrong, since removable hard disks (in the real world: SD card readers) also support it in pretty much the same way. Without the LOEJ bit, START/STOP UNIT does nothing for all devices. Signed-off-by: Paolo Bonzini <[email protected]>
b456a71c4a1eb5704d135fd08da9a0de8fd81231
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/b456a71c4a1eb5704d135fd08da9a0de8fd81231
2012-07-27 08:25:21+02:00
qdev: Collect private helpers in one place Just code motion, with one long line wrapped to keep checkpatch.pl happy. Signed-off-by: Markus Armbruster <[email protected]> Signed-off-by: Kevin Wolf <[email protected]>
d4d34b0d3f5af5c8e09980da0de2eebe9a27dc71
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/d4d34b0d3f5af5c8e09980da0de2eebe9a27dc71
2012-07-17 16:48:31+02:00
fdc_test: introduce test_sense_interrupt Calling sense interrupt status while there is no interrupt should return invalid command (0x80). Read command should always returns in st0 seek_end bit set to 1. Signed-off-by: Pavel Hrdina <[email protected]> Signed-off-by: Kevin Wolf <[email protected]>
b3ce604eeaa77970fa53838e7df2bc85344f2554
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/b3ce604eeaa77970fa53838e7df2bc85344f2554
2012-07-09 15:53:03+02:00
json-parser: don't replicate tokens at each level of recursion Currently, when parsing a stream of tokens we make a copy of the token list at the beginning of each level of recursion so that we do not modify the original list in cases where we need to fall back to an earlier state. In the worst case, we will only read 1 or 2 tokens off the list before recursing again, which means an upper bound of roughly N^2 token allocations. For a "reasonably" sized QMP request (in this a QMP representation of cirrus_vga's device state, generated via QIDL, being passed in via qom-set), this caused my 16GB's of memory to be exhausted before any noticeable progress was made by the parser. This patch works around the issue by using single copy of the token list in the form of an indexable array so that we can save/restore state by manipulating indices. A subsequent commit adds a "large_dict" test case which exhibits the same behavior as above. With this patch applied the test case successfully completes in under a second. Tested with valgrind, make check, and QMP. Reviewed-by: Eric Blake <[email protected]> Signed-off-by: Michael Roth <[email protected]> Signed-off-by: Anthony Liguori <[email protected]>
65c0f1e9558c7c762cdb333406243fff1d687117
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/65c0f1e9558c7c762cdb333406243fff1d687117
2012-08-16 13:41:15-05:00
Exit loop if we have been there too long Checking each 64 pages is a random magic number as good as any other. We don't want to test too many times, but on the other hand, qemu_get_clock_ns() is not so expensive either. We want to be sure that we spent less than 50ms (half of buffered_file timer), if we spent more than 100ms, all the accounting got wrong. Signed-off-by: Juan Quintela <[email protected]>
4508bd9ed8053cef0a1a849bf2f1896a5dd86580
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/4508bd9ed8053cef0a1a849bf2f1896a5dd86580
2012-06-29 13:31:04+02:00
target-i386: drop usage of prev_debug_excp_handler Chains of exception handlers are currently unused feature, drop it for now so as not to expose prev_debug_excp_handler at global scope when moving tcg initialization into target-i386/cpu.c Later we probably could re-invent better interface for this. Signed-off-by: Igor Mammedov <[email protected]>
130a03855098a4057c227bc658c0688f8665b71f
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/130a03855098a4057c227bc658c0688f8665b71f
2012-06-25 15:34:02+02:00