commit_msg
stringlengths
1
24.2k
commit_hash
stringlengths
2
84
project
stringlengths
2
40
source
stringclasses
4 values
labels
int64
0
1
repo_url
stringlengths
26
70
commit_url
stringlengths
74
118
commit_date
stringlengths
25
25
target-arm: Fix TTBR selecting logic on AArch32 Stage 2 translation Address size is 40-bit for the AArch32 stage 2 translation, and t0sz can be negative (from -8 to 7), so we need to adjust it to use the existing TTBR selecting logic. Signed-off-by: Sergey Sorokin <[email protected]> Message-id: [email protected] Reviewed-by: Peter Maydell <[email protected]> Signed-off-by: Peter Maydell <[email protected]>
6e99f762612827afeff54add2e4fc2c3b2657fed
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/6e99f762612827afeff54add2e4fc2c3b2657fed
2016-06-06 16:59:32+01:00
target-i386: kvm: Simplify MSR array construction Add a helper function that appends new entries to the MSR buffer and checks for the buffer size limit. Reviewed-by: Paolo Bonzini <[email protected]> Signed-off-by: Eduardo Habkost <[email protected]>
9c600a84544dfedff238f6e0cfac0d88c58654c0
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/9c600a84544dfedff238f6e0cfac0d88c58654c0
2016-05-23 19:47:37-03:00
scsi-disk: introduce scsi_disk_req_check_error Commonize all the checks for canceled requests and errors. The next patch will add another case to check for, in order to handle passthrough commands. There is no semantic change here; the only nontrivial modification is in scsi_write_do_fua, where cancellation has been checked earlier by both callers. Thus, the check is replaced with an assertion. Signed-off-by: Paolo Bonzini <[email protected]>
5b956f415a356449a4171d5e0c7d9a25bbc84b5a
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/5b956f415a356449a4171d5e0c7d9a25bbc84b5a
2016-05-29 09:11:11+02:00
linux-user: Set r14 on exit from microblaze syscall All syscall exits on microblaze result in r14 being equal to the PC we return to, because the kernel syscall exit instruction "rtbd" does this. (This is true even for sigreturn(); note that r14 is not a userspace-usable register as the kernel may clobber it at any point.) Emulate the setting of r14 on exit; this isn't really a guest visible change for valid guest code because r14 isn't reliably observable anyway. However having the code and the comment helps to explain why it's ok for the ERESTARTSYS handling not to undo the changes to r14 that happen on syscall entry. Signed-off-by: Peter Maydell <[email protected]> Signed-off-by: Riku Voipio <[email protected]>
d7749ab770601258be7ae862b5827c42bb35e44c
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/d7749ab770601258be7ae862b5827c42bb35e44c
2016-05-27 14:49:50+03:00
include: poison symbols in osdep.h Ensure that all target-independent files ignore poisoned symbols, and fix the fallout. Signed-off-by: Paolo Bonzini <[email protected]>
bdd902277c784cfcc0c2e602afe79515070b9e02
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/bdd902277c784cfcc0c2e602afe79515070b9e02
2016-05-19 16:42:28+02:00
scsi-generic: Merge block max xfer len in INQUIRY response The rationale is similar to the above mode sense response interception: this is practically the only channel to communicate restraints from elsewhere such as host and block driver. The scsi bus we attach onto can have a larger max xfer len than what is accepted by the host file system (guarding between the host scsi LUN and QEMU), in which case the SG_IO we generate would get -EINVAL. Signed-off-by: Fam Zheng <[email protected]> Message-Id: <[email protected]> Signed-off-by: Paolo Bonzini <[email protected]>
063143d5b1fde0fdcbae30bc7d6d14e76fa607d2
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/063143d5b1fde0fdcbae30bc7d6d14e76fa607d2
2016-05-29 09:11:12+02:00
block: Add bdrv_has_blk() In many cases we just want to know whether a BDS has at least one BB attached, without needing to know the exact BB that is attached. In contrast to bs->blk, this is still a valid question when more than one BB can be attached, so just answer it by checking the parents list. Signed-off-by: Kevin Wolf <[email protected]> Reviewed-by: Max Reitz <[email protected]>
dde33812a83b9c55b180a85411bfc4d6c39e8b11
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/dde33812a83b9c55b180a85411bfc4d6c39e8b11
2016-05-19 16:45:31+02:00
s390x: enable runtime instrumentation Introduce run-time-instrumentation support when running under kvm for virtio-ccw 2.7 machine and make sure older machines can not enable it. The new ri_allowed field in the s390MachineClass serves as an indicator whether the feature can be used by the machine and should therefore be activated if available. riccb_needed() is used to check whether riccb is needed or not in live migration. Signed-off-by: Fan Zhang <[email protected]> Signed-off-by: Cornelia Huck <[email protected]>
9700230b0d6d68d8650206ffd10d132219678db1
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/9700230b0d6d68d8650206ffd10d132219678db1
2016-05-17 15:50:29+02:00
tcg/ppc: Make direct jump patching thread-safe Ensure direct jump patching in PPC is atomic by: * limiting translation buffer size in 32-bit mode to be addressable by Branch I-form instruction; * using atomic_read()/atomic_set() for code patching. Signed-off-by: Sergey Fedorov <[email protected]> Signed-off-by: Sergey Fedorov <[email protected]> Reviewed-by: Alex Bennée <[email protected]> Message-Id: <[email protected]> Signed-off-by: Richard Henderson <[email protected]>
399f1648573d49b9411089e4e2ea62b6357b166e
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/399f1648573d49b9411089e4e2ea62b6357b166e
2016-05-12 14:06:40-10:00
block: Support AIO drivers in bdrv_driver_preadv/pwritev() Instead of registering emulation functions as .bdrv_co_writev, just directly check whether the function is there or not, and use the AIO interface if it isn't. This makes the read/write functions more consistent with how things are done in other places (flush, discard, etc.) Signed-off-by: Kevin Wolf <[email protected]> Reviewed-by: Eric Blake <[email protected]> Reviewed-by: Fam Zheng <[email protected]>
08844473820c93541fc47bdfeae0f2cc88cfab59
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/08844473820c93541fc47bdfeae0f2cc88cfab59
2016-05-12 15:22:07+02:00
spapr: fix possible Negative array index read fix CID 1351391. Signed-off-by: Gonglei <[email protected]> Message-Id: <[email protected]> Signed-off-by: Paolo Bonzini <[email protected]>
1a5512bb7ef73036a406727397fb58c640074321
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/1a5512bb7ef73036a406727397fb58c640074321
2016-04-08 00:07:56+02:00
block: initialize qcrypto API at startup Any programs which call the qcrypto APIs should ensure that qcrypto_init() has been called before anything else which can use crypto. Essentially this means right at the start of the main method before initializing anything else. This is important because some versions of gnutls/gcrypt require explicit initialization before use. Signed-off-by: Daniel P. Berrange <[email protected]> Reviewed-by: Alex Bligh <[email protected]> Tested-by: Alex Bligh <[email protected]> Signed-off-by: Kevin Wolf <[email protected]>
c229708848cc77b0277e7260f7e739d441c1d086
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/c229708848cc77b0277e7260f7e739d441c1d086
2016-04-12 18:06:51+02:00
cpus: don't use atomic_read for vm_clock_warp_start As vm_clock_warp_start is a 64 bit value this causes problems for the compiler trying to come up with a suitable atomic operation on 32 bit hosts. Because the variable is protected by vm_clock_seqlock, we check its value inside a seqlock critical section. Signed-off-by: Alex Bennée <[email protected]> Message-Id: <[email protected]> Signed-off-by: Paolo Bonzini <[email protected]>
ccffff48c93c30733783b05cd1ef843a4c274653
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/ccffff48c93c30733783b05cd1ef843a4c274653
2016-04-05 11:46:52+02:00
.travis.yml: enable OSX builds Travis has support for OSX builds. Making the setup work cleanly involves a little hacking about with the .travis.yml file but rather than make it too messy I've pushed all the "brew" install stuff into a support script called ./scripts/macosx-brew.sh. Currently only the default ./configure ${CONFIG} is built as I'm not sure what extra coverage would come from the other build stanzas. Signed-off-by: Alex Bennée <[email protected]> Acked-by: Peter Maydell <[email protected]>
1d002037f93898c9b507cd010bbb9075870ecc5d
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/1d002037f93898c9b507cd010bbb9075870ecc5d
2016-04-05 10:08:11+01:00
ivshmem-test: Improve test case /ivshmem/single Test state of registers after reset. Test reading Interrupt Status clears it. Test (invalid) read of Doorbell. Add more comments. Signed-off-by: Markus Armbruster <[email protected]> Reviewed-by: Marc-André Lureau <[email protected]> Message-Id: <[email protected]>
4958fe5d3c77a40a5250bc820b582a29d73605ab
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/4958fe5d3c77a40a5250bc820b582a29d73605ab
2016-03-21 21:28:59+01:00
fw_cfg: Split fw_cfg_keys.h off fw_cfg.h Much of fw_cfg.h's contents is #ifndef NO_QEMU_PROTOS. This lets a few places include it without satisfying the dependencies of the suppressed code. If you somehow include it with NO_QEMU_PROTOS, any future includes are ignored. Unnecessarily unclean. Move the stuff not under NO_QEMU_PROTOS into its own header fw_cfg_keys.h, and include it as appropriate. Tidy up the moved code to please checkpatch. Signed-off-by: Markus Armbruster <[email protected]> Signed-off-by: Paolo Bonzini <[email protected]>
6f061ea10f28c6cbe3ea588e84ef1f5fd27f0299
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/6f061ea10f28c6cbe3ea588e84ef1f5fd27f0299
2016-03-22 22:20:16+01:00
pc: acpi: SRAT: create only valid processor lapic entries When APIC IDs are sparse*, in addition to valid LAPIC entries the SRAT is also filled invalid ones for non possible APIC IDs. Fix it by asking machine for all possible APIC IDs instead of wrongly assuming that all APIC IDs in range 0..apic_id_limit are possible. * sparse lapic topology CLI: -smp x,sockets=2,cores=3,maxcpus=6 Signed-off-by: Igor Mammedov <[email protected]> Reviewed-by: Eduardo Habkost <[email protected]> Reviewed-by: Michael S. Tsirkin <[email protected]> Signed-off-by: Michael S. Tsirkin <[email protected]>
5803fce3891094618ba018ca1b7ba09ce5de9437
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/5803fce3891094618ba018ca1b7ba09ce5de9437
2016-03-11 16:59:12+02:00
qapi: Drop useless 'data' member of unions We started moving away from the use of the 'void *data' member in the C union corresponding to a QAPI union back in commit 544a373; recent commits have gotten rid of other uses. Now that it is completely unused, we can remove the member itself as well as the FIXME comment. Update the testsuite to drop the negative test union-clash-data. Signed-off-by: Eric Blake <[email protected]> Reviewed-by: Daniel P. Berrange <[email protected]> Message-Id: <[email protected]> Signed-off-by: Markus Armbruster <[email protected]>
48eb62a74fc2d6b0ae9e5f414304a85cfbf33066
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/48eb62a74fc2d6b0ae9e5f414304a85cfbf33066
2016-03-05 10:42:06+01:00
target-arm: Make reserved ranges in ID_AA64* spaces RAZ, not UNDEF The v8 ARM ARM defines that unused spaces in the ID_AA64* system register ranges are Reserved and must RAZ, rather than being UNDEF. Implement this. In particular, ARM v8.2 adds a new feature register ID_AA64MMFR2, and newer versions of the Linux kernel will attempt to read this, which causes them not to boot up on versions of QEMU missing this fix. Since the encoding .opc0 = 3, .opc1 = 0, .crn = 0, .crm = 2, .opc2 = 6 is actually defined in ARMv8 (as ID_MMFR4), we give it an entry in the ARMCPU struct so CPUs can override it, though since none do this too will just RAZ. Cc: [email protected] Reported-by: Ard Biesheuvel <[email protected]> Signed-off-by: Peter Maydell <[email protected]> Message-id: [email protected] Reviewed-by: Alex Bennée <[email protected]> Tested-by: Alex Bennée <[email protected]>
e20d84c1407d43d5a2e2ac95dbb46db3b0af8f9f
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/e20d84c1407d43d5a2e2ac95dbb46db3b0af8f9f
2016-02-26 15:09:42+00:00
qapi: Allow anonymous base for flat union Rather than requiring all flat unions to explicitly create a separate base struct, we can allow the qapi schema to specify the common members via an inline dictionary. This is similar to how commands can specify an inline anonymous type for its 'data'. We already have several struct types that only exist to serve as a single flat union's base; the next commit will clean them up. In particular, this patch's change to the BlockdevOptions example in qapi-code-gen.txt will actually be done in the real QAPI schema. Now that anonymous bases are legal, we need to rework the flat-union-bad-base negative test (as previously written, it forms what is now valid QAPI; tweak it to now provide coverage of a new error message path), and add a positive test in qapi-schema-test to use an anonymous base (making the integer argument optional, for even more coverage). Note that this patch only allows anonymous bases for flat unions; simple unions are already enough syntactic sugar that we do not want to burden them further. Meanwhile, while it would be easy to also allow an anonymous base for structs, that would be quite redundant, as the members can be put right into the struct instead. Signed-off-by: Eric Blake <[email protected]> Message-Id: <[email protected]> Signed-off-by: Markus Armbruster <[email protected]>
ac4338f8eb783fd421aae492ca262a586918471e
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/ac4338f8eb783fd421aae492ca262a586918471e
2016-03-18 10:29:26+01:00
rbd: add support for getting password from QCryptoSecret object Currently RBD passwords must be provided on the command line via $QEMU -drive file=rbd:pool/image:id=myname:\ key=QVFDVm41aE82SHpGQWhBQXEwTkN2OGp0SmNJY0UrSE9CbE1RMUE=:\ auth_supported=cephx This is insecure because the key is visible in the OS process listing. This adds support for an 'password-secret' parameter in the RBD parameters that can be used with the QCryptoSecret object to provide the password via a file: echo "QVFDVm41aE82SHpGQWhBQXEwTkN2OGp0SmNJY0UrSE9CbE1RMUE=" > poolkey.b64 $QEMU -object secret,id=secret0,file=poolkey.b64,format=base64 \ -drive driver=rbd,filename=rbd:pool/image:id=myname:\ auth_supported=cephx,password-secret=secret0 Reviewed-by: Josh Durgin <[email protected]> Signed-off-by: Daniel P. Berrange <[email protected]> Message-id: [email protected] Signed-off-by: Jeff Cody <[email protected]>
60390a2192e7b38aee18db6ce7fb740498709737
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/60390a2192e7b38aee18db6ce7fb740498709737
2016-02-29 14:54:30-05:00
hw/ppc/spapr: Implement the h_page_init hypercall This hypercall either initializes a page with zeros, or copies another page. According to LoPAPR, the i-cache of the page should also be flushed if using H_ICACHE_INVALIDATE or H_ICACHE_SYNCHRONIZE, and the d-cache should be synchronized to the RAM if the H_ICACHE_SYNCHRONIZE flag is used. For this, two new functions are introduced, kvmppc_dcbst_range() and kvmppc_icbi()_range, which use the corresponding assembler instructions to flush the caches if running with KVM on Power. If the code runs with TCG instead, the code only uses tb_flush(), assuming that this will be enough for synchronization. Signed-off-by: Thomas Huth <[email protected]> Signed-off-by: David Gibson <[email protected]>
3240dd9a6924df18dfccb83defa0914065da076e
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/3240dd9a6924df18dfccb83defa0914065da076e
2016-02-25 13:58:44+11:00
target-arm: Clean up trap/undef handling of SRS The SRS instruction is: * UNDEFINED in Hyp mode * UNPREDICTABLE in User or System mode * UNPREDICTABLE if the specified mode isn't accessible * trapped to EL3 if EL3 is AArch64 and we are at Secure EL1 Clean up the code to handle all these cases cleanly, including picking UNDEF as our choice of UNPREDICTABLE behaviour rather blindly trusting the mode field passed in the instruction. As part of this, move the check for IS_USER into gen_srs() itself rather than having it done by the caller. The exception is that we don't UNDEF for calls from System mode, which need a runtime check. This will be dealt with in the following commits. Signed-off-by: Peter Maydell <[email protected]> Reviewed-by: Sergey Fedorov <[email protected]> Reviewed-by: Edgar E. Iglesias <[email protected]>
cbc0326b6fb905f80b7cef85b24571f7ebb62077
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/cbc0326b6fb905f80b7cef85b24571f7ebb62077
2016-02-18 14:16:16+00:00
qapi: Forbid empty unions and useless alternates Empty unions serve no purpose, and while we compile with gcc which permits them, strict C99 forbids them. We happen to inject a dummy 'void *data' member into the C unions that represent QAPI unions and alternates, but we want to get rid of that member (it pollutes the namespace for no good reason), which would leave us with an empty union if the user didn't provide any branches. While empty structs make sense in QAPI, empty unions don't add any expressiveness to the QMP language. So prohibit them at parse time. Update the documentation and testsuite to match. Note that the documentation already mentioned that alternates should have "two or more JSON data types"; so this also fixes the code to enforce that. However, we have existing uses of a union type with only one branch, so the 2-or-more strictness is intentionally limited to alternates. Signed-off-by: Eric Blake <[email protected]> Message-Id: <[email protected]> Signed-off-by: Markus Armbruster <[email protected]>
02a57ae32b08e8981b59979b80e682c9a153e94d
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/02a57ae32b08e8981b59979b80e682c9a153e94d
2016-02-19 11:08:56+01:00
pseries: Add helper to calculate recommended hash page table size At present we calculate the recommended hash page table (HPT) size for a pseries guest just once in ppc_spapr_init() before allocating the HPT. In future patches we're going to want this calculation in other places, so this splits it out into a helper function. While we're at it, change the calculation to use ctz() instead of an explicit loop. Signed-off-by: David Gibson <[email protected]> Reviewed-by: Alexey Kardashevskiy <[email protected]>
8dfe8e7f4facef400ef1c220f29196ae5cfc526c
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/8dfe8e7f4facef400ef1c220f29196ae5cfc526c
2016-02-17 09:59:30+11:00
target-arm: Properly support EL2 and EL3 in arm_el_is_aa64() Support EL2 and EL3 in arm_el_is_aa64() by implementing the logic for checking the SCR_EL3 and HCR_EL2 register-width bits as appropriate to determine the register width of lower exception levels. Signed-off-by: Peter Maydell <[email protected]> Reviewed-by: Edgar E. Iglesias <[email protected]>
446c81abf8e0572b8d5d23fe056516ac62af278d
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/446c81abf8e0572b8d5d23fe056516ac62af278d
2016-01-21 14:15:08+00:00
bcm2835_property: implement "get board revision" query Return a valid value from the BCM2835 property mailbox query "get board revision". This query is used by U-Boot. Implementing it fixes the first obvious difference between qemu and real HW. The value returned is currently hard-coded to match the RPi2 I own. Other values are legal, e.g. different board manufacturer field values are likely to exist in the wild. Cc: Andrew Baumann <[email protected]> Signed-off-by: Stephen Warren <[email protected]> Reviewed-by: Andrew Baumann <[email protected]> Message-id: [email protected] Signed-off-by: Peter Maydell <[email protected]>
f0afa73164778570083504a185d7498884c68d65
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/f0afa73164778570083504a185d7498884c68d65
2016-02-11 11:17:32+00:00
xen_console: correctly cleanup primary console on teardown. All of the work in con_disconnect applies to the primary console case (when xendev->dev is NULL). Therefore remove the early check and bail and allow it to fall through. All of the existing code is correctly conditional already. The ->dev and ->gnttabdev handles are either both set or neither. For consistency with con_initialise() with to the former here too. With this con_initialise and con_disconnect now mirror each other. Fix up a hard tab in the function while editing. Signed-off-by: Ian Campbell <[email protected]> Reviewed-by: Stefano Stabellini <[email protected]> Signed-off-by: Stefano Stabellini <[email protected]>
549e9bcabc2f5b37b0be8c24257e0b527bffb49a
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/549e9bcabc2f5b37b0be8c24257e0b527bffb49a
2016-01-26 17:19:16+00:00
xenfb.c: avoid expensive loops when prod <= out_cons If the frontend sets out_cons to a value higher than out_prod, it will cause xenfb_handle_events to loop about 2^32 times. Avoid that by using better checks at the beginning of the function. Signed-off-by: Stefano Stabellini <[email protected]> Reported-by: Ling Liu <[email protected]>
ac0487e1d2ae811cd4d035741a109a4ecfb013f1
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/ac0487e1d2ae811cd4d035741a109a4ecfb013f1
2016-01-14 16:49:11+00:00
xen: Switch to libxenevtchn interface for compat shims. In Xen 4.7 we are refactoring parts libxenctrl into a number of separate libraries which will provide backward and forward API and ABI compatiblity. One such library will be libxenevtchn which provides access to event channels. In preparation for this switch the compatibility layer in xen_common.h (which support building with older versions of Xen) to use what will be the new library API. This means that the evtchn shim will disappear for versions of Xen which include libxenevtchn. To simplify things for the <= 4.0.0 support we wrap the int fd in a malloc(sizeof int) such that the handle is always a pointer. This leads to less typedef headaches and the need for XC_HANDLER_INITIAL_VALUE etc for these interfaces. Note that this patch does not add any support for actually using libxenevtchn, it just adjusts the existing shims. Note that xc_evtchn_alloc_unbound functionality remains in libxenctrl, since that functionality is not exposed by /dev/xen/evtchn. Signed-off-by: Ian Campbell <[email protected]> Reviewed-by: Stefano Stabellini <[email protected]> Signed-off-by: Stefano Stabellini <[email protected]>
a2db2a1edd06a50b8a862c654cf993368cf9f1d9
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/a2db2a1edd06a50b8a862c654cf993368cf9f1d9
2016-01-26 17:19:24+00:00
configure: Diagnose broken linkers directly Currently if the user's compiler works for creating .o files but their linker is broken such that compiling an executable from a C file does not work, we will report a misleading error message about the compiler not supporting __thread (since that happens to be the first test we run which requires a working linker). Explicitly check that compile_prog works as well as compile_object, so that people whose toolchain setup is broken get a more helpful error message. Signed-off-by: Peter Maydell <[email protected]> Signed-off-by: Michael Tokarev <[email protected]>
0ef74c7496fd3c526b2259f86326eca4b3a03b78
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/0ef74c7496fd3c526b2259f86326eca4b3a03b78
2015-12-04 09:39:55+03:00
s390x: no deprecation warning while testing 'make check' tries to start all available machines; the deprecation message for the s390-virtio machine is both useless and annoying there. Silence it while testing. Reported-by: Michael S. Tsirkin <[email protected]> Signed-off-by: Cornelia Huck <[email protected]> Acked-by: Christian Borntraeger <[email protected]> Acked-by: Michael S. Tsirkin <[email protected]>
567c88c354904d669dfac6170b8ac5f60b41d9bd
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/567c88c354904d669dfac6170b8ac5f60b41d9bd
2015-12-01 09:57:27+01:00
block: Track discard requests Both bdrv_discard and bdrv_aio_discard will call into bdrv_co_discard, so add tracked_request_begin/end calls around the loop. Signed-off-by: Fam Zheng <[email protected]> Reviewed-by: Kevin Wolf <[email protected]> Message-id: [email protected] Signed-off-by: Stefan Hajnoczi <[email protected]> Signed-off-by: Kevin Wolf <[email protected]>
b1066c875597649be1d1d6db4712bc504b4c4c81
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/b1066c875597649be1d1d6db4712bc504b4c4c81
2015-11-12 16:22:42+01:00
qemu-char: add logfile facility to all chardev backends Typically a UNIX guest OS will log boot messages to a serial port in addition to any graphical console. An admin user may also wish to use the serial port for an interactive console. A virtualization management system may wish to collect system boot messages by logging the serial port, but also wish to allow admins interactive access. Currently providing such a feature forces the mgmt app to either provide 2 separate serial ports, one for logging boot messages and one for interactive console login, or to proxy all output via a separate service that can multiplex the two needs onto one serial port. While both are valid approaches, they each have their own downsides. The former causes confusion and extra setup work for VM admins creating disk images. The latter places an extra burden to re-implement much of the QEMU chardev backends logic in libvirt or even higher level mgmt apps and adds extra hops in the data transfer path. A simpler approach that is satisfactory for many use cases is to allow the QEMU chardev backends to have a "logfile" property associated with them. $QEMU -chardev socket,host=localhost,port=9000,\ server=on,nowait,id-charserial0,\ logfile=/var/log/libvirt/qemu/test-serial0.log -device isa-serial,chardev=charserial0,id=serial0 This patch introduces a 'ChardevCommon' struct which is setup as a base for all the ChardevBackend types. Ideally this would be registered directly as a base against ChardevBackend, rather than each type, but the QAPI generator doesn't allow that since the ChardevBackend is a non-discriminated union. The ChardevCommon struct provides the optional 'logfile' parameter, as well as 'logappend' which controls whether QEMU truncates or appends (default truncate). Signed-off-by: Daniel P. Berrange <[email protected]> Message-Id: <[email protected]> [Call qemu_chr_parse_common if cd->parse is NULL. - Paolo] Signed-off-by: Paolo Bonzini <[email protected]>
d0d7708ba29cbcc343364a46bff981e0ff88366f
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/d0d7708ba29cbcc343364a46bff981e0ff88366f
2016-01-15 18:58:02+01:00
qemu-io: Check for trailing chars Make sure there's not trailing garbage, e.g. "64k-whatever-i-want-here" Reported-by: Max Reitz <[email protected]> Signed-off-by: John Snow <[email protected]> Reviewed-by: Eric Blake <[email protected]> Reviewed-by: Kevin Wolf <[email protected]> Signed-off-by: Kevin Wolf <[email protected]>
ef5a788527b2038d742b057a415ab4d0e735e98f
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/ef5a788527b2038d742b057a415ab4d0e735e98f
2015-11-11 16:40:10+01:00
Revert "exec: silence hugetlbfs warning under qtest" This reverts commit 1c7ba94a184df1eddd589d5400d879568d3e5d08. That commit changed QEMU initialization order from - object-initial, chardev, qtest, object-late to - chardev, qtest, object-initial, object-late This breaks chardev setups which need to rely on objects having been created. For example, when chardevs use TLS encryption in the future, they need to have tls credential objects created first. This revert, restores the ordering introduced in commit f08f9271bfe3f19a5eb3d7a2f48532065304d5c8 Author: Daniel P. Berrange <[email protected]> Date: Wed May 13 17:14:04 2015 +0100 vl: Create (most) objects before creating chardev backends Signed-off-by: Daniel P. Berrange <[email protected]> Message-Id: <[email protected]> Signed-off-by: Paolo Bonzini <[email protected]>
2c189a4e12a37b1c7cae2a2643c378c5af8f67fc
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/2c189a4e12a37b1c7cae2a2643c378c5af8f67fc
2015-11-26 16:47:44+01:00
migration_is_setup_or_active Add 'migration_is_setup_or_active' utility function to check state. (It gets postcopy added to it's list later on in the series) Signed-off-by: Dr. David Alan Gilbert <[email protected]> Reviewed-by: Juan Quintela <[email protected]> Signed-off-by: Juan Quintela <[email protected]>
f6844b99ce08e836d509ec4be2fbfc5ab13ac18f
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/f6844b99ce08e836d509ec4be2fbfc5ab13ac18f
2015-11-10 15:00:26+01:00
target-i386: tcg: Check right CPUID bits for clflushopt/pcommit Detect the clflushopt and pcommit instructions and check their corresponding feature flags, instead of checking CPUID_SSE and CPUID_CLFLUSH. Reviewed-by: Richard Henderson <[email protected]> Signed-off-by: Eduardo Habkost <[email protected]>
891bc821a3ee462b09b1ec436f2891f00ab1f85b
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/891bc821a3ee462b09b1ec436f2891f00ab1f85b
2015-11-06 12:03:12-02:00
fw_cfg: amend callback behavior spec to once per select Currently, the fw_cfg internal API specifies that if an item was set up with a read callback, the callback must be run each time a byte is read from the item. This behavior is both wasteful (most items do not have a read callback set), and impractical for bulk transfers (e.g., DMA read). At the time of this writing, the only items configured with a callback are "/etc/table-loader", "/etc/acpi/tables", and "/etc/acpi/rsdp". They all share the same callback functions: virt_acpi_build_update() on ARM (in hw/arm/virt-acpi-build.c), and acpi_build_update() on i386 (in hw/i386/acpi.c). Both of these callbacks are one-shot (i.e. they return without doing anything at all after the first time they are invoked with a given build_state; since build_state is also shared across all three items mentioned above, the callback only ever runs *once*, the first time either of the listed items is read). This patch amends the specification for fw_cfg_add_file_callback() to state that any available read callback will only be invoked once each time the item is selected. This change has no practical effect on the current behavior of QEMU, and it enables us to significantly optimize the behavior of fw_cfg reads during guest firmware setup, eliminating a large amount of redundant callback checks and invocations. Cc: Laszlo Ersek <[email protected]> Cc: Gerd Hoffmann <[email protected]> Cc: Marc Marí <[email protected]> Signed-off-by: Gabriel Somlo <[email protected]> Reviewed-by: Laszlo Ersek <[email protected]> Message-id: [email protected] Signed-off-by: Gerd Hoffmann <[email protected]>
3bef7e8aab8af2f86c5785761c37e068428c689d
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/3bef7e8aab8af2f86c5785761c37e068428c689d
2015-12-15 11:45:59+01:00
block: add a 'blockdev-snapshot' QMP command One of the limitations of the 'blockdev-snapshot-sync' command is that it does not allow passing BlockdevOptions to the newly created snapshots, so they are always opened using the default values. Extending the command to allow passing options is not a practical solution because there is overlap between those options and some of the existing parameters of the command. This patch introduces a new 'blockdev-snapshot' command with a simpler interface: it just takes two references to existing block devices that will be used as the source and target for the snapshot. Since the main difference between the two commands is that one of them creates and opens the target image, while the other uses an already opened one, the bulk of the implementation is shared. Signed-off-by: Alberto Garcia <[email protected]> Reviewed-by: Max Reitz <[email protected]> Signed-off-by: Kevin Wolf <[email protected]>
43de7e2de07093e47c7f25386aff280875dc3c62
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/43de7e2de07093e47c7f25386aff280875dc3c62
2015-11-11 16:25:47+01:00
replay: introduce icount event This patch adds icount event to the replay subsystem. This event corresponds to execution of several instructions and used to synchronize input events in the replay phase. Reviewed-by: Paolo Bonzini <[email protected]> Signed-off-by: Pavel Dovgalyuk <[email protected]> Message-Id: <[email protected]> Signed-off-by: Paolo Bonzini <[email protected]>
26bc60ac82f88d14e65be5387eb4a136edf94f1b
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/26bc60ac82f88d14e65be5387eb4a136edf94f1b
2015-11-05 12:19:09+01:00
replay: global variables and function stubs This patch adds global variables, defines, function declarations, and function stubs for deterministic VM replay used by external modules. Reviewed-by: Paolo Bonzini <[email protected]> Reviewed-by: Eric Blake <[email protected]> Signed-off-by: Pavel Dovgalyuk <[email protected]> Message-Id: <[email protected]> Signed-off-by: Paolo Bonzini <[email protected]>
d73abd6dcc105fb5cacc34716046fca63132a264
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/d73abd6dcc105fb5cacc34716046fca63132a264
2015-11-05 12:19:08+01:00
icount: improve counting for record/replay icount_warp_rt function is called by qemu_clock_warp and as callback of icount_warp timer. This patch adds call to qemu_clock_warp into main_loop_wait function, because icount warp may be missed in record/replay mode, when CPU is sleeping. This patch also disables of calling this function by timer, because it is not needed after making modifications of main_loop_wait. Signed-off-by: Pavel Dovgalyuk <[email protected]> Message-Id: <[email protected]> Signed-off-by: Paolo Bonzini <[email protected]> Signed-off-by: Pavel Dovgalyuk <[email protected]>
efab87cf79077a9624f675fc5fc8f034eaedfe4d
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/efab87cf79077a9624f675fc5fc8f034eaedfe4d
2015-11-06 10:16:02+01:00
tpm: Convert to new qapi union layout We have two issues with our qapi union layout: 1) Even though the QMP wire format spells the tag 'type', the C code spells it 'kind', requiring some hacks in the generator. 2) The C struct uses an anonymous union, which places all tag values in the same namespace as all non-variant members. This leads to spurious collisions if a tag value matches a non-variant member's name. Make the conversion to the new layout for TPM-related code. Signed-off-by: Eric Blake <[email protected]> Message-Id: <[email protected]> [Commit message tweaked slightly] Signed-off-by: Markus Armbruster <[email protected]>
ce21131a0b9e556bb73bf65eacdc07ccb21f78a9
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/ce21131a0b9e556bb73bf65eacdc07ccb21f78a9
2015-11-02 08:30:28+01:00
target-i386: Set "check=off" by default on pc-*-2.4 and older The default CPU model (qemu64) have some issues today: it enables some features (ABM and SSE4a) that are not present in many host CPUs. That means many hosts (but not all of them) had those features silently disabled in the default configuration in QEMU 2.4 and older. With the new "check=on" default, this causes warnings to be printed in the default configuration, because of the lack of SSE4A on all Intel hosts, and the lack of ABM on Sandy Bridge and older hosts: $ qemu-system-x86_64 -machine pc,accel=kvm warning: host doesn't support requested feature: CPUID.80000001H:ECX.abm [bit 5] warning: host doesn't support requested feature: CPUID.80000001H:ECX.sse4a [bit 6] Those issues will be fixed in pc-*-2.5 and newer. But as we can't change the guest ABI in pc-*-2.4, disable "check" mode by default in pc-*-2.4 and older so we don't print spurious warnings. Reviewed-by: Paolo Bonzini <[email protected]> Signed-off-by: Eduardo Habkost <[email protected]>
3e68482224129c3ddc061af7c9d438b882ecfdd1
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/3e68482224129c3ddc061af7c9d438b882ecfdd1
2015-11-05 16:27:59-02:00
ivshmem: use common is_power_of_2() The common version correctly checks for 0 value case. Signed-off-by: Marc-André Lureau <[email protected]> Reviewed-by: Claudio Fontana <[email protected]>
e309366337d636689730f6484e388e46db7b5654
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/e309366337d636689730f6484e388e46db7b5654
2015-10-24 18:02:49+02:00
vhost-user-test: check ownership during migration Check that backend source and destination do not have simultaneous ownership during migration. Signed-off-by: Marc-André Lureau <[email protected]> Reviewed-by: Michael S. Tsirkin <[email protected]> Signed-off-by: Michael S. Tsirkin <[email protected]> Tested-by: Thibaut Collet <[email protected]>
1d9edff78fa0b294d6084df76da89e20ee93fdab
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/1d9edff78fa0b294d6084df76da89e20ee93fdab
2015-10-22 14:34:50+03:00
net: Remove duplicate data from query-rx-filter on multiqueue net devices When responding to a query-rx-filter command on a multiqueue netdev, qemu reports the data for each queue. The data, however, is not per-queue, but per device and the same data is reported multiple times. This causes confusion and may also cause extra unnecessary processing when looking at the data. Commit 638fb14169 (net: Make qmp_query_rx_filter() with name argument more obvious) partially addresses this issue, by limiting the output when the name is specified. However, when the name is not specified, the issue still persists. Signed-off-by: Vladislav Yasevich <[email protected]> Signed-off-by: Jason Wang <[email protected]>
5320c2caf43cc76748a1ffa0fdcaa9eb501d3fcd
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/5320c2caf43cc76748a1ffa0fdcaa9eb501d3fcd
2015-10-27 10:30:39+08:00
vl.c: init delayed object after net_init_clients Init delayed object after net_init_clients, because netfilters need to be initialized after net clients initialized. Signed-off-by: Yang Hongyang <[email protected]> Signed-off-by: Jason Wang <[email protected]>
9abce56d7b319b0c78b487720d128706272e0a0c
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/9abce56d7b319b0c78b487720d128706272e0a0c
2015-10-12 13:19:36+08:00
checkpatch: port fix from kernel "## is not a valid modifier" checkpatch currently loops on fpu/softfloat.c Turns out this is fixed in the Linux version of checkpatch. So this is a port of Andy Whitcrofts fix from Linux, Original commit was commit 89a883530fe7 ("checkpatch: ## is not a valid modifier") As suggested by Peter Maydell for the QEMU version we drop the last "|" as there seems to be no need for that. (FWIW, the kernel discusion about that dried out: http://www.spinics.net/lists/kernel/msg1944421.html ) Cc: Andy Whitcroft <[email protected]> Signed-off-by: Christian Borntraeger <[email protected]> Message-Id: <[email protected]> Signed-off-by: Paolo Bonzini <[email protected]>
3e5385fcf536fc4238eb87de55af8dd99089cad4
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/3e5385fcf536fc4238eb87de55af8dd99089cad4
2015-10-12 18:29:26+02:00
s390x/gdb: expose virtualization specific registers Let's expose some virtual/fake registers as virtualization specific registers. Signed-off-by: David Hildenbrand <[email protected]> Signed-off-by: Jens Freimann <[email protected]> Message-Id: <[email protected]> Signed-off-by: Christian Borntraeger <[email protected]>
8a641ff60f38799a10ed44a7c5bddd386bc169ed
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/8a641ff60f38799a10ed44a7c5bddd386bc169ed
2015-10-02 13:31:52+02:00
qapi: Prefer typesafe upcasts to qapi base classes A previous patch (commit 1e6c1616) made it possible to directly cast from a qapi flat union type to its base type. However, it requires the use of a C cast, which turns off compiler type-safety checks. Fortunately, no such casts exist, just yet. Regardless, add inline type-safe wrappers named qapi_FOO_base() for any union type FOO that has a base, which can be used for a safer upcast, and enhance the testsuite to cover the new functionality. A future patch will extend the upcast support to structs, where such conversions do exist already. Note that C makes const-correct upcasts annoying because it lacks overloads; these functions cast away const so that they can accept user pointers whether const or not, and the result in turn can be assigned to normal or const pointers. Alternatively, this could have been done with macros, but type-safe macros are hairy, and not worthwhile here. This patch just adds upcasts. None of our code needed to downcast from a base qapi class to a child. Also, in the case of grandchildren (such as BlockdevOptionsQcow2), the caller will need to call two functions to get to the inner base (although it wouldn't be too hard to generate a qapi_FOO_base_base() if desired). If a user changes qapi to alter the base class hierarchy, such as going from 'A -> C' to 'A -> B -> C', it will change the type of 'qapi_C_base()', and the compiler will point out the places that are affected by the new base. One alternative was proposed, but was deemed too ugly to use in practice: the generators could output redundant information using anonymous types: | struct Child { | union { | struct { | Type1 parent_member1; | Type2 parent_member2; | }; | Parent base; | }; | }; With that ugly proposal, for a given qapi type, obj->member and obj->base.member would refer to the same storage; allowing convenience in working with members without needing 'base.' allowing typesafe upcast without needing a C cast by accessing '&obj->base', and allowing downcasts from the parent back to the child possible through container_of(obj, Child, base). Signed-off-by: Eric Blake <[email protected]> Message-Id: <[email protected]> [Commit message tweaked] Signed-off-by: Markus Armbruster <[email protected]>
30594fe1cd4355626e73b80645428105d0df3cf6
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/30594fe1cd4355626e73b80645428105d0df3cf6
2015-11-02 08:30:26+01:00
target-i386: get/put MSR_TSC_AUX across reset and migration There's one report of migration breaking due to missing MSR_TSC_AUX save/restore. Fix this by adding a new subsection that saves the state of this MSR. https://bugzilla.redhat.com/show_bug.cgi?id=1261797 Reported-by: Xiaoqing Wei <[email protected]> Signed-off-by: Amit Shah <[email protected]> CC: Paolo Bonzini <[email protected]> CC: Juan Quintela <[email protected]> CC: "Dr. David Alan Gilbert" <[email protected]> CC: Marcelo Tosatti <[email protected]> CC: Richard Henderson <[email protected]> CC: Eduardo Habkost <[email protected]> Reviewed-by: Eduardo Habkost <[email protected]> Signed-off-by: Eduardo Habkost <[email protected]>
c9b8f6b6210847b4381c5b2ee172b1c7eb9985d6
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/c9b8f6b6210847b4381c5b2ee172b1c7eb9985d6
2015-10-02 16:22:01-03:00
spapr: Initialize hotplug memory address space Initialize a hotplug memory region under which all the hotplugged memory is accommodated. Also enable memory hotplug by setting CONFIG_MEM_HOTPLUG. Modelled on i386 memory hotplug. Signed-off-by: Bharata B Rao <[email protected]> Reviewed-by: David Gibson <[email protected]> Signed-off-by: David Gibson <[email protected]>
4a1c9cf0073e733b421e7b82ad673e7cf6ed8454
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/4a1c9cf0073e733b421e7b82ad673e7cf6ed8454
2015-09-23 10:51:10+10:00
maint: avoid useless "if (foo) free(foo)" pattern The free() and g_free() functions both happily accept NULL on any platform QEMU builds on. As such putting a conditional 'if (foo)' check before calls to 'free(foo)' merely serves to bloat the lines of code. Signed-off-by: Daniel P. Berrange <[email protected]> Reviewed-by: Markus Armbruster <[email protected]> Reviewed-by: Eric Blake <[email protected]> Signed-off-by: Michael Tokarev <[email protected]>
ef1e1e0782e99c9dcf2b35e5310cdd8ca9211374
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/ef1e1e0782e99c9dcf2b35e5310cdd8ca9211374
2015-09-11 10:21:38+03:00
checkpatch: remove tests that are not relevant outside the kernel Fully removing Sparse support requires more invasive changes. Only remove the really kernel-specific parts such as address space names. Signed-off-by: Paolo Bonzini <[email protected]>
f1e155bbf863ade457019c6f09d4cba06b2d6bb4
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/f1e155bbf863ade457019c6f09d4cba06b2d6bb4
2015-09-09 15:34:55+02:00
vfio: Check guest IOVA ranges against host IOMMU capabilities The current vfio core code assumes that the host IOMMU is capable of mapping any IOVA the guest wants to use to where we need. However, real IOMMUs generally only support translating a certain range of IOVAs (the "DMA window") not a full 64-bit address space. The common x86 IOMMUs support a wide enough range that guests are very unlikely to go beyond it in practice, however the IOMMU used on IBM Power machines - in the default configuration - supports only a much more limited IOVA range, usually 0..2GiB. If the guest attempts to set up an IOVA range that the host IOMMU can't map, qemu won't report an error until it actually attempts to map a bad IOVA. If guest RAM is being mapped directly into the IOMMU (i.e. no guest visible IOMMU) then this will show up very quickly. If there is a guest visible IOMMU, however, the problem might not show up until much later when the guest actually attempt to DMA with an IOVA the host can't handle. This patch adds a test so that we will detect earlier if the guest is attempting to use IOVA ranges that the host IOMMU won't be able to deal with. For now, we assume that "Type1" (x86) IOMMUs can support any IOVA, this is incorrect, but no worse than what we have already. We can't do better for now because the Type1 kernel interface doesn't tell us what IOVA range the IOMMU actually supports. For the Power "sPAPR TCE" IOMMU, however, we can retrieve the supported IOVA range and validate guest IOVA ranges against it, and this patch does so. Signed-off-by: David Gibson <[email protected]> Reviewed-by: Laurent Vivier <[email protected]> Signed-off-by: Alex Williamson <[email protected]>
3898aad323475cf19127d9fc0846954d591d8e11
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/3898aad323475cf19127d9fc0846954d591d8e11
2015-10-05 12:38:13-06:00
qapi: Fix to reject union command and event arguments A command's or event's 'data' must be a struct type, given either as a dictionary, or as struct type name. Commit dd883c6 tightened the checking there, but not enough: we still accept 'union'. Fix to reject it. We may want to support union types there, but we'll have to extend qapi-commands.py and qapi-events.py for it. Signed-off-by: Markus Armbruster <[email protected]> Reviewed-by: Eric Blake <[email protected]>
315932b5edb86597adafbd1faa2d29c46499d8c3
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/315932b5edb86597adafbd1faa2d29c46499d8c3
2015-09-04 15:47:15+02:00
block: more check for replaced node We use mirror+replace to fix quorum's broken child. bs/s->common.bs is quorum, and to_replace is the broken child. The new child is target_bs. Without this patch, the replace node can be any node, and it can be top BDS with BB, or another quorum's child. We just check if the broken child is part of the quorum BDS in this patch. Signed-off-by: Wen Congyang <[email protected]> Message-id: [email protected] Signed-off-by: Stefan Hajnoczi <[email protected]>
e12f3784097a26a1ba51be420f41038b4c0ae5d1
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/e12f3784097a26a1ba51be420f41038b4c0ae5d1
2015-09-02 14:56:39+01:00
crypto: introduce new base module for TLS credentials Introduce a QCryptoTLSCreds class to act as the base class for storing TLS credentials. This will be later subclassed to provide handling of anonymous and x509 credential types. The subclasses will be user creatable objects, so instances can be created & deleted via 'object-add' and 'object-del' QMP commands respectively, or via the -object command line arg. If the credentials cannot be initialized an error will be reported as a QMP reply, or on stderr respectively. The idea is to make it possible to represent and manage TLS credentials independently of the network service that is using them. This will enable multiple services to use the same set of credentials and minimize code duplication. A later patch will convert the current VNC server TLS code over to use this object. The representation of credentials will be functionally equivalent to that currently implemented in the VNC server with one exception. The new code has the ability to (optionally) load a pre-generated set of diffie-hellman parameters, if the file dh-params.pem exists, whereas the current VNC server will always generate them on startup. This is beneficial for admins who wish to avoid the (small) time sink of generating DH parameters at startup and/or avoid depleting entropy. Signed-off-by: Daniel P. Berrange <[email protected]>
a090187de116a3d0b8146ca481249c8fc83ad3ee
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/a090187de116a3d0b8146ca481249c8fc83ad3ee
2015-09-15 14:47:37+01:00
qapi: Simplify error reporting for array types check_type() first checks and peels off the array type, then checks the element type. For two out of four error messages, it takes pains to report errors for "array of T" instead of just T. Odd. Let's examine the errors. * Unknown element type, e.g. tests/qapi-schema/args-array-unknown.json: Member 'array' of 'data' for command 'oops' uses unknown type 'array of NoSuchType' To make sense of this, you need to know that 'array of NoSuchType' refers to '[NoSuchType]'. Easy enough. However, simply reporting Member 'array' of 'data' for command 'oops' uses unknown type 'NoSuchType' is at least as easy to understand. * Element type's meta-type is inadmissible, e.g. tests/qapi-schema/returns-whitelist.json: 'returns' for command 'no-way-this-will-get-whitelisted' cannot use built-in type 'array of int' 'array of int' is technically not a built-in type, but that's pedantry. However, simply reporting 'returns' for command 'no-way-this-will-get-whitelisted' cannot use built-in type 'int' avoids the issue, and is at least as easy to understand. * The remaining two errors are unreachable, because the array checking ensures that value is a string. Thus, reporting some errors for "array of T" instead of just T works, but doesn't really improve things. Drop it. Signed-off-by: Markus Armbruster <[email protected]> Reviewed-by: Eric Blake <[email protected]>
eddf817bd823a90df209dfbdc2a0b2ec33b7cb77
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/eddf817bd823a90df209dfbdc2a0b2ec33b7cb77
2015-09-04 15:47:16+02:00
mirror: Speed up bitmap initial scanning Limiting to sectors_per_chunk for each bdrv_is_allocated_above is slow, because the underlying protocol driver would issue much more queries than necessary. We should coalesce the query. Signed-off-by: Fam Zheng <[email protected]> Reviewed-by: Stefan Hajnoczi <[email protected]> Message-id: <[email protected]> Signed-off-by: Stefan Hajnoczi <[email protected]>
999006975840f8cdf2038a587d852a6cbfe58e3b
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/999006975840f8cdf2038a587d852a6cbfe58e3b
2015-07-22 11:14:21+01:00
block: don't register quorum driver if SHA256 support is unavailable Commit 488981a4 [block: convert quorum blockdrv to use crypto APIs] broke qemu-iotest 041 on hosts with GnuTLS < 2.10.0. It converted a compile-time check to a run-time check at device open time. The result is that we now advertise a feature (the quorum block driver) that will never work (on those hosts). There's no way (short of parsing human-readable error messages) for qemu-iotests or any other API consumer to recognise that the quorum block driver isn't _actually_ available and shouldn't be used or tested. Move the run-time check to bdrv_quorum_init() to avoid registering the quorum block driver if we know it cannot work. This way API consumers can recognise it's unavailable. Fixes: 488981a4af396551a3178d032cc2b41d9553ada2 Signed-off-by: Sascha Silbe <[email protected]> Reviewed-by: Eric Blake <[email protected]> Reviewed-by: Daniel P. Berrange <[email protected]> Reviewed-by: Alberto Garcia <[email protected]> Message-id: [email protected] Signed-off-by: Peter Maydell <[email protected]>
e94867ed5f241008d0f53142b2704a075f9ed505
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/e94867ed5f241008d0f53142b2704a075f9ed505
2015-08-05 15:19:32+01:00
target-i386: emulate CPUID level of real hardware W10 insider has a bug where it ignores CPUID level and interprets CPUID.(EAX=07H, ECX=0H) incorrectly, because CPUID in fact returned CPUID.(EAX=04H, ECX=0H); this resulted in execution of unsupported instructions. While it's a Windows bug, there is no reason to emulate incorrect level. I used http://instlatx64.atw.hu/ as a source of CPUID and checked that it matches Penryn Xeon X5472, Westmere Xeon W3520, SandyBridge i5-2540M, and Haswell i5-4670T. kvm64 and qemu64 were bumped to 0xD to allow all available features for them (and to avoid the same Windows bug). Signed-off-by: Radim Krčmář <[email protected]> Reviewed-by: Eduardo Habkost <[email protected]> Signed-off-by: Eduardo Habkost <[email protected]>
3046bb5debc8153a542acb1df93b2a1a85527a15
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/3046bb5debc8153a542acb1df93b2a1a85527a15
2015-07-15 17:05:59-03:00
disas: cris: Fix 0 buffer length case Cris has the complication of variable length instructions and has a check in place to clamp memory reads in case the disas request doesn't have enough bytes for the instruction being disas'd. This breaks down in the case where disassembling for the monitor where the buffer length is defaulted to 0. The buffer length should never be zero for a regular target_disas, so we can safely assume the 0 case is for the monitor in which case consider the buffer length to be the max for cris instructions. Reviewed-by: Edgar E. Iglesias <[email protected]> Signed-off-by: Peter Crosthwaite <[email protected]> Signed-off-by: Andreas Färber <[email protected]>
51d373cf5f5a39fa315342d12ec910fe59d87090
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/51d373cf5f5a39fa315342d12ec910fe59d87090
2015-07-09 15:20:41+02:00
vvfat: add a label option Until now the vvfat volume label was hardcoded to be "QEMU VVFAT", now you can pass a file.label=labelname option to the -drive to change it. The FAT structure defines the volume label to be limited to 11 bytes and is filled up spaces when shorter than that. The trailing spaces however aren't exposed to the user by operating systems. [Added missing comment '#' characters in block-core.json to fix build errors. --Stefan] Signed-off-by: Wolfgang Bumiller <[email protected]> Message-id: [email protected] Reviewed-by: Eric Blake <[email protected]> Signed-off-by: Stefan Hajnoczi <[email protected]>
d5941ddae82a35771656d7e35f64f7f8f19c5627
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/d5941ddae82a35771656d7e35f64f7f8f19c5627
2015-06-23 15:06:17+01:00
i386: Introduce ARAT CPU feature ARAT signals that the APIC timer does not stop in power saving states. As our APICs are emulated, it's fine to expose this feature to guests, at least when asking for KVM host features or with CPU types that include the flag. The exact model number that introduced the feature is not known, but reports can be found that it's at least available since Sandy Bridge. Signed-off-by: Jan Kiszka <[email protected]> Acked-by: Paolo Bonzini <[email protected]> Acked-by: Michael S. Tsirkin <[email protected]> Reviewed-by: Eduardo Habkost <[email protected]> Signed-off-by: Eduardo Habkost <[email protected]>
28b8e4d0bf93ba176b4b7be819d537383c5a9060
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/28b8e4d0bf93ba176b4b7be819d537383c5a9060
2015-07-07 10:47:16-03:00
tcg: fix dead computation for repeated input arguments When the same temp is used twice or more as an input argument to a TCG instruction, the dead computation code doesn't recognize the second use as a dead temp. This is because the temp is marked as live in the same loop where dead inputs are checked. The fix is to split the loop in two parts. This avoid emitting a move and using a register for the movcond instruction when used as "move if true" on x86-64. This might bring more improvements on RISC TCG targets which don't have outputs aliased to inputs. Reviewed-by: Richard Henderson <[email protected]> Signed-off-by: Aurelien Jarno <[email protected]> Message-Id: <[email protected]> Signed-off-by: Richard Henderson <[email protected]>
c19f47bf5e8fe3dbd10206a52d0e6e348f803933
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/c19f47bf5e8fe3dbd10206a52d0e6e348f803933
2015-06-09 06:42:27-07:00
i386/acpi-build: fix PXB workarounds for unsupported BIOSes The patch apci: fix PXB behaviour if used with unsupported BIOS uses the following condition to see if a "PXB mem/IO chunk" has *not* been configured by the BIOS: (!range_base || range_base > range_limit) When this condition evaluates to true, said patch *omits* the corresponding entry from the _CRS. Later on the patch checks for the opposite condition (with the intent of *adding* entries to the _CRS if the "PXB mem/IO chunks" *have* been configured). Unfortunately, the condition was negated incorrectly: only the first ! operator was removed, which led to the nonsensical expression (range_base || range_base > range_limit) leading to bogus entries in the _CRS, and causing BSOD in Windows Server 2012 R2 when it runs on OVMF. The correct negative of the condition seen at the top is (range_base && range_base <= range_limit) Fix the expressions. Cc: Marcel Apfelbaum <[email protected]> Cc: Michael S. Tsirkin <[email protected]> Signed-off-by: Laszlo Ersek <[email protected]> Reviewed-by: Marcel Apfelbaum <[email protected]> Reviewed-by: Michael S. Tsirkin <[email protected]> Signed-off-by: Michael S. Tsirkin <[email protected]>
4ebc736e9938a7e88ecc785734b17145bf802a56
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/4ebc736e9938a7e88ecc785734b17145bf802a56
2015-06-11 12:40:30+02:00
virtio-pci: don't try to mask or unmask vqs without notifiers We should validate the vq index against nvqs_with_notifiers. Otherwise we may try to mask or unmask vector for vqs without notifiers (e.g control vq). This will lead qemu abort on kvm_irqchip_commit_routes() when trying to boot win8.1 guest. Fixes 851c2a75a6e80c8aa5e713864d98cfb512e7229b ("virtio-pci: speedup MSI-X masking and unmasking") Reported-by: Alex Williamson <[email protected]> Signed-off-by: Jason Wang <[email protected]> Reviewed-by: Michael S. Tsirkin <[email protected]> Signed-off-by: Michael S. Tsirkin <[email protected]>
6652d0811c9463fbfb2d2d1cb2ec03f388145c5f
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/6652d0811c9463fbfb2d2d1cb2ec03f388145c5f
2015-06-03 18:19:15+02:00
hw/arm/virt-acpi-build: Basic framework for building ACPI tables on ARM Introduce a preliminary framework in virt-acpi-build.c with the main ACPI build functions. It exposes the generated ACPI contents to guest over fw_cfg. The required ACPI v5.1 tables for ARM are: - RSDP: Initial table that points to XSDT - RSDT: Points to FADT GTDT MADT tables - FADT: Generic information about the machine - GTDT: Generic timer description table - MADT: Multiple APIC description table - DSDT: Holds all information about system devices/peripherals, pointed by FADT Signed-off-by: Shannon Zhao <[email protected]> Signed-off-by: Shannon Zhao <[email protected]> Reviewed-by: Alex Bennée <[email protected]> Reviewed-by: Igor Mammedov <[email protected]> Message-id: [email protected] Signed-off-by: Peter Maydell <[email protected]>
f5d8c8cd792b3712f85a1f9a3a9a719015691975
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/f5d8c8cd792b3712f85a1f9a3a9a719015691975
2015-05-29 11:28:54+01:00
qtest/ahci: add halted dma test If we're going to test the migration of halted DMA jobs, we should probably check to make sure we can resume them locally as a first step. Signed-off-by: John Snow <[email protected]> Reviewed-by: Kevin Wolf <[email protected]> Message-id: [email protected]
189d1b6126625212fbb50ed3a30a3e9e7ba7ca37
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/189d1b6126625212fbb50ed3a30a3e9e7ba7ca37
2015-05-22 15:58:22-04:00
net: Improve error message for -net hubport a bit Type "hubport" is valid only with -netdev. Unfortunately, that's detected late and the error message doesn't explain why: $ qemu-system-i386 -net hubport,id=foo,hubid=0 qemu-system-i386: -net hubport,id=foo,hubid=0: Device 'hubport' could not be initialized Improve the error message to "Parameter 'type' expects a net type". Not fixed: -net hubport without the parameters required by -netdev hubport still asks for those parameters: $ qemu-system-i386 -net hubport qemu-system-i386: -net hubport: Parameter 'hubid' is missing Signed-off-by: Markus Armbruster <[email protected]> Reviewed-by: Eric Blake <[email protected]> Message-id: [email protected] Signed-off-by: Stefan Hajnoczi <[email protected]>
ca7eb1848bb06d9b75784d7760b83c7b0beb1102
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/ca7eb1848bb06d9b75784d7760b83c7b0beb1102
2015-05-27 09:51:04+01:00
block/parallels: move parallels_open/probe to the very end of the file This will help to avoid forward declarations for upcoming parallels_check Some very obvious formatting fixes were made to the moved code to make checkpatch happy. Signed-off-by: Denis V. Lunev <[email protected]> Reviewed-by: Roman Kagan <[email protected]> Reviewed-by: Stefan Hajnoczi <[email protected]> Signed-off-by: Roman Kagan <[email protected]> Message-id: [email protected] CC: Kevin Wolf <[email protected]> Signed-off-by: Stefan Hajnoczi <[email protected]>
23d6bd3bd1225e8c8ade6ed829eabcf90ddfa6f7
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/23d6bd3bd1225e8c8ade6ed829eabcf90ddfa6f7
2015-05-22 09:37:32+01:00
s390x/mmu: Use ioctl for reading and writing from/to guest memory Add code to make use of the new ioctl for reading from / writing to virtual guest memory. By using the ioctl, the memory accesses are now protected with the so-called ipte-lock in the kernel. [CH: moved error message into kvm_s390_mem_op()] Signed-off-by: Thomas Huth <[email protected]> Acked-by: Christian Borntraeger <[email protected]> Signed-off-by: Cornelia Huck <[email protected]>
a9bcd1b8719dea2e91512238d810e2a0037e174d
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/a9bcd1b8719dea2e91512238d810e2a0037e174d
2015-04-30 13:21:42+02:00
hw/intc/arm_gic: Make ICDDCR/GICD_CTLR banked ICDDCR/GICD_CTLR is banked if the GIC has the security extensions, and the S (or only) copy has separate enable bits for Group0 and Group1 enable if the GIC implements interrupt groups. EnableGroup0 (Bit [1]) in GICv1 is architecturally IMPDEF. Since this bit (Enable Non-secure) is present in the integrated GIC of the Cortex-A9 MPCore, we support this bit in our GICv1 implementation too. Signed-off-by: Fabian Aggeler <[email protected]> Signed-off-by: Greg Bellows <[email protected]> Reviewed-by: Edgar E. Iglesias <[email protected]> Signed-off-by: Peter Maydell <[email protected]> Message-id: [email protected] Message-id: [email protected] [PMM: rewritten to store the state in a single s->ctlr uint32, with the NS register handled as an alias of bit 1 in that value; added vmstate version bump] Signed-off-by: Peter Maydell <[email protected]>
679aa175e84f5f80b32b307fce5a6b92729e0e61
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/679aa175e84f5f80b32b307fce5a6b92729e0e61
2015-05-12 11:57:17+01:00
qapi: More rigorous checking for type safety bypass Now that we have a way to validate every type, we can also be stricter about enforcing that callers that want to bypass type safety in generated code. Prior to this patch, it didn't matter what value was associated with the key 'gen', but it looked odd that 'gen':'yes' could result in bypassing the generated code. These changes also enforce the changes made earlier in the series for documentation and consolidation of using '**' as the wildcard type, as well as 'gen':false as the canonical spelling for requesting type bypass. Note that 'gen':false is a one-way switch away from the default; we do not support 'gen':true (similar for 'success-response'). In practice, this doesn't matter. Signed-off-by: Eric Blake <[email protected]> Reviewed-by: Markus Armbruster <[email protected]> Signed-off-by: Markus Armbruster <[email protected]>
2cbf09925ad45401673a79ab77f67de2f04a826c
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/2cbf09925ad45401673a79ab77f67de2f04a826c
2015-05-05 18:39:01+02:00
qapi: Add optional field "name" to block dirty bitmap This field will be set for user created dirty bitmap. Also pass in an error pointer to bdrv_create_dirty_bitmap, so when a name is already taken on this BDS, it can report an error message. This is not global check, two BDSes can have dirty bitmap with a common name. Implemented bdrv_find_dirty_bitmap to find a dirty bitmap by name, will be used later when other QMP commands want to reference dirty bitmap by name. Add bdrv_dirty_bitmap_make_anon. This unsets the name of dirty bitmap. Signed-off-by: Fam Zheng <[email protected]> Signed-off-by: John Snow <[email protected]> Reviewed-by: Max Reitz <[email protected]> Reviewed-by: Eric Blake <[email protected]> Reviewed-by: Stefan Hajnoczi <[email protected]> Message-id: [email protected] Signed-off-by: Stefan Hajnoczi <[email protected]> Signed-off-by: Kevin Wolf <[email protected]>
0db6e54a8a2c6e16780356422da671b71f862341
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/0db6e54a8a2c6e16780356422da671b71f862341
2015-04-28 15:36:10+02:00
translate-all: use glib for all page descriptor allocations Since commit b7b5233a "bsd-user/mmap.c: Don't try to override g_malloc/g_free" the exception we make here for usermode has been unnecessary. Get rid of it. Signed-off-by: Emilio G. Cota <[email protected]> Message-Id: <[email protected]> Signed-off-by: Paolo Bonzini <[email protected]>
e3a0abfda71db1fa83be894dcff7c4871b36cc8d
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/e3a0abfda71db1fa83be894dcff7c4871b36cc8d
2015-04-27 18:24:17+02:00
ppc: spapr: add 2.4 machine type The following patches will limit the following things to legacy machine type: - maximum number of virtqueues for virtio-pci were limited to 64 Cc: Alexander Graf <[email protected]> Cc: [email protected] Signed-off-by: Jason Wang <[email protected]> Reviewed-by: Michael S. Tsirkin <[email protected]> Signed-off-by: Michael S. Tsirkin <[email protected]> Reviewed-by: Alexander Graf <[email protected]>
d25228e7befac33b665cd9250292de47ae6b78b5
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/d25228e7befac33b665cd9250292de47ae6b78b5
2015-04-27 21:02:40+02:00
block/iscsi: use the allocationmap also if cache.direct=on the allocationmap has only a hint character. The driver always double checks that blocks marked unallocated in the cache are still unallocated before taking the fast path and return zeroes. So using the allocationmap is migration safe and can also be enabled with cache.direct=on. Signed-off-by: Peter Lieven <[email protected]> Message-id: [email protected] Signed-off-by: Stefan Hajnoczi <[email protected]> Signed-off-by: Kevin Wolf <[email protected]>
9eac3622a2b1159ab50b10540e822f3e58fdc383
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/9eac3622a2b1159ab50b10540e822f3e58fdc383
2015-04-28 15:36:10+02:00
exec: don't include hw/boards for linux-user As noted by Andreas, hw/boards.h shouldn't be used outside softmmu code. Include it conditionally, and drop the (now unnecessary) ifdef guards in hw/boards.h Reported-by: Andreas Färber <[email protected]> Cc: Peter Maydell <[email protected]> Signed-off-by: Michael S. Tsirkin <[email protected]> Reviewed-by: Andreas Färber <[email protected]>
4485bd269c0e1c051d21d0196be89cdba23d9520
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/4485bd269c0e1c051d21d0196be89cdba23d9520
2015-03-11 18:24:29+01:00
hmp: info spice: Show string channel name Useful for debugging. https://bugzilla.redhat.com/show_bug.cgi?id=822418 Signed-off-by: Cole Robinson <[email protected]> Reviewed-by: Eric Blake <[email protected]> Signed-off-by: Gerd Hoffmann <[email protected]>
22fa7da0005c939c940634da069ecb9bbb199a2a
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/22fa7da0005c939c940634da069ecb9bbb199a2a
2015-03-03 08:33:08+01:00
s390x: CPACF: Handle key wrap machine options Check for the aes_key_wrap and dea_key_wrap machine options and set the appropriate KVM device attribute(s) to tell the kernel to enable or disable the AES/DEA protected key functions for the guest domain. This patch introduces two new machine options for indicating the state of AES/DEA key wrapping functions. This controls whether the guest will have access to the AES/DEA crypto functions. aes_key_wrap="on | off" is changed to aes-key-wrap="on | off" dea_key_wrap="on | off" is changed to dea-key-wrap="on | off" Check for the aes-key-wrap and dea-key-wrap machine options and set the appropriate KVM device attribute(s) to tell the kernel to enable or disable the AES/DEA protected key functions for the guest domain. Reviewed-by: David Hildenbrand <[email protected]> Signed-off-by: Tony Krowiak <[email protected]> Signed-off-by: Jens Freimann <[email protected]> Message-Id: <[email protected]> Signed-off-by: Cornelia Huck <[email protected]>
2eb1cd0768af18fb2398ee7b590e4b81e0e504f9
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/2eb1cd0768af18fb2398ee7b590e4b81e0e504f9
2015-03-16 10:20:11+01:00
BlockConf: Call backend functions to detect geometry and blocksizes geometry: hd_geometry_guess function autodetects the drive geometry. This patch adds a block backend call, that probes the backing device geometry. If the inner driver method is implemented and succeeds (currently only for DASDs), the blkconf_geometry will pass-through the backing device geometry. Otherwise will fallback to old logic. blocksize: This patch initializes blocksize properties to 0. In order to set the property a blkconf_blocksizes was introduced. If user didn't set physical or logical blocksize, it will retrieve its value from a driver (only succeeds for DASD), otherwise it will set default 512 value. The blkconf_blocksizes call was added to all users of BlkConf. Signed-off-by: Ekaterina Tumanova <[email protected]> Reviewed-by: Markus Armbruster <[email protected]> Reviewed-by: Stefan Hajnoczi <[email protected]> Message-id: [email protected] Signed-off-by: Stefan Hajnoczi <[email protected]> Signed-off-by: Kevin Wolf <[email protected]>
0eb28a42284ec32e6f283985d2d638474a05eba4
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/0eb28a42284ec32e6f283985d2d638474a05eba4
2015-03-10 14:02:22+01:00
pc: acpi-build: simplify PCI bus tree generation it basicaly does the same as original approach, * just without bus/notify tables tracking (less obscure) which is easier to follow. * drops unnecessary loops and bitmaps, creating devices and notification method in the same loop. * saves us ~100LOC Signed-off-by: Igor Mammedov <[email protected]> Reviewed-by: Michael S. Tsirkin <[email protected]> Signed-off-by: Michael S. Tsirkin <[email protected]>
b23046abe78f48498a423b802d6d86ba0172d57f
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/b23046abe78f48498a423b802d6d86ba0172d57f
2015-03-01 12:33:23+01:00
s390x/kvm: more details for SIGP handler with one destination vcpu Whenever a sigp order is to be executed by a target vcpu, we use run_on_cpu(). As we have only one pointer to pass all data to these sigp handlers, let's introduce the struct sigp_info and use it as a transport container. All orders targeting a single vcpu are now dispatched from a separate handler. The destination vcpu is only valid for these orders and must not be checked for SIGP SET ARCHITECTURE. The sigp_info is filled with life in this new handler and used to pass the information about the sigp order to the existing handlers. The cc is set within these handlers. Rename sigp_cpu_start() and sigp_cpu_restart() on the way to match the SIGP order names (in order to avoid touching affected lines several times). Reviewed-by: Thomas Huth <[email protected]> Signed-off-by: Jens Freimann <[email protected]> Signed-off-by: David Hildenbrand <[email protected]> Message-Id: <[email protected]> Signed-off-by: Christian Borntraeger <[email protected]>
6eb8f212d2686ed9b17077d554465df7ae06f805
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/6eb8f212d2686ed9b17077d554465df7ae06f805
2015-03-10 09:26:22+01:00
pci: Allocate PCIe host bridge PCI ID We are going to introduce a PCIe host controller that doesn't exist that way in real hardware, but still needs to expose some PCIe root device which has PCI IDs. Allocate a PCI ID in the Red Hat space that we use for other devices of this kind. Signed-off-by: Alexander Graf <[email protected]> Signed-off-by: Peter Maydell <[email protected]>
bf439db4993b02033d4fba8460ca4dc45b15071a
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/bf439db4993b02033d4fba8460ca4dc45b15071a
2015-02-13 05:46:07+00:00
qtest: Fix deadloop by running main loop AIO context's timers qemu_clock_run_timers() only takes care of main_loop_tlg, we shouldn't forget aio timer list groups. Currently, the qemu_clock_deadline_ns_all (a few lines above) counts all the timergroups of this clock type, including aio tlg, but we don't fire them, so they are never cleared, which makes a dead loop. For example, this function hangs when trying to drive throttled block request queue with qtest clock_step. Signed-off-by: Fam Zheng <[email protected]> Acked-by: Paolo Bonzini <[email protected]> Message-id: [email protected] Signed-off-by: Stefan Hajnoczi <[email protected]>
efef88b3d9ad4325172ed288032807fa88d683cc
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/efef88b3d9ad4325172ed288032807fa88d683cc
2015-02-16 15:07:17+00:00
MAINTAINERS: migration: add vmstate static checker files Signed-off-by: Amit Shah <[email protected]> Reviewed-by: Juan Quintela <[email protected]> Signed-off-by: Amit Shah <[email protected]>
c55156402e5b1f64b17c3261ef39a5e6666d9209
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/c55156402e5b1f64b17c3261ef39a5e6666d9209
2014-12-16 17:47:35+05:30
s390x/kvm: sync register support helper function Let's unify the code to sync registers by moving the checks into a helper function can_sync_regs(). Signed-off-by: David Hildenbrand <[email protected]> Signed-off-by: Jens Freimann <[email protected]> Reviewed-by: Cornelia Huck <[email protected]> Signed-off-by: Cornelia Huck <[email protected]>
fdb78ec00655e59c8d47eec91918a4da0d966685
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/fdb78ec00655e59c8d47eec91918a4da0d966685
2015-01-12 10:14:04+01:00
target-ppc: VXSQRT Should Not Be Set for NaNs The Power ISA square root instructions (fsqrt[s], frsqrte[s]) must set the FPSCR[VXSQRT] flag when operating on a negative value. However, NaNs have no sign and therefore this flag should not be set when operating on one. Change the order of the checks in the helper code. Move the SNaN-to-QNaN macro to the top of the file so that it can be re-used. Signed-off-by: Tom Musta <[email protected]> Signed-off-by: Alexander Graf <[email protected]>
b748863a7f7d2996255dd2cb5a20e49785cc7387
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/b748863a7f7d2996255dd2cb5a20e49785cc7387
2015-01-07 16:16:25+01:00
cpu_ldst.h: Don't define helpers if MMU_MODE*_SUFFIX not defined Not all targets define a full set of suffix strings for the NB_MMU_MODES that they have. In this situation, don't define any helper functions for that mode, rather than defining helper functions with no suffix at all. The MMU mode is still functional; it is merely not directly accessible via cpu_ld*_MODE from target helper functions. Also add an "NB_MMU_MODES >= 2" check to the definition of the mode 1 helpers -- some targets only define one MMU mode. Signed-off-by: Peter Maydell <[email protected]> Reviewed-by: Richard Henderson <[email protected]> Message-id: [email protected]
de5ee4a888667ca0a198f0743d70075d70564117
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/de5ee4a888667ca0a198f0743d70075d70564117
2015-01-20 15:19:35+00:00
exec: qemu_ram_alloc_resizeable, qemu_ram_resize Add API to allocate "resizeable" RAM. This looks just like regular RAM generally, but has a special property that only a portion of it (used_length) is actually used, and migrated. This used_length size can change across reboots. Follow up patches will change used_length for such blocks at migration, making it easier to extend devices using such RAM (notably ACPI, but in the future thinkably other ROMs) without breaking migration compatibility or wasting ROM (guest) memory. Device is notified on resize, so it can adjust if necessary. qemu_ram_alloc_resizeable allocates this memory, qemu_ram_resize resizes it. Note: nothing prevents making all RAM resizeable in this way. However, reviewers felt that only enabling this selectively will make some class of errors easier to detect. Signed-off-by: Michael S. Tsirkin <[email protected]> Reviewed-by: Paolo Bonzini <[email protected]>
62be4e3a5041e84304aa23637da623a205c53ecc
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/62be4e3a5041e84304aa23637da623a205c53ecc
2015-01-08 13:17:54+02:00
target-mips: Make `helper_float_cvtw_s' consistent with the remaining helpers Move the call to `update_fcr31' in `helper_float_cvtw_s' after the exception flag check, for consistency with the remaining helpers that do it last too. Signed-off-by: Maciej W. Rozycki <[email protected]> Signed-off-by: Leon Alrae <[email protected]>
2b09f94cdbf5c54e2278d7f3aed2eceff3494790
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/2b09f94cdbf5c54e2278d7f3aed2eceff3494790
2014-12-16 12:45:19+00:00
spapr: Allow dynamic creation of PHB Now that we finally check for presence of dangling sysbus devices, make check started complaining that the sPAPR PHB is one such device. However, it really isn't. The spapr PHB is not really a traditional sysbus device, but much more a special spapr pv device which is already able to get created dynamically. Move spapr to its own dynamic sysbus check handling and allow PHB devices to get allocated dynamically. Signed-off-by: Alexander Graf <[email protected]>
9e3f973335afb3d5758aeebeb3ad478427d79bd4
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/9e3f973335afb3d5758aeebeb3ad478427d79bd4
2014-11-04 23:26:15+01:00
sysbus: Expose MMIO enumeration helper Sysbus devices have a range of MMIO regions they expose. The exact number of regions is device specific and internal information to the device model. Expose whether a region exists via a public interface. That way our platform bus enumeration code can dynamically determine how many regions exist. Signed-off-by: Alexander Graf <[email protected]>
471a9bc14444e79bb826616becd2e5531e591d30
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/471a9bc14444e79bb826616becd2e5531e591d30
2014-11-04 23:26:14+01:00
cpu-exec: fix cpu_exec_nocache In icount mode cpu_exec_nocache function is used to execute part of the existing TB. At the end of cpu_exec_nocache newly created TB is deleted. Sometimes io_read function needs to recompile current TB and restart TB lookup and execution. After that tb_find_fast function finds old (bigger) TB again. This TB cannot be executed (because icount is not big enough) and cpu_exec_nocache is called again. Such a loop continues over and over. This patch deletes old TB and avoids finding it in the TB cache. Signed-off-by: Pavel Dovgalyuk <[email protected]> Signed-off-by: Paolo Bonzini <[email protected]>
b4ac20b4df0d1eaa5d546ccb84751e3e97d257fd
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/b4ac20b4df0d1eaa5d546ccb84751e3e97d257fd
2014-12-15 12:21:02+01:00
exec: Handle multipage ranges in invalidate_and_set_dirty() The code in invalidate_and_set_dirty() needs to handle addr/length combinations which cross guest physical page boundaries. This can happen, for example, when disk I/O reads large blocks into guest RAM which previously held code that we have cached translations for. Unfortunately we were only checking the clean/dirty status of the first page in the range, and then were calling a tb_invalidate function which only handles ranges that don't cross page boundaries. Fix the function to deal with multipage ranges. The symptoms of this bug were that guest code would misbehave (eg segfault), in particular after a guest reboot but potentially any time the guest reused a page of its physical RAM for new code. Cc: [email protected] Signed-off-by: Peter Maydell <[email protected]> Reviewed-by: Paolo Bonzini <[email protected]> Message-id: [email protected]
f874bf905ff2f8dcc17acbfc61e49a92a6f4d04b
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/f874bf905ff2f8dcc17acbfc61e49a92a6f4d04b
2014-11-18 10:19:12+00:00
qcow2: Pull check_refblocks() up Pull check_refblocks() before calculate_refcounts() so we can drop its static declaration. Signed-off-by: Max Reitz <[email protected]> Reviewed-by: Benoît Canet <[email protected]> Reviewed-by: Kevin Wolf <[email protected]> Signed-off-by: Kevin Wolf <[email protected]>
057a3fe57e740e5e1cc3d62c9b8e0085e9fffa74
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/057a3fe57e740e5e1cc3d62c9b8e0085e9fffa74
2014-10-23 15:34:01+02:00