commit_msg
stringlengths
1
24.2k
commit_hash
stringlengths
2
84
project
stringlengths
2
40
source
stringclasses
4 values
labels
int64
0
1
repo_url
stringlengths
26
70
commit_url
stringlengths
74
118
commit_date
stringlengths
25
25
s390x/tcg: rework checking for deliverable interrupts Currently, enabling/disabling of interrupts is not really supported. Let's improve interrupt handling code by explicitly checking for deliverable interrupts only. This is the first step. Checking for external interrupt subclasses will be done next. Signed-off-by: David Hildenbrand <[email protected]> Message-Id: <[email protected]> Reviewed-by: Richard Henderson <[email protected]> Signed-off-by: Cornelia Huck <[email protected]>
8417f904bad50021b432dfea12613345d9fb1f68
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/8417f904bad50021b432dfea12613345d9fb1f68
2017-10-20 13:32:10+02:00
accel/tcg: allow to invalidate a write TLB entry immediately Background: s390x implements Low-Address Protection (LAP). If LAP is enabled, writing to effective addresses (before any translation) 0-511 and 4096-4607 triggers a protection exception. So we have subpage protection on the first two pages of every address space (where the lowcore - the CPU private data resides). By immediately invalidating the write entry but allowing the caller to continue, we force every write access onto these first two pages into the slow path. we will get a tlb fault with the specific accessed addresses and can then evaluate if protection applies or not. We have to make sure to ignore the invalid bit if tlb_fill() succeeds. Signed-off-by: David Hildenbrand <[email protected]> Message-Id: <[email protected]> Signed-off-by: Cornelia Huck <[email protected]>
f52bfb12143e29d7c8bd827bdb751aee47a9694e
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/f52bfb12143e29d7c8bd827bdb751aee47a9694e
2017-10-20 13:32:10+02:00
hw/block/onenand: Remove dead code block The condition of the for-loop makes sure that b is always smaller than s->blocks, so the "if (b >= s->blocks)" statement is completely superfluous here. Buglink: https://bugs.launchpad.net/qemu/+bug/1715007 Signed-off-by: Thomas Huth <[email protected]> Reviewed-by: Laurent Vivier <[email protected]> Signed-off-by: Kevin Wolf <[email protected]>
dbfa934106d22402d809d039e773b50ab1885477
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/dbfa934106d22402d809d039e773b50ab1885477
2017-10-06 16:28:58+02:00
linux-user: Tidy and enforce reserved_va initialization We had a check using TARGET_VIRT_ADDR_SPACE_BITS to make sure that the allocation coming in from the command-line option was not too large, but that didn't include target-specific knowledge about other restrictions on user-space. Remove several target-specific hacks in linux-user/main.c. For MIPS and Nios, we can replace them with proper adjustments to the respective target's TARGET_VIRT_ADDR_SPACE_BITS definition. For ARM, we had no existing ifdef but I suspect that the current default value of 0xf7000000 was chosen with this in mind. Define a workable value in linux-user/arm/, and also document why the special case is required. Signed-off-by: Richard Henderson <[email protected]> Reviewed-by: Peter Maydell <[email protected]> Message-Id: <[email protected]> Signed-off-by: Riku Voipio <[email protected]>
18e80c55bb6ec17c05ec0ba717ec83933c2bfc07
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/18e80c55bb6ec17c05ec0ba717ec83933c2bfc07
2017-10-16 16:00:56+03:00
spapr: fix the value of SDR1 in kvmppc_put_books_sregs() When running with KVM PR, if a new HPT is allocated we need to inform KVM about the HPT address and size. This is currently done by hacking the value of SDR1 and pushing it to KVM in several places. Also, migration breaks the guest since it is very unlikely the HPT has the same address in source and destination, but we push the incoming value of SDR1 to KVM anyway. This patch introduces a new virtual hypervisor hook so that the spapr code can provide the correct value of SDR1 to be pushed to KVM each time kvmppc_put_books_sregs() is called. It allows to get rid of all the hacking in the spapr/kvmppc code and it fixes migration of nested KVM PR. Suggested-by: David Gibson <[email protected]> Signed-off-by: Greg Kurz <[email protected]> Signed-off-by: David Gibson <[email protected]>
1ec26c757d5996468afcc0dced4fad04139574b3
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/1ec26c757d5996468afcc0dced4fad04139574b3
2017-09-27 13:05:41+10:00
vfio/pci: Add NVIDIA GPUDirect Cliques support NVIDIA has defined a specification for creating GPUDirect "cliques", where devices with the same clique ID support direct peer-to-peer DMA. When running on bare-metal, tools like NVIDIA's p2pBandwidthLatencyTest (part of cuda-samples) determine which GPUs can support peer-to-peer based on chipset and topology. When running in a VM, these tools have no visibility to the physical hardware support or topology. This option allows the user to specify hints via a vendor defined capability. For instance: <qemu:commandline> <qemu:arg value='-set'/> <qemu:arg value='device.hostdev0.x-nv-gpudirect-clique=0'/> <qemu:arg value='-set'/> <qemu:arg value='device.hostdev1.x-nv-gpudirect-clique=1'/> <qemu:arg value='-set'/> <qemu:arg value='device.hostdev2.x-nv-gpudirect-clique=1'/> </qemu:commandline> This enables two cliques. The first is a singleton clique with ID 0, for the first hostdev defined in the XML (note that since cliques define peer-to-peer sets, singleton clique offer no benefit). The subsequent two hostdevs are both added to clique ID 1, indicating peer-to-peer is possible between these devices. QEMU only provides validation that the clique ID is valid and applied to an NVIDIA graphics device, any validation that the resulting cliques are functional and valid is the user's responsibility. The NVIDIA specification allows a 4-bit clique ID, thus valid values are 0-15. Signed-off-by: Alex Williamson <[email protected]>
dfbee78db8fdf7bc8c151c3d29504bb47438480b
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/dfbee78db8fdf7bc8c151c3d29504bb47438480b
2017-10-03 12:57:36-06:00
s390x/css: fix NULL handling for CCW addresses Back then in the time of df1fe5bb49 ("s390: Virtual channel subsystem support.", 2013-01-24) -EIO used to map to a channel-program check (via the default label of the switch statement). Then 2dc95b4cac ("s390x/3270: 3270 data stream handling", 2016-04-01) came along and that changed dramatically. Let us roll back this undesired side effect, and go back to channel-program check. Signed-off-by: Halil Pasic <[email protected]> Fixes: 2dc95b4cac "s390x/3270: 3270 data stream handling" Message-Id: <[email protected]> Signed-off-by: Cornelia Huck <[email protected]>
cc6a9f8dc9278e9a5d499ea114b0a10b3bf5f134
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/cc6a9f8dc9278e9a5d499ea114b0a10b3bf5f134
2017-09-19 18:21:33+02:00
tests: Fix broken ivshmem-server-msi/-irq tests Broken with commit b4ba67d9a7025 ("libqos: Change PCI accessors to take opaque BAR handle") a while ago, but nobody noticed since the tests are not run by default: The msix_pba_bar is not correctly initialized anymore if bir_pba has the same value as bir_table. With this fix, "make check SPEED=slow" should work fine again. Fixes: b4ba67d9a702507793c2724e56f98e9b0f7be02b Tested-by: Cornelia Huck <[email protected]> Reviewed-by: David Gibson <[email protected]> Reviewed-by: Laurent Vivier <[email protected]> Signed-off-by: Thomas Huth <[email protected]>
4446158a1a89d51d8724090aa8bd115729533e3a
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/4446158a1a89d51d8724090aa8bd115729533e3a
2017-09-15 09:05:18+02:00
target/i386: [tcg] Port to DisasContextBase Incrementally paves the way towards using the generic instruction translation loop. Signed-off-by: Lluís Vilanova <[email protected]> Reviewed-by: Emilio G. Cota <[email protected]> Reviewed-by: Richard Henderson <[email protected]> Reviewed-by: Alex Benneé <[email protected]> Message-Id: <[email protected]> Signed-off-by: Richard Henderson <[email protected]>
6cf147aa299e49f7794858609a1e8ef19f81c007
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/6cf147aa299e49f7794858609a1e8ef19f81c007
2017-09-06 08:06:47-07:00
nvic: Don't apply group priority mask to negative priorities In several places we were unconditionally applying the nvic_gprio_mask() to a priority value. This is incorrect if the priority is one of the fixed negative priority values (for NMI and HardFault), so don't do it. This bug would have caused both NMI and HardFault to be considered as the same priority and so NMI wouldn't correctly preempt HardFault. Signed-off-by: Peter Maydell <[email protected]> Reviewed-by: Richard Henderson <[email protected]> Message-id: [email protected]
22a9c26af62f9772b7c0512e88f97d0d1f2e0872
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/22a9c26af62f9772b7c0512e88f97d0d1f2e0872
2017-09-14 18:43:17+01:00
tcg/arm: Improve tlb load for armv7 Use UBFX to avoid limitation on CPU_TLB_BITS. Since we're dropping the initial shift, we need to replace the page masking. We can use MOVW+BIC to do this without shifting. The result is the same size as the armv6 path with one less conditional instruction. Signed-off-by: Richard Henderson <[email protected]>
647ab96aaf5defeb138e48d610f7f633c587b40d
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/647ab96aaf5defeb138e48d610f7f633c587b40d
2017-09-07 11:57:35-07:00
qlit: move qlit from check-qjson to qobject/ Fix code style issues while at it, to please checkpatch. Signed-off-by: Marc-André Lureau <[email protected]> Reviewed-by: Markus Armbruster <[email protected]> Message-Id: <[email protected]> Signed-off-by: Markus Armbruster <[email protected]>
28035bcdf4647245743cf87cea3788331bf67a5f
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/28035bcdf4647245743cf87cea3788331bf67a5f
2017-09-04 13:09:11+02:00
qcow2: use DIV_ROUND_UP I used the clang-tidy qemu-round check to generate the fix: https://github.com/elmarco/clang-tools-extra Signed-off-by: Marc-André Lureau <[email protected]> Reviewed-by: Eric Blake <[email protected]> Reviewed-by: Richard Henderson <[email protected]>
21cf3e120191eb1302da2bbfc6c41239e0d84db7
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/21cf3e120191eb1302da2bbfc6c41239e0d84db7
2017-08-31 12:29:07+02:00
misc: Remove unused Error variables There's a few cases which we're passing an Error pointer to a function only to discard it immediately afterwards without checking it. In these cases we can simply remove the variable and pass NULL instead. Signed-off-by: Alberto Garcia <[email protected]> Reviewed-by: Philippe Mathieu-Daudé <[email protected]> Reviewed-by: Eric Blake <[email protected]> Message-id: [email protected] Signed-off-by: Stefan Hajnoczi <[email protected]>
c3a8fe331eb4310e2d058f1c15a817d255840323
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/c3a8fe331eb4310e2d058f1c15a817d255840323
2017-08-30 11:58:26+01:00
iotests: Add test of recent fix to 'qemu-img measure' The new test 190 ensures we don't regress back to an infinite loop when measuring the size of a 2T+ qcow2 image. I did not append to test 178, because that test is also designed to run with format 'raw'; also, this gives us some coverage of the measure command under the quick group. Signed-off-by: Eric Blake <[email protected]> Reviewed-by: Stefan Hajnoczi <[email protected]> Signed-off-by: Kevin Wolf <[email protected]>
b81b74bfb2ea3d23dc06cb0c84841dbea201b8de
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/b81b74bfb2ea3d23dc06cb0c84841dbea201b8de
2017-08-01 18:09:33+02:00
s390x/css: fix ilen in IO instruction handlers When initiating a program check interruption by calling program_interrupt the instruction length (ilen) of the current instruction is supplied as the third parameter. On s390x all the IO instructions are of instruction format S and their ilen is 4. The calls to program_interrupt (introduced by commits 7b18aad543 ("s390: Add channel I/O instructions.", 2013-01-24) and 61bf0dcb2e ("s390x/ioinst: Add missing alignment checks for IO instructions", 2013-06-21)) however use ilen == 2. This is probably due to a confusion between ilen which specifies the instruction length in bytes and ILC which does the same but in halfwords. If kvm_enabled() this does not actually matter, because the ilen parameter of program_interrupt is effectively unused. Let's provide the correct ilen to program_interrupt. Signed-off-by: Halil Pasic <[email protected]> Fixes: 7b18aad543 ("s390: Add channel I/O instructions.") Fixes: 61bf0dcb2e ("s390x/ioinst: Add missing alignment checks for IO instructions") Reviewed-by: David Hildenbrand <[email protected]> Message-Id: <[email protected]> Reviewed-by: Dong Jia Shi <[email protected]> Signed-off-by: Cornelia Huck <[email protected]>
7e01376daea75e888c370aab521a7d4aeaf2ffd1
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/7e01376daea75e888c370aab521a7d4aeaf2ffd1
2017-07-25 09:17:42+02:00
qemu-img: Check for backing image if specified during create Or, rather, force the open of a backing image if one was specified for creation. Using a similar -unsafe option as rebase, allow qemu-img to ignore the backing file validation if possible. It may not always be possible, as in the existing case when a filesize for the new image was not specified. This is accomplished by shifting around the conditionals in bdrv_img_create, such that a backing file is always opened unless we provide BDRV_O_NO_BACKING. qemu-img is adjusted to pass this new flag when -u is provided to create. Sorry for the heinous looking diffstat, but it's mostly whitespace. Inspired by: https://bugzilla.redhat.com/show_bug.cgi?id=1213786 Signed-off-by: John Snow <[email protected]> Signed-off-by: Kevin Wolf <[email protected]>
6e6e55f5c2e5b520d6506c2716287ba3b5d1bbc8
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/6e6e55f5c2e5b520d6506c2716287ba3b5d1bbc8
2017-07-18 15:27:37+02:00
Rework PowerPC exceptions model to make it more versatile: * don't use exception vectors as the exception number. Use vectors numbers as defined in the PowerPC embedded specification instead and extend this model to cover all emulated PowerPC variants exceptions. * add some missing exceptions definitions, from PowerPC 2.04 specification and actual PowerPC implementations. * add code provision for hypervisor exceptions handling. * define exception vectors and prefix in CPUPPCState to emulate BookE exception vectors without any hacks. * define per CPU model valid exception vectors. * handle all known exceptions in user-mode only emulations. * fix hardware interrupts priorities in most cases. * change RET_EXCP macros name into GEN_EXCP as they don't return. * do not stop translation on most instructions that are not defined as context-synchronizing in PowerPC specification. * fix PowerPC 64 jump targets and link register update when in 32 bits mode. * Fix PowerPC 464 and 464F definitions. git-svn-id: svn://svn.savannah.nongnu.org/qemu/trunk@3261 c046a42c-6fe2-441c-8c8c-71466251a162
e1833e1f96456fd8fc17463246fe0b2050e68efb
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/e1833e1f96456fd8fc17463246fe0b2050e68efb
2007-09-29 13:06:16+00:00
target/ppc: Refactor tcg radix mmu code The mmu-radix64.c file implements functions to enable the radix mmu emulation in tcg mode. There is a function ppc_radix64_walk_tree() which performs the radix tree walk and also implicitly checks the pte protection. Move the protection checking of the pte from the ppc_radix64_walk_tree() function into the caller. This means the ppc_radix64_walk_tree() function can be used without protection checking which is useful for debugging. ppc_radix64_walk_tree() no longer needs to take the rwx and prot variables. Signed-off-by: Suraj Jitindar Singh <[email protected]> Signed-off-by: David Gibson <[email protected]>
6a042827b638dc73da6a72c72596f5be80bd4581
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/6a042827b638dc73da6a72c72596f5be80bd4581
2017-07-11 11:04:02+10:00
docker: rebuild image if 'extra files' checksum does not match Signed-off-by: Philippe Mathieu-Daudé <[email protected]> Reviewed-by: Alex Bennée <[email protected]> Signed-off-by: Alex Bennée <[email protected]>
438d116872ccfe6d8fb9c260e2e828cbcfa64c4f
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/438d116872ccfe6d8fb9c260e2e828cbcfa64c4f
2017-06-21 15:01:48+01:00
qcow2: Use unsigned int for both members of Qcow2COWRegion Qcow2COWRegion has two attributes: - The offset of the COW region from the start of the first cluster touched by the I/O request. Since it's always going to be positive and the maximum request size is at most INT_MAX, we can use a regular unsigned int to store this offset. - The size of the COW region in bytes. This is guaranteed to be >= 0, so we should use an unsigned type instead. In x86_64 this reduces the size of Qcow2COWRegion from 16 to 8 bytes. It will also help keep some assertions simpler now that we know that there are no negative numbers. The prototype of do_perform_cow() is also updated to reflect these changes. Signed-off-by: Alberto Garcia <[email protected]> Reviewed-by: Eric Blake <[email protected]> Reviewed-by: Kevin Wolf <[email protected]> Signed-off-by: Kevin Wolf <[email protected]>
e034f5bcbc1139903b27c00bd832ee7c4b065810
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/e034f5bcbc1139903b27c00bd832ee7c4b065810
2017-06-26 14:51:13+02:00
migration: let MigrationState be a qdev Let the old man "MigrationState" join the object family. Direct benefit is that we can start to use all the property features derived from current QDev, like: HW_COMPAT_* bits, command line setup for migration parameters (so will never need to set them up each time using HMP/QMP, this is really, really attractive for test writters), etc. I see no reason to disallow this happen yet. So let's start from this one, to see whether it would be anything good. Now we init the MigrationState struct statically in main() to make sure it's initialized after global properties are applied, since we'll use them during creation of the object. No functional change at all. Reviewed-by: Juan Quintela <[email protected]> Signed-off-by: Peter Xu <[email protected]> Message-Id: <[email protected]> Reviewed-by: Eduardo Habkost <[email protected]> Signed-off-by: Juan Quintela <[email protected]>
e5cb7e7677010f529d3f0f9dcdb385dea9446f8d
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/e5cb7e7677010f529d3f0f9dcdb385dea9446f8d
2017-06-28 11:18:38+02:00
target/arm: Exit after clearing aarch64 interrupt mask Exit to cpu loop so we reevaluate cpu_arm_hw_interrupts. Tested-by: Emilio G. Cota <[email protected]> Tested-by: Alex Bennée <[email protected]> Reviewed-by: Emilio G. Cota <[email protected]> Reviewed-by: Alex Bennée <[email protected]> Signed-off-by: Richard Henderson <[email protected]>
8da54b2507c1cabf60c2de904cf0383b23239231
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/8da54b2507c1cabf60c2de904cf0383b23239231
2017-06-19 11:11:26-07:00
block: introduce dirty_bitmap_mutex It protects only the list of dirty bitmaps; in the next patch we will also protect their content. Reviewed-by: Stefan Hajnoczi <[email protected]> Signed-off-by: Paolo Bonzini <[email protected]> Message-Id: <[email protected]> Signed-off-by: Fam Zheng <[email protected]>
2119882c7eb7e2c612b24fc0c8d86f5887d6f1c3
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/2119882c7eb7e2c612b24fc0c8d86f5887d6f1c3
2017-06-16 07:55:00+08:00
timer/aspeed: fix timer enablement when a reload is not set When a timer is enabled before a reload value is set, the controller waits for a reload value to be set before starting decrementing. This fix tries to cover that case by changing the timer expiry only when a reload value is valid. Signed-off-by: Cédric Le Goater <[email protected]> Reviewed-by: Andrew Jeffery <[email protected]> Message-id: [email protected] Signed-off-by: Peter Maydell <[email protected]>
1403f36447216775e701fdae8bc8f00d359ecf0a
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/1403f36447216775e701fdae8bc8f00d359ecf0a
2017-06-13 14:57:00+01:00
be-hci: use backend functions Avoid accessing CharBackend directly, use qemu_chr_be_* methods instead. be->chr_read should exists if qemu_chr_be_can_write() is true. (use qemu_chr_be_write(), _impl() bypasses replay) Signed-off-by: Marc-André Lureau <[email protected]> Reviewed-by: Andrzej Zaborowski <[email protected]>
93a78e41242ba164ae6af1690ea68fe22165ad4b
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/93a78e41242ba164ae6af1690ea68fe22165ad4b
2017-06-02 11:33:53+04:00
block/win32: fix 'ret not initialized' warning Signed-off-by: Gerd Hoffmann <[email protected]> Reviewed-by: Stefan Weil <[email protected]> Reviewed-by: Fam Zheng <[email protected]> Message-id: [email protected] Signed-off-by: Stefan Hajnoczi <[email protected]>
cdece0467c00007cf8e3f4b3c3f0b13bf2c4fea9
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/cdece0467c00007cf8e3f4b3c3f0b13bf2c4fea9
2017-05-16 15:34:18+01:00
file-posix: Remove .bdrv_inactivate/invalidate_cache Now that the block layer takes care to request a lot less permissions for inactive nodes, the special-casing in file-posix isn't necessary any more. Signed-off-by: Kevin Wolf <[email protected]> Reviewed-by: Eric Blake <[email protected]>
22d5cd82e98b61b1dbd791fab9f4ae0f77c0ed14
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/22d5cd82e98b61b1dbd791fab9f4ae0f77c0ed14
2017-05-11 12:08:24+02:00
pseries: Restore support for total vcpus not a multiple of threads-per-core for old machine types As of pseries-2.7 and later, we require the total number of guest vcpus to be a multiple of the threads-per-core. pseries-2.6 and earlier machine types, however, are supposed to allow this for the sake of migration from old qemu versions which allowed this. Unfortunately, 8149e29 "pseries: Enforce homogeneous threads-per-core" broke this by not considering the old machine type case. This fixes it by only applying the check when the machine type supports hotpluggable cpus. By not-entirely-coincidence, that corresponds to the same time when we started enforcing total threads being a multiple of threads-per-core. Fixes: 8149e2992f7811355cc34721b79d69d1a3a667dd Signed-off-by: David Gibson <[email protected]> Reviewed-by: Laurent Vivier <[email protected]> Reviewed-by: Greg Kurz <[email protected]> Tested-by: Greg Kurz <[email protected]>
459264ef24cf2d409b8baf2047fa86e697d6e9ab
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/459264ef24cf2d409b8baf2047fa86e697d6e9ab
2017-05-24 11:39:53+10:00
hw/arm/virt: explicitly allocate cpu_index for cpus Currently cpu_index is implicitly auto assigned during cpu.realize() time cpu_exec_realizefn()->cpu_list_add(). It happens to match index in possible_cpus so take control over it and make board initialize cpu_index to possible_cpus index explicitly. It will at least document that board is in control of it and when '-device cpu' support comes it will keep cpu_index stable regardless of order cpus are created so it won't break migration. Within this series it will be used for internal conversion from storing cpu_index based NUMA node bitmaps to property based mapping with possible_cpus, And will allow map cpu_index to a CPU entry in possible_cpus array. Signed-off-by: Igor Mammedov <[email protected]> Reviewed-by: Andrew Jones <[email protected]> Message-Id: <[email protected]> Signed-off-by: Eduardo Habkost <[email protected]>
d9c34f9c6c745f6a8123a872b33990ab564c614a
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/d9c34f9c6c745f6a8123a872b33990ab564c614a
2017-05-11 16:08:48-03:00
hw/ppc/spapr_events.c: removing 'exception' from sPAPREventLogEntry Currenty we do not have any RTAS event that is reported by the event-scan interface. The existing events, RTAS_LOG_TYPE_EPOW and RTAS_LOG_TYPE_HOTPLUG, are being reported by the check-exception interface and, as such, marked as 'exception=true'. Commit 79853e18d9, 'spapr_events: event-scan RTAS interface', added the event_scan interface because the guest kernel requires it to initialize other required interfaces. It is acting since then as a stub because no events that would be reported by it were added since then. However, the existence of the 'exception' boolean adds an unnecessary load in the future migration of the pending_events, sPAPREventLogEntry QTAILQ that hosts the pending RTAS events. To make the code cleaner and ease the future migration changes, this patch makes the following changes: - remove the 'exception' boolean that filter these events. There is nothing to filter since all events are reported by check-exception; - functions rtas_event_log_queue, rtas_event_log_dequeue and rtas_event_log_contains don't receive the 'exception' boolean as parameter; - event_scan function was simplified. It was calling 'rtas_event_log_dequeue(mask, false)' that was always returning 'NULL' because we have no events that are created with exception=false, thus in the end it would execute a jump to 'out_no_events' all the time. The function now assumes that this will always be the case and all the remaining logic were deleted. In the future, when or if we add new RTAS events that should be reported with the event_scan interface, we can refer to the changes made in this patch to add the event_scan logic back. Signed-off-by: Daniel Henrique Barboza <[email protected]> Signed-off-by: David Gibson <[email protected]>
bff3063837a76b37a4bbbfe614324ca38e859f2b
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/bff3063837a76b37a4bbbfe614324ca38e859f2b
2017-05-24 11:39:53+10:00
tests: add alias check in /char/ringbuf Signed-off-by: Marc-André Lureau <[email protected]>
e24ef0db4fabfe1f64854cfd2a2b5aaddc90f379
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/e24ef0db4fabfe1f64854cfd2a2b5aaddc90f379
2017-05-04 15:34:42+04:00
hw/s390x/sclp: update LOADPARM in SCP Info LOADPARM has two copies: 1. in SCP Information Block 2. in IPL Information Parameter Block So, update SCLP intrinsics now. We always store LOADPARM in SCP information block even if we don't have a valid IPL Information Parameter Block. Initial patch from Eugene (jno) Dvurechenski. Signed-off-by: Eugene (jno) Dvurechenski <[email protected]> Signed-off-by: Farhan Ali <[email protected]> Reviewed-by: Christian Borntraeger <[email protected]> Signed-off-by: Cornelia Huck <[email protected]>
b038411d85b19e058d3909d97738a85c3f402db3
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/b038411d85b19e058d3909d97738a85c3f402db3
2017-05-02 15:08:54+02:00
target/ppc: Flush TLB on write to PIDR The PIDR (process id register) is used to store the id of the currently running process, which is used to select the process table entry used to perform address translation. This means that when we write to this register all the translations in the TLB become outdated as they are for a previously running process. Thus when this register is written to we need to invalidate the TLB entries to ensure stale entries aren't used to to perform translation for the new process, which would result in at best segfaults or alternatively just random memory being accessed. Signed-off-by: Suraj Jitindar Singh <[email protected]> Reviewed-by: David Gibson <[email protected]> [dwg: Fixed compile error for 32-bit targets] Signed-off-by: David Gibson <[email protected]>
31b2b0f8463533c32b5ad76e73668e2e9fca8ae2
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/31b2b0f8463533c32b5ad76e73668e2e9fca8ae2
2017-04-26 12:41:56+10:00
block: add bdrv_set_read_only() helper function We have a helper wrapper for checking for the BDS read_only flag, add a helper wrapper to set the read_only flag as well. Reviewed-by: Stefan Hajnoczi <[email protected]> Signed-off-by: Jeff Cody <[email protected]> Reviewed-by: John Snow <[email protected]> Message-id: 9b18972d05f5fa2ac16c014f0af98d680553048d.1491597120.git.jcody@redhat.com
fe5241bfe3fb61ec3f589ceacd91c1469bfd400f
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/fe5241bfe3fb61ec3f589ceacd91c1469bfd400f
2017-04-24 15:09:33-04:00
tests/qapi-schema: Systematic positive doc comment tests We have a number of negative tests, but we don't have systematic positive coverage. Fix that. Signed-off-by: Markus Armbruster <[email protected]> Message-Id: <[email protected]> Reviewed-by: Marc-André Lureau <[email protected]>
80d1f2e4a5df739842806610fb462753dde27b9a
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/80d1f2e4a5df739842806610fb462753dde27b9a
2017-03-21 10:42:55+01:00
qemu-img: show help for invalid global options The qemu-img sub-command executes regardless of invalid global options: $ qemu-img --foo info test.img qemu-img: unrecognized option '--foo' image: test.img ... The unrecognized option warning may be missed by the user. This can hide incorrect command-lines in scripts and confuse users. This patch prints the help information and terminates instead of executing the sub-command. Signed-off-by: Stefan Hajnoczi <[email protected]> Message-id: [email protected] Reviewed-by: Eric Blake <[email protected]> Signed-off-by: Max Reitz <[email protected]>
4581c16fce3c1078351f3424208f346b11b378f0
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/4581c16fce3c1078351f3424208f346b11b378f0
2017-03-27 16:50:36+02:00
xen: additionally restrict xenforeignmemory operations Commit f0f272baf3a7 "xen: use libxendevice model to restrict operations" added a command-line option (-xen-domid-restrict) to limit operations using the libxendevicemodel API to a specified domid. The commit also noted that the restriction would be extended to cover operations issued via other xen libraries by subsequent patches. My recent Xen patch [1] added a call to the xenforeignmemory API to allow it to be restricted. This patch now makes use of that new call when the -xen-domid-restrict option is passed. [1] http://xenbits.xen.org/gitweb/?p=xen.git;a=commit;h=5823d6eb Signed-off-by: Paul Durrant <[email protected]> Signed-off-by: Stefano Stabellini <[email protected]> Reviewed-by: Stefano Stabellini <[email protected]>
14d015b6fcd0b94a1e0983f82fab3e144143a314
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/14d015b6fcd0b94a1e0983f82fab3e144143a314
2017-04-21 12:40:14-07:00
ide: qdev: register ide bus unrealize function we have an idebus unrealize function, but it was being registered as the unrealize function for the IDE Device, so it was not getting invoked on device teardown because nothing is "unrealizing" the IDE devices themselves. Suggested-by: John Snow <[email protected]> Signed-off-by: Li Qiang <[email protected]> Reviewed-by: Philippe Mathieu-Daudé <[email protected]> Message-id: [email protected] Signed-off-by: John Snow <[email protected]>
44a109c1b38ddc9f853c33861875d0a85262de4f
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/44a109c1b38ddc9f853c33861875d0a85262de4f
2017-03-15 20:50:14-04:00
arm: Don't decode MRS(banked) or MSR(banked) for M profile M profile doesn't have the MSR(banked) and MRS(banked) instructions and uses the encodings for different kinds of M-profile MRS/MSR. Guard the relevant bits of the decode logic to make sure we don't accidentally fall into them by accident on M-profile. (The bit being checked for this (bit 5) is part of the SYSm field on M-profile, but since no currently allocated system registers have encodings with bit 5 of SYSm set, this hasn't been a problem in practice.) Signed-off-by: Peter Maydell <[email protected]> Reviewed-by: Alex Bennée <[email protected]> Message-id: [email protected]
43ac65742319ef5ac4461daf43316b189cd21e89
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/43ac65742319ef5ac4461daf43316b189cd21e89
2017-03-20 12:41:44+00:00
arm: Fix APSR writes via M profile MSR Our implementation of writes to the APSR for M-profile via the MSR instruction was badly broken. First and worst, we had the sense wrong on the test of bit 2 of the SYSm field -- this is supposed to request an APSR write if bit 2 is 0 but we were doing it if bit 2 was 1. This bug was introduced in commit 58117c9bb429cd, so hasn't been in a QEMU release. Secondly, the choice of exactly which parts of APSR should be written is defined by bits in the 'mask' field. We were not passing these through from instruction decode, making it impossible to check them in the helper. Pass the mask bits through from the instruction decode to the helper function and process them appropriately; fix the wrong sense of the SYSm bit 2 check. Invalid mask values and invalid combinations of mask and register number are UNPREDICTABLE; we choose to treat them as if the mask values were valid. Signed-off-by: Peter Maydell <[email protected]> Message-id: [email protected] Reviewed-by: Alex Bennée <[email protected]>
b28b3377d7e9ba35611d454d5a63ef50cab1f8c5
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/b28b3377d7e9ba35611d454d5a63ef50cab1f8c5
2017-03-20 12:41:44+00:00
PCI: add missing classes in pci_ids.h to build device tree To allow QEMU to add PCI entries in device tree, we must have a more exhaustive list of PCI class IDs. This patch synchronizes as much as possible with pci_ids.h and add some missing IDs from SLOF. Signed-off-by: Laurent Vivier <[email protected]> Reviewed-by: Michael S. Tsirkin <[email protected]> Reviewed-by: Thomas Huth <[email protected]> Signed-off-by: David Gibson <[email protected]>
089f7e827de44532f71c560efede395ed72a087c
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/089f7e827de44532f71c560efede395ed72a087c
2017-03-01 11:23:38+11:00
block: Fix pending requests check in bdrv_append() bdrv_append() cares about isolation of the node that it modifies, but not about activity in some subtree below it. Instead of using the recursive bdrv_requests_pending(), directly check bs->in_flight, which considers only the node in question. Signed-off-by: Kevin Wolf <[email protected]> Reviewed-by: Max Reitz <[email protected]> Acked-by: Fam Zheng <[email protected]>
dd65a52e4aa4a0adfedf0ed9a35da1960f359fe1
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/dd65a52e4aa4a0adfedf0ed9a35da1960f359fe1
2017-02-28 20:40:37+01:00
virtio: unbreak virtio-pci with IOMMU after caching ring translations Commit c611c76417f5 ("virtio: add MemoryListener to cache ring translations") registers a memory listener to dma_as. This may not work when IOMMU is enabled: dma_as(bus_master_as) were initialized in pcibus_machine_done() after virtio_realize(). This will cause a segfault. Fixing this by using pci_device_iommu_address_space() instead to make sure address space were initialized at this time. With this fix, IOMMU device were required to be initialized before any virtio-pci devices. Fixes: c611c76417f5 ("virtio: add MemoryListener to cache ring translations") Cc: Paolo Bonzini <[email protected]> Signed-off-by: Jason Wang <[email protected]> Reviewed-by: Michael S. Tsirkin <[email protected]> Signed-off-by: Michael S. Tsirkin <[email protected]>
96a8821d21411f10d77ea994af369c6e5c35a2cc
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/96a8821d21411f10d77ea994af369c6e5c35a2cc
2017-03-02 07:14:28+02:00
postcopy: Check for userfault+hugepage feature We need extra Linux kernel support (~4.11) to support userfaults on hugetlbfs; check for them. Signed-off-by: Dr. David Alan Gilbert <[email protected]> Reviewed-by: Juan Quintela <[email protected]> Reviewed-by: Laurent Vivier <[email protected]> Message-Id: <[email protected]> Signed-off-by: Dr. David Alan Gilbert <[email protected]>
7e8cafb7137502ce006cc48d0265f89399e0cb33
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/7e8cafb7137502ce006cc48d0265f89399e0cb33
2017-02-28 11:30:24+00:00
tests: Don't check qobject_type() before qobject_to_qint() qobject_to_qint(obj) returns NULL when obj isn't a QInt. Check that instead of qobject_type(obj) == QTYPE_QINT. Signed-off-by: Markus Armbruster <[email protected]> Message-Id: <[email protected]> Reviewed-by: Eric Blake <[email protected]>
0abfc4b885566eb41c3a4e1de5e2e105bdc062d9
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/0abfc4b885566eb41c3a4e1de5e2e105bdc062d9
2017-02-22 19:52:09+01:00
tests: Don't check qobject_type() before qobject_to_qfloat() qobject_to_qfloat(obj) returns NULL when obj isn't a QFloat. Check that instead of qobject_type(obj) == QTYPE_QFLOAT. Signed-off-by: Markus Armbruster <[email protected]> Message-Id: <[email protected]> Reviewed-by: Eric Blake <[email protected]>
8978b34af3250354e0b67340a7e920f909beda13
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/8978b34af3250354e0b67340a7e920f909beda13
2017-02-22 19:52:11+01:00
ppc: implement xssqrtqp instruction xssqrtqp: VSX Scalar Square Root Quad-Precision. Signed-off-by: Jose Ricardo Ziviani <[email protected]> Signed-off-by: David Gibson <[email protected]>
a4a68476def684f2f424a9ae1daed3de469da7cb
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/a4a68476def684f2f424a9ae1daed3de469da7cb
2017-02-22 11:28:27+11:00
cputlb: introduce tlb_flush_* async work. Some architectures allow to flush the tlb of other VCPUs. This is not a problem when we have only one thread for all VCPUs but it definitely needs to be an asynchronous work when we are in true multithreaded work. We take the tb_lock() when doing this to avoid racing with other threads which may be invalidating TB's at the same time. The alternative would be to use proper atomic primitives to clear the tlb entries en-mass. This patch doesn't do anything to protect other cputlb function being called in MTTCG mode making cross vCPU changes. Signed-off-by: KONRAD Frederic <[email protected]> [AJB: remove need for g_malloc on defer, make check fixes, tb_lock] Signed-off-by: Alex Bennée <[email protected]> Reviewed-by: Richard Henderson <[email protected]>
e3b9ca810980851f93f5719a7df2044c9435f003
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/e3b9ca810980851f93f5719a7df2044c9435f003
2017-02-24 10:32:46+00:00
virtio: check for vring setup in virtio_queue_update_used_idx If the vring has not been set up, it is not necessary for vring_used_idx to do anything (as is already the case when the caller is virtio_load). This is harmless for now, but it will be a problem when the MemoryRegionCache has not been set up. Signed-off-by: Paolo Bonzini <[email protected]> Reviewed-by: Philippe Mathieu-Daudé <[email protected]> Reviewed-by: Michael S. Tsirkin <[email protected]> Signed-off-by: Michael S. Tsirkin <[email protected]>
ca0176ad8368668c5ad2b428361652e05984e930
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/ca0176ad8368668c5ad2b428361652e05984e930
2017-02-17 21:52:30+02:00
cpu-exec: remove outermost infinite loop Reorganize the sigsetjmp so that the restart case falls through to cpu_handle_exception and the execution loop. Signed-off-by: Paolo Bonzini <[email protected]>
4515e58d60dc3aac53dbd5e53e4c3bec126967d8
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/4515e58d60dc3aac53dbd5e53e4c3bec126967d8
2017-02-16 14:06:56+01:00
vl: Move the cpu_synchronize_all_post_init() after generic devices initialization At the Qemu initialization, we call the cpu_synchronize_all_post_init() to synchronize All CPU states to KVM in the ./vl.c::main(). Currently, it is called before we initialize the CPUs, which is created by "-device" command and parsed by generic devices initialization, So, these CPUs may be ignored to synchronize. The patch moves the cpu_synchronize_all_post_init func after generic devices initialization to make sure that all the CPUs can be included. Signed-off-by: Dou Liyang <[email protected]> Message-Id: <[email protected]> Reviewed-by: Eduardo Habkost <[email protected]> Acked-by: Eduardo Habkost <[email protected]> Signed-off-by: Paolo Bonzini <[email protected]>
3741c2503bc06c7e3c5bd46a9d4e79a11bd7e7ed
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/3741c2503bc06c7e3c5bd46a9d4e79a11bd7e7ed
2017-02-16 15:30:49+01:00
vhost: skip ROM sections vhost does not support RO protections on memory at the moment - adding ROMs would mean that e.g. a buggy guest might change them in-memory - a condition from which guest reset does not recover. Not nice. We also definitely don't want to try logging writes into ROMs - in particular guests set very high addresses for ROM BARs so logging these writes would waste a lot of memory. Maybe ROMs could be supported with the iotlb variant - not sure, but there seems to be no good reason for virtio to try to do DMA from ROM. So let's just skip ROM memory. Suggested-by: Laurent Vivier <[email protected]> Signed-off-by: Michael S. Tsirkin <[email protected]> Reviewed-by: Laurent Vivier <[email protected]> Tested-by: Laurent Vivier <[email protected]>
d56ec1e98c0005933fe677d633484297f422691a
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/d56ec1e98c0005933fe677d633484297f422691a
2017-02-01 03:37:18+02:00
target-ppc: Fix xscmpodp and xscmpudp instructions - xscmpodp & xscmpudp are missing flags reset. - In xscmpodp, VXCC should be set only if VE is 0 for signalling NaN case and VXCC should be set by explicitly checking for quiet NaN case. - Comparison is being done only if the operands are not NaNs. However as per ISA, it should be done even when operands are NaNs. Signed-off-by: Bharata B Rao <[email protected]> Signed-off-by: Nikunj A Dadhania <[email protected]> Signed-off-by: David Gibson <[email protected]>
855f7a657e6061c241b5aa52c2a22cc94be4a63b
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/855f7a657e6061c241b5aa52c2a22cc94be4a63b
2017-01-31 10:10:12+11:00
rules: don't try to create missing include dirs In commit ba78db44f6532d66a1e704bd44613e841baa2fc5 Author: Daniel P. Berrange <[email protected]> Date: Wed Jan 25 16:14:10 2017 +0000 make: move top level dir to end of include search path The dir $(BUILD_DIR)/$(@D) was added to the include path. This would sometimes point to a non-existant directory, if the sub-dir in question did not contain any target-independant files (eg tcg/). To deal with this the rules.mak attempted to create the directory. While this was succesful, it also caused accidental creation of files in the parent of the build dir. e.g. when building common source files into target specific output files. Rather than trying to workaround this, just revert the code that attempted to mkdir the missing include directories. Instead just turn off the compiler warning in question as the missing dir is expected & harmless in general. NB: you can clean up a build directory parent that has been filled with empty directories by commit ba78db44f653 using this GNU find command in that parent directory: find audio backends block chardev crypto disas fsdev hw io linux-user \ migration nbd net qapi qom replay slirp target ui util \ -type d -empty -delete Signed-off-by: Daniel P. Berrange <[email protected]> Tested-by: Alberto Garcia <[email protected]> [PMM: added note about how to clean up a polluted directory] Signed-off-by: Peter Maydell <[email protected]>
ac7568bd3ff381e1e0624ac2c07954f01aa45aad
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/ac7568bd3ff381e1e0624ac2c07954f01aa45aad
2017-02-07 11:52:34+00:00
replay: improve interrupt handling This patch improves interrupt handling in record/replay mode. Now "interrupt" event is saved only when cc->cpu_exec_interrupt returns true. This patch also adds missing return to cpu_exec_interrupt function. Signed-off-by: Pavel Dovgalyuk <[email protected]> Message-Id: <20170124071708.4572.64023.stgit@PASHA-ISP> Signed-off-by: Paolo Bonzini <[email protected]>
d718b14b8cc2a28dcf48b68c87f16a36d280c36e
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/d718b14b8cc2a28dcf48b68c87f16a36d280c36e
2017-01-27 18:07:30+01:00
block: get max_transfer limit for char (scsi-generic) devices We can get the maximum number of bytes for a single I/O transfer from the BLKSECTGET ioctl, but we only perform this for block devices. scsi-generic devices are represented as character devices, and so do not issue this today. Update this, so that virtio-scsi devices using the scsi-generic interface can return the same data. Signed-off-by: Eric Farman <[email protected]> Message-Id: <[email protected]> Reviewed-by: Fam Zheng <[email protected]> Signed-off-by: Paolo Bonzini <[email protected]>
c4c41a0a65d650b241dec9efedf4ee3f00a16a30
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/c4c41a0a65d650b241dec9efedf4ee3f00a16a30
2017-01-27 18:07:31+01:00
target-hppa: Add softfloat specializations Like the original MIPS, HPPA has the MSB of an SNaN set. However, it has different rules for silencing an SNaN: (1) msb is cleared and (2) msb-1 must be set if the fraction is now zero, and (implementation defined) may be set always. I haven't checked real hardware but chose the set always alternative because it's easy and within spec. Signed-off-by: Richard Henderson <[email protected]>
005fa38d86257d471ac461c066a5409a9f5ebb02
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/005fa38d86257d471ac461c066a5409a9f5ebb02
2017-01-23 09:52:40-08:00
linux-user: Add HPPA startup and main loop Including support for the atomic memory op syscalls. Signed-off-by: Richard Henderson <[email protected]>
7c248bcda1d1b3081b1bdb3a10352bb549dff2c5
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/7c248bcda1d1b3081b1bdb3a10352bb549dff2c5
2017-01-23 09:52:40-08:00
virtio-crypto-pci: add check for cryptodev object We must assure each virtio crypto pci device has an vaild cryptodev backend object. Signed-off-by: Gonglei <[email protected]> Reviewed-by: Michael S. Tsirkin <[email protected]> Signed-off-by: Michael S. Tsirkin <[email protected]>
305f5131ac30b4a03e698bae0976f4cd24bb0a86
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/305f5131ac30b4a03e698bae0976f4cd24bb0a86
2017-01-10 07:02:52+02:00
s390x/pci: PCI multibus bridge handling When the hotplug handler detects a PCI bridge, the secondary bus has been initialized by the core PCI code. We give the secondary bus the bridge name and associate to it the IOMMU handling and hotplug/hotunplug callbacks. Signed-off-by: Pierre Morel <[email protected]> Signed-off-by: Cornelia Huck <[email protected]>
3fc92a24f333b48652a2373c296f641c04b08bae
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/3fc92a24f333b48652a2373c296f641c04b08bae
2017-01-20 10:02:02+01:00
net: mcf: check receive buffer size register value ColdFire Fast Ethernet Controller uses a receive buffer size register(EMRBR) to hold maximum size of all receive buffers. It is set by a user before any operation. If it was set to be zero, ColdFire emulator would go into an infinite loop while receiving data in mcf_fec_receive. Add check to avoid it. Reported-by: Wjjzhang <[email protected]> Signed-off-by: Prasad J Pandit <[email protected]> Signed-off-by: Jason Wang <[email protected]>
77d54985b85a0cb760330ec2bd92505e0a2a97a9
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/77d54985b85a0cb760330ec2bd92505e0a2a97a9
2016-12-05 17:45:14+08:00
virtio: convert to use DMA api Currently, all virtio devices bypass IOMMU completely. This is because address_space_memory is assumed and used during DMA emulation. This patch converts the virtio core API to use DMA API. This idea is - introducing a new transport specific helper to query the dma address space. (only pci version is implemented). - query and use this address space during virtio device guest memory accessing when iommu platform (VIRTIO_F_IOMMU_PLATFORM) was enabled for this device. Cc: Michael S. Tsirkin <[email protected]> Cc: Stefan Hajnoczi <[email protected]> Cc: Kevin Wolf <[email protected]> Cc: Amit Shah <[email protected]> Cc: Paolo Bonzini <[email protected]> Cc: [email protected] Signed-off-by: Jason Wang <[email protected]> Reviewed-by: Michael S. Tsirkin <[email protected]> Signed-off-by: Michael S. Tsirkin <[email protected]>
8607f5c3072caeebbe0217df28651fffd3a79fd9
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/8607f5c3072caeebbe0217df28651fffd3a79fd9
2017-01-10 05:56:58+02:00
acpi nvdimm: fix ARG3 conflict As ARG3 is a reserved name, we rename it to FARG Suggested-by: Igor Mammedov <[email protected]> Signed-off-by: Xiao Guangrong <[email protected]> Reviewed-by: Michael S. Tsirkin <[email protected]> Signed-off-by: Michael S. Tsirkin <[email protected]>
dba00936ea26e2b103ade4ac0f8a31aa6c410b6f
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/dba00936ea26e2b103ade4ac0f8a31aa6c410b6f
2016-11-01 19:21:08+02:00
ui/gtk: Fix build with older versions of gtk GDK_KEY_Delete is only defined with gtk version 2.22 and newer, on older versions this key was called GDK_Delete instead. Since this is the case for all GDK_KEY_* defines, change the already existing preprocessor check there to test for version 2.22, so we know that we can remove this code block in case we require that version as a minimum one day. Signed-off-by: Thomas Huth <[email protected]> Reviewed-by: Daniel P. Berrange <[email protected]> Message-id: [email protected] Signed-off-by: Gerd Hoffmann <[email protected]>
204af15b04a448aa6e954e37613ac43467fd76c4
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/204af15b04a448aa6e954e37613ac43467fd76c4
2016-11-10 15:29:58+00:00
qcow2: Don't strand clusters near 2G intervals during commit The qcow2_make_empty() function is reached during 'qemu-img commit', in order to clear out ALL clusters of an image. However, if the image cannot use the fast code path (true if the image is format 0.10, or if the image contains a snapshot), the cluster size is larger than 512, and the image is larger than 2G in size, then our choice of sector_step causes problems. Since it is not cluster aligned, but qcow2_discard_clusters() silently ignores an unaligned head or tail, we are leaving clusters allocated. Enhance the testsuite to expose the flaw, and patch the problem by ensuring our step size is aligned. Signed-off-by: Eric Blake <[email protected]> Reviewed-by: John Snow <[email protected]> Reviewed-by: Stefan Hajnoczi <[email protected]> Signed-off-by: Kevin Wolf <[email protected]>
a3e1505daec31ef56f0489f8c8fff1b8e4ca92bd
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/a3e1505daec31ef56f0489f8c8fff1b8e4ca92bd
2016-12-06 15:37:02+01:00
qemu-iotests: Add iotests.supports_quorum() There's many tests that need Quorum support in order to run. At the moment each test implements its own check to see if Quorum is enabled. This patch centralizes all those checks in a new function called iotests.supports_quorum(). Signed-off-by: Alberto Garcia <[email protected]> Reviewed-by: Kevin Wolf <[email protected]> Signed-off-by: Kevin Wolf <[email protected]>
b0f904950c84c8de24ed0be75d5d48e2f7ff1e73
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/b0f904950c84c8de24ed0be75d5d48e2f7ff1e73
2016-10-31 16:52:39+01:00
migration: Enter into COLO mode after migration if COLO is enabled Add a new migration state: MIGRATION_STATUS_COLO. Migration source side enters this state after the first live migration successfully finished if COLO is enabled by command 'migrate_set_capability x-colo on'. We reuse migration thread, so the process of checkpointing will be handled in migration thread. Signed-off-by: zhanghailiang <[email protected]> Signed-off-by: Li Zhijian <[email protected]> Signed-off-by: Gonglei <[email protected]> Reviewed-by: Dr. David Alan Gilbert <[email protected]> Reviewed-by: Amit Shah <[email protected]> Signed-off-by: Amit Shah <[email protected]>
0b827d5e7291193887d22d058bc20c12b423047c
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/0b827d5e7291193887d22d058bc20c12b423047c
2016-10-30 15:17:39+05:30
iotests: Remove raciness from 162 With qemu-nbd's new --fork option, we no longer need to launch it the hacky way. Suggested-by: Sascha Silbe <[email protected]> Signed-off-by: Max Reitz <[email protected]> Signed-off-by: Kevin Wolf <[email protected]>
668b4406314828c8b22ffe5951c3014380d778f1
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/668b4406314828c8b22ffe5951c3014380d778f1
2016-10-24 17:54:03+02:00
tests: add atomic_add-bench With this microbenchmark we can measure the overhead of emulating atomic instructions with a configurable degree of contention. The benchmark spawns $n threads, each performing $o atomic ops (additions) in a loop. Each atomic operation is performed on a different cache line (assuming lines are 64b long) that is randomly selected from a range [0, $r). [ Note: each $foo corresponds to a -foo flag ] Signed-off-by: Emilio G. Cota <[email protected]> Signed-off-by: Richard Henderson <[email protected]> Message-Id: <[email protected]>
070e3edceaa023109bfa7a1c5c259342e0b6b625
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/070e3edceaa023109bfa7a1c5c259342e0b6b625
2016-10-26 08:29:01-07:00
acpi: cphp: Force switch to modern cpu hotplug if APIC ID > 254 Switch to modern cpu hotplug at machine startup time if a cpu present at boot has apic-id in range unsupported by legacy cpu hotplug interface (i.e. > 254), to avoid killing QEMU from legacy cpu hotplug code with error: "acpi: invalid cpu id: #apic-id#" Signed-off-by: Igor Mammedov <[email protected]> Reviewed-by: Eduardo Habkost <[email protected]> Signed-off-by: Eduardo Habkost <[email protected]>
f9dc175d84802e9a00161bc8d4356b90d6c52125
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/f9dc175d84802e9a00161bc8d4356b90d6c52125
2016-10-24 17:29:14-02:00
qtest: fix make check complaint in crypto module CC tests/test-crypto-tlscredsx509.o CC tests/crypto-tls-x509-helpers.o CC tests/pkix_asn1_tab.o tests/pkix_asn1_tab.c:7:22: warning: libtasn1.h: No such file or directory tests/pkix_asn1_tab.c:9: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘pkix_asn1_tab’ make: *** [tests/pkix_asn1_tab.o] Error 1 Signed-off-by: Gonglei <[email protected]> Signed-off-by: Daniel P. Berrange <[email protected]>
48b95ea4f0933c13d778c0478cb82bbfdd515981
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/48b95ea4f0933c13d778c0478cb82bbfdd515981
2016-10-19 10:09:24+01:00
qmp: Disable query-cpu-* commands when they're unavailable Instead of requiring clients to actually call the query-cpu-* commands to find out if they are implemented, remove them from the output of "query-commands", so clients know they are not available. This is implemented by extending the existing hack at qmp_unregister_commands_hack(). I wish I could avoid adding even more #ifdefs to that code, but that's the solution we have today. Signed-off-by: Eduardo Habkost <[email protected]> Message-Id: <[email protected]> Reviewed-by: Eric Blake <[email protected]> Reviewed-by: Markus Armbruster <[email protected]> Signed-off-by: Markus Armbruster <[email protected]>
728b1429b16ebcc09ca7936d8689db9e006acbef
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/728b1429b16ebcc09ca7936d8689db9e006acbef
2016-10-07 19:22:11+02:00
target-i386: xsave: Simplify CPUID[0xD,0].{EAX,EDX} calculation Instead of assigning individual bits in a loop, just copy the values from ena_mask. Reviewed-by: Richard Henderson <[email protected]> Signed-off-by: Eduardo Habkost <[email protected]>
8057c621b1b17cbcb35fe67d1a09ada9055873a9
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/8057c621b1b17cbcb35fe67d1a09ada9055873a9
2016-09-27 16:17:17-03:00
virtio-9p: add reset handler Virtio devices should implement the VirtIODevice->reset() function to perform necessary cleanup actions and to bring the device to a quiescent state. In the case of the virtio-9p device, this means: - emptying the list of active PDUs (i.e. draining all in-flight I/O) - freeing all fids (i.e. close open file descriptors and free memory) That's what this patch does. The reset handler first waits for all active PDUs to complete. Since completion happens in the QEMU global aio context, we just have to loop around aio_poll() until the active list is empty. The freeing part involves some actions to be performed on the backend, like closing file descriptors or flushing extended attributes to the underlying filesystem. The virtfs_reset() function already does the job: it calls free_fid() for all open fids not involved in an ongoing I/O operation. We are sure this is the case since we have drained the PDU active list. The current code implements all backend accesses with coroutines, but we want to stay synchronous on the reset path. We can either change the current code to be able to run when not in coroutine context, or create a coroutine context and wait for virtfs_reset() to complete. This patch goes for the latter because it results in simpler code. Note that we also need to create a dummy PDU because it is also an API to pass the FsContext pointer to all backend callbacks. Signed-off-by: Greg Kurz <[email protected]> Reviewed-by: Michael S. Tsirkin <[email protected]> Reviewed-by: Stefan Hajnoczi <[email protected]>
0e44a0fd3f28cccb8963fdfc05c53c546b3f46b6
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/0e44a0fd3f28cccb8963fdfc05c53c546b3f46b6
2016-10-17 14:13:58+02:00
cpus-common: move exclusive work infrastructure from linux-user This will serve as the base for async_safe_run_on_cpu. Because start_exclusive uses CPU_FOREACH, merge exclusive_lock with qemu_cpu_list_lock: together with a call to exclusive_idle (via cpu_exec_start/end) in cpu_list_add, this protects exclusive work against concurrent CPU addition and removal. Reviewed-by: Alex Bennée <[email protected]> Reviewed-by: Richard Henderson <[email protected]> Signed-off-by: Paolo Bonzini <[email protected]>
ab129972c8b41e15b0521895a46fd9c752b68a5e
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/ab129972c8b41e15b0521895a46fd9c752b68a5e
2016-09-27 11:57:30+02:00
adb.c: prevent NO_KEY value from going to guest The NO_KEY value should not be sent to the guest. This patch drops that value. Signed-off-by: John Arbuckle <[email protected]> Signed-off-by: David Gibson <[email protected]>
f366e729f9231e7176e96dba16ddfb6b4b3ab1a8
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/f366e729f9231e7176e96dba16ddfb6b4b3ab1a8
2016-09-23 10:29:40+10:00
tests: virtio-9p: add basic configuration test This adds PCI init code and a basic test that checks the device config matches what is passed on the command line. Signed-off-by: Greg Kurz <[email protected]> Acked-by: Cornelia Huck <[email protected]>
557a4cc04a7cd092e8b5d6ef5a1e6799ed10b163
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/557a4cc04a7cd092e8b5d6ef5a1e6799ed10b163
2016-09-16 12:15:56+02:00
crypto: clear out buffer after timing pbkdf algorithm The 'out' buffer will hold a key derived from master password, so it is best practice to clear this buffer when no longer required. At this time, the code isn't worrying about locking buffers into RAM to prevent swapping sensitive data to disk. Reviewed-by: Eric Blake <[email protected]> Signed-off-by: Daniel P. Berrange <[email protected]>
8813800b7d995d8b54ef0a1e16d41fc13d8b5f3a
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/8813800b7d995d8b54ef0a1e16d41fc13d8b5f3a
2016-09-19 16:30:45+01:00
vmsvga: correct bitmap and pixmap size checks When processing svga command DEFINE_CURSOR in vmsvga_fifo_run, the computed BITMAP and PIXMAP size are checked against the 'cursor.mask[]' and 'cursor.image[]' array sizes in bytes. Correct these checks to avoid OOB memory access. Reported-by: Qinghao Tang <[email protected]> Reported-by: Li Qiang <[email protected]> Signed-off-by: Prasad J Pandit <[email protected]> Message-id: [email protected] Signed-off-by: Gerd Hoffmann <[email protected]>
167d97a3def77ee2dbf6e908b0ecbfe2103977db
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/167d97a3def77ee2dbf6e908b0ecbfe2103977db
2016-09-13 09:24:35+02:00
checkpatch: check for CVS keywords on all sources These should apply to all files, not just C/C++. Tweak the regular expression to check for whole words, to avoid false positives on Perl variables starting with "Id". Signed-off-by: Paolo Bonzini <[email protected]>
93eb8e31f38b3eb612e522c62e8932d7fd576ff9
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/93eb8e31f38b3eb612e522c62e8932d7fd576ff9
2016-08-10 11:10:03+02:00
scsi: mptsas: use g_new0 to allocate MPTSASRequest object When processing IO request in mptsas, it uses g_new to allocate a 'req' object. If an error occurs before 'req->sreq' is allocated, It could lead to an OOB write in mptsas_free_request function. Use g_new0 to avoid it. Reported-by: Li Qiang <[email protected]> Signed-off-by: Prasad J Pandit <[email protected]> Message-Id: <[email protected]> Cc: [email protected] Signed-off-by: Paolo Bonzini <[email protected]>
670e56d3ed2918b3861d9216f2c0540d9e9ae0d5
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/670e56d3ed2918b3861d9216f2c0540d9e9ae0d5
2016-09-14 12:25:13+02:00
docker: Don't start a container that doesn't exist Image building targets are dependencies of test running targets, so when a docker image doesn't exist, it means it's skipped (due to dependency checks in pre script). Therefore, skip the test too. Signed-off-by: Fam Zheng <[email protected]> Message-id: [email protected]
ff31e2256d7c984d3c4aa06f38ecd54c5138549d
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/ff31e2256d7c984d3c4aa06f38ecd54c5138549d
2016-07-20 19:19:43+08:00
libdecnumber: Don't fool around with guards to avoid #include Some libdecnumber headers avoid including decNumber.h or decContext.h again by checking their header guards. Don't. Including them multiple times is safe, and the compiler can do it efficiently. Signed-off-by: Markus Armbruster <[email protected]> Reviewed-by: Richard Henderson <[email protected]>
6031a51f1dab45bc6d5f8db1825e8f4f7915a870
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/6031a51f1dab45bc6d5f8db1825e8f4f7915a870
2016-07-12 16:19:16+02:00
qemu-iotests: Test naming of throttling groups Throttling groups are named using the 'group' parameter of the block_set_io_throttle command and the throttling.group command-line option. If that parameter is unspecified the groups get the name of the block device. This patch adds a new test to check the naming of throttling groups. Signed-off-by: Alberto Garcia <[email protected]> Message-id: d87d02823a6b91609509d8bb18e2f5dbd9a6102c.1467986342.git.berto@igalia.com Reviewed-by: Max Reitz <[email protected]> Signed-off-by: Max Reitz <[email protected]>
435d5ee6cd3fd7aa0f16748c03648ed97b493c2b
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/435d5ee6cd3fd7aa0f16748c03648ed97b493c2b
2016-07-13 13:41:39+02:00
linux-user: Correct type for LOOP_GET_STATUS{,64} ioctls The LOOP_GET_STATUS and LOOP_GET_STATUS64 ioctls were incorrectly defined as IOC_W rather than IOC_R, which meant we weren't correctly copying the information back from the kernel to the guest. The loop_info64 structure definition was also missing a member and using the wrong type for several 32-bit fields. In particular, this meant that "kpartx -d image.img" didn't work and "losetup -a" behaved strangely. Correct the ioctl type definitions. Reported-by: Chanho Park <[email protected]> Reviewed-by: Laurent Vivier <[email protected]> Signed-off-by: Peter Maydell <[email protected]> Signed-off-by: Riku Voipio <[email protected]>
f2c2fb50be13aca9c449d9156817c915d9cd2acb
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/f2c2fb50be13aca9c449d9156817c915d9cd2acb
2016-07-19 15:23:16+03:00
linux-user: Clean up target_signal.h header guards These headers all use TARGET_SIGNAL_H as header guard symbol. Reuse of the same guard symbol in multiple headers is okay as long as they cannot be included together. Since we can avoid guard symbol reuse easily, do so: use guard symbol $target_TARGET_SIGNAL_H for linux-user/$target/target_signal.h. Signed-off-by: Markus Armbruster <[email protected]> Reviewed-by: Richard Henderson <[email protected]>
9c93ae13a4014055c5c78e81078e5ccdc60c1cfa
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/9c93ae13a4014055c5c78e81078e5ccdc60c1cfa
2016-07-12 16:19:16+02:00
Update OpenBIOS images to SVN revision 218. Changes: r186: Revert broken r161, fix identification string printing (Igor Kovalenko) r187: Fix NetBSD reset problem r188: Add a TODO for Sparc r189: Fix some Sparc32 compile warnings r190: Fix some Sparc64 compile warnings r191: Add prototypes for [v]snprintf r192: Add a common header file for libgcc functions r193: Implement obmem for NetBSD loader r194: Add Make dependencies for some files, unify Sparc32/64 build.xml files r195: Remove debug messages r196: Add a.out support for SILO r198: Add a CPU node r199: Add (bogus) memory nodes r200: Add idprom node r201: Make serial console usable r202: Add MMU node and ops r203: Add trap table setting function to client interface r204: Fix MMU translation r205: Handle 32 bit windows, remove now unused files r206: Support for simple boot device selection r207: Fix TLB entry generation r208: Fix printing of exception messages r209: Set up tick_cmpr, update assembly flags r210: Add a clock-frequency node r211: Fix available and total memory Implement a static list of mmu translations Map more pages Add a fake unmap method r212: Fix builtin.c dependencies r213: Add FCode boot loader for Solaris etc. r214: Add correct reset vectors r215: Add T1 and T2 CPUs r216: Fix wrong translations r217: Add bootargs property for kernel command line r218: Finally fix the very obscure problem which prevented normal and especially FCode boot: too small heap (used for Forth memory)! Remove forced arch_init and boot hacks git-svn-id: svn://svn.savannah.nongnu.org/qemu/trunk@4983 c046a42c-6fe2-441c-8c8c-71466251a162
60e26a9167ab3bca18f4204616ad30082a6ea389
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/60e26a9167ab3bca18f4204616ad30082a6ea389
2008-08-02 11:18:40+00:00
pc: Parse CPU features only once Considering that features are converted to global properties and global properties are automatically applied to every new instance of created CPU (at object_new() time), there is no point in parsing cpu_model string every time a CPU created. So move parsing outside CPU creation loop and do it only once. Parsing also should be done before any CPU is created so that features would affect the first CPU a well. Signed-off-by: Igor Mammedov <[email protected]> Signed-off-by: Eduardo Habkost <[email protected]>
6aff24c6a61c6fec31e555c7748ba6085b7b2c06
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/6aff24c6a61c6fec31e555c7748ba6085b7b2c06
2016-07-07 15:25:06-03:00
s390x/pci: introduce S390PCIIOMMU Currently each zpci device holds its own DMA address space and memory region. At the same time, all instances of zpci device are stored in S390pciState. So duirng the initialization of S390pciState, all zpci devices are created and then all DMA address spaces are created. Thus, when initializing pci devices, their corresponding DMA address spaces could be found. But zpci qdev will be introduced later. Zpci device may be initialized and plugged afterwards generic pci device. So we should initialize all DMA address spaces and memory regions before initializing zpci devices. We introduce a new struct named S390PCIIOMMU. And a new field of S390pciState, which is an array to store all instances of S390PCIIOMMU, is added so that qemu pci code could find the corresponding DMA address space when initializing a generic pci device. And this should be done before the connection of a zpci device and a generic pci device is built. Signed-off-by: Yi Min Zhao <[email protected]> Acked-by: Pierre Morel <[email protected]> Signed-off-by: Cornelia Huck <[email protected]>
67d5cd9722b230027d3d4267ae6069c5d8a65463
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/67d5cd9722b230027d3d4267ae6069c5d8a65463
2016-07-11 09:48:05+02:00
qxl: fix surface migration Create a helper function qxl_dirty_one_surface() to mark a single qxl surface as dirty. Use the new qxl_get_check_slot_offset function and lookup the memory region from the slot instead of assuming the surface is stored in vram. Use the new helper function in qxl_dirty_surfaces, for both primary and off-screen surfaces. For off-screen surfaces this is no functional change. For primary surfaces this will dirty only the memory actually used instead of the whole surface0 region. It will also work correctly in case the guest places the primary surface in vram instead of the surface0 region (linux kms driver does that). https://bugzilla.redhat.com/show_bug.cgi?id=1235732 Signed-off-by: Gerd Hoffmann <[email protected]> Message-id: [email protected]
1331eab216c9dc4e50a48a34d14926b31a7fd611
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/1331eab216c9dc4e50a48a34d14926b31a7fd611
2016-07-06 10:31:11+02:00
iscsi: Set request_alignment during .bdrv_refresh_limits() We want to eventually stick request_alignment alongside other BlockLimits, but first, we must ensure it is populated at the same time as all other limits, rather than being a special case that is set only when a block is first opened. Signed-off-by: Eric Blake <[email protected]> Reviewed-by: Kevin Wolf <[email protected]> Reviewed-by: Fam Zheng <[email protected]> Signed-off-by: Kevin Wolf <[email protected]>
c8b3b998e2bb61e511591f126be9d362d80d705d
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/c8b3b998e2bb61e511591f126be9d362d80d705d
2016-07-05 16:46:25+02:00
block: Switch discard length bounds to byte-based Sector-based limits are awkward to think about; in our on-going quest to move to byte-based interfaces, convert max_discard and discard_alignment. Rename them, using 'pdiscard' as an aid to track which remaining discard interfaces need conversion, and so that the compiler will help us catch the change in semantics across any rebased code. The BlockLimits type is now completely byte-based; and in iscsi.c, sector_limits_lun2qemu() is no longer needed. pdiscard_alignment is made unsigned (we use power-of-2 alignments as bitmasks, where unsigned is easier to think about) while leaving max_pdiscard signed (since we still have an 'int' interface); this is comparable to what commit cf081fc did for write zeroes limits. We may later want to make everything an unsigned 64-bit limit - but that requires a bigger code audit. Signed-off-by: Eric Blake <[email protected]> Reviewed-by: Fam Zheng <[email protected]> Signed-off-by: Kevin Wolf <[email protected]>
b9f7855a50a7cbf04454fa84e9d1f333151f2259
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/b9f7855a50a7cbf04454fa84e9d1f333151f2259
2016-07-05 16:46:25+02:00
pckbd: handle A20 IRQ as GPIO The i8042 device has outgouing IRQ line A20. Currently the IRQ is referenced by a pointer which normally is set during machine initialization. The pointer is never changed at runtime. So common GPIO model can be applied to A20 IRQ line. Note that checking for IRQ to be connected as in previous version of code is not required because qemu_set_irq will do it. Signed-off-by: Efimov Vasily <[email protected]> Signed-off-by: Paolo Bonzini <[email protected]>
3115b9e2d286188a54d6f415186ae556046b68a3
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/3115b9e2d286188a54d6f415186ae556046b68a3
2016-06-29 14:03:46+02:00
acpi: add aml_call5 It will be used by NVDIMM ACPI Signed-off-by: Xiao Guangrong <[email protected]> Reviewed-by: Stefan Hajnoczi <[email protected]> Reviewed-by: Michael S. Tsirkin <[email protected]> Signed-off-by: Michael S. Tsirkin <[email protected]>
052889b8e96d24625043cd5901ab91dd38aca49f
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/052889b8e96d24625043cd5901ab91dd38aca49f
2016-06-24 05:13:57+03:00
ICH9 LPC: move call of isa_bus_irqs to 'realize' method The isa_bus_irqs function initializes ISA bus IRQ array pointer with specified value. Previously the ICH9 LPC bridge model did not have its own IRQs but only IRQ pointer cache. And same GSI were used for ISA bus and other sources behind the bridge (PCI, SCI). Hence, the pc_q35_init was only possible place to setup both ISA bus IRQs and the bridge IRQ cache. As a result, the call of isa_bus_irqs was made from pc_q35_init. Now the ICH9 LPC bridge has its own output IRQs which are connected to GSI. The output IRQs are already used to route IRQs from PCI and SCI. The patch makes the ICH9 LPC bridge output IRQs to used for ISA bus too. Signed-off-by: Efimov Vasily <[email protected]> Signed-off-by: Paolo Bonzini <[email protected]>
ea5d42508c16947e84d020751e739c59262051de
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/ea5d42508c16947e84d020751e739c59262051de
2016-06-29 14:03:46+02:00
qapi: Add new visit_complete() function Making each output visitor provide its own output collection function was the only remaining reason for exposing visitor sub-types to the rest of the code base. Add a polymorphic visit_complete() function which is a no-op for input visitors, and which populates an opaque pointer for output visitors. For maximum type-safety, also add a parameter to the output visitor constructors with a type-correct version of the output pointer, and assert that the two uses match. This approach was considered superior to either passing the output parameter only during construction (action at a distance during visit_free() feels awkward) or only during visit_complete() (defeating type safety makes it easier to use incorrectly). Most callers were function-local, and therefore a mechanical conversion; the testsuite was a bit trickier, but the previous cleanup patch minimized the churn here. The visit_complete() function may be called at most once; doing so lets us use transfer semantics rather than duplication or ref-count semantics to get the just-built output back to the caller, even though it means our behavior is not idempotent. Generated code is simplified as follows for events: |@@ -26,7 +26,7 @@ void qapi_event_send_acpi_device_ost(ACP | QDict *qmp; | Error *err = NULL; | QMPEventFuncEmit emit; |- QmpOutputVisitor *qov; |+ QObject *obj; | Visitor *v; | q_obj_ACPI_DEVICE_OST_arg param = { | info |@@ -39,8 +39,7 @@ void qapi_event_send_acpi_device_ost(ACP | | qmp = qmp_event_build_dict("ACPI_DEVICE_OST"); | |- qov = qmp_output_visitor_new(); |- v = qmp_output_get_visitor(qov); |+ v = qmp_output_visitor_new(&obj); | | visit_start_struct(v, "ACPI_DEVICE_OST", NULL, 0, &err); | if (err) { |@@ -55,7 +54,8 @@ void qapi_event_send_acpi_device_ost(ACP | goto out; | } | |- qdict_put_obj(qmp, "data", qmp_output_get_qobject(qov)); |+ visit_complete(v, &obj); |+ qdict_put_obj(qmp, "data", obj); | emit(QAPI_EVENT_ACPI_DEVICE_OST, qmp, &err); and for commands: | { | Error *err = NULL; |- QmpOutputVisitor *qov = qmp_output_visitor_new(); | Visitor *v; | |- v = qmp_output_get_visitor(qov); |+ v = qmp_output_visitor_new(ret_out); | visit_type_AddfdInfo(v, "unused", &ret_in, &err); |- if (err) { |- goto out; |+ if (!err) { |+ visit_complete(v, ret_out); | } |- *ret_out = qmp_output_get_qobject(qov); |- |-out: | error_propagate(errp, err); Signed-off-by: Eric Blake <[email protected]> Message-Id: <[email protected]> Reviewed-by: Markus Armbruster <[email protected]> Signed-off-by: Markus Armbruster <[email protected]>
3b098d56979d2f7fd707c5be85555d114353a28d
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/3b098d56979d2f7fd707c5be85555d114353a28d
2016-07-06 10:52:04+02:00
spapr: convert boot CPUs into CPU core devices Introduce sPAPRMachineClass.dr_cpu_enabled to indicate support for CPU core hotplug. Initialize boot time CPUs as core deivces and prevent topologies that result in partially filled cores. Both of these are done only if CPU core hotplug is supported. Note: An unrelated change in the call to xics_system_init() is done in this patch as it makes sense to use the local variable smt introduced in this patch instead of kvmppc_smt_threads() call here. TODO: We derive sPAPR core type by looking at -cpu <model>. However we don't take care of "compat=" feature yet for boot time as well as hotplug CPUs. Signed-off-by: Bharata B Rao <[email protected]> Reviewed-by: David Gibson <[email protected]> Signed-off-by: David Gibson <[email protected]>
94a94e4c49197d10e5ee7710bb0538ddeff75ba9
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/94a94e4c49197d10e5ee7710bb0538ddeff75ba9
2016-06-17 16:33:49+10:00
raw-posix: Switch to bdrv_co_* interfaces In order to use the modern byte-based .bdrv_co_preadv/pwritev() interface, this patch switches raw-posix to coroutine-based interfaces as a first step. In terms of semantics and performance, it doesn't make a difference with the existing code whether we go from a coroutine to a callback-based interface already in block/io.c or only in linux-aio.c As there have been concerns in the past that this change may be a step in the wrong direction with respect to a possible AIO fast path, the old callback-based interface for linux-aio is left around and can be reactivated when a fast path (e.g. directly from virtio-blk dataplane, bypassing the whole block layer) is implemented. Signed-off-by: Kevin Wolf <[email protected]> Reviewed-by: Eric Blake <[email protected]> Reviewed-by: Stefan Hajnoczi <[email protected]>
2174f12bdeb3974141784e14bbb7ad8c53178cd9
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/2174f12bdeb3974141784e14bbb7ad8c53178cd9
2016-06-16 15:19:55+02:00
throttle: refuse iops-size without iops-total/read/write In a similar vein to commit ee2bdc33c913b7d765baa5aa338c29fb30a05c9a ("throttle: refuse bps_max/iops_max without bps/iops") it is likely that the user made a configuration error if iops-size has been set but no iops limit has been set. Print an error message so the user can check their throttling configuration. They should either remove iops-size if they don't want any throttling or specify one of iops-total, iops-read, or iops-write. Signed-off-by: Stefan Hajnoczi <[email protected]> Reviewed-by: Alberto Garcia <[email protected]> Message-id: [email protected]
8860eabdee32f78d9a34273a340b8f74476bc9a0
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/8860eabdee32f78d9a34273a340b8f74476bc9a0
2016-06-07 14:40:51+01:00