commit_msg
stringlengths
1
24.2k
commit_hash
stringlengths
2
84
project
stringlengths
2
40
source
stringclasses
4 values
labels
int64
0
1
repo_url
stringlengths
26
70
commit_url
stringlengths
74
118
commit_date
stringlengths
25
25
converted string OPs and LOOP insns to TCG git-svn-id: svn://svn.savannah.nongnu.org/qemu/trunk@4494 c046a42c-6fe2-441c-8c8c-71466251a162
6e0d8677cb443e7408c0b7a25a93c6596d7fa380
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/6e0d8677cb443e7408c0b7a25a93c6596d7fa380
2008-05-18 19:28:26+00:00
windows cdrom cache flush (Stefano Stabellini) Windows only flushes its cache of a CDROM if it gets a SENSE_UNIT_ATTENTION CHECK_CONDITION response to a REQUEST_SENSE command. Make sure it does so after we change the CD. Tab damage fixed by Anthony Liguori Signed-off-by: Stefano Stabellini <[email protected]> Signed-off-by: Steven Smith <[email protected]> Signed-off-by: Anthony Liguori <[email protected]> git-svn-id: svn://svn.savannah.nongnu.org/qemu/trunk@5698 c046a42c-6fe2-441c-8c8c-71466251a162
9118e7f08f39001c92d595090b41305ef45c200a
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/9118e7f08f39001c92d595090b41305ef45c200a
2008-11-11 20:57:30+00:00
Add strict checking mode for softfp code. git-svn-id: svn://svn.savannah.nongnu.org/qemu/trunk@3688 c046a42c-6fe2-441c-8c8c-71466251a162
f090c9d4ad5812fb92843d6470a1111c15190c4c
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/f090c9d4ad5812fb92843d6470a1111c15190c4c
2007-11-18 14:33:24+00:00
Make SVM IOIO intercept check all needed bits, by Bernhard Kauer. git-svn-id: svn://svn.savannah.nongnu.org/qemu/trunk@3792 c046a42c-6fe2-441c-8c8c-71466251a162
b26177d7ec3f50157a5f37f804ffcace3b2a3945
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/b26177d7ec3f50157a5f37f804ffcace3b2a3945
2007-12-09 23:39:22+00:00
Invalidate TLBs when domains are changed (Matthew Warton). Legalise cp15 pid register writes (Matthew Warton). git-svn-id: svn://svn.savannah.nongnu.org/qemu/trunk@3494 c046a42c-6fe2-441c-8c8c-71466251a162
405ee3ad573c35790500048d07d5c7ac93167e6a
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/405ee3ad573c35790500048d07d5c7ac93167e6a
2007-10-31 00:47:13+00:00
Check the Galilleo config register instead of hardcoding the endianness. git-svn-id: svn://svn.savannah.nongnu.org/qemu/trunk@3417 c046a42c-6fe2-441c-8c8c-71466251a162
1931e26054fdf2b1b84091f0b9662979eb6931ec
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/1931e26054fdf2b1b84091f0b9662979eb6931ec
2007-10-20 19:47:14+00:00
Rename variables and rearrange code to please gcc -Wshadow checks git-svn-id: svn://svn.savannah.nongnu.org/qemu/trunk@3023 c046a42c-6fe2-441c-8c8c-71466251a162
b3ceef24f4fee8d5ed96b8c4a5d3e80c0a651f0b
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/b3ceef24f4fee8d5ed96b8c4a5d3e80c0a651f0b
2007-06-25 19:56:13+00:00
Limit the use of qemu_chr_open_tty to __linux__ and __sun__, by Andreas Faerber. git-svn-id: svn://svn.savannah.nongnu.org/qemu/trunk@3032 c046a42c-6fe2-441c-8c8c-71466251a162
3fda388a1c19bef4aa8615d91693260e74564bd8
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/3fda388a1c19bef4aa8615d91693260e74564bd8
2007-06-28 15:14:49+00:00
Initialize more GT64xxx registers on reset. git-svn-id: svn://svn.savannah.nongnu.org/qemu/trunk@2956 c046a42c-6fe2-441c-8c8c-71466251a162
30b6f3a866ba4cec86b86ddd22cf3fba3f23ea1d
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/30b6f3a866ba4cec86b86ddd22cf3fba3f23ea1d
2007-06-07 18:09:57+00:00
Always make all PowerPC exception definitions visible. Always make the hypervisor timers available. Remove all TARGET_PPC64H checks, keeping a few if (0) tests for cases that cannot be properly handled with the current PowerPC CPU definition. git-svn-id: svn://svn.savannah.nongnu.org/qemu/trunk@3656 c046a42c-6fe2-441c-8c8c-71466251a162
b172c56a6d849554f7e43adc95983a9d6c042689
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/b172c56a6d849554f7e43adc95983a9d6c042689
2007-11-17 01:37:44+00:00
Correctly initialize Arm CPU for Thumb entry points. git-svn-id: svn://svn.savannah.nongnu.org/qemu/trunk@1739 c046a42c-6fe2-441c-8c8c-71466251a162
0240ded8bb1580147ed2ff1748df439a3b41e38f
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/0240ded8bb1580147ed2ff1748df439a3b41e38f
2006-02-04 19:30:51+00:00
segment validation fix in lret/iret git-svn-id: svn://svn.savannah.nongnu.org/qemu/trunk@1684 c046a42c-6fe2-441c-8c8c-71466251a162
89984cd2e5e70e23b63109988c1156c76a31121d
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/89984cd2e5e70e23b63109988c1156c76a31121d
2005-12-04 22:17:10+00:00
generate GPF if non canonical addresses git-svn-id: svn://svn.savannah.nongnu.org/qemu/trunk@1681 c046a42c-6fe2-441c-8c8c-71466251a162
54ca9095f046dfa03c3d093cc55f6d76b61864e1
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/54ca9095f046dfa03c3d093cc55f6d76b61864e1
2005-12-04 18:46:06+00:00
Remove a local subpage IO hack, now that general subpage IO works. git-svn-id: svn://svn.savannah.nongnu.org/qemu/trunk@2885 c046a42c-6fe2-441c-8c8c-71466251a162
2a1639291bf9f3c88c62d10459fedaa677536ff5
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/2a1639291bf9f3c88c62d10459fedaa677536ff5
2007-05-28 11:26:15+00:00
test at least one invalid lock op code git-svn-id: svn://svn.savannah.nongnu.org/qemu/trunk@570 c046a42c-6fe2-441c-8c8c-71466251a162
4120b61d000117bf016dead1443682c74838227f
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/4120b61d000117bf016dead1443682c74838227f
2004-01-19 20:29:34+00:00
removed invalid eip update git-svn-id: svn://svn.savannah.nongnu.org/qemu/trunk@172 c046a42c-6fe2-441c-8c8c-71466251a162
3ebcc707d20643e9fefa24a4396de577b1163755
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/3ebcc707d20643e9fefa24a4396de577b1163755
2003-05-14 22:47:15+00:00
Open Hack'Ware version 0.4.1 git-svn-id: svn://svn.savannah.nongnu.org/qemu/trunk@1354 c046a42c-6fe2-441c-8c8c-71466251a162
85d8be6bf2c6823f9d386794defa790618c08986
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/85d8be6bf2c6823f9d386794defa790618c08986
2005-04-06 23:06:54+00:00
fixed tlb invalidation git-svn-id: svn://svn.savannah.nongnu.org/qemu/trunk@555 c046a42c-6fe2-441c-8c8c-71466251a162
988578886e0b9af507a7ef111f549c5dd47d93f3
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/988578886e0b9af507a7ef111f549c5dd47d93f3
2004-01-18 21:52:14+00:00
increased physical RAM limit to 2047 MB in soft MMU mode git-svn-id: svn://svn.savannah.nongnu.org/qemu/trunk@575 c046a42c-6fe2-441c-8c8c-71466251a162
bb551faa4ac8a798df9757c0ae26893041344bc3
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/bb551faa4ac8a798df9757c0ae26893041344bc3
2004-01-24 13:42:26+00:00
fixed TB linking in case of code invalidation (fixes random segfaults) git-svn-id: svn://svn.savannah.nongnu.org/qemu/trunk@469 c046a42c-6fe2-441c-8c8c-71466251a162
36bdbe5479cebb5765779a430d14daddddcab871
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/36bdbe5479cebb5765779a430d14daddddcab871
2003-11-19 22:12:02+00:00
soft MMU performance fix (oops) git-svn-id: svn://svn.savannah.nongnu.org/qemu/trunk@429 c046a42c-6fe2-441c-8c8c-71466251a162
415fa2ea77b726ea5a5768d659881e919df1fcf2
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/415fa2ea77b726ea5a5768d659881e919df1fcf2
2003-10-30 00:39:38+00:00
added return for ARM case (may be incorrect - need checking) git-svn-id: svn://svn.savannah.nongnu.org/qemu/trunk@319 c046a42c-6fe2-441c-8c8c-71466251a162
f8c8799840d3250723de8247a1bb8c70a336f0f5
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/f8c8799840d3250723de8247a1bb8c70a336f0f5
2003-07-09 19:41:41+00:00
suppressed ring 0 hacks git-svn-id: svn://svn.savannah.nongnu.org/qemu/trunk@275 c046a42c-6fe2-441c-8c8c-71466251a162
83479e770d31e171232a82f4eee7dab06d3b219c
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/83479e770d31e171232a82f4eee7dab06d3b219c
2003-06-25 16:12:37+00:00
More PowerPC definitions, from POWER 2.04 specifications and misc sources. Check that at least instructions set and SPRs are correct for PowerPC 401, 403, 405 and 440 cores. Implement PowerPC 401 MMU model (real-mode only). Improve INSNs and SPRs dump to ease parse with standard shell tools. Add more precise status for most PowerPC cores families. git-svn-id: svn://svn.savannah.nongnu.org/qemu/trunk@3201 c046a42c-6fe2-441c-8c8c-71466251a162
2662a059aa2affddfbe42e78b11c802cf30a970f
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/2662a059aa2affddfbe42e78b11c802cf30a970f
2007-09-21 05:50:37+00:00
pxb: Restrict to x86 The PCI Expander Bridge (PXB) device is essentially a hack to allow different PCIe devices to be assigned to different NUMA nodes on x86. Each PXB is sort-of a separate PCI host bridge, except that its config space is shared with the config space of the main PCI host bridge, rather than being independent. This is only necessary if the platform doesn't (easily) allow truly independent PCI host bridges. AFAIK that's just x86. This patch makes it possible to configure PXB out of the build, and adjusts the default configs so it's only included on x86 targets. Signed-off-by: David Gibson <[email protected]> Acked-by: Michael S. Tsirkin <[email protected]>
ef291226494f53f10c5cbe90bff550a52bda7b76
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/ef291226494f53f10c5cbe90bff550a52bda7b76
2017-01-31 10:10:14+11:00
nvdimm: add 'unarmed' option Currently the only vNVDIMM backend can guarantee the guest write persistence is device DAX on Linux, because no host-side kernel cache is involved in the guest access to it. The approach to detect whether the backend is device DAX needs to access sysfs, which may not work with SELinux. Instead, we add the 'unarmed' option to device 'nvdimm', so that users or management utils, which have enough knowledge about the backend, can control the unarmed flag in guest ACPI NFIT via this option. The guest Linux NVDIMM driver, for example, will mark the corresponding vNVDIMM device read-only if the unarmed flag in guest NFIT is set. The default value of 'unarmed' option is 'off' in order to keep the backwards compatibility. Signed-off-by: Haozhong Zhang <[email protected]> Message-Id: <[email protected]> Reviewed-by: Michael S. Tsirkin <[email protected]> Reviewed-by: Stefan Hajnoczi <[email protected]> Signed-off-by: Eduardo Habkost <[email protected]>
cb836434cda103fac3c06174e70bf5c9b7083b8e
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/cb836434cda103fac3c06174e70bf5c9b7083b8e
2018-01-19 11:18:51-02:00
i386: Change X86CPUDefinition::model_id to const char* It is valid to have a 48-character model ID on CPUID, however the definition of X86CPUDefinition::model_id is char[48], which can make the compiler drop the null terminator from the string. If a CPU model happens to have 48 bytes on model_id, "-cpu help" will print garbage and the object_property_set_str() call at x86_cpu_load_def() will read data outside the model_id array. We could increase the array size to 49, but this would mean the compiler would not issue a warning if a 49-char string is used by mistake for model_id. To make things simpler, simply change model_id to be const char*, and validate the string length using an assert() on x86_register_cpudef_type(). Reported-by: "Dr. David Alan Gilbert" <[email protected]> Signed-off-by: Eduardo Habkost <[email protected]> Message-Id: <[email protected]> Signed-off-by: Eduardo Habkost <[email protected]>
807e9869b8c4119b81df902625af818519e01759
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/807e9869b8c4119b81df902625af818519e01759
2018-01-17 23:04:31-02:00
tpm-tis: no longer expose TPMState Now that there is an interface instead. Signed-off-by: Marc-André Lureau <[email protected]> Reviewed-by: Stefan Berger <[email protected]> Signed-off-by: Stefan Berger <[email protected]>
36e8658924cec6427ca00f87ce86f65cfa705d69
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/36e8658924cec6427ca00f87ce86f65cfa705d69
2017-12-14 23:39:14-05:00
hw/ipmi: Replace fprintf(stderr, "*\n" with error_report() Replace a large number of the fprintf(stderr, "*\n" calls with error_report(). The functions were renamed with these commands and then compiler issues where manually fixed. find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N;N;N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig}' \ {} + find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N;N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig}' \ {} + find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig}' \ {} + find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig}' \ {} + find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig}' \ {} + find ./* -type f -exec sed -i \ 'N;N;N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig}' \ {} + find ./* -type f -exec sed -i \ 'N;N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig}' \ {} + find ./* -type f -exec sed -i \ 'N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig}' \ {} + find ./* -type f -exec sed -i \ 'N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig}' \ {} + find ./* -type f -exec sed -i \ 'N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig}' \ {} + find ./* -type f -exec sed -i \ 'N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig}' \ {} + Some lines where then manually tweaked to pass checkpatch. Signed-off-by: Alistair Francis <[email protected]> Reviewed-by: Philippe Mathieu-Daudé <[email protected]> Signed-off-by: Thomas Huth <[email protected]>
4fee24700d2a1e8d221823fdebfa41fbd939f48e
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/4fee24700d2a1e8d221823fdebfa41fbd939f48e
2018-01-22 09:51:00+01:00
s390x: handle exceptions during s390_cpu_virt_mem_rw() correctly (TCG) s390_cpu_virt_mem_rw() must always return, so callers can react on an exception (e.g. see ioinst_handle_stcrw()). However, for TCG we always have to exit the cpu loop (and restore the cpu state before that) if we injected a program interrupt. So let's introduce and use s390_cpu_virt_mem_handle_exc() in code that is not purely KVM. Directly pass the retaddr we already have available in these functions. Reviewed-by: Richard Henderson <[email protected]> Signed-off-by: David Hildenbrand <[email protected]> Message-Id: <[email protected]> Signed-off-by: Cornelia Huck <[email protected]>
98ee9bedc734e18287902f39e3a3a8adb399386a
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/98ee9bedc734e18287902f39e3a3a8adb399386a
2017-12-14 17:56:54+01:00
qcow2: check_errors are fatal When trying to repair a dirty image, qcow2_check() may apparently succeed (no really fatal error occurred that would prevent the check from continuing), but if check_errors in the result object is non-zero, we cannot trust the image to be usable. Reported-by: R. Nageswara Sastry <[email protected]> Buglink: https://bugs.launchpad.net/qemu/+bug/1728639 Signed-off-by: Max Reitz <[email protected]> Message-id: [email protected] Reviewed-by: Eric Blake <[email protected]> Signed-off-by: Max Reitz <[email protected]>
791fff504cad4d935dfaab6333ff9b7d95cbfe3f
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/791fff504cad4d935dfaab6333ff9b7d95cbfe3f
2017-11-17 18:21:30+01:00
ppc: fix VTB migration Migration of a system under stress (for example, with "stress-ng --numa 2") triggers on the destination some kernel watchdog messages like: NMI watchdog: BUG: soft lockup - CPU#0 stuck for 3489660870s! NMI watchdog: BUG: soft lockup - CPU#1 stuck for 3489660884s! This problem appears with the changes introduced by 42043e4 spapr: clock should count only if vm is running I think this commit only triggers the problem. Kernel computes the soft lockup duration using the Virtual Timebase register (VTB), not using the Timebase Register (TBR, the one 42043e4 stops). It appears VTB is not migrated, so this patch adds it in the list of the SPRs to migrate, and fixes the problem. For the migration, I've tested a migration from qemu-2.8.0 and pseries-2.8.0 to a patched master (qemu-2.11.0-rc1). The received VTB is 0 (as is it not initialized by qemu-2.8.0), but the value seems to be ignored by KVM and a non zero VTB is used by the kernel. I have no explanation for that, but as the original problem appears only with SMP system under stress I suspect some problems in KVM (I think because VTB is shared by all threads of a core). Signed-off-by: Laurent Vivier <[email protected]> Signed-off-by: David Gibson <[email protected]>
6dd836f5d32b989e18c6dda655a26f4d73a52f6a
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/6dd836f5d32b989e18c6dda655a26f4d73a52f6a
2017-11-22 15:28:37+11:00
block/snapshot: dirty all dirty bitmaps on snapshot-switch Snapshot-switch actually changes active state of disk so it should reflect on dirty bitmaps. Otherwise next incremental backup using these bitmaps will be invalid. Signed-off-by: Vladimir Sementsov-Ogievskiy <[email protected]> Message-id: [email protected] Reviewed-by: Eric Blake <[email protected]> Reviewed-by: John Snow <[email protected]> Signed-off-by: Max Reitz <[email protected]>
04dec3c3ae5c4a4f1fcb684fa264ba166bdb6610
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/04dec3c3ae5c4a4f1fcb684fa264ba166bdb6610
2017-11-14 18:06:25+01:00
build-sys: restrict vmcoreinfo to fw_cfg+dma capable targets vmcoreinfo is built for all targets. However, it requires fw_cfg with DMA operations support (write operation). Restrict vmcoreinfo exposure to architectures that are supporting FW_CFG_DMA, that is arm-virt and x86 only atm. Signed-off-by: Marc-André Lureau <[email protected]> Reviewed-by: Thomas Huth <[email protected]> Reviewed-by: Daniel Henrique Barboza <[email protected]> Tested-by: Daniel Henrique Barboza <[email protected]> Reviewed-by: Michael S. Tsirkin <[email protected]> Signed-off-by: Michael S. Tsirkin <[email protected]>
f865da7c369fa00b2ccaf6bce158ad2701b2a27c
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/f865da7c369fa00b2ccaf6bce158ad2701b2a27c
2017-11-16 17:46:53+02:00
nbd/server: Simplify nbd_negotiate_options loop Instead of making each caller check whether a transmission error occurred, we can sink a common error check to the end of the loop. Signed-off-by: Eric Blake <[email protected]> Message-Id: <[email protected]> [eblake: squash in compiler warning fix] Reviewed-by: Vladimir Sementsov-Ogievskiy <[email protected]>
8cbee49ed7348e9b2b708d75c8ff8941032cb488
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/8cbee49ed7348e9b2b708d75c8ff8941032cb488
2017-10-30 21:07:59+01:00
qemu-img.1: Image invalidation on qemu-img commit qemu-img commit invalidates all images between base and top. This should be mentioned in the man page. Suggested-by: Ping Li <[email protected]> Signed-off-by: Max Reitz <[email protected]> Reviewed-by: Jeff Cody <[email protected]> Signed-off-by: Kevin Wolf <[email protected]>
67e56472a503f94a3950bad85a57fb99706cf1d8
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/67e56472a503f94a3950bad85a57fb99706cf1d8
2017-10-26 14:59:18+02:00
qga-win: fix error-handling in getNameByStringSID() In one case we misconstrue a BOOL return as an HRESULT, and in the other case we don't check the BOOL return from LookupAccountSidW() before extracting the HRESULT from GetLastError(). Both can lead to getNameByStringSID() misreporting an error. Reported-by: Chen Hanxiao <[email protected]> Suggested-by: Tomáš Golembiovský <[email protected]> Signed-off-by: Michael Roth <[email protected]>
8cedc80555e5a395a4fda7130b0115015e775c48
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/8cedc80555e5a395a4fda7130b0115015e775c48
2017-10-26 20:01:32-05:00
tcg: Avoid loops against variable bounds Copy s->nb_globals or s->nb_temps to a local variable for the purposes of iteration. This should allow the compiler to use low-overhead looping constructs on some hosts. Reviewed-by: Philippe Mathieu-Daudé <[email protected]> Reviewed-by: Emilio G. Cota <[email protected]> Reviewed-by: Alex Bennée <[email protected]> Signed-off-by: Richard Henderson <[email protected]>
ac3b88911ebc6fc841f28898ee8aed40839debe2
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/ac3b88911ebc6fc841f28898ee8aed40839debe2
2017-10-24 21:44:34+02:00
build: remove use of MAKELEVEL optimization in submodule handling The Makefile attempts to optimize the handling of submodules by using MAKELEVEL to only check the submodule status when running from the top level make invokation. This causes problems for people who are using a makefile of their own to in turn invoke QEMU's makefile, as MAKELEVEL is already set to 1 (or more) when QEMU's makefile runs. This optimization should not really be needed, since the git-submodule.sh script is already used to detect if a submodule update is required. This by removing the MAKELEVEL check, we at most add an extra 'git-submodule.sh status' call to each make level, the overhead of which is lost in noise of building QEMU. Reviewed-by: Greg Kurz <[email protected]> Tested-by: Greg Kurz <[email protected]> Signed-off-by: Daniel P. Berrange <[email protected]>
c4b01c7c5171e9f77ed4ed6d9b4f63845410f641
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/c4b01c7c5171e9f77ed4ed6d9b4f63845410f641
2017-11-06 12:49:20+00:00
linux-user/main: support dfilter This adds the -dfilter support to linux-user. There is a minor checkpatch complaint about formatting which I've ignored for aesthetic reasons. Signed-off-by: Alex Bennée <[email protected]> Reviewed-by: Laurent Vivier <[email protected]> Reviewed-by: Richard Henderson <[email protected]> Signed-off-by: Riku Voipio <[email protected]>
8423fa9010f2cadd50e8c21a20c62dc5b977704c
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/8423fa9010f2cadd50e8c21a20c62dc5b977704c
2017-10-17 22:17:01+03:00
exec-all: bring tb->invalid into tb->cflags This gets rid of a hole in struct TranslationBlock. Reviewed-by: Richard Henderson <[email protected]> Signed-off-by: Emilio G. Cota <[email protected]> Signed-off-by: Richard Henderson <[email protected]>
84f1c148da2b35fbb5a436597872765257e8914e
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/84f1c148da2b35fbb5a436597872765257e8914e
2017-10-10 07:37:10-07:00
migration: Check field save returns Check the return values from vmstate_save_state for fields and also the return values from 'put' for fields that use that. Signed-off-by: Dr. David Alan Gilbert <[email protected]> Message-Id: <[email protected]> Reviewed-by: Peter Xu <[email protected]> Reviewed-by: Cornelia Huck <[email protected]> Reviewed-by: Juan Quintela <[email protected]> Signed-off-by: Dr. David Alan Gilbert <[email protected]>
88b0faf1853937b87a35cae8c74e38971aff0bba
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/88b0faf1853937b87a35cae8c74e38971aff0bba
2017-09-27 11:37:11+01:00
target-arm: Don't check for "Thumb2 or M profile" for not-Thumb1 The code which implements the Thumb1 split BL/BLX instructions is guarded by a check on "not M or THUMB2". All we really need to check here is "not THUMB2" (and we assume that elsewhere too, eg in the ARCH(6T2) test that UNDEFs the Thumb2 insns). This doesn't change behaviour because all M profile cores have Thumb2 and so ARM_FEATURE_M implies ARM_FEATURE_THUMB2. (v6M implements a very restricted subset of Thumb2, but we can cross that bridge when we get to it with appropriate feature bits.) Signed-off-by: Peter Maydell <[email protected]> Reviewed-by: Richard Henderson <[email protected]> Message-id: [email protected]
6b8acf256df09c8a8dd7dcaa79b06eaff4ad63f7
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/6b8acf256df09c8a8dd7dcaa79b06eaff4ad63f7
2017-10-12 13:23:14+01:00
target-arm: Simplify insn_crosses_page() Recent changes have left insn_crosses_page() more complicated than it needed to be: * it's only called from thumb_tr_translate_insn() so we know for certain that we're looking at a Thumb insn * the caller's check for dc->pc >= dc->next_page_start - 3 means that dc->pc can't possibly be 4 aligned, so there's no need to check that (the check was partly there to ensure that we didn't treat an ARM insn as Thumb, I think) * we now have thumb_insn_is_16bit() which lets us do a precise check of the length of the next insn, rather than opencoding an inaccurate check Simplify it down to just loading the first half of the insn and calling thumb_insn_is_16bit() on it. Signed-off-by: Peter Maydell <[email protected]> Reviewed-by: Richard Henderson <[email protected]> Message-id: [email protected]
5b8d7289e9e92a0d7bcecb93cd189e245fef10cd
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/5b8d7289e9e92a0d7bcecb93cd189e245fef10cd
2017-10-12 13:23:14+01:00
hmp: fix "dump-quest-memory" segfault (arm) Running QEMU with qemu-system-aarch64 -M none -nographic -m 256 and executing dump-guest-memory /dev/null 0 8192 results in segfault Fix by checking if we have CPU, and exit with error if there is no CPU: (qemu) dump-guest-memory /dev/null this feature or command is not currently supported Signed-off-by: Laurent Vivier <[email protected]> Reviewed-by: Thomas Huth <[email protected]> Reviewed-by: Greg Kurz <[email protected]> Message-Id: <[email protected]> Reviewed-by: Eric Auger <[email protected]> Tested-by: Eric Auger <[email protected]> Signed-off-by: Dr. David Alan Gilbert <[email protected]>
6dba634097d54db60017f10c160a052e46bdf60d
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/6dba634097d54db60017f10c160a052e46bdf60d
2017-09-14 15:52:10+01:00
nvic: Handle v8M changes in nvic_exec_prio() Update nvic_exec_prio() to support the v8M changes: * BASEPRI, FAULTMASK and PRIMASK are all banked * AIRCR.PRIS can affect NS priorities * AIRCR.BFHFNMINS affects FAULTMASK behaviour These changes mean that it's no longer possible to definitely say that if FAULTMASK is set it overrides PRIMASK, and if PRIMASK is set it overrides BASEPRI (since if PRIMASK_NS is set and AIRCR.PRIS is set then whether that 0x80 priority should take effect or the priority in BASEPRI_S depends on the value of BASEPRI_S, for instance). So we switch to the same approach used by the pseudocode of working through BASEPRI, PRIMASK and FAULTMASK and overriding the previous values if needed. Signed-off-by: Peter Maydell <[email protected]> Reviewed-by: Richard Henderson <[email protected]> Message-id: [email protected]
49c80c380d665bcc7d5b68ea1ec3617e51a90d73
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/49c80c380d665bcc7d5b68ea1ec3617e51a90d73
2017-09-21 16:31:09+01:00
i386/cpu/hyperv: support over 64 vcpus for windows guests Starting with Windows Server 2012 and Windows 8, if CPUID.40000005.EAX contains a value of -1, Windows assumes specific limit to the number of VPs. In this case, Windows Server 2012 guest VMs may use more than 64 VPs, up to the maximum supported number of processors applicable to the specific Windows version being used. https://docs.microsoft.com/en-us/virtualization/hyper-v-on-windows/reference/tlfs For compatibility, Let's introduce a new property for X86CPU, named "x-hv-max-vps" as Eduardo's suggestion, and set it to 0x40 before machine 2.10. (The "x-" prefix indicates that the property is not supposed to be a stable user interface.) Signed-off-by: Gonglei <[email protected]> Message-Id: <[email protected]> Signed-off-by: Paolo Bonzini <[email protected]>
6c69dfb67e84747cf071958594d939e845dfcc0c
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/6c69dfb67e84747cf071958594d939e845dfcc0c
2017-09-19 16:20:49+02:00
nvic: Add cached vectpending_prio state Instead of looking up the pending priority in nvic_pending_prio(), cache it in a new state struct field. The calculation of the pending priority given the interrupt number is more complicated in v8M with the security extension, so the caching will be worthwhile. This changes nvic_pending_prio() from returning a full (group + subpriority) priority value to returning a group priority. This doesn't require changes to its callsites because we use it only in comparisons of the form execution_prio > nvic_pending_prio() and execution priority is always a group priority, so a test (exec prio > full prio) is true if and only if (execprio > group_prio). (Architecturally the expected comparison is with the group priority for this sort of "would we preempt" test; we were only doing a test with a full priority as an optimisation to avoid the mask, which is possible precisely because the two comparisons always give the same answer.) Signed-off-by: Peter Maydell <[email protected]> Reviewed-by: Richard Henderson <[email protected]> Message-id: [email protected]
5255fcf8e47acd059e2f0d414841c40231c1bd22
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/5255fcf8e47acd059e2f0d414841c40231c1bd22
2017-09-21 16:29:27+01:00
qemu-iothread: IOThread supports the GMainContext event loop IOThread uses AioContext event loop and does not run a GMainContext. Therefore,chardev cannot work in IOThread,such as the chardev is used for colo-compare packets reception. This patch makes the IOThread run the GMainContext event loop, chardev and IOThread can work together. Reviewed-by: Fam Zheng <[email protected]> Signed-off-by: Wang Yong <[email protected]> Signed-off-by: Wang Guang <[email protected]> Signed-off-by: Jason Wang <[email protected]>
329163cbe64a615b4edf6c40f2fff8c79dbc8fb4
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/329163cbe64a615b4edf6c40f2fff8c79dbc8fb4
2017-09-08 09:32:48+08:00
spapr_drc: add unrealize method to physical DRC class When hot-unplugging a PHB, all its PCI DRC connectors get unrealized. This patch adds an unrealize method to the physical DRC class, in order to undo registrations performed in realize_physical(). Signed-off-by: Greg Kurz <[email protected]> Signed-off-by: David Gibson <[email protected]>
379ae096f7ee7c8ae15886eeb4361008ac6ba1c4
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/379ae096f7ee7c8ae15886eeb4361008ac6ba1c4
2017-09-08 09:30:54+10:00
target/arm: [tcg,a64] Port to disas_log Incrementally paves the way towards using the generic instruction translation loop. Reviewed-by: Emilio G. Cota <[email protected]> Reviewed-by: Richard Henderson <[email protected]> Signed-off-by: Lluís Vilanova <[email protected]> Message-Id: <[email protected]> [rth: Move tb->size computation and use that result.] Signed-off-by: Richard Henderson <[email protected]>
58350fa4b2852fede96cfebad0b26bf79bca419c
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/58350fa4b2852fede96cfebad0b26bf79bca419c
2017-09-06 08:06:48-07:00
target/arm: [tcg,a64] Port to breakpoint_check Incrementally paves the way towards using the generic instruction translation loop. Reviewed-by: Emilio G. Cota <[email protected]> Reviewed-by: Richard Henderson <[email protected]> Signed-off-by: Lluís Vilanova <[email protected]> Message-Id: <[email protected]> [rth: Use DISAS_TOO_MANY for "execute only one more" after bp.] Signed-off-by: Richard Henderson <[email protected]>
0cb56b373da70047979b61b042f59aaff4012e1b
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/0cb56b373da70047979b61b042f59aaff4012e1b
2017-09-06 08:06:47-07:00
vga: use DIV_ROUND_UP I used the clang-tidy qemu-round check to generate the fix: https://github.com/elmarco/clang-tools-extra Signed-off-by: Marc-André Lureau <[email protected]> Reviewed-by: Richard Henderson <[email protected]>
2c23ce22c611a0cdddf9e7fdd3e8144da74744b5
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/2c23ce22c611a0cdddf9e7fdd3e8144da74744b5
2017-08-31 12:29:07+02:00
block/vhdx: check error return of bdrv_flush() Reported-by: Kevin Wolf <[email protected]> Signed-off-by: Jeff Cody <[email protected]> Reviewed-by: Eric Blake <[email protected]> Signed-off-by: Kevin Wolf <[email protected]>
c6572fa0d2b81bc3a9ca5716f975f2bf59c62e6c
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/c6572fa0d2b81bc3a9ca5716f975f2bf59c62e6c
2017-08-08 14:37:00+02:00
qlit: Tighten QLit list vs QList comparison We check that all members of the QLit list are also in the QList. We neglect to check the other direction. Fix that. While there, use QLIST_FOREACH_ENTRY() to simplify the code and break the loop on the first mismatch. Signed-off-by: Marc-André Lureau <[email protected]> Message-Id: <[email protected]> [Commit message improved] Signed-off-by: Markus Armbruster <[email protected]>
cbb654052600c376d5ee3401c98a25d09d11a154
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/cbb654052600c376d5ee3401c98a25d09d11a154
2017-09-04 13:09:12+02:00
block/qapi: Remove redundant NULL check to silence Coverity When skipping implicit nodes in bdrv_block_device_info(), we know that bs0 is always non-NULL; initially, because it's taken from a BdrvChild and a BdrvChild never has a NULL bs, and after the first iteration because implicit nodes always have a backing file. Remove the NULL check and add an assertion that the implicit node does indeed have a backing file. Signed-off-by: Kevin Wolf <[email protected]> Reviewed-by: Eric Blake <[email protected]> Reviewed-by: Jeff Cody <[email protected]>
8e8eb0a9035e5b6c6447c82138570e388282cfa2
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/8e8eb0a9035e5b6c6447c82138570e388282cfa2
2017-08-01 18:09:33+02:00
iotests: Check dirty bitmap statistics in 124 We had a bug for multiple releases where dirty-bitmap count was documented in bytes but reported in sectors; enhance the testsuite to add coverage of DirtyBitmapInfo to ensure we do not regress again. Signed-off-by: Eric Blake <[email protected]> Reviewed-by: Stefan Hajnoczi <[email protected]> Reviewed-by: John Snow <[email protected]> Signed-off-by: Kevin Wolf <[email protected]>
1e2b1f6487ae26256a42f017fc1b06e19bb98f5a
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/1e2b1f6487ae26256a42f017fc1b06e19bb98f5a
2017-08-01 18:09:33+02:00
target/sh4: Unify code for CHECK_NOT_DELAY_SLOT We do not need to emit N copies of raising an exception. Reviewed-by: Philippe Mathieu-Daudé <[email protected]> Reviewed-by: Aurelien Jarno <[email protected]> Signed-off-by: Richard Henderson <[email protected]> Message-Id: <[email protected]> Signed-off-by: Aurelien Jarno <[email protected]>
dec16c6ee8e665ec558f7564e68c09e01facf903
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/dec16c6ee8e665ec558f7564e68c09e01facf903
2017-07-18 23:39:17+02:00
tests: Simplify abstract-interfaces check with a helper Add a new type_list_find() helper to device-introspect-test.c, to simplify the code at test_abstract_interfaces(). Reviewed-by: Eric Blake <[email protected]> Signed-off-by: Eduardo Habkost <[email protected]> Message-Id: <[email protected]> Signed-off-by: Eduardo Habkost <[email protected]>
dbb2a604a94f3899fa34bd1ede462f213e822e03
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/dbb2a604a94f3899fa34bd1ede462f213e822e03
2017-07-17 15:41:30-03:00
usb: Fix build with newer gcc gcc 7 is pickier about our sources: hw/usb/bus.c: In function ‘usb_port_location’: hw/usb/bus.c:410:66: error: ‘%d’ directive output may be truncated writing between 1 and 11 bytes into a region of size between 0 and 15 [-Werror=format-truncation=] snprintf(downstream->path, sizeof(downstream->path), "%s.%d", ^~ hw/usb/bus.c:410:9: note: ‘snprintf’ output between 3 and 28 bytes into a destination of size 16 snprintf(downstream->path, sizeof(downstream->path), "%s.%d", ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ upstream->path, portnr); ~~~~~~~~~~~~~~~~~~~~~~~ But we know that there are at most 5 levels of USB hubs, with at most two digits per level; that plus the separating dots means we use at most 15 bytes (including trailing NUL) of our 16-byte field. Adding an assertion to show gcc that we checked for truncation is enough to shut up the false-positive warning. Inspired by an idea by Dr. David Alan Gilbert <[email protected]>. Signed-off-by: Eric Blake <[email protected]> Reviewed-by: Philippe Mathieu-Daudé <[email protected]> Message-id: [email protected] Signed-off-by: Gerd Hoffmann <[email protected]>
121829cb2160e9cd82482c1542699fa589688106
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/121829cb2160e9cd82482c1542699fa589688106
2017-07-20 10:02:11+02:00
block/qapi: Use blk_all_next() for query-block This patch replaces the blk_next() loop in query-block by a blk_all_next() one so that we also get access to BlockBackends that aren't owned by the monitor. For now, the next thing we do is check whether each BB has a name, so there is no semantic difference. Signed-off-by: Kevin Wolf <[email protected]> Reviewed-by: Eric Blake <[email protected]> Reviewed-by: John Snow <[email protected]>
d5b68844e6f7c13d30b46cc92ba468e5f92119a6
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/d5b68844e6f7c13d30b46cc92ba468e5f92119a6
2017-07-18 15:14:36+02:00
s390x/css: check ccw address validity According to the PoP channel command words (CCW) must be doubleword aligned and 31 bit addressable for format 1 and 24 bit addressable for format 0 CCWs. If the channel subsystem encounters a ccw address which does not satisfy this alignment requirement a program-check condition is recognised. The situation with 31 bit addressable is a bit more complicated: both the ORB and a format 1 CCW TIC hold the address of (the rest of) the channel program, that is the address of the next CCW in a word, and the PoP mandates that bit 0 of that word shall be zero -- or a program-check condition is to be recognized -- and does not belong to the field holding the ccw address. Since in code the corresponding fields span across the whole word (unlike in PoP where these are defined as 31 bit wide) we can check this by applying a mask. The 24 addressable case isn't affecting TIC because the address is composed of a halfword and a byte portion (no additional zero bit requirements) and just slightly complicates the ORB case where also bits 1-7 need to be zero. The same requirements (especially n-bit addressability) apply to the ccw addresses generated while chaining. Let's make our CSS implementation follow the AR more closely. Signed-off-by: Halil Pasic <[email protected]> Message-Id: <[email protected]> Reviewed-by: Dong Jia Shi <[email protected]> Signed-off-by: Cornelia Huck <[email protected]>
198c0d1f9df8c429502cb744fc26b6ba6e71db74
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/198c0d1f9df8c429502cb744fc26b6ba6e71db74
2017-07-28 10:06:25+02:00
target/arm/translate.h: expand comment on DISAS_EXIT We already have an exit condition, DISAS_UPDATE which will exit the run-loop. Expand on the difference with DISAS_EXIT in the comments. Signed-off-by: Alex Bennée <[email protected]> Reviewed-by: Richard Henderson <[email protected]> Message-id: [email protected] Signed-off-by: Peter Maydell <[email protected]>
abd1fb0ee2c58b99f4b2d15718f1825fe4984e12
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/abd1fb0ee2c58b99f4b2d15718f1825fe4984e12
2017-07-17 13:36:07+01:00
s390x/arch_dump: also dump guarded storage control block Write the new note section of type 30b (guarded storage control block). Signed-off-by: Christian Borntraeger <[email protected]>
21a106904b5336b6ea60c22a95feb7d61c664d7f
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/21a106904b5336b6ea60c22a95feb7d61c664d7f
2017-07-14 12:29:49+02:00
qcow: require image size to be > 1 for new images The qcow driver refuses to open images which are less than 2 bytes in size, but will happily create such images. Add a check in the create path to avoid this discrepancy. Reviewed-by: Max Reitz <[email protected]> Reviewed-by: Alberto Garcia <[email protected]> Reviewed-by: Eric Blake <[email protected]> Signed-off-by: Daniel P. Berrange <[email protected]> Message-id: [email protected] Signed-off-by: Max Reitz <[email protected]>
6aa837f7bd60903573e0644f503f455454bbf5ae
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/6aa837f7bd60903573e0644f503f455454bbf5ae
2017-07-11 17:44:55+02:00
backup: Switch backup_run() to byte-based We are gradually converting to byte-based interfaces, as they are easier to reason about than sector-based. Change the internal loop iteration of backups to track by bytes instead of sectors (although we are still guaranteed that we iterate by steps that are cluster-aligned). Signed-off-by: Eric Blake <[email protected]> Reviewed-by: John Snow <[email protected]> Reviewed-by: Jeff Cody <[email protected]> Reviewed-by: Kevin Wolf <[email protected]> Signed-off-by: Kevin Wolf <[email protected]>
6f8e35e2414433a56b4bd548b87b8ac2aedecb77
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/6f8e35e2414433a56b4bd548b87b8ac2aedecb77
2017-07-10 13:18:06+02:00
serial: chardev hotswap support This allows to change the port's backend runtime, e.g. change it from file to a socket making it possible to establish a debug session with WinDbg > qemu-system [..] -chardev file,id=charchannel2,path=/tmp/charchannel2 \ -device isa-serial,chardev=charchannel2,id=channel2 QEMU 2.9.50 monitor - type 'help' for more information (qemu) chardev-change charchannel2 \ socket,host=127.0.0.1,port=4242,server,nowait For a backend change, a number of ioctls has to be replayed to sync the current setup of a frontend to a backend tty. This is hopefully enough so we don't have to track, store and replay the whole original control byte sequence. Signed-off-by: Anton Nefedov <[email protected]> Reviewed-by: Vladimir Sementsov-Ogievskiy <[email protected]> Message-Id: <[email protected]> Signed-off-by: Paolo Bonzini <[email protected]>
1a29cc8f5ebd657e159dbe4be340102595846d42
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/1a29cc8f5ebd657e159dbe4be340102595846d42
2017-07-14 11:04:34+02:00
checkpatch: should not use signal except for SIG_DFL or SIG_IGN Using signal to establish a signal handler is not portable; on SysV systems, the signal handler would be reset to SIG_DFL after delivery, while BSD preserves the signal handler. Daniel Berrange reported that (to complicate matters further) the signal system call has SysV behavior, but glibc signal() actually calls the sigaction system call to provide BSD behavior. However, using signal() to set a signal's disposition to SIG_DFL or SIG_IGN is portable and is a relatively common occurrence in QEMU source code, so allow that. Reviewed-by: Daniel P. Berrange <[email protected]> Reviewed-by: Richard W.M. Jones <[email protected]> Signed-off-by: Paolo Bonzini <[email protected]>
e8c2091d4c4dd78bb9b8618205a238b96c87045d
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/e8c2091d4c4dd78bb9b8618205a238b96c87045d
2017-07-04 14:39:28+02:00
util/oslib-win32: Remove if conditional The original ready < nhandles - 1 can be re-written as ready + 1 < nhandles. The check was actually incorrect because WAIT_OBJECT_0 was not subtracted from ready; it worked because WAIT_OBJECT_0 is zero. After subtracting WAIT_OBJECT_0, the result is the same condition that we are checking on the first itteration of the for loop. This means we can remove the if statement and let the for loop check the code. Signed-off-by: Alistair Francis <[email protected]> Message-Id: <a14083d681951f3999a0e9314605cb706381ae8d.1498756113.git.alistair.francis@xilinx.com> Signed-off-by: Paolo Bonzini <[email protected]>
0ec7b534821c8b287317f97cd98ee3f908bd3839
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/0ec7b534821c8b287317f97cd98ee3f908bd3839
2017-07-04 14:39:27+02:00
target/s390x: Exit after changing PSW mask Exit to cpu loop so we reevaluate cpu_s390x_hw_interrupts. Reviewed-by: Alex Bennée <[email protected]> Signed-off-by: Richard Henderson <[email protected]>
542f70c22edd22367373b4cb34d3c478f1ac7c0f
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/542f70c22edd22367373b4cb34d3c478f1ac7c0f
2017-06-19 11:11:25-07:00
sdl2: add assert to make coverity happy There is a loop a few lines up counting consoles and setting sdl2_num_outputs accordingly, so con ptr can't be NULL there. Signed-off-by: Gerd Hoffmann <[email protected]> Message-id: [email protected] Signed-off-by: Gerd Hoffmann <[email protected]>
85970a627f308483053f18a342037245d0fee469
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/85970a627f308483053f18a342037245d0fee469
2017-06-23 11:50:46+02:00
tcg/arm: Remove limit on code buffer size Since we're no longer using a direct branch, we have no limit on the branch distance. Signed-off-by: Richard Henderson <[email protected]>
acb0b292b6d0f49972dc98f742e79ed53973e438
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/acb0b292b6d0f49972dc98f742e79ed53973e438
2017-06-19 11:10:59-07:00
virtio-9p: message header is 7-byte long The 9p spec at http://man.cat-v.org/plan_9/5/intro reads: "Each 9P message begins with a four-byte size field specify- ing the length in bytes of the complete message including the four bytes of the size field itself. The next byte is the message type, one of the constants in the enumeration in the include file <fcall.h>. The next two bytes are an iden- tifying tag, described below." ie, each message starts with a 7-byte long header. The core 9P code already assumes this pretty much everywhere. This patch does the following: - makes the assumption explicit in the common 9p.h header, since it isn't related to the transport - open codes the header size in handle_9p_output() and hardens the sanity check on the space needed for the reply message Signed-off-by: Greg Kurz <[email protected]> Acked-by: Stefano Stabellini <[email protected]>
a4d99854505ed63f5ea67fbfefb90316472cf158
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/a4d99854505ed63f5ea67fbfefb90316472cf158
2017-06-29 15:11:50+02:00
megasas: do not read command more than once from frame Avoid TOC-TOU bugs by passing the frame_cmd down, and checking cmd->dcmd_opcode instead of cmd->frame->header.frame_cmd. Signed-off-by: Paolo Bonzini <[email protected]>
36c327a69d723571f02a7691631667cdb1865ee1
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/36c327a69d723571f02a7691631667cdb1865ee1
2017-06-15 11:04:05+02:00
xics: setup cpu at realize time Until recently, spapr used to allocate ICPState objects for the lifetime of the machine. They would only be associated to vCPUs in xics_cpu_setup() when plugging a CPU core. Now that ICPState objects have the same lifecycle as vCPUs, it is possible to associate them during realization. This patch hence open-codes xics_cpu_setup() in icp_realize(). The vCPU is passed as a property. Note that vCPU now needs to be realized first for the IRQs to be allocated. It also needs to resetted before ICPState realization in order to synchronize with KVM. Since ICPState objects are freed when unrealized, xics_cpu_destroy() isn't needed anymore and can be safely dropped. Signed-off-by: Greg Kurz <[email protected]> Reviewed-by: Cédric Le Goater <[email protected]> Signed-off-by: David Gibson <[email protected]>
9ed656631d73a7564dfe178ca8c48bf049098aaf
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/9ed656631d73a7564dfe178ca8c48bf049098aaf
2017-06-09 12:15:57+10:00
target/s390x: rework PGM interrupt psw.addr handling We can tell from the program interrupt code, whether a program interrupt has to forward the address in the PGM new PSW (suppressing/terminated/completed) to point at the next instruction, or if it is nullifying and the PSW address does not have to be incremented. So let's not modify the PSW address outside of the injection path and handle this internally. We just have to handle instruction length auto detection if no valid instruction length can be provided. This should fix various program interrupt injection paths, where the PSW was not properly forwarded. Signed-off-by: David Hildenbrand <[email protected]> Message-Id: <[email protected]> Signed-off-by: Richard Henderson <[email protected]>
becf8217deb2afc347d5172d9f30c8a8964b8b27
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/becf8217deb2afc347d5172d9f30c8a8964b8b27
2017-06-13 11:09:39-07:00
sockets: improve error reporting if UNIX socket path is too long The 'struct sockaddr_un' only allows 108 bytes for the socket path. If the user supplies a path, QEMU uses snprintf() to silently truncate it when too long. This is undesirable because the user will then be unable to connect to the path they asked for. If the user doesn't supply a path, QEMU builds one based on TMPDIR, but if that leads to an overlong path, it mistakenly uses error_setg_errno() with a stale errno value, because snprintf() does not set errno on truncation. In solving this the code needed some refactoring to ensure we don't pass 'un.sun_path' directly to any APIs which expect NUL-terminated strings, because the path is not required to be terminated. Signed-off-by: Daniel P. Berrange <[email protected]> Message-Id: <[email protected]> Reviewed-by: Eric Blake <[email protected]> Signed-off-by: Paolo Bonzini <[email protected]>
ad9579aaa16d5b385922d49edac2c96c79bcfb62
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/ad9579aaa16d5b385922d49edac2c96c79bcfb62
2017-06-07 18:22:02+02:00
target/s390x: fix COMPARE LOGICAL LONG EXTENDED There are multiple issues with the COMPARE LOGICAL LONG EXTENDED instruction: - The test between the two operands is inverted, leading to an inversion of the cc values 1 and 2. - The address and length of an operand continue to be decreased after reaching the end of this operand. These values are then wrong write back to the registers. - We should limit the amount of bytes to process, so that interrupts can be served correctly. At the same time rename dest into src1 and src into src3 to match the operand names and make the code less confusing. Reviewed-by: Richard Henderson <[email protected]> Signed-off-by: Aurelien Jarno <[email protected]> Message-Id: <[email protected]> Signed-off-by: Richard Henderson <[email protected]>
84aa07f109f0afaeeec63c159f3a578b955c3de9
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/84aa07f109f0afaeeec63c159f3a578b955c3de9
2017-06-06 15:20:43-07:00
gluster: add support for PREALLOC_MODE_FALLOC Add missing support for "preallocation=falloc" to the Gluster block driver. This change bases its logic on that of block/file-posix.c and removed the gluster_supports_zerofill() and qemu_gluster_zerofill() functions in favour of #ifdef checks in an easy to read switch-statement. Both glfs_zerofill() and glfs_fallocate() have been introduced with GlusterFS 3.5.0 (pkg-config glusterfs-api = 6). A #define for the availability of glfs_fallocate() has been added to ./configure. Reported-by: Satheesaran Sundaramoorthi <[email protected]> Signed-off-by: Niels de Vos <[email protected]> Message-id: [email protected] URL: https://bugzilla.redhat.com/1450759 Signed-off-by: Niels de Vos <[email protected]> Signed-off-by: Jeff Cody <[email protected]>
df3a429ae82c0f45becdfab105617701d75e0f05
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/df3a429ae82c0f45becdfab105617701d75e0f05
2017-06-02 10:51:47-04:00
memory: tune last param of iommu_ops.translate() This patch converts the old "is_write" bool into IOMMUAccessFlags. The difference is that "is_write" can only express either read/write, but sometimes what we really want is "none" here (neither read nor write). Replay is an good example - during replay, we should not check any RW permission bits since thats not an actual IO at all. CC: Paolo Bonzini <[email protected]> CC: David Gibson <[email protected]> Reviewed-by: David Gibson <[email protected]> Acked-by: David Gibson <[email protected]> Acked-by: Paolo Bonzini <[email protected]> Signed-off-by: Peter Xu <[email protected]> Reviewed-by: Michael S. Tsirkin <[email protected]> Signed-off-by: Michael S. Tsirkin <[email protected]> Reviewed-by: Jason Wang <[email protected]>
bf55b7afce53718ef96f4e6616da62c0ccac37dd
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/bf55b7afce53718ef96f4e6616da62c0ccac37dd
2017-05-25 21:25:27+03:00
xen/9pfs: send responses back to the frontend Once a request is completed, xen_9pfs_push_and_notify gets called. In xen_9pfs_push_and_notify, update the indexes (data has already been copied to the sg by the common code) and send a notification to the frontend. Schedule the bottom-half to check if we already have any other requests pending. Signed-off-by: Stefano Stabellini <[email protected]> CC: [email protected] CC: [email protected] CC: Aneesh Kumar K.V <[email protected]> CC: Greg Kurz <[email protected]>
4476e09e34d4257d2bfbdb70d106a154f42c928b
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/4476e09e34d4257d2bfbdb70d106a154f42c928b
2017-04-25 11:04:33-07:00
sockets: Limit SocketAddressLegacy to external interfaces SocketAddressLegacy is a simple union, and simple unions are awkward: they have their variant members wrapped in a "data" object on the wire, and require additional indirections in C. SocketAddress is the equivalent flat union. Convert all users of SocketAddressLegacy to SocketAddress, except for existing external interfaces. See also commit fce5d53..9445673 and 85a82e8..c5f1ae3. Signed-off-by: Markus Armbruster <[email protected]> Message-Id: <[email protected]> Reviewed-by: Eric Blake <[email protected]> [Minor editing accident fixed, commit message and a comment tweaked] Signed-off-by: Markus Armbruster <[email protected]>
bd269ebc82fbaa5fe7ce5bc7c1770ac8acecd884
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/bd269ebc82fbaa5fe7ce5bc7c1770ac8acecd884
2017-05-09 09:14:40+02:00
vmsvga: fix vmsvga_update_display Fix standard vga mode check: Both s->config and s->enabled must be set to enable vmware command fifo processing. Drop dirty tracking code from the fifo rendering code path, it isn't used anyway because vmsvga turns off dirty tracking when leaving standard vga mode. Signed-off-by: Gerd Hoffmann <[email protected]> Message-id: [email protected] Signed-off-by: Gerd Hoffmann <[email protected]>
104bd1dc707649fe39d0d1405ba7268ebc26edd5
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/104bd1dc707649fe39d0d1405ba7268ebc26edd5
2017-04-24 10:12:28+02:00
s390x/css: introduce read-only property type for device ids Let's introduce a read-only property type that handles device ids of the CssDevId type used for channel devices for future use. e.g. exposing the busid of an I/O subchannel that is assigned to a ccw device. Signed-off-by: Dong Jia Shi <[email protected]> Signed-off-by: Cornelia Huck <[email protected]>
c35fc6aa1840b26f06f9ac79509c7ed9280003ac
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/c35fc6aa1840b26f06f9ac79509c7ed9280003ac
2017-04-21 09:32:09+02:00
cryptodev: fix asserting single queue We already check for queues == 1 in cryptodev_builtin_init and when that is not true raise an error. But before that error is reported the assertion in cryptodev_builtin_cleanup kicks in (because object is being finalized and freed). Let's remove assert(queues == 1) form cryptodev_builtin_cleanup as it does only harm and no good. Reported-by: Boris Fiuczynski <[email protected]> Signed-off-by: Halil Pasic <[email protected]> Reviewed-by: Eric Blake <[email protected]> Signed-off-by: Gonglei <[email protected]>
b7bad50ae81efeb180609eeecdb086ebc7536ed7
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/b7bad50ae81efeb180609eeecdb086ebc7536ed7
2017-03-23 17:22:01+08:00
ide: core: add cleanup function As the pci ahci can be hotplug and unplug, in the ahci unrealize function it should free all the resource once allocated in the realized function. This patch add ide_exit to free the resource. Signed-off-by: Li Qiang <[email protected]> Message-id: [email protected] Signed-off-by: John Snow <[email protected]>
c9f086418a255f386e1c4d2c1418c032eb349537
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/c9f086418a255f386e1c4d2c1418c032eb349537
2017-03-15 20:50:14-04:00
pseries: Don't expose PCIe extended config space on older machine types bb9986452 "spapr_pci: Advertise access to PCIe extended config space" allowed guests to access the extended config space of PCI Express devices via the PAPR interfaces, even though the paravirtualized bus mostly acts like plain PCI. However, that patch enabled access unconditionally, including for existing machine types, which is an unwise change in behaviour. This patch limits the change to pseries-2.9 (and later) machine types. Suggested-by: Andrea Bolognani <[email protected]> Signed-off-by: David Gibson <[email protected]>
82516263cead40ac240ae5fb2a6f5fc0fda9614c
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/82516263cead40ac240ae5fb2a6f5fc0fda9614c
2017-03-14 11:54:17+11:00
filter-rewriter: skip net_checksum_calculate() while offset = 0 While the offset of packets's sequence for primary side and secondary side is zero, it is unnecessary to call net_checksum_calculate() to recalculate the checksume value of packets. Signed-off-by: zhanghailiang <[email protected]> Signed-off-by: Jason Wang <[email protected]>
db0a762e4be965b8976abe9df82c6d47c57336fc
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/db0a762e4be965b8976abe9df82c6d47c57336fc
2017-03-06 11:46:02+08:00
disas/microblaze: Avoid unintended sign extension In read_insn_microblaze() we assemble 4 bytes into an 'unsigned long'. If 'unsigned long' is 64 bits and the high byte has its top bit set, then C's implicit conversion from 'unsigned char' to 'int' for the shift will result in an unintended sign extension which sets the top 32 bits in 'inst'. Add casts to prevent this. (Spotted by Coverity, CID 1005401.) Signed-off-by: Peter Maydell <[email protected]> Reviewed-by: Edgar E. Iglesias <[email protected]> Message-id: [email protected]
1d153a3388b150b8aeedde32242db86b79c45473
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/1d153a3388b150b8aeedde32242db86b79c45473
2017-03-07 14:33:51+00:00
s390x/css: handle format-0 TIC CCW correctly For TIC CCW, bit positions 8-32 of the format-1 CCW must contain zeros; otherwise, a program-check condition is generated. For format-0 TIC CCWs, bits 32-63 are ignored. To convert TIC from format-0 CCW to format-1 CCW correctly, let's clear bits 8-32 to guarantee compatibility. Reviewed-by: Pierre Morel <[email protected]> Signed-off-by: Dong Jia Shi <[email protected]> Signed-off-by: Cornelia Huck <[email protected]>
9f94f84ce7df633142953806cc4c102765cabc0e
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/9f94f84ce7df633142953806cc4c102765cabc0e
2017-02-24 10:15:18+01:00
audio/sdlaudio: Allow audio playback with SDL2 When compiling with SDL2, the semaphore trick used in sdlaudio.c does not work - QEMU locks up completely in this case. To avoid the hang and get at least some audio playback up and running (it's a little bit crackling, but better than nothing), we can use the SDL locking functions SDL_LockAudio() and SDL_UnlockAudio() to sync with the sound playback thread instead. Signed-off-by: Thomas Huth <[email protected]> Message-id: [email protected] Signed-off-by: Gerd Hoffmann <[email protected]>
bcf19777df78193f7cdb108a55db44fd4f20d5b5
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/bcf19777df78193f7cdb108a55db44fd4f20d5b5
2017-03-01 15:12:03+01:00
machine: Convert abstract typename on compat_props to subclass names Original problem description by Greg Kurz: > Since commit "9a4c0e220d8a hw/virtio-pci: fix virtio > behaviour", passing -device virtio-blk-pci.disable-modern=off > has no effect on 2.6 machine types because the internal > virtio-pci.disable-modern=on compat property always prevail. The same bug also affects other abstract type names mentioned on compat_props by machine-types: apic-common, i386-cpu, pci-device, powerpc64-cpu, s390-skeys, spapr-pci-host-bridge, usb-device, virtio-pci, x86_64-cpu. The right fix for this problem is to make sure compat_props and -global options are always applied in the order they are registered, instead of reordering them based on the type hierarchy. But changing the ordering rules of -global is risky and might break existing configurations, so we shouldn't do that on a stable branch. This is a temporary hack that will work around the bug when registering compat_props properties: if we find an abstract class on compat_props, register properties for all its non-abstract subtypes instead. This will make sure -global won't be overridden by compat_props, while keeping the existing ordering rules on -global options. Note that there's one case that won't be fixed by this hack: "-global spapr-pci-vfio-host-bridge.<option>=<value>" won't be able to override compat_props, because spapr-pci-host-bridge is not an abstract class. Signed-off-by: Eduardo Habkost <[email protected]> Message-Id: <[email protected]> Reviewed-by: Cornelia Huck <[email protected]> Reviewed-by: Halil Pasic <[email protected]> Reviewed-by: Greg Kurz <[email protected]> Tested-by: Greg Kurz <[email protected]> Signed-off-by: Eduardo Habkost <[email protected]>
0bcba41fe379e4c6834adcf1456d9099db31a5b2
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/0bcba41fe379e4c6834adcf1456d9099db31a5b2
2017-03-14 16:53:44-03:00
ppc: implement xssubqp instruction xssubqp: VSX Scalar Subtract Quad-Precision. Signed-off-by: Jose Ricardo Ziviani <[email protected]> Signed-off-by: David Gibson <[email protected]>
f6b99afdc33e94cd09ee68979f2db409e7f56517
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/f6b99afdc33e94cd09ee68979f2db409e7f56517
2017-02-22 11:28:27+11:00
cpu-exec: tighten barrier on TCG_EXIT_REQUESTED This seems to have worked just fine so far on weakly-ordered architectures, but I don't see anything that prevents the reordering from: store 1 to exit_request store 1 to tcg_exit_req load tcg_exit_req store 0 to tcg_exit_req load exit_request store 0 to exit_request store 1 to exit_request store 1 to tcg_exit_req to this: store 1 to exit_request store 1 to tcg_exit_req load tcg_exit_req load exit_request store 1 to exit_request store 1 to tcg_exit_req store 0 to tcg_exit_req store 0 to exit_request therefore losing a request. It's possible that other memory barriers (e.g. in rcu_read_unlock) are hiding it, but better safe than sorry. Signed-off-by: Paolo Bonzini <[email protected]>
a70fe14b7dddcb944fbd6c9f3739cd3a22089af5
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/a70fe14b7dddcb944fbd6c9f3739cd3a22089af5
2017-02-16 14:06:56+01:00
intel_iommu: add "caching-mode" option This capability asks the guest to invalidate cache before each map operation. We can use this invalidation to trap map operations in the hypervisor. Signed-off-by: Aviv Ben-David <[email protected]> [peterx: using "caching-mode" instead of "cache-mode" to align with spec] [peterx: re-write the subject to make it short and clear] Reviewed-by: Jason Wang <[email protected]> Signed-off-by: Peter Xu <[email protected]> Signed-off-by: Aviv Ben-David <[email protected]> Reviewed-by: Michael S. Tsirkin <[email protected]> Signed-off-by: Michael S. Tsirkin <[email protected]>
3b40f0e53c2ebfcec8aabab7e91c11c5bd441ac0
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/3b40f0e53c2ebfcec8aabab7e91c11c5bd441ac0
2017-02-17 21:52:31+02:00
coroutine-lock: reschedule coroutine on the AioContext it was running on As a small step towards the introduction of multiqueue, we want coroutines to remain on the same AioContext that started them, unless they are moved explicitly with e.g. aio_co_schedule. This patch avoids that coroutines switch AioContext when they use a CoMutex. For now it does not make much of a difference, because the CoMutex is not thread-safe and the AioContext itself is used to protect the CoMutex from concurrent access. However, this is going to change. Reviewed-by: Stefan Hajnoczi <[email protected]> Signed-off-by: Paolo Bonzini <[email protected]> Reviewed-by: Fam Zheng <[email protected]> Reviewed-by: Daniel P. Berrange <[email protected]> Message-id: [email protected] Signed-off-by: Stefan Hajnoczi <[email protected]>
a9d9235567e7637d474fa9a52432c63c9feeed07
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/a9d9235567e7637d474fa9a52432c63c9feeed07
2017-02-21 11:14:08+00:00
target/ppc: Add Instruction Authority Mask Register Check The instruction authority mask register (IAMR) can be used to restrict permissions for instruction fetch accesses on a per key basis for each of 32 different key values. Access permissions are derived based on the specific key value stored in the relevant page table entry. The IAMR was introduced in, and is present in processors since, POWER8 (ISA v2.07). Thus introduce a function to check access permissions based on the pte key value and the contents of the IAMR when handling a page fault to ensure sufficient access permissions for an instruction fetch. A hash pte contains a key value in bits 2:3|52:54 of the second double word of the pte, this key value gives an index into the IAMR which contains 32 2-bit access masks. If the least significant bit of the 2-bit access mask corresponding to the given key value is set (IAMR[key] & 0x1 == 0x1) then the instruction fetch is not permitted and an ISI is generated accordingly. While we're here, add defines for the srr1 bits to be set for the ISI for clarity. e.g. pte: dw0 [XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX] dw1 [XX01XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX010XXXXXXXXX] ^^ ^^^ key = 01010 (0x0a) IAMR: [XXXXXXXXXXXXXXXXXXXX01XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX] ^^ Access mask = 0b01 Test access mask: 0b01 & 0x1 == 0x1 Least significant bit of the access mask is set, thus the instruction fetch is not permitted. We should generate an instruction storage interrupt (ISI) with bit 42 of SRR1 set to indicate access precluded by virtual page class key protection. Signed-off-by: Suraj Jitindar Singh <[email protected]> [dwg: Move new constants to cpu.h, since they're not MMUv3 specific] Signed-off-by: David Gibson <[email protected]>
a6152b52bc50c5cf1cd118a74b483dd3f0748ebd
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/a6152b52bc50c5cf1cd118a74b483dd3f0748ebd
2017-03-03 11:30:59+11:00
vnc: ensure connection sharing/limits is always configured The connection sharing / limits are only set in the vnc_display_open() method and so missed when VNC is running with '-vnc none'. This in turn prevents clients being added to the VNC server with the QMP "add_client" command. This was introduced in commit e5f34cdd2da54f28d90889a3afd15fad2d6105ff Author: Gerd Hoffmann <[email protected]> Date: Thu Oct 2 12:09:34 2014 +0200 vnc: track & limit connections Signed-off-by: Daniel P. Berrange <[email protected]> Message-id: [email protected] Signed-off-by: Gerd Hoffmann <[email protected]>
12e29b1682e0a50ed57c324152addb585ae5ce69
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/12e29b1682e0a50ed57c324152addb585ae5ce69
2016-08-03 15:06:32+02:00
pci-assign: avoid pointless stat Just check the errno value after fopen and follow it with fstat. This shuts up Coverity's complaint about TOC/TOU violation. Signed-off-by: Paolo Bonzini <[email protected]> Reviewed-by: Eric Blake <[email protected]> Signed-off-by: Michael Tokarev <[email protected]>
9ed2690354e65a87b830f197cac0138e842f989e
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/9ed2690354e65a87b830f197cac0138e842f989e
2017-01-24 23:26:53+03:00
hw/i386: check if nvdimm is enabled before plugging The missing of 'nvdimm' in the machine type option '-M' means NVDIMM is disabled. QEMU should refuse to plug any NVDIMM device in this case and report the misconfiguration. The behavior of NVDIMM on unsupported platform (HW/FW) is vendor specific. For some vendors, it's undefined and the platform may do anything. Thus, I think QEMU is free to choose the implementation. Aborting QEMU (i.e. refusing to boot) is the easiest one. Reported-by: Stefan Hajnoczi <[email protected]> Signed-off-by: Haozhong Zhang <[email protected]> Message-Id: [email protected] Message-Id: [email protected] Reviewed-by: Michael S. Tsirkin <[email protected]> Signed-off-by: Michael S. Tsirkin <[email protected]> Reviewed-by: Xiao Guangrong <[email protected]> Reviewed-by: Eduardo Habkost <[email protected]> Reviewed-by: Stefan Hajnoczi <[email protected]>
e987c37aee1752177906847630d32477da57e705
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/e987c37aee1752177906847630d32477da57e705
2017-02-01 03:37:17+02:00