commit_msg
stringlengths 1
24.2k
| commit_hash
stringlengths 2
84
⌀ | project
stringlengths 2
40
| source
stringclasses 4
values | labels
int64 0
1
| repo_url
stringlengths 26
70
⌀ | commit_url
stringlengths 74
118
⌀ | commit_date
stringlengths 25
25
⌀ |
|---|---|---|---|---|---|---|---|
s390x/kvm: use kvm_gsi_routing_enabled in flic
Let's use kvm_gsi_routing_enabled() to check if kvm supports
KVM_CAP_IRQ_ROUTING in order to avoid a needless ioctl invocation.
Signed-off-by: Fei Li <[email protected]>
Signed-off-by: Cornelia Huck <[email protected]>
|
4cbd6c41fa3aa901e12e8158e8d22dd8f70f7a90
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/4cbd6c41fa3aa901e12e8158e8d22dd8f70f7a90
|
2017-01-20 09:48:09+01:00
|
aspeed: use first FMC flash as a boot ROM
Create a ROM region, using the default size of the mapping window for
the CE0 FMC flash module, and fill it with the flash content.
This is a little hacky but until we can boot from a MMIO region, it
seems difficult to do anything else.
Signed-off-by: Cédric Le Goater <[email protected]>
Reviewed-by: Joel Stanley <[email protected]>
Reviewed-by: Andrew Jeffery <[email protected]>
Message-id: [email protected]
Signed-off-by: Peter Maydell <[email protected]>
|
d769a1da342d6af58adcaf1db2752654963a6a8b
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/d769a1da342d6af58adcaf1db2752654963a6a8b
|
2017-01-20 11:15:08+00:00
|
aio-win32: remove walking_handlers, protecting AioHandler list with list_lock
Reviewed-by: Stefan Hajnoczi <[email protected]>
Signed-off-by: Paolo Bonzini <[email protected]>
Reviewed-by: Fam Zheng <[email protected]>
Message-id: [email protected]
Signed-off-by: Stefan Hajnoczi <[email protected]>
|
b92d9a91abae1569ac499f72fbb90ee7b0ae5398
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/b92d9a91abae1569ac499f72fbb90ee7b0ae5398
|
2017-01-16 13:25:18+00:00
|
net: virtio-net discards TX data after link down
https://bugzilla.redhat.com/show_bug.cgi?id=1295637
Upon set_link monitor command or upon netdev deletion
virtio-net sends link down indication to the guest
and stops vhost if one is used.
Guest driver can still submit data for TX until it
recognizes link loss. If these packets not returned by
the host, the Windows guest will never be able to finish
disable/removal/shutdown.
Now each packet sent by guest after NIC indicated link
down will be completed immediately.
Signed-off-by: Yuri Benditovich <[email protected]>
Reviewed-by: Michael S. Tsirkin <[email protected]>
Signed-off-by: Michael S. Tsirkin <[email protected]>
|
283e2c2adcb80148c7f67d71d52134af80d2fbae
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/283e2c2adcb80148c7f67d71d52134af80d2fbae
|
2017-01-10 07:02:53+02:00
|
tests: virtio-9p: ".." cannot be used to walk out of the shared directory
According to the 9P spec at http://man.cat-v.org/plan_9/5/intro, the
parent directory of the root directory of a server's tree is itself.
This test hence checks that the qid of the root directory as returned by
attach is the same as the qid of ".." when walking from the root directory.
Signed-off-by: Greg Kurz <[email protected]>
|
a37c07022b44e4fc29238deca7588406d081e6c2
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/a37c07022b44e4fc29238deca7588406d081e6c2
|
2017-01-03 17:28:44+01:00
|
xen: fix quad word bufioreq handling
We should not consume the second slot if it didn't get written yet.
Normal writers - i.e. Xen - would not update write_pointer between the
two writes, but the page may get fiddled with by the guest itself, and
we're better off avoiding to enter an infinite loop in that case.
Reported-by: yanghongke <[email protected]>
Signed-off-by: Jan Beulich <[email protected]>
Reviewed-by: Paul Durrant <[email protected]>
Reviewed-by: Stefano Stabellini <[email protected]>
Signed-off-by: Stefano Stabellini <[email protected]>
|
ff3b8b8f864fa5721b196ca3dcc48853b0ee0275
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/ff3b8b8f864fa5721b196ca3dcc48853b0ee0275
|
2016-11-28 11:25:23-08:00
|
nvdimm acpi: rename nvdimm_plugged_device_list
Its behavior has been changed as the nvdimm device which is being
realized also will be handled in this function, so rename it to
reflect the fact
Suggested-by: Igor Mammedov <[email protected]>
Signed-off-by: Xiao Guangrong <[email protected]>
Reviewed-by: Michael S. Tsirkin <[email protected]>
Signed-off-by: Michael S. Tsirkin <[email protected]>
Reviewed-by: Stefan Hajnoczi <[email protected]>
Reviewed-by: Igor Mammedov <[email protected]>
|
cf7c0ff521b0710079aa28f21937fb7dbb3f5224
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/cf7c0ff521b0710079aa28f21937fb7dbb3f5224
|
2016-11-15 17:20:37+02:00
|
acpi nvdimm: rename result_size to dsm_out_buf_siz
Rename it as dsm_out_buf_siz is more descriptive
Suggested-by: Igor Mammedov <[email protected]>
Signed-off-by: Xiao Guangrong <[email protected]>
Reviewed-by: Michael S. Tsirkin <[email protected]>
Signed-off-by: Michael S. Tsirkin <[email protected]>
|
fa1a448dda87c97431d1f177075fbf00ace5f9d8
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/fa1a448dda87c97431d1f177075fbf00ace5f9d8
|
2016-11-01 19:21:08+02:00
|
migration: Fix return code of ram_save_iterate()
qemu_savevm_state_iterate() expects the iterators to return 1
when they are done, and 0 if there is still something left to do.
However, ram_save_iterate() does not obey this rule and returns
the number of saved pages instead. This causes a fatal hang with
ppc64 guests when you run QEMU like this (also works with TCG):
qemu-img create -f qcow2 /tmp/test.qcow2 1M
qemu-system-ppc64 -nographic -nodefaults -m 256 \
-hda /tmp/test.qcow2 -serial mon:stdio
... then switch to the monitor by pressing CTRL-a c and try to
save a snapshot with "savevm test1" for example.
After the first iteration, ram_save_iterate() always returns 0 here,
so that qemu_savevm_state_iterate() hangs in an endless loop and you
can only "kill -9" the QEMU process.
Fix it by using proper return values in ram_save_iterate().
Signed-off-by: Thomas Huth <[email protected]>
Reviewed-by: Juan Quintela <[email protected]>
Signed-off-by: Juan Quintela <[email protected]>
|
5c90308f07335451a08c030dc40a9eed4698152b
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/5c90308f07335451a08c030dc40a9eed4698152b
|
2016-11-14 19:35:41+01:00
|
ppc/pnv: add a PnvCore object
This is largy inspired by sPAPRCPUCore with some simplification, no
hotplug for instance. A set of PnvCore objects is added to the PnvChip
and the device tree is populated looping on these cores.
Real HW cpu ids are now generated depending on the chip cpu model, the
chip id and a core mask. The id is propagated to the CPU object, using
properties, to set the SPR_PIR (Processor Identification Register)
Signed-off-by: Cédric Le Goater <[email protected]>
Signed-off-by: David Gibson <[email protected]>
|
d2fd9612eedfbfda8461d1a5f897546e3c457abb
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/d2fd9612eedfbfda8461d1a5f897546e3c457abb
|
2016-10-28 09:38:25+11:00
|
tcg: move locking for tb_invalidate_phys_page_range up
In the linux-user case all things that involve ''l1_map' and PageDesc
tweaks are protected by the memory lock (mmpa_lock). For SoftMMU mode
we previously relied on single threaded behaviour, with MTTCG we now use
the tb_lock().
As a result we need to do a little re-factoring and push the taking of
this lock up the call tree. This requires a slightly different entry for
the SoftMMU and user-mode cases from tb_invalidate_phys_range.
This also means user-mode breakpoint insertion needs to take two locks
but it hadn't taken any previously so this is an improvement.
Signed-off-by: Alex Bennée <[email protected]>
Message-Id: <[email protected]>
Signed-off-by: Paolo Bonzini <[email protected]>
|
ba051fb5e56d5ff5e4fa672d37954452e58543b2
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/ba051fb5e56d5ff5e4fa672d37954452e58543b2
|
2016-10-31 15:00:25+01:00
|
nbd: Implement NBD_CMD_WRITE_ZEROES on client
Upstream NBD protocol recently added the ability to efficiently
write zeroes without having to send the zeroes over the wire,
along with a flag to control whether the client wants a hole.
The generic block code takes care of falling back to the obvious
write of lots of zeroes if we return -ENOTSUP because the server
does not have WRITE_ZEROES.
Ideally, since NBD_CMD_WRITE_ZEROES does not involve any data
over the wire, we want to support transactions that are much
larger than the normal 32M limit imposed on NBD_CMD_WRITE. But
the server may still have a limit smaller than UINT_MAX, so
until experimental NBD protocol additions for advertising various
command sizes is finalized (see [1], [2]), for now we just stick to
the same limits as normal writes.
[1] https://github.com/yoe/nbd/blob/extension-info/doc/proto.md
[2] https://sourceforge.net/p/nbd/mailman/message/35081223/
Signed-off-by: Eric Blake <[email protected]>
Message-Id: <[email protected]>
Signed-off-by: Paolo Bonzini <[email protected]>
|
fa778fffdfafce811bba3dd97de41fb524b861f7
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/fa778fffdfafce811bba3dd97de41fb524b861f7
|
2016-11-02 09:28:56+01:00
|
qapi: rename QmpInputVisitor to QObjectInputVisitor
The QmpInputVisitor has no direct dependency on QMP. It is
valid to use it anywhere that one has a QObject. Rename it
to better reflect its functionality as a generic QObject
to QAPI converter.
The previous commit renamed the files, this one renames C identifiers.
Reviewed-by: Kevin Wolf <[email protected]>
Reviewed-by: Eric Blake <[email protected]>
Signed-off-by: Daniel P. Berrange <[email protected]>
Message-Id: <[email protected]>
Reviewed-by: Markus Armbruster <[email protected]>
[Straightforwardly rebased, split into file and identifier rename]
Signed-off-by: Markus Armbruster <[email protected]>
|
09e68369a88d7de0f988972bf28eec1b80cc47f9
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/09e68369a88d7de0f988972bf28eec1b80cc47f9
|
2016-10-25 16:25:54+02:00
|
block: only call aio_poll on the current thread's AioContext
aio_poll is not thread safe; for example bdrv_drain can hang if
the last in-flight I/O operation is completed in the I/O thread after
the main thread has checked bs->in_flight.
The bug remains latent as long as all of it is called within
aio_context_acquire/aio_context_release, but this will change soon.
To fix this, if bdrv_drain is called from outside the I/O thread,
signal the main AioContext through a dummy bottom half. The event
loop then only runs in the I/O thread.
Reviewed-by: Fam Zheng <[email protected]>
Signed-off-by: Paolo Bonzini <[email protected]>
Message-Id: <[email protected]>
Signed-off-by: Fam Zheng <[email protected]>
|
c9d1a56174339b0afdef63b7d151b38f4bb6dae5
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/c9d1a56174339b0afdef63b7d151b38f4bb6dae5
|
2016-10-28 21:50:18+08:00
|
block: change drain to look only at one child at a time
bdrv_requests_pending is checking children to also wait until internal
requests (such as metadata writes) have completed. However, checking
children is in general overkill. Children requests can be of two kinds:
- requests caused by an operation on bs, e.g. a bdrv_aio_write to bs
causing a write to bs->file->bs. In this case, the parent's in_flight
count will always be incremented by at least one for every request in
the child.
- asynchronous metadata writes or flushes. Such writes can be started
even if bs's in_flight count is zero, but not after the .bdrv_drain
callback has been invoked.
This patch therefore changes bdrv_drain to finish I/O in the parent
(after which the parent's in_flight will be locked to zero), call
bdrv_drain (after which the parent will not generate I/O on the child
anymore), and then wait for internal I/O in the children to complete.
Signed-off-by: Paolo Bonzini <[email protected]>
Reviewed-by: Fam Zheng <[email protected]>
Message-Id: <[email protected]>
Signed-off-by: Fam Zheng <[email protected]>
|
d42cf28837801cd1f835089fe9db2a42a1af55cd
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/d42cf28837801cd1f835089fe9db2a42a1af55cd
|
2016-10-28 21:50:18+08:00
|
qemu-nbd: Add --fork option
Using the --fork option, one can make qemu-nbd fork the worker process.
The original process will exit on error of the worker or once the worker
enters the main loop.
Suggested-by: Sascha Silbe <[email protected]>
Signed-off-by: Max Reitz <[email protected]>
Signed-off-by: Kevin Wolf <[email protected]>
|
ffb31e1da7d3e044649717c4ebcb1768b5b44299
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/ffb31e1da7d3e044649717c4ebcb1768b5b44299
|
2016-10-24 17:54:03+02:00
|
crypto: add mode check in qcrypto_cipher_new() for cipher-builtin
Signed-off-by: Gonglei <[email protected]>
Signed-off-by: Daniel P. Berrange <[email protected]>
|
77cf26cd89c6e6947fe856a079061cebaecd5435
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/77cf26cd89c6e6947fe856a079061cebaecd5435
|
2016-10-19 10:09:24+01:00
|
translate-all.c: Compute L1 page table properties at runtime
Remove L1 page mapping table properties computing
statically using macros which is dependent on
TARGET_PAGE_BITS. Drop macros V_L1_SIZE, V_L1_SHIFT,
V_L1_BITS macros and replace with variables which are
computed at early stage of VM boot.
Removing dependency can help to make TARGET_PAGE_BITS
dynamic.
Signed-off-by: Vijaya Kumar K <[email protected]>
Message-id: [email protected]
[PMM:
assert(v_l1_shift % V_L2_BITS == 0)
cache v_l2_levels
initialize from page_init() rather than vl.c
minor code style fixes
put v_l1_size into a local where used as a loop limit]
Reviewed-by: Richard Henderson <[email protected]>
Signed-off-by: Peter Maydell <[email protected]>
|
66ec9f49399f0a9fa13ee77c472caba0de2773fc
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/66ec9f49399f0a9fa13ee77c472caba0de2773fc
|
2016-10-24 16:26:49+01:00
|
linux-user: disable unicore32 linux-user build
In order to cleanup linux-user, we need support for most relatively
modern syscalls. unicore32 lacks support for syscalls like
epoll_pwait, preventing cleaning up the CONFIG_EPOLL mess.
This patch can be reverted when unicore32 starts either supporting
the syscalls as defined in mainline kernel, or the oldabi interface
gains support for syscalls supported since at kernel 2.6.19 / glibc 2.6
Cc: MPRC <[email protected]>
Cc: Xuetao Guan <[email protected]>
Signed-off-by: Riku Voipio <[email protected]>
|
5e2b40f7271cf9d02960944d5e0ce233a3dac5b7
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/5e2b40f7271cf9d02960944d5e0ce233a3dac5b7
|
2016-10-21 15:20:14+03:00
|
target-ppc/kvm: Enable transactional memory on POWER8 with KVM-HV, too
Transactional memory is also supported on POWER8 KVM-HV if the
KVM_CAP_PPC_HTM is not available in the kernel yet, so add a hack
to allow TM here, too.
Signed-off-by: Thomas Huth <[email protected]>
Signed-off-by: David Gibson <[email protected]>
|
7f516c9675285298826d4ef20ce1a093b13caf89
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/7f516c9675285298826d4ef20ce1a093b13caf89
|
2016-10-05 11:05:28+11:00
|
Postcopy vs xbzrle: Don't send xbzrle pages once in postcopy [for 2.8]
xbzrle relies on reading pages that have already been sent
to the destination and then applying the modifications; we can't
do that in postcopy because the destination may well have
modified the page already or the page has been discarded.
I already didn't allow reception of xbzrle pages, but I
forgot to add the test to stop them being sent.
Enabling both xbzrle and postcopy can make some sense;
if you think that your migration might finish if you
have xbzrle, then when it doesn't complete you flick
over to postcopy and stop xbzrle'ing.
This corresponds to RH bug:
https://bugzilla.redhat.com/show_bug.cgi?id=1368422
Symptom is:
Unknown combination of migration flags: 0x60 (postcopy mode)
(either 0x60 or 0x40)
Signed-off-by: Dr. David Alan Gilbert <[email protected]>
Reviewed-by: Juan Quintela <[email protected]>
Signed-off-by: Juan Quintela <[email protected]>
|
2ebeaec012b4e5695612774c44f14c61ab46c72c
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/2ebeaec012b4e5695612774c44f14c61ab46c72c
|
2016-10-13 17:23:53+02:00
|
linux-user: remove #define smp_{cores, threads}
Those are unneeded now that CPUState nr_{cores,threads} is always
initialized.
Signed-off-by: Marc-André Lureau <[email protected]>
Reviewed-by: Eduardo Habkost <[email protected]>
Acked-by: David Gibson <[email protected]>
Signed-off-by: Eduardo Habkost <[email protected]>
|
eab60fb9f5e7bb6738b0619cfd0057d3a9d21330
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/eab60fb9f5e7bb6738b0619cfd0057d3a9d21330
|
2016-09-27 16:17:17-03:00
|
vl: Switch qemu_uuid to QemuUUID
Update all qemu_uuid users as well, especially get rid of the duplicated
low level g_strdup_printf, sscanf and snprintf calls with QEMU UUID API.
Since qemu_uuid_parse is quite tangled with qemu_uuid, its switching to
QemuUUID is done here too to keep everything in sync and avoid code
churn.
Signed-off-by: Fam Zheng <[email protected]>
Reviewed-by: Eric Blake <[email protected]>
Reviewed-by: Jeff Cody <[email protected]>
Message-Id: <[email protected]>
|
9c5ce8db2e5c2769ed2fd3d91928dd1853b5ce7c
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/9c5ce8db2e5c2769ed2fd3d91928dd1853b5ce7c
|
2016-09-23 11:42:52+08:00
|
linux-user: Recheck for pending synchronous signals too
In process_pending_signals() we restart the scan of possible
pending signals after calling handle_pending_signal() in
case some other signal has been generated. This rescan
should also include a check for a new synchronous signal
since those are in fact the only kind of new signal that
the signal frame setup process might produce.
Reviewed-by: Richard Henderson <[email protected]>
Signed-off-by: Peter Maydell <[email protected]>
Signed-off-by: Riku Voipio <[email protected]>
|
8bd3773cce1885c46e5cf09a72b9138ccba5fbf2
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/8bd3773cce1885c46e5cf09a72b9138ccba5fbf2
|
2016-09-21 21:51:49+03:00
|
linux-user: Remove unnecessary nptl_flags variable from do_fork()
The 'nptl_flags' variable in do_fork() is set to a copy of
'flags', and then the CLONE_NPTL_FLAGS are cleared out of 'flags'.
However the only effect of this is that the later check on
"if (flags & CLONE_PARENT_SETTID)" is never true. Since we
will already have done the setting of parent_tidptr in clone_func()
in the child thread, we don't need to do it again.
Delete the dead if() and the clearing of CLONE_NPTL_FLAGS from
'flags', and then use 'flags' where we were previously using
'nptl_flags', so we can delete the unnecessary variable.
Signed-off-by: Peter Maydell <[email protected]>
Signed-off-by: Riku Voipio <[email protected]>
|
7cfbd386b92e93fbfae033b9ac89a20d1fe72573
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/7cfbd386b92e93fbfae033b9ac89a20d1fe72573
|
2016-09-21 22:14:18+03:00
|
target-i386: remove helper_lock()
It's been superseded by the atomic helpers.
The use of the atomic helpers provides a significant performance and scalability
improvement. Below is the result of running the atomic_add-test microbenchmark with:
$ x86_64-linux-user/qemu-x86_64 tests/atomic_add-bench -o 5000000 -r $r -n $n
, where $n is the number of threads and $r is the allowed range for the additions.
The scenarios measured are:
- atomic: implements x86' ADDL with the atomic_add helper (i.e. this patchset)
- cmpxchg: implement x86' ADDL with a TCG loop using the cmpxchg helper
- master: before this patchset
Results sorted in ascending range, i.e. descending degree of contention.
Y axis is Throughput in Mops/s. Tests are run on an AMD machine with 64
Opteron 6376 cores.
atomic_add-bench: 5000000 ops/thread, [0,1] range
25 ++---------+----------+---------+----------+----------+----------+---++
+ atomic +-E--+ + + + + + |
|cmpxchg +-H--+ |
20 +Emaster +-N--+ ++
|| |
|++ |
|| |
15 +++ ++
|N| |
|+| |
10 ++| ++
|+|+ |
| | -+E+------ +++ ---+E+------+E+------+E+-----+E+------+E|
|+E+E+- +++ +E+------+E+-- |
5 ++|+ ++
|+N+H+--- +++ |
++++N+--+H++----+++ + +++ --++H+------+H+------+H++----+H+---+--- |
0 ++---------+-----H----+---H-----+----------+----------+----------+---H+
0 10 20 30 40 50 60
Number of threads
atomic_add-bench: 5000000 ops/thread, [0,2] range
25 ++---------+----------+---------+----------+----------+----------+---++
++atomic +-E--+ + + + + + |
|cmpxchg +-H--+ |
20 ++master +-N--+ ++
|E| |
|++ |
||E |
15 ++| ++
|N|| |
|+|| ---+E+------+E+-----+E+------+E|
10 ++| | ---+E+------+E+-----+E+--- +++ +++
||H+E+--+E+-- |
|+++++ |
| || |
5 ++|+H+-- +++ ++
|+N+ - ---+H+------+H+------ |
+ +N+--+H++----+H+---+--+H+----++H+--- + + +H+---+--+H|
0 ++---------+----------+---------+----------+----------+----------+---++
0 10 20 30 40 50 60
Number of threads
atomic_add-bench: 5000000 ops/thread, [0,8] range
40 ++---------+----------+---------+----------+----------+----------+---++
++atomic +-E--+ + + + + + |
35 +cmpxchg +-H--+ ++
| master +-N--+ ---+E+------+E+------+E+-----+E+------+E|
30 ++| ---+E+-- +++ ++
| | -+E+--- |
25 ++E ---- +++ ++
|+++++ -+E+ |
20 +E+ E-- +++ ++
|H|+++ |
|+| +H+------- |
15 ++H+ ---+++ +H+------ ++
|N++H+-- +++--- +H+------++|
10 ++ +++ - +++ ---+H+ +++ +H+
| | +H+-----+H+------+H+-- |
5 ++| +++ ++
++N+N+--+N++ + + + + + |
0 ++---------+----------+---------+----------+----------+----------+---++
0 10 20 30 40 50 60
Number of threads
atomic_add-bench: 5000000 ops/thread, [0,128] range
160 ++---------+---------+----------+---------+----------+----------+---++
+ atomic +-E--+ + + + + + |
140 +cmpxchg +-H--+ +++ +++ ++
| master +-N--+ E--------E------+E+------++|
120 ++ --| | +++ E+
| -- +++ +++ ++|
100 ++ - ++
| +++- +++ ++|
80 ++ -+E+ -+H+------+H+------H--------++
| ---- ---- +++ H|
| ---+E+-----+E+- ---+H+ ++|
60 ++ +E+--- +++ ---+H+--- ++
| --+++ ---+H+-- |
40 ++ +E+-+H+--- ++
| +H+ |
20 +EE+ ++
+N+ + + + + + + |
0 ++N-N---N--+---------+----------+---------+----------+----------+---++
0 10 20 30 40 50 60
Number of threads
atomic_add-bench: 5000000 ops/thread, [0,1024] range
350 ++---------+---------+----------+---------+----------+----------+---++
+ atomic +-E--+ + + + + + |
300 +cmpxchg +-H--+ +++
| master +-N--+ +++ ||
| +++ | ----E|
250 ++ | ----E---- ++
| ----E--- | ---+H|
200 ++ -+E+--- +++ ---+H+--- ++
| ---- -+H+-- |
| +E+ +++ ---- +++ |
150 ++ ---+++ ---+H+- ++
| --- -+H+-- |
100 ++ ---+E+ ---- +++ ++
| +++ ---+E+-----+H+- |
| -+E+------+H+-- |
50 ++ +E+ ++
+EE+ + + + + + + |
0 ++N-N---N--+---------+----------+---------+----------+----------+---++
0 10 20 30 40 50 60
Number of threads
hi-res: http://imgur.com/a/fMRmq
For master I stopped measuring master after 8 threads, because there is little
point in measuring the well-known performance collapse of a contended lock.
Reviewed-by: Alex Bennée <[email protected]>
Signed-off-by: Emilio G. Cota <[email protected]>
Message-Id: <[email protected]>
Signed-off-by: Richard Henderson <[email protected]>
|
37b995f6e7a1cb6fa378c5cd4217b9dd9e1fc98b
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/37b995f6e7a1cb6fa378c5cd4217b9dd9e1fc98b
|
2016-10-26 08:29:01-07:00
|
cutils: Remove ppc buffer zero checking
For ppc64le, gcc6 does extremely poorly with the Altivec code.
Moreover, on POWER7 and POWER8, a hand-optimized Altivec version
turns out to be no faster than the revised integer version, and
therefore not worth the effort.
Signed-off-by: Richard Henderson <[email protected]>
Signed-off-by: Paolo Bonzini <[email protected]>
|
43ff5e01ecba41628f68eb3c62fd49e0405fcca9
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/43ff5e01ecba41628f68eb3c62fd49e0405fcca9
|
2016-09-13 19:13:32+02:00
|
char: convert qemu_chr_fe_write to qemu_chr_fe_write_all
The mux chardev was not checking the return value of any
qemu_chr_fe_write() call so would silently loose data
on EAGAIN.
Similarly the qemu_chr_fe_printf method would not check
errors and was not in a position to retry even if it
could check.
Signed-off-by: Daniel P. Berrange <[email protected]>
Message-Id: <[email protected]>
Signed-off-by: Paolo Bonzini <[email protected]>
|
90f998f5f4267a0c22e983f533d19b9de1849283
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/90f998f5f4267a0c22e983f533d19b9de1849283
|
2016-09-13 19:09:43+02:00
|
virtio-bus: Plug devices after features are negotiated
Currently, devices are plugged before features are negotiated.
If the backend doesn't support VIRTIO_F_VERSION_1, the transport
needs to rewind some settings.
This is the case for CCW, for which a post_plugged callback had
been introduced, where max_rev field is just updated if
VIRTIO_F_VERSION_1 is not supported by the backend.
For PCI, implementing post_plugged would be much more
complicated, so it needs to know whether the backend supports
VIRTIO_F_VERSION_1 at plug time.
Currently, nothing is done for PCI. Modern capabilities get
exposed to the guest even if VIRTIO_F_VERSION_1 is not supported
by the backend, which confuses the guest.
This patch replaces existing post_plugged solution with an
approach that fits with both transports.
Features negotiation is performed before ->device_plugged() call.
A pre_plugged callback is introduced so that the transports can
set their supported features.
Cc: Michael S. Tsirkin <[email protected]>
Cc: [email protected]
Tested-by: Cornelia Huck <[email protected]> [ccw]
Reviewed-by: Cornelia Huck <[email protected]>
Reviewed-by: Marcel Apfelbaum <[email protected]>
Signed-off-by: Maxime Coquelin <[email protected]>
|
d1b4259f1ab18af24e6a297edb6a8f71691f3256
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/d1b4259f1ab18af24e6a297edb6a8f71691f3256
|
2016-09-15 17:30:03+03:00
|
block: Accept node-name for blockdev-snapshot-internal-sync
In order to remove the necessity to use BlockBackend names in the
external API, we want to allow node-names everywhere. This converts
blockdev-snapshot-internal-sync to accept a node-name without lifting
the restriction that we're operating at a root node.
In case of an invalid device name, the command returns the GenericError
error class now instead of DeviceNotFound, because this is what
qmp_get_root_bs() returns.
Signed-off-by: Kevin Wolf <[email protected]>
Reviewed-by: Eric Blake <[email protected]>
Reviewed-by: Alberto Garcia <[email protected]>
Reviewed-by: Max Reitz <[email protected]>
|
75dfd402a734e8080fa77a1bcf60ecc46e0e6158
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/75dfd402a734e8080fa77a1bcf60ecc46e0e6158
|
2016-09-05 19:06:47+02:00
|
vhost-user-test: Use libqos instead of pxe-virtio.rom
vhost-user-test relies on iPXE just to initialize the virtio-net
device, and doesn't do any actual packet tx/rx testing.
In addition to that, the test relies on TCG, which is
imcompatible with vhost. The test only worked by accident: a bug
the memory backend initialization made memory regions not have
the DIRTY_MEMORY_CODE bit set in dirty_log_mask.
This changes vhost-user-test to initialize the virtio-net device
using libqos, and not use TCG nor pxe-virtio.rom.
Signed-off-by: Eduardo Habkost <[email protected]>
|
cdafe929615ec5eca71bcd5a3d12bab5678e5886
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/cdafe929615ec5eca71bcd5a3d12bab5678e5886
|
2016-09-05 16:03:47-03:00
|
checkpatch: ignore automatically imported Linux headers
Linux uses tabs for indentation and checkpatch always complained about
automatically imported headers. update-linux-headers.sh could be modified to
expand tabs, but there is no real reason to complain about any ugly code in
Linux headers, so skip all hunk-related checks.
Signed-off-by: Radim Krčmář <[email protected]>
Signed-off-by: Paolo Bonzini <[email protected]>
|
93bf13c6df4d6fd1a889cae890a9570eb00eb8e5
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/93bf13c6df4d6fd1a889cae890a9570eb00eb8e5
|
2016-08-09 22:57:36+02:00
|
optionrom: fix compilation with mingw docker target
Two fixes are needed. First, mingw does not have -D_FORTIFY_SOURCE,
hence --enable-debug disables optimization. This is not acceptable
for ROMs, which should override CFLAGS to force inclusion of -O2.
Second, PE stores global constructors and destructors using the
following linker script snippet:
___CTOR_LIST__ = .; __CTOR_LIST__ = . ;
LONG (-1);*(.ctors); *(.ctor); *(SORT(.ctors.*)); LONG (0);
___DTOR_LIST__ = .; __DTOR_LIST__ = . ;
LONG (-1); *(.dtors); *(.dtor); *(SORT(.dtors.*)); LONG (0);
The LONG directives cause the .img files to be 16 bytes too large;
the recently added check to signrom.py catches this. To fix this,
replace -T and -e options with a linker script.
Signed-off-by: Paolo Bonzini <[email protected]>
|
9d4cd7b4ed413a1371997ce74da39900b2a8473b
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/9d4cd7b4ed413a1371997ce74da39900b2a8473b
|
2016-08-09 22:57:36+02:00
|
virtio: Introduce virtio_add_queue_aio
Using this function instead of virtio_add_queue marks the vq as aio
based. This differentiation will be useful in later patches.
Distinguish between virtqueue processing in the iohandler context and main loop
AioContext. iohandler context is isolated from AioContexts and therefore does
not run during aio_poll().
Signed-off-by: Fam Zheng <[email protected]>
Reviewed-by: Michael S. Tsirkin <[email protected]>
Signed-off-by: Michael S. Tsirkin <[email protected]>
Reviewed-by: Cornelia Huck <[email protected]>
Reviewed-by: Stefan Hajnoczi <[email protected]>
Acked-by: Paolo Bonzini <[email protected]>
|
872dd82c83745a603d2e07a03d34313eb6467ae4
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/872dd82c83745a603d2e07a03d34313eb6467ae4
|
2016-07-21 20:44:19+03:00
|
ast2400: externalize revision numbers
AST2400_A0_SILICON_REV is defined twice. Fix this by including the
definition in the header file as well as the routine to check if a
silicon revision is supported. It will useful to reuse in other
controllers.
Let's add also AST2500_A0_SILICON_REV for future use.
Signed-off-by: Cédric Le Goater <[email protected]>
Message-id: [email protected]
Reviewed-by: Peter Maydell <[email protected]>
Signed-off-by: Peter Maydell <[email protected]>
|
79a9f323a80b802ca98895d1c2d4aaf23cff815a
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/79a9f323a80b802ca98895d1c2d4aaf23cff815a
|
2016-07-14 16:51:39+01:00
|
filter-buffer: fix segfault when starting qemu with status=off property
After commit 338d3f, we support 'status' property for filter object.
The segfault can be triggered by starting qemu with 'status=off' property
for filter, when the s->incoming_queue is NULL, we reference it directly
in qemu_net_queue_flush() which was called in status_changed() callback
function.
We shouldn't trigger status_changed() before the filter was initialized,
We can check the value of 'nf->netdev' to confirm if the filter is
initialized or not, so let's check its value before calling
status_changed().
Signed-off-by: zhanghailiang <[email protected]>
Signed-off-by: Jason Wang <[email protected]>
|
e0a039e50d481dce6b4ee45a29002538a258cd89
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/e0a039e50d481dce6b4ee45a29002538a258cd89
|
2016-04-06 09:52:07+08:00
|
block: Cater to iscsi with non-power-of-2 discard
Dell Equallogic iSCSI SANs have a very unusual advertised geometry:
$ iscsi-inq -e 1 -c $((0xb0)) iscsi://XXX/0
wsnz:0
maximum compare and write length:1
optimal transfer length granularity:0
maximum transfer length:0
optimal transfer length:0
maximum prefetch xdread xdwrite transfer length:0
maximum unmap lba count:30720
maximum unmap block descriptor count:2
optimal unmap granularity:30720
ugavalid:1
unmap granularity alignment:0
maximum write same length:30720
which says that both the maximum and the optimal discard size
is 15M. It is not immediately apparent if the device allows
discard requests not aligned to the optimal size, nor if it
allows discards at a finer granularity than the optimal size.
I tried to find details in the SCSI Commands Reference Manual
Rev. A on what valid values of maximum and optimal sizes are
permitted, but while that document mentions a "Block Limits
VPD Page", I couldn't actually find documentation of that page
or what values it would have, or if a SCSI device has an
advertisement of its minimal unmap granularity. So it is not
obvious to me whether the Dell Equallogic device is compliance
with the SCSI specification.
Fortunately, it is easy enough to support non-power-of-2 sizing,
even if it means we are less efficient than truly possible when
targetting that device (for example, it means that we refuse to
unmap anything that is not a multiple of 15M and aligned to a
15M boundary, even if the device truly does support a smaller
granularity where unmapping actually works).
Reported-by: Peter Lieven <[email protected]>
Signed-off-by: Eric Blake <[email protected]>
Message-Id: <[email protected]>
Acked-by: Stefan Hajnoczi <[email protected]>
Signed-off-by: Paolo Bonzini <[email protected]>
|
b8d0a9804d0bd43c9b662a6917ae9cd514a54dff
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/b8d0a9804d0bd43c9b662a6917ae9cd514a54dff
|
2016-08-03 18:44:57+02:00
|
linux-user: Clean up target_cpu.h header guards
These headers all use TARGET_CPU_H as header guard symbol. Reuse of
the same guard symbol in multiple headers is okay as long as they
cannot be included together.
Since we can avoid guard symbol reuse easily, do so: use guard symbol
$target_TARGET_CPU_H for linux-user/$target/target_cpu.h.
Signed-off-by: Markus Armbruster <[email protected]>
Reviewed-by: Richard Henderson <[email protected]>
|
55c5063c61e030c533b4bca8ef2a2ad26f1bc73a
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/55c5063c61e030c533b4bca8ef2a2ad26f1bc73a
|
2016-07-12 16:19:16+02:00
|
hostmem: detect host backend memory is being used properly
Currently, we use memory_region_is_mapped() to detect if the host
backend memory is being used. This works if the memory is directly
mapped into guest's address space, however, it is not true for
nvdimm as it uses aliased memory region to map the memory. This is
why this bug can happen:
https://bugzilla.redhat.com/show_bug.cgi?id=1352769
Fix it by introduce a new filed, is_mapped, to HostMemoryBackend,
we set/clear this filed accordingly when the device link/unlink to
host backend memory
Signed-off-by: Xiao Guangrong <[email protected]>
Signed-off-by: Paolo Bonzini <[email protected]>
|
2aece63c8a9d2c3a8ff41d2febc4cdeff2633331
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/2aece63c8a9d2c3a8ff41d2febc4cdeff2633331
|
2016-07-13 13:30:04+02:00
|
target-arm/arm-semi.c: In SYS_HEAPINFO use correct type for 'limit'
In commit f5666418c4 most of the SYS_HEAPINFO implementation was
fixed to use target_ulong rather than uint32_t, but the 'limit'
variable was not changed.
Reported-by: Laurent Desnogues <[email protected]>
Reviewed-by: Laurent Desnogues <[email protected]>
Signed-off-by: Peter Maydell <[email protected]>
Message-id: [email protected]
|
90e26f5aacd265257f7de58ee59f72dc36dff40e
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/90e26f5aacd265257f7de58ee59f72dc36dff40e
|
2016-07-07 13:47:00+01:00
|
mptsas: remove unnecessary internal msi state flag
internal flag msi_in_use in unnecessary, msi_uninit() could be called
directly, and msi_enabled() is enough to check device msi state.
cc: Markus Armbruster <[email protected]>
cc: Marcel Apfelbaum <[email protected]>
cc: Paolo Bonzini <[email protected]>
cc: Michael S. Tsirkin <[email protected]>
Reviewed-by: Markus Armbruster <[email protected]>
Signed-off-by: Cao jin <[email protected]>
Reviewed-by: Michael S. Tsirkin <[email protected]>
Signed-off-by: Michael S. Tsirkin <[email protected]>
|
2e2aa31674444b61e79536a90d63a90572e695c8
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/2e2aa31674444b61e79536a90d63a90572e695c8
|
2016-07-05 13:14:41+03:00
|
block: Set request_alignment during .bdrv_refresh_limits()
We want to eventually stick request_alignment alongside other
BlockLimits, but first, we must ensure it is populated at the
same time as all other limits, rather than being a special case
that is set only when a block is first opened.
Add a .bdrv_refresh_limits() to all four of our legacy devices
that will always be sector-only (bochs, cloop, dmg, vvfat), in
spite of their recent conversion to expose a byte interface.
Signed-off-by: Eric Blake <[email protected]>
Reviewed-by: Kevin Wolf <[email protected]>
Reviewed-by: Fam Zheng <[email protected]>
Signed-off-by: Kevin Wolf <[email protected]>
|
a65064816d64db463f4c24bd81dcaad62fee89eb
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/a65064816d64db463f4c24bd81dcaad62fee89eb
|
2016-07-05 16:46:25+02:00
|
vfio: add pcie extended capability support
For vfio pcie device, we could expose the extended capability on
PCIE bus. due to add a new pcie capability at the tail of the chain,
in order to avoid config space overwritten, we introduce a copy config
for parsing extended caps. and rebuild the pcie extended config space.
Signed-off-by: Chen Fan <[email protected]>
Tested-by: Laszlo Ersek <[email protected]>
Signed-off-by: Alex Williamson <[email protected]>
|
325ae8d548ebeee99cbebd38e2ff0909a9081c50
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/325ae8d548ebeee99cbebd38e2ff0909a9081c50
|
2016-06-30 13:00:23-06:00
|
memory: Add reporting of supported page sizes
Every IOMMU has some granularity which MemoryRegionIOMMUOps::translate
uses when translating, however this information is not available outside
the translate context for various checks.
This adds a get_min_page_size callback to MemoryRegionIOMMUOps and
a wrapper for it so IOMMU users (such as VFIO) can know the minimum
actual page size supported by an IOMMU.
As IOMMU MR represents a guest IOMMU, this uses TARGET_PAGE_SIZE
as fallback.
This removes vfio_container_granularity() and uses new helper in
memory_region_iommu_replay() when replaying IOMMU mappings on added
IOMMU memory region.
Signed-off-by: Alexey Kardashevskiy <[email protected]>
Reviewed-by: David Gibson <[email protected]>
Acked-by: Alex Williamson <[email protected]>
[dwg: Removed an unnecessary calculation]
Signed-off-by: David Gibson <[email protected]>
|
f682e9c244af7166225f4a50cc18ff296bb9d43e
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/f682e9c244af7166225f4a50cc18ff296bb9d43e
|
2016-06-22 11:13:09+10:00
|
target-arm: Provide hook to tell GICv3 about changes of security state
The GICv3 CPU interface needs to know when the CPU it is attached
to makes an exception level or mode transition that changes the
security state, because whether it is asserting IRQ or FIQ can change
depending on these things. Provide a mechanism for letting the GICv3
device register a hook to be called on such changes.
Signed-off-by: Peter Maydell <[email protected]>
Reviewed-by: Shannon Zhao <[email protected]>
Tested-by: Shannon Zhao <[email protected]>
Message-id: [email protected]
|
bd7d00fc50c9960876dd194ebf0c88889b53e765
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/bd7d00fc50c9960876dd194ebf0c88889b53e765
|
2016-06-17 15:23:51+01:00
|
block: Allow .bdrv_load/save_vmstate() to return 0/-errno
The return value of .bdrv_load/save_vmstate() can be any non-negative
number in case of success now. It used to be bytes/-errno.
Signed-off-by: Kevin Wolf <[email protected]>
Reviewed-by: Fam Zheng <[email protected]>
Reviewed-by: Eric Blake <[email protected]>
Reviewed-by: Stefan Hajnoczi <[email protected]>
|
b433d9424d271ce68f592590f77dc2b30944d3a5
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/b433d9424d271ce68f592590f77dc2b30944d3a5
|
2016-06-16 15:19:55+02:00
|
target-mips: Add abs2008 flavor of <ABS|NEG>.<S|D>
Updated handling of instructions <ABS|NEG>.<S|D>. Note that legacy
(pre-abs2008) ABS and NEG instructions are arithmetic (and, therefore,
any NaN operand causes signaling invalid operation), while abs2008
ones are non-arithmetic, always and only changing the sign bit, even
for NaN-like operands. Details on these instructions are documented
in [1] p. 35 and 359.
Implementation-wise, abs2008 versions are implemented without helpers,
for simplicity and performance sake.
[1] "MIPS Architecture For Programmers Volume II-A:
The MIPS64 Instruction Set Reference Manual",
Imagination Technologies LTD, Revision 6.04, November 13, 2015
Signed-off-by: Thomas Schwinge <[email protected]>
Signed-off-by: Maciej W. Rozycki <[email protected]>
Signed-off-by: Aleksandar Markovic <[email protected]>
Reviewed-by: Leon Alrae <[email protected]>
Signed-off-by: Leon Alrae <[email protected]>
|
6be77480052b1a71557081896e7080363a8a2f95
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/6be77480052b1a71557081896e7080363a8a2f95
|
2016-06-24 13:41:46+01:00
|
scripts: add muldiv64() checking coccinelle scripts
Signed-off-by: Laurent Vivier <[email protected]>
Signed-off-by: Michael Tokarev <[email protected]>
|
e9d5150739c4e321088eddfe46b88a8654d86eae
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/e9d5150739c4e321088eddfe46b88a8654d86eae
|
2016-06-07 18:02:49+03:00
|
hw/arm/virt: fix limit of 64-bit ACPI/ECAM PCI MMIO range
Set the MMIO range limit field to 'base + size - 1' as required.
Signed-off-by: Ard Biesheuvel <[email protected]>
Reviewed-by: Shannon Zhao <[email protected]>
Message-id: [email protected]
Signed-off-by: Peter Maydell <[email protected]>
|
e40c3d2e7f4b58669a1b4e5dfb684e57c0bf62ce
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/e40c3d2e7f4b58669a1b4e5dfb684e57c0bf62ce
|
2016-06-06 16:59:28+01:00
|
scsi: megasas: use appropriate property buffer size
When setting MegaRAID SAS controller properties via MegaRAID
Firmware Interface(MFI) commands, a user supplied size parameter
is used to set property value. Use appropriate size value to avoid
OOB access issues.
Reported-by: Li Qiang <[email protected]>
Signed-off-by: Prasad J Pandit <[email protected]>
Message-Id: <[email protected]>
Signed-off-by: Paolo Bonzini <[email protected]>
|
1b85898025c4cd95dce673d15e67e60e98e91731
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/1b85898025c4cd95dce673d15e67e60e98e91731
|
2016-05-29 09:11:10+02:00
|
nbd: Don't trim unrequested bytes
Similar to commit df7b97ff, we are mishandling clients that
give an unaligned NBD_CMD_TRIM request, and potentially
trimming bytes that occur before their request; which in turn
can cause potential unintended data loss (unlikely in
practice, since most clients are sane and issue aligned trim
requests). However, while we fixed read and write by switching
to the byte interfaces of blk_, we don't yet have a byte
interface for discard. On the other hand, trim is advisory, so
rounding the user's request to simply ignore the first and last
unaligned sectors (or the entire request, if it is sub-sector
in length) is just fine.
CC: [email protected]
Signed-off-by: Eric Blake <[email protected]>
Message-Id: <[email protected]>
Signed-off-by: Paolo Bonzini <[email protected]>
|
353ab969730742b7392414d62f4ba9632e8cf22c
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/353ab969730742b7392414d62f4ba9632e8cf22c
|
2016-05-29 09:11:10+02:00
|
linux-user: Support for restarting system calls for S390 targets
Update the S390 main loop and sigreturn code:
* on TARGET_ERESTARTSYS, wind guest PC backwards to repeat syscall insn
* set all guest CPU state within signal.c code on sigreturn
* handle TARGET_QEMU_ESIGRETURN in the main loop as the indication
that the main loop should not touch any guest CPU state
Signed-off-by: Timothy Edward Baldwin <[email protected]>
Message-id: 1441497448-32489-33-git-send-email-T.E.Baldwin99@members.leeds.ac.uk
Reviewed-by: Peter Maydell <[email protected]>
[PMM: tweak commit message; remove stray double semicolon; drop
TARGET_USE_ERESTARTSYS define]
Signed-off-by: Peter Maydell <[email protected]>
Signed-off-by: Riku Voipio <[email protected]>
|
47405ab642101c8ea0472ae434ab4bd2bc1fa41f
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/47405ab642101c8ea0472ae434ab4bd2bc1fa41f
|
2016-05-27 14:49:50+03:00
|
vl: Table-based select_vgahw()
Instead of implementing separate check functions for each vga
interface type, add a table enumerating the possible VGA
interfaces.
Reviewed-by: Eric Blake <[email protected]>
Reviewed-by: Marcel Apfelbaum <[email protected]>
Signed-off-by: Eduardo Habkost <[email protected]>
|
8c9a2b71de67742b40870da22abeccab57c81924
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/8c9a2b71de67742b40870da22abeccab57c81924
|
2016-05-20 14:28:52-03:00
|
qemu-io: Add missing option documentation
The Usage: summary is missing several options, but rather than
having to maintain it, it's simpler to just state [OPTIONS],
since the options are spelled out below.
Commit 499afa2 added --image-opts, but forgot to document it in
--help. Likewise for commit 9e8f183 and -d/--discard.
Commit e3aff4f6 put "-o/--offset" in the long opts, but it has
never been honored.
Add a note that '-n' is short for '-t none'.
Commit 9a2d77ad killed the -C option, but forgot to undocument
it for the 'open' subcommand.
Finally, commit 10d9d75 removed -g/--growable, but forgot to
cull it from the valid short options.
Signed-off-by: Eric Blake <[email protected]>
Message-id: [email protected]
Reviewed-by: Max Reitz <[email protected]>
Signed-off-by: Max Reitz <[email protected]>
|
e4e12bb26d9f2e2de02ff888063f41cc1e1b3935
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/e4e12bb26d9f2e2de02ff888063f41cc1e1b3935
|
2016-05-12 15:33:23+02:00
|
target-mips: check CP0 enabled for CACHE instruction also in R6
Signed-off-by: Leon Alrae <[email protected]>
|
40d48212f934d4deab40ffe84a0f9c4c553d4742
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/40d48212f934d4deab40ffe84a0f9c4c553d4742
|
2016-03-30 09:14:00+01:00
|
qmp: Tighten output visitor rules
Tighten assertions in the QMP output visitor, so that:
- qmp_output_get_qobject() can only be called after pairing a
visit_end_* for every visit_start_* (rather than allowing it on
a partially built object)
- qmp_output_get_qobject() cannot be called unless at least one
visit_type_* or visit_start/visit_end pair has occurred since
creation/reset (the accidental return of NULL fixed by commit
ab8bf1d7 would have been much easier to diagnose)
- ensure that we are encountering the expected object or list
type, to provide protection against mismatched push(struct)/
pop(list) or push(list)/pop(struct), similar to the qmp-input
protection added in commit bdd8e6b5.
- ensure that except for the root, 'name' is non-null inside a
dict, and NULL inside a list (this may need changing later if
we add "name.0" support for better error messages for a list,
but for now it makes sure all users are at least consistent)
Signed-off-by: Eric Blake <[email protected]>
Message-Id: <[email protected]>
Signed-off-by: Markus Armbruster <[email protected]>
|
56a6f02b8ce1fe41a2a9077593e46eca7d98267d
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/56a6f02b8ce1fe41a2a9077593e46eca7d98267d
|
2016-05-12 09:47:55+02:00
|
pc-bios/s390-ccw: add more disk layout checks
Experiments showed possibility of few more "misconfigurations" in disk
layout. They are reported now.
Acked-by: Cornelia Huck <[email protected]>
Reviewed-by: David Hildenbrand <[email protected]>
Signed-off-by: Eugene (jno) Dvurechenski <[email protected]>
Signed-off-by: Cornelia Huck <[email protected]>
|
b1be0972f9d0e7b93a8906c977f26aca96a70e6a
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/b1be0972f9d0e7b93a8906c977f26aca96a70e6a
|
2016-03-23 16:13:38+01:00
|
ivshmem: Tighten check of property "size"
If size_t is narrower than 64 bits, passing uint64_t ivshmem_size to
mmap() truncates. Reject such sizes.
Signed-off-by: Markus Armbruster <[email protected]>
Reviewed-by: Marc-André Lureau <[email protected]>
Message-Id: <[email protected]>
|
08183c20b8b0782e4c30156eb7202d1117ca22f5
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/08183c20b8b0782e4c30156eb7202d1117ca22f5
|
2016-03-21 21:29:02+01:00
|
io: use bind() to check for IPv4/6 availability
Currently the test-io-channel-socket.c test uses getifaddrs
to see if an IPv4/6 address is present on any host NIC, as
a way to determine if IPv4/6 sockets can be used. This is
problematic because getifaddrs is not available on Win32.
Rather than testing indirectly via getifaddrs, just create
a socket and try to bind() to the loopback address instead.
Reviewed-by: Paolo Bonzini <[email protected]>
Signed-off-by: Daniel P. Berrange <[email protected]>
|
0a27af918b9cfb7fc1605c66dfc70700be16fab5
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/0a27af918b9cfb7fc1605c66dfc70700be16fab5
|
2016-03-10 17:10:18+00:00
|
block: add generic full disk encryption driver
Add a block driver that is capable of supporting any full disk
encryption format. This utilizes the previously added block
encryption code, and at this time supports the LUKS format.
The driver code is capable of supporting any format supported
by the QCryptoBlock module, so it registers one block driver
for each format. This patch only registers the "luks" driver
since the "qcow" driver is there only for back-compatibility
with existing qcow built-in encryption.
New LUKS compatible volumes can be formatted using qemu-img
with defaults for all settings.
$ qemu-img create --object secret,data=123456,id=sec0 \
-f luks -o key-secret=sec0 demo.luks 10G
Alternatively the cryptographic settings can be explicitly
set
$ qemu-img create --object secret,data=123456,id=sec0 \
-f luks -o key-secret=sec0,cipher-alg=aes-256,\
cipher-mode=cbc,ivgen-alg=plain64,hash-alg=sha256 \
demo.luks 10G
And query its size
$ qemu-img info demo.img
image: demo.img
file format: luks
virtual size: 10G (10737418240 bytes)
disk size: 132K
encrypted: yes
Note that it was not necessary to provide the password
when querying info for the volume. The password is only
required when performing I/O on the volume
All volumes created by this new 'luks' driver should be
capable of being opened by the kernel dm-crypt driver.
The only algorithms listed in the LUKS spec that are
not currently supported by this impl are sha512 and
ripemd160 hashes and cast6 cipher.
Reviewed-by: Eric Blake <[email protected]>
Signed-off-by: Daniel P. Berrange <[email protected]>
[ kwolf - Added #include to resolve conflict with da34e65c ]
Signed-off-by: Kevin Wolf <[email protected]>
|
78368575a63df3ef95653024fa21a91d441b0c8d
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/78368575a63df3ef95653024fa21a91d441b0c8d
|
2016-03-30 12:11:26+02:00
|
replay: character devices
This patch implements record and replay of character devices.
It records chardevs communication in replay mode. Recorded information
include data read from backend and counter of bytes written
from frontend to backend to preserve frontend internal state.
If character device was configured through the command line in record mode,
then in replay mode it should be also added to command line. Backend of
the character device could be changed in replay mode.
Replaying of devices that perform ioctl and get_msgfd operations is not
supported.
gdbstub which also acts as a backend is not recorded to allow controlling
the replaying through gdb. Monitor backends are also not recorded.
Signed-off-by: Pavel Dovgalyuk <[email protected]>
Message-Id: <20160314074436.4980.83856.stgit@PASHA-ISP>
[Add stubs. - Paolo]
Signed-off-by: Paolo Bonzini <[email protected]>
|
33577b47c64435fcc2a1bc01c7e82534256f1fc3
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/33577b47c64435fcc2a1bc01c7e82534256f1fc3
|
2016-03-15 18:23:40+01:00
|
net: ne2000: check ring buffer control registers
Ne2000 NIC uses ring buffer of NE2000_MEM_SIZE(49152)
bytes to process network packets. Registers PSTART & PSTOP
define ring buffer size & location. Setting these registers
to invalid values could lead to infinite loop or OOB r/w
access issues. Add check to avoid it.
Reported-by: Yang Hongke <[email protected]>
Tested-by: Yang Hongke <[email protected]>
Signed-off-by: Prasad J Pandit <[email protected]>
Signed-off-by: Jason Wang <[email protected]>
|
415ab35a441eca767d033a2702223e785b9d5190
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/415ab35a441eca767d033a2702223e785b9d5190
|
2016-03-08 15:34:09+08:00
|
qemu-nbd: don't overlap long option values with short options
When defining values for long options, the normal practice is
to start numbering from 256, to avoid overlap with the range
of valid values for short options.
Reviewed-by: Eric Blake <[email protected]>
Signed-off-by: Daniel P. Berrange <[email protected]>
Signed-off-by: Kevin Wolf <[email protected]>
|
fa8b7ce2c6d9ec80aa54769f2988c830d459486a
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/fa8b7ce2c6d9ec80aa54769f2988c830d459486a
|
2016-02-22 09:50:05+01:00
|
input: linux evdev support
This patch adds support for reading input events directly from linux
evdev devices and forward them to the guest. Unlike virtio-input-host
which simply passes on all events to the guest without looking at them
this will interpret the events and feed them into the qemu input
subsystem.
Therefore this is limited to what the qemu input subsystem and the
emulated input devices are able to handle. Also there is no support for
absolute coordinates (tablet/touchscreen). So we are talking here about
basic mouse and keyboard support.
The advantage is that it'll work without virtio-input drivers in the
guest, the events are delivered to the usual ps/2 or usb input devices
(depending on what the machine happens to have). And for keyboards
qemu is able to switch the keyboard between guest and host on hotkey.
The hotkey is hard-coded for now (both control keys), initialy the
guest owns the keyboard.
Probably most useful when assigning vga devices with vfio and using a
physical monitor instead of vnc/spice/gtk as guest display.
Usage: Add '-input-linux /dev/input/event<nr>' to the qemu command
line. Note that udev has rules which populate /dev/input/by-{id,path}
with static names, which might be more convinient to use.
Signed-off-by: Gerd Hoffmann <[email protected]>
Message-id: [email protected]
|
e0d2bd5195fdc032c8da566027a35a97aaa0394b
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/e0d2bd5195fdc032c8da566027a35a97aaa0394b
|
2016-03-08 12:20:11+01:00
|
fw_cfg: unbreak migration compatibility for 2.4 and earlier machines
When I reviewed Marc's fw_cfg DMA patches, I completely missed that the
way we set dma_enabled would break migration.
Gerd explained the right way (see reference below): dma_enabled should be
set to true by default, and only true->false transitions should be
possible:
- when the user requests that with
-global fw_cfg_mem.dma_enabled=off
or
-global fw_cfg_io.dma_enabled=off
as appropriate for the platform,
- when HW_COMPAT_2_4 dictates it,
- when board code initializes fw_cfg without requesting DMA support.
Cc: Marc Marí <[email protected]>
Cc: Gerd Hoffmann <[email protected]>
Cc: Alexandre DERUMIER <[email protected]>
Cc: [email protected]
Ref: http://thread.gmane.org/gmane.comp.emulators.qemu/390272/focus=391042
Ref: https://bugs.launchpad.net/qemu/+bug/1536487
Suggested-by: Gerd Hoffmann <[email protected]>
Signed-off-by: Laszlo Ersek <[email protected]>
Message-id: [email protected]
Signed-off-by: Gerd Hoffmann <[email protected]>
|
e6915b5f3a874a467a9a65f7ec1d6ef8d251a51a
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/e6915b5f3a874a467a9a65f7ec1d6ef8d251a51a
|
2016-02-26 10:06:40+01:00
|
blockjob: Fix hang in block_job_finish_sync
With a mirror job running on a virtio-blk dataplane disk, sending "q" to
HMP will cause a dead loop in block_job_finish_sync.
This is because the aio_poll() only processes the AIO context of bs
which has no more work to do, while the main loop BH that is scheduled
for setting the job->completed flag is never processed.
Fix this by adding a flag in BlockJob structure, to track which context
to poll for the block job to make progress. Its value is set to true
when block_job_coroutine_complete() is called, and is checked in
block_job_finish_sync to determine which context to poll.
Suggested-by: Stefan Hajnoczi <[email protected]>
Signed-off-by: Fam Zheng <[email protected]>
Message-id: [email protected]
Signed-off-by: Stefan Hajnoczi <[email protected]>
|
794f01414f9f4c4d0c6f1961154674961941c197
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/794f01414f9f4c4d0c6f1961154674961941c197
|
2016-02-09 13:52:26+00:00
|
tpm: avoid clang shifting negative signed warning
clang 3.7.0 on x86_64 warns about the following:
hw/tpm/tpm_tis.c:1000:36: warning: shifting a negative signed value is undefined [-Wshift-negative-value]
tis->loc[c].iface_id = TPM_TIS_IFACE_ID_SUPPORTED_FLAGS1_3;
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
hw/tpm/tpm_tis.c:144:10: note: expanded from macro 'TPM_TIS_IFACE_ID_SUPPORTED_FLAGS1_3'
(~0 << 4)/* all of it is don't care */)
~~ ^
Signed-off-by: Stefan Hajnoczi <[email protected]>
|
886ce6f8b6ede74eb04314ef62d15bcdf5df7ef1
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/886ce6f8b6ede74eb04314ef62d15bcdf5df7ef1
|
2015-11-17 18:35:56+08:00
|
scripts/kvm/kvm_stat: Cleanup of platform detection
s390 machines can also be detected via uname -m, i.e. python's
os.uname, no need for more complicated checks.
Calling uname once and saving its value for multiple checks is
perfectly sufficient. We don't expect the machine's architecture to
change when the script is running anyway.
On multi-cpu systems x86_init currently will get called multiple
times, returning makes sure we don't waste cicles on that.
Signed-off-by: Janosch Frank <[email protected]>
Message-Id: <[email protected]>
Signed-off-by: Paolo Bonzini <[email protected]>
|
8d3b5ddc4e10eeda435c8f9ceecd15cd9ab284e7
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/8d3b5ddc4e10eeda435c8f9ceecd15cd9ab284e7
|
2016-01-26 15:58:12+01:00
|
iotests: 024: Use TEST_IMG override instead of "mv"
Signed-off-by: Fam Zheng <[email protected]>
Reviewed-by: Max Reitz <[email protected]>
Message-id: [email protected]
Signed-off-by: Max Reitz <[email protected]>
|
f19f11896e130f111e0e1e190cb9cded6f627147
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/f19f11896e130f111e0e1e190cb9cded6f627147
|
2016-01-07 21:30:17+01:00
|
blockdev: Error out on negative throttling option values
extract_common_blockdev_options() uses qemu_opt_get_number() to parse
the bps/iops numbers to uint64_t, then converts to double and stores in
ThrottleConfig. The actual parsing is done by strtoull() in
parse_option_number(). Negative numbers are wrapped to large positive
ones, and stored.
We used to reject negative numbers since 7d81c1413c9, but this regressed
when the option parsing code was changed later. Now fix this again.
This time, define an arbitrary large upper limit (1e15), and check the
values so both negative and impractically big numbers are caught and
reported.
Signed-off-by: Fam Zheng <[email protected]>
Reviewed-by: Markus Armbruster <[email protected]>
Reviewed-by: Alberto Garcia <[email protected]>
Signed-off-by: Kevin Wolf <[email protected]>
|
972606c4db826f286f7f475551180502859f49b9
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/972606c4db826f286f7f475551180502859f49b9
|
2016-01-20 13:37:37+01:00
|
ide: ahci: reset ncq object to unused on error
When processing NCQ commands, AHCI device emulation prepares a
NCQ transfer object; To which an aio control block(aiocb) object
is assigned in 'execute_ncq_command'. In case, when the NCQ
command is invalid, the 'aiocb' object is not assigned, and NCQ
transfer object is left as 'used'. This leads to a use after
free kind of error in 'bdrv_aio_cancel_async' via 'ahci_reset_port'.
Reset NCQ transfer object to 'unused' to avoid it.
[Maintainer edit: s/ACHI/AHCI/ in the commit message. --js]
Reported-by: Qinghao Tang <[email protected]>
Signed-off-by: Prasad J Pandit <[email protected]>
Reviewed-by: John Snow <[email protected]>
Message-id: [email protected]
Signed-off-by: John Snow <[email protected]>
|
4ab0359a8ae182a7ac5c99609667273167703fab
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/4ab0359a8ae182a7ac5c99609667273167703fab
|
2016-01-11 14:10:42-05:00
|
block: Pass driver-specific options to .bdrv_refresh_filename()
In order to decide whether a blkdebug: filename can be produced or a
json: one is necessary, blkdebug checked whether bs->options had more
options than just "config", "x-image" or "image" (the latter including
nested options). That doesn't work well when generic block layer options
are present.
This patch passes an option QDict to the driver that contains only
driver-specific options, i.e. the options for the general block layer as
well as child nodes are already filtered out. Works much better this
way.
Signed-off-by: Kevin Wolf <[email protected]>
Reviewed-by: Max Reitz <[email protected]>
Reviewed-by: Alberto Garcia <[email protected]>
|
4cdd01d32ee6fe04f8d909bfd3708be6864873a2
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/4cdd01d32ee6fe04f8d909bfd3708be6864873a2
|
2015-12-18 14:34:42+01:00
|
qapi: Detect collisions in C member names
Detect attempts to declare two object members that would result
in the same C member name, by keying the 'seen' dictionary off
of the C name rather than the qapi name. It also requires passing
info through the check_clash() methods.
This addresses a TODO and fixes the previously-broken
args-name-clash test. The resulting error message demonstrates
the utility of the .describe() method added previously. No change
to generated code.
Signed-off-by: Eric Blake <[email protected]>
Message-Id: <[email protected]>
Signed-off-by: Markus Armbruster <[email protected]>
|
27b60ab93bd1d5d8c85f009aac7a97ffd2c53c86
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/27b60ab93bd1d5d8c85f009aac7a97ffd2c53c86
|
2015-12-17 08:21:27+01:00
|
qapi: Simplify QAPISchemaObjectTypeVariants.check()
Reduce the ugly flat union / simple union conditional by doing just
the essential work here, namely setting self.tag_member.
Move the rest to callers.
Signed-off-by: Markus Armbruster <[email protected]>
Message-Id: <[email protected]>
[rebase to earlier changes that moved tag_member.check() of
alternate types, and tweak commit title and wording]
Signed-off-by: Eric Blake <[email protected]>
Message-Id: <[email protected]>
|
14ff84619c6bb9b729dbf8b127c1e4c56ed8c500
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/14ff84619c6bb9b729dbf8b127c1e4c56ed8c500
|
2015-12-17 08:21:26+01:00
|
snapshot: create bdrv_all_find_snapshot helper
to check that snapshot is available for all loaded block drivers.
The check bs != bs1 in hmp_info_snapshots is an optimization. The check
for availability of this snapshot will return always true as the list
of snapshots was collected from that image.
The patch also ensures proper locking.
Signed-off-by: Denis V. Lunev <[email protected]>
Reviewed-by: Fam Zheng <[email protected]>
Reviewed-by: Juan Quintela <[email protected]>
CC: Stefan Hajnoczi <[email protected]>
CC: Kevin Wolf <[email protected]>
Tested-by: Greg Kurz <[email protected]>
Signed-off-by: Juan Quintela <[email protected]>
|
723ccda1a0eecece8e70dbcdd35a603f6c41a475
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/723ccda1a0eecece8e70dbcdd35a603f6c41a475
|
2015-11-19 11:50:00+01:00
|
migration: factor our snapshottability check in load_vmstate
We should check that all inserted and not read-only images support
snapshotting. This could be made using already invented helper
bdrv_all_can_snapshot().
Signed-off-by: Denis V. Lunev <[email protected]>
Reviewed-by: Juan Quintela <[email protected]>
Reviewed-by: Fam Zheng <[email protected]>
CC: Stefan Hajnoczi <[email protected]>
CC: Kevin Wolf <[email protected]>
Tested-by: Greg Kurz <[email protected]>
Signed-off-by: Juan Quintela <[email protected]>
|
849f96e2f71b52444516a0880fd9d12691b63d20
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/849f96e2f71b52444516a0880fd9d12691b63d20
|
2015-11-19 11:50:00+01:00
|
qapi: Track owner of each object member
Future commits will migrate semantic checking away from parsing
and over to the various QAPISchema*.check() methods. But to
report an error message about an incorrect semantic use of a
member of an object type, it helps to know which type, command,
or event owns the member. In particular, when a member is
inherited from a base type, it is desirable to associate the
member name with the base type (and not the type calling
member.check()).
Rather than packing additional information into the seen array
passed to each member.check() (as in seen[m.name] = {'member':m,
'owner':type}), it is easier to have each member track the name
of the owner type in the first place (keeping things simpler
with the existing seen[m.name] = m). The new member.owner field
is set via a new set_owner() method, called when registering
the members and variants arrays with an object or variant type.
Track only a name, and not the actual type object, to avoid
creating a circular python reference chain.
Note that Variants.set_owner() method does not set the owner
for the tag_member field; this field is set earlier either as
part of an object's non-variant members, or explicitly by
alternates.
The source information is intended for human consumption in
error messages, and a new describe() method is added to access
the resulting information. For example, given the qapi:
{ 'command': 'foo', 'data': { 'string': 'str' } }
an implementation of visit_command() that calls
arg_type.members[0].describe()
will see "'string' (parameter of foo)".
To make the human-readable name of implicit types work without
duplicating efforts, the describe() method has to reverse the
name of implicit types, via the helper _pretty_owner().
No change to generated code.
Signed-off-by: Eric Blake <[email protected]>
Message-Id: <[email protected]>
[Incorrect & unused -wrapper case in _pretty_owner() dropped]
Signed-off-by: Markus Armbruster <[email protected]>
|
88d4ef8b5cbf9d3336564b1d3ac7a91cbe4aee0e
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/88d4ef8b5cbf9d3336564b1d3ac7a91cbe4aee0e
|
2015-12-17 08:21:27+01:00
|
qapi: Check for QAPI collisions involving variant members
Right now, our ad hoc parser ensures that we cannot have a
flat union that introduces any members that would clash with
non-variant members inherited from the union's base type (see
flat-union-clash-member.json). We want QAPISchemaObjectType.check()
to make the same check, so we can later reduce some of the ad
hoc checks.
We already have a map 'seen' of all non-variant members. We
still need to check for collisions between each variant type's
members and the non-variant ones.
To know the variant type's members, we need to call
variant.type.check(). This also detects when a type contains
itself in a variant, exactly like the existing base.check()
detects when a type contains itself as a base. (Except that
we currently forbid anything but a struct as the type of a
variant, so we can't actually trigger this type of loop yet.)
Slight complication: an alternate's variant can have arbitrary
type, but only an object type's check() may be called outside
QAPISchema.check(). We could either skip the call for variants
of alternates, or skip it for non-object types. For now, do
the latter, because it's easier.
Then we call each variant member's check_clash() with the
appropriate 'seen' map. Since members of different variants
can't clash, we have to clone a fresh seen for each variant.
Wrap this in a new helper method
QAPISchemaObjectTypeVariants.check_clash().
Note that cloning 'seen' inside .check_clash() resembles
the one we just removed from .check() in 'qapi: Drop
obsolete tag value collision assertions'; the difference here is
that we are now checking for clashes among the qapi members of
the variant type, rather than for a single clash with the variant
tag name itself.
Note that, by construction, collisions can't actually happen for
simple unions: each variant's type is a wrapper with a single
member 'data', which will never collide with the only non-variant
member 'type'.
For alternates, there's nothing for a variant object type's
members to clash with, and therefore no need to call the new
variants.check_clash().
No change to generated code.
Signed-off-by: Eric Blake <[email protected]>
Message-Id: <[email protected]>
[Commit message tweaked]
Signed-off-by: Markus Armbruster <[email protected]>
|
b807a1e1e3796adaf3ece2f7b69ea5ee28468ff4
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/b807a1e1e3796adaf3ece2f7b69ea5ee28468ff4
|
2015-12-17 08:21:26+01:00
|
cpu: replay instructions sequence
This patch adds calls to replay functions into the icount setup block.
In record mode number of executed instructions is written to the log.
In replay mode number of istructions to execute is taken from the replay log.
When replayed instructions counter is expired qemu_notify_event()
function is called to wake up the iothread.
Reviewed-by: Paolo Bonzini <[email protected]>
Signed-off-by: Pavel Dovgalyuk <[email protected]>
Message-Id: <[email protected]>
Signed-off-by: Paolo Bonzini <[email protected]>
|
8b42704441865611a5ee241ac9fc5cabc47a079b
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/8b42704441865611a5ee241ac9fc5cabc47a079b
|
2015-11-05 12:19:09+01:00
|
cpu-exec: allow temporary disabling icount
This patch is required for deterministic replay to generate an exception
by trying executing an instruction without changing icount.
It adds new flag to TB for disabling icount while translating it.
Signed-off-by: Paolo Bonzini <[email protected]>
Signed-off-by: Pavel Dovgalyuk <[email protected]>
Message-Id: <[email protected]>
Signed-off-by: Paolo Bonzini <[email protected]>
|
56c0269a9ec105d3848d9f900b5e38e6b35e2478
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/56c0269a9ec105d3848d9f900b5e38e6b35e2478
|
2015-11-05 12:19:09+01:00
|
throttle: Use bs->throttle_state instead of bs->io_limits_enabled
There are two ways to check for I/O limits in a BlockDriverState:
- bs->throttle_state: if this pointer is not NULL, it means that this
BDS is member of a throttling group, its ThrottleTimers structure
has been initialized and its I/O limits are ready to be applied.
- bs->io_limits_enabled: if true it means that the throttle_state
pointer is valid _and_ the limits are currently enabled.
The latter is used in several places to check whether a BDS has I/O
limits configured, but what it really checks is whether requests
are being throttled or not. For example, io_limits_enabled can be
temporarily set to false in cases like bdrv_read_unthrottled() without
otherwise touching the throtting configuration of that BDS.
This patch replaces bs->io_limits_enabled with bs->throttle_state in
all cases where what we really want to check is the existence of I/O
limits, not whether they are currently enabled or not.
Signed-off-by: Alberto Garcia <[email protected]>
Signed-off-by: Kevin Wolf <[email protected]>
|
a0d64a61db602696f4f1895a890c65eda5b3b618
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/a0d64a61db602696f4f1895a890c65eda5b3b618
|
2015-11-11 16:25:47+01:00
|
vhost-user: add vhost_user_requires_shm_log()
Check if the backend has VHOST_USER_PROTOCOL_F_LOG_SHMFD feature and
require a shared log.
Signed-off-by: Marc-André Lureau <[email protected]>
Reviewed-by: Michael S. Tsirkin <[email protected]>
Signed-off-by: Michael S. Tsirkin <[email protected]>
Tested-by: Thibaut Collet <[email protected]>
|
1be0ac2109fbaca6e730ac578f0564507d173e2d
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/1be0ac2109fbaca6e730ac578f0564507d173e2d
|
2015-10-22 14:34:49+03:00
|
throttle: test that snapshots move the throttling configuration
If a snapshot is performed on a device that has I/O limits they should
be moved to the target image (the new active layer).
Signed-off-by: Alberto Garcia <[email protected]>
Reviewed-by: Max Reitz <[email protected]>
Signed-off-by: Kevin Wolf <[email protected]>
|
317438e6dba5d7bb44bd867c10993c54b927992b
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/317438e6dba5d7bb44bd867c10993c54b927992b
|
2015-10-16 15:34:29+02:00
|
block/ssh: remove dead code
The "err" label cannot be reached with qp != NULL. Remove the free-ing
of qp and avoid future regressions by removing the initializer.
Signed-off-by: Paolo Bonzini <[email protected]>
ACKed-by: Richard W.M. Jones <[email protected]>
Reviewed-by: Fam Zheng <[email protected]>
Signed-off-by: Michael Tokarev <[email protected]>
|
eab2ac9d3c1675a58989000c2647aa33e440906a
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/eab2ac9d3c1675a58989000c2647aa33e440906a
|
2015-10-08 19:46:01+03:00
|
pc: Set hw_version on all machine classes
In 2012, QEMU had a bug where it exposed QEMU version information to the
guest, meaning a QEMU upgrade would expose different hardware to the
guest OS even if the same machine-type is being used.
The bug was fixed by commit 93bfef4c6e4b23caea9d51e1099d06433d8835a4, on
all machines up to pc-1.0. But we kept introducing the same bug on all
newer machines since then. That means we are breaking guest ABI every
time QEMU was upgraded.
Fix this by setting the hw_version on all PC machines, making sure the
hardware won't change when upgrading QEMU.
Note that QEMU_VERSION was "1.0" in QEMU 1.0, but starting on QEMU
1.1.0, it started following the "x.y.0" pattern. We have to follow it,
to make sure we use the right QEMU_VERSION string from each QEMU
release.
The 2.5 machine classes could have hw_version unset, because the default
value for qemu_get_version() is QEMU_VERSION. But I decided to set it
explicitly to QEMU_VERSION so we don't forget to update it to "2.5.0"
after we release 2.5.0 and create a 2.6 machine class.
Reported-by: Laszlo Ersek <[email protected]>
Reviewed-by: Laszlo Ersek <[email protected]>
Signed-off-by: Eduardo Habkost <[email protected]>
Message-Id: <[email protected]>
Signed-off-by: Paolo Bonzini <[email protected]>
|
de796d93f59d363409dfd9e186ccd64a21f92204
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/de796d93f59d363409dfd9e186ccd64a21f92204
|
2015-11-04 15:02:30+01:00
|
target-arm: Break the TB after ISB to execute self-modified code correctly
If any store instruction writes the code inside the same TB
after this store insn, the execution of the TB must be stopped
to execute new code correctly.
As described in ARMv8 manual D3.4.6 self-modifying code must do an
IC invalidation to be valid, and an ISB after it. So it's enough to end
the TB after ISB instruction on the code translation.
Also this TB break is necessary to take any pending interrupts immediately
after an ISB (as required by ARMv8 ARM D1.14.4).
Signed-off-by: Sergey Sorokin <[email protected]>
[PMM: tweaked commit message and comments slightly]
Reviewed-by: Peter Maydell <[email protected]>
Signed-off-by: Peter Maydell <[email protected]>
|
6df99dec9e81838423d723996e96236693fa31fe
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/6df99dec9e81838423d723996e96236693fa31fe
|
2015-10-16 11:14:52+01:00
|
target-mips: remove wrong checks for recip.fmt and rsqrt.fmt
Instructions recip.{s|d} and rsqrt.{s|d} do not require 64-bit FPU neither
they require any particular mode for its FPU. This patch removes the checks
that may break a program that uses these instructions.
Signed-off-by: Petar Jovanovic <[email protected]>
Reviewed-by: Leon Alrae <[email protected]>
Signed-off-by: Leon Alrae <[email protected]>
|
ca6c7803d2beae43299a80f4549d36579881fc0b
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/ca6c7803d2beae43299a80f4549d36579881fc0b
|
2015-09-18 09:20:48+01:00
|
gtk: check for existing grabs in gd_grab_{pointer,keyboard}
If a grab is already active for our window, do nothing.
If a grab is already active for another window, release it.
Cleanup some checks and ungrab calls in the code which are
not needed any more.
Signed-off-by: Gerd Hoffmann <[email protected]>
Reviewed-by: Marc-André Lureau <[email protected]>
|
aa4f4058ba8cde200e62ef3dafc4e1595f6033e9
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/aa4f4058ba8cde200e62ef3dafc4e1595f6033e9
|
2015-09-15 12:27:39+02:00
|
net: smc91c111: flush packets on RCR register changes
The SOFT_RST or RXEN in the control register can be used as a condition
to unblock the net layer via can_receive(). So check for possible
flushes on RCR changes. This will drop all pending packets on soft
reset or disable which is the functional intent of the can_receive()
logic.
Signed-off-by: Peter Crosthwaite <[email protected]>
Reviewed-by: Fam Zheng <[email protected]>
Tested-by: Richard Purdie <[email protected]>
Message-id: b114d4c96f4afbdaa15f1361d9c07e3021755915.1441873621.git.crosthwaite.peter@gmail.com
Signed-off-by: Stefan Hajnoczi <[email protected]>
|
271a234a2359975101396916f37f3c7d347c61b8
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/271a234a2359975101396916f37f3c7d347c61b8
|
2015-09-17 12:36:03+01:00
|
net/dp8393x: remove check of runt packets
Ethernet requires that messages are at least 64 bytes on the wire. This
limitation does not exist on emulation (no wire message), so remove the
check. Netcard is now able to receive small network packets.
Signed-off-by: Hervé Poussineau <[email protected]>
Reviewed-by: Aurelien Jarno <[email protected]>
Signed-off-by: Leon Alrae <[email protected]>
|
30dfa9a46cd845db3f43f5c11b129f4a50941b02
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/30dfa9a46cd845db3f43f5c11b129f4a50941b02
|
2015-07-28 09:30:09+01:00
|
vnc: fix vnc client authentication
Commit 800567a61 updated the code to the generic crypto API
and mixed up encrypt and decrypt functions in
procotol_client_auth_vnc.
(Used to be: deskey(key, EN0) which encrypts, and was
changed to qcrypto_cipher_decrypt in 800567a61.)
Changed it to qcrypto_cipher_encrypt now.
Signed-off-by: Wolfgang Bumiller <[email protected]>
Signed-off-by: Gerd Hoffmann <[email protected]>
|
a16951375f7669b7faf27f72ca753e25325c5179
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/a16951375f7669b7faf27f72ca753e25325c5179
|
2015-07-14 15:33:48+02:00
|
crypto: introduce generic cipher API & built-in implementation
Introduce a generic cipher API and an implementation of it that
supports only the built-in AES and DES-RFB algorithms.
The test suite checks the supported algorithms + modes to
validate that every backend implementation is actually correctly
complying with the specs.
Signed-off-by: Daniel P. Berrange <[email protected]>
Message-Id: <[email protected]>
Signed-off-by: Paolo Bonzini <[email protected]>
|
ca38a4cc9e36647437b837b346a41981fb8880cd
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/ca38a4cc9e36647437b837b346a41981fb8880cd
|
2015-07-08 13:11:01+02:00
|
qcow2: remove unnecessary check
The value of 'i' is guaranteed to be >= 0
Signed-off-by: Alberto Garcia <[email protected]>
Message-id: [email protected]
Signed-off-by: Stefan Hajnoczi <[email protected]>
|
1bd84ee717bf146c19281cce48a36a2f4d71748d
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/1bd84ee717bf146c19281cce48a36a2f4d71748d
|
2015-07-07 10:31:04+01:00
|
qemu-iotests: s390x: fix test 049, reject negative sizes in QemuOpts
when creating an image qemu-img enable us specifying the size of the
image using -o size=xx options. But when we specify an invalid size
such as a negtive size then different platform gives different result.
parse_option_size() function in util/qemu-option.c will be called to
parse the size, a cast was called in the function to cast the input
(saved as a double in the function) size to an unsigned int64 value,
when the input is a negtive value or exceeds the maximum of uint64, then
the result is undefined.
According to C99 6.3.1.4, the result of converting a floating point
number to an integer that cannot represent the (integer part of) number
is undefined. And sure enough the results are different on x86 and
s390.
C99 Language spec 6.3.1.4 Real floating and integers:
the result of this assignment/cast is undefined if the float is not
in the open interval (-1, U<type>_MAX+1).
Reviewed-by: Max Reitz <[email protected]>
Reviewed-by: Sascha Silbe <[email protected]>
Signed-off-by: Bo Tu <[email protected]>
Signed-off-by: Kevin Wolf <[email protected]>
|
212789925efffe1c552b114321ee74081a7efb03
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/212789925efffe1c552b114321ee74081a7efb03
|
2015-09-04 20:59:48+02:00
|
vfio/pci: Fix RTL8168 NIC quirks
The RTL8168 quirk correctly describes using bit 31 as a signal to
mark a latch/completion, but the code mistakenly uses bit 28. This
causes the Realtek driver to spin on this register for quite a while,
20k cycles on Windows 7 v7.092 driver. Then it gets frustrated and
tries to set the bit itself and spins for another 20k cycles. For
some this still results in a working driver, for others not. About
the only thing the code really does in its current form is protect
the guest from sneaking in writes to the real hardware MSI-X table.
The fix is obviously to use bit 31 as we document that we should.
The other problem doesn't seem to affect current drivers as nobody
seems to use these window registers for writes to the MSI-X table, but
we need to use the stored data when a write is triggered, not the
value of the current write, which only provides the offset.
Note that only the Windows drivers from Realtek seem to use these
registers, the Microsoft drivers provided with Windows 8.1 do not
access them, nor do Linux in-kernel drivers.
Link: https://bugs.launchpad.net/qemu/+bug/1384892
Signed-off-by: Alex Williamson <[email protected]>
Cc: [email protected] # v2.1+
|
69970fcef937bddd7f745efe39501c7716fdfe56
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/69970fcef937bddd7f745efe39501c7716fdfe56
|
2015-07-22 14:56:01-06:00
|
ml605_mmu: Move the hardcoded values to the init function
Move the hard coded register values to the init function.
This also allows the entire reset function to be deleted, as
PVR registers are now preserved on reset.
The hardcoded PVR0 values can be removed as they are setting
the endianness and stack protection, which is already done
or invalid.
Signed-off-by: Alistair Francis <[email protected]>
Reviewed-by: Peter Crosthwaite <[email protected]>
Signed-off-by: Edgar E. Iglesias <[email protected]>
|
a87310a62d1885b8f6d6b5b30227cbd9792d2c3c
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/a87310a62d1885b8f6d6b5b30227cbd9792d2c3c
|
2015-06-21 17:20:16+10:00
|
raw-posix: Introduce hdev_is_sg()
Until now, an SG device was identified only by checking if its path
started with "/dev/sg". Then, hdev_open() would set the bs->sg flag
accordingly. The patch relies on the actual properties of the device
instead of the specified file path.
To this end, test for an SG device (e.g. /dev/sg0) by ensuring that
all of the following holds:
- The specified file name corresponds to a character device
- The device supports the SG_GET_VERSION_NUM ioctl
- The device supports the SG_GET_SCSI_ID ioctl
Signed-off-by: Dimitris Aragiorgis <[email protected]>
Message-id: [email protected]
Signed-off-by: Stefan Hajnoczi <[email protected]>
|
3307ed7b3fac5ba99eb3b84904b0b7cdc3592a61
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/3307ed7b3fac5ba99eb3b84904b0b7cdc3592a61
|
2015-06-23 15:08:52+01:00
|
s390x/migration: Introduce 2.4 machine
The section footer changes commit f68945d42bab ("Add a protective
section footer") and commit 37fb569c0198 ("Disable section footers
on older machine types") broke migration for any non-versioned
machines.
This pinpoints a problem of s390-ccw machines: it needs to
be versioned to be compatible with future changes in common
code data structures such as section footers.
Let's introduce a version scheme for s390-ccw-virtio machines.
We will use the old s390-ccw-virtio name as alias to the latest
version as all existing libvirt XML for the ccw type were expanded
by libvirt to that name.
The only downside of this patch is, that the old alias s390-ccw
will no longer be available as machines can have only one alias,
but it should not really matter.
Cc: Dr. David Alan Gilbert <[email protected]>
Cc: Juan Quintela <[email protected]>
Cc: Boris Fiuczynski <[email protected]>
Cc: Jason J. Herne <[email protected]>
Signed-off-by: Christian Borntraeger <[email protected]>
Message-Id: <[email protected]>
Reviewed-by: Juan Quintela <[email protected]>
Signed-off-by: Cornelia Huck <[email protected]>
|
c4d3c0a2696c09a884b680d15b03325e46656a6c
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/c4d3c0a2696c09a884b680d15b03325e46656a6c
|
2015-07-02 15:35:34+02:00
|
monitor: cleanup parsing of cmd name and cmd arguments
There's too much going on in monitor_parse_command().
Split up the arguments parsing bits into a separate function
monitor_parse_arguments(). Let the original function check for
command validity and sub-commands if any and return data (*cmd)
that the newly introduced function can process and return a
QDict. Also, pass a pointer to the cmdline to track current
parser location.
Suggested-by: Markus Armbruster <[email protected]>
Signed-off-by: Bandan Das <[email protected]>
Acked-by: Luiz Capitulino <[email protected]>
Signed-off-by: Markus Armbruster <[email protected]>
|
ae50212ff717f3d295ebff352eb7d6cc08332b7e
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/ae50212ff717f3d295ebff352eb7d6cc08332b7e
|
2015-06-22 17:40:00+02:00
|
vmdk: Use bdrv_open_image()
Besides standardising on a single interface for opening child nodes,
this patch allows the user to specify options to individual extent
nodes. Overriding file names isn't possible with this yet, so it's of
limited usefulness, but still a step forward.
Signed-off-by: Kevin Wolf <[email protected]>
Reviewed-by: Eric Blake <[email protected]>
Reviewed-by: Max Reitz <[email protected]>
Reviewed-by: Jeff Cody <[email protected]>
|
a646836784a0fc50fee6f9a0d3fb968289714128
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/a646836784a0fc50fee6f9a0d3fb968289714128
|
2015-06-12 16:58:07+02:00
|
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.