CVE ID
stringlengths
13
43
CVE Page
stringlengths
45
48
CWE ID
stringclasses
90 values
codeLink
stringlengths
46
139
commit_id
stringlengths
6
81
commit_message
stringlengths
3
13.3k
func_after
stringlengths
14
241k
func_before
stringlengths
14
241k
lang
stringclasses
3 values
project
stringclasses
309 values
vul
int8
0
1
CVE-2018-11363
https://www.cvedetails.com/cve/CVE-2018-11363/
CWE-125
https://github.com/AndreRenaud/PDFGen/commit/ee58aff6918b8bbc3be29b9e3089485ea46ff956
ee58aff6918b8bbc3be29b9e3089485ea46ff956
jpeg: Fix another possible buffer overrun Found via the clang libfuzzer
int pdf_add_ppm(struct pdf_doc *pdf, struct pdf_object *page, int x, int y, int display_width, int display_height, const char *ppm_file) { struct pdf_object *obj; uint8_t *data; FILE *fp; char line[1024]; unsigned width, height, size; /* Load the PPM file */ fp = fopen(ppm_file, "rb"); if (!fp) return pdf_set_err(pdf, -errno, "Unable to open '%s'", ppm_file); if (!fgets(line, sizeof(line) - 1, fp)) { fclose(fp); return pdf_set_err(pdf, -EINVAL, "Invalid PPM file"); } /* We only support binary ppms */ if (strncmp(line, "P6", 2) != 0) { fclose(fp); return pdf_set_err(pdf, -EINVAL, "Only binary PPM files supported"); } /* Find the width line */ do { if (!fgets(line, sizeof(line) - 1, fp)) { fclose(fp); return pdf_set_err(pdf, -EINVAL, "Unable to find PPM size"); } if (line[0] == '#') continue; if (sscanf(line, "%u %u\n", &width, &height) != 2) { fclose(fp); return pdf_set_err(pdf, -EINVAL, "Unable to find PPM size"); } break; } while (1); /* Skip over the byte-size line */ if (!fgets(line, sizeof(line) - 1, fp)) { fclose(fp); return pdf_set_err(pdf, -EINVAL, "No byte-size line in PPM file"); } if (width > INT_MAX || height > INT_MAX) { fclose(fp); return pdf_set_err(pdf, -EINVAL, "Invalid width/height in PPM file: %ux%u", width, height); } size = width * height * 3; data = malloc(size); if (!data) { fclose(fp); return pdf_set_err(pdf, -ENOMEM, "Unable to allocate memory for RGB data"); } if (fread(data, 1, size, fp) != size) { free(data); fclose(fp); return pdf_set_err(pdf, -EINVAL, "Insufficient RGB data available"); } fclose(fp); obj = pdf_add_raw_rgb24(pdf, data, width, height); free(data); if (!obj) return pdf->errval; return pdf_add_image(pdf, page, obj, x, y, display_width, display_height); }
int pdf_add_ppm(struct pdf_doc *pdf, struct pdf_object *page, int x, int y, int display_width, int display_height, const char *ppm_file) { struct pdf_object *obj; uint8_t *data; FILE *fp; char line[1024]; unsigned width, height, size; /* Load the PPM file */ fp = fopen(ppm_file, "rb"); if (!fp) return pdf_set_err(pdf, -errno, "Unable to open '%s'", ppm_file); if (!fgets(line, sizeof(line) - 1, fp)) { fclose(fp); return pdf_set_err(pdf, -EINVAL, "Invalid PPM file"); } /* We only support binary ppms */ if (strncmp(line, "P6", 2) != 0) { fclose(fp); return pdf_set_err(pdf, -EINVAL, "Only binary PPM files supported"); } /* Find the width line */ do { if (!fgets(line, sizeof(line) - 1, fp)) { fclose(fp); return pdf_set_err(pdf, -EINVAL, "Unable to find PPM size"); } if (line[0] == '#') continue; if (sscanf(line, "%u %u\n", &width, &height) != 2) { fclose(fp); return pdf_set_err(pdf, -EINVAL, "Unable to find PPM size"); } break; } while (1); /* Skip over the byte-size line */ if (!fgets(line, sizeof(line) - 1, fp)) { fclose(fp); return pdf_set_err(pdf, -EINVAL, "No byte-size line in PPM file"); } if (width > INT_MAX || height > INT_MAX) { fclose(fp); return pdf_set_err(pdf, -EINVAL, "Invalid width/height in PPM file: %ux%u", width, height); } size = width * height * 3; data = malloc(size); if (!data) { fclose(fp); return pdf_set_err(pdf, -ENOMEM, "Unable to allocate memory for RGB data"); } if (fread(data, 1, size, fp) != size) { free(data); fclose(fp); return pdf_set_err(pdf, -EINVAL, "Insufficient RGB data available"); } fclose(fp); obj = pdf_add_raw_rgb24(pdf, data, width, height); free(data); if (!obj) return pdf->errval; return pdf_add_image(pdf, page, obj, x, y, display_width, display_height); }
C
PDFGen
0
CVE-2016-0826
https://www.cvedetails.com/cve/CVE-2016-0826/
CWE-264
https://android.googlesource.com/platform/frameworks/av/+/c9ab2b0bb05a7e19fb057e79b36e232809d70122
c9ab2b0bb05a7e19fb057e79b36e232809d70122
Camera: Disallow dumping clients directly Camera service dumps should only be initiated through ICameraService::dump. Bug: 26265403 Change-Id: If3ca4718ed74bf33ad8a416192689203029e2803
CameraService::Client* CameraService::Client::getClientFromCookie(void* user) { BasicClient *basicClient = gCameraService->getClientByIdUnsafe((int) user); Client* client = static_cast<Client*>(basicClient); if (client == NULL) return NULL; if (client->mDestructionStarted) return NULL; return client; }
CameraService::Client* CameraService::Client::getClientFromCookie(void* user) { BasicClient *basicClient = gCameraService->getClientByIdUnsafe((int) user); Client* client = static_cast<Client*>(basicClient); if (client == NULL) return NULL; if (client->mDestructionStarted) return NULL; return client; }
C
Android
0
CVE-2016-10196
https://www.cvedetails.com/cve/CVE-2016-10196/
CWE-119
https://github.com/libevent/libevent/commit/329acc18a0768c21ba22522f01a5c7f46cacc4d5
329acc18a0768c21ba22522f01a5c7f46cacc4d5
evutil_parse_sockaddr_port(): fix buffer overflow @asn-the-goblin-slayer: "Length between '[' and ']' is cast to signed 32 bit integer on line 1815. Is the length is more than 2<<31 (INT_MAX), len will hold a negative value. Consequently, it will pass the check at line 1816. Segfault happens at line 1819. Generate a resolv.conf with generate-resolv.conf, then compile and run poc.c. See entry-functions.txt for functions in tor that might be vulnerable. Please credit 'Guido Vranken' for this discovery through the Tor bug bounty program." Reproducer for gdb (https://gist.github.com/azat/be2b0d5e9417ba0dfe2c): start p (1ULL<<31)+1ULL # $1 = 2147483649 p malloc(sizeof(struct sockaddr)) # $2 = (void *) 0x646010 p malloc(sizeof(int)) # $3 = (void *) 0x646030 p malloc($1) # $4 = (void *) 0x7fff76a2a010 p memset($4, 1, $1) # $5 = 1990369296 p (char *)$4 # $6 = 0x7fff76a2a010 '\001' <repeats 200 times>... set $6[0]='[' set $6[$1]=']' p evutil_parse_sockaddr_port($4, $2, $3) # $7 = -1 Before: $ gdb bin/http-connect < gdb (gdb) $1 = 2147483649 (gdb) (gdb) $2 = (void *) 0x646010 (gdb) (gdb) $3 = (void *) 0x646030 (gdb) (gdb) $4 = (void *) 0x7fff76a2a010 (gdb) (gdb) $5 = 1990369296 (gdb) (gdb) $6 = 0x7fff76a2a010 '\001' <repeats 200 times>... (gdb) (gdb) (gdb) (gdb) Program received signal SIGSEGV, Segmentation fault. __memcpy_sse2_unaligned () at memcpy-sse2-unaligned.S:36 After: $ gdb bin/http-connect < gdb (gdb) $1 = 2147483649 (gdb) (gdb) $2 = (void *) 0x646010 (gdb) (gdb) $3 = (void *) 0x646030 (gdb) (gdb) $4 = (void *) 0x7fff76a2a010 (gdb) (gdb) $5 = 1990369296 (gdb) (gdb) $6 = 0x7fff76a2a010 '\001' <repeats 200 times>... (gdb) (gdb) (gdb) (gdb) $7 = -1 (gdb) (gdb) quit Fixes: #318
addrinfo_from_hostent(const struct hostent *ent, int port, const struct evutil_addrinfo *hints) { int i; struct sockaddr_in sin; struct sockaddr_in6 sin6; struct sockaddr *sa; int socklen; struct evutil_addrinfo *res=NULL, *ai; void *addrp; if (ent->h_addrtype == PF_INET) { memset(&sin, 0, sizeof(sin)); sin.sin_family = AF_INET; sin.sin_port = htons(port); sa = (struct sockaddr *)&sin; socklen = sizeof(struct sockaddr_in); addrp = &sin.sin_addr; if (ent->h_length != sizeof(sin.sin_addr)) { event_warnx("Weird h_length from gethostbyname"); return NULL; } } else if (ent->h_addrtype == PF_INET6) { memset(&sin6, 0, sizeof(sin6)); sin6.sin6_family = AF_INET6; sin6.sin6_port = htons(port); sa = (struct sockaddr *)&sin6; socklen = sizeof(struct sockaddr_in6); addrp = &sin6.sin6_addr; if (ent->h_length != sizeof(sin6.sin6_addr)) { event_warnx("Weird h_length from gethostbyname"); return NULL; } } else return NULL; for (i = 0; ent->h_addr_list[i]; ++i) { memcpy(addrp, ent->h_addr_list[i], ent->h_length); ai = evutil_new_addrinfo_(sa, socklen, hints); if (!ai) { evutil_freeaddrinfo(res); return NULL; } res = evutil_addrinfo_append_(res, ai); } if (res && ((hints->ai_flags & EVUTIL_AI_CANONNAME) && ent->h_name)) { res->ai_canonname = mm_strdup(ent->h_name); if (res->ai_canonname == NULL) { evutil_freeaddrinfo(res); return NULL; } } return res; }
addrinfo_from_hostent(const struct hostent *ent, int port, const struct evutil_addrinfo *hints) { int i; struct sockaddr_in sin; struct sockaddr_in6 sin6; struct sockaddr *sa; int socklen; struct evutil_addrinfo *res=NULL, *ai; void *addrp; if (ent->h_addrtype == PF_INET) { memset(&sin, 0, sizeof(sin)); sin.sin_family = AF_INET; sin.sin_port = htons(port); sa = (struct sockaddr *)&sin; socklen = sizeof(struct sockaddr_in); addrp = &sin.sin_addr; if (ent->h_length != sizeof(sin.sin_addr)) { event_warnx("Weird h_length from gethostbyname"); return NULL; } } else if (ent->h_addrtype == PF_INET6) { memset(&sin6, 0, sizeof(sin6)); sin6.sin6_family = AF_INET6; sin6.sin6_port = htons(port); sa = (struct sockaddr *)&sin6; socklen = sizeof(struct sockaddr_in6); addrp = &sin6.sin6_addr; if (ent->h_length != sizeof(sin6.sin6_addr)) { event_warnx("Weird h_length from gethostbyname"); return NULL; } } else return NULL; for (i = 0; ent->h_addr_list[i]; ++i) { memcpy(addrp, ent->h_addr_list[i], ent->h_length); ai = evutil_new_addrinfo_(sa, socklen, hints); if (!ai) { evutil_freeaddrinfo(res); return NULL; } res = evutil_addrinfo_append_(res, ai); } if (res && ((hints->ai_flags & EVUTIL_AI_CANONNAME) && ent->h_name)) { res->ai_canonname = mm_strdup(ent->h_name); if (res->ai_canonname == NULL) { evutil_freeaddrinfo(res); return NULL; } } return res; }
C
libevent
0
CVE-2011-3363
https://www.cvedetails.com/cve/CVE-2011-3363/
CWE-20
https://github.com/torvalds/linux/commit/70945643722ffeac779d2529a348f99567fa5c33
70945643722ffeac779d2529a348f99567fa5c33
cifs: always do is_path_accessible check in cifs_mount Currently, we skip doing the is_path_accessible check in cifs_mount if there is no prefixpath. I have a report of at least one server however that allows a TREE_CONNECT to a share that has a DFS referral at its root. The reporter in this case was using a UNC that had no prefixpath, so the is_path_accessible check was not triggered and the box later hit a BUG() because we were chasing a DFS referral on the root dentry for the mount. This patch fixes this by removing the check for a zero-length prefixpath. That should make the is_path_accessible check be done in this situation and should allow the client to chase the DFS referral at mount time instead. Cc: [email protected] Reported-and-Tested-by: Yogesh Sharma <[email protected]> Signed-off-by: Jeff Layton <[email protected]> Signed-off-by: Steve French <[email protected]>
static int check2ndT2(struct smb_hdr *pSMB, unsigned int maxBufSize) { struct smb_t2_rsp *pSMBt; int remaining; __u16 total_data_size, data_in_this_rsp; if (pSMB->Command != SMB_COM_TRANSACTION2) return 0; /* check for plausible wct, bcc and t2 data and parm sizes */ /* check for parm and data offset going beyond end of smb */ if (pSMB->WordCount != 10) { /* coalesce_t2 depends on this */ cFYI(1, "invalid transact2 word count"); return -EINVAL; } pSMBt = (struct smb_t2_rsp *)pSMB; total_data_size = get_unaligned_le16(&pSMBt->t2_rsp.TotalDataCount); data_in_this_rsp = get_unaligned_le16(&pSMBt->t2_rsp.DataCount); remaining = total_data_size - data_in_this_rsp; if (remaining == 0) return 0; else if (remaining < 0) { cFYI(1, "total data %d smaller than data in frame %d", total_data_size, data_in_this_rsp); return -EINVAL; } else { cFYI(1, "missing %d bytes from transact2, check next response", remaining); if (total_data_size > maxBufSize) { cERROR(1, "TotalDataSize %d is over maximum buffer %d", total_data_size, maxBufSize); return -EINVAL; } return remaining; } }
static int check2ndT2(struct smb_hdr *pSMB, unsigned int maxBufSize) { struct smb_t2_rsp *pSMBt; int remaining; __u16 total_data_size, data_in_this_rsp; if (pSMB->Command != SMB_COM_TRANSACTION2) return 0; /* check for plausible wct, bcc and t2 data and parm sizes */ /* check for parm and data offset going beyond end of smb */ if (pSMB->WordCount != 10) { /* coalesce_t2 depends on this */ cFYI(1, "invalid transact2 word count"); return -EINVAL; } pSMBt = (struct smb_t2_rsp *)pSMB; total_data_size = get_unaligned_le16(&pSMBt->t2_rsp.TotalDataCount); data_in_this_rsp = get_unaligned_le16(&pSMBt->t2_rsp.DataCount); remaining = total_data_size - data_in_this_rsp; if (remaining == 0) return 0; else if (remaining < 0) { cFYI(1, "total data %d smaller than data in frame %d", total_data_size, data_in_this_rsp); return -EINVAL; } else { cFYI(1, "missing %d bytes from transact2, check next response", remaining); if (total_data_size > maxBufSize) { cERROR(1, "TotalDataSize %d is over maximum buffer %d", total_data_size, maxBufSize); return -EINVAL; } return remaining; } }
C
linux
0
CVE-2014-8106
https://www.cvedetails.com/cve/CVE-2014-8106/
CWE-119
https://git.qemu.org/?p=qemu.git;a=commit;h=bf25983345ca44aec3dd92c57142be45452bd38a
bf25983345ca44aec3dd92c57142be45452bd38a
null
static void cirrus_vga_write_sr(CirrusVGAState * s, uint32_t val) { switch (s->vga.sr_index) { case 0x00: // Standard VGA case 0x01: // Standard VGA case 0x02: // Standard VGA case 0x03: // Standard VGA case 0x04: // Standard VGA s->vga.sr[s->vga.sr_index] = val & sr_mask[s->vga.sr_index]; if (s->vga.sr_index == 1) s->vga.update_retrace_info(&s->vga); break; case 0x06: // Unlock Cirrus extensions val &= 0x17; if (val == 0x12) { s->vga.sr[s->vga.sr_index] = 0x12; } else { s->vga.sr[s->vga.sr_index] = 0x0f; } break; case 0x10: case 0x30: case 0x50: case 0x70: // Graphics Cursor X case 0x90: case 0xb0: case 0xd0: case 0xf0: // Graphics Cursor X s->vga.sr[0x10] = val; s->hw_cursor_x = (val << 3) | (s->vga.sr_index >> 5); break; case 0x11: case 0x31: case 0x51: case 0x71: // Graphics Cursor Y case 0x91: case 0xb1: case 0xd1: case 0xf1: // Graphics Cursor Y s->vga.sr[0x11] = val; s->hw_cursor_y = (val << 3) | (s->vga.sr_index >> 5); break; case 0x07: // Extended Sequencer Mode cirrus_update_memory_access(s); case 0x08: // EEPROM Control case 0x09: // Scratch Register 0 case 0x0a: // Scratch Register 1 case 0x0b: // VCLK 0 case 0x0c: // VCLK 1 case 0x0d: // VCLK 2 case 0x0e: // VCLK 3 case 0x0f: // DRAM Control case 0x12: // Graphics Cursor Attribute case 0x13: // Graphics Cursor Pattern Address case 0x14: // Scratch Register 2 case 0x15: // Scratch Register 3 case 0x16: // Performance Tuning Register case 0x18: // Signature Generator Control case 0x19: // Signature Generator Result case 0x1a: // Signature Generator Result case 0x1b: // VCLK 0 Denominator & Post case 0x1c: // VCLK 1 Denominator & Post case 0x1d: // VCLK 2 Denominator & Post case 0x1e: // VCLK 3 Denominator & Post case 0x1f: // BIOS Write Enable and MCLK select s->vga.sr[s->vga.sr_index] = val; #ifdef DEBUG_CIRRUS printf("cirrus: handled outport sr_index %02x, sr_value %02x\n", s->vga.sr_index, val); #endif break; case 0x17: // Configuration Readback and Extended Control s->vga.sr[s->vga.sr_index] = (s->vga.sr[s->vga.sr_index] & 0x38) | (val & 0xc7); cirrus_update_memory_access(s); break; default: #ifdef DEBUG_CIRRUS printf("cirrus: outport sr_index %02x, sr_value %02x\n", s->vga.sr_index, val); #endif break; } }
static void cirrus_vga_write_sr(CirrusVGAState * s, uint32_t val) { switch (s->vga.sr_index) { case 0x00: // Standard VGA case 0x01: // Standard VGA case 0x02: // Standard VGA case 0x03: // Standard VGA case 0x04: // Standard VGA s->vga.sr[s->vga.sr_index] = val & sr_mask[s->vga.sr_index]; if (s->vga.sr_index == 1) s->vga.update_retrace_info(&s->vga); break; case 0x06: // Unlock Cirrus extensions val &= 0x17; if (val == 0x12) { s->vga.sr[s->vga.sr_index] = 0x12; } else { s->vga.sr[s->vga.sr_index] = 0x0f; } break; case 0x10: case 0x30: case 0x50: case 0x70: // Graphics Cursor X case 0x90: case 0xb0: case 0xd0: case 0xf0: // Graphics Cursor X s->vga.sr[0x10] = val; s->hw_cursor_x = (val << 3) | (s->vga.sr_index >> 5); break; case 0x11: case 0x31: case 0x51: case 0x71: // Graphics Cursor Y case 0x91: case 0xb1: case 0xd1: case 0xf1: // Graphics Cursor Y s->vga.sr[0x11] = val; s->hw_cursor_y = (val << 3) | (s->vga.sr_index >> 5); break; case 0x07: // Extended Sequencer Mode cirrus_update_memory_access(s); case 0x08: // EEPROM Control case 0x09: // Scratch Register 0 case 0x0a: // Scratch Register 1 case 0x0b: // VCLK 0 case 0x0c: // VCLK 1 case 0x0d: // VCLK 2 case 0x0e: // VCLK 3 case 0x0f: // DRAM Control case 0x12: // Graphics Cursor Attribute case 0x13: // Graphics Cursor Pattern Address case 0x14: // Scratch Register 2 case 0x15: // Scratch Register 3 case 0x16: // Performance Tuning Register case 0x18: // Signature Generator Control case 0x19: // Signature Generator Result case 0x1a: // Signature Generator Result case 0x1b: // VCLK 0 Denominator & Post case 0x1c: // VCLK 1 Denominator & Post case 0x1d: // VCLK 2 Denominator & Post case 0x1e: // VCLK 3 Denominator & Post case 0x1f: // BIOS Write Enable and MCLK select s->vga.sr[s->vga.sr_index] = val; #ifdef DEBUG_CIRRUS printf("cirrus: handled outport sr_index %02x, sr_value %02x\n", s->vga.sr_index, val); #endif break; case 0x17: // Configuration Readback and Extended Control s->vga.sr[s->vga.sr_index] = (s->vga.sr[s->vga.sr_index] & 0x38) | (val & 0xc7); cirrus_update_memory_access(s); break; default: #ifdef DEBUG_CIRRUS printf("cirrus: outport sr_index %02x, sr_value %02x\n", s->vga.sr_index, val); #endif break; } }
C
qemu
0
CVE-2013-2911
https://www.cvedetails.com/cve/CVE-2013-2911/
CWE-399
https://github.com/chromium/chromium/commit/0220f39fac21d169a834ef91de362f4169f2eef5
0220f39fac21d169a834ef91de362f4169f2eef5
Avoid reparsing an XSLT stylesheet after the first failure. Certain libxslt versions appear to leave the doc in an invalid state when parsing fails. We should cache this result and avoid re-parsing. (The test cannot be converted to text-only due to its invalid stylesheet). [email protected],[email protected],[email protected] BUG=271939 Review URL: https://chromiumcodereview.appspot.com/23103007 git-svn-id: svn://svn.chromium.org/blink/trunk@156248 bbb929c8-8fbe-4397-9dbb-9b2b20218538
Document* XSLStyleSheet::ownerDocument() { for (XSLStyleSheet* styleSheet = this; styleSheet; styleSheet = styleSheet->parentStyleSheet()) { Node* node = styleSheet->ownerNode(); if (node) return node->document(); } return 0; }
Document* XSLStyleSheet::ownerDocument() { for (XSLStyleSheet* styleSheet = this; styleSheet; styleSheet = styleSheet->parentStyleSheet()) { Node* node = styleSheet->ownerNode(); if (node) return node->document(); } return 0; }
C
Chrome
0
CVE-2017-0555
https://www.cvedetails.com/cve/CVE-2017-0555/
CWE-200
https://android.googlesource.com/platform/external/libavc/+/0b23c81c3dd9ec38f7e6806a3955fed1925541a0
0b23c81c3dd9ec38f7e6806a3955fed1925541a0
Decoder: Fixed initialization of first_slice_in_pic To handle some errors, first_slice_in_pic was being set to 2. This is now cleaned up and first_slice_in_pic is set to 1 only once per pic. This will ensure picture level initializations are done only once even in case of error clips Bug: 33717589 Bug: 33551775 Bug: 33716442 Bug: 33677995 Change-Id: If341436b3cbaa724017eedddd88c2e6fac36d8ba
WORD32 ih264d_reset(iv_obj_t *dec_hdl, void *pv_api_ip, void *pv_api_op) { dec_struct_t * ps_dec; ivd_ctl_reset_op_t *ps_ctl_op = (ivd_ctl_reset_op_t *)pv_api_op; UNUSED(pv_api_ip); ps_ctl_op->u4_error_code = 0; ps_dec = (dec_struct_t *)(dec_hdl->pv_codec_handle); if(ps_dec != NULL) { ih264d_init_decoder(ps_dec); /* memset(ps_dec->disp_bufs, 0, (MAX_DISP_BUFS_NEW) * sizeof(disp_buf_t)); memset(ps_dec->u4_disp_buf_mapping, 0, (MAX_DISP_BUFS_NEW) * sizeof(UWORD32)); memset(ps_dec->u4_disp_buf_to_be_freed, 0, (MAX_DISP_BUFS_NEW) * sizeof(UWORD32)); */ } else { H264_DEC_DEBUG_PRINT( "\nReset called without Initializing the decoder\n"); ps_ctl_op->u4_error_code = ERROR_INIT_NOT_DONE; } return IV_SUCCESS; }
WORD32 ih264d_reset(iv_obj_t *dec_hdl, void *pv_api_ip, void *pv_api_op) { dec_struct_t * ps_dec; ivd_ctl_reset_op_t *ps_ctl_op = (ivd_ctl_reset_op_t *)pv_api_op; UNUSED(pv_api_ip); ps_ctl_op->u4_error_code = 0; ps_dec = (dec_struct_t *)(dec_hdl->pv_codec_handle); if(ps_dec != NULL) { ih264d_init_decoder(ps_dec); /* memset(ps_dec->disp_bufs, 0, (MAX_DISP_BUFS_NEW) * sizeof(disp_buf_t)); memset(ps_dec->u4_disp_buf_mapping, 0, (MAX_DISP_BUFS_NEW) * sizeof(UWORD32)); memset(ps_dec->u4_disp_buf_to_be_freed, 0, (MAX_DISP_BUFS_NEW) * sizeof(UWORD32)); */ } else { H264_DEC_DEBUG_PRINT( "\nReset called without Initializing the decoder\n"); ps_ctl_op->u4_error_code = ERROR_INIT_NOT_DONE; } return IV_SUCCESS; }
C
Android
0
CVE-2017-16359
https://www.cvedetails.com/cve/CVE-2017-16359/
CWE-476
https://github.com/radare/radare2/commit/62e39f34b2705131a2d08aff0c2e542c6a52cf0e
62e39f34b2705131a2d08aff0c2e542c6a52cf0e
Fix #8764 - huge vd_aux caused pointer wraparound
ut64 Elf_(r_bin_elf_v2p) (ELFOBJ *bin, ut64 vaddr) { int i; if (!bin) { return 0; } if (!bin->phdr) { if (bin->ehdr.e_type == ET_REL) { return vaddr - bin->baddr; } return vaddr; } for (i = 0; i < bin->ehdr.e_phnum; ++i) { Elf_(Phdr) *p = &bin->phdr[i]; if (!p) { break; } if (p->p_type == PT_LOAD && is_in_vphdr (p, vaddr)) { if (!p->p_offset && !p->p_vaddr) { continue; } return p->p_offset + vaddr - p->p_vaddr; } } return vaddr; }
ut64 Elf_(r_bin_elf_v2p) (ELFOBJ *bin, ut64 vaddr) { int i; if (!bin) { return 0; } if (!bin->phdr) { if (bin->ehdr.e_type == ET_REL) { return vaddr - bin->baddr; } return vaddr; } for (i = 0; i < bin->ehdr.e_phnum; ++i) { Elf_(Phdr) *p = &bin->phdr[i]; if (!p) { break; } if (p->p_type == PT_LOAD && is_in_vphdr (p, vaddr)) { if (!p->p_offset && !p->p_vaddr) { continue; } return p->p_offset + vaddr - p->p_vaddr; } } return vaddr; }
C
radare2
0
CVE-2017-9211
https://www.cvedetails.com/cve/CVE-2017-9211/
CWE-476
https://github.com/torvalds/linux/commit/9933e113c2e87a9f46a40fde8dafbf801dca1ab9
9933e113c2e87a9f46a40fde8dafbf801dca1ab9
crypto: skcipher - Add missing API setkey checks The API setkey checks for key sizes and alignment went AWOL during the skcipher conversion. This patch restores them. Cc: <[email protected]> Fixes: 4e6c3df4d729 ("crypto: skcipher - Add low-level skcipher...") Reported-by: Baozeng <[email protected]> Signed-off-by: Herbert Xu <[email protected]>
static inline void skcipher_unmap(struct scatter_walk *walk, void *vaddr) { if (PageHighMem(scatterwalk_page(walk))) kunmap_atomic(vaddr); }
static inline void skcipher_unmap(struct scatter_walk *walk, void *vaddr) { if (PageHighMem(scatterwalk_page(walk))) kunmap_atomic(vaddr); }
C
linux
0
CVE-2016-1696
https://www.cvedetails.com/cve/CVE-2016-1696/
CWE-284
https://github.com/chromium/chromium/commit/c0569cc04741cccf6548c2169fcc1609d958523f
c0569cc04741cccf6548c2169fcc1609d958523f
[Extensions] Expand bindings access checks BUG=601149 BUG=601073 Review URL: https://codereview.chromium.org/1866103002 Cr-Commit-Position: refs/heads/master@{#387710}
~DetectedLanguage() {}
~DetectedLanguage() {}
C
Chrome
0
CVE-2016-2324
https://www.cvedetails.com/cve/CVE-2016-2324/
CWE-119
https://github.com/git/git/commit/de1e67d0703894cb6ea782e36abb63976ab07e60
de1e67d0703894cb6ea782e36abb63976ab07e60
list-objects: pass full pathname to callbacks When we find a blob at "a/b/c", we currently pass this to our show_object_fn callbacks as two components: "a/b/" and "c". Callbacks which want the full value then call path_name(), which concatenates the two. But this is an inefficient interface; the path is a strbuf, and we could simply append "c" to it temporarily, then roll back the length, without creating a new copy. So we could improve this by teaching the callsites of path_name() this trick (and there are only 3). But we can also notice that no callback actually cares about the broken-down representation, and simply pass each callback the full path "a/b/c" as a string. The callback code becomes even simpler, then, as we do not have to worry about freeing an allocated buffer, nor rolling back our modification to the strbuf. This is theoretically less efficient, as some callbacks would not bother to format the final path component. But in practice this is not measurable. Since we use the same strbuf over and over, our work to grow it is amortized, and we really only pay to memcpy a few bytes. Signed-off-by: Jeff King <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
static void append_prune_data(struct cmdline_pathspec *prune, const char **av) { while (*av) { ALLOC_GROW(prune->path, prune->nr + 1, prune->alloc); prune->path[prune->nr++] = *(av++); } }
static void append_prune_data(struct cmdline_pathspec *prune, const char **av) { while (*av) { ALLOC_GROW(prune->path, prune->nr + 1, prune->alloc); prune->path[prune->nr++] = *(av++); } }
C
git
0
CVE-2018-17205
https://www.cvedetails.com/cve/CVE-2018-17205/
CWE-617
https://github.com/openvswitch/ovs/commit/0befd1f3745055c32940f5faf9559be6a14395e6
0befd1f3745055c32940f5faf9559be6a14395e6
ofproto: Fix OVS crash when reverting old flows in bundle commit During bundle commit flows which are added in bundle are applied to ofproto in-order. In case if a flow cannot be added (e.g. flow action is go-to group id which does not exist), OVS tries to revert back all previous flows which were successfully applied from the same bundle. This is possible since OVS maintains list of old flows which were replaced by flows from the bundle. While reinserting old flows ovs asserts due to check on rule state != RULE_INITIALIZED. This will work only for new flows, but for old flow the rule state will be RULE_REMOVED. This is causing an assert and OVS crash. The ovs assert check should be modified to != RULE_INSERTED to prevent any existing rule being re-inserted and allow new rules and old rules (in case of revert) to get inserted. Here is an example to trigger the assert: $ ovs-vsctl add-br br-test -- set Bridge br-test datapath_type=netdev $ cat flows.txt flow add table=1,priority=0,in_port=2,actions=NORMAL flow add table=1,priority=0,in_port=3,actions=NORMAL $ ovs-ofctl dump-flows -OOpenflow13 br-test cookie=0x0, duration=2.465s, table=1, n_packets=0, n_bytes=0, priority=0,in_port=2 actions=NORMAL cookie=0x0, duration=2.465s, table=1, n_packets=0, n_bytes=0, priority=0,in_port=3 actions=NORMAL $ cat flow-modify.txt flow modify table=1,priority=0,in_port=2,actions=drop flow modify table=1,priority=0,in_port=3,actions=group:10 $ ovs-ofctl bundle br-test flow-modify.txt -OOpenflow13 First flow rule will be modified since it is a valid rule. However second rule is invalid since no group with id 10 exists. Bundle commit tries to revert (insert) the first rule to old flow which results in ovs_assert at ofproto_rule_insert__() since old rule->state = RULE_REMOVED. Signed-off-by: Vishal Deep Ajmera <[email protected]> Signed-off-by: Ben Pfaff <[email protected]>
ofport_install(struct ofproto *p, struct netdev *netdev, const struct ofputil_phy_port *pp) { const char *netdev_name = netdev_get_name(netdev); struct ofport *ofport; int error; /* Create ofport. */ ofport = p->ofproto_class->port_alloc(); if (!ofport) { error = ENOMEM; goto error; } ofport->ofproto = p; ofport->netdev = netdev; ofport->change_seq = netdev_get_change_seq(netdev); ofport->pp = *pp; ofport->ofp_port = pp->port_no; ofport->created = time_msec(); /* Add port to 'p'. */ hmap_insert(&p->ports, &ofport->hmap_node, hash_ofp_port(ofport->ofp_port)); shash_add(&p->port_by_name, netdev_name, ofport); update_mtu(p, ofport); /* Let the ofproto_class initialize its private data. */ error = p->ofproto_class->port_construct(ofport); if (error) { goto error; } connmgr_send_port_status(p->connmgr, NULL, pp, OFPPR_ADD); return 0; error: VLOG_WARN_RL(&rl, "%s: could not add port %s (%s)", p->name, netdev_name, ovs_strerror(error)); if (ofport) { ofport_destroy__(ofport); } else { netdev_close(netdev); } return error; }
ofport_install(struct ofproto *p, struct netdev *netdev, const struct ofputil_phy_port *pp) { const char *netdev_name = netdev_get_name(netdev); struct ofport *ofport; int error; /* Create ofport. */ ofport = p->ofproto_class->port_alloc(); if (!ofport) { error = ENOMEM; goto error; } ofport->ofproto = p; ofport->netdev = netdev; ofport->change_seq = netdev_get_change_seq(netdev); ofport->pp = *pp; ofport->ofp_port = pp->port_no; ofport->created = time_msec(); /* Add port to 'p'. */ hmap_insert(&p->ports, &ofport->hmap_node, hash_ofp_port(ofport->ofp_port)); shash_add(&p->port_by_name, netdev_name, ofport); update_mtu(p, ofport); /* Let the ofproto_class initialize its private data. */ error = p->ofproto_class->port_construct(ofport); if (error) { goto error; } connmgr_send_port_status(p->connmgr, NULL, pp, OFPPR_ADD); return 0; error: VLOG_WARN_RL(&rl, "%s: could not add port %s (%s)", p->name, netdev_name, ovs_strerror(error)); if (ofport) { ofport_destroy__(ofport); } else { netdev_close(netdev); } return error; }
C
ovs
0
CVE-2011-4112
https://www.cvedetails.com/cve/CVE-2011-4112/
CWE-264
https://github.com/torvalds/linux/commit/550fd08c2cebad61c548def135f67aba284c6162
550fd08c2cebad61c548def135f67aba284c6162
net: Audit drivers to identify those needing IFF_TX_SKB_SHARING cleared After the last patch, We are left in a state in which only drivers calling ether_setup have IFF_TX_SKB_SHARING set (we assume that drivers touching real hardware call ether_setup for their net_devices and don't hold any state in their skbs. There are a handful of drivers that violate this assumption of course, and need to be fixed up. This patch identifies those drivers, and marks them as not being able to support the safe transmission of skbs by clearning the IFF_TX_SKB_SHARING flag in priv_flags Signed-off-by: Neil Horman <[email protected]> CC: Karsten Keil <[email protected]> CC: "David S. Miller" <[email protected]> CC: Jay Vosburgh <[email protected]> CC: Andy Gospodarek <[email protected]> CC: Patrick McHardy <[email protected]> CC: Krzysztof Halasa <[email protected]> CC: "John W. Linville" <[email protected]> CC: Greg Kroah-Hartman <[email protected]> CC: Marcel Holtmann <[email protected]> CC: Johannes Berg <[email protected]> Signed-off-by: David S. Miller <[email protected]>
isdn_net_ciscohdlck_disconnected(isdn_net_local *lp) { del_timer(&lp->cisco_timer); }
isdn_net_ciscohdlck_disconnected(isdn_net_local *lp) { del_timer(&lp->cisco_timer); }
C
linux
0
CVE-2013-7008
https://www.cvedetails.com/cve/CVE-2013-7008/
null
https://github.com/FFmpeg/FFmpeg/commit/29ffeef5e73b8f41ff3a3f2242d356759c66f91f
29ffeef5e73b8f41ff3a3f2242d356759c66f91f
avcodec/h264: do not trust last_pic_droppable when marking pictures as done This simplifies the code and fixes a deadlock Fixes Ticket2927 Signed-off-by: Michael Niedermayer <[email protected]>
static av_always_inline void prefetch_motion(H264Context *h, int list, int pixel_shift, int chroma_idc) { /* fetch pixels for estimated mv 4 macroblocks ahead * optimized for 64byte cache lines */ const int refn = h->ref_cache[list][scan8[0]]; if (refn >= 0) { const int mx = (h->mv_cache[list][scan8[0]][0] >> 2) + 16 * h->mb_x + 8; const int my = (h->mv_cache[list][scan8[0]][1] >> 2) + 16 * h->mb_y; uint8_t **src = h->ref_list[list][refn].f.data; int off = (mx << pixel_shift) + (my + (h->mb_x & 3) * 4) * h->mb_linesize + (64 << pixel_shift); h->vdsp.prefetch(src[0] + off, h->linesize, 4); if (chroma_idc == 3 /* yuv444 */) { h->vdsp.prefetch(src[1] + off, h->linesize, 4); h->vdsp.prefetch(src[2] + off, h->linesize, 4); } else { off= (((mx>>1)+64)<<pixel_shift) + ((my>>1) + (h->mb_x&7))*h->uvlinesize; h->vdsp.prefetch(src[1] + off, src[2] - src[1], 2); } } }
static av_always_inline void prefetch_motion(H264Context *h, int list, int pixel_shift, int chroma_idc) { /* fetch pixels for estimated mv 4 macroblocks ahead * optimized for 64byte cache lines */ const int refn = h->ref_cache[list][scan8[0]]; if (refn >= 0) { const int mx = (h->mv_cache[list][scan8[0]][0] >> 2) + 16 * h->mb_x + 8; const int my = (h->mv_cache[list][scan8[0]][1] >> 2) + 16 * h->mb_y; uint8_t **src = h->ref_list[list][refn].f.data; int off = (mx << pixel_shift) + (my + (h->mb_x & 3) * 4) * h->mb_linesize + (64 << pixel_shift); h->vdsp.prefetch(src[0] + off, h->linesize, 4); if (chroma_idc == 3 /* yuv444 */) { h->vdsp.prefetch(src[1] + off, h->linesize, 4); h->vdsp.prefetch(src[2] + off, h->linesize, 4); } else { off= (((mx>>1)+64)<<pixel_shift) + ((my>>1) + (h->mb_x&7))*h->uvlinesize; h->vdsp.prefetch(src[1] + off, src[2] - src[1], 2); } } }
C
FFmpeg
0
CVE-2017-6991
https://www.cvedetails.com/cve/CVE-2017-6991/
CWE-119
https://github.com/chromium/chromium/commit/3bfe67c9c4b45eb713326aae7a67c8f7390dae08
3bfe67c9c4b45eb713326aae7a67c8f7390dae08
sqlite: safely move pointer values through SQL. This lands https://www.sqlite.org/src/timeline?c=d6a44b35 in third_party/sqlite/src/ and third_party/sqlite/patches/0013-Add-new-interfaces-sqlite3_bind_pointer-sqlite3_resu.patch and re-generates third_party/sqlite/amalgamation/* using the script at third_party/sqlite/google_generate_amalgamation.sh. The CL also adds a layout test that verifies the patch works as intended. BUG=742407 Change-Id: I2e1a457459cd2e975e6241b630e7b79c82545981 Reviewed-on: https://chromium-review.googlesource.com/572976 Reviewed-by: Chris Mumford <[email protected]> Commit-Queue: Victor Costan <[email protected]> Cr-Commit-Position: refs/heads/master@{#487275}
static int closeUnixFile(sqlite3_file *id){ unixFile *pFile = (unixFile*)id; #if SQLITE_MAX_MMAP_SIZE>0 unixUnmapfile(pFile); #endif if( pFile->h>=0 ){ robust_close(pFile, pFile->h, __LINE__); pFile->h = -1; } #if OS_VXWORKS if( pFile->pId ){ if( pFile->ctrlFlags & UNIXFILE_DELETE ){ osUnlink(pFile->pId->zCanonicalName); } vxworksReleaseFileId(pFile->pId); pFile->pId = 0; } #endif #ifdef SQLITE_UNLINK_AFTER_CLOSE if( pFile->ctrlFlags & UNIXFILE_DELETE ){ osUnlink(pFile->zPath); sqlite3_free(*(char**)&pFile->zPath); pFile->zPath = 0; } #endif OSTRACE(("CLOSE %-3d\n", pFile->h)); OpenCounter(-1); sqlite3_free(pFile->pUnused); memset(pFile, 0, sizeof(unixFile)); return SQLITE_OK; }
static int closeUnixFile(sqlite3_file *id){ unixFile *pFile = (unixFile*)id; #if SQLITE_MAX_MMAP_SIZE>0 unixUnmapfile(pFile); #endif if( pFile->h>=0 ){ robust_close(pFile, pFile->h, __LINE__); pFile->h = -1; } #if OS_VXWORKS if( pFile->pId ){ if( pFile->ctrlFlags & UNIXFILE_DELETE ){ osUnlink(pFile->pId->zCanonicalName); } vxworksReleaseFileId(pFile->pId); pFile->pId = 0; } #endif #ifdef SQLITE_UNLINK_AFTER_CLOSE if( pFile->ctrlFlags & UNIXFILE_DELETE ){ osUnlink(pFile->zPath); sqlite3_free(*(char**)&pFile->zPath); pFile->zPath = 0; } #endif OSTRACE(("CLOSE %-3d\n", pFile->h)); OpenCounter(-1); sqlite3_free(pFile->pUnused); memset(pFile, 0, sizeof(unixFile)); return SQLITE_OK; }
C
Chrome
0
CVE-2016-1616
https://www.cvedetails.com/cve/CVE-2016-1616/
CWE-254
https://github.com/chromium/chromium/commit/297ae873b471a46929ea39697b121c0b411434ee
297ae873b471a46929ea39697b121c0b411434ee
Custom buttons should only handle accelerators when focused. BUG=541415 Review URL: https://codereview.chromium.org/1437523005 Cr-Commit-Position: refs/heads/master@{#360130}
void CustomButton::ShowContextMenu(const gfx::Point& p, ui::MenuSourceType source_type) { if (!context_menu_controller()) return; if (state_ != STATE_DISABLED) SetState(STATE_NORMAL); View::ShowContextMenu(p, source_type); }
void CustomButton::ShowContextMenu(const gfx::Point& p, ui::MenuSourceType source_type) { if (!context_menu_controller()) return; if (state_ != STATE_DISABLED) SetState(STATE_NORMAL); View::ShowContextMenu(p, source_type); }
C
Chrome
0
CVE-2016-7127
https://www.cvedetails.com/cve/CVE-2016-7127/
CWE-787
https://github.com/php/php-src/commit/1bd103df00f49cf4d4ade2cfe3f456ac058a4eae?w=1
1bd103df00f49cf4d4ade2cfe3f456ac058a4eae?w=1
Fix bug #72730 - imagegammacorrect allows arbitrary write access
PHP_FUNCTION(imagesetstyle) { zval *IM, *styles; gdImagePtr im; int * stylearr; int index; HashPosition pos; int num_styles; if (zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "ra", &IM, &styles) == FAILURE) { return; } ZEND_FETCH_RESOURCE(im, gdImagePtr, &IM, -1, "Image", le_gd); num_styles = zend_hash_num_elements(HASH_OF(styles)); if (num_styles == 0) { php_error_docref(NULL TSRMLS_CC, E_WARNING, "styles array must not be empty"); RETURN_FALSE; } /* copy the style values in the stylearr */ stylearr = safe_emalloc(sizeof(int), num_styles, 0); zend_hash_internal_pointer_reset_ex(HASH_OF(styles), &pos); for (index = 0;; zend_hash_move_forward_ex(HASH_OF(styles), &pos)) { zval ** item; if (zend_hash_get_current_data_ex(HASH_OF(styles), (void **) &item, &pos) == FAILURE) { break; } if (Z_TYPE_PP(item) != IS_LONG) { zval lval; lval = **item; zval_copy_ctor(&lval); convert_to_long(&lval); stylearr[index++] = Z_LVAL(lval); } else { stylearr[index++] = Z_LVAL_PP(item); } } gdImageSetStyle(im, stylearr, index); efree(stylearr); RETURN_TRUE; }
PHP_FUNCTION(imagesetstyle) { zval *IM, *styles; gdImagePtr im; int * stylearr; int index; HashPosition pos; int num_styles; if (zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "ra", &IM, &styles) == FAILURE) { return; } ZEND_FETCH_RESOURCE(im, gdImagePtr, &IM, -1, "Image", le_gd); num_styles = zend_hash_num_elements(HASH_OF(styles)); if (num_styles == 0) { php_error_docref(NULL TSRMLS_CC, E_WARNING, "styles array must not be empty"); RETURN_FALSE; } /* copy the style values in the stylearr */ stylearr = safe_emalloc(sizeof(int), num_styles, 0); zend_hash_internal_pointer_reset_ex(HASH_OF(styles), &pos); for (index = 0;; zend_hash_move_forward_ex(HASH_OF(styles), &pos)) { zval ** item; if (zend_hash_get_current_data_ex(HASH_OF(styles), (void **) &item, &pos) == FAILURE) { break; } if (Z_TYPE_PP(item) != IS_LONG) { zval lval; lval = **item; zval_copy_ctor(&lval); convert_to_long(&lval); stylearr[index++] = Z_LVAL(lval); } else { stylearr[index++] = Z_LVAL_PP(item); } } gdImageSetStyle(im, stylearr, index); efree(stylearr); RETURN_TRUE; }
C
php-src
0
CVE-2017-0811
https://www.cvedetails.com/cve/CVE-2017-0811/
null
https://android.googlesource.com/platform/external/libhevc/+/25c0ffbe6a181b4a373c3c9b421ea449d457e6ed
25c0ffbe6a181b4a373c3c9b421ea449d457e6ed
Ensure CTB size > 16 for clips with tiles and width/height >= 4096 For clips with tiles and dimensions >= 4096, CTB size of 16 can result in tile position > 255. This is not supported by the decoder Bug: 37930177 Test: ran poc w/o crashing Change-Id: I2f223a124c4ea9bfd98343343fd010d80a5dd8bd (cherry picked from commit 248e72c7a8c7c382ff4397868a6c7453a6453141)
WORD32 ihevcd_parse_pred_wt_ofst(bitstrm_t *ps_bitstrm, sps_t *ps_sps, pps_t *ps_pps, slice_header_t *ps_slice_hdr) { IHEVCD_ERROR_T ret = (IHEVCD_ERROR_T)IHEVCD_SUCCESS; WORD32 value; WORD32 i; pred_wt_ofst_t *ps_wt_ofst = &ps_slice_hdr->s_wt_ofst; UNUSED(ps_pps); UEV_PARSE("luma_log2_weight_denom", value, ps_bitstrm); ps_wt_ofst->i1_luma_log2_weight_denom = value; if(ps_sps->i1_chroma_format_idc != 0) { SEV_PARSE("delta_chroma_log2_weight_denom", value, ps_bitstrm); ps_wt_ofst->i1_chroma_log2_weight_denom = ps_wt_ofst->i1_luma_log2_weight_denom + value; } for(i = 0; i < ps_slice_hdr->i1_num_ref_idx_l0_active; i++) { BITS_PARSE("luma_weight_l0_flag[ i ]", value, ps_bitstrm, 1); ps_wt_ofst->i1_luma_weight_l0_flag[i] = value; } if(ps_sps->i1_chroma_format_idc != 0) { for(i = 0; i < ps_slice_hdr->i1_num_ref_idx_l0_active; i++) { BITS_PARSE("chroma_weight_l0_flag[ i ]", value, ps_bitstrm, 1); ps_wt_ofst->i1_chroma_weight_l0_flag[i] = value; } } else { for(i = 0; i < ps_slice_hdr->i1_num_ref_idx_l0_active; i++) { ps_wt_ofst->i1_chroma_weight_l0_flag[i] = 0; } } for(i = 0; i < ps_slice_hdr->i1_num_ref_idx_l0_active; i++) { if(ps_wt_ofst->i1_luma_weight_l0_flag[i]) { SEV_PARSE("delta_luma_weight_l0[ i ]", value, ps_bitstrm); ps_wt_ofst->i2_luma_weight_l0[i] = (1 << ps_wt_ofst->i1_luma_log2_weight_denom) + value; SEV_PARSE("luma_offset_l0[ i ]", value, ps_bitstrm); ps_wt_ofst->i2_luma_offset_l0[i] = value; } else { ps_wt_ofst->i2_luma_weight_l0[i] = (1 << ps_wt_ofst->i1_luma_log2_weight_denom); ps_wt_ofst->i2_luma_offset_l0[i] = 0; } if(ps_wt_ofst->i1_chroma_weight_l0_flag[i]) { WORD32 ofst; WORD32 shift = (1 << (BIT_DEPTH_CHROMA - 1)); SEV_PARSE("delta_chroma_weight_l0[ i ][ j ]", value, ps_bitstrm); ps_wt_ofst->i2_chroma_weight_l0_cb[i] = (1 << ps_wt_ofst->i1_chroma_log2_weight_denom) + value; SEV_PARSE("delta_chroma_offset_l0[ i ][ j ]", value, ps_bitstrm); ofst = ((shift * ps_wt_ofst->i2_chroma_weight_l0_cb[i]) >> ps_wt_ofst->i1_chroma_log2_weight_denom); ofst = value - ofst + shift; ps_wt_ofst->i2_chroma_offset_l0_cb[i] = CLIP_S8(ofst); SEV_PARSE("delta_chroma_weight_l0[ i ][ j ]", value, ps_bitstrm); ps_wt_ofst->i2_chroma_weight_l0_cr[i] = (1 << ps_wt_ofst->i1_chroma_log2_weight_denom) + value; SEV_PARSE("delta_chroma_offset_l0[ i ][ j ]", value, ps_bitstrm); ofst = ((shift * ps_wt_ofst->i2_chroma_weight_l0_cr[i]) >> ps_wt_ofst->i1_chroma_log2_weight_denom); ofst = value - ofst + shift; ps_wt_ofst->i2_chroma_offset_l0_cr[i] = CLIP_S8(ofst); } else { ps_wt_ofst->i2_chroma_weight_l0_cb[i] = (1 << ps_wt_ofst->i1_chroma_log2_weight_denom); ps_wt_ofst->i2_chroma_weight_l0_cr[i] = (1 << ps_wt_ofst->i1_chroma_log2_weight_denom); ps_wt_ofst->i2_chroma_offset_l0_cb[i] = 0; ps_wt_ofst->i2_chroma_offset_l0_cr[i] = 0; } } if(BSLICE == ps_slice_hdr->i1_slice_type) { for(i = 0; i < ps_slice_hdr->i1_num_ref_idx_l1_active; i++) { BITS_PARSE("luma_weight_l1_flag[ i ]", value, ps_bitstrm, 1); ps_wt_ofst->i1_luma_weight_l1_flag[i] = value; } if(ps_sps->i1_chroma_format_idc != 0) { for(i = 0; i < ps_slice_hdr->i1_num_ref_idx_l1_active; i++) { BITS_PARSE("chroma_weight_l1_flag[ i ]", value, ps_bitstrm, 1); ps_wt_ofst->i1_chroma_weight_l1_flag[i] = value; } } else { for(i = 0; i < ps_slice_hdr->i1_num_ref_idx_l1_active; i++) { ps_wt_ofst->i1_chroma_weight_l1_flag[i] = 0; } } for(i = 0; i < ps_slice_hdr->i1_num_ref_idx_l1_active; i++) { if(ps_wt_ofst->i1_luma_weight_l1_flag[i]) { SEV_PARSE("delta_luma_weight_l1[ i ]", value, ps_bitstrm); ps_wt_ofst->i2_luma_weight_l1[i] = (1 << ps_wt_ofst->i1_luma_log2_weight_denom) + value; SEV_PARSE("luma_offset_l1[ i ]", value, ps_bitstrm); ps_wt_ofst->i2_luma_offset_l1[i] = value; } else { ps_wt_ofst->i2_luma_weight_l1[i] = (1 << ps_wt_ofst->i1_luma_log2_weight_denom); ps_wt_ofst->i2_luma_offset_l1[i] = 0; } if(ps_wt_ofst->i1_chroma_weight_l1_flag[i]) { WORD32 ofst; WORD32 shift = (1 << (BIT_DEPTH_CHROMA - 1)); SEV_PARSE("delta_chroma_weight_l1[ i ][ j ]", value, ps_bitstrm); ps_wt_ofst->i2_chroma_weight_l1_cb[i] = (1 << ps_wt_ofst->i1_chroma_log2_weight_denom) + value;; SEV_PARSE("delta_chroma_offset_l1[ i ][ j ]", value, ps_bitstrm); ofst = ((shift * ps_wt_ofst->i2_chroma_weight_l1_cb[i]) >> ps_wt_ofst->i1_chroma_log2_weight_denom); ofst = value - ofst + shift; ps_wt_ofst->i2_chroma_offset_l1_cb[i] = CLIP_S8(ofst);; SEV_PARSE("delta_chroma_weight_l1[ i ][ j ]", value, ps_bitstrm); ps_wt_ofst->i2_chroma_weight_l1_cr[i] = (1 << ps_wt_ofst->i1_chroma_log2_weight_denom) + value; SEV_PARSE("delta_chroma_offset_l1[ i ][ j ]", value, ps_bitstrm); ofst = ((shift * ps_wt_ofst->i2_chroma_weight_l1_cr[i]) >> ps_wt_ofst->i1_chroma_log2_weight_denom); ofst = value - ofst + shift; ps_wt_ofst->i2_chroma_offset_l1_cr[i] = CLIP_S8(ofst);; } else { ps_wt_ofst->i2_chroma_weight_l1_cb[i] = (1 << ps_wt_ofst->i1_chroma_log2_weight_denom); ps_wt_ofst->i2_chroma_weight_l1_cr[i] = (1 << ps_wt_ofst->i1_chroma_log2_weight_denom); ps_wt_ofst->i2_chroma_offset_l1_cb[i] = 0; ps_wt_ofst->i2_chroma_offset_l1_cr[i] = 0; } } } return ret; }
WORD32 ihevcd_parse_pred_wt_ofst(bitstrm_t *ps_bitstrm, sps_t *ps_sps, pps_t *ps_pps, slice_header_t *ps_slice_hdr) { IHEVCD_ERROR_T ret = (IHEVCD_ERROR_T)IHEVCD_SUCCESS; WORD32 value; WORD32 i; pred_wt_ofst_t *ps_wt_ofst = &ps_slice_hdr->s_wt_ofst; UNUSED(ps_pps); UEV_PARSE("luma_log2_weight_denom", value, ps_bitstrm); ps_wt_ofst->i1_luma_log2_weight_denom = value; if(ps_sps->i1_chroma_format_idc != 0) { SEV_PARSE("delta_chroma_log2_weight_denom", value, ps_bitstrm); ps_wt_ofst->i1_chroma_log2_weight_denom = ps_wt_ofst->i1_luma_log2_weight_denom + value; } for(i = 0; i < ps_slice_hdr->i1_num_ref_idx_l0_active; i++) { BITS_PARSE("luma_weight_l0_flag[ i ]", value, ps_bitstrm, 1); ps_wt_ofst->i1_luma_weight_l0_flag[i] = value; } if(ps_sps->i1_chroma_format_idc != 0) { for(i = 0; i < ps_slice_hdr->i1_num_ref_idx_l0_active; i++) { BITS_PARSE("chroma_weight_l0_flag[ i ]", value, ps_bitstrm, 1); ps_wt_ofst->i1_chroma_weight_l0_flag[i] = value; } } else { for(i = 0; i < ps_slice_hdr->i1_num_ref_idx_l0_active; i++) { ps_wt_ofst->i1_chroma_weight_l0_flag[i] = 0; } } for(i = 0; i < ps_slice_hdr->i1_num_ref_idx_l0_active; i++) { if(ps_wt_ofst->i1_luma_weight_l0_flag[i]) { SEV_PARSE("delta_luma_weight_l0[ i ]", value, ps_bitstrm); ps_wt_ofst->i2_luma_weight_l0[i] = (1 << ps_wt_ofst->i1_luma_log2_weight_denom) + value; SEV_PARSE("luma_offset_l0[ i ]", value, ps_bitstrm); ps_wt_ofst->i2_luma_offset_l0[i] = value; } else { ps_wt_ofst->i2_luma_weight_l0[i] = (1 << ps_wt_ofst->i1_luma_log2_weight_denom); ps_wt_ofst->i2_luma_offset_l0[i] = 0; } if(ps_wt_ofst->i1_chroma_weight_l0_flag[i]) { WORD32 ofst; WORD32 shift = (1 << (BIT_DEPTH_CHROMA - 1)); SEV_PARSE("delta_chroma_weight_l0[ i ][ j ]", value, ps_bitstrm); ps_wt_ofst->i2_chroma_weight_l0_cb[i] = (1 << ps_wt_ofst->i1_chroma_log2_weight_denom) + value; SEV_PARSE("delta_chroma_offset_l0[ i ][ j ]", value, ps_bitstrm); ofst = ((shift * ps_wt_ofst->i2_chroma_weight_l0_cb[i]) >> ps_wt_ofst->i1_chroma_log2_weight_denom); ofst = value - ofst + shift; ps_wt_ofst->i2_chroma_offset_l0_cb[i] = CLIP_S8(ofst); SEV_PARSE("delta_chroma_weight_l0[ i ][ j ]", value, ps_bitstrm); ps_wt_ofst->i2_chroma_weight_l0_cr[i] = (1 << ps_wt_ofst->i1_chroma_log2_weight_denom) + value; SEV_PARSE("delta_chroma_offset_l0[ i ][ j ]", value, ps_bitstrm); ofst = ((shift * ps_wt_ofst->i2_chroma_weight_l0_cr[i]) >> ps_wt_ofst->i1_chroma_log2_weight_denom); ofst = value - ofst + shift; ps_wt_ofst->i2_chroma_offset_l0_cr[i] = CLIP_S8(ofst); } else { ps_wt_ofst->i2_chroma_weight_l0_cb[i] = (1 << ps_wt_ofst->i1_chroma_log2_weight_denom); ps_wt_ofst->i2_chroma_weight_l0_cr[i] = (1 << ps_wt_ofst->i1_chroma_log2_weight_denom); ps_wt_ofst->i2_chroma_offset_l0_cb[i] = 0; ps_wt_ofst->i2_chroma_offset_l0_cr[i] = 0; } } if(BSLICE == ps_slice_hdr->i1_slice_type) { for(i = 0; i < ps_slice_hdr->i1_num_ref_idx_l1_active; i++) { BITS_PARSE("luma_weight_l1_flag[ i ]", value, ps_bitstrm, 1); ps_wt_ofst->i1_luma_weight_l1_flag[i] = value; } if(ps_sps->i1_chroma_format_idc != 0) { for(i = 0; i < ps_slice_hdr->i1_num_ref_idx_l1_active; i++) { BITS_PARSE("chroma_weight_l1_flag[ i ]", value, ps_bitstrm, 1); ps_wt_ofst->i1_chroma_weight_l1_flag[i] = value; } } else { for(i = 0; i < ps_slice_hdr->i1_num_ref_idx_l1_active; i++) { ps_wt_ofst->i1_chroma_weight_l1_flag[i] = 0; } } for(i = 0; i < ps_slice_hdr->i1_num_ref_idx_l1_active; i++) { if(ps_wt_ofst->i1_luma_weight_l1_flag[i]) { SEV_PARSE("delta_luma_weight_l1[ i ]", value, ps_bitstrm); ps_wt_ofst->i2_luma_weight_l1[i] = (1 << ps_wt_ofst->i1_luma_log2_weight_denom) + value; SEV_PARSE("luma_offset_l1[ i ]", value, ps_bitstrm); ps_wt_ofst->i2_luma_offset_l1[i] = value; } else { ps_wt_ofst->i2_luma_weight_l1[i] = (1 << ps_wt_ofst->i1_luma_log2_weight_denom); ps_wt_ofst->i2_luma_offset_l1[i] = 0; } if(ps_wt_ofst->i1_chroma_weight_l1_flag[i]) { WORD32 ofst; WORD32 shift = (1 << (BIT_DEPTH_CHROMA - 1)); SEV_PARSE("delta_chroma_weight_l1[ i ][ j ]", value, ps_bitstrm); ps_wt_ofst->i2_chroma_weight_l1_cb[i] = (1 << ps_wt_ofst->i1_chroma_log2_weight_denom) + value;; SEV_PARSE("delta_chroma_offset_l1[ i ][ j ]", value, ps_bitstrm); ofst = ((shift * ps_wt_ofst->i2_chroma_weight_l1_cb[i]) >> ps_wt_ofst->i1_chroma_log2_weight_denom); ofst = value - ofst + shift; ps_wt_ofst->i2_chroma_offset_l1_cb[i] = CLIP_S8(ofst);; SEV_PARSE("delta_chroma_weight_l1[ i ][ j ]", value, ps_bitstrm); ps_wt_ofst->i2_chroma_weight_l1_cr[i] = (1 << ps_wt_ofst->i1_chroma_log2_weight_denom) + value; SEV_PARSE("delta_chroma_offset_l1[ i ][ j ]", value, ps_bitstrm); ofst = ((shift * ps_wt_ofst->i2_chroma_weight_l1_cr[i]) >> ps_wt_ofst->i1_chroma_log2_weight_denom); ofst = value - ofst + shift; ps_wt_ofst->i2_chroma_offset_l1_cr[i] = CLIP_S8(ofst);; } else { ps_wt_ofst->i2_chroma_weight_l1_cb[i] = (1 << ps_wt_ofst->i1_chroma_log2_weight_denom); ps_wt_ofst->i2_chroma_weight_l1_cr[i] = (1 << ps_wt_ofst->i1_chroma_log2_weight_denom); ps_wt_ofst->i2_chroma_offset_l1_cb[i] = 0; ps_wt_ofst->i2_chroma_offset_l1_cr[i] = 0; } } } return ret; }
C
Android
0
null
null
null
https://github.com/chromium/chromium/commit/e93dc535728da259ec16d1c3cc393f80b25f64ae
e93dc535728da259ec16d1c3cc393f80b25f64ae
Add a unit test that filenames aren't unintentionally converted to URLs. Also fixes two issues in OSExchangeDataProviderWin: - It used a disjoint set of clipboard formats when handling GetUrl(..., true /* filename conversion */) vs GetFilenames(...), so the actual returned results would vary depending on which one was called. - It incorrectly used ::DragFinish() instead of ::ReleaseStgMedium(). ::DragFinish() is only meant to be used in conjunction with WM_DROPFILES. BUG=346135 Review URL: https://codereview.chromium.org/380553002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283226 0039d316-1c4b-4281-b951-d872f2087c98
bool OSExchangeDataProviderWin::HasFileContents() const { return ClipboardUtil::HasFileContents(source_object_); }
bool OSExchangeDataProviderWin::HasFileContents() const { return ClipboardUtil::HasFileContents(source_object_); }
C
Chrome
0
CVE-2013-2915
https://www.cvedetails.com/cve/CVE-2013-2915/
null
https://github.com/chromium/chromium/commit/b12eb22a27110f49a2ad54b9e4ffd0ccb6cf9ce9
b12eb22a27110f49a2ad54b9e4ffd0ccb6cf9ce9
Delete unneeded pending entries in DidFailProvisionalLoad to prevent a spoof. BUG=280512 BUG=278899 TEST=See bug for repro steps. Review URL: https://chromiumcodereview.appspot.com/23978003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222146 0039d316-1c4b-4281-b951-d872f2087c98
void NavigationControllerImpl::NavigateToPendingEntry(ReloadType reload_type) { needs_reload_ = false; if (pending_entry_index_ != -1 && pending_entry_index_ == last_committed_entry_index_ && (entries_[pending_entry_index_]->restore_type() == NavigationEntryImpl::RESTORE_NONE) && (entries_[pending_entry_index_]->GetTransitionType() & PAGE_TRANSITION_FORWARD_BACK)) { web_contents_->Stop(); if (web_contents_->GetInterstitialPage()) web_contents_->GetInterstitialPage()->DontProceed(); DiscardNonCommittedEntries(); return; } if (web_contents_->GetInterstitialPage()) { static_cast<InterstitialPageImpl*>(web_contents_->GetInterstitialPage())-> CancelForNavigation(); } if (!pending_entry_) { DCHECK_NE(pending_entry_index_, -1); pending_entry_ = entries_[pending_entry_index_].get(); } if (!web_contents_->NavigateToPendingEntry(reload_type)) DiscardNonCommittedEntries(); if (pending_entry_ && !pending_entry_->site_instance() && pending_entry_->restore_type() != NavigationEntryImpl::RESTORE_NONE) { pending_entry_->set_site_instance(static_cast<SiteInstanceImpl*>( web_contents_->GetPendingSiteInstance())); pending_entry_->set_restore_type(NavigationEntryImpl::RESTORE_NONE); } }
void NavigationControllerImpl::NavigateToPendingEntry(ReloadType reload_type) { needs_reload_ = false; if (pending_entry_index_ != -1 && pending_entry_index_ == last_committed_entry_index_ && (entries_[pending_entry_index_]->restore_type() == NavigationEntryImpl::RESTORE_NONE) && (entries_[pending_entry_index_]->GetTransitionType() & PAGE_TRANSITION_FORWARD_BACK)) { web_contents_->Stop(); if (web_contents_->GetInterstitialPage()) web_contents_->GetInterstitialPage()->DontProceed(); DiscardNonCommittedEntries(); return; } if (web_contents_->GetInterstitialPage()) { static_cast<InterstitialPageImpl*>(web_contents_->GetInterstitialPage())-> CancelForNavigation(); } if (!pending_entry_) { DCHECK_NE(pending_entry_index_, -1); pending_entry_ = entries_[pending_entry_index_].get(); } if (!web_contents_->NavigateToPendingEntry(reload_type)) DiscardNonCommittedEntries(); if (pending_entry_ && !pending_entry_->site_instance() && pending_entry_->restore_type() != NavigationEntryImpl::RESTORE_NONE) { pending_entry_->set_site_instance(static_cast<SiteInstanceImpl*>( web_contents_->GetPendingSiteInstance())); pending_entry_->set_restore_type(NavigationEntryImpl::RESTORE_NONE); } }
C
Chrome
0
CVE-2015-1295
https://www.cvedetails.com/cve/CVE-2015-1295/
null
https://github.com/chromium/chromium/commit/8fa5a358cb32085b51daf92df8fd4a79b3931f81
8fa5a358cb32085b51daf92df8fd4a79b3931f81
Crash on nested IPC handlers in PrintWebViewHelper Class is not designed to handle nested IPC. Regular flows also does not expect them. Still during printing of plugging them may show message boxes and start nested message loops. For now we are going just crash. If stats show us that this case is frequent we will have to do something more complicated. BUG=502562 Review URL: https://codereview.chromium.org/1228693002 Cr-Commit-Position: refs/heads/master@{#338100}
void PrintWebViewHelper::PrintPage(blink::WebLocalFrame* frame, bool user_initiated) { DCHECK(frame); if (delegate_->CancelPrerender(render_view(), routing_id())) return; if (!IsScriptInitiatedPrintAllowed(frame, user_initiated)) return; if (delegate_->OverridePrint(frame)) return; if (!g_is_preview_enabled_) { Print(frame, blink::WebNode(), true); } else { print_preview_context_.InitWithFrame(frame); RequestPrintPreview(PRINT_PREVIEW_SCRIPTED); } }
void PrintWebViewHelper::PrintPage(blink::WebLocalFrame* frame, bool user_initiated) { DCHECK(frame); if (delegate_->CancelPrerender(render_view(), routing_id())) return; if (!IsScriptInitiatedPrintAllowed(frame, user_initiated)) return; if (delegate_->OverridePrint(frame)) return; if (!g_is_preview_enabled_) { Print(frame, blink::WebNode(), true); } else { print_preview_context_.InitWithFrame(frame); RequestPrintPreview(PRINT_PREVIEW_SCRIPTED); } }
C
Chrome
0
CVE-2016-9916
https://www.cvedetails.com/cve/CVE-2016-9916/
CWE-400
https://git.qemu.org/?p=qemu.git;a=commit;h=898ae90a44551d25b8e956fd87372d303c82fe68
898ae90a44551d25b8e956fd87372d303c82fe68
null
static int proxy_mknod(FsContext *fs_ctx, V9fsPath *dir_path, const char *name, FsCred *credp) { int retval; V9fsString fullname; v9fs_string_init(&fullname); v9fs_string_sprintf(&fullname, "%s/%s", dir_path->data, name); retval = v9fs_request(fs_ctx->private, T_MKNOD, NULL, &fullname, credp->fc_mode, credp->fc_rdev, credp->fc_uid, credp->fc_gid); v9fs_string_free(&fullname); if (retval < 0) { errno = -retval; retval = -1; } return retval; }
static int proxy_mknod(FsContext *fs_ctx, V9fsPath *dir_path, const char *name, FsCred *credp) { int retval; V9fsString fullname; v9fs_string_init(&fullname); v9fs_string_sprintf(&fullname, "%s/%s", dir_path->data, name); retval = v9fs_request(fs_ctx->private, T_MKNOD, NULL, &fullname, credp->fc_mode, credp->fc_rdev, credp->fc_uid, credp->fc_gid); v9fs_string_free(&fullname); if (retval < 0) { errno = -retval; retval = -1; } return retval; }
C
qemu
0
CVE-2017-11462
https://www.cvedetails.com/cve/CVE-2017-11462/
CWE-415
https://github.com/krb5/krb5/commit/56f7b1bc95a2a3eeb420e069e7655fb181ade5cf
56f7b1bc95a2a3eeb420e069e7655fb181ade5cf
Preserve GSS context on init/accept failure After gss_init_sec_context() or gss_accept_sec_context() has created a context, don't delete the mechglue context on failures from subsequent calls, even if the mechanism deletes the mech-specific context (which is allowed by RFC 2744 but not preferred). Check for union contexts with no mechanism context in each GSS function which accepts a gss_ctx_id_t. CVE-2017-11462: RFC 2744 permits a GSS-API implementation to delete an existing security context on a second or subsequent call to gss_init_sec_context() or gss_accept_sec_context() if the call results in an error. This API behavior has been found to be dangerous, leading to the possibility of memory errors in some callers. For safety, GSS-API implementations should instead preserve existing security contexts on error until the caller deletes them. All versions of MIT krb5 prior to this change may delete acceptor contexts on error. Versions 1.13.4 through 1.13.7, 1.14.1 through 1.14.5, and 1.15 through 1.15.1 may also delete initiator contexts on error. ticket: 8598 (new) target_version: 1.15-next target_version: 1.14-next tags: pullup
gss_unwrap_aead (minor_status, context_handle, input_message_buffer, input_assoc_buffer, output_payload_buffer, conf_state, qop_state) OM_uint32 * minor_status; gss_ctx_id_t context_handle; gss_buffer_t input_message_buffer; gss_buffer_t input_assoc_buffer; gss_buffer_t output_payload_buffer; int *conf_state; gss_qop_t *qop_state; { OM_uint32 status; gss_union_ctx_id_t ctx; gss_mechanism mech; status = val_unwrap_aead_args(minor_status, context_handle, input_message_buffer, input_assoc_buffer, output_payload_buffer, conf_state, qop_state); if (status != GSS_S_COMPLETE) return (status); /* * select the approprate underlying mechanism routine and * call it. */ ctx = (gss_union_ctx_id_t) context_handle; if (ctx->internal_ctx_id == GSS_C_NO_CONTEXT) return (GSS_S_NO_CONTEXT); mech = gssint_get_mechanism (ctx->mech_type); if (!mech) return (GSS_S_BAD_MECH); return gssint_unwrap_aead(mech, minor_status, ctx, input_message_buffer, input_assoc_buffer, output_payload_buffer, conf_state, qop_state); }
gss_unwrap_aead (minor_status, context_handle, input_message_buffer, input_assoc_buffer, output_payload_buffer, conf_state, qop_state) OM_uint32 * minor_status; gss_ctx_id_t context_handle; gss_buffer_t input_message_buffer; gss_buffer_t input_assoc_buffer; gss_buffer_t output_payload_buffer; int *conf_state; gss_qop_t *qop_state; { OM_uint32 status; gss_union_ctx_id_t ctx; gss_mechanism mech; status = val_unwrap_aead_args(minor_status, context_handle, input_message_buffer, input_assoc_buffer, output_payload_buffer, conf_state, qop_state); if (status != GSS_S_COMPLETE) return (status); /* * select the approprate underlying mechanism routine and * call it. */ ctx = (gss_union_ctx_id_t) context_handle; mech = gssint_get_mechanism (ctx->mech_type); if (!mech) return (GSS_S_BAD_MECH); return gssint_unwrap_aead(mech, minor_status, ctx, input_message_buffer, input_assoc_buffer, output_payload_buffer, conf_state, qop_state); }
C
krb5
1
CVE-2016-10129
https://www.cvedetails.com/cve/CVE-2016-10129/
CWE-476
https://github.com/libgit2/libgit2/commit/2fdef641fd0dd2828bd948234ae86de75221a11a
2fdef641fd0dd2828bd948234ae86de75221a11a
smart_pkt: treat empty packet lines as error The Git protocol does not specify what should happen in the case of an empty packet line (that is a packet line "0004"). We currently indicate success, but do not return a packet in the case where we hit an empty line. The smart protocol was not prepared to handle such packets in all cases, though, resulting in a `NULL` pointer dereference. Fix the issue by returning an error instead. As such kind of packets is not even specified by upstream, this is the right thing to do.
int git_smart__push(git_transport *transport, git_push *push, const git_remote_callbacks *cbs) { transport_smart *t = (transport_smart *)transport; struct push_packbuilder_payload packbuilder_payload = {0}; git_buf pktline = GIT_BUF_INIT; int error = 0, need_pack = 0; push_spec *spec; unsigned int i; packbuilder_payload.pb = push->pb; if (cbs && cbs->push_transfer_progress) { packbuilder_payload.cb = cbs->push_transfer_progress; packbuilder_payload.cb_payload = cbs->payload; } #ifdef PUSH_DEBUG { git_remote_head *head; char hex[GIT_OID_HEXSZ+1]; hex[GIT_OID_HEXSZ] = '\0'; git_vector_foreach(&push->remote->refs, i, head) { git_oid_fmt(hex, &head->oid); fprintf(stderr, "%s (%s)\n", hex, head->name); } git_vector_foreach(&push->specs, i, spec) { git_oid_fmt(hex, &spec->roid); fprintf(stderr, "%s (%s) -> ", hex, spec->lref); git_oid_fmt(hex, &spec->loid); fprintf(stderr, "%s (%s)\n", hex, spec->rref ? spec->rref : spec->lref); } } #endif /* * Figure out if we need to send a packfile; which is in all * cases except when we only send delete commands */ git_vector_foreach(&push->specs, i, spec) { if (spec->refspec.src && spec->refspec.src[0] != '\0') { need_pack = 1; break; } } if ((error = git_smart__get_push_stream(t, &packbuilder_payload.stream)) < 0 || (error = gen_pktline(&pktline, push)) < 0 || (error = packbuilder_payload.stream->write(packbuilder_payload.stream, git_buf_cstr(&pktline), git_buf_len(&pktline))) < 0) goto done; if (need_pack && (error = git_packbuilder_foreach(push->pb, &stream_thunk, &packbuilder_payload)) < 0) goto done; /* If we sent nothing or the server doesn't support report-status, then * we consider the pack to have been unpacked successfully */ if (!push->specs.length || !push->report_status) push->unpack_ok = 1; else if ((error = parse_report(t, push)) < 0) goto done; /* If progress is being reported write the final report */ if (cbs && cbs->push_transfer_progress) { error = cbs->push_transfer_progress( push->pb->nr_written, push->pb->nr_objects, packbuilder_payload.last_bytes, cbs->payload); if (error < 0) goto done; } if (push->status.length) { error = update_refs_from_report(&t->refs, &push->specs, &push->status); if (error < 0) goto done; error = git_smart__update_heads(t, NULL); } done: git_buf_free(&pktline); return error; }
int git_smart__push(git_transport *transport, git_push *push, const git_remote_callbacks *cbs) { transport_smart *t = (transport_smart *)transport; struct push_packbuilder_payload packbuilder_payload = {0}; git_buf pktline = GIT_BUF_INIT; int error = 0, need_pack = 0; push_spec *spec; unsigned int i; packbuilder_payload.pb = push->pb; if (cbs && cbs->push_transfer_progress) { packbuilder_payload.cb = cbs->push_transfer_progress; packbuilder_payload.cb_payload = cbs->payload; } #ifdef PUSH_DEBUG { git_remote_head *head; char hex[GIT_OID_HEXSZ+1]; hex[GIT_OID_HEXSZ] = '\0'; git_vector_foreach(&push->remote->refs, i, head) { git_oid_fmt(hex, &head->oid); fprintf(stderr, "%s (%s)\n", hex, head->name); } git_vector_foreach(&push->specs, i, spec) { git_oid_fmt(hex, &spec->roid); fprintf(stderr, "%s (%s) -> ", hex, spec->lref); git_oid_fmt(hex, &spec->loid); fprintf(stderr, "%s (%s)\n", hex, spec->rref ? spec->rref : spec->lref); } } #endif /* * Figure out if we need to send a packfile; which is in all * cases except when we only send delete commands */ git_vector_foreach(&push->specs, i, spec) { if (spec->refspec.src && spec->refspec.src[0] != '\0') { need_pack = 1; break; } } if ((error = git_smart__get_push_stream(t, &packbuilder_payload.stream)) < 0 || (error = gen_pktline(&pktline, push)) < 0 || (error = packbuilder_payload.stream->write(packbuilder_payload.stream, git_buf_cstr(&pktline), git_buf_len(&pktline))) < 0) goto done; if (need_pack && (error = git_packbuilder_foreach(push->pb, &stream_thunk, &packbuilder_payload)) < 0) goto done; /* If we sent nothing or the server doesn't support report-status, then * we consider the pack to have been unpacked successfully */ if (!push->specs.length || !push->report_status) push->unpack_ok = 1; else if ((error = parse_report(t, push)) < 0) goto done; /* If progress is being reported write the final report */ if (cbs && cbs->push_transfer_progress) { error = cbs->push_transfer_progress( push->pb->nr_written, push->pb->nr_objects, packbuilder_payload.last_bytes, cbs->payload); if (error < 0) goto done; } if (push->status.length) { error = update_refs_from_report(&t->refs, &push->specs, &push->status); if (error < 0) goto done; error = git_smart__update_heads(t, NULL); } done: git_buf_free(&pktline); return error; }
C
libgit2
0
CVE-2016-2449
https://www.cvedetails.com/cve/CVE-2016-2449/
CWE-264
https://android.googlesource.com/platform/frameworks/av/+/b04aee833c5cfb6b31b8558350feb14bb1a0f353
b04aee833c5cfb6b31b8558350feb14bb1a0f353
Camera3Device: Validate template ID Validate template ID before creating a default request. Bug: 26866110 Bug: 27568958 Change-Id: Ifda457024f1d5c2b1382f189c1a8d5fda852d30d
void Camera3Device::notify(const camera3_notify_msg *msg) { ATRACE_CALL(); NotificationListener *listener; { Mutex::Autolock l(mOutputLock); listener = mListener; } if (msg == NULL) { SET_ERR("HAL sent NULL notify message!"); return; } switch (msg->type) { case CAMERA3_MSG_ERROR: { notifyError(msg->message.error, listener); break; } case CAMERA3_MSG_SHUTTER: { notifyShutter(msg->message.shutter, listener); break; } default: SET_ERR("Unknown notify message from HAL: %d", msg->type); } }
void Camera3Device::notify(const camera3_notify_msg *msg) { ATRACE_CALL(); NotificationListener *listener; { Mutex::Autolock l(mOutputLock); listener = mListener; } if (msg == NULL) { SET_ERR("HAL sent NULL notify message!"); return; } switch (msg->type) { case CAMERA3_MSG_ERROR: { notifyError(msg->message.error, listener); break; } case CAMERA3_MSG_SHUTTER: { notifyShutter(msg->message.shutter, listener); break; } default: SET_ERR("Unknown notify message from HAL: %d", msg->type); } }
C
Android
0
null
null
null
https://github.com/chromium/chromium/commit/820957a3386e960334be3b93b48636e749d38ea3
820957a3386e960334be3b93b48636e749d38ea3
Make WebContentsDelegate::OpenColorChooser return NULL on failure Changing WebContentsDelegate::OpenColorChooser to return NULL on failure so we don't put the same ColorChooser into two scoped_ptrs(WebContentsImpl::color_chooser_) BUG=331790 Review URL: https://codereview.chromium.org/128053002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244710 0039d316-1c4b-4281-b951-d872f2087c98
void WebContentsImpl::StopFinding(StopFindAction action) { Send(new ViewMsg_StopFinding(GetRoutingID(), action)); }
void WebContentsImpl::StopFinding(StopFindAction action) { Send(new ViewMsg_StopFinding(GetRoutingID(), action)); }
C
Chrome
0
CVE-2014-3645
https://www.cvedetails.com/cve/CVE-2014-3645/
CWE-20
https://github.com/torvalds/linux/commit/bfd0a56b90005f8c8a004baf407ad90045c2b11e
bfd0a56b90005f8c8a004baf407ad90045c2b11e
nEPT: Nested INVEPT If we let L1 use EPT, we should probably also support the INVEPT instruction. In our current nested EPT implementation, when L1 changes its EPT table for L2 (i.e., EPT12), L0 modifies the shadow EPT table (EPT02), and in the course of this modification already calls INVEPT. But if last level of shadow page is unsync not all L1's changes to EPT12 are intercepted, which means roots need to be synced when L1 calls INVEPT. Global INVEPT should not be different since roots are synced by kvm_mmu_load() each time EPTP02 changes. Reviewed-by: Xiao Guangrong <[email protected]> Signed-off-by: Nadav Har'El <[email protected]> Signed-off-by: Jun Nakajima <[email protected]> Signed-off-by: Xinhao Xu <[email protected]> Signed-off-by: Yang Zhang <[email protected]> Signed-off-by: Gleb Natapov <[email protected]> Signed-off-by: Paolo Bonzini <[email protected]>
static int nonpaging_map(struct kvm_vcpu *vcpu, gva_t v, u32 error_code, gfn_t gfn, bool prefault) { int r; int level; int force_pt_level; pfn_t pfn; unsigned long mmu_seq; bool map_writable, write = error_code & PFERR_WRITE_MASK; force_pt_level = mapping_level_dirty_bitmap(vcpu, gfn); if (likely(!force_pt_level)) { level = mapping_level(vcpu, gfn); /* * This path builds a PAE pagetable - so we can map * 2mb pages at maximum. Therefore check if the level * is larger than that. */ if (level > PT_DIRECTORY_LEVEL) level = PT_DIRECTORY_LEVEL; gfn &= ~(KVM_PAGES_PER_HPAGE(level) - 1); } else level = PT_PAGE_TABLE_LEVEL; if (fast_page_fault(vcpu, v, level, error_code)) return 0; mmu_seq = vcpu->kvm->mmu_notifier_seq; smp_rmb(); if (try_async_pf(vcpu, prefault, gfn, v, &pfn, write, &map_writable)) return 0; if (handle_abnormal_pfn(vcpu, v, gfn, pfn, ACC_ALL, &r)) return r; spin_lock(&vcpu->kvm->mmu_lock); if (mmu_notifier_retry(vcpu->kvm, mmu_seq)) goto out_unlock; make_mmu_pages_available(vcpu); if (likely(!force_pt_level)) transparent_hugepage_adjust(vcpu, &gfn, &pfn, &level); r = __direct_map(vcpu, v, write, map_writable, level, gfn, pfn, prefault); spin_unlock(&vcpu->kvm->mmu_lock); return r; out_unlock: spin_unlock(&vcpu->kvm->mmu_lock); kvm_release_pfn_clean(pfn); return 0; }
static int nonpaging_map(struct kvm_vcpu *vcpu, gva_t v, u32 error_code, gfn_t gfn, bool prefault) { int r; int level; int force_pt_level; pfn_t pfn; unsigned long mmu_seq; bool map_writable, write = error_code & PFERR_WRITE_MASK; force_pt_level = mapping_level_dirty_bitmap(vcpu, gfn); if (likely(!force_pt_level)) { level = mapping_level(vcpu, gfn); /* * This path builds a PAE pagetable - so we can map * 2mb pages at maximum. Therefore check if the level * is larger than that. */ if (level > PT_DIRECTORY_LEVEL) level = PT_DIRECTORY_LEVEL; gfn &= ~(KVM_PAGES_PER_HPAGE(level) - 1); } else level = PT_PAGE_TABLE_LEVEL; if (fast_page_fault(vcpu, v, level, error_code)) return 0; mmu_seq = vcpu->kvm->mmu_notifier_seq; smp_rmb(); if (try_async_pf(vcpu, prefault, gfn, v, &pfn, write, &map_writable)) return 0; if (handle_abnormal_pfn(vcpu, v, gfn, pfn, ACC_ALL, &r)) return r; spin_lock(&vcpu->kvm->mmu_lock); if (mmu_notifier_retry(vcpu->kvm, mmu_seq)) goto out_unlock; make_mmu_pages_available(vcpu); if (likely(!force_pt_level)) transparent_hugepage_adjust(vcpu, &gfn, &pfn, &level); r = __direct_map(vcpu, v, write, map_writable, level, gfn, pfn, prefault); spin_unlock(&vcpu->kvm->mmu_lock); return r; out_unlock: spin_unlock(&vcpu->kvm->mmu_lock); kvm_release_pfn_clean(pfn); return 0; }
C
linux
0
CVE-2016-6490
https://www.cvedetails.com/cve/CVE-2016-6490/
CWE-20
https://git.qemu.org/?p=qemu.git;a=commit;h=1e7aed70144b4673fc26e73062064b6724795e5f
1e7aed70144b4673fc26e73062064b6724795e5f
null
void virtio_config_writel(VirtIODevice *vdev, uint32_t addr, uint32_t data) { VirtioDeviceClass *k = VIRTIO_DEVICE_GET_CLASS(vdev); uint32_t val = data; if (addr + sizeof(val) > vdev->config_len) { return; } stl_p(vdev->config + addr, val); if (k->set_config) { k->set_config(vdev, vdev->config); } }
void virtio_config_writel(VirtIODevice *vdev, uint32_t addr, uint32_t data) { VirtioDeviceClass *k = VIRTIO_DEVICE_GET_CLASS(vdev); uint32_t val = data; if (addr + sizeof(val) > vdev->config_len) { return; } stl_p(vdev->config + addr, val); if (k->set_config) { k->set_config(vdev, vdev->config); } }
C
qemu
0
CVE-2011-2350
https://www.cvedetails.com/cve/CVE-2011-2350/
CWE-20
https://github.com/chromium/chromium/commit/b944f670bb7a8a919daac497a4ea0536c954c201
b944f670bb7a8a919daac497a4ea0536c954c201
[JSC] Implement a helper method createNotEnoughArgumentsError() https://bugs.webkit.org/show_bug.cgi?id=85102 Reviewed by Geoffrey Garen. In bug 84787, kbr@ requested to avoid hard-coding createTypeError(exec, "Not enough arguments") here and there. This patch implements createNotEnoughArgumentsError(exec) and uses it in JSC bindings. c.f. a corresponding bug for V8 bindings is bug 85097. Source/JavaScriptCore: * runtime/Error.cpp: (JSC::createNotEnoughArgumentsError): (JSC): * runtime/Error.h: (JSC): Source/WebCore: Test: bindings/scripts/test/TestObj.idl * bindings/scripts/CodeGeneratorJS.pm: Modified as described above. (GenerateArgumentsCountCheck): * bindings/js/JSDataViewCustom.cpp: Ditto. (WebCore::getDataViewMember): (WebCore::setDataViewMember): * bindings/js/JSDeprecatedPeerConnectionCustom.cpp: (WebCore::JSDeprecatedPeerConnectionConstructor::constructJSDeprecatedPeerConnection): * bindings/js/JSDirectoryEntryCustom.cpp: (WebCore::JSDirectoryEntry::getFile): (WebCore::JSDirectoryEntry::getDirectory): * bindings/js/JSSharedWorkerCustom.cpp: (WebCore::JSSharedWorkerConstructor::constructJSSharedWorker): * bindings/js/JSWebKitMutationObserverCustom.cpp: (WebCore::JSWebKitMutationObserverConstructor::constructJSWebKitMutationObserver): (WebCore::JSWebKitMutationObserver::observe): * bindings/js/JSWorkerCustom.cpp: (WebCore::JSWorkerConstructor::constructJSWorker): * bindings/scripts/test/JS/JSFloat64Array.cpp: Updated run-bindings-tests. (WebCore::jsFloat64ArrayPrototypeFunctionFoo): * bindings/scripts/test/JS/JSTestActiveDOMObject.cpp: (WebCore::jsTestActiveDOMObjectPrototypeFunctionExcitingFunction): (WebCore::jsTestActiveDOMObjectPrototypeFunctionPostMessage): * bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp: (WebCore::jsTestCustomNamedGetterPrototypeFunctionAnotherFunction): * bindings/scripts/test/JS/JSTestEventTarget.cpp: (WebCore::jsTestEventTargetPrototypeFunctionItem): (WebCore::jsTestEventTargetPrototypeFunctionAddEventListener): (WebCore::jsTestEventTargetPrototypeFunctionRemoveEventListener): (WebCore::jsTestEventTargetPrototypeFunctionDispatchEvent): * bindings/scripts/test/JS/JSTestInterface.cpp: (WebCore::JSTestInterfaceConstructor::constructJSTestInterface): (WebCore::jsTestInterfacePrototypeFunctionSupplementalMethod2): * bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp: (WebCore::jsTestMediaQueryListListenerPrototypeFunctionMethod): * bindings/scripts/test/JS/JSTestNamedConstructor.cpp: (WebCore::JSTestNamedConstructorNamedConstructor::constructJSTestNamedConstructor): * bindings/scripts/test/JS/JSTestObj.cpp: (WebCore::JSTestObjConstructor::constructJSTestObj): (WebCore::jsTestObjPrototypeFunctionVoidMethodWithArgs): (WebCore::jsTestObjPrototypeFunctionIntMethodWithArgs): (WebCore::jsTestObjPrototypeFunctionObjMethodWithArgs): (WebCore::jsTestObjPrototypeFunctionMethodWithSequenceArg): (WebCore::jsTestObjPrototypeFunctionMethodReturningSequence): (WebCore::jsTestObjPrototypeFunctionMethodThatRequiresAllArgsAndThrows): (WebCore::jsTestObjPrototypeFunctionSerializedValue): (WebCore::jsTestObjPrototypeFunctionIdbKey): (WebCore::jsTestObjPrototypeFunctionOptionsObject): (WebCore::jsTestObjPrototypeFunctionAddEventListener): (WebCore::jsTestObjPrototypeFunctionRemoveEventListener): (WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndOptionalArg): (WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndTwoOptionalArgs): (WebCore::jsTestObjPrototypeFunctionMethodWithCallbackArg): (WebCore::jsTestObjPrototypeFunctionMethodWithNonCallbackArgAndCallbackArg): (WebCore::jsTestObjPrototypeFunctionOverloadedMethod1): (WebCore::jsTestObjPrototypeFunctionOverloadedMethod2): (WebCore::jsTestObjPrototypeFunctionOverloadedMethod3): (WebCore::jsTestObjPrototypeFunctionOverloadedMethod4): (WebCore::jsTestObjPrototypeFunctionOverloadedMethod5): (WebCore::jsTestObjPrototypeFunctionOverloadedMethod6): (WebCore::jsTestObjPrototypeFunctionOverloadedMethod7): (WebCore::jsTestObjConstructorFunctionClassMethod2): (WebCore::jsTestObjConstructorFunctionOverloadedMethod11): (WebCore::jsTestObjConstructorFunctionOverloadedMethod12): (WebCore::jsTestObjPrototypeFunctionMethodWithUnsignedLongArray): (WebCore::jsTestObjPrototypeFunctionConvert1): (WebCore::jsTestObjPrototypeFunctionConvert2): (WebCore::jsTestObjPrototypeFunctionConvert3): (WebCore::jsTestObjPrototypeFunctionConvert4): (WebCore::jsTestObjPrototypeFunctionConvert5): (WebCore::jsTestObjPrototypeFunctionStrictFunction): * bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp: (WebCore::JSTestSerializedScriptValueInterfaceConstructor::constructJSTestSerializedScriptValueInterface): (WebCore::jsTestSerializedScriptValueInterfacePrototypeFunctionAcceptTransferList): git-svn-id: svn://svn.chromium.org/blink/trunk@115536 bbb929c8-8fbe-4397-9dbb-9b2b20218538
void JSTestNamedConstructor::finishCreation(JSGlobalData& globalData) { Base::finishCreation(globalData); ASSERT(inherits(&s_info)); }
void JSTestNamedConstructor::finishCreation(JSGlobalData& globalData) { Base::finishCreation(globalData); ASSERT(inherits(&s_info)); }
C
Chrome
0
CVE-2016-1641
https://www.cvedetails.com/cve/CVE-2016-1641/
null
https://github.com/chromium/chromium/commit/75ca8ffd7bd7c58ace1144df05e1307d8d707662
75ca8ffd7bd7c58ace1144df05e1307d8d707662
Don't call WebContents::DownloadImage() callback if the WebContents were deleted BUG=583718 Review URL: https://codereview.chromium.org/1685343004 Cr-Commit-Position: refs/heads/master@{#375700}
void WebContentsImpl::RenderViewTerminated(RenderViewHost* rvh, base::TerminationStatus status, int error_code) { if (rvh != GetRenderViewHost()) { return; } if (IsFullscreenForCurrentTab(GetRenderViewHost()->GetWidget())) ExitFullscreenMode(false); CancelActiveAndPendingDialogs(); if (delegate_) delegate_->HideValidationMessage(this); SetIsLoading(false, true, nullptr); NotifyDisconnected(); SetIsCrashed(status, error_code); ResetLoadProgressState(); FOR_EACH_OBSERVER(WebContentsObserver, observers_, RenderProcessGone(GetCrashedStatus())); }
void WebContentsImpl::RenderViewTerminated(RenderViewHost* rvh, base::TerminationStatus status, int error_code) { if (rvh != GetRenderViewHost()) { return; } if (IsFullscreenForCurrentTab(GetRenderViewHost()->GetWidget())) ExitFullscreenMode(false); CancelActiveAndPendingDialogs(); if (delegate_) delegate_->HideValidationMessage(this); SetIsLoading(false, true, nullptr); NotifyDisconnected(); SetIsCrashed(status, error_code); ResetLoadProgressState(); FOR_EACH_OBSERVER(WebContentsObserver, observers_, RenderProcessGone(GetCrashedStatus())); }
C
Chrome
0
CVE-2016-1639
https://www.cvedetails.com/cve/CVE-2016-1639/
null
https://github.com/chromium/chromium/commit/c66b1fc49870c514b1c1e8b53498153176d7ec2b
c66b1fc49870c514b1c1e8b53498153176d7ec2b
cros: Check initial auth type when showing views login. Bug: 859611 Change-Id: I0298db9bbf4aed6bd40600aef2e1c5794e8cd058 Reviewed-on: https://chromium-review.googlesource.com/1123056 Reviewed-by: Xiaoyin Hu <[email protected]> Commit-Queue: Jacob Dufault <[email protected]> Cr-Commit-Position: refs/heads/master@{#572224}
bool IsUserAllowedForARC(const AccountId& account_id) { return user_manager::UserManager::IsInitialized() && arc::IsArcAllowedForUser( user_manager::UserManager::Get()->FindUser(account_id)); }
bool IsUserAllowedForARC(const AccountId& account_id) { return user_manager::UserManager::IsInitialized() && arc::IsArcAllowedForUser( user_manager::UserManager::Get()->FindUser(account_id)); }
C
Chrome
0
null
null
null
https://github.com/chromium/chromium/commit/19190765882e272a6a2162c89acdb29110f7e3cf
19190765882e272a6a2162c89acdb29110f7e3cf
Revert 102184 - [Sync] use base::Time in sync Make EntryKernel/Entry/BaseNode use base::Time instead of int64s. Add sync/util/time.h, with utility functions to manage the sync proto time format. Store times on disk in proto format instead of the local system. This requires a database version bump (to 77). Update SessionChangeProcessor/SessionModelAssociator to use base::Time, too. Remove hackish Now() function. Remove ZeroFields() function, and instead zero-initialize in EntryKernel::EntryKernel() directly. BUG= TEST= Review URL: http://codereview.chromium.org/7981006 [email protected] Review URL: http://codereview.chromium.org/7977034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102186 0039d316-1c4b-4281-b951-d872f2087c98
bool DirectoryBackingStore::OpenAndConfigureHandleHelper( sqlite3** handle) const { if (SQLITE_OK == sqlite_utils::OpenSqliteDb(backing_filepath_, handle)) { sqlite_utils::scoped_sqlite_db_ptr scoped_handle(*handle); sqlite3_busy_timeout(scoped_handle.get(), std::numeric_limits<int>::max()); { string integrity_error; bool is_ok = CheckIntegrity(scoped_handle.get(), &integrity_error); if (!is_ok) { LOG(ERROR) << "Integrity check failed: " << integrity_error; return false; } } { sqlite_utils::SQLStatement statement; statement.prepare(scoped_handle.get(), "PRAGMA fullfsync = 1"); if (SQLITE_DONE != statement.step()) { LOG(ERROR) << sqlite3_errmsg(scoped_handle.get()); return false; } } { sqlite_utils::SQLStatement statement; statement.prepare(scoped_handle.get(), "PRAGMA synchronous = 2"); if (SQLITE_DONE != statement.step()) { LOG(ERROR) << sqlite3_errmsg(scoped_handle.get()); return false; } } sqlite3_busy_timeout(scoped_handle.release(), kDirectoryBackingStoreBusyTimeoutMs); #if defined(OS_WIN) const DWORD attrs = GetFileAttributes(backing_filepath_.value().c_str()); const BOOL attrs_set = SetFileAttributes(backing_filepath_.value().c_str(), attrs | FILE_ATTRIBUTE_NOT_CONTENT_INDEXED); #endif return true; } return false; }
bool DirectoryBackingStore::OpenAndConfigureHandleHelper( sqlite3** handle) const { if (SQLITE_OK == sqlite_utils::OpenSqliteDb(backing_filepath_, handle)) { sqlite_utils::scoped_sqlite_db_ptr scoped_handle(*handle); sqlite3_busy_timeout(scoped_handle.get(), std::numeric_limits<int>::max()); { string integrity_error; bool is_ok = CheckIntegrity(scoped_handle.get(), &integrity_error); if (!is_ok) { LOG(ERROR) << "Integrity check failed: " << integrity_error; return false; } } { sqlite_utils::SQLStatement statement; statement.prepare(scoped_handle.get(), "PRAGMA fullfsync = 1"); if (SQLITE_DONE != statement.step()) { LOG(ERROR) << sqlite3_errmsg(scoped_handle.get()); return false; } } { sqlite_utils::SQLStatement statement; statement.prepare(scoped_handle.get(), "PRAGMA synchronous = 2"); if (SQLITE_DONE != statement.step()) { LOG(ERROR) << sqlite3_errmsg(scoped_handle.get()); return false; } } sqlite3_busy_timeout(scoped_handle.release(), kDirectoryBackingStoreBusyTimeoutMs); #if defined(OS_WIN) const DWORD attrs = GetFileAttributes(backing_filepath_.value().c_str()); const BOOL attrs_set = SetFileAttributes(backing_filepath_.value().c_str(), attrs | FILE_ATTRIBUTE_NOT_CONTENT_INDEXED); #endif return true; } return false; }
C
Chrome
0
CVE-2015-6761
https://www.cvedetails.com/cve/CVE-2015-6761/
CWE-362
https://github.com/chromium/chromium/commit/fd506b0ac6c7846ae45b5034044fe85c28ee68ac
fd506b0ac6c7846ae45b5034044fe85c28ee68ac
Fix detach with open()ed document leaving parent loading indefinitely Change-Id: I26c2a054b9f1e5eb076acd677e1223058825f6d6 Bug: 803416 Test: fast/loader/document-open-iframe-then-detach.html Change-Id: I26c2a054b9f1e5eb076acd677e1223058825f6d6 Reviewed-on: https://chromium-review.googlesource.com/887298 Reviewed-by: Mike West <[email protected]> Commit-Queue: Nate Chapin <[email protected]> Cr-Commit-Position: refs/heads/master@{#532967}
static HistoryCommitType LoadTypeToCommitType(FrameLoadType type) { switch (type) { case kFrameLoadTypeStandard: return kStandardCommit; case kFrameLoadTypeInitialInChildFrame: case kFrameLoadTypeInitialHistoryLoad: return kInitialCommitInChildFrame; case kFrameLoadTypeBackForward: return kBackForwardCommit; default: break; } return kHistoryInertCommit; }
static HistoryCommitType LoadTypeToCommitType(FrameLoadType type) { switch (type) { case kFrameLoadTypeStandard: return kStandardCommit; case kFrameLoadTypeInitialInChildFrame: case kFrameLoadTypeInitialHistoryLoad: return kInitialCommitInChildFrame; case kFrameLoadTypeBackForward: return kBackForwardCommit; default: break; } return kHistoryInertCommit; }
C
Chrome
0
CVE-2015-1274
https://www.cvedetails.com/cve/CVE-2015-1274/
CWE-254
https://github.com/chromium/chromium/commit/d27468a832d5316884bd02f459cbf493697fd7e1
d27468a832d5316884bd02f459cbf493697fd7e1
Switch to equalIgnoringASCIICase throughout modules/accessibility BUG=627682 Review-Url: https://codereview.chromium.org/2793913007 Cr-Commit-Position: refs/heads/master@{#461858}
bool AXListBoxOption::canSetSelectedAttribute() const { if (!isHTMLOptionElement(getNode())) return false; if (toHTMLOptionElement(getNode())->isDisabledFormControl()) return false; HTMLSelectElement* selectElement = listBoxOptionParentNode(); if (selectElement && selectElement->isDisabledFormControl()) return false; return true; }
bool AXListBoxOption::canSetSelectedAttribute() const { if (!isHTMLOptionElement(getNode())) return false; if (toHTMLOptionElement(getNode())->isDisabledFormControl()) return false; HTMLSelectElement* selectElement = listBoxOptionParentNode(); if (selectElement && selectElement->isDisabledFormControl()) return false; return true; }
C
Chrome
0
CVE-2017-5550
https://www.cvedetails.com/cve/CVE-2017-5550/
CWE-200
https://github.com/torvalds/linux/commit/b9dc6f65bc5e232d1c05fe34b5daadc7e8bbf1fb
b9dc6f65bc5e232d1c05fe34b5daadc7e8bbf1fb
fix a fencepost error in pipe_advance() The logics in pipe_advance() used to release all buffers past the new position failed in cases when the number of buffers to release was equal to pipe->buffers. If that happened, none of them had been released, leaving pipe full. Worse, it was trivial to trigger and we end up with pipe full of uninitialized pages. IOW, it's an infoleak. Cc: [email protected] # v4.9 Reported-by: "Alan J. Wylie" <[email protected]> Tested-by: "Alan J. Wylie" <[email protected]> Signed-off-by: Al Viro <[email protected]>
size_t copy_page_from_iter(struct page *page, size_t offset, size_t bytes, struct iov_iter *i) { if (unlikely(i->type & ITER_PIPE)) { WARN_ON(1); return 0; } if (i->type & (ITER_BVEC|ITER_KVEC)) { void *kaddr = kmap_atomic(page); size_t wanted = copy_from_iter(kaddr + offset, bytes, i); kunmap_atomic(kaddr); return wanted; } else return copy_page_from_iter_iovec(page, offset, bytes, i); }
size_t copy_page_from_iter(struct page *page, size_t offset, size_t bytes, struct iov_iter *i) { if (unlikely(i->type & ITER_PIPE)) { WARN_ON(1); return 0; } if (i->type & (ITER_BVEC|ITER_KVEC)) { void *kaddr = kmap_atomic(page); size_t wanted = copy_from_iter(kaddr + offset, bytes, i); kunmap_atomic(kaddr); return wanted; } else return copy_page_from_iter_iovec(page, offset, bytes, i); }
C
linux
0
CVE-2018-17205
https://www.cvedetails.com/cve/CVE-2018-17205/
CWE-617
https://github.com/openvswitch/ovs/commit/0befd1f3745055c32940f5faf9559be6a14395e6
0befd1f3745055c32940f5faf9559be6a14395e6
ofproto: Fix OVS crash when reverting old flows in bundle commit During bundle commit flows which are added in bundle are applied to ofproto in-order. In case if a flow cannot be added (e.g. flow action is go-to group id which does not exist), OVS tries to revert back all previous flows which were successfully applied from the same bundle. This is possible since OVS maintains list of old flows which were replaced by flows from the bundle. While reinserting old flows ovs asserts due to check on rule state != RULE_INITIALIZED. This will work only for new flows, but for old flow the rule state will be RULE_REMOVED. This is causing an assert and OVS crash. The ovs assert check should be modified to != RULE_INSERTED to prevent any existing rule being re-inserted and allow new rules and old rules (in case of revert) to get inserted. Here is an example to trigger the assert: $ ovs-vsctl add-br br-test -- set Bridge br-test datapath_type=netdev $ cat flows.txt flow add table=1,priority=0,in_port=2,actions=NORMAL flow add table=1,priority=0,in_port=3,actions=NORMAL $ ovs-ofctl dump-flows -OOpenflow13 br-test cookie=0x0, duration=2.465s, table=1, n_packets=0, n_bytes=0, priority=0,in_port=2 actions=NORMAL cookie=0x0, duration=2.465s, table=1, n_packets=0, n_bytes=0, priority=0,in_port=3 actions=NORMAL $ cat flow-modify.txt flow modify table=1,priority=0,in_port=2,actions=drop flow modify table=1,priority=0,in_port=3,actions=group:10 $ ovs-ofctl bundle br-test flow-modify.txt -OOpenflow13 First flow rule will be modified since it is a valid rule. However second rule is invalid since no group with id 10 exists. Bundle commit tries to revert (insert) the first rule to old flow which results in ovs_assert at ofproto_rule_insert__() since old rule->state = RULE_REMOVED. Signed-off-by: Vishal Deep Ajmera <[email protected]> Signed-off-by: Ben Pfaff <[email protected]>
pick_datapath_id(const struct ofproto *ofproto) { const struct ofport *port; port = ofproto_get_port(ofproto, OFPP_LOCAL); if (port) { struct eth_addr ea; int error; error = netdev_get_etheraddr(port->netdev, &ea); if (!error) { return eth_addr_to_uint64(ea); } VLOG_WARN("%s: could not get MAC address for %s (%s)", ofproto->name, netdev_get_name(port->netdev), ovs_strerror(error)); } return ofproto->fallback_dpid; }
pick_datapath_id(const struct ofproto *ofproto) { const struct ofport *port; port = ofproto_get_port(ofproto, OFPP_LOCAL); if (port) { struct eth_addr ea; int error; error = netdev_get_etheraddr(port->netdev, &ea); if (!error) { return eth_addr_to_uint64(ea); } VLOG_WARN("%s: could not get MAC address for %s (%s)", ofproto->name, netdev_get_name(port->netdev), ovs_strerror(error)); } return ofproto->fallback_dpid; }
C
ovs
0
CVE-2016-2106
https://www.cvedetails.com/cve/CVE-2016-2106/
CWE-189
https://git.openssl.org/?p=openssl.git;a=commit;h=3f3582139fbb259a1c3cbb0a25236500a409bf26
3f3582139fbb259a1c3cbb0a25236500a409bf26
null
int EVP_CipherInit(EVP_CIPHER_CTX *ctx, const EVP_CIPHER *cipher, const unsigned char *key, const unsigned char *iv, int enc) { EVP_CIPHER_CTX_reset(ctx); return EVP_CipherInit_ex(ctx, cipher, NULL, key, iv, enc); }
int EVP_CipherInit(EVP_CIPHER_CTX *ctx, const EVP_CIPHER *cipher, const unsigned char *key, const unsigned char *iv, int enc) { EVP_CIPHER_CTX_reset(ctx); return EVP_CipherInit_ex(ctx, cipher, NULL, key, iv, enc); }
C
openssl
0
null
null
null
https://github.com/chromium/chromium/commit/a44b00c88bc5ea35b5b150217c5fd6e4ce168e58
a44b00c88bc5ea35b5b150217c5fd6e4ce168e58
Apply behaviour change fix from upstream for previous XPath change. BUG=58731 TEST=NONE Review URL: http://codereview.chromium.org/4027006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63572 0039d316-1c4b-4281-b951-d872f2087c98
xmlXPathNewNodeSet(xmlNodePtr val) { xmlXPathObjectPtr ret; ret = (xmlXPathObjectPtr) xmlMalloc(sizeof(xmlXPathObject)); if (ret == NULL) { xmlXPathErrMemory(NULL, "creating nodeset\n"); return(NULL); } memset(ret, 0 , (size_t) sizeof(xmlXPathObject)); ret->type = XPATH_NODESET; ret->boolval = 0; ret->nodesetval = xmlXPathNodeSetCreate(val); /* @@ with_ns to check whether namespace nodes should be looked at @@ */ #ifdef XP_DEBUG_OBJ_USAGE xmlXPathDebugObjUsageRequested(NULL, XPATH_NODESET); #endif return(ret); }
xmlXPathNewNodeSet(xmlNodePtr val) { xmlXPathObjectPtr ret; ret = (xmlXPathObjectPtr) xmlMalloc(sizeof(xmlXPathObject)); if (ret == NULL) { xmlXPathErrMemory(NULL, "creating nodeset\n"); return(NULL); } memset(ret, 0 , (size_t) sizeof(xmlXPathObject)); ret->type = XPATH_NODESET; ret->boolval = 0; ret->nodesetval = xmlXPathNodeSetCreate(val); /* @@ with_ns to check whether namespace nodes should be looked at @@ */ #ifdef XP_DEBUG_OBJ_USAGE xmlXPathDebugObjUsageRequested(NULL, XPATH_NODESET); #endif return(ret); }
C
Chrome
0
null
null
null
https://github.com/chromium/chromium/commit/181c7400b2bf50ba02ac77149749fb419b4d4797
181c7400b2bf50ba02ac77149749fb419b4d4797
gpu: Use GetUniformSetup computed result size. [email protected] BUG=468936 Review URL: https://codereview.chromium.org/1016193003 Cr-Commit-Position: refs/heads/master@{#321489}
void GLES2DecoderImpl::Destroy(bool have_context) { if (!initialized()) return; DCHECK(!have_context || context_->IsCurrent(NULL)); state_.vertex_attrib_manager = NULL; state_.default_vertex_attrib_manager = NULL; state_.texture_units.clear(); state_.bound_array_buffer = NULL; state_.current_queries.clear(); framebuffer_state_.bound_read_framebuffer = NULL; framebuffer_state_.bound_draw_framebuffer = NULL; state_.bound_renderbuffer = NULL; state_.bound_valuebuffer = NULL; if (offscreen_saved_color_texture_info_.get()) { DCHECK(offscreen_target_color_texture_); DCHECK_EQ(offscreen_saved_color_texture_info_->service_id(), offscreen_saved_color_texture_->id()); offscreen_saved_color_texture_->Invalidate(); offscreen_saved_color_texture_info_ = NULL; } if (have_context) { if (copy_texture_CHROMIUM_.get()) { copy_texture_CHROMIUM_->Destroy(); copy_texture_CHROMIUM_.reset(); } clear_framebuffer_blit_.reset(); if (state_.current_program.get()) { program_manager()->UnuseProgram(shader_manager(), state_.current_program.get()); } if (attrib_0_buffer_id_) { glDeleteBuffersARB(1, &attrib_0_buffer_id_); } if (fixed_attrib_buffer_id_) { glDeleteBuffersARB(1, &fixed_attrib_buffer_id_); } if (validation_texture_) { glDeleteTextures(1, &validation_texture_); glDeleteFramebuffersEXT(1, &validation_fbo_multisample_); glDeleteFramebuffersEXT(1, &validation_fbo_); } if (offscreen_target_frame_buffer_.get()) offscreen_target_frame_buffer_->Destroy(); if (offscreen_target_color_texture_.get()) offscreen_target_color_texture_->Destroy(); if (offscreen_target_color_render_buffer_.get()) offscreen_target_color_render_buffer_->Destroy(); if (offscreen_target_depth_render_buffer_.get()) offscreen_target_depth_render_buffer_->Destroy(); if (offscreen_target_stencil_render_buffer_.get()) offscreen_target_stencil_render_buffer_->Destroy(); if (offscreen_saved_frame_buffer_.get()) offscreen_saved_frame_buffer_->Destroy(); if (offscreen_saved_color_texture_.get()) offscreen_saved_color_texture_->Destroy(); if (offscreen_resolved_frame_buffer_.get()) offscreen_resolved_frame_buffer_->Destroy(); if (offscreen_resolved_color_texture_.get()) offscreen_resolved_color_texture_->Destroy(); } else { if (offscreen_target_frame_buffer_.get()) offscreen_target_frame_buffer_->Invalidate(); if (offscreen_target_color_texture_.get()) offscreen_target_color_texture_->Invalidate(); if (offscreen_target_color_render_buffer_.get()) offscreen_target_color_render_buffer_->Invalidate(); if (offscreen_target_depth_render_buffer_.get()) offscreen_target_depth_render_buffer_->Invalidate(); if (offscreen_target_stencil_render_buffer_.get()) offscreen_target_stencil_render_buffer_->Invalidate(); if (offscreen_saved_frame_buffer_.get()) offscreen_saved_frame_buffer_->Invalidate(); if (offscreen_saved_color_texture_.get()) offscreen_saved_color_texture_->Invalidate(); if (offscreen_resolved_frame_buffer_.get()) offscreen_resolved_frame_buffer_->Invalidate(); if (offscreen_resolved_color_texture_.get()) offscreen_resolved_color_texture_->Invalidate(); } state_.current_program = NULL; copy_texture_CHROMIUM_.reset(); clear_framebuffer_blit_.reset(); if (query_manager_.get()) { query_manager_->Destroy(have_context); query_manager_.reset(); } if (vertex_array_manager_ .get()) { vertex_array_manager_->Destroy(have_context); vertex_array_manager_.reset(); } if (image_manager_.get()) { image_manager_->Destroy(have_context); image_manager_.reset(); } offscreen_target_frame_buffer_.reset(); offscreen_target_color_texture_.reset(); offscreen_target_color_render_buffer_.reset(); offscreen_target_depth_render_buffer_.reset(); offscreen_target_stencil_render_buffer_.reset(); offscreen_saved_frame_buffer_.reset(); offscreen_saved_color_texture_.reset(); offscreen_resolved_frame_buffer_.reset(); offscreen_resolved_color_texture_.reset(); fragment_translator_ = NULL; vertex_translator_ = NULL; async_pixel_transfer_manager_.reset(); if (group_.get()) { framebuffer_manager()->RemoveObserver(this); group_->Destroy(this, have_context); group_ = NULL; } if (context_.get()) { context_->ReleaseCurrent(NULL); context_ = NULL; } #if defined(OS_MACOSX) for (TextureToIOSurfaceMap::iterator it = texture_to_io_surface_map_.begin(); it != texture_to_io_surface_map_.end(); ++it) { CFRelease(it->second); } texture_to_io_surface_map_.clear(); #endif }
void GLES2DecoderImpl::Destroy(bool have_context) { if (!initialized()) return; DCHECK(!have_context || context_->IsCurrent(NULL)); state_.vertex_attrib_manager = NULL; state_.default_vertex_attrib_manager = NULL; state_.texture_units.clear(); state_.bound_array_buffer = NULL; state_.current_queries.clear(); framebuffer_state_.bound_read_framebuffer = NULL; framebuffer_state_.bound_draw_framebuffer = NULL; state_.bound_renderbuffer = NULL; state_.bound_valuebuffer = NULL; if (offscreen_saved_color_texture_info_.get()) { DCHECK(offscreen_target_color_texture_); DCHECK_EQ(offscreen_saved_color_texture_info_->service_id(), offscreen_saved_color_texture_->id()); offscreen_saved_color_texture_->Invalidate(); offscreen_saved_color_texture_info_ = NULL; } if (have_context) { if (copy_texture_CHROMIUM_.get()) { copy_texture_CHROMIUM_->Destroy(); copy_texture_CHROMIUM_.reset(); } clear_framebuffer_blit_.reset(); if (state_.current_program.get()) { program_manager()->UnuseProgram(shader_manager(), state_.current_program.get()); } if (attrib_0_buffer_id_) { glDeleteBuffersARB(1, &attrib_0_buffer_id_); } if (fixed_attrib_buffer_id_) { glDeleteBuffersARB(1, &fixed_attrib_buffer_id_); } if (validation_texture_) { glDeleteTextures(1, &validation_texture_); glDeleteFramebuffersEXT(1, &validation_fbo_multisample_); glDeleteFramebuffersEXT(1, &validation_fbo_); } if (offscreen_target_frame_buffer_.get()) offscreen_target_frame_buffer_->Destroy(); if (offscreen_target_color_texture_.get()) offscreen_target_color_texture_->Destroy(); if (offscreen_target_color_render_buffer_.get()) offscreen_target_color_render_buffer_->Destroy(); if (offscreen_target_depth_render_buffer_.get()) offscreen_target_depth_render_buffer_->Destroy(); if (offscreen_target_stencil_render_buffer_.get()) offscreen_target_stencil_render_buffer_->Destroy(); if (offscreen_saved_frame_buffer_.get()) offscreen_saved_frame_buffer_->Destroy(); if (offscreen_saved_color_texture_.get()) offscreen_saved_color_texture_->Destroy(); if (offscreen_resolved_frame_buffer_.get()) offscreen_resolved_frame_buffer_->Destroy(); if (offscreen_resolved_color_texture_.get()) offscreen_resolved_color_texture_->Destroy(); } else { if (offscreen_target_frame_buffer_.get()) offscreen_target_frame_buffer_->Invalidate(); if (offscreen_target_color_texture_.get()) offscreen_target_color_texture_->Invalidate(); if (offscreen_target_color_render_buffer_.get()) offscreen_target_color_render_buffer_->Invalidate(); if (offscreen_target_depth_render_buffer_.get()) offscreen_target_depth_render_buffer_->Invalidate(); if (offscreen_target_stencil_render_buffer_.get()) offscreen_target_stencil_render_buffer_->Invalidate(); if (offscreen_saved_frame_buffer_.get()) offscreen_saved_frame_buffer_->Invalidate(); if (offscreen_saved_color_texture_.get()) offscreen_saved_color_texture_->Invalidate(); if (offscreen_resolved_frame_buffer_.get()) offscreen_resolved_frame_buffer_->Invalidate(); if (offscreen_resolved_color_texture_.get()) offscreen_resolved_color_texture_->Invalidate(); } state_.current_program = NULL; copy_texture_CHROMIUM_.reset(); clear_framebuffer_blit_.reset(); if (query_manager_.get()) { query_manager_->Destroy(have_context); query_manager_.reset(); } if (vertex_array_manager_ .get()) { vertex_array_manager_->Destroy(have_context); vertex_array_manager_.reset(); } if (image_manager_.get()) { image_manager_->Destroy(have_context); image_manager_.reset(); } offscreen_target_frame_buffer_.reset(); offscreen_target_color_texture_.reset(); offscreen_target_color_render_buffer_.reset(); offscreen_target_depth_render_buffer_.reset(); offscreen_target_stencil_render_buffer_.reset(); offscreen_saved_frame_buffer_.reset(); offscreen_saved_color_texture_.reset(); offscreen_resolved_frame_buffer_.reset(); offscreen_resolved_color_texture_.reset(); fragment_translator_ = NULL; vertex_translator_ = NULL; async_pixel_transfer_manager_.reset(); if (group_.get()) { framebuffer_manager()->RemoveObserver(this); group_->Destroy(this, have_context); group_ = NULL; } if (context_.get()) { context_->ReleaseCurrent(NULL); context_ = NULL; } #if defined(OS_MACOSX) for (TextureToIOSurfaceMap::iterator it = texture_to_io_surface_map_.begin(); it != texture_to_io_surface_map_.end(); ++it) { CFRelease(it->second); } texture_to_io_surface_map_.clear(); #endif }
C
Chrome
0
CVE-2016-10746
https://www.cvedetails.com/cve/CVE-2016-10746/
CWE-254
https://github.com/libvirt/libvirt/commit/506e9d6c2d4baaf580d489fff0690c0ff2ff588f
506e9d6c2d4baaf580d489fff0690c0ff2ff588f
virDomainGetTime: Deny on RO connections We have a policy that if API may end up talking to a guest agent it should require RW connection. We don't obey the rule in virDomainGetTime(). Signed-off-by: Michal Privoznik <[email protected]>
virDomainCreateLinux(virConnectPtr conn, const char *xmlDesc, unsigned int flags) { return virDomainCreateXML(conn, xmlDesc, flags); }
virDomainCreateLinux(virConnectPtr conn, const char *xmlDesc, unsigned int flags) { return virDomainCreateXML(conn, xmlDesc, flags); }
C
libvirt
0
CVE-2015-8543
https://www.cvedetails.com/cve/CVE-2015-8543/
null
https://github.com/torvalds/linux/commit/79462ad02e861803b3840cc782248c7359451cd9
79462ad02e861803b3840cc782248c7359451cd9
net: add validation for the socket syscall protocol argument 郭永刚 reported that one could simply crash the kernel as root by using a simple program: int socket_fd; struct sockaddr_in addr; addr.sin_port = 0; addr.sin_addr.s_addr = INADDR_ANY; addr.sin_family = 10; socket_fd = socket(10,3,0x40000000); connect(socket_fd , &addr,16); AF_INET, AF_INET6 sockets actually only support 8-bit protocol identifiers. inet_sock's skc_protocol field thus is sized accordingly, thus larger protocol identifiers simply cut off the higher bits and store a zero in the protocol fields. This could lead to e.g. NULL function pointer because as a result of the cut off inet_num is zero and we call down to inet_autobind, which is NULL for raw sockets. kernel: Call Trace: kernel: [<ffffffff816db90e>] ? inet_autobind+0x2e/0x70 kernel: [<ffffffff816db9a4>] inet_dgram_connect+0x54/0x80 kernel: [<ffffffff81645069>] SYSC_connect+0xd9/0x110 kernel: [<ffffffff810ac51b>] ? ptrace_notify+0x5b/0x80 kernel: [<ffffffff810236d8>] ? syscall_trace_enter_phase2+0x108/0x200 kernel: [<ffffffff81645e0e>] SyS_connect+0xe/0x10 kernel: [<ffffffff81779515>] tracesys_phase2+0x84/0x89 I found no particular commit which introduced this problem. CVE: CVE-2015-8543 Cc: Cong Wang <[email protected]> Reported-by: 郭永刚 <[email protected]> Signed-off-by: Hannes Frederic Sowa <[email protected]> Signed-off-by: David S. Miller <[email protected]>
static int dn_shutdown(struct socket *sock, int how) { struct sock *sk = sock->sk; struct dn_scp *scp = DN_SK(sk); int err = -ENOTCONN; lock_sock(sk); if (sock->state == SS_UNCONNECTED) goto out; err = 0; if (sock->state == SS_DISCONNECTING) goto out; err = -EINVAL; if (scp->state == DN_O) goto out; if (how != SHUT_RDWR) goto out; sk->sk_shutdown = SHUTDOWN_MASK; dn_destroy_sock(sk); err = 0; out: release_sock(sk); return err; }
static int dn_shutdown(struct socket *sock, int how) { struct sock *sk = sock->sk; struct dn_scp *scp = DN_SK(sk); int err = -ENOTCONN; lock_sock(sk); if (sock->state == SS_UNCONNECTED) goto out; err = 0; if (sock->state == SS_DISCONNECTING) goto out; err = -EINVAL; if (scp->state == DN_O) goto out; if (how != SHUT_RDWR) goto out; sk->sk_shutdown = SHUTDOWN_MASK; dn_destroy_sock(sk); err = 0; out: release_sock(sk); return err; }
C
linux
0
CVE-2011-2918
https://www.cvedetails.com/cve/CVE-2011-2918/
CWE-399
https://github.com/torvalds/linux/commit/a8b0ca17b80e92faab46ee7179ba9e99ccb61233
a8b0ca17b80e92faab46ee7179ba9e99ccb61233
perf: Remove the nmi parameter from the swevent and overflow interface The nmi parameter indicated if we could do wakeups from the current context, if not, we would set some state and self-IPI and let the resulting interrupt do the wakeup. For the various event classes: - hardware: nmi=0; PMI is in fact an NMI or we run irq_work_run from the PMI-tail (ARM etc.) - tracepoint: nmi=0; since tracepoint could be from NMI context. - software: nmi=[0,1]; some, like the schedule thing cannot perform wakeups, and hence need 0. As one can see, there is very little nmi=1 usage, and the down-side of not using it is that on some platforms some software events can have a jiffy delay in wakeup (when arch_irq_work_raise isn't implemented). The up-side however is that we can remove the nmi parameter and save a bunch of conditionals in fast paths. Signed-off-by: Peter Zijlstra <[email protected]> Cc: Michael Cree <[email protected]> Cc: Will Deacon <[email protected]> Cc: Deng-Cheng Zhu <[email protected]> Cc: Anton Blanchard <[email protected]> Cc: Eric B Munson <[email protected]> Cc: Heiko Carstens <[email protected]> Cc: Paul Mundt <[email protected]> Cc: David S. Miller <[email protected]> Cc: Frederic Weisbecker <[email protected]> Cc: Jason Wessel <[email protected]> Cc: Don Zickus <[email protected]> Link: http://lkml.kernel.org/n/[email protected] Signed-off-by: Ingo Molnar <[email protected]>
xscale2pmu_handle_irq(int irq_num, void *dev) { unsigned long pmnc, of_flags; struct perf_sample_data data; struct cpu_hw_events *cpuc; struct pt_regs *regs; int idx; /* Disable the PMU. */ pmnc = xscale2pmu_read_pmnc(); xscale2pmu_write_pmnc(pmnc & ~XSCALE_PMU_ENABLE); /* Check the overflow flag register. */ of_flags = xscale2pmu_read_overflow_flags(); if (!(of_flags & XSCALE2_OVERFLOWED_MASK)) return IRQ_NONE; /* Clear the overflow bits. */ xscale2pmu_write_overflow_flags(of_flags); regs = get_irq_regs(); perf_sample_data_init(&data, 0); cpuc = &__get_cpu_var(cpu_hw_events); for (idx = 0; idx <= armpmu->num_events; ++idx) { struct perf_event *event = cpuc->events[idx]; struct hw_perf_event *hwc; if (!test_bit(idx, cpuc->active_mask)) continue; if (!xscale2_pmnc_counter_has_overflowed(pmnc, idx)) continue; hwc = &event->hw; armpmu_event_update(event, hwc, idx, 1); data.period = event->hw.last_period; if (!armpmu_event_set_period(event, hwc, idx)) continue; if (perf_event_overflow(event, &data, regs)) armpmu->disable(hwc, idx); } irq_work_run(); /* * Re-enable the PMU. */ pmnc = xscale2pmu_read_pmnc() | XSCALE_PMU_ENABLE; xscale2pmu_write_pmnc(pmnc); return IRQ_HANDLED; }
xscale2pmu_handle_irq(int irq_num, void *dev) { unsigned long pmnc, of_flags; struct perf_sample_data data; struct cpu_hw_events *cpuc; struct pt_regs *regs; int idx; /* Disable the PMU. */ pmnc = xscale2pmu_read_pmnc(); xscale2pmu_write_pmnc(pmnc & ~XSCALE_PMU_ENABLE); /* Check the overflow flag register. */ of_flags = xscale2pmu_read_overflow_flags(); if (!(of_flags & XSCALE2_OVERFLOWED_MASK)) return IRQ_NONE; /* Clear the overflow bits. */ xscale2pmu_write_overflow_flags(of_flags); regs = get_irq_regs(); perf_sample_data_init(&data, 0); cpuc = &__get_cpu_var(cpu_hw_events); for (idx = 0; idx <= armpmu->num_events; ++idx) { struct perf_event *event = cpuc->events[idx]; struct hw_perf_event *hwc; if (!test_bit(idx, cpuc->active_mask)) continue; if (!xscale2_pmnc_counter_has_overflowed(pmnc, idx)) continue; hwc = &event->hw; armpmu_event_update(event, hwc, idx, 1); data.period = event->hw.last_period; if (!armpmu_event_set_period(event, hwc, idx)) continue; if (perf_event_overflow(event, 0, &data, regs)) armpmu->disable(hwc, idx); } irq_work_run(); /* * Re-enable the PMU. */ pmnc = xscale2pmu_read_pmnc() | XSCALE_PMU_ENABLE; xscale2pmu_write_pmnc(pmnc); return IRQ_HANDLED; }
C
linux
1
CVE-2017-7191
https://www.cvedetails.com/cve/CVE-2017-7191/
CWE-416
https://github.com/irssi/irssi/commit/77b2631c78461965bc9a7414aae206b5c514e1b3
77b2631c78461965bc9a7414aae206b5c514e1b3
Merge branch 'netjoin-timeout' into 'master' fe-netjoin: remove irc servers on "server disconnected" signal Closes #7 See merge request !10
static void msg_join(IRC_SERVER_REC *server, const char *channel, const char *nick, const char *address) { NETSPLIT_REC *split; NETJOIN_REC *netjoin; GSList *channels; int rejoin = 1; if (!IS_IRC_SERVER(server)) return; if (ignore_check(SERVER(server), nick, address, channel, NULL, MSGLEVEL_JOINS)) return; split = netsplit_find(server, nick, address); netjoin = netjoin_find(server, nick); if (split == NULL && netjoin == NULL) return; /* if this was not a channel they split from, treat it normally */ if (netjoin != NULL) { if (!gslist_find_icase_string(netjoin->old_channels, channel)) return; } else { channels = split->channels; while (channels != NULL) { NETSPLIT_CHAN_REC *schannel = channels->data; if (!strcasecmp(schannel->name, channel)) break; channels = channels->next; } /* we still need to create a NETJOIN_REC now as the * NETSPLIT_REC will be destroyed */ if (channels == NULL) rejoin = 0; } if (join_tag == -1) { join_tag = g_timeout_add(1000, (GSourceFunc) sig_check_netjoins, NULL); signal_add("print starting", (SIGNAL_FUNC) sig_print_starting); } if (netjoin == NULL) netjoin = netjoin_add(server, nick, split->channels); if (rejoin) { netjoin->now_channels = g_slist_append(netjoin->now_channels, g_strconcat(" ", channel, NULL)); signal_stop(); } }
static void msg_join(IRC_SERVER_REC *server, const char *channel, const char *nick, const char *address) { NETSPLIT_REC *split; NETJOIN_REC *netjoin; GSList *channels; int rejoin = 1; if (!IS_IRC_SERVER(server)) return; if (ignore_check(SERVER(server), nick, address, channel, NULL, MSGLEVEL_JOINS)) return; split = netsplit_find(server, nick, address); netjoin = netjoin_find(server, nick); if (split == NULL && netjoin == NULL) return; /* if this was not a channel they split from, treat it normally */ if (netjoin != NULL) { if (!gslist_find_icase_string(netjoin->old_channels, channel)) return; } else { channels = split->channels; while (channels != NULL) { NETSPLIT_CHAN_REC *schannel = channels->data; if (!strcasecmp(schannel->name, channel)) break; channels = channels->next; } /* we still need to create a NETJOIN_REC now as the * NETSPLIT_REC will be destroyed */ if (channels == NULL) rejoin = 0; } if (join_tag == -1) { join_tag = g_timeout_add(1000, (GSourceFunc) sig_check_netjoins, NULL); signal_add("print starting", (SIGNAL_FUNC) sig_print_starting); } if (netjoin == NULL) netjoin = netjoin_add(server, nick, split->channels); if (rejoin) { netjoin->now_channels = g_slist_append(netjoin->now_channels, g_strconcat(" ", channel, NULL)); signal_stop(); } }
C
irssi
0
CVE-2013-7271
https://www.cvedetails.com/cve/CVE-2013-7271/
CWE-20
https://github.com/torvalds/linux/commit/f3d3342602f8bcbf37d7c46641cb9bca7618eb1c
f3d3342602f8bcbf37d7c46641cb9bca7618eb1c
net: rework recvmsg handler msg_name and msg_namelen logic This patch now always passes msg->msg_namelen as 0. recvmsg handlers must set msg_namelen to the proper size <= sizeof(struct sockaddr_storage) to return msg_name to the user. This prevents numerous uninitialized memory leaks we had in the recvmsg handlers and makes it harder for new code to accidentally leak uninitialized memory. Optimize for the case recvfrom is called with NULL as address. We don't need to copy the address at all, so set it to NULL before invoking the recvmsg handler. We can do so, because all the recvmsg handlers must cope with the case a plain read() is called on them. read() also sets msg_name to NULL. Also document these changes in include/linux/net.h as suggested by David Miller. Changes since RFC: Set msg->msg_name = NULL if user specified a NULL in msg_name but had a non-null msg_namelen in verify_iovec/verify_compat_iovec. This doesn't affect sendto as it would bail out earlier while trying to copy-in the address. It also more naturally reflects the logic by the callers of verify_iovec. With this change in place I could remove " if (!uaddr || msg_sys->msg_namelen == 0) msg->msg_name = NULL ". This change does not alter the user visible error logic as we ignore msg_namelen as long as msg_name is NULL. Also remove two unnecessary curly brackets in ___sys_recvmsg and change comments to netdev style. Cc: David Miller <[email protected]> Suggested-by: Eric Dumazet <[email protected]> Signed-off-by: Hannes Frederic Sowa <[email protected]> Signed-off-by: David S. Miller <[email protected]>
data_sock_bind(struct socket *sock, struct sockaddr *addr, int addr_len) { struct sockaddr_mISDN *maddr = (struct sockaddr_mISDN *) addr; struct sock *sk = sock->sk; struct sock *csk; int err = 0; if (*debug & DEBUG_SOCKET) printk(KERN_DEBUG "%s(%p) sk=%p\n", __func__, sock, sk); if (addr_len != sizeof(struct sockaddr_mISDN)) return -EINVAL; if (!maddr || maddr->family != AF_ISDN) return -EINVAL; lock_sock(sk); if (_pms(sk)->dev) { err = -EALREADY; goto done; } _pms(sk)->dev = get_mdevice(maddr->dev); if (!_pms(sk)->dev) { err = -ENODEV; goto done; } if (sk->sk_protocol < ISDN_P_B_START) { read_lock_bh(&data_sockets.lock); sk_for_each(csk, &data_sockets.head) { if (sk == csk) continue; if (_pms(csk)->dev != _pms(sk)->dev) continue; if (csk->sk_protocol >= ISDN_P_B_START) continue; if (IS_ISDN_P_TE(csk->sk_protocol) == IS_ISDN_P_TE(sk->sk_protocol)) continue; read_unlock_bh(&data_sockets.lock); err = -EBUSY; goto done; } read_unlock_bh(&data_sockets.lock); } _pms(sk)->ch.send = mISDN_send; _pms(sk)->ch.ctrl = mISDN_ctrl; switch (sk->sk_protocol) { case ISDN_P_TE_S0: case ISDN_P_NT_S0: case ISDN_P_TE_E1: case ISDN_P_NT_E1: mISDN_sock_unlink(&data_sockets, sk); err = connect_layer1(_pms(sk)->dev, &_pms(sk)->ch, sk->sk_protocol, maddr); if (err) mISDN_sock_link(&data_sockets, sk); break; case ISDN_P_LAPD_TE: case ISDN_P_LAPD_NT: err = create_l2entity(_pms(sk)->dev, &_pms(sk)->ch, sk->sk_protocol, maddr); break; case ISDN_P_B_RAW: case ISDN_P_B_HDLC: case ISDN_P_B_X75SLP: case ISDN_P_B_L2DTMF: case ISDN_P_B_L2DSP: case ISDN_P_B_L2DSPHDLC: err = connect_Bstack(_pms(sk)->dev, &_pms(sk)->ch, sk->sk_protocol, maddr); break; default: err = -EPROTONOSUPPORT; } if (err) goto done; sk->sk_state = MISDN_BOUND; _pms(sk)->ch.protocol = sk->sk_protocol; done: release_sock(sk); return err; }
data_sock_bind(struct socket *sock, struct sockaddr *addr, int addr_len) { struct sockaddr_mISDN *maddr = (struct sockaddr_mISDN *) addr; struct sock *sk = sock->sk; struct sock *csk; int err = 0; if (*debug & DEBUG_SOCKET) printk(KERN_DEBUG "%s(%p) sk=%p\n", __func__, sock, sk); if (addr_len != sizeof(struct sockaddr_mISDN)) return -EINVAL; if (!maddr || maddr->family != AF_ISDN) return -EINVAL; lock_sock(sk); if (_pms(sk)->dev) { err = -EALREADY; goto done; } _pms(sk)->dev = get_mdevice(maddr->dev); if (!_pms(sk)->dev) { err = -ENODEV; goto done; } if (sk->sk_protocol < ISDN_P_B_START) { read_lock_bh(&data_sockets.lock); sk_for_each(csk, &data_sockets.head) { if (sk == csk) continue; if (_pms(csk)->dev != _pms(sk)->dev) continue; if (csk->sk_protocol >= ISDN_P_B_START) continue; if (IS_ISDN_P_TE(csk->sk_protocol) == IS_ISDN_P_TE(sk->sk_protocol)) continue; read_unlock_bh(&data_sockets.lock); err = -EBUSY; goto done; } read_unlock_bh(&data_sockets.lock); } _pms(sk)->ch.send = mISDN_send; _pms(sk)->ch.ctrl = mISDN_ctrl; switch (sk->sk_protocol) { case ISDN_P_TE_S0: case ISDN_P_NT_S0: case ISDN_P_TE_E1: case ISDN_P_NT_E1: mISDN_sock_unlink(&data_sockets, sk); err = connect_layer1(_pms(sk)->dev, &_pms(sk)->ch, sk->sk_protocol, maddr); if (err) mISDN_sock_link(&data_sockets, sk); break; case ISDN_P_LAPD_TE: case ISDN_P_LAPD_NT: err = create_l2entity(_pms(sk)->dev, &_pms(sk)->ch, sk->sk_protocol, maddr); break; case ISDN_P_B_RAW: case ISDN_P_B_HDLC: case ISDN_P_B_X75SLP: case ISDN_P_B_L2DTMF: case ISDN_P_B_L2DSP: case ISDN_P_B_L2DSPHDLC: err = connect_Bstack(_pms(sk)->dev, &_pms(sk)->ch, sk->sk_protocol, maddr); break; default: err = -EPROTONOSUPPORT; } if (err) goto done; sk->sk_state = MISDN_BOUND; _pms(sk)->ch.protocol = sk->sk_protocol; done: release_sock(sk); return err; }
C
linux
0
CVE-2014-3194
https://www.cvedetails.com/cve/CVE-2014-3194/
CWE-416
https://github.com/chromium/chromium/commit/05c619eb6e7dac046afc72c0d5381856f87fb421
05c619eb6e7dac046afc72c0d5381856f87fb421
exo: Reduce side-effects of dynamic activation code. This code exists for clients that need to managed their own system modal dialogs. Since the addition of the remote surface API we can limit the impact of this to surfaces created for system modal container. BUG=29528396 Review-Url: https://codereview.chromium.org/2084023003 Cr-Commit-Position: refs/heads/master@{#401115}
void ShellSurface::OnPostWindowStateTypeChange( ash::wm::WindowState* window_state, ash::wm::WindowStateType old_type) { ash::wm::WindowStateType new_type = window_state->GetStateType(); if (ash::wm::IsMaximizedOrFullscreenOrPinnedWindowStateType(old_type) || ash::wm::IsMaximizedOrFullscreenOrPinnedWindowStateType(new_type)) { Configure(); } if (widget_) UpdateWidgetBounds(); if (!state_changed_callback_.is_null()) state_changed_callback_.Run(old_type, new_type); scoped_animations_disabled_.reset(); }
void ShellSurface::OnPostWindowStateTypeChange( ash::wm::WindowState* window_state, ash::wm::WindowStateType old_type) { ash::wm::WindowStateType new_type = window_state->GetStateType(); if (ash::wm::IsMaximizedOrFullscreenOrPinnedWindowStateType(old_type) || ash::wm::IsMaximizedOrFullscreenOrPinnedWindowStateType(new_type)) { Configure(); } if (widget_) UpdateWidgetBounds(); if (!state_changed_callback_.is_null()) state_changed_callback_.Run(old_type, new_type); scoped_animations_disabled_.reset(); }
C
Chrome
0
CVE-2011-1800
https://www.cvedetails.com/cve/CVE-2011-1800/
CWE-189
https://github.com/chromium/chromium/commit/1777aa6484af15014b8691082a8c3075418786f5
1777aa6484af15014b8691082a8c3075418786f5
[Qt][WK2] Allow transparent WebViews https://bugs.webkit.org/show_bug.cgi?id=80608 Reviewed by Tor Arne Vestbø. Added support for transparentBackground in QQuickWebViewExperimental. This uses the existing drawsTransparentBackground property in WebKit2. Also, changed LayerTreeHostQt to set the contentsOpaque flag when the root layer changes, otherwise the change doesn't take effect. A new API test was added. * UIProcess/API/qt/qquickwebview.cpp: (QQuickWebViewPrivate::setTransparentBackground): (QQuickWebViewPrivate::transparentBackground): (QQuickWebViewExperimental::transparentBackground): (QQuickWebViewExperimental::setTransparentBackground): * UIProcess/API/qt/qquickwebview_p.h: * UIProcess/API/qt/qquickwebview_p_p.h: (QQuickWebViewPrivate): * UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp: (tst_QQuickWebView): (tst_QQuickWebView::transparentWebViews): * WebProcess/WebPage/qt/LayerTreeHostQt.cpp: (WebKit::LayerTreeHostQt::LayerTreeHostQt): (WebKit::LayerTreeHostQt::setRootCompositingLayer): git-svn-id: svn://svn.chromium.org/blink/trunk@110254 bbb929c8-8fbe-4397-9dbb-9b2b20218538
void QQuickWebView::goForward() { Q_D(QQuickWebView); d->webPageProxy->goForward(); }
void QQuickWebView::goForward() { Q_D(QQuickWebView); d->webPageProxy->goForward(); }
C
Chrome
0
CVE-2018-18339
https://www.cvedetails.com/cve/CVE-2018-18339/
CWE-119
https://github.com/chromium/chromium/commit/e34e01b1b0987e418bc22e3ef1cf2e4ecaead264
e34e01b1b0987e418bc22e3ef1cf2e4ecaead264
[scheduler] Remove implicit fallthrough in switch Bail out early when a condition in the switch is fulfilled. This does not change behaviour due to RemoveTaskObserver being no-op when the task observer is not present in the list. [email protected] Bug: 177475 Change-Id: Ibc7772c79f8a8c8a1d63a997dabe1efda5d3a7bd Reviewed-on: https://chromium-review.googlesource.com/891187 Reviewed-by: Nico Weber <[email protected]> Commit-Queue: Alexander Timin <[email protected]> Cr-Commit-Position: refs/heads/master@{#532649}
RendererSchedulerImpl::AsValue(base::TimeTicks optional_now) const { base::AutoLock lock(any_thread_lock_); return AsValueLocked(optional_now); }
RendererSchedulerImpl::AsValue(base::TimeTicks optional_now) const { base::AutoLock lock(any_thread_lock_); return AsValueLocked(optional_now); }
C
Chrome
0
CVE-2016-5200
https://www.cvedetails.com/cve/CVE-2016-5200/
CWE-119
https://github.com/chromium/chromium/commit/2f19869af13bbfdcfd682a55c0d2c61c6e102475
2f19869af13bbfdcfd682a55c0d2c61c6e102475
chrome/browser/ui/webauthn: long domains may cause a line break. As requested by UX in [1], allow long host names to split a title into two lines. This allows us to show more of the name before eliding, although sufficiently long names will still trigger elision. Screenshot at https://drive.google.com/open?id=1_V6t2CeZDAVazy3Px-OET2LnB__aEW1r. [1] https://docs.google.com/presentation/d/1TtxkPUchyVZulqgdMcfui-68B0W-DWaFFVJEffGIbLA/edit#slide=id.g5913c4105f_1_12 Change-Id: I70f6541e0db3e9942239304de43b487a7561ca34 Bug: 870892 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601812 Auto-Submit: Adam Langley <[email protected]> Commit-Queue: Nina Satragno <[email protected]> Reviewed-by: Nina Satragno <[email protected]> Cr-Commit-Position: refs/heads/master@{#658114}
void AuthenticatorClientPinEntrySheetModel::SetPinCode( base::string16 pin_code) { pin_code_ = std::move(pin_code); }
void AuthenticatorClientPinEntrySheetModel::SetPinCode( base::string16 pin_code) { pin_code_ = std::move(pin_code); }
C
Chrome
0
CVE-2018-1000040
https://www.cvedetails.com/cve/CVE-2018-1000040/
CWE-20
http://git.ghostscript.com/?p=mupdf.git;a=commitdiff;h=83d4dae44c71816c084a635550acc1a51529b881;hp=f597300439e62f5e921f0d7b1e880b5c1a1f1607
83d4dae44c71816c084a635550acc1a51529b881
null
int fz_colorspace_is_cal(fz_context *ctx, const fz_colorspace *cs) { return cs && (cs->flags & FZ_COLORSPACE_IS_CAL); }
int fz_colorspace_is_cal(fz_context *ctx, const fz_colorspace *cs) { return cs && (cs->flags & FZ_COLORSPACE_IS_CAL); }
C
ghostscript
0
CVE-2017-9501
https://www.cvedetails.com/cve/CVE-2017-9501/
CWE-617
https://github.com/ImageMagick/ImageMagick/commit/01843366d6a7b96e22ad7bb67f3df7d9fd4d5d74
01843366d6a7b96e22ad7bb67f3df7d9fd4d5d74
Fixed incorrect call to DestroyImage reported in #491.
MagickExport MagickBooleanType IsTaintImage(const Image *image) { char magick[MaxTextExtent], filename[MaxTextExtent]; register const Image *p; assert(image != (Image *) NULL); if (image->debug != MagickFalse) (void) LogMagickEvent(TraceEvent,GetMagickModule(),"..."); assert(image->signature == MagickSignature); (void) CopyMagickString(magick,image->magick,MaxTextExtent); (void) CopyMagickString(filename,image->filename,MaxTextExtent); for (p=image; p != (Image *) NULL; p=GetNextImageInList(p)) { if (p->taint != MagickFalse) return(MagickTrue); if (LocaleCompare(p->magick,magick) != 0) return(MagickTrue); if (LocaleCompare(p->filename,filename) != 0) return(MagickTrue); } return(MagickFalse); }
MagickExport MagickBooleanType IsTaintImage(const Image *image) { char magick[MaxTextExtent], filename[MaxTextExtent]; register const Image *p; assert(image != (Image *) NULL); if (image->debug != MagickFalse) (void) LogMagickEvent(TraceEvent,GetMagickModule(),"..."); assert(image->signature == MagickSignature); (void) CopyMagickString(magick,image->magick,MaxTextExtent); (void) CopyMagickString(filename,image->filename,MaxTextExtent); for (p=image; p != (Image *) NULL; p=GetNextImageInList(p)) { if (p->taint != MagickFalse) return(MagickTrue); if (LocaleCompare(p->magick,magick) != 0) return(MagickTrue); if (LocaleCompare(p->filename,filename) != 0) return(MagickTrue); } return(MagickFalse); }
C
ImageMagick
0
null
null
null
https://github.com/chromium/chromium/commit/8353baf8d1504dbdd4ad7584ff2466de657521cd
8353baf8d1504dbdd4ad7584ff2466de657521cd
Remove WebFrame::canHaveSecureChild To simplify the public API, ServiceWorkerNetworkProvider can do the parent walk itself. Follow-up to https://crrev.com/ad1850962644e19. BUG=607543 Review-Url: https://codereview.chromium.org/2082493002 Cr-Commit-Position: refs/heads/master@{#400896}
Document::~Document() { DCHECK(!layoutView()); DCHECK(!parentTreeScope()); DCHECK(!m_axObjectCache); InstanceCounters::decrementCounter(InstanceCounters::DocumentCounter); }
Document::~Document() { DCHECK(!layoutView()); DCHECK(!parentTreeScope()); DCHECK(!m_axObjectCache); InstanceCounters::decrementCounter(InstanceCounters::DocumentCounter); }
C
Chrome
0
CVE-2015-5707
https://www.cvedetails.com/cve/CVE-2015-5707/
CWE-189
https://github.com/torvalds/linux/commit/451a2886b6bf90e2fb378f7c46c655450fb96e81
451a2886b6bf90e2fb378f7c46c655450fb96e81
sg_start_req(): make sure that there's not too many elements in iovec unfortunately, allowing an arbitrary 16bit value means a possibility of overflow in the calculation of total number of pages in bio_map_user_iov() - we rely on there being no more than PAGE_SIZE members of sum in the first loop there. If that sum wraps around, we end up allocating too small array of pointers to pages and it's easy to overflow it in the second loop. X-Coverup: TINC (and there's no lumber cartel either) Cc: [email protected] # way, way back Signed-off-by: Al Viro <[email protected]>
sg_write(struct file *filp, const char __user *buf, size_t count, loff_t * ppos) { int mxsize, cmd_size, k; int input_size, blocking; unsigned char opcode; Sg_device *sdp; Sg_fd *sfp; Sg_request *srp; struct sg_header old_hdr; sg_io_hdr_t *hp; unsigned char cmnd[SG_MAX_CDB_SIZE]; if ((!(sfp = (Sg_fd *) filp->private_data)) || (!(sdp = sfp->parentdp))) return -ENXIO; SCSI_LOG_TIMEOUT(3, sg_printk(KERN_INFO, sdp, "sg_write: count=%d\n", (int) count)); if (atomic_read(&sdp->detaching)) return -ENODEV; if (!((filp->f_flags & O_NONBLOCK) || scsi_block_when_processing_errors(sdp->device))) return -ENXIO; if (!access_ok(VERIFY_READ, buf, count)) return -EFAULT; /* protects following copy_from_user()s + get_user()s */ if (count < SZ_SG_HEADER) return -EIO; if (__copy_from_user(&old_hdr, buf, SZ_SG_HEADER)) return -EFAULT; blocking = !(filp->f_flags & O_NONBLOCK); if (old_hdr.reply_len < 0) return sg_new_write(sfp, filp, buf, count, blocking, 0, 0, NULL); if (count < (SZ_SG_HEADER + 6)) return -EIO; /* The minimum scsi command length is 6 bytes. */ if (!(srp = sg_add_request(sfp))) { SCSI_LOG_TIMEOUT(1, sg_printk(KERN_INFO, sdp, "sg_write: queue full\n")); return -EDOM; } buf += SZ_SG_HEADER; __get_user(opcode, buf); if (sfp->next_cmd_len > 0) { cmd_size = sfp->next_cmd_len; sfp->next_cmd_len = 0; /* reset so only this write() effected */ } else { cmd_size = COMMAND_SIZE(opcode); /* based on SCSI command group */ if ((opcode >= 0xc0) && old_hdr.twelve_byte) cmd_size = 12; } SCSI_LOG_TIMEOUT(4, sg_printk(KERN_INFO, sdp, "sg_write: scsi opcode=0x%02x, cmd_size=%d\n", (int) opcode, cmd_size)); /* Determine buffer size. */ input_size = count - cmd_size; mxsize = (input_size > old_hdr.reply_len) ? input_size : old_hdr.reply_len; mxsize -= SZ_SG_HEADER; input_size -= SZ_SG_HEADER; if (input_size < 0) { sg_remove_request(sfp, srp); return -EIO; /* User did not pass enough bytes for this command. */ } hp = &srp->header; hp->interface_id = '\0'; /* indicator of old interface tunnelled */ hp->cmd_len = (unsigned char) cmd_size; hp->iovec_count = 0; hp->mx_sb_len = 0; if (input_size > 0) hp->dxfer_direction = (old_hdr.reply_len > SZ_SG_HEADER) ? SG_DXFER_TO_FROM_DEV : SG_DXFER_TO_DEV; else hp->dxfer_direction = (mxsize > 0) ? SG_DXFER_FROM_DEV : SG_DXFER_NONE; hp->dxfer_len = mxsize; if (hp->dxfer_direction == SG_DXFER_TO_DEV) hp->dxferp = (char __user *)buf + cmd_size; else hp->dxferp = NULL; hp->sbp = NULL; hp->timeout = old_hdr.reply_len; /* structure abuse ... */ hp->flags = input_size; /* structure abuse ... */ hp->pack_id = old_hdr.pack_id; hp->usr_ptr = NULL; if (__copy_from_user(cmnd, buf, cmd_size)) return -EFAULT; /* * SG_DXFER_TO_FROM_DEV is functionally equivalent to SG_DXFER_FROM_DEV, * but is is possible that the app intended SG_DXFER_TO_DEV, because there * is a non-zero input_size, so emit a warning. */ if (hp->dxfer_direction == SG_DXFER_TO_FROM_DEV) { static char cmd[TASK_COMM_LEN]; if (strcmp(current->comm, cmd)) { printk_ratelimited(KERN_WARNING "sg_write: data in/out %d/%d bytes " "for SCSI command 0x%x-- guessing " "data in;\n program %s not setting " "count and/or reply_len properly\n", old_hdr.reply_len - (int)SZ_SG_HEADER, input_size, (unsigned int) cmnd[0], current->comm); strcpy(cmd, current->comm); } } k = sg_common_write(sfp, srp, cmnd, sfp->timeout, blocking); return (k < 0) ? k : count; }
sg_write(struct file *filp, const char __user *buf, size_t count, loff_t * ppos) { int mxsize, cmd_size, k; int input_size, blocking; unsigned char opcode; Sg_device *sdp; Sg_fd *sfp; Sg_request *srp; struct sg_header old_hdr; sg_io_hdr_t *hp; unsigned char cmnd[SG_MAX_CDB_SIZE]; if ((!(sfp = (Sg_fd *) filp->private_data)) || (!(sdp = sfp->parentdp))) return -ENXIO; SCSI_LOG_TIMEOUT(3, sg_printk(KERN_INFO, sdp, "sg_write: count=%d\n", (int) count)); if (atomic_read(&sdp->detaching)) return -ENODEV; if (!((filp->f_flags & O_NONBLOCK) || scsi_block_when_processing_errors(sdp->device))) return -ENXIO; if (!access_ok(VERIFY_READ, buf, count)) return -EFAULT; /* protects following copy_from_user()s + get_user()s */ if (count < SZ_SG_HEADER) return -EIO; if (__copy_from_user(&old_hdr, buf, SZ_SG_HEADER)) return -EFAULT; blocking = !(filp->f_flags & O_NONBLOCK); if (old_hdr.reply_len < 0) return sg_new_write(sfp, filp, buf, count, blocking, 0, 0, NULL); if (count < (SZ_SG_HEADER + 6)) return -EIO; /* The minimum scsi command length is 6 bytes. */ if (!(srp = sg_add_request(sfp))) { SCSI_LOG_TIMEOUT(1, sg_printk(KERN_INFO, sdp, "sg_write: queue full\n")); return -EDOM; } buf += SZ_SG_HEADER; __get_user(opcode, buf); if (sfp->next_cmd_len > 0) { cmd_size = sfp->next_cmd_len; sfp->next_cmd_len = 0; /* reset so only this write() effected */ } else { cmd_size = COMMAND_SIZE(opcode); /* based on SCSI command group */ if ((opcode >= 0xc0) && old_hdr.twelve_byte) cmd_size = 12; } SCSI_LOG_TIMEOUT(4, sg_printk(KERN_INFO, sdp, "sg_write: scsi opcode=0x%02x, cmd_size=%d\n", (int) opcode, cmd_size)); /* Determine buffer size. */ input_size = count - cmd_size; mxsize = (input_size > old_hdr.reply_len) ? input_size : old_hdr.reply_len; mxsize -= SZ_SG_HEADER; input_size -= SZ_SG_HEADER; if (input_size < 0) { sg_remove_request(sfp, srp); return -EIO; /* User did not pass enough bytes for this command. */ } hp = &srp->header; hp->interface_id = '\0'; /* indicator of old interface tunnelled */ hp->cmd_len = (unsigned char) cmd_size; hp->iovec_count = 0; hp->mx_sb_len = 0; if (input_size > 0) hp->dxfer_direction = (old_hdr.reply_len > SZ_SG_HEADER) ? SG_DXFER_TO_FROM_DEV : SG_DXFER_TO_DEV; else hp->dxfer_direction = (mxsize > 0) ? SG_DXFER_FROM_DEV : SG_DXFER_NONE; hp->dxfer_len = mxsize; if (hp->dxfer_direction == SG_DXFER_TO_DEV) hp->dxferp = (char __user *)buf + cmd_size; else hp->dxferp = NULL; hp->sbp = NULL; hp->timeout = old_hdr.reply_len; /* structure abuse ... */ hp->flags = input_size; /* structure abuse ... */ hp->pack_id = old_hdr.pack_id; hp->usr_ptr = NULL; if (__copy_from_user(cmnd, buf, cmd_size)) return -EFAULT; /* * SG_DXFER_TO_FROM_DEV is functionally equivalent to SG_DXFER_FROM_DEV, * but is is possible that the app intended SG_DXFER_TO_DEV, because there * is a non-zero input_size, so emit a warning. */ if (hp->dxfer_direction == SG_DXFER_TO_FROM_DEV) { static char cmd[TASK_COMM_LEN]; if (strcmp(current->comm, cmd)) { printk_ratelimited(KERN_WARNING "sg_write: data in/out %d/%d bytes " "for SCSI command 0x%x-- guessing " "data in;\n program %s not setting " "count and/or reply_len properly\n", old_hdr.reply_len - (int)SZ_SG_HEADER, input_size, (unsigned int) cmnd[0], current->comm); strcpy(cmd, current->comm); } } k = sg_common_write(sfp, srp, cmnd, sfp->timeout, blocking); return (k < 0) ? k : count; }
C
linux
0
CVE-2016-6836
https://www.cvedetails.com/cve/CVE-2016-6836/
CWE-200
https://git.qemu.org/?p=qemu.git;a=commit;h=fdda170e50b8af062cf5741e12c4fb5e57a2eacf
fdda170e50b8af062cf5741e12c4fb5e57a2eacf
null
vmxnet3_dump_conf_descr(const char *name, struct Vmxnet3_VariableLenConfDesc *pm_descr) { VMW_CFPRN("%s descriptor dump: Version %u, Length %u", name, pm_descr->confVer, pm_descr->confLen); };
vmxnet3_dump_conf_descr(const char *name, struct Vmxnet3_VariableLenConfDesc *pm_descr) { VMW_CFPRN("%s descriptor dump: Version %u, Length %u", name, pm_descr->confVer, pm_descr->confLen); };
C
qemu
0
CVE-2013-4514
https://www.cvedetails.com/cve/CVE-2013-4514/
CWE-119
https://github.com/torvalds/linux/commit/b5e2f339865fb443107e5b10603e53bbc92dc054
b5e2f339865fb443107e5b10603e53bbc92dc054
staging: wlags49_h2: buffer overflow setting station name We need to check the length parameter before doing the memcpy(). I've actually changed it to strlcpy() as well so that it's NUL terminated. You need CAP_NET_ADMIN to trigger these so it's not the end of the world. Reported-by: Nico Golde <[email protected]> Reported-by: Fabian Yamaguchi <[email protected]> Signed-off-by: Dan Carpenter <[email protected]> Cc: [email protected] Signed-off-by: Linus Torvalds <[email protected]>
int wvlan_rts(struct rtsreq *rrq, __u32 io_base) { int ioctl_ret = 0; /*------------------------------------------------------------------------*/ DBG_FUNC("wvlan_rts"); DBG_ENTER(DbgInfo); DBG_PRINT("io_base: 0x%08x\n", io_base); switch (rrq->typ) { case WL_IOCTL_RTS_READ: DBG_TRACE(DbgInfo, "IOCTL: WVLAN2_IOCTL_RTS -- WL_IOCTL_RTS_READ\n"); rrq->data[0] = IN_PORT_WORD(io_base + rrq->reg); DBG_TRACE(DbgInfo, " reg 0x%04x ==> 0x%04x\n", rrq->reg, CNV_LITTLE_TO_SHORT(rrq->data[0])); break; case WL_IOCTL_RTS_WRITE: DBG_TRACE(DbgInfo, "IOCTL: WVLAN2_IOCTL_RTS -- WL_IOCTL_RTS_WRITE\n"); OUT_PORT_WORD(io_base + rrq->reg, rrq->data[0]); DBG_TRACE(DbgInfo, " reg 0x%04x <== 0x%04x\n", rrq->reg, CNV_LITTLE_TO_SHORT(rrq->data[0])); break; case WL_IOCTL_RTS_BATCH_READ: DBG_TRACE(DbgInfo, "IOCTL: WVLAN2_IOCTL_RTS -- WL_IOCTL_RTS_BATCH_READ\n"); IN_PORT_STRING_16(io_base + rrq->reg, rrq->data, rrq->len); DBG_TRACE(DbgInfo, " reg 0x%04x ==> %d bytes\n", rrq->reg, rrq->len * sizeof(__u16)); break; case WL_IOCTL_RTS_BATCH_WRITE: DBG_TRACE(DbgInfo, "IOCTL: WVLAN2_IOCTL_RTS -- WL_IOCTL_RTS_BATCH_WRITE\n"); OUT_PORT_STRING_16(io_base + rrq->reg, rrq->data, rrq->len); DBG_TRACE(DbgInfo, " reg 0x%04x <== %d bytes\n", rrq->reg, rrq->len * sizeof(__u16)); break; default: DBG_TRACE(DbgInfo, "IOCTL: WVLAN2_IOCTL_RTS -- UNSUPPORTED RTS CODE: 0x%X", rrq->typ); ioctl_ret = -EOPNOTSUPP; break; } DBG_LEAVE(DbgInfo); return ioctl_ret; } /* wvlan_rts */
int wvlan_rts(struct rtsreq *rrq, __u32 io_base) { int ioctl_ret = 0; /*------------------------------------------------------------------------*/ DBG_FUNC("wvlan_rts"); DBG_ENTER(DbgInfo); DBG_PRINT("io_base: 0x%08x\n", io_base); switch (rrq->typ) { case WL_IOCTL_RTS_READ: DBG_TRACE(DbgInfo, "IOCTL: WVLAN2_IOCTL_RTS -- WL_IOCTL_RTS_READ\n"); rrq->data[0] = IN_PORT_WORD(io_base + rrq->reg); DBG_TRACE(DbgInfo, " reg 0x%04x ==> 0x%04x\n", rrq->reg, CNV_LITTLE_TO_SHORT(rrq->data[0])); break; case WL_IOCTL_RTS_WRITE: DBG_TRACE(DbgInfo, "IOCTL: WVLAN2_IOCTL_RTS -- WL_IOCTL_RTS_WRITE\n"); OUT_PORT_WORD(io_base + rrq->reg, rrq->data[0]); DBG_TRACE(DbgInfo, " reg 0x%04x <== 0x%04x\n", rrq->reg, CNV_LITTLE_TO_SHORT(rrq->data[0])); break; case WL_IOCTL_RTS_BATCH_READ: DBG_TRACE(DbgInfo, "IOCTL: WVLAN2_IOCTL_RTS -- WL_IOCTL_RTS_BATCH_READ\n"); IN_PORT_STRING_16(io_base + rrq->reg, rrq->data, rrq->len); DBG_TRACE(DbgInfo, " reg 0x%04x ==> %d bytes\n", rrq->reg, rrq->len * sizeof(__u16)); break; case WL_IOCTL_RTS_BATCH_WRITE: DBG_TRACE(DbgInfo, "IOCTL: WVLAN2_IOCTL_RTS -- WL_IOCTL_RTS_BATCH_WRITE\n"); OUT_PORT_STRING_16(io_base + rrq->reg, rrq->data, rrq->len); DBG_TRACE(DbgInfo, " reg 0x%04x <== %d bytes\n", rrq->reg, rrq->len * sizeof(__u16)); break; default: DBG_TRACE(DbgInfo, "IOCTL: WVLAN2_IOCTL_RTS -- UNSUPPORTED RTS CODE: 0x%X", rrq->typ); ioctl_ret = -EOPNOTSUPP; break; } DBG_LEAVE(DbgInfo); return ioctl_ret; } /* wvlan_rts */
C
linux
0
CVE-2017-15129
https://www.cvedetails.com/cve/CVE-2017-15129/
CWE-416
https://github.com/torvalds/linux/commit/21b5944350052d2583e82dd59b19a9ba94a007f0
21b5944350052d2583e82dd59b19a9ba94a007f0
net: Fix double free and memory corruption in get_net_ns_by_id() (I can trivially verify that that idr_remove in cleanup_net happens after the network namespace count has dropped to zero --EWB) Function get_net_ns_by_id() does not check for net::count after it has found a peer in netns_ids idr. It may dereference a peer, after its count has already been finaly decremented. This leads to double free and memory corruption: put_net(peer) rtnl_lock() atomic_dec_and_test(&peer->count) [count=0] ... __put_net(peer) get_net_ns_by_id(net, id) spin_lock(&cleanup_list_lock) list_add(&net->cleanup_list, &cleanup_list) spin_unlock(&cleanup_list_lock) queue_work() peer = idr_find(&net->netns_ids, id) | get_net(peer) [count=1] | ... | (use after final put) v ... cleanup_net() ... spin_lock(&cleanup_list_lock) ... list_replace_init(&cleanup_list, ..) ... spin_unlock(&cleanup_list_lock) ... ... ... ... put_net(peer) ... atomic_dec_and_test(&peer->count) [count=0] ... spin_lock(&cleanup_list_lock) ... list_add(&net->cleanup_list, &cleanup_list) ... spin_unlock(&cleanup_list_lock) ... queue_work() ... rtnl_unlock() rtnl_lock() ... for_each_net(tmp) { ... id = __peernet2id(tmp, peer) ... spin_lock_irq(&tmp->nsid_lock) ... idr_remove(&tmp->netns_ids, id) ... ... ... net_drop_ns() ... net_free(peer) ... } ... | v cleanup_net() ... (Second free of peer) Also, put_net() on the right cpu may reorder with left's cpu list_replace_init(&cleanup_list, ..), and then cleanup_list will be corrupted. Since cleanup_net() is executed in worker thread, while put_net(peer) can happen everywhere, there should be enough time for concurrent get_net_ns_by_id() to pick the peer up, and the race does not seem to be unlikely. The patch fixes the problem in standard way. (Also, there is possible problem in peernet2id_alloc(), which requires check for net::count under nsid_lock and maybe_get_net(peer), but in current stable kernel it's used under rtnl_lock() and it has to be safe. Openswitch begun to use peernet2id_alloc(), and possibly it should be fixed too. While this is not in stable kernel yet, so I'll send a separate message to netdev@ later). Cc: Nicolas Dichtel <[email protected]> Signed-off-by: Kirill Tkhai <[email protected]> Fixes: 0c7aecd4bde4 "netns: add rtnl cmd to add and get peer netns ids" Reviewed-by: Andrey Ryabinin <[email protected]> Reviewed-by: "Eric W. Biederman" <[email protected]> Signed-off-by: Eric W. Biederman <[email protected]> Reviewed-by: Eric Dumazet <[email protected]> Acked-by: Nicolas Dichtel <[email protected]> Signed-off-by: David S. Miller <[email protected]>
void unregister_pernet_subsys(struct pernet_operations *ops) { mutex_lock(&net_mutex); unregister_pernet_operations(ops); mutex_unlock(&net_mutex); }
void unregister_pernet_subsys(struct pernet_operations *ops) { mutex_lock(&net_mutex); unregister_pernet_operations(ops); mutex_unlock(&net_mutex); }
C
linux
0
CVE-2017-16532
https://www.cvedetails.com/cve/CVE-2017-16532/
CWE-476
https://github.com/torvalds/linux/commit/7c80f9e4a588f1925b07134bb2e3689335f6c6d8
7c80f9e4a588f1925b07134bb2e3689335f6c6d8
usb: usbtest: fix NULL pointer dereference If the usbtest driver encounters a device with an IN bulk endpoint but no OUT bulk endpoint, it will try to dereference a NULL pointer (out->desc.bEndpointAddress). The problem can be solved by adding a missing test. Signed-off-by: Alan Stern <[email protected]> Reported-by: Andrey Konovalov <[email protected]> Tested-by: Andrey Konovalov <[email protected]> Signed-off-by: Felipe Balbi <[email protected]>
static int simple_check_buf(struct usbtest_dev *tdev, struct urb *urb) { unsigned i; u8 expected; u8 *buf = urb->transfer_buffer; unsigned len = urb->actual_length; unsigned maxpacket = get_maxpacket(urb->dev, urb->pipe); int ret = check_guard_bytes(tdev, urb); if (ret) return ret; for (i = 0; i < len; i++, buf++) { switch (pattern) { /* all-zeroes has no synchronization issues */ case 0: expected = 0; break; /* mod63 stays in sync with short-terminated transfers, * or otherwise when host and gadget agree on how large * each usb transfer request should be. resync is done * with set_interface or set_config. */ case 1: /* mod63 */ expected = (i % maxpacket) % 63; break; /* always fail unsupported patterns */ default: expected = !*buf; break; } if (*buf == expected) continue; ERROR(tdev, "buf[%d] = %d (not %d)\n", i, *buf, expected); return -EINVAL; } return 0; }
static int simple_check_buf(struct usbtest_dev *tdev, struct urb *urb) { unsigned i; u8 expected; u8 *buf = urb->transfer_buffer; unsigned len = urb->actual_length; unsigned maxpacket = get_maxpacket(urb->dev, urb->pipe); int ret = check_guard_bytes(tdev, urb); if (ret) return ret; for (i = 0; i < len; i++, buf++) { switch (pattern) { /* all-zeroes has no synchronization issues */ case 0: expected = 0; break; /* mod63 stays in sync with short-terminated transfers, * or otherwise when host and gadget agree on how large * each usb transfer request should be. resync is done * with set_interface or set_config. */ case 1: /* mod63 */ expected = (i % maxpacket) % 63; break; /* always fail unsupported patterns */ default: expected = !*buf; break; } if (*buf == expected) continue; ERROR(tdev, "buf[%d] = %d (not %d)\n", i, *buf, expected); return -EINVAL; } return 0; }
C
linux
0
CVE-2011-1160
https://www.cvedetails.com/cve/CVE-2011-1160/
CWE-200
https://github.com/torvalds/linux/commit/1309d7afbed112f0e8e90be9af975550caa0076b
1309d7afbed112f0e8e90be9af975550caa0076b
char/tpm: Fix unitialized usage of data buffer This patch fixes information leakage to the userspace by initializing the data buffer to zero. Reported-by: Peter Huewe <[email protected]> Signed-off-by: Peter Huewe <[email protected]> Signed-off-by: Marcel Selhorst <[email protected]> [ Also removed the silly "* sizeof(u8)". If that isn't 1, we have way deeper problems than a simple multiplication can fix. - Linus ] Signed-off-by: Linus Torvalds <[email protected]>
static void timeout_work(struct work_struct *work) { struct tpm_chip *chip = container_of(work, struct tpm_chip, work); mutex_lock(&chip->buffer_mutex); atomic_set(&chip->data_pending, 0); memset(chip->data_buffer, 0, TPM_BUFSIZE); mutex_unlock(&chip->buffer_mutex); }
static void timeout_work(struct work_struct *work) { struct tpm_chip *chip = container_of(work, struct tpm_chip, work); mutex_lock(&chip->buffer_mutex); atomic_set(&chip->data_pending, 0); memset(chip->data_buffer, 0, TPM_BUFSIZE); mutex_unlock(&chip->buffer_mutex); }
C
linux
0
CVE-2017-18079
https://www.cvedetails.com/cve/CVE-2017-18079/
CWE-476
https://github.com/torvalds/linux/commit/340d394a789518018f834ff70f7534fc463d3226
340d394a789518018f834ff70f7534fc463d3226
Input: i8042 - fix crash at boot time The driver checks port->exists twice in i8042_interrupt(), first when trying to assign temporary "serio" variable, and second time when deciding whether it should call serio_interrupt(). The value of port->exists may change between the 2 checks, and we may end up calling serio_interrupt() with a NULL pointer: BUG: unable to handle kernel NULL pointer dereference at 0000000000000050 IP: [<ffffffff8150feaf>] _spin_lock_irqsave+0x1f/0x40 PGD 0 Oops: 0002 [#1] SMP last sysfs file: CPU 0 Modules linked in: Pid: 1, comm: swapper Not tainted 2.6.32-358.el6.x86_64 #1 QEMU Standard PC (i440FX + PIIX, 1996) RIP: 0010:[<ffffffff8150feaf>] [<ffffffff8150feaf>] _spin_lock_irqsave+0x1f/0x40 RSP: 0018:ffff880028203cc0 EFLAGS: 00010082 RAX: 0000000000010000 RBX: 0000000000000000 RCX: 0000000000000000 RDX: 0000000000000282 RSI: 0000000000000098 RDI: 0000000000000050 RBP: ffff880028203cc0 R08: ffff88013e79c000 R09: ffff880028203ee0 R10: 0000000000000298 R11: 0000000000000282 R12: 0000000000000050 R13: 0000000000000000 R14: 0000000000000000 R15: 0000000000000098 FS: 0000000000000000(0000) GS:ffff880028200000(0000) knlGS:0000000000000000 CS: 0010 DS: 0018 ES: 0018 CR0: 000000008005003b CR2: 0000000000000050 CR3: 0000000001a85000 CR4: 00000000001407f0 DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000400 Process swapper (pid: 1, threadinfo ffff88013e79c000, task ffff88013e79b500) Stack: ffff880028203d00 ffffffff813de186 ffffffffffffff02 0000000000000000 <d> 0000000000000000 0000000000000000 0000000000000000 0000000000000098 <d> ffff880028203d70 ffffffff813e0162 ffff880028203d20 ffffffff8103b8ac Call Trace: <IRQ> [<ffffffff813de186>] serio_interrupt+0x36/0xa0 [<ffffffff813e0162>] i8042_interrupt+0x132/0x3a0 [<ffffffff8103b8ac>] ? kvm_clock_read+0x1c/0x20 [<ffffffff8103b8b9>] ? kvm_clock_get_cycles+0x9/0x10 [<ffffffff810e1640>] handle_IRQ_event+0x60/0x170 [<ffffffff8103b154>] ? kvm_guest_apic_eoi_write+0x44/0x50 [<ffffffff810e3d8e>] handle_edge_irq+0xde/0x180 [<ffffffff8100de89>] handle_irq+0x49/0xa0 [<ffffffff81516c8c>] do_IRQ+0x6c/0xf0 [<ffffffff8100b9d3>] ret_from_intr+0x0/0x11 [<ffffffff81076f63>] ? __do_softirq+0x73/0x1e0 [<ffffffff8109b75b>] ? hrtimer_interrupt+0x14b/0x260 [<ffffffff8100c1cc>] ? call_softirq+0x1c/0x30 [<ffffffff8100de05>] ? do_softirq+0x65/0xa0 [<ffffffff81076d95>] ? irq_exit+0x85/0x90 [<ffffffff81516d80>] ? smp_apic_timer_interrupt+0x70/0x9b [<ffffffff8100bb93>] ? apic_timer_interrupt+0x13/0x20 To avoid the issue let's change the second check to test whether serio is NULL or not. Also, let's take i8042_lock in i8042_start() and i8042_stop() instead of trying to be overly smart and using memory barriers. Signed-off-by: Chen Hong <[email protected]> [dtor: take lock in i8042_start()/i8042_stop()] Cc: [email protected] Signed-off-by: Dmitry Torokhov <[email protected]>
static void __exit i8042_exit(void) { platform_device_unregister(i8042_platform_device); platform_driver_unregister(&i8042_driver); i8042_platform_exit(); bus_unregister_notifier(&serio_bus, &i8042_kbd_bind_notifier_block); panic_blink = NULL; }
static void __exit i8042_exit(void) { platform_device_unregister(i8042_platform_device); platform_driver_unregister(&i8042_driver); i8042_platform_exit(); bus_unregister_notifier(&serio_bus, &i8042_kbd_bind_notifier_block); panic_blink = NULL; }
C
linux
0
CVE-2019-13311
https://www.cvedetails.com/cve/CVE-2019-13311/
CWE-399
https://github.com/ImageMagick/ImageMagick/commit/4a334bbf5584de37c6f5a47c380a531c8c4b140a
4a334bbf5584de37c6f5a47c380a531c8c4b140a
https://github.com/ImageMagick/ImageMagick/issues/1623
WandExport MagickBooleanType MogrifyImageCommand(ImageInfo *image_info, int argc,char **argv,char **wand_unused(metadata),ExceptionInfo *exception) { #define DestroyMogrify() \ { \ if (format != (char *) NULL) \ format=DestroyString(format); \ if (path != (char *) NULL) \ path=DestroyString(path); \ DestroyImageStack(); \ for (i=0; i < (ssize_t) argc; i++) \ argv[i]=DestroyString(argv[i]); \ argv=(char **) RelinquishMagickMemory(argv); \ } #define ThrowMogrifyException(asperity,tag,option) \ { \ (void) ThrowMagickException(exception,GetMagickModule(),asperity,tag,"`%s'", \ option); \ DestroyMogrify(); \ return(MagickFalse); \ } #define ThrowMogrifyInvalidArgumentException(option,argument) \ { \ (void) ThrowMagickException(exception,GetMagickModule(),OptionError, \ "InvalidArgument","'%s': %s",argument,option); \ DestroyMogrify(); \ return(MagickFalse); \ } char *format, *option, *path; Image *image; ImageStack image_stack[MaxImageStackDepth+1]; MagickBooleanType global_colormap; MagickBooleanType fire, pend, respect_parenthesis; MagickStatusType status; register ssize_t i; ssize_t j, k; wand_unreferenced(metadata); /* Set defaults. */ assert(image_info != (ImageInfo *) NULL); assert(image_info->signature == MagickCoreSignature); if (image_info->debug != MagickFalse) (void) LogMagickEvent(TraceEvent,GetMagickModule(),"..."); assert(exception != (ExceptionInfo *) NULL); if (argc == 2) { option=argv[1]; if ((LocaleCompare("version",option+1) == 0) || (LocaleCompare("-version",option+1) == 0)) { ListMagickVersion(stdout); return(MagickTrue); } } if (argc < 2) return(MogrifyUsage()); format=(char *) NULL; path=(char *) NULL; global_colormap=MagickFalse; k=0; j=1; NewImageStack(); option=(char *) NULL; pend=MagickFalse; respect_parenthesis=MagickFalse; status=MagickTrue; /* Parse command line. */ ReadCommandlLine(argc,&argv); status=ExpandFilenames(&argc,&argv); if (status == MagickFalse) ThrowMogrifyException(ResourceLimitError,"MemoryAllocationFailed", GetExceptionMessage(errno)); for (i=1; i < (ssize_t) argc; i++) { option=argv[i]; if (LocaleCompare(option,"(") == 0) { FireImageStack(MagickFalse,MagickTrue,pend); if (k == MaxImageStackDepth) ThrowMogrifyException(OptionError,"ParenthesisNestedTooDeeply", option); PushImageStack(); continue; } if (LocaleCompare(option,")") == 0) { FireImageStack(MagickFalse,MagickTrue,MagickTrue); if (k == 0) ThrowMogrifyException(OptionError,"UnableToParseExpression",option); PopImageStack(); continue; } if (IsCommandOption(option) == MagickFalse) { char backup_filename[MagickPathExtent], *filename; Image *images; struct stat properties; /* Option is a file name: begin by reading image from specified file. */ FireImageStack(MagickFalse,MagickFalse,pend); filename=argv[i]; if ((LocaleCompare(filename,"--") == 0) && (i < (ssize_t) (argc-1))) filename=argv[++i]; images=ReadImages(image_info,filename,exception); status&=(images != (Image *) NULL) && (exception->severity < ErrorException); if (images == (Image *) NULL) continue; properties=(*GetBlobProperties(images)); if (format != (char *) NULL) (void) CopyMagickString(images->filename,images->magick_filename, MagickPathExtent); if (path != (char *) NULL) { GetPathComponent(option,TailPath,filename); (void) FormatLocaleString(images->filename,MagickPathExtent, "%s%c%s",path,*DirectorySeparator,filename); } if (format != (char *) NULL) AppendImageFormat(format,images->filename); AppendImageStack(images); FinalizeImageSettings(image_info,image,MagickFalse); if (global_colormap != MagickFalse) { QuantizeInfo *quantize_info; quantize_info=AcquireQuantizeInfo(image_info); (void) RemapImages(quantize_info,images,(Image *) NULL,exception); quantize_info=DestroyQuantizeInfo(quantize_info); } *backup_filename='\0'; if ((LocaleCompare(image->filename,"-") != 0) && (IsPathWritable(image->filename) != MagickFalse)) { /* Rename image file as backup. */ (void) CopyMagickString(backup_filename,image->filename, MagickPathExtent); for (j=0; j < 6; j++) { (void) ConcatenateMagickString(backup_filename,"~", MagickPathExtent); if (IsPathAccessible(backup_filename) == MagickFalse) break; } if ((IsPathAccessible(backup_filename) != MagickFalse) || (rename_utf8(image->filename,backup_filename) != 0)) *backup_filename='\0'; } /* Write transmogrified image to disk. */ image_info->synchronize=MagickTrue; status&=WriteImages(image_info,image,image->filename,exception); if (status != MagickFalse) { #if defined(MAGICKCORE_HAVE_UTIME) { MagickBooleanType preserve_timestamp; preserve_timestamp=IsStringTrue(GetImageOption(image_info, "preserve-timestamp")); if (preserve_timestamp != MagickFalse) { struct utimbuf timestamp; timestamp.actime=properties.st_atime; timestamp.modtime=properties.st_mtime; (void) utime(image->filename,&timestamp); } } #endif if (*backup_filename != '\0') (void) remove_utf8(backup_filename); } RemoveAllImageStack(); continue; } pend=image != (Image *) NULL ? MagickTrue : MagickFalse; switch (*(option+1)) { case 'a': { if (LocaleCompare("adaptive-blur",option+1) == 0) { i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("adaptive-resize",option+1) == 0) { i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("adaptive-sharpen",option+1) == 0) { i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("affine",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); break; } if (LocaleCompare("alpha",option+1) == 0) { ssize_t type; if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); type=ParseCommandOption(MagickAlphaChannelOptions,MagickFalse, argv[i]); if (type < 0) ThrowMogrifyException(OptionError, "UnrecognizedAlphaChannelOption",argv[i]); break; } if (LocaleCompare("annotate",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); i++; break; } if (LocaleCompare("antialias",option+1) == 0) break; if (LocaleCompare("append",option+1) == 0) break; if (LocaleCompare("attenuate",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("authenticate",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); break; } if (LocaleCompare("auto-gamma",option+1) == 0) break; if (LocaleCompare("auto-level",option+1) == 0) break; if (LocaleCompare("auto-orient",option+1) == 0) break; if (LocaleCompare("auto-threshold",option+1) == 0) { ssize_t method; if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); method=ParseCommandOption(MagickAutoThresholdOptions,MagickFalse, argv[i]); if (method < 0) ThrowMogrifyException(OptionError,"UnrecognizedThresholdMethod", argv[i]); break; } if (LocaleCompare("average",option+1) == 0) break; ThrowMogrifyException(OptionError,"UnrecognizedOption",option) } case 'b': { if (LocaleCompare("background",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); break; } if (LocaleCompare("bias",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("black-point-compensation",option+1) == 0) break; if (LocaleCompare("black-threshold",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("blue-primary",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("blue-shift",option+1) == 0) { i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("blur",option+1) == 0) { i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("border",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("bordercolor",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); break; } if (LocaleCompare("box",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); break; } if (LocaleCompare("brightness-contrast",option+1) == 0) { i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } ThrowMogrifyException(OptionError,"UnrecognizedOption",option) } case 'c': { if (LocaleCompare("cache",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("canny",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("caption",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); break; } if (LocaleCompare("channel",option+1) == 0) { ssize_t channel; if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); channel=ParseChannelOption(argv[i]); if (channel < 0) ThrowMogrifyException(OptionError,"UnrecognizedChannelType", argv[i]); break; } if (LocaleCompare("channel-fx",option+1) == 0) { ssize_t channel; if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); channel=ParsePixelChannelOption(argv[i]); if (channel < 0) ThrowMogrifyException(OptionError,"UnrecognizedChannelType", argv[i]); break; } if (LocaleCompare("cdl",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); break; } if (LocaleCompare("charcoal",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("chop",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("clahe",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("clamp",option+1) == 0) break; if (LocaleCompare("clip",option+1) == 0) break; if (LocaleCompare("clip-mask",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); break; } if (LocaleCompare("clut",option+1) == 0) break; if (LocaleCompare("coalesce",option+1) == 0) break; if (LocaleCompare("colorize",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("color-matrix",option+1) == 0) { KernelInfo *kernel_info; if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); kernel_info=AcquireKernelInfo(argv[i],exception); if (kernel_info == (KernelInfo *) NULL) ThrowMogrifyInvalidArgumentException(option,argv[i]); kernel_info=DestroyKernelInfo(kernel_info); break; } if (LocaleCompare("colors",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("colorspace",option+1) == 0) { ssize_t colorspace; if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); colorspace=ParseCommandOption(MagickColorspaceOptions,MagickFalse, argv[i]); if (colorspace < 0) ThrowMogrifyException(OptionError,"UnrecognizedColorspace", argv[i]); break; } if (LocaleCompare("combine",option+1) == 0) { ssize_t colorspace; if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); colorspace=ParseCommandOption(MagickColorspaceOptions,MagickFalse, argv[i]); if (colorspace < 0) ThrowMogrifyException(OptionError,"UnrecognizedColorspace", argv[i]); break; } if (LocaleCompare("compare",option+1) == 0) break; if (LocaleCompare("comment",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); break; } if (LocaleCompare("composite",option+1) == 0) break; if (LocaleCompare("compress",option+1) == 0) { ssize_t compress; if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); compress=ParseCommandOption(MagickCompressOptions,MagickFalse, argv[i]); if (compress < 0) ThrowMogrifyException(OptionError,"UnrecognizedImageCompression", argv[i]); break; } if (LocaleCompare("concurrent",option+1) == 0) break; if (LocaleCompare("connected-components",option+1) == 0) { i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("contrast",option+1) == 0) break; if (LocaleCompare("contrast-stretch",option+1) == 0) { i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("convolve",option+1) == 0) { KernelInfo *kernel_info; if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); kernel_info=AcquireKernelInfo(argv[i],exception); if (kernel_info == (KernelInfo *) NULL) ThrowMogrifyInvalidArgumentException(option,argv[i]); kernel_info=DestroyKernelInfo(kernel_info); break; } if (LocaleCompare("copy",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("crop",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("cycle",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } ThrowMogrifyException(OptionError,"UnrecognizedOption",option) } case 'd': { if (LocaleCompare("decipher",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); break; } if (LocaleCompare("deconstruct",option+1) == 0) break; if (LocaleCompare("debug",option+1) == 0) { ssize_t event; if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); event=ParseCommandOption(MagickLogEventOptions,MagickFalse,argv[i]); if (event < 0) ThrowMogrifyException(OptionError,"UnrecognizedEventType", argv[i]); (void) SetLogEventMask(argv[i]); break; } if (LocaleCompare("define",option+1) == 0) { i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (*option == '+') { const char *define; define=GetImageOption(image_info,argv[i]); if (define == (const char *) NULL) ThrowMogrifyException(OptionError,"NoSuchOption",argv[i]); break; } break; } if (LocaleCompare("delay",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("delete",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("density",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("depth",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("deskew",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("despeckle",option+1) == 0) break; if (LocaleCompare("dft",option+1) == 0) break; if (LocaleCompare("direction",option+1) == 0) { ssize_t direction; if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); direction=ParseCommandOption(MagickDirectionOptions,MagickFalse, argv[i]); if (direction < 0) ThrowMogrifyException(OptionError,"UnrecognizedDirectionType", argv[i]); break; } if (LocaleCompare("display",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); break; } if (LocaleCompare("dispose",option+1) == 0) { ssize_t dispose; if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); dispose=ParseCommandOption(MagickDisposeOptions,MagickFalse, argv[i]); if (dispose < 0) ThrowMogrifyException(OptionError,"UnrecognizedDisposeMethod", argv[i]); break; } if (LocaleCompare("distort",option+1) == 0) { ssize_t op; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); op=ParseCommandOption(MagickDistortOptions,MagickFalse,argv[i]); if (op < 0) ThrowMogrifyException(OptionError,"UnrecognizedDistortMethod", argv[i]); i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); break; } if (LocaleCompare("dither",option+1) == 0) { ssize_t method; if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); method=ParseCommandOption(MagickDitherOptions,MagickFalse,argv[i]); if (method < 0) ThrowMogrifyException(OptionError,"UnrecognizedDitherMethod", argv[i]); break; } if (LocaleCompare("draw",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); break; } if (LocaleCompare("duplicate",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("duration",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } ThrowMogrifyException(OptionError,"UnrecognizedOption",option) } case 'e': { if (LocaleCompare("edge",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("emboss",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("encipher",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); break; } if (LocaleCompare("encoding",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); break; } if (LocaleCompare("endian",option+1) == 0) { ssize_t endian; if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); endian=ParseCommandOption(MagickEndianOptions,MagickFalse,argv[i]); if (endian < 0) ThrowMogrifyException(OptionError,"UnrecognizedEndianType", argv[i]); break; } if (LocaleCompare("enhance",option+1) == 0) break; if (LocaleCompare("equalize",option+1) == 0) break; if (LocaleCompare("evaluate",option+1) == 0) { ssize_t op; if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); op=ParseCommandOption(MagickEvaluateOptions,MagickFalse,argv[i]); if (op < 0) ThrowMogrifyException(OptionError,"UnrecognizedEvaluateOperator", argv[i]); i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("evaluate-sequence",option+1) == 0) { ssize_t op; if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); op=ParseCommandOption(MagickEvaluateOptions,MagickFalse,argv[i]); if (op < 0) ThrowMogrifyException(OptionError,"UnrecognizedEvaluateOperator", argv[i]); break; } if (LocaleCompare("extent",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("extract",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } ThrowMogrifyException(OptionError,"UnrecognizedOption",option) } case 'f': { if (LocaleCompare("family",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); break; } if (LocaleCompare("features",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("fill",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); break; } if (LocaleCompare("filter",option+1) == 0) { ssize_t filter; if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); filter=ParseCommandOption(MagickFilterOptions,MagickFalse,argv[i]); if (filter < 0) ThrowMogrifyException(OptionError,"UnrecognizedImageFilter", argv[i]); break; } if (LocaleCompare("flatten",option+1) == 0) break; if (LocaleCompare("flip",option+1) == 0) break; if (LocaleCompare("flop",option+1) == 0) break; if (LocaleCompare("floodfill",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); break; } if (LocaleCompare("font",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); break; } if (LocaleCompare("format",option+1) == 0) { (void) CopyMagickString(argv[i]+1,"sans",MagickPathExtent); (void) CloneString(&format,(char *) NULL); if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); (void) CloneString(&format,argv[i]); (void) CopyMagickString(image_info->filename,format, MagickPathExtent); (void) ConcatenateMagickString(image_info->filename,":", MagickPathExtent); (void) SetImageInfo(image_info,0,exception); if (*image_info->magick == '\0') ThrowMogrifyException(OptionError,"UnrecognizedImageFormat", format); break; } if (LocaleCompare("frame",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("function",option+1) == 0) { ssize_t op; if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); op=ParseCommandOption(MagickFunctionOptions,MagickFalse,argv[i]); if (op < 0) ThrowMogrifyException(OptionError,"UnrecognizedFunction",argv[i]); i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); break; } if (LocaleCompare("fuzz",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("fx",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); break; } ThrowMogrifyException(OptionError,"UnrecognizedOption",option) } case 'g': { if (LocaleCompare("gamma",option+1) == 0) { i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if ((LocaleCompare("gaussian-blur",option+1) == 0) || (LocaleCompare("gaussian",option+1) == 0)) { i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("geometry",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("gravity",option+1) == 0) { ssize_t gravity; if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); gravity=ParseCommandOption(MagickGravityOptions,MagickFalse, argv[i]); if (gravity < 0) ThrowMogrifyException(OptionError,"UnrecognizedGravityType", argv[i]); break; } if (LocaleCompare("grayscale",option+1) == 0) { ssize_t method; if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); method=ParseCommandOption(MagickPixelIntensityOptions,MagickFalse, argv[i]); if (method < 0) ThrowMogrifyException(OptionError,"UnrecognizedIntensityMethod", argv[i]); break; } if (LocaleCompare("green-primary",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } ThrowMogrifyException(OptionError,"UnrecognizedOption",option) } case 'h': { if (LocaleCompare("hald-clut",option+1) == 0) break; if ((LocaleCompare("help",option+1) == 0) || (LocaleCompare("-help",option+1) == 0)) return(MogrifyUsage()); if (LocaleCompare("hough-lines",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } ThrowMogrifyException(OptionError,"UnrecognizedOption",option) } case 'i': { if (LocaleCompare("identify",option+1) == 0) break; if (LocaleCompare("idft",option+1) == 0) break; if (LocaleCompare("implode",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("intensity",option+1) == 0) { ssize_t intensity; if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); intensity=ParseCommandOption(MagickPixelIntensityOptions, MagickFalse,argv[i]); if (intensity < 0) ThrowMogrifyException(OptionError, "UnrecognizedPixelIntensityMethod",argv[i]); break; } if (LocaleCompare("intent",option+1) == 0) { ssize_t intent; if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); intent=ParseCommandOption(MagickIntentOptions,MagickFalse,argv[i]); if (intent < 0) ThrowMogrifyException(OptionError,"UnrecognizedIntentType", argv[i]); break; } if (LocaleCompare("interlace",option+1) == 0) { ssize_t interlace; if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); interlace=ParseCommandOption(MagickInterlaceOptions,MagickFalse, argv[i]); if (interlace < 0) ThrowMogrifyException(OptionError,"UnrecognizedInterlaceType", argv[i]); break; } if (LocaleCompare("interline-spacing",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("interpolate",option+1) == 0) { ssize_t interpolate; if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); interpolate=ParseCommandOption(MagickInterpolateOptions,MagickFalse, argv[i]); if (interpolate < 0) ThrowMogrifyException(OptionError,"UnrecognizedInterpolateMethod", argv[i]); break; } if (LocaleCompare("interword-spacing",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } ThrowMogrifyException(OptionError,"UnrecognizedOption",option) } case 'k': { if (LocaleCompare("kerning",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("kuwahara",option+1) == 0) { i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } ThrowMogrifyException(OptionError,"UnrecognizedOption",option) } case 'l': { if (LocaleCompare("label",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); break; } if (LocaleCompare("lat",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); } if (LocaleCompare("layers",option+1) == 0) { ssize_t type; if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); type=ParseCommandOption(MagickLayerOptions,MagickFalse,argv[i]); if (type < 0) ThrowMogrifyException(OptionError,"UnrecognizedLayerMethod", argv[i]); break; } if (LocaleCompare("level",option+1) == 0) { i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("level-colors",option+1) == 0) { i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); break; } if (LocaleCompare("limit",option+1) == 0) { char *p; double value; ssize_t resource; if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); resource=ParseCommandOption(MagickResourceOptions,MagickFalse, argv[i]); if (resource < 0) ThrowMogrifyException(OptionError,"UnrecognizedResourceType", argv[i]); i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); value=StringToDouble(argv[i],&p); (void) value; if ((p == argv[i]) && (LocaleCompare("unlimited",argv[i]) != 0)) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("liquid-rescale",option+1) == 0) { i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("list",option+1) == 0) { ssize_t list; if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); list=ParseCommandOption(MagickListOptions,MagickFalse,argv[i]); if (list < 0) ThrowMogrifyException(OptionError,"UnrecognizedListType",argv[i]); status=MogrifyImageInfo(image_info,(int) (i-j+1),(const char **) argv+j,exception); return(status == 0 ? MagickFalse : MagickTrue); } if (LocaleCompare("log",option+1) == 0) { if (*option == '+') break; i++; if ((i == (ssize_t) argc) || (strchr(argv[i],'%') == (char *) NULL)) ThrowMogrifyException(OptionError,"MissingArgument",option); break; } if (LocaleCompare("loop",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } ThrowMogrifyException(OptionError,"UnrecognizedOption",option) } case 'm': { if (LocaleCompare("magnify",option+1) == 0) break; if (LocaleCompare("map",option+1) == 0) { global_colormap=(*option == '+') ? MagickTrue : MagickFalse; if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); break; } if (LocaleCompare("mask",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); break; } if (LocaleCompare("matte",option+1) == 0) break; if (LocaleCompare("mattecolor",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); break; } if (LocaleCompare("maximum",option+1) == 0) break; if (LocaleCompare("mean-shift",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("median",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("metric",option+1) == 0) { ssize_t type; if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); type=ParseCommandOption(MagickMetricOptions,MagickTrue,argv[i]); if (type < 0) ThrowMogrifyException(OptionError,"UnrecognizedMetricType", argv[i]); break; } if (LocaleCompare("minimum",option+1) == 0) break; if (LocaleCompare("modulate",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("mode",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("monitor",option+1) == 0) break; if (LocaleCompare("monochrome",option+1) == 0) break; if (LocaleCompare("morph",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("morphology",option+1) == 0) { char token[MagickPathExtent]; KernelInfo *kernel_info; ssize_t op; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); GetNextToken(argv[i],(const char **) NULL,MagickPathExtent,token); op=ParseCommandOption(MagickMorphologyOptions,MagickFalse,token); if (op < 0) ThrowMogrifyException(OptionError,"UnrecognizedMorphologyMethod", token); i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); kernel_info=AcquireKernelInfo(argv[i],exception); if (kernel_info == (KernelInfo *) NULL) ThrowMogrifyInvalidArgumentException(option,argv[i]); kernel_info=DestroyKernelInfo(kernel_info); break; } if (LocaleCompare("mosaic",option+1) == 0) break; if (LocaleCompare("motion-blur",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } ThrowMogrifyException(OptionError,"UnrecognizedOption",option) } case 'n': { if (LocaleCompare("negate",option+1) == 0) break; if (LocaleCompare("noise",option+1) == 0) { i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (*option == '+') { ssize_t noise; noise=ParseCommandOption(MagickNoiseOptions,MagickFalse, argv[i]); if (noise < 0) ThrowMogrifyException(OptionError,"UnrecognizedNoiseType", argv[i]); break; } if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("noop",option+1) == 0) break; if (LocaleCompare("normalize",option+1) == 0) break; ThrowMogrifyException(OptionError,"UnrecognizedOption",option) } case 'o': { if (LocaleCompare("opaque",option+1) == 0) { i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); break; } if (LocaleCompare("ordered-dither",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); break; } if (LocaleCompare("orient",option+1) == 0) { ssize_t orientation; orientation=UndefinedOrientation; if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); orientation=ParseCommandOption(MagickOrientationOptions,MagickFalse, argv[i]); if (orientation < 0) ThrowMogrifyException(OptionError,"UnrecognizedImageOrientation", argv[i]); break; } ThrowMogrifyException(OptionError,"UnrecognizedOption",option) } case 'p': { if (LocaleCompare("page",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); break; } if (LocaleCompare("paint",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("path",option+1) == 0) { (void) CloneString(&path,(char *) NULL); if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); (void) CloneString(&path,argv[i]); break; } if (LocaleCompare("perceptible",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("pointsize",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("polaroid",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("poly",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("posterize",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("precision",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("print",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); break; } if (LocaleCompare("process",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); break; } if (LocaleCompare("profile",option+1) == 0) { i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); break; } ThrowMogrifyException(OptionError,"UnrecognizedOption",option) } case 'q': { if (LocaleCompare("quality",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("quantize",option+1) == 0) { ssize_t colorspace; if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); colorspace=ParseCommandOption(MagickColorspaceOptions,MagickFalse, argv[i]); if (colorspace < 0) ThrowMogrifyException(OptionError,"UnrecognizedColorspace", argv[i]); break; } if (LocaleCompare("quiet",option+1) == 0) break; ThrowMogrifyException(OptionError,"UnrecognizedOption",option) } case 'r': { if (LocaleCompare("rotational-blur",option+1) == 0) { i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("raise",option+1) == 0) { i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("random-threshold",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("range-threshold",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("read-mask",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); break; } if (LocaleCompare("red-primary",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); } if (LocaleCompare("regard-warnings",option+1) == 0) break; if (LocaleCompare("region",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("remap",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); break; } if (LocaleCompare("render",option+1) == 0) break; if (LocaleCompare("repage",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("resample",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("resize",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleNCompare("respect-parentheses",option+1,17) == 0) { respect_parenthesis=(*option == '-') ? MagickTrue : MagickFalse; break; } if (LocaleCompare("reverse",option+1) == 0) break; if (LocaleCompare("roll",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("rotate",option+1) == 0) { i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } ThrowMogrifyException(OptionError,"UnrecognizedOption",option) } case 's': { if (LocaleCompare("sample",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("sampling-factor",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("scale",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("scene",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("seed",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("segment",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("selective-blur",option+1) == 0) { i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("separate",option+1) == 0) break; if (LocaleCompare("sepia-tone",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("set",option+1) == 0) { i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); break; } if (LocaleCompare("shade",option+1) == 0) { i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("shadow",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("sharpen",option+1) == 0) { i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("shave",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("shear",option+1) == 0) { i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("sigmoidal-contrast",option+1) == 0) { i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("size",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("sketch",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("smush",option+1) == 0) { i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); i++; break; } if (LocaleCompare("solarize",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("sparse-color",option+1) == 0) { ssize_t op; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); op=ParseCommandOption(MagickSparseColorOptions,MagickFalse,argv[i]); if (op < 0) ThrowMogrifyException(OptionError,"UnrecognizedSparseColorMethod", argv[i]); i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); break; } if (LocaleCompare("splice",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("spread",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("statistic",option+1) == 0) { ssize_t op; if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); op=ParseCommandOption(MagickStatisticOptions,MagickFalse,argv[i]); if (op < 0) ThrowMogrifyException(OptionError,"UnrecognizedStatisticType", argv[i]); i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("stretch",option+1) == 0) { ssize_t stretch; if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); stretch=ParseCommandOption(MagickStretchOptions,MagickFalse, argv[i]); if (stretch < 0) ThrowMogrifyException(OptionError,"UnrecognizedStyleType", argv[i]); break; } if (LocaleCompare("strip",option+1) == 0) break; if (LocaleCompare("stroke",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); break; } if (LocaleCompare("strokewidth",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("style",option+1) == 0) { ssize_t style; if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); style=ParseCommandOption(MagickStyleOptions,MagickFalse,argv[i]); if (style < 0) ThrowMogrifyException(OptionError,"UnrecognizedStyleType", argv[i]); break; } if (LocaleCompare("swap",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("swirl",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("synchronize",option+1) == 0) break; ThrowMogrifyException(OptionError,"UnrecognizedOption",option) } case 't': { if (LocaleCompare("taint",option+1) == 0) break; if (LocaleCompare("texture",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); break; } if (LocaleCompare("tile",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); break; } if (LocaleCompare("tile-offset",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("tint",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("transform",option+1) == 0) break; if (LocaleCompare("transpose",option+1) == 0) break; if (LocaleCompare("transverse",option+1) == 0) break; if (LocaleCompare("threshold",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("thumbnail",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("transparent",option+1) == 0) { i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); break; } if (LocaleCompare("transparent-color",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); break; } if (LocaleCompare("treedepth",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("trim",option+1) == 0) break; if (LocaleCompare("type",option+1) == 0) { ssize_t type; if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); type=ParseCommandOption(MagickTypeOptions,MagickFalse,argv[i]); if (type < 0) ThrowMogrifyException(OptionError,"UnrecognizedImageType", argv[i]); break; } ThrowMogrifyException(OptionError,"UnrecognizedOption",option) } case 'u': { if (LocaleCompare("undercolor",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); break; } if (LocaleCompare("unique-colors",option+1) == 0) break; if (LocaleCompare("units",option+1) == 0) { ssize_t units; if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); units=ParseCommandOption(MagickResolutionOptions,MagickFalse, argv[i]); if (units < 0) ThrowMogrifyException(OptionError,"UnrecognizedUnitsType", argv[i]); break; } if (LocaleCompare("unsharp",option+1) == 0) { i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } ThrowMogrifyException(OptionError,"UnrecognizedOption",option) } case 'v': { if (LocaleCompare("verbose",option+1) == 0) { image_info->verbose=(*option == '-') ? MagickTrue : MagickFalse; break; } if ((LocaleCompare("version",option+1) == 0) || (LocaleCompare("-version",option+1) == 0)) { ListMagickVersion(stdout); break; } if (LocaleCompare("vignette",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("virtual-pixel",option+1) == 0) { ssize_t method; if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); method=ParseCommandOption(MagickVirtualPixelOptions,MagickFalse, argv[i]); if (method < 0) ThrowMogrifyException(OptionError, "UnrecognizedVirtualPixelMethod",argv[i]); break; } ThrowMogrifyException(OptionError,"UnrecognizedOption",option) } case 'w': { if (LocaleCompare("wave",option+1) == 0) { i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("wavelet-denoise",option+1) == 0) { i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("weight",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); break; } if (LocaleCompare("white-point",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("white-threshold",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("write",option+1) == 0) { i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); break; } if (LocaleCompare("write-mask",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); break; } ThrowMogrifyException(OptionError,"UnrecognizedOption",option) } case '?': break; default: ThrowMogrifyException(OptionError,"UnrecognizedOption",option) } fire=(GetCommandOptionFlags(MagickCommandOptions,MagickFalse,option) & FireOptionFlag) == 0 ? MagickFalse : MagickTrue; if (fire != MagickFalse) FireImageStack(MagickFalse,MagickTrue,MagickTrue); } if (k != 0) ThrowMogrifyException(OptionError,"UnbalancedParenthesis",argv[i]); if (i != (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingAnImageFilename",argv[i]); DestroyMogrify(); return(status != 0 ? MagickTrue : MagickFalse); }
WandExport MagickBooleanType MogrifyImageCommand(ImageInfo *image_info, int argc,char **argv,char **wand_unused(metadata),ExceptionInfo *exception) { #define DestroyMogrify() \ { \ if (format != (char *) NULL) \ format=DestroyString(format); \ if (path != (char *) NULL) \ path=DestroyString(path); \ DestroyImageStack(); \ for (i=0; i < (ssize_t) argc; i++) \ argv[i]=DestroyString(argv[i]); \ argv=(char **) RelinquishMagickMemory(argv); \ } #define ThrowMogrifyException(asperity,tag,option) \ { \ (void) ThrowMagickException(exception,GetMagickModule(),asperity,tag,"`%s'", \ option); \ DestroyMogrify(); \ return(MagickFalse); \ } #define ThrowMogrifyInvalidArgumentException(option,argument) \ { \ (void) ThrowMagickException(exception,GetMagickModule(),OptionError, \ "InvalidArgument","'%s': %s",argument,option); \ DestroyMogrify(); \ return(MagickFalse); \ } char *format, *option, *path; Image *image; ImageStack image_stack[MaxImageStackDepth+1]; MagickBooleanType global_colormap; MagickBooleanType fire, pend, respect_parenthesis; MagickStatusType status; register ssize_t i; ssize_t j, k; wand_unreferenced(metadata); /* Set defaults. */ assert(image_info != (ImageInfo *) NULL); assert(image_info->signature == MagickCoreSignature); if (image_info->debug != MagickFalse) (void) LogMagickEvent(TraceEvent,GetMagickModule(),"..."); assert(exception != (ExceptionInfo *) NULL); if (argc == 2) { option=argv[1]; if ((LocaleCompare("version",option+1) == 0) || (LocaleCompare("-version",option+1) == 0)) { ListMagickVersion(stdout); return(MagickTrue); } } if (argc < 2) return(MogrifyUsage()); format=(char *) NULL; path=(char *) NULL; global_colormap=MagickFalse; k=0; j=1; NewImageStack(); option=(char *) NULL; pend=MagickFalse; respect_parenthesis=MagickFalse; status=MagickTrue; /* Parse command line. */ ReadCommandlLine(argc,&argv); status=ExpandFilenames(&argc,&argv); if (status == MagickFalse) ThrowMogrifyException(ResourceLimitError,"MemoryAllocationFailed", GetExceptionMessage(errno)); for (i=1; i < (ssize_t) argc; i++) { option=argv[i]; if (LocaleCompare(option,"(") == 0) { FireImageStack(MagickFalse,MagickTrue,pend); if (k == MaxImageStackDepth) ThrowMogrifyException(OptionError,"ParenthesisNestedTooDeeply", option); PushImageStack(); continue; } if (LocaleCompare(option,")") == 0) { FireImageStack(MagickFalse,MagickTrue,MagickTrue); if (k == 0) ThrowMogrifyException(OptionError,"UnableToParseExpression",option); PopImageStack(); continue; } if (IsCommandOption(option) == MagickFalse) { char backup_filename[MagickPathExtent], *filename; Image *images; struct stat properties; /* Option is a file name: begin by reading image from specified file. */ FireImageStack(MagickFalse,MagickFalse,pend); filename=argv[i]; if ((LocaleCompare(filename,"--") == 0) && (i < (ssize_t) (argc-1))) filename=argv[++i]; images=ReadImages(image_info,filename,exception); status&=(images != (Image *) NULL) && (exception->severity < ErrorException); if (images == (Image *) NULL) continue; properties=(*GetBlobProperties(images)); if (format != (char *) NULL) (void) CopyMagickString(images->filename,images->magick_filename, MagickPathExtent); if (path != (char *) NULL) { GetPathComponent(option,TailPath,filename); (void) FormatLocaleString(images->filename,MagickPathExtent, "%s%c%s",path,*DirectorySeparator,filename); } if (format != (char *) NULL) AppendImageFormat(format,images->filename); AppendImageStack(images); FinalizeImageSettings(image_info,image,MagickFalse); if (global_colormap != MagickFalse) { QuantizeInfo *quantize_info; quantize_info=AcquireQuantizeInfo(image_info); (void) RemapImages(quantize_info,images,(Image *) NULL,exception); quantize_info=DestroyQuantizeInfo(quantize_info); } *backup_filename='\0'; if ((LocaleCompare(image->filename,"-") != 0) && (IsPathWritable(image->filename) != MagickFalse)) { /* Rename image file as backup. */ (void) CopyMagickString(backup_filename,image->filename, MagickPathExtent); for (j=0; j < 6; j++) { (void) ConcatenateMagickString(backup_filename,"~", MagickPathExtent); if (IsPathAccessible(backup_filename) == MagickFalse) break; } if ((IsPathAccessible(backup_filename) != MagickFalse) || (rename_utf8(image->filename,backup_filename) != 0)) *backup_filename='\0'; } /* Write transmogrified image to disk. */ image_info->synchronize=MagickTrue; status&=WriteImages(image_info,image,image->filename,exception); if (status != MagickFalse) { #if defined(MAGICKCORE_HAVE_UTIME) { MagickBooleanType preserve_timestamp; preserve_timestamp=IsStringTrue(GetImageOption(image_info, "preserve-timestamp")); if (preserve_timestamp != MagickFalse) { struct utimbuf timestamp; timestamp.actime=properties.st_atime; timestamp.modtime=properties.st_mtime; (void) utime(image->filename,&timestamp); } } #endif if (*backup_filename != '\0') (void) remove_utf8(backup_filename); } RemoveAllImageStack(); continue; } pend=image != (Image *) NULL ? MagickTrue : MagickFalse; switch (*(option+1)) { case 'a': { if (LocaleCompare("adaptive-blur",option+1) == 0) { i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("adaptive-resize",option+1) == 0) { i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("adaptive-sharpen",option+1) == 0) { i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("affine",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); break; } if (LocaleCompare("alpha",option+1) == 0) { ssize_t type; if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); type=ParseCommandOption(MagickAlphaChannelOptions,MagickFalse, argv[i]); if (type < 0) ThrowMogrifyException(OptionError, "UnrecognizedAlphaChannelOption",argv[i]); break; } if (LocaleCompare("annotate",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); i++; break; } if (LocaleCompare("antialias",option+1) == 0) break; if (LocaleCompare("append",option+1) == 0) break; if (LocaleCompare("attenuate",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("authenticate",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); break; } if (LocaleCompare("auto-gamma",option+1) == 0) break; if (LocaleCompare("auto-level",option+1) == 0) break; if (LocaleCompare("auto-orient",option+1) == 0) break; if (LocaleCompare("auto-threshold",option+1) == 0) { ssize_t method; if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); method=ParseCommandOption(MagickAutoThresholdOptions,MagickFalse, argv[i]); if (method < 0) ThrowMogrifyException(OptionError,"UnrecognizedThresholdMethod", argv[i]); break; } if (LocaleCompare("average",option+1) == 0) break; ThrowMogrifyException(OptionError,"UnrecognizedOption",option) } case 'b': { if (LocaleCompare("background",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); break; } if (LocaleCompare("bias",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("black-point-compensation",option+1) == 0) break; if (LocaleCompare("black-threshold",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("blue-primary",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("blue-shift",option+1) == 0) { i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("blur",option+1) == 0) { i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("border",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("bordercolor",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); break; } if (LocaleCompare("box",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); break; } if (LocaleCompare("brightness-contrast",option+1) == 0) { i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } ThrowMogrifyException(OptionError,"UnrecognizedOption",option) } case 'c': { if (LocaleCompare("cache",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("canny",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("caption",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); break; } if (LocaleCompare("channel",option+1) == 0) { ssize_t channel; if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); channel=ParseChannelOption(argv[i]); if (channel < 0) ThrowMogrifyException(OptionError,"UnrecognizedChannelType", argv[i]); break; } if (LocaleCompare("channel-fx",option+1) == 0) { ssize_t channel; if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); channel=ParsePixelChannelOption(argv[i]); if (channel < 0) ThrowMogrifyException(OptionError,"UnrecognizedChannelType", argv[i]); break; } if (LocaleCompare("cdl",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); break; } if (LocaleCompare("charcoal",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("chop",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("clahe",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("clamp",option+1) == 0) break; if (LocaleCompare("clip",option+1) == 0) break; if (LocaleCompare("clip-mask",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); break; } if (LocaleCompare("clut",option+1) == 0) break; if (LocaleCompare("coalesce",option+1) == 0) break; if (LocaleCompare("colorize",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("color-matrix",option+1) == 0) { KernelInfo *kernel_info; if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); kernel_info=AcquireKernelInfo(argv[i],exception); if (kernel_info == (KernelInfo *) NULL) ThrowMogrifyInvalidArgumentException(option,argv[i]); kernel_info=DestroyKernelInfo(kernel_info); break; } if (LocaleCompare("colors",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("colorspace",option+1) == 0) { ssize_t colorspace; if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); colorspace=ParseCommandOption(MagickColorspaceOptions,MagickFalse, argv[i]); if (colorspace < 0) ThrowMogrifyException(OptionError,"UnrecognizedColorspace", argv[i]); break; } if (LocaleCompare("combine",option+1) == 0) { ssize_t colorspace; if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); colorspace=ParseCommandOption(MagickColorspaceOptions,MagickFalse, argv[i]); if (colorspace < 0) ThrowMogrifyException(OptionError,"UnrecognizedColorspace", argv[i]); break; } if (LocaleCompare("compare",option+1) == 0) break; if (LocaleCompare("comment",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); break; } if (LocaleCompare("composite",option+1) == 0) break; if (LocaleCompare("compress",option+1) == 0) { ssize_t compress; if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); compress=ParseCommandOption(MagickCompressOptions,MagickFalse, argv[i]); if (compress < 0) ThrowMogrifyException(OptionError,"UnrecognizedImageCompression", argv[i]); break; } if (LocaleCompare("concurrent",option+1) == 0) break; if (LocaleCompare("connected-components",option+1) == 0) { i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("contrast",option+1) == 0) break; if (LocaleCompare("contrast-stretch",option+1) == 0) { i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("convolve",option+1) == 0) { KernelInfo *kernel_info; if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); kernel_info=AcquireKernelInfo(argv[i],exception); if (kernel_info == (KernelInfo *) NULL) ThrowMogrifyInvalidArgumentException(option,argv[i]); kernel_info=DestroyKernelInfo(kernel_info); break; } if (LocaleCompare("copy",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("crop",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("cycle",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } ThrowMogrifyException(OptionError,"UnrecognizedOption",option) } case 'd': { if (LocaleCompare("decipher",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); break; } if (LocaleCompare("deconstruct",option+1) == 0) break; if (LocaleCompare("debug",option+1) == 0) { ssize_t event; if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); event=ParseCommandOption(MagickLogEventOptions,MagickFalse,argv[i]); if (event < 0) ThrowMogrifyException(OptionError,"UnrecognizedEventType", argv[i]); (void) SetLogEventMask(argv[i]); break; } if (LocaleCompare("define",option+1) == 0) { i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (*option == '+') { const char *define; define=GetImageOption(image_info,argv[i]); if (define == (const char *) NULL) ThrowMogrifyException(OptionError,"NoSuchOption",argv[i]); break; } break; } if (LocaleCompare("delay",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("delete",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("density",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("depth",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("deskew",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("despeckle",option+1) == 0) break; if (LocaleCompare("dft",option+1) == 0) break; if (LocaleCompare("direction",option+1) == 0) { ssize_t direction; if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); direction=ParseCommandOption(MagickDirectionOptions,MagickFalse, argv[i]); if (direction < 0) ThrowMogrifyException(OptionError,"UnrecognizedDirectionType", argv[i]); break; } if (LocaleCompare("display",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); break; } if (LocaleCompare("dispose",option+1) == 0) { ssize_t dispose; if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); dispose=ParseCommandOption(MagickDisposeOptions,MagickFalse, argv[i]); if (dispose < 0) ThrowMogrifyException(OptionError,"UnrecognizedDisposeMethod", argv[i]); break; } if (LocaleCompare("distort",option+1) == 0) { ssize_t op; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); op=ParseCommandOption(MagickDistortOptions,MagickFalse,argv[i]); if (op < 0) ThrowMogrifyException(OptionError,"UnrecognizedDistortMethod", argv[i]); i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); break; } if (LocaleCompare("dither",option+1) == 0) { ssize_t method; if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); method=ParseCommandOption(MagickDitherOptions,MagickFalse,argv[i]); if (method < 0) ThrowMogrifyException(OptionError,"UnrecognizedDitherMethod", argv[i]); break; } if (LocaleCompare("draw",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); break; } if (LocaleCompare("duplicate",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("duration",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } ThrowMogrifyException(OptionError,"UnrecognizedOption",option) } case 'e': { if (LocaleCompare("edge",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("emboss",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("encipher",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); break; } if (LocaleCompare("encoding",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); break; } if (LocaleCompare("endian",option+1) == 0) { ssize_t endian; if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); endian=ParseCommandOption(MagickEndianOptions,MagickFalse,argv[i]); if (endian < 0) ThrowMogrifyException(OptionError,"UnrecognizedEndianType", argv[i]); break; } if (LocaleCompare("enhance",option+1) == 0) break; if (LocaleCompare("equalize",option+1) == 0) break; if (LocaleCompare("evaluate",option+1) == 0) { ssize_t op; if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); op=ParseCommandOption(MagickEvaluateOptions,MagickFalse,argv[i]); if (op < 0) ThrowMogrifyException(OptionError,"UnrecognizedEvaluateOperator", argv[i]); i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("evaluate-sequence",option+1) == 0) { ssize_t op; if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); op=ParseCommandOption(MagickEvaluateOptions,MagickFalse,argv[i]); if (op < 0) ThrowMogrifyException(OptionError,"UnrecognizedEvaluateOperator", argv[i]); break; } if (LocaleCompare("extent",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("extract",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } ThrowMogrifyException(OptionError,"UnrecognizedOption",option) } case 'f': { if (LocaleCompare("family",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); break; } if (LocaleCompare("features",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("fill",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); break; } if (LocaleCompare("filter",option+1) == 0) { ssize_t filter; if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); filter=ParseCommandOption(MagickFilterOptions,MagickFalse,argv[i]); if (filter < 0) ThrowMogrifyException(OptionError,"UnrecognizedImageFilter", argv[i]); break; } if (LocaleCompare("flatten",option+1) == 0) break; if (LocaleCompare("flip",option+1) == 0) break; if (LocaleCompare("flop",option+1) == 0) break; if (LocaleCompare("floodfill",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); break; } if (LocaleCompare("font",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); break; } if (LocaleCompare("format",option+1) == 0) { (void) CopyMagickString(argv[i]+1,"sans",MagickPathExtent); (void) CloneString(&format,(char *) NULL); if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); (void) CloneString(&format,argv[i]); (void) CopyMagickString(image_info->filename,format, MagickPathExtent); (void) ConcatenateMagickString(image_info->filename,":", MagickPathExtent); (void) SetImageInfo(image_info,0,exception); if (*image_info->magick == '\0') ThrowMogrifyException(OptionError,"UnrecognizedImageFormat", format); break; } if (LocaleCompare("frame",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("function",option+1) == 0) { ssize_t op; if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); op=ParseCommandOption(MagickFunctionOptions,MagickFalse,argv[i]); if (op < 0) ThrowMogrifyException(OptionError,"UnrecognizedFunction",argv[i]); i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); break; } if (LocaleCompare("fuzz",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("fx",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); break; } ThrowMogrifyException(OptionError,"UnrecognizedOption",option) } case 'g': { if (LocaleCompare("gamma",option+1) == 0) { i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if ((LocaleCompare("gaussian-blur",option+1) == 0) || (LocaleCompare("gaussian",option+1) == 0)) { i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("geometry",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("gravity",option+1) == 0) { ssize_t gravity; if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); gravity=ParseCommandOption(MagickGravityOptions,MagickFalse, argv[i]); if (gravity < 0) ThrowMogrifyException(OptionError,"UnrecognizedGravityType", argv[i]); break; } if (LocaleCompare("grayscale",option+1) == 0) { ssize_t method; if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); method=ParseCommandOption(MagickPixelIntensityOptions,MagickFalse, argv[i]); if (method < 0) ThrowMogrifyException(OptionError,"UnrecognizedIntensityMethod", argv[i]); break; } if (LocaleCompare("green-primary",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } ThrowMogrifyException(OptionError,"UnrecognizedOption",option) } case 'h': { if (LocaleCompare("hald-clut",option+1) == 0) break; if ((LocaleCompare("help",option+1) == 0) || (LocaleCompare("-help",option+1) == 0)) return(MogrifyUsage()); if (LocaleCompare("hough-lines",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } ThrowMogrifyException(OptionError,"UnrecognizedOption",option) } case 'i': { if (LocaleCompare("identify",option+1) == 0) break; if (LocaleCompare("idft",option+1) == 0) break; if (LocaleCompare("implode",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("intensity",option+1) == 0) { ssize_t intensity; if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); intensity=ParseCommandOption(MagickPixelIntensityOptions, MagickFalse,argv[i]); if (intensity < 0) ThrowMogrifyException(OptionError, "UnrecognizedPixelIntensityMethod",argv[i]); break; } if (LocaleCompare("intent",option+1) == 0) { ssize_t intent; if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); intent=ParseCommandOption(MagickIntentOptions,MagickFalse,argv[i]); if (intent < 0) ThrowMogrifyException(OptionError,"UnrecognizedIntentType", argv[i]); break; } if (LocaleCompare("interlace",option+1) == 0) { ssize_t interlace; if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); interlace=ParseCommandOption(MagickInterlaceOptions,MagickFalse, argv[i]); if (interlace < 0) ThrowMogrifyException(OptionError,"UnrecognizedInterlaceType", argv[i]); break; } if (LocaleCompare("interline-spacing",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("interpolate",option+1) == 0) { ssize_t interpolate; if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); interpolate=ParseCommandOption(MagickInterpolateOptions,MagickFalse, argv[i]); if (interpolate < 0) ThrowMogrifyException(OptionError,"UnrecognizedInterpolateMethod", argv[i]); break; } if (LocaleCompare("interword-spacing",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } ThrowMogrifyException(OptionError,"UnrecognizedOption",option) } case 'k': { if (LocaleCompare("kerning",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("kuwahara",option+1) == 0) { i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } ThrowMogrifyException(OptionError,"UnrecognizedOption",option) } case 'l': { if (LocaleCompare("label",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); break; } if (LocaleCompare("lat",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); } if (LocaleCompare("layers",option+1) == 0) { ssize_t type; if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); type=ParseCommandOption(MagickLayerOptions,MagickFalse,argv[i]); if (type < 0) ThrowMogrifyException(OptionError,"UnrecognizedLayerMethod", argv[i]); break; } if (LocaleCompare("level",option+1) == 0) { i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("level-colors",option+1) == 0) { i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); break; } if (LocaleCompare("limit",option+1) == 0) { char *p; double value; ssize_t resource; if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); resource=ParseCommandOption(MagickResourceOptions,MagickFalse, argv[i]); if (resource < 0) ThrowMogrifyException(OptionError,"UnrecognizedResourceType", argv[i]); i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); value=StringToDouble(argv[i],&p); (void) value; if ((p == argv[i]) && (LocaleCompare("unlimited",argv[i]) != 0)) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("liquid-rescale",option+1) == 0) { i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("list",option+1) == 0) { ssize_t list; if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); list=ParseCommandOption(MagickListOptions,MagickFalse,argv[i]); if (list < 0) ThrowMogrifyException(OptionError,"UnrecognizedListType",argv[i]); status=MogrifyImageInfo(image_info,(int) (i-j+1),(const char **) argv+j,exception); return(status == 0 ? MagickFalse : MagickTrue); } if (LocaleCompare("log",option+1) == 0) { if (*option == '+') break; i++; if ((i == (ssize_t) argc) || (strchr(argv[i],'%') == (char *) NULL)) ThrowMogrifyException(OptionError,"MissingArgument",option); break; } if (LocaleCompare("loop",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } ThrowMogrifyException(OptionError,"UnrecognizedOption",option) } case 'm': { if (LocaleCompare("magnify",option+1) == 0) break; if (LocaleCompare("map",option+1) == 0) { global_colormap=(*option == '+') ? MagickTrue : MagickFalse; if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); break; } if (LocaleCompare("mask",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); break; } if (LocaleCompare("matte",option+1) == 0) break; if (LocaleCompare("mattecolor",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); break; } if (LocaleCompare("maximum",option+1) == 0) break; if (LocaleCompare("mean-shift",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("median",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("metric",option+1) == 0) { ssize_t type; if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); type=ParseCommandOption(MagickMetricOptions,MagickTrue,argv[i]); if (type < 0) ThrowMogrifyException(OptionError,"UnrecognizedMetricType", argv[i]); break; } if (LocaleCompare("minimum",option+1) == 0) break; if (LocaleCompare("modulate",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("mode",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("monitor",option+1) == 0) break; if (LocaleCompare("monochrome",option+1) == 0) break; if (LocaleCompare("morph",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("morphology",option+1) == 0) { char token[MagickPathExtent]; KernelInfo *kernel_info; ssize_t op; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); GetNextToken(argv[i],(const char **) NULL,MagickPathExtent,token); op=ParseCommandOption(MagickMorphologyOptions,MagickFalse,token); if (op < 0) ThrowMogrifyException(OptionError,"UnrecognizedMorphologyMethod", token); i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); kernel_info=AcquireKernelInfo(argv[i],exception); if (kernel_info == (KernelInfo *) NULL) ThrowMogrifyInvalidArgumentException(option,argv[i]); kernel_info=DestroyKernelInfo(kernel_info); break; } if (LocaleCompare("mosaic",option+1) == 0) break; if (LocaleCompare("motion-blur",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } ThrowMogrifyException(OptionError,"UnrecognizedOption",option) } case 'n': { if (LocaleCompare("negate",option+1) == 0) break; if (LocaleCompare("noise",option+1) == 0) { i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (*option == '+') { ssize_t noise; noise=ParseCommandOption(MagickNoiseOptions,MagickFalse, argv[i]); if (noise < 0) ThrowMogrifyException(OptionError,"UnrecognizedNoiseType", argv[i]); break; } if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("noop",option+1) == 0) break; if (LocaleCompare("normalize",option+1) == 0) break; ThrowMogrifyException(OptionError,"UnrecognizedOption",option) } case 'o': { if (LocaleCompare("opaque",option+1) == 0) { i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); break; } if (LocaleCompare("ordered-dither",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); break; } if (LocaleCompare("orient",option+1) == 0) { ssize_t orientation; orientation=UndefinedOrientation; if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); orientation=ParseCommandOption(MagickOrientationOptions,MagickFalse, argv[i]); if (orientation < 0) ThrowMogrifyException(OptionError,"UnrecognizedImageOrientation", argv[i]); break; } ThrowMogrifyException(OptionError,"UnrecognizedOption",option) } case 'p': { if (LocaleCompare("page",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); break; } if (LocaleCompare("paint",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("path",option+1) == 0) { (void) CloneString(&path,(char *) NULL); if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); (void) CloneString(&path,argv[i]); break; } if (LocaleCompare("perceptible",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("pointsize",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("polaroid",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("poly",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("posterize",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("precision",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("print",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); break; } if (LocaleCompare("process",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); break; } if (LocaleCompare("profile",option+1) == 0) { i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); break; } ThrowMogrifyException(OptionError,"UnrecognizedOption",option) } case 'q': { if (LocaleCompare("quality",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("quantize",option+1) == 0) { ssize_t colorspace; if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); colorspace=ParseCommandOption(MagickColorspaceOptions,MagickFalse, argv[i]); if (colorspace < 0) ThrowMogrifyException(OptionError,"UnrecognizedColorspace", argv[i]); break; } if (LocaleCompare("quiet",option+1) == 0) break; ThrowMogrifyException(OptionError,"UnrecognizedOption",option) } case 'r': { if (LocaleCompare("rotational-blur",option+1) == 0) { i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("raise",option+1) == 0) { i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("random-threshold",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("range-threshold",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("read-mask",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); break; } if (LocaleCompare("red-primary",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); } if (LocaleCompare("regard-warnings",option+1) == 0) break; if (LocaleCompare("region",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("remap",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); break; } if (LocaleCompare("render",option+1) == 0) break; if (LocaleCompare("repage",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("resample",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("resize",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleNCompare("respect-parentheses",option+1,17) == 0) { respect_parenthesis=(*option == '-') ? MagickTrue : MagickFalse; break; } if (LocaleCompare("reverse",option+1) == 0) break; if (LocaleCompare("roll",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("rotate",option+1) == 0) { i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } ThrowMogrifyException(OptionError,"UnrecognizedOption",option) } case 's': { if (LocaleCompare("sample",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("sampling-factor",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("scale",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("scene",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("seed",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("segment",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("selective-blur",option+1) == 0) { i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("separate",option+1) == 0) break; if (LocaleCompare("sepia-tone",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("set",option+1) == 0) { i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); break; } if (LocaleCompare("shade",option+1) == 0) { i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("shadow",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("sharpen",option+1) == 0) { i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("shave",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("shear",option+1) == 0) { i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("sigmoidal-contrast",option+1) == 0) { i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("size",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("sketch",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("smush",option+1) == 0) { i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); i++; break; } if (LocaleCompare("solarize",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("sparse-color",option+1) == 0) { ssize_t op; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); op=ParseCommandOption(MagickSparseColorOptions,MagickFalse,argv[i]); if (op < 0) ThrowMogrifyException(OptionError,"UnrecognizedSparseColorMethod", argv[i]); i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); break; } if (LocaleCompare("splice",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("spread",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("statistic",option+1) == 0) { ssize_t op; if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); op=ParseCommandOption(MagickStatisticOptions,MagickFalse,argv[i]); if (op < 0) ThrowMogrifyException(OptionError,"UnrecognizedStatisticType", argv[i]); i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("stretch",option+1) == 0) { ssize_t stretch; if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); stretch=ParseCommandOption(MagickStretchOptions,MagickFalse, argv[i]); if (stretch < 0) ThrowMogrifyException(OptionError,"UnrecognizedStyleType", argv[i]); break; } if (LocaleCompare("strip",option+1) == 0) break; if (LocaleCompare("stroke",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); break; } if (LocaleCompare("strokewidth",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("style",option+1) == 0) { ssize_t style; if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); style=ParseCommandOption(MagickStyleOptions,MagickFalse,argv[i]); if (style < 0) ThrowMogrifyException(OptionError,"UnrecognizedStyleType", argv[i]); break; } if (LocaleCompare("swap",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("swirl",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("synchronize",option+1) == 0) break; ThrowMogrifyException(OptionError,"UnrecognizedOption",option) } case 't': { if (LocaleCompare("taint",option+1) == 0) break; if (LocaleCompare("texture",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); break; } if (LocaleCompare("tile",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); break; } if (LocaleCompare("tile-offset",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("tint",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("transform",option+1) == 0) break; if (LocaleCompare("transpose",option+1) == 0) break; if (LocaleCompare("transverse",option+1) == 0) break; if (LocaleCompare("threshold",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("thumbnail",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("transparent",option+1) == 0) { i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); break; } if (LocaleCompare("transparent-color",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); break; } if (LocaleCompare("treedepth",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("trim",option+1) == 0) break; if (LocaleCompare("type",option+1) == 0) { ssize_t type; if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); type=ParseCommandOption(MagickTypeOptions,MagickFalse,argv[i]); if (type < 0) ThrowMogrifyException(OptionError,"UnrecognizedImageType", argv[i]); break; } ThrowMogrifyException(OptionError,"UnrecognizedOption",option) } case 'u': { if (LocaleCompare("undercolor",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); break; } if (LocaleCompare("unique-colors",option+1) == 0) break; if (LocaleCompare("units",option+1) == 0) { ssize_t units; if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); units=ParseCommandOption(MagickResolutionOptions,MagickFalse, argv[i]); if (units < 0) ThrowMogrifyException(OptionError,"UnrecognizedUnitsType", argv[i]); break; } if (LocaleCompare("unsharp",option+1) == 0) { i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } ThrowMogrifyException(OptionError,"UnrecognizedOption",option) } case 'v': { if (LocaleCompare("verbose",option+1) == 0) { image_info->verbose=(*option == '-') ? MagickTrue : MagickFalse; break; } if ((LocaleCompare("version",option+1) == 0) || (LocaleCompare("-version",option+1) == 0)) { ListMagickVersion(stdout); break; } if (LocaleCompare("vignette",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("virtual-pixel",option+1) == 0) { ssize_t method; if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); method=ParseCommandOption(MagickVirtualPixelOptions,MagickFalse, argv[i]); if (method < 0) ThrowMogrifyException(OptionError, "UnrecognizedVirtualPixelMethod",argv[i]); break; } ThrowMogrifyException(OptionError,"UnrecognizedOption",option) } case 'w': { if (LocaleCompare("wave",option+1) == 0) { i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("wavelet-denoise",option+1) == 0) { i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("weight",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); break; } if (LocaleCompare("white-point",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("white-threshold",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); if (IsGeometry(argv[i]) == MagickFalse) ThrowMogrifyInvalidArgumentException(option,argv[i]); break; } if (LocaleCompare("write",option+1) == 0) { i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); break; } if (LocaleCompare("write-mask",option+1) == 0) { if (*option == '+') break; i++; if (i == (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingArgument",option); break; } ThrowMogrifyException(OptionError,"UnrecognizedOption",option) } case '?': break; default: ThrowMogrifyException(OptionError,"UnrecognizedOption",option) } fire=(GetCommandOptionFlags(MagickCommandOptions,MagickFalse,option) & FireOptionFlag) == 0 ? MagickFalse : MagickTrue; if (fire != MagickFalse) FireImageStack(MagickFalse,MagickTrue,MagickTrue); } if (k != 0) ThrowMogrifyException(OptionError,"UnbalancedParenthesis",argv[i]); if (i != (ssize_t) argc) ThrowMogrifyException(OptionError,"MissingAnImageFilename",argv[i]); DestroyMogrify(); return(status != 0 ? MagickTrue : MagickFalse); }
C
ImageMagick6
0
CVE-2011-4930
https://www.cvedetails.com/cve/CVE-2011-4930/
CWE-134
https://htcondor-git.cs.wisc.edu/?p=condor.git;a=commitdiff;h=5e5571d1a431eb3c61977b6dd6ec90186ef79867
5e5571d1a431eb3c61977b6dd6ec90186ef79867
null
validate_entries( bool ignore_invalid_entry ) { HASHITER it = hash_iter_begin( ConfigTab, TABLESIZE ); unsigned int invalid_entries = 0; MyString tmp; MyString output = "The following configuration macros appear to contain default values that must be changed before Condor will run. These macros are:\n"; while( ! hash_iter_done(it) ) { char * val = hash_iter_value(it); if( strstr(val, FORBIDDEN_CONFIG_VAL) ) { char * name = hash_iter_key(it); MyString filename; int line_number; param_get_location(name, filename, line_number); tmp.sprintf(" %s (found on line %d of %s)\n", name, line_number, filename.Value()); output += tmp; invalid_entries++; } hash_iter_next(it); } hash_iter_delete(&it); if(invalid_entries > 0) { if(ignore_invalid_entry) { dprintf(D_ALWAYS, "%s", output.Value()); } else { EXCEPT("%s", output.Value()); } } }
validate_entries( bool ignore_invalid_entry ) { HASHITER it = hash_iter_begin( ConfigTab, TABLESIZE ); unsigned int invalid_entries = 0; MyString tmp; MyString output = "The following configuration macros appear to contain default values that must be changed before Condor will run. These macros are:\n"; while( ! hash_iter_done(it) ) { char * val = hash_iter_value(it); if( strstr(val, FORBIDDEN_CONFIG_VAL) ) { char * name = hash_iter_key(it); MyString filename; int line_number; param_get_location(name, filename, line_number); tmp.sprintf(" %s (found on line %d of %s)\n", name, line_number, filename.Value()); output += tmp; invalid_entries++; } hash_iter_next(it); } hash_iter_delete(&it); if(invalid_entries > 0) { if(ignore_invalid_entry) { dprintf(D_ALWAYS, "%s", output.Value()); } else { EXCEPT(output.Value()); } } }
CPP
htcondor
1
CVE-2013-4526
https://www.cvedetails.com/cve/CVE-2013-4526/
CWE-119
https://git.qemu.org/?p=qemu.git;a=commit;h=ae2158ad6ce0845b2fae2a22aa7f19c0d7a71ce5
ae2158ad6ce0845b2fae2a22aa7f19c0d7a71ce5
null
static int handle_cmd(AHCIState *s, int port, int slot) { IDEState *ide_state; uint32_t opts; uint64_t tbl_addr; AHCICmdHdr *cmd; uint8_t *cmd_fis; dma_addr_t cmd_len; if (s->dev[port].port.ifs[0].status & (BUSY_STAT|DRQ_STAT)) { /* Engine currently busy, try again later */ DPRINTF(port, "engine busy\n"); return -1; } cmd = &((AHCICmdHdr *)s->dev[port].lst)[slot]; if (!s->dev[port].lst) { DPRINTF(port, "error: lst not given but cmd handled"); return -1; } /* remember current slot handle for later */ s->dev[port].cur_cmd = cmd; opts = le32_to_cpu(cmd->opts); tbl_addr = le64_to_cpu(cmd->tbl_addr); cmd_len = 0x80; cmd_fis = dma_memory_map(s->as, tbl_addr, &cmd_len, DMA_DIRECTION_FROM_DEVICE); if (!cmd_fis) { DPRINTF(port, "error: guest passed us an invalid cmd fis\n"); return -1; } /* The device we are working for */ ide_state = &s->dev[port].port.ifs[0]; if (!ide_state->bs) { DPRINTF(port, "error: guest accessed unused port"); goto out; } debug_print_fis(cmd_fis, 0x90); switch (cmd_fis[0]) { case SATA_FIS_TYPE_REGISTER_H2D: break; default: DPRINTF(port, "unknown command cmd_fis[0]=%02x cmd_fis[1]=%02x " "cmd_fis[2]=%02x\n", cmd_fis[0], cmd_fis[1], cmd_fis[2]); goto out; break; } switch (cmd_fis[1]) { case SATA_FIS_REG_H2D_UPDATE_COMMAND_REGISTER: break; case 0: break; default: DPRINTF(port, "unknown command cmd_fis[0]=%02x cmd_fis[1]=%02x " "cmd_fis[2]=%02x\n", cmd_fis[0], cmd_fis[1], cmd_fis[2]); goto out; break; } switch (s->dev[port].port_state) { case STATE_RUN: if (cmd_fis[15] & ATA_SRST) { s->dev[port].port_state = STATE_RESET; } break; case STATE_RESET: if (!(cmd_fis[15] & ATA_SRST)) { ahci_reset_port(s, port); } break; } if (cmd_fis[1] == SATA_FIS_REG_H2D_UPDATE_COMMAND_REGISTER) { /* Check for NCQ command */ if ((cmd_fis[2] == READ_FPDMA_QUEUED) || (cmd_fis[2] == WRITE_FPDMA_QUEUED)) { process_ncq_command(s, port, cmd_fis, slot); goto out; } /* Decompose the FIS */ ide_state->nsector = (int64_t)((cmd_fis[13] << 8) | cmd_fis[12]); ide_state->feature = cmd_fis[3]; if (!ide_state->nsector) { ide_state->nsector = 256; } if (ide_state->drive_kind != IDE_CD) { /* * We set the sector depending on the sector defined in the FIS. * Unfortunately, the spec isn't exactly obvious on this one. * * Apparently LBA48 commands set fis bytes 10,9,8,6,5,4 to the * 48 bit sector number. ATA_CMD_READ_DMA_EXT is an example for * such a command. * * Non-LBA48 commands however use 7[lower 4 bits],6,5,4 to define a * 28-bit sector number. ATA_CMD_READ_DMA is an example for such * a command. * * Since the spec doesn't explicitly state what each field should * do, I simply assume non-used fields as reserved and OR everything * together, independent of the command. */ ide_set_sector(ide_state, ((uint64_t)cmd_fis[10] << 40) | ((uint64_t)cmd_fis[9] << 32) /* This is used for LBA48 commands */ | ((uint64_t)cmd_fis[8] << 24) /* This is used for non-LBA48 commands */ | ((uint64_t)(cmd_fis[7] & 0xf) << 24) | ((uint64_t)cmd_fis[6] << 16) | ((uint64_t)cmd_fis[5] << 8) | cmd_fis[4]); } /* Copy the ACMD field (ATAPI packet, if any) from the AHCI command * table to ide_state->io_buffer */ if (opts & AHCI_CMD_ATAPI) { memcpy(ide_state->io_buffer, &cmd_fis[AHCI_COMMAND_TABLE_ACMD], 0x10); ide_state->lcyl = 0x14; ide_state->hcyl = 0xeb; debug_print_fis(ide_state->io_buffer, 0x10); ide_state->feature = IDE_FEATURE_DMA; s->dev[port].done_atapi_packet = false; /* XXX send PIO setup FIS */ } ide_state->error = 0; /* Reset transferred byte counter */ cmd->status = 0; /* We're ready to process the command in FIS byte 2. */ ide_exec_cmd(&s->dev[port].port, cmd_fis[2]); if ((s->dev[port].port.ifs[0].status & (READY_STAT|DRQ_STAT|BUSY_STAT)) == READY_STAT) { ahci_write_fis_d2h(&s->dev[port], cmd_fis); } } out: dma_memory_unmap(s->as, cmd_fis, cmd_len, DMA_DIRECTION_FROM_DEVICE, cmd_len); if (s->dev[port].port.ifs[0].status & (BUSY_STAT|DRQ_STAT)) { /* async command, complete later */ s->dev[port].busy_slot = slot; return -1; } /* done handling the command */ return 0; }
static int handle_cmd(AHCIState *s, int port, int slot) { IDEState *ide_state; uint32_t opts; uint64_t tbl_addr; AHCICmdHdr *cmd; uint8_t *cmd_fis; dma_addr_t cmd_len; if (s->dev[port].port.ifs[0].status & (BUSY_STAT|DRQ_STAT)) { /* Engine currently busy, try again later */ DPRINTF(port, "engine busy\n"); return -1; } cmd = &((AHCICmdHdr *)s->dev[port].lst)[slot]; if (!s->dev[port].lst) { DPRINTF(port, "error: lst not given but cmd handled"); return -1; } /* remember current slot handle for later */ s->dev[port].cur_cmd = cmd; opts = le32_to_cpu(cmd->opts); tbl_addr = le64_to_cpu(cmd->tbl_addr); cmd_len = 0x80; cmd_fis = dma_memory_map(s->as, tbl_addr, &cmd_len, DMA_DIRECTION_FROM_DEVICE); if (!cmd_fis) { DPRINTF(port, "error: guest passed us an invalid cmd fis\n"); return -1; } /* The device we are working for */ ide_state = &s->dev[port].port.ifs[0]; if (!ide_state->bs) { DPRINTF(port, "error: guest accessed unused port"); goto out; } debug_print_fis(cmd_fis, 0x90); switch (cmd_fis[0]) { case SATA_FIS_TYPE_REGISTER_H2D: break; default: DPRINTF(port, "unknown command cmd_fis[0]=%02x cmd_fis[1]=%02x " "cmd_fis[2]=%02x\n", cmd_fis[0], cmd_fis[1], cmd_fis[2]); goto out; break; } switch (cmd_fis[1]) { case SATA_FIS_REG_H2D_UPDATE_COMMAND_REGISTER: break; case 0: break; default: DPRINTF(port, "unknown command cmd_fis[0]=%02x cmd_fis[1]=%02x " "cmd_fis[2]=%02x\n", cmd_fis[0], cmd_fis[1], cmd_fis[2]); goto out; break; } switch (s->dev[port].port_state) { case STATE_RUN: if (cmd_fis[15] & ATA_SRST) { s->dev[port].port_state = STATE_RESET; } break; case STATE_RESET: if (!(cmd_fis[15] & ATA_SRST)) { ahci_reset_port(s, port); } break; } if (cmd_fis[1] == SATA_FIS_REG_H2D_UPDATE_COMMAND_REGISTER) { /* Check for NCQ command */ if ((cmd_fis[2] == READ_FPDMA_QUEUED) || (cmd_fis[2] == WRITE_FPDMA_QUEUED)) { process_ncq_command(s, port, cmd_fis, slot); goto out; } /* Decompose the FIS */ ide_state->nsector = (int64_t)((cmd_fis[13] << 8) | cmd_fis[12]); ide_state->feature = cmd_fis[3]; if (!ide_state->nsector) { ide_state->nsector = 256; } if (ide_state->drive_kind != IDE_CD) { /* * We set the sector depending on the sector defined in the FIS. * Unfortunately, the spec isn't exactly obvious on this one. * * Apparently LBA48 commands set fis bytes 10,9,8,6,5,4 to the * 48 bit sector number. ATA_CMD_READ_DMA_EXT is an example for * such a command. * * Non-LBA48 commands however use 7[lower 4 bits],6,5,4 to define a * 28-bit sector number. ATA_CMD_READ_DMA is an example for such * a command. * * Since the spec doesn't explicitly state what each field should * do, I simply assume non-used fields as reserved and OR everything * together, independent of the command. */ ide_set_sector(ide_state, ((uint64_t)cmd_fis[10] << 40) | ((uint64_t)cmd_fis[9] << 32) /* This is used for LBA48 commands */ | ((uint64_t)cmd_fis[8] << 24) /* This is used for non-LBA48 commands */ | ((uint64_t)(cmd_fis[7] & 0xf) << 24) | ((uint64_t)cmd_fis[6] << 16) | ((uint64_t)cmd_fis[5] << 8) | cmd_fis[4]); } /* Copy the ACMD field (ATAPI packet, if any) from the AHCI command * table to ide_state->io_buffer */ if (opts & AHCI_CMD_ATAPI) { memcpy(ide_state->io_buffer, &cmd_fis[AHCI_COMMAND_TABLE_ACMD], 0x10); ide_state->lcyl = 0x14; ide_state->hcyl = 0xeb; debug_print_fis(ide_state->io_buffer, 0x10); ide_state->feature = IDE_FEATURE_DMA; s->dev[port].done_atapi_packet = false; /* XXX send PIO setup FIS */ } ide_state->error = 0; /* Reset transferred byte counter */ cmd->status = 0; /* We're ready to process the command in FIS byte 2. */ ide_exec_cmd(&s->dev[port].port, cmd_fis[2]); if ((s->dev[port].port.ifs[0].status & (READY_STAT|DRQ_STAT|BUSY_STAT)) == READY_STAT) { ahci_write_fis_d2h(&s->dev[port], cmd_fis); } } out: dma_memory_unmap(s->as, cmd_fis, cmd_len, DMA_DIRECTION_FROM_DEVICE, cmd_len); if (s->dev[port].port.ifs[0].status & (BUSY_STAT|DRQ_STAT)) { /* async command, complete later */ s->dev[port].busy_slot = slot; return -1; } /* done handling the command */ return 0; }
C
qemu
0
CVE-2018-16425
https://www.cvedetails.com/cve/CVE-2018-16425/
CWE-415
https://github.com/OpenSC/OpenSC/commit/360e95d45ac4123255a4c796db96337f332160ad#diff-d643a0fa169471dbf2912f4866dc49c5
360e95d45ac4123255a4c796db96337f332160ad#diff-d643a0fa169471dbf2912f4866dc49c5
fixed out of bounds writes Thanks to Eric Sesterhenn from X41 D-SEC GmbH for reporting the problems.
int sc_pkcs15emu_sc_hsm_get_curve(struct ec_curve **curve, u8 *oid, size_t oidlen) { int i; for (i = 0; curves[i].oid.value; i++) { if ((curves[i].oid.len == oidlen) && !memcmp(curves[i].oid.value, oid, oidlen)) { *curve = &curves[i]; return SC_SUCCESS; } } return SC_ERROR_INVALID_DATA; }
int sc_pkcs15emu_sc_hsm_get_curve(struct ec_curve **curve, u8 *oid, size_t oidlen) { int i; for (i = 0; curves[i].oid.value; i++) { if ((curves[i].oid.len == oidlen) && !memcmp(curves[i].oid.value, oid, oidlen)) { *curve = &curves[i]; return SC_SUCCESS; } } return SC_ERROR_INVALID_DATA; }
C
OpenSC
0
CVE-2014-9903
https://www.cvedetails.com/cve/CVE-2014-9903/
CWE-200
https://github.com/torvalds/linux/commit/4efbc454ba68def5ef285b26ebfcfdb605b52755
4efbc454ba68def5ef285b26ebfcfdb605b52755
sched: Fix information leak in sys_sched_getattr() We're copying the on-stack structure to userspace, but forgot to give the right number of bytes to copy. This allows the calling process to obtain up to PAGE_SIZE bytes from the stack (and possibly adjacent kernel memory). This fix copies only as much as we actually have on the stack (attr->size defaults to the size of the struct) and leaves the rest of the userspace-provided buffer untouched. Found using kmemcheck + trinity. Fixes: d50dde5a10f30 ("sched: Add new scheduler syscalls to support an extended scheduling parameters ABI") Cc: Dario Faggioli <[email protected]> Cc: Juri Lelli <[email protected]> Cc: Ingo Molnar <[email protected]> Signed-off-by: Vegard Nossum <[email protected]> Signed-off-by: Peter Zijlstra <[email protected]> Link: http://lkml.kernel.org/r/[email protected] Signed-off-by: Thomas Gleixner <[email protected]>
static inline void check_class_changed(struct rq *rq, struct task_struct *p, const struct sched_class *prev_class, int oldprio) { if (prev_class != p->sched_class) { if (prev_class->switched_from) prev_class->switched_from(rq, p); p->sched_class->switched_to(rq, p); } else if (oldprio != p->prio || dl_task(p)) p->sched_class->prio_changed(rq, p, oldprio); }
static inline void check_class_changed(struct rq *rq, struct task_struct *p, const struct sched_class *prev_class, int oldprio) { if (prev_class != p->sched_class) { if (prev_class->switched_from) prev_class->switched_from(rq, p); p->sched_class->switched_to(rq, p); } else if (oldprio != p->prio || dl_task(p)) p->sched_class->prio_changed(rq, p, oldprio); }
C
linux
0
CVE-2019-6978
https://www.cvedetails.com/cve/CVE-2019-6978/
CWE-415
https://github.com/php/php-src/commit/089f7c0bc28d399b0420aa6ef058e4c1c120b2ae
089f7c0bc28d399b0420aa6ef058e4c1c120b2ae
Sync with upstream Even though libgd/libgd#492 is not a relevant bug fix for PHP, since the binding doesn't use the `gdImage*Ptr()` functions at all, we're porting the fix to stay in sync here.
void * gdImageGifPtr (gdImagePtr im, int *size) { void *rv; gdIOCtx *out = gdNewDynamicCtx (2048, NULL); if (!_gdImageGifCtx(im, out)) { rv = gdDPExtractData(out, size); } else { rv = NULL; } out->gd_free (out); return rv; }
void * gdImageGifPtr (gdImagePtr im, int *size) { void *rv; gdIOCtx *out = gdNewDynamicCtx (2048, NULL); gdImageGifCtx (im, out); rv = gdDPExtractData (out, size); out->gd_free (out); return rv; }
C
php-src
1
CVE-2019-15296
https://www.cvedetails.com/cve/CVE-2019-15296/
CWE-119
https://github.com/knik0/faad2/commit/942c3e0aee748ea6fe97cb2c1aa5893225316174
942c3e0aee748ea6fe97cb2c1aa5893225316174
Fix a couple buffer overflows https://hackerone.com/reports/502816 https://hackerone.com/reports/507858 https://github.com/videolan/vlc/blob/master/contrib/src/faad2/faad2-fix-overflows.patch
static uint32_t latmParsePayload(latm_header *latm, bitfile *ld) { uint32_t framelen; uint8_t tmp; framelen = 0; if(latm->framelen_type==0) { do { tmp = (uint8_t)faad_getbits(ld, 8); framelen += tmp; } while(tmp==0xff); } else if(latm->framelen_type==1) framelen=latm->frameLength; return framelen; }
static uint32_t latmParsePayload(latm_header *latm, bitfile *ld) { uint32_t framelen; uint8_t tmp; framelen = 0; if(latm->framelen_type==0) { do { tmp = (uint8_t)faad_getbits(ld, 8); framelen += tmp; } while(tmp==0xff); } else if(latm->framelen_type==1) framelen=latm->frameLength; return framelen; }
C
faad2
0
CVE-2018-13093
https://www.cvedetails.com/cve/CVE-2018-13093/
CWE-476
https://github.com/torvalds/linux/commit/afca6c5b2595fc44383919fba740c194b0b76aff
afca6c5b2595fc44383919fba740c194b0b76aff
xfs: validate cached inodes are free when allocated A recent fuzzed filesystem image cached random dcache corruption when the reproducer was run. This often showed up as panics in lookup_slow() on a null inode->i_ops pointer when doing pathwalks. BUG: unable to handle kernel NULL pointer dereference at 0000000000000000 .... Call Trace: lookup_slow+0x44/0x60 walk_component+0x3dd/0x9f0 link_path_walk+0x4a7/0x830 path_lookupat+0xc1/0x470 filename_lookup+0x129/0x270 user_path_at_empty+0x36/0x40 path_listxattr+0x98/0x110 SyS_listxattr+0x13/0x20 do_syscall_64+0xf5/0x280 entry_SYSCALL_64_after_hwframe+0x42/0xb7 but had many different failure modes including deadlocks trying to lock the inode that was just allocated or KASAN reports of use-after-free violations. The cause of the problem was a corrupt INOBT on a v4 fs where the root inode was marked as free in the inobt record. Hence when we allocated an inode, it chose the root inode to allocate, found it in the cache and re-initialised it. We recently fixed a similar inode allocation issue caused by inobt record corruption problem in xfs_iget_cache_miss() in commit ee457001ed6c ("xfs: catch inode allocation state mismatch corruption"). This change adds similar checks to the cache-hit path to catch it, and turns the reproducer into a corruption shutdown situation. Reported-by: Wen Xu <[email protected]> Signed-Off-By: Dave Chinner <[email protected]> Reviewed-by: Christoph Hellwig <[email protected]> Reviewed-by: Carlos Maiolino <[email protected]> Reviewed-by: Darrick J. Wong <[email protected]> [darrick: fix typos in comment] Signed-off-by: Darrick J. Wong <[email protected]>
xfs_iget( xfs_mount_t *mp, xfs_trans_t *tp, xfs_ino_t ino, uint flags, uint lock_flags, xfs_inode_t **ipp) { xfs_inode_t *ip; int error; xfs_perag_t *pag; xfs_agino_t agino; /* * xfs_reclaim_inode() uses the ILOCK to ensure an inode * doesn't get freed while it's being referenced during a * radix tree traversal here. It assumes this function * aqcuires only the ILOCK (and therefore it has no need to * involve the IOLOCK in this synchronization). */ ASSERT((lock_flags & (XFS_IOLOCK_EXCL | XFS_IOLOCK_SHARED)) == 0); /* reject inode numbers outside existing AGs */ if (!ino || XFS_INO_TO_AGNO(mp, ino) >= mp->m_sb.sb_agcount) return -EINVAL; XFS_STATS_INC(mp, xs_ig_attempts); /* get the perag structure and ensure that it's inode capable */ pag = xfs_perag_get(mp, XFS_INO_TO_AGNO(mp, ino)); agino = XFS_INO_TO_AGINO(mp, ino); again: error = 0; rcu_read_lock(); ip = radix_tree_lookup(&pag->pag_ici_root, agino); if (ip) { error = xfs_iget_cache_hit(pag, ip, ino, flags, lock_flags); if (error) goto out_error_or_again; } else { rcu_read_unlock(); if (flags & XFS_IGET_INCORE) { error = -ENODATA; goto out_error_or_again; } XFS_STATS_INC(mp, xs_ig_missed); error = xfs_iget_cache_miss(mp, pag, tp, ino, &ip, flags, lock_flags); if (error) goto out_error_or_again; } xfs_perag_put(pag); *ipp = ip; /* * If we have a real type for an on-disk inode, we can setup the inode * now. If it's a new inode being created, xfs_ialloc will handle it. */ if (xfs_iflags_test(ip, XFS_INEW) && VFS_I(ip)->i_mode != 0) xfs_setup_existing_inode(ip); return 0; out_error_or_again: if (!(flags & XFS_IGET_INCORE) && error == -EAGAIN) { delay(1); goto again; } xfs_perag_put(pag); return error; }
xfs_iget( xfs_mount_t *mp, xfs_trans_t *tp, xfs_ino_t ino, uint flags, uint lock_flags, xfs_inode_t **ipp) { xfs_inode_t *ip; int error; xfs_perag_t *pag; xfs_agino_t agino; /* * xfs_reclaim_inode() uses the ILOCK to ensure an inode * doesn't get freed while it's being referenced during a * radix tree traversal here. It assumes this function * aqcuires only the ILOCK (and therefore it has no need to * involve the IOLOCK in this synchronization). */ ASSERT((lock_flags & (XFS_IOLOCK_EXCL | XFS_IOLOCK_SHARED)) == 0); /* reject inode numbers outside existing AGs */ if (!ino || XFS_INO_TO_AGNO(mp, ino) >= mp->m_sb.sb_agcount) return -EINVAL; XFS_STATS_INC(mp, xs_ig_attempts); /* get the perag structure and ensure that it's inode capable */ pag = xfs_perag_get(mp, XFS_INO_TO_AGNO(mp, ino)); agino = XFS_INO_TO_AGINO(mp, ino); again: error = 0; rcu_read_lock(); ip = radix_tree_lookup(&pag->pag_ici_root, agino); if (ip) { error = xfs_iget_cache_hit(pag, ip, ino, flags, lock_flags); if (error) goto out_error_or_again; } else { rcu_read_unlock(); if (flags & XFS_IGET_INCORE) { error = -ENODATA; goto out_error_or_again; } XFS_STATS_INC(mp, xs_ig_missed); error = xfs_iget_cache_miss(mp, pag, tp, ino, &ip, flags, lock_flags); if (error) goto out_error_or_again; } xfs_perag_put(pag); *ipp = ip; /* * If we have a real type for an on-disk inode, we can setup the inode * now. If it's a new inode being created, xfs_ialloc will handle it. */ if (xfs_iflags_test(ip, XFS_INEW) && VFS_I(ip)->i_mode != 0) xfs_setup_existing_inode(ip); return 0; out_error_or_again: if (!(flags & XFS_IGET_INCORE) && error == -EAGAIN) { delay(1); goto again; } xfs_perag_put(pag); return error; }
C
linux
0
CVE-2014-3200
https://www.cvedetails.com/cve/CVE-2014-3200/
null
https://github.com/chromium/chromium/commit/c0947dabeaa10da67798c1bbc668dca4b280cad5
c0947dabeaa10da67798c1bbc668dca4b280cad5
[Contextual Search] Change "Now on Tap" to "Contextual Cards" BUG=644934 Review-Url: https://codereview.chromium.org/2361163003 Cr-Commit-Position: refs/heads/master@{#420899}
std::string ContextualSearchDelegate::BuildRequestUrl(std::string selection) { if (!template_url_service_ || !template_url_service_->GetDefaultSearchProvider()) { return std::string(); } std::string selected_text(net::EscapeQueryParamValue(selection, true)); TemplateURL* template_url = template_url_service_->GetDefaultSearchProvider(); TemplateURLRef::SearchTermsArgs search_terms_args = TemplateURLRef::SearchTermsArgs(base::string16()); int contextual_cards_version = field_trial_->IsContextualCardsBarIntegrationEnabled() ? kContextualCardsVersion : 0; TemplateURLRef::SearchTermsArgs::ContextualSearchParams params( kContextualSearchRequestVersion, selected_text, std::string(), contextual_cards_version); search_terms_args.contextual_search_params = params; std::string request( template_url->contextual_search_url_ref().ReplaceSearchTerms( search_terms_args, template_url_service_->search_terms_data(), NULL)); std::string replacement_url = field_trial_->GetResolverURLPrefix(); if (!replacement_url.empty()) { size_t pos = request.find(kContextualSearchServerEndpoint); if (pos != std::string::npos) { request.replace(0, pos + strlen(kContextualSearchServerEndpoint), replacement_url); } } return request; }
std::string ContextualSearchDelegate::BuildRequestUrl(std::string selection) { if (!template_url_service_ || !template_url_service_->GetDefaultSearchProvider()) { return std::string(); } std::string selected_text(net::EscapeQueryParamValue(selection, true)); TemplateURL* template_url = template_url_service_->GetDefaultSearchProvider(); TemplateURLRef::SearchTermsArgs search_terms_args = TemplateURLRef::SearchTermsArgs(base::string16()); int now_on_tap_version = field_trial_->IsNowOnTapBarIntegrationEnabled() ? kNowOnTapVersion : 0; TemplateURLRef::SearchTermsArgs::ContextualSearchParams params( kContextualSearchRequestVersion, selected_text, std::string(), now_on_tap_version); search_terms_args.contextual_search_params = params; std::string request( template_url->contextual_search_url_ref().ReplaceSearchTerms( search_terms_args, template_url_service_->search_terms_data(), NULL)); std::string replacement_url = field_trial_->GetResolverURLPrefix(); if (!replacement_url.empty()) { size_t pos = request.find(kContextualSearchServerEndpoint); if (pos != std::string::npos) { request.replace(0, pos + strlen(kContextualSearchServerEndpoint), replacement_url); } } return request; }
C
Chrome
1
CVE-2018-18350
https://www.cvedetails.com/cve/CVE-2018-18350/
null
https://github.com/chromium/chromium/commit/d683fb12566eaec180ee0e0506288f46cc7a43e7
d683fb12566eaec180ee0e0506288f46cc7a43e7
Inherit CSP when self-navigating to local-scheme URL As the linked bug example shows, we should inherit CSP when we navigate to a local-scheme URL (even if we are in a main browsing context). Bug: 799747 Change-Id: I8413aa8e8049461ebcf0ffbf7b04c41d1340af02 Reviewed-on: https://chromium-review.googlesource.com/c/1234337 Reviewed-by: Mike West <[email protected]> Commit-Queue: Andy Paicu <[email protected]> Cr-Commit-Position: refs/heads/master@{#597889}
bool DocumentInit::ShouldSetURL() const { DocumentLoader* loader = MasterDocumentLoader(); return (loader && loader->GetFrame()->Tree().Parent()) || !url_.IsEmpty(); }
bool DocumentInit::ShouldSetURL() const { DocumentLoader* loader = MasterDocumentLoader(); return (loader && loader->GetFrame()->Tree().Parent()) || !url_.IsEmpty(); }
C
Chrome
0
CVE-2017-14041
https://www.cvedetails.com/cve/CVE-2017-14041/
CWE-787
https://github.com/uclouvain/openjpeg/commit/e5285319229a5d77bf316bb0d3a6cbd3cb8666d9
e5285319229a5d77bf316bb0d3a6cbd3cb8666d9
pgxtoimage(): fix write stack buffer overflow (#997)
opj_image_t* rawltoimage(const char *filename, opj_cparameters_t *parameters, raw_cparameters_t *raw_cp) { return rawtoimage_common(filename, parameters, raw_cp, OPJ_FALSE); }
opj_image_t* rawltoimage(const char *filename, opj_cparameters_t *parameters, raw_cparameters_t *raw_cp) { return rawtoimage_common(filename, parameters, raw_cp, OPJ_FALSE); }
C
openjpeg
0
CVE-2017-5120
https://www.cvedetails.com/cve/CVE-2017-5120/
null
https://github.com/chromium/chromium/commit/b7277af490d28ac7f802c015bb0ff31395768556
b7277af490d28ac7f802c015bb0ff31395768556
bindings: Support "attribute FrozenArray<T>?" Adds a quick hack to support a case of "attribute FrozenArray<T>?". Bug: 1028047 Change-Id: Ib3cecc4beb6bcc0fb0dbc667aca595454cc90c86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933866 Reviewed-by: Hitoshi Yoshida <[email protected]> Commit-Queue: Yuki Shiino <[email protected]> Cr-Commit-Position: refs/heads/master@{#718676}
void V8TestObject::ByteAttributeAttributeSetterCallback( const v8::FunctionCallbackInfo<v8::Value>& info) { RUNTIME_CALL_TIMER_SCOPE_DISABLED_BY_DEFAULT(info.GetIsolate(), "Blink_TestObject_byteAttribute_Setter"); v8::Local<v8::Value> v8_value = info[0]; test_object_v8_internal::ByteAttributeAttributeSetter(v8_value, info); }
void V8TestObject::ByteAttributeAttributeSetterCallback( const v8::FunctionCallbackInfo<v8::Value>& info) { RUNTIME_CALL_TIMER_SCOPE_DISABLED_BY_DEFAULT(info.GetIsolate(), "Blink_TestObject_byteAttribute_Setter"); v8::Local<v8::Value> v8_value = info[0]; test_object_v8_internal::ByteAttributeAttributeSetter(v8_value, info); }
C
Chrome
0
CVE-2014-1713
https://www.cvedetails.com/cve/CVE-2014-1713/
CWE-399
https://github.com/chromium/chromium/commit/f85a87ec670ad0fce9d98d90c9a705b72a288154
f85a87ec670ad0fce9d98d90c9a705b72a288154
document.location bindings fix BUG=352374 [email protected] Review URL: https://codereview.chromium.org/196343011 git-svn-id: svn://svn.chromium.org/blink/trunk@169176 bbb929c8-8fbe-4397-9dbb-9b2b20218538
static void byteAttributeAttributeSetter(v8::Local<v8::Value> jsValue, const v8::PropertyCallbackInfo<void>& info) { ExceptionState exceptionState(ExceptionState::SetterContext, "byteAttribute", "TestObjectPython", info.Holder(), info.GetIsolate()); TestObjectPython* imp = V8TestObjectPython::toNative(info.Holder()); V8TRYCATCH_EXCEPTION_VOID(int, cppValue, toInt8(jsValue, exceptionState), exceptionState); imp->setByteAttribute(cppValue); }
static void byteAttributeAttributeSetter(v8::Local<v8::Value> jsValue, const v8::PropertyCallbackInfo<void>& info) { ExceptionState exceptionState(ExceptionState::SetterContext, "byteAttribute", "TestObjectPython", info.Holder(), info.GetIsolate()); TestObjectPython* imp = V8TestObjectPython::toNative(info.Holder()); V8TRYCATCH_EXCEPTION_VOID(int, cppValue, toInt8(jsValue, exceptionState), exceptionState); imp->setByteAttribute(cppValue); }
C
Chrome
0
CVE-2015-6766
https://www.cvedetails.com/cve/CVE-2015-6766/
null
https://github.com/chromium/chromium/commit/2cb006bc9d3ad16353ed49c2b75faea618156d0f
2cb006bc9d3ad16353ed49c2b75faea618156d0f
Fix possible map::end() dereference in AppCacheUpdateJob triggered by a compromised renderer. BUG=551044 Review URL: https://codereview.chromium.org/1418783005 Cr-Commit-Position: refs/heads/master@{#358815}
void AppCacheHost::OnCacheLoaded(AppCache* cache, int64 cache_id) { if (cache_id == pending_main_resource_cache_id_) { pending_main_resource_cache_id_ = kAppCacheNoCacheId; main_resource_cache_ = cache; } else if (cache_id == pending_selected_cache_id_) { pending_selected_cache_id_ = kAppCacheNoCacheId; FinishCacheSelection(cache, NULL); } }
void AppCacheHost::OnCacheLoaded(AppCache* cache, int64 cache_id) { if (cache_id == pending_main_resource_cache_id_) { pending_main_resource_cache_id_ = kAppCacheNoCacheId; main_resource_cache_ = cache; } else if (cache_id == pending_selected_cache_id_) { pending_selected_cache_id_ = kAppCacheNoCacheId; FinishCacheSelection(cache, NULL); } }
C
Chrome
0
CVE-2018-17468
https://www.cvedetails.com/cve/CVE-2018-17468/
CWE-200
https://github.com/chromium/chromium/commit/5fe74f831fddb92afa5ddfe46490bb49f083132b
5fe74f831fddb92afa5ddfe46490bb49f083132b
Do not forward resource timing to parent frame after back-forward navigation LocalFrame has |should_send_resource_timing_info_to_parent_| flag not to send timing info to parent except for the first navigation. This flag is cleared when the first timing is sent to parent, however this does not happen if iframe's first navigation was by back-forward navigation. For such iframes, we shouldn't send timings to parent at all. Bug: 876822 Change-Id: I128b51a82ef278c439548afc8283ae63abdef5c5 Reviewed-on: https://chromium-review.googlesource.com/1186215 Reviewed-by: Kinuko Yasuda <[email protected]> Commit-Queue: Kunihiko Sakamoto <[email protected]> Cr-Commit-Position: refs/heads/master@{#585736}
void WebLocalFrameImpl::ReloadImage(const WebNode& web_node) { const Node* node = web_node.ConstUnwrap<Node>(); if (auto* image_element = ToHTMLImageElementOrNull(*node)) image_element->ForceReload(); }
void WebLocalFrameImpl::ReloadImage(const WebNode& web_node) { const Node* node = web_node.ConstUnwrap<Node>(); if (auto* image_element = ToHTMLImageElementOrNull(*node)) image_element->ForceReload(); }
C
Chrome
0
CVE-2017-9059
https://www.cvedetails.com/cve/CVE-2017-9059/
CWE-404
https://github.com/torvalds/linux/commit/c70422f760c120480fee4de6c38804c72aa26bc1
c70422f760c120480fee4de6c38804c72aa26bc1
Merge tag 'nfsd-4.12' of git://linux-nfs.org/~bfields/linux Pull nfsd updates from Bruce Fields: "Another RDMA update from Chuck Lever, and a bunch of miscellaneous bugfixes" * tag 'nfsd-4.12' of git://linux-nfs.org/~bfields/linux: (26 commits) nfsd: Fix up the "supattr_exclcreat" attributes nfsd: encoders mustn't use unitialized values in error cases nfsd: fix undefined behavior in nfsd4_layout_verify lockd: fix lockd shutdown race NFSv4: Fix callback server shutdown SUNRPC: Refactor svc_set_num_threads() NFSv4.x/callback: Create the callback service through svc_create_pooled lockd: remove redundant check on block svcrdma: Clean out old XDR encoders svcrdma: Remove the req_map cache svcrdma: Remove unused RDMA Write completion handler svcrdma: Reduce size of sge array in struct svc_rdma_op_ctxt svcrdma: Clean up RPC-over-RDMA backchannel reply processing svcrdma: Report Write/Reply chunk overruns svcrdma: Clean up RDMA_ERROR path svcrdma: Use rdma_rw API in RPC reply path svcrdma: Introduce local rdma_rw API helpers svcrdma: Clean up svc_rdma_get_inv_rkey() svcrdma: Add helper to save pages under I/O svcrdma: Eliminate RPCRDMA_SQ_DEPTH_MULT ...
static void handle_connect_req(struct rdma_cm_id *new_cma_id, struct rdma_conn_param *param) { struct svcxprt_rdma *listen_xprt = new_cma_id->context; struct svcxprt_rdma *newxprt; struct sockaddr *sa; /* Create a new transport */ newxprt = rdma_create_xprt(listen_xprt->sc_xprt.xpt_server, 0); if (!newxprt) { dprintk("svcrdma: failed to create new transport\n"); return; } newxprt->sc_cm_id = new_cma_id; new_cma_id->context = newxprt; dprintk("svcrdma: Creating newxprt=%p, cm_id=%p, listenxprt=%p\n", newxprt, newxprt->sc_cm_id, listen_xprt); svc_rdma_parse_connect_private(newxprt, param); /* Save client advertised inbound read limit for use later in accept. */ newxprt->sc_ord = param->initiator_depth; /* Set the local and remote addresses in the transport */ sa = (struct sockaddr *)&newxprt->sc_cm_id->route.addr.dst_addr; svc_xprt_set_remote(&newxprt->sc_xprt, sa, svc_addr_len(sa)); sa = (struct sockaddr *)&newxprt->sc_cm_id->route.addr.src_addr; svc_xprt_set_local(&newxprt->sc_xprt, sa, svc_addr_len(sa)); /* * Enqueue the new transport on the accept queue of the listening * transport */ spin_lock_bh(&listen_xprt->sc_lock); list_add_tail(&newxprt->sc_accept_q, &listen_xprt->sc_accept_q); spin_unlock_bh(&listen_xprt->sc_lock); set_bit(XPT_CONN, &listen_xprt->sc_xprt.xpt_flags); svc_xprt_enqueue(&listen_xprt->sc_xprt); }
static void handle_connect_req(struct rdma_cm_id *new_cma_id, struct rdma_conn_param *param) { struct svcxprt_rdma *listen_xprt = new_cma_id->context; struct svcxprt_rdma *newxprt; struct sockaddr *sa; /* Create a new transport */ newxprt = rdma_create_xprt(listen_xprt->sc_xprt.xpt_server, 0); if (!newxprt) { dprintk("svcrdma: failed to create new transport\n"); return; } newxprt->sc_cm_id = new_cma_id; new_cma_id->context = newxprt; dprintk("svcrdma: Creating newxprt=%p, cm_id=%p, listenxprt=%p\n", newxprt, newxprt->sc_cm_id, listen_xprt); svc_rdma_parse_connect_private(newxprt, param); /* Save client advertised inbound read limit for use later in accept. */ newxprt->sc_ord = param->initiator_depth; /* Set the local and remote addresses in the transport */ sa = (struct sockaddr *)&newxprt->sc_cm_id->route.addr.dst_addr; svc_xprt_set_remote(&newxprt->sc_xprt, sa, svc_addr_len(sa)); sa = (struct sockaddr *)&newxprt->sc_cm_id->route.addr.src_addr; svc_xprt_set_local(&newxprt->sc_xprt, sa, svc_addr_len(sa)); /* * Enqueue the new transport on the accept queue of the listening * transport */ spin_lock_bh(&listen_xprt->sc_lock); list_add_tail(&newxprt->sc_accept_q, &listen_xprt->sc_accept_q); spin_unlock_bh(&listen_xprt->sc_lock); set_bit(XPT_CONN, &listen_xprt->sc_xprt.xpt_flags); svc_xprt_enqueue(&listen_xprt->sc_xprt); }
C
linux
0
CVE-2017-5061
https://www.cvedetails.com/cve/CVE-2017-5061/
CWE-362
https://github.com/chromium/chromium/commit/5d78b84d39bd34bc9fce9d01c0dcd5a22a330d34
5d78b84d39bd34bc9fce9d01c0dcd5a22a330d34
(Reland) Discard compositor frames from unloaded web content This is a reland of https://codereview.chromium.org/2707243005/ with a small change to fix an uninitialized memory error that fails on MSAN bots. BUG=672847 [email protected], [email protected] CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2731283003 Cr-Commit-Position: refs/heads/master@{#454954}
int LayerTreeHostImpl::RequestedMSAASampleCount() const { if (settings_.gpu_rasterization_msaa_sample_count == -1) { float device_scale_factor = pending_tree_ ? pending_tree_->device_scale_factor() : active_tree_->device_scale_factor(); return device_scale_factor >= 2.0f ? 4 : 8; } return settings_.gpu_rasterization_msaa_sample_count; }
int LayerTreeHostImpl::RequestedMSAASampleCount() const { if (settings_.gpu_rasterization_msaa_sample_count == -1) { float device_scale_factor = pending_tree_ ? pending_tree_->device_scale_factor() : active_tree_->device_scale_factor(); return device_scale_factor >= 2.0f ? 4 : 8; } return settings_.gpu_rasterization_msaa_sample_count; }
C
Chrome
0
CVE-2018-11376
https://www.cvedetails.com/cve/CVE-2018-11376/
CWE-125
https://github.com/radare/radare2/commit/1f37c04f2a762500222dda2459e6a04646feeedf
1f37c04f2a762500222dda2459e6a04646feeedf
Fix #9904 - crash in r2_hoobr_r_read_le32 (over 9000 entrypoints) and read_le oobread (#9923)
static ut8 bin_reloc_size(RBinReloc *reloc) { #define CASE(T) case R_BIN_RELOC_ ## T: return T / 8 switch (reloc->type) { CASE(8); CASE(16); CASE(32); CASE(64); } return 0; #undef CASE }
static ut8 bin_reloc_size(RBinReloc *reloc) { #define CASE(T) case R_BIN_RELOC_ ## T: return T / 8 switch (reloc->type) { CASE(8); CASE(16); CASE(32); CASE(64); } return 0; #undef CASE }
C
radare2
0
CVE-2012-2833
https://www.cvedetails.com/cve/CVE-2012-2833/
CWE-119
https://github.com/chromium/chromium/commit/1595f66a8dec04864afd048809cd9d0802049feb
1595f66a8dec04864afd048809cd9d0802049feb
[V8] ASSERT that removeAllDOMObjects() is called only on worker threads https://bugs.webkit.org/show_bug.cgi?id=100046 Reviewed by Eric Seidel. This function is called only on worker threads. We should ASSERT that fact and remove the dead code that tries to handle the main thread case. * bindings/v8/V8DOMMap.cpp: (WebCore::removeAllDOMObjects): git-svn-id: svn://svn.chromium.org/blink/trunk@132156 bbb929c8-8fbe-4397-9dbb-9b2b20218538
DOMWrapperMap<void>& getDOMObjectMap(v8::Isolate* isolate) { return DOMData::getCurrentStore(isolate).domObjectMap(); }
DOMWrapperMap<void>& getDOMObjectMap(v8::Isolate* isolate) { return DOMData::getCurrentStore(isolate).domObjectMap(); }
C
Chrome
0
CVE-2010-1635
https://www.cvedetails.com/cve/CVE-2010-1635/
null
https://git.samba.org/?p=samba.git;a=commit;h=25452a2268ac7013da28125f3df22085139af12d
25452a2268ac7013da28125f3df22085139af12d
null
bool open_was_deferred(uint16 mid) { struct pending_message_list *pml; for (pml = deferred_open_queue; pml; pml = pml->next) { if (SVAL(pml->buf.data,smb_mid) == mid && !pml->processed) { return True; } } return False; }
bool open_was_deferred(uint16 mid) { struct pending_message_list *pml; for (pml = deferred_open_queue; pml; pml = pml->next) { if (SVAL(pml->buf.data,smb_mid) == mid && !pml->processed) { return True; } } return False; }
C
samba
0
CVE-2018-16077
https://www.cvedetails.com/cve/CVE-2018-16077/
CWE-285
https://github.com/chromium/chromium/commit/90f878780cce9c4b0475fcea14d91b8f510cce11
90f878780cce9c4b0475fcea14d91b8f510cce11
Prevent sandboxed documents from reusing the default window Bug: 377995 Change-Id: Iff66c6d214dfd0cb7ea9c80f83afeedfff703541 Reviewed-on: https://chromium-review.googlesource.com/983558 Commit-Queue: Andy Paicu <[email protected]> Reviewed-by: Daniel Cheng <[email protected]> Cr-Commit-Position: refs/heads/master@{#567663}
void FrameLoader::CommitNavigation(const FrameLoadRequest& passed_request, WebFrameLoadType frame_load_type, HistoryItem* history_item) { CHECK(!passed_request.OriginDocument()); CHECK(passed_request.FrameName().IsEmpty()); CHECK(!passed_request.Form()); CHECK(passed_request.TriggeringEventInfo() == WebTriggeringEventInfo::kNotFromEvent); DCHECK(frame_->GetDocument()); DCHECK(!in_stop_all_loaders_); DCHECK(frame_->IsNavigationAllowed()); DCHECK_EQ(Document::kNoDismissal, frame_->GetDocument()->PageDismissalEventBeingDispatched()); if (HTMLFrameOwnerElement* element = frame_->DeprecatedLocalOwner()) element->CancelPendingLazyLoad(); FrameLoadRequest request(passed_request); request.GetResourceRequest().SetHasUserGesture( Frame::HasTransientUserActivation(frame_)); if (frame_load_type == WebFrameLoadType::kStandard) frame_load_type = DetermineFrameLoadType(request); StartLoad(request, frame_load_type, kNavigationPolicyCurrentTab, history_item, false /* check_with_client */); }
void FrameLoader::CommitNavigation(const FrameLoadRequest& passed_request, WebFrameLoadType frame_load_type, HistoryItem* history_item) { CHECK(!passed_request.OriginDocument()); CHECK(passed_request.FrameName().IsEmpty()); CHECK(!passed_request.Form()); CHECK(passed_request.TriggeringEventInfo() == WebTriggeringEventInfo::kNotFromEvent); DCHECK(frame_->GetDocument()); DCHECK(!in_stop_all_loaders_); DCHECK(frame_->IsNavigationAllowed()); DCHECK_EQ(Document::kNoDismissal, frame_->GetDocument()->PageDismissalEventBeingDispatched()); if (HTMLFrameOwnerElement* element = frame_->DeprecatedLocalOwner()) element->CancelPendingLazyLoad(); FrameLoadRequest request(passed_request); request.GetResourceRequest().SetHasUserGesture( Frame::HasTransientUserActivation(frame_)); if (frame_load_type == WebFrameLoadType::kStandard) frame_load_type = DetermineFrameLoadType(request); StartLoad(request, frame_load_type, kNavigationPolicyCurrentTab, history_item, false /* check_with_client */); }
C
Chrome
0
CVE-2017-5033
https://www.cvedetails.com/cve/CVE-2017-5033/
CWE-281
https://github.com/chromium/chromium/commit/14f2111f9cec919a450115ce4914f228effca58e
14f2111f9cec919a450115ce4914f228effca58e
Revert "Add explicit flag for compositor scrollbar injected gestures" This reverts commit d9a56afcbdf9850bc39bb3edb56d07d11a1eb2b2. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 669086 as the culprit for flakes in the build cycles as shown on: https://analysis.chromium.org/p/chromium/flake-portal/analysis/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vZDlhNTZhZmNiZGY5ODUwYmMzOWJiM2VkYjU2ZDA3ZDExYTFlYjJiMgw Sample Failed Build: https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-rel/25818 Sample Failed Step: content_browsertests on Ubuntu-16.04 Sample Flaky Test: ScrollLatencyScrollbarBrowserTest.ScrollbarThumbDragLatency Original change's description: > Add explicit flag for compositor scrollbar injected gestures > > The original change to enable scrollbar latency for the composited > scrollbars incorrectly used an existing member to try and determine > whether a GestureScrollUpdate was the first one in an injected sequence > or not. is_first_gesture_scroll_update_ was incorrect because it is only > updated when input is actually dispatched to InputHandlerProxy, and the > flag is cleared for all GSUs before the location where it was being > read. > > This bug was missed because of incorrect tests. The > VerifyRecordedSamplesForHistogram method doesn't actually assert or > expect anything - the return value must be inspected. > > As part of fixing up the tests, I made a few other changes to get them > passing consistently across all platforms: > - turn on main thread scrollbar injection feature (in case it's ever > turned off we don't want the tests to start failing) > - enable mock scrollbars > - disable smooth scrolling > - don't run scrollbar tests on Android > > The composited scrollbar button test is disabled due to a bug in how > the mock theme reports its button sizes, which throws off the region > detection in ScrollbarLayerImplBase::IdentifyScrollbarPart (filed > crbug.com/974063 for this issue). > > Change-Id: Ie1a762a5f6ecc264d22f0256db68f141fc76b950 > > Bug: 954007 > Change-Id: Ib258e08e083e79da90ba2e4e4216e4879cf00cf7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1652741 > Commit-Queue: Daniel Libby <[email protected]> > Reviewed-by: David Bokan <[email protected]> > Cr-Commit-Position: refs/heads/master@{#669086} Change-Id: Icc743e48fa740fe27f0cb0cfa21b209a696f518c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 954007 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660114 Cr-Commit-Position: refs/heads/master@{#669150}
cc::ScrollState CreateScrollStateForGesture(const WebGestureEvent& event) { cc::ScrollStateData scroll_state_data; switch (event.GetType()) { case WebInputEvent::kGestureScrollBegin: scroll_state_data.position_x = event.PositionInWidget().x; scroll_state_data.position_y = event.PositionInWidget().y; scroll_state_data.delta_x_hint = -event.data.scroll_begin.delta_x_hint; scroll_state_data.delta_y_hint = -event.data.scroll_begin.delta_y_hint; scroll_state_data.is_beginning = true; scroll_state_data.is_in_inertial_phase = (event.data.scroll_begin.inertial_phase == WebGestureEvent::InertialPhaseState::kMomentum); scroll_state_data.delta_granularity = static_cast<double>(event.data.scroll_begin.delta_hint_units); break; case WebInputEvent::kGestureScrollUpdate: scroll_state_data.delta_x = -event.data.scroll_update.delta_x; scroll_state_data.delta_y = -event.data.scroll_update.delta_y; scroll_state_data.velocity_x = event.data.scroll_update.velocity_x; scroll_state_data.velocity_y = event.data.scroll_update.velocity_y; scroll_state_data.is_in_inertial_phase = event.data.scroll_update.inertial_phase == WebGestureEvent::InertialPhaseState::kMomentum; scroll_state_data.delta_granularity = static_cast<double>(event.data.scroll_update.delta_units); break; case WebInputEvent::kGestureScrollEnd: scroll_state_data.is_ending = true; break; default: NOTREACHED(); break; } return cc::ScrollState(scroll_state_data); }
cc::ScrollState CreateScrollStateForGesture(const WebGestureEvent& event) { cc::ScrollStateData scroll_state_data; switch (event.GetType()) { case WebInputEvent::kGestureScrollBegin: scroll_state_data.position_x = event.PositionInWidget().x; scroll_state_data.position_y = event.PositionInWidget().y; scroll_state_data.delta_x_hint = -event.data.scroll_begin.delta_x_hint; scroll_state_data.delta_y_hint = -event.data.scroll_begin.delta_y_hint; scroll_state_data.is_beginning = true; scroll_state_data.is_in_inertial_phase = (event.data.scroll_begin.inertial_phase == WebGestureEvent::InertialPhaseState::kMomentum); scroll_state_data.delta_granularity = static_cast<double>(event.data.scroll_begin.delta_hint_units); break; case WebInputEvent::kGestureScrollUpdate: scroll_state_data.delta_x = -event.data.scroll_update.delta_x; scroll_state_data.delta_y = -event.data.scroll_update.delta_y; scroll_state_data.velocity_x = event.data.scroll_update.velocity_x; scroll_state_data.velocity_y = event.data.scroll_update.velocity_y; scroll_state_data.is_in_inertial_phase = event.data.scroll_update.inertial_phase == WebGestureEvent::InertialPhaseState::kMomentum; scroll_state_data.delta_granularity = static_cast<double>(event.data.scroll_update.delta_units); break; case WebInputEvent::kGestureScrollEnd: scroll_state_data.is_ending = true; break; default: NOTREACHED(); break; } return cc::ScrollState(scroll_state_data); }
C
Chrome
0
CVE-2016-10130
https://www.cvedetails.com/cve/CVE-2016-10130/
CWE-284
https://github.com/libgit2/libgit2/commit/9a64e62f0f20c9cf9b2e1609f037060eb2d8eb22
9a64e62f0f20c9cf9b2e1609f037060eb2d8eb22
http: check certificate validity before clobbering the error variable
static int http_stream_write_single( git_smart_subtransport_stream *stream, const char *buffer, size_t len) { http_stream *s = (http_stream *)stream; http_subtransport *t = OWNING_SUBTRANSPORT(s); git_buf request = GIT_BUF_INIT; assert(t->connected); if (s->sent_request) { giterr_set(GITERR_NET, "Subtransport configured for only one write"); return -1; } clear_parser_state(t); if (gen_request(&request, s, len) < 0) return -1; if (git_stream_write(t->io, request.ptr, request.size, 0) < 0) goto on_error; if (len && git_stream_write(t->io, buffer, len, 0) < 0) goto on_error; git_buf_free(&request); s->sent_request = 1; return 0; on_error: git_buf_free(&request); return -1; }
static int http_stream_write_single( git_smart_subtransport_stream *stream, const char *buffer, size_t len) { http_stream *s = (http_stream *)stream; http_subtransport *t = OWNING_SUBTRANSPORT(s); git_buf request = GIT_BUF_INIT; assert(t->connected); if (s->sent_request) { giterr_set(GITERR_NET, "Subtransport configured for only one write"); return -1; } clear_parser_state(t); if (gen_request(&request, s, len) < 0) return -1; if (git_stream_write(t->io, request.ptr, request.size, 0) < 0) goto on_error; if (len && git_stream_write(t->io, buffer, len, 0) < 0) goto on_error; git_buf_free(&request); s->sent_request = 1; return 0; on_error: git_buf_free(&request); return -1; }
C
libgit2
0
CVE-2013-1957
https://www.cvedetails.com/cve/CVE-2013-1957/
CWE-264
https://github.com/torvalds/linux/commit/132c94e31b8bca8ea921f9f96a57d684fa4ae0a9
132c94e31b8bca8ea921f9f96a57d684fa4ae0a9
vfs: Carefully propogate mounts across user namespaces As a matter of policy MNT_READONLY should not be changable if the original mounter had more privileges than creator of the mount namespace. Add the flag CL_UNPRIVILEGED to note when we are copying a mount from a mount namespace that requires more privileges to a mount namespace that requires fewer privileges. When the CL_UNPRIVILEGED flag is set cause clone_mnt to set MNT_NO_REMOUNT if any of the mnt flags that should never be changed are set. This protects both mount propagation and the initial creation of a less privileged mount namespace. Cc: [email protected] Acked-by: Serge Hallyn <[email protected]> Reported-by: Andy Lutomirski <[email protected]> Signed-off-by: "Eric W. Biederman" <[email protected]>
void mnt_pin(struct vfsmount *mnt) { br_write_lock(&vfsmount_lock); real_mount(mnt)->mnt_pinned++; br_write_unlock(&vfsmount_lock); }
void mnt_pin(struct vfsmount *mnt) { br_write_lock(&vfsmount_lock); real_mount(mnt)->mnt_pinned++; br_write_unlock(&vfsmount_lock); }
C
linux
0
CVE-2016-10196
https://www.cvedetails.com/cve/CVE-2016-10196/
CWE-119
https://github.com/libevent/libevent/commit/329acc18a0768c21ba22522f01a5c7f46cacc4d5
329acc18a0768c21ba22522f01a5c7f46cacc4d5
evutil_parse_sockaddr_port(): fix buffer overflow @asn-the-goblin-slayer: "Length between '[' and ']' is cast to signed 32 bit integer on line 1815. Is the length is more than 2<<31 (INT_MAX), len will hold a negative value. Consequently, it will pass the check at line 1816. Segfault happens at line 1819. Generate a resolv.conf with generate-resolv.conf, then compile and run poc.c. See entry-functions.txt for functions in tor that might be vulnerable. Please credit 'Guido Vranken' for this discovery through the Tor bug bounty program." Reproducer for gdb (https://gist.github.com/azat/be2b0d5e9417ba0dfe2c): start p (1ULL<<31)+1ULL # $1 = 2147483649 p malloc(sizeof(struct sockaddr)) # $2 = (void *) 0x646010 p malloc(sizeof(int)) # $3 = (void *) 0x646030 p malloc($1) # $4 = (void *) 0x7fff76a2a010 p memset($4, 1, $1) # $5 = 1990369296 p (char *)$4 # $6 = 0x7fff76a2a010 '\001' <repeats 200 times>... set $6[0]='[' set $6[$1]=']' p evutil_parse_sockaddr_port($4, $2, $3) # $7 = -1 Before: $ gdb bin/http-connect < gdb (gdb) $1 = 2147483649 (gdb) (gdb) $2 = (void *) 0x646010 (gdb) (gdb) $3 = (void *) 0x646030 (gdb) (gdb) $4 = (void *) 0x7fff76a2a010 (gdb) (gdb) $5 = 1990369296 (gdb) (gdb) $6 = 0x7fff76a2a010 '\001' <repeats 200 times>... (gdb) (gdb) (gdb) (gdb) Program received signal SIGSEGV, Segmentation fault. __memcpy_sse2_unaligned () at memcpy-sse2-unaligned.S:36 After: $ gdb bin/http-connect < gdb (gdb) $1 = 2147483649 (gdb) (gdb) $2 = (void *) 0x646010 (gdb) (gdb) $3 = (void *) 0x646030 (gdb) (gdb) $4 = (void *) 0x7fff76a2a010 (gdb) (gdb) $5 = 1990369296 (gdb) (gdb) $6 = 0x7fff76a2a010 '\001' <repeats 200 times>... (gdb) (gdb) (gdb) (gdb) $7 = -1 (gdb) (gdb) quit Fixes: #318
apply_numeric_port_hack(int port, struct evutil_addrinfo **ai) { /* Now we run through the list and set the ports on all of the * results where ports would make sense. */ for ( ; *ai; ai = &(*ai)->ai_next) { struct sockaddr *sa = (*ai)->ai_addr; if (sa && sa->sa_family == AF_INET) { struct sockaddr_in *sin = (struct sockaddr_in*)sa; sin->sin_port = htons(port); } else if (sa && sa->sa_family == AF_INET6) { struct sockaddr_in6 *sin6 = (struct sockaddr_in6*)sa; sin6->sin6_port = htons(port); } else { /* A numeric port makes no sense here; remove this one * from the list. */ struct evutil_addrinfo *victim = *ai; *ai = victim->ai_next; victim->ai_next = NULL; freeaddrinfo(victim); } } }
apply_numeric_port_hack(int port, struct evutil_addrinfo **ai) { /* Now we run through the list and set the ports on all of the * results where ports would make sense. */ for ( ; *ai; ai = &(*ai)->ai_next) { struct sockaddr *sa = (*ai)->ai_addr; if (sa && sa->sa_family == AF_INET) { struct sockaddr_in *sin = (struct sockaddr_in*)sa; sin->sin_port = htons(port); } else if (sa && sa->sa_family == AF_INET6) { struct sockaddr_in6 *sin6 = (struct sockaddr_in6*)sa; sin6->sin6_port = htons(port); } else { /* A numeric port makes no sense here; remove this one * from the list. */ struct evutil_addrinfo *victim = *ai; *ai = victim->ai_next; victim->ai_next = NULL; freeaddrinfo(victim); } } }
C
libevent
0
CVE-2014-2739
https://www.cvedetails.com/cve/CVE-2014-2739/
CWE-20
https://github.com/torvalds/linux/commit/b2853fd6c2d0f383dbdf7427e263eb576a633867
b2853fd6c2d0f383dbdf7427e263eb576a633867
IB/core: Don't resolve passive side RoCE L2 address in CMA REQ handler The code that resolves the passive side source MAC within the rdma_cm connection request handler was both redundant and buggy, so remove it. It was redundant since later, when an RC QP is modified to RTR state, the resolution will take place in the ib_core module. It was buggy because this callback also deals with UD SIDR exchange, for which we incorrectly looked at the REQ member of the CM event and dereferenced a random value. Fixes: dd5f03beb4f7 ("IB/core: Ethernet L2 attributes in verbs/cm structures") Signed-off-by: Moni Shoua <[email protected]> Signed-off-by: Or Gerlitz <[email protected]> Signed-off-by: Roland Dreier <[email protected]>
static void cma_set_rep_event_data(struct rdma_cm_event *event, struct ib_cm_rep_event_param *rep_data, void *private_data) { event->param.conn.private_data = private_data; event->param.conn.private_data_len = IB_CM_REP_PRIVATE_DATA_SIZE; event->param.conn.responder_resources = rep_data->responder_resources; event->param.conn.initiator_depth = rep_data->initiator_depth; event->param.conn.flow_control = rep_data->flow_control; event->param.conn.rnr_retry_count = rep_data->rnr_retry_count; event->param.conn.srq = rep_data->srq; event->param.conn.qp_num = rep_data->remote_qpn; }
static void cma_set_rep_event_data(struct rdma_cm_event *event, struct ib_cm_rep_event_param *rep_data, void *private_data) { event->param.conn.private_data = private_data; event->param.conn.private_data_len = IB_CM_REP_PRIVATE_DATA_SIZE; event->param.conn.responder_resources = rep_data->responder_resources; event->param.conn.initiator_depth = rep_data->initiator_depth; event->param.conn.flow_control = rep_data->flow_control; event->param.conn.rnr_retry_count = rep_data->rnr_retry_count; event->param.conn.srq = rep_data->srq; event->param.conn.qp_num = rep_data->remote_qpn; }
C
linux
0
CVE-2011-4127
https://www.cvedetails.com/cve/CVE-2011-4127/
CWE-264
https://github.com/torvalds/linux/commit/0bfc96cb77224736dfa35c3c555d37b3646ef35e
0bfc96cb77224736dfa35c3c555d37b3646ef35e
block: fail SCSI passthrough ioctls on partition devices Linux allows executing the SG_IO ioctl on a partition or LVM volume, and will pass the command to the underlying block device. This is well-known, but it is also a large security problem when (via Unix permissions, ACLs, SELinux or a combination thereof) a program or user needs to be granted access only to part of the disk. This patch lets partitions forward a small set of harmless ioctls; others are logged with printk so that we can see which ioctls are actually sent. In my tests only CDROM_GET_CAPABILITY actually occurred. Of course it was being sent to a (partition on a) hard disk, so it would have failed with ENOTTY and the patch isn't changing anything in practice. Still, I'm treating it specially to avoid spamming the logs. In principle, this restriction should include programs running with CAP_SYS_RAWIO. If for example I let a program access /dev/sda2 and /dev/sdb, it still should not be able to read/write outside the boundaries of /dev/sda2 independent of the capabilities. However, for now programs with CAP_SYS_RAWIO will still be allowed to send the ioctls. Their actions will still be logged. This patch does not affect the non-libata IDE driver. That driver however already tests for bd != bd->bd_contains before issuing some ioctl; it could be restricted further to forbid these ioctls even for programs running with CAP_SYS_ADMIN/CAP_SYS_RAWIO. Cc: [email protected] Cc: Jens Axboe <[email protected]> Cc: James Bottomley <[email protected]> Signed-off-by: Paolo Bonzini <[email protected]> [ Make it also print the command name when warning - Linus ] Signed-off-by: Linus Torvalds <[email protected]>
static int sg_emulated_host(struct request_queue *q, int __user *p) { return put_user(1, p); }
static int sg_emulated_host(struct request_queue *q, int __user *p) { return put_user(1, p); }
C
linux
0
CVE-2015-1213
https://www.cvedetails.com/cve/CVE-2015-1213/
CWE-119
https://github.com/chromium/chromium/commit/faaa2fd0a05f1622d9a8806da118d4f3b602e707
faaa2fd0a05f1622d9a8806da118d4f3b602e707
[Blink>Media] Allow autoplay muted on Android by default There was a mistake causing autoplay muted is shipped on Android but it will be disabled if the chromium embedder doesn't specify content setting for "AllowAutoplay" preference. This CL makes the AllowAutoplay preference true by default so that it is allowed by embedders (including AndroidWebView) unless they explicitly disable it. Intent to ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/Q1cnzNI2GpI/AL_eyUNABgAJ BUG=689018 Review-Url: https://codereview.chromium.org/2677173002 Cr-Commit-Position: refs/heads/master@{#448423}
void HTMLMediaElement::networkStateChanged() { setNetworkState(webMediaPlayer()->getNetworkState()); }
void HTMLMediaElement::networkStateChanged() { setNetworkState(webMediaPlayer()->getNetworkState()); }
C
Chrome
0
CVE-2013-3236
https://www.cvedetails.com/cve/CVE-2013-3236/
CWE-200
https://github.com/torvalds/linux/commit/680d04e0ba7e926233e3b9cee59125ce181f66ba
680d04e0ba7e926233e3b9cee59125ce181f66ba
VSOCK: vmci - fix possible info leak in vmci_transport_dgram_dequeue() In case we received no data on the call to skb_recv_datagram(), i.e. skb->data is NULL, vmci_transport_dgram_dequeue() will return with 0 without updating msg_namelen leading to net/socket.c leaking the local, uninitialized sockaddr_storage variable to userland -- 128 bytes of kernel stack memory. Fix this by moving the already existing msg_namelen assignment a few lines above. Cc: Andy King <[email protected]> Cc: Dmitry Torokhov <[email protected]> Cc: George Zhang <[email protected]> Signed-off-by: Mathias Krause <[email protected]> Signed-off-by: David S. Miller <[email protected]>
vmci_transport_queue_pair_alloc(struct vmci_qp **qpair, struct vmci_handle *handle, u64 produce_size, u64 consume_size, u32 peer, u32 flags, bool trusted) { int err = 0; if (trusted) { /* Try to allocate our queue pair as trusted. This will only * work if vsock is running in the host. */ err = vmci_qpair_alloc(qpair, handle, produce_size, consume_size, peer, flags, VMCI_PRIVILEGE_FLAG_TRUSTED); if (err != VMCI_ERROR_NO_ACCESS) goto out; } err = vmci_qpair_alloc(qpair, handle, produce_size, consume_size, peer, flags, VMCI_NO_PRIVILEGE_FLAGS); out: if (err < 0) { pr_err("Could not attach to queue pair with %d\n", err); err = vmci_transport_error_to_vsock_error(err); } return err; }
vmci_transport_queue_pair_alloc(struct vmci_qp **qpair, struct vmci_handle *handle, u64 produce_size, u64 consume_size, u32 peer, u32 flags, bool trusted) { int err = 0; if (trusted) { /* Try to allocate our queue pair as trusted. This will only * work if vsock is running in the host. */ err = vmci_qpair_alloc(qpair, handle, produce_size, consume_size, peer, flags, VMCI_PRIVILEGE_FLAG_TRUSTED); if (err != VMCI_ERROR_NO_ACCESS) goto out; } err = vmci_qpair_alloc(qpair, handle, produce_size, consume_size, peer, flags, VMCI_NO_PRIVILEGE_FLAGS); out: if (err < 0) { pr_err("Could not attach to queue pair with %d\n", err); err = vmci_transport_error_to_vsock_error(err); } return err; }
C
linux
0
CVE-2017-5122
https://www.cvedetails.com/cve/CVE-2017-5122/
CWE-119
https://github.com/chromium/chromium/commit/f8675cbb337440a11bf9afb10ea11bae42bb92cb
f8675cbb337440a11bf9afb10ea11bae42bb92cb
cros: Enable some tests in //ash/wm in ash_unittests --mash For the ones that fail, disable them via filter file instead of in the code, per our disablement policy. Bug: 698085, 695556, 698878, 698888, 698093, 698894 Test: ash_unittests --mash Change-Id: Ic145ab6a95508968d6884d14fac2a3ca08888d26 Reviewed-on: https://chromium-review.googlesource.com/752423 Commit-Queue: James Cook <[email protected]> Reviewed-by: Steven Bennetts <[email protected]> Cr-Commit-Position: refs/heads/master@{#513836}
aura::Window* GetOverviewWindowForMinimizedState(int index, aura::Window* window) { WindowSelectorItem* selector = GetWindowItemForWindow(index, window); return selector->GetOverviewWindowForMinimizedStateForTest(); }
aura::Window* GetOverviewWindowForMinimizedState(int index, aura::Window* window) { WindowSelectorItem* selector = GetWindowItemForWindow(index, window); return selector->GetOverviewWindowForMinimizedStateForTest(); }
C
Chrome
0
CVE-2015-6761
https://www.cvedetails.com/cve/CVE-2015-6761/
CWE-362
https://github.com/chromium/chromium/commit/fd506b0ac6c7846ae45b5034044fe85c28ee68ac
fd506b0ac6c7846ae45b5034044fe85c28ee68ac
Fix detach with open()ed document leaving parent loading indefinitely Change-Id: I26c2a054b9f1e5eb076acd677e1223058825f6d6 Bug: 803416 Test: fast/loader/document-open-iframe-then-detach.html Change-Id: I26c2a054b9f1e5eb076acd677e1223058825f6d6 Reviewed-on: https://chromium-review.googlesource.com/887298 Reviewed-by: Mike West <[email protected]> Commit-Queue: Nate Chapin <[email protected]> Cr-Commit-Position: refs/heads/master@{#532967}
void DocumentLoader::DispatchLinkHeaderPreloads( ViewportDescriptionWrapper* viewport, LinkLoader::MediaPreloadPolicy media_policy) { DCHECK_GE(state_, kCommitted); LinkLoader::LoadLinksFromHeader( GetResponse().HttpHeaderField(HTTPNames::Link), GetResponse().Url(), *frame_, frame_->GetDocument(), NetworkHintsInterfaceImpl(), LinkLoader::kOnlyLoadResources, media_policy, viewport); }
void DocumentLoader::DispatchLinkHeaderPreloads( ViewportDescriptionWrapper* viewport, LinkLoader::MediaPreloadPolicy media_policy) { DCHECK_GE(state_, kCommitted); LinkLoader::LoadLinksFromHeader( GetResponse().HttpHeaderField(HTTPNames::Link), GetResponse().Url(), *frame_, frame_->GetDocument(), NetworkHintsInterfaceImpl(), LinkLoader::kOnlyLoadResources, media_policy, viewport); }
C
Chrome
0
CVE-2012-2375
https://www.cvedetails.com/cve/CVE-2012-2375/
CWE-189
https://github.com/torvalds/linux/commit/20e0fa98b751facf9a1101edaefbc19c82616a68
20e0fa98b751facf9a1101edaefbc19c82616a68
Fix length of buffer copied in __nfs4_get_acl_uncached _copy_from_pages() used to copy data from the temporary buffer to the user passed buffer is passed the wrong size parameter when copying data. res.acl_len contains both the bitmap and acl lenghts while acl_len contains the acl length after adjusting for the bitmap size. Signed-off-by: Sachin Prabhu <[email protected]> Signed-off-by: Trond Myklebust <[email protected]>
static int _nfs4_proc_create_session(struct nfs_client *clp) { struct nfs4_session *session = clp->cl_session; struct nfs41_create_session_args args = { .client = clp, .cb_program = NFS4_CALLBACK, }; struct nfs41_create_session_res res = { .client = clp, }; struct rpc_message msg = { .rpc_proc = &nfs4_procedures[NFSPROC4_CLNT_CREATE_SESSION], .rpc_argp = &args, .rpc_resp = &res, }; int status; nfs4_init_channel_attrs(&args); args.flags = (SESSION4_PERSIST | SESSION4_BACK_CHAN); status = rpc_call_sync(session->clp->cl_rpcclient, &msg, RPC_TASK_TIMEOUT); if (!status) /* Verify the session's negotiated channel_attrs values */ status = nfs4_verify_channel_attrs(&args, session); if (!status) { /* Increment the clientid slot sequence id */ clp->cl_seqid++; } return status; }
static int _nfs4_proc_create_session(struct nfs_client *clp) { struct nfs4_session *session = clp->cl_session; struct nfs41_create_session_args args = { .client = clp, .cb_program = NFS4_CALLBACK, }; struct nfs41_create_session_res res = { .client = clp, }; struct rpc_message msg = { .rpc_proc = &nfs4_procedures[NFSPROC4_CLNT_CREATE_SESSION], .rpc_argp = &args, .rpc_resp = &res, }; int status; nfs4_init_channel_attrs(&args); args.flags = (SESSION4_PERSIST | SESSION4_BACK_CHAN); status = rpc_call_sync(session->clp->cl_rpcclient, &msg, RPC_TASK_TIMEOUT); if (!status) /* Verify the session's negotiated channel_attrs values */ status = nfs4_verify_channel_attrs(&args, session); if (!status) { /* Increment the clientid slot sequence id */ clp->cl_seqid++; } return status; }
C
linux
0
CVE-2018-6096
https://www.cvedetails.com/cve/CVE-2018-6096/
null
https://github.com/chromium/chromium/commit/36f801fdbec07d116a6f4f07bb363f10897d6a51
36f801fdbec07d116a6f4f07bb363f10897d6a51
If a page calls |window.focus()|, kick it out of fullscreen. BUG=776418, 800056 Change-Id: I1880fe600e4814c073f247c43b1c1ac80c8fc017 Reviewed-on: https://chromium-review.googlesource.com/852378 Reviewed-by: Nasko Oskov <[email protected]> Reviewed-by: Philip Jägenstedt <[email protected]> Commit-Queue: Avi Drissman <[email protected]> Cr-Commit-Position: refs/heads/master@{#533790}
void RenderViewImpl::ConvertWindowToViewport(blink::WebFloatRect* rect) { RenderWidget::ConvertWindowToViewport(rect); }
void RenderViewImpl::ConvertWindowToViewport(blink::WebFloatRect* rect) { RenderWidget::ConvertWindowToViewport(rect); }
C
Chrome
0
CVE-2018-1000037
https://www.cvedetails.com/cve/CVE-2018-1000037/
CWE-20
http://git.ghostscript.com/?p=mupdf.git;a=commitdiff;h=8a3257b01faa899dd9b5e35c6bb3403cd709c371;hp=de39f005f12a1afc6973c1f5cec362d6545f70cb
8a3257b01faa899dd9b5e35c6bb3403cd709c371
null
pdf_process_SC(fz_context *ctx, pdf_processor *proc, pdf_csi *csi, int stroke) { if (csi->name[0]) { pdf_obj *patres, *patobj, *type; patres = pdf_dict_get(ctx, csi->rdb, PDF_NAME_Pattern); if (!patres) fz_throw(ctx, FZ_ERROR_SYNTAX, "cannot find Pattern dictionary"); patobj = pdf_dict_gets(ctx, patres, csi->name); if (!patobj) fz_throw(ctx, FZ_ERROR_SYNTAX, "cannot find Pattern resource '%s'", csi->name); type = pdf_dict_get(ctx, patobj, PDF_NAME_PatternType); if (pdf_to_int(ctx, type) == 1) { if (proc->op_SC_pattern && proc->op_sc_pattern) { pdf_pattern *pat = pdf_load_pattern(ctx, csi->doc, patobj); fz_try(ctx) { if (stroke) proc->op_SC_pattern(ctx, proc, csi->name, pat, csi->top, csi->stack); else proc->op_sc_pattern(ctx, proc, csi->name, pat, csi->top, csi->stack); } fz_always(ctx) pdf_drop_pattern(ctx, pat); fz_catch(ctx) fz_rethrow(ctx); } } else if (pdf_to_int(ctx, type) == 2) { if (proc->op_SC_shade && proc->op_sc_shade) { fz_shade *shade = pdf_load_shading(ctx, csi->doc, patobj); fz_try(ctx) { if (stroke) proc->op_SC_shade(ctx, proc, csi->name, shade); else proc->op_sc_shade(ctx, proc, csi->name, shade); } fz_always(ctx) fz_drop_shade(ctx, shade); fz_catch(ctx) fz_rethrow(ctx); } } else { fz_throw(ctx, FZ_ERROR_SYNTAX, "unknown pattern type: %d", pdf_to_int(ctx, type)); } } else { if (proc->op_SC_color && proc->op_sc_color) { if (stroke) proc->op_SC_color(ctx, proc, csi->top, csi->stack); else proc->op_sc_color(ctx, proc, csi->top, csi->stack); } } }
pdf_process_SC(fz_context *ctx, pdf_processor *proc, pdf_csi *csi, int stroke) { if (csi->name[0]) { pdf_obj *patres, *patobj, *type; patres = pdf_dict_get(ctx, csi->rdb, PDF_NAME_Pattern); if (!patres) fz_throw(ctx, FZ_ERROR_SYNTAX, "cannot find Pattern dictionary"); patobj = pdf_dict_gets(ctx, patres, csi->name); if (!patobj) fz_throw(ctx, FZ_ERROR_SYNTAX, "cannot find Pattern resource '%s'", csi->name); type = pdf_dict_get(ctx, patobj, PDF_NAME_PatternType); if (pdf_to_int(ctx, type) == 1) { if (proc->op_SC_pattern && proc->op_sc_pattern) { pdf_pattern *pat = pdf_load_pattern(ctx, csi->doc, patobj); fz_try(ctx) { if (stroke) proc->op_SC_pattern(ctx, proc, csi->name, pat, csi->top, csi->stack); else proc->op_sc_pattern(ctx, proc, csi->name, pat, csi->top, csi->stack); } fz_always(ctx) pdf_drop_pattern(ctx, pat); fz_catch(ctx) fz_rethrow(ctx); } } else if (pdf_to_int(ctx, type) == 2) { if (proc->op_SC_shade && proc->op_sc_shade) { fz_shade *shade = pdf_load_shading(ctx, csi->doc, patobj); fz_try(ctx) { if (stroke) proc->op_SC_shade(ctx, proc, csi->name, shade); else proc->op_sc_shade(ctx, proc, csi->name, shade); } fz_always(ctx) fz_drop_shade(ctx, shade); fz_catch(ctx) fz_rethrow(ctx); } } else { fz_throw(ctx, FZ_ERROR_SYNTAX, "unknown pattern type: %d", pdf_to_int(ctx, type)); } } else { if (proc->op_SC_color && proc->op_sc_color) { if (stroke) proc->op_SC_color(ctx, proc, csi->top, csi->stack); else proc->op_sc_color(ctx, proc, csi->top, csi->stack); } } }
C
ghostscript
0
CVE-2015-1300
https://www.cvedetails.com/cve/CVE-2015-1300/
CWE-254
https://github.com/chromium/chromium/commit/9c391ac04f9ac478c8b0e43b359c2b43a6c892ab
9c391ac04f9ac478c8b0e43b359c2b43a6c892ab
Use pdf compositor service for printing when OOPIF is enabled When OOPIF is enabled (by site-per-process flag or top-document-isolation feature), use the pdf compositor service for converting PaintRecord to PDF on renderers. In the future, this will make compositing PDF from multiple renderers possible. [email protected] BUG=455764 Change-Id: I3c28f03f4358e4228239fe1a33384f85e7716e8f Reviewed-on: https://chromium-review.googlesource.com/699765 Commit-Queue: Wei Li <[email protected]> Reviewed-by: Daniel Cheng <[email protected]> Reviewed-by: Lei Zhang <[email protected]> Cr-Commit-Position: refs/heads/master@{#511616}
PrintPreviewDialogDelegate::PrintPreviewDialogDelegate(WebContents* initiator) : initiator_(initiator) { }
PrintPreviewDialogDelegate::PrintPreviewDialogDelegate(WebContents* initiator) : initiator_(initiator) { }
C
Chrome
0
CVE-2018-17206
https://www.cvedetails.com/cve/CVE-2018-17206/
null
https://github.com/openvswitch/ovs/commit/9237a63c47bd314b807cda0bd2216264e82edbe8
9237a63c47bd314b807cda0bd2216264e82edbe8
ofp-actions: Avoid buffer overread in BUNDLE action decoding. Reported-at: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=9052 Signed-off-by: Ben Pfaff <[email protected]> Acked-by: Justin Pettit <[email protected]>
parse_STACK_PUSH(char *arg, struct ofpbuf *ofpacts, enum ofputil_protocol *usable_protocols OVS_UNUSED) { return nxm_parse_stack_action(ofpact_put_STACK_PUSH(ofpacts), arg); }
parse_STACK_PUSH(char *arg, struct ofpbuf *ofpacts, enum ofputil_protocol *usable_protocols OVS_UNUSED) { return nxm_parse_stack_action(ofpact_put_STACK_PUSH(ofpacts), arg); }
C
ovs
0
CVE-2017-9202
https://www.cvedetails.com/cve/CVE-2017-9202/
CWE-369
https://github.com/jsummers/imageworsener/commit/dc49c807926b96e503bd7c0dec35119eecd6c6fe
dc49c807926b96e503bd7c0dec35119eecd6c6fe
Double-check that the input image's density is valid Fixes a bug that could result in division by zero, at least for a JPEG source image. Fixes issues #19, #20
IW_IMPL(void) iw_make_gamma_csdescr(struct iw_csdescr *cs, double gamma) { cs->cstype = IW_CSTYPE_GAMMA; cs->gamma = gamma; if(cs->gamma<0.1) cs->gamma=0.1; if(cs->gamma>10.0) cs->gamma=10.0; cs->srgb_intent = 0; optimize_csdescr(cs); }
IW_IMPL(void) iw_make_gamma_csdescr(struct iw_csdescr *cs, double gamma) { cs->cstype = IW_CSTYPE_GAMMA; cs->gamma = gamma; if(cs->gamma<0.1) cs->gamma=0.1; if(cs->gamma>10.0) cs->gamma=10.0; cs->srgb_intent = 0; optimize_csdescr(cs); }
C
imageworsener
0
CVE-2016-0810
https://www.cvedetails.com/cve/CVE-2016-0810/
CWE-264
https://android.googlesource.com/platform%2Fframeworks%2Fav/+/19c47afbc402542720ddd280e1bbde3b2277b586
19c47afbc402542720ddd280e1bbde3b2277b586
DO NOT MERGE SoundPool: add lock for findSample access from SoundPoolThread Sample decoding still occurs in SoundPoolThread without holding the SoundPool lock. Bug: 25781119 Change-Id: I11fde005aa9cf5438e0390a0d2dfe0ec1dd282e8
Sample::Sample(int sampleID, int fd, int64_t offset, int64_t length) { init(); mSampleID = sampleID; mFd = dup(fd); mOffset = offset; mLength = length; ALOGV("create sampleID=%d, fd=%d, offset=%" PRId64 " length=%" PRId64, mSampleID, mFd, mLength, mOffset); }
Sample::Sample(int sampleID, int fd, int64_t offset, int64_t length) { init(); mSampleID = sampleID; mFd = dup(fd); mOffset = offset; mLength = length; ALOGV("create sampleID=%d, fd=%d, offset=%" PRId64 " length=%" PRId64, mSampleID, mFd, mLength, mOffset); }
C
Android
0
CVE-2015-1278
https://www.cvedetails.com/cve/CVE-2015-1278/
CWE-254
https://github.com/chromium/chromium/commit/784f56a9c97a838448dd23f9bdc7c05fe8e639b3
784f56a9c97a838448dd23f9bdc7c05fe8e639b3
Correctly reset FP in RFHI whenever origin changes Bug: 713364 Change-Id: Id8bb923750e20f3db6fc9358b1d44120513ac95f CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Change-Id: Id8bb923750e20f3db6fc9358b1d44120513ac95f Reviewed-on: https://chromium-review.googlesource.com/482380 Commit-Queue: Ian Clelland <[email protected]> Reviewed-by: Charles Reis <[email protected]> Cr-Commit-Position: refs/heads/master@{#466778}
void RenderFrameHostImpl::OnDidCommitProvisionalLoad(const IPC::Message& msg) { ScopedCommitStateResetter commit_state_resetter(this); RenderProcessHost* process = GetProcess(); base::PickleIterator iter(msg); FrameHostMsg_DidCommitProvisionalLoad_Params validated_params; if (!IPC::ParamTraits<FrameHostMsg_DidCommitProvisionalLoad_Params>:: Read(&msg, &iter, &validated_params)) { bad_message::ReceivedBadMessage( process, bad_message::RFH_COMMIT_DESERIALIZATION_FAILED); return; } TRACE_EVENT1("navigation", "RenderFrameHostImpl::OnDidCommitProvisionalLoad", "url", validated_params.url.possibly_invalid_spec()); DCHECK_EQ(ui::PageTransitionIsMainFrame(validated_params.transition), !GetParent()); if (is_waiting_for_beforeunload_ack_ && unload_ack_is_for_navigation_ && !GetParent()) { base::TimeTicks approx_renderer_start_time = send_before_unload_start_time_; OnBeforeUnloadACK(true, approx_renderer_start_time, base::TimeTicks::Now()); } if (IsWaitingForUnloadACK()) return; if (validated_params.report_type == FrameMsg_UILoadMetricsReportType::REPORT_LINK) { UMA_HISTOGRAM_CUSTOM_TIMES( "Navigation.UI_OnCommitProvisionalLoad.Link", base::TimeTicks::Now() - validated_params.ui_timestamp, base::TimeDelta::FromMilliseconds(10), base::TimeDelta::FromMinutes(10), 100); } else if (validated_params.report_type == FrameMsg_UILoadMetricsReportType::REPORT_INTENT) { UMA_HISTOGRAM_CUSTOM_TIMES( "Navigation.UI_OnCommitProvisionalLoad.Intent", base::TimeTicks::Now() - validated_params.ui_timestamp, base::TimeDelta::FromMilliseconds(10), base::TimeDelta::FromMinutes(10), 100); } if (!CanCommitURL(validated_params.url)) { VLOG(1) << "Blocked URL " << validated_params.url.spec(); bad_message::ReceivedBadMessage(process, bad_message::RFH_CAN_COMMIT_URL_BLOCKED); return; } if (!CanCommitOrigin(validated_params.origin, validated_params.url)) { bad_message::ReceivedBadMessage(GetProcess(), bad_message::RFH_INVALID_ORIGIN_ON_COMMIT); return; } process->FilterURL(false, &validated_params.url); process->FilterURL(true, &validated_params.referrer.url); for (std::vector<GURL>::iterator it(validated_params.redirects.begin()); it != validated_params.redirects.end(); ++it) { process->FilterURL(false, &(*it)); } process->FilterURL(true, &validated_params.searchable_form_url); if (!CanAccessFilesOfPageState(validated_params.page_state)) { bad_message::ReceivedBadMessage( GetProcess(), bad_message::RFH_CAN_ACCESS_FILES_OF_PAGE_STATE); return; } if (!navigation_handle_ && IsBrowserSideNavigationEnabled()) { if (!is_loading()) { bool was_loading = frame_tree_node()->frame_tree()->IsLoading(); is_loading_ = true; frame_tree_node()->DidStartLoading(true, was_loading); } pending_commit_ = false; } std::unique_ptr<NavigationHandleImpl> navigation_handle = TakeNavigationHandleForCommit(validated_params); DCHECK(navigation_handle); if (!IsBrowserSideNavigationEnabled() && !validated_params.searchable_form_url.is_empty()) { navigation_handle->set_searchable_form_url( validated_params.searchable_form_url); navigation_handle->set_searchable_form_encoding( validated_params.searchable_form_encoding); validated_params.searchable_form_url = GURL(); validated_params.searchable_form_encoding = std::string(); } accessibility_reset_count_ = 0; frame_tree_node()->navigator()->DidNavigate(this, validated_params, std::move(navigation_handle)); commit_state_resetter.disable(); if (frame_tree_node_->IsMainFrame() && GetView() && !validated_params.was_within_same_document) { RenderWidgetHostImpl::From(GetView()->GetRenderWidgetHost()) ->StartNewContentRenderingTimeout(validated_params.content_source_id); } }
void RenderFrameHostImpl::OnDidCommitProvisionalLoad(const IPC::Message& msg) { ScopedCommitStateResetter commit_state_resetter(this); RenderProcessHost* process = GetProcess(); base::PickleIterator iter(msg); FrameHostMsg_DidCommitProvisionalLoad_Params validated_params; if (!IPC::ParamTraits<FrameHostMsg_DidCommitProvisionalLoad_Params>:: Read(&msg, &iter, &validated_params)) { bad_message::ReceivedBadMessage( process, bad_message::RFH_COMMIT_DESERIALIZATION_FAILED); return; } TRACE_EVENT1("navigation", "RenderFrameHostImpl::OnDidCommitProvisionalLoad", "url", validated_params.url.possibly_invalid_spec()); DCHECK_EQ(ui::PageTransitionIsMainFrame(validated_params.transition), !GetParent()); if (is_waiting_for_beforeunload_ack_ && unload_ack_is_for_navigation_ && !GetParent()) { base::TimeTicks approx_renderer_start_time = send_before_unload_start_time_; OnBeforeUnloadACK(true, approx_renderer_start_time, base::TimeTicks::Now()); } if (IsWaitingForUnloadACK()) return; if (validated_params.report_type == FrameMsg_UILoadMetricsReportType::REPORT_LINK) { UMA_HISTOGRAM_CUSTOM_TIMES( "Navigation.UI_OnCommitProvisionalLoad.Link", base::TimeTicks::Now() - validated_params.ui_timestamp, base::TimeDelta::FromMilliseconds(10), base::TimeDelta::FromMinutes(10), 100); } else if (validated_params.report_type == FrameMsg_UILoadMetricsReportType::REPORT_INTENT) { UMA_HISTOGRAM_CUSTOM_TIMES( "Navigation.UI_OnCommitProvisionalLoad.Intent", base::TimeTicks::Now() - validated_params.ui_timestamp, base::TimeDelta::FromMilliseconds(10), base::TimeDelta::FromMinutes(10), 100); } if (!CanCommitURL(validated_params.url)) { VLOG(1) << "Blocked URL " << validated_params.url.spec(); bad_message::ReceivedBadMessage(process, bad_message::RFH_CAN_COMMIT_URL_BLOCKED); return; } if (!CanCommitOrigin(validated_params.origin, validated_params.url)) { bad_message::ReceivedBadMessage(GetProcess(), bad_message::RFH_INVALID_ORIGIN_ON_COMMIT); return; } process->FilterURL(false, &validated_params.url); process->FilterURL(true, &validated_params.referrer.url); for (std::vector<GURL>::iterator it(validated_params.redirects.begin()); it != validated_params.redirects.end(); ++it) { process->FilterURL(false, &(*it)); } process->FilterURL(true, &validated_params.searchable_form_url); if (!CanAccessFilesOfPageState(validated_params.page_state)) { bad_message::ReceivedBadMessage( GetProcess(), bad_message::RFH_CAN_ACCESS_FILES_OF_PAGE_STATE); return; } if (!navigation_handle_ && IsBrowserSideNavigationEnabled()) { if (!is_loading()) { bool was_loading = frame_tree_node()->frame_tree()->IsLoading(); is_loading_ = true; frame_tree_node()->DidStartLoading(true, was_loading); } pending_commit_ = false; } std::unique_ptr<NavigationHandleImpl> navigation_handle = TakeNavigationHandleForCommit(validated_params); DCHECK(navigation_handle); if (!IsBrowserSideNavigationEnabled() && !validated_params.searchable_form_url.is_empty()) { navigation_handle->set_searchable_form_url( validated_params.searchable_form_url); navigation_handle->set_searchable_form_encoding( validated_params.searchable_form_encoding); validated_params.searchable_form_url = GURL(); validated_params.searchable_form_encoding = std::string(); } accessibility_reset_count_ = 0; frame_tree_node()->navigator()->DidNavigate(this, validated_params, std::move(navigation_handle)); commit_state_resetter.disable(); if (frame_tree_node_->IsMainFrame() && GetView() && !validated_params.was_within_same_document) { RenderWidgetHostImpl::From(GetView()->GetRenderWidgetHost()) ->StartNewContentRenderingTimeout(validated_params.content_source_id); } }
C
Chrome
0
CVE-2016-7539
https://www.cvedetails.com/cve/CVE-2016-7539/
CWE-399
https://github.com/ImageMagick/ImageMagick/commit/4e81ce8b07219c69a9aeccb0f7f7b927ca6db74c
4e81ce8b07219c69a9aeccb0f7f7b927ca6db74c
http://www.imagemagick.org/discourse-server/viewtopic.php?f=2&t=28946
MagickPrivate MagickBooleanType SyncImagePixelCache(Image *image, ExceptionInfo *exception) { CacheInfo *magick_restrict cache_info; assert(image != (Image *) NULL); assert(exception != (ExceptionInfo *) NULL); cache_info=(CacheInfo *) GetImagePixelCache(image,MagickTrue,exception); return(cache_info == (CacheInfo *) NULL ? MagickFalse : MagickTrue); }
MagickPrivate MagickBooleanType SyncImagePixelCache(Image *image, ExceptionInfo *exception) { CacheInfo *magick_restrict cache_info; assert(image != (Image *) NULL); assert(exception != (ExceptionInfo *) NULL); cache_info=(CacheInfo *) GetImagePixelCache(image,MagickTrue,exception); return(cache_info == (CacheInfo *) NULL ? MagickFalse : MagickTrue); }
C
ImageMagick
0
CVE-2018-6158
https://www.cvedetails.com/cve/CVE-2018-6158/
CWE-362
https://github.com/chromium/chromium/commit/20b65d00ca3d8696430e22efad7485366f8c3a21
20b65d00ca3d8696430e22efad7485366f8c3a21
[oilpan] Fix GCInfoTable for multiple threads Previously, grow and access from different threads could lead to a race on the table backing; see bug. - Rework the table to work on an existing reservation. - Commit upon growing, avoiding any copies. Drive-by: Fix over-allocation of table. Bug: chromium:841280 Change-Id: I329cb6f40091e14e8c05334ba1104a9440c31d43 Reviewed-on: https://chromium-review.googlesource.com/1061525 Commit-Queue: Michael Lippautz <[email protected]> Reviewed-by: Kentaro Hara <[email protected]> Cr-Commit-Position: refs/heads/master@{#560434}
void LargeObjectPage::MakeConsistentForMutator() { HeapObjectHeader* header = GetHeapObjectHeader(); if (header->IsMarked()) header->Unmark(); }
void LargeObjectPage::MakeConsistentForMutator() { HeapObjectHeader* header = GetHeapObjectHeader(); if (header->IsMarked()) header->Unmark(); }
C
Chrome
0
CVE-2018-12453
https://www.cvedetails.com/cve/CVE-2018-12453/
CWE-704
https://github.com/antirez/redis/commit/c04082cf138f1f51cedf05ee9ad36fb6763cafc6
c04082cf138f1f51cedf05ee9ad36fb6763cafc6
Abort in XGROUP if the key is not a stream
void xrevrangeCommand(client *c) { xrangeGenericCommand(c,1); }
void xrevrangeCommand(client *c) { xrangeGenericCommand(c,1); }
C
redis
0