id
int64 393k
2.82B
| repo
stringclasses 68
values | title
stringlengths 1
936
| body
stringlengths 0
256k
⌀ | labels
stringlengths 2
508
| priority
stringclasses 3
values | severity
stringclasses 3
values |
|---|---|---|---|---|---|---|
301,957,787 | awesome-mac | Suggested Additions | Hello,
I have found your list searching for some applications - excellent work and thank you for providing it!
Here are some fixes:
- Coda2 is a a web-developement IDE and not really a general purpose text editor. It probably should be under "Web Development Tools".
Here are some suggestions for additions:
- [Rider](https://www.jetbrains.com/rider/) is a non-free, non-opensource cross-platform C# IDE from Jetbrains - it is an alternative to Visual Studio by Microsoft with the additional benefit of getting [Resharper](https://www.jetbrains.com/resharper/) features that are not available on Visual Studio for Mac.
- [Expressions](http://www.apptorium.com/expressions) is non-free, non-opensource regular expression checker. It has a nice interface and it can dissect a regex.
- [Navicat](https://www.navicat.com/en/products/navicat-premium) is a non-free, non-opensource database editor that supports very many databases. It is a large program that has become more of a database IDE due to the very many features.
- [JavE](http://www.jave.de) is a free and opensource ASCII text editor with very many features.
I highly recommend [GrandPerspective](http://grandperspectiv.sourceforge.net) in "System Related Tools" - it is an open-source and free (beautiful and beautifully simple!) application that can analyze any folder and display files as clusters of blocks depending on the file size.
Under "Game Emulation" you probably would like to add [Wineskin](http://wineskin.urgesoftware.com/tiki-index.php) - it is a wrapper for wine and can be used to run Windows games as well as create self-standing applications.
If useful, please add! (ﾉ◕ヮ◕)ﾉ*:･ﾟ✧
| addition | low | Minor |
302,045,206 | godot | Area3D/Area2D doesn't detect static bodies if "Monitorable" is disabled | <!-- Please search existing issues for potential duplicates before filing yours:
https://github.com/godotengine/godot/issues?q=is%3Aissue
-->
**Godot version:**
184b2fe
**Issue description:**
This could also affect the 3D version of it, but I just tested in 2D.
If an Area2D's `Monitorable` property is disabled, it will fail to detect static bodies. | bug,confirmed,topic:physics | medium | Critical |
302,053,082 | go | cmd/go: "go get github.com\alexbrainman\gowingui" should succeed on Mac | ### What version of Go are you using (`go version`)?
go version go1.10 windows/amd64
### Does this issue reproduce with the latest release?
Yes
### What operating system and processor architecture are you using (`go env`)?
```
set GOARCH=amd64
set GOBIN=
set GOCACHE=C:\Users\Alex\AppData\Local\go-build
set GOEXE=.exe
set GOHOSTARCH=amd64
set GOHOSTOS=windows
set GOOS=windows
set GOPATH=c:\users\alex\dev
set GORACE=
set GOROOT=c:\users\alex\dev\go
set GOTMPDIR=
set GOTOOLDIR=c:\users\alex\dev\go\pkg\tool\windows_amd64
set GCCGO=gccgo
set CC=gcc
set CXX=g++
set CGO_ENABLED=1
set CGO_CFLAGS=-g -O2
set CGO_CPPFLAGS=
set CGO_CXXFLAGS=-g -O2
set CGO_FFLAGS=-g -O2
set CGO_LDFLAGS=-g -O2
set PKG_CONFIG=pkg-config
set GOGCCFLAGS=-m64 -mthreads -fmessage-length=0 -fdebug-prefix-map=C:\Users\Alex\AppData\Local\Temp\go-build838310042=/tmp/go-build -gno-record-gcc-switches
```
### What did you do?
I run
```
go get github.com\alexbrainman\gowingui
````
command.
### What did you expect to see?
I expected command to fail, because I used \ instead of / in package import path.
### What did you see instead?
I see no error message, and I also see gowingui.exe in my %GOPATH%\bin directory.
### Comments
I discovered this while investigating #24232
And if I run
```
go install -ldflags "-H windowsgui" github.com\alexbrainman\gowingui
```
the %GOPATH%\bin\gowingui.exe file does not have IMAGE_SUBSYSTEM_WINDOWS_GUI flag set properly.
So if this issue is rejected as working as intended, than we should fix cmd/go flag processing to avoid cases like #24232
Alex | OS-Darwin,NeedsFix | low | Critical |
302,057,359 | gin | IP Addresses misalign log lines | Variable-length IP addresses misalign everything to their right.
(IPv6 addresses and paths are censored out in orange, but you get the idea.) | bug | low | Minor |
302,058,275 | youtube-dl | Re-enable ANSI console color for Windows 10.16257 and later | In **Windows 10** build **16257** (released [last year](https://blogs.msdn.microsoft.com/commandline/2017/08/02/updating-the-windows-console-colors/)) and later, **ANSI color** and escape sequences for the built-in `cmd.exe` console ("conhost") are subject to the following registry key:
[HKEY_CURRENT_USER\Console]
"VirtualTerminalLevel"=dword:00000001
See [MSDN blogs](https://blogs.msdn.microsoft.com/commandline/2017/06/20/understanding-windows-console-host-settings/) for more information. There's also some official [MSDN docs](https://docs.microsoft.com/en-us/windows/console/console-virtual-terminal-sequences) and a bunch of articles on StackOverflow, such as [here](https://superuser.com/questions/413073/windows-console-with-ansi-colors-handling) and [here](https://stackoverflow.com/questions/16755142/how-to-make-win32-console-recognize-ansi-vt100-escape-sequences). There's also some critical information on this subject in [this](https://github.com/Microsoft/WSL/issues/1173#issuecomment-254250445) github comment.
This new capability means that the following lines of code in **youtube-dl** are overly-restrictive:
https://github.com/rg3/youtube-dl/blob/f9f10268c1816dcf1fc0db9d8128008f73a154c7/youtube_dl/extractor/common.py#L782
https://github.com/rg3/youtube-dl/blob/f9f10268c1816dcf1fc0db9d8128008f73a154c7/youtube_dl/YoutubeDL.py#L596
https://github.com/rg3/youtube-dl/blob/f9f10268c1816dcf1fc0db9d8128008f73a154c7/youtube_dl/YoutubeDL.py#L608
On Windows 10, the value of `compat_os_name` is "nt". Because the lines listed above subsume all three cases where **youtube-dl** references the `--no-color` command-line option, the end result is that the `--no-color` option always asserted on Windows (that is, regardless of ***not*** specifying `--no-color`).
Relaxing the three conjunctions shown above, by removing the `and compat_os_name != 'nt'` term from each, allows for ANSI color on Windows 10 (assuming the system-wide default is 'enabled' as specified by the registry key mentioned above).
| request | low | Major |
302,073,638 | youtube-dl | Viu doesn't work | - [x] I've **verified** and **I assure** that I'm running youtube-dl **2018.03.03**
### Before submitting an *issue* make sure you have:
- [x] At least skimmed through the [README](https://github.com/rg3/youtube-dl/blob/master/README.md), **most notably** the [FAQ](https://github.com/rg3/youtube-dl#faq) and [BUGS](https://github.com/rg3/youtube-dl#bugs) sections
- [x] [Searched](https://github.com/rg3/youtube-dl/search?type=Issues) the bugtracker for similar issues including closed ones
- [x] Checked that provided video/audio/playlist URLs (if any) are alive and playable in a browser
### What is the purpose of your *issue*?
- [x] Bug report (encountered problems with youtube-dl)
---
### Description of your *issue*, suggested solution and other information
Viu doesn't work while Youtube-dl lists it as supported site.
youtube-dl https://www.viu.com/ott/my/en/tag-the_precedent-playlist-22032452
[generic] tag-the_precedent-playlist-22032452: Requesting header
WARNING: Falling back on generic information extractor.
[generic] tag-the_precedent-playlist-22032452: Downloading webpage
[generic] tag-the_precedent-playlist-22032452: Extracting information
ERROR: Unsupported URL: https://www.viu.com/ott/my/en/tag-the_precedent-playlist-22032452
youtube-dl https://www.viu.com/ott/my/en/video-the_precedents_ep_1-1108985519?containerId=playlist-22032452
[generic] video-the_precedents_ep_1-1108985519?containerId=playlist-22032452: Requesting header
WARNING: Falling back on generic information extractor.
[generic] video-the_precedents_ep_1-1108985519?containerId=playlist-22032452: Downloading webpage
[generic] video-the_precedents_ep_1-1108985519?containerId=playlist-22032452: Extracting information
ERROR: Unsupported URL: https://www.viu.com/ott/my/en/video-the_precedents_ep_1-1108985519?containerId=playlist-22032452 | geo-restricted | low | Critical |
302,088,055 | TypeScript | Suggestion: readonly method | **Problem:**
A method (function written with the [ES6 method syntax](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Functions/Method_definitions)) can currently be replaced with another function by a simple assignment.
As an example consider the following snippet of code:
```ts
class Person {
constructor(...) {...}
displayName (): string {...}
}
const x: Person = new Person(...)
x.displayName = function(this: Person): string {...} // Assignment
```
Because the `readonly` modifier is not usable for methods, this is not possible to prevent this kind of assignments.
**Proposal:**
A method is always readonly.
The following codes are identical:
```ts
class Person {
displayName (): string {...}
}
```
```ts
class Person {
readonly displayName: (this: Person) => string = function () {...}
}
```
**Compatibility:**
This is a breaking change. However, method syntax is recent and mostly used in classes. Codes which assign a function to a method are certainly rare.
**Temporary workaround:**
Do not use method syntax in your classes and interfaces. Note hat this leads to very verbose codes.
If you use an interface, the verbosity is acceptable. However you get also strict variance.
```ts
interface PersonI {
readonly displayName: (this: Person) => string
}
```
| Suggestion,Awaiting More Feedback | medium | Critical |
302,094,785 | flutter | TabPageSelector - externalize TabPageSelectorIndicator builder | Would it be possible to add a callback to the `TabPageSelector` that would allow to pass in a custom widget builder that could be used instead of the default `TabPageSelectorIndicator`? | c: new feature,framework,f: material design,P3,team-design,triaged-design | low | Minor |
302,095,717 | go | cmd/compile: loop optimization | Please answer these questions before submitting your issue. Thanks!
### What version of Go are you using (`go version`)?
master (1.11 dev)
### Does this issue reproduce with the latest release?
this is a compilation strategy proposal
### What operating system and processor architecture are you using (`go env`)?
amd64 / Darwin (macbook pro)
### What did you do?
I have code that iterates without referencing the loop variable. Changing that from:
for i := 0; i < n; i++ {
// no access to i
}
...to...
for i := -n; i < 0; i++ {
// no access to i
}
saves me 4%-5% in my test cases.
Looking at the .S files, I see that there are two gains (as expected): one is that the loop limit needs only be addressable and referenced at the start of the loop--which frees a register over the body of the loop; and also, because the test is against zero and there are dedicated instructions for that rather than loading immediate literals or otherwise.
It seems (from afar) that there could be a rule along the lines of:
if loop variable not referenced in body
and assignment has block structure (i:=)
and type of loop variable is signed
and incr RHS does not depend on additive offset to variable (i++ ok, i*=2 not),
then transform "for v := low; v OP high; incr" into "for v := low-high; v OP 0; incr"
I don't have any comprehensive data about how common this situation may be, but it does help.
### What did you expect to see?
no change because i expected the compiler to be doing this.
### What did you see instead?
5% speedup | Performance,NeedsInvestigation,compiler/runtime | low | Major |
302,110,575 | youtube-dl | "Could not send HEAD request to https://learn.miguelgrinberg.com/watch/mega-tutorial/ch01.html: HTTP Error 500: INTERNAL SERVER ERROR" | ## Please follow the guide below
- You will be asked some questions and requested to provide some information, please read them **carefully** and answer honestly
- Put an `x` into all the boxes [ ] relevant to your *issue* (like this: `[x]`)
- Use the *Preview* tab to see what your issue will actually look like
---
### Make sure you are using the *latest* version: run `youtube-dl --version` and ensure your version is *2018.03.03*. If it's not, read [this FAQ entry](https://github.com/rg3/youtube-dl/blob/master/README.md#how-do-i-update-youtube-dl) and update. Issues with outdated version will be rejected.
- [x] I've **verified** and **I assure** that I'm running youtube-dl **2018.03.03**
```
$ youtube-dl --version
2018.03.03
```
### Before submitting an *issue* make sure you have:
- [x] At least skimmed through the [README](https://github.com/rg3/youtube-dl/blob/master/README.md), **most notably** the [FAQ](https://github.com/rg3/youtube-dl#faq) and [BUGS](https://github.com/rg3/youtube-dl#bugs) sections
- [x] [Searched](https://github.com/rg3/youtube-dl/search?type=Issues) the bugtracker for similar issues including closed ones
- [x] Checked that provided video/audio/playlist URLs (if any) are alive and playable in a browser
### What is the purpose of your *issue*?
- [ ] Bug report (encountered problems with youtube-dl)
- [x] Site support request (request for adding support for a new site)
- [ ] Feature request (request for a new functionality)
- [ ] Question
- [ ] Other
---
### The following sections concretize particular purposed issues, you can erase any section (the contents between triple ---) not applicable to your *issue*
---
### If the purpose of this *issue* is a *site support request* please provide all kinds of example URLs support for which should be included (replace following example URLs by **yours**):
- Single video: https://www.youtube.com/watch?v=BaW_jenozKc
- Single video: https://youtu.be/BaW_jenozKc
- Playlist: https://www.youtube.com/playlist?list=PL4lCao7KL_QFVb7Iudeipvc2BCavECqzc
Note that **youtube-dl does not support sites dedicated to [copyright infringement](https://github.com/rg3/youtube-dl#can-you-add-support-for-this-anime-video-site-or-site-which-shows-current-movies-for-free)**. In order for site support request to be accepted all provided example URLs should not violate any copyrights.
---
Hi -
Could you add support for this site, which hosts its videos on Vimeo's streaming platform? The site requires a subscription.
Sample URLs are as follows:
* https://learn.miguelgrinberg.com/watch/mega-tutorial/ch01.html
* https://learn.miguelgrinberg.com/watch/mega-tutorial/ch02.html
...and so on, up to:
* https://learn.miguelgrinberg.com/watch/mega-tutorial/ch23.html
Authenticated users can play videos at those URLs in a browser. Attempting to fetch videos from any of those URLs using `youtube-dl` fails with the error **ERROR: Unable to download webpage: HTTP Error 500: INTERNAL SERVER ERROR (caused by HTTPError());** despite providing credentials on the command line.
The full output from a verbose `youtube-dl` invocation follows:
```
$ youtube-dl --verbose -u PRIVATE https://learn.miguelgrinberg.com/watch/mega-tutorial/ch01.html
```
```
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: [u'--verbose', u'-u', u'PRIVATE', u'https://learn.miguelgrinberg.com/watch/mega-tutorial/ch01.html']
Type account password and press [Return]:
[debug] Encodings: locale UTF-8, fs UTF-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2018.03.03
[debug] Python version 2.7.14 (CPython) - Linux-4.13.0-36-generic-x86_64-with-Ubuntu-17.10-artful
[debug] exe versions: ffmpeg 3.3.4-2, ffprobe 3.3.4-2, rtmpdump 2.4
[debug] Proxy map: {}
[generic] ch01: Requesting header
WARNING: Could not send HEAD request to https://learn.miguelgrinberg.com/watch/mega-tutorial/ch01.html: HTTP Error 500: INTERNAL SERVER ERROR
[generic] ch01: Downloading webpage
ERROR: Unable to download webpage: HTTP Error 500: INTERNAL SERVER ERROR (caused by HTTPError()); please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see https://yt-dl.org/update on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
File "/usr/local/lib/python2.7/dist-packages/youtube_dl/extractor/common.py", line 519, in _request_webpage
return self._downloader.urlopen(url_or_request)
File "/usr/local/lib/python2.7/dist-packages/youtube_dl/YoutubeDL.py", line 2199, in urlopen
return self._opener.open(req, timeout=self._socket_timeout)
File "/usr/lib/python2.7/urllib2.py", line 435, in open
response = meth(req, response)
File "/usr/lib/python2.7/urllib2.py", line 548, in http_response
'http', request, response, code, msg, hdrs)
File "/usr/lib/python2.7/urllib2.py", line 473, in error
return self._call_chain(*args)
File "/usr/lib/python2.7/urllib2.py", line 407, in _call_chain
result = func(*args)
File "/usr/lib/python2.7/urllib2.py", line 556, in http_error_default
raise HTTPError(req.get_full_url(), code, msg, hdrs, fp)
```
Thank you for taking the time to look at this!
| site-support-request,account-needed | low | Critical |
302,117,540 | rust | Linking with `gcc` fails on Windows | The following code fails to link on both `stable-gnu` and `nightly-gnu` toolchains:
```rust
extern crate hound;
fn main() {
let mut input = hound::WavReader::open("clarinet-d4.wav").unwrap();
println!("Hello, world!");
}
```
The build fails with the following output: https://gist.github.com/suhr/2962444f16cfce13bdc7118fe658a33c. Note that `hound` is a pure Rust crate.
Strangely enough, a hello world without `hound` compiles just fine.
OS: Windows 7, toolchain: `stable-gnu` and `nightly-gnu`. | A-linkage,T-compiler,O-windows-gnu,C-bug | medium | Major |
302,123,464 | go | runtime/race: doesn't support the plugin package | #### What did you do?
```Go
// plugin/plugin.go
package main
import (
"os"
"time"
)
var counter int
func main() {
os.Exit(Main())
}
func Main() int {
go func() {
counter++
}()
time.Sleep(500 * time.Millisecond)
return counter
}
```
```Go
// plugin-runner.go
package main
import (
"os"
"plugin"
)
func main() {
p, err := plugin.Open(os.Args[1])
if err != nil {
panic(err)
}
sym, err := p.Lookup("Main")
if err != nil {
panic(err)
}
f := sym.(func() int)
_ = f()
}
```
```bash
$ go build -o plugin/plugin.so -race -buildmode=plugin plugin/plugin.go
$ go run -race plugin-runner.go plugin/plugin.so
```
#### What did you expect to see?
A `DATA RACE` output similar to this one:
```bash
$ go run -race plugin/plugin.go
==================
WARNING: DATA RACE
Read at 0x00000051da38 by main goroutine:
main.Main()
/go/src/github.com/tiborvass/goissues/plugin/race-nodetect/plugin/plugin.go:19 +0x5f
main.main()
/go/src/github.com/tiborvass/goissues/plugin/race-nodetect/plugin/plugin.go:11 +0x2f
Previous write at 0x00000051da38 by goroutine 6:
main.Main.func1()
/go/src/github.com/tiborvass/goissues/plugin/race-nodetect/plugin/plugin.go:16 +0x56
Goroutine 6 (finished) created at:
main.Main()
/go/src/github.com/tiborvass/goissues/plugin/race-nodetect/plugin/plugin.go:15 +0x42
main.main()
/go/src/github.com/tiborvass/goissues/plugin/race-nodetect/plugin/plugin.go:11 +0x2f
==================
exit status 1
```
#### What did you see instead?
No output. I reproduced it 100% on both linux and darwin.
#### System details
```
go version go1.10 linux/amd64
GOARCH="amd64"
GOBIN=""
GOCACHE="/root/.cache/go-build"
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/go"
GORACE=""
GOROOT="/usr/local/go"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build269754766=/tmp/go-build -gno-record-gcc-switches"
GOROOT/bin/go version: go version go1.10 linux/amd64
GOROOT/bin/go tool compile -V: compile version go1.10
uname -sr: Linux 4.9.75-linuxkit-aufs
/lib/x86_64-linux-gnu/libc.so.6: GNU C Library (Debian GLIBC 2.24-11+deb9u1) stable release version 2.24, by Roland McGrath et al.
``` | RaceDetector,help wanted,NeedsInvestigation,FeatureRequest,compiler/runtime | low | Critical |
302,127,824 | flutter | BuildContext docs unclear | https://twitter.com/dodyg/status/970416861161586691
"""
"In particular, this means that within a build method, the build context of the widget of the build method is not the same as the build context of the widgets returned by that build method. "
I am trying to understand this.
"""
| framework,d: api docs,P2,team-framework,triaged-framework | low | Minor |
302,135,725 | godot | GPUParticles3D shadows don't update when the node is outside the camera frustum (and CPUParticles3D does not trigger redrawing) | I set up a 3D scene with the default environment, a player with a camera attached, 3D particles that emit the default spheres, and a bouncing ball. Using the directionalLight node , the shadow for the bouncing ball updates even when out of the frame, but the particle shadows do not.
https://imgur.com/a/rFZlT
| bug,topic:rendering,confirmed,topic:3d,topic:particles | low | Major |
302,148,013 | flutter | Better way to differentiate between tap and scroll | Current value of kTouchSlop seems really big, there is a very noticeable jerk at the beginning of scrolling, which is very unlike any native iOS scrollview, where scrolling feels instantaneous while tapping still works as expected.
As far as I can tell, iOS deals with this following way:
* The tap gesture recognizer start is slightly delayed (optional).
* The scroll gesture recognizer starts almost immediately.
* When scrolling over certain threshold, the touch tap recognizer gets cancelled. Depending on how fast user scrolls, there might be a brief highlight visible (for the time between tap gesture recognizer start and cancellation).
So tapping and scrolling in iOS are not mutually exclusive. | c: new feature,framework,f: gestures,c: proposal,P3,team-framework,triaged-framework | low | Major |
302,171,396 | rust | Provide a way to const-initialize vendor-specific vector types | The platform independent simd types have constructors which are const fns, so they can be used in things like lookup tables: https://raw.githubusercontent.com/sfackler/stream-vbyte64/ea0d5b0afdf97f31473fafbf33d460fbbb313785/src/tables.rs.
However, the same is not the case for the vendor-specific types like `__m256i`. There are platform intrinsics which initialize those types (e.g. `_mm256_setr_epi32` is equivalent to `i32x8::new`) but those are not const fns.
One way to work around this is by type-punning through unions:
```rust
#![feature(stdsimd)]
use std::arch::x86_64::*;
#[repr(C)]
union Pun {
a: __m256i,
b: [u32; 8],
}
static FOO: Pun = Pun { b: [1, 2, 3, 4, 5, 6, 7, 8] };
fn main() {
let x = unsafe { _mm256_extract_epi32(FOO.a, 3) };
println!("{}", x);
}
```
This kind of union is pretty common in SIMD-related C code I've seen, and I think well defined behavior from what the unions RFC describes. Is this the "right" way to do this? Can/should we make functions like `_mm256_set_epi32` const?
cc @alexcrichton | T-lang,C-feature-request,A-SIMD,A-const-eval | low | Major |
302,178,715 | opencv | Why hard code the local size to 256 in ocl_pyramid() ? modules/imgproc/src/pyramid.cpp | ##### System information (version)
<!-- Example
- OpenCV => 3.4.0
- Operating System / Platform => Arm 64
- Compiler => GCC
-->
##### Detailed description
in ocl_pyramid(), the local work size is hard coded to 256, I think it should query the max work group size for the device.
| category: imgproc,category: ocl,RFC | low | Minor |
302,213,116 | pytorch | [feature request] Different interpolation algos for 'grid_sample' function | The 2D grid interpolator function 'grid_sample' only does bilinear sampling from the source image at the moment. It would be useful to have 'nearest' and other samplings available. The function call does take 'mode' as a parameter but only bilinear sampling seems to have been implemented. It would especially be useful if we have to use 'grid_sample' for class label maps for segmentation, and the grid (source indices) is a Variable.
cc @jlin27 @mruberry | hackamonth,module: docs,triaged,function request,module: interpolation | medium | Major |
302,227,051 | flutter | Help users get flutter added to path | ## Steps to Reproduce
We are seeing lots of upstream issues in the IDEs boiling down to the root issue of users not having flutter correctly in path (for example, https://github.com/flutter/flutter/issues/15066, https://github.com/Dart-Code/Dart-Code/issues/633).
It would be good if doctor could check for this.
It would be even better if the flutter tool could offer to add to path on behalf of the user. | tool,P2,team-tool,triaged-tool | low | Major |
302,256,394 | neovim | logging: invalid msgpack-rpc string | Since spell_spec.lua was added, this occasionally fails on travis macOS. We need more visibility into "invalid msgpack-rpc string", perhaps we should keep the full request and if this type of failure is detected, dump the request contents.
There are multiple projects involved, and currently I'm not sure where the `invalid msgpack-rpc string` comes from:
- https://github.com/neovim/lua-client
- https://github.com/libmpack/libmpack
- neovim itself (and its test framework in `test/functional/*`)
```
[32m[2m[----------][0m[0m Running tests from [36m/Users/travis/build/neovim/neovim/test/functional/ui/spell_spec.lua[0m
[32m[2m[ RUN ][0m[0m 'spell' joins long lines #7937: -- Output to stderr:
Uncaught Error: .../nvim-deps/usr/share/lua/5.1/nvim/msgpack_rpc_stream.lua:84: invalid msgpack-rpc string
stack traceback:
[C]: in function 'receive'
.../nvim-deps/usr/share/lua/5.1/nvim/msgpack_rpc_stream.lua:84: in function 'cb'
...vim-deps/usr/share/lua/5.1/nvim/child_process_stream.lua:43: in function <...vim-deps/usr/share/lua/5.1/nvim/child_process_stream.lua:39>
[C]: in function 'run'
/Users/travis/nvim-deps/usr/share/lua/5.1/nvim/session.lua:179: in function '_run'
/Users/travis/nvim-deps/usr/share/lua/5.1/nvim/session.lua:126: in function 'run'
test/functional/helpers.lua:192: in function 'run'
test/functional/ui/screen.lua:286: in function 'wait'
test/functional/ui/screen.lua:221: in function 'expect'
...is/build/neovim/neovim/test/functional/ui/spell_spec.lua:38: in function <...is/build/neovim/neovim/test/functional/ui/spell_spec.lua:27>
...
/Users/travis/nvim-deps/usr/share/lua/5.1/busted/block.lua:155: in function 'execute'
/Users/travis/nvim-deps/usr/share/lua/5.1/busted/init.lua:7: in function 'executor'
/Users/travis/nvim-deps/usr/share/lua/5.1/busted/core.lua:312: in function </Users/travis/nvim-deps/usr/share/lua/5.1/busted/core.lua:312>
[C]: in function 'xpcall'
/Users/travis/nvim-deps/usr/share/lua/5.1/busted/core.lua:178: in function 'safe'
/Users/travis/nvim-deps/usr/share/lua/5.1/busted/core.lua:312: in function 'execute'
...rs/travis/nvim-deps/usr/share/lua/5.1/busted/execute.lua:58: in function 'execute'
/Users/travis/nvim-deps/usr/share/lua/5.1/busted/runner.lua:174: in function </Users/travis/nvim-deps/usr/share/lua/5.1/busted/runner.lua:11>
...deps/usr/lib/luarocks/rocks/busted/2.0.rc12-1/bin/busted:3: in main chunk
[C]: at 0x0100001010
CMake Error at /Users/travis/build/neovim/neovim/cmake/RunTests.cmake:53 (message):
Running functional tests failed with error: 1.
```
"trailing data in msgpack string" seen in https://github.com/neovim/neovim/pull/8304:
```
[32m[2m[ RUN ][0m[0m nvim_ui_attach() handles very large width/height #2180: -- Output to stderr:
Uncaught Error: ...m-deps/usr/share/lua/5.1/nvim/msgpack_rpc_stream.lua:53: trailing data in msgpack string
stack traceback:
[C]: in function 'unpack'
...m-deps/usr/share/lua/5.1/nvim/msgpack_rpc_stream.lua:53: in function <...m-deps/usr/share/lua/5.1/nvim/msgpack_rpc_stream.lua:53>
[C]: in function 'receive'
...m-deps/usr/share/lua/5.1/nvim/msgpack_rpc_stream.lua:84: in function 'cb'
...deps/usr/share/lua/5.1/nvim/child_process_stream.lua:43: in function <...deps/usr/share/lua/5.1/nvim/child_process_stream.lua:39>
[C]: in function 'run'
.../travis/nvim-deps/usr/share/lua/5.1/nvim/session.lua:179: in function '_run'
.../travis/nvim-deps/usr/share/lua/5.1/nvim/session.lua:165: in function '_blocking_request'
.../travis/nvim-deps/usr/share/lua/5.1/nvim/session.lua:86: in function 'request'
test/functional/helpers.lua:90: in function <test/functional/helpers.lua:89>
...
.../travis/nvim-deps/usr/share/lua/5.1/busted/block.lua:155: in function 'execute'
...e/travis/nvim-deps/usr/share/lua/5.1/busted/init.lua:7: in function 'executor'
...e/travis/nvim-deps/usr/share/lua/5.1/busted/core.lua:312: in function <...e/travis/nvim-deps/usr/share/lua/5.1/busted/core.lua:312>
[C]: in function 'xpcall'
...e/travis/nvim-deps/usr/share/lua/5.1/busted/core.lua:178: in function 'safe'
...e/travis/nvim-deps/usr/share/lua/5.1/busted/core.lua:312: in function 'execute'
...ravis/nvim-deps/usr/share/lua/5.1/busted/execute.lua:58: in function 'execute'
...travis/nvim-deps/usr/share/lua/5.1/busted/runner.lua:174: in function <...travis/nvim-deps/usr/share/lua/5.1/busted/runner.lua:11>
.../usr/lib/luarocks/rocks/busted/2.0.rc12-1/bin/busted:3: in main chunk
[C]: ?
CMake Error at /home/travis/build/neovim/neovim/cmake/RunTests.cmake:53 (message):
Running functional tests failed with error: 1.
``` | bug,test,channels-rpc | low | Critical |
302,266,981 | kubernetes | Make pod hostname/subdomain feature compatible with Deployments | **Is this a BUG REPORT or FEATURE REQUEST?**:
/kind feature
**What happened**:
Following this guide - https://kubernetes.io/docs/concepts/services-networking/dns-pod-service/#pods-hostname-and-subdomain-fields
Specifically.
> If there exists a headless service in the same namespace as the pod and with the same name as the subdomain, the cluster’s KubeDNS Server also returns an A record for the Pod’s fully qualified hostname. For example, given a Pod with the hostname set to “busybox-1” and the subdomain set to “default-subdomain”, and a headless Service named “default-subdomain” in the same namespace, the pod will see its own FQDN as “busybox-1.default-subdomain.my-namespace.svc.cluster.local”. DNS serves an A record at that name, pointing to the Pod’s IP. Both pods “busybox1” and “busybox2” can have their distinct A records.
I expect to be able to use this feature in a Deployment, as deploying individual pods is not a scalable pattern.
Specifying a subdomain in the deployment works correctly.
Specifying a hostname causes all the pods in the deployment to have the same hostname - making the feature useless.
Not specifying a hostname causes DNS registration not to occur.
**What you expected to happen**:
I expect to either:
* Specify a hostname prefix in the deployment, and have the deployment put in a unique suffix, and register it with Kube-DNS
or
* Not specify a hostname, and K8s should use the standard hostname, and register that with KubeDNS.
**How to reproduce it (as minimally and precisely as possible)**:
```
apiVersion: v1
kind: Service
metadata:
name: busybox
spec:
selector:
type: busybox
clusterIP: None
ports:
- name: foo # Actually, no port is needed.
port: 1234
targetPort: 1234
---
apiVersion: extensions/v1beta1
kind: Deployment
metadata:
name: busybox
spec:
replicas: 2
template:
metadata:
labels:
name: busybox
type: busybox
name: busybox
spec:
subdomain: busybox
# hostname: foo # optional
containers:
- name: worker
image: busybox
command:
- sleep
- "3600"
```
* Exec into first created pod - try to ping/dig/host other Pod by FQDN.
**Anything else we need to know?**:
I know all about StatefulSets, and how DNS registration works with those. The workload I'm deploying is individual scale-out processing with autoscaling and a natural fit for Deployments - but it does require functional per-pod DNS records.
**Environment**:
- Kubernetes version (use `kubectl version`): v1.7.12-gke.1
- Cloud provider or hardware configuration: GKE
- OS (e.g. from /etc/os-release): busybox
- Kernel (e.g. `uname -a`): 4.4.86+
| sig/network,kind/feature,sig/apps,lifecycle/frozen | high | Critical |
302,273,459 | angular | RouterLinkActiveOptions – Allow activating a link on multiple routes | ## I'm submitting a...
<!-- Check one of the following options with "x" -->
<pre><code>
[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report <!-- Please search GitHub for a similar issue or PR before submitting -->
[x] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question
</code></pre>
## Current behavior
<!-- Describe how the issue manifests. -->
Currently `routerLink` can be active only on the currently specified route
## Expected behavior
<!-- Describe what the desired behavior would be. -->
It would be nice to have an option where we can provide lets say a regex or an array of routes on which we want to make the link active.
It would be useful in the cases where a component is loaded on different routes. For example, in my case, I have a route `/dashboard` that gets loaded at `/` for the logged in users and for non logged in users we load the landing page at `/`. Now in the sidebar on dashboard, I have the router link that looks like below.
```html
<a routerLink="/" [routerLinkOptions]="{exact: true}">Dashboard</a>
```
It gets activated when the user lands on dashboard through `/` but won't work when user lands on `/dashboard`. Currently, I have a custom matcher written that activates the link for me but It would be nice if I could so something like below
```html
<a routerLink="/" [routerLinkOptions]="{match:['/', '/dashboard']}">Dashboard</a>
``` | feature,freq2: medium,area: router,feature: under consideration | medium | Critical |
302,371,070 | opencv | CUDA median filter behavior is broken. | ##### System information (version)
- OpenCV => 3.4
- Operating System / Platform => Windows 64 Bit
- Compiler => Visual Studio 2017
#### Detailed description
Applying median filtering using the CUDA filter vs the CPU filter produces dramatically different results with the CUDA version not matching the expected output.
#### CPU:
##### CUDA:
##### Steps to reproduce
median.cpp
Ptr<cv::cuda::Filter> medianCUDA = cv::cuda::createMedianFilter(CV_8U, 3);
cv::cuda::GpuMat img_d, filtered_d;
cv::Mat img, filtered, cudaResult;
img = imread("input.png", IMREAD_GRAYSCALE);
cv::medianBlur(img.clone(), filtered, 3);
img_d.upload(img.clone());
medianCUDA->apply(img_d, filtered_d);
filtered_d.download(cudaResult);
cv::imwrite("cudaResult.png", cudaResult);
cv::imwrite("cpuResult.png", filtered); | category: gpu/cuda (contrib),incomplete | low | Critical |
302,406,782 | go | cmd/go: installed c-shared libraries receiving ".a" suffix on Linux | ### What version of Go are you using (`go version`)?
`go version go1.9.4 linux/amd64`
### Does this issue reproduce with the latest release?
Yes. Reproduced with `1.10`
### What operating system and processor architecture are you using (`go env`)?
```
GOARCH="amd64"
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GORACE=""
GOROOT="/usr/local/go"
GOTOOLDIR="/usr/local/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
CC="gcc"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build706877829=/tmp/go-build -gno-record-gcc-switches"
CXX="g++"
CGO_ENABLED="1"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
```
### What did you do?
`go install -buildmode=c-shared -x -a ./libpa`
`libpa` contains a a C library declared in a main package.
### What did you expect to see?
I expected the output file to be labeled `libpa.so` indicating it was a shared object
### What did you see instead?
The output was labeled `libpa.a` indicating an archive file, but in actuality it was a shared object file.
```
file $GOPATH//pkg/linux_amd64_shared/<pkg dir>/libpa.a
libpa.a: ELF 64-bit LSB shared object, x86-64, version 1 (SYSV), dynamically linked, BuildID[sha1]=31934079c8d80546780a304c28421f0d8228c9a4, not stripped
```
### Additional Information
- `go build -buildmode=c-shared -o libpa.so -x -a ./libpa` produces the expected `libpa.so` output. This is how `.so` files are generated in [cshared_test.go](https://github.com/golang/go/blob/919e85ae056a238789af6bb2d7b34fe9fdde4ebb/misc/cgo/testcshared/cshared_test.go).
- `go install -buildmode=c-archive -x -a ./libpa` produces an archive file correctly named `libpa.a`
- [init.go](https://github.com/golang/go/blob/0c14345c9638effe6d19569b8bc75caa7c026f66/src/cmd/go/internal/work/init.go) leaves the `cfg.ExeSuffix` empty for Linux machines when the `c-shared` option is selected (sets it to "`.a`" for `c-archive`).
- Passing GOEXE=".so" does not appear to overwrite the cfg.ExeSuffix.
| help wanted,NeedsFix | low | Critical |
302,489,012 | rust | Enum variants completely shadow inherent associated functions. | Consider the code below:
```rust
enum Foo { Bar(i32) }
impl Foo {
fn Bar(x: i32) -> Foo {
println!("I'm uncallable");
Foo::Bar(x)
}
}
fn main() {
Foo::Bar(0); // Variant constructor.
<Foo>::Bar(0); // Inherent function.
}
```
It compiles successfully and terminates with no output. There is an ambiguity between the variant and the associated function, <strike>though it seems we always prefer the variant, making the associated function uncallable</strike>. Having an inherent associated function with the same name as a variant should be an error.
Edit: @petrochenkov points out that it's not actually uncallable, you can call it with `<Foo>::Bar(0)`. A deny-by-default lint then perhaps? | C-enhancement,A-diagnostics,T-compiler | low | Critical |
302,505,433 | pytorch | [feature request] F.interpolate to support integral data types: bool, int8, int32, int16, int64 ||| support uint8 on CUDA | 1. Bilinear upsampling on integer types like ByteTensor and LongTensor
~~2. Nearest upsampling when target size isn't divisible by input size~~ | todo,triaged | medium | Major |
302,519,900 | go | cmd/compile: struct field alive too long | Program 1:
```
package main
import (
"fmt"
"runtime"
)
func main() {
y := make([]int, 1e6)
runtime.GC()
var stat runtime.MemStats
runtime.ReadMemStats(&stat)
fmt.Println(stat.Alloc)
fmt.Println(len(y))
}
```
Program 2:
```
package main
import (
"fmt"
"runtime"
)
func main() {
type T struct {
x int
y *[1e6]int
}
t := T{x: 7, y: new([1e6]int)}
runtime.GC()
var stat runtime.MemStats
runtime.ReadMemStats(&stat)
fmt.Println(stat.Alloc)
fmt.Println(t.x)
}
```
In program 1, the allocation at `make` is garbage collected, so program 1 prints just ~100KB of usage.
In program 2, the allocation at `new` is not garbage collected, so it prints ~8MB.
The allocation in program 2 should be GCd, it is no longer referenced.
For some reason the compiler is keeping all of t alive even though only one field of it is alive after GC.
Strangely, if I replace `fmt.Println` with `println`, then the allocation gets GCd.
I'm not entirely sure what is going on yet, but it looks like `t` is being treated as addressable. But it is getting decomposed correctly. Strange.
First reported here: https://groups.google.com/forum/#!topic/golang-nuts/4qmn5gw7OBQ | NeedsFix,compiler/runtime | low | Major |
302,521,817 | flutter | a11y announcements of fancy text field | Internal: b/292548468
What is the a11y behavior of the fancy text fields supposed to be that have a placeholder text, a helper, and a character count? What should be announced how?
Also, what about the text field that has a suffix with "/dozen"??
How should errors be announced?
Needs to be defined for iOS and Android.
@HansMuller | framework,f: material design,a: accessibility,customer: mulligan (g3),from: a11y review,P2,team-design,triaged-design | low | Critical |
302,543,822 | TypeScript | JSDoc member documentation not returned by quickInfo | https://github.com/Microsoft/vscode/issues/40181
<!-- Please try to reproduce the issue with `typescript@next`. It may have already been fixed. -->
**TypeScript Version:** 2.8.0-dev.20180302
<!-- Search terms you tried before logging this (so others can find this issue more easily) -->
**Search Terms:**
**Code**
For the js:
```ts
/**
* @param o has a string and a number
* @param o.s the string
* @param o.n the number
*/
function f(o: {s: string; n: number }) { return o.s.length + o.n; }
f({s: 'abc', n: 2})
```
hover over `s` to trigger a quickInfo request
**Expected behavior:**
Documentation for `s` is returned.
**Actual behavior:**
No documentation returned:
```
[Trace - 6:45:58 PM] Response received: quickinfo (38). Request took 10 ms. Success: true
Result: {
"kind": "property",
"kindModifiers": "",
"start": {
"line": 8,
"offset": 4
},
"end": {
"line": 8,
"offset": 5
},
"displayString": "(property) s: string",
"documentation": "",
"tags": []
}
```
**Playground Link:** <!-- A link to a TypeScript Playground "Share" link which demonstrates this behavior -->
**Related Issues:**
| Bug,Domain: JSDoc,Domain: Quick Info | low | Minor |
302,586,375 | rust | It's possible to impose generic bounds that later make type inference recurse infinitely | I wrote this wrapper type (e.g. for integers):
```Rust
struct Wrapped<T> (T);
impl<'a, T> Add for &'a Wrapped<T>
where &'a T: Add<Output = T> {
type Output = Wrapped<T>;
fn add(self, other: Self) -> Self::Output {
Wrapped (&self.0 + &other.0)
}
}
```
It works fine, but plays *really poorly* with any helper function definitions of this form:
```Rust
fn add<'a, T: 'a>(left: &'a T, right: &'a T) -> T
where &'a T: Add<Output = T> {
left + right
}
```
The problem doesn't occur until the function is actually used in a way that triggers type inference. For example:
```
error[E0275]: overflow evaluating the requirement `<&_ as std::ops::Add>::Output`
--> src/main.rs:16:24
|
31 | add(&1, &2);
| ^^^
|
= help: consider adding a `#![recursion_limit="128"]` attribute to your crate
= note: required because of the requirements on the impl of `std::ops::Add` for `&Wrapped<_>`
= note: required because of the requirements on the impl of `std::ops::Add` for `&Wrapped<Wrapped<_>>`
= note: required because of the requirements on the impl of `std::ops::Add` for `&Wrapped<Wrapped<Wrapped<_>>>`
= note: required because of the requirements on the impl of `std::ops::Add` for `&Wrapped<Wrapped<Wrapped<Wrapped<_>>>>`
...
= note: required by `add`
```
Notice that this call site doesn't even make use of the type `Wrapped<T>`: it's just impossible to perform type inference on the `add()` helper function at all.
Interestingly, `add::<i32>(&1, &2)` doesn't generate the error, but even something as simple as `add(&1i32, &2i32)` does.
@gpm helped me investigate the problem and its implications, and noticed that type inference for the function
```Rust
fn add<T, R>(left: T, right: T) -> R
where T: Add<Output = R> {
left + right
}
```
isn't broken. But this doesn't help you if some library crate has defined a type with the problematic impl and you now need to define a function that adds by references instead of moves...
```
$ rustc --version --verbose
rustc 1.23.0
binary: rustc
commit-hash: unknown
commit-date: unknown
host: x86_64-unknown-linux-gnu
release: 1.23.0
LLVM version: 4.0
``` | C-enhancement,A-associated-items,T-lang,A-inference | low | Critical |
302,628,038 | opencv | OE-2 "Maintaining OpenCV 2.x" discussion | the feature request about evolution proposal [OE-2](https://github.com/opencv/opencv/wiki/OE-2.-OpenCV-2) | evolution | low | Minor |
302,629,578 | opencv | OE-11 "Adding Logging" discussion | the feature request about evolution proposal [OE-11](https://github.com/opencv/opencv/wiki/OE-11.-Logging) | evolution | medium | Critical |
302,645,565 | react | For Controlled Input, step does not work as expected unless initialized with null or "". | *BUG*
**What is the current behavior?**
For input type="number", step does not work as expected if there is an initial value set. Step only seems to get honored if the initial value is "" or null.
Example:
https://codepen.io/anon/pen/MQMBmX
The example uses a controlled input binding value and step. Step is 1/10th of the value. If you edit the value in the textbox to 50000 and increment using the stepper, it will increment to 50100 (i.e. by the initial value and not by the current step).
Edit the code so initial value is "" or null. Edit textbox to 50000 and step up - value goes to 55000 as expected.
**What is the expected behavior?**
It should be possible to render a number input that honors step without having to initialize the input component value to null or "" first.
It seems when there is an initial value provided, it will write a value attribute into the DOM (e.g. value="100"). When initial value is "" or null then just the value attribute is written to DOM with no assignment. e.g. (value).
**Which versions of React, and which browser / OS are affected by this issue? Did this work in previous versions of React?**
16.3.0-alpha.1 (ported to this version to confirm if still an issue)
0.14.7 (originally found in this version)
Seems to affect Chrome only (confirmed windows and mac, versions 59 and 64). Bug does not appear in Safari (on a mac at least). | Type: Bug,Component: DOM | low | Critical |
302,663,308 | go | runtime: "runtime: unexpected return pc for testing.tRunner called from 0x0" | Recent iOS crash:
https://build.golang.org/log/7446a26b3c8d6c6016d1abafbc8cd0588baf7a47
Perhaps related to #20846, #23133, #23561.
<details>
````
runtime: unexpected return pc for testing.tRunner called from 0x0
stack: frame={sp:0x130172fa0, fp:0x130172fc0} stack=[0x130172000,0x130173000)
0000000130172ea0: 0000000130030570 0000000000000000
0000000130172eb0: 000000013046a3c0 00000001303ef200
0000000130172ec0: 00000001303ef288 00000001303ef338
0000000130172ed0: 000000013046a418 0000000130465df8
0000000130172ee0: 00000001303c0500 0000000100a7f450
0000000130172ef0: 00000001006e56b4 <testing.tRunner.func1+452> 0000000130465da0
0000000130172f00: 0000000130661f60 000000013038de01
0000000130172f10: 00000001006e56b4 <testing.tRunner.func1+452> 000000013038de00
0000000130172f20: 00000001006e235c <testing.tRunner+220> 0000000130465da0
0000000130172f30: 0000000130661f60 0000000000000000
0000000130172f40: 00000000009e7668 0000000000000000
0000000130172f50: 0000000100653c30 <runtime.sighandler+0> 0000000000000001
0000000130172f60: 0000000100687118 <syscall.Syscall+8> 0000000100a7f510
0000000130172f70: 000000000000000d 0000000000000000
0000000130172f80: 0000000000000000 000000010068712c <syscall.Syscall+28>
0000000130172f90: 0000000000000000 0000000000000000
0000000130172fa0: <0000000000000000 0000000000000000
0000000130172fb0: 0000000000000000 0000000000000000
0000000130172fc0: >0000000000000000 0000000000000000
0000000130172fd0: 0000000000000000 0000000000000000
0000000130172fe0: 0000000130172f70 0000000000000000
0000000130172ff0: 0000000000000000 0000000000000000
fatal error: unknown caller pc
runtime stack:
runtime.throw(0x100a18995, 0x11)
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/runtime/panic.go:616 +0x5c
runtime.gentraceback(0xffffffffffffffff, 0xffffffffffffffff, 0x0, 0x1303ef200, 0x0, 0x0, 0x7fffffff, 0x16fcd2c78, 0x0, 0x0, ...)
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/runtime/traceback.go:302 +0x16a8
runtime.scanstack(0x1303ef200, 0x13002f270)
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/runtime/mgcmark.go:786 +0xdc
runtime.scang(0x1303ef200, 0x13002f270)
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/runtime/proc.go:888 +0x1b8
runtime.markroot.func1()
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/runtime/mgcmark.go:264 +0x58
runtime.markroot(0x13002f270, 0x2e)
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/runtime/mgcmark.go:245 +0x318
runtime.gcDrainN(0x13002f270, 0x5f558, 0x2)
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/runtime/mgcmark.go:1050 +0xe8
runtime.gcAssistAlloc1(0x13013c300, 0x5f558)
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/runtime/mgcmark.go:557 +0x100
runtime.gcAssistAlloc.func1()
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/runtime/mgcmark.go:468 +0x28
runtime.systemstack(0x100000000)
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/runtime/asm_arm64.s:229 +0x8c
runtime.mstart()
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/runtime/proc.go:1170
goroutine 39 [GC assist marking]:
runtime.systemstack_switch()
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/runtime/asm_arm64.s:178 +0x8 fp=0x13004ebb0 sp=0x13004eba0 pc=0x100667f08
runtime.gcAssistAlloc(0x13013c300)
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/runtime/mgcmark.go:467 +0x138 fp=0x13004ebf0 sp=0x13004ebb0 pc=0x100631ff8
runtime.mallocgc(0x84c18, 0x100984b80, 0x13004ec01, 0x1006d7c90)
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/runtime/malloc.go:789 +0x7c4 fp=0x13004eca0 sp=0x13004ebf0 pc=0x100621d34
runtime.makeslice(0x100984b80, 0x84c18, 0x84c18, 0x130572000, 0x1, 0x42418)
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/runtime/slice.go:61 +0x70 fp=0x13004ecd0 sp=0x13004eca0 pc=0x100655530
bytes.makeSlice(0x84c18, 0x0, 0x0, 0x0)
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/bytes/buffer.go:230 +0x54 fp=0x13004ed10 sp=0x13004ecd0 pc=0x1006d7cb4
bytes.(*Buffer).grow(0x13039ee70, 0x3e8, 0x3e8)
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/bytes/buffer.go:144 +0x120 fp=0x13004ed60 sp=0x13004ed10 pc=0x1006d76e0
bytes.(*Buffer).Write(0x13039ee70, 0x1302b5c00, 0x3e8, 0x3e8, 0x3e8, 0x0, 0x0)
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/bytes/buffer.go:174 +0xc0 fp=0x13004ed90 sp=0x13004ed60 pc=0x1006d7990
net/http.TestReadResponseCloseInMiddle(0x130117c20)
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/net/http/response_test.go:651 +0x68 fp=0x13004efa0 sp=0x13004ed90 pc=0x10087f1c8
testing.tRunner(0x130117c20, 0x100a7d6c0)
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/testing/testing.go:788 +0xa8 fp=0x13004efc0 sp=0x13004efa0 pc=0x1006e2328
runtime.goexit()
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/runtime/asm_arm64.s:917 +0x4 fp=0x13004efc0 sp=0x13004efc0 pc=0x10066a474
created by testing.(*T).Run
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/testing/testing.go:835 +0x22c
goroutine 1 [chan receive]:
testing.tRunner.func1(0x130116000)
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/testing/testing.go:764 +0x15c
testing.tRunner(0x130116000, 0x130063dd0)
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/testing/testing.go:794 +0xdc
testing.runTests(0x1300f0500, 0x100cd7760, 0x1c9, 0x1c9, 0x13001f230)
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/testing/testing.go:1076 +0x24c
testing.(*M).Run(0x130110580, 0x0)
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/testing/testing.go:993 +0x148
net/http_test.TestMain(0x130110580)
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/net/http/main_test.go:23 +0x20
main.main()
_testmain.go:1008 +0x148
goroutine 5 [syscall]:
os/signal.signal_recv(0x0)
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/runtime/sigqueue.go:139 +0xc8
os/signal.loop()
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/os/signal/signal_unix.go:22 +0x18
created by os/signal.init.0
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/os/signal/signal_unix.go:28 +0x30
goroutine 256 [chan send]:
testing.tRunner.func1(0x130336ff0)
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/testing/testing.go:783 +0x1c4
testing.tRunner(0x130336ff0, 0x100a7dc20)
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/testing/testing.go:794 +0xdc
created by testing.(*T).Run
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/testing/testing.go:835 +0x22c
goroutine 34 [chan receive]:
testing.(*testContext).waitParallel(0x130114000)
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/testing/testing.go:883 +0x88
testing.(*T).Parallel(0x130117770)
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/testing/testing.go:698 +0x17c
net/http.TestRequestWriteTransport(0x130117770)
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/net/http/requestwrite_test.go:573 +0x28
testing.tRunner(0x130117770, 0x100a7d728)
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/testing/testing.go:788 +0xa8
created by testing.(*T).Run
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/testing/testing.go:835 +0x22c
goroutine 56 [chan send]:
testing.tRunner.func1(0x130214870)
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/testing/testing.go:783 +0x1c4
testing.tRunner(0x130214870, 0x100a7dc70)
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/testing/testing.go:794 +0xdc
created by testing.(*T).Run
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/testing/testing.go:835 +0x22c
goroutine 155 [chan send]:
testing.tRunner.func1(0x1303361e0)
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/testing/testing.go:783 +0x1c4
testing.tRunner(0x1303361e0, 0x100a7db98)
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/testing/testing.go:794 +0xdc
created by testing.(*T).Run
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/testing/testing.go:835 +0x22c
goroutine 348 [chan send]:
testing.tRunner.func1(0x1304704b0)
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/testing/testing.go:783 +0x1c4
testing.tRunner(0x1304704b0, 0x100a7de68)
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/testing/testing.go:794 +0xdc
created by testing.(*T).Run
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/testing/testing.go:835 +0x22c
goroutine 91 [chan send]:
testing.tRunner.func1(0x130214ff0)
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/testing/testing.go:783 +0x1c4
testing.tRunner(0x130214ff0, 0x100a7ddd8)
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/testing/testing.go:794 +0xdc
created by testing.(*T).Run
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/testing/testing.go:835 +0x22c
goroutine 195 [select]:
net/http.(*Transport).getConn(0x1304411d0, 0x130114ba0, 0x0, 0x1303b5040, 0x5, 0x1304941e0, 0xf, 0x0, 0x0, 0x0)
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/net/http/transport.go:962 +0x3b8
net/http.(*Transport).RoundTrip(0x1304411d0, 0x130452900, 0x1304411d0, 0x0, 0x0)
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/net/http/transport.go:409 +0x454
net/http.send(0x130452900, 0x100abd440, 0x1304411d0, 0x0, 0x0, 0x0, 0x0, 0x130662220, 0x1303b5000, 0x1008291e0)
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/net/http/client.go:252 +0xec
net/http.(*Client).send(0x1302d9470, 0x130452900, 0x0, 0x0, 0x0, 0x130662220, 0x0, 0x1, 0x1)
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/net/http/client.go:176 +0xc4
net/http.(*Client).Do(0x1302d9470, 0x130452900, 0x1303b5040, 0x17, 0x0)
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/net/http/client.go:615 +0x1f4
net/http.(*Client).Get(0x1302d9470, 0x1303b5040, 0x17, 0x1304acd80, 0x0, 0x0)
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/net/http/client.go:396 +0x74
net/http_test.TestClientInsecureTransport(0x13038c0f0)
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/net/http/client_test.go:864 +0x1ec
testing.tRunner(0x13038c0f0, 0x100a7db88)
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/testing/testing.go:788 +0xa8
created by testing.(*T).Run
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/testing/testing.go:835 +0x22c
goroutine 157 [chan send]:
testing.tRunner.func1(0x1303363c0)
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/testing/testing.go:783 +0x1c4
testing.tRunner(0x1303363c0, 0x100a7e338)
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/testing/testing.go:794 +0xdc
created by testing.(*T).Run
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/testing/testing.go:835 +0x22c
goroutine 253 [chan send]:
testing.tRunner.func1(0x130336d20)
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/testing/testing.go:783 +0x1c4
testing.tRunner(0x130336d20, 0x100a7dd70)
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/testing/testing.go:794 +0xdc
created by testing.(*T).Run
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/testing/testing.go:835 +0x22c
goroutine 94 [chan send]:
testing.tRunner.func1(0x1302152c0)
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/testing/testing.go:783 +0x1c4
testing.tRunner(0x1302152c0, 0x100a7dbf8)
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/testing/testing.go:794 +0xdc
created by testing.(*T).Run
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/testing/testing.go:835 +0x22c
goroutine 154 [chan send]:
testing.tRunner.func1(0x1303360f0)
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/testing/testing.go:783 +0x1c4
testing.tRunner(0x1303360f0, 0x100a7dba8)
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/testing/testing.go:794 +0xdc
created by testing.(*T).Run
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/testing/testing.go:835 +0x22c
goroutine 95 [chan send]:
testing.tRunner.func1(0x1302153b0)
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/testing/testing.go:783 +0x1c4
testing.tRunner(0x1302153b0, 0x100a7dbb8)
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/testing/testing.go:794 +0xdc
created by testing.(*T).Run
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/testing/testing.go:835 +0x22c
goroutine 153 [chan send]:
testing.tRunner.func1(0x130336000)
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/testing/testing.go:783 +0x1c4
testing.tRunner(0x130336000, 0x100a7dbf0)
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/testing/testing.go:794 +0xdc
created by testing.(*T).Run
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/testing/testing.go:835 +0x22c
goroutine 368 [chan send]:
testing.tRunner.func1(0x1304900f0)
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/testing/testing.go:783 +0x1c4
testing.tRunner(0x1304900f0, 0x100a7de98)
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/testing/testing.go:794 +0xdc
created by testing.(*T).Run
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/testing/testing.go:835 +0x22c
goroutine 364 [chan send]:
testing.tRunner.func1(0x13038dd10)
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/testing/testing.go:783 +0x1c4
testing.tRunner(0x13038dd10, 0x100a7de20)
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/testing/testing.go:794 +0xdc
created by testing.(*T).Run
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/testing/testing.go:835 +0x22c
goroutine 274 [chan send]:
testing.tRunner.func1(0x1303371d0)
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/testing/testing.go:783 +0x1c4
testing.tRunner(0x1303371d0, 0x100a7dc10)
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/testing/testing.go:794 +0xdc
created by testing.(*T).Run
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/testing/testing.go:835 +0x22c
goroutine 363 [chan send]:
testing.tRunner.func1(0x13038dc20)
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/testing/testing.go:783 +0x1c4
testing.tRunner(0x13038dc20, 0x100a7dee8)
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/testing/testing.go:794 +0xdc
created by testing.(*T).Run
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/testing/testing.go:835 +0x22c
goroutine 349 [chan send]:
testing.tRunner.func1(0x1304705a0)
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/testing/testing.go:783 +0x1c4
testing.tRunner(0x1304705a0, 0x100a7dde8)
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/testing/testing.go:794 +0xdc
created by testing.(*T).Run
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/testing/testing.go:835 +0x22c
goroutine 276 [chan send]:
testing.tRunner.func1(0x1303373b0)
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/testing/testing.go:783 +0x1c4
testing.tRunner(0x1303373b0, 0x100a7dc08)
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/testing/testing.go:794 +0xdc
created by testing.(*T).Run
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/testing/testing.go:835 +0x22c
goroutine 367 [chan send]:
testing.tRunner.func1(0x130490000)
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/testing/testing.go:783 +0x1c4
testing.tRunner(0x130490000, 0x100a7de90)
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/testing/testing.go:794 +0xdc
created by testing.(*T).Run
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/testing/testing.go:835 +0x22c
goroutine 257 [chan send]:
testing.tRunner.func1(0x1303370e0)
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/testing/testing.go:783 +0x1c4
testing.tRunner(0x1303370e0, 0x100a7dc28)
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/testing/testing.go:794 +0xdc
created by testing.(*T).Run
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/testing/testing.go:835 +0x22c
goroutine 277 [chan send]:
testing.tRunner.func1(0x1303374a0)
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/testing/testing.go:783 +0x1c4
testing.tRunner(0x1303374a0, 0x100a7dbc0)
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/testing/testing.go:794 +0xdc
created by testing.(*T).Run
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/testing/testing.go:835 +0x22c
goroutine 350 [chan send]:
testing.tRunner.func1(0x130470690)
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/testing/testing.go:783 +0x1c4
testing.tRunner(0x130470690, 0x100a7def0)
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/testing/testing.go:794 +0xdc
created by testing.(*T).Run
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/testing/testing.go:835 +0x22c
goroutine 275 [chan send]:
testing.tRunner.func1(0x1303372c0)
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/testing/testing.go:783 +0x1c4
testing.tRunner(0x1303372c0, 0x100a7dc18)
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/testing/testing.go:794 +0xdc
created by testing.(*T).Run
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/testing/testing.go:835 +0x22c
goroutine 278 [chan send]:
testing.tRunner.func1(0x130337590)
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/testing/testing.go:783 +0x1c4
testing.tRunner(0x130337590, 0x100a7dbc8)
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/testing/testing.go:794 +0xdc
created by testing.(*T).Run
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/testing/testing.go:835 +0x22c
goroutine 273 [chan send]:
testing.tRunner.func1(0x13038d0e0)
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/testing/testing.go:783 +0x1c4
testing.tRunner(0x13038d0e0, 0x100a7dbe8)
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/testing/testing.go:794 +0xdc
created by testing.(*T).Run
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/testing/testing.go:835 +0x22c
goroutine 351 [chan send]:
testing.tRunner.func1(0x130470780)
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/testing/testing.go:783 +0x1c4
testing.tRunner(0x130470780, 0x100a7def8)
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/testing/testing.go:794 +0xdc
created by testing.(*T).Run
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/testing/testing.go:835 +0x22c
goroutine 352 [chan send]:
testing.tRunner.func1(0x130470870)
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/testing/testing.go:783 +0x1c4
testing.tRunner(0x130470870, 0x100a7df00)
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/testing/testing.go:794 +0xdc
created by testing.(*T).Run
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/testing/testing.go:835 +0x22c
goroutine 347 [chan send]:
testing.tRunner.func1(0x1304703c0)
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/testing/testing.go:783 +0x1c4
testing.tRunner(0x1304703c0, 0x100a7de88)
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/testing/testing.go:794 +0xdc
created by testing.(*T).Run
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/testing/testing.go:835 +0x22c
goroutine 322 [chan send]:
testing.tRunner.func1(0x13038d1d0)
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/testing/testing.go:783 +0x1c4
testing.tRunner(0x13038d1d0, 0x100a7e930)
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/testing/testing.go:794 +0xdc
created by testing.(*T).Run
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/testing/testing.go:835 +0x22c
goroutine 366 [chan send]:
testing.tRunner.func1(0x13038def0)
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/testing/testing.go:783 +0x1c4
testing.tRunner(0x13038def0, 0x100a7de40)
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/testing/testing.go:794 +0xdc
created by testing.(*T).Run
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/testing/testing.go:835 +0x22c
goroutine 365 [chan send (scan)]:
testing.tRunner.func1(0x0)
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/testing/testing.go:783 +0x1c4
fatal error: unexpected signal during runtime execution
panic during panic
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x100661440]
runtime stack:
runtime.startpanic_m()
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/runtime/panic.go:690 +0x16c
runtime.startpanic()
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/runtime/panic.go:589 +0x14
runtime.throw(0x100a2cb7a, 0x2a)
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/runtime/panic.go:615 +0x54
runtime.sigpanic()
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/runtime/signal_unix.go:372 +0x23c
runtime.gentraceback(0xffffffffffffffff, 0xffffffffffffffff, 0x0, 0x1303ef200, 0x0, 0x0, 0x64, 0x0, 0x0, 0x0, ...)
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/runtime/traceback.go:290 +0x10cc
runtime.traceback1(0xffffffffffffffff, 0xffffffffffffffff, 0x0, 0x1303ef200, 0x0)
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/runtime/traceback.go:729 +0xbc
runtime.traceback(0xffffffffffffffff, 0xffffffffffffffff, 0x0, 0x1303ef200)
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/runtime/traceback.go:690 +0x3c
runtime.tracebackothers(0x13013cc00)
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/runtime/traceback.go:879 +0x194
runtime.dopanic_m(0x13013cc00, 0x10064079c, 0x16fcd27a0)
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/runtime/panic.go:736 +0x270
runtime.dopanic.func1()
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/runtime/panic.go:598 +0x30
runtime.dopanic(0x0)
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/runtime/panic.go:597 +0x34
runtime.throw(0x100a18995, 0x11)
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/runtime/panic.go:616 +0x5c
runtime.gentraceback(0xffffffffffffffff, 0xffffffffffffffff, 0x0, 0x1303ef200, 0x0, 0x0, 0x7fffffff, 0x16fcd2c78, 0x0, 0x0, ...)
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/runtime/traceback.go:302 +0x16a8
runtime.scanstack(0x1303ef200, 0x13002f270)
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/runtime/mgcmark.go:786 +0xdc
runtime.scang(0x1303ef200, 0x13002f270)
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/runtime/proc.go:888 +0x1b8
runtime.markroot.func1()
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/runtime/mgcmark.go:264 +0x58
runtime.markroot(0x13002f270, 0x2e)
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/runtime/mgcmark.go:245 +0x318
runtime.gcDrainN(0x13002f270, 0x5f558, 0x2)
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/runtime/mgcmark.go:1050 +0xe8
runtime.gcAssistAlloc1(0x13013c300, 0x5f558)
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/runtime/mgcmark.go:557 +0x100
runtime.gcAssistAlloc.func1()
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/runtime/mgcmark.go:468 +0x28
runtime.systemstack(0x100000000)
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/runtime/asm_arm64.s:229 +0x8c
runtime.mstart()
/private/var/folders/f6/d2bhfqss2716nxm8gkv1fmb80000gn/T/workdir-host-darwin-amd64-eliasnaur-ios/go/src/runtime/proc.go:1170
Process 518 exited with status = 2 (0x00000002)
go_darwin_arm_exec: test timeout (test completion)
FAIL net/http 392.050s
````
</details> | OS-Windows,NeedsInvestigation,mobile | low | Critical |
302,705,831 | rust | Better unused variable warning | Given the code:
```
fn main() {
let best = [1, 2, 3]
.iter()
.enumerate()
.min_by_key(|&(i, f)| f);
println!("{:?}", best);
}
```
The last Nighly rustc gives the warning:
```
warning: unused variable: `i`
--> ...\test.rs:5:31
|
5 | .min_by_key(|&(i, f)| f);
| ^ help: consider using `_i` instead
|
= note: #[warn(unused_variables)] on by default
```
But I think it's better to suggest the programmer to use write `_` instead of `_i`.
| C-enhancement,A-lints,A-diagnostics,T-compiler | low | Minor |
302,725,396 | flutter | "flutter uninstall" to delete flutter and all related cache files | Hey
How do you properly uninstall flutter and all flutter dependencies and flutter libraries?
It copies a lot of content in the file system.
I am on ubuntu 16.04.
| c: new feature,tool,P3,team-tool,triaged-tool | medium | Major |
302,726,722 | flutter | Better error message when adding Futures into the widget tree | EDIT: It seems I must use setState() for it to work. Not directly returning from the async function. But still I think a better error message is needed.
## Steps to Reproduce
```dart
import 'package:flutter/material.dart';
import 'dart:io';
import 'dart:convert';
class Report extends StatelessWidget {
makeRequest() async {
var _httpClient = new HttpClient();
try {
return 'OK';
} catch (exception) {
return 'OH NO!';
}
}
@override
Widget build(BuildContext context) {
return new Text(makeRequest());
}
}
```
## Logs
<details>
<summary> Logs</summary>
```
I/flutter ( 4208): ══╡ EXCEPTION CAUGHT BY WIDGETS LIBRARY ╞═══════════════════════════════════════════════════════════
[ +3 ms] I/flutter ( 4208): The following assertion was thrown building Report(dirty):
[ ] I/flutter ( 4208): type '_Future' is not a subtype of type 'String' of 'data' where
[ ] I/flutter ( 4208): _Future is from dart:async
[ ] I/flutter ( 4208): String is from dart:core
[ +32 ms] I/flutter ( 4208): Either the assertion indicates an error in the framework itself, or we should provide substantially
[ ] I/flutter ( 4208): more information in this error message to help you determine and fix the underlying cause.
[ ] I/flutter ( 4208): In either case, please report this assertion by filing a bug on GitHub:
[ ] I/flutter ( 4208): https://github.com/flutter/flutter/issues/new
[ ] I/flutter ( 4208): When the exception was thrown, this was the stack:
[ +10 ms] I/flutter ( 4208): #0 new Text (package:flutter/src/widgets/text.dart:203)
[ ] I/flutter ( 4208): #1 Report.build (file:///Users/gorjan/Projects/aero/lib/widgets/Report.dart:32)
[ ] I/flutter ( 4208): #2 StatelessElement.build (package:flutter/src/widgets/framework.dart:3678)
[ +10 ms] I/flutter ( 4208): #3 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:3625)
[ ] I/flutter ( 4208): #4 Element.rebuild (package:flutter/src/widgets/framework.dart:3478)
[ ] I/flutter ( 4208): #5 ComponentElement._firstBuild (package:flutter/src/widgets/framework.dart:3605)
[ ] I/flutter ( 4208): #6 ComponentElement.mount (package:flutter/src/widgets/framework.dart:3600)
[ ] I/flutter ( 4208): #7 Element.inflateWidget (package:flutter/src/widgets/framework.dart:2890)
[ ] I/flutter ( 4208): #8 Element.updateChild (package:flutter/src/widgets/framework.dart:2693)
[ ] I/flutter ( 4208): #9 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:3636)
[ +10 ms] I/flutter ( 4208): #10 Element.rebuild (package:flutter/src/widgets/framework.dart:3478)
[ ] I/flutter ( 4208): #11 ComponentElement._firstBuild (package:flutter/src/widgets/framework.dart:3605)
[ ] I/flutter ( 4208): #12 ComponentElement.mount (package:flutter/src/widgets/framework.dart:3600)
[ ] I/flutter ( 4208): #13 Element.inflateWidget (package:flutter/src/widgets/framework.dart:2890)
[ ] I/flutter ( 4208): #14 Element.updateChild (package:flutter/src/widgets/framework.dart:2693)
[ ] I/flutter ( 4208): #15 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:3636)
[ ] I/flutter ( 4208): #16 Element.rebuild (package:flutter/src/widgets/framework.dart:3478)
[ ] I/flutter ( 4208): #17 ComponentElement._firstBuild (package:flutter/src/widgets/framework.dart:3605)
[ ] I/flutter ( 4208): #18 ComponentElement.mount (package:flutter/src/widgets/framework.dart:3600)
[ ] I/flutter ( 4208): #19 ParentDataElement.mount (package:flutter/src/widgets/framework.dart:3916)
[ ] I/flutter ( 4208): #20 Element.inflateWidget (package:flutter/src/widgets/framework.dart:2890)
[ ] I/flutter ( 4208): #21 MultiChildRenderObjectElement.mount (package:flutter/src/widgets/framework.dart:4716)
[ ] I/flutter ( 4208): #22 Element.inflateWidget (package:flutter/src/widgets/framework.dart:2890)
[ ] I/flutter ( 4208): #23 Element.updateChild (package:flutter/src/widgets/framework.dart:2693)
[ ] I/flutter ( 4208): #24 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:3636)
[ ] I/flutter ( 4208): #25 Element.rebuild (package:flutter/src/widgets/framework.dart:3478)
[ ] I/flutter ( 4208): #26 ComponentElement._firstBuild (package:flutter/src/widgets/framework.dart:3605)
[ ] I/flutter ( 4208): #27 ComponentElement.mount (package:flutter/src/widgets/framework.dart:3600)
[ ] I/flutter ( 4208): #28 Element.inflateWidget (package:flutter/src/widgets/framework.dart:2890)
[ ] I/flutter ( 4208): #29 Element.updateChild (package:flutter/src/widgets/framework.dart:2693)
[ ] I/flutter ( 4208): #30 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:3636)
[ ] I/flutter ( 4208): #31 Element.rebuild (package:flutter/src/widgets/framework.dart:3478)
[ ] I/flutter ( 4208): #32 ComponentElement._firstBuild (package:flutter/src/widgets/framework.dart:3605)
[ ] I/flutter ( 4208): #33 StatefulElement._firstBuild (package:flutter/src/widgets/framework.dart:3741)
[ ] I/flutter ( 4208): #34 ComponentElement.mount (package:flutter/src/widgets/framework.dart:3600)
[ ] I/flutter ( 4208): #35 Element.inflateWidget (package:flutter/src/widgets/framework.dart:2890)
[ ] I/flutter ( 4208): #36 Element.updateChild (package:flutter/src/widgets/framework.dart:2693)
[ ] I/flutter ( 4208): #37 SingleChildRenderObjectElement.mount (package:flutter/src/widgets/framework.dart:4611)
[ ] I/flutter ( 4208): #38 Element.inflateWidget (package:flutter/src/widgets/framework.dart:2890)
[ ] I/flutter ( 4208): #39 Element.updateChild (package:flutter/src/widgets/framework.dart:2693)
[ ] I/flutter ( 4208): #40 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:3636)
[ ] I/flutter ( 4208): #41 Element.rebuild (package:flutter/src/widgets/framework.dart:3478)
[ ] I/flutter ( 4208): #42 ComponentElement._firstBuild (package:flutter/src/widgets/framework.dart:3605)
[ ] I/flutter ( 4208): #43 ComponentElement.mount (package:flutter/src/widgets/framework.dart:3600)
[ ] I/flutter ( 4208): #44 Element.inflateWidget (package:flutter/src/widgets/framework.dart:2890)
[ ] I/flutter ( 4208): #45 Element.updateChild (package:flutter/src/widgets/framework.dart:2693)
[ ] I/flutter ( 4208): #46 SingleChildRenderObjectElement.mount (package:flutter/src/widgets/framework.dart:4611)
[ ] I/flutter ( 4208): #47 Element.inflateWidget (package:flutter/src/widgets/framework.dart:2890)
[ ] I/flutter ( 4208): #48 Element.updateChild (package:flutter/src/widgets/framework.dart:2693)
[ ] I/flutter ( 4208): #49 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:3636)
[ ] I/flutter ( 4208): #50 Element.rebuild (package:flutter/src/widgets/framework.dart:3478)
[ ] I/flutter ( 4208): #51 ComponentElement._firstBuild (package:flutter/src/widgets/framework.dart:3605)
[ ] I/flutter ( 4208): #52 StatefulElement._firstBuild (package:flutter/src/widgets/framework.dart:3741)
[ ] I/flutter ( 4208): #53 ComponentElement.mount (package:flutter/src/widgets/framework.dart:3600)
[ ] I/flutter ( 4208): #54 Element.inflateWidget (package:flutter/src/widgets/framework.dart:2890)
[ ] I/flutter ( 4208): #55 Element.updateChild (package:flutter/src/widgets/framework.dart:2693)
[ ] I/flutter ( 4208): #56 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:3636)
[ ] I/flutter ( 4208): #57 Element.rebuild (package:flutter/src/widgets/framework.dart:3478)
[ ] I/flutter ( 4208): #58 ComponentElement._firstBuild (package:flutter/src/widgets/framework.dart:3605)
[ ] I/flutter ( 4208): #59 StatefulElement._firstBuild (package:flutter/src/widgets/framework.dart:3741)
[ ] I/flutter ( 4208): #60 ComponentElement.mount (package:flutter/src/widgets/framework.dart:3600)
[ ] I/flutter ( 4208): #61 Element.inflateWidget (package:flutter/src/widgets/framework.dart:2890)
[ ] I/flutter ( 4208): #62 Element.updateChild (package:flutter/src/widgets/framework.dart:2693)
[ ] I/flutter ( 4208): #63 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:3636)
[ ] I/flutter ( 4208): #64 Element.rebuild (package:flutter/src/widgets/framework.dart:3478)
[ ] I/flutter ( 4208): #65 ComponentElement._firstBuild (package:flutter/src/widgets/framework.dart:3605)
[ ] I/flutter ( 4208): #66 ComponentElement.mount (package:flutter/src/widgets/framework.dart:3600)
[ ] I/flutter ( 4208): #67 Element.inflateWidget (package:flutter/src/widgets/framework.dart:2890)
[ ] I/flutter ( 4208): #68 Element.updateChild (package:flutter/src/widgets/framework.dart:2693)
[ ] I/flutter ( 4208): #69 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:3636)
[ ] I/flutter ( 4208): #70 Element.rebuild (package:flutter/src/widgets/framework.dart:3478)
[ ] I/flutter ( 4208): #71 ComponentElement._firstBuild (package:flutter/src/widgets/framework.dart:3605)
[ ] I/flutter ( 4208): #72 ComponentElement.mount (package:flutter/src/widgets/framework.dart:3600)
[ ] I/flutter ( 4208): #73 Element.inflateWidget (package:flutter/src/widgets/framework.dart:2890)
[ ] I/flutter ( 4208): #74 Element.updateChild (package:flutter/src/widgets/framework.dart:2693)
[ ] I/flutter ( 4208): #75 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:3636)
[ ] I/flutter ( 4208): #76 Element.rebuild (package:flutter/src/widgets/framework.dart:3478)
[ ] I/flutter ( 4208): #77 ComponentElement._firstBuild (package:flutter/src/widgets/framework.dart:3605)
[ ] I/flutter ( 4208): #78 StatefulElement._firstBuild (package:flutter/src/widgets/framework.dart:3741)
[ ] I/flutter ( 4208): #79 ComponentElement.mount (package:flutter/src/widgets/framework.dart:3600)
[ ] I/flutter ( 4208): #80 Element.inflateWidget (package:flutter/src/widgets/framework.dart:2890)
[ ] I/flutter ( 4208): #81 Element.updateChild (package:flutter/src/widgets/framework.dart:2693)
[ ] I/flutter ( 4208): #82 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:3636)
[ ] I/flutter ( 4208): #83 Element.rebuild (package:flutter/src/widgets/framework.dart:3478)
[ ] I/flutter ( 4208): #84 ComponentElement._firstBuild (package:flutter/src/widgets/framework.dart:3605)
[ ] I/flutter ( 4208): #85 StatefulElement._firstBuild (package:flutter/src/widgets/framework.dart:3741)
[ ] I/flutter ( 4208): #86 ComponentElement.mount (package:flutter/src/widgets/framework.dart:3600)
[ ] I/flutter ( 4208): #87 Element.inflateWidget (package:flutter/src/widgets/framework.dart:2890)
[ ] I/flutter ( 4208): #88 Element.updateChild (package:flutter/src/widgets/framework.dart:2693)
[ ] I/flutter ( 4208): #89 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:3636)
[ ] I/flutter ( 4208): #90 Element.rebuild (package:flutter/src/widgets/framework.dart:3478)
[ ] I/flutter ( 4208): #91 ComponentElement._firstBuild (package:flutter/src/widgets/framework.dart:3605)
[ ] I/flutter ( 4208): #92 ComponentElement.mount (package:flutter/src/widgets/framework.dart:3600)
[ ] I/flutter ( 4208): #93 Element.inflateWidget (package:flutter/src/widgets/framework.dart:2890)
[ ] I/flutter ( 4208): #94 Element.updateChild (package:flutter/src/widgets/framework.dart:2693)
[ ] I/flutter ( 4208): #95 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:3636)
[ ] I/flutter ( 4208): #96 Element.rebuild (package:flutter/src/widgets/framework.dart:3478)
[ ] I/flutter ( 4208): #97 ComponentElement._firstBuild (package:flutter/src/widgets/framework.dart:3605)
[ ] I/flutter ( 4208): #98 ComponentElement.mount (package:flutter/src/widgets/framework.dart:3600)
[ ] I/flutter ( 4208): #99 Element.inflateWidget (package:flutter/src/widgets/framework.dart:2890)
[ ] I/flutter ( 4208): #100 Element.updateChild (package:flutter/src/widgets/framework.dart:2693)
[ ] I/flutter ( 4208): #101 SingleChildRenderObjectElement.mount (package:flutter/src/widgets/framework.dart:4611)
[ ] I/flutter ( 4208): #102 Element.inflateWidget (package:flutter/src/widgets/framework.dart:2890)
[ ] I/flutter ( 4208): #103 Element.updateChild (package:flutter/src/widgets/framework.dart:2693)
[ ] I/flutter ( 4208): #104 SingleChildRenderObjectElement.mount (package:flutter/src/widgets/framework.dart:4611)
[ ] I/flutter ( 4208): #105 Element.inflateWidget (package:flutter/src/widgets/framework.dart:2890)
[ ] I/flutter ( 4208): #106 Element.updateChild (package:flutter/src/widgets/framework.dart:2693)
[ ] I/flutter ( 4208): #107 SingleChildRenderObjectElement.mount (package:flutter/src/widgets/framework.dart:4611)
[ ] I/flutter ( 4208): #108 Element.inflateWidget (package:flutter/src/widgets/framework.dart:2890)
[ ] I/flutter ( 4208): #109 Element.updateChild (package:flutter/src/widgets/framework.dart:2693)
[ ] I/flutter ( 4208): #110 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:3636)
[ ] I/flutter ( 4208): #111 Element.rebuild (package:flutter/src/widgets/framework.dart:3478)
[ ] I/flutter ( 4208): #112 ComponentElement._firstBuild (package:flutter/src/widgets/framework.dart:3605)
[ ] I/flutter ( 4208): #113 StatefulElement._firstBuild (package:flutter/src/widgets/framework.dart:3741)
[ ] I/flutter ( 4208): #114 ComponentElement.mount (package:flutter/src/widgets/framework.dart:3600)
[ ] I/flutter ( 4208): #115 Element.inflateWidget (package:flutter/src/widgets/framework.dart:2890)
[ ] I/flutter ( 4208): #116 Element.updateChild (package:flutter/src/widgets/framework.dart:2693)
[ ] I/flutter ( 4208): #117 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:3636)
[ ] I/flutter ( 4208): #118 Element.rebuild (package:flutter/src/widgets/framework.dart:3478)
[ ] I/flutter ( 4208): #119 ComponentElement._firstBuild (package:flutter/src/widgets/framework.dart:3605)
[ ] I/flutter ( 4208): #120 ComponentElement.mount (package:flutter/src/widgets/framework.dart:3600)
[ ] I/flutter ( 4208): #121 Element.inflateWidget (package:flutter/src/widgets/framework.dart:2890)
[ ] I/flutter ( 4208): #122 Element.updateChild (package:flutter/src/widgets/framework.dart:2693)
[ ] I/flutter ( 4208): #123 SingleChildRenderObjectElement.mount (package:flutter/src/widgets/framework.dart:4611)
[ ] I/flutter ( 4208): #124 Element.inflateWidget (package:flutter/src/widgets/framework.dart:2890)
[ ] I/flutter ( 4208): #125 Element.updateChild (package:flutter/src/widgets/framework.dart:2693)
[ ] I/flutter ( 4208): #126 SingleChildRenderObjectElement.mount (package:flutter/src/widgets/framework.dart:4611)
[ ] I/flutter ( 4208): #127 Element.inflateWidget (package:flutter/src/widgets/framework.dart:2890)
[ ] I/flutter ( 4208): #128 Element.updateChild (package:flutter/src/widgets/framework.dart:2693)
[ ] I/flutter ( 4208): #129 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:3636)
[ ] I/flutter ( 4208): #130 Element.rebuild (package:flutter/src/widgets/framework.dart:3478)
[ ] I/flutter ( 4208): #131 ComponentElement._firstBuild (package:flutter/src/widgets/framework.dart:3605)
[ ] I/flutter ( 4208): #132 ComponentElement.mount (package:flutter/src/widgets/framework.dart:3600)
[ ] I/flutter ( 4208): #133 Element.inflateWidget (package:flutter/src/widgets/framework.dart:2890)
[ ] I/flutter ( 4208): #134 Element.updateChild (package:flutter/src/widgets/framework.dart:2693)
[ ] I/flutter ( 4208): #135 SingleChildRenderObjectElement.mount (package:flutter/src/widgets/framework.dart:4611)
[ ] I/flutter ( 4208): #136 Element.inflateWidget (package:flutter/src/widgets/framework.dart:2890)
[ ] I/flutter ( 4208): #137 Element.updateChild (package:flutter/src/widgets/framework.dart:2693)
[ ] I/flutter ( 4208): #138 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:3636)
[ ] I/flutter ( 4208): #139 Element.rebuild (package:flutter/src/widgets/framework.dart:3478)
[ ] I/flutter ( 4208): #140 ComponentElement._firstBuild (package:flutter/src/widgets/framework.dart:3605)
[ ] I/flutter ( 4208): #141 StatefulElement._firstBuild (package:flutter/src/widgets/framework.dart:3741)
[ ] I/flutter ( 4208): #142 ComponentElement.mount (package:flutter/src/widgets/framework.dart:3600)
[ ] I/flutter ( 4208): #143 Element.inflateWidget (package:flutter/src/widgets/framework.dart:2890)
```
</details>
## Flutter Doctor
```
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel beta, v0.1.5, on Mac OS X 10.13.3 17D102, locale en-MK)
[✓] Android toolchain - develop for Android devices (Android SDK 27.0.3)
[✓] iOS toolchain - develop for iOS devices (Xcode 9.2)
[✓] Android Studio (version 3.0)
[✓] VS Code (version 1.20.1)
[✓] Connected devices (1 available)
• No issues found!
``` | framework,dependency: dart,d: api docs,has reproducible steps,P3,found in release: 3.0,found in release: 3.1,team-framework,triaged-framework | low | Critical |
302,737,845 | opencv | OE-15 "Bit-exactness" discussion | the feature request about evolution proposal [OE-15](https://github.com/opencv/opencv/wiki/OE-15.-Bit-Exactness) | evolution | low | Minor |
302,738,248 | opencv | OE-16 "Mini Halide" discussion | the feature request about evolution proposal [OE-16](https://github.com/opencv/opencv/wiki/OE-16.-Mini-Halide) | evolution | low | Minor |
302,738,881 | opencv | OE-17 "New Filter Engine" discussion | the feature request about evolution proposal [OE-17](https://github.com/opencv/opencv/wiki/OE-17.-New-Filter-Engine) | evolution | low | Major |
302,739,262 | opencv | OE-18 "Module OptFlow" discussion | the feature request about evolution proposal [OE-18](https://github.com/opencv/opencv/wiki/OE-18.-Module-Optflow) | evolution | low | Minor |
302,739,866 | opencv | OE-19 "Stereo Module" discussion | the feature request about evolution proposal [OE-19](https://github.com/opencv/opencv/wiki/OE-19.-Module-Stereo) | evolution | low | Minor |
302,740,117 | opencv | OE-20 "Calibration Module" discussion | the feature request about evolution proposal [OE-20](https://github.com/opencv/opencv/wiki/OE-20.-Module-Calibration) | evolution | low | Minor |
302,742,061 | opencv | OE-24 "Revised HighGUI Module" discussion | the feature request about evolution proposal [OE-24](https://github.com/opencv/opencv/wiki/OE-24.-Module-HighGUI) | evolution | medium | Major |
302,742,518 | opencv | OE-25 "Hardware-accelerated Video I/O Module" discussion | the feature request about evolution proposal [OE-25](https://github.com/opencv/opencv/wiki/OE-25.-Fast-VideoIO) | evolution | low | Minor |
302,742,866 | opencv | OE-26 "Revise Samples" discussion | the feature request about evolution proposal [OE-26](https://github.com/opencv/opencv/wiki/OE-26.-Samples) | evolution | low | Minor |
302,743,159 | opencv | OE-27 "Wide Universal Intrinsics" discussion | the feature request about evolution proposal [OE-27](https://github.com/opencv/opencv/wiki/OE-27.-Wide-Universal-Intrinsics) | evolution | low | Major |
302,767,570 | opencv | OE-4 "OpenCV 4.0" discussion | the feature request about evolution proposal [OE-4](https://github.com/opencv/opencv/wiki/OE-4.-OpenCV-4) | evolution | medium | Major |
302,820,173 | TypeScript | Don't offer to infer parameter type if inferred type is 'any' | **TypeScript Version:** 2.8.0-dev.20180302
**Code**
```ts
function f(x) {}
function g(x) {
f(x);
}
```
Click on first `x`.
**Expected behavior:**
No suggestion.
**Actual behavior:**
Suggestion to "infer parameter types from usage", which just adds `: any`. | Bug,Domain: Quick Fixes | low | Minor |
302,831,412 | create-react-app | Base configuration file query | Wouldn't it be better for the default configuration after ejecting to inherit from a base Webpack configuration file and then have the development / production configurations merge off of the base configuration. Looking at the default generated files created by create-react-app after ejecting, I can see that there is a lot of duplication between `webpack.config.dev.js` and `webpack.config.prod.js`. Any reasons why it was written in this manner originally or why we can't move towards a base configuration file?
Apologies if this issue / question has been lodged before. Tried my best to find similar issues! | issue: proposal,difficulty: medium | low | Minor |
302,849,125 | go | cmd/go: test gives go/parser's syntax errors, which are sometimes worse than the compiler's | ```
$ cat f3.go
package main
func f(x int) int {
retrun x
}
$ go run f3.go
# command-line-arguments
./f3.go:4:9: syntax error: unexpected x at end of statement
$ gofmt f3.go
f3.go:4:9: expected ';', found x
f3.go:5:3: expected '}', found 'EOF'
```
I would usually not mind if go/parser is worse than the compiler's parser at giving useful errors. However, now that vet always runs with test, it's vet that reports syntax errors to me when I run `go test`. This particular error (the more confusing one) had me scratching my head for a minute, before I realised the typo.
Should this be fixed in go/parser, or should something else be done, such as using the compiler's syntax package to replace go/parser's syntax errors?
/cc @griesemer | NeedsFix | low | Critical |
302,879,005 | go | proposal: spec: improve for-loop ergonomics | Motivation
----------
Go's for-loops encourage difficult-to-read code.
1. The Go 1 loop syntax sets the wrong defaults. The syntax is optimized for three-part [`ForClause`](https://golang.org/ref/spec#ForClause) loops, but `range` loops are far more common (by a ratio of nearly 4:1 in the code I sampled) and arguably ought to be viewed as the “default”.
* The three-part `ForClause` form is nearly always used for iterating one variable over sequential integers. That puts the interesting part — the condition — in the middle, where it is the hardest to find.
(For the rare other cases, it is always possible to express a three-part `ForClause` as an equivalent one-part `ForClause` with an extra scope block. Loops that use `continue` require care, but `continue` in a three-part non-integer loop is especially rare.)
* Nothing else in the language has a three-part form, and the existence of the three-part `for` loop precludes a more useful two-part alternative (for APIs such as `io.Reader`), because it would be too easy to confuse a two-part loop with a three-part one.
2. The `range` keyword is confusing to newcomers.
* In set theory, [_range_](http://mathworld.wolfram.com/Range.html) means "image" or "codomain", but the single-value version of a Go 1 `range` loop instead iterates over the _domain_ of the slice, map, or array. That makes the single-value form confusing, especially when the index and element types are mutually assignable (https://play.golang.org/p/c-lWoTI_Z-Y) or when the value is used as an `interface{}` (https://play.golang.org/p/cqZPSHZtuwH).
* In some other programming languages (such as Python), `range` refers to a sequence of points in a numerical interval, evoking [line segment range](http://mathworld.wolfram.com/LineSegmentRange.html) or [statistical range](http://mathworld.wolfram.com/StatisticalRange.html). In contrast, the Go `range` keyword doesn't have anything to do with numerical intervals, except to the extent that slice indices happen to be intervals.
* The fact that `range` modifies the semantics of `:=` and `=` is surprising. The only other Go operator that modifies the semantics of another operator is `=` itself, which (beyond the `, ok` idiom) modifies the semantics of the index operator (`[]`) for map assignments. (I think we should fix that too; see https://github.com/golang/go/issues/20660#issuecomment-367781440.)
It is rarely useful to have a `range` loop assign to existing variables, and we could address that use-case more cleanly with a `finally` or `else` keyword anyway.
3. Eliminating the `range` keyword would allow us to fix variable capture (https://github.com/golang/go/issues/20733) in a way that does not unexpectedly change the semantics of `for`-loops written in the Go 1 style. (That is, old-style loops would no longer compile, instead of successfully compiling to something different from before.)
----
Proposal
--------
1. Remove the `range` keyword and the three-part loop form.
2. Make the `range` form of the `for` loop more concise, and add a two-part form and optional `else` block.
* For the one-part form:
* If the first part is of the form `x : z` or `x, y : z`, it introduces new variables `x` and `y` (as applicable), which take the value of each successive element of `z`. The one-variable form can be used only for channels and numeric intervals (see `interval` below). The two-variable form can be used only for maps, slices, strings, and arrays.
* Otherwise, the first part must be a boolean expression and specifies the `Condition` of the loop.
* The new two-part form parallels the two-part form of `switch`. The first part is an arbitrary statement (usually a short variable declaration) to be evaluated before every iteration, and the second part is the `Condition`:
`for x, err := f(); err == nil {`
* An `else` block may follow a loop that has with a `Condition`. Control transfers to the `else` block when the condition is false (like `else` in Python loops). The variables declared in the first part of the two-part form remain in scope for the `else` block.
* (If we don't like the way `else` reads, we could drop that part entirely, or use some other keyword — such as `finally` — and/or tweak the semantics, for example by also transferring control to the block in case of a `break`.)
3. Add a built-in pseudofunction `interval` to replace the vast majority of existing 3-part loops.
* `interval(m, n)` returns a container that iterates over `[m, n)` by increments of `1`.
* `interval(m, n, step)` returns a container that iterates from `m` (inclusive) to `n` (exclusive) by `step`.
----
Examples
--------
### Simple conditions
Loops with just a `Condition` remain the same as in Go 1.
```go
for a < b {
a *= 2
}
```
----
```go
for len(h) > 0 {
x := heap.Pop(h)
f(x.(someType))
}
```
### Ranges
Range loops lose a little bit of boilerplate, and gain a closer resemblance to for-each loops in other languages with C-like syntax (such as C++ and Java).
```go
for i, s := range a {
g(i, s)
}
```
becomes
```go
for i, s : a {
g(i, s)
}
```
----
(from https://github.com/golang/go/wiki/SliceTricks#filtering-without-allocating)
```go
b := a[:0]
for _, x := range a {
if f(x) {
b = append(b, x)
}
}
```
becomes
```go
b := a[:0]
for _, x : a {
if f(x) {
b = append(b, x)
}
}
```
### Intervals
Simple numeric intervals move the limit closer to the end of the line (where it is easier to find), and in some cases drop the need for redundant variables.
```go
for i, n := 0, f(x); i < n; i++ {
g(i)
}
```
becomes
```go
for i : interval(0, f(x)) {
g(i)
}
```
----
```go
for n := runtime.GOMAXPROCS(0); n > 0; n-- {
go …
}
```
becomes
```go
for n : interval(runtime.GOMAXPROCS(0), 0, -1) {
go …
}
```
----
(from https://github.com/golang/go/wiki/SliceTricks#reversing, noting that the original goes out of its way
— and loses some clarity in the process — to avoid re-evaluating `len(a)/2` at each iteration)
```go
for i := len(a)/2-1; i >= 0; i-- {
opp := len(a)-1-i
a[i], a[opp] = a[opp], a[i]
}
```
becomes
```go
for i : interval(0, len(a)/2) {
opp := len(a)-1-i
a[i], a[opp] = a[opp], a[i]
}
```
or
```go
for i, _ : a[:len(a)/2] {
opp := len(a)-1-i
a[i], a[opp] = a[opp], a[i]
}
```
### Iterators
Iterator patterns shed boilerplate and/or levels of indentation.
```go
for {
n, err := r.Read(p)
if err != nil {
if err != io.EOF {
return err
}
return nil
}
f(p[:n])
}
```
becomes
```go
for n, err := r.Read(p); err == nil {
f(p[:n])
} else if err != io.EOF {
return err
}
return nil
```
----
```go
iter := Begin()
for x, ok := iter.Next(); ok; x, ok = iter.Next() {
f(x)
}
```
becomes
```go
iter := Begin()
for x, ok := iter.Next(); ok {
f(x)
}
```
### Lists
Loops iterating over certain custom containers (such as linked lists) become a bit more awkward.
(On the other hand, I would argue that they were awkward to begin with — and they could be fixed by a further change to allow types to implement the `range`-like behavior directly.)
```go
for e := l.Front(); e != nil; e = e.Next() {
f(e)
}
```
becomes
```go
e := l.Front()
for e != nil {
f(e)
e = e.Next()
}
``` | LanguageChange,Proposal,LanguageChangeReview | high | Critical |
302,914,204 | go | runtime: wrong Unix error code from panic. | Please answer these questions before submitting your issue. Thanks!
### What version of Go are you using (`go version`)?
go version devel +baf3eb1625 Tue Mar 6 01:11:26 2018 +0000 darwin/amd64
```
% cat p.go
package main
func main() {
panic(3)
}
% ./p
panic: 3
goroutine 1 [running]:
main.main()
/Users/r/p.go:4 +0x39
% echo $?
2
%
```
Exit code 2 traditionally means 'incorrect arguments', as in flag.Usage.
Panic should be something like 127 or 255 on Unix.
Reported by [email protected] on nuts.
| NeedsFix,early-in-cycle,compiler/runtime | medium | Critical |
302,934,604 | vue | SFC: Invalid root tag structure should throw error | **Moved from**: [vue-loader#1161](https://github.com/vuejs/vue-loader/issues/1161)
### What problem does this feature solve?
In Single File Component, `<script>` tag may or may not closed, so this works:
```html
<template>
<div class="chicken">
Chicken: {{ chicken }}
</div>
</template>
<script>
export default {
data() { return { chicken: 'fried' } }
}
// (EOF)
```
However, `<style>` isn't; if there's no `</style>`, styles are **simply ignored** without any warning or errors.
```html
<template>
<div class="chicken">
Chicken: {{ chicken }}
</div>
</template>
<script>
export default {
data() { return { chicken: 'fried' } }
}
</script>
<style scoped>
.chicken { /* super important */
font-weight: 900;
}
/* (EOF) */
```
### What does the proposed API look like?
Any `<template>`, `<script>`, `<style>` tags should **explicitly**:
* Closed - unclosed tag should throw a warning and refuse to build.
* ~or May not closed - contents should build correctly even it's not closed.~
<!-- generated by vue-issues. DO NOT REMOVE --> | improvement | low | Critical |
302,954,838 | go | x/net/dns: invalid assumptions about domain names and character strings | ### What version of Go are you using (`go version`)?
`go version go1.10 linux/amd64`
### Does this issue reproduce with the latest release?
Yes.
### What did you do?
[Reviewed go cl 37879](https://go-review.googlesource.com/c/go/+/37879#message-f19801f32435469ed7e1ed98732f7bcd02da5aea) and [dns/dnsmessage/message.go as of 2018-03-06](https://github.com/golang/net/blob/22ae77b79946ea320088417e4d50825671d82d57/dns/dnsmessage/message.go).
### What did you expect to see?
Correct handling of DNS data.
### What did you see instead?
* [`func (n *Name) pack`](https://github.com/golang/net/blob/22ae77b79946ea320088417e4d50825671d82d57/dns/dnsmessage/message.go#L1537) incorrectly assumes that terminal dots imply absolute names, falsely accepting names that end with _escaped_ dots (e.g., `example\.`).
* [`func (n *Name) unpack`](https://github.com/golang/net/blob/22ae77b79946ea320088417e4d50825671d82d57/dns/dnsmessage/message.go#L1603) assumes that label contents can be directly copied from wire format to presentation format, and therefore incorrectly converts dots in labels to label-_separating_ dots (e.g., equating the distinct names `a.b.example.` [1 0x61 1 0x62 7 0x65 0x78 0x61 0x6d 0x70 0x6c 0x65 0] and `a\.b.example.` [3 0x61 0x2E 0x62 7 0x65 0x78 0x61 0x6d 0x70 0x6c 0x65 0]) and produces invalid domain names by naïvely including backslashes and control characters.
* [`type TXTResource`](https://github.com/golang/net/blob/22ae77b79946ea320088417e4d50825671d82d57/dns/dnsmessage/message.go#L1954) incorrectly assumes that TXT RDATA is a single string (when it reality it is a _sequence_ of character strings [1], each of which is limited to 255 octets in wire format [2]), making it impossible to differentiate `TXT "" ""` (two empty character strings) from `TXT ""` (one empty character string). The associated pack/unpack code also fails to reject overly-long strings (e.g., "aa-ab-ac-…-az-ba-bb-bc-…-zx-zy-zz"), instead naïvely combining/splitting 255-octet chunks.
[1]: https://tools.ietf.org/html/rfc1035#section-3.3.14
[2]: https://tools.ietf.org/html/rfc1035#section-3.3 | NeedsFix | low | Major |
302,961,506 | go | x/net/http2: add ability to specify priority to http2.Transport.RoundTrip | Example diff: https://github.com/golang/net/pull/17/files
Use case: I'm implementing an HTTP/2 reverse that would like to pass through the priority that the client sends to the upstream server. | NeedsDecision,FeatureRequest | low | Minor |
302,970,310 | rust | Mismatched lifetime in trait function declaration is not detected | Consider the following code:
```rust
pub trait FromStr<'a>: Sized {
type Err;
fn from_str(s: &'a str) -> Result<Self, Self::Err>;
}
struct Foo<'a>(&'a str);
impl<'a> FromStr<'a> for Foo<'a> {
type Err = ();
fn from_str(s: &str) -> Result<Self, Self::Err> {
Ok(Foo(s))
}
}
```
The compiler errors out failing to infer an appropriate lifetime:
```
error[E0495]: cannot infer an appropriate lifetime for lifetime parameter `'a` due to conflicting requirements
--> src/main.rs:11:12
|
11 | Ok(Foo(s))
| ^^^
|
note: first, the lifetime cannot outlive the anonymous lifetime #1 defined on the method body at 10:5...
--> src/main.rs:10:5
|
10 | / fn from_str(s: &str) -> Result<Self, Self::Err> {
11 | | Ok(Foo(s))
12 | | }
| |_____^
note: ...so that reference does not outlive borrowed content
--> src/main.rs:11:16
|
11 | Ok(Foo(s))
| ^
note: but, the lifetime must be valid for the lifetime 'a as defined on the impl at 8:1...
--> src/main.rs:8:1
|
8 | impl<'a> FromStr<'a> for Foo<'a> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
= note: ...so that the expression is assignable:
expected std::result::Result<Foo<'a>, _>
found std::result::Result<Foo<'_>, _>
```
But the most immediate error is that the declaration of `from_str` doesn't match the trait definition, missing the lifetime bound on `&str` to match the lifetime associated with the trait. | C-enhancement,A-diagnostics,T-compiler,fixed-by-NLL,A-suggestion-diagnostics,D-papercut | low | Critical |
302,980,716 | vscode | Allow a workspace to show individual files from other folders | **Update from @bpasero:** this issue was renamed based on the discussion at the end (see https://github.com/microsoft/vscode/issues/45177#issuecomment-1341005532 and above)
**_Original below:_**
<!-- Do you have a question? Please ask it on https://stackoverflow.com/questions/tagged/vscode. -->
<!-- Use Help > Report Issue to prefill these. -->
- VSCode Version: 1.20.1
- OS Version: Microsoft Windows [Version 10.0.16299.248]
Steps to Reproduce:
N/A
<!-- Launch with `code --disable-extensions` to check. -->
Does this issue occur when all extensions are disabled?: Yes
---
Currently, .code-workspace only contains `folders` field which allows to add folders into workspace. I prefer a way to add single files into workspace for the entire project, such as README or something else.
| feature-request,workbench-workspace,keep | high | Critical |
303,098,992 | TypeScript | Suggestion: ability to find imports for module | Find references is a very useful feature, however sometimes I need to be able to find all imports of a given module:
- regardless of what they're exporting
- but the module does not have any exports
This is sometimes necessary when a module has side effects, and you want to see which files imported it.
This might also be useful for dynamic imports. In one project we have several dynamic imports (for code splitting) that never explicitly reference the module exports, so if I use find references on those module exports, I will not be shown the dynamic import. For example, here is a dynamic import:
When I activate find references on the exports of that module, I am not shown the import:
| Suggestion,Awaiting More Feedback | low | Major |
303,099,381 | vscode | [json] External schemas referenced from schema not updated | ### Issue Type
Bug
### Description
#### Setup
**`color-schema.json`**
```
{
"$schema": "http://json-schema.org/draft-07/schema#",
"validColors": {
"enum": ["Red"]
}
}
```
**`schema.json`**
```
{
"$schema": "http://json-schema.org/draft-07/schema#",
"type": "object",
"properties": {
"color": { "$ref": "color-schema.json#/validColors" }
},
"required": ["color"]
}
```
**`test.json`**
```
{
"$schema": "./schema.json",
"color": "Red"
}
```
#### Test 1: Intellisense notices changes in `schema.json`
Rename the property `color` to `colorx` in `schema.json` -> (Desired) error in `test.json`: `Missing property "colorx".`
:heavy_check_mark: That work's!
#### Test 2: Intellisense does not notice changes in `color-schema.json`
Change `Red` to `Yellow` in `color-schema.json` -> no errors!
Restarting VSCode finally gives the desired error in `test.json`: `Value is not accepted. Valid values: "Yellow".`
:x: That doesn't work! (i. e. at least without restarting VSCode after each schema dependency change)
### VS Code Info
VS Code version: Code 1.20.1 (f88bbf9137d24d36d968ea6b2911786bfe103002, 2018-02-13T15:31:21.019Z)
OS version: Linux x64 4.13.0-36-generic
<details>
<summary>System Info</summary>
|Item|Value|
|---|---|
|CPUs|Intel(R) Core(TM) i5-5200U CPU @ 2.20GHz (4 x 2194)|
|Load (avg)|1, 1, 1|
|Memory (System)|7.71GB (1.54GB free)|
|Process Argv|/usr/share/code/code --unity-launch|
|Screen Reader|no|
|VM|0%|
</details><details><summary>Extensions (6)</summary>
Extension|Author (truncated)|Version
---|---|---
calculate|aca|2.0.0
QML|bbe|1.0.0
Kotlin|mat|1.5.0
cpptools|ms-|0.15.0
vetur|oct|0.11.7
enumerator|swi|0.0.6
</details>
Reproduces without extensions | bug,json | low | Critical |
303,161,589 | TypeScript | String.replace does not accept string | (string, ...any[]) => string replacer | **TypeScript Version:** 2.7.2
**Search Terms:** String.replace overload union parameter
**Code**
```ts
type ReplacerFn = () => string;
type Replacer = string | ReplacerFn;
function replaceFoo(str: string, replacer: Replacer) {
return str.replace(new RegExp("foo"), replacer);
}
```
**Expected behavior:**
Compiles successfully.
Perhaps the change is as simple as combining the two overloads into a union, though the implications of that change are possibly unpleasant as far as tooling is concerned.
**Actual behavior:**
`bad.ts(5,43): error TS2345: Argument of type 'Replacer' is not assignable to parameter of type '(substring: string, ...args: any[]) => string'.
Type 'string' is not assignable to type '(substring: string, ...args: any[]) => string'.`
**Playground Link:** [playground link](https://www.typescriptlang.org/play/#src=type%20ReplacerFn%20%3D%20()%20%3D%3E%20string%3B%0D%0Atype%20Replacer%20%3D%20string%20%7C%20ReplacerFn%3B%0D%0A%0D%0Afunction%20replaceFoo(str%3A%20string%2C%20replacer%3A%20Replacer)%20%7B%0D%0A%20%20%20%20return%20str.replace(new%20RegExp(%22foo%22)%2C%20replacer)%3B%0D%0A%7D)
**Related Issues:**
#20432 (Array.from)
#20215 (new Date)
#14107 (underlying issue) | Bug,Help Wanted,Domain: lib.d.ts | low | Critical |
303,251,206 | rust | Collect and aggregate timing statistics of CI builders | Currently we only have a little bit of insight into how long all our CI builds are taking with a breakdown of where all that time is going. It's hoped that if we have a historical record of the duration of CI builds which is relatively consistent and granular we can more easily see regressions that happen over time and diagnose otherwise obvious-in-retrospect problems with the build.
The current thinking for how this might be done is to instrument rustbuild to, by default on CI, emit timing information about each step in a structured fashion. The thinking is we could then scrape the logs of all our CI builds to aggregate this structure data. The data needs to include enough information so that it can indeed be easily aggregated. For example we shouldn't have to look at the Travis environment to guess whether it's an OSX/Linux build or which architecture is being assembled.
Once we've got this data we can hopefully set up graphs over time like https://rust-lang-nursery.github.io/rustc-pr-tracking/ to see what time is going where. CI timings are *very* noisy but the hope is that general trends will still be relatively clear. | C-enhancement,T-bootstrap,T-infra | low | Major |
303,257,284 | godot | Disabling/removing an editor plugin defining custom types doesn't reverts custom icons | Godot 3.0.2 stable
Windows 10 64 bits
I disabled one of my plugins, but I noticed that the custom node it defined still had its custom icon.
I closed the editor, deleted the `plugin.cfg` file, restarted the editor: the scene still shows the custom icon.
I tried removing the script on that node, closed the scene, and reopened: the node still has the custom icon.
Changing the type of the node to `Spatial` reverted its icon, even though the node was a `Spatial` already.
Before fixing the icon, those two errors were printed each time I reloaded the scene, though it might be unrelated:
```
ERROR: PopupMenu::get_item_text: Index p_idx=-1163005939 out of size (items.size()=4)
At: scene\gui\popup_menu.cpp:732
ERROR: PopupMenu::set_item_checked: Index p_idx=-1163005939 out of size (items.size()=4)
At: scene\gui\popup_menu.cpp:680
``` | bug,topic:editor | low | Critical |
303,288,571 | go | cmd/compile: esc.go fails to mark anonymous receiver parameters as non-escaping | package p
type T struct { x int }
//go:noinline
func (*T) M() {}
//go:noinline
func (_ *T) N() {}
func f() {
var t T
t.M()
t.N()
(*T).M(&t)
(*T).N(&t)
}
Compiling the above code with "go tool compile -m" outputs:
a.go:13:3: t escapes to heap
a.go:12:6: moved to heap: t
a.go:14:3: t escapes to heap
a.go:15:9: &t escapes to heap
a.go:16:9: &t escapes to heap
This doesn't happen if the receiver parameters are given a proper name, or if the receiver parameters are turned into normal parameters (i.e., changing the methods into functions).
The direct calls (`t.M()` and `t.N()`) are because `(*EscState).esctag`'s unnamed parameter loop only touches `fn.Type.Params()`, not `fn.Type.Recvs()`.
The indirect calls (`(*T).M(&t)` and `(*T).N(&t)`) appear to be because esc.go just doesn't look for esc tags for methods called as functions. | NeedsFix,compiler/runtime | low | Major |
303,318,887 | rust | Use apple's version of clang to compile iOS targets by default | In Xcode, Apple ships a closed-source version of clang, which in turn has a closed-source version of LLVM (it seems like Xcode 9's LLVM forks off of LLVM 5?). Apple's clang/LLVM generally includes stability enhancements that would otherwise potentially cause problems for developers. I'm not sure what the benefits are of using Rust's current LLVM, e.g. it can be newer than Apple's, but Apple's clang is a really safe bet and seems a good thing to use by default. Some of these platform-specific issues can manifest in weird and very difficult to diagnose ways, e.g. random restarts, that it would be good to save developers from.
We could just give users a bitcode file for them to compile with clang themselves (#35968), or maybe there's some way to have the user specify which version of clang they want. | O-macos,O-ios,T-bootstrap,C-feature-request | low | Major |
303,325,138 | TypeScript | generate function declaration from function type in TypeScript | _From @unional on October 5, 2017 18:52_
```ts
type MyCallback = (a: number, b: string) => void
function foo(callback: MyCallback) {
// ...
}
// case 1
foo((a, b) => { ... })
// case 2
foo(function (a, b) { ... })
// case 3
function cb(a: number, b: string) { ... }
foo(cb)
```
Above are 3 common ways to write a callback.
TypeScript is great at inferring the argument types in the implemented callbacks.
`a`, and `b` are typed accordingly in the callbacks above.
However, the tooltip is not useful when we are implementing the callbacks:
If I change `foo()` to not using type alias, it helps in case 1 and 2:
```ts
function foo(callback: (a: number, b: string) => void) { ... }
```
But that doesn't help in case 3 and actually demotes type alias.
One solution I can think of is using [ctrl+.] to fill in the callback:
```ts
foo(/* caret */)
// [ctrl+.] and choose "implement callback as arrow function":
foo((a: number, b: string) => { /* caret */ })
// [ctrl+.] and choose "implement callback as function declaration":
foo(function (a: number, b: string) { /* caret */ })
// caret anywhere on the type alias below
MyCallback
// [ctrl+.] and choose "implement function declaration" will expand to snippet:
function ${1:functionName}(a: number, b: string): void { ${0} }
```
_Copied from original issue: Microsoft/vscode#35635_ | Suggestion,In Discussion,VS Code Tracked,Domain: Quick Fixes,Experience Enhancement | low | Minor |
303,327,727 | TypeScript | Need a version of getSupportedCodeFixes that only returns codes that support fix-all | VS needs it in order to implement this API:
http://source.roslyn.io/#Microsoft.CodeAnalysis.Workspaces/CodeFixes/FixAllOccurrences/FixAllProvider.cs,8a74cdbcb24c6dcb,references
Without it, VS will offer fix-all for all code fixes. This is relatively low impact. | Suggestion,Experience Enhancement | low | Minor |
303,344,606 | flutter | Support user-supplied project templates for `flutter create` | ### Proposal
I stumbled upon [a boilerplate project](https://github.com/anilcancakir/flutter-boilerplate) today and realized that I'd have to manually clone this and change values in different files and whatnot to get started with it.
Here I propose allowing users to specify a custom template at project creation time.
### User Interface
Users creating a new project can specify a template as follows:
```
# from pub
$ flutter create my-project-name --template package-name-on-pub
# or from a git host
$ flutter create my-project-name --template https://somegithost.com/username/projectname
# or from the local filesystem
$ flutter create my-project-name --template /path/to/project/root
```
### Unanswered Questions
1) Are substitutions (author name, project name, description, etc) limited to a know set of files?
2) <your questions / concerns here>
#### If the answer to 1 is "no" then how will the templating system know which files to modify?
Should it scan *all* files looking for use of template context data?
Or should the template author explicitly list the files in some form of a manifest?
### Alternatives
1) We don't do this
2) The `flutter` CLI could grow a `flutter template install` (or similar) command.
This would mean creating a directory to house templates (such as `~/.flutter/templates`, although `~/.flutter` is already a textual file but this could be moved I imagine) and augmenting [the template "discovery" code](https://github.com/flutter/flutter/blob/20004357288389829df79a3af5308d4c5819aecf/packages/flutter_tools/lib/src/template.dart#L166-L170).
3) <your idea here!> | c: new feature,tool,P3,team-tool,triaged-tool | high | Critical |
303,356,582 | go | runtime: ignore map size hint if there's not enough memory? | Please answer these questions before submitting your issue. Thanks!
#### What did you do?
go test in encoding/gob
#### What did you expect to see?
Passed tests
#### What did you see instead?
[test_otpt.txt](https://github.com/golang/go/files/1791870/test_otpt.txt)
#### Does this issue reproduce with the latest release (go1.10)?
No
#### System details
```
go version devel +0add9a4dcf Thu Mar 8 03:26:22 2018 +0000 linux/amd64
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/mfrw/.cache/go-build"
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/home/mfrw/go/go_get"
GORACE=""
GOROOT="/home/mfrw/go"
GOTMPDIR=""
GOTOOLDIR="/home/mfrw/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build389146753=/tmp/go-build -gno-record-gcc-switches"
GOROOT/bin/go version: go version devel +0add9a4dcf Thu Mar 8 03:26:22 2018 +0000 linux/amd64
GOROOT/bin/go tool compile -V: compile version devel +0add9a4dcf Thu Mar 8 03:26:22 2018 +0000
uname -sr: Linux 4.9.20-1-MANJARO
LSB Version: n/a
Distributor ID: ManjaroLinux
Description: Manjaro Linux
Release: 17.0.1
Codename: Gellivara
/usr/lib/libc.so.6: GNU C Library (GNU libc) stable release version 2.25, by Roland McGrath et al.
gdb --version: GNU gdb (GDB) 7.12.1
```
<details>
=== RUN TestUintCodec
--- PASS: TestUintCodec (0.00s)
=== RUN TestIntCodec
--- PASS: TestIntCodec (0.00s)
=== RUN TestScalarEncInstructions
--- PASS: TestScalarEncInstructions (0.00s)
=== RUN TestScalarDecInstructions
--- PASS: TestScalarDecInstructions (0.00s)
=== RUN TestEndToEnd
--- PASS: TestEndToEnd (0.00s)
=== RUN TestOverflow
--- PASS: TestOverflow (0.00s)
=== RUN TestNesting
--- PASS: TestNesting (0.00s)
=== RUN TestAutoIndirection
--- PASS: TestAutoIndirection (0.00s)
=== RUN TestReorderedFields
--- PASS: TestReorderedFields (0.00s)
=== RUN TestIgnoredFields
--- PASS: TestIgnoredFields (0.00s)
=== RUN TestBadRecursiveType
--- PASS: TestBadRecursiveType (0.00s)
=== RUN TestIndirectSliceMapArray
--- PASS: TestIndirectSliceMapArray (0.00s)
=== RUN TestInterface
--- PASS: TestInterface (0.00s)
=== RUN TestInterfaceBasic
--- PASS: TestInterfaceBasic (0.00s)
=== RUN TestInterfacePointer
--- PASS: TestInterfacePointer (0.00s)
=== RUN TestIgnoreInterface
--- PASS: TestIgnoreInterface (0.00s)
=== RUN TestUnexportedFields
--- PASS: TestUnexportedFields (0.00s)
=== RUN TestDebugSingleton
--- PASS: TestDebugSingleton (0.00s)
=== RUN TestDebugStruct
--- PASS: TestDebugStruct (0.00s)
=== RUN TestFuzz
--- PASS: TestFuzz (0.00s)
codec_test.go:1424: disabled; run with -gob.fuzz to enable
=== RUN TestFuzzRegressions
--- PASS: TestFuzzRegressions (0.00s)
codec_test.go:1444: disabled; run with -gob.fuzz to enable
=== RUN TestFuzzOneByte
fatal error: runtime: out of memory
runtime stack:
runtime.throw(0x5b89e1, 0x16)
/home/mfrw/go/src/runtime/panic.go:617 +0x80
runtime.sysMap(0xc004000000, 0xdd00000000, 0x6be7f8)
/home/mfrw/go/src/runtime/mem_linux.go:156 +0xc7
runtime.(*mheap).sysAlloc(0x6a48e0, 0xdd00000000, 0x80, 0x0)
/home/mfrw/go/src/runtime/malloc.go:601 +0x1d0
runtime.(*mheap).grow(0x6a48e0, 0x6e80000, 0x0)
/home/mfrw/go/src/runtime/mheap.go:920 +0x42
runtime.(*mheap).allocSpanLocked(0x6a48e0, 0x6e80000, 0x6be808, 0x7f98353cbdd0)
/home/mfrw/go/src/runtime/mheap.go:848 +0x337
runtime.(*mheap).alloc_m(0x6a48e0, 0x6e80000, 0xffffffffffff0100, 0x7f98353cbe08)
/home/mfrw/go/src/runtime/mheap.go:692 +0x119
runtime.(*mheap).alloc.func1()
/home/mfrw/go/src/runtime/mheap.go:759 +0x4d
runtime.(*mheap).alloc(0x6a48e0, 0x6e80000, 0x7f9835010100, 0x4157f9)
/home/mfrw/go/src/runtime/mheap.go:758 +0x8a
runtime.largeAlloc(0xdd00000000, 0xc000280001, 0x7f9838545000)
/home/mfrw/go/src/runtime/malloc.go:1001 +0x94
runtime.mallocgc.func1()
/home/mfrw/go/src/runtime/malloc.go:896 +0x46
runtime.systemstack(0x0)
/home/mfrw/go/src/runtime/asm_amd64.s:403 +0x66
runtime.mstart()
/home/mfrw/go/src/runtime/proc.go:1170
goroutine 27 [running]:
runtime.systemstack_switch()
/home/mfrw/go/src/runtime/asm_amd64.s:363 fp=0xc000287748 sp=0xc000287740 pc=0x455360
runtime.mallocgc(0xdd00000000, 0x5970e0, 0xc0003f2b01, 0xc000287828)
/home/mfrw/go/src/runtime/malloc.go:895 +0x895 fp=0xc0002877e8 sp=0xc000287748 pc=0x40bd45
runtime.newarray(0x5970e0, 0x110000000, 0x5a6da0)
/home/mfrw/go/src/runtime/malloc.go:1030 +0x6a fp=0xc000287818 sp=0xc0002877e8 pc=0x40c12a
runtime.makeBucketArray(0x57f520, 0xc0003edc20, 0xc000376318, 0x5)
/home/mfrw/go/src/runtime/map.go:881 +0xe2 fp=0xc000287850 sp=0xc000287818 pc=0x40e672
runtime.makemap(0x57f520, 0x36f6e6502, 0xc0003edc20, 0x194)
/home/mfrw/go/src/runtime/map.go:328 +0xe3 fp=0xc000287890 sp=0xc000287850 pc=0x40cd53
reflect.makemap(0x57f520, 0x36f6e6502, 0x15)
/home/mfrw/go/src/runtime/map.go:1190 +0x167 fp=0xc0002878c8 sp=0xc000287890 pc=0x40f317
reflect.MakeMapWithSize(0x5dc640, 0x57f520, 0x36f6e6502, 0x1, 0x676e69646f636e65, 0x546e4f2e626f672f)
/home/mfrw/go/src/reflect/value.go:2136 +0x69 fp=0xc0002878f0 sp=0xc0002878c8 pc=0x498899
encoding/gob.(*Decoder).decodeMap(0xc000376300, 0x5dc640, 0x57f520, 0xc000142820, 0x57f520, 0xc0003be3b0, 0x195, 0x5c16e8, 0x5c16a8, 0x5da720, ...)
/home/mfrw/go/src/encoding/gob/decode.go:562 +0x6a9 fp=0xc0002879f8 sp=0xc0002878f0 pc=0x50a1e9
encoding/gob.(*Decoder).decOpFor.func2(0xc00021af50, 0xc000142820, 0x57f520, 0xc0003be3b0, 0x195)
/home/mfrw/go/src/encoding/gob/decode.go:829 +0x97 fp=0xc000287a60 sp=0xc0002879f8 pc=0x544ad7
encoding/gob.(*Decoder).decodeStruct(0xc000376300, 0xc000142a00, 0x5a63a0, 0xc0003be360, 0x199)
/home/mfrw/go/src/encoding/gob/decode.go:471 +0xc7 fp=0xc000287ae8 sp=0xc000287a60 pc=0x508fd7
encoding/gob.(*Decoder).decodeValue(0xc000376300, 0x62, 0x566a80, 0xc0003be360, 0x16)
/home/mfrw/go/src/encoding/gob/decode.go:1205 +0x266 fp=0xc000287b90 sp=0xc000287ae8 pc=0x50f776
encoding/gob.(*Decoder).DecodeValue(0xc000376300, 0x566a80, 0xc0003be360, 0x16, 0x0, 0x0)
/home/mfrw/go/src/encoding/gob/decoder.go:212 +0x134 fp=0xc000287bc8 sp=0xc000287b90 pc=0x510ac4
encoding/gob.(*Decoder).Decode(0xc000376300, 0x566a80, 0xc0003be360, 0xc000287cc8, 0xc000287cb0)
/home/mfrw/go/src/encoding/gob/decoder.go:187 +0x18b fp=0xc000287c30 sp=0xc000287bc8 pc=0x5108eb
encoding/gob.TestFuzzOneByte.func1(0xc0000c14a0, 0xc000287cc8, 0xc000287cb0, 0xc0003bc6c0, 0x112, 0x120, 0xc0003be360)
/home/mfrw/go/src/encoding/gob/codec_test.go:1499 +0xe0 fp=0xc000287c68 sp=0xc000287c30 pc=0x545950
encoding/gob.TestFuzzOneByte(0xc0000c14a0)
/home/mfrw/go/src/encoding/gob/codec_test.go:1501 +0x630 fp=0xc000287fa8 sp=0xc000287c68 pc=0x52ff50
testing.tRunner(0xc0000c14a0, 0x5c13a8)
/home/mfrw/go/src/testing/testing.go:788 +0xc3 fp=0xc000287fd0 sp=0xc000287fa8 pc=0x4c2183
runtime.goexit()
/home/mfrw/go/src/runtime/asm_amd64.s:1379 +0x1 fp=0xc000287fd8 sp=0xc000287fd0 pc=0x457431
created by testing.(*T).Run
/home/mfrw/go/src/testing/testing.go:835 +0x2c5
goroutine 1 [chan receive]:
testing.(*T).Run(0xc0000c14a0, 0x5b653c, 0xf, 0x5c13a8, 0x46d301)
/home/mfrw/go/src/testing/testing.go:836 +0x2ec
testing.runTests.func1(0xc0000c0000)
/home/mfrw/go/src/testing/testing.go:1078 +0x64
testing.tRunner(0xc0000c0000, 0xc000057df8)
/home/mfrw/go/src/testing/testing.go:788 +0xc3
testing.runTests(0xc00000c7e0, 0x69d6a0, 0x5c, 0x5c, 0x40b7a1)
/home/mfrw/go/src/testing/testing.go:1076 +0x2a1
testing.(*M).Run(0xc0000be000, 0x0)
/home/mfrw/go/src/testing/testing.go:993 +0x165
main.main()
_testmain.go:260 +0x13d
exit status 2
FAIL encoding/gob 0.698s
</details>
| NeedsFix | medium | Critical |
303,358,624 | node | child_process stdout being truncated | * **Version**: 9.7.1
* **Platform**: Darwin miless-mbp.lan 17.4.0 Darwin Kernel Version 17.4.0: Sun Dec 17 09:19:54 PST 2017; root:xnu-4570.41.2~1/RELEASE_X86_64 x86_64
* **Subsystem**:
It seems like `spawn()` and `exec()` is truncating `stdout`, even when `maxBuffer` is set. I've been trying to capture the output of `jest --help`, which the full output looks like the following:
```
Usage: jest [--config=<pathToConfigFile>] [TestPathPattern]
Options:
--help, -h Show help [boolean]
--all The opposite of `onlyChanged`. If
`onlyChanged` is set by default, running jest
with `--all` will force Jest to run all tests
instead of running only tests related to
changed files.
--automock Automock all files by default. [boolean]
--bail, -b Exit the test suite immediately upon the first
failing test. [boolean]
--browser Respect the "browser" field in package.json
when resolving modules. Some packages export
different versions based on whether they are
operating in node.js or a browser. [boolean]
--cache Whether to use the transform cache. Disable
the cache using --no-cache. [boolean]
--cacheDirectory The directory where Jest should store its
cached dependency information. [string]
--changedFilesWithAncestor Runs tests related to the current changes and
the changes made in the last commit. Behaves
similarly to `--onlyChanged`. [boolean]
--changedSince Runs tests related the changes since the
provided branch. If the current branch has
diverged from the given branch, then only
changes made locally will be tested. Behaves
similarly to `--onlyChanged`. [string]
--ci Whether to run Jest in continuous integration
(CI) mode. This option is on by default in
most popular CI environments. It will prevent
snapshots from being written unless explicitly
requested. [boolean] [default: false]
--clearCache Clears the configured Jest cache directory and
then exits. Default directory can be found by
calling jest --showConfig [boolean]
--clearMocks Automatically clear mock calls and instances
between every test. Equivalent to calling
jest.clearAllMocks() between each test.
[boolean]
--collectCoverage Alias for --coverage. [boolean]
--collectCoverageFrom An array of glob patterns relative to
<rootDir> matching the files that coverage
info needs to be collected from. [array]
--collectCoverageOnlyFrom Explicit list of paths coverage will be
restricted to. [array]
--color Forces test results output color highlighting
(even if stdout is not a TTY). Set to false if
you would like to have no colors. [boolean]
--colors Alias for `--color`. [boolean]
--config, -c The path to a jest config file specifying how
to find and execute tests. If no rootDir is
set in the config, the current directory is
assumed to be the rootDir for the project.
This can also be a JSON encoded value which
Jest will use as configuration. [string]
--coverage Indicates that test coverage information
should be collected and reported in the
output. [boolean]
--coverageDirectory The directory where Jest should output its
coverage files. [string]
--coveragePathIgnorePatterns An array of regexp pattern strings that are
matched against all file paths before
executing the test. If the file pathmatches
any of the patterns, coverage information will
be skipped. [array]
--coverageReporters A list of reporter names that Jest uses when
writing coverage reports. Any istanbul
reporter can be used. [array]
--coverageThreshold A JSON string with which will be used to
configure minimum threshold enforcement for
coverage results [string]
--debug Print debugging info about your jest config.
[boolean]
--detectLeaks **EXPERIMENTAL**: Detect memory leaks in
tests. After executing a test, it will try to
garbage collect the global object used, and
fail if it was leaked
[boolean] [default: false]
--env The test environment used for all tests. This
can point to any file or node module.
Examples: `jsdom`, `node` or
`path/to/my-environment.js` [string]
--expand, -e Use this flag to show full diffs instead of a
patch. [boolean]
--findRelatedTests Find related tests for a list of source files
that were passed in as arguments. Useful for
pre-commit hook integration to run the minimal
amount of tests necessary. [boolean]
--forceExit Force Jest to exit after all tests have
completed running. This is useful when
resources set up by test code cannot be
adequately cleaned up. [boolean]
--globalSetup The path to a module that runs before All
Tests. [string]
--globalTeardown The path to a module that runs after All
Tests. [string]
--globals A JSON string with map of global variables
that need to be available in all test
environments. [string]
--haste A JSON string with map of variables for the
haste module system [string]
--json Prints the test results in JSON. This mode
will send all other test output and user
messages to stderr. [boolean]
--lastCommit Run all tests affected by file changes in the
last commit made. Behaves similarly to
`--onlyChanged`. [boolean]
--listTests Lists all tests Jest will run given the
arguments and exits. Most useful in a CI
system together with `--findRelatedTests` to
determine the tests Jest will run based on
specific files [boolean] [default: false]
--logHeapUsage Logs the heap usage after every test. Useful
to debug memory leaks. Use together with
`--runInBand` and `--expose-gc` in node.
[boolean]
--mapCoverage Maps code coverage reports against original
source code when transformers supply source
maps.
DEPRECATED [boolean]
--maxWorkers, -w Specifies the maximum number of workers the
worker-pool will spawn for running tests. This
defaults to the number of the cores available
on your machine. (its usually best not to
override this default) [number]
--moduleDirectories An array of directory names to be searched
recursively up from the requiring module's
location. [array]
--moduleFileExtensions An array of file extensions your modules use.
If you require modules without specifying a
file extension, these are the extensions Jest
will look for. [array]
--moduleNameMapper A JSON string with a map from regular
expressions to module names that allow to stub
out resources, like images or styles with a
single module [string]
--modulePathIgnorePatterns An array of regexp pattern strings that are
matched against all module paths before those
paths are to be considered "visible" to the
module loader. [array]
--modulePaths An alternative API to setting the NODE_PATH
env variable, modulePaths is an array of
absolute paths to additional locations to
search when resolving modules. [array]
--noStackTrace Disables stack trace in test results output
[boolean]
--notify Activates notifications for test results.
[boolean]
--notifyMode Specifies when notifications will appear for
test results. [string] [default: "always"]
--onlyChanged, -o Attempts to identify which tests to run based
on which files have changed in the current
repository. Only works if you're running tests
in a git or hg repository at the moment.
[boolean]
--onlyFailures, -f Run tests that failed in the previous
execution. [boolean]
--outputFile Write test results to a file when the --json
option is also specified. [string]
--passWithNoTests Will not fail if no tests are found (for
example while using `--testPathPattern`.)
[boolean] [default: false]
--preset A preset that is used as a base for Jest's
configuration. [string]
--projects A list of projects that use Jest to run all
tests of all projects in a single instance of
Jest. [array]
--reporters A list of custom reporters for the test suite.
[array]
--resetMocks Automatically reset mock state between every
test. Equivalent to calling
jest.resetAllMocks() between each test.
[boolean]
--resetModules If enabled, the module registry for every test
file will be reset before running each
individual test. [boolean]
--resolver A JSON string which allows the use of a custom
resolver. [string]
--restoreMocks Automatically restore mock state and
implementation between every test. Equivalent
to calling jest.restoreAllMocks() between each
test. [boolean]
--rootDir The root directory that Jest should scan for
tests and modules within. [string]
--roots A list of paths to directories that Jest
should use to search for files in. [array]
--runInBand, -i Run all tests serially in the current process
(rather than creating a worker pool of child
processes that run tests). This is sometimes
useful for debugging, but such use cases are
pretty rare. [boolean]
--runTestsByPath Used when provided patterns are exact file
paths. This avoids converting them into a
regular expression and matching it against
every single file. [boolean] [default: false]
--setupFiles The paths to modules that run some code to
configure or set up the testing environment
before each test. [array]
--setupTestFrameworkScriptFile The path to a module that runs some code to
configure or set up the testing framework
before each test. [string]
--showConfig Print your jest config and then exits.
[boolean]
--silent Prevent tests from printing messages through
the console. [boolean]
--snapshotSerializers A list of paths to snapshot serializer modules
Jest should use for snapshot testing. [array]
--testEnvironment Alias for --env [string]
--testFailureExitCode Exit code of `jest` command if the test run
failed [string]
--testLocationInResults Add `location` information to the test results
[boolean] [default: false]
--testMatch The glob patterns Jest uses to detect test
files. [array]
--testNamePattern, -t Run only tests with a name that matches the
regex pattern. [string]
--testPathIgnorePatterns An array of regexp pattern strings that are
matched against all test paths before
executing the test. If the test path matches
any of the patterns, it will be skipped.
[array]
--testPathPattern A regexp pattern string that is matched
against all tests paths before executing the
test. [array]
--testRegex The regexp pattern Jest uses to detect test
files. [string]
--testResultsProcessor Allows the use of a custom results processor.
This processor must be a node module that
exports a function expecting as the first
argument the result object [string]
--testRunner Allows to specify a custom test runner. The
default is `jasmine2`. A path to a custom
test runner can be provided:
`<rootDir>/path/to/testRunner.js`. [string]
--testURL This option sets the URL for the jsdom
environment. [string]
--timers Setting this value to fake allows the use of
fake timers for functions such as setTimeout.
[string]
--transform A JSON string which maps from regular
expressions to paths to transformers. [string]
--transformIgnorePatterns An array of regexp pattern strings that are
matched against all source file paths before
transformation. [array]
--unmockedModulePathPatterns An array of regexp pattern strings that are
matched against all modules before the module
loader will automatically return a mock for
them. [array]
--updateSnapshot, -u Use this flag to re-record snapshots. Can be
used together with a test suite pattern or
with `--testNamePattern` to re-record snapshot
for test matching the pattern [boolean]
--useStderr Divert all output to stderr. [boolean]
--verbose Display individual test results with the test
suite hierarchy. [boolean]
--watch Watch files for changes and rerun tests
related to changed files. If you want to
re-run all tests when a file has changed, use
the `--watchAll` option. [boolean]
--watchAll Watch files for changes and rerun all tests.
If you want to re-run only the tests related
to the changed files, use the `--watch`
option. [boolean]
--watchPathIgnorePatterns An array of regexp pattern strings that are
matched against all paths before trigger test
re-run in watch mode. If the test path matches
any of the patterns, it will be skipped.
[array]
--watchman Whether to use watchman for file crawling.
Disable using --no-watchman. [boolean]
Documentation: https://facebook.github.io/jest/
```
## spawn()
Here's an example `spawn()` script:
```js
const cp = require('child_process');
const out = [];
const p = cp.spawn('./node_modules/.bin/jest', ['--help'], {
cwd: process.cwd(),
maxBuffer: 1000 * 1000 * 10, // 10 MB
});
p.stdout.on('data', line => {
out.push(String(line));
});
p.on('close', code => {
console.log(code);
console.log(out.join(''));
});
```
And the captured output:
```
0
Usage: jest [--config=<pathToConfigFile>] [TestPathPattern]
Options:
--help, -h Show help [boolean]
--all The opposite of `onlyChanged`. If
`onlyChanged` is set by default, running jest
with `--all` will force Jest to run all tests
instead of running only tests related to
changed files.
--automock Automock all files by default. [boolean]
--bail, -b Exit the test suite immediately upon the first
failing test. [boolean]
--browser Respect the "browser" field in package.json
when resolving modules. Some packages export
different versions based on whether they are
operating in node.js or a browser. [boolean]
--cache Whether to use the transform cache. Disable
the cache using --no-cache. [boolean]
--cacheDirectory The directory where Jest should store its
cached dependency information. [string]
--changedFilesWithAncestor Runs tests related to the current changes and
the changes made in the last commit. Behaves
similarly to `--onlyChanged`. [boolean]
--changedSince Runs tests related the changes since the
provided branch. If the current branch has
diverged from the given branch, then only
changes made locally will be tested. Behaves
similarly to `--onlyChanged`. [string]
--ci Whether to run Jest in continuous integration
(CI) mode. This option is on by default in
most popular CI environments. It will prevent
snapshots from being written unless explicitly
requested. [boolean] [default: false]
--clearCache Clears the configured Jest cache directory and
then exits. Default directory can be found by
calling jest --showConfig [boolean]
--clearMocks Automatically clear mock calls and instances
between every test. Equivalent to calling
jest.clearAllMocks() between each test.
[boolean]
--collectCoverage Alias for --coverage. [boolean]
--collectCoverageFrom An array of glob patterns relative to
<rootDir> matching the files that coverage
info needs to be collected from. [array]
--collectCoverageOnlyFrom Explicit list of paths coverage will be
restricted to. [array]
--color Forces test results output color highlighting
(even if stdout is not a TTY). Set to false if
you would like to have no colors. [boolean]
--colors Alias for `--color`. [boolean]
--config, -c The path to a jest config file specifying how
to find and execute tests. If no rootDir is
set in the config, the current directory is
assumed to be the rootDir for the project.
This can also be a JSON encoded value which
Jest will use as configuration. [string]
--coverage Indicates that test coverage information
should be collected and reported in the
output. [boolean]
--coverageDirectory The directory where Jest should output its
coverage files. [string]
--coveragePathIgnorePatterns An array of regexp pattern strings that are
matched against all file paths before
executing the test. If the file pathmatches
any of the patterns, coverage information will
be skipped. [array]
--coverageReporters A list of reporter names that Jest uses when
writing coverage reports. Any istanbul
reporter can be used. [array]
--coverageThreshold A JSON string with which will be used to
configure minimum threshold enforcement for
coverage results [string]
--debug Print debugging info about your jest config.
[boolean]
--detectLeaks **EXPERIMENTAL**: Detect memory leaks in
tests. After executing a test, it will try to
garbage collect the global object used, and
fail if it was leaked
[boolean] [default: false]
--env The test environment used for all tests. This
can point to any file or node module.
Examples: `jsdom`, `node` or
`path/to/my-environment.js` [string]
--expand, -e Use this flag to show full diffs instead of a
patch. [boolean]
--findRelatedTests Find related tests for a list of source files
that were passed in as arguments. Useful for
pre-commit hook integration to run the minimal
amount of tests necessary. [boolean]
--forceExit Force Jest to exit after all tests have
completed running. This is useful when
resources set up by test code cannot be
adequately cleaned up. [boolean]
--globalSetup The path to a module that runs before All
Tests. [string]
--globalTeardown The path to a module that runs after All
Tests. [string]
--globals A JSON string with map of global variables
that need to be available in all test
environments. [string]
--haste A JSON string with map of variables for the
haste module system [string]
--json Prints the test results in JSON. This mode
will send all other test output and user
messages to stderr. [boolean]
--lastCommit Run all tests affected by file changes in the
last commit made. Behaves similarly to
```
Notice that about half the output is missing.
## exec()
Another attempt using `exec()`.
```js
const cp = require('child_process');
cp.exec('./node_modules/.bin/jest --help', {
cwd: process.cwd(),
maxBuffer: 1000 * 1000 * 10, // 10 MB
}, (error, stdout) => {
console.log(stdout);
});
```
The output is the same as the truncated above.
## Execa
Another attempt using `execa`.
```js
const execa = require('execa');
execa('jest', ['--help']).then(result => {
console.log(result.code);
console.log(result.stdout);
});
```
The output is the same as the truncated above. | child_process,macos,stdio | medium | Critical |
303,360,361 | rust | Reference to a #[thread_local] is dereferenced too early | I'm working on the [dynamic library for elfmalloc](https://github.com/ezrosent/allocators-rs/tree/master/elfc) for Mac, and one of the caveats that we have to work with is that, during dynamic library loading, TLS is unavailable (if you try to access a `#[thread_local]`, the program simply aborts).
In order to work around this, we have a mechanism which checks to make sure that dynamic loading is finished before we access any thread-local storage (see the [`with` method](https://github.com/ezrosent/allocators-rs/blob/6f85313c51f42f0b4f8ea7d6d938caa5eab54412/alloc-tls/src/lib.rs#L209)).
Recently, we encountered a strange bug: We were spuriously accessing thread-local values while dynamic loading was still happening. The code in question looks like this:
```rust
pub unsafe fn alloc(size: usize) -> *mut u8 {
LOCAL_ELF_HEAP.with(|h| (*h.get()).alloc.alloc(size))
.unwrap_or_else(|| super::large_alloc::alloc(size))
}
```
`LOCAL_ELF_HEAP` is a `#[thread_local]` variable, and in the `with` method, we make sure that dynamic loading is done before we dereference `&self`. To make a long story short, it appears as though the generated code has reordered the instructions to dereference `LOCAL_ELF_HEAP` *before* we check to make sure that dynamic loading is done. You can see that in the disassembly of the `alloc` method (output from lldb):
```text
0x10f1b7670 <+0>: pushq %rbp
0x10f1b7671 <+1>: movq %rsp, %rbp
0x10f1b7674 <+4>: subq $0x40, %rsp
0x10f1b7678 <+8>: leaq -0x20(%rbp), %rax
0x10f1b767c <+12>: leaq -0x28(%rbp), %rcx
0x10f1b7680 <+16>: movq %rdi, -0x28(%rbp)
0x10f1b7684 <+20>: movq %rcx, -0x10(%rbp)
0x10f1b7688 <+24>: movq -0x10(%rbp), %rdx
0x10f1b768c <+28>: leaq 0xaf5f5(%rip), %rdi ; elfmalloc::general::global::LOCAL_ELF_HEAP::h7d8e035078da16c9
0x10f1b7693 <+35>: movq %rax, -0x30(%rbp)
0x10f1b7697 <+39>: movq %rdx, -0x38(%rbp)
0x10f1b769b <+43>: callq *(%rdi)
-> 0x10f1b769d <+45>: leaq -0x20(%rbp), %rdi
0x10f1b76a1 <+49>: movq %rax, %rsi
0x10f1b76a4 <+52>: movq -0x38(%rbp), %rdx
0x10f1b76a8 <+56>: callq 0x10f1e2ac0 ; _$LT$alloc_tls..TLSSlot$LT$T$GT$$GT$::with::h2a59e6dd7499a672 at lib.rs:209
0x10f1b76ad <+61>: leaq -0x20(%rbp), %rdi
0x10f1b76b1 <+65>: leaq -0x28(%rbp), %rax
0x10f1b76b5 <+69>: movq %rax, -0x8(%rbp)
0x10f1b76b9 <+73>: movq -0x8(%rbp), %rsi
0x10f1b76bd <+77>: callq 0x10f1eb9a0 ; _$LT$core..option..Option$LT$T$GT$$GT$::unwrap_or_else::h09d8edc34df58ca5 at option.rs:373
0x10f1b76c2 <+82>: movq %rax, -0x40(%rbp)
0x10f1b76c6 <+86>: movq -0x40(%rbp), %rax
0x10f1b76ca <+90>: addq $0x40, %rsp
0x10f1b76ce <+94>: popq %rbp
0x10f1b76cf <+95>: retq
```
The `->` points to where the next instruction to be executed at the time that the program aborted. The `callq` is to `libdyld.dylib`'s `_tlv_bootstrap`, which is simply [implemented as](https://opensource.apple.com/source/dyld/dyld-239.3/src/threadLocalVariables.c) `abort();`.
The key thing to note is that the call to `_tlv_boostrap` (which attempts - and fails - to access the `#[thread_local]`) is *before* the call to `with` a couple of instructions later. I'm not positive, but my hypothesis is that the compiler reordered the accesses because immutable references are supposed to guarantee that the referent exists, and so it thought that the reordering was valid. | O-macos,T-compiler,A-thread-locals,C-bug | low | Critical |
303,378,122 | react-native | Rotate transform not working well on View with borderRadius | When rotating a component, its children also rotate as expected, except for the `View`s with `borderRadius > 0`, which their rounded border does not rotate.
### Environment
Environment:
OS: macOS High Sierra 10.13.3
Node: 8.9.0
Yarn: 1.5.1
npm: 5.7.1
Watchman: 4.9.0
Xcode: Xcode 9.2 Build version 9C40b
Android Studio: 3.0 AI-171.4443003
Packages: (wanted => installed)
react: ^16.3.0-alpha.1 => 16.3.0-alpha.1
react-native: ^0.54.0 => 0.54.0
### Expected Behavior
Borders should rotate like everything else.
### Actual Behavior
<div>
<img width="300" alt="SCREENSHOT" src="https://user-images.githubusercontent.com/619186/37137472-9fcced60-2284-11e8-8ee5-7484d624366a.png">
<img width="300" alt="GIF" src="https://user-images.githubusercontent.com/619186/37137698-b6ee6130-2285-11e8-9bc0-bd91e6268518.gif" />
</div>
> ^ The one from the right has `overflow: hidden` on the main photo container, so things got worse. We actually can notice it's not just the border, but the actual view mask / clip bounds that's not rotating.
### Steps to Reproduce
[ANDROID] https://snack.expo.io/@brunolemos/react-native---border-radius-rotate-bug
<details>
<summary>Full Code</summary>
```jsx
import React, { Component } from 'react';
import { Image, Text, View, StyleSheet } from 'react-native';
import { Constants } from 'expo';
export default class App extends Component {
render() {
return (
<View style={styles.container}>
<View style={styles.block}>
<View style={styles.textContainer}>
<Text>SQUARE</Text>
<Image
source={require('./assets/logo_facebook_square.png')}
style={styles.image}
/>
</View>
<View style={[styles.textContainer, { borderRadius: 10 }]}>
<Text>ROUND</Text>
<Image
source={require('./assets/logo_facebook_square.png')}
style={[styles.image, { borderRadius: 10 }]}
/>
</View>
</View>
<View style={[styles.block, { transform: [{ rotate: '-10deg' }] }]}>
<View style={styles.textContainer}>
<Text>SQUARE</Text>
<Image
source={require('./assets/logo_facebook_square.png')}
style={styles.image}
/>
</View>
<View style={[styles.textContainer, { borderRadius: 10 }]}>
<Text>ROUND</Text>
<Image
source={require('./assets/logo_facebook_square.png')}
style={[styles.image, { borderRadius: 10 }]}
/>
</View>
</View>
</View>
);
}
}
const styles = StyleSheet.create({
container: {
flex: 1,
alignItems: 'center',
justifyContent: 'center',
paddingTop: Constants.statusBarHeight,
backgroundColor: '#ecf0f1',
},
block: {
justifyContent: 'center',
alignItems: 'center',
marginBottom: 60,
width: 200,
height: 200,
backgroundColor: 'white',
},
textContainer: {
flexDirection: 'row',
justifyContent: 'center',
alignItems: 'center',
margin: 10,
padding: 10,
borderWidth: 2,
borderColor: 'red',
},
image: {
width: 40,
height: 40,
borderWidth: 4,
borderColor: 'green',
},
});
```
</details>
### Investigating + Related
After more investigation this is what I found:
- Everything works fine on react-native 0.49.5;
- `rotate + borderRadius > 0 + overflow:hidden` bug introduced on 0.50.0; (https://github.com/facebook/react-native/commit/30044fd531c22c4c5e8f1ede206fa7c2c3fd3aa8?)
- `rotate + borderRadius > 0 + borderWidth > 0` bug introduced on 0.51.0; (https://github.com/facebook/react-native/commit/4994d6a389b4e41ba25e802edab5d3fdc9e8a4f1?)
- Bug still present on 0.54.0.
Possibly related:
- Commit https://github.com/facebook/react-native/commit/30044fd531c22c4c5e8f1ede206fa7c2c3fd3aa8 (v0.50; cc @AaaChiuuu)
- Commit https://github.com/facebook/react-native/commit/4994d6a389b4e41ba25e802edab5d3fdc9e8a4f1 (0.51; cc @rsnara)
- Issue #18208: Border not scaling on Android 7.0
- Issue #17400: Non zero borderRadius brakes transform on Android
- Issue #17224: Border not animating with scale in 0.51.0
- Issue #17074: Overflow does not work and is inconsistent with iOS, #6802 | Ran Commands,Issue: Author Provided Repro,Impact: Regression,Platform: Android,Resolution: Fixed | high | Critical |
303,451,174 | opencv | OE-28 "Image Stitching" Module | ## Stitching Module
* Author: Jiri Horner
* Link: https://github.com/opencv/opencv/wiki/OE-28.-Image-Stitching
* Status: Open
* Platforms: **All**
* Complexity: 1-2 man-weeks
## Introduction and Rationale
Stitching module has been around for quite some time and hasn't been refreshed to match changes in rest of the OpenCV.
Stitcher interface is widely used from Python, but lots of features can't be controlled from Python. User experience should be improved.
There is no interoperability with features2d module, all feature finders need to be wrapped manually for stitching module.
Dependencies on legacy CUDA stuff in stitching module let to some compilation problems recently.
Dependencies on xfeatures2d makes it impossible for distributions to provide patent-free stitching module while offering patented algorithms to use with for users that need them.
## Proposed solution
* remove `detail::FeaturesFinder` and `detail::FeaturesMatcher` wrapper classes. Use `cv::Feature2D` and `cv::DescriptorMatcher` from features2d module. This will allow to use all features and descriptors with stitching modules. Move all estimation code from `detail::FeaturesMatcher` to `detail::Estimator`. This also solves problems with dependencies on xfeatures2d.
* allow user to explicitly set `detail::Estimator`
* consolidate creation methods for stitcher. Keep only `Stitcher::create`, wrap this method for Python. Drop `try_use_gpu` flag, rely on T-API or user explicitly setting CUDA classes to use.
* allow users to set FeaturesFinder, DescriptorMatcher, BundleAdjuster etc. from Python
* drop legacy usage of legacy Levenberg–Marquardt API from bundle adjusters. Replace with new LevMarq API.
* remove direct usage of CUDA from stitching module (OpenCL alternatives are already available). Move to CUDA modules where it makes sense.
## Impact on existing code, compatibility
Changes in Stitcher interface might require some changes in user code. We could introduce some wrapper classes and aliases to ease transition towards using new API with classes from features2d.
## Possible alternatives
Keep as is.
## References
https://github.com/opencv/opencv/issues?utf8=%E2%9C%93&q=is%3Aissue+label%3A%22category%3A+gpu+%28cuda%29%22+stitching
cc @vpisarev
| category: stitching,evolution | low | Major |
303,576,791 | go | net: TestLookupGoogleSRV and TestLookupGmailMX flaky on builders | During [CL98775](https://go-review.googlesource.com/c/go/+/98775): [build742ae1bd](https://storage.googleapis.com/go-build-log/742ae1bd/linux-amd64-race_65be7a03.log)
```
--- FAIL: TestLookupGoogleSRV (5.01s)
lookup_test.go:76: lookup _xmpp-server._tcp.google.com on 10.3.240.10:53: read udp 10.0.7.69:46483->10.3.240.10:53: read: connection refused
--- FAIL: TestLookupGmailMX (10.01s)
lookup_test.go:113: lookup gmail.com on 10.3.240.10:53: read udp 10.0.7.69:41650->10.3.240.10:53: read: connection refused
FAIL
FAIL net 29.755s
```
The failure disappeared during second try-bots run.
Most likely a temporary network issue on builder.
Filling this in case this pops up again in near time. | Testing,Builders,NeedsInvestigation | low | Critical |
303,596,069 | puppeteer | Scripts are not evalutated in header and footer HTML templates for PDFs. | ### Steps to reproduce
* Puppeteer version: 1.1.1
* Platform / OS version: Windows 10, version 1709, build 16299.248
* Node.js version: v7.9.0
**What steps will reproduce the problem?**
First, I setup a basic test page like this:
```jsx
const browser = await puppeteer.launch({ignoreHTTPSErrors: true})
const page = await browser.newPage()
await page.setContent(`
<html>
<head>
<title>Test Page</title>
<style>
body{
background: yellow;
min-height: 6000px;
}
</style>
</head>
<body>
I'm an HTML page.
</body>
</html>
`)
const pdf = await page.pdf({
format: 'Letter',
printBackground: true,
headerTemplate: headerTemplate,
displayHeaderFooter: true,
margin: {
top: '1in',
right: '0in',
bottom: '1in',
left: '0in'
}
})
await browser.close()
```
The `headerTemplate` looks like this:
```jsx
const headerTemplate = `
<div style="font-size: 10px; display: flex; flex-direction: row; justify-content: space-between; width: 100%" id='template'>
<div class='pageNumber' id='num' style="font-size: 10px;">Page number</div>
<div class='date' style="font-size: 10px;"></div>
<div class='title' style="font-size: 10px;"></div>
<div class='url' style="font-size: 10px;"></div>
<div class='totalPages' style="font-size: 10px;"></div>
<script>
var pageNum = document.getElementById("num");
pageNum.remove()
var template = document.getElementById("template")
template.style.background = 'red';
</script>
</div>`
```
**What is the expected result?**
The docs don't mention whether or not script tags are supported in the header and footer templates. I would expect then that the code above would render a header with a red background and remove the page number node. (The code above was just for testing purposes).
**What happens instead?**
The script appears not to evaluate. Instead the resulting PDF has no background, and a page number div.
If evaluating scripts in these templates is not supported, might I suggest updating the PDF section of the docs to state as much. Thanks for all the hard work the Puppeteer team has put into this project!
| feature,upstream,chromium,confirmed | high | Critical |
303,623,712 | go | cmd/compile: slice update with self subslice - write barrier probably not needed (?) | Commit b8543397 (CL 98757) changes encoding/binary to use explicit offset instead of `buf = buf[1:]` idiom with the rationale that `buf = buf[1:]` is slice data pointer update which in turn is done with write barrier, while using `buf[offset]` explicitly does not need to update buf slice pointer and so does not need to issue GC write barrier. The commit cites significant speedup for encoding/binary under GOGC=1 and notes that While running make.bash, over 5% of all pointer writes come from encoding/binary doing struct reads.
It was then noted there that instead of explicitly using offset and avoiding `buf = buf[1:]` update idiom for performance reasons, it would be better to instead teach the compiler to know that slice updates with destination array pointer pointing to the same array's underlying object as of original slice, e.g. as in
`buf = buf[1:]` does not need write barrier at all.
The conversation there contains the rationale for current compiler behaviour but also brings questions and arguments for why it can be done. It was suggested to move the conversation to the issues, so here it goes.
--------
@josharian thinking out loud maybe it is better to instead teach the compiler to know that slice updates with destination array pointer pointing to the same array's underlying object as of original slice, e.g. as in
```go
buf = buf[1:]
```
does not need write barrier at all?
The rationale (to my limited write barriers understanding) is that it is whole allocated object that is shaded by write barrier:
```
// writePointer(slot, ptr):
// shade(*slot)
// if current stack is grey:
// shade(ptr)
// *slot = ptr
...
// 1. shade(*slot) prevents a mutator from hiding an object by moving
// the sole pointer to it from the heap to its stack. If it attempts
// to unlink an object from the heap, this will shade it.
//
// 2. shade(ptr) prevents a mutator from hiding an object by moving
// the sole pointer to it from its stack into a black object in the
// heap. If it attempts to install the pointer into a black object,
// this will shade it.
```
(https://github.com/golang/go/blob/d7eb4901/src/runtime/mbarrier.go#L21)
```go
func shade(b uintptr) {
if obj, span, objIndex := findObject(b, 0, 0); obj != 0 {
...
```
(https://github.com/golang/go/blob/d7eb4901/src/runtime/mgcmark.go#L1211)
```go
func findObject(p, refBase, refOff uintptr) (base uintptr, s *mspan, objIndex uintptr) {
s = spanOf(p)
...
```
(https://github.com/golang/go/blob/d7eb4901/src/runtime/mbitmap.go#L354)
and so for `buf = buf[1:]` the slice, either before or after the update, will be pointing to inside the same allocated object -> thus the mutator for sure won't hide the allocated object from GC and so there is no need to shade it with such updates.
Doing so in the compiler will fix the performance issue this patch solves, as well as automatically remove write barriers in other, probably many, places thus helping not only speed but also code size (#6853).
I appologize if there is something trivial preventing doing this, that I missed.
Kirill
/cc @aclements
--------
@aclements says:
The danger here is subtle. We haven't done this because the update to buf could be racy and if we did this that race could break GC. Specifically, if one goroutine executes `buf = buf[1:]` without a write barrier while another executes `buf = x` with a write barrier, it's possible for the final value of `buf` to continue pointing to the original buf allocation, but for the garbage collector to think it points to the `x` allocation and free the original `buf` allocation.
Of course, racy Go programs are undefined, but right now the garbage collector is immune to these sorts of non-type-safety-breaking "benign" races (this is obviously a somewhat fuzzy argument, since races let you break type safety and that lets you break memory safety, and saying anything formal about "benign" races is notoriously impossible so what I'm saying is probably not true anyway, but we try :)
--------
@dgryski says:
@aclements It would be interesting to see the effect such an update would have on code size and performance to know how much we're leaving on the table with this safety check on.
--------
me says:
@aclements thanks for explaining. Am I right that with write-barriers enabled for both racy buf updates, the mechanism that prevents GC from deallocating wrong object is that in the current GC written `ptr` is always shaded too (https://github.com/golang/go/blob/go1.10-1-g678dede7bc/src/runtime/mbarrier.go#L162 (go1.10), https://github.com/golang/go/blob/0add9a4dcf/src/runtime/mwbbuf.go#L226 (tip)) ?
By the way the thread that performs `buf = x` with write barrier will always do `shade(*slot)`. If there is `buf = buf[1:]` racing with `buf = x`, even if the former does not use write barrier, the `shade(*slot)` of `buf = x` thread will shade original `buf` object in _any_ case (it either sees `buf` or `buf+1` as `*slot` but they both actually lead to the same allocated object). If so, since `shade` actually greys an object and grey objects never become white - only eventually black, we can say that original `buf` underlying object will stay alive - not deallocated, and so it is safe to do `buf = buf[1:]` without write barrier.
But this goes contrary to what you say, and so there is probably some mistake on my side. Could you please explain where the above logic fails?
I'm GC newbie so please forgive me if I miss something well-known.
--------
@josharian says:
@navytux would you mind opening a new issue and migrating this (interesting) discussion there? We tend to try to keep all conversation on CLs and issues. Thanks!
| Performance,compiler/runtime | low | Major |
303,703,096 | vscode | Settings editor should search known keys in object type settings | Issue Type: <b>Settings Search Issue</b>
I would have expected to find this as a sub-section of workbench color customizations.
VS Code version: Code - Insiders 1.22.0-insider (a9dcb2c3159367e347271d88c399e1f6ca88c23d, 2018-03-08T22:21:18.293Z)
OS version: Darwin x64 16.7.0
<details><summary>Extensions (21)</summary>
Extension|Author (truncated)|Version
---|---|---
vsc-material-theme|Equ|1.5.0
material-icon-theme|PKi|3.2.3
vscode-docker|Pet|0.0.25
code-settings-sync|Sha|2.9.0
solargraph|cas|0.13.0
npm-intellisense|chr|1.3.0
githistory|don|0.4.0
gitlens|eam|8.1.0
tslint|eg2|1.0.28
vscode-npm-script|eg2|0.3.3
git-project-manager|fel|1.4.0
svgpreview|kis|0.2.0
Go|luk|0.6.77
vscode-azurestorage|ms-|0.2.0
mssql|ms-|1.3.0
python|ms-|2018.2.0
azure-account|ms-|0.3.1
vsliveshare|ms-|0.2.206
printcode|nob|2.0.4
Ruby|reb|0.17.0
vscode-open-in-github|ziy|1.3.1
</details><details><summary>Results</summary>
Setting|Extension|Score
---|---|---
mssql.query.displayBitAsNumber|ms-mssql.mssql|0.478
openInGitHub.requireSelectionForLines|ziyasal.vscode-open-in-github|0.394
openInGitHub.gitHubDomain|ziyasal.vscode-open-in-github|0.136
openInGitHub.providerType|ziyasal.vscode-open-in-github|0.133
mssql.format.placeSelectStatementReferencesOnNewLine|ms-mssql.mssql|0.122
npm-intellisense.importLinebreak|christian-kohler.npm-intellisense|0.064
printcode.webServerPort|nobuhito.printcode|0.057
gitHistory.pageSize|donjayamanne.githistory|0.052
gitHistory.showEditorTitleMenuBarIcons|donjayamanne.githistory|0.047
printcode.tabSize|nobuhito.printcode|0.036
gitProjectManager.recentProjectsListSize|felipecaputo.git-project-manager|0.030
npm.bin|eg2.vscode-npm-script|0.019
gitHistory.hideCommitViewExplorer|donjayamanne.githistory|0.013
mssql.format.datatypeCasing|ms-mssql.mssql|0.011
mssql.format.keywordCasing|ms-mssql.mssql|0.011
npm-intellisense.showBuildInLibs|christian-kohler.npm-intellisense|0.010
azureStorage.file.showSavePrompt|ms-azuretools.vscode-azurestorage|0.007
mssql.format.alignColumnDefinitionsInColumns|ms-mssql.mssql|0.007
gitProjectManager.warnIfFolderNotFound|felipecaputo.git-project-manager|0.007
mssql.format.placeCommasBeforeNextStatement|ms-mssql.mssql|0.006
</details>
Query: editor active line number
Literal matches: 0
<!-- generated by issue reporter --> | feature-request,settings-editor | low | Major |
303,712,761 | vscode | Emmet completions disappear when using bem in the presence of other snippets | <!-- Do you have a question? Please ask it on https://stackoverflow.com/questions/tagged/vscode. -->
<!-- Use Help > Report Issue to prefill these. -->
- VSCode Version: 1.22.0-ins
- OS Version: win7x64
Bootstrap 4+ snippets extensions are installed.
Well, first of all, I'm a little confused how "**bem**" matches with **b**4-**me**dia-....
But even if so, do we have an option for Emmet to have higher priority on every other extension? | bug,emmet,confirmed | low | Minor |
303,721,588 | rust | Unsize isn't implemented for unions | This came up in the fix for #48493. It seems like unions should have unsize impls for all of their fields?
```rust
#![feature(untagged_unions, unsize, coerce_unsized)]
use std::marker::Unsize;
use std::ops::CoerceUnsized;
union Data<T: ?Sized> {
v: T,
u: (),
}
struct Pointer<T: ?Sized>(Box<Data<T>>);
impl<T: ?Sized + Unsize<U>, U: ?Sized> CoerceUnsized<Pointer<U>> for Pointer<T> {}
fn main() {}
```
```
error[E0277]: the trait bound `Data<T>: std::marker::Unsize<Data<U>>` is not satisfied
--> src/main.rs:12:1
|
12 | impl<T: ?Sized + Unsize<U>, U: ?Sized> CoerceUnsized<Pointer<U>> for Pointer<T> {}
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the trait `std::marker::Unsize<Data<U>>` is not implemented for `Data<T>`
|
= note: required because of the requirements on the impl of `std::ops::CoerceUnsized<std::boxed::Box<Data<U>>>` for `std::boxed::Box<Data<T>>`
error: aborting due to previous error
If you want more information on this error, try using "rustc --explain E0277"
error: Could not compile `playground`.
To learn more, run the command again with --verbose.
``` | C-enhancement,T-compiler,needs-rfc | low | Critical |
303,764,406 | rust | Spurious "note: downstream crates may implement trait `Foo` for type `&_`" | The following code:
```rust
trait Foo {}
impl<T: Foo> std::fmt::Display for T {
fn fmt(&self, f: &mut std::fmt::Formatter) -> std::fmt::Result {
Ok(())
}
}
```
produces the following compiler output:
```
error[E0119]: conflicting implementations of trait `std::fmt::Display` for type `&_`:
--> src/main.rs:3:1
|
3 | impl<T: Foo> std::fmt::Display for T {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: conflicting implementation in crate `core`:
- impl<'a, T> std::fmt::Display for &'a T
where T: std::fmt::Display, T: ?Sized;
= note: downstream crates may implement trait `Foo` for type `&_`
error[E0210]: type parameter `T` must be used as the type parameter for some local type (e.g. `MyStruct<T>`); only traits defined in the current crate can be implemented for a type parameter
--> src/main.rs:3:1
|
3 | / impl<T: Foo> std::fmt::Display for T {
4 | | fn fmt(&self, f: &mut std::fmt::Formatter) -> std::fmt::Result {
5 | | Ok(())
6 | | }
7 | | }
| |_^
error: aborting due to 2 previous errors
```
While there might be legitimate reasons why this is not allowed, the note is wrong: the trait `Foo` is not public, a downstream can't possibly implement it for some type. | C-enhancement,A-diagnostics,T-lang,T-compiler | medium | Critical |
303,765,848 | flutter | Installation failed when a path includes special characters | ## Steps to Reproduce
```
$ pwd
/Volumes/Hard disk drive #1/Code
$ git clone -b beta https://github.com/flutter/flutter.git
Cloning into 'flutter'...
remote: Counting objects: 114951, done.
remote: Compressing objects: 100% (3/3), done.
remote: Total 114951 (delta 0), reused 0 (delta 0), pack-reused 114948
Receiving objects: 100% (114951/114951), 34.72 MiB | 1.40 MiB/s, done.
Resolving deltas: 100% (85931/85931), done.
$ export PATH=`pwd`/flutter/bin:$PATH
$ flutter doctor
Downloading Dart SDK from Flutter engine ead227f118077d1f2b57842a32abaf105b573b8a...
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 43.3M 100 43.3M 0 0 8075k 0 0:00:05 0:00:05 --:--:-- 9352k
Building flutter tool...
vm-service: Error: Unhandled exception:
Unsupported operation: Cannot extract a file path from a URI with a fragment component
#0 _Uri.toFilePath (dart:core/uri.dart:2597)
#1 _loadFile (loader.dart:427:26)
#2 _handleResourceRequest (loader.dart:512:7)
#3 _processLoadRequest (loader.dart:1017:9)
#4 _RawReceivePortImpl._handleMessage (dart:isolate-patch/dart:isolate/isolate_patch.dart:165)
```
| c: crash,tool,dependency: dart,P2,team-tool,triaged-tool | low | Critical |
303,787,073 | scrcpy | Add On Screen buttons | My phone has capacitive buttons, and because of that i don't have on-screen buttons. A command line argument for showing the buttons would be nice. | feature request | high | Critical |
303,789,370 | vscode | Double-click selection matches some escaped characters | Issue Type: <b>Bug</b>
If you have a string with the "\t", "\n", etc. sequences followed by a word, double-clicking the word will select the escaped character as well:
VS Code version: Code 1.21.0 (9a199d77c82fcb82f39c68bb33c614af01c111ba, 2018-03-07T11:01:43.521Z)
OS version: Linux x64 4.10.0-42-generic
<details>
<summary>System Info</summary>
|Item|Value|
|---|---|
|CPUs|Intel(R) Core(TM) i7-6700 CPU @ 3.40GHz (8 x 3142)|
|Load (avg)|0, 1, 1|
|Memory (System)|15.56GB (3.82GB free)|
|Process Argv|/usr/share/code/code --unity-launch|
|Screen Reader|no|
|VM|0%|
</details><details><summary>Extensions (7)</summary>
Extension|Author (truncated)|Version
---|---|---
vscode-icontheme-nomo-dark|be5|1.3.5
vscode-eslint|dba|1.4.7
githistory|don|0.4.0
auto-close-tag|for|0.5.6
docthis|joe|0.6.0
python|ms-|2018.2.0
color-highlight|nau|2.3.0
(1 theme extensions excluded)
</details>
Reproduces without extensions
<!-- generated by issue reporter --> | feature-request,under-discussion,editor-wordnav | low | Critical |
303,811,582 | neovim | option: use numbered registers for smaller deletions | Once upon a time, there was a [bug that was causing small deletions appear in the numbered registers](
https://groups.google.com/d/msg/vim_dev/pbN4rAw8LmI/jR54qQjvuOsJ) under some conditions. Then it was fixed.
And now there's no way to use such a useful bugfeature.
Ingo Karkat who reported this bug also proposed a super-useful option `smalldeletethreshold`, which I'm dying without.
I hope that Neovim development is not so sluggish as Vim development and this feature-request can survive. I even ready to try implementing it...
### Actual behaviour
Deletions like `d5w` has no history, though it's a kind of a large amount of text. If I use `d5w`, then jump to the insertion place and use `x` to fix a small thing, I'll lose the `d5w`'d text completely.
### Expected behaviour
I want to set a (non-existing) `smalldeletethreshold` option to 2 so that all deletions larger than `x` are pushed into the numbered registers "1.."9.
| enhancement,options | low | Critical |
303,827,488 | rust | Value returned by `to_owned` doesn't always *own* the data | For example:
```
let a = vec![1, 2];
let s = Some(&a);
let r = vec![];
if let Some(ref v) = s {
r = v.to_owned();
}
```
This doesn't compile:
```
error[E0308]: mismatched types
--> src/main.rs:6:13
|
6 | r = v.to_owned();
| ^^^^^^^^^^^^ expected struct `std::vec::Vec`, found reference
|
= note: expected type `std::vec::Vec<_>`
found type `&std::vec::Vec<{integer}>`
```
Relates to #43236. | C-enhancement,T-libs-api | low | Critical |
303,843,782 | go | cmd/link: silently performs incorrect relocations when linking foreign objects | For example, [when linking syso files](https://github.com/FiloSottile/ed25519-dalek-rustgo/pull/1#issuecomment-371611831).
Adding `go:cgo_import_dynamic` helps but (1) it was recently disabled for security reasons for non-cgo files, then reenabled because solaris needs it, so it's unclear if this policy will persist in the long-run for all architectures, and (2) you need to specify it for specific symbols rather than for all symbols. In any case, an error should be raised with a hint on what to do, rather than succeeding silently with invalid output.
The equivalent thing in Haskell [Just Works](https://github.com/infinity0/ed25519-dalek-rustgo/commit/31f4ed2feccd87c2ecefc805cfe11264e0d2394c) with no extra annotations.
| NeedsInvestigation | low | Critical |
303,854,222 | go | x/build/cmd/gerritbot: too many comments on a new pull request | For example: https://github.com/golang/go/pull/24322
I would expect two comments - "This PR has been imported to Gerrit", and the forward of the "Congratulations on opening your first change" automated comment.
However, somehow gerritbot (or perhaps GitHub?) seem to think that the pull request needed importing twice, or that it was updated when it doesn't look like it was.
Or perhaps the pull request was updated while gerritbot was importing it, resulting in these duplicate and confusing messages. | Builders,NeedsInvestigation | low | Minor |
303,891,130 | TypeScript | Javascript modules should be able to pass the exported value to child modules | <!-- 🚨 STOP 🚨 𝗦𝗧𝗢𝗣 🚨 𝑺𝑻𝑶𝑷 🚨 -->
<!--
Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker.
Please help us by doing the following steps before logging an issue:
* Search: https://github.com/Microsoft/TypeScript/search?type=Issues
* Read the CONTRIBUTING guidelines: https://github.com/Microsoft/TypeScript/blob/master/CONTRIBUTING.md
* Read the FAQ: https://github.com/Microsoft/TypeScript/wiki/FAQ
-->
<!-- If you have a QUESTION:
THIS IS NOT A FORUM FOR QUESTIONS.
Ask questions at http://stackoverflow.com/questions/tagged/typescript
or https://gitter.im/Microsoft/TypeScript
-->
<!-- If you have a SUGGESTION:
Most suggestion reports are duplicates, please search extra hard before logging a new suggestion.
See https://github.com/Microsoft/TypeScript-wiki/blob/master/Writing-Good-Design-Proposals.md
-->
<!-- If you have a BUG:
Please fill in the *entire* template below.
-->
<!-- Please try to reproduce the issue with `typescript@next`. It may have already been fixed. -->
**TypeScript Version:** 2.7.0-dev.201xxxxx
<!-- Search terms you tried before logging this (so others can find this issue more easily) -->
**Search Terms:**
**Code**
```ts
// @noEmit: true
// @allowJs: true
// @checkJs: true
// @Filename: bluebird.js
var bluebird = require('./promise')()
bluebird.promisify
bluebird.outer
module.exports = bluebird
// @Filename: promise.js
module.exports = function() {
function Promise() {
}
Promise.outer = function () {
}
require('./promisify')(Promise)
Promise.promisify
Promise.outer
return Promise
}
// @Filename: promisify.js
module.exports = function (Promise) {
Promise.promisify = function () {
}
}
```
**Expected behavior:**
Bluebird's assignments to Promise in both promise.js and promisify.js should be visible in both promise.js and bluebird.js
**Actual behavior:**
`promisify` is not recognised in promise.js or bluebird.js. This seems very difficult to track statically, especially in the binder. | Bug,checkJs,Domain: JavaScript | low | Critical |
303,904,121 | scrcpy | Add a cli option to start as 1:1 | I’m not sure I fully understood why scrcpy does not start as 1:1 right away on my computer since the window does fit on screen after I press ctrl+g.
But there should be a cli option to start as 1:1 anyway as it can be useful is some situations, even when it does not fit on screen. | feature request | low | Minor |
303,909,714 | TypeScript | Javascript should allow non-top-level assignment to exports assignments |
```ts
// @noEmit: true
// @allowJs: true
// @checkJs: true
// @Filename: core.js
exports.load = load
exports.loaded = false
function load(conf) {
if (conf) {
exports.loaded = conf
}
}
```
**Expected behavior:**
No error.
**Actual behavior:**
Both uses of `loaded` have the error "cannot redeclare exported variable `loaded`". | Bug,Domain: JavaScript | low | Critical |
303,913,870 | kubernetes | Enabling ResourceQuotas increases controller-manager CPU usage ~4x | Based on https://github.com/kubernetes/kubernetes/issues/60589#issuecomment-371876879
After enabling quotas (specifically pods per namespace) by default in our tests, we're continuously seeing such failures:
```
Container kube-controller-manager-e2e-big-master/kube-controller-manager is using 0.531144723/0.5 CPU
not to have occurred
```
This may be a serious issue with scalability of quotas and needs some digging in.
/assign @gmarek
(who enabled it.. feel free to redirect this as apt)
cc @kubernetes/sig-scalability-bugs | kind/bug,priority/important-soon,sig/scalability,lifecycle/frozen | low | Critical |
303,919,347 | go | go/printer, gofmt: line directives specifying columns must stay in place relative to next token | gofmt changes the code
```
package p
/*line foo:10:12*/func g() /*line :20:13*/{}
```
to
```
package p
/*line foo:10:12*/
func g()/*line :20:13*/ {}
```
which changes the positions of some tokens. Generally, gofmt changes positions, but in the case of line directives specifying specific line and column values we want those values to remain stable.
See also #22662, #24143, and #24183. | NeedsFix | low | Minor |
303,945,371 | go | go/parser: redundant error message with unexpected comma | Please answer these questions before submitting your issue. Thanks!
### What version of Go are you using (`go version`)?
go version go1.10 linux/amd64
### Does this issue reproduce with the latest release?
yes
### What did you do?
```
package main
func f() {}
func main() {
f(,)
}
/*
...
*/ // missing ',' in argument list
```
### What did you expect to see?
[edit]
```
$ go fmt a.go
a.go:6:4: expected operand, found ','
```
### What did you see instead?
```
$ go fmt a.go
a.go:6:4: expected operand, found ','
a.go:11:37: missing ',' in argument list
```
| NeedsFix,gopls/parsing | low | Critical |
303,980,950 | TypeScript | Assignments to global objects in Javascript should be global declarations | ```ts
// @noEmit: true
// @allowJs: true
// @checkJs: true
// @Filename: a.js
global.x = 1
window.y = 2
this.z = 3
var n = x + y + z
```
**Expected behavior:**
No error, and x, y and z are visible globally.
**Actual behavior:**
Errors:
1. Can't find name 'global'
2. 'Window' has no property 'y'
3. Cannot find name 'x', 'y' or 'z'
Ideally, `global` should only be visible when targetting node and `window` should only be visible when targetting the browser. It's not a requirement, though. | Bug,Help Wanted,Effort: Moderate,Experience Enhancement,Rescheduled | low | Critical |
304,015,593 | TypeScript | In Javascript, `typeof x !== undefined ? t : f` should act like a declaration of `x` in the true branch | **Search Terms:**
existence of define typeof undefined
**Code**
```ts
// @noEmit: true
// @allowJs: true
// @checkJs: true
// @strict: true
// @Filename: a.js
if (typeof define !== 'undefined' && define.amd) {
define([], function() {
})
}
// also, nested
exports.storage = 'undefined' != typeof chrome &&
'undefined' != typeof chrome.storage ?
chrome.storage.local :
undefined;
```
**Expected behavior:**
The check `type define !== undefined` should cause the true branch of the conditional to act as if `define` were declared.
**Actual behavior:**
Cannot find name 'define'. | Bug,Domain: JavaScript | low | Minor |
304,024,997 | flutter | Clearing the Console on the Mac Terminal makes the Flutter Tooling hang | I am on a macOS High Sierra 10.13.3 using the default Terminal.app using zsh. The Flutter tools connect to a remote application on an iOS device when invoked with `flutter run`. I can interact with the application via the service protocol like normal (for example, a hot-reload with `r`). Clearing the console makes the tooling hang up and unresponsive to further keystrokes. I used CMD+K on the Mac. | tool,P2,team-tool,triaged-tool | low | Minor |
304,056,976 | opencv | Feature request / evolutionary proposal - abstraction layer for concurrent data containers similar to TBB and PPL | # Feature request / evolutionary proposal - abstraction layer for concurrent data containers similar to TBB and PPL
Author: Ryan Wong (@kinchungwong)
Link: TBD
Status: pre-**Draft**
> Feature request submitted from public - not yet discussed by team
Platforms: **All**
> This proposal abstracts over concurrent containers (```concurrent_vector```, ```concurrent_queue```, etc) in TBB and PPL so that (1) other platforms can have access to a fallback implementation (2) both OpenCV and its users can access such facility without writing platform-specific ```#ifdef```s.
Complexity: **no estimates**
> (1) new facility; does not affect existing code
> (2) for platforms already have TBB and PPL, wrapping is trivial
> (3) for other platforms, initial version may use a C++11/14 mutex-based fallback which is inferior but acceptable. A good fallback will be a future evolutionary proposal.
> (4) after implementation, existing code can be migrated to use new facility, gradually
> (5) users of OpenCV will find it useful
# Introduction and Rationale
Several of the Evolutionary Proposals already place a requirement on having such concurrency containers. It is foreseeable that some Evolutionary Proposals may eventually require exposing these containers to OpenCV users.
Specifically:
* <b>OE-11, Logging</b>, may require a concurrent queue to:
* Latch (buffer) messages,
* Maintain the cross-thread timestamp order of logging events
* <b>OE-16, Mini-Halide</b>, may require a task graph (OE-23), which is typically built on top of concurrency containers from TBB and PPL
* <b>OE-17, New Filter Engine</b>, may require a facility <b>stronger than ```ParallelLoopBody```</b>. An example is diamond task completion dependency (example: parallel task A and B; when both A and B are finished then start task C).
* <b>OE-23, Task Graph execution engine</b>, same as above.
# Proposed Solution
## Initial lightweight wrapper capability
* Applies only to for platforms with TBB or PPL enabled.
* Interface wrapper for `concurrent_vector`, `concurrent_queue`, `concurrent_unordered_map` in respective framework
## Initial fallback capability
* Mutex-based wrapper around C++ standard containers
## Future enhancement
* A better fallback implementation that satisfies either lock-free or obstruction-free guarantee, in order to match the same guarantees as in TBB and PPL.
* Actual performance (CPU overhead, RAM overhead) is nice-to-have but do not need to compete with TBB or PPL.
# Impact on existing code, compatibility
The abstraction wrapper code will be new.
May require C++14 or C++17. In other words, ***currently it is unsure whether C++11 can be sufficient***.
Existing code can be migrated to use the new code over a long period of time. Unmigrated code can continue to use platform-specific ```ifdef``` in order to use TBB or PPL.
# Possible alternatives
The status quo. Some code can continue to use TBB or PPL, such as https://github.com/opencv/opencv/blob/master/modules/core/src/parallel.cpp
Inability to give OpenCV users access to these concurrent containers may impede the dependent OEs, namely OE-11, OE-16, OE-17, OE-23.
# References
(todo)
# Information about proposal author (This section can be removed by the team after review)
I have worked on these things before so I know what is required. However, my ability to contribute code may be subject to a legal release arrangement (that is being discussed) with my former employer. My C++ coding skill is moderately well (enough to have the experience of working on this type of stuff) but probably not world-class. | feature,RFC | low | Major |
304,061,496 | vscode | Add a setting to not promote workspace folders to top level if they are children of another top level folder | In case a multi-root configuration is composed of workspace folders that are overlapping (e.g. one is the parent of the other), add a setting to not promote those workspace folders are top level folders of the file explorer that are already included in another workspace folder.
Extracted from https://github.com/Microsoft/vscode/issues/45399 | feature-request,file-explorer,workbench-multiroot | high | Critical |
304,073,132 | angular | WebRTC with Angular is not working on iOS Safari | ## I'm submitting a...
<pre><code>
[ ] Regression (a behavior that used to work and stopped working in a new release)
[X] Bug report <!-- Please search GitHub for a similar issue or PR before submitting -->
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question
</code></pre>
## Current behavior
WebRTC with Angular is not working on iOS Safari. Using WebRTC without Angular works fine on iOS Safari. The localStream freezes after the RTCPeerConnection is established. There are no problems on Desktop/Safari, Desktop/Chrome and Android/Chrome.
## Expected behavior
The localStream should not freeze after the RTCPeerConnection is established on iOS Safari.
## Minimal reproduction of the problem with instructions
Apple is natively supporting WebRTC since iOS 11 and Safari 11 on the desktop.
As a base for testing I used:
https://github.com/webrtc/samples/tree/gh-pages/src/content/peerconnection/pc1
Because this example has `playsinline` missing in `video` element it's not working on iOS Safari. I took the code of this example in a plunker and added `playsinline`.
App:
https://run.plnkr.co/plunks/z4BJ5OJxFM5WQp7ndD6g/
Editor:
https://plnkr.co/edit/z4BJ5OJxFM5WQp7ndD6g
Tested this plunker in iOS Safari (version 11.2.6) on a iPhone 6 (A1586) and iPad mini 2 (A1489). That is working fine !!
Now the same code I put into an Angular app:
App:
https://webrtc-angular-test.stackblitz.io/
Editor:
https://stackblitz.com/edit/webrtc-angular-test
In `polyfills.ts` added patches:
```
import 'zone.js/dist/webapis-rtc-peer-connection';
import 'zone.js/dist/zone-patch-user-media';
```
#### In detail what goes wrong:
The 'Start' button works fine. When I give permission localStream is visible. After 'Call' button the localStream freezes. The remoteStream is visible normal. No error messages in the console.
## Environment
<pre><code>
Angular version: 5.0.0
Browser:
- [ ] Chrome (desktop) version XX
- [ ] Chrome (Android) version XX
- [ ] Chrome (iOS) version XX
- [ ] Firefox version XX
- [ ] Safari (desktop) version XX
- [x] Safari (iOS) version 11.2.6
- [ ] IE version XX
- [ ] Edge version XX
</code></pre>
I also written an issue in the `zone.js` without any result:
https://github.com/angular/zone.js/issues/1019 | type: bug/fix,freq2: medium,area: core,area: zones,core: DOM rendering,state: needs more investigation,P3 | low | Critical |
304,076,702 | go | debug/pe: big-obj is not supported | cgo doesn't support the [big-obj](https://docs.microsoft.com/en-us/cpp/build/reference/bigobj-increase-number-of-sections-in-dot-obj-file) format.
### What version of Go are you using (`go version`)?
```
go version go1.10 windows/amd64
```
### Does this issue reproduce with the latest release?
Yes.
### What operating system and processor architecture are you using (`go env`)?
```
set GOARCH=amd64
set GOOS=windows
```
### What did you do?
I tried to link a `.o` file which is generated with the `-Wa,-mbig-obj` gcc option.
See the following background for detail.
### What did you expect to see?
The big-obj format is supported by cgo.
### What did you see instead?
```
cannot parse gcc output $WORK\b001\\_cgo_.o as ELF, Mach-O, PE object
```
The message is produced at here: https://github.com/golang/go/blob/5c432fe0e3755255d70d1ad601725b039becb7ad/src/cmd/cgo/gcc.go#L1586
I suppose `debug/pe` doesn't support the big-obj format.
### Background
I'm now trying to use [wxGo](https://github.com/dontpanic92/wxGo), but the size of an executable file is quite big (~30MB), so I tried to reduce the size by using `-fdata-sections -ffunction-sections` CPPFLAGS and `-Wl,--gc-sections` LDFLAGS. (See: https://stackoverflow.com/a/6770305/4570471)
However, this caused the following error:
```
C:/TDM-GCC-64/bin/../lib/gcc/x86_64-w64-mingw32/5.1.0/../../../../x86_64-w64-mingw32/bin/as.exe: $WORK\b001\_x003.o: too many sections (70137)
C:\Users\*******\AppData\Local\Temp\ccjbnMxS.s: Fatal error: can't close $WORK\b001\_x003.o: File too big
```
This is because the traditional PE-COFF format stores the number of sections with a 16-bit signed integer. To support more than 32K sections, the [big-obj](https://docs.microsoft.com/en-us/cpp/build/reference/bigobj-increase-number-of-sections-in-dot-obj-file) format is needed, and the `-Wa,-mbig-obj` CPPFLAGS can be used for that. However, cgo doesn't support the big-obj format.
Steps to reproduce:
```
path C:\TDM-GCC-64\bin;%PATH%
set "CGO_LDFLAGS_ALLOW=-Wl,--subsystem,windows|-mwindows"
set "CGO_CPPFLAGS_ALLOW=-fdata-sections|-ffunction-sections|-Wa,-mbig-obj"
go get -u -d github.com/dontpanic92/wxGo/wx
cd %GOPATH%\src\github.com\dontpanic92\wxGo
```
Then apply the following patch to wxGo:
```diff
--- a/wx/setup_windows_amd64.go
+++ b/wx/setup_windows_amd64.go
@@ -1,6 +1,6 @@
package wx
-// #cgo CPPFLAGS: -I${SRCDIR}/windows_amd64/ -I${SRCDIR}/../wxWidgets/wxWidgets-3.1.0/include -D_FILE_OFFSET_BITS=64 -D__WXMSW__
+// #cgo CPPFLAGS: -I${SRCDIR}/windows_amd64/ -I${SRCDIR}/../wxWidgets/wxWidgets-3.1.0/include -D_FILE_OFFSET_BITS=64 -D__WXMSW__ -fdata-sections -ffunction-sections -Wa,-mbig-obj
// #cgo !wxgo_binary_package_build LDFLAGS: -L${SRCDIR}/windows_amd64/lib -lwxmsw31u -lwxmsw31u_gl -lwxscintilla -lwxregexu -lwxexpat -lwxtiff -lwxjpeg -lwxpng -lwxzlib
// #cgo mingw_workaround LDFLAGS: -Wl,--subsystem,windows,--allow-multiple-definition
// #cgo !mingw_workaround LDFLAGS: -Wl,--subsystem,windows
```
Then:
```
cd wx
go install -x .
```
The following error is shown:
```
cannot parse gcc output $WORK\b001\\_cgo_.o as ELF, Mach-O, PE object
```
Cf. in case of Haskell: https://ghc.haskell.org/trac/ghc/ticket/13815 | help wanted,NeedsFix | low | Critical |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.