id
int64 393k
2.82B
| repo
stringclasses 68
values | title
stringlengths 1
936
| body
stringlengths 0
256k
β | labels
stringlengths 2
508
| priority
stringclasses 3
values | severity
stringclasses 3
values |
|---|---|---|---|---|---|---|
296,868,665 | go | runtime: always log GC details in-memory | Whenever a user reports a potential issue with the GC, the first thing we ask for is a GC trace (GODEBUG=gctrace=1). We rarely get it.
gctrace=1 is cheap enough to leave on all the time, but spamming stderr is poor form. Instead, the runtime could log it in memory somewhere, either as text or structured data, and expose it in a /debug handler or something. Then it'd be much easier to pull on demand.
This might also be useful for GODEBUG=sched{detail,trace} but I haven't seen that come up as often. | NeedsFix,compiler/runtime | low | Critical |
296,871,235 | kubernetes | Fuzz or matrix test the API server | We have seen a variety of problems where misconfiguration causes the `{kube-apiserver,kube-controller-manager}` to `{crashloop,otherwise prevent repair of the problem}`.
Examples:
- webhook that won't let you do anything (including delete it) #59124 #56761
- apiservice without an endpoint, but the service can never get healthy because k-c-m won't come up #55271
There is a huge space of these problems, and while we have some specific cases, we would do well to try some intelligent fuzz testing to root out more.
If fuzz testing is too much work at first, sharing a single matrix-based test around misconfigurations would be a very, very good start.
cc @lavalamp @jennybuckley @cheftako
/kind feature-request
/area testing
/sig api-machinery
/priority important-soon | area/test,priority/important-soon,sig/api-machinery,kind/feature,sig/testing,priority/important-longterm,lifecycle/frozen | low | Critical |
296,875,859 | flutter | Smooth checkbox value animation segues | It would nice to have smooth segues for cases where a tristate checkbox's value changes in the middle of its animation cycle.
For example: currently if the value changes from true to null at t=0.75 we just abruptly start rendering a dash. This happens in 50ms so users who haven't slowed the animation speed are unlikely to notice. Instead of the abrupt change we could use the 50ms to animate the check away, per the existing animation, and animate the dash in.
Or cross-fade from the check to the dash.
See https://github.com/flutter/flutter/pull/14611
| framework,a: animation,f: material design,a: quality,P3,team-design,triaged-design | low | Major |
296,944,554 | pytorch | [feature request] Stratified splits in random_split function | It's probably less of an issue on "biggish" datasets, but a param for specifying stratification in `random_split` (which was merged here: #4435) would be nice. If the targets are class labels this could be done based on the integer labels. For regression problems, there are some interesting ideas posted here: http://scottclowe.com/2016-03-19-stratified-regression-partitions/
If this is of interest, we could discuss how to implement that efficiently, I am happy to help.
cc @SsnL @VitalyFedyunin | module: dataloader,triaged | low | Minor |
296,968,434 | kubernetes | Kubernetes is vulnerable to stale reads, violating critical pod safety guarantees | When we added resourceVersion=0 to reflectors, we didn't properly reason about its impact on nodes. Its current behavior can cause two nodes to run a pod with the same name at the same time when using multiple api servers, which violates the pod safety guarantees on the cluster. Because a read serviced by the watch cache can be arbitrarily delayed, a client that connects to that api server can read an arbitrarily old history. We explicitly use quorum reads against etcd to prevent this.
Scenario:
1. T1: StatefulSet controller creates `pod-0` (uid 1) which is scheduled to `node-1`
2. T2: `pod-0` is deleted as part of a rolling upgrade
3. `node-1` sees that `pod-0` is deleted and cleans it up, then deletes the pod in the api
4. The StatefulSet controller creates a second pod `pod-0` (uid 2) which is assigned to `node-2`
5. `node-2` sees that `pod-0` has been scheduled to it and starts `pod-0`
6. The kubelet on `node-1` crashes and restarts, then performs an initial list of pods scheduled to it against an API server in an HA setup (more than one API server) that is partitioned from the master (watch cache is arbitrarily delayed). The watch cache returns a list of pods from before T2
7. `node-1` fills its local cache with a list of pods from before T2
7. `node-1` starts `pod-0` (uid 1) and `node-2` is already running `pod-0` (uid 2).
This violates pod safety. Since we support HA api servers, we cannot use `resourceVersion=0` from reflectors on the node, and probably should not use it on the masters. We can only safely use `resourceVersion=0` after we have retrieved at least one list, and only if we verify that resourceVersion is in the future.
@kubernetes/sig-apps-bugs @kubernetes/sig-api-machinery-bugs @kubernetes/sig-scalability-bugs This is a fairly serious issue that can lead to cluster identity guarantees being lost, which means clustered software cannot run safely if it has assumed the pod safety guarantee prevents two pods with the same name running on the cluster at the same time. The user impact is likely data loss of critical data.
This is also something that could happen for controllers - during a controller lease failover the next leader could be working from a very old cache and undo recent work done.
No matter what, the first list of a component with a clean state that must preserve "happens-before" must perform a live quorum read against etcd to fill their cache. That can only be done by omitting resourceVersion=0.
Fixes:
1. Disable resourceVersion=0 from being used in reflector list, only use when known safe
2. Disable resourceVersion=0 for first list, and optionally use resourceVersion=0 for subsequent calls if we know the previous resourceVersion is after our current version (assumes resource version monotonicity)
3. Disable resourceVersion=0 for the first list from a reflector, then send resourceVersion=<latest> on subsequent list calls (which causes the watch cache to wait until the resource version shows up).
4. Perform live reads from Kubelet on all new pods coming in to verify they still exist
1 is a pretty significant performance regression, but is the most correct and safest option (just like we enabled quorum reads everywhere). 2 is more complex, and there are a few people trying to remove the monotonicity guarantees from resource version, but would retain most of the performance benefits of using this in the reflector. 3 is probably less complex than 2, but i'm not positive it actually works. 4 is hideous and won't fix other usage.
Probably needs to be backported to 1.6. | kind/bug,priority/important-soon,sig/scalability,sig/api-machinery,sig/apps,lifecycle/frozen | high | Critical |
296,968,628 | godot | Multiple Godot instances conflict with each other | **Godot version:**
3.0 stable
**OS/device including version:**
Any
**Issue description:**
When running Godot as a part of CI on a build machine, multiple instances of Godot can be launched
to work with different workspaces. However, at least one problem with this is that Godot may create temporary files (grep `get_cache_dir()`) with same paths for different runs, so you get a race condition between multiple instances. This has caused problems in our actual workflow - when two separate jobs run Godot on the same machine, we get corrupted packages as a result. | bug,topic:core | low | Major |
296,970,763 | opencv | Latest doxygen (1.8.14) segfaults | ##### System information (version)
- OpenCV => 3.4.0
- Operating System / Platform => Linux 64 Bit
- Compiler => gcc-7.3
- doxygen => 1.8.14
##### Detailed description
Previously, using doxygen-1.8.9.1, generating documentation completed OK.
However using latest doxygen-1.8.14, ```make doxygen``` fails with segmentation fault:
```
[100%] Generate Doxygen documentation
make[3]: *** [doc/CMakeFiles/doxygen_cpp.dir/build.make:392: doc/CMakeFiles/doxygen_cpp] Segmentation fault
make[2]: *** [CMakeFiles/Makefile2:13022: doc/CMakeFiles/doxygen_cpp.dir/all] Error 2
make[1]: *** [CMakeFiles/Makefile2:12965: doc/CMakeFiles/doxygen.dir/rule] Error 2
make: *** [Makefile:3135: doxygen] Error 2
```
##### Steps to reproduce
Upgrade to lastest doxygen-1.8.14. After usual cmake configuration & make, run ```make doxygen```.
Running doxygen directly on generated Doxyfile gives no extra clue:
```
root@sl64current:/var/tmp/SBo/opencv-3.4.0/build# doxygen doc/Doxyfile
Segmentation fault
root@sl64current:/var/tmp/SBo/opencv-3.4.0/build#
```
Again, reverting to doxygen-1.8.9.1 runs without any problem.
| category: documentation,incomplete | low | Critical |
296,987,594 | rust | Compiling crate serde-derive with "-Z sanitizer=leak" fails | Compiling my crate that uses `serde` with `RUSTFLAGS="-Z sanitizer=leak"` results in:
```
error: Only executables, staticlibs, cdylibs, dylibs and rlibs can be compiled with `-Z sanitizer`
```
Verbose output shows:
```
Running `rustc --crate-name cubeb_core cubeb-core/src/lib.rs --crate-type lib --emit=dep-info,link -C debuginfo=2 -C metadata=61d1a8a7b2e564d0 -C extra-filename=-61d1a8a7b2e564d0 --out-dir /home/djg/Mozilla/cubeb-rs/target/debug/deps -C incremental=/home/djg/Mozilla/cubeb-rs/target/debug/incremental -L dependency=/home/djg/Mozilla/cubeb-rs/target/debug/deps --extern cubeb_sys=/home/djg/Mozilla/cubeb-rs/target/debug/deps/libcubeb_sys-f4b7e696cf674255.rlib --extern foreign_types=/home/djg/Mozilla/cubeb-rs/target/debug/deps/libforeign_types-9d464a343a654ec3.rlib --extern bitflags=/home/djg/Mozilla/cubeb-rs/target/debug/deps/libbitflags-709a54b1053b84e9.rlib -Z sanitizer=leak -L native=/home/djg/Mozilla/cubeb-rs/target/debug/build/cubeb-sys-52b952c542113788/out/lib -L native=/usr/lib64 -L native=/usr/lib64 -L native=/usr/lib64`
error: aborting due to previous error
error: Could not compile `serde_derive`.
Caused by:
process didn't exit successfully: `rustc --crate-name serde_derive /home/djg/.cargo/registry/src/github.com-1ecc6299db9ec823/serde_derive-1.0.27/src/lib.rs --crate-type proc-macro --emit=dep-info,link -C prefer-dynamic -C debuginfo=2 --cfg feature="default" -C metadata=8e2449096591e6bb -C extra-filename=-8e2449096591e6bb --out-dir /home/djg/Mozilla/cubeb-rs/target/debug/deps -L dependency=/home/djg/Mozilla/cubeb-rs/target/debug/deps --extern syn=/home/djg/Mozilla/cubeb-rs/target/debug/deps/libsyn-b487ac40d22b413a.rlib --extern quote=/home/djg/Mozilla/cubeb-rs/target/debug/deps/libquote-2902a853682299e0.rlib --extern serde_derive_internals=/home/djg/Mozilla/cubeb-rs/target/debug/deps/libserde_derive_internals-dcd3ff49aa5d175c.rlib --cap-lints warn -Z sanitizer=leak` (exit code: 101)
``` | T-compiler,A-sanitizers,A-macros-2.0,C-bug | low | Critical |
297,001,684 | TypeScript | Understand 'int', 'integer', 'float', 'double', etc. as 'number' in JSDoc | All numeric-sounding names should probably resolve to `number` (maybe only if no other type is defined with such a given name).
Ideas:
* `[u]int[8|16|32|64]`
* `integer`
* `float`
* `double` | Suggestion,Awaiting More Feedback,Domain: JavaScript | low | Major |
297,036,023 | puppeteer | headerTemplate and footerTemplate only work with truthy values | **Tell us about your environment:**
* Puppeteer version: 1.0.0
* Platform / OS version: Ubuntu 16.04
* URLs (if applicable):
* Node.js version: 6.12.3
**What steps will reproduce the problem?**
```
await page.pdf({
headerTemplate: '',
footerTemplate: '',
});
```
**What is the expected result?**
The header and footer should be blank.
**What happens instead?**
The default header and footer are still shown.
It seems that passing any falsey value results in the default template being used instead. I would suggest that only `undefined` should cause it to use the default template. Empty string, `null`, `false` and `0` should all override the default template.
Thanks.
| feature,upstream,chromium | low | Minor |
297,071,900 | go | x/build: sharded iOS builders | Currently, the android/amd64 and android/386 builders run on an Android emulator with a amd64 system image. This is taxing the heavyly loaded mobile builder Mac Mini. It is also inefficient: the emulator builds competes with Android device builds and any concurrent iOS builds. Because builds are slow, android is not in the trybot set, leaving me to often pester CL authors with "this CL broke android".
Is it possible to add (and run) the Android emulator inside the existing docker images used for regular builders and then run android sharded tests as any other GOOS? If so, android/amd64 and android/386 builds would complete much faster, and take some pressure off the mobile device builder.
If the emulator builds are stable enough, android/amd64 (and perhaps android/386) could even join the trybot set, avoiding most (if not all) android specific followup work after a CL is submitted. | Builders,NeedsInvestigation,mobile,new-builder | high | Major |
297,083,864 | go | x/build/cmd/gerritbot: don't post CL updates if the PR author has a Gerrit account | For example: https://github.com/golang/go/pull/23809
If gerritbot successfully added the PR author as a reviewer or as CC to the Gerrit CL, it makes little sense to forward comment/review updates to the Github pull request in the form of comments. | Builders | low | Minor |
297,143,566 | vscode | "Download Now" button should respect the used installation method on Linux | ### Issue Type
Bug
### Description
> __Edit:__ Originally this issue was specifically about the `.deb` installation method, but since this problem is not specific to it, I edited the issue to be more general.
#### How to reproduce
1. Install (an outdated version of) VS Code using one of the installation methods.
2. Open VSCode and wait for the `(1)` to appear on the settings icon.
3. Click on the settings icon and then on **Download Now**.
#### Expected behavior
VSCode starts the download of the latest version's file (when the `.tar.gz` was used to install VS Code) or instructs the user to run an update through the relevant package manager.
#### Actual behavior
VS Code always starts the download of the latest version's `.tar.gz` file.
### Possible solution
VS Code could check what type of download was used to install and behave differently based on that.
Checking whether a `.deb` was used could look something like this:
```ts
import { spawn } from 'child_process';
export function isDebInstallation(): Promise<boolean> {
return new Promise(resolve => {
spawn('dpkg', ['--list', 'code']).on('close', code => {
resolve(code === 0);
});
});
}
```
Another option would be to include the information about what installation method was used in the release.
### VS Code Info
VS Code version: Code 1.20.0 (c63189deaa8e620f650cc28792b8f5f3363f2c5b, 2018-02-07T17:10:15.949Z)
OS version: Linux x64 4.13.0-32-generic
<details>
<summary>System Info</summary>
|Item|Value|
|---|---|
|CPUs|Intel(R) Core(TM) i5-4590 CPU @ 3.30GHz (4 x 3300)|
|Load (avg)|1, 1, 1|
|Memory (System)|15.61GB (10.31GB free)|
|Process Argv|/usr/share/code/code .|
|Screen Reader|no|
|VM|0%|
</details>
Reproduces without extensions | help wanted,feature-request,install-update,linux | medium | Critical |
297,149,437 | rust | incr.comp.: Do per-MonoItem dependency tracking in order to collect data about granularity fallout. | Currently the compiler only allocates a single `DepNode` per CGU. This is enough for implementing object file re-use but we are losing information about what items within an object file exactly caused it to be re-compiled. In order to gather more information about how CGU partitioning affects re-use, it would be good to know which `MonoItems` within a CGU were changed and which were not.
Before making this the default though, we should check how it affects the number of `DepNodes` and edges in the graph. | C-enhancement,T-compiler,A-incr-comp | low | Minor |
297,151,147 | rust | incr.comp.: Allow for re-using object files that contain unused code. | Right now, incremental compilation can only re-use an object file if it is an exact match of that code that we want. In theory it would be possible though to keep using an object file that contains a superset of the code we need.
An implementation would probably need https://github.com/rust-lang/rust/issues/48211 to be implemented first. CGU translation would also need to be de-querified since the re-use decision cannot be made by simply marking the CGU as green.
However, before putting effort into implementing this we should make sure that it would actually pay off. For this we need to collect some data on `MonoItem` invalidation (which again is covered by https://github.com/rust-lang/rust/issues/48211). | C-enhancement,T-compiler,A-incr-comp | low | Minor |
297,168,206 | rust | Tracking issue for RFC #2056: Allow trivial constraints to appear in where clauses | This is a tracking issue for the RFC "Allow trivial constraints to appear in where clauses " (rust-lang/rfcs#2056).
**Steps:**
- [x] Implement the RFC β https://github.com/rust-lang/rust/pull/48557
- [ ] As noted in https://github.com/rust-lang/rust/issues/48214#issuecomment-396038764, the new trait solver might solve a few issues with this feature, so this is currently blocked on the new trait solver (`-Znext-solver`)
- [ ] Adjust documentation ([see instructions on forge][doc-guide])
- [ ] Stabilization PR ([see instructions on forge][stabilization-guide])
[stabilization-guide]: https://forge.rust-lang.org/stabilization-guide.html
[doc-guide]: https://forge.rust-lang.org/stabilization-guide.html#updating-documentation
**Unresolved questions:**
- [ ] Should the lint error by default instead of warn? | B-RFC-approved,T-lang,B-unstable,B-RFC-implemented,C-tracking-issue,S-tracking-impl-incomplete,S-tracking-needs-summary,F-trivial_bounds | medium | Critical |
297,217,921 | TypeScript | Glob support for per pattern tsconfig configuration | It's common to have different configurations for files in the same directory with different name patterns. The most common is `file.ts` and `file.test.ts`. We usually have different configurations for test files. For instance the global `"jest"` type is needed in test files but not in source files.
To separate configuration for test and source we can have two separate `tsconfig.json` files which `"include"` only test and source:
```js
// tsconfig.json
{
"exclude": ["*.test.ts"]
}
```
> Exclude glob is pending https://github.com/Microsoft/TypeScript/issues/10202
```js
// test.tsconfig.json
{
"include": ["*.test.ts"],
"compilerOptions": {
"types": ["jest"]
}
}
```
But this is not optimal for IDEs and other tsc users.
### Glob based `tsconfig.json`
I'm proposing a glob based tsconfig.json which has different config per glob pattern:
```js
[
{
// Shared config
"compilerOptions": {}
},
{
"include": ["*.test.ts"],
"compilerOptions": {
"lib": ["jest"]
}
}
]
```
### Changes to `tsconfig.json`
* It can be an array of configurations
* Each item in the array can specify `include` or `exclude` for fine grained compiler options
### Resolving compiler option per file pattern
TODO
### Conflicting exclude and include pattern between compiler options
TODO
this way one tsconfig.json can serve for all files with different configs per pattern
**TypeScript Version:** 2.7
**Search Terms:**
* TSConfig
* Glob
* Pattern
| Suggestion,In Discussion | medium | Major |
297,240,521 | go | cmd/compile: avoid updating capacity if unused | Using go1.10,
Consider the following code:
```go
func IsASCII(b []byte) bool {
for len(b) >= 8 {
x := binary.LittleEndian.Uint64(b)
if x&0x8080808080808080 > 0 {
return false
}
b = b[8:]
}
for _, x := range b {
if x&0x80 > 0 {
return false
}
}
return true
}
```
The compiled assembly is as follows:
```
0x0000 00000 (main.go:11) MOVQ "".b+16(SP), AX
0x0005 00005 (main.go:11) MOVQ "".b+24(SP), CX
0x000a 00010 (main.go:11) MOVQ "".b+8(SP), DX
0x000f 00015 (main.go:12) JMP 45
0x0011 00017 (main.go:17) ADDQ $-8, CX
0x0015 00021 (main.go:17) MOVQ CX, BX
0x0018 00024 (main.go:17) NEGQ CX
0x001b 00027 (main.go:17) SARQ $63, CX
0x001f 00031 (main.go:17) ANDQ $8, CX
0x0023 00035 (main.go:17) ADDQ CX, DX
0x0026 00038 (main.go:17) ADDQ $-8, AX
0x002a 00042 (main.go:17) MOVQ BX, CX
0x002d 00045 (main.go:12) CMPQ AX, $8
0x0031 00049 (main.go:12) JLT 75
0x0033 00051 (main.go:13) MOVQ (DX), BX
0x0036 00054 (main.go:13) MOVQ $-9187201950435737472, SI
0x0040 00064 (main.go:14) TESTQ BX, SI
0x0043 00067 (main.go:14) JLS 17
0x0045 00069 (main.go:15) MOVB $0, "".~r1+32(SP)
0x004a 00074 (main.go:15) RET
0x004b 00075 (main.go:15) MOVL $0, CX
0x004d 00077 (main.go:19) JMP 85
0x004f 00079 (main.go:19) INCQ DX
0x0052 00082 (main.go:19) INCQ CX
0x0055 00085 (main.go:19) CMPQ CX, AX
0x0058 00088 (main.go:19) JGE 104
0x005a 00090 (main.go:19) MOVBLZX (DX), BX
0x005d 00093 (main.go:20) TESTB $-128, BL
0x0060 00096 (main.go:20) JLS 79
0x0062 00098 (main.go:21) MOVB $0, "".~r1+32(SP)
0x0067 00103 (main.go:21) RET
0x0068 00104 (main.go:24) MOVB $1, "".~r1+32(SP)
0x006d 00109 (main.go:24) RET
```
You'll notice that the slice header {ptr, len, cap} are loaded into {DX, AX, CX}. Several times in the assembly, you see the CX register being used as it seems that `b = b[8:]` on line 17 causes the capacity to also be updated.
However, the go code actually does not care about the capacity at all. If the compiler is able to prove that the capacity will never be used, then it could avoid doing the math to ensure that the capacity is up-to-date.
\cc @randall77 @dr2chase | Performance,NeedsFix,compiler/runtime | low | Minor |
297,273,401 | kubernetes | GCE Node Controller is very inefficient with multiple zones | Looking at getInstanceByName https://github.com/kubernetes/kubernetes/blob/release-1.8/pkg/cloudprovider/providers/gce/gce_instances.go#L461, we do a very inefficient search for instances by name. This is free when there is only one zone, and cheap if the product `(number of zones) x (number of nodes)` is small, but it can get out of hand quickly with large, multi-zone clusters.
It not only wastes effort, but it generates a noisy signal on the cloud provider end, as kube-controller-manager starts racking up huge numbers of 404s.
Can we make this more efficient? At the very least, can we please stop logging these as errors? They are expected.
https://github.com/kubernetes/kubernetes/blob/release-1.8/pkg/cloudprovider/providers/gce/gce_instances.go#L483
cc @cheftako
/kind bug
/sig node
/area nodecontroller | kind/bug,area/platform/gce,area/nodecontroller,area/cloudprovider,lifecycle/frozen,sig/cloud-provider,needs-triage | medium | Critical |
297,279,828 | go | x/mobile/app: TestAndroidApp test is failing | Running go test golang.org/x/mobile/app:
````
--- FAIL: TestAndroidApp (1.01s)
app_test.go:232: gomobile version
app_test.go:232: gomobile install golang.org/x/mobile/app/internal/testapp
app_test.go:235: gomobile install golang.org/x/mobile/app/internal/testapp exit status 1: gomobile: manual declaration of uses-sdk in AndroidManifest.xml not supported
FAIL
FAIL golang.org/x/mobile/app 1.015s
````
Even after removing the explicit <uses-sdk> element from app/internal/testapp/AndroidManifest.xml, TestAndroidApp still fails:
````
--- FAIL: TestAndroidApp (2.78s)
app_test.go:232: gomobile version
app_test.go:232: gomobile install golang.org/x/mobile/app/internal/testapp
app_test.go:77: local address: tcp:43823
app_test.go:232: adb reverse tcp:12533 tcp:43823
app_test.go:232: adb shell input keyevent 26
app_test.go:232: adb shell input keyevent 82
app_test.go:232: adb shell content insert --uri content://settings/system --bind name:s:accelerometer_rotation --bind value:i:0
app_test.go:232: adb shell content insert --uri content://settings/system --bind name:s:user_rotation --bind value:i:0
app_test.go:232: adb shell am start -n org.golang.testapp/org.golang.app.GoNativeActivity
app_test.go:128: comm.recv: hello_from_testapp
app_test.go:128: comm.send: hello_from_host
app_test.go:128: comm.recv: lifecycle_visible
app_test.go:128: comm.recv: size 2.2222223 1
app_test.go:128: comm.recv: paint red
app_test.go:232: adb shell content insert --uri content://settings/system --bind name:s:user_rotation --bind value:i:1
app_test.go:128: comm.recv: size 2.2222223 1
app_test.go:151: want orientation 2, got 1
app_test.go:232: adb shell input tap 50 260
app_test.go:128: comm.recv: size 2.2222223 1
app_test.go:127: cannot scan recv command touch: "size 2.2222223 1": EOF
FAIL
FAIL golang.org/x/mobile/app 2.789s
```` | mobile | low | Minor |
297,280,681 | TypeScript | Divide by zero Typechecking | We have type literals for numbers already and a `strictNullCheck` compiler option -- wouldn't it be awesome if we had a type guard again divide-by-zero errors? I'm building a game that involved a lot of math, computing intersections of lines and such. But what if a line is parallel? It would be cool if the compiler would suggest this as a type error.
```
function f(): number | 0 {
return 0
}
const y = 100 / f()
```
<!-- Please try to reproduce the issue with `typescript@next`. It may have already been fixed. -->
**TypeScript Version:** 2.7.0-dev.201xxxxx | Suggestion,In Discussion | low | Critical |
297,315,323 | flutter | Flutter can receive touches even when hidden behind another native ViewController | I have an example at https://github.com/xster/flutter-test/tree/master/t33_animation_with_native
Even after the second view controller was presentViewController'ed, the FlutterViewController still passes events to Flutter.
cc @cbracken any ideas? | platform-ios,engine,customer: posse (eap),has reproducible steps,P2,found in release: 3.7,found in release: 3.8,team-ios,triaged-ios | low | Critical |
297,326,595 | go | net: add support for Happy Eyeballs version 2 (RFC 8305) | Since RFC 6555 published, research papers, for example, Measuring the Effects of Happy Eyeballs, depict improvement space for the RFC. In addition, network or service operators speak up that the race is not only for TCP connection setup but for DNS query handling. [RFC 8305](https://tools.ietf.org/html/rfc8305) Happy Eyeballs version 2 addresses such issues.
To summarize, version 2 clarifies the existing algorithm, modifies the configurable variable values for performance improvement and adds consideration for various circumstances such as IPv6-IPv4 transition and VPN. Luckily, there's no significant user-visible behavioral change.
I'd like to propose to replace the existing RFC 6555 implementation with RFC 8305 implementation after landing dns/dnsmessage package (#16218). | Proposal,Proposal-Accepted | low | Major |
297,372,950 | rust | llvm lint: "unreachable immediately preceded by instruction without side effects" | reduced from https://github.com/alexcrichton/rustc-demangle/
````rust
pub fn demangle(inner: &str) {
inner.chars().peekable().by_ref().take(0).count();
}
````
````
$ RUSTFLAGS="-C passes=lint" cargo build
Compiling rustc-demangle v0.1.5 (file:///tmp/rustc-demangle)
Unusual: unreachable immediately preceded by instruction without side effects
unreachable, !dbg !33
Finished dev [unoptimized + debuginfo] target(s) in 0.31 secs
````
//cc #7463 | A-LLVM,C-enhancement,T-compiler | low | Critical |
297,378,157 | flutter | Support creating projects without all the IntelliJ files | I'm looking at integrating `flutter create` into a command in VS Code. Currently when you run this it outputs a bunch of IntelliJ files that are not wanted if you're working in VS Code. For now I'm thinking of just deleting them, but it'd be nice if they could just be excluded (for example a flag to tell `flutter create` which IDE to create settings for, or a `--no-intellij-files` flag or something).
I think the things that are not required are:
- `.idea` folder
- several `.iml` files in the root | c: new feature,tool,P3,team-tool,triaged-tool | low | Major |
297,464,734 | rust | incr.comp.: Investigate making the result cache updateable in-place. | Right now the compiler will always load and deserialize all query result cache entries that are still valid and then serialize and write them to back to disk again, similar to how a copying garbage collector works. The main reason for implementing the cache this way is that it is very simple.
There might be value in making the cache file updateable in-place in order to save serialization time for unchanged entries. First though, we need some profiling evidence that this would actually save a noticeable amount of time. | C-enhancement,I-compiletime,T-compiler,A-incr-comp | low | Minor |
297,591,855 | pytorch | [feature request] warnings for functions with unspecified dim arguments | Hi,
I noticed that when calling `torch.sort()` without specifying the `dim` argument results in undesired behavior when called on a tensor of dimension nx1. If `dim` is not given in `torch.sort()`, the last dimension of the input is chosen. This is documented but not desirable when the last dimension is 1. A short example for this is the following:
```
import torch
a = torch.randn(10, 1)
print(a)
a_s, _ = torch.sort(a)
print(a_s)
```
yields the same (unsorted) tensor for both `print(a)` and `print(a_s)`
```
1.2201
0.0733
1.6214
0.6704
0.8339
-1.1773
-0.4946
0.4496
0.7240
1.2748
[torch.FloatTensor of size 10x1]
1.2201
0.0733
1.6214
0.6704
0.8339
-1.1773
-0.4946
0.4496
0.7240
1.2748
[torch.FloatTensor of size 10x1]
```
We (that is me, @Kaixhin and @bastings) would suggest to issue a warning in such a case to improve usability.
Cheers,
Christina
| triaged,enhancement | low | Minor |
297,596,973 | flutter | Draw repeat patterns or images with canvas with dart.ui | Please add support for repeating a pattern in a shape, similar to pattern fill support for the HTML canvas.
https://developer.mozilla.org/en-US/docs/Web/API/CanvasRenderingContext2D/createPattern
What I would like to do is draw a small pattern using the existing lines, rects, circles, and other shapes. I would then like to use this pattern as the fill for drawing other elements on the canvas, instead of just a color.
i.e., currently I can draw a rectangle with a solid fill color like so:
```dart
void drawRect(Rectangle<num> bounds, Color fill) {
final paint = new Paint();
paint.color = new Color.fromARGB(fill.a, fill.r, fill.g, fill.b);
paint.style = PaintingStyle.fill;
canvas.drawRect(bounds, paint);
}
```
Instead, I would like to have something like a PantingStyle.repeat, where I can set another canvas element (or similar construct) as the source for the pattern to repeat. | engine,d: api docs,a: images,P2,team-engine,triaged-engine | low | Major |
297,638,334 | rust | Error when canonicalizing path on RAM drive | ```
R:\rust-test>rustc --version --verbose
warning: could not canonicalize path: 'R:\rust-test'
warning: could not canonicalize path: 'R:\rust-test'
warning: could not canonicalize path: 'R:\'
rustc 1.24.0 (4d90ac38c 2018-02-12)
binary: rustc
commit-hash: 4d90ac38c0b61bb69470b61ea2cccea0df48d9e5
commit-date: 2018-02-12
host: x86_64-pc-windows-msvc
release: 1.24.0
LLVM version: 4.0
```
I created a new project using 'cargo new rust-test --bin'
Imported project to Intellij and clicked run. (without Intellij fails as well, just less text)
Console:
```
C:/Users/<username>/.cargo/bin/cargo.exe run --package rust-test --bin rust-test
warning: could not canonicalize path: 'R:\rust-test'
warning: could not canonicalize path: 'R:\rust-test'
warning: could not canonicalize path: 'R:\'
Compiling rust-test v0.1.0 (file:///R:/rust-test)
error: incremental compilation: error canonicalizing path `R:\rust-test\target\debug\incremental\rust_test-1apbc64jn2fjp`: Niepoprawna funkcja. (os error 1)
error: internal compiler error: unexpected panic
note: the compiler unexpectedly panicked. this is a bug.
note: we would appreciate a bug report: https://github.com/rust-lang/rust/blob/master/CONTRIBUTING.md#bug-reports
note: rustc 1.24.0 (4d90ac38c 2018-02-12) running on x86_64-pc-windows-msvc
note: run with `RUST_BACKTRACE=1` for a backtrace
thread 'rustc' panicked at 'src\librustc\session\mod.rs:665: Trying to get session directory from IncrCompSession `NotInitialized`', src\librustc\session\mod.rs:1141:26
stack backtrace:
0: <std::sync::condvar::WaitTimeoutResult as core::fmt::Debug>::fmt
1: <std::time::SystemTimeError as core::fmt::Display>::fmt
2: std::panicking::Location::column
3: std::panicking::Location::column
4: std::panicking::rust_panic_with_hook
5: <alloc::vec::Vec<(alloc::string::String, u64)> as rustc::session::config::dep_tracking::DepTrackingHash>::hash
6: rustc::ty::context::tls::span_debug
7: rustc::session::bug_fmt
8: rustc::session::bug_fmt
9: rustc::session::Session::incr_comp_session_dir
10: rustc_incremental::persist::load::load_dep_graph
11: rustc_driver::driver::compile_input
12: rustc_driver::run_compiler
13: rustc_driver::profile::dump
14: _rust_maybe_catch_panic
15: <rustc_driver::pretty::UserIdentifiedItem as core::fmt::Debug>::fmt
16: <std::sync::condvar::Condvar as core::default::Default>::default
17: std::sys::windows::thread::Thread::new
18: BaseThreadInitThunk
error: Could not compile `rust-test`.
To learn more, run the command again with --verbose.
Process finished with exit code 101
```
'Niepoprawna funkcja.' means 'invalid function'
R is an in-memory drive created using ImDisk program.
cargo new ... cargo run works fine on external ssd drive.
So in-memory drive is probably the cause. Reporting because console output says you will appreciate it. | O-windows,I-ICE,T-compiler,A-incr-comp,C-bug | low | Critical |
297,645,393 | go | x/build/cmd/gopherbot: changes are not seen for refs/meta/config branch | This is due to a Gerrit config problem. gobot canβt see a change (https://go-review.googlesource.com/c/go/+/94016) and so it keeps erroring out and causing a 30s backoff.
Is there a reason why we hide our refs/meta/config from the public?
/cc @bradfitz | Builders,NeedsInvestigation | low | Critical |
297,650,077 | TypeScript | Allow trailing commas in type arguments | <!-- Please try to reproduce the issue with `typescript@next`. It may have already been fixed. -->
**TypeScript Version:** 2.7.1
<!-- Search terms you tried before logging this (so others can find this issue more easily) -->
**Search Terms:** trailing comma template literal types generic
**Code**
```ts
class FooClass<
A,
B,
C,
> {
a: A;
b: B;
c: C;
}
const instance = new FooClass<
boolean,
number,
string, // [ts] Trailing comma not allowed.
>();
```
**Expected behavior:**
No errors as of #16152's resolution.
**Actual behavior:**
`Trailing comma not allowed.`
**Playground Link:** http://www.typescriptlang.org/play/#src=class%20FooClass%3C%0D%0A%09A%2C%0D%0A%09B%2C%0D%0A%09C%2C%0D%0A%3E%20%7B%0D%0A%09a%3A%20A%3B%0D%0A%09b%3A%20B%3B%0D%0A%09c%3A%20C%3B%0D%0A%7D%0D%0A%0D%0Aconst%20instance%20%3D%20new%20FooClass%3C%0D%0A%09boolean%2C%0D%0A%09number%2C%0D%0A%09string%2C%20%2F%2F%20%5Bts%5D%20Trailing%20comma%20not%20allowed.%0D%0A%09%3E()%3B
**Related Issues:**
#16152. @samal84 mentioned something like this but I couldn't parse what they meant without a code sample (is this it?). ~I'll take~ I can, if this is approved, take a stab at removing this error too.
| Suggestion,Awaiting More Feedback | medium | Critical |
297,651,197 | terminal | GetKeyboardLayout is not updated during a console session | _From @matial on August 13, 2017 21:0_
* Your Windows build number: version 10.0.14393
* Calling GetKeyboardLayout(0) periodically within a console application returns the handle of the keyboard layout active when starting the console. If the keyboard layout is changed while the console app is running, subsequent calls to GetKeyboardLayout do not reflect the new active layout.
* What's wrong / what should be happening instead: GetKeyboardLayout should return the handle of the last activated keyboard layout.
_Copied from original issue: Microsoft/WSL#2418_ | Product-Conhost,Area-Server,Issue-Bug | low | Major |
297,652,737 | go | net: better DNS transport for builtin DNS stub resolver | Split from #18588. The existing DNS stub resolver uses per-query DNS transport that would cause socket descriptor exhaustion. It might be better to have some mechanism for DNS transport to reduce the use of socket descriptors. For UDP-based DNS transport, it might be the use of shared UDP endpoints. For TCP-based DNS transport, it might be the use of connection pooling. | NeedsInvestigation | low | Major |
297,661,688 | TypeScript | narrowing to "never" by "if" statement does not exclude "undefined" return type | **TypeScript Version:** 2.7.1
**Search Terms:** narrowing types never switch case if undefined strictNullChecks
**Code**
```ts
// Build this code with "--strictNullChecks" option.
function assertNever(x: never): never {
throw new Error("not reached");
}
enum A {
Foo, Bar
}
// There are no errors on this function.
function good(a: A): number {
switch (a) {
case A.Foo: return 0;
case A.Bar: return 1;
}
}
// This function causes the following error though "a" is "never" at the end of the function.
// error TS2366: Function lacks ending return statement and return type does not include 'undefined'.
function bad(a: A): number {
if (a === A.Foo) return 0;
if (a === A.Bar) return 1;
}
// No error if explicit return of "never" is added.
function ok(a: A): number {
if (a === A.Foo) return 0;
if (a === A.Bar) return 1;
return assertNever(a);
}
```
**Expected behavior:** The `bad()` function should not cause error so that `if` statement works like `switch`.
**Actual behavior:** As commented in the code, only `bad()` function causes an error.
**Playground Link:** (please check "strictNullChecks" option.)
http://www.typescriptlang.org/play/#src=function%20assertNever(x%3A%20never)%3A%20never%20%7B%0D%0A%20%20%20%20throw%20new%20Error(%22unexpected%22)%3B%0D%0A%7D%0D%0A%0D%0Aenum%20A%20%7B%0D%0A%20%20%20%20Foo%2C%20Bar%0D%0A%7D%0D%0A%0D%0Afunction%20good(a%3A%20A)%3A%20number%20%7B%0D%0A%20%20%20%20switch%20(a)%20%7B%0D%0A%20%20%20%20%20%20%20%20case%20A.Foo%3A%20return%200%3B%0D%0A%20%20%20%20%20%20%20%20case%20A.Bar%3A%20return%201%3B%0D%0A%20%20%20%20%7D%0D%0A%7D%0D%0A%0D%0Afunction%20bad(a%3A%20A)%3A%20number%20%7B%0D%0A%20%20%20%20if%20(a%20%3D%3D%3D%20A.Foo)%20return%200%3B%0D%0A%20%20%20%20if%20(a%20%3D%3D%3D%20A.Bar)%20return%201%3B%0D%0A%7D%0D%0A%0D%0Afunction%20ok(a%3A%20A)%3A%20number%20%7B%0D%0A%20%20%20%20if%20(a%20%3D%3D%3D%20A.Foo)%20return%200%3B%0D%0A%20%20%20%20if%20(a%20%3D%3D%3D%20A.Bar)%20return%201%3B%0D%0A%20%20%20%20return%20assertNever(a)%3B%0D%0A%7D
**Related Issues:**
| Suggestion,In Discussion | low | Critical |
297,667,366 | rust | Option::unwrap, panic!, print!, maybe others induce string relocations | Consider the following code:
```rust
pub fn foo(a: Option<usize>) -> usize {
a.unwrap()
}
```
This generates the following:
```asm
example::foo:
cmp qword ptr [rdi], 1
jne .LBB0_1
mov rax, qword ptr [rdi + 8]
ret
.LBB0_1:
push rbp
mov rbp, rsp
lea rdi, [rip + .Lref.2]
call core::panicking::panic@PLT
ud2
str.0:
.ascii "called `Option::unwrap()` on a `None` value"
str.1:
.ascii "/checkout/src/libcore/option.rs"
.Lref.2:
.quad str.0
.quad 43
.quad str.1
.quad 31
.long 335
.long 21
```
The quads under `.Lref.2` correspond to (pointer, length) pairs for both strings emitted by unwrap(). The way they are stored looks related to the call convention for `core::panicking::panic`, which looks like it just wants a pointer to a buffer containing 2 &str and 2 integers. The problem with this is that each of those pointers need relocations in the final position independent binary. And in ELF, those are large: each relocation is 2 (on 32-bits) or 3 (on 64-bits) words, so 24 bytes on 64-bits. Per string.
The same kind of thing happens with `panic!`:
```rust
pub fn foo() {
panic!("foo")
}
```
I'll skip the assembly for the code itself, but the data looks like:
```asm
str.1:
.ascii "/tmp/compiler-explorer-compiler118116-63-xzcrje.hzu9d/example.rs"
.Lref.2:
.quad str.1
.quad 64
.long 2
.long 5
str.4:
.ascii "foo"
```
Do note that there is no reference to `str.4`, the corresponding (pointer, length) is actually created from code in that case:
```asm
lea rcx, [rip + str.4]
mov qword ptr [rax], rcx
mov qword ptr [rax + 8], 3
```
And the same again for `print!`:
```rust
pub fn foo() {
print!("foo")
}
```
generating this data:
```asm
str.0:
.ascii "foo"
.Lref.1:
.quad str.0
.quad 3
```
A counter example is `Option::expect`:
```rust
pub fn foo(a: Option<usize>) -> usize {
a.expect("bar")
}
```
which generates:
```asm
example::foo:
cmp qword ptr [rdi], 1
jne .LBB0_1
mov rax, qword ptr [rdi + 8]
ret
.LBB0_1:
push rbp
mov rbp, rsp
lea rdi, [rip + str.0]
mov esi, 3
call core::option::expect_failed@PLT
ud2
str.0:
.ascii "bar"
``` | A-LLVM,C-enhancement,A-codegen,T-compiler | low | Critical |
297,680,841 | rust | wasm32_final_outputs test fails when Cargo 0.25 is compiled from rustc 1.24.0 source tarball | When running `cargo test` from the src/tools/cargo directory in the rustc 1.24.0 source tarball, the `wasm32_final_outputs` test fails. It seems that the test is finding the rustc Cargo.toml instead of the cargo Cargo.toml and it fails because the test directory is not part of the workspace. I filed an issue with Cargo ([#4755](https://github.com/rust-lang/cargo/issues/4755)) and was instructed to file the issue against rust instead.
```
test wasm32_final_outputs ... FAILED
test transitive_dependencies_not_available ... ok
test verbose_release_build_deps ... ok
test staticlib_rlib_and_bin ... ok
test lto_build ... ok
test same_metadata_different_directory ... ok
failures:
---- wasm32_final_outputs stdout ----
thread 'wasm32_final_outputs' panicked at 'Can't create workspace: ErrorMessage { msg: "current package believes it\'s in a workspace when it\'s not:\ncurrent: /home/build/YPKG/root/cargo/build/rustc-1.24.0-src/src/target/cit/t120/foo/Cargo.toml\nworkspace: /home/build/YPKG/root/cargo/build/rustc-1.24.0-src/src/Cargo.toml\n\nthis may be fixable by adding `target/cit/t120/foo` to the `workspace.members` array of the manifest located at: /home/build/YPKG/root/cargo/build/rustc-1.24.0-src/src/Cargo.toml" }', src/libcore/result.rs:916:5
note: Run with `RUST_BACKTRACE=1` for a backtrace.
failures:
wasm32_final_outputs
test result: FAILED. 127 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out
error: test failed, to rerun pass '--test build'
``` | A-testsuite,T-compiler,O-wasm,C-bug | low | Critical |
297,702,988 | pytorch | Unsafe out= keyword argument with tensors sharing storage | The current `out=` behavior is unsafe. For example, if you do `a_3x3_tensor.sum(dim=1, out=y[1, 1:10])` it will try to `THTensor_(resize)` the view and in turn write to incorrect locations of `y`.
Instead, if `out` is sharing storage, we should accept if only it 1) has correct size and 2) the range is not overlapping with the source tensors.
cc @mruberry @rgommers @zou3519 @soumith | triaged,module: numpy,module: safe resize,module: correctness (silent) | low | Major |
297,708,162 | vscode | Git - Support prompting for GPG password | - VSCode Version: 1.19.3
- OS Version: Windows 10
Hey, Git don't work in Visual Studio Code, when i have gpg signing activated.
Steps to reproduce: https://help.github.com/articles/signing-commits-with-gpg/
Does this issue occur when all extensions are disabled?: Yes
| help wanted,feature-request,git | high | Critical |
297,769,333 | godot | Duplicated Animation Player loses connection to saved animations | <!-- Please search existing issues for potential duplicates before filing yours:
https://github.com/godotengine/godot/issues?q=is%3Aissue
-->
**Godot version:**
<!-- Specify commit hash if non-official. -->
3.0
**OS/device including version:**
<!-- Specify GPU model and drivers if graphics-related. -->
**Issue description:**
<!-- What happened, and what was expected. -->
A duplicated (Ctrl + D) Animation Player loses connection to any saved animations contained in it.
**Steps to reproduce:**
Create a 2D node, add a Sprite and Animation Player as child nodes. Create an animation and save it to disk. Duplicate the 2D node and its children. Now change the animation in the original 2D node and save it. The corresponding animation in the duplicate 2D node Animation Player will not have updated since the connection to the saved animation is now lost.
**Minimal reproduction project:**
<!-- Recommended as it greatly speeds up debugging. Drag and drop a zip archive to upload it. -->
| bug,topic:editor,confirmed | low | Critical |
297,773,826 | youtube-dl | Requesting support for prepaway.com | ### What is the purpose of your *issue*?
- [ ] Bug report (encountered problems with youtube-dl)
- [x] Site support request (request for adding support for a new site)
- [ ] Feature request (request for a new functionality)
- [ ] Question
- [ ] Other
---
### If the purpose of this *issue* is a *site support request* please provide all kinds of example URLs support for which should be included (replace following example URLs by **yours**):
- Playlist: https://www.prepaway.com/tutorials/cisco-300-210-sitcs-ccnp-security.html#curriculum | account-needed | low | Critical |
297,774,093 | youtube-dl | Request support for www.cybrary.it | ### What is the purpose of your *issue*?
- [ ] Bug report (encountered problems with youtube-dl)
- [x] Site support request (request for adding support for a new site)
- [ ] Feature request (request for a new functionality)
- [ ] Question
- [ ] Other
---
### If the purpose of this *issue* is a *site support request* please provide all kinds of example URLs support for which should be included (replace following example URLs by **yours**):
- Playlist: https://www.cybrary.it/course/ethical-hacking/ | account-needed | low | Critical |
297,839,522 | vscode | [folding] Code folding does not respect multi-cursor | <!-- Do you have a question? Please ask it on https://stackoverflow.com/questions/tagged/vscode. -->
<!-- Use Help > Report Issue to prefill these. -->
- VSCode Version: 1.20.1
- OS Version: Windows 10
Steps to Reproduce:
1. Open a new document with the following css:
```
.selector{
min-width: 40px;
}
.selector.a{
width: 468px;
height: 60 px;
}
.selector.b{
width: 728px;
height: 90 px;
}
.selector.c{
width: 160px;
height: 600 px;
}
```
2. Highlight any occurrence of `.selector` and multiselect all occurrences with `Ctrl + D`.
3. Move all cursors to the beginning of their respective lines with `Home`
4. Attempt to execute a code fold with `Ctrl + Shift + [`
Expected Behavior:
All selectors are folded down to
```
.selector{β¦}
.selector.a{β¦}
.selector.b{β¦}
.selector.c{β¦}
```
Actual Behavior:
Only the initially selected selector is folded. All others remain expanded.
<!-- Launch with `code --disable-extensions` to check. -->
Does this issue occur when all extensions are disabled?: Yes | feature-request,editor-folding | low | Minor |
297,861,657 | go | net: don't keep reading from UDP resolver after truncated packet | When the `host` or `dig` programs see a malformed packet from a resolver when using UDP, they fall back to using TCP. The net package resolver does not do this; it simply ignores the malformed packet (in `(*dnsPacketConn).dnsRoundTrip` in net/dnsclient_unix.go). This was done for #13281. I suggest that we do the same.
This is showing up right now for me when I run `go test -test.run=TestLookupLongTXT net`. I see this:
```
--- FAIL: TestLookupLongTXT (10.00s)
lookup_test.go:334: lookup golang.rsc.io on 127.0.0.1:53: read udp 127.0.0.1:39779->127.0.0.1:53: i/o timeout
FAIL
FAIL net 10.023s
```
If I run `dig -t txt golang.rsc.io` the output starts with
```
;; Warning: Message parser reports malformed message packet.
;; Truncated, retrying in TCP mode.
```
I suggest that we keep the current behavior for the `!resp.IsResponseTo(query)` case but change the behavior for an `Unpack` failure to drop right back to TCP.
CC @mdempsky | NeedsInvestigation | low | Critical |
297,872,704 | youtube-dl | Can't extract Facebook videos | [debug] Command-line args: [u'--verbose', u'https://www.facebook.com/padraocarvalheira/videos/1607606815918150/', u'--no-check-certificate']
[debug] Encodings: locale UTF-8, fs UTF-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2018.02.11
[debug] Python version 2.7.12 (CPython) - Linux-4.4.0-109-generic-x86_64-with-Ubuntu-16.04-xenial
[debug] exe versions: none
[debug] Proxy map: {}
[facebook] 1607606815918150: Downloading webpage
ERROR: Unable to download webpage: HTTP Error 403: Forbidden (caused by HTTPError()); please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see https://yt-dl.org/update on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output. | cant-reproduce | low | Critical |
297,925,798 | tensorflow | Sample for report_tensor_allocations_upon_oom and RunOptions | This is a feature request.
Please add some example to the docs describing how to use report_tensor_allocations_upon_oom and other options of RunOptions
All I could find is this file:
https://github.com/tensorflow/tensorflow/blob/master/tensorflow/python/profiler/model_analyzer_test.py
But it is not obvious. For example, it contains:
from tensorflow.core.protobuf import config_pb2
and then
with session.Session() as sess:
sess.run(c, options=config_pb2.RunOptions(
report_tensor_allocations_upon_oom=True))
And more questions arise like: "What is config_pb2?" etc.
Thanks. | type:docs-feature | medium | Critical |
297,928,485 | kubernetes | Validation on update and delete | As it stands today, changes to validation logic can break the API if they tighten the requirements for an object. The general case for this is:
1. Create object `X`
2. Upgrade to new server version
3. Try to update object `X` (add a label for example)
4. The update fails because of validation errors
Specifically, an object already stored within the API is considered invalid.
Another similar issue can occur on a delete which requires an update (i.e. a finalizer needs to be removed). Since the object cannot be updated in-place, it cannot be deleted without first "fixing" it to match the current validation requirements.
This has the potential to break controllers or any autonomous process. It makes changes to validation hard to review because you have to understand how preexisting objects will behave under the new validation. In openshift, this constantly breaks the storage migration process which does no-op updates to all objects in the API.
A possible fix for the no-op update case would be to _not_ run validation when the input and output objects are exactly the same.
For the more complex update cases and the delete case, we could do something similar to `IsOnlyMutatingGCFields` to determine if validation can be safely skipped.
@kubernetes/sig-api-machinery-misc | sig/api-machinery,lifecycle/frozen | low | Critical |
297,933,248 | vscode | Expose git diff functions outside of overflow menu | 
These commands like revert selected ranges etc are pretty commonly useful commands. Would make sense to extract them into buttons to the left of the overflow menu.
Consider git tools like SourceTree
| feature-request,ux | low | Minor |
297,948,004 | terminal | Replace SimSun, MingLiu, MSGothic, GulimChe with one (or four?) decent monospace fonts. | _From @be5invis on May 12, 2017 5:35_
**THEY ARE UGLY, REALLY**.
The new font(s) should be:
- Exact half-width monospace, to prevent full-width glyphs being stretched or alignment being broken.
- No bitmap. In vector.
- Well hinted.
- Follows regional (CCJK) orthographic standards and aesthetic habits.
_Copied from original issue: Microsoft/WSL#2091_ | Issue-Feature,Product-Conhost,Area-Fonts | medium | Critical |
297,948,522 | terminal | Japanese character output in Integrated Terminal of Visual Studio Code causes the next prompt out of position after upgrading to Creators Update | _From @yusuke-konishi on April 10, 2017 3:50_
* A brief description
Japanese character output in Integrated Terminal of Visual Studio Code causes the next prompt out of position **after upgrading to Creators Update**. This issue is reproducible 100%.
For example, `echo γ` causes the next prompt out of position. The screenshot below is the result of `ls -la` with en only, and `echo γ`. `ls -la` does not cause any problem, but `echo γ` causes the next prompt out of position.
* Expected results
Japanese character output in Integrated Terminal of Visual Studio Code keeps the next prompt in the correct position.
* Actual results (with terminal output if applicable)
Japanese character output in Integrated Terminal of Visual Studio Code causes the next prompt out of position.
* Your Windows build number
Version 1703, build 15063.13 (Japanese)
* Steps / All commands required to reproduce the error from a brand new installation
1. Install Windows 10 Creators Update
2. Install BoW on Creators Update
3. Install Visual Studio Code (v1.11.1)
4. Open BoW in Integrated Terminal by [Ctrl] +[@]
5. Run `echo γ`
-> This causes the next prompt out of position.
* Other troubleshooting
I tried repro on the following three environment by Visual Studio Code v1.11.1. By this results, this does not seem to depend on Visual Studio Code, but **Creators Update**. Can't BoW handle this issue?
1) OK
OS: build 14393.0
BoW: Ubuntu 14.04
2) **NG**
OS: **build 15063.13 (upgraded from build 14393.0)**
BoW: Ubuntu 14.04 (not upgraded)
3) **NG**
OS: **build 15063.13**
BoW: Ubuntu 16.04
_Copied from original issue: Microsoft/WSL#1871_ | Product-Conhost,Area-Output,Issue-Bug | low | Critical |
297,958,622 | rust | Disambiguating associated types from super traits in a trait object | Suppose you have a trait:
```
trait Foo: std::ops::Index<usize> + std::ops::Index<isize> {}
```
How do you declare a `Foo` trait object, say a `Box`? The `Output` associated types need to be specified but they need to be disambiguated between the two super traits. Projections that Iβve tried donβt seem to work but itβs possible I didnβt try the right incarnation.
This stems from the https://users.rust-lang.org/t/how-to-specify-associated-types-with-same-name-in-generics/15677 post. | C-enhancement,A-associated-items,T-lang,T-types,A-trait-objects | low | Major |
297,962,565 | pytorch | BatchNorm1d raises RuntimeError (CUDNN_STATUS_BAD_PARAM) on 3D input. | - OS: Ubuntu 16.04
- PyTorch version: 0.3.1
- How you installed PyTorch (conda, pip, source): pip
- Python version: 3.5.3
- CUDA/cuDNN version: 8.0
- GPU models and configuration: Titan Xp
- GCC version (if compiling from source): -
- A script to reproduce the bug. Please try to provide as minimal of a test case as possible.
```
bn = torch.nn.BatchNorm1d(5, eps=0.001, momentum=0.99).cuda()
x = Variable(torch.rand(2,5,1).cuda())
bn(x)
```
- Error messages and/or stack traces of the bug
```
---------------------------------------------------------------------------
RuntimeError Traceback (most recent call last)
<ipython-input-62-f513ba6863d2> in <module>()
1 bn = torch.nn.BatchNorm1d(5, eps=0.001, momentum=0.99).cuda()
2 x = Variable(torch.rand(2,5,1).cuda())
----> 3 bn(x)
/usr/local/lib/python3.5/dist-packages/torch/nn/modules/module.py in __call__(self, *input, **kwargs)
355 result = self._slow_forward(*input, **kwargs)
356 else:
--> 357 result = self.forward(*input, **kwargs)
358 for hook in self._forward_hooks.values():
359 hook_result = hook(self, input, result)
/usr/local/lib/python3.5/dist-packages/torch/nn/modules/batchnorm.py in forward(self, input)
35 return F.batch_norm(
36 input, self.running_mean, self.running_var, self.weight, self.bias,
---> 37 self.training, self.momentum, self.eps)
38
39 def __repr__(self):
/usr/local/lib/python3.5/dist-packages/torch/nn/functional.py in batch_norm(input, running_mean, running_var, weight, bias, training, momentum, eps)
1011 raise ValueError('Expected more than 1 value per channel when training, got input size {}'.format(size))
1012 f = torch._C._functions.BatchNorm(running_mean, running_var, training, momentum, eps, torch.backends.cudnn.enabled)
-> 1013 return f(input, weight, bias)
1014
1015
RuntimeError: CUDNN_STATUS_BAD_PARAM
```
- Context around what you are trying to do
Use BatchNorm1d on a batch of data (Examples x Channels x Length)
P.S.: This works on master branch. | module: cudnn,triaged | low | Critical |
297,963,994 | kubernetes | Common approach for delegated pod admission & policy | There are a number of features that apply policies to pods. However, this is challenging since pods are not typically created by users - they are typically created by a controller instantiating some pod template. Each policy addresses this in their own way:
- **PodSecurityPolicy** - policy is checked against the pods service account, in addition to the creating user. It is not intuitive to give the pod SA the permission to create itself. From a security standpoint, this is similar to namespace level, since we don't have special authorization for using a service account in a namespace.
- **NetworkPolicy** - a podselector determines the pods to apply to, but it's hard to guard or require use of the policy since pods can be created with any label (see next item). NetworkPolicy is namespaced, so a catch-all selector can require all pods in a namespace to comply.
- **ImagePolicy** - limits access to images in pod specs. No first-party story, delegates decisions to an external webhook. Review request includes image name (registry, name, tag, sha), pod annotations (matching prefix), and namespace.
- **LimitRanger, ResourceQuota** - limits resource requests, limits, and usage. Policies applied at namespace level (i.e. all pods in a namespace)
- **Toleration & NodeSelector restrictions** - namespace level, defined on the namespace object
- [Proposal for validated annotations](https://github.com/kubernetes/community/pull/1604) and [Proposal for restricting label access](https://docs.google.com/document/d/1Ql_Y-DRbvPCSA-o36CLOs3t4tQUoSvbQxtVEI4FCtEo/edit#heading=h.tx3ialsfu4bx) - Both face a similar problem of validating a pod.
Options for dealing with delegated policy application:
1. **Apply policy at the namespace level** - The most widely used approach right now, but we should standardize the API. This approach has the advantage that it is consistent with authorization (e.g. RBAC), where create permissions are granted at the namespace level. Disadvantages are that policies can't be applied more granularly in a namespace, and managing policy across namespaces needs to be handled.
2. **Apply policy on the pod's service account** - The approach PSP takes. This is counter intuitive, and doesn't really elevate security over the namespace approach, since service account access is not subdivided.
3. **Applied to requester, checked against PodTemplates** - Under this approach, the policy would be checked when a create ReplicaSet/Controller, Job, Deployment, DaemonSet, StatefulSet, etc. are created, matching the policy to the PodTemplate. To handle the delegation issue, controllers that create the pods according to the template are granted unrestricted access. This approach has an intuitive user experience, but a lot of problem including:
- Dealing with CRDs & third party controllers is challenging
- Large attack surface, if you can get control of a controller's credentials (particularly a problem for non-built in controllers)
- Policy isn't checked against initializer values & mutating admission controllers that kick in at pod creation. Less of a problem if those apply to the podtemplates, but that has its own set of issues.
- Not all policies can reasonable be applied at template creation time (e.g. ResourceQuota)
- Updating a policy does not retroactively apply
4. **Delegated auth** - Same as above, but rather than granting unrestricted access to the controllers, grant them access to act as the user that initially created the template. This still faces a lot of the same problems as (3), but also introduces the challenge of determining if a Pod matches a template (which might be intractable, I can't come up with a good answer).
5. **??** - Suggestions wanted!
/kind feature
/sig auth
/priority important-longterm | kind/cleanup,kind/feature,sig/auth,priority/important-longterm,lifecycle/frozen | medium | Minor |
297,967,514 | godot | Frame stutter when playing a project on MacOS/Linux | **Godot version:**
3.0
**OS/device including version:**
MacOS High Sierra, NVIDIA GeForce GT 750M 2 GB
**Issue description:**
Frame stuttering: https://imgur.com/a/nzIIn
The FPS seem to remain unaffected when a stutter occurs. I've tried disabling V-sync. All demo projects I've tried have this issue. When using the Profiler I've noticed that the game mostly doesn't stutter anymore. I've managed to capture a profile both with stutter (right side) and without stutter (left side): https://imgur.com/a/ctFMp. An exported version of the game has no frame stuttering. But I will get stuttering even in the exported game when I'm playing both the exported version and the preview game from within Godot.
**Steps to reproduce:**
Be on MacOS (or Linux https://www.reddit.com/r/godot/comments/7y2aba/frame_stutter/dud66un/).
Set MacOS' scaling to "More Space".
Play any project from within Godot.
**Minimal reproduction project:**
Any (demo) project with character movement to test it | bug,platform:linuxbsd,platform:macos,topic:porting | medium | Critical |
298,023,954 | rust | Feature: show failure step when compilation failed due to static analysis | Newcomers might find this kind of output useful for an invalid program:
```
β Syntax valid!
β Types invalid
- Borrow checker
error[E0599]: no method named `collect` found for type `std::vec::Vec<T>` in the current scope
...
```
This would make it easier to see if you're fixing errors correctly, and are getting 'better' errors. | A-frontend,A-diagnostics,T-compiler,C-feature-request | low | Critical |
298,036,625 | rust | Improve implicit conversion of &[_; 0] into &[T] | https://play.rust-lang.org/?gist=251182ab9c63f93d776eed72b43d4455&version=stable
```rust
pub fn foo<T>(lists: &[&[T]]) {
let (first, rest) = lists.split_first().unwrap_or((&(&[]), &[]));
}
```
This code should pass type checking. (Unless I'm mistaken.) | A-type-system,C-enhancement,T-lang,T-compiler,A-coercions,T-types | low | Minor |
298,059,372 | rust | `resume_unwind` can indefinitely increase the panic count | A corner-case use of `resume_unwind` can lead to a large panic count. This complicates the flowchart of panic handling. I think `resume_unwind` should abort when `panic_count >= 1` to keep the invariant `panic_count <= 2` (and `panic_count <= 1` when unwinding).
[Playground](https://play.rust-lang.org/?gist=b72fbc07b8bdc9997bd79b04198bbacb&version=nightly)
```rust
#![feature(update_panic_count)]
use std::ops::Drop;
use std::panic::resume_unwind;
use std::rt::update_panic_count; // to show panic count
struct A;
impl Drop for A {
fn drop(&mut self) {
let panic_count = update_panic_count(0);
println!("panic_count = {}", panic_count);
if panic_count >= 100 {
return;
}
let _x = A;
resume_unwind(Box::new(()));
}
}
fn main() {
let _x = A;
}
```
It prints
```
panic_count = 0
panic_count = 1
panic_count = 2
...
panic_count = 100
``` | A-runtime,T-libs-api,C-bug | low | Minor |
298,070,073 | youtube-dl | Site Support on Smosh.com | ## Please follow the guide below
- You will be asked some questions and requested to provide some information, please read them **carefully** and answer honestly
- Put an `x` into all the boxes [ ] relevant to your *issue* (like this: `[x]`)
- Use the *Preview* tab to see what your issue will actually look like
---
### Make sure you are using the *latest* version: run `youtube-dl --version` and ensure your version is *2018.02.22*. If it's not, read [this FAQ entry](https://github.com/rg3/youtube-dl/blob/master/README.md#how-do-i-update-youtube-dl) and update. Issues with outdated version will be rejected.
- [x] I've **verified** and **I assure** that I'm running youtube-dl **2018.02.22**
### Before submitting an *issue* make sure you have:
- [ ] At least skimmed through the [README](https://github.com/rg3/youtube-dl/blob/master/README.md), **most notably** the [FAQ](https://github.com/rg3/youtube-dl#faq) and [BUGS](https://github.com/rg3/youtube-dl#bugs) sections
- [ ] [Searched](https://github.com/rg3/youtube-dl/search?type=Issues) the bugtracker for similar issues including closed ones
- [ ] Checked that provided video/audio/playlist URLs (if any) are alive and playable in a browser
### What is the purpose of your *issue*?
- [ ] Bug report (encountered problems with youtube-dl)
- [x] Site support request (request for adding support for a new site)
- [ ] Feature request (request for a new functionality)
- [ ] Question
- [ ] Other
---
### If the purpose of this *issue* is a *bug report*, *site support request* or you are not completely sure provide the full verbose output as follows:
### If the purpose of this *issue* is a *site support request* please provide all kinds of example URLs support for which should be included (replace following example URLs by **yours**):
- Single video: http://www.smosh.com/videos/breaking-habit-alternate-ending | site-support-request | low | Critical |
298,081,988 | vscode | The bgcolor of selected text in highlighted search keyword is not different from the highlight color | ### Issue Type
Bug
### Description
Steps to reproduce:
1. search some keyword in the left search panel
2. click on one search result
3. the keyword is highlighted
4. select some word in the highlighted text
I want the bgcolor of selected text differ from highlighted color, but it is the same.
(in this pic, "COUNT" is selected)
Note that this issue only occur when I open the file from search panel, and only occur on the highlight of search result I clicked.
(the second highlight works fine)
I tried 4 color themes, all reproduced this issue.
### VS Code Info
VS Code version: Code 1.20.1 (f88bbf9137d24d36d968ea6b2911786bfe103002, 2018-02-13T15:34:36.336Z)
OS version: Windows_NT x64 6.1.7601
<details>
<summary>System Info</summary>
|Item|Value|
|---|---|
|CPUs|Intel(R) Core(TM) i5-2500 CPU @ 3.30GHz (4 x 3292)|
|Memory (System)|7.96GB (3.77GB free)|
|Process Argv|C:\Program Files\Microsoft VS Code\Code.exe F:\Works\ygopro-scripts|
|Screen Reader|no|
|VM|0%|
</details><details><summary>Extensions (1)</summary>
Extension|Author (truncated)|Version
---|---|---
vscode-eslint|dba|1.4.5
</details>
Reproduces without extensions
| bug,help wanted,search,confirmed | low | Critical |
298,085,794 | rust | Partial substitution of trait associated types results in compiltion failure | Consider a [following playground](https://play.rust-lang.org/?gist=12118ce186c0d5fff14c872dcf27b2d0&version=stable):
```rust
#![crate_type = "lib"]
trait A<X> {
}
trait B {
type X;
type A: A<Self::X>;
}
fn oops<T: B<X=String>>(_: &T) {
}
```
It fails to compile with
```
Compiling playground v0.0.1 (file:///playground)
error[E0277]: the trait bound `<T as B>::A: A<std::string::String>` is not satisfied
--> src/lib.rs:11:1
|
11 | / fn oops<T: B<X=String>>(_: &T) {
12 | | }
| |_^ the trait `A<std::string::String>` is not implemented for `<T as B>::A`
|
= help: consider adding a `where <T as B>::A: A<std::string::String>` bound
= note: required by `B`
error: aborting due to previous error
error: Could not compile `playground`.
To learn more, run the command again with --verbose.
``` | C-enhancement,A-trait-system,T-compiler | low | Critical |
298,097,521 | vscode | Workspace ... scrollbar area is totally invisible | <!-- Do you have a question? Please ask it on https://stackoverflow.com/questions/tagged/vscode. -->
<!-- Use Help > Report Issue to prefill these. -->
- VSCode Version: 1.21.0-ins
- OS Version: win7x64
How about to make scrollbar area a little bit visible?
Cause you don't even see where to click, when you want to scroll some hundreds of folders instantly.
For now it's totally invisible:
| feature-request,ux | low | Minor |
298,114,534 | rust | Debug LLVM + `-Z time-llvm-passes` asserts compiling simplest program. | For context, I was trying to add PGO support to rustc, and I was adding a couple LLVM passes for profile info generation and usage, and the only thing I managed to do is crashing rustc under LLVM, or that my changes did nothing, so I built with debug LLVM to check whether I was doing something obviously wrong. Furthermore, I wanted to see if the passes I was adding were actually being executed, thus I tried `-Z time-llvm-passes`.
~For the record, I am hitting release crashes under `llvm::SelectionDAGISel` with my changes (without `-Z time-llvm-passes`), so I suspect this is a more serious issue than "LLVM uses a static hashmap to store timing info".~ These assertions reproduce without any change on 16362c737fe740f630ada06349fa9004e2a51bb7.
On a rustc compiled with the following `config.toml` (comments stripped for brevity):
```toml
[llvm]
optimize = false
assertions = true
[build]
profiler = true # This is because I was trying to do PGO stuff, but I suspect it's unnecessary.
configure-args = ['--enable-profiler', '--enable-debug', '--enable-llvm-assertions'] # I'd ignore this since I tweaked other fields manually.
[install]
[rust]
debug-assertions = true
debuginfo = true
debuginfo-lines = true
[target.x86_64-unknown-linux-gnu]
[dist]
```
Compiled from 16362c737fe740f630ada06349fa9004e2a51bb7, with:
```shell
$ ./x.py build --stage 1 src/libtest
```
Given a `t.rs` file like:
```rust
fn main() {}
```
Building it with:
```shell
./build/x86_64-unknown-linux-gnu/stage1/bin/rustc -Z time-llvm-passes t.rs
```
Asserts with:
```
rustc: /home/emilio/projects/moz/rust/src/llvm/lib/Support/Timer.cpp:133: void llvm::Timer::startTimer(): Assertion `!Running && "Cannot start a running timer"' failed.
```
I need to compile a slightly more complex file to be able to catch it under rr, but the stack is:
<details>
```
(rr) bt
#0 0x00007f54039a766b in raise () from /lib64/libc.so.6
#1 0x00007f54039a9381 in abort () from /lib64/libc.so.6
#2 0x00007f540399f8fa in __assert_fail_base () from /lib64/libc.so.6
#3 0x00007f540399f972 in __assert_fail () from /lib64/libc.so.6
#4 0x00007f53f0b26c20 in llvm::Timer::startTimer (this=0x7f53e008f438) at /home/emilio/projects/moz/rust/src/llvm/lib/Support/Timer.cpp:133
#5 0x00007f53f02c29a2 in llvm::TimeRegion::TimeRegion (this=0x7f53e9e71f90, t=0x7f53e008f438) at /home/emilio/projects/moz/rust/src/llvm/include/llvm/Support/Timer.h:149
#6 0x00007f53f0b27222 in llvm::NamedRegionTimer::NamedRegionTimer (this=0x7f53e9e71f90, Name=..., Description=..., GroupName=..., GroupDescription=..., Enabled=true)
at /home/emilio/projects/moz/rust/src/llvm/lib/Support/Timer.cpp:215
#7 0x00007f53ef778cd6 in llvm::SelectionDAGISel::CodeGenAndEmitDAG (this=0x7f53d4002040) at /home/emilio/projects/moz/rust/src/llvm/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp:883
#8 0x00007f53ef777154 in llvm::SelectionDAGISel::SelectBasicBlock (this=0x7f53d4002040, Begin=..., End=..., HadTailCall=@0x7f53e9e7285f: false)
at /home/emilio/projects/moz/rust/src/llvm/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp:664
#9 0x00007f53ef77cbaa in llvm::SelectionDAGISel::SelectAllBasicBlocks (this=0x7f53d4002040, Fn=...)
at /home/emilio/projects/moz/rust/src/llvm/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp:1624
#10 0x00007f53ef775e3e in llvm::SelectionDAGISel::runOnMachineFunction (this=0x7f53d4002040, mf=...)
at /home/emilio/projects/moz/rust/src/llvm/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp:466
#11 0x00007f53ee213fad in (anonymous namespace)::X86DAGToDAGISel::runOnMachineFunction (this=0x7f53d4002040, MF=...)
at /home/emilio/projects/moz/rust/src/llvm/lib/Target/X86/X86ISelDAGToDAG.cpp:175
#12 0x00007f53efaf72a3 in llvm::MachineFunctionPass::runOnFunction (this=0x7f53d4002040, F=...) at /home/emilio/projects/moz/rust/src/llvm/lib/CodeGen/MachineFunctionPass.cpp:62
#13 0x00007f53f07f353b in llvm::FPPassManager::runOnFunction (this=0x7f53d4004be0, F=...) at /home/emilio/projects/moz/rust/src/llvm/lib/IR/LegacyPassManager.cpp:1520
#14 0x00007f53f07f36bc in llvm::FPPassManager::runOnModule (this=0x7f53d4004be0, M=...) at /home/emilio/projects/moz/rust/src/llvm/lib/IR/LegacyPassManager.cpp:1541
#15 0x00007f53f07f3a0d in (anonymous namespace)::MPPassManager::runOnModule (this=0x7f53d40206b0, M=...) at /home/emilio/projects/moz/rust/src/llvm/lib/IR/LegacyPassManager.cpp:1597
#16 0x00007f53f07f40f9 in llvm::legacy::PassManagerImpl::run (this=0x7f53d40042d0, M=...) at /home/emilio/projects/moz/rust/src/llvm/lib/IR/LegacyPassManager.cpp:1700
#17 0x00007f53f07f42f1 in llvm::legacy::PassManager::run (this=0x7f53d400fc50, M=...) at /home/emilio/projects/moz/rust/src/llvm/lib/IR/LegacyPassManager.cpp:1731
#18 0x00007f53ee0bf47e in LLVMRustWriteOutputFile (Target=0x7f53f50de6d0, PMR=0x7f53d400fc50, M=0x7f53f484f8a0, Path=0x7f53d4020660 "test.test1.rcgu.o", RustFileType=<optimized out>)
at ../rustllvm/PassWrapper.cpp:530
#19 0x00007f53ede2e7a2 in rustc_trans::back::write::write_output_file (handler=0x7f53e9e738e0, target=0x2, pm=0x7f53e9e71bc0, m=0x0, output=0x7f53d400b270,
file_type=rustc_llvm::ffi::FileType::ObjectFile) at librustc_trans/back/write.rs:102
#20 0x00007f53ede15176 in rustc_trans::back::write::codegen::{{closure}}::{{closure}} (cpm=0x7f53d400fc50) at librustc_trans/back/write.rs:773
#21 rustc_trans::back::write::codegen::with_codegen (tm=0x7f53f50de6d0, llmod=<optimized out>, no_builtins=<optimized out>, f=...) at librustc_trans/back/write.rs:639
#22 rustc_trans::back::write::codegen::{{closure}} () at librustc_trans/back/write.rs:772
#23 0x00007f53ede0e22a in rustc::util::common::time (do_it=<optimized out>, what=..., f=...) at /home/emilio/projects/moz/rust/src/librustc/util/common.rs:120
#24 0x00007f53ede3086d in rustc_trans::back::write::codegen (cgcx=<optimized out>, diag_handler=<optimized out>, mtrans=..., config=<optimized out>, timeline=<optimized out>)
at librustc_trans/back/write.rs:695
#25 0x00007f53ede37866 in rustc_trans::back::write::execute_work_item (cgcx=0x7f53e9e73ef8, work_item=..., timeline=<optimized out>) at librustc_trans/back/write.rs:1346
#26 0x00007f53ede01046 in rustc_trans::back::write::spawn_work::{{closure}} () at librustc_trans/back/write.rs:1970
#27 std::sys_common::backtrace::__rust_begin_short_backtrace (f=...) at /home/emilio/projects/moz/rust/src/libstd/sys_common/backtrace.rs:136
#28 0x00007f53ede79c2e in std::thread::Builder::spawn::{{closure}}::{{closure}} () at /home/emilio/projects/moz/rust/src/libstd/thread/mod.rs:406
#29 <std::panic::AssertUnwindSafe<F> as core::ops::function::FnOnce<()>>::call_once (self=..., _args=<optimized out>) at /home/emilio/projects/moz/rust/src/libstd/panic.rs:293
#30 std::panicking::try::do_call (data=<optimized out>) at /home/emilio/projects/moz/rust/src/libstd/panicking.rs:479
#31 0x00007f5403df628f in __rust_maybe_catch_panic (f=0x0, data=0x2 <error: Cannot access memory at address 0x2>, data_ptr=0x7f53e9e746f8, vtable_ptr=0x7f53e9e746f0)
at libpanic_unwind/lib.rs:102
#32 0x00007f53ede79b1c in std::panicking::try (f=...) at /home/emilio/projects/moz/rust/src/libstd/panicking.rs:458
#33 0x00007f53ede0b7e9 in std::panic::catch_unwind (f=...) at /home/emilio/projects/moz/rust/src/libstd/panic.rs:358
#34 std::thread::Builder::spawn::{{closure}} () at /home/emilio/projects/moz/rust/src/libstd/thread/mod.rs:405
#35 <F as alloc::boxed::FnBox<A>>::call_box (self=0x7f53dc002a80, args=<optimized out>) at /home/emilio/projects/moz/rust/src/liballoc/boxed.rs:788
#36 0x00007f5403dd1fec in _$LT$alloc..boxed..Box$LT$alloc..boxed..FnBox$LT$A$C$$u20$Output$u3d$R$GT$$u20$$u2b$$u20$$u27$a$GT$$u20$as$u20$core..ops..function..FnOnce$LT$A$GT$$GT$::call_once::---Type <return> to continue, or q <return> to quit---
hbc01871d4ce3ef85 (self=<error reading variable: access outside bounds of object referenced via synthetic pointer>, args=<optimized out>)
at /home/emilio/projects/moz/rust/src/liballoc/boxed.rs:798
#37 std::sys_common::thread::start_thread (main=<optimized out>) at libstd/sys_common/thread.rs:24
#38 std::sys::unix::thread::Thread::new::thread_start (main=0x7f53e0023250) at libstd/sys/unix/thread.rs:90
#39 0x00007f540355461b in start_thread () from /lib64/libpthread.so.0
#40 0x00007f5403a8798f in clone () from /lib64/libc.so.6
(rr)
```
</details>
The threads are doing:
<details>
```
(rr) info thread
Id Target Id Frame
1 Thread 31405.31405 (mmap_hardlink_3_rustc) 0x00007f5403555bdd in pthread_join () from /lib64/libpthread.so.0
2 Thread 31405.31411 (rustc) 0x0000000070000002 in ?? ()
* 3 Thread 31405.31429 (rustc) 0x00007f54039a766b in raise () from /lib64/libc.so.6
4 Thread 31405.31414 (rustc) 0x0000000070000002 in ?? ()
5 Thread 31405.31417 (rustc) 0x0000000070000002 in ?? ()
6 Thread 31405.31426 (rustc) 0x00007f53ee144373 in llvm::SmallPtrSetImplBase::insert_imp (this=0x7f53ea372a60, Ptr=0x7f53e0054a30)
at /home/emilio/projects/moz/rust/src/llvm/include/llvm/ADT/SmallPtrSet.h:132
7 Thread 31405.31432 (rustc)
0x00007f53f07f7236 in llvm::DenseMapIterator<void const*, llvm::Pass*, llvm::DenseMapInfo<void const*>, llvm::detail::DenseMapPair<void const*, llvm::Pass*>, true>::DenseMapIterator<false, void> (this=0x7f53e9971e20, I=...) at /home/emilio/projects/moz/rust/src/llvm/include/llvm/ADT/DenseMap.h:1149
8 Thread 31405.31435 (rustc)
llvm::DenseMapBase<llvm::DenseMap<unsigned int, std::pair<unsigned short, unsigned short>, llvm::DenseMapInfo<unsigned int>, llvm::detail::DenseMapPair<unsigned int, std::pair<unsigned short, unsigned short> > >, unsigned int, std::pair<unsigned short, unsigned short>, llvm::DenseMapInfo<unsigned int>, llvm::detail::DenseMapPair<unsigned int, std::pair<unsigned short, unsigned short> > >::initEmpty (this=0x7f53cc025348) at /home/emilio/projects/moz/rust/src/llvm/include/llvm/ADT/DenseMap.h:347
9 Thread 31405.31438 (rustc) 0x00007f53ee416f36 in llvm::dyn_cast<llvm::InvokeInst, llvm::Instruction> (Val=0x7f53f57a1d08)
at /home/emilio/projects/moz/rust/src/llvm/include/llvm/Support/Casting.h:333
```
</details>
Thread 1:
<details>
```
(rr) thread 1
[Switching to thread 1 (Thread 31405.31405)]
#0 0x00007f5403555bdd in pthread_join () from /lib64/libpthread.so.0
(rr) bt
#0 0x00007f5403555bdd in pthread_join () from /lib64/libpthread.so.0
#1 0x00007f5403dd2280 in std::sys::unix::thread::Thread::join (self=...) at libstd/sys/unix/thread.rs:176
#2 0x00007f54040fa8f2 in <std::thread::JoinInner<T>>::join (self=<optimized out>) at /home/emilio/projects/moz/rust/src/libstd/thread/mod.rs:1200
#3 <std::thread::JoinHandle<T>>::join (self=...) at /home/emilio/projects/moz/rust/src/libstd/thread/mod.rs:1322
#4 0x00007f540420b521 in rustc_driver::in_rustc_thread (f=...) at librustc_driver/lib.rs:1431
#5 rustc_driver::monitor (f=...) at librustc_driver/lib.rs:1440
#6 rustc_driver::run (run_compiler=...) at librustc_driver/lib.rs:158
#7 rustc_driver::main () at librustc_driver/lib.rs:1512
#8 0x000056323a130eb6 in std::rt::lang_start::{{closure}} () at /home/emilio/projects/moz/rust/src/libstd/rt.rs:74
#9 0x00007f5403da3788 in std::rt::lang_start_internal::{{closure}} () at libstd/rt.rs:59
#10 std::panicking::try::do_call (data=0x7fffba2d4918 "XI-\272\377\177\000") at libstd/panicking.rs:479
#11 0x00007f5403df628f in __rust_maybe_catch_panic (f=0xffffffffffffffda, data=0x7f53fcbe99d0 "\263z\000", data_ptr=0x7fffba2d4928, vtable_ptr=0x7fffba2d4920) at libpanic_unwind/lib.rs:102
#12 0x00007f5403da367a in std::panicking::try (f=...) at libstd/panicking.rs:458
#13 0x00007f5403db9c67 in std::panic::catch_unwind (f=...) at libstd/panic.rs:358
#14 std::rt::lang_start_internal (main=..., argc=<optimized out>, argv=0x7fffba2d4b58) at libstd/rt.rs:58
#15 0x000056323a130ea2 in main ()
#16 0x00007f540399100a in __libc_start_main () from /lib64/libc.so.6
#17 0x000056323a130d7a in _start ()
(rr)
```
</details>
Thread 2:
<details>
```
(rr) bt
#0 0x0000000070000002 in ?? ()
#1 0x00007f54044da83f in _raw_syscall () at /home/emilio/projects/moz/rr/src/preload/raw_syscall.S:120
#2 0x00007f54044d7d84 in traced_raw_syscall (call=<optimized out>) at /home/emilio/projects/moz/rr/src/preload/syscallbuf.c:203
#3 sys_readlink (call=<optimized out>) at /home/emilio/projects/moz/rr/src/preload/syscallbuf.c:1866
#4 syscall_hook_internal (call=0x7f53fbbe8fa0) at /home/emilio/projects/moz/rr/src/preload/syscallbuf.c:2496
#5 0x00007f54044d61a1 in syscall_hook (call=0x7f53fbbe8fa0) at /home/emilio/projects/moz/rr/src/preload/syscallbuf.c:2576
#6 0x00007f54044d58da in _syscall_hook_trampoline () at /home/emilio/projects/moz/rr/src/preload/syscall_hook.S:282
#7 0x00007f54044d590a in __morestack () at /home/emilio/projects/moz/rr/src/preload/syscall_hook.S:417
#8 0x00007f54044d5925 in _syscall_hook_trampoline_48_3d_00_f0_ff_ff () at /home/emilio/projects/moz/rr/src/preload/syscall_hook.S:428
#9 0x00007f540355acc1 in pthread_cond_wait@@GLIBC_2.3.2 () from /lib64/libpthread.so.0
#10 0x00007f5403dccb10 in std::sys::unix::condvar::Condvar::wait (self=<optimized out>, mutex=<optimized out>) at libstd/sys/unix/condvar.rs:78
#11 std::sys_common::condvar::Condvar::wait (mutex=<optimized out>, self=<optimized out>) at libstd/sys_common/condvar.rs:51
#12 std::sync::condvar::Condvar::wait (self=<optimized out>, guard=...) at libstd/sync/condvar.rs:212
#13 0x00007f5403de38f8 in std::thread::park () at libstd/thread/mod.rs:800
#14 0x00007f5403db7d70 in std::sync::mpsc::blocking::WaitToken::wait (self=...) at libstd/sync/mpsc/blocking.rs:81
#15 0x00007f53edd4325a in <std::sync::mpsc::stream::Packet<T>>::recv (self=0x7f53dc001bc0, deadline=...) at /home/emilio/projects/moz/rust/src/libstd/sync/mpsc/stream.rs:210
#16 0x00007f53ede45afe in <std::sync::mpsc::Receiver<T>>::recv (self=0x7f53fcbde2b8) at /home/emilio/projects/moz/rust/src/libstd/sync/mpsc/mod.rs:1210
#17 0x00007f53edd98ab1 in rustc_trans::back::write::OngoingCrateTranslation::wait_for_signal_to_translate_item (self=<optimized out>) at librustc_trans/back/write.rs:2256
#18 rustc_trans::base::trans_crate (tcx=..., rx=...) at librustc_trans/base.rs:837
#19 0x00007f53edd664be in <rustc_trans::LlvmTransCrate as rustc_trans_utils::trans_crate::TransCrate>::trans_crate (self=<optimized out>, tcx=..., rx=...) at librustc_trans/lib.rs:226
#20 0x00007f540414aa5d in rustc_driver::driver::phase_4_translate_to_llvm::{{closure}} () at librustc_driver/driver.rs:1103
#21 rustc::util::common::time (do_it=<optimized out>, what=..., f=...) at /home/emilio/projects/moz/rust/src/librustc/util/common.rs:120
#22 0x00007f54041177d9 in rustc_driver::driver::phase_4_translate_to_llvm (trans=..., tcx=..., rx=...) at librustc_driver/driver.rs:1102
#23 0x00007f54041d0ff6 in rustc_driver::driver::compile_input::{{closure}} (tcx=..., analysis=..., rx=..., result=...) at librustc_driver/driver.rs:252
#24 0x00007f54041cc7c9 in rustc_driver::driver::phase_3_run_analysis_passes::{{closure}} (tcx=...) at librustc_driver/driver.rs:1085
#25 rustc::ty::context::tls::enter::{{closure}} (tls=<optimized out>) at /home/emilio/projects/moz/rust/src/librustc/ty/context.rs:1573
#26 <std::thread::local::LocalKey<T>>::try_with (self=<optimized out>, f=...) at /home/emilio/projects/moz/rust/src/libstd/thread/local.rs:377
#27 <std::thread::local::LocalKey<T>>::with (self=<optimized out>, f=...) at /home/emilio/projects/moz/rust/src/libstd/thread/local.rs:288
#28 0x00007f54041c7337 in rustc::ty::context::tls::enter (gcx=<optimized out>, interners=<optimized out>, f=...) at /home/emilio/projects/moz/rust/src/librustc/ty/context.rs:1570
#29 rustc::ty::context::tls::enter_global::{{closure}} (span_dbg=<optimized out>) at /home/emilio/projects/moz/rust/src/librustc/ty/context.rs:1557
#30 <std::thread::local::LocalKey<T>>::try_with (self=0x7f54044d15e8 <ref.41.llvm.E49595CD>, f=...) at /home/emilio/projects/moz/rust/src/libstd/thread/local.rs:377
#31 <std::thread::local::LocalKey<T>>::with (self=0x7f54044d15e8 <ref.41.llvm.E49595CD>, f=...) at /home/emilio/projects/moz/rust/src/libstd/thread/local.rs:288
#32 0x00007f54041f4192 in rustc::ty::context::tls::enter_global (gcx=..., f=...) at /home/emilio/projects/moz/rust/src/librustc/ty/context.rs:1554
#33 rustc::ty::context::TyCtxt::create_and_enter (s=0x7f53fcbe4c90, cstore=..., local_providers=..., extern_providers=..., arenas=<optimized out>, resolutions=..., hir=...,
on_disk_query_result_cache=..., crate_name=..., tx=..., output_filenames=<optimized out>, f=...) at /home/emilio/projects/moz/rust/src/librustc/ty/context.rs:1197
#34 0x00007f5404112e4d in rustc_driver::driver::phase_3_run_analysis_passes (sess=0x7f53fcbe4c90, cstore=..., trans=..., control=<optimized out>, hir_map=..., analysis=...,
resolutions=..., arenas=<optimized out>, name=..., output_filenames=<optimized out>, f=...) at librustc_driver/driver.rs:998
#35 rustc_driver::driver::compile_input (trans=..., sess=<optimized out>, cstore=0x7f53f40b5ad0, input_path=<optimized out>, input=<optimized out>, outdir=<optimized out>,
output=<optimized out>, addl_plugins=..., control=<optimized out>) at librustc_driver/driver.rs:214
#36 0x00007f54042025b8 in rustc_driver::run_compiler (args=..., callbacks=..., file_loader=..., emitter_dest=...) at librustc_driver/lib.rs:506
#37 0x00007f540416ca74 in rustc_driver::main::{{closure}} () at librustc_driver/lib.rs:1519
#38 rustc_driver::run::{{closure}} () at librustc_driver/lib.rs:159
#39 rustc_driver::monitor::{{closure}} () at librustc_driver/lib.rs:1441
#40 std::sys_common::backtrace::__rust_begin_short_backtrace (f=...) at /home/emilio/projects/moz/rust/src/libstd/sys_common/backtrace.rs:136
#41 0x00007f5403df628f in __rust_maybe_catch_panic (f=0xca, data=0x56323abb3cb8 "\002\000", data_ptr=0x7f53fcbe8a58, vtable_ptr=0x7f53fcbe8a50) at libpanic_unwind/lib.rs:102
#42 0x00007f540420e8b4 in std::panicking::try (f=...) at /home/emilio/projects/moz/rust/src/libstd/panicking.rs:458
#43 0x00007f540410d39f in std::panic::catch_unwind (f=...) at /home/emilio/projects/moz/rust/src/libstd/panic.rs:358
#44 std::thread::Builder::spawn::{{closure}} () at /home/emilio/projects/moz/rust/src/libstd/thread/mod.rs:405
#45 <F as alloc::boxed::FnBox<A>>::call_box (self=0x56323abb3c40, args=<optimized out>) at /home/emilio/projects/moz/rust/src/liballoc/boxed.rs:788
#46 0x00007f5403dd1fec in _$LT$alloc..boxed..Box$LT$alloc..boxed..FnBox$LT$A$C$$u20$Output$u3d$R$GT$$u20$$u2b$$u20$$u27$a$GT$$u20$as$u20$core..ops..function..FnOnce$LT$A$GT$$GT$::call_once::hbc01871d4ce3ef85 (self=<error reading variable: access outside bounds of object referenced via synthetic pointer>, args=<optimized out>)
at /home/emilio/projects/moz/rust/src/liballoc/boxed.rs:798
#47 std::sys_common::thread::start_thread (main=<optimized out>) at libstd/sys_common/thread.rs:24
#48 std::sys::unix::thread::Thread::new::thread_start (main=0x56323abb3d60) at libstd/sys/unix/thread.rs:90
#49 0x00007f540355461b in start_thread () from /lib64/libpthread.so.0
#50 0x00007f5403a8798f in clone () from /lib64/libc.so.6
```
</details>
Thread 3 is the crashing thread, with the first stack.
Thread 4:
<details>
```
(rr) bt
#0 0x0000000070000002 in ?? ()
#1 0x00007f54044da83f in _raw_syscall () at /home/emilio/projects/moz/rr/src/preload/raw_syscall.S:120
#2 0x00007f54044d7d84 in traced_raw_syscall (call=<optimized out>) at /home/emilio/projects/moz/rr/src/preload/syscallbuf.c:203
#3 sys_readlink (call=<optimized out>) at /home/emilio/projects/moz/rr/src/preload/syscallbuf.c:1866
#4 syscall_hook_internal (call=0x7f53eab77fa0) at /home/emilio/projects/moz/rr/src/preload/syscallbuf.c:2496
#5 0x00007f54044d61a1 in syscall_hook (call=0x7f53eab77fa0) at /home/emilio/projects/moz/rr/src/preload/syscallbuf.c:2576
#6 0x00007f54044d58da in _syscall_hook_trampoline () at /home/emilio/projects/moz/rr/src/preload/syscall_hook.S:282
#7 0x00007f54044d590a in __morestack () at /home/emilio/projects/moz/rr/src/preload/syscall_hook.S:417
#8 0x00007f54044d5925 in _syscall_hook_trampoline_48_3d_00_f0_ff_ff () at /home/emilio/projects/moz/rr/src/preload/syscall_hook.S:428
#9 0x00007f540355acc1 in pthread_cond_wait@@GLIBC_2.3.2 () from /lib64/libpthread.so.0
#10 0x00007f5403dccb10 in std::sys::unix::condvar::Condvar::wait (self=<optimized out>, mutex=<optimized out>) at libstd/sys/unix/condvar.rs:78
#11 std::sys_common::condvar::Condvar::wait (mutex=<optimized out>, self=<optimized out>) at libstd/sys_common/condvar.rs:51
#12 std::sync::condvar::Condvar::wait (self=<optimized out>, guard=...) at libstd/sync/condvar.rs:212
#13 0x00007f5403de38f8 in std::thread::park () at libstd/thread/mod.rs:800
#14 0x00007f5403db7d70 in std::sync::mpsc::blocking::WaitToken::wait (self=...) at libstd/sync/mpsc/blocking.rs:81
#15 0x00007f54000f1ad1 in <std::sync::mpsc::stream::Packet<T>>::recv (self=0x7f53dc001e00, deadline=...) at /home/emilio/projects/moz/rust/src/libstd/sync/mpsc/stream.rs:210
#16 0x00007f54000f5f9b in <std::sync::mpsc::Receiver<T>>::recv (self=<optimized out>) at /home/emilio/projects/moz/rust/src/libstd/sync/mpsc/mod.rs:1210
#17 <std::sync::mpsc::IntoIter<T> as core::iter::iterator::Iterator>::next (self=0x7f53ead778d0) at /home/emilio/projects/moz/rust/src/libstd/sync/mpsc/mod.rs:1589
#18 0x00007f54000eee0f in jobserver::imp::spawn_helper::{{closure}} () at /home/emilio/.cargo/registry/src/github.com-1ecc6299db9ec823/jobserver-0.1.9/src/lib.rs:599
#19 std::sys_common::backtrace::__rust_begin_short_backtrace (f=...) at /home/emilio/projects/moz/rust/src/libstd/sys_common/backtrace.rs:136
#20 0x00007f54000f1810 in std::thread::Builder::spawn::{{closure}}::{{closure}} () at /home/emilio/projects/moz/rust/src/libstd/thread/mod.rs:406
#21 <std::panic::AssertUnwindSafe<F> as core::ops::function::FnOnce<()>>::call_once (self=..., _args=<optimized out>) at /home/emilio/projects/moz/rust/src/libstd/panic.rs:293
#22 std::panicking::try::do_call (data=<optimized out>) at /home/emilio/projects/moz/rust/src/libstd/panicking.rs:479
#23 0x00007f5403df628f in __rust_maybe_catch_panic (f=0xca, data=0x7f53f508d89c "\000", data_ptr=0x7f53ead77a00, vtable_ptr=0x7f53ead779f8) at libpanic_unwind/lib.rs:102
#24 0x00007f54000f1763 in std::panicking::try (f=...) at /home/emilio/projects/moz/rust/src/libstd/panicking.rs:458
#25 0x00007f54000f041e in std::panic::catch_unwind (f=...) at /home/emilio/projects/moz/rust/src/libstd/panic.rs:358
#26 std::thread::Builder::spawn::{{closure}} () at /home/emilio/projects/moz/rust/src/libstd/thread/mod.rs:405
#27 <F as alloc::boxed::FnBox<A>>::call_box (self=0x7f53f508d910, args=<optimized out>) at /home/emilio/projects/moz/rust/src/liballoc/boxed.rs:788
#28 0x00007f5403dd1fec in _$LT$alloc..boxed..Box$LT$alloc..boxed..FnBox$LT$A$C$$u20$Output$u3d$R$GT$$u20$$u2b$$u20$$u27$a$GT$$u20$as$u20$core..ops..function..FnOnce$LT$A$GT$$GT$::call_once::hbc01871d4ce3ef85 (self=<error reading variable: access outside bounds of object referenced via synthetic pointer>, args=<optimized out>)
at /home/emilio/projects/moz/rust/src/liballoc/boxed.rs:798
#29 std::sys_common::thread::start_thread (main=<optimized out>) at libstd/sys_common/thread.rs:24
#30 std::sys::unix::thread::Thread::new::thread_start (main=0x7f53f508d850) at libstd/sys/unix/thread.rs:90
#31 0x00007f540355461b in start_thread () from /lib64/libpthread.so.0
#32 0x00007f5403a8798f in clone () from /lib64/libc.so.6
```
</details>
Thread 5:
<details>
```
(rr) bt
#0 0x0000000070000002 in ?? ()
#1 0x00007f54044da83f in _raw_syscall () at /home/emilio/projects/moz/rr/src/preload/raw_syscall.S:120
#2 0x00007f54044d7d84 in traced_raw_syscall (call=<optimized out>) at /home/emilio/projects/moz/rr/src/preload/syscallbuf.c:203
#3 sys_readlink (call=<optimized out>) at /home/emilio/projects/moz/rr/src/preload/syscallbuf.c:1866
#4 syscall_hook_internal (call=0x7f53ea676fa0) at /home/emilio/projects/moz/rr/src/preload/syscallbuf.c:2496
#5 0x00007f54044d61a1 in syscall_hook (call=0x7f53ea676fa0) at /home/emilio/projects/moz/rr/src/preload/syscallbuf.c:2576
#6 0x00007f54044d58da in _syscall_hook_trampoline () at /home/emilio/projects/moz/rr/src/preload/syscall_hook.S:282
#7 0x00007f54044d590a in __morestack () at /home/emilio/projects/moz/rr/src/preload/syscall_hook.S:417
#8 0x00007f54044d5925 in _syscall_hook_trampoline_48_3d_00_f0_ff_ff () at /home/emilio/projects/moz/rr/src/preload/syscall_hook.S:428
#9 0x00007f540355acc1 in pthread_cond_wait@@GLIBC_2.3.2 () from /lib64/libpthread.so.0
#10 0x00007f5403dccb10 in std::sys::unix::condvar::Condvar::wait (self=<optimized out>, mutex=<optimized out>) at libstd/sys/unix/condvar.rs:78
#11 std::sys_common::condvar::Condvar::wait (mutex=<optimized out>, self=<optimized out>) at libstd/sys_common/condvar.rs:51
#12 std::sync::condvar::Condvar::wait (self=<optimized out>, guard=...) at libstd/sync/condvar.rs:212
#13 0x00007f5403de38f8 in std::thread::park () at libstd/thread/mod.rs:800
#14 0x00007f5403db7d70 in std::sync::mpsc::blocking::WaitToken::wait (self=...) at libstd/sync/mpsc/blocking.rs:81
#15 0x00007f53edd6addf in <std::sync::mpsc::shared::Packet<T>>::recv (self=0x7f53f508b4a0, deadline=...) at /home/emilio/projects/moz/rust/src/libstd/sync/mpsc/shared.rs:239
#16 0x00007f53ede45560 in <std::sync::mpsc::Receiver<T>>::recv (self=0x7f53ea8758b0) at /home/emilio/projects/moz/rust/src/libstd/sync/mpsc/mod.rs:1218
#17 0x00007f53ede0277c in rustc_trans::back::write::start_executing_work::{{closure}} () at librustc_trans/back/write.rs:1757
#18 std::sys_common::backtrace::__rust_begin_short_backtrace (f=...) at /home/emilio/projects/moz/rust/src/libstd/sys_common/backtrace.rs:136
#19 0x00007f53ede79bdc in std::thread::Builder::spawn::{{closure}}::{{closure}} () at /home/emilio/projects/moz/rust/src/libstd/thread/mod.rs:406
#20 <std::panic::AssertUnwindSafe<F> as core::ops::function::FnOnce<()>>::call_once (self=..., _args=<optimized out>) at /home/emilio/projects/moz/rust/src/libstd/panic.rs:293
#21 std::panicking::try::do_call (data=0x7f53ea876498 "\000") at /home/emilio/projects/moz/rust/src/libstd/panicking.rs:479
#22 0x00007f5403df628f in __rust_maybe_catch_panic (f=0xca, data=0x7f53f508df3c "\000", data_ptr=0x7f53ea876638, vtable_ptr=0x7f53ea876630) at libpanic_unwind/lib.rs:102
#23 0x00007f53ede79a2c in std::panicking::try (f=...) at /home/emilio/projects/moz/rust/src/libstd/panicking.rs:458
#24 0x00007f53ede0b9aa in std::panic::catch_unwind (f=...) at /home/emilio/projects/moz/rust/src/libstd/panic.rs:358
#25 std::thread::Builder::spawn::{{closure}} () at /home/emilio/projects/moz/rust/src/libstd/thread/mod.rs:405
#26 <F as alloc::boxed::FnBox<A>>::call_box (self=0x7f53f508ec70, args=<optimized out>) at /home/emilio/projects/moz/rust/src/liballoc/boxed.rs:788
#27 0x00007f5403dd1fec in _$LT$alloc..boxed..Box$LT$alloc..boxed..FnBox$LT$A$C$$u20$Output$u3d$R$GT$$u20$$u2b$$u20$$u27$a$GT$$u20$as$u20$core..ops..function..FnOnce$LT$A$GT$$GT$::call_once::hbc01871d4ce3ef85 (self=<error reading variable: access outside bounds of object referenced via synthetic pointer>, args=<optimized out>)
at /home/emilio/projects/moz/rust/src/liballoc/boxed.rs:798
#28 std::sys_common::thread::start_thread (main=<optimized out>) at libstd/sys_common/thread.rs:24
#29 std::sys::unix::thread::Thread::new::thread_start (main=0x7f53f508ee20) at libstd/sys/unix/thread.rs:90
#30 0x00007f540355461b in start_thread () from /lib64/libpthread.so.0
#31 0x00007f5403a8798f in clone () from /lib64/libc.so.6
```
</details>
Thread 6 is running the same LLVM pass:
<details>
```
(rr) bt
#0 0x00007f53ee144373 in llvm::SmallPtrSetImplBase::insert_imp (this=0x7f53ea372a60, Ptr=0x7f53e0054a30) at /home/emilio/projects/moz/rust/src/llvm/include/llvm/ADT/SmallPtrSet.h:132
#1 0x00007f53ee63d62a in llvm::SmallPtrSetImpl<llvm::SDNode*>::insert (this=0x7f53ea372a60, Ptr=0x7f53e0054a30)
at /home/emilio/projects/moz/rust/src/llvm/include/llvm/ADT/SmallPtrSet.h:372
#2 0x00007f53ef6b84b1 in llvm::ScheduleDAGSDNodes::BuildSchedUnits (this=0x7f53e00a3f20) at /home/emilio/projects/moz/rust/src/llvm/lib/CodeGen/SelectionDAG/ScheduleDAGSDNodes.cpp:334
#3 0x00007f53ef6b914c in llvm::ScheduleDAGSDNodes::BuildSchedGraph (this=0x7f53e00a3f20, AA=0x0)
at /home/emilio/projects/moz/rust/src/llvm/lib/CodeGen/SelectionDAG/ScheduleDAGSDNodes.cpp:518
#4 0x00007f53ef6a6b9f in (anonymous namespace)::ScheduleDAGRRList::Schedule (this=0x7f53e00a3f20)
at /home/emilio/projects/moz/rust/src/llvm/lib/CodeGen/SelectionDAG/ScheduleDAGRRList.cpp:365
#5 0x00007f53ef6b6bfb in llvm::ScheduleDAGSDNodes::Run (this=0x7f53e00a3f20, dag=0x7f53e00549f0, bb=0x7f53e0087ed8)
at /home/emilio/projects/moz/rust/src/llvm/lib/CodeGen/SelectionDAG/ScheduleDAGSDNodes.cpp:63
#6 0x00007f53ef778d09 in llvm::SelectionDAGISel::CodeGenAndEmitDAG (this=0x7f53e00080f0) at /home/emilio/projects/moz/rust/src/llvm/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp:884
#7 0x00007f53ef77baac in llvm::SelectionDAGISel::SelectAllBasicBlocks (this=0x7f53e00080f0, Fn=...)
at /home/emilio/projects/moz/rust/src/llvm/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp:1422
#8 0x00007f53ef775e3e in llvm::SelectionDAGISel::runOnMachineFunction (this=0x7f53e00080f0, mf=...)
at /home/emilio/projects/moz/rust/src/llvm/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp:466
#9 0x00007f53ee213fad in (anonymous namespace)::X86DAGToDAGISel::runOnMachineFunction (this=0x7f53e00080f0, MF=...)
at /home/emilio/projects/moz/rust/src/llvm/lib/Target/X86/X86ISelDAGToDAG.cpp:175
#10 0x00007f53efaf72a3 in llvm::MachineFunctionPass::runOnFunction (this=0x7f53e00080f0, F=...) at /home/emilio/projects/moz/rust/src/llvm/lib/CodeGen/MachineFunctionPass.cpp:62
#11 0x00007f53f07f353b in llvm::FPPassManager::runOnFunction (this=0x7f53e0095140, F=...) at /home/emilio/projects/moz/rust/src/llvm/lib/IR/LegacyPassManager.cpp:1520
#12 0x00007f53f07f36bc in llvm::FPPassManager::runOnModule (this=0x7f53e0095140, M=...) at /home/emilio/projects/moz/rust/src/llvm/lib/IR/LegacyPassManager.cpp:1541
#13 0x00007f53f07f3a0d in (anonymous namespace)::MPPassManager::runOnModule (this=0x7f53e00562a0, M=...) at /home/emilio/projects/moz/rust/src/llvm/lib/IR/LegacyPassManager.cpp:1597
#14 0x00007f53f07f40f9 in llvm::legacy::PassManagerImpl::run (this=0x7f53e000a860, M=...) at /home/emilio/projects/moz/rust/src/llvm/lib/IR/LegacyPassManager.cpp:1700
#15 0x00007f53f07f42f1 in llvm::legacy::PassManager::run (this=0x7f53e0090150, M=...) at /home/emilio/projects/moz/rust/src/llvm/lib/IR/LegacyPassManager.cpp:1731
#16 0x00007f53ee0bf47e in LLVMRustWriteOutputFile (Target=0x7f53f56b77e0, PMR=0x7f53e0090150, M=0x7f53f4965900, Path=0x7f53e0011850 "test.test0.rcgu.o", RustFileType=<optimized out>)
at ../rustllvm/PassWrapper.cpp:530
#17 0x00007f53ede2e7a2 in rustc_trans::back::write::write_output_file (handler=0x7f53ea3748e0, target=0x7f53ea372a60, pm=0x7f53e0054a30, m=0x7f53ea372a88, output=0x7f53e0011080,
file_type=rustc_llvm::ffi::FileType::ObjectFile) at librustc_trans/back/write.rs:102
#18 0x00007f53ede15176 in rustc_trans::back::write::codegen::{{closure}}::{{closure}} (cpm=0x7f53e0090150) at librustc_trans/back/write.rs:773
#19 rustc_trans::back::write::codegen::with_codegen (tm=0x7f53f56b77e0, llmod=<optimized out>, no_builtins=<optimized out>, f=...) at librustc_trans/back/write.rs:639
#20 rustc_trans::back::write::codegen::{{closure}} () at librustc_trans/back/write.rs:772
#21 0x00007f53ede0e22a in rustc::util::common::time (do_it=<optimized out>, what=..., f=...) at /home/emilio/projects/moz/rust/src/librustc/util/common.rs:120
#22 0x00007f53ede3086d in rustc_trans::back::write::codegen (cgcx=<optimized out>, diag_handler=<optimized out>, mtrans=..., config=<optimized out>, timeline=<optimized out>)
at librustc_trans/back/write.rs:695
#23 0x00007f53ede37866 in rustc_trans::back::write::execute_work_item (cgcx=0x7f53ea374ef8, work_item=..., timeline=<optimized out>) at librustc_trans/back/write.rs:1346
#24 0x00007f53ede01046 in rustc_trans::back::write::spawn_work::{{closure}} () at librustc_trans/back/write.rs:1970
#25 std::sys_common::backtrace::__rust_begin_short_backtrace (f=...) at /home/emilio/projects/moz/rust/src/libstd/sys_common/backtrace.rs:136
#26 0x00007f53ede79c2e in std::thread::Builder::spawn::{{closure}}::{{closure}} () at /home/emilio/projects/moz/rust/src/libstd/thread/mod.rs:406
#27 <std::panic::AssertUnwindSafe<F> as core::ops::function::FnOnce<()>>::call_once (self=..., _args=<optimized out>) at /home/emilio/projects/moz/rust/src/libstd/panic.rs:293
#28 std::panicking::try::do_call (data=<optimized out>) at /home/emilio/projects/moz/rust/src/libstd/panicking.rs:479
#29 0x00007f5403df628f in __rust_maybe_catch_panic (f=0x7f53ea372a98, data=0x7f53ea372a60 "\006", data_ptr=0x7f53ea3756f8, vtable_ptr=0x7f53ea3756f0) at libpanic_unwind/lib.rs:102
#30 0x00007f53ede79b1c in std::panicking::try (f=...) at /home/emilio/projects/moz/rust/src/libstd/panicking.rs:458
#31 0x00007f53ede0b7e9 in std::panic::catch_unwind (f=...) at /home/emilio/projects/moz/rust/src/libstd/panic.rs:358
#32 std::thread::Builder::spawn::{{closure}} () at /home/emilio/projects/moz/rust/src/libstd/thread/mod.rs:405
#33 <F as alloc::boxed::FnBox<A>>::call_box (self=0x7f53dc001130, args=<optimized out>) at /home/emilio/projects/moz/rust/src/liballoc/boxed.rs:788
#34 0x00007f5403dd1fec in _$LT$alloc..boxed..Box$LT$alloc..boxed..FnBox$LT$A$C$$u20$Output$u3d$R$GT$$u20$$u2b$$u20$$u27$a$GT$$u20$as$u20$core..ops..function..FnOnce$LT$A$GT$$GT$::call_once::hbc01871d4ce3ef85 (self=<error reading variable: access outside bounds of object referenced via synthetic pointer>, args=<optimized out>)
#35 std::sys_common::thread::start_thread (main=<optimized out>) at libstd/sys_common/thread.rs:24
#36 std::sys::unix::thread::Thread::new::thread_start (main=0x7f53e4000d00) at libstd/sys/unix/thread.rs:90
#37 0x00007f540355461b in start_thread () from /lib64/libpthread.so.0
#38 0x00007f5403a8798f in clone () from /lib64/libc.so.6
```
</details>
Thread 7:
<details>
```
(rr) thread 7
[Switching to thread 7 (Thread 31405.31432)]
#0 0x00007f53f07f7236 in llvm::DenseMapIterator<void const*, llvm::Pass*, llvm::DenseMapInfo<void const*>, llvm::detail::DenseMapPair<void const*, llvm::Pass*>, true>::DenseMapIterator<false, void> (this=0x7f53e9971e20, I=...) at /home/emilio/projects/moz/rust/src/llvm/include/llvm/ADT/DenseMap.h:1149
1149 : DebugEpochBase::HandleBase(I), Ptr(I.Ptr), End(I.End) {}
(rr) bt
#0 0x00007f53f07f7236 in llvm::DenseMapIterator<void const*, llvm::Pass*, llvm::DenseMapInfo<void const*>, llvm::detail::DenseMapPair<void const*, llvm::Pass*>, true>::DenseMapIterator<false, void> (this=0x7f53e9971e20, I=...) at /home/emilio/projects/moz/rust/src/llvm/include/llvm/ADT/DenseMap.h:1149
#1 0x00007f53f07f194c in llvm::PMDataManager::findAnalysisPass (this=0x7f53d8001130, AID=0x7f53f3ff2a08 <llvm::BasicAAWrapperPass::ID>, SearchParent=false)
at /home/emilio/projects/moz/rust/src/llvm/lib/IR/LegacyPassManager.cpp:1096
#2 0x00007f53f07efbc0 in llvm::PMTopLevelManager::findAnalysisPass (this=0x7f53d80016d0, AID=0x7f53f3ff2a08 <llvm::BasicAAWrapperPass::ID>)
at /home/emilio/projects/moz/rust/src/llvm/lib/IR/LegacyPassManager.cpp:725
#3 0x00007f53f07f19cb in llvm::PMDataManager::findAnalysisPass (this=0x7f53d8001130, AID=0x7f53f3ff2a08 <llvm::BasicAAWrapperPass::ID>, SearchParent=true)
at /home/emilio/projects/moz/rust/src/llvm/lib/IR/LegacyPassManager.cpp:1103
#4 0x00007f53f07f07ad in llvm::PMDataManager::verifyPreservedAnalysis (this=0x7f53d8001130, P=0x7f53d800e480) at /home/emilio/projects/moz/rust/src/llvm/lib/IR/LegacyPassManager.cpp:867
#5 0x00007f53f07f35d8 in llvm::FPPassManager::runOnFunction (this=0x7f53d8001110, F=...) at /home/emilio/projects/moz/rust/src/llvm/lib/IR/LegacyPassManager.cpp:1529
#6 0x00007f53f07f36bc in llvm::FPPassManager::runOnModule (this=0x7f53d8001110, M=...) at /home/emilio/projects/moz/rust/src/llvm/lib/IR/LegacyPassManager.cpp:1541
#7 0x00007f53f07f3a0d in (anonymous namespace)::MPPassManager::runOnModule (this=0x7f53d8001a20, M=...) at /home/emilio/projects/moz/rust/src/llvm/lib/IR/LegacyPassManager.cpp:1597
#8 0x00007f53f07f40f9 in llvm::legacy::PassManagerImpl::run (this=0x7f53d8001510, M=...) at /home/emilio/projects/moz/rust/src/llvm/lib/IR/LegacyPassManager.cpp:1700
#9 0x00007f53f07f42f1 in llvm::legacy::PassManager::run (this=0x7f53d800ab30, M=...) at /home/emilio/projects/moz/rust/src/llvm/lib/IR/LegacyPassManager.cpp:1731
#10 0x00007f53ee0bf47e in LLVMRustWriteOutputFile (Target=0x7f53f4fbb570, PMR=0x7f53d800ab30, M=0x7f53f407de60, Path=0x7f53d800a880 "test.test2.rcgu.o", RustFileType=<optimized out>)
at ../rustllvm/PassWrapper.cpp:530
#11 0x00007f53ede2e7a2 in rustc_trans::back::write::write_output_file (handler=0x7f53e99728e0, target=0x7f53e9971e20, pm=0x7f53e9971e40, m=0x7f53d8003b10, output=0x7f53d800b070,
file_type=rustc_llvm::ffi::FileType::ObjectFile) at librustc_trans/back/write.rs:102
#12 0x00007f53ede15176 in rustc_trans::back::write::codegen::{{closure}}::{{closure}} (cpm=0x7f53d800ab30) at librustc_trans/back/write.rs:773
#13 rustc_trans::back::write::codegen::with_codegen (tm=0x7f53f4fbb570, llmod=<optimized out>, no_builtins=<optimized out>, f=...) at librustc_trans/back/write.rs:639
#14 rustc_trans::back::write::codegen::{{closure}} () at librustc_trans/back/write.rs:772
#15 0x00007f53ede0e22a in rustc::util::common::time (do_it=<optimized out>, what=..., f=...) at /home/emilio/projects/moz/rust/src/librustc/util/common.rs:120
#16 0x00007f53ede3086d in rustc_trans::back::write::codegen (cgcx=<optimized out>, diag_handler=<optimized out>, mtrans=..., config=<optimized out>, timeline=<optimized out>)
at librustc_trans/back/write.rs:695
#17 0x00007f53ede37866 in rustc_trans::back::write::execute_work_item (cgcx=0x7f53e9972ef8, work_item=..., timeline=<optimized out>) at librustc_trans/back/write.rs:1346
#18 0x00007f53ede01046 in rustc_trans::back::write::spawn_work::{{closure}} () at librustc_trans/back/write.rs:1970
#19 std::sys_common::backtrace::__rust_begin_short_backtrace (f=...) at /home/emilio/projects/moz/rust/src/libstd/sys_common/backtrace.rs:136
#20 0x00007f53ede79c2e in std::thread::Builder::spawn::{{closure}}::{{closure}} () at /home/emilio/projects/moz/rust/src/libstd/thread/mod.rs:406
#21 <std::panic::AssertUnwindSafe<F> as core::ops::function::FnOnce<()>>::call_once (self=..., _args=<optimized out>) at /home/emilio/projects/moz/rust/src/libstd/panic.rs:293
#22 std::panicking::try::do_call (data=<optimized out>) at /home/emilio/projects/moz/rust/src/libstd/panicking.rs:479
#23 0x00007f5403df628f in __rust_maybe_catch_panic (f=0x7f53e9971e20, data=0x7f53e9971e20 "\020\022", data_ptr=0x7f53e99736f8, vtable_ptr=0x7f53e99736f0) at libpanic_unwind/lib.rs:102
#24 0x00007f53ede79b1c in std::panicking::try (f=...) at /home/emilio/projects/moz/rust/src/libstd/panicking.rs:458
#25 0x00007f53ede0b7e9 in std::panic::catch_unwind (f=...) at /home/emilio/projects/moz/rust/src/libstd/panic.rs:358
#26 std::thread::Builder::spawn::{{closure}} () at /home/emilio/projects/moz/rust/src/libstd/thread/mod.rs:405
#27 <F as alloc::boxed::FnBox<A>>::call_box (self=0x7f53dc003260, args=<optimized out>) at /home/emilio/projects/moz/rust/src/liballoc/boxed.rs:788
#28 0x00007f5403dd1fec in _$LT$alloc..boxed..Box$LT$alloc..boxed..FnBox$LT$A$C$$u20$Output$u3d$R$GT$$u20$$u2b$$u20$$u27$a$GT$$u20$as$u20$core..ops..function..FnOnce$LT$A$GT$$GT$::call_once::hbc01871d4ce3ef85 (self=<error reading variable: access outside bounds of object referenced via synthetic pointer>, args=<optimized out>)
at /home/emilio/projects/moz/rust/src/liballoc/boxed.rs:798
#29 std::sys_common::thread::start_thread (main=<optimized out>) at libstd/sys_common/thread.rs:24
#30 std::sys::unix::thread::Thread::new::thread_start (main=0x7f53d4022590) at libstd/sys/unix/thread.rs:90
#31 0x00007f540355461b in start_thread () from /lib64/libpthread.so.0
#32 0x00007f5403a8798f in clone () from /lib64/libc.so.6
```
</details>
Thread 8:
<details>
```
(rr) thread 8
[Switching to thread 8 (Thread 31405.31435)]
#0 llvm::DenseMapBase<llvm::DenseMap<unsigned int, std::pair<unsigned short, unsigned short>, llvm::DenseMapInfo<unsigned int>, llvm::detail::DenseMapPair<unsigned int, std::pair<unsigned short, unsigned short> > >, unsigned int, std::pair<unsigned short, unsigned short>, llvm::DenseMapInfo<unsigned int>, llvm::detail::DenseMapPair<unsigned int, std::pair<unsigned short, unsigned short> > >::initEmpty (this=0x7f53cc025348) at /home/emilio/projects/moz/rust/src/llvm/include/llvm/ADT/DenseMap.h:347
347 ::new (&B->getFirst()) KeyT(EmptyKey);
(rr) bt
#0 llvm::DenseMapBase<llvm::DenseMap<unsigned int, std::pair<unsigned short, unsigned short>, llvm::DenseMapInfo<unsigned int>, llvm::detail::DenseMapPair<unsigned int, std::pair<unsigned short, unsigned short> > >, unsigned int, std::pair<unsigned short, unsigned short>, llvm::DenseMapInfo<unsigned int>, llvm::detail::DenseMapPair<unsigned int, std::pair<unsigned short, unsigned short> > >::initEmpty (this=0x7f53cc025348) at /home/emilio/projects/moz/rust/src/llvm/include/llvm/ADT/DenseMap.h:347
#1 0x00007f53ee3b6cb7 in llvm::DenseMapBase<llvm::DenseMap<unsigned int, std::pair<unsigned short, unsigned short>, llvm::DenseMapInfo<unsigned int>, llvm::detail::DenseMapPair<unsigned int, std::pair<unsigned short, unsigned short> > >, unsigned int, std::pair<unsigned short, unsigned short>, llvm::DenseMapInfo<unsigned int>, llvm::detail::DenseMapPair<unsigned int, std::pair<unsigned short, unsigned short> > >::moveFromOldBuckets (this=0x7f53cc025348, OldBucketsBegin=0x7f53cc049160, OldBucketsEnd=0x7f53cc051160)
at /home/emilio/projects/moz/rust/src/llvm/include/llvm/ADT/DenseMap.h:362
#2 0x00007f53ee3b6a5e in llvm::DenseMap<unsigned int, std::pair<unsigned short, unsigned short>, llvm::DenseMapInfo<unsigned int>, llvm::detail::DenseMapPair<unsigned int, std::pair<unsigned short, unsigned short> > >::grow (this=0x7f53cc025348, AtLeast=8192) at /home/emilio/projects/moz/rust/src/llvm/include/llvm/ADT/DenseMap.h:739
#3 0x00007f53ee3b65c4 in llvm::DenseMapBase<llvm::DenseMap<unsigned int, std::pair<unsigned short, unsigned short>, llvm::DenseMapInfo<unsigned int>, llvm::detail::DenseMapPair<unsigned int, std::pair<unsigned short, unsigned short> > >, unsigned int, std::pair<unsigned short, unsigned short>, llvm::DenseMapInfo<unsigned int>, llvm::detail::DenseMapPair<unsigned int, std::pair<unsigned short, unsigned short> > >::grow (this=0x7f53cc025348, AtLeast=8192) at /home/emilio/projects/moz/rust/src/llvm/include/llvm/ADT/DenseMap.h:502
#4 0x00007f53ee3b5da5 in llvm::DenseMapBase<llvm::DenseMap<unsigned int, std::pair<unsigned short, unsigned short>, llvm::DenseMapInfo<unsigned int>, llvm::detail::DenseMapPair<unsigned int, std::pair<unsigned short, unsigned short> > >, unsigned int, std::pair<unsigned short, unsigned short>, llvm::DenseMapInfo<unsigned int>, llvm::detail::DenseMapPair<unsigned int, std::pair<unsigned short, unsigned short> > >::InsertIntoBucketImpl<unsigned int> (this=0x7f53cc025348, Key=@0x7f53e947094c: 7219, Lookup=@0x7f53e947094c: 7219, TheBucket=0x7f53cc04acd0)
at /home/emilio/projects/moz/rust/src/llvm/include/llvm/ADT/DenseMap.h:546
#5 0x00007f53ee3b4ce7 in llvm::DenseMapBase<llvm::DenseMap<unsigned int, std::pair<unsigned short, unsigned short>, llvm::DenseMapInfo<unsigned int>, llvm::detail::DenseMapPair<unsigned int, std::pair<unsigned short, unsigned short> > >, unsigned int, std::pair<unsigned short, unsigned short>, llvm::DenseMapInfo<unsigned int>, llvm::detail::DenseMapPair<unsigned int, std::pair<unsigned short, unsigned short> > >::InsertIntoBucket<unsigned int> (this=0x7f53cc025348, TheBucket=0x7f53cc04acd0, Key=@0x7f53e947094c: 7219)
at /home/emilio/projects/moz/rust/src/llvm/include/llvm/ADT/DenseMap.h:512
#6 0x00007f53ee3b3ad1 in llvm::DenseMapBase<llvm::DenseMap<unsigned int, std::pair<unsigned short, unsigned short>, llvm::DenseMapInfo<unsigned int>, llvm::detail::DenseMapPair<unsigned int, std::pair<unsigned short, unsigned short> > >, unsigned int, std::pair<unsigned short, unsigned short>, llvm::DenseMapInfo<unsigned int>, llvm::detail::DenseMapPair<unsigned int, std::pair<unsigned short, unsigned short> > >::FindAndConstruct (this=0x7f53cc025348, Key=@0x7f53e947094c: 7219) at /home/emilio/projects/moz/rust/src/llvm/include/llvm/ADT/DenseMap.h:304
#7 0x00007f53ee3b20c4 in llvm::DenseMapBase<llvm::DenseMap<unsigned int, std::pair<unsigned short, unsigned short>, llvm::DenseMapInfo<unsigned int>, llvm::detail::DenseMapPair<unsigned int, std::pair<unsigned short, unsigned short> > >, unsigned int, std::pair<unsigned short, unsigned short>, llvm::DenseMapInfo<unsigned int>, llvm::detail::DenseMapPair<unsigned int, std::pair<unsigned short, unsigned short> > >::operator[] (this=0x7f53cc025348, Key=@0x7f53e947094c: 7219) at /home/emilio/projects/moz/rust/src/llvm/include/llvm/ADT/DenseMap.h:308
#8 0x00007f53ee39971b in llvm::X86InstrInfo::AddTableEntry (R2MTable=..., M2RTable=..., RegOp=7222, MemOp=7219, Flags=68)
at /home/emilio/projects/moz/rust/src/llvm/lib/Target/X86/X86InstrInfo.cpp:3747
#9 0x00007f53ee3993cf in llvm::X86InstrInfo::X86InstrInfo (this=0x7f53cc025110, STI=...) at /home/emilio/projects/moz/rust/src/llvm/lib/Target/X86/X86InstrInfo.cpp:3715
#10 0x00007f53ee3e75eb in llvm::X86Subtarget::X86Subtarget (this=0x7f53cc024ef0, TT=..., CPU=..., FS=..., TM=..., StackAlignOverride=0)
at /home/emilio/projects/moz/rust/src/llvm/lib/Target/X86/X86Subtarget.cpp:371
#11 0x00007f53ee3f02e0 in llvm::make_unique<llvm::X86Subtarget, llvm::Triple const&, llvm::StringRef&, llvm::StringRef&, llvm::X86TargetMachine const&, unsigned int&> (args#0=...,
args#1=..., args#2=..., args#3=..., args#4=@0x7f53f503f0a4: 0) at /home/emilio/projects/moz/rust/src/llvm/include/llvm/ADT/STLExtras.h:945
#12 0x00007f53ee3ede09 in llvm::X86TargetMachine::getSubtargetImpl (this=0x7f53f503ed90, F=...) at /home/emilio/projects/moz/rust/src/llvm/lib/Target/X86/X86TargetMachine.cpp:266
#13 0x00007f53ef955b05 in (anonymous namespace)::AtomicExpand::runOnFunction (this=0x7f53cc000b20, F=...) at /home/emilio/projects/moz/rust/src/llvm/lib/CodeGen/AtomicExpandPass.cpp:200
#14 0x00007f53f07f353b in llvm::FPPassManager::runOnFunction (this=0x7f53cc0070e0, F=...) at /home/emilio/projects/moz/rust/src/llvm/lib/IR/LegacyPassManager.cpp:1520
#15 0x00007f53f07f36bc in llvm::FPPassManager::runOnModule (this=0x7f53cc0070e0, M=...) at /home/emilio/projects/moz/rust/src/llvm/lib/IR/LegacyPassManager.cpp:1541
#16 0x00007f53f07f3a0d in (anonymous namespace)::MPPassManager::runOnModule (this=0x7f53cc001a20, M=...) at /home/emilio/projects/moz/rust/src/llvm/lib/IR/LegacyPassManager.cpp:1597
#17 0x00007f53f07f40f9 in llvm::legacy::PassManagerImpl::run (this=0x7f53cc0014f0, M=...) at /home/emilio/projects/moz/rust/src/llvm/lib/IR/LegacyPassManager.cpp:1700
#18 0x00007f53f07f42f1 in llvm::legacy::PassManager::run (this=0x7f53cc00a960, M=...) at /home/emilio/projects/moz/rust/src/llvm/lib/IR/LegacyPassManager.cpp:1731
#19 0x00007f53ee0bf47e in LLVMRustWriteOutputFile (Target=0x7f53f503ed90, PMR=0x7f53cc00a960, M=0x7f53f571c4f0, Path=0x7f53cc00a820 "test.test3.rcgu.o", RustFileType=<optimized out>)
at ../rustllvm/PassWrapper.cpp:530
#20 0x00007f53ede2e7a2 in rustc_trans::back::write::write_output_file (handler=0x7f53e94718e0, target=0x4, pm=0x7f53cc054660, m=0xffffffff, output=0x7f53cc00c060,
file_type=rustc_llvm::ffi::FileType::ObjectFile) at librustc_trans/back/write.rs:102
#21 0x00007f53ede15176 in rustc_trans::back::write::codegen::{{closure}}::{{closure}} (cpm=0x7f53cc00a960) at librustc_trans/back/write.rs:773
#22 rustc_trans::back::write::codegen::with_codegen (tm=0x7f53f503ed90, llmod=<optimized out>, no_builtins=<optimized out>, f=...) at librustc_trans/back/write.rs:639
#23 rustc_trans::back::write::codegen::{{closure}} () at librustc_trans/back/write.rs:772
#24 0x00007f53ede0e22a in rustc::util::common::time (do_it=<optimized out>, what=..., f=...) at /home/emilio/projects/moz/rust/src/librustc/util/common.rs:120
#25 0x00007f53ede3086d in rustc_trans::back::write::codegen (cgcx=<optimized out>, diag_handler=<optimized out>, mtrans=..., config=<optimized out>, timeline=<optimized out>)
at librustc_trans/back/write.rs:695
#26 0x00007f53ede37866 in rustc_trans::back::write::execute_work_item (cgcx=0x7f53e9471ef8, work_item=..., timeline=<optimized out>) at librustc_trans/back/write.rs:1346
#27 0x00007f53ede01046 in rustc_trans::back::write::spawn_work::{{closure}} () at librustc_trans/back/write.rs:1970
#28 std::sys_common::backtrace::__rust_begin_short_backtrace (f=...) at /home/emilio/projects/moz/rust/src/libstd/sys_common/backtrace.rs:136
#29 0x00007f53ede79c2e in std::thread::Builder::spawn::{{closure}}::{{closure}} () at /home/emilio/projects/moz/rust/src/libstd/thread/mod.rs:406
#30 <std::panic::AssertUnwindSafe<F> as core::ops::function::FnOnce<()>>::call_once (self=..., _args=<optimized out>) at /home/emilio/projects/moz/rust/src/libstd/panic.rs:293
#31 std::panicking::try::do_call (data=<optimized out>) at /home/emilio/projects/moz/rust/src/libstd/panicking.rs:479
#32 0x00007f5403df628f in __rust_maybe_catch_panic (f=0x7f53cc054668, data=0x4 <error: Cannot access memory at address 0x4>, data_ptr=0x7f53e94726f8, vtable_ptr=0x7f53e94726f0)
at libpanic_unwind/lib.rs:102
#33 0x00007f53ede79b1c in std::panicking::try (f=...) at /home/emilio/projects/moz/rust/src/libstd/panicking.rs:458
#34 0x00007f53ede0b7e9 in std::panic::catch_unwind (f=...) at /home/emilio/projects/moz/rust/src/libstd/panic.rs:358
#35 std::thread::Builder::spawn::{{closure}} () at /home/emilio/projects/moz/rust/src/libstd/thread/mod.rs:405
#36 <F as alloc::boxed::FnBox<A>>::call_box (self=0x7f53dc003dc0, args=<optimized out>) at /home/emilio/projects/moz/rust/src/liballoc/boxed.rs:788
#37 0x00007f5403dd1fec in _$LT$alloc..boxed..Box$LT$alloc..boxed..FnBox$LT$A$C$$u20$Output$u3d$R$GT$$u20$$u2b$$u20$$u27$a$GT$$u20$as$u20$core..ops..function..FnOnce$LT$A$GT$$GT$::call_once::hbc01871d4ce3ef85 (self=<error reading variable: access outside bounds of object referenced via synthetic pointer>, args=<optimized out>)
at /home/emilio/projects/moz/rust/src/liballoc/boxed.rs:798
#38 std::sys_common::thread::start_thread (main=<optimized out>) at libstd/sys_common/thread.rs:24
#39 std::sys::unix::thread::Thread::new::thread_start (main=0x7f53dc001770) at libstd/sys/unix/thread.rs:90
#40 0x00007f540355461b in start_thread () from /lib64/libpthread.so.0
#41 0x00007f5403a8798f in clone () from /lib64/libc.so.6
```
</details>
Thread 9:
<details>
```
(rr) bt
#0 0x00007f53ee416f36 in llvm::dyn_cast<llvm::InvokeInst, llvm::Instruction> (Val=0x7f53f57a1d08) at /home/emilio/projects/moz/rust/src/llvm/include/llvm/Support/Casting.h:333
#1 0x00007f53f087faf9 in (anonymous namespace)::Verifier::verifyDominatesUse (this=0x7f53d0007720, I=..., i=0) at /home/emilio/projects/moz/rust/src/llvm/lib/IR/Verifier.cpp:3711
#2 0x00007f53f0880887 in (anonymous namespace)::Verifier::visitInstruction (this=0x7f53d0007720, I=...) at /home/emilio/projects/moz/rust/src/llvm/lib/IR/Verifier.cpp:3825
#3 0x00007f53f087c8a0 in (anonymous namespace)::Verifier::visitLoadInst (this=0x7f53d0007720, LI=...) at /home/emilio/projects/moz/rust/src/llvm/lib/IR/Verifier.cpp:3133
#4 0x00007f53f088f8ab in llvm::InstVisitor<(anonymous namespace)::Verifier, void>::visitLoad (this=0x7f53d0007720, I=...)
at /home/emilio/projects/moz/rust/src/llvm/include/llvm/IR/Instruction.def:153
#5 0x00007f53f0887d77 in llvm::InstVisitor<(anonymous namespace)::Verifier, void>::visit (this=0x7f53d0007720, I=...)
at /home/emilio/projects/moz/rust/src/llvm/include/llvm/IR/Instruction.def:153
#6 0x00007f53f086ac6f in (anonymous namespace)::Verifier::visit (this=0x7f53d0007720, I=...) at /home/emilio/projects/moz/rust/src/llvm/lib/IR/Verifier.cpp:534
#7 0x00007f53f089736e in llvm::InstVisitor<(anonymous namespace)::Verifier, void>::visit<llvm::ilist_iterator<llvm::ilist_detail::node_options<llvm::Instruction, true, false, void>, false, false> > (this=0x7f53d0007720, Start=..., End=...) at /home/emilio/projects/moz/rust/src/llvm/include/llvm/IR/InstVisitor.h:92
#8 0x00007f53f0894c8e in llvm::InstVisitor<(anonymous namespace)::Verifier, void>::visit (this=0x7f53d0007720, BB=...)
at /home/emilio/projects/moz/rust/src/llvm/include/llvm/IR/InstVisitor.h:107
#9 0x00007f53f088f1a0 in llvm::InstVisitor<(anonymous namespace)::Verifier, void>::visit<llvm::ilist_iterator<llvm::ilist_detail::node_options<llvm::BasicBlock, true, false, void>, false, false> > (this=0x7f53d0007720, Start=..., End=...) at /home/emilio/projects/moz/rust/src/llvm/include/llvm/IR/InstVisitor.h:92
#10 0x00007f53f0887704 in llvm::InstVisitor<(anonymous namespace)::Verifier, void>::visit (this=0x7f53d0007720, F=...)
at /home/emilio/projects/moz/rust/src/llvm/include/llvm/IR/InstVisitor.h:103
#11 0x00007f53f086a741 in (anonymous namespace)::Verifier::verify (this=0x7f53d0007720, F=...) at /home/emilio/projects/moz/rust/src/llvm/lib/IR/Verifier.cpp:348
#12 0x00007f53f08857d2 in (anonymous namespace)::VerifierLegacyPass::runOnFunction (this=0x7f53d0001e70, F=...) at /home/emilio/projects/moz/rust/src/llvm/lib/IR/Verifier.cpp:4659
#13 0x00007f53f07f353b in llvm::FPPassManager::runOnFunction (this=0x7f53d0001110, F=...) at /home/emilio/projects/moz/rust/src/llvm/lib/IR/LegacyPassManager.cpp:1520
#14 0x00007f53f07f32db in llvm::legacy::FunctionPassManagerImpl::run (this=0x7f53d0000c20, F=...) at /home/emilio/projects/moz/rust/src/llvm/lib/IR/LegacyPassManager.cpp:1469
#15 0x00007f53f07f2ec3 in llvm::legacy::FunctionPassManager::run (this=0x7f53d0000c00, F=...) at /home/emilio/projects/moz/rust/src/llvm/lib/IR/LegacyPassManager.cpp:1393
#16 0x00007f53ee0b9050 in LLVMRustRunFunctionPassManager (PMR=0x7f53d0000c00, M=<optimized out>) at ../rustllvm/PassWrapper.cpp:478
#17 0x00007f53ede37614 in rustc_trans::back::write::optimize (diag_handler=<optimized out>, cgcx=<optimized out>, mtrans=<optimized out>, config=<optimized out>, timeline=<optimized out>)
at librustc_trans/back/write.rs:569
#18 rustc_trans::back::write::execute_work_item (cgcx=0x7f53e8f70ef8, work_item=..., timeline=<optimized out>) at librustc_trans/back/write.rs:1301
#19 0x00007f53ede01046 in rustc_trans::back::write::spawn_work::{{closure}} () at librustc_trans/back/write.rs:1970
#20 std::sys_common::backtrace::__rust_begin_short_backtrace (f=...) at /home/emilio/projects/moz/rust/src/libstd/sys_common/backtrace.rs:136
#21 0x00007f53ede79c2e in std::thread::Builder::spawn::{{closure}}::{{closure}} () at /home/emilio/projects/moz/rust/src/libstd/thread/mod.rs:406
#22 <std::panic::AssertUnwindSafe<F> as core::ops::function::FnOnce<()>>::call_once (self=..., _args=<optimized out>) at /home/emilio/projects/moz/rust/src/libstd/panic.rs:293
#23 std::panicking::try::do_call (data=<optimized out>) at /home/emilio/projects/moz/rust/src/libstd/panicking.rs:479
#24 0x00007f5403df628f in __rust_maybe_catch_panic (f=0x7f53f57a1d08, data=0x7f53f57a1d08 "\200Dy\365S\177", data_ptr=0x7f53e8f716f8, vtable_ptr=0x7f53e8f716f0)
at libpanic_unwind/lib.rs:102
#25 0x00007f53ede79b1c in std::panicking::try (f=...) at /home/emilio/projects/moz/rust/src/libstd/panicking.rs:458
#26 0x00007f53ede0b7e9 in std::panic::catch_unwind (f=...) at /home/emilio/projects/moz/rust/src/libstd/panic.rs:358
#27 std::thread::Builder::spawn::{{closure}} () at /home/emilio/projects/moz/rust/src/libstd/thread/mod.rs:405
#28 <F as alloc::boxed::FnBox<A>>::call_box (self=0x7f53dc004920, args=<optimized out>) at /home/emilio/projects/moz/rust/src/liballoc/boxed.rs:788
#29 0x00007f5403dd1fec in _$LT$alloc..boxed..Box$LT$alloc..boxed..FnBox$LT$A$C$$u20$Output$u3d$R$GT$$u20$$u2b$$u20$$u27$a$GT$$u20$as$u20$core..ops..function..FnOnce$LT$A$GT$$GT$::call_once::hbc01871d4ce3ef85 (self=<error reading variable: access outside bounds of object referenced via synthetic pointer>, args=<optimized out>)
at /home/emilio/projects/moz/rust/src/liballoc/boxed.rs:798
#30 std::sys_common::thread::start_thread (main=<optimized out>) at libstd/sys_common/thread.rs:24
#31 std::sys::unix::thread::Thread::new::thread_start (main=0x7f53dc0025b0) at libstd/sys/unix/thread.rs:90
#32 0x00007f540355461b in start_thread () from /lib64/libpthread.so.0
#33 0x00007f5403a8798f in clone () from /lib64/libc.so.6
```
</details> | A-LLVM,T-compiler,C-bug | low | Critical |
298,118,691 | rust | Using std::io::{Read, Write, Cursor} in a nostd environment | I'm surprised there's no ticket for this, so here we go.
It isn't possible in nostd to use [std::io::Cursor](https://doc.rust-lang.org/std/io/struct.Cursor.html). That seems to be mostly because it requires std::io::Read, Write, and Seek. However, I'd argue that those traits should also be part of libcore, and only the specific implementations be in libstd. After all, the Read/Write/Seek traits and the Cursor struct don't seem to rely on anything that's part of the stdlib: they don't need allocation, etc...
My use-case is, I have to write data into an array, and treating that array in a file would lead to much more idiomatic code. Furthermore it'd allow using crates like byteorder in nostd environment. | T-libs-api,C-feature-request,A-io | high | Critical |
298,131,139 | vscode | SCM - Differentiate between submodules and normal repos | ### Issue Type
Feature Request
**I would like submodules to be nested underneath their parent repo in the Source Control Pane.**
### Description
I love the new submodule feature, but there are a couple of issues with the Source Control pane:
* I can't tell which providers (repos) are submodules
* I can't tell what top-level provider a given submodule provider is associated with
For most situations, this probably isn't an issue. But for some of my projects, it is a serious issue. For example, I have projects:
* A - depends on nothing
* B - depends on A
* C - depends on A and B
* etc
For development, I use a multi-root workspace with a directory structure something like this:
* Projects
* A
* B *(references `../A`)*
* C *(references `../A` and `../B`)*
For continuous integration and deployment, I use submodules:
* C *(references `./.libs/A` and `./.libs/B`)*
* .libs
* A
* B *(references `/builds/C/.libs/A`)*
While I could leave the submodules uninitialized on my dev machine, my workflow includes doing a build with submodules before I push, to ensure I haven't forgotten to update a submodule, because why waste CPU cycles on a CI build that's guaranteed to fail.
In this particular example, where B has A as a submodule, and C has A and B, I will have six repos (A, B, C, B/.libs/A, C/.libs/A, and C/.libs/B) show up in VSCode. While I can and do disable submodule discovery for these projects, that doesn't stop VSCode from picking them up when I open a file in a submodule.
### VS Code Info
VS Code version: Code 1.20.1 (f88bbf9137d24d36d968ea6b2911786bfe103002, 2018-02-13T15:34:36.336Z)
OS version: Windows_NT x64 10.0.16299
| help wanted,feature-request,scm | medium | Critical |
298,332,954 | go | cmd/compile, runtime: optimize comparison of large values with zero | ```go
package p
type T [20]byte
func f(x *T) bool {
return *x == T{}
}
```
Currently this sets up and zeros twenty bytes and then calls memequal. Comparing a large type to zero should be easy; we can then dispatch instead to an optimized runtime routine that doesn't need to actually construct a zero value. (Should handle != as well.)
cc @randall77 @martisch
| Performance,compiler/runtime | low | Major |
298,362,815 | go | x/build/cmd/gerritbot: report errors to StackDriver | Currently we donβt know when an import fails unless we check the PRs manually. We should be reporting errors to StackDriver and alert on an error. | Builders | low | Critical |
298,387,526 | godot | Games receive joypad input even if the game window is not focused | **Godot version:**
<!-- Specify commit hash if non-official. -->
3925e6a5431424f422273f3522016a9d6a51a876
**OS/device including version:**
<!-- Specify GPU model and drivers if graphics-related. -->
Tested on Linux Mint 18.3 sylvia
**Issue description:**
<!-- What happened, and what was expected. -->
When running multiple Godot games all games will receive the joypad input. It does not matter if the games are started from the editor or if they are run from the commandline.
**Steps to reproduce:**
1. Run two godot games at the same time and use a joypad.
2. See that both games will process the joypad input regardless of the window focus
| bug,discussion,confirmed,topic:input | medium | Critical |
298,390,302 | TypeScript | rootDir option documentation incorrect and confusing | I've recently started a new project with TS and run into some confusing behaviour. I've placed my files in an "app" folder, but the emitted TS (using AMD modules with --outFile) generates module names without the app prefix, breaking my JS references.
Turns out that I was supposed to use rootDir, instead of rootDirs.
The first issue is that since #5819, this actually does affect outFile as well, so the documentation clearly stating it only applies to outDir is wrong.
The second issue is that it's really confusing the difference between rootDirs and rootDir, and it's still unclear to me why rootDirs: ["./"] did not produce the same result as rootDir: "./". The written documentation is not very clear out this and potentially, one or both options neeed renaming.
This is referencing the current live version on https://www.typescriptlang.org/docs/handbook/compiler-options.html | Docs | low | Minor |
298,487,561 | neovim | API: list builtin (normal-mode) commands | I'm trying to create a Qt Creator plugin that uses Neovim as backend. So far so good, it was super easy thanks to the great api you guys designed. But I have a problem with shortcuts:
Qt Creator has a lot of shortcuts (seriously a lot) so some basic vim keys are overlapped by Qt Creator's shortcut. I can capture a key that's going to activate a Qt Creator shortcut and avoid the bound action to happen and send the keys to Neovim but it'd disable lots of useful shortcuts in Qt Creator like `Cmd+b` for build and lots of others. Currently I'm trying to create mappings in neovim in vim file that runs only for the plugin, these mappings map for example `Cmd+b` to an `rpcnotify` which calls the desired action in Qt Creator, something like this:
```
nnoremap <c-]> :call rpcnotify(0, 'Gui', 'triggerCommand', 'TextEditor.FollowSymbolUnderCursor')<bar>call rpcnotify(0, 'Gui', 'triggerCommand', 'TextEditor.JumpToFileUnderCursor')<cr>
inoremap <expr> <c-space> rpcnotify(0, 'Gui', 'triggerCommand', 'TextEditor.CompleteThis') ? '' : ''
```
But the problem is the list is growing so fast and it's not a good idea at all, not just cause the list is long, but also because this way users of the plugin need to update this file with changes they make in Qt Creator settings. Notice that this list can't be generated automatically cause then again some vim useful maps would get overridden.
So I thought it'd be helpful if there were a function in vim like `ismapped("<D-B>")`, then by checking it when a shortcut is pressed I can decide to pass it to Neovim or handle it in Qt Creator. This way I can implement the "default is Neovim, if Neovim doesn't map it to something then lets see if QtCreator can handle it" for keys.
So I'm suggesting the implementation of this `ismapped` function and I think it'll be useful not just for me for this plugin but many others who are trying to use neovim as a backend for another editor. | enhancement,api,complexity:high,architecture | low | Major |
298,492,040 | vscode | Setup challenges when running mocha tests | ## Goals
- Since I run tests many times, I want to run mocha tests out of the box using a keyboard shortcut or a flat command (i.e. one that doesn't require input).
- I want to navigate directly to test suites and test cases.
- I want to jump to the last failed test of the most recent test run with a keyboard shortcut.
## Getting to a keyboard shortcut
- Add a `test` script to `package.json` and install the `npm` extension. Then I can use <kbd>Cmd+R T</kbd> to run the npm test script. Somehow I have to learn that the npm extension can be helpful.
- I can try to use tasks. I need to configure tasks, need to configure the default test task, and I need to assign a keyboard shortcut to the `run test task` command. That's three big hurdles. We have a tasks menu, but that's only talking about build tasks not test tasks. Steep learning curve.
## Issue with the terminal
- In both cases (npm and tasks) the test execution happens in a terminal. The terminal is reused. When running tests I care about the failing tests. The terminal gives me link detection to where the test failed. Great. When I do this the terminal is scrolled away from its default position, i.e. the most recent line of output. Thus, when click the link and I fix the issue and re-run the tests then I don't see the output of the re-run. I need to go to the terminal and scroll to the bottom to see if the test succeeded or failed. A terminal that shows tests should scroll automatically to the bottom.
- I can assign a keyboard shortcut to focus the active terminal (there is none by default). However, in order to find the failed tests and the link to the source I use the mouse. I'd like to jump to failing tests directly with a keyboard shortcut.
## Navigation issues
- Show Document Symbols and Show Workspace Symbols are unaware of mocha test suites and test cases. I always use search to navigate to my tests.
## Issues when debugging
- The debug console does not support link detection. Thus, when I run tests in the debugger without hitting a breakpoint, I can not easily navigate the test failure. | feature-request | low | Critical |
298,516,293 | go | image/jpeg: encoding with RGB profile causing loss of image saturation | Please answer these questions before submitting your issue. Thanks!
### What version of Go are you using (`go version`)?
1.9.2
### Does this issue reproduce with the latest release?
yes
### What operating system and processor architecture are you using (`go env`)?
windows 10
### What did you do?
I encoding a JPEG file with RGB profile, some how the encoding result look like not correct, I using gimp and it compress correctly, the output result show a bit darker then the original image.
here the [code ](https://play.golang.org/p/duRhfwmMl3t) from go playground
Original image
After encode
The images diff
### What did you expect to see?
### What did you see instead?
| NeedsInvestigation | low | Major |
298,516,480 | flutter | Camera plugin should use FLT prefix for all Objective-C types | The main `CameraPlugin` type has no prefix (possibly others too). ~To make that work with Flutter tooling, an `iosPrefix` clause must be added to the `pubspec.yaml` file~:
```yaml
flutter:
plugin:
androidPackage: io.flutter.plugins.camera
iosPrefix: FLT
pluginClass: CameraPlugin
```
Edit: For current versions, the `pubspec.yaml` change is just to change `CameraPlugin` to `FLTCameraPlugin`. | platform-ios,p: camera,package,good first issue,P3,team-ios,triaged-ios | low | Minor |
298,541,834 | vscode | [theming] customize file icons in settings | <!-- Do you have a question? Please ask it on https://stackoverflow.com/questions/tagged/vscode. -->
<!-- Use Help > Report Issue to prefill these. -->
- VSCode Version: all
- OS Version: all
Can't there be a quick way to customize file extension icon instead of having to create a whole extension for a custom theme as explained here https://github.com/Microsoft/vscode/issues/10804?
It's really daunting to have to learn the whole system of extension just for this tiny need.
<!-- Launch with `code --disable-extensions` to check. -->
Does this issue occur when all extensions are disabled?: Yes/No
| feature-request,themes | medium | Critical |
298,574,679 | go | os: TestChtimes failure on OSX with Go 1.10: AccessTime didn't go backwards | Please answer these questions before submitting your issue. Thanks!
### What version of Go are you using (`go version`)?
`go version go1.10 darwin/amd64`
### Does this issue reproduce with the latest release?
Yes
### What operating system and processor architecture are you using (`go env`)?
```GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/me/Library/Caches/go-build"
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
GOPATH="/Users/me/go"
GORACE=""
GOROOT="/Users/me/opt/go"
GOTMPDIR=""
GOTOOLDIR="/Users/me/opt/go/pkg/tool/darwin_amd64"
GCCGO="gccgo"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/cf/y_tt0zms6nx39x08k23y5zsr0000gn/T/go-build648291915=/tmp/go-build -gno-record-gcc-switches -fno-common"
```
### What did you do?
`$ GOROOT_BOOTSTRAP=~/opt/go-bootstrap ./all.bash`
### What did you expect to see?
(tests pass)
### What did you see instead?
```
--- FAIL: TestChtimes (0.00s)
os_test.go:1200: AccessTime didn't go backwards; was=2018-02-20 14:13:29.321904999 +0200 EET, after=2018-02-20 14:13:29.322166175 +0200 EET
FAIL
FAIL os 0.759s
```
| help wanted,OS-Darwin,NeedsInvestigation | low | Critical |
298,578,695 | TypeScript | Tagged union types aren't narrowed in for/while loop | **TypeScript Version:** 2.7.0-dev.20180220
<!-- Search terms you tried before logging this (so others can find this issue more easily) -->
**Search Terms:**
**Code**
```ts
const enum Types {
Array,
Node,
}
declare const obj:
| { type: Types.Array, value: never[], }
| { type: Types.Node, value: {}, };
for (; ;) {
switch (obj.type) {
case Types.Node:
void obj.value;
break;
case Types.Array:
void obj.value.push;
break;
}
}
```
These work correctly.
```ts
const enum Types {
Array,
Node,
}
declare const obj:
| { type: Types.Array, value: never[], }
| { type: Types.Node, value: {}, };
for (; ;) {
switch (obj.type) {
case Types.Node:
void obj.value;
break;
case Types.Array:
void obj.value.push;
break;
}
}
```
```ts
const enum Types {
Array,
Node,
}
declare const obj:
| { type: Types.Array, value: never[], }
| { type: Types.Node, value: {}, };
switch (obj.type) {
case Types.Node:
void obj.value;
break;
case Types.Array:
void obj.value.push;
break;
}
```
**Expected behavior:**
pass
**Actual behavior:**
`obj.value` type in the second case-clause is `{}` but popup type info is `never[]`.
**Playground Link:** <!-- A link to a TypeScript Playground "Share" link which demonstrates this behavior -->
**Related Issues:**
| Bug | low | Minor |
298,613,540 | rust | Slower performance caused only by using LTO | [The Computer Language Benchmarks Game](https://benchmarksgame.alioth.debian.org/) was on the Rust subreddit recently and while I checked out the numbers for Rust, I noticed that the Rust solution for the [fasta benchmark](https://benchmarksgame.alioth.debian.org/u64q/fasta.html) is much slower than the C version, although they work fairly similarly, the multithreading in the C version is based on the Rust version. It turned out that the Rust benchmarks are compiled with LTO by default, and when I tested the code on my machine without LTO (both stable and nightly), it was almost as fast as the C version. I tried to find an existing issue, but most of them are about slow compilation, not slow runtime.
The interesting thing is that on the CPU monitor graph it's clearly visible that during the last part of the benchmark all CPU cores are only on 70% usage (so it's like a mutex is locked for too long). I also checked the binary size, it went down from 4.4 MB to 3.1 MB with LTO.
EDIT: I also tested it with the Mutex from `parking_lot`, it's still slow with LTO, but without it's a tiny bit faster than the C version. | I-slow,C-enhancement,T-compiler | low | Major |
298,629,823 | godot | Pressing any accent before Escape makes Escape fire two "pressed" events | **Godot version:**
tested in 3.0 stable and 2.1.4 stable
**OS/device including version:**
Windows 10 64bit (desktop build), including Fall Creators' Update
**Issue description:**
While listening for input, when you press the Circumflex accent before pressing Escape, you'll get two key press events for the Escape key, both as InputEvents and as Actions.
Pressing other keys like Space or A after Circumflex does not exhibit that behaviour.
This is a mild inconvenience on German keyboards and possibly others, where the Circumflex key is located below Escape (sometimes directly, like on this here Laptop).
Also happens with other accent keys like accent acute or accent grave (the tick / backtick characters), although these are in a different spot so it's less easy to fat-finger them.
Debug print from Godot 2:
> Circumflex + ESC
> Device 0 ID 722 Event: Key Unicode: Scan: 92 Echo: False PressedTrue Mod:
> Device 0 ID 723 Event: Key Unicode: Scan: 92 Echo: False PressedFalse Mod:
> Device 0 ID 726 Event: Key Unicode: ^ Scan: 16777217 Echo: False PressedTrue Mod:
> Device 0 ID 727 Event: Key Unicode: Scan: 16777217 Echo: False PressedTrue Mod:
> Device 0 ID 728 Event: Key Unicode: Scan: 16777217 Echo: False PressedFalse Mod:
>
> Circumflex + A:
> Device 0 ID 774 Event: Key Unicode: Scan: 92 Echo: False PressedTrue Mod:
> Device 0 ID 775 Event: Key Unicode: Scan: 92 Echo: False PressedFalse Mod:
> Device 0 ID 777 Event: Key Unicode: Γ’ Scan: 65 Echo: False PressedTrue Mod:
> Device 0 ID 778 Event: Key Unicode: Scan: 65 Echo: False PressedFalse Mod:
The attached minimal project shows the behaviour in Godot 3 using var2str on the event; circumflex produces 2 events, the Escape key again produces 3.
The workaround on my end will be to discard Escape key events with the Circumflex char in their unicode property, will have to see if using actions still remains functional or if I'll have to rely on InputEventKey.
**Steps to reproduce:**
- any Node must have an _input(event) function
- with the default keybindings, Escape is bound to the action "ui_cancel"
- have _input react to either event.is_action_pressed("ui_cancel") or check for InputEventKey and the correct Scancode, then for example print anything to the console
- press circumflex, then escape
- the print will happen twice; if you print the key events, you'll get 2 for the accent and 3 for escape
**Minimal reproduction project:**
[Circumflex.zip](https://github.com/godotengine/godot/files/1740551/Circumflex.zip)
| bug,platform:windows,confirmed,topic:input | low | Critical |
298,696,649 | vscode | When A grammar injects to B, grammars embedding B should get A's injection | A real world example: https://github.com/vuejs/vetur/issues/701
GraphQL is injecting to `source.js`.
Vetur is embedding `source.js`.
However the Vue grammar is not getting any injections from GraphQL. | feature-request,grammar | low | Major |
298,704,087 | go | cmd/compile: use runtime.zeroVal for small zero-valued readonly static vars | Split out from #23929. No reason to have lots of different zero-valued readonly symbols when we can re-use runtime.zeroVal.
| Performance,compiler/runtime | low | Major |
298,704,722 | TypeScript | this any typed in some JS object literals | From https://github.com/Microsoft/vscode/issues/43930
**TypeScript Version:** 2.8.0.insiders-20180211
<!-- Search terms you tried before logging this (so others can find this issue more easily) -->
**Search Terms:**
- this
- object literal
**Code**
For the js:
```js
console.log({
a: 1,
b() {
this
}
});
```
Hover over `this` in `b`
**Bug**
`this` has `any` type
`this` is properly typed in cases like:
```js
const z = {
a: 1,
b() {
this
}
}
```
**Playground Link:** <!-- A link to a TypeScript Playground "Share" link which demonstrates this behavior -->
**Related Issues:**
- https://github.com/Microsoft/TypeScript/issues/11072 | Bug,VS Code Tracked,Domain: JavaScript,Has Repro | low | Critical |
298,727,221 | TypeScript | Suggestion: Type annotations and interfaces for function declarations | Currently in TypeScript, function declarations cannot be typed in the same way as function expressions, e.g. this function can implement the `React.FC` interface:
interface TestProps {
message: string
}
const Test: React.FC<TestProps> = ({ message }) => {
return <div>{message}</div>
}
But this function can't, at least not directly:
function Test({ message }: TestProps) {
return <div>{message}</div>
}
This becomes more of an issue if you try to add properties to the function object:
Test.defaultProps = {
message: 'hi'
}
It seems that currently the only way to specify the type for the function object in the second example is to create a new variable:
const AliasForTest: React.FC<TestProps> = Test
AliasForTest.defaultProps = {
message: 'hi'
}
This seems like kind of an ugly workaround, so it seems that the current idiom is to just prefer arrow functions for cases like this. But this leads to inconsistency on teams that generally prefer function declarations over const expressions for top-level functions. Personally I find it more readable to see the word "function" for top-level functions rather than seeing "const", which is generally already all over the place in the code. There is even an ESLint rule for teams that share my preference (although I don't think it's been ported to TSLint yet): https://eslint.org/docs/rules/func-style. In any case, I have seen others express similar views and other codebases (including some from Facebook and Apollo, for example) that still prefer the "function" keyword for top-level functions.
However, stylistically it's also a problem if top-level functions are declared some places as declarations (using `function`) and in other places as expressions (using `const`). But for those who desire consistency, TypeScript is basically forcing the use of expressions, due to the issues described above.
This is far from being a top priority of course, but I was surprised to see that TypeScript didn't provide some equivalent typing syntax for function declarations. It would be great if this could be considered for a future version (even if far in the future). Thanks for reading! | Suggestion,In Discussion,Has Repro | high | Critical |
298,746,577 | rust | rustdoc: Strip empty line(s) above and/or below hidden code in Rust code blocks | Consider the following code:
```rs
//! Top-level documentation.
//!
//! ```rust
//! // ... some Rust code ...
//!
//! # // ... hidden boilerplate-y Rust code ...
//!
//! // ... some Rust code ...
//! ```
```
Currently (last checked: 2024), rustdoc renders two empty lines in between the first & the last comment (quite reasonably so). However, it might be nice to essentially collapse them into a single line since the author likely didn't intend to have extra lines in the rendered output but only in the *source code* for legibility (since there the `#`-prefixed code is obviously visible).
The "workaround" / user fix for this is to manually hide the "blank" lines with `#`:
```rs
//! Top-level documentation.
//!
//! ```rust
//! // ... some Rust code ...
//! #
//! # // ... hidden boilerplate-y Rust code ...
//!
//! // ... some Rust code ...
//! ```
```
An argument could be made that this is less "esthetically pleasing" and a bit annoying.
<details><summary>Original issue description from 2018 for context</summary>
Basically, I want:
```text
rust code
# secret boilerplatey rust code
more rust code
```
to render the same as:
```text
rust code
#
# secret boilerplatey rust code
more rust code
```
</details> | T-rustdoc,C-feature-request,A-rustdoc-ui,T-rustdoc-frontend | low | Minor |
298,774,749 | go | x/build/cmd/gerritbot: Gerrit Bot should not be the owner of all imported changes | Gerrit bug: https://bugs.chromium.org/p/gerrit/issues/detail?id=8296 | Builders,NeedsFix | low | Critical |
298,782,956 | godot | C# CallDeferred() won't take function names in pascal case | **Godot version:**
3.0
**Issue description:**
<!-- What happened, and what was expected. -->
CallDeferred doesn't accept the pascal case method name in C#.
While using C# scripting you must pass in the 'snake case' function name same as GDScript.
I think that this causes confusion when all other names are changed to pascal case in C#.
It caused me quite a bit of confusion. Perhaps if it is not an issue changing the function could throw an error if the function name passed in is not recognized?
**Steps to reproduce:**
call CallDeferred and pass in a function name in pascal case e.g. "AddChild" and watch it not work.
| enhancement,topic:dotnet | medium | Critical |
298,794,034 | flutter | FadeInImage support for crossfading between images | Right now it is only possible to have a FadeInImage fade out to white and then fade in to the desired loaded image. It would be great if I can just crossfade between them if I wanted to.
https://material.io/guidelines/patterns/loading-images.html#loading-images-usage
Material guidelines state that the images can also transition. | c: new feature,framework,a: animation,P3,team-framework,triaged-framework | medium | Major |
298,846,822 | pytorch | TestMultiprocessing.test_fd_sharing hangs with ASAN | Sample build https://ci.pytorch.org/jenkins/job/pytorch-builds/job/pytorch-linux-xenial-cuda9-cudnn7-py3-test/3486/console
cc @mruberry @VitalyFedyunin | module: tests,triaged | low | Minor |
298,855,261 | neovim | API: Ability to set the size of the editable area | How can a client set a Neovim's instance editable area to 80 columns and 40 rows excluding the sign column, numbers column, etc?
In the process of developing the Qt Creator client I need to set Neovim's editable area as exact same size as of Qt Creator's editable area. Qt Creator has its own number/sign/fold column and its size is not to be the same as Neovim's. I need to set the size of the editable area in order to make `wrap`ing lines work the same in Neovim and QtCreator (aka `gj` and `gk` work correctly.)
I couldn't find a way to set this size, I even asked it here: https://vi.stackexchange.com/questions/15269/how-to-set-get-size-of-editable-area-in-a-neovim-client
How can I achieve this? | enhancement,api,ui,ui-extensibility | low | Major |
298,930,570 | vue | extended components fall back to global component definition. (instead of local one in "super/parent") | ### Version
2.5.13
### Reproduction link
[https://codepen.io/dasdeck/pen/NyMvjQ](https://codepen.io/dasdeck/pen/NyMvjQ)
### Steps to reproduce
The codepen shows the bug on opening.
### What is expected?
I'd expect "extComp" to behave exactly like "baseComp" since it is extended.
### What is actually happening?
"extComp" uses the global "my-comp" definition instead of the one in the super/parent component
---
This might be expected/intended behavior, however, all people I asked agree that this is counter intuitive and feels more like a bug than a feature.
Cheer!
JM
<!-- generated by vue-issues. DO NOT REMOVE --> | improvement | medium | Critical |
298,978,507 | flutter | Navigator forces expand size constraint. | I found that I wanted to use the a Step like UX where the user can proceed through a series of steps. The back button on Android should take them to the previous step. This should appear in a dialog.
I found when you use a `Navigator` it forces the contents to max constraints, which means the dialog must fill the screen. I feel that Navigator is a almost has a "Semantic" meaning that it controls the routes and history back stack, and its parent should constrain where the stack/transitions occur. I believe it is a bug for the constraint resolution to come from the `Navigator`.
From what I can tell with the Flutter Inspector the root cause is that `Navigator` returns an `Overlay` widget that contains a `Stack` with `fit: StackFit.expand`.
I've included a small example below for testing. I'm not setup to build the engine repo, or I would have tested my supposition above. It would be great to get some feedback if this is the problem, and if an optional fit parameter put on Navigator/Overlay so its not forced.
@Hixie I assume you want to know about this for your Navigator work.
## Steps to Reproduce
**Example Code**
```dart
import 'package:flutter/material.dart';
void main() => runApp(new MainWidget());
class MainWidget extends StatelessWidget {
@override
Widget build(BuildContext context) {
return new MaterialApp(
home: new Scaffold(
backgroundColor: Colors.lightBlue,
body: new AlertDialog(
title: const Text('Help'),
content: new Navigator(
initialRoute: 'step:1',
onGenerateRoute: _onGenerateRoute,
),
),
),
);
}
Route<dynamic> _onGenerateRoute(RouteSettings settings) {
var parts = settings.name.split(':');
return new PageRouteBuilder(
pageBuilder: (_, __, ___) => new StepWidget(int.parse(parts[1], radix: 10)),
transitionsBuilder: (BuildContext _, Animation<double> animation, Animation<double> secondary, Widget child) {
child = new SlideTransition(
position: new Tween<Offset>(
begin: Offset.zero,
end: const Offset(-1.0, 0.0),
).animate(secondary),
child: child,
);
child = new SlideTransition(
position: new Tween<Offset>(
begin: const Offset(1.0, 0.0),
end: Offset.zero,
).animate(animation),
child: child,
);
return child;
}
);
}
}
class StepWidget extends StatelessWidget {
final int step;
StepWidget(this.step);
@override
Widget build(BuildContext context) {
return new Column(
mainAxisSize: MainAxisSize.min,
children: <Widget>[
new Container(
padding: const EdgeInsets.all(48.0),
child: new Text('Step $step'),
),
new Row(
mainAxisSize: MainAxisSize.max,
children: <Widget>[
new Expanded(
child: new FlatButton(
child: const Text('Prev'),
onPressed: () => Navigator.of(context).maybePop(),
),
),
new Expanded(
child: new FlatButton(
child: const Text('Next'),
onPressed: () => Navigator.of(context).pushNamed('step:${step + 1}'),
),
),
],
),
],
);
}
}
```
## Flutter Doctor
```
β] Flutter (on Microsoft Windows [Version 10.0.14393], locale en-GB, channel master)
β’ Flutter version 0.1.1-pre.33 at C:\Android\flutter
β’ Framework revision d401bd78ae (8 days ago), 2018-02-13 01:56:13 -0800
β’ Engine revision f5a4a93787
β’ Tools Dart version 2.0.0-dev.22.0
β’ Engine Dart version 2.0.0-edge.32396138ff733cbe8d9ac32178e6cffccdf80644
[β] Android toolchain - develop for Android devices (Android SDK 27.0.3)
β’ Android SDK at C:\Android\SDK
β’ Android NDK at C:\Android\SDK\ndk-bundle
β’ Platform android-27, build-tools 27.0.3
β’ ANDROID_HOME = C:\Android\SDK
β’ Java binary at: C:\Android\Studio\jre\bin\java
β’ Java version OpenJDK Runtime Environment (build 1.8.0_152-release-915-b01)
[β] Android Studio (version 3.0)
β’ Android Studio at C:\Android\Studio
β’ Java version OpenJDK Runtime Environment (build 1.8.0_152-release-915-b01)
[β] IntelliJ IDEA Community Edition (version 2017.3)
β’ Flutter plugin version 21.2.3
β’ Dart plugin version 173.4548.30
[β] Connected devices
β’ Google Nexus 5X, 7 1 0, API 25, 1080x1920 β’ 192.168.188.101:5555 β’ android-x86 β’ Android 7.1.1 (API 25)
β’ No issues found!
```
| framework,f: routes,P2,team-framework,triaged-framework | low | Critical |
299,005,238 | vscode | [json] schema fileMatch for all *.json files in root folder | - VSCode Version: 1.20.1
- OS Version: Win 10
Does this issue occur when all extensions are disabled?: Yes
I've tried asking this on stackoverflow and gitter without success. I have a project with (among other things) lots of .json files. This is the `.vscode/settings.json` file:
``` json
{
"json.schemas": [
{
"fileMatch": [
"*.json"
],
"url": "https://path/to/schema.json"
}
]
}
```
The problem is that this matches all .json files in the project, but I need it to match **only \*.json files in the root directory**. What can I put in `fileMatch` to enable this, or can this not be done with the file matching? | help wanted,feature-request,json | low | Major |
299,016,433 | kubernetes | kubectl cp fails on large files | <!-- This form is for bug reports and feature requests ONLY!
If you're looking for help check [Stack Overflow](https://stackoverflow.com/questions/tagged/kubernetes) and the [troubleshooting guide](https://kubernetes.io/docs/tasks/debug-application-cluster/troubleshooting/).
-->
**Is this a BUG REPORT or FEATURE REQUEST?**:
/kind bug
**What happened**:
Copying either a large file, or a large directory from a container via `kubectl cp` results in the error of `error: unexpected EOF` and a failure to transfer. In my case, the file is 1.7G.
I executed the following command
```bash
kubectl cp infra-cassandra-global-0:cassandra.tar.gz infra-cassandra-global-0-cassandra.tar.gz
```
The command executes, however the terminal will print the error below after 10-14 seconds of execution, and no file is copied.
```bash
error: unexpected EOF
```
**What you expected to happen**:
The large file to be downloaded from the container.
**How to reproduce it (as minimally and precisely as possible)**:
Add a large file >= 1.7G to any location in the pod. I was able to re-create this will the file on a PV, or locally on the image file system.
Execute `kubectl cp` to download the large file. It will fail.
**Anything else we need to know?**:
**Environment**:
- Kubernetes version (use `kubectl version`): v1.8.6, client v1.8.5
- Cloud provider or hardware configuration: AWS
- OS (e.g. from /etc/os-release): k8s-1.8-debian-jessie-amd64-hvm-ebs-2017-12-02 (ami-06a57e7e)
- Kernel (e.g. `uname -a`):
- Install tools: Kops
- Others:
| kind/bug,sig/node,sig/cli,triage/accepted | high | Critical |
299,024,155 | three.js | VTKLoader: Add support for more dataset format | I would like to ask for advice because of I have one use case where I need to load VTK file which is a BINARY DATASET STRUCTURED POINTS, which represents a segmented image.
```
# vtk DataFile Version 3.0
VTK File Generated by Insight Segmentation and Registration Toolkit (ITK)
BINARY
DATASET STRUCTURED_POINTS
DIMENSIONS 1040 1040 1
SPACING 2.6455026988983699e-01 2.6455026988983699e-01 1.0000000000000000e+00
ORIGIN 0.0000000000000000e+00 0.0000000000000000e+00 0.0000000000000000e+00
POINT_DATA 1081600
SCALARS scalars unsigned_short 1
LOOKUP_TABLE default
Binary data
```
Thank you for your help. | Enhancement,Loaders | low | Major |
299,034,240 | rust | parser: modulesubpath defined with path macro needs to replace pathseperator to the default pathseperator | When trying out rustfmt on windows I got an error on my code that compiles. I have defined cross platform modules as such:
```
#[cfg(target_os = "linux")]
#[path = "proxyimpl/linux.rs"]
pub mod proxyimpl;
#[cfg(not(target_os = "linux"))]
#[path = "proxyimpl/nonlinux.rs"]
pub mod proxyimpl;
```
When running rustfmt on windows I get the following error
```
rustfmt .\main.rs
error: couldn't read "\\\\?\\C:\\Users\\<snip>\\Source\\irondragon\\src\\gpioaccess\\proxyimpl/linux.rs": The filename, directory name, or volume label syntax is incorrect. (os error 123)
--> \\?\C:\Users\<snip>\Source\irondragon\src\gpioaccess\mod.rs:68:9
|
68 | pub mod proxyimpl;
| ^^^^^^^^^
thread 'main' panicked at 'Box<Any>', src\libsyntax\parse\mod.rs:215:29
stack backtrace:
0: <std::sync::condvar::WaitTimeoutResult as core::fmt::Debug>::fmt
1: <std::time::SystemTimeError as core::fmt::Display>::fmt
2: std::panicking::Location::column
3: std::panicking::Location::column
4: std::panicking::rust_panic_with_hook
5: <syntax::ext::tt::macro_rules::TokenSet as core::fmt::Debug>::fmt
6: syntax::parse::new_parser_from_tts
7: syntax::parse::parser::Parser::default_submod_path
8: syntax::parse::parser::Parser::parse_item
9: syntax::parse::parser::Parser::parse_visibility
10: syntax::parse::parser::Parser::default_submod_path
11: syntax::parse::parser::Parser::parse_item
12: syntax::parse::parser::Parser::parse_visibility
13: syntax::parse::parser::Parser::parse_crate_mod
14: <unknown>
15: <unknown>
16: <unknown>
17: <unknown>
18: <unknown>
19: std::panicking::update_panic_count
20: _rust_maybe_catch_panic
21: std::rt::lang_start_internal
22: <unknown>
23: <unknown>
24: BaseThreadInitThunk
```
Changing it to
```
#[cfg(target_os = "linux")]
#[path = "proxyimpl\\linux.rs"]
pub mod proxyimpl;
#[cfg(not(target_os = "linux"))]
#[path = "proxyimpl\\nonlinux.rs"]
pub mod proxyimpl;
```
I can run rustfmt on windows, but my travisci build (linux) fails.
| C-enhancement,A-diagnostics,A-parser,T-compiler | low | Critical |
299,123,867 | go | x/build: run ssacheck mode for all architectures, not just amd64 | We have an amd64 ssacheck builder. That builder should compile std+cmd for all architectures, not just native. That would have prevented or at least caught #24014. | help wanted,Builders | low | Minor |
299,191,550 | kubernetes | Add local PV e2e block test for GCE local SSD | <!-- This form is for bug reports and feature requests ONLY!
If you're looking for help check [Stack Overflow](https://stackoverflow.com/questions/tagged/kubernetes) and the [troubleshooting guide](https://kubernetes.io/docs/tasks/debug-application-cluster/troubleshooting/).
-->
**Is this a BUG REPORT or FEATURE REQUEST?**:
/kind feature
/sig storage
/assign
**What happened**:
Once #60137 merges, add local SSD block as another type | sig/storage,kind/feature,lifecycle/frozen | low | Critical |
299,232,288 | youtube-dl | Site support request: FOXplay.fi | ### Make sure you are using the *latest* version:
- [x] I've **verified** and **I assure** that I'm running youtube-dl **2018.02.11**
### Before submitting an *issue* make sure you have:
- [x] At least skimmed through the [README](https://github.com/rg3/youtube-dl/blob/master/README.md), **most notably** the [FAQ](https://github.com/rg3/youtube-dl#faq) and [BUGS](https://github.com/rg3/youtube-dl#bugs) sections
- [x] [Searched](https://github.com/rg3/youtube-dl/search?type=Issues) the bugtracker for similar issues including closed ones
- [x] Checked that provided video/audio/playlist URLs (if any) are alive and playable in a browser
### What is the purpose of your *issue*?
- [ ] Bug report (encountered problems with youtube-dl)
- [x] Site support request (request for adding support for a new site)
- [ ] Feature request (request for a new functionality)
- [ ] Question
- [ ] Other
---
### If the purpose of this *issue* is a *bug report*, *site support request* or you are not completely sure provide the full verbose output as follows:
Add the `-v` flag to **your command line** you run youtube-dl with (`youtube-dl -v <your command line>`), copy the **whole** output and insert it here. It should look similar to one below (replace it with **your** log inserted between triple ```):
```
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['https://www.foxplay.fi/sarjat/huutokaupan-metsaestaejaet-suomi/jaksot/jakso-6', '-v']
[debug] Encodings: locale UTF-8, fs utf-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2018.02.11
[debug] Python version 3.6.4 (CPython) - Linux-4.15.3-2-ARCH-x86_64-with-arch
[debug] exe versions: ffmpeg 3.4.2, ffprobe 3.4.2, rtmpdump 2.4
[debug] Proxy map: {}
[generic] jakso-6: Requesting header
WARNING: Falling back on generic information extractor.
[generic] jakso-6: Downloading webpage
[generic] jakso-6: Extracting information
ERROR: Unsupported URL: https://www.foxplay.fi/sarjat/huutokaupan-metsaestaejaet-suomi/jaksot/jakso-6
Traceback (most recent call last):
File "/usr/lib/python3.6/site-packages/youtube_dl/YoutubeDL.py", line 785, in extract_info
ie_result = ie.extract(url)
File "/usr/lib/python3.6/site-packages/youtube_dl/extractor/common.py", line 440, in extract
ie_result = self._real_extract(url)
File "/usr/lib/python3.6/site-packages/youtube_dl/extractor/generic.py", line 3111, in _real_extract
raise UnsupportedError(url)
youtube_dl.utils.UnsupportedError: Unsupported URL: https://www.foxplay.fi/sarjat/huutokaupan-metsaestaejaet-suomi/jaksot/jakso-6
```
---
### If the purpose of this *issue* is a *site support request* please provide all kinds of example URLs support for which should be included (replace following example URLs by **yours**):
- Single video: https://www.foxplay.fi/sarjat/huutokaupan-metsaestaejaet-suomi/jaksot/jakso-6
- Single video: https://kids.foxplay.fi/sarjat/teletapit/jaksot/vanukaskaaos-pisin-ja-lyhyin
---
### Description of your *issue*, suggested solution and other information
I would like youtube-dl to support www.foxplay.fi. No registration needed. | geo-restricted | low | Critical |
299,251,418 | rust | Misleading diagnostics for method call | The following (reduced example) code leads to a misleading error message:
```rust
trait IsARectangle<T> {}
struct GeneralRectangle<T>
{
x: T
}
impl<T> IsARectangle<T> for GeneralRectangle<T> {}
impl<U> GeneralRectangle<U> where U: std::ops::Add<Output = U>
{
fn from<T, R>(_: &R) -> Result<GeneralRectangle<U>, ()>
where
R: IsARectangle<T>,
{
unimplemented!()
}
}
fn box_to_pixel<T, S>( (_, _): (S, S)) -> Result<GeneralRectangle<T>, ()>
// if you enable the following line, it will work:
//where T: std::ops::Add<Output = T>
{
GeneralRectangle::<T>::from::<u32, GeneralRectangle<u32>>(&GeneralRectangle::<u32> {
x: 0,
})
}
fn main() {
box_to_pixel::<u32, u32>( (0, 0) );
}
```
The problem is that the `where`-clause for `box_to_pixel` is missing (it works if it is added), but the compiler instead reports:
```
error[E0087]: too many type parameters provided: expected at most 0 type parameters, found 2 type parameters
--> src\main.rs:22:39
|
22 | GeneralRectangle::<T>::from::<u32, GeneralRectangle<u32>>(&GeneralRectangle::<u32> {
| ^^^ expected 0 type parameters
error[E0277]: the trait bound `std::result::Result<GeneralRectangle<T>, ()>: std::convert::From<&GeneralRectangle<u32>>` is not satisfied
--> src\main.rs:22:9
|
22 | GeneralRectangle::<T>::from::<u32, GeneralRectangle<u32>>(&GeneralRectangle::<u32> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the trait `std::convert::From<&GeneralRectangle<u32>>` is not implemented for `std::result::Result<GeneralRectangle<T>, ()>`
|
= note: required by `std::convert::From::from`
```
As a Rust beginner, who might have not yet heard about `std::convert::From::from`, I would now be really confused, because the `from` method exists (in my code!), and it does expect 2 type parameters, not 0.
The error message is better if the `where U: std::ops::Add<Output = U>` is moved from the `impl` block to the `fn from`, so I do understand what the compiler does here (it probably totally disregards the whole `impl` block because its `where` clause is not satisfied), but maybe the situation can be improved anyway?
| C-enhancement,A-diagnostics,T-compiler | low | Critical |
299,312,985 | opencv | fisheye::estimateNewCameraMatrixForUndistrortRectify computes unfeasible new cam matrix |
##### System information (version)
<!-- Example
- OpenCV => 3.1
- Operating System / Platform => Windows 64 Bit
- Compiler => Visual Studio 2015
-->
- OpenCV => : 3.4
- Operating System / Platform => Linux Mint 18.1
- Compiler => gcc 5.4
##### Detailed description
fisheye::estimateNewCameraMatrixForUndistortRectify() estimates a unfeasible new camera matrix.
newCamMat =
[16.56655127068949, 0, 804.0577455220744;
0, 16.56435955242479, 795.9641361656702;
0, 0, 1]
with old cameraMatrix K=
[479.8212553715528, 0, 804.0575648361054;
0, 479.757776075711, 795.958873881724;
0, 0, 1]
##### Steps to reproduce
Calling fisheye::estimateNewCameraMatrixForUndistortRectify() with:
Mat newCamMat, map1, map2;
K =
[479.8212553715528, 0, 804.0575648361054;
0, 479.757776075711, 795.958873881724;
0, 0, 1]
imageSize = (1668,1668)
distCoeffs = [0.01280820642470711;
0.002218423317829948;
-0.002689326073929679;
0.0002362784535736659]
such that the call is
fisheye::estimateNewCameraMatrixForUndistrortRectify(K, distCoeffs, imageSize, Matx33d::eye(), newCamMat, 1.0)
<!-- to add code example fence it with triple backticks and optional file extension
```.cpp
// C++ code example
```
or attach as .txt or .zip file
--> | category: calib3d | low | Minor |
299,461,783 | pytorch | Bugs: Score Function approach in REINFORCE for PONG | I adapted the reinforce and actor-critic code for Cartpole to PONG. The original Cartpole code is located in:
https://github.com/pytorch/examples/blob/master/reinforcement_learning/reinforce.py
In the Cartpole example, the input to the policy NN is the state outputted by OpenAI, which is an array of 4 float. In PONG, the input is a downsampled image vector of 1600 (40x40) or 6400 (80x80). When using the reinforce.py as the guideline and using the score function approach described in Pytorch.org documentation (http://pytorch.org/docs/master/distributions.html), I encountered 2 bugs:
(1) GPU Memory Error
The exact error is:
RuntimeError: cuda runtime error (2) : out of memory at /opt/conda/conda-bld/pytorch_1512386481460/work/torch/lib/THC/generic/THCStorage.cu:58
The REINFORCE implementation requires the policy NN to run forward pass 1000-1500 times depending on how many game steps it takes for 21 points to be reached. Running "nvidia-smi l 1", I discover that GPU memory is not released on the Nvidia card even after the program exit.
I have to do 2 things to get the code to run:
- Add torch.cuda.empty_cache() at the end of each episode
- Limit the forward passes to a fixed batch size (e.g. 800-1200) instead of letting the code run until a flag (done) is True
The typical workflow for policy-based RL is 1000-10000 forward pass, and then 1 single backward pass utilizing stacked intermediary data such as hidden units, states, rewards, log_prob and so on. Either Torch or the underlying CUDA has memory management problem with this kind of workflow.
(2) Underperformance of the trained RL agent
I have run the REINFORCE agent to 30K episodes and it is not learning as well as the original REINFORCE implemented by Andrej Karpathy using numpy.
Details of my experimentation is detailed in:
https://github.com/LUKELIEM/deep_rl/blob/master/gym/reinforce.ipynb
There is 1 major difference between my code and Karpathy's py-pong.py:
- Karpathy implements the backprop directly
- His code accumulates the intermediary states (epx), hidden states (eph), rewards (epr) and log_prob (eplogd) during the forward pass
- At the single backpass after 1000-1500 forward passes, the backprop is implemented by matrix multiplication of these stacked intermediary values to produce a gradient
- The code then uses RMSprop to update the weights directly.
- Pytorch's code implements backprop using policy_loss.backward() through this code fragment:
probs = policy(Variable(state))
m = Categorical(probs)
action = m.sample()
policy.saved_log_probs.append(m.log_prob(action))
I have tried various update rules and they all seem incapable to learning beyond running reward of 0.
- OS: Ubuntu 16.04
- PyTorch version: 0.3.0
- How you installed PyTorch (conda, pip, source): conda
- Python version: 3.6.4
- CUDA/cuDNN version:
- GPU models and configuration: ASUS ROG STRIX GeForce GTX 1080 TI 11GB VR Ready 5K HD Gaming Graphics Card
- GCC version (if compiling from source):
| todo,module: crash,module: loss,module: cuda,module: memory usage,triaged | low | Critical |
299,468,933 | go | gccgo: TestShared/tsan_shared fails with GCC 5.5.0 | Please answer these questions before submitting your issue. Thanks!
### What version of Go are you using (`go version`)?
Go 1.10
### Does this issue reproduce with the latest release?
Yes
### What operating system and processor architecture are you using (`go env`)?
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/leo/.cache/go-build"
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/home/leo/go"
GORACE=""
GOROOT="/gnu/store/h4gwja8863p3jhkav8ja7s710acckzy1-go-1.10"
GOTMPDIR=""
GOTOOLDIR="/gnu/store/h4gwja8863p3jhkav8ja7s710acckzy1-go-1.10/pkg/tool/linux_amd64"
GCCGO="gccgo"
CC="/gnu/store/cfdn69spjc44x4sd0acrwhxq6yay3rbc-gcc-5.5.0/bin/gcc"
CXX="g++"
CGO_ENABLED="1"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build244943669=/tmp/go-build -gno-record-gcc-switches"
### What did you do?
I am testing the update of Go from 1.9.4 to 1.10 in GNU Guix. We bootstrap from Go 1.4.3 using GCC 5.5.0. I invoke the build with `sh all.bash`.
### What did you expect to see?
A successful compilation and test of Go 1.10, as with Go 1.9.4.
### What did you see instead?
There is a test failure. If I understand correctly, GCC 5.5.0's ThreadSanitizer finds a race. When I rebuild Go 1.4.3 with GCC 6.4.0, and build Go 1.10 using that bootstrap Go and version of GCC, the race is not detected. The test fails consistently with GCC 5.5.0.
```
##### ../misc/cgo/testsanitizers
--- FAIL: TestShared (0.03s)
--- FAIL: TestShared/tsan_shared (2.54s)
cshared_test.go:71: `/tmp/guix-build-go-1.10.drv-0/TestShared367937240/tsan_shared` exited with exit status 66
==================
WARNING: ThreadSanitizer: data race (pid=28778)
Write of size 8 at 0x7ffff5495c30 by thread T1:
#0 pthread_attr_getstacksize <null> (tsan_shared+0x00000041be82)
#1 x_cgo_init <null> (libtsan_shared.so+0x00000008aeaf)
#2 runtime.rt0_go /tmp/guix-build-go-1.10.drv-0/go/src/runtime/asm_amd64.s:199 (libtsan_shared.so+0x000000081586)
Previous write of size 8 at 0x7ffff5495c30 by main thread:
#0 <null> <null> (0x000000000001)
Location is stack of thread T1.
Thread T1 (tid=28786, running) created by main thread at:
#0 pthread_create <null> (tsan_shared+0x00000040c794)
#1 _cgo_try_pthread_create <null> (libtsan_shared.so+0x00000008ad70)
#2 x_cgo_sys_thread_create <null> (libtsan_shared.so+0x00000008ab12)
#3 _rt0_amd64_lib /tmp/guix-build-go-1.10.drv-0/go/src/runtime/asm_amd64.s:56 (libtsan_shared.so+0x0000000813b6)
SUMMARY: ThreadSanitizer: data race ??:0 __interceptor_pthread_attr_getstacksize
==================
==================
WARNING: ThreadSanitizer: data race (pid=28778)
Read of size 8 at 0x7d080000dfe0 by thread T2:
#0 threadentry <null> (libtsan_shared.so+0x00000008b0d2)
Previous write of size 8 at 0x7d080000dfe0 by thread T1:
#0 malloc <null> (tsan_shared+0x00000040aba3)
#1 x_cgo_thread_start <null> (libtsan_shared.so+0x00000008b730)
#2 runtime.asmcgocall /tmp/guix-build-go-1.10.drv-0/go/src/runtime/asm_amd64.s:718 (libtsan_shared.so+0x000000082fc6)
Location is heap block of size 24 at 0x7d080000dfe0 allocated by thread T1:
#0 malloc <null> (tsan_shared+0x00000040aba3)
#1 x_cgo_thread_start <null> (libtsan_shared.so+0x00000008b730)
#2 runtime.asmcgocall /tmp/guix-build-go-1.10.drv-0/go/src/runtime/asm_amd64.s:718 (libtsan_shared.so+0x000000082fc6)
Thread T2 (tid=28791, running) created by thread T1 at:
#0 pthread_create <null> (tsan_shared+0x00000040c794)
#1 _cgo_try_pthread_create <null> (libtsan_shared.so+0x00000008ad70)
#2 _cgo_sys_thread_start <null> (libtsan_shared.so+0x00000008b011)
#3 x_cgo_thread_start <null> (libtsan_shared.so+0x00000008b7be)
#4 runtime.asmcgocall /tmp/guix-build-go-1.10.drv-0/go/src/runtime/asm_amd64.s:718 (libtsan_shared.so+0x000000082fc6)
Thread T1 (tid=28786, running) created by main thread at:
#0 pthread_create <null> (tsan_shared+0x00000040c794)
#1 _cgo_try_pthread_create <null> (libtsan_shared.so+0x00000008ad70)
#2 x_cgo_sys_thread_create <null> (libtsan_shared.so+0x00000008ab12)
#3 _rt0_amd64_lib /tmp/guix-build-go-1.10.drv-0/go/src/runtime/asm_amd64.s:56 (libtsan_shared.so+0x0000000813b6)
SUMMARY: ThreadSanitizer: data race ??:0 threadentry
==================
==================
WARNING: ThreadSanitizer: data race (pid=28778)
Read of size 8 at 0x7ffff7dd54f8 by thread T2:
#0 threadentry <null> (libtsan_shared.so+0x00000008b105)
Previous write of size 8 at 0x7ffff7dd54f8 by thread T1:
#0 x_cgo_init <null> (libtsan_shared.so+0x00000008ae43)
#1 runtime.rt0_go /tmp/guix-build-go-1.10.drv-0/go/src/runtime/asm_amd64.s:199 (libtsan_shared.so+0x000000081586)
Location is global 'setg_gcc' of size 8 at 0x7ffff7dd54f8 (libtsan_shared.so+0x0000003134f8)
Thread T2 (tid=28791, running) created by thread T1 at:
#0 pthread_create <null> (tsan_shared+0x00000040c794)
#1 _cgo_try_pthread_create <null> (libtsan_shared.so+0x00000008ad70)
#2 _cgo_sys_thread_start <null> (libtsan_shared.so+0x00000008b011)
#3 x_cgo_thread_start <null> (libtsan_shared.so+0x00000008b7be)
#4 runtime.asmcgocall /tmp/guix-build-go-1.10.drv-0/go/src/runtime/asm_amd64.s:718 (libtsan_shared.so+0x000000082fc6)
Thread T1 (tid=28786, running) created by main thread at:
#0 pthread_create <null> (tsan_shared+0x00000040c794)
#1 _cgo_try_pthread_create <null> (libtsan_shared.so+0x00000008ad70)
#2 x_cgo_sys_thread_create <null> (libtsan_shared.so+0x00000008ab12)
#3 _rt0_amd64_lib /tmp/guix-build-go-1.10.drv-0/go/src/runtime/asm_amd64.s:56 (libtsan_shared.so+0x0000000813b6)
SUMMARY: ThreadSanitizer: data race ??:0 threadentry
==================
==================
WARNING: ThreadSanitizer: data race (pid=28778)
Read of size 8 at 0x7d080000df80 by thread T6:
#0 threadentry <null> (libtsan_shared.so+0x00000008b0d2)
Previous write of size 8 at 0x7d080000df80 by thread T1:
#0 malloc <null> (tsan_shared+0x00000040aba3)
#1 x_cgo_thread_start <null> (libtsan_shared.so+0x00000008b730)
#2 runtime.asmcgocall /tmp/guix-build-go-1.10.drv-0/go/src/runtime/asm_amd64.s:688 (libtsan_shared.so+0x000000082f87)
Location is heap block of size 24 at 0x7d080000df80 allocated by thread T1:
#0 malloc <null> (tsan_shared+0x00000040aba3)
#1 x_cgo_thread_start <null> (libtsan_shared.so+0x00000008b730)
#2 runtime.asmcgocall /tmp/guix-build-go-1.10.drv-0/go/src/runtime/asm_amd64.s:688 (libtsan_shared.so+0x000000082f87)
Thread T6 (tid=28796, running) created by thread T1 at:
#0 pthread_create <null> (tsan_shared+0x00000040c794)
#1 _cgo_try_pthread_create <null> (libtsan_shared.so+0x00000008ad70)
#2 _cgo_sys_thread_start <null> (libtsan_shared.so+0x00000008b011)
#3 x_cgo_thread_start <null> (libtsan_shared.so+0x00000008b7be)
#4 runtime.asmcgocall /tmp/guix-build-go-1.10.drv-0/go/src/runtime/asm_amd64.s:688 (libtsan_shared.so+0x000000082f87)
Thread T1 (tid=28786, running) created by main thread at:
#0 pthread_create <null> (tsan_shared+0x00000040c794)
#1 _cgo_try_pthread_create <null> (libtsan_shared.so+0x00000008ad70)
#2 x_cgo_sys_thread_create <null> (libtsan_shared.so+0x00000008ab12)
#3 _rt0_amd64_lib /tmp/guix-build-go-1.10.drv-0/go/src/runtime/asm_amd64.s:56 (libtsan_shared.so+0x0000000813b6)
SUMMARY: ThreadSanitizer: data race ??:0 threadentry
==================
ThreadSanitizer: reported 4 warnings
FAIL
2018/02/22 05:28:09 Failed: exit status 1
```
| NeedsInvestigation | low | Critical |
299,475,819 | flutter | Support specifying transitions in Navigator.xNamed calls | Internal: b/292548374
Mulligan uses named routes for all navigation. The `Navigator.pushNamed` method does not support specifying a transition. Instead, it is my understanding that the transition must be declared when we construct the `MaterialPageRoute`.
From my previous discussions with our UX designer, transitions to a given route could vary based on the user action that triggers the navigator push. For example, the transition to route C could be different coming from route A than from route B. This means that in order to support different transitions with the current design, we would have to pass metadata in the named route (e.g., via query parameters) in order to decide what transition to use when constructing the `MaterialPageRoute`.
While this is certainly possible, it seems cumbersome for what I believe would be a common use case.
| c: new feature,framework,customer: mulligan (g3),f: routes,P2,team-framework,triaged-framework | low | Major |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.