id
int64 393k
2.82B
| repo
stringclasses 68
values | title
stringlengths 1
936
| body
stringlengths 0
256k
⌀ | labels
stringlengths 2
508
| priority
stringclasses 3
values | severity
stringclasses 3
values |
|---|---|---|---|---|---|---|
262,992,932 | rust | Tracking issue for `#[doc(spotlight)]` | Initially implemented in https://github.com/rust-lang/rust/pull/45039, this attribute puts your own trait on every function doc if its return type implements it. | T-rustdoc,B-unstable,C-tracking-issue | medium | Major |
263,024,134 | vue | Export flow types in dist file | ### What problem does this feature solve?
If people want to use Vue flow types, they can import them from the Vue npm module.
### What does the proposed API look like?
We would include the flow directory in the npm dist files
(I'm happy to make a PR)
<!-- generated by vue-issues. DO NOT REMOVE --> | feature request | low | Minor |
263,241,254 | go | x/build/devapp: flag new contributors in CL list | I was speaking with someone today who mentioned that they read some of the CL's and issue responses and felt intimidated. Specifically they were worried that they would submit a CL and there would be a mistake with it and they'd get unfriendly feedback.
It's easy to see how this could happen. If I make a dumb mistake it's probably due to carelessness and it's worth calling out, where if a new contributor makes a mistake, it's probably due to not knowing the context or the build tools well enough. But that can be hard for a reviewer to see, or a reviewer might not know to switch modes before reviewing a CL.
We have the "Thanks for your first contribution" commit message, but maybe we could add something else to flag for reviewers that the contributor is new to the project? Maybe gopherbot could add a "New-Contributor: +1" label to CL's where the submitter has submitted less than five CL's. Or a gopherbot message that says e.g. "Note to reviewers: This CL was submitted by someone new to the Go project! They might not have all of the context that others have." | Builders,Proposal,Proposal-Accepted | medium | Critical |
263,289,306 | TypeScript | Detect duplicate nodes during printing | While rewriting code for refactorings and code fixes, it is quite easy to inadvertently insert a single `Node` into multiple positions in the tree (i.e. when it should have been cloned). It would be very helpful if the printer (or other, more appropriate, component) detected this, rather than behaving subtly incorrectly or throwing an (apparently) unrelated exception.
One way to do this would be to clear `__pos` and `__end` before traversing the tree and then throwing if they are set a second time during the traversal. | Suggestion,Experience Enhancement | low | Minor |
263,315,267 | TypeScript | Add node flags for blank lines before and after a node | When inserting a node (e.g. during a code fix or refactoring), it would be very helpful if there were a way to say "ensure that there is a blank line following this node", rather than inserting one, since inserting one might result in a pair of blank lines. The determination of whether or not to actually insert a linebreak would be made in the printer. | Suggestion,In Discussion,API | low | Minor |
263,337,386 | electron | Menu.popup: implement positioningItem for all OS | It looks like [`positioningItem`](https://github.com/electron/electron/blob/master/docs/api/menu.md#menupopupbrowserwindow-options) for `Menu.popup()` is only supported on macOS. It would be great to have it on Linux and Windows as well. | enhancement :sparkles:,platform/windows,platform/linux | low | Minor |
263,387,634 | godot | [2.1.4] Collision offset of Area2D when parent is in movement | ### **Operating system or device, Godot version, GPU Model and driver (if graphics related):**
- OS: *Ubuntu 17.04*
- Godot: *2.1.4*
- GPU: unrelated, but *GTX 860m* using the proprietary drivers
### **Issue description:**
**The scenario**
- I have a ship and a player (both `KinematicBody2D`)
- The player can freely move on the ship (player is a child node of ship)
- Ship has a cockpit, player should be able to enter the cockpit to fly the ship
- The cockpit is a `Area2D` to detect a collision (i.e. if the player inside the cockpit, so the 'Action' key triggers the 'player-enters-cockpit' action)
**The Problem:**
- In the beginning, ship and player are stationary. Player might move into the cockpit and enter it. Player may then accelerate the ship and jump out. Eventually, he might come back, but cannot enter the cockpit anymore because there is no collision detected by the `Area2D`
- Depending on the velocity of the ship, the actual collision area of the `Area2D` will move ahead of the ship. I.e. there is an offset (see illustration below)
- The higher the velocity, the higher the offset
- If the velocity is constant, the offset is constant as well
- The offset is *always* in the direction of flight. The rotation of the ship is irrelevant
Here's an illustration (desired/expected place of collision in a moving ship in red on the left, and the actual place of collision in red on the right):
**Worth mentioning**
- If you enable <kbd>Visible Collision Shapes</kbd> in the debug tools, you won't see any offset at all. The shapes are obviously colliding
- I made a test and manually calculated the collision detection, which produces correct results (i.e. the collisions are detected right, regardless of what the velocity is). A bit more specific: if I check for collision using `collide()` of `RectangleShape2D` for the player model and the `Area2D` inside `_fixed_process()`, I get correct results. However, this is not really practical, since I need to know all possible collision objects in advance... I would expect, that the `body_enter` and `body_exit` events honour the `_fixed_process`-ing (i.e. that the calculations which lead to these events are synchronous with `_fixed_process`)
```gd
func _fixed_process(delta):
# ...
# Workarround
var player = get_node('../path/to/player')
var bb_player = player.get_node('collision-model').shape
var cockpit = get_node('../path/to/cockpit/location')
var bb_cockpit = cockpit.get_node('collision-model').shape
if bb_player.collide(player.get_transform(), bb_cockpit, cockpit.get_transform()):
print('collision')
else:
print('no collision')
# ...
```
### **Steps to reproduce:**
- I made a small demonstration project [right here](https://github.com/charlydelta/godot-movement-cd-bug)
- You can only toggle between two velocities, but it shows the problem quite well I think
- Use <kbd>S</kbd> to travel at a slow velocity (i.e. the hit detection works)
- Use <kbd>F</kbd> to travel at a fast velocity (i.e. the hit detection wont work)
- You can observe the `body_enter` and `body_exit` events in the `print` output
- Traveling at slow speed should indicate `"ENTERED"` in the output. If you toggle to a fast speed, you should see, that the player left the cockpit according to the engine (indicated by `"LEFT"`)
| bug,topic:core,confirmed | low | Critical |
263,487,050 | rust | [Stable] ICE on Windows 7 when compiling dependencies | UPDATE 2:
I just talked over this issue on [internals](https://internals.rust-lang.org/t/familiarity-with-rustc-code/6015/2) and it strongly looks like this ICE is triggered because the code was effectively on a network drive. I moved the project to an internal disk, and now it compiles fine.
Still, I'd rather not close this issue just yet, as it would be nice to be able to compile from a network drive without ICE. This bug also seems related to [this one](https://github.com/rust-lang/rust/issues/40282#issuecomment-330097638), and is perhaps even a duplicate.
UPDATE: I just tried this with stable `rustc 1.20.0 (f3d6973f4 2017-08-27) running on i686-pc-windows-msvc`, and get the same result as with nightly.
I'm trying to compile a project for work on Windows 7 using `rustc 1.22.0-nightly (c6884b12d 2017-09-30)`, but compilation fails when trying to build the project's dependencies.
Interesting to note is that the same `rustc` version on OS X has no issues with the same project.
The log output follows:
````
F:\quip (master)
λ cargo run --bin sxi
warning: could not canonicalize path: 'F:\quip'
warning: could not canonicalize path: 'F:\quip'
warning: could not canonicalize path: 'F:\'
Compiling kernel32-sys v0.2.2
error: internal compiler error: unexpected panic
note: the compiler unexpectedly panicked. this is a bug.
note: we would appreciate a bug report: https://github.com/rust-lang/rust/blob/master/CONTRIBUTING.md#bug-reports
note: rustc 1.22.0-nightly (c6884b12d 2017-09-30) running on i686-pc-windows-msvc
note: run with `RUST_BACKTRACE=1` for a backtrace
thread 'rustc' panicked at 'called `Result::unwrap()` on an `Err` value: Error { repr: Os { code: 1, message: "Incorrect function." } }', src\libcore\result.rs:906:4
stack backtrace:
0: 0x62d9131d - std::panicking::Location::column::h9895b0760262a28a
1: 0x62d90fba - std::panicking::Location::column::h9895b0760262a28a
2: 0x62d91868 - std::panicking::rust_panic_with_hook::h8f20d66610e2b881
3: 0x62d916de - std::panicking::begin_panic_fmt::hb90e383f78c9754f
4: 0x62d91667 - std::panicking::begin_panic_fmt::hb90e383f78c9754f
5: 0x62d915b9 - rust_begin_unwind
6: 0x62da430a - core::panicking::panic_fmt::hf1b6bd69ee550bb9
7: 0x5c586a14 - rustc_metadata::cstore::CrateMetadata::needs_panic_runtime::h066b1941f56c69e2
8: 0x5c66682b - rustc_metadata::locator::Context::report_errs::he94b06f72750cbc6
9: 0x5c65b93f - rustc_metadata::creader::CrateLoader::new::h948973d8362524be
10: 0x5c657bef - rustc_metadata::creader::CrateLoader::new::h948973d8362524be
11: 0x5c660ca2 - <rustc_metadata::creader::CrateLoader<'a> as rustc::middle::cstore::CrateLoader>::process_item::h8732ec1d24fcb8e2
12: 0x5cb69b45 - rustc_resolve::build_reduced_graph::<impl rustc_resolve::ToNameBinding<'a> for (rustc::hir::def::Def, rustc::ty::Visibility, syntax_pos::span_encoding::Span, syntax_pos::hygiene::Mark)>::to_name_binding::hdcec3f8b36125949
13: 0x5cb70fa6 - <rustc_resolve::build_reduced_graph::BuildReducedGraphVisitor<'a, 'b> as syntax::visit::Visitor<'a>>::visit_item::hf1aa69c66ee40100
14: 0x5cb711cc - <rustc_resolve::build_reduced_graph::BuildReducedGraphVisitor<'a, 'b> as syntax::visit::Visitor<'a>>::visit_item::hf1aa69c66ee40100
15: 0x5cb61b8a - rustc_resolve::macros::<impl syntax::ext::base::Resolver for rustc_resolve::Resolver<'a>>::visit_expansion::h1eebd66536c4d25a
16: 0x62a49a30 - syntax::ext::expand::MacroExpander::expand_crate::h7773bd6ef2621edf
17: 0x62a3f949 - syntax::ext::expand::MacroExpander::expand_crate::h7773bd6ef2621edf
18: 0x62a3f3c7 - syntax::ext::expand::MacroExpander::expand_crate::h7773bd6ef2621edf
19: 0x63d4b353 - rustc_driver::driver::count_nodes::h39504b0a4a68bcf8
20: 0x63d468ef - rustc_driver::driver::count_nodes::h39504b0a4a68bcf8
21: 0x63d3e246 - rustc_driver::driver::compile_input::h9417596b5d9e2ea9
22: 0x63d5e975 - rustc_driver::run_compiler::hf870ea00b3ee6606
23: 0x63c756cb - <unknown>
24: 0x62d9899b - _rust_maybe_catch_panic
25: 0x63cae93f - <rustc_driver::derive_registrar::Finder as rustc::hir::itemlikevisit::ItemLikeVisitor<'v>>::visit_impl_item::h8a468c2ea6f8f76e
26: 0x62d8f67c - std::sys::imp::thread::Thread::new::h08d4b413205a3a97
27: 0x76923c44 - BaseThreadInitThunk
28: 0x76e037f4 - RtlInitializeExceptionChain
error: Could not compile `kernel32-sys`.
To learn more, run the command again with --verbose.
```` | O-windows,I-ICE,T-compiler,C-bug,O-windows-7 | low | Critical |
263,488,277 | rust | rust can't serialize 11 fields efficiently | Using noalias (#45012) lets rust generate much better code for the serialization of 10 fields in good_bake_bytes() however it falls back to terrible with the 11 fields of bad_bake_bytes()
```rust
use std::io::Write;
use std::{io, ptr};
struct UnsafeVecWriter<'a>(&'a mut Vec<u8>);
impl<'a> Write for UnsafeVecWriter<'a> {
fn write(&mut self, buf: &[u8]) -> io::Result<usize> {
unsafe {
let old_len = self.0.len();
self.0.set_len(old_len + buf.len());
ptr::copy_nonoverlapping(buf.as_ptr(), self.0.as_mut_ptr().offset(old_len as isize), buf.len());
}
Ok(buf.len())
}
fn flush(&mut self) -> io::Result<()> { Ok(()) }
}
struct Entity {
o: (f32,f32,f32,f32,f32,f32,f32,f32,f32,f32,f32),
}
use std::mem::transmute;
fn do_f32<W: Write>(w: &mut W, x: f32) {
unsafe {
let p: [u8; 4] = std::mem::transmute([x]);
w.write(&p);
}
}
#[inline(never)]
fn bad_bake_bytes(vec: &mut Vec<u8>, e: &Entity) {
let w = &mut UnsafeVecWriter(vec);
do_f32(w, e.o.0);
do_f32(w, e.o.1);
do_f32(w, e.o.2);
do_f32(w, e.o.3);
do_f32(w, e.o.4);
do_f32(w, e.o.5);
do_f32(w, e.o.6);
do_f32(w, e.o.7);
do_f32(w, e.o.8);
do_f32(w, e.o.9);
do_f32(w, e.o.10);
}
#[inline(never)]
fn good_bake_bytes(vec: &mut Vec<u8>, e: &Entity) {
let w = &mut UnsafeVecWriter(vec);
do_f32(w, e.o.0);
do_f32(w, e.o.1);
do_f32(w, e.o.2);
do_f32(w, e.o.3);
do_f32(w, e.o.4);
do_f32(w, e.o.5);
do_f32(w, e.o.6);
do_f32(w, e.o.7);
do_f32(w, e.o.8);
do_f32(w, e.o.9);
//do_f32(w, e.o.10);
}
fn main() {
let mut encoded = Vec::new();
let decoded: Entity = unsafe { std::mem::uninitialized() };
bad_bake_bytes(&mut encoded, &decoded);
good_bake_bytes(&mut encoded, &decoded);
}
```
```assembly
__ZN10serde_fast14bad_bake_bytes17h506e94e6df0b1a3bE:
.cfi_startproc
pushq %rbp
Lcfi0:
.cfi_def_cfa_offset 16
Lcfi1:
.cfi_offset %rbp, -16
movq %rsp, %rbp
Lcfi2:
.cfi_def_cfa_register %rbp
movl (%rsi), %eax
movq 16(%rdi), %rcx
leaq 4(%rcx), %rdx
movq %rdx, 16(%rdi)
movq (%rdi), %rdx
movl %eax, (%rdx,%rcx)
movl 4(%rsi), %eax
movq 16(%rdi), %rcx
leaq 4(%rcx), %rdx
movq %rdx, 16(%rdi)
movq (%rdi), %rdx
movl %eax, (%rdx,%rcx)
movl 8(%rsi), %eax
movq 16(%rdi), %rcx
leaq 4(%rcx), %rdx
movq %rdx, 16(%rdi)
movq (%rdi), %rdx
movl %eax, (%rdx,%rcx)
movl 12(%rsi), %eax
movq 16(%rdi), %rcx
leaq 4(%rcx), %rdx
movq %rdx, 16(%rdi)
movq (%rdi), %rdx
movl %eax, (%rdx,%rcx)
movl 16(%rsi), %eax
movq 16(%rdi), %rcx
leaq 4(%rcx), %rdx
movq %rdx, 16(%rdi)
movq (%rdi), %rdx
movl %eax, (%rdx,%rcx)
movl 20(%rsi), %eax
movq 16(%rdi), %rcx
leaq 4(%rcx), %rdx
movq %rdx, 16(%rdi)
movq (%rdi), %rdx
movl %eax, (%rdx,%rcx)
movl 24(%rsi), %eax
movq 16(%rdi), %rcx
leaq 4(%rcx), %rdx
movq %rdx, 16(%rdi)
movq (%rdi), %rdx
movl %eax, (%rdx,%rcx)
movl 28(%rsi), %eax
movq 16(%rdi), %rcx
leaq 4(%rcx), %rdx
movq %rdx, 16(%rdi)
movq (%rdi), %rdx
movl %eax, (%rdx,%rcx)
movl 32(%rsi), %eax
movq 16(%rdi), %rcx
leaq 4(%rcx), %rdx
movq %rdx, 16(%rdi)
movq (%rdi), %rdx
movl %eax, (%rdx,%rcx)
movl 36(%rsi), %eax
movq 16(%rdi), %rcx
leaq 4(%rcx), %rdx
movq %rdx, 16(%rdi)
movq (%rdi), %rdx
movl %eax, (%rdx,%rcx)
movl 40(%rsi), %eax
movq 16(%rdi), %rcx
leaq 4(%rcx), %rdx
movq %rdx, 16(%rdi)
movq (%rdi), %rdx
movl %eax, (%rdx,%rcx)
popq %rbp
retq
.cfi_endproc
.p2align 4, 0x90
__ZN10serde_fast15good_bake_bytes17h3098644f875a0da3E:
.cfi_startproc
pushq %rbp
Lcfi3:
.cfi_def_cfa_offset 16
Lcfi4:
.cfi_offset %rbp, -16
movq %rsp, %rbp
Lcfi5:
.cfi_def_cfa_register %rbp
movl (%rsi), %eax
movq (%rdi), %rcx
movq 16(%rdi), %rdx
movl %eax, (%rcx,%rdx)
movl 4(%rsi), %eax
movl %eax, 4(%rcx,%rdx)
movl 8(%rsi), %eax
movl %eax, 8(%rcx,%rdx)
movl 12(%rsi), %eax
movl %eax, 12(%rcx,%rdx)
movl 16(%rsi), %eax
movl %eax, 16(%rcx,%rdx)
movl 20(%rsi), %eax
movl %eax, 20(%rcx,%rdx)
movl 24(%rsi), %eax
movl %eax, 24(%rcx,%rdx)
movl 28(%rsi), %eax
movl %eax, 28(%rcx,%rdx)
movl 32(%rsi), %eax
movl %eax, 32(%rcx,%rdx)
movl 36(%rsi), %eax
leaq 40(%rdx), %rsi
movq %rsi, 16(%rdi)
movl %eax, 36(%rcx,%rdx)
popq %rbp
retq
.cfi_endproc
``` | A-LLVM,I-slow,C-enhancement,T-compiler,WG-llvm,C-optimization | medium | Major |
263,500,311 | vscode | Customizable status bar item locations | Hello
It would be really nice if one could customize the location of the items in the status bar at the bottom of the editor. For instance, I would want to have git branch information on the right, text encoding and position on the left, etc.
Maybe allow people to sort things with something like
```javascript
"window.statusBar.items": {
"left" : ["cursorPosition", "tabWidth"],
"right": ["textEncoding", "gitBranch", "feedbackButton" ]
}
```
| feature-request,workbench-status,keep | high | Critical |
263,578,496 | go | image/jpeg: Unable to decode concatenated JPEGs (MIME-less "MJPEG") | #### What did you do?
Wrapping `ffmpeg -i <url> -c:v mjpeg -f image2pipe -` in a `exec.Cmd` and continuously decoding the command output in a loop with `jpeg.Decode` fails while doing the same thing with `ffmpeg -i <url> -c:v png -f image2pipe -` and `png.Decode` works.
The following example illustrates the error by creating an MJPEG stream using a sample image: https://play.golang.org/p/lppyHZftWA
The same program but using a PNG stream and `png.Decode` shows successful decoding and a clean exit: https://play.golang.org/p/c54-hc6JRK
The following is a test that is expected to pass:
```
package test
import (
"bytes"
"image/jpeg"
"image/png"
"io"
"testing"
)
// pngFrame is a PNG produced with
// `convert -size 1x1 xc:white png:- | xxd -c 1 -ps | sed -e 's/^/\\x/' |tr -d '\n'`
const pngFrame = "\x89\x50\x4e\x47\x0d\x0a\x1a\x0a\x00\x00\x00\x0d\x49\x48\x44\x52\x00\x00\x00\x01\x00\x00\x00\x01\x01\x00\x00\x00\x00\x37\x6e\xf9\x24\x00\x00\x00\x04\x67\x41\x4d\x41\x00\x00\xb1\x8f\x0b\xfc\x61\x05\x00\x00\x00\x20\x63\x48\x52\x4d\x00\x00\x7a\x26\x00\x00\x80\x84\x00\x00\xfa\x00\x00\x00\x80\xe8\x00\x00\x75\x30\x00\x00\xea\x60\x00\x00\x3a\x98\x00\x00\x17\x70\x9c\xba\x51\x3c\x00\x00\x00\x02\x62\x4b\x47\x44\x00\x01\xdd\x8a\x13\xa4\x00\x00\x00\x07\x74\x49\x4d\x45\x07\xe1\x0a\x06\x15\x06\x25\x79\xa4\x37\xa0\x00\x00\x00\x0a\x49\x44\x41\x54\x08\xd7\x63\x68\x00\x00\x00\x82\x00\x81\xdd\x43\x6a\xf4\x00\x00\x00\x25\x74\x45\x58\x74\x64\x61\x74\x65\x3a\x63\x72\x65\x61\x74\x65\x00\x32\x30\x31\x37\x2d\x31\x30\x2d\x30\x36\x54\x32\x31\x3a\x30\x36\x3a\x33\x37\x2b\x30\x31\x3a\x30\x30\xeb\x24\x00\x4a\x00\x00\x00\x25\x74\x45\x58\x74\x64\x61\x74\x65\x3a\x6d\x6f\x64\x69\x66\x79\x00\x32\x30\x31\x37\x2d\x31\x30\x2d\x30\x36\x54\x32\x31\x3a\x30\x36\x3a\x33\x37\x2b\x30\x31\x3a\x30\x30\x9a\x79\xb8\xf6\x00\x00\x00\x00\x49\x45\x4e\x44\xae\x42\x60\x82"
// jpegFrame is a JPEG frame produced with
// `convert -size 1x1 xc:white jpg:- | xxd -c 1 -ps | sed -e 's/^/\\x/' |tr -d '\n'`
const jpegFrame = "\xff\xd8\xff\xe0\x00\x10\x4a\x46\x49\x46\x00\x01\x01\x00\x00\x01\x00\x01\x00\x00\xff\xdb\x00\x43\x00\x03\x02\x02\x02\x02\x02\x03\x02\x02\x02\x03\x03\x03\x03\x04\x06\x04\x04\x04\x04\x04\x08\x06\x06\x05\x06\x09\x08\x0a\x0a\x09\x08\x09\x09\x0a\x0c\x0f\x0c\x0a\x0b\x0e\x0b\x09\x09\x0d\x11\x0d\x0e\x0f\x10\x10\x11\x10\x0a\x0c\x12\x13\x12\x10\x13\x0f\x10\x10\x10\xff\xc0\x00\x0b\x08\x00\x01\x00\x01\x01\x01\x11\x00\xff\xc4\x00\x14\x00\x01\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x09\xff\xc4\x00\x14\x10\x01\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\xff\xda\x00\x08\x01\x01\x00\x00\x3f\x00\x54\xdf\xff\xd9"
func TestMultiPngDecode(t *testing.T) {
var expected int = 3 // expected success count
var got int // decoded frame count
var no int // frame number
stream := bytes.NewBuffer(bytes.Repeat([]byte(pngFrame), expected))
for no = 1; no <= expected; no++ {
_, err := png.Decode(stream)
if err != nil {
if err != io.EOF {
t.Errorf("Unexpected error when decoding frame #%d: %s", no, err)
}
break
}
got++
}
if expected != got {
t.Errorf("Expected %d decoded frames, got %d", expected, got)
}
}
func TestMjpegDecode(t *testing.T) {
var expected int = 3 // expected success count
var got int // decoded frame count
var no int // frame number
stream := bytes.NewBuffer(bytes.Repeat([]byte(jpegFrame), expected))
for no = 1; no <= expected; no++ {
_, err := jpeg.Decode(stream)
if err != nil {
if err != io.EOF {
t.Errorf("Unexpected error when decoding frame #%d: %s", no, err)
}
break
}
got++
}
if expected != got {
t.Errorf("Expected %d decoded frames, got %d", expected, got)
}
}
```
Grabbing a number of frames from a video and inspecting the output we can verify that there's no unexpected bytes after the EOI marker (`ff d9`) and before the next SOI marker (`ff d8`) and that we get the expected number of frames:
```
ffmpeg -v quiet -y -i <video> -frames:v 3 -c:v mjpeg -f image2pipe - | hexdump | grep "ff d8"
0000000 ff d8 ff e0 00 10 4a 46 49 46 00 01 02 00 00 01
00054d0 14 9e 80 7f ff d9 ff d8 ff e0 00 10 4a 46 49 46
000ca60 ad d0 2b 8a 29 69 29 68 7a 05 cf ff d9 ff d8 ff
ffmpeg -v quiet -y -i <video> -frames:v 3 -c:v mjpeg -f image2pipe - | hexdump | grep "ff d9"
00054d0 14 9e 80 7f ff d9 ff d8 ff e0 00 10 4a 46 49 46
000ca60 ad d0 2b 8a 29 69 29 68 7a 05 cf ff d9 ff d8 ff
0014180 ff d9
```
#### What did you expect to see?
The MJPEG stream is a concatenation of JPEG images and the decoder should be able to successfully decode multiple images in sequence without forcing caller to keep track of and seek to next frame.
The program https://play.golang.org/p/lppyHZftWA is expected to not give any output but decode all stream frames correctly and exit cleanly when hitting `io.EOF`
#### What did you see instead?
The program prints an error message as it hits `io.ErrUnexpectedEOF`
#### Does this issue reproduce with the latest release (go1.9.1)?
Yes
#### System details
```
go version go1.9 darwin/amd64
GOARCH="amd64"
GOBIN=""
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
GOPATH="/Users/hnnsgstfssn/go"
GORACE=""
GOROOT="/usr/local/Cellar/go/1.9/libexec"
GOTOOLDIR="/usr/local/Cellar/go/1.9/libexec/pkg/tool/darwin_amd64"
GCCGO="gccgo"
CC="clang"
GOGCCFLAGS="-fPIC -m64 -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/md/xyw1fqr954lfbtnfc_9ym_0r0000gn/T/go-build236075526=/tmp/go-build -gno-record-gcc-switches -fno-common"
CXX="clang++"
CGO_ENABLED="0"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOROOT/bin/go version: go version go1.9 darwin/amd64
GOROOT/bin/go tool compile -V: compile version go1.9
uname -v: Darwin Kernel Version 16.6.0: Fri Apr 14 16:21:16 PDT 2017; root:xnu-3789.60.24~6/RELEASE_X86_64
ProductName: Mac OS X
ProductVersion: 10.12.5
BuildVersion: 16F73
lldb --version: lldb-370.0.42
Swift-3.1
```
| NeedsInvestigation | low | Critical |
263,631,610 | vscode | Input box completion support | - VSCode Version: 1.17.0
- OS Version: Windows 10 x64
I'm not sure if I'm searching for the right terms, but there doesn't seem to be a way to get an extension to show an input box with completion entries, similar to the 'Show all commands' dropdown, or the 'Go to symbol in workspace' dropdown:
The closest that I can get is to use `showInputBox` with a `validateInput` input validator, but this only allows you to return one entry, which doesn't work well if there's multiple options that could be possible. There's also the quick picker, but as far as I know, it doesn't allow you to dynamically update the available options depending on what has been typed in.
Is it possible to expose a similar sort of functionality in the vscode API?
| feature-request,quick-pick | medium | Major |
263,644,188 | rust | Decouple NetBSD/amd64 builds from dynamic libgcc_s | The prebuilt binaries for NetBSD x86_64 require libgcc_s.so, but the base NetBSD system can be built as a "pure" clang build; in such cases the system will not contain libgcc_s.so.
To cover non-gcc NetBSD systems the bootstrap kit should be built using -static-libgcc.
See https://gnats.netbsd.org/cgi-bin/query-pr-single.pl?number=52584 | T-compiler,O-netbsd,C-feature-request | low | Minor |
263,648,169 | youtube-dl | Unsupported TV Provider NBC free profile to view full episode with new Tokens System | Microsoft Windows [Version 6.1.7601]
Copyright (c) 2009 Microsoft Corporation. All rights reserved.
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['-v', '--no-check', '--ap-mso', 'NBC', '--ap-usernam
e', 'PRIVATE', '--ap-password', 'PRIVATE', 'http://www.nbc.com/today/video/today
-oct-5-2017/3590873']
Usage: youtube-dl [OPTIONS] URL [URL...]
youtube-dl: error: Unsupported TV Provider, use --ap-list-mso to get a list of s
upported TV Providers
I've **verified** and **I assure** that I'm running youtube-dl **2017.10.07**
Using latest version youtube dl sorry i did in last issue include verbose, NBC changed the policy for viewing the video, now needed to create a NBC profile to view free to view video with lock icon you can create a free account here
https://www.nbc.com/sign-up
before this change you did not need auy profile and download on youtube worked fine, if you removed (s) from https
when done you get 3 free credits for new account, each credit allow you view a full locked episode,, you will need a US ip/proxy to view as it is geo locked, but i have tested this and it works the video plays if you are logged into free nbc profile it does not need to be linked to a US TV provider as long as you tokens to unlock a episode.
https://www.nbc.com/today/video/today-oct-6-2017/3590881
i need some help and understand how to use the commands --ap-mso --ap-username --ap-password
does these command support this new NBC profile and token system nbc had changed too since start of this week
hope someone can look into all this. | tv-provider-account-needed | low | Critical |
263,650,274 | vscode | Can we support CR line endings as well as LF and CRLF? | VSCode supports LF line endings, and CRLF line endings, but it doesn't support CR line endings.
Any chance of support for this? There _are_ some exotic platforms which still require them, such as e.g. pre OSX MacOS, and the amount of work involved ought to be trivial. This is ff=mac mode in vim.
I've tried manually setting files.eol to "\r", but the value is rejected as being invalid.
Right now, if you try to open a CR file in VSCode it gets normalised to CRLF, which is incorrect. At the very least stopping this from happening would be nice. | feature-request,editor-textbuffer | high | Critical |
263,660,888 | flutter | UserAccountsDrawerHeader - Integrate account management | Would it be possible for the UserAccountsDrawerHeader to be integrated with [AccountManager](https://developer.android.com/reference/android/accounts/AccountManager) in Android and in settings bundle/within app in iOS (whichever is better)?
This would help standardize the sign in/ sign out flow, or atleast provide a template to implement this most common of all functionalities. This would also help volks understand the best practice for how to check if the user is signed in before showing a page/screen, and react if the user signs out while an action is in progress. An analogy for this functionality is the router hooks (CanActivate et al) in AngularDart [1]. The Flutter router Fluro [2] does not seem to have the hooks/guard mechanism.
In case this mechanism is better implemented via the Observer pattern/Streams/Rx*, that too would be a welcome discussion. Some guidance is better than nothing.
Filing this request since I could not find an issue for this. Apologies in case there is already one. Also, in case it is relevant, this assumes that the authentication mechanism does not use Firebase.
[1] - https://github.com/dart-lang/angular/blob/master/angular_router/example/lib/admin/admin_component.dart
[2] - https://github.com/goposse/fluro | c: new feature,framework,f: material design,package,P3,team-design,triaged-design | low | Minor |
263,662,022 | flutter | UserAccountsDrawerHeader - Implement/document user account switching | UserAccountsDrawerHeader does not seem to switch user accounts when another user account image is tapped on. May be the animations need to be triggered via some calls, may be the relevant calls are missing, may be everything required to do this is already there and I cannot see it.
In any case, the expected state is that when the user clicks on the small CircleAvatar, the user accounts should switch. Relevant animations, if any, should be performed. Not sure about the animations part because the material spec does not seem to suggest any [1], but I am sure that the user account switching needs to be communicated to the user through some visual mechanism.
With regards to the actual user account switching within the app, and the relevant changes, the app needs to be notified about the account switching. Would this be best implemented as some kind of an event delivered on a user account lifecycle subscription, in conjunction with #12447 ? Apologies if this does not make any sense, I am trying to wrap my head around this myself.
[1] - https://material.io/guidelines/patterns/navigation-drawer.html | framework,f: material design,d: examples,P2,team-design,triaged-design | low | Minor |
263,672,194 | godot | Inconsistent execution order of _integrate_forces | **Operating system or device, Godot version, GPU Model and driver (if graphics related):**
v2.1.4 stable
**Issue description:**
The standard 2d physics step performs force integration before velocity integration. Rigid Bodies have a method binding called `_integrate_forces` that's designed to replace force integration with custom logic. However, within a standard step, the `_integrate_forces` method executes _after_ the velocity integration stage, rather than before.
This is mainly a consistency issue. It can partially be worked around by inserting integration code into the `_fixed_process` method, but this can result in minor race conditions if other nodes attempt to modify a rigid body's physics parameters during the fixed physics stage. | bug,confirmed,topic:physics | low | Minor |
263,684,779 | neovim | startup: precedence of :syntax/:filetype autocmds | <!-- Before reporting: search existing issues and check the FAQ. -->
- `nvim --version`: NVIM v0.2.1-915-g01e53a5
- Vim (version: ) behaves differently? no
- Operating system/version: WSL
- Terminal name/version: conhost/Windows 10
- `$TERM`: xterm-256color
### Steps to reproduce using `nvim -u NORC`
```fish
~> cat minimal.vim
autocmd FileType md set syntax=markdown filetype=markdown
~> nvim -u minimal.vim
:set ft=md
:set ft #prints markdown
:set syntax #prints md
```
whereas
```fish
~> nvim -u NORC
:autocmd FileType md set syntax=markdown filetype=markdown
:set ft=md
:set ft #prints markdown
:set syntax #prints markdown
```
Vim does not exhibit this behavior when started up with `minimal.vim` containing the same.
| defaults,ux | low | Major |
263,690,241 | youtube-dl | Site support request: DAZN.com | ## Please follow the guide below
- You will be asked some questions and requested to provide some information, please read them **carefully** and answer honestly
- Put an `x` into all the boxes [ ] relevant to your *issue* (like this: `[x]`)
- Use the *Preview* tab to see what your issue will actually look like
---
### Make sure you are using the *latest* version: run `youtube-dl --version` and ensure your version is *2017.10.07*. If it's not, read [this FAQ entry](https://github.com/rg3/youtube-dl/blob/master/README.md#how-do-i-update-youtube-dl) and update. Issues with outdated version will be rejected.
- [x] I've **verified** and **I assure** that I'm running youtube-dl **2017.10.07**
### Before submitting an *issue* make sure you have:
- [x] At least skimmed through the [README](https://github.com/rg3/youtube-dl/blob/master/README.md), **most notably** the [FAQ](https://github.com/rg3/youtube-dl#faq) and [BUGS](https://github.com/rg3/youtube-dl#bugs) sections
- [x] [Searched](https://github.com/rg3/youtube-dl/search?type=Issues) the bugtracker for similar issues including closed ones
### What is the purpose of your *issue*?
- [ ] Bug report (encountered problems with youtube-dl)
- [x] Site support request (request for adding support for a new site)
- [ ] Feature request (request for a new functionality)
- [ ] Question
- [ ] Other
---
### The following sections concretize particular purposed issues, you can erase any section (the contents between triple ---) not applicable to your *issue*
---
### If the purpose of this *issue* is a *bug report*, *site support request* or you are not completely sure provide the full verbose output as follows:
Add the `-v` flag to **your command line** you run youtube-dl with (`youtube-dl -v <your command line>`), copy the **whole** output and insert it here. It should look similar to one below (replace it with **your** log inserted between triple ```):
```
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: [u'-v', u'https://www.dazn.com/en-CA/competition/Competition:wy3kluvb4efae1of0d8146c1/ArticleId:f8nvxa8g55ty12hyzllyr0iei']
[debug] Encodings: locale UTF-8, fs utf-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2017.10.07
[debug] Python version 2.7.10 - Darwin-17.0.0-x86_64-i386-64bit
[debug] exe versions: avconv 12.2, avprobe 12.2, ffmpeg 3.3.4, ffprobe 3.3.4, phantomjs 2.1.1
[debug] Proxy map: {}
[generic] ArticleId:f8nvxa8g55ty12hyzllyr0iei: Requesting header
WARNING: Falling back on generic information extractor.
[generic] ArticleId:f8nvxa8g55ty12hyzllyr0iei: Downloading webpage
[generic] ArticleId:f8nvxa8g55ty12hyzllyr0iei: Extracting information
ERROR: Unsupported URL: https://www.dazn.com/en-CA/competition/Competition:wy3kluvb4efae1of0d8146c1/ArticleId:f8nvxa8g55ty12hyzllyr0iei
Traceback (most recent call last):
File "/usr/local/bin/youtube-dl/youtube_dl/extractor/generic.py", line 2156, in _real_extract
doc = compat_etree_fromstring(webpage.encode('utf-8'))
File "/usr/local/bin/youtube-dl/youtube_dl/compat.py", line 2539, in compat_etree_fromstring
doc = _XML(text, parser=etree.XMLParser(target=_TreeBuilder(element_factory=_element_factory)))
File "/usr/local/bin/youtube-dl/youtube_dl/compat.py", line 2528, in _XML
parser.feed(text)
File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/xml/etree/ElementTree.py", line 1642, in feed
self._raiseerror(v)
File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/xml/etree/ElementTree.py", line 1506, in _raiseerror
raise err
ParseError: mismatched tag: line 45, column 2
Traceback (most recent call last):
File "/usr/local/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 784, in extract_info
ie_result = ie.extract(url)
File "/usr/local/bin/youtube-dl/youtube_dl/extractor/common.py", line 434, in extract
ie_result = self._real_extract(url)
File "/usr/local/bin/youtube-dl/youtube_dl/extractor/generic.py", line 3051, in _real_extract
raise UnsupportedError(url)
UnsupportedError: Unsupported URL: https://www.dazn.com/en-CA/competition/Competition:wy3kluvb4efae1of0d8146c1/ArticleId:f8nvxa8g55ty12hyzllyr0iei
```
---
### If the purpose of this *issue* is a *site support request* please provide all kinds of example URLs support for which should be included (replace following example URLs by **yours**):
- Single video: https://www.dazn.com/en-CA/competition/Competition:wy3kluvb4efae1of0d8146c1/ArticleId:f8nvxa8g55ty12hyzllyr0iei
---
### Description of your *issue*, suggested solution and other information
No issue.
| geo-restricted,account-needed | low | Critical |
263,704,800 | youtube-dl | Site support: www.i24news.tv | ## Please follow the guide below
- You will be asked some questions and requested to provide some information, please read them **carefully** and answer honestly
- Put an `x` into all the boxes [ ] relevant to your *issue* (like this: `[x]`)
- Use the *Preview* tab to see what your issue will actually look like
---
### Make sure you are using the *latest* version: run `youtube-dl --version` and ensure your version is *2017.10.07*. If it's not, read [this FAQ entry](https://github.com/rg3/youtube-dl/blob/master/README.md#how-do-i-update-youtube-dl) and update. Issues with outdated version will be rejected.
- [x] I've **verified** and **I assure** that I'm running youtube-dl **2017.10.07**
### Before submitting an *issue* make sure you have:
- [x] At least skimmed through the [README](https://github.com/rg3/youtube-dl/blob/master/README.md), **most notably** the [FAQ](https://github.com/rg3/youtube-dl#faq) and [BUGS](https://github.com/rg3/youtube-dl#bugs) sections
- [x] [Searched](https://github.com/rg3/youtube-dl/search?type=i24) the bugtracker for similar issues including closed ones
### What is the purpose of your *issue*?
- [ ] Bug report (encountered problems with youtube-dl)
- [x] Site support request (request for adding support for a new site)
- [ ] Feature request (request for a new functionality)
- [ ] Question
- [ ] Other
---
### The following sections concretize particular purposed issues, you can erase any section (the contents between triple ---) not applicable to your *issue*
---
### If the purpose of this *issue* is a *bug report*, *site support request* or you are not completely sure provide the full verbose output as follows:
Add the `-v` flag to **your command line** you run youtube-dl with (`youtube-dl -v http://www.i24news.tv/en/tv/live`), copy the **whole** output and insert it here. It should look similar to one below (replace it with **your** log inserted between triple ```):
```
youtube-dl -v http://www.i24news.tv/en/tv/live
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: [u'-v', u'http://www.i24news.tv/en/tv/live']
[debug] Encodings: locale UTF-8, fs UTF-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2017.10.07
[debug] Python version 2.7.12 - Linux-4.4.0-21-generic-x86_64-with-LinuxMint-18.2-sonya
[debug] exe versions: ffmpeg 2.8.11-0ubuntu0.16.04.1, ffprobe 2.8.11-0ubuntu0.16.04.1
[debug] Proxy map: {}
[generic] live: Requesting header
WARNING: Falling back on generic information extractor.
[generic] live: Downloading webpage
[generic] live: Extracting information
ERROR: Unsupported URL: http://www.i24news.tv/en/tv/live
Traceback (most recent call last):
File "/usr/local/bin/youtube-dl/youtube_dl/extractor/generic.py", line 2156, in _real_extract
doc = compat_etree_fromstring(webpage.encode('utf-8'))
File "/usr/local/bin/youtube-dl/youtube_dl/compat.py", line 2539, in compat_etree_fromstring
doc = _XML(text, parser=etree.XMLParser(target=_TreeBuilder(element_factory=_element_factory)))
File "/usr/local/bin/youtube-dl/youtube_dl/compat.py", line 2528, in _XML
parser.feed(text)
File "/usr/lib/python2.7/xml/etree/ElementTree.py", line 1653, in feed
self._raiseerror(v)
File "/usr/lib/python2.7/xml/etree/ElementTree.py", line 1517, in _raiseerror
raise err
ParseError: not well-formed (invalid token): line 72, column 22
Traceback (most recent call last):
File "/usr/local/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 784, in extract_info
ie_result = ie.extract(url)
File "/usr/local/bin/youtube-dl/youtube_dl/extractor/common.py", line 434, in extract
ie_result = self._real_extract(url)
File "/usr/local/bin/youtube-dl/youtube_dl/extractor/generic.py", line 3051, in _real_extract
raise UnsupportedError(url)
UnsupportedError: Unsupported URL: http://www.i24news.tv/en/tv/live
...
<end of log>
```
---
### If the purpose of this *issue* is a *site support request* please provide all kinds of example URLs support for which should be included (replace following example URLs by **yours**):
- Single video: https://www.youtube.com/watch?v=BaW_jenozKc
- Single video: https://youtu.be/BaW_jenozKc
- Playlist: https://www.youtube.com/playlist?list=PL4lCao7KL_QFVb7Iudeipvc2BCavECqzc
Note that **youtube-dl does not support sites dedicated to [copyright infringement](https://github.com/rg3/youtube-dl#can-you-add-support-for-this-anime-video-site-or-site-which-shows-current-movies-for-free)**. In order for site support request to be accepted all provided example URLs should not violate any copyrights.
---
### Description of your *issue*, suggested solution and other information
Explanation of your *issue* in arbitrary form goes here. Please make sure the [description is worded well enough to be understood](https://github.com/rg3/youtube-dl#is-the-description-of-the-issue-itself-sufficient). Provide as much context and examples as possible.
If work on your *issue* requires account credentials please provide them or explain how one can obtain them.
| site-support-request | low | Critical |
263,719,668 | TypeScript | Customise extensions that import intellisense recognises | _From @Rich-Harris on October 6, 2017 15:7_
As of VSCode 1.17, typing `import x from './` offers autocomplete suggestions of local files and directories. However, the list of file extensions that are recognised is somewhat arbitrary — .js files are recognised, as are .ts and .jsx, but .json isn't (despite the fact that the Node handles .json files natively).
Meanwhile, when building web applications with bundlers like Webpack and Rollup, it's common to import files with extensions like .css, .html, .vue, .tsv and so on.
Is there some way to customise the list of extensions that are recognised? An alternative approach could be to recognise all file extensions rather than attempting to filter them.
_Copied from original issue: Microsoft/vscode#35731_ | Suggestion,In Discussion,Domain: Completion Lists,VS Code Tracked | low | Minor |
263,727,333 | go | encoding/json: Multiple issues with decoding of nulls into ",string" tagged fields. | I've been playing around with the `megacheck` tool, and found that `NullTestStrings` type in `encoding/json`'s tests is unused. It seems to be aimed at checking decoding of nulls into `",string"` fields, but there were no tests, which is the first issue. The second is that if you create one, it fails: https://play.golang.org/p/5XjdhoDDkq.
```
--- FAIL: TestUnmarshalStringNulls (0.00s)
main.go:126: Unmarshal of null values failed: MustNotUnmarshalJSON was used
main.go:138: Unmarshal of null did not clear nulls.Map
main.go:141: Unmarshal of null did not clear nulls.Slice
main.go:144: Unmarshal of null did not clear nulls.Interface
main.go:147: Unmarshal of null did not clear nulls.PRaw
main.go:150: Unmarshal of null did not clear nulls.PTime
main.go:153: Unmarshal of null did not clear nulls.PBigInt
main.go:156: Unmarshal of null did not clear nulls.PText
main.go:159: Unmarshal of null did not clear nulls.PBuffer
main.go:162: Unmarshal of null did not clear nulls.PStruct
main.go:166: Unmarshal of RawMessage null did not record null: 123
FAIL
```
It seems to me that there are some inconsistencies between decoding `null` into a simple field and decoding `"null"` into a `",string"` field.
Formalities:
```
$ go version
go version devel +ca360c3 Sat Oct 7 22:12:36 2017 +0000 linux/amd64
$ go env
GOARCH="amd64"
GOBIN=""
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/home/ainar/go"
GORACE=""
GOROOT="/home/ainar/go/gotip"
GOTOOLDIR="/home/ainar/go/gotip/pkg/tool/linux_amd64"
GCCGO="gccgo"
CC="gcc"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build220310604=/tmp/go-build -gno-record-gcc-switches"
CXX="g++"
CGO_ENABLED="1"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
``` | NeedsInvestigation | low | Critical |
263,788,585 | flutter | We should exclude flutter_tools dependencies from flutter API docs | In particular, having the "file" package in there is very confusing. | tool,d: api docs,P2,team-tool,triaged-tool | low | Major |
263,877,573 | go | cmd/compile: consider adding sibling links to generated DWARF | The DWARF .debug_info section generated by the current Go compiler
does not make use of sibling links at the moment. As gc-generated
DWARF DIE's begin to get more substantial/complicated, this will make
it more time-consuming for debugger as it tries to locate the DIE for
a specific entity within the .debug_info section.
It might make sense to look into introducing siblings to DIEs such as
the subprogram DIE and possibly the structure type DIE (for use in cases
where you have a struct with a large number of members).
Note that such a change would provide little benefit for Delve users
without a corresponding change to Delve (looking at the Delve tip
source code, it appears that the DWARF reader is not set up to exploit
sibling links).
@aarzilli @heschik
| NeedsInvestigation,Debugging,compiler/runtime | low | Critical |
263,889,534 | opencv | IMREAD_LOAD_GDAL produces images with RGB band order |
**System information (version)**
- OpenCV => 3.3.0
- GDAL => 2.2.1
- Operating System / Platform => Linux 64 Bit (CentOS 7)
- Compiler => GCC 7.2
**Detailed description**
Hello, when reading color raster image using GDAL (IMREAD_LOAD_GDAL flag), the band order is RGB, which is reversed from opencv standart one -> BGR. This is not a big problem, but still challenging when I want to save image after some manipulation/or overlay something on it and then write it using imwrite.
**Steps to reproduce**
just open any image with IMREAD_LOAD_GDAL flag - imread(file, IMREAD_LOAD_GDAL).
Thank you | incomplete | low | Minor |
263,966,091 | rust | Grammar ambiguity with left shifts and fully qualified (UFCS) paths | Playground: https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=35f2e9b9c6d48c33199bc878363a15df
```rust
trait Trait {
const CONST: u8;
}
impl Trait for *const u8 {
const CONST: u8 = 1;
}
fn main() {
0<<*const u8 as Trait>::CONST;
}
```
`0<<*const u8 as Trait>::CONST` here unambiguously means `0 < (<*const u8 as Trait>::CONST)` because it can't be parsed as a shift, but rustc tries to parse it as a shift and report an error:
```
error: expected expression, found keyword `const`
--> src/main.rs:9:9
|
9 | 0<<*const u8 as Trait>::CONST;
| ^^^^^
```
Note that you can't detect this situation using limited lookahead in general case, for example
```rust
0<<Trait1 + Trait2 + ... + 'static as Trait>::CONST
```
is unambiguously a type too, but we don't know it until we see `'static`.
This syntax allows to construct fully ambiguous examples as well, e.g.
```rust
x<<y as z>::a
```
can be interpreted as both `((x << y) as z) > (::a)` and `x < (<y as z>::a)`. | C-enhancement,A-grammar,A-parser,P-low,T-lang | low | Critical |
263,981,307 | TypeScript | [typescript] dom definitions not up to date | _From @yukulele on October 5, 2017 12:7_
<!-- Do you have a question? Please ask it on http://stackoverflow.com/questions/tagged/vscode. -->
<!-- Use Help > Report Issues to prefill these. -->
- VSCode Version: 1.16.1
- OS Version: macOS Sierra 10.12.6
Steps to Reproduce:
* Create this code in typescript file
```typescript
const elm = document.createElement('main')
```
* `elm` is typed as `HTMLElement` instead of `HTMLMainElement`
`lib.dom.d.ts` is not up to date
how to update it without wait for vscode update ?
<!-- Launch with `code --disable-extensions` to check. -->
Reproduces without extensions: Yes
_Copied from original issue: Microsoft/vscode#35620_ | Bug,Help Wanted,Domain: lib.d.ts,VS Code Tracked,Effort: Casual | low | Major |
264,011,387 | go | proposal: spec: find a way to export uncased identifiers | https://github.com/golang/go/issues/5763#issue-51284151 observes “It is very strange to use, say Z成本 or Jぶつける as identifiers.” In that issue we discussed potentially changing the default export rule, but as of https://github.com/golang/go/issues/5763#issuecomment-333669811, which seemed to have general agreement, we decided against that.
Even so we do want to find a way to export uncased identifiers, or at least consider ways, in order to address the original observation.
This issue is for discussion of non-breaking ways to export uncased identifiers. | LanguageChange,Proposal,LanguageChangeReview | medium | Critical |
264,058,030 | youtube-dl | request support for http://embed.vidello.com/ | ## Please follow the guide below
- You will be asked some questions and requested to provide some information, please read them **carefully** and answer honestly
- Put an `x` into all the boxes [ ] relevant to your *issue* (like this: `[x]`)
- Use the *Preview* tab to see what your issue will actually look like
---
### Make sure you are using the *latest* version: run `youtube-dl --version` and ensure your version is *2017.10.07*. If it's not, read [this FAQ entry](https://github.com/rg3/youtube-dl/blob/master/README.md#how-do-i-update-youtube-dl) and update. Issues with outdated version will be rejected.
- [x] I've **verified** and **I assure** that I'm running youtube-dl **2017.10.07**
### Before submitting an *issue* make sure you have:
- [x] At least skimmed through the [README](https://github.com/rg3/youtube-dl/blob/master/README.md), **most notably** the [FAQ](https://github.com/rg3/youtube-dl#faq) and [BUGS](https://github.com/rg3/youtube-dl#bugs) sections
- [x] [Searched](https://github.com/rg3/youtube-dl/search?type=Issues) the bugtracker for similar issues including closed ones
### What is the purpose of your *issue*?
- [ ] Bug report (encountered problems with youtube-dl)
- [x] Site support request (request for adding support for a new site)
- [ ] Feature request (request for a new functionality)
- [ ] Question
- [ ] Other
---
### The following sections concretize particular purposed issues, you can erase any section (the contents between triple ---) not applicable to your *issue*
---
### If the purpose of this *issue* is a *bug report*, *site support request* or you are not completely sure provide the full verbose output as follows:
Add the `-v` flag to **your command line** you run youtube-dl with (`youtube-dl -v <your command line>`), copy the **whole** output and insert it here. It should look similar to one below (replace it with **your** log inserted between triple ```):
```
youtube-dl -v http://embed.vidello.com/36/ya8c4z5veuxyexfc/player.html
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['-v', 'http://embed.vidello.com/36/ya8c4z5veuxyexfc/player.html']
[debug] Encodings: locale cp1252, fs utf-8, out utf-8, pref cp1252
[debug] youtube-dl version 2017.10.07
[debug] Python version 3.6.1 - Windows-7-6.1.7601-SP1
[debug] exe versions: none
[debug] Proxy map: {}
[generic] player: Requesting header
WARNING: Falling back on generic information extractor.
[generic] player: Downloading webpage
[generic] player: Extracting information
ERROR: Unsupported URL: http://embed.vidello.com/36/ya8c4z5veuxyexfc/player.html
Traceback (most recent call last):
File "c:\users\work\appdata\local\programs\python\python36\lib\site-packages\youtube_dl\YoutubeDL.py", line 784, in ex
tract_info
ie_result = ie.extract(url)
File "c:\users\work\appdata\local\programs\python\python36\lib\site-packages\youtube_dl\extractor\common.py", line 434
, in extract
ie_result = self._real_extract(url)
File "c:\users\work\appdata\local\programs\python\python36\lib\site-packages\youtube_dl\extractor\generic.py", line 30
51, in _real_extract
raise UnsupportedError(url)
youtube_dl.utils.UnsupportedError: Unsupported URL: http://embed.vidello.com/36/ya8c4z5veuxyexfc/player.html
```
---
### If the purpose of this *issue* is a *site support request* please provide all kinds of example URLs support for which should be included (replace following example URLs by **yours**):
- Single video: http://embed.vidello.com/36/ya8c4z5veuxyexfc/player.html
- Single video: http://embed.vidello.com/36/ya8c4z5veuxyexfc/player.html
- Playlist:
Note that **youtube-dl does not support sites dedicated to [copyright infringement](https://github.com/rg3/youtube-dl#can-you-add-support-for-this-anime-video-site-or-site-which-shows-current-movies-for-free)**. In order for site support request to be accepted all provided example URLs should not violate any copyrights.
---
### Description of your *issue*, suggested solution and other information
Explanation of your *issue* in arbitrary form goes here. Please make sure the [description is worded well enough to be understood](https://github.com/rg3/youtube-dl#is-the-description-of-the-issue-itself-sufficient). Provide as much context and examples as possible.
If work on your *issue* requires account credentials please provide them or explain how one can obtain them.
hi youtube-dl team!
this is to kindly request to your team to support this url >> http://embed.vidello.com/, example is http://embed.vidello.com/36/ya8c4z5veuxyexfc/player.html
looking forward to your great support.
thank you youtube-dl team and more power!
respectfully yours,
az
| site-support-request | low | Critical |
264,073,495 | go | proposal: x/net/sctp: new package | # Background
This proposal will make easy to develop SCTP based applications such as HSS or MME in cellular networks.
I'd like to add this proposal to core library, because the one-to-one style SCTP interface on Linux is very similar to TCP interface. If we make an another package or add this to golang.org/x/net, it will make
large copy of code from `net` and `internal/poll` package.
# Proposal
Add one-to-one style SCTP support to net package.
* Support sctp/sctp4/sctp6 in net.Listen and net.Dial.
* Add 3 functions and 3 structs to net packages.
* structs
* SCTPAddr
* SCTPConn
* SCTPListener
* functions
* func DialSCTP(string, *SCTPAddr, *SCTPAddr) (*SCTPConn, error)
* func ListenSCTP(string, *SCTPAddr) (*SCTPListener, error)
* func ResolveSCTPAddr(string, string) (*SCTPAddr, error)
This proposal supports only one-to-one style interface with `SOCK_STREAM`. | Proposal | medium | Critical |
264,074,109 | go | cmd/link: loading c-shared into Go program crashes on Windows | ### What version of Go are you using (`go version`)?
go version devel +bb0bfd002a Tue Oct 10 01:02:27 2017 +0000 windows/amd64
### Does this issue reproduce with the latest release?
Only tip
### What operating system and processor architecture are you using (`go env`)?
```
set GOARCH=amd64
set GOBIN=
set GOEXE=.exe
set GOHOSTARCH=amd64
set GOHOSTOS=windows
set GOOS=windows
set GOPATH=c:/dev/go
set GORACE=
set GOROOT=c:\go
set GOTOOLDIR=c:\go\pkg\tool\windows_amd64
set GCCGO=gccgo
set CC=gcc
set GOGCCFLAGS=-m64 -mthreads -fmessage-length=0 -fdebug-prefix-map=C:\Users\mattn\AppData\Local\Temp\go-build049037059=/tmp/go-build -gno-record-gcc-switches
set CXX=g++
set CGO_ENABLED=1
set CGO_CFLAGS=-g -O2
set CGO_CPPFLAGS=
set CGO_CXXFLAGS=-g -O2
set CGO_FFLAGS=-g -O2
set CGO_LDFLAGS=-g -O2
set PKG_CONFIG=pkg-config
```
### What did you do?
foo.go
```go
package main
import "C"
import (
"fmt"
)
//export Foo
func Foo() {
fmt.Println("foo")
}
func main() {
}
```
creating foo.dll
```
go build -buildmode=c-shared -o foo.dll foo.go
```
call Foo in foo.dll
```go
package main
import (
"syscall"
)
func main() {
syscall.NewLazyDLL("foo.dll").NewProc("Foo").Call()
}
```
### What did you see instead?
output `foo`
### What did you expect to see?
panic
```
fatal error: unexpected signal during runtime execution
[signal 0xc0000005 code=0x0 addr=0xfffffffac5feddfe pc=0x6ae92064]
goroutine 1 [running]:
runtime.throw(0x6af45d8d, 0x2a)
c:/go/src/runtime/panic.go:616 +0x88 fp=0xc042033730 sp=0xc042033710 pc=0x6aea9398
runtime.sigpanic()
c:/go/src/runtime/signal_windows.go:155 +0x170 fp=0xc042033760 sp=0xc042033730 pc=0x6aeb9da0
runtime.heapBitsSetType(0xc042034020, 0x10, 0x10, 0x6af1f520)
c:/go/src/runtime/mbitmap.go:921 +0x544 fp=0xc0420337b8 sp=0xc042033760 pc=0x6ae92064
runtime.mallocgc(0x10, 0x6af1f520, 0x1, 0xc04200c2c0)
c:/go/src/runtime/malloc.go:740 +0x582 fp=0xc042033858 sp=0xc0420337b8 pc=0x6ae8f202
runtime.convT2Estring(0x6af1f520, 0xc0420338e8, 0x40, 0x6af52100)
c:/go/src/runtime/iface.go:357 +0x71 fp=0xc042033890 sp=0xc042033858 pc=0x6ae8d361
runtime.preprintpanics(0xc042033978)
c:/go/src/runtime/panic.go:402 +0xe6 fp=0xc042033908 sp=0xc042033890 pc=0x6aea8896
panic(0x6af26ee0, 0x6afb2ec0)
c:/go/src/runtime/panic.go:543 +0x41b fp=0xc0420339b0 sp=0xc042033908 pc=0x6aea8edb
runtime.panicmem()
c:/go/src/runtime/panic.go:63 +0x59 fp=0xc0420339d0 sp=0xc0420339b0 pc=0x6aea7bc9
runtime.sigpanic()
c:/go/src/runtime/signal_windows.go:161 +0x83 fp=0xc042033a00 sp=0xc0420339d0 pc=0x6aeb9cb3
os.(*File).write(0x0, 0xc04200e068, 0x4, 0x8, 0x0, 0x0, 0xc2034028)
c:/go/src/os/file_windows.go:224 +0x29 fp=0xc042033a48 sp=0xc042033a00 pc=0x6aeec0a9
os.(*File).Write(0x0, 0xc04200e068, 0x4, 0x8, 0x0, 0x0, 0x0)
c:/go/src/os/file.go:140 +0x73 fp=0xc042033ac0 sp=0xc042033a48 pc=0x6aeeb943
fmt.Fprintln(0x6af520a0, 0x0, 0xc042033ba8, 0x1, 0x1, 0x4b3600, 0xc042033c48, 0x3)
c:/go/src/fmt/print.go:255 +0x89 fp=0xc042033b28 sp=0xc042033ac0 pc=0x6af08109
fmt.Println(0xc042033ba8, 0x1, 0x1, 0x0, 0x4b3600, 0xc042033c90)
c:/go/src/fmt/print.go:264 +0x5e fp=0xc042033b78 sp=0xc042033b28 pc=0x6af081ce
main.Foo()
C:/dev/go-sandbox/dll/dll.go:10 +0x64 fp=0xc042033bc8 sp=0xc042033b78 pc=0x6af0f334
main._cgoexpwrap_e001a1a948c6_Foo()
b002/_cgo_gotypes.go:45 +0x27 fp=0xc042033bd8 sp=0xc042033bc8 pc=0x6af0f2b7
runtime.call32(0x0, 0x22fc90, 0x22fe0f, 0x0)
c:/go/src/runtime/asm_amd64.s:509 +0x42 fp=0xc042033c08 sp=0xc042033bd8 pc=0x6aecde12
runtime.cgocallbackg1(0x0)
c:/go/src/runtime/cgocall.go:316 +0x1aa fp=0xc042033c88 sp=0xc042033c08 pc=0x6ae82c0a
runtime.cgocallbackg(0x0)
c:/go/src/runtime/cgocall.go:194 +0xef fp=0xc042033cf0 sp=0xc042033c88 pc=0x6ae829bf
runtime.cgocallback_gofunc(0x402150, 0x44ac60, 0x4b3948, 0xc042033d50)
c:/go/src/runtime/asm_amd64.s:762 +0xaf fp=0xc042033d10 sp=0xc042033cf0 pc=0x6aecf46f
goroutine 1 [runnable, locked to thread]:
syscall.Syscall(0x775b54e0, 0x3, 0x3, 0x1, 0x0, 0x0, 0x0, 0x0)
c:/go/src/runtime/syscall_windows.go:171 +0xf9
syscall.SetHandleInformation(0x3, 0x1, 0x30, 0x6af31900)
c:/go/src/syscall/zsyscall_windows.go:936 +0x6b
syscall.CloseOnExec(0x3)
c:/go/src/syscall/exec_windows.go:125 +0x3b
syscall.getStdHandle(0xfffffffffffffff6, 0x6af41949)
c:/go/src/syscall/syscall_windows.go:370 +0x45
```
As far as I can see, panic occur at `(*File) write(b []byte)`
```go
func (f *File) write(b []byte) (n int, err error) {
n, err = f.pfd.Write(b)
runtime.KeepAlive(f)
return n, err
}
```
Maybe, poller in dll is conflicting with main process.
| OS-Windows,NeedsInvestigation,compiler/runtime | high | Critical |
264,096,662 | rust | Cannot infer type in test from section 12.4 of rust book v2 | Hello everyone!
I'm learning Rust now using [this book](https://doc.rust-lang.org/book/second-edition/) and faced strange(as for me) error on section 12.4 when running tests.
[You can reproduce a bug with next snippet of code](https://play.rust-lang.org/?version=nightly&mode=debug&edition=2018&gist=908e4dd2100ae4b4df7f85e5dc405cc5)
```
pub fn search<'a> (q: &str, text: &'a str) -> Vec<&'a str> {
text.lines().filter(|line| line.contains(q)).collect()
}
#[cfg(test)]
mod tests {
use super::*;
#[test]
fn it_should_compile_but_it_doesnt () {
let q = "queryABCD";
let t = "text with query";
assert_eq!( vec![], search(q, t) );
}
}
// error[E0282]: type annotations needed
// --> src/lib.rs:13:21
// |
// 13 | assert_eq!( vec![], search(q, t) );
// | ^^^^^^ cannot infer type for `T`
// |
// = note: this error originates in a macro outside of the current crate
```
However, it's fairly obvious that compiler knows the type annotation that must be infered from vec![] macro. Next snippet makes it clear
```
pub fn search<'a> (q: &str, text: &'a str) -> Vec<&'a str> {
text.lines().filter(|line| line.contains(q)).collect()
}
#[cfg(test)]
mod tests {
use super::*;
#[test]
fn it_should_compile_but_it_doesnt () {
let q = "queryABCD";
let t = "text with query";
assert_eq!( 333, search(q, t) );
}
}
// error[E0277]: the trait bound `{integer}: std::cmp::PartialEq<std::vec::Vec<&str>>` is not satisfied
// --> src/lib.rs:13:9
// |
// 13 | assert_eq!( 333, search(q, t) );
// | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ can't compare `{integer}` with `std::vec::Vec<&str>`
// |
// = help: the trait `std::cmp::PartialEq<std::vec::Vec<&str>>` is not implemented for `{integer}`
// = note: this error originates in a macro outside of the current crate
```
I think it's a bug but not sure since I'm novice in rust. I tried different toolchains, specifically 1.16, 1.18, 1.20(stable) and nightly and got the same result. | C-enhancement,A-diagnostics,T-compiler,A-inference,D-newcomer-roadblock | low | Critical |
264,159,426 | TypeScript | Declaration merging: remove function overloads? | Let's say one of the libs come with a function like this:
```ts
// library:
declare module 'example' {
interface Animal { }
export function sayHello(a: Animal);
}
```
I want to narrow down the type to just `Dog`. This is my module augmentation:
```ts
// app.ts
declare module 'example' {
interface Dog extends Animal { }
export function sayHello(a: Dog);
}
```
This merges the declarations to two function overloads:
```
sayHello(a: Dog);
sayHello(a: Animal);
```
I'd like to remove the generic `Animal` one to get stricter type checking of my code.
I couldn't find if this has been discussed before but I would find it useful quite often. Some examples would be:
- `express` headers (string by default, I'd use union of string literals)
- `yargs` args (I'd limit them to args specific to my app)
| Suggestion,Awaiting More Feedback | medium | Major |
264,177,295 | opencv | OpenCL native_sqrt precision | ##### System information (version)
- OpenCV => 3.3.0-dev
- Internal OpenCL 1.2 implementation.
##### Detailed description
In OpenCL the accuracy of builtin functions with the `native_` prefix is implementation defined.
The improc corner.cl file is using `native_sqrt` in two places, line [219](https://github.com/opencv/opencv/blob/master/modules/imgproc/src/opencl/corner.cl#L219) & [211](https://github.com/opencv/opencv/blob/master/modules/imgproc/src/opencl/corner.cl#L211).
Because of this I'm seeing fails with an internal OpenCL implementation of the OCL_Imgproc/CornerMinEigenVal.Mat subtests in the opencv_test_imgproc unit tests due to not precise enough results. Changing native_sqrt to sqrt resolves this issue.
If there is a hard precision requirement here we shouldn't be using native builtins as it's not portable.
| category: imgproc,category: ocl | low | Minor |
264,214,099 | godot | GridMap Enhancement: Make use of Bresenham's line algorithm for drawing | In pixel art applications, it is common to use a line algorithm draw a line between the last two sampled input points. For example, if I move my mouse too fast for godot to handle on my PC, I get a handful of discrete tile placements. Using Bresenham's line algorithm, these would instead be solid lines of tiles.
This was drawn with a single left-click and quick drag:
But it really should be something like this instead:
This is a common feature of raster based drawing applications, and I believe most voxel packages also.
(at least MagicaVoxel and Qubicle). It would vastly improve the usability and general "feel" of the GridMap editor
Algorithm for reference: https://en.wikipedia.org/wiki/Bresenham%27s_line_algorithm | enhancement,topic:editor,usability | low | Major |
264,252,182 | youtube-dl | Can't watch CBC The National newscast video | ## Please follow the guide below
- You will be asked some questions and requested to provide some information, please read them **carefully** and answer honestly
- Put an `x` into all the boxes [ ] relevant to your *issue* (like this: `[x]`)
- Use the *Preview* tab to see what your issue will actually look like
---
### Make sure you are using the *latest* version: run `youtube-dl --version` and ensure your version is *2017.10.07*. If it's not, read [this FAQ entry](https://github.com/rg3/youtube-dl/blob/master/README.md#how-do-i-update-youtube-dl) and update. Issues with outdated version will be rejected.
- [x] I've **verified** and **I assure** that I'm running youtube-dl **2017.10.07**
### Before submitting an *issue* make sure you have:
- [x] At least skimmed through the [README](https://github.com/rg3/youtube-dl/blob/master/README.md), **most notably** the [FAQ](https://github.com/rg3/youtube-dl#faq) and [BUGS](https://github.com/rg3/youtube-dl#bugs) sections
- [x] [Searched](https://github.com/rg3/youtube-dl/search?type=Issues) the bugtracker for similar issues including closed ones
### What is the purpose of your *issue*?
- [x] Bug report (encountered problems with youtube-dl)
- [x] Site support request (request for adding support for a new site)
- [ ] Feature request (request for a new functionality)
- [ ] Question
- [ ] Other
---
### The following sections concretize particular purposed issues, you can erase any section (the contents between triple ---) not applicable to your *issue*
---
### If the purpose of this *issue* is a *bug report*, *site support request* or you are not completely sure provide the full verbose output as follows:
Add the `-v` flag to **your command line** you run youtube-dl with (`youtube-dl -v <your command line>`), copy the **whole** output and insert it here. It should look similar to one below (replace it with **your** log inserted between triple ```):
```
./youtube-dl -v http://www.cbc.ca/player/play/1067218499691 >>error.txt 2>>error.txt
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: [u'-v', u'http://www.cbc.ca/player/play/1067218499691']
[debug] Encodings: locale ISO-8859-1, fs ISO-8859-1, out None, pref ISO-8859-1
[debug] youtube-dl version 2017.10.07
[debug] Python version 2.7.13 - Linux-4.9.9-i686-with-glibc2.0
[debug] exe versions: none
[debug] Proxy map: {}
[ThePlatform] 1067218499691: Downloading SMIL data
[ThePlatform] 1067218499691: Checking video URL
Traceback (most recent call last):
File "/usr/lib/python2.7/runpy.py", line 174, in _run_module_as_main
"__main__", fname, loader, pkg_name)
File "/usr/lib/python2.7/runpy.py", line 72, in _run_code
exec code in run_globals
File "./youtube-dl/__main__.py", line 19, in <module>
File "./youtube-dl/youtube_dl/__init__.py", line 465, in main
File "./youtube-dl/youtube_dl/__init__.py", line 455, in _real_main
File "./youtube-dl/youtube_dl/YoutubeDL.py", line 1980, in download
File "./youtube-dl/youtube_dl/YoutubeDL.py", line 795, in extract_info
File "./youtube-dl/youtube_dl/YoutubeDL.py", line 861, in process_ie_result
File "./youtube-dl/youtube_dl/YoutubeDL.py", line 784, in extract_info
File "./youtube-dl/youtube_dl/extractor/common.py", line 434, in extract
File "./youtube-dl/youtube_dl/extractor/theplatform.py", line 295, in _real_extract
File "./youtube-dl/youtube_dl/extractor/theplatform.py", line 49, in _extract_theplatform_smil
File "./youtube-dl/youtube_dl/extractor/common.py", line 1666, in _parse_smil_formats
File "./youtube-dl/youtube_dl/extractor/common.py", line 1170, in _is_valid_url
File "./youtube-dl/youtube_dl/extractor/common.py", line 503, in _request_webpage
File "./youtube-dl/youtube_dl/YoutubeDL.py", line 2190, in urlopen
File "/usr/lib/python2.7/urllib2.py", line 429, in open
response = self._open(req, data)
File "/usr/lib/python2.7/urllib2.py", line 447, in _open
'_open', req)
File "/usr/lib/python2.7/urllib2.py", line 407, in _call_chain
result = func(*args)
File "./youtube-dl/youtube_dl/utils.py", line 1086, in https_open
File "/usr/lib/python2.7/urllib2.py", line 1195, in do_open
h.request(req.get_method(), req.get_selector(), req.data, headers)
File "/usr/lib/python2.7/httplib.py", line 1042, in request
self._send_request(method, url, body, headers)
File "/usr/lib/python2.7/httplib.py", line 1082, in _send_request
self.endheaders(body)
File "/usr/lib/python2.7/httplib.py", line 1038, in endheaders
self._send_output(message_body)
File "/usr/lib/python2.7/httplib.py", line 882, in _send_output
self.send(msg)
File "/usr/lib/python2.7/httplib.py", line 844, in send
self.connect()
File "/usr/lib/python2.7/httplib.py", line 1263, in connect
server_hostname=server_hostname)
File "/usr/lib/python2.7/ssl.py", line 363, in wrap_socket
_context=self)
File "/usr/lib/python2.7/ssl.py", line 611, in __init__
self.do_handshake()
File "/usr/lib/python2.7/ssl.py", line 848, in do_handshake
match_hostname(self.getpeercert(), self.server_hostname)
File "/usr/lib/python2.7/ssl.py", line 282, in match_hostname
% (hostname, ', '.join(map(repr, dnsnames))))
ssl.CertificateError: hostname u'progressive.cbc.ca' doesn't match either of '*.akamaized.net', '*.akamaihd-staging.net', '*.akamaized-staging.net', '*.akamaihd.net', 'a248.e.akamai.net'
...
<end of log>
```
---
### If the purpose of this *issue* is a *site support request* please provide all kinds of example URLs support for which should be included (replace following example URLs by **yours**):
- Single video: http://www.cbc.ca/player/play/1067218499691
Note that **youtube-dl does not support sites dedicated to [copyright infringement](https://github.com/rg3/youtube-dl#can-you-add-support-for-this-anime-video-site-or-site-which-shows-current-movies-for-free)**. In order for site support request to be accepted all provided example URLs should not violate any copyrights.
---
### Description of your *issue*, suggested solution and other information
Explanation of your *issue* in arbitrary form goes here. Please make sure the [description is worded well enough to be understood](https://github.com/rg3/youtube-dl#is-the-description-of-the-issue-itself-sufficient). Provide as much context and examples as possible.
If work on your *issue* requires account credentials please provide them or explain how one can obtain them.
I used to be able to watch videos from http://www.cbc.ca/player/, but for a few weeks now I have not been able to, and I always get error messages such as the one I've reported here. | bug | low | Critical |
264,260,315 | rust | link-dead-code does not include symbols for unused inlined functions | Consider a file `x.rs`:
```rust
#[inline]
fn gggg() {}
fn main() {}
```
The symbol `gggg` is not included in the compiled binary (tested with `rustc -C link-dead-code x.rs && nm x | grep gggg`). If the inline attribute is removed, the symbol is included. | C-enhancement,A-codegen,T-compiler | low | Major |
264,313,234 | flutter | Stepper should change height with textScaleFactor | When a the textScaleFactor changes, the step names will scale, and so the height of the steps should change. | framework,f: material design,a: accessibility,a: fidelity,c: proposal,P2,team-design,triaged-design | low | Minor |
264,349,808 | vscode | [folding] allow defining folding regions in user settings and/or extensions | Would it be able to abstract out the language specifics and treat code folding similar to how `emmet` handles it...
i.e.
```
"emmet.includeLanguages": {
"php": "html",
"blade": "html",
"javascript": "javascriptreact"
},
```
So for code folding it could be...
```
"codeFolding.IncludeLanguages": {
"php": {
"openTag": "//#region",
"closeTage": "//#endregion"
},
...etc...
}
```
This is just an off the cuff idea for implementing this and I'm not sure that it's possible, but the goal would be to not be dependent on the language plugin developers to implement the feature. | feature-request,editor-folding | medium | Critical |
264,365,282 | flutter | Document how to create bullet list and numbering list using RichText Widget with indent and outdent | Is there a way to add bullet list or numbering list in the RichText widget? How about indent and outdent?
Thanks. | framework,d: api docs,a: typography,has reproducible steps,P2,found in release: 3.3,found in release: 3.7,team-framework,triaged-framework | low | Major |
264,452,797 | go | net/http: go server behind nginx require read entire body before writing response | ### What version of Go are you using (`go version`)?
go version go1.9.1 windows/amd64
### Does this issue reproduce with the latest release?
YES
### What operating system and processor architecture are you using (`go env`)?
set GOARCH=amd64
set GOBIN=
set GOEXE=.exe
set GOHOSTARCH=amd64
set GOHOSTOS=windows
set GOOS=windows
set GOPATH=E:\Documents\Develop\WorkSpace\Go
set GORACE=
set GOROOT=E:\Documents\Develop\RunTime\Go\x64
set GOTOOLDIR=E:\Documents\Develop\RunTime\Go\x64\pkg\tool\windows_amd64
set GCCGO=gccgo
set CC=gcc
set GOGCCFLAGS=-m64 -mthreads -fmessage-length=0 -fdebug-prefix-map=D:\CommonSoft\MSYS2\tmp\go-build716063943=/tmp/go-build -gno-record-gcc-switches
set CXX=g++
set CGO_ENABLED=1
set CGO_CFLAGS=-g -O2
set CGO_CPPFLAGS=
set CGO_CXXFLAGS=-g -O2
set CGO_FFLAGS=-g -O2
set CGO_LDFLAGS=-g -O2
set PKG_CONFIG=pkg-config
### What did you do?
1. Start Go Server
````
package main
import (
"log"
"net/http"
)
func main() {
MockServer()
}
func MockServer() {
http.HandleFunc("/", func(w http.ResponseWriter, req *http.Request) {
w.WriteHeader(400)
w.Write([]byte("HELLO"))
})
log.Fatal(http.ListenAndServe(":8080", nil))
}
````
2. Start nginx
nginx.conf
````
upstream nodes {
server 127.0.0.1:8080 max_fails=0;
}
server {
listen 80;
server_name ~.*;
access_log logs/access.log main;
error_log logs/error.log;
client_max_body_size 1024m;
client_body_buffer_size 512K;
proxy_next_upstream error timeout non_idempotent;
client_body_temp_path client_body_temp_path 3 2;
location / {
proxy_http_version 1.1;
proxy_pass http://nodes;
break;
}
}
````
3. Make A POST Request
````
package main
import (
"bytes"
"fmt"
"log"
"net/http"
"net/http/httputil"
)
func main() {
resp, err := http.Post("http://127.0.0.1:80", "application/octet-stream", bytes.NewReader(make([]byte, 1024*1024)))
if err != nil {
log.Fatal(err)
}
defer resp.Body.Close()
respBuf, err := httputil.DumpResponse(resp, true)
if err != nil {
log.Fatal(err)
}
fmt.Println(string(respBuf))
}
````
### What did you expect to see?
Response:
````
HTTP/1.1 400 Bad Request
Content-Length: 5
Connection: keep-alive
Content-Type: text/plain; charset=utf-8
Date: Wed, 11 Oct 2017 04:16:07 GMT
Server: nginx/1.13.0
HELLO
````
### What did you see instead?
Resp:
````
HTTP/1.1 502 Bad Gateway
Content-Length: 173
Connection: keep-alive
Content-Type: text/html
Date: Wed, 11 Oct 2017 04:02:37 GMT
Server: nginx/1.13.0
<html>
<head><title>502 Bad Gateway</title></head>
<body bgcolor="white">
<center><h1>502 Bad Gateway</h1></center>
<hr><center>nginx/1.13.0</center>
</body>
````
Nginx Error:
````
2017/10/11 12:02:37 [error] 11956#2392: *49 WSASend() failed (10054: An existing connection was forcibly closed by the remote host) while sending request to upstream, client: 127.0.0.1, server: ~.*, request: "POST / HTTP/1.1", upstream: "http://127.0.0.1:8080/", host: "127.0.0.1:80"
````
If i send request without body or the server side read all the body, response will be as expected.
It seems golang should ensure that a FIN packet is sent before any RST packet.
https://trac.nginx.org/nginx/ticket/1037 | help wanted,NeedsInvestigation | medium | Critical |
264,503,197 | go | crypto/elliptic: ECDSA parameters should be validated. | ### What version of Go are you using (`go version`)?
`go1.9.1 linux/amd64`
### What operating system and processor architecture are you using (`go env`)?
GOHOSTARCH="amd64" (intel)
GOHOSTOS="linux"
### What did you do?
Playground link:
https://play.golang.org/p/Ldd8fvrP5m
I've been playing around with Go's ECDSA package and have noticed a few problems, none of practical security relevance, since those problems have premises unlikely to happen in real use cases. (I actually discussed those on Go's security mailing list a long time ago.)
The problems are all about parameters validation in ECDSA.
### What did you expect to see?
The Go's implementation should conform to the [DSS standard](http://nvlpubs.nist.gov/nistpubs/FIPS/NIST.FIPS.186-4.pdf), notably by performing verification that the point used are actually on the curve at hand.
But if the checks I discuss here are considered not worthy, a workaround like what has been done for DSA might be good to completely avoid any risk of infinite loops.
I would expect a method to check the validity of the provided parameters, as per [FIPS 186-4](http://nvlpubs.nist.gov/nistpubs/FIPS/NIST.FIPS.186-4.pdf) sections [3.1](http://nvlpubs.nist.gov/nistpubs/FIPS/NIST.FIPS.186-4.pdf#page=20) and [3.3](http://nvlpubs.nist.gov/nistpubs/FIPS/NIST.FIPS.186-4.pdf#page=22).
### What did you see instead?
- No check is performed on the curve's points used to see whether they are on the curve or not, so it is possible to use a point not even on the curve. (Whether this is dangerous for ECDSA has not been studied.)
Note that checks that points are on the curve are performed in the TLS package (where they are important, because of the invalid curve attack) thanks to the [elliptic.Unmarshal](https://golang.org/pkg/crypto/elliptic/#Unmarshal) method.
- I also see that no check is performed on the private parameter "d" to verify if it's within well defined bounds. So it is possible to sign using a 0 value, which is not among the correct boundaries which are [1, n-1] (even if the value 1 does not make much sense from a security point of view).
There is an example on the playground linked where this causes an infinite loop when signing an null hash with a null private integer.
The value 0 is simply invalid as a private integer and should be rejected.
- There are no "validation" methods for keys, this could be a good way to avoid performing such checks at each signature/verification: by providing a method users are supposed to use to validate the keys.
Such checks are important in my opinion and are part of the so-called "defense in depth" we want to generally ensure in a crypto library.
What are your opinions on these topics? | help wanted,NeedsFix | low | Minor |
264,574,059 | youtube-dl | Vevo playlist fail | ## Please follow the guide below
- You will be asked some questions and requested to provide some information, please read them **carefully** and answer honestly
- Put an `x` into all the boxes [ ] relevant to your *issue* (like this: `[x]`)
- Use the *Preview* tab to see what your issue will actually look like
---
### Make sure you are using the *latest* version: run `youtube-dl --version` and ensure your version is *2017.10.07*. If it's not, read [this FAQ entry](https://github.com/rg3/youtube-dl/blob/master/README.md#how-do-i-update-youtube-dl) and update. Issues with outdated version will be rejected.
- [x] I've **verified** and **I assure** that I'm running youtube-dl **2017.10.07**
### Before submitting an *issue* make sure you have:
- [x] At least skimmed through the [README](https://github.com/rg3/youtube-dl/blob/master/README.md), **most notably** the [FAQ](https://github.com/rg3/youtube-dl#faq) and [BUGS](https://github.com/rg3/youtube-dl#bugs) sections
- [x] [Searched](https://github.com/rg3/youtube-dl/search?type=Issues) the bugtracker for similar issues including closed ones
### What is the purpose of your *issue*?
- [x] Bug report (encountered problems with youtube-dl)
- [ ] Site support request (request for adding support for a new site)
- [ ] Feature request (request for a new functionality)
- [ ] Question
- [ ] Other
---
### The following sections concretize particular purposed issues, you can erase any section (the contents between triple ---) not applicable to your *issue*
---
### If the purpose of this *issue* is a *bug report*, *site support request* or you are not completely sure provide the full verbose output as follows:
Add the `-v` flag to **your command line** you run youtube-dl with (`youtube-dl -v <your command line>`), copy the **whole** output and insert it here. It should look similar to one below (replace it with **your** log inserted between triple ```):
`PS X:\DevelopTemp\YouTubeDownloader\YouTubeDL> .\youtube-dl.exe https://www.vevo.com/watch/playlist/0f741525-88c9-4e2c-b
349-2624f2bd23eb -v
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['https://www.vevo.com/watch/playlist/0f741525-88c9-4e2c-b349-2624f2bd23eb', '-v']
[debug] Encodings: locale cp1252, fs mbcs, out cp850, pref cp1252
[debug] youtube-dl version 2017.10.07
[debug] Python version 3.4.4 - Windows-10-10.0.15063
[debug] exe versions: none
[debug] Proxy map: {}
[VevoPlaylist] 0f741525-88c9-4e2c-b349-2624f2bd23eb: Downloading webpage
ERROR: An extractor error has occurred. (caused by KeyError('playlists',)); please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type youtube-dl -U to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
Traceback (most recent call last):
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpqocja9go\build\youtube_dl\extractor\common.py", line 434, in extract
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpqocja9go\build\youtube_dl\extractor\vevo.py", line 359, in _real_extract
KeyError: 'playlists'
Traceback (most recent call last):
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpqocja9go\build\youtube_dl\extractor\common.py", line 434, in extract
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpqocja9go\build\youtube_dl\extractor\vevo.py", line 359, in _real_extract
KeyError: 'playlists'
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpqocja9go\build\youtube_dl\YoutubeDL.py", line 784, in extract_info
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpqocja9go\build\youtube_dl\extractor\common.py", line 447, in extract
youtube_dl.utils.ExtractorError: An extractor error has occurred. (caused by KeyError('playlists',)); please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type youtube-dl -U to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.`
[debug] System config: []
[debug] User config: []
[debug] Command-line args: [u'-v', u'http://www.youtube.com/watch?v=BaW_jenozKcj']
[debug] Encodings: locale cp1251, fs mbcs, out cp866, pref cp1251
[debug] youtube-dl version 2017.10.07
[debug] Python version 2.7.11 - Windows-2003Server-5.2.3790-SP2
[debug] exe versions: ffmpeg N-75573-g1d0487f, ffprobe N-75573-g1d0487f, rtmpdump 2.4
[debug] Proxy map: {}
...
<end of log>
```
---
### If the purpose of this *issue* is a *site support request* please provide all kinds of example URLs support for which should be included (replace following example URLs by **yours**):
- Single video: https://www.youtube.com/watch?v=BaW_jenozKc
- Single video: https://youtu.be/BaW_jenozKc
- Playlist: https://www.youtube.com/playlist?list=PL4lCao7KL_QFVb7Iudeipvc2BCavECqzc
Note that **youtube-dl does not support sites dedicated to [copyright infringement](https://github.com/rg3/youtube-dl#can-you-add-support-for-this-anime-video-site-or-site-which-shows-current-movies-for-free)**. In order for site support request to be accepted all provided example URLs should not violate any copyrights.
---
### Description of your *issue*, suggested solution and other information
Explanation of your *issue* in arbitrary form goes here. Please make sure the [description is worded well enough to be understood](https://github.com/rg3/youtube-dl#is-the-description-of-the-issue-itself-sufficient). Provide as much context and examples as possible.
If work on your *issue* requires account credentials please provide them or explain how one can obtain them.
| geo-restricted | low | Critical |
264,637,370 | godot | SpotLights with shadows enabled cause artifacts to appear in the editor (`3.x` only) | **Operating system or device, Godot version, GPU Model and driver (if graphics related):** Windows 10, Godot Git https://github.com/godotengine/godot/commit/409e58e67abde4e7af6e43b32c23338e119377fb, NVIDIA
SpotLights with shadows enabled cause shading artifacts to appear in the editor, see the screenshots below. Tweaking the shadow bias doesn't seem to have any effect on the artifacts.
**Narrow spotlight with shadows (broken):**
**Wide spotlight with shadows (broken):**
SpotLights with an angle above 90° look broken with shadows enabled, but they work with shadows disabled.
**Ultrawide spotlight with shadows (broken):**
**Ultrawide spotlight without shadows (working):**
This bug doesn't seem to affect running projects.
**SpotLight in running project (working):**
 | bug,topic:rendering,confirmed,topic:3d | low | Critical |
264,659,633 | angular | Overriding 'panmove' Hammer event for multitouch does not work | ## I'm submitting a...
<!-- Check one of the following options with "x" -->
<pre><code>
[ ] Regression (a behavior that used to work and stopped working in a new release)
[x] Bug report <!-- Please search GitHub for a similar issue or PR before submitting -->
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question
</code></pre>
## Current behavior
<!-- Describe how the issue manifests. -->
When extending HammerGestureConfig, overriding 'panmove' event with a 'pointers' parameter higher than 1 does not work. 2+ fingers moves for 'panmove' are not regnonized and do not trigger any events. I want to inform that I had no issue overriding other parameters for other events.
## Expected behavior
When setting 'pointers' parameter at 2 for 'panmove' event, application shall trigger 'panmove' event when panning with 2 fingers .
## Minimal reproduction of the problem with instructions
Here is an example to test on a touchscreen:
http://plnkr.co/edit/c9yfRNag7TqSKmX8QMww?p=preview
## What is the motivation / use case for changing the behavior?
User want to be able to pan over a touchscreen with more than one finger.
## Environment
<pre><code>
Angular version: 4.3.0
<!-- Check whether this is still an issue in the most recent Angular version -->
Browser:
- [x] Chrome (desktop) version XX
- [ ] Chrome (Android) version XX
- [ ] Chrome (iOS) version XX
- [ ] Firefox version XX
- [ ] Safari (desktop) version XX
- [ ] Safari (iOS) version XX
- [ ] IE version XX
- [ ] Edge version XX
For Tooling issues:
- Node version: XX <!-- run `node --version` -->
- Platform: <!-- Mac, Linux, Windows -->
Others:
<!-- Anything else relevant? Operating system version, IDE, package manager, HTTP server, ... -->
Using Chrome on a tablet (Windows or Android).
</code></pre>
| type: bug/fix,freq1: low,area: core,core: event listeners,P3 | low | Critical |
264,672,423 | rust | [incremental] skip type-checking | This is a kind of meta-bug aimed at skipping type-checking, which is (to some extent) the "holy grail" of incremental compilation. This bug only contains a list of issues and a task breakdown. [For background on the general approach we have in mind, see this gist.](https://gist.github.com/nikomatsakis/6e9fae5319be49c70e7efbe67c09fc1a)
Substeps:
- [x] https://github.com/rust-lang/rust/issues/45210: Introduce the `ensure` operation [first described here](https://github.com/rust-lang/rust/issues/45156#issuecomment-335537847) and use it on the `typeck_tables_of` invocations. -- @theotherjimmy is [on it](https://github.com/rust-lang/rust/issues/45208#issuecomment-335896368)
- [x] https://github.com/rust-lang/rust/issues/45214: Isolate the "used trait imports" part of typeck tables into a distinct query
- [ ] Enable serialization and deserialization of incremental results, at least for some types.
- In particular, we will need to support serializing and re-loading `Vec<DefId>`. It wouldn't hurt to support `()` while we're at it.
- This is likely best tackled by @michaelwoerister or @alexcrichton, but that may not be the case.
Ultimately, all of the the uses of `typeck_tables_of` must be analyzed and eliminated. These uses are listed here in order to mine for producing more subtasks. =)
<details><p>
- [ ] `src/librustc_passes/consts.rs:142: self.tables = self.tcx.typeck_tables_of(item_def_id);`
- [x] `src/librustc_typeck/check_unused.rs:69: let tables = tcx.typeck_tables_of(item_def_id);`
- [ ] `src/librustc_save_analysis/dump_visitor.rs:109: let tables = self.tcx.typeck_tables_of(item_def_id);`
- [ ] `src/librustc_typeck/collect.rs:1155: return tcx.typeck_tables_of(def_id).node_id_to_type(hir_id);`
- [ ] `src/librustc_typeck/collect.rs:1192: tcx.typeck_tables_of(owner).node_id_to_type(hir_id)`
- [ ] `src/librustc_typeck/collect.rs:1244: tcx.typeck_tables_of(def_id).closure_tys()[hir_id]`
- [ ] `src/librustc_privacy/lib.rs:503: replace(tables, tcx.typeck_tables_of(def_id))`
- [ ] `src/librustc_const_eval/pattern.rs:606: self.tables = self.tcx.typeck_tables_of(def_id);`
- [ ] `src/librustc_const_eval/eval.rs:381: tables: tcx.typeck_tables_of(def_id),`
- [ ] `src/librustc_const_eval/eval.rs:770: let tables = tcx.typeck_tables_of(def_id);`
- [ ] `src/librustc_borrowck/borrowck/mod.rs:100: let tables = tcx.typeck_tables_of(owner_def_id);`
- [ ] `src/librustc_borrowck/borrowck/mod.rs:198: let tables = tcx.typeck_tables_of(owner_def_id);`
- [ ] `src/librustc/cfg/construct.rs:57: let tables = tcx.typeck_tables_of(owner_def_id);`
- [x] `src/librustc/ty/mod.rs:2108: self.typeck_tables_of(self.hir.body_owner_def_id(body))`
- not a direct user, see calls of `body_tables()` below
- [ ] `src/librustc/middle/intrinsicck.rs:136: let tables = self.tcx.typeck_tables_of(owner_def_id);`
- [ ] `src/librustc_typeck/check/mod.rs:734: tcx.typeck_tables_of(body_owner_def_id);`
- [ ] `src/librustc_typeck/check/mod.rs:756: tcx.typeck_tables_of(def_id).generator_sigs()[hir_id].map(|s| ty::Binder(s))`
- [ ] `src/librustc_typeck/check/mod.rs:764: tcx.typeck_tables_of(def_id).closure_kinds()[hir_id].0`
- [ ] `src/librustc_typeck/check/mod.rs:857: return tcx.typeck_tables_of(outer_def_id);`
- [ ] `src/librustc_typeck/check/mod.rs:1152: tcx.typeck_tables_of(tcx.hir.local_def_id(it.id));`
- [ ] `src/librustc_typeck/check/mod.rs:1574: tcx.typeck_tables_of(tcx.hir.local_def_id(e.node_id));`
- [ ] `src/librustc_mir/transform/generator.rs:712: let interior = *tcx.typeck_tables_of(def_id).generator_interiors().get(hir_id).unwrap();`
- [ ] `src/librustc_mir/hair/cx/mod.rs:96: tables: tcx.typeck_tables_of(src_def_id),`
- [ ] `src/tools/clippy/clippy_lints/src/consts.rs:302: tables: self.tcx.typeck_tables_of(def_id),`
- [ ] `src/librustc_privacy/lib.rs:518: let orig_tables = replace(&mut self.tables, self.tcx.body_tables(body));`
- [ ] `src/librustc_privacy/lib.rs:672: let orig_tables = replace(&mut self.tables, self.tcx.body_tables(body));`
- [ ] `src/librustc_driver/pretty.rs:505: self.tables.set(self.tcx.body_tables(id));`
- [ ] `src/librustc_const_eval/check_match.rs:53: tables: self.tcx.body_tables(b),`
- [ ] `src/librustc/lint/context.rs:636: self.tables = self.tcx.body_tables(body);`
- [ ] `src/librustc/lint/context.rs:696: self.tables = self.tcx.body_tables(body_id);`
- [ ] `src/librustc/middle/liveness.rs:530: let tables = ir.tcx.body_tables(body);`
- [ ] `src/librustc/middle/reachable.rs:101: self.tables = self.tcx.body_tables(body);`
- [ ] `src/librustc/middle/dead.rs:218: self.tables = self.tcx.body_tables(body);`
- [ ] `src/librustc_mir/build/mod.rs:106: let gen_ty = tcx.body_tables(body_id).node_id_to_type(fn_hir_id);`
- [ ] `src/librustc_mir/build/mod.rs:247: let closure_ty = tcx.body_tables(body_id).node_id_to_type(closure_expr_hir_id);`
- [ ] `src/tools/clippy/clippy_lints/src/attrs.rs:172: is_relevant_expr(tcx, tcx.body_tables(eid), &tcx.hir.body(eid).value)`
- [ ] `src/tools/clippy/clippy_lints/src/attrs.rs:180: ImplItemKind::Method(_, eid) => is_relevant_expr(tcx, tcx.body_tables(eid), &tcx.hir.body(eid).value),`
- [ ] `src/tools/clippy/clippy_lints/src/attrs.rs:189: is_relevant_expr(tcx, tcx.body_tables(eid), &tcx.hir.body(eid).value)`
- [ ] `src/tools/clippy/clippy_lints/src/functions.rs:154: let tables = cx.tcx.body_tables(body.id());`
</p></details> | C-enhancement,I-compiletime,T-compiler,A-incr-comp | low | Critical |
264,688,956 | pytorch | BN slows down double-backprop enormously | When using a ConvNet without batchnorm layers, the optimization with a gradient penalty takes approximately 5 times longer than without the gradient penalty. This ratio 1:5 corresponds exactly to the ratio expected by the double-backpropagation algorithm. But when the ConvNet has batchnorm layers, this ratio goes up to approximately 1:30.
Note that these ratios are independent of the number of layers.
For instance, the output of the following code with 3 conv layers (n_layers=3) gives:
> No BN and no lambda
> epoch 0 loss 2.30 time 9
> No BN and with lambda
> epoch 0 loss 2.30 time 50
> With BN and no lambda
> epoch 0 loss 2.30 time 12
> With BN and with lambda
> epoch 0 loss 2.30 time 305
```python
import torch
import torch.nn as nn
import torch.nn.functional as F
import torch.backends.cudnn as cudnn
from torch.autograd import Variable
import time
class Identity(nn.Module):
def __init__(self, *args):
super(Identity, self).__init__()
def forward(self, x):
return x
class Layer(nn.Module):
def __init__(self, in_planes, planes, BN):
super(Layer, self).__init__()
self.bn = BN(planes)
self.conv = nn.Conv2d(in_planes, planes, 3, padding=1, bias=False)
self.act = nn.ReLU()
def forward(self, x):
return self.act(self.bn(self.conv(x)))
class Net(nn.Module):
def __init__(self, BN, n_layers=3):
super(Net, self).__init__()
self.in_planes = 3
self.layers = self._make_layers(Layer, 64, n_layers, BN)
self.linear = nn.Linear(64, 10)
def _make_layers(self, block, planes, num_blocks, BN):
strides = [1] + [1] * (num_blocks - 1)
layers = []
for stride in strides:
layers.append(block(self.in_planes, planes, BN))
self.in_planes = planes
return nn.Sequential(*layers)
def forward(self, x):
out = self.layers(x)
out = F.avg_pool2d(out, out.size(2))
out = out.view(out.size(0), -1)
return self.linear(out)
def do_epoch(net, criterion, optimizer, lam):
net.train()
aggr_loss = count = 0
for _ in range(1000):
inputs = Variable(torch.cuda.FloatTensor(128,3,32,32).normal_(), requires_grad=True)
targets = Variable(torch.LongTensor(128).random_(0, 10).cuda())
outputs = net(inputs)
optimizer.zero_grad()
loss = criterion(outputs, targets)
loss.backward(create_graph=(lam > 0))
# gradient penalty
if lam > 0:
gpenalty = inputs.grad.view(inputs.size(0), -1).add(1e-5).norm(1, 1).mean()
(lam * gpenalty).backward()
optimizer.step()
count += 1
aggr_loss += loss.data[0]
return aggr_loss / count
def main(net, lam):
net.cuda()
cudnn.benchmark = True
criterion = torch.nn.CrossEntropyLoss()
criterion.cuda()
optimizer = torch.optim.SGD(net.parameters(), lr=.001, momentum=0.9)
for epoch in range(1):
time_start = time.time()
loss = do_epoch(net, criterion, optimizer, lam)
print("epoch %2d loss %.2f time %d" % (epoch, loss, time.time()-time_start))
n_layers = 3
BN = Identity
print('No BN and no lambda')
main(Net(BN, n_layers), 0.)
print('No BN and with lambda')
main(Net(BN, n_layers), .001)
BN = nn.BatchNorm2d
print('With BN and no lambda')
main(Net(BN, n_layers), 0.)
print('With BN and with lambda')
main(Net(BN, n_layers), .001)
```
cc @VitalyFedyunin @ngimel | module: performance,triaged | low | Major |
264,693,367 | rust | make easier/possible to detect `derive` attributes after expansion | In the spirit of #44942, it would be nice if the `missing_debug_implementations` and `missing_copy_implementations` lints suggested adding a derive attribute (in the case where one does not already exist) or adding `Debug` (respectively `Copy`) to the list of traits in the derive attribute (in the case where it already exists). (This mostly for the sake of RLS and [other tools](https://github.com/killercup/rustfix), but the span highlighting is pretty, too.) But while the lints (obviously, necessarily) know how to look up whether the trait has been implemented, it's not clear how to make them detect an existing derive attribute (and its span): `cx.tcx.get_attrs` doesn't work because we apparently strip off the attribute during expansion ~~(it _looks_ like this happens twice, which is confusing: [1](https://github.com/rust-lang/rust/blob/c0d40a190/src/libsyntax/ext/expand.rs#L310-L311) [2](https://github.com/rust-lang/rust/blob/cbf5d39cca/src/libsyntax/ext/derive.rs#L25-L27))~~. But I can't modify the expansion code because I'm still not smart enough to understand it. | A-macros,T-compiler,C-feature-request | low | Critical |
264,756,827 | TypeScript | require.main.require imports do not work | <!-- BUGS: Please use this template. -->
<!-- QUESTIONS: This is not a general support forum! Ask Qs at http://stackoverflow.com/questions/tagged/typescript -->
<!-- SUGGESTIONS: See https://github.com/Microsoft/TypeScript-wiki/blob/master/Writing-Good-Design-Proposals.md -->
<!-- Please try to reproduce the issue with `typescript@next`. It may have already been fixed. -->
**TypeScript Version:** 2.6.0-dev.201xxxxx
From: https://github.com/Microsoft/vscode/issues/35489#issuecomment-335689358
**Code**
```ts
const myModule = require.main.require('./file.js')
```
Run go to definition on `myModule`
**Expected behavior:**
Goes to defintion of `myModule`
**Actual behavior:**
Nothing happens. Looks like we don't understand `require.main.require` style imports
| Suggestion,Awaiting More Feedback,VS Code Tracked,Domain: JavaScript | low | Critical |
264,765,998 | rust | Big performance problem with closed intervals looping | In my code I've essentially stopped using loops with ... (intervals closed on the right, recently written with the syntax ..=) because they give performance problems. This is a simple example that shows the problem:
```rust
#![feature(inclusive_range_syntax)]
#![allow(private_no_mangle_fns)]
#[inline(never)]
#[no_mangle]
fn foo1(n: u64) -> u64 {
let mut count = 0;
for _ in 0 .. n {
for j in (0 .. n + 1).rev() {
count += j;
}
}
count
}
#[inline(never)]
#[no_mangle]
fn foo2(n: u64) -> u64 {
let mut count = 0;
for _ in 0 .. n {
for j in (0 ..= n).rev() {
count += j;
}
}
count
}
fn main() {
let n: u64 = std::env::args().nth(1).unwrap().parse().unwrap();
let what: u32 = std::env::args().nth(2).unwrap().parse().unwrap();
match what {
1 => println!("{}", foo1(n)),
2 => println!("{}", foo2(n)),
_ => panic!(),
}
}
```
Compiled with the last Nightly:
```
rustc 1.22.0-nightly (d6d711dd8 2017-10-10)
binary: rustc
commit-hash: d6d711dd8f7ad5885294b8e1f0009a23dc1f8b1f
commit-date: 2017-10-10
host: x86_64-pc-windows-gnu
release: 1.22.0-nightly
LLVM version: 4.0
```
Compiled with:
`rustc -O test.rs`
Running it calling foo1 takes 0.02 seconds:
```
...>elaps test 100000 1
500005000000000
```
Running it calling foo2 takes about 13.65 seconds:
```
...>elaps test 100000 2
500005000000000
```
<details><summary>The asm I am seeing using "--emit asm"</summary>
```
foo1:
testq %rcx, %rcx
je .LBB5_1
movq %rcx, %r8
imulq %r8, %r8
leaq -1(%rcx), %rdx
movq %rcx, %rax
mulq %rdx
shldq $63, %rax, %rdx
subq %rdx, %r8
cmpq $3, %rcx
jbe .LBB5_3
movq %rcx, %rdx
andq $-4, %rdx
je .LBB5_3
movd %r8, %xmm0
pshufd $68, %xmm0, %xmm2
leaq -4(%rdx), %r9
movl %r9d, %eax
shrl $2, %eax
incl %eax
andq $3, %rax
je .LBB5_8
cmpq $-1, %rcx
pxor %xmm0, %xmm0
pxor %xmm3, %xmm3
je .LBB5_11
movdqa %xmm2, %xmm3
.LBB5_11:
negq %rax
xorl %r10d, %r10d
pxor %xmm1, %xmm1
.p2align 4, 0x90
.LBB5_12:
paddq %xmm3, %xmm0
paddq %xmm3, %xmm1
addq $4, %r10
incq %rax
jne .LBB5_12
jmp .LBB5_13
.LBB5_3:
xorl %eax, %eax
xorl %edx, %edx
.LBB5_4:
xorl %r9d, %r9d
cmpq $-1, %rcx
cmoveq %r9, %r8
.p2align 4, 0x90
.LBB5_5:
incq %rdx
addq %r8, %rax
cmpq %rcx, %rdx
jb .LBB5_5
.LBB5_19:
retq
.LBB5_1:
xorl %eax, %eax
retq
.LBB5_8:
xorl %r10d, %r10d
pxor %xmm0, %xmm0
pxor %xmm1, %xmm1
.LBB5_13:
cmpq $12, %r9
jb .LBB5_18
cmpq $-1, %rcx
pxor %xmm3, %xmm3
je .LBB5_16
movdqa %xmm2, %xmm3
.LBB5_16:
movq %rdx, %rax
subq %r10, %rax
.p2align 4, 0x90
.LBB5_17:
paddq %xmm3, %xmm0
paddq %xmm3, %xmm1
paddq %xmm3, %xmm0
paddq %xmm3, %xmm1
paddq %xmm3, %xmm0
paddq %xmm3, %xmm1
paddq %xmm3, %xmm0
paddq %xmm3, %xmm1
addq $-16, %rax
jne .LBB5_17
.LBB5_18:
paddq %xmm1, %xmm0
pshufd $78, %xmm0, %xmm1
paddq %xmm0, %xmm1
movd %xmm1, %rax
cmpq %rcx, %rdx
jne .LBB5_4
jmp .LBB5_19
foo2:
pushq %rsi
pushq %rdi
pushq %rbx
testq %rcx, %rcx
je .LBB6_1
testb $1, %cl
jne .LBB6_4
xorl %eax, %eax
xorl %r8d, %r8d
cmpq $1, %rcx
jne .LBB6_11
jmp .LBB6_23
.LBB6_1:
xorl %eax, %eax
jmp .LBB6_23
.LBB6_4:
xorl %r8d, %r8d
movq $-1, %r9
xorl %r10d, %r10d
movq %rcx, %r11
xorl %eax, %eax
jmp .LBB6_5
.p2align 4, 0x90
.LBB6_8:
addq %r11, %rax
movq %rdi, %r10
movq %rdx, %r11
.LBB6_5:
cmpq %r11, %r10
movl $1, %esi
cmovbq %r9, %rsi
cmoveq %r8, %rsi
testq %rsi, %rsi
movl $1, %edi
movl $0, %edx
je .LBB6_8
cmpq $-1, %rsi
jne .LBB6_9
leaq -1(%r11), %rdx
movq %r10, %rdi
jmp .LBB6_8
.LBB6_9:
movl $1, %r8d
cmpq $1, %rcx
je .LBB6_23
.LBB6_11:
xorl %r9d, %r9d
movq $-1, %r10
.p2align 4, 0x90
.LBB6_12:
xorl %r11d, %r11d
movq %rcx, %rdx
jmp .LBB6_13
.p2align 4, 0x90
.LBB6_16:
addq %rdx, %rax
movq %rbx, %r11
movq %rsi, %rdx
.LBB6_13:
cmpq %rdx, %r11
movl $1, %edi
cmovbq %r10, %rdi
cmoveq %r9, %rdi
testq %rdi, %rdi
movl $1, %ebx
movl $0, %esi
je .LBB6_16
cmpq $-1, %rdi
jne .LBB6_17
leaq -1(%rdx), %rsi
movq %r11, %rbx
jmp .LBB6_16
.p2align 4, 0x90
.LBB6_17:
addq $2, %r8
xorl %r11d, %r11d
movq %rcx, %rdx
jmp .LBB6_18
.p2align 4, 0x90
.LBB6_21:
addq %rdx, %rax
movq %rbx, %r11
movq %rsi, %rdx
.LBB6_18:
cmpq %rdx, %r11
movl $1, %edi
cmovbq %r10, %rdi
cmoveq %r9, %rdi
testq %rdi, %rdi
movl $1, %ebx
movl $0, %esi
je .LBB6_21
cmpq $-1, %rdi
jne .LBB6_22
leaq -1(%rdx), %rsi
movq %r11, %rbx
jmp .LBB6_21
.p2align 4, 0x90
.LBB6_22:
cmpq %rcx, %r8
jb .LBB6_12
.LBB6_23:
popq %rbx
popq %rdi
popq %rsi
retq
```
</details> | I-slow,C-enhancement,T-compiler,C-optimization | medium | Major |
264,812,360 | kubernetes | CRI: clarify optional fields in all structures | Towards https://github.com/kubernetes-incubator/cri-tools/issues/151 and https://github.com/kubernetes-incubator/cri-tools/pull/152, we need to clarify the optional fields for all structures in CRI.
| kind/cleanup,sig/node,lifecycle/frozen,triage/needs-information | low | Minor |
264,879,636 | go | runtime: crash on Plan 9 since CL 46033 | ```
#!watchflakes
post <- goos == "plan9" && log ~ `fatal error: unexpected signal` && (log ~ `&\s*os\.StartProcess` || log ~ `^\s*runtime\.newm1`)
```
Since the runtime.LockOSThread change in CL [46033](https://golang.org/cl/46033), Go programs are crashing on Plan 9 when running commands with os/exec.
```
fatal error: unexpected signal during runtime execution
[signal sys: trap: fault read code=0x0 addr=0x0 pc=0x5ef]
runtime stack:
runtime.throw(0x36dca9, 0x2a)
/tmp/workdir/go/src/runtime/panic.go:616 +0x6a
runtime.sigpanic()
/tmp/workdir/go/src/runtime/os_plan9.go:79 +0x240
goroutine 1 [chan receive]:
syscall.startProcess(0x1087b310, 0x7, 0x1085db60, 0x4, 0x4, 0x107b7290, 0x10, 0x1087bc80, 0x107b7290)
/tmp/workdir/go/src/syscall/exec_plan9.go:514 +0xac
syscall.StartProcess(0x1087b310, 0x7, 0x1085db60, 0x4, 0x4, 0x107b7290, 0x2, 0x4, 0x0, 0x0)
/tmp/workdir/go/src/syscall/exec_plan9.go:525 +0x48
os.startProcess(0x1087b310, 0x7, 0x1085db60, 0x4, 0x4, 0x108a1c3c, 0x1084ca00, 0x3d, 0x3d)
/tmp/workdir/go/src/os/exec_plan9.go:33 +0x191
os.StartProcess(0x1087b310, 0x7, 0x1085db60, 0x4, 0x4, 0x108a1c3c, 0x0, 0x0, 0x41dbde8)
/tmp/workdir/go/src/os/exec.go:94 +0x48
os/exec.(*Cmd).Start(0x107c0580, 0x1086b201, 0x1076f7a0)
/tmp/workdir/go/src/os/exec/exec.go:363 +0x3c1
os/exec.(*Cmd).Run(0x107c0580, 0x1076f7a0, 0x1086b858)
/tmp/workdir/go/src/os/exec/exec.go:286 +0x20
os/exec.(*Cmd).CombinedOutput(0x107c0580, 0x1, 0x1, 0x1086b4a0, 0x3c, 0x3c)
/tmp/workdir/go/src/os/exec/exec.go:506 +0xed
cmd/go/internal/work.(*Builder).gccSupportsFlag(0x107e2230, 0x10766ea8, 0x1, 0x1, 0x3661a1, 0x18, 0x0)
/tmp/workdir/go/src/cmd/go/internal/work/build.go:3514 +0x437
cmd/go/internal/work.(*Builder).compilerCmd(0x107e2230, 0x35d3b1, 0x2, 0x35d387, 0x2, 0x35d2b1, 0x1, 0x0, 0x0, 0x302ce0, ...)
/tmp/workdir/go/src/cmd/go/internal/work/build.go:3454 +0x61b
cmd/go/internal/work.(*Builder).GccCmd(0x107e2230, 0x35d2b1, 0x1, 0x0, 0x0, 0x107c29a0, 0xb, 0x16)
/tmp/workdir/go/src/cmd/go/internal/work/build.go:3390 +0x64
cmd/go/internal/envcmd.MkEnv(0x1086a000, 0x3b, 0x3b)
/tmp/workdir/go/src/cmd/go/internal/envcmd/env.go:76 +0x31a
main.main()
/tmp/workdir/go/src/cmd/go/main.go:122 +0x479
goroutine 5 [syscall]:
os/signal.signal_recv(0x0, 0x0)
/tmp/workdir/go/src/runtime/sigqueue_plan9.go:109 +0x69
os/signal.loop()
/tmp/workdir/go/src/os/signal/signal_plan9.go:27 +0x19
created by os/signal.init.0
/tmp/workdir/go/src/os/signal/signal_plan9.go:22 +0x36
goroutine 13 [runnable, locked to thread]:
syscall.Close(0x7, 0x1085dbe0, 0x5)
/tmp/workdir/go/src/syscall/zsyscall_plan9_386.go:245 +0x86
syscall.forkExec(0x1087b310, 0x7, 0x1085db60, 0x4, 0x4, 0x107b7290, 0x108159d0, 0x0, 0x0)
/tmp/workdir/go/src/syscall/exec_plan9.go:434 +0x4c0
syscall.startProcess.func1(0x1087b310, 0x7, 0x1085db60, 0x4, 0x4, 0x107b7290, 0x1084f600)
/tmp/workdir/go/src/syscall/exec_plan9.go:488 +0x51
created by syscall.startProcess
/tmp/workdir/go/src/syscall/exec_plan9.go:484 +0x80
2017/10/11 15:05:51 Failed: exit status: 'go 2462: 2'
```
See https://build.golang.org/log/c14eefc1c70d14ad2d0f768ff9f13222fa8d435c | help wanted,OS-Plan9,NeedsInvestigation,compiler/runtime | medium | Critical |
264,932,364 | angular | [Proposal] medatdata / extras property for AbstractControl | ## I'm submitting a...
<pre><code>
[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report <!-- Please search GitHub for a similar issue or PR before submitting -->
[x] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question
</code></pre>
## Current behavior
Currently there is no way to construct FormControl, FormGroup and FormArray and set metadata / extras info (ex. allowedValues etc.)
## Expected behavior
Possibility to set metadata / extras info
## What is the motivation / use case for changing the behavior?
Possibility to set metadata info for each specific control would be very helpful when writing forms. For example generating select options would looks like that:
```html
<label for="control1">Control 1</label>
<select id="control1" [formControl]="control1">
<option *ngFor="let option of control.metadata.allowedValues" [ngValue]="option">
{{option.someProp}}
</option>
</select>
<label for="control2">Control 2</label>
<select id="control2" [formControl]="control2">
<option *ngFor="let option of control.metadata.allowedValues" [ngValue]="option">
{{option.someProp}}
</option>
</select>
```
Or if you have a form which is table but not all cells are controls, let say in each row you have cell with id (it is not a control just value for the user):
```html
<table>
<thead>
<tr>
<th>...</th>
<th>...</th>
<th>...</th>
</tr>
</thead>
<tbody>
<tr *ngFor="let control of controls"
[formGroup]="control"
[attr.id]="control.metadata.id">
<td>{{control.metadata.id}}</td>
<td><input formControlName="child1"></td>
<td><input formControlName="child2"></td>
</tr>
</tbody>
</table>
```
And there may be many more usage examples
## Proposal API
Setting this new property should be possible by using `FormBuilder`, `FormControl`, `FormGroup` and `FormArray`:
* for `FormBuilder#group` pass as optional property in `extra` arg
* for `FormBuilder#array`, `FormGroup` and `FormArray` pass as 4th optional arg
* for `FormBuilder#control` and `FormControl` pass as optional property in `formState` arg
Example:
```typescript
formBuilder.group({
child1: {
value: null,
metadata: { allowedValues: ['A', 'B', 'C'] }
},
child2: ''
array: formBuilder.array([], null, null, {category: 'CUSTOMER_1'})
}, {
metadata: { id: 1253 }
})
``` | feature,state: Needs Design,area: forms,feature: under consideration | high | Critical |
265,003,721 | opencv | about icvGetQuadrangleHypotheses function skip holes | in icvGetQuadrangleHypotheses function,
there are following code:
if (hierarchy.at(idx)[3] != -1)
continue; // skip holes
but does it right?, how about change it like the following?
if (hierarchy.at(idx)[2] != -1)
continue; // skip holes
I can not figure out which is right?
https://docs.opencv.org/2.4/modules/imgproc/doc/structural_analysis_and_shape_descriptors.html?highlight=findcontours#findcontours | category: calib3d,RFC | low | Minor |
265,050,528 | You-Dont-Know-JS | Up & Running Ch2 Transpiling - use of (void 0) and confusing paragraph | In the example foo() function it's not clear why (void 0) was used when it appears "undefined" could be used with the same effect (at least that's what I've seen). "void" was very briefly mentioned earlier in the book but wasn't fully explained.
Re the paragraph:
"You may not have realized just from looking at the ES6 version that undefined is the only value that can't get explicitly passed in for a default-value parameter, but the transpiled code makes that much more clear."
This part: "can't get explicitly passed in for a default-value parameter" seems to be a contradiction, or at least ambiguous, is it:
1. undefined can't be passed into a function as an argumentr? (it can)
2. undefined can't be passed into a function that uses default parameter values? (it can)
3. undefined can't be written into a parameter as a default value? (it can)
Does it mean, in effect: "You can pass in "undefined" as an argument to a function, but if that function has a default parameter value that value will override undefined"?
| for second edition | low | Minor |
265,056,655 | TypeScript | Support @ts-ignore for specific errors | **TypeScript Version:** 2.6.0-dev.20171011
**Code**
```ts
function countDown(n: number): void {
switch (n) {
// @ts-ignore
case 1:
console.log("1");
// intentional fall through
case 0:
console.log("0");
}
}
```
**Expected behavior:**
Ability to make `ts-ignore` apply to the `--noFallthroughCasesInSwitch` error but not to other errors.
**Actual behavior:**
`case "1":` would also compile. | Suggestion,Revisit | high | Critical |
265,140,302 | youtube-dl | Fails to download truTV episode after MSO Auth appears to be successful | ## Please follow the guide below
- You will be asked some questions and requested to provide some information, please read them **carefully** and answer honestly
- Put an `x` into all the boxes [ ] relevant to your *issue* (like this: `[x]`)
- Use the *Preview* tab to see what your issue will actually look like
---
### Make sure you are using the *latest* version: run `youtube-dl --version` and ensure your version is *2017.10.12*. If it's not, read [this FAQ entry](https://github.com/rg3/youtube-dl/blob/master/README.md#how-do-i-update-youtube-dl) and update. Issues with outdated version will be rejected.
- [x] I've **verified** and **I assure** that I'm running youtube-dl **2017.10.12**
### Before submitting an *issue* make sure you have:
- [x] At least skimmed through the [README](https://github.com/rg3/youtube-dl/blob/master/README.md), **most notably** the [FAQ](https://github.com/rg3/youtube-dl#faq) and [BUGS](https://github.com/rg3/youtube-dl#bugs) sections
- [x] [Searched](https://github.com/rg3/youtube-dl/search?type=Issues) the bugtracker for similar issues including closed ones
### What is the purpose of your *issue*?
- [x] Bug report (encountered problems with youtube-dl)
- [ ] Site support request (request for adding support for a new site)
- [ ] Feature request (request for a new functionality)
- [ ] Question
- [ ] Other
---
### The following sections concretize particular purposed issues, you can erase any section (the contents between triple ---) not applicable to your *issue*
---
### If the purpose of this *issue* is a *bug report*, *site support request* or you are not completely sure provide the full verbose output as follows:
Add the `-v` flag to **your command line** you run youtube-dl with (`youtube-dl -v <your command line>`), copy the **whole** output and insert it here. It should look similar to one below (replace it with **your** log inserted between triple ```):
```
youtube-dl http://www.trutv.com/full-episodes/adam-ruins-everything/2124090/index.html --ap-mso wavebroadband --ap-username PRIVATE -v
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: [u'http://www.trutv.com/full-episodes/adam-ruins-everything/2124090/index.html', u'--ap-mso', u'wavebroadband', u'--ap-username', u'PRIVATE', u'-v']
Type TV provider account password and press [Return]:
[debug] Encodings: locale UTF-8, fs UTF-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2017.10.12
[debug] Python version 2.7.12 - Linux-4.4.26-gentoo-x86_64-Intel-R-_Core-TM-_i7-6700K_CPU_@_4.00GHz-with-gentoo-2.3
[debug] exe versions: ffmpeg 3.3.4, ffprobe 3.3.4, rtmpdump 2.4
[debug] Proxy map: {}
[TruTV] 2124090: Downloading webpage
[TruTV] Downloading XML
[TruTV] 2124090: Downloading Provider Redirect Page
[TruTV] 2124090: Downloading Provider Login Page
[TruTV] 2124090: Logging in
[TruTV] 2124090: Confirming Login
[TruTV] 2124090: Retrieving Session
ERROR: Unable to download webpage: HTTP Error 401: Unauthorized (caused by HTTPError()); please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see https://yt-dl.org/update on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
File "/usr/lib64/python2.7/site-packages/youtube_dl/extractor/common.py", line 503, in _request_webpage
return self._downloader.urlopen(url_or_request)
File "/usr/lib64/python2.7/site-packages/youtube_dl/YoutubeDL.py", line 2195, in urlopen
return self._opener.open(req, timeout=self._socket_timeout)
File "/usr/lib64/python2.7/urllib2.py", line 435, in open
response = meth(req, response)
File "/usr/lib64/python2.7/urllib2.py", line 548, in http_response
'http', request, response, code, msg, hdrs)
File "/usr/lib64/python2.7/urllib2.py", line 473, in error
return self._call_chain(*args)
File "/usr/lib64/python2.7/urllib2.py", line 407, in _call_chain
result = func(*args)
File "/usr/lib64/python2.7/urllib2.py", line 556, in http_error_default
raise HTTPError(req.get_full_url(), code, msg, hdrs, fp)
```
---
### Description of your *issue*, suggested solution and other information
When attempting to download the episode at http://www.trutv.com/full-episodes/adam-ruins-everything/2124090/index.html, an error appears after the MSO Auth appears to be successful. | tv-provider-account-needed | low | Critical |
265,141,958 | TypeScript | JSDoc-typed node modules require special configuration in consumers to be useful | It looks like an ongoing goal for TS is to recommend JSDoc as the recommended way to give type-checking to raw JS users. As a user I am not a huge fan of this approach but I'll try to be objective in this issue.
If I write a node module `js-lib` as raw javascript typed with jsdoc, it will appear as untyped to consumers of my module unless they specifically opt in to JS type checking.
Example:
```
+-js-lib
| +-index.js
| +-package.json
|
+-ts-consumer
+-index.ts
+-package.json
+-tsconfig.json
```
## js-lib/index.js
```js
/**
* @param {string} s
* @returns {number}
*/
module.exports = function test(s) { return parseInt(s) };
```
## js-lib/package.json
```json
{
"name": "js-lib",
"main": "index.js"
}
```
## ts-consumer/index.ts
```ts
import test = require('../js-lib');
// index.ts(1,23): error TS6143: Module '../js-lib' was resolved to '/Users/jarrad/src/personal/ts-test/lib/js-index.js', but '--allowJs' is not set.
import test = require('js-lib'); // after npm install ../js-lib
// index.ts(1,23): error TS7016: Could not find a declaration file for module 'lib'. '/Users/jarrad/src/personal/ts-test/lib/index.js' implicitly has an 'any' type.
// Try `npm install @types/lib` if it exists or add a new declaration (.d.ts) file containing `declare module 'lib';
test("test");
```
## ts-consumer/tsconfig.json
```js
{
"compilerOptions": {
"strict": true
}
}
```
It should be possible for me to make my `js-lib` usable to Typescript authors without them having to configure their own project with `allowJs` and `checkJs`.
| Suggestion,Needs Proposal | medium | Critical |
265,143,974 | react | Use the native `beforeinput` event if it's supported | **Do you want to request a *feature* or report a *bug*?**
Improvement.
**What is the current behavior?**
Right now, the synthetic `onBeforeInput` event is being created based on two other events:
- `textInput` when possible—which is in Webkit.
- `keypress` as a fallback.
But these days in Chrome, Safari and Opera the spec'd `beforeinput` event is available and actually fires. And when it does, it includes other [spec'd properties](https://developer.mozilla.org/en-US/docs/Web/API/InputEvent) which can be extremely helpful:
- `inputType` tells you whether the event is inserting text, replacing text, inserting a line break, etc.
- `getTargetRanges()` tells you where the input is taking place in the DOM.
Right now this information isn't exposed, because even if the browser supports `beforeinput`, it's not being checked for.
**What is the expected behavior?**
Instead React should treat `textInput` as a slightly-preferred fallback for native `beforeinput` support, but add `beforeinput` as the true goal. So we'd end up with a fallback stack of:
- `beforeinput`
- `textInput`
- `keypress`
Which guarantees that the `nativeEvent` will always be the most spec'd and have the most relevant information associated with it.
---
The `beforeinput` event's extra properties are critical in `contenteditable` situations, when you want to prevent the default browser behavior from firing but perform the logic on an internal model instead. (I'm looking to do this for [Slate](https://github.com/ianstormtaylor/slate).)
Without that extra information you have to fallback to hackier behavior—allowing the event to occur, trying to parse the DOM for what the change was, then re-rendering to remove it, etc. I want to avoid this on the more modern browsers, because it results in reduced performance.
---
There is another situation that this fixes, which is that spellcheck right now doesn't trigger React's `onBeforeInput` handler, even though modern browsers fire the `beforeinput` event, because it's not being listened for right now.
| Type: Feature Request,Component: DOM | high | Critical |
265,245,440 | kubernetes | Rand utility should use per-component source instead of a global source | Offshoot from https://github.com/kubernetes/kubernetes/pull/53720#issuecomment-336232742
Using a single global source is bad, as multiple goroutines can be in lock contention for the RNG (though ideally they could've used different sources).
Also a single RNG source can bottleneck throughput in such cases.
It's also worth thinking how much this is going to help? Maybe it's not that bad currently where each binary has its own source and IIUC it's apiserver that is mostly generating names and that is anyway a single sub-component doing that (I might be missing sth here).
cc @smarterclayton @kubernetes/sig-api-machinery-bugs | kind/bug,sig/api-machinery,lifecycle/frozen | low | Critical |
265,261,496 | nvm | Gemset Like Feature in NVM | #### What's the feature?
- Project based global packages.
#### What problem is the feature intended to solve?
- Lets say I have an `angular 2` project which was created and managed with `Angular CLI 1.0.0` and for some reason` That Angular CLI project` has been `updated to 2.0.0`. This updated packages do everything based on `Angular 4`, which is problem for our older project. So have these global CLI's based on project would help us manage that.
- Following article have also tried to explain this pain (https://www.sitepoint.com/solve-global-npm-module-dependency-problem/)
#### Is the absence of this feature blocking you or your team? If so, how?
- It is blocking us doing experiments on new packages/frameworks and also keep working on existing projects.
#### Is this feature similar to an existing feature in another tool?
- In RVM, you have Gemsets which help you achieve the same goal.
| feature requests | medium | Major |
265,270,488 | TypeScript | Proposal: delegateof | # delegateof Proposal
**delegate (noun)**
A person sent or authorized to represent others, in particular an elected representative sent to a conference.
___
## Motivation
A popular and widely applied practice for creating flexible and reusable object oriented code is **delegation**.
**Delegation** involves two objects handling a request: a receiving object(**delegator**) delegates operations to its **delegate**.
An example of this is the [Strategy Pattern](https://en.wikipedia.org/wiki/Strategy_pattern).
## Problem
In order for the delegate pattern to be successful, **the delegate must be able to have access to the same context as the delegator**.
While the **delegator** context can be passed to the **delegate** in the form of raw parameters (`delegateOperation(delegateRequiredParam1,delegateRequiredParam2,delegateRequiredParam3)`) this approach restricts the amount of responsibility that can be delegated in a nice, scalable way.
To remove such restriction, the **delegate** should receive a reference to the **delegator** object and have the possibility of accessing a wider interface than the one of a foreign caller.
**Example**
### Given
```typescript
class Player {
protected xPos: number;
protected yPos: number;
constructor(private movementStrategy: PlayerMovementStrategy) {
}
protected startAnimation(animationId: string) {
// Code to start an animation
}
protected setMovementStrategy(movementStrategy: PlayerMovementStrategy){
this.movementStrategy = movementStrategy;
}
move(direction: Direction) {
this.movementStrategy.move(this, direction);
}
}
class WalkingMovementStrategy implements PlayerMovementStrategy {
move(player: Player, direction: Direction) {
player.startAnimation('someWalkingAnimation');
switch (direction) {
case Direction.UP:
player.setMovementStrategy(flyingStrategy);
break;
case Direction.Right:
player.xPos = player.xPos + 1;
// Rest of cases
}
}
}
class FlyingMovementStrategy implements PlayerMovementStrategy {
move(player: Player, direction: Direction) {
player.startAnimation('flyingAnimation');
switch (direction) {
case Direction.Up:
player.yPos = player.yPos + 10;
break;
// Rest of cases
}
}
}
interface PlayerMovementStrategy {
move(player: Player, direction: Direction): void;
}
enum Direction {
Up,
Down,
Left,
Right,
}
```
### Then
```typescript
const coolPlayer = new Player(new WalkingMovementStrategy());
coolPlayer.move(Direction.Up);
```
```sh
Property startAnimation is protected an is only accessible within the class Player.
```
Things to note
1.
Changing the `startAnimation` member accessibility to public solves the problem but exposes a method intended for internal usage.
Same goes for the other attributes xPos, yPos.
2.
The delegate must change more than 1 thing of the delegator object, hence making returning a value to apply the changes possible but ugly.
Something like this
```typescript
const result = movementStrategy.move(player, direction);
console.log(result);
// { nextAnimation: 'walkingAnimation', newYPos : 2 }
```
And what about extensibility? What happens if a movement strategy wants to trigger multiple animations?
## Solution
Add the functionality: `objectA delegateof objectB`
### What does it do?
`delegateof` allows `objectA` to have access to the protected members of `objectB`.
### Example
```typescript
class Player{
constructor(private movementStrategy: PlayerMovementStrategy){}
protected startAnimation(animationId: string){
// start the animation
}
move(direction: Direction){
this.movementStrategy.move(this, direction);
}
}
class WalkingMovementStrategy delegateof Player implements PlayerMovementStrategy{
move(player: Player, direction: Direction){
// No member accesibility errors yay
player.startAnimation('yayAnimation');
}
}
```
### Closing thoughts
While the keyword suffices for the OOP style, I am not sure how could this be implemented for plain objects or if it should even be attempted to.
Example
```typescript
const playerMovementStrategy = {
move(player: Player, direction: Direction){
// How to make this work here... or do we even need this?
player.startAnimation('yayAnimation');
}
}
```
Eager to hear your thoughts on it,
Joel.
### Edit on member privacy
@andy-ms mentioned privacy as a concern. If we would like to retain the privacy of protected and private members we could introduce a new accessor `delegated` which functions as `protected` but allows classes which declare themselves as delegates of the class to be able to access the member.
```typescript
class Player{
constructor(private movementStrategy: PlayerMovementStrategy){}
delegated startAnimation(animationId: string){
// start the animation
}
move(direction: Direction){
this.movementStrategy.move(this, direction);
}
}
class WalkingMovementStrategy delegateof Player implements PlayerMovementStrategy{
move(player: Player, direction: Direction){
// No member accesibility errors ;-)
player.startAnimation('yayAnimation');
}
}
``` | Suggestion,In Discussion | low | Critical |
265,319,083 | rust | Improve rustdoc's Trait Implementations section by grouping by module | Right now, rustdoc's output for `std::option::Option` looks like this (as seen on https://doc.rust-lang.org/std/option/enum.Option.html):
This is pretty hard for me to read. I think this has been suggested before but hiding (or at least, minimizing) the trait methods makes this much easier to read:
This better but it's still hard to skim through because there's no ordering to the results (at least, that I can discern). If the trait impls were grouped by module, it would be much easier to skim:
Alphabetizing the modules and the trait impls would improve this even more. | T-rustdoc,C-enhancement | low | Minor |
265,350,811 | flutter | Updating an App on timezone or timezone definition changes | Currently Flutter apps are rebuilt when the device's locale setting is changed.
It's not clear how well we respond when the device's time zone changes or when time zone definitions change (which can actually happen).
| framework,engine,f: date/time picker,a: internationalization,has reproducible steps,P2,team-engine,triaged-engine,found in release: 3.19,found in release: 3.20 | low | Critical |
265,374,119 | angular | Feature Request: debounce in ngModelOptions | [ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report <!-- Please search GitHub for a similar issue or PR before submitting -->
[ x] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question
</code></pre>
## Current behavior
No support for `debounce` in `ngModelOptions`
## Expected behavior
Angular doesn't yet support `debounce` `ngModelOption` on inputs. I would like to know what is the logic behind not implementing the same with `blur`?
## Example usecase for debounce:
A text input like in Google docs which should save the typed text after 3 secs of no keypress after typing.
| feature,effort2: days,state: Needs Design,freq2: medium,area: forms,forms: ngModel,feature: under consideration | medium | Critical |
265,383,292 | vscode | Terminal should support workbench.fontAliasing | https://github.com/Microsoft/vscode/issues/2577
https://twitter.com/_developit/status/918488307968937984
| help wanted,feature-request,upstream,upstream-issue-linked,terminal-rendering | medium | Major |
265,383,499 | go | x/build: number of test failures | In lieu of an automated builder, I run the x/build tests in Travis CI. @andybons has fixed two problems with cmd/cl and with cloud.google.com depedencies, but this has revealed a number of underlying test failures:
```
--- FAIL: TestConnAgainstNetTest (2.03s)
revdial_test.go:236: warning: the revdial's SetWriteDeadline support is not complete; some tests involving write deadlines known to be flaky
--- PASS: TestConnAgainstNetTest/BasicIO (0.41s)
--- PASS: TestConnAgainstNetTest/PingPong (0.19s)
--- PASS: TestConnAgainstNetTest/RacyRead (0.34s)
--- FAIL: TestConnAgainstNetTest/RacyWrite (0.42s)
testing.go:610: race detected during execution of test
```
`TestCorpusCheck` causes the entire Go corpus to download to the test instance, which eventually runs out of memory.
```
2017/10/13 18:26:13 Downloading 9495471 bytes of https://maintner.golang.org/logs/27 ...
2017/10/13 18:26:13 wrote /home/travis/.cache/golang-maintner/0027.growing.mutlog
fatal error: runtime: out of memory
```
Also, we need to update the `go-github` version for the `gitmirror` Docker file, I believe; IsPullRequest was added very recently.
```
src/golang.org/x/build/maintner/github.go:802: d.b.IsPullRequest undefined (type *github.Issue has no field or method IsPullRequest)
Removing intermediate container 65ca938e2dcb
The command '/bin/sh -c go install golang.org/x/build/cmd/gitmirror' returned a non-zero code: 2
make: *** [build0] Error 2
```
| help wanted,Builders | low | Critical |
265,464,938 | rust | Lifetime errors for referenced objects when reference is moved are not clear | I believe there is room for improvement here:
```rust
use std::path::{Path,PathBuf};
use std::thread;
fn main() -> () {
let pb = PathBuf::from(".");
let p = Path::new(&pb);
thread::spawn(move|| {
println!("{:?}", p);
});
}
```
This is obviously not correct, since `p` depends on `pb` which may not live as long, now that `pb` has been moved to the thread's scope and shares its lifetime.
However, the error when compiling this is problematic, since it doesn't make it clear at all why this object's lifetime needs to be increased:
```rust
> rustc +nightly ./test.rs
error[E0597]: `pb` does not live long enough
--> ./test.rs:6:24
|
6 | let p = Path::new(&pb);
| ^^ does not live long enough
...
10 | }
| - borrowed value only lives until here
|
= note: borrowed value must be valid for the static lifetime...
error: aborting due to previous error
```
It's easy to imagine a case where it's not as simple to figure out what is going on (perhaps a chain of references, separated by hundreds of lines of code, that compiled just fine until one of these latter references was moved to spawn a thread, and suddenly the lifetime of a completely different variable in code that wasn't touched is throwing an error). | C-enhancement,A-diagnostics,A-lifetimes,T-compiler | low | Critical |
265,486,019 | rust | Refactor librustc_codegen_llvm for multiple codegen backends. | ~~[#50615] Rename `librustc_trans` to `librustc_codegen_llvm`.~~
~~Make `rustc_driver` either able to choose codegen backends, or even better, pass `rustc_codegen_llvm` to `rustc_driver` from `rustc-main`.
See also #45226.~~
Possible refactoring steps:
* ~~remove `SharedCrateContext`, use `TyCtxt`~~
* ~~rename `(Local)CrateContext` to `CodegenContext`, remove accessor methods~~
* [#52461] ~~merge `librustc_llvm` into `librustc_codegen_llvm`~~
* ~~pass `ValueRef` as `&'ll Value` instead, encode LLVM lifetimes in FFI signatures~~
* ~~use this technique for C++ objects that borrow others: https://github.com/rust-lang/rust/issues/43467#issuecomment-405808005~~
* use this technique for the `DI*` inheritance hierarchy: https://github.com/rust-lang/rust/issues/43467#issuecomment-399509319
* use `&'ll Module<'ll>`, `&'ll Value<'ll>`, `&'ll Type<'ll>` etc. to correctly model lifetime relationships (without an invariant lifetime parameter, very little is actually enforced)
* refer to [`cranelift`](https://github.com/CraneStation/cranelift) and [`llvm2cranelift`](https://github.com/sunfishcode/llvm2cranelift) for common Cranelift/LLVM builder APIs
* [#55627] ~~common tools used by SSA backends could be placed in `rustc_codegen_ssa`~~
* refactor `rustc_codegen_ssa` APIs to match Cranelift, leave LLVM second-class
* unaddressed comments from #55627 may be relevant here
* split the metadata, "optimize + generate machine code" (should it be called "`binemit`"?) and linking components, out of `rustc_codegen_ssa` | A-codegen,T-compiler,C-feature-request,A-cranelift,A-gcc | low | Minor |
265,495,929 | vscode | [html] JSON edit support inside HTML document / script tag with type="application/json" | There are scenarios where it is useful to embed JSON inside an html document, such as for the [amp-bind element](https://www.ampproject.org/docs/reference/components/amp-bind):
```html
<amp-state id="myAnimals">
<script type="application/json">
{
"dog": {
"imageUrl": "/img/dog.jpg",
"style": "greenBackground"
},
"cat": {
"imageUrl": "/img/cat.jpg",
"style": "redBackground"
}
}
</script>
</amp-state>
```
Providing syntax coloring / error checking would be very beneficial in these cases. | feature-request,html | medium | Critical |
265,504,890 | TypeScript | Suggestion: target specific runtimes instead of JS versions | First advantage is target to browser is native for user than target to js version. Don't need to know what each browser support.
Second is ts can transpilate more effective. Some browser can have partially support of next standard. Ts can transpilate unsupported features only.
| Suggestion,Awaiting More Feedback | high | Critical |
265,507,064 | go | cmd/link: making sense of HeadType | The linker makes extensive use of HeadType. It does not make much sense to me.
When used as a value, it is very close to meaning `GOOS`. One exception is both "android" and "linux" are represented as "Hlinux", but besides that they are equivalent.
When used as a flag to the linker, `-H`, it is the value of `GOOS`, plus the potential value "windowsgui", which is treated as "windows" except it sets a global linker variable `windowsgui` to true. The linker is also receiving the `GOOS` environment variable used by the compiler (and all other tools) to make their OS decision.
Proposal:
- Leave the `-H` flag alone, as other build systems may depend on it.
- Check when the linker starts that GOOS and `-H` match.
- Convert any OS-specific conditions in the linker to using GOOS.
- Convert the HeadType enumeration into:
```
const (
Unknown HeadType = iota
ELF
MachO
Plan9
PE
PEGUI
)
```
- Replace the `IsELF` global variable with `ctxt.HeadType == objabi.ELF` instead.
- Replace `windowsgui` with `ctxt.HeadType == objabi.PEGUI`.
Thoughts?
cc @ianlancetaylor | NeedsFix,compiler/runtime | low | Minor |
265,508,116 | angular | Enter animation doesn't work with tracked ngFor | <!--
PLEASE HELP US PROCESS GITHUB ISSUES FASTER BY PROVIDING THE FOLLOWING INFORMATION.
ISSUES MISSING IMPORTANT INFORMATION MAY BE CLOSED WITHOUT INVESTIGATION.
-->
## I'm submitting a...
<!-- Check one of the following options with "x" -->
<pre><code>
[ ] Regression (a behavior that used to work and stopped working in a new release)
[x] Bug report <!-- Please search GitHub for a similar issue or PR before submitting -->
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question
</code></pre>
## Current behavior
<!-- Describe how the issue manifests. -->
This template markup for a chatlike collection of messages
<div fxFlexFill fxLayout="column">
<div class="messages" fxFlex fxLayout="column-reverse">
<div *ngFor="let message of messages | async; trackBy identify" class="message" fxFlex="0 0 auto"
[@flyInOut]="'in'"
[ngClass]="{own: message.author == userId, other: message.author != userId}">
<span>{{message.text}}</span>
</div>
</div>
<div class="input">
<mat-form-field class="textfield">
<input matInput placeholder="Nachricht" [formControl]="messageControl">
<button mat-icon-button matSuffix [disabled]="messageControl.invalid" (click)="sendMessage()">
<mat-icon svgIcon="send"></mat-icon>
</button>
</mat-form-field>
</div>
</div>
With this animation defined
animations: [
trigger('flyInOut', [
state('in', style({transform: 'translateX(0)'})),
transition('void => *', [
style({transform: 'translateX(-100%)'}),
animate(100),
]),
transition('* => void', [
animate(100, style({transform: 'translateX(100%)'})),
]),
]),
],
Results in the top element flying in while the new text is displayed at the bottom.
## Expected behavior
<!-- Describe what the desired behavior would be. -->
The new element is animated.
## Minimal reproduction of the problem with instructions
<!--
For bug reports please provide the *STEPS TO REPRODUCE* and if possible a *MINIMAL DEMO* of the problem via
https://plnkr.co or similar (you can use this template as a starting point: http://plnkr.co/edit/tpl:AvJOMERrnz94ekVua0u5).
-->
Animate `:enter` on something that adds items to the lists beginning.
## Environment
<pre><code>
@angular/cli: 1.4.5
node: 8.2.1
os: darwin x64
@angular/animations: 4.4.4
@angular/cdk: 2.0.0-beta.12
@angular/common: 4.4.4
@angular/compiler: 4.4.4
@angular/core: 4.4.4
@angular/flex-layout: 2.0.0-beta.9
@angular/forms: 4.4.4
@angular/http: 4.4.4
@angular/material: 2.0.0-beta.12
@angular/platform-browser: 4.4.4
@angular/platform-browser-dynamic: 4.4.4
@angular/router: 4.4.4
@angular/cli: 1.4.5
@angular/compiler-cli: 4.4.4
@angular/language-service: 4.4.4
typescript: 2.5.3
Browser:
- [x] Chrome (desktop) version 61.0.3163.100
- [ ] Chrome (Android) version XX
- [ ] Chrome (iOS) version XX
- [ ] Firefox version XX
- [ ] Safari (desktop) version XX
- [ ] Safari (iOS) version XX
- [ ] IE version XX
- [ ] Edge version XX
Others:
<!-- Anything else relevant? Operating system version, IDE, package manager, HTTP server, ... -->
</code></pre>
| type: bug/fix,area: animations,freq2: medium,P3 | low | Critical |
265,510,839 | go | crypto/tls: implement OCSP Must-Staple | A bit over a year ago, someone created an issue to add support for RFC 7633 TLS Feature Extension into `crypto/tls` but it was closed by @agl because he felt it was premature and that OCSP stapling wasn't really supported as a client in Go (not sure if that has changed?).
See #13074
It's been more than a year so I'm creating this issue to see what he thinks of it now. | help wanted,Proposal-Accepted,NeedsFix,Proposal-Crypto | low | Major |
265,526,090 | rust | Better Integrate MIR dump in `rustc_mir::util::liveness` into the wider dump infrastructure | Opening this so it doesn't get lost.
In the WG-compiler-nll gitter, @nikomatsakis mentioned that we should possibly update [liveness.rs](https://github.com/rust-lang/rust/blob/ec016f80cf725a9c8a613cdcd2ac97588d5f9af2/src/librustc_mir/util/liveness.rs#L180) so that it uses the infrastructure from #45013. | C-enhancement,T-compiler,A-MIR | low | Minor |
265,536,132 | flutter | Unstructured JSON API | A while ago while noodling around I wrote the following class. I'm posting it here for us to consider if we want to expose this or something like it in the framework.
```dart
// Copyright 2017 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
@proxy
class Json {
factory Json(dynamic input) {
if (input is Json)
return wrap(input._value);
return wrap(input);
}
factory Json.list(List<dynamic> input) {
return new Json.raw(input.map<Json>(wrap).toList());
}
// (This differs from "real" JSON in that we don't allow duplicate keys.)
factory Json.map(Map<dynamic, dynamic> input) {
final Map<String, Json> values = <String, Json>{};
input.forEach((dynamic key, dynamic value) {
key = key.toString();
assert(!values.containsKey(key), 'Json.map keys must be unique strings');
values[key] = wrap(value);
});
return new Json.raw(values);
}
const Json.raw(this._value);
final dynamic _value;
static Json wrap(dynamic value) {
if (value == null) {
return const Json.raw(null);
} else if (value is num) {
return new Json.raw(value.toDouble());
} else if (value is List) {
return new Json.list(value);
} else if (value is Map) {
return new Json.map(value);
} else if (value == true) {
return const Json.raw(true);
} else if (value == false) {
return const Json.raw(false);
} else if (value is Json) {
return value;
}
return new Json.raw(value.toString());
}
dynamic unwrap() {
if (_value is Map) {
final Map<String, dynamic> values = <String, dynamic>{};
_value.forEach((String key, Json value) {
values[key] = value.unwrap();
});
return values;
} else if (_value is List) {
return _value.map<dynamic>((Json value) => value.unwrap()).toList();
} else {
return _value;
}
}
double toDouble() => _value as double;
bool toBoolean() => _value as bool;
@override
String toString() => _value.toString();
Type get valueType => _value.runtimeType;
String toJson() {
// insert JSON serializer here
throw new Exception('not implemented');
}
dynamic operator [](dynamic key) {
return _value[key];
}
void operator []=(dynamic key, dynamic value) {
_value[key] = wrap(value);
}
@override
dynamic noSuchMethod(Invocation invocation) {
if (invocation.isGetter)
return this[_symbolName(invocation.memberName)];
if (invocation.isSetter)
return this[_symbolName(invocation.memberName)] = invocation.positionalArguments[0];
return super.noSuchMethod(invocation);
}
// Workaround for https://github.com/dart-lang/sdk/issues/28372
String _symbolName(Symbol symbol) {
// WARNING: Assumes a fixed format for Symbol.toString which is *not*
// guaranteed anywhere.
final String s = '$symbol';
return s.substring(8, s.length - 2);
}
bool operator <(dynamic other) {
if (other.runtimeType != Json)
return _value < other;
return _value < other._value;
}
bool operator <=(dynamic other) {
if (other.runtimeType != Json)
return _value <= other;
return _value <= other._value;
}
bool operator >(dynamic other) {
if (other.runtimeType != Json)
return _value > other;
return _value > other._value;
}
bool operator >=(dynamic other) {
if (other.runtimeType != Json)
return _value >= other;
return _value >= other._value;
}
dynamic operator -(dynamic other) {
if (other.runtimeType != Json)
return _value - other;
return _value - other._value;
}
dynamic operator +(dynamic other) {
if (other.runtimeType != Json)
return _value + other;
return _value + other._value;
}
dynamic operator /(dynamic other) {
if (other.runtimeType != Json)
return _value / other;
return _value / other._value;
}
dynamic operator ~/(dynamic other) {
if (other.runtimeType != Json)
return _value ~/ other;
return _value ~/ other._value;
}
dynamic operator *(dynamic other) {
if (other.runtimeType != Json)
return _value * other;
return _value * other._value;
}
dynamic operator %(dynamic other) {
if (other.runtimeType != Json)
return _value % other;
return _value % other._value;
}
dynamic operator |(dynamic other) {
if (other.runtimeType != Json)
return _value | other;
return _value | other._value;
}
dynamic operator ^(dynamic other) {
if (other.runtimeType != Json)
return _value ^ other;
return _value ^ other._value;
}
dynamic operator &(dynamic other) {
if (other.runtimeType != Json)
return _value & other;
return _value & other._value;
}
dynamic operator <<(dynamic other) {
if (other.runtimeType != Json)
return _value << other;
return _value << other._value;
}
dynamic operator >>(dynamic other) {
if (other.runtimeType != Json)
return _value >> other;
return _value >> other._value;
}
@override
bool operator ==(dynamic other) {
if (other.runtimeType != Json)
return _value == other;
return _value == other._value;
}
@override
int get hashCode => _value.hashCode;
}
void main() {
final Json value = new Json({
'foo': {
'bar': [ 0, 1, 'two', 3 ],
},
'baz': true,
'quux': true,
});
assert(value.foo.bar[2] == 'two');
assert(value.baz == true);
assert(value.baz == value.quux);
value.foo.bar[0] = 'zero';
assert(value.foo.bar[0].valueType == String);
assert(value.foo.bar[1].toDouble() == 1.0);
assert(value.foo.bar[1] < 2.0);
assert(value.foo.bar[1] < value.foo.bar[3]);
}
``` | c: new feature,framework,dependency: dart,P3,team-framework,triaged-framework | low | Minor |
265,595,336 | TypeScript | Promise.{all,race} static method's iterable definitions incorrectly omit other definitions by overloading (regression) | `es2015.iterable.d.ts` must not omit `es2015.promise.d.ts` definitions by overloading. However, npm package distributions work correctly.
**TypeScript Version:** 2.6.0 RC for Visual Studio 2015
**Code**
```ts
Promise.all([0, 0]);
```
**Expected behavior:**
Should use definitions of `es2015.promise.d.ts`.
```ts
Promise.all([0, 0]); // Promise<[number, number]>
```
**Actual behavior:**
Uses definitions of `es2015.iterable.d.ts`.
```ts
Promise.all([0, 0]); // Promise<number[]>
```
| Bug,Domain: lib.d.ts | low | Major |
265,638,947 | TypeScript | typeChecker.typeToString() should print most derived alias | <!-- BUGS: Please use this template. -->
<!-- QUESTIONS: This is not a general support forum! Ask Qs at http://stackoverflow.com/questions/tagged/typescript -->
<!-- SUGGESTIONS: See https://github.com/Microsoft/TypeScript-wiki/blob/master/Writing-Good-Design-Proposals.md -->
<!-- Please try to reproduce the issue with `typescript@next`. It may have already been fixed. -->
**TypeScript Version:** typescript@next
**Code**
[Playground Link](https://www.typescriptlang.org/play/index.html#src=type%20First%3CT%2C%20R%3E%20%3D%20(source%3A%20T)%20%3D%3E%20R%3B%0D%0Atype%20Second%3CT%3E%20%3D%20First%3CT%2C%20T%3E%3B%0D%0A%0D%0Adeclare%20function%20example()%3A%20Second%3Cstring%3E%3B%0D%0A)
```ts
type First<T, R> = (source: T) => R;
type Second<T> = First<T, T>;
declare function example(): Second<string>;
```
**Expected behavior:**
Using the compiler API, `typeChecker.typeToString(signature.getReturnType())` of `example` returns the most derived alias, `Second<string>`
**Actual behavior:**
`typeChecker.typeToString(signature.getReturnType())` returns `First<string, string>`
***
IntelliSense [in the playground](https://www.typescriptlang.org/play/index.html#src=type%20First%3CT%2C%20R%3E%20%3D%20(source%3A%20T)%20%3D%3E%20R%3B%0D%0Atype%20Second%3CT%3E%20%3D%20First%3CT%2C%20T%3E%3B%0D%0A%0D%0Adeclare%20function%20example()%3A%20Second%3Cstring%3E%3B%0D%0A) and vscode both show the same thing as `typeChecker.typeToString(returnType)`, so I assume they share the same underlying logic.
I tried examining the type object itself to see if I could reach into private APIs to get it, but I couldn't find it. I also tried [various formatting flags](https://github.com/Microsoft/TypeScript/blob/4487917f89bd5e068a4d35e8db22bf728cab4b74/src/compiler/types.ts#L2809-L2827), but none of them seemed to give me the desired behavior.
I searched for existing issues on this, #17433 seemed similar but digging into it, I think it's different. It's also possible this behavior was intentional of course, if so, lmk. I'm using the compiler API to generate custom [documentation for rxjs](https://github.com/ReactiveX/rxjs-docs) and there are sometimes a number of aliases used which simplify much more complex structures and hide internals.
I could try to take a crack at a patch if someone knows where I might find the applicable logic. Seems like it would need to be on the type metadata generation side, since I can't find it in the type returned from `signature.getReturnType()`?
Cc/ @benlesh | Bug | low | Critical |
265,675,823 | youtube-dl | Opera Platform is now OperaVision | ## Please follow the guide below
- You will be asked some questions and requested to provide some information, please read them **carefully** and answer honestly
- Put an `x` into all the boxes [ ] relevant to your *issue* (like this: `[x]`)
- Use the *Preview* tab to see what your issue will actually look like
---
### Make sure you are using the *latest* version: run `youtube-dl --version` and ensure your version is *2017.10.15.1*. If it's not, read [this FAQ entry](https://github.com/rg3/youtube-dl/blob/master/README.md#how-do-i-update-youtube-dl) and update. Issues with outdated version will be rejected.
- [x] I've **verified** and **I assure** that I'm running youtube-dl **2017.10.15.1**
### Before submitting an *issue* make sure you have:
- [x] At least skimmed through the [README](https://github.com/rg3/youtube-dl/blob/master/README.md), **most notably** the [FAQ](https://github.com/rg3/youtube-dl#faq) and [BUGS](https://github.com/rg3/youtube-dl#bugs) sections
- [x] [Searched](https://github.com/rg3/youtube-dl/search?type=Issues) the bugtracker for similar issues including closed ones
### What is the purpose of your *issue*?
- [ ] Bug report (encountered problems with youtube-dl)
- [x] Site support request (request for adding support for a new site)
- [ ] Feature request (request for a new functionality)
- [ ] Question
- [ ] Other
---
### If the purpose of this *issue* is a *site support request* please provide all kinds of example URLs support for which should be included (replace following example URLs by **yours**):
Note that **youtube-dl does not support sites dedicated to [copyright infringement](https://github.com/rg3/youtube-dl#can-you-add-support-for-this-anime-video-site-or-site-which-shows-current-movies-for-free)**. In order for site support request to be accepted all provided example URLs should not violate any copyrights.
---
### Description of your *issue*, suggested solution and other information
The Opera Platform has changed domain, it is now Operavision (www.operavision.eu) and it does not work with youtube.dl, please upgrade with this new site.
Single video: http://www.operavision.eu/en/library/performances/operas/lecume-des-jours
| site-support-request | low | Critical |
265,755,676 | angular | component host element removal is delayed when animation module is added to project | ## I'm submitting a...
<pre><code>
[ ] Regression
[X] Bug report
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request
</code></pre>
With imported BrowserAnimationsModule I have observed that host nodes of destroyed component instances from an old route are removed from the DOM **AFTER** the ngAfterViewInit() lifecycle hook was called on any newly component instance on the new route.
Without imported BrowserAnimationsModule the host nodes of destroyed component instances from an old route are removed **BEFORE** the ngAfterViewInit() lifecycle hook is called.
I understand that in presence of the BrowserAnimationsModule the host nodes of destroyed component can only be removed from the DOM **AFTER** any animations have ended.
Is it possible to only delay the node removal if there are animations present? If this is not possible, can you please add this fact to the documentation of the BrowserAnimationsModule?
## Current behavior (with imported BrowserAnimationsModule)
The removal of the host node of a destroyed component instance on an old route happens **AFTER**
the ngAfterViewInit() call on the new component instance even if no animations are present.
## Expected behavior (with imported BrowserAnimationsModule)
If there are no animations defined on component instances of the old route, then remove all host nodes of destroyed components from the DOM BEFORE ngAfterViewInit() is called on any new component instances on the new route.
## Minimal reproduction of the problem with instructions
## What is the motivation / use case for changing the behavior?
Don't break anything just by importing an unused BrowserAnimationsModule
## Environment
<pre><code>
Angular version: 4.4.4
Browser:
- [X] Chrome (desktop) version 61.0.3163.100
- [ ] Chrome (Android) version XX
- [ ] Chrome (iOS) version XX
- [ ] Firefox version XX
- [ ] Safari (desktop) version XX
- [ ] Safari (iOS) version XX
- [ ] IE version XX
- [ ] Edge version XX
For Tooling issues:
- Node version: 5.4.1
- Platform: Windows
Others:
</code></pre>
| type: bug/fix,area: animations,freq2: medium,P3 | low | Critical |
265,872,334 | go | runtime: TestLldbPython test fails with lldb 3.8 on linux | Verified the test passed with lldb 3.9 or higher, or if lldb is not installed at all.
--- FAIL: TestLldbPython (1.83s)
runtime-lldb_test.go:178: Unexpected lldb output:
Created target
Created breakpoint
Process launched
Hit breakpoint
Stopped at main.go:10
Stopped in main.main
no intvar
FAIL
FAIL runtime 19.046s
Skipping the test if lldb is too ancient seems reasonable. | Testing,help wanted,NeedsFix,compiler/runtime | low | Minor |
265,918,474 | TypeScript | 'Canvas#getContext' almost never returns 'null' | **TypeScript Version:** 2.5.3
**Code:**
```ts
let canvas: HTMLCanvasElement = document.createElement("canvas");
let ctx: CanvasRenderingContext2D = canvas.getContext("2d");
ctx.fillRect(0, 0, canvas.width, canvas.height);
```
**Expected behavior:**
No errors should occur because the type of canvas is HTMLCanvasElement.
**Actual behavior:**
```
test.ts(2,5): error TS2322: Type 'CanvasRenderingContext2D | null' is not assignable to type 'CanvasRenderingContext2D'.
Type 'null' is not assignable to type 'CanvasRenderingContext2D'.
```
If I change the type of ctx to `CanvasRenderingContext2D | null`, then I get
```
test.ts(3,1): error TS2531: Object is possibly 'null'.
```
| Suggestion,Domain: lib.d.ts,Awaiting More Feedback | medium | Critical |
265,925,274 | flutter | Allow the Dart VM to post idle task callbacks. | A mechanism for the engine to notify the Dart VM that an idle time slice was available for bookkeeping tasks was added in https://github.com/flutter/engine/pull/4012. Based on feedback from @rmacnak-google, this results in a lot of calls into the VM where there isn't much work to be done. Instead, it was suggested that the VM could post tasks into the engine for execution at a point in time the engine determines is safe (i.e. won't cause jank). Along with a callback, the VM would also give an approximation of the time it think it will take to service that callback. Based on this information, the engine can decide to prioritize the idle tasks. It is not clear if this mechanism is a replacement of the current scheme or just an addition.
cc @zanderso, @a-siva | c: new feature,engine,c: performance,dependency: dart,P2,team-engine,triaged-engine | low | Minor |
265,942,028 | flutter | Make Material Icons font a package | Currently there are special logic that pulls the font file from https://storage.googleapis.com/flutter_infra/flutter/fonts as a tool artifact cache, and a special yaml entry lets the tool add it to the flx.
Use the generic logic used in Cupertino to host a new package on pub that user apps can add dependencies on to indirectly get the font instead. See #12559 for Cupertino. See #12160 for mechanism.
Remove special logic from tools. | framework,f: material design,c: proposal,P2,team-design,triaged-design | low | Major |
265,954,318 | flutter | PageController needs documentation about how the pages are laid out when viewportFraction is not 1.0 | It appears that the page is centered in the available space rather than top or bottom aligned (in the case of vertical paging) | framework,f: scrolling,d: api docs,P2,team-framework,triaged-framework | low | Minor |
265,975,124 | vue | vue SSR webpack plugin support template syntax for filename option | ### What problem does this feature solve?
multiple entry and output point, because webpack plugin option of filename don't support template syntac like [name]、[id], so It's not convenient on this situation.
### What does the proposed API look like?
new VueSSRServerPlugin({
filename: '[name]/vue-ssr-server-bundle.json'
})
<!-- generated by vue-issues. DO NOT REMOVE --> | feature request | medium | Minor |
266,028,983 | puppeteer | Change dpi of PDFs | It seems that we can't change dpi of generated PDFs, will it be a feature ?
For some case, it would be useful. | feature,chromium | low | Major |
266,097,776 | youtube-dl | Support connection reuse / keep-alive | ### What is the purpose of your *issue*?
- [ ] Bug report (encountered problems with youtube-dl)
- [ ] Site support request (request for adding support for a new site)
- [x] Feature request (request for a new functionality)
- [ ] Question
- [ ] Other
----
Many videos from YouTube contain a lot of small video chunks. Creating one connection per file download significantly slows down the speed. I only get up to 200-500KiB/s for a chunk then the connection is closed and another is made for the next chunk. When downloading a big video file from YouTube I can get 5-6MiB/s. (The actual speed difference depends on the available bandwidth and round-trip time.)
TCP slow start significantly limits the speed when the connection is starting. With connection reuse / HTTP keep-alive we can avoid all the speeding-up phrase.
| request | medium | Critical |
266,156,611 | puppeteer | [Feature] Call `page.goto()` as a POST request and/or with custom headers | Actually the only way to request a page through a POST or/and with custom headers is by trapping the request with `page.setRequestInterceptionEnabled(true)` (as proposed [here](https://github.com/GoogleChrome/puppeteer/issues/669#issuecomment-326797345)) or by building a custom html page with a `<form>` tag and submitting it (this solution prevent us to set custom headers).
Both of these solutions are very hackish…
It would be better to have a second parameter to `page.goto()` in which we can specify the request params like [`request.continue()`](https://github.com/GoogleChrome/puppeteer/blob/v0.12.0/docs/api.md#requestcontinueoverrides):
```javascript
{
method: 'POST',
postData: '…',
headers: {…}
}
```
What do you think?
| feature,upstream,chromium | high | Critical |
266,213,280 | every-programmer-should-know | What do you think about adding theoretical computer science in this list ? | Needs some ❤️ | low | Minor |
|
266,228,215 | pytorch | Sparse tensor .new(size) can be confusing | Say `x` is a sparse tensor. When calling `y = x.new(x.size())`, it automatically creates a new sparse tensor with `y.dimensionI = x.dimensionI + x.dimensionV` and `y.dimensionV = 0`, regardless of `x.dimensionV`. This causes extremely confusing behaviors like the following, where `x.new(x.size()) + x` errors but `x.new(x.size()).resize_as_(x) + x` works:
```
(Pdb) x
FloatTensor of size 10x3 with indices:
1 2 4 5 4 1 3 1 3 2 0
[torch.cuda.LongTensor of size 1x11 (GPU 0)]
and values:
1 1 1
1 1 1
1 1 1
1 1 1
1 1 1
1 1 1
1 1 1
1 1 1
1 1 1
1 1 1
1 1 1
[torch.cuda.FloatTensor of size 11x3 (GPU 0)]
(Pdb) y = x.new(x.size())
(Pdb) y
FloatTensor of size 10x3 with indices:
[torch.cuda.LongTensor with no dimension]
and values:
[torch.cuda.FloatTensor with no dimension]
(Pdb) y + x
*** RuntimeError: cadd operands have incompatible sizes or dimension types at /home/ssnl/sftp/pytorch/torch/lib/THCS/generic/THCSTensorMath.cu:358
(Pdb) yy = x.new(x.size()).resize_as_(x)
(Pdb) yy
FloatTensor of size 10x3 with indices:
[torch.cuda.LongTensor with no dimension]
and values:
[torch.cuda.FloatTensor with no dimension]
(Pdb) yy + x
FloatTensor of size 10x3 with indices:
1 2 4 5 4 1 3 1 3 2 0
[torch.cuda.LongTensor of size 1x11 (GPU 0)]
and values:
1 1 1
1 1 1
1 1 1
1 1 1
1 1 1
1 1 1
1 1 1
1 1 1
1 1 1
1 1 1
1 1 1
[torch.cuda.FloatTensor of size 11x3 (GPU 0)]
```
cc @vincentqb | module: sparse,triaged | low | Critical |
266,251,322 | TypeScript | "Debugging Language Service in VS Code" documentation is weird | The "Debugging Language Service in VS Code" wiki is vague and sometimes confusing.
>Update your user settings to use your development version of typescript, located in the .../TypeScript/built/local directory. The corresponding setting/path is
>```
>{
> "typescript.tsdk": "/path/to/repo/TypeScript/built/local"
>}
>```
User settings are stored per folder and it's not clear which folder should be used. Both typescript and vscode have been downloaded. There have been no instructions to open either version of code yet.
>Debugging tsserver (server-side)
>...
>2. Update launch.json with an option to attach to the node instance, with sourcemaps from your built/local folder.
Again, which launch.json is being spoken about?
>3. Launch an instance of development vs code, and open a ts file.
>4. Launch an instance of stable vs code.
>5. Attach the stable vs code instance to the development instance.
Wouldn't it be easier to open an instance of code, change the launch.json and then open a .ts file or attach to the other instance?
It would be helpful to list the steps in order and with more detail, perhaps with an example path so that it's clear which instance of code is being opened, which folder said instance is opening (if any) and which files are being edited.
Given that there aren't too many steps, it should be quite reasonable to list all steps for each debugging excercise.
| Docs | low | Critical |
266,253,930 | TypeScript | Provide a way to apply quick fixes/refactorings/code actions in a bulk automated fashion | Currently, we have several quick fixes and refactorings. Some of these are generally to help reorganize your codebase/fix issues, some are more to migrate from JS to TS more easily, and some are to more-easily opt in to a more strongly-typed version of TypeScript.
The problem here is that these quick fixes/refactorings can become painful when manually applied. Sometimes we want to apply them *en masse* - altoghether. But perhaps the way I see this as is something that could be applied granularly (individually), altogether at once, or in a one-at-a-time but nonetheless automated fashion (supervised).
Some prior art here we may want to look at for inspiration are [jscodeshift](https://github.com/facebook/jscodeshift). | Suggestion,Needs Proposal,Domain: Refactorings,Domain: Quick Fixes | low | Major |
266,271,137 | go | cmd/compile: odd inlining heuristic under mid-stack inlining | Suppose:
func F() { ...; G(); ... }
func G() { ... }
When midstack inlining (#19348) is enabled (-l=4), F is inlinable under two conditions:
1. G is inlineable, and F's total cost including the cost of inlining G falls under the max budget.
2. G is not inlineable, and F's total cost (excluding the cost of inlining G, since it won't be inlined) falls under the max budget.
However, this leaves out a third possibility:
3. G is inlineable, and F's total cost falls under the max budget as long as G is not inlined.
This seems counter-intuitive to me: that simplifying G from being non-inlineable (case 2) to inlineable (case 3), might cause F to no longer be inlineable.
On the other hand, maybe this is desirable: if we can't inline F+G, maybe it's better to make non-inline calls to F+G, than to inline F and make a non-inline call to G.
What inlining heuristics do other compilers use in situations like this?
/cc @ianlancetaylor | Performance,NeedsInvestigation,compiler/runtime | low | Major |
266,299,066 | TypeScript | Support yarn in `Install @types/<package>` code fix | https://github.com/Microsoft/TypeScript/pull/19130 added a code fix to install packages from `@types`. This will always use `npm` to install the package. This works for updating `package.json` and `package-lock.json`, but not `yarn.lock` | Suggestion,Awaiting More Feedback,Domain: Quick Fixes | low | Major |
266,329,972 | youtube-dl | Filename truncation should apply on actual filename instead of title (was: FFMPEG chokes on default filename) | ## Please follow the guide below
- You will be asked some questions and requested to provide some information, please read them **carefully** and answer honestly
- Put an `x` into all the boxes [ ] relevant to your *issue* (like this: `[x]`)
- Use the *Preview* tab to see what your issue will actually look like
---
### Make sure you are using the *latest* version: run `youtube-dl --version` and ensure your version is *2017.10.15.1*. If it's not, read [this FAQ entry](https://github.com/rg3/youtube-dl/blob/master/README.md#how-do-i-update-youtube-dl) and update. Issues with outdated version will be rejected.
- [x] I've **verified** and **I assure** that I'm running youtube-dl **2017.10.15.1**
### Before submitting an *issue* make sure you have:
- [x] At least skimmed through the [README](https://github.com/rg3/youtube-dl/blob/master/README.md), **most notably** the [FAQ](https://github.com/rg3/youtube-dl#faq) and [BUGS](https://github.com/rg3/youtube-dl#bugs) sections
- [x] [Searched](https://github.com/rg3/youtube-dl/search?type=Issues) the bugtracker for similar issues including closed ones
### What is the purpose of your *issue*?
- [x] Bug report (encountered problems with youtube-dl)
- [ ] Site support request (request for adding support for a new site)
- [ ] Feature request (request for a new functionality)
- [ ] Question
- [ ] Other
---
### If the purpose of this *issue* is a *bug report*, *site support request* or you are not completely sure provide the full verbose output as follows:
Add the `-v` flag to **your command line** you run youtube-dl with (`youtube-dl -v <your command line>`), copy the **whole** output and insert it here. It should look similar to one below (replace it with **your** log inserted between triple ```):
_**Sanitized output**_
```
PS G:\test> .\youtube-dl --cookies '.\cookies.txt' 'https://www.blah.com/video/mnff?manifest=https%3A%2F
%2Fwmvideocdn.streaming.mediaservices.windows.net%2Ffbbcda92-5518-4b65-a0b5-ec3f1a18b81e_prores_out.i
sm%2FManifest%28format%3Dm3u8-aapl%2Caudio-only%3Dfalse%2Cfilter%3Dpreset2%29&token=Bearer%3DeyJ0eXAiOiJKV1QiLCJhbGciOiJ
IUzI1NiJ9.eyJ1cm46bWljcm9zb2Z0OmF6dXJlOm1lZGlhc2VydmljZXM6Y29udGVudGtleWlkZW50aWZpZXIiOiI5YzU1ZDIyOS0xZTM5LTQ1NDEtODRiNi
1lZDY0NDI3NmJlZTkiLCJDS1R5cGUiOiJFTlZFIiwiaXNzIjoiV2FrYW5pbS5UViIsImF1ZCI6Imh0dHA6Ly93d3cud2FrYW5pbS50diIsImV4cCI6MTUwOD
M2MDc0OCwibmJmIjoxNTA4Mjc2NDQ4fQ.weq0Ei6YC8Zul-WyjaYipqIHevyc-lH7m_sFhte_uPc&idepisode=3672&numero=1&idserie=272' -v
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['--cookies', '.\\cookies.txt', 'https://blah.com/video/mnff?manifest=htt
ps%3A%2F%2Fwmvideocdn.streaming.mediaservices.windows.net%2Ffbbcda92-5518-4b65-a0b5-ec3f1a18b81e_pror
es_out.ism%2FManifest%28format%3Dm3u8-aapl%2Caudio-only%3Dfalse%2Cfilter%3Dpreset2%29&token=Bearer%3DeyJ0eXAiOiJKV1QiLCJ
hbGciOiJIUzI1NiJ9.eyJ1cm46bWljcm9zb2Z0OmF6dXJlOm1lZGlhc2VydmljZXM6Y29udGVudGtleWlkZW50aWZpZXIiOiI5YzU1ZDIyOS0xZTM5LTQ1ND
EtODRiNi1lZDY0NDI3NmJlZTkiLCJDS1R5cGUiOiJFTlZFIiwiaXNzIjoiV2FrYW5pbS5UViIsImF1ZCI6Imh0dHA6Ly93d3cud2FrYW5pbS50diIsImV4cC
I6MTUwODM2MDc0OCwibmJmIjoxNTA4Mjc2NDQ4fQ.weq0Ei6YC8Zul-WyjaYipqIHevyc-lH7m_sFhte_uPc&idepisode=3672&numero=1&idserie=272
', '-v']
[debug] Encodings: locale cp1252, fs mbcs, out cp437, pref cp1252
[debug] youtube-dl version 2017.10.15.1
[debug] Python version 3.4.4 - Windows-7-6.1.7601-SP1
[debug] exe versions: ffmpeg N-87871-g7480f232d2, ffprobe N-87871-g7480f232d2
[debug] Proxy map: {}
[generic] mnff?manifest=https://wmvideocdn.streaming.mediaservices.windows.net/fbbcda92-5518-4b65-a0b5-ec3f1a18
b81e/_prores_out.ism/Manifest(format=m3u8-aapl,audio-only=false,filter=preset2)&token=Bearer=eyJ0eXAiOiJKV1QiLCJh
bGciOiJIUzI1NiJ9.eyJ1cm46bWljcm9zb2Z0OmF6dXJlOm1lZGlhc2VydmljZXM6Y29udGVudGtleWlkZW50aWZpZXIiOiI5YzU1ZDIyOS0xZTM5LTQ1NDE
tODRiNi1lZDY0NDI3NmJlZTkiLCJDS1R5cGUiOiJFTlZFIiwiaXNzIjoiV2FrYW5pbS5UViIsImF1ZCI6Imh0dHA6Ly93d3cud2FrYW5pbS50diIsImV4cCI
6MTUwODM2MDc0OCwibmJmIjoxNTA4Mjc2NDQ4fQ: Requesting header
[generic] mnff?manifest=https://wmvideocdn.streaming.mediaservices.windows.net/fbbcda92-5518-4b65-a0b5-ec3f1a18
b81e/_prores_out.ism/Manifest(format=m3u8-aapl,audio-only=false,filter=preset2)&token=Bearer=eyJ0eXAiOiJKV1QiLCJh
bGciOiJIUzI1NiJ9.eyJ1cm46bWljcm9zb2Z0OmF6dXJlOm1lZGlhc2VydmljZXM6Y29udGVudGtleWlkZW50aWZpZXIiOiI5YzU1ZDIyOS0xZTM5LTQ1NDE
tODRiNi1lZDY0NDI3NmJlZTkiLCJDS1R5cGUiOiJFTlZFIiwiaXNzIjoiV2FrYW5pbS5UViIsImF1ZCI6Imh0dHA6Ly93d3cud2FrYW5pbS50diIsImV4cCI
6MTUwODM2MDc0OCwibmJmIjoxNTA4Mjc2NDQ4fQ: Downloading m3u8 information
[debug] Default format spec: bestvideo+bestaudio/best
[debug] Invoking downloader on 'https://blah.com/video/mnffsnd?manifest=https%3a%2f%2fwmvideocdn.st
reaming.mediaservices.windows.net%2ffbbcda92-5518-4b65-a0b5-ec3f1a18b81e%_prores_out.ism/QualityLevels(1465184)
/Manifest(video,format=m3u8-aapl,filter=preset2)&token=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJ1cm46bWljcm9zb2Z0OmF6dXJl
Om1lZGlhc2VydmljZXM6Y29udGVudGtleWlkZW50aWZpZXIiOiI5YzU1ZDIyOS0xZTM5LTQ1NDEtODRiNi1lZDY0NDI3NmJlZTkiLCJDS1R5cGUiOiJFTlZF
IiwiaXNzIjoiV2FrYW5pbS5UViIsImF1ZCI6Imh0dHA6Ly93d3cud2FrYW5pbS50diIsImV4cCI6MTUwODM2MDc0OCwibmJmIjoxNTA4Mjc2NDQ4fQ.weq0E
i6YC8Zul-WyjaYipqIHevyc-lH7m_sFhte_uPc'
[download] Destination: mnff-mnffmanifest=https -__wmvideocdn.streaming.mediaservices.windows.net_fbbcda92-5518
-4b65-a0b5-ec3f1a18b81e__prores_out.ism_Manifest(format=m3u8-aapl,audio-only=false,filter=preset2)&token=Bearer=e
yJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJ1cm46bWljcm9zb2Z0OmF6dXJlOm1lZGlhc2VydmljZXM6Y29udGVudGtleWlkZW50aWZpZXIiOiI5YzU1
ZDIyOS0xZTM5LTQ1NDEtODRiNi1lZDY0NDI3NmJlZTkiLCJDS1R5cGUiOiJFTlZFIiwiaXNzIjoiV2FrYW5pbS5UViIsImF1ZCI6Imh0dHA6Ly93d3cud2Fr
YW5pbS50diIsImV4cCI6MTUwODM2MDc0OCwibmJmIjoxNTA4Mjc2NDQ4fQ.f1644.mp4
[debug] ffmpeg command line: ffmpeg -y -loglevel verbose -headers "Accept-Charset: ISO-8859-1,utf-8;q=0.7,*;q=0.7
Cookie: ai_user=DYSPI|2017-10-17T20:40:48.829Z; WMV2Consent=true; ; ASP.NET_SessionId=iqpx4vtkyw1pa5rn
lkyjxmnt; =; .Auth=ZclG-YhW_wYUTZtXSV4ss2XGhyeMVI-eKydZH0Ed5bqg-ctn4o_r_EHxrjyMT2HuLnC1Qp-sgCbDO
x-iDFy8El8Cs_5r6SbuoF2zYZpfGDDJ5cl9mzdtjfG9WLhJYAtY8e3e4NuQikVALUyCvarLxYj61N80J4bJ37xtpB7kzxj_9g3CNMoXH78K1HfOdTpZk4qXQ
0YvHujCwuuSVNz_2dLC0vlDpV_NM9Ykf29yil05clVJw607vYfY7j6LfdEexEIf0kvO12LAHcjB0tOWOHv8xS3VmhmKIqnBTof8KaGO6dyBuVFyXUVfzR1xx
_OAWLSFCNxHuZG2h193dNpOPMFmqdkQyG6j7xclWdH2OgOFBd3FZXBq3EHsoyyxNZ8Q7ixfWMuoNkwChWL8dcKb9Lhx0WEvbOXvl-XcwEnPAmwTbAWUsvmuk
VfFY1D9p_7cVgPcuIssPyDXwUBQLgz0PYvgEdpWfPGceyalHygQH7pPSoWKQuRzcjFSOitE1l4f1u8Rl859TYAbRWhJIxiPIDwbKlk_jPRFEJlEUehVBKpVg
ElsdoaWMqcr4jRGabIhEHfSxKdurS5rjVSEcejxDg; _ga=GA1.2.183824678.1508272849; _gid=GA1.2.1732356944.1508272849
Accept-Language: en-us,en;q=0.5
Accept-Encoding: gzip, deflate
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0) Gecko/20150101 Firefox/47.0 (Chrome)
Accept: text/html,application/xhtml+xml,application/xml;q=0.9,*/*;q=0.8
" -i "https://blah.com/video/mnffsnd?manifest=https%3a%2f%2fwmvideocdn.streaming.mediaservices.wind
ows.net%2ffbbcda92-5518-4b65-a0b5-ec3f1a18b81e%_prores_out.ism/QualityLevels(1465184)/Manifest(video,format=m3u
8-aapl,filter=preset2)&token=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJ1cm46bWljcm9zb2Z0OmF6dXJlOm1lZGlhc2VydmljZXM6Y29udG
VudGtleWlkZW50aWZpZXIiOiI5YzU1ZDIyOS0xZTM5LTQ1NDEtODRiNi1lZDY0NDI3NmJlZTkiLCJDS1R5cGUiOiJFTlZFIiwiaXNzIjoiV2FrYW5pbS5UVi
IsImF1ZCI6Imh0dHA6Ly93d3cud2FrYW5pbS50diIsImV4cCI6MTUwODM2MDc0OCwibmJmIjoxNTA4Mjc2NDQ4fQ.weq0Ei6YC8Zul-WyjaYipqIHevyc-lH
7m_sFhte_uPc" -c copy -f mp4 "file:mnff-mnffmanifest=https -__wmvideocdn.streaming.mediaservices.windows.net_fb
bcda92-5518-4b65-a0b5-ec3f1a18b81e__prores_out.ism_Manifest(format=m3u8-aapl,audio-only=false,filter=preset2)&tok
en=Bearer=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJ1cm46bWljcm9zb2Z0OmF6dXJlOm1lZGlhc2VydmljZXM6Y29udGVudGtleWlkZW50aWZpZ
XIiOiI5YzU1ZDIyOS0xZTM5LTQ1NDEtODRiNi1lZDY0NDI3NmJlZTkiLCJDS1R5cGUiOiJFTlZFIiwiaXNzIjoiV2FrYW5pbS5UViIsImF1ZCI6Imh0dHA6L
y93d3cud2FrYW5pbS50diIsImV4cCI6MTUwODM2MDc0OCwibmJmIjoxNTA4Mjc2NDQ4fQ.f1644.mp4.part"
ffmpeg version N-87871-g7480f232d2 Copyright (c) 2000-2017 the FFmpeg developers
built with gcc 7.2.0 (GCC)
configuration: --enable-gpl --enable-version3 --enable-sdl2 --enable-bzlib --enable-fontconfig --enable-gnutls --enabl
e-iconv --enable-libass --enable-libbluray --enable-libfreetype --enable-libmp3lame --enable-libopenjpeg --enable-libopu
s --enable-libshine --enable-libsnappy --enable-libsoxr --enable-libtheora --enable-libtwolame --enable-libvpx --enable-
libwavpack --enable-libwebp --enable-libx264 --enable-libx265 --enable-libxml2 --enable-libzimg --enable-lzma --enable-z
lib --enable-gmp --enable-libvidstab --enable-libvorbis --enable-cuda --enable-cuvid --enable-d3d11va --enable-nvenc --e
nable-dxva2 --enable-avisynth --enable-libmfx
libavutil 55. 79.100 / 55. 79.100
libavcodec 57.108.100 / 57.108.100
libavformat 57. 84.100 / 57. 84.100
libavdevice 57. 11.100 / 57. 11.100
libavfilter 6.108.100 / 6.108.100
libswscale 4. 9.100 / 4. 9.100
libswresample 2. 10.100 / 2. 10.100
libpostproc 54. 8.100 / 54. 8.100
[hls,applehttp @ 00000000004cc6c0] HLS request for url 'https://wmvideocdn.streaming.mediaservices.windows.net/
fbbcda92-5518-4b65-a0b5-ec3f1a18b81e/_prores_out.ism/QualityLevels(1465184)/Fragments(video=0,format=m3u8-aapl)',
offset 0, playlist 0
[hls,applehttp @ 00000000004cc6c0] Opening 'https://blah.com/video/key?KID=9c55d229-1e39-4541-84b6-ed644276b
ee9&token=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJ1cm46bWljcm9zb2Z0OmF6dXJlOm1lZGlhc2VydmljZXM6Y29udGVudGtleWlkZW50aWZpZ
XIiOiI5YzU1ZDIyOS0xZTM5LTQ1NDEtODRiNi1lZDY0NDI3NmJlZTkiLCJDS1R5cGUiOiJFTlZFIiwiaXNzIjoiV2FrYW5pbS5UViIsImF1ZCI6Imh0dHA6L
y93d3cud2FrYW5pbS50diIsImV4cCI6MTUwODM2MDc0OCwibmJmIjoxNTA4Mjc2NDQ4fQ.weq0Ei6YC8Zul-WyjaYipqIHevyc-lH7m_sFhte_uPc' for r
eading
[hls,applehttp @ 00000000004cc6c0] Opening 'crypto+https://wmvideocdn.streaming.mediaservices.windows.net/fbbcd
a92-5518-4b65-a0b5-ec3f1a18b81e/_prores_out.ism/QualityLevels(1465184)/Fragments(video=0,format=m3u8-aapl)' for r
eading
[h264 @ 000000000058a7a0] Reinit context to 960x544, pix_fmt: yuv420p
[hls,applehttp @ 00000000004cc6c0] max_analyze_duration 5000000 reached at 5005000 microseconds st:0
Input #0, hls,applehttp, from 'https://blah.com/video/mnffsnd?manifest=https%3a%2f%2fwmvideocdn.str
eaming.mediaservices.windows.net%2ffbbcda92-5518-4b65-a0b5-ec3f1a18b81e_prores_out.ism/QualityLevels(1465184)/
Manifest(video,format=m3u8-aapl,filter=preset2)&token=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJ1cm46bWljcm9zb2Z0OmF6dXJlO
m1lZGlhc2VydmljZXM6Y29udGVudGtleWlkZW50aWZpZXIiOiI5YzU1ZDIyOS0xZTM5LTQ1NDEtODRiNi1lZDY0NDI3NmJlZTkiLCJDS1R5cGUiOiJFTlZFI
iwiaXNzIjoiV2FrYW5pbS5UViIsImF1ZCI6Imh0dHA6Ly93d3cud2FrYW5pbS50diIsImV4cCI6MTUwODM2MDc0OCwibmJmIjoxNTA4Mjc2NDQ4fQ.weq0Ei
6YC8Zul-WyjaYipqIHevyc-lH7m_sFhte_uPc':
Duration: 00:23:03.34, start: 0.083411, bitrate: 0 kb/s
Program 0
Metadata:
variant_bitrate : 0
Stream #0:0: Video: h264 (High), 1 reference frame ([27][0][0][0] / 0x001B), yuv420p(left), 960x540 (960x544) [SAR 1
:1 DAR 16:9], 23.98 fps, 23.98 tbr, 90k tbn, 47.95 tbc
Metadata:
variant_bitrate : 0
file:mnff-mnffmanifest=https -__wmvideocdn.streaming.mediaservices.windows.net_fbbcda92-5518-4b65-a0b5-ec3f1a18
b81e__prores_out.ism_Manifest(format=m3u8-aapl,audio-only=false,filter=preset2)&token=Bearer=eyJ0eXAiOiJKV1QiLCJh
bGciOiJIUzI1NiJ9.eyJ1cm46bWljcm9zb2Z0OmF6dXJlOm1lZGlhc2VydmljZXM6Y29udGVudGtleWlkZW50aWZpZXIiOiI5YzU1ZDIyOS0xZTM5LTQ1NDE
tODRiNi1lZDY0NDI3NmJlZTkiLCJDS1R5cGUiOiJFTlZFIiwiaXNzIjoiV2FrYW5pbS5UViIsImF1ZCI6Imh0dHA6Ly93d3cud2FrYW5pbS50diIsImV4cCI
6MTUwODM2MDc0OCwibmJmIjoxNTA4Mjc2NDQ4fQ.f1644.mp4.part: No such file or directory
ERROR: ffmpeg exited with code 1
File "__main__.py", line 19, in <module>
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmplnz97faa\build\youtube_dl\__init__.py", line 465, i
n main
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmplnz97faa\build\youtube_dl\__init__.py", line 455, i
n _real_main
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmplnz97faa\build\youtube_dl\YoutubeDL.py", line 1985,
in download
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmplnz97faa\build\youtube_dl\YoutubeDL.py", line 795,
in extract_info
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmplnz97faa\build\youtube_dl\YoutubeDL.py", line 849,
in process_ie_result
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmplnz97faa\build\youtube_dl\YoutubeDL.py", line 1619,
in process_video_result
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmplnz97faa\build\youtube_dl\YoutubeDL.py", line 1886,
in process_info
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmplnz97faa\build\youtube_dl\YoutubeDL.py", line 1831,
in dl
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmplnz97faa\build\youtube_dl\downloader\common.py", li
ne 361, in download
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmplnz97faa\build\youtube_dl\downloader\external.py",
line 57, in real_download
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmplnz97faa\build\youtube_dl\downloader\common.py", li
ne 163, in report_error
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmplnz97faa\build\youtube_dl\YoutubeDL.py", line 612,
in report_error
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmplnz97faa\build\youtube_dl\YoutubeDL.py", line 574,
in trouble
<end of log>
```
---
### Description of your *issue*, suggested solution and other information
I was trying to download a video from an M3U8. Everything was going fine until FFMPEG suddenly quits saying "No such file or directory".
Turns out, the output filename Youtube-DL was feeding FFMPEG was bad, causing FFMPEG to quit. The simple solution is to use the `-o` flag on Youtube-DL to specify an output name. Though ideally, Youtube-DL shouldn't be outputting bad filenames to begin with. | bug | low | Critical |
266,340,213 | go | os: StartProcess ETXTBSY race on Unix systems | Modern Unix systems appear to have a fundamental design flaw in the interaction between multithreaded programs, fork+exec, and the prohibition on executing a program if that program is open for writing.
Below is a simple multithreaded C program. It creates 20 threads all doing the same thing: write an exit 0 shell script to /var/tmp/fork-exec-N (for different N), and then fork and exec that script. Repeat ad infinitum. Note that the shell script fds are opened O_CLOEXEC, so that an fd being written by one thread does not leak into the fork+exec's shell script of a different thread.
On my Linux workstation, this program produces a never-ending stream of ETXTBSY errors. The problem is that O_CLOEXEC is not enough. The fd being written by one thread _can_ leak into the forked child of a second thread, and it stays there until that child calls exec. If the first thread closes the fd and calls exec before the second thread's child does exec, then the first thread's exec will get ETXTBSY, because somewhere in the system (specifically, in the child of the second thread), there is an fd still open for writing the first thread's shell script, and according to modern Unix rules, one must not exec a program if there exists any fd anywhere open for writing that program.
Five years ago this bit us because cmd/go installed cmd/cgo (that is, copied the binary from a temporary location to somewhere/bin/cgo) and then executed it. To fix this we put a sleep+retry loop around the fork+exec of cgo when it gets ETXTBSY. Now (as of last week or so) we don't ever install cmd/cgo and execute it in the same cmd/go process, so that specific race is gone, although as I write this cmd/go still has the sleep+retry loop, which I intend to remove.
Last week this bit us again because cmd/go updated a build stamp in the binary, closed it, and executed it. The resulting flaky ETXTBSY failures were reported as #22220. A pending CL fixes this by not updating the build stamp in temporary binaries, which are the main ones we execute. There's still one case where we write+execute a program, which is `go test -cpuprofile x.prof pkg`. The cpuprofile flag (and a few others) cause cmd/go to leave the pkg.test in the current directory for debugging purposes but also run the test. Luckily running the test is currently the final thing cmd/go does, and it waits for any other fork+exec'ed programs to finish before fork+exec'ing the test. So the race cannot happen in this case.
In general this race is going to happen every time anyone writes a program that both writes and executes a program. It's easy to imagine other build systems running into this, but also programs that do things like unzip a zip file and then run a program inside it - think a program supervisor or mini container runtime. As soon as there are multiple threads doing fork+exec at the same time, and one of them is doing fork+exec of a program that was previously open for write in the same process, you have a mysterious flaky problem.
It seems like maybe Go should take care of this, if possible. We've now hit it twice in cmd/go, five years apart, and at least this past time it took the better part of a day to figure out. (I don't remember how long it took five years ago, in part because I don't remember anything about discovering it five years ago. I also don't want to rediscover all this five years from now.)
There are a few hacks we could use:
- In os.StartProcess, if we see ETXTBSY, sleep 100ms and try again, maybe a few times, up to say 1 second of sleeping. In general we don't know how long to sleep.
- Arrange with a locking mechanism that close must never complete during a fork+exec sequence. The end of the fork+exec sequence needs to be the point where we know the close-on-exec fds have been closed. Unfortunately there is no portable way to identify that point.
- If the exec fails and the child tells us and exits, we can wait for the exit. That's easy.
- If the exec succeeds, we find out because the exec closes the child's end of the status pipe, and we get EOF.
- If we know that an OS does close-on-exec work in increasing fd order, then we could also track the maximum fd we've opened and move the status pipe above that. Then seeing the status pipe close would mean all other fds are closed too.
- If the OS had a "close all fds above x", we could use that. (I don't know of any that do, but it sure would help.)
- It may not be OK to block all closes on a wedged fork+exec (in general an exec'ed program may be loaded from some slow network server).
- Note that vfork(2) is not a solution. Vfork is defined as the parent does not continue executing until the child is no longer using the parent's memory image. In the case of a successful exec, at least on Linux, vfork releases the memory image before doing any of the close-on-exec work, so the parent continues running before the child has closed the fds we care about.
None of these seem great. The ETXTBSY sleep, up to 1 second, might be the best option. It would certainly reduce the flake rate and in many cases would probably make it undetectable. It would not help exec of very slow-to-load programs, but that's not the common case.
I wondered how Java deals with this, and the answer seems to be that Java doesn't deal with this. https://bugs.openjdk.java.net/browse/JDK-8068370 was filed in 2014 and is still open.
#include <pthread.h>
#include <stdio.h>
#include <string.h>
#include <unistd.h>
#include <fcntl.h>
#include <stdlib.h>
#include <sys/wait.h>
#include <errno.h>
#include <stdint.h>
void* runner(void*);
int
main(void)
{
int i;
pthread_t pid[20];
for(i=1; i<20; i++)
pthread_create(&pid[i], 0, runner, (void*)(uintptr_t)i);
runner(0);
return 0;
}
char script[] = "#!/bin/sh\nexit 0\n";
void*
runner(void *v)
{
int i, fd, pid, status;
char buf[100], *argv[2];
i = (int)(uintptr_t)v;
snprintf(buf, sizeof buf, "/var/tmp/fork-exec-%d", i);
argv[0] = buf;
argv[1] = 0;
for(;;) {
fd = open(buf, O_WRONLY|O_CREAT|O_TRUNC|O_CLOEXEC, 0777);
if(fd < 0) {
perror("open");
exit(2);
}
write(fd, script, strlen(script));
close(fd);
pid = fork();
if(pid < 0) {
perror("fork");
exit(2);
}
if(pid == 0) {
execve(buf, argv, 0);
exit(errno);
}
if(waitpid(pid, &status, 0) < 0) {
perror("waitpid");
exit(2);
}
if(!WIFEXITED(status)) {
perror("waitpid not exited");
exit(2);
}
status = WEXITSTATUS(status);
if(status != 0)
fprintf(stderr, "exec: %d %s\n", status, strerror(status));
}
return 0;
} | NeedsInvestigation | high | Critical |
266,516,973 | vscode | [theming] editor.selectionForeground is not working | - VSCode Version: Code 1.17.2 (b813d12980308015bcd2b3a2f6efa5c810c33ba5, 2017-10-16T13:57:00.652Z)
- OS Version: Linux x64 4.8.0-59-generic
---
Steps to Reproduce:
1. Add customization for `workbench.colorCustomizations.editor.selectionForeground`
2. Save settings
Expected result: a text selection should use the configured foreground color
Actual result: it doesn't.
I notice that the tooltip in the settings editor says "Color of the selected text for high contrast". I'm not sure what that means, my only thought was that it might apply to the "High Contrast" theme I see mentioned in the docs. I tried to switch to that theme, but it doesn't make any difference whatsoever (seriously, none at all - it's weird because I thought I did that before and things looked different then - is high contrast broken now?).
In any case, I'd like to see selection foreground color implemented regardless of theme. For presentation purposes, I want a bright selection background color (my preference is bright yellow), and this is generally incompatible with any kind of syntax-highlight colored text.
| feature-request,debt,themes,editor-theming | high | Critical |
266,580,026 | TypeScript | Create Annex B lib target |
[Annex B](https://www.ecma-international.org/ecma-262/6.0/#sec-additional-ecmascript-features-for-web-browsers) is the 🚽 of JavaScript with such features like a broken `escape` method and the `blink` method for `string`s. We shouldn't offer broken functions by default, and (almost) no one wants to see `fontcolor` in their string completion list, but it *is* "standard", so we should have a separate `lib` target (in the same category as e.g. `dom`) for `annex-b` that squirrels away the Annex B declarations so people can still opt in if they want to. | Suggestion,Help Wanted,Committed,Effort: Moderate | low | Critical |
Subsets and Splits
No saved queries yet
Save your SQL queries to embed, download, and access them later. Queries will appear here once saved.