id
int64 393k
2.82B
| repo
stringclasses 68
values | title
stringlengths 1
936
| body
stringlengths 0
256k
⌀ | labels
stringlengths 2
508
| priority
stringclasses 3
values | severity
stringclasses 3
values |
|---|---|---|---|---|---|---|
259,373,986 | flutter | Document the various Method and BasicMessage channels | We have a number of communication channels that are used for different purposes, and their expected usage is not documented. Also, for creating new channels, the expected scope and naming conventions of channels are also not defined.
Some examples of existing channels:
```
flutter/accessibility
flutter/assets
flutter/keyevent
flutter/lifecycle
flutter/localization
flutter/navigation
flutter/platform
flutter/settings
flutter/system
flutter/textinput
```
Each one should be documented.
Some examples of files where they are used:
[shell/common/engine.cc](https://github.com/flutter/engine/blob/4aee64f6be1f20a1d68b6897ae1946d2bac0dd9c/shell/common/engine.cc#L43)
[shell/platform/android/io/flutter/view/FlutterView.java](https://github.com/flutter/engine/blob/4aee64f6be1f20a1d68b6897ae1946d2bac0dd9c/shell/platform/android/io/flutter/view/FlutterView.java#L165)
[shell/platform/darwin/ios/framework/Source/FlutterViewController.mm](https://github.com/flutter/engine/blob/4aee64f6be1f20a1d68b6897ae1946d2bac0dd9c/shell/platform/darwin/ios/framework/Source/FlutterViewController.mm#L150)
| framework,d: api docs,P2,a: plugins,team-framework,triaged-framework | low | Minor |
259,420,585 | vscode | Support Jupyter Notebook Interactive Computing paradigm | Around 500,000 VSCode users have been relying on Don Jayamanne has "vscodeJupyter" extension to connect to Jupyter Notebooks and execute code in an interactive environment. (https://github.com/DonJayamanne/vscodeJupyter)
With rapid continuing growth of Python, Data Science, and Deep Learning communities, Jupyter Notebooks and interactive computing need to be promoted to a first class citizen of VS Code, rather than being an extension developed by a volunteer.
Please refer to Atom + Hydrogen integration, and upcoming JupyerLab projects for ideas on how to integrate Notebooks inside Visual Studio Code.
Thank you! | feature-request | medium | Critical |
259,446,492 | opencv | Lots of warnings due to -Wundef and TBB on Linux/gcc | ##### System information (version)
- OpenCV => 3.3
- Operating System / Platform => Ubuntu 16.04 x86_64
- Compiler => GCC 5.4.0
##### Detailed description
When Compiling OpenCV with TBB (`WITH_TBB=ON`) and `tbbvars.sh` correctly initialised in the environment, CMake finds it just fine but during compilation I get an insane amount of useless warnings.
E.g.
```
/mnt/t/dev/ubuntu/libraries/tbb2017_20170604oss/include/tbb/tbb_config.h:573:11: warning: "_MSC_VER" is not defined [-Wundef]
#elif _MSC_VER == 1600
```
```
In file included from /mnt/t/dev/ubuntu/libraries/tbb2017_20170604oss/include/tbb/tbb_stddef.h:95:0,
from /mnt/t/dev/ubuntu/libraries/tbb2017_20170604oss/include/tbb/aligned_space.h:24,
from /mnt/t/dev/ubuntu/libraries/tbb2017_20170604oss/include/tbb/tbb.h:35,
from /mnt/t/dev/ubuntu/libraries/opencv/modules/core/include/opencv2/core/private.hpp:65,
from /mnt/t/dev/ubuntu/libraries/opencv/modules/core/src/precomp.hpp:55,
from /mnt/t/dev/ubuntu/libraries/opencv/build2/modules/core/opencv_core_pch_dephelp.cxx:1:
/mnt/t/dev/ubuntu/libraries/tbb2017_20170604oss/include/tbb/tbb_config.h:39:32: warning: "__APPLE__" is not defined [-Wundef]
#if !defined(__TBB_SYMBOL) && (__APPLE__ || __ANDROID__)
^
/mnt/t/dev/ubuntu/libraries/tbb2017_20170604oss/include/tbb/tbb_config.h:39:45: warning: "__ANDROID__" is not defined [-Wundef]
#if !defined(__TBB_SYMBOL) && (__APPLE__ || __ANDROID__)
^
/mnt/t/dev/ubuntu/libraries/tbb2017_20170604oss/include/tbb/tbb_config.h:58:5: warning: "__clang__" is not defined [-Wundef]
#if __clang__
```
There are literally hundreds, if not thousands, of these warnings complaining about undefined macros. A lot of those are obviously expected NOT to be defined for this platform/compiler/architecture combination.
##### Steps to reproduce
- Checkout OpenCV 3.3.0 code
- Download recent version of TBB (2017 update 7 or 2018)
- Modify tbbvars.sh to set TBBROOT correctly
- run `source tbbvars.sh intel64`
- In directory with OpenCV source code
```
$ mkdir build && cd build
$ cmake .. -DWITH_TBB=ON
$ make
```
Lots of warnings.
As an additional question, what's the recommended parallel framework for OpenCV these days? I seem to remember that OpenCV used to favour TBB above other options back in the day? I could be wrong. | feature,category: build/install | low | Major |
259,473,479 | TypeScript | small code change causes 70% build time regression (20s->34s) [strictGenericChecks] | **TypeScript Version:** 2.6.0-dev.20170921
**Code**
Sorry it's a bit bigger codebase, but it would be very hard I guess to reproduce a performance issue with little code.
If you pull https://github.com/emmanueltouzery/prelude.ts and run `npm install` and then `tsc`.
* On the `v0.2.1` tag the build time is ~20 seconds for me.
* On the `v0.2.2` tag the build time is ~34 seconds for me.
The difference between both tags is very small!
https://github.com/emmanueltouzery/prelude.ts/compare/v0.2.1...v0.2.2 `6 files changed, 8 insertions(+), 5 deletions(-)` (mostly I export an interface which was not marked as exported)
And also if I build with `strictGenericChecks: false`, the build time collapses from 34 seconds to 5 seconds even for `v0.2.2`.
**Expected behavior:**
A bit slower build with `strictGenericChecks` enabled, same build time for 0.2.1 and 0.2.2.
**Actual behavior:**
Almost 7 times slower build time with `strictGenericChecks`, 70% build time increase between 0.2.1 and 0.2.2. | Bug | low | Major |
259,488,859 | youtube-dl | [RTP] Add support to download live videos (Failed to download m3u8 information: HTTP Error 403: Forbidden) | ---
- [X] I've **verified** and **I assure** that I'm running youtube-dl **2017.09.15**
- [X] At least skimmed through the [README](https://github.com/rg3/youtube-dl/blob/master/README.md), **most notably** the [FAQ](https://github.com/rg3/youtube-dl#faq) and [BUGS](https://github.com/rg3/youtube-dl#bugs) sections
- [X] [Searched](https://github.com/rg3/youtube-dl/search?type=Issues) the bugtracker for similar issues including closed ones
### What is the purpose of your *issue*?
- [ ] Bug report (encountered problems with youtube-dl)
- [X] Site support request (request for adding support for a new site)
- [ ] Feature request (request for a new functionality)
- [ ] Question
- [ ] Other
---
Fail to download RTP live videos.
- Single video: http://www.rtp.pt/play/direto/rtp1
- Single video: http://www.rtp.pt/play/direto/rtp2
- Single video: http://www.rtp.pt/play/direto/rtp3
- Single video: http://www.rtp.pt/play/direto/rtpinternacional
- Single video: http://www.rtp.pt/play/direto/rtpmemoria
- Single video: http://www.rtp.pt/play/direto/rtpmadeira
- Single video: http://www.rtp.pt/play/direto/rtpacores
- Single video: http://www.rtp.pt/play/direto/rtpafrica
- Single video: http://www.rtp.pt/play/zigzag/direto/tv
```
$ youtube-dl --version
2017.09.15
$ youtube-dl --verbose 'http://www.rtp.pt/play/direto/rtp1'
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: [u'--verbose', u'http://www.rtp.pt/play/direto/rtp1']
[debug] Encodings: locale UTF-8, fs UTF-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2017.09.15
[debug] Python version 2.7.9 - Linux-4.4.88-desktop-1.mga5-x86_64-with-mandrake-5-Official
[debug] exe versions: ffmpeg 2.4.13, ffprobe 2.4.13
[debug] Proxy map: {}
[generic] rtp1: Requesting header
WARNING: Falling back on generic information extractor.
[generic] rtp1: Downloading webpage
[generic] rtp1: Extracting information
[generic] playlist: Downloading m3u8 information
ERROR: Failed to download m3u8 information: HTTP Error 403: Forbidden (caused by HTTPError()); please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type youtube-dl -U to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
File "/usr/bin/youtube-dl/youtube_dl/extractor/common.py", line 503, in _request_webpage
return self._downloader.urlopen(url_or_request)
File "/usr/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 2177, in urlopen
return self._opener.open(req, timeout=self._socket_timeout)
File "/usr/lib64/python2.7/urllib2.py", line 437, in open
response = meth(req, response)
File "/usr/lib64/python2.7/urllib2.py", line 550, in http_response
'http', request, response, code, msg, hdrs)
File "/usr/lib64/python2.7/urllib2.py", line 475, in error
return self._call_chain(*args)
File "/usr/lib64/python2.7/urllib2.py", line 409, in _call_chain
result = func(*args)
File "/usr/lib64/python2.7/urllib2.py", line 558, in http_error_default
raise HTTPError(req.get_full_url(), code, msg, hdrs, fp)
```
| request | low | Critical |
259,510,429 | vscode | Delete matching parentheses, brackets, or braces | - VSCode Version: Code 1.16.1 (27492b6bf3acb0775d82d2f87b25a93490673c6d, 2017-09-14T16:38:23.027Z)
- OS Version: Windows_NT x64 6.3.9600
- Extensions: Extensions are disabled
---
Steps to Reproduce:
1. Create a new file.
2. Paste the following code: `var foo = (1 + bar) + baz;`.
3. Position the cursor before the first `(`. It and its matching parenthesis should highlight.
4. Hit the delete key.
5. Only the first parenthesis is deleted.
It would be useful if the corresponding parenthesis, brace, or bracket were deleted when the targeted one was.
I see two ways to accomplish this:
1. Add a shortcut for both backspace and delete that does the operation on the matching character.
2. Automatically do the deletion. This could be an extension of the already-existing "editor.autoClosingBrackets" setting or (more likely) a new setting that governs this behavior.
<!-- Launch with `code --disable-extensions` to check. -->
Reproduces without extensions: Yes | feature-request,editor-core | high | Critical |
259,564,065 | opencv | cv::medianBlur does not support to specify the border type. | <!--
If you have a question rather than reporting a bug please go to http://answers.opencv.org where you get much faster responses.
If you need further assistance please read [How To Contribute](https://github.com/opencv/opencv/wiki/How_to_contribute).
This is a template helping you to create an issue which can be processed as quickly as possible. This is the bug reporting section for the OpenCV library.
-->
##### System information (version)
<!-- Example
- OpenCV => 3.1
- Operating System / Platform => Windows 64 Bit
- Compiler => Visual Studio 2015
-->
- OpenCV => :latest:
##### Detailed description
`cv::medianBlur` does not support to specify the border type and the API
does not tell how it handles the border.
`cv::blur`, `cv::boxFilter`, `cv::GaussianBlur` and `cv::bilateralFilter` all
support to specify the border type.
Please refer to https://github.com/opencv/opencv/blob/master/modules/imgproc/include/opencv2/imgproc.hpp#L1370
##### Steps to reproduce
<!-- to add code example fence it with triple backticks and optional file extension
```.cpp
// C++ code example
```
or attach as .txt or .zip file
--> | feature,category: imgproc,priority: low,category: documentation | low | Critical |
259,592,343 | rust | In-band lifetimes: Lint against single-use lifetime names | Once support for `'_` lands in https://github.com/rust-lang/rust/pull/44691, the next step for https://github.com/rust-lang/rust/issues/44524 is to implement a lint that warns against "single use" lifetime names.
### Current status
The lint is partially implemented but needs to be completed. Here is a checklist:
- [x] Issue warnings at the right times; [this gist](https://gist.github.com/nikomatsakis/acdeb20b0192e2a1f404d514b3002c59) provides a comprehensive test case.
- "Warning: never used at all" falls under `unused_lifetimes`
- [x] For each warning, issue a suggested fix:
- For a single-use lifetime `'a` appearing in `&'a T`, suggest `&T`
- For a single-use lifetime `'a` appearing in any other place, suggest `'_`
- One challenge: the binder must be removed too
- cc @estebank -- is it possible to give suggested fixes that make changes to multiple spots at once? I guess that might just be multiple suggestions?
- [] We'll know this is *really* done when we can enable by default in rustc crates and apply rustfix with suggestions
### Older Background
The idea is that an explicit name like `'a` should only be used (at least in a function or impl) to *link together* two things. Otherwise, you should just use `'_` to indicate that the lifetime is not linked to anything.
Until https://github.com/rust-lang/rust/issues/15872 is closed, we should only lint for single-use lifetime names that are bound in **functions**. Once #15872 is closed, we can also lint against those found in impl headers.
We can detect cases where a lint is valid by modifying [the `resolve_lifetimes` code](https://github.com/rust-lang/rust/blob/3cf28f3002470f61a471c69b869e4f55ae1766f7/src/librustc/middle/resolve_lifetime.rs):
- This code basically walks over the HIR and resolves all lifetime names.
- It maintains a stack of [scopes](https://github.com/rust-lang/rust/blob/3cf28f3002470f61a471c69b869e4f55ae1766f7/src/librustc/middle/resolve_lifetime.rs#L194-L230) indicating what names are valid.
- [The function `with()`](https://github.com/rust-lang/rust/blob/3cf28f3002470f61a471c69b869e4f55ae1766f7/src/librustc/middle/resolve_lifetime.rs#L781-L803) is used to push new scopes on the stack. It is also given a closure which will execute with the new name bindings in scope.
- `with()` gets called for impls and other kinds of items [from here](https://github.com/rust-lang/rust/blob/3cf28f3002470f61a471c69b869e4f55ae1766f7/src/librustc/middle/resolve_lifetime.rs#L348-L351); for methods and functions in particular it is called from [`visit_early_late`](https://github.com/rust-lang/rust/blob/3cf28f3002470f61a471c69b869e4f55ae1766f7/src/librustc/middle/resolve_lifetime.rs#L823)).
- Once a name is in scope, [`resolve_lifetime_ref()`](https://github.com/rust-lang/rust/blob/3cf28f3002470f61a471c69b869e4f55ae1766f7/src/librustc/middle/resolve_lifetime.rs#L866) is called to resolve an actual reference to a named lifetime.
- This could be used, for example, to update some information in the `Scope`, e.g. counting how many times a particular lifetime was referenced.
- Then, before `with()` returns, we could scan the lifetimes and check for those that were only referenced 1 time (or 0 times...) and issue a lint warning.
(There are some directions for how to add a lint under the header "Issuing future compatibility warnings" in [the rustc-bug-fix-procedure page on forge](https://forge.rust-lang.org/rustc-bug-fix-procedure.html) -- we can skip the "future compatibility" parts here.)
| A-lints,A-lifetimes,E-mentor,B-RFC-approved,T-compiler,C-tracking-issue,S-tracking-impl-incomplete,F-lint-single_use_lifetimes | medium | Critical |
259,602,081 | react-native | On iOS, orientation changes don't animate in a way that "looks native" | <!--
PLEASE DON'T DELETE THIS TEMPLATE UNTIL YOU HAVE READ THE FIRST SECTION.
-->
### Is this a bug report?
Yes
### Have you read the [Contributing Guidelines](https://facebook.github.io/react-native/docs/contributing.html)?
Yes
### Environment
Environment:
OS: macOS Sierra 10.12.6
Node: 8.4.0
Yarn: 1.0.1
npm: 5.4.1
Watchman: 4.5.0
Xcode: Xcode 8.3.3 Build version 8E3004b
Android Studio: 2.3 AI-162.3934792
Packages: (wanted => installed)
react: 16.0.0-alpha.12 => 16.0.0-alpha.12
react-native: 0.48.3 => 0.48.3
### Steps to Reproduce
1. Create a react native app w/ react native init
2. Run it on an iOS device or the iOS simulator
3. (If on a simulator) Turn on slow animations (CMD+T) so the issue will be more obvious.
4. Rotate the device a few times to landscape and portrait
5. Observe that immediately after the orientation changes, the view is resized to the dimensions of the new orientation, and THEN the rotation animation begins. The view's contents and dimensions are not _smoothly_ resized while the view is being rotated.
### Expected Behavior
In a regular native iOS app, when the orientation of the device changes, the view's contents and dimensions smoothly resize while the view is also rotated at the same time.
Here is a animated gif. This is a simple native app written in swift, see how the view resizes and rotates smoothly (at the same time) on orientation changes:
### Actual Behavior
On orientation changes, the view's dimensions and contents are resized once at the very beginning of the change, and then the rotation animation happens.
Here is another animated git. This is a simple RN app, with a red border applied to the view so you can see how the view's dimensions are immediately changed (not smoothly animated).
### Reproducible Demo
Sadly I can't seem to get the expo app to handle rotations so I guess having a Snack wouldn't be useful.
But you can see if yourself pretty easily if you:
1. Use `react-native init` to create a new app
2. Edit `index.ios.js` and add to the container's styles (line ~40):
```
borderColor: 'red',
borderWidth: 10,
```
3. Then run it, turn on slow animations in the simulator (CMD+T), and change the orientation a few times.
| Platform: iOS,Help Wanted :octocat:,Issue: Author Provided Repro,Bug | medium | Critical |
259,613,433 | TypeScript | Printer doesn't print jsDoc comments | <!-- BUGS: Please use this template. -->
<!-- QUESTIONS: This is not a general support forum! Ask Qs at http://stackoverflow.com/questions/tagged/typescript -->
<!-- SUGGESTIONS: See https://github.com/Microsoft/TypeScript-wiki/blob/master/Writing-Good-Design-Proposals.md -->
I'm using the compiler to convert some old JS files into TypeScript (specifically changing our old "classes" into TS/ES6 classes). I'm doing this by getting the original AST, applying some transformations, and then printing out the new AST to code.
JSDoc nodes are parsed just fine and are available in the original AST, but when printing out the AST back to source, they are missing.
**TypeScript Version:** 2.5.2
**Code**
Here's an example of just converting a simple class to AST, and trying to print it out again:
```ts
const ts = require('typescript');
const fileContents = `
export class MyClass {
/**
* My great documentation
*/
myMethod() { return 1; }
}
`;
const sourceFile = ts.createSourceFile('myFile.ts', fileContents, ts.ScriptTarget.ES2017, /* setParentNodes */ false);
const ast = sourceFile.statements[ 0 ];
const resultFile = ts.createSourceFile('newFile.ts', '', ts.ScriptTarget.Latest, /*setParentNodes*/ false, ts.ScriptKind.TS);
const printer = ts.createPrinter({ newLine: ts.NewLineKind.LineFeed, removeComments: false });
const result = printer.printNode(ts.EmitHint.Unspecified, ast, resultFile);
console.log(result);
```
**Expected behavior:**
The result from the `Printer` should be printed exactly as the input:
```ts
export class MyClass {
/**
* My great documentation
*/
myMethod() { return 1; }
}
```
**Actual behavior:**
The jsDoc comment is missing:
```ts
export class MyClass {
myMethod() { return 1; }
}
```
Great job btw with all of the functionality to be able to grab the AST and generate new AST nodes. Many thanks for that! | Bug | low | Critical |
259,620,461 | flutter | Adjacent Material Widgets in a Column/Row do not cast a shadow on each other | Internal: b/292548582
## Steps to Reproduce
When you create a widget that has a build method like this:
```dart
Widget build(BuildContext context) => return new Scaffold(
appBar: new AppBar(
title: new Text('Test'),
),
body: new Column(
children: <Widget>[
new Material(
color: Colors.blue.shade500,
child: new Container(height: 100.0),
elevation: 20.0,
),
new Material(
color: Colors.white,
child: new Container(height: 100.0),
elevation: 10.0,
),
new Material(
color: Colors.orange.shade500,
child: new Container(height: 100.0),
elevation: 20.0,
),
],
),
);
```
You get this result:
As you can see, only the shadow from the bottom-most, orange Material is rendered. I would expect there to be a shadow rendered over the middle, white Material from both the above and below, as both of those have higher elevation.
For bonus points, I would also expect the shadow over the white Material to be about half as large as the one cast over the scaffold background by the orange Material (because the former is going from elevation 20 to 10, while the latter is going from elevation 20 to 0). | framework,engine,f: material design,customer: mulligan (g3),customer: crowd,has reproducible steps,P2,found in release: 3.3,found in release: 3.7,team-design,triaged-design | low | Critical |
259,626,268 | rust | Tracking issue: Allow autoderef and autoref in operators (experiment) | This is a specific issue to track the changes proposed by @arielb1 in [RFC 2174](https://github.com/rust-lang/rfcs/pull/2147). We decided to roll this into a [larger experiment around coercions, generics, and Copy type ergonomics](https://github.com/rust-lang/rust/issues/44619) and are therefore ready to implement (but not yet stabilize).
| E-mentor,T-compiler,C-tracking-issue,S-tracking-unimplemented | medium | Major |
259,653,363 | javascript | Provide clarity around chained function indents | My coworkers and I are having trouble deciding how best to indent chained function calls, covered in section [19.6 - Whitespace > Chains](https://github.com/airbnb/javascript/blob/eslint-config-airbnb-v15.1.0/README.md#whitespace--chains)
It appears to me that one of the 'good' examples given doesn't actually pass ESLinting:
```
// good
const leds = stage.selectAll('.led')
.data(data)
.enter().append('svg:svg')
.classed('led', true)
.attr('width', (radius + margin) * 2)
.append('svg:g')
.attr('transform', `translate(${radius + margin},${radius + margin})`)
.call(tron.led);`
```
In particular, it complains about the indentation being 4 spaces instead of 2, for the 5 lines where that's the case.
What's more, even though it might technically be permitted, there is some weirdness in this example that we think should be elaborated upon and/or clarified. Here are two examples:
1. the second line (` .data(data)`) is indented 4 spaces, which at first glance seems pretty weird since it's two gutters in from it's parent. It makes more sense if the first line were split into two, though, e.g.
```
const leds = stage
.selectAll('.led')
.data(data)
.enter().append('svg:svg')
...
```
2. the third line, although also technically allowed (<= two chains per line), also strikes us a kind of code smell since, if using this level of nesting/indenting/detail, why not put each item on it's own line to increase legibility? e.g.
```
...
.enter()
.append('svg:svg')
...
```
Overall, we had some pretty involved discussion around when and where to use which, and often it seemed to be difficult to reason about because the semantics of the indenting seemed to depend on the semantics of the methods being called, which is tough to be consistent about. There are different strategies to deal with this, but it would be nice if this guide had an opinion that we could rely upon, instead of having to debate the merits of each alternative.
---
For instance, in #19, the issue that seems to have introduced function chaining rules, @quirkyjack proposes that
> Blocks at even indent level are all acting on the last selector in the chain, [e.g.]
```
$('#foo')
.find('.baz')
.doSomething()
.end()
.find('.moo')
.doSomethingElse()
```
...whereas in [jQuery's `.end()` docs](https://api.jquery.com/end/)...
> A long jQuery chain can be visualized as a structured code block, with filtering methods providing the openings of nested blocks and end() methods closing them:
```
$( "ul.first" )
.find( ".foo" )
.css( "background-color", "red" )
.end()
.find( ".bar" )
.css( "background-color", "green" )
.end();
```
Surely both should be preferred to a flat-indented equivalent (since the indents do add clarity and readability via grouping), but how should they be enforced consistently? Or even just pass linting, as the case may be. A 'flat-indenting' example:
```
// tough to follow
$( "ul.first" )
.find( ".foo" )
.css( "background-color", "red" )
.end()
.deferrablePlugin()
.then(handler)
.catch(errorHandler)
.closest( ".bar" )
.css( "background-color", "green" )
.parent()
.chainable($el => {
// long function
})
.prevSibling(); | pull request wanted,editorial | low | Critical |
259,779,033 | every-programmer-should-know | What are some good resources on Data Structures? | Books, courses, visualizations - everything will do. | Needs some ❤️ | low | Major |
259,785,484 | kubernetes | EBS volume remains attached | <!-- This form is for bug reports and feature requests ONLY!
If you're looking for help check [Stack Overflow](https://stackoverflow.com/questions/tagged/kubernetes) and the [troubleshooting guide](https://kubernetes.io/docs/tasks/debug-application-cluster/troubleshooting/).
-->
**Is this a BUG REPORT or FEATURE REQUEST?**:
> Uncomment only one, leave it on its own line:
>
/kind bug
> /kind feature
@kubernetes/sig-aws-bugs
@kubernetes/sig-storage-bugs
**What happened**:
A dynamic gp2 EBS volume fails detaching when it's PVC is deleted.
**What you expected to happen**:
The volume should detach from the node and be deleted.
**How to reproduce it (as minimally and precisely as possible)**:
1. Create a gp2 PVC in a custom namespace.
2. Attach the volume to a Pod that is serving NFS using it.
3. Delete the NFS deployment.
4. Delete PVC.
5. View PV logs (describe)
**Anything else we need to know?**:
The Pod is serving kernel space NFS with privileged execution enabled.
**PV logs show:**
`Name: pvc-6d16e0e2-9e61-11e7-8d0a-020e29f6e7aa
Labels: failure-domain.beta.kubernetes.io/region=eu-west-1
failure-domain.beta.kubernetes.io/zone=eu-west-1c
Annotations: kubernetes.io/createdby=aws-ebs-dynamic-provisioner
pv.kubernetes.io/bound-by-controller=yes
pv.kubernetes.io/provisioned-by=kubernetes.io/aws-ebs
StorageClass: gp2
Status: Released
Claim: ns-lala/pvc-gp2-3-lala-my-second-env
Reclaim Policy: Delete
Access Modes: RWO
Capacity: 100Gi
Message:
Source:
Type: AWSElasticBlockStore (a Persistent Disk resource in AWS)
VolumeID: aws://eu-west-1c/vol-02e0d7af3a2ed3cd7
FSType: ext4
Partition: 0
ReadOnly: false
Events:
FirstSeen LastSeen Count From SubObjectPath Type Reason Message
--------- -------- ----- ---- ------------- -------- ------ -------
6m 6m 1 persistentvolume-controller Normal VolumeDelete VolumeInUse: Volume vol-02e0d7af3a2ed3cd7 is currently attached to i-098542f86525fa716
status code: 400, request id: 1f147f8f-46a4-4a84-a4c8-57fa36f1291c
5m 5m 1 persistentvolume-controller Normal VolumeDelete VolumeInUse: Volume vol-02e0d7af3a2ed3cd7 is currently attached to i-098542f86525fa716
status code: 400, request id: 00e8ad51-235d-49e1-a6d9-7471a4783be7
5m 5m 1 persistentvolume-controller Normal VolumeDelete VolumeInUse: Volume vol-02e0d7af3a2ed3cd7 is currently attached to i-098542f86525fa716
status code: 400, request id: d2dd099a-8078-462a-9fc4-4e22a7403aaf
5m 5m 1 persistentvolume-controller Normal VolumeDelete VolumeInUse: Volume vol-02e0d7af3a2ed3cd7 is currently attached to i-098542f86525fa716
status code: 400, request id: ec0cc658-30f1-4a77-a30f-caf1f2f51b7a
5m 5m 1 persistentvolume-controller Normal VolumeDelete VolumeInUse: Volume vol-02e0d7af3a2ed3cd7 is currently attached to i-098542f86525fa716
status code: 400, request id: 9d8d255f-25d9-4bf3-875e-511ab15bcbcf
4m 4m 1 persistentvolume-controller Normal VolumeDelete VolumeInUse: Volume vol-02e0d7af3a2ed3cd7 is currently attached to i-098542f86525fa716
status code: 400, request id: 8fad4241-6e91-4405-9556-83d52ec64a36
4m 4m 1 persistentvolume-controller Normal VolumeDelete VolumeInUse: Volume vol-02e0d7af3a2ed3cd7 is currently attached to i-098542f86525fa716
status code: 400, request id: 867143c0-8114-4260-a592-8aaa1a0b92ad
3m 3m 1 persistentvolume-controller Normal VolumeDelete VolumeInUse: Volume vol-02e0d7af3a2ed3cd7 is currently attached to i-098542f86525fa716
status code: 400, request id: 30398105-fde1-42af-8c6b-e2bf84bed2bf
2m 2m 1 persistentvolume-controller Normal VolumeDelete VolumeInUse: Volume vol-02e0d7af3a2ed3cd7 is currently attached to i-098542f86525fa716`
**Environment**:
- Kubernetes version (use `kubectl version`): Client Version: version.Info{Major:"1", Minor:"6", GitVersion:"v1.6.7", GitCommit:"095136c3078ccf887b9034b7ce598a0a1faff769", GitTreeState:"clean", BuildDate:"2017-07-05T16:51:56Z", GoVersion:"go1.7.6", Compiler:"gc", Platform:"linux/amd64"}
- Cloud provider or hardware configuration**: AWS / m4.xlarge
- OS (e.g. from /etc/os-release): Debian GNU/Linux 8 (jessie)
- Kernel (e.g. `uname -a`): Linux ip-172-20-98-70 4.4.78-k8s #1 SMP Fri Jul 28 01:28:39 UTC 2017 x86_64 GNU/Linux
- Install tools: KOPS
- Others: None
| kind/bug,sig/storage,lifecycle/frozen,area/provider/aws | medium | Critical |
259,799,790 | go | net/http: no Client API to close server connection based on Response | ### What version of Go are you using (`go version`)?
1.8
### What operating system and processor architecture are you using (`go env`)?
linux/amd64
### What did you do?
I'm using http.Client that connects to HTTP/2 server. I would like to prevent reusing the connection if last response had error 500.
I tried to implement something like this, but I failed:
- Transport.CancelRequest doesn't work for HTTP/2,
- Request.Cancel works only on a single stream in HTTP/2 connection,
- CloseIdleConnections won't work if the connection is in use.
- I also tried to use httptrace.GetConn to steal net.Conn used by the request and close it, but this is against httptrace protocol.
I did small research and I can't find any way to implement such a thing.
This is a feature request to add it.
Background:
I have an environment where I have tcp load balancer with few replicas behind.
While new connections are directed only to healthy replicas, the existing ones are always attached to the same replica (even if it becomes unhealthy).
If http.Client is attached to replica which became unhealthy, reusing the same connection will cause directing request to the same unhealthy instance.
A more reasonable approach in this case is to reconnect so that load balancer can attach a healthy replica.
| Thinking,NeedsDecision,FeatureRequest | low | Critical |
259,840,577 | go | go/types: incorrect error message for string(1<<s + 1.1) | Type-checking the program
```
package p
var s uint
var _ = string(1<<s + 1.0)
```
produces the error:
```
x.src:3:16: cannot convert 1 << s + 1.0 (untyped float value) to string
```
But the correct error would be:
```
cannot shift 1 (untyped float value)
```
See also the TODO in go/types/conversions.go. | NeedsFix | low | Critical |
259,937,253 | youtube-dl | subscriptions.viddler.com support | ## Please follow the guide below
- You will be asked some questions and requested to provide some information, please read them **carefully** and answer honestly
- Put an `x` into all the boxes [ ] relevant to your *issue* (like this: `[x]`)
- Use the *Preview* tab to see what your issue will actually look like
---
### Make sure you are using the *latest* version: run `youtube-dl --version` and ensure your version is *2017.09.15*. If it's not, read [this FAQ entry](https://github.com/rg3/youtube-dl/blob/master/README.md#how-do-i-update-youtube-dl) and update. Issues with outdated version will be rejected.
- [x] I've **verified** and **I assure** that I'm running youtube-dl **2017.09.15**
### Before submitting an *issue* make sure you have:
- [x] At least skimmed through the [README](https://github.com/rg3/youtube-dl/blob/master/README.md), **most notably** the [FAQ](https://github.com/rg3/youtube-dl#faq) and [BUGS](https://github.com/rg3/youtube-dl#bugs) sections
- [x] [Searched](https://github.com/rg3/youtube-dl/search?type=Issues) the bugtracker for similar issues including closed ones
### What is the purpose of your *issue*?
- [ ] Bug report (encountered problems with youtube-dl)
- [ ] Site support request (request for adding support for a new site)
- [x] Feature request (request for a new functionality)
- [ ] Question
- [ ] Other
---
Please consider adding support to the viddler extractor for subscriptions.viddler.com URLs. They looks like.
http://subscriptions.viddler.com/channelname/videoname
where channelname is the name of the account providing the fee and videoname is a video id which appears to be a six char [a-z0-9] code. This appears to be a playlist, but maybe it works for single videos as well?
When I go to the URL, it redirects me first to
http://subscriptions.viddler.com/channelname/accounts/sign_in
to enter login/passwd. Also if I try youtube-dl I get this:
`ERROR: Unsupported URL: http://subscriptions.viddler.com/channelname/accounts/sign_in?redirect_to=http%3A%2F%2Fsubscriptions.viddler.com%2Fchannelname%videoname`
so that URL might be able to be used in the extractor if that helps.
Please let me know if I can provide any more info. Unfortunately I can't provide the particular channelname and videoname, I don't have permission. But maybe it's possible to find a free one that could be used for tests? | account-needed | low | Critical |
260,000,482 | TypeScript | Union type inference failure in generic function | <!-- BUGS: Please use this template. -->
**TypeScript Version:** 2.2.2 and the one used here https://www.typescriptlang.org/play/ (latest i suppose)
**Code**
```ts
function FieldToName<TData>(name: keyof TData | { name: keyof TData }): keyof TData {
if (typeof name === 'string') return name;
else return name.name; // 1
}
```
**Expected behavior:**
Should compile flawlessly.
**Actual behavior:**
failure to compile at line *//1*:
>Property 'name' does not exist on type 'keyof TData | { name: keyof TData; }'.
Property 'name' does not exist on type 'keyof TData'. | Bug | low | Critical |
260,027,558 | go | proposal: encoding/json: support struct tag for time.Format in JSON Marshaller/Unmarshaller | I will start with the proposal as a TL;DR before explaining the motivations behind it:
**Proposal**
It would be quite convenient if we could have the `encoding/json` package understand the format of `time.Time` as part of the struct definition. Something like this:
```go
type User struct {
Name string
JoinDate time.Time `time:"2006-01-02"`
}
```
This means that when you write `json.Unmarshal(data, &user)`, the json package will understand what format to parse/serialize the field with.
**Motivation/Experience Report**
Currently, there are three workarounds:
1. `type MyTime time.Time`: [https://goplay.space/#APZL4Rzlm_](https://goplay.space/#APZL4Rzlm_)
2. Embedding time.Time in MyTime type: https://goplay.space/#q-oKnSTtQV
3. Implementing `json.Unmarshaller` on the parent struct: https://goplay.space/#mzb8MQfajl
Those workarounds are not bad. However, I've noticed that they get out of hand once your codebase starts to scale.
Imagine having hundreds of structs with hundreds of fields where many of them could have different Time types just because they have different serialization formats, and nothing else.
The `time.Time` package, I think, might be too opinionated to assume RFC3339 is the only acceptable format in the `json.Unmarshaller` interface: https://github.com/golang/go/blob/ce10e9d84574112b224eae88dc4e0f43710808de/src/time/time.go#L1366. (Same goes for RFC3339Nano in the json.Marshaller implementation).
I think it makes sense for it to be a default serialization format, but not the only one. The workaround is initially not bad at all. However, it gets cumbersome when your project scales.
I think this proposal shows that the above solution can make our code more declarative and less cumbersome. This echo's Rob Pike's [talk](https://www.youtube.com/watch?v=rFejpH_tAHM) in that here we can hide complexity behind a simple interface.
Lastly, this doesn't make or break my Go experience, but I personally see room for enhancement here. | Proposal,Proposal-Hold | high | Critical |
260,030,819 | rust | Initializing array of Option<T> using [None; n] syntax should not require std::marker::Copy for T | I am new to Rust so forgive me if this is a stupid assertion.
Currently if you have an array of ```Option<T>``` the ```std::marker::Copy``` must be on ```T``` when using the repeated element syntax while initializing the array.
Case and point:
```rust
let arr: [Option<String>; 5] = [None; 5];
```
Shouldn't the compiler know that it is only "copying" ```None``` and allow the assignment? | T-compiler,C-feature-request,A-array | medium | Critical |
260,104,198 | go | doc: contribution guidelines: reference and/or incorporate docs for git/gerrit | The contribution guidelines explicitly assume a working knowledge of git and implicitly assume a working knowledge of gerrit.
These are large systems but the average contributor will need to know only a few basics of each to proceed. Linking to appropriate and specific documentation for what is needed in the common case will make it easier for a potential contributor to attain any missing knowledge, judge the necessary time investment of the desired contribution, and, if nothing else, realize that this isn't that complicated.
Git is a very common tool but has many obscure commands and abstruse workflows. Stating that a contributor has a "basic understanding of Git" can mean quite a lot of things, but the understanding necessary is, indeed, quite basic.
Aside from the commands provided by the `codereview` extension, and rare commands needed for troubleshooting, the average contributor whould only need to know a handful of commands and tasks that can be exhaustively listed. Saying something along the lines of "A contributor should be familiar with
- `git add`
- `git branch`
- (and so on)
If not, see _this linked tutorial_", would not add much to the length of the docs but would let a reader say either
- okay, I know all that—great!
- hmm, I guess I need to click that link . . .
While few may need to click that link (or links), it would be very reassuring to know upfront that you won't be spending the afternoon on stackoverflow trying to figure out why `git eldritch-horror` fails with `error: no erorr`. Anyone who does needs to click that link would surely appreciate finding that out before starting.
Gerrit is simpler than git, but it is a much less commonly used tool.
The docs assume far too much knowledge of its use to the point that for the most part it is written as if gerrit is something that just automatically happens outside the contribution process, though it is where everything important takes place. When steps to be taken in gerrit are mentioned it often only says *what* needs to be done and not *how* to do it. This is sufficient for anyone who has used gerrit before but can be intimidating for someone who has never used gerrit. (The [Reviewing code by others](https://golang.org/doc/contribute.html#download) section is an excellent example of a good mix of what and how, though it appears to be outdated).
Like git, there should be very few tasks required of the average contributor that can be exhaustively listed, linking to mini how-tos for general tasks such as drafting and submitting comments.
Screencasts of common tasks and annotated screenshots (even if the annotation is "just ignore this") of various common polygerrit screens could also help demystify the experience.
The how-tos, screencasts, and screenshots could be hosted on the wiki, if they do not already exist: the important part is that the docs link to those, wherever they may be, when appropriate.
CC @spf13 | Documentation,NeedsFix | low | Critical |
260,105,800 | rust | rustc silently ignores invalid -C target-feature names | Compiling a simple `Hello, World` program:
```
$ rustc -V
rustc 1.20.0 (f3d6973f4 2017-08-27)
# Note the trailing "zzzz"
$ RUSTFLAGS=-Ctarget-feature=+crt-staticzzzz cargo build -v
Compiling rust-test v0.1.0 (rust-test)
Running `rustc --crate-name rust_test src/main.rs --crate-type bin --emit=dep-info,link -C debuginfo=2 -C metadata=aafe1708c049ad76 -C extra-filename=-aafe1708c049ad76 --out-dir rust-test/target/debug/deps -L dependency=rust-test/target/debug/deps '-Ctarget-feature=+crt-staticzzzz'`
Finished dev [unoptimized + debuginfo] target(s) in 0.25 secs
```
Should `RUSTFLAGS=-Ctarget-feature=+crt-staticzzzz` be silently accepted?
If I pass `RUSTFLAGS=-Ctarget-feature=+batman`, a warning is printed, as expected.
```
'+batman' is not a recognized feature for this target (ignoring feature)
```
Why is trailing misspelling silently allowed? | C-enhancement,A-diagnostics,T-compiler,A-target-feature | low | Critical |
260,121,723 | rust | Crate not found when using extern macro in another macro and invoked from another crate | ```rust
// -----------------------------------------------
// serde-test/src/lib.rs
//! This crate provides a macro that creates serializable structs.
#![feature(use_extern_macros)]
#[doc(hidden)]
pub extern crate serde_derive;
#[macro_export]
macro_rules! serde_test {
() => {
#[derive($crate::serde_derive::Deserialize, $crate::serde_derive::Serialize)]
pub struct Serializable {
}
}
}
// -----------------------------------------------
// serde-test-test/Cargo.toml
[package]
name = "serde-test-test"
version = "0.1.0"
authors = ["Tim Kuehn <[email protected]>"]
[dependencies]
serde-test = { path = "../serde-test" }
// -----------------------------------------------
// serde-test-test/src/lib.rs
#![feature(use_extern_macros)]
#[macro_use]
extern crate serde_test;
serde_test! {}
```
In serde-test-test directory:
```$ cargo build
error[E0463]: can't find crate for `_serde`
--> src/lib.rs:6:1
|
6 | serde_test! {}
| ^^^^^^^^^^^^^^ can't find crate
|
= note: this error originates in a macro outside of the current crate
error: aborting due to previous error
error: Could not compile `serde-test-test`.
To learn more, run the command again with --verbose.
```
This error goes away if you add `serde = "*"` to serde-test-test/Cargo.toml. | T-compiler,A-macros-2.0,C-bug | low | Critical |
260,128,290 | rust | `std::io::Read::read_to_end` does not specialize for `&[u8]` or `Take<&'a [u8]>` | `read_to_end` currently includes some logic to do exponentially large `.resize` / `.read` operations.
For `&[u8]` or `Take<&'a [u8]>`, the problem is much simpler as we know the size that will be required :
```rust
v.extend_from_slice(&data);
let n = v.len();
data = &data[n..];
```
The `manual` implementation is typically between 3 and 5 times faster on my computer.
Assuming what seems a non-pathological case : no resize required, the `Vec` has a sufficient capacity to begin with, and running the following benchmark https://gist.github.com/fulmicoton/a1fb87c3f3578f118552917636c95933
yields the following result :
```
test tests::bench_read_manual ... bench: 9 ns/iter (+/- 1)
test tests::bench_read_std ... bench: 35 ns/iter (+/- 6)
```
| C-enhancement,T-libs,A-io | low | Major |
260,134,451 | pytorch | Learning rate scheduler have different APIs | The default API for step is either step() or step(epoch): https://github.com/pytorch/pytorch/blob/master/torch/optim/lr_scheduler.py#L26
The default API for ReduceLROnPlateau is step(metric):
https://github.com/pytorch/pytorch/blob/master/torch/optim/lr_scheduler.py#L252
Moreover, **this is not documented**. In fact, none of the LR schedulers have .step documented. Please either document this thoroughly or fix it.
http://pytorch.org/docs/master/optim.html#how-to-adjust-learning-rate
cc @vincentqb | module: optimizer,triaged | low | Minor |
260,137,672 | go | runtime: ebpf uretprobe support | We had issue with using uprobes with ebpf due to dynamic nature of golang stacks. Is there a proposal/way to address that? | help wanted,OS-Linux,compiler/runtime | medium | Major |
260,243,572 | pytorch | Add the new lr_scheduler which called poly | The learning policy is from [DeepLab v2](https://arxiv.org/abs/1606.00915):
> Learning rate policy: We have explored different learning rate policies when training DeepLab-LargeFOV. Similar to [86], we also found that employing a “poly” learning rate policy (the learning rate is multiplied by (1 iter max iter )power) is more effective than “step” learning rate (reduce the learning rate at a fixed step size).
If you agree, I open a pull request later.
cc @vincentqb | module: optimizer,triaged | low | Minor |
260,279,901 | go | net/http: decide how users should use SetSessionTicketKeys with ServeTLS, etc | ## Short version:
Using `tls.Config.SetSessionTicketKeys` does not work with `http.Server.ServeTLS` (and all methods that build on it, like `ListenAndServeTLS`).
Problem arises because `tls.Config` [gets cloned](https://github.com/golang/go/blob/release-branch.go1.9/src/net/http/server.go#L2748) inside `ServeTLS` and there seems to be no way to reference the new one from "outside". If this behavior can't be changed, at least a mention in the docs might be nice! :wink:
## Long version:
### What version of Go are you using (`go version`)?
1.9 (but problem seems to be present starting with 1.5)
### Does this issue reproduce with the latest release?
yes
### What operating system and processor architecture are you using (`go env`)?
```
GOARCH="amd64"
GOBIN=""
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/home/costela/go"
GORACE=""
GOROOT="/usr/lib/go-1.9"
GOTOOLDIR="/usr/lib/go-1.9/pkg/tool/linux_amd64"
GCCGO="gccgo"
CC="gcc"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build167108121=/tmp/go-build -gno-record-gcc-switches"
CXX="g++"
CGO_ENABLED="1"
PKG_CONFIG="pkg-config"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
```
### What did you do?
Attempt to use `tls.Config.SetSessionTicketKeys` on a running server, which is explicitly mentioned as possible in the docs:
```go
httpsServer := &http.Server{
Addr: "localhost:https",
TLSConfig: &tls.Config{
SessionTicketKey: [32]byte{...some hard-coded key...}
},
}
go func() {
keys := make([][32]byte, 1)
for t := range time.Tick(10 * time.Second) {
bytes, _ := t.MarshalBinary()
copy(keys[0][:], bytes)
tlsConfig.SetSessionTicketKeys(keys) // yes, I'm aware this is highly insecure ;)
}
}()
log.Fatal(httpsServer.ListenAndServeTLS("some.crt", "some.key"))
```
And then checked to see if session-resumption works with:
```
$ openssl s_client -connect localhost:443 -sess_out session.tmp -quiet
$ openssl s_client -connect localhost:443 -sess_in session.tmp | grep Reused
```
### What did you expect to see?
* session being reused in the first 10 seconds (using the hard-coded initial key)
* session being reused "inside" a 10 second tick (using the same time-based key)
* session **not** being reused "between" two 10 second ticks (using different time-based keys)
### What did you see instead?
Session was reused in all scenarios, consistent with what would be expected because of the `tls.Config` cloning mentioned in the "short" explanation above.
### Why is this a problem?
Because there is no mention in the docs (or did I miss something?) that using `ServeTLS` and friends will cause your reference to `tls.Config` to become "useless", in the sense that it doesn't reflect the running server's state. Workaround would be to create your own `net.Listener`, but that means a lot of boilerplate code, e.g. replicating `tcpKeepAliveListener`, etc.
I think I understand why the clone might be necessary (I imagine it has to do with not changing it because it might be reused), but I can't think of a reason to not update the pointer in the `http.Server` struct to point to the new clone. Am I missing something obvious?
But even if I am, it would be nice to mention this "gotcha" in the docs (I'd be happy to prepare a small PR for that if there are no objections) | NeedsDecision,early-in-cycle | low | Critical |
260,292,401 | rust | Tracking issue for RFC 2011: Generic assert | This is a tracking issue for rust-lang/rfcs#2011.
The feature gate for the issue is `#![feature(generic_assert)]`.
Sub tracking-issue: #96949.
### About tracking issues
Tracking issues are used to record the overall progress of implementation.
They are also used as hubs connecting to other relevant issues, e.g., bugs or open design questions.
A tracking issue is however *not* meant for large scale discussion, questions, or bug reports about a feature.
Instead, open a dedicated issue for the specific matter and add the relevant feature gate label.
### Steps
- [x] Implementation (see section *Implementation history*)
- [ ] Final comment period (FCP)[^1]
- [ ] Stabilization PR
[^1]: https://std-dev-guide.rust-lang.org/feature-lifecycle/stabilization.html
### Blockers
* [Does not work in const eval yet](https://github.com/rust-lang/rust/pull/96496#issuecomment-1126815652).
### Implementation history
* #97233
* #97450
* #97665
* #98148
* #98337
* #111928
* #135139
* #135712 | B-RFC-approved,T-libs-api,T-compiler,C-tracking-issue,A-error-handling,A-fmt,Libs-Tracked,PG-error-handling,S-tracking-impl-incomplete,F-generic_assert | medium | Critical |
260,293,799 | rust | Tracking issue for RFC 2045: improving `#[target_feature]` | This is a tracking issue for the `#[target_feature]` segment of RFC 2045 (https://github.com/rust-lang/rfcs/pull/2045).
`#[cfg(target_feature)]` was tracked in [#29717](https://github.com/rust-lang/rust/issues/29717) and has since been stabilized.
**Steps**
* [x] Implement the proposed `#[target_feature]` semantics
* [x] Document these semantics: https://github.com/rust-lang/reference/pull/545
* [ ] Stabilize
* x86_64 & i686
* [x] The basic set (sse–sse4.2, avx, avx2, ...) (#49664)
* [x] adx: https://github.com/rust-lang/rust/pull/93745
* [ ] avx512
* [x] ~~mmx~~ (never going to be stabilized)
* [ ] sse4a
* [ ] tbm
* [ ] lahfsahf
* [ ] prfchw
* [ ] arm
* [ ] aarch64
* [ ] hexagon
* [ ] powerpc
* [ ] mips
@gnzlbg have anything else you want filled out here?
*(below added from comments on PR)*
- [ ] consensus on the API for run-time feature detection
- [ ] should `cfg!(feature)` work across #[inline(always)] functions, generics, etc?
And some related tasks:
- [x] API breaking change: allow `#[target_feature]` on unsafe functions only
- [x] API breaking change: `#[target_feature = "+feature"]` => `#[target_feature(enable = "feature")]`
- [ ] fix bug: https://github.com/rust-lang/rust/issues/42515
- [x] resolve bug: https://github.com/rust-lang/rust/issues/44367
| A-stability,T-lang,T-libs-api,B-unstable,A-SIMD,C-tracking-issue,Libs-Tracked,S-tracking-design-concerns,A-target-feature | high | Critical |
260,340,503 | go | x/build: Add gdb to Windows Builders | As observed in golang/go#22012 the Windows builders do not have gdb causing them to skip any gdb related test.
Add [gdb to these packages](https://github.com/golang/build/blob/master/env/windows/startup.ps1#L134)
| OS-Windows,Builders,NeedsFix | low | Major |
260,350,423 | rust | Add --slowtest mode to test harness for finding the slowest test | [Elixir has this](https://twitter.com/elixirlang/status/912361337287856128). It would be pretty useful for speeding up large testsuites.
Probably should exist as a `--slowtest N` parameter to the test harness, which `cargo test` passes down.
Doubt this needs an RFC? | C-feature-request,A-libtest | low | Major |
260,394,295 | rust | resolve how to handle constants and default binding modes | Another interesting question that @tschottdorf encountered when implementing default binding modes: What do we do with constants? The RFC specifies that we ought to treat a `FOO` binding that resolves to a constant as something which can skip through `&T` types -- however, that runs into trouble if the type of the constant itself is `&str` or `&[T]`. The current logic at least skips through all `&T` or `&mut T` types when it skips through *any*, but handling `&str` correctly would require skipping through "only the right number".
@tschottdorf implemented various rules but we should at minimum update the RFC to match. | T-compiler,C-feature-request | low | Minor |
260,402,540 | go | cmd/compile: redundant branch | ```
func f(x interface{}) bool {
if x == nil {
return false
}
switch x.(type) {
case bool:
return true
default:
return false
}
}
```
Compiles to
```
0x0000 00000 (/Users/khr/go/tmp4.go:3) MOVQ "".x+8(SP), AX
0x0005 00005 (/Users/khr/go/tmp4.go:4) TESTQ AX, AX
0x0008 00008 (/Users/khr/go/tmp4.go:4) JEQ 47
0x000a 00010 (/Users/khr/go/tmp4.go:7) JEQ 41
...
```
That second branch is useless. We should get rid of it somehow.
| Performance,compiler/runtime | low | Minor |
260,426,751 | go | gotype: type-checking external test files that rely on internal test files fails | I tried to use `go/types` to type check a package with internal test files (with `package foo`) and external test files (with `package foo_test`). The internal test files expose some symbols that the external test files consume. This works fine in `go test`. However, the `go/types` code does not recognize the symbols exported by the internal test files.
I want to use the `go/types` package to write a refactoring tool that consumes external test files that rely on symbols exported by internal tests files, but I can't because of this error.
I think the issue is that the `go/types` import logic ignores the internal `_test.go` files when type-checking the external `_test.go` files. The `go/types` config https://golang.org/pkg/go/types/#Config does not seem to have a knob to import `_test.go` files.
### What version of Go are you using (`go version`)?
```
go version go1.9 darwin/amd64
```
### Does this issue reproduce with the latest release?
Yes
### What operating system and processor architecture are you using (`go env`)?
```
GOARCH="amd64"
GOOS="darwin"
```
### What did you do?
I created a new package `testgotypes` with 3 files:
`testgotypes.go`, without this file gotype doesn't run:
```
package testgotypes
```
`internal_test.go`, which exports a variable for the external test:
```
package testgotypes
var Export = "hello"
```
`external_test.go`, which tries to access the variable exported by `internal_test.go`:
```
package testgotypes_test
import (
"testing"
"testgotypes"
)
func TestExport(t *testing.T) {
if testgotypes.Export != "hello" {
t.Error("uh oh")
}
}
```
I ran tests, which worked just fine:
```
➜ testgotypes git:(master) go test -v
=== RUN TestExport
--- PASS: TestExport (0.00s)
PASS
ok testgotypes 0.006s
```
Then I tried to run `gotype`, compiled from `/usr/local/Cellar/go/1.9/libexec/src/go/types/gotype.go`:
```
➜ testgotypes git:(master) gotype -x -t .
external_test.go:10:5: Export not declared by package testgotypes
```
It fails with the same error my refactoring code sees.
To sanity check `gotype`, I then renamed `internal_test.go` to `internal.go` to make it part of the non-test build. Then `gotype` is happy:
```
➜ testgotypes git:(master) mv internal_test.go internal.go
➜ testgotypes git:(master) gotype -x -t .
```
### What did you expect to see?
`gotype` successfully type checking `external_test.go`.
### What did you see instead?
`gotype` fails to type check the `external_test.go` file. | NeedsFix | low | Critical |
260,427,483 | youtube-dl | Error 404 while trying to download from Vimeo On Demand | Hello, everyone. I am getting an HTTP Error 404: Not Found while trying to download from Vimeo On Demand. Any guess on the reason this is happening? Thanks in advance.
C:\Users\lucas\Desktop\Downloads>youtube-dl -v -u lucas@com https://vimeo.com/ondemand/dozecamadas/190360067 --verbose
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['-v', '-u', 'PRIVATE', 'https://vimeo.com/ondemand/dozecamadas/190360067', '--verbose']
Type account password and press [Return]:
[debug] Encodings: locale cp1252, fs mbcs, out cp437, pref cp1252
[debug] youtube-dl version 2017.09.24
[debug] Python version 3.4.4 - Windows-10-10.0.15063
[debug] exe versions: none
[debug] Proxy map: {}
[vimeo:ondemand] dozecamadas: Downloading webpage
ERROR: Unable to download webpage: HTTP Error 404: Not Found (caused by HTTPError()); please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type youtube-dl -U to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmp1uop9avr\build\youtube_dl\extractor\common.py", line 503, in _request_webpage
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmp1uop9avr\build\youtube_dl\YoutubeDL.py", line 2178, in urlopen
File "C:\Python\Python34\lib\urllib\request.py", line 470, in open
File "C:\Python\Python34\lib\urllib\request.py", line 580, in http_response
File "C:\Python\Python34\lib\urllib\request.py", line 508, in error
File "C:\Python\Python34\lib\urllib\request.py", line 442, in _call_chain
File "C:\Python\Python34\lib\urllib\request.py", line 588, in http_error_default | account-needed | low | Critical |
260,428,929 | angular | Adding <webview> on an event or router navigation causes error: Uncaught TypeError: GuestViewContainer[(this.viewType + "BrowserPlugin")] is not a constructor | <!--
PLEASE HELP US PROCESS GITHUB ISSUES FASTER BY PROVIDING THE FOLLOWING INFORMATION.
ISSUES MISSING IMPORTANT INFORMATION MAY BE CLOSED WITHOUT INVESTIGATION.
-->
## I'm submitting a...
<!-- Check one of the following options with "x" -->
<pre><code>
[ ] Regression (a behavior that used to work and stopped working in a new release)
[ x ] Bug report <!-- Please search GitHub for a similar issue or PR before submitting -->
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question
</code></pre>
## Current behavior
<!-- Describe how the issue manifests. -->
I am adding a `<webview>` when the app first runs in a component, and then a second one on a button click. The first one is displayed without issue. The second one throws an error:
> Uncaught TypeError: GuestViewContainer[(this.viewType + "BrowserPlugin")] is not a constructor
The application is hosted as a Chrome app. The webviews are added by being contained in a component, the components are added via `*ngIf`.
The issue also manifests when adding the component containing the webview via the router and activating a route.
It is unclear to me if this is a bug in Angular or in Chrome. I am only able to reproduce the issue in Chrome.
## Expected behavior
<!-- Describe what the desired behavior would be. -->
I expect that the webview will be displayed properly without error whenever its added - when the app first runs or if its displayed later in response to an event or route being activated.
## Minimal reproduction of the problem with instructions
<!--
For bug reports please provide the *STEPS TO REPRODUCE* and if possible a *MINIMAL DEMO* of the problem via
https://plnkr.co or similar (you can use this template as a starting point: http://plnkr.co/edit/tpl:AvJOMERrnz94ekVua0u5).
-->
*STEPS TO REPRODUCE*
Load a webview in angular component either on event (e.g. button click) or via activating an angular route. You will get error "Uncaught TypeError: GuestViewContainer[(this.viewType + "BrowserPlugin")] is not a constructor" and callstack shown in "Others" section.
*MINIMAL DEMO*
To run packaged chrome app reproduction of the issue:
* Unzip the .zip file : [https://github.com/ArtOfContext/angular-chromeapp-adding-webview-throws-error-reproduction/raw/master/angular-chromeapp-adding-webview-throws-error-reproduction.zip](https://github.com/ArtOfContext/angular-chromeapp-adding-webview-throws-error-reproduction/raw/master/angular-chromeapp-adding-webview-throws-error-reproduction.zip)
* Navigate Chrome browser to chrome://extensions
* check the Developer mode button checkbox
* Click Load unpacked extension... button
* Browse to the folder that you just unzipped
* Find the Chrome app that was just added in extensions window, click the launch button
* Again in extensions window for the app, click the index.html
* In the application, click the button that says "Click to add 2nd webview"
* Check the javascript console.
* See error message - the error and callstack is listed in Others section below
To build the bug reproduction from source:
* pull git repo: https://github.com/ArtOfContext/angular-chromeapp-adding-webview-throws-error-reproduction
* requires Angular CLI
* npm install
* run the following:
ng build --aot
npm run chromeapp # this copies manifest.json and background.js into the dist folder
- The packaged chrome app is now inside of the "dist" folder. You can use this folder and the Load unpackaged extension button in chrome://extensions
## What is the motivation / use case for changing the behavior?
<!-- Describe the motivation or the concrete use case. -->
I want to be able to use `<webview>`s as I would other HTML components inside of Angular / Chrome apps. In Chrome apps, iframes are not available and we need similar functionality. Webview is the answer - its a a powerful component in Chrome apps and there are several capabilities we require.
## Environment
<pre><code>
Angular version: 4.4.3
<!-- Check whether this is still an issue in the most recent Angular version -->
Browser:
- [ x ] Chrome (desktop) version XX
- [ ] Chrome (Android) version XX
- [ ] Chrome (iOS) version XX
- [ ] Firefox version XX
- [ ] Safari (desktop) version XX
- [ ] Safari (iOS) version XX
- [ ] IE version XX
- [ ] Edge version XX
For Tooling issues:
- Node version: 8.0.0 <!-- run `node --version` -->
- Platform: Windows <!-- Mac, Linux, Windows -->
Others:
<!-- Anything else relevant? Operating system version, IDE, package manager, HTTP server, ... -->
The reproduction repo contains another JavaScript only version of the app, it does not use Angular. I am not able to reproduce the issue in that case. That app is "javascript-only-working".
Call stack of error in the Angular version:
Uncaught TypeError: GuestViewContainer[(this.viewType + "BrowserPlugin")] is not a constructor
at WebViewImpl.GuestViewContainer.createInternalElement$ (extensions::guestViewContainer:97:7)
at WebViewImpl.GuestViewContainer (extensions::guestViewContainer:26:41)
at new WebViewImpl (extensions::webView:19:22)
at HTMLElement.proto.createdCallback (extensions::guestViewContainer:246:5)
at DefaultDomRenderer2.webpackJsonp.../../../platform-browser/@angular/platform-browser.es5.js.DefaultDomRenderer2.createElement (chrome-extension://abjegfgbmmkgiifemllflgcpdpjdecjj/vendor.bundle.js:24397:25)
at DebugRenderer2.webpackJsonp.../../../core/@angular/core.es5.js.DebugRenderer2.createElement (chrome-extension://abjegfgbmmkgiifemllflgcpdpjdecjj/vendor.bundle.js:20357:49)
at createElement (chrome-extension://abjegfgbmmkgiifemllflgcpdpjdecjj/vendor.bundle.js:15950:27)
at createViewNodes (chrome-extension://abjegfgbmmkgiifemllflgcpdpjdecjj/vendor.bundle.js:18946:44)
at callViewAction (chrome-extension://abjegfgbmmkgiifemllflgcpdpjdecjj/vendor.bundle.js:19429:13)
at execComponentViewsAction (chrome-extension://abjegfgbmmkgiifemllflgcpdpjdecjj/vendor.bundle.js:19338:13)
</code></pre>
| type: bug/fix,freq1: low,area: core,core: DOM rendering,state: needs more investigation,P3 | low | Critical |
260,433,124 | kubernetes | daemonset wrongly reports unavailable pods | <!-- This form is for bug reports and feature requests ONLY!
If you're looking for help check [Stack Overflow](https://stackoverflow.com/questions/tagged/kubernetes) and the [troubleshooting guide](https://kubernetes.io/docs/tasks/debug-application-cluster/troubleshooting/).
-->
**Is this a BUG REPORT or FEATURE REQUEST?**:
> Uncomment only one, leave it on its own line:
>
/kind bug
> /kind feature
**What happened**:
kubectl rollout status on a daemonset sometimes is stuck forever. The daemonset's status reports unavailable pods even when all pods are running and ready.
```
$ kubectl -n monitoring rollout status ds <redacted>
Waiting for rollout to finish: 1 of 2 updated pods are available...
```
Here's the status section of the daemonset:
```
status:
currentNumberScheduled: 2
desiredNumberScheduled: 2
numberAvailable: 1
numberMisscheduled: 0
numberReady: 2
numberUnavailable: 1
observedGeneration: 1
updatedNumberScheduled: 2
```
Here's the status sections of the pods:
```
status:
conditions:
- lastProbeTime: null
lastTransitionTime: 2017-09-25T21:13:05Z
status: "True"
type: Initialized
- lastProbeTime: null
lastTransitionTime: 2017-09-25T21:16:14Z
status: "True"
type: Ready
- lastProbeTime: null
lastTransitionTime: 2017-09-25T21:14:24Z
status: "True"
type: PodScheduled
```
```
status:
conditions:
- lastProbeTime: null
lastTransitionTime: 2017-09-25T21:13:04Z
status: "True"
type: Initialized
- lastProbeTime: null
lastTransitionTime: 2017-09-25T21:16:02Z
status: "True"
type: Ready
- lastProbeTime: null
lastTransitionTime: 2017-09-25T21:14:28Z
status: "True"
type: PodScheduled
```
```
$ date
Mon Sep 25 22:18:39 UTC 2017
```
**What you expected to happen**:
kubectl rollout status should exit successfully when the rollout is complete. The daemonset should report all pods as available.
**How to reproduce it (as minimally and precisely as possible)**:
Can't reproduce it reliably, but it happened with this simple daemonset:
```
apiVersion: extensions/v1beta1
kind: DaemonSet
metadata:
annotations: <redacted>
name: <redacted>
namespace: <redacted>
spec:
minReadySeconds: 30
template:
metadata:
annotations: <redacted>
labels: <redacted>
spec:
affinity:
nodeAffinity:
requiredDuringSchedulingIgnoredDuringExecution:
nodeSelectorTerms:
- matchExpressions:
- key: cloud.google.com/gke-nodepool
operator: NotIn
values:
- <redacted>
containers:
- args: <redacted>
image: <redacted>
imagePullPolicy: Always
name: <redacted>
ports: <redacted>
resources: {}
volumeMounts: <redacted>
dnsPolicy: ClusterFirstWithHostNet
hostNetwork: true
volumes:
- downwardAPI:
items:
- fieldRef:
apiVersion: v1
fieldPath: metadata.labels
path: labels
- fieldRef:
apiVersion: v1
fieldPath: metadata.namespace
path: namespace
name: podinfo
updateStrategy:
rollingUpdate:
maxUnavailable: 3
type: RollingUpdate
```
**Anything else we need to know?**:
**Environment**:
- Kubernetes version (use `kubectl version`):
```
Client Version: version.Info{Major:"1", Minor:"7", GitVersion:"v1.7.5", GitCommit:"17d7182a7ccbb167074be7a87f0a68bd00d58d97", GitTreeState:"clean", BuildDate:"2017-08-31T09:14:02Z", GoVersion:"go1.8.3", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"7", GitVersion:"v1.7.5", GitCommit:"17d7182a7ccbb167074be7a87f0a68bd00d58d97", GitTreeState:"clean", BuildDate:"2017-08-31T08:56:23Z", GoVersion:"go1.8.3", Compiler:"gc", Platform:"linux/amd64"}
```
- Cloud provider or hardware configuration**: GKE
- OS (e.g. from /etc/os-release): COS
- Kernel (e.g. `uname -a`):
- Install tools: GKE
- Others:
| kind/bug,sig/apps,lifecycle/frozen | medium | Critical |
260,461,066 | TypeScript | Nested Tagged Unions |
**TypeScript Version:** 2.5.2
**Code**
```ts
type A = { type: "a", a: number }
type B = { type: "b", b: number }
type X = { type: A, a: string }
type Y = { type: B, b: string }
let x: X | Y
if (x.type.type === "a") {
x.a // Type Error
}
```
**Expected behavior:**
I would expect x to have type `X` inside the if-statement after disambiguating the nested tagged union types.
**Actual behavior:**
| Suggestion,In Discussion | high | Critical |
260,590,836 | go | cmd/link: stop requiring gold on arm64 when GNU ld is fixed | ### What version of Go are you using (`go version`)?
Any, more specifically 1.8, 1.9, master, most probably all versions supporting AArch64/arm64 target
### Does this issue reproduce with the latest release?
Yes
### What operating system and processor architecture are you using (`go env`)?
linux/arm64
### What did you do?
GC on linux/arm64 assumes gold linker availability see `src/cmd/link/internal/ld/lib.go:1182`
When gold is not available gcc fails due to it missing, when it tries to invoke it. All in shared_test.
When gold flag is remove by removing `sys.ARM64` from codition on `src/cmd/link/internal/ld/lib.go:1173`, build/test fail with
```
--- FAIL: TestTrivialExecutable (0.29s)
shared_test.go:66: executing go install -installsuffix=5577006791947779410 -linkshared trivial failed exit status 2:
# trivial
/root/go/pkg/tool/linux_arm64/link: running gcc failed: exit status 1
/usr/bin/ld: /tmp/go-link-151650837/go.o(.data.rel.ro+0x2c0): unresolvable R_AARCH64_ABS64 relocation against symbol `go.link.abihash.libruntime,sync-atomic.so'
/usr/bin/ld: final link failed: Nonrepresentable section on output
collect2: error: ld returned 1 exit status
```
And so one for most of the cases shared_test.
### What did you expect to see?
All tests pass. GC working with default binutils ld.
### What did you see instead?
GC failing to build some binaries with binutils ld. | NeedsFix | medium | Critical |
260,603,507 | rust | Inconsistent linking against stdlib based on whether a Workspace is used | Minimal repro: https://github.com/illicitonion/repro-rustworkspacerpath
I have a dynamic library which I produce. I am trying to split it into a few crates internally, to logically decompose it, and speed up compilation. I would like to end up producing a dylib with no runtime dependencies on the system (as I do when just building one crate).
If I decompose into sub-crates and don't add a [workspace] section to my Cargo.toml, my top-level dylib is produced as I expect. It has no dynamic dependency on libstd listed when I run `otool -L` on my Mac. However, `cargo test --all` doesn't pick up the sub-crate tests.
If I add a [workspace] section to my Cargo.toml, `cargo test --all` picks up the sub-crate tests, but my top-level dylib now has a dynamic dependency on libstd.
As far as I can tell, there doesn't appear to be a way to both have `--all` work, and not pick up a runtime dependency on a dylib which I'd like to avoid.
Which of the following is the bug, I'm not sure:
1. `cargo test --all` doesn't pick up non-workspace sub-crates
2. `cargo build` produces different linkage configuration depending on whether you're in a workspace
but it seems wrong that there's no way to get the best of both behaviours. | A-FFI,T-cargo,C-bug | low | Critical |
260,612,016 | vscode | Allow to switch to folder/workspace without window reload | #34774
1. VSCode, open a no folder vscode
2. Click on the big open folder button in the explorer
3. Notice that VSCode reloads - unlike most other scenarios where we are adding aditional folders where this just happens | feature-request,workbench-state,keep | low | Major |
260,650,968 | youtube-dl | [Site Support Request] - tirerack.com | ### Make sure you are using the *latest* version: run `youtube-dl --version` and ensure your version is *2017.09.24*. If it's not, read [this FAQ entry](https://github.com/rg3/youtube-dl/blob/master/README.md#how-do-i-update-youtube-dl) and update. Issues with outdated version will be rejected.
- [X ] I've **verified** and **I assure** that I'm running youtube-dl **2017.09.24**
`$> youtube-dl -U`
`youtube-dl is up-to-date (2017.09.24)`
### Before submitting an *issue* make sure you have:
- [X] At least skimmed through the [README](https://github.com/rg3/youtube-dl/blob/master/README.md), **most notably** the [FAQ](https://github.com/rg3/youtube-dl#faq) and [BUGS](https://github.com/rg3/youtube-dl#bugs) sections
- [X] [Searched](https://github.com/rg3/youtube-dl/search?type=Issues) the bugtracker for similar issues including closed ones
### What is the purpose of your *issue*?
- [X] Feature request (request for a new functionality)
### The following sections concretize particular purposed issues, you can erase any section (the contents between triple ---) not applicable to your *issue*
### If the purpose of this *issue* is a *site support request* please provide all kinds of example URLs support for which should be included (replace following example URLs by **yours**):
'https://www.tirerack.com/tires/tires.jsp?gclid=Cj0KCQjw9afOBRDWARIsAJW4nvzw7hZTEOgd-9jv7gAqRfJxa-fo6rBfcHUxm_yFsJhj99PIuyZqiDMaAt8qEALw_wcB&tireMake=Sumitomo&tireModel=HTR+Z+III&partnum=835YR9HTRZ3&GCID=C13674x012-tire&KEYWORD=tires.jsp_Sumitomo_HTR_Z_III_Tire&code=yes&src=17540115&ci_sku=835YR9HTRZ3&ci_sku=835YR9HTRZ3&ci_src=17588969&s_kwcid=AL!3756!3!72322431853!!!!119415463933!&ef_id=WbLstQAABbQ-UYo-:20170926142755:s'
### Description of your *issue*, suggested solution and other information
youtube-dl -v 'https://www.tirerack.com/tires/tires.jsp?gclid=Cj0KCQjw9afOBRDWARIsAJW4nvzw7hZTEOgd-9jv7gAqRfJxa-fo6rBfcHUxm_yFsJhj99PIuyZqiDMaAt8qEALw_wcB&tireMake=Sumitomo&tireModel=HTR+Z+III&partnum=835YR9HTRZ3&GCID=C13674x012-tire&KEYWORD=tires.jsp_Sumitomo_HTR_Z_III_Tire&code=yes&src=17540115&ci_sku=835YR9HTRZ3&ci_sku=835YR9HTRZ3&ci_src=17588969&s_kwcid=AL!3756!3!72322431853!!!!119415463933!&ef_id=WbLstQAABbQ-UYo-:20170926142755:s'
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: [u'-v', u'https://www.tirerack.com/tires/tires.jsp?gclid=Cj0KCQjw9afOBRDWARIsAJW4nvzw7hZTEOgd-9jv7gAqRfJxa-fo6rBfcHUxm_yFsJhj99PIuyZqiDMaAt8qEALw_wcB&tireMake=Sumitomo&tireModel=HTR+Z+III&partnum=835YR9HTRZ3&GCID=C13674x012-tire&KEYWORD=tires.jsp_Sumitomo_HTR_Z_III_Tire&code=yes&src=17540115&ci_sku=835YR9HTRZ3&ci_sku=835YR9HTRZ3&ci_src=17588969&s_kwcid=AL!3756!3!72322431853!!!!119415463933!&ef_id=WbLstQAABbQ-UYo-:20170926142755:s']
[debug] Encodings: locale UTF-8, fs UTF-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2017.09.24
[debug] Python version 2.7.12 - Linux-4.13.1-041301-generic-x86_64-with-Ubuntu-16.04-xenial
[debug] exe versions: avconv 2.8.11-0ubuntu0.16.04.1, avprobe 2.8.11-0ubuntu0.16.04.1, ffmpeg 2.8.11-0ubuntu0.16.04.1, ffprobe 2.8.11-0ubuntu0.16.04.1
[debug] Proxy map: {}
[generic] tires.jsp?gclid=Cj0KCQjw9afOBRDWARIsAJW4nvzw7hZTEOgd-9jv7gAqRfJxa-fo6rBfcHUxm_yFsJhj99PIuyZqiDMaAt8qEALw_wcB&tireMake=Sumitomo&tireModel=HTR+Z+III&partnum=835YR9HTRZ3&GCID=C13674x012-tire&KEYWORD=tires: Requesting header
WARNING: Falling back on generic information extractor.
[generic] tires.jsp?gclid=Cj0KCQjw9afOBRDWARIsAJW4nvzw7hZTEOgd-9jv7gAqRfJxa-fo6rBfcHUxm_yFsJhj99PIuyZqiDMaAt8qEALw_wcB&tireMake=Sumitomo&tireModel=HTR+Z+III&partnum=835YR9HTRZ3&GCID=C13674x012-tire&KEYWORD=tires: Downloading webpage
[generic] tires.jsp?gclid=Cj0KCQjw9afOBRDWARIsAJW4nvzw7hZTEOgd-9jv7gAqRfJxa-fo6rBfcHUxm_yFsJhj99PIuyZqiDMaAt8qEALw_wcB&tireMake=Sumitomo&tireModel=HTR+Z+III&partnum=835YR9HTRZ3&GCID=C13674x012-tire&KEYWORD=tires: Extracting information
ERROR: Unsupported URL: https://www.tirerack.com/tires/tires.jsp?gclid=Cj0KCQjw9afOBRDWARIsAJW4nvzw7hZTEOgd-9jv7gAqRfJxa-fo6rBfcHUxm_yFsJhj99PIuyZqiDMaAt8qEALw_wcB&tireMake=Sumitomo&tireModel=HTR+Z+III&partnum=835YR9HTRZ3&GCID=C13674x012-tire&KEYWORD=tires.jsp_Sumitomo_HTR_Z_III_Tire&code=yes&src=17540115&ci_sku=835YR9HTRZ3&ci_sku=835YR9HTRZ3&ci_src=17588969&s_kwcid=AL!3756!3!72322431853!!!!119415463933!&ef_id=WbLstQAABbQ-UYo-:20170926142755:s
Traceback (most recent call last):
File "/usr/local/bin/youtube-dl/youtube_dl/extractor/generic.py", line 2125, in _real_extract
doc = compat_etree_fromstring(webpage.encode('utf-8'))
File "/usr/local/bin/youtube-dl/youtube_dl/compat.py", line 2539, in compat_etree_fromstring
doc = _XML(text, parser=etree.XMLParser(target=_TreeBuilder(element_factory=_element_factory)))
File "/usr/local/bin/youtube-dl/youtube_dl/compat.py", line 2528, in _XML
parser.feed(text)
File "/usr/lib/python2.7/xml/etree/ElementTree.py", line 1653, in feed
self._raiseerror(v)
File "/usr/lib/python2.7/xml/etree/ElementTree.py", line 1517, in _raiseerror
raise err
ParseError: undefined entity: line 32, column 17
Traceback (most recent call last):
File "/usr/local/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 777, in extract_info
ie_result = ie.extract(url)
File "/usr/local/bin/youtube-dl/youtube_dl/extractor/common.py", line 434, in extract
ie_result = self._real_extract(url)
File "/usr/local/bin/youtube-dl/youtube_dl/extractor/generic.py", line 2980, in _real_extract
raise UnsupportedError(url)
UnsupportedError: Unsupported URL: https://www.tirerack.com/tires/tires.jsp?gclid=Cj0KCQjw9afOBRDWARIsAJW4nvzw7hZTEOgd-9jv7gAqRfJxa-fo6rBfcHUxm_yFsJhj99PIuyZqiDMaAt8qEALw_wcB&tireMake=Sumitomo&tireModel=HTR+Z+III&partnum=835YR9HTRZ3&GCID=C13674x012-tire&KEYWORD=tires.jsp_Sumitomo_HTR_Z_III_Tire&code=yes&src=17540115&ci_sku=835YR9HTRZ3&ci_sku=835YR9HTRZ3&ci_src=17588969&s_kwcid=AL!3756!3!72322431853!!!!119415463933!&ef_id=WbLstQAABbQ-UYo-:20170926142755:s
| site-support-request | low | Critical |
260,679,960 | go | runtime: test failures introduced on ppc64le with change to improve fastrand | ### What version of Go are you using (`go version`)?
tip
### Does this issue reproduce with the latest release?
intermittently, only seen on the golang build page so far
### What operating system and processor architecture are you using (`go env`)?
ppc64le
### What did you do?
When the fastrand change was merged https://github.com/golang/go/commit/e7e4a4ffa3330518250c4075e1f16a8ba62414df runtime failures started to happen intermittently for ppc64le on the build page. Another change was merged after that resulting in consistent failures on ppc64le that hid this one for a while, but that one has now been fixed.
### What did you expect to see?
ok for the ppc64le build on the build page
### What did you see instead?
fail for the ppc64le build on the build page intermittently
Here is an example of when it fails https://build.golang.org/log/8552765394dde8879c15b4e35b2f995606b8ed1b.
Looks like the tests are all parked waiting to run and it times out.
If I look at the change where this started happening, the only thing that looks like it could affect this is the code that was moved in mcommoninit to be under control of a lock where it wasn't before, but I can't say that is wrong, just different.
I have not been able to reproduce this anywhere else.
| NeedsInvestigation | medium | Critical |
260,724,453 | TypeScript | Strict variance and read-only versions of types | I feel like we should have an open "suggestion" issue with a meaningful title to track the work on stricter variance and read-only versions of types that the TypeScript team is considering, especially as other issues are being duped against it. The initial design sketch and a few comments are in #17502.
After a little more searching, should this be merged with #10725? | Suggestion,In Discussion | medium | Critical |
260,766,278 | rust | Tracking issue for RFC 3519: `arbitrary_self_types` | This is the tracking issue for RFC 3519: Arbitrary self types v2.
The feature gate for this issue is `#![feature(arbitrary_self_types)]`.
### About tracking issues
Tracking issues are used to record the overall progress of implementation. They are also used as hubs connecting to other relevant issues, e.g., bugs or open design questions. A tracking issue is however *not* meant for large scale discussion, questions, or bug reports about a feature. Instead, open a dedicated issue for the specific matter and add the relevant feature gate label.
### Steps
[Current plan][] is:
[Current plan]: https://github.com/rust-lang/rust/issues/44874#issuecomment-2122179688
* [x] **Fix the current lifetime elision bugs**
* [x] **Search for potentially conflicting method candidates**
* [x] **Block generic arbitrary self types**.
* [x] **Introduce an `arbitrary_self_types_pointers` feature gate**
* [x] **Rename the old `Receiver` trait** -- currently being run through crater
* [x] **Land the new `Receiver` trait without it doing anything**.
* [x] **Switch over the method resolution to use the `Receiver` trait, if the `arbitrary_self_types` feature is enabled**. The main event.
* [ ] **Add [diagnostics](https://github.com/rust-lang/rust/issues/44874) for the `!Sized` case and the `NonNull` etc. cases.**
* [ ] **Update the Rust reference**.
* [ ] Add documentation to the [dev guide][]. See the [instructions][doc-guide].
* [ ] Add formatting for new syntax to the [style guide][]. See the [nightly style procedure][].
* [ ] Stabilize!
- https://github.com/rust-lang/rust/pull/135881
[dev guide]: https://github.com/rust-lang/rustc-dev-guide
[doc-guide]: https://rustc-dev-guide.rust-lang.org/stabilization_guide.html#documentation-prs
[nightly style procedure]: https://github.com/rust-lang/style-team/blob/master/nightly-style-procedure.md
[reference]: https://github.com/rust-lang/reference
[reference-instructions]: https://github.com/rust-lang/reference/blob/master/CONTRIBUTING.md
[style guide]: https://github.com/rust-lang/rust/tree/master/src/doc/style-guide
### Unresolved Questions
None.
### Notable for Stabilization
- https://github.com/rust-lang/rust/pull/134524
### Related
- #27941
### Implementation history
TODO.
---
*(Below follows content that predated the accepted Arbitrary Self Types v2 RFC.)*
<details>
- [ ] figure out the object safety situation
- [ ] figure out the handling of inference variables behind raw pointers
- [ ] decide whether we want safe virtual raw pointer methods
## Object Safety
See https://github.com/rust-lang/rust/issues/27941#issuecomment-332157526
## Handling of inference variables
Calling a method on `*const _` could now pick impls of the form
```Rust
impl RandomType {
fn foo(*const Self) {}
}
```
Because method dispatch wants to be "limited", this won't really work, and as with the existing situation on `&_` we should be emitting an "the type of this value must be known in this context" error.
This feels like fairly standard inference breakage, but we need to check the impact of this before proceeding.
## Safe virtual raw pointer methods
e.g. this is UB, so we might want to force the call `<dyn Foo as Foo>::bar` to be unsafe somehow - e.g. by not allowing `dyn Foo` to be object safe unless `bar` was an `unsafe fn`
```Rust
trait Foo {
fn bar(self: *const Self);
}
fn main() {
// creates a raw pointer with a garbage vtable
let foo: *const dyn Foo = unsafe { mem::transmute([0usize, 0x1000usize]) };
// and call it
foo.bar(); // this is UB
}
```
However, even today you could UB in safe code with `mem::size_of_val(foo)` on the above code, so this might not be actually a problem.
## More information
There's no reason the `self` syntax has to be restricted to `&T`, `&mut T` and `Box<T>`, we should allow for more types there, e.g.
```Rust
trait MyStuff {
fn do_async_task(self: Rc<Self>);
}
impl MyStuff for () {
fn do_async_task(self: Rc<Self>) {
// ...
}
}
Rc::new(()).do_async_stuff();
```
</details>
| B-RFC-approved,T-lang,B-unstable,C-tracking-issue,F-arbitrary_self_types,S-tracking-needs-summary,T-types,S-types-deferred | high | Critical |
260,830,954 | electron | Support REPL on Windows | The `electron --interactive` option [supposedly](https://electron.atom.io/docs/tutorial/repl/) only works on macOS and Linux. What would it take to add Windows support? | enhancement :sparkles:,platform/windows | low | Major |
260,928,341 | material-ui | Tooltip doesn't work for <IconButton disabled> | <!-- Checked checkbox should look like this: [x] -->
- [x] I have searched the [issues](https://github.com/callemall/material-ui/issues) of this repository and believe that this is not a duplicate.
## Expected Behavior
Tooltip is visible for hover
## Current Behavior
Tooltip is hidden for hover
## Steps to Reproduce (for bugs)
```jsx
<Tooltip title="Tooltip" placement="bottom">
<IconButton disabled>
<Done/>
</IconButton>
</Tooltip>
```
## Your Environment
| Tech | Version |
|--------------|---------|
| Material-UI | v1.0.0-beta.12 |
| component: tooltip,enhancement | medium | Critical |
260,970,779 | react | Multiple onFocus events fired on single focus in Safari | I'd like to report a possible bug.
1. Brief description
OnFocus synthetic event is fired multiple times on single focus occurrence in Safari. Expected behaviour is for it to be fired only once per focus.
2. Live demo: https://codesandbox.io/s/101pnjxq27
3. Minimal steps to reproduce
- install create-react-app
`$ npm install -g create-react-app`
- create an example application
`$ create-react-app input-focus-test`
`$ cd input-focus-test`
- edit application file and add input with onFocus event handler
`$ vi src/App.js`
```javascript
import React, { Component } from 'react';
import logo from './logo.svg';
import './App.css';
class App extends Component {
handleOnFocus = evt => {
console.log('handleOnFocus', evt);
}
render() {
return (
<div className="App">
<header className="App-header">
<img src={logo} className="App-logo" alt="logo" />
<h1 className="App-title">Welcome to React</h1>
</header>
<p className="App-intro">
To get started, edit <code>src/App.js</code> and save to reload.
</p>
<p>
Input
<input onFocus={this.handleOnFocus}/>
</p>
</div>
);
}
}
export default App;
```
- start application
`$ npm run start`
- open up locahost:3000 in Safari
- click on the input field with developer’s console opened
- notice focus event fired multiple times
4. Additional info
This issue has been found in the following environment:
- macOS Sierra version 10.12.6 (also tested and found on High Sierra)
- Safari 10.1.2 (also tested and found in Safari 10.0 and Safari 11, seems to work on latest Safari mobile, Chrome and Firefox)
- React JS 15.5.4 (also tested and found in React 16)
- example steps to reproduce above generated with create-react-app version 1.4.1
Some of our observations that might come in handy:
- this issue seems to behave randomly to some extent
- event is usually fired twice when changing focus from input to input (so first click on input fires two events, consequential fire only one, but when changing focus to a different input field it fires twice again)
- additional interesting behavior happens with multiple input fields; for instance with input fields 1 and 2, first focus on input 1 generates two events onFocus with input 1, but then focus on input 2 sometimes generates three events: onFocus with input 1, then input 2, then input 1 again as targets.
| Type: Bug,Component: DOM | medium | Critical |
261,041,240 | flutter | Document why Opacity is inconsistent about hit testing vs accessibility when opacity is 0.0 | This will prevent stacked items which are not visible from blocking items which are nevertheless "behind" them. | framework,a: accessibility,d: api docs,P2,team-framework,triaged-framework | low | Major |
261,087,848 | flutter | need to be able to write a11y integration tests | We should have a way to write integration tests for assistive technologies. These tests should assert that an app is usable with TalkBack (Android) and VoiceOver (iOS) just like they are supposed to.
A framework that enables that is useful for
* ourselves to verify that our a11y implementation interacts correctly with TalkBack and VoiceOver
* all Flutter apps developers to ensure that their support for assistive technologies in their apps doesn't break. | a: tests,framework,a: accessibility,P2,team-framework,triaged-framework | low | Minor |
261,143,607 | godot | Visualscript connection lines get drawn over or below the nodes each time a node gets selected | **Operating system or device, Godot version, GPU Model and driver (if graphics related):**
Godot 3.0 master https://github.com/godotengine/godot/commit/da144fed4c49133a93b3b83cfc665352c0af351a
**Issue description:**
<!-- What happened, and what was expected. -->
**Steps to reproduce:**
1. Add nodes to a visualscript
2. Make lines overlap nodes to better see the issue
3. Start selecting different nodes (or the same sometimes)
4. Lines get drawn over and below the overlapping node each time you select a node
| enhancement,topic:editor,confirmed,usability,topic:visualscript,topic:gui | low | Major |
261,146,698 | godot | Visualscript disconnecting lines which node changes size cause some issues | **Operating system or device, Godot version, GPU Model and driver (if graphics related):**
Godot 3.0 master https://github.com/godotengine/godot/commit/da144fed4c49133a93b3b83cfc665352c0af351a
**Issue description:**
<!-- What happened, and what was expected. -->
**Steps to reproduce:**
1. Disconnect a line which node changes size
2. Enjoy issues
| bug,topic:editor,confirmed,topic:visualscript | low | Major |
261,147,977 | godot | Visualscript selecting an input/output doesn't focus the node | **Operating system or device, Godot version, GPU Model and driver (if graphics related):**
Godot 3.0 master https://github.com/godotengine/godot/commit/da144fed4c49133a93b3b83cfc665352c0af351a
**Issue description:**
<!-- What happened, and what was expected. -->
Two options:
- It shouldn't happen
- The `_ready` Function node should be focused
**Steps to reproduce:**
1. Make two nodes overlap
2. Try to link an input/output line from the node underneath
| enhancement,confirmed,usability,topic:visualscript | low | Major |
261,170,307 | rust | Documentation for new stable features can be hard to find (e.g. for associated const) | ### Background
I was just changing some code to use associated consts for a struct. I wasn't sure what the exact syntax was, so I was looking for the documentation about it. I remembered that it was recently stabilized, so I googled for "rust associated constants". Here's the top results:
<img width="654" alt="screen shot 2017-09-28 at 11 44 54" src="https://user-images.githubusercontent.com/16778/30945591-826dff54-a442-11e7-919a-941f594cdeff.png">
[The first result](https://doc.rust-lang.org/1.7.0/book/associated-constants.html) looked good, but because it had "1.7.0" in the URL and it was in a "Nightly Rust" section, I wasn't sure whether this feature had changed in the time that it was stabilized, so I continued my search.
[The next result](https://github.com/rust-lang/rust/issues/29646) was the tracking issue. I tried to find a definitive statement there as to when it was actually stabilized, but couldn't find one. Also there were no links to the documentation.
So then I went looking for the [Rust 1.20 announcement post](https://blog.rust-lang.org/2017/08/31/Rust-1.20.html), and it had some documentation. That helped. But I was still looking for something that is not a blog post, something better to link to.
So I went back to the tracking issue and found a link to an issue to add documentation to the reference. Finally, I dug up this: https://doc.rust-lang.org/stable/reference/items.html#associated-constants That's what I wanted to find in the beginning!
### Possible improvements
I think there are a couple of things that could have helped me find this quicker:
1. The first google result (the nightly rust feature page) could be updated to have a big notice with a link to the stable docs for that feature and a mentioning in which Rust version it was stabilized. (You could make an argument that old docs should not be changed, but I think it's better to be pragmatic if that's what the first search result is.)
2. The blog post could link to the documentation.
3. The tracking issue description could be updated to clearly state in which stable release that feature was included and link to the documentation.
All these things would make it more likely for people to find the right documentation and not have to wonder about when a feature was stabilized.
What do you think? I'm not sure if that's something that warrants an RFC or if there are any existing checklists in place for what to do when stabilizing a feature (which we could add the above things to). | C-enhancement,P-low,A-docs | low | Major |
261,284,328 | neovim | 'joinspaces' should be buffer-local | ### Actual behaviour
The 'joinspaces' option is global, meaning you can't set this option differently for text files and code.
### Expected behaviour
This option should be buffer-local, with a fallback to the global setting, just like many others. See 'global-local'. | enhancement,options | low | Minor |
261,292,338 | neovim | :terminal should clear history on `reset` | I think embedded terminal should behave like external one and clear the `:terminal` buffer history if type `reset` in it. | enhancement,terminal | low | Major |
261,365,046 | youtube-dl | Please support https://www.tvnz.co.nz/ | ## Please follow the guide below
- You will be asked some questions and requested to provide some information, please read them **carefully** and answer honestly
- Put an `x` into all the boxes [ ] relevant to your *issue* (like this: `[x]`)
- Use the *Preview* tab to see what your issue will actually look like
---
### Make sure you are using the *latest* version: run `youtube-dl --version` and ensure your version is *2017.09.24*. If it's not, read [this FAQ entry](https://github.com/rg3/youtube-dl/blob/master/README.md#how-do-i-update-youtube-dl) and update. Issues with outdated version will be rejected.
- [ ] I've **verified** and **I assure** that I'm running youtube-dl **2017.09.24**
### Before submitting an *issue* make sure you have:
- [ ] At least skimmed through the [README](https://github.com/rg3/youtube-dl/blob/master/README.md), **most notably** the [FAQ](https://github.com/rg3/youtube-dl#faq) and [BUGS](https://github.com/rg3/youtube-dl#bugs) sections
- [ ] [Searched](https://github.com/rg3/youtube-dl/search?type=Issues) the bugtracker for similar issues including closed ones
### What is the purpose of your *issue*?
- [ ] Bug report (encountered problems with youtube-dl)
- [ x] Site support request (request for adding support for a new site)
- [ ] Feature request (request for a new functionality)
- [ ] Question
- [ ] Other
---
### The following sections concretize particular purposed issues, you can erase any section (the contents between triple ---) not applicable to your *issue*
---
### If the purpose of this *issue* is a *bug report*, *site support request* or you are not completely sure provide the full verbose output as follows:
Add the `-v` flag to **your command line** you run youtube-dl with (`youtube-dl -v <your command line>`), copy the **whole** output and insert it here. It should look similar to one below (replace it with **your** log inserted between triple ```):
[stefan@localhost ~]$ youtube-dl --all-subs -v https://www.tvnz.co.nz/shows/when-we-go-to-war
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: [u'--all-subs', u'-v', u'https://www.tvnz.co.nz/shows/when-we-go-to-war']
[debug] Encodings: locale UTF-8, fs UTF-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2017.09.24
[debug] Python version 2.7.5 - Linux-3.10.0-693.2.2.el7.x86_64-x86_64-with-centos-7.4.1708-Core
[debug] exe versions: ffmpeg 2.6.8, ffprobe 2.6.8, rtmpdump 2.4
[debug] Proxy map: {}
[generic] when-we-go-to-war: Requesting header
WARNING: Falling back on generic information extractor.
[generic] when-we-go-to-war: Downloading webpage
[generic] when-we-go-to-war: Extracting information
ERROR: Unsupported URL: https://www.tvnz.co.nz/shows/when-we-go-to-war
Traceback (most recent call last):
File "/usr/local/bin/youtube-dl/youtube_dl/extractor/generic.py", line 2125, in _real_extract
doc = compat_etree_fromstring(webpage.encode('utf-8'))
File "/usr/local/bin/youtube-dl/youtube_dl/compat.py", line 2539, in compat_etree_fromstring
doc = _XML(text, parser=etree.XMLParser(target=_TreeBuilder(element_factory=_element_factory)))
File "/usr/local/bin/youtube-dl/youtube_dl/compat.py", line 2528, in _XML
parser.feed(text)
File "/usr/lib64/python2.7/xml/etree/ElementTree.py", line 1642, in feed
self._raiseerror(v)
File "/usr/lib64/python2.7/xml/etree/ElementTree.py", line 1506, in _raiseerror
raise err
ParseError: not well-formed (invalid token): line 4, column 526
Traceback (most recent call last):
File "/usr/local/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 777, in extract_info
ie_result = ie.extract(url)
File "/usr/local/bin/youtube-dl/youtube_dl/extractor/common.py", line 434, in extract
ie_result = self._real_extract(url)
File "/usr/local/bin/youtube-dl/youtube_dl/extractor/generic.py", line 2980, in _real_extract
raise UnsupportedError(url)
UnsupportedError: Unsupported URL: https://www.tvnz.co.nz/shows/when-we-go-to-war
### If the purpose of this *issue* is a *site support request* please provide all kinds of example URLs support for which should be included (replace following example URLs by **yours**):
https://www.tvnz.co.nz/shows/dirty-laundry
https://www.tvnz.co.nz/shows/clique
https://www.tvnz.co.nz/shows/the-level
https://www.tvnz.co.nz/shows/apple-tree-yard
https://www.tvnz.co.nz/shows/queen-sugar
Note that **youtube-dl does not support sites dedicated to [copyright infringement](https://github.com/rg3/youtube-dl#can-you-add-support-for-this-anime-video-site-or-site-which-shows-current-movies-for-free)**. In order for site support request to be accepted all provided example URLs should not violate any copyrights.
---
### Description of your *issue*, suggested solution and other information
Please support https://www.tvnz.co.nz/
| site-support-request,account-needed | low | Critical |
261,403,762 | go | cmd/compile: avoid allocations for some return values | A non-inlinable function that returns new memory always allocates it on the heap. For example, in the base64 package the `DecodeString` method returns a heap-allocated byte slice:
```func (enc *Encoding) DecodeString(s string) ([]byte, error)```
It is common for this return value to have limited life, easily scoped to the stack:
```
b, err := enc.DecodeString(s)
if err != nil { ... }
data = append(data, b...)
```
For cases like this, the `DecodeString` method could have been made more efficient by writing in a style where the `[]byte` was passed as an argument:
```func (enc *Encoding) AppendDecodeString(out []byte, s string) ([]byte, error)```
No heap allocation is necessary for calling this version. This transformation has been manually applied in many places in the standard library, from the `Append*` functions in strconv to `io.Reader` itself.
The compiler could do this automatically.
For concrete methods, the original function signature can be satisfied by a wrapper function, that allocates the value on the heap and calls a variant where return values containing pointers are passed as "out" arguments. When compiling code that can keep the output on the stack, the caller can be modified to use the generated functions.
For example, the implementation of `DecodeString` is:
```
func (enc *Encoding) DecodeString(s string) ([]byte, error) {
dbuf := make([]byte, enc.DecodedLen(len(s)))
n, _, err := enc.decode(dbuf, []byte(s))
return dbuf[:n], err
}
```
Currently, escape analysis determines that `dbuf` escapes to the heap without ever seeing how the value is used. Instead, the compiler can split this function in two, an inlinable allocation function, and a body:
```
func (enc *Encoding) ΨDecodeString(s string) []byte {
return make([]byte, enc.DecodedLen(len(s)))
}
func (enc *Encoding) ΦDecodeString(s string, dbuf *[]byte) error {
n, _, err := enc.decode(*dbuf, []byte(s))
*dbuf = dbuf[:n]
return err
}
func (enc *Encoding) DecodeString(s string) ([]byte, error) {
out := enc.ΨDecodeString(s) // inlined
err := enc.ΦDecodeString(s, &out)
return out, err
}
```
Then the compiler can transform callers of `DecodeString` where the return value would fit on the stack to two calls to `ΨDecodeString` and `ΦDecodeString`. The first is inlined, determined not to escape and so `dbuf` lives on the stack.
The general analysis of can the Ψ allocation function be inlined, and how does it pass data dependencies to the Φ function could get complicated. | Performance,NeedsInvestigation,compiler/runtime | low | Critical |
261,414,281 | vscode | Add control to open file shown in "replace preview" editor when performing project-wide find/replace | While performing a project-wide find/replace, opening an occurrence from the search sidebar opens a "replace preview" diff editor. This view is not editable, so if the user would like to edit the displayed file, the only current way to do so is manually either from the explorer sidebar or the quick-open palette.
Per @roblourens' suggestion in #35323, "There should be a working Open File button that always appears, git repo or not, in the replace diff editor." | help wanted,feature-request,search | medium | Major |
261,422,729 | angular | Form validators re-run on view (re)creation | <!--
PLEASE HELP US PROCESS GITHUB ISSUES FASTER BY PROVIDING THE FOLLOWING INFORMATION.
ISSUES MISSING IMPORTANT INFORMATION MAY BE CLOSED WITHOUT INVESTIGATION.
-->
## I'm submitting a...
<!-- Check one of the following options with "x" -->
<pre><code>
[ ] Regression (a behavior that used to work and stopped working in a new release)
[x] Bug report <!-- Please search GitHub for a similar issue or PR before submitting -->
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question
</code></pre>
## Current behavior
<!-- Describe how the issue manifests. -->
When the directive associated with a form control is created in the view, validators are triggered.
## Expected behavior
<!-- Describe what the desired behavior would be. -->
Validators should **not be triggered when the view changes**. Reactive forms should not be tied to the way they are represented in the view. Their source of truth should be the **model**.
## Minimal reproduction of the problem with instructions
<!--
For bug reports please provide the *STEPS TO REPRODUCE* and if possible a *MINIMAL DEMO* of the problem via
https://plnkr.co or similar (you can use this template as a starting point: http://plnkr.co/edit/tpl:AvJOMERrnz94ekVua0u5).
-->
https://stackblitz.com/edit/angular-reactive-forms-issue?file=app/app.component.ts
1. Open console.
2. Use the _Toggle visiblity_ button to confirm that validators are running on each control directive creation.
## What is the motivation / use case for changing the behavior?
<!-- Describe the motivation or the concrete use case. -->
3. Continue from above steps.
4. Press _set errors manually_ to insert an error manually (this is mocking manually setting an error after validation is returned from backend)
5. Press _Toggle visiblity_ to make it disappear. Nothing happens in console.
6. Press it again to make the control appear. Notice that console logs, which means that validators is running.
Observe the fact that **error message is now gone**. Toggling the view is mocking the use-case of having a mulitpart form.
---
If this is by design, I don't see a reason for it. We're creating a view where we write data form model to view. The action of reading from model should not trigger validators, as far as I understand. As I see it, validators should be run when the `FormControl` instances are created in the model. _Why are validators triggered when value did not change?_
## Environment
<pre><code>
Angular version: 4.3.6
<!-- Check whether this is still an issue in the most recent Angular version --> | type: bug/fix,freq2: medium,area: forms,state: confirmed,forms: validators,P4 | low | Critical |
261,458,722 | go | net/http: document security considerations for serving internet traffic | The `net/http/pprof` package _implicitly_ registers HTTP handlers through its `init()` function. I argue this implicit behavior is too subtle and may contribute to people inadvertently leaving such endpoints open. Some IPv4 scans reveal a non-trivial number of pprof endpoints exposed (http://mmcloughlin.com/posts/your-pprof-is-showing). Since Go 1.9 an exposed pprof endpoint leaks source code.
I would like to spark a discussion on the possibility of moving to an _explicit_ handler registration model. It is not clear to me that this would qualify for the Security exemption of the Go 1 compatibility guarantee, but I thought it was worthy of mention. Perhaps a warning in documentation would be enough. | Documentation,NeedsFix | medium | Major |
261,460,728 | rust | Crate naming confusion - use underscores always. E.g. tokio-core and serde_derive | We need to make things a bit more consistent: 'extern' crate name _should equal_ crate name in the toml file.
For example: tokio-core and serde_derive are both valid crate names.
But
> extern crate tokio-core;
is a compile error as it's not a valid rust name. Instead we have to use underscore:
> extern crate tokio_core;
Can we ban new crates being published on crates.io with hyphens so that we _only_ have underscores. (Or alternatively ban underscores and only have hyphens). Worst case, can we ensure that no one can publish a crate called tokio_core if there is already a tokio-core as this is a security risk of someone publishing a malicious crate.
| T-compiler,C-feature-request | low | Critical |
261,503,347 | rust | Make or (|) patterns work with match default binding modes | Consider the following example which (at the time of writing, i.e. #44614) fails:
```rust
pub fn main() {
let x = &Some((3, 3));
let _: &i32 = match x {
// Here, each of the patterns are treated independently
//
// FIXME(tschottdorf): make this compile without the actual `|`.
// @nikomatsakis suggested perhaps just removing the code which
// complains but wasn't sure whether it's still required for anything.
// Opinions?
//
// Some((x, 3)) | &Some((ref x, 5)) => x,
// - first binding ^ bound in different ways
/*Some((x, 3)) |*/ &Some((ref x, 5)) => x,
_ => &5i32,
};
}
```
It's not clear whether the rule that prevents this from compiling is still worthwhile.
@nikomatsakis had this to say:
> I suspect we can just remove it but it may be used by some code somewhere
i.e., I'm pretty sure the old trans code (obviated by MIR now) used to rely on that (that each binding had a single "mode") but...
well, maybe MIR builder does too, who knows
honestly maybe not worth supporting
(well, I guess that if we keep the check, we would want to check the inferred mode -- probably better if we ditch it and figure out if we have to change anything else as a result)
| C-enhancement,T-compiler | low | Minor |
261,511,767 | vscode | File extension specific settings | This was discussed here:
https://github.com/Microsoft/vscode/issues/1587
but instead what was implemented was language specific settings. That doesn't help us where we have the same language in files with different extensions but what to impose different settings on them.
(ex. I have a DSL like language that looks like JS, I want to make it syntax highlight as JS, but disable validation because some things aren't quit right. Having to fork the JS language bindings for that and maintain it is unfortunate.) | feature-request,config | high | Critical |
261,559,685 | angular | animations: query is not working when querying for animations inside ng-content that are not first descendant node | ## I'm submitting a...
<pre><code>
[x] Bug report <!-- Please search GitHub for a similar issue or PR before submitting -->
</code></pre>
## Current behavior
`query` doesn't work properly in a particular case, it's best to check the [stackblitz example](https://stackblitz.com/edit/animations-ng-content-query-bug?file=app%2Fdummy.component.ts), it seems that when
1) animation you query is inside a component using `ng-content`
2) animation inside that component is not the FIRST child node of said component
query + stagger is not working, which I assume means query is not catching them at all.. it works fine if you use a div instead of component with ng-content OR or the child animation is the first descendant
## Minimal reproduction of the problem with instructions
click the button - https://stackblitz.com/edit/animations-ng-content-query-bug?file=app%2Fdummy.component.ts
## Environment
5.0.0-rc.0
cc @matsko | type: bug/fix,area: animations,freq1: low,P3 | low | Critical |
261,607,863 | go | x/crypto/ssh/agent: Accept Flags in Agent.Sign() | I was trying unsuccessfully to get ssh-agent to sign a JWT via the x/crypto/ssh/agent.Agent::Sign() interface.
In https://github.com/golang/crypto/blob/master/ssh/agent/client.go#L371, the Flags in signRequestAgentMsg was left as default (0).
req := ssh.Marshal(signRequestAgentMsg{
KeyBlob: key.Marshal(),
Data: data,
})
In OpenSSH ssh-agent, https://github.com/openssh/openssh-portable/blob/master/ssh-agent.c#L262, the signing algorithm is being determined by parsing the flags sent in the signRequestAgentMsg - 2 for rsa-sha2-256 and 4 for rsa-sha2-512, and sending 0 probably defaults the algorithm to SHA1.
It seems that allowing the caller to specify flags, or at a higher level, an algorithm name, would be able to resolve this, but I'm not sure what is the best way to implement this. | NeedsDecision | low | Minor |
261,715,718 | rust | Tracking issue for RFC 2137: Support defining C-compatible variadic functions in Rust | This is a tracking issue for the RFC "Support defining C-compatible variadic functions in Rust" (rust-lang/rfcs#2137).
**Steps:**
- [x] Implement the RFC (PR https://github.com/rust-lang/rust/pull/57760)
- [ ] Adjust documentation ([see instructions on forge][doc-guide])
- [ ] Stabilization PR ([see instructions on forge][stabilization-guide])
[stabilization-guide]: https://forge.rust-lang.org/stabilization-guide.html
[doc-guide]: https://forge.rust-lang.org/stabilization-guide.html#updating-documentation
**Unresolved questions:**
- "When implementing this feature, we will need to determine whether the compiler
can provide an appropriate lifetime that prevents a `VaList` from outliving its
corresponding variadic function."
- Continuing bikeshed on the `...` syntax.
- Ensure that even when this gets stabilized for regular functions, it is still rejected on `const fn`.
- What even is the semantics of this? What exactly is allowed and disallowed? Would be good to have a Miri implementation.
- borrowck problems: https://github.com/rust-lang/rust/issues/125431
- What exactly are the ABI requirements around variadic calls? What are the ABI compatibility rules? Do we have to be concerned about LLVM target features affecting variadic ABI? | A-FFI,B-RFC-approved,T-lang,B-unstable,C-tracking-issue,F-c_variadic,S-tracking-ready-to-stabilize | high | Critical |
261,723,347 | TypeScript | TS Server: Send error event when a plugin fails to load | **Problem**
When a TS Server plug-in is not loaded, the TS Server currently fails silently. This results in a confusing experience for users since intellisense or other expected plugin features will not work. You currently have to check the TS Server logs to see that a plugin was not loaded
**Request**
Send an error event to the client when a plugin fails to load. I imagine the interface would look like:
```ts
type PluginInitializationFailedEventName = "pluginInitializationFailed";
interface PluginInitializationFailedEvent extends Event {
event: PluginInitializationFailedEventName;
body: PluginInitializationFailedEventBody;
}
interface PluginInitializationFailedEventBody {
name: string;
project?: string; // Path to the js/tsconfig file that registered this plugin
}
```` | Bug,VS Code Tracked | low | Critical |
261,728,090 | angular | HostBinding does not support asynchronous structures (Observables and Promises) | <pre><code>
[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report <!-- Please search GitHub for a similar issue or PR before submitting -->
[ X] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question
</code></pre>
## Current behavior
If the component has the following line
@HostBinding('class.async-class') private asyncClass: Observable<boolean> = new Subject<boolean>;
the element representing the component will always have the CSS class "async-class" set
## Expected behavior
What I would expect is that the CSS class "async-class" set until and unless the Subject emits true
## Minimal reproduction of the problem with instructions
## What is the motivation / use case for changing the behavior?
As it is, it's not clear what the change-detection strategy is. Worse, if the state of the component is maintained in a observables (otherwise an efficient strategy), the code has to manual subscribe to (and then unsubscribe from) the relevant observables and hand-update an otherwise unnecessary variables
## Environment
<pre><code>
Angular version: 4.1
Browser:
All
For Tooling issues:
- Node version:
- Platform:
</code></pre>
| feature,area: core,core: binding & interpolation,core: host and host bindings,cross-cutting: observables,feature: under consideration | high | Critical |
261,759,527 | rust | overflow during drop-check on a recursive type | I get a pretty strange error when trying to compile this: ([playground link](https://play.rust-lang.org/?gist=5490697a4e08dd949d7a6abbc58a2bd1&version=stable))
```Rust
enum Stuff<T> {
Value(T),
Nested(Box<Stuff<Stuff<T>>>),
}
fn main() {
let a = Stuff::Value(1);
}
```
output:
```
error[E0320]: overflow while adding drop-check rules for Stuff<i32>
--> src/main.rs:7:9
|
7 | let a = Stuff::Value(1);
| ^
|
= note: overflowed on Stuff<Stuff<Stuff<Stuff<Stuff<Stuff< ...
```
If the type isn't used, the program compiles fine. Don't know if the type is actually representable or not, the error is misleading. | E-hard,C-enhancement,A-diagnostics,P-low,T-compiler | low | Critical |
261,793,458 | angular | (Template-driven forms) FormControl for multiple radio buttons in a group is being removed from the Form | <!--
PLEASE HELP US PROCESS GITHUB ISSUES FASTER BY PROVIDING THE FOLLOWING INFORMATION.
ISSUES MISSING IMPORTANT INFORMATION MAY BE CLOSED WITHOUT INVESTIGATION.
-->
## I'm submitting a...
<!-- Check one of the following options with "x" -->
<pre><code>
[ ] Regression (a behavior that used to work and stopped working in a new release)
[x] Bug report <!-- Please search GitHub for a similar issue or PR before submitting -->
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question
</code></pre>
## Current behavior
<!-- Describe how the issue manifests. -->
Using template-driven forms, I have the following scenario:
- Inside a `<form>`, I have a group of radio buttons that are all bound to a single property on the component via ngModel. The FormControl for this group of radio buttons has a `required` validator, since I want the form to be valid if and only if the user has selected one of the radio buttons.
- There are a variable number of radio buttons in the group, so each radio button's value is equal to the index read from the *ngFor in the template.
- There is a "Add Choice" button which adds another radio button to the group, and an "X" button that removes a radio button from the group. (**Note:** it is possible to remove the radio button that is currently selected, in which case I set `selectedIndex = null` to indicate that no radio button is selected.)
When I delete one of the radio buttons from the UI, the FormControl is being removed from the Form (despite the fact that there are still other radio buttons in the same group that are bound to that FormControl). The form is now "valid" because the required validator (which was attached to the FormControl) is no longer part of the form.
## Expected behavior
<!-- Describe what the desired behavior would be. -->
The FormControl should not be removed from the Form when there are still other radio buttons in the same group bound to that FormControl. I would only expect the FormControl to be removed from the Form when all radio buttons in the group are removed from the UI.
## Minimal reproduction of the problem with instructions
<!--
For bug reports please provide the *STEPS TO REPRODUCE* and if possible a *MINIMAL DEMO* of the problem via
https://plnkr.co or similar (you can use this template as a starting point: http://plnkr.co/edit/tpl:AvJOMERrnz94ekVua0u5).
-->
**Minimal demo**: http://plnkr.co/edit/76tRuG1hUhKzQCpMuBcz?p=preview
**Steps to reproduce**:
1. Load the plunker
2. Observe that the form is currently invalid because no radio button is selected.
3. Click one of the "X" buttons to delete a radio button from the UI.
4. Bug: the form is now valid (despite the fact that no radio button is selected).
## What is the motivation / use case for changing the behavior?
<!-- Describe the motivation or the concrete use case. -->
Using template-driven forms, I want to be able to use Angular validators with a form that contains a variable number of radio buttons. (In the minimal repro above, I'm aware I can work around the issue by writing my own custom validator that checks `selectedIndex === null`, or by using reactive forms instead. But I'm still reporting this as a bug for template-driven forms because I don't agree with the behavior where the FormControl is being removed from the Form when there are still other radio buttons in the UI that are bound to it.)
## Environment
<pre><code>
Angular version: 4.4.4
<!-- Check whether this is still an issue in the most recent Angular version -->
Browser:
- [x] Chrome (desktop) version 61.0.3163.100 (Official Build) (64-bit)
- [ ] Chrome (Android) version XX
- [ ] Chrome (iOS) version XX
- [ ] Firefox version XX
- [ ] Safari (desktop) version XX
- [ ] Safari (iOS) version XX
- [ ] IE version XX
- [ ] Edge version XX
For Tooling issues:
- Node version: XX <!-- run `node --version` -->
- Platform: <!-- Mac, Linux, Windows -->
Others:
<!-- Anything else relevant? Operating system version, IDE, package manager, HTTP server, ... -->
</code></pre>
| type: bug/fix,freq1: low,area: forms,state: confirmed,forms: template-driven,P4 | low | Critical |
261,818,675 | angular | ng-deep breaks CSS on components with no encapsulation | <!--
PLEASE HELP US PROCESS GITHUB ISSUES FASTER BY PROVIDING THE FOLLOWING INFORMATION.
ISSUES MISSING IMPORTANT INFORMATION MAY BE CLOSED WITHOUT INVESTIGATION.
-->
## I'm submitting a...
<!-- Check one of the following options with "x" -->
<pre><code>
[ ] Regression (a behavior that used to work and stopped working in a new release)
[x] Bug report <!-- Please search GitHub for a similar issue or PR before submitting -->
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question
</code></pre>
## Current behavior
<!-- Describe how the issue manifests. -->
If you use `::ng-deep` in a component where view encapsulation is turned off, it stays there. Since this is invalid CSS, some rules break. It's silent _and_ partial failure because CSS parser simply sees `::ng-deep` as unknown selector.
## Expected behavior
<!-- Describe what the desired behavior would be. -->
`::ng-deep` should be stripped down from CSS.
## Minimal reproduction of the problem with instructions
<!--
For bug reports please provide the *STEPS TO REPRODUCE* and if possible a *MINIMAL DEMO* of the problem via
https://plnkr.co or similar (you can use this template as a starting point: http://plnkr.co/edit/tpl:AvJOMERrnz94ekVua0u5).
-->
https://stackblitz.com/edit/angular-ng-deep-bug?file=app%2Fapp.component.css
- If you comment out the `::ng-deep`, it works.
- If you (alternatively) comment out the settings for no encapsulation, it also works.
## What is the motivation / use case for changing the behavior?
<!-- Describe the motivation or the concrete use case. -->
This is super-annoying when used with SCSS mixins.
## Workaround
- Have a flag in SCSS mixins which conditional uses `::ng-deep` or not when needed. Developer is in charge of manual orchestration of its usage only in components where view encapsulation is enabled.
- Not using ViewEncapsulation.None and wrapping whole file in `::ng-deep`. Much easier to do with a preprocessor which allows nesting rules, though
## Environment
<pre><code>
Angular version: 4.4.3
<!-- Check whether this is still an issue in the most recent Angular version -->
| type: bug/fix,freq1: low,area: core,core: CSS encapsulation,P3 | low | Critical |
261,841,762 | go | cmd/compile: move DWARF go.info.* symbol generation out of the linker | The linker generates go.info.* symbols for Go types. It does so by parsing the contents of type.* symbols. It also depends on the names of these type.* symbols to successfully find other others.
All of this makes the linker quite fragile. The logic in decodesym.go has to be kept in sync with the compiler's rtype code generation, the runtime, and the reflect package. Depending on the type. symbol names interacts poorly with other things the linker wants to do, like rename symbols.
An easier place to generate these go.info.* symbols is in the compiler, right next to the code that generates the type.* symbols. The data structures are all nicely laid out in memory and don't require the hairy partial-decoding we do in the linker.
It looks like a tiny part of this has already been done, the compiler generates go.info symbols for vars. It should be possible to move the rest of the type symbols to the compiler piecemeal.
cc @heschik @dr2chase | NeedsInvestigation,compiler/runtime | low | Major |
261,870,915 | rust | It's often not possible to implement ToOwned for user composite types | `&str` and `&[u8]` seems to work by internal magic but it is hard to implement `ToOwned` for user composite types. Consider:
```rust
struct Foo<'a> {
foo: &'a str,
bar: &'a str,
foobar: &'a str
}
struct FooBuf {
foo: String,
bar: String,
foobar: String
}
```
It is not possible to mark that `FooBuf` is an owned version of `Foo` as it would require implementing `Borrow` for `FooBuf`. However it is not possible to implement `fn borrow(&FooBuf) -> &Foo` as we don't have anywhere we can store `Foo`. Built-in types workaround it by handling `&str` and similar types separately from `&T` and packing the actual structure there.
(I know too little about type system to create any RFR which would fix it) | T-lang,C-feature-request | low | Major |
261,923,516 | kubernetes | Also include namespace in encoding for --append-hash? | In a comment on [Generated Names for Generated Data](https://docs.google.com/document/d/1x1fJ3pGRx20ujR-Y89HUAw8glUL8-ygaztLkkmQeCdU/edit?ts=59d0846a) yesterday, @anguslees suggested including the name and namespace in the hashes. While the current implementation includes the name, it does not include the namespace. We should consider including the namespace as well, because it makes dictionary attacks less portable. The tradeoff is that this will be a backwards-incompatible change to kubectl (new encoding backing the hash).
/cc @anguslees @liggitt @mikedanese @bgrant0607 | area/security,area/kubectl,priority/awaiting-more-evidence,kind/feature,sig/cli,area/secret-api,lifecycle/frozen | medium | Major |
261,925,548 | awesome-mac | Alphabetize and curate each subsection | I'm curious what everyone thinks--would it be worthwhile to go back and alphabetize all the entires? | organization,high-priority | low | Minor |
261,931,648 | TypeScript | Augmenting external module that is re-exported? | **TypeScript Version:** 2.5.2
**Code**
This can't be demonstrated with a simple 1-file code example so I made a trivial project to demo it:
https://github.com/chriseppstein/typescript_module_augmentation_bug
Instructions for how to run the demo and work around the issue are included on the README there.
When I include an interface in a node module's main `index.ts` file, then it is open for merging with a `declare module "my_npm_module" {}` but when I move that interface into a local submodule and export it in the main `index.ts` with a `export * from "./local_module";` then the downstream consumer breaks.
**Expected behavior:**
It seems to me that the point of being able to export from other modules is to keep downstream consumers protected from internal refactors and maintain an existing public API. So I expect to be able to augment an interface and have it behave the same whether or not it has been re-exported.
**Actual behavior:**
It looks like the interface gets forked into two definitions, the downstream module sees only the interface surface that was added and the upstream module only sees the interface surface it defined. | Suggestion,Needs Proposal | low | Critical |
261,942,350 | go | os: OpenFile issue on darwin: 100% CPU on pty master read | Go version: `go version go1.9 darwin/amd64`
os.OpenFile calls os.newFile with `pollable` always true. (https://github.com/golang/go/blob/9f7fd893dc455339233a8e081f5fb5e2c51e7b5d/src/os/file_unix.go#L186)
On darwin, open `/dev/ptmx` fails to set the non-blocking flag, however, the subsequent slaves work fine. (https://github.com/golang/go/blob/9f7fd893dc455339233a8e081f5fb5e2c51e7b5d/src/os/file_unix.go#L105-L119)
My guess is that having the slave in non-blocking mode is the reason why read on the master takes 100% CPU.
Details of the issue: kr/pty#52
Quickfix: kr/pty#53
Is it expected always set the poller when using os.OpenFile? Maybe we should take a look at the flags and see if there is O_NONBLOCK instead of forcing it or maybe introduce a new flag to toggle the poller?
To reproduce on darwin: https://play.golang.org/p/rq8pJGL3ey
| OS-Darwin,NeedsInvestigation | low | Minor |
261,946,969 | rust | Add vi movement keys for navigating rust documentation | Adding vi movements keys would make it much faster to navigate the documentation while programming, since it would avoid having to resort to the mouse or arrow keys as frequently. Moving hands around can be annoying and is the reason many optimise their setups to avoid doing so. | T-rustdoc,P-low,C-feature-request | low | Major |
261,954,201 | neovim | Timer/job callback not triggered in "normal get additional char" state | I've noticed a difference to Vim, when I wanted to test for handling of operator pending mode in Neomake: Neovim does not trigger the timer callback that would be required to end the mode started with `feedkeys`.
This will hang after the `feedkeys` call:
```diff
diff --git a/src/nvim/testdir/test_autocmd.vim b/src/nvim/testdir/test_autocmd.vim
index 835df42a1..d55c1bed3 100644
--- a/src/nvim/testdir/test_autocmd.vim
+++ b/src/nvim/testdir/test_autocmd.vim
@@ -47,6 +47,13 @@ if has('timers')
au! CursorHoldI
set updatetime&
endfunc
+
+ func Test_exit_insert_mode_from_operator_pending()
+ let g:triggered = 0
+ call timer_start(100, 'ExitInsertMode')
+ call feedkeys("da", 'x!')
+ call assert_equal(1, g:triggered)
+ endfunc
endif
function Test_bufunload()
```
The same seems to apply to job callbacks.
This seems to be good in general (to not potentially interrupt the user), but I've wondered if this is intended, and if there is a test for this.
Would there be another way to simulate this in a test myself? | needs:design,job-control,event-loop | low | Major |
261,978,006 | godot | Having Trouble Compiling a module .dll | After cloning the master branch of godot yesterday (9/30/17) and building the engine for windows I tried going through the module tutorial. I was able to statically build and use the 'sumator' module (as in the tuorial) without problems, however, when trying to build a dll version of the module through VS2015, I get these error messages:
```
Severity Code Description Project File Line Suppression State
Error LNK1181 cannot open input file 'sumator.windows.tools.32.windows.tools.32.lib' godot F:\godot\LINK 1
Severity Code Description Project File Line Suppression State
Error MSB3073 The command "echo Starting SCons && cmd /V /C set "plat=x86" ^& (if "x86"=="x64" (set "plat=x86_amd64")) ^& set "tools=yes" ^& (if "debug"=="release" (set "tools=no")) ^& call "C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\vcvarsall.bat" !plat! ^& scons platform=windows target=debug tools=!tools! -j1" exited with code 2. godot C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\V140\Microsoft.MakeFile.Targets 41
```
The only file that changed between my successful build of static module and this one was the SCsub file which was setup like the tutorial:
```
Import('env')
sources = [
"register_types.cpp",
"sumator.cpp"
]
module_env = env.Clone()
module_env.Append(CXXFLAGS='-fPIC') # Needed to compile shared library
module_env['LIBS'] = []
shared_lib = module_env.SharedLibrary(target='#bin/sumator', source=sources)
shared_lib_shim = shared_lib[0].name.rsplit('.', 1)[0]
env.Append(LIBS=[shared_lib_shim])
env.Append(LIBPATH=['#bin'])
```
I know some of the tutorials are becoming dated with version 3.0, so is there something wrong with the file above or is there something else I need to do to get a .dll to show up in the bin folder?
| bug,topic:buildsystem,confirmed,documentation | low | Critical |
262,060,463 | rust | macros sometimes allow expr followed by ident | You can use a repetition to get around the future proofer.
```rust
macro_rules! bad {
($e:expr $i:ident) => {} //~ERROR
}
macro_rules! sneaky {
($($i:ident $e:expr)*) => {} // no error
}
fn main() {
sneaky!(a b c d);
}
```
I feel that both of these should be accepted, or neither. BTW, I am using the equivalent of `sneaky!` in brainmunch (found this while preparing my RustFest talk).
Fixing this by disallowing both macros would require cratering.
cc @jseyfried @LeoTestard | C-enhancement,P-medium,A-macros,T-lang | low | Critical |
262,089,655 | opencv | Documentation: eliminate absolute paths | Observed for classes from opencv_contrib.
[Example](http://docs.opencv.org/master/d4/db2/classcv_1_1aruco_1_1Board.html):
> The documentation for this class was generated from the following file:
/build/master-contrib_docs-lin64/opencv_contrib/modules/aruco/include/opencv2/aruco.hpp | category: documentation | low | Minor |
262,108,654 | kubernetes | Cronjobs - failedJobsHistoryLimit not reaping state `Error` | /kind bug
/sig apps
Cronjob limits were defined in #52390 - however it doesn't appear that `failedJobsHistoryLimit` will reap cronjob pods that end up in a state of `Error`
kubectl get pods --show-all | grep cronjob | grep Error | wc -l
566
Cronjob had `failedJobsHistoryLimit` set to 2
**Environment**:
- Kubernetes version (use `kubectl version`):
Client Version: version.Info{Major:"1", Minor:"7", GitVersion:"v1.7.6", GitCommit:"4bc5e7f9a6c25dc4c03d4d656f2cefd21540e28c", GitTreeState:"clean", BuildDate:"2017-09-15T08:51:09Z", GoVersion:"go1.9", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"6", GitVersion:"v1.6.4", GitCommit:"d6f433224538d4f9ca2f7ae19b252e6fcb66a3ae", GitTreeState:"clean", BuildDate:"2017-05-19T18:33:17Z", GoVersion:"go1.7.5", Compiler:"gc", Platform:"linux/amd64"}
- OS (e.g. from /etc/os-release):
Centos7.3
- Kernel (e.g. `uname -a`):
4.4.83-1.el7.elrepo.x86_64 #1 SMP Thu Aug 17 09:03:51 EDT 2017 x86_64 x86_64 x86_64 GNU/Linux
| kind/bug,sig/apps,area/workload-api/cronjob,area/workload-api/job,lifecycle/frozen | high | Critical |
262,246,336 | youtube-dl | Site support: Otomads.com | ## Please follow the guide below
- You will be asked some questions and requested to provide some information, please read them **carefully** and answer honestly
- Put an `x` into all the boxes [ ] relevant to your *issue* (like this: `[x]`)
- Use the *Preview* tab to see what your issue will actually look like
---
### Make sure you are using the *latest* version: run `youtube-dl --version` and ensure your version is *2017.10.01*. If it's not, read [this FAQ entry](https://github.com/rg3/youtube-dl/blob/master/README.md#how-do-i-update-youtube-dl) and update. Issues with outdated version will be rejected.
- [X] I've **verified** and **I assure** that I'm running youtube-dl **2017.10.01**
### Before submitting an *issue* make sure you have:
- [X] At least skimmed through the [README](https://github.com/rg3/youtube-dl/blob/master/README.md), **most notably** the [FAQ](https://github.com/rg3/youtube-dl#faq) and [BUGS](https://github.com/rg3/youtube-dl#bugs) sections
- [X] [Searched](https://github.com/rg3/youtube-dl/search?type=Issues) the bugtracker for similar issues including closed ones
### What is the purpose of your *issue*?
- [ ] Bug report (encountered problems with youtube-dl)
- [X] Site support request (request for adding support for a new site)
- [ ] Feature request (request for a new functionality)
- [ ] Question
- [ ] Other
---
### The following sections concretize particular purposed issues, you can erase any section (the contents between triple ---) not applicable to your *issue*
---
### If the purpose of this *issue* is a *bug report*, *site support request* or you are not completely sure provide the full verbose output as follows:
Add the `-v` flag to **your command line** you run youtube-dl with (`youtube-dl -v <your command line>`), copy the **whole** output and insert it here. It should look similar to one below (replace it with **your** log inserted between triple ```):
```
[debug] System config: []
[debug] User config: []
[debug] Command-line args: [u'-v', u'http://www.youtube.com/watch?v=BaW_jenozKcj']
[debug] Encodings: locale cp1251, fs mbcs, out cp866, pref cp1251
[debug] youtube-dl version 2017.10.01
[debug] Python version 2.7.11 - Windows-2003Server-5.2.3790-SP2
[debug] exe versions: ffmpeg N-75573-g1d0487f, ffprobe N-75573-g1d0487f, rtmpdump 2.4
[debug] Proxy map: {}
...
<end of log>
```
---
### If the purpose of this *issue* is a *site support request* please provide all kinds of example URLs support for which should be included (replace following example URLs by **yours**):
- Single video: https://www.youtube.com/watch?v=BaW_jenozKc
- Single video: https://youtu.be/BaW_jenozKc
- Playlist: https://www.youtube.com/playlist?list=PL4lCao7KL_QFVb7Iudeipvc2BCavECqzc
Note that **youtube-dl does not support sites dedicated to [copyright infringement](https://github.com/rg3/youtube-dl#can-you-add-support-for-this-anime-video-site-or-site-which-shows-current-movies-for-free)**. In order for site support request to be accepted all provided example URLs should not violate any copyrights.
---
### Description of your *issue*, suggested solution and other information
Explanation of your *issue* in arbitrary form goes here. Please make sure the [description is worded well enough to be understood](https://github.com/rg3/youtube-dl#is-the-description-of-the-issue-itself-sufficient). Provide as much context and examples as possible.
If work on your *issue* requires account credentials please provide them or explain how one can obtain them.
Site support request for otomads.com.
[Example video URL](https://otomads.com/om2249)
[Example channel URL](https://otomads.com/u599)
--dump-pages
```
[generic] om2249: Requesting header
WARNING: Falling back on generic information extractor.
[generic] om2249: Downloading webpage
[generic] Dumping request to https://otomads.com/om2249
PCFET0NUWVBFIGh0bWw+DQo8aHRtbD4NCjxoZWFkPg0KICA8bWV0YSBjaGFyc2V0PSJVVEYtOCI+DQogIDxtZXRhIG5hbWU9dmlld3BvcnQgY29udGVudD0id2lkdGg9ZGV2aWNlLXdpZHRoLCBpbml0aWFsLXNjYWxlPTEiPg0KICA8bWV0YSBuYW1lPSJkZXNjcmlwdGlvbiIgaWQ9Im1ldGEtZGVzY3JpcHRpb24iDQogICAgICAgIGNvbnRlbnQ9IlZpZGVvIHNoYXJpbmcgd2Vic2l0ZSBvbmx5IGZvciBvdG9tYWRzLiBBZHMgZnJlZS4gSGlnaCBxdWFsaXR5LiI+DQogIDx0aXRsZT5vdG9tYWRzPC90aXRsZT4NCg0KICA8c2NyaXB0IHNyYz0iL2xpYi9qcy9qcXVlcnkuanM/dj1uZXd1aTEiPjwvc2NyaXB0Pg0KICA8c2NyaXB0IHNyYz0iL2xpYi9qcy9EUGxheWVyLm1pbi5qcz92PW5ld3VpMSI+PC9zY3JpcHQ+DQogIDxsaW5rIHJlbD0ic3R5bGVzaGVldCIgaHJlZj0iL2xpYi9jc3MvRFBsYXllci5taW4uY3NzP3Y9bmV3dWkxIj4NCiAgPGxpbmsgcmVsPSJzdHlsZXNoZWV0IiBocmVmPSIvbGliL2Nzcy9mb250LWF3ZXNvbWUubWluLmNzcz92PW5ld3VpMSI+DQogIDxsaW5rIHJlbD0ic3R5bGVzaGVldCIgaHJlZj0iL2xpYi9jc3MvZm9udC1lbnR5cG8uY3NzP3Y9bmV3dWkxIj4NCiAgPGxpbmsgcmVsPSJzdHlsZXNoZWV0IiBocmVmPSIvY3NzL2luZGV4LmNzcz92PW5ld3VpMSI+DQogIDxsaW5rIHJlbD0iaWNvbiIgdHlwZT0iaW1hZ2UvcG5nIiBocmVmPSIvZmF2aWNvbi5wbmciPg0KPC9oZWFkPg0KPGJvZHk+DQogIDxkaXYgaWQ9ImFwcCI+PC9kaXY+DQogIDxzY3JpcHQgc3JjPSIvbWFpbi5qcz92PW5ld3VpMSI+PC9zY3JpcHQ+DQogIDxsaW5rIHJlbD0ic3R5bGVzaGVldCIgaHJlZj0iL2Nzcy9zdHlsZS5jc3M/dj1uZXd1aTEiPg0KPC9ib2R5Pg0KPC9odG1sPg0K
[generic] om2249: Extracting information
ERROR: Unsupported URL: https://otomads.com/om2249
```
| site-support-request | low | Critical |
262,248,606 | TypeScript | Expose configuration hook for custom module resolution | Following on from #6012 and #5039, it'd be nice to have the ability to add TypeScript to projects with heterogeneous module resolution/packaging systems and have typechecking work.
The `paths` and `baseUrl` configuration options get us a long way, but they don't deal well with module loaders that are less widely used, frequently changing, or that allow for complex module resolution rules. Letting the user entirely outsource all module resolution concerns using the configuration would allow type checking to work regardless of the user's preference of npm, bower, requirejs, browserify, jspm, webpack, etc.
A simple approach might be to have a `tsconfig` option for a parametrized command line invocation (similar to npm scripts) that is able to resolve modules. Each package manager can distribute a tool that implements module resolution according to its own needs, which the users can install and point to in their `tsconfig.json`.
Exactly how extensive the API needs to be is up for debate. It could be something as simple as a function that maps requested module names to file system paths, or a more abstract implementation of something like `System` from [here](https://github.com/Microsoft/TypeScript/blob/51e9aef2a7362cd82fce55901d0de82c521a8a89/src/compiler/sys.ts#L33), which could open up more interesting use cases (e.g. "virtual" modules built using code generation, or F# style [type providers](https://docs.microsoft.com/en-us/dotnet/fsharp/tutorials/type-providers/)). | Suggestion,In Discussion | high | Critical |
262,296,543 | youtube-dl | request support for another vooplayer url | ## Please follow the guide below
- You will be asked some questions and requested to provide some information, please read them **carefully** and answer honestly
- Put an `x` into all the boxes [ ] relevant to your *issue* (like this: `[x]`)
- Use the *Preview* tab to see what your issue will actually look like
---
### Make sure you are using the *latest* version: run `youtube-dl --version` and ensure your version is *2017.10.01*. If it's not, read [this FAQ entry](https://github.com/rg3/youtube-dl/blob/master/README.md#how-do-i-update-youtube-dl) and update. Issues with outdated version will be rejected.
- [x] I've **verified** and **I assure** that I'm running youtube-dl **2017.10.01**
### Before submitting an *issue* make sure you have:
- [x] At least skimmed through the [README](https://github.com/rg3/youtube-dl/blob/master/README.md), **most notably** the [FAQ](https://github.com/rg3/youtube-dl#faq) and [BUGS](https://github.com/rg3/youtube-dl#bugs) sections
- [x] [Searched](https://github.com/rg3/youtube-dl/search?type=Issues) the bugtracker for similar issues including closed ones
### What is the purpose of your *issue*?
- [ ] Bug report (encountered problems with youtube-dl)
- [x] Site support request (request for adding support for a new site)
- [x] Feature request (request for a new functionality)
- [ ] Question
- [ ] Other
---
### The following sections concretize particular purposed issues, you can erase any section (the contents between triple ---) not applicable to your *issue*
---
### If the purpose of this *issue* is a *bug report*, *site support request* or you are not completely sure provide the full verbose output as follows:
Add the `-v` flag to **your command line** you run youtube-dl with (`youtube-dl -v <your command line>`), copy the **whole** output and insert it here. It should look similar to one below (replace it with **your** log inserted between triple ```):
```
[generic] MTUxMTY=: Requesting header
WARNING: Falling back on generic information extractor.
[generic] MTUxMTY=: Downloading webpage
[generic] MTUxMTY=: Extracting information
ERROR: Unsupported URL: https://go.cdn.vooplayer.com/publish/MTUxMTY=
PS D:\> youtube-dl -v https://go.cdn.vooplayer.com/publish/MTUxMTY=
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['-v', 'https://go.cdn.vooplayer.com/publish/MTUxMTY=']
[debug] Encodings: locale cp1252, fs utf-8, out utf-8, pref cp1252
[debug] youtube-dl version 2017.10.01
[debug] Python version 3.6.1 - Windows-7-6.1.7601-SP1
[debug] exe versions: none
[debug] Proxy map: {}
[generic] MTUxMTY=: Requesting header
WARNING: Falling back on generic information extractor.
[generic] MTUxMTY=: Downloading webpage
[generic] MTUxMTY=: Extracting information
ERROR: Unsupported URL: https://go.cdn.vooplayer.com/publish/MTUxMTY=
Traceback (most recent call last):
File "c:\users\work\appdata\local\programs\python\python36\lib\site-packages\youtube_dl\YoutubeDL.py", line 783, in ex
tract_info
ie_result = ie.extract(url)
File "c:\users\work\appdata\local\programs\python\python36\lib\site-packages\youtube_dl\extractor\common.py", line 434
, in extract
ie_result = self._real_extract(url)
File "c:\users\work\appdata\local\programs\python\python36\lib\site-packages\youtube_dl\extractor\generic.py", line 30
51, in _real_extract
raise UnsupportedError(url)
youtube_dl.utils.UnsupportedError: Unsupported URL: https://go.cdn.vooplayer.com/publish/MTUxMTY=
```
---
### If the purpose of this *issue* is a *site support request* please provide all kinds of example URLs support for which should be included (replace following example URLs by **yours**):
- Single video: https://go.cdn.vooplayer.com/publish/MTUxMTY=
- Single video:
- Playlist:
Note that **youtube-dl does not support sites dedicated to [copyright infringement](https://github.com/rg3/youtube-dl#can-you-add-support-for-this-anime-video-site-or-site-which-shows-current-movies-for-free)**. In order for site support request to be accepted all provided example URLs should not violate any copyrights.
---
### Description of your *issue*, suggested solution and other information
Explanation of your *issue* in arbitrary form goes here. Please make sure the [description is worded well enough to be understood](https://github.com/rg3/youtube-dl#is-the-description-of-the-issue-itself-sufficient). Provide as much context and examples as possible.
If work on your *issue* requires account credentials please provide them or explain how one can obtain them.
hello youtube-dl team!
greetings!
this is to kindly request to your team to support another vooplayer url, example https://go.cdn.vooplayer.com/publish/MTUxMTY=
i've marked both [x] Site support request and [x] Feature request for the said request.
i've already tried pasting the possible vooplayer video file MTUxMTY= to youtube-dl's new capability to download vooplayer videos with this extension https://www.vooplayer.com/v3/watch/watch.php?v=, where...
_youtube-dl https://www.vooplayer.com/v3/watch/watch.php?v=MTUxMTY=_
and i've tried this youtube-dl functionality too...
_youtube-dl -v "https://go.cdn.vooplayer.com/publish/MTUxMTY=" --referer "https://www.wpcrafter.com/lesson/ee-using-box-shadows/"_
i hope your team can help and make downloading of another vooplayer url possible.
thank you youtube-dl team and more power!
looking forward to your reply.
respectfully yours,
az | site-support-request | low | Critical |
262,335,036 | opencv | solvePnPRansac does not work on some doc stated input shapes (Python bindings) | ##### System information (version)
- OpenCV => 3.3.0 and 3.1.0
- Operating System / Platform => macOS
- Compiler => Python bindings
The current `solvePnPRansac()` documentation states that the function works on `Nx3/3xN` single-channel `src` input and `Nx2/2xN` single-channel `dst` input (as well as `Nx1x3` and `Nx1x2`multi-channel inputs) but the function only works on the multi-channel inputs in Python. `solvePnP()` seems to work with both types, however.
See the [Stack Overflow question](https://stackoverflow.com/questions/46534126/solvepnp-object-points-image-points-shape/46538877?noredirect=1#comment80032402_46538877) that brought this up. Note that issue #6304 brought this up but is now closed with no PR attached to it as far as I can see.
Either a change to the Python bindings would fix the issue, or an update to the documentation. | category: documentation | low | Minor |
262,352,596 | rust | Avoid volatile loads to preserve the gdb pretty printer section | Right now when you compile a program with debuginfo on Linux we'll emit a volatile load of a gdb pretty printer section which is intended on ensuring that the linker forces a section in the executable.
Apparently, though, this has caused some problems for embedded work (cc @japaric) where the section doesn't always make it to the final image that's flashed to devices, meaning that this stray load near the beginning of the program can sometimes cause problems.
We should look into other solutions to force the linker to keep this symbol I think. Right now we're passing a version script on Linux to preserve symbols in cdylibs and I think the same would work for this? Worth trying out!
cc @michaelwoerister | A-linkage,A-debuginfo,C-enhancement,P-medium,T-compiler,WG-embedded | low | Critical |
262,557,557 | TypeScript | Don't extract constant to an unreachable location | ```ts
function Outer() {
return 1;
function Inner() {
1; // Extract this
}
}
```
Right now, the new local is inserted after the `return`, where it is unreachable. | Bug,Domain: Refactorings | low | Minor |
262,574,605 | TypeScript | Allow Extract Constant in expression-bodied arrow functions | ```ts
const f = () => 1 + [#|(2 + 3)|] + 4;
```
Expected:
```ts
const f = () => {
const newLocal = (2 + 3);
return 1 + newLocal + 4;
};
```
We can detect this scenario, but `ChangeTracker` doesn't support overlapping transformations (i.e. substituting `newLocal` into the expression and then putting the result into a return statement). | Suggestion,Domain: Refactorings,Experience Enhancement | low | Minor |
262,588,829 | react | Performance enhancements in niche situations | I hit on a couple things that were a bit surprising to me... not sure what I'm really asking here, other than if these things are documented somewhere. Also kinda just going with the flow where this seems to be the place to raise generic "issues" even if they're not bugs :)
1. keys can make things slower
I had a bunch of items, and the only thing that changed was their x/y positions. adding a key with index made rendering slower. It's possible this is short-sighted though since it could very well change once that "layer" has more items changing above/below it, but I found it interesting.
2. rendering null makes a _huge_ difference
I had two test cases - a full graphics pipeline vs. an essentially empty POJO renderer. The difference in speed didn't matter about the data or graphics, but rather about what was returned in the components `render()`. For DOM this doesn't work of course - but for custom renderers, when it's known that a certain type of element will be an edge node - doing the side effects in render() (or some other lifecycle) and then returning `null` is _significantly_ faster than even a straight functional component that returns a simple element (which does the same side effects). This makes sense, since react then has less branches to consider (even if those branches point to nothing other than simple objects).
| Type: Discussion,Component: Reconciler | low | Critical |
262,592,096 | rust | DW_TAG_formal_parameter always has DW_AT_decl_line == 1 | It seems that Rust debuginfo always writes `decl_line` of 1 for formal parameters.
With this `line.rs`:
```rust
#![crate_type = "dylib"] // line 1
pub fn foo( // 2
x: i32, // 3
y: i32) // 4
-> i32 // 5
{ x + y } // 6
```
With:
```
$ rustc +nightly -Vv
rustc 1.22.0-nightly (185cc5f26 2017-10-02)
binary: rustc
commit-hash: 185cc5f26d2c8a794189b028b43f6a3b8fc586db
commit-date: 2017-10-02
host: x86_64-unknown-linux-gnu
release: 1.22.0-nightly
LLVM version: 4.0
```
I get this output:
```
$ rustc +nightly -g line.rs
$ dwgrep 'entry ?(@AT_name == "foo") child*' libline.so
[2f] subprogram
low_pc 0x42100
high_pc 66
frame_base 0..0xffffffffffffffff:0 reg6
linkage_name "_ZN4line3fooE"
name "foo"
decl_file "/tmp/line.rs"
decl_line 2
type [8c] base_type
external true
[4c] formal_parameter
location 0..0xffffffffffffffff:0 fbreg <-16>
name "x"
decl_file "/tmp/line.rs"
decl_line 1
type [8c] base_type
[5a] formal_parameter
location 0..0xffffffffffffffff:0 fbreg <-12>
name "y"
decl_file "/tmp/line.rs"
decl_line 1
type [8c] base_type
[68] lexical_block
ranges 0x4210e..0x4212a, 0x4213a..0x42142
[6d] variable
location 0..0xffffffffffffffff:0 fbreg <-8>
name "x"
decl_file "/tmp/line.rs"
decl_line 3
type [8c] base_type
[7b] variable
location 0..0xffffffffffffffff:0 fbreg <-4>
name "y"
decl_file "/tmp/line.rs"
decl_line 4
type [8c] base_type
```
So it describes the formal parameters of `x` and `y` both with line 1, but also describes local variables with the correct lines 3 and 4.
In LLVM IR it looks like this, with the wrong lines in `!10` and `!13`:
```llvm
$ rustc +nightly -g line.rs --emit=llvm-ir
$ sed -n '/DIComp/,$p' line.ll
!0 = distinct !DICompileUnit(language: DW_LANG_Rust, file: !1, producer: "clang LLVM (rustc version 1.22.0-nightly (185cc5f26 2017-10-02))", isOptimized: false, runtimeVersion: 0, emissionKind: FullDebug, enums: !2)
!1 = !DIFile(filename: "line.rs", directory: "/tmp")
!2 = !{}
!3 = !{i32 2, !"Debug Info Version", i32 3}
!4 = distinct !DISubprogram(name: "foo", linkageName: "_ZN4line3fooE", scope: !5, file: !1, line: 2, type: !7, isLocal: false, isDefinition: true, scopeLine: 2, flags: DIFlagPrototyped, isOptimized: false, unit: !0, templateParams: !2, variables: !2)
!5 = !DINamespace(name: "line", scope: null, file: !6)
!6 = !DIFile(filename: "<unknown>", directory: "")
!7 = !DISubroutineType(types: !8)
!8 = !{!9, !9, !9}
!9 = !DIBasicType(name: "i32", size: 32, encoding: DW_ATE_signed)
!10 = !DILocalVariable(name: "x", arg: 1, scope: !4, file: !1, line: 1, type: !9)
!11 = !DIExpression()
!12 = !DILocation(line: 1, scope: !4)
!13 = !DILocalVariable(name: "y", arg: 2, scope: !4, file: !1, line: 1, type: !9)
!14 = !DILocalVariable(name: "x", scope: !15, file: !1, line: 3, type: !9, align: 4)
!15 = distinct !DILexicalBlock(scope: !4, file: !1, line: 6)
!16 = !DILocation(line: 3, scope: !15)
!17 = !DILocalVariable(name: "y", scope: !15, file: !1, line: 4, type: !9, align: 4)
!18 = !DILocation(line: 4, scope: !15)
!19 = !DILocation(line: 6, scope: !15)
!20 = !DILocation(line: 6, scope: !4)
``` | A-debuginfo,E-needs-test,T-compiler,C-bug | low | Critical |
262,838,479 | go | runtime/race: unexpected race when Conn.Close used for synchronization | go version devel +a714470 Wed Sep 27 16:29:18 2017 +0000 linux/amd64
The following program reports a race even though the read of x
cannot happen in parallel with the assignment to x because
we wait for the connection to be closed before reading it.
https://play.golang.org/p/ufvoScCbSm
==================
WARNING: DATA RACE
Read at 0x00c42008a220 by main goroutine:
main.main()
/home/rog/src/tst.go:24 +0x288
Previous write at 0x00c42008a220 by goroutine 7:
main.main.func1()
/home/rog/src/tst.go:16 +0x7a
Goroutine 7 (finished) created at:
main.main()
/home/rog/src/tst.go:14 +0x16d
==================
2017/10/04 16:48:53 1
Found 1 data race(s)
exit status 66
| RaceDetector,compiler/runtime | low | Major |
262,848,294 | rust | Missing stack trace on Windows | This unfortunately is not reliably reproducible - I can get a stack trace from small test projects, so the only way I can demonstrate it is cloning [this repo](https://github.com/parkovski/scifiweb/tree/5ef233e9454906e115ab674b1d9e4499282eb042) and running (with RUST_BACKTRACE=1) `scifiweb.exe run vm/test/noresolve.scifi`. I have VS2017 on Windows 10 - I don't remember this happening with 2015, so I'm not sure if it's a change made in VS or Rust.
The error I get is this - there is nothing printed after `stack backtrace:`.
```
thread 'main' panicked at 'Can't take immutable awake borrow while mutable borrow is active', util\src\graph_cell.rs:19:4
stack backtrace:
```
The VS debugger does show a stack trace, so the PDB must be generated correctly.
I'm willing to work on a fix for this if someone can point me toward how to debug the stack trace generation code in Rust. | A-debuginfo,T-compiler,O-windows-msvc,C-bug | low | Critical |
262,945,079 | react | Umbrella: React DOM Bugs | Since I was going through all open issues yesterday and today, I also compiled a list of things that seem broken in ReactDOM, grouped by areas.
I don’t think all of these issues are equally important but I’d like to start a discussion around how we can start attacking them—both in shorter and in longer term. For example any potential fixes to the onChange event logic would need to take https://github.com/facebook/react/issues/9657 into account (or even inform it).
I think it would be a good topic for our next chat, cc @jquense @aweary @nhunzaker. Maybe we could also broadcast it this time? 😃
## Autofill
* [ ] https://github.com/facebook/react/issues/1159 Provide a way to handle browser-autocompleted form values on controlled components
* [ ] https://github.com/facebook/react/issues/7328 IE 11 and Edge no longer prompt to remember password on controlled form
* [ ] https://github.com/facebook/react/issues/10468 DOM Fixture Form Coverage: Restored State and Auto-fill
## Composition Events
### Issues
* [x] https://github.com/facebook/react/issues/10217 Incorrect data in compositionend event when typing Korean on IE11
* [ ] https://github.com/facebook/react/issues/3926 Change event fires too many times when inputing Chinese characters
* [ ] <s>https://github.com/facebook/react/issues/8423 onChange does not work well with IE11 at Japanese IME. in React 15.4.0</s>
### PRs
* [x] https://github.com/facebook/react/pull/7926 <s>Try to generate a beforeInput event for buggy composition scenarios in IE</s>
* [x] https://github.com/facebook/react/pull/8438 Handle composition events in ChangeEventPlugin
## Mouse Enter / Leave
* [ ] https://github.com/facebook/react/issues/4251 mouseenter fires on disabled inputs whereas mouseleave does not
* [ ] https://github.com/facebook/react/issues/10109 Mouseenter event not triggered when cursor moves from disabled button
* [ ] https://github.com/facebook/react/issues/7135 onMouseEnter propagation in double reactroot
* [ ] https://github.com/facebook/react/issues/6807 onMouseLeave not working as expected
* [ ] https://github.com/facebook/react/issues/13956 onMouseEnter doesn't fire under removed node
## Input, Checkbox, and Select
* [x] https://github.com/facebook/react/issues/4672 Change event does not fire in IE and Edge under certain circumstances
* [x] https://github.com/facebook/react/issues/4854 Pressing spacebar on a checked radio button only fires click in some browsers
* [x] https://github.com/facebook/react/issues/6368 Input type 'email' as controlled component does not control white spaces
* [ ] https://github.com/facebook/react/issues/6951 Changing state in onFocus and onChange for a select multiple element does not work in Firefox
* [x] https://github.com/facebook/react/issues/7024 select onChange not firing when using keyboard
* [ ] https://github.com/facebook/react/issues/7281 <s>Input onChange not triggered every time in IE11 if e.preventDefault() used</s>
* [ ] https://github.com/facebook/react/issues/7489 input element `setSelectionRange` after backspace does not work in IE10
* [x] https://github.com/facebook/react/issues/7630 Radio buttons are not correctly checked when using multiple lists of radio buttons
* [ ] https://github.com/facebook/react/issues/7769 input autoFocus causes focus to be emitted before ref
* [ ] https://github.com/facebook/react/issues/8514 Undo behavior in controlled textareas works differently from the default behaviour in chrome
* [ ] https://github.com/facebook/react/issues/8531 <s>IE10 triggers onChange twice when replacing a text selection</s>
* [x] https://github.com/facebook/react/issues/8642 textarea + onFocus + stopPropagation = incorrect cursor rendering on Firefox
* [x] https://github.com/facebook/react/issues/8876 onBeforeInput fires after Edge updates the DOM
* [ ] https://github.com/facebook/react/issues/8938 Clear button on iOS date input does not return correct event value
* [ ] https://github.com/facebook/react/issues/9023 event.preventDefault in click handler does not prevent onChange from being called
* [x] https://github.com/facebook/react/issues/11010 Reset of select ignores defaultValue
| Type: Umbrella,React Core Team | medium | Critical |
262,961,656 | react | Type Fiber by tag as disjoint union | @sebmarkbage tried this in https://github.com/facebook/react/pull/8545 but Flow couldn't handle it well.
Might be worth trying again someday. | Type: Enhancement,Component: Reconciler,React Core Team | medium | Minor |
262,965,898 | flutter | Benchmark sub-systems of a11y processing | Get performance numbers for the following:
* Updating the semantics tree in Dart
* Transferring semantics tree update to native side
* Processing semantics tree update on native side | framework,c: performance,a: accessibility,P3,team-framework,triaged-framework | low | Major |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.