id
int64 393k
2.82B
| repo
stringclasses 68
values | title
stringlengths 1
936
| body
stringlengths 0
256k
⌀ | labels
stringlengths 2
508
| priority
stringclasses 3
values | severity
stringclasses 3
values |
|---|---|---|---|---|---|---|
246,901,834 | rust | rustc aborts when there is a compilation failure on FreeBSD and OpenBSD | When there is a compilation failure, the Rust compiler aborts with the following output:
```
$ rustc invalid.rs
error: requires at least a format string argument
--> invalid.rs:2:5
|
2 | print!()
| ^^^^^^^^
|
= note: this error originates in a macro outside of the current crate
error: aborting due to previous error(s)
fatal runtime error: failed to initiate panic, error 5
Abort trap (core dumped)
```
I used the following invalid source file:
```rust
fn main() {
print!()
}
```
Here is the backtrace:
```
(gdb) r
Starting program: /var/ports/obj/mnt/home/dumbbell/Projects/freebsd/ports/SVN/lang/rust/work/rustc-1.19.0-src/build/x86_64-unknown-freebsd/stage2/bin/rustc invalid.rs
[New LWP 101467 of process 50322]
error: requires at least a format string argument
--> invalid.rs:2:5
|
2 | print!()
| ^^^^^^^^
|
= note: this error originates in a macro outside of the current crate
error: aborting due to previous error(s)
fatal runtime error: failed to initiate panic, error 5
Thread 2 received signal SIGABRT, Aborted.
[Switching to LWP 101467 of process 50322]
0x0000000801be1b5a in thr_kill () from /lib/libc.so.7
(gdb) bt
#0 0x0000000801be1b5a in thr_kill () from /lib/libc.so.7
#1 0x0000000801be1b24 in __raise (s=6) at /mnt/home/dumbbell/Projects/freebsd/src/SVN/head/lib/libc/gen/raise.c:52
#2 0x0000000801be1a99 in abort () at /mnt/home/dumbbell/Projects/freebsd/src/SVN/head/lib/libc/stdlib/abort.c:65
#3 0x000000080184b5a1 in std::sys_common::util::abort::h1ff3fd43e3f3affb () from /var/ports/obj/mnt/home/dumbbell/Projects/freebsd/ports/SVN/lang/rust/work/rustc-1.19.0-src/build/x86_64-unknown-freebsd/stage2/bin/../lib/libstd-8923652fdd8a524a.so
#4 0x0000000801859f2e in rust_panic () from /var/ports/obj/mnt/home/dumbbell/Projects/freebsd/ports/SVN/lang/rust/work/rustc-1.19.0-src/build/x86_64-unknown-freebsd/stage2/bin/../lib/libstd-8923652fdd8a524a.so
#5 0x0000000801859e96 in std::panicking::rust_panic_with_hook::h625888e35dbc23f2 () from /var/ports/obj/mnt/home/dumbbell/Projects/freebsd/ports/SVN/lang/rust/work/rustc-1.19.0-src/build/x86_64-unknown-freebsd/stage2/bin/../lib/libstd-8923652fdd8a524a.so
#6 0x0000000805b69a29 in std::panicking::begin_panic::h334ae91969cdd553 () from /var/ports/obj/mnt/home/dumbbell/Projects/freebsd/ports/SVN/lang/rust/work/rustc-1.19.0-src/build/x86_64-unknown-freebsd/stage2/lib/../lib/librustc_errors-7119f0b402b67ca4.so
#7 0x0000000805b84415 in rustc_errors::Handler::abort_if_errors::h0cb792d8711ba104 () from /var/ports/obj/mnt/home/dumbbell/Projects/freebsd/ports/SVN/lang/rust/work/rustc-1.19.0-src/build/x86_64-unknown-freebsd/stage2/lib/../lib/librustc_errors-7119f0b402b67ca4.so
#8 0x0000000801515cd8 in rustc_driver::driver::phase_2_configure_and_expand::_$u7b$$u7b$closure$u7d$$u7d$::hed28ccb91f2e1d2f ()
from /var/ports/obj/mnt/home/dumbbell/Projects/freebsd/ports/SVN/lang/rust/work/rustc-1.19.0-src/build/x86_64-unknown-freebsd/stage2/bin/../lib/librustc_driver-d90bd0899d4860c7.so
#9 0x000000080150df01 in rustc_driver::driver::phase_2_configure_and_expand::hfdbd55e50731a10a ()
from /var/ports/obj/mnt/home/dumbbell/Projects/freebsd/ports/SVN/lang/rust/work/rustc-1.19.0-src/build/x86_64-unknown-freebsd/stage2/bin/../lib/librustc_driver-d90bd0899d4860c7.so
#10 0x00000008015058f7 in rustc_driver::driver::compile_input::ha42b7de34a40dbc4 () from /var/ports/obj/mnt/home/dumbbell/Projects/freebsd/ports/SVN/lang/rust/work/rustc-1.19.0-src/build/x86_64-unknown-freebsd/stage2/bin/../lib/librustc_driver-d90bd0899d4860c7.so
#11 0x0000000801550877 in rustc_driver::run_compiler::h166e93bfe8677c78 () from /var/ports/obj/mnt/home/dumbbell/Projects/freebsd/ports/SVN/lang/rust/work/rustc-1.19.0-src/build/x86_64-unknown-freebsd/stage2/bin/../lib/librustc_driver-d90bd0899d4860c7.so
#12 0x00000008014744dc in std::sys_common::backtrace::__rust_begin_short_backtrace::h31e6f5e865f4c216 ()
from /var/ports/obj/mnt/home/dumbbell/Projects/freebsd/ports/SVN/lang/rust/work/rustc-1.19.0-src/build/x86_64-unknown-freebsd/stage2/bin/../lib/librustc_driver-d90bd0899d4860c7.so
#13 0x0000000801865907 in __rust_maybe_catch_panic () from /var/ports/obj/mnt/home/dumbbell/Projects/freebsd/ports/SVN/lang/rust/work/rustc-1.19.0-src/build/x86_64-unknown-freebsd/stage2/bin/../lib/libstd-8923652fdd8a524a.so
#14 0x000000080149a2e1 in _$LT$F$u20$as$u20$alloc..boxed..FnBox$LT$A$GT$$GT$::call_box::h8348efc58e17166f ()
from /var/ports/obj/mnt/home/dumbbell/Projects/freebsd/ports/SVN/lang/rust/work/rustc-1.19.0-src/build/x86_64-unknown-freebsd/stage2/bin/../lib/librustc_driver-d90bd0899d4860c7.so
#15 0x0000000801858948 in std::sys::imp::thread::Thread::new::thread_start::h40165c228796f269 () from /var/ports/obj/mnt/home/dumbbell/Projects/freebsd/ports/SVN/lang/rust/work/rustc-1.19.0-src/build/x86_64-unknown-freebsd/stage2/bin/../lib/libstd-8923652fdd8a524a.so
#16 0x00000008067e8bc5 in thread_start (curthread=0x80b8a2b00) at /mnt/home/dumbbell/Projects/freebsd/src/SVN/head/lib/libthr/thread/thr_create.c:289
#17 0x0000000000000000 in ?? ()
Backtrace stopped: Cannot access memory at address 0x7fffdfffe000
```
As you can see in the paths, this is with Rust 1.19.0. The same happens with previous versions, so this isn't a regression (or not a recent one).
In the example, Rust was compiled with Clang 4.0.0, but the bundled LLVM was used.
When I compile and run a program which panics, the panic looks to be handled correctly:
```rust
fn main() {
panic!()
}
```
```
$ RUST_BACKTRACE=1 ./panic
thread 'main' panicked at 'explicit panic', panic.rs:2
stack backtrace:
0: std::sys::imp::backtrace::tracing::imp::unwind_backtrace
1: std::sys_common::backtrace::_print
2: std::panicking::default_hook::{{closure}}
3: std::panicking::default_hook
4: std::panicking::rust_panic_with_hook
5: std::panicking::begin_panic
6: panic::main
7: __rust_maybe_catch_panic
8: std::rt::lang_start
9: main
10: _start
```
I don't know how to debug this further. I tried with `debuginfo = true` and `debuginfo-lines = true` in `config.toml`, but then the problem vanishes. I'm willing to help but I would like some pointers to where to look :-) | I-crash,T-compiler,O-openbsd,O-freebsd,C-bug | low | Critical |
246,931,205 | rust | "error: trait bound is not satisfied" when it is | ### STR
``` toml
# Cargo.toml
[dependencies]
typenum = "=1.9.0"
```
``` rust
// src/lib.rs
extern crate typenum;
use std::marker::PhantomData;
use typenum::{Max, Maximum, Unsigned};
/// A resource, a mechanism to safely share data between tasks
trait Resource {
type Data: Send;
type Ceiling: Unsigned;
fn claim<THRESHOLD, F>(&self, t: &mut T<THRESHOLD>, f: F)
where
F: FnOnce(
&R<Self::Data, Self::Ceiling>,
&mut Maximum<THRESHOLD, Self::Ceiling>,
),
THRESHOLD: Unsigned + Max<Self::Ceiling>;
}
/// Unlocked resource
struct R<DATA, CEILING>
where
CEILING: Unsigned,
DATA: Send,
{
data: DATA,
_ceiling: PhantomData<CEILING>,
}
impl<DATA, CEILING> Resource for R<DATA, CEILING>
where
DATA: Send,
CEILING: Unsigned,
{
type Data = DATA;
type Ceiling = CEILING;
fn claim<THRESHOLD, F>(&self, t: &mut T<THRESHOLD>, f: F)
where
F: FnOnce(&R<DATA, CEILING>, &mut Maximum<THRESHOLD, CEILING>),
THRESHOLD: Unsigned + Max<CEILING>,
{
f(self)
}
}
/// Preemption threshold token
struct T<THRESHOLD>
where
THRESHOLD: Unsigned,
{
_threshold: PhantomData<THRESHOLD>,
}
```
``` console
$ cargo build
error[E0277]: the trait bound `THRESHOLD: typenum::Max<CEILING>` is not satisfied
--> src/lib.rs:39:5
|
39 | / fn claim<THRESHOLD, F>(&self, t: &mut T<THRESHOLD>, f: F)
40 | | where
41 | | F: FnOnce(&R<DATA, CEILING>, &mut Maximum<THRESHOLD, CEILING>),
42 | | THRESHOLD: Unsigned + Max<CEILING>,
43 | | {
44 | | f(self)
45 | | }
| |_____^ the trait `typenum::Max<CEILING>` is not implemented for `THRESHOLD`
|
= help: consider adding a `where THRESHOLD: typenum::Max<CEILING>` bound
error[E0277]: the trait bound `THRESHOLD: typenum::Max<CEILING>` is not satisfied
--> src/lib.rs:39:5
|
39 | / fn claim<THRESHOLD, F>(&self, t: &mut T<THRESHOLD>, f: F)
40 | | where
41 | | F: FnOnce(&R<DATA, CEILING>, &mut Maximum<THRESHOLD, CEILING>),
42 | | THRESHOLD: Unsigned + Max<CEILING>,
43 | | {
44 | | f(self)
45 | | }
| |_____^ the trait `typenum::Max<CEILING>` is not implemented for `THRESHOLD`
|
= help: consider adding a `where THRESHOLD: typenum::Max<CEILING>` bound
error[E0276]: impl has stricter requirements than trait
--> src/lib.rs:39:5
|
12 | / fn claim<THRESHOLD, F>(&self, t: &mut T<THRESHOLD>, f: F)
13 | | where
14 | | F: FnOnce(
15 | | &R<Self::Data, Self::Ceiling>,
16 | | &mut Maximum<THRESHOLD, Self::Ceiling>,
17 | | ),
18 | | THRESHOLD: Unsigned + Max<Self::Ceiling>;
| |_________________________________________________- definition of `claim` from trait
...
39 | / fn claim<THRESHOLD, F>(&self, t: &mut T<THRESHOLD>, f: F)
40 | | where
41 | | F: FnOnce(&R<DATA, CEILING>, &mut Maximum<THRESHOLD, CEILING>),
42 | | THRESHOLD: Unsigned + Max<CEILING>,
43 | | {
44 | | f(self)
45 | | }
| |_____^ impl has extra requirement `for<'r, 'r> F: std::ops::FnOnce<(&'r R<DATA, CEILING>, &'r mut _)>`
error: aborting due to 3 previous errors
```
### Expected outcome
I would expect this to compile since the supposedly unsatisfied trait bound is right there in the where clause of `claim`.
### Meta
``` console
$ rustc -V
rustc 1.21.0-nightly (599be0d18 2017-07-26)
```
cc @eddyb @nagisa Any clue what's wrong here? Seems closure related. If you drop the `FnOnce` bound and replace `F` with `Maximum<..>` it compiles. | A-type-system,T-compiler,C-bug,T-types | low | Critical |
247,028,611 | kubernetes | Support httpHead for pod livenessProbe | /kind feature
**What happened**:
The docs for [http liveness probes](https://kubernetes.io/docs/tasks/configure-pod-container/configure-liveness-readiness-probes/#define-a-liveness-http-request) only reference `httpGet`, but a http `HEAD` request is better for healthchecks as no data is returned so it is lighter weight.
**What you expected to happen**:
I would expect a httpHead directive to exist. It would perform a request such as:
```
HEAD / HTTP/1.1
```
vs `httpGet`, which does something like:
```
GET / HTTP/1.1
```
**How to reproduce it (as minimally and precisely as possible)**:
Create a livenessProbe and be :disappointed: that `HEAD` requests aren't available. | sig/node,kind/feature,needs-triage | high | Critical |
247,032,765 | TypeScript | cannot redeclare exported variable | <!-- BUGS: Please use this template. -->
<!-- QUESTIONS: This is not a general support forum! Ask Qs at http://stackoverflow.com/questions/tagged/typescript -->
<!-- SUGGESTIONS: See https://github.com/Microsoft/TypeScript-wiki/blob/master/Writing-Good-Design-Proposals.md -->
**TypeScript Version:** 2.4.2
**Code**
```js
// @ts-check
exports.foo = function() {};
exports.foo = _.memoize(exports.foo);
```
**Expected behavior:**
no errors since this is a commonjs file (`tsconfig.json` configured appropriately) and this is an ok behaviour in Node.js.
**Actual behavior:**
error: cannot redeclare exported variable foo | Bug,Domain: JavaScript | low | Critical |
247,034,267 | electron | Feature request: <webview> app-manifest-updated event | The Electron `<webview>` has events for notifying its parent when web page metadata changes including:
* `page-title-updated` for `<title>` changes
* `page-favicon-updated` for `<link rel=icon>` changes
* `did-change-theme-color` for `<meta name=theme-color>` changes
I'd like to propose a new event which is dispatched when a web app manifest link relation changes:
* `app-manifest-updated` for `<link rel=manifest>` changes
...as defined by [W3C Web App Manifest](https://www.w3.org/TR/appmanifest/) specification and used by modern progressive web apps.
The payload of the event could simply be the URL of the manifest as with icon link relations, or it could be the manifest JSON content itself with Electron responsible for fetching the manifest in a fully spec compliant way (e.g. using the correct browsing context and supporting HTTP authenticated manifests etc).
For prior art, see the vendor-prefixed [`mozbrowsermanifestchanged` event](https://developer.mozilla.org/en-US/docs/Web/Events/mozbrowsermanifestchange) in Gecko's Browser API (similar to Electron's Webview API).
The use case of this event is to detect when the current web page is part of a web app that can be installed, and use the manifest metadata to install the web app into a web app runtime.
The event name could be different to what I propose here, but note that a web app manifest applies to a whole web app or website which may consist of multiple pages, it it not strictly page metadata in the way that a `<title>` is. | enhancement :sparkles:,component/webview | low | Major |
247,086,358 | rust | Final link failed (with CARGO_INCREMENTAL) | Sometimes (it's not always reproducible and it doesn't happen with some specific code), I get a linker error complaining undefined references to rust functions in my project, something like this:
```
= note: /home/vorner/work/pakon/aggregator/target/debug/deps/aggregator-57e8a9355952fffd.aggregator-keeper-query-tests.o: In function `aggregator::keeper::query::tests::time_to_system':
/home/vorner/work/pakon/aggregator/src/keeper/query.rs:414: undefined reference to `aggregator::keeper::query::Time::to_absolute::h1a0a7dea62a07bb1'
/home/vorner/work/pakon/aggregator/src/keeper/query.rs:421: undefined reference to `aggregator::keeper::query::Time::to_absolute::h1a0a7dea62a07bb1'
/usr/lib/gcc/x86_64-pc-linux-gnu/6.3.0/../../../../x86_64-pc-linux-gnu/bin/ld: /home/vorner/work/pakon/aggregator/target/debug/deps/aggregator-57e8a9355952fffd: hidden symbol `_ZN10aggregator6keeper5query4Time11to_absolute17h1a0a7dea62a07bb1E' isn't defined
/usr/lib/gcc/x86_64-pc-linux-gnu/6.3.0/../../../../x86_64-pc-linux-gnu/bin/ld: final link failed: Bad value
collect2: error: ld returned 1 exit status
```
They don't go away even when I modify the sources and try to compile again. These things help:
* Running `cargo clean` and trying again.
* Running the compilation *without* CARGO_INCREMENTAL (I have it set in my environment).
Therefore, I believe sometimes rustc produces and stores part of the compilation without the function present and tries to reuse it next time. I further suspect this might happen when the function is unused at the first compilation, but then I add a test that uses it ‒ maybe some kind of optimisation producing the module (or struct's impl) without the code for the unused function and caching it, not noticing it is missing the next time.
It happens more often when I code with `cargo watch --no-restart -x test --all` in a separate terminal and save the file often (maybe simply because the compilation is run more often).
```
$ rustc --version --verbose
rustc 1.21.0-nightly (aac223f4f 2017-07-30)
binary: rustc
commit-hash: aac223f4f5d5ca979c694b614d4db37a7200528d
commit-date: 2017-07-30
host: x86_64-unknown-linux-gnu
release: 1.21.0-nightly
LLVM version: 4.0
``` | A-linkage,T-compiler,A-incr-comp,C-bug | low | Critical |
247,133,774 | TypeScript | File altered by before transform does not remove new unused imports | **Description of the bug:**
When using a before transform that makes an import unused, the import will not be removed by TypeScript.
So if I have:
```ts
import { unused } from 'unused-module';
import { something } from 'some-module';
const value = something;
```
And replace `const value = something` with
```ts
import { somethingElse } from 'some-other-module';
const value = somethingElse;
```
The `import { unused } from 'unused-module';` statement will be removed, but `import { something } from 'some-module';` will remain:
```ts
import { something } from 'some-module';
import { somethingElse } from 'some-other-module';
const value = somethingElse;
```
**TypeScript Version:** 2.4.2
**Code**
```ts
import { unused } from 'unused-module';
import { something } from 'some-module';
const value = something;
```
Reproduction of this bug requires using the transforms API.
I have prepared a repository with a simple reproduction that runs this file: https://github.com/filipesilva/ts-transform-import-bug/blob/master/test.ts
```
git clone https://github.com/filipesilva/ts-transform-import-bug
cd ts-transform-decorator-bug
npm install
npm test
```
**Expected behavior:**
All unused imports are removed.
```ts
import { somethingElse } from 'some-other-module';
const value = somethingElse;
```
**Actual behavior:**
Only imports there were unused before the transformed are removed.
```ts
import { something } from 'some-module';
import { somethingElse } from 'some-other-module';
const value = somethingElse;
```
/cc @rbuckton | Bug,API,Domain: Transforms | low | Critical |
247,150,281 | vscode | macOS: Copying text to clipboard does not preserve tabs | This might be an Electron problem rather than VS Code, but copying text to the clipboard does not preserve tabs. Instead, it converts the tabs to an appropriate number of non-breaking space characters.
Here is `settings.json`:
```javascript
{
"editor.fontFamily": "'SFMono Light', Hack, Menlo, Monaco, 'Courier New', monospace",
"editor.minimap.enabled": false,
"editor.fontSize": 15,
"editor.renderIndentGuides": true,
"terminal.integrated.fontSize": 14,
"editor.insertSpaces": false,
"editor.autoIndent": false,
"editor.detectIndentation": false
}
```
- VSCode Version: Code 1.14.2 (cb82febafda0c8c199b9201ad274e25d9a76874e, 2017-07-19T23:22:50.650Z)
- OS Version: Darwin x64 16.7.0
- Extensions:
Extension|Author (truncated)|Version
---|---|---
EditorConfig|Edi|0.9.4
angular1-code-snippets-johnpapastyle|lpe|0.1.0
guides|spy|0.8.4
---
Steps to Reproduce:
1. Insert text with tabs
2. Copy text to clipboard
3. Clipboard contents have non-breaking spaces instead of tabs
<!-- Launch with `code --disable-extensions` to check. -->
Reproduces without extensions: Yes | bug,macos,editor-clipboard | low | Minor |
247,166,771 | rust | Tracking issue for oom=panic (RFC 2116) | **Update:** This now the tracking issue for a mechanism to make OOM / memory allocation errors panic (and so by default unwind the thread) instead of aborting the process. This feature was accepted in RFC https://github.com/rust-lang/rfcs/pull/2116.
It was separated from https://github.com/rust-lang/rust/issues/48043, which tracks another feature of the same RFC, since the two features will likely be stabilized at different times.
**Blockers**
This should be blocked until we can audit all places in the code that allocate to ensure they safely handle unwinding on OOM.
- [x] https://github.com/rust-lang/rust/issues/123369
- [ ] https://github.com/rust-lang/unsafe-code-guidelines/issues/506
**Steps:**
- [ ] Implement the RFC
- [ ] `std::alloc::set_allocation_error_hook` (tracked at https://github.com/rust-lang/rust/issues/51245) could potentially be this mechanism, but that hook is currently document as not allowed to unwind.
- [ ] Adjust documentation ([see instructions on forge][doc-guide])
- [ ] Stabilization PR ([see instructions on forge][stabilization-guide])
[stabilization-guide]: https://forge.rust-lang.org/stabilization-guide.html
[doc-guide]: https://forge.rust-lang.org/stabilization-guide.html#updating-documentation
Original feature request:
----
Several users who are invested in the "thread is a task" model that Rust was originally designed around have expressed a desire to unwind in the case of OOM. Specifically each task has large and unpredictable memory usage, and tearing down the first task that encounters OOM is considered a reasonable strategy.
Aborting on OOM is considered unacceptable because it would be expensive to discard all the work that the other tasks have managed to do.
We already (accidentally?) specified that all allocators can panic on OOM, including the global one, with the introduction of generic allocators on collections. So in theory no one "should" be relying on the default `oom=abort` semantics. This knob would only affect the default global allocator. Presumably there would just be a function somewhere in the stdlib which is cfg'd to be a panic or abort based on this flag?
This is not a replacement for proper fallible allocation handling routines requested in #29802 because most of the potential users of **that** API build with `panic=abort`. Also the requesters of **this** API are unwilling to go through the effort to ensure all their dependents are using fallible allocations everywhere.
I am dubious on this API but I'm filling an issue so that it's written down and everyone who wants it has a place to go and assert that it is in fact good and desirable. | B-RFC-approved,A-allocators,T-lang,T-libs-api,C-tracking-issue,Libs-Tracked,S-tracking-ready-to-stabilize | high | Critical |
247,183,013 | vscode | multiCursorModifier should be ctrlCmd by default for *nix users | - VSCode Version: Code - Insiders 1.15.0-insider (6328bae2bf8382fd4abd054c14976548eaea66cf, 2017-07-27T07:00:51.592Z)
- OS Version: Linux x64 4.10.0-28-generic
- Extensions: none
---
Following on the heels of #21506, I feel that the default click action for *nix users should not be alt-click, but ctrl-click.
What's odd is I only see references to ctrl-click in the issue, but somehow...
Alt-click is mapped by default in Ubuntu window manager to move windows, so alt-click in this case does nothing (or rather, it moves the vscode window)
Perhaps this is more a question than a bug, but:
1. Is this configurable in `settings.json`, so it is ctrl-click?
2. If not, can the default be changed to ctrl-click so it functions on Ubuntu at least? | feature-request,editor-multicursor | low | Critical |
247,263,333 | flutter | Would like to be able to avoid asset load errors at runtime | Currently with Flutter it's very easy to end up with asset load errors at runtime since assets are keyed off of strings, which are not in any way validated at analyze time (or generated/provided by the system).
Posse's currently most common crash in their live app is a failed asset string load.
They also have a manual file of string constants that they maintain from their pubspec.yaml (presumably could be autogenerated pretty easily).
This just seems like a pattern we could help with. This bug is about finding ideas to reduce the likelihood of this kind of failure.
FYI @yjbanov
| tool,framework,a: assets,P3,team-framework,triaged-framework | low | Critical |
247,264,281 | rust | Confusing mismatched type error | If you forget to put a semicolon after the last expression in the body of a function that returns no values, `rustc` will infer that the type of the expression should be `()`. If the programmer didn't intend to return a value, but merely forgot to type a semicolon, the resulting error can be confusing. Consider, for example, the following [toy program](https://play.rust-lang.org/?gist=0bf5eb6df01e8b850d0a413e56cc59b8&version=stable):
```rust
use std::ptr;
fn main() {
let a = 0;
ptr::read(&a)
}
```
This produces the following error message:
```text
error[E0308]: mismatched types
--> src/main.rs:5:15
|
5 | ptr::read(&a)
| ^^ expected (), found integral variable
|
= note: expected type `*const ()`
found type `&{integer}`
```
In this simple example, it may be obvious, but in the somewhat more complicated code I was working with that led me to this issue, I spent a decent amount of time trying to figure out why I was supposedly passing a pointer to `()` to `mem::replace`, thus causing the type of the second argument to `replace` to fail to unify. It took me a while to figure out that this was actually the culprit.
<!-- TRIAGEBOT_START -->
<!-- TRIAGEBOT_ASSIGN_START -->
<!-- TRIAGEBOT_ASSIGN_DATA_START$${"user":"sulami"}$$TRIAGEBOT_ASSIGN_DATA_END -->
<!-- TRIAGEBOT_ASSIGN_END -->
<!-- TRIAGEBOT_END --> | C-enhancement,A-diagnostics,T-compiler,D-confusing,D-newcomer-roadblock | low | Critical |
247,281,102 | rust | "failed to run cargo build" on powerpc64 when installing rust 1.19.0 | After downloading the latest Rust release tarball, 1.19.0, running ./configure, and then make, I get the following, after a few tarballs are downloaded successfully:
```
aperez@debian-sid-ppc64:~/rust-1.19.0$ make -j4
downloading https://static.rust-lang.org/dist/2017-06-08/rust-std-1.18.0-powerpc64-unknown-linux-gnu.tar.gz
######################################################################## 100.0%
extracting /home/aperez/rust-1.19.0/build/cache/2017-06-08/rust-std-1.18.0-powerpc64-unknown-linux-gnu.tar.gz
downloading https://static.rust-lang.org/dist/2017-06-08/rustc-1.18.0-powerpc64-unknown-linux-gnu.tar.gz
######################################################################## 100.0%
extracting /home/aperez/rust-1.19.0/build/cache/2017-06-08/rustc-1.18.0-powerpc64-unknown-linux-gnu.tar.gz
downloading https://static.rust-lang.org/dist/2017-06-08/cargo-0.19.0-powerpc64-unknown-linux-gnu.tar.gz
######################################################################## 100.0%
extracting /home/aperez/rust-1.19.0/build/cache/2017-06-08/cargo-0.19.0-powerpc64-unknown-linux-gnu.tar.gz
failed to run: /home/aperez/rust-1.19.0/build/powerpc64-unknown-linux-gnu/stage0/bin/cargo build --manifest-path /home/aperez/rust-1.19.0/src/bootstrap/Cargo.toml
Build completed unsuccessfully in 0:00:51
Makefile:24: recipe for target 'all' failed
make: *** [all] Error 1
``` | I-crash,O-PowerPC,C-bug | low | Critical |
247,403,434 | angular | Angular Router + Browser History=> extra page view count in GA | <!--
PLEASE HELP US PROCESS GITHUB ISSUES FASTER BY PROVIDING THE FOLLOWING INFORMATION.
ISSUES MISSING IMPORTANT INFORMATION MAY BE CLOSED WITHOUT INVESTIGATION.
-->
## I'm submitting a...
<!-- Check one of the following options with "x" -->
<pre><code>
[ ] Regression (a behavior that used to work and stopped working in a new release)
[X] Bug report <!-- Please search GitHub for a similar issue or PR before submitting -->
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question
</code></pre>
## Current behavior
<!-- Describe how the issue manifests. -->
There is two bug here. one of them is already raised https://github.com/angular/angular/issues/17148
the other one is if resolver reject, Router will add the route to browser.history
## Expected behavior
<!-- Describe what the desired behavior would be. -->
rejected route should not be added to history by replaceState nor pushState becuse it is rejected and the user should stay in current page
## Minimal reproduction of the problem with instructions
<!--
For bug reports please provide the *STEPS TO REPRODUCE* and if possible a *MINIMAL DEMO* of the problem via
https://plnkr.co or similar (you can use this template as a starting point: http://plnkr.co/edit/tpl:AvJOMERrnz94ekVua0u5).
-->
http://plnkr.co/edit/PlUgiNrC8eTWUajoxxEg?p=preview
please open console.
you will land on page 1 by default
page 2 and 3 has a resolver which will reject. so you are not able to navigate to page 2 or 3
click on page2 or page3 link
an error will be raised (reproduce of issue 17148)
before each error, you will see a warning in console
`app.ts:92 >>>>THEY DID IT replaceState!` (reproduce this error)
## What is the motivation / use case for changing the behavior?
<!-- Describe the motivation or the concrete use case. -->
In single page application + GTM, we should track the page view event for GA by using browser.history
browser history change event will be fired after replaceState and/or pushState
because replaceState is called, GTM will fire page track event which is wrong.
## Environment
<pre><code>
Angular version: 4.1.2 - 4.3.2
<!-- Check whether this is still an issue in the most recent Angular version -->
Browser:
- [ ] Chrome (desktop) version XX
- [ ] Chrome (Android) version XX
- [X] Chrome (iOS) Version 59.0.3071.115 (Official Build) (64-bit)
- [X] Firefox version 54.0.1 (64-bit)
- [ ] Safari (desktop) version XX
- [X] Safari (iOS) Version 10.1.2 (12603.3.8)
- [ ] IE version XX
- [ ] Edge version XX
For Tooling issues:
- Node version: XX <!-- run `node --version` -->
- Platform: <!-- Mac, Linux, Windows -->
Others:
<!-- Anything else relevant? Operating system version, IDE, package manager, HTTP server, ... -->
</code></pre>
I am not sure it is relevant or not so I am putting it in other section:
base on my comment on another issue if you modify resolver and replace error line with following:
`subject.error({message: 'some error', ngNavigationCancelingError: true});`
there will be no error any more
but the problem in this error will be bigger.
replaceState will be fired twice!!!! for each rejected route!!!!
issue https://github.com/angular/angular/issues/13873 is similar to issue 1
the main expectation is wrong but still it is raised becuse resolver reject will raise an error
| type: bug/fix,freq2: medium,area: router,state: confirmed,P3 | low | Critical |
247,446,381 | electron | Register URL pattern as bypassing CSP? | Since `v0.30.3` we can register URL schemes (`http`, `file`, `chrome-extension`.. ) as bypassing CSP via `webFrame.registerURLSchemeAsBypassingCSP`.
Is there a way to register URL patterns (like `https://mydomain.com/trusted-scripts/*`) as bypassing CSPs?
If no, would it make sense to add such an API (`webFrame.registerURLPatternAsBypassingCSP` I guess)?
Any idea where I should start the implementation from on Chromium side? | enhancement :sparkles: | low | Minor |
247,447,498 | opencv | The Viz3d window seems to have broken. | <!--
If you have a question rather than reporting a bug please go to http://answers.opencv.org where you get much faster responses.
If you need further assistance please read [How To Contribute](https://github.com/opencv/opencv/wiki/How_to_contribute).
This is a template helping you to create an issue which can be processed as quickly as possible. This is the bug reporting section for the OpenCV library.
-->
##### System information (version)
<!-- Example
- OpenCV => 3.2
- Operating System / Platform => Ubuntu 17.04
- Compiler => g++
-->
- OpenCV => 3.2
- Operating System / Platform => Ubuntu 17.04
- Compiler => g++
##### Detailed description
The 3D Visualizer module seems to have broken with a recent update to Ubuntu 17.04. The Viz3d window was behaving normally last week, but now just displays a blank, blue window. I also tested one of the tutorials from the documentation, and I get the same result. It seems like I can set the background color with setBackgroundColor(), but other commands I've tried have no effect. The console only prints this line of text:
```.txt
../../../../src/intel/isl/isl.c:1370: FINISHME: validate row pitch of stencil surfaces
```
##### Steps to reproduce
Open a viz::Viz3d window and start the update loop to reproduce the bug. Bellow is the tutorial I've been using to check the issue.
<!-- to add code example fence it with triple backticks and optional file extension
```.cpp
// C++ code example
```
or attach as .txt or .zip file
-->
```.cpp
#include <opencv2/viz.hpp>
#include <opencv2/calib3d.hpp>
#include <iostream>
using namespace cv;
int main() {
viz::Viz3d myWindow("Coordinate Frame");
myWindow.showWidget("Coordinate Widget", viz::WCoordinateSystem());
viz::WLine axis(Point3f(-1.0f, -1.0f, -1.0f), Point3f(1.0f, 1.0f, 1.0f));
axis.setRenderingProperty(viz::LINE_WIDTH, 4.0);
myWindow.showWidget("Line Widget", axis);
viz::WCube cube_widget(Point3f(0.5, 0.5, 0.0), Point3f(0.0, 0.0, -0.5), true, viz::Color::blue());
cube_widget.setRenderingProperty(viz::LINE_WIDTH, 4.0);
myWindow.showWidget("Cube Widget", cube_widget);
Mat rot_vec = Mat::zeros(1, 3, CV_32F);
float translation_phase = 0.0, translation = 0.0;
while (!myWindow.wasStopped()) {
rot_vec.at<float>(0, 0) += CV_PI * 0.01f;
rot_vec.at<float>(0, 1) += CV_PI * 0.01f;
rot_vec.at<float>(0, 2) += CV_PI * 0.01f;
translation_phase += CV_PI * 0.01f;
translation = sin(translation_phase);
Mat rot_mat;
Rodrigues(rot_vec, rot_mat);
Affine3f pose(rot_mat, Vec3f(translation, translation, translation));
myWindow.setWidgetPose("Cube Widget", pose);
myWindow.spinOnce(1, true);
}
return 0;
}
``` | bug,category: viz | low | Critical |
247,498,586 | go | cmd/compile: incorrect type assertions on conflicting package names | This is a bug that has existed since Go1.0.
Consider the following packages:
```go
package iface // import "github.com/dsnet/example/iface1/iface"
import "fmt"
import "reflect"
func CheckInterface() {
type iface interface { unexported() }
var v interface{} = foo{}
t := reflect.TypeOf(v)
t1 := reflect.TypeOf((*iface)(nil)).Elem()
t2 := reflect.TypeOf((*interface { unexported() })(nil)).Elem()
fmt.Println("reflect implements named interface: ", t.Implements(t1))
fmt.Println("reflect implements interface literal:", t.Implements(t2))
_, ok1 := v.(iface)
_, ok2 := v.(interface { unexported() })
fmt.Println("type assertion on named interface: ", ok1)
fmt.Println("type assertion on interface literal: ", ok2)
fmt.Println()
}
type foo struct{}
func (foo) unexported() {}
```
```go
package iface // import "github.com/dsnet/example/iface2/iface"
import "fmt"
import "reflect"
func CheckInterface() {
type iface interface { unexported() }
var v interface{} = foo{}
t := reflect.TypeOf(v)
t1 := reflect.TypeOf((*iface)(nil)).Elem()
t2 := reflect.TypeOf((*interface { unexported() })(nil)).Elem()
fmt.Println("reflect implements named interface: ", t.Implements(t1))
fmt.Println("reflect implements interface literal:", t.Implements(t2))
_, ok1 := v.(iface)
_, ok2 := v.(interface { unexported() })
fmt.Println("type assertion on named interface: ", ok1)
fmt.Println("type assertion on interface literal: ", ok2)
fmt.Println()
}
type foo struct{}
func (foo) unexported() {}
```
In the setup, we have two packages both named `iface` where the source code of both packages is identical, but they have different absolute package paths.
Running the following program:
```go
package main
import (
iface1 "github.com/dsnet/example/iface1/iface"
iface2 "github.com/dsnet/example/iface2/iface"
)
func main() {
iface1.CheckInterface()
iface2.CheckInterface()
}
```
Prints the following (on Go1.0 to Go1.8):
```
reflect implements named interface: true
reflect implements interface literal: true
type assertion on named interface: true
type assertion on interface literal: true
reflect implements named interface: true
reflect implements interface literal: false
type assertion on named interface: true
type assertion on interface literal: false
```
The output slightly differs on Go1.9, but is still wrong.
We expect that calling `iface1.CheckInterface()` and `iface2.CheckInterface()` to produce the exact same results. However, that is not what we see. In `iface2`, type assertions via a interface literal on unexported fields no longer works properly, but it works as expected in `iface1`.
\cc @ianlancetaylor @josharian @mdempsky @neild | NeedsFix | low | Critical |
247,535,673 | flutter | Refactor "pop" so that BackButton can quit the app on Android | 
Specifically:
* Remove the call to `SystemNavigator.pop` from the `didPopRoute` handler in the `WidgetsApp`.
* Make `WidgetsApp` call `maybePop` instead of `pop` on the Navigator. (Or, make it call another method that then calls `maybePop`, so that we don't break `maybePop` users.)
* Make `maybePop` (or probably the aforementioned new method that calls `maybePop`) default to calling `pop` if it can pop and there's more than one route around, otherwise, call `onPopFirst` or `onExit` on the Navigator widget (if such a callback was provided). This is a `VoidCallback` property.
* Have `WidgetsApp` provide such a callback to its `Navigator`, which calls an `onExit` callback that _it_ also provides. That callback should return a boolean. If that callback returns false, it does nothing, otherwise it calls `SystemNavigator.pop`. | framework,f: routes,P2,team-framework,triaged-framework | low | Critical |
247,539,885 | TypeScript | Support for a built-in "constructable" type or "class type" | <!-- BUGS: Please use this template. -->
<!-- QUESTIONS: This is not a general support forum! Ask Qs at http://stackoverflow.com/questions/tagged/typescript -->
<!-- SUGGESTIONS: See https://github.com/Microsoft/TypeScript-wiki/blob/master/Writing-Good-Design-Proposals.md -->
**TypeScript Version:** 2.4.0
It would be interesting to allow type hinting for class type.
Something like
```ts
function generateMyClass(myClass: class) {
return new myClass();
}
class Foo {}
generateMyClass(Foo); // Should work
generateMyClass('something else'); // should NOT work
```
Currently, the closest we have is
```ts
type Instantiable = {new(...args: any[]): any};
function doSomethingWithMyClass(myClass: Instantiable ) {
// some code that doesn't matter
}
class Foo {}
abstract class Bar {}
doSomethingWithMyClass(Foo); // It works :)
doSomethingWithMyClass('something else' ); // It doesn't work and it's OK
doSomethingWithMyClass(Bar); // It doesn't work and it's NOT OK
```
It is of course logical that the abstract class causes an error with the code above, this is why it could be nice to have something to handle this case.
To go further, we can think about adding some genericity on it.
```ts
// With the actual implementation
type Instantiable<T = any> = {new(...args: any[]): T};
function foo<T>(myClass: Instantiable<T>): T { /* ... */ }
// With the new class type hint
function foo<T>(myClass: class<T>): T { /* ... */ }
```
| Suggestion,Awaiting More Feedback | medium | Critical |
247,557,583 | TypeScript | Generic values | TypeScript supports generic type/interface/class declarations. These features serve as an analog of "type constructors" in other type systems: they allow us to declare a type that is parameterized over some number of type arguments.
TypeScript also supports generic functions. These serve as limited form of parametric polymorphism: they allow us to declare types whose *inhabitants* are parametrized over some number of type arguments. Unlike in certain other type systems however, these types can only be function types.
So for example while we can declare:
```ts
type Id = <T>(x : T) => T
const test : Id = x => x
```
we cannot declare (for whatever reason):
```ts
type TwoIds = <T> { id1: (x: T) => T, id2: (x: T) => T }
const test : TwoIds = { id1: x => x, id2: x => x }
```
One result of this limitation is that the type constructor and polymorphism features interact poorly in TypeScript. The problem applies even to function types: if we abstract a sophisticated function type into a type constructor, we can no longer universally quantify away its type parameters to get a generic function type. This is illustrated below:
```ts
// This works
type Id = <T>(x : T) => T
// This should also work
type IdT<T> = (x: T) => T
type Id = <T> IdT<T> // but is impossible to express
```
Another problem is that it is often useful to quantify over types other than bare functions, and TypeScript prohibits this. As an example, this prevents us from modeling polymorphic lenses:
```ts
type Lens<T, U> = {
get(obj: T): U
set(val: U, obj: T): T
}
// no way to express the following type signature
const firstItemInArrayLens: <A> Lens<A[], A> = {
get: arr => arr[0],
set: (val, arr) => [val, ...arr.slice(1)]
}
firstItemInArrayLens.get([10]) // Should be number
firstItemInArrayLens.get(["Hello"]) // Should be string
```
In this case, a workaround is to break down the type into functions and move all the polymorphic quantification there, since functions are the only values that are allowed to be polymorphic in TypeScript:
```ts
type ArrayIndexLens = {
get<A>(obj: A[]): A
set<A>(val: A, obj: A[]): A[]
}
const firstItemInArrayLens: ArrayIndexLens = { ... }
```
By contrast, in Haskell you'd simply declare an inhabitant of a polymorphic type: `firstItemInArrayLens :: forall a. Lens [a] a`, similarly to the pseudocode declaration `const firstItemInArrayLens: <A> Lens<A[], A>`:
```hs
{-# LANGUAGE ExplicitForAll #-}
data Lens s a = Lens { get :: s -> a, set :: a -> s -> s }
firstItemInArrayLens :: forall a. Lens [a] a
firstItemInArrayLens = Lens { get = _, set = _ }
```
In some sense TypeScript has even less of a problem doing this than Haskell, because Haskell has concerns like runtime specialization; it must turn every polymorphic expression into an actual function which receives type arguments.
TypeScript just needs to worry about assignability; at runtime everything is duck typed and "polymorphic" anyway. A more polymorphic term (or a term for which a sufficiently polymorphic type can be inferred) can be assigned to a reference of a less polymorphic type.
Today, a value of type `<A> (x: A) => A` is assignable where a `(x: number) => number` is expected, and in turn the expression `x => x` is assignable where a `<A> (x: A) => A` is expected. Why not generalize this so an `<A> Foo<A>` is assignable wherever a `Foo<string>` is expected, and it is possible to write: `const anythingFooer: <A> Foo<A> = { /* implement Foo polymorphically */ }`? | Suggestion,Awaiting More Feedback | high | Critical |
247,585,591 | rust | -Zdump-mir is incomplete for dead functions | Given the following program
```
fn main() {
let _closure = |x: i32| x+x;
}
```
I would expect `rustc filename.rs -Zdump-mir=all` to dump all stages of the MIR of all functions. What happens instead is that for the closure, only the `000-*` and `001-*` passes are emitted; the `002-*` are missing. That's probably because they are not actually emitted into the binary, so they never get generated. I think that's a bug; one should expect `-Zdump-mir` to generate the MIR of all phases of all code.
(I noticed this because I was adding a mir-opt test and it told me it couldn't find the file.) | I-needs-decision,T-compiler,C-bug | low | Critical |
247,659,096 | vscode | [folding] show comment first line for folded sections | I think it could be really useful to change the multiline comment folding.
When you fold a comment like this (like above php function) :
```
/**
* Print person name on terminal
*
* @param person $p
* @return void
*/
```
You see this :
```
/** ...
```
In some editors like phpStorm or Eclipse, it's folded like this :
```
* Print person name on terminal ...
```
That's very more useful ;)
Is it possible to implement this kind of folding ? | feature-request,editor-folding | medium | Major |
247,733,052 | go | net/http: still return the content on malformed MIME header line | Please answer these questions before submitting your issue. Thanks!
### What version of Go are you using (`go version`)?
go version go1.8.3 darwin/amd64
### What operating system and processor architecture are you using (`go env`)?
GOARCH="amd64"
GOBIN=""
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
GOPATH="/Users/jsilva/go"
GORACE=""
GOROOT="/usr/local/Cellar/go/1.8.3/libexec"
GOTOOLDIR="/usr/local/Cellar/go/1.8.3/libexec/pkg/tool/darwin_amd64"
GCCGO="gccgo"
CC="clang"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/_n/q8bzrfk93ss0nf_0fbk2ns8c0000gn/T/go-build250479046=/tmp/go-build -gno-record-gcc-switches -fno-common"
CXX="clang++"
CGO_ENABLED="1"
PKG_CONFIG="pkg-config"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
### What did you do?
Fetch "http://107-182-231-168.webnow.net.br/status2.xsl?mount=/98fm.aac" or a similar URL from another Icecast server using http.Client.
Source: https://gist.github.com/joaolsilva/d24b7bf5602f0d6615eb5d385fd0ffdc
https://play.golang.org/p/MiokU7tQgI
### What did you expect to see?
The content of the URL
### What did you see instead?
err: Get http://107-182-231-168.webnow.net.br/status2.xsl?mount=/98fm.aac: malformed MIME header line: Content-Disposition = attachment; filename=file.asc
The MIME header might indeed be malformed, but other http clients such as cURL, browsers, etc. work (they seem to ignore the malformed line) and return the content. | NeedsDecision | medium | Critical |
247,747,086 | TypeScript | Allow object types to have property-like associated types | **Edit:** Add `static Type` variant for classes, make abstractness a little clearer, clarify things.
*This has probably already been asked before, but a quick search didn't turn up anything.*
This is similar, and partially inspired by, Swift's/Rust's associated types and Scala's abstract types.
---
## Rationale
- In complex structures like in virtual DOM components/nodes and in graphs, where there are numerous constraints to check, but they would get cumbersome in a hurry to force off onto the user.
- ~~In dynamic imports, where you never have the module namespace itself until runtime, yet you still want to be able to use types defined within it.~~ **Edit:** [Already addressed elsewhere](https://github.com/Microsoft/TypeScript/issues/22445).
- In types where there's a *lot* of optional parameters, it'd be easier and more flexible to label which ones you're defining as part of the type.
- In types where you want to specify a single optional parameter, and the required ordering requires you to specify some that you *don't* want to specify, that would get boilerplatey in a hurry. I've experienced this personally on multiple occasions.
- It would allow fully typing namespaces and named module imports without hard-coded compiler handling.
## Proposed Syntax/Semantics
- Each interface and object type may have a number of associated types within it.
- Associated types are checked for assignability like any other usual property, except they live in a different "namespace" from properties. In particular, the type must be assignable to the target's type.
- To access an associated type, you use `TypeName.Type`, where `Type` is the name of an associated type.
- For sugar and namespace compatibility, `object.Type` is equivalent to `(typeof object).Type`
- To expect an interface with an associated type, you use `Foo & {type Type: Value}` or `Foo with <Type: Value>`.
- To expect an object with an associated type, you use `{type Type: Value}`.
- To declare an abstract associated type, you use `type Type: *` within the interface or object type.
- To declare a non-abstract associated type, you use `type Type: Default` within the interface or object type.
- To constrain an abstract associated type, you use `type Type: * extends Super`.
- Associated types may be inherited from other interfaces and/or object types.
- Namespaces' types are modified to include the exported types as associated types.
- Classes may also define associated types, optionally with visibility modifiers.
- Associated types may have defaults, in case they aren't defined or further constrained later.
- Constraining an associated type with an existing default removes the default if and only if the existing constraint is not assignable to the new constraint. For example, `{type Foo: string | number = string} & {type Foo: string | number}` is assignable to `{type Foo: string}`, but `{type Foo: string | number = string} & {type Foo: number}` is not.
Here's what that would look like in syntax:
```ts
// Interfaces
interface Foo {
type Type: *; // abstract
type Sub: * extends Type; // abstract, constrained
type Type: Default;
type Type: * extends Type = Default; // late-bound default
}
// Objects
type Foo = {
type Type: Foo,
}
// Classes
abstract class Foo {
// Note: outer class *must* be abstract for these, and the keyword is required.
abstract type Type: *; // abstract
private abstract type Sub: * extends Type; // abstract, constrained
protected abstract type Type: * extends Type = Default, // late-bound default
// Note: outer class *may* be not abstract for these.
type Type: Default;
private type Type: Default;
// Declare an associated type in the class
// Note: type must not be abstract.
static Type: Foo;
}
```
## Emit
This has no effect on the JavaScript emit as it is purely type-level.
## Compatibility
- This is purely additive, making no observably incompatible changes beyond possibly different error messages.
- This has no impact on any existing JavaScript-related proposal.
## Other
- It may slow down the type checker a little initially when namespaces are unified, but two optimization points are available, which would recover most of the perf hit, if not all:
- Associated types could be stored in a per-interface type map.
- The list of associated types could be initially stored as `undefined` to avoid generating a large number of empty arrays.
- It should have little effect on editor tooling. | Suggestion,In Discussion | high | Critical |
247,770,146 | TypeScript | Extending string-based enums | Before string based enums, many would fall back to objects. Using objects also allows extending of types. For example:
```ts
const BasicEvents = {
Start: "Start",
Finish: "Finish"
};
const AdvEvents = {
...BasicEvents,
Pause: "Pause",
Resume: "Resume"
};
```
When switching over to string enums, it"s impossible to achieve this without re-defining the enum.
I would be very useful to be able to do something like this:
```ts
enum BasicEvents {
Start = "Start",
Finish = "Finish"
};
// extend enum using "extends" keyword
enum AdvEvents extends BasicEvents {
Pause = "Pause",
Resume = "Resume"
};
```
Considering that the produced enums are objects, this won"t be too horrible either:
```ts
// extend enum using spread
enum AdvEvents {
...BasicEvents,
Pause = "Pause",
Resume = "Resume"
};
```
| Suggestion,Waiting for TC39 | high | Critical |
247,770,607 | angular | Component/declarative error handling (ala React 16's <ErrorBoundary/>) |
## I'm submitting a...
<!-- Check one of the following options with "x" -->
<pre><code>
[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report <!-- Please search GitHub for a similar issue or PR before submitting -->
[x] Feature request
[x] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question
</code></pre>
React recently introduced a concept called "Error Boundaries" (https://facebook.github.io/react/blog/2017/07/26/error-handling-in-react-16.html). Basically you wrap key areas of your app with <ErrorBoundary> .... </ErrorBoundary> and any component/template errors within can be handled at that level. I've run into issues with my Angular 4 app where an error in a component will cause the app to break ... sometimes the app is still navigable but often times rendering is messed up and the app just needs a restart. Most blog posts (and the Angular documentation) on error handling don't deal with rendering issues, just logging/handling any exceptions that may occur. What are strategies for gracefully handling "breaking errors" in an Angular app? Would something like <ErrorBoundary/> make sense for Angular?
Edit: after discussing with @robwormald, it seems the current proscribed solution for handling uncaught errors would be to log them and then reload the entire app via the `ErrorHandler` mechanism already in Angular. This is still less than ideal (although ideally there would be no errors :-)). As applications grow, and as third party components are added/upgraded - it would be useful to introduce an the concept of an ErrorBoundary for two primary reasons:
1) allows more graceful and selective degradation of the app (if a child components underneath an ErrorBoundary fail, they can be restarted)
2) Error boundaries will introduce 'bulkheads' that ensure a single error won't sink the entire ship (forcing an app reload/restart), which will be more important the more likely errors are to occur (size of app, # external components, etc) | feature,area: core,core: error handling,feature: under consideration | medium | Critical |
247,809,019 | go | testing: collect performance counters for benchmarks | Performance counters may be helpful for benchmarking:
- it can provide more information like cache misses, branch misprediction, etc.
- number of cycles may be more stable than wall clock time.
It may be hard to do it in a portable way. But doing it only on platforms that are available would still be nice.
@aclements
| Proposal,Proposal-Accepted | medium | Major |
247,849,153 | TypeScript | Don't allow `this` in decorator expressions | e.g. `@this.method()` is invalid | Bug,Domain: Decorators,ES Next | low | Minor |
248,003,365 | react | Too much unnecessary updates when a child element is moved to the front | **Do you want to request a *feature* or report a *bug*?**
Not sure if it's a bug or an 'accepted' behavior. But this can affect performance in some situations or even 'break the expectations' in others (e.g. animating moved elements [i.e. simple moves])
**What is the current behavior?**
When a child element moves from the end of the list to the front React actually moves all the other elements after the moved/last element instead of simply inserting the moved element at the front of the list.
This also can be stated more generally for an element or a block of elements moving backward with a significant shift.
**If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem via https://jsfiddle.net or similar (template: https://jsfiddle.net/84v837e9/).**
Here is a [demo](https://codesandbox.io/s/wjZkrGVzJ) that shows the DOM operations performed on DOM nodes (moves & insertions) during reconciliation. To reproduce the issue
- type '0123456789x' in the input field then click `Patch!`
- now type 'x0123456789' (move the last 'x' to the front) then click `Patch!` again
Here's the output
Instead of moving the 'x' to the front. React actually moves all the other elements after the 'x'
*Note: the demo uses MutationObserver api to find out the operations. But you can also verify this behavior directly by commenting out the code that activates the dom observer (in componentDidMount) and watch the dom operations manually in the devtools element inspector*
**What is the expected behavior?**
React should perform the minimal number of operations. I know that the 'minimum' will vary for each situation and not trivial to infer for the general case. But for some common cases like this one it should be feasible.
For info this use case is handled in most of the other virtual dom libs like preact, snabbdom. Inferno is a remarkable case as it will always infer the minimum number of operations (it uses an algorithm to find the [longest increasing subsequence](https://en.wikipedia.org/wiki/Longest_increasing_subsequence) on an array containing the indexes of the old elements).
I found this behavior while working on a demo to find out how vdom libs rearrange nodes during children reconciliation. For example here is the same output for other libs ([demo](https://codesandbox.io/s/BkLpXYQn))
**Which versions of React, and which browser / OS are affected by this issue? Did this work in previous versions of React?**
The demo uses the 0.16 version. But I tried with 0.15 and it has the same behavior | Type: Discussion,Component: Reconciler | low | Critical |
248,050,044 | go | x/build/cmd/gopherbot: don't fight humans | In #20892, I re-opened an issue, only to have @gopherbot re-close it. This is an issue to follow-up on what happened there. cc @andybons @kevinburke | Builders,NeedsFix | medium | Major |
248,050,750 | rust | Tuples of functions do not coerce to tuples of function pointers | Hi
Following code does not compile in current nightly even though error message does not seem to have valid meaning. Returning single function in both match arms compiles successfully.
```
fn m(i:i8) {
let (l, r) = match i {
0 => {
fn f1()-> bool { true };
fn f2()-> bool { true };
(f1, f2)
}
1 => {
fn f1()-> bool { true };
fn f2()-> bool { true };
(f1, f2)
}
};
}
fn main() {
m(0)
}
error[E0308]: match arms have incompatible types
--> src/main.rs:2:16
|
2 | let (l, r) = match i {
| ________________^
3 | | 0 => {
4 | | fn f1()-> bool { true };
5 | | fn f2()-> bool { true };
... |
12 | | }
13 | | };
| |___^ expected fn item, found a different fn item
|
= note: expected type `(fn() -> bool {m::f1}, fn() -> bool {m::f2})` (fn item)
found type `(fn() -> bool {m::f1}, fn() -> bool {m::f2})` (fn item)
note: match arm with an incompatible type
```
| A-type-system,T-lang,C-feature-request,T-types | low | Critical |
248,057,332 | TypeScript | Suggestion: Provide better APIs to simplify converting CommentRanges into SynthesizedComments | **Scenario**
[Tsickle from the Angular project](https://github.com/angular/tsickle) is a TypeScript transformer that makes the emitted JavaScript compatible with Google Closure Compiler.
For this, it converts types into comments so that Closure Compiler can understand the types. E.g.
```ts
/**
* The test function
*/
function test(a: number): string { ...}
```
becomes
```js
/**
* The test function
* @param {number} a
* @return {string}
*/
function test(a: number): string { ...}
```
Additionally, it escapes existing `@...` tags in jsdoc tags that are unknown to Closure Compiler. E.g.
```ts
/**
* For example,
* @madeUpTag
*/
const c = 'c';
```
becomes
```ts
/**
* For example,
* \@madeUpTag
*/
const c = 'c';
```
Finally, it also generates new code that also contains comments. E.g. it always adds a file prelude and converts interfaces into functions with closure type annotations:
```ts
interface Point {
x: number;
y: number;
}
```
becomes
```ts
/**
* @fileoverview Generated by tsickle
*/
function Point() { }
function Point_tsickle_Closure_declarations() {
/** @type {number} */
Point.prototype.x;
/** @type {number} */
Point.prototype.y;
}
```
It follows, that Tsickle needs to be able to potentially modify every comment in the emitted JavaScript, and be able to synthetically create any kind of comment as well. We recently switched to using transformers, and went with the following approach to modify comments: Suppress the original comment via `ts.EmitFlags.NoComment`, convert the `ts.CommentRange`s into `ts.SynthesizedComment`s which can be modified.
**Problems with the current API**
We made this work, but we had to duplicate quite a but of logic from [compiler/comments.ts](https://github.com/Microsoft/TypeScript/blob/master/src/compiler/comments.ts):
- for a parent and a child node that start / end at the same offset (e.g. `VariableStatement` and the first `VariableDeclaration`), `ts.getLeadingCommentRanges` / `ts.getTrailingCommentRanges` returns the same comments for both, as it is only based on the node position. With the current API, we need to keep track of which comments we already processed so that we don't get duplications in the output.
- getting the leading inline comments before a node does not work when using `ts.getLeadingCommentRanges` as it skips the characters until the first newline. With the current API, we force the function to read all leading comments by using `pos = 0` and just passing in the trivia of the node. This gives us all comments, but we also need to keep track of which comments were already processed so that we don't duplicate the trailing comments from the previous node.
- there is no API do detect the different kind of comments (pinned, detached, tripple slash), and the API for emitting `SynthesizedComment`s only has regular comments that are always emitted. I.e. using the current API, we need to duplicate a lot of the logic from TypeScript.
- there is no API for detecting detached leading / trailing comments (e.g. for `Block`s and `SourceFile`). With the current API, we need to duplicate the logic for detecting detached comments, including the counting of newlines between comments. There is also no direct API for emitting detached `SynthesizedComment`s. So far we are using a `ts.NonEmittedStatement` with `ts.EmitFlags.CustomPrologue` (the `EmitFlag` is to prevent additional newlines before the comment).
- synthetic comments already add the wrapping comment characters (`/*` / `*/` / `//` ) depending on the `CommentKind`, so when converting a `CommentRange` into a `SynthesizedComment` we need to strip them manually.
**Proposal Attempt**
Add the following APIs:
- `ts.getLeadingCommentRanges(node: ts.Node): ts.CommentRange[]`
* similar to `ts.getLeadingCommentRanges(text: string, pos: number)`
* would solve the problems of inline leading comments
* would only return a comment for either the parent or child when they start at the same position.
* would never return leading detached comments
- `ts.getTrailingCommentRanges(node: ts.Node): ts.CommentRange[]`:
* similar to `ts.getTrailingCommentRanges(text: string, pos: number)`
* would only return a comment for either the parent or child when they end at the same position.
* would never return trailing detached comments
- `ts.getLeading/TrailingDetachedCommentRanges(node: ts.Node): ts.CommentRange[]`:
* returns the leading / trailing detached comments for a `ts.Block` and `ts.SourceFile`
- `ts.setSyntheticLeading/TrailingDetachedComments(node: ts.Node, comments: ts.SynthesizedComment[])`:
* would set leading / trailing detached synthesized comments for a `ts.Block` and `ts.SourceFile`
Additionally, change `ts.SynthesizedComment` / `ts.CommentRange`:
```ts
type CommentKind = SyntaxKind.SingleLineCommentTrivia | SyntaxKind.MultiLineCommentTrivia | SyntaxKind.TrippleSlashCommentTrivia;
interface ts.CommentRange {
isPinned?: boolean;
}
interface ts.SynthesizedComment extends ts.CommentRange {
...
containsTrivia?: boolean // whether the `text` already contains the trivia or not.
}
```
/cc @mprobst @evmar @alexeagle | Suggestion,In Discussion,API | low | Minor |
248,068,018 | rust | Compiler unable to match types with trait implementation | `rustc 1.19.0 (0ade33941 2017-07-17)`
The following piece of code:
```rust
pub struct Foo {
pub data: [u8; 64],
}
pub struct FooRef<'a> {
pub data: &'a [u8; 64],
}
impl<'a> From<&'a Foo> for FooRef<'a> {
fn from(foo: &'a Foo) -> Self {
FooRef {
data: &foo.data,
}
}
}
impl Foo {
pub fn do_something<'a, F>(&self, _foo: F) where FooRef<'a>: From<F> {
let _test_foo = FooRef::from(self);
}
pub fn do_something2<F>(&self, _foo: F) {
let _test_foo2 = FooRef::from(self);
}
}
```
fails with:
```
error[E0308]: mismatched types
--> foo/src/lib.rs:19:32
|
19 | let _test_foo = FooRef::from(self);
| ^^^^ expected type parameter, found &Foo
|
= note: expected type `F`
found type `&Foo`
error: aborting due to previous error(s)
```
Because of additional lifetime or template at line 19, compiler is no longer able to resolve `FooRef::from(self);`
Link to the repo:
https://github.com/debris/borrowchecker_test
run with `cargo check -p foo`
It may not be an issue, but in that case, it needs better error message. And also, please tell me how to make it work ;) | A-type-system,T-compiler,C-bug,T-types | low | Critical |
248,073,371 | go | cmd/compile, runtime: add and use go:nosplitrec compilation directive | A key error leading to #21306 was a call from a nosplit function to a function not marked nosplit, permitting preemption at a point where it was not permitted.
Therefore, just as we have `go:nowritebarrierrec` meaning that such a function may not call any function that permits write barriers, we should have `go:nosplitrec` meaning that such a function may not call any function that permits preemption.
Since `nosplit` is now a misnomer--the stack no longer splits--we could also consider a name like `go:nopreemptrec`. | NeedsFix,compiler/runtime | medium | Critical |
248,084,546 | go | x/build: set up alerts for errors reported to stackdriver | Currently we get a bunch of errors reported, eg:
9/4/17 7:53AM: buildID: B32739cd61, name: windows-amd64-2016, hostType: host-windows-amd64-2016, error: failed to get a buildlet: Error creating instance: &{Code:QUOTA_EXCEEDED Location: Message:Quota 'CPUS' exceeded. Limit: 500.0 ForceSendFields:[] NullFields:[]}
8/4/17 7:53AM: buildID: B059b7649c, name: openbsd-amd64-60, hostType: host-openbsd-amd64-60, error: failed to get a buildlet: Failed to create instance: googleapi: Error 403: Quota 'CPUS' exceeded. Limit: 500.0, quotaExceeded
at main.(*buildStatus).reportErr (coordinator.go:1951)
... etc
Probably not a pressing issue, as the coordinator's retry logic is at least enough to ensure the builds eventually run.
EDIT:
we need to figure out which errors are noise, and alert on the rest. | Builders | low | Critical |
248,098,767 | opencv | Absence of GridAdaptedFeature detector, dense adapted feature detector | <!--
If you have a question rather than reporting a bug please go to http://answers.opencv.org where you get much faster responses.
If you need further assistance please read [How To Contribute](https://github.com/opencv/opencv/wiki/How_to_contribute).
This is a template helping you to create an issue which can be processed as quickly as possible. This is the bug reporting section for the OpenCV library.
-->
It appears that the following detectors were removed -
DenseFeatureDetector, OpponentColorDescriptorExtractor, DynamicAdaptedFeatureDetector, PyramidAdaptedFeatureDetector
in this commit - https://github.com/opencv/opencv/commit/31df47b6eaeb753a77f4d0cc3f4225c5c40682f6
Is there any chance that these methods will be brought back into OpenCV?
| category: features2d,RFC | low | Critical |
248,114,062 | react | <video /> attribute needed but not guaranteed by React | As @gaearon [mentioned](https://twitter.com/dan_abramov/status/893511715463340033), React does not guarantee an *attribute* will be set, so probably this is not a bug.
If I understand well, react will ensure the property is set anyway.
**Current behaviour**
React renders the html `<video />` element without the attribute `muted` when explicitly passed.
**Demo time**
In [this pen](https://codepen.io/elrumordelaluz/pen/ba4b5294cec7ea455c66e9b9d0a6c889?editors=0010) I made a simple example setting `muted` to the element and obtaining the result below:
Actually the property is set well, since the [original medial file](http://clips.vorwaerts-gmbh.de/VfE_html5.mp4) has an audio track and in the pen result is muted.
**The point**
I think is most a _specific need_ than the _expected behaviour_.
From the functionality POV, it is absolutely ok, my _Component_ renders a `<video />` muted as requested and so on.
But there are _browsers_ and _policies_, more specifically related to this issue, Webkit and the [New <video> Policies for iOS](https://webkit.org/blog/6784/new-video-policies-for-ios/) updated one year ago, with some interesting changes for the `<video />` element.
The part interested is
> `<video muted>` elements will also be allowed to autoplay without a user gesture.
So, the _specific need_ is to have the _explicit_ `attribute` to tell the browser that this video could be `autoPlay`ed.
There's a similar [issue](https://github.com/facebook/react/issues/6544) | Type: Feature Request,Component: DOM,HTML | high | Critical |
248,174,074 | TypeScript | Feedback to improve compileOnSave with tsserver. | I have implemented inside Eclipse `compile on save` with tsserver by consuming `compileOnSaveAffectedFileList` and `compileOnSaveEmitFile` commands. It works great but I think we could again improved it
For `compileOnSaveAffectedFileList`:
* `compileOnSaveAffectedFileList` should throw error when the given file is excluded of tsconfig.json. It will give the capability to display an error dialog when user wishes to compile a ts file which is excluded by tsconfig.json
* in some case, tsserver `compileOnSaveAffectedFileList` returns *.d.ts files (see ttps://github.com/angelozerr/typescript.java/issues/190#issuecomment-317876026) those *.d.ts files must be ignored for compilation.
For `compileOnSaveEmitFile`:
* the reponse `compileOnSaveEmitFile` should return diagnostics errors. I had to call the two tsserver commands `syntacticDiagnosticsSync` and `semantacticDiagnosticsSync` after the call of `compileOnSaveEmitFile` to display errors in the Eclipse "Problem View"
* the reponse `compileOnSaveEmitFile` should return the emited files path (js and *.js.map). In Eclipse case it's very helpful because I could refresh the files.
| Suggestion,Help Wanted,API,VS Code Tracked | low | Critical |
248,246,915 | go | all: inconsistent hyphenation | Grepping for `//.*[a-zA-Z]-\n` (see [CL 53510](https://go.dev/cl/53510)) yields some examples of phrases that are inconsistently hyphenated in the tree. Two prominent ones:
* "floating-point" vs "floating point"
* "run-time" vs "run time"
Low priority, but we should pick one and use it consistently. (And also do a more targeted grep to find other hyphenation inconsistencies.)
| Documentation,NeedsInvestigation | low | Major |
248,254,428 | opencv | Please produce current C++ NuGet package for OpenCV | To whom it may concern,
Please produce a current C++ NuGet package for OpenCV. This has become the standard way to deploy software libraries on Windows.
Unfortunately, since there is no official current package, many non-official packages have arisen, causing confusion. The two I have found to work are:
https://www.nuget.org/packages/OpenCV/2.4.11/
Which seems to be the most downloaded one and works great, but is using OpenCV 2.4.11, which is quite a bit out of date by now. The only other one I have found to work is:
https://www.nuget.org/packages/opencv3.1/1.0.0
Which also works great, but is clearly labeled not official and is using OpenCV 3.1 rather than the current 3.2, and also does not seem to work with the recently released Visual Studio 2017.
I realize this could be a substantial undertaking, however a current C++ NuGet package for OpenCV would be greatly appreciated by all Windows OpenCV users. | feature,category: build/install | low | Major |
248,255,666 | youtube-dl | Add support for “danmaku” subtitles on nicovideo.jp | ### Make sure you are using the *latest* version: run `youtube-dl --version` and ensure your version is *2017.08.06*. If it's not, read [this FAQ entry](https://github.com/rg3/youtube-dl/blob/master/README.md#how-do-i-update-youtube-dl) and update. Issues with outdated version will be rejected.
- [x] I've **verified** and **I assure** that I'm running youtube-dl **2017.08.06**
### Before submitting an *issue* make sure you have:
- [x] At least skimmed through the [README](https://github.com/rg3/youtube-dl/blob/master/README.md), **most notably** the [FAQ](https://github.com/rg3/youtube-dl#faq) and [BUGS](https://github.com/rg3/youtube-dl#bugs) sections
- [x] [Searched](https://github.com/rg3/youtube-dl/search?type=Issues) the bugtracker for similar issues including closed ones
### What is the purpose of your *issue*?
- [ ] Bug report (encountered problems with youtube-dl)
- [ ] Site support request (request for adding support for a new site)
- [x] Feature request (request for a new functionality)
- [ ] Question
- [ ] Other
---
### If the purpose of this *issue* is a *site support request* please provide all kinds of example URLs support for which should be included (replace following example URLs by **yours**):
- Single video: http://nicovideo.jp/watch/sm10215922
---
### Description of your *issue*, suggested solution and other information
Most videos on nicovideo.jp contain an XML file representing comments from users, meant to be rendered on top of the video in a similar way as subtitles.
youtube-dl should expose a way to retrieve this track, either to then [convert it to ass](https://github.com/m13253/danmaku2ass), or to (be made available to video players](https://github.com/mpv-player/mpv/issues/4722). | request | low | Critical |
248,257,179 | flutter | Customizable BottomNavigationBar height | Although it implements the material design spec, plenty of apps do make the BottomNavigationBar shorter (Youtube, Facebook, Keep, etc). It would be nice to have this functionality, although it is not critical to our app. | c: new feature,framework,f: material design,P2,team-design,triaged-design | low | Minor |
248,261,402 | go | x/tools/cmd/eg: clean imports after refactoring | tl;dr: While new imports are correctly added by the refactoring, imports that are made obsolete still exist unnecessarily (and therefore __break compilation__). We need to run something like `goimports` after performing the eg transformation.
### What version of Go are you using (`go version`)?
`go version go1.8.1 darwin/amd64`
### What operating system and processor architecture are you using (`go env`)?
darwin/amd64
### What did you do?
```bash
Leos-MBP:~ LeoRudberg$ go build golang.org/x/tools/cmd/eg
Leos-MBP:~ LeoRudberg$ go version
go version go1.8.1 darwin/amd64
Leos-MBP:~ LeoRudberg$ cat test-eg/template.go
package template
import (
"errors"
"fmt"
)
func before(s string) error { return fmt.Errorf("%s", s) }
func after(s string) error { return errors.New(s) }
Leos-MBP:~ LeoRudberg$ cat test-eg/example.go
package example
import (
"fmt"
)
func Whoops(s string) error {
return fmt.Errorf("%s", "Whoops: "+s)
}
Leos-MBP:~ LeoRudberg$ eg -t test-eg/template.go test-eg/example.go
=== test-eg/example.go (1 matches)
package example
import (
"fmt"
"errors"
)
func Whoops(s string) error {
return errors.New("Whoops: " + s)
}
```
### What did you expect to see?
The `import` section for the result should only contain `errors`.
### What did you see instead?
The `import` section contained `errors`, but also `fmt` unnecessarily.
| Tools,Refactoring | low | Critical |
248,291,973 | java-design-patterns | Robot pattern | **Description:**
The Robot design pattern is an advanced testing pattern commonly used in Android development to simplify and streamline UI testing. The core idea is to encapsulate the interactions with the UI components in a separate class, referred to as a "Robot," which then exposes high-level methods for test scripts to use. This promotes clean, readable, and maintainable test code by abstracting away the detailed interactions with the UI.
**Main elements of the pattern:**
1. **Robot Class**: This class handles UI interactions. It encapsulates the operations that can be performed on the UI, such as clicking buttons, entering text, or verifying text visibility.
2. **Test Class**: This class uses the Robot class to perform tests. It calls the high-level methods provided by the Robot class, making the test code cleaner and more readable.
3. **Fluent Interface**: The Robot methods are often designed to return the Robot itself, enabling method chaining for more concise and expressive tests.
**References:**
1. [Robot Design Pattern Overview](https://academy.realm.io/posts/kau-jake-wharton-testing-robots/)
2. [Java Design Patterns Contribution Guidelines](https://github.com/iluwatar/java-design-patterns/wiki)
**Acceptance Criteria:**
1. A Robot class is implemented encapsulating UI interactions.
2. A sample test class is provided demonstrating the use of the Robot class.
3. Documentation is updated to include a description of the Robot design pattern and usage examples.
| epic: pattern,type: feature | low | Major |
248,314,298 | opencv | How to set key frame interval | <!--
If you have a question rather than reporting a bug please go to http://answers.opencv.org where you get much faster responses.
If you need further assistance please read [How To Contribute](https://github.com/opencv/opencv/wiki/How_to_contribute).
This is a template helping you to create an issue which can be processed as quickly as possible. This is the bug reporting section for the OpenCV library.
-->
##### System information (version)
<!-- Example
- OpenCV => 3.1
- Operating System / Platform => Windows 64 Bit
- Compiler => Visual Studio 2015
-->
- OpenCV => 3.1
- Operating System / Platform => mac
- Compiler => gcc+
##### Detailed description
<!-- your description -->
##### Steps to reproduce
<!-- to add code example fence it with triple backticks and optional file extension
```.cpp
// C++ code example
```
or attach as .txt or .zip file
-->
I use some picture to generate a video, and i want to set keyframe just for some reason. But i can not find any methods to set or change keyframe when i generate the video. So is there any way to do that, or just maybe impossible? | feature,category: videoio | low | Critical |
248,325,550 | pytorch | DataParallel is not compatible with pack_padded_sequence | If the model has `pack_padded_sequence`, then with `DataParallel ` module it will output error `"ValueError: lengths array has incorrect size"` | awaiting response (this tag is deprecated),triaged,module: data parallel | low | Critical |
248,329,188 | tensorflow | Numerical instability of gradient calculation of tf.norm (nan at 0, inf for small values) | ### System information
- **Have I written custom code (as opposed to using a stock example script provided in TensorFlow)**: Yes see below
- **OS Platform and Distribution (e.g., Linux Ubuntu 16.04)**: Mac OS X 10.11.6
- **TensorFlow installed from (source or binary)**: binary
- **TensorFlow version (use command below)**: #v1.2.0-5-g435cdfc 1.2.1
- **Python version**: 3.6
- **Bazel version (if compiling from source)**:
- **CUDA/cuDNN version**: On CPU
- **GPU model and memory**:
- **Exact command to reproduce**: tf.norm at [0,0] see below for code
```
import numpy as np
import tensorflow as tf
print(tf.GIT_VERSION, " ", tf.VERSION) #v1.2.0-5-g435cdfc 1.2.1
X = tf.placeholder(tf.float32, shape=(4,None))
Z = tf.norm(X, ord='euclidean', axis=1, name='logit')
var_grad = tf.gradients(Z, [X])
with tf.Session() as sess:
X_ = np.array([
[1], # Grad OK
[0], # Grad NaN
[1e-16], # Grad OK
[1e-19] #Grad Inf
], dtype=np.float32)
sess.run(tf.global_variables_initializer())
print(sess.run((Z, var_grad), feed_dict={X: X_}))
# Result:
#(array([9.99999940e-01, 0.00000000e+00, 9.99999951e-17,
# 0.00000000e+00], dtype=float32), [array([[1.00000012],
# [nan],
# [1.],
# [inf]], dtype=float32)])
```
### Describe the problem
`nan` is calculated for the gradient of `tf.norm` at zero values. For extremely small values `inf` is calculated. Note that the exact result should be 1 in all cases above.
Above is a minimal example to reproduce it. The problem occurred in a real world scenario, when implementing a custom loss function (the entropy in https://arxiv.org/abs/1611.01449) and two embeddings where too close to each other (distance practically 0).
### Source code / logs
See above
#### Output of logfile
```
== cat /etc/issue ===============================================
Darwin Olivers-MBP-5.fritz.box 15.6.0 Darwin Kernel Version 15.6.0: Tue Apr 11 16:00:51 PDT 2017; root:xnu-3248.60.11.5.3~1/RELEASE_X86_64 x86_64
Mac OS X 10.11.6
== are we in docker ========================================= echo == are we in docker ====================================num echo == are we in docker ========================================= ec== echo == are we in docker =======================================c++ --version
== uname -a =====================================================
Darwin Olivers-MBP-5.fritz.box 15.6.0 Darwin Kernel Version 15.6.0: Tue Apr 11 16:00:51 PDT 2017; root:xnu-3248.60.11.5.3~1/RELEASE_X86_64 x86_64
== check pips ===================================================
numpy (1.13.0)
protobuf (3.3.0)
tensorflow (1.2.1)
== check for virtualenv ============== echo == check for virtualenv =====on_b echo == check fo sys echo == check for virtualenv ============== echo == check for virtualenv ============================================
== cat /etc/issue ===============================================
Darwin Olivers-MBP-5.fritz.box 15.6.0 Darwin Kernel Version 15.6.0: Tue Apr 11 16:00:51 PDT 2017; root:xnu-3248.60.11.5.3~1/RELEASE_X86_64 x86_64
Mac OS X 10.11.6
== are we in docker =============================================
No
== compiler =====================================================
Apple LLVM version 7.3.0 (clang-703.0.31)
Target: x86_64-apple-darwin15.6.0
Thread model: posix
InstalledDir: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin
== uname -a =====================================================
Darwin Olivers-MBP-5.fritz.box 15.6.0 Darwin Kernel Version 15.6.0: Tue Apr 11 16:00:51 PDT 2017; root:xnu-3248.60.11.5.3~1/RELEASE_X86_64 x86_64
== check pips ===================================================
numpy (1.13.0)
protobuf (3.3.0)
tensorflow (1.2.1)
== check for virtualenv =========================================
True
== tensorflow import ============================================
tf.VERSION = 1.2.1
tf.GIT_VERSION = v1.2.0-5-g435cdfc
tf.COMPILER_VERSION = v1.2.0-5-g435cdfc
Sanity check: array([1], dtype=int32)
== env ==========================================================
LD_LIBRARY_PATH is unset
DYLD_LIBRARY_PATH is unset
== nvidia-smi ===================================================
tf_env_collect.sh.txt: line 105: nvidia-smi: command not found
== cuda libs ===================================================
``` | stat:contribution welcome | medium | Critical |
248,388,012 | nvm | I can't use nvm install node, help me | I can't use nvm install node, help me
error :
```sh
Downloading and installing node v8.2.1...
Local cache found: $NVM_DIR/.cache/bin/node-v8.2.1-linux-x64/node-v8.2.1-linux-x64.tar.xz
Computing checksum with sha256sum
Checksums do not match: 'f74e70e2c3c6d96e887286e605480f64487cd543f4a5988b29f491b32f1256c8' found, 'abcddeb95cc4465953b1edb0922d20e9b0b3de83688fc8150b863117032a978a' expected.
Checksum check failed!
Removing the broken local cache...
Downloading https://npm.taobao.org/mirrors/node/v8.2.1/node-v8.2.1-linux-x64.tar.xz...
######################################################################## 100.0%
Computing checksum with sha256sum
Checksums do not match: 'f74e70e2c3c6d96e887286e605480f64487cd543f4a5988b29f491b32f1256c8' found, 'abcddeb95cc4465953b1edb0922d20e9b0b3de83688fc8150b863117032a978a' expected.
xz: (stdin): File format not recognized
tar: Child returned status 1
tar: Error is not recoverable: exiting now
Binary download failed, trying source.
Additional options while compiling: 8
Local cache found: $NVM_DIR/.cache/src/node-v8.2.1/node-v8.2.1.tar.xz
Computing checksum with sha256sum
Checksums do not match: '9ceab53e0b7dd9771d7ea799d8599d2f1711fe39230692651ec99190d9f8e956' found, '02c46d8914540eea73d0ad33bf9f371a28aa0dc8c5d740948491fef044ad8c8b' expected.
Checksum check failed!
Removing the broken local cache...
Downloading https://npm.taobao.org/mirrors/node/v8.2.1/node-v8.2.1.tar.xz...
######################################################################## 100.0%
Computing checksum with sha256sum
Checksums do not match: '9ceab53e0b7dd9771d7ea799d8599d2f1711fe39230692651ec99190d9f8e956' found, '02c46d8914540eea73d0ad33bf9f371a28aa0dc8c5d740948491fef044ad8c8b' expected.
xz: (stdin): File format not recognized
tar: Child returned status 1
tar: Error is not recoverable: exiting now
nvm: install v8.2.1 failed!
``` | installing node,needs followup | low | Critical |
248,422,175 | vscode | Provide an API to show hover-like tooltip | Please provide an API to trigger a hover-like tooltip.
Use case:
In my language extension, I want to let users know the type of the expression by pressing a combination of keys. This is similar to what hover does but:
- It is triggered by pressing a shortcut
- When the same shortcut is pressed again I want to widen the scope of the expression and show the type of a "bigger" expression, etc.
Being able to show custom tooltips is also useful in different scenarios for providing extra information about the code.
- VSCode Version: 1.14.2
- OS Version: MacOS | feature-request,editor-api | medium | Critical |
248,537,289 | godot | Scripts not added retroactively to instanced inherited scenes open in editor | _**bugsquad edit**_: reproduction steps which were used to confirm the issue are here: https://github.com/godotengine/godot/issues/10156#issuecomment-320997658
-----------
**Operating system or device - Godot version:**
OS: Windows
Godot Version: 3.0 Alpha Build 1
**Issue description:**
I have found a problem where when I add a script to a scene, all nodes that instance that scene don't get the script.
**Steps to reproduce:**
1. Make a scene that you will instance.
2. Instance that scene into the scene your game will run.
3. Add a script to the original scene. | bug,topic:core,confirmed | low | Critical |
248,574,665 | go | x/net/http2: bogus greeting when providing TLSClientConfig | ### What version of Go are you using (`go version`)?
go version go1.9beta2 darwin/amd64
### What operating system and processor architecture are you using (`go env`)?
```
GOARCH="amd64"
GOBIN=""
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
GOPATH="/Users/jackson/"
GORACE=""
GOROOT="/Users/jackson/sdk/go1.9beta2"
GOTOOLDIR="/Users/jackson/sdk/go1.9beta2/pkg/tool/darwin_amd64"
GCCGO="gccgo"
CC="clang"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/df/tll2ynl125z01jxszx2fq2nw0000gn/T/go-build293310413=/tmp/go-build -gno-record-gcc-switches -fno-common"
CXX="clang++"
CGO_ENABLED="1"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config
```
### What did you do?
Download https://gist.github.com/jbowens/3e1f7443d6cb1bf8071f4aea2397c4b1
go1.9beta2 run main.go
### What did you expect to see?
The program should exit without panicking.
### What did you see instead?
```
2017/08/07 18:17:01 http2: server: error reading preface from client [::1]:59163: bogus greeting "POST / HTTP/1.1\r\nHost: l"
panic: Post https://localhost:8080/: net/http: HTTP/1.x transport connection broken: malformed HTTP response "\x00\x00\x18\x04\x00\x00\x00\x00\x00\x00\x05\x00\x10\x00\x00\x00\x03\x00\x00\x00\xfa\x00\x06\x00\x10\x01@\x00\x04\x00\x10\x00\x00"
```
From my understanding, the presence of TLSClientConfig should cause the client [to not use http2](https://golang.org/src/net/http/transport.go#L213), but it appears to negotiate to http2 anyways. | NeedsFix | low | Critical |
248,601,852 | thefuck | Can we make thefuck learn alias + function in bash? | i have this function in .bash_profile
```
quickpush() {
git add .
git commit -m "$@"
echo "🍏 commit message: [$@]"
git push
echo 🚀 quick push success... or not.
}
```
when i use it in terminal (mac)
```
$: quickpus hello world // => suggest quickpush hello world
```
can we auto suggest like that for all function in bash or need modify fuck for each custom function? | enhancement,help wanted,hacktoberfest,HackIllinois | low | Minor |
248,615,229 | rust | Can show operands at runtime when 'attempt to multiply with overflow' panic ? | Is it possible to show the two operands at runtime when this panic occurs ?
thread 'main' panicked at 'attempt to multiply with overflow', src/main.rs:7
So maybe we can see `2*122` in the panic message?
[example code](https://play.rust-lang.org/?gist=3d3739913cd5cbbff6159d1b9687427f&version=stable)
[code with backtrace](https://play.rust-lang.org/?gist=50435a8845bd16bd4bf3a4995ddaff81&version=nightly)
<details><summary>output</summary>
```rust
Compiling playground v0.0.1 (file:///playground)
Finished dev [unoptimized + debuginfo] target(s) in 0.62 secs
Running `target/debug/playground`
thread 'main' panicked at 'attempt to multiply with overflow', src/main.rs:9:20
stack backtrace:
0: std::sys::imp::backtrace::tracing::imp::unwind_backtrace
at /checkout/src/libstd/sys/unix/backtrace/tracing/gcc_s.rs:49
1: std::sys_common::backtrace::_print
at /checkout/src/libstd/sys_common/backtrace.rs:71
2: std::panicking::default_hook::{{closure}}
at /checkout/src/libstd/sys_common/backtrace.rs:60
at /checkout/src/libstd/panicking.rs:380
3: std::panicking::default_hook
at /checkout/src/libstd/panicking.rs:396
4: std::panicking::rust_panic_with_hook
at /checkout/src/libstd/panicking.rs:610
5: std::panicking::begin_panic
at /checkout/src/libstd/panicking.rs:571
6: std::panicking::begin_panic_fmt
at /checkout/src/libstd/panicking.rs:521
7: rust_begin_unwind
at /checkout/src/libstd/panicking.rs:497
8: core::panicking::panic_fmt
at /checkout/src/libcore/panicking.rs:71
9: core::panicking::panic
at /checkout/src/libcore/panicking.rs:51
10: playground::main
at src/main.rs:9
11: __rust_maybe_catch_panic
at /checkout/src/libpanic_unwind/lib.rs:98
12: std::rt::lang_start
at /checkout/src/libstd/panicking.rs:458
at /checkout/src/libstd/panic.rs:361
at /checkout/src/libstd/rt.rs:61
13: main
14: __libc_start_main
15: _start
```
</details>
----------
**EDIT:** what I tried and had no effect whatsoever:
```patch
diff --git a/src/librustc_const_math/int.rs b/src/librustc_const_math/int.rs
index 65471416e8..1c05352aec 100644
--- a/src/librustc_const_math/int.rs
+++ b/src/librustc_const_math/int.rs
@@ -329,7 +329,10 @@ impl ::std::fmt::Display for ConstInt {
macro_rules! overflowing {
($e:expr, $err:expr) => {{
if $e.1 {
- return Err(Overflow($err));
+ return {
+ eprintln!("!!!moo3:{:?}!{:?}!",$e,$err);
+ Err(Overflow($err))
+ }
} else {
$e.0
}
@@ -341,6 +344,7 @@ macro_rules! impl_binop {
impl ::std::ops::$op for ConstInt {
type Output = Result<Self, ConstMathErr>;
fn $func(self, rhs: Self) -> Result<Self, ConstMathErr> {
+ eprintln!("!!!moo4:{:?}!{:?}!",self,rhs);
match (self, rhs) {
(I8(a), I8(b)) => a.$checked_func(b).map(I8),
(I16(a), I16(b)) => a.$checked_func(b).map(I16),
@@ -428,7 +432,10 @@ fn check_division(
(Usize(_), Usize(Us32(0))) => Err(zerr),
(Usize(_), Usize(Us64(0))) => Err(zerr),
- (I8(::std::i8::MIN), I8(-1)) => Err(Overflow(op)),
+ (I8(::std::i8::MIN), I8(-1)) => {
+ eprintln!("!!!moo2{:?}!",op);
+ Err(Overflow(op))
+ },
(I16(::std::i16::MIN), I16(-1)) => Err(Overflow(op)),
(I32(::std::i32::MIN), I32(-1)) => Err(Overflow(op)),
(I64(::std::i64::MIN), I64(-1)) => Err(Overflow(op)),
diff --git a/src/librustc_mir/build/expr/as_rvalue.rs b/src/librustc_mir/build/expr/as_rvalue.rs
index 2512291f1a..f8fd8315c5 100644
--- a/src/librustc_mir/build/expr/as_rvalue.rs
+++ b/src/librustc_mir/build/expr/as_rvalue.rs
@@ -285,6 +285,7 @@ impl<'a, 'gcx, 'tcx> Builder<'a, 'gcx, 'tcx> {
bug!("MIR build_binary_op: {:?} is not checkable", op)
}
});
+ eprintln!("!!!moo{:?}!",err);
block = self.assert(block, Operand::Consume(of), false,
AssertMessage::Math(err), span);
diff --git a/src/librustc_trans/mir/constant.rs b/src/librustc_trans/mir/constant.rs
index 53469689bc..783aea003d 100644
--- a/src/librustc_trans/mir/constant.rs
+++ b/src/librustc_trans/mir/constant.rs
@@ -932,6 +932,7 @@ pub fn const_scalar_checked_binop<'a, 'tcx>(tcx: TyCtxt<'a, 'tcx, 'tcx>,
bug!("Operator `{:?}` is not a checkable operator", op)
}
};
+ eprintln!("!!!moo5:{:?}!", result);
let of = match result {
Ok(_) => false,
``` | T-lang,T-libs-api,C-feature-accepted | low | Critical |
248,663,398 | vscode | SCM - Support altCommand for SCM resources | Feature suggestion. Implement some keyboard button+Click combination on a file in Git Sidebar to `Open File` (not `Open Change`, which is being used by default by just clicking on a file). For example: Ctrl+Click (Command+Click), Option+Click (Alt+Click) or something like that.
Make a life a bit easier for a user when he tries to open files, which has been already edited by him, for further edition. :) | help wanted,feature-request,scm | low | Major |
248,755,857 | angular | Http ResponseType cannot be set | ## I'm submitting a...
<!-- Check one of the following options with "x" -->
<pre><code>
[ ] Regression (a behavior that used to work and stopped working in a new release)
[x] Bug report <!-- Please search GitHub for a similar issue or PR before submitting -->
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question
</code></pre>
## Current behavior
Response type cannot be set for HttpClient methods.
```
const options = {headers: headers, params: params, responseType: 'text'};
return this.http.get(url, options).share();
```
Would show an error
```
Types of property 'responseType' are incompatible.
Type 'string' is not assignable to type '"json"'.
```
## Expected behavior
It is expected that the response type should be exported like
```
export type ResponseType = 'arraybuffer' | 'blob' | 'json' | 'text';;
```
And one would be able to set it using this type. Otherwise the type cannot be changed.
## Environment
Angular version: 4.1.1 and still there in 5.0.0-beta.2
as seen here: https://github.com/angular/angular/blob/master/packages/common/http/src/client.ts | feature,area: common/http,feature: under consideration | high | Critical |
248,796,599 | opencv | Use imported targets for linking to CUDA | In https://github.com/opencv/opencv/pull/3893 CUDA targets where nicely marked as imported targets, but this change seems to be lost again over time. To repeat from original pull request moving to imported targets has two major advantages:
* It removes the need to use link_directories, which doesn't guarantee that the libraries from the supplied directory will be used (there may be libraries with the same names earlier in the search path).
* It removes the need to put -L entries into OPENCV_LINKER_LIBS. This variable is used with target_link_libraries, where such entries are treated as linker flags, so doing this is unportable. I remove the support for -L entries from OpenCVGenPkgconfig.cmake, as well, to discourage adding them in the future.
Would it be an option to get this applied again for newer OpenCV versions? If yes I could prepare a pull request accordingly. | feature,category: build/install,category: gpu/cuda (contrib) | low | Minor |
248,878,972 | opencv | Nested parallel_for_ no longer parallelized | ##### System information (version)
<!-- Example
- OpenCV => 3.1
- Operating System / Platform => Windows 64 Bit
- Compiler => Visual Studio 2015
-->
- OpenCV => 3.3.0
- Operating System / Platform => All
- Compiler => All
##### Detailed description
Commit 006966e6295f44e48ade066d4eb56826439680fb breaks nesting of parallell_for_
If you have parallel loops nested within others then parallelization is now disabled for the nested regions.
##### Steps to reproduce
1. Search Internet for your preferred nested parallel_for_ example. There are plenty.
2. Put a breakpoint on the nested loop
Results:
1. The range parameter provided to the nested loop will always be for the full range of the loop
2. CPU utilization is much lower than earlier versions of OpenCV. Ie. slower performance | category: core,RFC | low | Major |
248,900,739 | godot | Instances of inner class can't be load back with ConfigFile | **Operating system or device - Godot version:**
Godot 3.0 alpha1 on Windows 10
**Issue description:**
<!-- What happened, and what was expected. -->
There is a class named `MyClass.gd`. Instance of this class can be save and load back with `ConfigFile` but something wrong with the member `subObj ` which is an Instance of the inner class `SubClass`.
```gdscript
var name = "boy"
var age = 2
var subObj = SubClass.new()
class SubClass:
var sex = "male"
```
**Steps to reproduce:**
1. Download the project below
2. Click "Save" button to save an instance of `MyClass` with `ConfigFile`
3. Click "Load" button to load the saved instance back from the saved file.
**Link to minimal example project:**
[ConfigFileBug.zip](https://github.com/godotengine/godot/files/1210159/ConfigFileBug.zip)
| bug,topic:core,confirmed | low | Critical |
249,046,169 | neovim | API: timeout for blocking requests | <!-- Before reporting: search existing issues and check the FAQ. -->
- `nvim --version`: 0.2.0
- Vim (version: ) behaves differently? N/A
- Operating system/version: macOS Sierra 10.12.1
- Terminal name/version: a remote UI talking to a --headless nvim through the Nvim API
- `$TERM`: N/A
### Steps to reproduce using `nvim -u NORC`
Run:
NVIM_LISTEN_ADDRESS=... nvim -u NORC --headless
Connect to that address, and issue an API call:
nvim_command("edit README.md")
Kill the nvim process and restart it.
Reconnect and issue the same command.
Observe that nvim prints out a swap file recovery dialog with a prompt to nvim's stdout:
```
Found a swap file by the name ...
...
[O]pen Read-Only, (E)dit anyway, (R)ecover, (D)elete it, (Q)uit, (A)bort:
```
**Note**: Changing `nvim_command` to `nvim_command_output` exposes the same behaviour.
### Actual behaviour
The API call blocks and never returns, neither success nor failure.
Moreover, no API calls work from this point.
For example, calling `nvim_command("recover")` or `nvim_command("help recovery")` blocks and doesn't return any result either, and has no effect on nvim.
### Expected behaviour
`nvim_command` must not block. It should return immediately an error reply explaining that a recovery decision is required. Until the decision is taken, other commands like `nvim_command("help recovery")` should be processed normally.
| enhancement,api,channels-rpc | low | Critical |
249,063,481 | rust | Static library linkage error | This issue was previously submitted to https://github.com/rust-lang/cargo/issues/4351, which contains the description and the reproduction steps.
Basically I suspect that rustc is not passing the static libraries in the correct order to the linker. | A-linkage,C-bug | low | Critical |
249,063,486 | kubernetes | Clear restart counter | /kind feature
/sig feature-requests
**What happened**:
We use the restart counter (and his frequency) to monitor our apps health
**What you expected to happen**:
It we be helpful to have an option to clear the counter and the history of the pod without deleting it.
**Environment**:
- Kubernetes version (use `kubectl version`): 1.7.2
- Cloud provider or hardware configuration**: hw
- OS (e.g. from /etc/os-release): Centos7
- Kernel (e.g. `uname -a`):
- Install tools:
- Others:
| kind/documentation,sig/node,kind/feature,lifecycle/frozen,triage/needs-information,needs-triage | high | Critical |
249,194,782 | TypeScript | Allow narrowing generic type to single element of union type | It is a fairly common pattern to create a set of generic components, and then to use the generic component type within the system. Currently, typescript has an issue handling cases where some values of a generic component depend on others.
**TypeScript Version:** 2.4.0 / nightly (2.5.0-dev.201xxxxx)
2.4
**Code**
```ts
let index = {
a: {
arg: 'a',
fn: (a: string) => {a.toUpperCase()}
},
b: {
arg: 1,
fn: (b: number) => {b + 1}
}
}
let runFn= <K extends keyof (typeof index)>(key: K) => {
let i = index[key]
let arg = i.arg
let fn = i.fn
fn(arg) // Error: compiler doesn't understand that fn and arg will match
}
```
**Expected behavior:**
No error, since we know that `arg` and `fn` are pulled off of the same map entry.
**Actual behavior:**
`Error: cannot invoke expression whose type lacks a call signature` | Suggestion,Awaiting More Feedback | low | Critical |
249,216,779 | rust | Tracking issue for `#[doc(cfg(…))]`, `#[doc(cfg_hide(…))]` and `doc_auto_cfg` | This is a tracking issue for the `#[doc(cfg(…))]` attribute (feature: `doc_cfg`) introduced in #43348 and `#[doc(cfg_hide(…))]` (feature: `doc_cfg_hide`) attribute introduced in #89596, along with the `doc_auto_cfg` feature introduced in https://github.com/rust-lang/rust/pull/90502.
**Steps:**
- [x] Implement: #43348
- [x] ~~Fix syntax mismatches: #84437~~ (fixed in #84442)
- [x] Adjust documentation ([see instructions on forge][doc-guide]) (https://github.com/rust-lang/rust/pull/92818)
- [ ] RFC (rust-lang/rfcs#3631)
- [ ] Stabilization PR ([see instructions on forge][stabilization-guide]): #79263
[stabilization-guide]: https://forge.rust-lang.org/stabilization-guide.html
[doc-guide]: https://forge.rust-lang.org/stabilization-guide.html#updating-documentation
(cc #1998) | T-rustdoc,B-unstable,C-tracking-issue,F-doc_cfg,F-doc_auto_cfg | high | Critical |
249,226,154 | go | cmd/compile: gdb 8 on windows crashes reading Go binary | ### What version of Go are you using (`go version`)?
```
> go version
go version go1.9rc2 windows/amd64
```
### What operating system and processor architecture are you using (`go env`)?
```
> go env
set GOARCH=amd64
set GOBIN=
set GOEXE=.exe
set GOHOSTARCH=amd64
set GOHOSTOS=windows
set GOOS=windows
set GOPATH=C:\Users\kjk\src\go
set GORACE=
set GOROOT=C:\Go
set GOTOOLDIR=C:\Go\pkg\tool\windows_amd64
set GCCGO=gccgo
set CC=gcc
set GOGCCFLAGS=-m64 -mthreads -fmessage-length=0
set CXX=g++
set CGO_ENABLED=1
set CGO_CFLAGS=-g -O2
set CGO_CPPFLAGS=
set CGO_CXXFLAGS=-g -O2
set CGO_FFLAGS=-g -O2
set CGO_LDFLAGS=-g -O2
set PKG_CONFIG=pkg-config
```
### What did you do?
I'm trying to gather more information on #20975 which involves running the executable on windows under a debugger that understands dwarf debug info (because neither msvc nor windbg do).
I tried:
* clone repro program https://github.com/kjk/go20975 and run `build.ps1` to build it
* download gdb from `https://nuwen.net/mingw.html` and unpack under `c:\`
* run `C:\MinGW\bin\gdb.exe .\go20975.exe` to run under dbg
* enter `https://vox.com` in text box
### What did you expect to see?
When crash happens, I expected to get a human-readable callstack.
### What did you see instead?
```
[New Thread 2176.0xc90]
fatal: morestack on g0
../../src/gdb/buildsym.c:1773: internal-error: void buildsym_init(): Assertion `free_pendings == NULL' failed.
A problem internal to GDB has been detected,
further debugging may prove unreliable.
```
The crash happened in the program but it also crashed gdb.
It seems that DWARF information created by Go compiler breaks gdb.
```
PS C:\Users\kjk\src\go\src\github.com\kjk\go20975> C:\MinGW\bin\gdb.exe --version
GNU gdb (GDB) 8.0
```
| OS-Windows,NeedsInvestigation | medium | Critical |
249,260,263 | vue | Line numbers for errors in the html parser | ### What problem does this feature solve?
Errors raised by the html parser (`options.warn` in the code) don't register the location of the error.
With the location it will be much easier to debug.
For example if I forget to close an HTML tag, the compiler will complain and tell me the name of the tag. However I will have no idea where the opening tag is located. For moderately big files it's quite impractical.
### What does the proposed API look like?
In `parseHTML` we could add a property in options that will include the line at which the HTML is included in the `.vue` file. We can use this to offset the location before printing it.
As for getting the locations themselves I have no idea how to proceed. If someone can give me some pointers I may submit a pull request.
<!-- generated by vue-issues. DO NOT REMOVE --> | feature request,improvement,has PR | low | Critical |
249,305,727 | angular | Error message for missing `*directives` is wrong and confusing | <!--
PLEASE HELP US PROCESS GITHUB ISSUES FASTER BY PROVIDING THE FOLLOWING INFORMATION.
ISSUES MISSING IMPORTANT INFORMATION MAY BE CLOSED WITHOUT INVESTIGATION.
-->
## I'm submitting a...
<!-- Check one of the following options with "x" -->
<pre><code>
[ ] Regression (a behavior that used to work and stopped working in a new release)
[x] Bug report <!-- Please search GitHub for a similar issue or PR before submitting -->
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question
</code></pre>
## Current behavior
<!-- Describe how the issue manifests. -->
When i use **NO_ERRORS_SCHEMA** in my unit tests with structural directives which have a property binding:
```html
<div *someDirective="'some-value'"></div>
```
my tests don't work and i get an error:
but when i use structural directive without property binding:
```html
<div *someDirective></div>
```
it works.
## Expected behavior
<!-- Describe what the desired behavior would be. -->
I expect that behavior for structural directive with property binding when NO_ERRORS_SCHEMA configured will work the same as for the one without binding.
## Minimal reproduction of the problem with instructions
<!--
For bug reports please provide the *STEPS TO REPRODUCE* and if possible a *MINIMAL DEMO* of the problem via
https://plnkr.co or similar (you can use this template as a starting point: http://plnkr.co/edit/tpl:AvJOMERrnz94ekVua0u5).
-->
Here is [plnkr demo](https://plnkr.co/Dk9O9jXszf6Zd813vdEU?p=preview)
## What is the motivation / use case for changing the behavior?
<!-- Describe the motivation or the concrete use case. -->
I'm trying to unit test my component that uses custom structural directive. And i want to ignore all not required directives in my test case, rather than trying to mock them out. | type: bug/fix,freq1: low,area: compiler,core: ng-template and *microsyntax,core: directive matching,P4,compiler: template type-checking | low | Critical |
249,310,576 | go | x/tools/cmd/stringer: cannot import vendored dependencies | Please answer these questions before submitting your issue. Thanks!
### What version of Go are you using (`go version`)?
go version go1.8.3 linux/amd64
### What operating system and processor architecture are you using (`go env`)?
Ubuntu Linux, amd64
### What did you do?
Attempted to run golang.org/x/tools/cmd/stringer on package importing vendored dependencies
### What did you expect to see?
The tool work as expected
### What did you see instead?
While 'go build' and all other tools seem fine with depdencies vendored in $GOPATH/src/vendor, stringer fails with import errors:
```
$ go build plinth/auth
$ go get golang.org/x/tools/cmd/stringer
$ go generate plinth/auth
stringer: checking package: auth.go:8:2: could not import golang.org/x/net/context (can't find import: vendor/golang.org/x/net/context)
src/plinth/auth/auth.go:37: running "stringer": exit status 1
$ stringer -type Role $GOPATH/src/plinth/auth
stringer: checking package: [...]/src/plinth/auth/auth.go:8:2: could not import golang.org/x/net/context (can't find import: vendor/golang.org/x/net/context)
$ ls $GOPATH/src/vendor/golang.org/x/net/context
context.go context_test.go ctxhttp go17.go go19.go pre_go17.go pre_go19.go withtimeout_test.go
```
| Tools | low | Critical |
249,362,236 | go | net/http: ResponseWriter.Write does not error after WriteTimeout nor is ErrorLog used | Please answer these questions before submitting your issue. Thanks!
### What version of Go are you using (`go version`)?
```
go version go1.8.3 darwin/amd64
```
### What operating system and processor architecture are you using (`go env`)?
```
GOARCH="amd64"
GOBIN=""
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
GOPATH="/Users/uwe/dev/go"
GORACE=""
GOROOT="/usr/local/Cellar/go/1.8.3/libexec"
GOTOOLDIR="/usr/local/Cellar/go/1.8.3/libexec/pkg/tool/darwin_amd64"
GCCGO="gccgo"
CC="clang"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/p2/0p6x8w350vqgpvfby6wnxnhc0000gn/T/go-build935868292=/tmp/go-build -gno-record-gcc-switches -fno-common"
CXX="clang++"
CGO_ENABLED="1"
PKG_CONFIG="pkg-config"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
```
### What did you do?
https://play.golang.org/p/pwjZmMKleR
Create a HTTP server with a `WriteTimeout = 1 * time.Second` and a `HTTPHandler` with an artificial `time.Sleep(2 * time.Second)` and then writing out some bytes. Then start the server and run a request against this handler.
### What did you expect to see?
Writing a response after hitting `WriteTimeout` should at least do one out of the two options:
1. Return an error for `n, err := w.Write()`
2. Log a message to `http.Server.ErrorLog`
(1) would indicate that no more bytes can be written, e.g. because the connection was closed.
(2) would be similar to `w.conn.server.logf("http: multiple response.WriteHeader calls")`, e.g. `w.conn.server.logf("http: write attempt after write timeout")`.
### What did you see instead?
Neither (1) nor (2) happened.
This was confusing as I saw in my http logging middleware that response bytes have been written, but I did not understand to where/which connection; which was hard to debug.
While trying to understand how `WriteTimeout` works it seems that the http server's `ResponseWriter` is not aware of the consequences. But I would like to discuss if there are options to improve the situation/inform the user.
An example of the observed consequences with `WriteTimeout` set to `3 * time.Second` on e.g. Heroku:
```
Aug 07 12:16:48 {"level":"info","ts":1502108208.0430696,"caller":"middleware/logger.go:91","msg":"Outgoing response","request_id":"a8fe82a0-c212-4527-9cae-06e38cf46d49","status":200,"latency":9.043189693,"bytes_out":97}
Aug 07 12:16:48 heroku/router: at=error code=H13 desc="Connection closed without response" method=GET path="/foo" host=bar request_id=a8fe82a0-c212-4527-9cae-06e38cf46d49 fwd="54.216.3.69" dyno=web.1 connect=0ms service=9044ms status=503 bytes=0 protocol=https
``` | NeedsFix | medium | Critical |
249,363,806 | godot | Manually Resizing Viewport Render makes a Flickering Godot Splashscreen Background | **Operating system or device - Godot version:**
Godot 2.1.3 stable
Windows 7 service pack 1
**Issue description:**
i wrote a script that will resize my Base Game Display Size Pixel Perfectly to a Screen/Window Size by having a Resize Value of Integers.
in Project Settings Display
* Game Display 144x216
* Test Screen 500x500
* set Stretch mode to Viewport
the main function that resize the render is the Viewport.set_render_target_to_screen_rect()
if you hit play it will display the sprite pixel perfectly resized to the given Window/fullscreen size. but there is a flickering Godot Splashscreen behind it. but my friend who uses Linux dosent have the flickering
**Steps to reproduce:**
Open the Project in a Windows OS and hit play.
**Link to minimal example project:**
http://www.mediafire.com/file/88hes1vm3cb902a/Test.rar
here is the Test Project
| bug,topic:rendering,confirmed | low | Major |
249,515,034 | go | cmd/compile: improve codegen for nested if statements | As observed in CL 54651, these two semantically equivalent bits of code do not always compile equivalently:
```go
if a {
if b {
// ...
}
}
```
```go
if a && b {
// ...
}
```
This issue is to investigate why, and if the latter is systematically better, consider improving the former. Note that 'if a && b' gets special handling at Node -> SSA time; phiopt.go does some further related cleanup, but perhaps not enough.
cc @randall77 | Performance,compiler/runtime | low | Minor |
249,518,482 | vscode | [GRIPE] "editor.mouseWheelScrollSensitivity" setting is not respected while making a text selection | the editor scrolls insanely fast while selecting large blocks of text which is quite unwieldy, so i tried to see if i could affect this behavior with the setting `editor.mouseWheelScrollSensitivity`, but it had no effect. please make a setting to control the sensitivity of scrolling while selecting text. | feature-request,editor-core | low | Minor |
249,532,573 | go | x/mobile: need API to hide Android status bar on native app | ### What version of Go are you using (`go version`)?
$ go version
go version go1.9rc2 linux/amd64
### What operating system and processor architecture are you using (`go env`)?
$ go env
GOARCH="amd64"
GOBIN=""
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/home/everton/go"
GORACE=""
GOROOT="/usr/local/go1.9rc2.linux-amd64"
GOTOOLDIR="/usr/local/go1.9rc2.linux-amd64/pkg/tool/linux_amd64"
GCCGO="gccgo"
CC="gcc"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build881532661=/tmp/go-build -gno-record-gcc-switches"
CXX="g++"
CGO_ENABLED="1"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
### What did you do?
Wrote basic Android native game using gomobile.
Need full screen support, but couldn't find API to hide status bar.
### What did you expect to see?
Full screen available for Android native game written with gomobile.
### What did you see instead?
The Android status bar.
| NeedsFix,mobile | low | Critical |
249,552,074 | opencv | Set manually the destination image size of LinearPolar / LogPolar | ##### Detailed description
The methods `linearPolar` and `logPolar` return the image of the same size as the source.
I consider this behavior strange since the dimensions of the result image are ρ and φ and have nothing to do with the original image width and height.
Ideally, the radial and angular dimensions should be set manually with some reasonable defaults depending on the _maxRadius_ parameter (say, _maxRadius_ × _π∙maxRadius_ to match the average resolution of the source for LinearPolar). I don’t think, however, that changing the default behavior (and thus breaking the compatibility) is the right thing to do.
So, is it possible to just add the method overloads with the destination image size as an argument to have the ability to set it manually? | feature,category: imgproc | low | Major |
249,552,206 | go | encoding/xml: cannot marshal self-closing tag | Please answer these questions before submitting your issue. Thanks!
### What version of Go are you using (`go version`)?
go version go1.8.3 darwin/amd64
### What operating system and processor architecture are you using (`go env`)?
GOARCH="amd64"
GOBIN=""
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
GOPATH="/Users/xxx/.go:/Users/xxx/workspace/goproject"
GORACE=""
GOROOT="/usr/local/Cellar/go/1.8.3/libexec"
GOTOOLDIR="/usr/local/Cellar/go/1.8.3/libexec/pkg/tool/darwin_amd64"
GCCGO="gccgo"
CC="clang"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/53/r61bh2fj1hg9n0w03fs__7kc0000gn/T/go-build440341166=/tmp/go-build -gno-record-gcc-switches -fno-common"
CXX="clang++"
CGO_ENABLED="1"
PKG_CONFIG="pkg-config"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
### What did you do?
I want to marshal a xml struct which has a self-closing tag field. After looking up in golang doc, there isn't an official support. In [google group](https://groups.google.com/forum/#!topic/golang-nuts/guG6iOCRu08) they use string.Replace, it's ugly. It seems we could write marshal func for the custom struct, by i'm willing to see an official support like
```
type Person struct {
XMLName xml.Name `xml:"person"`
Id int `xml:"id,attr"`
FirstName string `xml:"name>first"`
LastName string `xml:"name>last"`
Age int `xml:"age"`
Height float32 `xml:"height,omitempty"`
Married bool
Address
Comment string `xml:",comment"`
Balabala string `xml:"balabala,allowempty"` // i want something like this
}
```
In xml standard, a self-closing tag is permitted.
https://www.w3.org/TR/REC-xml/#dt-empty
And empty-element tag should be used, and should only be used, for elements which are declared EMPTY.
https://www.w3.org/TR/REC-xml/#d0e2480
| NeedsFix | high | Critical |
249,576,669 | rust | `x.py doc` cannot work when a junction point / symbolic link cannot be created. | ... for instance, in a VirtualBox shared folder, which are mapped as network drive, does not support junction point on Windows, which causes `Incorrect function. (os error 1)` always.
Symbolic links (junction points) are used because:
> Here what we're doing is creating a *symlink* (directory junction on
> Windows) to the final output location. This is not done as an
> optimization but rather for correctness. We've got three trees of
> documentation, one for std, one for test, and one for rustc. It's then
> our job to merge them all together.
>
> Unfortunately rustbuild doesn't know nearly as well how to merge doc
> trees as rustdoc does itself, so instead of actually having three
> separate trees we just have rustdoc output to the same location across
> all of them.
>
> This way rustdoc generates output directly into the output, and rustdoc
> will also directly handle merging.
There should be other way to achieve the same effect? For example forcing `rustdoc` to output to `stage$N/$TARGET/doc` (bootstrap already wrapped `rustdoc` so it should be fine). | C-enhancement,T-bootstrap,A-docs,T-infra,C-optimization | low | Critical |
249,614,120 | flutter | Colors of Image Icon |
I wanted to use a multi color image as my icon the way it was. But when i made it an image icon it got decolorized. How do I restore the original colors?
| framework,a: images,has reproducible steps,P2,found in release: 3.3,found in release: 3.7,team-framework,triaged-framework | low | Major |
249,669,043 | react | Cross-origin error passed to componentDidCatch incorrectly | tl;dr React is passing "A cross-origin error was thrown" to `componentDidCatch` when there are no cross-origin scripts.
See [this discussion thread](https://github.com/facebook/react/pull/10353#issuecomment-321528685) and [this repro case](https://github.com/tessin/tessin-mini).
I was able to confirm the behavior. A quick look at `onError` showed a null `event.error`. | Component: DOM,Type: Needs Investigation,React Core Team | high | Critical |
249,700,441 | TypeScript | Generating type definitions for mixin classes with protected members | **TypeScript Version:** 2.4.2
**Code:**
I'm using mixins as described by: https://github.com/Microsoft/TypeScript/pull/13743
```
export type Constructor<T> = new(...args: any[]) => T;
export function Unsubscriber<T extends Constructor<{}>>(Base: T) {
class Unsubscriber extends Base implements OnDestroy {
protected unsubscribe: Subject<void> = new Subject();
ngOnDestroy() {
this.unsubscribe.next();
this.unsubscribe.complete();
}
}
return Unsubscriber;
}
```
If I compile this code with `"declaration": true` to get type definitions for my library, I get the following error:
```
ERROR in (truncated)/mixins.ts (...): Return type of exported function has or is using private name 'Unsubscriber'.
```
One solution is to add an interface...
```
export interface IUnsubscriber extends OnDestroy {
unsubscribe: Subject<void>;
}
```
...and have my mixin `function` have a return type of `Constructor<IUnsubscriber>`. This works, but it forces me to make the properties/methods exposed by my mixin be `public` even in cases where I want them to be `protected`.
Short of adding `protected` members to interfaces (which I'm not sure is the right thing to do), this seems to be a limitation of the currently supported mixin strategy.
| Bug,Domain: Declaration Emit | medium | Critical |
249,706,531 | vue | Update slot content without rerendering rest of component | ### What problem does this feature solve?
I have developed some components that can generate large amounts of HTML, and allow content to be added via slot. It appears that if the slot content is updated, the render function is called for the component; however, this seems like something that could be avoided through optimization which would significantly improve the performance of my component in some instances.
Is this possible?
### What does the proposed API look like?
Not proposing API changes.
<!-- generated by vue-issues. DO NOT REMOVE --> | improvement | medium | Major |
249,718,931 | go | container/heap: optimize heap to reduce number of comparisons during heapify and heap pop | This is an optimization specified in Knuth Volume 3 (Exercise 5.2, problem 18 I believe) where `down()` is called on an element in a certain position (during heap pop or init). It states that it's beneficial to move that element all the way to the leaf and then move up to its appropriate place instead of breaking out as soon as we find a position where the item is <= both of its children.
Python does this and the comment about this method in its `heapq` module describes it better than I can articulate (also includes comparison numbers).
```python
# The child indices of heap index pos are already heaps, and we want to make
# a heap at index pos too. We do this by bubbling the smaller child of
# pos up (and so on with that child's children, etc) until hitting a leaf,
# then using _siftdown to move the oddball originally at index pos into place.
#
# We *could* break out of the loop as soon as we find a pos where newitem <=
# both its children, but turns out that's not a good idea, and despite that
# many books write the algorithm that way. During a heap pop, the last array
# element is sifted in, and that tends to be large, so that comparing it
# against values starting from the root usually doesn't pay (= usually doesn't
# get us out of the loop early). See Knuth, Volume 3, where this is
# explained and quantified in an exercise.
#
# Cutting the # of comparisons is important, since these routines have no
# way to extract "the priority" from an array element, so that intelligence
# is likely to be hiding in custom comparison methods, or in array elements
# storing (priority, record) tuples. Comparisons are thus potentially
# expensive.
#
# On random arrays of length 1000, making this change cut the number of
# comparisons made by heapify() a little, and those made by exhaustive
# heappop() a lot, in accord with theory. Here are typical results from 3
# runs (3 just to demonstrate how small the variance is):
#
# Compares needed by heapify Compares needed by 1000 heappops
# -------------------------- --------------------------------
# 1837 cut to 1663 14996 cut to 8680
# 1855 cut to 1659 14966 cut to 8678
# 1847 cut to 1660 15024 cut to 8703
#
# Building the heap by using heappush() 1000 times instead required
# 2198, 2148, and 2219 compares: heapify() is more efficient, when
# you can use it.
#
# The total compares needed by list.sort() on the same lists were 8627,
# 8627, and 8632 (this should be compared to the sum of heapify() and
# heappop() compares): list.sort() is (unsurprisingly!) more efficient
# for sorting.
def _siftup(heap, pos):
endpos = len(heap)
startpos = pos
newitem = heap[pos]
# Bubble up the smaller child until hitting a leaf.
childpos = 2*pos + 1 # leftmost child position
while childpos < endpos:
# Set childpos to index of smaller child.
rightpos = childpos + 1
if rightpos < endpos and not heap[childpos] < heap[rightpos]:
childpos = rightpos
# Move the smaller child up.
heap[pos] = heap[childpos]
pos = childpos
childpos = 2*pos + 1
# The leaf at pos is empty now. Put newitem there, and bubble it up
# to its final resting place (by sifting its parents down).
heap[pos] = newitem
_siftdown(heap, startpos, pos)
```
Is there any interest in doing this optimization? I'm fairly new to Go, but I'd love to contribute with this if it's something you'd like to see. Thanks! | Performance,NeedsFix | low | Major |
249,777,729 | flutter | Ballistic simulations may be created too frequently | Make a normal fling gesture.
~50% of the time, many goBallistic calls are triggered when I would have expected just one.
In this example, it took 78ms cumulative recreating the simulations and causes frame drops.
Call stack
```
#0 ScrollPositionWithSingleContext.goBallistic (package:flutter/src/widgets/scroll_position_with_single_context.dart:150:16)
#1 BallisticScrollActivity.applyNewDimensions (package:flutter/src/widgets/scroll_activity.dart:399:14)
#2 ScrollPosition.applyNewDimensions (package:flutter/src/widgets/scroll_position.dart:441:14)
#3 ScrollPositionWithSingleContext.applyNewDimensions (package:flutter/src/widgets/scroll_position_with_single_context.dart:110:29)
#4 ScrollPosition.applyContentDimensions (package:flutter/src/widgets/scroll_position.dart:411:7)
#5 RenderViewport.performLayout (package:flutter/src/rendering/viewport.dart:827:20)
#6 RenderObject._layoutWithoutResize (package:flutter/src/rendering/object.dart:1767:7)
#7 PipelineOwner.flushLayout (package:flutter/src/rendering/object.dart:1056:18)
#8 BindingBase&SchedulerBinding&GestureBinding&ServicesBinding&RendererBinding.drawFrame (package:flutter/src/rendering/binding.dart:251:19)
#9 BindingBase&SchedulerBinding&GestureBinding&ServicesBinding&RendererBinding&WidgetsBinding.drawFrame (package:flutter/src/widgets/binding.dart:504:22)
#10 BindingBase&SchedulerBinding&GestureBinding&ServicesBinding&RendererBinding._handlePersistentFrameCallback (package:flutter/src/rendering/binding.dart:189:5)
#11 BindingBase&SchedulerBinding._invokeFrameCallback (package:flutter/src/scheduler/binding.dart:695:15)
#12 BindingBase&SchedulerBinding.handleDrawFrame (package:flutter/src/scheduler/binding.dart:643:9)
#13 _invoke (file:///Users/xster/development/flutter/bin/cache/pkg/sky_engine/lib/ui/hooks.dart:86)
#14 _drawFrame (file:///Users/xster/development/flutter/bin/cache/pkg/sky_engine/lib/ui/hooks.dart:75)
``` | framework,c: performance,f: scrolling,P2,team-framework,triaged-framework | low | Major |
249,822,177 | go | cmd/compile: coalesce consecutive calls to print/println | CLs 55095–55098 change how the compiler (and runtime) implement the built-ins print and println, in order to reduce the amount of code they generate. (The goal is to both reduce the runtime's binary footprint and to increase instruction density in important runtime routines.)
This issue spells out one further obvious optimization. Consider:
```go
println("a")
println("b")
```
After CL 55098, this is gets compiled into: printlock, print "a\n", printunlock, printlock, print "b\n", printunlock. But it could get compiled into: printlock, print "a\nb\n", printunlock. In short, coalesce consecutive calls to print/println in a single printlock-protected sequence of calls, combining string constants as possible, taking care to correctly handle the spaces and newlines introduced by println.
Low priority, but might be an interesting learning exercise for someone interested in the mid-tier of the compiler. It's not super straightforward, since walkprint looks at one node at a time, but it also shouldn't *too* difficult.
| Performance,NeedsDecision | low | Major |
249,825,561 | youtube-dl | Tudou/Youku Channel Support | ## Please follow the guide below
- You will be asked some questions and requested to provide some information, please read them **carefully** and answer honestly
- Put an `x` into all the boxes [ ] relevant to your *issue* (like this: `[x]`)
- Use the *Preview* tab to see what your issue will actually look like
---
### Make sure you are using the *latest* version: run `youtube-dl --version` and ensure your version is *2017.08.09*. If it's not, read [this FAQ entry](https://github.com/rg3/youtube-dl/blob/master/README.md#how-do-i-update-youtube-dl) and update. Issues with outdated version will be rejected.
- [x] I've **verified** and **I assure** that I'm running youtube-dl **2017.08.09**
### Before submitting an *issue* make sure you have:
- [x] At least skimmed through the [README](https://github.com/rg3/youtube-dl/blob/master/README.md), **most notably** the [FAQ](https://github.com/rg3/youtube-dl#faq) and [BUGS](https://github.com/rg3/youtube-dl#bugs) sections
- [x] [Searched](https://github.com/rg3/youtube-dl/search?type=Issues) the bugtracker for similar issues including closed ones
### What is the purpose of your *issue*?
- [ ] Bug report (encountered problems with youtube-dl)
- [x] Site support request (request for adding support for a new site)
- [ ] Feature request (request for a new functionality)
- [ ] Question
- [ ] Other
---
### If the purpose of this *issue* is a *bug report*, *site support request* or you are not completely sure provide the full verbose output as follows:
**Tudou:**
~$ youtube-dl http://id.tudou.com/i/UMTE2NzI5MDI4/videos -v
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['http://id.tudou.com/i/UMTE2NzI5MDI4/videos', '-v']
[debug] Encodings: locale UTF-8, fs utf-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2017.08.09
[debug] Python version 3.4.5 - Linux-3.10.0-514.26.1.el7.x86_64-x86_64-with-centos-7.3.1611-Core
[debug] exe versions: ffmpeg 2.6.8, ffprobe 2.6.8
[debug] Proxy map: {}
[generic] videos: Requesting header
WARNING: Falling back on generic information extractor.
[generic] videos: Downloading webpage
[generic] videos: Extracting information
ERROR: Unsupported URL: http://id.tudou.com/i/UMTE2NzI5MDI4/videos
Traceback (most recent call last):
File "/home/gazlene/.local/lib/python3.4/site-packages/youtube_dl/YoutubeDL.py", line 776, in extract_info
ie_result = ie.extract(url)
File "/home/gazlene/.local/lib/python3.4/site-packages/youtube_dl/extractor/common.py", line 433, in extract
ie_result = self._real_extract(url)
File "/home/gazlene/.local/lib/python3.4/site-packages/youtube_dl/extractor/generic.py", line 2944, in _real_extract
raise UnsupportedError(url)
youtube_dl.utils.UnsupportedError: Unsupported URL: http://id.tudou.com/i/UMTE2NzI5MDI4/videos
**Youku:**
youtube-dl http://i.youku.com/i/UNzY4NDMy/videos -v
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['http://i.youku.com/i/UNzY4NDMy/videos', '-v']
[debug] Encodings: locale UTF-8, fs utf-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2017.08.09
[debug] Python version 3.4.5 - Linux-3.10.0-514.26.1.el7.x86_64-x86_64-with-centos-7.3.1611-Core
[debug] exe versions: ffmpeg 2.6.8, ffprobe 2.6.8
[debug] Proxy map: {}
[generic] videos: Requesting header
WARNING: Falling back on generic information extractor.
[generic] videos: Downloading webpage
[generic] videos: Extracting information
ERROR: Unsupported URL: http://i.youku.com/i/UNzY4NDMy/videos
Traceback (most recent call last):
File "/home/gazlene/.local/lib/python3.4/site-packages/youtube_dl/YoutubeDL.py", line 776, in extract_info
ie_result = ie.extract(url)
File "/home/gazlene/.local/lib/python3.4/site-packages/youtube_dl/extractor/common.py", line 433, in extract
ie_result = self._real_extract(url)
File "/home/gazlene/.local/lib/python3.4/site-packages/youtube_dl/extractor/generic.py", line 2944, in _real_extract
raise UnsupportedError(url)
youtube_dl.utils.UnsupportedError: Unsupported URL: http://i.youku.com/i/UNzY4NDMy/videos
---
### Description of your *issue*, suggested solution and other information
Is there a way to support the download of Tudou and Youku channels? I'm an archivist, and i upload channels to Internet Archive (archive.org). There have been a couple i've been trying to archive, and if youtube channel support was implemented, then Youku/Tudou should be no problem. thank you. :) | request | low | Critical |
249,826,086 | vscode | Can't drag selected text with Ctrl to second file | - VSCode Version: Code 1.14.2 (cb82febafda0c8c199b9201ad274e25d9a76874e, 2017-07-19T23:34:09.706Z)
- OS Version: Windows_NT ia32 6.3.9600
------------------------------------------------
Hi,
See this gif:
Thanks
@bpasero @rebornix @alexandrudima
| feature-request,editor-drag-and-drop | low | Major |
249,851,597 | pytorch | Add CRF Layer | I use blstm-crf in advance_tutorial， but it runs very slow, can you add crf layer in pytorch？
cc @albanD @mruberry | feature,module: nn,triaged | low | Major |
249,861,936 | go | x/crypto/ssh: ssh connections and channels should be cancelable | When using x/crypto/ssh in a long-running program for communicating with many nodes that may come and go, it is necessary to be able to shutdown started SSH connections and channels cleanly. Currently there are many goroutines leaked.
For example, https://github.com/golang/crypto/blob/master/ssh/connection.go#L79 the DiscardRequests function is launched in its own go routine for each new connection, and there is no way, currently, to shut it down. It thus leaks memory.
Moreover in order to make the internals of the (brilliant, fabulous) ssh library cancellable, each instance of a raw send and receive will need to be put with a select statement that includes a cancellation signal. I suggest implenting cancellation by adding context.CancelFunc and context.Context to the Config structure.
I've made these changes in a branch, here https://github.com/glycerine/crypto/tree/cancelable
These likely are not perfect or to anyone else's taste exactly, but feel free to mold to taste.
@hanwen this may be of interest. | NeedsInvestigation | medium | Major |
249,946,166 | pytorch | Hard-negative mining using __getitem__ directive in Dataset class | If I wish to do online hard negative mining (for triplet based algorithms), then I wish to send the recent state dict of my network to the data loader to evaluate the criterion and select the negative. Currently, you need to have a lot of workaround for this to get it working. I think the major limitation is the usage of the __getitem__ directive. Can we have a more flexible approach which allows to send arbitrary number of parameters? Or is there a solution in the current situation which I am not aware of?
Thanks.
cc @SsnL | module: dataloader,triaged | low | Major |
249,979,787 | vscode | Cleanup ExtensionContext.workspaceState when a workspace no longer exists | feature-request,workbench-state | high | Critical |
|
250,052,361 | go | cmd/compile: optimize unsigned comparisons with zero/one | I started on an minor optimization effort earlier this summer that I won't have time to see through for 1.10. This issue is a snapshot of the work and a description of what to do next, in case anyone else wants to pick an architecture to work on and run with it.
Comparing unsigned ints with zero/one is special and (perhaps surprisingly) not uncommon. One example: Given unsigned x, `x > 0` iff `x != 0`. This is helpful, because on many architectures, x == 0 and x != 0 are faster and/or shorter. For example, on amd64, we can use TEST instead of CMP, and arm64 has dedicated instructions for comparison with zero.
Here are some generic rewrite rules that I believe to be sound:
```
(Greater64U x zero:(Const64 [0])) -> (Neq64 x zero)
(Greater32U x zero:(Const32 [0])) -> (Neq32 x zero)
(Greater16U x zero:(Const16 [0])) -> (Neq16 x zero)
(Greater8U x zero:(Const8 [0])) -> (Neq8 x zero)
(Leq64U x zero:(Const64 [0])) -> (Eq64 x zero)
(Leq32U x zero:(Const32 [0])) -> (Eq32 x zero)
(Leq16U x zero:(Const16 [0])) -> (Eq16 x zero)
(Leq8U x zero:(Const8 [0])) -> (Eq8 x zero)
(Geq64U _ (Const64 [0])) -> (ConstBool [1])
(Geq32U _ (Const32 [0])) -> (ConstBool [1])
(Geq16U _ (Const16 [0])) -> (ConstBool [1])
(Geq8U _ (Const8 [0])) -> (ConstBool [1])
(Less64U _ (Const64 [0])) -> (ConstBool [0])
(Less32U _ (Const32 [0])) -> (ConstBool [0])
(Less16U _ (Const16 [0])) -> (ConstBool [0])
(Less8U _ (Const8 [0])) -> (ConstBool [0])
(Less64U x (Const64 <t> [1])) -> (Eq64 x (Const64 <t> [0]))
(Less32U x (Const32 <t> [1])) -> (Eq32 x (Const32 <t> [0]))
(Less16U x (Const16 <t> [1])) -> (Eq16 x (Const16 <t> [0]))
(Less8U x (Const8 <t> [1])) -> (Eq8 x (Const8 <t> [0]))
(Geq64U x (Const64 <t> [1])) -> (Neq64 x (Const64 <t> [0]))
(Geq32U x (Const32 <t> [1])) -> (Neq32 x (Const32 <t> [0]))
(Geq16U x (Const16 <t> [1])) -> (Neq16 x (Const16 <t> [0]))
(Geq8U x (Const8 <t> [1])) -> (Neq8 x (Const8 <t> [0]))
```
Unfortunately, doing this at the generic level is probably not ideal, since (a) not all architectures have special handling of eq/neq 0, (b) it might interfere with the prove pass.
So the remaining work here is to port these rules to arch-specific rules as applicable, and confirm/disconfirm that they are used and that they are worthwhile.
(Related aside: Why doesn't amd64.rules have rules like `(SETNE (CMPQ x zero:(MOVQconst))) -> (SETNE (TESTQ x x))`?)
cc @martisch @philhofer
| Suggested,Performance,help wanted,compiler/runtime | low | Minor |
250,085,125 | kubernetes | apiserver errors should include reason | /kind feature
**What happened**:
Spend too much time figuring out that my apiserver didn't start because the etcd DNS name couldn't be resolved. I got the following error:
```
Error: error waiting for etcd connection: timed out waiting for the condition
```
And even `--v=10` didn't provide any more context. This was very misleading and made me assume the issue is on application level.
**What you expected to happen**:
I expected the apiserver error to tell me that DNS resolution wasn't working.
**How to reproduce it (as minimally and precisely as possible)**:
I used the bootkube manifest but just starting the apiserver with `--etcd-servers` pointing to a nonexisting name. | area/api,area/apiserver,sig/api-machinery,kind/feature,lifecycle/frozen | medium | Critical |
250,109,335 | javascript | Support for ESnext Class Feature | Hello,
Curious if support for [ESnext classes](https://github.com/tc39/proposal-class-fields) is can be expected now that the feature has been [moved from stage-2 to stage-3](https://github.com/tc39/proposal-class-fields/commit/5a4ff5fa4bf30885188279f6fb8070f2e1903c32).
If not, at what point (if any) will this feature be included?
Currently using the work around detailed in https://github.com/airbnb/javascript/issues/589.
Thank you | needs eslint rule change/addition | low | Major |
250,132,888 | kubernetes | Support on Containerized mounter with customer image | "Containerized Mounter" feature #community/pull/589 is work-in-progress. Currently Kuberentes supports a temporary solution for containerized mounter, but only works for NFS and GlusterFS.
#37990 #41944
But based on the current mounter with chroot solution, we can also make other types of mount utitlities work in a quick way. The steps are listed as follows
1. Install the mount binaries in a docker image (example of Docker file https://github.com/kubernetes/kubernetes/blob/master/cluster/gce/gci/mounter/Dockerfile)
2. Export the docker image to a tar file
docker run --name=gcimounter image
docker export gcimounter > image.tar
3. Upload the image.tar to google cloud (or other places that you can use wget to download it)
4. Run a daemonSet to install the image tar file on each Kuberentes cluster node
Example of daemonSet yaml file https://gist.github.com/jingxu97/9f7ef10d9b915e8701a7294e99367f17
This is a quick-dirty way to set up mounter rootfs with customized image file so that user could have their own version of file system binaries. But we are not trying to fully support this since we are currently working on a more generalized approach for containerized mount.
| sig/storage,lifecycle/frozen | low | Minor |
250,294,909 | vscode | Toggle the block comment without having to select it | <!-- Do you have a question? Please ask it on http://stackoverflow.com/questions/tagged/vscode. -->
<!-- Use Help > Report Issues to prefill these. -->
- VSCode Version: 1.15.0
- OS Version: windows10
There is a problem that bothers me. **If I want to remove the block comment, I have to select it**, like this:
If I do not select it, and go to toggle block comment, it becomes:
Have you a good idea to solve it?
**PS**: I use this hot key `ctrl+shift+/` to toggle block comments, which was bound to the command `editor.action.blockComment`
Reproduces without extensions: Yes
| feature-request,editor-comments | medium | Critical |
250,327,117 | flutter | Possible to capture the previous screen before an error | In relation to https://github.com/flutter/flutter/issues/10695, customer: six is asking if it's possible to capture the previous frame before an error.
That way they could send that screen as part of a feedback report. | framework,P2,team-framework,triaged-framework | low | Critical |
250,340,074 | angular | Animations behaving differently despite equivalent definitions | <!--
PLEASE HELP US PROCESS GITHUB ISSUES FASTER BY PROVIDING THE FOLLOWING INFORMATION.
ISSUES MISSING IMPORTANT INFORMATION MAY BE CLOSED WITHOUT INVESTIGATION.
-->
## I'm submitting a...
<!-- Check one of the following options with "x" -->
<pre><code>
[ ] Regression (a behavior that used to work and stopped working in a new release)
[x] Bug report <!-- Please search GitHub for a similar issue or PR before submitting -->
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question
</code></pre>
## Current behavior
<!-- Describe how the issue manifests. -->
I have been trying to get this animation to work where a modal dialog expands out from the click location. When I define the animation using states, it looks like the dialog is "swooping" in from the location (and if i slow it down in the chrome animations debugging tool, it looks like the dialog expands out towards the middle of the screen and then moves upwards). If i change the animation to have inline styles defined, everything works as expected.
Non-working "swooping" animation:
```typescript
state(void, style({
left: '{{startX}}px',
top: '{{startY}}px',
transformOrigin: '{{transformOrigin}}',
opacity: '0',
transform: 'scale(0.01)'
}), { params: { startX: 0, startY: 0, transformOrigin: 'top left' }}),
state('OPEN', style({
left: '50%',
top: '138px',
opacity: '1',
transform: 'scale(1) translateX(-50%)'
})),
transition('void => OPEN', animate(200))
```
Working option:
```typescript
transition(`void=> OPEN`, [
style({
left: '{{startX}}px',
top: '{{startY}}px',
transformOrigin: '{{transformOrigin}}',
opacity: '0',
transform: 'scale(0.01)'
}),
animate(200, style({
left: '50%',
top: '138px',
opacity: '1',
transform: 'scale(1) translateX(-50%)'
}))
], { params: { startX: 0, startY: 0, transformOrigin: 'top left' }})
```
## Expected behavior
<!-- Describe what the desired behavior would be. -->
I would expect both of these animation definitions to be equivalent. The only difference I can see is that obviously the one with state definitions keeps those styles applied to the element after the transition is do ne
## Minimal reproduction of the problem with instructions
<!--
For bug reports please provide the *STEPS TO REPRODUCE* and if possible a *MINIMAL DEMO* of the problem via
https://plnkr.co or similar (you can use this template as a starting point: http://plnkr.co/edit/tpl:AvJOMERrnz94ekVua0u5).
-->
Hard to get a reproducible version of this because the dialog is being added into an auxiliary router outlet. (I also tried getting the "router driven animations" to work and never was able to)
## What is the motivation / use case for changing the behavior?
<!-- Describe the motivation or the concrete use case. -->
## Environment
<pre><code>
Angular version: 4.3.4
<!-- Check whether this is still an issue in the most recent Angular version -->
Browser:
- [x] Chrome (desktop) version 60.0.3112.90
- [ ] Chrome (Android) version XX
- [ ] Chrome (iOS) version XX
- [ ] Firefox version XX
- [ ] Safari (desktop) version XX
- [ ] Safari (iOS) version XX
- [ ] IE version XX
- [ ] Edge version XX
For Tooling issues:
- Node version: XX <!-- run `node --version` -->
- Platform: <!-- Mac, Linux, Windows -->
Others:
<!-- Anything else relevant? Operating system version, IDE, package manager, HTTP server, ... -->
</code></pre>
| type: bug/fix,area: animations,freq2: medium,P3 | low | Critical |
250,372,948 | vscode | [themes] Disable Italic Option Feature Request | - VSCode Version: 1.15.0
- OS Version: Windows 10 Version 1703 Build 15063.540
Steps to Reproduce:
1.
2.
Reproduces without extensions: Yes/No
Sometimes authors of themes use italic for `comments`, `language keywords` and for other things. In some cases that's looks not so good (as example what I mean you can read my issue/feature-request on Material Theme https://github.com/equinusocio/vsc-material-theme/issues/81). Of course we can change this in theme source code manually but it will be great to have `Disable Italic Option` in vscode config file.
For example in Sublime Text 3 we have `no_italic` font option to disable italic at all:
```
"font_options":
[
"no_italic"
],
```
Related issue: https://github.com/Microsoft/vscode/issues/25895
Fira Code don't have Italic too.
| feature-request,themes,accessibility | high | Critical |
250,374,131 | go | x/mobile/gl: need API to retrieve error from GetAttribLocation() | ### What version of Go are you using (`go version`)?
$ go version
go version go1.9rc2 linux/amd64
### What operating system and processor architecture are you using (`go env`)?
$ go env
GOARCH="amd64"
GOBIN=""
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/home/esmarques/go"
GORACE=""
GOROOT="/usr/local/go1.9rc2.linux-amd64"
GOTOOLDIR="/usr/local/go1.9rc2.linux-amd64/pkg/tool/linux_amd64"
GCCGO="gccgo"
CC="gcc"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build080353435=/tmp/go-build -gno-record-gcc-switches"
CXX="g++"
CGO_ENABLED="1"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
### What did you do?
Need API to retrieve error from GetAttribLocation().
### What did you expect to see?
GetAttribLocation() returns -1 on error:
https://www.khronos.org/registry/OpenGL-Refpages/es3.0/html/glGetAttribLocation.xhtml
I would expect to be able to detect the -1 using the API in https://godoc.org/golang.org/x/mobile/gl
### What did you see instead?
GetAttribLocation() currently returns result as Attrib.Value (uint) which can't deliver the error -1.
https://godoc.org/golang.org/x/mobile/gl#Attrib
| mobile | low | Critical |
250,377,554 | go | .gitignore: Remove cruft and editor/OS-specific ignore files | Here's the current contents of the `.gitignore` file for the Go project.
```
.DS_Store
*.[56789ao]
*.a[56789o]
*.so
*.pyc
._*
.nfs.*
[56789a].out
*~
*.orig
*.rej
*.exe
.*.swp
core
*.cgo*.go
*.cgo*.c
_cgo_*
_obj
_test
_testmain.go
/VERSION.cache
/bin/
/build.out
/doc/articles/wiki/*.bin
/goinstall.log
/last-change
/misc/cgo/life/run.out
/misc/cgo/stdio/run.out
/misc/cgo/testso/main
/pkg/
/src/*.*/
/src/cmd/cgo/zdefaultcc.go
/src/cmd/go/internal/cfg/zdefaultcc.go
/src/cmd/go/internal/cfg/zosarch.go
/src/cmd/internal/objabi/zbootstrap.go
/src/go/build/zcgo.go
/src/go/doc/headscan
/src/runtime/internal/sys/zversion.go
/src/unicode/maketables
/test.out
/test/garbage/*.out
/test/pass.out
/test/run.out
/test/times.out
# IntelliJ-based editors
/.idea/
```
Many of those, like `.idea` and `.DS_Store`, are not specific to the Go project - they're specific to a user's environment or to an OS. There are large number of user-specific files that get placed in directories that we might need to exclude; we can't enumerate the list, and it also seems useful to teach users how to solve this problem for themselves.
Git has a tool for dealing with files you'd like to (privately) ignore. You can edit the `.git/info/exclude` file to privately ignore any files you don't want to commit to the project. You can also create a global `.gitignore` file for your computer to ignore those files in every Git repository on your machine, described here: https://help.github.com/articles/ignoring-files/#create-a-global-gitignore.
Finally, you can create a Git template to automatically populate the contents of `.gitignore` whenever a new Git repository is created, as described here: https://stackoverflow.com/a/16658321/329700
I'd like to propose that we put the above instructions in the `.gitignore` file and then remove all of the user and OS-specific ignore directives; the ignore file should only include artifacts that are generated by the Go project that we'd rather not check in. | NeedsFix | low | Major |
250,379,447 | vscode | Add Opacity & Variable Height to Minimap | I'm looking for a way to change my VSCode Editor Minimap to behave more like the Atom Minimap.
Specifically, to have container opacity and variable height as the file grows in length. The opacity is what is most important to me, but the variable container length would help a lot as well.
Currently, my Atom minimap allows opacity and only grows in length as needed.
While my VSCode minimap covers my code and maintains full pane height no matter how many lines are in the file.
I tried asking a question about this on [stackoverflow](https://stackoverflow.com/questions/45685834/vscode-minimap-creating-opacitylimited-height-like-atom-minimap-package) and looking through these issues. So far the closest I've found to this question is issue [#21255](https://github.com/Microsoft/vscode/issues/21255), which points to issue [#21229](https://github.com/Microsoft/vscode/issues/21229) and then to issue [#21359](https://github.com/Microsoft/vscode/issues/21359), which lead to the implementation of a box shadow to make the minimap separation more prominent.
Unfortunately, the box shadow doesn't allow me to recover that text editor width while keeping my minimap enabled. This makes the difference between being able to see all my code using 2 panes and having my code cut off by the minimap.
I'm sure a lot of people transitioning from Atom to VSCode would appreciate being able to maintain this editor workspace, particularly when working with a lot of smaller files.
EDIT:
Adding what information I can in case you consider feature implementation:
Atom uses a gear icon that appears over the minimap on mouseover allows for 'absolute-mode' to be toggled on and off. This option toggles between a VSCode-like minimap and the one I showed above.
From what I understand of the VSCode design paradigm so far, I think a similar feature could be toggled as a User Setting such as `"editor.minimap.absolutePosition": true,` | feature-request,editor-minimap | medium | Critical |
250,454,447 | flutter | Flutter templates should support "com.android.library" Gradle plugin | The generated plugin template `build.gradle` files, and Flutter's `packages/flutter_tools/gradle/flutter.gradle` do not support Android library.
In the `flutter.gradle` file, only `project.android.applicationVariants` are used. Android library does not have this property and instead offers `libraryVariants`.
The problem does not happen to app template, such as the `example/android` in the plugin package.
Fixing this would eliminate all the squiggle lines and missing Flutter imports in Java source.
This is probably related to #11439 and #9698. | platform-android,tool,t: gradle,P2,a: plugins,team-android,triaged-android | low | Major |
Subsets and Splits
No saved queries yet
Save your SQL queries to embed, download, and access them later. Queries will appear here once saved.