id
int64 393k
2.82B
| repo
stringclasses 68
values | title
stringlengths 1
936
| body
stringlengths 0
256k
⌀ | labels
stringlengths 2
508
| priority
stringclasses 3
values | severity
stringclasses 3
values |
|---|---|---|---|---|---|---|
175,885,451 | You-Dont-Know-JS | ES6 & Beyond: figure out default function closure over params/body-vars | https://gist.github.com/getify/1abb4e0710a3eb56b04e9fbc9944b50d
| for second edition | medium | Minor |
175,907,502 | youtube-dl | Site Request: https://school.scotch.io/courses | ## Please follow the guide below
- You will be asked some questions and requested to provide some information, please read them **carefully** and answer honestly
- Put an `x` into all the boxes [ ] relevant to your _issue_ (like that [x])
- Use _Preview_ tab to see how your issue will actually look like
---
### Make sure you are using the _latest_ version: run `youtube-dl --version` and ensure your version is _2016.09.08_. If it's not read [this FAQ entry](https://github.com/rg3/youtube-dl/blob/master/README.md#how-do-i-update-youtube-dl) and update. Issues with outdated version will be rejected.
- [x] I've **verified** and **I assure** that I'm running youtube-dl **2016.09.08**
### Before submitting an _issue_ make sure you have:
- [x] At least skimmed through [README](https://github.com/rg3/youtube-dl/blob/master/README.md) and **most notably** [FAQ](https://github.com/rg3/youtube-dl#faq) and [BUGS](https://github.com/rg3/youtube-dl#bugs) sections
- [x] [Searched](https://github.com/rg3/youtube-dl/search?type=Issues) the bugtracker for similar issues including closed ones
### What is the purpose of your _issue_?
- [ ] Bug report (encountered problems with youtube-dl)
- [x] Site support request (request for adding support for a new site)
- [ ] Feature request (request for a new functionality)
- [ ] Question
- [ ] Other
---
### If the purpose of this _issue_ is a _site support request_ please provide all kinds of example URLs support for which should be included (replace following example URLs by **yours**):
- List of Courses: https://school.scotch.io/courses
- Example Course / Playlist: https://school.scotch.io/getting-started-with-angular-2
- Single video (part of course): https://school.scotch.io/getting-started-with-angular-2/introduction
| account-needed | low | Critical |
175,970,980 | vue | Allow SSR to render unescaped inlined script tags. | I have a feature request - In order to fully replace templating engine server should be able to output raw unescaped contents for some tags like <script>. Currently all the transcluded content or the content provided by v-text/v-html is automatically escaped and the script becomes unusable.
Example of usage - output json-ld:
```
<script type="application/ld+json">
{
"@context": "http://schema.org",
"@type": "Person",
"name": "John Doe",
"jobTitle": "Graduate research assistant",
"affiliation": "University of Dreams",
"additionalName": "Johnny",
"url": "http://www.example.com",
"address": {
"@type": "PostalAddress",
"streetAddress": "1234 Peach Drive",
"addressLocality": "Wonderland",
"addressRegion": "Georgia"
}
}
</script>
```
| feature request | low | Major |
175,983,800 | opencv | Suggestions for future GSoCs | Just want to point out that it might be interesting to get the opinion of the community into new subjects for GSoC 2017 and collect them somewhere central. We could use this issue for a growing list of suggestions.
Let me start by adding one
- Fixing the terribly broken down video backend (both writer and reader). There is simply no guarantee that stuff works on different systems for now, codecs are poorly supported and the huge amount of issues on the Q&A clearly show we need some fixing in this part of the library.
| RFC,GSoC | medium | Critical |
175,985,019 | opencv | IPP: pow() with non-integral exponent does not follow documentation on negative numbers | ##### System information (version)
- OpenCV => 3.1
- Operating System / Platform => Linux 64 Bit
- Compiler => g++ 4.9.3
##### Detailed description
When compiling OpenCV with `-DWITH_IPP=OFF`, there is (typically) no problem. When compiling OpenCV with `-DWITH_IPP=ON` however, taking a non-integral power of a negative number x results in `-nan` instead of the expected |x|^e, which is what should happen according to:
http://docs.opencv.org/3.1.0/d2/de8/group__core__array.html#gaf0d056b5bd1dc92500d6f6cf6bac41ef
##### Steps to reproduce
```
#include <opencv/cv.hpp>
using namespace cv;
main(int argc, char** argv) {
Mat test(1,1,CV_32FC1);
test = -1.0;
pow(test,0.4,test);
printf("result: %f\n",test.at<float>(0));
}
```
When compiled with `-DWITH_IPP=OFF`, you get `result: 1.0`
When compiled with `-DWITH_IPP=ON`, you get `result: -nan`
For exponent 0.5, both the IPP and non-IPP version seem to be broken (probably because it is handled as a special case), and they both result in `-nan`.
Suggested solution:
Update the documentation to say that the result of a negative number to a non-integral power is undefined.
Some background:
I was using `pow` to gamma-adjust an image, where the values were not necessarily between 0.0 and 1.0 but could be a bit outside that range because of previous processing steps. I was assuming that values below 0.0 would be clamped to 0.0 before taking the power (which would be the useful thing to do here), but instead they would actually become positive. So thanks to this bug in OpenCV, I discovered a bug in my code. I can't think of any cases where the documented behavior is actually what you want, so I think it's better to explicitly say that the result is undefined (after all, mathematically the result is not a real number), than it is to 'fix' the IPP implementation of `pow`.
| bug,category: core,category: documentation,RFC | low | Critical |
176,005,398 | vscode | Support for RTL languages | - VSCode Version: 1.5.0
- OS Version: windows 10
I can honestly dare to say that this is the best open source editor for web developers but, the missing of the small things like the Arabic language support is really frustrating!!
@alexandrudima yes I mean to work with source code files containing Arabic or Hebrew.
| feature-request,editor-RTL | high | Critical |
176,107,312 | flutter | `flutter build` is returning zero, should return not zero ? | `flutter build` doesn't do anything other than print the help. We might not want to return zero there. Instead, I'd expect some non-zero code.
For example, this will run the second command, which I didn't expect:
`flutter build && flutter install`
The second command should not run because the first was not successful, however the first command returned zero.
| tool,P3,team-tool,triaged-tool | low | Major |
176,117,527 | flutter | "flutter drive" CLI is confusing | ``` bash
$ flutter drive --profile
Test file not found: test_driver/main_test.dart
$ flutter drive --profile -t test_driver/main.dart
Target file "test_driver/main.dart" not found.
$ flutter drive --profile test_driver/scroll_perf.dart
Starting application: lib/main.dart
$ flutter drive --profile -t test_driver/scroll_perf.dart
Starting application: test_driver/scroll_perf.dart
$ flutter drive --profile -t test_driver/scroll_perf_test.dart
Test file not found: test_driver/scroll_perf_test_test.dart
```
I AM THE CONFOOSE.
| tool,P2,team-tool,triaged-tool | low | Major |
176,122,587 | go | runtime: mark long lived objects with a special flag | Hi,
I've been thinking on how to make finding memory leaks a bit easier for Go users.
I would like to ask if it's possible to introduce a runtime flag like `GODEBUG=gctrace=3` where the GC would "paint" the long lived objects that live over a long period of time in the memory of the program. Say this could be configured via `GODEBUG=gctrace=3,longlived=100s` which would express that the user sees the objects that are present for more than 100 seconds printed when the GC runs (the display can be done at a frequency of a few seconds apart so that it doesn't overload output in case of very large applications). An alternative would be maybe instead of a time span to configure a number of GC runs that would need to pass in order for an object to be considered old (but that would imply the user is very savvy about the GC, how it works and how the application should perform).
I know this would imply a runtime penalty but when trying to find a memory leak performance is not the priority.
What do you think? Would this be possible? If you need further details to clarify this please let me know.
Thank you.
| NeedsDecision,FeatureRequest,compiler/runtime | low | Critical |
176,142,277 | vscode | Move line up/down should support multiple cursors | - VSCode Version: Code - Insiders 1.6.0-insider (20c3935a130f5b86d629a8543c9c71348c54c3de, 2016-09-09T05:59:09.913Z)
- OS Version: Linux x64 4.4.0-31-generic, Ubuntu 16.04
Steps to Reproduce:
1. Add multiple cursors across multiple lines
2. Run the move line up command, only the line containing the "primary" cursor is moved and the other cursors are lost
| feature-request,editor-multicursor,editor-commands | medium | Major |
176,145,082 | go | proposal: C API for the runtime | # Purpose
This is a proposal for a basic C API for the runtime. It allows for non-Go main programs and for using specially written Go libraries from any language that can call C functions, with a few additional features beyond what are currently available by `buildmode=c-shared`. This will be a new buildmode.
# Background
Go can call almost any C function via CGo. However, the ability to have a non-Go main program is much more limited. Go does have `buildmode=c-shared`, but it is limited by #11100 and also does not allow for useful features like passing `GOMAXPROCS` other than as an environment variable.
# Goals
- Allow for writing programs in a mixture of Go and another language, such that Go is not necessarily the language in which the program's entry point is written.
- Allow for writing a a library partly or completely in Go for use by another language.
- Provide handles that can passed to C and which can refer to any Go object.
# Non-Goals
- Allowing arbitrary Go functions to be called from C
- Allowing C code to manipulate arbitrary Go data structures.
# The API
## Ground rules.
The entire API is provided in a single C header file, `goapi.h`.
Unless otherwise specified, any function can be called from multiple threads simultaneously. However, a single pointer in the API cannot be passed to API functions in 2 or more threads simultaneously, unless both functions take pointers to `const` data.
## The API itself
``` c
int go_runtime_init(char * const* errormsg, ssize_t *already_initialized, const char * const *options, const void * const* arguments);
```
Initializes the Go runtime. Must be called before calling any other Go function. Thread-safe and may be called multiple times.
`options` is a pointer to an array of NUL-terminated strings. Each string corresponds to a matching `void*` in `arguments` that corresponds to a matching pointer, which points to a flag that can be used to configure the runtime. Currently, the only string in `options` that is meaningful is `GOMAXPROCS`, which replaces the `GOMAXPROCS` environment variable: the corresponding `void*` must point to a `size_t*`. All other values are reserved and must not be used.
If the defaults are OK, both `arguments` and `options` may be set to NULL. They are ignored if the runtime is already initialized.
Returns 0 on success, a negative number on failure.
- On success, `*errormsg` is set to `NULL` and `*already_initialized` is set to the number of times the runtime has been initialized (including this one). It is safe to set `errormsg` and/or `already_initialized` to NULL, in which case they are not accessed.
- On failure, `*errormsg` points to a NUL-terminated, human-readable error message, and `*already_initialized` holds a negative number. Again, neither are written to if NULL.
``` c
int go_runtime_shutdown(void);
```
This function shuts down the runtime. It must be called once for each call to `go_runtime_init`. Only the last such call has any effect.
Once the number of calls to `go_runtime_shutdown` equals the number of calls to `go_runtime_init`, this function terminates all active goroutines and resets any signal handlers.
The following sentence may not be initially implemented:
Afterwards, it is safe to `dlclose` the shared library containing the runtime, or to restart the runtime with `go_runtime_init`.
``` c
typedef struct Go_Handle *Go_Handle;
```
A handle to an arbitrary Go object. Analogous to a Haskell stable pointer. It stays valid even across garbage collections.
A `Go_Handle` is not guaranteed to point to valid memory. Dereferencing it invokes undefined behavior.
``` c
void go_runtime_delete_handle(Go_Handle handle_to_be_freed);
```
Deletes the handle passed as argument, rendering it invalid and freeing all underlying resources. After this function is called, the object the handle pointed to may be garbage collected if there are no more references to it.
``` c
Go_Handle go_runtime_duplicate_handle(Go_Handle handle_to_be_duplicated);
```
Duplicates the handle passed as argument. The returned handle points to the same object as the original handle, but must be deallocated separately.
``` c
uint8_t go_runtime_are_identical_handles(Go_Handle handle1, Go_Handle handle2);
```
Tests if the 2 handles passed are identical. Returns `true` if they point to the same object in memory. Otherwise, returns `false`.
## The Go side
These are additional functions exposed from the runtime package.
``` go
type CHandle
```
The type of C handles to Go data. When passed via CGo, becomes a `Go_Handle` on the C side.
May be accessed by multiple goroutines simultaneously.
``` go
func NewHandle(object interface {}) CHandle
```
Creates a handle to a Go object that can safely be passed to C.
``` go
func DuplicateHandle(handle CHandle) CHandle
```
Duplicates the handle.
``` go
func TestIfIdenticalHandles(handle1 CHandle, handle2 CHandle) bool
```
Tests if the 2 handles passed point to the same object; that is, if modifications of the object pointed to by one will affect the object pointed to by the other.
``` go
func DeallocateHandle(handle CHandle)
```
Deallocates the handle, rendering it invalid.
``` go
func DereferenceHandle(handle CHandle) interface {}
```
Dereferences the handle, returning the contained object. If the handle is invalid, invokes undefined behavior.
| Proposal,Proposal-Hold | medium | Critical |
176,173,394 | rust | `impl Trait` fails to resolve when returning `!` | I couldn't think of a better title.
This code doesn't compile on nightly :
``` rust
#![feature(conservative_impl_trait)]
use std::ops::Add ;
fn test() -> impl Add<u32> {
unimplemented!()
}
fn main() {}
```
```
rustc 1.13.0-nightly (378195665 2016-09-08)
error[E0277]: the trait bound `(): std::ops::Add<u32>` is not satisfied
```
while this does :
``` rust
#![feature(conservative_impl_trait)]
use std::ops::Add ;
fn test() -> impl Add<u32> {
if true {
unimplemented!()
} else {
0
}
}
fn main() {}
```
| A-type-system,A-trait-system,T-compiler,A-impl-trait,C-bug,T-types | medium | Critical |
176,177,261 | vscode | [json] validation doesn't work offline | - VSCode Version: 1.5.1
- OS Version: OS X El Capitan 10.11.3
Every time I launch VS Code when I'm offline, I get this error:
JSON validation doesn't work as a result.
I hope a schema reference can be initially cached inside the editor and downloaded once again when internet is on.
Steps to Reproduce:
1. Go offline (switch off the internet)
2. Open VS Code.
3. Open some `json` file
4. Work without validation but with an error.
| feature-request,json | low | Critical |
176,181,367 | flutter | specify assets that are for development only | It would be useful to specify some assets that should be loaded only during development and ignored when doing a `release` build.
I'm proposing adding a `dev_assets` option to `flutter.yml` to mimic the similar concept of `dev_dependencies` in the standard Dart pubspec.yaml.
This feature is in someway related #4014 in that you need a way to know in your code that `dev_assets` are available to use.
| c: new feature,tool,a: assets,P3,customer: castaway,team-tool,triaged-tool | medium | Major |
176,190,605 | electron | Add option to apply WS_BORDER style for frameless window | - Electron version:
latest
- Operating system:
Windows (7 and 10)
The current BrowserWindow implementation doesn't have a way to optionally add back in the borders. In Windows API, I'm familiar with having these by using styles like:
WS_BORDER, WS_DLGFRAME
and/or extended styles:
WS_EX_DLGMODALFRAME | WS_EX_CLIENTEDGE | WS_EX_STATICEDGE
Windows 10 puts a 1 pixel border around the entire window with the user's selected color. When the app is missing this, it doesn't feel like a native app.
Here's an extreme close-up showing a frameless electron window (back) and a native windows app (front)
| enhancement :sparkles:,platform/windows,component/BrowserWindow | low | Major |
176,199,560 | go | doc: add ACME (LetsEncrypt, etc) example docs to the standard library | Thanks to @crhym3, we now have a suitably-licensed & CLA-clean ACME implementation in https://godoc.org/golang.org/x/crypto/acme (and a high-level package in https://godoc.org/golang.org/x/crypto/acme/autocert).
I'd like to consider privately vendoring that into Go 1.8 and making HTTPS even easier.
I'd like a complete user program with automatic HTTPS certs to look something like:
``` go
package main
import (
"log"
"net/http"
)
func main() {
http.HandleFunc("/", websiteHandler)
srv := &http.Server{
Addr: "example.com:443",
ACMEServer: http.LetsEncrypt, // non-empty enables autocert support
ACMEAgreeTOS: func(tosURL string) bool { return true },
ACMEEmail: "[email protected]", // (but optional)
}
log.Fatal(srv.ListenAndServeTLS("", ""))
}
```
Misc notes:
- The `ACMEFoo` names are placeholders. Maybe they'd deserve their own struct.
- `ACMEServer` would be required as the opt-in, and we wouldn't make LetsEncrypt be automatic or preferred, but we would add a constant `const LetsEncrypt = "https://acme-v01.api.letsencrypt.org/directory"` like the `acme` package has.
- `ACMEAgreeTOS` would be required for now. The ACME protocol requires a TOS agreement because the CAB Forum requires cert issuers to have a legal relationship with the people getting certs or something. It's mostly a formality, but we shouldn't make it automatically say "yes" either, even though I don't think LetsEncrypt themselves care. Maybe we could export the https://godoc.org/golang.org/x/crypto/acme#AcceptTOS func in the `net/http` package to reduce the boilerplate.
- `ACMEEmail` is optional. If provided, your ACME cert provider can keep you updated on problems or changes.
- the default cache directory would be automatic. We could provide a string to let people pick an alternate directory. If you want to do something more complicated (e.g. cache coordination over a cluster), then you can just import the `golang.org/x/crypto/acme/autocert` package yourself. This is analogous to the HTTP/2 situation where common HTTP/2 is provided automatically, but weird uses require importing the guts.
- `srv.ListenAndServeTLS("", "")` is already valid for the past few releases, since 6a208efbdfa939dc236a63383df19c7ab44aa50a for #14268 requested by @willchan specifically for LetsEncrypt stuff. It's a little ugly but works. Maybe we could provide instead a new method or option which also listens on an cleartext port 80 and redirects HTTP to HTTPS, optionally with a HSTS header.
My goal is for HTTPS to be dead simple out of the box.
Thoughts?
/cc @adg @broady @campoy @quentinmit @rsc @robpike @ianlancetaylor @mholt @crhym3
| Documentation,NeedsDecision | high | Critical |
176,199,919 | go | x/mobile/exp/audio/al: Crash when running al.CloseDevice() on OSX | ### What version of Go are you using (`go version`)?
```
go version go1.7 darwin/amd64
```
### What operating system and processor architecture are you using (`go env`)?
Mac OS X 10.11.5
```
GOARCH="amd64"
GOBIN=""
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
GOPATH="/Users/ejf3/workspace/gowork"
GORACE=""
GOROOT="/usr/local/go"
GOTOOLDIR="/usr/local/go/pkg/tool/darwin_amd64"
CC="clang"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/zn/6y_5b8214sdg_1zzx907x3kh0000gn/T/go-build694490723=/tmp/go-build -gno-record-gcc-switches -fno-common"
CXX="clang++"
CGO_ENABLED="1"
```
### What did you do?
```
import (
"fmt"
"golang.org/x/mobile/exp/audio/al"
)
func main() {
fmt.Println("Hello, playground")
err := al.OpenDevice()
if err != nil {
fmt.Println("failed to open device " + err.Error())
return
}
defer al.CloseDevice()
}
```
The line `defer al.CloseDevice()` causes the crash. Removing that line allows the program to run without printing an error.
### What did you expect to see?
I expected not to see a crash.
### What did you see instead?
```
fatal error: unexpected signal during runtime execution
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x41f1927]
runtime stack:
runtime.throw(0x40ae810, 0x2a)
/usr/local/go/src/runtime/panic.go:566 +0x95
runtime.sigpanic()
/usr/local/go/src/runtime/sigpanic_unix.go:12 +0x2cc
goroutine 1 [syscall, locked to thread]:
runtime.cgocall(0x4080c00, 0xc420053e10, 0x0)
/usr/local/go/src/runtime/cgocall.go:131 +0x110 fp=0xc420053de0 sp=0xc420053da0
golang.org/x/mobile/exp/audio/al._Cfunc_alcDestroyContext(0x19)
golang.org/x/mobile/exp/audio/al/_obj/_cgo_gotypes.go:666 +0x41 fp=0xc420053e10 sp=0xc420053de0
golang.org/x/mobile/exp/audio/al.alcDestroyContext(0x19)
/Users/ejf3/workspace/gowork/src/golang.org/x/mobile/exp/audio/al/alc_notandroid.go:61 +0x75 fp=0xc420053e58 sp=0xc420053e10
golang.org/x/mobile/exp/audio/al.CloseDevice()
/Users/ejf3/workspace/gowork/src/golang.org/x/mobile/exp/audio/al/alc.go:70 +0xa9 fp=0xc420053e80 sp=0xc420053e58
main.main()
/Users/ejf3/workspace/gowork/src/ejf.io/gosoundwave/noise/noise.go:29 +0x3c7 fp=0xc420053f48 sp=0xc420053e80
runtime.main()
/usr/local/go/src/runtime/proc.go:183 +0x1f4 fp=0xc420053fa0 sp=0xc420053f48
runtime.goexit()
/usr/local/go/src/runtime/asm_amd64.s:2086 +0x1 fp=0xc420053fa8 sp=0xc420053fa0
goroutine 17 [syscall, locked to thread]:
runtime.goexit()
/usr/local/go/src/runtime/asm_amd64.s:2086 +0x1
```
This appears similar to the following two issues:
- [x/mobile/exp/audio/al: Flaky crash on Mac OS X](https://github.com/golang/go/issues/15075)
- [runtime: OpenReader: Invalid heap pointer in both 1.4rc2 and 1.4rc1](https://github.com/golang/go/issues/9191)
| mobile | low | Critical |
176,214,055 | rust | Unions interacting with Enum layout optimization | IRC (#rust) short discussion log, since I don't actually know much about this:
```
19:30 Amanieu: bluss: I had a look at nodrop-union, shouldn't you add another field to union with type () to inhibit the enum layout optimization?
19:31 Amanieu: admittedly the exact interactions between enums and unions is still somewhat poorly specified
19:31 bluss: Amanieu: good question. As it is now, that optimization is not used for unions
19:31 bluss: Amanieu: but I haven't checked the RFC discussions to see how it's going to be
19:32 Amanieu: I don't think this point was covered in the discussions
19:33 Amanieu: well, someone should probably open an issue about it
19:33 Amanieu: it's 2am here so I'll let someone else do that :P
19:34 bluss: it's 3am here, so I'm passing it on
```
cc @Amanieu @bluss
| A-codegen,T-lang,T-compiler,F-untagged_unions,A-enum | medium | Major |
176,216,261 | vscode | Trigger language auto detection mechanism | Some times I'm fetching some content from the web and pasting it into the current active editor.
So far, I didn't find any way to set the current language for the window. Is there any particular API call for that?
Even better, would it be possible to trigger the auto detection mechanism with the API?
| feature-request,api,languages-basic | medium | Major |
176,227,761 | opencv | Multithreaded connected component labeling implementation | This is an RFC for the implementation of a multithreaded version of the connected component labeling algorithm.
Such algorithms have appeared in research papers since a few years ago. A common theme in these approaches is to divide the image into blocks (tiles or strips), and then:
1. Perform labeling within each block, in parallel;
2. Let the main (caller) thread process the equivalence labeling of "seams" between blocks;
3. Update the labeling in each block to the final labeling, in parallel.
The second step is single-threaded. As a result there is a synchronization barrier before and after the second step.
---
I ask this question here instead of OpenCV Answers because it is not a beginner question, and I believe this is a feature that will eventually be implemented in (contributed to) OpenCV. A second reason I ask this is because I have implemented a proprietary version of it for my employer. I have secured the permissions to make a separate implementation for OpenCV provided that the implementation details in the contributed version can be fully traced to research work that has already been published.
I am aware of the existing connected component labeling implementation in OpenCV and has studied the algorithm. However, it is too early for me to say whether I will be able to keep the best of both implementations.
---
One minor detail is that my current (proprietary) implementation uses a more flexible definition of connectivity, one which is traditionally termed "flat-zones CCL". This flexible definition allows caller to specify two predicates:
1. isForeground ( point ) -> bool
2. isConnected ( pointOne, pointTwo ) -> bool
The foreground predicate is given the pixel value, and returns whether it will be assigned a label. All non-foreground pixels will be given a nondescript pseudo-label.
If two pixels are adjacent (according 4 or 8 neighborhood), and both pixels are foreground, then the connectivity predicate will be invoked. The two pixels will be connected if and only if all these conditions are satisfied.
The current OpenCV implementation corresponds to the imposed restrictions that:
1. Image must be CV_8UC1 or CV_8SC1
2. isForeground is currently hard-coded as Image(row, col) != 0
3. isConnected must return true, i.e. two pixels which are both foreground and adjacent, must be connected by definition.
(Note: in the current OpenCV implementation, Wu's implementation defines foreground as Image(row, col) != 0, whereas Grana's implementation defines foreground as Image(row, col) > 0. This difference may be pose problem for CV_8SC1 input image type.)
The significance of this flexibility is that it allows for the possibility that two pixels which are both foreground to be disconnected, by a suitable choice of connectivity predicate. This flexibility is required in the implementation of some image processing algorithms.
On the other hand, this predicate flexibility is incompatible with some CCL optimization techniques, such as Grana et al. For this reason, users who provide isConnected predicate should indicate whether it is a trivial implementation (one that always return true), so that all optimization techniques can be applied.
The predicate will need to be supplied as a functor to a class template.
---
I haven't started working on this second implementation yet; so I would like to solicit some feedback about the desirability of this feature before I start. Please feel free to ask questions.
I understand that performance benchmarks will help make an informed decision. Please feel free to suggest performance benchmark scenarios that I should test for.
| RFC | low | Major |
176,248,010 | youtube-dl | please support rtd.rt.com RT Documentaries | there is a download button, but I wish to have a automation on CLI
```
$ youtube-dl https://rtd.rt.com/films/911-the-peace-we-lost/#part-1 -v
[debug] System config: [u'--prefer-ffmpeg', u'--hls-prefer-native', u'-n']
[debug] User config: []
[debug] Command-line args: [u'https://rtd.rt.com/films/911-the-peace-we-lost/#part-1', u'-v']
[debug] Encodings: locale UTF-8, fs utf-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2016.09.08
[debug] Python version 2.7.10 - Darwin-15.6.0-x86_64-i386-64bit
[debug] exe versions: avconv 11.4, avprobe 11.4, ffmpeg 3.1.3, ffprobe 3.1.3
[debug] Proxy map: {'http': 'http://localhost:8118', 'https': 'http://localhost:8118'}
[generic] #part-1: Requesting header
WARNING: Falling back on generic information extractor.
[generic] #part-1: Downloading webpage
[generic] #part-1: Extracting information
WARNING: [generic] #part-1: Failed to parse JSON No JSON object could be decoded
[debug] Invoking downloader on u'https://rtd.rt.com/films/911-the-peace-we-lost/playlist.xml'
[download] Destination: 9_11. The Peace We Lost-playlist.xml
[download] 100% of 832.00B in 00:00
```
downloaded file
```
$ cat 9_11.\ The\ Peace\ We\ Lost-playlist.xml
<rss version="2.0" xmlns:media="http://search.yahoo.com/mrss/">
<channel>
<title>9/11. The Peace We Lost</title>
<item>
<title>Part 1</title>
<link>https://rtd.rt.com/films/911-the-peace-we-lost/#part-1</link>
<description>It’s 15 years since the 2001 terror attack on New York’s twin towers changed America forever. Thousands lost their lives or loved ones and many others lost their health. On that day though, everyone in the US lost something else; peace of mind. RT Doc asks how 9/11 transformed modern America’s world view.</description>
<pubDate>2016-09-09</pubDate>
<media:content url="https://rtd.rt.com/files/films/911-the-peace-we-lost/911-the-peace-we-lost_3.mp4" />
<media:thumbnail url="https://rtd.rt.com/files/films/911-the-peace-we-lost/911-the-peace-we-lost_5.jpg" />
</item>
</channel>
</rss>
```
| site-support-request | low | Critical |
176,334,047 | youtube-dl | Add support for Youku.com playlists | - [x] I've **verified** and **I assure** that I'm running youtube-dl **2016.09.11.1**
- [x] At least skimmed through [README](https://github.com/rg3/youtube-dl/blob/master/README.md) and **most notably** [FAQ](https://github.com/rg3/youtube-dl#faq) and [BUGS](https://github.com/rg3/youtube-dl#bugs) sections
- [x] [Searched](https://github.com/rg3/youtube-dl/search?type=Issues) the bugtracker for similar issues including closed ones
- [x] Feature request (request for a new functionality)
### Description of your _issue_, suggested solution and other information
Could you please add support for playlists on Youku.com? Example of a playlist with 161 videos: http://list.youku.com/albumlist/show?id=4405574 Another with 16 videos: http://list.youku.com/albumlist/show?id=4401438
| request | low | Critical |
176,447,538 | godot | Strange movement with move_and_slide() | **Operating system or device - Godot version:**
Xubuntu Linux 16.04, v2.2.alpha.custom_build, compiled from source.
**Issue description** (what happened, and what was expected):
I'm putting these issues as one as they are similar enough that I don't want to bombard the issue tracker with issues.
1) The character will "jump" up a little when moving upwards on a ramp when I let go of the movement key.
2) The character will "jump" a little bit when running against a wall while standing on a incline. Similar to problem 1.
3) If there is a moving platform that is shaped as a triangle, and the character is jumping from the bottom and in the same direction as the triangle platform and hits one of the edges while doing so, he will travel vertically upwards with the ramp edge, whereas he should simply fall down. (Also shown in video.)
Here's a video which explains and shows the issues: https://youtu.be/uFPI2GcmXrQ
The problem/problems I am talking about are from 0:00 to 1:29
**Steps to reproduce:**
Please watch link above.
**Link to minimal example project** (optional but very welcome):
[moveandslide_example.zip](https://github.com/godotengine/godot/files/468056/moveandslide_example.zip)
| bug,discussion,confirmed,topic:physics | medium | Critical |
176,469,059 | TypeScript | circular symlink breaks typescript intellisense | _From @bedorlan on September 9, 2016 13:47_
Steps to Reproduce:
1. Before creating symlink, intellisense works:
2. Inside some project folder, create symbolic link to parent folder
`$ ln -s ../../ baselibs`
3. Restart vscode
4. Now intellisense fails:
My project folder has 16942 files and 2944 folders. I try to reproduce the issue in a simpler folder structure, but i couldn't.
I also tried to ignore the symlink in the settings.json, but this doesn't fix the issue.
Gladly i'll provide more info.
- VSCode Version:
Versión 1.5.1
Confirmación 07d663dc1bd848161edf4cd4ce30cce410d3d877
Fecha 2016-09-08T21:34:58.760Z
Shell 0.37.6
Representador 49.0.2623.75
Node 5.10.0
- OS Version:
Linux os006724 4.6.0-1-amd64 #1 SMP Debian 4.6.4-1 (2016-07-18) x86_64 GNU/Linux
_Copied from original issue: Microsoft/vscode#11773_
| Bug,VS Code Tracked | low | Minor |
176,474,154 | opencv | Difference in return type of disparity map between normal StereoBM (CV_16S) vs CUDA StereoBM (CV_8UC1) | <!--
If you have a question rather than reporting a bug please go to http://answers.opencv.org where you get much faster responses.
If you need further assistance please read [How To Contribute](https://github.com/opencv/opencv/wiki/How_to_contribute).
This is a template helping you to create an issue which can be processed as quickly as possible. This is the bug reporting section for the OpenCV library.
-->
##### System information (version)
<!-- Example
- OpenCV => 3.1
- Operating System / Platform => Windows 64 Bit
- Compiler => Visual Studio 2015
-->
- OpenCV => 3.1
- Operating System / Platform => Windows 64 Bit
- Compiler => VC12
##### Detailed description
The normal version of StereoBM is set to give an assertion error if the output disparity map is not of type CV_16SC1 or CV_32FC1. However this is not the case with the CUDA implementation, which returns an CV_8UC1.
<!-- your description -->
##### Steps to reproduce
<!-- to add code example fence it with triple backticks and optional file extension
or attach as .txt or .zip file
-->
```
C:\opencv\sources\modules\calib3d\src\stereobm.cpp
void compute( InputArray leftarr, InputArray rightarr, OutputArray disparr )
{
int dtype = disparr.fixedType() ? disparr.type() : params.dispType;
Size leftsize = leftarr.size();
if (leftarr.size() != rightarr.size())
CV_Error( Error::StsUnmatchedSizes, "All the images must have the same size" );
if (leftarr.type() != CV_8UC1 || rightarr.type() != CV_8UC1)
CV_Error( Error::StsUnsupportedFormat, "Both input images must have CV_8UC1" );
if (dtype != CV_16SC1 && dtype != CV_32FC1)
CV_Error( Error::StsUnsupportedFormat, "Disparity image must have CV_16SC1 or CV_32FC1 format" );
----
----
}
C:\opencv\sources\modules\cudastereo\src\stereobm.cpp
void StereoBMImpl::compute(InputArray _left, InputArray _right, OutputArray _disparity, Stream& _stream)
{
using namespace ::cv::cuda::device::stereobm;
const int max_supported_ndisp = 1 << (sizeof(unsigned char) * 8);
CV_Assert( 0 < ndisp_ && ndisp_ <= max_supported_ndisp );
CV_Assert( ndisp_ % 8 == 0 );
CV_Assert( winSize_ % 2 == 1 );
GpuMat left = _left.getGpuMat();
GpuMat right = _right.getGpuMat();
CV_Assert( left.type() == CV_8UC1 );
CV_Assert( left.size() == right.size() && left.type() == right.type() );
_disparity.create(left.size(), CV_8UC1);
----
----
}
```
| feature,category: calib3d,affected: 3.4,category: gpu/cuda (contrib) | low | Critical |
176,495,117 | TypeScript | Docs on improving compilation speed | With the `--watch` flag on, a recompile of an existing file generally takes 4 seconds now in our project. This isn't terrible at all, but the wait time has grown since we started using it.
I was wondering what factors affect incremental compilation speed? With TypeScript gaining widespread adoption, I think it'll be very important to developer experience to have a doc page detailing the main contributors to incremental compilation time and ways to improve it.
P.S. Note I meant incremental compilation speed with `--watch`, not a full recompile.
| Docs | medium | Major |
176,495,964 | go | x/build: consider adding a linux builder with a newer kernel | Not entirely sure this is the appropriate form for this request, but well: the PIE internal linking stuff all passes on the builders (and Ubuntu 14.04) but breaks on new-ish linux (e.g. Ubuntu 16.04). I think this is probably a kernel version thing, so can we get a builder with a newer kernel?
| Builders,new-builder | low | Major |
176,504,842 | rust | "lifetime parameter is not constrained..." when using lifetime param to derive assoc. type from reference type trait impl | This works ([playpen](https://is.gd/bFeGb7)):
``` rust
use std::marker::PhantomData;
trait X {
type Q;
}
trait Y { }
struct Z<T> { t: PhantomData<T> }
impl<'a, T> X for Z<T> where T: 'a, &'a T: Y {
type Q = u8;
}
```
If instead we add an associated type `Z` to `Y` and try to write `type Q = <&'a T as Y>::Z;` in the `X` implementation, it fails with "error[E0207]: the lifetime parameter `'a` is not constrained by the impl trait, self type, or predicates" ([playpen](https://is.gd/CqJvsp):
``` rust
use std::marker::PhantomData;
trait X {
type Q;
}
trait Y {
type Z;
}
struct Z<T> { t: PhantomData<T> }
impl<'a, T> X for Z<T> where T: 'a, &'a T: Y {
type Q = <&'a T as Y>::Z;
}
```
Rust version: doesn't seem to matter; all of stable, beta, and nightly on play.rlo produce the same results.
Thanks to @QuietMisdreavus on IRC for helping with the reduced example.
| A-type-system,T-compiler,C-bug,T-types | low | Critical |
176,521,849 | TypeScript | Array inheritance in ES6 declaration file (lib.es6.d.ts) | ES6 supports Array inheritance, but this is not reflected in the TypeScript declaration file (lib.es6.d.ts).
Array functions like 'filter' and 'slice' return an array of the subclass, so the following should compile in TypeScript:
``` javascript
class MyArray extends Array {
get size() { return this.length; }
}
var x = new MyArray(10).slice();
x.size;
```
The functions 'reverse', 'concat', 'slice', 'splice', 'filter' should return with the type 'this'.
The 'map' function returns an instance of the subtype too, but it I don't know how that could be represented in TypeScript, as it would require a generic parameter in the return type, something like:
`map<U>(callback: (value: T, index: number, array: this) => U): this<U>`
Another issue is the static constructors of the Array class, this should compile too:
``` javascript
var x = MyArray.of(1,2,3);
var y = MyArray.from([1,2,3]);
x.size;
y.size;
```
There are also some additional complications added by the @@species Symbol, which can be used to change the type signature of the subclass to not use 'this' as the return value for functions like 'filter' and 'slice'. So for the following example, the subclass would work how the return types are defined in the declaration file currently:
``` javascript
class MyArray2 extends Array {
static get [Symbol.species]() { return Array; }
}
```
Chrome and Node.js both already implement the array inheritance features shown here.
| Suggestion,Help Wanted,Domain: lib.d.ts | low | Major |
176,561,109 | kubernetes | more metrics for API Storage | @wojtek-t and I have a discussion around etcd backend performance. We have some guess about why etcd drops watchers. But I think it would be great if we can expose more metrics to do white box monitoring. Also for etcd3 backend, there is no metrics.
Then we have more data and more confidence.
Some example metrics I can think of beside the existing ones in etcd2:
1. latest_revision
2. latest_watched_revision
3. number of watchers
/cc @wojtek-t do you think this is a good idea?
| sig/scalability,lifecycle/frozen | low | Major |
176,564,621 | opencv | VideoCapture multiple threading Segmentation Fault in ubuntu but fine in mac os | OpenCV => 3.1
Operating System / Platform => Linux ubuntu 16.04
Compiler => g++ (GCC) 5.3.0
VideoCapture multiple threading Segmentation Fault, or **\* Error in `./a.out': double free or corruption (fasttop): 0x00007eff64001c60 ***, the code is [here](https://github.com/KeyKy/issue/blob/master/videoCapture_multi_threading.cpp).
while in
OpenCV => 3.1
Operating System / Platform => Mac OSX 10.11.5
Compiler => Apple LLVM version 7.3.0
VideoCapture multiple threading works fine.
| category: videoio,category: 3rdparty | low | Critical |
176,573,758 | go | x/net/trace: add GetSpanId and GetTraceId for cross-request tracking. | In our gRPC and in HTTP handlers we're using request IDs in headers to correlate the tree of requests that "spawn" out of an original request.
Golang has an awesome `/debug/requests` and `/debug/events`, which are incredibly helpful, especially for gRPC.
Ideally, we'd move from our custom middleware/interceptors that we use with request ID to propagate (in our internal network) as trace spans. Unfortunately, you cannot read the trace ID in order for it to be serialized into headers. This would make it possible to have a consistent view of request IDs in our logs and `/debug/requests`.
Also it would make it easier to ship stuff to ~~Dapper~~[Cloud Trace](https://github.com/GoogleCloudPlatform/google-cloud-go/blob/master/trace/trace.go) :)
| NeedsInvestigation,FeatureRequest | low | Critical |
176,615,904 | react | [bug] click not disabled on <fieldset disabled><button onClick={() => alert('clicked')}><span>click me</span></button></fieldset> | **bug**
In the following
``` jsx
const Component = () =>
<fieldset disabled>
<button
onClick={() => alert('clicked by React')}
>click me here and <span style={{color: 'red'}}>here</span></button>
</fieldset>;
```
clicking on `click me here and` will not trigger `alert('clicked by React')` whereas clicking on the red `here` will trigger `alert('clicked by React')`.
Demo: https://jsfiddle.net/ropbvL3y/
Thanks for React, it's an incredibly well designed tool.
| Type: Bug,Component: DOM | medium | Critical |
176,617,681 | opencv | Python interface does not report missing parameters | ##### System information (version)
- OpenCV => 3.1
- Operating System / Platform => Linux 64 Bit
- Compiler => gcc
##### Detailed description
The function `calcOpticalFlowFarneback` offers a flag: `OPTFLOW_USE_INITIAL_FLOW`, which when set needs an additional input field `flow`. If this flag is set, but the parameter is not given, the function acts non-deterministic and returns mostly garbage. Identifying this problem took me quite some time.
##### Expected behaviour
There should be an error message stating:
"The field `flow` is not given, but expected, as `OPTFLOW_USE_INITIAL_FLOW` is set"
##### Steps to reproduce
```
import numpy as np
import cv2
image1 = np.random.rand(100,100)
image2 = np.random.rand(100,100)
flow = cv2.calcOpticalFlowFarneback(image1, image2,
pyr_scale=0.5, levels=3,
winsize=15, iterations=3,
poly_n=5, poly_sigma=1.2,
flags=cv2.OPTFLOW_USE_INITIAL_FLOW)
# flow now contains garbage.
```
| bug,category: python bindings,category: video | low | Critical |
176,644,234 | go | runtime: expose number of running/runnable goroutines | ### Summary
I'd like to propose a way to expose the number of active (running + runnable) goroutines.
### Background
My primary use case for this metric is to estimate application load (`num-active-goroutines / num-cpu`) in order to implement load shedding. Other metrics, like the `times()` syscall, don't expose application overload and don't work well in the presence of noisy neighbours.
### Plan
Currently the runtime package includes `runtime.NumGoroutine() int` which returns the number of live, non-system goroutines.
The runtime package could be extended to include `runtime.NumActiveGoroutine() int`. `NumActiveGoroutine()` should count all goroutines where `isSystemGoroutine()` is false and where status is `_Grunnable|_Grunning|_Gsyscall`.
It seems that such a function would need to acquire `sched.lock` and `allglock`. This could have some performance implications.
| NeedsFix,early-in-cycle | medium | Major |
176,679,249 | youtube-dl | Site Request: dailydrip.com | ## Please follow the guide below
- You will be asked some questions and requested to provide some information, please read them **carefully** and answer honestly
- Put an `x` into all the boxes [ ] relevant to your _issue_ (like that [x])
- Use _Preview_ tab to see how your issue will actually look like
---
### Make sure you are using the _latest_ version: run `youtube-dl --version` and ensure your version is _2016.09.11.1_. If it's not read [this FAQ entry](https://github.com/rg3/youtube-dl/blob/master/README.md#how-do-i-update-youtube-dl) and update. Issues with outdated version will be rejected.
- [X] I've **verified** and **I assure** that I'm running youtube-dl **2016.09.11.1**
### Before submitting an _issue_ make sure you have:
- [X] At least skimmed through [README](https://github.com/rg3/youtube-dl/blob/master/README.md) and **most notably** [FAQ](https://github.com/rg3/youtube-dl#faq) and [BUGS](https://github.com/rg3/youtube-dl#bugs) sections
- [X] [Searched](https://github.com/rg3/youtube-dl/search?type=Issues) the bugtracker for similar issues including closed ones
### What is the purpose of your _issue_?
- [ ] Bug report (encountered problems with youtube-dl)
- [X] Site support request (request for adding support for a new site)
- [ ] Feature request (request for a new functionality)
- [ ] Question
- [ ] Other
---
`youtube-dl` is able to download the free videos without an issue from dailydrip.com (as expected), but is unable to authenticate to download the paid. I've tried using the cookie, but am still unable to download.
| site-support-request,account-needed | low | Critical |
176,720,605 | javascript | no-global-assign should include all browser global variables when environment is browser | We're using Airbnb style guide. Today I faced a bug that root of it was the fact that I had a variable named `location` which is a global object available in browser. So instead of getting `variable not defined: location` ESLint just passed.
[no-global-assign](http://eslint.org/docs/rules/no-global-assign) accepts an array of variable names that should be forbidden to use. All variable names like `location`, `document`, `window` and `navigator` should be in the blacklist as variable names.
| question | low | Critical |
176,754,513 | kubernetes | kubeconfig lock files change behavior of KUBECONFIG | Previously, if KUBECONFIG pointed to an empty directory that you don't have permission to write to, config would safely ignore that directory in its load path. Now, the lock file raises a permission denied error which prevents normal operations from passing.
To recreate against 1.4
```
sudo mkdir /foo
KUBECONFIG=/foo/foo.config go test ./pkg/kubectl/cmd/config
# error is because of a lock failure, we don't print the error in the test
```
In 1.2:
```
git checkout origin/release-1.3
```
This is a regression and causes old clients to break when they upgrade to 1.4 - if you had a KUBECONFIG before that pointed to a dir you can't write to, we can't fail.
| priority/important-soon,area/kubectl,sig/api-machinery,lifecycle/frozen | low | Critical |
176,835,648 | youtube-dl | Walla is not working | ## Please follow the guide below
- You will be asked some questions and requested to provide some information, please read them **carefully** and answer honestly
- Put an `x` into all the boxes [ ] relevant to your _issue_ (like that [x])
- Use _Preview_ tab to see how your issue will actually look like
---
### Make sure you are using the _latest_ version: run `youtube-dl --version` and ensure your version is _2016.09.11.1_. If it's not read [this FAQ entry](https://github.com/rg3/youtube-dl/blob/master/README.md#how-do-i-update-youtube-dl) and update. Issues with outdated version will be rejected.
- [x] I've **verified** and **I assure** that I'm running youtube-dl **2016.09.11.1**
### Before submitting an _issue_ make sure you have:
- [x] At least skimmed through [README](https://github.com/rg3/youtube-dl/blob/master/README.md) and **most notably** [FAQ](https://github.com/rg3/youtube-dl#faq) and [BUGS](https://github.com/rg3/youtube-dl#bugs) sections
- [x] [Searched](https://github.com/rg3/youtube-dl/search?type=Issues) the bugtracker for similar issues including closed ones
### What is the purpose of your _issue_?
- [x] Bug report (encountered problems with youtube-dl)
- [ ] Site support request (request for adding support for a new site)
- [ ] Feature request (request for a new functionality)
- [ ] Question
- [ ] Other
---
### The following sections concretize particular purposed issues, you can erase any section (the contents between triple ---) not applicable to your _issue_
---
### If the purpose of this _issue_ is a _bug report_, _site support request_ or you are not completely sure provide the full verbose output as follows:
Add `-v` flag to **your command line** you run youtube-dl with, copy the **whole** output and insert it here. It should look similar to one below (replace it with **your** log inserted between triple ```):
```
youtube-dl -v http://vod.walla.co.il/episode/1867679/srugim/season-3/episode-1
[debug] System config: []
[debug] User config: []
[debug] Command-line args: [u'-v', u'http://vod.walla.co.il/episode/1867679/srugim/season-3/episode-1']
[debug] Encodings: locale UTF-8, fs UTF-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2016.09.11.1
[debug] Python version 2.7.12 - Linux-4.4.0-36-generic-x86_64-with-Ubuntu-16.04-xenial
[debug] exe versions: ffmpeg 2.8.6-1ubuntu2, ffprobe 2.8.6-1ubuntu2, rtmpdump 2.4
[debug] Proxy map: {}
[Walla] srugim/season-3/episode-1: Downloading XML
ERROR: No video formats found; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see https://yt-dl.org/update on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
Traceback (most recent call last):
File "/usr/lib/python2.7/dist-packages/youtube_dl/YoutubeDL.py", line 691, in extract_info
ie_result = ie.extract(url)
File "/usr/lib/python2.7/dist-packages/youtube_dl/extractor/common.py", line 347, in extract
return self._real_extract(url)
File "/usr/lib/python2.7/dist-packages/youtube_dl/extractor/walla.py", line 75, in _real_extract
self._sort_formats(formats)
File "/usr/lib/python2.7/dist-packages/youtube_dl/extractor/common.py", line 911, in _sort_formats
raise ExtractorError('No video formats found')
ExtractorError: No video formats found; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see https://yt-dl.org/update on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
...
<end of log>
```
### Description of your _issue_, suggested solution and other information
Walla VOD (http://vod.walla.co.il/) not working
| geo-restricted | low | Critical |
176,956,100 | go | x/build: meta bug tracking trybot build speed (goal: 15 minutes; further improvements are blocked on completing LUCI migration and robust metrics) | *Updated in 2021:* The goal is to make most trybot runs take complete within the time specified in the issue subject. It's currently blocked on creating a mechanism to systematically measure and track TryBot completion time.
*Updated in 2024:* Also blocked on finishing the build system migration to LUCI. | Builders,NeedsInvestigation,umbrella | medium | Critical |
176,967,484 | go | cmd/compile: combine contiguous multi-byte comparisons to a constant | On architectures that allow unaligned loads, we should rewrite `b[0] == c1 && b[1] == c2` to `*(*uint16)(&b[0]) == (c1 << 8) + c2`. And do all architectures for cases in which we know b[0] is appropriately aligned. Also uint32 and uint64 (as appropriate).
See CL 26758 for more discussion; that CL will cause many of these to be generated.
We might also independently want to update the front end (near OCMPSTR) to generate the larger comparisons directly.
``` go
package p
import "testing"
var (
sink bool
b1, b2 byte
)
func Benchmark8(b *testing.B) {
for i := 0; i < b.N; i++ {
sink = b1 == 5 && b2 == 9
}
}
func Benchmark16(b *testing.B) {
u16 := uint16(b1<<8) + uint16(b2)
const c16 = (5 << 8) + 9
for i := 0; i < b.N; i++ {
sink = u16 == c16
}
}
```
```
Benchmark8-8 2000000000 0.99 ns/op
Benchmark16-8 2000000000 0.68 ns/op
```
| Performance,compiler/runtime | low | Minor |
176,985,346 | three.js | Feature: HDR cubemap from a single file | In the example [materials / envmaps / hdr](http://threejs.org/examples/webgl_materials_envmaps_hdr.html), a cubemap is textured using six `.hdr` files, using [`HDRCubeTextureLoader`](http://threejs.org/examples/js/loaders/HDRCubeTextureLoader.js). How about texturing a cubemap from a single `.hdr` file?
| Enhancement | low | Major |
177,023,216 | go | cmd/compile: avoid reloads of temp register on ppc64le, others | Please answer these questions before submitting your issue. Thanks!
### What version of Go are you using (`go version`)?
go version devel +9fcbde7 Wed Sep 14 10:07:17 2016 -0500 linux/ppc64le
### What operating system and processor architecture are you using (`go env`)?
Ubuntu 16.04 ppc64le
### What did you do?
Built the test from the math package, then inspected the objdump.
### What did you expect to see?
Looking for opportunities for improvement.
### What did you see instead?
In main.main, this code is generated:
111c8: 1f 00 e0 3f lis r31,31
111cc: 98 29 9f e8 ld r4,10648(r31)
111d0: 1f 00 e0 3f lis r31,31
111d4: 90 29 bf e8 ld r5,10640(r31)
111d8: 1f 00 e0 3f lis r31,31
111dc: e0 29 df e8 ld r6,10720(r31)
111e0: 1f 00 e0 3f lis r31,31
111e4: d8 29 ff e8 ld r7,10712(r31)
111e8: 1f 00 e0 3f lis r31,31
111ec: d0 29 1f e9 ld r8,10704(r31)
111f0: 1f 00 e0 3f lis r31,31
111f4: a0 29 3f e9 ld r9,10656(r31)
111f8: 1f 00 e0 3f lis r31,31
111fc: b0 29 5f e9 ld r10,10672(r31)
11200: 1f 00 e0 3f lis r31,31
11204: b8 29 7f e9 ld r11,10680(r31)
11208: 1f 00 e0 3f lis r31,31
1120c: c0 29 9f e9 ld r12,10688(r31)
r31 is reloaded each time with the same value. I believe this happens because this is a MOVD based on SB which implicitly generates two instructions, and uses r31 for the temp register and possibly that is not visible to the register allocator.
| Performance,NeedsFix,compiler/runtime | medium | Major |
177,032,229 | kubernetes | openapi static init is 50% of startup time for binary that links to it | `github.com/go-openapi/spec` calls MustLoadSwagger20Schema which loads an asset via JSON unmarshal on every init. Anything that pulls in that dependency (genericapiserver, which is a lot) will get slower (hyperkube, and maybe kubectl if it accidentally pulls it in).
Looks like we'll need to support a patch upstream to make it lazy.
| priority/important-soon,area/apiserver,sig/api-machinery,lifecycle/frozen | low | Major |
177,041,425 | rust | Exposure of HashMap iteration order allows for O(n²) blowup. | Exposing `HashMap`'s iteration order can cause `O(n²)` blowup even in innocent-looking code _without_ the presence of an attacker. In the presence of an attacker, access to the order of a dictionary allows HashDoS-like attacks with only two requests in common scenarios.
## Without an attacker
Consider a user with two possibly-disjoint hash maps
```
let first_map: HashMap<u64, _> = (0..900000).map(|i| (i, ())).collect();
let second_map: HashMap<u64, _> = (900000..1800000).map(|i| (i, ())).collect();
```
The user wants to merge the hash maps, and does so naïvely,
```
let mut merged = first_map;
merged.extend(second_map);
```
Time for merge when `second_map` is shuffled: **0.4s**
Time for merge when `second_map` is not shuffled: **40.s** (x100 amplification)
This effect is noticeably more pronounced when merging with a round robin strategy.
## With an attacker
The threat model here is simple. The attacker is able to send JSON to the server. The server parses the JSON into a `HashMap` and through whatever means - an error message including the formatted map or explicit listing of the contents of the map - may reveal the order of the map.
The attack on this model requires two requests. The first sends some large JSON to the server
```
let first_request: HashMap<u64, _> = (0..900000).map(|i| (i, ())).collect();
```
and recieves an ordering
```
let returned_data: Vec<_> = first_request.into_iter().collect();
```
The attacker then sends the first and third quarter of this list in a new JSON object.
```
let second_request: HashMap<u64, _> =
returned_data[..225000].iter()
.chain(&returned_data[450000..675000])
.cloned().collect();
```
Total time _without_ second request: **0.1s**
Total time _with_ second request: **200s** (x2000 amplification)
---
## Solutions, near-solutions and non-solutions
These solutions should not be considered to be ordered, necessarily disjoint, nor an exhaustive list of options.
### Fall back to `BTreeMap`
It should be clear that we cannot treat hash maps as a solved problem just because we use `SipHash`. In fact, `SipHash` is entirely insufficient to solve the problem. My first suggestion is thus to stop trying to make the hasher secure, and instead fall back to `BTreeMap` when nonlinear behaviour is detected.
This guarantees a minimum level of performance regardless of the capabilities of the attacker, and allows usage of a faster hashing algorithm by default. Hash maps should get faster by default as a result. This does not prevent having to consider the issue, since the fallback is costly and must be rare, but this is an easier problem than entirely securing the hash map.
### Use a hash map without problematic blowup, or less affected by it
Java solves this problem by using a hash map with chaining and converting large buckets to tree maps. This mitigates the impact of degradation, but does not seem to allow using contiguous hash maps by default.
As far as I am aware, the blowup cannot be resolved by moving to another common form of open addressing, although quadratic probing would be significantly less affected by some of these attacks. Chaining alone also defeats the attacks given here, but still requires a secure hash and fails with attackers with more capabilities.
### Use different seeds for each hash map
Pull requests #31356 (closed) and #33318 (merged) first proposed incrementing the thread local seed for each hash map. This was later removed when no threat model was seen, but would prevent both attacks listed here.
This still allows attacks when hash maps are reused.
### Randomize iteration order
I am not sure how one would randomize iteration order efficiently. However, it should solve the problem unless hashes are exposed through other means.
### Ignore the problem
Given that Rust went so far as to use `SipHash`, quadratic blowup on code as simple as `fst.extend(snd)` seems too extreme to ignore.
| P-medium,A-collections,T-libs-api,C-bug | high | Critical |
177,215,281 | go | math: Lgamma got slower from Go 1.6 to Go 1.7 | Please answer these questions before submitting your issue. Thanks!
### What version of Go are you using (`go version`)?
go1.6.3, go version devel +8086e7c
### What operating system and processor architecture are you using (`go env`)?
```
GOARCH="amd64"
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
CC="gcc"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build584510834=/tmp/go-build -gno-record-gcc-switches"
CXX="g++"
CGO_ENABLED="1"
```
### What did you do?
Investigating slowdown of Lgamma benchmark.
1.6 vs 1.7 gives:
name old time/op new time/op delta
Lgamma-4 11.9ns ± 0% 14.2ns ± 0% +19.33% (p=0.000 n=29+29)
It might be compiler issue(code not changed). Looking into objdump of lgamma function for both versions I see different instruction order and registers used:
In 1.7:
```
REPNE MOVSD_XMM 0x14a4b5(IP), X3
REPNE MOVSD_XMM 0x14a4bd(IP), X5
REPNE MOVSD_XMM 0x14a4c5(IP), X6
REPNE MOVSD_XMM 0x14a4cd(IP), X7
REPNE MOVSD_XMM 0x14a4d4(IP), X8
REPNE MOVSD_XMM 0x14a4db(IP), X9
REPNE MULSD X4, X9
REPNE ADDSD X9, X8
REPNE MULSD X4, X8
REPNE ADDSD X8, X7
REPNE MULSD X4, X7
REPNE ADDSD X7, X6
REPNE MULSD X4, X6
...
```
In 1.6:
```
REPNE MOVSD_XMM 0x1f94c0(IP), X0
REPNE MOVSD_XMM 0x1f94c0(IP), X1
REPNE MULSD X3, X1
REPNE ADDSD X1, X0
REPNE MULSD X3, X0
REPNE MOVSD_XMM 0x1f949c(IP), X1
REPNE ADDSD X1, X0
REPNE MULSD X3, X0
REPNE MOVSD_XMM 0x1f9484(IP), X1
REPNE ADDSD X1, X0
REPNE MULSD X3, X0
...
```
Tried force scheduler to generate instruction order like in 1.6
(for that expanded all expressions like `p1 := _lgamT[0] + w_(_lgamT[3]+w_(_lgamT[6]+w_(_lgamT[9]+w__lgamT[12])))` with tmp variables).
But result was still bad:
name old time/op new time/op delta
Lgamma-4 11.9ns ± 0% 13.1ns ± 0% +10.08% (p=0.000 n=29+19)
Also tried to generate random registers - no much effect:
name old time/op new time/op delta
Lgamma-4 11.9ns ± 0% 13.5ns ± 0% +13.45% (p=0.000 n=29+10)
| Performance,help wanted,NeedsInvestigation | low | Critical |
177,227,230 | go | build: provide a mechanism to disable architectures? | For build speed & binary size reasons, I would like to run make.bash with certain architectures disabled.
(my motivation: when I'm cross-compiling an ARM toolchain from Linux for #17105, there's no need for ppc64, mips64, s390x, arm64, 386, or even amd64 in my resulting binaries)
I started a prototype in https://golang.org/cl/29230 which defines build tags like "without_ppc64", "without_386", "without_s390x", etc.
The compiler and linker were easy. I decided to wait on `cmd/asm` until more discussion.
What do people think of something like this?
/cc @ianlancetaylor @mdempsky @randall77 @robpike @griesemer @josharian @rsc
| help wanted,NeedsInvestigation,FeatureRequest | low | Major |
177,233,694 | angular | Better Typing for `forwardRef` and `resolveForwardRef` | We have a fix but wanted to make sure a pull request for `forwardRef` would be accepted. It's marked as`@experimental`, are there any plans to change it?
**I'm submitting a ...** (check one with "x")
```
[x] bug report => search github for a similar issue or PR before submitting
[ ] feature request
[ ] support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question
```
**Current behavior**
When using `forwardRef` and `resolveForwardRef`, types will not be tracked.
```
class MyType {}
let myForwardRef = forwardRef(() => MyType);
resolveForwardRef(myForwardRef) //=> any
```
**Expected behavior**
```
class MyType {}
let myForwardRef = forwardRef(() => MyType);
resolveForwardRef(myForwardRef) //=> MyType
```
**Reproduction of the problem**
Just import `forwardRef` and `resolveForwardRef` and observe the types in a supporting editor
**What is the motivation / use case for changing the behavior?**
To keep code type-safe and tooling effective
**Please tell us about your environment:**
MacOS Sierra 10.12, VSCode
- **Angular version:** 2.0.0-rc.7
- **Browser:** N/A
- **Language:** TypeScript 2.0.2
- **Node (for AoT issues):** N/A
| type: bug/fix,breaking changes,freq1: low,area: core,P4 | low | Critical |
177,245,083 | youtube-dl | [techtalks] Add support for authentication | ### Make sure you are using the _latest_ version: run `youtube-dl --version` and ensure your version is _2016.09.15_. If it's not read [this FAQ entry](https://github.com/rg3/youtube-dl/blob/master/README.md#how-do-i-update-youtube-dl) and update. Issues with outdated version will be rejected.
- [x] I've **verified** and **I assure** that I'm running youtube-dl **2016.09.15**
### Before submitting an _issue_ make sure you have:
- [x] At least skimmed through [README](https://github.com/rg3/youtube-dl/blob/master/README.md) and **most notably** [FAQ](https://github.com/rg3/youtube-dl#faq) and [BUGS](https://github.com/rg3/youtube-dl#bugs) sections
- [x] [Searched](https://github.com/rg3/youtube-dl/search?type=Issues) the bugtracker for similar issues including closed ones
### What is the purpose of your _issue_?
- [x] Bug report (encountered problems with youtube-dl)
- [ ] Site support request (request for adding support for a new site)
- [x] Feature request (request for a new functionality)
- [ ] Question
- [ ] Other
---
```
$ youtube-dl -v -u PRIVATE -p PRIVATE http://techtalks.tv/talks/lecture-sep-14th-2/61647
[debug] System config: []
[debug] User config: []
[debug] Command-line args: ['-v', '-u', 'PRIVATE', '-p', 'PRIVATE', 'http://techtalks.tv/talks/lecture-sep-14th-2/61647']
[debug] Encodings: locale UTF-8, fs utf-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2016.09.15
[debug] Python version 3.5.2 - Darwin-15.6.0-x86_64-i386-64bit
[debug] exe versions: ffmpeg 2.8.6, ffprobe 2.8.6
[debug] Proxy map: {}
[generic] 61647: Requesting header
[redirect] Following redirect to http://techtalks.tv/account/login/?next=/talks/lecture-sep-14th-2/61647/
[generic] 61647: Requesting header
WARNING: Falling back on generic information extractor.
[generic] 61647: Downloading webpage
[generic] 61647: Extracting information
ERROR: Unsupported URL: http://techtalks.tv/account/login/?next=/talks/lecture-sep-14th-2/61647/
Traceback (most recent call last):
File "/usr/local/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 694, in extract_info
ie_result = ie.extract(url)
File "/usr/local/bin/youtube-dl/youtube_dl/extractor/common.py", line 347, in extract
return self._real_extract(url)
File "/usr/local/bin/youtube-dl/youtube_dl/extractor/generic.py", line 2393, in _real_extract
raise UnsupportedError(url)
youtube_dl.utils.UnsupportedError: Unsupported URL: http://techtalks.tv/account/login/?next=/talks/lecture-sep-14th-2/61647/
```
| account-needed | low | Critical |
177,312,565 | youtube-dl | [redtube] Extract categories and tags | ## Please follow the guide below
- You will be asked some questions and requested to provide some information, please read them **carefully** and answer honestly
- Put an `x` into all the boxes [ ] relevant to your _issue_ (like that [x])
- Use _Preview_ tab to see how your issue will actually look like
---
### Make sure you are using the _latest_ version: run `youtube-dl --version` and ensure your version is _2016.09.15_. If it's not read [this FAQ entry](https://github.com/rg3/youtube-dl/blob/master/README.md#how-do-i-update-youtube-dl) and update. Issues with outdated version will be rejected.
- [x ] I've **verified** and **I assure** that I'm running youtube-dl **2016.09.15**
### Before submitting an _issue_ make sure you have:
- [x] At least skimmed through [README](https://github.com/rg3/youtube-dl/blob/master/README.md) and **most notably** [FAQ](https://github.com/rg3/youtube-dl#faq) and [BUGS](https://github.com/rg3/youtube-dl#bugs) sections
- [x] [Searched](https://github.com/rg3/youtube-dl/search?type=Issues) the bugtracker for similar issues including closed ones
### What is the purpose of your _issue_?
- [ ] Bug report (encountered problems with youtube-dl)
- [ ] Site support request (request for adding support for a new site)
- [x] Feature request (request for a new functionality)
- [ ] Question
- [x] Other
---
### verbose output as follows:
$ youtube-dl -v
[debug] System config: []
[debug] User config: []
[debug] Command-line args: [u'-v', u'http://www.redtube.com/1622217']
[debug] Encodings: locale cp1251, fs mbcs, out cp866, pref cp1251
[debug] youtube-dl version 2016.09.15
[debug] Python version 3.4.4 - Windows-10-10.0.10586
[debug] exe versions: none
[debug] Proxy map: {}
### example URLs :
http://www.redtube.com/1622217
### Description of your _issue_, suggested solution and other information
Metadata like "categories" and "tags" are not included when downloading videos from redtube.com
This is most likely to be solved if 'categories': list, or 'tags': list, will be added to current extractor command.
| request,nsfw | low | Critical |
177,353,271 | youtube-dl | youtube-dl complains about outdated avconv on Debian | ### Make sure you are using the _latest_ version: run `youtube-dl --version` and ensure your version is _2016.09.15_. If it's not read [this FAQ entry](https://github.com/rg3/youtube-dl/blob/master/README.md#how-do-i-update-youtube-dl) and update. Issues with outdated version will be rejected.
- [x] I've **verified** and **I assure** that I'm running youtube-dl **2016.09.15**
### Before submitting an _issue_ make sure you have:
- [x] At least skimmed through [README](https://github.com/rg3/youtube-dl/blob/master/README.md) and **most notably** [FAQ](https://github.com/rg3/youtube-dl#faq) and [BUGS](https://github.com/rg3/youtube-dl#bugs) sections
- [x] [Searched](https://github.com/rg3/youtube-dl/search?type=Issues) the bugtracker for similar issues including closed ones
### What is the purpose of your _issue_?
- [ ] Bug report (encountered problems with youtube-dl)
- [ ] Site support request (request for adding support for a new site)
- [x] Feature request (request for a new functionality)
- [ ] Question
- [ ] Other
---
### The following sections concretize particular purposed issues, you can erase any section (the contents between triple ---) not applicable to your _issue_
---
### If the purpose of this _issue_ is a _bug report_, _site support request_ or you are not completely sure provide the full verbose output as follows:
Add `-v` flag to **your command line** you run youtube-dl with, copy the **whole** output and insert it here. It should look similar to one below (replace it with **your** log inserted between triple ```):
```
$ ./youtube-dl -v 'http://www.cc.com/full-episodes/oqhari/the-daily-show-with-trevor-noah-september-14--2016---hannah-hart-season-21-ep-21153'
[debug] System config: []
[debug] User config: []
[debug] Command-line args: [u'-v', u'http://www.cc.com/full-episodes/oqhari/the-daily-show-with-trevor-noah-september-14--2016---hannah-hart-season-21-ep-21153']
[debug] Encodings: locale UTF-8, fs UTF-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2016.09.15
[debug] Python version 2.7.9 - Linux-4.5.0-0.bpo.2-amd64-x86_64-with-debian-8.5
[debug] exe versions: avconv 2.6.9, avprobe 2.6.9, ffmpeg 2.6.9, ffprobe 2.6.9, rtmpdump 2.4
[debug] Proxy map: {}
[ComedyCentral] the-daily-show-with-trevor-noah-september-14--2016---hannah-hart-season-21-ep-21153: Downloading webpage
[ComedyCentral] 6a95eb1a-bf13-453a-97c2-dbb01e774f4a: Downloading info
[ComedyCentral] 98bf6757-1d25-4585-94de-0a4b42dbc077: Extracting information
[ComedyCentral] 98bf6757-1d25-4585-94de-0a4b42dbc077: Downloading video urls
[ComedyCentral] be5b7144-a6e2-4efc-9265-d1f91a7adc95: Extracting information
[ComedyCentral] be5b7144-a6e2-4efc-9265-d1f91a7adc95: Downloading video urls
[ComedyCentral] 66615bd2-93f8-4a9e-ab19-fadc642257a0: Extracting information
[ComedyCentral] 66615bd2-93f8-4a9e-ab19-fadc642257a0: Downloading video urls
[ComedyCentral] a6e78047-c0cb-4162-9a13-455af372d1cb: Extracting information
[ComedyCentral] a6e78047-c0cb-4162-9a13-455af372d1cb: Downloading video urls
[download] Downloading playlist: September 14, 2016 - Hannah Hart
[ComedyCentral] playlist September 14, 2016 - Hannah Hart: Collected 4 video ids (downloading 4 of them)
[download] Downloading video 1 of 4
WARNING: Your copy of avconv is outdated and unable to properly mux separate video and audio files, youtube-dl will download single file media. Update avconv to version 10-0 or newer to fix this.
[debug] Invoking downloader on u'http://viacommtvstrmfs.fplive.net/gsp.comedystor/com/dailyshow/TDS/Season_21/21153/ds_21_153_act1_2a0gi8r18t_1920x1080_5128.mp4'
[download] The Daily Show with Trevor Noah_September 14, 2016_21_21153_September 14, 2016 - Hannah Hart_Act 1-98bf6757-1d25-4585-94de-0a4b42dbc077.mp4 has already been downloaded
[download] 100% of 234.77MiB
[download] Downloading video 2 of 4
WARNING: Your copy of avconv is outdated and unable to properly mux separate video and audio files, youtube-dl will download single file media. Update avconv to version 10-0 or newer to fix this.
[debug] Invoking downloader on u'http://viacommtvstrmfs.fplive.net/gsp.comedystor/com/dailyshow/TDS/Season_21/21153/ds_21_153_act2_ltrb8juyp2_1920x1080_5128.mp4'
[download] The Daily Show with Trevor Noah_September 14, 2016_21_21153_September 14, 2016 - Hannah Hart_Act 2-be5b7144-a6e2-4efc-9265-d1f91a7adc95.mp4 has already been downloaded
[download] 100% of 167.62MiB
[download] Downloading video 3 of 4
WARNING: Your copy of avconv is outdated and unable to properly mux separate video and audio files, youtube-dl will download single file media. Update avconv to version 10-0 or newer to fix this.
[debug] Invoking downloader on u'http://viacommtvstrmfs.fplive.net/gsp.comedystor/com/dailyshow/TDS/Season_21/21153/ds_21_153_act3_d20heeqqlf_1920x1080_5128.mp4'
[download] The Daily Show with Trevor Noah_September 14, 2016_21_21153_September 14, 2016 - Hannah Hart_Act 3-66615bd2-93f8-4a9e-ab19-fadc642257a0.mp4 has already been downloaded
[download] 100% of 174.49MiB
[download] Downloading video 4 of 4
WARNING: Your copy of avconv is outdated and unable to properly mux separate video and audio files, youtube-dl will download single file media. Update avconv to version 10-0 or newer to fix this.
[debug] Invoking downloader on u'http://viacommtvstrmfs.fplive.net/gsp.comedystor/com/dailyshow/TDS/Season_21/21153/ds_21_153_act4_10jl2re3zw_1920x1080_5128.mp4'
[download] The Daily Show with Trevor Noah_September 14, 2016_21_21153_September 14, 2016 - Hannah Hart_Act 4-a6e78047-c0cb-4162-9a13-455af372d1cb.mp4 has already been downloaded
[download] 100% of 94.59MiB
[download] Finished downloading playlist: September 14, 2016 - Hannah Hart
```
---
### Description of your _issue_, suggested solution and other information
On Debian, avconv and friends get symlinked to ffmpeg when you have ffmpeg installed, instead of libav.
youtube-dl therefore tries to use avconv preferentially by default, but notices the version string is not what it would prefer, yielding things like the above log, where it concludes the version of avconv is stale, and changes its behavior.
I can work around this by defining --prefer-ffmpeg in ~/.config/youtube-dl.conf, but it would be nice if youtube-dl could, in addition to parsing the version string out of the first line of the {av,ff}\* utilities, parse the utility name out of the first line, and decide that it's not executing the utility it thinks it is (e.g. determining that libav is not actually available on the system when avconv/avplay/etc report ffmpeg/ffplay/..., versus reporting the same version string for both).
| bug | low | Critical |
177,419,099 | youtube-dl | [YouTube] Honor --include-ads (was: --include-ads should work with -g) | - [x ] I've **verified** and **I assure** that I'm running youtube-dl **2016.09.15**
- [x ] At least skimmed through [README](https://github.com/rg3/youtube-dl/blob/master/README.md) and **most notably** [FAQ](https://github.com/rg3/youtube-dl#faq) and [BUGS](https://github.com/rg3/youtube-dl#bugs) sections
- [ x] [Searched](https://github.com/rg3/youtube-dl/search?type=Issues) the bugtracker for similar issues including closed ones
### What is the purpose of your _issue_?
- [ x] Bug report (encountered problems with youtube-dl)
- [ ] Site support request (request for adding support for a new site)
- [x ] Feature request (request for a new functionality)
- [ ] Question
- [ ] Other
### If the purpose of this _issue_ is a _bug report_, _site support request_ or you are not completely sure provide the full verbose output as follows:
```
$ youtube-dl -v --include-ads -g https://www.youtube.com/watch?v=by1RRP9wa_Y
[debug] System config: []
[debug] User config: []
[debug] Command-line args: ['--prefer-free-formats', '-v', '--include-ads', '-g', 'https://www.youtube.com/watch?v=by1RRP9wa_Y']
[debug] Encodings: locale UTF-8, fs utf-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2016.09.15
[debug] Python version 3.5.2 - Linux-4.4.20-1-lts-x86_64-with-arch
[debug] exe versions: ffmpeg 3.1.3, ffprobe 3.1.3, rtmpdump 2.4
https://r6---sn-n4g-jqb6.googlevideo.com/videoplayback?sparams=clen%2Cdur%2Cei%2Cgcr%2Cgir%2Cid%2Cinitcwndbps%2Cip%2Cipbits%2Citag%2Ckeepalive%2Clmt%2Cmime%2Cmm%2Cmn%2Cms%2Cmv%2Cpcm2cms%2Cpl%2Crequiressl%2Csource%2Cupn%2Cexpire&ei=XuvbV4LlHam9iQbl9pyYCg&ip=77.158.88.42&clen=26041709&id=o-AKiNrGp651rPkcaCPGxWujOUygseRQXH2xoIUTBSuRPy&keepalive=yes&upn=QmaIi7k2-PE&mm=31&mn=sn-n4g-jqb6&mt=1474029834&mv=m&ms=au&itag=135&ipbits=0&lmt=1469864873129722&expire=1474052030&mime=video%2Fmp4&key=yt6&gir=yes&requiressl=yes&source=youtube&gcr=fr&pcm2cms=yes&dur=253.240&initcwndbps=1521250&pl=21&signature=C914E7A617EB00B7135B91A92C02E636AA7D3523.8C8172EB1A25A5B4B245B73FFAC5C391F76622E3&ratebypass=yes
https://r6---sn-n4g-jqb6.googlevideo.com/videoplayback?sparams=clen%2Cdur%2Cei%2Cgcr%2Cgir%2Cid%2Cinitcwndbps%2Cip%2Cipbits%2Citag%2Ckeepalive%2Clmt%2Cmime%2Cmm%2Cmn%2Cms%2Cmv%2Cpcm2cms%2Cpl%2Crequiressl%2Csource%2Cupn%2Cexpire&ei=XuvbV4LlHam9iQbl9pyYCg&ip=77.158.88.42&clen=4015657&id=o-AKiNrGp651rPkcaCPGxWujOUygseRQXH2xoIUTBSuRPy&keepalive=yes&upn=QmaIi7k2-PE&mm=31&mn=sn-n4g-jqb6&mt=1474029834&mv=m&ms=au&itag=251&ipbits=0&lmt=1469722106914133&expire=1474052030&mime=audio%2Fwebm&key=yt6&gir=yes&requiressl=yes&source=youtube&gcr=fr&pcm2cms=yes&dur=253.261&initcwndbps=1521250&pl=21&signature=BE56DEA07BCF75742743076F0B86570EFE4D9ED6.3C87F915F1312A22E5C500EA98DB9B4222AE9AE0&ratebypass=yes
...
<end of log>
```
### Description of your _issue_, suggested solution and other information
When using -g option to get video url and --include-ads option, youtube-dl should include ads url too.
I'm using youtube-dl in lollypop to allow users playing music from youtube but I will prefer to add a "fair use" by default (playing ads) with an hidden option to disable ads.
| request | low | Critical |
177,451,327 | go | cmd/compile: optimizing multiple accesses to same key in map | I was reviewing some code for performance issues, and the profile pointed me to a function that was accessing the same map element multiple times like this:
``` go
data[key].Foo = 1
data[key].Bar.Baz += 4
[...]
```
The profile showed many calls to `runtime.mapaccess1_fast32`. I was wondering if it would be legal for the compiler to optimize this straight code to do only one map access, and then of course if it's worth doing it or not.
| Performance,NeedsFix,compiler/runtime | medium | Major |
177,480,147 | opencv | Unexpected non const behaviour in InputArray.getMat() and Mat::operator= | ##### System information (version)
- OpenCV = 3.1
- Operating System / Platform = Windows 7/64 Bit
- Compiler = Visual Studio 2013
##### Detailed description
As is defined `InputArray` _is the proxy class for passing read-only input arrays into OpenCV functions_ but the `getMat()` method returns a read-write object.
In addiction the `Mat::operator=` returns a non-const Mat even if source is defined as `const`
##### Steps to reproduce
In the following test the function changes content of the `in` param while caller expects a read-only behaviour .
As you can see the test function can also changes content of the `const Mat &src` param
``` .cpp
void TestConsts(const Mat &src, InputArray in)
{
Mat dst1;
dst1 = src;
dst1 = 1;
Mat dst2 = in.getMat();
dst2 = 2;
}
int main(int argc, char** argv)
{
Mat A = Mat::zeros(Size(3, 3), CV_8UC1);
Mat B = Mat::zeros(Size(3, 3), CV_8UC1);
TestConsts(A, B);
cout << A << endl;
cout << B << endl;
return 0;
}
```
result is 1 and 2 instead of zeros
``` .text
A = [ 1, 1, 1]
B = [ 2, 2, 2]
```
| RFC | low | Major |
177,530,088 | youtube-dl | Add Support for YouTube Channels Owned by a Google+ Page | #### Make sure you are using the _latest_ version: run `youtube-dl --version` and ensure your version is _2016.09.15_. If it's not read [this FAQ entry](https://github.com/rg3/youtube-dl/blob/master/README.md#how-do-i-update-youtube-dl) and update. Issues with outdated version will be rejected.
- [x] I've **verified** and **I assure** that I'm running youtube-dl **2016.09.15**
#### Before submitting an _issue_ make sure you have:
- [x] At least skimmed through [README](https://github.com/rg3/youtube-dl/blob/master/README.md) and **most notably** [FAQ](https://github.com/rg3/youtube-dl#faq) and [BUGS](https://github.com/rg3/youtube-dl#bugs) sections
- [x] [Searched](https://github.com/rg3/youtube-dl/search?type=Issues) the bugtracker for similar issues including closed ones
#### What is the purpose of your _issue_?
- [x] Bug report (encountered problems with youtube-dl)
- [ ] Site support request (request for adding support for a new site)
- [x] Feature request (request for a new functionality)
- [ ] Question
- [ ] Other
---
# The issue
YouTube videos can not only be owned by users, [but by Google+ pages as well](https://support.google.com/youtube/answer/4642409). Please add support for [authenticating as a Google+ Page](https://youtube-eng.googleblog.com/2013/06/google-page-identities-and-youtube-api_24.html), so that we can download our private YouTube videos from these channels.
Thanks!
| account-needed | low | Critical |
177,537,172 | flutter | Expansion panels should have a smart way to expand. | Right now, expansion panels always grow, push all children downwards but never scroll. A smarter way to do this would be to consider scrolling the list s that it causes least movement and makes the currently expanding items easiest to follow.
| c: new feature,framework,f: material design,P3,team-design,triaged-design | low | Minor |
177,578,065 | youtube-dl | [fc2] Playlist support | - [x] I've **verified** and **I assure** that I'm running youtube-dl **2016.09.15**
- [x] [Searched](https://github.com/rg3/youtube-dl/search?type=Issues) the bugtracker for similar issues including closed ones
- [x] Site support request (request for adding support for a new site)
- [x] Feature request (request for a new functionality)
The current fc2 plugin is kind of incomplete. There is a playlist system on fc2 that's not currently supported.
Here's a random example I picked: http://video.fc2.com/list.php?m=scont&sobj_up_mb_id=82206749
Note that it can be both `/list.php` and `/a/list.php`.
Would appreciate support being extended to this feature.
| request | low | Critical |
177,584,222 | youtube-dl | [abc.net.au] Youtube embed results in "Unable to extract video urls" error. | - [x] I've **verified** and **I assure** that I'm running youtube-dl **2016.09.15**
### Before submitting an _issue_ make sure you have:
- [x] At least skimmed through [README](https://github.com/rg3/youtube-dl/blob/master/README.md) and **most notably** [FAQ](https://github.com/rg3/youtube-dl#faq) and [BUGS](https://github.com/rg3/youtube-dl#bugs) sections
- [x] [Searched](https://github.com/rg3/youtube-dl/search?type=Issues) the bugtracker for similar issues including closed ones
### What is the purpose of your _issue_?
- [x] Bug report (encountered problems with youtube-dl)
- [ ] Site support request (request for adding support for a new site)
- [ ] Feature request (request for a new functionality)
- [ ] Question
- [ ] Other
```
$ y -v http://www.abc.net.au/news/2015-08-17/warren-entsch-introduces-same-sex-marriage-bill/6702326
[debug] System config: []
[debug] User config: ['-4', '-f', 'best', '--prefer-free-formats', '--no-cache-dir', '--no-mtime', '--youtube-skip-dash-manifest']
[debug] Command-line args: ['-v', 'http://www.abc.net.au/news/2015-08-17/warren-entsch-introduces-same-sex-marriage-bill/6702326']
[debug] Encodings: locale UTF-8, fs utf-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2016.09.15
[debug] Python version 3.6.0b1 - Linux-4.8.0-rc5-686-i686-with-debian-stretch-sid
[debug] exe versions: ffmpeg 3.1.3, ffprobe 3.1.3, rtmpdump 2.4
[debug] Proxy map: {}
[abc.net.au] 6702326: Downloading webpage
ERROR: Unable to extract video urls; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see https://yt-dl.org/update on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
Traceback (most recent call last):
File "/usr/local/lib/python3.6/dist-packages/youtube_dl/YoutubeDL.py", line 694, in extract_info
ie_result = ie.extract(url)
File "/usr/local/lib/python3.6/dist-packages/youtube_dl/extractor/common.py", line 355, in extract
return self._real_extract(url)
File "/usr/local/lib/python3.6/dist-packages/youtube_dl/extractor/abc.py", line 67, in _real_extract
raise ExtractorError('Unable to extract video urls')
youtube_dl.utils.ExtractorError: Unable to extract video urls; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see https://yt-dl.org/update on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
```
http://www.abc.net.au/news/2015-08-17/warren-entsch-introduces-same-sex-marriage-bill/6702326
| bug | low | Critical |
177,636,637 | rust | In some cases, the compiler doesn't find a proper macro rule even when it exists | Macro rules, that are generated with macro rules, are not working in some cases. See the following example:
```
/* lib.rs */
macro_rules! gen_lookup {
($e:expr) => {
#[macro_export]
macro_rules! lookup {
($e) => { "bug" };
("works") => { "works" };
}
}
}
gen_lookup!("bug");
pub fn run()
{
println!("{}", lookup!("works"));
// println!("{}", lookup!("bug"));
}
```
```
/* main.rs */
#[macro_use]
extern crate rustbug;
fn main() {
rustbug::run();
println!("{}", lookup!("bug"));
}
```
When you include the commented line, you should get `error: no rules expected the token `"bug"``. This is especially weird, since the exactly same line works in case where the macro is used from an external crate (see main.rs). As usual, when gen_lookup is removed and lookup macro is written manually, everything works as expected.
| A-macros,T-compiler,C-bug | low | Critical |
177,651,475 | godot | inst2dict does not turn classes inside classes to dict | inst2dict does not turn classes inside classes to dict.
Here is an example of to_json() output;
```json
{
"description": "Some Desc",
"id": 1337,
"@path": "res://data/classes/project_class.gd",
"tasks": [
"[Reference:835]",
"[Reference:836]",
"[Reference:837]"
],
"@subpath": "",
"name":"P Name"
}
```
I believe the classes (Reference:8XX) should also be converted to Dictionary for this to work as intended. :)
Currently; a workaround for this is to save the other classes as Dict, and use a set/get where you convert between class and dictionary. However I am sure inst2dict should also include subclasses.
Hope to see a fix implemented in the future :)
| bug,discussion,topic:core,topic:gdscript,confirmed | low | Major |
177,658,646 | vscode | Possibility to display line endings in text area | - VSCode Version: 1.5
- OS Version: Win 7 x64
At the moment there is only the little statusbar menu which display/change the line ending if the actual file. But sometimes it would be great to see the line endings directly in every line (see atom f.e.) especially when there are mixed line endings (not good, but this happens from time to time).
Greetings
Tonka
| feature-request,editor-render-whitespace | high | Critical |
177,671,142 | create-react-app | Duplicate React | “Duplicate React” is an incredibly common issue that produces weird errors and confuses beginners and advanced users alike. It happens when you install `react` but some component you’re using installs its own copy of `react` (often with a different version).
React doesn’t throw in such cases because there are situations in which multiple React may validly coexist in the page (e.g. a third-party React-powered widget on a React-powered website). However it seems to make much less sense inside a single bundle. Webpack is in a perfect position to do this, but of course it won’t add any library-specific code. The good news is that we’re on top of webpack, so we might be able to do something.
There are several possible options:
- 1. Do nothing. (Like now)
- 2. Warn/error on duplicate React in the bundle.
- 3. Alias React to always be the one on the top level, regardless of Node resolution mechanism.
Option (3) seems like the easiest to do (we can special-case React in our Webpack, and maybe Jest, configs). It also “just works” from the user’s point of view because they don’t need to delete any `node_modules` or mess with projects’ `peerDependencies`. The downside is the ecosystem loses because project authors don’t become aware that their components incorrectly depend on React, or that their components are outdated.
Option (2) seems like more work. It’s not immediately clear what message we could provide. Would we tell the user to delete the extra `react` from the respective `node_modules` subfolder? Would we tell them to file an issue with that component or library?
Finally, we could stick with doing nothing.
Any thoughts?
| contributions: up for grabs!,issue: proposal,difficulty: medium | medium | Critical |
177,672,365 | go | os/exec: Cannot execute command with space in the name on Windows, when there are parameters | Go 1.7.1 on windows-amd64, Windows 10 latest.
Consider a test project:
```
src/github.com/calmh/wincmdtest/
main.go
folder name/
test.bat
```
`main.go` contents:
``` go
package main
import (
"fmt"
"os/exec"
"strings"
)
func main() {
execCmd("./folder name/test.bat")
execCmd("./folder name/test.bat", "one param")
}
func execCmd(path string, args ...string) {
fmt.Printf("Running: %q %q\n", path, strings.Join(args, " "))
cmd := exec.Command(path, args...)
bs, err := cmd.CombinedOutput()
fmt.Printf("Output: %s", bs)
fmt.Printf("Error: %v\n\n", err)
}
```
`folder name/test.bat` contents:
``` bat
@echo off
echo Success
```
Expected output is two runs with "Success" in them.
Actual:
```
C:\Users\jb\Go\src\github.com\calmh\wincmdtest>go run main.go
Running: "./folder name/test.bat" ""
Output: Success
Error: <nil>
Running: "./folder name/test.bat" "one param"
Output: '.' is not recognized as an internal or external command,
operable program or batch file.
Error: exit status 1
```
It appears that having params on a command, where the command contains a space, breaks the parsing of it. I haven't been able to work around this by experimenting with various ways of quoting the command, using backslashes or slashes, etc.
| OS-Windows,NeedsFix,early-in-cycle | medium | Critical |
177,676,293 | nvm | Using the system node as default | I've done `nvm alias default system`, and doing `nvm use system` shows `Now using system version of node: v6.5.0 (npm v3.10.6)`. But if I do `nvm exec system node app.js` I get an error:
```
N/A: version "system" is not yet installed.
You need to run "nvm install system" to install it before using it.
```
What's the correct way to use the system node as the default? (I only switch to nvm versions of node when I'm in a directory with an .nvmrc.)
| needs followup | low | Critical |
177,676,628 | rust | Closures should infer to capture by copy | Inspired by a common stumbling block with `Iterator::flat_map`.
This code does not compile:
``` rust
(0..10).flat_map(|i| (0..i).map(|j| i + j))
```
```
error: `i` does not live long enough
```
[(playground code)](https://play.rust-lang.org/?gist=8579249badd19920bd552376eb1fbb3a&version=stable&backtrace=0)
The problem: `i` is a local variable and captured by reference in a closure we're trying to return. It's an integer, its data size is equal or smaller as a value instead of a reference.
Can rustc infer that the closure should capture `i` by "move" here (Copy)?
| C-enhancement,A-closures,T-lang,A-inference,C-feature-request | low | Critical |
177,677,100 | go | cmd/go: drop runtime from plugins | It looks like plugins contain a copy of the runtime. I guess that copy is unused, and could probably be dropped, reducing binary size.
| NeedsFix | medium | Major |
177,686,578 | rust | Collision between extern-block fn and #[no_mangle] fn not detected | This code compiles and `x::foo` calls itself recursively.
``` rust
#![crate_type="lib"]
extern {
fn foo();
}
pub mod x {
#[no_mangle]
pub unsafe extern "C" fn foo() { ::foo() }
}
```
https://play.rust-lang.org/?gist=dc191ae3cfb84887ba39bbf327a2e6fe&version=stable&backtrace=1
We don't end up seeing a re-definition because the `foo` in the extern block only creates a declaration.
EDIT: Here's an example that is actually a problem we should probably prevent:
``` rust
#![crate_type="lib"]
extern {
fn foo(x: i32);
}
pub mod x {
#[no_mangle]
pub unsafe extern "C" fn foo() { ::foo(0) }
}
```
This happily compiles, and probably shouldn't.
| A-FFI,T-lang,T-compiler,C-feature-request | low | Minor |
177,709,701 | awesome-mac | 协作工具 | notion https://www.notion.so/
| vote | low | Minor |
177,730,556 | opencv | calibration using circle grid pattern has perspective bias | ##### Detailed description
the perspective bias using circle grid is not considered in the calibrtion pipeline, when using a circle grid pattern, a circle on the board in real world, projects on the image to be an ellipse (unconsidering distortion), according to the projective geometry, the center of the circle does not correspond to the center of the ellipse (or the centroid of the blob), this is showed in the following picture:
http://paste.ubuntu.org.cn/4219097
the perspective bias affects the calibration precision, this is detailed in the paper
Heikkila J. Geometric camera calibration using circular control points[J]. IEEE Transactions on pattern analysis and machine intelligence, 2000, 22(10): 1066-1077.
| feature,category: calib3d | low | Minor |
177,828,375 | rust | Rust has trouble seeing higher ranked lifetimes through generics | Rust has trouble seeing that a generic function is "generic" over higher ranked lifetimes. This behavior is best described by example. Given:
``` rust
fn id<X>(x: X) -> X { x }
fn id_wrapped<'a, T>(v: &'a T) -> &'a T {
// Defined for<'a>. No coercion.
id::<&'a T>(v)
}
fn has_hrl<F: Fn(&()) -> &()>(f: F) {}
fn main() {
has_hrl(id);
has_hrl(id_wrapped);
has_hrl(|x| id(x));
}
```
Rust complains:
``` rust
error[E0281]: type mismatch: the type `fn(_) -> _ {id::<_>}` implements the trait `std::ops::Fn<(_,)>`, but the trait `for<'r> std::ops::Fn<(&'r (),)>` is required (expected concrete lifetime, found bound lifetime parameter )
--> tmp.rs:11:5
|
11 | has_hrl(id);
| ^^^^^^^
|
= note: required by `has_hrl`
error[E0271]: type mismatch resolving `for<'r> <fn(_) -> _ {id::<_>} as std::ops::FnOnce<(&'r (),)>>::Output == &'r ()`
--> tmp.rs:11:5
|
11 | has_hrl(id);
| ^^^^^^^ expected bound lifetime parameter , found concrete lifetime
|
= note: concrete lifetime that was found is lifetime '_#0r
= note: required by `has_hrl`
error: aborting due to 2 previous errors
```
However, the `has_hrl(id_wrapped)` and `has_hrl(|x| id(x))` calls demonstrate that, at some level, the rust type checker infers that `id` implements `for<'r> Fn(&'r ()) -> &'r ()`. That's why I filed this as a bug instead of an RFC issue. However, I can move this if you feel that it's too much of a feature request.
---
My motivation is functional programming. Not being able to infer that a generic function is defined for some HRL makes it impossible to use such functions with, e.g., `Iterator::filter`.
| A-type-system,A-lifetimes,A-closures,T-lang,T-compiler,C-bug,T-types,A-higher-ranked | low | Critical |
177,840,918 | TypeScript | Unintuitive error message with 'unreachable' code | <!-- BUGS: Please use this template. -->
<!-- QUESTIONS: This is not a general support forum! Ask Qs at http://stackoverflow.com/questions/tagged/typescript -->
<!-- SUGGESTIONS: See https://github.com/Microsoft/TypeScript-wiki/blob/master/Writing-Good-Design-Proposals.md -->
**TypeScript Version:** 2.0.02
**Code**
``` ts
const enum Keys {
Tab = 10,
Shift = 13
}
function bug() {
let key: Keys;
if (key === Keys.Tab) {
return;
}
if (key === Keys.Tab || key === Keys.Shift) {
console.log('Bug');
}
}
```
On line 13 you get an error message that === can't be applied as an operator. Took me quite some time to find out that the same comparison was above (the real code was a little bit more complicated) and was leaving the function.
| Suggestion,Help Wanted,Effort: Difficult,Domain: Error Messages | low | Critical |
177,882,694 | kubernetes | Replication controller (and RS): Don't make more than 1k unschedulable pods | Observed a cluster with a nonsensically high value for spec.replicas and replication controller was trying to honor it, and crushing the master in the process. RC should probably not make more than a reasonable number of pending pods, maybe like 500 or 1000, it should make enough to give signal to sizers looking for unscheduled pods but not more. Certainly not 150k+ as observed.
| priority/important-soon,area/controller-manager,area/reliability,sig/apps,area/workload-api/replicaset,lifecycle/frozen | low | Major |
177,895,688 | react | input autoFocus causes focus to be emitted before ref | https://jsfiddle.net/nnwd2c34/
Can reproduce on Chrome, but not in IE11.
| Type: Bug,Component: DOM,Difficulty: challenging | medium | Major |
177,918,721 | rust | Add traits w/ auto-deriving for soundly serializing/inspecting/transforming rustc types. | Currently, we're limited to the general-purpose `Eq`, `Ord`, `Hash`, `Encodable` and `Decodable` traits, even though the compiler often has more unconventional desires, involving contexts and custom behaviors.
There are several special-purpose traits already in the compiler, such as AST/HIR `Folder`/`Visitor` and the two-in-one `TypeFoldable` (which also does visiting).
Also, #36551 adds a specialization mechanism in the bundled `rustc_serialize` to work around the fact that `Encodable` and `Decodable` have their methods be generic over the encoder/decoder instead of the trait, but this abuses the yet-unclosed lifetime soundness hole in specialization (#31844):
``` rust
impl<'a, 'tcx> SpecializedDecoder<Ty<'tcx>> for DecodeContext<'a, 'tcx> {...}
```
That `impl` requires that the `'tcx` of the decoded `Ty` match the `'tcx` of the decoder, but this _cannot_ be enforced through specialization as the lifetime relationships do not exist before monomorphization.
A better solution would involve custom traits that can dispatch over the decoder w/o specialization, i.e.:
``` rust
impl<'a, 'tcx> Decodable<DecodeContext<'a, 'tcx>> for Ty<'tcx> {...}
```
To make all of this ergonomic, auto-deriving is necessary, and I believe macros 1.1 (perhaps helped by a permanent switch to rustbuild) can make it happen.
Last but not least, it may be possible to generalize encoding/decoding and visiting/folding/relating into a single (or a pair of) abstraction(s), but I'd have to leave that to someone who understands tree folding, transducers, and perhaps Haskell lenses, although there's no guarantee they map nicely to Rust.
cc @rust-lang/compiler
| C-cleanup,A-metadata,T-compiler | low | Minor |
177,927,499 | kubernetes | kube-apiserver: limit the size of node objects more than other objects | Due to the frequency of status updates and the fact that etcd saves the entire object with every heartbeat, Kubernetes is more sensitive to the size of node objects than other objects in the system.
In practice, node objects that are merely 150k are enough to take down a small master.
We should think about what a sane size limit is, what to do when a component like kubelet attempts to violate the size limit, and whether maybe we should start storing the heartbeat time in a separate location to eliminate this class of problems entirely.
We'll probably need to reevaluate this when we start running etcd 3.
| priority/important-soon,sig/api-machinery,lifecycle/frozen | medium | Major |
178,066,804 | youtube-dl | Request: playlist thumbnail support | Thumbnails for playlists would be very useful for e.g. albums.
| request | low | Minor |
178,080,300 | angular | Binding to [name] on radio inputs does not provide browser-default tab interaction | **I'm submitting a ...** (check one with "x")
```
[x] bug report => search github for a similar issue or PR before submitting
```
**Current behavior**
When the the `name` attribute of a radio input is bound using `[name]='name'`, it appears that the actual name attribute is not set with the bound value. This causes incorrect tab behavior for groups of radios. If I have a component with 3 radios, and repeat that component 3 times, then all 9 radios behave as if they had the same name (they collectively act as a single tab stop, and the arrow keys can be used to navigate between all 9 when any radio is focused). See https://plnkr.co/edit/SXxIxZM1BuMsnAZnN1UF?p=preview
When binding to `[attr.name]`, tab/arrow key navigation works as expected, but other radios that share the same value are also selected. I.E. when selecting `Option 1` in group 1, `Option 1` is selected in groups 2 and 3 as well. However, this appears to not effect the value of the `FormControl`, the selected value and the selected radio become out of sync.
See: https://plnkr.co/edit/5jHshpyQHezLqZEXqz5v?p=preview
When binding to _both_ `[attr.name]` and `[name]` I get the expected behavior, but it seems like I should only need to bind to one or the other. See: https://plnkr.co/edit/7ZnsSzTCuyiufCdjX5zN?p=preview
**Expected behavior**
Binding to `[name]` should set the input's name attribute so that the correct tab behavior is preserved. In the above example, each component's 3 radios should act as a single tab stop, and using the arrow keys should cycle between each of the component's 3 radios.
If binding to both `[name]` and `[attr.name]` is required, it should probably be documented, maybe in [FormControlDirective](https://angular.io/docs/ts/latest/api/forms/index/FormControlDirective-directive.html)?
**What is the motivation / use case for changing the behavior?**
My app supports custom radio fields, so the number of fields and their options are all runtime values. I'm trying to create a reusable `radio-group` which accepts bindings to `name`, `options`, and `formControl`.
- **Angular version:** 2.0.0
- **Browser:** all
| type: bug/fix,freq2: medium,workaround2: non-obvious,area: forms,state: confirmed,forms: directives,P4 | medium | Critical |
178,112,247 | angular | Support disabling individual radios without disabling control | ```
<input type="radio" name="food" ngModel disabled>
<input type="radio" name="food" ngModel>
```
Must wait for a minor release to make API changes.
| feature,state: Needs Design,freq2: medium,area: forms,feature: under consideration | medium | Minor |
178,133,655 | go | x/build: record and collect compiler benchmarks | Recently we added a -bench flag to cmd/compile to benchmark compiler phases. It might be interesting if the builders used this flag and then persisted the output file so we could monitor compiler performance over time.
There's a risk that measuring the standard library compile time is confounded with changes to the standard library, but I think only a couple packages (runtime, net, net/http) still seem under active development. So it's probably still a decent signal.
/cc @bradfitz @griesemer
| Builders,NeedsInvestigation | low | Major |
178,328,194 | vscode | Mac: Provide a setting to hide the title bar and inline the window controls | Hello there, a lot of the standard apps in recent versions of macOS have started to inline their titlebar into their tabs, menu buttons etc. I assume this is mainly to save vertical space on laptops. However, like all UI trends, apps that don't quite keep up end up feeling old-fashioned 👯
I started a fork of VS Code that uses the inline style:
There needed to be a few changes:
- I moved the sidebar width to 76, to fit the traffic lights
- I increased the height of the elements that act as the titlebar by one pixel, mainly so that they align with the centre position of the titlebar items
- Allow mouse dragging via the sidebar, and the title elements
Fork: https://github.com/orta/vscode/tree/inline-titlebar
Changes: https://github.com/orta/vscode/compare/master...mac-titlebar-inline
I realise that VS Code is a cross-platform project, and so these changes should _probably_ only be applied in the context of macOS, which I'm happy to look into with some advice (I don't have a windows/linux machine to hand for example).
I also know that no-one wants big unexpected UI changes on their OSS projects, so I've not made it as a PR, but I'd love to know if/what I can do to move this upstream?
_Sidenote:_ If someone can tell me how, I'm happy to make a downloadable build for people to try too, I couldn't find a way to do it - I'm still quite fresh to npm projects.
| feature-request,ux,macos,titlebar | high | Critical |
178,386,050 | rust | Better SIMD shuffles | I'm trying to do the following in AVX2 using intrinsics: shift `x` one byte to the right, while shifting the rightmost byte of `y` into the leftmost byte of `x`. This is best done using two instructions: `vperm2i128` followed by `vpalignr`. However, `simd_shuffle32` generates four instructions: `vmovdqa` (to load a constant), `vpblendvb`, then `vperm2i128` and `vpalignr`. Here is a a full example, which may be compiled with `rustc -O -C target_feature=+avx2 --crate-type=lib --emit=asm shuffle.rs`.
```
#![feature(platform_intrinsics, repr_simd)]
#[allow(non_camel_case_types)]
#[repr(simd)]
pub struct u8x32(u8, u8, u8, u8, u8, u8, u8, u8, u8, u8, u8, u8, u8, u8, u8, u8, u8, u8, u8, u8, u8, u8, u8, u8, u8, u8, u8, u8, u8, u8, u8, u8);
extern "platform-intrinsic" {
fn simd_shuffle32<T, U>(x: T, y: T, idx: [u32; 32]) -> U;
}
pub fn right_shift_1(left: u8x32, right: u8x32) -> u8x32 {
unsafe { simd_shuffle32(left, right, [31, 32, 33, 34, 35, 36, 37, 38, 39, 40, 41, 42, 43, 44, 45, 46, 47, 48, 49, 50, 51, 52, 53, 54, 55, 56, 57, 58, 59, 60, 61, 62]) }
}
```
This might be considered a bug in LLVM, in the sense that it's generating a sub-optimal shuffle. However, I think it should be addressed in rustc, because if I know what the right sequence of instructions is then I shouldn't have to hope that LLVM can generate it. Moreover, it's possible to get the right code from clang (compile with `clang -emit-llvm -mavx2 -O -S shuffle.c`):
```
#include <immintrin.h>
__m256i right_shift_1(__m256i left, __m256i right)
{
__m256i new_left = _mm256_permute2x128_si256(left, right, 33);
return _mm256_alignr_epi8(new_left, right, 1);
}
```
A possibly interesting observation is that the unoptimized LLVM IR from clang contains a `llvm.x86.avx2.vperm2i128` intrinsic followed by a `shufflevector`. The optimized LLVM IR from clang contains two `shufflevector` intrinsics. In order to try to get the same output from rustc, I first patched it to support `llvm.x86.avx2.vperm2i128`. After modifying `right_shift_1` to use the new intrinsic, I got rustc to produce `llvm.x86.avx2.vperm2i128` followed by a `shufflevector`. However, the optimized LLVM IR from rustc still produces a single `shufflevector`, and it still ends up producing the bad asm.
I think this means that the fault is from some optimization pass in rustc that isn't in clang, but I haven't had time to investigate it yet...
| A-LLVM,I-slow,C-enhancement,T-compiler,A-SIMD,C-optimization | low | Critical |
178,416,733 | rust | Inner function cannot be tested | I really would like to be able to this:
``` rust
fn outer(x: i32) -> i32 {
fn inner(a: i32, b: i32) -> i32 {
a + b
}
#[test]
fn test_inner() {
assert_eq!(inner(3, 5), 8);
}
inner(x, 5)
}
#[test]
fn test_outer() {
assert_eq!(outer(3), 8);
}
```
| T-compiler,C-feature-request,A-libtest | low | Major |
178,421,469 | TypeScript | programUpToDate check in synchonizeHostData should ignore differences in library files that were injected by the compiler | Currently `programUpToDate` compares the set of root files provided by the host with the set of files in the program. This check might fail even set of files in the program have not changed because set of files in program is composed of root files unioned with injected library files. As a result we'll spend time rebuilding the program when really nothing has been changed.
The check should be updated to ignore differences that originate from injected files.
| Bug | low | Minor |
178,477,198 | flutter | Callback for "key" presses on Input widget | Internal: b/140828801
There are many use cases when it is desired to capture the actual key being pressed in a `input` widget.
A classic example is a "tag input" use case. You have a list of "tags/labels/chips" that is followed by a text input. When you add some text in and submit it, a new tag/label/chip is added. When you press backspace/delete and the text input is empty, then the most recent tag/label/chip should be removed.
We will need a "onKeyPress" callback so that we can know if the backspace/delete key was being pressed.
| c: new feature,customer: fuchsia,framework,a: desktop,P3,team-design,triaged-design | low | Major |
178,514,171 | nvm | support strict-ssl-false param? | I can't access the internet without the proxy in my company.
when I use `nvm` to install nodejs ,it always accesss the internet with https and causes the SSL certificate problem.
NPM is allow to set strict-ssl=false in .npmrc to support it .
does NVM support this ?
| installing node,feature requests,SSL issue,pull request wanted | low | Major |
178,665,215 | vscode | Allow to specify the tsconfig.json filename explicitly | currently VSCode uses the file with the exact name `tsconfig.json` in the folder as the project file for a typescript project,
i have a few other project files named differently for corresponding sub-projects **inside the same folder**, I wish there was a way to tell VSCode to use one of them rather then the default `tsconfig.json`
| feature-request,typescript,upstream-issue-linked | high | Critical |
178,683,359 | opencv | OpenCVConfig expects a certain layout on Windows | ##### System information (version)
- OpenCV => 74e997f15b20600895896e1a837a0bb3cbf7f07b
- Operating System / Platform => Windows
- Compiler => MSVC2013
##### Detailed description
The `OpenCVConfig.cmake` unconditionally does a lot of complicated logic on Windows. While the current setup has its use case, we would like to be able to install OpenCV just like any other library without a special runtime subdirectory (which requires extra `PATH` manipulations that we would like to avoid).
##### Steps to reproduce
- Set `OpenCV_INSTALL_BINARIES_PREFIX=` so that the install uses standard `bin/` and `lib/` directories;
- the installed `OpenCVConfig.cmake` cannot find anything because it is not told about the actual `OpenCV_INSTALL_BINARIES_PREFIX` used.
We set `OpenCV_INSTALL_BINARIES_PREFIX` to empty so that we do not want to extend `PATH` with the extra directories only used by OpenCV. Basically, we want a *nix-style install on Windows. This could probably be triggered based on whether the prefix is set manually or not. If it is set manually, assume the user knows what they are doing and skip the "find a runtime-compatible directory" logic and just install a regular `OpenCVConfig.cmake` to `lib/cmake/OpenCV/`.
| feature,category: build/install,affected: 3.4 | low | Minor |
178,697,243 | angular | Add canDeactivateChild guard | **I'm submitting a ...** (check one with "x")
```
[ ] bug report => search github for a similar issue or PR before submitting
[x] feature request
[ ] support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question
```
**What is the motivation / use case for changing the behavior?**
There is already a canActivateChild guard. Having the symmetric guard is equally important. Not sure why this wasn't added at the same time. We have many scenarios where we need to protect child routes from navigating away if they have pending unsaved changes. That's currently only possible by putting a canDeactivate guard on each child route.
- **Angular version:** Latest
- **Browser:** all
- **Language:** all | feature,freq2: medium,area: router,feature: under consideration | high | Critical |
178,709,541 | bitcoin | whiteconnections should be re-added | The `whiteconnections` option was added in 0.12 but later removed in #6374 because it was viewed as being redundant. While whitelisted connections can no longer be _evicted_ as of that PR, `whiteconnections` is still useful because it allows for _new_ connections. For example, you could have a full node that you use as a gateway for several of your lightweight nodes, and in this case it may be impossible for you to connect to your gateway due to insufficient connection slots. whiteconnections solved this, but it is now removed.
Here's a real-world complaint about this issue: https://www.reddit.com/r/Bitcoin/comments/540hoj/can_whitelistnetmask_free_up_a_connection/
Perhaps it would be more elegant to detect when a whitelisted peer is trying to connect when we have no more connection slots, and trigger the eviction of a non-whitelisted inbound peer in this case. But it's probably easier to just re-add `whiteconnections`.
| P2P | low | Major |
178,721,730 | rust | LLVM assertions when using `-C target-feature=+soft-float` with a few targets | [Found](https://travis-ci.org/japaric/smoke/builds/161972628) using [smoke](https://github.com/japaric/smoke/pull/28). (cc @brson)
Smoke is a "cross" testing framework. It runs different tests, like the unit tests of the standard
crates, for several targets. I wanted to see how setting `-C target-feature=+soft-float` affected a
single test case but decided to set it via `RUSTFLAGS` ~~for fun~~ to see how it affected _all_ the
tests it runs. To my surprise, on 6 of 10 targets, this resulted in LLVM assertions while compiling
_one or two_ of the **many** tests that smoke runs. Here's the summary:
- `i686-apple-darwin` Assertion: "Should only be an extending load, not truncating!"
- `x86_64-apple-darwin` Assertion: "This value type is not natively supported!"
- `i686-unknown-linux-gnu` Assertion: "Should only be an extending load, not truncating!"
- `i686-unknown-linux-musl` Assertion: "Should only be an extending load, not truncating!"
- `x86_64-unknown-linux-gnu` Assertion: "This value type is not natively supported!"
- `x86_64-unknown-linux-musl` Assertion: "This value type is not natively supported!"
- `mips-unknown-linux-gnu` OK
- `mipsel-unknown-linux-gnu` OK
- `powerpc-unknown-linux-gnu` OK
- `powerpc64-unknown-linux-gnu` OK
And below it's a more detailed report of how the assertion was triggered:
### `i686-apple-darwin`
### `i686-unknown-linux-gnu`
### `i686-unknown-linux-musl`
[Travis build job for i686-apple-darwin](https://travis-ci.org/japaric/smoke/jobs/161972630#L332)
[Travis build job for i686-unknown-linux-gnu](https://travis-ci.org/japaric/smoke/jobs/161972635#L501)
[Travis build job for i686-unknown-linux-musl](https://travis-ci.org/japaric/smoke/jobs/161972637#L448)
Command:
```
$ cargo run --target $TARGET --manifest-path libc/libc-test/Cargo.toml
```
On [this rust-lang/libc checkout](https://github.com/rust-lang/libc/tree/836cda98930c5621d937c31e3796db9fe0b8f8a7).
Assertion:
```
Assertion failed: (MemVT.getScalarType().bitsLT(VT.getScalarType()) && "Should only be an extending load, not truncating!"), function getLoad, file /Users/rustbuild/src/rust-buildbot/slave/nightly-dist-rustc-mac/build/src/llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp, line 5085.
```
### `x86_64-apple-darwin`
### `x86_64-unknown-linux-gnu`
### `x86_64-unknown-linux-musl`
[Travis build job for x86_64-apple-darwin](https://travis-ci.org/japaric/smoke/jobs/161972632#L209)
[Travis build job for x86_64-unknown-linux-gnu](https://travis-ci.org/japaric/smoke/jobs/161972639#L352)
[Travis build job for x86_64-unknown-linux-musl](https://travis-ci.org/japaric/smoke/jobs/161972641#L386)
Command:
```
$ cargo test --target $TARGET
```
On this [Cargo repository](https://github.com/japaric/smoke/tree/837942777cce38bcb5b089a5dce6f3388552d237).
Assertion:
```
rustc: /buildslave/rust-buildbot/slave/nightly-dist-rustc-linux/build/src/llvm/include/llvm/Target/TargetLowering.h:437: virtual const llvm::TargetRegisterClass* llvm::TargetLoweringBase::getRegClassFor(llvm::MVT) const: Assertion `RC && "This value type is not natively supported!"' failed.
```
**NOTE** `cargo test --target $TARGET --release` didn't result in a LLVM assertion.
---
`x86_64-unknown-linux-gnu` and `x86_64-unknown-linux-musl` also failed the `libc` test mentioned in
the previous section but with a different LLVM assertion:
```
rustc: /buildslave/rust-buildbot/slave/nightly-dist-rustc-linux/build/src/llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp:4390: llvm::SDValue getMemcpyLoadsAndStores(llvm::SelectionDAG&, const llvm::SDLoc&, llvm::SDValue, llvm::SDValue, llvm::SDValue, uint64_t, unsigned int, bool, bool, llvm::MachinePointerInfo, llvm::MachinePointerInfo): Assertion `NVT.bitsGE(VT)' failed.
```
### Meta
```
$ rustc -V
rustc 1.13.0-nightly (4f9812a59 2016-09-21)
```
### Final thoughts
I think these assertions could either:
- Be just badness from mixing the standard crates that were compiled with native float operations
enabled with crates that were compiled without them (`+soft-float`). When we have a Cargo that
can build `std` and (`libtest`), I should re-run these tests to discard that possibility (`std` would
be recompiled with `+soft-float`).
- Indicate that some parts of the standard crates can't be compiled with `+soft-float` for some
targets for some reason.
| A-LLVM,T-compiler,C-bug,A-target-feature | low | Critical |
178,746,129 | vscode | [icon-themes] Support for globs in file associations (Icon themes) | - VSCode Version: Stable 1.5.2
- OS Version: Windows 10
See [vscode-icons #328](https://github.com/robertohuertasm/vscode-icons/issues/328#issuecomment-248671728)
This will allow to support a very common scenario which is a filename with small variations depending on environments:
- web.config, web.prod.config, web.dev.config
- webpack.config.json, webpack.dev.config.json
- ...
| feature-request,themes | high | Critical |
178,753,366 | TypeScript | Adjust cursor position on new line or don't emit empty spaces | From https://github.com/Microsoft/vscode/issues/11961
Ping @wallverb
- VSCode Version: Code - Insiders 1.6.0-insider (67a46126c83aac8c715d4c318fcfd18a183658bf, 2016-09-13T11:09:28.863Z)
- OS Version: Darwin x64 15.6.0
Steps to Reproduce:
TypeScript code
``` ts
class Test {
test() {
}
}
```
1. Put cursor on line `2:0`
2. Hit enter
Initial:
User presses Enter:
Notice how cursor is at `3:0` but there are spaces in front of cursor
Natural thing is to use tab to get to proper indent location which will leave empty spaces in front:
(Users might not be aware there are extra whitespaces if they dont have `renderWhitespace`)
So seems like it should put cursor at the end of that whitespaces or not append whitespaces
FYI - Both Atom and Sublime - do not append whitespaces
| Bug,VS Code Tracked | low | Minor |
178,790,783 | rust | Trait object coercion has problems with contravariant structs and lifetime bounds | I would expect this code to compile:
``` rust
#![allow(dead_code)]
#![allow(unused_variables)]
struct Covariant<'a> { y: &'a i32 }
struct Contravariant<'a> { y: fn(&'a i32) }
trait HasLifetime<'a> : 'a {}
impl<'a, T> HasLifetime<'a> for T where T: 'a {}
fn check_lifetime_bound<'a, T: 'a>(x: &T) {}
fn check_contra_rightway<'a>(x: Contravariant<'a>) {
let xref = &x;
let xstatic: &Contravariant<'static> = &x;
check_lifetime_bound::<'a>(&x);
check_lifetime_bound::<'a>(xref);
check_lifetime_bound::<'a>(xstatic);
check_lifetime_bound::<'static>(&x); // <-- this works, but...
check_lifetime_bound::<'static>(xref);
check_lifetime_bound::<'static>(xstatic);
let a: &HasLifetime<'static> = &x; // <-- this doesn't (BUG!)
let a: &HasLifetime<'static> = xstatic; // <-- nonetheless, this does work
// NB: Substituting Any for HasLifetime<'static> produces identical
// results.
}
fn check_co_wrongway<'a>(x: Covariant<'a>) {
let xref = &x;
// let xstatic: &Covariant<'static> = &x; <-- correctly fails
check_lifetime_bound::<'a>(&x);
check_lifetime_bound::<'a>(xref);
// check_lifetime_bound::<'static>(&x); <-- correctly fails
// check_lifetime_bound::<'static>(xref); <-- correctly fails
let a: &HasLifetime<'a> = &x;
}
fn check_co_rightway<'a>(x: Covariant<'static>, _: &'a i32) {
let xref = &x;
let xa: &Covariant<'a> = &x;
check_lifetime_bound::<'a>(&x);
check_lifetime_bound::<'a>(xref);
check_lifetime_bound::<'a>(xa);
check_lifetime_bound::<'static>(&x);
check_lifetime_bound::<'static>(xref);
// check_lifetime_bound::<'static>(xa); <-- this correctly fails
let a: &HasLifetime<'a> = &x;
let a: &HasLifetime<'a> = xref;
let a: &HasLifetime<'a> = xa;
// let bad: &HasLifetime<'static> = xa; <-- correctly fails
}
fn main() {}
```
Using `rustc 1.11.0 (9b21dcd6a 2016-08-15)`, I get:
```
ref_life.rs:22:36: 22:38 error: the type `Contravariant<'a>` does not fulfill the required lifetime [E0477]
ref_life.rs:22 let a: &HasLifetime<'static> = &x; // <-- this doesn't (BUG!)
^~
ref_life.rs:22:36: 22:38 note: type must outlive the static lifetime
ref_life.rs:22:36: 22:38 error: cannot infer an appropriate lifetime for lifetime parameter `'a` due to conflicting requirements [E0495]
ref_life.rs:22 let a: &HasLifetime<'static> = &x; // <-- this doesn't (BUG!)
^~
ref_life.rs:12:52: 28:2 note: first, the lifetime cannot outlive the lifetime 'a as defined on the block at 12:51...
ref_life.rs:12 fn check_contra_rightway<'a>(x: Contravariant<'a>) {
^
ref_life.rs:22:36: 22:38 note: ...so that the type `Contravariant<'a>` will meet its required lifetime bounds
ref_life.rs:22 let a: &HasLifetime<'static> = &x; // <-- this doesn't (BUG!)
^~
ref_life.rs:22:36: 22:38 note: but, the lifetime must be valid for the static lifetime...
ref_life.rs:22:36: 22:38 note: ...so that trait type parameters matches those specified on the impl (expected HasLifetime<'static>, found HasLifetime<'_>)
ref_life.rs:22 let a: &HasLifetime<'static> = &x; // <-- this doesn't (BUG!)
^~
error: aborting due to 2 previous errors
```
It seems that the rustc can match a covariant struct against a shorter lifetime bound when coercing to a trait object but that it can't match a contravariant struct against a longer timetime bound when coercing to a trait object, depite the fact that coercing directly works fine.
| C-enhancement,A-lifetimes,T-compiler,A-coercions,A-variance,T-types,A-trait-objects | low | Critical |
178,837,476 | angular | Huge performance impact on Component's host document click | **I'm submitting a ...** (check one with "x")
```
[x] bug report
[ ] feature request
[ ] support request
```
**Problem**
Performance impact when having few hundres instantiations of same component that registers on `document.click` event through `host` property in `@Component` directive.
``` ts
@Component({
selector: 'value-edit',
template: ``,
host: {
"(document: click)": "onClickOff($event)",
}
)
export class ValueEditComponent {
onClickOff(globalEvent) {
// to make sure it doesn't affect performance we keep it EMPTY!
}
}
```
**Behaviour**
Every single click wherever on the page (document) takes big amount of time, like 2-3 seconds in my case. The screenshot below shows a sequence of: wait ~5 seconds, click, wait few seconds and stop recording. The click is the huge green column on the screenshot:
**Expected behaviour**
Every single click shouldn't take seconds of processing.
**Reproduction of the problem**
[Plunker here](http://plnkr.co/edit/dWSXPihP8rePF08tiYvZ?p=preview)
Just commenting out `"(document: click)": "onClickOff($event)",` fixes the performance issue on click.
**Environment:**
- **Angular version:** 2.0.0
- **Browser:** latest stable Chrome 53.0.2785.116 m
- **Language:** TypeScript 2.0.x
[posted StackOverflow question](http://stackoverflow.com/questions/39643062/huge-performance-impact-on-components-host-document-click-angular2)
| type: bug/fix,area: performance,freq1: low,area: core,state: confirmed,core: host and host bindings,core: change detection,design complexity: major,P3 | medium | Critical |
178,860,074 | angular | ngNonBindable can't handle unescaped { characters | **I'm submitting a ...** (check one with "x")
```
[x] bug report => search github for a similar issue or PR before submitting
[ ] feature request
[ ] support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question
```
**Current behavior**
`<div>Test binding: {{2 + 2}}</div>`
=> `Test binding: 4`
`<div ngNonBindable>Test non binding: {{2 + 2}}</div>`
=> `Test binding: {{2 + 2}}`
`<div>Test non binding: {2 + 2}</div>`
=> Template parse errors, the "(Do you have an unescaped "{" in your template? Use "{{ '{' }}") to escape it.)" message.
This is a problem because precisely due to the fact that they are [ngNonBindable] marked elements, `"{{ '{' }}"` doesn't produce the expected result.
**Expected behavior**
As the escaping of `{` characters isn't possible inside [ngNonBindable] elements so it's the compiler's job to ignore them altogether, I believe.
`<div>Test non binding: {2 + 2}</div>`
=> `Test binding: {2 + 2}`
**Reproduction of the problem**
here => http://plnkr.co/edit/GSzwEUyXyY1qDabjpEL1?p=preview
- **Angular version:** 2.0.0
| freq2: medium,area: core,area: compiler,core: basic template syntax,type: use-case,P3,compiler: parser | medium | Critical |
178,992,426 | go | cmd/compile: elimination of unused runtime calls | Please answer these questions before submitting your issue. Thanks!
### What version of Go are you using (`go version`)?
`go version go1.7.1 windows/amd64`
### What operating system and processor architecture are you using (`go env`)?
```
set GOARCH=amd64
set GOBIN=
set GOEXE=.exe
set GOHOSTARCH=amd64
set GOHOSTOS=windows
set GOOS=windows
set GOPATH=C:\Dmitriy\Coding\Go\
set GORACE=
set GOROOT=C:\Dmitriy\Go
set GOTOOLDIR=C:\Dmitriy\Go\pkg\tool\windows_amd64
set CC=gcc
set GOGCCFLAGS=-m64 -mthreads -fmessage-length=0
set CXX=g++
set CGO_ENABLED=1
```
### What did you do?
Compiled simple program with two unused parameters of type `interface{}` and empty body.
https://play.golang.org/p/TkLKdhLcXo
### What did you expect to see?
Dead code elimination removing the call to `empty` and any unnecessary conversions.
### What did you see instead?
The call to `empty` was removed, but conversions are left around:
```
TEXT main.main(SB) C:/Dmitriy/Coding/Go/src/github.com/DmitriyMV/ssa_test/main.go
main.go:5 0x401040 65488b0c2528000000 GS MOVQ GS:0x28, CX
main.go:5 0x401049 488b8900000000 MOVQ 0(CX), CX
main.go:5 0x401050 483b6110 CMPQ 0x10(CX), SP
main.go:5 0x401054 0f86c1000000 JBE 0x40111b
main.go:5 0x40105a 4881ec80000000 SUBQ $0x80, SP
main.go:5 0x401061 48896c2478 MOVQ BP, 0x78(SP)
main.go:5 0x401066 488d6c2478 LEAQ 0x78(SP), BP
main.go:6 0x40106b 48c74424300a000000 MOVQ $0xa, 0x30(SP)
main.go:6 0x401074 488d1d97750900 LEAQ 0x97597(IP), BX
main.go:6 0x40107b 48895c2468 MOVQ BX, 0x68(SP)
main.go:6 0x401080 48c744247005000000 MOVQ $0x5, 0x70(SP)
main.go:6 0x401089 48c744242800000000 MOVQ $0x0, 0x28(SP)
main.go:6 0x401092 488d1de7e10700 LEAQ 0x7e1e7(IP), BX
main.go:6 0x401099 48891c24 MOVQ BX, 0(SP)
main.go:6 0x40109d 488d5c2430 LEAQ 0x30(SP), BX
main.go:6 0x4010a2 48895c2408 MOVQ BX, 0x8(SP)
main.go:6 0x4010a7 488d5c2428 LEAQ 0x28(SP), BX
main.go:6 0x4010ac 48895c2410 MOVQ BX, 0x10(SP)
main.go:6 0x4010b1 e86a930000 CALL runtime.convT2E(SB)
main.go:6 0x4010b6 488b5c2418 MOVQ 0x18(SP), BX
main.go:6 0x4010bb 48895c2458 MOVQ BX, 0x58(SP)
main.go:6 0x4010c0 488b5c2420 MOVQ 0x20(SP), BX
main.go:6 0x4010c5 48895c2460 MOVQ BX, 0x60(SP)
main.go:6 0x4010ca 31db XORL BX, BX
main.go:6 0x4010cc 48895c2438 MOVQ BX, 0x38(SP)
main.go:6 0x4010d1 48895c2440 MOVQ BX, 0x40(SP)
main.go:6 0x4010d6 488d1d63e60700 LEAQ 0x7e663(IP), BX
main.go:6 0x4010dd 48891c24 MOVQ BX, 0(SP)
main.go:6 0x4010e1 488d5c2468 LEAQ 0x68(SP), BX
main.go:6 0x4010e6 48895c2408 MOVQ BX, 0x8(SP)
main.go:6 0x4010eb 488d5c2438 LEAQ 0x38(SP), BX
main.go:6 0x4010f0 48895c2410 MOVQ BX, 0x10(SP)
main.go:6 0x4010f5 e826930000 CALL runtime.convT2E(SB)
main.go:6 0x4010fa 488b5c2418 MOVQ 0x18(SP), BX
main.go:6 0x4010ff 48895c2448 MOVQ BX, 0x48(SP)
main.go:6 0x401104 488b5c2420 MOVQ 0x20(SP), BX
main.go:6 0x401109 48895c2450 MOVQ BX, 0x50(SP)
main.go:7 0x40110e 488b6c2478 MOVQ 0x78(SP), BP
main.go:7 0x401113 4881c480000000 ADDQ $0x80, SP
main.go:7 0x40111a c3 RET
main.go:5 0x40111b e890d10400 CALL runtime.morestack_noctxt(SB)
main.go:5 0x401120 e91bffffff JMP main.main(SB)
```
Same thing happen with parameters of map[type]type. With parameter of `...interface{}` the `empty` function itself doesn't get optimized away.
While it's not a bug, it can be a handy feature for debug prints that get optimized away if build tag doesn't present.
| Performance,binary-size,compiler/runtime | low | Critical |
178,998,768 | TypeScript | Allow method type guards | **TypeScript Version:** 2.0.3
**Code**
Why I can have function type guard:
``` ts
function hasValue<T>(value: T | undefined): value is T { return value !== undefined; }
```
but not method type guard:
``` ts
export class Maybe<T> {
constructor(public value: T | undefined) {}
hasValue(): this.value is T { return this.value !== undefined; }
// ^ '{' or ';' expected.
}
```
?
| Suggestion,Awaiting More Feedback | medium | Critical |
179,002,389 | rust | Channel should not default to `dev` when built from a tarball | Today whenever Rust is built without a .git directory (approximately meaning "when it's built from a tarball") the configure script overrides the release channel to "stable", per [this PR](https://github.com/rust-lang/rust/pull/33971) and [this issue](https://github.com/rust-lang/rust/issues/28322). Unfortunately, as I [realized after a recent bug in which nightly distcheck thought it was a stable compiler](https://github.com/rust-lang/rust/pull/36678#issuecomment-249334587) this is not correct. Today, if somebody downloads a _nightly_ tarball and builds it, they will receive a compiler that claims to be a stable release. This is just not true.
I'm not sure how best to fix this. The configure script is the source of truth for the release channel, and the configure script is not telling the truth.
Here's one thing we could do: the build process that produces the tarball also dumps a `version` file into the source tree, and the release channel can be derived from that file. So when the [configure script sees that it is not in a git repo](https://github.com/rust-lang/rust/blob/master/configure#L652) it opens that file and looks for "-nightly", "-beta", or "-dev" and sets the release channel as appropriate. If it sees none of those it sets the channel to "stable". If the version file does not exist it sets the channel to "dev".
cc @alexcrichton
| P-medium,T-bootstrap,T-dev-tools,C-bug,E-needs-design | low | Critical |
179,011,638 | go | cmd/compile: optimize f32Slice[i] += 1 across math.Float32bits, Float32frombits | I'm not sure how often this arises in practice, but it did come up in https://go-review.googlesource.com/#/c/29691/ in a vector rasterizer
Roughly speaking, in func floatingAccumulateMask, I'm accumulating the elements of a []float32 and storing the (scaled) cumulative sums in an []uint32.
I don't actually need both of the individual and cumulative values at the same time. If the two slices were both []float32 or both []uint32, then I could halve the amount of memory that I need (and possibly have better cache access patterns) by writing the output elements in-place over the input elements.
I can actually still do this, even without using unsafe, with just one slice (of type []uint32), and sprinking some math.Float32bits and math.Float32frombits throughout my float32 code.
This works, in that it produces the correct output, but there is a performance penalty. In a simpler repro case, suppose that I had these global variables:
```
f32Slice []float32
u32Slice []uint32
```
and these three lines of code:
```
f32Slice[0] += 1
u32Slice[0] = uint32(1 + int32(u32Slice[0]))
u32Slice[0] = math.Float32bits(1 + math.Float32frombits(u32Slice[0]))
```
The GOARCH=amd64 codegen for each of the three lines are:
```
48 8b 05 b1 71 09 00 mov 0x971b1(%rip),%rax # 498298 <main.f32Slice+0x8>
48 8b 0d a2 71 09 00 mov 0x971a2(%rip),%rcx # 498290 <main.f32Slice>
48 85 c0 test %rax,%rax
76 3a jbe 40112d <main.main+0x12d>
f3 0f 10 01 movss (%rcx),%xmm0
f3 0f 10 0d 15 cc 06 movss 0x6cc15(%rip),%xmm1 # 46dd14 <$f32.3f800000>
00
f3 0f 58 c8 addss %xmm0,%xmm1
f3 0f 11 09 movss %xmm1,(%rcx)
```
```
48 8b 05 fe 71 09 00 mov 0x971fe(%rip),%rax # 4982b0 <main.u32Slice>
48 8b 0d ff 71 09 00 mov 0x971ff(%rip),%rcx # 4982b8 <main.u32Slice+0x8>
48 85 c9 test %rcx,%rcx
76 76 jbe 401134 <main.main+0x134>
8b 08 mov (%rax),%ecx
ff c1 inc %ecx
89 08 mov %ecx,(%rax)
```
```
48 8b 05 6c 72 09 00 mov 0x9726c(%rip),%rax # 4982b0 <main.u32Slice>
48 8b 0d 6d 72 09 00 mov 0x9726d(%rip),%rcx # 4982b8 <main.u32Slice+0x8>
48 85 c9 test %rcx,%rcx
0f 86 e7 00 00 00 jbe 40113b <main.main+0x13b>
8b 00 mov (%rax),%eax
89 44 24 0c mov %eax,0xc(%rsp)
f3 0f 10 44 24 0c movss 0xc(%rsp),%xmm0
f3 0f 10 0d ac cc 06 movss 0x6ccac(%rip),%xmm1 # 46dd14 <$f32.3f800000>
00
f3 0f 58 c1 addss %xmm1,%xmm0
f3 0f 11 44 24 08 movss %xmm0,0x8(%rsp)
8b 44 24 08 mov 0x8(%rsp),%eax
48 8b 0d 33 72 09 00 mov 0x97233(%rip),%rcx # 4982b0 <main.u32Slice>
48 8b 15 34 72 09 00 mov 0x97234(%rip),%rdx # 4982b8 <main.u32Slice+0x8>
48 85 d2 test %rdx,%rdx
0f 86 ae 00 00 00 jbe 40113b <main.main+0x13b>
89 01 mov %eax,(%rcx)
```
The codegen for the first two lines are efficient. The codegen for the third line could be better in two ways. First, there's an unnecessary bounce via the stack from memory to XMM0:
```
8b 00 mov (%rax),%eax
89 44 24 0c mov %eax,0xc(%rsp)
f3 0f 10 44 24 0c movss 0xc(%rsp),%xmm0
```
and likewise on the way back. Second, there are two bounds checks instead of one, but the second is redundant.
I am not a compiler person, but it looks to me like the Float32{,from}bits calls are treated as black box functions and not like a (no-op) uint32 to int32 conversion until too late in the codegen for e.g. the relevant bounds check elimination.
I'll let y'all decide if this is a dupe of issue #17069.
| NeedsFix,compiler/runtime | low | Major |
179,037,602 | youtube-dl | add support for pixar.com | hi,
could you please add support for pixar.com so i can view them without flash:
```
username@hostname:/tmp$ youtube-dl --verbose http://www.pixar.com/video/3790
[debug] System config: []
[debug] User config: []
[debug] Command-line args: [u'--verbose', u'http://www.pixar.com/video/3790']
[debug] Encodings: locale UTF-8, fs UTF-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2016.09.24
[debug] Python version 2.7.9 - Linux-4.2.0-0.bpo.1-amd64-x86_64-with-debian-8.5
[debug] exe versions: ffmpeg 2.8.6, ffprobe 2.8.6, rtmpdump 2.4
[debug] Proxy map: {}
[generic] 3790: Requesting header
WARNING: Falling back on generic information extractor.
[generic] 3790: Downloading webpage
[generic] 3790: Extracting information
[debug] Invoking downloader on u'http://www.pixar.com/video/3790'
[download] Destination: Pixar-3790.unknown_video
[download] 100% of 17.49KiB in 00:00
username@hostname:/tmp$ file Pixar-3790.unknown_video
Pixar-3790.unknown_video: HTML document, ASCII text, with very long lines, with CRLF, LF line terminators
```
thanks
| site-support-request | low | Critical |
Subsets and Splits
No saved queries yet
Save your SQL queries to embed, download, and access them later. Queries will appear here once saved.