id
int64
393k
2.82B
repo
stringclasses
68 values
title
stringlengths
1
936
body
stringlengths
0
256k
โŒ€
labels
stringlengths
2
508
priority
stringclasses
3 values
severity
stringclasses
3 values
172,267,413
opencv
Bug: Different round/cast orders in implicit Mat type conversion, depending on seemingly unrelated compiler flags
<!-- If you have a question rather than reporting a bug please go to http://answers.opencv.org where you get much faster responses. If you need further assistance please read [How To Contribute](https://github.com/opencv/opencv/wiki/How_to_contribute). This is a template helping you to create an issue which can be processed as quickly as possible. This is the bug reporting section for the OpenCV library. --> ##### System information (version) <!-- Example - OpenCV => 3.1 - Operating System / Platform => Windows 64 Bit - Compiler => Visual Studio 2015 --> - OpenCV => 3.0 (tested on the 3.0.0 tag and master) - Operating System / Platform => OSX10.11 and Ubuntu16.04 - Compiler => clang-703.0.29 and gcc-5.4.0 ##### Detailed description <!-- your description --> It seems that there is some poorly defined behaviour when a type conversion occurs in a `MatExpr`. Sometimes the cast (`convertTo`) happens before the multiplication operation (and therefore no precision loss because of rounding) and sometimes the cast happens after. So `cv::Mat_<float> = cv::Mat_<uint16_t> * float` (pseudocode) produces different results depending on seemingly unrelated compiler flags in the target app (i.e. OpenCV compilation is unchanged for the two different results). ##### Steps to reproduce Compile opencv fresh from master. <!-- to add code example fence it with triple backticks and optional file extension ```.cpp // C++ code example ``` or attach as .txt or .zip file --> **reproduce_conversion_fail.cpp**: ``` #include <iostream> #include <string> #include <opencv2/opencv.hpp> int main() { cv::Mat_<uint16_t> imu = cv::Mat_<uint16_t>::ones(10, 10); cv::Mat_<uint16_t> imu2 = imu * 0.001f; imu2 *= 1000.f; cv::Mat_<float> imf = imu * 0.001f; imf *= 1000.f; std::cout << "mean uint16_t: " << cv::mean(imu) << std::end; std::cout << "mean uint16_t (autorounded): " << cv::mean(imu2) << std::end; std::cout << "mean float: " << cv::mean(imf) << std::endl; } ``` `g++ reproduce_conversion_fail.cpp -I../src/opencv/install/include -L../src/opencv/install/lib -lopencv_core -lopencv_imgcodecs -std=c++11` results in: ``` mean uint16_t: [1, 0, 0, 0] mean uint16_t (autorounded): [0, 0, 0, 0] mean float: [0, 0, 0, 0] ``` or `g++ reproduce_conversion_fail.cpp -I../src/opencv/install/include -L../src/opencv/install/lib -lopencv_core -lopencv_imgcodecs` results in ``` mean uint16_t: [1, 0, 0, 0] mean uint16_t (autorounded): [0, 0, 0, 0] mean float: [1, 0, 0, 0] ``` Compiling opencv with `WITH_IPP=OFF` removes this behaviour. Not sure if the error is in the IPP-part of the code or if it just cannot be triggered with the `c++11` flag when IPP is enabled.
category: core,affected: 3.4,RFC
low
Critical
172,269,227
youtube-dl
Site support request [stopgame.ru]
- [x] I've **verified** and **I assure** that I'm running youtube-dl **2016.08.19** - [x] At least skimmed through [README](https://github.com/rg3/youtube-dl/blob/master/README.md) and **most notably** [FAQ](https://github.com/rg3/youtube-dl#faq) and [BUGS](https://github.com/rg3/youtube-dl#bugs) sections - [x] [Searched](https://github.com/rg3/youtube-dl/search?type=Issues) the bugtracker for similar issues including closed ones ### What is the purpose of your _issue_? - [x] Site support request (request for adding support for a new site) ``` >youtube-dl -vF http://stopgame.ru/gamemovie/show/390 [debug] System config: [] [debug] User config: [u'--sub-lang', u'ru,en'] [debug] Command-line args: [u'-vF', u'http://stopgame.ru/gamemovie/show/390'] [debug] Encodings: locale UTF-8, fs UTF-8, out UTF-8, pref UTF-8 [debug] youtube-dl version 2016.08.19 [debug] Python version 2.7.10 - Linux-4.1.30-gentoo-nvidia-x86_64-Intel-R-_Core-TM-2_Duo_CPU_E8400_@_3.00GHz-with-gentoo-2.2 [debug] exe versions: ffmpeg 3.1.2, ffprobe 3.1.2 [debug] Proxy map: {} [generic] 390: Requesting header WARNING: Falling back on generic information extractor. [generic] 390: Downloading webpage [generic] 390: Extracting information ERROR: Unsupported URL: http://stopgame.ru/gamemovie/show/390 Traceback (most recent call last): File "/usr/lib64/python2.7/site-packages/youtube_dl/extractor/generic.py", line 1633, in _real_extract doc = compat_etree_fromstring(webpage.encode('utf-8')) File "/usr/lib64/python2.7/site-packages/youtube_dl/compat.py", line 2525, in compat_etree_fromstring doc = _XML(text, parser=etree.XMLParser(target=_TreeBuilder(element_factory=_element_factory))) File "/usr/lib64/python2.7/site-packages/youtube_dl/compat.py", line 2514, in _XML parser.feed(text) File "/usr/lib64/python2.7/xml/etree/ElementTree.py", line 1642, in feed self._raiseerror(v) File "/usr/lib64/python2.7/xml/etree/ElementTree.py", line 1506, in _raiseerror raise err ParseError: duplicate attribute: line 2, column 37 Traceback (most recent call last): File "/usr/lib64/python2.7/site-packages/youtube_dl/YoutubeDL.py", line 691, in extract_info ie_result = ie.extract(url) File "/usr/lib64/python2.7/site-packages/youtube_dl/extractor/common.py", line 347, in extract return self._real_extract(url) File "/usr/lib64/python2.7/site-packages/youtube_dl/extractor/generic.py", line 2377, in _real_extract raise UnsupportedError(url) UnsupportedError: Unsupported URL: http://stopgame.ru/gamemovie/show/390 ``` - Single video: http://stopgame.ru/gamemovie/show/390 - Single video: http://stopgame.ru/machinima/show/536 - Playlist: http://stopgame.ru/gamemovie/genre/vghs - Playlist: http://stopgame.ru/machinima/genre/red_vs_blue
site-support-request
low
Critical
172,289,658
vscode
Improve editor.trimAutoWhitespace or cursor navigation
Loosing indent position all the time when navigating code. You loose code indent position with both navigating with the mouse or arrow keys (sick of pressing tab to get alignment back or delete then enter to get a new line with the correct indentation, or just start typing from the wrong position and use code format shortcut after entering something at a different location. - VSCode Version: 1.4.0 - OS Version: Win10 Steps to Reproduce: Edit anything with line gaps between code
feature-request,editor-core
low
Major
172,293,323
rust
Go over all libstd traits and see which of them !/TyNever should implement
E.g. `!` should implement `Default`.
T-libs-api,C-feature-accepted,F-never_type
low
Minor
172,311,848
youtube-dl
Download videos from Plex's servers?
Is it possible? Thank you in advance. :)
site-support-request,account-needed
low
Major
172,323,373
awesome-mac
Please add LittleIpsum
- LittleIpsum on the Mac App Store || https://itunes.apple.com/us/app/littleipsum/id405772121?mt=12 "The best Latin text generator for OS X. Incredibly quick and lightweight."
vote
low
Minor
172,323,567
awesome-mac
Please add CopyClip
- CopyClip - Clipboard History Manager on the Mac App Store || https://itunes.apple.com/us/app/copyclip-clipboard-history/id595191960?mt=12 "CopyClip is the simplest and most efficient clipboard manager for your Mac. Running discreetly from your menu bar, this app stores all that you have copied or cut in the past, allowing you to quickly find that snippet of text you've been looking for."
addition
low
Minor
172,324,801
rust
Implementation of Index<Foo> prevents indexing arrays by other index types
``` rust use std::ops::Index; enum Foo { Zero, One, Two, } impl Index<Foo> for [u8; 3] { type Output = u8; fn index(&self, index: Foo) -> &u8 { unsafe { self.get_unchecked(index as usize) } } } fn main() { let arr: [u8; 3] = [0, 1, 2]; // OK: let _ = arr[Foo::Two]; // Error: let _ = arr[2usize]; // ^^^^^^ expected enum `Foo`, found `usize` // Error: let _ = &arr[0usize..2]; // ^^^^^^^^^ expected enum `Foo`, found struct `std::ops::Range<usize>` // Error: let _ = &arr[..]; // ^^ expected enum `Foo`, found struct `std::ops::RangeFull` } ```
A-type-system,T-compiler,C-bug,A-array,T-types
low
Critical
172,332,757
TypeScript
Give a better error message when an import isn't found but a namespace of the same name exists
See #10463. `foo.d.ts` ``` ts declare module foo { // ... } ``` `bar.ts` ``` ts import foo = require("foo"); ``` `"foo"` won't be found, but if the compiler can resolve an identifier named `foo` to a namespace that uses the `declare module` syntax, we should probably give an error like ``` Cannot find module 'foo'. A legacy-style namespace with the same name was found. Try changing the declaration to use quotes (e.g. 'declare module "foo"'). ```
Bug,Help Wanted,Effort: Moderate,Domain: Error Messages
low
Critical
172,370,268
youtube-dl
Site support - oniseptv
- [x] I've **verified** and **I assure** that I'm running youtube-dl **2016.08.22** ### Before submitting an _issue_ make sure you have: - [x] At least skimmed through [README](https://github.com/rg3/youtube-dl/blob/master/README.md) and **most notably** [FAQ](https://github.com/rg3/youtube-dl#faq) and [BUGS](https://github.com/rg3/youtube-dl#bugs) sections - [x] [Searched](https://github.com/rg3/youtube-dl/search?type=Issues) the bugtracker for similar issues including closed ones ### What is the purpose of your _issue_? - [ ] Bug report (encountered problems with youtube-dl) - [x] Site support request (request for adding support for a new site) - [ ] Feature request (request for a new functionality) - [ ] Question - [ ] Other --- --- ### If the purpose of this _issue_ is a _bug report_, _site support request_ or you are not completely sure provide the full verbose output as follows: Add `-v` flag to **your command line** you run youtube-dl with, copy the **whole** output and insert it here. It should look similar to one below (replace it with **your** log inserted between triple ```): ``` $ ./youtube-dl -v https://oniseptv.onisep.fr/video/ce-sera-moi-tania-decoratrice-d-interieur [debug] System config: [] [debug] User config: [] [debug] Command-line args: [u'-v', u'https://oniseptv.onisep.fr/video/ce-sera-moi-tania-decoratrice-d-interieur'] [debug] Encodings: locale UTF-8, fs UTF-8, out UTF-8, pref UTF-8 [debug] youtube-dl version 2016.08.22 [debug] Python version 2.7.11 - Linux-4.4.0-34-generic-x86_64-with-debian-stretch-sid [debug] exe versions: avconv 2.8.6-1ubuntu2, avprobe 2.8.6-1ubuntu2, ffmpeg 2.8.6-1ubuntu2, ffprobe 2.8.6-1ubuntu2 [debug] Proxy map: {} [generic] ce-sera-moi-tania-decoratrice-d-interieur: Requesting header WARNING: Falling back on generic information extractor. [generic] ce-sera-moi-tania-decoratrice-d-interieur: Downloading webpage [generic] ce-sera-moi-tania-decoratrice-d-interieur: Extracting information ERROR: Unsupported URL: https://oniseptv.onisep.fr/video/ce-sera-moi-tania-decoratrice-d-interieur Traceback (most recent call last): File "./youtube-dl/youtube_dl/extractor/generic.py", line 1633, in _real_extract doc = compat_etree_fromstring(webpage.encode('utf-8')) File "./youtube-dl/youtube_dl/compat.py", line 2525, in compat_etree_fromstring doc = _XML(text, parser=etree.XMLParser(target=_TreeBuilder(element_factory=_element_factory))) File "./youtube-dl/youtube_dl/compat.py", line 2514, in _XML parser.feed(text) File "/home/spontex/miniconda2/lib/python2.7/xml/etree/ElementTree.py", line 1642, in feed self._raiseerror(v) File "/home/spontex/miniconda2/lib/python2.7/xml/etree/ElementTree.py", line 1506, in _raiseerror raise err ParseError: syntax error: line 1, column 0 Traceback (most recent call last): File "./youtube-dl/youtube_dl/YoutubeDL.py", line 691, in extract_info ie_result = ie.extract(url) File "./youtube-dl/youtube_dl/extractor/common.py", line 347, in extract return self._real_extract(url) File "./youtube-dl/youtube_dl/extractor/generic.py", line 2377, in _real_extract raise UnsupportedError(url) UnsupportedError: Unsupported URL: https://oniseptv.onisep.fr/video/ce-sera-moi-tania-decoratrice-d-interieur ``` --- ### If the purpose of this _issue_ is a _site support request_ please provide all kinds of example URLs support for which should be included (replace following example URLs by **yours**): - Single video: https://oniseptv.onisep.fr/video/ce-sera-moi-tania-decoratrice-d-interieur - Single video: https://oniseptv.onisep.fr/video/ce-sera-moi-evan-journaliste-sportif - Playlist: http://www.onisep.fr/Decouvrir-les-metiers/Actus-2015/Ce-sera-moi/Ce-sera-moi-Demain-je-serai-animatrice-en-centre-de-loisirs --- ### Description of your _issue_, suggested solution and other information I could not find the video files inside the HTML source code, neither could the generic converter :-)
site-support-request
low
Critical
172,475,567
go
cmd/compile: should recognize binary package and intrinsify it where possible
The compiler should recognize calls to binary.Reader and binary.Writer where the byte order and type of `data interface{}` are compile-time constants, and based on that "do the right thing". One candidate for "the right thing" is, for target/source types that contain no padding and for the native byte order, alias a byte slice to the storage, and pass that to the read or write method. Further enhancements could deal with padding and mismatched native/requested byte order.
Performance,compiler/runtime
low
Major
172,490,198
TypeScript
Warn/error when testing a non-nullable type for null
**TypeScript Version:** 2.0.0 **TL;DR:** If a project is configured for strict null checks, checking a variable which is typed as non-null is nonsense and could indicate a type mismatch. **Code:** Here's a motivating example I experienced: ``` ts async function someFunc1(): Promise<string | null> { // do some stuff and return the appropriately typed promise } async function someFunc2(): Promise<boolean> { // Negating a non-null Promise is crazy talk, but here I go! return !!someFunc1() } ``` Of course what I _really_ meant was: ``` ts async function someFunc2(): Promise<boolean> { return !!(await someFunc1()) } ``` **Expected behavior:** TypeScript warns that I'm effectively testing my non-null `Promise` for null, and points out that that's nonsense. **Actual behavior:** TypeScript happily accepted the code, which led to a bug.
Suggestion,Awaiting More Feedback
low
Critical
172,535,692
rust
incr. comp.: Increase partition granularity via special-casing non-inlined functions
If we put every function into its own codegen unit, we would minimize the amount of functions being re-translated even though they have not changed. The main reason we don't do this, is because it would completely prevent inlining, which in turn has too detrimental an effect on runtime performance. However, for many functions we could probably predict very well that they would never get inlined by LLVM anyway, because they are marked with `#[inline(never)]` or they are just too big. This category of functions could be put into their own codegen unit without negative effects on runtime performance.
C-enhancement,T-compiler,A-incr-comp
low
Major
172,538,034
go
runtime: simplify brk_ usage on plan9
Brad pointed out in [CL 27491](https://go-review.googlesource.com/#/c/27491) that the addr argument to func brk_ is unused. We should remove it, update the assembly argument size on arm, and simplify the calling code. Leaving for someone with a plan9 installation to do and test.
OS-Plan9,compiler/runtime
low
Minor
172,566,264
javascript
Error in 16.1
Hello, In 16.1, it says: > Use braces with all multi-line blocks. But in the examples, there's a contradiction: ``` // good if (test) return false; ``` And ``` // bad function foo() { return false; } ``` The second one shouldn't say 'bad' since it's not multi-line block like the rule says.
pull request wanted,semver-breaking: guide change,editorial
low
Critical
172,644,151
rust
Adding type annotation equivalent to existing type changes code semantics
This piece of code can't compile: ``` fn main() { let y = &mut 2i32; { let x = y; *x = 3; } println!("{}", y); } ``` But, if we add the type annotation, it compiles: ``` fn main() { let y = &mut 2i32; { let x: &mut i32 = y; *x = 3; } println!("{}", y); } ``` I guess the later form triggers "auto-deref" mechanism, which equals to: ``` let x = &mut *y; ``` But this behaviour is still very confusing. Type annotation or not doesn't change the type of `x` at all. Type of `x` is always `&mut i32`. But they lead to different compile result. I have no idea whether should we fix it.
A-type-system,C-enhancement,E-mentor,T-compiler,T-types
low
Major
172,685,824
opencv
StereoBM disparity width reduced problem (SSE2)
<!-- If you have a question rather than reporting a bug please go to http://answers.opencv.org where you get much faster responses. If you need further assistance please read [How To Contribute](https://github.com/opencv/opencv/wiki/How_to_contribute). This is a template helping you to create an issue which can be processed as quickly as possible. This is the bug reporting section for the OpenCV library. --> ##### System information (version) <!-- Example - OpenCV => 3.1 - Operating System / Platform => Windows 64 Bit - Compiler => Visual Studio 2015 --> - OpenCV => 3.1 (latest commit in master 3d5700655fca14fe075b79f913255d1ab47fb97e) - Operating System / Platform => Ubuntu 16.04.1 LTS - Compiler => gcc (Ubuntu 5.4.0-6ubuntu1~16.04.2) ##### Detailed description Greetings, I stumbled upon a problem while computing and analysing the disparity map created by StereoBM using SSE2. For input images I used aloeL.jpg and aloeR.jpg from samples/data of OpenCV. When computing a disparity map with `cv::Mat_<float>` as the type of the resulting disparity and with `setPreFilterCap` > 31 or `setBlockSize` > 21, I get a normal looking disparity map: Parameters used: - disparities: 160 - block size: 21 - pre filter cap: 32 Scale of the resulting map: - max: 159.059 - min: -1 Result (scaled [0, 255]): ![aloe_disp_cap_32](https://cloud.githubusercontent.com/assets/4293865/17890321/80ba5a3e-6935-11e6-812b-e4a9e35af25a.png) The problem arises when I change `setPreFilterCap` to 31. The horizontal resolution of the disparity map is reduced and the scale of the resulting map jumped by roughly 4096 times. Parameters used: - disparities: 160 - block size: 21 - pre filter cap: 31 Scale of the resulting map: - max: 651520 - min: -4096 Result (scaled [0, 255]): ![aloe_disp_cap_31](https://cloud.githubusercontent.com/assets/4293865/17890539/f5e7bfd0-6936-11e6-95ec-0c4a919fe64c.png) When I traced the cause of this problem I found this line to be the root of the problem: modules/calib3d/src/stereobm.cpp [line 1170-1172]: ``` #if CV_SSE2 bool useShorts = params.preFilterCap <= 31 && params.SADWindowSize <= 21 && checkHardwareSupport(CV_CPU_SSE2); #else ``` **[Edit 1:** modules/calib3d/src/stereobm.cpp [line 1016-1021]: ``` #if CV_SSE2 if( useShorts ) findStereoCorrespondenceBM_SSE2( left_i, right_i, disp_i, cost_i, *state, ptr, row0, rows - row1 ); else #endif findStereoCorrespondenceBM( left_i, right_i, disp_i, cost_i, *state, ptr, row0, rows - row1 ); ``` The condition of `useShorts` matches with my findings, so if `useShorts` is true the problem arises if not, all is good. So it seems the SSE2 implementation is broken. **Edit 1]** On the other hand if the type of resulting map is declared as `cv::Mat` the map's horizontal resolution is not reduced but the scale jumps by 16 times. Parameters used: - disparities: 160 - block size: 21 - pre filter cap: 31 Scale of the resulting map: - max: 2544 - min: -16 Result (scaled [0, 255]): ![aloe_disp_cap_31](https://cloud.githubusercontent.com/assets/4293865/17890902/1adf5634-6939-11e6-89bb-27d909f47285.png) IMHO this is not the supposed behaviour because changing the pre-filter parameters should not affect the width and/or scale of the disparity map. Cheers ##### Steps to reproduce <!-- to add code example fence it with triple backticks and optional file extension ```.cpp // C++ code example ``` or attach as .txt or .zip file --> ``` .cpp #include <iostream> #include <opencv2/calib3d.hpp> #include <opencv2/highgui.hpp> int main(int argc, char* argv[]) { cv::Mat leftFrame, rightFrame; leftFrame = cv::imread(argv[1], cv::IMREAD_GRAYSCALE); rightFrame = cv::imread(argv[2], cv::IMREAD_GRAYSCALE); int numDisparities = 160; cv::Ptr<cv::StereoBM> sbm; sbm = cv::StereoBM::create(numDisparities, 21); sbm->setPreFilterCap(31); cv::Mat_<float> disp; cv::Mat disp8; sbm->compute(leftFrame, rightFrame, disp); double min, max; cv::minMaxLoc(disp, &min, &max); std::cout << "Max: " << max << " Min: " << min << std::endl; disp.convertTo(disp8, CV_8UC1, 255. / (numDisparities - 1)); cv::imshow("Disparity", disp8); cv::waitKey(0); return 0; } ```
bug,category: calib3d,affected: 3.4
low
Critical
172,723,324
TypeScript
Template string downlevel to ES5 escapes more Unicode characters than necessary
<!-- BUGS: Please use this template. --> <!-- QUESTIONS: This is not a general support forum! Ask Qs at http://stackoverflow.com/questions/tagged/typescript --> <!-- SUGGESTIONS: See https://github.com/Microsoft/TypeScript-wiki/blob/master/Writing-Good-Design-Proposals.md --> **TypeScript Version:** 1.8.10 Typescript compiles template strings with Unicode characters incorrectly. **Code** ``` ts var test1: string = 'test'; // Normal string (only English) var test2: string = `test`; // Template string (only English) var test3: string = 'ั‚ะตัั‚'; // Normal string (Cyrillic) var test4: string = `ั‚ะตัั‚`; // Template string (Cyrillic) ``` **Expected behavior:** There should be no significant difference in string representation, no matter language they are using. Since this is Unicode anyway. You can see expected behavior on standard, singleline strings. This behavior I would consider normal, expected. ``` js var test1 = 'test'; // Normal string (only English) var test2 = "test"; // Template string (only English) var test3 = 'ั‚ะตัั‚'; // Normal string (Cyrillic) var test4 = "ั‚ะตัั‚"; // Template string (Cyrillic) ``` **Actual behavior:** Multiline (template) strings with none-English characters becomes encoded. ``` js var test1 = 'test'; // Normal string (only English) var test2 = "test"; // Template string (only English) var test3 = 'ั‚ะตัั‚'; // Normal string (Cyrillic) var test4 = "\u0442\u0435\u0441\u0442"; // Template string (Cyrillic) ``` Link to official [playground](http://www.typescriptlang.org/play/#src=var%20test1%3A%20string%20%3D%20%27test%27%3B%20%2F%2F%20Normal%20string%20%28only%20English%29%0D%0Avar%20test2%3A%20string%20%3D%20%60test%60%3B%20%2F%2F%20Template%20string%20%28only%20English%29%0D%0Avar%20test3%3A%20string%20%3D%20%27%D1%82%D0%B5%D1%81%D1%82%27%3B%20%2F%2F%20Normal%20string%20%28Cyrillic%29%0D%0Avar%20test4%3A%20string%20%3D%20%60%D1%82%D0%B5%D1%81%D1%82%60%3B%20%2F%2F%20Template%20string%20%28Cyrillic%29)
Suggestion,Help Wanted,Experience Enhancement
low
Critical
172,758,875
kubernetes
Hung volumes can wedge the kubelet
If you have pods that use something like NFS storage, if the system is unable to read the mounted directory, or unmount it, it is possible to completely wedge the kubelet such that it can't successfully run any new pods that use volumes (which is basically all, if they use secret tokens) until either the storage issue is resolved, or you restart the kubelet. To reproduce: 1. Create a pod that uses an NFS volume 2. Stop the NFS server 3. Try to delete the pod 4. Wait a couple of minutes - you'll see the pod stuck Terminating 5. Try to create a new pod (`kubectl run --rm --attach --restart Never --image busybox bbox date`) The busybox pod will be stuck ContainerCreating with events such as these: ``` Events: FirstSeen LastSeen Count From SubobjectPath Type Reason Message --------- -------- ----- ---- ------------- -------- ------ ------- 8m 8m 1 {default-scheduler } Normal Scheduled Successfully assigned bbox to 127.0.0.1 6m 6s 4 {kubelet 127.0.0.1} Warning FailedMount Unable to mount volumes for pod "bbox_default(12a20cdb-694f-11e6-baa4-001c42e13e5d)": timeout expired waiting for volumes to attach/mount for pod "bbox"/"default". list of unattached/unmounted volumes=[default-token-joiwi] 6m 6s 4 {kubelet 127.0.0.1} Warning FailedSync Error syncing pod, skipping: timeout expired waiting for volumes to attach/mount for pod "bbox"/"default". list of unattached/unmounted volumes=[default-token-joiwi] ``` In this [stack trace](https://gist.github.com/ncdc/d6411b82cd6169991dc3b98c203f59e1#file-stack-deleting-pod-txt-L53-L67) I gathered after I deleted the pod, it shows that the volume reconciler is still trying to get the volumes for the pod I just deleted. You'll also see a goroutine trying to stop the Docker container, but it is stuck. In this [stack trace](https://gist.github.com/ncdc/d6411b82cd6169991dc3b98c203f59e1#file-stack-run-pod-txt-L32-L41) I gathered after I tried to create the bbox pod, it shows that the new pod (bbox) is waiting for its volumes to attach/mount (in this case, secrets). We've seen this in 1.2.x and I just reproduced it in master (commit f297ea966e0916c18dc008af566975bd26dfb29c). cc @kubernetes/sig-storage @kubernetes/sig-node @kubernetes/rh-cluster-infra @pmorie @derekwaynecarr @timothysc @saad-ali
kind/bug,priority/important-soon,area/kubelet,sig/storage,lifecycle/frozen
high
Critical
172,988,027
youtube-dl
[LeEco] Download 'Album' related to a video
### Make sure you are using the _latest_ version: run `youtube-dl --version` and ensure your version is _2016.08.24.1_. If it's not read [this FAQ entry](https://github.com/rg3/youtube-dl/blob/master/README.md#how-do-i-update-youtube-dl) and update. Issues with outdated version will be rejected. - [x] I've **verified** and **I assure** that I'm running youtube-dl **2016.06.25** ### Before submitting an _issue_ make sure you have: - [ ] At least skimmed through [README](https://github.com/rg3/youtube-dl/blob/master/README.md) and **most notably** [FAQ](https://github.com/rg3/youtube-dl#faq) and [BUGS](https://github.com/rg3/youtube-dl#bugs) sections - [x] [Searched](https://github.com/rg3/youtube-dl/search?type=Issues) the bugtracker for similar issues including closed ones ### What is the purpose of your _issue_? - [ ] Bug report (encountered problems with youtube-dl) - [ ] Site support request (request for adding support for a new site) - [x] Feature request (request for a new functionality) - [ ] Question - [ ] Other --- ### The following sections concretize particular purposed issues, you can erase any section (the contents between triple ---) not applicable to your _issue_ --- ### If the purpose of this _issue_ is a _site support request_ please provide all kinds of example URLs support for which should be included (replace following example URLs by **yours**): - http://www.le.com/ptv/vplay/22246607.html --- ### Description of your _issue_, suggested solution and other information It would be helpful to be able to download video playlist in the "Album" that a video belong to. The album playlist was displayed at the right sidebar of a video if available. - http://www.le.com/ptv/vplay/22282706.html - http://www.le.com/ptv/vplay/22246607.html
request
low
Critical
172,993,029
go
x/text/search: WholeWord and Exact options are nil
1. What version of Go are you using (`go version`)? go1.7 2. What operating system and processor architecture are you using (`go env`)? linux/amd64 3. What did you do? https://play.golang.org/p/GNfQa_7pq3 4. What did you expect to see? -1, -1 5. What did you see instead? ``` panic: runtime error: invalid memory address or nil pointer dereference [snip] $GOPATH/src/golang.org/x/text/search/search.go:82 [snip] ``` This is perhaps a case of "I didn't read the var definition carefully enough", but having exported symbols that crash is unfortunate.
NeedsInvestigation
low
Critical
173,032,232
youtube-dl
[Nico Nico Douga] "Unable to find video URL" error when downloading videos above 100MB
- [x] I've **verified** and **I assure** that I'm running youtube-dl **2016.08.24.1** - [x] At least skimmed through [README](https://github.com/rg3/youtube-dl/blob/master/README.md) and **most notably** [FAQ](https://github.com/rg3/youtube-dl#faq) and [BUGS](https://github.com/rg3/youtube-dl#bugs) sections - [x] [Searched](https://github.com/rg3/youtube-dl/search?type=Issues) the bugtracker for similar issues including closed ones --- edit: error still present in 2016.09.19 update (another crashing example: http://www.nicovideo.jp/watch/sm29698977) You might be aware that Nico Nico Douga raised its upload limit to 1.5GB instead of what formerly was 100MB after August 18th 2016. Some users already began uploading content above 100MB, and this apparently causes some trouble to our well known "video downloaders". Now when trying to attempt to download such content with youtube-dl, I'm rewarded by a strange and irrelevant "Unable to find video URL" when it actually tries to retrieve data and gather video info. And yes, I'm using the latest version to date and am actually using my login credentials to download the video. For the moment, only VideoDownloadHelper (Firefox add-on) manages to download this particular video (featured in the log) but it unfortunately fails before the end. - Here's one of the incriminating videos: http://www.nicovideo.jp/watch/sm29513760 - Here's my log (user and password replaced by ***): ``` F:\>youtube-dl -v -u *** -p *** http://www.nicovideo.jp/watch/sm29513760 [debug] System config: [] [debug] User config: [] [debug] Command-line args: ['-v', '-u', 'PRIVATE', '-p', 'PRIVATE', 'http://www.nicovideo.jp/watch/sm29513760'] [debug] Encodings: locale cp1252, fs mbcs, out cp1252, pref cp1252 [debug] youtube-dl version 2016.08.24.1 [debug] Python version 3.4.4 - Windows-XP-5.1.2600-SP3 [debug] exe versions: ffmpeg 2.8.4, ffprobe N-67999-gd0879a9 [debug] Proxy map: {} ERROR: Unable to find video URL; please report this issue on https://yt-dl.org/ ug . Make sure you are using the latest version; type youtube-dl -U to update Be sure to call youtube-dl with the --verbose flag and include its complete ou put. Traceback (most recent call last): File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpvarrvgfb\bild\youtube_dl\YoutubeDL.py", line 691, in extract_info File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpvarrvgfb\bild\youtube_dl\extractor\common.py", line 347, in extract File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpvarrvgfb\bild\youtube_dl\extractor\niconico.py", line 161, in _real_extract youtube_dl.utils.ExtractorError: Unable to find video URL; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type youtube-dl -U to update. Be sure to call youtube-dl with the --verbose flag and include its complete output. ``` - Another log (from a different environment, Ubuntu 16.04): ``` $ youtube-dl -v -u *** -p *** http://www.nicovideo.jp/watch/sm29513760 [debug] System config: [] [debug] User config: [] [debug] Command-line args: [u'-v', u'-u', u'PRIVATE', u'-p', u'PRIVATE', u'http://www.nicovideo.jp/watch/sm29513760'] [debug] Encodings: locale UTF-8, fs UTF-8, out UTF-8, pref UTF-8 [debug] youtube-dl version 2016.08.24.1 [debug] Python version 2.7.12 - Linux-4.4.0-34-generic-x86_64-with-Ubuntu-16.04-xenial [debug] exe versions: avconv 2.8.6-1ubuntu2, avprobe 2.8.6-1ubuntu2, ffmpeg 2.8.6-1ubuntu2, ffprobe 2.8.6-1ubuntu2, rtmpdump 2.4 [debug] Proxy map: {} [niconico] Logging in [niconico] sm29513760: Downloading webpage [niconico] sm29513760: Downloading video info page [niconico] sm29513760: Downloading flv info ERROR: Unable to find video URL; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type youtube-dl -U to update. Be sure to call youtube-dl with the --verbose flag and include its complete output. Traceback (most recent call last): File "/usr/local/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 691, in extract_info ie_result = ie.extract(url) File "/usr/local/bin/youtube-dl/youtube_dl/extractor/common.py", line 347, in extract return self._real_extract(url) File "/usr/local/bin/youtube-dl/youtube_dl/extractor/niconico.py", line 161, in _real_extract raise ExtractorError('Unable to find video URL') ExtractorError: Unable to find video URL; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type youtube-dl -U to update. Be sure to call youtube-dl with the --verbose flag and include its complete output. ```
account-needed
low
Critical
173,070,871
flutter
pop() improvements
A route should have a way to override NavigatorState.pop()'s concept of whether this is the home route, such that popping it quits the app even though there's other routes on the history behind it. For example, so that you can have a login screen, then once you've logged in, you see the main page of the app, and "back" sends you out of the app not back to the login screen. popUntil() (and thus pop()) probably need a way to override that, so that you can manually pop past such routes. For example, so that you can "log out" of an app as described above, and return to the "login" page.
c: new feature,framework,customer: fast (g3),f: routes,P3,team-framework,triaged-framework
low
Minor
173,071,311
flutter
Give authors more control over initialRoute handling
Imagine you had an app that required visiting a login page before interacting with it. Right now, a user could cheat by launching the app with an intent that sets the defaultRoute.
framework,customer: fast (g3),f: routes,P3,team-framework,triaged-framework
low
Minor
173,081,018
go
cmd/compile: inline reflect.TypeOf (or make it intrinsic)
@randall77 was mentioning the compiler maybe inlining reflect.TypeOf calls the other day. Or somebody was. Today I ran across the github.com/vmware/govmomi/vim25/types package which has 5769 calls to reflect.TypeOf, populating a map: ``` types.go: t["WillLoseHAProtection"] = reflect.TypeOf((*WillLoseHAProtection)(nil)).Elem() types.go: t["WillLoseHAProtectionFault"] = reflect.TypeOf((*WillLoseHAProtectionFault)(nil)).Elem() types.go: t["WillModifyConfigCpuRequirements"] = reflect.TypeOf((*WillModifyConfigCpuRequirements)(nil)).Elem() types.go: t["WillModifyConfigCpuRequirementsFault"] = reflect.TypeOf((*WillModifyConfigCpuRequirementsFault)(nil)).Elem() types.go: t["WillResetSnapshotDirectory"] = reflect.TypeOf((*WillResetSnapshotDirectory)(nil)).Elem() types.go: t["WillResetSnapshotDirectoryFault"] = reflect.TypeOf((*WillResetSnapshotDirectoryFault)(nil)).Elem() types.go: t["WinNetBIOSConfigInfo"] = reflect.TypeOf((*WinNetBIOSConfigInfo)(nil)).Elem() types.go: t["WipeDiskFault"] = reflect.TypeOf((*WipeDiskFault)(nil)).Elem() types.go: t["WipeDiskFaultFault"] = reflect.TypeOf((*WipeDiskFaultFault)(nil)).Elem() types.go: t["XmlToCustomizationSpecItem"] = reflect.TypeOf((*XmlToCustomizationSpecItem)(nil)).Elem() types.go: t["XmlToCustomizationSpecItemRequestType"] = reflect.TypeOf((*XmlToCustomizationSpecItemRequestType)(nil)).Elem() types.go: t["ZeroFillVirtualDiskRequestType"] = reflect.TypeOf((*ZeroFillVirtualDiskRequestType)(nil)).Elem() types.go: t["ZeroFillVirtualDisk_Task"] = reflect.TypeOf((*ZeroFillVirtualDisk_Task)(nil)).Elem() ``` If the compiler could inline the `reflect.TypeOf` calls then they could stop autogenerating the Elem part too, and it's all just static data and their init load could drop a bunch. reflect.TypeOf is just: ``` go // TypeOf returns the reflection Type that represents the dynamic type of i. // If i is a nil interface value, TypeOf returns nil. func TypeOf(i interface{}) Type { eface := *(*emptyInterface)(unsafe.Pointer(&i)) return toType(eface.typ) } func toType(t *rtype) Type { if t == nil { return nil } return t } ``` Low priority.
Performance,compiler/runtime
low
Major
173,111,454
rust
cyclic type "of infinite size" may not be
rustc's error message "cyclic type of infinite size" is produced whenever a type parameter is inferred to refer to the type it's a parameter of, but this does not need to actually result in an infinitely sized type. I think such cyclic types should be allowed, but at minimum the error message should be improved. For example: ``` rust use std::cell::Cell; struct Foo<'a, T: 'a>(Cell<Option<&'a T>>); fn main() { let foo = Foo(Cell::new(None)); foo.0.set(Some(&foo)); } ``` produces: ``` error[E0308]: mismatched types --> test.rs:5:20 | 5 | foo.0.set(Some(&foo)); | ^^^^ cyclic type of infinite size | = note: expected type `&_` = note: found type `&Foo<'_, _>` error: aborting due to previous error ```
A-type-system,A-diagnostics,T-compiler,C-bug,T-types
low
Critical
173,138,502
angular
HttpParameterCodec improperly encodes special characters like '+' and '='
**I'm submitting a ...** ``` [x ] bug report => search github for a similar issue or PR before submitting [ ] feature request [ ] support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question ``` **Current behavior** Code exemple ``` let body = new URLSearchParams(); for (let i in values) { body.set(i, values[i]); } let options = RequestOptions(); options.headers.append('Content-Type', 'application/x-www-form-urlencoded') return this.http.post(uri, body, options).then(); [...] ``` If `values[i]` has a '+' character in it, then it is replaced by spaces. **Expected/desired behavior** '+' should be sent as any other character. **Please tell us about your environment:** - **Angular version:** 2.0.0-rc.5 - **Browser:** [all | Chrome XX | Firefox XX | IE XX ] - **Language:** [Typescript]
breaking changes,freq2: medium,area: common/http,state: has PR,risk: high,state: confirmed,design complexity: low-hanging,P3,risky
high
Critical
173,192,498
vscode
Auto hide panel
Similar to behavior in Visual Studio, is there a way we could get the terminal to show/hide automatically? Leaving some sort of tab at the bottom of the screen? It opens when: 1. User mouses over the tab 2. Something is written to the terminal It hides when: 1. User clicks outside of the open terminal window. 2. The terminal has not been written to within a set period of ~10 seconds. Ex: I'm working on an Angular 2 application using the angular-cli build tool. When I'm writing code or clicking through the UI I don't particularly care about what's displaying in the terminal. But as soon as I save my changes and the build process starts, I DO want to quickly see what the current state of the build is. So after saving a file, when the CLI tool starts writing to the terminal, it would pop-up from the bottom, and as long as my mouse isn't hovering over it, it will hide again after several seconds of inactivity.
feature-request,layout
high
Critical
173,306,082
youtube-dl
Facebook F8 and/or Facebook Videos Needed
Hello, I need to download: 1. Facebook F8 videos from url: https://developers.facebook.com/videos 2. Facebook videos from url: https://web.facebook.com/FacebookforDevelopers/videos 3. All videos-only(no pics) from url: https://twitter.com/FacebookDevRel/media Please tell me how can I download them.
request
low
Minor
173,319,376
rust
Constant let binding slower than const
Hello. I am currently optimizing my [`des`](https://crates.io/crates/des) crate and I found out that using a `let` statement can be significantly slower than using a `const` statement. For instance, when I run `cargo bench` with the `const` declaration [here](https://github.com/antoyo/des-rs/blob/97031b96ebb2534a8b0bb9cf3cc675048fb0d742/src/lib.rs#L258), I get: ``` running 1 test test bench_decrypt ... bench: 1,621 ns/iter (+/- 15) ``` If I replace this `const` by a `let`, the performance is not as good: ``` running 1 test test bench_decrypt ... bench: 18,203 ns/iter (+/- 99) ``` On another benchmark, I think it was 4 times slower with `let`. I expected to have the same performance with a constant `let` and a `const`. Instead, the `let` declaration is slower than a `const`. ## Meta `rustc --version --verbose`: ``` rustc 1.13.0-nightly (aef6971ca 2016-08-17) binary: rustc commit-hash: aef6971ca96be5f04291420cc773b8bfacb8b36d commit-date: 2016-08-17 host: x86_64-unknown-linux-gnu release: 1.13.0-nightly ``` Thanks to fix this issue.
I-slow,C-enhancement,A-codegen,T-compiler,C-optimization
low
Major
173,457,464
go
x/tools/cmd/goimports: permission denied causes imports to stop
Please answer these questions before submitting your issue. Thanks! 1. What version of Go are you using (`go version`)? ``` go version go1.7 darwin/amd64 ``` 1. What operating system and processor architecture are you using (`go env`)? ``` GOARCH="amd64" GOBIN="" GOEXE="" GOHOSTARCH="amd64" GOHOSTOS="darwin" GOOS="darwin" GOPATH="/Users/jeffwilliams/go" GORACE="" GOROOT="/usr/local/Cellar/go/1.7/libexec" GOTOOLDIR="/usr/local/Cellar/go/1.7/libexec/pkg/tool/darwin_amd64" CC="clang" GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/jc/ctl0fvhs34v21m_hg1z3w0zh0000gp/T/go-build379181819=/tmp/go-build -gno-record-gcc-switches -fno-common" CXX="clang++" CGO_ENABLED="1" ``` 1. What did you do? If possible, provide a recipe for reproducing the error. A complete runnable program is good. A link on play.golang.org is best. One unreadable dir in GOPATH will cause the walk to fail and ignore all directories after that point, with a confusing message like: ``` 2016/08/26 15:39:24 goimports: scanning directory /Users/jeffwilliams/go/src: permission denied ``` In this case, it was a test dir with permissions 0000: ``` /Users/jeffwilliams/go/src/github.com/wherethebitsroam/cloudcp/test/fred/dave ``` Admittedly, moving this test content into testdata where it should have been fixed the problem. But this is not very obvious given the error. The relevant code was golang.org/x/tools/imports/fastwalk_unix.go: ``` fd, err := syscall.Open(dirName, 0, 0) ``` 1. What did you expect to see? goimports to skip the directory with permission denied. Or at least give an error with the directory which was the problem. 1. What did you see instead? goimports failed to insert the imports for known packages in the file being processed.
help wanted,Tools
medium
Critical
173,491,981
flutter
AppBar shadow does not extend to the edge of the screen (particularly noticeable during back gesture)
On iOS, when swiping back, you can see a small portion that is missing its shadow. It's especially visible during the back gesture action, because of the contrast. Notice how in the upper left of the shadow, right under the blue app bar that is moving off the page, you see an area that is lighter than the rest. The effect is more pronounced on your phone itself, as you're moving the view off the screen. ![cbbf0129-bcec-4d83-a2d2-ba4dff83b30a_png](https://cloud.githubusercontent.com/assets/5479/18012594/18965304-6b6f-11e6-99c7-ff71c7973f87.png)
framework,f: material design,a: fidelity,a: quality,has reproducible steps,P3,team-design,triaged-design,found in release: 3.19,found in release: 3.20
low
Major
173,498,223
TypeScript
Strange boolean-discriminant narrowing with strictNullChecks off
<!-- BUGS: Please use this template. --> <!-- QUESTIONS: This is not a general support forum! Ask Qs at http://stackoverflow.com/questions/tagged/typescript --> <!-- SUGGESTIONS: See https://github.com/Microsoft/TypeScript-wiki/blob/master/Writing-Good-Design-Proposals.md --> **TypeScript Version:** nightly (2.1.0-dev.20160826) **Code** ``` ts type Result = { success: true } | { success: false, error: string } function handleError(res: Result) { if (res.success === true) { return; } res.error; // OK } function handleError2(res: Result) { if (res.success !== false) { return; } res.error; // OK } function handleError3(res: Result) { if (res.success) { return; } res.error; // Property 'error' does not exist on type 'Result' // but should be OK } ``` **Expected behavior:** All three cases should behave the same.
Bug,Help Wanted,Effort: Moderate
low
Critical
173,555,092
TypeScript
Inherited typing for class property initializers
# Problem Initializing a class member with things like `{ }`, `null`, `undefined`, or `[]` has unexpected behavior. ``` ts class Base { favorites = ["red", "blue"]; } class Derived extends Base { favorites = []; constructor() { this.favorites.push('green'); // Can't push string onto never[], wat? } } ``` ``` ts interface Settings { size?: number; color?: string; } class Base { settings: Settings = { size: 42 }; } class Derived extends Base { settings = { }; constructor() { if (big) this.settings = { siz: 100 }; // no error, wat? } } ``` # Solution New rule: When a class property is initialized with exactly `null`, `undefined`, `{ }`, or `[]`, the type of the property is taken from the same property of the _inherited type_ (if one exists), rather than the type of the initializer. The _inherited type_ is `B & I1 & I2 & ...` where `B` is the base class and `I1`, `I2`, `...` are the `implement`ed interfaces of the class. # Examples ``` ts interface Positionable { position: string | null; } class MyPos implements Positionable { position = null; setPos(x: string) { this.position = x; } getPos() { return this.position.subtr(3); // error detected } } ``` ``` ts class Base { items = ['one']; } class Derived extends Base { items = []; // no longer an implicit any } var x = new Derived(); x.items.push(10); // Error as expected ``` # Bad Ideas We Thought Were good ![image](https://cloud.githubusercontent.com/assets/6685088/18022117/1aad819e-6ba1-11e6-9a33-c2beab0051ef.png) Contextual typing plays poorly with other behavior such as unit type positions. Consider ``` ts enum E { A, B, C } class Base { thing = E.A; } class Derived extends Base { thing = E.B; change() { this.thing = E.C; // Error! wat } } ``` This turns into a big problem because the `E.B` expression is contextually typed by the unit-like type `E.A | E.B | E.C` and so acquires the _specific_ type `E.B` rather than the intended type `E`! Daniel found this break in Azure. /cc conspirators @DanielRosenwasser @sandersn
Suggestion,In Discussion
high
Critical
173,560,819
TypeScript
Allow skipping some generics when calling a function with multiple generics
Right now in TypeScript it's all or nothing when calling generic methods. You can either skip typing all the generics altogether and they will be inferred from the context (if possible), or you have to manually (re)define all of them. But the reality isn't black and white, there are also shades of gray, where we can infer types for some of the generic parameters, but not others. Currently those have to be unnecessarily verbose by forcing the programmer to explicitly restate them. Take a look at these 3 cases: Case 1 - everything can be inferred - no need to call the method with `<>` definition: ``` ts function case1<A, B, C>(a: A, b: B, c: C): A {} example(1, '2', true); ``` Compiler knows that: A is number B is string C is boolean --- Case 2 - nothing can be inferred, so we need to state what A, B and C should be, otherwise they'll default to `{}`: ``` ts function case2<A, B, C>(): A {} example<number, string, boolean>(); ``` --- Case 3 - the one that's interesting to this feature request - some can be inferred, some can't: ``` ts function case3<A, B, C>(b: string, c: boolean): A {} // incorrect type of A - left unspecified: example('thing'); // correct, but unnecessarily verbose - we already know that 'thing' is a string and true is a bool example<number, string, boolean>('thing', true); ``` Now, typing `string, boolean` in the above example isn't a big deal, but with complex scenarios, say with a method using 5 generics, where you can infer 4 of them, retyping them all seems overly verbose and prone to error. It would be great if we could have some way to skip re-typing the types that can automatically be inferred. Something like a special `auto` or `inferred` type, so we could write: ``` ts example<number, auto, auto>('thing', bool); ``` Or maybe even, if we only want to specify those up to a certain point: ``` ts example<number>('thing', bool); ``` The above "short-hand" notation could perhaps be different to account for function overloads with different number of generics. Having such a feature would solve newcomers encountering problems such as this one: http://stackoverflow.com/questions/38687965/typescript-generics-argument-type-inference/38688143
Suggestion,In Discussion
high
Critical
173,561,102
go
runtime: profile goroutine creation
Most unbounded Go memory leaks I've encountered have been due to goroutine leaks. When diagnosing these leaks, it would be helpful to know what function call stack led to the creation of the goroutines so we can link the goroutines back to the non-stdlib code that created themโ€”_why_ the goroutine exists, in addition to its start PC. This is the same vein in which the current heap profiles include the stack that allocated the memory rather than just the PC and type of the allocation. Related proposal for file descriptor profiling: #16379 --- A popular way to leak goroutines is by making http requests and not closing the response body. That problem could be targeted more specifically with a good static analysis tool, similar to vet's new -lostcancel check. Both approaches would be helpful.
NeedsDecision
low
Major
173,574,321
go
x/playground: GOSSAFUNC mode
Maybe with a button to switch it on. It would be useful for posting issues regarding compiler outputs in discussions. PS. This is not a bug or feature request regarding programs written in Go so I think it's fine to ignore answering the following questions. > Please answer these questions before submitting your issue. Thanks!
NeedsDecision
low
Critical
173,592,435
rust
Rustdoc generates docs for hidden methods in impls
I've seen #34025, but in the following case `rustdoc` still generates documentation for `hidden()` in the `impl Bar for Foo` (but as `tymethod` instead of `method`). It works correctly if `hidden()` is also marked as hidden in the trait _definition_. ``` rust pub struct Foo; pub trait Bar { fn test(); fn hidden(); } impl Bar for Foo { fn test() {} #[doc(hidden)] fn hidden() {} } ``` `rustc -V`: `rustc 1.13.0-nightly (e9bc1bac8 2016-08-24)`
T-rustdoc,A-trait-system,A-impl-trait,C-bug
low
Minor
173,608,089
opencv
GRIP: The Graphically Represented Image Processing engine
I would like to share one cool user facing implementation of OpenCV in a nicely bundled up application. I'm the developer behind [GRIP](https://github.com/WPIRoboticsProjects/GRIP) and would like to share with everyone. The goal of this project was to build an application that non-experts could use to construct computer vision algorithms, and more experienced users could use to develop algorithms faster. Given the time constraints imposed by robotics challenges like the FIRST Robotics Competition, computer vision is often underutilized by even the most experienced players. We used Java and OpenCV to implement a user interface to make rapidly developing vision systems easier. As a result, many teams successfully used our software in the 2016 FIRST Robotics Competition. We believe that our application could be used for further applications in research and education. We will be adding code generation within the next month for Java, Python and C++. Its currently being developed with a focus on FIRST Robotics but can be useful in a variety of fields. Is there a better place to post this? Is there somewhere that people may find this too useful? [GRIP-MQP.pdf](https://github.com/opencv/opencv/files/440782/GRIP-MQP.pdf)
RFC
low
Minor
173,625,218
rust
redundant E0210 (coherence) after E0120 (blanket Drop impl)
``` $ cargo script -e 'trait Trait {} impl<T: Trait> Drop for T { fn drop(&mut self) { } }' Compiling expr v0.1.0 (file:///Users/alex/.multirust/toolchains/beta/cargo/.cargo/script-cache/expr-223e68b0943558e6) error[E0120]: the Drop trait may only be implemented on structures --> /Users/alex/.multirust/toolchains/beta/cargo/.cargo/script-cache/expr-223e68b0943558e6/expr.rs:5:41 | 5 | {trait Trait {} impl<T: Trait> Drop for T { fn drop(&mut self) { } }} | ^ implementing Drop requires a struct error[E0210]: type parameter `T` must be used as the type parameter for some local type (e.g. `MyStruct<T>`); only traits defined in the current crate can be implemented for a type parameter --> /Users/alex/.multirust/toolchains/beta/cargo/.cargo/script-cache/expr-223e68b0943558e6/expr.rs:5:17 | 5 | {trait Trait {} impl<T: Trait> Drop for T { fn drop(&mut self) { } }} | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ error: aborting due to 2 previous errors error: Could not compile `expr`. ```
A-diagnostics,T-compiler,D-verbose
low
Critical
173,629,807
youtube-dl
Can't download videos from bbs (plays fine in browser)
## Please follow the guide below - You will be asked some questions and requested to provide some information, please read them **carefully** and answer honestly - Put an `x` into all the boxes [ ] relevant to your _issue_ (like that [x]) - Use _Preview_ tab to see how your issue will actually look like --- ### Make sure you are using the _latest_ version: run `youtube-dl --version` and ensure your version is _2016.08.28_. If it's not read [this FAQ entry](https://github.com/rg3/youtube-dl/blob/master/README.md#how-do-i-update-youtube-dl) and update. Issues with outdated version will be rejected. - [ x] I've **verified** and **I assure** that I'm running youtube-dl **2016.08.28** ### Before submitting an _issue_ make sure you have: - [x ] At least skimmed through [README](https://github.com/rg3/youtube-dl/blob/master/README.md) and **most notably** [FAQ](https://github.com/rg3/youtube-dl#faq) and [BUGS](https://github.com/rg3/youtube-dl#bugs) sections - [ ]x [Searched](https://github.com/rg3/youtube-dl/search?type=Issues) the bugtracker for similar issues including closed ones ### What is the purpose of your _issue_? - [ x] Bug report (encountered problems with youtube-dl) - [ ] Site support request (request for adding support for a new site) - [ ] Feature request (request for a new functionality) - [ ] Question - [ ] Other --- ### The following sections concretize particular purposed issues, you can erase any section (the contents between triple ---) not applicable to your _issue_ --- ### If the purpose of this _issue_ is a _bug report_, _site support request_ or you are not completely sure provide the full verbose output as follows: Add `-v` flag to **your command line** you run youtube-dl with, copy the **whole** output and insert it here. It should look similar to one below (replace it with **your** log inserted between triple ```): ``` keybounceMBP:FrozenPlanet michael$ youtube-dl -v http://www.bbc.co.uk/programmes/b00mfl7n/clips [debug] System config: [] [debug] User config: [u'-o', u'%(title)s.%(ext)s', u'-f', u'\nbest[ext=mp4][height>431][height<=480]/\nbest[ext=mp4][height>431][height<=576]/\nbestvideo[ext=mp4][height=480]+bestaudio[ext=m4a]/\nbest[ext=mp4][height>340][height<=431]/\nbestvideo[ext=mp4][height>360][height<=576]+bestaudio/\nbest[height>340][height<=576]/\nbestvideo[height>360][height<=576]+bestaudio/\nbestvideo[height=360]+bestaudio/\nbest[ext=mp4][height>=280][height<=360]/\nbest[height<=576]/\nworst', u'--write-sub', u'--write-auto-sub', u'--sub-lang', u'en,enUS', u'--sub-format', u'srt/ass/best', u'--embed-subs', u'--recode-video', u'mp4', u'--mark-watched'] [debug] Command-line args: [u'-v', u'http://www.bbc.co.uk/programmes/b00mfl7n/clips'] [debug] Encodings: locale UTF-8, fs utf-8, out UTF-8, pref UTF-8 [debug] youtube-dl version 2016.08.28 [debug] Python version 2.7.5 - Darwin-13.4.0-x86_64-i386-64bit [debug] exe versions: ffmpeg 3.1.1, ffprobe 3.1.1, rtmpdump 2.4 [debug] Proxy map: {} [bbc.co.uk:playlist] b00mfl7n: Downloading webpage [download] Downloading playlist: Frozen Planet - Clips - BBC One [bbc.co.uk:playlist] b00mfl7n: Downloading page 2 [bbc.co.uk:playlist] b00mfl7n: Downloading page 3 [bbc.co.uk:playlist] b00mfl7n: Downloading page 4 [bbc.co.uk:playlist] b00mfl7n: Downloading page 5 [bbc.co.uk:playlist] b00mfl7n: Downloading page 6 [bbc.co.uk:playlist] b00mfl7n: Downloading page 7 [bbc.co.uk:playlist] playlist Frozen Planet - Clips - BBC One: Downloading 142 videos [download] Downloading video 1 of 142 [bbc.co.uk] p03phqgj: Downloading video page [bbc.co.uk] p03phqgp: Downloading media selection XML [bbc.co.uk] p03phqgp: Downloading media selection XML [debug] Invoking downloader on u'rtmp://cp44293.edgefcs.net/ondemand?auth=daEcHd6b3aTbBbwduakabc1cYbGbhbXc4dZ-bxWNiM-bWG-EqtEFnBoMCpHnwC&aifp=v001&slist=public/secure_auth/800kbps/MP/2c978993539a3ae10153ae381a560975--video--nhufilm-frozenplanet-graphics-sea-ice-1024x576_flv_avc1_med.mp4;public/secure_auth/480kbps/MP/2c978993539a3ae10153ae381a560975--video--nhufilm-frozenplanet-graphics-sea-ice-1024x576_flv_avc1_low.mp4;public/secure_auth/1500kbps/MP/2c978993539a3ae10153ae381a560975--video--nhufilm-frozenplanet-graphics-sea-ice-1024x576_flv_avc1_high.mp4' [download] Destination: Arctic spring melt from Space, To the Ends of the Earth, Frozen Planet - BBC One.flv [debug] rtmpdump command line: rtmpdump --verbose -r 'rtmp://cp44293.edgefcs.net/ondemand?auth=daEcHd6b3aTbBbwduakabc1cYbGbhbXc4dZ-bxWNiM-bWG-EqtEFnBoMCpHnwC&aifp=v001&slist=public/secure_auth/800kbps/MP/2c978993539a3ae10153ae381a560975--video--nhufilm-frozenplanet-graphics-sea-ice-1024x576_flv_avc1_med.mp4;public/secure_auth/480kbps/MP/2c978993539a3ae10153ae381a560975--video--nhufilm-frozenplanet-graphics-sea-ice-1024x576_flv_avc1_low.mp4;public/secure_auth/1500kbps/MP/2c978993539a3ae10153ae381a560975--video--nhufilm-frozenplanet-graphics-sea-ice-1024x576_flv_avc1_high.mp4' -o 'Arctic spring melt from Space, To the Ends of the Earth, Frozen Planet - BBC One.flv.part' --swfVfy http://www.bbc.co.uk/emp/releases/iplayer/revisions/617463_618125_4/617463_618125_4_emp.swf --pageUrl http://www.bbc.co.uk --app 'ondemand?auth=daEcHd6b3aTbBbwduakabc1cYbGbhbXc4dZ-bxWNiM-bWG-EqtEFnBoMCpHnwC&aifp=v001&slist=public/secure_auth/800kbps/MP/2c978993539a3ae10153ae381a560975--video--nhufilm-frozenplanet-graphics-sea-ice-1024x576_flv_avc1_med.mp4;public/secure_auth/480kbps/MP/2c978993539a3ae10153ae381a560975--video--nhufilm-frozenplanet-graphics-sea-ice-1024x576_flv_avc1_low.mp4;public/secure_auth/1500kbps/MP/2c978993539a3ae10153ae381a560975--video--nhufilm-frozenplanet-graphics-sea-ice-1024x576_flv_avc1_high.mp4' --playpath mp4:public/secure_auth/1500kbps/MP/2c978993539a3ae10153ae381a560975--video--nhufilm-frozenplanet-graphics-sea-ice-1024x576_flv_avc1_high.mp4 --resume --skip 1 [rtmpdump] RTMPDump 2.4 [rtmpdump] (c) 2010 Andrej Stepanchuk, Howard Chu, The Flvstreamer Team; license: GPL [rtmpdump] DEBUG: Parsing... [rtmpdump] DEBUG: Parsed protocol: 0 [rtmpdump] DEBUG: Parsed host : cp44293.edgefcs.net [rtmpdump] DEBUG: Parsed app : ondemand?auth=daEcHd6b3aTbBbwduakabc1cYbGbhbXc4dZ-bxWNiM-bWG-EqtEFnBoMCpHnwC&aifp=v001&slist=public/secure_auth/800kbps/MP/2c978993539a3ae10153ae381a560975--video--nhufilm-frozenplanet-graphics-sea-ice-1024x576_flv_avc1_med.mp4;public/secure_auth/480kbps/MP/2c978993539a3ae10153ae381a560975--video--nhufilm-frozenplanet-graphics-sea-ice-1024x576_flv_avc1_low.mp4;public/secure_auth/1500kbps/MP/2c978993539a3ae10153ae381a560975--video--nhufilm-frozenplanet-graphics-sea-ice-1024x576_flv_avc1_high.mp4 [rtmpdump] DEBUG: Number of skipped key frames for resume: 1 [rtmpdump] DEBUG: Protocol : RTMP [rtmpdump] DEBUG: Hostname : cp44293.edgefcs.net [rtmpdump] DEBUG: Port : 1935 [rtmpdump] DEBUG: Playpath : mp4:public/secure_auth/1500kbps/MP/2c978993539a3ae10153ae381a560975--video--nhufilm-frozenplanet-graphics-sea-ice-1024x576_flv_avc1_high.mp4 [rtmpdump] DEBUG: tcUrl : rtmp://cp44293.edgefcs.net:1935/ondemand?auth=daEcHd6b3aTbBbwduakabc1cYbGbhbXc4dZ-bxWNiM-bWG-EqtEFnBoMCpHnwC&aifp=v001&slist=public/secure_auth/800kbps/MP/2c978993539a3ae10153ae381a560975--video--nhufilm-frozenplanet-graphics-sea-ice-1024x576_flv_avc1_med.mp4;public/secure_auth/480kbps/MP/2c978993539a3ae10153ae381a560975--video--nhufilm-frozenplanet-graphics-sea-ice-1024x576_flv_avc1_low.mp4;public/secure_auth/1500kbps/MP/2c978993539a3ae10153ae381a560975--video--nhufilm-frozenplanet-graphics-sea-ice-1024x [rtmpdump] DEBUG: swfUrl : http://www.bbc.co.uk/emp/releases/iplayer/revisions/617463_618125_4/617463_618125_4_emp.swf [rtmpdump] DEBUG: pageUrl : http://www.bbc.co.uk [rtmpdump] DEBUG: app : ondemand?auth=daEcHd6b3aTbBbwduakabc1cYbGbhbXc4dZ-bxWNiM-bWG-EqtEFnBoMCpHnwC&aifp=v001&slist=public/secure_auth/800kbps/MP/2c978993539a3ae10153ae381a560975--video--nhufilm-frozenplanet-graphics-sea-ice-1024x576_flv_avc1_med.mp4;public/secure_auth/480kbps/MP/2c978993539a3ae10153ae381a560975--video--nhufilm-frozenplanet-graphics-sea-ice-1024x576_flv_avc1_low.mp4;public/secure_auth/1500kbps/MP/2c978993539a3ae10153ae381a560975--video--nhufilm-frozenplanet-graphics-sea-ice-1024x576_flv_avc1_high.mp4 [rtmpdump] DEBUG: live : no [rtmpdump] DEBUG: timeout : 30 sec [rtmpdump] DEBUG: SWFSHA256: [rtmpdump] DEBUG: b6 74 7f 89 f9 ec 6a 60 c1 a4 b5 8b b1 18 b0 fa [rtmpdump] DEBUG: 65 18 86 24 c2 8a 1a a3 2f 72 0f 0b 80 59 dd 7f [rtmpdump] DEBUG: SWFSize : 595316 [rtmpdump] DEBUG: Failed to get last keyframe. [rtmpdump] DEBUG: Closing connection. [rtmpdump] 0 bytes [rtmpdump] RTMPDump 2.4 [rtmpdump] (c) 2010 Andrej Stepanchuk, Howard Chu, The Flvstreamer Team; license: GPL [rtmpdump] DEBUG: Parsing... [rtmpdump] DEBUG: Parsed protocol: 0 [rtmpdump] DEBUG: Parsed host : cp44293.edgefcs.net [rtmpdump] DEBUG: Parsed app : ondemand?auth=daEcHd6b3aTbBbwduakabc1cYbGbhbXc4dZ-bxWNiM-bWG-EqtEFnBoMCpHnwC&aifp=v001&slist=public/secure_auth/800kbps/MP/2c978993539a3ae10153ae381a560975--video--nhufilm-frozenplanet-graphics-sea-ice-1024x576_flv_avc1_med.mp4;public/secure_auth/480kbps/MP/2c978993539a3ae10153ae381a560975--video--nhufilm-frozenplanet-graphics-sea-ice-1024x576_flv_avc1_low.mp4;public/secure_auth/1500kbps/MP/2c978993539a3ae10153ae381a560975--video--nhufilm-frozenplanet-graphics-sea-ice-1024x576_flv_avc1_high.mp4 [rtmpdump] DEBUG: Number of skipped key frames for resume: 1 [rtmpdump] DEBUG: Number of skipped key frames for resume: 1 [rtmpdump] DEBUG: Protocol : RTMP [rtmpdump] DEBUG: Hostname : cp44293.edgefcs.net [rtmpdump] DEBUG: Port : 1935 [rtmpdump] DEBUG: Playpath : mp4:public/secure_auth/1500kbps/MP/2c978993539a3ae10153ae381a560975--video--nhufilm-frozenplanet-graphics-sea-ice-1024x576_flv_avc1_high.mp4 [rtmpdump] DEBUG: tcUrl : rtmp://cp44293.edgefcs.net:1935/ondemand?auth=daEcHd6b3aTbBbwduakabc1cYbGbhbXc4dZ-bxWNiM-bWG-EqtEFnBoMCpHnwC&aifp=v001&slist=public/secure_auth/800kbps/MP/2c978993539a3ae10153ae381a560975--video--nhufilm-frozenplanet-graphics-sea-ice-1024x576_flv_avc1_med.mp4;public/secure_auth/480kbps/MP/2c978993539a3ae10153ae381a560975--video--nhufilm-frozenplanet-graphics-sea-ice-1024x576_flv_avc1_low.mp4;public/secure_auth/1500kbps/MP/2c978993539a3ae10153ae381a560975--video--nhufilm-frozenplanet-graphics-sea-ice-1024x [rtmpdump] DEBUG: swfUrl : http://www.bbc.co.uk/emp/releases/iplayer/revisions/617463_618125_4/617463_618125_4_emp.swf [rtmpdump] DEBUG: pageUrl : http://www.bbc.co.uk [rtmpdump] DEBUG: app : ondemand?auth=daEcHd6b3aTbBbwduakabc1cYbGbhbXc4dZ-bxWNiM-bWG-EqtEFnBoMCpHnwC&aifp=v001&slist=public/secure_auth/800kbps/MP/2c978993539a3ae10153ae381a560975--video--nhufilm-frozenplanet-graphics-sea-ice-1024x576_flv_avc1_med.mp4;public/secure_auth/480kbps/MP/2c978993539a3ae10153ae381a560975--video--nhufilm-frozenplanet-graphics-sea-ice-1024x576_flv_avc1_low.mp4;public/secure_auth/1500kbps/MP/2c978993539a3ae10153ae381a560975--video--nhufilm-frozenplanet-graphics-sea-ice-1024x576_flv_avc1_high.mp4 [rtmpdump] DEBUG: live : no [rtmpdump] DEBUG: timeout : 30 sec [rtmpdump] DEBUG: SWFSHA256: [rtmpdump] DEBUG: b6 74 7f 89 f9 ec 6a 60 c1 a4 b5 8b b1 18 b0 fa [rtmpdump] DEBUG: 65 18 86 24 c2 8a 1a a3 2f 72 0f 0b 80 59 dd 7f [rtmpdump] DEBUG: SWFSize : 595316 [rtmpdump] DEBUG: Failed to get last keyframe. [rtmpdump] DEBUG: Closing connection. ERROR: rtmpdump exited with code 1 File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/runpy.py", line 162, in _run_module_as_main "__main__", fname, loader, pkg_name) File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/runpy.py", line 72, in _run_code exec code in run_globals File "/Users/michael/bin/youtube-dl/__main__.py", line 19, in <module> youtube_dl.main() File "/Users/michael/bin/youtube-dl/youtube_dl/__init__.py", line 433, in main _real_main(argv) File "/Users/michael/bin/youtube-dl/youtube_dl/__init__.py", line 423, in _real_main retcode = ydl.download(all_urls) File "/Users/michael/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 1788, in download url, force_generic_extractor=self.params.get('force_generic_extractor', False)) File "/Users/michael/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 702, in extract_info return self.process_ie_result(ie_result, download, extra_info) File "/Users/michael/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 863, in process_ie_result extra_info=extra) File "/Users/michael/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 755, in process_ie_result extra_info=extra_info) File "/Users/michael/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 702, in extract_info return self.process_ie_result(ie_result, download, extra_info) File "/Users/michael/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 748, in process_ie_result return self.process_video_result(ie_result, download=download) File "/Users/michael/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 1432, in process_video_result self.process_info(new_info) File "/Users/michael/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 1696, in process_info success = dl(filename, info_dict) File "/Users/michael/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 1638, in dl return fd.download(name, info) File "/Users/michael/bin/youtube-dl/youtube_dl/downloader/common.py", line 354, in download return self.real_download(filename, info_dict) File "/Users/michael/bin/youtube-dl/youtube_dl/downloader/rtmp.py", line 202, in real_download self.report_error('rtmpdump exited with code %d' % retval) File "/Users/michael/bin/youtube-dl/youtube_dl/downloader/common.py", line 162, in report_error self.ydl.report_error(*args, **kargs) File "/Users/michael/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 565, in report_error self.trouble(error_message, tb) File "/Users/michael/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 527, in trouble tb_data = traceback.format_list(traceback.extract_stack()) keybounceMBP:FrozenPlanet michael$ ``` Attempting to download the clips for Frozen Planet fails. I can watch most of the clips in the browser. A few, such as the 4th one (a highlight, not from an episode) does not -- and that one will give a geolocation error from youtube-dl. But the rest can be played without location restriction, but not downloaded.
cant-reproduce
low
Critical
173,631,794
go
x/image: packages to render TrueType fonts
github.com/golang/freetype already exists, but its license (the Freetype license) differs from the Go standard library, and code in the stdlib or under golang.org/x cannot depend on out-of-tree code. I propose to add two new packages in the golang.org/x/image repo that together lets you use TTFs to draw text. There are existing packages under golang.org/x/image/font that can draw bitmap fonts, but this would be the first golang.org/x package that draws vector fonts. The golang.org/x/image/vector package rasterizes 2-D vector graphics: filled and stroked polygons and Bรฉzier curves. 2-D vector graphics (and the scope of this package) encompasses more than just fonts, but this package will rasterize the glyphs of a vector font such as TrueType. It'd be comparable to the github.com/golang/freetype/raster package, but not based on the Freetype code. The golang.org/x/image/font/sfnt package parses sfnt font formats, including TrueType (.ttf) and OpenType (.otf). It will implement the existing golang.org/x/image/font font.Face interface for font format agnostic text drawing. It'd be comparable to the github.com/golang/freetype/truetype package, but not based on the Freetype code. A proof of concept (as a single "package main" instead of two separate packages) exists in a separate repository, https://github.com/google/font-go, which is in turn based on https://github.com/google/font-rs and the accompanying article (https://medium.com/@raphlinus/inside-the-fastest-font-renderer-in-the-world-75ae5270c445) by Raph Levien of Google. Roughly speaking, font.go would become package sfnt, and raster.go and acc*.{go,s} would become package vector.
Proposal,Proposal-Accepted
medium
Critical
173,643,775
node
Lexical variable declarations (`let`, `const`) unusable in repl if error thrown during declaration/first assignment
- **Version**: v.6.3.1 - **Platform**: Linux (Ubuntu 14.04) - **Subsystem**: `repl` (I think) <!-- Enter your issue details below this comment. --> ``` let s = Set(); ``` gives `TypeError: Constructor Set requires 'new'`. However, after this: ``` s ``` gives `ReferenceError: s is not defined` and ``` let s = new Set(); ``` gives `TypeError: Identifier 's' has already been declared`. I'm not sure whether this is a real bug or it's expected behaviour, but it sure does seem unusual that `s` becomes unusable from this point in in the repl. This isn't a problem when running `node` on a js file because the TypeError simply terminates execution.
repl,vm
medium
Critical
173,672,076
youtube-dl
[awaan] Add support for login
Hi. Could you add support for awaan.ae videos that require login with password and username?Thanks in advance!
account-needed
low
Major
173,680,116
rust
odd span with unused import generated by macro
I noticed this in a much more complex macro (it was recursive), but I minimized it: ``` rust macro_rules! m { ($($i:ident)*) => { use $($i)::*; } } m!(std cmp); ``` ``` warning: unused import, #[warn(unused_imports)] on by default --> /Users/alex/.multirust/toolchains/beta/cargo/.cargo/script-cache/expr-8aedeaeb93034069/expr.rs:5:64 | 5 | {macro_rules! m { ($($i:ident)*) => { use $($i)::*; } } m!(std cmp);} | ^^^ ``` I can't say the span is wrong... but it also doesn't seem right. cc @jonathandturner
A-lints,A-macros,C-bug
low
Minor
173,941,084
go
doc: document assembly calling convention
We should probably specify the Go calling convention in doc/asm.html, at least to a degree. Might be especially useful as a reference when we get around to changing it. @cherrymui @dr2chase @nigeltao
Documentation,help wanted,NeedsFix
medium
Critical
173,990,184
opencv
medianBlur slowness with grayscale images
<!-- If you have a question rather than reporting a bug please go to http://answers.opencv.org where you get much faster responses. If you need further assistance please read [How To Contribute](https://github.com/opencv/opencv/wiki/How_to_contribute). This is a template helping you to create an issue which can be processed as quickly as possible. This is the bug reporting section for the OpenCV library. --> ##### System information (version) - OpenCV => 3.1 - Operating System / Platform => Windows 64 Bit - Compiler => Visual Studio 2015 ##### Detailed description src image: 2000x2000 bmp color image median blur with ksize = 5 time elapsed ~70ms src image: 2000x2000 bmp grayscale image median blur with ksize = 5 time elapsed ~3700ms ##### Steps to reproduce ``` .cpp // C++ code example Mat src = imread(imageFileName); Mat out; medianBlur(src, out, 5); //70ms Mat src2 = imread(imageFileName, IMREAD_GRAYSCALE); medianBlur(src2, out, 5); //3700ms Mat src3 = imread(imageFileName, IMREAD_GRAYSCALE); cvtColor(src3, src3, CV_GRAY2BGR); medianBlur(src3, out, 5); //70ms cvtColor(out, out, CV_BGR2GRAY); //total process ~100ms ```
bug,category: core,affected: 3.4
low
Critical
174,006,136
youtube-dl
--embed-thumbnail crashes the program if the file has the wrong type
- [x] I've **verified** and **I assure** that I'm running youtube-dl **2016.08.28** ### Before submitting an _issue_ make sure you have: - [x] At least skimmed through [README](https://github.com/rg3/youtube-dl/blob/master/README.md) and **most notably** [FAQ](https://github.com/rg3/youtube-dl#faq) and [BUGS](https://github.com/rg3/youtube-dl#bugs) sections - [x] [Searched](https://github.com/rg3/youtube-dl/search?type=Issues) the bugtracker for similar issues including closed ones ### What is the purpose of your _issue_? - [x] Bug report (encountered problems with youtube-dl) --- ### The following sections concretize particular purposed issues, you can erase any section (the contents between triple ---) not applicable to your _issue_ --- ### If the purpose of this _issue_ is a _bug report_, _site support request_ or you are not completely sure provide the full verbose output as follows: ``` [info] Writing video description to: Nujabes - Modal Soul (Full Album)-WrO9PTpuSSs.description [info] Writing video annotations to: Nujabes - Modal Soul (Full Album)-WrO9PTpuSSs.annotations.xml [info] Writing video description metadata as JSON to: Nujabes - Modal Soul (Full Album)-WrO9PTpuSSs.info.json [youtube] WrO9PTpuSSs: Downloading thumbnail ... [youtube] WrO9PTpuSSs: Writing thumbnail to: Nujabes - Modal Soul (Full Album)-WrO9PTpuSSs.jpg [download] Destination: Nujabes - Modal Soul (Full Album)-WrO9PTpuSSs.f247.webm [download] 100% of 167.34MiB in 11:38 [download] Destination: Nujabes - Modal Soul (Full Album)-WrO9PTpuSSs.f251.webm [download] 100% of 60.15MiB in 04:41 [ffmpeg] Merging formats into "Nujabes - Modal Soul (Full Album)-WrO9PTpuSSs.webm" Deleting original file Nujabes - Modal Soul (Full Album)-WrO9PTpuSSs.f247.webm (pass -k to keep) Deleting original file Nujabes - Modal Soul (Full Album)-WrO9PTpuSSs.f251.webm (pass -k to keep) [ffmpeg] Adding metadata to 'Nujabes - Modal Soul (Full Album)-WrO9PTpuSSs.webm' [ffmpeg] There aren't any subtitles to embed ERROR: Only mp3 and m4a/mp4 are supported for thumbnail embedding for now. ``` ### Description of your _issue_, suggested solution and other information The program crashes with `--embed-thumbnails` enabled when the file is not `mp3/m4a/mp4`. I wanted to backup a long playlist over night, but it crashed after video 9. Invocation: ``` youtube-dl --yes-playlist --write-description --write-info-json --write-annotations --write-thumbnail --all-subs --add-metadata --embed-subs --embed-thumbnail <playlist> ``` I wrote a small, dirty patch that prevents the crash: ``` diff diff --git a/youtube_dl/postprocessor/embedthumbnail.py b/youtube_dl/postprocessor/embedthumbnail.py index 3bad5a2..cfc0e07 100644 --- a/youtube_dl/postprocessor/embedthumbnail.py +++ b/youtube_dl/postprocessor/embedthumbnail.py @@ -87,6 +87,8 @@ class EmbedThumbnailPP(FFmpegPostProcessor): os.remove(encodeFilename(filename)) os.rename(encodeFilename(temp_filename), encodeFilename(filename)) else: - raise EmbedThumbnailPPError('Only mp3 and m4a/mp4 are supported for thumbnail embedding for now.') + # should be correctly caught outside, but the calling system is confusing + # raise EmbedThumbnailPPError('Only mp3 and m4a/mp4 are supported for thumbnail embedding for now.') + self._downloader.report_warning('Only mp3 and m4a/mp4 are supported for thumbnail embedding for now.') return [], info ``` The nice way would be to catch the exception outside of the class and handle it correctly, but I couldnโ€™t find out where it is called. It should also be clarified how the semantics should be: does `--embed-thumbnail` guarantee that a thumbnail exists in the output? can it embed if there is a thumbnail (then the error should not exist)? does it try its best and skip if it doesnโ€™t work?
request,bug
low
Critical
174,096,367
go
cmd/compile: move most (*Type).IsFoo methods to (EType).IsFoo
In type.go, we have a bunch of helper methods like IsInteger, IsSigned, IsPtrShaped, etc. that currently can only be used on specific types (i.e., `*Type`), but many of these are really properties of type kinds (`EType`). This is annoying in parts of the compiler where we don't care about type identity anymore, but would still care about properties like signedness/etc. I think we should change Type's `Etype EType` field into an embedding of EType and change these method's receiver parameters from `*Type` to `EType`. Some need to stay on `*Type` though; notably IsEmptyInterface and IsUntyped, because they depend on properties of the specific type. It's a bit redundant for the single-kind methods like IsMap to be moved to EType, but for consistency we might as well move them too. Filing as an issue in case anyone objects or has alternative proposals.
NeedsFix,early-in-cycle
low
Minor
174,100,288
rust
"mod lib" in lib.rs produces incorrect error message
lib.rs: ``` mod a1; mod lib; ``` a1.rs - empty file. Error: ``` error: cannot declare a new module at this location --> src/lib.rs:1:5 | 1 | mod a1; | ^^ | note: maybe move this module `lib` to its own directory via `lib/mod.rs` --> src/lib.rs:1:5 | 1 | mod a1; | ^^ note: ... or maybe `use` the module `a1` instead of possibly redeclaring it --> src/lib.rs:1:5 | 1 | mod a1; | ^^ ``` Error location and some of the messages incorrectly refer to a1 module instead of lib. Module a1 itself is declared correctly. If I write lib before a1, the error starts making more sense: lib.rs: ``` mod lib; mod a1; ``` Error: ``` error: cannot declare a new module at this location --> src/lib.rs:1:5 | 1 | mod lib; | ^^^ | note: maybe move this module `lib` to its own directory via `lib/mod.rs` --> src/lib.rs:1:5 | 1 | mod lib; | ^^^ note: ... or maybe `use` the module `lib` instead of possibly redeclaring it --> src/lib.rs:1:5 | 1 | mod lib; | ^^^ ```
A-diagnostics,A-parser,T-compiler,C-bug
low
Critical
174,108,532
flutter
"flutter" tool poorly handles there being a file called "build" in the project directory
If a project directory contains a file named 'build', there will be a name collision with Flutter's build directory. To my understanding, there also exists a system-level configuration to specify the name of the build directory, but this would be impractical to configure on a team with a large number of people switching between projects based out of different version control systems. Is there or can there be a way to avoid this name collision on a project scale? (if you would like additional clarification, feel free to ping me)
tool,a: quality,P3,team-tool,triaged-tool
low
Major
174,111,968
opencv
Python binding for `findChessboardCorners` adds an extra dimension
##### System information (version) - OpenCV => 3.1.0 - Operating System / Platform => OS X 10.11.6 - Compiler => clang 7.3.0 - Python => 3.5.2 ##### Detailed description Calling `cv2.findChessboardCorners` returns a 3-dimensional array, including a redundant empty dimension. This behavior does not exist in the C++ API if a `std::vector<cv::Vec2f>` is passed as the output parameter, but is replicated if a `cv::Mat` is passed as an output parameter. ##### Steps to reproduce ``` .py import cv2 _, img = cv2.imread('my_7x9_chessboard.jpg', cv2.IMREAD_GRAYSCALE) chessboard_shape = 7, 9 pattern_found, image_corners = cv2.findChessboardCorners(img, chessboard_shape) print(image_corners.shape) # prints (63, 1, 2); should be (63, 2) ```
RFC
low
Minor
174,296,657
angular
UseCapture:true event handlers
**I'm submitting a ...** (check one with "x") ``` [ ] bug report => search github for a similar issue or PR before submitting [X ] feature request [ ] support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question ``` **Current behavior** All events (click, keys, etc) are registered with a `addEventListener(...,()=>{...},false)` in the browser_adapter. If we want to "cancel" them ahead, by capturing the event and calling stopPropagation(), we have to use a non-angular native JS. ``` element.nativeElement.addEventListener('click', (event: MouseEvent) => { if (someCondition) event.stopImmediatePropagation(); }, true); ``` **Desired behavior** A way to add a handler to an element that adds the event listener to the capture phase. I leave the syntax to you, but something like `@HostListener('~click',['$event'])` seems logical to me (and similarly `(~click)="..."`). **What is the motivation / use case for changing the behavior?** Creating directives that disables clicks/key events/etc. If the element has a custom handler on it, we need to cancel the event BEFORE it gets there. **Please tell us about your environment:** - **Angular version:** 2.0.0-rc.4
feature,freq1: low,area: core,core: event listeners,P3,feature: under consideration
high
Critical
174,317,615
vscode
Remove whitespace and indent to the right spot when the line has more whitespace than necessary
Extracted from https://github.com/Microsoft/vscode/issues/2938#issuecomment-235987405 --- From @chrmarti Works, except when there is already the full indentation (or more) on the line. It would make sense to make it work the same way in that case: ![indent](https://cloud.githubusercontent.com/assets/9205389/17225083/5eadbb98-54b8-11e6-8b28-21bba9fde257.gif)
feature-request,editor-autoindent
low
Minor
174,372,053
TypeScript
Recursively Resolving Modules
<!-- BUGS: Please use this template. --> <!-- QUESTIONS: This is not a general support forum! Ask Qs at http://stackoverflow.com/questions/tagged/typescript --> <!-- SUGGESTIONS: See https://github.com/Microsoft/TypeScript-wiki/blob/master/Writing-Good-Design-Proposals.md --> **TypeScript Version:** 2.1.0 I'm using ts-loader and Webpack to compile my .ts files. In My Webpack config I have the following configuration: ``` resolve: { modulesDirectories: ['shared', 'node_modules'] } ``` This allows me to import a component that lives in the shared directory without spelling out the full relative path. Example: `import Button from 'components/Button'` Webpack will walk up the directory tree and use the first `shared` directory it finds (the same way it does with the `node_modules` directories). This way, the component can live in the `../../shared/components/Buttton.tsx` and Webpack will find it and bundle it. My files compile fine because I am using ts-loader but I am getting `can not find module` errors in my editor. Is there a way to tell the TS compiler to recursively look for the component in the shared directories? I noticed the new `baseUrl` and `paths` configuration option but to my knowledge you can not use `paths` to recursively look for a directory.
Suggestion,Needs Proposal
medium
Critical
174,406,546
vscode
Editor selection colors should be simplified
- VSCode Version: Code - Insiders 1.5.0-insider (1de4d832ccb061c13cf70eaf0221fbaa86abfbdd, 2016-08-31T06:16:16.953Z) - OS Version: Linux x64 4.4.0-36-generic, Ubuntu 16.04 Follow up from #1636 I think we need to take a step back and take a good look at editor selection colors. Currently there are so many states, it's very confusing as to what find match, selection match is what and even what the actual selection is. Here are some of the states using my theme [Glacier](https://marketplace.visualstudio.com/items?itemName=Tyriar.theme-glacier): ![image](https://cloud.githubusercontent.com/assets/2193314/18149502/4d7a8d04-6f95-11e6-8726-a4df8ee95627.png) Selection ![image](https://cloud.githubusercontent.com/assets/2193314/18149492/32a2bbe6-6f95-11e6-985b-d2de3a32ed5a.png) Find match ![image](https://cloud.githubusercontent.com/assets/2193314/18149524/765a9340-6f95-11e6-94a6-9d916a2af65a.png) Symbol match ![image](https://cloud.githubusercontent.com/assets/2193314/18149531/8b5d273a-6f95-11e6-9096-b713c7f04233.png) Selection match (lighter than word match) ![image](https://cloud.githubusercontent.com/assets/2193314/18149574/ca1a92d2-6f95-11e6-90d9-31c18dbab87d.png) Selection + selection match ![image](https://cloud.githubusercontent.com/assets/2193314/18149882/e9ed2942-6f97-11e6-912c-0638a2225c4a.png) Selection + find match + symbol match ![image](https://cloud.githubusercontent.com/assets/2193314/18149620/0fc5e642-6f96-11e6-940a-3990cf650c9d.png) Symbol highlight ![image](https://cloud.githubusercontent.com/assets/2193314/18149599/e9b7ff26-6f95-11e6-8403-bfc48f88d79e.png) "Strong" symbol highlight for cursor word ![image](https://cloud.githubusercontent.com/assets/2193314/18149654/55266e00-6f96-11e6-89ab-d4be281a65a7.png) "Strong" symbol highlight for words away from cursor ![image](https://cloud.githubusercontent.com/assets/2193314/18149744/e5b605b6-6f96-11e6-9a1e-b9a27d5832f4.png) Selection + "Strong" symbol highlight for cursor word ![image](https://cloud.githubusercontent.com/assets/2193314/18149762/02f6e762-6f97-11e6-82d2-8746528ed790.png) Selection + "Strong" symbol highlight for cursor word (when selecting via <kbd>ctrl</kbd>+<kbd>d</kbd>) ![image](https://cloud.githubusercontent.com/assets/2193314/18149836/8b8ef84e-6f97-11e6-89d0-48dfb0fc87db.png) Selection + "Strong" symbol highlight for cursor word (when selecting via <kbd>ctrl</kbd>+<kbd>d</kbd>) + Find match This is in no way an exhaustive list of states but I think it gets the point across. Here are some of my initial thoughts: - The _actual_ selection should _always_ be the selection color defined in the theme - this is the primary reason I sometimes lost my selection. - Find matches should _not_ use the selection color defined by the theme. - Some of these states have colors that differ by so little they lose information and make the UI look sloppy. We should reduce the number of possible colors by reducing the amount they can stack with each other. - Is it useful differentiating symbol highlight and selection highlight? - Is strong symbol highlight useful? We already have a color to indicate symbols and they can't both show at once. - I'm quite perplexed by it, especially when things like this happen: ![image](https://cloud.githubusercontent.com/assets/2193314/18150034/ef49b940-6f98-11e6-8b92-760f40dd5c4d.png) Why are both `userEnv` variables highlighted with the strong symbol highlight below but not above? ![image](https://cloud.githubusercontent.com/assets/2193314/18150039/fd69d172-6f98-11e6-83f4-b495607ae9ca.png) - The blue looks bad in my theme, is there a way we can get a more suitable color using existing colors? - The line highlight color doesn't work when a range is selected. - Can we use a border to indicate find matches or something? That would make the distinction very clear. - Since 95% of themes are just imported from Sublime `.tmTheme` files and not adjusted to work better with vscode, we should make an effort to have the defaults work and only add additional tmTheme properties if they are absolutely necessary. - `findHighlight` is defined in many themes, why don't we adopt that since Sublime uses it? Personally I think something like below would be more usable despite being so simple (this is to illustrate my point, I'm not proposing this): - Selection is always the `selection` color from theme - All symbol and word highlights are `selection` color at 50% opacity - Find matches use white with 50% opacity
feature-request,editor-theming
medium
Major
174,409,926
go
x/net/websocket: fails to Receive a single frame sent in chunks from Browser
Please answer these questions before submitting your issue. Thanks! ### What version of Go are you using (`go version`)? 1.5 to 1.7 ### What operating system and processor architecture are you using (`go env`)? GOARCH="amd64" GOBIN="" GOEXE="" GOHOSTARCH="amd64" GOHOSTOS="linux" GOOS="linux" GOPATH="/home/matthew/code/go:/home/matthew/code/go" GORACE="" GOROOT="/usr/local/go" GOTOOLDIR="/usr/local/go/pkg/tool/linux_amd64" CC="gcc" GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build629490277=/tmp/go-build -gno-record-gcc-switches" CXX="g++" CGO_ENABLED="1" ### What did you do? This is a very difficult issue to reproduce, as the browsers themselves don't always exhibit the problem. Reproducing in our environment means sending a large >120k websocket message from the Browser (tested on Chrome) to the Go program from a "clean" browser - meaning either all caches, cookies cleared, or a new Incognito mode browser. When sent to the server, the browser will chunk the frame into multiple parts, setting the hybiFrameReader.header.Fin bit to false ### What did you expect to see? I expected the whole frame to arrive. ### What did you see instead? arbitrary cut off of string frame. My fix was to change the Receive function to check if the frame Fin was false, and if so, goto Again: ``` go // Receive receives single frame from ws, unmarshaled by cd.Unmarshal and stores in v. func (cd Codec) Receive(ws *Conn, v interface{}) (err error) { ws.rio.Lock() defer ws.rio.Unlock() if ws.frameReader != nil { _, err = io.Copy(ioutil.Discard, ws.frameReader) if err != nil { return err } ws.frameReader = nil } var b bytes.Buffer again: frame, err := ws.frameReaderFactory.NewFrameReader() if err != nil { return err } frame, err = ws.frameHandler.HandleFrame(frame) if err != nil { return err } if frame == nil { goto again } payloadType := frame.PayloadType() data, err := ioutil.ReadAll(frame) if err != nil { return err } _, err = b.Write(data) if err != nil { return err } if !frame.(*hybiFrameReader).header.Fin { goto again } return cd.Unmarshal(b.Bytes(), payloadType, v) } I have a feeling Read(...) also suffers from this problem. ```
NeedsInvestigation
low
Critical
174,418,188
rust
Confusing error message when traits from different modules have the same name
This error looks pretty bizarre, right? Especially the "help:" message, which is clearly not helpful at all. (This is from the current nightly.) ``` error[E0277]: the trait bound `B: Basics` is not satisfied --> src\collision_detection\simple_grid.rs:115:1 | 115 | pub fn insert_predictors <B: Basics, Settings: TimeStewardSettings <B>> (s ettings: Settings) { | ^ trait `B: Basics` not satisfied | = help: consider adding a `where B: Basics` bound = note: required by `TimeStewardSettings` ``` What happened is that I had two traits named Basics, one in the crate root and one in the current module. Presumably, the compiler could give a clearer error message in this situation, although I'm not sure what the best way to handle it is โ€“ it would obviously be bad to give the full path for every trait mentioned in an error message. Maybe it should give the full path exactly when there are two traits (or other objects) with the same name?
C-enhancement,A-diagnostics,T-compiler,D-confusing,D-invalid-suggestion,S-has-mcve
low
Critical
174,484,555
angular
Order of ngModel & onModelChange
**I'm submitting a ...** (check one with "x") ``` [x] bug report => search github for a similar issue or PR before submitting [ ] feature request [ ] support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question ``` **Current behavior** Currently the order of `(ngModelChange)` and `[(ngModel)]` on an input element matters. In the following case the `ngModelChange` callback is called before `ngModel` updates the value of model: ``` <select (ngModelChange)="onModelChange()" [(ngModel)]="hero.name" > <option>Dexter</option> <option>Voltron</option> </select> ``` The following however works fine: ``` <select [(ngModel)]="hero.name" (ngModelChange)="onModelChange()"> <option>Dexter</option> <option>Voltron</option> </select> ``` **Expected/desired behavior** Not sure what the expected behavior should be or if this the intended behavior. But I think the order of attributes in an element should not matter. **Reproduction of the problem** Link to plunker: http://plnkr.co/edit/wrVrHYx3pPdLmCKz17RL?p=preview Open up the console and select Hero name from the drop-down. Notice how the values are printed in console. Swap the order of `ngModel` and `onModelChange` and observe the difference. - **Angular version:** 2.0.0-rc.5 - **Browser:** Chrome Version 52.0.2743.116 m - **Language:** TypeScript
workaround1: obvious,freq1: low,area: core,core: inputs / outputs,type: confusing,P4
medium
Critical
174,573,735
flutter
Would like the option to have the Drawer behind the AppBar on tablets
The Drawer overlays the Appbar, that causes that the first item of the drawer is hidden under the statusbar. I think there should be at leat an option to place the Drawer under the appbar.
c: new feature,framework,f: material design,a: tablet,P2,team-design,triaged-design
low
Major
174,775,815
rust
Mark dropck-related borrow errors explicitly
Today you can use the key phrase โ€œnote: reference must be valid for the block suffixโ€... to get reminded that a borrow error is related to dropck. This could be improved to explicitly mention dropck rules or put the error message in that context in some way. cc @pnkfelix
A-diagnostics,A-destructors,A-borrow-checker,T-compiler
low
Critical
174,784,598
vscode
Debug console architecture
This item is intended as a discussion for the future of the debug console. Currently we use the tree to represent all elements in the debug console. This has worked well thus far but has certain limitations. The benefit of using the tree is that we can easily render complex elements - the ones that have children. The tree also allows us to lazily fetch the children of each element and is virtualised. ### Motivation for the change https://github.com/Microsoft/vscode/issues/1957 https://github.com/Microsoft/vscode/issues/4338 https://github.com/Microsoft/vscode/issues/4326 https://github.com/Microsoft/vscode/issues/2163 https://github.com/Microsoft/vscode/issues/6845 https://github.com/Microsoft/vscode/issues/228 https://github.com/Microsoft/vscode/issues/10680 https://github.com/Microsoft/vscode/issues/26641 ### Option 1: use the editor and simulate the tree using editor decorations **pro:** find, selection, word wrap, performance **con:** have to simulate the tree by using editor decorations / indentation, not enough flexibility (for possibly future requests of rendering custom things in the debug console). Note: editor could be enhanced to render custom images, but customly rendered output which the user can interact with is tricky. ### Option 2: use the editor but render a tree per complex object in a custom editor widget **pro:** most similar to what we currently have with some benefits on top (able to find/copy outside of complex objects) **con:** find and selection will not work inside the tree, thus making it hard to copy / find contents inside complex objects ### Option 3: render the debug console not using existing widgets **pro:** gives most flexibility **con:** no virtualisation, slow for a large number of elements, have to rewrite find widget, word wraping Chrome debug console is a good example of this. They can render multiple complex elements side by side and expand / collapse them. @weinand @alexandrudima please edit / modify as you see fit. I might have missed some of the pro/cons that we discussed, I just simply wrote what we have talked about this afternoon.
feature-request,debug
medium
Critical
174,799,511
go
x/crypto/scrypt,x/crypto/argon2: add high-level APIs
_Summary_: The x/crypto/scrypt package has a very simple API that puts the onus of figuring out salt generation and sensible N/r/p values on the package user. We should attempt to mirror the bcrypt packages' API and provide sensible defaults. _Details_: - Add a `GenerateFromPassword` function that generates output in the form `N$r$p$salt$dk` (noting that there is no 'standard' for scrypt here) - Add a `CompareHashAndPassword` function - Add a `Cost` function that can return the cost of a given output (i.e. for determining whether to upgrade or not) - Provide sensible default params that provide reasonable values of N, r, p and document why/when you may wish to change them. - Potentially provide a way to automatically determine values of N, r, p given memory (MB) and time (ms) constraints. Note that I've done most of this work in https://godoc.org/github.com/elithrar/simple-scrypt and would seek to bring most of this in.
Proposal-Accepted,NeedsFix,Proposal-Crypto
medium
Critical
174,815,540
rust
Performance left on the table?
I've been playing with Rust optimizations today and discovered something curious: it looks like LLVM `opt` does a better job at optimizing Rust IR than `rustc`: ``` sh set -v LINK=`rustc n_body.rs -O -o n_body-rustc -Zprint-link-args` rustc n_body.rs --emit=llvm-ir -o n_body.ll #-O opt n_body.ll -O3 -S -o n_body-opt.ll #opt n_body-opt.ll -O3 -S -o n_body-opt.ll llc n_body-opt.ll -relocation-model=pic -filetype=obj -o n_body-opt.o eval ${LINK/n_body-rustc.0.o/n_body-opt.o} -o n_body-opt time ./n_body-rustc 20000000 time ./n_body-opt 20000000 set +v ``` produces: ``` ... time ./n_body-rustc 20000000 -0.169075164 -0.169031665 real 0m3.876s user 0m3.868s sys 0m0.008s time ./n_body-opt 20000000 -0.169075164 -0.169031665 real 0m3.626s user 0m3.610s sys 0m0.016s ``` (n_body.rs having been copied verbatim from [benchmarksgame](http://benchmarksgame.alioth.debian.org/u64q/program.php?test=nbody&lang=rust&id=1)) Adding `-O` to the second `rustc` invocation and running IR through `opt` twice pushes the time down even further: ``` ... time ./n_body-opt 20000000 -0.169075164 -0.169031665 real 0m3.147s user 0m3.135s sys 0m0.012s ``` This happens on both stable 1.11.0 and the current nightly. (x86_64-unknown-linux-gnu) Does this mean that we could have `-C opt-level=4`?
A-LLVM,I-slow,C-enhancement,T-compiler,C-optimization
low
Major
174,821,410
go
cmd/compile: use common ancestor blocks in CSE?
``` go package x var p *int func f(b bool) int { if b && *p == 0 { return 0 } return *p } ``` The load `*p` occurs regardless of the value of b. That is, the compiler should treat this as equivalent to: ``` go package x var p *int func f(b bool) int { i := *p if b && i == 0 { return 0 } return i } ``` It does not. The latter generates better code. The reason is that neither block containing `*p` is an ancestor of the other, so CSE ignores the `*p` values. However, they share a common ancestor in which all of the values' arguments are available. This happened in practice in CL 22712. Perhaps CSE should be taught to recognize situations like this. Potential downsides: - This might move easily-recalculated values far from their uses, causing additional spills. (Aside: I think this is what went wrong with CL 28219. And yet making tighten more aggressive causes problems as well. We clearly need a more sophisticated approach in general to scheduling, so that we can pick up all these nickels without losing any dollar bills along the way.) - This might be computationally expensive, and CSE was long a problem child for performance. cc @randall77 @dr2chase @aclements @bradfitz @tzneal If we fix this, we should consider reverting CL 22712.
Performance,compiler/runtime
low
Major
174,837,849
TypeScript
compilerOptions.paths to support relative and absolute paths
<!-- BUGS: Please use this template. --> **TypeScript Version:** 2.0.2 **Code** ``` ts { "compilerOptions": { "paths": { "./moment": ["node_modules/moment/moment.d.ts"], "/foo/bar/baz": [ "some/other/path/for/compiler"] } }, ``` **Expected behavior:** I expect (need) to be able to redirect the compiler for any module, not just 'non relative' paths. I'm deploying to a runtime environment that requires me to use relative or absolute paths, but I need the compiler to look to different locations when building locally. **Actual behavior:** The compiler seems to ignore any `compilerOption.paths` setting which starts with `/` or `./`
Suggestion,Awaiting More Feedback
low
Critical
174,857,445
flutter
Widget test with await is hanged when not using `runAsync` instead of showing error/warning message
``` import "dart:async"; import "package:flutter_test/flutter_test.dart"; void main() { Future future; setUp(() { future = new Future.value(); }); testWidgets("awaiting future with value from setUp works", (WidgetTester tester) async { await future; }); } ``` ``` flutter_test_async$ flutter test test/async_widget_test.dart 00:05 +0 -1: - awaiting future with value from setUp works TimeoutException after 0:00:05.000000: Test timed out after 5 seconds. dart:async _StreamController.add websocket_impl.dart 1111 _WebSocketImpl._WebSocketImpl._fromSocket.<fn> dart:async _EventSinkWrapper.add websocket_impl.dart 333 _WebSocketProtocolTransformer._messageFrameEnd websocket_impl.dart 228 _WebSocketProtocolTransformer.add 00:05 +0 -1: Some tests failed. ``` ``` [โœ“] Flutter (on Mac OS, channel unknown) โ€ข Flutter at /Users/drewwarren/flutter โ€ข Framework revision 852a00a17b (8 days ago), 2016-08-25 14:23:13 โ€ข Engine revision c4022b61fa โ€ข Tools Dart version 1.19.0-dev.5.0 [x] Android toolchain - develop for Android devices x Android Studio / Android SDK not found. Download from https://developer.android.com/sdk/ (or visit https://flutter.io/setup/#android-setup for detailed instructions). [โœ“] iOS toolchain - develop for iOS devices (Xcode 7.3.1) โ€ข XCode at /Applications/Xcode.app/Contents/Developer โ€ข Xcode 7.3.1, Build version 7D1014 [โœ“] Atom - a lightweight development environment for Flutter โ€ข flutter plugin version 0.2.4 โ€ข dartlang plugin version 0.6.37 ```
a: tests,framework,a: quality,a: error message,has reproducible steps,P3,team-framework,triaged-framework,found in release: 3.16,found in release: 3.19
medium
Critical
174,861,083
godot
Auto-completion not working when using NodePath from exported variable.
When using: ``` export(NodePath) var node func some_func(): get_node(node).node_method() ``` Auto-completion in Script Editor is not working while when using get_node("node_path_to_node") it is.
enhancement,topic:gdscript,topic:editor,usability
low
Major
174,899,060
rust
Code only compiles with try!, not with question mark syntax
The following code only compiles with `try!`, not when using the `?`-syntax instead: ``` rust #![feature(question_mark)] fn foo() -> Result<Vec<u32>, std::num::ParseIntError> { let s = &["42", "1337"]; let parsed: Vec<u32> = try!(s.iter().map(|str| { let val = str.parse::<u32>()?; Ok(val + 1) }).collect()); Ok(parsed) } fn main() { println!("{:?}", foo()); } ``` Replacing the single `try!` in function `foo` with its `?` equivalent produces the following error: ``` error[E0284]: type annotations required: cannot resolve `<_ as std::ops::Carrier>::Success == _` --> <anon>:6:28 | 6 | let parsed: Vec<u32> = s.iter().map(|str| { | ^ error: aborting due to previous error ``` Example on playground: https://is.gd/CPUV0f (replace `try!` with `?` to see the error) Rustc version: rustc 1.13.0-nightly (acd3f796d 2016-08-28) Note: @KiChjang mentioned on IRC that using turbofish on the collect call, `.collect::<Result<_,_>>()` , makes the `?` version compile again.
C-enhancement,T-compiler,A-inference
low
Critical
174,927,135
rust
[rustbuild] cross-compiling to windows-gnu fails
``` $ python2 src/bootstrap/bootstrap.py --stage 1 --step libstd -j8 --target=i686-pc-windows-gnu Finished debug [unoptimized + debuginfo] target(s) in 0.0 secs Building stage0 std artifacts (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu) Finished release [optimized] target(s) in 0.0 secs Building stage0 test artifacts (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu) Finished release [optimized] target(s) in 0.0 secs Building stage0 compiler artifacts (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu) Finished release [optimized] target(s) in 0.0 secs Building stage1 std artifacts (x86_64-unknown-linux-gnu -> i686-pc-windows-gnu) thread 'main' panicked at 'failed to copy `crt2.o` to `/home/nagisa/Documents/rust/rust/worktrees/more-cace/build/x86_64-unknown-linux-gnu/stage1/lib/rustlib/i686-pc-windows-gnu/lib/crt2.o`: the source path is not an existing regular file', src/bootstrap/util.rs:46 ```
T-bootstrap,C-bug,S-needs-info
low
Critical
174,941,344
flutter
Material "Durations" class?
Not a bug, just a suggestion! Happy to help implement it as well, if it's something you would be interested in :) I really enjoy the `Icons`, `Colors`, etc classes available in the `material` package. They helped me bust out a quick, decent looking prototype in no time at all! I also started using the `AnimatedOpacity` class to perform a couple of transitions, which required a `Duration` parameter, and wondered: "Oh yes, what exactly are the correct Material durations?" Luckily, the material specs are well documented here: https://material.google.com/motion/duration-easing.html with the specs. I created a small helper class in my app, but wondered if they could be codified as a class in the `Material` package? Some constants already exist in the Material package (https://docs.flutter.io/flutter/material/material-library.html), but the material guidelines require extending the animation duration by 30% for Tablets, for example. Would it make sense to have another class, such as `Durations`, with methods that take something like a `Size` (preferably something better), and return the correct duration? This could look something like: ``` dart class Durations { static final kStandardMobileDurationInMs = 300; static final kEnterScreenMobileDurationInMs = 225; static final kExitScreenMobileDurationInMs = 195; // Size is really not great, but is just an example! I would imagine another class that would help distinguish between tablets / wearables, and that value could get passed into here instead static Duration standardDuration({ Size screenSize }) { return new Duration( milliseconds: (kStandardMobileDurationInMs * screenSizeModifier(screenSize)).round() ); } static double screenSizeModifier(Size screenSize) { if (screenSize == null) { return 1.0; } else if (isLargeScreen(screenSize)) { return 1.3; } else if (isSmallScreen(screenSize)) { return 0.7; } return 1.0; } static bool isSmallScreen(Size screenSize) { return screenSize.width < 320 || screenSize.height < 320; } static bool isLargeScreen(Size screenSize) { return screenSize.width > 500 || screenSize.height > 500; } // Pseudo-code / not implemented, but extra durations from the spec as an example static Duration complexFullScreenDuration(); static Duration enterScreenDuration(); static Duration exitScreenDuration(); } ``` Let me know whatcha think! p.s. The fact that `Size` exists as a first class citizen in `dart:ui` is really cool. The more I play with this language and the libs, the more I'm impressed by the little things :)
c: new feature,framework,f: material design,P3,team-design,triaged-design
low
Critical
174,949,096
rust
Specialization influnces inference
## STR ``` Rust #![feature(specialization)] struct My<T>(T); trait Conv<T> { fn conv(self) -> T; } impl<T> Conv<T> for My<T> { default fn conv(self) -> T { self.0 } } #[cfg(broken)] impl Conv<u32> for My<u32> { default fn conv(self) -> u32 { self.0 } } fn main() { let x = My(0); x.conv() + 0i32; } ``` ## Expected Result Adding a specialized impl will not affect type inference. ## Actual Result After adding the specialized impl, inference is guided to take it: ``` error[E0308]: mismatched types --> <anon>:20:16 | 20 | x.conv() + 0i32; | ^^^^ expected u32, found i32 error[E0277]: the trait bound `u32: std::ops::Add<i32>` is not satisfied --> <anon>:20:5 | 20 | x.conv() + 0i32; | ^^^^^^^^^^^^^^^ trait `u32: std::ops::Add<i32>` not satisfied | = help: the following implementations were found: = help: <u32 as std::ops::Add> = help: <&'a u32 as std::ops::Add<u32>> = help: <u32 as std::ops::Add<&'a u32>> = help: <&'b u32 as std::ops::Add<&'a u32>> error: aborting due to 2 previous errors ``` cc @aturon @nikomatsakis
A-trait-system,T-compiler,A-specialization,A-inference,C-bug,requires-nightly,F-specialization
low
Critical
174,958,004
opencv
bring back cv::convertScale
It was replaced with `Mat::convertTo` which is not accessible from the python bindings.
feature,category: python bindings,affected: 3.4
low
Major
174,966,874
youtube-dl
Site request: (doc.)rt.com
Please add rt.com (and/or doc.rt.com and other subdomains) to youtube-DL. Sample link is here: https://doc.rt.com/filmy/chernij-oktyabr-93-go/ The log of (not)downloading: C:>youtube-dl.exe -F -v https://doc.rt.com/filmy/chernij-oktyabr-93-go/ [debug] System config: [] [debug] User config: [] [debug] Command-line args: ['-F', '-v', 'https://doc.rt.com/filmy/chernij-oktyabr-93-go/'] [debug] Encodings: locale cp1251, fs mbcs, out cp866, pref cp1251 [debug] youtube-dl version 2016.09.04.1 [debug] Python version 3.4.4 - Windows-7-6.1.7601-SP1 [debug] exe versions: ffmpeg N-81391-g2a3720b, ffprobe N-81391-g2a3720b, rtmpdump 2.4 [debug] Proxy map: {} [generic] chernij-oktyabr-93-go: Requesting header WARNING: Falling back on generic information extractor. [generic] chernij-oktyabr-93-go: Downloading webpage [generic] chernij-oktyabr-93-go: Extracting information [info] Available formats for playlist: format code extension resolution note ## 0 xml unknown Please notice, rt.com offers several resolutions to viewer, here is the pic: http://i.imgur.com/CKnrGzJ.png Thanks in advance!
site-support-request
low
Critical
174,983,277
You-Dont-Know-JS
Types & Grammar Ch 3 - RegExp.prototype is an object as of ES6
The code below throws an error because RegExp.prototype is an ordinary object as of ES6. I think it would make sense to either change the example or note that this code won't work anymore if no regex is passed in for rx. ``` function isThisCool(vals,fn,rx) { console.log(vals, fn, rx) vals = vals || Array.prototype; fn = fn || Function.prototype; rx = rx || RegExp.prototype; return rx.test( vals.map( fn ).join( "" ) ); } isThisCool(); // true ``` I did find a workaround via `RegExp.toPrototype.toString()`, but I'm assuming that it would make more sense to just type `rx || /(?:)/`in line 4 to get the result you want. Here's my code in case it helps: ``` function isThisCool(vals,fn,rx) { vals = vals || Array.prototype; fn = fn || Function.prototype; rx = rx || RegExp.prototype.toString(); rx = new RegExp(rx.slice(1,-1)); return rx.test( vals.map( fn ).join( "" ) ); } isThisCool(); // true ```
for second edition
medium
Critical
175,003,882
rust
Windows Defender goes nuts when running rustdoc on some projects
`rustdoc` gets pretty much completely stalled on some projects by Windows Defender on Windows 10. `rustdoc` cpu usage drops to 0%, while `MsMpEng.exe` uses 100% on a single core. This issue seems to have popped up only a few weeks ago.
O-windows,T-rustdoc,C-enhancement
low
Major
175,062,592
three.js
IES Light Support
##### Description of the problem IES lights are a standard for specifying the illumination intensity in a specific direction from a light. It allows one to use IES profiles to specify real-world light bulbs in a scene and get perfect results. It is used all the time for architectural rendering. We should try to get this into THreeJS at some point. I understand the way that you do this is to create a spherical map of intensities for each light type (e.g. IES profile) and then sample from it. http://www.cgarena.com/freestuff/tutorials/max/ieslights/ I believe this requires then one cubemap per IES profile light. It isn't that slow so it is suitable for real-time on all devices. ##### Three.js version - [x] Dev - [x] r80 - [ ] ... ##### Browser - [x] All of them - [ ] Chrome - [ ] Firefox - [ ] Internet Explorer ##### OS - [x] All of them - [ ] Windows - [ ] Linux - [ ] Android - [ ] IOS ##### Hardware Requirements (graphics card, VR Device, ...)
Enhancement,Bounty
medium
Major
175,083,503
youtube-dl
[facebook] Add support for user videos
Hello, is it possible to recover all the videos from a facebook page? It is already possible to do this on Youtube and Dailymotion. Youtube-dl already suppporte downloading and retrieval of information on a single video. The videos on facebook link are: - https://www.facebook.com/USERNAME/videos/ - https://m.facebook.com/MisterVOnline/videos/ - https://touch.facebook.com/MisterVOnline/videos/ thank you in advance
request
low
Minor
175,159,846
opencv
stereoRectify returns too narrow FoV
<!-- If you have a question rather than reporting a bug please go to http://answers.opencv.org where you get much faster responses. If you need further assistance please read [How To Contribute](https://github.com/opencv/opencv/wiki/How_to_contribute). This is a template helping you to create an issue which can be processed as quickly as possible. This is the bug reporting section for the OpenCV library. --> ##### System information (version) - OpenCV => 2.4.8 or 3.1 - Operating System / Platform => Ubuntu14.04 - Compiler => gcc 4.8.4 ##### Detailed description Using cv::stereoRectify, we can compute rectification transforms. Setting argument alpha = 0 (or -1), We obtain projection matrix which create rectified image so that only valid pixels are visible. However, there are too much loss of angle of view. ##### Steps to reproduce ``` .cpp #include "opencv2/opencv.hpp" using namespace cv; int main(int argc, char** argv) { // read images Mat img1 = imread("left000000.png, 1"); Mat img2 = imread("right000000.png, 1"); // get parameters. Mat cameraMatrix1 = (Mat_<double>(3,3) << 297.4089814269344, 0, 320.5522625552759, 0, 297.4237628565247, 216.5714813003074, 0, 0, 1); Mat distCoeffs1 = (Mat_<double>(8,1) << 0.2748830280780161, -0.01621485704756092, -0.0001422338901898611, -5.464830883313612e-05, 0.0007905921035454578, 0.6293739571366611, 0, 0); Mat cameraMatrix2 = (Mat_<double>(3,3) << 299.9196394373507, 0, 317.3610118656668, 0, 299.8188459158802, 218.7071016329061, 0, 0, 1); Mat distCoeffs2 = (Mat_<double>(8,1) << 0.2764273821263449, -0.01606351441652921, -0.0001328981789739428, 3.984181363726657e-05, 0.0007352344185123152, 0.6319438272394248, 0, 0); Mat R = (Mat_<double>(3,3) << 0.999986734411586, -0.001027538742322914, -0.005047292837277665, 0.001012708281235076, 0.9999951654653096, -0.002939977541586314, 0.005050289376790885, 0.002934827105800179, 0.9999829405380223); Mat T = (Mat_<double>(3,1) << -0.08175826598351721, -0.001466183753848256, 0.001439342993774405); Size imageSize = Size(640, 480); Mat R1, R2, P1, P2, Q; Rect validRoi1, validRoi2; // rectify double alpha = 0; stereoRectify(cameraMatrix1, distCoeffs1, cameraMatrix2, distCoeffs2, imageSize, R, T, R1, R2, P1, P2, Q, CALIB_ZERO_DISPARITY, alpha, imageSize, &validRoi1, &validRoi2); // remap Mat rmap[2][2]; initUndistortRectifyMap(cameraMatrix1, distCoeffs1, R1, P1, imageSize, CV_16SC2, rmap[0][0], rmap[0][1]); initUndistortRectifyMap(cameraMatrix2, distCoeffs2, R2, P2, imageSize, CV_16SC2, rmap[1][0], rmap[1][1]); Mat out1, out2; remap(img1, out1, rmap[0][0], rmap[0][1], CV_INTER_LINEAR); remap(img2, out2, rmap[1][0], rmap[1][1], CV_INTER_LINEAR); Mat result; hconcat(out1, out2, result); // draw horizontal line for(int j = 0; j < result.rows; j += 16 ) { line(result, Point(0, j), Point(result.cols, j), Scalar(0, 255, 0), 1, 8); } // show imshow("result", result); waitKey(); return 0; } ``` input image1 ![left000000](https://cloud.githubusercontent.com/assets/21995016/18240473/0585f6d2-7387-11e6-8850-6c46bdc7bbe5.png) input image2 ![right000000](https://cloud.githubusercontent.com/assets/21995016/18240478/0d95f76e-7387-11e6-99fd-0e26cad2b3de.png) result image ![alpha0_000000](https://cloud.githubusercontent.com/assets/21995016/18240485/18ff1a54-7387-11e6-9bcc-fd6980aa94f9.png) ##### Workaround If you replace rectify part with following code, you can decrease loss of angle of view with stereo rectification. Setting argument alpha = 1, we get projection matrix and rectangles inside the rectified images where all the pixels are valid. We recompute projection matrix so that rectified image have only valid pixels. ``` .cpp // rectify double alpha = 1; stereoRectify(cameraMatrix1, distCoeffs1, cameraMatrix2, distCoeffs2, imageSize, R, T, R1, R2, P1, P2, Q, CALIB_ZERO_DISPARITY, alpha, imageSize, &validRoi1, &validRoi2); Rect commonRoi = validRoi1 & validRoi2; // to retain aspect ratio Rect_<double> aspectRoi; if(commonRoi.width > commonRoi.height*4.0/3.0){ aspectRoi.x = commonRoi.x + (commonRoi.width-commonRoi.height*4.0/3.0)/2.0; aspectRoi.y = commonRoi.y; aspectRoi.width = commonRoi.height*4.0/3.0; aspectRoi.height = commonRoi.height; } else{ aspectRoi.x = commonRoi.x; aspectRoi.y = commonRoi.y + (commonRoi.height-commonRoi.width*3.0/4.0)/2.0; aspectRoi.width = commonRoi.width; aspectRoi.height = commonRoi.width*3.0/4.0; } // create cropping matrix double u = double(imageSize.width)/double(aspectRoi.width); double v = double(imageSize.height)/double(aspectRoi.height); Mat M = (Mat_<double>(3,3) << u, 0, -double(aspectRoi.x)*u, 0, v, -double(aspectRoi.y)*v, 0, 0, 1); P1 = M * P1; P2 = M * P2; ``` modified result image ![result000000](https://cloud.githubusercontent.com/assets/21995016/18240491/22da33e2-7387-11e6-84d2-2eee58c477c0.png)
bug,category: calib3d,affected: 2.4,affected: 3.4
low
Critical
175,224,532
go
cmd/gofmt: Anonymous field could be placed in the 2nd column of a struct
### What version of Go are you using (`go version`)? `go version go1.7 windows/amd64` ### What operating system and processor architecture are you using (`go env`)? ``` set GOARCH=amd64 set GOBIN= set GOEXE=.exe set GOHOSTARCH=amd64 set GOHOSTOS=windows set GOOS=windows set GOPATH=C:\PROJECTS\Go set GORACE= set GOROOT=C:\Go set GOTOOLDIR=C:\Go\pkg\tool\windows_amd64 set CC=gcc set GOGCCFLAGS=-m64 -mthreads -fmessage-length=0 set CXX=g++ set CGO_ENABLED=1 ``` ### What did you do? ![gofmt1](https://cloud.githubusercontent.com/assets/142650/18272045/79bf1ae6-742d-11e6-9ad4-ff7441d43445.png) ### What did you expect to see? ![gofmt2](https://cloud.githubusercontent.com/assets/142650/18272088/c36cd5d4-742d-11e6-9a4e-5ba93a088c6b.png) ### What did you see instead? ![gofmt1](https://cloud.githubusercontent.com/assets/142650/18272045/79bf1ae6-742d-11e6-9ad4-ff7441d43445.png)
NeedsInvestigation
low
Major
175,311,249
TypeScript
Add spread/rest higher-order types operator
The spread type is a new type operator that types the [TC39 stage 3 object spread operator](https://github.com/sebmarkbage/ecmascript-rest-spread). Its counterpart, the difference type, will type the proposed object rest destructuring operator. The spread type `{ ...A, ...B }` combines the properties, but not the call or construct signatures, of entities A and B. The pull request is at #11150. The original issue for spread/rest types is #2103. Note that this proposal deviates from the specification by keeping all properties except methods, not just own enumerable ones. ## Proposal syntax The type syntax in this proposal differs from the type syntax as implemented in order to treat spread as a binary operator. Three rules are needed to convert the `{ ...spread1, ...spread2 }` syntax to binary syntax `spread1 ... spread2`. 1. `{ ...spread }` becomes `{} ... spread`. 2. `{ a, b, c, ...d}` becomes `{a, b, c} ... d` 3. Multiple spreads inside an object literal are treated as sequences of binary spreads: `{ a, b, c, ...d, ...e, f, g}` becomes `{a, b, c} ... d ... e ... { f, g }`. ## Type Relationships - Identity: `A ... A ... A` is equivalent to `A ... A` and `A ... A` is equivalent to `{} ... A`. - Commutativity: `A ... B` is _not_ equivalent to `B ... A`. Properties of `B` overwrite properties of `A` with the same name in `A ... B`. - Associativity: `(A ... B) ... C` is equivalent to `A ... (B ... C)`. `...` is right-associative. - Distributivity: Spread is distributive over `|`, so `A ... (B | C)` is equivalent to `A ... B | A ... C`. ## Assignment compatibility - `A ... B` is assignable to `X` if the properties and index signatures of `A ... B` are assignable to those of `X`, and `X` has no call or construct signatures. - `X` is assignable to `A ... B` if the properties and index signatures of `X` are assignable to those of `A ... B`. ### Type parameters A spread type containing type parameters is assignable to another spread type if the type if the source and target types are both of the form `T ... { some, object, type }` and both source and target have the same type parameter and the source object type is assignable to the target object type. ### Type inference Spread types are not type inference targets. ## Properties and index signatures In the following definitions, 'property' means either a property or a get accessor. The type `A ... B` has a property `P` if 1. `A` has a property `P` or `B` has a property `P`, and 2. Either `A.P` or `B.P` is not a method. In this case `(A ... B).P` has the type 1. Of `B.P` if `B.P` is not optional. 2. Of `A.P | B.P` if `B.P` is optional and `A` has a property `P`. 3. Of `A.P` otherwise. `private`, `protected` and `readonly` behave the same way as optionality except that if `A.P` or `B.P` is `private`, `protected` or `readonly`, then `(A ...B).P` is `private`, `protected` or `readonly`, respectively. ## Index signatures The type `A ... B` has an index signature if `A` has an index signature and `B` has an index signature. The index signature's type is the union of the two index signatures' types. ## Call and Construct signatures `A ... B` has no call signatures and no construct signatures, since these are not properties. ## Precedence Precedence of `...` is higher than `&` and `|`. Since the language syntax is that of object type literals, precedence doesn't matter since the braces act as boundaries of the spread type. ## Examples Taken from the [TC39 proposal](https://github.com/sebmarkbage/ecmascript-rest-spread/blob/master/Spread.md) and given types. ### Shallow Clone (excluding prototype) ``` ts let aClone: { ...A } = { ...a }; ``` ### Merging Two Objects ``` ts let ab: { ...A, ...B } = { ...a, ...b }; ``` ### Overriding Properties ``` ts let aWithOverrides: { ...A, x: number, y: number } = { ...a, x: 1, y: 2 }; // equivalent to let aWithOverrides: { ...A, ...{ x: number, y: number } } = { ...a, ...{ x: 1, y: 2 } }; ``` ### Default Properties ``` ts let aWithDefaults: { x: number, y: number, ...A } = { x: 1, y: 2, ...a }; ``` ### Multiple Merges ``` ts // Note: getters on a are executed twice let xyWithAandB: { x: number, ...A, y: number, ...B, ...A } = { x: 1, ...a, y: 2, ...b, ...a }; // equivalent to let xyWithAandB: { x: number, y: number, ...B, ...A } = { x: 1, ...a, y: 2, ...b, ...a }; ``` ### Getters on the Object Initializer ``` ts // Does not throw because .x isn't evaluated yet. It's defined. let aWithXGetter: { ...A, x: never } = { ...a, get x() { throw new Error('not thrown yet') } }; ``` ### Getters in the Spread Object ``` ts // Throws because the .x property of the inner object is evaluated when the // property value is copied over to the surrounding object initializer. let runtimeError: { ...A, x: never } = { ...a, ...{ get x() { throw new Error('thrown now') } } }; ``` ### Setters Are Not Executed When They're Redefined ``` ts let z: { x: number } = { set x() { throw new Error(); }, ...{ x: 1 } }; // No error ``` ### Null/Undefined Are Ignored ``` ts let emptyObject: {} = { ...null, ...undefined }; // no runtime error ``` ### Updating Deep Immutable Object ``` ts let newVersion: { ...A, name: string, address: { address, zipCode: string }, items: { title: string }[] } = { ...previousVersion, name: 'New Name', // Override the name property address: { ...previousVersion.address, zipCode: '99999' } // Update nested zip code items: [...previousVersion.items, { title: 'New Item' }] // Add an item to the list of items }; ``` Note: If `A = { name: string, address: { address, zipCode: string }, items: { title: string }[] }`, then the type of newVersion is equivalent to `A` # Rest types The difference type is the opposite of the spread type. It types the TC39 stage 3 object-rest destructuring operator. The difference type `rest(T, a, b, c)` represents the type `T` after the properties `a`, `b` and `c` have been removed, as well as call signatures and construct signatures. A short example illustrates the way this type is used: ``` ts /** JavaScript version */ function removeX(o) { let { x, ...rest } = o; return rest; } /** Typescript version */ function removeX<T extends { x: number, y: number }>(o: T): rest(T, x) { let { x, ...rest }: T = o; return rest; } ``` ## Type Relationships - `rest(A)` is not equivalent to `A` because it is missing call and construct signatures. - `rest(rest(A))` is equivalent to `rest(A)`. - `rest(rest(A, a), b)` is equivalent to `rest(rest(A, b), a)` and `rest(A, a, b)`. - `rest(A | B, a)` is equivalent to `rest(A, a) | rest(B, a)`. ## Assignment compatibility - `rest(T, x)` is not assignable to `T`. - `T` is assignable to `rest(T, x)` because `T` has more properties and signatures. ## Properties and index signatures The type `rest(A, P)` removes `P` from `A` if it exists. Otherwise, it does nothing. ## Call and Construct signatures `rest(A)` does not have call or construct signatures. ## Precedence Difference types have similar precedence to `-` in the expression grammar, particularly compared to `&` and `|`. TODO: Find out what this precedence is.
Suggestion,Revisit
high
Critical
175,371,986
opencv
Ninja-based build fails on Windows when building with CUDA
##### System information (version) - OpenCV => 3.1 - Operating System / Platform => Windows 64 Bit - Compiler => Visual Studio 12.0 ##### Detailed description I am running into problems building OpenCV 3.1.0 with CUDA support on Windows. The problem seems to stem from the path to the CUDA libraries having spaces in it: ``` [740/1182] Linking CXX shared library bin\opencv_world310.dll FAILED: bin/opencv_world310.dll lib/opencv_world310.lib cmd.exe /C "cd . && "C:\Program Files (x86)\CMake\bin\cmake.exe" -E vs_link_dll --intdir=modules\world\CMakeFiles\opencv_world.dir --manifests -- C:\PROGRA~2\M ICROS~2.0\VC\bin\amd64\link.exe /nologo @CMakeFiles/opencv_world.rsp /out:bin\o pencv_world310.dll /implib:lib\opencv_world310.lib /pdb:bin\opencv_world310.pdb /dll /version:3.1 /machine:x64 /INCREMENTAL:NO /NODEFAULTLIB:atlthunk.lib /NODEF AULTLIB:atlsd.lib /NODEFAULTLIB:libcmt.lib /DEBUG && cmd.exe /C "cd /D C:\User s\rjray\opencv\build\modules\world && "C:\Program Files (x86)\CMake\bin\cmake.ex e" -E copy_if_different C:/Users/rjray/opencv/opencv/3rdparty/ffmpeg/opencv_ffmp eg_64.dll C:/Users/rjray/opencv/build/bin/opencv_ffmpeg310_64.dll"" LINK : warning LNK4044: unrecognized option '/LC:/Program'; ignored LINK : fatal error LNK1181: cannot open input file 'Files/NVIDIA.obj' LINK failed. with 1181 ninja: build stopped: subcommand failed. ``` We are using Ninja as the build system, with CMake using Ninja as the target (`-GNinja`). The command used to configure CMake is: ``` cmake \ -GNinja \ -DCMAKE_BUILD_TYPE=Release \ -DINSTALL_TESTS=ON \ -DWITH_OPENCL=OFF \ -DBUILD_SHARED_LIBS=ON \ -DBUILD_TESTS=ON \ -DBUILD_opencv_python2=OFF \ -DBUILD_opencv_python3=OFF \ -DBUILD_PERF_TESTS=ON \ -DWITH_FFMPEG=ON \ -DINSTALL_CREATE_DISTRIB=ON \ -DENABLE_SSE=ON \ -DENABLE_SSE2=ON \ -DWITH_CUDA=ON \ "-DCUDA_TOOLKIT_ROOT_DIR=C:/Program Files/NVIDIA GPU Computing Toolkit/CUDA/v8.0" \ -DBUILD_opencv_java=OFF \ -DWITH_MSMF=OFF \ -DWITH_TBB=OFF \ -DWITH_1394=OFF \ -DWITH_VFW=OFF \ -DBUILD_DOCS=OFF \ -DBUILD_EXAMPLES=OFF \ -DWITH_VTK=OFF \ ..\opencv ``` (Actual command is one line, the backslashes and line-breaks are because the above comes from a guide I am writing, and are there for readability.) I have also tried the above command with the quoting of the `CUDA_TOOLKIT_ROOT_DIR` element escaped: ``` ^"-DCUDA_TOOLKIT_ROOT_DIR=C:/Program Files/NVIDIA GPU Computing Toolkit/CUDA/v8.0^" ``` This did not help. Our build system is able to build the 2.4.13 source without a problem on the same Windows machine with the same toolchain, so I suspect that this is something introduced later than the 2.4 branch. Our builds of 2.4.13 are using the same toolkit-root declaration as above (the quoted-escaped version of the line is what our build system is using). The error message from linking implies that the toolkit root path is being passed to a `/L` option without escaping the spaces in the path. In the files generated by CMake for 2.4.13, the reference to the toolkit dir had the spaces escaped with `$` characters, but I cannot find the declaration in the files generated for 3.1.0, so I can't see how it is being declared. I am including the files CMakeCache.txt and build.ninja (as `build.ninja.txt`, so that GitHub will upload it), in case they can offer some insight. [CMakeCache.txt](https://github.com/opencv/opencv/files/457954/CMakeCache.txt) [build.ninja.txt](https://github.com/opencv/opencv/files/457958/build.ninja.txt)
bug,priority: low,category: build/install,category: gpu/cuda (contrib)
low
Critical
175,382,196
flutter
DropDown have the ghost of a SizeObserver inside them
The way we handle the initial scroll offset means that we take two frames to render a dropdown. We should be able to compute the scroll offset at layout time and set it then, before paint, rather than requiring a loop through build via scrollTo(). See also https://github.com/flutter/flutter/issues/5750 about making DropDown lazy.
framework,f: material design,c: performance,perf: speed,P2,team-design,triaged-design
low
Minor
175,382,620
youtube-dl
Site support request for VoyeurWeb
## Please follow the guide below - You will be asked some questions and requested to provide some information, please read them **carefully** and answer honestly - Put an `x` into all the boxes [ ] relevant to your _issue_ (like that [x]) - Use _Preview_ tab to see how your issue will actually look like --- ### Make sure you are using the _latest_ version: run `youtube-dl --version` and ensure your version is _2016.09.04.1_. If it's not read [this FAQ entry](https://github.com/rg3/youtube-dl/blob/master/README.md#how-do-i-update-youtube-dl) and update. Issues with outdated version will be rejected. - [x] I've **verified** and **I assure** that I'm running youtube-dl **2016.09.04.1** ### Before submitting an _issue_ make sure you have: - [x] At least skimmed through [README](https://github.com/rg3/youtube-dl/blob/master/README.md) and **most notably** [FAQ](https://github.com/rg3/youtube-dl#faq) and [BUGS](https://github.com/rg3/youtube-dl#bugs) sections - [x] [Searched](https://github.com/rg3/youtube-dl/search?type=Issues) the bugtracker for similar issues including closed ones ### What is the purpose of your _issue_? - [ ] Bug report (encountered problems with youtube-dl) - [x] Site support request (request for adding support for a new site) - [ ] Feature request (request for a new functionality) - [ ] Question - [ ] Other ### If the purpose of this _issue_ is a _bug report_, _site support request_ or you are not completely sure provide the full verbose output as follows: Add `-v` flag to **your command line** you run youtube-dl with, copy the **whole** output and insert it here. It should look similar to one below (replace it with **your** log inserted between triple ```): ``` youtube-dl -v http://www.voyeurweb.com/contributions/view/3233689-playing-with-my-tits [debug] System config: [] [debug] User config: ['-f', 'bestvideo+bestaudio/best', '--external-downloader=aria2c', '--external-downloader-args=--file-allocation=falloc --max-connection-per-server=10 --min-split-size=1M', '--netrc'] [debug] Command-line args: ['-v', 'http://www.voyeurweb.com/contributions/view/3233689-playing-with-my-tits'] [debug] Encodings: locale UTF-8, fs utf-8, out UTF-8, pref UTF-8 [debug] youtube-dl version 2016.09.04.1 [debug] Python version 3.5.1 - Darwin-15.6.0-x86_64-i386-64bit [debug] exe versions: avconv 11.4, avprobe 11.4, ffmpeg 3.1.2, ffprobe 3.1.2, rtmpdump 2.4 [debug] Proxy map: {} [generic] 3233689-playing-with-my-tits: Requesting header WARNING: Falling back on generic information extractor. [generic] 3233689-playing-with-my-tits: Downloading webpage [generic] 3233689-playing-with-my-tits: Extracting information ERROR: Unsupported URL: http://www.voyeurweb.com/contributions/view/3233689-playing-with-my-tits Traceback (most recent call last): File "/usr/local/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 691, in extract_info ie_result = ie.extract(url) File "/usr/local/bin/youtube-dl/youtube_dl/extractor/common.py", line 347, in extract return self._real_extract(url) File "/usr/local/bin/youtube-dl/youtube_dl/extractor/generic.py", line 2388, in _real_extract raise UnsupportedError(url) youtube_dl.utils.UnsupportedError: Unsupported URL: http://www.voyeurweb.com/contributions/view/3233689-playing-with-my-tits ``` --- ### If the purpose of this _issue_ is a _site support request_ please provide all kinds of example URLs support for which should be included (replace following example URLs by **yours**): - Single video: http://www.voyeurweb.com/contributions/view/3233689-playing-with-my-tits - Single video: http://www.voyeurweb.com/contributions/view/3233364-summer-fever - Single video: http://www.voyeurweb.com/contributions/view/3232909-stripping --- ### Description of your _issue_, suggested solution and other information Explanation of your _issue_ in arbitrary form goes here. Please make sure the [description is worded well enough to be understood](https://github.com/rg3/youtube-dl#is-the-description-of-the-issue-itself-sufficient). Provide as much context and examples as possible. If work on your _issue_ required an account credentials please provide them or explain how one can obtain them.
site-support-request,nsfw
low
Critical
175,416,868
youtube-dl
Possibility of changing the project license
_So I know this is going to be a controversial suggestion, and please take the filing of this issue as just that, a suggestion._ tl;dr - The current public domain license causes licensing issues as well as contributing issues that could be fixed with something like Apache. Adopting another license is a trivial amount of effort, involves no operational changes to the project, and has some non-zero possibility of providing legal or contributory advantages. ## Problems with Current License The current license [Unlicense](http://unlicense.org) has a variety of issues: 1. **It's not a comprehensive public domain license in the first place.** Because of it's wording, it may not be applicable in some countries due to the legal differences in the definition of public domain. IANAL, so I cannot claim expertise, but I know the community has wrestled with this issue before, and is why CC0 is generally considered a better alternative, since in cases where public domain does not really exist, CC0 falls back and becomes a normal, lax copyright license that gives almost the same effects. 2. **It prevents the inclusion of most third-party code or libraries.** Pretty much any Python library (many of which are MIT, BSD, or Apache licensed), any StackOverflow code, or even code copied from other libraries indirectly (see #10557) cannot be included unless explicitly authorized by _all_ copyright holders of such software. That's because the licenses are incompatible. Getting authors' permissions for every included snippet of code is cumbersome, and creates a lot of extra work. 3. **It prevents many corporate contributors from contributing.** Speaking from personal experience as a Google employee, it is significantly more difficult (albeit not impossible) for me to submit code to this project during work hours because of the license. Many large companies have policies allowing employees to contribute to open source projects, but if the license is not one reviewed or approved by the company (usually Apache, GPL, etc.) then you have to jump through more hoops. (This is because all contributions made during work hours or with work equipment is property of the company, so you need company permission to actually release it under the given license.) To be more concrete with my anecdote, for me, if this project was under the Apache or GPL license, I could contribute indefinitely and without approval. But as it stands, I need to submit every patch I plan on uploading along with the project's information to a compliance committee who has to review my change and ensure it's OK. ### Counterpoints 1. This is a small project, so there's really no need to care about whether public domain applies in certain countries. Nobody is going to sue the youtube-dl contributors. 2. This project uses very little third-party code, so the issues I mentioned regarding licensing really don't apply often. 3. I don't have any non-anecdotal evidence on what the actual impact of these issues are on the project, or whether it actually affects the number of contributors. ### Counter-counterpoints 1. Better safe than sorry. 2. Changing the license takes less effort than asking permission for even a single inclusion of third-party code. 3. There is the possibility there is an impact, and the current license is holding back people from contributing that we don't know about. ## Why Public Domain Isn't Necessary This is a more personal opinion, but I believe public domain is unnecessary. In other words, presuming the current authors already don't care about copyright or its enforcement for this project, there is _no advantage_ that the public domain gives over a standard relaxed license like the Apache license. The differences between Unlicense and Apache are (roughly): - The copyright notice and license must be distributed along with the project. [Trivial] - Modified copies must contain notices of the files changed. [Doesn't matter if copyright isn't being enforced by the authors.] - Apache provides protections to the other contributors and users against patent and copyright claims from malicious contributors of code. [Like above, probably not an issue, but better safe than sorry.] My general position is that **adopting another license is a trivial amount of effort, involves no operational changes to the project, and has some non-zero possibility of providing legal or contributory advantages**. The contributors don't have to do anything special. The project can be packaged and distributed as it has always been done. The only effort is the changing of a single text file. And the result will be additional legal protection (if it ever becomes needed) as well as the possibility of easier development and more contributors. ## Possible Replacement Licenses If by now you are at least convinced of choosing a new license, I three recommendations: - **[CC0](https://creativecommons.org/publicdomain/zero/1.0/)**: fixes _some_ of the issues I mentioned, but not all. A good compromise if people are really insistent on sticking with public domain. - **[Apache 2.0](https://www.apache.org/licenses/LICENSE-2.0)**: the license I've mentioned many times, and will solve all the problems I mentioned with no operational changes - **[GPL 3.0](https://www.gnu.org/licenses/gpl-3.0.en.html)**: a stronger license, and the one used by MPV, that requires the license propagate into modified copies. If the authors don't plan on enforcing copyright, it doesn't really make a difference since the whole point of the GPL is to allow authors to sue if it's not followed. Nonetheless, I like it personally because I'm a free software advocate, but that's a separate concern from the other stuff I've mentioned. There are, of course, many other choices, but I don't recommend licenses like MIT or BSD. They don't provide the same patent protections as the Apache license, and otherwise have zero advantage over Apache. I know the Apache license is longer and has more legalese, but that's just because it's an actual, modern software license. ## Summary I know I've said a lot, and this is pretty much an essay, but it would be really cool if it was easier for me, and I presume others, to contribute code to and include third-party code in this project freely. I don't presume to be a core contributor to this project, so I hope this essay does not sound too prescriptive. If you all decide just to close this, then obviously that's your decision. But I hope I could get at least your consideration, because the amount of effort that would be saved for me alone would outweigh even the amount of effort I put into writing this bug report.
request,bug
medium
Critical
175,421,969
opencv
HIGHGUI ERROR: V4L/V4L2: VIDIOC_S_CROP
<!-- i am running code for face detection and i got this error : HIGHGUI ERROR: V4L/V4L2: VIDIOC_S_CROP Traceback (most recent call last): File "web.py", line 16, in <module> faces = face_cascade.detectMultiScale(gray, 1.3 find the attachment --> [threading.tar.gz](https://github.com/opencv/opencv/files/458410/threading.tar.gz)
incomplete
low
Critical
175,443,980
go
x/exp/shiny: value of event/key.Event.Rune inconsistent across platforms while control key is pressed
Please answer these questions before submitting your issue. Thanks! ### What version of Go are you using (`go version`)? go version go1.7 linux/amd64 go version go1.7 windows/amd64 ### What did you do? Open a shiny window, log key events received, press ctrl+C on the window. ### What did you expect to see? I expected the value of event/key.Event.Rune to be the same on linux and windows ### What did you see instead? On linux ctrl+C produces the rune 'c', on windows 0x3 is reported instead. This isn't limited to 'c' all ctrl+key combinations produce different results on windows and linux. I think that the value of Rune should either be the same across platforms or always set to -1 when ctrl is pressed.
NeedsDecision
low
Major
175,521,282
go
cmd/cgo: support clang on Windows
What version of Go are you using (go version)? go version devel +0cff219 Wed Sep 7 10:43:13 2016 +0000 windows/amd64 What operating system and processor architecture are you using (go env)? Windows 10 / AMD64 What did you do? I used CGO with Clang for Windows 3.8.1 (http://llvm.org/releases/3.8.1/LLVM-3.8.1-win64.exe) like this: set CC=clang set CGO_CFLAGS="-m64 -Ipath/to/my/includes" set CGO_LDFLAGS = "-v -Xlinker -libpath:path/to/libs -lwldap32 -ladvapi32 -lws2_32 -ldbghelp -luser32" go build What did you expect to see? Expected to see nothing (ie, successful compile) ### What did you see instead? ``` # editor/dom clang version 3.8.1 (branches/release_38) Target: x86_64-pc-windows-msvc Thread model: posix InstalledDir: C:\Program Files\LLVM\bin "C:\\Program Files (x86)\\Microsoft Visual Studio 14.0\\VC\\bin\\amd64\\link.exe" "-out:C:\\Users\\CHRIST~1\\AppData\\Local\\Temp\\go-build406860094\\editor\\dom\\_obj\\_cgo_.o" -defaultlib:libcmt "-libpath:C:\\Program Files (x86)\\Microsoft Visual Studio 14.0\\VC\\lib\\amd64" "-libpath:C:\\Program Files (x86)\\Windows Kits\\10\\Lib\\10.0.10240.0\\ucrt\\x64" "-libpath:C:\\Program Files (x86)\\Windows Kits\\8.1\\Lib\\winv6.3\\um\\x64" -nologo "C:\\Users\\CHRIST~1\\AppData\\Local\\Temp\\go-build406860094\\editor\\dom\\_obj\\_cgo_main.o" "C:\\Users\\CHRIST~1\\AppData\\Local\\Temp\\go-build406860094\\editor\\dom\\_obj\\_cgo_export.o" "C:\\Users\\CHRIST~1\\AppData\\Local\\Temp\\go-build406860094\\editor\\dom\\_obj\\binding.cgo2.o" "-libpath:c:\\temp\\go\\src\\editor\\.mm\\windows\\amd64\\release\\lib" core-static.lib ssl-static.lib crypto-static.lib ssh2-static.lib c-ares-static.lib user32.lib ws2_32.lib wldap32.lib advapi32.lib dbghelp.lib Creating library $WORK\editor\dom\_obj\_cgo_.lib and object $WORK\editor\dom\_obj\_cgo_.exp core-static.lib(node.obj) : warning LNK4049: locally defined symbol xmlFree imported core-static.lib(xml.obj) : warning LNK4049: locally defined symbol xmlFree imported # editor/dom clang version 3.8.1 (branches/release_38) Target: x86_64-pc-windows-msvc Thread model: posix InstalledDir: C:\Program Files\LLVM\bin "C:\\Program Files (x86)\\Microsoft Visual Studio 14.0\\VC\\bin\\amd64\\link.exe" "-out:C:\\Users\\CHRIST~1\\AppData\\Local\\Temp\\go-build406860094\\editor\\dom\\_obj\\_all.o" "-libpath:C:\\Program Files (x86)\\Microsoft Visual Studio 14.0\\VC\\lib\\amd64" "-libpath:C:\\Program Files (x86)\\Windows Kits\\10\\Lib\\10.0.10240.0\\ucrt\\x64" "-libpath:C:\\Program Files (x86)\\Windows Kits\\8.1\\Lib\\winv6.3\\um\\x64" -nologo "C:\\Users\\CHRIST~1\\AppData\\Local\\Temp\\go-build406860094\\editor\\dom\\_obj\\_cgo_export.o" "C:\\Users\\CHRIST~1\\AppData\\Local\\Temp\\go-build406860094\\editor\\dom\\_obj\\binding.cgo2.o" -Wl,-r LINK : warning LNK4044: unrecognized option '/Wl,-r'; ignored LINK : fatal error LNK1561: entry point must be defined clang.exe: error: linker command failed with exit code 1561 (use -v to see invocation) ```
help wanted,OS-Windows,NeedsFix,compiler/runtime
high
Critical
175,536,431
TypeScript
[Proposal] Display all properties (inherited or not) of a given class (in TypeScript)
_From @yahiko00 on September 4, 2016 21:56_ Visual Studio Code is a fantastic tool and I am really impressed by all its features despite being quite young. There is a feature that does not still exists in VS Code which could be really convenient when we are forced to deal with big inheritance hierarchies. This proposal is based on the TypeScript language, but I am quite sure this could apply to other OOP languages VS Code supports. ## Overview of the Workflow Let us assume we have a source file _animal.ts_ like this: ``` ts // animal.ts abstract class Animal { private dna: number; name: string; constructor(name: string) { this.dna = Math.random(); this.name = name; } abstract shout(): string; } ``` This file could be open or not in VS Code, but it is part of the current project. Let us assume we have another source file _bird.ts_ like this: ``` ts // bird.ts class Bird extends Animal { constructor() { super(); this.name = "Hector"; } shout(): string { return "Cuicui!"; // sorry it is in French... I do not know how a bird shouts in English ^_^ } } ``` This file is open in VS Code. What I would like to be able to do in VS Code is displaying all properties, inherited or not, available for the class `Bird`. To do so, we could move the cursor on the `Bird` identifier, press F1 key, and run a new _Display all inherited properties_ command. This new command would open a new file in a new tab called _Bird (all inherited properties)_. In this example, the content of this file would be the following: ``` class Bird { private dna: number; name: string; super.constructor(name: string) { this.dna = Math.random(); this.name = name; } constructor() { super(); this.name = "Hector"; } shout(): string { return "Cuicui!"; } } ``` The content of _Bird (all inherited properties)_ has nothing to do with valid syntax. Its purpose is only informational. ## Some informal rules - Attributes should be displayed first. - Type anotations should be rendered unchanged. - Access modifiers `public`, `protected`, `private` should be rendered unchanged. - Abstract methods which are not overriden should be rendered. - All versions of an overriden method should be rendered, with a concatenation of `super` prefixes to distinguish each version in the inheritance hierarchy. For instance `super.method()` would refer to immediate `method()`'s parent, whereas `super.super.method()` would refer to `method()`'s grand-parent, and so on. - `Method()`'s parent should be displayed before the `method()` itself. - The same rules for `method()` apply to `constructor()`. _Copied from original issue: Microsoft/vscode#11526_
Suggestion,Needs Proposal,VS Code Tracked
medium
Critical
175,560,494
opencv
Executable download differs from build.
##### System information (version) - OpenCV => 3.1 - Operating System / Platform => Windows 64 Bit - Compiler => Visual Studio 2013 ##### Detailed description Downloading the executable from opencv.org and installing provides OpenCV 3.1 with a different directory structure then when building from source, the opencv_world310.libs are not built by the downloadable installer either, it looks more like a 2.x version really That makes code written for the sole `#include <opencv2/opencv.hpp>` import dysfunctional when building with the downloaded version.
incomplete
low
Minor
175,610,408
go
cmd/compile: detect call trees that can be marked NOSPLIT
CL 24814 contains a minor optimization for 386/amd64: Ignore a few common runtime functions that take no arguments when deciding whether a function is a leaf function and is thus eligible for being marked NOSPLIT and thus having no function prolog. Keith suggested some ways during code review to make this analysis much more powerful. This issue is a reminder to investigate those suggestions.
Performance,compiler/runtime
low
Minor
175,627,366
flutter
Path.arcTo doesn't draw anything if its angles add up to a multiple of 2*PI
framework,d: api docs,P3,team-framework,triaged-framework
low
Minor
175,679,093
opencv
highgui error when cross compiling to mips architecture (MT7688) linkit smart 7688 device from ubuntu 14.04
**_### Same Error when compiling with all versions of opencv. Currently using opencv 2.4.11 version. After running "cmake-gui" command and configuring the required libraries.Then when running the "make" command i am getting the following error. By skipping highgui library i am able to compile opencv.But i require highgui for my applications._** < ``` Scanning dependencies of target libtiff [ 2%] Building C object 3rdparty/libtiff/CMakeFiles/libtiff.dir/tif_aux.c.o [ 2%] Building C object 3rdparty/libtiff/CMakeFiles/libtiff.dir/tif_close.c.o [ 2%] Building C object 3rdparty/libtiff/CMakeFiles/libtiff.dir/tif_codec.c.o [ 2%] Building C object 3rdparty/libtiff/CMakeFiles/libtiff.dir/tif_color.c.o [ 2%] Building C object 3rdparty/libtiff/CMakeFiles/libtiff.dir/tif_compress.c.o [ 2%] Building C object 3rdparty/libtiff/CMakeFiles/libtiff.dir/tif_dir.c.o [ 2%] Building C object 3rdparty/libtiff/CMakeFiles/libtiff.dir/tif_dirinfo.c.o [ 2%] Building C object 3rdparty/libtiff/CMakeFiles/libtiff.dir/tif_dirread.c.o [ 3%] Building C object 3rdparty/libtiff/CMakeFiles/libtiff.dir/tif_dirwrite.c.o [ 3%] Building C object 3rdparty/libtiff/CMakeFiles/libtiff.dir/tif_dumpmode.c.o [ 3%] Building C object 3rdparty/libtiff/CMakeFiles/libtiff.dir/tif_error.c.o [ 3%] Building C object 3rdparty/libtiff/CMakeFiles/libtiff.dir/tif_extension.c.o [ 3%] Building C object 3rdparty/libtiff/CMakeFiles/libtiff.dir/tif_fax3.c.o [ 3%] Building C object 3rdparty/libtiff/CMakeFiles/libtiff.dir/tif_fax3sm.c.o [ 3%] Building C object 3rdparty/libtiff/CMakeFiles/libtiff.dir/tif_flush.c.o [ 3%] Building C object 3rdparty/libtiff/CMakeFiles/libtiff.dir/tif_getimage.c.o [ 3%] Building C object 3rdparty/libtiff/CMakeFiles/libtiff.dir/tif_jbig.c.o [ 3%] Building C object 3rdparty/libtiff/CMakeFiles/libtiff.dir/tif_jpeg_12.c.o [ 3%] Building C object 3rdparty/libtiff/CMakeFiles/libtiff.dir/tif_jpeg.c.o [ 3%] Building C object 3rdparty/libtiff/CMakeFiles/libtiff.dir/tif_luv.c.o [ 4%] Building C object 3rdparty/libtiff/CMakeFiles/libtiff.dir/tif_lzma.c.o [ 4%] Building C object 3rdparty/libtiff/CMakeFiles/libtiff.dir/tif_lzw.c.o [ 4%] Building C object 3rdparty/libtiff/CMakeFiles/libtiff.dir/tif_next.c.o [ 4%] Building C object 3rdparty/libtiff/CMakeFiles/libtiff.dir/tif_ojpeg.c.o [ 4%] Building C object 3rdparty/libtiff/CMakeFiles/libtiff.dir/tif_open.c.o [ 4%] Building C object 3rdparty/libtiff/CMakeFiles/libtiff.dir/tif_packbits.c.o [ 4%] Building C object 3rdparty/libtiff/CMakeFiles/libtiff.dir/tif_pixarlog.c.o [ 4%] Building C object 3rdparty/libtiff/CMakeFiles/libtiff.dir/tif_predict.c.o [ 4%] Building C object 3rdparty/libtiff/CMakeFiles/libtiff.dir/tif_print.c.o [ 4%] Building C object 3rdparty/libtiff/CMakeFiles/libtiff.dir/tif_read.c.o [ 4%] Building C object 3rdparty/libtiff/CMakeFiles/libtiff.dir/tif_strip.c.o [ 5%] Building C object 3rdparty/libtiff/CMakeFiles/libtiff.dir/tif_swab.c.o [ 5%] Building C object 3rdparty/libtiff/CMakeFiles/libtiff.dir/tif_thunder.c.o [ 5%] Building C object 3rdparty/libtiff/CMakeFiles/libtiff.dir/tif_tile.c.o [ 5%] Building C object 3rdparty/libtiff/CMakeFiles/libtiff.dir/tif_version.c.o [ 5%] Building C object 3rdparty/libtiff/CMakeFiles/libtiff.dir/tif_warning.c.o [ 5%] Building C object 3rdparty/libtiff/CMakeFiles/libtiff.dir/tif_write.c.o [ 5%] Building C object 3rdparty/libtiff/CMakeFiles/libtiff.dir/tif_zip.c.o [ 5%] Building CXX object 3rdparty/libtiff/CMakeFiles/libtiff.dir/tif_stream.cxx.o [ 5%] Building C object 3rdparty/libtiff/CMakeFiles/libtiff.dir/tif_unix.c.o Linking CXX static library ../lib/liblibtiff.a [ 5%] Built target libtiff [ 9%] Built target libjpeg [ 12%] Built target libjasper Scanning dependencies of target libpng [ 13%] Building C object 3rdparty/libpng/CMakeFiles/libpng.dir/pngread.c.o [ 13%] Building C object 3rdparty/libpng/CMakeFiles/libpng.dir/pngpread.c.o [ 13%] Building C object 3rdparty/libpng/CMakeFiles/libpng.dir/pngtrans.c.o [ 13%] Building C object 3rdparty/libpng/CMakeFiles/libpng.dir/pngrio.c.o [ 13%] Building C object 3rdparty/libpng/CMakeFiles/libpng.dir/pngrutil.c.o [ 13%] Building C object 3rdparty/libpng/CMakeFiles/libpng.dir/pngwtran.c.o [ 13%] Building C object 3rdparty/libpng/CMakeFiles/libpng.dir/png.c.o [ 13%] Building C object 3rdparty/libpng/CMakeFiles/libpng.dir/pngwutil.c.o [ 13%] Building C object 3rdparty/libpng/CMakeFiles/libpng.dir/pngwrite.c.o [ 13%] Building C object 3rdparty/libpng/CMakeFiles/libpng.dir/pngrtran.c.o [ 13%] Building C object 3rdparty/libpng/CMakeFiles/libpng.dir/pngerror.c.o [ 13%] Building C object 3rdparty/libpng/CMakeFiles/libpng.dir/pngget.c.o [ 14%] Building C object 3rdparty/libpng/CMakeFiles/libpng.dir/pngset.c.o [ 14%] Building C object 3rdparty/libpng/CMakeFiles/libpng.dir/pngmem.c.o [ 14%] Building C object 3rdparty/libpng/CMakeFiles/libpng.dir/pngwio.c.o Linking C static library ../lib/liblibpng.a [ 14%] Built target libpng Scanning dependencies of target IlmImf [ 14%] Building CXX object 3rdparty/openexr/CMakeFiles/IlmImf.dir/Half/half.cpp.o [ 14%] Building CXX object 3rdparty/openexr/CMakeFiles/IlmImf.dir/Iex/IexThrowErrnoExc.cpp.o [ 14%] Building CXX object 3rdparty/openexr/CMakeFiles/IlmImf.dir/Iex/IexBaseExc.cpp.o [ 14%] Building CXX object 3rdparty/openexr/CMakeFiles/IlmImf.dir/IlmThread/IlmThreadMutex.cpp.o [ 14%] Building CXX object 3rdparty/openexr/CMakeFiles/IlmImf.dir/IlmThread/IlmThreadSemaphorePosix.cpp.o [ 14%] Building CXX object 3rdparty/openexr/CMakeFiles/IlmImf.dir/IlmThread/IlmThreadPosix.cpp.o [ 14%] Building CXX object 3rdparty/openexr/CMakeFiles/IlmImf.dir/IlmThread/IlmThreadPool.cpp.o [ 14%] Building CXX object 3rdparty/openexr/CMakeFiles/IlmImf.dir/IlmThread/IlmThread.cpp.o [ 14%] Building CXX object 3rdparty/openexr/CMakeFiles/IlmImf.dir/IlmThread/IlmThreadSemaphore.cpp.o [ 14%] Building CXX object 3rdparty/openexr/CMakeFiles/IlmImf.dir/IlmThread/IlmThreadSemaphorePosixCompat.cpp.o [ 14%] Building CXX object 3rdparty/openexr/CMakeFiles/IlmImf.dir/IlmThread/IlmThreadMutexPosix.cpp.o [ 15%] Building CXX object 3rdparty/openexr/CMakeFiles/IlmImf.dir/Imath/ImathRandom.cpp.o [ 15%] Building CXX object 3rdparty/openexr/CMakeFiles/IlmImf.dir/Imath/ImathMatrixAlgo.cpp.o [ 15%] Building CXX object 3rdparty/openexr/CMakeFiles/IlmImf.dir/Imath/ImathVec.cpp.o [ 15%] Building CXX object 3rdparty/openexr/CMakeFiles/IlmImf.dir/Imath/ImathFun.cpp.o [ 15%] Building CXX object 3rdparty/openexr/CMakeFiles/IlmImf.dir/Imath/ImathColorAlgo.cpp.o [ 15%] Building CXX object 3rdparty/openexr/CMakeFiles/IlmImf.dir/IlmImf/ImfMisc.cpp.o [ 15%] Building CXX object 3rdparty/openexr/CMakeFiles/IlmImf.dir/IlmImf/ImfMultiView.cpp.o [ 15%] Building CXX object 3rdparty/openexr/CMakeFiles/IlmImf.dir/IlmImf/ImfMatrixAttribute.cpp.o [ 15%] Building CXX object 3rdparty/openexr/CMakeFiles/IlmImf.dir/IlmImf/ImfTimeCode.cpp.o [ 15%] Building CXX object 3rdparty/openexr/CMakeFiles/IlmImf.dir/IlmImf/ImfFloatAttribute.cpp.o [ 15%] Building CXX object 3rdparty/openexr/CMakeFiles/IlmImf.dir/IlmImf/ImfTiledMisc.cpp.o [ 16%] Building CXX object 3rdparty/openexr/CMakeFiles/IlmImf.dir/IlmImf/ImfOutputFile.cpp.o [ 16%] Building CXX object 3rdparty/openexr/CMakeFiles/IlmImf.dir/IlmImf/ImfHeader.cpp.o [ 16%] Building CXX object 3rdparty/openexr/CMakeFiles/IlmImf.dir/IlmImf/ImfIntAttribute.cpp.o [ 16%] Building CXX object 3rdparty/openexr/CMakeFiles/IlmImf.dir/IlmImf/ImfRleCompressor.cpp.o [ 16%] Building CXX object 3rdparty/openexr/CMakeFiles/IlmImf.dir/IlmImf/ImfChannelList.cpp.o [ 16%] Building CXX object 3rdparty/openexr/CMakeFiles/IlmImf.dir/IlmImf/ImfPreviewImageAttribute.cpp.o [ 16%] Building CXX object 3rdparty/openexr/CMakeFiles/IlmImf.dir/IlmImf/ImfThreading.cpp.o [ 16%] Building CXX object 3rdparty/openexr/CMakeFiles/IlmImf.dir/IlmImf/ImfZipCompressor.cpp.o [ 16%] Building CXX object 3rdparty/openexr/CMakeFiles/IlmImf.dir/IlmImf/ImfPizCompressor.cpp.o [ 16%] Building CXX object 3rdparty/openexr/CMakeFiles/IlmImf.dir/IlmImf/ImfHuf.cpp.o [ 16%] Building CXX object 3rdparty/openexr/CMakeFiles/IlmImf.dir/IlmImf/ImfEnvmapAttribute.cpp.o [ 16%] Building CXX object 3rdparty/openexr/CMakeFiles/IlmImf.dir/IlmImf/ImfTimeCodeAttribute.cpp.o [ 17%] Building CXX object 3rdparty/openexr/CMakeFiles/IlmImf.dir/IlmImf/ImfOpaqueAttribute.cpp.o [ 17%] Building CXX object 3rdparty/openexr/CMakeFiles/IlmImf.dir/IlmImf/ImfChromaticities.cpp.o [ 17%] Building CXX object 3rdparty/openexr/CMakeFiles/IlmImf.dir/IlmImf/ImfChromaticitiesAttribute.cpp.o [ 17%] Building CXX object 3rdparty/openexr/CMakeFiles/IlmImf.dir/IlmImf/ImfLineOrderAttribute.cpp.o [ 17%] Building CXX object 3rdparty/openexr/CMakeFiles/IlmImf.dir/IlmImf/ImfChannelListAttribute.cpp.o [ 17%] Building CXX object 3rdparty/openexr/CMakeFiles/IlmImf.dir/IlmImf/ImfStringVectorAttribute.cpp.o [ 17%] Building CXX object 3rdparty/openexr/CMakeFiles/IlmImf.dir/IlmImf/ImfStringAttribute.cpp.o [ 17%] Building CXX object 3rdparty/openexr/CMakeFiles/IlmImf.dir/IlmImf/ImfIO.cpp.o [ 17%] Building CXX object 3rdparty/openexr/CMakeFiles/IlmImf.dir/IlmImf/b44ExpLogTable.cpp.o [ 17%] Building CXX object 3rdparty/openexr/CMakeFiles/IlmImf.dir/IlmImf/ImfPreviewImage.cpp.o [ 17%] Building CXX object 3rdparty/openexr/CMakeFiles/IlmImf.dir/IlmImf/ImfAttribute.cpp.o [ 18%] Building CXX object 3rdparty/openexr/CMakeFiles/IlmImf.dir/IlmImf/ImfAcesFile.cpp.o [ 18%] Building CXX object 3rdparty/openexr/CMakeFiles/IlmImf.dir/IlmImf/ImfKeyCodeAttribute.cpp.o [ 18%] Building CXX object 3rdparty/openexr/CMakeFiles/IlmImf.dir/IlmImf/ImfRational.cpp.o [ 18%] Building CXX object 3rdparty/openexr/CMakeFiles/IlmImf.dir/IlmImf/ImfCRgbaFile.cpp.o [ 18%] Building CXX object 3rdparty/openexr/CMakeFiles/IlmImf.dir/IlmImf/ImfDoubleAttribute.cpp.o [ 18%] Building CXX object 3rdparty/openexr/CMakeFiles/IlmImf.dir/IlmImf/ImfTiledInputFile.cpp.o [ 18%] Building CXX object 3rdparty/openexr/CMakeFiles/IlmImf.dir/IlmImf/ImfVecAttribute.cpp.o [ 18%] Building CXX object 3rdparty/openexr/CMakeFiles/IlmImf.dir/IlmImf/ImfB44Compressor.cpp.o [ 18%] Building CXX object 3rdparty/openexr/CMakeFiles/IlmImf.dir/IlmImf/ImfTileOffsets.cpp.o [ 18%] Building CXX object 3rdparty/openexr/CMakeFiles/IlmImf.dir/IlmImf/ImfRgbaFile.cpp.o [ 18%] Building CXX object 3rdparty/openexr/CMakeFiles/IlmImf.dir/IlmImf/ImfTiledRgbaFile.cpp.o [ 18%] Building CXX object 3rdparty/openexr/CMakeFiles/IlmImf.dir/IlmImf/ImfStdIO.cpp.o [ 19%] Building CXX object 3rdparty/openexr/CMakeFiles/IlmImf.dir/IlmImf/ImfCompressionAttribute.cpp.o [ 19%] Building CXX object 3rdparty/openexr/CMakeFiles/IlmImf.dir/IlmImf/ImfConvert.cpp.o [ 19%] Building CXX object 3rdparty/openexr/CMakeFiles/IlmImf.dir/IlmImf/ImfBoxAttribute.cpp.o [ 19%] Building CXX object 3rdparty/openexr/CMakeFiles/IlmImf.dir/IlmImf/ImfTileDescriptionAttribute.cpp.o [ 19%] Building CXX object 3rdparty/openexr/CMakeFiles/IlmImf.dir/IlmImf/ImfFramesPerSecond.cpp.o [ 19%] Building CXX object 3rdparty/openexr/CMakeFiles/IlmImf.dir/IlmImf/ImfKeyCode.cpp.o [ 19%] Building CXX object 3rdparty/openexr/CMakeFiles/IlmImf.dir/IlmImf/ImfPxr24Compressor.cpp.o [ 19%] Building CXX object 3rdparty/openexr/CMakeFiles/IlmImf.dir/IlmImf/ImfRgbaYca.cpp.o [ 19%] Building CXX object 3rdparty/openexr/CMakeFiles/IlmImf.dir/IlmImf/ImfVersion.cpp.o [ 19%] Building CXX object 3rdparty/openexr/CMakeFiles/IlmImf.dir/IlmImf/ImfCompressor.cpp.o [ 19%] Building CXX object 3rdparty/openexr/CMakeFiles/IlmImf.dir/IlmImf/ImfRationalAttribute.cpp.o [ 20%] Building CXX object 3rdparty/openexr/CMakeFiles/IlmImf.dir/IlmImf/ImfLut.cpp.o [ 20%] Building CXX object 3rdparty/openexr/CMakeFiles/IlmImf.dir/IlmImf/ImfTestFile.cpp.o [ 20%] Building CXX object 3rdparty/openexr/CMakeFiles/IlmImf.dir/IlmImf/ImfInputFile.cpp.o [ 20%] Building CXX object 3rdparty/openexr/CMakeFiles/IlmImf.dir/IlmImf/ImfTiledOutputFile.cpp.o [ 20%] Building CXX object 3rdparty/openexr/CMakeFiles/IlmImf.dir/IlmImf/ImfEnvmap.cpp.o [ 20%] Building CXX object 3rdparty/openexr/CMakeFiles/IlmImf.dir/IlmImf/ImfFrameBuffer.cpp.o [ 20%] Building CXX object 3rdparty/openexr/CMakeFiles/IlmImf.dir/IlmImf/ImfScanLineInputFile.cpp.o [ 20%] Building CXX object 3rdparty/openexr/CMakeFiles/IlmImf.dir/IlmImf/ImfStandardAttributes.cpp.o [ 20%] Building CXX object 3rdparty/openexr/CMakeFiles/IlmImf.dir/IlmImf/ImfWav.cpp.o Linking CXX static library ../lib/libIlmImf.a [ 20%] Built target IlmImf Scanning dependencies of target opencv_core_pch_dephelp [ 20%] Building CXX object modules/core/CMakeFiles/opencv_core_pch_dephelp.dir/opencv_core_pch_dephelp.cxx.o Linking CXX static library ../../lib/libopencv_core_pch_dephelp.a [ 20%] Built target opencv_core_pch_dephelp Scanning dependencies of target pch_Generate_opencv_core [ 20%] Generating precomp.hpp.gch/opencv_core_Release.gch [ 20%] Built target pch_Generate_opencv_core Scanning dependencies of target opencv_core [ 20%] Building CXX object modules/core/CMakeFiles/opencv_core.dir/src/cmdparser.cpp.o [ 20%] Building CXX object modules/core/CMakeFiles/opencv_core.dir/src/lapack.cpp.o [ 20%] Building CXX object modules/core/CMakeFiles/opencv_core.dir/src/dxt.cpp.o [ 20%] Building CXX object modules/core/CMakeFiles/opencv_core.dir/src/copy.cpp.o [ 20%] Building CXX object modules/core/CMakeFiles/opencv_core.dir/src/opengl_interop_deprecated.cpp.o [ 20%] Building CXX object modules/core/CMakeFiles/opencv_core.dir/src/matop.cpp.o [ 20%] Building CXX object modules/core/CMakeFiles/opencv_core.dir/src/tables.cpp.o [ 20%] Building CXX object modules/core/CMakeFiles/opencv_core.dir/src/mathfuncs.cpp.o [ 21%] Building CXX object modules/core/CMakeFiles/opencv_core.dir/src/stat.cpp.o [ 21%] Building CXX object modules/core/CMakeFiles/opencv_core.dir/src/parallel.cpp.o [ 21%] Building CXX object modules/core/CMakeFiles/opencv_core.dir/src/out.cpp.o [ 21%] Building CXX object modules/core/CMakeFiles/opencv_core.dir/src/array.cpp.o [ 21%] Building CXX object modules/core/CMakeFiles/opencv_core.dir/src/gl_core_3_1.cpp.o [ 21%] Building CXX object modules/core/CMakeFiles/opencv_core.dir/src/datastructs.cpp.o [ 21%] Building CXX object modules/core/CMakeFiles/opencv_core.dir/src/arithm.cpp.o [ 21%] Building CXX object modules/core/CMakeFiles/opencv_core.dir/src/algorithm.cpp.o [ 21%] Building CXX object modules/core/CMakeFiles/opencv_core.dir/src/persistence.cpp.o [ 21%] Building CXX object modules/core/CMakeFiles/opencv_core.dir/src/alloc.cpp.o [ 21%] Building CXX object modules/core/CMakeFiles/opencv_core.dir/src/opengl_interop.cpp.o [ 21%] Building CXX object modules/core/CMakeFiles/opencv_core.dir/src/gpumat.cpp.o [ 22%] Building CXX object modules/core/CMakeFiles/opencv_core.dir/src/system.cpp.o [ 22%] Building CXX object modules/core/CMakeFiles/opencv_core.dir/src/matrix.cpp.o [ 22%] Building CXX object modules/core/CMakeFiles/opencv_core.dir/src/drawing.cpp.o [ 22%] Building CXX object modules/core/CMakeFiles/opencv_core.dir/src/rand.cpp.o [ 22%] Building CXX object modules/core/CMakeFiles/opencv_core.dir/src/convert.cpp.o [ 22%] Building CXX object modules/core/CMakeFiles/opencv_core.dir/src/glob.cpp.o [ 22%] Building CXX object modules/core/CMakeFiles/opencv_core.dir/src/matmul.cpp.o Linking CXX shared library ../../lib/libopencv_core.so [ 22%] Built target opencv_core Scanning dependencies of target opencv_ts_pch_dephelp [ 23%] Building CXX object modules/ts/CMakeFiles/opencv_ts_pch_dephelp.dir/opencv_ts_pch_dephelp.cxx.o Linking CXX static library ../../lib/libopencv_ts_pch_dephelp.a [ 23%] Built target opencv_ts_pch_dephelp [ 23%] Generating precomp.hpp.gch/opencv_ts_Release.gch [ 23%] Built target pch_Generate_opencv_ts Scanning dependencies of target opencv_flann_pch_dephelp [ 23%] Building CXX object modules/flann/CMakeFiles/opencv_flann_pch_dephelp.dir/opencv_flann_pch_dephelp.cxx.o Linking CXX static library ../../lib/libopencv_flann_pch_dephelp.a [ 23%] Built target opencv_flann_pch_dephelp [ 23%] Generating precomp.hpp.gch/opencv_flann_Release.gch [ 24%] Built target pch_Generate_opencv_flann Scanning dependencies of target opencv_flann [ 24%] Building CXX object modules/flann/CMakeFiles/opencv_flann.dir/src/miniflann.cpp.o [ 24%] Building CXX object modules/flann/CMakeFiles/opencv_flann.dir/src/flann.cpp.o Linking CXX shared library ../../lib/libopencv_flann.so [ 24%] Built target opencv_flann Scanning dependencies of target opencv_imgproc_pch_dephelp [ 24%] Building CXX object modules/imgproc/CMakeFiles/opencv_imgproc_pch_dephelp.dir/opencv_imgproc_pch_dephelp.cxx.o Linking CXX static library ../../lib/libopencv_imgproc_pch_dephelp.a [ 24%] Built target opencv_imgproc_pch_dephelp [ 24%] Generating precomp.hpp.gch/opencv_imgproc_Release.gch [ 24%] Built target pch_Generate_opencv_imgproc Scanning dependencies of target opencv_imgproc [ 24%] Building CXX object modules/imgproc/CMakeFiles/opencv_imgproc.dir/src/gabor.cpp.o [ 24%] Building CXX object modules/imgproc/CMakeFiles/opencv_imgproc.dir/src/deriv.cpp.o [ 24%] Building CXX object modules/imgproc/CMakeFiles/opencv_imgproc.dir/src/avx/imgwarp_avx.cpp.o [ 24%] Building CXX object modules/imgproc/CMakeFiles/opencv_imgproc.dir/src/convhull.cpp.o [ 24%] Building CXX object modules/imgproc/CMakeFiles/opencv_imgproc.dir/src/thresh.cpp.o [ 24%] Building CXX object modules/imgproc/CMakeFiles/opencv_imgproc.dir/src/accum.cpp.o [ 25%] Building CXX object modules/imgproc/CMakeFiles/opencv_imgproc.dir/src/sumpixels.cpp.o [ 25%] Building CXX object modules/imgproc/CMakeFiles/opencv_imgproc.dir/src/histogram.cpp.o [ 25%] Building CXX object modules/imgproc/CMakeFiles/opencv_imgproc.dir/src/tables.cpp.o [ 25%] Building CXX object modules/imgproc/CMakeFiles/opencv_imgproc.dir/src/emd.cpp.o [ 25%] Building CXX object modules/imgproc/CMakeFiles/opencv_imgproc.dir/src/avx2/imgwarp_avx2.cpp.o [ 25%] Building CXX object modules/imgproc/CMakeFiles/opencv_imgproc.dir/src/cornersubpix.cpp.o [ 25%] Building CXX object modules/imgproc/CMakeFiles/opencv_imgproc.dir/src/color.cpp.o [ 25%] Building CXX object modules/imgproc/CMakeFiles/opencv_imgproc.dir/src/corner.cpp.o [ 25%] Building CXX object modules/imgproc/CMakeFiles/opencv_imgproc.dir/src/contours.cpp.o [ 25%] Building CXX object modules/imgproc/CMakeFiles/opencv_imgproc.dir/src/rotcalipers.cpp.o [ 25%] Building CXX object modules/imgproc/CMakeFiles/opencv_imgproc.dir/src/clahe.cpp.o [ 25%] Building CXX object modules/imgproc/CMakeFiles/opencv_imgproc.dir/src/undistort.cpp.o [ 26%] Building CXX object modules/imgproc/CMakeFiles/opencv_imgproc.dir/src/shapedescr.cpp.o [ 26%] Building CXX object modules/imgproc/CMakeFiles/opencv_imgproc.dir/src/geometry.cpp.o [ 26%] Building CXX object modules/imgproc/CMakeFiles/opencv_imgproc.dir/src/grabcut.cpp.o [ 26%] Building CXX object modules/imgproc/CMakeFiles/opencv_imgproc.dir/src/pyramids.cpp.o [ 26%] Building CXX object modules/imgproc/CMakeFiles/opencv_imgproc.dir/src/approx.cpp.o [ 26%] Building CXX object modules/imgproc/CMakeFiles/opencv_imgproc.dir/src/filter.cpp.o [ 26%] Building CXX object modules/imgproc/CMakeFiles/opencv_imgproc.dir/src/templmatch.cpp.o [ 26%] Building CXX object modules/imgproc/CMakeFiles/opencv_imgproc.dir/src/samplers.cpp.o [ 26%] Building CXX object modules/imgproc/CMakeFiles/opencv_imgproc.dir/src/smooth.cpp.o [ 26%] Building CXX object modules/imgproc/CMakeFiles/opencv_imgproc.dir/src/linefit.cpp.o [ 26%] Building CXX object modules/imgproc/CMakeFiles/opencv_imgproc.dir/src/segmentation.cpp.o [ 27%] Building CXX object modules/imgproc/CMakeFiles/opencv_imgproc.dir/src/distransform.cpp.o [ 27%] Building CXX object modules/imgproc/CMakeFiles/opencv_imgproc.dir/src/canny.cpp.o [ 27%] Building CXX object modules/imgproc/CMakeFiles/opencv_imgproc.dir/src/matchcontours.cpp.o [ 27%] Building CXX object modules/imgproc/CMakeFiles/opencv_imgproc.dir/src/featureselect.cpp.o [ 27%] Building CXX object modules/imgproc/CMakeFiles/opencv_imgproc.dir/src/utils.cpp.o [ 27%] Building CXX object modules/imgproc/CMakeFiles/opencv_imgproc.dir/src/floodfill.cpp.o [ 27%] Building CXX object modules/imgproc/CMakeFiles/opencv_imgproc.dir/src/generalized_hough.cpp.o [ 27%] Building CXX object modules/imgproc/CMakeFiles/opencv_imgproc.dir/src/phasecorr.cpp.o [ 27%] Building CXX object modules/imgproc/CMakeFiles/opencv_imgproc.dir/src/moments.cpp.o [ 27%] Building CXX object modules/imgproc/CMakeFiles/opencv_imgproc.dir/src/hough.cpp.o [ 27%] Building CXX object modules/imgproc/CMakeFiles/opencv_imgproc.dir/src/morph.cpp.o [ 27%] Building CXX object modules/imgproc/CMakeFiles/opencv_imgproc.dir/src/imgwarp.cpp.o [ 28%] Building CXX object modules/imgproc/CMakeFiles/opencv_imgproc.dir/src/subdivision2d.cpp.o Linking CXX shared library ../../lib/libopencv_imgproc.so [ 28%] Built target opencv_imgproc Scanning dependencies of target opencv_highgui_pch_dephelp [ 28%] Building CXX object modules/highgui/CMakeFiles/opencv_highgui_pch_dephelp.dir/opencv_highgui_pch_dephelp.cxx.o Linking CXX static library ../../lib/libopencv_highgui_pch_dephelp.a [ 28%] Built target opencv_highgui_pch_dephelp Scanning dependencies of target pch_Generate_opencv_highgui [ 28%] Generating precomp.hpp.gch/opencv_highgui_Release.gch [ 28%] Built target pch_Generate_opencv_highgui Scanning dependencies of target opencv_highgui [ 28%] Building CXX object modules/highgui/CMakeFiles/opencv_highgui.dir/src/cap.cpp.o [ 28%] Building CXX object modules/highgui/CMakeFiles/opencv_highgui.dir/src/cap_images.cpp.o [ 28%] Building CXX object modules/highgui/CMakeFiles/opencv_highgui.dir/src/loadsave.cpp.o [ 28%] Building CXX object modules/highgui/CMakeFiles/opencv_highgui.dir/src/utils.cpp.o [ 28%] Building CXX object modules/highgui/CMakeFiles/opencv_highgui.dir/src/window.cpp.o [ 28%] Building CXX object modules/highgui/CMakeFiles/opencv_highgui.dir/src/window_gtk.cpp.o [ 29%] Building CXX object modules/highgui/CMakeFiles/opencv_highgui.dir/src/cap_dc1394_v2.cpp.o /home/mvreddy/Desktop/opencv-2.4.11/modules/highgui/src/cap_dc1394_v2.cpp:58:27: fatal error: dc1394/dc1394.h: No such file or directory #include <dc1394/dc1394.h> ^ compilation terminated. make[2]: *** [modules/highgui/CMakeFiles/opencv_highgui.dir/src/cap_dc1394_v2.cpp.o] Error 1 make[1]: *** [modules/highgui/CMakeFiles/opencv_highgui.dir/all] Error 2 make: *** [all] Error 2 > ```
wontfix
low
Critical
175,742,062
TypeScript
Support property decorators for shorthand constructor-parameter syntax
**TypeScript Version:** 2.0.2 **Code** I'm taking advantage of shorthand property declarations syntax via constructor. The code below contains a problem, it won't work as expected for `class City`, it such case typescript will treat `PropertyDecorator` as `ParameterDecorator`, there is no way to supply both `PropertyDecorator` and `ParameterDecorator` simultaneously for such shorthand syntax: ``` ts function PropertyDecorator(target: Object, propertyKey: string | symbol) { } function ParameterDecorator(target: Object, propertyKey: string | symbol, index: number) {} class Country { @PropertyDecorator public name: string; public constructor(name: string) { this.name = name; } } class City { public constructor( @PropertyDecorator public name: string, @PropertyDecorator public country: Country) { } } ``` It looks better to use the following syntax that would allow distinguishing different decorator types: ``` ts function PropertyDecorator(target: Object, propertyKey: string | symbol) { } function ParameterDecorator(target: Object, propertyKey: string | symbol, index: number) {} class Country { public name: string; public constructor(name: string) { this.name = name; } } class City { public constructor( @PropertyDecorator public @ParameterDecorator name: string, @PropertyDecorator public @ParameterDecorator country: Country) { } } ```
Bug
medium
Major
175,750,834
vscode
Feature request: 'Ignore comments' checkbox in the 'Find' dialog
Wide popularity of the embedded documentation conventions like JSDoc and C#'s XML comments leads to a situation where comments often constitute the bigger part of a source file (e.g. look at the source of [angular.js](https://unpkg.com/angular/angular.js): the whole API documentation is there!). This abundance of comments makes it extremely difficult to find anything in the source code proper. For example, reading someone's code, we might want to know how and where a certain function is used. However, if we decide to conduct a search by its name, we might get lost in dozens of code samples in the comments and overlook some important case of its real usage. Shift-F12 often helps in such situations, but not always. This undermines the habitual workflow of those who are used to rely a lot on the search to read the code. Not sure if any other editor has this feature, but it would be great to have the 'Ignore comments' option in VS Code's search dialog.
feature-request,search,editor-find
high
Critical
175,803,961
angular
Add readonly to FormControl formstate
**I'm submitting a ...** (check one with "x") ``` [ ] bug report => search github for a similar issue or PR before submitting [x] feature request [ ] support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question ``` Currently there is a "disabled" flag which will disable the control, and also disable the validator. But there also should be a "readonly" flag which do not disable the validator. **Current behavior** - Does not exist - **Expected behavior** - Explained above - **What is the motivation / use case for changing the behavior?** **Please tell us about your environment:** - **Angular version:** 2.0.0-rc.6 - **Browser:** [all] - **Language:** [all] - **Node (for AoT issues):** `node --version` = 6.5.0
feature,state: Needs Design,freq2: medium,area: forms,Accessibility,feature: under consideration
high
Critical
175,848,729
go
cmd/compile: make algs content-addressable
When we generate algs, we name them after the types they operate on. However, all that matters to the alg is the structure of the type. Equality and hashing is the same for `struct { A [2]int64}` and `struct { B [2]int64 }`. I took an initial stab at this in [CL 19842](https://go-review.googlesource.com/c/19842/) but it didn't properly handle pointers vs scalars. The CL suggested a possible binary size improvement of ~1%. This issue is a reminder to try again, probably after some alg-related cleanup. cc @cherrymui
binary-size,compiler/runtime
low
Major
175,852,487
go
cmd/compile: reuse algs for [N]T arrays
For arrays [N]T where T is not a pure memory type, we currently generate separate algorithms for each distinct value of N. Instead, we could emit simple stub algs that load N into a register/argument, and then jump to a common []T implementation. Unclear if this shows up often enough in practice to be beneficial though. Related #17029.
binary-size,compiler/runtime
low
Minor
175,884,783
You-Dont-Know-JS
ES6 & Beyond: default params truncate function length
![screen shot 2016-09-08 at 11 52 08 pm](https://cloud.githubusercontent.com/assets/150330/18369668/80a2ebb6-7627-11e6-87f5-e5a4b1c54e03.png)
for second edition
medium
Minor
175,885,210
You-Dont-Know-JS
ES6 & Beyond: default params have `this`, `arguments`, etc
![screen shot 2016-09-09 at 12 53 33 am](https://cloud.githubusercontent.com/assets/150330/18369742/e126b8b4-7627-11e6-9288-8f155347e632.png)
for second edition
medium
Minor