id
int64 393k
2.82B
| repo
stringclasses 68
values | title
stringlengths 1
936
| body
stringlengths 0
256k
β | labels
stringlengths 2
508
| priority
stringclasses 3
values | severity
stringclasses 3
values |
|---|---|---|---|---|---|---|
168,206,767 | TypeScript | Protected nested classes | **TypeScript Version:** 1.8.9
**Code**
``` ts
class Outer {
protected static Inner = class {}
private myInner: Outer.Inner;
}
```
**Expected behavior:** No errors.
**Actual behavior:** Compiler error: `Cannot find namespace 'Outer'. Line 3, Column 24`
**Code**
``` ts
class Outer {
protected static Inner = class {}
private myInner: Outer.Inner;
}
namespace Outer {}
```
**Expected behavior:** No errors.
**Actual behavior:** Compiler error: `Module 'Outer' has no exported member 'Inner'. Line 3, Column 32`
**Code**
``` ts
export class Outer {
protected static Inner = class {};
}
export class Child extends Outer {
static temp = class extends Outer.Inner {}
}
```
**Expected behavior:** No errors.
**Actual behavior:** Compiler error: `Property 'Inner' is protected and only accessible within class 'Outer' and its subclasses. Line 6, Column 35`
---
The problem here is that there is no way to define a protected nested class in a way that makes it possible to use in a type declaration. The third example shows why I want to use this: I want a nested class that can only be extended by classes that extend the parent class.
| Suggestion,Awaiting More Feedback | low | Critical |
168,263,008 | vscode | Allow to bring up a dialog with multiple inputs | ## Feature request
It would be nice if an extension could present a single dialog with multiple input fields. For example, the [New Project command in Ionide](https://github.com/ionide/ionide-vscode-fsharp/blob/a58b470dfd2a891eb46a545df0eb326fb0d93038/src/Components/Forge.fs#L142) asks for project directory and project name, and it would be nice to be able to input both at once in a single dialog. Another use case: I would like to implement the [Project Scaffold init script](https://github.com/fsprojects/ProjectScaffold/blob/master/init.fsx#L86) as another option in Ionide's New Project setup. It asks at least seven questions (more if you choose to let it run `git init` for you), and asking each question one at a time in separate dialogs makes for a less-than-ideal user experience. I'd like to be able to present all seven questions in a single dialog.
## Suggested API
`showInputDialog(options: Map<string, InputBoxOptions|QuickPickOptions>, quickPickItems?: Map<string, string[] | Thenable<string[]>>): Thenable<Map<string,string>>`
`options` is an ES6 Map whose keys are the names of the fields we're asking the user to fill in. The user won't see these names, but they will be used as the keys of the resulting Map object. Their ordering matters, since the order of the keys in the Map will be used as the order in which to present the fields in the interaction dialog. (If using an ES6 Map is not yet possible in VS Code, then `options` would be a plain old Javascript object. In that case, an additional `fieldOrder` parameter, an array of strings, would be required -- see below for suggested API if ES6 Map is not yet possible).
The values of the `options` Map will be the InputBoxOptions or QuickPickOptions for that particular field in the interaction dialog. These will be treated exactly as they are in the `showInputBox` and `showQuickPick` functions. If any values of the `options` Map are `QuickPickOptions`, then the `quickPickItems` parameter is required. Its keys must match the keys of `options` that have a `QuickPickOptions` value, and its value is the list of items to pick from (exactly equivalent to the `items` parameter of the `showQuickPick` function). And, just like `showQuickPick`, there would need to be another overload that would match the `showQuickPick<T extends QuickPickItem>(items: T[] | Thenable<T[]>, ...)` overload. I.e.,
`showInputDialog<T extends QuickPickItem>(options: Map<string, InputBoxOptions|QuickPickOptions>, quickPickItems?: Map<string, T[] | Thenable<T[]>>): Thenable<Map<string,string|T>>`
The difference between this and the non-generic `showInputDialog` would be exactly the same as the difference between `showQuickPick<T>` and non-generic `showQuickPick`, so I won't go into further detail on this overload.
The return value of `showInputDialog` would be a promise that resolves to an ES6 Map whose keys are the same as the keys of the `options` parameter, and whose values are the result of what the user typed. If the user canceled the dialog by pressing Escape, the values of the Map will be `undefined`; otherwise, they will be strings in the case of `InputBoxOptions` fields, and either strings or `T` instances in the case of `QuickPickOptions` fields (where `T`, of course, extends `QuickPickItem`, and is only returned in the generic version of `showInputDialog`).
As mentioned above, if it is not yet possible in VS Code's codebase to use an ES6 Map, then my suggested API would look like:
`showInputDialog(fieldOrder: string[], options: object, quickPickItems?: object): Thenable<object>`
or:
`showInputDialog<T extends QuickPickItem>(fieldOrder: string[], options: object, quickPickItems?: object): Thenable<object>`
for the generic version (returning `T` instances, rather than strings, for any QuickPick fields). The keys and values of the input and output objects would be identical to the `Map` version; only the `fieldOrder` parameter is added to specify the order in which the fields should be listed in the dialog.
## Usage example
Since that specification is a bit hard to read, here is an example.
``` javascript
var opts = new Map<string,InputBoxOptions|QuickPickOptions>();
var items = new Map<string,string[]>;
opts.add("ProjectName", {prompt: "Project name?"});
opts.add("InitializeGit", {prompt: "Initialize Git? Y/N"});
opts.add("Template", {placeholder: "Project template"});
items.add("Template", ["F#", "C#", "VB"]);
showInputDialog(opts, items).then(function(result) {
if (result["Template"] == "VB") {
showWarningMessage("Visual Basic support is deprecated.");
}
showInformationMessage("Initializing project...");
initializeProject(result["ProjectName"]);
// etc.
});
```
| feature-request,api,linux,dialogs | medium | Critical |
168,407,633 | rust | Tracking issue for promoting `!` to a type (RFC 1216) | Tracking issue for rust-lang/rfcs#1216, which promotes `!` to a type.
### About tracking issues
Tracking issues are used to record the overall progress of implementation. They are also used as hubs connecting to other relevant issues, e.g., bugs or open design questions. A tracking issue is however *not* meant for large scale discussion, questions, or bug reports about a feature. Instead, open a dedicated issue for the specific matter and add the relevant feature gate label.
## Pending issues to resolve
- [ ] Regressions from fallback to `()` https://github.com/rust-lang/rust/issues/67225
- [ ] How to handle fallback of diverging expressions https://github.com/rust-lang/rust/issues/65992
## Interesting events and links
- Initial PR #35162
- Stabilization PR https://github.com/rust-lang/rust/pull/65355
- Reverting stabilization https://github.com/rust-lang/rust/pull/67224 due to regressions https://github.com/rust-lang/rust/issues/66757 | A-type-system,B-RFC-approved,T-lang,B-unstable,C-tracking-issue,finished-final-comment-period,F-never_type,Libs-Tracked,S-tracking-design-concerns,T-types | high | Critical |
168,424,883 | You-Dont-Know-JS | This & prototype inheritance - Chapter 1 - Grammar issue | > JavaScript's this mechanism isn't actually that advanced, but developers often paraphrase that quote in their own mind by inserting "complex" or "confusing", and there's no question that without lack of clear understanding, this can seem downright magical in your confusion.
Towards the end of the sentence the part that says, "without lack of clear understanding,..." is I think a sort of double negative that to me seems to mean WITH a clear understanding of JS, which wouldn't make sense.
I think it should be either, "..without a clear understanding", or "..a lack of clear understanding can make this seem.."
| for second edition | medium | Minor |
168,452,608 | TypeScript | TSX related formatting bugs | **TypeScript Version:** 2.0 beta
**Code**
`|` is indicating cursor here.
``` ts
<Scene key="root"
| // cursor should be indented so that attribute definitions can be naturally indented
```
``` ts
<Scene key="root">
| // cursor should be indented, as cursor on unfinished array does
```
``` ts
<Scene key = "root" /> // formatting does not work
// PS: this isΒ fixed by #10054
```
**Expected behavior:**
``` ts
<Scene key="root"
|
```
``` ts
<Scene key="root">
|
```
``` ts
<Scene key="root" />
// PS: this isΒ fixed by #10054
```
| Bug,Help Wanted,Domain: Formatter | low | Critical |
168,456,455 | opencv | Set CAP_PROP_FOURCC does not work under Windows for USB camera | ##### System information (version)
- OpenCV => 3.1.0
- Operating System / Platform => Windows 7 64 Bit
- Compiler => Python
##### Detailed description
Trying to switch camera output from YUY2 to MJPG but it does not work. MJPG mode is working in other software packages.
##### Steps to reproduce
```
import cv2
import sys
import numpy as np
import time
fourcc_names = ['CAP_PROP_POS_MSEC', 'CAP_PROP_POS_FRAMES', 'CAP_PROP_POS_AVI_RATIO', 'CAP_PROP_FRAME_WIDTH', 'CAP_PROP_FRAME_HEIGHT', 'CAP_PROP_FPS', 'CAP_PROP_FOURCC', 'CAP_PROP_FRAME_COUNT', 'CAP_PROP_FORMAT', 'CAP_PROP_MODE', 'CAP_PROP_BRIGHTNESS', 'CAP_PROP_CONTRAST', 'CAP_PROP_SATURATION', 'CAP_PROP_HUE', 'CAP_PROP_GAIN', 'CAP_PROP_EXPOSURE', 'CAP_PROP_CONVERT_RGB', 'CAP_PROP_WHITE_BALANCE_BLUE_U', 'CAP_PROP_RECTIFICATION', 'CAP_PROP_MONOCHROME', 'CAP_PROP_SHARPNESS', 'CAP_PROP_AUTO_EXPOSURE', 'CAP_PROP_GAMMA', 'CAP_PROP_TEMPERATURE', 'CAP_PROP_TRIGGER', 'CAP_PROP_TRIGGER_DELAY', 'CAP_PROP_WHITE_BALANCE_RED_V', 'CAP_PROP_ZOOM', 'CAP_PROP_FOCUS', 'CAP_PROP_GUID', 'CAP_PROP_ISO_SPEED', 'CAP_PROP_BACKLIGHT', 'CAP_PROP_PAN', 'CAP_PROP_TILT', 'CAP_PROP_ROLL', 'CAP_PROP_IRIS', 'CAP_PROP_SETTINGS', 'CAP_PROP_BUFFERSIZE', 'CAP_PROP_AUTOFOCUS']
def decode_fourcc(v):
v = int(v)
return "".join([chr((v >> 8 * i) & 0xFF) for i in range(4)])
print cv2.__version__
camera = cv2.VideoCapture()
camera.open(0)
print 'Camera open:', camera.isOpened()
# print camera.get(cv2.CAP_PROP_FOURCC)
# C = camera.get(cv2.CAP_PROP_FOURCC)
# print 'fourcc original:', decode_fourcc(C)
# codec = 0x47504A4D # MJPG
# codec = 844715353.0 # YUY2
codec = 1196444237.0 # MJPG
# print 'fourcc:', decode_fourcc(codec)
camera.set(cv2.CAP_PROP_FOURCC, codec)
camera.set(cv2.CAP_PROP_FRAME_WIDTH, 1280)
camera.set(cv2.CAP_PROP_FRAME_HEIGHT, 720)
camera.set(cv2.CAP_PROP_FPS, 30.0)
print camera.get(cv2.CAP_PROP_FRAME_WIDTH)
print camera.get(cv2.CAP_PROP_FRAME_HEIGHT)
print camera.get(cv2.CAP_PROP_FPS)
C = camera.get(cv2.CAP_PROP_FOURCC)
print 'fourcc:', decode_fourcc(C)
print
for i in xrange(38):
print i, fourcc_names[i], camera.get(i)
while(1):
camera.grab()
retval, im = camera.retrieve(0)
cv2.imshow("image", im)
k = cv2.waitKey(1) & 0xff
if k == 27:
break
camera.release()
cv2.destroyAllWindows()
```
##### Output
```
3.1.0
Camera open: True
1280.0
720.0
30.00003
fourcc: YUY2
0 CAP_PROP_POS_MSEC -1.0
1 CAP_PROP_POS_FRAMES -1.0
2 CAP_PROP_POS_AVI_RATIO -1.0
3 CAP_PROP_FRAME_WIDTH 1280.0
4 CAP_PROP_FRAME_HEIGHT 720.0
5 CAP_PROP_FPS 30.00003
6 CAP_PROP_FOURCC 844715353.0
7 CAP_PROP_FRAME_COUNT -1.0
8 CAP_PROP_FORMAT -1.0
9 CAP_PROP_MODE -1.0
10 CAP_PROP_BRIGHTNESS 0.0
11 CAP_PROP_CONTRAST 32.0
12 CAP_PROP_SATURATION 64.0
13 CAP_PROP_HUE 0.0
14 CAP_PROP_GAIN 0.0
15 CAP_PROP_EXPOSURE -6.0
16 CAP_PROP_CONVERT_RGB -1.0
17 CAP_PROP_WHITE_BALANCE_BLUE_U 4600.0
18 CAP_PROP_RECTIFICATION -1.0
19 CAP_PROP_MONOCHROME 19.0
20 CAP_PROP_SHARPNESS 3.0
21 CAP_PROP_AUTO_EXPOSURE -1.0
22 CAP_PROP_GAMMA 100.0
23 CAP_PROP_TEMPERATURE -1.0
24 CAP_PROP_TRIGGER -1.0
25 CAP_PROP_TRIGGER_DELAY -1.0
26 CAP_PROP_WHITE_BALANCE_RED_V -1.0
27 CAP_PROP_ZOOM 27.0
28 CAP_PROP_FOCUS 28.0
29 CAP_PROP_GUID -1.0
30 CAP_PROP_ISO_SPEED -1.0
31 CAP_PROP_BACKLIGHT -1.0
32 CAP_PROP_PAN 1.0
33 CAP_PROP_TILT 33.0
34 CAP_PROP_ROLL 34.0
35 CAP_PROP_IRIS 35.0
36 CAP_PROP_SETTINGS 36.0
37 CAP_PROP_BUFFERSIZE -1.0
``` | feature,priority: low,category: videoio(camera),platform: win32 | low | Major |
168,465,163 | angular | Problem when adding dynamically a component with g[test] selector in SVG | **I'm submitting a ...** (check one with "x")
[ x ] bug report
[ ] feature request
[ ] support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question
**Current behavior**
I try to add dynamically this component within SVG:
```
@Component({
selector: 'g[test1]',
template: `
<svg:text x="10" y="15" fill="red">I love SVG!</svg:text>
`
})
export class Test1Comp {
}
```
I use this approach:
```
this.resolver.resolveComponent(Test1Comp).then((factory:ComponentFactory<any>) => {
this.cmpRef = this.viewContainerRef.createComponent(factory);
});
```
Whereas the corresponding content is added to the DOM, it appears that the host element (`g`) isn't a valid SVG element (perhaps the svg namespace isn't used):
```
<g test1> <!-- UnkownHTMLElement-->
<text>...</text> <!-- SVGTextElement -->
</g>
```
This prevents from displaying the SVG elements within the `g` one.
**Expected/desired behavior**
To be able to add dynamically components within SVG with selectors like `g[test1]`.
**Reproduction of the problem**
See this plunkr: http://plnkr.co/edit/6aLGnLNi0svLk4CVS9M2?p=preview.
**What is the expected behavior?**
I expect the added host element to be an `SVGElement` and not an `HTMLUnknownElement`.
**What is the motivation / use case for changing the behavior?**
**Please tell us about your environment:**
- **Angular version:** 2.0.0-rc.4
- **Browser:** [Chrome]
- **Language:** [ TypeScript ]
| type: bug/fix,freq2: medium,area: core,state: confirmed,core: dynamic view creation,cross-cutting: SVG,P3,bug | medium | Critical |
168,495,104 | godot | Improve tool script debugging | I am currently developping a GDScript editor plugin, and just like developping a game, I make mistakes and am getting countless errors, yay!
But the problem here is that I only get the error and the line where it occurred. I am currently spending a lot of time trying to figure out a bug happening everytime I use Ctrl+S that makes the editor hang for 30 seconds (it was 5 minutes when it first occurred!). Because I edit the tool in the editor, it is becoming a PITA to debug. Godot even froze at some point but not a clue what happened.
It would be a great improvement if we could get the call stack of tool script errors, because mine just tells `invalid index in get_value(x,y)`, which can happen in a lot of different ways, so I'm screwed to the point I have to print everywhere (making the test even longer!), erase stuff and wait for a while everytime just to find the culprit code path.
FYI: the bug was caused by https://github.com/godotengine/godot/issues/5984
| enhancement,topic:editor,usability | medium | Critical |
168,506,254 | rust | Test runner interacts badly with redirected child process | (Moved here from rust-lang/cargo/2936 as it is believed to be a standard library bug.)
Consider the code at https://gitlab.com/BartMassey/ptyknot/tree/pipes-direct/misc/piperef-rs . The relevant portion is in piperef.rs:
```
...
// Write "hello world" to stdout.
match write_mode {
WriteMode::Macro => {println!("hello world");},
WriteMode::C => {
let buf = "hello world".as_bytes();
let hello = std::ffi::CString::new(buf).unwrap();
let bufptr = hello.as_ptr() as *const libc::c_void;
check_cint!(libc::write(1, bufptr, buf.len()));
}
}
....
```
This code is run in a child process. When it is invoked by running it after `cargo build`, it works fine regardless of whether Macro or C mode is used. When it is invoked by `cargo test`, C mode works but Macro mode fails with an empty string. When it is invoked by `cargo test -- --nocapture`, both modes work again. Here's a transcript:
```
$ cargo build
Compiling libc v0.2.14
Compiling piperef v0.1.0 (file:///usr/local/src/ptyknot/misc/piperef-rs)
$ target/debug/piperef
$ cargo test
Compiling piperef v0.1.0 (file:///usr/local/src/ptyknot/misc/piperef-rs)
Running target/debug/piperef-80efeb997239b2ac
running 2 tests
test write_macro_test ... FAILED$<2>
test write_c_test ... ok$<2>
failures:
---- write_macro_test stdout ----
thread 'write_macro_test' panicked at 'assertion failed: `(left == right)` (left: `""`, right: `"hello world"`)', piperef.rs:60
note: Run with `RUST_BACKTRACE=1` for a backtrace.
failures:
write_macro_test
test result: FAILED$<2>. 1 passed; 1 failed; 0 ignored; 0 measured
error: test failed
$ cargo test -- --nocapture
Running target/debug/piperef-80efeb997239b2ac
running 2 tests
test write_macro_test ... ok
test write_c_test ... ok
test result: ok. 2 passed; 0 failed; 0 ignored; 0 measured
$
```
It looks like the test runner is fouling up the environment somehow, but I can't figure out how by looking at stuff.
| C-enhancement,A-libtest,A-process | low | Critical |
168,534,134 | bitcoin | Separate resource usage profiles | There has been talk before (and I'm surprised to not find an existing issue about it) of having different memory usage profiles. This could encompass defaults for:
- `-dbcache`
- `-par`
- `-maxsigcachesize`
- `-maxmempool`
- `-maxorphantx`
- `-maxconnections`
- `-maxreceivebuffer`
- `-maxsendbuffer`
For desktop systems, autodetecting could be used to determine optimal settings. For servers, it could be specified on the command line. I have heard about interest in a means for specifying "Just use all the memory I have".
| Feature,Resource usage | low | Minor |
168,534,903 | react | Attach Stack at setState Calls in DEV Mode | We have a queue for state transitions. There is a natural place for a `new Error()` stack frame to be stored there.
We could use this information to work our way back from errors to show information about which `setState` call was the source of the error.
Because of batching, it is not always possible to make the correct attribution. It could be one of several possible sources.
(Specifically I'd like to use this in Fiber when the starvation protection kicks in. We can show which state transition was kept getting deferred due to higher priority work.)
| Type: Enhancement,Component: Core Utilities,React Core Team | low | Critical |
168,536,401 | rust | type_id is not crate-independent with object associated types | ## Meta
```
$ rustc -V
rustc 1.12.0-dev (5556554e2 2016-07-31)
```
## STR
``` Rust
#![feature(core_intrinsics, rustc_private)]
#[cfg(arena_first)]
extern crate arena;
extern crate term;
#[cfg(not(arena_first))]
extern crate arena;
use std::intrinsics::type_id;
fn main() { unsafe {
println!("same={:?} different={:?}",
type_id::<arena::TypedArena<()>>(),
type_id::<Iterator<Item=arena::TypedArena<()>>>()
);
}}
```
Any pair of crates, one of them with a struct, can be used instead of arena/term.
## Expected Result
The Type ID of `Iterator<Item=arena::TypedArena<()>>` should be the same when the cfg is toggled.
## Actual Result
The Type ID of `Iterator<Item=arena::TypedArena<()>>` differs when the cfg is toggled, but the id of `arena::TypedArena<()>` does not
| A-trait-system,E-needs-test,T-compiler,C-bug | low | Major |
168,541,166 | rust | Verify that the AST does not have DUMMY_SP | Currently, syntax extensions can generate code with `DUMMY_SP` in its AST. All compiler diagnostics from that code, and all stack backtraces generated by that code, are basically worthless.
That should not be possible. The lowered HIR should not have any DUMMY_SP.
cc @rust-lang/compiler
| A-debuginfo,C-enhancement,T-compiler,A-proc-macros | low | Major |
168,663,304 | go | fmt: Scanf EOF error inconsistency | Please answer these questions before submitting your issue. Thanks!
_What version of Go are you using (`go version`)?_
`go version devel +ff227b8 Thu Jul 21 01:04:22 2016 +0000 linux/amd64`
but older versions of Go are also affected.
_What operating system and processor architecture are you using (`go env`)?_
``` text
GOARCH="amd64"
GOBIN="/home/fjl/bin"
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/home/fjl/"
GORACE=""
GOROOT="/usr/lib/go"
GOTOOLDIR="/usr/lib/go/pkg/tool/linux_amd64"
CC="gcc"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build153025883=/tmp/go-build -gno-record-gcc-switches"
CXX="g++"
CGO_ENABLED="1"
```
_What did you do?_
I use fmt.Sscanf to parse integers and big integers.
https://play.golang.org/p/aZVlPM7haY
_What did you expect to see?_
When there is not enough input Sscanf (and Fscanf, Scanf) should return io.ErrUnexpectedEOF
_What did you see instead?_
It returns io.ErrUnexpectedEOF for big.Int and io.EOF for uint.
| NeedsFix | low | Critical |
168,743,597 | TypeScript | Suggestion: output fewer errors for incorrectly implemented interface | **TypeScript Version:** nightly
**Code**
``` ts
interface A {
f(): void;
}
class B implements A {
eff() {}
}
var b: B;
b.f();
b.f();
b.f();
```
**Expected behavior:**
```
src/a.ts(4,7): error TS2420: Class 'B' incorrectly implements interface 'A'.
Property 'f' is missing in type 'B'.
```
**Actual behavior:**
```
src/a.ts(4,7): error TS2420: Class 'B' incorrectly implements interface 'A'.
Property 'f' is missing in type 'B'.
src/a.ts(9,3): error TS2339: Property 'f' does not exist on type 'B'.
src/a.ts(10,3): error TS2339: Property 'f' does not exist on type 'B'.
src/a.ts(11,3): error TS2339: Property 'f' does not exist on type 'B'.
```
There can be an overwhelming number of missing-property errors if a commonly-used class mis-implements an interface it declares.
| Suggestion,Help Wanted,Effort: Difficult | low | Critical |
168,838,480 | rust | unsatisfyable HKL error message prints broken bound (`for<'b> 'b : `) | the full error is
```
error[E0279]: the requirement `for<'b> 'b : ` is not satisfied (`expected bound lifetime parameter 'b, found concrete lifetime`)
--> <anon>:2:5
|
2 | test::<FooS>(&mut 42);
| ^^^^^^^^^^^^
|
= note: required because of the requirements on the impl of `for<'b> Foo<'b>` for `FooS<'_>`
= note: required by `test`
```
reproducible example on stable, beta and nightly:
``` rust
fn main() {
test::<FooS>(&mut 42);
}
trait Foo<'a> {}
struct FooS<'a> {
data: &'a mut u32,
}
impl<'a, 'b: 'a> Foo<'b> for FooS<'a> {}
fn test<'a, F>(data: &'a mut u32) where F: for<'b> Foo<'b> {}
```
| A-diagnostics,T-compiler,C-bug | low | Critical |
168,857,681 | opencv | loading 32 bit TIFF requires imread flags to be set | According to the documentation flag `IMREAD_ANYDEPTH`
> If set, return 16-bit/32-bit image when the input has the corresponding depth, otherwise convert it to 8-bit
When reading 32bit TIFF image without any flags the image should load and get converted to 8bit. In practice however image is empty.
When flag `IMREAD_ANYDEPTH` is set the image loads correctly as a 32bit float.
| bug,category: imgcodecs | low | Major |
168,885,234 | TypeScript | Inconsistent DocComment merging for merged declarations | _From @unional on July 14, 2016 7:17_
Likely tsc error?
VSCode: 1.3.1
ts: 2.1.0-dev.20160712
``` ts
/**
* some function
*/
function foo() {}
/**
* some interface
*/
interface foo {}
/**
* some namespace
*/
namespace foo {}
```
It works like this when it is variable:
``` ts
/**
* some variable
*/
let foo: any;
/**
* some interface
*/
interface foo {}
/**
* some namespace
*/
namespace foo {}
```
The highlighting is also wrong for interface, and interface is hidden when hovering variable and namespace.
_Copied from original issue: Microsoft/vscode#9254_
| Bug,Help Wanted,VS Code Tracked | low | Critical |
168,993,826 | electron | Chrome Web Push support | I came across [this previous issue](https://github.com/electron/electron/issues/3095), where it was said that Chrome Push would not be supported at the time since Google's private services are not included in Electron's content bundle. Now that Chrome 52 [supports a non-proprietary protocol](http://blog.chromium.org/2016/06/chrome-52-beta-css-containment-simpler.html), would Electron eventually support web push notifications?
| enhancement :sparkles:,component/chrome-api | high | Critical |
169,000,245 | rust | Tracking issue for future-incompatibility lint `patterns_in_fns_without_body` | Code using patterns in parameters of foreign functions, function pointers or trait methods without body is not accepted by the compiler.
```rs
extern {
fn f((a, b): (u8, u16)); // ERROR
}
type T = fn((a, b): (u8, u16)); // ERROR
trait Tr {
fn f((a, b): (u8, u16)); // ERROR
}
```
Previously some simple patterns like `&ident`, `&&ident` or `mut ident` were allowed in these positions, now they aren't. Such patterns weren't properly type checked, e.g. `type A = fn(&arg: u8);` compiled despite `u8` not being a reference.
#### What are these errors for?
Full patterns don't make sense in functions without bodies, but simple identifiers may be useful for documenting argument purposes even if they aren't actually used - `type Callback = fn(useful_name: u8)`.
By restricting patterns in body-less function signatures to `ident: TYPE` we can make argument names optional and accept simply a `TYPE` in argument position (`type T = fn(u8)`) without introducing parsing ambiguities.
#### How to fix this warning/error
Remove `&` or `mut` from the pattern and make the function parameter a single identifier or `_`.
#### Current status
- [x] https://github.com/rust-lang/rust/pull/35015 made patterns in foreign functions and function pointers hard errors
- [x] https://github.com/rust-lang/rust/pull/37378 made patterns in trait methods without body warn-by-default lints
- [x] https://github.com/rust-lang/rust/pull/45775 made patterns in trait methods without body hard errors, except for `mut IDENT`
- [x] https://github.com/rust-lang/rust/pull/65785 made patterns in trait methods without body deny-by-default lints
- [ ] ? made patterns in trait methods without body hard errors
- [x] https://github.com/rust-lang/rust/issues/78927 provide structured suggestions
| A-lints,T-lang,T-compiler,C-future-incompatibility,C-tracking-issue | low | Critical |
169,015,802 | flutter | determinate circular progress indicators have wrong animation | See: https://material-design.storage.googleapis.com/publish/material_v_8/material_ext_publish/0B14F_FSUCc01N2kzc1hlaFR5WlU/061101_Circular_Sheet_xhdpi_005.webm
| framework,f: material design,P2,team-design,triaged-design | low | Minor |
169,015,985 | flutter | Improve transition from indeterminate to determinate circular progress indicators | We should transition cleanly. Right now we just switch modes with a sudden change.
| framework,f: material design,a: quality,has reproducible steps,P2,found in release: 3.7,found in release: 3.9,team-design,triaged-design | low | Minor |
169,027,689 | go | x/net/http2: rename and export Transport's t1 field | Please answer these questions before submitting your issue. Thanks!
1. What version of Go are you using (`go version`)?
go version go1.7rc4 darwin/amd64
2. What operating system and processor architecture are you using (`go env`)?
GOARCH="amd64"
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
3. What did you do?
Directly use an `http2.Transport` to set its `AllowHTTP` field to true, to enable HTTP/2 over HTTP (and set DialTLS accordingly, as mentioned here: https://github.com/golang/go/issues/14141#issuecomment-219212895).
4. What did you expect to see?
Have access to the same rich set of configuration options as are available on `http.Transport`.
5. What did you see instead?
Many configuration options from `http.Transport` are not available on `http2.Transport` (e.g. controlling idle connections in the ClientConnPool).
As discussed on golang-dev mailing list (https://groups.google.com/forum/#!topic/golang-dev/HmqDsLpTywk), as it currently stands, if we have to directly use the `http2.Transport`, we have to give up on a number of configuration options that are present only on `http.Transport`. @bradfitz suggested to rename and export the `http2.Transport.t1` field to fix this.
| NeedsFix | low | Major |
169,059,888 | youtube-dl | count of videos when giving playlist-start should number downloads starting from given number | ### Make sure you are using the _latest_ version: run `youtube-dl --version` and ensure your version is _2016.08.01_. If it's not read [this FAQ entry](https://github.com/rg3/youtube-dl/blob/master/README.md#how-do-i-update-youtube-dl) and update. Issues with outdated version will be rejected.
- [x] I've **verified** and **I assure** that I'm running youtube-dl **2016.02.22**
### Before submitting an _issue_ make sure you have:
- [x] At least skimmed through [README](https://github.com/rg3/youtube-dl/blob/master/README.md) and **most notably** [FAQ](https://github.com/rg3/youtube-dl#faq) and [BUGS](https://github.com/rg3/youtube-dl#bugs) sections
- [x] [Searched](https://github.com/rg3/youtube-dl/search?type=Issues) the bugtracker for similar issues including closed ones
### What is the purpose of your _issue_?
- [x] Feature request (request for a new functionality)
---
### Description of your _issue_, suggested solution and other information
When I start a download from a particular --playlist-start value (say --playlist-start 15), the numbering shown is like "downloading 1 of 70". It would help to have it also display the added value (like downloading 15 of 84, 16 of 84, etc.). If the download breaks or has to be restarted from a point, we know what number to give next.
| request | low | Critical |
169,072,431 | vscode | Git - Support git-bash ssh agent for Windows | cc @saggafarsyad
From #6202
| help wanted,feature-request,git | medium | Major |
169,215,074 | javascript | The use of || operator in assignments | In the topic 15.7 this kind of assignment is favored over ternaries: `const foo = a || b;`. Actually, this pattern is used in a lot of the examples, but should it be discouraged since it can produce undesired behavior when the left operand is falsy? In the above example if `a` is falsy so `b` would be the result.
I know the developer should distinguish problematic cases, but one of the goals of the style guide is to avoid potential issues.
| question | low | Major |
169,232,831 | kubernetes | Bulk deletes are resource intensive on caches. | We have a series of tests that fill a cluster, settle, then bulk delete using namespaces.
This bulk delete is very memory intensive and expensive on the api-server. The profile of the operation shows a large spike in memory, which is likely due to how we cache.
By contrast etcd profile looks like:
If there are overlapping bulk operations on larger clusters, this could be very expensive.
A good example would be bulk job creation and cleanup (e.g. builds).
/cc @kubernetes/sig-scalability @smarterclayton @deads2k
| sig/scalability,area/apiserver,sig/api-machinery,lifecycle/frozen | medium | Major |
169,290,787 | kubernetes | Add support for custom stop signal to send to containers | Docker added STOPSIGNAL to let container images change which signal is delivered to kill the container. Should we support that? It would be bad if an image expected SIGUSR1 and we sent SIGTERM.
They support ints or strings. I think we should only support strings.
| area/kubelet,area/api,sig/node,kind/feature,lifecycle/frozen,area/pod-lifecycle | medium | Critical |
169,308,831 | TypeScript | Formatter fails to format uglified files | <!-- BUGS: Please use this template. -->
<!-- QUESTIONS: This is not a general support forum! Ask Qs at http://stackoverflow.com/questions/tagged/typescript -->
<!-- SUGGESTIONS: See https://github.com/Microsoft/TypeScript-wiki/blob/master/Writing-Good-Design-Proposals.md -->
**TypeScript Version:** 1.8.10
I use vscode from the Command Palette to format a javascript file uglified by uglify-js, but it failed. It not format code correctly, and only format partially.
**source file**
**sublime jsFormat formated**
**vscode formated**
You see, It seems like, vscode only add some spaces around brackets, letters, commas etc.
See https://github.com/Microsoft/vscode/issues/8914#issuecomment-231978337 and the discussion below for more details. The provided traces clearly show that the tsserver only returns white space (" ") changes. No insertion of new lines.
| Suggestion,Help Wanted,Domain: Formatter,VS Code Tracked | low | Critical |
169,336,063 | go | x/tools/cmd/goimports: can't find proto packages | Please answer these questions before submitting your issue. Thanks!
1. What version of Go are you using (`go version`)?
`go version go1.6.2 darwin/amd64`
1. What operating system and processor architecture are you using (`go env`)?
```
GOARCH="amd64"
GOBIN=""
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
GOPATH="/Users/danielchatfield"
GORACE=""
GOROOT="/usr/local/Cellar/go/1.6.2/libexec"
GOTOOLDIR="/usr/local/Cellar/go/1.6.2/libexec/pkg/tool/darwin_amd64"
GO15VENDOREXPERIMENT="1"
CC="clang"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fno-common"
CXX="clang++"
CGO_ENABLED="1"
```
Package `fooproto` in `github.com/danielchatfield/repo/foo/proto`
Running `goimports` on the following fails to find the import.
```
package main
func main() {
_ := &fooproto.SomeStruct{}
}
```
The first commit that broke this is `https://github.com/golang/tools/commit/e047ae774b027ae958a270598c5ac2591e457afc`
| NeedsInvestigation | low | Major |
169,423,227 | kubernetes | Storage should not allow multiple users of a PVclaim, if the claim is RWO, even if the PV is RWX | This is hard to validate, but it is a bug. We need to clarify the meaning of a claim's mode. Today it means "at least" but I think we also need to express "this pod demands exclusive access" vs "shared access is OK". That is more of an app-level semantic than infrastructure.
Concretely, assume my app needs a RWO volume. I get bound to an NFS share that is RWX (which is "greater than" RWO). My app _does not_ tolerate multiple writers to the volume. It is possible to schedule another pod against the claim, and have it succeed since the PV is RWX underneath. Now my app is corrupted.
This pattern could maybe apply to RWO PVs, too, if the pods land on the same machine, but that is a more subtle discussion.
| priority/important-soon,area/kubelet,sig/storage,lifecycle/frozen | low | Critical |
169,436,644 | youtube-dl | Introduce compatible-merge operators for format selection (was: Need a bestvideo+bestcompatibleaudio format selector) | ### I have
- [x] **Verified** and **I assure** that I'm running youtube-dl **2016.08.01**
- [x] At least skimmed through [README](https://github.com/rg3/youtube-dl/blob/master/README.md) and **most notably** [FAQ](https://github.com/rg3/youtube-dl#faq) and [BUGS](https://github.com/rg3/youtube-dl#bugs) sections
- [x] [Searched](https://github.com/rg3/youtube-dl/search?type=Issues) the bugtracker for similar issues including closed ones
### The purpose of this _issue_
- [ ] Bug report (encountered problems with youtube-dl)
- [ ] Site support request (request for adding support for a new site)
- [x] Feature request (request for a new functionality)
- [ ] Question
- [ ] Other
### Description
This request follows [this question](https://github.com/rg3/youtube-dl/issues/10221).
I need something like **`-f bestvideo+bestcompatibleaudio`**, where `'bestcompatibleaudio'` is the selector for the best audio file which is compatible with the desired video file (so that the files don't need to be muxed into an mkv.) Or, if you all find this cool, maybe even `'worstcompatibleaudio'`
_Until it is implemented, anyone who is in dire need of this feature can use this [script](https://gist.github.com/Daemonster/4c94372a85cd4b5ea86df06e102a19e7)._
| request | medium | Critical |
169,489,569 | flutter | Dropdown button menu is not repositioned after rotating the screen | 1) Run Gallery -> Buttons -> Dropdown
2) Tap on one of the dropdown buttons to show the popup menu
3) Rotate the screen
The popup menu will remain at the same coordinates it had before the rotation (and it may be offscreen). It should be moved to match the position of the dropdown button in the new layout.
| framework,f: material design,a: fidelity,P3,team-design,triaged-design | low | Minor |
169,636,045 | angular | feat(Forms) Expose FormControl errors to parent FormGroup | **I'm submitting a ...** (check one with "x")
```
[ ] bug report
[x feature request
[ ] support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question
```
**Current behavior**
When there are errors in a form group, the formGroup.status is 'INVALID' but the formGroup.errors property is null.
ex.
```
formGroup.controls.username.errors: {invalidEmail: true}
formGroup.errors: null
```
**Expected/desired behavior**
When the validity of a FormControl changes, have the parent FormGroup.errors merged with the errors from the controls. This is similar to how the angularjs formController.$error property works.
https://docs.angularjs.org/api/ng/type/form.FormController
**What is the motivation / use case for changing the behavior?**
This would be helpful because I prefer to only disable a submit button when specific errors are on a form, such as required. With this I could drive that attribute off the formControl.errors value instead of formControl.status.
ex.
```
From:
<button [disabled]="myForm.status !== 'VALID'">Submit</button>
To:
<button [disabled]="myForm.errors.required">Submit</button>
```
| feature,state: Needs Design,freq3: high,area: forms,feature: under consideration | high | Critical |
169,650,181 | go | runtime/trace: implement user events | https://golang.org/s/go15trace specifies user events:
> Runtime/pprof package also exposes a set of functions for emission of user events:
>
> ```
> package pprof
> func TraceEvent(id string)
> func TraceScopeStart(id string)
> func TraceScopeEnd(id string)
> ```
But there is no implementation at this time.
Those would be invaluable to properly debug latency problems.
(According to @dvyukov there is no one actively working on it, so I might give it a try.)
| help wanted,NeedsFix,early-in-cycle | medium | Critical |
169,652,986 | go | proposal: sync: mechanism to select on condition variables | Sometimes condition variables are the best fit for a problem, and sometimes channels are. They don't compose well, though.
I've increasingly been finding myself in a position where I would like to select on both channel(s) and a condition variable. This has come up a few times in http2, where I use condition variables for flow control, but there are plenty of channels (including the net/http.Request.Cancel channel) in play too. Sometimes I need to both wait for flow control, or wait for a user to cancel their request, or the peer side to close their connection, etc.
I would love to be able to select on a condition variable, like if the `sync.Cond` type had a method:
``` go
// WaitChan returns a channel which receives a value when awoken
// by Broadcast or Signal. Unlike Wait, WaitChan does not unlock
// or lock the c.L mutex.
func (c *Cond) WaitChan() <-chan struct{} {
// ....
}
```
The semantics would be the receiving from it acts like a `runtime_Syncsemacquire` on `c.sema`. We'd need to define what happens if another case in the select fires first. (does the semacquire get canceled?).
Thoughts?
| Proposal | high | Critical |
169,696,164 | awesome | More non-{tech,science} awesome lists please! | There are so many interesting topics in this world. Let's not limit ourselves to just tech and science!
I think the only non-{tech,science} list we have here is the [Economics](https://github.com/antontarasenko/awesome-economics) list.
Examples:
- [Life hacks](https://en.wikipedia.org/wiki/Life_hack)
- Skateboarding
- [Yarn bombing](https://en.wikipedia.org/wiki/Yarn_bombing)
- Pony grooming
- Cooking
- ...
**Please share more ideas!**
##
[Click here to get started creating a list.](https://github.com/sindresorhus/awesome/blob/master/create-list.md)
| list request | high | Critical |
169,700,944 | go | cmd/cgo: arrange to pass unmodified Go source files to compiler, go/types | Currently cgo support is implemented with cmd/cgo as a separate tool that analyzes cgo-using Go code and transforms it into standard Go code. This proposal is to extract the analysis logic into a separate internal package that can be reused by cmd/compile and go/types directly without needing source rewrites. I.e., turn them into native cgo compilers, rather than needing a separate "cgofront" preprocessor step.
The expected benefits are:
1. Better error messages. E.g., currently cmd/compile emits error messages about calls to _Cfunc_foo instead of C.foo.
2. Better position information. Currently when using golang.org/x/tools/go/loader to analyze cgo-using source, the column location and byte offset information is wrong because it applies go/types to the post-transformation Go source files. Thanks to //line directives, we can at least identify the original line number, but it's troublesome/imprecise to write type-sensitive refactoring tools that rely on column information and want to support cgo-using packages.
3. Better desugaring of cgo calls. Currently cmd/cgo needs to rewrite expressions into valid Go code to be accepted by cmd/compile, which is sometimes subtle (e.g., #7757, #9557, #13635, #13930, #16591). By desugaring within the compiler itself, we have more flexibility about the sorts of fundamental operations we can use.
Potential downsides and counter-arguments:
1. cmd/cgo still needs to exist for gccgo, but cmd/cgo already has substantially different behavior for supporting cmd/compile vs gccgo.
2. Might complicate #15681 (scheduling cmd/cgo earlier), but I expect an alternative strategy is equally viable: schedule the C compilations later. Currently the only reason we need to schedule the C compilations before the Go compiler is to produce _cgo_imports.go. But this file only contains //go:cgo_import_dynamic and //go:cgo_dynamic_linker directives, which don't actually affect Go compilation; cmd/compile just writes them back out again so cmd/link can ultimately handle them.
3. Increases coupling between cmd/compile and cgo, but cmd/compile already is / needs to be cgo-aware, and cmd/go already has extensive special case code for cmd/cgo (unlike any other tool that generates Go source).
Alternative ideas that might achieve similar benefits while generalizing to tools other than cmd/cgo:
1. Add a //go:errorname directive so cmd/cgo can express that _Cfunc_foo should be referred to as "C.foo" in error messages. It's not obvious this would generalize fully though; e.g., cmd/yacc rewrites $1 to yyDollar[1], which would need something more powerful to express.
2. Generalize //line directives to something that records column/offset information too (similar to JavaScript Source Maps). Again, I'm not sure how useful in practice this would actually be for tools other than cmd/cgo.
/cc @ianlancetaylor @alandonovan @griesemer
| Proposal-Accepted | high | Critical |
169,730,382 | neovim | Exiting :terminal kills split | - `nvim --version`: 0.1.4
- Vim (version: ) behaves differently?
- Operating system/version: OSX 10.11.6
- Terminal name/version: iTerm 2 Build 3.0.5
- `$TERM`: xterm-256color
### Actual behaviour
Start: Run Neovim in a vertical split, with a file on each side.
Next: Start a terminal session in the left split.
Next: End that terminal session.
Result: The left split gets closed along with the terminal session.
### Expected behaviour
Start: Run Neovim in a vertical split, with a file on each side.
Next: Start a terminal session in the left split.
Next: End that terminal session.
Result: The left split stays in-tact, with the previous file back in focus.
This is something that happens normally when closing out of a terminal session in a single window environment, ex:
### Steps to reproduce using `nvim -u NORC`
```
nvim -u NORC
Same as above (happens without plugins enabled)
```
| terminal | medium | Critical |
169,744,867 | youtube-dl | Request: introduce new field `short_description` | Many a supported site often has both a short description and a longer. Introducing a new field `short_description` (or a similar name), would allow for both to be extracted.
| request | low | Minor |
169,747,160 | TypeScript | Provide a way to alias namespaces | TypeScript should have a way to embed (type) namespaces. In the following case, assigned (embeded) namespace NS.A should have a C type.
**TypeScript Version:** master
**Code**
``` ts
namespace NS_A {
export class C {
}
}
namespace NS {
export var A = NS_A;
export type A = NS_A;
}
var C = NS.A.C;
type C = NS.A.C;
```
**Expected behavior:**
```
$ node built/local/tsc.js --lib es6 -m commonjs --noEmit index.ts
```
**Actual behavior:**
```
$ node built/local/tsc.js --lib es6 -m commonjs --noEmit index.ts
index.ts(7,19): error TS2304: Cannot find name 'NS_A'.
index.ts(10,13): error TS2305: Module 'NS' has no exported member 'A'.
```
| Suggestion,Needs More Info | medium | Critical |
169,762,151 | rust | Add `is_empty` function to `ExactSizeIterator` | Tracking issue for functionality introduced in https://github.com/rust-lang/rust/pull/34357
| T-libs-api,B-unstable,C-tracking-issue,A-iterators,Libs-Tracked | high | Critical |
169,807,578 | youtube-dl | Add support for Voot.com | ### Make sure you are using the _latest_ version: run `youtube-dl --version` and ensure your version is _2016.08.07_. If it's not read [this FAQ entry](https://github.com/rg3/youtube-dl/blob/master/README.md#how-do-i-update-youtube-dl) and update. Issues with outdated version will be rejected.
- [x] I've **verified** and **I assure** that I'm running youtube-dl **2016.08.07**
### Before submitting an _issue_ make sure you have:
- [x] At least skimmed through [README](https://github.com/rg3/youtube-dl/blob/master/README.md) and **most notably** [FAQ](https://github.com/rg3/youtube-dl#faq) and [BUGS](https://github.com/rg3/youtube-dl#bugs) sections
- [x] [Searched](https://github.com/rg3/youtube-dl/search?type=Issues) the bugtracker for similar issues including closed ones
### What is the purpose of your _issue_?
- [ ] Bug report (encountered problems with youtube-dl)
- [x] Site support request (request for adding support for a new site)
- [ ] Feature request (request for a new functionality)
- [ ] Question
- [ ] Other
---
### If the purpose of this _issue_ is a _site support request_ please provide all kinds of example URLs support for which should be included (replace following example URLs by **yours**):
- Single video: http://www.voot.com/shows/splitsvilla-s09/9/411756/rajnandini-to-settle-scores-with-martina-/434441
- Playlist: http://www.voot.com/shows/splitsvilla-s09/9/411756
---
Georestrictd to IN.
| site-support-request,geo-restricted | low | Critical |
169,856,870 | youtube-dl | Not downloading all videos from a Vimeo channel | ### Make sure you are using the _latest_ version: run `youtube-dl --version` and ensure your version is _2016.08.07_. If it's not read [this FAQ entry](https://github.com/rg3/youtube-dl/blob/master/README.md#how-do-i-update-youtube-dl) and update. Issues with outdated version will be rejected.
- [x] I've **verified** and **I assure** that I'm running youtube-dl **2016.08.07**
### Before submitting an _issue_ make sure you have:
- [x] At least skimmed through [README](https://github.com/rg3/youtube-dl/blob/master/README.md) and **most notably** [FAQ](https://github.com/rg3/youtube-dl#faq) and [BUGS](https://github.com/rg3/youtube-dl#bugs) sections
- [x] [Searched](https://github.com/rg3/youtube-dl/search?type=Issues) the bugtracker for similar issues including closed ones
### What is the purpose of your _issue_?
- [ ] Bug report (encountered problems with youtube-dl)
- [x] Site support request (request for adding support for a new site)
- [ ] Feature request (request for a new functionality)
- [ ] Question
- [ ] Other
---
### The following sections concretize particular purposed issues, you can erase any section (the contents between triple ---) not applicable to your _issue_
---
### If the purpose of this _issue_ is a _bug report_, _site support request_ or you are not completely sure provide the full verbose output as follows:
Add `-v` flag to **your command line** you run youtube-dl with, copy the **whole** output and insert it here. It should look similar to one below (replace it with **your** log inserted between triple ```):
```
$ youtube-dl -v https://vimeo.com/channels/1098614/
[debug] System config: []
[debug] User config: []
[debug] Command-line args: [u'-v', u'https://vimeo.com/channels/1098614/']
[debug] Encodings: locale UTF-8, fs utf-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2016.08.07
[debug] Python version 2.7.10 - Darwin-15.6.0-x86_64-i386-64bit
[debug] exe versions: none
[debug] Proxy map: {}
[vimeo:channel] 1098614: Downloading page 1
[download] Downloading playlist: Monitorama PDX 2016 - Portland, OR
[vimeo:channel] 1098614: Downloading page 2
[vimeo:channel] 1098614: Downloading page 3
[vimeo:channel] playlist Monitorama PDX 2016 - Portland, OR: Downloading 29 videos
[download] Downloading video 1 of 29
[vimeo] 1098614: Downloading webpage
[vimeo] 1098614: Extracting information
[vimeo] 1098614: Downloading webpage
[vimeo] 1098614: Downloading JSON metadata
[vimeo] 1098614: Downloading m3u8 information
[debug] Invoking downloader on u'https://fpdl.vimeocdn.com/vimeo-prod-skyfire-std-us/01/4721/6/173609948/561655526.mp4?token=57a871ba_0x99f9f77cb10076d805607e88cdccc9d649bb22c5'
[download] Monitorama PDX 2016 - Adrian Cockcroft - Monitoring Challenges-1098614.mp4 has already been downloaded
[download] 100% of 546.51MiB
[download] Downloading video 2 of 29
[vimeo] 1098614: Downloading webpage
[vimeo] 1098614: Extracting information
[vimeo] 1098614: Downloading webpage
[vimeo] 1098614: Downloading JSON metadata
[vimeo] 1098614: Downloading m3u8 information
[debug] Invoking downloader on u'https://fpdl.vimeocdn.com/vimeo-prod-skyfire-std-us/01/4721/6/173609948/561655526.mp4?token=57a871bc_0x5f835f1f1187425673da32df1fb508de234d9e35'
[download] Monitorama PDX 2016 - Adrian Cockcroft - Monitoring Challenges-1098614.mp4 has already been downloaded
[download] 100% of 546.51MiB
[download] Downloading video 3 of 29
[vimeo] 1098614: Downloading webpage
[vimeo] 1098614: Extracting information
[vimeo] 1098614: Downloading webpage
[vimeo] 1098614: Downloading JSON metadata
[vimeo] 1098614: Downloading m3u8 information
[debug] Invoking downloader on u'https://fpdl.vimeocdn.com/vimeo-prod-skyfire-std-us/01/4721/6/173609948/561655526.mp4?token=57a871bf_0x2a185045b6ccfeb4d03b41c2dacf5d2dff868eab'
[download] Monitorama PDX 2016 - Adrian Cockcroft - Monitoring Challenges-1098614.mp4 has already been downloaded
[download] 100% of 546.51MiB
[download] Downloading video 4 of 29
[vimeo] 1098614: Downloading webpage
[vimeo] 1098614: Extracting information
[vimeo] 1098614: Downloading webpage
[vimeo] 1098614: Downloading JSON metadata
[vimeo] 1098614: Downloading m3u8 information
[debug] Invoking downloader on u'https://fpdl.vimeocdn.com/vimeo-prod-skyfire-std-us/01/4721/6/173609948/561655526.mp4?token=57a871c2_0xe26ae01dfe27cf98e214608193aa71c6596141db'
[download] Monitorama PDX 2016 - Adrian Cockcroft - Monitoring Challenges-1098614.mp4 has already been downloaded
[download] 100% of 546.51MiB
[download] Downloading video 5 of 29
[vimeo] 1098614: Downloading webpage
[vimeo] 1098614: Extracting information
[vimeo] 1098614: Downloading webpage
[vimeo] 1098614: Downloading JSON metadata
[vimeo] 1098614: Downloading m3u8 information
[debug] Invoking downloader on u'https://fpdl.vimeocdn.com/vimeo-prod-skyfire-std-us/01/4721/6/173609948/561655526.mp4?token=57a871c4_0x01e71c479d0e39f8c5707cc7c4840f377e07c340'
[download] Monitorama PDX 2016 - Adrian Cockcroft - Monitoring Challenges-1098614.mp4 has already been downloaded
[download] 100% of 546.51MiB
[download] Downloading video 6 of 29
[vimeo] 1098614: Downloading webpage
[vimeo] 1098614: Extracting information
[vimeo] 1098614: Downloading webpage
[vimeo] 1098614: Downloading JSON metadata
[vimeo] 1098614: Downloading m3u8 information
[debug] Invoking downloader on u'https://fpdl.vimeocdn.com/vimeo-prod-skyfire-std-us/01/4721/6/173609989/561561068.mp4?token=57a85f9f_0xb5d59997083816fbaca6bbedd59ddb480f63a140'
[download] Monitorama PDX 2016 - Brian Smith - The Art of Performance Monitoring-1098614.mp4 has already been downloaded
[download] 100% of 366.15MiB
[download] Downloading video 7 of 29
[vimeo] 1098614: Downloading webpage
[vimeo] 1098614: Extracting information
[vimeo] 1098614: Downloading webpage
[vimeo] 1098614: Downloading JSON metadata
[vimeo] 1098614: Downloading m3u8 information
[debug] Invoking downloader on u'https://fpdl.vimeocdn.com/vimeo-prod-skyfire-std-us/01/4721/6/173609989/561561068.mp4?token=57a85fa2_0x5307f00be2124eb6bbd12507e44706fe7842531d'
[download] Monitorama PDX 2016 - Brian Smith - The Art of Performance Monitoring-1098614.mp4 has already been downloaded
[download] 100% of 366.15MiB
[download] Downloading video 8 of 29
[vimeo] 1098614: Downloading webpage
[vimeo] 1098614: Extracting information
[vimeo] 1098614: Downloading webpage
[vimeo] 1098614: Downloading JSON metadata
[vimeo] 1098614: Downloading m3u8 information
[debug] Invoking downloader on u'https://fpdl.vimeocdn.com/vimeo-prod-skyfire-std-us/01/4721/6/173609989/561561068.mp4?token=57a85fa5_0xd753e61e8d6f56c793dab4c6560acab2fa190351'
[download] Monitorama PDX 2016 - Brian Smith - The Art of Performance Monitoring-1098614.mp4 has already been downloaded
[download] 100% of 366.15MiB
[download] Downloading video 9 of 29
[vimeo] 1098614: Downloading webpage
[vimeo] 1098614: Extracting information
[vimeo] 1098614: Downloading webpage
[vimeo] 1098614: Downloading JSON metadata
[vimeo] 1098614: Downloading m3u8 information
[debug] Invoking downloader on u'https://fpdl.vimeocdn.com/vimeo-prod-skyfire-std-us/01/4721/6/173609989/561561068.mp4?token=57a85fa7_0x75a77e18460710a25acb686ca0dce644785a6afe'
[download] Monitorama PDX 2016 - Brian Smith - The Art of Performance Monitoring-1098614.mp4 has already been downloaded
[download] 100% of 366.15MiB
[download] Downloading video 10 of 29
[vimeo] 1098614: Downloading webpage
[vimeo] 1098614: Extracting information
[vimeo] 1098614: Downloading webpage
[vimeo] 1098614: Downloading JSON metadata
[vimeo] 1098614: Downloading m3u8 information
[debug] Invoking downloader on u'https://fpdl.vimeocdn.com/vimeo-prod-skyfire-std-us/01/4721/6/173609989/561561068.mp4?token=57a85faa_0x93336e023f41e1ecabe5fde8487e25930e13be88'
[download] Monitorama PDX 2016 - Brian Smith - The Art of Performance Monitoring-1098614.mp4 has already been downloaded
[download] 100% of 366.15MiB
[download] Downloading video 11 of 29
[vimeo] 1098614: Downloading webpage
[vimeo] 1098614: Extracting information
[vimeo] 1098614: Downloading webpage
[vimeo] 1098614: Downloading JSON metadata
[vimeo] 1098614: Downloading m3u8 information
[debug] Invoking downloader on u'https://fpdl.vimeocdn.com/vimeo-prod-skyfire-std-us/01/4740/6/173704315/561723680.mp4?token=57a86535_0x8a4b71292f5cebf414ff2ce7a3f5713ff7680b72'
[download] Monitorama PDX 2016 - Brian Overstreet - Scaling Pinterestβs Monitoring System-1098614.mp4 has already been downloaded
[download] 100% of 371.76MiB
[download] Downloading video 12 of 29
[vimeo] 1098614: Downloading webpage
[vimeo] 1098614: Extracting information
[vimeo] 1098614: Downloading webpage
[vimeo] 1098614: Downloading JSON metadata
[vimeo] 1098614: Downloading m3u8 information
[debug] Invoking downloader on u'https://fpdl.vimeocdn.com/vimeo-prod-skyfire-std-us/01/4740/6/173704315/561723680.mp4?token=57a86539_0x87c4d8e1047a9a86d5a75de29e606de4ad903771'
[download] Monitorama PDX 2016 - Brian Overstreet - Scaling Pinterestβs Monitoring System-1098614.mp4 has already been downloaded
[download] 100% of 371.76MiB
[download] Downloading video 13 of 29
[vimeo] 1098614: Downloading webpage
[vimeo] 1098614: Extracting information
[vimeo] 1098614: Downloading webpage
[vimeo] 1098614: Downloading JSON metadata
[vimeo] 1098614: Downloading m3u8 information
[debug] Invoking downloader on u'https://fpdl.vimeocdn.com/vimeo-prod-skyfire-std-us/01/4740/6/173704315/561723680.mp4?token=57a8653d_0xf2d9a23d8307f4766e6a2a8084ca2710d98f4498'
[download] Monitorama PDX 2016 - Brian Overstreet - Scaling Pinterestβs Monitoring System-1098614.mp4 has already been downloaded
[download] 100% of 371.76MiB
[download] Downloading video 14 of 29
[vimeo] 1098614: Downloading webpage
[vimeo] 1098614: Extracting information
[vimeo] 1098614: Downloading webpage
[vimeo] 1098614: Downloading JSON metadata
[vimeo] 1098614: Downloading m3u8 information
[debug] Invoking downloader on u'https://fpdl.vimeocdn.com/vimeo-prod-skyfire-std-us/01/4740/6/173704315/561723680.mp4?token=57a8653f_0x922e2df6122162deb1d916126e78fd01c6c1f584'
[download] Monitorama PDX 2016 - Brian Overstreet - Scaling Pinterestβs Monitoring System-1098614.mp4 has already been downloaded
[download] 100% of 371.76MiB
[download] Downloading video 15 of 29
[vimeo] 1098614: Downloading webpage
[vimeo] 1098614: Extracting information
[vimeo] 1098614: Downloading webpage
[vimeo] 1098614: Downloading JSON metadata
[vimeo] 1098614: Downloading m3u8 information
[debug] Invoking downloader on u'https://fpdl.vimeocdn.com/vimeo-prod-skyfire-std-us/01/4740/6/173704315/561723680.mp4?token=57a86542_0x72e7d7dc3f7089b7903956dd0871923687a7eedd'
[download] Monitorama PDX 2016 - Brian Overstreet - Scaling Pinterestβs Monitoring System-1098614.mp4 has already been downloaded
[download] 100% of 371.76MiB
[download] Downloading video 16 of 29
[vimeo] 1098614: Downloading webpage
[vimeo] 1098614: Extracting information
[vimeo] 1098614: Downloading webpage
[vimeo] 1098614: Downloading JSON metadata
[vimeo] 1098614: Downloading m3u8 information
[debug] Invoking downloader on u'https://fpdl.vimeocdn.com/vimeo-prod-skyfire-std-us/01/4722/6/173610048/561618083.mp4?token=57a867dd_0xacc08d5530febc3cc2513c179b131ae01ad3edff'
[download] Monitorama PDX 2016 - Dave Josephsen - 5 Lines I Couldn't Draw-1098614.mp4 has already been downloaded
[download] 100% of 442.25MiB
[download] Downloading video 17 of 29
[vimeo] 1098614: Downloading webpage
[vimeo] 1098614: Extracting information
[vimeo] 1098614: Downloading webpage
[vimeo] 1098614: Downloading JSON metadata
[vimeo] 1098614: Downloading m3u8 information
[debug] Invoking downloader on u'https://fpdl.vimeocdn.com/vimeo-prod-skyfire-std-us/01/4722/6/173610048/561618083.mp4?token=57a867e0_0x14ea1d23f7505fb6323968e3875cb88fbee9fb37'
[download] Monitorama PDX 2016 - Dave Josephsen - 5 Lines I Couldn't Draw-1098614.mp4 has already been downloaded
[download] 100% of 442.25MiB
[download] Downloading video 18 of 29
[vimeo] 1098614: Downloading webpage
[vimeo] 1098614: Extracting information
[vimeo] 1098614: Downloading webpage
[vimeo] 1098614: Downloading JSON metadata
[vimeo] 1098614: Downloading m3u8 information
[debug] Invoking downloader on u'https://fpdl.vimeocdn.com/vimeo-prod-skyfire-std-us/01/4722/6/173610048/561618083.mp4?token=57a867e2_0x3069d804355da536947d1caf22c9c71a56063530'
[download] Monitorama PDX 2016 - Dave Josephsen - 5 Lines I Couldn't Draw-1098614.mp4 has already been downloaded
[download] 100% of 442.25MiB
[download] Downloading video 19 of 29
[vimeo] 1098614: Downloading webpage
[vimeo] 1098614: Extracting information
[vimeo] 1098614: Downloading webpage
[vimeo] 1098614: Downloading JSON metadata
[vimeo] 1098614: Downloading m3u8 information
[debug] Invoking downloader on u'https://fpdl.vimeocdn.com/vimeo-prod-skyfire-std-us/01/4722/6/173610048/561618083.mp4?token=57a867e5_0x023fdf4701d2d75c921921f6a4ad231b79ad47db'
[download] Monitorama PDX 2016 - Dave Josephsen - 5 Lines I Couldn't Draw-1098614.mp4 has already been downloaded
[download] 100% of 442.25MiB
[download] Downloading video 20 of 29
[vimeo] 1098614: Downloading webpage
[vimeo] 1098614: Extracting information
[vimeo] 1098614: Downloading webpage
[vimeo] 1098614: Downloading JSON metadata
[vimeo] 1098614: Downloading m3u8 information
[debug] Invoking downloader on u'https://fpdl.vimeocdn.com/vimeo-prod-skyfire-std-us/01/4722/6/173610048/561618083.mp4?token=57a867e7_0xf92322cca7acd23f4a8542e76d3a31af44df40a1'
[download] Monitorama PDX 2016 - Dave Josephsen - 5 Lines I Couldn't Draw-1098614.mp4 has already been downloaded
[download] 100% of 442.25MiB
[download] Downloading video 21 of 29
[vimeo] 1098614: Downloading webpage
[vimeo] 1098614: Extracting information
[vimeo] 1098614: Downloading webpage
[vimeo] 1098614: Downloading JSON metadata
[vimeo] 1098614: Downloading m3u8 information
[debug] Invoking downloader on u'https://fpdl.vimeocdn.com/vimeo-prod-skyfire-std-us/01/4740/6/173704322/561738544.mp4?token=57a86be2_0xd2bcdd3276642fff73b59ed6492c93f89799761e'
[download] Monitorama PDX 2016 - Brian Brazil - Prometheus-1098614.mp4 has already been downloaded
[download] 100% of 480.14MiB
[download] Downloading video 22 of 29
[vimeo] 1098614: Downloading webpage
[vimeo] 1098614: Extracting information
[vimeo] 1098614: Downloading webpage
[vimeo] 1098614: Downloading JSON metadata
[vimeo] 1098614: Downloading m3u8 information
[debug] Invoking downloader on u'https://fpdl.vimeocdn.com/vimeo-prod-skyfire-std-us/01/4740/6/173704322/561738544.mp4?token=57a86be5_0x648bea2efb79b4527371e888a8274f27e7853aa4'
[download] Monitorama PDX 2016 - Brian Brazil - Prometheus-1098614.mp4 has already been downloaded
[download] 100% of 480.14MiB
[download] Downloading video 23 of 29
[vimeo] 1098614: Downloading webpage
[vimeo] 1098614: Extracting information
[vimeo] 1098614: Downloading webpage
[vimeo] 1098614: Downloading JSON metadata
[vimeo] 1098614: Downloading m3u8 information
[debug] Invoking downloader on u'https://fpdl.vimeocdn.com/vimeo-prod-skyfire-std-us/01/4740/6/173704322/561738544.mp4?token=57a86be8_0x9ac509e199e61610566fd77f2f3484a3c3bb5765'
[download] Monitorama PDX 2016 - Brian Brazil - Prometheus-1098614.mp4 has already been downloaded
[download] 100% of 480.14MiB
[download] Downloading video 24 of 29
[vimeo] 1098614: Downloading webpage
[vimeo] 1098614: Extracting information
[vimeo] 1098614: Downloading webpage
[vimeo] 1098614: Downloading JSON metadata
[vimeo] 1098614: Downloading m3u8 information
[debug] Invoking downloader on u'https://fpdl.vimeocdn.com/vimeo-prod-skyfire-std-us/01/4740/6/173704322/561738544.mp4?token=57a86bea_0xbbbe846f6f0afc6c2374c025688b35070bfea252'
[download] Monitorama PDX 2016 - Brian Brazil - Prometheus-1098614.mp4 has already been downloaded
[download] 100% of 480.14MiB
[download] Downloading video 25 of 29
[vimeo] 1098614: Downloading webpage
[vimeo] 1098614: Extracting information
[vimeo] 1098614: Downloading webpage
[vimeo] 1098614: Downloading JSON metadata
[vimeo] 1098614: Downloading m3u8 information
[debug] Invoking downloader on u'https://fpdl.vimeocdn.com/vimeo-prod-skyfire-std-us/01/4740/6/173704322/561738544.mp4?token=57a86bed_0x3a25ab5184727acab4bfcea69619c23c737abd34'
[download] Monitorama PDX 2016 - Brian Brazil - Prometheus-1098614.mp4 has already been downloaded
[download] 100% of 480.14MiB
[download] Downloading video 26 of 29
[vimeo] 1098614: Downloading webpage
[vimeo] 1098614: Extracting information
[vimeo] 1098614: Downloading webpage
[vimeo] 1098614: Downloading JSON metadata
[vimeo] 1098614: Downloading m3u8 information
[debug] Invoking downloader on u'https://fpdl.vimeocdn.com/vimeo-prod-skyfire-std-us/01/4740/6/173704175/561757411.mp4?token=57a869bf_0xbc71c0d1301f36360526407592089bd1aac3e797'
[download] Monitorama PDX 2016 - Joey Parsons - Monitoring and Health at Airbnb-1098614.mp4 has already been downloaded
[download] 100% of 463.80MiB
[download] Downloading video 27 of 29
[vimeo] 1098614: Downloading webpage
[vimeo] 1098614: Extracting information
[vimeo] 1098614: Downloading webpage
[vimeo] 1098614: Downloading JSON metadata
[vimeo] 1098614: Downloading m3u8 information
[debug] Invoking downloader on u'https://fpdl.vimeocdn.com/vimeo-prod-skyfire-std-us/01/4740/6/173704175/561757411.mp4?token=57a869c3_0x5d9e262d0de2d4f2b98514a38803ad4ea0da04fb'
[download] Monitorama PDX 2016 - Joey Parsons - Monitoring and Health at Airbnb-1098614.mp4 has already been downloaded
[download] 100% of 463.80MiB
[download] Downloading video 28 of 29
[vimeo] 1098614: Downloading webpage
[vimeo] 1098614: Extracting information
[vimeo] 1098614: Downloading webpage
[vimeo] 1098614: Downloading JSON metadata
[vimeo] 1098614: Downloading m3u8 information
[debug] Invoking downloader on u'https://fpdl.vimeocdn.com/vimeo-prod-skyfire-std-us/01/4740/6/173704175/561757411.mp4?token=57a869c5_0xf6af99a29476102439d34a202d84dd78e394725a'
[download] Monitorama PDX 2016 - Joey Parsons - Monitoring and Health at Airbnb-1098614.mp4 has already been downloaded
[download] 100% of 463.80MiB
[download] Downloading video 29 of 29
[vimeo] 1098614: Downloading webpage
[vimeo] 1098614: Extracting information
[vimeo] 1098614: Downloading webpage
[vimeo] 1098614: Downloading JSON metadata
[vimeo] 1098614: Downloading m3u8 information
[debug] Invoking downloader on u'https://fpdl.vimeocdn.com/vimeo-prod-skyfire-std-us/01/4740/6/173704175/561757411.mp4?token=57a869c8_0xf4bab1e1c9034a9ae4e37e1f732c4a1c10f635f5'
[download] Monitorama PDX 2016 - Joey Parsons - Monitoring and Health at Airbnb-1098614.mp4 has already been downloaded
[download] 100% of 463.80MiB
[download] Finished downloading playlist: Monitorama PDX 2016 - Portland, OR
```
---
### Description of your _issue_, suggested solution and other information
I'm trying to download all videos from a [Vimeo channel](https://vimeo.com/channels/1098614). It has 29 videos in the list but youtube-dl just downloads 6 of them. Logs show that it is fetching URLs of only these 6 videos (repeating each video 5 times).
| site-support-request | low | Critical |
169,925,440 | TypeScript | Error message for invalid string literal type could be improved | <!-- BUGS: Please use this template. -->
<!-- QUESTIONS: This is not a general support forum! Ask Qs at http://stackoverflow.com/questions/tagged/typescript -->
<!-- SUGGESTIONS: See https://github.com/Microsoft/TypeScript-wiki/blob/master/Writing-Good-Design-Proposals.md -->
**TypeScript Version:** 2.0 Beta
**Code**
``` ts
// A *self-contained* demonstration of the problem follows...
interface Foo {
method(value: 'aa'): void;
method(value: 'bb'): void;
method(value: 'zz'): void;
method(value: 'last'): void;
}
const x: Foo = {} as any;
x.method('bar'); // Error line
```
**Expected behavior:**
A more meaningful error message, e.g.
`Argument of type "'bar'" is not assignable to parameter of type "'aa' | 'bb'|...|'last'"`
**Actual behavior:**
`Argument of type "'bar'" is not assignable to parameter of type "'last'"`
I am finding this error message confusing, because the compiler picks the value of the last overload in order to report the error, and there is nothing special about the last value.
| Suggestion,Help Wanted,Effort: Moderate,Domain: Error Messages,Experience Enhancement | low | Critical |
169,933,943 | go | runtime: use frame pointers for callers | Traceback is the main source of slowdown for tracer. On net/http.BenchmarkClientServerParallel4:
BenchmarkClientServerParallel4-6 200000 10627 ns/op 4482 B/op 57 allocs/op
with tracer:
BenchmarkClientServerParallel4-6 200000 16444 ns/op 4482 B/op 57 allocs/op
That's +55% slowdown. Top functions of profile are:
6.09% http.test http.test [.] runtime.pcvalue
5.88% http.test http.test [.] runtime.gentraceback
5.41% http.test http.test [.] runtime.readvarint
4.31% http.test http.test [.] runtime.findfunc
2.98% http.test http.test [.] runtime.step
2.12% http.test http.test [.] runtime.mallocgc
runtime.callers/gcallers/Callers are not interested in frame/func/sp/args/etc for each frame, they only need PC values. PC values can be obtained using frame pointers, which must be much faster. Note that there calls are always synchronous (can't happen during function prologue or in the middle of goroutine switch), so should be much simpler to handle.
We should use frame pointers in runtime.callers.
@aclements @ianlancetaylor @hyangah
| Performance,NeedsFix,early-in-cycle | medium | Major |
169,965,894 | kubernetes | Controller manager special-cases NFS and other volumes | code in `cmd/kube-controller-manager/app/plugins.go`:
```
nfsConfig := volume.VolumeConfig{
RecyclerMinimumTimeout: int(config.PersistentVolumeRecyclerConfiguration.MinimumTimeoutNFS),
RecyclerTimeoutIncrement: int(config.PersistentVolumeRecyclerConfiguration.IncrementTimeoutNFS),
RecyclerPodTemplate: volume.NewPersistentVolumeRecyclerPodTemplate(),
}
```
Volume plugins should be opaque. We need to find a way for params like this to come through without open-coding lists of parameters per volume plugin type. This will take some thinking, and it will have to be compatible for a while.
@saad-ali @jsafrane @matchstick
| priority/backlog,sig/storage,sig/api-machinery,lifecycle/frozen | low | Minor |
170,025,995 | gin | Is there a way to match hosts like you can in Gorilla? | For example, Gorilla has: `r.Host("www.example.com")`
Is that possible?
| feature | low | Minor |
170,035,532 | rust | `array.push(Foo { ... })` should construct `Foo` in-place | Right now when you push an immediate we construct a temporary copy on the stack and then move it into place on the heap. This is wasteful and results in a good deal of code bloat. Can we do better (with MIR perhaps)?
One possible sketch of a solution is to implement MIR inlining and then use some variant of #32966 that can prove that the construction of the argument to `push()` does not touch the vector, enabling us to forward the move from the stack to the destination of `ptr::write()`.
An alternative would be to implement rust-lang/rfcs#1426.
cc @eddyb @nikomatsakis
| I-slow,C-enhancement,T-compiler,A-MIR,A-array | low | Major |
170,044,224 | rust | Bad codegen: unnecessary on-stack copy in WebRender 2 | Here's an unncessary on-stack copy in WebRender 2 with an inefficient `mov` chain.
Original code: https://github.com/servo/webrender/blob/master/src/tiling.rs#L111
```
fn add_layer_to_ubo(layer_ubos: &mut Vec<Vec<PackedLayer>>,
layer_to_ubo_map: &mut Vec<Option<usize>>,
layer_index: StackingContextIndex,
ctx: &RenderTargetContext) -> (usize, u32) {
let index_in_ubo = match layer_to_ubo_map[layer_index.0] {
Some(index_in_ubo) => {
index_in_ubo
}
None => {
let need_new_ubo = layer_ubos.is_empty() ||
layer_ubos.last().unwrap().len() == ctx.alpha_batch_max_layers;
if need_new_ubo {
for i in 0..layer_to_ubo_map.len() {
layer_to_ubo_map[i] = None;
}
layer_ubos.push(Vec::new());
}
let layer_ubo = layer_ubos.last_mut().unwrap();
let index = layer_ubo.len();
let sc = &ctx.layer_store[layer_index.0];
layer_ubo.push(PackedLayer {
transform: sc.transform,
inv_transform: sc.transform.invert(),
screen_vertices: sc.xf_rect.as_ref().unwrap().vertices,
world_clip_rect: sc.world_clip_rect.unwrap(),
});
layer_to_ubo_map[layer_index.0] = Some(index);
index
}
};
(layer_ubos.len() - 1, index_in_ubo as u32)
}
```
`out-reduced.ll`: https://gist.github.com/pcwalton/3dbfe14ea18a70bd96f7c74e27696663
`out-reduced.s`: https://gist.github.com/pcwalton/2ca2e9755eb75f7e61ccd252ff87ec9d
| A-LLVM,I-slow,C-enhancement,T-compiler | low | Major |
170,121,916 | youtube-dl | please support flyvidz.com - a really spammy site with strange pop-up like stuff | <img width="1304" alt="screen shot 2016-08-09 at 11 33 40" src="https://cloud.githubusercontent.com/assets/1093836/17511847/29425bf0-5e25-11e6-89ed-76b3b85d2af8.png">
flyvidz.com is a spamy site, even with ad blocking there is fishy stuff. I wish to get their videos.
Warning: this site sadly hosts not only porn also terrible stuff :-(
```
> youtube-dl -v http://flyvidz.com/gave-no-fk-girl-caught-in-middle-of-concert-giving-guy-head/
[debug] System config: [u'--restrict-filenames', u'--ignore-errors', u'--prefer-ffmpeg', u'-n', u'-o', u'~/Desktop/%(title)s-%(resolution)s.%(ext)s', u'-f', u'bestvideo[ext!=webm]+bestaudio[ext!=webm]/best[ext!=webm]']
[debug] User config: []
[debug] Command-line args: [u'-v', u'http://flyvidz.com/gave-no-fk-girl-caught-in-middle-of-concert-giving-guy-head/']
[debug] Encodings: locale UTF-8, fs utf-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2016.08.07
[debug] Python version 2.7.12 - Darwin-15.6.0-x86_64-i386-64bit
[debug] exe versions: avconv 11.4, avprobe 11.4, ffmpeg 3.1.1, ffprobe 3.1.1, rtmpdump 2.4
[debug] Proxy map: {'http': 'http://localhost:8118', 'https': 'http://localhost:8118'}
[generic] gave-no-fk-girl-caught-in-middle-of-concert-giving-guy-head: Requesting header
WARNING: Falling back on generic information extractor.
[generic] gave-no-fk-girl-caught-in-middle-of-concert-giving-guy-head: Downloading webpage
[generic] gave-no-fk-girl-caught-in-middle-of-concert-giving-guy-head: Extracting information
[download] Downloading playlist: Gave No F**K: Girl Caught in Middle of Concert Giving Guy Head
[generic] playlist Gave No F**K: Girl Caught in Middle of Concert Giving Guy Head: Collected 1 video ids (downloading 1 of them)
[download] Downloading video 1 of 1
[youtube:user] Downloading login page
[youtube:user] Logging in
[youtube:user] embed: Downloading channel page
[youtube:playlist] Downloading login page
[youtube:playlist] Logging in
[youtube:playlist] UUaHofiHZt-qSj7yg-pu2pGg: Downloading webpage
[download] Downloading playlist: Uploads from embed
[youtube:playlist] playlist Uploads from embed: Downloading 0 videos
[download] Finished downloading playlist: Uploads from embed
[download] Finished downloading playlist: Gave No F**K: Girl Caught in Middle of Concert Giving Guy Head
```
thanks for great work
| request | low | Critical |
170,310,057 | youtube-dl | Support futurelearn.com | ### Make sure you are using the _latest_ version: run `youtube-dl --version` and ensure your version is _2016.08.10_. If it's not read [this FAQ entry](https://github.com/rg3/youtube-dl/blob/master/README.md#how-do-i-update-youtube-dl) and update. Issues with outdated version will be rejected.
- [x] I've **verified** and **I assure** that I'm running youtube-dl **2016.08.10**
### Before submitting an _issue_ make sure you have:
- [x] At least skimmed through [README](https://github.com/rg3/youtube-dl/blob/master/README.md) and **most notably** [FAQ](https://github.com/rg3/youtube-dl#faq) and [BUGS](https://github.com/rg3/youtube-dl#bugs) sections
- [x] [Searched](https://github.com/rg3/youtube-dl/search?type=Issues) the bugtracker for similar issues including closed ones
### What is the purpose of your _issue_?
- [x] Site support request (request for adding support for a new site)
Hi, I'd like to add support for http://www.futurelearn.com/
| site-support-request,account-needed | low | Critical |
170,333,200 | rust | Only the first expression in an `include!`d file is included. | If you have a file that invokes a macro and you `include!` it, the following happens:
### `main.rs`
``` rust
fn main() {
macro_rules! my_macro {
($name:expr) => {{
printn!("{}", $name);
}}
}
include!("helper.rs");
}
```
### `helper.rs`
``` rust
my_macro!("foo");
my_macro!("bar");
```
### STR
```
$ rustc main.rs
$ ./main
foo
```
#### Expected output
Should print `foo` and `bar`, just as if the code would have been inlined.
Tested with latest nightly and stable:
```
rustc 1.12.0-nightly (080e0e072 2016-08-08)
rustc 1.10.0 (cfcb716cf 2016-07-03)
```
| A-diagnostics,A-macros,T-compiler,C-bug | low | Major |
170,344,580 | TypeScript | Function composition challenge for type system | How would you type the following JavaScript function?
``` ts
function wrap(fn) { return (a, b) => fn(a, b); }
```
Obviously, the naive typed declaration would be:
``` ts
type Func<A, B, R> = (a: A, b: B) => R;
declare function wrap<A, B, R>(fn: Func<A, B, R>): Func<A, B, R>;
```
But it does not really describe its contract. So, let's say if I pass generic function, which is absolutely acceptable, it's not gonna work:
``` ts
const f1 = wrap(<T>(a: T, b: T): T => a || b);
```
It's clear that `f1` must be `<T>(a: T, b: T) => T`, but it's inferred to be `(a: {}, b: {}) => {}`.
And that's not about type inferring, because we wouldn't be able to express that contract at all.
The challenge here is that I want to be able to capture/propagate not only the generic parameters themselves, but also their relations. To illustrate, if I add an overload to capture that kind of signatures:
``` ts
declare function wrap<A, B, R>(fn: <T>(a: T, b: T) => T): <T>(a: T, b: T) => T;
```
then, I still wouldn't be able to express
``` ts
const f2 = wrap(<T>(a: T, b: T): [T, T] => [a, b]);
```
Because then I would need to add overloads of unbounded number of type compositions, such as `[T]`, `T | number`, `[[T & string, number], T] | Whatever` ... infinite number of variations.
Hypothetically, I could express with something like this:
``` ts
declare function wrap<F extends Function>(fn: F): F;
```
but it doesn't solve the problem either:
- `F` isn't constrained to be requiring at least 2 arguments
- `F extends (a: {}, b: {}) => {}` would work, but doesn't currently, because it collapses `F` to `(a: {}, b: {}) => {}`
- it doesn't allow to express modified signature components of `F`; see an example below
So then we come to more complicated things:
``` ts
const wrap2 = fn => args => [fn(args[0], args[1])];
// so that
const f3 = wrap2((a: number, b: string): number|string => a || b); // (args: [number, string]) => [number|string]
```
How to express that in the type system?
A reader can think now that is very synthetic examples that unlikely be found in real world.
Actually, it came to me when I tried to properly type Redux store enhancers. Redux's store enhancers are powerful and built based on function compositions. Enhancers can be very generic or can be applicable to specific types of dispatchers, states etc etc. And more importantly they can be constructed being detached from specific store. If the issue falls to discussion I will provide more details of why it's required there.
So where's the proposal?
I've been thinking of that for awhile and haven't came out with something viable yet.
However, this is something we can start with:
``` ts
declare function wrap2<~G, Ζ¦<T1, T2, R, ~G>>(fn: <...G>(a: T1, b: T2) => R): <...G>(args: [T1, T2]) => [R]);
```
Of course, ignoring the syntax, here's what was introduced:
1. `~G` is generic set of unbinded (no such word?) generic parameters with their constraints. Since it's not the same as generic type parameter, I've marked it with `~`. So than it's applied as `<...G>` that means that set becomes set of generic parameters. For example `~G=<T, R extends T>`, so then `<...G>=<T, R extends T>`.
2. `Ζ¦<T1, T2, R, ~G>` (_maybe syntax `Ζ¦<T1, T2, R, ...G>` would make more sense, btw_) is a relation between `T1`, `T2`, `R`, `~G`. It is another kind of generic information. It could be a set of relations, such as `T1=number`, `T2=string`, `R=T1|T2=number|string`. Important here, is that relations can introduce new names that can be used as generic parameters, and also, they can reference existing type parameters from enclosing generic info.
Probably, examples could help to understand what I'm trying to say:
``` ts
// JavaScript
const f(f1, f2) => a => b => f2(f1(a), b);
// TypeScript
declare function f<~G1, ~G2, Ζ¦<~G1, ~G2, A, B, R1, R2>>(
f1: <...G1>(a: A) => R1,
f2: <...G2>(r1: R1, b: B) => R2): <...G1>(a: A) => <...G2>(b: B) => R2;
// using
const g = f(
/* f1 = */ <T>(a: [T, T]): [T, T] => [a[1], a[0]],
/* f2 = */ <T, B extends T>(r1: [T, T], b: B[]): B[] => [...r1, ...b]);
// Inferred generic data (all can be set explicitly, syntax is pending):
// ~G1 = <T>
// ~G2 = <T, B extends T>
// Ζ¦<~G1, ~G2, A, B, R1, R2> ->
// A is [G1.T, G1.T],
// R1 is [G1.T, G1.T],
// R1 is [G2.T, G2.T],
// B is G2.B[],
// R2 is G2.B[]
// So the return type, type of const g would be
// <...G1>(a: A) => <...G2>(b: B) => R2 ->
// <T>(a: [T, T]) => <G2_T extends T, B extends G2_T>(b: B) => B[]
```
Simpler example from the beginning:
``` ts
// JavaScript
function wrap(fn) { return (a, b) => fn(a, b); }
// TypeScript
declare function wrap<~G, R<~G, A, B, C>>(
fn: <...G>(a: A, b: B) => C): <...G>(a: A, b: B) => C;
// using
const f1 = wrap(<T>(a: T, b: T): T => a || b);
// is the same as explicitly
const f1: <T>(a: T, b: T) => T =
wrap<
/* ~G = */ ~<T>,
<~<T>, A, B, C> -> [
A is T,
B is T,
C is T]
>(<T>(a: T, b: T): T => a || b);
```
Ok, guys, what do you think of this?
| Suggestion,In Discussion | high | Critical |
170,349,861 | go | x/sys/windows: named pipes support on Windows | 1. What version of Go are you using (`go version`)?
go version go1.7rc3 windows/amd64
2. What operating system and processor architecture are you using (`go env`)?
set GOARCH=amd64
set GOBIN=
set GOEXE=.exe
set GOHOSTARCH=amd64
set GOHOSTOS=windows
set GOOS=windows
set GOPATH=d:\developing\go\xxx..\3td;d:\developing\go\meijing\
set GORACE=
set GOROOT=d:\tools\go_amd64
set GOTOOLDIR=d:\tools\go_amd64\pkg\tool\windows_amd64
set CC=gcc
set GOGCCFLAGS=-m64 -mthreads -fmessage-length=0 -fdebug-prefix-map=C:\Users\xxx\go-build491836642=/tmp/go-build -gno-record-gcc-switches
set CXX=g++
set CGO_ENABLED=1
On *nix we have unix sockets - a standard way of doing IPC (interprocess communication).
On windows we can use TCP sockets for doing the IPC, but a natural way of doing so according to this page (http://msdn.microsoft.com/en-us/library/windows/desktop/aa365574(v=vs.85).aspx) is named pipes. Very close analogy to unix sockets. Providing net.NamedPipeConn in the net package sounds like a good idea to me. I need run web app on the pipe.
I find this issues https://github.com/golang/go/issues/3599, but is closed. It provide a alternative package βgopkg.in/natefinch/npipe.v2βγ but it is unstable and low performance. All thread will blocked at syscall.WaitForSingleObject while Use PipeListener on the server.
| OS-Windows,compiler/runtime | low | Critical |
170,382,643 | opencv | ThinPlateSplineShapeTransformer::wrapImage transformed X and Y values are located in the oposite side | <!--
If you have a question rather than reporting a bug please go to http://answers.opencv.org where you get much faster responses.
If you need further assistance please read [How To Contribute](https://github.com/opencv/opencv/wiki/How_to_contribute).
This is a template helping you to create an issue which can be processed as quickly as possible. This is the bug reporting section for the OpenCV library.
-->
##### System information (version)
<!-- Example
- OpenCV => 3.1
- Operating System / Platform => Windows 64 Bit
- Compiler => Visual Studio 2013
-->
- OpenCV => 3.1
- Operating System / Platform => Windows 64 Bit
- Compiler => Visual Studio 2013
##### Detailed description
Hi,
I'm working with the ThinPlateSplineShapeTransformer. I tried the methods **estimateTransformation**, **applyTransformation** and **warpImage**. It seems there is a bug in the ThinPlateSplineShapeTransformer::warpImage implementation where transformed X values are located in the oposite side. The same behavior for the Y values.
##### Steps to reproduce
First, I tried only the **estimateTransformation** and **applyTransformation** methods.
``` cpp
auto tps = cv::createThinPlateSplineShapeTransformer();
std::vector<cv::Point2f> sourcePoints, targetPoints;
sourcePoints.push_back(cv::Point2f(0, 0));
targetPoints.push_back(cv::Point2f(100, 0));
sourcePoints.push_back(cv::Point2f(799, 0));
targetPoints.push_back(cv::Point2f(799, 0));
sourcePoints.push_back(cv::Point2f(0, 599));
targetPoints.push_back(cv::Point2f(0, 599));
sourcePoints.push_back(cv::Point2f(799, 599));
targetPoints.push_back(cv::Point2f(799, 599));
std::vector<cv::DMatch> matches;
for (unsigned int i = 0; i < sourcePoints.size(); i++)
matches.push_back(cv::DMatch(i, i, 0));
tps->estimateTransformation(sourcePoints, targetPoints, matches);
std::vector<cv::Point2f> transPoints;
tps->applyTransformation(sourcePoints, transPoints);
cout << "sourcePoints = " << endl << " " << sourcePoints << endl << endl;
cout << "targetPoints = " << endl << " " << targetPoints << endl << endl;
cout << "transPos = " << endl << " " << transPoints << endl << endl;
```
So, we want to transform 4 points (sourcePoints) into 4 targetPoints (targetPoints). In line 4 the source point (0,0) should be transformed to the target point (100, 0). In other words: The target point is 100 units moved to the right. We assume that we have a x axis which will be positive to the right.
Then we match the 4 source to the target points with cv::DMatch. And then we call **estimateTransformation** to perform the thin plate spline implementation. And finally we prove the tranformation with the method **applyTransformation**. The transformed points "transPoints" should be equal to the targetPoints.
And thats true. The output is:
```
sourcePoints =
[0, 0;
799, 0;
0, 599;
799, 599]
targetPoints =
[100, 0;
799, 0;
0, 599;
799, 599]
transPos =
[100.00003, 0;
799, 0;
4.196167e-005, 599;
799, 599]
```
Hurrah. The **estimateTransformation** and **applyTransformation** methods work as expected.
But now we want to apply the transformation for a "real" image with **warpImage**. Be aware that the origin of an "image" is in the upper left corner. So the y axis goes from up to down and the x axis goes from left to right.
I added only these few lines of code to the above code
``` cpp
cv::Mat img = cv::imread("C:/tests/ThinPlateSplineShapeTransformer/t.png");
cv::imshow("input", img);
cv::Mat res;
tps->warpImage(img, res);
cv::imshow("warp result", res);
```
Here is the input image:
But the wrapped image is not correct. It seems that the point (0,0) is transformed to (-100, 0) or somewhere else.
A work-around is to switch sourcePoints and targetPoints in **estimateTransformation**
``` cpp
// **** Switch source and target points so that wrapImage is working correctly. ****
tps->estimateTransformation(targetPoints, sourcePoints, matches);
```
After the "switch" the wrap result is correct:
In this image you see that the point (0,0) is transformed to (100,0).
I didn't show the images for the Y transformation. But there is the same problem like the X transformation.
The work-around is very dangerous. If someone else is reading my code the other programmer could think that it is wrong and switch the source and target points back.
Greetings,
Thomas
| bug,affected: 3.4,category: shape | low | Critical |
170,505,114 | flutter | No good way to determine who is causing my RenderObject to paint (without markNeedsPaint being called) | ```
debugPrintMarkNeedsPaintStacks = true;
```
The above gives a stack trace but it's not helpful in finding the culprit - it's all RenderObjects and RenderProxyBoxes usually.
| c: new feature,framework,a: debugging,P3,team-framework,triaged-framework | low | Critical |
170,511,567 | flutter | Stack and other multi-child layout renderers should not call markNeedsPaint if they don't actually change their layout | Example is a Stack with two children, one always changing and the other never changing. The changing child shouldn't cause the non-changing child to repaint.
| framework,c: performance,P3,team-framework,triaged-framework | low | Major |
170,514,027 | kubernetes | design and implement kubeconfig v2 api version | The kubeconfig v2 api is intended to address usability issues of the v1 api. Design is in progress but i'm hoping to use this issue aggregate some ideas and problems we would like to address in v2.
v2 kubeconfig should:
- be composable: adding new clusters or auth infos should not require modifying existing files. We should be able to drop new contexts into new files in the .kube directory and have kubectl pick these up.
- context should be configurable by the environment: I should be able to talk to a different cluster or use a different namespace in different terminal tabs.
cc @jlowdermilk @kubernetes/kubectl
| area/kubectl,sig/api-machinery,lifecycle/frozen | medium | Major |
170,515,702 | nvm | Add `prune` support to nvm | I was exploring setting up a machine that would continuously test against different versions of node. Seeing how `nvm` is very easy to use for installing (think nightly `nvm i 6` etc) my next concern was removing older versions of node. A `nvm prune` suggestively should remove all older versions of each major; for instance:
``` bash
$ nvm ls
v0.12.7
v6.3.0
-> v6.3.1
default -> 6.3 (-> v6.3.1)
node -> stable (-> v6.3.1) (default)
stable -> 6.3 (-> v6.3.1) (default)
iojs -> N/A (default)
lts/* -> lts/argon (-> N/A)
lts/argon -> v4.4.7 (-> N/A)
$ nvm prune
# Cleaning older versions of node:
# - Uninstalled node v6.3.0
# - did x.y.z
$ nvm ls
v0.12.7
-> v6.3.1
default -> 6.3 (-> v6.3.1)
node -> stable (-> v6.3.1) (default)
stable -> 6.3 (-> v6.3.1) (default)
iojs -> N/A (default)
lts/* -> lts/argon (-> N/A)
lts/argon -> v4.4.7 (-> N/A)
```
If passed a major (6, 0.12, etc), only clean that major (6.3.0 && 6.3.1 -> 6.3.1)
| feature requests | medium | Major |
170,544,376 | flutter | Should have finer grained linkability | Ideas from earlier:
# Linkability
This file has ideas only, so far. Comments welcome.
## Scenarios
- soduku app:
- want to share the board layout, but not my progress so far
- want to transfer my progress to another device
- a wikipedia-like app:
- follow links to other topics
- have links from other apps (e.g. search) to a specific subsection of a topic
- an instant-messenger app:
- bookmark specific group conversations
- a social network app:
- link to specific posts
- link to social network constructs like user lists (twitter), communities (g+), walls (fb), usersβ¦
- an IDE
- want to save a particular state of open windows, maybe to share with other developers
- Navigation app
- want to link to different modes of the app: nav mode, search page, personal profile, settings, etc
- want to link to specific points of interest, either public (restaurant) or private (home, work, saved locations)
- want to link to a specific map location, zoom level, direction, angle, time of day (for shadows), route (for navigation)
- want to link to a destination in nav mode (without a route)
- Podcast app
- want to link to a specific view (e.g. in doggcatcher, feeds, audio, video, news...)
- want to link to a specific podcast (maybe independently of the app)
- want to link to a specific time in a specific episode of a specific podcast
- save ui state (e.g. size of ui area vs podcast list in doggcatcher, scroll position in a list, specific settings window being on top of specific tab at a specific scroll position, etc)
- News app
- categories
- articles
- sets of categories
- sets of categories + a selected category + a scroll position
- app sections (e.g. Newsstandβs Explore vs Read Now vs My Library)
- specific settings in the settings section of the app
- Code Review Tools
- a specific code review
- a specific file in a specific code review
- code review plus scroll position
- specific comment
- the state of the UI, such as which changes are visible, which comments are expanded, sort settings, filter settings, etc; whether the settings window is open, what tab itβs open to, what field is focusedβ¦
## UI
- Sharing current state to another device using NFC: just put the phones together, the active app(s?) serialise their state to a βURLβ and that is sent to the other device
- App exposes a βpermalinkβ or βget linkβ UI that exposes a string you can Share (a la Androidβs Share intent) or copy and paste.
- An accessibility tree should expose the URL of each part of the app so that a user with an accessibility tool can bookmark a particular location in the app to jump to it later.
## Thoughts
- Seems like you link to three kinds of things:
- different in-app concepts, which might be shared across apps
- specific posts in a social network
- users
- particular game board starting configurations, game levels
- wikipedia topics
- search results
- POIs in a map
- videos on Vimeo, YouTube, etc
- a code review / CL / pull request
- a comment on a code review
- a file in a code review
- a comment in a blog post
- telephone numbers
- lat/long coordinates
- podcasts
- different top-level parts of the app (shallow state)
- e.g. in Facebook, linking to the stream; in G+, linking to the communities landing page, etc
- in a maps app, the mode (satellite, navigation, etc)
- deep state
- the current state of a particular game board, e.g. all the piece positions in chess, all the current choices in soduku...
- what windows are open, what field is focused, what widgets are expanded, the precise view of a 3D map, etc
- subsection of a topic in wikipedia (scroll position)
- Since almost every app is going to have app-specific items, we need to make the item space trivially extensible (no registry, no fixed vocabulary). This means that common items (e.g. lat/long coordinates, podcasts) will probably evolve conventions organically within communities rather than in a centralised fashion
- We donβt have to use URLs as they are known today, but doing so would leverage the existing infrastructure which might be valuable
## Ideas
- Two kinds of URLs: application state, and βthingsβ.
- Application state URLs consist of an identifier for the app, plus a blob of data for how to open the app
- Thing URLs identify a thing, either by string name, opaque identifier, or more structured data (e.g. two comma-separated floating point numbers for lat/long).
- Thing URLs have a label saying what they are, e.g. βpoiβ or βgeoβ or βcl-commentβ or something.
- Maybe βappsβ are just things, and going to an app is like picking that app thing from the system app, the same way youβd pick a post from a social network app.
| framework,f: routes,P3,team-framework,triaged-framework | low | Minor |
170,575,889 | java-design-patterns | Entity component system (ECS) pattern | Description:
The Entity Component System (ECS) design pattern is a robust architectural pattern used in game development and other performance-critical applications. This pattern provides a flexible and efficient way to manage entities and their behaviors by breaking them down into distinct components. The main elements of the ECS pattern include:
1. **Entity**: A general-purpose object that serves as a container for components. Entities are usually identified by a unique ID and do not contain any logic.
2. **Component**: A modular, reusable piece of data that describes a specific aspect of an entity, such as position, velocity, or health. Components are passive data holders.
3. **System**: Logic that operates on entities with specific components. Systems query entities that possess the necessary components and execute game logic, updating component data as needed.
Implementing the ECS pattern involves defining entities, components, and systems, and establishing a way to manage and process these elements efficiently.
References:
- [Entity Component System - Wikipedia](https://en.wikipedia.org/wiki/Entity_component_system)
- [Java Design Patterns - Contribution Guidelines](https://github.com/iluwatar/java-design-patterns/wiki)
- [Entity Component System Is the Coolest Thing I Ever Met](https://artificials.ch/entity-component-system-are-crazy-cool/)
Acceptance Criteria:
1. Create an `Entity` class that uniquely identifies each entity.
2. Develop a variety of `Component` classes that can be associated with entities, such as PositionComponent, VelocityComponent, and HealthComponent.
3. Implement `System` classes that operate on entities with specific components, including methods for querying relevant entities and updating their components.
4. Provide unit tests that validate the correct behavior of entities, components, and systems.
5. Ensure the implementation adheres to the project's coding standards and contribution guidelines.
| epic: pattern,type: feature | low | Major |
170,662,684 | TypeScript | Scope of this is lost when passing a member function to setInterval | TypeScript Version: 1.8.10
When passing a member function to setInterval, the scope of 'this' is lost within the callback, though the structure of the code (given experience of any object orientated language) indicates it shouldn't be.
**Example code**
```
export class SetIntervalTest {
private someNumber: number = 1;
trigger() {
setInterval(this.setIntervalCallback, 400);
}
private setIntervalCallback() {
console.log(this.someNumber);
}
}
```
**Expected behavior**
When console.log(this.someNumber); is called, the scope of this is within the scope of the SetIntervalTest interval instance, printing '1'.
**Actual behavior:**
The scope of this is pulled from global scope, resulting in this.someNumber being 'undefined'. If that isn't possible, the compiler should indicate the expected behaviour is not what you're going to get.
To fix this i need to change 'setInterval(this.setIntervalCallback, 400);' to 'setInterval(() => this.setIntervalCallback(), 400);' so 'this' is correctly scoped in the callback.
| Suggestion,Help Wanted,Domain: lib.d.ts,Good First Issue | low | Major |
170,687,707 | TypeScript | This-function parameters must be specified in caller *and* callee, even for methods | This means that only very careful people will benefit from assignability checking (and therefore argument checking at call sites). (Due to contextual typing, code that uses a this-typed library will get improved body checking a lot of the time.)
Specifically, assignability checking only happens when `this` is explicitly declared by both sides.
Instead, class methods should implicitly have `this: this` unless declared otherwise.
Given the declarations:
``` ts
declare let f: (this: string, x: number) => void;
declare class C {
m(x: number): void;
n(this: this, x: number): void;
}
declare let c: C;
```
**Expected behavior:**
``` ts
c.m = f // error, 'this: string' is not assignable to 'this: string'
f = c.m // error, 'this: C' is not assignable to 'this: string'
f = c.n // error, 'this: string' is not assignable to 'this: C'
c.n = f // error, 'this: C' is not assignable to 'this: string'
```
**Actual behavior:**
``` ts
c.m = f // no error
f = c.m // no error
f = c.n // error, 'this: string' is not assignable to 'this: C'
c.n = f // error, 'this: C' is not assignable to 'this: string'
```
# Comments
The "this parameter" feature was designed this way to balance four concerns:
1. Backward compatibility with un-annotated code.
2. Compiler efficiency.
3. Consistency between class and interface `this`.
4. Quality of error checking.
As you can see, (4) took the biggest hit by requiring annotation on both the source and target of the assignment.
## Backward compatibility
The problem with unannotated code is that we can't tell whether a function is intended to be called with or without `this`.
### Functions
`--noImplicitThis` helps address this problem by forcing annotation of this parameters for functions.
TODO: Work through some examples.
### Methods
Actually, for methods, we _do_ have a pretty good idea that a method is not supposed to be removed from its class. Even if the class implements an interface, we the class methods should still be able to refer to class-private implementation details.
TODO: Work through some examples.
## Interface consistency
The problem is that interfaces are frequently used to interact with objects instead of the class type itself. But interfaces are used in lots of other contexts as well. That means we can't infer intent with an interface, but if we don't add `this: this` to interface methods, we're left with a bad assignment problem:
``` ts
interface I {
m(x: number): void;
}
class C implements I {
y = 12;
m(x: number) {
return this.y + x;
}
}
let c = new C();
f = c.m;
f(); // error, this must of type 'C'
let i: I = c;
f = i.m;
f(); // ok, this is not annotated
```
"Assignment escape hatches" like this exist throughout TypeScript, but adding more is not a good thing.
## Efficiency
Briefly, if every interface has a `this` type, then every interface will be generic, even in non-OO code. This causes the compiler to generate about double the number of types internally, which is slower and uses more memory than today.
| Suggestion,Needs Proposal | low | Critical |
170,773,416 | rust | `self` and `super` behave inconsistently in `use` statements and as module names | Handling of `self` and `super` in `use` and `mod` statements is inconsistent. [Playpen](https://is.gd/znBchD):
``` rust
use self; // error: `self` imports are only allowed within a { } list [E0429] (expected)
// error: unresolved import `self`. There is no `self` in the crate root [E0432]
mod super { // error: expected identifier, found keyword `super`
type Test = u32;
mod submodule {
use super; // error: a module named `super` has already been imported in this module [E0252]
use super::{self, Test}; // (^^^ apparently "already" means "on the next line"?)
}
use super; // (no error for this one?)
}
```
There are probably several (related) issues here.
- Inconsistent handling of keyword status for `self` and `super` as module names: if we add a `mod self { }` to the above, we get the two "expected identifier, found keyword" errors we'd expect -- and no other output. It appears that `mod self { }` causes an immediate "aborting due to previous error", while `mod super { }` does not.
- `use super::{self, ...};` doesn't special-case the `self` keyword as a keyword like `use foo::bar::{self, ...};` does.
- `use super;` doesn't special-case the `super` keyword as a keyword.
- `use self;` _does_ do some special-casing so it can produce "error: `self` imports are only allowed within a { } list [E0429]", but it then continues by attempting to resolve `self` as an ident.
| C-enhancement,A-resolve,T-lang | low | Critical |
170,790,834 | youtube-dl | ffmpeg/avconv does not support SOCKS proxies | ### Make sure you are using the _latest_ version: run `youtube-dl --version` and ensure your version is _2016.08.12_. If it's not read [this FAQ entry](https://github.com/rg3/youtube-dl/blob/master/README.md#how-do-i-update-youtube-dl) and update. Issues with outdated version will be rejected.
- [x] I've **verified** and **I assure** that I'm running youtube-dl **2016.08.12**
### Before submitting an _issue_ make sure you have:
- [x] At least skimmed through [README](https://github.com/rg3/youtube-dl/blob/master/README.md) and **most notably** [FAQ](https://github.com/rg3/youtube-dl#faq) and [BUGS](https://github.com/rg3/youtube-dl#bugs) sections
- [x] [Searched](https://github.com/rg3/youtube-dl/search?type=Issues) the bugtracker for similar issues including closed ones
### What is the purpose of your _issue_?
- [x] Bug report (encountered problems with youtube-dl)
- [ ] Site support request (request for adding support for a new site)
- [ ] Feature request (request for a new functionality)
- [ ] Question
- [ ] Other
---
### If the purpose of this _issue_ is a _bug report_, _site support request_ or you are not completely sure provide the full verbose output as follows:
Add `-v` flag to **your command line** you run youtube-dl with, copy the **whole** output and insert it here. It should look similar to one below (replace it with **your** log inserted between triple ```):
```
[tim@passepartout ~]$ youtube-dl -v --proxy socks5://127.0.0.1:11111/ http://www.cwtv.com/shows/penn-teller-fool-us/you-dirty-rathead/?play=0c8763f4-6dfc-42c2-86af-02e9fd078334
[debug] System config: ['--prefer-free-formats']
[debug] User config: []
[debug] Command-line args: ['-v', '--proxy', 'socks5://127.0.0.1:11111/', 'http://www.cwtv.com/shows/penn-teller-fool-us/you-dirty-rathead/?play=0c8763f4-6dfc-42c2-86af-02e9fd078334']
[debug] Encodings: locale UTF-8, fs utf-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2016.07.17
[debug] Python version 3.4.3 - Linux-4.6.5-200.fc23.x86_64-x86_64-with-fedora-23-Twenty_Three
[debug] exe versions: ffmpeg 2.8.7, ffprobe 2.8.7, rtmpdump 2.4
[debug] Proxy map: {'http': 'socks5://127.0.0.1:11111/', 'https': 'socks5://127.0.0.1:11111/'}
[CWTV] 0c8763f4-6dfc-42c2-86af-02e9fd078334: Downloading JSON metadata
[CWTV] 0c8763f4-6dfc-42c2-86af-02e9fd078334: Downloading m3u8 information
[debug] Invoking downloader on 'http://hlsioscwtv.warnerbros.com/hls/2016/06/28/PennandTeller-305-YouDirtyRathead-P301-CW-Stereo_b2f7faf81_2100kbps/PennandTeller-305-YouDirtyRathead-P301-CW-Stereo_b2f7faf81_2100kbps.m3u8'
[download] Destination: You Dirty Rathead!-0c8763f4-6dfc-42c2-86af-02e9fd078334.mp4
[debug] ffmpeg command line: ffmpeg -y -headers 'User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0) Gecko/20150101 Firefox/47.0 (Chrome)
Accept-Charset: ISO-8859-1,utf-8;q=0.7,*;q=0.7
Accept-Language: en-us,en;q=0.5
Accept-Encoding: gzip, deflate
Accept: text/html,application/xhtml+xml,application/xml;q=0.9,*/*;q=0.8
' -i http://hlsioscwtv.warnerbros.com/hls/2016/06/28/PennandTeller-305-YouDirtyRathead-P301-CW-Stereo_b2f7faf81_2100kbps/PennandTeller-305-YouDirtyRathead-P301-CW-Stereo_b2f7faf81_2100kbps.m3u8 -c copy -f mp4 -bsf:a aac_adtstoasc 'file:You Dirty Rathead!-0c8763f4-6dfc-42c2-86af-02e9fd078334.mp4.part'
ffmpeg version 2.8.7 Copyright (c) 2000-2016 the FFmpeg developers
built with gcc 5.3.1 (GCC) 20160406 (Red Hat 5.3.1-6)
configuration: --prefix=/usr --bindir=/usr/bin --datadir=/usr/share/ffmpeg --incdir=/usr/include/ffmpeg --libdir=/usr/lib64 --mandir=/usr/share/man --arch=x86_64 --optflags='-O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -m64 -mtune=generic' --enable-bzlib --disable-crystalhd --enable-frei0r --enable-gnutls --enable-ladspa --enable-libass --enable-libcdio --enable-libdc1394 --disable-indev=jack --enable-libfreetype --enable-libgsm --enable-libmp3lame --enable-openal --enable-libopencv --enable-libopenjpeg --enable-libopus --enable-libpulse --enable-libschroedinger --enable-libsoxr --enable-libspeex --enable-libtheora --enable-libvorbis --enable-libv4l2 --enable-libvpx --enable-libx264 --enable-libx265 --enable-libxvid --enable-x11grab --enable-avfilter --enable-avresample --enable-postproc --enable-pthreads --disable-static --enable-shared --enable-gpl --disable-debug --disable-stripping --shlibdir=/usr/lib64 --enable-runtime-cpudetect
libavutil 54. 31.100 / 54. 31.100
libavcodec 56. 60.100 / 56. 60.100
libavformat 56. 40.101 / 56. 40.101
libavdevice 56. 4.100 / 56. 4.100
libavfilter 5. 40.101 / 5. 40.101
libavresample 2. 1. 0 / 2. 1. 0
libswscale 3. 1.101 / 3. 1.101
libswresample 1. 2.101 / 1. 2.101
libpostproc 53. 3.100 / 53. 3.100
[http @ 0x122f2c0] HTTP error 403 Forbidden
http://hlsioscwtv.warnerbros.com/hls/2016/06/28/PennandTeller-305-YouDirtyRathead-P301-CW-Stereo_b2f7faf81_2100kbps/PennandTeller-305-YouDirtyRathead-P301-CW-Stereo_b2f7faf81_2100kbps.m3u8: Server returned 403 Forbidden (access denied)
ERROR: ffmpeg exited with code 1
File "/usr/bin/youtube-dl", line 9, in <module>
load_entry_point('youtube-dl==2016.7.17', 'console_scripts', 'youtube-dl')()
File "/usr/lib/python3.4/site-packages/youtube_dl/__init__.py", line 422, in main
_real_main(argv)
File "/usr/lib/python3.4/site-packages/youtube_dl/__init__.py", line 412, in _real_main
retcode = ydl.download(all_urls)
File "/usr/lib/python3.4/site-packages/youtube_dl/YoutubeDL.py", line 1775, in download
url, force_generic_extractor=self.params.get('force_generic_extractor', False))
File "/usr/lib/python3.4/site-packages/youtube_dl/YoutubeDL.py", line 693, in extract_info
return self.process_ie_result(ie_result, download, extra_info)
File "/usr/lib/python3.4/site-packages/youtube_dl/YoutubeDL.py", line 739, in process_ie_result
return self.process_video_result(ie_result, download=download)
File "/usr/lib/python3.4/site-packages/youtube_dl/YoutubeDL.py", line 1421, in process_video_result
self.process_info(new_info)
File "/usr/lib/python3.4/site-packages/youtube_dl/YoutubeDL.py", line 1683, in process_info
success = dl(filename, info_dict)
File "/usr/lib/python3.4/site-packages/youtube_dl/YoutubeDL.py", line 1625, in dl
return fd.download(name, info)
File "/usr/lib/python3.4/site-packages/youtube_dl/downloader/common.py", line 350, in download
return self.real_download(filename, info_dict)
File "/usr/lib/python3.4/site-packages/youtube_dl/downloader/external.py", line 43, in real_download
self.get_basename(), retval))
File "/usr/lib/python3.4/site-packages/youtube_dl/downloader/common.py", line 161, in report_error
self.ydl.report_error(*args, **kargs)
File "/usr/lib/python3.4/site-packages/youtube_dl/YoutubeDL.py", line 556, in report_error
self.trouble(error_message, tb)
File "/usr/lib/python3.4/site-packages/youtube_dl/YoutubeDL.py", line 518, in trouble
tb_data = traceback.format_list(traceback.extract_stack())
[tim@passepartout ~]$
```
---
### Description of your _issue_, suggested solution and other information
If I run `youtube-dl` on a host in the US to download geo-restricted content like http://www.cwtv.com/shows/penn-teller-fool-us/you-dirty-rathead/?play=0c8763f4-6dfc-42c2-86af-02e9fd078334, it works fine. If I set up a SOCKS proxy and use `--proxy socks5://127.0.0.1:11111/`, it fails. I assume this is because `youtube-dl` calls `ffmpeg`, but does not instruct `ffmpeg` to use the proxy.
This is confusing. Either `youtube-dl` should pass proxy information to subcommands, or, if `youtube-dl` was called with the `--proxy` option and a subcommand does not support using a SOCKS proxy, `youtube-dl` should abort with an informative error message.
| external-bugs | medium | Critical |
170,793,554 | youtube-dl | Site request: Anime Planet | ## Please follow the guide below
- You will be asked some questions and requested to provide some information, please read them **carefully** and answer honestly
- Put an `x` into all the boxes [ ] relevant to your _issue_ (like that [x])
- Use _Preview_ tab to see how your issue will actually look like
---
### Make sure you are using the _latest_ version: run `youtube-dl --version` and ensure your version is _2016.08.12_. If it's not read [this FAQ entry](https://github.com/rg3/youtube-dl/blob/master/README.md#how-do-i-update-youtube-dl) and update. Issues with outdated version will be rejected.
- [x ] I've **verified** and **I assure** that I'm running youtube-dl **2016.08.12**
### Before submitting an _issue_ make sure you have:
- [ x] At least skimmed through [README](https://github.com/rg3/youtube-dl/blob/master/README.md) and **most notably** [FAQ](https://github.com/rg3/youtube-dl#faq) and [BUGS](https://github.com/rg3/youtube-dl#bugs) sections
- [ x] [Searched](https://github.com/rg3/youtube-dl/search?type=Issues) the bugtracker for similar issues including closed ones
### What is the purpose of your _issue_?
- [ ] Bug report (encountered problems with youtube-dl)
- [ x] Site support request (request for adding support for a new site)
- [ ] Feature request (request for a new functionality)
- [ ] Question
- [ ] Other
---
### The following sections concretize particular purposed issues, you can erase any section (the contents between triple ---) not applicable to your _issue_
---
### If the purpose of this _issue_ is a _bug report_, _site support request_ or you are not completely sure provide the full verbose output as follows:
Add `-v` flag to **your command line** you run youtube-dl with, copy the **whole** output and insert it here. It should look similar to one below (replace it with **your** log inserted between triple ```):
```
keybounceMBP:Finite-Fluids michael$ youtube-dl -v http://www.anime-planet.com/anime/rosario-to-vampire
[debug] System config: []
[debug] User config: [u'-o', u'%(title)s.%(ext)s', u'-f', u'\nbest[ext=mp4][height>431][height<=480]/\nbestvideo[ext=mp4][height=480]+bestaudio[ext=m4a]/\nbest[ext=mp4][height>340][height<=431]/\nbestvideo[ext=mp4][height>360][height<=576]+bestaudio/\nbest[height>340][height<=576]/\nbestvideo[height>360][height<=576]+bestaudio/\nbestvideo[height=360]+bestaudio/\nbest[ext=mp4][height>=280][height<=360]/\nbest[height<=576]/\nworst', u'--write-sub', u'--write-auto-sub', u'--sub-lang', u'en,enUS', u'--sub-format', u'srt/ass/best', u'--embed-subs', u'--recode-video', u'mp4', u'--mark-watched']
[debug] Command-line args: [u'-v', u'http://www.anime-planet.com/anime/rosario-to-vampire']
[debug] Encodings: locale UTF-8, fs utf-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2016.08.12
[debug] Python version 2.7.5 - Darwin-13.4.0-x86_64-i386-64bit
[debug] exe versions: ffmpeg 3.1.1, ffprobe 3.1.1, rtmpdump 2.4
[debug] Proxy map: {}
[generic] rosario-to-vampire: Requesting header
WARNING: Falling back on generic information extractor.
[generic] rosario-to-vampire: Downloading webpage
[generic] rosario-to-vampire: Extracting information
ERROR: Unsupported URL: http://www.anime-planet.com/anime/rosario-to-vampire
Traceback (most recent call last):
File "/Users/michael/bin/youtube-dl/youtube_dl/extractor/generic.py", line 1610, in _real_extract
doc = compat_etree_fromstring(webpage.encode('utf-8'))
File "/Users/michael/bin/youtube-dl/youtube_dl/compat.py", line 2525, in compat_etree_fromstring
doc = _XML(text, parser=etree.XMLParser(target=_TreeBuilder(element_factory=_element_factory)))
File "/Users/michael/bin/youtube-dl/youtube_dl/compat.py", line 2514, in _XML
parser.feed(text)
File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/xml/etree/ElementTree.py", line 1642, in feed
self._raiseerror(v)
File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/xml/etree/ElementTree.py", line 1506, in _raiseerror
raise err
ParseError: syntax error: line 1, column 1
Traceback (most recent call last):
File "/Users/michael/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 691, in extract_info
ie_result = ie.extract(url)
File "/Users/michael/bin/youtube-dl/youtube_dl/extractor/common.py", line 347, in extract
return self._real_extract(url)
File "/Users/michael/bin/youtube-dl/youtube_dl/extractor/generic.py", line 2344, in _real_extract
raise UnsupportedError(url)
UnsupportedError: Unsupported URL: http://www.anime-planet.com/anime/rosario-to-vampire
```
Typical playlist: http://www.anime-planet.com/anime/rosario-to-vampire
Typical episode: http://www.anime-planet.com/anime/rosario-to-vampire/videos/172162
NB: Site claims to be legal viewing with various partners.
| site-support-request,geo-restricted | low | Critical |
170,821,643 | youtube-dl | new site: webstream.eu requested | - [x] I've **verified** and **I assure** that I'm running youtube-dl **2016.08.12**
### Before submitting an _issue_ make sure you have:
- [x] At least skimmed through [README](https://github.com/rg3/youtube-dl/blob/master
- [x] [Searched](https://github.com/rg3/youtube-dl/search?type=Issues) the bugtracker for similar issues including closed ones
### What is the purpose of your _issue_?
- [ ] Bug report (encountered problems with youtube-dl)
- [x] Site support request (request for adding support for a new site)
- [ ] Feature request (request for a new functionality)
- [ ] Question
- [ ] Other
---
### The following sections concretize particular purposed issues, you can erase any section (the contents between triple ---) not applicable to your _issue_
---
### If the purpose of this _issue_ is a _bug report_, _site support request_ or you are not completely sure provide the full verbose output as follows:
Add `-v` flag to **your command line** you run youtube-dl with, copy the **whole** output and insert it here. It should look similar to one below (replace it with **your** log inserted between triple ```):
```
$ youtube-dl -s -v https://www.webstream.eu/channel/isaacandmeikefreiburg2016
[debug] System config: []
[debug] User config: [u'-t', u'-i', u'-x', u'--no-mtime', u'--audio-format=mp3', u'--audio-quality=128K']
[debug] Command-line args: [u'-s', u'-v', u'https://www.webstream.eu/channel/isaacandmeikefreiburg2016']
[debug] Encodings: locale UTF-8, fs UTF-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2016.08.12
[debug] Python version 2.7.6 - Linux-3.16.0-77-generic-x86_64-with-Ubuntu-14.04-trusty
[debug] exe versions: avconv 9.18-6, avprobe 9.18-6, rtmpdump 2.4
[debug] Proxy map: {}
[generic] isaacandmeikefreiburg2016: Requesting header
WARNING: Falling back on generic information extractor.
[generic] isaacandmeikefreiburg2016: Downloading webpage
[generic] isaacandmeikefreiburg2016: Extracting information
ERROR: Unsupported URL: https://www.webstream.eu/channel/isaacandmeikefreiburg2016
Traceback (most recent call last):
File "/usr/local/sbin/youtube-dl/youtube_dl/extractor/generic.py", line 1610, in _real_extract
doc = compat_etree_fromstring(webpage.encode('utf-8'))
File "/usr/local/sbin/youtube-dl/youtube_dl/compat.py", line 2525, in compat_etree_fromstring
doc = _XML(text, parser=etree.XMLParser(target=_TreeBuilder(element_factory=_element_factory)))
File "/usr/local/sbin/youtube-dl/youtube_dl/compat.py", line 2514, in _XML
parser.feed(text)
File "/usr/lib/python2.7/xml/etree/ElementTree.py", line 1642, in feed
self._raiseerror(v)
File "/usr/lib/python2.7/xml/etree/ElementTree.py", line 1506, in _raiseerror
raise err
ParseError: not well-formed (invalid token): line 11, column 18
Traceback (most recent call last):
File "/usr/local/sbin/youtube-dl/youtube_dl/YoutubeDL.py", line 691, in extract_info
ie_result = ie.extract(url)
File "/usr/local/sbin/youtube-dl/youtube_dl/extractor/common.py", line 347, in extract
return self._real_extract(url)
File "/usr/local/sbin/youtube-dl/youtube_dl/extractor/generic.py", line 2344, in _real_extract
raise UnsupportedError(url)
UnsupportedError: Unsupported URL: https://www.webstream.eu/channel/isaacandmeikefreiburg2016
### Description of your *issue*, suggested solution and other information
webstream.eu often has more than one video, almost like a playlist, none of which i was able to get, and i dont have the skills necessary, to even understand the issue further. Just wanted to add, the website in question is only ONE EXAMPLE of a whole lot, i am interested to download from.
```
| site-support-request | low | Critical |
170,822,360 | youtube-dl | Seperate Exception for authentication error in an extractor | ## Please follow the guide below
- You will be asked some questions and requested to provide some information, please read them **carefully** and answer honestly
- Put an `x` into all the boxes [ ] relevant to your _issue_ (like that [x])
- Use _Preview_ tab to see how your issue will actually look like
---
### Make sure you are using the _latest_ version: run `youtube-dl --version` and ensure your version is _2016.08.12_. If it's not read [this FAQ entry](https://github.com/rg3/youtube-dl/blob/master/README.md#how-do-i-update-youtube-dl) and update. Issues with outdated version will be rejected.
- [ x] I've **verified** and **I assure** that I'm running youtube-dl **2016.08.12**
### Before submitting an _issue_ make sure you have:
- [x] At least skimmed through [README](https://github.com/rg3/youtube-dl/blob/master/README.md) and **most notably** [FAQ](https://github.com/rg3/youtube-dl#faq) and [BUGS](https://github.com/rg3/youtube-dl#bugs) sections
- [x] [Searched](https://github.com/rg3/youtube-dl/search?type=Issues) the bugtracker for similar issues including closed ones
### What is the purpose of your _issue_?
- [ ] Bug report (encountered problems with youtube-dl)
- [ ] Site support request (request for adding support for a new site)
- [x] Feature request (request for a new functionality)
- [ ] Question
- [ ] Other
---
### The following sections concretize particular purposed issues, you can erase any section (the contents between triple ---) not applicable to your _issue_
---
Can we have a seperate exception for authentication errors in extractors so that while using it as a python module we can identify login errors.
| request | low | Critical |
170,857,540 | vscode | Lift `setContext` from a command to proper API | This would be very useful to activate extension build feature per project type.
would help for [this issue](https://github.com/Microsoft/vscode/issues/9280)
| feature-request,api,context-keys | high | Critical |
170,956,054 | You-Dont-Know-JS | ECMAScript editors: JS classes are not fake | > But does that mean JavaScript actually has classes? Plain and simple: No. ... the classes you have in other languages are not like the "classes" you're faking in JS.
At least a couple ECMAScript editors, Brian Terlson and Allen Wirfs-Brock, have implied or explicitly stated that the notion that JS classes are "fake" is incorrect.
Terlson explicitly said as much on reddit:
"it is not at all helpful for beginners to constantly be exposed to the notion that JS classes are "fake". They are not, they have real syntax and real semantics" (https://www.reddit.com/r/javascript/comments/4bmiqj/using_classes_in_javascript_es6_best_practice/d1avktu)
"There is no gold standard for "class". From a developer's perspective, a "class" is an OO encapsulation mechanism that involves creating methods, defining fields, and producing instances and has some sort of inheritance scheme. Making the definition of "class" more constrained than this is not only incorrect but also not a useful distinction to make at all." (https://www.reddit.com/r/javascript/comments/4bmiqj/using_classes_in_javascript_es6_best_practice/d1atm1a)
And Wirfs-Brock implied the same on twitter:
"What word do you use for βan open set of objects that share a common interface and implementationβ?" (https://twitter.com/awbjs/status/689506114807857152)
Wirfs-Brock also gave a talk showing how Smalltalk's class model and JavaScript's constructor pattern are "exactly the same, basically." (https://www.youtube.com/watch?v=EPHmm8JiGbg&t=37m28s)
Likewise, Python's and Ruby's class and inheritance models are strikingly similar as well. In both languages, a class is a memory consuming runtime object, and inheritance happens by delegation.
If we were to pick a definition of "class" that accommodates not just Java/C#/C++ but also Smalltalk/Python/Ruby, then it would probably have to be something very much like Wirfs-Brock's tweet: A class is a descriptor for an open set of objects that share a common interface and implementation.
And if we accept that as the definition of class, then we have to acknowledge that JS classes are not fake. JS has real classes just like Smalltalk/Python/Ruby have real classes.
| for second edition | medium | Major |
170,981,657 | godot | "Sync script changes" doesn't work for Visual Scripts | I have "Sync script changes" enabled, but when I change and save the visual script nothing happens...
My project: [HelloTriangle.zip](https://github.com/godotengine/godot/files/416323/HelloTriangle.zip)
Try to enable "Sync script changes" under Debug options and change one of the position values while app is running...
| bug,topic:editor,topic:visualscript | low | Critical |
170,992,526 | TypeScript | 'innerText' should not be nullable in most of Node's derived types | Compile the following with `--strictNullChecks` with the DOM available.
``` ts
const foo = document.createElement("div");
const s: string = foo.textContent;
```
Expected: No error
Actual: `Type 'string | null' is not assignable to type 'string'.`
From https://developer.mozilla.org/en-US/docs/Web/API/Node/textContent:
> - `textContent` returns `null` if the element is a [document](https://developer.mozilla.org/en-US/docs/DOM/document), a document type, or a notation. [...]
> - If the node is a CDATA section, a comment, a processing instruction, or a text node, textContent returns the text inside this node (the [`nodeValue`](https://developer.mozilla.org/en-US/docs/DOM/Node.nodeValue)).
> - For other node types, `textContent` returns the concatenation of the `textContent` attribute value of every child node, excluding comments and processing instruction nodes. This is an empty string if the node has no children.
Proposed fix: `textContent will be defined as nullable in`Node`, but overridden as`string` in most of its descendants.
| Bug,Help Wanted,Domain: lib.d.ts | low | Critical |
171,036,986 | youtube-dl | Site support request: Spotify | ### Make sure you are using the _latest_ version: run `youtube-dl --version` and ensure your version is _2016.08.13_. If it's not read [this FAQ entry](https://github.com/rg3/youtube-dl/blob/master/README.md#how-do-i-update-youtube-dl) and update. Issues with outdated version will be rejected.
- [x] I've **verified** and **I assure** that I'm running youtube-dl **2016.08.13**
### Before submitting an _issue_ make sure you have:
- [x] At least skimmed through [README](https://github.com/rg3/youtube-dl/blob/master/README.md) and **most notably** [FAQ](https://github.com/rg3/youtube-dl#faq) and [BUGS](https://github.com/rg3/youtube-dl#bugs) sections
- [x] [Searched](https://github.com/rg3/youtube-dl/search?type=Issues) the bugtracker for similar issues including closed ones
### What is the purpose of your _issue_?
- [ ] Bug report (encountered problems with youtube-dl)
- [x] Site support request (request for adding support for a new site)
- [ ] Feature request (request for a new functionality)
- [ ] Question
- [ ] Other
### If the purpose of this _issue_ is a _bug report_, _site support request_ or you are not completely sure provide the full verbose output as follows:
Add `-v` flag to **your command line** you run youtube-dl with, copy the **whole** output and insert it here. It should look similar to one below (replace it with **your** log inserted between triple ```):
```
$ python -m youtube_dl https://play.spotify.com/user/starsam80/playlist/3Cwl7TvjAgsVvs1KF7jxbs --verbose
[debug] System config: []
[debug] User config: []
[debug] Command-line args: ['https://play.spotify.com/user/starsam80/playlist/3Cwl7TvjAgsVvs1KF7jxbs', '--verbose']
[debug] Encodings: locale UTF-8, fs utf-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2016.08.13
[debug] Git HEAD: aaf44a2
[debug] Python version 3.5.2 - Linux-4.7.0-1-ARCH-x86_64-with-arch-Arch-Linux
[debug] exe versions: ffmpeg 3.1.2, ffprobe 3.1.2, rtmpdump 2.4
[debug] Proxy map: {}
[generic] 3Cwl7TvjAgsVvs1KF7jxbs: Requesting header
WARNING: Falling back on generic information extractor.
[generic] 3Cwl7TvjAgsVvs1KF7jxbs: Downloading webpage
[generic] 3Cwl7TvjAgsVvs1KF7jxbs: Extracting information
ERROR: Unsupported URL: https://play.spotify.com/user/starsam80/playlist/3Cwl7TvjAgsVvs1KF7jxbs
Traceback (most recent call last):
File "/home/starsam80/.local/lib/python3.5/site-packages/youtube_dl/YoutubeDL.py", line 691, in extract_info
ie_result = ie.extract(url)
File "/home/starsam80/.local/lib/python3.5/site-packages/youtube_dl/extractor/common.py", line 347, in extract
return self._real_extract(url)
File "/home/starsam80/.local/lib/python3.5/site-packages/youtube_dl/extractor/generic.py", line 2344, in _real_extract
raise UnsupportedError(url)
youtube_dl.utils.UnsupportedError: Unsupported URL: https://play.spotify.com/user/starsam80/playlist/3Cwl7TvjAgsVvs1KF7jxbs
```
---
### If the purpose of this _issue_ is a _site support request_ please provide all kinds of example URLs support for which should be included (replace following example URLs by **yours**):
- Single song: https://play.spotify.com/track/7zsXy7vlHdItvUSH8EwQss
- Playlist (Top 50): https://play.spotify.com/chart/6o9o1UphRtyv10VPuDT80D
- Playlist (User created): https://play.spotify.com/user/starsam80/playlist/5VFlb4iQz3RADlqHrp5kQe
- Playlist (An artist): https://play.spotify.com/artist/3sS2Q1UZuUXL7TZSbQumDI
---
### Description of your _issue_, suggested solution and other information
Since there is support for Soundcloud, I don't see why Spotify can't be supported. The links above _may_ be blocked by a simple login, but you can create a free account if needed. https://developer.spotify.com/ also looks useful.
| site-support-request,account-needed | medium | Critical |
171,051,248 | kubernetes | Setting a message when cordoning nodes | Hey,
when draining a node or cordon a node I think its important to be able to set a message why this node was cordoned.
e.g (two examples)
kubectl cordon K8S_NODENAME "disabled due to docker maintenance"
kubectl drain K8S_NODENAME --set-message "disabled due to docker maintenance"
| area/kubectl,sig/node,sig/cli,lifecycle/frozen | medium | Major |
171,060,487 | three.js | Editor: Light targets are not editable. | ``` json
{
"uuid": "F7A1537F-0DA9-4FC2-9436-1BCC2A930EDA",
"type": "SpotLight",
"castShadow": true,
"matrix": [1, 0, 0, 0, 0, 1, 0, 0, 0, 0, 1, 0, 215.52757263183594, -383.2663269042969, 587.3773193359375, 1],
"color": 255,
"intensity": 2,
"distance": 1300,
"angle": 0.3490658503988659,
"decay": 1,
"penumbra": 0
}
```
this is what I get for the spot light. importing it in 3js editor it looks at the origin.
| Editor | medium | Major |
171,072,396 | opencv | Android Camera2Renderer can't find the correct size | Hi,
I'm trying to run this opencv4android example (android tutorial 4): https://github.com/opencv/opencv/tree...
The project compiles fine, but when i tryied to run, there is only a black screen and org.opencv.android.Camera2Renderer can't find the correct size (always 0x0). This is the log cat:
```
08-07 23:02:57.854 30516-30572/com.negi.app I/OpenGLRenderer: Initialized EGL, version 1.4
08-07 23:02:57.912 30516-30563/com.negi.app I/CameraGLRendererBase: onSurfaceCreated
08-07 23:02:57.912 30516-30563/com.negi.app I/CameraGLRendererBase: OpenGL ES version: OpenGL ES 3.0 [email protected] AU@ (GIT@I3f4bae6ca5)
08-07 23:02:57.912 30516-30563/com.negi.app D/CameraGLRendererBase: loadShader
08-07 23:02:57.940 30516-30563/com.negi.app D/CameraGLRendererBase: Shader program is built OK
08-07 23:02:57.941 30516-30563/com.negi.app D/CameraGLRendererBase: loadShader
08-07 23:02:57.948 30516-30563/com.negi.app D/CameraGLRendererBase: Shader program is built OK
08-07 23:02:57.948 30516-30563/com.negi.app I/CameraGLRendererBase: onSurfaceChanged(720x1072)
08-07 23:02:57.948 30516-30563/com.negi.app D/CameraGLRendererBase: updateState
08-07 23:02:57.948 30516-30563/com.negi.app D/CameraGLRendererBase: mEnabled=true, mHaveSurface=true
08-07 23:02:57.948 30516-30563/com.negi.app D/Camera2Renderer: doStart
08-07 23:02:57.948 30516-30563/com.negi.app I/Camera2Renderer: startBackgroundThread
08-07 23:02:57.948 30516-30563/com.negi.app I/Camera2Renderer: stopBackgroundThread
08-07 23:02:57.950 30516-30563/com.negi.app D/CameraGLRendererBase: doStart
08-07 23:02:57.951 30516-30563/com.negi.app D/CameraGLRendererBase: initSurfaceTexture
08-07 23:02:57.951 30516-30563/com.negi.app D/CameraGLRendererBase: deleteSurfaceTexture
08-07 23:02:57.953 30516-30563/com.negi.app I/Camera2Renderer: openCamera
08-07 23:02:57.953 30516-30563/com.negi.app I/CameraManagerGlobal: Connecting to camera service
08-07 23:02:57.958 30516-30563/com.negi.app I/Camera2Renderer: Opening camera: 0
08-07 23:02:57.974 30516-30563/com.negi.app I/CameraManager: Using legacy camera HAL.
08-07 23:02:58.050 30516-30572/com.negi.app V/RenderScript: 0xaebf9000 Launching thread(s), CPUs 4
08-07 23:02:58.097 30516-30516/com.negi.app I/Timeline: Timeline: Activity_idle id: android.os.BinderProxy@db53606 time:220493642
08-07 23:02:58.330 30516-30563/com.negi.app D/CameraGLRendererBase: updateState end
08-07 23:02:58.330 30516-30563/com.negi.app I/Camera2Renderer: setCameraPreviewSize(720x1072)
08-07 23:02:58.330 30516-30563/com.negi.app I/Camera2Renderer: cacPreviewSize: 720x1072
08-07 23:02:58.330 30516-30604/com.negi.app I/Camera2Renderer: createCameraPreviewSession(-1x-1)
08-07 23:02:58.335 30516-30563/com.negi.app D/Camera2Renderer: trying size: 1600x1200
08-07 23:02:58.335 30516-30563/com.negi.app D/Camera2Renderer: trying size: 1280x720
08-07 23:02:58.335 30516-30563/com.negi.app D/Camera2Renderer: trying size: 960x720
08-07 23:02:58.335 30516-30563/com.negi.app D/Camera2Renderer: trying size: 720x480
08-07 23:02:58.335 30516-30563/com.negi.app D/Camera2Renderer: trying size: 640x480
08-07 23:02:58.335 30516-30563/com.negi.app D/Camera2Renderer: trying size: 480x320
08-07 23:02:58.335 30516-30563/com.negi.app D/Camera2Renderer: trying size: 320x240
08-07 23:02:58.335 30516-30563/com.negi.app D/Camera2Renderer: trying size: 176x144
08-07 23:02:58.335 30516-30563/com.negi.app I/Camera2Renderer: best size: 0x0
08-07 23:02:58.335 30516-30563/com.negi.app D/CameraGLRendererBase: initFBO(-1x-1)
08-07 23:02:58.335 30516-30563/com.negi.app D/CameraGLRendererBase: deleteFBO(-1x-1)
08-07 23:02:58.335 30516-30563/com.negi.app W/Adreno-ES20: <core_glTexImage2D:501>: GL_INVALID_VALUE
08-07 23:02:58.339 30516-30563/com.negi.app D/CameraGLRendererBase: initFBO error status: 1281
08-07 23:02:58.339 30516-30563/com.negi.app E/CameraGLRendererBase: initFBO failed, status: 36054
08-07 23:02:58.340 30516-30563/com.negi.app W/Adreno-ES20: <core_glClear:37>: Error: Unknown: 0x506
```
I tried this tutorial http://docs.opencv.org/trunk/d7/dbd/tutorial_android_ocl_intro.html#gsc.tab=0 but is deprecated and can`t find any solution.
| bug,priority: low,platform: android,affected: 3.4 | low | Critical |
171,105,210 | youtube-dl | Problem with Discovery.com playlist | ## Please follow the guide below
- You will be asked some questions and requested to provide some information, please read them **carefully** and answer honestly
- Put an `x` into all the boxes [ ] relevant to your _issue_ (like that [x])
- Use _Preview_ tab to see how your issue will actually look like
---
### Make sure you are using the _latest_ version: run `youtube-dl --version` and ensure your version is _2016.08.13_. If it's not read [this FAQ entry](https://github.com/rg3/youtube-dl/blob/master/README.md#how-do-i-update-youtube-dl) and update. Issues with outdated version will be rejected.
- [ x] I've **verified** and **I assure** that I'm running youtube-dl **2016.08.13**
### Before submitting an _issue_ make sure you have:
- [x ] At least skimmed through [README](https://github.com/rg3/youtube-dl/blob/master/README.md) and **most notably** [FAQ](https://github.com/rg3/youtube-dl#faq) and [BUGS](https://github.com/rg3/youtube-dl#bugs) sections
- [ x] [Searched](https://github.com/rg3/youtube-dl/search?type=Issues) the bugtracker for similar issues including closed ones
### What is the purpose of your _issue_?
- [ x] Bug report (encountered problems with youtube-dl)
- [ ] Site support request (request for adding support for a new site)
- [ ] Feature request (request for a new functionality)
- [ ] Question
- [ ] Other
---
### The following sections concretize particular purposed issues, you can erase any section (the contents between triple ---) not applicable to your _issue_
---
### If the purpose of this _issue_ is a _bug report_, _site support request_ or you are not completely sure provide the full verbose output as follows:
Add `-v` flag to **your command line** you run youtube-dl with, copy the **whole** output and insert it here. It should look similar to one below (replace it with **your** log inserted between triple ```):
```
michael$ youtube-dl -F http://www.discovery.com/tv-shows/frozen-planet/videos/
[Discovery] videos: Downloading JSON metadata
ERROR: An extractor error has occurred. (caused by KeyError(u'playlist',)); please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type youtube-dl -U to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
keybounceMBP:Nightly michael$ youtube-dl -v -F http://www.discovery.com/tv-shows/frozen-planet/videos/
[debug] System config: []
[debug] User config: [u'-o', u'%(title)s.%(ext)s', u'-f', u'\nbest[ext=mp4][height>431][height<=480]/\nbestvideo[ext=mp4][height=480]+bestaudio[ext=m4a]/\nbest[ext=mp4][height>340][height<=431]/\nbestvideo[ext=mp4][height>360][height<=576]+bestaudio/\nbest[height>340][height<=576]/\nbestvideo[height>360][height<=576]+bestaudio/\nbestvideo[height=360]+bestaudio/\nbest[ext=mp4][height>=280][height<=360]/\nbest[height<=576]/\nworst', u'--write-sub', u'--write-auto-sub', u'--sub-lang', u'en,enUS', u'--sub-format', u'srt/ass/best', u'--embed-subs', u'--recode-video', u'mp4', u'--mark-watched']
[debug] Command-line args: [u'-v', u'-F', u'http://www.discovery.com/tv-shows/frozen-planet/videos/']
[debug] Encodings: locale UTF-8, fs utf-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2016.08.13
[debug] Python version 2.7.5 - Darwin-13.4.0-x86_64-i386-64bit
[debug] exe versions: ffmpeg 3.1.1, ffprobe 3.1.1, rtmpdump 2.4
[debug] Proxy map: {}
[Discovery] videos: Downloading JSON metadata
ERROR: An extractor error has occurred. (caused by KeyError(u'playlist',)); please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type youtube-dl -U to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
Traceback (most recent call last):
File "/Users/michael/bin/youtube-dl/youtube_dl/extractor/common.py", line 347, in extract
return self._real_extract(url)
File "/Users/michael/bin/youtube-dl/youtube_dl/extractor/discovery.py", line 73, in _real_extract
for idx, video_info in enumerate(info['playlist']):
KeyError: u'playlist'
Traceback (most recent call last):
File "/Users/michael/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 691, in extract_info
ie_result = ie.extract(url)
File "/Users/michael/bin/youtube-dl/youtube_dl/extractor/common.py", line 353, in extract
raise ExtractorError('An extractor error has occurred.', cause=e)
ExtractorError: An extractor error has occurred. (caused by KeyError(u'playlist',)); please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type youtube-dl -U to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
```
This was another attempt to grab the Frozen Planet clips.
| geo-restricted | low | Critical |
171,148,476 | TypeScript | Auto-indentation problem with promise blocks | _From @lumaxis on August 12, 2016 0:7_
- VSCode Version: 1.5.0-insider (666ed83a2d465257201cdac215a553ddee3cccbe)
- OS Version: 10.11.6
Steps to Reproduce:
1. Create a Typescript file and start writing code using promises
2. Auto-indent file using ~~Shift+Alt+D~~ Shift+Alt-F
Expected Result:
``` typescript
return output
.then((result: ControllerResponse) => {
return res
.status(result.statusCode)
.json(result.payload);
})
```
Actual Result:
``` typescript
return output
.then((result: ControllerResponse) => {
return res
.status(result.statusCode)
.json(result.payload);
})
```
Description:
The problem with the current way is that it leads to a strange indentation on the closing braces:
``` typescript
});
}
```
Here, the closing curly braces and parentheses for the `.then()` block are indented 4 spaces instead of 2 spaces as they should be.
_Copied from original issue: Microsoft/vscode#10453_
| Bug,Help Wanted,Domain: Formatter,VS Code Tracked | medium | Major |
171,154,672 | rust | [rustbuild] Support `exclude` in config.toml, not just as a flag | debuginfo-gdb tests fail on my system due to gdb not existing/gdb being misconfigured/gdb being not actually gdb/gdb being too new/gdb being too old/gdb outputting stuff to stderr/etc. There should be a way to disable selected collections of tests altogether in rustbuild.
I tried setting debuginfo-tests to false, but it only appears to tweak whether `-g` gets passed to the tests by default.
<!-- TRIAGEBOT_START -->
<!-- TRIAGEBOT_ASSIGN_START -->
<!-- TRIAGEBOT_ASSIGN_DATA_START$${"user":"Aditya-PS-05"}$$TRIAGEBOT_ASSIGN_DATA_END -->
<!-- TRIAGEBOT_ASSIGN_END -->
<!-- TRIAGEBOT_END --> | E-easy,T-bootstrap,C-feature-request | low | Critical |
171,248,235 | vscode | Execute functions during snippet expansion | - VSCode Version: 1.4
- OS Version: any
There are several snippets that exist in Visual Studio today that I would like to introduce to the C# extension for VS Code, but require generating dynamic text are executing code to perform other actions during snippet expansion. For example:
- `ctor` -- generate a constructor declaration, automatically filling in the name of the constructor with the enclosing type name.
- `testclass` -- generate a test class and adds references to necessary test assemblies.
- `cw` -- generate `System.Console.WriteLine()` but simplify the type name with the current using directives. So, `System.` is removed if `using System;` is in scope.
From what I can tell, snippets only support text with placeholders today. Is it possible to generate text dynamically or execute commands with arguments during snippet expansion?
| feature-request,api,snippets | high | Critical |
171,383,407 | opencv | When creating a PR containing only doc changes | Wouldn't it make sense to disable the buildbots for the source code if only files from doc folder are edited? This would speed up the build of the docs for verification.
| feature,category: infrastructure | low | Minor |
171,447,769 | opencv | Camera calibration thoughts | I'm trying to use the calibrateCamera function to calibrate an industrial camera but it doesn't give the results I'm expecting. I took 10 pictures.
I'm using a planar calibration pattern with about one thousand of points.
I know that I cannot have a sub pixel accuracy for the all detected points but I'm pretty sure that a subset of them (between 50 and 75 %) are below one pixel of reprojection.
The OpenCV documentation said that the method for a planar pattern is implemented with "A Flexible New Technique for Camera Calibration" from Zhengyou Zhang. So I decided to implement it.
The first step of this method is to estimate homographies to have a guess of the calibration matrix. Once the guess is found, it must be refined with a LM algorithm.
To find an homography, a RANSAC estimation must be implemented to have an accurate guess. A Ransac estimation requires a threshold to find inliers/outliers. Instead of giving a hard coded value for the threshold (like 3 in OpenCV), I'm using a technique that finds this threshold to give me an inlier ratio between 0.5 and 0.75.
This procedure gives me a subset of inliers with a mean distance between points about 0.15 pixel with more than 500 points.
At this step, I know that my homographies are well estimated.
After the LM refinement, I have the exact same results as OpenCV, which is nice, it means that my implementation is not so bad after all but I'm still not having the results I'm expecting.
For each view to estimate the homography, a ransac procedure was used to compute it. So I decided to keep only the inliers points for refining the solution. The results are really better now. The results are really close to the one expected from the technical documentation of the camera.
The rms error of the reprojection on each view for the whole points is slightly reduced but the focal length/principal point and the k1/k2 distortion coefficients are correct.
The improvement was made by:
1. Refining the solution on the inliers points and not the whole data set
2. Not using a hard coded value for the distance error for the homography estimation
I'm using OpenCV 2.4.13 on MacOS X.
What do you think about this procedure ?
| RFC | low | Critical |
171,456,327 | javascript | [Request] use constants for linter error levels | My team has forked this project a couple times because linting rules are mostly 2/error instead of 1/warning, so it obscures genuine errors.
Something like this:
```
<Foo b={} a={} /> // props sorted wrong
```
Should not have the same severity as a critical bug! This adds a ton of mental overhead to every line when red dots are popping up everywhere: "will this code throw an error or is there some minor formatting issue?"
Needing to be so precious with every line slows down development when you may just be testing some additions or wading into third party code.
Doubly with autofix enabled, Atom currently fixes a ton of formatting inconsistencies on save, I can safely ignore some warnings now.
However, I understand your logic in #853Β β when you need to enforce absolute consistency in your team, saying "you can't proceed without fixing this niggle" is important. I would argue that should go in a commit hook or similar, but...
why not use a custom constant to define the error levels? This would allow the linting logic to be more flexible:
`{ rule: airbnb.ERROR }`
| question | low | Critical |
171,473,774 | youtube-dl | MKV thumbnail not correctly embedded | - [x] I've **verified** and **I assure** that I'm running youtube-dl **2016.08.13**
- [x] At least skimmed through [README](https://github.com/rg3/youtube-dl/blob/master/README.md) and **most notably** [FAQ](https://github.com/rg3/youtube-dl#faq) and [BUGS](https://github.com/rg3/youtube-dl#bugs) sections
- [x] [Searched](https://github.com/rg3/youtube-dl/search?type=Issues) the bugtracker for similar issues including closed ones
### What is the purpose of your _issue_?
- [x] Bug report (encountered problems with youtube-dl)
- [ ] Site support request (request for adding support for a new site)
- [ ] Feature request (request for a new functionality)
- [ ] Question
- [ ] Other
---
When using --embed-thumbnail, it seems that the thumbnail isn't added as an image resource (cover.jpg) to the mkv video file but instead added as a second video stream. Seemingly using the same code as is used for embedding cover art for a mp3. This results in the embedded thumbnail not being displayed and instead no thumbnail or a automatically generated one being shown.
Tested with this video:
https://www.youtube.com/watch?v=k_okcNVZqqI
youtube-dl https://www.youtube.com/watch?v=k_okcNVZqqI --embed-thumbnail
Using youtube-dl 2016.08.13 and ffmpeg-20160815-3282e31-win64-static
MediaInfo, thumbnail embedded with --embed-thumbnail:
[INK DROPS 4K (ULTRA HD)-k_okcNVZqqI.mkv.MediaInfo.txt](https://github.com/rg3/youtube-dl/files/420888/INK.DROPS.4K.ULTRA.HD.-k_okcNVZqqI.mkv.MediaInfo.txt)
MediaInfo, thumbnail embedded with mkvpropedit:
[INK DROPS 4K (ULTRA HD)-k_okcNVZqqI-proper.mkv.MediaInfo.txt](https://github.com/rg3/youtube-dl/files/420889/INK.DROPS.4K.ULTRA.HD.-k_okcNVZqqI-proper.mkv.MediaInfo.txt)
Related to this the request for thumbnail embedding support for webm files when this is fixed. (#10360)
| bug,postprocessors | low | Critical |
171,513,236 | go | cmd/compile: move SSA boolean optimizations to generic level | Boolean optimizations were at the arch-specific level, because we had not yet decided that bools will be 0/1 everywhere. Now that that decision has been made, boolean optimizations could be migrated earlier. Filing this issue as a reminder on behalf of @brtzsnr.
| compiler/runtime | low | Minor |
171,540,554 | go | cmd/compile: make SSA IDs stable across passes | GOSSAFUNC's ssa.html's help text says:
> Values and blocks are highlighted by ID, which may vary across passes. (TODO: Fix this.)
But what is the bug? Maybe this is.
/cc @josharian @randall77
| NeedsFix,compiler/runtime | low | Critical |
171,600,491 | TypeScript | Comments on inner properties are stripped | TS: 2.0.0
``` ts
// code.ts
/**
* Some foo
*/
export const foo = {
/**
* Some boo
*/
boo = 0
}
```
expect:
``` ts
// code.d.ts
/**
* Some foo
*/
export declare foo: {
/**
* Some boo
*/
boo: number;
}
```
actual:
``` ts
// code.d.ts
/**
* Some foo
*/
export declare foo: {
boo: number;
}
```
By the way, is there a way to separately control whether comment should be kept in `*.d.ts` and `*.js`?
Currently when `tsconfig.json/compilerOptions/removeComments = true`, comments are removed from both of them.
Would it be nice to keep the comments in `*.d.ts` but not `*.js`?
| Suggestion,Help Wanted | low | Minor |
171,610,859 | opencv | boxFilter unexpected behaviour | While trying to use boxFilter on floating-point CV_32FC3 images, I noticed a strange behaviour where negative numbers appear.
The following code snippet should reproduce the issue with the image attached:
``` .cpp
cv::Mat testImg = cv::imread("data/castle.jpg");
testImg.convertTo(testImg, CV_32FC3, 1.0 / 255.0);
for (int i = 0; i < testImg.total(); i++) {
if (testImg.at<cv::Vec3f>(i)[0] < 0 ||
testImg.at<cv::Vec3f>(i)[1] < 0 ||
testImg.at<cv::Vec3f>(i)[2] < 0) {
std::cout << "Before box filter: " << testImg.at<cv::Vec3f>(i) << std::endl;
}
}
cv::boxFilter(testImg, testImg, -1, cv::Size(3, 3));
for (int i = 0; i < testImg.total(); i++) {
if (testImg.at<cv::Vec3f>(i)[0] < 0 ||
testImg.at<cv::Vec3f>(i)[1] < 0 ||
testImg.at<cv::Vec3f>(i)[2] < 0) {
std::cout << "After box filter: " << testImg.at<cv::Vec3f>(i) << std::endl;
}
}
```
<!--
If you have a question rather than reporting a bug please go to http://answers.opencv.org where you get much faster responses.
If you need further assistance please read [How To Contribute](https://github.com/opencv/opencv/wiki/How_to_contribute).
This is a template helping you to create an issue which can be processed as quickly as possible. This is the bug reporting section for the OpenCV library.
-->
##### System information (version)
<!-- Example
- OpenCV => 3.1
- Operating System / Platform => Windows 64 Bit
- Compiler => Visual Studio 2015
-->
- OpenCV => 3.1.0
- Operating System / Platform => Windows 10 64-bit
- Compiler => Visual Studio 2013
##### Detailed description
<!-- your description -->
##### Steps to reproduce
<!-- to add code example fence it with triple backticks and optional file extension
```.cpp
// C++ code example
```
or attach as .txt or .zip file
-->
| RFC | low | Critical |
171,637,648 | TypeScript | Trailing trivia removed for some object properties | **TypeScript Version:** 1.8.x / Playground
**Code**
``` ts
// the export annotations
export function bug() {
// hello
// another?
// return annotation
return {
// return object annotation
outer: {
// more!
inner1: { // here too
// and more
p1: 'v1', // comment1
p2: 'v2', // comment2
p3: 'v3' // last comment
} // here?
} // and here?
}; // here too?
// and finally here
}
```
[Playground demo](http://www.typescriptlang.org/play/#src=%2F%2F%20the%20export%20annotations%0Aexport%20function%20bug%28%29%20%7B%0A%09%2F%2F%20hello%0A%09%0A%09%2F%2F%20another%3F%0A%09%0A%09%2F%2F%20return%20annotation%0A%09return%20%7B%0A%09%09%2F%2F%20return%20object%20annotation%0A%09%09outer%3A%20%7B%0A%09%09%09%2F%2F%20more!%0A%09%09%09inner1%3A%20%7B%20%2F%2F%20here%20too%0A%09%09%09%09%2F%2F%20and%20more%0A%09%09%09%09%0A%09%09%09%09p1%3A%20'v1'%2C%20%2F%2F%20comment1%0A%09%09%09%09p2%3A%20'v2'%2C%20%2F%2F%20comment2%0A%09%09%09%09p3%3A%20'v3'%20%20%2F%2F%20last%20comment%0A%09%09%09%7D%20%2F%2F%20here%3F%0A%09%09%7D%20%2F%2F%20and%20here%3F%0A%09%7D%3B%20%2F%2F%20here%20too%3F%0A%09%0A%09%2F%2F%20and%20finally%20here%0A%7D)
**Expected behavior:**
All comments preserved
**Actual behavior:**
`comment1` and `comment2` are removed
| Bug,Domain: Comment Emit | low | Critical |
171,647,332 | youtube-dl | Support for rio2016.francetvsport.fr | ## Please follow the guide below
- You will be asked some questions and requested to provide some information, please read them **carefully** and answer honestly
- Put an `x` into all the boxes [ ] relevant to your _issue_ (like that [x])
- Use _Preview_ tab to see how your issue will actually look like
---
### Make sure you are using the _latest_ version: run `youtube-dl --version` and ensure your version is _2016.08.17_. If it's not read [this FAQ entry](https://github.com/rg3/youtube-dl/blob/master/README.md#how-do-i-update-youtube-dl) and update. Issues with outdated version will be rejected.
- [ ] I've **verified** and **I assure** that I'm running youtube-dl **2016.08.17**
### Before submitting an _issue_ make sure you have:
- [ ] At least skimmed through [README](https://github.com/rg3/youtube-dl/blob/master/README.md) and **most notably** [FAQ](https://github.com/rg3/youtube-dl#faq) and [BUGS](https://github.com/rg3/youtube-dl#bugs) sections
- [ ] [Searched](https://github.com/rg3/youtube-dl/search?type=Issues) the bugtracker for similar issues including closed ones
### What is the purpose of your _issue_?
- [ ] Bug report (encountered problems with youtube-dl)
- [x] Site support request (request for adding support for a new site)
- [ ] Feature request (request for a new functionality)
- [ ] Question
- [ ] Other
---
### The following sections concretize particular purposed issues, you can erase any section (the contents between triple ---) not applicable to your _issue_
---
### If the purpose of this _issue_ is a _bug report_, _site support request_ or you are not completely sure provide the full verbose output as follows:
Add `-v` flag to **your command line** you run youtube-dl with, copy the **whole** output and insert it here. It should look similar to one below (replace it with **your** log inserted between triple ```):
```
$ youtube-dl -v <your command line>
[debug] System config: []
[debug] User config: []
[debug] Command-line args: [u'-v', u'http://www.youtube.com/watch?v=BaW_jenozKcj']
[debug] Encodings: locale cp1251, fs mbcs, out cp866, pref cp1251
[debug] youtube-dl version 2016.08.17
[debug] Python version 2.7.11 - Windows-2003Server-5.2.3790-SP2
[debug] exe versions: ffmpeg N-75573-g1d0487f, ffprobe N-75573-g1d0487f, rtmpdump 2.4
[debug] Proxy map: {}
...
<end of log>
```
---
### If the purpose of this _issue_ is a _site support request_ please provide all kinds of example URLs support for which should be included (replace following example URLs by **yours**):
- Single video: https://www.youtube.com/watch?v=BaW_jenozKc
- Single video: https://youtu.be/BaW_jenozKc
- Playlist: https://www.youtube.com/playlist?list=PL4lCao7KL_QFVb7Iudeipvc2BCavECqzc
---
### Description of your _issue_, suggested solution and other information
Explanation of your _issue_ in arbitrary form goes here. Please make sure the [description is worded well enough to be understood](https://github.com/rg3/youtube-dl#is-the-description-of-the-issue-itself-sufficient). Provide as much context and examples as possible.
If work on your _issue_ required an account credentials please provide them or explain how one can obtain them.
| site-support-request,geo-restricted | low | Critical |
171,764,676 | vscode | Glob matching should be case insensitive | - VSCode Version: 1.4.0
- OS Version: Win10 1511
Steps to Reproduce:
1. using VSCode, open a directory stored in an NTFS volume, which has files named FooContainer.cs
2. press CTRL+SHIFT+F to invoke Find in Files
3. press "..." to show 'files to include'
4. enter "*_/_container.cs"
5. search for something that is known to exist in the file.
6. results: nothing is found
7. replace 'files to include' with "*_/_Container.cs" (only change is the upper case C instead of lower case)
8. search again, this time results are found as expected.
Since Windows NTFS is not a case-sensitive file system, the expected results is that I can search in files using any case in the 'files to include'/'files to exclude'.
| feature-request,search,file-glob | high | Critical |
171,766,442 | kubernetes | Rethink how we manage/name/publish annotations | NB: This is about the annotations that kubernetes itself uses, not about end-user annotations. Those are explicitly reserved for use by end-users.
We use annotations for 2 main things.
1) To prototype new would-be fields in existing objects.
2) To decorate objects with bits of state from the core system components.
In both cases, we have to write down and publish the name of the annotation and the expected/allowed values for it. Currently that is ad hoc. Sometimes it is written as a const somewhere global-ish (e.g. pkg/api). Sometimes it is a const in a local pkg. Sometimes it is just a string literal.
We have defined naming conventions for annotations but we don't always stick to them, nor are the conventions precise enough to be consistent.
I propose (without too much though yet) that we refine the conventions and standardize our own annotations more. Obviously this would be a "going forward" spec.
1) Any annotation that is a "would-be field", but is still alpha or beta designated should be named as `{kind}.alpha.kubernetes.io/{field-name}` (same for beta). `{kind}` is the top-level Kubernetes API type, all lowercase, e.g. "pod", "replicationcontroller", "podsecuritypolicy". `{field-name}` is the proposed name of the would-field after converting capital letters to dashes, e.g. "policy", "class", "file-mode". The "spec" nesting is implied for objects that have spec/status blocks. NB that the suffix is "kubernetes.io" not "k8s.io".
For fields that would exist on a sub-struct of an API type, the field name would reflect the nesting, e.g. `pod.alpha.kubernetes.io/security-context.breadth`.
For fields that would exist on a sub-struct where that struct is used as a list, the field name would reflect the name of the slice and the value would have enough information to logically patch the values. E.g. `pod.alpha.kubernetes.io/containers.volumes.encrypted: "[ [false, true], []]"` would map to a pod with 2 containers[] records with 2 volumes in the first and none in the second.
For fields that would exist on a sub-struct where that struct is used as a map, the field name would reflect the name of the slice and the value would have enough information to logically patch the values. E.g. `foo.alpha.kubernetes.io/field-names: "{ \"key\": \"val\" }"` would map to a foo with a map called fieldNames with a key "key". I could not find any concrete examples in our API where this would apply.
Alternative sub-points:
- we could make "spec" explicit
- we could make the name include "field" to distinguish from annotations that are not pre-GA fields
- we could NOT convert fooBar to foo-bar for field names -- it's easier
2) All annotations that represent would-be fields must be defined in the per-API packages in `annotations.go` (or in a sub-pkg thereof?) with consistent const names and comments explaining what the feature is, who owns it, and what values are allowed.
3) All annotations that represent would-be fields must be validated as if they were real fields.
4) Any annotation that is used by the kubernetes system but is not an alpha or beta field should be named as `{subsystem}.kubernetes.io/{meaningful-name}`. As above, `{subsystem}` is a little loose, and could use refinement. `{meaningful-name}` is a name that reflects the meaning of the annotation. All such annotations must be collected and published in a central file with consistent const names and comments explaining what the feature is, who owns it, and what values are allowed. These annotations are internal to the system and do not come from users, therefore do not necessarily need alpha/beta designation.
The main goal of all this is consistency and obviousness in naming, centralized places to publish the existence, meaning, and requirements for annotations, and the ability to curate and manage names. Ad hoc self-governance clearly is not working.
This could segue into the discussion gates for features.
@jlowdermilk @timstclair @lavalamp @erictune @smarterclayton @bgrant0607
| area/kubectl,sig/api-machinery,lifecycle/frozen | low | Minor |
171,778,370 | youtube-dl | Windows 10 x64 - Fatal Python error: Py_Initialize: unable to load the file system codec | ### Make sure you are using the _latest_ version: run `youtube-dl --version` and ensure your version is _2016.08.17_. If it's not read [this FAQ entry](https://github.com/rg3/youtube-dl/blob/master/README.md#how-do-i-update-youtube-dl) and update. Issues with outdated version will be rejected.
- [x] I've **verified** and **I assure** that I'm running youtube-dl **2016.08.17**
### Before submitting an _issue_ make sure you have:
- [x] At least skimmed through [README](https://github.com/rg3/youtube-dl/blob/master/README.md) and **most notably** [FAQ](https://github.com/rg3/youtube-dl#faq) and [BUGS](https://github.com/rg3/youtube-dl#bugs) sections
- [x] [Searched](https://github.com/rg3/youtube-dl/search?type=Issues) the bugtracker for similar issues including closed ones
### What is the purpose of your _issue_?
- [x] Bug report (encountered problems with youtube-dl)
- [ ] Site support request (request for adding support for a new site)
- [ ] Feature request (request for a new functionality)
- [ ] Question
- [ ] Other
---
### If the purpose of this _issue_ is a _bug report_, _site support request_ or you are not completely sure provide the full verbose output as follows:
Add `-v` flag to **your command line** you run youtube-dl with, copy the **whole** output and insert it here. It should look similar to one below (replace it with **your** log inserted between triple ```):
```
C:\path\to\youtube-dl>youtube-dl.exe -v
Fatal Python error: Py_Initialize: unable to load the file system codec
ImportError: No module named 'encodings'
Current thread 0x00003a38 (most recent call first):
<end of log>
```
---
### Description of your _issue_, suggested solution and other information
Similar issue:
I found #10053, which reports the same problem, but was closed because the user had placed it in `C:\Windows\System32`. I did _not_ place mine in that location.
Additional notes:
- I downloaded the executable file just prior to executing, so it is the latest version
- Windows 10 x64 machine
- Microsoft Visual C++ 2010 redistributable package is installed
- The machine was recently upgraded to Windows 10, and prior to the upgrade, youtube-dl functioned just fine
| external-bugs | medium | Critical |
171,928,304 | youtube-dl | Feature request for site http://www.t-online.de/tv/ | ## Please follow the guide below
i wount do cause i am sure i am right and i am programmer myself, not python, and i have done this questioner once and seen that there are many unrelated questions to my situation.
This is a feature request for the page http://www.t-online.de/tv/
Example videos:
http://www.t-online.de/tv/news/id_75241532/biker-fasst-sich-ein-herz-und-hilft-altem-mann.html?vid
http://www.t-online.de/tv/webclips/spektakulaere-videos/id_75443616/was-ein-vergessener-blinker-alles-anrichten-kann.html?vid=ap
http://www.t-online.de/tv/webclips/spektakulaere-videos/id_75456908/bei-tragischem-motorradsturz-retter-er-ihr-das-leben.html?vid=ap
http://www.t-online.de/tv/webclips/spektakulaere-videos/id_77644470/motorradfahrer-reagiert-geistesgegenwaertig.html?vid=ap
http://www.t-online.de/tv/webclips/spektakulaere-videos/id_77814304/reifenwechsel-auf-dem-mittelstreifen-endet-in-einer-katastrophe.html?vid=ap
http://www.t-online.de/tv/webclips/spektakulaere-videos/id_77905470/fahrer-mit-brennendem-pizzaofen-auf-der-autobahn.html
http://www.t-online.de/tv/video-hits/heisseste-videos-2014/id_68627612/junge-frau-wird-heimlich-beobachtet.html?vid=ap
http://www.t-online.de/tv/webclips/spektakulaere-videos/id_70400086/frau-legt-sexy-einlage-hin-um-abschleppen-zu-verhindern.html
http://www.t-online.de/tv/webclips/spektakulaere-videos/id_74081816/beim-abschleppen-reisst-das-seil.html?vid=ap
http://www.t-online.de/tv/webclips/spektakulaere-videos/id_78726044/hunderte-einkaufswagen-werden-in-obere-etage-befoerdert.html
http://www.t-online.de/tv/webclips/spektakulaere-videos/id_76853702/abschleppdienst-reisst-hinterachse-von-liegengebliebenen-wagen-ab.html
http://www.t-online.de/tv/weitere-videos/auto/id_77015242/selbstgebauter-sportwagen-beradino-.html?vid=ap
http://www.t-online.de/tv/weitere-videos/auto/id_78733178/selbstgebauter-formel-1-wagen-zieht-blicke-auf-sich.html
Example playlist:
http://www.t-online.de/tv/webclips/
http://www.t-online.de/tv/weitere-videos/lifehacks/
http://www.t-online.de/tv/news/
http://www.t-online.de/tv/
(eventually the video page itself giving a recursive mode downloading all related videos (possible limits: depth, only the first related video which will be played on auto by its auto play function or even all other related videos; time period (only newer then))
and here the output of the current version of youtube-dl trying to manage one of that page:
```
$ youtube-dl --write-info-json --write-description http://www.t-online.de/tv/news/id_75241532/biker-fasst-sich-ein-herz-und-hilft-altem-mann.html?vid=ap
[generic] biker-fasst-sich-ein-herz-und-hilft-altem-mann: Requesting header
WARNING: Falling back on generic information extractor.
[generic] biker-fasst-sich-ein-herz-und-hilft-altem-mann: Downloading webpage
[generic] biker-fasst-sich-ein-herz-und-hilft-altem-mann: Extracting information
ERROR: Unsupported URL: http://www.t-online.de/tv/news/id_75241532/biker-fasst-sich-ein-herz-und-hilft-altem-mann.html?vid=ap
treaki@treakis-tp:/tmp$ youtube-dl -v --write-info-json --write-description http://www.t-online.de/tv/news/id_75241532/biker-fasst-sich-ein-herz-und-hilft-altem-mann.html?vid=ap
[debug] System config: []
[debug] User config: []
[debug] Command-line args: [u'-v', u'--write-info-json', u'--write-description', u'http://www.t-online.de/tv/news/id_75241532/biker-fasst-sich-ein-herz-und-hilft-altem-mann.html?vid=ap']
[debug] Encodings: locale UTF-8, fs UTF-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2016.08.17
[debug] Python version 2.7.11 - Linux-4.1.0-1-amd64-x86_64-with-debian-8.0
[debug] exe versions: avconv 2.4.3, avprobe 2.4.3, ffmpeg 2.4.3, ffprobe 2.4.3, rtmpdump 2.4
[debug] Proxy map: {}
[generic] biker-fasst-sich-ein-herz-und-hilft-altem-mann: Requesting header
WARNING: Falling back on generic information extractor.
[generic] biker-fasst-sich-ein-herz-und-hilft-altem-mann: Downloading webpage
[generic] biker-fasst-sich-ein-herz-und-hilft-altem-mann: Extracting information
ERROR: Unsupported URL: http://www.t-online.de/tv/news/id_75241532/biker-fasst-sich-ein-herz-und-hilft-altem-mann.html?vid=ap
Traceback (most recent call last):
File "/usr/local/bin/youtube-dl/youtube_dl/extractor/generic.py", line 1623, in _real_extract
doc = compat_etree_fromstring(webpage.encode('utf-8'))
File "/usr/local/bin/youtube-dl/youtube_dl/compat.py", line 2525, in compat_etree_fromstring
doc = _XML(text, parser=etree.XMLParser(target=_TreeBuilder(element_factory=_element_factory)))
File "/usr/local/bin/youtube-dl/youtube_dl/compat.py", line 2514, in _XML
parser.feed(text)
File "/usr/lib/python2.7/xml/etree/ElementTree.py", line 1642, in feed
self._raiseerror(v)
File "/usr/lib/python2.7/xml/etree/ElementTree.py", line 1506, in _raiseerror
raise err
ParseError: mismatched tag: line 121, column 154
Traceback (most recent call last):
File "/usr/local/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 691, in extract_info
ie_result = ie.extract(url)
File "/usr/local/bin/youtube-dl/youtube_dl/extractor/common.py", line 347, in extract
return self._real_extract(url)
File "/usr/local/bin/youtube-dl/youtube_dl/extractor/generic.py", line 2362, in _real_extract
raise UnsupportedError(url)
UnsupportedError: Unsupported URL: http://www.t-online.de/tv/news/id_75241532/biker-fasst-sich-ein-herz-und-hilft-altem-mann.html?vid=ap
```
regards
| site-support-request | low | Critical |
172,008,546 | TypeScript | [Proposal] Type assertion statement (type cast) at block-scope level | This is a proposal in order to simplify the way we have to deal with type guards in TypeScript in order to enforce the type inference.
The use case is the following. Let us assume we have dozens (and dozens) of interfaces as the following:
**Code**
``` ts
interface AARect {
x: number; // top left corner
y: number; // top left corner
width: number;
height: number;
}
interface AABox {
x: number; // center
y: number; // center
halfDimX: number;
halfDimY: number;
}
interface Circle {
x: number; // center
y: number; // center
radius: number;
}
// And much more...
```
And we have a union type like this one:
``` ts
type Geometry = AARect | AABox | Circle | // ... And much more
```
It is quite easy to discriminate a type from another with `hasOwnProperty` or the `in` keyword:
``` ts
function processGeometry(obj: Geometry): void {
if ("width" in obj) {
let width = (obj as AARect).width;
// ...
}
if ("halfDimX" in obj) {
let halfDimX = (obj as AABox).halfDimX;
// ...
}
else if ("radius" in obj) {
let radius = (obj as Circle).radius;
// ...
}
// And much more...
}
```
But, as we can see, this is quite burdensome when we need to manipulate `obj` inside each `if` block, since we need to type cast each time we use `obj`.
A first way to mitigate this issue would be to create an helper variable like this:
``` ts
if ("width" in obj) {
let helpObj = obj as AARect;
let width = helpObj.width;
// ...
}
```
But this is not really satisfying since it creates an artefact we will find in the emitted JavaScript file, which is here just for the sake of the type inference.
So another solution could be to use user-defined type guard functions:
``` ts
function isAARect(obj: Geometry): obj is AARect {
return "width" in obj;
}
function isAABox(obj: Geometry): obj is AABox {
return "halfDimX" in obj;
}
function isCircle(obj: Geometry): obj is Circle {
return "radius" in obj;
}
// And much more...
function processGeometry(obj: Geometry): void {
if (isAARect(obj)) {
let width = obj.width;
// ...
}
if (isAABox(obj)) {
let halfDimX = obj.halfDimX;
// ...
}
else if (isCircle(obj)) {
let radius = obj.radius;
// ...
}
// And much more...
}
```
But again, I find this solution not really satisfying since it still creates persistent helpers functions just for the sake of the type inference and can be overkill for situations when we do not often need to perform type guards.
So, my proposal is to introduce a new syntax in order to _force_ the type of an identifier at a block-scope level.
``` ts
function processGeometry(obj: Geometry): void {
if ("width" in obj) {
assume obj is AARect;
let width = obj.width;
// ...
}
if ("halfDimX" in obj) {
assume obj is AABox;
let halfDimX = obj.halfDimX;
// ...
}
else if ("radius" in obj) {
assume obj is Circle;
let radius = obj.radius;
// ...
}
// And much more...
}
```
Above, the syntax `assume <identifier> is <type>` gives the information to the type inference that inside the block, following this annotation, `<identifier>` has to be considered as `<type>`. No need to type cast any more. Such a way has the advantage over the previous techniques not to generate any code in the emitted JavaScript. And in my opinion, it is less tedious than creating dedicated helper functions.
This syntax can be simplified or changed. For instance we could just have :
`<identifier> is <obj>`
without a new keyword `assume`, but I am unsure this would be compliant with the current grammar and design goals of the TypeScript team.
Nevertheless, whatever any welcomed optimization, I think the general idea is relevant for making TypeScript clearer, less verbose in the source code and in the final JavaScript, and less tedious to write when we have to deal with union types.
| Suggestion,Revisit | high | Critical |
172,014,147 | youtube-dl | support for zoig.com and zoig channels | ## Please follow the guide below
- You will be asked some questions and requested to provide some information, please read them **carefully** and answer honestly
- Put an `x` into all the boxes [ ] relevant to your _issue_ (like that [x])
- Use _Preview_ tab to see how your issue will actually look like
---
### Make sure you are using the _latest_ version: run `youtube-dl --version` and ensure your version is _2016.08.19_. If it's not read [this FAQ entry](https://github.com/rg3/youtube-dl/blob/master/README.md#how-do-i-update-youtube-dl) and update. Issues with outdated version will be rejected.
- [X] I've **verified** and **I assure** that I'm running youtube-dl **2016.08.19**
### Before submitting an _issue_ make sure you have:
- [X] At least skimmed through [README](https://github.com/rg3/youtube-dl/blob/master/README.md) and **most notably** [FAQ](https://github.com/rg3/youtube-dl#faq) and [BUGS](https://github.com/rg3/youtube-dl#bugs) sections
- [X] [Searched](https://github.com/rg3/youtube-dl/search?type=Issues) the bugtracker for similar issues including closed ones
### What is the purpose of your _issue_?
- [ ] Bug report (encountered problems with youtube-dl)
- [X] Site support request (request for adding support for a new site)
- [ ] Feature request (request for a new functionality)
- [ ] Question
- [ ] Other
---
### The following sections concretize particular purposed issues, you can erase any section (the contents between triple ---) not applicable to your _issue_
---
### If the purpose of this _issue_ is a _bug report_, _site support request_ or you are not completely sure provide the full verbose output as follows:
Add `-v` flag to **your command line** you run youtube-dl with, copy the **whole** output and insert it here. It should look similar to one below (replace it with **your** log inserted between triple ```):
```
$ youtube-dl -v <your command line>
[debug] System config: []
[debug] User config: []
[debug] Command-line args: [u'-v', u'http://www.youtube.com/watch?v=BaW_jenozKcj']
[debug] Encodings: locale cp1251, fs mbcs, out cp866, pref cp1251
[debug] youtube-dl version 2016.08.19
[debug] Python version 2.7.11 - Windows-2003Server-5.2.3790-SP2
[debug] exe versions: ffmpeg N-75573-g1d0487f, ffprobe N-75573-g1d0487f, rtmpdump 2.4
[debug] Proxy map: {}
...
<end of log>
```
---
### If the purpose of this _issue_ is a _site support request_ please provide all kinds of example URLs support for which should be included (replace following example URLs by **yours**):
- Single video: https://www.youtube.com/watch?v=BaW_jenozKc
- Single video: https://youtu.be/BaW_jenozKc
- Playlist: https://www.youtube.com/playlist?list=PL4lCao7KL_QFVb7Iudeipvc2BCavECqzc
---
### Description of your _issue_, suggested solution and other information
Explanation of your _issue_ in arbitrary form goes here. Please make sure the [description is worded well enough to be understood](https://github.com/rg3/youtube-dl#is-the-description-of-the-issue-itself-sufficient). Provide as much context and examples as possible.
If work on your _issue_ required an account credentials please provide them or explain how one can obtain them.
Need site support for zoig.com
Example:
http://www.zoig.com/play/4821121-milf-cock-tits-pussy-sex-blowjob-cumshot-cream-dick
and zoig.com channels, example:
http://www.zoig.com/profile/sierracouple-videos
| site-support-request | low | Critical |
172,186,577 | go | runtime,cmd/compile: -buildmode=c-shared and dlopen-ing a shared library | consider the following `GOPATH`:
```
sh> tree .
.
βββ mylib.so
βββ src
βββ main.go
βββ my-cmd
βΒ Β βββ main.go
βββ pkg1
βΒ Β βββ pkg.go
βββ pkg2
βββ pkg.go
5 directories, 6 files
```
with:
``` go
// src/pkg1
package pkg1
import "fmt"
var Int = 0
var Map = make(map[string]int)
func init() {
fmt.Printf("pkg1.Int: %p\n", &Int)
fmt.Printf("pkg1.Map: %p\n", &Map)
}
```
``` go
// src/pkg2
package pkg2
import "C"
import (
"fmt"
"pkg1"
)
//export Load
func Load() {
fmt.Printf("pkg2.Load...\n")
}
func init() {
fmt.Printf(">>> pkg2: pkg1.Int: %p\n", &pkg1.Int)
fmt.Printf(">>> pkg2: pkg1.Map: %p\n", &pkg1.Map)
}
```
``` go
// src/my-cmd/main.go
package main
import "C"
import _ "pkg2"
func main() {}
```
and:
``` go
// src/main.go
package main
// #include <dlfcn.h>
// #cgo LDFLAGS: -ldl
// #include <stdlib.h>
// #include <stdio.h>
//
// void loadPlugin(void *lib) {
// void (*f)(void) = NULL;
// char *error = NULL;
// f = (void (*)(void))(dlsym(lib, "Load"));
// error = dlerror();
// if (f == NULL || error != NULL) {
// fprintf(stderr, "ERROR no such symbol!!! (%s)\n", error);
// return;
// }
// fprintf(stderr, "symbol 'Load' loaded...\n");
// (*f)();
// }
import "C"
import (
"fmt"
"log"
"pkg1"
"unsafe"
)
func main() {
fmt.Printf("main.pkg1.Int: %p\n", &pkg1.Int)
fmt.Printf("main.pkg1.Map: %p\n", &pkg1.Map)
fmt.Printf("loading DLL...\n")
cstr := C.CString("./mylib.so")
defer C.free(unsafe.Pointer(cstr))
h := C.dlopen(cstr, C.RTLD_NOW)
if h == nil {
log.Fatalf("error loading %s\n", C.GoString(cstr))
}
defer C.dlclose(h)
fmt.Printf("loading plugin...\n")
C.loadPlugin(h)
fmt.Printf("loading plugin... [done]\n")
}
```
running the following command, gives:
```
sh> go build -buildmode=c-shared -o mylib.so ./src/my-cmd && go run ./src/main.go
pkg1.Int: 0x728c48
pkg1.Map: 0x70e1e0
main.pkg1.Int: 0x728c48
main.pkg1.Map: 0x70e1e0
loading DLL...
loading plugin...
symbol 'Load' loaded...
pkg1.Int: 0x7f925f7f9a48
pkg1.Map: 0x7f925f7df038
>>> pkg2: pkg1.Int: 0x7f925f7f9a48
>>> pkg2: pkg1.Map: 0x7f925f7df038
pkg2.Load...
loading plugin... [done]
```
ie: the addresses of `pkg1.Int` and `pkg1.Map` are not the same when inspected from the `go.main()` or `pkg1.init` and when inspected from the dynamically loaded `mylib.so` shared library.
also, `pkg1.init()` is run twice.
here is my environment:
```
sh> go version
go version go1.7 linux/amd64
sh> go env
GOARCH="amd64"
GOBIN=""
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/home/binet/work/igo/src/github.com/go-interpreter/example/cshared-bug"
GORACE=""
GOROOT="/usr/lib/go"
GOTOOLDIR="/usr/lib/go/pkg/tool/linux_amd64"
CC="gcc"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build549233304=/tmp/go-build -gno-record-gcc-switches"
CXX="g++"
CGO_ENABLED="1"
```
from my reading of https://docs.google.com/document/d/1nr-TQHw_er6GOQRsF6T43GGhFDelrAP0NqSS_00RgZQ/edit# this shouldn't happen, even when using the `c-shared` buildmode instead of the `plugin` buildmode.
@ianlancetaylor @crawshaw : right ?
| NeedsInvestigation,early-in-cycle,compiler/runtime | low | Critical |
172,237,050 | TypeScript | probable bug in typeof type guard | **TypeScript Version:** 1.8.0
**Code**
``` ts
const numbers: {[key: string]: number} = {a: 1, b: 2};
const mixed: {[key: string]: number|string} = {a: 1, b: 'two'};
function test(something: {[key: string]: number|string}) {
Object.keys(something).forEach(k => {
if (typeof something[k] === 'number') {
Math.floor(something[k]);
} else {
something[k].toLowerCase();
}
});
}
test(numbers);
```
Link: https://www.typescriptlang.org/play/#src=const%20numbers%3A%20%7B%5Bkey%3A%20string%5D%3A%20number%7D%20%3D%20%7Ba%3A%201%2C%20b%3A%202%7D%3B%0D%0A%0D%0Aconst%20mixed%3A%20%7B%5Bkey%3A%20string%5D%3A%20number%7Cstring%7D%20%3D%20%7Ba%3A%201%2C%20b%3A%20'two'%7D%3B%0D%0A%0D%0Afunction%20test(something%3A%20%7B%5Bkey%3A%20string%5D%3A%20number%7Cstring%7D)%20%7B%0D%0A%20%20Object.keys(something).forEach(k%20%3D%3E%20%7B%0D%0A%20%20%20%20%20%20%20%20if%20(typeof%20something%5Bk%5D%20%3D%3D%3D%20'number')%20%7B%0D%0A%20%20%20%20%20%20%20%20%20%20%20%20Math.floor(something%5Bk%5D)%3B%0D%0A%20%20%20%20%20%20%20%20%7D%20else%20%7B%0D%0A%20%20%20%20%20%20%20%20%20%20%20%20something%5Bk%5D.toLowerCase()%3B%0D%0A%20%20%20%20%20%20%20%20%7D%0D%0A%20%20%7D)%3B%0D%0A%7D%0D%0A%0D%0Atest(numbers)%3B
**Expected behavior:**
Type guard would apply to `something[k]`.
**Actual behavior:**
Type guard does not get applied to `something[k]`.
| Bug | low | Critical |
172,245,399 | vscode | Support Windows Narrator for screen reading | - VSCode Version: 1.4.0
- OS Version: Windows
Hi,
I'm trying to test Accessibility on VSCode. I found that VsCode doesn't support Windows Narrator. However, I was able to use NVDA tool. It works perfectly fine.
Is this the known issue ? It's working fine on mac os with voiceover utility
| feature-request,upstream,accessibility,electron,a11ymas | medium | Major |
Subsets and Splits
No saved queries yet
Save your SQL queries to embed, download, and access them later. Queries will appear here once saved.