id
int64
393k
2.82B
repo
stringclasses
68 values
title
stringlengths
1
936
body
stringlengths
0
256k
labels
stringlengths
2
508
priority
stringclasses
3 values
severity
stringclasses
3 values
157,412,105
rust
Trailing semicolon silently ignored in expr macro
``` fn main() { macro_rules! a { ($e:expr) => { $e; } } a!(true) } ``` Error: Expected `()`, found `bool` But: ``` fn main() { macro_rules! a { ($e:expr) => { $e; } } a!(true); // <-- semicolon } ``` does not warn that the `;` is ignored. So either - there should be a warning that the `;` has no effect in the macro, or - the `;` inside the macro should turn the expression into `()`.
A-macros,C-bug
low
Critical
157,477,619
youtube-dl
pluralsight "skill"
It would be awesome if also the "skills" url could be grabbed The "skills" are a group of courses. Link sample https://app.pluralsight.com/paths/skill/docker
request,account-needed
low
Major
157,495,417
rust
Cannot create function reference with parameters that don't have to outlive the functions lifetime
List of things tried (that I remember): - Using the same lifetime for both the closure reference and it's parameters renders the reference uncallable: https://is.gd/CpXw0w - Using different lifetimes for the closure reference and it's parameters fails to compile, since the parameters must _outlive_ the closure itself: https://is.gd/q5mJly - Using [Higher-Rank Trait Bounds](https://doc.rust-lang.org/nomicon/hrtb.html) works, but is infeasible since it requires the parameter references types to be defined directly where the closure reference itself is defined: https://is.gd/genxSf Since anything is better than `unsafe { transmute(parameter_reference) }`, I'd appreciate any comments on how to properly implement this.
A-lifetimes,C-bug,T-types
low
Minor
157,538,814
go
x/mobile/exp/audio: Windows support
# The problem The [current al implementation](https://github.com/golang/mobile/tree/master/exp/audio/al) does not allow for Windows builds. A while ago I posted [this](https://groups.google.com/forum/#!topic/golang-nuts/mfaRRJc1-gI) on the forums. # The fix This feels a bit hacky, but I managed to update the C-import stuff to this (on both the `al_notandroid.go` and `alc_notandroid.go` file, and updating all build tags to include Windows): ``` C #cgo darwin CFLAGS: -DGOOS_darwin #cgo linux CFLAGS: -DGOOS_linux #cgo windows CFLAGS: -DGOOS_windows -I E:/src/golang.org/x/mobile/exp/audio/al/include/ #cgo darwin LDFLAGS: -framework OpenAL #cgo linux LDFLAGS: -lopenal #cgo windows,386 LDFLAGS: E:/src/golang.org/x/mobile/exp/audio/al/bin/Win32/soft_oal.dll #cgo windows,amd64 LDFLAGS: E:/src/golang.org/x/mobile/exp/audio/al/bin/Win64/soft_oal.dll #ifdef GOOS_darwin #include <stdlib.h> #include <OpenAL/alc.h> #endif #ifdef GOOS_linux #include <stdlib.h> #include <AL/alc.h> #endif #ifdef GOOS_windows #include <stdlib.h> #include <AL/alc.h> #endif ``` # The caveats 1. I have no idea how to replace `E:` by something like `$GOPATH` (since `GOPATH == E:`), maybe someone knows? 2. Those `bin` and `include` directories that are expected to be within the directory, are those from the binaries from https://github.com/kcat/openal-soft . Not sure if we can safely redistribute those? (licensing etc.) 3. If Go cannot redistribute those files (I dunno, could be the case), would there be _any_ way to allow people to do this themselves? Without having to fork the al implementation? Or could we reference some kind of path and expect Windows-developers to put those files there? I don't need any attribution, therefore there's no PR associated, but it would be nice to let this "fix" be part of Go, instead of having to fork it.
OS-Windows,mobile
low
Major
157,689,630
kubernetes
Scheduling of pods with RWO volumes
Since RWO volumes work only on a single host, wouldn't it be reasonable for the scheduler to schedule pods for a {RC,RS,D,etc.} that uses such a volume on the same node? Otherwise, pods that land on different nodes are essentially blocked. Deployments are the most affected since you can have a Deployment with just one pod and maxSurge=1 (which is actually the default currently) and with a RWO volume, it will block. @kubernetes/sig-scheduling @kubernetes/deployment @kubernetes/sig-storage
priority/important-soon,sig/scheduling,sig/storage,kind/feature,lifecycle/frozen
high
Critical
157,707,489
youtube-dl
Site support request: ComedyCentral UK
Example URL: http://www.comedycentral.co.uk/friends/articles/sitcom-cameos. The site is geo-restricted to the UK.
site-support-request,geo-restricted
low
Minor
157,733,937
go
cmd/vet: check for duplicate cases in switches
Consider: ``` go type A [1]int func f(x A) { switch x { case A([1]int{1}): case A([1]int{1}): } } ``` This is almost certainly a typo; the second case is unreachable. The compiler may reject duplicate constant cases in expression switches, but not e.g. `nil` or composite literals containing constants. (See #15896 for discussion.) Perhaps cmd/vet should step in to help catch these likely bugs. This issue is a reminder to investigate.
Analysis
low
Critical
157,739,511
go
cmd/vet: printf findings can be arbitrarily long
When vet reports a printf problem such as this one: ``` fmt.Printf("%d", func() { ... }) // arg in printf call is a function value, not a function call ``` it prints out the entire body of the function literal, which can be quite long. For example, given the program at https://play.golang.org/p/f8W0zpISww, vet prints ``` % go vet ~/a.go ../../../../a.go:6: arg func() { println("blah") println("blah") println("blah") ... dozens more lines... println("blah") println("blah") println("blah") } in printf call is a function value, not a function call ``` Perhaps it should not print the function body at all.
NeedsDecision,Analysis
low
Minor
157,742,103
youtube-dl
Add support for jizzbunker.com
## Please follow the guide below - You will be asked some questions and requested to provide some information, please read them **carefully** and answer honestly - Put an `x` into all the boxes [ ] relevant to your _issue_ (like that [x]) - Use _Preview_ tab to see how your issue will actually look like --- ### Make sure you are using the _latest_ version: run `youtube-dl --version` and ensure your version is _2016.05.30.2_. If it's not read [this FAQ entry](https://github.com/rg3/youtube-dl/blob/master/README.md#how-do-i-update-youtube-dl) and update. Issues with outdated version will be rejected. - [x] I've **verified** and **I assure** that I'm running youtube-dl **2016.05.30.2** ### Before submitting an _issue_ make sure you have: - [x] At least skimmed through [README](https://github.com/rg3/youtube-dl/blob/master/README.md) and **most notably** [FAQ](https://github.com/rg3/youtube-dl#faq) and [BUGS](https://github.com/rg3/youtube-dl#bugs) sections - [x] [Searched](https://github.com/rg3/youtube-dl/search?type=Issues) the bugtracker for similar issues including closed ones ### What is the purpose of your _issue_? - [ ] Bug report (encountered problems with youtube-dl) - [x] Site support request (request for adding support for a new site) - [ ] Feature request (request for a new functionality) - [ ] Question - [ ] Other --- ### The following sections concretize particular purposed issues, you can erase any section (the contents between triple ---) not applicable to your _issue_ --- ### If the purpose of this _issue_ is a _bug report_, _site support request_ or you are not completely sure provide the full verbose output as follows: Add `-v` flag to **your command line** you run youtube-dl with, copy the **whole** output and insert it here. It should look similar to one below (replace it with **your** log inserted between triple ```): ``` $ youtube-dl -v <your command line> [debug] System config: [] [debug] User config: [] [debug] Command-line args: [u'-v', u'http://www.youtube.com/watch?v=BaW_jenozKcj'] [debug] Encodings: locale cp1251, fs mbcs, out cp866, pref cp1251 [debug] youtube-dl version 2016.05.30.2 [debug] Python version 2.7.11 - Windows-2003Server-5.2.3790-SP2 [debug] exe versions: ffmpeg N-75573-g1d0487f, ffprobe N-75573-g1d0487f, rtmpdump 2.4 [debug] Proxy map: {} ... <end of log> ``` --- ### If the purpose of this _issue_ is a _site support request_ please provide all kinds of example URLs support for which should be included (replace following example URLs by **yours**): - Single video: https://www.youtube.com/watch?v=BaW_jenozKc - Single video: https://youtu.be/BaW_jenozKc - Playlist: https://www.youtube.com/playlist?list=PL4lCao7KL_QFVb7Iudeipvc2BCavECqzc --- ### Description of your _issue_, suggested solution and other information Explanation of your _issue_ in arbitrary form goes here. Please make sure the [description is worded well enough to be understood](https://github.com/rg3/youtube-dl#is-the-description-of-the-issue-itself-sufficient). Provide as much context and examples as possible. If work on your _issue_ required an account credentials please provide them or explain how one can obtain them. --- Hi, Can you add support for jizzbunker.com ?
site-support-request
low
Critical
157,788,188
rust
Argument names in foreign functions, function types and trait methods are not resolved
Arguments in foreign functions, function types and traits are pattern bindings like all other function arguments and supposedly they should be resolved in the same way, however they are not resolved at all. It doesn't make _much_ difference because these bindings can't be used in function bodies, however it makes _some_ difference, for example foreign functions can reuse constant names for their arguments, while other functions can't (whether it's good or bad is a separate question). Accidentally, some function arguments being unresolved also affect lints like `non_snake_case`, such lints don't report warnings for them. This may be reasonable for foreign functions though, because such functions may follow foreign naming conventions. If this lint is "fixed" it may affects crates like `winapi` (cc @retep998). This is not so reasonable for trait methods however. Examples: ``` rust #![allow(dead_code, unused_variables)] const SOD: u8 = 0; const SOB: u8 = 0; const MOD: u8 = 0; const MDC: u8 = 0; const DRI: u8 = 0; // warning: variable `SOD` should have a snake case name // error: let variables cannot be named the same as const variables fn f(SOD: u8) {} trait Tr { // warning: variable `SOB` should have a snake case name // error: let variables cannot be named the same as const variables fn g(SOB: u8) {} // No warnings, no errors fn h(MOD: u8); } // No warnings, no errors type A = fn(MDC: u8); extern "C" { // No warnings, no errors fn k(DRI: u8); } fn main() { } ```
A-resolve,T-compiler,C-bug
low
Critical
157,820,043
youtube-dl
[Python3][Tumblr] Infinite redirect when using proxy feature
`version 2016.05.30.2` `youtube-dl -j "http://sythnmsvntn.tumblr.com/post/145116566731/little-kid-dancing-to-seventeens-pretty-u-this-is` **WITHOUT proxy:** Request 1: > GET /post/145116566731/ (why is youtube-dl removing part of the url here?) Response: > HTTP/1.1 301 Moved Permanently > Location: http://sythnmsvntn.tumblr.com/post/145116566731/little-kid-dancing-to-seventeens-pretty-u-this-is#_=_ Request 2: > GET /post/145116566731/little-kid-dancing-to-seventeens-pretty-u-this-is HTTP/1.1 OK, page is now sent and youtube-dl handles it correctly. **WITH proxy:** Same as before, but request 2 looks like this: > GET http://sythnmsvntn.tumblr.com/post/145116566731/little-kid-dancing-to-seventeens-pretty-u-this-is#_=_ Notice the not removed `#_=_` at the end. This causes tumblr to respond with yet another 301 redirect (as in first response) resulting in infinite loop: > ERROR: Unable to download webpage: HTTP Error 301: The HTTP server returned a redirect error that would lead to an infinite loop.
cant-reproduce
low
Critical
157,820,099
youtube-dl
Allow rendering subtitles besides simply adding a subtitle stream (was: Feature request "-f bestsubtitle")
## Please follow the guide below - You will be asked some questions and requested to provide some information, please read them **carefully** and answer honestly - Put an `x` into all the boxes [ ] relevant to your _issue_ (like that [x]) - Use _Preview_ tab to see how your issue will actually look like --- ### Make sure you are using the _latest_ version: run `youtube-dl --version` and ensure your version is _2016.05.30.2_. If it's not read [this FAQ entry](https://github.com/rg3/youtube-dl/blob/master/README.md#how-do-i-update-youtube-dl) and update. Issues with outdated version will be rejected. - [x] I've **verified** and **I assure** that I'm running youtube-dl **2016.05.30.2** ### Before submitting an _issue_ make sure you have: - [x] At least skimmed through [README](https://github.com/rg3/youtube-dl/blob/master/README.md) and **most notably** [FAQ](https://github.com/rg3/youtube-dl#faq) and [BUGS](https://github.com/rg3/youtube-dl#bugs) sections - [ ] [Searched](https://github.com/rg3/youtube-dl/search?type=Issues) the bugtracker for similar issues including closed ones ### What is the purpose of your _issue_? - [ ] Bug report (encountered problems with youtube-dl) - [ ] Site support request (request for adding support for a new site) - [x] Feature request (request for a new functionality) - [ ] Question - [ ] Other --- ### The following sections concretize particular purposed issues, you can erase any section (the contents between triple ---) not applicable to your _issue_ --- ### If the purpose of this _issue_ is a _bug report_, _site support request_ or you are not completely sure provide the full verbose output as follows: Add `-v` flag to **your command line** you run youtube-dl with, copy the **whole** output and insert it here. It should look similar to one below (replace it with **your** log inserted between triple ```): ``` $ youtube-dl -v <your command line> [debug] System config: [] [debug] User config: [] [debug] Command-line args: [u'-v', u'http://www.youtube.com/watch?v=BaW_jenozKcj'] [debug] Encodings: locale cp1251, fs mbcs, out cp866, pref cp1251 [debug] youtube-dl version 2016.05.30.2 [debug] Python version 2.7.11 - Windows-2003Server-5.2.3790-SP2 [debug] exe versions: ffmpeg N-75573-g1d0487f, ffprobe N-75573-g1d0487f, rtmpdump 2.4 [debug] Proxy map: {} ... <end of log> ``` --- ### If the purpose of this _issue_ is a _site support request_ please provide all kinds of example URLs support for which should be included (replace following example URLs by **yours**): - Single video: https://www.youtube.com/watch?v=BaW_jenozKc - Single video: https://youtu.be/BaW_jenozKc - Playlist: https://www.youtube.com/playlist?list=PL4lCao7KL_QFVb7Iudeipvc2BCavECqzc --- ### Description of your _issue_, suggested solution and other information there are already `-f` parameters `bestvideo` and `bestaudio` but i wonder why there is no `bestsub` or `bestsubtitle` to help burn subtitles into video files For example: ``` bash -f "bestvideo[ext=mp4]+bestaudio[ext=m4a]+bestsubtitle[ext=vtt]/best" ``` will burn both best audio and best subtitle into the mp4 file. - `--write-auto-sub` option should be automatically used if `bestsubtitle` is invoked but no subtitle is available - if `bestsubtitle` is invoked without `bestvideo` and `bestaudio`, download best subtitle only
request,subtitles
medium
Critical
157,886,686
rust
The `meta` fragment specifier is considered as a single TT.
At various locations of the FOLLOW sets analysis for `macro_rules!`, `meta` is considered as always matching a single TT. This is not the case: `ident = ...` and `ident(...)` are both valid `meta`s. That being said the only consequence of this is that `meta` can be followed by anything, and I think it's not unreasonable to assume that the syntax of `meta` will not be expanded in the future... But still, we might want to check that.
A-macros,C-bug
low
Minor
157,980,587
rust
[rustdoc] Rustdoc should prevent long file names.
I'm not actually certain if handling absurdly long method names should be a goal for rustdoc, but currently they produce filenames that are too long for the filesystem. I discovered this while working with [opencv-rust](https://github.com/kali/opencv-rust) which auto generates c-wrapper methods for opencv, some of which have very long names. A possible proposed solution was that rustdoc abbreviate filenames, I suggest that a good solution might be splitting the name into 255 char chunks. Eg the problem file: `/home/benjamin/dev/opencv-rust/target/doc/opencv/sys/fn.cv_calib3d_cv_solvePnPRansac_InputArray_objectPoints_InputArray_imagePoints_InputArray_cameraMatrix_InputArray_distCoeffs_OutputArray_rvec_OutputArray_tvec_bool_useExtrinsicGuess_int_iterationsCount_float_reprojectionError_int_minInliersCount_OutputArray_inliers_int_flags.html` Would become something like: `/home/benjamin/dev/opencv-rust/target/doc/opencv/sys/fn.cv_calib3d_cv_solvePnPRansac_InputArray_objectPoints_InputArray_imagePoints_InputArray_cameraMatrix_InputArray_distCoeffs_OutputArray_rvec_OutputArray_tvec_bool_useExtrinsicGuess_int_iterationsCount_float_reprojectionErr/or_int_minInliersCount_OutputArray_inliers_int_flags.html` Previous discussion on the rust subreddit: https://www.reddit.com/r/rust/comments/4m29tk/solution_to_file_name_too_long_for_cargo_doc/
T-rustdoc,C-feature-request
low
Critical
158,015,930
youtube-dl
Add Support for Hubspot Academy
I ran the update command, but it updated to 2016.5.30.2. - [X] I've **verified** and **I assure** that I'm running youtube-dl **2016.5.30.2** - [X] At least skimmed through [README](https://github.com/rg3/youtube-dl/blob/master/README.md) and **most notably** [FAQ](https://github.com/rg3/youtube-dl#faq) and [BUGS](https://github.com/rg3/youtube-dl#bugs) sections - [X] [Searched](https://github.com/rg3/youtube-dl/search?type=Issues) the bugtracker for similar issues including closed ones - [X] Bug report (encountered problems with youtube-dl) - [X] Site support request (request for adding support for a new site) ``` ➜ ~ youtube-dl -v http://academy.hubspot.com/ic16/essentials-of-an-effective-inbound-strategy [debug] System config: [] [debug] User config: [] [debug] Command-line args: [u'-v', u'http://academy.hubspot.com/ic16/essentials-of-an-effective-inbound-strategy'] [debug] Encodings: locale UTF-8, fs UTF-8, out UTF-8, pref UTF-8 [debug] youtube-dl version 2016.05.30.2 [debug] Python version 2.7.10 - Linux-4.2.0-36-generic-x86_64-with-Ubuntu-15.10-wily [debug] exe versions: ffmpeg 2.7.6-0ubuntu0.15.10.1, ffprobe 2.7.6-0ubuntu0.15.10.1 [debug] Proxy map: {} [generic] essentials-of-an-effective-inbound-strategy: Requesting header WARNING: Falling back on generic information extractor. [generic] essentials-of-an-effective-inbound-strategy: Downloading webpage [generic] essentials-of-an-effective-inbound-strategy: Extracting information [Wistia] 87h8tffa9w: Downloading JSON metadata ERROR: Error while getting the playlist Traceback (most recent call last): File "/usr/local/lib/python2.7/dist-packages/youtube_dl/YoutubeDL.py", line 676, in extract_info ie_result = ie.extract(url) File "/usr/local/lib/python2.7/dist-packages/youtube_dl/extractor/common.py", line 341, in extract return self._real_extract(url) File "/usr/local/lib/python2.7/dist-packages/youtube_dl/extractor/wistia.py", line 49, in _real_extract 'Error while getting the playlist', expected=True) ExtractorError: Error while getting the playlist ``` I've tested this in 2 countries...
bug
low
Critical
158,019,131
go
reflect: StructOf doesn't generate wrapper methods for embedded fields
``` % go version go version devel +bbd1dcd Wed Jun 1 21:32:46 2016 +0000 linux/amd64 % cat ~/a.go package main import ( "bytes" "io" "reflect" "sync" ) func main() { t := reflect.StructOf([]reflect.StructField{ {Type: reflect.TypeOf(sync.Mutex{}), Anonymous: true}, {Type: reflect.TypeOf(bytes.Buffer{}), Anonymous: true}, }) x := reflect.New(t).Interface() _ = x.(io.Writer) } % go run ~/a.go panic: interface conversion: *truct { sync.Mutex; bytes.Buffer } is not io.Writer: missing method Write ``` I expected that x would have generated wrapper methods for Mutex.Lock, etc. Interestingly, adding this declaration inside func main (not at package level): ``` var _ interface{} = new(struct { sync.Mutex bytes.Buffer }) ``` causes the program to succeed. Presumably it causes the compiler to generate the correct type information, which `reflect.StructOf` then finds.
NeedsFix,compiler/runtime
medium
Major
158,022,097
go
cmd/compile: SSA performance regression due to array zeroing
go version devel +bbd1dcd Wed Jun 1 21:32:46 2016 +0000 darwin/amd64 https://github.com/hydroflame/go1.7bench This very simple program take 2 4 element vector and performs component wise addition. If you run the benchmark with SSA and without you will see that it is much faster without SSA. ``` $ go test -run NONE -bench . -gcflags -ssa=0 > nossa.txt testing: warning: no tests to run $ go test -run NONE -bench . -gcflags -ssa=1 > ssa.txt testing: warning: no tests to run $ benchcmp nossa.txt ssa.txt benchmark old ns/op new ns/op delta BenchmarkAdd-4 2.45 11.4 +365.31% ``` I expect that the binary generated with SSA would be at least the same speed as the old one. This particular example is extracted from one of my bigger library: `github.com/luxengine/glm` for more example of SSA bad performance run benchmarks in - github.com/luxengine/glm - github.com/luxengine/glm/geo
Performance,NeedsFix,compiler/runtime
low
Major
158,040,788
youtube-dl
Show the title of excluded videos (was: How To Use The "forcetitle" Option)
- [x] I've **verified** and **I assure** that I'm running youtube-dl **2016.06.02** ### Before submitting an _issue_ make sure you have: - [x] At least skimmed through [README](https://github.com/rg3/youtube-dl/blob/master/README.md) and **most notably** [FAQ](https://github.com/rg3/youtube-dl#faq) and [BUGS](https://github.com/rg3/youtube-dl#bugs) sections - [x] [Searched](https://github.com/rg3/youtube-dl/search?type=Issues) the bugtracker for similar issues including closed ones ### What is the purpose of your _issue_? - [ ] Bug report (encountered problems with youtube-dl) - [ ] Site support request (request for adding support for a new site) - [ ] Feature request (request for a new functionality) - [x] Question - [ ] Other --- ### Description of your _issue_, suggested solution and other information I'm testing some searches with youtube-dl using the --dateafter option. Whenever a video is excluded due to the --dateafter option it gives the generic message "upload date is not in range" but doesn't include the title of the video or any other information. Is there a way to force it to print the title of the video that was excluded? I tried --forcetitle that I thought I found in the source code on the github page https://github.com/rg3/youtube-dl/blob/master/youtube_dl/YoutubeDL.py , but that didn't work. Thank you!
request
low
Critical
158,122,990
rust
Immutable borrow as argument for mutable borrow does not compile
I have the following piece of code which I expect to work but the borrow checker does not agree: ``` fn main() { let mut data = vec![1; 100]; { let (left, right) = data.split_at_mut(data.len() / 2); } println!("{:?}", data); } ``` Please note that the extra scope is in principle not related to the issue I'm describing, I'm just doing it such that I can use the `println!` macro to ensure that the compiler does not optimize the code away because I'm not using it thereafter. (I'm new to Rust so I don't know the exact rules) The error I get is the following: ``` main.rs:4:47: 4:51 error: cannot borrow `data` as immutable because it is also borrowed as mutable [E0502] main.rs:4 let (left, right) = data.split_at_mut(data.len() / 2); ^~~~ main.rs:4:29: 4:33 note: previous borrow of `data` occurs here; the mutable borrow prevents subsequent moves, borrows, or modification of `data` until the borrow ends main.rs:4 let (left, right) = data.split_at_mut(data.len() / 2); ^~~~ main.rs:5:6: 5:6 note: previous borrow ends here main.rs:3 { main.rs:4 let (left, right) = data.split_at_mut(data.len() / 2); main.rs:5 } ^ ``` However what I would expect is the following: 1. `data.len()` takes an immutable borrow. 2. `data.len()` returns the immutable borrow and divides the obtained `u32` by `2`. 3. `data.split_at_mut()` takes a mutable borrow. It seems like the borrow checker currently evaluates the statement in the wrong order. The following workaround is available, but it feels like this is a place where we should not have the need to (rightfully) fight the borrow checker. ``` fn main() { let mut data = vec![1; 100]; { let len = data.len(); let (left, right) = data.split_at_mut(len / 2); } println!("{:?}", data); } ```
A-borrow-checker,T-compiler,C-bug
low
Critical
158,134,290
react
Changing state in onFocus and onChange for a select multiple element does not work in Firefox
I want to use a controlled `<select multiple={true} />` component in React. In addition to the value I also want to keep the focused state of the select in the state. To do this, I update the state with `setState` in the `onChange`, `onFocus` and `onBlur` event handlers. Unfortunately there is an issue in Firefox: Firefox will only update the value on a change event after the select has gained focus. This means that a user has to click twice on the select element to change its value when it does not have focus. I would expect the select to gain focus and change the value at the same click. I created a jsFiddle to demonstrate the prolem: [React select multiple issue in Firefox demonstration](https://jsfiddle.net/fugf1kw9/2/) I only see this problem in Firefox and with select multiple. In IE and Chrome it is working as expected, and in Firefox it is working as expected for other form elements (simple select, checkbox, radio, text input, textarea). My environment: - Firefox 46.0.1 under Win7 x64 - React 15.1.0
Type: Bug,Component: DOM
low
Major
158,151,643
youtube-dl
add support for volafile.io - rip entire room / all movie files
example URL `https://volafile.io/r/08wJOs` warning URL only temporary and will expire
site-support-request
low
Major
158,190,038
go
runtime: main_init_done can be implemented more efficiently
A C thread in a -buildmode={c-archive,c-shared} may call back into Go code before Go initialization is complete, in which case it must wait. It currently waits using a channel called `main_init_done`. In the review of https://golang.org/cl/23610 Dmitry points out that this can be done more efficiently. The callback will necessarily go through `runtime·needm`. We can arrange for `needm` to wait for initialization to be complete. It already waits for a new `M` to be created. In fact, `needm` already has a race condition. It crashes if `cgoHasExtraM` is not true. That global variable is set to true early in Go initialization, but that initialization will be running in a separate thread. If a C thread is fast enough in calling Go, the program will crash because Go initialization has not yet reached the required point. We should avoid crashing if `islibrary || isarchive`; we should simply wait.
Performance,NeedsFix,compiler/runtime
low
Critical
158,284,783
rust
Provide mechanism for documenting known bugs or shortcomings
Go has a [fairly poorly documented](https://github.com/golang/go/issues/5060) feature that lines marked with `BUG` are shown under "Bugs" in documentation for a package. The keywords can be configured using the (again poorly documented) `-notes` argument to [`godoc`](https://godoc.org/golang.org/x/tools/cmd/godoc). This can be used to document known bugs and shortcomings of a package alongside the package's main documentation. For examples, see the bottom of [`net`](https://golang.org/pkg/net/), [`sync/atomic`](https://golang.org/pkg/sync/atomic/), or [`encoding/xml`](https://golang.org/pkg/encoding/xml/). Having a similar feature in `rustdoc` would be really useful, as it establishes a standard way of communicating known problems, which could prevent unnecessary bug reports, and encourage dialogue about known limitations. If it were also possible to link to the discussion for a given feature or bug, that would make it even better. Thoughts?
T-rustdoc,C-feature-request
low
Critical
158,305,270
youtube-dl
Blogspot falls back on generic
### What is the purpose of your _issue_? - [ ] Bug report (encountered problems with youtube-dl) - [x] Site support request (request for adding support for a new site) - [ ] Feature request (request for a new functionality) - [ ] Question - [ ] Other ``` youtube-dl --ignore-config --v http://vida420armonia.blogspot.com/2015/02/blog-post_18.html ``` ``` [debug] System config: [] [debug] User config: ['--download-archive', '~/.ytdlarchive', '--retries', '100', '--no-overwrites', '--call-home', '--continue', '--write-info-json', '--write-description', '--write-thumbnail', '--write-annotations', '--all-subs', '--write-sub', '--add-metadata', '-f', 'bestvideo+bestaudio/best', '--merge-output-format', 'mkv', '--prefer-ffmpeg', '--embed-thumbnail'] [debug] Command-line args: ['-v', 'http://vida420armonia.blogspot.com/2015/02/blog-post_18.html'] [debug] Encodings: locale UTF-8, fs utf-8, out UTF-8, pref UTF-8 [debug] youtube-dl version 2016.05.30.2 [debug] Python version 3.5.1+ - Linux-4.4.0-22-generic-x86_64-with-Ubuntu-16.04-xenial [debug] exe versions: ffmpeg 2.8.6-1ubuntu2, ffprobe 2.8.6-1ubuntu2, rtmpdump 2.4 [debug] Proxy map: {} [debug] Public IP address: 172.58.169.123 WARNING: You are using an outdated version (newest version: 2016.06.02)! See https://yt-dl.org/update if you need help updating. [generic] blog-post_18: Requesting header WARNING: Falling back on generic information extractor. [generic] blog-post_18: Downloading webpage [generic] blog-post_18: Extracting information ERROR: Unsupported URL: http://vida420armonia.blogspot.com/2015/02/blog-post_18.html Traceback (most recent call last): File "/usr/local/lib/python3.5/dist-packages/youtube_dl/YoutubeDL.py", line 676, in extract_info ie_result = ie.extract(url) File "/usr/local/lib/python3.5/dist-packages/youtube_dl/extractor/common.py", line 341, in extract return self._real_extract(url) File "/usr/local/lib/python3.5/dist-packages/youtube_dl/extractor/generic.py", line 2134, in _real_extract raise UnsupportedError(url) youtube_dl.utils.UnsupportedError: Unsupported URL: http://vida420armonia.blogspot.com/2015/02/blog-post_18.html ```
site-support-request
low
Critical
158,367,498
youtube-dl
Add site-support for akibapass.de
## Please follow the guide below - You will be asked some questions and requested to provide some information, please read them **carefully** and answer honestly - Put an `x` into all the boxes [ ] relevant to your _issue_ (like that [x]) - Use _Preview_ tab to see how your issue will actually look like --- ### Make sure you are using the _latest_ version: run `youtube-dl --version` and ensure your version is _2016.06.02_. If it's not read [this FAQ entry](https://github.com/rg3/youtube-dl/blob/master/README.md#how-do-i-update-youtube-dl) and update. Issues with outdated version will be rejected. - [x] I've **verified** and **I assure** that I'm running youtube-dl **2016.06.02** ### Before submitting an _issue_ make sure you have: - [x] At least skimmed through [README](https://github.com/rg3/youtube-dl/blob/master/README.md) and **most notably** [FAQ](https://github.com/rg3/youtube-dl#faq) and [BUGS](https://github.com/rg3/youtube-dl#bugs) sections - [x] [Searched](https://github.com/rg3/youtube-dl/search?type=Issues) the bugtracker for similar issues including closed ones ### What is the purpose of your _issue_? - [ ] Bug report (encountered problems with youtube-dl) - [x] Site support request (request for adding support for a new site) - [ ] Feature request (request for a new functionality) - [ ] Question - [ ] Other --- ### The following sections concretize particular purposed issues, you can erase any section (the contents between triple ---) not applicable to your _issue_ --- ### If the purpose of this _issue_ is a _bug report_, _site support request_ or you are not completely sure provide the full verbose output as follows: Add `-v` flag to **your command line** you run youtube-dl with, copy the **whole** output and insert it here. It should look similar to one below (replace it with **your** log inserted between triple ```): ``` $ youtube-dl -v <your command line> [debug] System config: [] [debug] User config: [] [debug] Command-line args: [u'-v', u'http://www.youtube.com/watch?v=BaW_jenozKcj'] [debug] Encodings: locale cp1251, fs mbcs, out cp866, pref cp1251 [debug] youtube-dl version 2016.06.02 [debug] Python version 2.7.11 - Windows-2003Server-5.2.3790-SP2 [debug] exe versions: ffmpeg N-75573-g1d0487f, ffprobe N-75573-g1d0487f, rtmpdump 2.4 [debug] Proxy map: {} ... <end of log> ``` --- ### If the purpose of this _issue_ is a _site support request_ please provide all kinds of example URLs support for which should be included (replace following example URLs by **yours**): - Single video: https://www.youtube.com/watch?v=BaW_jenozKc - Single video: https://youtu.be/BaW_jenozKc - Playlist: https://www.youtube.com/playlist?list=PL4lCao7KL_QFVb7Iudeipvc2BCavECqzc --- Hi, I would like to request support for the german anime portal http://www.akibapass.de It is offering a free test period around 1 month so if account is necessary it can be created for free Best regards, Sadaou
site-support-request,geo-restricted
low
Critical
158,449,660
youtube-dl
Site support request: TYTNetwork
Example url: https://www.tytnetwork.com/2016/05/18/wtf-money-monster/ Note that some urls, like [this one](https://www.tytnetwork.com/2016/05/25/verizon-strikers-take-poster-child-corporate-greed/), are YouTube-embeds, which the generic extractor catch
site-support-request
low
Minor
158,491,071
opencv
Error using -baseFormatSave
Hi, I'm working with OpenCV 2.4.9 on Ubuntu 16.04. I tried to create my own cascade file with opencv_traincascade but for my application I need that the .xml is saved on the old format (opencv_haartraining). I tried to use the -baseFormatSave argument for this but when it finishes the training this error appears: ``` OpenCV Error: Unknown error code -6 (old file format is used for Haar-like features only) in save, file /home/mnl/opencv-2.4.9/apps/traincascade/cascadeclassifier.cpp, line 437 terminate called after throwing an instance of 'cv::Exception' what(): /home/mnl/opencv-2.4.9/apps/traincascade/cascadeclassifier.cpp:437: error: (-6) old file format is used for Haar-like features only in function save ``` On terminal I'm writing: `opencv_traincascade -data data -vec cars.vec -bg bg.txt -numPos 500 -numNeg 500 -numStages 17 -w 48 -h 24 -featureType LBP -minHitRate 0.999 -baseFormatSave` Any ideas?
bug,category: apps
low
Critical
158,491,903
go
x/mobile: support multiple independent bindings in the same app
Please answer these questions before submitting your issue. Thanks! 1. What version of Go are you using (`go version`)? 1.5 2. What operating system and processor architecture are you using (`go env`)? windows amd64 3. What did you do? I make arr module by use gomobile bind common, but I have two different package hello and halou,so I do this: as follow gomobile bind -target=android golang.org/x/mobile/example/bind/hello gomobile bind -target=android golang.org/x/mobile/example/bind/halou I get two aar module,then import them by android studio , when I build apk,happen erro messsage Error:Error converting bytecode to dex: Cause: com.android.dex.DexException: Multiple dex files define Lgo/LoadJNI; :app:transformClassesWithDexForDebug FAILED Error:Execution failed for task ':app:transformClassesWithDexForDebug'. > com.android.build.api.transform.TransformException: com.android.ide.common.process.ProcessException: java.util.concurrent.ExecutionException: com.android.ide.common.process.ProcessException: org.gradle.process.internal.ExecException: Process 'command 'D:\jdk\bin\java.exe'' finished with non-zero exit value 2 I know resason that two arr include two jar file,but them have same LoadJNI.class and Seq.class, so conflict! I want to know that how to resolve it by good way?
NeedsInvestigation,mobile
medium
Critical
158,492,263
youtube-dl
[vk] Add support for 1tv embeds
### Make sure you are using the _latest_ version: run `youtube-dl --version` and ensure your version is _2016.06.03_. If it's not read [this FAQ entry](https://github.com/rg3/youtube-dl/blob/master/README.md#how-do-i-update-youtube-dl) and update. Issues with outdated version will be rejected. - [x] I've **verified** and **I assure** that I'm running youtube-dl **2016.06.03** ### Before submitting an _issue_ make sure you have: - [x] At least skimmed through [README](https://github.com/rg3/youtube-dl/blob/master/README.md) and **most notably** [FAQ](https://github.com/rg3/youtube-dl#faq) and [BUGS](https://github.com/rg3/youtube-dl#bugs) sections - [x] [Searched](https://github.com/rg3/youtube-dl/search?type=Issues) the bugtracker for similar issues including closed ones ### What is the purpose of your _issue_? - [x] Bug report (encountered problems with youtube-dl) - [ ] Site support request (request for adding support for a new site) - [ ] Feature request (request for a new functionality) - [ ] Question - [ ] Other --- Add `-v` flag to **your command line** you run youtube-dl with, copy the **whole** output and insert it here. It should look similar to one below (replace it with **your** log inserted between triple ```): ``` D:\>youtube-dl --verbose https://vk.com/1tv?z=video-25380626_456239892%2Fvideos-25380626%2Fpl_-25380626_-2 [debug] System config: [] [debug] User config: [] [debug] Command-line args: ['--verbose', 'https://vk.com/1tv?z=video-25380626_456239892%2Fvideos-25380626%2Fpl_-25380626_-2'] [debug] Encodings: locale cp1251, fs mbcs, out cp866, pref cp1251 [debug] youtube-dl version 2016.06.03 [debug] Python version 3.5.1 - Windows-10-10.0.10586-SP0 [debug] exe versions: avconv 11.3, avprobe 11.3, ffmpeg N-78358-g674cc26, ffprobe N-78358-g674cc26, rtmpdump 2.4 [debug] Proxy map: {} [vk] -25380626_456239892: Downloading webpage ERROR: Unable to extract vars; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see https://yt-dl.org/update on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output. Traceback (most recent call last): File "c:\python35\lib\site-packages\youtube_dl\YoutubeDL.py", line 676, in extract_info ie_result = ie.extract(url) File "c:\python35\lib\site-packages\youtube_dl\extractor\common.py", line 341, in extract return self._real_extract(url) File "c:\python35\lib\site-packages\youtube_dl\extractor\vk.py", line 296, in _real_extract data_json = self._search_regex(r'var\s+vars\s*=\s*({.+?});', info_page, 'vars') File "c:\python35\lib\site-packages\youtube_dl\extractor\common.py", line 644, in _search_regex raise RegexNotFoundError('Unable to extract %s' % _name) youtube_dl.utils.RegexNotFoundError: Unable to extract vars; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see https://yt-dl.org/update on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output. ```
request
low
Critical
158,498,107
youtube-dl
Request: Add support for IMDb title page
IMDb is currently supported, but not for [title pages](http://www.imdb.com/title/tt1475582/). These often contain multiple videos. [This url](http://www.imdb.com/title/tt1475582/videogallery) contains all the videos from the title page.
request
low
Minor
158,499,564
opencv
Compile OpenCV 3.1.0 with ICC -mmic Xeon PHI
Hi all. I need to use OpenCV+FFMPEG in a Xeon Phi without root permission. My environment is: - OpenCV version: 3.1.0 - Host OS: Linux - Target OS: Phi Co-Processor - Compiler & CMake: ICC 15.0.2 & CMake 3.5.2 (installed in my home) When I compile OpenCV with GCC in my home, it works fine. I compile with cmake -D CMAKE_INSTALL_PREFIX=$HOME/lib/opencv-3.1.0 -D WITH_GTK=ON .. all works fine by setting LD_CONFIG_PATH and PKG_CONFIG_PATH env variables od ffmpeg and opencv. Now, i need to use my code in a PHi CoProcessor, so I compile my code with `icc -mmic -Wall -std=c++11 -DNO_DEFAULT_MAPPING -I /home/spm1407/lib/opencv-3.1.0/include/ -I /home/spm1501/fastflow/ -O3 -o farm farm.cpp -pthread -L/home/spm1407/lib/opencv-3.1.0/lib -lopencv_core -lopencv_highgui -lopencv_imgcodecs -lopencv_videoio -lopencv_video -lopencv_imgproc -lpthread` (Please ignore FastFlow) Compiler returns ``` x86_64-k1om-linux-ld: skipping incompatible /home/spm1407/lib/opencv-3.1.0/lib/libopencv_core.so when searching for -lopencv_core x86_64-k1om-linux-ld: cannot find -lopencv_core x86_64-k1om-linux-ld: skipping incompatible /home/spm1407/lib/opencv-3.1.0/lib/libopencv_highgui.so when searching for -lopencv_highgui x86_64-k1om-linux-ld: cannot find -lopencv_highgui x86_64-k1om-linux-ld: skipping incompatible /home/spm1407/lib/opencv-3.1.0/lib/libopencv_imgcodecs.so when searching for -lopencv_imgcodecs x86_64-k1om-linux-ld: cannot find -lopencv_imgcodecs x86_64-k1om-linux-ld: skipping incompatible /home/spm1407/lib/opencv-3.1.0/lib/libopencv_videoio.so when searching for -lopencv_videoio x86_64-k1om-linux-ld: cannot find -lopencv_videoio x86_64-k1om-linux-ld: skipping incompatible /home/spm1407/lib/opencv-3.1.0/lib/libopencv_video.so when searching for -lopencv_video x86_64-k1om-linux-ld: cannot find -lopencv_video x86_64-k1om-linux-ld: skipping incompatible /home/spm1407/lib/opencv-3.1.0/lib/libopencv_imgproc.so when searching for -lopencv_imgproc x86_64-k1om-linux-ld: cannot find -lopencv_imgproc ``` So, i'm trying to compile (maybe Cross-Compile, if i understood) OpenCV by setting compiler and flags of ICC: `../../cmake/bin/cmake -D CMAKE_BUILD_TYPE=RELEASE -D CMAKE_INSTALL_PREFIX=$HOME/lib/opencv-3.1.0 -D WITH_GTK=ON -DCMAKE_C_COMPILER=icc -DCMAKE_CXX_COMPILER=icpc -DWITH_CUDA=OFF -DCMAKE_TOOLCHAIN_FILE=../cmake_files/cmake_template.cmake -DCMAKE_C_FLAGS=-mmic -DCMAKE_CXX_FLAGS=-mmic -DBUILD_SHARED_LIBS=OFF -DWITH_PTHREADS_PF=OFF -DWITH_IPP=OFF ..` I tried disabling PTHREADS_PF, IPP, using CMAKE_TEMPLATE from [(this page](https://software.intel.com/en-us/articles/cross-compilation-for-intel-xeon-phi-coprocessor-with-cmake) but cmake every time returns ``` catastrophic error: cannot open source file "zlib.h" #include "zlib.h" ``` How can i resolve this issue? Any suggest? Thanks.
bug,priority: low,category: build/install
low
Critical
158,529,356
opencv
findContours documentation does not state how to find the first contour
When using the CV_RETR_TREE mode to retrieve the whole hierarchy of the contours in findContours(), the documentation is missing information on how to find the _first_ contour from which the links are to be followed. The first contour could be 0, but without documentation I cannot be sure. Because of this, I have to do a linear scan to make sure I will find all of the 0-level contours.
feature,category: imgproc,category: documentation
low
Major
158,537,769
go
cmd/go: go get download progress and download speed status
go 1.6 linux_amd_64 ### problem go get is an awesome tool download and install repositories from websites. But the problem is many times due bad internet connection or varying internet speed or a large repository it takes a lot of time.All we can do is look at blinking the cursor and there is no way to know how much code has been downloaded or is it installing or downloading . ### feature request I would like to request this feature of percentage of completed download and download speed status in go get tool. It will be very helpful for gophers with slow internet access.
NeedsInvestigation
high
Major
158,564,968
go
all: combine broken up DATA statements in assembly
During the 1.7 cycle, @mdempsky made it possible to have long DATA statements in assembly. For 1.8, let's clean up all the assembly. Not a priority, but easy and pleasing. It would also have allowed spellcheckers that people run occasionally to catch #15962.
NeedsFix
low
Critical
158,577,766
youtube-dl
Site support request: m2m.tv
youtube-dl is unable to extract videos from m2m.tv. Tested with 2016.06.03. I'd like to request support. Example URL of a video: https://m2m.tv/watch/vivienne-westwood-do-it-yourself/films Index of available videos: https://m2m.tv/films Thanks!
site-support-request
low
Major
158,592,498
go
x/build/cmd/relui: create GitHub releases
GitHub has a ["releases" feature](https://help.github.com/articles/creating-releases/) that provides downloadable releases in a well-known location. We could make Go releases available via GitHub as well as our [download page](https://golang.org/dl/). Assuming we want to do so, we could modify the `release` tool to create and populate those releases for us automatically. But do we want to do this? What are the advantages? What are the disadvantages?
Builders,NeedsDecision,FeatureRequest
medium
Major
158,757,190
go
cmd/cgo: undefined reference when linking a program that refers to SIG_DFL.
cgo appears to be unable to link Go programs that refer to SIG_DFL or SIG_IGN. (This is admittedly an esoteric use-case, since Go programs should generally not be using signal.h in any way. However, it may be a symptom of some other bug around cgo's handling of function pointers and macros.) Platform: ``` sh $ go version go version go1.6.1 linux/amd64 $ uname -srio Linux 3.13.0-83-generic x86_64 GNU/Linux ``` Source: ``` go $ cat src/sig_dfl/sigdfl.go package main import "fmt" /* #include <signal.h> static const void* sig_dfl = SIG_DFL; */ import "C" func main() { fmt.Println(C.SIG_DFL) fmt.Println(C.sig_dfl) } ``` Error: ``` $ go build sig_dfl # sig_dfl /tmp/go-build592850176/sig_dfl/_obj/_cgo_main.o:(.data.rel+0x0): undefined reference to `sig_dfl' /tmp/go-build592850176/sig_dfl/_obj/_cgo_main.o:(.data.rel+0x8): undefined reference to `SIG_DFL' collect2: error: ld returned 1 exit status ```
NeedsFix
low
Critical
158,794,578
rust
"invalid subrange count" compiling `[(); 1 << 63]` with -g enabled
The following produces an LLVM error with `-g` enabled: ``` rust let _a = [(); 1 << 63]; ``` The error is: ``` invalid subrange count !16 = !DISubrange(count: -9223372036854775808) LLVM ERROR: Broken function found, compilation aborted! ```
A-LLVM,A-debuginfo,I-ICE,P-medium,T-compiler,regression-from-stable-to-stable,C-bug,glacier,S-bug-has-test
low
Critical
158,809,868
rust
Make `--export-dynamic` the default option when linking executables.
With `#[no_mangle] pub fn` Rust exports a dynamic symbol for the defined function in an executable, but this behaviour is somewhat magical and not transitive. If `--export-dynamic` is made the default then all symbols that are marked as visible in any dependency of the executable will also be exported as a dynamic symbol. This is important for libraries that support plugins where the plugin needs to be able to call back into a function defined in the library. The case I am dealing with is Lua plugins which must have access to the Lua runtime functions when loaded, but presumably the same issues exist for other pluggable libraries (for example SQLite loadable extensions). So long as Rust correctly manage its symbol visibility, and authors of static libraries correctly manage the symbol visibility of the C functions in their libraries, this change should have no down-sides. I believe currently Rust does not quite manage symbol visibility correctly because it leaves every local absolute symbol visible. I'm not sure if there is a reason for this or it is just an oversight, but this would probably need to be resolved. On the issue of the `#[no_mangle] pub fn` I'm not sure why this behaviour is not transitive, but I believe this issue should also be fixed. I may not be using it correctly, but I cannot seem to make a `#[no_mangle] pub fn` from a dependency appear in the symbol table of an executable. I believe this is related to issue #27541.
A-linkage,C-feature-request
low
Major
158,867,714
opencv
How can use the runAt function in cascade detect in opencv 3.1?
This is a template helping you to create an issue which can be processes as quickly as possible. Feel free to add additional information or remove not relevant points if you do not need them. If you have a question rather than reporting a bug please go to http://answers.opencv.org where you get much faster responses. ### Please state the information for your system - OpenCV version: 3.10 - Host OS: Mac OS X 10.11.3 -Compiler & CMake: GCC 5.3 & CMake 3.5 ### In which part of the OpenCV library you got the issue? Examples: - objdetect - face recognition ### Expected behaviour The continues behaviour as opencv2.4. Opencv 2.4 support run a cascade detection in a specified point, which enable cascade object to do classifier's job. ### Actual behaviour In opencv 3.1, the runAt function has been moved to CascadeClassifierImpl, which is not accessable . How can I use the runAt function? ### Additional description ### Code example to reproduce the issue / Steps to reproduce the issue Please try to give a full example which will compile as is. ``` ```
feature,category: objdetect
low
Critical
158,883,763
youtube-dl
Support for chickybox.com
- [X] I've **verified** and **I assure** that I'm running youtube-dl **2016.06.03** ### Before submitting an _issue_ make sure you have: - [X] At least skimmed through [README](https://github.com/rg3/youtube-dl/blob/master/README.md) and **most notably** [FAQ](https://github.com/rg3/youtube-dl#faq) and [BUGS](https://github.com/rg3/youtube-dl#bugs) sections - [X] [Searched](https://github.com/rg3/youtube-dl/search?type=Issues) the bugtracker for similar issues including closed ones ### What is the purpose of your _issue_? - [ ] Bug report (encountered problems with youtube-dl) - [X] Site support request (request for adding support for a new site) - [ ] Feature request (request for a new functionality) - [ ] Question - [ ] Other --- - Single video: http://www.chickybox.com/femminicidio-04pnvi3Jhv
site-support-request
low
Critical
158,981,958
vscode
take advantage of tsserver model of code for faster TypeScript builds
- VSCode Version: 1.2 - OS Version: Windows 7, x64 Currently a way to build a TypeScript project is to run a console command (tsc) that works separately from the tsserver. It looks like the the build could have been done faster if the model of code stored in the tsserver was used that is already parsed, bound and partially typechecked.
feature-request,typescript
low
Major
158,985,597
go
crypto/x509: CertificateRequest does not support attributes not covered by pkix.AttributeTypeAndValueSET
Prior to Go 1.5 it was not possible to parse CSRs which included single attributes like challenge password( OID 1.2.840.113549.1.9.7) See https://github.com/cloudflare/cfssl/issues/115 This issue was addressed in CL [#8160](https://go-review.googlesource.com/#/c/8160/) https://github.com/cloudflare/go/commit/23fca3da84e991bf8b85e1919b65a4ac390814fa by ignoring those attributes. Currently there is no good way to parse and marshal a CSR with attributes that don't fit in the structure defined by `pkix.AttributeTypeAndValueSET`. Challenge Password is a necessary attribute when implementing the [SCEP Protocol](https://tools.ietf.org/html/draft-nourse-scep-23#section-8.3) which is widely used in IoT and Mobile Device Management environments like the Apple MDM [spec](https://developer.apple.com/library/ios/documentation/NetworkingInternet/Conceptual/iPhoneOTAConfiguration/OTASecurity/OTASecurity.html). To extract or add a challenge password attribute, the CSR has to be unmarshalled and modified separately from the `x509/crypto`. Here's an example [workaround](https://github.com/micromdm/scep/commit/4a4f8bc7f7bc34083b0737060db8ef7b55005472) which reimplements parsing and marshaling the CertificateRequest type. The `x509/crypto` library should have a method for handling special attributes in the CSR. As CL [#8160](https://go-review.googlesource.com/#/c/8160/) mentions in the review comments, one possible solution is to add a `RawAttributes` field to the CertificateRequest struct.
NeedsInvestigation
low
Minor
159,017,368
go
x/net/html: provide convenience methods FirstElementChild/NextElementSibling
Please answer these questions before submitting your issue. Thanks! 1. What version of Go are you using (`go version`)? go version go1.6.1 linux/amd64 1. What operating system and processor architecture are you using (`go env`)? GOARCH="amd64" GOBIN="" GOEXE="" GOHOSTARCH="amd64" GOHOSTOS="linux" GOOS="linux" GOPATH="/home/user/go" GORACE="" GOROOT="/usr/lib/go-1.6" GOTOOLDIR="/usr/lib/go-1.6/pkg/tool/linux_amd64" GO15VENDOREXPERIMENT="1" CC="gcc" GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0" CXX="g++" CGO_ENABLED="1" 1. What did you do? If possible, provide a recipe for reproducing the error. A complete runnable program is good. A link on play.golang.org is best. Here is a link to golang playground, but note that this library doesn't actually run on the playground. I am providing a playground link because I cannot format the code correctly here given the string formatting I am using. https://play.golang.org/p/DrERE6s0tT 1. What did you expect to see? The last printed div is supposed to have children as per the html string. 1. What did you see instead? Instead it is parsed as a Text NodeType, and thus has no children, or even data.
NeedsInvestigation
low
Critical
159,057,650
go
x/net/http2: data race on DebugGoroutines
This is an issue of http2 package-specific debug hook, so not critical. ``` go test -race golang.org/x/net/http2 -count 10 ================== WARNING: DATA RACE Write at 0x000000705ee2 by goroutine 236: golang.org/x/net/http2.TestGoroutineLock() /swdev/src/golang.org/x/net/http2/gotrack_test.go:15 +0x82 testing.tRunner() /go/src/testing/testing.go:610 +0xc9 Previous read at 0x000000705ee2 by goroutine 147: golang.org/x/net/http2.goroutineLock.check() /swdev/src/golang.org/x/net/http2/gotrack.go:32 +0x3e golang.org/x/net/http2.(*serverConn).stopShutdownTimer() /swdev/src/golang.org/x/net/http2/server.go:651 +0x58 golang.org/x/net/http2.(*serverConn).serve() /swdev/src/golang.org/x/net/http2/server.go:722 +0x8c8 golang.org/x/net/http2.(*Server).ServeConn() /swdev/src/golang.org/x/net/http2/server.go:339 +0xb70 golang.org/x/net/http2.ConfigureServer.func1() /swdev/src/golang.org/x/net/http2/server.go:200 +0xe7 net/http.(*conn).serve() /go/src/net/http/server.go:1493 +0x12ab Goroutine 236 (running) created at: testing.(*T).Run() /go/src/testing/testing.go:646 +0x52f testing.RunTests.func1() /go/src/testing/testing.go:793 +0xb9 testing.tRunner() /go/src/testing/testing.go:610 +0xc9 testing.RunTests() /go/src/testing/testing.go:799 +0x4b5 testing.(*M).Run() /go/src/testing/testing.go:743 +0x12f main.main() golang.org/x/net/http2/_test/_testmain.go:470 +0x1b4 Goroutine 147 (finished) created at: net/http.(*Server).Serve() /go/src/net/http/server.go:2240 +0x53e net/http/httptest.(*Server).goServe.func1() /go/src/net/http/httptest/server.go:235 +0xa2 ================== PASS ```
Testing
low
Critical
159,059,505
go
cmd/compile: escape analysis of interface calls to non-exported method names
Consider this Go source: ``` package p import "fmt" type A int func (A) f(x *int) { fmt.Println("A", *x) } type B int func (B) f(x *int) { fmt.Println("B", *x) } func (B) g() {} type Fer interface { f(x *int); g() } func H(f Fer) { i := 42 f.f(&i) } ``` At the f.f(&i) call site in H, we can't be sure exactly what method will be called. However, since it's an unexported method name, it must be implemented by a method in the same package. Consequently, if we know that all candidate methods in the package are non-escaping (such as A.f and B.f are), we can still be sure that f.f(&i) is a non-escaping call. Note that we still have to consider A.f even though A itself doesn't implement Fer, because a downstream package could do something like: ``` package q import "p" type X struct { p.B } type Y struct { p.A; X } func Z() { p.H(Y{}) } ``` There are probably refinements that could avoid this though. I happened to notice this because of package net's "exchange" function, which calls the unexported TCPConn.dnsRoundTrip or UDPConn.dnsRoundTrip methods. I haven't investigated how common this situation is though. /cc @dr2chase @alandonovan
compiler/runtime
low
Minor
159,100,646
neovim
:normal ex command should work in terminal mode
- `nvim --version`: `NVIM v0.1.5-385-g999590b` - Operating system/version: OS X / 10.11.5 - Terminal name/version: iTerm2 / Build 3.0.20160607-nightly - `$TERM`: xterm-256color - Actual behaviour: `execute "normal! gt"` have no effect when run from a terminal, if a terminal is active. - Expected behaviour: `execute "normal! gt"` should switch tabs ### Steps to reproduce using `nvim -u minimal_vimrc` 1. `nvim -u mini_vimrc` 2. `:edit foo<cr>` 3. `:tabedit bar<cr>` 4. `:sp | term<cr>` 5. `Ctrl-\ Ctrl\n :Tabs<cr>` 6. Select `Tab page 1` and press Enter 7. You are not moved to the first tab. 8. Now type `:messages<cr>` to see the command that was executed: `normal! 1gt`. It works, If you do the same from another window that is not bound to a terminal buffer !!!! Here is a [asciicast](https://asciinema.org/a/692o9i8u5e9g3al4qj8fz11mx). Here is a mini_vimrc: ``` vim call plug#begin('~/.config/nvim/plugged') set rtp+=/usr/local/opt/fzf Plug 'junegunn/fzf.vim' function! s:tablist() redir => tabs silent tabs redir END return filter(split(tabs, '\n'), 'v:val =~ "Tab page"') endfunction function! s:tabopen(e) "Show what is being executed echomsg 'normal! '. matchstr(a:e, 'Tab page \zs[0-9]*\ze.*$').'gt' execute 'normal! '. matchstr(a:e, 'Tab page \zs[0-9]*\ze.*$').'gt' endfunction command Tabs call fzf#run({ \ 'source': reverse(<sid>tablist()), \ 'sink': function('<sid>tabopen'), \ 'options': '', \ 'down': len(<sid>tablist()) + 2 \ }) call plug#end() ```
bug,terminal
low
Major
159,117,787
youtube-dl
hls process
### Make sure you are using the _latest_ version: run `youtube-dl --version` and ensure your version is _2016.06.03_. If it's not read [this FAQ entry](https://github.com/rg3/youtube-dl/blob/master/README.md#how-do-i-update-youtube-dl) and update. Issues with outdated version will be rejected. - [x] I've **verified** and **I assure** that I'm running youtube-dl **2016.06.03** ### Before submitting an _issue_ make sure you have: - [x] At least skimmed through [README](https://github.com/rg3/youtube-dl/blob/master/README.md) and **most notably** [FAQ](https://github.com/rg3/youtube-dl#faq) and [BUGS](https://github.com/rg3/youtube-dl#bugs) sections - [x] [Searched](https://github.com/rg3/youtube-dl/search?type=Issues) the bugtracker for similar issues including closed ones ### What is the purpose of your _issue_? - [x] Bug report (encountered problems with youtube-dl) - [ ] Site support request (request for adding support for a new site) - [ ] Feature request (request for a new functionality) - [ ] Question - [ ] Other --- Hi, I've seen two problems with current hls download process: 1. With --hls-use-mpegts, ffmpeg must be used in all cases because native doesn't support it: At the moment, it only works if combination of protocol and hls-prefer options gives ffmpeg. 2. m3u8 fixup doesn't need to be done when ffmpeg is used: At the moment, it's also done with m3u8_native and --hls-prefer-ffmpeg.
bug
low
Critical
159,174,986
rust
slice::sort_by_key has more restrictions than slice::sort_by
I expected that these invocations of `sort_by` and `sort_by_key` would be equivalent: ``` rust struct Client(String); impl Client { fn key(&self) -> &str { &self.0 } } fn main() { let mut clients: Vec<Client> = vec![]; // Error: cannot infer an appropriate lifetime for autoref due to conflicting requirements clients.sort_by_key(|c| c.key()); // OK clients.sort_by(|a, b| a.key().cmp(&b.key())); } ``` The [implementation of `sort_by_key`](https://github.com/rust-lang/rust/blob/d5759a3417fa395d439f4283825504dd4f78dc87/src/libcollections/slice.rs#L818-L822): ``` rust pub fn sort_by_key<B, F>(&mut self, mut f: F) where F: FnMut(&T) -> B, B: Ord { self.sort_by(|a, b| f(a).cmp(&f(b))) } ``` An initial attempt at using HRTB didn't seem to pan out: ``` rust pub fn sort_by_key<B, F>(&mut self, mut f: F) where for <'a> F: FnMut(&'a T) -> B + 'a, B: Ord ```
T-libs-api,C-bug
medium
Critical
159,254,344
flutter
Should cross-fade the paginated data table header when it changes
If you select something, we replace the header with a count of selected items. We should do that with an animation that cross-fades from the previous text, or something. Right now it feels a bit sudden.
c: new feature,framework,f: material design,P3,team-design,triaged-design
low
Minor
159,275,230
opencv
Better to have an option for Python3 or Python2?
### Please state the information for your system - OpenCV version: 3.x (git) - Host OS: Linux (Ubuntu 16.04) - GCC 5.3.1 & CMake 3.5.1 ### In which part of the OpenCV library you got the issue? Python ### Expected behaviour While configure, I can see > PYTHON2_EXECUTABLE /usr/bin/python2.7 > PYTHON2_INCLUDE_DIR /usr/include/python2.7 > PYTHON2_INCLUDE_DIR2 > PYTHON2_LIBRARY /usr/lib/x86_64-linux-gnu/libpython2.7.so > PYTHON2_LIBRARY_DEBUG > PYTHON2_NUMPY_INCLUDE_DIRS > PYTHON2_PACKAGES_PATH lib/python2.7/dist-packages > PYTHON3_EXECUTABLE /usr/bin/python3 > PYTHON3_INCLUDE_DIR /usr/include/python3.5m > PYTHON3_INCLUDE_DIR2 > PYTHON3_LIBRARY /usr/lib/x86_64-linux-gnu/libpython3.5m.so > PYTHON3_LIBRARY_DEBUG > PYTHON3_NUMPY_INCLUDE_DIRS /usr/lib/python3/dist-packages/numpy/core/include > PYTHON3_PACKAGES_PATH lib/python3.5/dist-packages But, there is **NO** option for me to choose which version of python that I'm going to use for OpenCV build. ### Actual behaviour I prefer using Python 3.5m, but finally, it always goes to Python 2.7 . Any suggestions if I can specify which version of python I would like to use for compilation? Cheers Pei
feature,priority: low,category: build/install
low
Critical
159,288,238
youtube-dl
Feature Request - Remove Videos from YouTube Playlist after Download
### What is the purpose of your _issue_? - [ ] Bug report (encountered problems with youtube-dl) - [ ] Site support request (request for adding support for a new site) - [X] Feature request (request for a new functionality) - [X] Question - [ ] Other --- ### Feature Request - Remove Videos from YouTube Playlist after Download I would like to add a option to remove a video from a YouTube playlist after it is downloaded. I believe this is possible as the YouTube API has a python section for this. https://developers.google.com/youtube/1.0/developers_guide_python#adding-a-playlist I have managed to add the option to the options list as "--remove-watched", but can't seem to call the method it points at. I admit I am new to python but have coded in several other languages before so if someone could point me in the right direction I will do my best to figure it out. Thanks,
request
low
Critical
159,359,615
youtube-dl
[eclassesbyravindra] Site support request
C:\chirag\Videos\Gate Ravi Lectures\CN Problems>youtube-dl.exe http://eclassesby ravindra.com/enrol/index.php?id=24/ [generic] index: Requesting header [redirect] Following redirect to http://eclassesbyravindra.com/login/index.php [generic] index: Requesting header WARNING: Falling back on generic information extractor. [generic] index: Downloading webpage [generic] index: Extracting information ERROR: Unsupported URL: http://eclassesbyravindra.com/login/index.php It gets redirect to another mostly previous url in normal browsing and does not download the videos.
site-support-request,account-needed
medium
Critical
159,479,062
angular
Control Validators should be observable chains
- **I'm submitting a ...** - [X] feature request **Current behavior** Validators are callback functions **Expected/desired behavior** Validators should be observables. - **What is the motivation / use case for changing the behavior?** Currently it is very counter intuitive to build debounced async validators (http://plnkr.co/edit/2NuNj1lBj2e6OdUJjFra?p=preview). It would be much cleaner to work with an observable chain that is subscribed once, instead of subscribed for every value change of a control. It could look like this: ``` new Control('',validator$=>{ return validator$.map(valid=>{ valid.errors.minLen=valid.value.length>5?null,"Length must be at least 5"; return valid; }); }); ```
feature,state: Needs Design,area: forms,feature: under consideration
medium
Critical
159,508,296
go
x/mobile/font: Default font fail on MacOS and iOS
Hello, 1. What version of Go are you using (`go version`)? I'm using Go version 1.6.2 and Gomobile version +c435d0b 2. What operating system and processor architecture are you using (`go env`)? I'm on MacOS (darwin / amd64) 3. What did you do? I'm trying to use the Default system font on MacOS and iOS (gomobile). The complete program can be found here: https://github.com/antoine-richard/gomobile-text See this line: https://github.com/antoine-richard/gomobile-text/blob/master/game.go#L47 4. What did you expect to see? I expect to see the Default font being used. 5. What did you see instead? I'm getting the following error: `freetype: invalid TrueType format: bad maxp length: 6` on both MacOS and iOS when using the Default font. The monospace font works on these OSes. The default font works on Android. I've found 2 issues mentioning the same kind of problem: https://github.com/golang/go/issues/10644 and https://github.com/golang/go/issues/10136 Also the test on default font fails on MacOS: ``` --- FAIL: TestLoadFonts (0.02s) font_test.go:41: default font: not a TTF: missing "glyf" table FAIL exit status 1 FAIL golang.org/x/mobile/exp/font 0.035s ``` Is there a way to use the default font on Darwin? Is there any known workaround? Thank you Antoine
mobile
low
Critical
159,552,711
go
x/net/http2: deal with half-closed remote in Transport, flaky TestTransportResPattern_c0h1d0t0, TestTransportResPattern_c1h2d0t0
See https://build.golang.org/log/6c16a5f66e28811897fa9ff2818873f56a9a128c and https://build.golang.org/log/5ea1f443a67a371b9acdebeee89cc802345ce5fb. ``` --- FAIL: TestTransportResPattern_c0h1d1t0 (0.00s) transport_test.go:664: client: RoundTrip: http2: stream closed FAIL FAIL golang.org/x/net/http2 7.585s ```
Testing
low
Minor
159,641,011
vscode
Implement editor undo stack serialization
Related to #7169, #7535 Similarly to the view state, we need a way to serialize, and later deserialize, a model's undo stack.
feature-request,editor-textbuffer,undo-redo
medium
Major
159,666,457
TypeScript
Find all references for ambient module
``` // declarations.d.ts declare module "x" { export const x: number; } // index.ts import {x} from "x"; ``` Goto-declaration for "x" in index.ts works, but find-all-references for "x" in declarations.d.ts finds only itself. In this case one can simply look through each of export in the module's body and find all of their references; but for shorthand ambient modules (`declare module "x";`) that won't work, as there is no module body.
Suggestion,Help Wanted,API
low
Minor
159,670,186
youtube-dl
Request: Extract more (course) metadata for Lynda
Categories can be found as 'subjects.' Courses have their own description, along with other metadata such as 'view count' and 'creator,' which currently aren't extracted.
request
low
Minor
159,710,464
electron
macOS dynamic menu items (that change when the user holds down a modifier)
> A dynamic menu item is a command that changes when the user presses a modifier key. https://developer.apple.com/library/mac/documentation/UserExperience/Conceptual/OSXHIGuidelines/MenuChanging.html - Operating system: OS X
enhancement :sparkles:,platform/macOS,component/menu
low
Major
159,728,132
TypeScript
Symlinks not resolved for `/// <reference path="..." />`
**TypeScript Version:** nightly (1.9.0-dev) **Code** ``` shell $ ls -alF a/ project/ symlink -> a/ $ cat a/one.ts import './zone'; $ cat a/zone.d.ts declare type ZoneType = {a:string}; declare const Zone: ZoneType; $ cat project/tsconfig.json { "compilerOptions": { "module": "commonjs", "target": "es5", "noEmit": true, "traceResolution": true } } $ cat project/deps.d.ts ///<reference path="../symlink/zone.d.ts"/> ///<reference path="../symlink/one.ts"/> ``` **Expected behavior:** There are two ways the program may import `zone.d.ts`, either by resolving symlinks to `../a/zone` or by using the path provided `../symlink/zone`. In order to treat these as the same file, TypeScript needs to use the same path internally. **Actual behavior:** One case resolves the symlink and the other does not, causing the declarations in the file to conflict with themselves: ``` $ tsc -p project ======== Resolving module './zone' from '/usr/local/google/home/alexeagle/repro_pathmapping_zone/symlink/one.ts'. ======== Module resolution kind is not specified, using 'NodeJs'. Loading module as file / folder, candidate module location '/usr/local/google/home/alexeagle/repro_pathmapping_zone/symlink/zone'. File '/usr/local/google/home/alexeagle/repro_pathmapping_zone/symlink/zone.ts' does not exist. File '/usr/local/google/home/alexeagle/repro_pathmapping_zone/symlink/zone.tsx' does not exist. File '/usr/local/google/home/alexeagle/repro_pathmapping_zone/symlink/zone.d.ts' exist - use it as a name resolution result. Resolving real path for '/usr/local/google/home/alexeagle/repro_pathmapping_zone/symlink/zone.d.ts', result '/usr/local/google/home/alexeagle/repro_pathmapping_zone/a/zone.d.ts' ======== Module name './zone' was successfully resolved to '/usr/local/google/home/alexeagle/repro_pathmapping_zone/a/zone.d.ts'. ======== a/zone.d.ts(1,14): error TS2300: Duplicate identifier 'ZoneType'. a/zone.d.ts(2,15): error TS2451: Cannot redeclare block-scoped variable 'Zone'. symlink/zone.d.ts(1,14): error TS2300: Duplicate identifier 'ZoneType'. symlink/zone.d.ts(2,15): error TS2451: Cannot redeclare block-scoped variable 'Zone'. ``` with @vikerman
Bug
medium
Critical
159,753,711
youtube-dl
Feature Request - Add to --match-filter keys one to identify the categorie of the YouTube Video.
### What is the purpose of your _issue_? - [ ] Bug report (encountered problems with youtube-dl) - [ ] Site support request (request for adding support for a new site) - [x] Feature request (request for a new functionality) - [x] Question - [ ] Other ### Feature Request - Add to `--match-filter` keys one to identify the categorie of the YouTube Video. For example only allow videos from the MUSIC category, I was thinking something like that: `--match-filter "categorie = Music"` or similar. Thanks for your work!
request
low
Critical
159,757,242
youtube-dl
Drop Python 3.2 support
- [x] I've **verified** and **I assure** that I'm running youtube-dl **2016.06.11.3** ### Before submitting an _issue_ make sure you have: - [x] At least skimmed through [README](https://github.com/rg3/youtube-dl/blob/master/README.md) and **most notably** [FAQ](https://github.com/rg3/youtube-dl#faq) and [BUGS](https://github.com/rg3/youtube-dl#bugs) sections - [x] [Searched](https://github.com/rg3/youtube-dl/search?type=Issues) the bugtracker for similar issues including closed ones ### What is the purpose of your _issue_? - [ ] Bug report (encountered problems with youtube-dl) - [ ] Site support request (request for adding support for a new site) - [ ] Feature request (request for a new functionality) - [ ] Question - [x] Other --- The latest pip has dropped Python 3.2 support (pypa/pip#3156) . As a result, I can't install pip: ``` $ python3.2 ~/tmp/get-pip.py --user /tmp/tmpyhlooe/pip.zip/pip/_vendor/pkg_resources/__init__.py:80: UserWarning: Support for Python 3.0-3.2 has been dropped. Future versions will fail here. Traceback (most recent call last): File "/home/yen/tmp/get-pip.py", line 19177, in <module> main() File "/home/yen/tmp/get-pip.py", line 194, in main bootstrap(tmpdir=tmpdir) File "/home/yen/tmp/get-pip.py", line 82, in bootstrap import pip File "/tmp/tmpyhlooe/pip.zip/pip/__init__.py", line 16, in <module> File "/tmp/tmpyhlooe/pip.zip/pip/vcs/mercurial.py", line 9, in <module> File "/tmp/tmpyhlooe/pip.zip/pip/download.py", line 36, in <module> File "/tmp/tmpyhlooe/pip.zip/pip/utils/ui.py", line 15, in <module> File "/tmp/tmpyhlooe/pip.zip/pip/_vendor/progress/bar.py", line 48 empty_fill = u'∙' ^ SyntaxError: invalid syntax ``` Reasons for dropping: - According to dstufft, requests by Python 3.2 clients account for less than 0.5% traffic on pypi.org - pip does not support Python 3.2. I need pip to install nose and PyCrypto (for #8201) - Although Ubuntu 12.04 LTS (EOL on April 2017) still ships Python 3.2, users can use Python 2.7 A last bit: re on Python 3.2 is broken. ``` $ python3.2 test/test_all_urls.py ..F............. ====================================================================== FAIL: test_no_duplicates (__main__.TestAllURLsMatching) ---------------------------------------------------------------------- Traceback (most recent call last): File "test/test_all_urls.py", line 93, in test_no_duplicates self.assertTrue(ie.suitable(url), '%s should match URL %r' % (type(ie).__name__, url)) AssertionError: False is not true : UnicodeBOMIE should match URL '\ufeffhttp://www.youtube.com/watch?v=BaW_jenozKc' ---------------------------------------------------------------------- Ran 16 tests in 1.708s FAILED (failures=1) $ python3.2 Python 3.2.6 (default, May 23 2016, 01:08:02) [GCC 6.1.1 20160501] on linux2 Type "help", "copyright", "credits" or "license" for more information. >>> import re >>> re.match(r'\ufeff', '\ufeff') >>> ``` UPDATE 2018/01/25: Blackberry 10 ships Python 3.2 and no 2.x, so 3.2 support should be kept until Blackberry 10 is dropped. Ref: https://appworld.blackberry.com/webstore/content/32880889
request
low
Critical
159,759,817
youtube-dl
Add support for wetube.io
## Please follow the guide below --- ### Make sure you are using the _latest_ version: run `youtube-dl --version` and ensure your version is _2016.06.11.3_. If it's not read [this FAQ entry](https://github.com/rg3/youtube-dl/blob/master/README.md#how-do-i-update-youtube-dl) and update. Issues with outdated version will be rejected. - [x] I've **verified** and **I assure** that I'm running youtube-dl **2016.06.11.3** ### Before submitting an _issue_ make sure you have: - [x] At least skimmed through [README](https://github.com/rg3/youtube-dl/blob/master/README.md) and **most notably** [FAQ](https://github.com/rg3/youtube-dl#faq) and [BUGS](https://github.com/rg3/youtube-dl#bugs) sections - [x] [Searched](https://github.com/rg3/youtube-dl/search?type=Issues) the bugtracker for similar issues including closed ones ### What is the purpose of your _issue_? - [ ] Bug report (encountered problems with youtube-dl) - [ ] Site support request (request for adding support for a new site) - [x] Feature request (request for a new functionality) - [ ] Question - [ ] Other --- ### If the purpose of this _issue_ is a _bug report_, _site support request_ or you are not completely sure provide the full verbose output as follows: ``` youtube-dl 'https://www.wetube.io/video/conference-de-pablo-servigne-effondrements-comment-encaisser-les-chocs/' -v [debug] System config: [] [debug] User config: [] [debug] Command-line args: ['https://www.wetube.io/video/conference-de-pablo-servigne-effondrements-comment-encaisser-les-chocs/', '-v'] [debug] Encodings: locale UTF-8, fs utf-8, out UTF-8, pref UTF-8 [debug] youtube-dl version 2016.06.11 [debug] Python version 3.5.1 - Linux-4.6.2-1-ARCH-x86_64-with-arch [debug] exe versions: ffmpeg 3.0.2, ffprobe 3.0.2, rtmpdump 2.4 [debug] Proxy map: {} [generic] conference-de-pablo-servigne-effondrements-comment-encaisser-les-chocs: Requesting header WARNING: Falling back on generic information extractor. [generic] conference-de-pablo-servigne-effondrements-comment-encaisser-les-chocs: Downloading webpage [generic] conference-de-pablo-servigne-effondrements-comment-encaisser-les-chocs: Extracting information ERROR: Unsupported URL: https://www.wetube.io/video/conference-de-pablo-servigne-effondrements-comment-encaisser-les-chocs/ Traceback (most recent call last): File "/usr/lib/python3.5/site-packages/youtube_dl/YoutubeDL.py", line 676, in extract_info ie_result = ie.extract(url) File "/usr/lib/python3.5/site-packages/youtube_dl/extractor/common.py", line 342, in extract return self._real_extract(url) File "/usr/lib/python3.5/site-packages/youtube_dl/extractor/generic.py", line 2154, in _real_extract raise UnsupportedError(url) youtube_dl.utils.UnsupportedError: Unsupported URL: https://www.wetube.io/video/conference-de-pablo-servigne-effondrements-comment-encaisser-les-chocs/ ``` ### If the purpose of this _issue_ is a _site support request_ please provide all kinds of example URLs support for which should be included (replace following example URLs by **yours**): - Single video: https://www.wetube.io/video/conference-de-pablo-servigne-effondrements-comment-encaisser-les-chocs/ - website : https://www.wetube.io
site-support-request
low
Critical
159,763,349
youtube-dl
Download only Audio bytes
I want to download from YouTube the best Audio Quality possible. Since the Audio Only files are at low bitrate (usually 128k), i have to download the whole Audio+Video (format 22 usually has the best audio), and then extract the audio. But i don't want to download the entire video file to only get the audio. I know it is possible to download only Audio bytes by parsing the format header and skip all video frames to save bandwidth. For example 4K Video Downloader does this with YouTube to get the best Audio quality from a video. It parses the MP4 header, and download only the audio bytes. it is possible to implement this functionality?
request
low
Major
159,846,298
opencv
crashes, when OutputArrayOfArrays is used with type inherited from cv::Point2f
- OpenCV version: 3.1 - Host OS: Linux (Ubuntu 14.04) - aruco ### Expected behaviour application detects markers and saves points information correctly ### Actual behaviour application crashes ### Code example to reproduce the issue / Steps to reproduce the issue ``` /* this works fine if points is of type: vector<vector<cv::Point2f>>; */ cv::Ptr<aruco::Dictionary> dict=aruco::getPredefinedDictionary(aruco::DICT_4X4_50); aruco::detectMarkers(inputImage, dict, points, marIds); let's create our own type for storing points: class Vector2f : public cv::Point2f { public: Vector2f() : cv::Point2f(){} Vector2f(float newX, float newY): cv::Point2f(newX, newY){} float length(); //implementation not meaningfull }; now sample code: /* this does not work if points is of type vector<vector<Vector2f>>; */ cv::Ptr<aruco::Dictionary> dict=aruco::getPredefinedDictionary(aruco::DICT_4X4_50); aruco::detectMarkers(inputImage, dict, points, marIds); ``` Application crashes with exception. I used to work more with opencv some time ago I remember, that sometimes you are doing some low level metaprogramming stuff and hardcode things for certain types defined by you. This might be an issue.
bug,category: core
low
Critical
159,856,220
rust
Lint against transmutes which could be `as` casts.
The relevant casts are at least those between pointers and integers, or between two pointers. There's probably also some likelihood of same-type transmutes arising, which keep working after changing the types (of FFI signatures, for example) but could be removed because they're noops. Clippy might be interested, if they don't already have this (cc @Manishearth).
A-lints,C-feature-request
low
Major
159,882,689
TypeScript
Triple slash reference should include extension '.d.ts' or not?
_From @frogcjn on June 13, 2016 6:6_ `/// <reference path='../../../typings/index.d.ts' />` or `/// <reference path='../../../typings/index' />` ? Thanks! tsc recognizes the file without .d.ts extension, but vscode's ts validation has a different behavior. This makes a headache communication between typescript coder. <img width="355" alt="2016-06-13 02 25 22" src="https://cloud.githubusercontent.com/assets/1777562/15998322/fa52bdb2-316f-11e6-84a8-6de7cc0316dc.png"> _Copied from original issue: Microsoft/vscode#7594_
Bug,Help Wanted,VS Code Tracked
low
Minor
159,896,424
kubernetes
kubectl run -it loses some lines of the log
When running a command via `kubectl run -it` that immediately prints something, we might lose some lines of the log due to a race of the execution of the container and the `kubectl attach` used by `kubectl run` to attach to the terminal (compare comment https://github.com/kubernetes/kubernetes/issues/16670#issuecomment-199017681). As a workaround for running an interactive shell we have this ugly `Hit enter for command prompt` now. The actual root problem though is that `docker attach` does not replay the logs. It looks like `docker run` is the only way to actually synchronously run a command, get all the output and attach to the process.
kind/bug,priority/backlog,area/kubectl,sig/node,sig/cli,triage/accepted
medium
Critical
159,913,187
TypeScript
Module augmentation with export list
**TypeScript Version:** 1.8.10 **Code** ``` ts // scale.ts class Scale { weightOnEarth(mass) {} } export { Scale } ``` ``` ts // advancedScale.ts import {Scale} from "./scale" ; declare module "./scale" { interface Scale { weightOnMoon(mass); } } Scale.prototype.weightOnMoon = function (ee) { } ``` ``` ts // consumer.ts import { Scale } from "./scale"; import "./advancedScale"; let scale: Scale; scale.weightOnMoon(10); // ok scale.weightOnEarth(10); ``` ``` // tsconfig.json { "compilerOptions": { "module": "commonjs", "target": "es5" } } ``` # Bug 1 This code is from [this post](https://blogs.msdn.microsoft.com/typescript/2016/02/22/announcing-typescript-1-8-2/), with just a small change: in `scale.ts`, the syntax of export list is used `export { Scale }`. The compiler returns errors: > scale.ts(5,10): error TS2484: Export declaration conflicts with exported declaration of 'Scale' > advancedScale.ts(9,1): error TS2304: Cannot find name 'Scale'. > consumer.ts(7,7): error TS2339: Property 'weightOnEarth' does not exist on type 'Scale'. # Bug 2 With the original code, in `consumer.ts`, the line `import "./advancedScale";` can be removed but the code still compiles.
Bug
low
Critical
159,933,804
rust
Higher-ranked lifetime causes inconsistent behavior with trait bounds.
Existing code uses trait bounds to force side-conditions on associated types. For instance, `IntoIterator` is defined (in part) as follows: <details><summary>Original snippet from 2016 (no longer syntactically legal)</summary> ```rs trait IntoIterator where Self::IntoIter::Item == Self::Item { type Item; type IntoIter: Iterator; } ``` </details> ```rs trait IntoIterator { type Item; type IntoIter: Iterator<Item = Self::Item>; } ``` Similarly, we can define a side-condition using higher-ranked lifetimes: ``` rust trait BorrowIterator where for<'a> &'a Self: IntoIterator {} ``` This is necessary when we want to implement a trait for a (non-reference) type `T`, but want to require trait implementations on `&'a T` where those trait implementations can refer to the borrow lifetime `'a`. However, the former concrete trait bounds are usable as trait bounds in functions. For instance, the following will compile: ``` rust fn needs_iter<T: IntoIterator>(){} ``` Whereas this will fail: ``` rust fn needs_borrow_iter<T: BorrowIterator>(){} ``` With the error: ``` error: the trait bound `for<'a> &'a T: std::iter::Iterator` is not satisfied [--explain E0277] --> <anon>:19:1 19 |> fn needs_borrow_iter<T: BorrowIterator>() |> ^ note: `&'a T` is not an iterator; maybe try calling `.iter()` or a similar method note: required because of the requirements on the impl of `for<'a> std::iter::IntoIterator` for `&'a T` note: required by `BorrowIterator` ``` This is doubly puzzling since `T: IntoIterator` doesn't require `T: Iterator`. See #34142 which shows similar issues with bounds on function definitions. See #27113 which shows issues with 'outlives' relations in where-clauses.
A-type-system,A-lifetimes,T-compiler,C-bug,T-types,A-higher-ranked
low
Critical
159,942,751
youtube-dl
Support for skillshare.com
## Please follow the guide below - You will be asked some questions and requested to provide some information, please read them **carefully** and answer honestly - Put an `x` into all the boxes [ ] relevant to your _issue_ (like that [x]) - Use _Preview_ tab to see how your issue will actually look like --- ### Make sure you are using the _latest_ version: run `youtube-dl --version` and ensure your version is _2016.06.12_. If it's not read [this FAQ entry](https://github.com/rg3/youtube-dl/blob/master/README.md#how-do-i-update-youtube-dl) and update. Issues with outdated version will be rejected. - [x ] I've **verified** and **I assure** that I'm running youtube-dl **2016.06.12** ### Before submitting an _issue_ make sure you have: - [x ] At least skimmed through [README](https://github.com/rg3/youtube-dl/blob/master/README.md) and **most notably** [FAQ](https://github.com/rg3/youtube-dl#faq) and [BUGS](https://github.com/rg3/youtube-dl#bugs) sections - [x ] [Searched](https://github.com/rg3/youtube-dl/search?type=Issues) the bugtracker for similar issues including closed ones ### What is the purpose of your _issue_? - [ ] Bug report (encountered problems with youtube-dl) - [x ] Site support request (request for adding support for a new site) - [ ] Feature request (request for a new functionality) - [ ] Question - [ ] Other --- ### The following sections concretize particular purposed issues, you can erase any section (the contents between triple ---) not applicable to your _issue_ --- ### If the purpose of this _issue_ is a _bug report_, _site support request_ or you are not completely sure provide the full verbose output as follows: Add `-v` flag to **your command line** you run youtube-dl with, copy the **whole** output and insert it here. It should look similar to one below (replace it with **your** log inserted between triple ```): ``` $ youtube-dl -v <your command line> [debug] System config: [] [debug] User config: [] [debug] Command-line args: [u'-v', u'http://www.youtube.com/watch?v=BaW_jenozKcj'] [debug] Encodings: locale cp1251, fs mbcs, out cp866, pref cp1251 [debug] youtube-dl version 2016.06.12 [debug] Python version 2.7.11 - Windows-2003Server-5.2.3790-SP2 [debug] exe versions: ffmpeg N-75573-g1d0487f, ffprobe N-75573-g1d0487f, rtmpdump 2.4 [debug] Proxy map: {} ... <end of log> ``` --- ### If the purpose of this _issue_ is a _site support request_ please provide all kinds of example URLs support for which should be included (replace following example URLs by **yours**): - Single video: https://www.youtube.com/watch?v=BaW_jenozKc - Single video: https://youtu.be/BaW_jenozKc - Playlist: https://www.youtube.com/playlist?list=PL4lCao7KL_QFVb7Iudeipvc2BCavECqzc --- Hi Sir i want to request you to add this one website for downloading video this is a elearning website like (lynda, udemy and pluralsight) here is course links https://www.skillshare.com/classes/technology/Design-Build-Your-Own-Personal-Computer/694021855/classroom/discussions?via=my-classes&enrolledRedirect=1 but there is not single video link every video is playing in single link may b i am wrong cuz i am not programmer here is free course link which you can enroll and check https://www.skillshare.com/classes/technology/Design-Build-Your-Own-Personal-Computer/694021855/classroom/discussions?via=my-classes&enrolledRedirect=1 if you want premium account then tell me i will give you mine
site-support-request,account-needed
medium
Critical
159,945,245
rust
Associated type equality not followed through multiple traits
Simplest case to reproduce would be to add a trait which decorates `IntoIterator` and try to write a blanket impl for that trait: ``` rust trait DecoratesIntoIterator: IntoIterator { type Output: Iterator<Item=Self::Item>; } impl<T> DecoratesIntoIterator for T where T: IntoIterator, T::IntoIter: DecoratesIntoIterator, { type Output = <T::IntoIter as DecoratesIntoIterator>::Output; } ``` Will fail to compile with ``` type mismatch resolving `<<<T as std::iter::IntoIterator>::IntoIter as DecoratesIntoIterator>::Output as std::iter::Iterator>::Item == <T as std::iter::IntoIterator>::Item`: ``` even though every trait mentioned has the constraint that the output has `Iterator<Item=Self::Item>`. Ran into this with a more concrete use case inside of Diesel: ``` rust trait Query { type SqlType; } trait AsQuery { type SqlType; type Query: Query<SqlType=Self::SqlType>; fn as_query(self) -> Self::Query; } trait LimitDsl: AsQuery { type Output: Query<SqlType=Self::SqlType>; fn limit(self, limit: i64) -> Self::Output; } impl<T> LimitDsl for T where T: AsQuery, T::Query: LimitDsl, { type Output = <T::Query as LimitDsl>::Output; fn limit(self, limit: i64) -> Self::Output { self.as_query().limit(limit) } } ``` This can be worked around by manually restating the constraint, like so: ``` impl<T, ST> LimitDsl for T where T: AsQuery<SqlType=ST>, T::Query: LimitDsl<SqlType=ST>, ``` but this shouldn't be required.
A-type-system,T-compiler,C-bug,T-types
low
Minor
160,019,117
rust
Rust is overflowing on recursive trait evaluation where it didn't before
This can be simplified down to the following: ``` rust trait MyTrait { type Output; } impl<T: MyTrait> MyTrait for T { type Output = <T as MyTrait>::Output; } trait SomeOtherTrait {} impl<T> SomeOtherTrait for T where T: MyTrait, T::Output: Send {} fn main() {} ``` When compiling that program, rust will overflow when it did not on older versions.. Of course that example is contrived, and attempting to use any concrete type there will always overflow. It is simplified from the slightly more realistic example in https://is.gd/XSHLG2, which is simplified from the real world case where I encountered this, which was trying to pull https://github.com/diesel-rs/diesel/blob/f0a75bb/diesel/src/query_dsl/load_dsl.rs#L23-L29 into a separate trait. The important distinction is that we're now overflowing in a generic context, in cases where there are some concrete types which are valid. Specifically this causes confusing differing behavior between where clauses on methods and where clauses on trait impls. The above code is fine if the where clause is instead on some trait method, as it's no longer evaluated until there's a concrete type that the method is being called on. I'd actually think that rustc could always avoid overflow here, and instead detect that it's evaluating the same trait impl def for the same type and answer no. The code implies that was the intention. But that's aside the point, this is about a concrete change in behavior. The issue was first introduced in nightly-2015-08-15. On nightlies prior to that, https://is.gd/vrEvFN would compile successfully. It manifested as an actual stack overflow until nightly-2015-10-29, where it became a proper error (hilariously giving a warning that this warning would become a hard error due to RFC 1214, when it was already hard erroring). I believe this was an unintentional side effect of implementing RFC 1214, as that was merged in on the nightly that introduced the issue.
A-type-system,P-medium,T-compiler,regression-from-stable-to-stable,C-bug,T-types
low
Critical
160,075,472
three.js
Feature request: Real-time rounded corners on otherwise hard edges
##### Description of the problem NVIDIA's iRay/Mental Ray has the capability to automatically round corners that are sharp. This is very useful for making hard corners more realistic as very few corners in real-life are ultra sharp. Basically it can convert the left to the right: ![mental-ray-rounded-corners-example](https://cloud.githubusercontent.com/assets/588541/16027924/5ac0d62e-31a8-11e6-9a7e-d16e875d5680.jpg) I know that it is possible to do this with bevels, but I wonder if there is a real-time way to do this? More details: http://www.geonak.com/wp-content/uploads/2007/06/mia_roundcorners_Maya.pdf?2d12ba ##### Three.js version - [x] Dev - [x] r77 - [ ] ... ##### Browser - [x] All of them - [ ] Chrome - [ ] Firefox - [ ] Internet Explorer ##### OS - [x] All of them - [ ] Windows - [ ] Linux - [ ] Android - [ ] IOS ##### Hardware Requirements (graphics card, VR Device, ...)
Enhancement
low
Minor
160,094,119
opencv
Error while building with CUDA
I'm having the error after executing the following command: cmake -G "Unix Makefiles" -D CMAKE_CXX_COMPILER=/usr/bin/g++-4.9 -D CMAKE_C_COMPILER=/usr/bin/gcc-4.9 -D CMAKE_BUILD_TYPE=RELEASE -D CMAKE_INSTALL_PREFIX=/usr/local -D INSTALL_C_EXAMPLES=ON -D INSTALL_PYTHON_EXAMPLES=ON -D OPENCV_EXTRA_MODULES_PATH=~/Downloads/opencv/opencv_contrib/modules -D BUILD_EXAMPLES=ON -D WITH_TBB=ON -D WITH_V4L=ON -D WITH_QT=ON -D WITH_OPENGL=ON -D CUDA_NVCC_FLAGS="-ccbin gcc-4.9" -D CUDA_ARCH_BIN="2.0" -D WITH_TBB=ON -D BUILD_NEW_PYTHON_SUPPORT=ON -D WITH_V4L=ON -D ENABLE_FAST_MATH=1 -D CUDA_FAST_MATH=1 -D WITH_CUBLAS=1 -D BUILD_TIFF=ON -D BUILD_EXAMPLES=ON -D CUDA_GENERATION=Auto .. CMake Error at cuda_compile_generated_gpu_mat.cu.o.cmake:266 (message): Error generating file /home/bernardo/Downloads/opencv/opencv/build/modules/core/CMakeFiles/cuda_compile.dir/src/cuda/./cuda_compile_generated_gpu_mat.cu.o modules/core/CMakeFiles/opencv_core.dir/build.make:398: recipe for target 'modules/core/CMakeFiles/cuda_compile.dir/src/cuda/cuda_compile_generated_gpu_mat.cu.o' failed make[2]: **\* [modules/core/CMakeFiles/cuda_compile.dir/src/cuda/cuda_compile_generated_gpu_mat.cu.o] Error 1 I have installed and linked GCC 4.9 and gcc 4.8. ### Please state the information for your system - OpenCV version: 3.1 - Ubuntu 16.04 - Compiler: GCC 4.8, 4.9 ### In which part of the OpenCV library you got the issue? make
bug,category: build/install,category: gpu/cuda (contrib)
low
Critical
160,255,426
youtube-dl
YUNG CLOUD SUPPORT
## Please follow the guide below - You will be asked some questions and requested to provide some information, please read them **carefully** and answer honestly - Put an `x` into all the boxes [ ] relevant to your _issue_ (like that [x]) - Use _Preview_ tab to see how your issue will actually look like --- ### Make sure you are using the _latest_ version: run `youtube-dl --version` and ensure your version is _2016.06.14_. If it's not read [this FAQ entry](https://github.com/rg3/youtube-dl/blob/master/README.md#how-do-i-update-youtube-dl) and update. Issues with outdated version will be rejected. - [x ] I've **verified** and **I assure** that I'm running youtube-dl **2016.06.14** Please support yung.cloud ( a soundcloud like website) http://yung.cloud/ anthony@VMServer:~$ youtube-dl http://yung.cloud/index.php?a=track&id=17913 [1] 1932 anthony@VMServer:~$ [generic] index: Requesting header [redirect] Following redirect to http://yung.cloud/ [generic] yung: Requesting header WARNING: Falling back on generic information extractor. [generic] yung: Downloading webpage [generic] yung: Extracting information ERROR: Unsupported URL: http://yung.cloud/ **If you inspect the source, for every song there is a src thing that gives you the location of where the music is stored, for instance this song is stored in " http://yung.cloud/uploads/tracks/524978921_1618317889_768903362.mp3 "
site-support-request
low
Critical
160,294,231
rust
[rustbuild] do not delete sysroot directory
I tend to put various test files into `$DESTINATION/stage1/bin` so I can have a different terminal open and quickly test stage1 rustc against various test cases I have at hand for a particular thing I’m working on at the time without cluttering root of my checkout. rustbuild deleting the destination directory every build is inherently incompatible with this workflow. Consider not doing it.
C-enhancement,T-bootstrap,E-needs-design
low
Minor
160,315,635
kubernetes
Node status should include allocated resources info through the API
See #25355. Users want to be able to query the allocated resources for nodes and currently do this through `kubectl describe` which is both very inefficient as well as hard to parse the data out of.
priority/awaiting-more-evidence,sig/node,lifecycle/frozen,needs-triage
medium
Critical
160,347,189
rust
Match expressions use O(n) stack space with n branches in debug mode
I ran into this problem while working on a parser (https://github.com/evanw/esbuild/tree/rust). Here's a reduced test case: https://gist.github.com/evanw/06e074a1d6d5c21e8d32e2c26de07714. It contains two recursive functions, `small` and `large`, that each contain a match expression. Every call prints out the amount of stack space used. In debug: ``` small: stack space: 0.3kb stack space: 0.7kb stack space: 1.0kb stack space: 1.4kb stack space: 1.7kb stack space: 2.1kb stack space: 2.4kb stack space: 2.8kb stack space: 3.1kb stack space: 3.4kb stack space: 3.8kb large: stack space: 0.6kb stack space: 1.3kb stack space: 1.9kb stack space: 2.6kb stack space: 3.2kb stack space: 3.8kb stack space: 4.5kb stack space: 5.1kb stack space: 5.8kb stack space: 6.4kb stack space: 7.0kb ``` In release: ``` small: stack space: 0.0kb stack space: 0.1kb stack space: 0.2kb stack space: 0.4kb stack space: 0.5kb stack space: 0.6kb stack space: 0.7kb stack space: 0.8kb stack space: 0.9kb stack space: 1.0kb stack space: 1.1kb large: stack space: 0.0kb stack space: 0.1kb stack space: 0.2kb stack space: 0.4kb stack space: 0.5kb stack space: 0.6kb stack space: 0.7kb stack space: 0.8kb stack space: 0.9kb stack space: 1.0kb stack space: 1.1kb ``` I would expect the amount of stack space used by a match expression to be proportional to the stack space of the largest branch, not to the total stack space of all branches. The problem isn't too bad here but it causes my actual parser to use huge amounts of stack space and to crash with a stack overflow when parsing virtually all normal-sized inputs.
A-LLVM,C-enhancement,A-codegen,T-compiler,I-heavy,A-mir-opt,A-patterns,C-optimization
medium
Critical
160,374,745
youtube-dl
Site support request: instagram videos I liked
Is it possible to add list extractor for instagram videos I liked? Instagram API is able to return 300 last items I liked (need authentication). (I found this related blog http://symmetricinfinity.com/2013/04/06/download-your-likes-from-instagram.html)
request,account-needed
low
Minor
160,539,712
youtube-dl
cannot retreive infos from Gdrive folders (unsupported URL)
## Please follow the guide below - You will be asked some questions and requested to provide some information, please read them **carefully** and answer honestly - Put an `x` into all the boxes [ ] relevant to your _issue_ (like that [x]) - Use _Preview_ tab to see how your issue will actually look like --- ### Make sure you are using the _latest_ version: run `youtube-dl --version` and ensure your version is _2016.06.14_. If it's not read [this FAQ entry](https://github.com/rg3/youtube-dl/blob/master/README.md#how-do-i-update-youtube-dl) and update. Issues with outdated version will be rejected. - [X] I've **verified** and **I assure** that I'm running youtube-dl **2016.06.14** ### Before submitting an _issue_ make sure you have: - [X] At least skimmed through [README](https://github.com/rg3/youtube-dl/blob/master/README.md) and **most notably** [FAQ](https://github.com/rg3/youtube-dl#faq) and [BUGS](https://github.com/rg3/youtube-dl#bugs) sections - [X] [Searched](https://github.com/rg3/youtube-dl/search?type=Issues) the bugtracker for similar issues including closed ones ### What is the purpose of your _issue_? - [X] Bug report (encountered problems with youtube-dl) - [ ] Site support request (request for adding support for a new site) - [ ] Feature request (request for a new functionality) - [ ] Question - [ ] Other --- ### The following sections concretize particular purposed issues, you can erase any section (the contents between triple ---) not applicable to your _issue_ --- ### If the purpose of this _issue_ is a _bug report_, _site support request_ or you are not completely sure provide the full verbose output as follows: Add `-v` flag to **your command line** you run youtube-dl with, copy the **whole** output and insert it here. It should look similar to one below (replace it with **your** log inserted between triple ```): ``` $ youtube-dl -v --skip-download --get-id --get-title "https://drive.google.com/drive/folders/HIDDEN" [debug] System config: [] [debug] User config: [] [debug] Command-line args: [u'-v', u'--skip-download', u'--get-id', u'--get-title', u'https://drive.google.com/drive/folders/HIDDEN'] [debug] Encodings: locale UTF-8, fs UTF-8, out UTF-8, pref UTF-8 [debug] youtube-dl version 2016.06.14 [debug] Python version 2.7.6 - Linux-3.14.20-i686-with-glibc2.4 [debug] exe versions: avconv 9.16-6, avprobe 9.16-6, ffmpeg 9.16-6, rtmpdump 2.4 [debug] Proxy map: {} WARNING: Falling back on generic information extractor. ERROR: Unsupported URL: https://support.google.com/drive/answer/6286662?p=unsupported_browser&rd=1 Traceback (most recent call last): File "/tmp/youtube-dl/youtube-dl/youtube_dl/extractor/generic.py", line 1440, in _real_extract doc = compat_etree_fromstring(webpage.encode('utf-8')) File "/tmp/youtube-dl/youtube-dl/youtube_dl/compat.py", line 2524, in compat_etree_fromstring doc = _XML(text, parser=etree.XMLParser(target=_TreeBuilder(element_factory=_element_factory))) File "/tmp/youtube-dl/youtube-dl/youtube_dl/compat.py", line 2513, in _XML parser.feed(text) File "/usr/lib/python2.7/xml/etree/ElementTree.py", line 1642, in feed self._raiseerror(v) File "/usr/lib/python2.7/xml/etree/ElementTree.py", line 1506, in _raiseerror raise err ParseError: syntax error: line 1, column 0 Traceback (most recent call last): File "/tmp/youtube-dl/youtube-dl/youtube_dl/YoutubeDL.py", line 676, in extract_info ie_result = ie.extract(url) File "/tmp/youtube-dl/youtube-dl/youtube_dl/extractor/common.py", line 342, in extract return self._real_extract(url) File "/tmp/youtube-dl/youtube-dl/youtube_dl/extractor/generic.py", line 2140, in _real_extract raise UnsupportedError(url) UnsupportedError: Unsupported URL: https://support.google.com/drive/answer/6286662?p=unsupported_browser&rd=1 <end of log> ``` --- ### If the purpose of this _issue_ is a _site support request_ please provide all kinds of example URLs support for which should be included (replace following example URLs by **yours**): - Single video: https://www.youtube.com/watch?v=BaW_jenozKc - Single video: https://youtu.be/BaW_jenozKc - Playlist: https://www.youtube.com/playlist?list=PL4lCao7KL_QFVb7Iudeipvc2BCavECqzc --- ### Description of your _issue_, suggested solution and other information Explanation of your _issue_ in arbitrary form goes here. Please make sure the [description is worded well enough to be understood](https://github.com/rg3/youtube-dl#is-the-description-of-the-issue-itself-sufficient). Provide as much context and examples as possible. If work on your _issue_ required an account credentials please provide them or explain how one can obtain them. The folder was shared with public link sharing (anyone with the link can view).
request
low
Critical
160,571,584
youtube-dl
Unable to download https://mobile.twitter.com's video.
Example: $ youtube-dl -v https://twitter.com/i/moments/741297043239542784 [debug] System config: [] [debug] User config: [] [debug] Command-line args: ['-v', 'https://twitter.com/i/moments/741297043239542784'] [debug] Encodings: locale UTF-8, fs utf-8, out UTF-8, pref UTF-8 [debug] youtube-dl version 2016.06.14 [debug] Python version 3.4.2 - Linux-3.16.0-4-amd64-x86_64-with-debian-8.5 [debug] exe versions: ffmpeg 3.0.2-2, ffprobe 3.0.2-2, rtmpdump 2.4 [debug] Proxy map: {} [generic] 741297043239542784: Requesting header WARNING: Falling back on generic information extractor. [generic] 741297043239542784: Downloading webpage [generic] 741297043239542784: Extracting information [redirect] Following redirect to https://mobile.twitter.com/i/nojs_router?path=/i/moments/741297043239542784 [generic] 741297043239542784: Requesting header [redirect] Following redirect to https://mobile.twitter.com/i/moments/741297043239542784?m=1 [generic] 741297043239542784?m=1: Requesting header WARNING: Falling back on generic information extractor. [generic] 741297043239542784?m=1: Downloading webpage [generic] 741297043239542784?m=1: Extracting information ERROR: Unsupported URL: https://mobile.twitter.com/i/moments/741297043239542784?m=1 Traceback (most recent call last): File "/home/ant/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 676, in extract_info ie_result = ie.extract(url) File "/home/ant/bin/youtube-dl/youtube_dl/extractor/common.py", line 342, in extract return self._real_extract(url) File "/home/ant/bin/youtube-dl/youtube_dl/extractor/generic.py", line 2140, in _real_extract raise UnsupportedError(url) youtube_dl.utils.UnsupportedError: Unsupported URL: https://mobile.twitter.com/i/moments/741297043239542784?m=1 Thank you in advance. :)
request
low
Critical
160,578,836
go
cmd/gofmt: comments in expr-stmt are not arranged
Please answer these questions before submitting your issue. Thanks! 1. What version of Go are you using (`go version`)? go version go1.6 darwin/amd 2. What operating system and processor architecture are you using (`go env`)? GOARCH="amd64" GOBIN="" GOEXE="" GOHOSTARCH="amd64" GOHOSTOS="darwin" GOOS="darwin" GOPATH="/Users/hiro/.go" GORACE="" GOROOT="/Users/hiro/go1.6" GOTOOLDIR="/Users/hiro/go1.6/pkg/tool/darwin_amd64" GO15VENDOREXPERIMENT="1" CC="clang" GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fno-common" CXX="clang++" CGO_ENABLED="1" 3. What did you do? I was trying to preallocate buffer for encoding. After I ran `gofmt`, I expected comments in expr-stmt are arranged, but not. ``` go package main func main() { var val []byte var name string buf := make([]byte, 24+ // min buffer size 4+len(val)+ // tagLen + value 2+len(name)+1+ // nameLen + name + '\0' 16) // checksum _ = buf } ``` https://play.golang.org/p/wAVUh_sGmw 4. What did you expect to see? ``` go package main func main() { var val []byte var name string buf := make([]byte, 24+ // min buffer size 4+len(val)+ // tagLen + value 2+len(name)+1+ // nameLen + name + '\0' 16) // checksum _ = buf } ``` 5. What did you see instead? same as input.
NeedsFix
low
Minor
160,613,596
vscode
[css] Support <angle> units icon in CSS
In Firefox 49, there is an icon in the front of the angle unit, but the angle of the icon is constant. I hope: - **The VSCode can be a dynamic response to the actual point of view.** - **<kbd>Shift</kbd> + `click` to change the unit format.** ![Firefox DevTools](https://img.alicdn.com/tps/TB1zhUgKpXXXXX0XFXXXXXXXXXX-400-171.gif) **Spec**: https://drafts.csswg.org/css-values/#angles
help wanted,feature-request,css-less-scss
low
Major
160,621,611
opencv
Corrupted frames when reading RTSP stream
**System Information:** - OpenCV version: 3.1 with python - Host OS: Linux (Ubuntu 14.04) (virtual machine on Mac) - Compiler & CMake: GCC 4.8 & CMake 2.8.12.2 - Python version 3.4 ffmpeg: ``` ffmpeg version N-80279-g5d12cfa Copyright (c) 2000-2016 the FFmpeg developers built with gcc 4.8 (Ubuntu 4.8.4-2ubuntu1~14.04.3) configuration: --prefix=/home/vagrant/ffmpeg_build --pkg-config-flags=--static --extra-cflags=-I/home/vagrant/ffmpeg_build/include --extra-ldflags=-L/home/vagrant/ffmpeg_build/lib --bindir=/home/vagrant/bin --enable-gpl --enable-libass --enable-libfdk-aac --enable-libfreetype --enable-libmp3lame --enable-libopus --enable-libtheora --enable-libvorbis --enable-libvpx --enable-libx264 --enable-openssl --enable-libx265 --enable-nonfree libavutil 55. 24.100 / 55. 24.100 libavcodec 57. 46.100 / 57. 46.100 libavformat 57. 37.101 / 57. 37.101 libavdevice 57. 0.101 / 57. 0.101 libavfilter 6. 46.101 / 6. 46.101 libswscale 4. 1.100 / 4. 1.100 libswresample 2. 0.101 / 2. 0.101 libpostproc 54. 0.100 / 54. 0.100 ``` ### Expected behaviour I am passing rtsp link to VideoCapture and reading the frames. It should read the frames fine. ### Actual behaviour After some time, I start getting corrupted frames. For Example: If we consider image rows and cols, after certain row x, all the rows below have the same rgb values as x. After a few minutes it does not read the frame any more i.e. it returns 'False' on read function.
category: videoio,incomplete
low
Minor
160,671,741
vscode
Long Text longer than 10000 letters wrapped with [...]
- VSCode Version: 1.3.0-insiders - OS Version: Win 10 Steps to Reproduce: 1. Open a file with a very long line - over the limit of 10000 2. Position the cursor at the start of the line in question 3. Press 'End' keyboard key Result - the 'End' key does nothing, while it rather has to go to the end of the trimmed/loaded part of the line. All-in-all, I must say the approach to treating long lines is one of the worst shortcomming of VS Code (along with not being able to load big files at all). This approach makes the editor totally unusable for touching minified scripts and css for example, so I'd rather say you have to think of improving the performance and removing this serious limitation.
feature-request,editor-rendering
medium
Major
160,739,796
angular
state of the checkbox not getting updated even after its ng-model value is updated
- **I'm submitting a bug for state of the checkbox not getting updated even after its ng-model value is updated** - [ ] bug report **Current behavior** If you try and update the ngModel of a checkbox in say ngModelChange method, the ngModel value is updated but the checkbox still remains in previous state. **Expected/desired behavior** The state of checkbox should change as ngModel value changes. - **What is the motivation / use case for changing the behavior?** I am trying to implement "select all" checkbox through angular 2. I have a list of checkboxes and one select all checkbox. And in my use case it's so that if user checks all checkboxes from the list manually , I have to uncheck all the checkboxes from the list and check the "All" checkbox. So I have binded a ngModel and ngModelChange to all the checkboxes .Now what happens is if I try to update the ngModel in the ngModelChange method ,the state of checkbox is not changed even though the ngModel value is updated (since angular2 listens to events only and not to change in value of ngModel). I have tried to achieve this through the attribute directive as well but nothing seems to work. - **Angular version:** 2.0.0-beta.X - **Browser:** [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ] - **Language:** [all | TypeScript X.X | ES6/7 | ES5 | Dart]
type: bug/fix,workaround1: obvious,freq2: medium,area: forms,state: confirmed,forms: ngModel,P4
high
Critical
160,833,652
TypeScript
Add rule typescript.format.insertSpaceAfterOpeningAndBeforeClosingNamedImport
_From @unional on June 16, 2016 22:12_ - VSCode Version: 1.2.1 - OS Version: Windows 2012 R2 Currently object literal will have space added, but not named import: ``` ts // before format code import {Container} from './Container'; let x = {Container}; // after format code import {Container} from './Container'; let x = { Container }; ``` _Copied from original issue: Microsoft/vscode#7795_
Suggestion,Help Wanted,Domain: Formatter
low
Minor
160,833,922
TypeScript
Is it possible to link typescript interfaces to JSON files?
_From @Sequoia on June 16, 2016 20:3_ I know it's possible to do this [with json schemas](https://code.visualstudio.com/Docs/languages/json#_json-schemas-settings) but is it possible to do this with a typescript interface? _Copied from original issue: Microsoft/vscode#7792_
Suggestion,Needs Proposal
medium
Major
160,835,242
go
cmd/compile: complicated bounds check elimination
**1. go version go1.7beta1 windows/amd64** **2. set GOARCH=amd64** set GOBIN= set GOEXE=.exe set GOHOSTARCH=amd64 **set GOHOSTOS=windows** set GOOS=windows set GOPATH=F:\Go\ set GORACE= set GOROOT=F:\Go set GOTOOLDIR=F:\Go\pkg\tool\windows_amd64 set CC=gcc set GOGCCFLAGS=-m64 -mthreads -fmessage-length=0 -fdebug-prefix-map=C:\Users\Super\AppData\Local\Temp\go-build211527254=/tmp/go-build -gno-record-gcc-switches set CXX=g++ set CGO_ENABLED=1 **3. Runnable program:** ``` go // PrimeSpeed project PrimeSpeed.go package main import ( "fmt" "math" "time" // "unsafe" ) func mkCLUT() [65536]byte { var arr [65536]byte for i := 0; i < 65536; i++ { var cnt byte = 0 for v := (uint16)(i ^ 0xFFFF); v > 0; v &= v - 1 { cnt++ } arr[i] = cnt } return arr } var cnstCLUT [65536]byte = mkCLUT() func primesTest(top uint) int { lmtndx := (top - 3) >> 1 lstw := lmtndx >> 5 lmt := lstw + 1 topsqrtndx := (int(math.Sqrt(float64(top))) - 3) >> 1 cmpsts := make([]uint32, lstw+1) // start := uintptr(unsafe.Pointer(&cmpsts[0])) // step := unsafe.Sizeof(cmpsts[0]) for i := 0; i <= topsqrtndx; i++ { if cmpsts[i>>5]&(uint32(1)<<uint(i)) == 0 { p := (uint(i) << 1) + 3 for j := (p*p - 3) >> 1; j <= topi; j += p { cmpsts[j>>5] |= 1 << (j & 31) } // p := uintptr((uint(i) << 1) + 3) // lmt := uintptr(lmtndx) // for j := (p*p - 3) >> 1; j <= lmt; j += p { // *(*uint)(unsafe.Pointer(start + step*(j>>5))) |= 1 << (j & 31) // } } } msk := uint32(0xFFFFFFFE) << (lmtndx & 31) cmpsts[lstw] |= msk cnt := 1 for i := uint(0); i <= lstw; i++ { v := cmpsts[i] cnt += int(cnstCLUT[v&0xFFFF] + cnstCLUT[0xFFFF&(v>>16)]) } return cnt } func main() { n := uint(262146) strt := time.Now() sum := 0 for i := 0; i < 1000; i++ { sum += primesTest(n) } end := time.Now() fmt.Println("Found", sum, "primes up to", n, "in", end.Sub(strt), ".") } ``` play.golang.org link: https://play.golang.org/p/_E5R5JAlGW **4. When "go tool compile -S PrimeSpeed.go > PrimeSpeed.s" is run**, the inner tight composite number culling loop as quoted below: ``` line 36 for j := (p*p - 3) >> 1; j <= topi; j += p { line 37 cmpsts[j>>5] |= 1 << (j & 31) line 38 } ``` looks like the following assembly code from PrimeSpeed.s: ``` 0x00f1 00241 (Main.go:37) MOVQ R8, CX 0x00f4 00244 (Main.go:37) SHRQ $5, R8 0x00f8 00248 (Main.go:37) CMPQ R8, DX 0x00fb 00251 (Main.go:37) JCC $0, 454 0x0101 00257 (Main.go:37) MOVL (AX)(R8*4), R10 0x0105 00261 (Main.go:37) MOVQ CX, R11 0x0108 00264 (Main.go:37) ANDQ $31, CX 0x010c 00268 (Main.go:37) MOVL R9, R12 **;; saves 1 to r12** 0x010f 00271 (Main.go:37) SHLL CX, R9 0x0112 00274 (Main.go:37) ORL R10, R9 0x0115 00277 (Main.go:37) MOVL R9, (AX)(R8*4) 0x0119 00281 (Main.go:36) LEAQ 3(R11)(DI*2), R8 0x011e 00286 (Main.go:37) MOVL R12, R9 **;; restores 1 to r9 from r12** 0x0121 00289 (Main.go:36) CMPQ R8, BX 0x0124 00292 (Main.go:36) JLS $0, 241 ``` **5. I expected to see**: ``` 0x00f1 00241 (Main.go:37) MOVQ R8, CX 0x00f4 00244 (Main.go:37) SHRQ $5, R8 0x00f8 00248 (Main.go:37) CMPQ R8, DX ;; array bounds check, only if no -B option 0x00fb 00251 (Main.go:37) JCC $0, 454 ;; panic if out of bounds 0x0101 00257 (Main.go:37) MOVL (AX)(R8*4), R10 0x0105 00261 (Main.go:37) MOVQ CX, R11 0x0108 00264 (Main.go:37) ANDQ $31, CX (Main.go:37) MOVL $1,R9 **;; IMMEDIATE LOAD OF 1 to R9** (Main.go:37) SHLL CX, R9 (Main.go:37) ORL R10, R9 (Main.go:37) MOVL R9, (AX)(R8*4) (Main.go:36) LEAQ 3(R11)(DI*2), R8 (Main.go:36) CMPQ R8, BX (Main.go:36) JLS $0, 241 ``` Even better, without recalculating p = 2 \* i + 3 thus j += j + 2 \* i + 3 inside the inner loop: Includes changing order of instructions for processors without OOE: ``` 0x00f1 00241 (Main.go:37) MOVQ R8, R11 0x0105 00261 (Main.go:37) MOVQ R8, CX 0x00f4 00244 (Main.go:37) SHRQ $5, R11 0x0108 00264 (Main.go:37) ANDQ $31, CX 0x00f8 00248 (Main.go:37) CMPQ R11, DX ;; array bounds check, only if no -B option 0x00fb 00251 (Main.go:37) JCC $0, 454 ;; panic if out of bounds 0x0101 00257 (Main.go:37) MOVL (AX)(R11*4), R10 0x010c 00268 (Main.go:37) MOVL $1,R9 **;; IMMEDIATE LOAD OF 1 to R9** 0x010f 00271 (Main.go:37) SHLL CX, R9 0x0112 00274 (Main.go:37) ORL R10, R9 0x0119 00281 (Main.go:36) ADDL R12, R8 **;; ADD PRE-CALCULATED 'p' in R12 to 'j'** 0x0115 00277 (Main.go:37) MOVL R9, (AX)(R11*4) 0x0121 00289 (Main.go:36) CMPQ R8, BX 0x0124 00292 (Main.go:36) JLS $0, 241 ``` The following is the same loop without bounds checks generated for C/C++ with the Visual Studio compiler (intel assembler format): ``` $Loop: mov edx, esi mov ecx, esi shr edx, 5 and ecx, 31 ; 0000001fH mov eax, 1 add esi, edi ; add 'p' in edi to 'j' shl eax, cl or DWORD PTR [ebx+edx*4], eax cmp esi, ebp ; ebp contains 'topi' jbe SHORT $Loop ``` Note that the above uses a total of seven registers for this inner loop, so the same code is generated for x86 and x64 compilations. Unfortunately, it takes another register to hold the upper array bound for a range check and the x86 architecture can only have seven available; however, it is possible to slightly change the code as follows: ``` line 36 bnds := lstw + 1 line 37 k := (p*p - 3) >> 1 line 38 for j, w := j, j >> 5; w <= bnds; w = r >> 5 { line 39 cmpsts[w] |= 1 << (j & 31) line 40 j += p line 41 } ``` which for Visual Studio C/C++ generates the following same number of instructions in the loop: ``` $Loop: mov ecx, edx mov eax, 1 and ecx, 31 ; 0000001fH add edx, edi ; add 'p' in edi to 'j' shl eax, cl or DWORD PTR [ebx+esi*4], eax **$Start:** mov esi, edx shr esi, 5 cmp esi, ebp **; ebp contains the array length, bnds** jb SHORT $Loop **; this is the same as doing an array bounds check** ``` and it can be seen that the array bounds check is now done at the same time as the loop completion check; it should be a simple matter to clue the compiler that 'bnds' contains the array length, perhaps by assigning it inside the loop as len(cmpsts) as is done for C# x86 code so that it recognizes that the bounds check is already done. The start point of the loop could be the line after the "or" line at the **$Start**: label or an external check could be implemented to ensure that the bounds check is done for the first loop before the array is accessed as is done for the Visual Studio C/C++ compiler. As demonstrated above, the golang code runs slower than C/C++ code by almost a factor of two on some x86 processors and more than that factor for x86 processors. It also runs slightly slower than C#/Java for both architectures.
Performance,NeedsFix
low
Critical
160,873,659
opencv
Different results of CascadeClasifier on CPU and GPU
### My system - OpenCV version: 3.1 - Host OS: Linux (Ubuntu 14.04) - CPU: intel i7 3770 - Video card: GTX-950 - Video driver: v.352.93 ### In which part of the OpenCV library you got the issue? - objdetect, cudaobjdetect - cv::CascadeClassifier, cv::cuda::CascadeClassifier ### Expected behaviour I built the latest OpenCV version with cuda support from master branch. After that I tried to use CPU cv::CascadeClassifier and GPU cv::cuda::CascadeClassifier, but faced with a strange result. I use same xml from opencv/data/haarcascades_cuda/haarcascade_fullbody.xml for both CPU and GPU version of CascadeClassifier. CPU Classifier with this xml shows much more objects than GPU classifier. Another strange thing, that when I set ScaleFactor to 2, speed of CPU version boosted up to 4 times, but GPU version becomes just slightly faster. ### Additional description [OpencvQA](http://answers.opencv.org/question/96452/different-results-of-cascadeclasifier-on-cpu-and-gpu/) [Video demo: example.ogv.zip](https://github.com/Itseez/opencv/files/320887/example.ogv.zip) [Video demo with same parameters values: example_v2.ogv.zip](https://github.com/Itseez/opencv/files/322422/example_v2.ogv.zip) ### Code example to reproduce the issue [Bitbucket: main.cpp](https://bitbucket.org/barbatum/cascadeqa/raw/571cdafc1b230cb5ec5d2c7b6b766895549d2d1e/CascadeQA/main.cpp) [Bitbucket: qmake project + deps build bash script](https://bitbucket.org/barbatum/cascadeqa)
bug,priority: low,category: objdetect,category: gpu/cuda (contrib)
low
Major
160,946,741
flutter
Vertical text alignment based off last baseline
null
c: new feature,framework,a: typography,P3,team-framework,triaged-framework
low
Major
160,997,143
TypeScript
Signatures of intersection/union types properties
Consider next example: ``` interface A{ f:string; set_f(val:string) : void; get_f() : string; } interface B{ f:number; set_f(val:number) : void; get_f() : number; } let n:number; let str:string let first : A&B; first.f = n; // error, as f has type number&string. Probably OK, but probably it should be number|string, to be symmetric with set_f function. first.f = str; // error, as f has type number&string. n = first.f; str = first.f; first.set_f(n); first.set_f(str); n = first.get_f(); // error, typescript prefer to use first signature () => string. Shouldn't it be string&number. str = first.get_f(); let second : A|B; second.f = n; // Ops, no error! But it should be at least string&number here second.f = str;// Ops, no error! But it should be at least string&number here n = second.f; // error, typescript prefer to use first signature string. It should be string|number str = second.f;// Ops, no error, typescript prefer to use first signature string. It should be string|number second.set_f(n); //error, lack a call signature. It's really good, but better if it would be (string&number) => void second.set_f(str); //error, lack a call signature. n = second.get_f(); // error, cool, typescript was able to correctly infer result as string|number str = second.get_f();// error, cool, typescript was able to correctly infer result as string|number ``` With #9167 additional to previous was added preserving readonly flag for intersection. Should't readonly flag be reset if any of intersection member has no such flag? As intersection should extend possibilities of type, and never narrow down it.
Suggestion,Needs Proposal
low
Critical
161,012,562
TypeScript
[FEATURE REQUEST] Please supply a minified version with only transpilation functionality
Please supply a minified version (inc npm). Please also let this be a new js file with only parts needed for transpilation. This will aid our in-browser usages. thanks
Suggestion,Help Wanted,API
low
Major
161,032,183
go
cmd/compile: do front-end constant evaluation across simple inlined function boundaries
``` go func i(x int) int { return x } func f(a int) bool { switch a { case 1, 2, 3, 4, 5, 6: return true } return false } func g(a int) bool { switch a { case i(1), i(2), i(3), i(4), i(5), i(6): return true } return false } ``` f and g should compile to the same code. They don't. In g, i(n) is not recognized as a constant case, because i(n) ends up being a tempname introduced to hold the inlined return value from i. As a result, g does not use binary search over the cases. The SSA back-end can see past such things, but several important optimization decisions are made in the front-end on a const/non-const basis. As a first pass, maybe recognized inlined functions containing exactly one return statement and inline the returned expression directly. This may also require work to avoid converting inlined arguments from constants to tempnames, which itself might be useful. Sample real world code in which this occurs, from asm9.go in the s390x obj code: ``` go func OPVCC(o uint32, xo uint32, oe uint32, rc uint32) uint32 { return o<<26 | xo<<1 | oe<<10 | rc&1 } func opform(ctxt *obj.Link, insn uint32) int { switch insn { default: ctxt.Diag("bad insn in loadform: %x", insn) case OPVCC(58, 0, 0, 0), // ld OPVCC(58, 0, 0, 0) | 1<<1, // lwa OPVCC(62, 0, 0, 0): // std return DS_FORM case OP_ADDI, // add OPVCC(32, 0, 0, 0), // lwz OPVCC(42, 0, 0, 0), // lha OPVCC(40, 0, 0, 0), // lhz OPVCC(34, 0, 0, 0), // lbz OPVCC(50, 0, 0, 0), // lfd OPVCC(48, 0, 0, 0), // lfs OPVCC(36, 0, 0, 0), // stw OPVCC(44, 0, 0, 0), // sth OPVCC(38, 0, 0, 0), // stb OPVCC(54, 0, 0, 0), // stfd OPVCC(52, 0, 0, 0): // stfs return D_FORM } return 0 } ```
Performance,NeedsFix,compiler/runtime
low
Minor
161,064,954
TypeScript
Suggestion: Upper-bound generic type constraints
This is a proposal for generic structural supertype constraints. I'll first detail the proposal, and then get into a discussion about use-cases. ## Proposal A supertype constraint is a constraint on a generic type parameter to be the structural _supertype_ of another type. It's like a subtype/inheritance constraint, but from the other direction. For example, let's say we have a square: ``` interface Square {width : number; height : number} ``` In this suggested syntax, you could write: ``` performAction<T extended by Square>(partialSquare : T) {} ``` This means the type `T` must be a structural supertype of square. So the potential candidates for `T` are: ``` {width : number}, {height : number}, Square, {} ``` It's an established kind of type constraint, not something I just made up. Although it's not exactly common, some languages do implement this feature, such as Scala. In Scala, you can write: ``` def performAction[T >: Square](obj : T) = { ... } ``` To express a supertype/upper bound constraint. In this case, of course, the constraint isn't structural -- `T` must declare that it implements `Square`. ## Utility In most languages, including Scala, this kind of constraint isn't very useful. It only comes up in certain specific situations. However, Javascript libraries often have this kind of API, where you're allowed to specify the partial properties of an object to modify it (the rest remain at their previous value). In many cases, you can support this by having optional interface members, but isn't always possible or correct. An important example is React, which defines a method called `setState`: ``` class Component { var state; setState(partialState) { //merges the properties of partialState with the current state. } } ``` The right signature for this method should be: ``` class Component<Props, State> { setState<PartialState extended by State>(partialState : PartialState) { //merges the properties of partialState with the current state. } } ``` Currently,the definition files state that it is: ``` setState(fullState : State) { //merges the properties of partialState with the current state. } ``` Which doesn't fully capture the functionality of the method. ## Notes The suggested syntax doesn't give us a nice way of combining both subtype and supertype constraints. One possibility is: ``` exampleMethod<T extends LowerBound and extended by UpperBound> ```
Suggestion,Awaiting More Feedback
medium
Major
161,089,562
TypeScript
Rename doesn't work for string literal compared to string literal type
In the below, try to rename `"ADD_TODO"` in the case clause. It fails. ``` ts interface AddTodo { type: "ADD_TODO"; text: string; } interface DeleteTodo { type: "DELETE_TODO"; position: number newText: string; } type TodoAction = AddTodo | DeleteTodo; function dispatchOrSomething(action: TodoAction) { switch (action.type) { case "ADD_TODO": break; case "DELETE_TODO": } } ```
Bug
low
Minor
161,099,596
go
cmd/compile: poor register allocator behavior in compression code
Please answer these questions before submitting your issue. Thanks! 1. What version of Go are you using (`go version`)? go1.6 windows/amd64 and go1.7beta1 windows/amd64 2. What operating system and processor architecture are you using (`go env`)? set GOARCH=amd64 set GOBIN= set GOEXE=.exe set GOHOSTARCH=amd64 set GOHOSTOS=windows set GOOS=windows set GOPATH=E:\Users\fred\Documents\Prog\kanzi\go set GORACE= set GOROOT=E:\Program Files\go set GOTOOLDIR=E:\Program Files\go\pkg\tool\windows_amd64 set GO15VENDOREXPERIMENT=1 set CC=gcc set GOGCCFLAGS=-m64 -mthreads -fmessage-length=0 set CXX=g++ set CGO_ENABLED=1 3. What did you do? I ran "go build TestZRLT.go" then "TestZRLT.exe" both for Go 1.6 and 1.7 beta1 The source code is very simple: https://github.com/flanglet/kanzi/blob/master/go/src/kanzi/test/TestZRLT.go. It runs a correctness and a performance test tor the Zero Run Length Transform: https://github.com/flanglet/kanzi/blob/master/go/src/kanzi/function/ZRLT.go. 4. What did you expect to see? I expected to see no performance regression from 1.6 to 1.7beta1 5. What did you see instead? ZRLT encoding is much faster with 1.7beta1 but decoding is much slower. Output for 1.6: Speed test Iterations: 50000 ZRLT encoding [ms]: 10694 Throughput [MB/s]: 222 ZRLT decoding [ms]: 7419 Throughput [MB/s]: 321 ZRLT encoding [ms]: 10753 Throughput [MB/s]: 221 ZRLT decoding [ms]: 7472 Throughput [MB/s]: 319 ZRLT encoding [ms]: 10724 Throughput [MB/s]: 222 ZRLT decoding [ms]: 7393 Throughput [MB/s]: 322 Output for 1.7beta1: Speed test Iterations: 50000 ZRLT encoding [ms]: 6834 Throughput [MB/s]: 348 ZRLT decoding [ms]: 11560 Throughput [MB/s]: 206 ZRLT encoding [ms]: 6828 Throughput [MB/s]: 349 ZRLT decoding [ms]: 11589 Throughput [MB/s]: 205 ZRLT encoding [ms]: 6790 Throughput [MB/s]: 351 ZRLT decoding [ms]: 11558 Throughput [MB/s]: 206 I narrowed down the issue to the run length decoding loop: ``` for val <= 1 { runLength = (runLength << 1) | int(val) srcIdx++ if srcIdx >= srcEnd { break } val = src[srcIdx] } ``` If I replace 'for val <= 1 {' with 'for val&1 == val {', the decoding becomes much faster (although not as fast as with Go 1.6) Output for 1.7beta1 with code change: Speed test Iterations: 50000 ZRLT encoding [ms]: 6800 Throughput [MB/s]: 350 ZRLT decoding [ms]: 7669 Throughput [MB/s]: 310 ZRLT encoding [ms]: 6813 Throughput [MB/s]: 349 ZRLT decoding [ms]: 7689 Throughput [MB/s]: 310 ZRLT encoding [ms]: 6775 Throughput [MB/s]: 351 ZRLT decoding [ms]: 7662 Throughput [MB/s]: 311
Performance,NeedsFix,compiler/runtime
medium
Major
161,182,296
TypeScript
Show inherited comments in quick info
TypeScript Version: 1.8.10 Have an interface in one file ``` interface IFooController { /** * random comment * @returns {string} Returns a string */ test(): string; } export default IFooController; ``` In another file have a class that implements that interface ``` import IFooController from "../Interfaces/Controllers/IFooController"; export default class FooController implements IFooController { test(){ } } ``` **Expected behavior:** See the comments of the interface when hover over the class method **Actual behavior:** See nothing. This doesn't happen with functions and class comments. This only happens when interface is imported. Using Microsoft Visual Studio Professional 2015 Version 14.0.25123.00 Update 2
Suggestion,In Discussion,API,Domain: Quick Info,Experience Enhancement
low
Minor