id
int64 393k
2.82B
| repo
stringclasses 68
values | title
stringlengths 1
936
| body
stringlengths 0
256k
⌀ | labels
stringlengths 2
508
| priority
stringclasses 3
values | severity
stringclasses 3
values |
|---|---|---|---|---|---|---|
153,669,465 | youtube-dl | site support: likeafool | - [x] I've **verified** and **I assure** that I'm running youtube-dl **2016.05.01**
### Before submitting an _issue_ make sure you have:
- [x] At least skimmed through [README](https://github.com/rg3/youtube-dl/blob/master/README.md) and **most notably** [FAQ](https://github.com/rg3/youtube-dl#faq) and [BUGS](https://github.com/rg3/youtube-dl#bugs) sections
- [x] [Searched](https://github.com/rg3/youtube-dl/search?type=Issues) the bugtracker for similar issues including closed ones
### What is the purpose of your _issue_?
- [ ] Bug report (encountered problems with youtube-dl)
- [x] Site support request (request for adding support for a new site)
- [ ] Feature request (request for a new functionality)
- [ ] Question
- [ ] Other
---
- Single video: http://www.likeafool.com/video/13799/moose-unexpectedly-gives-birth-to-twins
- http://www.likeafool.com/files/a7f28614a5c01cbb28b62df08871bc19
| site-support-request | low | Critical |
153,764,287 | TypeScript | Make default JSX mode "react" | To enable JSX syntax in TypeScript you need two steps:
- add `"jsx": "react"` to `"compilerOptions"` in `tsconfig.json`
- use `.tsx` extension
This is quite troublesome if you want to reuse certain generators/boilerplates/build scripts for us. It is also against the single source of truth principle and can be confusing. I recently stumbled over a bug where we used the `.tsx` extension, but hadn't configured the `tsconfig.json`.
There was a lot of discussion recently about changing the `.js` extension to `.mjs` to introduce ES6 modules to Node and many people are against that and prefer to have an additional flag in the `package.json`.
I'd like to see the same for TypeScript and JSX:
- the `.tsx` extension is purely optional
- only `"jsx": "react"` in `tsconfig.json` is mandatory
| Suggestion,Help Wanted,Good First Issue | medium | Critical |
153,764,521 | vscode | isWatching/background task as preLaunchTask in launch.json | It would be nice to have a watcher task as preLaunchTask in launch.json. At the moment this is not possible because the launch task will not start before the preLaunchTask ends.
A long running preLaunchTask should have a regex similar to problemMatcher to wait for a specific text in the output window before executing the launch task.
In my scenario I'm running webpack dev server as a watcher task. I want this task to run if <kbd>F5</kbd> is hit and the preLaunchTask is not running. To delay the debugger launch it would be useful to test for a specific string in the output window `webpack: bundle is now VALID.`
| feature-request,tasks | high | Critical |
153,842,295 | go | x/review/git-codereview: Change-Id hook silently doesn't run anymore when codereview.cfg is not present | This is a regression introduced in
https://go-review.googlesource.com/#/c/19560/
Before that change, if the hooks were installed for a private `foobar.com` Gerrit origin (i.e. not `googlesource.com`), they would all run. After that change, the hook code tries to figure out if Gerrit is in use, and when not, the Change-Id line is silently not added. Unfortunately, the heuristic to determine if Gerrit is in use (`haveGerrit()`) errs on the negative side. Consequently `git-codereview mail` is rejected by Gerrit because of the missing Change-Id. The failure is hard to debug because the hooks seem correctly installed, and it is especially annoying as git-codereview may have removed old working hooks in the past [1] to install its own.
One workaround is to create a `codereview.cfg` file in repo's root with a valid gerrit value. But it's not that great because for most installations it should be self-evident what is the Gerrit origin, it feels like a unwarranted burden on a lot of people (see: #15073) to introduce that file in many old and new gerrit repos.
The hard problem seems to be the runtime determination of what hooks should be running. Specifically, in the change above, Russ described how he wants the "issue" hook to run on non-Gerrit repo, but not the Change-Id one.
I propose to remove runtime determination of what hooks should run in favor of explicit configuration. i.e. `git-codereview hooks` would evolve to the following:
- Like current behavior, any git-codereview sub-command would install all the hooks, if and only if a valid Gerrit is detected.
- Like current behavior, if `git-codereview hooks` is run manually, it would force hooks installation regardless of `haveGerrit()` value. But, unlike current behavior it would also enable all the hook functions: issuerepo, gofmt, change-id. (See below how hooks are enabled).
- If arguments are passed to `git-codereview hooks`, where arguments could be any sub-set of 'issuerepo', 'gofmt' and 'change-id', then it would only enable those.
The git hook script should probably stay a simple exec as it is today, because it is hard to replace and extend in the future. On the other hand, git provides a very powerful `git config` set of commands that git-coderereview could run on behalf of the user to set and get the different expected behaviors. https://go-review.googlesource.com/#/c/19684/ proposes something similar for reading the configuration, although I suggest we take it further and lean on the dedicated git interfaces to do the writing and reading.
I'm happy to work on a CL if that solution is deemed acceptable.
1. https://github.com/golang/review/blob/77ae237af753cd4f4820e67cdf058aea410bccc7/git-codereview/hook.go#L31
| NeedsInvestigation | low | Critical |
153,859,133 | go | spec: when exactly do we evaluate the LHS variable in a tuple assignment? | Please answer these questions before submitting your issue. Thanks!
1. What version of Go are you using (`go version`)?
gccgo version 4.9.3
2. What operating system and processor architecture are you using (`go env`)?
Ubuntu 14.04 on AWS t2.micro
3. What did you do?
If possible, provide a recipe for reproducing the error.
A complete runnable program is good.
A link on play.golang.org is best.
Deleting from a slice as suggested by https://github.com/golang/go/wiki/SliceTricks, raises an index out of bound error when compiling with gccgo. The following toy program works fine using GC but not with GCCGO:
```
package main
import "fmt"
func main() {
xs := []int{0,1,2,3,4}
i := 2
xs, xs[len(xs)-1] = append(xs[:i], xs[i+1:]...), 0
fmt.Println(xs)
}
```
https://play.golang.org/p/f039m1h7Z1
Note: while this toy example is a slice of ints, I'm using the delete code for removing an entry from a slice of pointers. The bug is in `xs[len(xs)-1] = 0`.
1. What did you expect to see?
`[0 1 3 4]`
1. What did you see instead?
```
panic: runtime error: index out of range
goroutine 1 [running]:
main.main
/home/ubuntu/Go/src/bad/remove.go:8
```
| NeedsFix | medium | Critical |
153,876,826 | flutter | Add support for magic tap | iOS accessibility has the notion of a context-sensitive "perform the action that makes the most sense here" action -- they call it the Magic Tap.
Per the [iOS Developer Library](https://developer.apple.com/library/ios/featuredarticles/ViewControllerPGforiPhoneOS/SupportingAccessibility.html):
> Magic Tap. A two-finger double-tap that performs the most-intended action.
This can be used, for example, to allow the user to play and pause music in a music app without hunting for the play/pause button.
| c: new feature,platform-ios,framework,a: accessibility,P3,team-ios,triaged-ios | low | Major |
153,896,974 | go | compress/flate: add 3-byte matching for higher compression levels | Using `9af83462`
The recent changes to `compress/flate` has provided pretty good improvements overall to the compression speeds, but I have noticed a few extraordinary cases where the compression ratio suffers significantly.
This [spreadsheet compares the output sizes](https://docs.google.com/spreadsheets/d/15kBp7rWX4FhC3K4CK0-mOsMObVOK_e0-3D97p_sWFBg/edit?usp=sharing) from go1.6 to current go.tip on a number of compression benchmarks. All tests were done using the `flate.DefaultCompression` setting.
Most notably, the [clegg.tiff image from the ACT corpus](http://compression.ca/act/act-files.html) experiences a 44% increase in output size (511928 to 741046 bytes).
I think it would be worthwhile to understand what causes this fairly significant regression in compression ratio before the go1.7 release.
cc @nigeltao @klauspost
| NeedsInvestigation | low | Major |
153,907,610 | go | encoding/json: support decoding to []int from []string by applying tag ,string | Please answer these questions before submitting your issue. Thanks!
1. What version of Go are you using (`go version`)?
1.6
2. What operating system and processor architecture are you using (`go env`)?
set GOARCH=amd64
set GOBIN=
set GOEXE=.exe
set GOHOSTARCH=amd64
set GOHOSTOS=windows
set GOOS=windows
set GOPATH=D:\litead\oxygen
set GORACE=
set GOROOT=C:\go
set GOTOOLDIR=C:\go\pkg\tool\windows_amd64
set GO15VENDOREXPERIMENT=1
set CC=gcc
set GOGCCFLAGS=-m64 -mthreads -fmessage-length=0
set CXX=g++
set CGO_ENABLED=1
3. What did you do?
If possible, provide a recipe for reproducing the error.
A complete runnable program is good.
A link on play.golang.org is best.
[https://play.golang.org/p/A4CLM3P6Dw](https://play.golang.org/p/A4CLM3P6Dw)
4. What did you expect to see?
decode the int64 slice successfully
5. What did you see instead?
an error:
> json: cannot unmarshal string into Go value of type int64
according to the documentation, the behavior is correct, but this makes it hard to decode an int64 slice (although there are workarounds). It will be good if 'string' tag could also be applied to slices.
| NeedsDecision,FeatureRequest | low | Critical |
153,921,268 | angular | Support for Dynamic Content Projection | # Use Case
`<ng-content>` allows for static (compile time resolution) projection of content. There are cases where the projection needs to be controlled programmatically. A common example is when the parent component would like to wrap/decorate the child components during projection.
# Mental Model
The mental model would be that `<ng-content>` is for fast static projection, but for dynamic projection one would use a query to get a hold of the child components in the form of `ViewRef`s which could then be inserted programmatically at any location in the tree.
# Possible Solution
- `ContentViewRef` extends `ViewRef`
- `@Content(selector)` Provides a way to select direct children content elements using CSS selectors. (This would be after directives such as `ngFor` would unroll the content, and it would be in the correct order.)
- This would allow selection of elements rather than directives. These `ContentViewRef`s could then be reinserted to any `ViewContainerRef`
- We would need `ngViewOutlet` (similar to `ngTemplateOutlet`).
``` ts
@Component({
template: `
<div *ngFor="let view of allViews">
<template ngViewOutlet="view"></template>
</div>
<ng-content><!-- project non selected nodes, such as text nodes --></ng-content>
`
})
class MySelect {
@Content('*') allViews: ContentViewRef[];
// another example
@Content('my-option') optionViews: ContentViewRef[];
}
```
``` ts
@Component({
selector: 'app',
template: `
<my-select>
Option
<my-option>header</my-option>
<my-option *ngFor="let item in items">unrolled items {{item}}</my-option>
<my-option-group>
<my-option>
foo <b>bar</b>
<other-directive />
</my-option>
<my-separator></my-separator>
<my-option></my-option>
</my-option-group>
</my-select>
`
})
class App {}
```
| feature,state: Needs Design,area: core,core: content projection,feature: under consideration | high | Critical |
153,925,534 | rust | confusing lifetime inference | Consider following snippet:
``` rust
use std::error::Error;
use std::io::{self, ErrorKind};
fn caused_of<'a>(mut err: &'a (Error + 'static)) -> Option<&'a io::Error> {
loop {
match err.downcast_ref::<io::Error>() {
None => match err.cause() {
None => return None,
Some(cause) => err = cause,
},
d => return d,
}
}
}
fn main() {
let e = io::Error::new(ErrorKind::Other, "oh no!");
println!("{:?}", caused_of(&e));
}
```
According to [Book](https://doc.rust-lang.org/book/lifetimes.html#lifetime-elision), cause's lifetime should be err's lifetime. which is 'a, so it should be safe to assign cause to err directly. But I got following warnnings:
```
test.rs:8:34: 8:39 error: cannot infer an appropriate lifetime for autoref due to conflicting requirements [E0495]
test.rs:8 None => match err.cause() {
^~~~~
test.rs:8:30: 8:41 note: first, the lifetime cannot outlive the method call at 8:29...
test.rs:8 None => match err.cause() {
^~~~~~~~~~~
test.rs:8:30: 8:33 note: ...so that method receiver is valid for the method call
test.rs:8 None => match err.cause() {
^~~
test.rs:5:75: 15:25 note: but, the lifetime must be valid for the lifetime 'a as defined on the block at 5:74...
test.rs:5 fn caused_of<'a>(mut err: &'a (Error + 'static)) -> Option<&'a io::Error> {
^
test.rs:10:48: 10:53 note: ...so that trait type parameters matches those specified on the impl (expected std::ops::CoerceUnsized<&'a std::error::Error + 'static>, found std::ops::CoerceUnsized<&std::error::Error + 'static>)
test.rs:10 Some(cause) => err = cause,
^~~~~
error: aborting due to previous error
```
Am I missing something here?
| A-type-system,C-enhancement,A-diagnostics,A-lifetimes,T-compiler,T-types | low | Critical |
153,929,347 | youtube-dl | Support site film.qq.com | ## Please follow the guide below
- You will be asked some questions and requested to provide some information, please read them **carefully** and answer honestly
- Put an `x` into all the boxes [ ] relevant to your _issue_ (like that [x])
- Use _Preview_ tab to see how your issue will actually look like
---
### Make sure you are using the _latest_ version: run `youtube-dl --version` and ensure your version is _2016.05.01_. If it's not read [this FAQ entry](https://github.com/rg3/youtube-dl/blob/master/README.md#how-do-i-update-youtube-dl) and update. Issues with outdated version will be rejected.
- [x] I've **verified** and **I assure** that I'm running youtube-dl **2016.05.01**
### Before submitting an _issue_ make sure you have:
- [x] At least skimmed through [README](https://github.com/rg3/youtube-dl/blob/master/README.md) and **most notably** [FAQ](https://github.com/rg3/youtube-dl#faq) and [BUGS](https://github.com/rg3/youtube-dl#bugs) sections
- [x] [Searched](https://github.com/rg3/youtube-dl/search?type=Issues) the bugtracker for similar issues including closed ones
### What is the purpose of your _issue_?
- [ ] Bug report (encountered problems with youtube-dl)
- [x] Site support request (request for adding support for a new site)
- [ ] Feature request (request for a new functionality)
- [ ] Question
- [ ] Other
Single video:http://film.qq.com/cover/q/qoudfsxphflt789.html
| site-support-request,geo-restricted,account-needed | low | Critical |
154,099,060 | nvm | `nvm upgrade`? | Would it be possible to add something like `nvm upgrade`? I imagine it would upgrade to the latest minor/patch version of the currently active version (or just latest patch for v0.x), and would be functionally equivalent to something like `nvm install [major version] --reinstall-packages-from=$(nvm version)`. There could also be an optional switch to delete the old version.
I've been using this in my profile, which isn't quite as nice as I have to specify the new version to install:
``` bash
# nvm-upgrade NEW_VERSION
#
# Installs the specified version of node via nvm, reinstalling all global
# packages from the currently activated version of node. Does not delete
# the previous node version.
function nvm-upgrade() {
nvm install $1 --reinstall-packages-from=`nvm version`
nvm use $1
npm install -g npm
npm upgrade -g
}
```
| feature requests | low | Minor |
154,113,298 | neovim | slow movement, highlighting on long lines | - Neovim version: 0.1.4
- Vim behaves differently? Vim version: 7.4.1797-1
- Operating system/version: Arch Linux 4.4.8-1-lts
- Terminal name/version: xterm
- `$TERM`: xterm
### Actual behaviour
Extremely slow cursor movement in files with long lines (e.g. [englishdictionary.sql](https://sourceforge.net/projects/mysqlenglishdictionary/files/englishdictionary.sql/download)). Apparently caused by very inefficient highlighting (slow regexps?).
### Expected behaviour
Cursor movement at normal speed (i.e. without getting stuck indefinitely).
### Steps to reproduce using `nvim -u NORC`
```
nvim -u NORC englishdictionary.sql
```
Vim behavior is the same, i.e. bad.
The reason why I'm raising this issue is to propose some timeout for highlighting. I'm working quite a lot with such long-line files and it's pain without highlighting and even more with it.
Even some hack as switching off highlighting for lines longer than some configurable _N_ would be fine, because my goal is to edit the file and work with it (and with the indefinitely hung nvim it's impossible to run `:syntax off`).
| performance,bug-vim,syntax,display,normal-mode | medium | Major |
154,145,615 | youtube-dl | A suggestion to move username@password in URI into --proxy-user --proxy-pass | - [x] I've **verified** and **I assure** that I'm running youtube-dl **2016.05.10**
- [x] At least skimmed through [README](https://github.com/rg3/youtube-dl/blob/master/README.md) and **most notably** [FAQ](https://github.com/rg3/youtube-dl#faq) and [BUGS](https://github.com/rg3/youtube-dl#bugs) sections
- [x] [Searched](https://github.com/rg3/youtube-dl/search?type=Issues) the bugtracker for similar issues including closed ones
### What is the purpose of your _issue_?
- [x] Bug report (encountered problems with youtube-dl)
- [x] Feature request (request for a new functionality)
---
```
youtube-dl --verbose --proxy "socks5://username%%40domainname.com:P%%[email protected]:1080" https://www.youtube.com/watch?v=6W5pq4bIzIw
[youtube] 6W5pq4bIzIw: Downloading webpage
[debug] System config: []
[debug] User config: []
[debug] Command-line args: [u'--verbose', u'--proxy', u'socks5://username%%40domainname.com:P%%[email protected]:1080', u'https://www.youtube.com/watch?v=6W5pq4bIzIw']
[debug] Encodings: locale cp1252, fs mbcs, out cp437, pref cp1252
[debug] youtube-dl version 2016.05.10
[debug] Python version 2.7.10 - Windows-7-6.1.7601-SP1
[debug] exe versions: ffmpeg N-79000-g66edd86, ffprobe N-79000-g66edd86, rtmpdump 2.4
[debug] Proxy map: {u'http': u'socks5://username%%40domainname.com:P%[email protected]:1080', u'https': u'socks5://username%%40domainname.com:P%[email protected]:1080'}
Traceback (most recent call last):
File "__main__.py", line 19, in <module>
File "youtube_dl\__init__.pyo", line 421, in main
File "youtube_dl\__init__.pyo", line 411, in _real_main
File "youtube_dl\YoutubeDL.pyo", line 1735, in download
File "youtube_dl\YoutubeDL.pyo", line 676, in extract_info
File "youtube_dl\extractor\common.pyo", line 341, in extract
File "youtube_dl\extractor\youtube.pyo", line 1216, in _real_extract
File "youtube_dl\extractor\common.pyo", line 501, in _download_webpage
File "youtube_dl\extractor\common.pyo", line 408, in _download_webpage_handle
File "youtube_dl\extractor\common.pyo", line 388, in _request_webpage
File "youtube_dl\YoutubeDL.pyo", line 1945, in urlopen
File "urllib2.pyo", line 431, in open
File "urllib2.pyo", line 449, in _open
File "urllib2.pyo", line 409, in _call_chain
File "youtube_dl\utils.pyo", line 932, in https_open
File "urllib2.pyo", line 1194, in do_open
File "httplib.pyo", line 1053, in request
File "httplib.pyo", line 1093, in _send_request
File "httplib.pyo", line 1049, in endheaders
File "httplib.pyo", line 893, in _send_output
File "httplib.pyo", line 855, in send
File "youtube_dl\utils.pyo", line 898, in connect
File "youtube_dl\socks.pyo", line 268, in connect
File "youtube_dl\socks.pyo", line 264, in _make_proxy
File "youtube_dl\socks.pyo", line 219, in _setup_socks5
File "youtube_dl\socks.pyo", line 212, in _socks5_auth
youtube_dl.socks.Socks5Error: [Errno 1] unknown error
```
---
### Description of your _issue_, suggested solution and other information
http proxy authentication works fine with this URI scheme, https has always failed, maybe it can be fixed also or made into another issue ticket.
Socks5 support seems to fail when trying to authenticate. I've included the verbose output. Also I suggest due to many usernames being email addresses taking the username/password parameters into their own command line switches. Otherwise users have to know that they need to encode their characters and be familiar with URI specification to use a username and password. Also decoding URIs can come with issues especially in experimental implementations.
This was done in a windows command prompt and I saved the parameters to a batch file so sometimes the % need additional escaping(%%40 for @ in a batch file, %40 from the command line). when composing the URIs
The suggestion is that the username and password be moved out to their own parameters, such as --proxy-user --proxy-pass
This way http,https,and socks5 proxies with passwords can be sure to work even with lots of @ signs, etc, and users don't have to guess which characters are allowed and are not, less likely to have to deal with shell + URI escaping rules(though if % is still used, that is another issue), and having to deal with both.
| request | low | Critical |
154,160,924 | youtube-dl | post-processing merge should preserve "encoded date" metadata | - [ x] I've **verified** and **I assure** that I'm running youtube-dl **2016.05.10**
- [x ] At least skimmed through [README](https://github.com/rg3/youtube-dl/blob/master/README.md) and **most notably** [FAQ](https://github.com/rg3/youtube-dl#faq) and [BUGS](https://github.com/rg3/youtube-dl#bugs) sections
- [ x] [Searched](https://github.com/rg3/youtube-dl/search?type=Issues) the bugtracker for similar issues including closed ones
### What is the purpose of your _issue_?
- [x ] Feature request (request for a new functionality)
When merging/muxing youtube video components into a single file, the "Encoded date" / "Tagged date" is set to the year 1904, even though the source video and audio have proper encoding dates.
Applying `--postprocessor-args "-map_metadata 0"` via ffmpeg will copy it over, but this should be a default behavior.
Proposed solution: include `-map_metadata 0` by default or use `-metadata creation_time="DATE"`, where `DATE` is ISO-8601
| request,postprocessors | low | Critical |
154,170,364 | opencv | cv::gpu::ORB_GPU::buildScalePyramids fails with small images | In OpenCV 2.4, in the `gpu::ORB_GPU` class, orb.cpp file, there is an issue that occurs with small images when using the defaults. [On line 535](https://github.com/Itseez/opencv/blob/2.4/modules/gpu/src/orb.cpp#L535)
```
Rect inner(edgeThreshold_, edgeThreshold_,
sz.width - 2 * edgeThreshold_, sz.height - 2 * edgeThreshold_);
```
Given the default values of 8 levels and a 1.2 scale factor, we get a scale of 0.232568039, which we multiple the input `image.rows` and `image.cols` by. However, with a default edge threshold of 31, if `sz.width` or `sz.height` is less than 62, we get a rectangle with a negative width or height, so the next line, `buf_(inner)` will throw an assert:
> OpenCV Error: Assertion failed (0 <= roi.x && 0 <= roi.width && roi.x + roi.width <= m.cols && 0 <= roi.y && 0 <= roi.height && roi.y + roi.height <= m.rows) in GpuMat
Calculating backwards, that means that the image must have both dimension greater than 266 pixels, or else the program will fail.
Note that the CPU version seems to address this problem in [lkpyramid.cpp, line 820](https://github.com/Itseez/opencv/blob/2.4/modules/video/src/lkpyramid.cpp#L820):
```
if( sz.width <= winSize.width || sz.height <= winSize.height )
```
I'm not sure what the best fix is for the GPU case, but for now I will address this by either:
```
scaleFactor = min(pow(min(image.rows, image.cols)/62.0, 1/8.0), 1.2);
```
or:
```
nLevels = min(int(ceil(log(min(image.rows, image.cols)/62.0)/log(1.2))), 8);
```
I'll see which gives the best results, but the `nLevels` follows the CPU code more closely.
| bug,affected: 2.4,category: gpu/cuda (contrib) | low | Critical |
154,176,028 | go | syscall: Windows Errno.Temporary and Errno.Timeout are incomplete | What version of Go are you using (`go version`)?
go version go1.6 windows/amd64
I read src/syscall/syscall_windows.go and find Errno.Temporary() just check EINTR, EMFILE and Errno.Timeout, but the src/syscall/syscall_unix.go, Errno.Temporary() additional check ECONNRESET and ECONNABORTED.
so why different between windows and linux?
Sorry my poor English.
| ExpertNeeded,help wanted,OS-Windows,NeedsInvestigation,early-in-cycle | low | Major |
154,181,138 | kubernetes | Make API field defaulting and validation less error-prone | There are frequent errors in API field specification, such as:
- default vs inferred (e.g., `fsType`: https://github.com/kubernetes/kubernetes/blob/master/pkg/api/v1/types.go#L557); note that implicitly inferred is discouraged
- default vs required
- required/optional vs omitempty
- omitempty vs. pointers
- documentation vs actual defaulting and validation code
For examples of multiple errors in one type, see:
https://github.com/kubernetes/kubernetes/issues/18885#issuecomment-218376807
One way to make defaulting and validation less error prone would to be allow them to be specified declaratively, on API fields using tags or comments. Protocol buffers allow literal default values to be specified (though, unlike in Kubernetes, they aren't conveyed on the wire; non-literals, such as fields defaulted from other fields, can't be specified this way). Declarative validation, where possible (i.e., simple rules), was previously requested by #8116.
Since omitempty and pointer rules are apparently non-obvious, I think we should require specification of required vs optional and then either verify that the other properties are consistent or autogenerate them.
Auto-fixing field names in documentation is covered by #19319.
cc @lavalamp @thockin @kubernetes/sig-api-machinery
| priority/backlog,sig/api-machinery,area/swagger,lifecycle/frozen | low | Critical |
154,241,351 | You-Dont-Know-JS | "async & performance" and "es6 & beyond": update "TCO" | A&P Ch6, E&B Ch7
Many things to update here, including:
- "TCO" is the wrong term, should have been PTC (proper tail calls)
- TCO is about optional optimizations on top of PTC
- potentially the STC changes post ES6
- tail calls isn't about reusing stack frames, but about throwing away the current one before making the next one
| for second edition | low | Major |
154,306,896 | go | x/crypto/ssh: No support for Window Dimension Change Message | Please answer these questions before submitting your issue. Thanks!
1. What version of Go are you using (`go version`)?
go version go1.6.1 darwin/amd64
2. What operating system and processor architecture are you using (`go env`)?
darwin/amd64
3. What did you do?
If possible, provide a recipe for reproducing the error.
A complete runnable program is good.
A link on play.golang.org is best.
Simply a part of the RFC 4254 document that was not implemented; would want a method on an ssh.Session object to send messages such as this.
1. What did you expect to see?
N/A
2. What did you see instead?
Not yet implemented.
| help wanted,NeedsFix,FeatureRequest | low | Critical |
154,324,187 | java-design-patterns | IODA architectural pattern | ## Description
The IODA (Input, Operations, Data, and Access) design pattern focuses on separating the concerns of input, operations, data, and access within a software system. This pattern promotes cleaner, more maintainable code by isolating different aspects of the system, thus making it easier to manage and scale.
### Main Elements of the Pattern:
1. **Input**: Handles all the input operations, including user interactions and data input from external sources.
2. **Operations**: Manages the business logic and core operations of the application.
3. **Data**: Responsible for the data management, including data structures and in-memory data handling.
4. **Access**: Handles the persistence layer, including database interactions and external service integrations.
### References:
- [Project Contribution Guidelines](https://github.com/iluwatar/java-design-patterns/wiki)
- [IODA Architecture Overview](https://geekswithblogs.net/gwbarchive/the-ioda-architecture/)
- [IODA Architecture by Example](http://geekswithblogs.net/theArchitectsNapkin/archive/2015/05/02/ioda-architecture-by-example.aspx)
- [IODA Architecture](http://www.infoq.com/news/2015/05/ioda-architecture)
## Acceptance Criteria
1. The implementation should include clearly defined classes or modules for Input, Operations, Data, and Access.
2. Each component should be independently testable, with unit tests covering the core functionalities of Input, Operations, Data, and Access.
3. Ensure adherence to the project's coding standards and contribution guidelines as outlined in the project's documentation.
| info: help wanted,epic: pattern,type: feature | low | Minor |
154,336,479 | TypeScript | ES6 modules cannot use "await" as an identifier | According to http://www.ecma-international.org/ecma-262/6.0/#sec-future-reserved-words
"await is only treated as a FutureReservedWord when Module is the goal symbol of the syntactic grammar."
This code should be illegal I think:
http://www.typescriptlang.org/play/#src=import%20'foo'%3B%0A%0Alet%20await%20%3D%203%3B
Came up when discussing TS semantics with @ajklein (v8 ES6 module expert).
| Bug,ES6 | low | Minor |
154,370,753 | vscode | Middle mouse button scrolling | - VSCode Version: 1.10
I searched the issues but did not find any such post, so apologies if there is an existing thread that I missed.
I'd like to know if there is any middle mouse click scrolling, planned? That is, clicking the scroll wheel to toggle drag scrolling. It's a useful feature to have when navigating very long files.
And if it isn't, is there any API that would allow this to be enabled via an extension?
Thanks
| feature-request,windows,editor-scrollbar | high | Critical |
154,552,246 | angular | Testing: wait for async tasks started in ng lifecycle hooks (ex. ngOnInit) | As of today `ComponentFixture::whenStable()` won't pick up async tasks started inside ng2 lifecycle hooks, ex.: `ngOnInit`. There are legitimate cases where async tasks are needed inside lifecycle hooks, ex.: using `ComponentResolver` in `ngOnInit`:
``` javascript
@Directive({
selector: 'template[ngb-alert]'
})
export class NgbAlertDismissible {
constructor(private _vcRef: ViewContainerRef, private _tplRef: TemplateRef<any>, private _cr: ComponentResolver, private _injector: Injector) {
}
ngOnInit() {
this._cr.resolveComponent(NgbAlert).then((cf: ComponentFactory<NgbAlert>) => {
var rootNodes = this._tplRef.createEmbeddedView({}).rootNodes;
this._vcRef.createComponent(cf, 0, this._injector, [rootNodes]);
});
}
}
```
At present the only way to write a test for the above component is to use `setTimout`, while the following should work just fine:
``` javascript
fixture.whenStable().then(() => {
fixture.detectChanges();
// do the assertions here...
});
```
| area: testing | low | Major |
154,574,016 | bitcoin | getchaintips doesn't mark headers-only chain as invalid | During headers-first downloading, if an invalid block is found, the client stops syncing that branch, but forever lists it as "headers-only". It seems to me it should be marked as "invalid". This is due to the subsequent headers not being marked "BLOCK_FAILED_CHILD".
| Validation | low | Critical |
154,761,933 | go | cmd/vet: check for concurrent use of T.FatalX and T.SkipX | The `testing` package is explicit about the following:
> A test ends when its Test function returns or calls any of the methods FailNow, Fatal, Fatalf, SkipNow, Skip, or Skipf. Those methods, as well as the Parallel method, must be called only from the goroutine running the Test function.
However, this is easy to overlook and it is not immediately obvious that the code below is a bad test:
``` go
func TestFoo(t *testing.T) {
go func() {
t.Fatal("fatal") // Called from outside the Test function
}()
time.Sleep(1 * time.Second)
}
```
This outputs (what a user expects):
```
--- FAIL: TestFoo (1.00s)
foo_test.go:10: fatal
```
Giving the user a false sense of having written correct test.
However, when running the test with the `-race` flag, it becomes obvious this is not okay:
```
==================
WARNING: DATA RACE
....
==================
--- FAIL: TestFoo (1.00s)
foo_test.go:10: fatal
```
Perhaps the `vet` tool can check for these cases.
| help wanted,Analysis | low | Minor |
154,796,967 | flutter | Don't redirect standard stream to syslog when running on a custom embedder | The Flutter tools read syslog output for `flutter logs`. To service this, the framework redirects standard stream output to syslog. When Flutter is embedded by third parties, this can cause the engine to redirect the stream anyway. This could be potentially confusing to the user.
| c: new feature,platform-ios,engine,P3,team-ios,triaged-ios | low | Minor |
154,798,830 | flutter | Need a way to preload asset images that are resolution aware | In my app, I'm getting flickering because `AssetImage()` tries to load an image, but it's not immediately available because it hasn't been loaded.
There needs to be a way to warm the cache in a resolution-aware manner.
| c: new feature,framework,d: api docs,a: assets,P2,team-framework,triaged-framework | low | Major |
154,799,974 | rust | method has an incompatible type for trait due to lifetimes has too wide a span | [For](https://play.rust-lang.org/?gist=4babb6ed0153e47f82c965a9feafbb28&version=nightly)
``` rust
trait A<'a> {
fn a<'b>(self) -> Box<A<'b>>;
}
struct C;
impl<'a> A<'a> for C {
fn a<'b>(self) -> Box<A<'a>>{}
}
```
it would be much more useful if we spanned the offending lifetime rather than the whole method: i.e. like this
```
error: method `a` has an incompatible type for trait:
expected bound lifetime parameter 'b,
found concrete lifetime [--explain E0053]
--> <anon>:8:5
8 |> fn a<'b>(self) -> Box<A<'a>>{}
|> ^^
```
instead of
```
error: method `a` has an incompatible type for trait:
expected bound lifetime parameter 'b,
found concrete lifetime [--explain E0053]
--> <anon>:8:5
8 |> fn a<'b>(self) -> Box<A<'a>>{}
|> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
```
| A-diagnostics,A-lifetimes,A-trait-system,T-compiler,D-confusing,D-terse | low | Critical |
154,822,636 | go | cmd/go: schedule cgo compilation early | From a quick scan of the code, it appears that cgo does not depend on a package's dependencies having been compiled. Given that that is the case, and given that cgo (and the resulting C compiler invocations) are generally very slow, it is probably worth scheduling all invocations of cmd/cgo at the very beginning of a build. (As a corollary, this might also mean scheduling the compilation of cmd/cgo itself early.)
cc @ianlancetaylor for input about whether cgo invocations can be safely pushed to the head of the queue.
One downside: It is unclear whether this is just a poor man's version of #8893, which didn't appear to yield much fruit. That could use more investigation.
| ToolSpeed,NeedsInvestigation | low | Major |
154,839,743 | TypeScript | Type Merging between extends and intersection | **TypeScript Version:**
1.8.10
**Code**
``` ts
interface Foo {
on(type: 'foo', listener: (event: MouseEvent) => boolean): boolean;
on(type: string, listener: (event: Event) => boolean): boolean;
}
interface Bar {
on(type: 'bar', listener: (event: MSGestureEvent) => boolean): boolean;
on(type: string, listener: (event: Event) => boolean): boolean;
}
interface FooBarA extends Foo, Bar {} // Error: not correctly extended
interface FooBarB extends Foo, Bar {
on(type: 'foo', listener: (event: MouseEvent) => boolean): boolean;
on(type: 'bar', listener: (event: MSGestureEvent) => boolean): boolean;
on(type: string, listener: (event: Event) => boolean): boolean;
}
type FooBarC = Foo & Bar;
let foobar: FooBarC;
foobar.on('foo', (event) => { return false; });
```
**Expected behavior:**
That `FooBarA` would work instead of throwing an error.
**Actual behavior:**
`FooBarA` complains `Interface 'FooBarA' cannot simultaneously extend types 'Foo' and 'Bar'. Named property 'on' of types 'Foo' and 'Bar' are not identical.`
While that is true in the strictest sense, the "base" override matches, which means in theory the string literal types could be merged and the error should only occur if there is a conflict between a specific string literal type.
Using the intersection type works perfectly fine and the resulting type mirrors the runtime behaviour. Using the "reimplement all methods" (`FooBarB`) gets really tedious really quickly when you are trying to do something like model event listeners like the above.
| Suggestion,Help Wanted,Effort: Moderate | low | Critical |
154,848,056 | youtube-dl | Site support request - Canal-u.tv | Canal-u.tv link not supported :
`youtube-dl -t https://www.canal-u.tv/video/ecole_normale_superieure_de_lyon/gouvernement.3118
[generic] gouvernement: Requesting header
WARNING: Falling back on generic information extractor.
[generic] gouvernement: Downloading webpage
[generic] gouvernement: Extracting information
[generic] gouvernement.3118: Downloading SMIL file
[download] Destination: Gouvernement - Ecole Normale Supérieure de Lyon - Vidéo - Canal-U-gouvernement.3118.flv
[rtmpdump] 0 bytes
ERROR: rtmpdump exited with code 1`
Thank you for considering my request.
| site-support-request | low | Critical |
154,888,026 | go | x/net: Add an eBPF package | Forked from #14982 - that issue was originally about adding both a BPF and an eBPF package to x/net.
After researching eBPF more, the virtual machine is _very_ different and more complex, so it makes sense to track the work for eBPF separately from the relatively simple BPF stuff.
Main documentation for eBPF is at https://www.kernel.org/doc/Documentation/networking/filter.txt , although it's described as a diff from "classic" BPF, which is really not a helpful way to specify a machine.
| NeedsDecision,FeatureRequest | low | Minor |
154,899,115 | youtube-dl | Subtitle tracks order | youtube-dl ignores --sub-lang languages order and embeds subtitles randomly(?).
Is there some way to embed them in the selected order?
```
D:\youtube-dl.exe --format best --format best --keep-video --sub-lang en,ru --embed-subs --write-sub --write-auto-sub --verbose --output %(title)s.%(ext)s --restrict-filenames "https://www.youtube.com/watch?v=vBpxhfBlVLU"
[debug] System config: []
[debug] User config: []
[debug] Command-line args: [u'--format', u'best', u'--format', u'best', u'--keep-video', u'--sub-lang', u'en,ru', u'--embed-subs', u'--write-sub', u'--write-auto-sub', u'--verbose', u'--output', u'%(title)s.%(ext)s', u'--restrict-filenames', u'https://www.youtube.com/watch?v=vBpxhfBlVLU']
[debug] Encodings: locale cp1251, fs mbcs, out cp866, pref cp1251
[debug] youtube-dl version 2016.05.10
[debug] Python version 2.7.10 - Windows-XP-5.1.2600-SP3
[debug] exe versions: ffmpeg 2.4.git
[debug] Proxy map: {}
[youtube] vBpxhfBlVLU: Downloading webpage
[youtube] vBpxhfBlVLU: Downloading video info webpage
[youtube] vBpxhfBlVLU: Extracting video information
[youtube] vBpxhfBlVLU: Looking for automatic captions
[youtube] vBpxhfBlVLU: Downloading MPD manifest
[info] Writing video subtitles to: Why_do_mirrors_flip_horizontally_but_not_vertically.ru.vtt
[info] Writing video subtitles to: Why_do_mirrors_flip_horizontally_but_not_vertically.en.vtt
[debug] Invoking downloader on u'https://r2---sn-8vap5-3c2s.googlevideo.com/videoplayback?ratebypass=yes&ipbits=0&mime=video%2Fmp4&sparams=dur%2Cid%2Cinitcwndbps%2Cip%2Cipbits%2Citag%2Clmt%2Cmime%2Cmm%2Cmn%2Cms%2Cmv%2Cpl%2Cratebypass%2Crequiressl%2Csource%2Cupn%2Cexpire&expire=1463325036&initcwndbps=2611250&mn=sn-8vap5-3c2s&mm=31&signature=ADCE8371EB7E32D0A131BC1A9B07A0494E6F905E.A13C54F346D41B39120D2B225AB1258BB8E7D897&fexp=9407191%2C9416126%2C9416891%2C9419452%2C9422342%2C9422596%2C9428398%2C9429743%2C9431012%2C9431418%2C9433096%2C9433946%2C9434078%2C9434344%2C9434922%2C9435850%2C9436090%2C9436322%2C9436446%2C9436481&key=yt6&ip=93.74.138.5&requiressl=yes&pl=17&source=youtube&sver=3&dur=227.044&mv=m&mt=1463302590&ms=au&id=o-AH40Dxpb2QCbBCG2x6b8XnI8bnoQG9y9qoCqnYySsSn7&lmt=1428126602563068&itag=22&upn=sFeBRwXcMRQ'
[download] Destination: Why_do_mirrors_flip_horizontally_but_not_vertically.mp4
[download] 100% of 51.10MiB in 00:05
[ffmpeg] Embedding subtitles in 'Why_do_mirrors_flip_horizontally_but_not_vertically.mp4'
[debug] ffmpeg command line: ffmpeg -y -i file:Why_do_mirrors_flip_horizontally_but_not_vertically.mp4 -i file:Why_do_mirrors_flip_horizontally_but_not_vertically.ru.vtt -i file:Why_do_mirrors_flip_horizontally_but_not_vertically.en.vtt -map 0 -c copy -map -0:s -c:s mov_text -map 1:0 -metadata:s:s:0 language=rus -map 2:0 -metadata:s:s:1 language=eng file:Why_do_mirrors_flip_horizontally_but_not_vertically.temp.mp4
```
| request,postprocessors | low | Critical |
154,905,705 | rust | Error E0301 "the parameter type `T` may not live long enough" could explain where the lifetime requirement comes from | Error E0301 "the parameter type `T` may not live long enough" could explain where the lifetime requirement comes from.
Here's some example code where the `T: 'static` requirement comes implicitly from a `Box<Trait>` trait object (so 'static is invisible).
[playground](https://play.rust-lang.org/?gist=829eb1711d4a426b8dfebbaadcf5e512&version=stable&backtrace=0)
``` rust
trait Funny { }
fn new_funny_handle<T: Funny + Default>() -> Box<Funny> {
Box::new(T::default())
}
```
``` rust
error: the parameter type `T` may not live long enough [--explain E0310]
--> <anon>:5:5
5 |> Box::new(T::default())
|> ^^^^^^^^^^^^^^^^^^^^^^
help: consider adding an explicit lifetime bound `T: 'static`...
note: ...so that the type `T` will meet its required lifetime bounds
--> <anon>:5:5
5 |> Box::new(T::default())
|>
```
| C-enhancement,A-diagnostics,T-compiler,D-confusing,D-papercut | low | Critical |
154,921,331 | neovim | Option to show showbreak character at end of the line that is wrapping | ### Consider this a feature request
- Neovim version: 0.1.5-dev
- Operating system/version: Ubuntu GNOME 15.10
- Terminal name/version: GNOME Terminal 3.16
- `$TERM`: xterm-256color
### Actual behaviour
The glyphs appear on the next line. I have to use `set cpo+=n` and `set showbreak=↪\ \ \` to keep the character from overlapping with the text. This works ok as long as I have files < 4 digit lines. Then I need to add another space in `showbreak` which breaks it in places where line number is only 3 digits.
### Expected behaviour
This is a configurable option in Visual Studio. It looks a little cleaner and doesn't make the user deal with the number of spaces in showbreak.
**NOTE:** The glyph doesn't have to be drawn in the last column (but it would be great if it could).
| enhancement | low | Major |
154,994,126 | TypeScript | Add a mechanism to copy another function/method's overload set | ## Problem
#### Outline
When I make a new sub-class from a parent-class who has multiple overloaded constructors (or some methods), I've to re-write the definition (header) of each function and re-write branch-condition again. It's very annoying and tiresome work for me.
#### With an example
https://github.com/samchon/stl/blob/master/ts/src/std/TreeMap.ts#L72-L177
``` typescript
class TreeMap<Key, T> extends base.UniqueMap<Key, T>
{
// THOSE DEFINITIONS ARE REPEATED IN EVERY SUB-CLASSES
constructor();
constructor(compare: (left: Key, right: Key) => boolean);
constructor(array: Array<Pair<Key, T>>);
constructor(array: Array<Pair<Key, T>>, compare: (left: Key, right: Key) => boolean);
constructor(array: Array<[Key, T]>);
constructor(array: Array<[Key, T]>, compare: (left: Key, right: Key) => boolean);
constructor(container: base.MapContainer<Key, T>);
constructor(container: base.MapContainer<Key, T>, compare: (left: Key, right: Key) => boolean);
constructor(begin: MapIterator<Key, T>, end: MapIterator<Key, T>);
constructor(begin: MapIterator<Key, T>, end: MapIterator<Key, T>, compare: (left: Key, right: Key) => boolean);
constructor(...args: any[])
{
// THOSE BRANCH CONDITIONS ARE ALSO REPEATED TOO
// condition statements identifying type of arguments
/*IF
ELSE IF
ELSE IF
...*/
}
}
```
In the link, you can see the _TreeMap_ class inherited from _base.UniqueMap_. Of course, you also can see that the constructors and branch-condition codes have to be re-written.
**Those idiot codes are repeated in every sub-classes in my fucking project.**
## Solution
#### Suggest: using statement
Those're very annoying and inefficient job for development. So I want to suggest a notation can reduce such in-efficient works.
In C++, fetching all overloaded methods from parent can be implemented by just a line.
With **using** statement. `using Parent::methodName;`
``` cpp
template <class T>
class URLVariables : public std::map<std::string, T>
{
private:
typedef std::map<std::string, T> super;
public:
// ALL THE CONSTRUCTORS + CUSTOM ONE
using super::map; // [using super::super] is also possible
/* -- THOSE CAN BE OMITTED BY USING STATEMENT --
URLVariables();
URLVariables(const super &);
URLVariables(super &&);
URLVariables(const std::initializer_list<std::pair<std::string, T>>> &);
template <InputIterator> URLVariables(InputIterator first, InputIterator last);
*/
URLVariables(const std::string &);
// ALL THE COUNT METHODS + CUSTOM ONE
using super::count;
bool count(const std::string_view &) const;
bool count(const ByteArray &) const;
}
```
If the **using statement** is adopted in _TypeScript_, codes will be much precise like below. Isn't it much precise than codes of the top?
``` typescript
class TreeMap<Key, T> extends base.UniqueMap<Key, T>
{
// THE USING STATEMENT
using super.constructor;
// THOSE RE-DEFINITIONS ARE OMITTED BY THE USING STATEMENT
/*constructor();
constructor(compare: (left: Key, right: Key) => boolean);
constructor(array: Array<Pair<Key, T>>);
constructor(array: Array<Pair<Key, T>>, compare: (left: Key, right: Key) => boolean);
constructor(array: Array<[Key, T]>);
constructor(array: Array<[Key, T]>, compare: (left: Key, right: Key) => boolean);
constructor(container: base.MapContainer<Key, T>);
constructor(container: base.MapContainer<Key, T>, compare: (left: Key, right: Key) => boolean);
constructor(begin: MapIterator<Key, T>, end: MapIterator<Key, T>);
constructor(begin: MapIterator<Key, T>, end: MapIterator<Key, T>, compare: (left: Key, right: Key) => boolean);*/
constructor(...args: any[])
{
// CALLING SUPER CONSTRUCTORS' RE DONE BY
super(...args);
}
}
```
I'm waiting for your opinion and eagerly looking forward to the enhancement.
| Suggestion,Awaiting More Feedback | low | Minor |
155,018,203 | You-Dont-Know-JS | "ES6 & Beyond", ch3, section "Modules -> Moving forward" - unclear sentence | First of all, huge respect for the books, they are amazing!
In the **Moving Forward** subsection, there is a sentence that seems somewhat unclear (uses being accustomed to something):
> Some **uses are accustomed to being able to provide** dynamic API definitions, where methods can be added/removed/replaced in response to runtime conditions. Either these **uses will have to change** to fit with ES6 static APIs, or they will have to restrain the dynamic changes to properties/methods of a second-level object.
Maybe there should be **users** instead of **uses**?
| for second edition | medium | Minor |
155,056,265 | TypeScript | Bug: Accessing private statics in a class via its derived class is allowed | **TypeScript Version:**
1.8.X
**Code**
``` ts
class FooBase {
private static privateStatic: string = "";
testBase(): void {
console.log(FooBase.privateStatic);
// Should error, but doesn't
console.log(Foo.privateStatic);
}
}
class Foo extends FooBase {
test() {
// Should error, and does
console.log(Foo.privateStatic);
}
}
```
**Expected behavior:**
Accessing `Foo.privateStatic` shouldn't be allowed, regardless of the context it's called in.
**Actual behavior:**
`FooBase` is allowed to do this.
_(thanks @sethbrenith for deducing this)_
| Suggestion,Breaking Change,Help Wanted,Effort: Moderate | medium | Critical |
155,142,838 | go | spec: clarify method sets and recursive promotions | My reading of the Go spec is that this is valid:
```
package p
type S1 struct { *S2 }
type S2 struct { *S1 }
func (*S1) M() {}
var _ = S1.M
```
Rationale:
1. Because of `func (*S1) M() {}`, `M` is a member of `*S1`'s method set.
2. Because of the `*S1` embedding into `S2`, `M` is also a member of `S2` and `*S2`'s method sets.
3. Because of the `*S2` embedding into `S1`, `M` should also be a member of `S1`'s method set.
However, cmd/compile, gccgo, and gotype all reject it.
/cc @griesemer @ianlancetaylor
| Documentation,NeedsFix | low | Major |
155,155,021 | go | cmd/compile: poor error message when invoking method on embedded type | Please answer these questions before submitting your issue. Thanks!
1. What version of Go are you using (`go version`)?
go1.6.2
1. What operating system and processor architecture are you using (`go env`)?
The playground
1. What did you do?
https://play.golang.org/p/hsjwmQwtsb
Relevant snippet:
``` go
func TestFoo(t *testing.T) {
t.Fail("what?")
}
```
1. What did you expect to see?
```
prog.go:14: too many arguments in call to t.Fail
```
1. What did you see instead?
```
prog.go:14: too many arguments in call to t.common.Fail
```
The `.common` bit is unexpected and an implementation detail. Running `godoc testing Fail` shows a simple method `func (c *T) Fail()`, and the fact that `testing.T` embeds `testing.common` does not seem useful.
| NeedsFix,compiler/runtime | low | Critical |
155,178,668 | kubernetes | Umbrella issue for various swagger related improvements | Summarizing all our swagger related issues here:
Improving the spec:
- [ ] Represent Enum types: right now, we represent them as strings and put the possible values in comments. Want to represent them as enum types and use the list of valid values for validation: https://github.com/kubernetes/kubernetes/issues/24562
- [x] Represent strategic merge patch policy in swagger: https://github.com/kubernetes/kubernetes/issues/24560 (need to figure out how to represent it)
- [x] Fix the return type for /versions: https://github.com/kubernetes/kubernetes/issues/17176 (super simple one line change)
- [x] *versioned.Event model should not be a pointer: https://github.com/kubernetes/kubernetes/issues/24240 (looks like a bug in go-restful)
- [x] Get swagger spec validation to pass: https://github.com/kubernetes/kubernetes/issues/16748 (requires change to swagger-tools most probably)
- [x] Figure out a way to represent IntOrString: We represent them as string right now which fails when we return int: https://github.com/kubernetes/kubernetes/issues/14190
- [x] Fix responseModel for pods/log: https://github.com/kubernetes/kubernetes/issues/14071
- [ ] Document all possible status codes and returned object types: https://github.com/kubernetes/kubernetes/issues/6167
- [x] Represent maps as maps (right now we represent them as `"type": "object"` which is the generic type we use for all our custom types): https://github.com/kubernetes/kubernetes/issues/4700 (requires moving to 2.0)
- [x] Represent unversioned.Time correctly in swagger spec: https://github.com/kubernetes/kubernetes/issues/2968 (should be a simple change)
- [x] intOrString #2971
- [ ] deletion response is incorrect #30537
Making it easy to use:
- [x] Serve it as JSON at kubernetes.io: https://github.com/kubernetes/kubernetes/issues/15571
- [x] Validate on each commit to ensure valid spec at HEAD: https://github.com/kubernetes/kubernetes/issues/5356
Doing things on top of spec:
- [ ] Generate client libraries in multiple languages: We can use client-gen swagger tool to use the swagger to spec to auto generate client libraries in multiple languages: https://github.com/kubernetes/kubernetes/issues/22405
Advanced:
- [x] Move to swagger spec 2.0: https://github.com/kubernetes/kubernetes/issues/13414 (we are using go-restful to generate swagger spec 1.2 right now).
- [ ] Move all internal components to use OpenAPI (swagger spec 2.0): https://github.com/kubernetes/kubernetes/issues/38637
| priority/backlog,sig/api-machinery,area/swagger,lifecycle/frozen | medium | Critical |
155,228,734 | You-Dont-Know-JS | "ES6 & Beyond", ch4, section "Review" - possible typo | > Right now, we can manage these interactions with the aid**e** of various async libraries’ runners, but JavaScript is eventually going to support this interaction pattern with dedicated syntax alone!
As I just learned, [aide](http://dictionary.cambridge.org/dictionary/english/aide) is a valid English word, but it seems to refer to a person, which would make it incompatible with "with the aide of runners" construct.
If you confirm a typo, I would gladly fix it and create a pull request.
| for second edition | low | Minor |
155,334,607 | kubernetes | Store logs from hooks and probes in separate log files | As of now kubelet inlines log files from probes. #25681 inlines logs from hooks.
Inlining such logs makes it difficult to identify them and also pollutes kubelet logs.
Ideally, these logs should be either inlined into container logs. That is not possible today with the default docker logging driver.
An alternative is to store hooks and prober logs into separate container logs that the kubelet can manage.
| priority/backlog,sig/node,kind/feature,lifecycle/frozen,needs-triage | medium | Critical |
155,447,578 | opencv | [Bug] Different description result for a keypoint with ORB and cuda::ORB | ### Please state the information for your system
- OpenCV version: 3.1
- Host OS: Linux (Ubuntu 16.04)
### In which part of the OpenCV library you got the issue?
Examples:
- features2d(ORB) and cudafeatures2d(cuda::ORB)
- different description results for same key-points
### Problem description
Find key-points and describe using cv::cuda::ORB::detecetAndCompute() with useProvidedKeypoints = false (to be able to detect key-points)
Describe key-points that we just detect using cv::ORB::detectAndCompute with useProvidedKeypoints = true which will use given key-points to describe.
Compare two description and expect them to be exactly the same.
### Expected behavior
Expecting exactly identical description result for a key-point on same image using both cv::ORB and cv::cudaORB.
### Actual behavior
Different description results for same key-points between cv::ORB and cv::cuda::ORB
### Code example to reproduce the issue / Steps to reproduce the issue
Please try to give a full example which will compile as is.
```
#include <opencv2/core/cuda.hpp>
#include <opencv2/core.hpp>
#include <opencv2/cudafeatures2d.hpp>
#include <opencv2/imgcodecs.hpp>
#include <opencv2/imgcodecs/imgcodecs_c.h>
#include <iostream>
using namespace cv;
using namespace std;
int main() {
cv::Mat img_cpu = cv::imread("lena.png", CV_LOAD_IMAGE_GRAYSCALE);
cv::cuda::GpuMat img_gpu(img_cpu);
cv::cuda::GpuMat desc_gpu;
cv::Mat desc_cpu;
vector<KeyPoint> keypoints;
cv::Ptr<cv::ORB> orb_cpu = cv::ORB::create(15);
cv::Ptr<cv::cuda::ORB> orb_gpu = cv::cuda::ORB::create(15);
orb_gpu->detectAndCompute(img_gpu, noArray(),keypoints,desc_gpu, false);
orb_cpu->detectAndCompute(img_cpu,noArray(),keypoints,desc_cpu,true);
cv::Mat donwloaded_desc_gpu(desc_gpu);
cout <<"Description result for GPU" << endl << donwloaded_desc_gpu << endl << "Description result for CPU" << endl << desc_cpu << endl;
return 0;
}
```
I run this code like this:
> g++ -c issue.cpp
> g++ -L/usr/local/lib -o "issue" ./issue.o -lopencv_core -lopencv_cudafeatures2d -lopencv_features2d -lopencv_imgproc -lopencv_imgcodecs
> ./issue
| category: gpu/cuda (contrib),RFC | low | Critical |
155,608,545 | kubernetes | Audit all APIs for selector fields, ensure documented semantics when nil or empty. | Service.spec.selector comments say "If empty, all pods are selected, if not specified, endpoints must be manually specified".
As far as I can tell this is not implemented, though. While Go understands the different between a nil slice and a non-nil slice with no elements, JSON does not. With an `omitempty` field, we get the field dropped in either case.
To actually achieve this semantic, we need the type to be a pointer, so omitempty applies to a nil pointer but not an empty map. But at least protobuf codegen does not support this, either. I think the right fix is to change the documentation.
@bgrant0607 @smarterclayton
| priority/backlog,help wanted,sig/architecture,lifecycle/frozen | low | Major |
155,609,975 | go | net: add mechanism to wait for readability on a TCPConn | **EDIT**: this proposal has shifted. See https://github.com/golang/go/issues/15735#issuecomment-266574151 below.
Old:
The net/http package needs a way to wait for readability on a TCPConn without actually reading from it. (See #15224)
http://golang.org/cl/22031 added such a mechanism, making Read(0 bytes) do a wait for readability, followed by returning (0, nil). But maybe that is strange. Windows already works like that, though. (See new tests in that CL)
Reconsider this for Go 1.8.
Maybe we could add a new method to TCPConn instead, like WaitRead.
| NeedsInvestigation | high | Critical |
155,761,681 | youtube-dl | Display instantaneous download speed instead of average speed | - [x] I've **verified** and **I assure** that I'm running youtube-dl **2016.05.16**
- [x] At least skimmed through [README](https://github.com/rg3/youtube-dl/blob/master/README.md) and **most notably** [FAQ](https://github.com/rg3/youtube-dl#faq) and [BUGS](https://github.com/rg3/youtube-dl#bugs) sections
- [x] [Searched](https://github.com/rg3/youtube-dl/search?type=Issues) the bugtracker for similar issues including closed ones
### What is the purpose of your _issue_?
- [ ] Bug report (encountered problems with youtube-dl)
- [ ] Site support request (request for adding support for a new site)
- [x] Feature request (request for a new functionality)
- [ ] Question
- [ ] Other
---
I have an incredibly unstable internet connection. My download speed will often fluctuate from being in the low kbps decades to the 5-10 mbps range. From what I've been able to see from my cursory search of the codebase, youtube-dl calculates speed as an average over the whole download process:
from https://github.com/rg3/youtube-dl/blob/f9b1529af8aec98bffd42edb5be15e1ada791a20/youtube_dl/downloader/common.py
```
@staticmethod
def calc_speed(start, now, bytes):
dif = now - start
if bytes == 0 or dif < 0.001: # One millisecond
return None
return float(bytes) / dif
```
Perhaps you should add a method to return the speed over the past few seconds rather than the whole download, so that wierd internet slowdowns don't show me wildly different average speed than the current speed.
| request | low | Critical |
155,795,399 | go | cmd/go: only rebuild dependent packages when export data has changed | @mwhudson suggested in #15734:
> If the export data hasn't changed, can you skip the compilation of dependent packages?
Moving this idea here to be tracked separately.
My 2c: Interesting idea, seems worth pursuing. Not sure how often it happens that code changes don't impact export data (or how cheap that is to detect), but when it does happen, that could save a _bunch_ of computation.
| ToolSpeed,NeedsFix,GoCommand | low | Major |
155,840,497 | go | testing: complain loudly during concurrent use of T.FatalX and T.SkipX | The `testing` package is explicit about the following:
> A test ends when its Test function returns or calls any of the methods FailNow, Fatal, Fatalf, SkipNow, Skip, or Skipf. Those methods, as well as the Parallel method, must be called only from the goroutine running the Test function.
However, this is easy to overlook and it is not immediately obvious that the code below is a bad test:
``` go
func TestFoo(t *testing.T) {
go func() {
t.Fatal("fatal") // Called from outside the Test function
}()
time.Sleep(1 * time.Second)
}
```
This currently outputs (what a user expects):
```
--- FAIL: TestFoo (1.00s)
foo_test.go:10: fatal
```
However, since t.Fatal is not safe to call outside of the Test function, this is poor feedback since it makes the user think that the test is correctly written when it is actually racy. Instead it should complain loudly that this is wrong.
As I'm debugging poor tests, I've noticed that the calling of t.Fatal in a goroutine is actually a fairly common phenomenon.
Related: #15674
/cc @mpvl @bradfitz
| help wanted,NeedsFix | medium | Critical |
155,844,727 | go | image: optimize Image.At().RGBA() | In the Go standard library (and x/image), we can see several calls that look like `Image.At().RGBA()`.
These calls mostly happen in y/x loops.
They are slow because they allocate memory.
I have written a library that speeds up `Image.At().RGBA()`.
It is available on https://github.com/pierrre/imageutil
If you call https://godoc.org/github.com/pierrre/imageutil#NewAtFunc with an image, it returns a https://godoc.org/github.com/pierrre/imageutil#AtFunc
A `AtFunc` returns the RGBA value (uint32) for a given pixel (x/y).
A call to `NewAtFunc()` allocates memory, but it only happens 1 time per image.
A call to a `AtFunc` doesn't allocate memory (most of the time).
There is also `NewSetFunc()` that helps to set RGBA values to an image.
It works the same way.
My code is just a copy/paste of the Go standard library, but organized differently.
Benchmarks!
I've written benchmarks for "encode" functions.
It only tests blank images, but it will give you an idea.
``` go
package benchimageencode
import (
"bytes"
"image"
"image/color"
"image/gif"
"image/jpeg"
"image/png"
"io"
"strconv"
"testing"
"golang.org/x/image/bmp"
"golang.org/x/image/tiff"
)
func Benchmark(b *testing.B) {
buf := new(bytes.Buffer)
for _, tcEnc := range []struct {
name string
enc func(w io.Writer, im image.Image) error
}{
{
"JPEG",
func(w io.Writer, im image.Image) error {
return jpeg.Encode(w, im, nil)
},
},
{"PNG", png.Encode},
{
"GIF",
func(w io.Writer, im image.Image) error {
return gif.Encode(w, im, nil)
},
},
{"BMP", bmp.Encode},
{
"TIFF",
func(w io.Writer, im image.Image) error {
return tiff.Encode(w, im, nil)
},
},
} {
b.Run(tcEnc.name, func(b *testing.B) {
for _, tcIm := range []struct {
name string
newImage func(image.Rectangle) image.Image
}{
{
"RGBA",
func(r image.Rectangle) image.Image {
return image.NewRGBA(r)
},
},
{
"RGBA64",
func(r image.Rectangle) image.Image {
return image.NewRGBA64(r)
},
},
{
"NRGBA",
func(r image.Rectangle) image.Image {
return image.NewNRGBA(r)
},
},
{
"NRGBA64",
func(r image.Rectangle) image.Image {
return image.NewNRGBA64(r)
},
},
{
"Alpha",
func(r image.Rectangle) image.Image {
return image.NewAlpha(r)
},
},
{
"Alpha16",
func(r image.Rectangle) image.Image {
return image.NewAlpha16(r)
},
},
{
"Gray",
func(r image.Rectangle) image.Image {
return image.NewGray(r)
},
},
{
"Gray16",
func(r image.Rectangle) image.Image {
return image.NewGray16(r)
},
},
{
"Paletted",
func(r image.Rectangle) image.Image {
return image.NewPaletted(r, color.Palette{
color.RGBA{R: 0x00, G: 0x00, B: 0x00, A: 0xFF},
color.RGBA{R: 0xFF, G: 0x00, B: 0x00, A: 0xFF},
color.RGBA{R: 0x00, G: 0xFF, B: 0x00, A: 0xFF},
color.RGBA{R: 0x00, G: 0x00, B: 0xFF, A: 0xFF},
})
},
},
{
"YCbCr",
func(r image.Rectangle) image.Image {
return image.NewYCbCr(r, image.YCbCrSubsampleRatio444)
},
},
{
"NYCbCrA",
func(r image.Rectangle) image.Image {
return image.NewNYCbCrA(r, image.YCbCrSubsampleRatio444)
},
},
{
"CMYK",
func(r image.Rectangle) image.Image {
return image.NewCMYK(r)
},
},
} {
b.Run(tcIm.name, func(b *testing.B) {
for _, size := range []int{
10, 100, 1000,
} {
im := tcIm.newImage(image.Rect(0, 0, size, size))
b.Run(strconv.Itoa(size), func(b *testing.B) {
for i := 0; i < b.N; i++ {
buf.Reset()
err := tcEnc.enc(buf, im)
if err != nil {
b.Fatal(err)
}
}
})
}
})
}
})
}
}
```
Results:
```
benchmark old ns/op new ns/op delta
Benchmark/JPEG/RGBA/10-8 6891 6922 +0.45%
Benchmark/JPEG/RGBA/100-8 243797 226064 -7.27%
Benchmark/JPEG/RGBA/1000-8 18211697 18183751 -0.15%
Benchmark/JPEG/RGBA64/10-8 15505 8078 -47.90%
Benchmark/JPEG/RGBA64/100-8 654661 284739 -56.51%
Benchmark/JPEG/RGBA64/1000-8 51987889 22906425 -55.94%
Benchmark/JPEG/NRGBA/10-8 15891 7327 -53.89%
Benchmark/JPEG/NRGBA/100-8 646659 257388 -60.20%
Benchmark/JPEG/NRGBA/1000-8 53610219 20396700 -61.95%
Benchmark/JPEG/NRGBA64/10-8 16586 7310 -55.93%
Benchmark/JPEG/NRGBA64/100-8 718770 256065 -64.37%
Benchmark/JPEG/NRGBA64/1000-8 55099237 20160389 -63.41%
Benchmark/JPEG/Alpha/10-8 13366 7624 -42.96%
Benchmark/JPEG/Alpha/100-8 535532 274982 -48.65%
Benchmark/JPEG/Alpha/1000-8 43495216 21314882 -50.99%
Benchmark/JPEG/Alpha16/10-8 14041 7849 -44.10%
Benchmark/JPEG/Alpha16/100-8 567633 271382 -52.19%
Benchmark/JPEG/Alpha16/1000-8 46175342 21845906 -52.69%
Benchmark/JPEG/Gray/10-8 4124 4114 -0.24%
Benchmark/JPEG/Gray/100-8 80502 81061 +0.69%
Benchmark/JPEG/Gray/1000-8 7237756 7227977 -0.14%
Benchmark/JPEG/Gray16/10-8 13816 7688 -44.35%
Benchmark/JPEG/Gray16/100-8 565986 273270 -51.72%
Benchmark/JPEG/Gray16/1000-8 46435379 21609969 -53.46%
Benchmark/JPEG/Paletted/10-8 9504 7861 -17.29%
Benchmark/JPEG/Paletted/100-8 339095 277612 -18.13%
Benchmark/JPEG/Paletted/1000-8 27374214 22215206 -18.85%
Benchmark/JPEG/YCbCr/10-8 16747 8353 -50.12%
Benchmark/JPEG/YCbCr/100-8 693129 293951 -57.59%
Benchmark/JPEG/YCbCr/1000-8 56055246 23340037 -58.36%
Benchmark/JPEG/NYCbCrA/10-8 17758 9100 -48.76%
Benchmark/JPEG/NYCbCrA/100-8 753606 331801 -55.97%
Benchmark/JPEG/NYCbCrA/1000-8 61176716 27043470 -55.79%
Benchmark/JPEG/CMYK/10-8 16301 8968 -44.98%
Benchmark/JPEG/CMYK/100-8 664311 332938 -49.88%
Benchmark/JPEG/CMYK/1000-8 53249646 26513162 -50.21%
Benchmark/PNG/RGBA/10-8 233825 234277 +0.19%
Benchmark/PNG/RGBA/100-8 1318376 1244438 -5.61%
Benchmark/PNG/RGBA/1000-8 87804961 87500804 -0.35%
Benchmark/PNG/RGBA64/10-8 234305 241012 +2.86%
Benchmark/PNG/RGBA64/100-8 1560487 1571785 +0.72%
Benchmark/PNG/RGBA64/1000-8 116953559 115641713 -1.12%
Benchmark/PNG/NRGBA/10-8 224863 215643 -4.10%
Benchmark/PNG/NRGBA/100-8 543683 477847 -12.11%
Benchmark/PNG/NRGBA/1000-8 22236178 22087216 -0.67%
Benchmark/PNG/NRGBA64/10-8 278971 229319 -17.80%
Benchmark/PNG/NRGBA64/100-8 1338571 1344189 +0.42%
Benchmark/PNG/NRGBA64/1000-8 94600702 92419064 -2.31%
Benchmark/PNG/Alpha/10-8 226913 235867 +3.95%
Benchmark/PNG/Alpha/100-8 1237592 1212220 -2.05%
Benchmark/PNG/Alpha/1000-8 87412677 86772330 -0.73%
Benchmark/PNG/Alpha16/10-8 238503 230353 -3.42%
Benchmark/PNG/Alpha16/100-8 1534150 1577323 +2.81%
Benchmark/PNG/Alpha16/1000-8 114207844 113559204 -0.57%
Benchmark/PNG/Gray/10-8 240275 224893 -6.40%
Benchmark/PNG/Gray/100-8 349896 319882 -8.58%
Benchmark/PNG/Gray/1000-8 5872431 5918043 +0.78%
Benchmark/PNG/Gray16/10-8 232315 219746 -5.41%
Benchmark/PNG/Gray16/100-8 856544 922971 +7.76%
Benchmark/PNG/Gray16/1000-8 51153358 50292261 -1.68%
Benchmark/PNG/Paletted/10-8 222739 229109 +2.86%
Benchmark/PNG/Paletted/100-8 320867 322279 +0.44%
Benchmark/PNG/Paletted/1000-8 5880143 5995715 +1.97%
Benchmark/PNG/YCbCr/10-8 264396 229815 -13.08%
Benchmark/PNG/YCbCr/100-8 1119731 944250 -15.67%
Benchmark/PNG/YCbCr/1000-8 72874727 42894471 -41.14%
Benchmark/PNG/NYCbCrA/10-8 254977 239658 -6.01%
Benchmark/PNG/NYCbCrA/100-8 1646790 1662818 +0.97%
Benchmark/PNG/NYCbCrA/1000-8 126894096 125769798 -0.89%
Benchmark/PNG/CMYK/10-8 288477 227636 -21.09%
Benchmark/PNG/CMYK/100-8 1050239 883844 -15.84%
Benchmark/PNG/CMYK/1000-8 68309463 42997860 -37.05%
Benchmark/BMP/RGBA/10-8 2357 2337 -0.85%
Benchmark/BMP/RGBA/100-8 19857 19835 -0.11%
Benchmark/BMP/RGBA/1000-8 1699880 1658537 -2.43%
Benchmark/BMP/RGBA64/10-8 5892 2893 -50.90%
Benchmark/BMP/RGBA64/100-8 370764 72362 -80.48%
Benchmark/BMP/RGBA64/1000-8 37558621 6772522 -81.97%
Benchmark/BMP/NRGBA/10-8 5587 2754 -50.71%
Benchmark/BMP/NRGBA/100-8 330937 57430 -82.65%
Benchmark/BMP/NRGBA/1000-8 32697775 5413184 -83.44%
Benchmark/BMP/NRGBA64/10-8 6067 2779 -54.19%
Benchmark/BMP/NRGBA64/100-8 379282 59023 -84.44%
Benchmark/BMP/NRGBA64/1000-8 36784396 5547886 -84.92%
Benchmark/BMP/Alpha/10-8 4947 2691 -45.60%
Benchmark/BMP/Alpha/100-8 268719 54878 -79.58%
Benchmark/BMP/Alpha/1000-8 26591321 5049983 -81.01%
Benchmark/BMP/Alpha16/10-8 5236 2747 -47.54%
Benchmark/BMP/Alpha16/100-8 290536 57670 -80.15%
Benchmark/BMP/Alpha16/1000-8 28806912 5421961 -81.18%
Benchmark/BMP/Gray/10-8 3576 3575 -0.03%
Benchmark/BMP/Gray/100-8 4829 4768 -1.26%
Benchmark/BMP/Gray/1000-8 58899 57669 -2.09%
Benchmark/BMP/Gray16/10-8 5166 2781 -46.17%
Benchmark/BMP/Gray16/100-8 287760 57665 -79.96%
Benchmark/BMP/Gray16/1000-8 28462012 5463188 -80.81%
Benchmark/BMP/Paletted/10-8 3210 3358 +4.61%
Benchmark/BMP/Paletted/100-8 4386 4546 +3.65%
Benchmark/BMP/Paletted/1000-8 58090 58225 +0.23%
Benchmark/BMP/YCbCr/10-8 6046 2999 -50.40%
Benchmark/BMP/YCbCr/100-8 387509 79009 -79.61%
Benchmark/BMP/YCbCr/1000-8 38474751 7584745 -80.29%
Benchmark/BMP/NYCbCrA/10-8 6739 3387 -49.74%
Benchmark/BMP/NYCbCrA/100-8 462438 116874 -74.73%
Benchmark/BMP/NYCbCrA/1000-8 45898191 11495621 -74.95%
Benchmark/BMP/CMYK/10-8 5594 3105 -44.49%
Benchmark/BMP/CMYK/100-8 339544 90794 -73.26%
Benchmark/BMP/CMYK/1000-8 33004703 8738049 -73.52%
Benchmark/TIFF/RGBA/10-8 2312 2509 +8.52%
Benchmark/TIFF/RGBA/100-8 4122 3509 -14.87%
Benchmark/TIFF/RGBA/1000-8 295062 288624 -2.18%
Benchmark/TIFF/RGBA64/10-8 2698 2657 -1.52%
Benchmark/TIFF/RGBA64/100-8 63975 65120 +1.79%
Benchmark/TIFF/RGBA64/1000-8 6303790 6177960 -2.00%
Benchmark/TIFF/NRGBA/10-8 1867 1850 -0.91%
Benchmark/TIFF/NRGBA/100-8 2997 3031 +1.13%
Benchmark/TIFF/NRGBA/1000-8 293275 297403 +1.41%
Benchmark/TIFF/NRGBA64/10-8 2641 2737 +3.63%
Benchmark/TIFF/NRGBA64/100-8 64303 64035 -0.42%
Benchmark/TIFF/NRGBA64/1000-8 6227868 6260150 +0.52%
Benchmark/TIFF/Alpha/10-8 4791 2631 -45.08%
Benchmark/TIFF/Alpha/100-8 270968 60194 -77.79%
Benchmark/TIFF/Alpha/1000-8 26615543 5647306 -78.78%
Benchmark/TIFF/Alpha16/10-8 5037 2701 -46.38%
Benchmark/TIFF/Alpha16/100-8 293523 68395 -76.70%
Benchmark/TIFF/Alpha16/1000-8 29014088 6497133 -77.61%
Benchmark/TIFF/Gray/10-8 1481 1431 -3.38%
Benchmark/TIFF/Gray/100-8 1652 1657 +0.30%
Benchmark/TIFF/Gray/1000-8 36243 38499 +6.22%
Benchmark/TIFF/Gray16/10-8 1728 1826 +5.67%
Benchmark/TIFF/Gray16/100-8 19916 20041 +0.63%
Benchmark/TIFF/Gray16/1000-8 1682497 1682254 -0.01%
Benchmark/TIFF/Paletted/10-8 4276 4374 +2.29%
Benchmark/TIFF/Paletted/100-8 4759 4690 -1.45%
Benchmark/TIFF/Paletted/1000-8 39673 39281 -0.99%
Benchmark/TIFF/YCbCr/10-8 5862 2863 -51.16%
Benchmark/TIFF/YCbCr/100-8 383112 90709 -76.32%
Benchmark/TIFF/YCbCr/1000-8 37969567 8576337 -77.41%
Benchmark/TIFF/NYCbCrA/10-8 6511 3511 -46.08%
Benchmark/TIFF/NYCbCrA/100-8 454029 125287 -72.41%
Benchmark/TIFF/NYCbCrA/1000-8 45109329 11977360 -73.45%
Benchmark/TIFF/CMYK/10-8 5431 3017 -44.45%
Benchmark/TIFF/CMYK/100-8 331066 96960 -70.71%
Benchmark/TIFF/CMYK/1000-8 33648362 9402967 -72.06%
benchmark old allocs new allocs delta
Benchmark/JPEG/RGBA/10-8 4 5 +25.00%
Benchmark/JPEG/RGBA/100-8 4 5 +25.00%
Benchmark/JPEG/RGBA/1000-8 4 5 +25.00%
Benchmark/JPEG/RGBA64/10-8 260 5 -98.08%
Benchmark/JPEG/RGBA64/100-8 12548 5 -99.96%
Benchmark/JPEG/RGBA64/1000-8 1016068 5 -100.00%
Benchmark/JPEG/NRGBA/10-8 260 5 -98.08%
Benchmark/JPEG/NRGBA/100-8 12548 5 -99.96%
Benchmark/JPEG/NRGBA/1000-8 1016068 5 -100.00%
Benchmark/JPEG/NRGBA64/10-8 260 5 -98.08%
Benchmark/JPEG/NRGBA64/100-8 12548 5 -99.96%
Benchmark/JPEG/NRGBA64/1000-8 1016068 5 -100.00%
Benchmark/JPEG/Alpha/10-8 260 5 -98.08%
Benchmark/JPEG/Alpha/100-8 12548 5 -99.96%
Benchmark/JPEG/Alpha/1000-8 1016068 5 -100.00%
Benchmark/JPEG/Alpha16/10-8 260 5 -98.08%
Benchmark/JPEG/Alpha16/100-8 12548 5 -99.96%
Benchmark/JPEG/Alpha16/1000-8 1016068 5 -100.00%
Benchmark/JPEG/Gray/10-8 4 4 +0.00%
Benchmark/JPEG/Gray/100-8 4 4 +0.00%
Benchmark/JPEG/Gray/1000-8 4 4 +0.00%
Benchmark/JPEG/Gray16/10-8 260 5 -98.08%
Benchmark/JPEG/Gray16/100-8 12548 5 -99.96%
Benchmark/JPEG/Gray16/1000-8 1016068 5 -100.00%
Benchmark/JPEG/Paletted/10-8 4 6 +50.00%
Benchmark/JPEG/Paletted/100-8 4 6 +50.00%
Benchmark/JPEG/Paletted/1000-8 4 6 +50.00%
Benchmark/JPEG/YCbCr/10-8 260 5 -98.08%
Benchmark/JPEG/YCbCr/100-8 12548 5 -99.96%
Benchmark/JPEG/YCbCr/1000-8 1016068 5 -100.00%
Benchmark/JPEG/NYCbCrA/10-8 260 5 -98.08%
Benchmark/JPEG/NYCbCrA/100-8 12548 5 -99.96%
Benchmark/JPEG/NYCbCrA/1000-8 1016068 5 -100.00%
Benchmark/JPEG/CMYK/10-8 260 5 -98.08%
Benchmark/JPEG/CMYK/100-8 12548 5 -99.96%
Benchmark/JPEG/CMYK/1000-8 1016068 5 -100.00%
Benchmark/PNG/RGBA/10-8 232 233 +0.43%
Benchmark/PNG/RGBA/100-8 20032 20033 +0.00%
Benchmark/PNG/RGBA/1000-8 2000032 2000033 +0.00%
Benchmark/PNG/RGBA64/10-8 232 233 +0.43%
Benchmark/PNG/RGBA64/100-8 20032 20033 +0.00%
Benchmark/PNG/RGBA64/1000-8 2000032 2000033 +0.00%
Benchmark/PNG/NRGBA/10-8 32 33 +3.12%
Benchmark/PNG/NRGBA/100-8 32 33 +3.12%
Benchmark/PNG/NRGBA/1000-8 32 33 +3.12%
Benchmark/PNG/NRGBA64/10-8 132 133 +0.76%
Benchmark/PNG/NRGBA64/100-8 10032 10033 +0.01%
Benchmark/PNG/NRGBA64/1000-8 1000032 1000033 +0.00%
Benchmark/PNG/Alpha/10-8 232 233 +0.43%
Benchmark/PNG/Alpha/100-8 20032 20033 +0.00%
Benchmark/PNG/Alpha/1000-8 2000032 2000033 +0.00%
Benchmark/PNG/Alpha16/10-8 232 233 +0.43%
Benchmark/PNG/Alpha16/100-8 20032 20033 +0.00%
Benchmark/PNG/Alpha16/1000-8 2000032 2000033 +0.00%
Benchmark/PNG/Gray/10-8 32 33 +3.12%
Benchmark/PNG/Gray/100-8 32 33 +3.12%
Benchmark/PNG/Gray/1000-8 32 33 +3.12%
Benchmark/PNG/Gray16/10-8 132 133 +0.76%
Benchmark/PNG/Gray16/100-8 10032 10033 +0.01%
Benchmark/PNG/Gray16/1000-8 1000032 1000033 +0.00%
Benchmark/PNG/Paletted/10-8 38 40 +5.26%
Benchmark/PNG/Paletted/100-8 38 40 +5.26%
Benchmark/PNG/Paletted/1000-8 38 40 +5.26%
Benchmark/PNG/YCbCr/10-8 132 33 -75.00%
Benchmark/PNG/YCbCr/100-8 10032 33 -99.67%
Benchmark/PNG/YCbCr/1000-8 1000032 33 -100.00%
Benchmark/PNG/NYCbCrA/10-8 232 233 +0.43%
Benchmark/PNG/NYCbCrA/100-8 20032 20033 +0.00%
Benchmark/PNG/NYCbCrA/1000-8 2000032 2000033 +0.00%
Benchmark/PNG/CMYK/10-8 132 33 -75.00%
Benchmark/PNG/CMYK/100-8 10032 33 -99.67%
Benchmark/PNG/CMYK/1000-8 1000032 33 -100.00%
Benchmark/BMP/RGBA/10-8 33 33 +0.00%
Benchmark/BMP/RGBA/100-8 33 33 +0.00%
Benchmark/BMP/RGBA/1000-8 33 33 +0.00%
Benchmark/BMP/RGBA64/10-8 133 34 -74.44%
Benchmark/BMP/RGBA64/100-8 10033 34 -99.66%
Benchmark/BMP/RGBA64/1000-8 1000033 34 -100.00%
Benchmark/BMP/NRGBA/10-8 133 34 -74.44%
Benchmark/BMP/NRGBA/100-8 10033 34 -99.66%
Benchmark/BMP/NRGBA/1000-8 1000033 34 -100.00%
Benchmark/BMP/NRGBA64/10-8 133 34 -74.44%
Benchmark/BMP/NRGBA64/100-8 10033 34 -99.66%
Benchmark/BMP/NRGBA64/1000-8 1000033 34 -100.00%
Benchmark/BMP/Alpha/10-8 133 34 -74.44%
Benchmark/BMP/Alpha/100-8 10033 34 -99.66%
Benchmark/BMP/Alpha/1000-8 1000033 34 -100.00%
Benchmark/BMP/Alpha16/10-8 133 34 -74.44%
Benchmark/BMP/Alpha16/100-8 10033 34 -99.66%
Benchmark/BMP/Alpha16/1000-8 1000033 34 -100.00%
Benchmark/BMP/Gray/10-8 37 37 +0.00%
Benchmark/BMP/Gray/100-8 36 36 +0.00%
Benchmark/BMP/Gray/1000-8 36 36 +0.00%
Benchmark/BMP/Gray16/10-8 133 34 -74.44%
Benchmark/BMP/Gray16/100-8 10033 34 -99.66%
Benchmark/BMP/Gray16/1000-8 1000033 34 -100.00%
Benchmark/BMP/Paletted/10-8 37 37 +0.00%
Benchmark/BMP/Paletted/100-8 36 36 +0.00%
Benchmark/BMP/Paletted/1000-8 36 36 +0.00%
Benchmark/BMP/YCbCr/10-8 133 34 -74.44%
Benchmark/BMP/YCbCr/100-8 10033 34 -99.66%
Benchmark/BMP/YCbCr/1000-8 1000033 34 -100.00%
Benchmark/BMP/NYCbCrA/10-8 133 34 -74.44%
Benchmark/BMP/NYCbCrA/100-8 10033 34 -99.66%
Benchmark/BMP/NYCbCrA/1000-8 1000033 34 -100.00%
Benchmark/BMP/CMYK/10-8 133 34 -74.44%
Benchmark/BMP/CMYK/100-8 10033 34 -99.66%
Benchmark/BMP/CMYK/1000-8 1000033 34 -100.00%
Benchmark/TIFF/RGBA/10-8 25 25 +0.00%
Benchmark/TIFF/RGBA/100-8 25 25 +0.00%
Benchmark/TIFF/RGBA/1000-8 25 25 +0.00%
Benchmark/TIFF/RGBA64/10-8 27 27 +0.00%
Benchmark/TIFF/RGBA64/100-8 27 27 +0.00%
Benchmark/TIFF/RGBA64/1000-8 27 27 +0.00%
Benchmark/TIFF/NRGBA/10-8 25 25 +0.00%
Benchmark/TIFF/NRGBA/100-8 25 25 +0.00%
Benchmark/TIFF/NRGBA/1000-8 25 25 +0.00%
Benchmark/TIFF/NRGBA64/10-8 27 27 +0.00%
Benchmark/TIFF/NRGBA64/100-8 27 27 +0.00%
Benchmark/TIFF/NRGBA64/1000-8 27 27 +0.00%
Benchmark/TIFF/Alpha/10-8 126 27 -78.57%
Benchmark/TIFF/Alpha/100-8 10026 27 -99.73%
Benchmark/TIFF/Alpha/1000-8 1000026 27 -100.00%
Benchmark/TIFF/Alpha16/10-8 126 27 -78.57%
Benchmark/TIFF/Alpha16/100-8 10026 27 -99.73%
Benchmark/TIFF/Alpha16/1000-8 1000026 27 -100.00%
Benchmark/TIFF/Gray/10-8 24 24 +0.00%
Benchmark/TIFF/Gray/100-8 24 24 +0.00%
Benchmark/TIFF/Gray/1000-8 24 24 +0.00%
Benchmark/TIFF/Gray16/10-8 25 25 +0.00%
Benchmark/TIFF/Gray16/100-8 25 25 +0.00%
Benchmark/TIFF/Gray16/1000-8 25 25 +0.00%
Benchmark/TIFF/Paletted/10-8 27 27 +0.00%
Benchmark/TIFF/Paletted/100-8 27 27 +0.00%
Benchmark/TIFF/Paletted/1000-8 27 27 +0.00%
Benchmark/TIFF/YCbCr/10-8 126 27 -78.57%
Benchmark/TIFF/YCbCr/100-8 10026 27 -99.73%
Benchmark/TIFF/YCbCr/1000-8 1000026 27 -100.00%
Benchmark/TIFF/NYCbCrA/10-8 126 27 -78.57%
Benchmark/TIFF/NYCbCrA/100-8 10026 27 -99.73%
Benchmark/TIFF/NYCbCrA/1000-8 1000026 27 -100.00%
Benchmark/TIFF/CMYK/10-8 126 27 -78.57%
Benchmark/TIFF/CMYK/100-8 10026 27 -99.73%
Benchmark/TIFF/CMYK/1000-8 1000026 27 -100.00%
benchmark old bytes new bytes delta
Benchmark/JPEG/RGBA/10-8 4400 4416 +0.36%
Benchmark/JPEG/RGBA/100-8 4400 4416 +0.36%
Benchmark/JPEG/RGBA/1000-8 4400 4416 +0.36%
Benchmark/JPEG/RGBA64/10-8 6448 4416 -31.51%
Benchmark/JPEG/RGBA64/100-8 104752 4416 -95.78%
Benchmark/JPEG/RGBA64/1000-8 8132924 4416 -99.95%
Benchmark/JPEG/NRGBA/10-8 5424 4416 -18.58%
Benchmark/JPEG/NRGBA/100-8 54576 4416 -91.91%
Benchmark/JPEG/NRGBA/1000-8 4068676 4416 -99.89%
Benchmark/JPEG/NRGBA64/10-8 6448 4416 -31.51%
Benchmark/JPEG/NRGBA64/100-8 104752 4416 -95.78%
Benchmark/JPEG/NRGBA64/1000-8 8132924 4416 -99.95%
Benchmark/JPEG/Alpha/10-8 4656 4416 -5.15%
Benchmark/JPEG/Alpha/100-8 16944 4416 -73.94%
Benchmark/JPEG/Alpha/1000-8 1020471 4416 -99.57%
Benchmark/JPEG/Alpha16/10-8 4912 4416 -10.10%
Benchmark/JPEG/Alpha16/100-8 29488 4416 -85.02%
Benchmark/JPEG/Alpha16/1000-8 2036550 4416 -99.78%
Benchmark/JPEG/Gray/10-8 4400 4400 +0.00%
Benchmark/JPEG/Gray/100-8 4400 4400 +0.00%
Benchmark/JPEG/Gray/1000-8 4400 4400 +0.00%
Benchmark/JPEG/Gray16/10-8 4912 4416 -10.10%
Benchmark/JPEG/Gray16/100-8 29488 4416 -85.02%
Benchmark/JPEG/Gray16/1000-8 2036550 4416 -99.78%
Benchmark/JPEG/Paletted/10-8 4400 4512 +2.55%
Benchmark/JPEG/Paletted/100-8 4400 4512 +2.55%
Benchmark/JPEG/Paletted/1000-8 4400 4512 +2.55%
Benchmark/JPEG/YCbCr/10-8 5219 4416 -15.39%
Benchmark/JPEG/YCbCr/100-8 44541 4416 -90.09%
Benchmark/JPEG/YCbCr/1000-8 3255826 4416 -99.86%
Benchmark/JPEG/NYCbCrA/10-8 5424 4416 -18.58%
Benchmark/JPEG/NYCbCrA/100-8 54576 4416 -91.91%
Benchmark/JPEG/NYCbCrA/1000-8 4068676 4416 -99.89%
Benchmark/JPEG/CMYK/10-8 5424 4416 -18.58%
Benchmark/JPEG/CMYK/100-8 54576 4416 -91.91%
Benchmark/JPEG/CMYK/1000-8 4068674 4416 -99.89%
Benchmark/PNG/RGBA/10-8 848947 848963 +0.00%
Benchmark/PNG/RGBA/100-8 930357 930373 +0.00%
Benchmark/PNG/RGBA/1000-8 8872468 8872480 +0.00%
Benchmark/PNG/RGBA64/10-8 850035 850051 +0.00%
Benchmark/PNG/RGBA64/100-8 1013234 1013249 +0.00%
Benchmark/PNG/RGBA64/1000-8 16897030 16897052 +0.00%
Benchmark/PNG/NRGBA/10-8 848147 848163 +0.00%
Benchmark/PNG/NRGBA/100-8 850356 850372 +0.00%
Benchmark/PNG/NRGBA/1000-8 872433 872450 +0.00%
Benchmark/PNG/NRGBA64/10-8 849235 849251 +0.00%
Benchmark/PNG/NRGBA64/100-8 933237 933253 +0.00%
Benchmark/PNG/NRGBA64/1000-8 8897022 8897035 +0.00%
Benchmark/PNG/Alpha/10-8 848946 848963 +0.00%
Benchmark/PNG/Alpha/100-8 930357 930372 +0.00%
Benchmark/PNG/Alpha/1000-8 8872497 8872518 +0.00%
Benchmark/PNG/Alpha16/10-8 850027 850043 +0.00%
Benchmark/PNG/Alpha16/100-8 1013228 1013245 +0.00%
Benchmark/PNG/Alpha16/1000-8 16897088 16897084 -0.00%
Benchmark/PNG/Gray/10-8 847955 847971 +0.00%
Benchmark/PNG/Gray/100-8 848531 848548 +0.00%
Benchmark/PNG/Gray/1000-8 854008 854023 +0.00%
Benchmark/PNG/Gray16/10-8 848251 848267 +0.00%
Benchmark/PNG/Gray16/100-8 869107 869123 +0.00%
Benchmark/PNG/Gray16/1000-8 2860163 2860184 +0.00%
Benchmark/PNG/Paletted/10-8 848019 848131 +0.01%
Benchmark/PNG/Paletted/100-8 848595 848708 +0.01%
Benchmark/PNG/Paletted/1000-8 854069 854183 +0.01%
Benchmark/PNG/YCbCr/10-8 848563 848259 -0.04%
Benchmark/PNG/YCbCr/100-8 883701 851716 -3.62%
Benchmark/PNG/YCbCr/1000-8 4084742 884739 -78.34%
Benchmark/PNG/NYCbCrA/10-8 850027 850043 +0.00%
Benchmark/PNG/NYCbCrA/100-8 1013226 1013242 +0.00%
Benchmark/PNG/NYCbCrA/1000-8 16897044 16897067 +0.00%
Benchmark/PNG/CMYK/10-8 848643 848259 -0.05%
Benchmark/PNG/CMYK/100-8 891701 851717 -4.48%
Benchmark/PNG/CMYK/1000-8 4884737 884741 -81.89%
Benchmark/BMP/RGBA/10-8 400 400 +0.00%
Benchmark/BMP/RGBA/100-8 688 688 +0.00%
Benchmark/BMP/RGBA/1000-8 3440 3440 +0.00%
Benchmark/BMP/RGBA64/10-8 1200 416 -65.33%
Benchmark/BMP/RGBA64/100-8 80688 704 -99.13%
Benchmark/BMP/RGBA64/1000-8 8003450 3456 -99.96%
Benchmark/BMP/NRGBA/10-8 800 416 -48.00%
Benchmark/BMP/NRGBA/100-8 40688 704 -98.27%
Benchmark/BMP/NRGBA/1000-8 4003453 3456 -99.91%
Benchmark/BMP/NRGBA64/10-8 1200 416 -65.33%
Benchmark/BMP/NRGBA64/100-8 80688 704 -99.13%
Benchmark/BMP/NRGBA64/1000-8 8003451 3456 -99.96%
Benchmark/BMP/Alpha/10-8 504 416 -17.46%
Benchmark/BMP/Alpha/100-8 10688 704 -93.41%
Benchmark/BMP/Alpha/1000-8 1003446 3456 -99.66%
Benchmark/BMP/Alpha16/10-8 600 416 -30.67%
Benchmark/BMP/Alpha16/100-8 20688 704 -96.60%
Benchmark/BMP/Alpha16/1000-8 2003451 3456 -99.83%
Benchmark/BMP/Gray/10-8 2464 2464 +0.00%
Benchmark/BMP/Gray/100-8 2456 2456 +0.00%
Benchmark/BMP/Gray/1000-8 2456 2456 +0.00%
Benchmark/BMP/Gray16/10-8 600 416 -30.67%
Benchmark/BMP/Gray16/100-8 20688 704 -96.60%
Benchmark/BMP/Gray16/1000-8 2003450 3456 -99.83%
Benchmark/BMP/Paletted/10-8 2464 2464 +0.00%
Benchmark/BMP/Paletted/100-8 2456 2456 +0.00%
Benchmark/BMP/Paletted/1000-8 2456 2456 +0.00%
Benchmark/BMP/YCbCr/10-8 720 416 -42.22%
Benchmark/BMP/YCbCr/100-8 32688 704 -97.85%
Benchmark/BMP/YCbCr/1000-8 3203455 3456 -99.89%
Benchmark/BMP/NYCbCrA/10-8 800 416 -48.00%
Benchmark/BMP/NYCbCrA/100-8 40688 704 -98.27%
Benchmark/BMP/NYCbCrA/1000-8 4003454 3456 -99.91%
Benchmark/BMP/CMYK/10-8 800 416 -48.00%
Benchmark/BMP/CMYK/100-8 40688 704 -98.27%
Benchmark/BMP/CMYK/1000-8 4003453 3456 -99.91%
Benchmark/TIFF/RGBA/10-8 2800 2800 +0.00%
Benchmark/TIFF/RGBA/100-8 2800 2800 +0.00%
Benchmark/TIFF/RGBA/1000-8 2800 2800 +0.00%
Benchmark/TIFF/RGBA64/10-8 2896 2896 +0.00%
Benchmark/TIFF/RGBA64/100-8 3712 3712 +0.00%
Benchmark/TIFF/RGBA64/1000-8 11008 11008 +0.00%
Benchmark/TIFF/NRGBA/10-8 2800 2800 +0.00%
Benchmark/TIFF/NRGBA/100-8 2800 2800 +0.00%
Benchmark/TIFF/NRGBA/1000-8 2800 2800 +0.00%
Benchmark/TIFF/NRGBA64/10-8 2896 2896 +0.00%
Benchmark/TIFF/NRGBA64/100-8 3712 3712 +0.00%
Benchmark/TIFF/NRGBA64/1000-8 11008 11008 +0.00%
Benchmark/TIFF/Alpha/10-8 2960 2864 -3.24%
Benchmark/TIFF/Alpha/100-8 13216 3232 -75.54%
Benchmark/TIFF/Alpha/1000-8 1006898 6912 -99.31%
Benchmark/TIFF/Alpha16/10-8 3056 2864 -6.28%
Benchmark/TIFF/Alpha16/100-8 23216 3232 -86.08%
Benchmark/TIFF/Alpha16/1000-8 2006901 6912 -99.66%
Benchmark/TIFF/Gray/10-8 1784 1784 +0.00%
Benchmark/TIFF/Gray/100-8 1784 1784 +0.00%
Benchmark/TIFF/Gray/1000-8 1784 1784 +0.00%
Benchmark/TIFF/Gray16/10-8 1816 1816 +0.00%
Benchmark/TIFF/Gray16/100-8 1992 1992 +0.00%
Benchmark/TIFF/Gray16/1000-8 3832 3832 +0.00%
Benchmark/TIFF/Paletted/10-8 7928 7928 +0.00%
Benchmark/TIFF/Paletted/100-8 7928 7928 +0.00%
Benchmark/TIFF/Paletted/1000-8 7928 7928 +0.00%
Benchmark/TIFF/YCbCr/10-8 3184 2864 -10.05%
Benchmark/TIFF/YCbCr/100-8 35232 3232 -90.83%
Benchmark/TIFF/YCbCr/1000-8 3206914 6912 -99.78%
Benchmark/TIFF/NYCbCrA/10-8 3248 2864 -11.82%
Benchmark/TIFF/NYCbCrA/100-8 43216 3232 -92.52%
Benchmark/TIFF/NYCbCrA/1000-8 4006906 6912 -99.83%
Benchmark/TIFF/CMYK/10-8 3248 2864 -11.82%
Benchmark/TIFF/CMYK/100-8 43216 3232 -92.52%
Benchmark/TIFF/CMYK/1000-8 4006903 6912 -99.83%
```
My library should also speed up "copy" function (from an image type to another).
The modifications in the standard library and x/image are really straightforward:
- replace all `\.At\(.*\)\.RGBA\(\)` to a call to a `AtFunc`
- call `NewAtFunc()` before a "y/x" loop
The `image/jpeg.toYCbCr()` is tricky.
You need to call `NewAtFunc` in `image/jpeg.encoder.writeSOS()` and pass the `AtFunc` to `toYCbCr()`.
I also had to move my library to the standard library, because the go tool complained about bad imports...
As you can see: https://github.com/pierrre/imageutil
my code is tested and it returns the same results as the standard library.
| Performance | low | Critical |
155,855,154 | go | x/build: monitor all the parts of the build system | The watcher is not pushing new commits to build.golang.org.
I see:
```
949 ? Ssl 8:51 docker daemon --host=fd:// --selinux-enabled
17215 ? Ssl 15:55 \_ /usr/local/bin/watcher -role=watcher -watcher.repo=https://go.googlesource.com/go -watcher.dash=https://build.golang.org/ -watcher.poll=10s -watcher.http=127.0.0.1:21536 -watcher.mirror=htt
5570 ? Z 0:00 \_ [git-remote-http] <defunct>
5608 ? Z 0:00 \_ [git-remote-http] <defunct>
5618 ? Z 0:00 \_ [git-remote-http] <defunct>
16843 ? S 1:34 \_ git push -f --mirror dest
18371 ? S 0:00 | \_ git-remote-https dest https://gopherbot:[redacted]@github.com/golang/go
18178 ? S 0:00 \_ git push -f --mirror dest
18389 ? S 0:00 | \_ git-remote-https dest https://gopherbot:[redacted]@github.com/golang/mobile
18335 ? S 0:00 \_ git push -f --mirror dest
18387 ? R 0:00 \_ git-remote-https dest https://gopherbot:[redacted]@github.com/golang/oauth2
```
And http://farmer.golang.org/debug/watcher at the end says only:
```
2016/05/19 18:43:40 go: sending commit to dashboard: ---40hexomitted---[master]("build: unset GOBIN during build")
2016/05/19 19:29:24 exp: found new commit ---40hexomitted---("shiny/widget/flex: add HTML printing of tests")
2016/05/19 19:29:24 exp: updated branch head: "master"(Head: ---40hexomitted---[master]("shiny/widget/flex: add HTML printing of tests") LastSeen: ---40hexomitted---[master]("shiny/driver/x11driver: have textureImpl.draw use an opaque mask."))
2016/05/19 19:29:24 exp: sending commit to dashboard: ---40hexomitted---[master]("shiny/widget/flex: add HTML printing of tests")
2016/05/19 19:36:46 exp: found new commit ---40hexomitted---("shiny/widget/flex: basics of flex algorithm")
2016/05/19 19:36:46 exp: updated branch head: "master"(Head: ---40hexomitted---[master]("shiny/widget/flex: basics of flex algorithm") LastSeen: ---40hexomitted---[master]("shiny/widget/flex: add HTML printing of tests"))
2016/05/19 19:36:46 exp: sending commit to dashboard: ---40hexomitted---[master]("shiny/widget/flex: basics of flex algorithm")
2016/05/19 22:45:58 exp: found new commit ---40hexomitted---("shiny/driver/x11driver: tighten the textureImpl.draw dst rectangle.")
2016/05/19 22:45:58 exp: updated branch head: "master"(Head: ---40hexomitted---[master]("shiny/driver/x11driver: tighten the textureImpl.draw dst rectangle.") LastSeen: ---40hexomitted---[master]("shiny/widget/flex: basics of flex algorithm"))
2016/05/19 22:45:58 exp: sending commit to dashboard: ---40hexomitted---[master]("shiny/driver/x11driver: tighten the textureImpl.draw dst rectangle.")
```
Server time is:
```
$ date
Thu May 19 23:06:28 UTC 2016
```
So it's just the go repo that's hung?
But the git subprocess for the go repo keeps coming & going. It's not hung there.
We should have a debugging endpoint to get the watcher's goroutines too.
I'll kick it for now.
This also needs to be monitored.
| Builders | low | Critical |
155,928,635 | youtube-dl | Automatically download subtitles with --embed-subs (was: '--all-subs' downloads and embeds subtitles but '--sub-lang en' does not) | ## Checks
- [x] I've **verified** and **I assure** that I'm running youtube-dl **2016.05.16**
- [x] At least skimmed through [README](https://github.com/rg3/youtube-dl/blob/master/README.md) and **most notably** [FAQ](https://github.com/rg3/youtube-dl#faq) and [BUGS](https://github.com/rg3/youtube-dl#bugs) sections
- [x] [Searched](https://github.com/rg3/youtube-dl/search?type=Issues) the bugtracker for similar issues including closed ones
### What is the purpose of your _issue_?
- [x] Bug report (encountered problems with youtube-dl)
- [ ] Site support request (request for adding support for a new site)
- [ ] Feature request (request for a new functionality)
- [ ] Question
- [ ] Other
---
## Summary
I have
```
-o "~/Movies/%(uploader)s/%(title)s.%(ext)s"
# Subtitles
--sub-lang en
#--all-subs
--embed-subs
--embed-thumbnail
--add-metadata
```
in my `~/.config/youtube-dl/config` file.
Running `~ ❯❯❯ youtube-dl "https://www.youtube.com/watch?v=P5-WGdiWAB4" -v` on [this video](https://www.youtube.com/watch?v=P5-WGdiWAB4) with English (en) and Portuguese (pt) subtitles will download and embed the subtitles when `--all-subs` is uncommented but `--sub-lang en` is works, but not the other way around. Additionally `--sub-lang en,pt` fails to download and embed either set of subtitles.
## Logs
##### `-all-subs`:
```
[debug] System config: []
[debug] User config: ['-o', '~/Movies/%(uploader)s/%(title)s.%(ext)s', '--all-subs', '--embed-subs', '--embed-thumbnail', '--add-metadata']
[debug] Command-line args: ['https://www.youtube.com/watch?v=P5-WGdiWAB4', '-v']
[debug] Encodings: locale UTF-8, fs utf-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2016.05.10
[debug] Python version 3.5.1 - Linux-4.5.4-1-ARCH-x86_64-with-arch
[debug] exe versions: ffmpeg 3.0.2, ffprobe 3.0.2
[debug] Proxy map: {}
[youtube] P5-WGdiWAB4: Downloading webpage
[youtube] P5-WGdiWAB4: Downloading video info webpage
[youtube] P5-WGdiWAB4: Extracting video information
[youtube] P5-WGdiWAB4: Downloading MPD manifest
[info] Writing video subtitles to: /home/expenses/Movies/The Intercept/Excerpt of Glenn Greenwald's interview with Brazilian President Dilma Rousseff.en.vtt
[info] Writing video subtitles to: /home/expenses/Movies/The Intercept/Excerpt of Glenn Greenwald's interview with Brazilian President Dilma Rousseff.pt.vtt
[youtube] P5-WGdiWAB4: Downloading thumbnail ...
[youtube] P5-WGdiWAB4: Writing thumbnail to: /home/expenses/Movies/The Intercept/Excerpt of Glenn Greenwald's interview with Brazilian President Dilma Rousseff.jpg
[debug] Invoking downloader on 'https://r4---sn-uo1-jije.googlevideo.com/videoplayback?id=3f9f9619d896001e&itag=137&source=youtube&requiressl=yes&initcwndbps=1181250&mn=sn-uo1-jije&mm=31&mv=m&ms=au&pl=21&ratebypass=yes&mime=video/mp4&gir=yes&clen=18750294&lmt=1463722565073351&dur=80.121&fexp=9405973,9414672,9416126,9416891,9417703,9422596,9423554,9428398,9431012,9432565,9433096,9433700,9433946,9435876,9436606,9436795,9436824,9436958,9437066&key=dg_yt0&mt=1463736430&signature=9141645C1412576A8A52F832FDBA27E5275397C5.38C000C9458CF75FDE2AC6C3D47571C3BD27BEA6&upn=Xhy1zeMw6VU&sver=3&ip=219.89.38.110&ipbits=0&expire=1463758362&sparams=ip,ipbits,expire,id,itag,source,requiressl,initcwndbps,mn,mm,mv,ms,pl,ratebypass,mime,gir,clen,lmt,dur'
[download] Destination: /home/expenses/Movies/The Intercept/Excerpt of Glenn Greenwald's interview with Brazilian President Dilma Rousseff.f137.mp4
[download] 100% of 17.88MiB in 00:48
[debug] Invoking downloader on 'https://r4---sn-uo1-jije.googlevideo.com/videoplayback?id=3f9f9619d896001e&itag=140&source=youtube&requiressl=yes&initcwndbps=1181250&mn=sn-uo1-jije&mm=31&mv=m&ms=au&pl=21&ratebypass=yes&mime=audio/mp4&gir=yes&clen=1274165&lmt=1463722461754020&dur=80.178&fexp=9405973,9414672,9416126,9416891,9417703,9422596,9423554,9428398,9431012,9432565,9433096,9433700,9433946,9435876,9436606,9436795,9436824,9436958,9437066&key=dg_yt0&mt=1463736430&signature=2AA9513411B82F9A966A7B19CE90E7211814EB81.3DD95CD215461542B92D6F902D86EB3C8408C960&upn=Xhy1zeMw6VU&sver=3&ip=219.89.38.110&ipbits=0&expire=1463758362&sparams=ip,ipbits,expire,id,itag,source,requiressl,initcwndbps,mn,mm,mv,ms,pl,ratebypass,mime,gir,clen,lmt,dur'
[download] Destination: /home/expenses/Movies/The Intercept/Excerpt of Glenn Greenwald's interview with Brazilian President Dilma Rousseff.f140.m4a
[download] 100% of 1.22MiB in 00:03
[ffmpeg] Merging formats into "/home/expenses/Movies/The Intercept/Excerpt of Glenn Greenwald's interview with Brazilian President Dilma Rousseff.mp4"
[debug] ffmpeg command line: ffmpeg -y -i 'file:/home/expenses/Movies/The Intercept/Excerpt of Glenn Greenwald'"'"'s interview with Brazilian President Dilma Rousseff.f137.mp4' -i 'file:/home/expenses/Movies/The Intercept/Excerpt of Glenn Greenwald'"'"'s interview with Brazilian President Dilma Rousseff.f140.m4a' -c copy -map 0:v:0 -map 1:a:0 'file:/home/expenses/Movies/The Intercept/Excerpt of Glenn Greenwald'"'"'s interview with Brazilian President Dilma Rousseff.temp.mp4'
Deleting original file /home/expenses/Movies/The Intercept/Excerpt of Glenn Greenwald's interview with Brazilian President Dilma Rousseff.f137.mp4 (pass -k to keep)
Deleting original file /home/expenses/Movies/The Intercept/Excerpt of Glenn Greenwald's interview with Brazilian President Dilma Rousseff.f140.m4a (pass -k to keep)
[ffmpeg] Adding metadata to '/home/expenses/Movies/The Intercept/Excerpt of Glenn Greenwald's interview with Brazilian President Dilma Rousseff.mp4'
[debug] ffmpeg command line: ffmpeg -y -i 'file:/home/expenses/Movies/The Intercept/Excerpt of Glenn Greenwald'"'"'s interview with Brazilian President Dilma Rousseff.mp4' -c copy -metadata 'purl=https://www.youtube.com/watch?v=P5-WGdiWAB4' -metadata 'title=Excerpt of Glenn Greenwald'"'"'s interview with Brazilian President Dilma Rousseff' -metadata 'artist=The Intercept' -metadata date=20160518 -metadata 'comment=How did the now-suspended President react when she saw the corruption-implicated, right-wing all-white-male cabinet appointed by the substitute President who took her job? Watch the full interview at The Intercept.' -metadata 'description=How did the now-suspended President react when she saw the corruption-implicated, right-wing all-white-male cabinet appointed by the substitute President who took her job? Watch the full interview at The Intercept.' 'file:/home/expenses/Movies/The Intercept/Excerpt of Glenn Greenwald'"'"'s interview with Brazilian President Dilma Rousseff.temp.mp4'
[ffmpeg] Embedding subtitles in '/home/expenses/Movies/The Intercept/Excerpt of Glenn Greenwald's interview with Brazilian President Dilma Rousseff.mp4'
[debug] ffmpeg command line: ffmpeg -y -i 'file:/home/expenses/Movies/The Intercept/Excerpt of Glenn Greenwald'"'"'s interview with Brazilian President Dilma Rousseff.mp4' -i 'file:/home/expenses/Movies/The Intercept/Excerpt of Glenn Greenwald'"'"'s interview with Brazilian President Dilma Rousseff.en.vtt' -i 'file:/home/expenses/Movies/The Intercept/Excerpt of Glenn Greenwald'"'"'s interview with Brazilian President Dilma Rousseff.pt.vtt' -map 0 -c copy -map -0:s -c:s mov_text -map 1:0 -metadata:s:s:0 language=eng -map 2:0 -metadata:s:s:1 language=por 'file:/home/expenses/Movies/The Intercept/Excerpt of Glenn Greenwald'"'"'s interview with Brazilian President Dilma Rousseff.temp.mp4'
Deleting original file /home/expenses/Movies/The Intercept/Excerpt of Glenn Greenwald's interview with Brazilian President Dilma Rousseff.en.vtt (pass -k to keep)
Deleting original file /home/expenses/Movies/The Intercept/Excerpt of Glenn Greenwald's interview with Brazilian President Dilma Rousseff.pt.vtt (pass -k to keep)
[atomicparsley] Adding thumbnail to "/home/expenses/Movies/The Intercept/Excerpt of Glenn Greenwald's interview with Brazilian President Dilma Rousseff.mp4"
[debug] AtomicParsley command line: AtomicParsley '/home/expenses/Movies/The Intercept/Excerpt of Glenn Greenwald'"'"'s interview with Brazilian President Dilma Rousseff.mp4' --artwork '/home/expenses/Movies/The Intercept/Excerpt of Glenn Greenwald'"'"'s interview with Brazilian President Dilma Rousseff.jpg' -o '/home/expenses/Movies/The Intercept/Excerpt of Glenn Greenwald'"'"'s interview with Brazilian President Dilma Rousseff.temp.mp4'
```
##### `--sub-lang en`:
```
[debug] System config: []
[debug] User config: ['-o', '~/Movies/%(uploader)s/%(title)s.%(ext)s', '--sub-lang', 'en', '--embed-subs', '--embed-thumbnail', '--add-metadata']
[debug] Command-line args: ['https://www.youtube.com/watch?v=P5-WGdiWAB4', '-v']
[debug] Encodings: locale UTF-8, fs utf-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2016.05.10
[debug] Python version 3.5.1 - Linux-4.5.4-1-ARCH-x86_64-with-arch
[debug] exe versions: ffmpeg 3.0.2, ffprobe 3.0.2
[debug] Proxy map: {}
[youtube] P5-WGdiWAB4: Downloading webpage
[youtube] P5-WGdiWAB4: Downloading video info webpage
[youtube] P5-WGdiWAB4: Extracting video information
[youtube] P5-WGdiWAB4: Downloading MPD manifest
[youtube] P5-WGdiWAB4: Downloading thumbnail ...
[youtube] P5-WGdiWAB4: Writing thumbnail to: /home/expenses/Movies/The Intercept/Excerpt of Glenn Greenwald's interview with Brazilian President Dilma Rousseff.jpg
[debug] Invoking downloader on 'https://r4---sn-uo1-jije.googlevideo.com/videoplayback?id=3f9f9619d896001e&itag=137&source=youtube&requiressl=yes&initcwndbps=1176250&mv=m&ms=au&mm=31&mn=sn-uo1-jije&pl=21&ratebypass=yes&mime=video/mp4&gir=yes&clen=18750294&lmt=1463722565073351&dur=80.121&sver=3&key=dg_yt0&upn=mkfxKNChU6M&signature=74FA1D4A0269304A63AA76476AAC7389E0074FD1.61A5FB8EFEC4752F1E28FBE0F7AD56F14D0F0F5B&mt=1463736688&fexp=9416126,9416891,9422596,9428398,9431012,9433096,9433946,9435876&ip=219.89.38.110&ipbits=0&expire=1463758602&sparams=ip,ipbits,expire,id,itag,source,requiressl,initcwndbps,mv,ms,mm,mn,pl,ratebypass,mime,gir,clen,lmt,dur'
[download] Destination: /home/expenses/Movies/The Intercept/Excerpt of Glenn Greenwald's interview with Brazilian President Dilma Rousseff.f137.mp4
[download] 100% of 17.88MiB in 00:27
[debug] Invoking downloader on 'https://r4---sn-uo1-jije.googlevideo.com/videoplayback?id=3f9f9619d896001e&itag=140&source=youtube&requiressl=yes&initcwndbps=1176250&mv=m&ms=au&mm=31&mn=sn-uo1-jije&pl=21&ratebypass=yes&mime=audio/mp4&gir=yes&clen=1274165&lmt=1463722461754020&dur=80.178&sver=3&key=dg_yt0&upn=mkfxKNChU6M&signature=1B5EAA716262E47B2CB6F4BAEB69269E4C8D62BB.9029C4BCB45D8C2650CD07EFA0CBD1149DF9BF94&mt=1463736688&fexp=9416126,9416891,9422596,9428398,9431012,9433096,9433946,9435876&ip=219.89.38.110&ipbits=0&expire=1463758602&sparams=ip,ipbits,expire,id,itag,source,requiressl,initcwndbps,mv,ms,mm,mn,pl,ratebypass,mime,gir,clen,lmt,dur'
[download] Destination: /home/expenses/Movies/The Intercept/Excerpt of Glenn Greenwald's interview with Brazilian President Dilma Rousseff.f140.m4a
[download] 100% of 1.22MiB in 00:05
[ffmpeg] Merging formats into "/home/expenses/Movies/The Intercept/Excerpt of Glenn Greenwald's interview with Brazilian President Dilma Rousseff.mp4"
[debug] ffmpeg command line: ffmpeg -y -i 'file:/home/expenses/Movies/The Intercept/Excerpt of Glenn Greenwald'"'"'s interview with Brazilian President Dilma Rousseff.f137.mp4' -i 'file:/home/expenses/Movies/The Intercept/Excerpt of Glenn Greenwald'"'"'s interview with Brazilian President Dilma Rousseff.f140.m4a' -c copy -map 0:v:0 -map 1:a:0 'file:/home/expenses/Movies/The Intercept/Excerpt of Glenn Greenwald'"'"'s interview with Brazilian President Dilma Rousseff.temp.mp4'
Deleting original file /home/expenses/Movies/The Intercept/Excerpt of Glenn Greenwald's interview with Brazilian President Dilma Rousseff.f137.mp4 (pass -k to keep)
Deleting original file /home/expenses/Movies/The Intercept/Excerpt of Glenn Greenwald's interview with Brazilian President Dilma Rousseff.f140.m4a (pass -k to keep)
[ffmpeg] Adding metadata to '/home/expenses/Movies/The Intercept/Excerpt of Glenn Greenwald's interview with Brazilian President Dilma Rousseff.mp4'
[debug] ffmpeg command line: ffmpeg -y -i 'file:/home/expenses/Movies/The Intercept/Excerpt of Glenn Greenwald'"'"'s interview with Brazilian President Dilma Rousseff.mp4' -c copy -metadata 'purl=https://www.youtube.com/watch?v=P5-WGdiWAB4' -metadata 'description=How did the now-suspended President react when she saw the corruption-implicated, right-wing all-white-male cabinet appointed by the substitute President who took her job? Watch the full interview at The Intercept.' -metadata 'artist=The Intercept' -metadata 'comment=How did the now-suspended President react when she saw the corruption-implicated, right-wing all-white-male cabinet appointed by the substitute President who took her job? Watch the full interview at The Intercept.' -metadata 'title=Excerpt of Glenn Greenwald'"'"'s interview with Brazilian President Dilma Rousseff' -metadata date=20160518 'file:/home/expenses/Movies/The Intercept/Excerpt of Glenn Greenwald'"'"'s interview with Brazilian President Dilma Rousseff.temp.mp4'
[ffmpeg] There aren't any subtitles to embed
[atomicparsley] Adding thumbnail to "/home/expenses/Movies/The Intercept/Excerpt of Glenn Greenwald's interview with Brazilian President Dilma Rousseff.mp4"
[debug] AtomicParsley command line: AtomicParsley '/home/expenses/Movies/The Intercept/Excerpt of Glenn Greenwald'"'"'s interview with Brazilian President Dilma Rousseff.mp4' --artwork '/home/expenses/Movies/The Intercept/Excerpt of Glenn Greenwald'"'"'s interview with Brazilian President Dilma Rousseff.jpg' -o '/home/expenses/Movies/The Intercept/Excerpt of Glenn Greenwald'"'"'s interview with Brazilian President Dilma Rousseff.temp.mp4'
```
| request | low | Critical |
156,047,305 | flutter | test framework in live mode should relayout and repaint if you rotate device | a: tests,c: new feature,framework,P3,team-framework,triaged-framework | low | Minor |
|
156,055,617 | go | x/build/cmd/buildlet: detect and kill stray processes | The buildlet, especially in reverse buildlet mode, needs to learn how to kill stray processes leftover from previous builds.
(This isn't relevant for VM and container-based builders, since the VM or container kill everything when they exit)
But on OS X and other weirder builders where we run the buildlet in reverse-dialing mode, I sometimes see stray processes. Like this:
Notice testgo spinning:
<img width="918" alt="screen shot 2016-05-20 at 2 32 25 pm" src="https://cloud.githubusercontent.com/assets/2621/15442767/f5e99af6-1e97-11e6-9e47-cba5a9477ed4.png">
(I think @ianlancetaylor fixed that bug, but still.... we should be tolerant of such bugs in the future)
This is a tracking bug to make the buildlet smarter: enumerate processes at start and end, and kill new things which didn't go away on their own, especially if they're owned or parented by us. Maybe scan the process list often during builds to learn parents, so we know if they were ours or not.
/cc @zombiezen @adg
| Builders,NeedsFix | low | Critical |
156,073,231 | youtube-dl | Support for http://traktrain.com/ ? | ## Please follow the guide below
- You will be asked some questions and requested to provide some information, please read them **carefully** and answer honestly
- Put an `x` into all the boxes [ ] relevant to your _issue_ (like that [x])
- Use _Preview_ tab to see how your issue will actually look like
---
### Make sure you are using the _latest_ version: run `youtube-dl --version` and ensure your version is _2016.05.16_. If it's not read [this FAQ entry](https://github.com/rg3/youtube-dl/blob/master/README.md#how-do-i-update-youtube-dl) and update. Issues with outdated version will be rejected.
- [ x] I've **verified** and **I assure** that I'm running youtube-dl **2016.05.16**
### Before submitting an _issue_ make sure you have:
- [x ] At least skimmed through [README](https://github.com/rg3/youtube-dl/blob/master/README.md) and **most notably** [FAQ](https://github.com/rg3/youtube-dl#faq) and [BUGS](https://github.com/rg3/youtube-dl#bugs) sections
- [x ] [Searched](https://github.com/rg3/youtube-dl/search?type=Issues) the bugtracker for similar issues including closed ones
### What is the purpose of your _issue_?
- [ ] Bug report (encountered problems with youtube-dl)
- [x ] Site support request (request for adding support for a new site)
- [ ] Feature request (request for a new functionality)
- [ ] Question
- [ ] Other
I would like to request support for this website: http://traktrain.com/.
example:
http://traktrain.com/davidsanyamusic
| site-support-request | low | Critical |
156,074,676 | go | go/types: provide better error message for errors in n:1 init assignment | Given a.go:
```
package p
var a, b []int = f1() // error
func f1() (_ []int, _ int) {
return
}
```
gotype reports:
```
$ gotype a.go
a.go:3:18: cannot use f1() (value of type int) as []int value in assignment
```
vs gc compiler:
```
$ go tool compile a.go
a.go:3: cannot assign int to b (type []int) in multiple assignment
```
The gc compiler's error message is much better.
| NeedsFix | low | Critical |
156,103,204 | youtube-dl | Exception is thrown if NTFS partition is mounted with 'windows_names' option and a directory or file name in the output template ends with a dot | - [x] I've **verified** and **I assure** that I'm running youtube-dl **2016.05.16**
Before submitting an _issue_ make sure you have:
- [x] At least skimmed through [README](https://github.com/rg3/youtube-dl/blob/master/README.md) and **most notably** [FAQ](https://github.com/rg3/youtube-dl#faq) and [BUGS](https://github.com/rg3/youtube-dl#bugs) sections
- [X] [Searched](https://github.com/rg3/youtube-dl/search?type=Issues) the bugtracker for similar issues including closed ones
### What is the purpose of your _issue_?
- [X] Bug report (encountered problems with youtube-dl)
- [ ] Site support request (request for adding support for a new site)
- [ ] Feature request (request for a new functionality)
- [ ] Question
- [ ] Other
---
### Log output
```
$ youtube-dl -v -o "%(uploader)s/%(playlist)s/%(playlist_index)s. %(title)s-%(id)s.%(ext)s" "https://www.youtube.com/playlist?list=PLAZNU5fM7FIBqwbWDY3tBK5EEz16tax0e"
[debug] System config: []
[debug] User config: []
[debug] Command-line args: ['-v', '-o', '%(uploader)s/%(playlist)s/%(playlist_index)s. %(title)s-%(id)s.%(ext)s', 'https://www.youtube.com/playlist?list=PLAZNU5fM7FIBqwbWDY3tBK5EEz16tax0e']
[debug] Encodings: locale UTF-8, fs utf-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2016.05.16
[debug] Python version 3.5.1 - Linux-4.5.4-1-ARCH-x86_64-with-arch
[debug] exe versions: ffmpeg 3.0.2, ffprobe 3.0.2, rtmpdump 2.4
[debug] Proxy map: {}
[youtube:playlist] PLAZNU5fM7FIBqwbWDY3tBK5EEz16tax0e: Downloading webpage
[download] Downloading playlist: Singles/Misc.
[youtube:playlist] playlist Singles/Misc.: Downloading 7 videos
[download] Downloading video 1 of 7
[youtube] PiMJ6Sy2ph4: Downloading webpage
[youtube] PiMJ6Sy2ph4: Downloading video info webpage
[youtube] PiMJ6Sy2ph4: Extracting video information
[youtube] PiMJ6Sy2ph4: Downloading MPD manifest
ERROR: unable to create directory [Errno 22] Invalid argument: 'Proximity/Singles_Misc.'
Traceback (most recent call last):
File "/usr/local/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 1497, in process_info
os.makedirs(dn)
File "/usr/lib/python3.5/os.py", line 241, in makedirs
mkdir(name, mode)
OSError: [Errno 22] Invalid argument: 'Proximity/Singles_Misc.'
```
---
### Description of the issue
NTFS partitions mounted with the `windows_names` option disallows files and directories from containing `<>:"/\|?*` and from ending with a `.`. I believe the former is taken care of by youtube-dl, but the latter is not. Python will throw a `ERROR: unable to create directory [Errno 22] Invalid argument` exception when you try to create a directory ending with a `.`.
In my example, I try to download a playlist named `Singles/Misc.` with the output template `%(uploader)s/%(playlist)s/%(playlist_index)s. %(title)s-%(id)s.%(ext)s`. If the playlist's name, and I presume the uploader's name, ends with `.` the exception will be thrown.
Example `/etc/fstab` for mounting an NTFS partition with the `windows_names` option:
```
/dev/sda1 /mnt/ntfs-partition ntfs-3g defaults,windows_names 0 0
```
### Suggested solution
I see three main alternatives, although if any of you find a more creative solution then please let me know:
- Detect if the partition the file/directory is being written to is NTFS and mounted with the `windows_names` option and follow Windows filename compatibility if that is the case.
- Make the `--restrict-filenames` option also replace dots from the end of directory names and filenames.
- Always replace dots from the end of all directories and filenames.
**NOTE:** Any solution would need to replace an arbitrary amount of dots from the end of the file and directory names, as their names could contain multiple dots: `playlist name...`
| request | low | Critical |
156,108,969 | go | cmd/compile: misleading error for multiple value function call in contexts that do accept multiple values | [playground](https://play.golang.org/p/kHimGTNfNc)
I can use a function's multiple returns as arguments to another function, but cannot use them as parameters in an initialization.
If it is intended, then the compiling error `multiple-value ... in single-value context` is misleading, because an array or struct initialization can indeed take multiple values.
| compiler/runtime | low | Critical |
156,129,772 | youtube-dl | Is this possible to download? (flash player I believe) | ## Please follow the guide below
- You will be asked some questions and requested to provide some information, please read them **carefully** and answer honestly
- Put an `x` into all the boxes [ ] relevant to your _issue_ (like that [x])
- Use _Preview_ tab to see how your issue will actually look like
---
### Make sure you are using the _latest_ version: run `youtube-dl --version` and ensure your version is _2016.05.21.2_. If it's not read [this FAQ entry](https://github.com/rg3/youtube-dl/blob/master/README.md#how-do-i-update-youtube-dl) and update. Issues with outdated version will be rejected.
- [ ] I've **verified** and **I assure** that I'm running youtube-dl **2016.05.21.2**
### Before submitting an _issue_ make sure you have:
- [x ] At least skimmed through [README](https://github.com/rg3/youtube-dl/blob/master/README.md) and **most notably** [FAQ](https://github.com/rg3/youtube-dl#faq) and [BUGS](https://github.com/rg3/youtube-dl#bugs) sections
- [x ] [Searched](https://github.com/rg3/youtube-dl/search?type=Issues) the bugtracker for similar issues including closed ones
### What is the purpose of your _issue_?
- [ ] Bug report (encountered problems with youtube-dl)
- [ x] Site support request (request for adding support for a new site)
- [ ] Feature request (request for a new functionality)
- [ ]x Question
- [ ] Other
---
Is it possible to download from websites like this: http://kswisha.com/ ?
| site-support-request | low | Critical |
156,160,351 | youtube-dl | Improve Brightcove title extraction | For at least some videos using Brightcove, especially those without separate extractors, the 'wrong' title is extracted, e.g.
```
[debug] System config: []
[debug] User config: []
[debug] Command-line args: [u'-v', u'http://www.rollingstone.com/music/videos/norwegian-dj-cashmere-cat-goes-spartan-on-with-me-premiere-20131219']
[debug] Encodings: locale UTF-8, fs utf-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2016.05.21.2
[debug] Git HEAD: e913537
[debug] Python version 2.7.11 - Darwin-15.3.0-x86_64-i386-64bit
[debug] exe versions: avconv 11.4, avprobe 11.4, ffmpeg 3.0.2, ffprobe 3.0.2, rtmpdump 2.4
[debug] Proxy map: {}
[generic] norwegian-dj-cashmere-cat-goes-spartan-on-with-me-premiere-20131219: Requesting header
WARNING: Falling back on generic information extractor.
[generic] norwegian-dj-cashmere-cat-goes-spartan-on-with-me-premiere-20131219: Downloading webpage
[generic] norwegian-dj-cashmere-cat-goes-spartan-on-with-me-premiere-20131219: Extracting information
[download] Downloading playlist: Norwegian DJ Cashmere Cat Goes Spartan on 'With Me' - Premiere
[generic] playlist Norwegian DJ Cashmere Cat Goes Spartan on 'With Me' - Premiere: Collected 1 video ids (downloading 1 of them)
[download] Downloading video 1 of 1
[brightcove:new] 4404576300001: Downloading webpage
[brightcove:new] 4404576300001: Downloading JSON metadata
[brightcove:new] 4404576300001: Downloading m3u8 information
[brightcove:new] 4404576300001: Downloading m3u8 information
[debug] Invoking downloader on u'https://secure.brightcove.com/services/mobile/streaming/index/rendition.m3u8?assetId=4404592834001&secure=true&pubId=3891678521001&videoId=4404576300001'
[hlsnative] Downloading m3u8 manifest
[hlsnative] Total fragments: 24
[download] Destination: Music Video-4404576300001.mp4
[download] 8.3% of ~23.41MiB at 2.24MiB/s ETA 00:25
```
It seems that the Brightcove extractor interprets the video as a playlist with a single video; the playlist title is the actual video title. Improving the Brightcove extractor so that it can better differentiate between playlists and single videos would solve the issue.
| request | low | Critical |
156,201,035 | kubernetes | kubectl edit: error UX is confusing and inconsistent | I edit a pod with some metadata such as:
```
# Please edit the object below. Lines beginning with a '#' will be ignored,
# and an empty file will abort the edit. If an error occurs while saving this file will be
# reopened with the relevant failures.
#
apiVersion: v1
kind: Pod
metadata:
generateName: guestbook-
labels:
app: guestbook
```
Then I close the file and it pops back open with this message after I add `fun: true` label:
```
# Please edit the object below. Lines beginning with a '#' will be ignored,
# and an empty file will abort the edit. If an error occurs while saving this file will be
# reopened with the relevant failures.
#
# The edited file had a syntax error: unable to decode "edited-file": [pos 453]: json: expect char '"' but got char 't'
#
apiVersion: v1
kind: Pod
metadata:
generateName: guestbook-
labels:
app: guestbook
fun: true
```
Putting the error in the comment header is OK but I was very confused when this happened to me and didn't notice the errors at all. A few potential fixes:
1. Print out the errors and then ask the user to "press enter" to fix, then launch the $EDITOR again
2. Put the error message above the line that generated the error
3. Automatically quote true/false values before converting to JSON in fields like labels.
Given the three options 1 is probably easiest and would fix the issue well enough for now.
cc @janetkuo as we discussed this might be a duplicate but I can't find the other one.
| priority/backlog,area/kubectl,kind/feature,help wanted,sig/cli,lifecycle/frozen | medium | Critical |
156,220,349 | vscode | Implement an overflow design for status bar entries | Hello,
For now, when you add a lot of items to the statusbar via plugins, only first few items are displayed and the remaining items are hidden.
It would be great to have a dropdownlist which will show all those remaining items.
I hope such a feature could enhance vscode.
Thanks in advance for your comments.
| feature-request,ux,workbench-status | medium | Major |
156,237,639 | opencv | imreadmutli not clear and some suggestion | Good to know that OpenCV going to handle multiple tiff , but I still did understand imreadmulti documentation , if I have an image with unknown number of pages , who will direct me to use imread or imreadmulti , another issue imreadmulti read all pages in memory (verctor of MAT) , I have some books may reach to 1000 pages or more , loading all pages will consume most of device memory , I think it's better to be implemented as follow
1-Function to get number of pages .
2-If number of pages is one we can call imread
3-If Number of pages larger than 1 we can call imreadmulti
4-Do not load all pages in memory , just open the required index.
5-If the user need all pages , he will use the pages counter obtained from point 1 and loop all pages.
| feature,category: imgcodecs,effort: few days | low | Minor |
156,267,412 | opencv | MSER Connected Components not accessable from class | ### Please state the information for your system
- OpenCV version: 3.x
- Host OS: Linux (Ubuntu 16.04)
### In which part of the OpenCV library you got the issue?
- MSER feature detector
### Expected behaviour
I would like to have access to the connected components from MSER algorithm in order to implement text detection.
### Actual behaviour
There is not way to get the connected components
### Additional description
Hey, I want to implement [robust text detection in natural images](http://web.stanford.edu/~hchen2/papers/ICIP2011_RobustTextDetection.pdf), as shown in this [official matlab example](http://www.mathworks.com/help/vision/examples/automatically-detect-and-recognize-text-in-natural-images.html). But in order to do it you must have access to the connected components within the MSER algorithm.
Those are [computed by opencv here](https://github.com/Itseez/opencv/blob/09df1a286b62450f2b619ee1d4fec02000daa2e4/modules/features2d/src/mser.cpp#L368), but as you can see from the code they are not saved anywhere and there is no way to pull them out of the function. I am not sure how to pull this from the c++ library without breaking something. I would gladly make a pull request if someone points me in the right direction.
### Code example to reproduce the issue / Steps to reproduce the issue
Please try to give a full example which will compile as is.
python:
``` python
img = cv2.imread(img)
mser.setDelta(4)
mser.setMinArea(200)
mser.setMaxArea(8000)
ngrey = cv2.cvtColor(origin, cv2.COLOR_BGR2GRAY)
regions = mser.detectRegions(ngrey, None)
#would like to have
#regions, mser_comp = mser.detectRegionsWithConnectedComponents(img, None)
```
c++:
``` c++
Mat image = imread( img);
vector<vector<Point>> contours;
Ptr<MSER> mserExtractor = MSER::create();
vector<vector<Point>> contours;
cvtColor( image, grey, CV_BGR2GRAY );
vector<cv::Rect> mserBbox;
mserExtractor->detectRegions(grey, contours, mserBbox);
```
| feature,category: features2d | low | Major |
156,268,509 | godot | [TRACKER] Scene Inheritance related issues | This is a tracker for issues related to Scene Inheritance.
```[tasklist]
- [x] #2223
- [x] #3897
- [x] #4759
- [x] #3904
- [x] #3945
- [x] #3395
- [x] #2946
- [x] #6106
- [x] #5798
- [x] #8103
- [x] #5997
- [x] #10147
- [x] #6212
- [ ] #7984
- [ ] https://github.com/godotengine/godot/issues/10156#issuecomment-320997658
- [x] #12373
- [x] #12990
- [x] #6169
- [x] #621
- [x] #4585
- [x] #13013
- [x] #481
``` | bug,enhancement,topic:core,topic:editor,tracker | low | Major |
156,300,769 | TypeScript | Suggestion: NODE_PATH support in module resolution | I'm working on a large project in which we'd like to use Typescript. We use disparate directories for our JS source, relying on our NODE_PATH environment var to pull them all together. However, Typescript does not use NODE_PATH in its module resolution.
I realize that our setup differs from the typical Node project, and may be considered an edge case. However, if I were to submit a pull request that added NODE_PATH support, would it be approved?
| Suggestion,Awaiting More Feedback | medium | Critical |
156,336,534 | go | x/mobile/exp/audio/al: Error when using `gomobile bind`: no current JVM | Please answer these questions before submitting your issue. Thanks!
## What version of Go are you using (`go version`)?
`go version go1.6.2 darwin/amd64`
## What operating system and processor architecture are you using (`go env`)?
```
GOARCH="amd64"
GOBIN=""
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
GOPATH="/Users/hajimehoshi/go"
GORACE=""
GOROOT="/usr/local/go"
GOTOOLDIR="/usr/local/go/pkg/tool/darwin_amd64"
GO15VENDOREXPERIMENT="1"
CC="clang"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fno-common"
CXX="clang++"
CGO_ENABLED="1"
```
## What did you do?
Calling `x/mobile/exp/audio/al` functions with `gomobile bind` causes error: `al: no current JVM`. It seems like `init` in `x/mobile/exp/audio/al` is called just before `setContext` in `x/mobile/bind/java/context_android.go` is called, which means `init` in `al` is called without the JVM context set.
## What did you expect to see?
No error.
| mobile | low | Critical |
156,405,518 | go | cmd/compile: loads/constants not lifted out of loop | ```
var t [256]byte
func f(b *[16]byte) {
for i, v := range b {
b[i] = t[v]
}
}
```
Compiles to:
```
0x000f 00015 (tmp1.go:7) MOVBLZX (AX), DX
0x0012 00018 (tmp1.go:7) LEAQ "".t(SB), BX
0x0019 00025 (tmp1.go:7) MOVBLZX (BX)(DX*1), DX
0x001d 00029 (tmp1.go:7) MOVQ "".b+8(FP), BX
0x0022 00034 (tmp1.go:7) MOVB DL, (BX)(CX*1)
0x0025 00037 (tmp1.go:6) INCQ AX
0x0028 00040 (tmp1.go:6) INCQ CX
0x002b 00043 (tmp1.go:6) CMPQ CX, $16
0x002f 00047 (tmp1.go:6) JLT $0, 15
```
Both the `LEAQ` and the `MOVQ "".b+8` could be done outside the loop.
| Performance,NeedsFix,compiler/runtime | medium | Critical |
156,408,076 | kubernetes | Client interfaces should not expose internal rest clients | https://github.com/kubernetes/kubernetes/pull/24220 added getters to expose internal RESTClient objects in Client interfaces. That tightly couples those interfaces to a particular implementation, which doesn't make sense (as evidenced by the fake clients returning nil, and anything calling those getters having to handle nils)
For example, this interface now couples all implementations to a RESTClient:
```
type CoreV1Interface interface {
RESTClient() rest.Interface
ComponentStatusesGetter
ConfigMapsGetter
EndpointsGetter
EventsGetter
LimitRangesGetter
NamespacesGetter
NodesGetter
PersistentVolumesGetter
PersistentVolumeClaimsGetter
PodsGetter
PodTemplatesGetter
ReplicationControllersGetter
ResourceQuotasGetter
SecretsGetter
ServicesGetter
ServiceAccountsGetter
}
```
cc @krousey @smarterclayton @gmarek
| kind/cleanup,sig/api-machinery,lifecycle/frozen | low | Major |
156,409,903 | go | cmd/compile: don't copy static array in range statement | ```
func f() {
for _, b := range [...]byte{1, 2, 3, 4, 5, 6, 7, 8, 9, 10} {
println(b)
}
}
```
The compiled code starts off with copying the static array to the stack, then using the stack copy to do the iteration. The static data is read-only, we could use the static data directly.
```
0x0013 00019 (tmp1.go:4) MOVQ "".statictmp_1(SB), AX
0x001a 00026 (tmp1.go:4) MOVQ "".statictmp_1+2(SB), CX
0x0021 00033 (tmp1.go:4) MOVQ AX, "".autotmp_3+30(SP)
0x0026 00038 (tmp1.go:4) MOVQ CX, "".autotmp_3+32(SP)
0x002b 00043 (tmp1.go:4) MOVQ $0, AX
0x002d 00045 (tmp1.go:4) LEAQ "".autotmp_3+30(SP), CX
...use CX to load the bytes...
```
| Performance,NeedsFix,early-in-cycle | low | Minor |
156,558,468 | rust | Weird integer inference failure | ``` rust
const K: u64 = 8;
const P0: [u64; 6] = [2, 3, 7, 9, 10, 14];
fn main() {
let mut ps = Vec::from(&P0 as &[_]);
// Fixup P0 if necessary.
for p in &mut ps {
if *p == K {
if *p == 2 || *p == 9 {
*p -= 1;
} else {
*p += 1;
}
}
}
println!("{:?}", ps);
}
```
fails to compile, despite compiler figuring out that `ps: Vec<u64>`, but explicit annotation of the vector type is necessary for integers to be inferred correctly:
```
…
// either works
let mut ps: Vec<u64> = Vec::from(&P0 as &[_]);
let mut ps = Vec::from(&P0 as &[u64]);
…
```
I would expect all the code snippets to be equivalent and compile.
| A-type-system,T-compiler,A-inference,C-bug,T-types | low | Critical |
156,572,625 | vscode | [css/less/scss] var should be a suggestion in intellisense | #6656
CSS
Sass
Less
| feature-request,css-less-scss | low | Major |
156,576,349 | vscode | [css] show all variable definitions for Go To definition | In this example, the variable has 3 definitions:
| feature-request,css-less-scss | low | Minor |
156,625,008 | vscode | Auto closing brackets should try to balance brackets | - VSCode Version: 1.1.0-alpha
- OS Version: Windows 10
Steps to Reproduce:
1. Open launch.json or create one
2. Delete the opening bracket { under configurations
3. Re-type the opening bracket
Auto-complete adds in a closing bracket when the closing bracket at the end of the config is showing an error. It would make sense that bracket auto-complete would know that there is an open bracket and to not add the closing bracket at the top.
| feature-request,editor-autoclosing | medium | Critical |
156,635,169 | flutter | Stack filter should collapse tree walks | This kind of thing:
```
I/flutter : #6 MultiChildRenderObjectElement.mount (package:flutter/src/widgets/framework.dart)
I/flutter : #7 Element.inflateWidget (package:flutter/src/widgets/framework.dart)
I/flutter : #8 Element.updateChild (package:flutter/src/widgets/framework.dart)
I/flutter : #9 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart)
I/flutter : #10 ComponentElement.mount (package:flutter/src/widgets/framework.dart)
I/flutter : #11 Element.inflateWidget (package:flutter/src/widgets/framework.dart)
I/flutter : #12 Element.updateChild (package:flutter/src/widgets/framework.dart)
I/flutter : #13 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart)
I/flutter : #14 StatefulElement._firstBuild (package:flutter/src/widgets/framework.dart)
I/flutter : #15 ComponentElement.mount (package:flutter/src/widgets/framework.dart)
I/flutter : #16 SingleChildRenderObjectElement.mount (package:flutter/src/widgets/framework.dart)
I/flutter : #17 Element.inflateWidget (package:flutter/src/widgets/framework.dart)
I/flutter : #18 Element.updateChild (package:flutter/src/widgets/framework.dart)
I/flutter : #19 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart)
I/flutter : #20 ComponentElement.mount (package:flutter/src/widgets/framework.dart)
I/flutter : #21 SingleChildRenderObjectElement.mount (package:flutter/src/widgets/framework.dart)
I/flutter : #22 SingleChildRenderObjectElement.mount (package:flutter/src/widgets/framework.dart)
I/flutter : #23 Element.inflateWidget (package:flutter/src/widgets/framework.dart)
I/flutter : #24 Element.updateChild (package:flutter/src/widgets/framework.dart)
I/flutter : #25 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart)
I/flutter : #26 ComponentElement.mount (package:flutter/src/widgets/framework.dart)
I/flutter : #27 SingleChildRenderObjectElement.mount (package:flutter/src/widgets/framework.dart)
I/flutter : #28 Element.inflateWidget (package:flutter/src/widgets/framework.dart)
I/flutter : #29 Element.updateChild (package:flutter/src/widgets/framework.dart)
I/flutter : #30 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart)
I/flutter : #31 ComponentElement.mount (package:flutter/src/widgets/framework.dart)
I/flutter : #32 Element.inflateWidget (package:flutter/src/widgets/framework.dart)
I/flutter : #33 Element.updateChild (package:flutter/src/widgets/framework.dart)
I/flutter : #34 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart)
I/flutter : #35 StatefulElement._firstBuild (package:flutter/src/widgets/framework.dart)
I/flutter : #36 ComponentElement.mount (package:flutter/src/widgets/framework.dart)
I/flutter : #37 Element.inflateWidget (package:flutter/src/widgets/framework.dart)
I/flutter : #38 Element.updateChild (package:flutter/src/widgets/framework.dart)
I/flutter : #39 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart)
I/flutter : #40 StatefulElement._firstBuild (package:flutter/src/widgets/framework.dart)
I/flutter : #41 ComponentElement.mount (package:flutter/src/widgets/framework.dart)
I/flutter : #42 SingleChildRenderObjectElement.mount (package:flutter/src/widgets/framework.dart)
I/flutter : #43 Element.inflateWidget (package:flutter/src/widgets/framework.dart)
I/flutter : #44 Element.updateChild (package:flutter/src/widgets/framework.dart)
I/flutter : #45 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart)
```
...isn't exactly redundant, but it'd be nice if we could output something cleaner and easier to understand. Right now we often end up with hundreds of stack frames with this kind of thing.
| c: new feature,framework,P3,team-framework,triaged-framework | low | Minor |
156,637,045 | flutter | RenderIntrinsicHeight should be more graceful when its child has an infinite intrinsic height | Specifically, it should complain that that's a violation of the intrinsic height protocol, and try to pin point which class messed up.
(ditto widths)
| c: new feature,c: crash,framework,a: error message,P3,team-framework,triaged-framework | low | Minor |
156,643,006 | youtube-dl | Randomly select an available IP address for --source-address (was: ipv6 selection) | I see there is an option --force-ipv6 to use ipv6, does it choose a random ipv6 ip from my range ?
Thanks!
| request | medium | Major |
156,652,564 | TypeScript | Some comments are removed | **TypeScript Version:**
1.7.5
**Code**
```
export function lex(source: string): Array<string>
{//validation and tokenization
}
```
``` ts
// A self-contained demonstration of the problem follows...
The comment after the beginning curly brace is discarded.
```
**Expected behavior:**
After being compiled the comment is not discarded.
**Actual behavior:**
The comment _is_ discarded.
| Bug,Help Wanted | low | Minor |
156,694,085 | nvm | Installing on Alpine Linux | Hi
First off, thanks for NVM - I use it frequently and see it being used everywhere and it's been great. To that end, I'd really like to use NVM on my current project which is basically a CI running via Docker - i'd like to be able to use Alpine Linux as the base image.
I can get NVM to install on Alpine by doing:
```
apk add bash
wget -qO- https://raw.githubusercontent.com/creationix/nvm/v0.31.1/install.sh | bash
```
Which is great. But then the resulting Node binary won't run and I believe from doing a little reading that this is likely to be because Alpine needs musl rather than GCC built binaries.
I tried using the `-s` flag in `nvm install` but that tells me it is not usable for Node > 1.
I see Alpine and other busybox-based distros gaining a lot of traction as they're so fast, perfect for containerised use - hence my interest.
So my question is...Do you think the above is correct and if so (or if similar), can I offer help in perhaps providing Alpine-compatible binaries? I can perhaps script a compilation of all the existing versions of Node source - though it'd take some time to run - then upload them somewhere e.g. S3.
If the above is of any interest, please let me know as I am keen to help wherever necessary.
Cheers
Neil
| installing node,feature requests | medium | Critical |
156,748,676 | TypeScript | DefinitionResponse selects full type range | When sending a `definition` request to the tsserver, the response contains a range selection of the whole type. For UX proposes it would be better to either select only the identifying portion, like a type name, or additional include such an identifying range.
See https://github.com/Microsoft/vscode/issues/6772 for some background.
| Suggestion,Help Wanted,API | low | Minor |
156,849,082 | opencv | Opencv3 / C-API: Undefined *VERSION* macros | ### Please state the information for your system
- OpenCV version: 3.1 and also dev version
- Host OS: Linux (Ubuntu 16.04-64 bits)
- Compiler & CMake: GCC 5.3.1 & CMake 3.5.1
### In which part of the OpenCV library you got the issue?
Opencv3 C-API doesn't defines CV_*_VERSION
### Expected behaviour
ALL CV_*_VERSION macros should be defined
### Actual behaviour
Compilation error:
```
main.c: In function ‘main’:
main.c:5:17: error: ‘CV_MAJOR_VERSION’ undeclared (first use in this function)
printf("%d\n",CV_MAJOR_VERSION);
```
### Code example to reproduce the issue / Steps to reproduce the issue
Please try to give a full example which will compile as is.
```
#include <stdio.h>
#include "opencv/cv.h"
int main()
{
printf("version %d\n", CV_MAJOR_VERSION);
)return 0;
}
```
Compilation line:
```
gcc -Wall main.c -o main -I/usr/local/include/opencv -I/usr/local/include -L/usr/local/lib -lopencv_imgproc -lopencv_core -lm
```
| wontfix | low | Critical |
156,852,942 | rust | "Unexpected end of macro invocation" error in nested macro has misleading span, doesn't specify which macro | The following code (based on a test case by @apoelstra):
``` rust
macro_rules! check_enum {
($e:ident, $($var:ident),*) => ({
$(assert_eq!(0 == $e::$var);)*
})
}
fn main() {
check_enum!(Foo, Bar, Baz);
}
```
generates this error message:
```
error: unexpected end of macro invocation
--> test.rs:9:25
9 |> check_enum!(Foo, Bar, Baz);
|> ^
```
The problem is that `assert_eq!` is expecting a comma. This is very hard to decipher though, because the span points to the outer macro invocation. (This may be related to #26615.) If a better span can't be found, it would be useful to at least include the name of the macro in the error message, e.g. "unepected end of `assert_eq!` invocation."
| C-enhancement,A-diagnostics,A-macros,T-compiler | low | Critical |
156,863,710 | TypeScript | Visual Studio 2015 provides inconsistent type info per request order | **TypeScript Version:**
1.8.30 with VS2015
@ahejlsberg @vladima @mhegazy
``` ts
// monad.ts
export abstract class Monad<T> {
private MONAD: T;
constructor(protected thunk?: () => Monad<T>) {
}
public abstract bind<U>(f: (val: T) => Monad<U>): Monad<U>;
public extract(): T
public extract<U>(transform: (val: any) => U): T | U
public extract<U>(transform?: (val: any) => U): T | U {
return this.evaluate().extract(transform);
}
protected memory_: this;
protected evaluate(): this {
return this.memory_ = this.memory_ || <this>this.thunk();
}
public assert<S extends Monad<T>>(type?: S): Monad<T> {
return this;
}
}
// maybe.impl.ts
import {Monad} from './monad';
export class Maybe<T> extends Monad<T> {
protected MAYBE: Just<T> | Nothing;
constructor(protected thunk?: () => Maybe<T>) {
super(thunk);
}
public bind<U>(f: (val: T) => Just<U> | Nothing): Maybe<U>
public bind<U>(f: (val: T) => Maybe<U>): Maybe<U>
public bind<U>(f: (val: T) => Maybe<U>): Maybe<U> {
return new Maybe<U>(() => {
const m: Maybe<T> = this.evaluate();
if (m instanceof Just) {
return f(m.extract());
}
if (m instanceof Nothing) {
return m;
}
if (m instanceof Maybe) {
return (<Maybe<T>>m).bind(f);
}
throw new TypeError(`ArchStream: Maybe: Invalid monad value.\n\t${m}`);
});
}
public extract(): T
public extract<U>(transform: () => U): T | U
public extract<U>(transform?: () => U): T | U {
return super.extract(transform);
}
public assert<S extends Maybe<T>>(type?: S): Maybe<T> {
return this;
}
}
export class Just<T> extends Maybe<T> {
protected MAYBE: Just<T>;
constructor(private val_: T) {
super();
}
public bind<U>(f: (val: T) => Just<U> | Nothing): Maybe<U>
public bind<U>(f: (val: T) => Maybe<U>): Maybe<U>
public bind<U>(f: (val: T) => Maybe<U>): Maybe<U> {
return new Maybe(() => this).bind(f);
}
public extract<U>(transform?: () => U): T {
return this.val_;
}
public assert<S extends Just<T>>(type?: S): Just<T> {
return this;
}
}
export class Nothing extends Maybe<any> {
protected MAYBE: Nothing;
public bind(f: (val: any) => Maybe<any>): Nothing {
return this;
}
public extract(): any
public extract<U>(transform: () => U): U
public extract<U>(transform?: () => U): U {
if (!transform) throw void 0;
return transform();
}
public assert<S extends Nothing>(type?: S): Nothing {
return this;
}
}
// maybe.ts
import {Maybe as Maybe_, Just as Just_, Nothing as Nothing_} from './maybe.impl';
export namespace Maybe {
export type Just<T> = Just_<T>;
export function Just<T>(val: T): Just<T> {
return new Just_(val);
}
export type Nothing = Nothing_;
export const Nothing = new Nothing_();
export const Return = Just;
}
export type Maybe<T> = Just<T> | Nothing | Maybe_<T>;
export type Just<T> = Maybe.Just<T>;
export const Just = Maybe.Just;
export type Nothing = Maybe.Nothing;
export const Nothing = Maybe.Nothing;
export const Return = Just;
// maybe.test.ts
it('Maybe', () => {
const result = Return(0)
.bind(n => Just(n) || Nothing || Just(n).bind(n => Just(n) || Nothing))
.bind(n => Just(n) || Nothing || Just(n).bind(n => Just(n) || Nothing))
.extract(() => 'Nothing');
assert(result === 0);
});
```
| Bug | low | Critical |
156,915,841 | TypeScript | TypeScript's ecosystem of self-bundled typings does not work with npm | When npm dependencies have same packages of different versions, tsc throws duplicate identifier errors. TypeScript's ecosystem of packages is weaker than npm, and does not have compatibility with npm. I believe this is a large problem. And this will be a popular problem because npm always install an exact version in resolving dependencies. For example, when depending `a@^0.0.2` and `a@^0.0.1` as another package's dependency, its project has `[email protected]` and `[email protected]`. npm can resolve these different versions, but TypeScript cannot.
**TypeScript Version:**
1.9.0-dev.20160526
| Suggestion,Needs Proposal | medium | Critical |
157,002,266 | go | runtime: pprof should report non-heap memory | pprof currently only reports heap-allocated memory. However, pprof is meant to help with debugging memory footprint and sometimes an application's memory footprint comes from non-heap sources, such as stacks or GC memory (the latter usually indicates a bug such as #15319, but it's currently hard to track down such bugs).
Hence, pprof should report the other sources of memory footprint somehow, such as showing them as isolated boxes or simply showing them in the info box. This information is already recorded in profiles, though it's in "comments".
| NeedsFix,FeatureRequest,compiler/runtime | medium | Critical |
157,059,546 | electron | CSS cursor not honored when element in header with titleBarStyle="hidden" | If you place an element with a css cursor style at the top of the page where the title bar would be with titleBarStyle="hidden", the cursor always displays as default. A simple example would be a link.
| platform/macOS,bug :beetle: | high | Critical |
157,076,492 | angular | [feat] Take advantage of passive event listeners | /ref https://github.com/WICG/EventListenerOptions
It's a way to declare that `preventDefault()` is not called by handler and make scrolling smoother.
Needs more investigation if support would be useful in Angular.
| feature,state: Needs Design,area: core,hotlist: google,core: event listeners,feature: under consideration | high | Critical |
157,091,195 | opencv | Wrong Documentation for cvtColor on HSV_FULL variants | Documentation says that RGB2HSV conversion gives the H channel between 0 and 180 and RGB2HSV_FULL gives H channel between 0 and 360. This confuses people because they think that for 8-bit images they need to convert to 16-bit or 32F before converting to HSV_FULL in order to to make room for the >255 values. I had to look at the code to discover that HSV_FULL variants produces H channel between 0 and 255 instead.
| feature,category: documentation | low | Minor |
157,114,203 | kubernetes | Speed up getting pod statuses in PLEG when there are many changes | Forked from https://github.com/kubernetes/kubernetes/issues/23591#issuecomment-203042820
Creating a new issue so I won't forget.
PLEG serially gets status for every pod, where at least one container has encountered a state transition. This becomes the bottleneck if a lot of containers changed in one relist period. We were aware of this problem and had come up with a few options before:
1. Add a new GetPodStatus variant to bypass the `docker ps -a` call since pleg already have this information. The downside is that this is a very docker-specific optimization and doesn't make sense for other runtimes.
2. Parallelize the process.
3. Do nothing. Assume docker is busy and process slowly.
I think we can do (2) with a small number of goroutines (e.g., 2) to speed up the time.
| priority/backlog,area/kubelet,sig/scalability,sig/node,kind/feature,lifecycle/frozen,needs-triage | low | Major |
157,178,495 | youtube-dl | problem with ESPN link | ## Please follow the guide below
- You will be asked some questions and requested to provide some information, please read them **carefully** and answer honestly
- Put an `x` into all the boxes [ ] relevant to your _issue_ (like that [x])
- Use _Preview_ tab to see how your issue will actually look like
---
### Make sure you are using the _latest_ version: run `youtube-dl --version` and ensure your version is _2016.05.21.2_. If it's not read [this FAQ entry](https://github.com/rg3/youtube-dl/blob/master/README.md#how-do-i-update-youtube-dl) and update. Issues with outdated version will be rejected.
- [x] I've **verified** and **I assure** that I'm running youtube-dl **2016.05.21.2**
### Before submitting an _issue_ make sure you have:
- [x] At least skimmed through [README](https://github.com/rg3/youtube-dl/blob/master/README.md) and **most notably** [FAQ](https://github.com/rg3/youtube-dl#faq) and [BUGS](https://github.com/rg3/youtube-dl#bugs) sections
- [x] [Searched](https://github.com/rg3/youtube-dl/search?type=Issues) the bugtracker for similar issues including closed ones
### What is the purpose of your _issue_?
- [x ] Bug report (encountered problems with youtube-dl)
- [ ] Site support request (request for adding support for a new site)
- [ ] Feature request (request for a new functionality)
- [ ] Question
- [ ] Other
---
### The following sections concretize particular purposed issues, you can erase any section (the contents between triple ---) not applicable to your _issue_
---
### If the purpose of this _issue_ is a _bug report_, _site support request_ or you are not completely sure provide the full verbose output as follows:
Add `-v` flag to **your command line** you run youtube-dl with, copy the **whole** output and insert it here. It should look similar to one below (replace it with **your** log inserted between triple ```):
```
$ youtube-dl -v <your command line>
[debug] System config: []
[debug] User config: []
[debug] Command-line args: ['--restrict-filenames', '-o', '%(title)s-%(id)s-%(uploader)s.%(ext)s', '-w', '-v']
[debug] Encodings: locale UTF-8, fs utf-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2016.05.21.2-gentoo_no_offensive_sites
[debug] Python version 3.4.3 - Linux-4.1.15-gentoo-r1-x86_64-Intel-R-_Core-TM-2_Quad_CPU_Q8400_@_2.66GHz-with-gentoo-2.2
[debug] exe versions: ffmpeg 2.8.6, ffprobe 2.8.6, rtmpdump 2.4
[debug] Proxy map: {}
...
<end of log>
```
---
### If the purpose of this _issue_ is a _site support request_ please provide all kinds of example URLs support for which should be included (replace following example URLs by **yours**):
- Single video: https://www.youtube.com/watch?v=BaW_jenozKc
- Single video: https://youtu.be/BaW_jenozKc
- Playlist: https://www.youtube.com/playlist?list=PL4lCao7KL_QFVb7Iudeipvc2BCavECqzc
---
```
Program said to report bug. :) I did check with --list-extractors, and it indicated that ESPN is supported.
$ youtube-dl --verbose 'http://espn.go.com/watchespn/player?id=2811559'
[debug] System config: []
[debug] User config: []
[debug] Command-line args: ['--restrict-filenames', '-o', '%(title)s-%(id)s-%(uploader)s.%(ext)s', '-w', '--verbose', 'http://espn.go.com/watchespn/player?id=2811559']
[debug] Encodings: locale UTF-8, fs utf-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2016.05.21.2-gentoo_no_offensive_sites
[debug] Python version 3.4.3 - Linux-4.1.15-gentoo-r1-x86_64-Intel-R-_Core-TM-2_Quad_CPU_Q8400_@_2.66GHz-with-gentoo-2.2
[debug] exe versions: ffmpeg 2.8.6, ffprobe 2.8.6, rtmpdump 2.4
[debug] Proxy map: {}
[ESPN] player?id=2811559: Downloading webpage
ERROR: Unable to extract video id; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see https://yt-dl.org/update on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
Traceback (most recent call last):
File "/usr/lib64/python3.4/site-packages/youtube_dl/YoutubeDL.py", line 676, in extract_info
ie_result = ie.extract(url)
File "/usr/lib64/python3.4/site-packages/youtube_dl/extractor/common.py", line 341, in extract
return self._real_extract(url)
File "/usr/lib64/python3.4/site-packages/youtube_dl/extractor/espn.py", line 57, in _real_extract
webpage, 'video id', group='id')
File "/usr/lib64/python3.4/site-packages/youtube_dl/extractor/common.py", line 644, in _search_regex
raise RegexNotFoundError('Unable to extract %s' % _name)
youtube_dl.utils.RegexNotFoundError: Unable to extract video id; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see https://yt-dl.org/update on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
```
| account-needed | low | Critical |
157,245,160 | go | runtime: unexpected fault address 0xffffffffffffffff (and other more innocent addresses) | After updating the go version from 1.5.1 to 1.6.2 our application crashed right after startup in production.
We run it with start-stop-daemon and use the '-u' flag to change the user. This is relevant because changing this to sudo-ing the start-stop-daemon to the user instead of using the flag the crash vanished. We figured this out trough experimentation.
```
# this crashes
start-stop-daemon -u user --start golang-cool-api-v2000
```
```
# this doesn't crash
sudo -u user start-stop-daemon --start golang-cool-api-v2000
```
1. What version of Go are you using (`go version`)?
1.6.2
2. What operating system and processor architecture are you using (`go env`)?
Linux 3.2.12-gentoo 64bit
3. What did you do?
Update to golang 1.6.2 from 1.5.1
4. What did you expect to see?
No difference :)
5. What did you see instead?
```
unexpected fault address 0xffffffffffffffff
fatal error: fault
[signal 0xb code=0x1 addr=0xffffffffffffffff pc=0xffffffffffffffff]
goroutine 19 [running]:
runtime.throw(0x9a3280, 0x5)
/usr/local/go/src/runtime/panic.go:547 +0x90 fp=0xc82002aed8 sp=0xc82002aec0
runtime.sigpanic()
/usr/local/go/src/runtime/sigpanic_unix.go:27 +0x2ab fp=0xc82002af28 sp=0xc82002aed8
runtime.call32(0x0, 0xc820109d20, 0xc820bea000, 0x1000000010)
/usr/local/go/src/runtime/asm_amd64.s:472 +0x3e fp=0xc82002af50 sp=0xc82002af28
runtime.runfinq()
/usr/local/go/src/runtime/mfinal.go:200 +0x299 fp=0xc82002afc0 sp=0xc82002af50
runtime.goexit()
/usr/local/go/src/runtime/asm_amd64.s:1998 +0x1 fp=0xc82002afc8 sp=0xc82002afc0
created by runtime.createfing
/usr/local/go/src/runtime/mfinal.go:139 +0x60
```
the address isn't the same between crashes
```
unexpected fault address 0xc8206fdd4a
fatal error: fault
[signal 0xb code=0x2 addr=0xc8206fdd4a pc=0xc8206fdd4a]
goroutine 18 [running]:
runtime.throw(0x9a3280, 0x5)
/usr/local/go/src/runtime/panic.go:547 +0x90 fp=0xc82002e6d8 sp=0xc82002e6c0
runtime.sigpanic()
/usr/local/go/src/runtime/sigpanic_unix.go:27 +0x2ab fp=0xc82002e728 sp=0xc82002e6d8
runtime.call32(0x0, 0xc820c4a040, 0xc820c5c000, 0x1000000010)
/usr/local/go/src/runtime/asm_amd64.s:472 +0x3e fp=0xc82002e750 sp=0xc82002e728
runtime.runfinq()
/usr/local/go/src/runtime/mfinal.go:200 +0x299 fp=0xc82002e7c0 sp=0xc82002e750
runtime.goexit()
/usr/local/go/src/runtime/asm_amd64.s:1998 +0x1 fp=0xc82002e7c8 sp=0xc82002e7c0
created by runtime.createfing
/usr/local/go/src/runtime/mfinal.go:139 +0x60
```
This stacktrace doesn't contain any relevant information for me. All the stackframes of the other goroutines don't seem the same between crashes.
It might be relevant (given the mfina.go in the stack) that this happened two times after the 9th gc and once after the 7th gc (GODEBUG="gctrace=2" is set)
| compiler/runtime | low | Critical |
157,259,075 | go | cmd/link: GOARM=7 output has no ARM attribute section, confusing readelf | Please answer these questions before submitting your issue. Thanks!
#1. What version of Go are you using (`go version`)?
Go 1.6
#2. What operating system and processor architecture are you using (`go env`)?
GOOS=android \
GOARCH=arm \
CC=$GOMOBILE/android-ndk-r10e/arm/bin/arm-linux-androideabi-gcc \
CXX=$GOMOBILE/android-ndk-r10e/arm/bin/arm-linux-androideabi-g++ \
CGO_ENABLED=1 \
GOARM=7 \
go build -p=4 -pkgdir=$GOMOBILE/pkg_android_arm -tags="" -v -x -i -gcflags=-shared -ldflags=-shared \
-buildmode=c-shared
1. What did you do?
If possible, provide a recipe for reproducing the error.
A complete runnable program is good.
# A link on play.golang.org is best.
Any gomobile build or bind can reproduce it.
#4. What did you expect to see?
when use “arm-linux-androideabi-readelf -A xxx.so” cmd, I hope something like this
Attribute Section: aeabi
File Attributes
Tag_CPU_name: "**ARM v7**"
Tag_CPU_arch: **v7**
Tag_CPU_arch_profile: Application
Tag_ARM_ISA_use: Yes
Tag_THUMB_ISA_use: Thumb-2
Tag_FP_arch: VFPv3-D16
Tag_ABI_PCS_wchar_t: 4
Tag_ABI_FP_denormal: Needed
Tag_ABI_FP_exceptions: Needed
Tag_ABI_FP_number_model: IEEE 754
Tag_ABI_align_needed: 8-byte
Tag_ABI_enum_size: int
Tag_ABI_HardFP_use: SP and DP
Tag_ABI_optimization_goals: Aggressive Speed
Tag_CPU_unaligned_access: v6
Tag_DIV_use: Not allowed
#5. What did you see instead?
But output like this：
Attribute Section: aeabi
File Attributes
Tag_CPU_name: "**5TE**"
Tag_CPU_arch: **v5TE**
Tag_ARM_ISA_use: Yes
Tag_THUMB_ISA_use: Thumb-1
Tag_FP_arch: VFPv2
Tag_ABI_PCS_wchar_t: 4
Tag_ABI_FP_denormal: Needed
Tag_ABI_FP_exceptions: Needed
Tag_ABI_FP_number_model: IEEE 754
Tag_ABI_align_needed: 8-byte
Tag_ABI_enum_size: int
Tag_ABI_optimization_goals: Aggressive Speed
which much like a **armv5te** so file...
| NeedsFix,compiler/runtime | low | Critical |
157,262,015 | youtube-dl | Site Request: Deadspin.com | ## Please follow the guide below
- You will be asked some questions and requested to provide some information, please read them **carefully** and answer honestly
- Put an `x` into all the boxes [ ] relevant to your _issue_ (like that [x])
- Use _Preview_ tab to see how your issue will actually look like
---
### Make sure you are using the _latest_ version: run `youtube-dl --version` and ensure your version is _2016.05.21.2_. If it's not read [this FAQ entry](https://github.com/rg3/youtube-dl/blob/master/README.md#how-do-i-update-youtube-dl) and update. Issues with outdated version will be rejected.
- [X ] I've **verified** and **I assure** that I'm running youtube-dl **2016.05.21.2**
### Before submitting an _issue_ make sure you have:
- [X ] At least skimmed through [README](https://github.com/rg3/youtube-dl/blob/master/README.md) and **most notably** [FAQ](https://github.com/rg3/youtube-dl#faq) and [BUGS](https://github.com/rg3/youtube-dl#bugs) sections
- [X ] [Searched](https://github.com/rg3/youtube-dl/search?type=Issues) the bugtracker for similar issues including closed ones
### What is the purpose of your _issue_?
- [ ] Bug report (encountered problems with youtube-dl)
- [X ] Site support request (request for adding support for a new site)
- [ ] Feature request (request for a new functionality)
- [ ] Question
- [ ] Other
---
---
### If the purpose of this _issue_ is a _site support request_ please provide all kinds of example URLs support for which should be included (replace following example URLs by **yours**):
- http://fittish.deadspin.com/pro-cyclist-crashes-spectacularly-into-snowbank-costs-1779152408
- http://theconcourse.deadspin.com/bear-catches-belly-rays-1779158981
- http://deadspin.com/russell-westbrook-tells-us-how-he-really-feels-about-st-1779124655
- Playlist: n/a
---
Thanks
Ringo
| site-support-request | low | Critical |
157,320,873 | rust | Unable to achieve aligned writes | I am trying to implement an efficient memory move operation for a specific usage pattern: https://play.rust-lang.org/?gist=6ddd4e11d7f7b0f6503ddd398f0e665f&version=nightly&backtrace=1
In release mode, the loop in move_items() in the above example is compiled into a series of unaligned reads followed by unaligned writes, despite my efforts to have the writes aligned.
| A-LLVM,I-slow,C-enhancement,T-compiler | low | Major |
157,335,965 | youtube-dl | Unable to download gameinformer.com's video due to its SSL error. | $ youtube-dl -v http://www.gameinformer.com/b/features/archive/2016/05/27/replay-the-matrix-path-of-neo.aspx
[debug] System config: []
[debug] User config: []
[debug] Command-line args: ['-v', 'http://www.gameinformer.com/b/features/archive/2016/05/27/replay-the-matrix-path-of-neo.aspx']
[debug] Encodings: locale UTF-8, fs utf-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2016.05.21.2
[debug] Python version 3.4.2 - Linux-3.16.0-4-amd64-x86_64-with-debian-8.4
[debug] exe versions: ffmpeg 2.8.6-1, ffprobe 2.8.6-1, rtmpdump 2.4
[debug] Proxy map: {}
[GameInformer] replay-the-matrix-path-of-neo: Downloading webpage
[brightcove:new] 4915937021001: Downloading webpage
[brightcove:new] 4915937021001: Downloading JSON metadata
[brightcove:new] 4915937021001: Downloading m3u8 information
[brightcove:new] 4915937021001: Downloading m3u8 information
[debug] Invoking downloader on 'https://secure.brightcove.com/services/mobile/streaming/index/rendition.m3u8?assetId=4916032574001&secure=true&pubId=694940074001&videoId=4915937021001'
[hlsnative] Downloading m3u8 manifest
[hlsnative] Total fragments: 394
[download] Destination: Replay - The Matrix - Path of Neo-4915937021001.mp4
ERROR: unable to download video data: <urlopen error [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed (_ssl.c:600)>
Traceback (most recent call last):
File "/usr/lib/python3.4/urllib/request.py", line 1174, in do_open
h.request(req.get_method(), req.selector, req.data, headers)
File "/usr/lib/python3.4/http/client.py", line 1090, in request
self._send_request(method, url, body, headers)
File "/usr/lib/python3.4/http/client.py", line 1128, in _send_request
self.endheaders(body)
File "/usr/lib/python3.4/http/client.py", line 1086, in endheaders
self._send_output(message_body)
File "/usr/lib/python3.4/http/client.py", line 924, in _send_output
self.send(msg)
File "/usr/lib/python3.4/http/client.py", line 859, in send
self.connect()
File "/usr/lib/python3.4/http/client.py", line 1230, in connect
server_hostname=sni_hostname)
File "/usr/lib/python3.4/ssl.py", line 364, in wrap_socket
_context=self)
File "/usr/lib/python3.4/ssl.py", line 577, in __init__
self.do_handshake()
File "/usr/lib/python3.4/ssl.py", line 804, in do_handshake
self._sslobj.do_handshake()
ssl.SSLError: [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed (_ssl.c:600)
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/home/ant/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 1644, in process_info
success = dl(filename, info_dict)
File "/home/ant/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 1586, in dl
return fd.download(name, info)
File "/home/ant/bin/youtube-dl/youtube_dl/downloader/common.py", line 350, in download
return self.real_download(filename, info_dict)
File "/home/ant/bin/youtube-dl/youtube_dl/downloader/hls.py", line 77, in real_download
success = ctx['dl'].download(frag_filename, {'url': frag_url})
File "/home/ant/bin/youtube-dl/youtube_dl/downloader/common.py", line 350, in download
return self.real_download(filename, info_dict)
File "/home/ant/bin/youtube-dl/youtube_dl/downloader/http.py", line 58, in real_download
data = self.ydl.urlopen(request)
File "/home/ant/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 1946, in urlopen
return self._opener.open(req, timeout=self._socket_timeout)
File "/usr/lib/python3.4/urllib/request.py", line 455, in open
response = self._open(req, data)
File "/usr/lib/python3.4/urllib/request.py", line 473, in _open
'_open', req)
File "/usr/lib/python3.4/urllib/request.py", line 433, in _call_chain
result = func(_args)
File "/home/ant/bin/youtube-dl/youtube_dl/utils.py", line 939, in https_open
req, *_kwargs)
File "/usr/lib/python3.4/urllib/request.py", line 1176, in do_open
raise URLError(err)
urllib.error.URLError: <urlopen error [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed (_ssl.c:600)>
| cant-reproduce | low | Critical |
157,353,800 | opencv | Make python binding generator more generic | The current python binding generator gen2.py makes a great job for creating python bindings of the core opencv library. Unfortunately it fails to help in the creation of third party library python bindings that link to the python opencv library. An example of a such a third party library that would benifit from a python binding is http://opencvblobslib.github.io/opencvblobslib/ .
There are two issues involved:
- 1. The python binding generator does not create .h files that a third party library can use. E.g. lets say that we have a library Foo wrapped into the python module PyFoo. We also have a library Bar with a python module PyBar(). For PyBar to access PyFoo, we need an h-file similar to the below. This allows a third party both to receive and decompose python objects as well as constructing new ones as return values.
```
#ifndef PYFOO_H
#define PYFOO_H
#include <Python.h>
#include <Foo.h>
PyObject *PyFoo_FromFoo(Foo foo);
typedef struct {
PyObject_HEAD;
Foo *foo;
} PyFoo;
#define PyFoo_Check(op) \
PyObject_TypeCheck(op, &PyFooType)
extern PyTypeObject PyFooType;
#endif
```
(This corresponds to the `pyopencv_from()` and `pyopencv_to()` functions that need to be made visible in the h-files. I'm not sure that I like the idea of having public API that rely on template instantiated functions. Why not just create a mangled name that contains the type of the from and to?)
- 2. Make `gen2.py` able to generate modules with a user chosen module name. This involved adding command line parameters for lots of hardwired module names in gen2.
| feature,category: python bindings | low | Minor |
157,374,322 | youtube-dl | [Podbay.fm] Support show pages | Successfully used youtube-dl on podbay.fm to download .mp3s.
example show link: http://podbay.fm/show/507135865
example mp3 link: http://podbay.fm/show/507135865/e/1463976000?autostart=1
`[debug] System config: []
[debug] User config: []
[debug] Command-line args: [u'-v']
[debug] Encodings: locale UTF-8, fs UTF-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2016.02.22
[debug] Python version 2.7.11+ - Linux-4.4.0-22-generic-x86_64-with-Ubuntu-16.04-xenial
[debug] exe versions: avconv 2.8.6-1ubuntu2, avprobe 2.8.6-1ubuntu2, ffmpeg 2.8.6-1ubuntu2, ffprobe 2.8.6-1ubuntu2, rtmpdump 2.4
[debug] Proxy map: {}`
| site-support-request | low | Critical |
157,393,042 | youtube-dl | Problem with original.livestream | ## Please follow the guide below
- You will be asked some questions and requested to provide some information, please read them **carefully** and answer honestly
- Put an `x` into all the boxes [ ] relevant to your _issue_ (like that [x])
- Use _Preview_ tab to see how your issue will actually look like
---
### Make sure you are using the _latest_ version: run `youtube-dl --version` and ensure your version is _2016.05.21.2_. If it's not read [this FAQ entry](https://github.com/rg3/youtube-dl/blob/master/README.md#how-do-i-update-youtube-dl) and update. Issues with outdated version will be rejected.
- [X] I've **verified** and **I assure** that I'm running youtube-dl **2016.05.21.2**
### Before submitting an _issue_ make sure you have:
- [X] At least skimmed through [README](https://github.com/rg3/youtube-dl/blob/master/README.md) and **most notably** [FAQ](https://github.com/rg3/youtube-dl#faq) and [BUGS](https://github.com/rg3/youtube-dl#bugs) sections
- [X] [Searched](https://github.com/rg3/youtube-dl/search?type=Issues) the bugtracker for similar issues including closed ones
### What is the purpose of your _issue_?
- [X] Bug report (encountered problems with youtube-dl)
- [ ] Site support request (request for adding support for a new site)
- [ ] Feature request (request for a new functionality)
- [ ] Question
- [ ] Other
---
### The following sections concretize particular purposed issues, you can erase any section (the contents between triple ---) not applicable to your _issue_
---
### If the purpose of this _issue_ is a _bug report_, _site support request_ or you are not completely sure provide the full verbose output as follows:
Add `-v` flag to **your command line** you run youtube-dl with, copy the **whole** output and insert it here. It should look similar to one below (replace it with **your** log inserted between triple ```):
```
C:\YT\ffmpeg\bin>C:\YT\ffmpeg\bin\youtube-dl.exe http://original.livestream.com/alcatrazindiretta/video?clipId=pla_7611df9c-a62e-40fa-b38d-ceb93348314a -v
[debug] System config: []
[debug] User config: []
[debug] Command-line args: [u'http://original.livestream.com/alcatrazindiretta/video?clipId=pla_7611df9c-a62e-40fa-b38d-ceb93348314a', u'-v']
[debug] Encodings: locale cp1252, fs mbcs, out cp850, pref cp1252
[debug] youtube-dl version 2016.05.21.2
[debug] Python version 2.7.10 - Windows-8-6.2.9200
[debug] exe versions: ffmpeg N-80117-gdac030d, ffprobe N-80117-gdac030d
[debug] Proxy map: {}
[livestream:original] pla_7611df9c-a62e-40fa-b38d-ceb93348314a: Downloading XML
[livestream:original] pla_7611df9c-a62e-40fa-b38d-ceb93348314a: Downloading JSON metadata
[livestream:original] pla_7611df9c-a62e-40fa-b38d-ceb93348314a: Downloading m3u8 information
[debug] Invoking downloader on u'http://mobilestr3.livestream.com/onDemand/ls/alcatrazindiretta/flv_1c33d320-ccfc-4ebe-90b7-6435ffa51875/chunklist.m3u8?wowzasessionid=1428253220'
[download] 010516-pla_7611df9c-a62e-40fa-b38d-ceb93348314a.mp4 has already been downloaded
[download] 100% of 0.00B
[ffmpeg] Fixing malformated aac bitstream in "010516-pla_7611df9c-a62e-40fa-b38d-ceb93348314a.mp4"
[debug] ffmpeg command line: ffmpeg -y -i file:010516-pla_7611df9c-a62e-40fa-b38d-ceb93348314a.mp4 -c copy -f mp4 -bsf:a aac_adtstoasc file:010516-pla_7611df9c-a62e-40fa-b38d-ceb93348314a.temp.mp4
ERROR: file:010516-pla_7611df9c-a62e-40fa-b38d-ceb93348314a.mp4: Invalid data found when processing input
Traceback (most recent call last):
File "youtube_dl\YoutubeDL.pyo", line 1782, in post_process
File "youtube_dl\postprocessor\ffmpeg.pyo", line 511, in run
File "youtube_dl\postprocessor\ffmpeg.pyo", line 172, in run_ffmpeg
File "youtube_dl\postprocessor\ffmpeg.pyo", line 168, in run_ffmpeg_multiple_files
FFmpegPostProcessorError
C:\YT\ffmpeg\bin>
```
---
### _Problem with original.livestream_
Hi!
I'm not a programmator and I do not speak english well, so maybe it's a problem with the installation. Anyway, I can download videos from Youtube but not from original.livestream.
Thank you
| bug | low | Critical |
157,405,999 | youtube-dl | [REQUEST] A personalized stdout of progress | ## Please follow the guide below
- You will be asked some questions and requested to provide some information, please read them **carefully** and answer honestly
- Put an `x` into all the boxes [ ] relevant to your _issue_ (like that [x])
- Use _Preview_ tab to see how your issue will actually look like
---
### Make sure you are using the _latest_ version: run `youtube-dl --version` and ensure your version is _2016.05.30.2_. If it's not read [this FAQ entry](https://github.com/rg3/youtube-dl/blob/master/README.md#how-do-i-update-youtube-dl) and update. Issues with outdated version will be rejected.
- [x] I've **verified** and **I assure** that I'm running youtube-dl **2016.05.30.2**
### Before submitting an _issue_ make sure you have:
- [x] At least skimmed through [README](https://github.com/rg3/youtube-dl/blob/master/README.md) and **most notably** [FAQ](https://github.com/rg3/youtube-dl#faq) and [BUGS](https://github.com/rg3/youtube-dl#bugs) sections
- [x] [Searched](https://github.com/rg3/youtube-dl/search?type=Issues) the bugtracker for similar issues including closed ones
### What is the purpose of your _issue_?
- [ ] Bug report (encountered problems with youtube-dl)
- [ ] Site support request (request for adding support for a new site)
- [x] Feature request (request for a new functionality)
- [ ] Question
- [ ] Other
---
### The following sections concretize particular purposed issues, you can erase any section (the contents between triple ---) not applicable to your _issue_
---
### If the purpose of this _issue_ is a _bug report_, _site support request_ or you are not completely sure provide the full verbose output as follows:
Add `-v` flag to **your command line** you run youtube-dl with, copy the **whole** output and insert it here. It should look similar to one below (replace it with **your** log inserted between triple ```):
```
$ youtube-dl -v <your command line>
[debug] System config: []
[debug] User config: []
[debug] Command-line args: [u'-v', u'http://www.youtube.com/watch?v=BaW_jenozKcj']
[debug] Encodings: locale cp1251, fs mbcs, out cp866, pref cp1251
[debug] youtube-dl version 2016.05.30.2
[debug] Python version 2.7.11 - Windows-2003Server-5.2.3790-SP2
[debug] exe versions: ffmpeg N-75573-g1d0487f, ffprobe N-75573-g1d0487f, rtmpdump 2.4
[debug] Proxy map: {}
...
<end of log>
```
---
### If the purpose of this _issue_ is a _site support request_ please provide all kinds of example URLs support for which should be included (replace following example URLs by **yours**):
- Single video: https://www.youtube.com/watch?v=BaW_jenozKc
- Single video: https://youtu.be/BaW_jenozKc
- Playlist: https://www.youtube.com/playlist?list=PL4lCao7KL_QFVb7Iudeipvc2BCavECqzc
---
### Description of your _issue_, suggested solution and other information
Explanation of your _issue_ in arbitrary form goes here. Please make sure the [description is worded well enough to be understood](https://github.com/rg3/youtube-dl#is-the-description-of-the-issue-itself-sufficient). Provide as much context and examples as possible.
If work on your _issue_ required an account credentials please provide them or explain how one can obtain them.
Hi I'm using the youtube-dl as part of an other process and I searched if the command line has any option to print the output progress at a diserd format but, there's no one. So I'm wondering if it would be possible to add an option to choose a desired output format of process for get the % of downloaded, totalsize, downloading current speed, etc into personalized form to pass to any external program for parse just like making string.split(" ") to choose the desired column.
Thanks in advance
| request | low | Critical |
Subsets and Splits
No saved queries yet
Save your SQL queries to embed, download, and access them later. Queries will appear here once saved.