id
int64 393k
2.82B
| repo
stringclasses 68
values | title
stringlengths 1
936
| body
stringlengths 0
256k
β | labels
stringlengths 2
508
| priority
stringclasses 3
values | severity
stringclasses 3
values |
---|---|---|---|---|---|---|
621,152,787 |
rust
|
align_to prefix max length not taken into account in optimization
|
<!--
Thank you for filing a bug report! π Please provide a short summary of the bug,
along with any information you feel relevant to replicating the bug.
-->
I tried this code:
```rust
pub fn count_non_ascii_sse2(buffer: &[u8]) -> u64 {
let mut count = 0;
let (prefix, simd, suffix) = unsafe { buffer.align_to::<core::arch::x86_64::__m128i>() };
for &b in prefix {
if b >= 0x80 {
count += 1;
}
}
for &s in simd {
count += unsafe {core::arch::x86_64::_mm_movemask_epi8(s)}.count_ones() as u64;
}
for &b in suffix {
if b >= 0x80 {
count += 1;
}
}
count
}
```
[Godbolt link](https://rust.godbolt.org/z/-ckzGe)
I expected to see this happen: I expected the compiler to conclude that `prefix.len() < 16` and, therefore, not emit autovectorization for the first scalar loop.
Instead, this happened: The compiler emitted an autovectorization for the first scalar loop even though the prefix is never long enough for the autovectorization to be useful.
### Meta
<!--
If you're using the stable version of the compiler, you should also check if the
bug also exists in the beta or nightly versions.
-->
`rustc --version --verbose`:
```
rustc 1.45.0-nightly (a74d1862d 2020-05-14)
```
|
A-LLVM,I-slow,T-compiler,A-SIMD,C-bug,A-autovectorization
|
low
|
Critical
|
621,166,621 |
PowerToys
|
Please allow individual tools to be installed
|
# Please allow individual tools to be installed
The PowerToys are great - but not always all at once.
Therefore: please allow us to select which Toys should be installed.
# Proposed technical implementation details (optional)
It would be great if the individual Toys could be installed by using Winget, for example:
- This installs all Toys:
`WinGet install powertoys`
- This installs just the Shortcut Guide:
`WinGet install powertoys-ShortcutGuide`
Thanks a lot, kind regards,
Thomas
|
Idea-Enhancement,Area-Setup/Install,Area-Enterprise
|
high
|
Critical
|
621,169,731 |
PowerToys
|
File Explorer (Preview Panes) - Open document format
|
# Summary of the new feature/enhancement
Currently to preview open document formats (ODF) like .odt you need certain 3rd party software installed. The PowerToys preview pane should render (at least basic text) a scrollable/first page representation of the document.
|
Idea-Enhancement,Product-File Explorer
|
low
|
Minor
|
621,180,327 |
flutter
|
Make keyboard events easier to use on Android PlatformViews
|
https://github.com/flutter/flutter/issues/55046 reported that the keyboard doesn't work for Android EditText's inside of PlatformViews. After researching the problem we found that things like `webview_flutter` use a complex setup of `InputConnection`'s in order to make keyboard access work. So, it isn't a problem of being impossible, but it is unacceptably difficult to implement. The workaround is detailed in the issue.
We should find a way to take the `InputConnection` manipulation and push it higher so it lives in PlatformView's code so no one has to apply this workaround. Additionally we might need to provide a more convenient way to use the workaround for plugins who don't want to accept the dependency on the latest engine.
Relevant code:
- [ThreadedInputConnectionProxyAdapterView](https://github.com/flutter/plugins/blob/8e17ab64d40136b6b097eac3ba25425d10a0291b/packages/webview_flutter/android/src/main/java/io/flutter/plugins/webviewflutter/ThreadedInputConnectionProxyAdapterView.java#L27) the class that swaps out the "InputConnection" for the one provided to the plugin, for the PlatformView's view in `webview_flutter`
- [InputAwareWebView](https://github.com/flutter/plugins/blob/dacab3a353c721c5d61c017bab926a1292746f15/packages/webview_flutter/android/src/main/java/io/flutter/plugins/webviewflutter/InputAwareWebView.java#L111) where the proxy used to hook up the keyboard input to the WebView.
cc @letsar @mklim
|
platform-android,framework,engine,a: quality,a: platform-views,c: proposal,P3,team-android,triaged-android
|
low
|
Major
|
621,184,686 |
flutter
|
Feature request: Ability to hide cursor pointer (Android)
|
<!-- Thank you for using Flutter!
If you are looking for support, please check out our documentation
or consider asking a question on Stack Overflow:
* https://flutter.dev/
* https://api.flutter.dev/
* https://stackoverflow.com/questions/tagged/flutter?sort=frequent
If you have found a bug or if our documentation doesn't have an answer
to what you're looking for, then fill our the template below. Please read
our guide to filing a bug first: https://flutter.dev/docs/resources/bug-reports
-->
## Use case
It's **only for Android**
Messaging app:
Usual native apps (Telegram, Slack) that have "edit message" feature have 3 first points but flutter app will have all 4
Edit your message:
1) TextField has an initial value
2) TextField is focused and the keyboard is open
3) There is a blinking cursor
4) There is cursor pointer (not desired)
## Proposal
Have the ability to hide cursor pointer programmatically but only for one time so if user tap on the text cursor pointer will appear as Usual
Thanks!
Ps For more info you can view my question on [StackOverflow](https://stackoverflow.com/questions/61889124/flutter-how-to-hide-textfield-text-pointer-cursor-when-use-initial-value-text)
|
a: text input,c: new feature,framework,c: proposal,P3,team-framework,triaged-framework
|
low
|
Critical
|
621,208,238 |
TypeScript
|
Polymorphic TypedArray methods return wrong type in subclasses
|
<!-- π¨ STOP π¨ π¦π§π’π£ π¨ πΊπ»πΆπ· π¨
Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Even if you think you've found a *bug*, please read the FAQ first, especially the Common "Bugs" That Aren't Bugs section!
Please help us by doing the following steps before logging an issue:
* Search: https://github.com/Microsoft/TypeScript/search?type=Issues
* Read the FAQ: https://github.com/Microsoft/TypeScript/wiki/FAQ
Please fill in the *entire* template below.
-->
<!--
Please try to reproduce the issue with the latest published version. It may have already been fixed.
For npm: `typescript@next`
This is also the 'Nightly' version in the playground: http://www.typescriptlang.org/play/?ts=Nightly
-->
**TypeScript Version:** 4.0.0-dev.20200519
<!-- Search terms you tried before logging this (so others can find this issue more easily) -->
**Search Terms:**
typedarray subarray polymorphic
**Code**
```ts
class Buf extends Uint8Array {
foo() {}
}
new Buf(10).subarray().foo()
```
**Expected behavior:**
No error.
**Actual behavior:**
error TS2339: Property 'foo' does not exist on type 'Uint8Array'.
**Playground Link:** [Playground Link](https://www.typescriptlang.org/play/?ts=4.0.0-dev.20200518&ssl=1&ssc=1&pln=25&pc=26#code/MYGwhgzhAEBCCuAzaBTAHgFxQOwCYwFUBLbDADgEEAnKsAT2gG8BYAKGmkQHsuAKASiYBfNiNZtsKAO5wkvAIwAGfgDoI8AEZga9ASu59+QA)
**Related Issues:** <!-- Did you find other bugs that looked similar? -->
|
Bug,Domain: lib.d.ts
|
low
|
Critical
|
621,211,408 |
terminal
|
Split panes equally in size
|
<!--
π¨π¨π¨π¨π¨π¨π¨π¨π¨π¨
I ACKNOWLEDGE THE FOLLOWING BEFORE PROCEEDING:
1. If I delete this entire template and go my own path, the core team may close my issue without further explanation or engagement.
2. If I list multiple bugs/concerns in this one issue, the core team may close my issue without further explanation or engagement.
3. If I write an issue that has many duplicates, the core team may close my issue without further explanation or engagement (and without necessarily spending time to find the exact duplicate ID number).
4. If I leave the title incomplete when filing the issue, the core team may close my issue without further explanation or engagement.
5. If I file something completely blank in the body, the core team may close my issue without further explanation or engagement.
All good? Then proceed!
-->
# Description of the new feature/enhancement
<!--
A clear and concise description of what the problem is that the new feature would solve.
Describe why and how a user would use this new functionality (if applicable).
-->
When splitting twice into three panes, I would like the option to split by parent equally.
Instead of:
```
+-------+---+---+
| | | |
+-------+---+---+
```
Ideally it would be like this:
```
+----+----+----+
| | | |
+----+----+----+
```
Coming from iTerm this makes much more sense to me.
When splitting vertically within a horizontal pane, it would work in the same fashion.
This could be a new shortcut that when splitting, e.g. "split horizontally and keep parent" where all children are resized when a new child is added or removed. (I don't how how it currently works internally, so I'm guessing here.)
|
Issue-Feature,Area-UserInterface,Product-Terminal
|
medium
|
Critical
|
621,212,448 |
PowerToys
|
Key remapper doesn't recognize Office key
|
<!--
**Important: When reporting BSODs or security issues, DO NOT attach memory dumps, logs, or traces to Github issues**.
Instead, send dumps/traces to [email protected], referencing this GitHub issue.
-->
# Environment
```
Windows build number: 10.0.19041.264
PowerToys version: 0.18
PowerToy module for which you are reporting the bug (if applicable): Remap Keyboard
```
# Steps to reproduce
Try to add a key mapping for the Office key (on the new Ergonomic 4000 keyboard). The key isn't detected correctly
# Expected behavior
I expect the Office key to be detected correctly so I can remap it.
# Actual behavior
It's either detected as `Space` or `Win (Left)`
<!-- What's actually happening? -->
# Screenshots
<!-- If applicable, add screenshots to help explain your problem. -->
|
Product-Keyboard Shortcut Manager
|
medium
|
Critical
|
621,212,792 |
rust
|
`unsafe` blocks do not apply to array length expressions they contain
|
The [following example](https://play.rust-lang.org/?version=nightly&mode=debug&edition=2018&gist=53cd554bc1f6829ebeb6b37a58375f40) fails to compile on the latest nightly.
```rust
#![feature(core_intrinsics)]
#![feature(const_int_unchecked_arith)]
fn main() {
let _ = unsafe { [0i32; std::intrinsics::unchecked_add(4, 2)] };
}
```
Output:
```
warning: unnecessary `unsafe` block
--> src/main.rs:5:13
|
5 | let _ = unsafe { [0i32; std::intrinsics::unchecked_add(4, 2)] };
| ^^^^^^ unnecessary `unsafe` block
|
= note: `#[warn(unused_unsafe)]` on by default
error[E0133]: call to unsafe function is unsafe and requires unsafe function or block
--> src/main.rs:5:29
|
5 | let _ = unsafe { [0i32; std::intrinsics::unchecked_add(4, 2)] };
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function
|
= note: consult the function's documentation for information on how to avoid undefined behavior
error: aborting due to previous error; 1 warning emitted
```
I would have expected this to compile successfully, but it seems that `unsafe` is not applied to array length expressions. The nightly features are only needed because there are no stable `const unsafe` functions. A user-defined `const unsafe fn` runs into the same error [on stable](https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=e0292c531ef391ca227bf6947dfb9bc1).
This arose from discussion in rust-lang/rfcs#2920.
<!-- TRIAGEBOT_START -->
<!-- TRIAGEBOT_ASSIGN_START -->
<!-- TRIAGEBOT_ASSIGN_DATA_START$${"user":"LeSeulArtichaut"}$$TRIAGEBOT_ASSIGN_DATA_END -->
<!-- TRIAGEBOT_ASSIGN_END -->
<!-- TRIAGEBOT_END -->
|
T-compiler,C-bug,A-const-eval,A-array
|
low
|
Critical
|
621,221,077 |
godot
|
Line2d's antialiased is not working correctly in GLES 3
|
Godot_v3.2.2-beta2_win64
windows 10
Godot_v3.2.2-beta2_win64
Gles3

Gles2

Querry - Is Gles2 deprecating?
|
bug,topic:rendering,topic:2d
|
low
|
Major
|
621,228,926 |
PowerToys
|
[Run] Support Extensions
|
Is the plugin environment the same as with Wox? The Wox.Plugin package seems to still be present. Can existing wox plugins be used? I can't drag any files into the launcher like I could with wox.
Do you have any guides or tips for creating a plugin otherwise?
|
Idea-Enhancement,Product-PowerToys Run,Run-Plugin,Run-Plugin Manager
|
high
|
Critical
|
621,235,751 |
flutter
|
Talkback does not honor namesRoute on Samsung devices
|
When creating a Semantics widget with scopesRoute AND namesRoute set to true, and specifying a label works on Android, except for Samsung devices. An easy way to see this is by creating an app that simply pushes a new route onto the stack, and Talk Back doesn't read anything at all on Samsung devices. This is related to #53924 where it won't read anything with only `scopesRoute` is set, but this bug is that the workaround of also setting `namesRoute` and a `label` doesn't work on Samsung.
The following code shows the problem. With this test, Talkback should read "Page 2" followed by the first text widget on the page when navigating back and forth between pages. This works on most devices except Samsung devices.
<details>
<summary>code sample</summary>
```dart
import 'package:flutter/material.dart';
import 'package:flutter/rendering.dart';
void main() {
runApp(MyApp());
}
class MyApp extends StatelessWidget {
// This widget is the root of your application.
@override
Widget build(BuildContext context) {
return MaterialApp(
title: 'Flutter Demo',
theme: ThemeData(
primarySwatch: Colors.blue,
),
home: SemanticsNav1HomePage(),
);
}
}
class SemanticsNav1HomePage extends StatelessWidget {
@override
Widget build(BuildContext context) {
SystemChrome.setSystemUIOverlayStyle(SystemUiOverlayStyle.dark);
return Semantics(
scopesRoute: true,
namesRoute: true,
label: "Page 1",
explicitChildNodes: true,
child: Scaffold(
body: SafeArea(
top: true,
child: Column(
mainAxisAlignment: MainAxisAlignment.start,
mainAxisSize: MainAxisSize.max,
crossAxisAlignment: CrossAxisAlignment.stretch,
children: <Widget>[
Padding(
padding: const EdgeInsets.all(24.0),
child: Text(
"Hello, press the button below to launch the next page",
style: TextStyle(fontSize: 24),
),
),
Expanded(
child: Center(
child: MaterialButton(
color: Colors.black,
textColor: Colors.white,
child: Text("Launch route 2", style: TextStyle(fontSize: 20)),
onPressed: () => Navigator.push(context, PageRouteBuilder(pageBuilder: (context, animation, secondaryAnimation) => SemanticsNav2HomePage())),
)
),
),
],
),
),
),
);
}
}
class SemanticsNav2HomePage extends StatelessWidget {
@override
Widget build(BuildContext context) {
SystemChrome.setSystemUIOverlayStyle(SystemUiOverlayStyle.dark);
return Semantics(
scopesRoute: true,
namesRoute: true,
label: "Page 2",
explicitChildNodes: true,
child: Scaffold(
body: SafeArea(
top: true,
child: Column(
mainAxisAlignment: MainAxisAlignment.start,
mainAxisSize: MainAxisSize.max,
crossAxisAlignment: CrossAxisAlignment.stretch,
children: <Widget>[
Padding(
padding: const EdgeInsets.all(24.0),
child: Text(
"Hello, press the button below to close this page",
style: TextStyle(fontSize: 24),
),
),
Expanded(
child: Center(
child: MaterialButton(
color: Colors.black,
textColor: Colors.white,
child: Text("Pop route 2", style: TextStyle(fontSize: 20)),
onPressed: () => Navigator.pop(context),
)
),
),
],
),
),
),
);
}
}
```
</details>
|
e: device-specific,platform-android,framework,engine,a: accessibility,f: routes,customer: amplify,has reproducible steps,P2,e: samsung,team-android,triaged-android,found in release: 3.19,found in release: 3.21
|
low
|
Critical
|
621,245,097 |
PowerToys
|
[Run][New Plugin] Have the ability to search and open an Outlook Contact card.
|
I"m not sure how many folks other than myself spent the last 10 yrs complaining in the Office forums that I could not click the start button and type in anything from a Outlook Desktop contacts card, including something from the notes section, or a phone # to pull up AND LAUNCH a contact card.
The issue is now, when you click Start, Search, it finds a contact ONLY by name and only from the icky People App, and not by any of the info in the contact card; and then it teases you by giving you an OPEN command, and then Lucy pulls the football away by ONLY launching a New Email message, to that contact.
This has been cruel and unusual punishment for those of us, (am I the only one) who open contact cards all day every day.
If someone could make this new search thingy index all my Outlook contacts, the way Outlook 2010 did, I will promise to open 1000 contact cards consecutively in an act of celebration. I may even film it.
<!--
A clear and concise description of what you want to happen.
-->
|
Idea-Enhancement,Product-PowerToys Run,Run-Plugin
|
low
|
Major
|
621,247,851 |
flutter
|
Let iOS keyboard dismissal synchronize with scroll
|
Since https://github.com/flutter/flutter/issues/21814, keyboards will dismiss during scroll. For higher fidelity, rather than one single brisk dismissal event, the keyboard dismissal should ideally be done gradually along with the scroll gesture.
Android counterpart: https://github.com/flutter/flutter/issues/62876
|
a: text input,c: new feature,platform-ios,framework,engine,a: fidelity,f: scrolling,customer: crowd,c: proposal,P3,team-ios,triaged-ios
|
high
|
Critical
|
621,274,046 |
pytorch
|
equivalent of tensorflow's embedding_lookup_sparse
|
## π Feature
<!-- A clear and concise description of the feature proposal -->
A way to gather embedding and reduce via methods such as sum or mean when a sparse index tensor is provided.
## Motivation
<!-- Please outline the motivation for the proposal. Is your feature request related to a problem? e.g., I'm always frustrated when [...]. If this is related to another GitHub issue, please link here too -->
It is frequently used in processing variable length sequence data, such as processing sentences.
## Pitch
<!-- A clear and concise description of what you want to happen. -->
An equivalent of tf.embedding_lookup_sparse
## Alternatives
<!-- A clear and concise description of any alternative solutions or features you've considered, if any. -->
I didn't find an alternative
## Additional context
<!-- Add any other context or screenshots about the feature request here. -->
|
feature,triaged
|
low
|
Minor
|
621,275,016 |
PowerToys
|
[Run] Setting to show path in result list without hovering
|
# Summary of the new feature/enhancement
The launcher sometimes finds some applications/executables which are not easy to put in context.
For example, when I search for "uninstall" I get several suggestions. a list of applications called "Uninstall" without any further information, except the icon and "Win32 application"
It would be helpful if there's a setting to show the path to a search result underneath.
# Proposed technical implementation details (optional)
Checkbox in the settings of PowerToys Run which toggles showing the path to a search result.
|
Idea-Enhancement,Product-PowerToys Run,Area-User Interface
|
low
|
Minor
|
621,284,279 |
kubernetes
|
SSA Apply: Different or same command?
|
I've had different form of this conversation with many different people and so far we've been going toward making server-side apply the same command, but there are pros and cons to both approach. I'd like to have a more formal discussion about this.
I'm going to try to describe the problem neutrally, but I think I'm biased toward having a separate command.
Why should we have a new `kubectl` command:
- We're less likely to break anyone's workflow (flags not working as expected, something that used to work with `kubectl apply` doesn't work anymore), we already have a few of these and there are probably a lot that we haven't seen:
- `--force` flag doesn't work for server-side apply
- Missing protocol doesn't work on deployment ports.
- Conflicts will start causing failures where they previously didn't
- We don't support applying APIServices
- The flags are a little messy because some clearly apply to client-side while other clearly apply to server-side, that's general engineer malpractice to convolute these two things (`--overwrite`, client-side dry-run, `--openapi-patch`, `--validate`).
- Because of the two points above, we're losing freedom to make the changes that we would want to make because we sort of have to maintain compatibility (C++ syndrome).
- Basically, the abstraction is leaky in bad ways.
On the other hand, re-using the same name is great because:
- There is clearly no better name than `apply` for the command, so we'll have to settle with something not as good
- If we ever want to re-claim the `apply` name, we'll need a long-term plan to deprecate the existing `apply` and eventually rename
- People will start using it instantly. The risk with the new command is that people never start using it or aren't aware that it exists
|
sig/api-machinery,sig/cli,lifecycle/frozen,wg/api-expression
|
low
|
Critical
|
621,288,821 |
youtube-dl
|
yupptv.com request
|
<!--
######################################################################
WARNING!
IGNORING THE FOLLOWING TEMPLATE WILL RESULT IN ISSUE CLOSED AS INCOMPLETE
######################################################################
-->
## Checklist
<!--
Carefully read and work through this check list in order to prevent the most common mistakes and misuse of youtube-dl:
- First of, make sure you are using the latest version of youtube-dl. Run `youtube-dl --version` and ensure your version is 2020.05.08. If it's not, see https://yt-dl.org/update on how to update. Issues with outdated version will be REJECTED.
- Make sure that all provided video/audio/playlist URLs (if any) are alive and playable in a browser.
- Make sure that site you are requesting is not dedicated to copyright infringement, see https://yt-dl.org/copyright-infringement. youtube-dl does not support such sites. In order for site support request to be accepted all provided example URLs should not violate any copyrights.
- Search the bugtracker for similar site support requests: http://yt-dl.org/search-issues. DO NOT post duplicates.
- Finally, put x into all relevant boxes (like this [x])
-->
- [x] I'm reporting a new site support request
- [x] I've verified that I'm running youtube-dl version **2020.05.08**
- [x] I've checked that all provided URLs are alive and playable in a browser
- [x] I've checked that none of provided URLs violate any copyrights
- [x] I've searched the bugtracker for similar site support requests including closed ones
## Example URLs
<!--
Provide all kinds of example URLs support for which should be included. Replace following example URLs by yours.
-->
- Single video: https://www.youtube.com/watch?v=BaW_jenozKc
- Single video: https://youtu.be/BaW_jenozKc
- Playlist: https://www.youtube.com/playlist?list=PL4lCao7KL_QFVb7Iudeipvc2BCavECqzc
## Description
<!--
Provide any additional information.
If work on your issue requires account credentials please provide them or explain how one can obtain them.
-->
Please add support for yupptv.com
here is an example link:
https://www.yupptv.com/channels/star-jalsha/chuni-panna/48534542/20-may-2020
|
site-support-request
|
low
|
Critical
|
621,345,695 |
pytorch
|
[jit] `jit.annotate` and multiple compilation of functions with different types
|
## π Feature
Provide a way to `jit.script` a method more than once with different signatures.
## Motivation
Providing "templating" or specializing generics functionality by reusing function definitions in Python for multiple scripted functions that differ in signature but share the body.
Currently the only way seems to write the entire function multiple times with the correct signature embedded in native Python syntax. `jit.annotate` and `jit.Attribute` are also getting deprecated (they never provided this functionality, but the API design is relevant).
## Pitch
Provide a function similar to `jit.script` with an additional argument taking a type signature for the method being compiled.
This type signature will likely need to be an actual Python object (e.g. based on `Callable[]`) to allow forwarding types from the compiling context to the compiler (which can't see the context here?).
Example:
```py
foo_tensor = jit.script_typed(foo, Callable[[Tensor, Tensor], Tensor]])
foo_tuple = jit.script_typed(foo, Callable[[Tensor, Tuple[Tensor, Tensor]], Tensor])
```
### Questions
How do we handle methods taking `self`, `cls`?
Simplest way would be to write them manually and dispatch to a separate compiled specialization of a function. Issue then is representing the `self` and `cls`.
The most basic needed functionality in that case, IMO, would be the ability to see a class instance as a container of variables and `Parameter`s, even without seeing any of its methods. We do need to continue having access to `nn.Module` fields as that's the current main design pattern. Something like a `Namespace`.
## Alternatives
Not sure.
## Additional context
Julia provides multiple dispatch. At a minimum, this provides some generics capability to the language.
In PyTorch, this is already handled by the base type (Tensor) at the element level. But we're missing it for more complex compositions of other available types.
cc @suo
|
triage review,oncall: jit
|
low
|
Minor
|
621,350,890 |
flutter
|
Remake native iOS button in example/flutter_view
|
The example was build with the MaterialControls pod, whose repository now 404s; as a result the tree is closed because this example doesn't build.
https://github.com/flutter/flutter/pull/57621 does a quick and dirty replacement with a featureless, shadowless, square button. It should be made to look a lot less bad, but that doesn't need to keep the tree closed.
|
framework,f: material design,d: examples,team-design,triaged-design
|
low
|
Minor
|
621,364,002 |
TypeScript
|
RegExp literal flag types
|
<!-- π¨ STOP π¨ π¦π§π’π£ π¨ πΊπ»πΆπ· π¨
Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker.
Please help us by doing the following steps before logging an issue:
* Search: https://github.com/Microsoft/TypeScript/search?type=Issues
* Read the FAQ, especially the "Common Feature Requests" section: https://github.com/Microsoft/TypeScript/wiki/FAQ
-->
## Search Terms
RegExp Regex literal flags as const narrowing
## Suggestion
This is similar to the proposal for typing named capture groups https://github.com/microsoft/TypeScript/issues/32098
It would be useful to narrow RegExp literals based on their flags as well. This could be modeled as type parameter(s) as in that proposal, or as a type intersection, which I will use here.
```
const myRegExp = /hello/y; // has type RegExp & {dotAll: false, global: false, ignoreCase: false, multiline: false, sticky: true, unicode: false, flags: 'y'};
```
## Use Cases
Regular expressions have different behavior when defined with different flags, and functions may have different behavior when they receive them, so they may want to distinguish the flags of a RegExp for overloads or allowed argument values.
## Examples
In the standard library, String.prototype.match returns either the first match with its capture groups, or a list of all matches, depending on whether the argument is a global RegExp. This could be modeled as an overload:
```
match(str: string): RegExpMatchArray|null
match(regexp: RegExp & {global: false}): RegExpMatchArray|null
match(regexp: RegExp & {global: true}): Array<string>|null;
match(regexp: RegExp): RegExpMatchArray|null;
```
I recently wrote some functions which only work with sticky RegExps, so I had to put checks at the top of each function:
```ts
function match(regexp: RegExp) {
if (!regexp.sticky) { throw new Error("Invalid argument -- RegExp must use the /y 'sticky' flag"); }
...
}
match(/sticky example/y); // compiles and runs fine
match(/non-sticky example/); // compiles fine, runtime error
```
I'd like to define the function instead as:
```ts
type StickyRegExp = RegExp & {sticky: true};
function match(regexp: StickyRegExp) {
...
}
match(/sticky example/y); // compiles and runs fine
match(/non-sticky example/); // compiler error
```
<!-- Show how this would be used and what the behavior would be -->
## Checklist
My suggestion meets these guidelines:
* [x] This wouldn't be a breaking change in existing TypeScript/JavaScript code
* [x] This wouldn't change the runtime behavior of existing JavaScript code
* [x] This could be implemented without emitting different JS based on the types of the expressions
* [x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
* [x] This feature would agree with the rest of [TypeScript's Design Goals](https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals).
|
Suggestion,Awaiting More Feedback
|
low
|
Critical
|
621,367,293 |
go
|
net/http/httptrace: Provide direction in the documentation for ClientTrace on safety of request mutations
|
The documentation for `ClientTrace` provides no guidance on if it is safe to modify the request from within any of the trace functions. It mentions that the functions within `ClientTrace` may be called concurrently, but does not comment on if these functions are permitted to modify the request. In contrast, the documentation for [RoundTripper](https://golang.org/pkg/net/http/#RoundTripper) explicitly calls out the expected behavior:
```
// RoundTrip should not modify the request, except for
// consuming and closing the Request's Body. RoundTrip may
// read fields of the request in a separate goroutine. Callers
// should not mutate or reuse the request until the Response's
// Body has been closed.
```
This concern was originally raised when attempting to use `GotConn` to modify the request `Header` to add the amount of time remaining until the request's context deadline, for use in distributed tracing. I would like to be able to modify certain properties in the request (Headers, Body, ...) in response to `ClientTrace` data, but need to understand if that behavior will continue to be supported.
This issue has two components:
1. Provide guidance on if the functions within `ClientTrace` are permitted to modify the request
2. If the functions within `ClientTrace` are permitted to modify the request, promise this expectation will continue in the future by updating the documentation to reflect this
|
Documentation,NeedsInvestigation
|
low
|
Major
|
621,393,647 |
vscode
|
Touch screen on chromebook
|
Issue Type: <b>Feature Request</b>
Can we have touch screen scrolling on chromebooks. I understand virtual keyboard may not be possible yet but basic cursor movement and scrolling should be possible.
VS Code version: Code 1.44.2 (ff915844119ce9485abfe8aa9076ec76b5300ddd, 2020-04-16T17:50:03.709Z)
OS version: Linux x64 4.19.113-08528-g5803a1c7e9f9
<!-- generated by issue reporter -->
|
feature-request,polish,web,touch/pointer
|
medium
|
Critical
|
621,401,288 |
pytorch
|
test_float_to_int_conversion_finite_cpu_int16 is failing on MacOS
|
```
May 19 08:56:50 ======================================================================
May 19 08:56:50 FAIL [0.003s]: test_float_to_int_conversion_finite_cpu_int16 (__main__.TestTorchDeviceTypeCPU)
May 19 08:56:50 ----------------------------------------------------------------------
May 19 08:56:50 Traceback (most recent call last):
May 19 08:56:50 File "/Users/distiller/workspace/miniconda3/lib/python3.7/site-packages/torch/testing/_internal/common_device_type.py", line 234, in instantiated_test
May 19 08:56:50 result = test(self, device_arg, dtype)
May 19 08:56:50 File "/Users/distiller/workspace/miniconda3/lib/python3.7/site-packages/torch/testing/_internal/common_device_type.py", line 501, in only_fn
May 19 08:56:50 return fn(self, device, *args, **kwargs)
May 19 08:56:50 File "test_torch.py", line 16627, in test_float_to_int_conversion_finite
May 19 08:56:50 self._float_to_int_conversion_helper(vals, device, dtype)
May 19 08:56:50 File "test_torch.py", line 16603, in _float_to_int_conversion_helper
May 19 08:56:50 self.assertEqual(torch.from_numpy(a), t.cpu())
May 19 08:56:50 File "/Users/distiller/workspace/miniconda3/lib/python3.7/site-packages/torch/testing/_internal/common_utils.py", line 1083, in assertEqual
May 19 08:56:50 self.assertTrue(result, msg=message)
May 19 08:56:50 AssertionError: False is not true : Tensors failed to compare as equal! Found 1 different element(s) (out of 9), with the greatest difference of 32768 (-32768 vs. 0) occuring at index 0.
May 19 08:56:50
May 19 08:56:50 ----------------------------------------------------------------------
```
This issue first appears on Master after this PR https://github.com/pytorch/pytorch/pull/38641, which seems unrelated.
I am disabling the test.
cc @ezyang @gchanan @zou3519 @mruberry
|
high priority,module: tests,triaged,module: numpy
|
low
|
Critical
|
621,440,384 |
flutter
|
Document that service workers require https
|
Images pulled from the web show ok when running `flutter run -d chrome`
However when I deploy the app on Firebase using: firebase deploy and hitting the endpoint, when I refresh the page, network pulled images do not show up at all. If I force refresh on the browser, they appear again.
|
tool,d: api docs,platform-web,P3,team-web,triaged-web
|
low
|
Major
|
621,453,907 |
PowerToys
|
[Run] Support single key press to open Run (e.g. caplock)
|
# Launch PowerToys Run by pressing capslock
Make Capslock into a hyper key, ideally to launch PowerToys Run (or other uses as ppl see fit).
## Advantages:
- save time: Alt-Space is two key presses, capslock is one.
- Capslock is obsolete. ChromeOS has already turned it into a search key so for kids using chromebooks in school it makes for an easier transition.
Note: I used the Keyboard Manager powertoy to remap capslock to another key, but its still not working to launch Run. Also tried remapping CapsLock to Alt-Space (in remap shortcuts) but that didn't work either.
|
Idea-Enhancement,Help Wanted,Product-PowerToys Run
|
medium
|
Critical
|
621,456,387 |
flutter
|
Proposal: Add about dialogue and license page for cupertino package.
|
## Use case
Display information about an app in a dialogue.
Display collected licenses.
## Proposal
Add a new UI for the Cupertino package mirroring that which already exists for the Material package.
## Related issues
#57226
|
c: new feature,framework,f: cupertino,c: proposal,team-design,triaged-design
|
low
|
Minor
|
621,465,826 |
TypeScript
|
Include types for TSConfig
|
## Search Terms
types for tsconfig
## Suggestion
Include types for TSConfig.
## Use Cases
Automation and code generation
## Examples
I'd like an extensible way to create and modify TSConfig files, and to represent these files as objects.
## Checklist
My suggestion meets these guidelines:
* [x] This wouldn't be a breaking change in existing TypeScript/JavaScript code
* [x] This wouldn't change the runtime behavior of existing JavaScript code
* [x] This could be implemented without emitting different JS based on the types of the expressions
* [x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
* [x] This feature would agree with the rest of [TypeScript's Design Goals](https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals).
@webstrand came up with a demo earlier today, that's somewhat manually extracted: https://gist.github.com/webstrand/68e33abe8073a1e6f56d25b722ea0db9
|
Suggestion,Awaiting More Feedback
|
low
|
Minor
|
621,479,209 |
go
|
cmd/go: return best-effort results despite inconsistent vendoring
|
Following up on https://github.com/golang/go/issues/39100, is it possible for the `go` command to return partial results even with an inconsistent vendor folder? This is done in several (arguably smaller) cases, like #35973 and #38846.
If `go list` could return partial results along with the error, that would make the experience in `gopls` much better for users. Right now, our best option will be to show the user a pop-up with the error message and a button that, when clicked, runs `go mod vendor`. This work-around is fine for now, but I wonder if there is a better longterm solution.
/cc @bcmills @jayconrod @heschik
|
Vendoring,NeedsInvestigation,FeatureRequest,modules
|
medium
|
Critical
|
621,523,112 |
terminal
|
Update Preview icon to align with Edge
|
# Environment
```none
Windows build number: 19628
Windows Terminal version (if applicable): 1.0.1402
```
# Steps to reproduce
Install Windows Terminal Preview
# Expected behavior
The Terminal Preview icon and Edge Insider icon's preview-labels line up nicely and use the same font and size.
# Actual behavior
Given the basic design, it feels obvious that the Terminal Preview's "Preview" label is modelled after the Microsoft Edge icon.
<img width="167" alt="Annotation 2020-05-20 091514" src="https://user-images.githubusercontent.com/1693592/82416744-d8ab1600-9a7a-11ea-8da3-c5b2569a2970.png">
But the labels don't line up nicely and a different font (weight) is used for the Terminal compared to Edge.
-----
It's a *very* insignificant issue. But I'd just like to point it out because - as someone who uses both regularly - it annoys me. π
|
Issue-Bug,Area-UserInterface,Product-Terminal,Priority-3
|
low
|
Major
|
621,530,588 |
pytorch
|
LibTorch 1.5.0 not supporting GLIBC < 2.23
|
## π Bug
LibTorch 1.5.0 seemed built on top of GLIBC 2.23 where PyTorch 1.5.0 pip wheel built on lower version. Do we have a plan to support LibTorch on version below 2.23? Or any instruction for user on GLIBC 2.23 and below to use it?
## To Reproduce
If you try to use it on Cent OS 7, you can easily fall into the following issue:
```
download
https://download.pytorch.org/libtorch/cu102/libtorch-cxx11-abi-shared-with-deps-1.5.0.zip
```
Error message
```
/lib64/libm.so.6: version `GLIBC_2.23' not found (required by /home/centos/libtorch_cpu.so)
```
## Expected behavior
It should be fine to use the libtorch for lower GLIBC version as claimed here: https://pytorch.org/get-started/locally/#supported-linux-distributions
## Environment
PyTorch version: 1.5.0
Is debug build: No
CUDA used to build PyTorch: 10.2
OS: CentOS Linux 7 (Core)
GCC version: (GCC) 4.8.5 20150623 (Red Hat 4.8.5-39)
CMake version: version 3.6.2
Python version: 3.6
Is CUDA available: No
CUDA runtime version: No CUDA
GPU models and configuration: No CUDA
Nvidia driver version: No CUDA
cuDNN version: No CUDA
Versions of relevant libraries:
[pip3] numpy==1.18.4
[pip3] torch==1.5.0
[conda] Could not collect
cc @malfet @yf225 @glaringlee
|
module: build,module: cpp,triaged
|
low
|
Critical
|
621,530,833 |
terminal
|
FPS overlay for performance debugging
|
<!--
π¨π¨π¨π¨π¨π¨π¨π¨π¨π¨
I ACKNOWLEDGE THE FOLLOWING BEFORE PROCEEDING:
1. If I delete this entire template and go my own path, the core team may close my issue without further explanation or engagement.
2. If I list multiple bugs/concerns in this one issue, the core team may close my issue without further explanation or engagement.
3. If I write an issue that has many duplicates, the core team may close my issue without further explanation or engagement (and without necessarily spending time to find the exact duplicate ID number).
4. If I leave the title incomplete when filing the issue, the core team may close my issue without further explanation or engagement.
5. If I file something completely blank in the body, the core team may close my issue without further explanation or engagement.
All good? Then proceed!
-->
# Description of the new feature/enhancement
It would be nice to have a FPS overlay to indicate the current rendering FPS. You've all seen this in various kinds of games. I'm confident that this will not be the craziest feature request for the WT project.
<!--
A clear and concise description of what the problem is that the new feature would solve.
Describe why and how a user would use this new functionality (if applicable).
-->
# Proposed technical implementation details (optional)
Well technically the FPS is quite easy to calculate, the overlay might be a little bit trickier, depending on what information we need to display and how to display them.
<!--
A clear and concise description of what you want to happen.
-->
|
Issue-Feature,Help Wanted,Area-Rendering,Area-Extensibility,Product-Terminal
|
low
|
Critical
|
621,547,269 |
godot
|
Monodevelop don't open cs file
|
**Godot version:**
3.2.1.stable mono
**OS/device including version:**
Debian 10
**Issue description:**
I switched to monodevlop today but when I click in any cs file nothing happen. I just have monodevelop opened when I start the project.
**Steps to reproduce:**
Click/try to open in any cs script
**Minimal reproduction project:**
[Basic.zip](https://github.com/godotengine/godot/files/4655421/Basic.zip)
|
bug,topic:editor,confirmed,topic:dotnet
|
low
|
Major
|
621,555,664 |
create-react-app
|
Use solutions style tsconfig structure for TypeScript template
|
In version 3.9, TypeScript introduced the concept of "Solutions Style" tsconfig to improve developer experience.
More info: https://devblogs.microsoft.com/typescript/announcing-typescript-3-9-rc/#solution-style-tsconfig
```jsonc
// tsconfig.json
{
"files": [],
"references": [
{ "path": "./tsconfig.app.json" },
{ "path": "./tsconfig.spec.json" },
]
}
```
|
issue: proposal,needs triage
|
low
|
Minor
|
621,570,416 |
flutter
|
RobolectricTestRunner on sdk 29 succeeds without actually running the test
|
When the target sdk is set to 29 either via robolectric.properties or `@Config` in the test, the test methods are found but just succeed without actually running the tests.
The normal per test printout like
`.[Robolectric] io.flutter.view.AccessibilityBridgeTest.itHoverOverOutOfBoundsDoesNotCrash: sdk=28; resources=LEGACY`
is absent too.
Possibly related to http://robolectric.org/migrating/#migrating-to-40
Noticed by @mehmetf
|
team,platform-android,engine,dependency: android,P2,team-android,triaged-android
|
low
|
Critical
|
621,577,651 |
pytorch
|
weight_decay in Adam is not an L2 Penalty
|
## π Documentation
The documentation for torch.optim.Adam states:
weight_decay (float, optional): weight decay (L2 penalty) (default: 0)
The formula for weight decay and L2-regularization are different.
Weight decay:
w[t+1] = w[t] - learning_rate * dw - weight_decay * w
L2-regularization:
loss = actual_loss + lambda * 1/2 sum(||w||^2)
For SGD, a weight decay is similar to an L2 regularization, which is not true for adaptive gradient.
See "Decoupled Weight Decay Regularization" ( https://arxiv.org/abs/1711.05101 )
Which version is implemented in PyTorch ? Weight decay ? L2-regularization ?
A formula in the documentation would clarify that.
cc @vincentqb
|
module: optimizer,triaged
|
low
|
Minor
|
621,594,066 |
go
|
cmd/go: test -cover reports 100.0% without full coverage
|
### What version of Go are you using (`go version`)?
<pre>
go version go1.14.3 windows/amd64
</pre>
### Does this issue reproduce with the latest release?
Yes (1.14.3)
### What operating system and processor architecture are you using (`go env`)?
<details><summary><code>go env</code> Output</summary><br><pre>
set GO111MODULE=
set GOARCH=amd64
set GOBIN=
set GOCACHE=C:\Users\egon\AppData\Local\go-build
set GOENV=C:\Users\egon\AppData\Roaming\go\env
set GOEXE=.exe
set GOFLAGS=
set GOHOSTARCH=amd64
set GOHOSTOS=windows
set GOINSECURE=
set GONOPROXY=
set GONOSUMDB=
set GOOS=windows
set GOPATH=C:\Users\egon\Desktop
set GOPRIVATE=
set GOPROXY=https://proxy.golang.org,direct
set GOROOT=c:\go
set GOSUMDB=sum.golang.org
set GOTMPDIR=
set GOTOOLDIR=c:\go\pkg\tool\windows_amd64
set GCCGO=gccgo
set AR=ar
set CC=gcc
set CXX=g++
set CGO_ENABLED=1
set GOMOD=
set CGO_CFLAGS=-g -O2
set CGO_CPPFLAGS=
set CGO_CXXFLAGS=-g -O2
set CGO_FFLAGS=-g -O2
set CGO_LDFLAGS=-g -O2
set PKG_CONFIG=pkg-config
set GOGCCFLAGS=-m64 -mthreads -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=C:\Users\egon\AppData\Local\Temp\go-build906217222=/tmp/go-build -gno-record-gcc-switches
</pre></details>
### What did you do?
The problem came up while developing a binary protocol library with many generated functions.
Generate many tests with a script:
```
package main
import (
"html/template"
"os"
)
const n = 50000
func main() {
{
f, err := os.Create("cov.go")
p(err)
_, err = f.Write([]byte(`package cov`))
p(err)
for i := 0; i < n; i++ {
p(template.Must(template.New("").Parse(`
func F{{.N}}() int { return {{.N}} }`)).Execute(f, map[string]interface{}{"N": i}))
}
p(f.Close())
}
{
f, err := os.Create("cov_test.go")
p(err)
_, err = f.Write([]byte(`package cov
import (
"testing"
)
`))
p(err)
for i := 0; i < n-1; i++ {
p(template.Must(template.New("").Parse(`
func TestF{{.N}}(t *testing.T) { F{{.N}}() }`)).Execute(f, map[string]interface{}{"N": i}))
}
p(f.Close())
}
}
func p(err error) {
if err != nil {
panic(err)
}
}
```
Run test coverage:
```
>go test -cover cov
ok cov 0.238s coverage: 100.0% of statements
```
### What did you expect to see?
`99.9%` or something similar.
Reducing `n` to `1000` produces `99.9%` on my machine.
### What did you see instead?
`100.0%` (which implies full coverage, not true!)
|
NeedsDecision
|
low
|
Critical
|
621,610,028 |
PowerToys
|
[Run] Add the ability to search files with specific file tags
|
I would be great if we could search files with specific tags from PowerToys Run.
For instance with I have file(s) tagged as Work, Education, Receipt, etc.
Searching for receipt (case insensitive) would show result(s) of file(s) that are tagged with Receipt.
|
Idea-Enhancement,Product-PowerToys Run,Run-Results (Indexer)
|
low
|
Minor
|
621,613,944 |
opencv
|
Papers for SIFT improvements
|
Maybe one or another idea from these ressources can be relevant for the GSoC SIFT project.
Fast Implementation:
https://github.com/alicevision/popsift
http://home.ifi.uio.no/paalh/publications/files/mmsys2018-popsift.pdf
Matching at different scale spaces:
http://openaccess.thecvf.com/content_iccv_2017/html/Zhou_Progressive_Large_Scale-Invariant_ICCV_2017_paper.html
|
feature,category: features2d
|
low
|
Minor
|
621,645,719 |
godot
|
Downloaded C# Plugins not instantly working without build
|
**Godot version:** 3.2 Mono
**OS/device including version:** Windows 10
**Issue description:**
We use plugins written in C# to prepare the project before running. People who download the project are forced to build the whole assembly before being able to use said plugin.
Is there a way to "ship" the project with already pre build plugin assemblies?
**Steps to reproduce:**
Any C# plugin needs to be build
**Minimal reproduction project:**
In progress
|
enhancement,topic:editor,topic:plugin,topic:dotnet
|
low
|
Minor
|
621,654,478 |
PowerToys
|
[Run] Default text when Run is opened
|
I would like to be able to specify a string that in inputted when the dialogue is opened, an example of this usage would be i want to have a default of `powershell -c "start-process pwsh -c ' ' -verb runas"` and have my curser placed in the single quotes of the second `-c` so i can quickly type an one-liner
|
Idea-Enhancement,Product-PowerToys Run
|
low
|
Minor
|
621,674,225 |
PowerToys
|
[Run][New Plugin] Dictionary
|

would help to search word meaning quickly a highly useful feature for everyone
|
Idea-Enhancement,Product-PowerToys Run,Run-Plugin
|
high
|
Critical
|
621,681,389 |
TypeScript
|
Parameters<T> and ReturnType<T> limitation
|
<!-- π¨ STOP π¨ π¦π§π’π£ π¨ πΊπ»πΆπ· π¨
Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Even if you think you've found a *bug*, please read the FAQ first, especially the Common "Bugs" That Aren't Bugs section!
Please help us by doing the following steps before logging an issue:
* Search: https://github.com/Microsoft/TypeScript/search?type=Issues
* Read the FAQ: https://github.com/Microsoft/TypeScript/wiki/FAQ
Please fill in the *entire* template below.
-->
<!--
Please try to reproduce the issue with the latest published version. It may have already been fixed.
For npm: `typescript@next`
This is also the 'Nightly' version in the playground: http://www.typescriptlang.org/play/?ts=Nightly
-->
**TypeScript Version:** 3.9.2
<!-- Search terms you tried before logging this (so others can find this issue more easily) -->
**Search Terms:**
Generic Method Extend Parameters ReturnType
**Code**
```ts
export class Test {
myMethod(): string {
return "42";
}
myMethod2(a: string): string {
return "42" + a;
}
// Works ---
override<M extends keyof this>(method: M, newFunc: this[M]) {
}
// Works ---
override2<M extends keyof this>(method: M, newFunc: (...args: Parameters<this["myMethod2"]>) => ReturnType<this["myMethod2"]>) {
}
// Fails ---
override3<M extends keyof this>(method: M, newFunc: (...args: Parameters<this[M]>) => ReturnType<this[M]>) {
}
}
const test = new Test();
test.override("myMethod2", a => "xxx");
test.override2("myMethod2", a => "xxx");
test.override3("myMethod2", a => "xxx");
```
**Expected behavior:**
I would expect override3 to compile and be equivalent to override + override2 (when M == "myMethod2")
**Actual behavior:**
override3 causes syntax error:
```
Type 'this[M]' does not satisfy the constraint '(...args: any) => any'.
Type 'this[keyof this]' is not assignable to type '(...args: any) => any'.
Type 'this[string] | this[number] | this[symbol]' is not assignable to type '(...args: any) => any'.
Type 'this[string]' is not assignable to type '(...args: any) => any'.
```
**Playground Link:** <!-- A link to a TypeScript Playground "Share" link which demonstrates this behavior -->
https://www.typescriptlang.org/play/?ssl=28&ssc=14&pln=28&pc=15#code/MYGwhgzhAEAqCmEAu0DeAod1vQLYE8BZeJACwHsATACgEoAuaZAJwEsA7AczSxz+ZIBXZu2gAiACwAmMQG5e2AL6Y+BYmSpTqYRiw6cGTJGy48+-ISPHSx0ANTQw8vsoXQA9O+wB1cswDWMNAAtKFu5ABu8MxslPAAPITQ8AAeSPDslDD+8PjkAGbQZKwQAHzUuCQUlIyEADTQ7PAA7gBiguzAjMUQANqEALq0ZjiufJ4+foHYocHhUTGscVKJyWkZWdA5eYU95ZUaNdD1jS3tnYzUAHQ3YMycEIwACndgB9EQ8T29YmpVmmIBqVhgBeUrQABKlnYsHwAAcEt9fkR-pQZEDhhgXCocBNoK0wKwQEFZvNorF4ABmVapdKZbK5ApFUglfao2oNJptDpdaDXW73R7QF7MN4kD5fFl9QbA6BgyHQ2EIyUlfoYkZKdCuYDkdjIIqIFAg07NOCGujydDpZBXSLkpbwajI9TVGQNMBy8FiFI+sS0eTWpC2hYUrTO1Fuxye8Q+lJ+gOG4P2uKUp1-Q6Rj3y72+-3oIA
**Related Issues:** <!-- Did you find other bugs that looked similar? -->
|
Suggestion,Awaiting More Feedback
|
low
|
Critical
|
621,683,208 |
transformers
|
Trying to add support for GPT2 as decoder in EncoderDecoder model
|
# π Feature request
Hi,
I am trying to add the option of using GPT2 as the decoder in the EncoderDecoder model, which only support
## Motivation
For a generation problem, it usually better to use GPT2 as the decoder, over BERT.
## Your contribution
I've made the following changes in `modeling_gpt2.py` file:
- Added crossattention layer if the model is a decoder, to the `Block` class:
```python
class Block(nn.Module):
def __init__(self, n_ctx, config, scale=False):
super().__init__()
nx = config.n_embd
self.ln_1 = nn.LayerNorm(nx, eps=config.layer_norm_epsilon)
self.attn = Attention(nx, n_ctx, config, scale)
self.ln_2 = nn.LayerNorm(nx, eps=config.layer_norm_epsilon)
self.mlp = MLP(4 * nx, config)
self.is_decoder = config.is_decoder
if self.is_decoder:
self.crossattention = Attention(nx, n_ctx, config, scale)
...
def forward(self, x, layer_past=None, attention_mask=None, head_mask=None, use_cache=False, encoder_hidden_states=None,
encoder_attention_mask=None):
output_attn = self.attn(
self.ln_1(x),
layer_past=layer_past,
attention_mask=attention_mask,
head_mask=head_mask,
use_cache=use_cache,
)
a = output_attn[0] # output_attn: a, present, (attentions)
outputs = []
if self.is_decoder and encoder_hidden_states is not None:
cross_attention_outputs = self.crossattention(
a, layer_past, attention_mask, head_mask, encoder_hidden_states=encoder_hidden_states,
encoder_attention_mask=encoder_attention_mask
)
a = cross_attention_outputs[0]
outputs = outputs + cross_attention_outputs[1:] # add cross attentions if we output attention weights
x = x + a
m = self.mlp(self.ln_2(x))
x = x + m
outputs = [x] + output_attn[1:] + outputs
return outputs # x, present, (attentions)
```
- Added 3 Linear layers instead of the Conv1d layer:
```python
class Attention(nn.Module):
def __init__(self, nx, n_ctx, config, scale=False):
...
# self.c_attn = Conv1D(n_state * 3, nx)
self.query = nn.Linear(n_state, nx)
self.key = nn.Linear(n_state, nx)
self.value = nn.Linear(n_state, nx)
...
```
- Added `encoder_attention_mask` and `encoder_hidden_states` to the forward function of the `Attention` class, and using them for the key and the value if they are provided:
```python
def forward(self, x, layer_past=None, attention_mask=None, head_mask=None, use_cache=False, encoder_hidden_states=None,
encoder_attention_mask=None):
query = self.query(x)
if encoder_hidden_states is not None:
key = self.key(encoder_hidden_states)
value = self.value(encoder_hidden_states)
attention_mask = encoder_attention_mask
else:
key = self.key(x)
value = self.value(x)
query = self.split_heads(query)
key = self.split_heads(key, k=True)
value = self.split_heads(value)
...
```
- Added the `encoder_attention_mask` and `encoder_hidden_states` arguments to the `GPT2Model` forward function, and processed `encoder_attention_mask` same as attention_mask:
```python
class GPT2Model(GPT2PreTrainedModel):
...
def forward(
self,
input_ids=None,
past=None,
attention_mask=None,
token_type_ids=None,
position_ids=None,
head_mask=None,
inputs_embeds=None,
use_cache=True,
encoder_hidden_states=None,
encoder_attention_mask=None,
):
...
# Encoder attention mask. (same action as for regular attention mask)
if encoder_attention_mask is not None:
assert batch_size > 0, "batch_size has to be defined and > 0"
encoder_attention_mask = encoder_attention_mask.view(batch_size, -1)
encoder_attention_mask = encoder_attention_mask.unsqueeze(1).unsqueeze(2)
encoder_attention_mask = encoder_attention_mask.to(dtype=next(self.parameters()).dtype) # fp16 compatibility
encoder_attention_mask = (1.0 - encoder_attention_mask) * -10000.0
...
for i, (block, layer_past) in enumerate(zip(self.h, past)):
if self.output_hidden_states:
all_hidden_states = all_hidden_states + (hidden_states.view(*output_shape),)
outputs = block(
hidden_states,
layer_past=layer_past,
attention_mask=attention_mask,
head_mask=head_mask[i],
use_cache=use_cache,
encoder_hidden_states=encoder_hidden_states,
encoder_attention_mask=encoder_attention_mask,
)
...
```
- Added the `encoder_attention_mask` and `encoder_hidden_states` arguments to the `GPT2LMHeadModel`forward function, as well as `lm_lables` and `masked_lm_labels` for EncoderDecoder model compatibility (probably it's better to use `GPT2DoubleHeadsModel`):
```python
class GPT2LMHeadModel(GPT2PreTrainedModel):
...
def forward(
self,
input_ids=None,
past=None,
attention_mask=None,
token_type_ids=None,
position_ids=None,
head_mask=None,
inputs_embeds=None,
labels=None,
use_cache=True,
lm_labels=None,
masked_lm_labels=None,
encoder_hidden_states=None,
encoder_attention_mask=None,
):
...
if lm_labels is not None:
if labels is not None:
raise ValueError("You cannot specify both labels and lm_labels at the same time")
labels = lm_labels
transformer_outputs = self.transformer(
input_ids,
past=past,
attention_mask=attention_mask,
token_type_ids=token_type_ids,
position_ids=position_ids,
head_mask=head_mask,
inputs_embeds=inputs_embeds,
use_cache=use_cache,
encoder_hidden_states=encoder_hidden_states,
encoder_attention_mask=encoder_attention_mask,
)
...
```
My biggest concern is with the second bullet, and I wanted to ask you if this implementation seems right (for now it's look like I am able to train and test an EncoderDecoder with BERT2GPT architecture).
Of course that if needed, I can provide the full code to all of my changes, but all of my changes is listed above.
Most (if not all) of the code I've add is adapted from huggingface `modeling_bert.py`file, so all of the credit goes to them.
Thanks
|
Core: Encoder-Decoder,Good First Issue
|
medium
|
Critical
|
621,685,772 |
PowerToys
|
[Run] Add ability to preview files
|
I think this would be the most useful feature to preview files and videos

|
Idea-Enhancement,Product-PowerToys Run
|
low
|
Minor
|
621,761,683 |
flutter
|
Let Flutter be installable via winget
|
Microsoft recently announced Windows Package Manager:
https://devblogs.microsoft.com/commandline/windows-package-manager-preview/
This is an equivalent of #14050 for Windows: `winget install flutter`. This would make Flutter installation on Windows easier to set up.
|
c: new feature,tool,platform-windows,a: first hour,c: proposal,P3,team-tool,triaged-tool
|
medium
|
Critical
|
621,794,651 |
PowerToys
|
PowerToys option to "Restart" under tray icon right-click menu
|
# Summary of the new feature/enhancement
Add an option to restart PowerToys when right-clicking on the PowerToys tray icon next to Settings and Exit.
Reasoning: The most common reason to right-click the tray icon and exit Powertoys is to exit and reopen PowerToys. Adding the ability to restart with a single click would be beneficial.
<!--
A clear and concise description of what the problem is that the new feature would solve.
Describe why and how a user would use this new functionality (if applicable).
-->
# Proposed technical implementation details (optional)
PowerToys would exit and re-open.
<!--
A clear and concise description of what you want to happen.
-->
|
Idea-Enhancement,Area-Runner,Area-User Interface
|
low
|
Minor
|
621,804,648 |
PowerToys
|
[KBM] CapsLock as a modifier in Remap Shortcuts
|
Dozens of us don't use Caps Lock at all during our normal workflow (dozens!), so it would be nice to be able to use it as an extra modifier when using the Remap Shortcuts functionality.
This is already a thing in macOS world thanks to tools like Karabiner Elements or BetterTouchTool that allow yout to turn Caps Lock into the "Hyper" modifier as it's commonly refered to. I'm sure there's something similar for Linux but I'm not that familiar with it.
In terms of implementation, I don't mind if Caps Lock is not recognised as a modifier straight away since maybe other people don't see it that way. I would be fine using Remap keyboard to map Caps Lock to this new virtual "Hyper" modifier so I can start using it for my Remap shortcuts.
Thanks for the tool by the way, I'm going to start moving most of my maps from AHK to the PowerToys!
|
Idea-Enhancement,Product-Keyboard Shortcut Manager
|
high
|
Critical
|
621,842,429 |
pytorch
|
SPMG in DDP does not have gradient computation and communication overlap?
|
We recently found that there are no overlaps between gradient computation and communication if we use single process multi-gpu mode in DDP. And if we switch to multi-process multi-gpu mode, the overlaps are perfect.
SPMG:

MPMG:

PyTorch version: 1.4.0
Does anyone know why?
Thanks
cc @pietern @mrshenli @pritamdamania87 @zhaojuanmao @satgera @rohan-varma @gqchen @aazzolini @xush6528 @osalpekar
|
oncall: distributed,triaged
|
low
|
Minor
|
621,852,088 |
PowerToys
|
[KBM] Use Caps Lock for toggle upper and lower cases in selected text
|
# Summary of the new feature/enhancement
Windows doesn't have a functionality to turn uppercase to lowercase and viceversa, also the Caps Lock key is in a great position and underused.
# Proposed technical implementation details (optional)
When the user press Caps Lock the currently selected text toggle to uppercase or lowercase dependant on the Caps Lock state.
I made some stupid proof of concept with Python and keyboard listener a while ago: https://github.com/sauloco/easyToogleCase
It worked but has multiple limitations.
|
Idea-Enhancement,Product-Keyboard Shortcut Manager
|
low
|
Major
|
621,910,868 |
pytorch
|
Convergence issues when using pytorch's native AMP
|
## π Bug
The issue has got very weird symptoms.
I've got a pretty complex convolutional network implemented in Pytorch with Lightning (https://github.com/PyTorchLightning/pytorch-lightning). The network trains fine on fp32 (light blue line on the plot below), but when I switch to AMP fp16 with `O2` optimization level (implementation from Lightning), the loss function does something very non-monotonic (dark-red line on the plot). It is important to say that this is training loss, not validation loss.

I could see that the network could just not train properly on AMP, but here the things get much weirder. The network trains correctly in fp16 when I change a specific upscaling in my network from bilinear:
```
nn.Upsample(scale_factor=4*i, mode='bilinear', align_corners=True)
```
to nearest neighbor:
```
nn.Upsample(scale_factor=4*i)
```
That leads me to believe that something very weird may be going on with AMP or fp16 in general. I was trying to force the nn.Upsample to produce a suspicious behavior, but I was unable to do so.
I also do have other `interpolate`-based operations that using bilinear mode in the network, but weirdly enough changing this specific one is enough to fix the network.
## To Reproduce
## Expected behavior
The network should converge the same way with and without fp16 enabled.
## Environment
```
Collecting environment information...
PyTorch version: 1.6.0.dev20200516
Is debug build: No
CUDA used to build PyTorch: 10.2
OS: CentOS Linux 7 (Core)
GCC version: (GCC) 4.8.5 20150623 (Red Hat 4.8.5-39)
CMake version: version 2.8.12.2
Python version: 3.6
Is CUDA available: Yes
CUDA runtime version: 10.2.89
GPU models and configuration: GPU 0: Tesla V100-PCIE-32GB
Nvidia driver version: 440.64.00
cuDNN version: Probably one of the following:
/apps/gpu/cuda/cuda-10.0/targets/x86_64-linux/lib/libcudnn.so.7.6.5
/apps/gpu/cuda/cuda-10.1/targets/x86_64-linux/lib/libcudnn.so.7.6.5
/apps/gpu/cuda/cuda-10.2/targets/x86_64-linux/lib/libcudnn.so.7.6.5
/apps/gpu/cuda/cuda-9.2/targets/x86_64-linux/lib/libcudnn.so.7.6.5
Versions of relevant libraries:
[pip3] numpy==1.18.4
[pip3] pytorch-lightning==0.7.6
[pip3] torch==1.6.0.dev20200516
[pip3] torchvision==0.7.0.dev20200516
[conda] Could not collect
```
(cuda 10.2 is used)
## Additional context
@mcarilli
cc @mcarilli
|
triaged,module: amp (automated mixed precision)
|
low
|
Critical
|
621,927,048 |
PowerToys
|
[Run] Always Show the Run Bar
|
# Summary of the new feature/enhancement
<!--
A clear and concise description of what the problem is that the new feature would solve.
Describe why and how a user would use this new functionality (if applicable).
-->
Since PT Run merges advantages of Windows Taskbar Search and Run, I would like to use it as my go-to app launch mechanism. Taskbar Search can be activated both by a keyboard shortcut and by clicking on the button/bar. PT Run only supports the former and only is visible during use.
It would feel more integrated if there is an option to always show the Run bar on the desktop. When the shortcut is used, the bar would appear on top of the open windows but would otherwise remain behind other windows. This would allow it to be immediately visible when starting a session and make it a potential replacement of the taskbar.
|
Idea-Enhancement,Product-PowerToys Run,Area-User Interface
|
low
|
Major
|
621,940,571 |
PowerToys
|
[Run] Strings after "-" symbol are not showing up
|
Hi All
I am pretty sure there is an error with search result with stings which are just after "-" symbol...
Let's say i have a file:
abc_123-def_456.mp3
So when you type 'def' nothing found. However when you type '456' it finds the file.
I tested that with multiple files.
**PowerToys update [crutkas edited]:**
We are currently blocked on resolving this since it a bug in Indexer regarding word breaks. For PowerToys to use the `LIKE` statement as a workaround, we feel the speed difference is too costly and is a constant impact for all queries, not just files with a dash in them.
Tracking ADO bug is: https://microsoft.visualstudio.com/OS/_workitems/edit/25828850
|
Issue-Bug,Product-PowerToys Run,Status-Blocked,Status-Reproducible
|
low
|
Critical
|
621,952,634 |
angular
|
padding-left style binding toggle doesn't work on Ivy
|
<!--π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
Oh hi there! π
To expedite issue processing please search open and closed issues before submitting a new one.
Existing issues often contain information about workarounds, resolution, or progress updates.
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
-->
# π bug report
### Affected Package
<!-- Can you pin-point one or more @angular/* packages as the source of the bug? -->
<!-- βοΈedit: --> The issue is caused by package @angular/....
### Is this a regression?
<!-- Did this behavior use to work in the previous version? -->
<!-- βοΈ--> Yes, the previous version in which this bug was not present was: ....
Angular 6
see working Stackblitz here
https://stackblitz.com/edit/angular-issue-repro2-qbdodz
1. click the toggle button, it sets "customPadding" which just means padding-left only.
2. click the toggle button, it unsets "customPadding" which just means padding only.
3. Notice that the box has left padding set correctly.
### Description
When I use a Hostbinding for style, the first time I apply padding, it works, then if I apply padding-left, it works, then when I apply padding again, it is actually being applied as padding-top, padding-right, and padding-bottom, but not padding-left.
## π¬ Minimal Reproduction
https://stackblitz.com/edit/angular-ivy-kajdf3
1. click the toggle button, it sets "customPadding" which just means padding-left only.
2. click the toggle button, it unsets "customPadding" which just means padding only.
3. Notice that the box does not have left padding set correctly.
## π Your Environment
**Angular Version:**
<pre><code>
<!-- run `ng version` and paste output below -->
Angular CLI: 9.1.1
Node: 10.16.0
OS: win32 x64
Angular:
...
Ivy Workspace:
Package Version
------------------------------------------------------
@angular-devkit/architect 0.901.1
@angular-devkit/core 9.1.1
@angular-devkit/schematics 9.1.1
@schematics/angular 9.1.1
@schematics/update 0.901.1
rxjs 6.5.4
</code></pre>
**Anything else relevant?**
<!-- βοΈIs this a browser specific issue? If so, please specify the browser and version. -->
<!-- βοΈDo any of these matter: operating system, IDE, package manager, HTTP server, ...? If so, please mention it below. -->
|
type: bug/fix,regression,area: core,state: confirmed,core: styling bindings,P4
|
low
|
Critical
|
622,016,254 |
go
|
proposal: crypto/x509: make CertPool.contains public
|
### What version of Go are you using (`go version`)?
<pre>
$ go version
go version go1.13.7 darwin/amd64
</pre>
### Does this issue reproduce with the latest release?
Yes. The `x509.CertPool` related source code in `release-branch.go1.14` does not appear to have changed, and is not public.
### What operating system and processor architecture are you using (`go env`)?
<details><summary><code>go env</code> Output</summary><br><pre>
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE=""
GOENV=""
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GONOPROXY=""
GONOSUMDB=""
GOOS="darwin"
GOPATH="go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/opt/pkg/go113"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/opt/pkg/go113/pkg/tool/darwin_amd64"
GCCGO="gccgo"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/zz/l8crt7256_vfh01b32jqp7yc0000gn/T/go-build669682046=/tmp/go-build -gno-record-gcc-switches -fno-common"
</pre></details>
### What did you do?
Searched the go source code for alternative paths to `CertPool.contains()`. I have not found an alternative yet.
### What did you expect to see?
A public equivalent to `CertPool.contains()`, or another code path that accesses the method by taking a `CertPool` as input (e.g.,`x509.IsCertIn(*Certificate, *CertPool) bool`).
### What did you see instead?
There does not appear to be any public code to determine if a `CertPool` contains a given certificate.
### Notes
I would like to make `x509.CertPool.contains()` public. Before submitting any changes, I figured I would ask :) I do not see any (obvious) reasons why it would be kept private in the source code, or in `git blame`.
Thank you for reading.
- Stephen
|
Proposal,Proposal-Crypto
|
low
|
Critical
|
622,025,565 |
terminal
|
Cannot scroll buffer in Terminal with inbox telnet client
|
Hi, I love the new Windows Terminal. I've manage to add my routers and switches to it but the only issue I have is that I can't scroll. Once I log into my switch using ssh, I can't seem to scroll up to see what's above. Kindly let me know how I can activate scrolling.
PS. scrolling works for regular CMD or PowerShell.
|
Help Wanted,Product-Conpty,Area-Output,Issue-Bug,Priority-2
|
medium
|
Critical
|
622,025,647 |
opencv
|
Please document custom neural net layers creation in python
|
Good day!
Please document argumens and return values for Python API for cv::dnn::Layer::getMemoryShapes (https://docs.opencv.org/master/d3/d6c/classcv_1_1dnn_1_1Layer.html#a3405ff43150088f3cc1d54f7e9b3ec29) and other involved methods.
I found an example of creating a custom layer in a Python in a tutorial (https://docs.opencv.org/master/dc/db1/tutorial_dnn_custom_layers.html), but there is no detailed information on input and output arguments of Python methods:
getMemoryShapes
forward
I am loading different TensorFlow frozen models to run them in speedy and mature opencv and sometimes it is needed to implement custom layers in python (as layers ane new and not implemented by opencv). API documentation on python methods for implementing custom dnn layers will help. Thank you!
|
category: documentation,category: dnn,Hackathon
|
low
|
Minor
|
622,036,783 |
terminal
|
Dev enhancement: Add IntelliCode Github Action
|
At MS Build, we discovered a new IntelliCode Github Action has been created. It only requires 2 lines in yaml to enable. Please get this set up to make contributing even easier using Visual Studio! (VS Code is also planned to be supported later).
|
Issue-Feature,Help Wanted,Area-Build,Product-Meta
|
low
|
Major
|
622,038,592 |
neovim
|
Set match priority lower than highlight
|
<!-- Before reporting: search existing issues and check the FAQ. -->
- `nvim --version`: v0.4.3
- `vim -u DEFAULTS` (version: ) behaves differently? No
- Operating system/version: NixOS 20.03
- Terminal name/version: Alacritty 0.5.0-dev
- `$TERM`: alacritty
### Steps to reproduce using `nvim -u NORC`
```
nvim -u NORC
:hi OverLength ctermbg=gray
:call matchadd('OverLength', '\%>80v.\+', -101)
:set spell
```
### Actual behaviour
Misspelled text in part of line longer than 80 characters is highlighted gray and indistinguishable from other text.
### Expected behaviour
Misspelled text in part of line longer than 80 characters is highlighted as a misspelled.
While a fix for this particular situation would be nice, in general, it should be possible to set any match priority lower than standard theme highlight priority. The (probably) easiest solution would be to give standard theme `hi` a priority value. Any `match` lower than that priority is overriden.
|
enhancement
|
low
|
Minor
|
622,066,527 |
PowerToys
|
[KBM] Remap Key to Mouse Click
|
Be nice if keyboard keys could be re-assigned to mouse keys. E.g. I like to use F1 to send a mouse left mouse click.
|
Idea-Enhancement,Product-Keyboard Shortcut Manager
|
high
|
Critical
|
622,091,468 |
react
|
Bug: React throws warning on browser default function
|
I'm receiving the following "Warning"
```
Warning: Use the `defaultValue` or `value` props on <select> instead of setting `selected` on <option>.
in option (created by styled.option)
in styled.option (created by Menu)
in select (created by styled.select)
in styled.select (created by Menu)
in div (created by styled.div)
in styled.div (created by Menu)
````
React version:
## Steps To Reproduce
1. create a select with options
```
return (<select>
<option>a</option>
<option selected>b</option>
</select>);
```
as usecase: the selected property is defined outside the state of the select component, it is set by navigating the site. As of now it is only a warning, so it works if I use this, but the customer whom I build the application, has strict standards, so as for this warning, it kills the audit of the application, even we stated that it is a React specific warning, not a standard, caused by some coding error.
2. see the warnning whowing up *RED* in your browser that a simple already built-in function of all browser if overriden and damned eternally.
Code does not have any outside dependencies.
## The current behavior
It throws the warning in development.
## The expected behavior
It is a standard behavior of all modern browsers, that you can tell the select dropdown or multiselect, that it has one ora other selected by code even from context.
This should not be a warning, as it is a w3c standard feature of the select dropdown. Please remove warnings and what-so-ever that you are forcing developers to do, to avoid using w3c standards.
|
Component: DOM,Type: Discussion
|
low
|
Critical
|
622,092,491 |
flutter
|
[desktop] Add support for mouse-position independent dragging
|

The gif shows a knob that, while being adjusted with a click and drag gesture, doesn't change the position of the mouse.
Such a feature is not only useful for games, but also for many UI applications such as sliders, infinite canvases, advanced text editor scrolling.
I don't see a way how this could be implemented right now without custom platform-dependent code.
|
c: new feature,framework,c: proposal,a: desktop,a: mouse,P3,team-framework,triaged-framework
|
low
|
Minor
|
622,099,655 |
PowerToys
|
[Run] Tab completion akin to omnibox search
|
Type keyword + tab = search completion in desired resource
If you use a chromium based browser then the omnibox is pretty cool. You assign a keyword to a search phrase, when you type the keyword + tab = search is completed in the search engine/application.
Example, type ebay+search term=result (handed off to default browser)


|
Idea-Enhancement,Product-PowerToys Run
|
low
|
Minor
|
622,112,943 |
flutter
|
InteractiveViewer should support rotation
|
I wrote InteractiveViewer in https://github.com/flutter/flutter/pull/56409 to support rotation, but I removed the feature to speed up development. I plan to revisit it and finish the rotation feature. The part that still needs work is how it interacts with boundaryMargin, and there is a TODO in the code explaining more and referencing this issue.
|
framework,c: proposal,P3,team-framework,triaged-framework
|
medium
|
Critical
|
622,155,624 |
flutter
|
Restructure Windows client wrapper creation error flow
|
Currently the engine is started in a window constructor, which means it doesn't return any status. Under the current wrapper+template, if starting the engine fails it will crash (trying to access into `view()`, which will be null).
We need a graceful way to handle errors, probably by pulling that step out of the constructor.
|
engine,platform-windows,a: desktop,P2,c: tech-debt,team-windows,triaged-windows
|
low
|
Critical
|
622,156,195 |
PowerToys
|
Settings sync
|
Ability to sync all settings to your MS account to enable similar experiences across multiple devices
**crutkas:**
closely related to [Backup and Restore PT Settings (import/export) #586](https://github.com/microsoft/PowerToys/issues/586)
|
Idea-Enhancement,Product-Settings
|
high
|
Critical
|
622,167,460 |
TypeScript
|
Type is not inferred in an if branch of a user-defined type guard when object is used for destructuring
|
<!-- π¨ STOP π¨ π¦π§π’π£ π¨ πΊπ»πΆπ· π¨
Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Even if you think you've found a *bug*, please read the FAQ first, especially the Common "Bugs" That Aren't Bugs section!
Please help us by doing the following steps before logging an issue:
* Search: https://github.com/Microsoft/TypeScript/search?type=Issues
* Read the FAQ: https://github.com/Microsoft/TypeScript/wiki/FAQ
Please fill in the *entire* template below.
-->
**TypeScript Version:** 3.9.2, v4.0.0-dev.20200519
<!-- Search terms you tried before logging this (so others can find this issue more easily) -->
**Search Terms:** type guard, destructuring, infer, if branch
**Expected behavior:**
Code compiles with no errors and inferred type of `withoutSymbols` is `{ [key: string]: TreeNode }`
**Actual behavior:**
Fails with `Rest types may only be created from object types.` error at line:
```ts
const { [VALUE]: value, [PARAM]: param, ...withoutSymbols } = node
```
To fix this, `node` variable should be cast to `TreeNode`:
```ts
const { [VALUE]: value, [PARAM]: param, ...withoutSymbols } = node as TreeNode
```
It seems redundant since this line of code is in the if branch of `isRootNode` type guard already.
**Code**
```ts
const VALUE: unique symbol = Symbol('value')
const PARAM: unique symbol = Symbol('param')
type RootTreeNode = {
[key: string]: TreeNode
}
type TreeNode = {
[VALUE]: string
[PARAM]?: RootTreeNode
[key: string]: TreeNode
}
function isRootNode(node: RootTreeNode | TreeNode): node is RootTreeNode {
return !(VALUE in node)
}
function filterSymbolsOut(node: RootTreeNode | TreeNode): RootTreeNode {
if (!isRootNode(node)) {
const { [VALUE]: value, [PARAM]: param, ...withoutSymbols } = node
return withoutSymbols
}
return node
}
```
<details><summary><b>Output</b></summary>
```ts
"use strict";
var __rest = (this && this.__rest) || function (s, e) {
var t = {};
for (var p in s) if (Object.prototype.hasOwnProperty.call(s, p) && e.indexOf(p) < 0)
t[p] = s[p];
if (s != null && typeof Object.getOwnPropertySymbols === "function")
for (var i = 0, p = Object.getOwnPropertySymbols(s); i < p.length; i++) {
if (e.indexOf(p[i]) < 0 && Object.prototype.propertyIsEnumerable.call(s, p[i]))
t[p[i]] = s[p[i]];
}
return t;
};
const VALUE = Symbol('value');
const PARAM = Symbol('param');
function isRootNode(node) {
return !(VALUE in node);
}
function filterSymbolsOut(node) {
if (!isRootNode(node)) {
const _a = node, _b = VALUE, value = _a[_b], _c = PARAM, param = _a[_c], withoutSymbols = __rest(_a, [typeof _b === "symbol" ? _b : _b + "", typeof _c === "symbol" ? _c : _c + ""]);
return withoutSymbols;
}
return node;
}
```
</details>
<details><summary><b>Compiler Options</b></summary>
```json
{
"compilerOptions": {
"noImplicitAny": true,
"strictNullChecks": true,
"strictFunctionTypes": true,
"strictPropertyInitialization": true,
"strictBindCallApply": true,
"noImplicitThis": true,
"noImplicitReturns": true,
"useDefineForClassFields": false,
"alwaysStrict": true,
"allowUnreachableCode": false,
"allowUnusedLabels": false,
"downlevelIteration": false,
"noEmitHelpers": false,
"noLib": false,
"noStrictGenericChecks": false,
"noUnusedLocals": false,
"noUnusedParameters": false,
"esModuleInterop": true,
"preserveConstEnums": false,
"removeComments": false,
"skipLibCheck": false,
"checkJs": false,
"allowJs": false,
"declaration": true,
"experimentalDecorators": false,
"emitDecoratorMetadata": false,
"target": "ES2017",
"module": "ESNext"
}
}
```
</details>
**Playground Link:** [Provided](https://www.typescriptlang.org/play/index.html#code/MYewdgzgLgBAagQQDIFUCiAuGBXMBLAR2wFMYIBPAWwCMQAbGAXhgGUra6AKAcgDcBDOiW4BKAFChIsAAoIASggCyWXIRJl29Jq01duAB34AnfpVFixUcvtJyQIKABUjxYgDkQAE1LMA3mJgYAG0Aa2JyLGgjPDAAcwBdLGdXD28xAF8LKxsYZPcvHxh-QKDEVDREsihouIDg2QVFeIB+LDsHPNTiOtDwyOqYhKSXfLTMsQAzXGAoPHAYPAh2qC7OMAK2+ycRrpgAH1ydgpEsde8FiBhlzoKiusCXKGwjMBgAQk4y9AXXs+JxcZTMAzOavCZ4OhQYhGNg0egQADy2Cgaw2Vy2N3OB0x-02HSO52KCwmME4b0Wy1WfxEIjugUCkmgRWCXwqWAEQmIABp6vIlJVDCZKDyAHRigDueCgAAsQMjYRxLultH97jBHs9XpKZXKoAr4XVMg9iE8XjBVZkgA)
|
Bug
|
low
|
Critical
|
622,172,469 |
PowerToys
|
[Feature Request] Long Screenshot Option
|
Many Browsers including Firefox and Several Mobile devices support Long Screenshot option wherein you can take a screenshot of a page that is scrollable. Windows Snip and Sketch is a great Screenshot tool with several useful features but it lacks this very useful feature. It will be quite a handy feature to have and will boost productivity when trying to share images of scrollable parts of an application thus saving one from copying from a document/webpage/app etc. Also, it would be great to have this work throughout Windows
Here's an example from Firefox:

U guys can draw inspiration from this software called [PicPick](https://picpick.app/en/)
|
Idea-New PowerToy
|
medium
|
Critical
|
622,187,070 |
godot
|
[Bullet] PhysicsServer.intersect_shape doesn't work with shapes that aren't centered
|
**Godot version:**
3.2.2 mono beta 2
**OS/device including version:**
MXLinux 19 64 bits
**Issue description:**
Intersect shape doesn't seem to handle shapes that aren't centered correctly, maybe I'm doing something wrong
**Steps to reproduce:**
Use intersect shape with a shape from a collision shape node that's not at the origin of its parent and pass the global transform of the shape node to the PhysicsShapeQueryParameters object.
**Minimal reproduction project:**
[3DPhysicsTest.zip](https://github.com/godotengine/godot/files/4660186/3DPhysicsTest.zip)
|
bug,confirmed,topic:physics
|
low
|
Minor
|
622,198,794 |
godot
|
[Bullet] Bullet physics breaks determinism when iterations_per_second is changed
|
**Godot version:**
3.2.2 beta 2
**OS/device including version:**
MXLinux 64 bits
**Issue description:**
I was making a 3D puzzle game where I had a slider to change how fast the simulation runs, the game was just using areas and discarding delta so iterations_per_second could be used to adjust the speed of the game, but this made the game simulate differently at different speeds. Changing the physics engine to Godot Physics seems to have fixed this for me.
**Steps to reproduce:**
Sorry can't really specify what was going on, but I think the areas weren't working consistently at different iterations per second.
|
bug,topic:physics
|
low
|
Major
|
622,201,390 |
TypeScript
|
Microsoft.TypeScript.Compiler
|
<!-- π¨ STOP π¨ π¦π§π’π£ π¨ πΊπ»πΆπ· π¨
Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker.
Please help us by doing the following steps before logging an issue:
* Search: https://github.com/Microsoft/TypeScript/search?type=Issues
* Read the FAQ, especially the "Common Feature Requests" section: https://github.com/Microsoft/TypeScript/wiki/FAQ
-->
## Search Terms
<!-- List of keywords you searched for before creating this issue. Write them down here so that others can find this suggestion more easily -->
Microsoft.TypeScript.Compiler
Microsoft.TypeScript.MSBuild
nuget
tsc.exe
standalone
## Suggestion
<!-- A summary of what you'd like to see added or changed -->
> Can you point me towards whatever used to be responsible for making this wrapped exe?
I was hoping to use this NuGet package for integration of TypeScript into a project which doesn't use Node,. The idea of having a self-contained NuGet package to let builds be reproduced in the future without Node installed as appealing to me, but I'm not super in tune with the JavaScript ecosystem in general so I wouldn't know where to begin on making my own self-contained exe like that. Plan B is to just throw Node and tsc.js into an internal NuGet package, but a self-maintained tsc.exe route seems more elegant if it isn't a huge ordeal.
--@PathogenDavid
This is a reopening of this issue #29689, which had outstanding questions.
In particular, as there environments out here that became dependant on the tsc.exe tooling which was optimal for us in producing TS code, how do we properly recreate the tool if it's not directly provided anymore?
Or perhaps more pointedly, the tsc build team had the ability to produce this before, would it be possible for them to keep the builds running? There would be a *great* deal of appreciation if that were the case.
## Use Cases
There are *many* projects out there are shipping or aim to ship some typescript _without_ accepting node as a dependency. Many build chains are heavy and fragile *already* without adding "the tool to build the tool". Even if we were to use package manager in our devops efforts, that would just get the tool (node) to build the tool (npm) to get and build the tool (tsc) to build *our code*....
(this shenanigans has actually prevented us from using some TS projects\libraries (that didn't have browser builds) as to not add *another* layer to the statement above)
:-|
## Examples
<!-- Show how this would be used and what the behavior would be -->
Should be:
```
C:\Users\Dev>tsc -v
Version 3.9.3
```
Is:
```
C:\Users\Dev>tsc -v
Version 3.1.5
```
## Checklist
My suggestion meets these guidelines:
* [X] This wouldn't be a breaking change in existing TypeScript/JavaScript code
* [X] This wouldn't change the runtime behavior of existing JavaScript code
* [X] This could be implemented without emitting different JS based on the types of the expressions
* [X] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
* [X] This feature would agree with the rest of [TypeScript's Design Goals](https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals). [10 sounds nice]
|
Visual Studio
|
low
|
Critical
|
622,205,284 |
bitcoin
|
Address cluster information on coin control window
|
I found it is very difficult to maintain privacy on my transactions because it is difficult to keep the address separated. I'm trying to prevent my addresses to cluster together, based on the following definition:
> Usually an adversary will try to link together multiple addresses which they believe belong to the same wallet. Such address collections are called "clusters", "closures" or "wallet clusters", and the activity of creating them is called "wallet clustering". ([source](https://en.bitcoin.it/wiki/Privacy#Blockchain_attacks_on_privacy))
While the coin control feature helps with that, it does not show all the transaction tree, listing just the coin sources.
I would like the coin control window display all the clustered addresses belonging to any given tree so I can chose better which coins to use.
### An example tree ###
Given the following transaction tree (where up-case letters are owned addresses)
```
a -> B
-> C -> e
|--> D
```
There are two UTXOs that can be spend: `B` and `D`, both are change addresses, within the coin-control I can see that the coins were received from `a`, but there is no mention of `e`, and that could be actually quite important, if for example `e` does know my name. That would allow for example, prioritizing those UTXO to send more money to `e`.
Could it be possible to add that information in the tree?
|
Feature,Wallet
|
low
|
Minor
|
622,206,348 |
deno
|
Codesign Deno binaries on Windows
|
I received an alert from the Avast antivirus during the upgrade of deno (from version 1.0.0 to version 1.0.1).
I ran the command 'deno upgrade' from the PowerShell terminal on Windows 10 SO.
The alert says that the deno.exe was infected with IDP.HELU.PSD11

|
build,windows
|
low
|
Minor
|
622,210,789 |
go
|
proposal: cmd/go: `go get` automatically add `replace` in go.mod
|
# Scenario
`B` repo fork from the `A` repo and `B` repo add some codes that `A` repo doesn't have.
Try to import `B` in `C` with go mod.
```bash
go get B
```
Go will compliant and refuse to import `B`.
```
module declares its path as: A
but was required as: B
```
-----
Because of `B` fork from `A`, it is no way to rename all the import paths which relevant to `A` since it will break the dependency.
And those users of `B` are painful to import `B` to their project, since `go get` refuse to import `B`, and they have to modify the `go.mod` by themselves.
For example:
```bash
go mod edit -replace A@latest=B@latest
```
It's like `B` is a second-class citizen.
# Proposal
I propose that `go get` can handle this scenario by add `replace` in `go.mod` and not refuse to import such repo.
Or maybe we can add a new flag `go get -r` to declare that the user wants to add a replacement explicitly.
Also, currently, `go get -u` refuse to upgrade `B` repo even we already add `replace` in `go.mod`. Therefore I think `go get -u` should respect this if this proposal passed.
|
Proposal,GoCommand,modules
|
low
|
Major
|
622,227,036 |
pytorch
|
Weight decay in AdamW
|
## π Bug
As the original paper(https://arxiv.org/pdf/1711.05101.pdf, green boxes) shows
<img width="604" alt="Screen Shot 2020-05-21 at 12 40 39 PM" src="https://user-images.githubusercontent.com/8815362/82520936-49782e00-9b60-11ea-869e-1d9e06bbea26.png">
the formula of applying weight decay to Adam should be
`\theta_t = (1 - \lambda) * \theta_{t - 1}` or
`\theta_t = (1 - {schedule multiplier} * \lambda) * \theta_{t - 1}`.
But, AdamW implementation in master branch (https://github.com/pytorch/pytorch/blob/master/torch/optim/adamw.py#L73) applies weight decay with learning rate.
`\theta_t = (1 - \lambda * {learning rate}) * \theta_{t - 1}`
## Expected behavior
I think this line(https://github.com/pytorch/pytorch/blob/a8d8fc553229731c2ca491fefe18ff977c7e8af0/torch/optim/adamw.py#L73) should be `p.mul_(1 - group['weight_decay'])`.
cc @vincentqb
|
module: optimizer,triaged
|
low
|
Critical
|
622,227,586 |
pytorch
|
Can't compile QuantizedOpKernels.cpp using gcc-9.3
|
## π Bug
Attempt to compile abovementioned source using gcc-9.3 from `pytorch-linux-bionic-py3.8-gcc9` fails with:
```
cd /var/lib/jenkins/workspace/build/caffe2 && /opt/cache/bin/sccache /opt/cache/bin/c++ -DAT_PARALLEL_OPENMP=1 -DCPUINFO_SUPPORTED_PLATFORM=1 -DFMT_HEADER_ONLY=1 -DFXDIV_USE_INLINE_ASSEMBLY=0 -DHAVE_MALLOC_USABLE_SIZE=1 -DHAVE_MMAP=1 -DHAVE_SHM_OPEN=1 -DHAVE_SHM_UNLINK=1 -DIDEEP_USE_MKL -DMINIZ_DISABLE_ZIP_READER_CRC32_CHECKS -DNNP_CONVOLUTION_ONLY=0 -DNNP_INFERENCE_ONLY=0 -DONNXIFI_ENABLE_EXT=1 -DONNX_ML=1 -DONNX_NAMESPACE=onnx_torch -DTH_BLAS_MKL -DTORCH_ENABLE_LLVM -DUSE_DISTRIBUTED -D_FILE_OFFSET_BITS=64 -Dtorch_cpu_EXPORTS -I/var/lib/jenkins/workspace/build/aten/src -I/var/lib/jenkins/workspace/aten/src -I/var/lib/jenkins/workspace/build -I/var/lib/jenkins/workspace -I/var/lib/jenkins/workspace/cmake/../third_party/benchmark/include -I/opt/llvm/include -I/var/lib/jenkins/workspace/build/caffe2/contrib/aten -I/var/lib/jenkins/workspace/third_party/onnx -I/var/lib/jenkins/workspace/build/third_party/onnx -I/var/lib/jenkins/workspace/third_party/foxi -I/var/lib/jenkins/workspace/build/third_party/foxi -I/var/lib/jenkins/workspace/caffe2/../torch/csrc/api -I/var/lib/jenkins/workspace/caffe2/../torch/csrc/api/include -I/var/lib/jenkins/workspace/caffe2/aten/src/TH -I/var/lib/jenkins/workspace/build/caffe2/aten/src/TH -I/var/lib/jenkins/workspace/caffe2/../torch/../aten/src -I/var/lib/jenkins/workspace/build/caffe2/aten/src -I/var/lib/jenkins/workspace/build/caffe2/../aten/src -I/var/lib/jenkins/workspace/build/caffe2/../aten/src/ATen -I/var/lib/jenkins/workspace/caffe2/../torch/csrc -I/var/lib/jenkins/workspace/caffe2/../torch/../third_party/miniz-2.0.8 -I/var/lib/jenkins/workspace/aten/src/TH -I/var/lib/jenkins/workspace/aten/../third_party/catch/single_include -I/var/lib/jenkins/workspace/aten/src/ATen/.. -I/var/lib/jenkins/workspace/build/caffe2/aten/src/ATen -I/var/lib/jenkins/workspace/third_party/miniz-2.0.8 -I/var/lib/jenkins/workspace/caffe2/core/nomnigraph/include -I/var/lib/jenkins/workspace/third_party/FXdiv/include -I/var/lib/jenkins/workspace/c10/.. -I/var/lib/jenkins/workspace/build/third_party/ideep/mkl-dnn/include -I/var/lib/jenkins/workspace/third_party/ideep/mkl-dnn/src/../include -I/var/lib/jenkins/workspace/third_party/cpuinfo/include -I/var/lib/jenkins/workspace/third_party/QNNPACK/include -I/var/lib/jenkins/workspace/third_party/pthreadpool/include -I/var/lib/jenkins/workspace/aten/src/ATen/native/quantized/cpu/qnnpack/include -I/var/lib/jenkins/workspace/aten/src/ATen/native/quantized/cpu/qnnpack/src -I/var/lib/jenkins/workspace/third_party/cpuinfo/deps/clog/include -I/var/lib/jenkins/workspace/third_party/NNPACK/include -I/var/lib/jenkins/workspace/third_party/fbgemm/include -I/var/lib/jenkins/workspace/third_party/fbgemm -I/var/lib/jenkins/workspace/third_party/fbgemm/third_party/asmjit/src -I/var/lib/jenkins/workspace/third_party/FP16/include -I/var/lib/jenkins/workspace/third_party/tensorpipe -I/var/lib/jenkins/workspace/third_party/fmt/include -isystem /var/lib/jenkins/workspace/build/third_party/gloo -isystem /var/lib/jenkins/workspace/cmake/../third_party/gloo -isystem /var/lib/jenkins/workspace/cmake/../third_party/googletest/googlemock/include -isystem /var/lib/jenkins/workspace/cmake/../third_party/googletest/googletest/include -isystem /var/lib/jenkins/workspace/third_party/protobuf/src -isystem /opt/conda/include -isystem /var/lib/jenkins/workspace/third_party/gemmlowp -isystem /var/lib/jenkins/workspace/third_party/neon2sse -isystem /var/lib/jenkins/workspace/third_party/XNNPACK/include -isystem /var/lib/jenkins/workspace/third_party -isystem /var/lib/jenkins/workspace/cmake/../third_party/eigen -isystem /opt/conda/include/python3.8 -isystem /opt/conda/lib/python3.8/site-packages/numpy/core/include -isystem /var/lib/jenkins/workspace/cmake/../third_party/pybind11/include -isystem /var/lib/jenkins/workspace/third_party/ideep/mkl-dnn/include -isystem /var/lib/jenkins/workspace/third_party/ideep/include -isystem /var/lib/jenkins/workspace/build/include -Wno-deprecated -fvisibility-inlines-hidden -fopenmp -DNDEBUG -DUSE_FBGEMM -DUSE_QNNPACK -DUSE_PYTORCH_QNNPACK -DUSE_XNNPACK -DUSE_INTERNAL_THREADPOOL_IMPL -O2 -fPIC -Wno-narrowing -Wall -Wextra -Werror=return-type -Wno-missing-field-initializers -Wno-type-limits -Wno-array-bounds -Wno-unknown-pragmas -Wno-sign-compare -Wno-unused-parameter -Wno-unused-variable -Wno-unused-function -Wno-unused-result -Wno-unused-local-typedefs -Wno-strict-overflow -Wno-strict-aliasing -Wno-error=deprecated-declarations -Wno-stringop-overflow -Wno-error=pedantic -Wno-error=redundant-decls -Wno-error=old-style-cast -fdiagnostics-color=always -faligned-new -Werror -Wno-unused-but-set-variable -Wno-maybe-uninitialized -fno-math-errno -fno-trapping-math -Werror=format -Wno-stringop-overflow -DHAVE_AVX_CPU_DEFINITION -DHAVE_AVX2_CPU_DEFINITION -O3 -DNDEBUG -DNDEBUG -fPIC -DCAFFE2_USE_GLOO -DHAVE_GCC_GET_CPUID -DUSE_AVX -DUSE_AVX2 -DTH_HAVE_THREAD -Wall -Wextra -Wno-unused-parameter -Wno-missing-field-initializers -Wno-write-strings -Wno-unknown-pragmas -Wno-missing-braces -Wno-maybe-uninitialized -Werror -Wno-strict-overflow -fvisibility=hidden -O2 -DCAFFE2_BUILD_MAIN_LIB -pthread -DASMJIT_STATIC -std=gnu++14 -O3 -mavx2 -mfma -mno-avx256-split-unaligned-load -mno-avx256-split-unaligned-store -DCPU_CAPABILITY=AVX2 -DCPU_CAPABILITY_AVX2 -o CMakeFiles/torch_cpu.dir/__/aten/src/ATen/native/quantized/cpu/kernels/QuantizedOpKernels.cpp.AVX2.cpp.o -c /var/lib/jenkins/workspace/build/aten/src/ATen/native/quantized/cpu/kernels/QuantizedOpKernels.cpp.AVX2.cpp
/var/lib/jenkins/workspace/build/aten/src/ATen/native/quantized/cpu/kernels/QuantizedOpKernels.cpp.AVX2.cpp: In instantiation of 'void at::native::{anonymous}::qadd_scalar_kernel(at::Tensor&, const at::Tensor&, c10::Scalar) [with bool ReLUFused = false]':
/var/lib/jenkins/workspace/build/aten/src/ATen/native/quantized/cpu/kernels/QuantizedOpKernels.cpp.AVX2.cpp:2327:1: required from here
/var/lib/jenkins/workspace/build/aten/src/ATen/native/quantized/cpu/kernels/QuantizedOpKernels.cpp.AVX2.cpp:837:16: error: implicitly-declared 'constexpr at::vec256::{anonymous}::Vec256<c10::qint8>& at::vec256::{anonymous}::Vec256<c10::qint8>::operator=(const at::vec256::{anonymous}::Vec256<c10::qint8>&)' is deprecated [-Werror=deprecated-copy]
837 | rv = rv.maximum(Vec(static_cast<scalar_t>(zero_point)));
| ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/var/lib/jenkins/workspace/aten/src/ATen/Dispatch.h:34:12: note: in definition of macro 'AT_QINT_PRIVATE_CASE_TYPE'
34 | return __VA_ARGS__(); \
| ^~~~~~~~~~~
```
cc @malfet
|
module: build,triaged
|
low
|
Critical
|
622,228,029 |
PowerToys
|
[KBM] Remapped key remains actively when changing to Japanese IME
|
<!--
**Important: When reporting BSODs or security issues, DO NOT attach memory dumps, logs, or traces to Github issues**.
Instead, send dumps/traces to [email protected], referencing this GitHub issue.
-->
# Environment
```
Windows build number: Microsoft Windows [Version 10.0.18363.836]
PowerToys version: v0.18.0
PowerToy module for which you are reporting the bug (if applicable): Keyboard Manager
```
# Steps to reproduce
<!-- A description of how to trigger this bug. -->
1. In Keyboard Manager, map <kbd>Caps Lock</kbd> key to <kbd>Ctrl (Left)</kbd> key
2. Changing keyboard IME from English (US) to Japanese
3. Enter some Japanese characters
4. Copy some text by using <kbd>Caps Lock + C</kbd> key
5. Press whatever keys, the <kbd>Caps Lock</kbd> key is remained actively
6. Need to go back to English IME and press <kbd>Caps Lock</kbd> key again to release
# Expected behavior
<!-- A description of what you're expecting, possibly containing screenshots or reference material. -->
Remapped key does not remains actively. Pressing some keys like <kbd>s</kbd> will input `s` character.
# Actual behavior
<!-- What's actually happening? -->
<kbd>Caps Lock</kbd> key remains actively. Pressing <kbd>s</kbd> will show Save Dialog
# Screenshots
<!-- If applicable, add screenshots to help explain your problem. -->
No need to attach screenshots
|
Help Wanted,Product-Keyboard Shortcut Manager,Priority-1
|
medium
|
Critical
|
622,228,221 |
pytorch
|
Can not compile GridSamplerKernel.cpp with gcc-9.3
|
Attempt to compile abovementioned source using gcc-9.3 from pytorch-linux-bionic-py3.8-gcc9 fails with:
```
cd /var/lib/jenkins/workspace/build/caffe2 && /opt/cache/bin/sccache /opt/cache/bin/c++ -DAT_PARALLEL_OPENMP=1 -DCPUINFO_SUPPORTED_PLATFORM=1 -DFMT_HEADER_ONLY=1 -DFXDIV_USE_INLINE_ASSEMBLY=0 -DHAVE_MALLOC_USABLE_SIZE=1 -DHAVE_MMAP=1 -DHAVE_SHM_OPEN=1 -DHAVE_SHM_UNLINK=1 -DIDEEP_USE_MKL -DMINIZ_DISABLE_ZIP_READER_CRC32_CHECKS -DNNP_CONVOLUTION_ONLY=0 -DNNP_INFERENCE_ONLY=0 -DONNXIFI_ENABLE_EXT=1 -DONNX_ML=1 -DONNX_NAMESPACE=onnx_torch -DTH_BLAS_MKL -DTORCH_ENABLE_LLVM -DUSE_DISTRIBUTED -D_FILE_OFFSET_BITS=64 -Dtorch_cpu_EXPORTS -I/var/lib/jenkins/workspace/build/aten/src -I/var/lib/jenkins/workspace/aten/src -I/var/lib/jenkins/workspace/build -I/var/lib/jenkins/workspace -I/var/lib/jenkins/workspace/cmake/../third_party/benchmark/include -I/opt/llvm/include -I/var/lib/jenkins/workspace/build/caffe2/contrib/aten -I/var/lib/jenkins/workspace/third_party/onnx -I/var/lib/jenkins/workspace/build/third_party/onnx -I/var/lib/jenkins/workspace/third_party/foxi -I/var/lib/jenkins/workspace/build/third_party/foxi -I/var/lib/jenkins/workspace/caffe2/../torch/csrc/api -I/var/lib/jenkins/workspace/caffe2/../torch/csrc/api/include -I/var/lib/jenkins/workspace/caffe2/aten/src/TH -I/var/lib/jenkins/workspace/build/caffe2/aten/src/TH -I/var/lib/jenkins/workspace/caffe2/../torch/../aten/src -I/var/lib/jenkins/workspace/build/caffe2/aten/src -I/var/lib/jenkins/workspace/build/caffe2/../aten/src -I/var/lib/jenkins/workspace/build/caffe2/../aten/src/ATen -I/var/lib/jenkins/workspace/caffe2/../torch/csrc -I/var/lib/jenkins/workspace/caffe2/../torch/../third_party/miniz-2.0.8 -I/var/lib/jenkins/workspace/aten/src/TH -I/var/lib/jenkins/workspace/aten/../third_party/catch/single_include -I/var/lib/jenkins/workspace/aten/src/ATen/.. -I/var/lib/jenkins/workspace/build/caffe2/aten/src/ATen -I/var/lib/jenkins/workspace/third_party/miniz-2.0.8 -I/var/lib/jenkins/workspace/caffe2/core/nomnigraph/include -I/var/lib/jenkins/workspace/third_party/FXdiv/include -I/var/lib/jenkins/workspace/c10/.. -I/var/lib/jenkins/workspace/build/third_party/ideep/mkl-dnn/include -I/var/lib/jenkins/workspace/third_party/ideep/mkl-dnn/src/../include -I/var/lib/jenkins/workspace/third_party/cpuinfo/include -I/var/lib/jenkins/workspace/third_party/QNNPACK/include -I/var/lib/jenkins/workspace/third_party/pthreadpool/include -I/var/lib/jenkins/workspace/aten/src/ATen/native/quantized/cpu/qnnpack/include -I/var/lib/jenkins/workspace/aten/src/ATen/native/quantized/cpu/qnnpack/src -I/var/lib/jenkins/workspace/third_party/cpuinfo/deps/clog/include -I/var/lib/jenkins/workspace/third_party/NNPACK/include -I/var/lib/jenkins/workspace/third_party/fbgemm/include -I/var/lib/jenkins/workspace/third_party/fbgemm -I/var/lib/jenkins/workspace/third_party/fbgemm/third_party/asmjit/src -I/var/lib/jenkins/workspace/third_party/FP16/include -I/var/lib/jenkins/workspace/third_party/tensorpipe -I/var/lib/jenkins/workspace/third_party/fmt/include -isystem /var/lib/jenkins/workspace/build/third_party/gloo -isystem /var/lib/jenkins/workspace/cmake/../third_party/gloo -isystem /var/lib/jenkins/workspace/cmake/../third_party/googletest/googlemock/include -isystem /var/lib/jenkins/workspace/cmake/../third_party/googletest/googletest/include -isystem /var/lib/jenkins/workspace/third_party/protobuf/src -isystem /opt/conda/include -isystem /var/lib/jenkins/workspace/third_party/gemmlowp -isystem /var/lib/jenkins/workspace/third_party/neon2sse -isystem /var/lib/jenkins/workspace/third_party/XNNPACK/include -isystem /var/lib/jenkins/workspace/third_party -isystem /var/lib/jenkins/workspace/cmake/../third_party/eigen -isystem /opt/conda/include/python3.8 -isystem /opt/conda/lib/python3.8/site-packages/numpy/core/include -isystem /var/lib/jenkins/workspace/cmake/../third_party/pybind11/include -isystem /var/lib/jenkins/workspace/third_party/ideep/mkl-dnn/include -isystem /var/lib/jenkins/workspace/third_party/ideep/include -isystem /var/lib/jenkins/workspace/build/include -Wno-deprecated -fvisibility-inlines-hidden -fopenmp -DNDEBUG -DUSE_FBGEMM -DUSE_QNNPACK -DUSE_PYTORCH_QNNPACK -DUSE_XNNPACK -DUSE_INTERNAL_THREADPOOL_IMPL -O2 -fPIC -Wno-narrowing -Wall -Wextra -Werror=return-type -Wno-missing-field-initializers -Wno-type-limits -Wno-array-bounds -Wno-unknown-pragmas -Wno-sign-compare -Wno-unused-parameter -Wno-unused-variable -Wno-unused-function -Wno-unused-result -Wno-unused-local-typedefs -Wno-strict-overflow -Wno-strict-aliasing -Wno-error=deprecated-declarations -Wno-stringop-overflow -Wno-error=pedantic -Wno-error=redundant-decls -Wno-error=old-style-cast -fdiagnostics-color=always -faligned-new -Werror -Wno-unused-but-set-variable -Wno-maybe-uninitialized -fno-math-errno -fno-trapping-math -Werror=format -Wno-stringop-overflow -DHAVE_AVX_CPU_DEFINITION -DHAVE_AVX2_CPU_DEFINITION -O3 -DNDEBUG -DNDEBUG -fPIC -DCAFFE2_USE_GLOO -DHAVE_GCC_GET_CPUID -DUSE_AVX -DUSE_AVX2 -DTH_HAVE_THREAD -Wall -Wextra -Wno-unused-parameter -Wno-missing-field-initializers -Wno-write-strings -Wno-unknown-pragmas -Wno-missing-braces -Wno-maybe-uninitialized -Werror -Wno-strict-overflow -fvisibility=hidden -O2 -DCAFFE2_BUILD_MAIN_LIB -pthread -DASMJIT_STATIC -std=gnu++14 -O3 -DCPU_CAPABILITY=DEFAULT -DCPU_CAPABILITY_DEFAULT -o CMakeFiles/torch_cpu.dir/__/aten/src/ATen/native/cpu/GridSamplerKernel.cpp.DEFAULT.cpp.o -c /var/lib/jenkins/workspace/build/aten/src/ATen/native/cpu/GridSamplerKernel.cpp.DEFAULT.cpp
/var/lib/jenkins/workspace/aten/src/ATen/cpu/vec256/vec256_base.h:696:19: error: '*((void*)& grad_clip +8)' is used uninitialized in this function [-Werror=uninitialized]
/var/lib/jenkins/workspace/aten/src/ATen/cpu/vec256/vec256_base.h:696:19: error: '*((void*)& grad_clip +16)' is used uninitialized in this function [-Werror=uninitialized]
/var/lib/jenkins/workspace/aten/src/ATen/cpu/vec256/vec256_base.h:696:19: error: '*((void*)& grad_clip +24)' is used uninitialized in this function [-Werror=uninitialized]
/var/lib/jenkins/workspace/aten/src/ATen/cpu/vec256/vec256_base.h: In member function 'std::pair<at::vec256::{anonymous}::Vec256<T>, at::vec256::{anonymous}::Vec256<T> > at::native::{anonymous}::ComputeLocation<scalar_t, at::native::detail::GridSamplerPadding::Reflection, align_corners>::apply_get_grad(const Vec&) const [with scalar_t = float; bool align_corners = false]':
/var/lib/jenkins/workspace/aten/src/ATen/cpu/vec256/vec256_base.h:696:19: error: 'grad_clip' is used uninitialized in this function [-Werror=uninitialized]
696 | buffer[i] = op(a_ptr[i], b_ptr[i]);
| ~~^~~~~~~~~~~~~~~~~~~~
/var/lib/jenkins/workspace/aten/src/ATen/cpu/vec256/vec256_base.h:696:19: error: '*((void*)& grad_clip +16)' is used uninitialized in this function [-Werror=uninitialized]
/var/lib/jenkins/workspace/aten/src/ATen/cpu/vec256/vec256_base.h: In function 'void at::native::{anonymous}::ApplyGridSample<scalar_t, 2, at::native::detail::GridSamplerInterpolation::Bilinear, padding, align_corners>::backward(at::TensorAccessor<scalar_t, 3>&, at::TensorAccessor<scalar_t, 3>&, const at::TensorAccessor<scalar_t, 3>&, const at::TensorAccessor<scalar_t, 3>&, int64_t, const Vec&, const Vec&, int64_t) const [with scalar_t = double; at::native::detail::GridSamplerPadding padding = at::native::detail::GridSamplerPadding::Border; bool align_corners = false]':
/var/lib/jenkins/workspace/aten/src/ATen/cpu/vec256/vec256_base.h:696:19: error: 'grad_clip' is used uninitialized in this function [-Werror=uninitialized]
696 | buffer[i] = op(a_ptr[i], b_ptr[i]);
```
cc @malfet
|
module: build,triaged
|
low
|
Critical
|
622,244,581 |
create-react-app
|
please alert users on symlink to external src folders
|
### Is your proposal related to a problem?
I had a bunch of my-apps and tried to create a symlink to an external common components folder.
project->sharedcomponents
project->my-app1->src->components (symlink to upper sharedcomponents)
project->my-app2->src->components (symlink to upper sharedcomponents)
```npm start``` error text sent me to a rat hole based on [classProperty](https://stackoverflow.com/questions/52237855/support-for-the-experimental-syntax-classproperties-isnt-currently-enabled/61927054#61927054) not enabled
### Describe the solution you'd like
maybe detecting symlinks and ending with an ERROR message with a clear text/reason why symlink to external folder won't be processed.
### Describe alternatives you've considered
bit.dev seems overengineering for this, I'd love to "mount" an external folder in src somehow and without a complex apparatus of new repos / new published components etc. Another alternative would be just allow symlinks and process them seamlessly.
### Additional context
|
issue: proposal,needs triage
|
low
|
Critical
|
622,259,894 |
go
|
cmd/pprof: use netrc for user/password authentication
|
### What version of Go are you using (`go version`)?
<pre>
$ go version
go version go1.14.2 darwin/amd64
</pre>
### Does this issue reproduce with the latest release?
Yes.
### What operating system and processor architecture are you using (`go env`)?
<details><summary><code>go env</code> Output</summary><br><pre>
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/prashant/Library/Caches/go-build"
GOENV="/Users/prashant/Library/Application Support/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOINSECURE=""
GONOPROXY=""
GONOSUMDB=""
GOOS="darwin"
GOPATH="/Users/prashant/gocode"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/Cellar/go/1.14.2_1/libexec"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/Cellar/go/1.14.2_1/libexec/pkg/tool/darwin_amd64"
GCCGO="gccgo"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/db/_9qlqsfd5zbckpmfx7jbkpr80000gn/T/go-build663148624=/tmp/go-build -gno-record-gcc-switches -fno-common"
</pre></details>
### What did you do?
Use `go tool pprof` to fetch a profile from an internal site that is protected behind auth. Authentication information is written to `~/.netrc` and `curl -n <url>` works fine. Since Go supports netrc for getting modules, it would be great if pprof could similarly support netrc files.
### What did you expect to see?
go tool pprof to use authentication information from `~/.netrc`.
### What did you see instead?
401, as the user/information is not used.
|
NeedsInvestigation,FeatureRequest,compiler/runtime
|
low
|
Critical
|
622,274,437 |
flutter
|
Refactor SemanticsUpdateBuilder.updateNode to support defaults
|
[SemanticsUpdateBuilder.updateNode()](https://github.com/flutter/engine/blob/48d7091649fe975122ce30478f2fc71def298cd5/lib/ui/semantics.dart#L691) currently expects that all of its parameters be set despite the fact that it's not a native call. We should consider applying most of the defaulting we do in [`lib/src/semantics/semantics.dart`](https://github.com/flutter/flutter/blob/1d407de925c395e8e4e8712fb2f4f90712702600/packages/flutter/lib/src/semantics/semantics.dart#L2063) on the dart:ui side.
Current updateNode definition:
```
void updateNode({
/*required*/ int/*!*/ id,
/*required*/ int/*!*/ flags,
/*required*/ int/*!*/ actions,
/*required*/ int/*!*/ maxValueLength,
/*required*/ int/*!*/ currentValueLength,
/*required*/ int/*!*/ textSelectionBase,
/*required*/ int/*!*/ textSelectionExtent,
/*required*/ int/*!*/ platformViewId,
/*required*/ int/*!*/ scrollChildren,
/*required*/ int/*!*/ scrollIndex,
/*required*/ double/*!*/ scrollPosition,
/*required*/ double/*!*/ scrollExtentMax,
/*required*/ double/*!*/ scrollExtentMin,
/*required*/ double/*!*/ elevation,
/*required*/ double/*!*/ thickness,
/*required*/ Rect/*!*/ rect,
/*required*/ String/*!*/ label,
/*required*/ String/*!*/ hint,
/*required*/ String/*!*/ value,
/*required*/ String/*!*/ increasedValue,
/*required*/ String/*!*/ decreasedValue,
TextDirection/*?*/ textDirection,
/*required*/ Float64List/*!*/ transform,
/*required*/ Int32List/*!*/ childrenInTraversalOrder,
/*required*/ Int32List/*!*/ childrenInHitTestOrder,
/*required*/ Int32List/*!*/ additionalActions,
}) {
```
Current framework defaulting at the call site:
```
builder.updateNode(
id: id,
flags: data.flags,
actions: data.actions,
rect: data.rect,
label: data.label,
value: data.value,
decreasedValue: data.decreasedValue,
increasedValue: data.increasedValue,
hint: data.hint,
textDirection: data.textDirection,
textSelectionBase: data.textSelection != null ? data.textSelection.baseOffset : -1,
textSelectionExtent: data.textSelection != null ? data.textSelection.extentOffset : -1,
platformViewId: data.platformViewId ?? -1,
maxValueLength: data.maxValueLength ?? -1,
currentValueLength: data.currentValueLength ?? -1,
scrollChildren: data.scrollChildCount ?? 0,
scrollIndex: data.scrollIndex ?? 0 ,
scrollPosition: data.scrollPosition ?? double.nan,
scrollExtentMax: data.scrollExtentMax ?? double.nan,
scrollExtentMin: data.scrollExtentMin ?? double.nan,
transform: data.transform?.storage ?? _kIdentityTransform,
elevation: data.elevation,
thickness: data.thickness,
childrenInTraversalOrder: childrenInTraversalOrder,
childrenInHitTestOrder: childrenInHitTestOrder,
additionalActions: customSemanticsActionIds ?? _kEmptyCustomSemanticsActionsList,
);
```
|
team,engine,a: accessibility,P2,team-engine,triaged-engine
|
low
|
Minor
|
622,279,040 |
PowerToys
|
[Image Resizer] Add NoCrop
|
# Summary of the new feature/enhancement
Currently the only options when trying to resize an image for a different aspect ratio are fit, fill and stretch. Fit is the only option that preserves the aspect ratio. When I choose fit, it does not render the picture to the exact dimensions and only reduces the image until both height and width just fit inside the specified dimensions (i.e no bars are added on sides to make the dimension correct). An use case scenario would when an user is trying to export a screenshot for posting on Instagram stories, where the pictures need to be in 16:9 (portrait) ratio.
# Proposed technical implementation details (optional)
When resizing an image for a different aspect ratio while 'fit' is selected, ask whether a canvas (bars) is required. The larger The background colour of the bars could also be changed, optionally.
So if I have an image that's 1080x720 and I want to upload it to IG stories, I can choose image resizer -> (fit, 720x1080, uncheck ignore the orientation of pictures) -> The choose use fill canvas and choose the background color -> Resize
|
Idea-Enhancement,Product-Image Resizer
|
low
|
Major
|
622,306,465 |
PowerToys
|
[Run] Support commands and parameters / arguments
|
# Summary of the new feature/enhancement
Support running commands, utilities with parameters.
<!--
-->
The older run box supports commands and parameters to be used in cases like this:
- cmd /k [your command here]
- ssh [email protected]
- runas.exe .......
- wt (Launch Windows Terminal)
- ping [server_address_here]
and more!
Could you please allow commands to be used with their optional parameters? Like the old run box did ?

|
Issue-Bug,Product-PowerToys Run,Run-Plugin
|
medium
|
Critical
|
622,328,613 |
PowerToys
|
[FZ Editor] Undo / Redo keybinding
|
# Summary of the new feature/enhancement
I would like to undo (ctrl-z) and redo (ctrl-y) on Fancy Zones Editor.
# Proposed technical implementation details
Here's sample (not tested) C# class for handling ctrl-z/y.
```csharp
class ChangeHistory<T> {
private int _currentIndex = -1;
private List<T> _history = new List<T>();
public int CurrentIndex => _currentIndex;
public T CurrentState => _currentIndex >= 0 ? _history[_currentIndex] : default;
// Save state
public void Push(T state) {
if (_currentIndex < _history.Count - 1) {
_history.RemoveRange(_currentIndex + 1, _history.Count - _currentIndex - 1);
}
_history.Add(state);
}
// Ctrl - Z
public void Pop() {
if (_currentIndex > 0) _currentIndex--;
}
// Ctrl - Y
public void Next() {
if (_currentIndex < _history.Count - 1) _currentIndex++;
}
}
```
|
Idea-Enhancement,FancyZones-Editor,Product-FancyZones
|
low
|
Minor
|
622,352,566 |
terminal
|
incorrect tooltips on 'more' button
|
# Environment
Platform | ServicePack | Version | VersionString
-| -|-|-
Win32NT | 10.0.18363.0 | Microsoft Windows NT| 10.0.18363.0
# Steps to reproduce
<!-- A description of how to trigger this bug. -->
1. hover on 'new' button
2. hover on 'more' button
3. both buttons have same tooltips named 'New Tab'
# Expected behavior
'more' button has different tooltips from 'new' button
<!-- A description of what you're expecting, possibly containing screenshots or reference material. -->
# Actual behavior
'more' button has same tooltips as 'new' button


|
Help Wanted,Issue-Bug,Area-UserInterface,Product-Terminal,Priority-3,Tracking-External
|
low
|
Critical
|
622,357,039 |
opencv
|
imwrite and imencode flag for RGB data
|
##### System information (version)
- OpenCV => 4.2
- Operating System / Platform => Ubuntu 18.04
- Compiler =>gcc 7.5
Is it possible to add a flag for the functions that assume that the data is BGR such that it can be told what's the data format?
For example I have a bigger RGB image 6336*125 and to convert it to BGR takes almost 3 ms on a Skylake CPU such that I can feed it to imwrite() or imencode() functions. For systems that have soft real time constrains this is a huge problem, not to mention that the fact that opencv is stuck with the legacy BGR format is a design issue that should be tackeld sooner or later instead of wasting unnecessary CPU cycles.
|
feature,priority: low,category: imgcodecs
|
low
|
Minor
|
622,368,893 |
pytorch
|
[JIT] named_(parameters | buffers) do not support recursive iteration.
|
Pointed out by @zdevito on GH-38849.
cc @suo
|
oncall: jit,triaged
|
low
|
Minor
|
622,392,703 |
PowerToys
|
[PowerToys Run] Start customizable web search from run
|
# Summary of the new feature/enhancement
## In short
I'd like to see the features of the `Webby` plugin in [Launchy](https://www.launchy.net) being available in `run`.
## In long
Allow starting web searches directly from the `run` tool by entering some search target + a search term and pressing enter.
I could imagine using some special character like `>` for shell plugin here as well.
This could look something like this (just an idea):
* The term `# ddg powertoys` should open the URL https://duckduckgo.com/?q=powertoys in my default browser
+ `#` -> Websearch
+ `ddg` -> The search target, `duckduckgo` here.
+ `powertoys` -> The search term
The mapping `search target` -> `url` should be freely configurable. E.g. in launchy I use the following:
* `dict` -> `https://dict.cc?s=%1`
* `dictesp` -> `https://dict.leo.org/esde?lp=esde&lang=de&search=%1`
* `ddg` -> `https://duckduckgo.com/?q=%1`
* `mdn` -> `https://developer.mozilla.org/en-US/search?q=%1`
* ...
This should also work without a search term & URI params to simply make URLs available via `run`:
* `Notion` -> `https://www.notion.so/`
|
Idea-Enhancement,Product-PowerToys Run
|
medium
|
Critical
|
622,401,281 |
PowerToys
|
[Run] Copy path also for other result-types
|
# Summary of the new feature/enhancement
The doc for Ctrl+C says "(Only applicable to folders and files)". It would be useful if that was also possible for applications, i.e. "type wo", Word appears, press Ctrl+C to get path of executable into clipboard.
|
Idea-Enhancement,Product-PowerToys Run
|
low
|
Minor
|
622,405,120 |
deno
|
OffscreenCanvas and CanvasRenderingContext2D
|
#1629 is about WebGL, it will likely take a lot of time to implement.
I think add **OffscreenCanvas & CanvasRenderingContext2D** interface at first is a good idea for now.
A lot of server-side image process like [shields.io](https://shields.io) can be done in OffscreenCanvas with 2d renderer
(and it should be able to load image from disk / web / memory.)
* Maybe render text will be a problem
Read from ttf directly? <- so we need a FontFace api with local file support
Use system font registry?
|
cli,suggestion
|
medium
|
Critical
|
622,446,292 |
PowerToys
|
[Run][Shell Plugin] Delete commands from history
|
# PowerToys Run should let the user delete certain commands.
I am loving the new PowerToys Run (previously known as Windows Walker with less functionalities), especially it's Shell Plugin invoking feature, I am experimenting with it and as a result, there are a lot of non-functional commands. I want to have them removed so that the commands history is more concise and easier to manage. Basically I want to have the history behave like bookmarks for commands.
For example:

This is my commands history. As you can see there are 3 nearly-identical commands and only 1 out of 3 works. If the other 2 can be removed, I can quickly navigate to the correct one without having to read it carefully.
I think using the Delete key to remove the current selected command is reasonable.
|
Idea-Enhancement,Product-PowerToys Run,Run-Plugin
|
low
|
Major
|
622,457,213 |
deno
|
Support Raw Sockets and Datalinks (Layer 3/2)
|
Since UDP and Unix sockets are implemented, and since Deno is now released, we could plan to add raw sockets (layer 3) and datalink (layer 2) support.
Tokio does not implement them, but I found some methods in [tokio/mio](https://github.com/tokio-rs/mio)
- https://github.com/tokio-rs/mio/blob/master/src/sys/unix/net.rs
- https://github.com/tokio-rs/mio/blob/master/src/sys/windows/net.rs
These methods are syscalls to [socket](http://man7.org/linux/man-pages/man2/socket.2.html)
We can use them with the domain `AF_INET` or `AF_INET6` (for IP packets) or `AF_PACKET` (for datalink packets) and the type `SOCK_RAW` in order to add the features to tokio/mio and then to deno
Otherwise, we could use [libpnet](https://github.com/libpnet/libpnet/), which already implements the features, but may not be as good as Tokio
|
cli,suggestion
|
low
|
Minor
|
622,476,130 |
PowerToys
|
[FancyZones] Detect Minimum Window Width
|
<!--
**Important: When reporting BSODs or security issues, DO NOT attach memory dumps, logs, or traces to Github issues**.
Instead, send dumps/traces to [email protected], referencing this GitHub issue.
-->
# Environment
```
Windows build number: 10.0.19041.264
PowerToys version: 0.18.0
PowerToy module for which you are reporting the bug (if applicable): Fancy Zones
```
# Steps to reproduce
When working with a window that has a fixed minimum width, the window snaps to a zone such that part of the window is hidden. For example, I am using the application MobaXTerm for work. This application has a minimum window width, which is narrower than the zone width. I have set up Fancy Zones such that it uses the default three-zone vertical layout. If I snap the window to the leftmost or center zones, there is no problem. However, if I snap the window to the rightmost zone, the right side of the window is cut off by the edge of the screen. (Note: this is more of a minor annoyance than anything that will keep me from using the program.)
# Expected behavior
Snap the window to the right side of the zone, not the left. Overlap between the right zone and the center can be allowed.

# Actual behavior
See description and screenshots. The right edge of the window is being clipped when snapped to the rightmost zone.
# Screenshots
Fancy Zones Layout

No problems with window clipping on left side

Right edge of window clipped

|
Idea-Enhancement,Help Wanted,Product-FancyZones
|
low
|
Critical
|
622,499,490 |
PowerToys
|
[Run][New Plugin] Searching emails
|
# Summary of the new feature/enhancement
It would be nice being able to search through your mails in PowerToys run. Mails should show up as search results just like files.
# Proposed technical implementation details (optional)
If possible PowerToys could integrate directly with Windows Mail so that you don't need to handle the mail fetching and the accounts.
|
Idea-Enhancement,Product-PowerToys Run,Run-Plugin
|
low
|
Major
|
622,502,593 |
youtube-dl
|
sejm.gov.pl/senat.gov.pl support
|
<!--
######################################################################
WARNING!
IGNORING THE FOLLOWING TEMPLATE WILL RESULT IN ISSUE CLOSED AS INCOMPLETE
######################################################################
-->
## Checklist
<!--
Carefully read and work through this check list in order to prevent the most common mistakes and misuse of youtube-dl:
- First of, make sure you are using the latest version of youtube-dl. Run `youtube-dl --version` and ensure your version is 2020.05.08. If it's not, see https://yt-dl.org/update on how to update. Issues with outdated version will be REJECTED.
- Make sure that all provided video/audio/playlist URLs (if any) are alive and playable in a browser.
- Make sure that site you are requesting is not dedicated to copyright infringement, see https://yt-dl.org/copyright-infringement. youtube-dl does not support such sites. In order for site support request to be accepted all provided example URLs should not violate any copyrights.
- Search the bugtracker for similar site support requests: http://yt-dl.org/search-issues. DO NOT post duplicates.
- Finally, put x into all relevant boxes (like this [x])
-->
- [x] I'm reporting a new site support request
- [x] I've verified that I'm running youtube-dl version **2020.05.08**
- [x] I've checked that all provided URLs are alive and playable in a browser
- [x] I've checked that none of provided URLs violate any copyrights
- [x] I've searched the bugtracker for similar site support requests including closed ones
## Example URLs
<!--
Provide all kinds of example URLs support for which should be included. Replace following example URLs by yours.
-->
Sejm:
- Single video: https://www.sejm.gov.pl/Sejm9.nsf/transmisje_arch.xsp?unid=15321500870398ECC125856E0023D677
- Single video with sign language transcription: https://www.sejm.gov.pl/Sejm9.nsf/transmisje_arch.xsp#9587D63364A355A1C1258562004DCF21
- Single video with sign language transcription: https://www.sejm.gov.pl/Sejm9.nsf/transmisje_arch.xsp?unid=9587D63364A355A1C1258562004DCF21
- Live video: see https://www.sejm.gov.pl/Sejm9.nsf/transmisje.xsp for current transmissions, schedule: https://www.sejm.gov.pl/Sejm9.nsf/terminarz.xsp
Senat:
- Single video: https://av8.senat.pl/10KKSP91
- Single video with sign language transcription: https://av8.senat.pl/10Sen101
- Live video: see current URLs on https://www.senat.gov.pl/transmisje/biezace-transmisje/ , transmission schedule: https://www.senat.gov.pl/prace/senat/posiedzenia/planowane,1.html (_wznowienie_, _rozpoczΔcie_)
## Description
<!--
Provide any additional information.
If work on your issue requires account credentials please provide them or explain how one can obtain them.
-->
av8.senat.pl is [Polish Senate](https://en.wikipedia.org/wiki/Senate_of_Poland)'s recording archive and live viewer, linked by senat.gov.pl. sejm.gov.pl, [Polish Sejm](https://en.wikipedia.org/wiki/Sejm)'s website also seems to use the same player, provided by [Atende Software](https://www.atendesoftware.pl/)
|
site-support-request
|
low
|
Critical
|
622,520,198 |
terminal
|
Display a warning when someone passes an invalid profile name on the `wt` commandline
|
<!--
π¨π¨π¨π¨π¨π¨π¨π¨π¨π¨
I ACKNOWLEDGE THE FOLLOWING BEFORE PROCEEDING:
1. If I delete this entire template and go my own path, the core team may close my issue without further explanation or engagement.
2. If I list multiple bugs/concerns in this one issue, the core team may close my issue without further explanation or engagement.
3. If I write an issue that has many duplicates, the core team may close my issue without further explanation or engagement (and without necessarily spending time to find the exact duplicate ID number).
4. If I leave the title incomplete when filing the issue, the core team may close my issue without further explanation or engagement.
5. If I file something completely blank in the body, the core team may close my issue without further explanation or engagement.
All good? Then proceed!
-->
<!--
This bug tracker is monitored by Windows Terminal development team and other technical folks.
**Important: When reporting BSODs or security issues, DO NOT attach memory dumps, logs, or traces to Github issues**.
Instead, send dumps/traces to [email protected], referencing this GitHub issue.
If this is an application crash, please also provide a Feedback Hub submission link so we can find your diagnostic data on the backend. Use the category "Apps > Windows Terminal (Preview)" and choose "Share My Feedback" after submission to get the link.
Please use this form and describe your issue, concisely but precisely, with as much detail as possible.
-->
# Environment
```none
Windows build number: 10.0.19041.264
Windows Terminal version (if applicable): 1.0.1401.0
Profiles:
Windows Powershell
Command Prompt
PowerShell
PowerShell 7 Preview
Ubuntu
Azure Cloud Shell
```
Config: [settings.txt](https://github.com/microsoft/terminal/files/4662704/settings.txt)
# Steps to reproduce
1. `wt -p Windows PowerShell`
Causes Windows Powershell to be loaded, but with Powershell (Core) as the profile
2. `wt -p Command Prompt`
Following message is shown: [error 0x80070002 when launching `Prompt'] (Is using the Powershell (Core) profile but the tab name is empty)
3. `wt -p ubuntu`
Launches Powershell (Core)
# Expected behavior
Less confusing behaviour, from what I have observed it seems like, on my system at least, the Powershell (Core) profile is considered a default of sorts, so if it doesn't find a direct match it just opens that. It also seems that the second argument seems to be passed as an argument to the profile, not entirely sure if that's right way to describe it, as `wt -p Windows Get-Date` results in the same error as the Command Prompt example instead of executing Get-Date.
So I think ways of adressing that would be:
1. Commands should only accept the ones defined in the documentation, (e.g. `new-tab`, `split-pane`, `focus-tab`)
2. If a direct (case insensitive) profile match isn't found, is it possible to launch the default profile while displaying to the user that the selected profile wasn't found?
3. (imo) If a direct (case insensitive) profile match is found do launch that, instead of the default. (i.e. `wt -p ubuntu` is the same as `wt -p Ubuntu`)
# Actual behavior
In steps to reproduce, above.
|
Product-Terminal,Issue-Task,Area-Commandline
|
low
|
Critical
|
622,521,498 |
go
|
x/exp/cmd/gorelease: set allowed changes with -compatibility flag
|
Currently, gorelease determines whether compatible and incompatible API changes are allowed based on the module base version and release version. It follows semver guidelines, for example, allowing incompatible changes at base major version v0.
Users may want to apply different (usually stricter) compatibility guidelines. For example, a module may want to forbid incompatible API changes between minor versions at v0, even though semver allows them.
gorelease should accept a `-compatibility` flag that allows users to set the compatibility level explicitly. For example:
```
gorelease -base=v0.10.0 -release=v0.10.1 -compatibility=patch
gorelease -base=v0.10.0 -release=v0.11.0 -compatibility=minor
gorelease -base=v0.10.0 -release=v0.15.0 -compatibility=major
```
cc @liggitt
|
NeedsInvestigation,FeatureRequest,modules,Tools
|
low
|
Minor
|
622,521,539 |
go
|
x/exp/cmd/gorelease: fetch base version from directory with -basedir flag
|
gorelease currently lets the user specify a base version to compare against using the `-base` flag. At the moment, this only accepts an existing version of the same module (retrievable using `go mod download`). #37410 would allow version queries like `@latest`, `@master`, or `@01234abcdef`
It may sometimes be useful to compare against code that isn't available to the proxy or pushed to the origin VCS server yet. A `-basedir` flag would help with this. It would let the user specify the base version as a directory tree.
```
gorelease -basedir=path/to/base -release=v1.0.0
```
cc @liggitt
|
NeedsInvestigation,FeatureRequest,modules,Tools
|
low
|
Minor
|
622,528,488 |
opencv
|
Linking Tutorial Pages to Their Github Source Page
|
To make contributing to tutorials easier, it would be nice to be able to go directly from a tutorial page to the file on github that it is generated from. For example, going from [Finding contours in your image](https://docs.opencv.org/master/df/d0d/tutorial_find_contours.html) to [find_contours.markdown](https://github.com/opencv/opencv/blob/master/doc/tutorials/imgproc/shapedescriptors/find_contours/find_contours.markdown) is slightly complicated because the file is under shapedescriptors, which you can't tell from the way the tutorials are organized on the docs site.
A possible approach to this I tested out was adding an alias to the [DoxyFile](https://github.com/opencv/opencv/blob/master/doc/Doxyfile.in) and then running a shell command that adds a line to the end of every tutorial markdown file using that alias.
For instance the alias:
`github_source{1}="[View on Github (https://github.com/opencv/opencv/blob/master/doc/\1)"`
With the following BSD command on a mac:
`find tutorials js_tutorials py_tutorials -name "*.markdown" -exec sh -c 'printf "\n@github_source{"$0"}" >> "$0"' {} \;`
The command/alias can definitely be improved, but I wanted to see if something like this would be accepted, and receive any feedback on better ways to automate this process moving forward.
|
category: documentation
|
low
|
Minor
|
622,537,224 |
PowerToys
|
[Feature Request] Media converter with ffmpg
|
Hi,
I use ffmpg a lot to convert videos into a stranded format, it would be nice if there was a power tool for it.
the tool could be simple UI or a right click on media (content menu) that when you select a video that you get an option to select want format you want to convert to.
AVI -> MP4
-> MKV
-> Other
also with that tool you can update the version of ffmpg you have installed and update some of the ffmpeg commands
if you can make it work like PowerRename
|
Idea-New PowerToy
|
medium
|
Major
|
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.