id
int64 393k
2.82B
| repo
stringclasses 68
values | title
stringlengths 1
936
| body
stringlengths 0
256k
⌀ | labels
stringlengths 2
508
| priority
stringclasses 3
values | severity
stringclasses 3
values |
|---|---|---|---|---|---|---|
624,007,891 |
flutter
|
Multibyte Texts are taller than alphabet Texts even though they are same FontSize
|
## Steps to Reproduce
Texts of emoji and Japanese is taller than the Texts of the alphabet.
**Expected results:** <!-- what did you want to see? -->
Same height.
**Actual results:** <!-- what did you see? -->
iOS 13.5
<img width="294" alt="スクリーンショット 2020-05-25 11 31 58" src="https://user-images.githubusercontent.com/1098127/82772944-b8fd5e80-9e7b-11ea-9929-cd47af3a564f.png">
<details>
```dart
import 'package:flutter/material.dart';
void main() {
runApp(MyApp());
}
class MyApp extends StatelessWidget {
@override
Widget build(BuildContext context) {
return MaterialApp(
title: 'Text heights',
home: HomePage(),
);
}
}
class HomePage extends StatefulWidget {
@override
HomePageState createState() => HomePageState();
}
class HomePageState extends State<HomePage> {
@override
Widget build(BuildContext context) {
return Scaffold(
appBar: AppBar(
title: Text("Text box heights"),
),
body: Column(
children: <Widget>[
Container(
padding: const EdgeInsets.all(20.0),
child: Row(
children: <Widget>[
Container(
color: Colors.red,
child: Text(
"ABC",
),
),
Container(
color: Colors.green,
child: Text(
"あいう",
),
),
],
),
),
Container(
padding: const EdgeInsets.all(20.0),
child: Row(
children: <Widget>[
Container(
color: Colors.red,
child: Text(
"ABC",
),
),
Container(
color: Colors.blue,
child: Text(
"😀😀😀",
),
),
],
),
),
],
),
);
}
}
```
```
[✓] Flutter (Channel dev, 1.19.0-1.0.pre, on Mac OS X 10.15.4 19E287, locale ja-JP)
• Flutter version 1.19.0-1.0.pre at /Applications/flutter
• Framework revision 456d80b9dd (13 days ago), 2020-05-11 11:45:03 -0400
• Engine revision d96f962ca2
• Dart version 2.9.0 (build 2.9.0-7.0.dev 092ed38a87)
[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.3)
• Android SDK at /Users/najeira/Library/Android/sdk
• Platform android-29, build-tools 29.0.3
• Java binary at: /Users/najeira/Library/Application Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/192.6392135/Android
Studio.app/Contents/jre/jdk/Contents/Home/bin/java
• Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b4-5784211)
• All Android licenses accepted.
[✓] Xcode - develop for iOS and macOS (Xcode 11.5)
• Xcode at /Applications/Xcode.app/Contents/Developer
• Xcode 11.5, Build version 11E608c
• CocoaPods version 1.9.1
[!] Android Studio (version 3.6)
• Android Studio at /Users/najeira/Library/Application Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/192.6392135/Android Studio.app/Contents
✗ Flutter plugin not installed; this adds Flutter specific functionality.
✗ Dart plugin not installed; this adds Dart specific functionality.
• Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b4-5784211)
[!] IntelliJ IDEA Ultimate Edition (version 2020.1.1)
• IntelliJ at /Users/najeira/Applications/JetBrains Toolbox/IntelliJ IDEA Ultimate.app
✗ Flutter plugin not installed; this adds Flutter specific functionality.
✗ Dart plugin not installed; this adds Dart specific functionality.
• For information about installing plugins, see
https://flutter.dev/intellij-setup/#installing-the-plugins
[!] VS Code (version 1.44.2)
• VS Code at /Applications/Visual Studio Code.app/Contents
✗ Flutter extension not installed; install from
https://marketplace.visualstudio.com/items?itemName=Dart-Code.flutter
```
</details>
|
engine,a: internationalization,a: typography,has reproducible steps,P2,found in release: 3.3,found in release: 3.6,team-engine,triaged-engine
|
low
|
Major
|
624,008,395 |
godot
|
Opaque Pre Pass Textures not Rendering Properly on Mobile Devices
|
**Godot version:**
3.2.1 -3.2.2 Beta 2
GLES 3
**OS/device including version:**
iOS 13.5,
Android
**Issue description:**
When adding an opaque pre-pass texture to a mesh it does not render properly on mobile devices.
**Steps to reproduce:**
Add a transparent texture to a mesh instance and set it to opaque pre pass.
Expected result ran on windows and macos:
<img width="487" alt="Screen Shot 2020-05-24 at 9 27 08 PM" src="https://user-images.githubusercontent.com/65880004/82772997-82393100-9e06-11ea-8073-f68c6e937032.png">
Actual Result on iphone 11 and similar issue on a friends android phone(dont have the specifics):
**Minimal reproduction project:**
[OpaqueIssue](https://github.com/TrevSaysHi/OpaqueIssue)
|
bug,platform:android,topic:rendering
|
low
|
Minor
|
624,067,706 |
flutter
|
iOS issue: Scrollbar position is wrong in horizontal ListView
|
i want to use Widget `Scrollbar` in **horizontal** ListView.
Android is normal, but iOS `Scrollbar` position is wrong.
| iOS | Android |
| :----------------------------------------------------------: | :----------------------------------------------------------: |
| ||
```dart
import 'package:flutter/material.dart';
import 'package:flutter/cupertino.dart';
void main() {
runApp(MyApp());
}
class MyApp extends StatelessWidget {
// This widget is the root of your application.
@override
Widget build(BuildContext context) {
return MaterialApp(
title: 'Flutter Demo',
theme: ThemeData(
primarySwatch: Colors.blue,
visualDensity: VisualDensity.adaptivePlatformDensity,
),
home: MyHomePage(),
);
}
}
class MyHomePage extends StatelessWidget {
final List<Widget> items = List<Widget>.generate(10, (_) {
return Placeholder(
fallbackWidth: 50,
fallbackHeight: 50,
);
});
@override
Widget build(BuildContext context) {
return Scaffold(
appBar: AppBar(
title: Text('Scrollbar in horizontal ListView'),
),
body: Scrollbar(
isAlwaysShown: true,
child: Container(
height: 50,
child: ListView(
scrollDirection: Axis.horizontal,
children: items,
),
),
),
);
}
}
```
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel stable, v1.17.1, on Mac OS X 10.15.4 19E287, locale zh-Hant-HK)
[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.3)
[✓] Xcode - develop for iOS and macOS (Xcode 11.5)
[✓] Android Studio (version 3.6)
[✓] VS Code (version 1.45.1)
[✓] Connected device (3 available)
• No issues found!
|
e: device-specific,platform-ios,framework,f: material design,a: fidelity,f: scrolling,a: layout,has reproducible steps,P2,found in release: 3.7,found in release: 3.10,team-ios,triaged-ios
|
low
|
Major
|
624,084,878 |
godot
|
Re-Import of multiple image files fails
|
**Godot version:**
Godot_v3.2.1-stable (Steam) and also in Mono Version
**OS/device including version:**
Windows 10
**Issue description:**
When selecting the "**Import**" tab next to the "Scene" tab, it's easy to re-import a single file. Thus, when having selected multiple files, the re-import option is also available, but fails for every type (Any type -> Any type, e.g. Texture -> Image).
Only output produced in the console is:
C:\Program Files (x86)\Steam\steamapps\common\Godot Engine/editor_data/projects/BugTest-35d503ddec07605593a9ad447e692fea/filesystem_update4
When changing .ogg Loop Offset for example, this works also for multiple files. I think the bug may be caused because Godot has to restart upon re-import image files.
**Steps to reproduce:**
1. Start a new project
2. Add 2 or more image files (.png/.jpg/etc. doesn't matter)
3. Try to re-import them into another type
4. Godot shows that it's working and restarts, but then all of the files are not re-imported
|
bug,topic:editor,topic:import
|
low
|
Critical
|
624,088,221 |
pytorch
|
ATen operator API versioning
|
## 🚀 Feature
When implementing a new out-of-source ATen backend extension for PyTorch, we find ATen operator APIs are incompatible from version to version (even among minor versions, for example v1.5.x).
We expect `ATen operator API versioning` could be provided to improve user experience, when out-of-source extension does not match with PyTorch (ATen operator API).
## Motivation
End-user may get runtime error about ATen operator API mismatching, when they try some different PyTorch minor versions with a given Intel Extension for PyTorch. For example,
Extension v0.1 is based on PyTorch v1.5.0.
End-user may try extension v0.1 on PyTorch v1.5.3+, and get ATen runtime error, due to ATen operator API changes.
In addition, different workloads may get different ATen runtime error (different operators API change). ATen runtime error is good enough for extension developer, but is not friendly enough for end-user.
So intuitively, we want to raise a warning ahead of all at runtime, if some ATen operator APIs change, which is more friendly to users, and may not bring risks.
## Pitch
We expect to have `ATen operator API versioning` for runtime check and raise a warning at extension loading time, if PyTorch ATen operator API version is not supported by extension.
P.S. We thought of checking PyTorch version only. But it would take huge efforts to investigate ATen operator API changes on all PyTorch versions (including all minor versions).
|
module: internals,triaged
|
low
|
Critical
|
624,089,120 |
flutter
|
Added 'enabled' property to RaisedButton and similar classes.
|
To disable a button in flutter you need to return a null to the onPress method.
This results in code something like:
```dart
RaisedButton(
onPressed: (enabled ? onPressed : null),
label: Text(label)
}
```
Syntactically this is ugly and when first reading the doco its not obvious how to achieve something that every other framework makes obvious.
Instead the framework should add an 'enabled' property to the button.
The syntax is then:
```dart
bool enabled;
RaisedButton(
enabled: enabled,
onPressed: onPressed,
label: Text(label)
}
```
This change can be made backward compatible (onPressed still works as previously documented) but will provide much cleaner syntax going forward.
This technique should be applied to other widgets that use a similar technique.
I've also came across implementations that pass a function to the onPress. This results in some very bizarre looking code that conditionally take an action but then return null in some cases. Reading this code makes little sense when most paths don't need to return anything.
I would view the current method signature as promoting bad practices.
|
framework,f: material design,c: proposal,team-design,triaged-design
|
low
|
Minor
|
624,098,358 |
terminal
|
Fast scroll by holding down Alt while scrolling with mouse wheel
|
# Description of the new feature/enhancement
VS Code has a great feature for scrolling using the mouse wheel. The window scrolls much faster when you hold down the Alt key. I use this all the time.
Sometimes in Windows Terminal I am scrolling through verbose CLI output, or I want to quickly look a long way back in the terminal history. It would be great if Terminal had the same Alt+scroll-wheel behaviour.
|
Area-Input,Area-TerminalControl,Product-Terminal,Issue-Task
|
low
|
Major
|
624,105,047 |
pytorch
|
ATen registrable operator list
|
## 🚀 Feature
Expose ATen registrable operators information in ATen operator API
## Motivation
When implementing a new out-of-source ATen backend extension for PyTorch, we find it is not easy to find out which ATen operators should be registered and implemented. Extension developer expect to work only based on PyTorch ATen operator API. But in fact, we have to distinguish operators in two cases as below, which depends on PyTorch implementation,
1. The operator is supported by sparse backend or not. If yes, we need to register the operator for not only dense backend but also for sparse backend.
2. Backends of the operator are bypassed at runtime or not. If bypassed, we ignore the operator, or we need register and implement the operator.
Regarding sparse or not, we have to check `native_functions.yaml`.
Regarding bypass or not, we have to check `derivatives.yaml` and generated file `VariableTypeEverything.cpp`.
## Pitch
If PyTorch can expose two operator lists as a part of API to show “sparse or not” and “bypass or not”, the case by case analysis for ATen OP could be avoided when registering Ops for new device. One intuitive idea is to mark them in existing API, for instance of detailed ATen Op schema in `RegistrationDeclarations.h`,
`{"schema": "aten::add.Tensor(Tensor self, Tensor other, *, Scalar alpha=1) -> Tensor", "compound": "false", "bypass": "false", "sparse": "true"}`
`{"schema": "aten::add_.Tensor(Tensor(a!) self, Tensor other, *, Scalar alpha=1) -> Tensor(a!)", "compound": "false", "bypass": "false", "sparse": "true"}`
`{"schema": "aten::add.out(Tensor self, Tensor other, *, Scalar alpha=1, Tensor(a!) out) -> Tensor(a!)", "compound": "false", "bypass": "false", "sparse": "true"}`
`{"schema": "aten::batch_norm(Tensor input, Tensor? weight, Tensor? bias, Tensor? running_mean, Tensor? running_var, bool training, float momentum, float eps, bool cudnn_enabled) -> Tensor", "compound": "false", "bypass": “true", "sparse": “false"}`
|
module: internals,triaged
|
low
|
Major
|
624,111,970 |
pytorch
|
Use general ATen dispatch mechanism
|
## 🚀 Feature
Use general ATen dispatch mechanism in some case, like `at::lstm`.
## Motivation
When implementing a new out-of-source ATen backend extension for PyTorch, we find it is no chance to hook whole lstm cell based on existing `at::lstm` dispatch strategy. Our backend gets bad performance here.
In detail, backends of `at::lstm` are bypassed at runtime. `VariableType::lstm` calls `TypeDefaultType::lstm` directly, bypasses `c10::dispatcher`. Except for two backends, cudnn and mimopen, which are dispatched by hard-code “if-else”, others backends fall down to component operators, like `at::matmul`, `at::sigmoid`, `at::tanh`...
```
// TypeDefault::lstm -> at::native::lstm
at::native::lstm() {
if (at::cudnn_is_acceptable(_input)) {
...
return at::_cudnn_rnn();
}
if (at::use_miopen(_input, dropout_p)) {
...
return at::miopen_rnn();
}
lstm_default_impl(); // fall down to component Ops, at::matmul, at::tanh...
}
```
We also find same issue in `at::_embedding_bag_backward`.
## Pitch
`at::convolution_overrideable`, `at::native_batch_norm` and `at::native_layer_norm` are good examples in similar case.
|
module: internals,triaged
|
low
|
Major
|
624,142,613 |
You-Dont-Know-JS
|
Scopes & Closures Ch. 6 - Switch Statement Scoping
|
**Please type "I already searched for this issue":**
I already searched for this issue.
**Edition:** (1st or 2nd)
2nd
**Book Title:**
Scope & Closures
**Chapter:**
Chapter 6: Limiting Scope Exposure
**Section Title:**
Scoping with Blocks
**Problem:**
> The `{ .. }` curly-brace pair on a `switch` statement (around the set of `case` clauses) does not define a block/scope.
As best I can tell, the switch statement curly-braces referred to **do** create a scope with `const` or `let`.
For example, with `var`, foo outputs `'foo'` as expected.
```javascript
switch (true) {
case true:
var foo = 'foo';
}
console.log(foo);
```
However, with `let`, logging `foo` produces a reference error. (Not expected if these braces aren't creating a scope)
```javascript
switch (true) {
case true:
let foo = 'foo';
}
console.log(foo);
```
This came up in our last online Code Club discussion (which I believe you have visited previously). Thanks so much for providing this resource!
|
errata
|
low
|
Critical
|
624,211,089 |
fastapi
|
Improve `HTTPDigest` implementation
|
### Describe the bug
`fastapi.security.HTTPDigest` is actually not implementing HTTP Digest Access Authentication as specified by [RFC 7616](https://tools.ietf.org/html/rfc7616) or (the obsoleted) [RFC 2617](https://tools.ietf.org/html/rfc2617).
### To Reproduce
Read the relevant RFCs or maybe try it out using `curl --digest`.
### Expected behavior
Exactly as specified in [RFC 7616](https://tools.ietf.org/html/rfc7616).
|
feature,confirmed,reviewed
|
low
|
Critical
|
624,239,153 |
flutter
|
Define a standard performance timing module, include the first-paint, first-contentful-paint, Time to Interactive in the flutter
|
<!-- Thank you for using Flutter!
If you are looking for support, please check out our documentation
or consider asking a question on Stack Overflow:
* https://flutter.dev/
* https://api.flutter.dev/
* https://stackoverflow.com/questions/tagged/flutter?sort=frequent
If you have found a bug or if our documentation doesn't have an answer
to what you're looking for, then fill our the template below. Please read
our guide to filing a bug first: https://flutter.dev/docs/resources/bug-reports
-->
## Use case
It's very important to know the performance data on the phone of the user, especially when the app is released.
There is the frame timing to calculate the fps data of the page, but we don't have any way to know the performance cost of the page opening on the flutter, like the first paint, time to interactive...
<!--
Please tell us the problem you are running into that led to you wanting
a new feature.
Is your feature request related to a problem? Please give a clear and
concise description of what the problem is.
Describe alternative solutions you've considered. Is there a package
on pub.dev/flutter that already solves this?
-->
## Proposal
we can calculate the the first paint timing when the first frame event is called back, but it's hard to know the time to interactive of the page.
on the web, time to interactive is defined like this:
Time to Interactive (TTI) is a page load performance metric that measures how long it takes for a web page to become interactive, which is defined as the point where:
1. The page has displayed useful content
2. Event handlers are registered for most visible page elements
3. When a user interacts with the page, the page consistently responds within 50ms - the user does not experience jank.
(-- from https://github.com/WICG/time-to-interactive)
so, is there any way to define a standard performance timing module, include the first-paint, first-contentful-paint, Time to Interactive in the flutter per page?
(follow the w3c standard : https://w3c.github.io/paint-timing/#first-paint)
<!--
Briefly but precisely describe what you would like Flutter to be able to do.
Consider attaching images showing what you are imagining.
Does this have to be provided by Flutter directly, or can it be provided
by a package on pub.dev/flutter? If so, maybe consider implementing and
publishing such a package rather than filing a bug.
-->
|
engine,c: performance,platform-web,c: proposal,perf: speed,e: web_canvaskit,P3,team-web,triaged-web
|
low
|
Critical
|
624,241,034 |
pytorch
|
runtime error while using default arguments in add_graph() function
|
## 🐛 Bug
As per the documentation of `add_graph()` function from `torch.utils.tensorboard.writer.SummaryWriter` module, only `model` is the required parameter and rest of the parameters are given a default value.
However, when I try to call `add_graph()` using only `model` as input, I get a following runtime error
```
Exception has occurred: TypeError
'NoneType' object is not iterable
File "F:\projects\ai\autoencoder\pointnet-autoencoder-pytorch\train.py", line 62, in <module>
writer.add_graph(autoencoder)
```
## To Reproduce
Steps to reproduce the behavior:
1. Create a model and call `add_graph()` function by passing only `model` and keep other parameters as default
## Expected behavior
`add_graph()` should not need input as a compulsory parameter as I would like to use this function to display the layers of my network graphically.
## Environment
Collecting environment information...
PyTorch version: 1.5.0
Is debug build: No
CUDA used to build PyTorch: None
OS: Microsoft Windows 10 Pro
GCC version: Could not collect
CMake version: version 3.17.0
Python version: 3.6
Is CUDA available: No
CUDA runtime version: No CUDA
GPU models and configuration: No CUDA
Nvidia driver version: No CUDA
cuDNN version: No CUDA
Versions of relevant libraries:
[pip] numpy==1.14.2
[pip] torch==1.5.0
[pip] torchvision==0.6.0
[conda] _pytorch_select 1.1.0 cpu
[conda] blas 1.0 mkl
[conda] cpuonly 1.0 0 pytorch
[conda] cudatoolkit 10.2.89 h74a9793_1
[conda] mkl 2020.1 216
[conda] numpy 1.14.2 py36h5c71026_0
[conda] pytorch 1.5.0 py3.6_cpu_0 [cpuonly] pytorch
[conda] torchvision 0.6.0 py36_cpu [cpuonly] pytorch
|
triaged,module: tensorboard,oncall: visualization
|
low
|
Critical
|
624,244,055 |
angular
|
TypeScript 3 Project References feature support
|
### Bug Report or Feature Request (mark with an `x`)
```
- [ ] bug report -> please search issues before submitting
- [x] feature request
```
### Command (mark with an `x`)
```
- [ ] new
- [x] build
- [x] serve
- [x] test
- [ ] e2e
- [ ] generate
- [ ] add
- [ ] update
- [ ] lint
- [ ] xi18n
- [ ] run
- [ ] config
- [ ] help
- [ ] version
- [ ] doc
```
### Versions
Node: 10.13.0
NPM: 3.10.10
Angular CLI: 7.0.4
Windows 10
### Desired functionality
I would like to use TypeScript 3 Project References feature in Angular 7 project (created by Angular CLI).
### Mention any other details that might be useful
More about TypeScript 3 Project References: https://www.typescriptlang.org/docs/handbook/project-references.html
|
feature,area: compiler,feature: under consideration
|
high
|
Critical
|
624,262,898 |
vscode
|
Search error: ENAMETOOLONG
|
When I press on Ctrl + P and enter the name of some JS or TS file, the files are not found. Only the last opened files are available. This is a recent problem, that appeared on the 1.45.1 version of Visual Studio code.
|
bug,search,confirmed
|
low
|
Critical
|
624,341,377 |
PowerToys
|
[Request] Shortcut to a context menu that doesn't have an existing shortcut.
|
# Adding shortcut functionality to context menu items without an existing one
Sometimes there's software functions that get used a lot, but for some reason the developer has not assigned a default shortcut key combination to it. "File->Page setup" in notepad.exe for example.
It'd be nice to add a way for PowerToys' keyboard manager to look at what the context menus in a specific program contain, and be able to assign a shortcut for that. In the example above, it would look at notepad.exe and apply a user specified shortcut that would select file->page setup, if notepad is the active window (not unlike a macro or the MacOS keyboard shortcuts functionality).
Fantastic work so far, much appreciated!
|
Idea-New PowerToy
|
low
|
Minor
|
624,372,922 |
godot
|
Problem with keeping aspect ratio in window when using macOS aspect-conserving resize
|
**Godot version:**
3.2.1
**OS/device including version:**
mac OS X 10.11.16, OpenGL ES 3.0 Renderer: ATI Radeon HD 5870 OpenGL Engine
**Issue description:**
(Preface: I have the window resolutuion set to 256x192, display.window/stretch/mode is set to Viewport, and the Aspect is set to Keep)
In Mac OS X, you can resize a window while keeping its aspect ratio by clicking and dragging while holding Shift. However, The game begins to generate black bars as though I am not keeping the ratio, despite me doing so. It can be seen both in enlarging the window, and reducing it.
(black bars made cyan for your convenience)
**Steps to reproduce:**
Set your window to any size, Set your mode to Viewport, aspect to Keep, and resize with ratio. Note that resizing the window through a script will keep the correct ratio.
**Minimal reproduction project:**
[Dawn.zip](https://github.com/godotengine/godot/files/4677937/Dawn.zip)
|
bug,platform:macos,topic:porting
|
low
|
Minor
|
624,378,442 |
PowerToys
|
[Fancy Zones] Exclude app from snapping thru context menu
| null |
Idea-Enhancement,Product-FancyZones
|
low
|
Minor
|
624,408,197 |
flutter
|
Why is DropdownButtonFormField's onChanged required?
|
<!-- Thank you for using Flutter!
If you are looking for support, please check out our documentation
or consider asking a question on Stack Overflow:
* https://flutter.dev/
* https://api.flutter.dev/
* https://stackoverflow.com/questions/tagged/flutter?sort=frequent
If you have found a bug or if our documentation doesn't have an answer
to what you're looking for, then fill our the template below. Please read
our guide to filing a bug first: https://flutter.dev/docs/resources/bug-reports
-->
## Steps to Reproduce
Try to initialize a `DropdownButtonFormField` without specifying the `onChanged` parameter.
**Expected results:** <!-- what did you want to see? -->
For `onChanged` to not be required and the widget to still work, which is consistent with other FormField widgets, such as `TextFormField`.
**Actual results:** <!-- what did you see? -->
Currently the `onChanged` parameter is required and is seemingly used as a way to disable the widget if you set it to null. If you don't care about the onChanged event and just want to use the DropdownButtonFormField in a normal basic form, you still have to set onChanged to an empty function (e.g. `onChanged: (value) {}`) otherwise it won't update the FormState/stay enabled. This feels unintuitive to me since e.g. the `TextFormField` widget does not require you to specify `onChanged` unless you're interested in that event.
While I'm not that experienced with Flutter, it seems like it would make more sense to not use `onChanged` as a way of disabling a `DropdownButtonFormField` and instead let it purely be a way of letting the user do something when the field changes. I don't know if there are issues with that or if this odd current behavior is just a leftover from old logic? Seems easy enough to change it up (I could attempt to submit a PR for it).
**Proposed Changes:**
Add a `bool enabled` parameter to `DropdownButtonFormField` (consistent with TextFormField) and use that to decide whether to set the underlying `DropdownButton.onChanged` to control its enabled'ness.
In the future, it might make sense to add an `enabled` parameter to `DropdownButton` as well, as an explicit way of controlling whether it should be enabled or not.
|
a: text input,framework,f: material design,c: proposal,P3,team-design,triaged-design
|
low
|
Critical
|
624,431,663 |
PowerToys
|
[Run] Allow filter out app results
|
# Summary of the new feature/enhancement
Sometimes it might be useful to filter out some apps/search result (maybe by regex for instance, or by context menu in the search results).
For example:
For instance here I personally don't want to see "Character Map", "Weather Windows App" and "Private Character Editor" because I never used them and not going to do so, but I see them in search results. It might be the issue would be fixed in the search result will be sorted somehow (by usage and weight).
|
Idea-Enhancement,Product-PowerToys Run
|
medium
|
Major
|
624,451,364 |
PowerToys
|
Keyboard manager breaks 3 and 4 finger touch pad taps with certain remaps
|
<!--
**Important: When reporting BSODs or security issues, DO NOT attach memory dumps, logs, or traces to Github issues**.
Instead, send dumps/traces to [email protected], referencing this GitHub issue.
-->
# Environment
```
Windows build number: 10.0.18363.836
PowerToys version: 0.18.1
PowerToy module for which you are reporting the bug (if applicable): Keyboard manager
```
# Steps to reproduce
1. Configure an action for 3/4 finger tap in Windows Settings -> Devices -> Touchpad
2. Turn on Keyboard manager in PowerToys settings
3. Remap Alt with Control
4. Remap Control with Alt
# Expected behavior
For 3 and 4 finger tap gestures configured in settings to work
For the Control and Alt key to be swapped
# Actual behavior
3 and 4 finger taps do nothing
Control and Alt key do still swap as they should
<!-- What's actually happening? -->
# Screenshots
<!-- If applicable, add screenshots to help explain your problem. -->
|
Issue-Bug,Product-Keyboard Shortcut Manager,Priority-1
|
medium
|
Critical
|
624,458,517 |
node
|
doc: some methods inherited from Uint8Array are documented but not all
|
# 📗 API Reference Docs Problem
<!------------------------------------------------------------------------------
Thank you for wanting to make nodejs.org better!
This template is for issues with the Node.js API reference docs.
For more general support, please open an issue in
our help repo at “https://github.com/nodejs/help”.
For the issue title, enter a one-line summary after “doc: ”.
The “✍️” signifies a request for input. If unsure, do the best you can.
If you found a problem with nodejs.org beyond the API reference docs, please
open an issue in our website repo at “https://github.com/nodejs/nodejs.org”.
------------------------------------------------------------------------------->
<!--
Version: output of “node -v”
Platform: output of “uname -a” (UNIX), or version and 32 or 64-bit (Windows)
Subsystem: if known, please specify affected core module name
-->
- **Version**: master
- **Subsystem**: buffer
## Location
Affected URL(s):
- https://nodejs.org/api/buffer.html
## Problem description
<!-- If applicable, include any screenshots that may help solve the problem. -->
Some methods inherited from `Uint8Array` are not documented, e.g. `map`, `reduce`, `set`. This makes sense because it's stated that the `Buffer` class is a subclass of the `Uint8Array` class, but some _are_ documented, e.g. `entries`, `keys`, `values`. This might be confusing.
---
<!-- Use “[x]” to check the box below if interested in contributing. -->
- [x] I would like to work on this issue and submit a pull request.
|
buffer,doc
|
low
|
Minor
|
624,466,524 |
PowerToys
|
[FancyZones] Allow window to be "locked" in place
|
# Summary of the new feature/enhancement
I am always accidentally moving or resizing my zoned windows, especially edge when i go to click on a tab. It would be nice if we could "lock" these windows into their zone to protect against accidental nudging. Either have the window snap back to it's original position, ~allow it to be "maximized" into the zone so it won't accidentally move, or just prevent movement.~ There could be a hotkey to override this behavior to intentionally move a "locked" window.
This should clearly be an optional setting, as i can see now it might annoy some people, or confuse people that are new to the product.
|
Idea-Enhancement,Product-FancyZones
|
low
|
Major
|
624,502,408 |
flutter
|
[WebView] Issue in using Hero with webview and global keys, "Multiple widgets used the same GlobalKey."
|
Hi, I'm facing an "Multiple widgets used the same GlobalKey." issue when tried put a global key in 2 webviews that is the same, according this video (https://youtu.be/RA-vLF_vnng?t=281), she said to put a global key in two widgets to prevent flutter to re-render the second one.
I Tried even the Navigator.pushReplacement to avoid duplicate keys, (but in my case, I need to have the possibility to go to previous page)
Here is a full sample, the hero transition works, but the go "back" freezes on my iOS, and the console logs "Multiple widgets used the same GlobalKey."
```dart
import 'package:flutter/foundation.dart';
import 'package:flutter/gestures.dart';
import 'package:flutter/material.dart';
import 'package:webview_flutter/webview_flutter.dart';
void main() {
runApp(StockDetailsPage());
}
class StockDetailsPage extends StatelessWidget {
const StockDetailsPage({Key key, this.symbol}) : super(key: key);
final String symbol;
// This widget is the root of your application.
@override
Widget build(BuildContext context) {
return MaterialApp(
title: 'Flutter Demo',
theme: ThemeData(
primarySwatch: Colors.blue,
visualDensity: VisualDensity.adaptivePlatformDensity,
),
home: MyHomePage(title: 'Flutter Demo Home Page'),
);
}
}
class MyHomePage extends StatefulWidget {
MyHomePage({Key key, this.title}) : super(key: key);
final String title;
@override
_MyHomePageState createState() => _MyHomePageState();
}
class _MyHomePageState extends State<MyHomePage> {
@override
void initState() {
super.initState();
}
@override
Widget build(BuildContext context) {
return Scaffold(
appBar: AppBar(
title: Text(widget.title),
),
body: ListView(
children: <Widget>[
Container(
height: 500,
child: Hero(
tag: 'Teste',
child: WebView(
key: gkey,
initialUrl: 'https://google.com.br',
javascriptMode: JavascriptMode.unrestricted,
),
),
),
RaisedButton(
child: Text('Go to Page 2'),
onPressed: () async {
await Navigator.of(context).push(
MaterialPageRoute(builder: (context) => PageTwo()),
);
},
),
Container(height: 600, color: Colors.red),
],
),
);
}
}
class PageTwo extends StatefulWidget {
@override
_PageState createState() => _PageState();
}
class _PageState extends State<PageTwo> {
@override
Widget build(BuildContext context) {
return Scaffold(
appBar: AppBar(),
body: Hero(
tag: 'Teste',
child: WebView(
key: gkey,
),
),
);
}
}
final gkey = GlobalKey();
```
```console
Flutter Doctor
[✓] Flutter (Channel stable, v1.17.1, on Mac OS X 10.14.6 18G103, locale en-US)
• Flutter version 1.17.1 at /Users/Mycap/documents/flutter
• Framework revision f7a6a7906b (13 days ago), 2020-05-12 18:39:00 -0700
• Engine revision 6bc433c6b6
• Dart version 2.8.2
[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
• Android SDK at /Users/Mycap/Library/Android/sdk
• Platform android-29, build-tools 29.0.2
• Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
• Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405)
• All Android licenses accepted.
[✓] Xcode - develop for iOS and macOS (Xcode 11.2.1)
• Xcode at /Applications/Xcode.app/Contents/Developer
• Xcode 11.2.1, Build version 11B500
• CocoaPods version 1.8.4
[✓] Android Studio (version 3.5)
• Android Studio at /Applications/Android Studio.app/Contents
• Flutter plugin version 42.1.1
• Dart plugin version 191.8593
• Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405)
[✓] Connected device (1 available)
• iPhone de Hb • 00008020-00113DD222C3002E • ios • iOS 13.3
```
Edit: The code is not formated correctly (pretty), but I think that we can reproduce the issue.
Edit2: The go back action freezes if using the swipe from left to right shortcut on left edge border, ios, using the appbar back button, works, but the exceptions occurs on console.
Any idea?
|
framework,a: animation,p: webview,package,team-ecosystem,has reproducible steps,P2,found in release: 2.2,found in release: 2.5,triaged-ecosystem
|
low
|
Major
|
624,527,364 |
deno
|
Deno lacks a cookie jar for `fetch`
|
Deno should store cookies on a per-run basis (and optionally have methods in the Deno namespace for export/import of cookies) so that it's possible to make a series of requests that depend on cookies.
Right now, a flow like the following would be impossible:
1. No cookies sent; response sets cookie 1.
2. Cookie 1 sent; response uses cookie 1 value somewhere in the body
Yes, I'm aware of `std/http/cookie`. No, it's not what I need - this is not a server. It's a client.
|
web,suggestion,ext/fetch
|
medium
|
Critical
|
624,546,756 |
rust
|
mod-with-a-body silently ignores any "mod.rs" (could have a better diagnostic?)
|
I tripped over this learning how the module system works and splitting things into multiple files.
If you write
```rust
// lib.rs
pub mod foo;
```
it looks for `foo/mod.rs`, and it all works fine. But let's say I want to add a submodule inside `foo`. So I changed `lib.rs` to look like this:
```rust
// lib.rs
pub mod foo {
pub mod sub;
}
```
Now `mod foo` has a body, so it does not look for `foo/mod.rs`. But I didn't know this rule, and it doesn't give me any indication that it skipped that file. Instead, I just get unresolved import errors as if all the stuff inside the `foo` module has magically disappeared.
It'd be nice if it said something along the lines of `"warning: ignoring foo/mod.rs as a body was found in lib.rs"` or so.
### Meta
`rustc --version --verbose`:
```
rustc 1.45.0-nightly (2d03399f5 2020-04-27)
binary: rustc
commit-hash: 2d03399f53d28a8be645625376c0c9fbe601a01d
commit-date: 2020-04-27
host: x86_64-apple-darwin
release: 1.45.0-nightly
LLVM version: 9.0
```
|
C-enhancement,A-diagnostics,T-compiler
|
low
|
Critical
|
624,582,251 |
pytorch
|
[FR] [distributed] coalesced primitives
|
## 🚀 Feature
`broadcast_coalesced`, `all_reduce_coalesced` and others will in many cases improve communication among processes. It would be great if core can provide the coalesced versions of these primitives, considering some of which are already implemented and used by DDP, etc., and that the coalescing helpers `unflatten_*` and `flatten_*` functions are already efficiently implemented in cpp in `cuda/comm.cpp` in core.
Parity with `torch.cuda.comm` could be another argument for having these.
Whether they should be separate methods or an additional flag on existing primitives is worth discussion. But either way, I really hope that PyTorch core can provide such generally useful functionalities.
cc @pietern @mrshenli @pritamdamania87 @zhaojuanmao @satgera @rohan-varma @gqchen @aazzolini @xush6528 @osalpekar
|
oncall: distributed,triaged
|
low
|
Major
|
624,583,611 |
pytorch
|
[FR] API consistency for cuda.comm and distributed
|
`torch.cuda.comm` and `torch.distributed` have similar but subtly different API sets. It would be great to make them consistent, and document the former.
cc @ngimel @pietern @mrshenli @pritamdamania87 @zhaojuanmao @satgera @rohan-varma @gqchen @aazzolini @xush6528 @osalpekar
|
oncall: distributed,module: docs,module: cuda,triaged
|
low
|
Minor
|
624,583,882 |
pytorch
|
[doc] document cuda.nccl
|
`torch.cuda.nccl` seems meant to be a set of low-level API (compared to `torch.cuda.comm` and `torch.distributed`). It would be great to document it.
cc @ngimel
|
module: docs,module: cuda,triaged,module: nccl
|
low
|
Minor
|
624,601,175 |
rust
|
Inconsistent handling of associated constants in patterns
|
The following code compiles:
```rust
trait Foo {
const C: i32;
}
impl<T> Foo for T {
const C: i32 = 0;
}
fn bar<T>() {
match 0 {
<T as Foo>::C => (),
_ => (),
}
}
```
but adding a trait bound of `Foo` to `bar`:
```rust
trait Foo {
const C: i32;
}
impl<T> Foo for T {
const C: i32 = 0;
}
fn bar<T: Foo>() {
match 0 {
<T as Foo>::C => (),
_ => (),
}
}
```
causes compilation to fail with:
```
error[E0158]: associated consts cannot be referenced in patterns
--> src/main.rs:14:9
|
14 | <T as Foo>::C => (),
| ^^^^^^^^^^^^^
error: aborting due to previous error
For more information about this error, try `rustc --explain E0158`.
error: could not compile `playground`.
To learn more, run the command again with --verbose.
```
I would expect these two cases to behave identically instead of one working and the other failing. (it seems like both cases should be disallowed, but I don't have a good grasp of the current state of relevant features)
This is reproducible in the rust playground on the stable, beta, and nightly channels
|
A-trait-system,A-associated-items,T-compiler,C-bug,A-const-eval,A-patterns,T-types
|
low
|
Critical
|
624,673,634 |
flutter
|
[OpenContainer] pass a navigator key as an argument to OpenContainer
|
When using OpenContainer widget from animations package, back button at the closedBuilder widget, pops the parent Navigator (I'm using nested navigator).
Is it possible to pass a navigator key as an argument to OpenContainer so we'll have a control with which navigator to navigate (including pop action)?
OpenContainer widget:
```
return OpenContainer(
closedBuilder: (context, action) {
return SummaryItem(
summary: summary,
);
},
openBuilder: (context, action) {
return DetailsScreen(
summary: summary,
),
},
closedElevation: 2.0,
openElevation: 15.0,
closedShape: const RoundedRectangleBorder(
borderRadius: BorderRadius.all(Radius.circular(10.0)),
),
transitionType: ContainerTransitionType.fadeThrough,
transitionDuration: const Duration(milliseconds: 500),
);
```
Flutter doctor:
```
[✓] Flutter (Channel stable, v1.17.1, on Mac OS X 10.15.4 19E287, locale en-IL)
• Flutter version 1.17.1 at /Users/yuvwork/Developer/flutter
• Framework revision f7a6a7906b (13 days ago), 2020-05-12 18:39:00 -0700
• Engine revision 6bc433c6b6
• Dart version 2.8.2
[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.3)
• Android SDK at /Users/yuvwork/Library/Android/sdk
• Platform android-29, build-tools 29.0.3
• Java binary at: /Applications/Android
Studio.app/Contents/jre/jdk/Contents/Home/bin/java
• Java version OpenJDK Runtime Environment (build
1.8.0_212-release-1586-b4-5784211)
• All Android licenses accepted.
[✓] Xcode - develop for iOS and macOS (Xcode 11.5)
• Xcode at /Applications/Xcode.app/Contents/Developer
• Xcode 11.5, Build version 11E608c
• CocoaPods version 1.9.1
[✓] Android Studio (version 3.6)
• Android Studio at /Applications/Android Studio.app/Contents
• Flutter plugin version 45.1.1
• Dart plugin version 192.8052
• Java version OpenJDK Runtime Environment (build
1.8.0_212-release-1586-b4-5784211)
[✓] Connected device (2 available)
• Android SDK built for x86 • emulator-5554 •
android-x86 • Android 10 (API 29) (emulator)
• iPhone SE (2nd generation) • 4B87D091-6516-4BA6-8C95-5DAF4DBB4637 • ios
• com.apple.CoreSimulator.SimRuntime.iOS-13-5 (simulator)
• No issues found!
```
|
package,c: proposal,p: animations,team-ecosystem,P3,triaged-ecosystem
|
low
|
Major
|
624,685,489 |
flutter
|
Integration flutter to app, file path issue when indexing on AppCode IDE
|
## Steps to Reproduce
<!-- Please tell us exactly how to reproduce the problem you are running into. -->
1. follow https://flutter.dev/docs/development/add-to-app/ios/project-setup#option-a---embed-with-cocoapods-and-the-flutter-sdk
## Logs
bug in Appcode https://youtrack.jetbrains.com/issue/OC-17593
## solution
https://www.kikt.top/posts/flutter/channel/flutter-ios-spec-edit/
just modify *podhelper.rb*
```
# plugin_pods.map do |r|
# symlink = File.join(symlinks_dir, r[:name])
# FileUtils.rm_f(symlink)
# File.symlink(r[:path], symlink)
# pod r[:name], :path => File.join(symlink, 'ios'), :inhibit_warnings => true
# end
```
to
```
plugin_pods.map { |p|
name = p[:name]
path = p[:path]
specPath = "#{path}/ios/#{name}.podspec"
pod p[:name],:path=>specPath
}
```
|
platform-ios,tool,a: existing-apps,P3,team-ios,triaged-ios
|
low
|
Critical
|
624,751,196 |
kubernetes
|
API Server supports insecure TLS ciphersuites
|
<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks!
If the matter is security related, please disclose it privately via https://kubernetes.io/security/
-->
**Description**
API Server allows administrators to configure TLS connections to use a variety of insecure cipher suites. In particular it supports the use of RC4 and 3DES in its symmetric suites. RC4 has known bias in its output and should never be used, while 3DES is an extremely deprecated 64-bit block cipher which is both slow and unneeded. Additionally, non-forward secure key exchange is supported (TLS_RSA_*). This, along with SHA-based cipher suites, should be deprecated and replaced.
**Recommendation**
Remove support for any cipher suite that uses RC4 or 3DES as well as non-forward secure key exchange suites (TLS_RSA_*). Deprecate all but the following cipher suite options for TLS versions up through 1.2:
```
TLS_ECDHE_ECDSA_WITH_AES_256_GCM_SHA384
TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256
TLS_ECDHE_ECDSA_WITH_CHACHA20_POLY1305_SHA256
TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256
TLS_ECDHE_RSA_WITH_CHACHA20_POLY1305_SHA256
```
**How to reproduce it**:
1. Start the api-server with weak/insecure cipher suites using `--tls-cipher-suites`:
```
--tls-cipher-suites=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256,TLS_RSA_WITH_RC4_128_SHA,TLS_RSA_WITH_AES_128_CBC_SHA256,TLS_ECDHE_ECDSA_WITH_RC4_128_SHA,TLS_ECDHE_RSA_WITH_RC4_128_SHA,TLS_ECDHE_ECDSA_WITH_AES_128_CBC_SHA256,TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256
```
Note: that `TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256` is not currently classified as weak or insecure, however it is required for the API Server running with HTTP2 enabled (default).
2. Using a modified `kubectl` that _only supports_ weak/insecure ciphers, a user can disable HTTP2 and establish a insecure connection with the API Server:
```
$ DISABLE_HTTP2=true kubectl_weak get pods --all-namespaces
I0514 09:03:11.918628 16970 http.go:122] HTTP2 has been explicitly disabled
NAMESPACE NAME READY STATUS RESTARTS AGE
kube-system kube-dns-c74654849-jqv9t 2/3 Running 0 45s
```
**Anything else we need to know?:**
This issue is derived from #81145, which focused on the kubelet.
To view the original finding, begin on page 89 of the [Kubernetes Security Review Report](https://github.com/kubernetes/community/blob/master/wg-security-audit/findings/Kubernetes%20Final%20Report.pdf).
See #81146 for current status of all issues created from these findings.
The vendor considers the original issue of Informational Severity.
**Environment**:
- Kubernetes version: `1.18.3`
/area security
/sig auth
/sig api-machinery
/wg security-audit
[DisableHTTP2]:https://github.com/kubernetes/kubernetes/blob/3b024339bd67b80e79a161bc295f6fe609eff076/staging/src/k8s.io/apiserver/pkg/server/config.go#L267
|
area/security,kind/cleanup,priority/awaiting-more-evidence,sig/api-machinery,sig/auth,help wanted,wg/security-audit,sig/security,triage/accepted
|
medium
|
Critical
|
624,756,225 |
godot
|
texture_set_shrink_all_x2_on_set_data and/or VRAM counting in editor doesn't work
|
<!-- Please search existing issues for potential duplicates before filing yours:
https://github.com/godotengine/godot/issues?q=is%3Aissue
-->
**Godot version:** 3.2.1
<!-- Specify commit hash if using non-official build. -->
**OS/device including version:** Linux 64b, NVidia 2080ti (440.82), GLES3
<!-- Specify GPU model, drivers, and the backend (GLES2, GLES3, Vulkan) if graphics-related. -->
**Issue description:**
<!-- What happened, and what was expected. -->
I have a following setup: `App` loads `Main` which loads a specific level. In case of `low_res` the `texture_set_shrink_all_x2_on_set_data` is called in `App._ready` before loading starts (`App` uses `ResourceLoader.load_interactive`, `Main` uses `resource_queue` script from docs).
| Mode | low_res | VRAM from nvtop** | VRAM from editor* | biggest asset in VRAM from editor |
| -------- | ----------------------------------------------------- | --------------- | ----------------- | --------------------------------- |
| exported | yes | 3502MB | - | - |
| editor | yes | 4083MB | 16.00 EiB | 35.61 MiB |
| exported | no | 6514MB | - | - |
| editor | no | 6514MB | 450.2 MiB | 35.61 MiB |
*: Debugger -> Video RAM -> Total
**: VRAM per game process
Total VRAM in editor seems to be completely broken (EiB? 450MiB vs 6514MB from nvtop?), so I will ignore it.
If hi res version occupies ~6.5GB, why isn't low res version occupying quarter of that value (half size in two dimensions)? 53% vs expected 25% is a big difference. Maybe it's related to a VRAM compression (which we use)? Why is biggest asset (it's from a level) in both cases of same VRAM size? It seems to me that either "VRAM usage by resource" is broken in editor as well or `texture_set_shrink_all_x2_on_set_data` isn't working for all assets. I don't know how to proceed further in troubleshooting this.
Unfortunately I cannot share the project.
<!-- **Steps to reproduce:** -->
<!-- **Minimal reproduction project:** -->
<!-- A small Godot project which reproduces the issue. Drag and drop a zip archive to upload it. -->
|
bug,topic:rendering,topic:editor,confirmed
|
low
|
Critical
|
624,792,099 |
material-ui
|
[Select] Prop component + value breaks compilation for MenuItem
|
<!-- Provide a general summary of the issue in the Title above -->
Combination of both prop `component` + prop `value` seems incompatible.
<!--
Thank you very much for contributing to Material-UI by creating an issue! ❤️
To avoid duplicate issues we ask you to check off the following list.
-->
<!-- Checked checkbox should look like this: [x] -->
- [x] The issue is present in the latest release.
- [x] I have searched the [issues](https://github.com/mui-org/material-ui/issues) of this repository and believe that this is not a duplicate.
## Current Behavior 😯
`value`, a valid prop for `MenuItem` (inherit from `li` native element) seems to break compilation, if provided along with `component` prop. No matter if `component` is a native HTML element, a custom component or MUI component.
<!-- Describe what happens instead of the expected behavior. -->
## Expected Behavior 🤔
<!-- Describe what should happen. -->
You can use both props w/o typescript compilation errors.
## Steps to Reproduce 🕹
<!--
Provide a link to a live example (you can use codesandbox.io) and an unambiguous set of steps to reproduce this bug.
Include code to reproduce, if relevant (which it most likely is).
You should use the official codesandbox template as a starting point: https://material-ui.com/r/issue-template
If you have an issue concerning TypeScript please start from this TypeScript playground: https://material-ui.com/r/ts-issue-template
Issues without some form of live example have a longer response time.
-->
As you can see in the [demo](https://codesandbox.io/s/material-demo-2wbmx?file=/demo.tsx), every combination should be acceptable. As you can see in the second case, `component="Typography"` lets you use any Typography prop along with MenuItem props. You can comment line 18 to check this out. But when it comes to `value`, Typescript complains for line 15
~~~
Property 'component' does not exist on type 'IntrinsicAttributes & { action?: Ref<ButtonBaseActions>; buttonRef?: Ref<unknown>; centerRipple?: boolean; disabled?: boolean; disableRipple?: boolean; ... 4 more ...; TouchRippleProps?: Partial<...>; } & { ...; } & { ...; } & CommonProps<...> & Pick<...>'
~~~
I've check out how MenuItem is basically a ListItem with aditional props, and the problem persists as well using this component. Probably is something with OverridableComponent interface or BaseButton, im not sure.
## Context 🔦
<!--
What are you trying to accomplish? How has this issue affected you?
Providing context helps us come up with a solution that is most useful in the real world.
-->
This "value" prop, not only an acceptable prop for native element, but it is indirectly being supported as [MUI documentation for Select](https://material-ui.com/api/select/#props) allows you to use MenuItem as children, but I couldn't find a demo with, also, a prop component.
## Your Environment 🌎
<!--
Include as many relevant details about the environment with which you experienced the bug.
If you encounter issues with typescript please include version and tsconfig.
-->
| Tech | Version |
| ----------- | ------- |
| Material-UI | v4.10.0 (latest) |
| React | v16.13.1 |
| Browser | 83.0.4103.61 |
| TypeScript | 3.9.3 |
|
component: select,typescript
|
low
|
Critical
|
624,811,458 |
node
|
Explicit pipe events for streams
|
Right now it's a bit ... hackish ... to detect piping from/to a stream.
You have to do some tricks with the `newListener` event to see if a data listener is attached.
Makes me wonder if we shouldn't add more explicit pipeing events such as
- `src.emit('pipe-to', dst)` when a readable is being piped somewhere
- `dst.emit('pipe-from', src)` when a writable is being piped to.
We do emit `pipe` atm on the dst i think, but having more explicit events makes it more clear I think.
/cc @mcollina @ronag
We are discussing this in streamx as well which is where this came up: https://github.com/mafintosh/streamx/issues/16
|
stream
|
low
|
Major
|
624,836,298 |
electron
|
Feature Request: Taskbar location for Windows
|
It would be good to have API to be able to determine the taskbar's location in Windows (including for multiple displays)
|
enhancement :sparkles:,platform/windows
|
low
|
Minor
|
624,903,550 |
TypeScript
|
Add undefined to tuple index signature, or reject keys that are not "keyof tuple"
|
## Search Terms
Tuple index signature
## Suggestion
I am opening up this issue as Seperate from https://github.com/microsoft/TypeScript/issues/13778 since I am ok with the current interpretation of the Array.
```ts
declare var strArray: string[] // infinitely long list of type string
var a : strArray[10 as number] // ok; a is string
```
but this fails in conjunction with tuples
```ts
declare var strTuple: [number, number] // length = 2
var a : strTuple[10 as number] // absolutely not ok; a is string;
```
<!-- A summary of what you'd like to see added or changed -->
### Better Options:
`var a : strTuple[10 as number] ` should either be `string | undefined` or it should give a type error similar to:
```ts
var a = { 0: 10, 1: 20} as const;
a[10 as number]; // type 'number' can't be used to index type
```
Tuples are already aware of boundaries and properly return undefined for more specific number types:
```ts
const t0: [string][0] = 'hello' // ok
const t1: [string][1] = 'hello' // Type '"hello"' is not assignable to type 'undefined'.
// therefore this is already true!
const t2: [string][0|1] // string | undefined
```
why would type `number` act any differently?
## Use Cases
// Easy fix for for loops
```ts
for (let i = 0 as 0 | 1; i < 2; i++) {
var definitly_string = strTuple[i] // type string
var j = i + someNumber;
var not_definitly_string = strTuple[j] //lets you know you need to be careful
}
```
You could use `keyof typeof strTuple` instead of `0 | 1` when you fix this https://github.com/microsoft/TypeScript/issues/27995
```ts
for (let i = 0 as keyof typeof strTuple; i < strTuple.length; i++) {
var definitly_string = strTuple[i] // type string
var j = i + someNumber;
var not_definitly_string = strTuple[j] //lets you know you need to be careful
}
```
<!--
What do you want to use this for?
What shortcomings exist with current approaches?
-->
Given that `strictNullChecks` still allow typed arrays to do this:
```ts
var notString1 = strArray[Infinity]; // no error, not undefined
var notString2 = strArray[NaN]; // no error, not undefined
```
It would be nice to have a mechanism that could allow you to declare arrays with better type safety.
## Examples
<!-- Show how this would be used and what the behavior would be -->
## Checklist
My suggestion meets these guidelines:
* [x] This wouldn't be a breaking change in existing TypeScript/JavaScript code
* [x] This wouldn't change the runtime behavior of existing JavaScript code
* [x] This could be implemented without emitting different JS based on the types of the expressions
* [x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
* [x] This feature would agree with the rest of [TypeScript's Design Goals](https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals).
|
Suggestion,Awaiting More Feedback
|
low
|
Critical
|
624,940,429 |
PowerToys
|
Taskbar widget to view currently selected virtual desktop
|
# Taskbar widget to view currently selected virtual desktop
(First off, THANK YOU for these tools! FancyZones, etc, are great for workflow)
It doesn't seem we have a native Windows feature to see which virtual desktop we're on **at a glance**.
A taskbar "toolbar" aka DeskBand lends itself well since it remains consistent while the desktops shuffle.
It's particularly compelling now that we can name virtual desktops in Win10 20-04, yay! =)
# Proposed technical implementation details
I've implemented a [rough working example here](https://github.com/Beej126/Win10VirtualDesktopDeskBand) and am already pleased with the workflow enhancement it provides.
|
Idea-Enhancement,Product-Virtual Desktop
|
low
|
Major
|
624,947,266 |
create-react-app
|
Hot reloading security risk by default
|
### Is your proposal related to a problem?
By default, the hot reloading functionality enabled in create-react-app, allows random websites to access the local development server error logs via websockets. These error logs can contain code and sensitive data, which can then be leaked out to external websites.
The problem is described here: https://medium.com/@stestagg/stealing-secrets-from-developers-using-websockets-254f98d577a0
### Describe the solution you'd like
Access to the local websocket server should be restricted. For example with a random secret.
|
issue: proposal,needs triage
|
low
|
Critical
|
624,947,891 |
flutter
|
SystemSound.play should not lower volume of music playback on iOS
|
<!-- Thank you for using Flutter!
If you are looking for support, please check out our documentation
or consider asking a question on Stack Overflow:
* https://flutter.dev/
* https://api.flutter.dev/
* https://stackoverflow.com/questions/tagged/flutter?sort=frequent
If you have found a bug or if our documentation doesn't have an answer
to what you're looking for, then fill our the template below. Please read
our guide to filing a bug first: https://flutter.dev/docs/resources/bug-reports
-->
## Steps to Reproduce
<!-- You must include full steps to reproduce so that we can reproduce the problem. -->
1. Create an IconButton or BottomNavigationBar (I believe this is general behavior but I've specifically tested those widgets.)
2. Tap one while playing music on iOS. The music plays quieter for the duration of the tap sound effect.
**Expected results:** <!-- what did you want to see? -->
Music playback is unaffected.
**Actual results:** <!-- what did you see? -->
The music plays quieter for the duration of the tap sound effect.
<details>
<summary>Logs</summary>
<!-- Finally, paste the output of running `flutter doctor -v` here. -->
```
[✓] Flutter (Channel stable, v1.17.1, on Mac OS X 10.15.4 19E287, locale en-US)
• Flutter version 1.17.1 at [REDACTED]
• Framework revision f7a6a7906b (2 weeks ago), 2020-05-12 18:39:00 -0700
• Engine revision 6bc433c6b6
• Dart version 2.8.2
[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.0)
• Android SDK at [REDACTED]
• Platform android-29, build-tools 29.0.0
• Java binary at: /Library/Java/JavaVirtualMachines/jdk1.8.0_202.jdk/Contents/Home/jre/bin/java
• Java version Java(TM) SE Runtime Environment (build 1.8.0_202-ea-b03)
• All Android licenses accepted.
[✓] Xcode - develop for iOS and macOS (Xcode 11.5)
• Xcode at /Applications/Xcode.app/Contents/Developer
• Xcode 11.5, Build version 11E608c
• CocoaPods version 1.8.4
[!] Android Studio (not installed)
• Android Studio not found; download from https://developer.android.com/studio/index.html
(or visit https://flutter.dev/docs/get-started/install/macos#android-setup for detailed instructions).
[!] IntelliJ IDEA Ultimate Edition (version 2020.1.1)
• IntelliJ at /Applications/IntelliJ IDEA.app
✗ Flutter plugin not installed; this adds Flutter specific functionality.
✗ Dart plugin not installed; this adds Dart specific functionality.
• For information about installing plugins, see
https://flutter.dev/intellij-setup/#installing-the-plugins
[!] VS Code (version 1.44.2)
• VS Code at /Applications/Visual Studio Code.app/Contents
✗ Flutter extension not installed; install from
https://marketplace.visualstudio.com/items?itemName=Dart-Code.flutter
[✓] Connected device (2 available)
• Pixel 2 • [REDACTED] • android-arm64 • Android 10 (API 29)
• iPhone • [REDACTED] • ios • iOS 13.5
```
</details>
## Sample Code
See: https://api.flutter.dev/flutter/material/BottomNavigationBar-class.html
(The issue can be seen when tapping items in the BottomNavigationBar)
```dart
// Flutter code sample for BottomNavigationBar
// This example shows a [BottomNavigationBar] as it is used within a [Scaffold]
// widget. The [BottomNavigationBar] has three [BottomNavigationBarItem]
// widgets and the [currentIndex] is set to index 0. The selected item is
// amber. The `_onItemTapped` function changes the selected item's index
// and displays a corresponding message in the center of the [Scaffold].
//
// 
import 'package:flutter/material.dart';
void main() => runApp(MyApp());
/// This Widget is the main application widget.
class MyApp extends StatelessWidget {
static const String _title = 'Flutter Code Sample';
@override
Widget build(BuildContext context) {
return MaterialApp(
title: _title,
home: MyStatefulWidget(),
);
}
}
class MyStatefulWidget extends StatefulWidget {
MyStatefulWidget({Key key}) : super(key: key);
@override
_MyStatefulWidgetState createState() => _MyStatefulWidgetState();
}
class _MyStatefulWidgetState extends State<MyStatefulWidget> {
int _selectedIndex = 0;
static const TextStyle optionStyle =
TextStyle(fontSize: 30, fontWeight: FontWeight.bold);
static const List<Widget> _widgetOptions = <Widget>[
Text(
'Index 0: Home',
style: optionStyle,
),
Text(
'Index 1: Business',
style: optionStyle,
),
Text(
'Index 2: School',
style: optionStyle,
),
];
void _onItemTapped(int index) {
setState(() {
_selectedIndex = index;
});
}
@override
Widget build(BuildContext context) {
return Scaffold(
appBar: AppBar(
title: const Text('BottomNavigationBar Sample'),
),
body: Center(
child: _widgetOptions.elementAt(_selectedIndex),
),
bottomNavigationBar: BottomNavigationBar(
items: const <BottomNavigationBarItem>[
BottomNavigationBarItem(
icon: Icon(Icons.home),
title: Text('Home'),
),
BottomNavigationBarItem(
icon: Icon(Icons.business),
title: Text('Business'),
),
BottomNavigationBarItem(
icon: Icon(Icons.school),
title: Text('School'),
),
],
currentIndex: _selectedIndex,
selectedItemColor: Colors.amber[800],
onTap: _onItemTapped,
),
);
}
}
```
|
platform-ios,framework,engine,has reproducible steps,P2,found in release: 3.7,found in release: 3.8,team-ios,triaged-ios
|
low
|
Critical
|
624,971,746 |
pytorch
|
[docs] Urls changed => forum links would become invalid
|
Originally in https://github.com/pytorch/pytorch/issues/18095#issuecomment-633149307:
@vadimkantorov:
Works: https://pytorch.org/docs/stable/torch.html#torch.flip
Breaks: https://pytorch.org/docs/master/torch.html#torch.flip
@t-vi:
They're now separate pages: https://pytorch.org/docs/master/generated/torch.flip.html#torch.flip
...but it would break many links, including on the forums.
@ezyang:
Yes, this will be a release blocker for next release.
cc @ezyang @gchanan @zou3519 @kadeng @msaroufim @svekars @brycebortree @mattip
|
high priority,module: docs,triaged,module: doc infra
|
medium
|
Critical
|
624,987,206 |
pytorch
|
Missing OneCycleLR and MultiplicativeLR in lr_scheduler.pyi
|
## 🐛 Bug
Not sure if it's a bug but it misses `OneCycleLR` and `MultiplicativeLR` in `lr_scheduler.pyi`
## To Reproduce
Steps to reproduce the behavior:
`from torch.optim.lr_scheduler import OneCycleLR, MultiplicativeLR` using PyCharm
or check `https://github.com/pytorch/pytorch/blob/master/torch/optim/lr_scheduler.pyi`
## Environment
PyTorch version: 1.5.0
Is debug build: No
CUDA used to build PyTorch: 10.2
OS: CentOS Linux release 7.7.1908 (Core)
GCC version: (GCC) 4.8.5 20150623 (Red Hat 4.8.5-39)
CMake version: version 2.8.12.2
Python version: 3.8
Is CUDA available: Yes
CUDA runtime version: Could not collect
GPU models and configuration: GPU 0: Quadro M1200
Nvidia driver version: 430.26
cuDNN version: Could not collect
Versions of relevant libraries:
[pip] numpy==1.18.1
[pip] pytorch-sphinx-theme==0.0.24
[pip] torch==1.5.0
[pip] torchfile==0.1.0
[pip] torchvision==0.6.0a0+82fd1c8
[conda] blas 1.0 mkl
[conda] cudatoolkit 10.2.89 hfd86e86_1
[conda] mkl 2020.1 217
[conda] mkl-service 2.3.0 py38he904b0f_0
[conda] mkl_fft 1.0.15 py38ha843d7b_0
[conda] mkl_random 1.1.0 py38h962f231_0
[conda] numpy 1.18.1 py38h4f9e942_0
[conda] numpy-base 1.18.1 py38hde5b4d6_1
[conda] pytorch 1.5.0 py3.8_cuda10.2.89_cudnn7.6.5_0 pytorch
[conda] pytorch-sphinx-theme 0.0.24 dev_0 <develop>
[conda] torchfile 0.1.0 pypi_0 pypi
[conda] torchvision 0.6.0 py38_cu102 pytorch
cc @ezyang
|
module: typing,triaged
|
low
|
Critical
|
625,007,002 |
vscode
|
Seeing output running out of sources related to CoreText
|
```
2020-05-26 18:11:47.989 Code - OSS Helper (Renderer)[40222:1396462] CoreText note: Client requested name ".NewYork-Regular", it will get Times-Roman rather than the intended font. All system UI font access should be through proper APIs such as CTFontCreateUIFontForLanguage() or +[NSFont systemFontOfSize:].
2020-05-26 18:11:47.989 Code - OSS Helper (Renderer)[40222:1396462] CoreText note: Set a breakpoint on CTFontLogSystemFontNameRequest to debug.
2020-05-26 18:11:47.995 Code - OSS Helper (Renderer)[40222:1396462] CoreText note: Client requested name ".NewYork-Regular", it will get Times-Roman rather than the intended font. All system UI font access should be through proper APIs such as CTFontCreateUIFontForLanguage() or +[NSFont systemFontOfSize:].
2020-05-26 18:11:47.998 Code - OSS Helper (Renderer)[40222:1396462] CoreText note: Client requested name ".NewYork-Regular", it will get Times-Roman rather than the intended font. All system UI font access should be through proper APIs such as CTFontCreateUIFontForLanguage() or +[NSFont systemFontOfSize:].
2020-05-26 18:11:47.998 Code - OSS Helper (Renderer)[40222:1396462] CoreText note: Client requested name ".NewYork-Regular", it will get Times-Roman rather than the intended font. All system UI font access should be through proper APIs such as CTFontCreateUIFontForLanguage() or +[NSFont systemFontOfSize:].
```
|
bug,upstream,macos,upstream-issue-linked,chromium
|
low
|
Critical
|
625,096,407 |
vscode
|
Custom editors cannot be opened when a single-folder workspace has Been Extended To A Multi-Folder Workspace
|
<!-- ⚠️⚠️ Do Not Delete This! bug_report_template ⚠️⚠️ -->
<!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ -->
<!-- Please search existing issues to avoid creating duplicates. -->
<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: https://code.visualstudio.com/insiders/ -->
<!-- Use Help > Report Issue to prefill these. -->
- VSCode Version: 1.45.1 / Insiders 2020-05-26T15:51:05.752Z
- OS Version: Windows 10 / Mac
Steps to Reproduce:
1. [Check out Cat Customs Sample](https://github.com/microsoft/vscode-extension-samples/tree/master/custom-editor-sample)
2. Install the extension
3. Copy the `exampleFiles` folder to `exampleFiles2`
4. Open a new VS Code Instance with `exampleFiles` as root folder
5. (Custom Editor works as intended)
6. Add `exampleFiles2` to the workspace.
7. Open `example.cscratch` in `exampleFile2` folder.
8. It crashes.
Does this issue occur when all extensions are disabled?: Yes
[You can see this happening with my draw.io extension too](https://imgur.com/53j7C1u):
https://github.com/hediet/vscode-drawio/issues/61
|
bug,help wanted,webview,custom-editors
|
low
|
Critical
|
625,113,520 |
flutter
|
TextTheme TextStyle name changes should have come with a Refactoring Tool
|
This is more of a Post-Mortem + Feature Request for future updates than an actual bug report.
The change that deprecated most of the names of the TextTheme TextStyles was https://github.com/flutter/flutter/pull/48547.
I don't mind breaking changes in Flutter, I even encourage them. I believe we should make them as soon as possible while the Framework is young so we don't accumulate a huge list of not ideal APIs for "historical reasons".
That being said, I also believe that those breaking changes should try to be as transparent as possible, leveraging refactoring tools as much as they can.
RxDart for [example](https://github.com/ReactiveX/rxdart#upgrading-from-rxdart-022x-to-023x) made a [tool](https://github.com/brianegan/rxdart_codmod) for automating refactoring for users upgrading from version 0.22.x to 0.23.x.
I upgraded to Flutter 1.17.1 with the new `Typography` API and this is how my Dart Analysis looks like:
Sure I can leverage some smart `Find and Replace` but still, it would be nicer to have such a tool already shipped along with the breaking changes.
|
framework,f: material design,c: proposal,team-design
|
low
|
Critical
|
625,115,158 |
pytorch
|
Cap DDP total number of buckets
|
@ngoyal2707 pointed out an important limitation of DDP. As of today, DDP creates buckets that's enough to hold the entire model. So, if the model size is 100MB and the `bucket_cap_mb=20MB`, there will be 5 buckets. This works well for small models, and having multiple buckets and hence `allreduce` helps to increase link utilization. However, if the model size is super large, keeping a large number of buckets is an overkill. Instead, we could have another cap on the number of materialized buckets. This would help reduce DDP footprint.
cc @pietern @mrshenli @pritamdamania87 @zhaojuanmao @satgera @rohan-varma @gqchen @aazzolini @xush6528 @osalpekar
|
oncall: distributed,triaged
|
low
|
Minor
|
625,125,770 |
PowerToys
|
[Image Resizer]Scaling Method Option
|
Can you add options for scaling method?
Bilinear, Bicubic, Nearest Neighbor, etc.
|
Idea-Enhancement,Product-Image Resizer
|
low
|
Major
|
625,145,653 |
go
|
proposal: x/crypto/ssh: export structured disconnect message / reason error
|
### What version of Go are you using (`go version`)?
<pre>
$ go version
go version go1.14.3 linux/amd64
</pre>
### What operating system and processor architecture are you using (`go env`)?
<details><summary><code>go env</code> Output</summary><br><pre>
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/jayschwa/.cache/go-build"
GOENV="/home/jayschwa/.config/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/home/jayschwa/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/snap/go/5759"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/snap/go/5759/pkg/tool/linux_amd64"
GCCGO="gccgo"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="/home/jayschwa/golang-crypto/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build549371117=/tmp/go-build -gno-record-gcc-switches"
</pre></details>
### Proposal
The SSH protocol defines disconnect reason codes in [section 11.1 of RFC 4253](https://tools.ietf.org/html/rfc4253#section-11.1). I have an application where I want to inspect the disconnect reason code. I currently do this by checking the error string, but this is considered a bad practice.
Internally, the `x/crypto/ssh` package contains a `disconnectMsg` error type that is the structured form of the disconnect reason data. However, that type is not exposed externally for use with a function such as `errors.As`. I propose that `disconnectMsg` (or something like it) be exported so that users may unwrap the error and inspect the reason code.
|
Proposal,Proposal-Crypto
|
low
|
Critical
|
625,172,920 |
terminal
|
Using Windows+Shift+(arrow key) to move Terminal between monitors with different scaling ratios causes incorrect resize of the window
|
# Environment
```none
Windows build number: 10.0.18363.836
Windows Terminal version (if applicable): 1.0.1401.0
```
# Steps to reproduce
Two monitors in the environment: One is 4K resolution, scaling ratio 200%; the other is 1080p resolution, scaling ratio 100%
The 4K monitor is the default monitor.
Open Windows Terminal. It opens on the 4K monitor.
Use "Windows+Shift+right arrow" to move it to the 1080p monitor.
# Expected behavior
Windows Terminal should show up on the 1080p monitor with the same number of rows and columns as it had when it was on the 4K monitor. (This is what happens if you *drag* it over.)
# Actual behavior
Windows Terminal has been sized down and has half of the rows and columns that it had before the move.
|
Help Wanted,Issue-Bug,Area-UserInterface,Product-Terminal,Priority-3
|
low
|
Major
|
625,181,481 |
angular
|
Using directive in ICU in Ivy is not allowed, and the error message is really vague
|
<!--🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅
Oh hi there! 😄
To expedite issue processing please search open and closed issues before submitting a new one.
Existing issues often contain information about workarounds, resolution, or progress updates.
🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅-->
# 🐞 bug report
### Affected Package
@angular/compiler?
### Is this a regression?
No
### Description
<!-- ✍️--> A clear and concise description of the problem...
Ivy disallows using directives in ICU
```html
<span i18n>Updated: {minutes, plural,
=0 {just now}
=1 {one <b custom-directive>minute</b> ago}
other {{{minutes}} minutes ago by {gender, select, male {male} female {female} other {other}}}}
</span>
```
Will compile, but produce the following error in run-time:
```
InvalidCharacterError: Failed to execute 'setAttribute' on 'Element': '[custom-directive]' is not a valid attribute name.
```
This is misleading, better message would be something like
```
Directive [custom-directive] is not allowed in ICU
```
Or something similar
## 🔬 Minimal Reproduction
* Enable Ivy
* Create an empty custom directive
* Try using it in a template inside of ICU
<!--
Please create and share minimal reproduction of the issue starting with this template: https://stackblitz.com/fork/angular-issue-repro2
-->
I couldn't find how to enable Ivy in stackblitz
<!--
If StackBlitz is not suitable for reproduction of your issue, please create a minimal GitHub repository with the reproduction of the issue.
A good way to make a minimal reproduction is to create a new app via `ng new repro-app` and add the minimum possible code to show the problem.
Share the link to the repo below along with step-by-step instructions to reproduce the problem, as well as expected and actual behavior.
Issues that don't have enough info and can't be reproduced will be closed.
You can read more about issue submission guidelines here: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#-submitting-an-issue
-->
## 🔥 Exception or Error
<pre><code>
<!-- If the issue is accompanied by an exception or an error, please share it below: -->
<!-- ✍️-->
</code></pre>
## 🌍 Your Environment
Angular 9+ with Ivy
|
help wanted,area: i18n,hotlist: error messages,freq1: low,hotlist: google,type: confusing,P4
|
low
|
Critical
|
625,193,412 |
excalidraw
|
[grouping] selected and editing groups should be shared in collaborative mode
|
collaboration,grouping
|
low
|
Minor
|
|
625,203,428 |
rust
|
Tracking Issue for Extend::{extend_one,extend_reserve}
|
This is a tracking issue for the trait methods `Extend::extend_one` and `extend_reserve`.
The feature gate for the issue is `#![feature(extend_one)]`.
### About tracking issues
Tracking issues are used to record the overall progress of implementation.
They are also uses as hubs connecting to other relevant issues, e.g., bugs or open design questions.
A tracking issue is however *not* meant for large scale discussion, questions, or bug reports about a feature.
Instead, open a dedicated issue for the specific matter and add the relevant feature gate label.
### Steps
- [x] Implement the API
- [x] Adjust documentation ([see instructions on rustc-dev-guide][doc-guide])
- [ ] Stabilization PR ([see instructions on rustc-dev-guide][stabilization-guide])
[stabilization-guide]: https://rustc-dev-guide.rust-lang.org/stabilization_guide.html#stabilization-pr
[doc-guide]: https://rustc-dev-guide.rust-lang.org/stabilization_guide.html#documentation-prs
### Unresolved Questions
- Are these method names appropriate?
- Note that `Extend` is in the prelude, so the explicit `extend_` prefix avoids ambiguity.
- Is `Extend` the best place for just methods?
- One goal is to improve `Iterator::unzip`, which only has `Default + Extend`, so there's not really much choice.
### Implementation history
- Initial implementation in #72162.
|
A-collections,T-libs-api,B-unstable,C-tracking-issue,A-iterators,Libs-Tracked
|
medium
|
Critical
|
625,204,402 |
terminal
|
Access keys for new tab drop down menu items
|
<!--
🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨
I ACKNOWLEDGE THE FOLLOWING BEFORE PROCEEDING:
1. If I delete this entire template and go my own path, the core team may close my issue without further explanation or engagement.
2. If I list multiple bugs/concerns in this one issue, the core team may close my issue without further explanation or engagement.
3. If I write an issue that has many duplicates, the core team may close my issue without further explanation or engagement (and without necessarily spending time to find the exact duplicate ID number).
4. If I leave the title incomplete when filing the issue, the core team may close my issue without further explanation or engagement.
5. If I file something completely blank in the body, the core team may close my issue without further explanation or engagement.
All good? Then proceed!
-->
# Description of the new feature/enhancement
Currently, bringing up the new tab drop down requires using arrow keys to move to each option. It would make accessibility easier if users could press access keys that correlate with each entry to jump to that entry or cycle through similarly identified entries.
<!--
A clear and concise description of what the problem is that the new feature would solve.
Describe why and how a user would use this new functionality (if applicable).
-->
# Proposed technical implementation details (optional)
<!--
A clear and concise description of what you want to happen.
-->
One possible solution:
If the menu looks like the following,
* **P**owerShell
* **C**ommand Prompt
* **P**SCore
* <hr>
* **S**ettings
* **F**eedback
* **A**bout
It would be helpful if a user could press `p` twice to select "PSCore" or `c` once to select "Command Prompt". This may be doable simply by setting `AccessKey` for each `MenuFlyoutItem` in `TerminalPage::_CreateNewTabFlyout`.
Another possible solution would be to support `_` syntax, mirroring WPF's implementation in the config JSON's profile names.
|
Issue-Feature,Help Wanted,Area-UserInterface,Product-Terminal
|
low
|
Critical
|
625,207,902 |
bitcoin
|
build: Investigate aarch64 pointer authentication
|
This would entail adding `-mbranch-protection=standard` to our hardening flags. We should also check if this feature requires kernel/glibc support that our ABI doesn't include.
More info: https://fedoraproject.org/wiki/Changes/Aarch64_PointerAuthentication
|
Build system
|
low
|
Minor
|
625,228,416 |
flutter
|
InteractiveViewer overscroll
|
InteractiveViewer, introduced in https://github.com/flutter/flutter/pull/56409, should allow an overscroll feature in both directions when its boundary is reached. Google Photos and Apple Photos both have this feature after zooming in slightly on a photo. This is also mentioned in https://github.com/flutter/flutter/issues/20175.
Edit: Also, the physics involved should probably be configurable, similar to how it's possible to pass in scroll physics to a scroll view.
|
c: new feature,framework,c: proposal,P3,team-framework,triaged-framework
|
medium
|
Major
|
625,244,207 |
TypeScript
|
Comment directive activated when longer string used
|
<!-- 🚨 STOP 🚨 𝗦𝗧𝗢𝗣 🚨 𝑺𝑻𝑶𝑷 🚨
Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Even if you think you've found a *bug*, please read the FAQ first, especially the Common "Bugs" That Aren't Bugs section!
Please help us by doing the following steps before logging an issue:
* Search: https://github.com/Microsoft/TypeScript/search?type=Issues
Done.
* Read the FAQ: https://github.com/Microsoft/TypeScript/wiki/FAQ
Done.
Please fill in the *entire* template below.
-->
<!--
Please try to reproduce the issue with the latest published version. It may have already been fixed.
For npm: `typescript@next`
This is also the 'Nightly' version in the playground: http://www.typescriptlang.org/play/?ts=Nightly
-->
**TypeScript Version:** [email protected]
**NodeJS Version:** v12.16.2
**Visual Studio Code:**
```text
Version: 1.45.1 (system setup)
Commit: 5763d909d5f12fe19f215cbfdd29a91c0fa9208a
Date: 2020-05-14T08:27:35.169Z
Electron: 7.2.4
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Windows_NT x64 6.1.7601
```
<!-- Search terms you tried before logging this (so others can find this issue more easily) -->
**Search Terms:** comment directive, @ts-ignore
**Code**
```ts
let obj = { }
// @ts-ignoreThisShouldNotMatchButItDoes
console.log( `obj.a = ${obj.a}` )
```
**Expected behavior:**
Property 'a' does not exist on type 'object'.ts(2339)
**Actual behavior:**
compile time: no 2339 error or indication in VS Code
run time: obj.a = undefined
**Description**
Visual Studio code and running tsc will produce error 2339 when the comment directive is removed. When adding in the comment `// @ts-ignore` both Visual Studio code and tsc will ignore the error. However, misspelling `ts-ignore` as `ts-ignoree` or `ts-ignoreThisShouldNotMatchButItDoes` will invoke the `@ts-ignore` directive and ignore the error.
I didn't test other directives to see whether they had similar issues... trying to keep things simple, but this issue could be symptomatic of all comment directives, assuming they re-use the same code for parsing.
**Playground Link:** https://www.typescriptlang.org/play/?target=6&jsx=0&ssl=2&ssc=13&pln=2&pc=41#code/DYUwLgBA9gRgVhAvBA3hAvgKAPTYgATAGcBaASwHMA7KAJxABUALMogZSagFdgATAOShgAsgEMwAYyYAhLmACSYACJQQRTBKhUiUUADpgUCgAoIAA1hw9opBAAkKS9fRmIASkxA
**Related Issues:** None that I could find. Searched under @ts-ignore, comment directive
|
Bug
|
low
|
Critical
|
625,258,365 |
vscode
|
Bulb menu should open immediately after clicking on the info icon in the problems view
|
<!-- ⚠️⚠️ Do Not Delete This! feature_request_template ⚠️⚠️ -->
<!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ -->
<!-- Please search existing issues to avoid creating duplicates. -->
<!-- Describe the feature you'd like. -->
When working through large no.s of lints in the 'problems' pane I use the quick fix bulb to rapidly fix many trivial errors.
This process is slowed down by how the 'quick fix bulb' appears and then disappears.
The process I used to apply these fixes is:
Open the 'problems pane'.
click on the line
wait for the bulb to appear
click the bulb
select the action.
The problem is that the bulb will appear and then disappear before re-appearing.
It also changes color from white to yellow (which I'm sure indicates something but I've not worked it out as yet).
My preferred operation would be:
click line
click 'info' icon.
The code then looks for quick fixes and displays the menu.
This would eliminate the slight delay in having to wait for the bulb to appear.
|
feature-request,error-list
|
medium
|
Critical
|
625,339,484 |
rust
|
Suggest importable type that differs only in capitalization
|
```rust
struct S {
m: Hashmap<String, ()>,
}
```
```console
error[E0412]: cannot find type `Hashmap` in this scope
--> src/main.rs:2:8
|
2 | m: Hashmap<String, ()>,
| ^^^^^^^ not found in this scope
```
If the code had been written with `HashMap` instead of `Hashmap`, we would get the following extremely likely correct suggestion:
```console
error[E0412]: cannot find type `HashMap` in this scope
--> src/main.rs:2:8
|
2 | m: HashMap<String, ()>,
| ^^^^^^^ not found in this scope
|
help: consider importing one of these items
|
1 | use std::collections::HashMap;
|
1 | use std::collections::hash_map::HashMap;
|
```
`Hashmap` is a fairly common capitalization in other languages (https://grep.app/search?q=Hashmap&case=true) so it would be good to provide an appropriate suggestion in this case.
(For whatever reason this doesn't trigger #72640.)
<!-- TRIAGEBOT_START -->
<!-- TRIAGEBOT_ASSIGN_START -->
<!-- TRIAGEBOT_ASSIGN_DATA_START$${"user":"chrissimpkins"}$$TRIAGEBOT_ASSIGN_DATA_END -->
<!-- TRIAGEBOT_ASSIGN_END -->
<!-- TRIAGEBOT_END -->
|
C-enhancement,A-diagnostics,T-compiler,A-suggestion-diagnostics,D-papercut
|
low
|
Critical
|
625,363,276 |
opencv
|
opencv.js 4.x cannot new ORB/AKAZE with enum argument
|
##### System information (version)
- OpenCV => 4.x (4.0, 4.1, 4.2, 4.3 checked)
- Operating System / Platform => Mac Mini, Chrome 81.0.4044.138
- Compiler => Non, using "https://docs.opencv.org/4.x.0/opencv.js"
##### Detailed description
When I new ORB/AKAZE with enum argument, got error:
`UnboundTypeError: Cannot construct AKAZE due to unbound types: N2cv5AKAZE14DescriptorTypeE`
and
`UnboundTypeError: Cannot construct ORB due to unbound types: N2cv3ORB9ScoreTypeE`
No problem without arguments.
```javascript
// no error
new cv.ORB();
new cv.AKAZE();
```
##### Steps to reproduce
after loaded, code in console:
```javascript
orb = new cv.ORB(500, 1.2, 8, 31, 0, 2, cv.ORB_HARRIS_SCORE, 31, 20);
```
```javascript
akaze = new cv.AKAZE(cv.AKAZE_DESCRIPTOR_MLDB, 0, 3, 0.001, 4, 4, 1);
```
##### Issue submission checklist
- [x] I report the issue, it's not a question
<!--
OpenCV team works with answers.opencv.org, Stack Overflow and other communities
to discuss problems. Tickets with question without real issue statement will be
closed.
-->
- [x] I checked the problem with documentation, FAQ, open issues,
answers.opencv.org, Stack Overflow, etc and have not found solution
<!--
Places to check:
* OpenCV documentation: https://docs.opencv.org
* FAQ page: https://github.com/opencv/opencv/wiki/FAQ
* OpenCV forum: https://answers.opencv.org
* OpenCV issue tracker: https://github.com/opencv/opencv/issues?q=is%3Aissue
* Stack Overflow branch: https://stackoverflow.com/questions/tagged/opencv
-->
- [x] I updated to latest OpenCV version and the issue is still there
<!--
master branch for OpenCV 4.x and 3.4 branch for OpenCV 3.x releases.
OpenCV team supports only latest release for each branch.
The ticket is closed, if the problem is not reproduced with modern version.
-->
- [x] There is reproducer code and related data files: videos, images, onnx, etc
<!--
The best reproducer -- test case for OpenCV that we can add to the library.
Recommendations for media files and binary files:
* Try to reproduce the issue with images and videos in opencv_extra repository
to reduce attachment size
* Use PNG for images, if you report some CV related bug, but not image reader
issue
* Attach the image as archite to the ticket, if you report some reader issue.
Image hosting services compress images and it breaks the repro code.
* Provide ONNX file for some public model or ONNX file with with random weights,
if you report ONNX parsing or handling issue. Architecture details diagram
from netron tool can be very useful too. See https://lutzroeder.github.io/netron/
-->
|
category: javascript (js)
|
low
|
Critical
|
625,381,944 |
opencv
|
The virtual_try_on.py can change C++？
|
- OpenCV => 4.3
- Operating System / Platform => Windows 64 Bit
- Compiler => Visual Studio 2017
##### Detailed description
The virtual_try_on.py can change C++？
|
feature,category: samples,category: dnn
|
low
|
Minor
|
625,395,680 |
pytorch
|
PyTorch Issue w/ GPU
|
Hi,
My python code crash after I call 'backward()' method only in GPU mode, in CPU mode it works well.
This is my setup:
- - - -
1. GPU Device - NVIDIA GeForce RTX 2060 Super
2. Cuda - 10.2.89.441.22 (Display Driver 441.22)
3. Operation System - Windows 10 64 Bit (Ver 1903 OS Build 18362.836)
4. Python 3.8 64 Bit
5. PyTorch Version 1.5.0
I installed the PyTorch module through pip using the link generated by PyTorch.org (The link was generated by the pytorch.org generator according to my setup specifications)
* P.S - is_cuda_available() returns true
cc @ngimel
|
needs reproduction,module: cuda,triaged
|
low
|
Critical
|
625,444,717 |
youtube-dl
|
new version of DMAX (DE) site is not working
|
<!--
######################################################################
WARNING!
IGNORING THE FOLLOWING TEMPLATE WILL RESULT IN ISSUE CLOSED AS INCOMPLETE
######################################################################
-->
## Checklist
<!--
Carefully read and work through this check list in order to prevent the most common mistakes and misuse of youtube-dl:
- First of, make sure you are using the latest version of youtube-dl. Run `youtube-dl --version` and ensure your version is 2020.05.08. If it's not, see https://yt-dl.org/update on how to update. Issues with outdated version will be REJECTED.
- Make sure that all provided video/audio/playlist URLs (if any) are alive and playable in a browser.
- Make sure that all URLs and arguments with special characters are properly quoted or escaped as explained in http://yt-dl.org/escape.
- Search the bugtracker for similar issues: http://yt-dl.org/search-issues. DO NOT post duplicates.
- Finally, put x into all relevant boxes (like this [x])
-->
- [x] I'm reporting a broken site support
- [x] I've verified that I'm running youtube-dl version **2020.05.08**
- [x] I've checked that all provided URLs are alive and playable in a browser
- [x] I've checked that all URLs and arguments with special characters are properly quoted or escaped
- [x] I've searched the bugtracker for similar issues including closed ones
## Verbose log
<!--
Provide the complete verbose output of youtube-dl that clearly demonstrates the problem.
Add the `-v` flag to your command line you run youtube-dl with (`youtube-dl -v <your command line>`), copy the WHOLE output and insert it below. It should look similar to this:
[debug] System config: []
[debug] User config: []
[debug] Command-line args: [u'-v', u'http://www.youtube.com/watch?v=BaW_jenozKcj']
[debug] Encodings: locale cp1251, fs mbcs, out cp866, pref cp1251
[debug] youtube-dl version 2020.05.08
[debug] Python version 2.7.11 - Windows-2003Server-5.2.3790-SP2
[debug] exe versions: ffmpeg N-75573-g1d0487f, ffprobe N-75573-g1d0487f, rtmpdump 2.4
[debug] Proxy map: {}
<more lines>
-->
```
youtube-dl.exe --format bestvideo[ext=mp4]+hls-160000mp4a.40.2-eng -v --no-check-certificate https://dmax.de/sendungen/body-cam-911-polizeieinsatz-hautnah/
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['--format', 'bestvideo[ext=mp4]+hls-160000mp4a.40.2-eng', '-v', '--no-check-certificate', 'https://dmax.de/sendungen/body-cam-911-polizeieinsatz-hautnah/']
[debug] Encodings: locale cp1251, fs mbcs, out cp866, pref cp1251
[debug] youtube-dl version 2020.05.08
[debug] Python version 3.4.4 (CPython) - Windows-10-10.0.18362
[debug] exe versions: none
[debug] Proxy map: {}
[generic] body-cam-911-polizeieinsatz-hautnah: Requesting header
WARNING: Falling back on generic information extractor.
[generic] body-cam-911-polizeieinsatz-hautnah: Downloading webpage
[generic] body-cam-911-polizeieinsatz-hautnah: Extracting information
ERROR: Unsupported URL: https://dmax.de/sendungen/body-cam-911-polizeieinsatz-hautnah/
Traceback (most recent call last):
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmp4z7swgz7\build\youtube_dl\YoutubeDL.py", line 797, in extract_info
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmp4z7swgz7\build\youtube_dl\extractor\common.py", line 530, in extract
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmp4z7swgz7\build\youtube_dl\extractor\generic.py", line 3370, in _real_extract
youtube_dl.utils.UnsupportedError: Unsupported URL: https://dmax.de/sendungen/body-cam-911-polizeieinsatz-hautnah/
```
## Description
<!--
Provide an explanation of your issue in an arbitrary form. Provide any additional information, suggested solution and as much context and examples as possible.
If work on your issue requires account credentials please provide them or explain how one can obtain them.
-->
One or two weeks ago site of DMAX (DE), was completely redesign, and new URL and way of working with video was provided (all video of season are on same page without change URL for each episode). Now youtube-dl couldn't work with this site anymore.
|
DRM
|
low
|
Critical
|
625,457,573 |
flutter
|
Debug console only display log from print()
|
Problems: no exceptions or debug logs shown in console, only log from `print()` is being shown, similar to [41133](https://github.com/flutter/flutter/issues/41133)
Tested on:
- iPhone 5S iOS
- iPhone X
- iPhone 7
those device using iOS version 13
flutter doctor -v
```
[✓] Flutter (Channel master, 1.19.0-2.0.pre.143, on Mac OS X 10.15.4 19E287, locale en-US)
• Flutter version 1.19.0-2.0.pre.143 at /Applications/development/mobile/flutterSDK/flutter
• Framework revision 9d58a87066 (4 days ago), 2020-05-22 22:37:01 -0700
• Engine revision 9ce1e5c5c7
• Dart version 2.9.0 (build 2.9.0-10.0.dev 7706afbcf5)
[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.3)
• Android SDK at /Users/berkatbejana/Library/Android/sdk
• Platform android-29, build-tools 29.0.3
• Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
• Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b4-5784211)
• All Android licenses accepted.
[✓] Xcode - develop for iOS and macOS (Xcode 11.4.1)
• Xcode at /Applications/Xcode.app/Contents/Developer
• Xcode 11.4.1, Build version 11E503a
• CocoaPods version 1.9.0
[✓] Android Studio (version 3.6)
• Android Studio at /Applications/Android Studio.app/Contents
• Flutter plugin version 45.1.1
• Dart plugin version 192.8052
• Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b4-5784211)
[✓] Connected device (1 available)
• iPhone • 2295cce0eb128bb1d06c2b1eee522a1de3a7c6f7 • ios • iOS 13.3.1
```
|
platform-ios,tool,P3,team-ios,triaged-ios
|
low
|
Critical
|
625,476,179 |
TypeScript
|
Language service doesn't suggest global variables
|
Re-exporting global variables overwrites suggestions of global variables.
<!--
Please try to reproduce the issue with the latest published version. It may have already been fixed.
For npm: `typescript@next`
This is also the 'Nightly' version in the playground: http://www.typescriptlang.org/play/?ts=Nightly
-->
**TypeScript Version:** 3.7.x-dev.20200526
<!-- Search terms you tried before logging this (so others can find this issue more easily) -->
**Search Terms:**
**Code**
```ts
// global.ts
const global: typeof globalThis = void 0
|| typeof globalThis !== 'undefined' && globalThis
|| typeof self !== 'undefined' && self
|| Function('return this')();
export = global;
// module.ts
Obj
```
**Expected behavior:**
Language service suggests the `Object` variable defined as a global variable and the `Object` variable exported from global.ts.
**Actual behavior:**
Language service suggests the duplicate two `Object` variables exported from global.ts.
**Playground Link:** <!-- A link to a TypeScript Playground "Share" link which demonstrates this behavior -->
**Related Issues:** #36468 #35478
|
Bug,Domain: Completion Lists
|
low
|
Minor
|
625,483,350 |
rust
|
Missed optimization: Option<fieldless enum> equality
|
This is similar to #49892, but different.
It's not limited to non-zero integer types. This happens for any types that have holes but no uninitialized bits.
I think comparing `Option<some fieldless enum>` values is not uncommon, so it adds to the severity of the issue.
### To reproduce
1. Create the following program:
```rust
pub fn eq(x: Option<bool>, y: Option<bool>) -> bool {
x == y
}
```
2. Inspect generated code, for example by running
```
cargo rustc --release --lib -- --emit asm -Cllvm-args=--x86-asm-syntax=intel
```
Or just visit [godbolt](https://godbolt.org/z/XYaWdR).
### Expected result
```asm
eq:
cmp dil, sil
sete al
ret
```
### Actual result
```asm
eq:
cmp dil, 2
sete al
cmp sil, 2
setne cl
cmp al, cl
je .LBB0_1
mov al, 1
cmp dil, 2
je .LBB0_5
cmp sil, 2
je .LBB0_5
test dil, dil
sete cl
test sil, sil
setne al
xor al, cl
.LBB0_5:
ret
.LBB0_1:
xor eax, eax
ret
```
### Meta
This happens both on 1.43.0 stable and on the recent nightly:
```
> rustc --version --verbose
rustc 1.45.0-nightly (8970e8bcf 2020-05-23)
binary: rustc
commit-hash: 8970e8bcf6153d1ead2283f1a0ed7b192230eca6
commit-date: 2020-05-23
host: x86_64-pc-windows-msvc
release: 1.45.0-nightly
LLVM version: 10.0
```
|
I-slow,C-enhancement,T-compiler,C-optimization
|
low
|
Minor
|
625,500,063 |
terminal
|
The cursor jumps to the end of the line and immediately returns to the correct position when typing in a Git Bash profile
|
<!--
🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨
I ACKNOWLEDGE THE FOLLOWING BEFORE PROCEEDING:
1. If I delete this entire template and go my own path, the core team may close my issue without further explanation or engagement.
2. If I list multiple bugs/concerns in this one issue, the core team may close my issue without further explanation or engagement.
3. If I write an issue that has many duplicates, the core team may close my issue without further explanation or engagement (and without necessarily spending time to find the exact duplicate ID number).
4. If I leave the title incomplete when filing the issue, the core team may close my issue without further explanation or engagement.
5. If I file something completely blank in the body, the core team may close my issue without further explanation or engagement.
All good? Then proceed!
-->
<!--
This bug tracker is monitored by Windows Terminal development team and other technical folks.
**Important: When reporting BSODs or security issues, DO NOT attach memory dumps, logs, or traces to Github issues**.
Instead, send dumps/traces to [email protected], referencing this GitHub issue.
If this is an application crash, please also provide a Feedback Hub submission link so we can find your diagnostic data on the backend. Use the category "Apps > Windows Terminal (Preview)" and choose "Share My Feedback" after submission to get the link.
Please use this form and describe your issue, concisely but precisely, with as much detail as possible.
-->
# Environment
```none
Windows build number: Microsoft Windows [Version 10.0.18362.836]
Windows Terminal version (if applicable): 1.0.1401.0
Any other software?
- Git for Windows
```
# Steps to reproduce
Open a Git Bash tab. My profile looks like this:
```JSON
{
"guid": "{7f9476f7-58ca-491b-b101-43b38738ebcb}",
"name" : "Git Bash",
"tabTitle": "Git Bash",
"commandline" : "\"%ProgramFiles%\\Git\\usr\\bin\\bash.exe\" -i -l",
"hidden": false,
"startingDirectory" : "C:\\Git",
"closeOnExit" : true,
"colorScheme" : "Solarized Dark",
"cursorColor" : "#FFFFFF",
"cursorShape" : "bar",
"fontSize" : 10,
"historySize" : 9001,
"icon" : "%ProgramFiles%\\Git\\mingw64\\share\\git\\git-for-windows.ico",
"padding" : "8, 8, 8, 8",
"snapOnInput" : true,
"useAcrylic" : false
}
```
Type something like `git commit -m ""` and press left arrow to put your cursor into the quote marks.
Then type a commit message.
# Expected behavior
After you type a character the cursor should be drawn directly after that character.
# Actual behavior
The cursor jumps to the end of the line before returning to the correct position. Here is a gif of it happening:
The jumping happens with every typed character, but because of framerate reasons the gif only captured a jump after the second `r` in "cursor" and the `m` in "jumps".
|
Help Wanted,Issue-Bug,Area-TerminalControl,Product-Terminal,Priority-3,Area-WPFControl
|
medium
|
Critical
|
625,517,146 |
rust
|
Wrong use closure help for const generics
|
This is wrong code:
```rust
#![feature(const_generics)]
#![allow(incomplete_features)]
fn main() {
let x = 2;
fn foo<const Y: u32>() -> u32 {
x + Y
}
let _ = foo();
}
```
I think it gives a wrong suggestion because closure generics aren't allowed yet:
```
error[E0434]: can't capture dynamic environment in a fn item
--> ...\test.rs:6:9
|
6 | x + Y
| ^
|
= help: use the `|| { ... }` closure form instead
error: aborting due to previous error
```
Using: `rustc 1.45.0-nightly (5239f5c57 2020-05-26)`
|
C-enhancement,A-diagnostics,T-compiler
|
low
|
Critical
|
625,532,349 |
pytorch
|
Failure when loading quantized pre-trained weights partially
|
Hi,
I have the weights of a model that was pre-trained with Quantization-Aware Training. What I want to do is to load them in another model that contains an additional layer with respect to the pre-trained one. Usually I would call `load_state_dict()` with `strict=False` as argument and it would try to load only the parameters that are present in the given checkpoint (leaving the other ones as default), but in the case of a quantized pre-trained model this doesn't work because the two lines below try to pull the zero_point and scale factors from the given checkpoint even when `strict=False` and the given checkpoint doesn't contain the weights for all layers of the new model.
https://github.com/pytorch/pytorch/blob/9b95f757afd34857ffd83d55060328f5f35a7daf/torch/nn/quantized/modules/functional_modules.py#L126-L127
I think that the `_load_from_state_dict()` function in the `QFunctional` class should try to pop those two values only if the `strict` argument is `True` and the given `state_dict` contains those parameters
cc @jerryzh168 @jianyuh @raghuramank100 @jamesr66a @vkuzo @jgong5 @Xia-Weiwen @leslie-fang-intel @dzhulgakov
|
oncall: quantization,low priority,triaged
|
low
|
Critical
|
625,543,088 |
TypeScript
|
Narrow typeof x === 'object' to Record<string | number | symbol, unknown> | null | unknown[]
|
## Search Terms
typeof object narrow record
## Suggestion
When narrowing a variable with `typeof x === 'object'`, narrow to `Record<string | number | symbol, unknown> | null | unknown[]` instead of `object | null`.
## Use Cases
When testing to see if something is an object, you almost always are starting out with `unknown` or similarly near-top level type and trying to narrow down to a lower "useful" type. When you use the `typeof x === 'object'` narrowing operation, currently TypeScript *over* narrows to the extremely constrained `{} | null` type. This suggestion would change that behavior to narrow down to the much wider `Record<string | number | symbol, unknown> | null | unknown[]`, which the user can then choose to narrow more if they like, or they can choose to work with it as-is.
## Examples
```ts
declare const apple: unknown
if (typeof apple !== 'object') throw new Error() // actual: object | null; desired: Record<string|number|symbol, unknown> | null | unknown[]
// uncomment this line and comment out the lines above to see desired behavior
// declare const apple: Record<string|number|symbol, unknown> | null | unknown[]
if (apple === null) throw new Error() // actual: object; desired: Record<string|number|symbol, unknown> | unknown[]
if (Array.isArray(apple)) throw new Error() // actual: object; desired: Record<string|number|symbol, unknown>
for (const key in apple) {
// Element implicitly has an 'any' type because expression of type 'string' can't be used to index type '{}'.
// No index signature with a parameter of type 'string' was found on type '{}'.
apple[key] // actual: error; desired: unknown
}
```
## Checklist
My suggestion meets these guidelines:
* [x] This wouldn't be a breaking change in existing TypeScript/JavaScript code
* [x] This wouldn't change the runtime behavior of existing JavaScript code
* [x] This could be implemented without emitting different JS based on the types of the expressions
* [x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
* [x] This feature would agree with the rest of [TypeScript's Design Goals](https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals).
|
Suggestion,Awaiting More Feedback
|
medium
|
Critical
|
625,555,049 |
flutter
|
image_picker has noticable shutter delay in capturing Image from camera
|
I am working on image_picker 0.6.6+4
While using Image source as camera and capturing the image using stock camera, there is a noticable shutter delay of about 2-3 sec. There is no delay using the Stock camera directly.
Device used - Redmi K20 Pro
OS version - MIUI 12 Android 10
Tried it on other devices as well.
```[√] Flutter (Channel stable, v1.17.1, on Microsoft Windows [Version 10.0.18363.836], locale en-IN)
• Flutter version 1.17.1 at C:\Flutter\flutter
• Framework revision f7a6a7906b (2 weeks ago), 2020-05-12 18:39:00 -0700
• Engine revision 6bc433c6b6
• Dart version 2.8.2
[√] Android toolchain - develop for Android devices (Android SDK version 29.0.3)
• Android SDK at C:\Users\Prasad\AppData\Local\Android\sdk
• Platform android-29, build-tools 29.0.3
• Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
• Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b04)
• All Android licenses accepted.
[√] Android Studio (version 3.6)
• Android Studio at C:\Program Files\Android\Android Studio
• Flutter plugin version 45.1.1
• Dart plugin version 192.8052
• Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b04)
[√] Connected device (2 available)
• Redmi Note 7 Pro • bd96c4d3 • android-arm64 • Android 10 (API 29)
• Redmi K20 Pro • 192.168.1.110:5555 • android-arm64 • Android 10 (API 29)
• No issues found!
```
|
e: device-specific,platform-android,p: image_picker,package,has reproducible steps,P2,found in release: 3.10,found in release: 3.11,team-android,triaged-android
|
low
|
Major
|
625,573,856 |
pytorch
|
Some @slowtests are never run in CI
|
https://github.com/pytorch/pytorch/issues/39060, for example, which is broken.
See output of of our one slow test build (master only) here: https://circleci.com/api/v1.1/project/github/pytorch/pytorch/5584582/output/106/0?file=true&allocation-id=5ece29ff9a720f435538c71f-0-build%2F1426355C.
cc @ezyang @gchanan @zou3519 @bdhirsh @heitorschueroff @mruberry @VitalyFedyunin
|
high priority,module: tests,triaged,quansight-nack
|
low
|
Critical
|
625,592,964 |
TypeScript
|
Suggestion: treat readonly static members of class as namespace members
|
<!-- 🚨 STOP 🚨 𝗦𝗧𝗢𝗣 🚨 𝑺𝑻𝑶𝑷 🚨
Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker.
Please help us by doing the following steps before logging an issue:
* Search: https://github.com/Microsoft/TypeScript/search?type=Issues
* Read the FAQ, especially the "Common Feature Requests" section: https://github.com/Microsoft/TypeScript/wiki/FAQ
-->
## Search Terms
<!-- List of keywords you searched for before creating this issue. Write them down here so that others can find this suggestion more easily -->
static member; namespace; type
Maybe related issues: https://github.com/microsoft/TypeScript/issues/38207
## Suggestion
Readonly static members of class should act like namespace members. Especially, when that member is assigned as an alias of enumeration or other class.
## Use Cases
With the suggestion,
```ts
enum Color { red, }
class Image {
public static readonly Color = Color; // Marked as readonly, so tsc can ensure it's an alias
}
```
The `Image.Color` should be an alias of enumeration `Color`. So we can use it when an enumeration may be used:
```ts
console.log(Image.Color.red); // OK
function f(color: Image.Color) { // OK: used as type #1
if (color === Image.Color.red){ /* ... */ }
}
```
`#1` is invalid for now because tsc does not treat `Image.Color` as a type.
To use `Image.Color` as a type, we may supply a verbose declaration according to the declaration merging rule of TypeScript:
```ts
namespace Image {
export type Color = (typeof Color)[keyof typeof Color]; // :(
}
```
It's verbose...
<!--
What do you want to use this for?
What shortcomings exist with current approaches?
-->
## Examples
Sometimes we want to embed enumerations, classes into other classes. Because we don't want directly expose that enumueration/class into module scope.
## Checklist
My suggestion meets these guidelines:
* [x] This wouldn't be a breaking change in existing TypeScript/JavaScript code
* [x] This wouldn't change the runtime behavior of existing JavaScript code
* [x] This could be implemented without emitting different JS based on the types of the expressions
* [x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
* [x] This feature would agree with the rest of [TypeScript's Design Goals](https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals).
|
Suggestion,Awaiting More Feedback
|
low
|
Critical
|
625,598,445 |
flutter
|
Obfuscation : Support excluding certain classes and types from obfuscation
|
There are many times where me might have used `toString` method on `enums` and many places where we might wanna keep the Type information after obfuscation.
There is a need to support excluding certain Types or classes from obfuscation.
When we build the apk through :
```flutter build apk --obfuscate --split-debug-info```
|
c: new feature,tool,dependency: dart,c: proposal,a: build,P3,team-tool,triaged-tool
|
low
|
Critical
|
625,628,145 |
go
|
proposal: crypto/tls: RFC 7685 support (ClientHello "padding(21)")
|
Unfortunately, there are TLS servers that refuse (and hang upon) ClientHello messages of sizes in the range 256-512 bytes, causing TLS handshake timeouts. RFC 7685 lets clients mitigate this by adding padding bytes to the ClientHello messages, so clients can adjust the ClientHello sizes at will as a workaround.
https://tools.ietf.org/html/rfc7685#section-1 reads:
> Successive TLS [RFC5246] versions have added support for more cipher
suites and, over time, more TLS extensions have been defined. This
has caused the size of the TLS ClientHello to grow, and the
additional size has caused some implementation bugs to come to light.
At least one of these implementation bugs can be ameliorated by
making the ClientHello even larger. This is desirable given that
fully comprehensive patching of affected implementations is difficult
to achieve.
This memo describes a TLS extension that can be used to pad a
ClientHello to a desired size in order to avoid implementation bugs
caused by certain ClientHello sizes.
And here's a description of a buggy server implementation:
https://mailarchive.ietf.org/arch/msg/tls/8wXwhM1d5WSmROHFSgrTyFmWN2o/
Adding support for this extension would let users workaround these buggy server implementations.
|
Proposal,NeedsInvestigation,Proposal-Crypto
|
low
|
Critical
|
625,653,842 |
opencv
|
GPU implementation of SGBM
|
##### System information (version)
<!-- Example
- OpenCV => 4.2
- Operating System / Platform => Windows 64 Bit
- Compiler => Visual Studio 2017
-->
- OpenCV => :grey_question:
- Operating System / Platform => :grey_question:
- Compiler => :grey_question:
##### Detailed description
<!-- your description -->
##### Steps to reproduce
<!-- to add code example fence it with triple backticks and optional file extension
```.cpp
// C++ code example
```
or attach as .txt or .zip file
-->
##### Issue submission checklist
- [ ] I report the issue, it's not a question
<!--
OpenCV team works with answers.opencv.org, Stack Overflow and other communities
to discuss problems. Tickets with question without real issue statement will be
closed.
-->
- [ ] I checked the problem with documentation, FAQ, open issues,
answers.opencv.org, Stack Overflow, etc and have not found solution
<!--
Places to check:
* OpenCV documentation: https://docs.opencv.org
* FAQ page: https://github.com/opencv/opencv/wiki/FAQ
* OpenCV forum: https://answers.opencv.org
* OpenCV issue tracker: https://github.com/opencv/opencv/issues?q=is%3Aissue
* Stack Overflow branch: https://stackoverflow.com/questions/tagged/opencv
-->
- [ ] I updated to latest OpenCV version and the issue is still there
<!--
master branch for OpenCV 4.x and 3.4 branch for OpenCV 3.x releases.
OpenCV team supports only latest release for each branch.
The ticket is closed, if the problem is not reproduced with modern version.
-->
- [ ] There is reproducer code and related data files: videos, images, onnx, etc
<!--
The best reproducer -- test case for OpenCV that we can add to the library.
Recommendations for media files and binary files:
* Try to reproduce the issue with images and videos in opencv_extra repository
to reduce attachment size
* Use PNG for images, if you report some CV related bug, but not image reader
issue
* Attach the image as archite to the ticket, if you report some reader issue.
Image hosting services compress images and it breaks the repro code.
* Provide ONNX file for some public model or ONNX file with with random weights,
if you report ONNX parsing or handling issue. Architecture details diagram
from netron tool can be very useful too. See https://lutzroeder.github.io/netron/
-->
I wanted to know if there is any specific reason behind not implementing a gpu accelerated version of sgbm.
Thank you in advance
|
category: calib3d,category: features2d,category: gpu/cuda (contrib)
|
low
|
Critical
|
625,654,985 |
kubernetes
|
Priority-based preemption can easily violate PDBs even when unnecessary due to multiple issues with the implementation
|
<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks!
If the matter is security related, please disclose it privately via https://kubernetes.io/security/
-->
**What happened**:
A scale-up of a deployment with pods that were configured with a high priority resulted in the scheduler violating the PodDisruptionBudget of another workload, even though there were multiple other candidates for preemption whose PDBs still allowed for disruption.
**What you expected to happen**:
According to the [Pod Priority and Preemption](https://kubernetes.io/docs/concepts/configuration/pod-priority-preemption/#poddisruptionbudget-is-supported-but-not-guaranteed) documentation, the scheduler respects PDBs when evicting other pods and only violates them as a last resort.
**How to reproduce it (as minimally and precisely as possible)**:
It's a bit hard to reproduce, because the root cause seems to be a race condition between the scheduler and the PDB controller in controller-manager. The original incident happened in a cluster that had lots of pods and PDBs, and reproducing it in smaller clusters might take more time. It's easier to emulate a hiccup in the PDB controller by temporarily disabling it. Here's how I reproduce it:
1. Provision 3 nodes that will not have any other workloads. Autoscaling should also be disabled.
2. Deploy 2 victim deployments, corresponding PDBs and a deployment with 0 replicas that will trigger the eviction. You can use [this YAML](https://gist.github.com/aermakov-zalando/0d88251dd4b38c272a5db87ec8d0f449), but don't forget to update the node selector and resource requirements. You want to ensure that each of the 3 nodes will run one pod from `victim-a`, one pod from `victim-b` and that the evictor pod would not fit without kicking one of the existing pods out.
3. Wait until the pods are fully started and ready, and the PDBs are marked as allowing 1 disruption.
4. The bug requires the PDB controller to be slower than the scheduler, which is hard to reproduce, but you can certainly try. Scaling up the `evictor` deployment to 2 replicas should, according to the documentation, force an eviction of one pod from `victim-a` and one pod from `victim-b`, and this is what happens in practice most of the time. It might still be possible to reproduce with enough iterations (scale up to 2, check what was evicted, scale down to 0 if the bug is not triggered, try again).
5. To reproduce it more reliably, it's easier to emulate the hiccup. After both victim deployments are ready and the PDBs are updated, restart the controller-manager with `--controllers=*,-disruption`.
6. Scale up the `evictor` deployment to 2 pods again. There's a very high chance that you'll see that the scheduler has evicted two pods of one of the victim deployments while not touching the other. If this doesn't happen, scale down to 0 and try again.
**Anything else we need to know?**:
The root cause of the issue seems to be in how the scheduler implements eviction. The implementation unfortunately has multiple issues, resulting in the scheduler easily violating PDBs. That's not the case for normal eviction, which is implemented correctly.
Here's how normal pod eviction works:
1. A user tries to create an `Eviction` for a given pod.
2. The eviction API handler [checks](https://github.com/kubernetes/kubernetes/blob/v1.17.5/pkg/registry/core/pod/storage/eviction.go#L133) if the pod was already terminated.
3. It then [checks](https://github.com/kubernetes/kubernetes/blob/v1.17.5/pkg/registry/core/pod/storage/eviction.go#L144) if there are multiple PDBs matching the same pod since this is not a supported configuration.
4. It then runs [`checkAndDecrement`](https://github.com/kubernetes/kubernetes/blob/v1.17.5/pkg/registry/core/pod/storage/eviction.go#L207) in a loop:
1. It updates the PDB to ensure that it operates on the latest state.
2. It [fails](https://github.com/kubernetes/kubernetes/blob/v1.17.5/pkg/registry/core/pod/storage/eviction.go#L208) if the PDB hasn't been updated by the controller.
3. It [fails](https://github.com/kubernetes/kubernetes/blob/v1.17.5/pkg/registry/core/pod/storage/eviction.go#L217) if the PDB doesn't allow for further disruptions. Note that this checks for pods that the PDB controller hasn't processed yet, see the next item.
4. It records the name of the disrupted pod in the PDB's status and tries to update the PDB. If the update fails because someone else updated the PDB already, it then retries everything again, otherwise the eviction is considered successful, and the handler proceeds with deleting the pod. **This is the most important part**, because it ensures that even if the PDB controller is down, slow to react or otherwise unavailable, the disruption will be recorded in the PDB resource and further disruptions will be forbidden.
The scheduler implements this completely differently, though:
1. A pod can't fit on any of the existing nodes, so the scheduler calls [`preempt`](https://github.com/kubernetes/kubernetes/blob/v1.17.5/pkg/scheduler/scheduler.go#L627) to try and free up some space (my IDE also shows that errors from it are ignored, but this is not relevant for the current issue).
2. `preempt` calls `Algorithm.Preempt()` which returns the node where preemption should happen and the list of pods that should be preempted. This performs a bunch of checks and then [fetches](https://github.com/kubernetes/kubernetes/blob/v1.17.5/pkg/scheduler/core/generic_scheduler.go#L349) all PDBs from the cluster, expecting them to reflect the up-to-date state.
3. It then [builds](https://github.com/kubernetes/kubernetes/blob/v1.17.5/pkg/scheduler/core/generic_scheduler.go#L1002) a list of candidate nodes, recording the number of PDB violations that eviction will cause on each. This is done by virtually evicting pods in order of priority first, and then trying to [reprieve](https://github.com/kubernetes/kubernetes/blob/v1.17.5/pkg/scheduler/core/generic_scheduler.go#L1160) pods whose eviction would violate the PDB. **Here's the first problem, however**: the scheduler doesn't consider its own evictions and only checks if the PDBs it fetched previously allow for at least one disruption. This means that if we have a PDB that currently allows one disruption, and the scheduler needs to evict two pods matched by this PDB, it'll consider that evicting both is a non-violating operation even though it's definitely not the case. **Second problem**: it also pays no attention to the PDB violations that haven't been applied yet by the PDB controller (those recorded in `pdb.status.disruptedPods`).
4. After a candidate node is selected, the scheduler then proceeds with the eviction by simply [deleting the pod](https://github.com/kubernetes/kubernetes/blob/v1.17.5/pkg/scheduler/scheduler.go#L477), instead of using the eviction API.
5. It then proceeds to the next unscheduled pod and runs the same algorithm again. **Third problem**: the whole logic described above assumes that after the pod was deleted in the previous step, the disruption controller has already reacted and updated the PDB status with the new number of allowed violations. This is not how distributed systems should be designed, because the disruption controller can be temporarily down, experience a hiccup (due to a GC pause or networking issues) or just be overloaded, preventing it from updating the PDB in time.
**Environment**:
- Kubernetes version (use `kubectl version`):
Client Version: version.Info{Major:"1", Minor:"17", GitVersion:"v1.17.5", GitCommit:"e0fccafd69541e3750d460ba0f9743b90336f24f", GitTreeState:"clean", BuildDate:"2020-04-16T11:44:03Z", GoVersion:"go1.13.9", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"17", GitVersion:"v1.17.4", GitCommit:"8d8aa39598534325ad77120c120a22b3a990b5ea", GitTreeState:"clean", BuildDate:"2020-03-12T20:55:23Z", GoVersion:"go1.13.8", Compiler:"gc", Platform:"linux/amd64"}
- Cloud provider or hardware configuration: AWS
- OS (e.g: `cat /etc/os-release`): `Ubuntu 18.04.4 LTS`
- Kernel (e.g. `uname -a`): `Linux …4.15.0-1063-aws #67-Ubuntu SMP Mon Mar 2 07:24:29 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux`
- Install tools: custom, [kubernetes-on-aws](https://github.com/zalando-incubator/kubernetes-on-aws)
|
kind/bug,sig/scheduling,lifecycle/frozen
|
medium
|
Critical
|
625,691,153 |
rust
|
Creating a macro of generating closure, description of arguments to closure in || with a star only works as an exclamation point.
|
It was expected that I could repeat the syntax of the closure in the macro, I repeated but the rule is not working out correctly.
**Code:**
```rust
macro_rules! test {
[ | $($args:ident),* | $($block:tt)* ] => {
| $($args),* | $($block)*
};
}
fn main() {
let enc = &test! {
|a| {
println!("1");
}
} as &'static dyn FnMut(usize);
let enc2 = &test! {
|| {
println!("2");
}
} as &'static dyn FnMut();
}
```
**Output:**
```rust
error: no rules expected the token `||`
--> src/main.rs:16:9
|
2 | macro_rules! test {
| ----------------- when calling this macro
...
16 | || {
| ^^ no rules expected this token in macro call
```
Macro code using one or more elements works, but macro code without elements does not work. Although this is precisely the rule with the star.
**Play:** https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=bd27f49b9feeb021af76615321013784
**Rust Version:** stable 1.43.1 or rustc 1.45.0-nightly (a74d1862d 2020-05-14)
|
A-grammar,A-parser,A-macros,T-lang,T-compiler,C-feature-request
|
low
|
Critical
|
625,701,113 |
pytorch
|
Add cpack support to CMakeLists.txt
|
## 🚀 Feature
Add cpack support for creating prepackaged builds of libtorch
## Motivation
Due to https://github.com/pytorch/pytorch/issues/14573 I need to compile libtorch from source and link against system protobuf. libtorch is installed as part of a CI pipeline and rather than build it from source each time, I would like to be able to point to a prebuilt `.deb` package to install.
## Pitch
Add [the few lines](https://gitlab.kitware.com/cmake/community/-/wikis/doc/cpack/Packaging-With-CPack) it would it take to support cpack
cc @malfet @yf225 @glaringlee
|
module: build,module: cpp,triaged
|
low
|
Minor
|
625,717,903 |
godot
|
trouble reproducing colors of the imported albedo texture correctly
|
**Godot version:**
3.2.1
**OS/device including version:**
Windows 10 64bit
**Issue description:**
Hello,
I'm having trouble reproducing the colors of the imported texture correctly.
Godot is probably acting illogical in this case.
The file is PNG, 8 bits.
My problem on pictures:
http://beetbeet.eu/images/godot/colors/texture-colors-problem.jpg
Oryginal texture file:
http://beetbeet.eu/images/godot/colors/texture.png
<img src="https://user-images.githubusercontent.com/8281454/83030063-5c15ca00-a06e-11ea-8e74-a71083a7cf8b.png" width="300" />
**Steps to reproduce:**
STEP 1: After starting the scene, the texture on the 3d object has lighter colors than it should have.
The colors are faded.
On the left side you can see in browser what texture has original colors.
STEP 2: With the scene still running, if I click Albedo Tex Force Srgb, then the colors in the running game window are correct.
This would seem to mean that I should have this option enabled on this material.
STEP 3: So I give a stop playing and with this option checked Albedo Tex Force Srgb I restart the game.
Unfortunately now the texture colors look completely different than in the two previous cases.
Now the colors are too dark.
What am I doing wrong that I cannot achieve the original colors of this texture permanently?
|
topic:import
|
low
|
Major
|
625,743,605 |
node
|
doc: <integer> is misleading
|
# 📗 API Reference Docs Problem
<!------------------------------------------------------------------------------
Thank you for wanting to make nodejs.org better!
This template is for issues with the Node.js API reference docs.
For more general support, please open an issue in
our help repo at “https://github.com/nodejs/help”.
For the issue title, enter a one-line summary after “doc: ”.
The “✍️” signifies a request for input. If unsure, do the best you can.
If you found a problem with nodejs.org beyond the API reference docs, please
open an issue in our website repo at “https://github.com/nodejs/nodejs.org”.
------------------------------------------------------------------------------->
<!--
Version: output of “node -v”
Platform: output of “uname -a” (UNIX), or version and 32 or 64-bit (Windows)
Subsystem: if known, please specify affected core module name
-->
- **Version**: master
## Location
Affected URL(s):
- https://nodejs.org/api/buffer
- https://nodejs.org/api/events
...among others
## Problem description
<!-- If applicable, include any screenshots that may help solve the problem. -->
Many methods are documented to take `<integer>` or `<integer[]>`. Examples:
[Buffer.from(array)](https://nodejs.org/api/buffer.html#buffer_class_method_buffer_from_array)
[emitter.setMaxListeners(n)](https://nodejs.org/api/events.html#events_emitter_setmaxlisteners_n)
It seems to always mean "an integer Number". However, clicking the type link leads to an [MDN section](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Data_structures#Number_type) that starts with "ECMAScript has two built-in numeric types: Number and BigInt (see below).". One might erroneously think that BigInt, which is also an "integer", works too.
---
<!-- Use “[x]” to check the box below if interested in contributing. -->
- [ ] I would like to work on this issue and submit a pull request.
|
doc,meta
|
low
|
Major
|
625,758,460 |
node
|
Use stream._construct
|
Since we have landed[ `construct`](https://github.com/nodejs/node/pull/29656) in streams we should try and update relevant parts of core where it makes sense to use this feature:
- [x] `fs` (was fixed as part of the `construct` PR)
- [ ] `net`
- [ ] `http`
- [ ] `http2`
- [ ] ...
|
stream,meta
|
low
|
Major
|
625,789,618 |
TypeScript
|
Type of reverse mappings of numeric enums is a `string` instead of `keyof typeof Enum`
|
<!-- 🚨 STOP 🚨 𝗦𝗧𝗢𝗣 🚨 𝑺𝑻𝑶𝑷 🚨
Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Even if you think you've found a *bug*, please read the FAQ first, especially the Common "Bugs" That Aren't Bugs section!
Please help us by doing the following steps before logging an issue:
* Search: https://github.com/Microsoft/TypeScript/search?type=Issues
* Read the FAQ: https://github.com/Microsoft/TypeScript/wiki/FAQ
Please fill in the *entire* template below.
-->
<!--
Please try to reproduce the issue with the latest published version. It may have already been fixed.
For npm: `typescript@next`
This is also the 'Nightly' version in the playground: http://www.typescriptlang.org/play/?ts=Nightly
-->
**TypeScript Version:** 4.0.0-dev.20200526
<!-- Search terms you tried before logging this (so others can find this issue more easily) -->
**Search Terms:**
enum
numeric enum
reverse enum
**Code**
```ts
enum Enum {
one = 1,
two = 2,
}
const a: keyof typeof Enum = Enum[Enum.one]; // (1)
const b = Enum[0]; // (2)
console.log(a, b);
```
**Expected behavior:**
When a numeric enum is indexed by itself the value should be of type `keyof typeof Enum`:
No error on line (1).
Error `Property '0' does not exist on type 'typeof Enum'` on line (2).
**Actual behavior:**
When a numeric enum is indexed by a number (including itself) the value is of type `string`:
Error `Type 'string' is not assignable to type '"one" | "two"'` on line (1).
No error on line (2).
**Playground Link:** [Provided](https://www.typescriptlang.org/play?ts=4.0.0-dev.20200526&ssl=7&ssc=19&pln=7&pc=1#code/KYOwrgtgBAou0G8CwAoKUD2JhQLxQEYAaVdAFwHcM8oAmElAX1VQGMsBnMqAQwC4oAa2ABPDADMoZEQAdgE2PBpxIAbRUQAdFmABdANxtO3AEbL4qgAwGjIDhgA2wTQ4wBzABQ8iUEwEpDFCA)
**Related Issues:** <!-- Did you find other bugs that looked similar? -->
|
Suggestion,Awaiting More Feedback
|
medium
|
Critical
|
625,807,191 |
flutter
|
Remove iOS version name normalization to 3 parts
|
## Use case
We specify app version and build numbers in `pubspec.yaml`. Some app releases we want to have a two part version number, like 2.7, for other app releases we want a three part version number, like 2.7.3.
In `pubspec.yaml` we write `version: 2.7+25` in the first case and `version: 2.7.3+25` in the second case.
For both Android and iOS we want the app version number to match the number we have in `pubspec.yaml`.
## Observed Behaviour
When Flutter generates the files for Android, the version number from `pubspec.yaml` is used verbatim, when it generates for iOS it is "normalized" to three parts. That is, 2.7 becomes 2.7.0.
The offending code is here:
https://github.com/flutter/flutter/blob/415401102ca165c2c727288e542eabd049ad4b62/packages/flutter_tools/lib/src/build_info.dart#L332-L334
## Proposal
Remove the iOS special case that normalizes to three parts.
## Solution
It is not, and never have been, a requirement to have three part version numbers on iOS. We have released apps on the Apple App Store for the past 10 years and used two part version numbers since the beginning.
The above referenced piece of code in `build_info.dart` references som Apple documentation that describes version numbers as three part. The author that created the offending piece of code must have read the documentation much to literally and mistaken it for official Apple policy.
The piece of code was introduced in merge request #27743.
|
c: new feature,platform-ios,tool,c: proposal,P3,team-ios,triaged-ios
|
low
|
Minor
|
625,825,519 |
java-design-patterns
|
Service Mesh pattern
|
**Description:**
The Service Mesh design pattern is a dedicated infrastructure layer for managing service-to-service communication within a microservices architecture. It aims to address the complexities associated with the growing number of services by providing observability, security, and reliability without altering application code. The main elements of the pattern include:
1. **Service Discovery:** Automatically detects and tracks the availability and health of services.
2. **Load Balancing:** Distributes incoming service requests across multiple instances of a service to ensure reliability and performance.
3. **Traffic Management:** Controls the flow of traffic between services, including routing, retries, failovers, and circuit breaking.
4. **Security:** Provides service-to-service authentication, authorization, and encryption.
5. **Observability:** Offers insights into service behavior, including metrics, logging, and tracing.
**References:**
1. [Service Mesh for Microservices](https://medium.com/microservices-in-practice/service-mesh-for-microservices-2953109a3c9a)
2. [Service Mesh Architecture](https://256.nurkiewicz.com/2)
3. [The Rise of Service Mesh Architecture](https://dzone.com/articles/the-rise-of-service-mesh-architecture)
4. [Pattern: Service Mesh](https://philcalcado.com/2017/08/03/pattern_service_mesh.html)
**Acceptance Criteria:**
1. Implement a basic Service Mesh framework that includes service discovery, load balancing, and traffic management.
2. Integrate security features for service-to-service communication, ensuring authentication and encryption.
3. Provide observability tools, including metrics collection, logging, and distributed tracing for monitoring service interactions.
|
info: help wanted,epic: pattern,type: feature
|
low
|
Major
|
625,827,686 |
rust
|
UX improvements around const usage and error lints
|
This code produces errors and warnings that I consider suboptimal:
```rust
#[warn(const_err)]
const TEST: bool = [true][1];
const TEST_2: bool = TEST;
fn main() {}
```
(Playground link: https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=20e9f735947348f61b83d9331c36f538 )
The errors and warnings are:
```
Compiling playground v0.0.1 (/playground)
warning: constant item is never used: `TEST`
--> src/main.rs:2:1
|
2 | const TEST: bool = [true][1];
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: `#[warn(dead_code)]` on by default
warning: constant item is never used: `TEST_2`
--> src/main.rs:3:1
|
3 | const TEST_2: bool = TEST;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^
warning: any use of this value will cause an error
--> src/main.rs:2:20
|
2 | const TEST: bool = [true][1];
| -------------------^^^^^^^^^-
| |
| index out of bounds: the len is 1 but the index is 1
|
note: the lint level is defined here
--> src/main.rs:1:8
|
1 | #[warn(const_err)]
| ^^^^^^^^^
error: any use of this value will cause an error
--> src/main.rs:3:22
|
3 | const TEST_2: bool = TEST;
| ---------------------^^^^-
| |
| referenced constant has errors
|
= note: `#[deny(const_err)]` on by default
error: aborting due to previous error
error: could not compile `playground`.
To learn more, run the command again with --verbose.
```
What could be better about this error message?
* By setting the `const_err` lint to `warn`, it shows error message "warning: any use of this value will cause an error". Indeed, it errors when `TEST` is used in the definition of `TEST_2`. However, it *also* warns that `TEST` isn't used; so it has a conflicting definition of what counts as "use".
* Extra verbosity not being great, we could get rid of the "not used" warning here and resolve the conflict of definitions in one go.
* The error message "any use of this value will cause an error" gets repeated. I think the word choice "any" fits well to the warning at definition site, but on the usage site better would be: "error: use of ill-defined/erroneous/something? constant" Maybe also the secondary span could be shortened not to include the item definition; as for me, it muddles the distinction of definition and usage even more. (Might be just here, though, as the usage and definition site are quite similar in this example?)
* The message "note: `#[deny(const_err)]` on by default" is confusing: yes, the default setting for `const_err` is `deny`, but it isn't actually `deny` here. Is the default setting what you wanted to tell about? How is it relevant, especially as it would be better conveyed in the earlier "note: the lint level is defined here" warning?
* Edit: I understood a bit more about the "note: `#[deny(const_err)]` on by default" message. `#[deny(const_err)]` is a per-item attribute, so it notes that it's on by default... *on this item*. The message could be better.
### Meta
Reproduces on Rust version: 1.43.1 && latest nightly 2020-05-26.
|
A-lints,A-diagnostics,T-compiler,C-bug,A-const-eval
|
low
|
Critical
|
625,893,611 |
go
|
x/build/cmd/coordinator: active gomote sessions and coordinator deploys are mutually exclusive
|
There are times when people need to investigate issues that require configuration or environment that is hard to reproduce locally, and they use [gomote](https://golang.org/wiki/Gomote) instances for such debugging sessions.
A limitation of the current implementation of this system is that all remote buildlets are lost when `cmd/coordinator` restarts. This limitation is documented in [doc/remote-buildlet.txt](https://github.com/golang/build/blob/9e7a7627a6196130b73c47362c3987069212b6d3/doc/remote-buildlet.txt#L5):
> Currently, if the coordinator dies or restarts, all buildlets are lost.
An unfortunate consequence is that this can reduce the window of time when `cmd/coordinator` can be re-deployed without disrupting investigative done by others.
This can generally be worked around by coordinating with people who are using gomotes to find a good time for a deploy, but it scales poorly when there are more concurrent investigations being done, especially during business hours.
This is the tracking issue to track how much of a problem it is and investigate ways to improve this situation if it ends up becoming a bottleneck.
/cc @cagedmantis @toothrot @andybons
|
Builders,NeedsInvestigation
|
low
|
Critical
|
625,909,211 |
godot
|
Collision detection issues - multiple collision shapes, CCD
|
<!-- Please search existing issues for potential duplicates before filing yours:
https://github.com/godotengine/godot/issues?q=is%3Aissue
-->
**Godot version:**
v3.2.2, custom build 73b97e8f0
**OS/device including version:**
Linux Mint 19.3
**Issue description:**
There are several issues already discussing the problems of continuous collision detection, more specifically the fact that it seemingly does not work at all (see #16113 for instance). I made some more tests as this issue affects my project, and noticed some unexpected behavior.
First of all, it is expected that small, fast objects may tunnel through thin obstacles or other small objects if they travel more distance between two physics frames than the size of both objects. This is where continuous collision detection is supposed to prevent such behavior. However, while testing I noticed the following:
- with continuous collision detection *disabled*, a rigid body with a single BoxShape never tunnels through a thin obstacle (see MRP below), even at speeds of 500 m/s at 60 physics FPS.
- on the other hand, a compound rigid body (in this case two BoxShapes) can tunnel through the same obstacle, irrespective of whether continuous collision detection is enabled.
I have not tested other shapes, but it appears that having more than one collision shape in a rigid body causes it to ignore continuous collision detection, while single collision shape rigid bodies seem to always have CCD enabled.
**Steps to reproduce:**
- Add a StaticBody with a thin BoxShape collision shape
- Add a RigidBody with a small BoxShape collision shape
- Throw/drop the rigid body into the static body at various velocities and CCD settings
- Perform the same test after adding a second collision shape to the RigidBody
**Minimal reproduction project:**
[CollisionDetectionIssue.zip](https://github.com/godotengine/godot/files/4690797/CollisionDetectionIssue.zip)
In this test project, there are two small rigid bodies that get thrown into a thin wall when you press the space bar. One of them has a single collision shape while the other has two. You can change the speed of both rigid bodies through the root node's exported variable.
At 60 physics FPS, tunnelling starts occurring for the second rigid body at an initial speed of 61 m/s.
The first rigid body will never tunnel, even at 500 m/s.
|
bug,topic:physics,topic:3d
|
low
|
Minor
|
625,924,196 |
youtube-dl
|
adding support for audiovault.net
|
<!--
######################################################################
WARNING!
IGNORING THE FOLLOWING TEMPLATE WILL RESULT IN ISSUE CLOSED AS INCOMPLETE
######################################################################
-->
## Checklist
<!--
Carefully read and work through this check list in order to prevent the most common mistakes and misuse of youtube-dl:
- First of, make sure you are using the latest version of youtube-dl. Run `youtube-dl --version` and ensure your version is 2020.05.08. If it's not, see https://yt-dl.org/update on how to update. Issues with outdated version will be REJECTED.
- Make sure that all provided video/audio/playlist URLs (if any) are alive and playable in a browser.
- Make sure that site you are requesting is not dedicated to copyright infringement, see https://yt-dl.org/copyright-infringement. youtube-dl does not support such sites. In order for site support request to be accepted all provided example URLs should not violate any copyrights.
- Search the bugtracker for similar site support requests: http://yt-dl.org/search-issues. DO NOT post duplicates.
- Finally, put x into all relevant boxes (like this [x])
-->
- [ x] I'm reporting a new site support request
- [x] I've verified that I'm running youtube-dl version **2020.05.08**
- [x] I've checked that all provided URLs are alive and playable in a browser
- [x] I've checked that none of provided URLs violate any copyrights
- [x] I've searched the bugtracker for similar site support requests including closed ones
## Example URLs
<!--
Provide all kinds of example URLs support for which should be included. Replace following example URLs by yours.
-->
- Single movie: http://audiovault.net/downnload/10963
## Description
<!--
Provide any additional information.
If work on your issue requires account credentials please provide them or explain how one can obtain them.
-->
this website is a donation based website which describes movies for blind and visually impaired people.
it requires account creation, which can be created on the website. other users can upload audio described videos (they require granting access).
all the files are in audio-only format like mp3 or ogg
thanks
|
site-support-request
|
low
|
Critical
|
625,969,631 |
pytorch
|
[TensorPipe] Avoid wrapping the future message in order to do atomic test-and-set
|
See #38931. The TensorPipe RPC agent has two threads operate on future messages: the I/O thread(s) and the timeout thread. They each have a copy of the future and the first one to operate on the future should go ahead, while the second one should just do nothing. However, making as complete a future that is already complete is an error. To allow for these two threads to synchronize we thus wrap the future message and attach an atomic_flag to it. This shouldn't be necessary: we should either fix the future's API to allow for something like markCompleteIfNeeded, or store a single copy of the future in the TP agent and have the two threads synchronize their access to it.
cc @osalpekar @jiayisuse @lw @beauby @pritamdamania87 @mrshenli @jjlilley @gqchen @rohan-varma
|
triaged,module: tensorpipe
|
low
|
Critical
|
625,971,720 |
flutter
|
video_player - Support device rotation and full screen
|
Do we have any option to enable the auto rotation when turning the device.
|
c: new feature,p: video_player,package,c: proposal,team-ecosystem,P3,triaged-ecosystem
|
low
|
Minor
|
625,981,577 |
flutter
|
Multiple global object keys
|
`GlobalKeys`, of course, are not to be abused. But sometimes they are necessary and I am finding problems with the restriction that only a single `GlobalObjectKey` must exist.
As a real example, you cannot use any widgets with a global key inside of a `ScrollablePositionedList` (see issue here: https://github.com/google/flutter.widgets/issues/137)
More generally, if you have any animation or list that must display the same widgets at the same time in different positions in the screen, then you can't have a `GlobalKey` anywhere because it will be a duplicate.
This problem would be solved with a key called `MultipleGlobalObjectKey` which would allow for repeating the key, and then instead of having a `currentState` getter it would have a `currentStates` getter, that would return a list of states instead of a single one. (then `currentState` could throw an error if there is more than one available state).
I believe what I am asking here is not a breaking change (but maybe I'm wrong?).
In other words, this would allow us to search the tree for all widgets (more than one) with some specific global key.
I tried to create this key class myself, but the `mount` method does this:
```
if (key is GlobalKey) {
key._register(this);
}
```
So `MultipleGlobalObjectKey` would need to override the `_register` method and I can't do it outside of `framework.dart`.
|
c: new feature,framework,c: proposal,P3,team-framework,triaged-framework
|
low
|
Critical
|
625,984,900 |
go
|
x/crypto/acme/autocert: Error http: TLS handshake error from <ip>:<port>: Head "": unsupported protocol scheme "" trying to connect to letsencrypt's pebble
|
<!--
Please answer these questions before submitting your issue. Thanks!
For questions please use one of our forums: https://github.com/golang/go/wiki/Questions
-->
### What version of Go are you using (`go version`)?
<pre>
$ go version
go version go1.10.8 linux/amd64
</pre>
### Does this issue reproduce with the latest release?
Yes. It happens with: go version go1.14.3 linux/amd64
### What operating system and processor architecture are you using (`go env`)?
<details><summary><code>go env</code> Output</summary><br><pre>
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/tofs/.cache/go-build"
GOENV="/home/tofs/.config/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/home/tofs/Private/production/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build170790492=/tmp/go-build -gno-record-gcc-switches"
</pre></details>
### What did you do?
* pebble is a lightweight implementation of an ACME server, for e2e testing purposes. It's available here: https://github.com/letsencrypt/pebble
* this is running inside a docker container with wget pre-installed
I added "example.org" to /etc/hosts pointing to the docker container's ip address.
I moved pebble test certificate to /etc/ssl/certs/ca-certificates.crt
I started pebble with:
PEBBLE_VA_ALWAYS_VALID=1 ./pebble -strict
I started a https server in the same container running this code:
```go
import (
"crypto/rsa"
"golang.org/x/crypto/acme"
"golang.org/x/crypto/acme/autocert"
"log"
"math/rand"
"net/http"
"time"
)
func main() {
key, err := rsa.GenerateKey(rand.New(rand.NewSource(time.Now().UnixNano())), 2048)
client := &acme.Client{DirectoryURL: "https://localhost:14000/dir", Key: key}
m := &autocert.Manager{
Cache: autocert.DirCache("secret-dir"),
Prompt: autocert.AcceptTOS,
HostPolicy: autocert.HostWhitelist("example.org", "www.example.org"),
Client: client,
}
if err != nil {
log.Fatal(err)
}
s := &http.Server{
Addr: ":https",
TLSConfig: m.TLSConfig(),
}
s.ListenAndServeTLS("", "")
}
```
I issued a call using wget to https://example.org
### What did you expect to see?
A 404 - page not found error
### What did you see instead?
* wget output:
--2020-05-27 21:30:28-- https://example.org/
Resolving example.org (example.org)... 172.17.0.4
Connecting to example.org (example.org)|172.17.0.4|:443... connected.
GnuTLS: A TLS fatal alert has been received.
GnuTLS: received alert [80]: Internal error
Unable to establish SSL connection.
* https server log (stderr):
2020/05/27 21:30:28 http: TLS handshake error from 172.17.0.4:53518: Head "": unsupported protocol scheme ""
* pebble output:
Pebble 2020/05/27 21:30:28 GET /dir -> calling handler()
Pebble 2020/05/27 21:30:28 HEAD /dir -> calling handler()
|
NeedsInvestigation
|
low
|
Critical
|
625,997,074 |
godot
|
RichTextLabel scrolling on android requires both "emulate touch from mouse" and "emulate mouse from touch" project settings
|
<!-- Please search existing issues for potential duplicates before filing yours:
https://github.com/godotengine/godot/issues?q=is%3Aissue
-->
**Godot version:**
3.2.1-stable
**OS/device including version:**
Android 9 / Samsung Galaxy S8
**Issue description:**
I have a simple scene with nothing but single RichTextLabel (scroll active=true, enough text for vertical scroll bar to appear).
Exported to Android, drag scrolling only works if **both** "emulate touch from mouse" and "emulate mouse from touch" project settings are enabled. The obvious workaround is to just enable both settings but that causes unwanted input events that have to be ignored in my custom controls (might cause some problems elsewhere too). I assume this is not intended behavior?
**Steps to reproduce:**
See description.
**Minimal reproduction project:**
[ScrollTest.zip](https://github.com/godotengine/godot/files/4691433/ScrollTest.zip)
|
bug,platform:android,confirmed,topic:input
|
low
|
Minor
|
626,014,525 |
flutter
|
unable to override browser default key bindings
|
In [DevTools](hub.com/flutter/devtools), we're adding keybindings to accelerate common operations. Where possible, we're trying to use keybindings that users would know from similar operations in other tools.
One keybinding we'd like to add is `ctrl-P` / `⌘P`, which for Chrome DevTools opens the list of application scripts. We're able to successfully bind to this keybinding via the `Shortcuts` / `LogicalKeySets` classes and do see our version of the scripts view opening. However, on a mac, ⌘P is the browser keybinding for print, so the browser's print dialog also opens.
Normally in a web app you'd do something like call `event.preventDefault()` to indicate that your app handled an event. It would be great if the Flutter framework / flutter web engine would notice that the key event was handled by the app, and prevented the browser default action from occurring.
From talking to @mdebbar, this use case may be covered by the 'Handling Synchronous Keyboard Events' design doc (https://docs.google.com/document/d/1rWXSjkb2ZKv-cpg26lVK0aZi4cVeXJ8j7YmSJdq2TOM/edit).
@mdebbar @gspencergoog
|
framework,engine,platform-web,customer: web10,customer: ddt,P2,team-web,triaged-web
|
low
|
Minor
|
626,027,341 |
youtube-dl
|
Adding site support to HKani.me
|
<!--
######################################################################
WARNING!
IGNORING THE FOLLOWING TEMPLATE WILL RESULT IN ISSUE CLOSED AS INCOMPLETE
######################################################################
-->
## Checklist
<!--
Carefully read and work through this check list in order to prevent the most common mistakes and misuse of youtube-dl:
- First of, make sure you are using the latest version of youtube-dl. Run `youtube-dl --version` and ensure your version is 2020.05.08. If it's not, see https://yt-dl.org/update on how to update. Issues with outdated version will be REJECTED.
- Make sure that all provided video/audio/playlist URLs (if any) are alive and playable in a browser.
- Make sure that site you are requesting is not dedicated to copyright infringement, see https://yt-dl.org/copyright-infringement. youtube-dl does not support such sites. In order for site support request to be accepted all provided example URLs should not violate any copyrights.
- Search the bugtracker for similar site support requests: http://yt-dl.org/search-issues. DO NOT post duplicates.
- Finally, put x into all relevant boxes (like this [x])
-->
- [X] I'm reporting a new site support request
- [X] I've verified that I'm running youtube-dl version **2020.05.08**
- [X] I've checked that all provided URLs are alive and playable in a browser
- [ ] I've checked that none of provided URLs violate any copyrights
- [X] I've searched the bugtracker for similar site support requests including closed ones
## Example URLs
<!--
Provide all kinds of example URLs support for which should be included. Replace following example URLs by yours.
-->
- Single video: https://www.hkanime.com/player/gg/embed/ipGaYglJBKlm8xH/
- Single video: https://www.hkanime.com/video/148/1/1/vod.html
## Description
<!--
Provide any additional information.
If work on your issue requires account credentials please provide them or explain how one can obtain them.
-->
Tried adding my own cookies and adding specific user-agent and referer but the request still turn around with either Error 403 Forbidden or site not supported.
|
site-support-request
|
low
|
Critical
|
626,056,035 |
pytorch
|
Build issue when installing pytorch with USE_FFMPEG=1 USE_OPENCV=1
|
## 🐛 Bug
I'm trying to build pytorch with video operators enabled in caffe2, steps taken from [VMZ repository](https://github.com/facebookresearch/VMZ/blob/master/tutorials/Installation_guide.md#ubuntu).
Any help or insights would be appreciated.
However, whenever I don't use the below env variables, the build works fine.
## To Reproduce
USE_OPENCV=1 USE_FFMPEG=1 USE_LMDB=1 python setup.py install
Steps to reproduce the behavior:
1. docker pull pytorch/pytorch:1.5-cuda10.1-cudnn7-devel
2. git clone --recursive https://github.com/pytorch/pytorch.git
3. cd pytorch; USE_OPENCV=1 USE_FFMPEG=1 USE_LMDB=1 python setup.py install
<!-- If you have a code sample, error messages, stack traces, please provide it here as well -->
```
[1728/4811] Building CXX object c10/CMakeFiles/c10.dir/util/numa.cpp.o
[1729/4811] Building CXX object c10/CMakeFiles/c10.dir/core/UndefinedTensorImpl.cpp.o
[1730/4811] Building CXX object c10/test/CMakeFiles/c10_tempfile_test.dir/util/tempfile_test.cpp.o
[1731/4811] Building CXX object c10/test/CMakeFiles/c10_flags_test.dir/util/flags_test.cpp.o
[1732/4811] Building CXX object c10/test/CMakeFiles/c10_Array_test.dir/util/Array_test.cpp.o
[1733/4811] Building C object caffe2/CMakeFiles/torch_global_deps.dir/__/torch/csrc/empty.c.o
[1734/4811] Linking C shared library lib/libtorch_global_deps.so
FAILED: lib/libtorch_global_deps.so
: && /usr/bin/cc -fPIC -fopenmp -DNDEBUG -O3 -DNDEBUG -DNDEBUG -Wl,--no-as-needed -rdynamic -shared -Wl,-soname,libtorch_global_deps.so -o lib/libtorch_global_deps.so caffe2/CMakeFiles/torch_global_deps.dir/__/torch/csrc/empty.c.o -L/usr/local/cuda/lib64 -Wl,-rpath,/usr/local/cuda/lib64:/usr/lib/x86_64-linux-gnu/openmpi/lib:::::::: /usr/lib/x86_64-linux-gnu/openmpi/lib/libmpi_cxx.so /usr/lib/x86_64-linux-gnu/openmpi/lib/libmpi.so /usr/local/cuda/lib64/libcurand.so /usr/lib/x86_64-linux-gnu/libcudnn.so /usr/local/cuda/lib64/libcufft.so /usr/lib/x86_64-linux-gnu/libcublas.so -lCUDA_cublas_device_LIBRARY-NOTFOUND /usr/local/cuda/lib64/libcudart.so /usr/local/cuda/lib64/libnvToolsExt.so && :
/usr/bin/ld: cannot find -lCUDA_cublas_device_LIBRARY-NOTFOUND
collect2: error: ld returned 1 exit status
```
## Expected behavior
<!-- A clear and concise description of what you expected to happen. -->
## Environment
Please copy and paste the output from our
[environment collection script](https://raw.githubusercontent.com/pytorch/pytorch/master/torch/utils/collect_env.py)
(or fill out the checklist below manually).
You can get the script and run it with:
```
wget https://raw.githubusercontent.com/pytorch/pytorch/master/torch/utils/collect_env.py
# For security purposes, please check the contents of collect_env.py before running it.
python collect_env.py
```
- PyTorch Version (e.g., 1.0):N/A
- OS (e.g., Linux): 18.04.4 LTS
- How you installed PyTorch (`conda`, `pip`, source): source
- Build command you used (if compiling from source): USE_OPENCV=1 USE_LMDB=1 USE_FFMPEG=1 python setup.py install
- Python version: 3.7
- CUDA/cuDNN version:
CUDA runtime version: 10.1.243
cuDNN version: /usr/lib/x86_64-linux-gnu/libcudnn.so.7.6.5
- GPU models and configuration: GPU 0: Tesla V100-SXM2-32GB
- Any other relevant information:
## Additional context
cc @malfet
|
module: build,triaged
|
low
|
Critical
|
626,059,986 |
rust
|
Decide on stability of `Display` output for libstd/libcore/etc. types
|
Per the discussion in #62794, it's not clear whether the output of `Display` impls for types in the standard library should be considered stable or unstable, and if unstable, which impls might be stable.
Views expressed:
- `Display` impls are unstable ([in this comment](https://github.com/rust-lang/rust/issues/62794#issuecomment-518374531) by @Mark-Simulacrum)
- I thought they were stable except for some exceptions ([in this comment](https://github.com/rust-lang/rust/issues/62794#issuecomment-524981491) by @xfix )
- I'm not certain that the libs team has expressed a view on this ([in this later comment](https://github.com/rust-lang/rust/issues/62794#issuecomment-525028204) by @Mark-Simulacrum)
Seems worth deciding on and documenting.
|
T-libs-api,C-discussion
|
low
|
Major
|
626,129,505 |
kubernetes
|
Allow setting an environment variable to some fraction or multiple of a resource field
|
**What would you like to be added**:
It would be nice to pass a process a number that is a bit lower than the container memory limit so that its garbage collection or memory management can use that limit.
For example:
- setting `GOMEMLIMIT` or setting `NODEMEMLIMIT`
- setting `NODE_OPTS=--max-old-space-size=$(NODEMEMLIMIT)` would be useful.
- setting `JAVA_MEM_LIMIT` and passing `-Xmx$(JAVA_MEM_LIMIT)M`
Currently you can use `envFrom.resourceFieldRef` to "copy" a resource request or limit to an environment variable, but you can only multiply the value by some power of 1000 or 1024 by specifying `divisor`.
**Why is this needed**:
This would make it possible to pass a memory limit into a process inside the container that is based on the container resource request or limit but less.
For example, when specifying node's `--max-old-space-size` or Java's `-Xmx` parameter, setting it equal to the memory limit of the container will be a problem, because the process actually uses more memory than what you provided as a parameter.
**Potential Solutions**
- If we could specify a `divisor` like `1.5Mi` then it would result in a number of megabytes equal to roughly 2 thirds of the available memory, leaving some extra for the other heaps.
- Add another field like `scale` or `multiplier` to `enfFrom.resourceFieldRef` which is multiplied by the input value to get the env var value
- Allow arithmetic in the existing env var expansion system - where currently you can only do `$(SOME_VAR)` in the command line, additionally support something like `$(SOME_VAR - 100)`
- Allow using a go template or some simple templating/expression language to actually fill out the env var with prefix and suffix, like `--max-old-space-size={{ value * 800 }}M`
**Workarounds**
- Create an admission webhook that does one of the above without changing the kubernetes core features
- If the container uses bash, you could run a command like `bash -c 'NODE_OPTIONS=---max-old-space-size=$(($MEMORY_LIMIT-500)) ...` or create your own entrypoint wrapper (maybe a shell script) that calculates the env vars before running the actual command
|
priority/backlog,sig/node,kind/feature,needs-triage
|
high
|
Critical
|
626,156,000 |
pytorch
|
The MacOS compiler is generating illegal instruction for the division of c10::complex
|
See: https://github.com/pytorch/pytorch/pull/39300
The MacOS compiler is generating illegal instruction for the division of `c10::complex` numbers. Search `AT_DISPATCH_COMPLEX_TYPES_MAC_STD` in the code to find and remove the workaround for `logspace_cpu_out` and `div_kernel`.
cc @ezyang @anjali411 @dylanbespalko
|
triaged,module: complex
|
low
|
Major
|
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.