id
int64 393k
2.82B
| repo
stringclasses 68
values | title
stringlengths 1
936
| body
stringlengths 0
256k
⌀ | labels
stringlengths 2
508
| priority
stringclasses 3
values | severity
stringclasses 3
values |
|---|---|---|---|---|---|---|
583,240,800 |
opencv
|
Add Line(Line Segment and LineRay)
|
##### Detailed description
OpenCV has a lot of places where, in my opinion, it will be better to use some data structure for Line (line segment or line ray) instead of cv::Vec4 with the description of the index meaning or using two points.
like:
- fitLine [[link](https://docs.opencv.org/2.4/modules/imgproc/doc/structural_analysis_and_shape_descriptors.html?highlight=fitline#cv.FitLine)]
> Output line parameters. In case of 2D fitting, it should be a vector of 4 elements (like Vec4f) - (vx, vy, x0, y0), where (vx, vy) is a normalized vector collinear to the line and (x0, y0) is a point on the line. In case of 3D fitting, it should be a vector of 6 elements (like Vec6f) - (vx, vy, vz, x0, y0, z0), where (vx, vy, vz) is a normalized vector collinear to the line and (x0, y0, z0) is a point on the line.
- clipLine [[link](https://docs.opencv.org/2.4/modules/core/doc/drawing_functions.html?highlight=line#cv.ClipLine)]
> pt1 – First line point.
> pt2 – Second line point.
- houghLines[[link](https://docs.opencv.org/2.4/modules/imgproc/doc/feature_detection.html?highlight=line#houghlines)]
> lines – Output vector of lines. Each line is represented by a two-element vector (\rho, \theta) . \rho is the distance from the coordinate origin (0,0) (top-left corner of the image). \theta is the line rotation angle in radians ( 0 \sim \textrm{vertical line}, \pi/2 \sim \textrm{horizontal line} ).
- houghLinesP[[link](https://docs.opencv.org/2.4/modules/imgproc/doc/feature_detection.html?highlight=line#houghlines)]
> lines – Output vector of lines. Each line is represented by a 4-element vector (x_1, y_1, x_2, y_2) , where (x_1,y_1) and (x_2, y_2) are the ending points of each detected line segment.
- drawing function cv::line[[link](https://docs.opencv.org/2.4/modules/core/doc/drawing_functions.html?highlight=line#line)]
> pt1 – First point of the line segment.
> pt2 – Second point of the line segment.
- KeyLine [[link](https://docs.opencv.org/3.4/d1/dd7/structcv_1_1line__descriptor_1_1KeyLine.html)]
##### It would be fine to add Structure similar to Point
```
template<typename _Tp> class LineSegment_
{
public:
typedef _Tp value_type;
//! default constructor
LineSegment_();
LineSegment_(Point_<_Tp> _pt1, Point_<_Tp> _pt2);
LineSegment_(const LineSegment_& pt);
LineSegment_(LineSegment_&& pt) CV_NOEXCEPT;
//! conversion from old-style C structure
LineSegment_(const Vec<_Tp, 4>& v);
LineSegment_& operator = (const LineSegment_& pt);
LineSegment_& operator = (LineSegment_&& pt) CV_NOEXCEPT;
//! conversion to another data type
template<typename _Tp2> operator LineSegment_<_Tp2>() const;
//! conversion to the old-style C structures
operator Vec<_Tp, 4>() const;
Point_<_Tp> pt1; //!< First point of the line segment
Point_<_Tp> pt2; //!< Second point of the line segment
};
typedef LineSegment_<int> LineSegment2i;
typedef LineSegment_<int64> LineSegment2l;
typedef LineSegment_<float> LineSegment2f;
typedef LineSegment_<double> LineSegment2d;
typedef LineSegment2i LineSegment;
```
```
template<typename _Tp1, typename _Tp2> class LineRay_
{
public:
LineRay_(Point_<_Tp1> _pt, Vec_<_Tp2> _dir);
...
Point_<_Tp1> pt; //!< Point on the line ray
Vec_<_Tp2> dir; //!< Direction of line ray(normalized may be)
};
```
Is it good idea to create This structure?
Which version use for start branch?
- OpenCV version => 2.4 :grey_question:
Redundacy Checked at:
* OpenCV documentation: https://docs.opencv.org ✔️ No redundacy found ✔️
* FAQ page: https://github.com/opencv/opencv/wiki/FAQ ✔️
* OpenCV forum: https://answers.opencv.org✔️
* OpenCV issue tracker: https://github.com/opencv/opencv/issues?q=is%3Aissue ✔️
* Stack Overflow branch: https://stackoverflow.com/questions/tagged/opencv ✔️
|
priority: low,RFC
|
low
|
Minor
|
583,276,732 |
rust
|
Tracking Issue for `Option::zip` and `Option::zip_with` (feature `option_zip`)
|
<!--
Thank you for creating a tracking issue! 📜 Tracking issues are for tracking a
feature from implementation to stabilisation. Make sure to include the relevant
RFC for the feature if it has one. Otherwise provide a short summary of the
feature and link any relevant PRs or issues, and remove any sections that are
not relevant to the feature.
Remember to add team labels to the tracking issue.
For a language team feature, this would e.g., be `T-lang`.
Such a feature should also be labeled with e.g., `F-my_feature`.
This label is used to associate issues (e.g., bugs and design questions) to the feature.
-->
This is a tracking issue for `#![feature(option_zip)]` which was introduced in #69997.
### About tracking issues
Tracking issues are used to record the overall progress of implementation.
They are also uses as hubs connecting to other relevant issues, e.g., bugs or open design questions.
A tracking issue is however *not* meant for large scale discussion, questions, or bug reports about a feature.
Instead, open a dedicated issue for the specific matter and add the relevant feature gate label.
### Steps
<!--
Include each step required to complete the feature. Typically this is a PR
implementing a feature, followed by a PR that stabilises the feature. However
for larger features an implementation could be broken up into multiple PRs.
-->
- [x] Stabilize `Option::zip` (https://github.com/rust-lang/rust/pull/72938)
- [ ] Resolve unresolved questions
- [ ] Stabilization PR ([see instructions on rustc-dev-guide][stabilization-guide])
[stabilization-guide]: https://rustc-dev-guide.rust-lang.org/stabilization_guide.html#stabilization-pr
[doc-guide]: https://rustc-dev-guide.rust-lang.org/stabilization_guide.html#documentation-prs
### Unresolved Questions
<!--
Include any open questions that need to be answered before the feature can be
stabilised.
-->
- [ ] Should we also include `zip_with` in the public API? Seems like a niche API and is easily replaced with `a.zip(b).map(f)`.
|
T-libs-api,B-unstable,C-tracking-issue,A-result-option,Libs-Tracked,Libs-Small
|
medium
|
Critical
|
583,277,884 |
youtube-dl
|
Support for Celebsroulette.com
|
<!--
######################################################################
WARNING!
IGNORING THE FOLLOWING TEMPLATE WILL RESULT IN ISSUE CLOSED AS INCOMPLETE
######################################################################
-->
## Checklist
<!--
Carefully read and work through this check list in order to prevent the most common mistakes and misuse of youtube-dl:
- First of, make sure you are using the latest version of youtube-dl. Run `youtube-dl --version` and ensure your version is 2020.03.08. If it's not, see https://yt-dl.org/update on how to update. Issues with outdated version will be REJECTED.
- Make sure that all provided video/audio/playlist URLs (if any) are alive and playable in a browser.
- Make sure that site you are requesting is not dedicated to copyright infringement, see https://yt-dl.org/copyright-infringement. youtube-dl does not support such sites. In order for site support request to be accepted all provided example URLs should not violate any copyrights.
- Search the bugtracker for similar site support requests: http://yt-dl.org/search-issues. DO NOT post duplicates.
- Finally, put x into all relevant boxes (like this [x])
-->
- [x] I'm reporting a new site support request
- [x] I've verified that I'm running youtube-dl version **2020.03.08**
- [x] I've checked that all provided URLs are alive and playable in a browser
- [x] I've checked that none of provided URLs violate any copyrights
- [x] I've searched the bugtracker for similar site support requests including closed ones
## Example URLs
<!--
Provide all kinds of example URLs support for which should be included. Replace following example URLs by yours.
-->
- Single video: https://celebsroulette.com/videos/3032/zooey-deschanel-new-girl-s1ep8/
- Playlist: https://celebsroulette.com/playlists/684/beautiful-butts/
|
site-support-request
|
low
|
Critical
|
583,281,934 |
youtube-dl
|
Support for heroero.com
|
<!--
######################################################################
WARNING!
IGNORING THE FOLLOWING TEMPLATE WILL RESULT IN ISSUE CLOSED AS INCOMPLETE
######################################################################
-->
## Checklist
<!--
Carefully read and work through this check list in order to prevent the most common mistakes and misuse of youtube-dl:
- First of, make sure you are using the latest version of youtube-dl. Run `youtube-dl --version` and ensure your version is 2020.03.08. If it's not, see https://yt-dl.org/update on how to update. Issues with outdated version will be REJECTED.
- Make sure that all provided video/audio/playlist URLs (if any) are alive and playable in a browser.
- Make sure that site you are requesting is not dedicated to copyright infringement, see https://yt-dl.org/copyright-infringement. youtube-dl does not support such sites. In order for site support request to be accepted all provided example URLs should not violate any copyrights.
- Search the bugtracker for similar site support requests: http://yt-dl.org/search-issues. DO NOT post duplicates.
- Finally, put x into all relevant boxes (like this [x])
-->
- [x] I'm reporting a new site support request
- [x] I've verified that I'm running youtube-dl version **2020.03.08**
- [x] I've checked that all provided URLs are alive and playable in a browser
- [x] I've checked that none of provided URLs violate any copyrights
- [x] I've searched the bugtracker for similar site support requests including closed ones
## Example URLs
<!--
Provide all kinds of example URLs support for which should be included. Replace following example URLs by yours.
-->
- Single video: https://heroero.com/videos/1061/sanex-naked-new-hot-video-ad-2013/
|
site-support-request
|
low
|
Critical
|
583,294,509 |
electron
|
Electron.ClientRequest should be typed as a WritableStream
|
In order to allow typescript usage of `stream.pipe(request)` (which works) the `ClientRequest` typescript definition needs to either be compatible with or `extend` Writable.
Extending probably makes the most sense if we can make that work as that's what we're actually doing in the code.
|
documentation :notebook:,component/typescript,stale-exempt
|
medium
|
Major
|
583,302,364 |
terminal
|
Console property sheet allows bitmap fonts despite the v2 console _not_ supporting them
|
The ["Hellfont Cyr"](https://plugring.farmanager.com/plugin.php?pid=164&l=en) terminal font is not rendered in v2 console. Instead of its 9x16 typeface, some random 12x16 is chosen.
(Left is ForceV2=0, right is ForceV2=1. Same font settings.)
_Originally posted by @AnrDaemon in https://github.com/microsoft/terminal/issues/295#issuecomment-600209738_
|
Product-Conhost,Issue-Bug,Area-Settings,Priority-3
|
low
|
Major
|
583,311,016 |
youtube-dl
|
www.ohrka.de
|
## Checklist
- [x] I'm reporting a new site support request
- [x] I've verified that I'm running youtube-dl version **2020.03.08**
- [x] I've checked that all provided URLs are alive and playable in a browser
- [x] I've checked that none of provided URLs violate any copyrights
- [x] I've searched the bugtracker for similar site support requests including closed ones
## Example URLs
- Single Audio: https://www.ohrka.de/hoeren/abenteuerlich-lustig/oskars-ganz-geheime-hoehle/
## Description
„Ear-channel“ connected to the German Public KiKa („Childrens Channel“) TV-Channel
|
site-support-request
|
low
|
Critical
|
583,314,921 |
godot
|
GridMap Mesh Library "Clear" doesn't actually clear the grid-map
|
**Godot version**: 3.0, 3.1, 3.2
**OS/device including version**: Windows 10 Pro 64-bit
**Issue description**:
- GridMap inspector has a section for choosing Mesh Library
- In this section, you can "Clear" currently assigned Mesh Library, which removes the Mesh Library and (apparently) deletes all tiles
- But this is not true, because even if you restart Godot, and then attach the same Mesh Library, all your tiles will be there at the scene again
- Clear implies complete removal of data, so this is not how it is meant to work. That is, by clicking "Clear", it should remove all history as well so you can effectively clean your map.
**Steps to reproduce:**
1) Add a Spatial, add a GridMap as its child
2) Assign your Mesh Library to the GridMap
3) Dump a couple of tiles, save, now use "Clear", see your tiles disappearing, save
4) Restart Godot, open your scene, re-add the Mesh Library and find your old tiles to be at the scene again
|
discussion,topic:editor,confirmed,topic:3d
|
low
|
Minor
|
583,329,004 |
PowerToys
|
[FancyZones] Exclude app by window title / exe
|
# Summary of the new feature/enhancement
The feature of "Move newly created windows to their last known zone" has a flaw - it resizes dialog boxes that can (but under normal circumstances shouldn't) be resized, such as the file dialog or Find and Replace.
While I like Excel windows to open in their prior place, I don't want the Find/Replace or the file dialogs box to span a huge space.
The proposal is to allow exclusion by window title (maybe also by dialog type for standard dialog boxes like the file dialog).
To do that (by title), the user would add the window title (e.g. "Find and Replace") to exclude windows with that title from being resized automatically.
<!--
A clear and concise description of what the problem is that the new feature would solve.
Describe why and how a user would use this new functionality (if applicable).
-->
# Proposed technical implementation details (optional)
<!--
A clear and concise description of what you want to happen.
-->
|
Idea-Enhancement,FancyZones-Dragging&UI,Product-FancyZones
|
low
|
Major
|
583,383,034 |
flutter
|
[pigeon] be explicit about allowed Dart keywords in the IDL
|
We should be very clear in the https://pub.dev/packages/pigeon readme on what types of Dart statements are allowed in the IDL files so that users don't gradually find out via trial and error repeat pub runs.
cc @gaaclarke
|
d: api docs,package,team-ecosystem,p: pigeon,P3,triaged-ecosystem
|
low
|
Critical
|
583,400,441 |
flutter
|
Flutter Web doesn't throw MissingPluginException when plugin is not registered
|
## Steps to Reproduce
1. Write an app with a button that calls `launch()` from `package:url_launcher` when clicked
2. Tap on the button to trigger launch().
3. Tap on it again.
**Expected results:**
A `MissingPluginException` that is [thrown in platform_channel.dart](https://github.com/flutter/flutter/blob/master/packages/flutter/lib/src/services/platform_channel.dart#L154) should be triggered twice.
**Actual results:**
It wasn't triggered on the first click, and only triggered on the second click. Making it difficult to know that a plugin is missing in this case. And the app code might be stuck waiting for a response from a plugin.
**Analysis:**
When a platform message was called, and if a handler was not registered for the channel, we [put the request in a channel buffer](https://github.com/flutter/flutter/blob/master/packages/flutter_web_plugins/lib/src/plugin_registry.dart#L84). The buffer has a size of 1, so the second click actually pushed the first message out and triggered the `MissingPluginException`.
From the discussion in #40165 which added the channel buffer, looks like it was added because the native side on mobile didn't have a way to know when the Dart side has finished initialization. (#38914)
For web since everything happens on the Dart side, it's a lot easier to make sure that registration happen before actual calling the platform channel, do we still need the channel buffer in this case?
cc @hterkelsen @yjbanov @ferhatb
|
engine,platform-web,P2,team-web,triaged-web
|
low
|
Minor
|
583,408,672 |
go
|
path/filepath: TestEvalSymlinksAboveRoot failures on macOS
|
[2020-03-17T20:48:23-0eeec4f/darwin-amd64-race](https://build.golang.org/log/0a56dc157638f581e1b2dba862e41dee69e7ce00)
```
--- FAIL: TestEvalSymlinksAboveRoot (0.01s)
path_test.go:1449: EvalSymlinks("/private/var/folders/kh/5zzynz152r94t18yzstnrwx80000gn/T/workdir-host-darwin-10_15/tmp/TestEvalSymlinksAboveRoot800207813/../../../../../../../../../private/var/folders/kh/5zzynz152r94t18yzstnrwx80000gn/T/workdir-host-darwin-10_15/tmp/TestEvalSymlinksAboveRoot800207813/b/file") = "/private/var/folders/kh/5zzynz152r94t18yzstnrwx80000gn/T/workdir-host-darwin-10_15/tmp/TestEvalSymlinksAboveRoot800207813/a/file"
path_test.go:1449: EvalSymlinks("/private/var/folders/kh/5zzynz152r94t18yzstnrwx80000gn/T/workdir-host-darwin-10_15/tmp/TestEvalSymlinksAboveRoot800207813/../../../../../../../../../../private/var/folders/kh/5zzynz152r94t18yzstnrwx80000gn/T/workdir-host-darwin-10_15/tmp/TestEvalSymlinksAboveRoot800207813/b/file") = "/private/var/folders/kh/5zzynz152r94t18yzstnrwx80000gn/T/workdir-host-darwin-10_15/tmp/TestEvalSymlinksAboveRoot800207813/a/file"
path_test.go:1445: EvalSymlinks("/private/var/folders/kh/5zzynz152r94t18yzstnrwx80000gn/T/workdir-host-darwin-10_15/tmp/TestEvalSymlinksAboveRoot800207813/../../../../../../../../../../../private/var/folders/kh/5zzynz152r94t18yzstnrwx80000gn/T/workdir-host-darwin-10_15/tmp/TestEvalSymlinksAboveRoot800207813/b/file") failed: lstat /private/../../../private/var: no such file or directory
FAIL
FAIL path/filepath 0.252s
```
See previously #35201.
|
OS-Darwin,NeedsInvestigation
|
low
|
Critical
|
583,413,166 |
pytorch
|
[JIT]torch.jit.export invaild for pytorch1.4
|
@torch.jit.export
it works in pytorch1.3, the same code in pytorch1.4, it's invaild.
cc @suo
|
needs reproduction,oncall: jit,triaged
|
low
|
Minor
|
583,426,314 |
pytorch
|
Enable OpaqueTensor to possess Storage then allow it to view from CPUTensor
|
## 🚀 Feature
Allow OpaqueTensor to have storage. Implement OpaqueTensor<<ideep::tensor>> in a way that use Storage as its buffer manager.
## Motivation
MKLDNN Layout is a physical extension to stride layout (always stride logically), so it is compatible to CPUTensor when transform from it. The copy nature of to_mkldnn will hurt performance when MKLDNN ops scattered in models, while it could be a view style.
## Pitch
Improve performance when using MKLDNN
## Additional context
The parameter T of the OpaqueTensor template is the class to describe underlining memory buffer, while it does not have to manage the buffer of its own. If we limit the responsibility of T to meta description and let Storage for resource management, then an Opaque Tensor could naturally view from CPUTensor when they are compatible. Even when Opaque T described a layout that beyond the semantics of a stride Tensor we could still choose to use Storage for buffer management as long as we don’t pass it out to incompatible tensor types.
A concrete case of this is, as we could see in DNNL Tensor if we use ideep::tensor for meta management and let Storage manage the buffer, then we could make to_mkldnn a view style op instead of a memory copy. In certain cases when DNNL Tensor format is compatible with CPUTensor (nearly all the cases other than some of 4D block format) we could optimize out unnecessary copy in transforming DNNL Tensor from or to CPUTensor.
cc @gujinghui @PenghuiCheng @XiaobingSuper @jianyuh
|
module: internals,triaged,module: mkldnn
|
medium
|
Major
|
583,433,517 |
go
|
proposal: x/crypto/ssh: export a method Disconnect in Conn interface
|
<!--
Please answer these questions before submitting your issue. Thanks!
For questions please use one of our forums: https://github.com/golang/go/wiki/Questions
-->
### What version of Go are you using (`go version`)?
<pre>
$ go version
go version go1.14 linux/amd64
</pre>
### Does this issue reproduce with the latest release?
Yes
### What operating system and processor architecture are you using (`go env`)?
<details><summary><code>go env</code> Output</summary><br><pre>
$ go env
GO111MODULE="on"
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/wutz/.cache/go-build"
GOENV="/home/wutz/.config/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GONOPROXY="git.paratera.net"
GONOSUMDB="git.paratera.net"
GOOS="linux"
GOPATH="/home/wutz/.go/path"
GOPRIVATE="git.paratera.net"
GOPROXY="https://goproxy.cn,direct"
GOROOT="/home/wutz/.go/root"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/home/wutz/.go/root/pkg/tool/linux_amd64"
GCCGO="gccgo"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="/home/wutz/go/ssh/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build427084596=/tmp/go-build -gno-record-gcc-switches"
</pre></details>
### Proposal: Feature Request
https://github.com/golang/crypto/blob/1b76d66859c6111b3d5c3ea6600ea44dc188bf12/ssh/connection.go#L72-L75
Want to export a method `Disconnect`
|
Proposal,Proposal-Crypto
|
low
|
Critical
|
583,439,654 |
create-react-app
|
Hot reloading breaks when encountering Typescript error
|
<!--
Please note that your issue will be fixed much faster if you spend about
half an hour preparing it, including the exact reproduction steps and a demo.
If you're in a hurry or don't feel confident, it's fine to report bugs with
less details, but this makes it less likely they'll get fixed soon.
In either case, please use this template and fill in as many fields below as you can.
Note that we don't provide help for webpack questions after ejecting.
You can find webpack docs at https://webpack.js.org/.
-->
### Describe the bug
I am having exactly same issue as metioned in https://github.com/facebook/create-react-app/issues/8055
Since that issue is now closed, I will just re-describe the issue again here.
Hot reloading seems to stop working when a Typescript compilation error is encountered.
Any subsequent code changes would not trigger hot reloading after that, even if I fix the lines that would cause compile errror.
I need to actually close and restart the dev server in order to see my changes reflected.
### Which terms did you search for in User Guide?
Typescript, Hot reloading
### Environment
<!--
To help identify if a problem is specific to a platform, browser, or module version, information about your environment is required.
This enables the maintainers quickly reproduce the issue and give feedback.
Run the following command in your React app's folder in terminal.
Note: The result is copied to your clipboard directly.
`npx create-react-app --info`
Paste the output of the command in the section below.
-->
```
System:
OS: Linux 4.19 Ubuntu 18.04.2 LTS (Bionic Beaver)
CPU: (12) x64 AMD Ryzen 5 3600 6-Core Processor
Binaries:
Node: 13.7.0 - /usr/bin/node
Yarn: 1.21.1 - /mnt/c/Program Files (x86)/Yarn/bin/yarn
npm: 6.14.2 - /usr/bin/npm
Browsers:
Chrome: Not Found
Firefox: Not Found
npmPackages:
react: ^16.13.0 => 16.13.0
react-dom: ^16.13.0 => 16.13.0
react-scripts: 3.4.0 => 3.4.0
npmGlobalPackages:
create-react-app: 3.4.0
```
### Steps to reproduce
<!--
How would you describe your issue to someone who doesn’t know you or your project?
Try to write a sequence of steps that anybody can repeat to see the issue.
-->
1. `create-react-app react-app --template typescript`
2. `cd react-app`
3. `yarn start`
4. Write invalid typescript code in `src/App.tsx` and save it to trigger compilation error
5. See TS compiler error message in terminal
6. Fix the code in `src/App.tsx` and save it
7. Note that hot reloading is now *NOT* triggered
6. Killing dev server and running `yarn start` again to see changes get reflected
### Expected behavior
Re-compile and hot reload on every save, just like when using `create-react-app` without the `--template typescript` flag
|
issue: needs investigation,issue: bug report
|
high
|
Critical
|
583,443,274 |
pytorch
|
Issues with DataParallel on Multiple GPUs
|
I am getting the following error when trying to use Multiple GPUs with DataParallel. Please note the implementation works perfectly fine on a single GPU.
Here is the traceback:
```
Traceback (most recent call last):
File "train.py", line 247, in <module>
train_loss = train_xe(model, dataloader_train, optim, text_field)
File "train.py", line 77, in train_xe
out = model(detections, captions)
File "/opt/conda/envs/m2release/lib/python3.6/site-packages/torch/nn/modules/module.py", line 547, in __call__
result = self.forward(*input, **kwargs)
File "/opt/conda/envs/m2release/lib/python3.6/site-packages/torch/nn/parallel/data_parallel.py", line 151, in forward
replicas = self.replicate(self.module, self.device_ids[:len(inputs)])
File "/opt/conda/envs/m2release/lib/python3.6/site-packages/torch/nn/parallel/data_parallel.py", line 156, in replicate
return replicate(module, device_ids, not torch.is_grad_enabled())
File "/opt/conda/envs/m2release/lib/python3.6/site-packages/torch/nn/parallel/replicate.py", line 111, in replicate
buffer_copies_not_rg = _broadcast_coalesced_reshape(buffers_not_rg, devices, detach=True)
File "/opt/conda/envs/m2release/lib/python3.6/site-packages/torch/nn/parallel/replicate.py", line 75, in _broadcast_coalesced_reshape
return comm.broadcast_coalesced(tensors, devices)
File "/opt/conda/envs/m2release/lib/python3.6/site-packages/torch/cuda/comm.py", line 39, in broadcast_coalesced
return torch._C._broadcast_coalesced(tensors, devices, buffer_size)
RuntimeError: tensors.size() == order.size() INTERNAL ASSERT FAILED at /pytorch/torch/csrc/utils/tensor_flatten.cpp:66, please report a bug to PyTorch. (reorder_tensors_like at /pytorch/torch/csrc/utils/tensor_flatten.cpp:66)
frame #0: c10::Error::Error(c10::SourceLocation, std::string const&) + 0x33 (0x7f71080e7273 in /opt/conda/envs/m2release/lib/python3.6/site-packages/torch/lib/libc10.so)
frame #1: torch::utils::reorder_tensors_like(std::vector<at::Tensor, std::allocator<at::Tensor> >&, c10::ArrayRef<at::Tensor>) + 0x139f (0x7f710c34c9cf in /opt/conda/envs/m2release/lib/python3.6/site-packages/torch/lib/libtorch.so)
frame #2: torch::cuda::broadcast_coalesced(c10::ArrayRef<at::Tensor>, c10::ArrayRef<long>, unsigned long) + 0x1d96 (0x7f710c834d76 in /opt/conda/envs/m2release/lib/python3.6/site-packages/torch/lib/libtorch.so)
frame #3: <unknown function> + 0x5f422c (0x7f71528fd22c in /opt/conda/envs/m2release/lib/python3.6/site-packages/torch/lib/libtorch_python.so)
frame #4: <unknown function> + 0x1d3ef4 (0x7f71524dcef4 in /opt/conda/envs/m2release/lib/python3.6/site-packages/torch/lib/libtorch_python.so)
<omitting python frames>
frame #48: __libc_start_main + 0xf0 (0x7f7160f72830 in /lib/x86_64-linux-gnu/libc.so.6)
```
Thanks :)
|
triaged,module: data parallel
|
low
|
Critical
|
583,449,719 |
node
|
benchmark: http simple connect timeout on macOS
|
<!--
Thank you for reporting an issue.
This issue tracker is for bugs and issues found within Node.js core.
If you require more general support please file an issue on our help
repo. https://github.com/nodejs/help
Please fill in as much of the template below as you're able.
Version: output of `node -v`
Platform: output of `uname -a` (UNIX), or version and 32 or 64-bit (Windows)
Subsystem: if known, please specify affected core module name
-->
* **Version**: v13.11.0
* **Platform**: macOS Catalina
* **Subsystem**: benchmark
### What steps will reproduce the bug?
<!--
Enter details about your bug, preferably a simple code snippet that can be
run using `node` directly without installing third-party dependencies.
-->
```js
node benchmark/http/simple.js
```
### How often does it reproduce? Is there a required condition?
Always reproduces.
### What is the expected behavior?
<!--
If possible please provide textual output instead of screenshots.
-->
It should run without timeout error on macOS.
### What do you see instead?
<!--
If possible please provide textual output instead of screenshots.
-->
<img width="1121" alt="Screen Shot 2020-03-18 at 11 58 44 AM" src="https://user-images.githubusercontent.com/3114495/76924042-1d49f200-6910-11ea-8cb3-66dab5f4d8a6.png">
### Additional information
<!--
Tell us anything else you think we should know.
-->
I found that it works when I change `duration` from 5 to 10. It could be some problem with frequently port binding.
```js
const bench = common.createBenchmark(main, {
// Unicode confuses ab on os x.
type: ['bytes', 'buffer'],
len: [4, 1024, 102400],
chunks: [1, 4],
c: [50, 500],
chunkedEnc: [1, 0],
duration: 5 // replace with 10, it works
});
```
|
benchmark
|
low
|
Critical
|
583,450,266 |
terminal
|
[v0.10] When two characters are ligatured, the first one becomes invisible
|
## Environment
```none
Platform ServicePack Version VersionString
-------- ----------- ------- -------------
Win32NT 10.0.19582.0 Microsoft Windows NT 10.0.19582.0
```
## Steps to reproduce
1. Change font to the one with ligatures, for example *Fira Code*.
2. Type `--`.
## Expected behavior
The first `-` shouldn't disappear.
## Actual behavior
The first `-` is disappeared.
|
Help Wanted,Area-Rendering,Area-Fonts,Issue-Bug,Product-Terminal,Priority-3
|
medium
|
Critical
|
583,458,293 |
kubernetes
|
Documentation of workqueue abstraction is too scattered
|
<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks!
If the matter is security related, please disclose it privately via https://kubernetes.io/security/
-->
**What happened**:
Colleagues had questions about workqueue and I realized that the answers are painfully scattered throughout the code.
1. The introduction to the workqueue abstraction is in doc.go. While this is not necessarily wrong, I will point out that my colleague did not find it. The comment on the golang type `Type` --- which is one implementation of the interface `Interface` --- in `queue.go` points to `doc.go`. The declaration of `RateLimitingInterface` does _not_ direct the reader to `doc.go`.
2. The need to call `Done` is not explained in any of the interface types. It is stated on one method implementation. I think that Done needs to be called for all the interfaces, and so should be documented in the root interface.
**What you expected to happen**:
**How to reproduce it (as minimally and precisely as possible)**:
**Anything else we need to know?**:
**Environment**:
- Kubernetes version (use `kubectl version`):
- Cloud provider or hardware configuration:
- OS (e.g: `cat /etc/os-release`):
- Kernel (e.g. `uname -a`):
- Install tools:
- Network plugin and version (if this is a network-related bug):
- Others:
|
kind/documentation,sig/api-machinery,lifecycle/frozen
|
low
|
Critical
|
583,480,830 |
vscode
|
Hyperlinks don't open on Arch Linux running KDE Plasma 5
|
Hello,
I found an existing issue https://github.com/Microsoft/vscode/issues/50139 but it is marked as closed, hence creating a new issue.
- VSCode Version:
```
1.43.0
78a4c91400152c0f27ba4d363eb56d2835f9903a
x64
```
- OS Version:
```
Operating System: Arch Linux
KDE Plasma Version: 5.18.3
KDE Frameworks Version: 5.68.0
Qt Version: 5.14.1
Kernel Version: 5.5.9-arch1-2
OS Type: 64-bit
Processors: 12 × Intel® Core™ i7-8750H CPU @ 2.20GHz
Memory: 7.6 GiB of RAM
```
Steps to Reproduce:
1. On an arch linux running KDE Plasma 5, open vscode or vscode Insider Edition (with or without extensions disabled)
2. Open any file that has a hyperlink
3. Ctrl + Click to follow the link
4. Nothing happens.
Does this issue occur when all extensions are disabled?: Yes
Does this issue occur in the Insider Edition? Yes
I expected the hyperlink to open in a browser.
Upon checking the process list, there is a processes associated with every Ctrl+Click (Because I clicked on the hyper link multiple times) and the PID changes because it crashes and the process re-spawns.
```bash
USER 59258 0.0 0.0 7840 3948 ? S 11:50 0:00 /bin/sh /usr/bin/xdg-open https://bing.com/
USER 59260 0.0 0.4 286740 39696 ? Rl 11:50 0:00 kde-open5 https://bing.com/
USER 59262 0.0 0.0 7840 3824 ? S 11:50 0:00 /bin/sh /usr/bin/xdg-open https://bing.com/
USER 59263 0.0 0.0 7840 3904 ? S 11:50 0:00 /bin/sh /usr/bin/xdg-open https://bing.com/
USER 59266 0.0 0.4 276048 38072 ? Rl 11:50 0:00 kde-open5 https://bing.com/
USER 59267 0.0 0.0 7840 3672 ? S 11:50 0:00 /bin/sh /usr/bin/xdg-open https://bing.com/
USER 59268 0.0 0.4 286740 39712 ? Rl 11:50 0:00 kde-open5 https://bing.com/
USER 59269 0.0 0.4 286744 39752 ? Rl 11:50 0:00 kde-open5 https://bing.com/
USER 59278 0.0 0.0 7840 3804 ? S 11:50 0:00 /bin/sh /usr/bin/xdg-open https://bing.com/
USER 59281 0.0 0.3 201740 30188 ? Rl 11:50 0:00 kde-open5 https://bing.com/
USER 59284 0.0 0.0 7840 3716 ? S 11:50 0:00 /bin/sh /usr/bin/xdg-open https://bing.com/
USER 59285 0.0 0.3 176616 26216 ? Sl 11:50 0:00 kde-open5 https://bing.com/
```
I managed to get the `strace` of the process if that is going to be of any help.
```bash
Process:
USER 30106 0.0 0.0 7840 3836 ? S 12:25 0:00 /bin/sh /usr/bin/xdg-open https://bing.com/
strace: Process 30106 attached
wait4(-1, [{WIFEXITED(s) && WEXITSTATUS(s) == 0}], 0, NULL) = 30108
rt_sigaction(SIGINT, {sa_handler=SIG_DFL, sa_mask=[], sa_flags=SA_RESTORER, sa_restorer=0x7f8b0ee30d70}, {sa_handler=0x559881b46ef0, sa_mask=[], sa_flags=SA_RESTORER, sa_restorer=0x7f8b0ee30d70}, 8) = 0
ioctl(2, TIOCGWINSZ, 0x7ffcb8e05300) = -1 ENOTTY (Inappropriate ioctl for device)
rt_sigprocmask(SIG_SETMASK, [], NULL, 8) = 0
--- SIGCHLD {si_signo=SIGCHLD, si_code=CLD_EXITED, si_pid=30108, si_uid=1000, si_status=0, si_utime=5, si_stime=1} ---
wait4(-1, 0x7ffcb8e04b90, WNOHANG, NULL) = -1 ECHILD (No child processes)
rt_sigreturn({mask=[]}) = 0
rt_sigprocmask(SIG_BLOCK, [CHLD], [], 8) = 0
rt_sigprocmask(SIG_SETMASK, [], NULL, 8) = 0
exit_group(0) = ?
+++ exited with 0 +++
```
Not sure if it is related and would be of any help but `journalctl` also started showing the following error after the above process keeps crashing.
```
Mar 18 13:20:46 localghost kwin_x11[1758]: qt.qpa.xcb: QXcbConnection: XCB error: 3 (BadWindow), sequence: 26572, resource id: 125829125, major code: 18 (ChangeProperty), minor code: 0
Mar 18 13:20:46 localghost kwin_x11[1758]: qt.qpa.xcb: QXcbConnection: XCB error: 3 (BadWindow), sequence: 26597, resource id: 125829125, major code: 18 (ChangeProperty), minor code: 0
Mar 18 13:20:46 localghost kwin_x11[1758]: qt.qpa.xcb: QXcbConnection: XCB error: 3 (BadWindow), sequence: 26635, resource id: 125829125, major code: 18 (ChangeProperty), minor code: 0
Mar 18 13:20:46 localghost kwin_x11[1758]: qt.qpa.xcb: QXcbConnection: XCB error: 3 (BadWindow), sequence: 26643, resource id: 125829125, major code: 18 (ChangeProperty), minor code: 0
Mar 18 13:20:46 localghost kwin_x11[1758]: qt.qpa.xcb: QXcbConnection: XCB error: 3 (BadWindow), sequence: 26651, resource id: 125829125, major code: 18 (ChangeProperty), minor code: 0
Mar 18 13:20:46 localghost kwin_x11[1758]: qt.qpa.xcb: QXcbConnection: XCB error: 3 (BadWindow), sequence: 26659, resource id: 125829125, major code: 18 (ChangeProperty), minor code: 0
```
My default association for url opening is Chrome, and opening the same url from terminal using `/bin/sh /usr/bin/xdg-open https://bing.com ` works.
Apologies if this issue doesn't belong here. I am not sure if this needs to be raised with vscode or KDE. Thank you.
|
upstream,linux,electron,workbench-os-integration,snap
|
low
|
Critical
|
583,494,344 |
neovim
|
Take HTML optional closing tags into account for indentation
|
This problem is shared between vim and neovim. It has been reported against vim as well here: https://github.com/vim/vim/issues/5806
auto-indentation of HTML doesn't seem to be aware of optional closing tags, which messes up the indentation levels when taking advantage of this aspect of the HTML language.
### Actual behavior
```html
<ol>
<li>1st list item
<li>2nd list item
</ol>
<p>1st paragraph
<p>2nd paragraph
```
### Expected behaviour
```html
<ol>
<li>1st list item
<li>2nd list item
</ol>
<p>1st paragraph
<p>paragraph
```
Based on the [WHATWG HTML spec](https://html.spec.whatwg.org/#syntax-tag-omission) and [W3C HTML spec](https://www.w3.org/TR/html53/syntax.html#optional-start-and-end-tags), this is what we ought to be doing:
* any of these elements closes a preceding `<p>` element: `<address>`, `<article>`, `<aside>`, `<blockquote>`, `<details>`, `<div>`, `<dl>`, `<fieldset>`, `<figcaption>`, `<figure>`, `<footer>`, `<form>`, `<h1>`, `<h2>`, `<h3>`, `<h4>`, `<h5>`, `<h6>`, `<header>`, `<hgroup>`, `<hr>`, `<main>`, `<menu>`, `<nav>`, `<ol>`, `<p>`, `<pre>`, `<section>`, `<table>`, or `<ul>`
* an `<li>` closes a preceding `<li>`
* a `<dt>` or `<dd>` closes a preceding `<dt>` or `<dd>`
* an `<option>` closes a preceding `<option>`
* an `<optgroup>` closes a preceding `<optgroup>`
* a `<td>` or `<th>` closes a preceding `<td>` or `<th>`
* a `<tr>` closes a preceding `<tr>`
* a `<tfoot>` or `<tbody>` closes a preceding `<thead>` or `<tbody>`
* an `<rb>`, `<rt>`, `<rp>`, or `<rtc>` closes a preceding `<rb>`, `<rt>`, `<rp>`, or `<rtc>`
* a `<colgroup>` closes a preceding `<colgroup>`
* a `<caption>` closes a preceding `<caption>`
(HTML has more to say about optional opening/closing tags, but the rest isn't relevant to indentation)
|
runtime,bug-vim,needs:vim-patch
|
low
|
Minor
|
583,506,350 |
go
|
math/big: Float.Sqrt does not set accuracy
|
<!--
Please answer these questions before submitting your issue. Thanks!
For questions please use one of our forums: https://github.com/golang/go/wiki/Questions
-->
### What version of Go are you using (`go version`)?
<pre>
$ go version go1.13.8 linux/amd64
</pre>
### Does this issue reproduce with the latest release?
Yes.
### What operating system and processor architecture are you using (`go env`)?
<details><summary><code>go env</code> Output</summary><br><pre>
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/root/.cache/go-build"
GOENV="/root/.config/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/root/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/root/app/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/root/app/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build510748991=/tmp/go-build -gno-record-gcc-switches"
</pre></details>
### What did you do?
<!--
If possible, provide a recipe for reproducing the error.
A complete runnable program is good.
A link on play.golang.org is best.
-->
I was researching ieee 754, and when using go, I found that the `big.Float.Sqrt` function always output exact results. I calculate sqrt(pi) with go and cpp on one enviroment:
**Go**
```go
package main
import (
"log"
"math/big"
)
func main() {
pi := big.NewFloat(3.14159265)
r := big.NewFloat(0).Sqrt(pi)
log.Println(r, r.Acc())
}
```
**Cpp**
```cpp
#include <iostream>
#include <cfenv>
#include <cmath>
#pragma STDC FENV_ACCESS ON
double pi = 3.14159265;
int main()
{
std::feclearexcept(FE_ALL_EXCEPT);
std::cout << "sqrt(pi) = " << sqrt(pi) << '\n';
if(std::fetestexcept(FE_INEXACT)) {
std::cout << "inexact result reported\n";
} else {
std::cout << "inexact result not reported\n";
}
}
```
### What did you expect to see?
```
golang: 1.7724538498928541 "InExact"
cpp : sqrt(pi) = 1.77245, inexact result reported
```
### What did you see instead?
```
golang: 1.7724538498928541 "Exact"
cpp : sqrt(pi) = 1.77245, inexact result reported
```
I don't think this is an accurate value, for `sqrt(pi) = 1.7724538498928541` in go
|
NeedsInvestigation
|
low
|
Critical
|
583,520,444 |
ant-design
|
Improve the accessibility
|
- [ ] I have searched the [issues](https://github.com/ant-design/ant-design/issues) of this repository and believe that this is not a duplicate.
### What problem does this feature solve?
Improve the overall accessibility of the framework according to a [this article](https://darekkay.com/blog/accessible-ui-frameworks/) AntD have poor accessibility, I doubt accessibility of things would have improved highly in 4.0
Better to focus on following things first although its better to have good color contrast
- [Focus-indicator](https://darekkay.com/blog/accessible-ui-frameworks/#Focus-indicator)
- [WAI-ARIA-compliance](https://darekkay.com/blog/accessible-ui-frameworks/#WAI-ARIA-compliance)
Currently opened issues regarding accessibility
- [ ] https://github.com/ant-design/ant-design/issues/16682
- [ ] https://github.com/ant-design/ant-design/issues/16270
- [ ] https://github.com/ant-design/ant-design/issues/12502
- [ ] https://github.com/ant-design/ant-design/issues/11600
### What does the proposed API look like?
May try a alternative library as suggested in [16607](https://github.com/ant-design/ant-design/issues/16607) or improve the current implementation.
<!-- generated by ant-design-issue-helper. DO NOT REMOVE -->
|
help wanted,Inactive,⌨️ Accessibility
|
medium
|
Major
|
583,525,112 |
fastapi
|
Include documentation for other types of security
|
Docs Link: https://fastapi.tiangolo.com/tutorial/security/
We have explained in detail about OAuth2 with password. However, there are no documentation links about other types like APIKeyHeader, HTTPHeader, etc. There is a very hidden mention https://fastapi.tiangolo.com/tutorial/security/#fastapi-utilities about the existence of other module. It took me a lot of time to find this. I feel it would be time-saving if we were to include these in the documentation itself.
Also, I feel that we should give option to add a global custom checking tool for security types, like the way `@app.middleware` does for wrapping custom logic. Currently, we can only check with tokenUrls, authenticationUrls, or defining custom functions that have to then be added as a dependency.
Something like this:
```py
auth_token = HTTPBearer(auto_error=False)
@app.check_security(auth_token)
def check_token(token):
# Include code to check the token
pass
```
Thanks!! 😄
|
feature,investigate,reviewed
|
low
|
Critical
|
583,547,637 |
pytorch
|
TracerWarning: Output nr 1. of the traced function does not match the corresponding output of the Python function
|
## 🐛 Bug
I am calling `torch.jit.trace` on a model and I am getting the corresponding error:
```TracerWarning: Output nr 1. of the traced function does not match the corresponding output of the Python function.```
This leads to the same inputs yielding different output results (Traced vs non-traced model).
Tried different approaches to fix it (also calling `eval()`), but nothing has worked so far. It is also interesting that the relative errors are quite high (see below).
## To Reproduce
Detailed error:
```TracerWarning: Output nr 1. of the traced function does not match the corresponding output of the Python function. Not within tolerance rtol=1e-05 atol=1e-05 at input[1] (5.841293811798096 vs. 19.417325973510742) and 9 other locations (100.00%)```
## Expected behavior
Tracing works without errors.
## Environment
PyTorch 1.1.0
Python 3.7.6
Ubuntu 18.04
cc @suo
|
needs reproduction,oncall: jit,triaged
|
medium
|
Critical
|
583,551,402 |
godot
|
Borderless window still shows Status Bar and can be resized in full screen
|
**Godot version:**
3.2.1
**OS/device including version:**
macOS Catalin 10.15.3 / MacBookPro11,1
**Issue description:**
When the game runs in full screen WITHOUT the Borderless option enabled, if the cursor hits the top edge of the screen, the whole Menu Bar and Status Bar appears; also, when the cursor hits the bottom edge of the screen, the Dock appears.
**The problem:**
When the game runs in full screen WITH the Borderless option enabled, when the cursor hits the bottom edge of the screen the Dock does NOT appear anymore, but when the cursor hits the top edge of the screen, the Status Bar STILL APEEARS.
**The second problem:**
When the game runs in Full Screen with the Borderless option enabled, but NOT with the Resizable option enabled, the window can still be resized, which looks very weird.
**Steps to reproduce:**
Enable/Disable Full Screen, Borderless and/or Resizable options based on which problem need to be reproduced.
**Minimal reproduction project:**
Not necessary. Works with empty projects.
|
bug,platform:macos,topic:porting
|
low
|
Minor
|
583,559,683 |
pytorch
|
Equality operator for torch.distribution.*
|
## 🚀 Feature
Implement `__eq__()` for torch.distributions.distribution.Distribution and subclasses.
## Motivation
This would avoid situations such as:
```
from torch.distributions import Normal
assert Normal(0, 1) == Normal(0, 1)
AssertionError
```
It should be possible to compare distributions without the need of writing custom code.
The comparison operator could be implemented according to the parameters that define the distribution itself.
As an example, the Normal class could have:
```
def __eq__(self, other):
return self.loc == other.loc and self.scale == other.scale
```
cc @vincentqb @fritzo @neerajprad @alicanb @vishwakftw
|
module: distributions,triaged,enhancement
|
low
|
Critical
|
583,571,670 |
go
|
x/tools/cmd/present2md: support full translation
|
Not sure this should be considered part of #33955. Please close if so.
The new `present2md` tool converts the `present` format to `markdown`. However, it is still missing some pieces of the present format when converting, namely:
- Captions
- Images
There may be more types I've missed, but these were the ones I noticed so far.
These are being caught by the fallback `PresentCmd` interface here:
https://github.com/golang/tools/blob/11a475a590acad44f466dde7d3e988cf52bad01c/cmd/present2md/main.go#L236-L247
I think it should be possible to convert both of these to markdown, though the caption may be more complicated.
|
help wanted,NeedsInvestigation,Tools
|
low
|
Minor
|
583,572,232 |
create-react-app
|
[PROPOSAL]: Allow an option to make the build fail if CRA emits warnings during build
|
### Is your proposal related to a problem?
<!--
Provide a clear and concise description of what the problem is.
For example, "I'm always frustrated when..."
-->
Our team is always frustrated when pr's are merged and the next time we run the app we get a boat load of console errors/warnings about React not recognizing props on a DOM element or failing prop types.
The errors themselves are fantastic but we'd like to find them sooner.
### Describe the solution you'd like
<!--
Provide a clear and concise description of what you want to happen.
-->
Allow an option to make the build fail when a warning is shown because someone forgot to add an `onChange` handler or because someone used `for` instead of `htmlFor`
### Describe alternatives you've considered
<!--
Let us know about other solutions you've tried or researched.
-->
I thought about creating a Jest test that would fail if `console.error` is called, but that only works on a per component basis whilst `npm run build` does it for the entire project.
### Additional context
<!--
Is there anything else you can add about the proposal?
You might want to link to related issues here, if you haven't already.
-->
|
issue: proposal,needs triage
|
low
|
Critical
|
583,581,992 |
rust
|
no_mangle causes compilation errors with async-await on armv7-linux-androideabi and aarch64-linux-android targets
|
<!--
Thank you for filing a bug report! 🐛 Please provide a short summary of the bug,
along with any information you feel relevant to replicating the bug.
-->
Adding the no_mangle attribute to a function which contains an await results in a compilation error for armv7-linux-androideabi and aarch64-linux-android targets. Removing the attribute fixes the issue (though that's not a solution). There are no problems with x86_64-linux-android and i686-linux-android targets.
```rust
#![cfg(target_os = "android")]
#![allow(non_snake_case)]
use tokio::{runtime::Runtime };
#[no_mangle]
pub fn Java_blah_blah_func() -> &'static str {
Runtime::new().unwrap().block_on(async {
myfunc().await
})
}
async fn myfunc() -> &'static str {
"hello"
}
```
I expected to see this happen: library should get compiled successfully.
Instead, I get the following error:
```
Function return type does not match operand type of return inst!
ret i32 undef
{ i8*, i32 }in function _ZN80_$LT$std..future..GenFuture$LT$T$GT$$u20$as$u20$core..future..future..Future$GT$4poll17h2e6af84f5e832d75E
LLVM ERROR: Broken function found, compilation aborted!
```
### Meta
<!--
If you're using the stable version of the compiler, you should also check if the
bug also exists in the beta or nightly versions.
-->
The error exists in the beta and nightly versions. RUST_BACKTRACE=1 doesn't seem to add additional information.
|
I-crash,A-LLVM,O-android,P-medium,T-compiler,regression-from-stable-to-stable,C-bug,A-async-await,E-needs-bisection,AsyncAwait-Triaged,E-needs-mcve,ICEBreaker-LLVM,ICEBreaker-Cleanup-Crew
|
medium
|
Critical
|
583,591,778 |
vue-element-admin
|
markdown插件tui-editor无法左右两边一起滚动
|
## Bug report（问题描述）
markdown插件tui-editor无法左右两边一起滚动
加上参数
```
:options="{
exts: ['scrollSync']
}"
```
#### Steps to reproduce（问题复现步骤）
1.
```
<MarkdownEditor ref="markdownEditor"
v-model="ruleForm.description"
:language="language"
height="580px"
:options="{
exts: ['scrollSync']
}"
/>
```
2.加上 exts: ['scrollSync'] 应该有scroll on图标的，但是并没有
#### Screenshot or Gif（截图或动态图）
#### Link to minimal reproduction（最小可在线还原demo）
官网demo没问题
https://nhn.github.io/tui.editor/latest/tutorial-example01-editor-basic
#### Other relevant information（格外信息）
- Your OS: 无
- Node.js version: 无
- vue-element-admin version:无
|
tui-editor
|
medium
|
Critical
|
583,625,458 |
create-react-app
|
Progress bar when run `npm run build`
|
This is the new thread for #935. Four years after there's still no progress.
> When running `npm run build`, it takes a long time to build.
> How to implement a progress bar when building?
|
issue: proposal,needs triage
|
low
|
Major
|
583,672,714 |
go
|
net: Unable to reliably distinguish IPv4-mapped-IPv6 addresses from regular IPv4 addresses
|
<!--
Please answer these questions before submitting your issue. Thanks!
For questions please use one of our forums: https://github.com/golang/go/wiki/Questions
-->
### What version of Go are you using (`go version`)?
<pre>
$ go version
go version go1.13.8 darwin/amd64
</pre>
### Does this issue reproduce with the latest release?
Yes
### What operating system and processor architecture are you using (`go env`)?
<details><summary><code>go env</code> Output</summary><br><pre>
$ go env
GO111MODULE="off"
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/alouis/Library/Caches/go-build"
GOENV="/Users/alouis/Library/Application Support/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
GOPATH="/Users/alouis/Documents/go_playground"
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/darwin_amd64"
GCCGO="gccgo"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/gf/xt8nljp959z9gyd_qdvr68gc0000gp/T/go-build940989106=/tmp/go-build -gno-record-gcc-switches -fno-common"
</pre></details>
### What did you do?
https://play.golang.org/p/gGY8VPwVm2J
### What did you expect to see?
Some way to parse an IPv4 mapped IPv6 address (e.g. `0:0:0:0:0:ffff:ac15:0006` or `::ffff:172.21.0.6`) and know that it is an IPv4 mapped IPv6 address.
The `net` package is bit prohibitive here, given that the `ParseIP` method is pretty opinionated. See here:
```
ip := net.ParseIP("::ffff:ac15:0006") // -> 172.21.0.6 (the ip4 equivalent of ac15:0006)
len(ip) // -> 16, this is because internally, all IPs seem to be 16 byte net.IP{0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0xff, 0xff, 0xac, 0x15, 0x0, 0x6}
```
### What did you see instead?
For any given IPv4-mapped-IPv6 address IP, all the IP parsing in the `net` package only indicate that the input is an IPv4 address.
This is also perhaps, further complicated by the internal representation of IPv4 addresses being 16 bytes, bearing the `::ffff` prefix internally.
However, if the user is using the `net` package for IP sanitization/validation, not being able to tell the difference seems to be a shortcoming. In order to be implement this on my own, I had to copy/paste the `parseIPv6` method from the `net` package, and do something like the following:
```
func isIPv4MappedIPv6Address(in string) bool {
in = strings.Split(in, "/")[0]
ip := parseIPv6(in)
if ip == nil {
// not an ipv6 address
return false
}
if ip.To4() == nil {
// couldn't map our ip6 to an ip4
return false
}
return true
}
```
I would propose here to expose the `parseIPv6` and `parseIPv6` methods. Exposing the Parse helpers would help multiple use-cases I'm sure, without increasing the API footprint significantly of the net package
---
For more parsing fun related to IPv4-mapped-IPv6 addresses, here's another instance where things look weird: https://play.golang.org/p/lsVp472VG4E
```
ip, network, _ := net.ParseCIDR("::ffff:ac15:0006/32")
fmt.Printf("ip: %v\n", ip) // ip: 172.21.0.6
fmt.Printf("network: %v\n", network) // network: ::/32
```
Since `ip` at this point is the 16 byte form, it does have the prefix, but then again any other IPv4 address would have as we see. However, we get an IPv6 network, which will leave the onus on the user to make sense of this result.
|
NeedsInvestigation
|
low
|
Critical
|
583,689,293 |
pytorch
|
[feature request] Sparse (hybrid sparse-dense) output option for topk, min, max
|
I wonder if PyTorch hybrid sparse/dense tensors can be used to represent outputs of dimension-wise topk / min / max. Unfortunately I couldn't completely understand from docs if they can be used for that (my current understanding is that they could not out of the box, hence feature request).
Probably pruning work is related as well.
My current impl storing directly indices/values from topk: https://gist.github.com/vadimkantorov/c473a181017e654444cbdfbcafa265e2
Usecase: store logits/log_probs compactly on disk
Context: https://discuss.pytorch.org/t/sparse-torch-topk-can-hybrid-sparse-dense-tensors-help/71832/2
cc @vincentqb
|
module: sparse,triaged
|
low
|
Minor
|
583,694,872 |
godot
|
hint tooltip scaled with control
|
**Godot version:**
3.2.1
**OS/device including version:**
Windows 10
**Issue description:**
I'm not sure if this is intended behavior, but 3.1.1 didn't do this and so the game I'm working on relied on this.
**Steps to reproduce:**
Create a TextureButton, add a a hint tooltip, scale down to 0.5, tooltip will be scaled too.
**Minimal reproduction project:**
|
discussion,topic:gui
|
low
|
Major
|
583,729,157 |
terminal
|
Allow to directly connect to PWSH in Azure Cloudshell bypassing bash
|
<!--
🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨
I ACKNOWLEDGE THE FOLLOWING BEFORE PROCEEDING:
1. If I delete this entire template and go my own path, the core team may close my issue without further explanation or engagement.
2. If I list multiple bugs/concerns in this one issue, the core team may close my issue without further explanation or engagement.
3. If I write an issue that has many duplicates, the core team may close my issue without further explanation or engagement (and without necessarily spending time to find the exact duplicate ID number).
4. If I leave the title incomplete when filing the issue, the core team may close my issue without further explanation or engagement.
5. If I file something completely blank in the body, the core team may close my issue without further explanation or engagement.
All good? Then proceed!
-->
# Description of the new feature/enhancement
Currently to launch powershell cloudshell in Windows Terminal one have to launch bash and then within bash you have to launch powershell ending up with shell running inside another shell plus additional time to perform those task on each run.
<!--
A clear and concise description of what the problem is that the new feature would solve.
Describe why and how a user would use this new functionality (if applicable).
-->
# Proposed technical implementation details (optional)
<!--
A clear and concise description of what you want to happen.
-->
Do the same what Azure portal offers where you are given a choice which shell you want when you connect to cloudhsell either bash or powershell and go directly into it.
|
Product-Terminal,Issue-Task,Area-AzureShell,Priority-3
|
low
|
Critical
|
583,731,171 |
godot
|
Editor Plugin: adding a node to a child node of the root node of the currently open scene won't show up in scene tree
|
**Godot version:**
3.2.1
**OS/device including version:**
Manjaro Linux
**Issue description:**
I am developing an editor plugin which is added to the dock. Essentially you click a button and nodes will be added to the currently open scene. Now when you a node (via the plugin) to the root node of the current scene everything works as expected (scene tree gets updated + the node renders in the editor). But when you add the new node as child of a child node of the root node, the new node does not show up in the scene tree (but will be rendered and can also be moved by moving the parent). If you save the scene and reload it, the new node is gone.
Adding a new node to the root node (works):
```
func _add_node(node: Node) -> void:
var scene = get_tree().get_edited_scene_root()
if scene == null:
printerr("Failed to add node %s: No scene open" % node.name)
else:
scene.add_child(node)
node.owner = scene
```
Adding new node as child of child node of root node (won't show up in scene tree):
```
func _add_node(node: Node) -> void:
var scene = get_tree().get_edited_scene_root()
if scene == null:
printerr("Failed to add node: No scene open")
return
var container = scene.get_node("Container")
if container == null:
printerr("No Container node found in current scene")
return
container.add_child(node)
node.owner = container
```
**Steps to reproduce:**
- Create an editor plugin in the dock
- Add a new node to a child of the root node in the currently open scene via the plugin
- New node does not show up in in scene tree but it gets rendered
**Minimal reproduction project:**
[BuggyPlugin.zip](https://github.com/godotengine/godot/files/4349290/BuggyPlugin.zip)
**Edit**: added minimal reproduction project
|
bug,topic:editor,topic:plugin
|
low
|
Critical
|
583,753,771 |
pytorch
|
Graphic tool to view the backward(Gradient Graph) and forward graph in Pytorch
|
Is there any graphical tool based on dot (graphViz) similar to what (TensorFlow and Pytorch/Glow) to view the backward Graph in Pytorch or at least a way to get a textual dump of backward Graph where the Graph Tree with Nodes and there edges can be seen, somethings on the line of JIT IR. Is there some environment variable like PYTORCH_JIT_LOG_LEVEL or some logic to dump the Nodes/edges in torch/csrc/distributed/autograd/engine/ .
```
[DUMP inliner.cpp:049] %6 : Tensor = prim::CallMethod[name="forward"](%5, %input.1)
[DUMP inliner.cpp:049] %input.3 : Float(1, 32, 14, 14) = aten::relu(%6) # /home/ddeepani/anaconda3/lib/python3.7/site-packages/torch/nn/functional.py:914:0
[DUMP inliner.cpp:049] %8 : Tensor = prim::CallMethod[name="forward"](%4, %input.3)
[DUMP inliner.cpp:049] %x1 : Float(1, 64, 12, 12) = aten::relu(%8) # /home/ddeepani/anaconda3/lib/python3.7/site-packages/torch/nn/functional.py:914:0
```
|
triaged,oncall: visualization
|
low
|
Major
|
583,796,336 |
godot
|
`AudioStreamPlayer.stop()` does not stop playback if playback was started in the same frame
|
**Godot version:**
3.2.1
**OS/device including version:**
Windows 10 64-bit
**Issue description:**
AudioStreamPlayer does not stop playback if stream position is zero.
In my project sometimes there are situations when states change very quickly, one state plays sound effect, another stops it.
I found out that
```
$sfx.play()
$sfx.stop()
```
is not working as expected.
**Steps to reproduce:**
Add AudioStreamPlayer, load sound stream and execute play() stop() methods in once block.
**Minimal reproduction project:**
[AudioStreamPlayerPlayStop.zip](https://github.com/godotengine/godot/files/4349664/AudioStreamPlayerPlayStop.zip)
|
bug,confirmed,topic:audio
|
low
|
Major
|
583,820,238 |
excalidraw
|
Share a live view without collaborating
|
Used it today for the first time. Very cool app. It would be nice if the app could also generate a live view where other viewers can’t collaborate. That way it could be used as a (remote) teaching whiteboard without the possibility for students to draw all kinds of inappropriate stuff. Especially since they're anonymous.
|
enhancement,collaboration
|
low
|
Minor
|
583,848,485 |
flutter
|
AnimatedFractionallySizedBox
|
## Use case
I would like to animate `FractionallySizedBox` between various `heightFactor` and `widthFactor` values.
## Proposal
I propose to add a `AnimatedFractionallySizedBox` Widget which would animate between `heightFactor` and `widthFactor` over a given duration. Much like `AnimatedPositioned`.
|
c: new feature,framework,would be a good package,P3,team-framework,triaged-framework
|
low
|
Major
|
583,865,703 |
godot
|
Reference counts not managed correctly when Reference types are returned from a GDNative node?
|
**Godot version:**
3.2
**OS/device including version:**
Windows 10
**Issue description:**
In certain situations References don't seem to be dereferenced as I would expect them to, leading to memory leaks. Perhaps I am doing something wrong or have some misunderstanding.
For clarity's sake here are two examples where References work as expected, and a third example where they do not.
`Thing` is a class derived from `Reference`
```
class Thing : public Reference {
GODOT_CLASS(Thing, Reference);
public:
Thing() {
std::cout << "Thing created" << std::endl;
}
~Thing() {
std::cout << "Thing deleted" << std::endl;
}
void _init() {}
};
```
**Example 1 - Instantiating in gdscript (works as expected)**
```
var Thing:Resource = preload("res://bin/Thing.gdns")
...
func _ready():
var thing = Thing.new()
# var goes out of scope, thing is deleted because there are no references left.
```
Output:
```
Thing created
Thing deleted
```
**Example 2 - Instantiating in gdscript and passing the reference to a GDNative object to store (also works as expected)**
```
class ThingHolder : public Node {
GODOT_CLASS(ThingHolder, Node);
Ref<Thing> thing_to_hold;
public:
static void _register_methods() {
register_method("hold_thing", &ThingHolder::hold_thing);
}
void _init() {}
void hold_thing(Ref<Thing> thing) {
thing_to_hold = thing
}
};
```
```
func _ready():
var thing = Thing.new()
# ThingHolder loaded as Autoload node
ThingHolder.hold_thing(thing)
# var goes out of scope, ThingHolder still holds a reference to the
# thing, so the object is not deleted yet.
```
As expected, "Thing deleted" is not printed until game shutdown when the ThingHolder is destructed.
**Example 3 - Instantiating in GDNative and returning a Ref<Thing> (does not work as expected)**
```
class ThingCreator : public Node {
GODOT_CLASS(ThingCreator, Node);
public:
static void _register_methods() {
register_method("make_thing", &ThingCreator::make_thing);
}
void _init() {}
Ref<Thing> make_thing() {
return Ref<Thing>(Thing::_new()); // (Correct?? Can't find any documentation on this.)
}
};
```
```
func _ready():
# ThingCreator loaded as Autoload node
var thing = ThingCreator.make_thing()
# At this point, there is only one logical reference to the thing, so it
# should be deleted when var goes out of scope.
```
"Thing created" is printed but "Thing deleted" is never printed. When the game exits we get the familiar message:
```
WARNING: cleanup: ObjectDB Instances still exist!
At: core/object.cpp:2071
ERROR: clear: Resources Still in use at Exit!
At: core/resource.cpp:476
```
|
discussion,topic:gdextension
|
low
|
Critical
|
583,890,587 |
rust
|
Ugly error reporting on binary operation between two condition flows
|
The following code:
```rust
fn to_log_flags(fatal: bool, recursive: bool) -> u32 {
if fatal { 1 } else { 0 } |
if recursive { 2 } else { 0 }
}
```
gives the following error:
```
Compiling playground v0.0.1 (/playground)
error: expected identifier, found keyword `if`
--> src/main.rs:3:5
|
3 | if recursive { 2 } else { 0 }
| ^^ expected identifier, found keyword
error: expected identifier, found `2`
--> src/main.rs:3:20
|
3 | if recursive { 2 } else { 0 }
| ^ expected identifier
error: expected one of `,`, `:`, or `@`, found `recursive`
--> src/main.rs:3:8
|
3 | if recursive { 2 } else { 0 }
| -^^^^^^^^^ expected one of `,`, `:`, or `@`
| |
| help: missing `,`
error: expected identifier, found keyword `else`
--> src/main.rs:3:24
|
3 | if recursive { 2 } else { 0 }
| ^^^^ expected identifier, found keyword
|
help: you can escape reserved keywords to use them as identifiers
|
3 | if recursive { 2 } r#else { 0 }
| ^^^^^^
error: expected identifier, found `0`
--> src/main.rs:3:31
|
3 | if recursive { 2 } else { 0 }
| ^ expected identifier
error: expected one of `,` or `:`, found keyword `else`
--> src/main.rs:3:24
|
3 | if recursive { 2 } else { 0 }
| -^^^^ expected one of `,` or `:`
| |
| help: missing `,`
error: expected one of `:` or `|`, found `}`
--> src/main.rs:4:1
|
3 | if recursive { 2 } else { 0 }
| - expected one of `:` or `|`
4 | }
| ^ unexpected token
error[E0308]: mismatched types
--> src/main.rs:2:16
|
2 | if fatal { 1 } else { 0 } |
| -----------^-------------- help: consider using a semicolon here
| | |
| | expected `()`, found integer
| expected this to be `()`
error[E0308]: mismatched types
--> src/main.rs:2:27
|
2 | if fatal { 1 } else { 0 } |
| ----------------------^--- help: consider using a semicolon here
| | |
| | expected `()`, found integer
| expected this to be `()`
error: aborting due to 9 previous errors
For more information about this error, try `rustc --explain E0308`.
```
This is clearly sub-optimal. The code can be fixed by wrapping the first if condition in `()`.
|
A-type-system,C-enhancement,A-diagnostics,A-parser,T-compiler,D-confusing,T-types
|
low
|
Critical
|
583,916,165 |
youtube-dl
|
Site support request: Fox Turkey
|
<!--
######################################################################
WARNING!
IGNORING THE FOLLOWING TEMPLATE WILL RESULT IN ISSUE CLOSED AS INCOMPLETE
######################################################################
-->
## Checklist
<!--
Carefully read and work through this check list in order to prevent the most common mistakes and misuse of youtube-dl:
- First of, make sure you are using the latest version of youtube-dl. Run `youtube-dl --version` and ensure your version is 2020.03.08. If it's not, see https://yt-dl.org/update on how to update. Issues with outdated version will be REJECTED.
- Make sure that all provided video/audio/playlist URLs (if any) are alive and playable in a browser.
- Make sure that site you are requesting is not dedicated to copyright infringement, see https://yt-dl.org/copyright-infringement. youtube-dl does not support such sites. In order for site support request to be accepted all provided example URLs should not violate any copyrights.
- Search the bugtracker for similar site support requests: http://yt-dl.org/search-issues. DO NOT post duplicates.
- Finally, put x into all relevant boxes (like this [x])
-->
- [x] I'm reporting a new site support request
- [x] I've verified that I'm running youtube-dl version **2020.03.08**
- [x] I've checked that all provided URLs are alive and playable in a browser
- [x] I've checked that none of provided URLs violate any copyrights
- [x] I've searched the bugtracker for similar site support requests including closed ones
## Example URLs
<!--
Provide all kinds of example URLs support for which should be included. Replace following example URLs by yours.
-->
- Single video: https://www.fox.com.tr/Ogretmen/bolum/1
- Single video: https://www.foxplay.com.tr/Ogretmen/bolumler/1-bolum
## Description
<!--
Provide any additional information.
If work on your issue requires account credentials please provide them or explain how one can obtain them.
-->
They are official sites of Fox Turkey
Both URLs (fox.com.tr and foxplay.com.tr) should be using same backend.
It's supported by streamlink if it helps: https://github.com/streamlink/streamlink/blob/master/src/streamlink/plugins/foxtr.py
Youtube-dl weirdly downloads some HTML file on the first URL
Here is the log:
```
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['-v', 'https://www.fox.com.tr/Ogretmen/bolum/1']
[debug] Encodings: locale cp1254, fs mbcs, out cp1254, pref cp1254
[debug] youtube-dl version 2020.03.08
[debug] Python version 3.4.4 (CPython) - Windows-7-6.1.7601-SP1
[debug] exe versions: ffmpeg git-2020-03-15-c467328, ffprobe git-2020-03-15-c467328, phantomjs 2.1.1, rtmpdump 2.4
[debug] Proxy map: {}
[generic] 1: Requesting header
WARNING: Falling back on generic information extractor.
[generic] 1: Downloading webpage
[generic] 1: Extracting information
[download] Downloading playlist: FOX | Öğretmen 1. Bölüm
[generic] playlist FOX | Öğretmen 1. Bölüm: Collected 1 video ids (downloading 1 of them)
[download] Downloading video 1 of 1
[debug] Default format spec: bestvideo+bestaudio/best
[debug] Invoking downloader on "https://www.fox.com.tr/Ogretmen/bolum/'+videoSrc+'"
[download] Destination: FOX _ Öğretmen 1. Bölüm-1.unknown_video
[download] 100% of 123.41KiB in 00:00
[download] Finished downloading playlist: FOX | Öğretmen 1. Bölüm
```
|
site-support-request
|
low
|
Critical
|
583,926,094 |
TypeScript
|
`@ts-ignore` quick fix should be switched to `@ts-expect-error`
|
Today we provide a quick fix in JavaScript files (e.g. `.js`, `.jsx`) under `// @ts-check` and `checkJs` to suppress errors by adding a
```js
// @ts-ignore
```
comment.
Now that we have `// @ts-expect-error` which errors in the presence of no errors, we should probably switch the quick fix over to use that instead.
|
Suggestion,Awaiting More Feedback
|
medium
|
Critical
|
583,928,441 |
godot
|
MemoryPool size hardcoded?
|
**Godot version:**
3.2.1rc1-custom
**OS/device including version:**
Ubuntu 19.10
**Issue description:**
Why MemoryPool amount is hardcoded?
Just on the file core/pool_vector.h there are the declaration:
`static void setup(uint32_t p_max_allocs = (1 << 16));`
I am asking if there are a reason to do that.
I need more memory for a module that create voxels and I will change it for myself.
But I see that in Godot 4.0 the memory pool is rewrited. So I hope it can allocate by demand. Am I right about this?
And will the 3.2.x series remain hardcoded? Or are there some plans to make that value a project setting?
|
discussion,topic:core
|
low
|
Major
|
583,929,065 |
terminal
|
Scenario: Keyboard Text Selection
|
##### [Original issue: #715] [Original Spec: #2840] [Mark mode spec: #5804] [initial PR: #10824] [markers PR: #10865]
## Features
* [x] #715
* [x] Quick Edit (modify existing selection w/ keyboard)
* [x] #1469
* implicit mark mode
* [ ] #11985
- see also: #13369
* [x] [follow-up] #3663
* [x] [follow-up] #6649
* [x] [follow-up] #4985
## Bugs
- #13413
- #13447
- #13485
## Misc.
* [ ] [Remove optional param for copy func, manually clear selection instead](https://github.com/microsoft/terminal/pull/13360#discussion_r905290481)
* feedback from #13533:
- [ ] Prioritize mark mode key bindings over custom key bindings when in mark mode
- Scrolling...
- [ ] [PROTOTYPE] scrolling should move the "mark"
- [ ] If we've scrolled, then we enter mark mode, start position should be somewhere in the visible area (NOT back at the input buffer aka the cursor position).
## PRs
- Spec...
- #2840
- #5804
- Impl...
- #3758
- #10824
- #13045
- #10865
- #13053
- #13358
- #13370
- #13405
- #13435
|
Area-Input,Area-TerminalControl,Product-Terminal,Issue-Scenario
|
low
|
Critical
|
583,946,511 |
excalidraw
|
We should have a different hint when drawing multisegments lines on mobile
|
enhancement,good first issue
|
low
|
Minor
|
|
583,978,112 |
vscode
|
[rename on type] option-delete and pasting creates 2 undo stops
|
Ref #88424
- Have content `<div></div|> `
- Option-delete or paste something
- You need two undo to restore the original content
|
bug,editor-synced-region
|
low
|
Minor
|
583,980,468 |
godot
|
Project always starts in maximized window
|
**Godot version:** 3.2.1 stable
**OS/device including version:** Ubuntu 18.04.4, 2 monitors, main monitor 2560 x 1440, GTX 1060
driver 435.21
**Issue description:** The project window size setting settings and editor window placement setting are ignored. Whatever I set, the project window always start maximized (OS.window_maximized always true on startup). It holds both for exported project and project run from editor. Maybe related to #36462 and #35571
**Steps to reproduce:** Set window width and height to smaller values than the resolution of the screen and run the project.
|
bug,topic:porting,needs testing
|
low
|
Major
|
583,982,952 |
pytorch
|
`conv2d` is slow with specific shapes of channels_last tensors
|
GPU: Tesla V100-SXM2
Cuda: 10.0
CudNN: 7603
```python
def f(x, w, args):
o = torch.conv2d(x, w, *args)
o.sum().backward()
torch.cuda.synchronize()
inputs = ((100, 2048, 14, 14), (2048, 64, 3, 3), None, (2, 2), (1, 1), (1, 1), 32)
shape_i = inputs[0]
shape_w = inputs[1]
args = inputs[2:]
for mf in (torch.contiguous_format, torch.channels_last):
x = torch.rand(shape_i, dtype=torch.float16, device='cuda').contiguous(memory_format=mf)
w = torch.rand(shape_w, dtype=torch.float16, device='cuda', requires_grad=True).contiguous(memory_format=mf)
print(mf)
%timeit f(x,w,args)
```
```
torch.contiguous_format
4.11 ms ± 37.3 µs per loop (mean ± std. dev. of 7 runs, 1 loop each)
torch.channels_last
143 ms ± 29.3 µs per loop (mean ± std. dev. of 7 runs, 10 loops each)
```
cc @csarofeen @ptrblck @VitalyFedyunin @jamesr66a @ngimel
|
module: performance,module: cudnn,triaged,module: memory format
|
low
|
Major
|
584,001,632 |
godot
|
GridMap: Metadata issues on updating / removing Mesh Library
|
**Godot version:** 3.0 - 3.2.1
**OS/device including version:** Windows 10 Pro 64-bit
**Issue description:**
I will start by saying that those are a number of issues which are all related to GridMap metadata, which include:
- Failure to update item preview on Mesh Library update
- Failure to update actual item (i.e. Mesh Library object) on Mesh Library update
- Wrong items and previews on Mesh Library update
- Wrong GridMap objects being rendered when running objects after Mesh Library update - GridMap objects in the editor are different to GridMap objects at runtime (this is perhaps the weirdest problem)
- Failure to clear GridMap metadata after removing Mesh Library - this can result in a messed scene if another library is attached, unless this library is compatible to old one, which is not always the case
- Unknown extra material changes happening during rendering after updating Mesh Library (i.e 3 material changes instead of 2)
All those issues are caused by either updating or removing / re-adding MeshLibrary. They can cause a lot of confusion to those unaware of them, as those issues are not obvious as to the cause.
Solutions:
- Always delete your /.import folder as well as all .import files when updating your Mesh Library
- You may need to delete and re-add your GridMap nodes if the issues persist, as they do store information which is not destroyed when removing / updating libraries
|
bug,topic:editor
|
low
|
Critical
|
584,007,686 |
terminal
|
Suggestion: Translate vscode color themes to terminal color schemes
|
For someone that knew the attributes in both vscode color themes and in terminal color scheme, it seems that it would be easy to write, say, a Python script to do this translation.
Because I know neither, I can only describe the need.
|
Product-Colortool,Help Wanted,Area-Settings,Issue-Task
|
low
|
Major
|
584,012,335 |
terminal
|
[Megathread] Panes Titlebar Follow-ups
|
##### [Panes megathread #1000] [Original PR: #7371] [Original Issue: #4717]
### Tasks
* [ ] Add a context menu entry for "close pane"
* [ ] Add a context menu entry for "zoom pane"
* [ ] Add optional "maximize/close" control
- Like the MinMaxCloseControl, but without minimize, and with "maximize" being "zoom pane"
- Should that option be in the theme? (#3327) _I'm thinking YES_
* [ ] Allow moving panes to other tabs #7075
### Open Discussion
* [ ] How should pane title color work with `tabColor`? https://github.com/microsoft/terminal/pull/7371#issuecomment-679223330
> > Currently, setting the tab's background color with the color picker does not update the pane titlebar color.
>
> I think that's fine. Currently, the order of precedence is [tab runtime color, control title color, theme color (unimplemented), default color]. So I could imagine this going two ways:
> * convert the "tab runtime color" to be a "pane runtime color". Then, using the color picker on the tab would set the active _pane_'s runtime color. This comes with the detrimental side effect that you'd have to re-color each pane in a tab manually.
> * add an additional "pane runtime color", and have the tab's color be composed from [tab runtime color, pane color (which is itself [pane runtime color, control title color, theme pane title color]), theme color, default]. This would allow panes to have their color changed at runtime with a color picker, and also have the tab have a manual color override.
>
>
> I'm of course just hypothesizing here in the comments - I don't think any of this is something that _needs_ to get done in _this_ PR. We can always loop back on the issue in a follow-up.
* [ ] Should the titlebar for a pane not appear until there are multiple panes? Kinda seems like there are three states: `paneTitlebarVisibility: [never, multiplePanes, always]`
|
Area-UserInterface,Product-Terminal,Issue-Scenario
|
low
|
Minor
|
584,012,361 |
terminal
|
Scenario: Add support for hyperlinks
|
This is the the megathread for tracking all the remaining work that needs to be done for hyperlink support in Terminal.
### "Soon" Timeframe
* [x] Original issue: #204 -> added in #7251
* [x] Allow `file://` URIs -> added in #7526
* [ ] #7562 Allow other URI schemes
* [x] Render hyperlinks differently from regular text in Terminal -> added in #7420
* [x] Hover underline text that have the same hyperlink ID and display the URI -> added in #7420
* [x] Display a content dialog box for URIs we cannot parse/schemes we do not support -> added in #7523
* [x] https://github.com/microsoft/terminal/issues/574 Add support for Terminal to auto-detect hyperlinks -> added in #7691
* [ ] #7563 Switch the pointer to the 👆 icon when we're hovering a link (in the clickable state, like with ctrl pressed)
* [ ] `VtEngine::_SetHyperlink` uses `fmt::format` to render the hyperlinks, and it should really use `_WriteFormattedString`
* [ ] #7564 Hook up hyperlinks to conhost (rendering + clicking)
* [ ] #7565 Make sure hyperlinks are included in HTML copy
* [x] #8123 Only underline hyperlinks on hover -> added in #8148
* [ ] ~Controlling tooltip delay for URLs #8242~
- Abandoned, platform limitation
* [x] ~Add a setting to disable auto detection of links (in PR #8239)~
- Abandoned, we're not sure anyone actually ever wanted this
* [x] Links/URLs get offset when certain unicode characters are printed #8709
* [x] #9117
* [x] #6649
* [ ] #11901
### Backlog
* [ ] Add a setting to configure the regex used to detect patterns
* [ ] #8849
- Theoretically, this could supersede #7562
- Should be self-consistent with #8294
* [ ] Control the styling of hyperlinks - attributes used for autodetected hyperlinks, and then different attributes for hovered ones #8294
* [ ] #2671
### References
* This VsCode issue has an enormous set of references to improvements they've made: https://github.com/microsoft/vscode/issues/172084
* #15700
|
Area-VT,Area-UserInterface,Product-Terminal,Issue-Scenario
|
high
|
Major
|
584,037,873 |
pytorch
|
Better examples in functional autograd functions
|
The current documentation of `torch.autograd.functional` follows that same practice as other places: create random Tensors and print them.
We could improve that by:
- Use hard coded values to make them more readable and easily reproducible
- Find a way to test that the docstring example stays up to date with what the function does?
cc @ezyang @SsnL @albanD @zou3519 @gqchen
|
module: docs,module: autograd,triaged
|
low
|
Minor
|
584,047,240 |
flutter
|
Web: PhysicalModelLayer doesn't check elevation
|
Currently `physical_model_test.dart` disables some tests because we do not check elevation on the Web the same way mobile Flutter does (or at all). We need to match the mobile behavior.
|
engine,platform-web,c: rendering,P2,team-web,triaged-web
|
low
|
Minor
|
584,062,855 |
TypeScript
|
Dynamic object key + discriminated union + typeof could have a better narrowing type
|
## Search Terms
dynamic object key, discriminated union, typeof, type inference, narrowing type
## Suggestion (or is it a bug report?)
We could write a discriminated union with one of the cases is a dynamic object key. For example...
```ts
type TExample = (
{
[key in string]: {
foo: number
}
}
| {
errorCode: string
}
)
```
So, if the key is `errorCode` it could be a `{ foo: number }` or a `string`. If the key is any string that isn't `errorCode`, it should be a `{ foo: number }`.
Then let's check that.
```ts
const func: () => TExample = () => ... // get value from somewhere
const value = func()
if ('errorCode' in value && typeof value.errorCode === 'string') {
value // what's the type of value here?
}
```
So, makes sense that the `value`'s type should be `{ errorCode: string }`, right?
But the type still is `TExample`! I think that we could have a better narrowing type, because `value` only shoud be `{ errorCode: string }` on this case.
Similarly, would be nice to have that:
```ts
if ('errorCode' in value && typeof value.errorCode === 'object') {
value // should be { [key in string]: { foo: number } }
}
```
As well as...
```ts
if ('errorCode' in value && typeof value.errorCode === 'number') {
value // should be never
}
```
[_Full code on playground_](https://www.typescriptlang.org/play/#code/C4TwDgpgBAKgogDwIYFswBtoF4oAoCwAUFFAN5EkkDaA1hCFAJYB2UAzsAE4sDmAugC4yFSqIBmAewlDmAVxQAjCJxEkAviI3EoAH2HaSyzhM4BhCQBMIQjt2Y9NRAJREiAYwnMOUMbOZuhXCcoLAA+WERUDGw8YLC8UigFdCQACyFEyWkoAEYoNXyXQndPbwA3JHRZGN9-INdCRjE8AHIjE3MrFqZWCqroADIBqFBICWa+6oA6drNLbCwcFtteFuDyAyhJ6AB6HfZUiVl0CyToRNnO63YuXnyiLSIm1sv57pYtyuqoIZHwCHGn36M04xjmVhCiygLQkCgAVhA3MA1vpRNsoHsDkcTmcyFBaPQejc7PwMj4pDJ5EpOPl7oRHo1mrg2qCOm8iejfqMARMvhAQWCrpClnJFMoURs0XyMfs2IdjqclFBmBAysoHg0gA)
**Edit**
I just noticed that it happens even when we are not using a dynamic object key...
```ts
type TExample = (
{
aaa: {
foo: number
}
}
| {
errorCode: string
}
)
const func: () => TExample = () => ... // get value from somewhere
const value = func()
if ('errorCode' in value && ((typeof value.errorCode) === 'number')) {
value // type is "{ errorCode: string }" ...... what!? I think that the expected is to be "never"
}
```
[_Playground_](https://www.typescriptlang.org/play/?ssl=1&ssc=1&pln=20&pc=1#code/C4TwDgpgBAKgogDwIYFswBtoF4oAoCwAUFFAN5EklLUBcZFljAZgPYt0B2ArigEYQAnBiQC+DMcSgAfepJKCBLAQGEWAEwh0AzsAEBLDgHNxRAJREiAYxYcdUJlw6W6uU1CwA+WIlQZseN088UihqJDoQ1nYoAEYoEXjzQisbOwA3JHQufwcnVwtCPSY8AHIFJVUNEqgDKAys6AAyRrxcUEgWYvrsgDpylXUIQKwcEu4+QRLTN3I5OszsqAB6Jah26D0tMih+ys0oHX0jeJ7Ts6gAdwALJGAAQgB+IgkiIA)
## Use Cases
I'm opening this issue because I had a problem because of this limitation.
I'm developing a client for an API and, for convention, all errors is returned as `{ errorCode: string }`.
And on an endpoint, the json can be a `{ [key in string]: TComplexObject }` on success case, or be a `{ errorCode: string }` on fail case.
So normally I'm checking if I had an error using `if ('errorCode' in result) {`, but on this endpoint it isn't enough since we have this limitation on TS. Then I don't have a good type inference on this case, needing to write a more complex code.
## Examples
```ts
type TExample = (
{
[key in string]: {
foo: number
}
}
| {
errorCode: string
}
)
const func: () => TExample = () => ({ blah: { foo: 1 } })
const value = func()
if ('errorCode' in value && typeof value.errorCode === 'string') {
value // should be { errorCode: string }
}
if ('errorCode' in value && typeof value.errorCode === 'object') {
value // should be { [key in string]: { foo: number } }
}
if ('errorCode' in value && typeof value.errorCode === 'number') {
value // should be never
}
```
|
Suggestion,Awaiting More Feedback
|
low
|
Critical
|
584,064,388 |
excalidraw
|
Link the text inside a shape to the shape
|
It can get a bit annoying when trying to move a block but it doesn't move the text inside it. Not a big issue, but I have forgotten to rubber-band (or command click) to move them together way too many times now :(
(I think there's a separate issue about linking arrows to shapes which is related)
|
enhancement
|
medium
|
Critical
|
584,065,664 |
TypeScript
|
for..of transform when targetting ES6< [Compiler option]
|
## Search Terms
for..of, downlevelIteration, transform, optimization, compiler option
## Suggestion
Option for transforming `for..of` when targetting ES6 and above.
## Background
Based on my investigation, `for..of` loops are slower than the traditional `for` loops (see the result: https://github.com/aminya/TypeScript-optimization)
It is pretty funny that when I target ES5, TypeScript converts `for..of` to the traditional loops, which makes the code faster, but I cannot do this when I target anything above ES6.
I noticed that there is `"downlevelIteration"` which does the opposite of what I want.
## Use Cases
It enhances the performance but allows to write readable code.
## Examples
```typescript
// for - of
let sum = 0
for (const a of arr) {
sum += a
}
// should be transformed to:
// Traditional
let sum = 0
for (let i = 0, l = arr.length; i < l; ++i) {
sum += arr[i]
}
// or
let sum = 0
for (let i = 0, l = arr.length; i < l; ++i) {
let a = arr[i]
sum += a
}
```
## Checklist
My suggestion meets these guidelines:
* [x] This wouldn't be a breaking change in existing TypeScript/JavaScript code
* [x] This wouldn't change the runtime behavior of existing JavaScript code
* [x] This could be implemented without emitting different JS based on the types of the expressions
* [x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
* [x] This feature would agree with the rest of [TypeScript's Design Goals](https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals).
|
Suggestion,Awaiting More Feedback
|
low
|
Major
|
584,069,616 |
flutter
|
[VoiceOver] Can not focus on TextField when inside sliver list that is scrolled.
|
Internal: b/151285964
<!-- Thank you for using Flutter!
If you are looking for support, please check out our documentation
or consider asking a question on Stack Overflow:
* https://flutter.dev/
* https://api.flutter.dev/
* https://stackoverflow.com/questions/tagged/flutter?sort=frequent
If you have found a bug or if our documentation doesn't have an answer
to what you're looking for, then fill our the template below. Please read
our guide to filing a bug first: https://flutter.dev/docs/resources/bug-reports
-->
When a text field is in the body of a sliver list, and you scroll the sliver list under a sliver app bar, the text field is no longer editable through iOS VoiceOver.
Seems similar to https://github.com/flutter/flutter/issues/45394.
## Steps to Reproduce
Using the following example app:
```dart
import 'package:flutter/material.dart';
void main() {
runApp(Demo());
}
class Demo extends StatelessWidget {
@override
Widget build(BuildContext context) {
return MaterialApp(
home: Scaffold(
body: CustomScrollView(
slivers: [
SliverAppBar(
pinned: true,
expandedHeight: 200,
flexibleSpace: Container(height: 100),
),
SliverList(
delegate: SliverChildListDelegate([
Container(
height: 400,
child: Center(child: TextField()),
),
Container(
height: 400,
child: Center(child: Text('empty box')),
),
]),
),
],
),
),
);
}
}
```
<!-- You must include full steps to reproduce so that we can reproduce the problem. -->
1. Run the above app on an iOS device.
1. Enable VoiceOver mode.
1. Scroll the app down so that the `SliverAppBar` is collapsed.
1. Attempt to edit the text field, notice that you can not focus on the text field, despite the VoiceOver saying "Text field, double tap to edit".
Also notice that if the app is _not_ scrolled, the `TextField` is editable even with VoiceOver enabled.
**Expected results:** <!-- what did you want to see? -->
Text field can be focused on and text can be entered.
**Actual results:** <!-- what did you see? -->
Text field can not be focused on or edited.
<details>
<summary>Flutter doctor output</summary>
<!--
Run your application with `flutter run --verbose` and attach all the
log output below between the lines with the backticks. If there is an
exception, please see if the error message includes enough information
to explain how to solve the issue.
-->
```
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel fix-defaultTextStyleAboveMaterialApp, v1.15.12-pre.4, on Mac OS X 10.14.6 18G3020, locale en-US)
[!] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
! Some Android licenses not accepted. To resolve this, run: flutter doctor --android-licenses
[!] Xcode - develop for iOS and macOS (Xcode 11.3)
! CocoaPods 1.7.5 out of date (1.8.0 is recommended).
CocoaPods is used to retrieve the iOS and macOS platform side's plugin code that responds to your plugin usage on the Dart side.
Without CocoaPods, plugins will not work on iOS or macOS.
For more info, see https://flutter.dev/platform-plugins
To upgrade:
sudo gem install cocoapods
[✓] Chrome - develop for the web
[✓] Android Studio (version 3.6)
[✓] Android Studio (version 3.5)
[✓] Connected device (5 available)
! Doctor found issues in 2 categories.
```
<!--
Run `flutter analyze` and attach any output of that command below.
If there are any analysis errors, try resolving them before filing this issue.
-->
```
```
|
a: text input,platform-ios,framework,engine,f: material design,a: accessibility,customer: money (g3),P2,team-ios,triaged-ios
|
low
|
Critical
|
584,082,162 |
TypeScript
|
Allow functions to have `new symbol` as the return type
|
## Search Terms
- unique symbol
- new unique symbol
- new symbol
## Suggestion
I request that `unique symbol` be allowed as the return type of a function declaration.
Alternatively, it might be better to use `new symbol` to disambiguate <https://github.com/microsoft/TypeScript/issues/40106#issuecomment-677741032>.
## Use Cases
Currently, it’s impossible to create an alias or a wrapper function for the global `Symbol` constructor and use that to construct unique symbols:
```js
// ./es-globals/fundamentals.js
export const ESSymbol = Symbol;
export const { for: ESSymbol_for } = ESSymbol;
```
```ts
// ./es-globals/fundamentals.d.ts
export import ESSymbol = globalThis.Symbol;
export declare const ESSymbol_for: typeof ESSymbol.for;
```
```js
// ./symbols.js
import { ESSymbol, ESSymbol_for } from "./es-globals/fundamentals.js";
// should be `unique symbol`, but is instead `symbol`:
export const customSymbol = ESSymbol("custom");
// should be `unique symbol` or `global symbol "nodejs.util.inspect.custom"`,
// but is instead `symbol`:
export const nodejs_util_inspect_custom = ESSymbol_for("nodejs.util.inspect.custom");
// should be `unique symbol` or `global symbol "nodejs.util.promisify.custom"`,
// but is instead `symbol`:
export const nodejs_util_promisify_custom = ESSymbol_for("nodejs.util.promisify.custom");
```
## Examples
This would allow defining `SymbolConstructor` as:
```ts
declare interface SymbolConstructor {
/**
* Returns a new unique Symbol value.
* @param description Description of the new symbol value.
*/
(description?: string | number): new symbol;
/**
* Returns a Symbol object from the global symbol registry matching the given key if found.
* Otherwise, returns a new symbol with this key.
* @param key key to search for.
*/
for<T extends string>(key: T): global symbol T;
// or, until GH-35909 is implemented:
for(key: string): new symbol;
}
```
## Checklist
My suggestion meets these guidelines:
* [x] This wouldn't be a breaking change in existing TypeScript/JavaScript code
* [x] This wouldn't change the runtime behavior of existing JavaScript code
* [x] This could be implemented without emitting different JS based on the types of the expressions
* [x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
* [x] This feature would agree with the rest of [TypeScript's Design Goals](https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals).
## See also
- <https://github.com/microsoft/TypeScript/issues/36468>
- <https://github.com/microsoft/TypeScript/issues/35909> (`global symbol "<name>"` proposal)
- <https://github.com/microsoft/TypeScript/pull/24738>
- <https://github.com/microsoft/TypeScript/issues/24506>
- <https://github.com/microsoft/TypeScript/issues/40106>
- <https://github.com/microsoft/TypeScript/pull/42543>
- <https://github.com/microsoft/TypeScript/issues/53282>
|
Suggestion,Awaiting More Feedback
|
medium
|
Critical
|
584,087,938 |
vscode
|
Report task execution result in onDidEndTask
|
The event `vscode.tasks.onDidEndTask` doesn't report the status of the task (i.e. succeeded or failed). It would be great if this can be added to be able to take actions based on that.
This will be particularly useful if the task has "dependent" tasks that might fail, in this case the event won't fire for the main task, so there has to be a way to know if any given task succeeded/failed in the chain.
|
feature-request,api,tasks,api-proposal
|
low
|
Critical
|
584,119,098 |
rust
|
Misleading error message for closure lifetime mismatch
|
Here's a fairly minimal reproduction of the code I was working with: ([Rust Playground](https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=86a9401a58692c0066ef248a8ceafe62))
```rust
type Input<'a> = &'a [u8];
fn bar<I, O, F>(f: F) -> impl Fn(I) -> O
where F: Fn(I) -> O,
{
f
}
// This version does not work:
fn foo<O, F>(f: F) -> impl Fn(Input) -> O
where F: Fn(Input) -> O
{
bar(f)
}
// This version works:
fn foo2<'a, O, F>(f: F) -> impl Fn(Input<'a>) -> O
where F: Fn(Input<'a>) -> O
{
bar(f)
}
```
The idea is that we want to define a function `foo` that takes a function and returns a new function by calling `bar`. The function `bar` also takes a function and returns a new function. In this minimal example, `bar` just returns `f`, but you can imagine that in a real application it would do something more interesting. This code resembles what you might see in a parser combinator library.
The error message you get with this code is as follows:
```rust
error[E0277]: expected a `std::ops::Fn<(&[u8],)>` closure, found `impl std::ops::Fn<(&[u8],)>`
--> src/lib.rs:10:23
|
10 | fn foo<O, F>(f: F) -> impl Fn(Input) -> O
| ^^^^^^^^^^^^^^^^^^^ expected an `Fn<(&[u8],)>` closure, found `impl std::ops::Fn<(&[u8],)>`
...
13 | bar(f)
| ------ this returned value is of type `impl std::ops::Fn<(&[u8],)>`
|
= help: the trait `for<'r> std::ops::Fn<(&'r [u8],)>` is not implemented for `impl std::ops::Fn<(&[u8],)>`
= note: the return type of a function must have a statically known size
error[E0271]: type mismatch resolving `for<'r> <impl std::ops::Fn<(&[u8],)> as std::ops::FnOnce<(&'r [u8],)>>::Output == O`
--> src/lib.rs:10:23
|
10 | fn foo<O, F>(f: F) -> impl Fn(Input) -> O
| ^^^^^^^^^^^^^^^^^^^ expected bound lifetime parameter, found concrete lifetime
|
= note: the return type of a function must have a statically known size
error: aborting due to 2 previous errors
```
There are a couple of misleading things about this message:
1. The expected and found text looks like it should be compatible, the error isn't clear from this part of the message:
```
expected an `Fn<(&[u8],)>` closure, found `impl std::ops::Fn<(&[u8],)>`
```
2. The following can lead you to add `for<'a>` to your trait bound, which will only take you further in the wrong direction (it happened to me today!)
```
the trait `for<'r> std::ops::Fn<(&'r [u8],)>` is not implemented for `impl std::ops::Fn<(&[u8],)>`
```
If you try adding `for<'a>` to the trait bound, you get some further error messages which are even less helpful :(
The problem is actually something not even shown in the error message: the lifetime of the reference in the argument type needs to be the same as the lifetime of the reference in the return type. If you do that (as in `foo2` above), the code compiles with no issues. Is there a reliable way for us to detect cases like this so we can improve the error message?
Thanks for all your work. :)
# Meta
`rustc --version --verbose`:
```
$ rustc --version --verbose
rustc 1.42.0 (b8cedc004 2020-03-09)
binary: rustc
commit-hash: b8cedc00407a4c56a3bda1ed605c6fc166655447
commit-date: 2020-03-09
host: x86_64-unknown-linux-gnu
release: 1.42.0
LLVM version: 9.0
```
|
A-diagnostics,A-closures,T-compiler,C-bug
|
low
|
Critical
|
584,204,166 |
go
|
os/signal: notify should filter out runtime-generated SIGURG
|
This program, when running under go 1.14, will show a huge number of `SIGURG` are received even though none should be (no network IO, no explicit kills).
https://play.golang.org/p/x7hFjPZnrg5
<pre>
package main
import (
"fmt"
"os"
"os/signal"
"syscall"
"time"
)
func main() {
ch := make(chan os.Signal, 1)
signal.Notify(ch, syscall.SIGURG)
for {
select {
case sig := <-ch:
fmt.Printf("received %v: %s\n", sig, time.Now())
default:
_ = new(int) // generate some GC activities
}
}
}
</pre>
https://go.googlesource.com/proposal/+/master/design/24543-non-cooperative-preemption.md changes to use SIGURG to preempt goroutines, which is fine, but I think `os/signal.Notify` should filter out those runtime generated SIGURGs.
The reason I found this is that I have a program that happens to use `SIGURG` as a custom signal like `SIGUSR1`, which works fine with previous Go releases. I understand that it should probably use `SIGUSR1`, but still I think `os/signal` should hide any signals generated by the runtime as it's irrelevant for the user and an implementation detail.
/cc @aclements thoughts?
|
NeedsInvestigation,compiler/runtime
|
medium
|
Major
|
584,211,766 |
rust
|
Incorrect explanation for error E0117
|
As of commit 1e5450d, the detailed explanation for error E0117 begins with:
```
The `Drop` trait was implemented on a non-struct type.
Erroneous code example:
impl Drop for u32 {}
```
The "The `Drop` trait was implemented on a non-struct type" sentence appears to be meant for E0120, but accidentally got included as part of the E0117 text.
I'm not sure how upstream wants to proceed here, but note that the example `impl Drop for u32 {}` _will_ [trigger](https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=edf3ea0cf084ba760ddb0fc8311080df) _both_ E0117 and E0120. So keeping this example- while changing the text- is probably fine.
I lost more time than I'd like to admit to misreading the docs here :P.
|
T-compiler,C-bug,A-error-codes
|
low
|
Critical
|
584,272,901 |
rust
|
Tracking Issue for Result::flatten (`result_flattening`)
|
This is a tracking issue for the `Result::flatten` API.
The feature gate for the issue is `#![feature(result_flattening)]`.
```rust
impl<T, E> Result<Result<T, E>, E> {
pub fn flatten(self) -> Result<T, E>;
}
```
### About tracking issues
Tracking issues are used to record the overall progress of implementation.
They are also uses as hubs connecting to other relevant issues, e.g., bugs or open design questions.
A tracking issue is however *not* meant for large scale discussion, questions, or bug reports about a feature.
Instead, open a dedicated issue for the specific matter and add the relevant feature gate label.
### Steps
- [x] Implement
- [ ] Adjust documentation ([see instructions on rustc-dev-guide][doc-guide])
- [ ] Stabilization PR ([see instructions on rustc-dev-guide][stabilization-guide])
[stabilization-guide]: https://rustc-dev-guide.rust-lang.org/stabilization_guide.html#stabilization-pr
[doc-guide]: https://rustc-dev-guide.rust-lang.org/stabilization_guide.html#documentation-prs
### Unresolved Questions
<!--
Include any open questions that need to be answered before the feature can be
stabilised.
-->
### Implementation history
* Implementation #70140
|
T-libs-api,B-unstable,C-tracking-issue,A-result-option,Libs-Tracked,Libs-Small
|
high
|
Critical
|
584,288,371 |
rust
|
Locals aligned to greater than page size can cause unsound behavior
|
Forked from https://github.com/rust-lang/rust/issues/70022
Minimal example
```Rust
#[repr(align(0x10000))]
struct Aligned(u8);
fn main() {
let x = Aligned(0);
println!("{:#x}", &x as *const _ as usize);
}
```
Aligning the stack is done *after* the stack probe. Because stacks grow downwards and aligning the stack shifts it downwards, it can cause the end of the stack to extend past the guard page and cause invalid access exceptions *or worse* when those sections of the stack are touched.
~~Only confirmed that this occurs on `pc-windows-msvc`~~ (pnkfelix edit: see comment thread, its a more general problem.)
<!-- TRIAGEBOT_START -->
<!-- TRIAGEBOT_ASSIGN_START -->
<!-- TRIAGEBOT_ASSIGN_DATA_START$${"user":"cuviper"}$$TRIAGEBOT_ASSIGN_DATA_END -->
<!-- TRIAGEBOT_ASSIGN_END -->
<!-- TRIAGEBOT_END -->
|
A-LLVM,O-windows,P-high,T-compiler,I-unsound,C-bug,ICEBreaker-LLVM,C-external-bug
|
medium
|
Major
|
584,293,347 |
rust
|
Statics aligned to greater than a page cause linker error
|
On Windows `link.exe` requires that the alignment of any section is less than or equal to the `/ALIGN` value. Statics with an alignment of 8192 or greater cause the section to have an alignment of 8192 (but not greater, see https://github.com/rust-lang/rust/issues/70022), but `link.exe` has a default `/ALIGN` of 4096 causing `fatal error LNK1164: section 0x6 alignment (8192) greater than /ALIGN value`. Specifying `-Clink-arg="/ALIGN:8192"` causes the error to go away.
Minimal example
```Rust
#[repr(align(0x100000))]
struct Aligned(u8);
static X: Aligned = Aligned(0);
fn main() {
println!("{:#x}", &X as *const _ as usize);
}
```
|
A-linkage,O-windows,T-compiler,C-bug,A-align
|
low
|
Critical
|
584,305,296 |
node
|
gcc warning in inspector protocol implementation
|
```
[1934/2890] CXX obj/gen/src/node/inspector/protocol/libnode.Protocol.o
gen/src/node/inspector/protocol/Protocol.cpp: In member function ‘virtual std::unique_ptr<node::inspector::protocol::Value> node::inspector::protocol::DictionaryValue::clone() const’:
gen/src/node/inspector/protocol/Protocol.cpp:698:21: warning: redundant move in return statement [-Wredundant-move]
698 | return std::move(result);
| ~~~~~~~~~^~~~~~~~
gen/src/node/inspector/protocol/Protocol.cpp:698:21: note: remove ‘std::move’ call
gen/src/node/inspector/protocol/Protocol.cpp: In member function ‘virtual std::unique_ptr<node::inspector::protocol::Value> node::inspector::protocol::ListValue::clone() const’:
gen/src/node/inspector/protocol/Protocol.cpp:739:21: warning: redundant move in return statement [-Wredundant-move]
739 | return std::move(result);
| ~~~~~~~~~^~~~~~~~
gen/src/node/inspector/protocol/Protocol.cpp:739:21: note: remove ‘std::move’ call
```
|
c++,v8 engine
|
low
|
Major
|
584,319,428 |
vscode
|
resolving multiple tasks with type npm and same script fails
|
Issue Type: <b>Bug</b>
Create 2 tasks with "type": "npm" and same "script"
Expected both tasks to be resolved by their label
- VsCode will list only one of those tasks when listing available tasks with "Tasks: Run Task".
- Depending tasks will fail with "Couldn't resolve dependent task 'x' in workspace folder 'y'" in the "Tasks" output.
**tasks.json:**
```json
{
"version": "2.0.0",
"tasks": [
{
"label": "start_both",
"type": "shell",
"dependsOn": [
"start_nr_1",
"start_nr_2"
],
"problemMatcher": []
},
{
"label": "start_nr_1",
"type": "npm",
"script": "start",
"problemMatcher": []
},
{
"label": "start_nr_2",
"type": "npm",
"script": "start",
"options": {
"env": {
"SOME": "option"
}
},
"problemMatcher": []
},
]
}
```
**package.json:**
```json
{
"scripts": {
"start": "echo running 'start' script"
}
}
```
VS Code version: Code 1.43.1 (fe22a9645b44368865c0ba92e2fb881ff1afce94, 2020-03-18T07:01:20.184Z)
OS version: Windows_NT x64 10.0.19041
<details>
<summary>System Info</summary>
|Item|Value|
|---|---|
|CPUs|Intel(R) Core(TM) i7-4790 CPU @ 3.60GHz (8 x 3592)|
|GPU Status|2d_canvas: enabled<br>flash_3d: enabled<br>flash_stage3d: enabled<br>flash_stage3d_baseline: enabled<br>gpu_compositing: enabled<br>multiple_raster_threads: enabled_on<br>oop_rasterization: disabled_off<br>protected_video_decode: unavailable_off<br>rasterization: enabled<br>skia_renderer: disabled_off_ok<br>video_decode: enabled<br>viz_display_compositor: enabled_on<br>viz_hit_test_surface_layer: disabled_off_ok<br>webgl: enabled<br>webgl2: enabled|
|Load (avg)|undefined|
|Memory (System)|15.92GB (8.47GB free)|
|Process Argv||
|Screen Reader|no|
|VM|0%|
</details>Extensions: none
<!-- generated by issue reporter -->
|
bug,tasks,polish
|
medium
|
Critical
|
584,372,370 |
vscode
|
[rename on type] strange behavior with auto indent in closing tag
|
Issue Type: <b>Bug</b>
Ref #88424
Set `"editor.autoIndent": "full"` (default) and `"editor.renameOnType": true`
Code for test
```html
<!DOCTYPE html>
<html lang="en">
<head>
<title>Document</title>
</head>
<body>
<span>
content
</span> <!-- is initial cursor position is between `span` and `>`-->
</body>
</html>
```
1. Set cursor to the end of `span` inside of closing tag
1. Use <kbd>Backspace</kbd> to remove `span`
Open and closed tags are `<>` and `</>` respectively
1. Start to typing `div`
1. After typing `d` open tag is still `<>`, closed tag is moved to the start of the line and has `</d>`
1. After typing `iv` it would be `<iv>` and `</div>`
Setting `"editor.autoIndent": "advanced"` doesn't have this problem.
Looks like wrong indent for closing tag might be related to #32871 but looks strange that `d` is lost in opening tag but other characters added after that.
/cc @octref
VS Code version: Code - Insiders 1.44.0-insider (c0eea2a712471a4d242d15704cfa968241d63280, 2020-03-19T09:27:54.357Z)
OS version: Windows_NT x64 10.0.18363
<details>
<summary>System Info</summary>
|Item|Value|
|---|---|
|CPUs|Intel(R) Core(TM) i7-8700 CPU @ 3.20GHz (12 x 3192)|
|GPU Status|2d_canvas: enabled<br>flash_3d: enabled<br>flash_stage3d: enabled<br>flash_stage3d_baseline: enabled<br>gpu_compositing: enabled<br>multiple_raster_threads: enabled_on<br>oop_rasterization: disabled_off<br>protected_video_decode: enabled<br>rasterization: enabled<br>skia_renderer: disabled_off_ok<br>video_decode: enabled<br>viz_display_compositor: enabled_on<br>viz_hit_test_surface_layer: disabled_off_ok<br>webgl: enabled<br>webgl2: enabled|
|Load (avg)|undefined|
|Memory (System)|31.72GB (18.08GB free)|
|Process Argv||
|Screen Reader|no|
|VM|0%|
</details>Extensions: none
<!-- generated by issue reporter -->
|
bug,editor-synced-region
|
low
|
Critical
|
584,377,995 |
node
|
rewrite bind function in prototype with console inside causes Maximum call stack size exceeded
|
Version: v12.4
Platform:Darwin Kernel Version 18.6.0
my issue code is quite simple:
```js
Function.prototype.bind = function () {
console.log(1)
}
const fn = function () {}
fn.bind()
```
it works well in chrome, I don't know if it'a a feature or bug in nodejs
thanks
|
console
|
low
|
Critical
|
584,433,123 |
material-ui
|
[styles][makeStyles] Uncaught TypeError: Cannot read property 'refs' of undefined in detach function
|
<!-- Provide a general summary of the issue in the Title above -->
When using makeStyles hook on the start-up page (e.g.: Login) of a React application, the page doesn't load sometimes in development mode and below error is encountered.
> VM677:176 Uncaught TypeError: Cannot read property 'refs' of undefined
at detach (eval at <anonymous> (VM17 bundle.js:4698), <anonymous>:176:5)
at eval (eval at <anonymous> (VM17 bundle.js:4698), <anonymous>:262:9)
at eval (eval at <anonymous> (VM17 bundle.js:4698), <anonymous>:218:9)
at HTMLUnknownElement.callCallback (eval at <anonymous> (VM17 bundle.js:1500), <anonymous>:188:14)
at Object.invokeGuardedCallbackDev (eval at <anonymous> (VM17 bundle.js:1500), <anonymous>:237:16)
at invokeGuardedCallback (eval at <anonymous> (VM17 bundle.js:1500), <anonymous>:292:31)
at safelyCallDestroy (eval at <anonymous> (VM17 bundle.js:1500), <anonymous>:19650:5)
at eval (eval at <anonymous> (VM17 bundle.js:1500), <anonymous>:20123:21)
at unstable_runWithPriority (eval at <anonymous> (VM17 bundle.js:1512), <anonymous>:653:12)
at runWithPriority$1 (eval at <anonymous> (VM17 bundle.js:1500), <anonymous>:11061:10)
at commitUnmount (eval at <anonymous> (VM17 bundle.js:1500), <anonymous>:20116:15)
at commitNestedUnmounts (eval at <anonymous> (VM17 bundle.js:1500), <anonymous>:20196:5)
at unmountHostComponents (eval at <anonymous> (VM17 bundle.js:1500), <anonymous>:20476:7)
at commitDeletion (eval at <anonymous> (VM17 bundle.js:1500), <anonymous>:20533:5)
at commitMutationEffects (eval at <anonymous> (VM17 bundle.js:1500), <anonymous>:22813:11)
at HTMLUnknownElement.callCallback (eval at <anonymous> (VM17 bundle.js:1500), <anonymous>:188:14)
at Object.invokeGuardedCallbackDev (eval at <anonymous> (VM17 bundle.js:1500), <anonymous>:237:16)
at invokeGuardedCallback (eval at <anonymous> (VM17 bundle.js:1500), <anonymous>:292:31)
at commitRootImpl (eval at <anonymous> (VM17 bundle.js:1500), <anonymous>:22540:9)
at unstable_runWithPriority (eval at <anonymous> (VM17 bundle.js:1512), <anonymous>:653:12)
at runWithPriority$1 (eval at <anonymous> (VM17 bundle.js:1500), <anonymous>:11061:10)
at commitRoot (eval at <anonymous> (VM17 bundle.js:1500), <anonymous>:22412:3)
From Chrome debugger, it seems that, in the makeStyles detach function, an undefined error is thrown for the sheetManager object (see image below).
After the error is thrown, the screen goes white.
<!--
Thank you very much for contributing to Material-UI by creating an issue! ❤️
To avoid duplicate issues we ask you to check off the following list.
-->
<!-- Checked checkbox should look like this: [x] -->
- [x] The issue is present in the latest release.
- [x] I have searched the [issues](https://github.com/mui-org/material-ui/issues) of this repository and believe that this is not a duplicate.
## Current Behavior 😯
<!-- Describe what happens instead of the expected behavior. -->
A Uncaught TypeError: Cannot read property 'refs' of undefined appears when the makeStyles detach function is called and sheetManager object in the following line is undefined. Also, the screen of the web application goes white.
`let sheetManager = multiKeyStore.get(stylesOptions.sheetsManager, stylesCreator, theme);`
## Expected Behavior 🤔
<!-- Describe what should happen. -->
sheetManager should not be undefined or a guard should be added to the subsequent code using it.
## Steps to Reproduce 🕹
<!--
Provide a link to a live example (you can use codesandbox.io) and an unambiguous set of steps to reproduce this bug.
Include code to reproduce, if relevant (which it most likely is).
You should use the official codesandbox template as a starting point: https://material-ui.com/r/issue-template
If you have an issue concerning TypeScript please start from this TypeScript playground: https://material-ui.com/r/ts-issue-template
Issues without some form of live example have a longer response time.
-->
I have not found an exact cause for this, sheetManager is set in attach function, but seems to not be found in a subsequent call to detach. Maybe a missing attach call or refs going to 0. A line below removes the sheetManager from the multiKeyStore.
`multiKeyStore.delete(stylesOptions.sheetsManager, stylesCreator, theme);`
<!--
Steps:
1.
2.
3.
4.
-->
## Context 🔦
I am getting a console error when this happens and the application screen is not loading. On subsequent tab loads, the app reloads.
<!--
What are you trying to accomplish? How has this issue affected you?
Providing context helps us come up with a solution that is most useful in the real world.
-->
## Your Environment 🌎
<!--
Include as many relevant details about the environment with which you experienced the bug.
If you encounter issues with typescript please include version and tsconfig.
-->
| Tech | Version |
| ----------- | ------- |
| Material-UI | v4.9.7 |
| React | 16.13.0 |
| Browser | Google Chrome |
| TypeScript | No |
| Babel ES6 | Yes |
|
package: styles
|
medium
|
Critical
|
584,460,717 |
godot
|
Spatial 'look_at' strange behaviour
|
**Godot version: 3.2.1**
**OS/device including version: Windows 10**
**Issue description: See example project**
**Steps to reproduce: See example project**
**Minimal reproduction project: https://github.com/Albatros53113/Turn-Zylinder/tree/master**
The issue is best described by looking at the example project 'readme'. Sorry if this is not an issue and I missunderstood some concepts, but seems like 'look_at' changes the axis it looks with.
|
topic:core
|
low
|
Minor
|
584,483,658 |
pytorch
|
How install old version pytorch 1.2.0 from source?
|
Hi,I'm installing pytorch1.2.0 from source(anaconda,python3.7,ubuntu18.04,cuda9.2).
my commands:
```
conda install numpy ninja pyyaml mkl mkl-include setuptools cmake cffi typing
conda install -c pytorch magma-cuda92
git clone --recursive https://github.com/pytorch/pytorch
git clone --branch v1.2.0 https://github.com/pytorch/pytorch.git pytorch-1.2.0
cd pytorch-1.2.0
git submodule sync
git submodule update --init --recursive
export CMAKE_PREFIX_PATH=${CONDA_PREFIX:-"$(dirname $(which conda))/../"}
python setup.py install
```
and then I got an error:
```
Building wheel torch-1.2.0a0+54a63e0
-- Building version 1.2.0a0+54a63e0
cmake --build . --target install --config Release -- -j 16
[2/3113] Performing build step for 'nccl_external'
FAILED: nccl_external-prefix/src/nccl_external-stamp/nccl_external-build nccl/lib/libnccl_static.a
cd /home/luqian/work/pytorch-1.2.0/third_party/nccl/nccl && env CCACHE_DISABLE=1 SCCACHE_DISABLE=1 make CXX=/usr/bin/c++ CUDA_HOME=/usr/local/cuda NVCC=/usr/local/cuda/bin/nvcc NVCC_GENCODE=-gencode=arch=compute_75,code=sm_75 BUILDDIR=/home/luqian/work/pytorch-1.2.0/build/nccl VERBOSE=0 -j && /home/luqian/anaconda3/bin/cmake -E touch /home/luqian/work/pytorch-1.2.0/build/nccl_external-prefix/src/nccl_external-stamp/nccl_external-build
make -C src build BUILDDIR=/home/luqian/work/pytorch-1.2.0/build/nccl
make[1]: 进入目录“/home/luqian/work/pytorch-1.2.0/third_party/nccl/nccl/src”
make[2]: 进入目录“/home/luqian/work/pytorch-1.2.0/third_party/nccl/nccl/src/collectives/device”
nvcc fatal : Unsupported gpu architecture 'compute_75'
nvcc fatal : Unsupported gpu architecture 'compute_75'
Makefile:52: recipe for target '/home/luqian/work/pytorch-1.2.0/build/nccl/obj/collectives/device/all_reduce.dep' failed
make[2]: *** [/home/luqian/work/pytorch-1.2.0/build/nccl/obj/collectives/device/all_reduce.dep] Error 1
make[2]: *** 正在等待未完成的任务....
nvcc fatal : Unsupported gpu architecture 'compute_75'
Makefile:52: recipe for target '/home/luqian/work/pytorch-1.2.0/build/nccl/obj/collectives/device/all_gather.dep' failed
make[2]: *** [/home/luqian/work/pytorch-1.2.0/build/nccl/obj/collectives/device/all_gather.dep] Error 1
nvcc fatal : Unsupported gpu architecture 'compute_75'
Makefile:52: recipe for target '/home/luqian/work/pytorch-1.2.0/build/nccl/obj/collectives/device/reduce.dep' failed
make[2]: *** [/home/luqian/work/pytorch-1.2.0/build/nccl/obj/collectives/device/reduce.dep] Error 1
nvcc fatal : Unsupported gpu architecture 'compute_75'
Makefile:52: recipe for target '/home/luqian/work/pytorch-1.2.0/build/nccl/obj/collectives/device/reduce_scatter.dep' failed
make[2]: *** [/home/luqian/work/pytorch-1.2.0/build/nccl/obj/collectives/device/reduce_scatter.dep] Error 1
Makefile:52: recipe for target '/home/luqian/work/pytorch-1.2.0/build/nccl/obj/collectives/device/broadcast.dep' failed
make[2]: *** [/home/luqian/work/pytorch-1.2.0/build/nccl/obj/collectives/device/broadcast.dep] Error 1
nvcc fatal : Unsupported gpu architecture 'compute_75'
Makefile:52: recipe for target '/home/luqian/work/pytorch-1.2.0/build/nccl/obj/collectives/device/functions.dep' failed
make[2]: *** [/home/luqian/work/pytorch-1.2.0/build/nccl/obj/collectives/device/functions.dep] Error 1
make[2]: 离开目录“/home/luqian/work/pytorch-1.2.0/third_party/nccl/nccl/src/collectives/device”
Makefile:49: recipe for target '/home/luqian/work/pytorch-1.2.0/build/nccl/obj/collectives/device/colldevice.a' failed
make[1]: *** [/home/luqian/work/pytorch-1.2.0/build/nccl/obj/collectives/device/colldevice.a] Error 2
make[1]: 离开目录“/home/luqian/work/pytorch-1.2.0/third_party/nccl/nccl/src”
Makefile:25: recipe for target 'src.build' failed
make: *** [src.build] Error 2
[17/3113] Building CXX object third_party/protobuf/cmake/CMake...dir/__/src/google/protobuf/compiler/csharp/csharp_message.cc.o
ninja: build stopped: subcommand failed.
Traceback (most recent call last):
File "setup.py", line 756, in <module>
build_deps()
File "setup.py", line 325, in build_deps
cmake=cmake)
File "/home/luqian/work/pytorch-1.2.0/tools/build_pytorch_libs.py", line 64, in build_caffe2
cmake.build(my_env)
File "/home/luqian/work/pytorch-1.2.0/tools/setup_helpers/cmake.py", line 321, in build
self.run(build_args, my_env)
File "/home/luqian/work/pytorch-1.2.0/tools/setup_helpers/cmake.py", line 133, in run
check_call(command, cwd=self.build_dir, env=env)
File "/home/luqian/anaconda3/lib/python3.7/subprocess.py", line 363, in check_call
raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['cmake', '--build', '.', '--target', 'install', '--config', 'Release', '--', '-j', '16']' returned non-zero exit status 1.
```
How can I solve this problem?
|
module: build,triaged
|
low
|
Critical
|
584,511,566 |
vscode
|
Minor UI inconsistencies: Input theme references
|
I expected that the overall search input in the UI preferences view is styleable via `settings.textInputBackground` and `settings.textInputForeground`. But currently it is styled via `input.background` and `input.foreground` only.
Please take a look at the attached screenshot. And you may want to use this setting snippet for further debugging.
<img width="1280" alt="vscode-input-theme-references" src="https://user-images.githubusercontent.com/3532570/76908802-e640f580-68a9-11ea-9c7e-c2644cf3dc85.png">
```
"workbench.colorCustomizations": {
"input.background": "#0000ff",
"input.border": "#ffff00",
"input.foreground": "#ffffff",
"settings.textInputBackground": "#00ff00",
"settings.textInputForeground": "#000000",
"settings.textInputBorder": "#ff0000",
},
```
|
ux,settings-editor,under-discussion
|
low
|
Critical
|
584,535,616 |
pytorch
|
Rename Dispatcher::findSchema to Dispatcher::findOperator
|
https://github.com/pytorch/pytorch/pull/34456#discussion_r393886732
|
triaged,module: dispatch
|
low
|
Minor
|
584,542,520 |
pytorch
|
Deprecate and remove RegisterOperators
|
Once the new operator registration api lands, it will be profitable to remove the old API so we can tighten up internal invariants related to how many times a def can happen. Deprecation strategy:
1. Migrate all uses we have direct control over to the new API
2. Make it invalid to mix new-style with old-style registration, but preserve multiple defs for old api. This will break anyone who overrides PyTorch methods, but will not break anyone who defines new ops with the old api
3. Make it invalid to use default alias analysis kind in default api. I don't think this will break anyone. If they are broken they can just migrate to new API.
4. Delete the old API entirely, at which point def can only happen once.
I don't know how long it will take to get to the last step though.
|
triaged,module: dispatch
|
low
|
Critical
|
584,544,878 |
pytorch
|
Make operator registrations truly commutative using priority
|
Static initializers may run in arbitrary order; we must design static initialization so that no matter what order they run you get the same result. This is not currently true for cases where you override a kernel with another (currently done to support Jupyter notebooks). Let's make this case commutative too, by associating registrations with priority, and then always taking higher priority. Reloads of kernels increment a "Jupyter" priority which makes overrides in this case chronological.
Priority is an "enum", but with a reserved space of sequential identifiers for chronological Jupyter identifiers.
|
triaged,module: dispatch
|
low
|
Minor
|
584,563,489 |
flutter
|
[pigeon] Codegen can accidentally use reserved keywords
|
When upgrading video_player to pigeon I ran into 2 different issues where codegen was using symbols which had reserved semantics in the target language:
- A message called "init" - when codegening for the message in objc "init:error:" was generated which has special rules in objc (it should return instancetype, which it wasn't)
- A field called "package" - the java parser is dumb and will get tripped up if you have a field that is named package, reserving that word for top level statements.
We can try to build these rules into the pigeon parser as we find them.
cc @xster
|
package,team-ecosystem,p: pigeon,P2,triaged-ecosystem
|
low
|
Critical
|
584,582,985 |
vscode
|
Replace in search Editor
|
Having a replace field in the search editor would permit to quickly replace all occurence without having to manage each occurence.
Bonus point for displaying difference like in search panel
|
feature-request,search-editor
|
high
|
Critical
|
584,605,666 |
kubernetes
|
Remove prometheus dependencies from k/k codebase
|
As part of Metrics Stability KEP we migrated from Prometheus client to Kubernetes Metrics Framework. So we no longer need to depend on promethues client directly.
I configured Bazel to forbid importing prometheus directly. https://github.com/kubernetes/kubernetes/blob/master/hack/verify-prometheus-imports.sh (EDITED)
Example PR that removes reference https://github.com/kubernetes/kubernetes/pull/85289
There are still couple of directories that need to be cleaned up:
* [x] `cluster/images/etcd-version-monitor` (@zhouya0, https://github.com/kubernetes/kubernetes/pull/89413)
* [x] `pkg/master` (@zhouya0)
* [x] `pkg/scheduler/` (@gavinfish, https://github.com/kubernetes/kubernetes/pull/98338)
* [ ] `pkg/volume` (@gavinfish, https://github.com/kubernetes/kubernetes/pull/98729)
* [x] `staging/src/k8s.io/apiserver/pkg/admission/metrics` (@tanjunchen, https://github.com/kubernetes/kubernetes/pull/89285)
* [x] `staging/src/k8s.io/apiserver/pkg/util/flowcontrol/metrics` (@tanjunchen)
* [ ] `test/e2e_node` (@gavinfish)
/sig instrumentation
/kind cleanup
/cc @logicalhan
Please volunteer if your interested in working on certain directory.
/help
|
kind/cleanup,kind/feature,sig/instrumentation,lifecycle/frozen
|
medium
|
Critical
|
584,681,472 |
vscode
|
Snap: Register code as an editor in Debian with update-alternatives
|
Issue Type: <b>Bug</b>
This is a bug report regarding a feature that was implemented here: https://github.com/microsoft/vscode/issues/3541
1) Install Ubuntu 18.04 LTS
2) Open Snap Store aka "Ubuntu Software"
3) Search for VSCode
4) Click on VSCode
5) Click install
6) Wait for install to complete
7) Open terminal
8) run "update-alternatives --config editor"
Expected: VSCode appears as an option. See https://github.com/microsoft/vscode/issues/3541
Actual: VSCode does not appear as an option
VS Code version: Code 1.43.1 (fe22a9645b44368865c0ba92e2fb881ff1afce94, 2020-03-18T07:17:38.324Z)
OS version: Linux x64 5.3.0-42-generic snap
<details>
<summary>System Info</summary>
|Item|Value|
|---|---|
|CPUs|Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz (8 x 3829)|
|GPU Status|2d_canvas: unavailable_software<br>flash_3d: disabled_software<br>flash_stage3d: disabled_software<br>flash_stage3d_baseline: disabled_software<br>gpu_compositing: disabled_software<br>multiple_raster_threads: enabled_on<br>oop_rasterization: disabled_off<br>protected_video_decode: disabled_off<br>rasterization: disabled_software<br>skia_renderer: disabled_off_ok<br>video_decode: disabled_software<br>viz_display_compositor: enabled_on<br>viz_hit_test_surface_layer: disabled_off_ok<br>webgl: unavailable_software<br>webgl2: unavailable_software|
|Load (avg)|1, 0, 0|
|Memory (System)|31.27GB (24.04GB free)|
|Process Argv|. --no-sandbox|
|Screen Reader|no|
|VM|0%|
</details>Extensions: none
<!-- generated by issue reporter -->
|
help wanted,feature-request,install-update,linux,snap
|
low
|
Critical
|
584,691,629 |
PowerToys
|
Browser Picker
|
# Browser picker so you can have rule-based default browsers
This is something I've wanted to write, but just haven't had time to do so. I originally considered this a store app, but I think PowerToys is a much better fit because this is more of a power user thing.
Many of us use multiple browsers so we can keep cookies separate. Most apps, however, want to launch just the default browser. In apps that support it, right now, I have to right-click and copy the URL and then paste it into the browser I want to use. That's clumsy.
Instead, it would be great to be able to set up rules for which browser to open. For example:
- Links from app <X> (example: Outlook, or VS Code, or Terminal) always open in browser <Y>
- Links to domain <Z> (example: outlook.com, or localhost) always open in browser <Y>
- Links from app <X> or domain <Z> always prompt for the browser
- Would include protocol handling in there as well
- And you can set a fall-though, which becomes your new effective default browser for when no rules apply. That default may be to prompt.
The browser would be an actual browser on the system, and also options like inprivate/incognito as appropriate.
<!--
A clear and concise description of what the problem is that the new feature would solve.
Describe why and how a user would use this new functionality (if applicable).
-->
# Proposed technical implementation details
The Browser Picker would be registered as the default browser. It would apply the rules and, if there's a match, open the browser selected. No UI needed in this case.
There would also need to be either a config UI, and/or a well-understood JSON file with the rules.
If no match, the default could be to use a specific browser, or to prompt.
|
Idea-New PowerToy
|
medium
|
Critical
|
584,733,074 |
godot
|
Toggling the `sequenced` property of `VisualScriptFunction` doesn't redraw/refesh call nodes
|
**Godot version:** v3.2.1.stable.official
**OS/device including version:** N/A
**Issue description:**
The `sequenced` property of `VisualScriptFunction` is (AFAICT) *supposed* to enable a function to act as a getter, however:
1. The functionality is undocumented (see: https://github.com/godotengine/godot-docs/issues/3287).
2. There is an apparent bug which makes the functionality--at a minimum--undiscoverable and potentially broken.
**Steps to reproduce:**
Here is an example of how the `sequenced` property is intended to be used:
Configuration:
* `functionA` has `Sequenced` set to `true` i.e. "On"/checked/ticked.
* `functionB` has `Sequenced` set to `false` i.e. "Off"/not-checked/not-ticked
In the above image, note the following:
* The call node for `functionB()` has no white triangle sequence ports, only an output data port.
* The call node for `functionA()` *does* have sequence ports in addition to the output data port.
Also, with this configuration, if the call to `functionA()` is not connected as part of a sequence then an error is generated by the `Add` node:
> Add: Invalid arguments A: Nil B int
**Minimal reproduction project:**
The below image shows an example of what happens if `sequenced` is toggled on `functionA` and another call node is created by dragging the function name from the "Functions" list onto the graph:
Note:
* The two `functionA()` function call nodes have different appearances (the lower `functionA()` node was created after "Sequenced" was unchecked.
There is more detail in the documentation-related issue linked above. (Including discussion about whether there's an underlying feature design/exposure issue to consider and uncertainty about potential caching/consts issues.)
### Potential solutions
My impression is that a bug fix would need to cover two parts:
1. Visual refresh of existing displayed function call nodes.
2. Handling of connections/disconnections of existing function call nodes when the referenced function's `sequenced` property is set to false--including potentially warning about unintended changes.
### Related links
* Commit where functionality was added: https://github.com/godotengine/godot/commit/8a4bce6ebd843f9a8f482f74601f4933aae737a3
* Issue marked as "Fixed" by above commit: "[It's impossible to create custom function without sequence port in VS #6346 ](https://github.com/godotengine/godot/issues/6346)"
* Semi-related issue: https://github.com/godotengine/godot/pull/9758
* Documentation of [`ports_changed_notify`](https://github.com/godotengine/godot/blob/0edcb8ed58be8bf6a5145ceaae5ff96778afb2a2/modules/visual_script/doc_classes/VisualScriptNode.xml#L32) which seems like it might used to modify/update display of node after `sequenced` property is toggled.
* The [Reddit /r/godot question about the `Sequenced` property of `VisualScriptFunction`](https://old.reddit.com/r/godot/comments/fla7gm/hello_im_currently_learning_how_to_use_visual/) that started me down this path. :)
|
bug,topic:visualscript
|
low
|
Critical
|
584,746,916 |
pytorch
|
Options for printing the shape with print(tensor)
|
It has been a fairly frequent feature request to print the shape of a tensor when printing the tensor in Python with `print(tensor)` (and it was controversial when we stopped printing the shape awhile ago).
We've been somewhat reluctant to do this because:
1) it doesn't match NumPy
2) it's not usable in the repr
2) the cost is asymmetric. I.e. printing is worse than not printing because you can't unprint. This can matter in cases like printing a list of 0-dimensional tensors where printing the shape would blow up the total print size.
But, giving users control has advantages.
So, I propose the following:
1) Implement a `shape=` parameter that does "shape checking except when the shape is not expressible".
For the majority of cases, this would just be verifying that the size matches the size of the passed-in data, e.g.:
```
>>> torch.tensor([1, 2, 3, 4, 5], shape=(5,))
tensor([1, 2, 3, 4, 5])
>>> torch.tensor([1, 2, 3, 4, 5], shape=(2, 3))
RuntimeError: BAD SHAPE
```
Note, there is one exception to shape printing which already exists, which is that we print the shape of the tensor when it's not expressible via the `torch.tensor` constructor:
```
>>> torch.randn(0,2,3)
tensor([], size=(0, 2, 3))
```
First, we should change this to `shape` to be consistent with NumPy. But we should also just make this expressible by supporting shape specification when the shape isn't expressible via the data.
2) Start printing when the data is summarized
In this case, you can't copy the string to the repr anyway
3) Add options to the print options to print the shape (https://github.com/pytorch/pytorch/blob/master/torch/_tensor_str.py)
I'd propose starting with 2 options: 'always', 'default'.
Always always prints.
Default only prints when the string is ambiguous or summarized
|
module: printing,triaged
|
low
|
Critical
|
584,756,191 |
vscode
|
Please make it possible to add gutter (margin) before the text area
|
Please consider making an option to add gutter before the text area to improve usability.
Currently it is problematic to use the mouse to place the caret in the beginning
of the line because there is no gutter to trap the mouse selection cursor:
On the screenshot below I try to place the cursor before the dot, and need to be
pixel-precise to make so.
Also I find it annoying when something "sticks" to the text/code, whether
it is folding icons or line numbers (if folding is off) so I personally always want some
extra margin to the left to improve readability.
The setting could be named something like:
"editor.leftMargin": 5,
The number would indicate the margin width in characters, I suppose.
In addition, an option to control how the mouse click behaves in this area should be added,
I suggest "line selection" mode or "standard selection" mode.
For "standard selection" a placeholder cursor would be shown just like in text.
For "line selection" pointer cursor would be shown, like by clicking on the line number area.
|
feature-request,editor-rendering
|
low
|
Major
|
584,758,139 |
flutter
|
run web drivers from dev directory
|
Running web drivers from lib directory is creating a warning in the logs.
Change it to run from dev. Steps:
1) Copy the file to the dev directory
2) Change plugins repo to use it from dev
3) Change flutter repo to use it from dev
4) Change engine repo to use it from dev
5) remove the unused file from lib
|
a: tests,framework,platform-web,P3,team-web,triaged-web
|
low
|
Minor
|
584,764,625 |
pytorch
|
[JIT] If a python function type comment is referring to a wrong type, JIT frontend gives a not helpful error message
|
```
dst_worker_name = worker_name((self.rank + 1) % self.world_size)
input_0 = torch.ones(2, 2)
input_1 = 1
expected_res = torch.add(input_0, input_1)
@torch.jit.ignore
def python_return_future():
# type: () -> Future[Tensor]
fut = rpc.rpc_async(dst_worker_name, torch.add, (input_0, input_1), {})
return fut
@torch.jit.script
def script_use_future():
# type: () -> Tensor
fut = python_return_future()
return fut.wait()
res = script_use_future()
self.assertEqual(res, expected_res)
```
The error message is
```
/data/users/shihaoxu/fbsource/fbcode/buck-out/dev/gen/caffe2/test/distributed/rpc/jit/rpc_fork#binary,link-tree/torch/testing/_internal/common_distributed.py:181: Caught exception:
Traceback (most recent call last):
File "/data/users/shihaoxu/fbsource/fbcode/buck-out/dev/gen/caffe2/test/distributed/rpc/jit/rpc_fork#binary,link-tree/torch/testing/_internal/common_distributed.py", line 178, in wrapper
fn(self)
File "/data/users/shihaoxu/fbsource/fbcode/buck-out/dev/gen/caffe2/test/distributed/rpc/jit/rpc_fork#binary,link-tree/torch/testing/_internal/dist_utils.py", line 69, in new_test_method
return_value = old_test_method(self, *arg, **kwargs)
File "/data/users/shihaoxu/fbsource/fbcode/buck-out/dev/gen/caffe2/test/distributed/rpc/jit/rpc_fork#binary,link-tree/torch/testing/_internal/distributed/rpc/jit/rpc_test.py", line 35, in test_script_call_python_return_future
@torch.jit.script
File "/data/users/shihaoxu/fbsource/fbcode/buck-out/dev/gen/caffe2/test/distributed/rpc/jit/rpc_fork#binary,link-tree/torch/jit/__init__.py", line 1296, in script
fn = torch._C._jit_script_compile(qualified_name, ast, _rcb, get_default_args(obj))
File "/data/users/shihaoxu/fbsource/fbcode/buck-out/dev/gen/caffe2/test/distributed/rpc/jit/rpc_fork#binary,link-tree/torch/jit/annotations.py", line 80, in get_signature
signature = parse_type_line(type_line, rcb, loc)
File "/data/users/shihaoxu/fbsource/fbcode/buck-out/dev/gen/caffe2/test/distributed/rpc/jit/rpc_fork#binary,link-tree/torch/jit/annotations.py", line 163, in parse_type_line
ret_ann = eval(ret_ann_str, {}, EvalEnv(rcb)) # noqa: P204
File "<string>", line 1, in <module>
TypeError: 'NoneType' object is not subscriptable
exiting process with exit code: 10
```
Expected error
```
RuntimeError: Failed to parse the return type of a type annotation: name 'Future' is not defined
```
This can be fixed by change
```
class closure_lookup(object):
# This is a class since `closure` is a dict and it's easier in
# `env_helper` if everything just works with `getattr` calls
def __getattr__(self, key):
if key in closure:
return closure[key]
elif hasattr(builtins, key):
return getattr(builtins, key)
raise KeyError(key) # This line is changed.
```
in "torch/_jit_internal.py".
But this fails other tests, I am suspecting other callsites didn't consider handling error, maybe they use None comparison?
cc @suo
|
oncall: jit,triaged
|
low
|
Critical
|
584,769,714 |
youtube-dl
|
Square thumbnails
|
## Checklist
- [X] I'm reporting a feature request
- [X] I've verified that I'm running youtube-dl version **2020.03.08**
- [X] I've searched the bugtracker for similar feature requests including closed ones
## Description
Feature to crop thumbnail to a sqaure format (1:1 aspect ratio).
e.g.: --embed-thumbnail RATIO
|
request
|
low
|
Critical
|
584,769,862 |
PowerToys
|
Fast Delete
|
# Summary of the new feature/enhancement
<!--
A clear and concise description of what the problem is that the new feature would solve.
Describe why and how a user would use this new functionality (if applicable).
-->
If you want to delete a lot of files (large number of files, not large files) thru File Explorer, right now it is a very slow process, compared to doing the same thru the command line.
# Proposed technical implementation details (optional)
I would like to have a power option that enabled me to fast delete a selection of files from Explorer. Pretty much what this provides:
https://www.ghacks.net/2017/07/18/how-to-delete-large-folders-in-windows-super-fast/
Which is pretty much this:
`DEL /F/Q/S *.* > NUL`
That would be much better than typing the command!
|
Idea-New PowerToy,Product-File Explorer,Product-File Actions Menu
|
medium
|
Major
|
584,775,073 |
pytorch
|
Generator C++ API should match Python API
|
I tried to do it in #34968 but that PR added c-tor Generator(Device device) to C++ API to match Python API, to avoid code duplication the logic was moved from THPGenerator_pynew to corresponding at::Generator c-tor. Unfortunately it made Generator.h dependent on CPUGenerator.h and CUDAGenerator.h, but this is how our Python API works :(
cc @yf225
|
module: cpp,triaged,module: random
|
low
|
Minor
|
584,793,979 |
node
|
Tracking Issue: enable sanitizers on our CI
|
### What are sanitizers?
[Sanitizers](https://github.com/google/sanitizers) are build options which can be used to identify programming errors in C++. They add overhead to the program, which is why it's not recommended to use in releases, but they can be valuable to find memory leaks and other potential crashes on our tests. V8 has [ASAN buildbots](https://ci.chromium.org/p/v8/builders/try/v8_linux64_asan_rel_ng/b8886122785772680448?) which run on every CL, and they are [working on making their code base UBSan compatible](https://bugs.chromium.org/p/v8/issues/detail?id=3770&q=ubsan&can=2) as well.
### Cool, what do we need to make it happen?
Well, first thing, asan has to work on Node.js. We have `--enable-asan` on `configure` today, and the build will work on most computers (it requires a considerable amount of memory). But most of our tests will fail with it, because our code base is not ASAN clean. We might be also missing some ASAN flags: looking at V8 source code and build dependencies, they do one thing or two different.
There's also the memory issue: as of right now, we need a big machine to build with ASAN. GitHub Actions can't run an ASAN build because it "only" has 7Gb. Hopefully there's something we can tune in the build to use less memory. Otherwise, we'll need a custom machine for it (probably on Jenkins).
As for other sanitizers (like UBSan), upstream projects need to support those first, so we are blocked for now.
#### To Do List (ASAN)
- [ ] Investigate huge memory consumption during build
- [ ] Move gengjiawen/node-build to `nodejs/` org
- [ ] Move repository
- [ ] Move Docker build to Node.js Docker hub
- [ ] Enable build on our CI (no tests)
- This will ensure we don't break the build moving forward
- [ ] Fix failing tests
- [ ] Once everything is working, enable tests on our CI
- [ ] Fix ASAN flags for OS X
- [ ] Fix ASASN flags for Windows
#### To Do List (UBSan)
- [ ] Wait for V8 to be UBSan compatible ([v8:3770](https://bugs.chromium.org/p/v8/issues/detail?id=3770&q=ubsan&can=2))
- [ ] Enable build on our CI (no tests)
- This will ensure we don't break the build moving forward
- [ ] Fix failing tests
- [ ] Once everything is working, enable tests on our CI
We can list current failing tests here once we get rid of the most noisy ones.
|
meta,memory
|
medium
|
Critical
|
584,797,105 |
flutter
|
Navigator docs are incomplete
|
The `Navigator` docs say `A widget that manages a set of child widgets with a stack discipline.`, so this induces us to believe the `Navigator` will add some sort of hierarchy to the pushed Routes, but anyone that tried to get an `InheritedWidget` from inside a new Route will get an error (unless the `InheritedWidget` is on top of the `MaterialApp`).
As [this article](https://medium.com/@mehmetf_71205/inheriting-widgets-b7ac56dbbeb1) shows, one could expect our app to look like this:
```
> School App [App Context]
> Student [Student Context]
> Grades
> Bio
> Teacher [Teacher Context]
> Courses
> Bio
```
But Navigator will actually make it look like this:
```
> School App [App Context]
> Student [Student Context]
> Student Grades
> Student Bio
> Teacher [Teacher Context]
> Teacher Courses
> Teacher Bio
```
This behavior is misleading and induces errors (I spent 2 hours trying to understand why my `Provider` wasn't working once I navigated further), so it should be added to the docs.
|
framework,d: api docs,f: routes,P2,team-framework,triaged-framework
|
low
|
Critical
|
584,818,607 |
TypeScript
|
[feature] class properties that are "readonly in public, writable in private" or other permutations
|
<!-- 🚨 STOP 🚨 𝗦𝗧𝗢𝗣 🚨 𝑺𝑻𝑶𝑷 🚨
Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker.
Please help us by doing the following steps before logging an issue:
* Search: https://github.com/Microsoft/TypeScript/search?type=Issues
* Read the FAQ, especially the "Common Feature Requests" section: https://github.com/Microsoft/TypeScript/wiki/FAQ
-->
## Search Terms
[typescript readonly on the outside writable on the inside](https://www.google.com/search?q=typescript%20readonly%20on%20the%20outside%20writable%20on%20the%20inside&cad=h)
- https://stackoverflow.com/questions/46634876/how-can-i-change-a-readonly-property-in-typescript
## Suggestion
Some sort of syntax to describe `readonly on the outside, writeable on the inside` for a given property, so we can avoid making a getter just for this purpose (or using any of the convoluted options linked in that StackOverflow post).
## Use Cases
To make this pattern easier to express.
## Examples
instead of having to write
```ts
class Foo {
private _foo = 123
get foo() {
return this._foo
}
changeIt() {
this._foo = 456
}
}
const f = new Foo
f.foo = 345 // ERROR
```
we would be able to write something shorter like
```ts
class Foo {
publicread foo = 123
changeIt() {
this.foo = 456
}
}
const f = new Foo
f.foo = 345 // ERROR
```
## Checklist
My suggestion meets these guidelines:
* [x] This wouldn't be a breaking change in existing TypeScript/JavaScript code
* [x] This wouldn't change the runtime behavior of existing JavaScript code
* [x] This could be implemented without emitting different JS based on the types of the expressions
* [x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
* [x] This feature would agree with the rest of [TypeScript's Design Goals](https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals).
|
Suggestion,Awaiting More Feedback
|
high
|
Critical
|
584,818,704 |
godot
|
Right-button menu for Scene-file nodes has a bigger offset than normal
|
**Godot version:** 3.2.1 (stable)
**OS/device including version:** ArchLinux
**Issue description:** When clicking with the right-button on a node added to the scene via a Scene file, the inspector menu that appears will have a weird offset (as shown in the images). This is probably caused by the toggle options "Editable Children" and "Load as Placeholder", as they show more distant to the option label than the rest of the icons.
This is a (very) minor UI bug and I couldn't found something similar happening somewhere else in Godot.
Normal Menu:
Weird Offset Menu:
|
enhancement,topic:editor,usability
|
low
|
Critical
|
584,819,267 |
scrcpy
|
Copy files from phone to PC
|
Is there any way to copy stuff from phone to pc like drag and drop feature. If not, please implement it. Thanks
|
feature request
|
low
|
Major
|
584,862,747 |
TypeScript
|
Discriminant-specific error message not shown when one constituent of a union has a union-typed discriminant
|
<!-- 🚨 STOP 🚨 𝗦𝗧𝗢𝗣 🚨 𝑺𝑻𝑶𝑷 🚨
Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Even if you think you've found a *bug*, please read the FAQ first, especially the Common "Bugs" That Aren't Bugs section!
Please help us by doing the following steps before logging an issue:
* Search: https://github.com/Microsoft/TypeScript/search?type=Issues
* Read the FAQ: https://github.com/Microsoft/TypeScript/wiki/FAQ
Please fill in the *entire* template below.
-->
<!--
Please try to reproduce the issue with the latest published version. It may have already been fixed.
For npm: `typescript@next`
This is also the 'Nightly' version in the playground: http://www.typescriptlang.org/play/?ts=Nightly
-->
**TypeScript Version:** 3.9.0-dev.20200319
<!-- Search terms you tried before logging this (so others can find this issue more easily) -->
**Search Terms:** discrimant tagged union assignable
**Code**
A simplified repro, based on real-world code:
```ts
interface A { x: number }
interface B { x: string }
interface U$A { kind: 'A', body: A }
interface U$B { kind: 'B', body: B }
interface U$null { kind: 'C' | 'D', body?: undefined }
type U = U$A | U$B | U$null;
declare function foo(u: U): void;
foo({kind: 'A', body: { x: 42 }}); // OK
foo({kind: 'B', body: { x: 42 }}); // Not OK
```
**Expected behavior:**
The second `x: 42` gets a squiggle and and the error `Type 'number' is not assignable to type 'string'.`
**Actual behavior:**
The whole argument to the second `foo` call gets a squiggle and the error:
>Argument of type '{ kind: "B"; body: { x: number; }; }' is not assignable to parameter of type 'U'. Type '{ kind: "B"; body: { x: number; }; }' is not assignable to type 'U$null'. Types of property 'kind' are incompatible. Type '"B"' is not assignable to type '"C" | "D"'.
I would expect the type of the argument to have been narrowed to `U$B` by checking the `kind` property first. As it stands, the developer UX is not ideal especially when the shapes of the types involved get larger and it gets quite hard to figure out which property is wrong (in my real-world case, the union has 250+ members and the error message is incomprehensible).
**Notes:**
If I change `x` to `y` in `interface B`, the error message comes up OK.
Also, if I comment out the two references to `U$null`, I get a different (but also acceptable) error.
**Playground Link:** <!-- A link to a TypeScript Playground "Share" link which demonstrates this behavior -->
https://www.typescriptlang.org/v2/en/play?ts=next#code/JYOwLgpgTgZghgYwgAgILIN7IB4C5kgCuAtgEbTIC+AUKJLIigEKY74DOYUoA5ldbXDR4SZAFUAJOiwBrUABN8AclRKANMlIB7eQE986GnWGNxElrIXKm6zTv3IWRoQ1GSiAGw+s5IRciUAYSVkAB8AgBFbbT0AfnxCPwgYUAh5fmowXQAHFDFkAF4zdHDJFlKJTw8AbgF5CAQPOCgUGESEMGAtEGQYLS0ACkJ8MQBKfAA3LWB5Wuo+wYxffxVo+3wsPGQAFgAmKkpR2oWBpasAmw0Yh038PYOj6iA
**Related Issues:** <!-- Did you find other bugs that looked similar? -->
None that (at an uneducated guess) seemed to be exactly this one.
|
Suggestion,Experience Enhancement
|
low
|
Critical
|
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.