url
stringlengths
63
63
repository_url
stringclasses
1 value
labels_url
stringlengths
77
77
comments_url
stringlengths
72
72
events_url
stringlengths
70
70
html_url
stringlengths
51
53
id
int64
1.57B
2.35B
node_id
stringlengths
18
19
number
int64
59.5k
69.6k
title
stringlengths
1
554
user
dict
labels
listlengths
0
8
state
stringclasses
2 values
locked
bool
2 classes
assignee
dict
assignees
listlengths
0
8
milestone
null
comments
sequencelengths
0
30
created_at
timestamp[s]
updated_at
timestamp[s]
closed_at
timestamp[s]
author_association
stringclasses
4 values
active_lock_reason
stringclasses
3 values
draft
bool
2 classes
pull_request
dict
body
stringlengths
1
65.4k
reactions
dict
timeline_url
stringlengths
72
72
performed_via_github_app
null
state_reason
stringclasses
3 values
is_pull_request
bool
2 classes
https://api.github.com/repos/tensorflow/tensorflow/issues/60316
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/60316/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/60316/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/60316/events
https://github.com/tensorflow/tensorflow/issues/60316
1,666,495,979
I_kwDOArmXAs5jVLXr
60,316
bug feedback
{ "login": "seems666", "id": 44560618, "node_id": "MDQ6VXNlcjQ0NTYwNjE4", "avatar_url": "https://avatars.githubusercontent.com/u/44560618?v=4", "gravatar_id": "", "url": "https://api.github.com/users/seems666", "html_url": "https://github.com/seems666", "followers_url": "https://api.github.com/users/seems666/followers", "following_url": "https://api.github.com/users/seems666/following{/other_user}", "gists_url": "https://api.github.com/users/seems666/gists{/gist_id}", "starred_url": "https://api.github.com/users/seems666/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/seems666/subscriptions", "organizations_url": "https://api.github.com/users/seems666/orgs", "repos_url": "https://api.github.com/users/seems666/repos", "events_url": "https://api.github.com/users/seems666/events{/privacy}", "received_events_url": "https://api.github.com/users/seems666/received_events", "type": "User", "site_admin": false }
[ { "id": 473172988, "node_id": "MDU6TGFiZWw0NzMxNzI5ODg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/type:bug", "name": "type:bug", "color": "159b2e", "default": false, "description": "Bug" }, { "id": 1097545817, "node_id": "MDU6TGFiZWwxMDk3NTQ1ODE3", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/comp:apis", "name": "comp:apis", "color": "0052cc", "default": false, "description": "Highlevel API related issues" }, { "id": 2498949452, "node_id": "MDU6TGFiZWwyNDk4OTQ5NDUy", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/TF%202.5", "name": "TF 2.5", "color": "5319e7", "default": false, "description": "Issues related to TF 2.5" } ]
closed
false
{ "login": "sushreebarsa", "id": 84765720, "node_id": "MDQ6VXNlcjg0NzY1NzIw", "avatar_url": "https://avatars.githubusercontent.com/u/84765720?v=4", "gravatar_id": "", "url": "https://api.github.com/users/sushreebarsa", "html_url": "https://github.com/sushreebarsa", "followers_url": "https://api.github.com/users/sushreebarsa/followers", "following_url": "https://api.github.com/users/sushreebarsa/following{/other_user}", "gists_url": "https://api.github.com/users/sushreebarsa/gists{/gist_id}", "starred_url": "https://api.github.com/users/sushreebarsa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sushreebarsa/subscriptions", "organizations_url": "https://api.github.com/users/sushreebarsa/orgs", "repos_url": "https://api.github.com/users/sushreebarsa/repos", "events_url": "https://api.github.com/users/sushreebarsa/events{/privacy}", "received_events_url": "https://api.github.com/users/sushreebarsa/received_events", "type": "User", "site_admin": false }
[ { "login": "sushreebarsa", "id": 84765720, "node_id": "MDQ6VXNlcjg0NzY1NzIw", "avatar_url": "https://avatars.githubusercontent.com/u/84765720?v=4", "gravatar_id": "", "url": "https://api.github.com/users/sushreebarsa", "html_url": "https://github.com/sushreebarsa", "followers_url": "https://api.github.com/users/sushreebarsa/followers", "following_url": "https://api.github.com/users/sushreebarsa/following{/other_user}", "gists_url": "https://api.github.com/users/sushreebarsa/gists{/gist_id}", "starred_url": "https://api.github.com/users/sushreebarsa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sushreebarsa/subscriptions", "organizations_url": "https://api.github.com/users/sushreebarsa/orgs", "repos_url": "https://api.github.com/users/sushreebarsa/repos", "events_url": "https://api.github.com/users/sushreebarsa/events{/privacy}", "received_events_url": "https://api.github.com/users/sushreebarsa/received_events", "type": "User", "site_admin": false } ]
null
[ "TF API is different than PT API. They don't need to have exactly the same signature. Not a bug", "Are you satisfied with the resolution of your issue?\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=Yes&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/60316\">Yes</a>\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=No&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/60316\">No</a>\n" ]
2023-04-13T14:05:28
2023-04-15T02:37:03
2023-04-15T02:37:01
NONE
null
null
null
<details><summary>Click to expand!</summary> ### Issue Type Bug ### Have you reproduced the bug with TF nightly? No ### Source source ### Tensorflow Version tf2.5 ### Custom Code Yes ### OS Platform and Distribution Windows 10 21H2 9044.2604 ### Mobile device _No response_ ### Python version 3.7 ### Bazel version _No response_ ### GCC/Compiler version _No response_ ### CUDA/cuDNN version 11.6 ### GPU model and memory _No response_ ### Current Behaviour? A robustness problem happened! When the number of inputs is greater than 1, the tanh function can still compute the inputs without throwing any exception. But in other framework like PyTorch, I can get exception message immediately. ### Standalone code to reproduce the issue ```shell import tensorflow as tf import torch import mindspore as ms if __name__ == '__main__': try: print(tf.tanh(tf.ones(2, 2), tf.ones(2, 2))) except Exception as e: print(e) try: print(torch.tanh(torch.ones(2, 2), torch.ones(2, 2))) except Exception as e: print(e) try: print(ms.ops.Tanh(ms.ops.Ones()((2, 2), ms.float32)), ms.ops.Ones()((2, 2), ms.float32)) except Exception as e: print(e) ``` ### Relevant log output ```shell tf.Tensor([0.76159416 0.76159416], shape=(2,), dtype=float64) tanh() takes 1 positional argument but 2 were given too many positional arguments ``` </details>
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/60316/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/60316/timeline
null
completed
false
https://api.github.com/repos/tensorflow/tensorflow/issues/60315
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/60315/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/60315/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/60315/events
https://github.com/tensorflow/tensorflow/issues/60315
1,666,464,994
I_kwDOArmXAs5jVDzi
60,315
bug feedback
{ "login": "seems666", "id": 44560618, "node_id": "MDQ6VXNlcjQ0NTYwNjE4", "avatar_url": "https://avatars.githubusercontent.com/u/44560618?v=4", "gravatar_id": "", "url": "https://api.github.com/users/seems666", "html_url": "https://github.com/seems666", "followers_url": "https://api.github.com/users/seems666/followers", "following_url": "https://api.github.com/users/seems666/following{/other_user}", "gists_url": "https://api.github.com/users/seems666/gists{/gist_id}", "starred_url": "https://api.github.com/users/seems666/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/seems666/subscriptions", "organizations_url": "https://api.github.com/users/seems666/orgs", "repos_url": "https://api.github.com/users/seems666/repos", "events_url": "https://api.github.com/users/seems666/events{/privacy}", "received_events_url": "https://api.github.com/users/seems666/received_events", "type": "User", "site_admin": false }
[ { "id": 473172988, "node_id": "MDU6TGFiZWw0NzMxNzI5ODg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/type:bug", "name": "type:bug", "color": "159b2e", "default": false, "description": "Bug" }, { "id": 1097547147, "node_id": "MDU6TGFiZWwxMDk3NTQ3MTQ3", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/comp:ops", "name": "comp:ops", "color": "0052cc", "default": false, "description": "OPs related issues" }, { "id": 2498949452, "node_id": "MDU6TGFiZWwyNDk4OTQ5NDUy", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/TF%202.5", "name": "TF 2.5", "color": "5319e7", "default": false, "description": "Issues related to TF 2.5" } ]
closed
false
{ "login": "sachinprasadhs", "id": 73069040, "node_id": "MDQ6VXNlcjczMDY5MDQw", "avatar_url": "https://avatars.githubusercontent.com/u/73069040?v=4", "gravatar_id": "", "url": "https://api.github.com/users/sachinprasadhs", "html_url": "https://github.com/sachinprasadhs", "followers_url": "https://api.github.com/users/sachinprasadhs/followers", "following_url": "https://api.github.com/users/sachinprasadhs/following{/other_user}", "gists_url": "https://api.github.com/users/sachinprasadhs/gists{/gist_id}", "starred_url": "https://api.github.com/users/sachinprasadhs/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sachinprasadhs/subscriptions", "organizations_url": "https://api.github.com/users/sachinprasadhs/orgs", "repos_url": "https://api.github.com/users/sachinprasadhs/repos", "events_url": "https://api.github.com/users/sachinprasadhs/events{/privacy}", "received_events_url": "https://api.github.com/users/sachinprasadhs/received_events", "type": "User", "site_admin": false }
[ { "login": "sachinprasadhs", "id": 73069040, "node_id": "MDQ6VXNlcjczMDY5MDQw", "avatar_url": "https://avatars.githubusercontent.com/u/73069040?v=4", "gravatar_id": "", "url": "https://api.github.com/users/sachinprasadhs", "html_url": "https://github.com/sachinprasadhs", "followers_url": "https://api.github.com/users/sachinprasadhs/followers", "following_url": "https://api.github.com/users/sachinprasadhs/following{/other_user}", "gists_url": "https://api.github.com/users/sachinprasadhs/gists{/gist_id}", "starred_url": "https://api.github.com/users/sachinprasadhs/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sachinprasadhs/subscriptions", "organizations_url": "https://api.github.com/users/sachinprasadhs/orgs", "repos_url": "https://api.github.com/users/sachinprasadhs/repos", "events_url": "https://api.github.com/users/sachinprasadhs/events{/privacy}", "received_events_url": "https://api.github.com/users/sachinprasadhs/received_events", "type": "User", "site_admin": false } ]
null
[ "Not a bug, I'd say. Rules for `NaN` say that any operation involving `NaN` should result in a `NaN`, afaik", "But the input is INF, in this situation the output should be INF as well.\r\nAnd I can get INF output in PyTorch when the input is INF and the operator is Conv2d.", "Does the same behavior occur in TF2.12?", "No, but I can get output -INF in TF2.12 with the same code, I wonder whether this output is correct or not.", "There might be an issue on the ordering of operations, but I am not sure that there is a guarantee on denormalized and special floats.", "TF convolutions call into NVIDIA's cuDNN library, which is producing the NaNs. Perhaps the internal cuDNN algorithm is multiplying some values by 0, which could be producing the NaNs because Inf * 0 = NaN.\r\n\r\nI don't think it's feasible to avoid turning Infs into NaNs in some cases, as algorithms may assume multiplying by zero results in zero, and also we don't have any control over cuDNN's algorithms. So I'll close this issue.", "Are you satisfied with the resolution of your issue?\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=Yes&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/60315\">Yes</a>\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=No&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/60315\">No</a>\n" ]
2023-04-13T13:51:32
2023-05-05T19:40:54
2023-05-05T19:40:52
NONE
null
null
null
<details><summary>Click to expand!</summary> ### Issue Type Bug ### Have you reproduced the bug with TF nightly? No ### Source binary ### Tensorflow Version tf2.5 ### Custom Code Yes ### OS Platform and Distribution Windows 10 21H2 9044.2604 ### Mobile device _No response_ ### Python version 3.7 ### Bazel version _No response_ ### GCC/Compiler version _No response_ ### CUDA/cuDNN version 11.6 ### GPU model and memory _No response_ ### Current Behaviour? A bug happened! When the input of Conv2D is inf, in_channels and out_channels are greater than 128, the output is supposed to be inf, but got nan in fact. And I can get correct output in PyTorch. ### Standalone code to reproduce the issue ```shell data = np.array([np.inf for _ in range(1 * 128 * 6 * 6)]) data = np.reshape(data, newshape=[1, 128, 6, 6]) conv = tf.keras.layers.Conv2D(filters=256, kernel_size=3) print(conv(data)) ``` ### Relevant log output ```shell tf.Tensor( [[[[nan nan nan ... nan nan nan] [nan nan nan ... nan nan nan] [nan nan nan ... nan nan nan] [nan nan nan ... nan nan nan]] [[nan nan nan ... nan nan nan] [nan nan nan ... nan nan nan] [nan nan nan ... nan nan nan] [nan nan nan ... nan nan nan]] [[nan nan nan ... nan nan nan] [nan nan nan ... nan nan nan] [nan nan nan ... nan nan nan] [nan nan nan ... nan nan nan]] ... [[nan nan nan ... nan nan nan] [nan nan nan ... nan nan nan] [nan nan nan ... nan nan nan] [nan nan nan ... nan nan nan]] [[nan nan nan ... nan nan nan] [nan nan nan ... nan nan nan] [nan nan nan ... nan nan nan] [nan nan nan ... nan nan nan]] [[nan nan nan ... nan nan nan] [nan nan nan ... nan nan nan] [nan nan nan ... nan nan nan] [nan nan nan ... nan nan nan]]]], shape=(1, 126, 4, 256), dtype=float32) ``` </details>
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/60315/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/60315/timeline
null
completed
false
https://api.github.com/repos/tensorflow/tensorflow/issues/60314
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/60314/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/60314/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/60314/events
https://github.com/tensorflow/tensorflow/issues/60314
1,666,420,792
I_kwDOArmXAs5jU5A4
60,314
Backpropagation for all zero label vectors in softmax/crossentropy
{ "login": "Janushki", "id": 128641174, "node_id": "U_kgDOB6rolg", "avatar_url": "https://avatars.githubusercontent.com/u/128641174?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Janushki", "html_url": "https://github.com/Janushki", "followers_url": "https://api.github.com/users/Janushki/followers", "following_url": "https://api.github.com/users/Janushki/following{/other_user}", "gists_url": "https://api.github.com/users/Janushki/gists{/gist_id}", "starred_url": "https://api.github.com/users/Janushki/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Janushki/subscriptions", "organizations_url": "https://api.github.com/users/Janushki/orgs", "repos_url": "https://api.github.com/users/Janushki/repos", "events_url": "https://api.github.com/users/Janushki/events{/privacy}", "received_events_url": "https://api.github.com/users/Janushki/received_events", "type": "User", "site_admin": false }
[ { "id": 404586594, "node_id": "MDU6TGFiZWw0MDQ1ODY1OTQ=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/stat:awaiting%20tensorflower", "name": "stat:awaiting tensorflower", "color": "f4b400", "default": false, "description": "Status - Awaiting response from tensorflower" }, { "id": 473172988, "node_id": "MDU6TGFiZWw0NzMxNzI5ODg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/type:bug", "name": "type:bug", "color": "159b2e", "default": false, "description": "Bug" }, { "id": 1097546578, "node_id": "MDU6TGFiZWwxMDk3NTQ2NTc4", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/comp:keras", "name": "comp:keras", "color": "0052cc", "default": false, "description": "Keras related issues" }, { "id": 1097547147, "node_id": "MDU6TGFiZWwxMDk3NTQ3MTQ3", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/comp:ops", "name": "comp:ops", "color": "0052cc", "default": false, "description": "OPs related issues" }, { "id": 5206407904, "node_id": "LA_kwDOArmXAs8AAAABNlN64A", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/TF%202.12", "name": "TF 2.12", "color": "c5def5", "default": false, "description": "For issues related to Tensorflow 2.12" } ]
closed
false
{ "login": "sachinprasadhs", "id": 73069040, "node_id": "MDQ6VXNlcjczMDY5MDQw", "avatar_url": "https://avatars.githubusercontent.com/u/73069040?v=4", "gravatar_id": "", "url": "https://api.github.com/users/sachinprasadhs", "html_url": "https://github.com/sachinprasadhs", "followers_url": "https://api.github.com/users/sachinprasadhs/followers", "following_url": "https://api.github.com/users/sachinprasadhs/following{/other_user}", "gists_url": "https://api.github.com/users/sachinprasadhs/gists{/gist_id}", "starred_url": "https://api.github.com/users/sachinprasadhs/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sachinprasadhs/subscriptions", "organizations_url": "https://api.github.com/users/sachinprasadhs/orgs", "repos_url": "https://api.github.com/users/sachinprasadhs/repos", "events_url": "https://api.github.com/users/sachinprasadhs/events{/privacy}", "received_events_url": "https://api.github.com/users/sachinprasadhs/received_events", "type": "User", "site_admin": false }
[ { "login": "sachinprasadhs", "id": 73069040, "node_id": "MDQ6VXNlcjczMDY5MDQw", "avatar_url": "https://avatars.githubusercontent.com/u/73069040?v=4", "gravatar_id": "", "url": "https://api.github.com/users/sachinprasadhs", "html_url": "https://github.com/sachinprasadhs", "followers_url": "https://api.github.com/users/sachinprasadhs/followers", "following_url": "https://api.github.com/users/sachinprasadhs/following{/other_user}", "gists_url": "https://api.github.com/users/sachinprasadhs/gists{/gist_id}", "starred_url": "https://api.github.com/users/sachinprasadhs/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sachinprasadhs/subscriptions", "organizations_url": "https://api.github.com/users/sachinprasadhs/orgs", "repos_url": "https://api.github.com/users/sachinprasadhs/repos", "events_url": "https://api.github.com/users/sachinprasadhs/events{/privacy}", "received_events_url": "https://api.github.com/users/sachinprasadhs/received_events", "type": "User", "site_admin": false } ]
null
[ "@sachinprasadhs,\r\nI was able to reproduce the issue on tensorflow v2.12 and nightly. Kindly find the gist of it [here](https://colab.research.google.com/gist/tilakrayal/79d4e1836b23cb219236e63d8ab3443f/untitled1071.ipynb).", "@Janushki , Thanks for reporting the issue. \r\nI was debugging this from my side as well.\r\nMeanwhile, Could you please provide some more details on the mathematical computation of both of the approaches.", "Initial observation: \r\nI was able to compare both the results outside gradient scope for forward computation and the results were identical.\r\nThe issue seems to be happening in the gradient calculation. \r\nBelow is the code I tried to compare both results with a seed and detailed gist can be found [here](https://gist.github.com/sachinprasadhs/a792cadef1ef4f217be127091c7953e6).\r\n```\r\nStep1 \r\nimport tensorflow as tf\r\nimport keras\r\ntf.keras.utils.set_random_seed(42)\r\nx = tf.constant([[0.1,0.90]])\r\ny = tf.constant([[0.0,.0]])\r\nz = tf.keras.Sequential(\r\n [keras.layers.Dense(2,activation = \"linear\", use_bias = False),\r\n keras.layers.Softmax()]\r\n )(x)\r\nprint(z)\r\nz = tf.losses.categorical_crossentropy(y, z)\r\nprint(z)\r\n```\r\n\r\n```\r\ntf.Tensor([[0.22173299 0.778267 ]], shape=(1, 2), dtype=float32)\r\ntf.Tensor([-0.], shape=(1,), dtype=float32)\r\n```\r\n\r\n```\r\nStep2:\r\nimport tensorflow as tf\r\nimport keras\r\ntf.keras.utils.set_random_seed(42)\r\nx = tf.Variable([[0.1,0.90]])\r\ny = tf.Variable([[0.0,.0]])\r\nz = keras.Sequential(\r\n keras.layers.Dense(2, activation = \"softmax\", use_bias = False)\r\n )(x)\r\nprint(z)\r\nz = tf.losses.categorical_crossentropy(y, z)\r\nprint(z)\r\n```\r\n\r\n```\r\ntf.Tensor([[0.22173299 0.778267 ]], shape=(1, 2), dtype=float32)\r\ntf.Tensor([0.], shape=(1,), dtype=float32)\r\n```\r\n", "> @Janushki , Thanks for reporting the issue. I was debugging this from my side as well. Meanwhile, Could you please provide some more details on the mathematical computation of both of the approaches.\r\n\r\nSorry for the late answer, I didnt have time last week. And thanks alot for your effort!\r\n\r\nThe Categorical Crossentropie Loss is defined as:\r\n$$-\\sum_i y_i * \\log(x_i)$$\r\n\r\nif we add the information that $y_i = 0$ this leads to\r\n$$-\\sum_i y_i * \\log(x_i)=-\\sum_i 0 * \\log(x_i)=-\\sum_i 0=0$$\r\nas the loss is constantly zero, the partial derivate for $x_i$ is zero aswell. Actually this should be independent of the pervious activation function.\r\n", "Hi @Janushki ,\r\n\r\nThank you for the report. There was indeed a discrepancy in the results depending on the approach. This is now fixed in `tf-nightly`. https://github.com/keras-team/keras/commit/304bb3d9ab137dd26263381977890f00aac62e75\r\n\r\nSpecifically, this fixes the `Softmax` layer. After this change, the `Softmax` layer produces the same result as the `softmax` activation.\r\n\r\nThanks,\r\nFabien", "Are you satisfied with the resolution of your issue?\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=Yes&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/60314\">Yes</a>\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=No&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/60314\">No</a>\n" ]
2023-04-13T13:26:28
2023-05-31T21:16:14
2023-05-31T21:16:11
NONE
null
null
null
<details><summary>Click to expand!</summary> ### Issue Type Bug ### Have you reproduced the bug with TF nightly? Yes ### Source source ### Tensorflow Version 2.13.0-dev20230413 ### Custom Code Yes ### OS Platform and Distribution Ubuntu 22.04.1 LTS ### Mobile device _No response_ ### Python version Python 3.10.10 ### Bazel version _No response_ ### GCC/Compiler version _No response_ ### CUDA/cuDNN version no GPU Used ### GPU model and memory no GPU Used ### Current Behaviour? The First approach to building a Softmax layer yields a non zero gradient in backpropagation for an all zero target vector. The second approach yields a zero gradient. I would expect the behaviour of the latter, as is mathematically correct. I am a bit unsure whether this is intentended behaviour or not. If it is intended, where does the difference come from? ### Standalone code to reproduce the issue ```shell import tensorflow as tf import keras x = tf.constant([[0.1,0.90]]) y = tf.constant([[0.0,.0]]) # First approach with tf.GradientTape() as g: g.watch(x) z = keras.Sequential( keras.layers.Dense(2, activation = "softmax", use_bias = False) )(x) z = tf.losses.categorical_crossentropy(y, z) dz_dx = g.gradient(z, x) print(dz_dx) x = tf.constant([[0.1,0.90]]) y = tf.constant([[0.0,.0]]) # Second approach with tf.GradientTape() as g: g.watch(x) z = keras.Sequential( [keras.layers.Dense(2, activation = "linear", use_bias = False), keras.layers.Softmax(axis = -1)] )(x) z = tf.losses.categorical_crossentropy(y, z) dz_dx = g.gradient(z, x) print(dz_dx) ``` ### Relevant log output _No response_</details>
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/60314/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/60314/timeline
null
completed
false
https://api.github.com/repos/tensorflow/tensorflow/issues/60313
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/60313/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/60313/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/60313/events
https://github.com/tensorflow/tensorflow/issues/60313
1,666,367,393
I_kwDOArmXAs5jUr-h
60,313
TensorFlow Lite in Play Services, app is crashing when creating interpreter
{ "login": "sandeep5193", "id": 5195732, "node_id": "MDQ6VXNlcjUxOTU3MzI=", "avatar_url": "https://avatars.githubusercontent.com/u/5195732?v=4", "gravatar_id": "", "url": "https://api.github.com/users/sandeep5193", "html_url": "https://github.com/sandeep5193", "followers_url": "https://api.github.com/users/sandeep5193/followers", "following_url": "https://api.github.com/users/sandeep5193/following{/other_user}", "gists_url": "https://api.github.com/users/sandeep5193/gists{/gist_id}", "starred_url": "https://api.github.com/users/sandeep5193/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sandeep5193/subscriptions", "organizations_url": "https://api.github.com/users/sandeep5193/orgs", "repos_url": "https://api.github.com/users/sandeep5193/repos", "events_url": "https://api.github.com/users/sandeep5193/events{/privacy}", "received_events_url": "https://api.github.com/users/sandeep5193/received_events", "type": "User", "site_admin": false }
[ { "id": 386191887, "node_id": "MDU6TGFiZWwzODYxOTE4ODc=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/stat:awaiting%20response", "name": "stat:awaiting response", "color": "f4b400", "default": false, "description": "Status - Awaiting response from author" }, { "id": 473172988, "node_id": "MDU6TGFiZWw0NzMxNzI5ODg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/type:bug", "name": "type:bug", "color": "159b2e", "default": false, "description": "Bug" }, { "id": 474725938, "node_id": "MDU6TGFiZWw0NzQ3MjU5Mzg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/stale", "name": "stale", "color": "d4c5f9", "default": false, "description": "This label marks the issue/pr stale - to be closed automatically if no activity" }, { "id": 750616506, "node_id": "MDU6TGFiZWw3NTA2MTY1MDY=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/comp:lite", "name": "comp:lite", "color": "0052cc", "default": false, "description": "TF Lite related issues" }, { "id": 2671339633, "node_id": "MDU6TGFiZWwyNjcxMzM5NjMz", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/TFLiteGpuDelegate", "name": "TFLiteGpuDelegate", "color": "F71F04", "default": false, "description": "TFLite Gpu delegate issue" }, { "id": 3835861157, "node_id": "LA_kwDOArmXAs7kopil", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/TFLiteGooglePlayServices", "name": "TFLiteGooglePlayServices", "color": "27FAE2", "default": false, "description": "For issues related to TensorFlow Lite in Google Play Services" } ]
closed
false
{ "login": "sachinprasadhs", "id": 73069040, "node_id": "MDQ6VXNlcjczMDY5MDQw", "avatar_url": "https://avatars.githubusercontent.com/u/73069040?v=4", "gravatar_id": "", "url": "https://api.github.com/users/sachinprasadhs", "html_url": "https://github.com/sachinprasadhs", "followers_url": "https://api.github.com/users/sachinprasadhs/followers", "following_url": "https://api.github.com/users/sachinprasadhs/following{/other_user}", "gists_url": "https://api.github.com/users/sachinprasadhs/gists{/gist_id}", "starred_url": "https://api.github.com/users/sachinprasadhs/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sachinprasadhs/subscriptions", "organizations_url": "https://api.github.com/users/sachinprasadhs/orgs", "repos_url": "https://api.github.com/users/sachinprasadhs/repos", "events_url": "https://api.github.com/users/sachinprasadhs/events{/privacy}", "received_events_url": "https://api.github.com/users/sachinprasadhs/received_events", "type": "User", "site_admin": false }
[ { "login": "sachinprasadhs", "id": 73069040, "node_id": "MDQ6VXNlcjczMDY5MDQw", "avatar_url": "https://avatars.githubusercontent.com/u/73069040?v=4", "gravatar_id": "", "url": "https://api.github.com/users/sachinprasadhs", "html_url": "https://github.com/sachinprasadhs", "followers_url": "https://api.github.com/users/sachinprasadhs/followers", "following_url": "https://api.github.com/users/sachinprasadhs/following{/other_user}", "gists_url": "https://api.github.com/users/sachinprasadhs/gists{/gist_id}", "starred_url": "https://api.github.com/users/sachinprasadhs/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sachinprasadhs/subscriptions", "organizations_url": "https://api.github.com/users/sachinprasadhs/orgs", "repos_url": "https://api.github.com/users/sachinprasadhs/repos", "events_url": "https://api.github.com/users/sachinprasadhs/events{/privacy}", "received_events_url": "https://api.github.com/users/sachinprasadhs/received_events", "type": "User", "site_admin": false } ]
null
[ "It seems that the crash is happening in the TensorFlow Lite GPU delegate while trying to create an interpreter. One potential solution is to disable the GPU delegate and only use the CPU delegate. You can do this by removing the following line of code:\r\n\r\narduino\r\nCopy code\r\n.addDelegateFactory(new GpuDelegateFactory())\r\nIf the issue persists, you could try updating your TensorFlow Lite in Play Services SDK to the latest version to see if the problem has been resolved in a newer release.\r\n\r\nAdditionally, you can check if there are any compatibility issues between the Samsung a13 device and the TensorFlow Lite GPU delegate by checking the device's specifications and the minimum requirements for the GPU delegate. You may also want to check if any other apps on the device are experiencing similar crashes and try to isolate the issue by running the app on other devices. Finally, you could try reaching out to the TensorFlow community forums for more help and guidance.", "Hi @sandeep5193 \r\n\r\nSorry for delayed response.\r\n\r\nWe can enable the GPU delegate option in the TFlite initialization by\r\n```\r\nTfLite.initialize(context,\r\n TfLiteInitializationOptions.builder()\r\n .setEnableGpuDelegateSupport(true)\r\n .build());\r\n```\r\nbefore adding `.addDelegateFactory(new GpuDelegateFactory())`\r\n\r\nPlease refer [this](https://www.tensorflow.org/lite/android/play_services#gpu_with_interpreter_apis) instructions on using GPU delegate.\r\n \r\nIf the issue still persists, could you please provide a standalone code to reproduce this issue?\r\n\r\nThanks.", "The code I have mentioned is working fine for some time now. All of a\r\nsudden it started crashing on few devices, without any changes in our code. You still think by\r\nchanging initialisation steps you have mentioned will solve the problem?\r\n\r\nOn Mon, 17 Apr, 2023, 5:25 pm pjpratik, ***@***.***> wrote:\r\n\r\n> Hi @sandeep5193 <https://github.com/sandeep5193>\r\n>\r\n> Sorry for delayed response.\r\n>\r\n> We can enable the GPU delegate option in the TFlite initialization by\r\n>\r\n> TfLite.initialize(context,\r\n> TfLiteInitializationOptions.builder()\r\n> .setEnableGpuDelegateSupport(true)\r\n> .build());\r\n>\r\n> before adding .addDelegateFactory(new GpuDelegateFactory())\r\n>\r\n> Please refer this\r\n> <https://www.tensorflow.org/lite/android/play_services#gpu_with_interpreter_apis>\r\n> instructions on using GPU delegate.\r\n>\r\n> If the issue still persists, could you please provide a standalone code to\r\n> reproduce this issue?\r\n>\r\n> Thanks.\r\n>\r\n> —\r\n> Reply to this email directly, view it on GitHub\r\n> <https://github.com/tensorflow/tensorflow/issues/60313#issuecomment-1511200353>,\r\n> or unsubscribe\r\n> <https://github.com/notifications/unsubscribe-auth/ABHUPVFGJFMGNNAX76YIALLXBUVTDANCNFSM6AAAAAAW5BL6IQ>\r\n> .\r\n> You are receiving this because you were mentioned.Message ID:\r\n> ***@***.***>\r\n>\r\n", "Hi @sandeep5193 \r\n\r\nWas it working fine with GPU delegate on few cases? \r\n\r\nI was checking if the the GPU delegate is not initialized that maybe causing the issue.\r\n\r\nCan you provide a reproducible code to better understand and investigate the issue.\r\n\r\nThanks.", "hi @pjpratik\r\n\r\nit was working very well in all devices. all of a sudden we started receiving this error in production, for few devices, exact numbers you can read in my first post. so we had to stop it.\r\n\r\nwe are not able to reproduce this in our development devices, but code mentioned in the original post is the point of crash.", "Given that it says [libtensorflowlite_jni_gms_client.so], this is beyond my understanding. @sachinprasadhs can this be assigned to the TFLite in GMS core team?", "Hi, we have identified a compatibility issue between the TFLite runtime module and the GPU delegate module that might be the cause of this crash. The good news is, we are already in the process of rolling out an update that should fix the issue. I will post an update on this bug once the rollout is complete.", "@sheepmaster can I downgrade my tflite version to remedy this in the short term?\r\n", "We have finished the rollout, so devices should pick up the fix automatically. If you still encounter crashes, please let us know (ideally by filing a new bug, so we can distinguish different issues). Thanks!", "This issue is stale because it has been open for 7 days with no activity. It will be closed if no further activity occurs. Thank you.", "This issue was closed because it has been inactive for 7 days since being marked as stale. Please reopen if you'd like to work on this further.", "Are you satisfied with the resolution of your issue?\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=Yes&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/60313\">Yes</a>\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=No&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/60313\">No</a>\n" ]
2023-04-13T12:55:19
2023-05-25T01:54:40
2023-05-25T01:54:37
NONE
null
null
null
**System information** - Android Device information: samsung a13 (5793 events, 31% of total events), samsung m11q, Redmi olivewood, samsung j6lte, samsung m13, samsung j7velte, samsung on7xelte - TensorFlow Lite in Play Services SDK version: play-services-tflite-java:16.0.1, play-services-tflite-gpu:16.1.0 - Google Play Services version: don't know, never happened in dev devices. **Standalone code to reproduce the issue** ``` InterpreterApi.create(new File(modelFile), new InterpreterApi.Options() .setRuntime(TfLiteRuntime.FROM_SYSTEM_ONLY) .addDelegateFactory(new GpuDelegateFactory())); ``` **Any other info / logs** We have started receiving this crash from 23 March 2023, app was updated a month ago before this(21st feb). When we stopped using GPU Delegate, toggled through Firebase Remote Config, the error went away. Samsung a13 device alone has registered 5793 crashes, which is 31% of total events, based on Play Store Console. title in the console is "[libtensorflowlite_jni_gms_client.so] Java_com_google_android_gms_tflite_NativeInterpreterWrapper_createInterpreter" backtrace: ``` #00 pc 0x000000000015643a /data/user_de/0/com.google.android.gms/app_chimera/m/0000003c/dl-TfliteDynamiteDynamite.integ_224210505100300.apk #01 pc 0x0000000000156415 /data/user_de/0/com.google.android.gms/app_chimera/m/0000003c/dl-TfliteDynamiteDynamite.integ_224210505100300.apk #02 pc 0x0000000000059961 /data/user_de/0/com.google.android.gms/app_chimera/m/000000bd/dl-TfliteGpuDynamite.optional_231015100300.apk #03 pc 0x0000000000159279 /data/user_de/0/com.google.android.gms/app_chimera/m/0000003c/dl-TfliteDynamiteDynamite.integ_224210505100300.apk #04 pc 0x000000000014f4bf /data/user_de/0/com.google.android.gms/app_chimera/m/0000003c/dl-TfliteDynamiteDynamite.integ_224210505100300.apk #05 pc 0x000000000014da61 /data/user_de/0/com.google.android.gms/app_chimera/m/0000003c/dl-TfliteDynamiteDynamite.integ_224210505100300.apk #06 pc 0x000000000014d8db /data/user_de/0/com.google.android.gms/app_chimera/m/0000003c/dl-TfliteDynamiteDynamite.integ_224210505100300.apk #07 pc 0x0000000000036181 /data/user_de/0/com.google.android.gms/app_chimera/m/0000003c/dl-TfliteDynamiteDynamite.integ_224210505100300.apk #08 pc 0x000000000001b477 /data/app/~~RdHSBgE6dMlsRCnHjLYXZw==/com.example-Z6wg41mIr1QI0UuN7e6zkQ==/lib/arm/libtensorflowlite_jni_gms_client.so #09 pc 0x000000000001a609 /data/app/~~RdHSBgE6dMlsRCnHjLYXZw==/com.example-Z6wg41mIr1QI0UuN7e6zkQ==/lib/arm/libtensorflowlite_jni_gms_client.so #10 pc 0x000000000001a673 /data/app/~~RdHSBgE6dMlsRCnHjLYXZw==/com.example-Z6wg41mIr1QI0UuN7e6zkQ==/lib/arm/libtensorflowlite_jni_gms_client.so #11 pc 0x000000000001abc1 /data/app/~~RdHSBgE6dMlsRCnHjLYXZw==/com.example-Z6wg41mIr1QI0UuN7e6zkQ==/lib/arm/libtensorflowlite_jni_gms_client.so #12 pc 0x0000000000017d61 /data/app/~~RdHSBgE6dMlsRCnHjLYXZw==/com.example-Z6wg41mIr1QI0UuN7e6zkQ==/lib/arm/libtensorflowlite_jni_gms_client.so (Java_com_google_android_gms_tflite_NativeInterpreterWrapper_createInterpreter+452) #13 pc 0x000000000014e2b5 /data/app/~~RdHSBgE6dMlsRCnHjLYXZw==/com.example-Z6wg41mIr1QI0UuN7e6zkQ==/oat/arm/base.odex (art_jni_trampoline+100) #14 pc 0x00000000000edf38 /apex/com.android.art/lib/libart.so (nterp_helper+2728) #15 pc 0x00000000009af384 /data/app/~~RdHSBgE6dMlsRCnHjLYXZw==/com.example-Z6wg41mIr1QI0UuN7e6zkQ==/oat/arm/base.vdex (com.google.android.gms.tflite.NativeInterpreterWrapper.zzl+528) #16 pc 0x00000000000ee688 /apex/com.android.art/lib/libart.so (nterp_helper+4600) #17 pc 0x00000000009af08e /data/app/~~RdHSBgE6dMlsRCnHjLYXZw==/com.example-Z6wg41mIr1QI0UuN7e6zkQ==/oat/arm/base.vdex (com.google.android.gms.tflite.NativeInterpreterWrapper.<init>+86) #18 pc 0x00000000000edf80 /apex/com.android.art/lib/libart.so (nterp_helper+2800) #19 pc 0x00000000009afbd2 /data/app/~~RdHSBgE6dMlsRCnHjLYXZw==/com.example-Z6wg41mIr1QI0UuN7e6zkQ==/oat/arm/base.vdex (com.google.android.gms.tflite.zzd.<init>+18) #20 pc 0x00000000000edf80 /apex/com.android.art/lib/libart.so (nterp_helper+2800) #21 pc 0x00000000009aef44 /data/app/~~RdHSBgE6dMlsRCnHjLYXZw==/com.example-Z6wg41mIr1QI0UuN7e6zkQ==/oat/arm/base.vdex (com.google.android.gms.tflite.InterpreterFactoryImpl.create+24) #22 pc 0x00000000000ee92c /apex/com.android.art/lib/libart.so (nterp_helper+5276) #23 pc 0x000000000040f87e /data/app/~~RdHSBgE6dMlsRCnHjLYXZw==/com.example-Z6wg41mIr1QI0UuN7e6zkQ==/oat/arm/base.vdex (androidx.appcompat.widget.a0.b+230) #24 pc 0x00000000000ed4c8 /apex/com.android.art/lib/libart.so (nterp_helper+56) #25 pc 0x00000000009b6ce0 /data/app/~~RdHSBgE6dMlsRCnHjLYXZw==/com.example-Z6wg41mIr1QI0UuN7e6zkQ==/oat/arm/base.vdex (com.google.firebase.samples.apps.mlkit.NsfwImageProcessor.createInterpreter+104) #26 pc 0x00000000000edf80 /apex/com.android.art/lib/libart.so (nterp_helper+2800) #27 pc 0x00000000009b6d0a /data/app/~~RdHSBgE6dMlsRCnHjLYXZw==/com.example-Z6wg41mIr1QI0UuN7e6zkQ==/oat/arm/base.vdex (com.google.firebase.samples.apps.mlkit.NsfwImageProcessor.lambda$new$0) #28 pc 0x00000000000edf80 /apex/com.android.art/lib/libart.so (nterp_helper+2800) #29 pc 0x00000000009b6bbc /data/app/~~RdHSBgE6dMlsRCnHjLYXZw==/com.example-Z6wg41mIr1QI0UuN7e6zkQ==/oat/arm/base.vdex (com.google.firebase.samples.apps.mlkit.NsfwImageProcessor.a) #30 pc 0x00000000000ed4c8 /apex/com.android.art/lib/libart.so (nterp_helper+56) #31 pc 0x00000000004123f0 /data/app/~~RdHSBgE6dMlsRCnHjLYXZw==/com.example-Z6wg41mIr1QI0UuN7e6zkQ==/oat/arm/base.vdex (com.applovin.exoplayer2.b.a0.run+44) #32 pc 0x0000000000c964b7 /data/misc/apexdata/com.android.art/dalvik-cache/arm/boot.oat (android.os.Handler.dispatchMessage+70) #33 pc 0x0000000000c99fb7 /data/misc/apexdata/com.android.art/dalvik-cache/arm/boot.oat (android.os.Looper.loopOnce+886) #34 pc 0x0000000000c99b5b /data/misc/apexdata/com.android.art/dalvik-cache/arm/boot.oat (android.os.Looper.loop+1034) #35 pc 0x0000000000c989bd /data/misc/apexdata/com.android.art/dalvik-cache/arm/boot.oat (android.os.HandlerThread.run+1748) #36 pc 0x00000000003bdbd5 /apex/com.android.art/lib/libart.so (art_quick_invoke_stub_internal+68) #37 pc 0x00000000003bd677 /apex/com.android.art/lib/libart.so (void art::quick_invoke_reg_setup<false>(art::ArtMethod*, unsigned int*, unsigned int, art::Thread*, art::JValue*, char const*) (.__uniq.192663596067446536341070919852553954320.llvm.16200230356545185596)+158) #38 pc 0x0000000000288f1d /apex/com.android.art/lib/libart.so (art::ArtMethod::Invoke(art::Thread*, unsigned int*, unsigned int, art::JValue*, char const*)+136) #39 pc 0x00000000003128a9 /apex/com.android.art/lib/libart.so (art::(anonymous namespace)::InvokeWithArgArray(art::ScopedObjectAccessAlreadyRunnable const&, art::ArtMethod*, art::(anonymous namespace)::ArgArray*, art::JValue*, char const*) (.__uniq.245181933781456475607640333933569312899.llvm.1951482298021755071)+40) #40 pc 0x00000000003127b5 /apex/com.android.art/lib/libart.so (art::JValue art::InvokeVirtualOrInterfaceWithJValues<art::ArtMethod*>(art::ScopedObjectAccessAlreadyRunnable const&, _jobject*, art::ArtMethod*, jvalue const*)+164) #41 pc 0x000000000033dc8b /apex/com.android.art/lib/libart.so (art::JValue art::InvokeVirtualOrInterfaceWithJValues<_jmethodID*>(art::ScopedObjectAccessAlreadyRunnable const&, _jobject*, _jmethodID*, jvalue const*)+42) #42 pc 0x00000000002f0bad /apex/com.android.art/lib/libart.so (art::Thread::CreateCallback(void*)+424) #43 pc 0x00000000000afc5f /apex/com.android.runtime/lib/bionic/libc.so (__pthread_start(void*)+40) #44 pc 0x0000000000065ef1 /apex/com.android.runtime/lib/bionic/libc.so (__start_thread+30) ```
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/60313/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/60313/timeline
null
completed
false
https://api.github.com/repos/tensorflow/tensorflow/issues/60312
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/60312/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/60312/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/60312/events
https://github.com/tensorflow/tensorflow/issues/60312
1,666,110,211
I_kwDOArmXAs5jTtMD
60,312
Stride-1 tf.nn.conv2d with XLA is 1.5x slower then without XLA, as far as stride-2 tf.nn.depthwise_conv2d
{ "login": "shkarupa-alex", "id": 1289725, "node_id": "MDQ6VXNlcjEyODk3MjU=", "avatar_url": "https://avatars.githubusercontent.com/u/1289725?v=4", "gravatar_id": "", "url": "https://api.github.com/users/shkarupa-alex", "html_url": "https://github.com/shkarupa-alex", "followers_url": "https://api.github.com/users/shkarupa-alex/followers", "following_url": "https://api.github.com/users/shkarupa-alex/following{/other_user}", "gists_url": "https://api.github.com/users/shkarupa-alex/gists{/gist_id}", "starred_url": "https://api.github.com/users/shkarupa-alex/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/shkarupa-alex/subscriptions", "organizations_url": "https://api.github.com/users/shkarupa-alex/orgs", "repos_url": "https://api.github.com/users/shkarupa-alex/repos", "events_url": "https://api.github.com/users/shkarupa-alex/events{/privacy}", "received_events_url": "https://api.github.com/users/shkarupa-alex/received_events", "type": "User", "site_admin": false }
[ { "id": 404586594, "node_id": "MDU6TGFiZWw0MDQ1ODY1OTQ=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/stat:awaiting%20tensorflower", "name": "stat:awaiting tensorflower", "color": "f4b400", "default": false, "description": "Status - Awaiting response from tensorflower" }, { "id": 473172988, "node_id": "MDU6TGFiZWw0NzMxNzI5ODg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/type:bug", "name": "type:bug", "color": "159b2e", "default": false, "description": "Bug" }, { "id": 1133285679, "node_id": "MDU6TGFiZWwxMTMzMjg1Njc5", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/comp:xla", "name": "comp:xla", "color": "0052cc", "default": false, "description": "XLA" }, { "id": 1463677878, "node_id": "MDU6TGFiZWwxNDYzNjc3ODc4", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/type:performance", "name": "type:performance", "color": "159b2e", "default": false, "description": "Performance Issue" }, { "id": 5206407904, "node_id": "LA_kwDOArmXAs8AAAABNlN64A", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/TF%202.12", "name": "TF 2.12", "color": "c5def5", "default": false, "description": "For issues related to Tensorflow 2.12" } ]
open
false
{ "login": "cheshire", "id": 348959, "node_id": "MDQ6VXNlcjM0ODk1OQ==", "avatar_url": "https://avatars.githubusercontent.com/u/348959?v=4", "gravatar_id": "", "url": "https://api.github.com/users/cheshire", "html_url": "https://github.com/cheshire", "followers_url": "https://api.github.com/users/cheshire/followers", "following_url": "https://api.github.com/users/cheshire/following{/other_user}", "gists_url": "https://api.github.com/users/cheshire/gists{/gist_id}", "starred_url": "https://api.github.com/users/cheshire/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/cheshire/subscriptions", "organizations_url": "https://api.github.com/users/cheshire/orgs", "repos_url": "https://api.github.com/users/cheshire/repos", "events_url": "https://api.github.com/users/cheshire/events{/privacy}", "received_events_url": "https://api.github.com/users/cheshire/received_events", "type": "User", "site_admin": false }
[ { "login": "cheshire", "id": 348959, "node_id": "MDQ6VXNlcjM0ODk1OQ==", "avatar_url": "https://avatars.githubusercontent.com/u/348959?v=4", "gravatar_id": "", "url": "https://api.github.com/users/cheshire", "html_url": "https://github.com/cheshire", "followers_url": "https://api.github.com/users/cheshire/followers", "following_url": "https://api.github.com/users/cheshire/following{/other_user}", "gists_url": "https://api.github.com/users/cheshire/gists{/gist_id}", "starred_url": "https://api.github.com/users/cheshire/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/cheshire/subscriptions", "organizations_url": "https://api.github.com/users/cheshire/orgs", "repos_url": "https://api.github.com/users/cheshire/repos", "events_url": "https://api.github.com/users/cheshire/events{/privacy}", "received_events_url": "https://api.github.com/users/cheshire/received_events", "type": "User", "site_admin": false }, { "login": "sachinprasadhs", "id": 73069040, "node_id": "MDQ6VXNlcjczMDY5MDQw", "avatar_url": "https://avatars.githubusercontent.com/u/73069040?v=4", "gravatar_id": "", "url": "https://api.github.com/users/sachinprasadhs", "html_url": "https://github.com/sachinprasadhs", "followers_url": "https://api.github.com/users/sachinprasadhs/followers", "following_url": "https://api.github.com/users/sachinprasadhs/following{/other_user}", "gists_url": "https://api.github.com/users/sachinprasadhs/gists{/gist_id}", "starred_url": "https://api.github.com/users/sachinprasadhs/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sachinprasadhs/subscriptions", "organizations_url": "https://api.github.com/users/sachinprasadhs/orgs", "repos_url": "https://api.github.com/users/sachinprasadhs/repos", "events_url": "https://api.github.com/users/sachinprasadhs/events{/privacy}", "received_events_url": "https://api.github.com/users/sachinprasadhs/received_events", "type": "User", "site_admin": false } ]
null
[ "Hi @shkarupa-alex ,\r\n\r\nI am not sure whether this is better comparison of XLA performance or not. I have increased the `repeats` to 1000 and also found similar results. Please refer to attached [gist](https://colab.research.google.com/gist/SuryanarayanaY/ddd84ed3c829b1b5b15206fc4efb59c6/60312-conv-vs-depthwise-speed.ipynb#scrollTo=vtxDK4y79_7B).\r\n\r\n```\r\nstride-1 conv 44.51\r\nstride-1 conv_jit 64.96\r\nstride-1 sepconv 19.95\r\nstride-1 sepconv_jit 17.47\r\nstride-1 dwconv 9.0\r\nstride-1 dwconv_jit 5.89\r\n\r\nstride-2 conv 32.42\r\nstride-2 conv_jit 28.98\r\nstride-2 sepconv 5.18\r\nstride-2 sepconv_jit 6.97\r\nstride-2 dwconv 2.58\r\nstride-2 dwconv_jit 4.29\r\n```\r\n\r\n\r\n", "@shkarupa-alex @SuryanarayanaY Thanks for the bug! Would you be interested in pursuing this further? E.g. when looked under nsys systems profiler, are the kernel names different? A next step would be looking into `conv_algorithm_picker`, enabling logs and checking why in XLA:GPU a different kernel from cuDNN is chosen from TF." ]
2023-04-13T10:01:27
2023-05-11T10:07:14
null
CONTRIBUTOR
null
null
null
<details><summary>Click to expand!</summary> ### Issue Type Bug ### Have you reproduced the bug with TF nightly? Yes ### Source binary ### Tensorflow Version 2.12.0, 2.13.0-dev20230412 ### Custom Code Yes ### OS Platform and Distribution Google Colab ### Mobile device _No response_ ### Python version Google Colab ### Bazel version _No response_ ### GCC/Compiler version _No response_ ### CUDA/cuDNN version 11.8 ### GPU model and memory _No response_ ### Current Behaviour? See example below to reproduce. Here is speed test results: stride-1 conv 40.66 stride-1 conv_jit 64.11 // conv2d is slower with JIT but only if stride=1 stride-2 conv 40.18 stride-2 conv_jit 28.05 // when stride=2 it is FASTER with JIT stride-1 dwconv 9.82 stride-1 dwconv_jit 5.72 // dwconv is faster with JIT but only if stride=1 stride-2 dwconv 2.59 stride-2 dwconv_jit 4.2 // when stride=2 it is SLOWER with JIT ### Standalone code to reproduce the issue ```shell https://colab.research.google.com/drive/1zqqPVVKt4ILRA1rCoWjB1uOtB3D0hDc-?usp=sharing ``` ### Relevant log output _No response_</details>
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/60312/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/60312/timeline
null
null
false
https://api.github.com/repos/tensorflow/tensorflow/issues/60311
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/60311/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/60311/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/60311/events
https://github.com/tensorflow/tensorflow/pull/60311
1,665,989,113
PR_kwDOArmXAs5ONYj9
60,311
get data ranges for missing types
{ "login": "chenfeiyue-cfy", "id": 69809761, "node_id": "MDQ6VXNlcjY5ODA5NzYx", "avatar_url": "https://avatars.githubusercontent.com/u/69809761?v=4", "gravatar_id": "", "url": "https://api.github.com/users/chenfeiyue-cfy", "html_url": "https://github.com/chenfeiyue-cfy", "followers_url": "https://api.github.com/users/chenfeiyue-cfy/followers", "following_url": "https://api.github.com/users/chenfeiyue-cfy/following{/other_user}", "gists_url": "https://api.github.com/users/chenfeiyue-cfy/gists{/gist_id}", "starred_url": "https://api.github.com/users/chenfeiyue-cfy/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/chenfeiyue-cfy/subscriptions", "organizations_url": "https://api.github.com/users/chenfeiyue-cfy/orgs", "repos_url": "https://api.github.com/users/chenfeiyue-cfy/repos", "events_url": "https://api.github.com/users/chenfeiyue-cfy/events{/privacy}", "received_events_url": "https://api.github.com/users/chenfeiyue-cfy/received_events", "type": "User", "site_admin": false }
[ { "id": 750616506, "node_id": "MDU6TGFiZWw3NTA2MTY1MDY=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/comp:lite", "name": "comp:lite", "color": "0052cc", "default": false, "description": "TF Lite related issues" }, { "id": 987666414, "node_id": "MDU6TGFiZWw5ODc2NjY0MTQ=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/ready%20to%20pull", "name": "ready to pull", "color": "2cd643", "default": false, "description": "PR ready for merge process" }, { "id": 1169364259, "node_id": "MDU6TGFiZWwxMTY5MzY0MjU5", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/size:XS", "name": "size:XS", "color": "adafea", "default": false, "description": "CL Change Size: Extra Small" } ]
closed
false
{ "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false }
[ { "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false } ]
null
[ "Hi @alankelly Can you please review this PR ? Thank you!", "Hi @alankelly Can you please review this PR ? Thank you!", "Hi @alankelly Can you please review this PR ? Thank you!", "Thanks for spotting this, this is definitely a bug. Since this is only used for benchmarking, it doesn't impact correctness but should nevertheless be fixed" ]
2023-04-13T08:46:21
2023-10-04T08:16:53
2023-10-04T08:16:53
CONTRIBUTOR
null
false
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/pulls/60311", "html_url": "https://github.com/tensorflow/tensorflow/pull/60311", "diff_url": "https://github.com/tensorflow/tensorflow/pull/60311.diff", "patch_url": "https://github.com/tensorflow/tensorflow/pull/60311.patch", "merged_at": "2023-10-04T08:16:53" }
Hi,I 'm learning how to generate random data in tflite benchmark.However,I met this confusing code , and it doesn't seem to include datatype of int32 or uint32 and so on , I guess maybe the code should be like this ?If not, could you complete the range setting for Int32 and Uint32? It 's really important to me, thanks!
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/60311/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/60311/timeline
null
null
true
https://api.github.com/repos/tensorflow/tensorflow/issues/60310
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/60310/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/60310/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/60310/events
https://github.com/tensorflow/tensorflow/pull/60310
1,665,880,953
PR_kwDOArmXAs5ONBxL
60,310
[Pluggable Device] Add DEFAULT_DEVICE registrations for some ops.
{ "login": "kulinseth", "id": 453004, "node_id": "MDQ6VXNlcjQ1MzAwNA==", "avatar_url": "https://avatars.githubusercontent.com/u/453004?v=4", "gravatar_id": "", "url": "https://api.github.com/users/kulinseth", "html_url": "https://github.com/kulinseth", "followers_url": "https://api.github.com/users/kulinseth/followers", "following_url": "https://api.github.com/users/kulinseth/following{/other_user}", "gists_url": "https://api.github.com/users/kulinseth/gists{/gist_id}", "starred_url": "https://api.github.com/users/kulinseth/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kulinseth/subscriptions", "organizations_url": "https://api.github.com/users/kulinseth/orgs", "repos_url": "https://api.github.com/users/kulinseth/repos", "events_url": "https://api.github.com/users/kulinseth/events{/privacy}", "received_events_url": "https://api.github.com/users/kulinseth/received_events", "type": "User", "site_admin": false }
[ { "id": 390482148, "node_id": "MDU6TGFiZWwzOTA0ODIxNDg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/awaiting%20review", "name": "awaiting review", "color": "bc3869", "default": false, "description": "Pull request awaiting review" }, { "id": 987666414, "node_id": "MDU6TGFiZWw5ODc2NjY0MTQ=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/ready%20to%20pull", "name": "ready to pull", "color": "2cd643", "default": false, "description": "PR ready for merge process" }, { "id": 1169365494, "node_id": "MDU6TGFiZWwxMTY5MzY1NDk0", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/size:M", "name": "size:M", "color": "adafea", "default": false, "description": "CL Change Size: Medium" }, { "id": 1478826728, "node_id": "MDU6TGFiZWwxNDc4ODI2NzI4", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/comp:core", "name": "comp:core", "color": "024391", "default": false, "description": "issues related to core part of tensorflow" } ]
closed
false
{ "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false }
[ { "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false } ]
null
[ "> Ask discussed offline, all registrations in this PR had caused internal test failures and were reverted before, and the issues haven't been fixed yet. Please guard all device default registrations in this PR with macos ifdefs for now.\r\n\r\nThanks @penpornk , added them to be specific to macos.", "For the record: I had made the requested changes internally before merging the PR.", "> For the record: I had made the requested changes internally before merging the PR.\r\n\r\nThanks Penporn. Much appreciated." ]
2023-04-13T07:32:40
2023-04-27T20:51:03
2023-04-27T19:35:50
CONTRIBUTOR
null
false
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/pulls/60310", "html_url": "https://github.com/tensorflow/tensorflow/pull/60310", "diff_url": "https://github.com/tensorflow/tensorflow/pull/60310.diff", "patch_url": "https://github.com/tensorflow/tensorflow/pull/60310.patch", "merged_at": "2023-04-27T19:35:50" }
Adding some more registrations for commonly used ops to DEFAULT_DEVICE using CPU implementation. cc @penpornk
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/60310/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/60310/timeline
null
null
true
https://api.github.com/repos/tensorflow/tensorflow/issues/60309
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/60309/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/60309/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/60309/events
https://github.com/tensorflow/tensorflow/issues/60309
1,665,732,684
I_kwDOArmXAs5jSRBM
60,309
Training stopping because of BufferError: Existing exports of data: object cannot be re-sized or something wrong with tornado
{ "login": "CaffineAddic", "id": 92669518, "node_id": "U_kgDOBYYGTg", "avatar_url": "https://avatars.githubusercontent.com/u/92669518?v=4", "gravatar_id": "", "url": "https://api.github.com/users/CaffineAddic", "html_url": "https://github.com/CaffineAddic", "followers_url": "https://api.github.com/users/CaffineAddic/followers", "following_url": "https://api.github.com/users/CaffineAddic/following{/other_user}", "gists_url": "https://api.github.com/users/CaffineAddic/gists{/gist_id}", "starred_url": "https://api.github.com/users/CaffineAddic/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/CaffineAddic/subscriptions", "organizations_url": "https://api.github.com/users/CaffineAddic/orgs", "repos_url": "https://api.github.com/users/CaffineAddic/repos", "events_url": "https://api.github.com/users/CaffineAddic/events{/privacy}", "received_events_url": "https://api.github.com/users/CaffineAddic/received_events", "type": "User", "site_admin": false }
[ { "id": 404586594, "node_id": "MDU6TGFiZWw0MDQ1ODY1OTQ=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/stat:awaiting%20tensorflower", "name": "stat:awaiting tensorflower", "color": "f4b400", "default": false, "description": "Status - Awaiting response from tensorflower" }, { "id": 473172988, "node_id": "MDU6TGFiZWw0NzMxNzI5ODg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/type:bug", "name": "type:bug", "color": "159b2e", "default": false, "description": "Bug" }, { "id": 1097545817, "node_id": "MDU6TGFiZWwxMDk3NTQ1ODE3", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/comp:apis", "name": "comp:apis", "color": "0052cc", "default": false, "description": "Highlevel API related issues" }, { "id": 5206407904, "node_id": "LA_kwDOArmXAs8AAAABNlN64A", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/TF%202.12", "name": "TF 2.12", "color": "c5def5", "default": false, "description": "For issues related to Tensorflow 2.12" } ]
open
false
{ "login": "sachinprasadhs", "id": 73069040, "node_id": "MDQ6VXNlcjczMDY5MDQw", "avatar_url": "https://avatars.githubusercontent.com/u/73069040?v=4", "gravatar_id": "", "url": "https://api.github.com/users/sachinprasadhs", "html_url": "https://github.com/sachinprasadhs", "followers_url": "https://api.github.com/users/sachinprasadhs/followers", "following_url": "https://api.github.com/users/sachinprasadhs/following{/other_user}", "gists_url": "https://api.github.com/users/sachinprasadhs/gists{/gist_id}", "starred_url": "https://api.github.com/users/sachinprasadhs/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sachinprasadhs/subscriptions", "organizations_url": "https://api.github.com/users/sachinprasadhs/orgs", "repos_url": "https://api.github.com/users/sachinprasadhs/repos", "events_url": "https://api.github.com/users/sachinprasadhs/events{/privacy}", "received_events_url": "https://api.github.com/users/sachinprasadhs/received_events", "type": "User", "site_admin": false }
[ { "login": "sachinprasadhs", "id": 73069040, "node_id": "MDQ6VXNlcjczMDY5MDQw", "avatar_url": "https://avatars.githubusercontent.com/u/73069040?v=4", "gravatar_id": "", "url": "https://api.github.com/users/sachinprasadhs", "html_url": "https://github.com/sachinprasadhs", "followers_url": "https://api.github.com/users/sachinprasadhs/followers", "following_url": "https://api.github.com/users/sachinprasadhs/following{/other_user}", "gists_url": "https://api.github.com/users/sachinprasadhs/gists{/gist_id}", "starred_url": "https://api.github.com/users/sachinprasadhs/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sachinprasadhs/subscriptions", "organizations_url": "https://api.github.com/users/sachinprasadhs/orgs", "repos_url": "https://api.github.com/users/sachinprasadhs/repos", "events_url": "https://api.github.com/users/sachinprasadhs/events{/privacy}", "received_events_url": "https://api.github.com/users/sachinprasadhs/received_events", "type": "User", "site_admin": false } ]
null
[ "@CaffineAddic,\r\nI tried to execute the mentioned code with the tensorflow v2.12 and it was executed without any issues. Kindly find the gist of it [here](https://colab.research.google.com/gist/tilakrayal/acc1bef1d752d4e7a5ed36485d49a31f/voxelmorph_tutorial.ipynb) and also looks like the error which you stated was related to tensorflow.\r\n\r\nThe error which was mentioned was discussed in [Tornado issue 2008](https://github.com/tornadoweb/tornado/pull/2008). The current theory is that it only happens when threads are being used incorrectly, but this is not certain.\r\n[Reference](https://stackoverflow.com/questions/44405493/how-to-resolve-buffererror-existing-exports-of-data-object-cannot-be-re-sized). Thank you!", "Thanks for the reply, actually the code works well for 150 epochs with 100 steps per epoch but it stops with this error at any range of epochs from 70 to 200. ", "https://github.com/CaffineAddic/HybridMorph-proof-of-concept-.git\r\n\r\nCan you see if this one works, I used this code to train the models before but now after the update it's failing", "@CaffineAddic,\r\nWhile I was accessing the issue, I was unable to view any code in the above link. Could you please provide the colab gist which helps to analyse the issue in an effective way. Thank you!", "https://github.com/CaffineAddic/HybridMorph-proof-of-concept-/blob/main/HybridMorph_proof%20of%20concept.ipynb", "I am running it on my local machine \r\n", "Could you please provide the model_loc = 'Models/ and csv_loc = 'CSV/' datasets and the models which you are trying to execute the code in the reproducible format. Thank you!", "There is no data-set needed to run this \r\nOne of the data-set is provided by the library other one is generated during the execution.\r\nThose two location are just to store the model weights as .h5 file and the other has the location of the CSV file where it will store errors per step.\r\nJust keep both as random temp folder.\r\nThank you ", "Having the same issue right now while training models, tornado version 6.3.2 and tensorflow version 2.12.0.", "Anyone got any fix??", "@CaffineAddic,\r\nApologies for the delay. We are working on the issue and will update the status here. Thank you!", "Thanks a lot for the reply, Good luck.", "(also seeing this issue)", "@CaffineAddic @akellehe , Could you please try to provide more information on this to debug the root cause of the issue. \r\nAlso, are you facing the similar behavior in other environments as well?", "Yess, over multiple systems configurations, I have tried run it over multiple fresh installs of tf 2.12", "I am getting the same error and stacktrace with a pytorch model with MPS backend from a jupyter notebook. The model continues training, but output stops streaming to jupyter.\r\nI suspect the problem is actually with jupyter and that websocket that allows streaming data from the python backend to the output cell. ", "Did you find any fix for it ??", "Same here. The error just random shows up. Some times after 100 epochs, sometimes at much earlier.\r\n\r\n2023-07-26 17:43:54 [E 00:43:54.737 NotebookApp] Uncaught exception in zmqstream callback\r\n2023-07-26 17:43:54 Traceback (most recent call last):\r\n2023-07-26 17:43:54 File \"/usr/local/lib/python3.8/dist-packages/zmq/eventloop/zmqstream.py\", line 634, in _handle_events\r\n2023-07-26 17:43:54 self._handle_recv()\r\n2023-07-26 17:43:54 File \"/usr/local/lib/python3.8/dist-packages/zmq/eventloop/zmqstream.py\", line 663, in _handle_recv\r\n2023-07-26 17:43:54 self._run_callback(callback, msg)\r\n2023-07-26 17:43:54 File \"/usr/local/lib/python3.8/dist-packages/zmq/eventloop/zmqstream.py\", line 584, in _run_callback\r\n2023-07-26 17:43:54 f = callback(*args, **kwargs)\r\n2023-07-26 17:43:54 File \"/usr/local/lib/python3.8/dist-packages/zmq/eventloop/zmqstream.py\", line 308, in stream_callback\r\n2023-07-26 17:43:54 return callback(self, msg)\r\n2023-07-26 17:43:54 File \"/usr/local/lib/python3.8/dist-packages/notebook/services/kernels/handlers.py\", line 572, in _on_zmq_reply\r\n2023-07-26 17:43:54 super()._on_zmq_reply(stream, msg)\r\n2023-07-26 17:43:54 File \"/usr/local/lib/python3.8/dist-packages/notebook/base/zmqhandlers.py\", line 256, in _on_zmq_reply\r\n2023-07-26 17:43:54 self.write_message(msg, binary=isinstance(msg, bytes))\r\n2023-07-26 17:43:54 File \"/usr/local/lib/python3.8/dist-packages/tornado/websocket.py\", line 339, in write_message\r\n2023-07-26 17:43:54 return self.ws_connection.write_message(message, binary=binary)\r\n2023-07-26 17:43:54 File \"/usr/local/lib/python3.8/dist-packages/tornado/websocket.py\", line 1086, in write_message\r\n2023-07-26 17:43:54 fut = self._write_frame(True, opcode, message, flags=flags)\r\n2023-07-26 17:43:54 File \"/usr/local/lib/python3.8/dist-packages/tornado/websocket.py\", line 1061, in _write_frame\r\n2023-07-26 17:43:54 return self.stream.write(frame)\r\n2023-07-26 17:43:54 File \"/usr/local/lib/python3.8/dist-packages/tornado/iostream.py\", line 540, in write\r\n2023-07-26 17:43:54 self._write_buffer.append(data)\r\n2023-07-26 17:43:54 File \"/usr/local/lib/python3.8/dist-packages/tornado/iostream.py\", line 157, in append\r\n2023-07-26 17:43:54 b += data # type: ignore\r\n2023-07-26 17:43:54 BufferError: Existing exports of data: object cannot be re-sized\r\n2023-07-26 17:43:54 Exception in callback BaseAsyncIOLoop._handle_events(28, 1)\r\n2023-07-26 17:43:54 handle: <Handle BaseAsyncIOLoop._handle_events(28, 1)>\r\n2023-07-26 17:43:54 Traceback (most recent call last):\r\n2023-07-26 17:43:54 File \"/usr/lib/python3.8/asyncio/events.py\", line 81, in _run\r\n2023-07-26 17:43:54 self._context.run(self._callback, *self._args)\r\n2023-07-26 17:43:54 File \"/usr/local/lib/python3.8/dist-packages/tornado/platform/asyncio.py\", line 206, in _handle_events\r\n2023-07-26 17:43:54 handler_func(fileobj, events)\r\n2023-07-26 17:43:54 File \"/usr/local/lib/python3.8/dist-packages/zmq/eventloop/zmqstream.py\", line 634, in _handle_events\r\n2023-07-26 17:43:54 self._handle_recv()\r\n2023-07-26 17:43:54 File \"/usr/local/lib/python3.8/dist-packages/zmq/eventloop/zmqstream.py\", line 663, in _handle_recv\r\n2023-07-26 17:43:54 self._run_callback(callback, msg)\r\n2023-07-26 17:43:54 File \"/usr/local/lib/python3.8/dist-packages/zmq/eventloop/zmqstream.py\", line 584, in _run_callback\r\n2023-07-26 17:43:54 f = callback(*args, **kwargs)\r\n2023-07-26 17:43:54 File \"/usr/local/lib/python3.8/dist-packages/zmq/eventloop/zmqstream.py\", line 308, in stream_callback\r\n2023-07-26 17:43:54 return callback(self, msg)\r\n2023-07-26 17:43:54 File \"/usr/local/lib/python3.8/dist-packages/notebook/services/kernels/handlers.py\", line 572, in _on_zmq_reply\r\n2023-07-26 17:43:54 super()._on_zmq_reply(stream, msg)\r\n2023-07-26 17:43:54 File \"/usr/local/lib/python3.8/dist-packages/notebook/base/zmqhandlers.py\", line 256, in _on_zmq_reply\r\n2023-07-26 17:43:54 self.write_message(msg, binary=isinstance(msg, bytes))\r\n2023-07-26 17:43:54 File \"/usr/local/lib/python3.8/dist-packages/tornado/websocket.py\", line 339, in write_message\r\n2023-07-26 17:43:54 return self.ws_connection.write_message(message, binary=binary)\r\n2023-07-26 17:43:54 File \"/usr/local/lib/python3.8/dist-packages/tornado/websocket.py\", line 1086, in write_message\r\n2023-07-26 17:43:54 fut = self._write_frame(True, opcode, message, flags=flags)\r\n2023-07-26 17:43:54 File \"/usr/local/lib/python3.8/dist-packages/tornado/websocket.py\", line 1061, in _write_frame\r\n2023-07-26 17:43:54 return self.stream.write(frame)\r\n2023-07-26 17:43:54 File \"/usr/local/lib/python3.8/dist-packages/tornado/iostream.py\", line 540, in write\r\n2023-07-26 17:43:54 self._write_buffer.append(data)\r\n2023-07-26 17:43:54 File \"/usr/local/lib/python3.8/dist-packages/tornado/iostream.py\", line 157, in append\r\n2023-07-26 17:43:54 b += data # type: ignore\r\n2023-07-26 17:43:54 BufferError: Existing exports of data: object cannot be re-sized", "Some random times I was getting this error training the keras models and the training was being stopped.\r\nSeems like the problem is on threads sync streaming the large output.\r\n\r\nSo, turning off the verbose of **fit()** method worked for me.\r\n**i.e:** model.fit(trainX, trainY, ... , **verbose=0**)\r\n\r\nI guess you can also use **verbose=2** for showing just the final details for each epoch and it will work fine.", "I will test it thank you @tgoMota ", " Uncaught exception in ZMQStream callback\r\n Traceback (most recent call last):\r\n File \"/home/saumya/anaconda3/envs/tf/lib/python3.9/site-packages/zmq/event loop/zmqstream.py\", line 584, in _run_callback\r\n f = callback(*args, **kwargs)\r\n File \"/home/saumya/anaconda3/envs/tf/lib/python3.9/site-packages/zmq/event loop/zmqstream.py\", line 308, in stream_callback\r\n return callback(self, msg)\r\n File \"/home/saumya/anaconda3/envs/tf/lib/python3.9/site-packages/notebook/ services/kernels/handlers.py\", line 572, in _on_zmq_reply\r\n super()._on_zmq_reply(stream, msg)\r\n File \"/home/saumya/anaconda3/envs/tf/lib/python3.9/site-packages/notebook/ base/zmqhandlers.py\", line 256, in _on_zmq_reply\r\n self.write_message(msg, binary=isinstance(msg, bytes))\r\n File \"/home/saumya/anaconda3/envs/tf/lib/python3.9/site-packages/tornado/w ebsocket.py\", line 339, in write_message\r\n return self.ws_connection.write_message(message, binary=binary)\r\n File \"/home/saumya/anaconda3/envs/tf/lib/python3.9/site-packages/tornado/w ebsocket.py\", line 1086, in write_message\r\n fut = self._write_frame(True, opcode, message, flags=flags)\r\n File \"/home/saumya/anaconda3/envs/tf/lib/python3.9/site-packages/tornado/w ebsocket.py\", line 1061, in _write_frame\r\n return self.stream.write(frame)\r\n File \"/home/saumya/anaconda3/envs/tf/lib/python3.9/site-packages/tornado/i ostream.py\", line 546, in write\r\n self._handle_write()\r\n File \"/home/saumya/anaconda3/envs/tf/lib/python3.9/site-packages/tornado/i ostream.py\", line 976, in _handle_write\r\n self._write_buffer.advance(num_bytes)\r\n File \"/home/saumya/anaconda3/envs/tf/lib/python3.9/site-packages/tornado/i ostream.py\", line 182, in advance\r\n assert 0 < size <= self._size\r\n AssertionError\r\n[E 16:53:16.352 NotebookApp] Uncaught exception in zmqstream callback\r\n Traceback (most recent call last):\r\n File \"/home/saumya/anaconda3/envs/tf/lib/python3.9/site-packages/zmq/event loop/zmqstream.py\", line 634, in _handle_events\r\n self._handle_recv()\r\n File \"/home/saumya/anaconda3/envs/tf/lib/python3.9/site-packages/zmq/event loop/zmqstream.py\", line 663, in _handle_recv\r\n self._run_callback(callback, msg)\r\n File \"/home/saumya/anaconda3/envs/tf/lib/python3.9/site-packages/zmq/event loop/zmqstream.py\", line 584, in _run_callback\r\n f = callback(*args, **kwargs)\r\n File \"/home/saumya/anaconda3/envs/tf/lib/python3.9/site-packages/zmq/event loop/zmqstream.py\", line 308, in stream_callback\r\n return callback(self, msg)\r\n File \"/home/saumya/anaconda3/envs/tf/lib/python3.9/site-packages/notebook/ services/kernels/handlers.py\", line 572, in _on_zmq_reply\r\n super()._on_zmq_reply(stream, msg)\r\n File \"/home/saumya/anaconda3/envs/tf/lib/python3.9/site-packages/notebook/ base/zmqhandlers.py\", line 256, in _on_zmq_reply\r\n self.write_message(msg, binary=isinstance(msg, bytes))\r\n File \"/home/saumya/anaconda3/envs/tf/lib/python3.9/site-packages/tornado/w ebsocket.py\", line 339, in write_message\r\n return self.ws_connection.write_message(message, binary=binary)\r\n File \"/home/saumya/anaconda3/envs/tf/lib/python3.9/site-packages/tornado/w ebsocket.py\", line 1086, in write_message\r\n fut = self._write_frame(True, opcode, message, flags=flags)\r\n File \"/home/saumya/anaconda3/envs/tf/lib/python3.9/site-packages/tornado/w ebsocket.py\", line 1061, in _write_frame\r\n return self.stream.write(frame)\r\n File \"/home/saumya/anaconda3/envs/tf/lib/python3.9/site-packages/tornado/i ostream.py\", line 546, in write\r\n self._handle_write()\r\n File \"/home/saumya/anaconda3/envs/tf/lib/python3.9/site-packages/tornado/i ostream.py\", line 976, in _handle_write\r\n self._write_buffer.advance(num_bytes)\r\n File \"/home/saumya/anaconda3/envs/tf/lib/python3.9/site-packages/tornado/i ostream.py\", line 182, in advance\r\n assert 0 < size <= self._size\r\n AssertionError\r\nException in callback BaseAsyncIOLoop._handle_events(33, 1)\r\nhandle: <Handle BaseAsyncIOLoop._handle_events(33, 1)>\r\nTraceback (most recent call last):\r\n File \"/home/saumya/anaconda3/envs/tf/lib/python3.9/asyncio/events.py\", line 80 , in _run\r\n self._context.run(self._callback, *self._args)\r\n File \"/home/saumya/anaconda3/envs/tf/lib/python3.9/site-packages/tornado/platf orm/asyncio.py\", line 206, in _handle_events\r\n handler_func(fileobj, events)\r\n File \"/home/saumya/anaconda3/envs/tf/lib/python3.9/site-packages/zmq/eventloop /zmqstream.py\", line 634, in _handle_events\r\n self._handle_recv()\r\n File \"/home/saumya/anaconda3/envs/tf/lib/python3.9/site-packages/zmq/eventloop /zmqstream.py\", line 663, in _handle_recv\r\n self._run_callback(callback, msg)\r\n File \"/home/saumya/anaconda3/envs/tf/lib/python3.9/site-packages/zmq/eventloop /zmqstream.py\", line 584, in _run_callback\r\n f = callback(*args, **kwargs)\r\n File \"/home/saumya/anaconda3/envs/tf/lib/python3.9/site-packages/zmq/eventloop /zmqstream.py\", line 308, in stream_callback\r\n return callback(self, msg)\r\n File \"/home/saumya/anaconda3/envs/tf/lib/python3.9/site-packages/notebook/serv ices/kernels/handlers.py\", line 572, in _on_zmq_reply\r\n super()._on_zmq_reply(stream, msg)\r\n File \"/home/saumya/anaconda3/envs/tf/lib/python3.9/site-packages/notebook/base /zmqhandlers.py\", line 256, in _on_zmq_reply\r\n self.write_message(msg, binary=isinstance(msg, bytes))\r\n File \"/home/saumya/anaconda3/envs/tf/lib/python3.9/site-packages/tornado/webso cket.py\", line 339, in write_message\r\n return self.ws_connection.write_message(message, binary=binary)\r\n File \"/home/saumya/anaconda3/envs/tf/lib/python3.9/site-packages/tornado/webso cket.py\", line 1086, in write_message\r\n fut = self._write_frame(True, opcode, message, flags=flags)\r\n File \"/home/saumya/anaconda3/envs/tf/lib/python3.9/site-packages/tornado/webso cket.py\", line 1061, in _write_frame\r\n return self.stream.write(frame)\r\n File \"/home/saumya/anaconda3/envs/tf/lib/python3.9/site-packages/tornado/iostr eam.py\", line 546, in write\r\n self._handle_write()\r\n File \"/home/saumya/anaconda3/envs/tf/lib/python3.9/site-packages/tornado/iostr eam.py\", line 976, in _handle_write\r\n self._write_buffer.advance(num_bytes)\r\n File \"/home/saumya/anaconda3/envs/tf/lib/python3.9/site-packages/tornado/iostr eam.py\", line 182, in advance\r\n assert 0 < size <= self._size\r\nAssertionError\r\n\r\n\r\nStill this error is persistent @tgoMota ", "I've encountered the same or a similar issue with TF 2.13.\r\n\r\ndocker run --gpus all --rm -u $(id -u):$(id -g) -p 8888:8888 -p 6006:6006 -v $PWD/:/tf/david_home tensorflow/tensorflow:2.13.0-gpu-jupyter\r\n\r\nIn my case output of the notebook to Firefox has frozen but the training job still seems to be running. \r\nFWIW when I run the same notebook using TF 2.13 with the LambdaStack, this does not happen i.e. output works as expected.\r\n\r\nE 12:40:01.689 NotebookApp] Uncaught exception in ZMQStream callback\r\n Traceback (most recent call last):\r\n File \"/usr/local/lib/python3.8/dist-packages/zmq/eventloop/zmqstream.py\", line 584, in _run_callback\r\n f = callback(*args, **kwargs)\r\n File \"/usr/local/lib/python3.8/dist-packages/zmq/eventloop/zmqstream.py\", line 308, in stream_callback\r\n return callback(self, msg)\r\n File \"/usr/local/lib/python3.8/dist-packages/notebook/services/kernels/handlers.py\", line 572, in _on_zmq_reply\r\n super()._on_zmq_reply(stream, msg)\r\n File \"/usr/local/lib/python3.8/dist-packages/notebook/base/zmqhandlers.py\", line 256, in _on_zmq_reply\r\n self.write_message(msg, binary=isinstance(msg, bytes))\r\n File \"/usr/local/lib/python3.8/dist-packages/tornado/websocket.py\", line 334, in write_message\r\n return self.ws_connection.write_message(message, binary=binary)\r\n File \"/usr/local/lib/python3.8/dist-packages/tornado/websocket.py\", line 1081, in write_message\r\n fut = self._write_frame(True, opcode, message, flags=flags)\r\n File \"/usr/local/lib/python3.8/dist-packages/tornado/websocket.py\", line 1056, in _write_frame\r\n return self.stream.write(frame)\r\n File \"/usr/local/lib/python3.8/dist-packages/tornado/iostream.py\", line 533, in write\r\n self._write_buffer.append(data)\r\n File \"/usr/local/lib/python3.8/dist-packages/tornado/iostream.py\", line 157, in append\r\n b += data # type: ignore\r\n BufferError: Existing exports of data: object cannot be re-sized\r\n[E 12:40:01.691 NotebookApp] Uncaught exception in zmqstream callback\r\n Traceback (most recent call last):\r\n File \"/usr/local/lib/python3.8/dist-packages/zmq/eventloop/zmqstream.py\", line 634, in _handle_events\r\n self._handle_recv()\r\n File \"/usr/local/lib/python3.8/dist-packages/zmq/eventloop/zmqstream.py\", line 663, in _handle_recv\r\n self._run_callback(callback, msg)\r\n File \"/usr/local/lib/python3.8/dist-packages/zmq/eventloop/zmqstream.py\", line 584, in _run_callback\r\n f = callback(*args, **kwargs)\r\n File \"/usr/local/lib/python3.8/dist-packages/zmq/eventloop/zmqstream.py\", line 308, in stream_callback\r\n return callback(self, msg)\r\n File \"/usr/local/lib/python3.8/dist-packages/notebook/services/kernels/handlers.py\", line 572, in _on_zmq_reply\r\n super()._on_zmq_reply(stream, msg)\r\n File \"/usr/local/lib/python3.8/dist-packages/notebook/base/zmqhandlers.py\", line 256, in _on_zmq_reply\r\n self.write_message(msg, binary=isinstance(msg, bytes))\r\n File \"/usr/local/lib/python3.8/dist-packages/tornado/websocket.py\", line 334, in write_message\r\n return self.ws_connection.write_message(message, binary=binary)\r\n File \"/usr/local/lib/python3.8/dist-packages/tornado/websocket.py\", line 1081, in write_message\r\n fut = self._write_frame(True, opcode, message, flags=flags)\r\n File \"/usr/local/lib/python3.8/dist-packages/tornado/websocket.py\", line 1056, in _write_frame\r\n return self.stream.write(frame)\r\n File \"/usr/local/lib/python3.8/dist-packages/tornado/iostream.py\", line 533, in write\r\n self._write_buffer.append(data)\r\n File \"/usr/local/lib/python3.8/dist-packages/tornado/iostream.py\", line 157, in append\r\n b += data # type: ignore\r\n BufferError: Existing exports of data: object cannot be re-sized\r\nERROR:asyncio:Exception in callback BaseAsyncIOLoop._handle_events(29, 1)\r\nhandle: <Handle BaseAsyncIOLoop._handle_events(29, 1)>\r\nTraceback (most recent call last):\r\n File \"/usr/lib/python3.8/asyncio/events.py\", line 81, in _run\r\n self._context.run(self._callback, *self._args)\r\n File \"/usr/local/lib/python3.8/dist-packages/tornado/platform/asyncio.py\", line 192, in _handle_events\r\n handler_func(fileobj, events)\r\n File \"/usr/local/lib/python3.8/dist-packages/zmq/eventloop/zmqstream.py\", line 634, in _handle_events\r\n self._handle_recv()\r\n File \"/usr/local/lib/python3.8/dist-packages/zmq/eventloop/zmqstream.py\", line 663, in _handle_recv\r\n self._run_callback(callback, msg)\r\n File \"/usr/local/lib/python3.8/dist-packages/zmq/eventloop/zmqstream.py\", line 584, in _run_callback\r\n f = callback(*args, **kwargs)\r\n File \"/usr/local/lib/python3.8/dist-packages/zmq/eventloop/zmqstream.py\", line 308, in stream_callback\r\n return callback(self, msg)\r\n File \"/usr/local/lib/python3.8/dist-packages/notebook/services/kernels/handlers.py\", line 572, in _on_zmq_reply\r\n super()._on_zmq_reply(stream, msg)\r\n File \"/usr/local/lib/python3.8/dist-packages/notebook/base/zmqhandlers.py\", line 256, in _on_zmq_reply\r\n self.write_message(msg, binary=isinstance(msg, bytes))\r\n File \"/usr/local/lib/python3.8/dist-packages/tornado/websocket.py\", line 334, in write_message\r\n return self.ws_connection.write_message(message, binary=binary)\r\n File \"/usr/local/lib/python3.8/dist-packages/tornado/websocket.py\", line 1081, in write_message\r\n fut = self._write_frame(True, opcode, message, flags=flags)\r\n File \"/usr/local/lib/python3.8/dist-packages/tornado/websocket.py\", line 1056, in _write_frame\r\n return self.stream.write(frame)\r\n File \"/usr/local/lib/python3.8/dist-packages/tornado/iostream.py\", line 533, in write\r\n self._write_buffer.append(data)\r\n File \"/usr/local/lib/python3.8/dist-packages/tornado/iostream.py\", line 157, in append\r\n b += data # type: ignore\r\nBufferError: Existing exports of data: object cannot be re-sized\r\n", "as @tgoMota mentioned try keeping \r\n\r\n verbose=2 \r\n\r\nThis worked for me\r\n", "@CaffineAddic , Is this still an issue? if the issue is resolved by changing verbose=0 to verbose=2, could you please close the issue.\r\nAlso, use the latest TensorFlow version to get the latest updates. Thank you!", "Ya essentially allowed me to start training but I cannot comment on the rest of users, also shouldn't training should happen with the default verbose value, tornado errors are still there if you want to I can close this issue, Thank you for your time and support. ", " Exception in callback <bound method WebSocketMixin.send_ping of ZMQChannelsHandler(bccd1408-a4a4-4810-805f-d10d0d4585df)>\r\n Traceback (most recent call last):\r\n File \"/home/saumya/anaconda3/envs/tf/lib/python3.9/site-packages/tornado/ioloop.py\", line 921, in _run\r\n val = self.callback()\r\n File \"/home/saumya/anaconda3/envs/tf/lib/python3.9/site-packages/notebook/base/zmqhandlers.py\", line 188, in send_ping\r\n self.ping(b'')\r\n File \"/home/saumya/anaconda3/envs/tf/lib/python3.9/site-packages/tornado/websocket.py\", line 445, in ping\r\n self.ws_connection.write_ping(data)\r\n File \"/home/saumya/anaconda3/envs/tf/lib/python3.9/site-packages/tornado/websocket.py\", line 1101, in write_ping\r\n self._write_frame(True, 0x9, data)\r\n File \"/home/saumya/anaconda3/envs/tf/lib/python3.9/site-packages/tornado/websocket.py\", line 1061, in _write_frame\r\n return self.stream.write(frame)\r\n File \"/home/saumya/anaconda3/envs/tf/lib/python3.9/site-packages/tornado/iostream.py\", line 540, in write\r\n self._write_buffer.append(data)\r\n File \"/home/saumya/anaconda3/envs/tf/lib/python3.9/site-packages/tornado/iostream.py\", line 157, in append\r\n b += data # type: ignore\r\n BufferError: Existing exports of data: object cannot be re-sized\r\n[I 01:36:07.003 NotebookApp] Saving file at /New_BRaTS/Brain_data/HybridMorph_proof of concept.ipynb\r\n[E 01:36:28.774 NotebookApp] Uncaught exception in ZMQStream callback\r\n Traceback (most recent call last):\r\n File \"/home/saumya/anaconda3/envs/tf/lib/python3.9/site-packages/zmq/eventloop/zmqstream.py\", line 584, in _run_callback\r\n f = callback(*args, **kwargs)\r\n File \"/home/saumya/anaconda3/envs/tf/lib/python3.9/site-packages/zmq/eventloop/zmqstream.py\", line 308, in stream_callback\r\n return callback(self, msg)\r\n File \"/home/saumya/anaconda3/envs/tf/lib/python3.9/site-packages/notebook/services/kernels/handlers.py\", line 572, in _on_zmq_reply\r\n super()._on_zmq_reply(stream, msg)\r\n File \"/home/saumya/anaconda3/envs/tf/lib/python3.9/site-packages/notebook/base/zmqhandlers.py\", line 256, in _on_zmq_reply\r\n self.write_message(msg, binary=isinstance(msg, bytes))\r\n File \"/home/saumya/anaconda3/envs/tf/lib/python3.9/site-packages/tornado/websocket.py\", line 339, in write_message\r\n return self.ws_connection.write_message(message, binary=binary\r\n\r\nSame error with verbose = 2. Any fixes " ]
2023-04-13T05:24:00
2024-05-11T09:02:12
null
NONE
null
null
null
<details><summary>Click to expand!</summary> ### Issue Type Bug ### Have you reproduced the bug with TF nightly? No ### Source source ### Tensorflow Version 2.12.0 ### Custom Code Yes ### OS Platform and Distribution NAME="CentOS Linux" VERSION="7 (Core)" ### Mobile device NAME="CentOS Linux" VERSION="7 (Core)" ### Python version 3.9.16 ### Bazel version _No response_ ### GCC/Compiler version _No response_ ### CUDA/cuDNN version 11.8.0 ### GPU model and memory _No response_ ### Current Behaviour? The model training would just stop abruptly https://colab.research.google.com/drive/1WiqyF7dCdnNBIANEY80Pxw_mVz4fyV-S?usp=sharing ### Standalone code to reproduce the issue ```shell Voxelmoprh library training ``` ### Relevant log output ```shell (tf) vr-lab@pop-os:~$ jupyter notebook _ _ _ _ | | | |_ __ __| |__ _| |_ ___ | |_| | '_ \/ _` / _` | _/ -_) \___/| .__/\__,_\__,_|\__\___| |_| Read the migration plan to Notebook 7 to learn about the new features and the actions to take if you are using extensions. https://jupyter-notebook.readthedocs.io/en/latest/migrate_to_notebook7.html Please note that updating to Notebook 7 might break some of your extensions. [I 00:02:49.290 NotebookApp] Serving notebooks from local directory: /home/vr-lab [I 00:02:49.290 NotebookApp] Jupyter Notebook 6.5.4 is running at: [I 00:02:49.290 NotebookApp] http://localhost:8888/?token=697572ae046e4388d22c7be946cefcb261064994d2f99466 [I 00:02:49.290 NotebookApp] or http://127.0.0.1:8888/?token=697572ae046e4388d22c7be946cefcb261064994d2f99466 [I 00:02:49.290 NotebookApp] Use Control-C to stop this server and shut down all kernels (twice to skip confirmation). [C 00:02:49.334 NotebookApp] To access the notebook, open this file in a browser: file:///home/vr-lab/.local/share/jupyter/runtime/nbserver-405435-open.html Or copy and paste one of these URLs: http://localhost:8888/?token=697572ae046e4388d22c7be946cefcb261064994d2f99466 or http://127.0.0.1:8888/?token=697572ae046e4388d22c7be946cefcb261064994d2f99466 [I 00:03:15.170 NotebookApp] Kernel started: 4915aa8a-d4aa-4d50-885f-810d53eae7db, name: python3 [I 00:03:20.670 NotebookApp] Kernel restarted: 4915aa8a-d4aa-4d50-885f-810d53eae7db [W 00:03:20.684 NotebookApp] Replacing stale connection: 4915aa8a-d4aa-4d50-885f-810d53eae7db:e6146c4b818f471185049a02ac632f6d [W 00:03:21.180 NotebookApp] zmq message arrived on closed channel [I 00:03:21.181 NotebookApp] Starting buffering for 4915aa8a-d4aa-4d50-885f-810d53eae7db:e6146c4b818f471185049a02ac632f6d [I 00:03:21.183 NotebookApp] Restoring connection for 4915aa8a-d4aa-4d50-885f-810d53eae7db:e6146c4b818f471185049a02ac632f6d [I 00:03:21.689 NotebookApp] Replaying 1 buffered messages [E 00:03:21.761 NotebookApp] Uncaught exception, closing connection. Traceback (most recent call last): File "/home/vr-lab/anaconda3/envs/tf/lib/python3.9/site-packages/tornado/iostream.py", line 702, in _handle_events self._handle_write() File "/home/vr-lab/anaconda3/envs/tf/lib/python3.9/site-packages/tornado/iostream.py", line 976, in _handle_write self._write_buffer.advance(num_bytes) File "/home/vr-lab/anaconda3/envs/tf/lib/python3.9/site-packages/tornado/iostream.py", line 182, in advance assert 0 < size <= self._size AssertionError [W 00:03:21.764 NotebookApp] Write error on <socket.socket [closed] fd=-1, family=AddressFamily.AF_INET, type=SocketKind.SOCK_STREAM, proto=6>: [Errno 9] Bad file descriptor [W 00:03:21.766 NotebookApp] zmq message arrived on closed channel [W 00:03:21.767 NotebookApp] zmq message arrived on closed channel Exception in callback None() handle: <Handle cancelled> Traceback (most recent call last): File "/home/vr-lab/anaconda3/envs/tf/lib/python3.9/asyncio/events.py", line 80, in _run self._context.run(self._callback, *self._args) File "/home/vr-lab/anaconda3/envs/tf/lib/python3.9/site-packages/tornado/platform/asyncio.py", line 206, in _handle_events handler_func(fileobj, events) File "/home/vr-lab/anaconda3/envs/tf/lib/python3.9/site-packages/tornado/iostream.py", line 702, in _handle_events self._handle_write() File "/home/vr-lab/anaconda3/envs/tf/lib/python3.9/site-packages/tornado/iostream.py", line 976, in _handle_write self._write_buffer.advance(num_bytes) File "/home/vr-lab/anaconda3/envs/tf/lib/python3.9/site-packages/tornado/iostream.py", line 182, in advance assert 0 < size <= self._size AssertionError [I 00:03:21.768 NotebookApp] Starting buffering for 4915aa8a-d4aa-4d50-885f-810d53eae7db:e6146c4b818f471185049a02ac632f6d 2023-04-11 00:03:22.084618: I tensorflow/core/platform/cpu_feature_guard.cc:193] This TensorFlow binary is optimized with oneAPI Deep Neural Network Library (oneDNN) to use the following CPU instructions in performance-critical operations: AVX2 AVX512F AVX512_VNNI FMA To enable them in other operations, rebuild TensorFlow with the appropriate compiler flags. 2023-04-11 00:03:22.225493: I tensorflow/core/util/port.cc:104] oneDNN custom operations are on. You may see slightly different numerical results due to floating-point round-off errors from different computation orders. To turn them off, set the environment variable `TF_ENABLE_ONEDNN_OPTS=0`. [I 00:03:22.803 NotebookApp] Restoring connection for 4915aa8a-d4aa-4d50-885f-810d53eae7db:e6146c4b818f471185049a02ac632f6d [I 00:03:22.803 NotebookApp] Replaying 1 buffered messages 2023-04-11 00:03:22.815590: W tensorflow/compiler/xla/stream_executor/platform/default/dso_loader.cc:64] Could not load dynamic library 'libnvinfer.so.7'; dlerror: libnvinfer.so.7: cannot open shared object file: No such file or directory; LD_LIBRARY_PATH: :/home/vr-lab/anaconda3/envs/tf/lib/:/home/vr-lab/anaconda3/envs/tf/lib/python3.9/site-packages/nvidia/cudnn/lib 2023-04-11 00:03:22.815709: W tensorflow/compiler/xla/stream_executor/platform/default/dso_loader.cc:64] Could not load dynamic library 'libnvinfer_plugin.so.7'; dlerror: libnvinfer_plugin.so.7: cannot open shared object file: No such file or directory; LD_LIBRARY_PATH: :/home/vr-lab/anaconda3/envs/tf/lib/:/home/vr-lab/anaconda3/envs/tf/lib/python3.9/site-packages/nvidia/cudnn/lib 2023-04-11 00:03:22.815716: W tensorflow/compiler/tf2tensorrt/utils/py_utils.cc:38] TF-TRT Warning: Cannot dlopen some TensorRT libraries. If you would like to use Nvidia GPU with TensorRT, please make sure the missing libraries mentioned above are installed properly. 2023-04-11 00:03:25.015062: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1613] Created device /job:localhost/replica:0/task:0/device:GPU:0 with 12776 MB memory: -> device: 0, name: NVIDIA RTX A4000, pci bus id: 0000:af:00.0, compute capability: 8.6 2023-04-11 00:03:40.078576: I tensorflow/compiler/xla/stream_executor/cuda/cuda_dnn.cc:428] Loaded cuDNN version 8600 [I 00:05:15.159 NotebookApp] Saving file at /Music/HybridMorph Please don't delete/HybridMorph_proof of concept.ipynb Task exception was never retrieved future: <Task finished name='Task-76' coro=<WebSocketProtocol13.write_message.<locals>.wrapper() done, defined at /home/vr-lab/anaconda3/envs/tf/lib/python3.9/site-packages/tornado/websocket.py:1090> exception=WebSocketClosedError()> Traceback (most recent call last): File "/home/vr-lab/anaconda3/envs/tf/lib/python3.9/site-packages/tornado/websocket.py", line 1092, in wrapper await fut tornado.iostream.StreamClosedError: Stream is closed During handling of the above exception, another exception occurred: Traceback (most recent call last): File "/home/vr-lab/anaconda3/envs/tf/lib/python3.9/asyncio/tasks.py", line 256, in __step result = coro.send(None) File "/home/vr-lab/anaconda3/envs/tf/lib/python3.9/site-packages/tornado/websocket.py", line 1094, in wrapper raise WebSocketClosedError() tornado.websocket.WebSocketClosedError [E 01:03:52.904 NotebookApp] Exception in callback <bound method WebSocketMixin.send_ping of ZMQChannelsHandler(4915aa8a-d4aa-4d50-885f-810d53eae7db)> Traceback (most recent call last): File "/home/vr-lab/anaconda3/envs/tf/lib/python3.9/site-packages/tornado/ioloop.py", line 921, in _run val = self.callback() File "/home/vr-lab/anaconda3/envs/tf/lib/python3.9/site-packages/notebook/base/zmqhandlers.py", line 188, in send_ping self.ping(b'') File "/home/vr-lab/anaconda3/envs/tf/lib/python3.9/site-packages/tornado/websocket.py", line 445, in ping self.ws_connection.write_ping(data) File "/home/vr-lab/anaconda3/envs/tf/lib/python3.9/site-packages/tornado/websocket.py", line 1101, in write_ping self._write_frame(True, 0x9, data) File "/home/vr-lab/anaconda3/envs/tf/lib/python3.9/site-packages/tornado/websocket.py", line 1061, in _write_frame return self.stream.write(frame) File "/home/vr-lab/anaconda3/envs/tf/lib/python3.9/site-packages/tornado/iostream.py", line 540, in write self._write_buffer.append(data) File "/home/vr-lab/anaconda3/envs/tf/lib/python3.9/site-packages/tornado/iostream.py", line 157, in append b += data # type: ignore BufferError: Existing exports of data: object cannot be re-sized [E 01:13:22.812 NotebookApp] Uncaught exception in ZMQStream callback Traceback (most recent call last): File "/home/vr-lab/anaconda3/envs/tf/lib/python3.9/site-packages/zmq/eventloop/zmqstream.py", line 584, in _run_callback f = callback(*args, **kwargs) File "/home/vr-lab/anaconda3/envs/tf/lib/python3.9/site-packages/zmq/eventloop/zmqstream.py", line 308, in stream_callback return callback(self, msg) File "/home/vr-lab/anaconda3/envs/tf/lib/python3.9/site-packages/notebook/services/kernels/handlers.py", line 572, in _on_zmq_reply super()._on_zmq_reply(stream, msg) File "/home/vr-lab/anaconda3/envs/tf/lib/python3.9/site-packages/notebook/base/zmqhandlers.py", line 256, in _on_zmq_reply self.write_message(msg, binary=isinstance(msg, bytes)) File "/home/vr-lab/anaconda3/envs/tf/lib/python3.9/site-packages/tornado/websocket.py", line 339, in write_message return self.ws_connection.write_message(message, binary=binary) File "/home/vr-lab/anaconda3/envs/tf/lib/python3.9/site-packages/tornado/websocket.py", line 1086, in write_message fut = self._write_frame(True, opcode, message, flags=flags) File "/home/vr-lab/anaconda3/envs/tf/lib/python3.9/site-packages/tornado/websocket.py", line 1061, in _write_frame return self.stream.write(frame) File "/home/vr-lab/anaconda3/envs/tf/lib/python3.9/site-packages/tornado/iostream.py", line 540, in write self._write_buffer.append(data) File "/home/vr-lab/anaconda3/envs/tf/lib/python3.9/site-packages/tornado/iostream.py", line 157, in append b += data # type: ignore BufferError: Existing exports of data: object cannot be re-sized [E 01:13:22.815 NotebookApp] Uncaught exception in zmqstream callback Traceback (most recent call last): File "/home/vr-lab/anaconda3/envs/tf/lib/python3.9/site-packages/zmq/eventloop/zmqstream.py", line 634, in _handle_events self._handle_recv() File "/home/vr-lab/anaconda3/envs/tf/lib/python3.9/site-packages/zmq/eventloop/zmqstream.py", line 663, in _handle_recv self._run_callback(callback, msg) File "/home/vr-lab/anaconda3/envs/tf/lib/python3.9/site-packages/zmq/eventloop/zmqstream.py", line 584, in _run_callback f = callback(*args, **kwargs) File "/home/vr-lab/anaconda3/envs/tf/lib/python3.9/site-packages/zmq/eventloop/zmqstream.py", line 308, in stream_callback return callback(self, msg) File "/home/vr-lab/anaconda3/envs/tf/lib/python3.9/site-packages/notebook/services/kernels/handlers.py", line 572, in _on_zmq_reply super()._on_zmq_reply(stream, msg) File "/home/vr-lab/anaconda3/envs/tf/lib/python3.9/site-packages/notebook/base/zmqhandlers.py", line 256, in _on_zmq_reply self.write_message(msg, binary=isinstance(msg, bytes)) File "/home/vr-lab/anaconda3/envs/tf/lib/python3.9/site-packages/tornado/websocket.py", line 339, in write_message return self.ws_connection.write_message(message, binary=binary) File "/home/vr-lab/anaconda3/envs/tf/lib/python3.9/site-packages/tornado/websocket.py", line 1086, in write_message fut = self._write_frame(True, opcode, message, flags=flags) File "/home/vr-lab/anaconda3/envs/tf/lib/python3.9/site-packages/tornado/websocket.py", line 1061, in _write_frame return self.stream.write(frame) File "/home/vr-lab/anaconda3/envs/tf/lib/python3.9/site-packages/tornado/iostream.py", line 540, in write self._write_buffer.append(data) File "/home/vr-lab/anaconda3/envs/tf/lib/python3.9/site-packages/tornado/iostream.py", line 157, in append b += data # type: ignore BufferError: Existing exports of data: object cannot be re-sized [E 01:13:22.815 NotebookApp] Exception in callback functools.partial(<function ZMQStream._update_handler.<locals>.<lambda> at 0x7f1de4ff4b80>) Traceback (most recent call last): File "/home/vr-lab/anaconda3/envs/tf/lib/python3.9/site-packages/tornado/ioloop.py", line 740, in _run_callback ret = callback() File "/home/vr-lab/anaconda3/envs/tf/lib/python3.9/site-packages/zmq/eventloop/zmqstream.py", line 718, in <lambda> self.io_loop.add_callback(lambda: self._handle_events(self.socket, 0)) File "/home/vr-lab/anaconda3/envs/tf/lib/python3.9/site-packages/zmq/eventloop/zmqstream.py", line 634, in _handle_events self._handle_recv() File "/home/vr-lab/anaconda3/envs/tf/lib/python3.9/site-packages/zmq/eventloop/zmqstream.py", line 663, in _handle_recv self._run_callback(callback, msg) File "/home/vr-lab/anaconda3/envs/tf/lib/python3.9/site-packages/zmq/eventloop/zmqstream.py", line 584, in _run_callback f = callback(*args, **kwargs) File "/home/vr-lab/anaconda3/envs/tf/lib/python3.9/site-packages/zmq/eventloop/zmqstream.py", line 308, in stream_callback return callback(self, msg) File "/home/vr-lab/anaconda3/envs/tf/lib/python3.9/site-packages/notebook/services/kernels/handlers.py", line 572, in _on_zmq_reply super()._on_zmq_reply(stream, msg) File "/home/vr-lab/anaconda3/envs/tf/lib/python3.9/site-packages/notebook/base/zmqhandlers.py", line 256, in _on_zmq_reply self.write_message(msg, binary=isinstance(msg, bytes)) File "/home/vr-lab/anaconda3/envs/tf/lib/python3.9/site-packages/tornado/websocket.py", line 339, in write_message return self.ws_connection.write_message(message, binary=binary) File "/home/vr-lab/anaconda3/envs/tf/lib/python3.9/site-packages/tornado/websocket.py", line 1086, in write_message fut = self._write_frame(True, opcode, message, flags=flags) File "/home/vr-lab/anaconda3/envs/tf/lib/python3.9/site-packages/tornado/websocket.py", line 1061, in _write_frame return self.stream.write(frame) File "/home/vr-lab/anaconda3/envs/tf/lib/python3.9/site-packages/tornado/iostream.py", line 540, in write self._write_buffer.append(data) File "/home/vr-lab/anaconda3/envs/tf/lib/python3.9/site-packages/tornado/iostream.py", line 157, in append b += data # type: ignore BufferError: Existing exports of data: object cannot be re-sized ``` </details>
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/60309/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/60309/timeline
null
null
false
https://api.github.com/repos/tensorflow/tensorflow/issues/60308
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/60308/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/60308/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/60308/events
https://github.com/tensorflow/tensorflow/issues/60308
1,665,522,552
I_kwDOArmXAs5jRdt4
60,308
use ESRGAN super resolution on iOS device by TensorFlowLiteSwift, the output is not identical as the output in python env.
{ "login": "OwenHongJinmu", "id": 7868069, "node_id": "MDQ6VXNlcjc4NjgwNjk=", "avatar_url": "https://avatars.githubusercontent.com/u/7868069?v=4", "gravatar_id": "", "url": "https://api.github.com/users/OwenHongJinmu", "html_url": "https://github.com/OwenHongJinmu", "followers_url": "https://api.github.com/users/OwenHongJinmu/followers", "following_url": "https://api.github.com/users/OwenHongJinmu/following{/other_user}", "gists_url": "https://api.github.com/users/OwenHongJinmu/gists{/gist_id}", "starred_url": "https://api.github.com/users/OwenHongJinmu/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/OwenHongJinmu/subscriptions", "organizations_url": "https://api.github.com/users/OwenHongJinmu/orgs", "repos_url": "https://api.github.com/users/OwenHongJinmu/repos", "events_url": "https://api.github.com/users/OwenHongJinmu/events{/privacy}", "received_events_url": "https://api.github.com/users/OwenHongJinmu/received_events", "type": "User", "site_admin": false }
[ { "id": 386191887, "node_id": "MDU6TGFiZWwzODYxOTE4ODc=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/stat:awaiting%20response", "name": "stat:awaiting response", "color": "f4b400", "default": false, "description": "Status - Awaiting response from author" }, { "id": 474725938, "node_id": "MDU6TGFiZWw0NzQ3MjU5Mzg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/stale", "name": "stale", "color": "d4c5f9", "default": false, "description": "This label marks the issue/pr stale - to be closed automatically if no activity" }, { "id": 750616506, "node_id": "MDU6TGFiZWw3NTA2MTY1MDY=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/comp:lite", "name": "comp:lite", "color": "0052cc", "default": false, "description": "TF Lite related issues" }, { "id": 1463677878, "node_id": "MDU6TGFiZWwxNDYzNjc3ODc4", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/type:performance", "name": "type:performance", "color": "159b2e", "default": false, "description": "Performance Issue" }, { "id": 2689451671, "node_id": "MDU6TGFiZWwyNjg5NDUxNjcx", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/comp:lite-examples", "name": "comp:lite-examples", "color": "06C2A1", "default": false, "description": "TensorFlow Lite Examples" } ]
closed
false
{ "login": "pjpratik", "id": 118897289, "node_id": "U_kgDOBxY6iQ", "avatar_url": "https://avatars.githubusercontent.com/u/118897289?v=4", "gravatar_id": "", "url": "https://api.github.com/users/pjpratik", "html_url": "https://github.com/pjpratik", "followers_url": "https://api.github.com/users/pjpratik/followers", "following_url": "https://api.github.com/users/pjpratik/following{/other_user}", "gists_url": "https://api.github.com/users/pjpratik/gists{/gist_id}", "starred_url": "https://api.github.com/users/pjpratik/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/pjpratik/subscriptions", "organizations_url": "https://api.github.com/users/pjpratik/orgs", "repos_url": "https://api.github.com/users/pjpratik/repos", "events_url": "https://api.github.com/users/pjpratik/events{/privacy}", "received_events_url": "https://api.github.com/users/pjpratik/received_events", "type": "User", "site_admin": false }
[ { "login": "pjpratik", "id": 118897289, "node_id": "U_kgDOBxY6iQ", "avatar_url": "https://avatars.githubusercontent.com/u/118897289?v=4", "gravatar_id": "", "url": "https://api.github.com/users/pjpratik", "html_url": "https://github.com/pjpratik", "followers_url": "https://api.github.com/users/pjpratik/followers", "following_url": "https://api.github.com/users/pjpratik/following{/other_user}", "gists_url": "https://api.github.com/users/pjpratik/gists{/gist_id}", "starred_url": "https://api.github.com/users/pjpratik/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/pjpratik/subscriptions", "organizations_url": "https://api.github.com/users/pjpratik/orgs", "repos_url": "https://api.github.com/users/pjpratik/repos", "events_url": "https://api.github.com/users/pjpratik/events{/privacy}", "received_events_url": "https://api.github.com/users/pjpratik/received_events", "type": "User", "site_admin": false } ]
null
[ "the tflite model is convert from https://tfhub.dev/captain-pool/esrgan-tf2/1", "@OwenHongJinmu \r\nCould you please elaborate more and provide detailed steps to replicate the issue reported here ?\r\n\r\nThank you !", "This issue is stale because it has been open for 7 days with no activity. It will be closed if no further activity occurs. Thank you.", "Hi @OwenHongJinmu \r\n\r\nThe TFLite model converted from the TF model might loose some accuracy because of quantization.\r\n\r\nYou can keep the float model by turning off the optimization by `converter.optimizations =[]` while converting the model to TFLite which can preserve better accuracy.\r\n\r\nThanks.\r\n\r\n", "This issue is stale because it has been open for 7 days with no activity. It will be closed if no further activity occurs. Thank you.", "This issue was closed because it has been inactive for 7 days since being marked as stale. Please reopen if you'd like to work on this further.", "Are you satisfied with the resolution of your issue?\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=Yes&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/60308\">Yes</a>\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=No&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/60308\">No</a>\n" ]
2023-04-13T01:36:04
2023-05-11T01:54:17
2023-05-11T01:53:58
NONE
null
null
null
I use the sample image for ESRGAN lr-1 ![lr1](https://user-images.githubusercontent.com/7868069/231623423-1431788d-dc0c-451e-9e52-d811f410276c.jpg) and inference by TensorFlowLiteSwift, compared with python env in Colab , the input pixel data array was identical, but the output pixel data was different totally。partial output data: iOS: [[[ 59. 78. 70.] [ 77. 137. 42.] [ 76. 136. 79.] ... Colab:[[[ 59. 79. 71.] [ 72. 103. 72.] [ 86. 124. 65.] ...
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/60308/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/60308/timeline
null
completed
false
https://api.github.com/repos/tensorflow/tensorflow/issues/60307
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/60307/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/60307/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/60307/events
https://github.com/tensorflow/tensorflow/pull/60307
1,665,423,762
PR_kwDOArmXAs5OLgAT
60,307
[oneDNN v3.x]: Support for convolution (fwd + bwd) and transpose
{ "login": "bhavani-subramanian", "id": 28113241, "node_id": "MDQ6VXNlcjI4MTEzMjQx", "avatar_url": "https://avatars.githubusercontent.com/u/28113241?v=4", "gravatar_id": "", "url": "https://api.github.com/users/bhavani-subramanian", "html_url": "https://github.com/bhavani-subramanian", "followers_url": "https://api.github.com/users/bhavani-subramanian/followers", "following_url": "https://api.github.com/users/bhavani-subramanian/following{/other_user}", "gists_url": "https://api.github.com/users/bhavani-subramanian/gists{/gist_id}", "starred_url": "https://api.github.com/users/bhavani-subramanian/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/bhavani-subramanian/subscriptions", "organizations_url": "https://api.github.com/users/bhavani-subramanian/orgs", "repos_url": "https://api.github.com/users/bhavani-subramanian/repos", "events_url": "https://api.github.com/users/bhavani-subramanian/events{/privacy}", "received_events_url": "https://api.github.com/users/bhavani-subramanian/received_events", "type": "User", "site_admin": false }
[ { "id": 390482148, "node_id": "MDU6TGFiZWwzOTA0ODIxNDg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/awaiting%20review", "name": "awaiting review", "color": "bc3869", "default": false, "description": "Pull request awaiting review" }, { "id": 987666414, "node_id": "MDU6TGFiZWw5ODc2NjY0MTQ=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/ready%20to%20pull", "name": "ready to pull", "color": "2cd643", "default": false, "description": "PR ready for merge process" }, { "id": 1104829434, "node_id": "MDU6TGFiZWwxMTA0ODI5NDM0", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/comp:mkl", "name": "comp:mkl", "color": "0052cc", "default": false, "description": "MKL related issues" }, { "id": 1169365682, "node_id": "MDU6TGFiZWwxMTY5MzY1Njgy", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/size:L", "name": "size:L", "color": "adafea", "default": false, "description": "CL Change Size: Large" } ]
closed
false
{ "login": "penpornk", "id": 38085909, "node_id": "MDQ6VXNlcjM4MDg1OTA5", "avatar_url": "https://avatars.githubusercontent.com/u/38085909?v=4", "gravatar_id": "", "url": "https://api.github.com/users/penpornk", "html_url": "https://github.com/penpornk", "followers_url": "https://api.github.com/users/penpornk/followers", "following_url": "https://api.github.com/users/penpornk/following{/other_user}", "gists_url": "https://api.github.com/users/penpornk/gists{/gist_id}", "starred_url": "https://api.github.com/users/penpornk/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/penpornk/subscriptions", "organizations_url": "https://api.github.com/users/penpornk/orgs", "repos_url": "https://api.github.com/users/penpornk/repos", "events_url": "https://api.github.com/users/penpornk/events{/privacy}", "received_events_url": "https://api.github.com/users/penpornk/received_events", "type": "User", "site_admin": false }
[ { "login": "penpornk", "id": 38085909, "node_id": "MDQ6VXNlcjM4MDg1OTA5", "avatar_url": "https://avatars.githubusercontent.com/u/38085909?v=4", "gravatar_id": "", "url": "https://api.github.com/users/penpornk", "html_url": "https://github.com/penpornk", "followers_url": "https://api.github.com/users/penpornk/followers", "following_url": "https://api.github.com/users/penpornk/following{/other_user}", "gists_url": "https://api.github.com/users/penpornk/gists{/gist_id}", "starred_url": "https://api.github.com/users/penpornk/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/penpornk/subscriptions", "organizations_url": "https://api.github.com/users/penpornk/orgs", "repos_url": "https://api.github.com/users/penpornk/repos", "events_url": "https://api.github.com/users/penpornk/events{/privacy}", "received_events_url": "https://api.github.com/users/penpornk/received_events", "type": "User", "site_admin": false }, { "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false } ]
null
[ "@penpornk Thank you reviewing this PR! I have addressed your review comments. Please take a look." ]
2023-04-12T23:55:34
2023-04-15T19:05:42
2023-04-15T19:05:41
CONTRIBUTOR
null
false
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/pulls/60307", "html_url": "https://github.com/tensorflow/tensorflow/pull/60307", "diff_url": "https://github.com/tensorflow/tensorflow/pull/60307.diff", "patch_url": "https://github.com/tensorflow/tensorflow/pull/60307.patch", "merged_at": "2023-04-15T19:05:41" }
- This PR adds support for oneDNN v3.x in: a) Convolution (fwd + bwd) for fp32 and bf16 b) Transpose and conjugate transpose for all types - Since oneDNN v3.x is not API backward compatible with oneDNN v2.x, this PR wraps all oneDNN kernels (except those listed above) with `#ifndef ENABLE_ONEDNN_V3` . The rewrite of all these ops are also prevented in mkl_layout pass, so when TF is compiled with oneDNN v3.x, these ops will fallback to Eigen-based implementation. The PR passes all unit tests related to convolution ops for fp32/bf16 when oneDNN v3.x is enabled. - Future PRs will enable remaining oneDNN kernels (implemented under `core/kernels/mkl/...`) by removing the macro `#ifndef ENABLE_ONEDNN_V3` around the kernel definition for the ops. - Support for int8 convolution will be added in a separate PR. - This PR (and future PRs related to oneDNN v3.x) does not add or affect Eigen ops and are specific only to oneDNN kernels.
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/60307/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/60307/timeline
null
null
true
https://api.github.com/repos/tensorflow/tensorflow/issues/60306
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/60306/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/60306/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/60306/events
https://github.com/tensorflow/tensorflow/pull/60306
1,665,322,860
PR_kwDOArmXAs5OLKMF
60,306
[NVIDIA XLA] Fix Fp32 biasAdd fusion for FP8 cublasLt matmul
{ "login": "wenscarl", "id": 25590028, "node_id": "MDQ6VXNlcjI1NTkwMDI4", "avatar_url": "https://avatars.githubusercontent.com/u/25590028?v=4", "gravatar_id": "", "url": "https://api.github.com/users/wenscarl", "html_url": "https://github.com/wenscarl", "followers_url": "https://api.github.com/users/wenscarl/followers", "following_url": "https://api.github.com/users/wenscarl/following{/other_user}", "gists_url": "https://api.github.com/users/wenscarl/gists{/gist_id}", "starred_url": "https://api.github.com/users/wenscarl/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/wenscarl/subscriptions", "organizations_url": "https://api.github.com/users/wenscarl/orgs", "repos_url": "https://api.github.com/users/wenscarl/repos", "events_url": "https://api.github.com/users/wenscarl/events{/privacy}", "received_events_url": "https://api.github.com/users/wenscarl/received_events", "type": "User", "site_admin": false }
[ { "id": 390482148, "node_id": "MDU6TGFiZWwzOTA0ODIxNDg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/awaiting%20review", "name": "awaiting review", "color": "bc3869", "default": false, "description": "Pull request awaiting review" }, { "id": 987666414, "node_id": "MDU6TGFiZWw5ODc2NjY0MTQ=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/ready%20to%20pull", "name": "ready to pull", "color": "2cd643", "default": false, "description": "PR ready for merge process" }, { "id": 1133285679, "node_id": "MDU6TGFiZWwxMTMzMjg1Njc5", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/comp:xla", "name": "comp:xla", "color": "0052cc", "default": false, "description": "XLA" }, { "id": 1169364458, "node_id": "MDU6TGFiZWwxMTY5MzY0NDU4", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/size:S", "name": "size:S", "color": "adafea", "default": false, "description": "CL Change Size: Small" } ]
closed
false
{ "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false }
[ { "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false } ]
null
[ "@reedwm Sorry for informing late. We decided not to cast F32->BF16 directly by XLA since it breaks what we previously did. Instead, our proposal is to only fuse the following pattern:\r\ny_fp32 = matmul(a, b) + broadcast(cast(cast(bias, bf16), fp32)) ---> y_fp32 = cublas-custom-call(a, b, cast(bias, bf16))\r\n\r\n", "Should I not merge this PR then? Why does casting F32->BF16 break what you previously did? It seems weird to require the user to cast the bias to bf16 then back to f32.", "Yes, please don't merge this PR. User will not normally do that. Casting the bias to bf16 then back to f32 is only for FP8 purpose." ]
2023-04-12T22:02:01
2023-04-20T03:50:41
2023-04-20T03:50:41
CONTRIBUTOR
null
false
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/pulls/60306", "html_url": "https://github.com/tensorflow/tensorflow/pull/60306", "diff_url": "https://github.com/tensorflow/tensorflow/pull/60306.diff", "patch_url": "https://github.com/tensorflow/tensorflow/pull/60306.patch", "merged_at": "2023-04-20T03:50:41" }
Cast Fp32 vector bias to Bf16 to be compatible with cuBLASLT Fp8 support surface. @reedwm @philipphack Once FuseVectorBiasAdd fails, will not try FuseMatrixBiasAdd since matrix bias add logic is implemented in CreateF8CustomCall. And this is only specific to F8 matmul. Open to future changes.
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/60306/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/60306/timeline
null
null
true
https://api.github.com/repos/tensorflow/tensorflow/issues/60305
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/60305/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/60305/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/60305/events
https://github.com/tensorflow/tensorflow/pull/60305
1,665,299,150
PR_kwDOArmXAs5OLFEQ
60,305
Optimize memory allocation and pair construction in ClientSession::Ru…
{ "login": "VijayR19", "id": 107766524, "node_id": "U_kgDOBmxi_A", "avatar_url": "https://avatars.githubusercontent.com/u/107766524?v=4", "gravatar_id": "", "url": "https://api.github.com/users/VijayR19", "html_url": "https://github.com/VijayR19", "followers_url": "https://api.github.com/users/VijayR19/followers", "following_url": "https://api.github.com/users/VijayR19/following{/other_user}", "gists_url": "https://api.github.com/users/VijayR19/gists{/gist_id}", "starred_url": "https://api.github.com/users/VijayR19/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/VijayR19/subscriptions", "organizations_url": "https://api.github.com/users/VijayR19/orgs", "repos_url": "https://api.github.com/users/VijayR19/repos", "events_url": "https://api.github.com/users/VijayR19/events{/privacy}", "received_events_url": "https://api.github.com/users/VijayR19/received_events", "type": "User", "site_admin": false }
[ { "id": 987666414, "node_id": "MDU6TGFiZWw5ODc2NjY0MTQ=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/ready%20to%20pull", "name": "ready to pull", "color": "2cd643", "default": false, "description": "PR ready for merge process" }, { "id": 1169364458, "node_id": "MDU6TGFiZWwxMTY5MzY0NDU4", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/size:S", "name": "size:S", "color": "adafea", "default": false, "description": "CL Change Size: Small" } ]
closed
false
{ "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false }
[ { "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false } ]
null
[ "Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).\n\nView this [failed invocation](https://github.com/tensorflow/tensorflow/pull/60305/checks?check_run_id=12704844397) of the CLA check for more information.\n\nFor the most up to date status, view the checks section at the bottom of the pull request.", "Hi @VijayR19 Can you please sign CLA. Thank you!", "> Hi @VijayR19 Can you please sign CLA. Thank you!\r\n\r\nHi, I have already done that but I still see that missing CLA. Very strange!" ]
2023-04-12T21:38:56
2023-04-20T01:39:25
2023-04-20T01:39:25
CONTRIBUTOR
null
false
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/pulls/60305", "html_url": "https://github.com/tensorflow/tensorflow/pull/60305", "diff_url": "https://github.com/tensorflow/tensorflow/pull/60305.diff", "patch_url": "https://github.com/tensorflow/tensorflow/pull/60305.patch", "merged_at": "2023-04-20T01:39:25" }
Optimize vector capacity reservation in ClientSession::Run Description: This pull request addresses a minor optimization opportunity in the ClientSession::Run function. By reserving the capacity of the output_tensor_names and target_node_names vectors before filling them, we can potentially reduce the number of reallocations and improve performance. The specific changes made in this pull request are: Reserve capacity for output_tensor_names vector using fetch_outputs.size() before the loop that fills it. Reserve capacity for target_node_names vector using run_outputs.size() before the loop that fills it. Testing: I have tested this change locally with the existing test suite, and all tests passed successfully. Reviewers can test this change by running the test suite after applying the patch.
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/60305/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/60305/timeline
null
null
true
https://api.github.com/repos/tensorflow/tensorflow/issues/60304
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/60304/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/60304/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/60304/events
https://github.com/tensorflow/tensorflow/pull/60304
1,665,176,093
PR_kwDOArmXAs5OKqJB
60,304
Add //tensorflow/tsl/protobuf:protos_all_cc_impl to tf_portable_proto_lib in tensorflow/tsl/platform/default/build_config.bzl
{ "login": "yishuangP", "id": 6421220, "node_id": "MDQ6VXNlcjY0MjEyMjA=", "avatar_url": "https://avatars.githubusercontent.com/u/6421220?v=4", "gravatar_id": "", "url": "https://api.github.com/users/yishuangP", "html_url": "https://github.com/yishuangP", "followers_url": "https://api.github.com/users/yishuangP/followers", "following_url": "https://api.github.com/users/yishuangP/following{/other_user}", "gists_url": "https://api.github.com/users/yishuangP/gists{/gist_id}", "starred_url": "https://api.github.com/users/yishuangP/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/yishuangP/subscriptions", "organizations_url": "https://api.github.com/users/yishuangP/orgs", "repos_url": "https://api.github.com/users/yishuangP/repos", "events_url": "https://api.github.com/users/yishuangP/events{/privacy}", "received_events_url": "https://api.github.com/users/yishuangP/received_events", "type": "User", "site_admin": false }
[ { "id": 1169364259, "node_id": "MDU6TGFiZWwxMTY5MzY0MjU5", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/size:XS", "name": "size:XS", "color": "adafea", "default": false, "description": "CL Change Size: Extra Small" } ]
closed
false
{ "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false }
[ { "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false } ]
null
[ "Please don't use \"add file\"/\"update file\"/\"fix file\"/etc. commit messages. These are hard to reason about when looking at the history of the file/repository. Instead, please write explanatory git commit messages.\r\n\r\nThe commit message is also the title of the PR if the PR has only one commit. It is thus twice important to have commit messages that are relevant, as PRs would be easier to understand and easier to analyze in search results.\r\n\r\nFor how to write good quality git commit messages, please consult https://cbea.ms/git-commit/ \r\n\r\nCC @yishuangP ", "Thanks for the tip! I'll use a more meaningful commit message next time" ]
2023-04-12T20:05:56
2023-04-14T22:18:38
2023-04-12T20:46:17
CONTRIBUTOR
null
false
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/pulls/60304", "html_url": "https://github.com/tensorflow/tensorflow/pull/60304", "diff_url": "https://github.com/tensorflow/tensorflow/pull/60304.diff", "patch_url": "https://github.com/tensorflow/tensorflow/pull/60304.patch", "merged_at": "2023-04-12T20:46:17" }
Add //tensorflow/tsl/protobuf:protos_all_cc_impl to tf_portable_proto_lib. This fixes the undefined symbol issue for TensorFlowLiteSelectTfOps_framework.
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/60304/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/60304/timeline
null
null
true
https://api.github.com/repos/tensorflow/tensorflow/issues/60303
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/60303/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/60303/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/60303/events
https://github.com/tensorflow/tensorflow/pull/60303
1,665,174,590
PR_kwDOArmXAs5OKp0M
60,303
Adding large tensor mlir kernels, batch 1
{ "login": "kushanam", "id": 42385577, "node_id": "MDQ6VXNlcjQyMzg1NTc3", "avatar_url": "https://avatars.githubusercontent.com/u/42385577?v=4", "gravatar_id": "", "url": "https://api.github.com/users/kushanam", "html_url": "https://github.com/kushanam", "followers_url": "https://api.github.com/users/kushanam/followers", "following_url": "https://api.github.com/users/kushanam/following{/other_user}", "gists_url": "https://api.github.com/users/kushanam/gists{/gist_id}", "starred_url": "https://api.github.com/users/kushanam/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kushanam/subscriptions", "organizations_url": "https://api.github.com/users/kushanam/orgs", "repos_url": "https://api.github.com/users/kushanam/repos", "events_url": "https://api.github.com/users/kushanam/events{/privacy}", "received_events_url": "https://api.github.com/users/kushanam/received_events", "type": "User", "site_admin": false }
[ { "id": 390482148, "node_id": "MDU6TGFiZWwzOTA0ODIxNDg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/awaiting%20review", "name": "awaiting review", "color": "bc3869", "default": false, "description": "Pull request awaiting review" }, { "id": 987666414, "node_id": "MDU6TGFiZWw5ODc2NjY0MTQ=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/ready%20to%20pull", "name": "ready to pull", "color": "2cd643", "default": false, "description": "PR ready for merge process" }, { "id": 1169365682, "node_id": "MDU6TGFiZWwxMTY5MzY1Njgy", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/size:L", "name": "size:L", "color": "adafea", "default": false, "description": "CL Change Size: Large" }, { "id": 1478826728, "node_id": "MDU6TGFiZWwxNDc4ODI2NzI4", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/comp:core", "name": "comp:core", "color": "024391", "default": false, "description": "issues related to core part of tensorflow" } ]
closed
false
{ "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false }
[ { "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false } ]
null
[]
2023-04-12T20:05:01
2023-04-19T20:06:23
2023-04-19T20:06:23
CONTRIBUTOR
null
false
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/pulls/60303", "html_url": "https://github.com/tensorflow/tensorflow/pull/60303", "diff_url": "https://github.com/tensorflow/tensorflow/pull/60303.diff", "patch_url": "https://github.com/tensorflow/tensorflow/pull/60303.patch", "merged_at": "2023-04-19T20:06:23" }
To enable Predicate, Mul and Div to the MLIR large indexing kernels CC: @frgossen for review
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/60303/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/60303/timeline
null
null
true
https://api.github.com/repos/tensorflow/tensorflow/issues/60302
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/60302/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/60302/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/60302/events
https://github.com/tensorflow/tensorflow/issues/60302
1,665,024,388
I_kwDOArmXAs5jPkGE
60,302
Issue created for Rollback of PR #60180: Use a custom rule for API files generation
{ "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "site_admin": false }
[]
closed
false
{ "login": "meteorcloudy", "id": 4171702, "node_id": "MDQ6VXNlcjQxNzE3MDI=", "avatar_url": "https://avatars.githubusercontent.com/u/4171702?v=4", "gravatar_id": "", "url": "https://api.github.com/users/meteorcloudy", "html_url": "https://github.com/meteorcloudy", "followers_url": "https://api.github.com/users/meteorcloudy/followers", "following_url": "https://api.github.com/users/meteorcloudy/following{/other_user}", "gists_url": "https://api.github.com/users/meteorcloudy/gists{/gist_id}", "starred_url": "https://api.github.com/users/meteorcloudy/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/meteorcloudy/subscriptions", "organizations_url": "https://api.github.com/users/meteorcloudy/orgs", "repos_url": "https://api.github.com/users/meteorcloudy/repos", "events_url": "https://api.github.com/users/meteorcloudy/events{/privacy}", "received_events_url": "https://api.github.com/users/meteorcloudy/received_events", "type": "User", "site_admin": false }
[ { "login": "meteorcloudy", "id": 4171702, "node_id": "MDQ6VXNlcjQxNzE3MDI=", "avatar_url": "https://avatars.githubusercontent.com/u/4171702?v=4", "gravatar_id": "", "url": "https://api.github.com/users/meteorcloudy", "html_url": "https://github.com/meteorcloudy", "followers_url": "https://api.github.com/users/meteorcloudy/followers", "following_url": "https://api.github.com/users/meteorcloudy/following{/other_user}", "gists_url": "https://api.github.com/users/meteorcloudy/gists{/gist_id}", "starred_url": "https://api.github.com/users/meteorcloudy/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/meteorcloudy/subscriptions", "organizations_url": "https://api.github.com/users/meteorcloudy/orgs", "repos_url": "https://api.github.com/users/meteorcloudy/repos", "events_url": "https://api.github.com/users/meteorcloudy/events{/privacy}", "received_events_url": "https://api.github.com/users/meteorcloudy/received_events", "type": "User", "site_admin": false }, { "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false }, { "login": "synandi", "id": 98147397, "node_id": "U_kgDOBdmcRQ", "avatar_url": "https://avatars.githubusercontent.com/u/98147397?v=4", "gravatar_id": "", "url": "https://api.github.com/users/synandi", "html_url": "https://github.com/synandi", "followers_url": "https://api.github.com/users/synandi/followers", "following_url": "https://api.github.com/users/synandi/following{/other_user}", "gists_url": "https://api.github.com/users/synandi/gists{/gist_id}", "starred_url": "https://api.github.com/users/synandi/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/synandi/subscriptions", "organizations_url": "https://api.github.com/users/synandi/orgs", "repos_url": "https://api.github.com/users/synandi/repos", "events_url": "https://api.github.com/users/synandi/events{/privacy}", "received_events_url": "https://api.github.com/users/synandi/received_events", "type": "User", "site_admin": false } ]
null
[ "Rolled forward again at https://github.com/tensorflow/tensorflow/commit/641501d1c773fe2b8527f63052ee3ae4f05c01a2" ]
2023-04-12T18:13:59
2023-04-13T14:36:06
2023-04-13T14:36:06
NONE
null
null
null
Merged PR #60180 is rolled back in ec0ba2461436eb45881a6e76ca29ed49dcd21a66. Please follow up with the reviewer and close this issue once its resolved.
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/60302/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/60302/timeline
null
completed
false
https://api.github.com/repos/tensorflow/tensorflow/issues/60301
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/60301/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/60301/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/60301/events
https://github.com/tensorflow/tensorflow/issues/60301
1,664,954,810
I_kwDOArmXAs5jPTG6
60,301
[tosa] [mlir] tfl.IfOp isn’t supported in tf-mlir-translate.
{ "login": "Jerry-Ge", "id": 24451859, "node_id": "MDQ6VXNlcjI0NDUxODU5", "avatar_url": "https://avatars.githubusercontent.com/u/24451859?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Jerry-Ge", "html_url": "https://github.com/Jerry-Ge", "followers_url": "https://api.github.com/users/Jerry-Ge/followers", "following_url": "https://api.github.com/users/Jerry-Ge/following{/other_user}", "gists_url": "https://api.github.com/users/Jerry-Ge/gists{/gist_id}", "starred_url": "https://api.github.com/users/Jerry-Ge/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Jerry-Ge/subscriptions", "organizations_url": "https://api.github.com/users/Jerry-Ge/orgs", "repos_url": "https://api.github.com/users/Jerry-Ge/repos", "events_url": "https://api.github.com/users/Jerry-Ge/events{/privacy}", "received_events_url": "https://api.github.com/users/Jerry-Ge/received_events", "type": "User", "site_admin": false }
[ { "id": 404586594, "node_id": "MDU6TGFiZWw0MDQ1ODY1OTQ=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/stat:awaiting%20tensorflower", "name": "stat:awaiting tensorflower", "color": "f4b400", "default": false, "description": "Status - Awaiting response from tensorflower" }, { "id": 473173272, "node_id": "MDU6TGFiZWw0NzMxNzMyNzI=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/type:feature", "name": "type:feature", "color": "159b2e", "default": false, "description": "Feature requests" }, { "id": 750616506, "node_id": "MDU6TGFiZWw3NTA2MTY1MDY=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/comp:lite", "name": "comp:lite", "color": "0052cc", "default": false, "description": "TF Lite related issues" }, { "id": 4651658080, "node_id": "LA_kwDOArmXAs8AAAABFUKrYA", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/comp:lite-tosa", "name": "comp:lite-tosa", "color": "bfdadc", "default": false, "description": "TFLite TOSA conversion issues" } ]
closed
false
{ "login": "arfaian", "id": 1106365, "node_id": "MDQ6VXNlcjExMDYzNjU=", "avatar_url": "https://avatars.githubusercontent.com/u/1106365?v=4", "gravatar_id": "", "url": "https://api.github.com/users/arfaian", "html_url": "https://github.com/arfaian", "followers_url": "https://api.github.com/users/arfaian/followers", "following_url": "https://api.github.com/users/arfaian/following{/other_user}", "gists_url": "https://api.github.com/users/arfaian/gists{/gist_id}", "starred_url": "https://api.github.com/users/arfaian/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/arfaian/subscriptions", "organizations_url": "https://api.github.com/users/arfaian/orgs", "repos_url": "https://api.github.com/users/arfaian/repos", "events_url": "https://api.github.com/users/arfaian/events{/privacy}", "received_events_url": "https://api.github.com/users/arfaian/received_events", "type": "User", "site_admin": false }
[ { "login": "arfaian", "id": 1106365, "node_id": "MDQ6VXNlcjExMDYzNjU=", "avatar_url": "https://avatars.githubusercontent.com/u/1106365?v=4", "gravatar_id": "", "url": "https://api.github.com/users/arfaian", "html_url": "https://github.com/arfaian", "followers_url": "https://api.github.com/users/arfaian/followers", "following_url": "https://api.github.com/users/arfaian/following{/other_user}", "gists_url": "https://api.github.com/users/arfaian/gists{/gist_id}", "starred_url": "https://api.github.com/users/arfaian/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/arfaian/subscriptions", "organizations_url": "https://api.github.com/users/arfaian/orgs", "repos_url": "https://api.github.com/users/arfaian/repos", "events_url": "https://api.github.com/users/arfaian/events{/privacy}", "received_events_url": "https://api.github.com/users/arfaian/received_events", "type": "User", "site_admin": false }, { "login": "sachinprasadhs", "id": 73069040, "node_id": "MDQ6VXNlcjczMDY5MDQw", "avatar_url": "https://avatars.githubusercontent.com/u/73069040?v=4", "gravatar_id": "", "url": "https://api.github.com/users/sachinprasadhs", "html_url": "https://github.com/sachinprasadhs", "followers_url": "https://api.github.com/users/sachinprasadhs/followers", "following_url": "https://api.github.com/users/sachinprasadhs/following{/other_user}", "gists_url": "https://api.github.com/users/sachinprasadhs/gists{/gist_id}", "starred_url": "https://api.github.com/users/sachinprasadhs/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sachinprasadhs/subscriptions", "organizations_url": "https://api.github.com/users/sachinprasadhs/orgs", "repos_url": "https://api.github.com/users/sachinprasadhs/repos", "events_url": "https://api.github.com/users/sachinprasadhs/events{/privacy}", "received_events_url": "https://api.github.com/users/sachinprasadhs/received_events", "type": "User", "site_admin": false } ]
null
[ "[proposed Label] comp:lite-tosa, seems I don't have the access to config the labels.\r\n\r\n", "Hi @Jerry-Ge,\r\n\r\nYes, currently it is true that `tf.IfOp -> tfl.IfOp` only happens at export time. Would you mind sharing the tflite model in question as well as how it was generated?", "Thanks @LukeBoyer, I pushed the dummy model I used for testing here: https://github.com/Jerry-Ge/tfl_models/tree/main\r\n\r\nIt's generated by using the `tf.cond()` operator and the `tf.lite.TFLiteConverter.from_concrete_functions` \r\n\r\nThen you ran the flatbuffer_translate code provided from above, you will get the `test_tflite.preopt.mlir` output I got. \r\n\r\nLet me know if you need more details. \r\n\r\n\r\n\r\n", "Thanks @Jerry-Ge. We are prioritizing fixing this issue and having the if op be legalized appropriately. I think 1-2 weeks is when the fix will come.", "> \r\n\r\nHi Luke, any updates here? Tks ", "Hi @Jerry-Ge, we're still working on this. It's taking longer than expected since a lot of tests expect `tf.If` and the op is not entirely equivalent to `tfl.If` so it's not a trivial find/replace change. We also have internal downstream dependents which will need to be updated.\r\n\r\nCan you help provide additional detail and context about your need for this? Just trying to understand if it's a nuisance, blocker, or something in between. Thanks!", "Thanks for the update! Don't worry and I can wait : )", "Hi @arfaian, any updates on this issue? If it's done, then we can close it? ", "If nobody plans to fix this, I will close this ticket by the end of this week. ", "Nobody is responding to this issue. Close this ticket for now. " ]
2023-04-12T17:25:46
2024-03-14T21:55:04
2024-03-14T21:55:04
CONTRIBUTOR
null
null
null
**System information** - OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Ubuntu 20.04.5 LTS - TensorFlow installed from (source or binary): source - TensorFlow version (or github SHA if from source): 45f08a0fcc90145b9c2b7057310762d6b0ebae85 **Standalone code to reproduce the issue** ``` tensorflow/bazel-bin/tensorflow/compiler/mlir/lite/flatbuffer_translate --tflite-flatbuffer-to-mlir onlyif/test_onlyif_1_f32/model.tflite --output-arrays=PartitionedCall:0 -o onlyif/test_onlyif_1_f32/test_tflite.preopt.mlir ``` test_tflite.preopt.mlir output: ``` func.func @main(%arg0: tensor<1xf32> {tf_saved_model.index_path = ["placeholder_0"]}) -> (tensor<*xf32> {tf_saved_model.index_path = ["output_0"]}) attributes {tf.entry_function = {inputs = "serving_default_placeholder_0:0", outputs = "PartitionedCall:0"}, tf_saved_model.exported_names = ["serving_default"]} { %0 = "tfl.pseudo_const"() {value = dense<5.000000e+00> : tensor<f32>} : () -> tensor<f32> %1 = tfl.less(%arg0, %0) : (tensor<1xf32>, tensor<f32>) -> tensor<1xi1> %2 = "tfl.pseudo_const"() {value = dense<> : tensor<0xi32>} : () -> tensor<0xi32> %3 = "tfl.reshape"(%1, %2) : (tensor<1xi1>, tensor<0xi32>) -> tensor<i1> // !!!!! THIS IS NOT tfl.If !!!!!! %4 = "tf.If"(%3, %arg0, %0) {else_branch = @cond_false_70, is_stateless = false, then_branch = @cond_true_60} : (tensor<i1>, tensor<1xf32>, tensor<f32>) -> tensor<*xf32> return %4 : tensor<*xf32> } ``` **Any other info / logs** - The goal is to generate tfl.IfOp in MLIR - seems a lot of TF::IfOp is used everywhere and a TFL::IfOp is only instantiated during the flatbuffer export - Some TODOs here: - https://github.com/tensorflow/tensorflow/blob/ba8b52cad65f882bed982517a7b7cf60c598efab/tensorflow/compiler/mlir/lite/flatbuffer_export.cc#L572 - https://github.com/tensorflow/tensorflow/blob/524101303ff158b939923b36805474f2e4118a49/tensorflow/compiler/mlir/lite/transforms/pin_ops_with_side_effects.cc#L48 Could anyone update the progress of the support of this operator?
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/60301/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/60301/timeline
null
completed
false
https://api.github.com/repos/tensorflow/tensorflow/issues/60300
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/60300/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/60300/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/60300/events
https://github.com/tensorflow/tensorflow/issues/60300
1,664,914,113
I_kwDOArmXAs5jPJLB
60,300
[tosa] [mlir] tfl.relu_0_to_1 mlir dialect can’t be generated
{ "login": "Jerry-Ge", "id": 24451859, "node_id": "MDQ6VXNlcjI0NDUxODU5", "avatar_url": "https://avatars.githubusercontent.com/u/24451859?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Jerry-Ge", "html_url": "https://github.com/Jerry-Ge", "followers_url": "https://api.github.com/users/Jerry-Ge/followers", "following_url": "https://api.github.com/users/Jerry-Ge/following{/other_user}", "gists_url": "https://api.github.com/users/Jerry-Ge/gists{/gist_id}", "starred_url": "https://api.github.com/users/Jerry-Ge/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Jerry-Ge/subscriptions", "organizations_url": "https://api.github.com/users/Jerry-Ge/orgs", "repos_url": "https://api.github.com/users/Jerry-Ge/repos", "events_url": "https://api.github.com/users/Jerry-Ge/events{/privacy}", "received_events_url": "https://api.github.com/users/Jerry-Ge/received_events", "type": "User", "site_admin": false }
[ { "id": 404586594, "node_id": "MDU6TGFiZWw0MDQ1ODY1OTQ=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/stat:awaiting%20tensorflower", "name": "stat:awaiting tensorflower", "color": "f4b400", "default": false, "description": "Status - Awaiting response from tensorflower" }, { "id": 473172988, "node_id": "MDU6TGFiZWw0NzMxNzI5ODg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/type:bug", "name": "type:bug", "color": "159b2e", "default": false, "description": "Bug" }, { "id": 750616506, "node_id": "MDU6TGFiZWw3NTA2MTY1MDY=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/comp:lite", "name": "comp:lite", "color": "0052cc", "default": false, "description": "TF Lite related issues" }, { "id": 4651658080, "node_id": "LA_kwDOArmXAs8AAAABFUKrYA", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/comp:lite-tosa", "name": "comp:lite-tosa", "color": "bfdadc", "default": false, "description": "TFLite TOSA conversion issues" } ]
closed
false
{ "login": "LukeBoyer", "id": 46931380, "node_id": "MDQ6VXNlcjQ2OTMxMzgw", "avatar_url": "https://avatars.githubusercontent.com/u/46931380?v=4", "gravatar_id": "", "url": "https://api.github.com/users/LukeBoyer", "html_url": "https://github.com/LukeBoyer", "followers_url": "https://api.github.com/users/LukeBoyer/followers", "following_url": "https://api.github.com/users/LukeBoyer/following{/other_user}", "gists_url": "https://api.github.com/users/LukeBoyer/gists{/gist_id}", "starred_url": "https://api.github.com/users/LukeBoyer/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/LukeBoyer/subscriptions", "organizations_url": "https://api.github.com/users/LukeBoyer/orgs", "repos_url": "https://api.github.com/users/LukeBoyer/repos", "events_url": "https://api.github.com/users/LukeBoyer/events{/privacy}", "received_events_url": "https://api.github.com/users/LukeBoyer/received_events", "type": "User", "site_admin": false }
[ { "login": "LukeBoyer", "id": 46931380, "node_id": "MDQ6VXNlcjQ2OTMxMzgw", "avatar_url": "https://avatars.githubusercontent.com/u/46931380?v=4", "gravatar_id": "", "url": "https://api.github.com/users/LukeBoyer", "html_url": "https://github.com/LukeBoyer", "followers_url": "https://api.github.com/users/LukeBoyer/followers", "following_url": "https://api.github.com/users/LukeBoyer/following{/other_user}", "gists_url": "https://api.github.com/users/LukeBoyer/gists{/gist_id}", "starred_url": "https://api.github.com/users/LukeBoyer/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/LukeBoyer/subscriptions", "organizations_url": "https://api.github.com/users/LukeBoyer/orgs", "repos_url": "https://api.github.com/users/LukeBoyer/repos", "events_url": "https://api.github.com/users/LukeBoyer/events{/privacy}", "received_events_url": "https://api.github.com/users/LukeBoyer/received_events", "type": "User", "site_admin": false }, { "login": "sachinprasadhs", "id": 73069040, "node_id": "MDQ6VXNlcjczMDY5MDQw", "avatar_url": "https://avatars.githubusercontent.com/u/73069040?v=4", "gravatar_id": "", "url": "https://api.github.com/users/sachinprasadhs", "html_url": "https://github.com/sachinprasadhs", "followers_url": "https://api.github.com/users/sachinprasadhs/followers", "following_url": "https://api.github.com/users/sachinprasadhs/following{/other_user}", "gists_url": "https://api.github.com/users/sachinprasadhs/gists{/gist_id}", "starred_url": "https://api.github.com/users/sachinprasadhs/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sachinprasadhs/subscriptions", "organizations_url": "https://api.github.com/users/sachinprasadhs/orgs", "repos_url": "https://api.github.com/users/sachinprasadhs/repos", "events_url": "https://api.github.com/users/sachinprasadhs/events{/privacy}", "received_events_url": "https://api.github.com/users/sachinprasadhs/received_events", "type": "User", "site_admin": false } ]
null
[ "[proposed Label] comp:lite-tosa, seems I don't have the access to config the labels. ", "Hi @Jerry-Ge, few questions:\r\n* how can I access the model in question; `relu0To1/test_relu0To1_13x21x3_qu8/model.tflite`?\r\n* What do we mean exactly by \"generate relu_0_to_1\" op? Is this op present in the flatbuffer but not present in output mlir via the translate tool?\r\n * If so, would you mind sharing how this tflite model was created?\r\n", "> Hi @Jerry-Ge, few questions:\r\n> \r\n> * how can I access the model in question; `relu0To1/test_relu0To1_13x21x3_qu8/model.tflite`?\r\n> * What do we mean exactly by \"generate relu_0_to_1\" op? Is this op present in the flatbuffer but not present in output mlir via the translate tool?\r\n> \r\n> * If so, would you mind sharing how this tflite model was created?\r\n\r\nHi Luke, thanks for following up with this. \r\n- That's a very dummy model created by using `tf.math.minimum(1.0, tf.math.maximum(0.0, a))` . I can see a relu with minimum there but ideally we should have relu0To1 right? \r\n Link to the model file: https://github.com/Jerry-Ge/tfl_models/blob/main/model_relu0To1.tflite\r\n<img width=\"382\" alt=\"Screenshot 2023-05-19 at 1 01 21 PM\" src=\"https://github.com/tensorflow/tensorflow/assets/24451859/8eba1ac9-d85c-4a77-99c9-06515ece88e0\">\r\n\r\n- Yea, I am currently using the `tf.lite.TFLiteConverter.from_concrete_functions` to generate the tflite models. ", "Ok I see the issue. While there is an op def for `relu_0_to_1` there is no logic to write them into the graph.\r\n\r\nI can add some logic to rewrite patterns such as the following:\r\n```\r\n %cst0 = arith.constant dense<0.0> : tensor<f32>\r\n %0 = \"tfl.maximum\"(%arg0, %cst0) : (tensor<2x2xf32>, tensor<f32>) -> tensor<2x2xf32>\r\n %cst1 = arith.constant dense<1.0> : tensor<f32>\r\n %1 = \"tfl.minimum\"(%0, %cst1) : (tensor<2x2xf32>, tensor<f32>) -> tensor<2x2xf32>\r\n```\r\nto \r\n```\r\n%0 = \"tfl.relu_0_to_1\"(%arg0) : (tensor<2x2xf32>) -> tensor<2x2xf32>\r\n```\r\n\r\nI'll keep this thread posted with status of change. Also worth noting that the min/maxes commute so either ordering should be rewritten.", "Hi @Jerry-Ge, this should be all set with https://github.com/tensorflow/tensorflow/commit/0a2aab71fedfc92ce99b484a87e926bdfcbec1d9", "Are you satisfied with the resolution of your issue?\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=Yes&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/60300\">Yes</a>\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=No&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/60300\">No</a>\n", "> Hi @Jerry-Ge, this should be all set with [0a2aab7](https://github.com/tensorflow/tensorflow/commit/0a2aab71fedfc92ce99b484a87e926bdfcbec1d9)\r\n\r\nYes, this is what I want and Thanks so much Luke!" ]
2023-04-12T16:55:44
2023-05-30T18:26:56
2023-05-30T15:18:38
CONTRIBUTOR
null
null
null
**System information** - OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Ubuntu 20.04.5 LTS - TensorFlow installed from (source or binary): source - TensorFlow version (or github SHA if from source): 45f08a0fcc90145b9c2b7057310762d6b0ebae85 **Standalone code to reproduce the issue** ``` tensorflow/bazel-bin/tensorflow/compiler/mlir/lite/flatbuffer_translate --tflite-flatbuffer-to-mlir relu0To1/test_relu0To1_13x21x3_qu8/model.tflite --output-arrays=PartitionedCall:0 -o relu0To1/test_relu0To1_13x21x3_qu8/test_tflite.preopt.mlir ``` **Any other info / logs** - The goal is to generate [tfl.relu_0_to_1](https://www.tensorflow.org/mlir/tfl_ops#tflrelu_0_to_1_mlirtflrelu0to1op) op in tfl dialect - The kernel was added here: https://github.com/tensorflow/tensorflow/commit/f11ab18461943d15fe562ce5bd07c3d1a50fd0de - Myself added the MLIR dialect here: https://github.com/tensorflow/tensorflow/commit/485f680eccae0a5f3f7b83319b1ddc3426fc601a - From the comments here https://github.com/tensorflow/tensorflow/pull/58078#pullrequestreview-1142611030 saying that Google will be finishing this. Could anyone update the progress of the support of this operator?
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/60300/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/60300/timeline
null
completed
false
https://api.github.com/repos/tensorflow/tensorflow/issues/60299
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/60299/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/60299/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/60299/events
https://github.com/tensorflow/tensorflow/pull/60299
1,664,851,433
PR_kwDOArmXAs5OJj4Y
60,299
tflite: add stdint.h for int types in internal::Spectrogram
{ "login": "stha09", "id": 51720730, "node_id": "MDQ6VXNlcjUxNzIwNzMw", "avatar_url": "https://avatars.githubusercontent.com/u/51720730?v=4", "gravatar_id": "", "url": "https://api.github.com/users/stha09", "html_url": "https://github.com/stha09", "followers_url": "https://api.github.com/users/stha09/followers", "following_url": "https://api.github.com/users/stha09/following{/other_user}", "gists_url": "https://api.github.com/users/stha09/gists{/gist_id}", "starred_url": "https://api.github.com/users/stha09/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/stha09/subscriptions", "organizations_url": "https://api.github.com/users/stha09/orgs", "repos_url": "https://api.github.com/users/stha09/repos", "events_url": "https://api.github.com/users/stha09/events{/privacy}", "received_events_url": "https://api.github.com/users/stha09/received_events", "type": "User", "site_admin": false }
[ { "id": 750616506, "node_id": "MDU6TGFiZWw3NTA2MTY1MDY=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/comp:lite", "name": "comp:lite", "color": "0052cc", "default": false, "description": "TF Lite related issues" }, { "id": 987666414, "node_id": "MDU6TGFiZWw5ODc2NjY0MTQ=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/ready%20to%20pull", "name": "ready to pull", "color": "2cd643", "default": false, "description": "PR ready for merge process" }, { "id": 1169364259, "node_id": "MDU6TGFiZWwxMTY5MzY0MjU5", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/size:XS", "name": "size:XS", "color": "adafea", "default": false, "description": "CL Change Size: Extra Small" } ]
closed
false
{ "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false }
[ { "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false } ]
null
[ "Hi @alankelly Can you please review this PR ? Thank you!" ]
2023-04-12T16:08:54
2023-06-12T18:06:26
2023-05-26T12:40:32
CONTRIBUTOR
null
false
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/pulls/60299", "html_url": "https://github.com/tensorflow/tensorflow/pull/60299", "diff_url": "https://github.com/tensorflow/tensorflow/pull/60299.diff", "patch_url": "https://github.com/tensorflow/tensorflow/pull/60299.patch", "merged_at": "2023-05-26T12:40:32" }
Discovered during Chromium build with GCC 13.
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/60299/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/60299/timeline
null
null
true
https://api.github.com/repos/tensorflow/tensorflow/issues/60298
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/60298/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/60298/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/60298/events
https://github.com/tensorflow/tensorflow/issues/60298
1,664,272,449
I_kwDOArmXAs5jMshB
60,298
Issue created for Rollback of PR #60180: Use a custom rule for API files generation
{ "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "site_admin": false }
[]
closed
false
{ "login": "meteorcloudy", "id": 4171702, "node_id": "MDQ6VXNlcjQxNzE3MDI=", "avatar_url": "https://avatars.githubusercontent.com/u/4171702?v=4", "gravatar_id": "", "url": "https://api.github.com/users/meteorcloudy", "html_url": "https://github.com/meteorcloudy", "followers_url": "https://api.github.com/users/meteorcloudy/followers", "following_url": "https://api.github.com/users/meteorcloudy/following{/other_user}", "gists_url": "https://api.github.com/users/meteorcloudy/gists{/gist_id}", "starred_url": "https://api.github.com/users/meteorcloudy/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/meteorcloudy/subscriptions", "organizations_url": "https://api.github.com/users/meteorcloudy/orgs", "repos_url": "https://api.github.com/users/meteorcloudy/repos", "events_url": "https://api.github.com/users/meteorcloudy/events{/privacy}", "received_events_url": "https://api.github.com/users/meteorcloudy/received_events", "type": "User", "site_admin": false }
[ { "login": "meteorcloudy", "id": 4171702, "node_id": "MDQ6VXNlcjQxNzE3MDI=", "avatar_url": "https://avatars.githubusercontent.com/u/4171702?v=4", "gravatar_id": "", "url": "https://api.github.com/users/meteorcloudy", "html_url": "https://github.com/meteorcloudy", "followers_url": "https://api.github.com/users/meteorcloudy/followers", "following_url": "https://api.github.com/users/meteorcloudy/following{/other_user}", "gists_url": "https://api.github.com/users/meteorcloudy/gists{/gist_id}", "starred_url": "https://api.github.com/users/meteorcloudy/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/meteorcloudy/subscriptions", "organizations_url": "https://api.github.com/users/meteorcloudy/orgs", "repos_url": "https://api.github.com/users/meteorcloudy/repos", "events_url": "https://api.github.com/users/meteorcloudy/events{/privacy}", "received_events_url": "https://api.github.com/users/meteorcloudy/received_events", "type": "User", "site_admin": false }, { "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false }, { "login": "tiruk007", "id": 111861663, "node_id": "U_kgDOBqrfnw", "avatar_url": "https://avatars.githubusercontent.com/u/111861663?v=4", "gravatar_id": "", "url": "https://api.github.com/users/tiruk007", "html_url": "https://github.com/tiruk007", "followers_url": "https://api.github.com/users/tiruk007/followers", "following_url": "https://api.github.com/users/tiruk007/following{/other_user}", "gists_url": "https://api.github.com/users/tiruk007/gists{/gist_id}", "starred_url": "https://api.github.com/users/tiruk007/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/tiruk007/subscriptions", "organizations_url": "https://api.github.com/users/tiruk007/orgs", "repos_url": "https://api.github.com/users/tiruk007/repos", "events_url": "https://api.github.com/users/tiruk007/events{/privacy}", "received_events_url": "https://api.github.com/users/tiruk007/received_events", "type": "User", "site_admin": false } ]
null
[ "Working on a rollforward", "Rolled forward at https://github.com/tensorflow/tensorflow/commit/da439b7d05584f93e745511d66f6d74a58b54b34" ]
2023-04-12T10:15:57
2023-04-12T15:18:15
2023-04-12T15:18:15
NONE
null
null
null
Merged PR #60180 is rolled back in 6767f70a301c62205e6fa1e590bfab3cfccd3978. Please follow up with the reviewer and close this issue once its resolved.
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/60298/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/60298/timeline
null
completed
false
https://api.github.com/repos/tensorflow/tensorflow/issues/60297
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/60297/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/60297/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/60297/events
https://github.com/tensorflow/tensorflow/issues/60297
1,663,641,245
I_kwDOArmXAs5jKSad
60,297
<spam>
{ "login": "ghost", "id": 10137, "node_id": "MDQ6VXNlcjEwMTM3", "avatar_url": "https://avatars.githubusercontent.com/u/10137?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ghost", "html_url": "https://github.com/ghost", "followers_url": "https://api.github.com/users/ghost/followers", "following_url": "https://api.github.com/users/ghost/following{/other_user}", "gists_url": "https://api.github.com/users/ghost/gists{/gist_id}", "starred_url": "https://api.github.com/users/ghost/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ghost/subscriptions", "organizations_url": "https://api.github.com/users/ghost/orgs", "repos_url": "https://api.github.com/users/ghost/repos", "events_url": "https://api.github.com/users/ghost/events{/privacy}", "received_events_url": "https://api.github.com/users/ghost/received_events", "type": "User", "site_admin": false }
[ { "id": 1593512946, "node_id": "MDU6TGFiZWwxNTkzNTEyOTQ2", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/invalid", "name": "invalid", "color": "db6f57", "default": true, "description": "Hacktoberfest spam PR" } ]
closed
true
{ "login": "synandi", "id": 98147397, "node_id": "U_kgDOBdmcRQ", "avatar_url": "https://avatars.githubusercontent.com/u/98147397?v=4", "gravatar_id": "", "url": "https://api.github.com/users/synandi", "html_url": "https://github.com/synandi", "followers_url": "https://api.github.com/users/synandi/followers", "following_url": "https://api.github.com/users/synandi/following{/other_user}", "gists_url": "https://api.github.com/users/synandi/gists{/gist_id}", "starred_url": "https://api.github.com/users/synandi/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/synandi/subscriptions", "organizations_url": "https://api.github.com/users/synandi/orgs", "repos_url": "https://api.github.com/users/synandi/repos", "events_url": "https://api.github.com/users/synandi/events{/privacy}", "received_events_url": "https://api.github.com/users/synandi/received_events", "type": "User", "site_admin": false }
[ { "login": "synandi", "id": 98147397, "node_id": "U_kgDOBdmcRQ", "avatar_url": "https://avatars.githubusercontent.com/u/98147397?v=4", "gravatar_id": "", "url": "https://api.github.com/users/synandi", "html_url": "https://github.com/synandi", "followers_url": "https://api.github.com/users/synandi/followers", "following_url": "https://api.github.com/users/synandi/following{/other_user}", "gists_url": "https://api.github.com/users/synandi/gists{/gist_id}", "starred_url": "https://api.github.com/users/synandi/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/synandi/subscriptions", "organizations_url": "https://api.github.com/users/synandi/orgs", "repos_url": "https://api.github.com/users/synandi/repos", "events_url": "https://api.github.com/users/synandi/events{/privacy}", "received_events_url": "https://api.github.com/users/synandi/received_events", "type": "User", "site_admin": false } ]
null
[]
2023-04-12T03:18:44
2023-04-12T03:44:19
2023-04-12T03:44:03
NONE
spam
null
null
null
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/60297/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/60297/timeline
null
completed
false
https://api.github.com/repos/tensorflow/tensorflow/issues/60296
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/60296/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/60296/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/60296/events
https://github.com/tensorflow/tensorflow/pull/60296
1,663,324,890
PR_kwDOArmXAs5OEXBh
60,296
Validate null pointer dereference
{ "login": "sachinprasadhs", "id": 73069040, "node_id": "MDQ6VXNlcjczMDY5MDQw", "avatar_url": "https://avatars.githubusercontent.com/u/73069040?v=4", "gravatar_id": "", "url": "https://api.github.com/users/sachinprasadhs", "html_url": "https://github.com/sachinprasadhs", "followers_url": "https://api.github.com/users/sachinprasadhs/followers", "following_url": "https://api.github.com/users/sachinprasadhs/following{/other_user}", "gists_url": "https://api.github.com/users/sachinprasadhs/gists{/gist_id}", "starred_url": "https://api.github.com/users/sachinprasadhs/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sachinprasadhs/subscriptions", "organizations_url": "https://api.github.com/users/sachinprasadhs/orgs", "repos_url": "https://api.github.com/users/sachinprasadhs/repos", "events_url": "https://api.github.com/users/sachinprasadhs/events{/privacy}", "received_events_url": "https://api.github.com/users/sachinprasadhs/received_events", "type": "User", "site_admin": false }
[ { "id": 987666414, "node_id": "MDU6TGFiZWw5ODc2NjY0MTQ=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/ready%20to%20pull", "name": "ready to pull", "color": "2cd643", "default": false, "description": "PR ready for merge process" }, { "id": 1169364259, "node_id": "MDU6TGFiZWwxMTY5MzY0MjU5", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/size:XS", "name": "size:XS", "color": "adafea", "default": false, "description": "CL Change Size: Extra Small" }, { "id": 1478826728, "node_id": "MDU6TGFiZWwxNDc4ODI2NzI4", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/comp:core", "name": "comp:core", "color": "024391", "default": false, "description": "issues related to core part of tensorflow" } ]
closed
false
{ "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false }
[ { "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false } ]
null
[ "Let's try with this fix, but if test fail let's do the real larger change that handles this better (https://github.com/tensorflow/tensorflow/pull/60296#discussion_r1163413390)" ]
2023-04-11T22:51:43
2023-05-01T16:26:10
2023-04-12T18:33:52
CONTRIBUTOR
null
false
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/pulls/60296", "html_url": "https://github.com/tensorflow/tensorflow/pull/60296", "diff_url": "https://github.com/tensorflow/tensorflow/pull/60296.diff", "patch_url": "https://github.com/tensorflow/tensorflow/pull/60296.patch", "merged_at": "2023-04-12T18:33:52" }
Added validation to check if the null pointer is dereferenced before executing the code. Fixes: https://github.com/tensorflow/tensorflow/issues/60220
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/60296/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/60296/timeline
null
null
true
https://api.github.com/repos/tensorflow/tensorflow/issues/60295
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/60295/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/60295/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/60295/events
https://github.com/tensorflow/tensorflow/issues/60295
1,663,308,421
I_kwDOArmXAs5jJBKF
60,295
[MLIR-HLO] Missing legalization for mhlo.scatter to standard MLIR
{ "login": "dime10", "id": 29467667, "node_id": "MDQ6VXNlcjI5NDY3NjY3", "avatar_url": "https://avatars.githubusercontent.com/u/29467667?v=4", "gravatar_id": "", "url": "https://api.github.com/users/dime10", "html_url": "https://github.com/dime10", "followers_url": "https://api.github.com/users/dime10/followers", "following_url": "https://api.github.com/users/dime10/following{/other_user}", "gists_url": "https://api.github.com/users/dime10/gists{/gist_id}", "starred_url": "https://api.github.com/users/dime10/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/dime10/subscriptions", "organizations_url": "https://api.github.com/users/dime10/orgs", "repos_url": "https://api.github.com/users/dime10/repos", "events_url": "https://api.github.com/users/dime10/events{/privacy}", "received_events_url": "https://api.github.com/users/dime10/received_events", "type": "User", "site_admin": false }
[ { "id": 404586594, "node_id": "MDU6TGFiZWw0MDQ1ODY1OTQ=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/stat:awaiting%20tensorflower", "name": "stat:awaiting tensorflower", "color": "f4b400", "default": false, "description": "Status - Awaiting response from tensorflower" }, { "id": 473184161, "node_id": "MDU6TGFiZWw0NzMxODQxNjE=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/type:support", "name": "type:support", "color": "159b2e", "default": false, "description": "Support issues" }, { "id": 1133285679, "node_id": "MDU6TGFiZWwxMTMzMjg1Njc5", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/comp:xla", "name": "comp:xla", "color": "0052cc", "default": false, "description": "XLA" } ]
open
false
{ "login": "cheshire", "id": 348959, "node_id": "MDQ6VXNlcjM0ODk1OQ==", "avatar_url": "https://avatars.githubusercontent.com/u/348959?v=4", "gravatar_id": "", "url": "https://api.github.com/users/cheshire", "html_url": "https://github.com/cheshire", "followers_url": "https://api.github.com/users/cheshire/followers", "following_url": "https://api.github.com/users/cheshire/following{/other_user}", "gists_url": "https://api.github.com/users/cheshire/gists{/gist_id}", "starred_url": "https://api.github.com/users/cheshire/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/cheshire/subscriptions", "organizations_url": "https://api.github.com/users/cheshire/orgs", "repos_url": "https://api.github.com/users/cheshire/repos", "events_url": "https://api.github.com/users/cheshire/events{/privacy}", "received_events_url": "https://api.github.com/users/cheshire/received_events", "type": "User", "site_admin": false }
[ { "login": "cheshire", "id": 348959, "node_id": "MDQ6VXNlcjM0ODk1OQ==", "avatar_url": "https://avatars.githubusercontent.com/u/348959?v=4", "gravatar_id": "", "url": "https://api.github.com/users/cheshire", "html_url": "https://github.com/cheshire", "followers_url": "https://api.github.com/users/cheshire/followers", "following_url": "https://api.github.com/users/cheshire/following{/other_user}", "gists_url": "https://api.github.com/users/cheshire/gists{/gist_id}", "starred_url": "https://api.github.com/users/cheshire/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/cheshire/subscriptions", "organizations_url": "https://api.github.com/users/cheshire/orgs", "repos_url": "https://api.github.com/users/cheshire/repos", "events_url": "https://api.github.com/users/cheshire/events{/privacy}", "received_events_url": "https://api.github.com/users/cheshire/received_events", "type": "User", "site_admin": false }, { "login": "sachinprasadhs", "id": 73069040, "node_id": "MDQ6VXNlcjczMDY5MDQw", "avatar_url": "https://avatars.githubusercontent.com/u/73069040?v=4", "gravatar_id": "", "url": "https://api.github.com/users/sachinprasadhs", "html_url": "https://github.com/sachinprasadhs", "followers_url": "https://api.github.com/users/sachinprasadhs/followers", "following_url": "https://api.github.com/users/sachinprasadhs/following{/other_user}", "gists_url": "https://api.github.com/users/sachinprasadhs/gists{/gist_id}", "starred_url": "https://api.github.com/users/sachinprasadhs/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sachinprasadhs/subscriptions", "organizations_url": "https://api.github.com/users/sachinprasadhs/orgs", "repos_url": "https://api.github.com/users/sachinprasadhs/repos", "events_url": "https://api.github.com/users/sachinprasadhs/events{/privacy}", "received_events_url": "https://api.github.com/users/sachinprasadhs/received_events", "type": "User", "site_admin": false } ]
null
[]
2023-04-11T22:31:00
2023-05-04T19:37:08
null
NONE
null
null
null
<details><summary>Click to expand!</summary> ### Issue Type Support ### Have you reproduced the bug with TF nightly? No ### Source source ### Tensorflow Version main branch ### Custom Code Yes ### OS Platform and Distribution _No response_ ### Mobile device _No response_ ### Python version _No response_ ### Bazel version _No response_ ### GCC/Compiler version _No response_ ### CUDA/cuDNN version _No response_ ### GPU model and memory _No response_ ### Current Behaviour? See below. ### Standalone code to reproduce the issue ```shell mhlo.scatter ``` ### Relevant log output _No response_</details> ### Problem Statement Is there a pass (sequence) that can lower the `mhlo.scatter` operation to standard MLIR dialects, such as linalg, tensor, arith, and/or scf? The goal is to ultimately lower to the LLVM dialect and perform codegen with LLVM. I wasn't able to find a pass that converts the `mhlo.scatter` op out of the MLIR-HLO dialect domain. Most other ops can be converter via passes like `--hlo-legalize-to-linalg`, `--mhlo-legalize-to-std`, or `--mhlo-legalize-control-flow`. (Duplicate of https://github.com/tensorflow/mlir-hlo/issues/64 since I'm not sure that repository is monitored for issues.)
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/60295/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/60295/timeline
null
null
false
https://api.github.com/repos/tensorflow/tensorflow/issues/60294
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/60294/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/60294/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/60294/events
https://github.com/tensorflow/tensorflow/issues/60294
1,663,255,930
I_kwDOArmXAs5jI0V6
60,294
tensorflow.python.framework.errors_impl.NotFoundError: Key conv1/kernel not found in checkpoint
{ "login": "TimofeyVO", "id": 130510544, "node_id": "U_kgDOB8du0A", "avatar_url": "https://avatars.githubusercontent.com/u/130510544?v=4", "gravatar_id": "", "url": "https://api.github.com/users/TimofeyVO", "html_url": "https://github.com/TimofeyVO", "followers_url": "https://api.github.com/users/TimofeyVO/followers", "following_url": "https://api.github.com/users/TimofeyVO/following{/other_user}", "gists_url": "https://api.github.com/users/TimofeyVO/gists{/gist_id}", "starred_url": "https://api.github.com/users/TimofeyVO/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/TimofeyVO/subscriptions", "organizations_url": "https://api.github.com/users/TimofeyVO/orgs", "repos_url": "https://api.github.com/users/TimofeyVO/repos", "events_url": "https://api.github.com/users/TimofeyVO/events{/privacy}", "received_events_url": "https://api.github.com/users/TimofeyVO/received_events", "type": "User", "site_admin": false }
[ { "id": 473172988, "node_id": "MDU6TGFiZWw0NzMxNzI5ODg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/type:bug", "name": "type:bug", "color": "159b2e", "default": false, "description": "Bug" }, { "id": 1097546578, "node_id": "MDU6TGFiZWwxMDk3NTQ2NTc4", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/comp:keras", "name": "comp:keras", "color": "0052cc", "default": false, "description": "Keras related issues" }, { "id": 5206407904, "node_id": "LA_kwDOArmXAs8AAAABNlN64A", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/TF%202.12", "name": "TF 2.12", "color": "c5def5", "default": false, "description": "For issues related to Tensorflow 2.12" } ]
closed
false
{ "login": "tilakrayal", "id": 81610181, "node_id": "MDQ6VXNlcjgxNjEwMTgx", "avatar_url": "https://avatars.githubusercontent.com/u/81610181?v=4", "gravatar_id": "", "url": "https://api.github.com/users/tilakrayal", "html_url": "https://github.com/tilakrayal", "followers_url": "https://api.github.com/users/tilakrayal/followers", "following_url": "https://api.github.com/users/tilakrayal/following{/other_user}", "gists_url": "https://api.github.com/users/tilakrayal/gists{/gist_id}", "starred_url": "https://api.github.com/users/tilakrayal/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/tilakrayal/subscriptions", "organizations_url": "https://api.github.com/users/tilakrayal/orgs", "repos_url": "https://api.github.com/users/tilakrayal/repos", "events_url": "https://api.github.com/users/tilakrayal/events{/privacy}", "received_events_url": "https://api.github.com/users/tilakrayal/received_events", "type": "User", "site_admin": false }
[ { "login": "tilakrayal", "id": 81610181, "node_id": "MDQ6VXNlcjgxNjEwMTgx", "avatar_url": "https://avatars.githubusercontent.com/u/81610181?v=4", "gravatar_id": "", "url": "https://api.github.com/users/tilakrayal", "html_url": "https://github.com/tilakrayal", "followers_url": "https://api.github.com/users/tilakrayal/followers", "following_url": "https://api.github.com/users/tilakrayal/following{/other_user}", "gists_url": "https://api.github.com/users/tilakrayal/gists{/gist_id}", "starred_url": "https://api.github.com/users/tilakrayal/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/tilakrayal/subscriptions", "organizations_url": "https://api.github.com/users/tilakrayal/orgs", "repos_url": "https://api.github.com/users/tilakrayal/repos", "events_url": "https://api.github.com/users/tilakrayal/events{/privacy}", "received_events_url": "https://api.github.com/users/tilakrayal/received_events", "type": "User", "site_admin": false } ]
null
[ "@TimofeyVO,\r\nI was facing a different issue while executing the mentioned code. Kindly find the gist of it [here](https://colab.research.google.com/gist/tilakrayal/0d6564af601c83c9fdab62cb4b30855a/untitled1068.ipynb) and provide required dependencies which helps to reproduce the issue. \r\n\r\nWhen you give the validation data as a variable it throws the Graph execution error. (for instance when you try to write \"model.predict([[a,b]]))\". But when you give an integer or float (model.predict([[17,2]])) it works and execution will happen.\r\n We can bypassed the problem by writing **\"model.predict([[float(a),float(b)]])\"** (We can also use the related type instead of float) Also there are similar issues that are still with the developer and they are working on the same.\r\nhttps://github.com/keras-team/tf-keras/issues/66\r\nhttps://github.com/keras-team/tf-keras/issues/639\r\n\r\nThank you!", "> \r\nIf I understood your remark correctly, then what\r\n1 file - mit_data_processing.py\r\n2 file - train_face_id.py\r\n3 file - test_face_id.py\r\n\r\nIn this screenshot, the file name should not be\r\n![image](https://user-images.githubusercontent.com/130510544/231477021-3a4fd35b-fdec-433c-8fc9-a3300000e6da.png)\r\n", "Are you satisfied with the resolution of your issue?\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=Yes&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/60294\">Yes</a>\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=No&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/60294\">No</a>\n" ]
2023-04-11T21:39:52
2023-09-22T18:22:46
2023-04-13T10:06:17
NONE
null
null
null
<details><summary>Click to expand!</summary> ### Issue Type Bug ### Have you reproduced the bug with TF nightly? Yes ### Source source ### Tensorflow Version 2.12.0 ### Custom Code Yes ### OS Platform and Distribution Windows x64 ### Mobile device _No response_ ### Python version 3.10 ### Bazel version _No response_ ### GCC/Compiler version _No response_ ### CUDA/cuDNN version _No response_ ### GPU model and memory _No response_ ### Current Behaviour? Hi everyone, I'm a novice programmer, I decided to create a neural network for facial recognition. I have encountered such an error. ```shell C:\Users\wefy2\AppData\Local\Programs\Python\Python310\python.exe C:/Users/wefy2/PycharmProjects/CNN-Facial-Recognition-master1/test_face_id.py WARNING:tensorflow:From C:\Users\wefy2\AppData\Local\Programs\Python\Python310\lib\site-packages\tensorflow\python\compat\v2_compat.py:107: disable_resource_variables (from tensorflow.python.ops.variable_scope) is deprecated and will be removed in a future version. Instructions for updating: non-resource variables are not supported in the long term WARNING:tensorflow:From C:\Users\wefy2\AppData\Local\Programs\Python\Python310\lib\site-packages\keras\layers\normalization\batch_normalization.py:581: _colocate_with (from tensorflow.python.framework.ops) is deprecated and will be removed in a future version. Instructions for updating: Colocations handled automatically by placer. 2023-04-11 23:01:13.568545: W tensorflow/c/c_api.cc:300] Operation '{name:'conv_dw_12_bn/gamma/Assign' id:1939 op device:{requested: '', assigned: ''} def:{{{node conv_dw_12_bn/gamma/Assign}} = AssignVariableOp[_has_manual_control_dependencies=true, dtype=DT_FLOAT, validate_shape=false](conv_dw_12_bn/gamma, conv_dw_12_bn/gamma/Initializer/ones)}}' was changed by setting attribute after it was run by a session. This mutation will have no effect, and will trigger an error in the future. Either don't modify nodes after running them or create a new session. 2023-04-11 23:01:15.059810: W tensorflow/core/framework/op_kernel.cc:1830] OP_REQUIRES failed at save_restore_v2_ops.cc:228 : NOT_FOUND: Key conv1/kernel not found in checkpoint WARNING:tensorflow:Restoring an object-based checkpoint using a name-based saver. This may be somewhat fragile, and will re-build the Saver. Instead, consider loading object-based checkpoints using tf.train.Checkpoint(). Traceback (most recent call last): File "C:\Users\wefy2\AppData\Local\Programs\Python\Python310\lib\site-packages\tensorflow\python\client\session.py", line 1378, in _do_call return fn(*args) File "C:\Users\wefy2\AppData\Local\Programs\Python\Python310\lib\site-packages\tensorflow\python\client\session.py", line 1361, in _run_fn return self._call_tf_sessionrun(options, feed_dict, fetch_list, File "C:\Users\wefy2\AppData\Local\Programs\Python\Python310\lib\site-packages\tensorflow\python\client\session.py", line 1454, in _call_tf_sessionrun return tf_session.TF_SessionRun_wrapper(self._session, options, feed_dict, tensorflow.python.framework.errors_impl.NotFoundError: Key conv1/kernel not found in checkpoint [[{{node save/RestoreV2}}]] During handling of the above exception, another exception occurred: Traceback (most recent call last): File "C:\Users\wefy2\AppData\Local\Programs\Python\Python310\lib\site-packages\tensorflow\python\training\saver.py", line 1418, in restore sess.run(self.saver_def.restore_op_name, File "C:\Users\wefy2\AppData\Local\Programs\Python\Python310\lib\site-packages\tensorflow\python\client\session.py", line 968, in run result = self._run(None, fetches, feed_dict, options_ptr, File "C:\Users\wefy2\AppData\Local\Programs\Python\Python310\lib\site-packages\tensorflow\python\client\session.py", line 1191, in _run results = self._do_run(handle, final_targets, final_fetches, File "C:\Users\wefy2\AppData\Local\Programs\Python\Python310\lib\site-packages\tensorflow\python\client\session.py", line 1371, in _do_run return self._do_call(_run_fn, feeds, fetches, targets, options, File "C:\Users\wefy2\AppData\Local\Programs\Python\Python310\lib\site-packages\tensorflow\python\client\session.py", line 1397, in _do_call raise type(e)(node_def, op, message) # pylint: disable=no-value-for-parameter tensorflow.python.framework.errors_impl.NotFoundError: Graph execution error: Detected at node 'save/RestoreV2' defined at (most recent call last): File "C:\Users\wefy2\PycharmProjects\CNN-Facial-Recognition-master1\test_face_id.py", line 66, in <module> test_nn.load_network() File "C:\Users\wefy2\PycharmProjects\CNN-Facial-Recognition-master1\test_face_id.py", line 25, in load_network saver = tf.train.Saver() Node: 'save/RestoreV2' Key conv1/kernel not found in checkpoint [[{{node save/RestoreV2}}]] Original stack trace for 'save/RestoreV2': File "C:\Users\wefy2\PycharmProjects\CNN-Facial-Recognition-master1\test_face_id.py", line 66, in <module> test_nn.load_network() File "C:\Users\wefy2\PycharmProjects\CNN-Facial-Recognition-master1\test_face_id.py", line 25, in load_network saver = tf.train.Saver() File "C:\Users\wefy2\AppData\Local\Programs\Python\Python310\lib\site-packages\tensorflow\python\training\saver.py", line 934, in __init__ self.build() File "C:\Users\wefy2\AppData\Local\Programs\Python\Python310\lib\site-packages\tensorflow\python\training\saver.py", line 946, in build self._build(self._filename, build_save=True, build_restore=True) File "C:\Users\wefy2\AppData\Local\Programs\Python\Python310\lib\site-packages\tensorflow\python\training\saver.py", line 974, in _build self.saver_def = self._builder._build_internal( # pylint: disable=protected-access File "C:\Users\wefy2\AppData\Local\Programs\Python\Python310\lib\site-packages\tensorflow\python\training\saver.py", line 543, in _build_internal restore_op = self._AddRestoreOps(filename_tensor, saveables, File "C:\Users\wefy2\AppData\Local\Programs\Python\Python310\lib\site-packages\tensorflow\python\training\saver.py", line 360, in _AddRestoreOps all_tensors = self.bulk_restore(filename_tensor, saveables, preferred_shard, File "C:\Users\wefy2\AppData\Local\Programs\Python\Python310\lib\site-packages\tensorflow\python\training\saver.py", line 611, in bulk_restore return io_ops.restore_v2(filename_tensor, names, slices, dtypes) File "C:\Users\wefy2\AppData\Local\Programs\Python\Python310\lib\site-packages\tensorflow\python\ops\gen_io_ops.py", line 1604, in restore_v2 _, _, _op, _outputs = _op_def_library._apply_op_helper( File "C:\Users\wefy2\AppData\Local\Programs\Python\Python310\lib\site-packages\tensorflow\python\framework\op_def_library.py", line 795, in _apply_op_helper op = g._create_op_internal(op_type_name, inputs, dtypes=None, File "C:\Users\wefy2\AppData\Local\Programs\Python\Python310\lib\site-packages\tensorflow\python\framework\ops.py", line 3814, in _create_op_internal ret = Operation( During handling of the above exception, another exception occurred: Traceback (most recent call last): File "C:\Users\wefy2\PycharmProjects\CNN-Facial-Recognition-master1\test_face_id.py", line 66, in <module> test_nn.load_network() File "C:\Users\wefy2\PycharmProjects\CNN-Facial-Recognition-master1\test_face_id.py", line 27, in load_network saver.restore(self.sess, path) File "C:\Users\wefy2\AppData\Local\Programs\Python\Python310\lib\site-packages\tensorflow\python\training\saver.py", line 1444, in restore self._object_restore_saver = saver_from_object_based_checkpoint( File "C:\Users\wefy2\AppData\Local\Programs\Python\Python310\lib\site-packages\tensorflow\python\training\saver.py", line 1826, in saver_from_object_based_checkpoint raise errors.NotFoundError( tensorflow.python.framework.errors_impl.NotFoundError: Existing variables not in the checkpoint: conv1/kernel, conv1_bn/beta, conv1_bn/gamma, conv1_bn/moving_mean, conv1_bn/moving_variance, conv_dw_1/depthwise_kernel, conv_dw_10/depthwise_kernel, conv_dw_10_bn/beta, conv_dw_10_bn/gamma, conv_dw_10_bn/moving_mean, conv_dw_10_bn/moving_variance, conv_dw_11/depthwise_kernel, conv_dw_11_bn/beta, conv_dw_11_bn/gamma, conv_dw_11_bn/moving_mean, conv_dw_11_bn/moving_variance, conv_dw_12/depthwise_kernel, conv_dw_12_bn/beta, conv_dw_12_bn/gamma, conv_dw_12_bn/moving_mean, conv_dw_12_bn/moving_variance, conv_dw_13/depthwise_kernel, conv_dw_13_bn/beta, conv_dw_13_bn/gamma, conv_dw_13_bn/moving_mean, conv_dw_13_bn/moving_variance, conv_dw_1_bn/beta, conv_dw_1_bn/gamma, conv_dw_1_bn/moving_mean, conv_dw_1_bn/moving_variance, conv_dw_2/depthwise_kernel, conv_dw_2_bn/beta, conv_dw_2_bn/gamma, conv_dw_2_bn/moving_mean, conv_dw_2_bn/moving_variance, conv_dw_3/depthwise_kernel, conv_dw_3_bn/beta, conv_dw_3_bn/gamma, conv_dw_3_bn/moving_mean, conv_dw_3_bn/moving_variance, conv_dw_4/depthwise_kernel, conv_dw_4_bn/beta, conv_dw_4_bn/gamma, conv_dw_4_bn/moving_mean, conv_dw_4_bn/moving_variance, conv_dw_5/depthwise_kernel, conv_dw_5_bn/beta, conv_dw_5_bn/gamma, conv_dw_5_bn/moving_mean, conv_dw_5_bn/moving_variance, conv_dw_6/depthwise_kernel, conv_dw_6_bn/beta, conv_dw_6_bn/gamma, conv_dw_6_bn/moving_mean, conv_dw_6_bn/moving_variance, conv_dw_7/depthwise_kernel, conv_dw_7_bn/beta, conv_dw_7_bn/gamma, conv_dw_7_bn/moving_mean, conv_dw_7_bn/moving_variance, conv_dw_8/depthwise_kernel, conv_dw_8_bn/beta, conv_dw_8_bn/gamma, conv_dw_8_bn/moving_mean, conv_dw_8_bn/moving_variance, conv_dw_9/depthwise_kernel, conv_dw_9_bn/beta, conv_dw_9_bn/gamma, conv_dw_9_bn/moving_mean, conv_dw_9_bn/moving_variance, conv_pw_1/kernel, conv_pw_10/kernel, conv_pw_10_bn/beta, conv_pw_10_bn/gamma, conv_pw_10_bn/moving_mean, conv_pw_10_bn/moving_variance, conv_pw_11/kernel, conv_pw_11_bn/beta, conv_pw_11_bn/gamma, conv_pw_11_bn/moving_mean, conv_pw_11_bn/moving_variance, conv_pw_12/kernel, conv_pw_12_bn/beta, conv_pw_12_bn/gamma, conv_pw_12_bn/moving_mean, conv_pw_12_bn/moving_variance, conv_pw_13/kernel, conv_pw_13_bn/beta, conv_pw_13_bn/gamma, conv_pw_13_bn/moving_mean, conv_pw_13_bn/moving_variance, conv_pw_1_bn/beta, conv_pw_1_bn/gamma, conv_pw_1_bn/moving_mean, conv_pw_1_bn/moving_variance, conv_pw_2/kernel, conv_pw_2_bn/beta, conv_pw_2_bn/gamma, conv_pw_2_bn/moving_mean, conv_pw_2_bn/moving_variance, conv_pw_3/kernel, conv_pw_3_bn/beta, conv_pw_3_bn/gamma, conv_pw_3_bn/moving_mean, conv_pw_3_bn/moving_variance, conv_pw_4/kernel, conv_pw_4_bn/beta, conv_pw_4_bn/gamma, conv_pw_4_bn/moving_mean, conv_pw_4_bn/moving_variance, conv_pw_5/kernel, conv_pw_5_bn/beta, conv_pw_5_bn/gamma, conv_pw_5_bn/moving_mean, conv_pw_5_bn/moving_variance, conv_pw_6/kernel, conv_pw_6_bn/beta, conv_pw_6_bn/gamma, conv_pw_6_bn/moving_mean, conv_pw_6_bn/moving_variance, conv_pw_7/kernel, conv_pw_7_bn/beta, conv_pw_7_bn/gamma, conv_pw_7_bn/moving_mean, conv_pw_7_bn/moving_variance, conv_pw_8/kernel, conv_pw_8_bn/beta, conv_pw_8_bn/gamma, conv_pw_8_bn/moving_mean, conv_pw_8_bn/moving_variance, conv_pw_9/kernel, conv_pw_9_bn/beta, conv_pw_9_bn/gamma, conv_pw_9_bn/moving_mean, conv_pw_9_bn/moving_variance Variables names when this checkpoint was written which don't exist now: Adam/m/conv2d/bias, Adam/m/conv2d/kernel, Adam/m/conv2d_1/bias, Adam/m/conv2d_1/kernel, Adam/m/conv2d_2/bias, Adam/m/conv2d_2/kernel, Adam/m/conv2d_3/bias, Adam/m/conv2d_3/kernel, Adam/m/dense/bias, Adam/m/dense/kernel, Adam/m/dense_1/bias, Adam/m/dense_1/kernel, Adam/v/conv2d/bias, Adam/v/conv2d/kernel, Adam/v/conv2d_1/bias, Adam/v/conv2d_1/kernel, Adam/v/conv2d_2/bias, Adam/v/conv2d_2/kernel, Adam/v/conv2d_3/bias, Adam/v/conv2d_3/kernel, Adam/v/dense/bias, Adam/v/dense/kernel, Adam/v/dense_1/bias, Adam/v/dense_1/kernel, conv2d/bias, conv2d/kernel, conv2d_1/bias, conv2d_1/kernel, conv2d_2/bias, conv2d_2/kernel, conv2d_3/bias, conv2d_3/kernel, count, iteration, learning_rate, total (4 variable name(s) did match) Could not find some variables in the checkpoint (see names above). Saver was attempting to load an object-based checkpoint (saved using tf.train.Checkpoint or tf.keras.Model.save_weights) using variable names. If the checkpoint was written with eager execution enabled, it's possible that variable names have changed (for example missing a '_1' suffix). It's also possible that there are new variables which did not exist when the checkpoint was written. You can construct a Saver(var_list=...) with only the variables which previously existed, and if variable names have changed you may need to make this a dictionary with the old names as keys. If you're using an Estimator, you'll need to return a tf.train.Saver inside a tf.train.Scaffold from your model_fn. Process finished with exit code 1 ``` I suspect that this problem is that the error occurs when loading the weights of the test_nn model from the saved checkpoints. It reports that some variables in the saved checkpoint do not correspond to variables in the model, because there are no corresponding stored values for them. Or because of a mismatch of tensorflow library versions mit_data_processing.py ```shell import cv2 import glob import numpy as np save_to = 'C:\\Users\\wefy2\\PycharmProjects\\CNN-Facial-Recognition-master1\\data' all_faces = [img for img in glob.glob('C:\\Users\\wefy2\\PycharmProjects\\CNN-Facial-Recognition-master1\\data\\gt_db\\s*\\*.jpg')] faces_x = [] faces_y = [] faceCascade = cv2.CascadeClassifier('data\\haarcascade_frontalface.xml') for i, face in enumerate(all_faces): image = cv2.imread(face) gray = cv2.cvtColor(image, cv2.COLOR_BGR2GRAY) faces = faceCascade.detectMultiScale(gray, 1.3, 5) if len(faces) == 1: x, y, w, h = faces[0] cropped_img = image[y:y + h, x:x + w] faces_x.append(cv2.resize(cropped_img, (128, 128))) faces_y.append(int(face.split('\\')[-2][1:])) print('Finished: ', i, ' Out of: ', len(all_faces)) faces_x, faces_y = np.array(faces_x), np.array(faces_y) np.save(save_to + 'x_train', faces_x) np.save(save_to + 'y_train', faces_y) ``` train_face_id.py ``` import numpy as np import tensorflow as tf import tensorflow_addons as tfa # loading data faces_x = np.load('datax_train.npy') faces_y = np.load('datay_train.npy') faces_x = tf.expand_dims(faces_x, axis=0) faces_y = tf.expand_dims(faces_y, axis=0) train_dataset = tf.data.Dataset.from_tensor_slices((faces_x, faces_y)) print('Faces were loaded successfully.') print (tf.__version__) # Construct the fully connected hashing layers model = tf.keras.Sequential([ tf.keras.layers.Conv2D(filters=64, kernel_size=3, padding='same', activation='relu', input_shape=(128, 128, 3)), tf.keras.layers.MaxPooling2D(pool_size=2), tf.keras.layers.Dropout(0.3), tf.keras.layers.Conv2D(filters=64, kernel_size=3, padding='same', activation='relu', input_shape=(128, 128, 3)), tf.keras.layers.MaxPooling2D(pool_size=2), tf.keras.layers.Dropout(0.3), tf.keras.layers.Conv2D(filters=32, kernel_size=2, padding='same', activation='relu'), tf.keras.layers.MaxPooling2D(pool_size=2), tf.keras.layers.Dropout(0.3), tf.keras.layers.Conv2D(filters=32, kernel_size=2, padding='same', activation='relu'), tf.keras.layers.MaxPooling2D(pool_size=2), tf.keras.layers.Dropout(0.3), tf.keras.layers.Flatten(), tf.keras.layers.Dense(256, activation='relu'), tf.keras.layers.Dropout(0.3), tf.keras.layers.Dense(128, activation='sigmoid') ]) # Compile the model model.compile( optimizer=tf.keras.optimizers.Adam(0.001), loss=tfa.losses.TripletSemiHardLoss(margin=3.0)) print(model.summary()) print('Model Compiled Successfully.') # Train the model print('Training has started.') history = model.fit(train_dataset, epochs=10, verbose=1) # Save the model model.save('models/face_id_model') print('Training is finished.') ``` test_face_id.py ``` import numpy as np import cv2 import tensorflow.compat.v1 as tf tf.disable_v2_behavior() class FaceID: def __init__(self): model = tf.keras.Sequential() net = tf.keras.applications.MobileNet(input_shape=(128, 128, 3), weights='imagenet', include_top=False) model.add(net) model.add(tf.keras.layers.GlobalAveragePooling2D()) self.features_extractor = model self.x_holder = tf.placeholder(shape=[None, 1024], dtype=tf.float32) fc_1 = tf.layers.Dense(units=512, activation=tf.nn.relu)(self.x_holder) fc_2 = tf.layers.Dense(units=128, activation=tf.nn.sigmoid)(fc_1) self.face_id = fc_2 self.sess = None def load_network(self, path='models\\face_id_model\\variables\\variables'): saver = tf.train.Saver() self.sess = tf.Session() saver.restore(self.sess, path) def get_id(self, imgs): imgs = imgs.reshape((-1, 128, 128, 3)) features = self.features_extractor.predict(imgs) embeds = self.sess.run([self.face_id], feed_dict={self.x_holder: features}) return embeds[0] class FaceExtractor: def __init__(self, cascade_path='data\\haarcascade_frontalface.xml'): self.faceCascade = cv2.CascadeClassifier(cascade_path) def extract_single_face_from_path(self, img_path): image = cv2.imread(img_path) gray = cv2.cvtColor(image, cv2.COLOR_BGR2GRAY) faces = self.faceCascade.detectMultiScale(gray, 1.3, 5) if len(faces) == 1: x, y, w, h = faces[0] cropped_img = image[y:y + h, x:x + w] return cv2.resize(cropped_img, (128, 128)) else: faces = self.faceCascade.detectMultiScale(gray, 1.3, 10) if len(faces) == 1: x, y, w, h = faces[0] cropped_img = image[y:y + h, x:x + w] return cv2.resize(cropped_img, (128, 128)) return None def faces_from_image(self, image): gray = cv2.cvtColor(image, cv2.COLOR_BGR2GRAY) return self.faceCascade.detectMultiScale(gray, 1.3, 5) test_nn = FaceID() face_ex = FaceExtractor() test_nn.load_network() ref_face = face_ex.extract_single_face_from_path("ref.jpg") ref_face_hash = test_nn.get_id(ref_face)[0] cap = cv2.VideoCapture(0) while True: ret, frame = cap.read() faces = face_ex.faces_from_image(frame) for face in faces: x, y, w, h = face cropped_face = cv2.resize(frame[y:y + h, x:x + w], (128, 128)) cropped_hash = test_nn.get_id(cropped_face)[0] cv2.rectangle(frame, (x, y), (x + w, y + h), 1, 3) distance_1 = np.sum(np.power(ref_face_hash - cropped_hash, 2)) if distance_1 <= 3: cv2.putText(frame, 'ref ', (x, y + h + 30), cv2.FONT_HERSHEY_SIMPLEX, 1, 1, 2, cv2.LINE_AA) else: cv2.putText(frame, 'Nan ', (x, y + h + 30), cv2.FONT_HERSHEY_SIMPLEX, 1, 1, 2, cv2.LINE_AA) cv2.imshow('My FaceID', frame) if cv2.waitKey(1) & 0xFF == ord('q'): ret, frame = cap.read() break ``` ``` ### Relevant log output _No response_</details>
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/60294/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/60294/timeline
null
completed
false
https://api.github.com/repos/tensorflow/tensorflow/issues/60293
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/60293/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/60293/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/60293/events
https://github.com/tensorflow/tensorflow/pull/60293
1,662,830,888
PR_kwDOArmXAs5OCtvd
60,293
build: add missing dependency on tablegen-generated files
{ "login": "ashay", "id": 19678, "node_id": "MDQ6VXNlcjE5Njc4", "avatar_url": "https://avatars.githubusercontent.com/u/19678?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ashay", "html_url": "https://github.com/ashay", "followers_url": "https://api.github.com/users/ashay/followers", "following_url": "https://api.github.com/users/ashay/following{/other_user}", "gists_url": "https://api.github.com/users/ashay/gists{/gist_id}", "starred_url": "https://api.github.com/users/ashay/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ashay/subscriptions", "organizations_url": "https://api.github.com/users/ashay/orgs", "repos_url": "https://api.github.com/users/ashay/repos", "events_url": "https://api.github.com/users/ashay/events{/privacy}", "received_events_url": "https://api.github.com/users/ashay/received_events", "type": "User", "site_admin": false }
[ { "id": 390482148, "node_id": "MDU6TGFiZWwzOTA0ODIxNDg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/awaiting%20review", "name": "awaiting review", "color": "bc3869", "default": false, "description": "Pull request awaiting review" }, { "id": 987666414, "node_id": "MDU6TGFiZWw5ODc2NjY0MTQ=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/ready%20to%20pull", "name": "ready to pull", "color": "2cd643", "default": false, "description": "PR ready for merge process" }, { "id": 1133285679, "node_id": "MDU6TGFiZWwxMTMzMjg1Njc5", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/comp:xla", "name": "comp:xla", "color": "0052cc", "default": false, "description": "XLA" }, { "id": 1169364259, "node_id": "MDU6TGFiZWwxMTY5MzY0MjU5", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/size:XS", "name": "size:XS", "color": "adafea", "default": false, "description": "CL Change Size: Extra Small" } ]
closed
false
{ "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false }
[ { "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false } ]
null
[]
2023-04-11T16:11:45
2023-04-24T11:58:13
2023-04-24T11:58:12
MEMBER
null
false
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/pulls/60293", "html_url": "https://github.com/tensorflow/tensorflow/pull/60293", "diff_url": "https://github.com/tensorflow/tensorflow/pull/60293.diff", "patch_url": "https://github.com/tensorflow/tensorflow/pull/60293.patch", "merged_at": "2023-04-24T11:58:12" }
The transforms/generic_host_to_llvm.cc file includes deallocation_ops.h, which includes a few tablegen-generated files that are produced by the `MLIRDeallocationPassesIncGen` target. However, this dependency on `MLIRDeallocationPassesIncGen` is missing from the CMake rules, which causes build errors like so: ``` In file included from transforms/generic_host_to_llvm.cc:19: deallocation/transforms/passes.h:62:10: fatal error: 'deallocation/transforms/passes.h.inc' file not found ``` This patch adds the missing dependency.
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/60293/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/60293/timeline
null
null
true
https://api.github.com/repos/tensorflow/tensorflow/issues/60292
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/60292/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/60292/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/60292/events
https://github.com/tensorflow/tensorflow/pull/60292
1,662,803,611
PR_kwDOArmXAs5OCnxp
60,292
[INTEL oneDNN] Refactoring: replace/remove MKL ML API calls
{ "login": "gzmkl", "id": 29215195, "node_id": "MDQ6VXNlcjI5MjE1MTk1", "avatar_url": "https://avatars.githubusercontent.com/u/29215195?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gzmkl", "html_url": "https://github.com/gzmkl", "followers_url": "https://api.github.com/users/gzmkl/followers", "following_url": "https://api.github.com/users/gzmkl/following{/other_user}", "gists_url": "https://api.github.com/users/gzmkl/gists{/gist_id}", "starred_url": "https://api.github.com/users/gzmkl/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gzmkl/subscriptions", "organizations_url": "https://api.github.com/users/gzmkl/orgs", "repos_url": "https://api.github.com/users/gzmkl/repos", "events_url": "https://api.github.com/users/gzmkl/events{/privacy}", "received_events_url": "https://api.github.com/users/gzmkl/received_events", "type": "User", "site_admin": false }
[ { "id": 1104829434, "node_id": "MDU6TGFiZWwxMTA0ODI5NDM0", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/comp:mkl", "name": "comp:mkl", "color": "0052cc", "default": false, "description": "MKL related issues" }, { "id": 1169365494, "node_id": "MDU6TGFiZWwxMTY5MzY1NDk0", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/size:M", "name": "size:M", "color": "adafea", "default": false, "description": "CL Change Size: Medium" } ]
closed
false
{ "login": "penpornk", "id": 38085909, "node_id": "MDQ6VXNlcjM4MDg1OTA5", "avatar_url": "https://avatars.githubusercontent.com/u/38085909?v=4", "gravatar_id": "", "url": "https://api.github.com/users/penpornk", "html_url": "https://github.com/penpornk", "followers_url": "https://api.github.com/users/penpornk/followers", "following_url": "https://api.github.com/users/penpornk/following{/other_user}", "gists_url": "https://api.github.com/users/penpornk/gists{/gist_id}", "starred_url": "https://api.github.com/users/penpornk/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/penpornk/subscriptions", "organizations_url": "https://api.github.com/users/penpornk/orgs", "repos_url": "https://api.github.com/users/penpornk/repos", "events_url": "https://api.github.com/users/penpornk/events{/privacy}", "received_events_url": "https://api.github.com/users/penpornk/received_events", "type": "User", "site_admin": false }
[ { "login": "penpornk", "id": 38085909, "node_id": "MDQ6VXNlcjM4MDg1OTA5", "avatar_url": "https://avatars.githubusercontent.com/u/38085909?v=4", "gravatar_id": "", "url": "https://api.github.com/users/penpornk", "html_url": "https://github.com/penpornk", "followers_url": "https://api.github.com/users/penpornk/followers", "following_url": "https://api.github.com/users/penpornk/following{/other_user}", "gists_url": "https://api.github.com/users/penpornk/gists{/gist_id}", "starred_url": "https://api.github.com/users/penpornk/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/penpornk/subscriptions", "organizations_url": "https://api.github.com/users/penpornk/orgs", "repos_url": "https://api.github.com/users/penpornk/repos", "events_url": "https://api.github.com/users/penpornk/events{/privacy}", "received_events_url": "https://api.github.com/users/penpornk/received_events", "type": "User", "site_admin": false }, { "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false } ]
null
[ "@penpornk Hi Penporn, I noticed that there were failures related internal CI and AMD ROCm build. But I am not sure if this PR caused them. The old should NOT be executed in recent years after we moved from MKL ML to MKL DNN (around 2017 or 18). \r\nPlease help to check. Thanks!\r\n\r\nMy next step is to clean up related bazel configuration (to get rid of \"if_mkl_ml\" staff). -GZ", "@gzmkl I haven't seen the latest ROCm results on this PR. (It's still running at the time I'm writing this comment.) But ROCm has been having infra failure lately. (It failed in many other PRs.) So it's likely unrelated to this PR. I'll take a look again after it's done running. :)", "@penpornk Please help to check the latest ROCm results on this PR. I could not find anything with the \"Details\" link. THANKS", "This PR is replaced by the new one (hopefully no more conflicts after oneDNN 3.x integration)\r\n\r\nhttps://github.com/tensorflow/tensorflow/pull/61471\r\n\r\nThus close this one\r\n" ]
2023-04-11T15:56:08
2023-08-04T00:27:46
2023-08-04T00:27:43
CONTRIBUTOR
null
false
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/pulls/60292", "html_url": "https://github.com/tensorflow/tensorflow/pull/60292", "diff_url": "https://github.com/tensorflow/tensorflow/pull/60292.diff", "patch_url": "https://github.com/tensorflow/tensorflow/pull/60292.patch", "merged_at": null }
MKL ML has been replaced by MKL DNN and now oneDNN. It is not supported anymore. In TensorFlow, there are still some MKL calls even though related methods and tests are NOT called any more. The PR replaces and removes calls to MKL ML (cblas) APIs which are not supported long time ago. 1. For FP32 Matmul, oneDNN dnnl_gemm() will be called. 2. For FP64 Matmul, it will NOT be supported as oneDNN currently does not support it. NEXT STEP: clean up MKL ML related configuration (bazel files).
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/60292/reactions", "total_count": 2, "+1": 2, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/60292/timeline
null
null
true
https://api.github.com/repos/tensorflow/tensorflow/issues/60291
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/60291/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/60291/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/60291/events
https://github.com/tensorflow/tensorflow/issues/60291
1,662,746,044
I_kwDOArmXAs5jG328
60,291
tf.random.truncated_normal (inside graph) crashed TPUv4 pod
{ "login": "edwardyehuang", "id": 3354448, "node_id": "MDQ6VXNlcjMzNTQ0NDg=", "avatar_url": "https://avatars.githubusercontent.com/u/3354448?v=4", "gravatar_id": "", "url": "https://api.github.com/users/edwardyehuang", "html_url": "https://github.com/edwardyehuang", "followers_url": "https://api.github.com/users/edwardyehuang/followers", "following_url": "https://api.github.com/users/edwardyehuang/following{/other_user}", "gists_url": "https://api.github.com/users/edwardyehuang/gists{/gist_id}", "starred_url": "https://api.github.com/users/edwardyehuang/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/edwardyehuang/subscriptions", "organizations_url": "https://api.github.com/users/edwardyehuang/orgs", "repos_url": "https://api.github.com/users/edwardyehuang/repos", "events_url": "https://api.github.com/users/edwardyehuang/events{/privacy}", "received_events_url": "https://api.github.com/users/edwardyehuang/received_events", "type": "User", "site_admin": false }
[ { "id": 386191887, "node_id": "MDU6TGFiZWwzODYxOTE4ODc=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/stat:awaiting%20response", "name": "stat:awaiting response", "color": "f4b400", "default": false, "description": "Status - Awaiting response from author" }, { "id": 473172988, "node_id": "MDU6TGFiZWw0NzMxNzI5ODg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/type:bug", "name": "type:bug", "color": "159b2e", "default": false, "description": "Bug" }, { "id": 474725938, "node_id": "MDU6TGFiZWw0NzQ3MjU5Mzg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/stale", "name": "stale", "color": "d4c5f9", "default": false, "description": "This label marks the issue/pr stale - to be closed automatically if no activity" }, { "id": 1097541661, "node_id": "MDU6TGFiZWwxMDk3NTQxNjYx", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/comp:tpus", "name": "comp:tpus", "color": "0052cc", "default": false, "description": "tpu, tpuestimator" }, { "id": 4511033337, "node_id": "LA_kwDOArmXAs8AAAABDODn-Q", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/TF%202.10", "name": "TF 2.10", "color": "C15088", "default": false, "description": "" } ]
closed
false
{ "login": "tilakrayal", "id": 81610181, "node_id": "MDQ6VXNlcjgxNjEwMTgx", "avatar_url": "https://avatars.githubusercontent.com/u/81610181?v=4", "gravatar_id": "", "url": "https://api.github.com/users/tilakrayal", "html_url": "https://github.com/tilakrayal", "followers_url": "https://api.github.com/users/tilakrayal/followers", "following_url": "https://api.github.com/users/tilakrayal/following{/other_user}", "gists_url": "https://api.github.com/users/tilakrayal/gists{/gist_id}", "starred_url": "https://api.github.com/users/tilakrayal/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/tilakrayal/subscriptions", "organizations_url": "https://api.github.com/users/tilakrayal/orgs", "repos_url": "https://api.github.com/users/tilakrayal/repos", "events_url": "https://api.github.com/users/tilakrayal/events{/privacy}", "received_events_url": "https://api.github.com/users/tilakrayal/received_events", "type": "User", "site_admin": false }
[ { "login": "tilakrayal", "id": 81610181, "node_id": "MDQ6VXNlcjgxNjEwMTgx", "avatar_url": "https://avatars.githubusercontent.com/u/81610181?v=4", "gravatar_id": "", "url": "https://api.github.com/users/tilakrayal", "html_url": "https://github.com/tilakrayal", "followers_url": "https://api.github.com/users/tilakrayal/followers", "following_url": "https://api.github.com/users/tilakrayal/following{/other_user}", "gists_url": "https://api.github.com/users/tilakrayal/gists{/gist_id}", "starred_url": "https://api.github.com/users/tilakrayal/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/tilakrayal/subscriptions", "organizations_url": "https://api.github.com/users/tilakrayal/orgs", "repos_url": "https://api.github.com/users/tilakrayal/repos", "events_url": "https://api.github.com/users/tilakrayal/events{/privacy}", "received_events_url": "https://api.github.com/users/tilakrayal/received_events", "type": "User", "site_admin": false } ]
null
[ "@edwardyehuang \r\nCould you please provide reproducible code or Colab gist to replicate the issue reported here ?\r\n\r\nThank you !", "This issue is stale because it has been open for 7 days with no activity. It will be closed if no further activity occurs. Thank you.", "This issue was closed because it has been inactive for 7 days since being marked as stale. Please reopen if you'd like to work on this further.", "Are you satisfied with the resolution of your issue?\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=Yes&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/60291\">Yes</a>\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=No&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/60291\">No</a>\n" ]
2023-04-11T15:26:08
2023-05-04T01:52:34
2023-05-04T01:52:31
CONTRIBUTOR
null
null
null
### Issue Type Bug ### Source source ### Tensorflow Version tf 2.10 TPU Pod ### Current Behaviour? I found ```tf.random.truncated_normal``` will crash the TPUv4 Pod during training (graph computation). ```tf.random.truncated_normal``` is fine when not in a graph (e.g. variable initialization). ```tf.random.normal``` and ```tf.random.uniform``` are fine during training. ### Relevant log output
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/60291/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/60291/timeline
null
completed
false
https://api.github.com/repos/tensorflow/tensorflow/issues/60290
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/60290/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/60290/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/60290/events
https://github.com/tensorflow/tensorflow/pull/60290
1,662,412,652
PR_kwDOArmXAs5OBRtY
60,290
Fix typos in CONTRIBUTING.md
{ "login": "AspireVenom", "id": 24754266, "node_id": "MDQ6VXNlcjI0NzU0MjY2", "avatar_url": "https://avatars.githubusercontent.com/u/24754266?v=4", "gravatar_id": "", "url": "https://api.github.com/users/AspireVenom", "html_url": "https://github.com/AspireVenom", "followers_url": "https://api.github.com/users/AspireVenom/followers", "following_url": "https://api.github.com/users/AspireVenom/following{/other_user}", "gists_url": "https://api.github.com/users/AspireVenom/gists{/gist_id}", "starred_url": "https://api.github.com/users/AspireVenom/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/AspireVenom/subscriptions", "organizations_url": "https://api.github.com/users/AspireVenom/orgs", "repos_url": "https://api.github.com/users/AspireVenom/repos", "events_url": "https://api.github.com/users/AspireVenom/events{/privacy}", "received_events_url": "https://api.github.com/users/AspireVenom/received_events", "type": "User", "site_admin": false }
[ { "id": 1169364458, "node_id": "MDU6TGFiZWwxMTY5MzY0NDU4", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/size:S", "name": "size:S", "color": "adafea", "default": false, "description": "CL Change Size: Small" } ]
closed
false
{ "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false }
[ { "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false } ]
null
[ "Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).\n\nView this [failed invocation](https://github.com/tensorflow/tensorflow/pull/60290/checks?check_run_id=12660438542) of the CLA check for more information.\n\nFor the most up to date status, view the checks section at the bottom of the pull request.", "Please don't use \"add file\"/\"update file\"/\"fix file\"/etc. commit messages. These are hard to reason about when looking at the history of the file/repository. Instead, please write explanatory git commit messages.\r\n\r\nThe commit message is also the title of the PR if the PR has only one commit. It is thus twice important to have commit messages that are relevant, as PRs would be easier to understand and easier to analyze in search results.\r\n\r\nFor how to write good quality git commit messages, please consult https://cbea.ms/git-commit/ ", "Hi @AspireVenom Can you please check @mihaimaruseac's comments and keep us posted ? Thank you!", "PR title changed, commit message not. But let's take it as it is and future commits would follow guidelines." ]
2023-04-11T12:50:57
2023-04-14T05:55:16
2023-04-14T05:55:13
NONE
null
false
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/pulls/60290", "html_url": "https://github.com/tensorflow/tensorflow/pull/60290", "diff_url": "https://github.com/tensorflow/tensorflow/pull/60290.diff", "patch_url": "https://github.com/tensorflow/tensorflow/pull/60290.patch", "merged_at": null }
Changed a couple of grammatical and spelling things within this document.
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/60290/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/60290/timeline
null
null
true
https://api.github.com/repos/tensorflow/tensorflow/issues/60289
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/60289/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/60289/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/60289/events
https://github.com/tensorflow/tensorflow/issues/60289
1,661,986,732
I_kwDOArmXAs5jD-es
60,289
Respect Keras layer names for output operations in Concrete Function
{ "login": "DLumi", "id": 69116001, "node_id": "MDQ6VXNlcjY5MTE2MDAx", "avatar_url": "https://avatars.githubusercontent.com/u/69116001?v=4", "gravatar_id": "", "url": "https://api.github.com/users/DLumi", "html_url": "https://github.com/DLumi", "followers_url": "https://api.github.com/users/DLumi/followers", "following_url": "https://api.github.com/users/DLumi/following{/other_user}", "gists_url": "https://api.github.com/users/DLumi/gists{/gist_id}", "starred_url": "https://api.github.com/users/DLumi/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/DLumi/subscriptions", "organizations_url": "https://api.github.com/users/DLumi/orgs", "repos_url": "https://api.github.com/users/DLumi/repos", "events_url": "https://api.github.com/users/DLumi/events{/privacy}", "received_events_url": "https://api.github.com/users/DLumi/received_events", "type": "User", "site_admin": false }
[ { "id": 404586594, "node_id": "MDU6TGFiZWw0MDQ1ODY1OTQ=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/stat:awaiting%20tensorflower", "name": "stat:awaiting tensorflower", "color": "f4b400", "default": false, "description": "Status - Awaiting response from tensorflower" }, { "id": 473172988, "node_id": "MDU6TGFiZWw0NzMxNzI5ODg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/type:bug", "name": "type:bug", "color": "159b2e", "default": false, "description": "Bug" }, { "id": 1097547147, "node_id": "MDU6TGFiZWwxMDk3NTQ3MTQ3", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/comp:ops", "name": "comp:ops", "color": "0052cc", "default": false, "description": "OPs related issues" }, { "id": 5206407904, "node_id": "LA_kwDOArmXAs8AAAABNlN64A", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/TF%202.12", "name": "TF 2.12", "color": "c5def5", "default": false, "description": "For issues related to Tensorflow 2.12" } ]
open
false
{ "login": "SuryanarayanaY", "id": 116063290, "node_id": "U_kgDOBur8Og", "avatar_url": "https://avatars.githubusercontent.com/u/116063290?v=4", "gravatar_id": "", "url": "https://api.github.com/users/SuryanarayanaY", "html_url": "https://github.com/SuryanarayanaY", "followers_url": "https://api.github.com/users/SuryanarayanaY/followers", "following_url": "https://api.github.com/users/SuryanarayanaY/following{/other_user}", "gists_url": "https://api.github.com/users/SuryanarayanaY/gists{/gist_id}", "starred_url": "https://api.github.com/users/SuryanarayanaY/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/SuryanarayanaY/subscriptions", "organizations_url": "https://api.github.com/users/SuryanarayanaY/orgs", "repos_url": "https://api.github.com/users/SuryanarayanaY/repos", "events_url": "https://api.github.com/users/SuryanarayanaY/events{/privacy}", "received_events_url": "https://api.github.com/users/SuryanarayanaY/received_events", "type": "User", "site_admin": false }
[ { "login": "SuryanarayanaY", "id": 116063290, "node_id": "U_kgDOBur8Og", "avatar_url": "https://avatars.githubusercontent.com/u/116063290?v=4", "gravatar_id": "", "url": "https://api.github.com/users/SuryanarayanaY", "html_url": "https://github.com/SuryanarayanaY", "followers_url": "https://api.github.com/users/SuryanarayanaY/followers", "following_url": "https://api.github.com/users/SuryanarayanaY/following{/other_user}", "gists_url": "https://api.github.com/users/SuryanarayanaY/gists{/gist_id}", "starred_url": "https://api.github.com/users/SuryanarayanaY/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/SuryanarayanaY/subscriptions", "organizations_url": "https://api.github.com/users/SuryanarayanaY/orgs", "repos_url": "https://api.github.com/users/SuryanarayanaY/repos", "events_url": "https://api.github.com/users/SuryanarayanaY/events{/privacy}", "received_events_url": "https://api.github.com/users/SuryanarayanaY/received_events", "type": "User", "site_admin": false } ]
null
[ "@DLumi \r\nThis issue seems to be Keras issue. Please post this issue on [keras-team/keras repo.](https://github.com/keras-team/keras/issues) as Keras development is fully moving to [github.com/keras-team/keras](http://github.com/keras-team/keras). All issues and PRs related to keras will be addressed in that repo.\r\nTo know more see this TF forum discussion ; \r\n[https://discuss.tensorflow.org/t/keras-project-moved-to-new-repository-in-https-github-com-keras-team-keras/1999](https://discuss.tensorflow.org/t/keras-project-moved-to-new-repository-in-https-github-com-keras-team-keras/1999)\r\nThank you!", "I really don't see how it is the Keras issue, since it seems like a manifestation of default behavior for calling `tf.function().get_concrete_function()`. If you don't specify tensor names in provided list of TensorSpecs, the algorithm would just stick to defaults (x for inputs; Identity for outputs), but if you do name your tensors, the `x` would be replaced with whatever you provided. Sadly that's not the case for outputs that get named `Identity`, since the algorithm slaps a fresh copy of default Identity operation on top of whatever there was before, and you simply don't have an option to provide a spec for this, as outputs seem to be tracked and named automatically. Thus you have no ability of preserving your Keras output names. \r\nI will repost this in Keras repo as you suggested, but I'll probably get redirected back here pretty quickly. ", "Hi @DLumi,\r\n\r\nAs the issue is already on Keras repo can we close it here so that it can be better tracked at single repo. Thanks!", "> Hi @DLumi,\r\n> \r\n> As the issue is already on Keras repo can we close it here so that it can be better tracked at single repo. Thanks!\r\n\r\nHonestly, I'd keep both issues open in case there are some tweaks required from the TF team. Unless the Keras team explicitly says they will handle this themselves, that is. \r\nBut I understand your wish to reduce issues piling up, so feel free to close this if that's really needed. ", "@SuryanarayanaY as expected, I got bounced back to you guys.\r\nhttps://github.com/keras-team/tf-keras/issues/219" ]
2023-04-11T08:14:38
2023-09-22T18:10:36
null
NONE
null
null
null
<details><summary>Click to expand!</summary> ### Issue Type Feature Request ### Have you reproduced the bug with TF nightly? Yes ### Source binary ### Tensorflow Version 2.12.0 ### Custom Code Yes ### OS Platform and Distribution _No response_ ### Mobile device _No response_ ### Python version 3.8.10 ### Bazel version _No response_ ### GCC/Compiler version _No response_ ### CUDA/cuDNN version _No response_ ### GPU model and memory _No response_ ### Current Behaviour? When converting a Keras model to concrete function, you can preserve the input name by creating a named TensorSpec, but the outputs are always created for you by just slapping `tf.identity` on top of whatever you had there, even if it was a custom named `tf.identity` operation. Since many converters rely on concrete functions to make their own representation (TFLite, ONNX, CoreML, etc), this behavior messes up the output operation names, often making them inconsistent with each other. There's currently no workaround for that. You *can* access previous graph nodes by calling a layer named like {model_name}/{output_layer_name} when doing inference on frozen graph itself, but it won't help you in any way to convert the model. So I'd be happy to see one of those things as a solution to that: 1) Add an option to explicitly specify the TensorSpec for outputs, just the way we do it for inputs. This would be the most obvious and convenient way of doing it from a user standpoint 2) Don't add new identity operations on top of existing ones. More of a kludge, but would get the job done 3) Add an option to rename operations in concrete function post factum. 4) Add an option to cut off the operations in concrete function past a certain node. 5) Add an option to convert a graph into a concrete function. Since you can directly modify graphs, this could work as well ### Standalone code to reproduce the issue ```shell import tensorflow as tf # Build simple model inputs = tf.keras.Input((224, 224, 3), name='custom_input_layer') x = tf.keras.layers.Flatten()(inputs) x = tf.keras.layers.Dense(512, activation='relu')(x) x = tf.keras.layers.Dense(256, activation='relu')(x) x = tf.keras.layers.Dense(128, activation='relu')(x) x = tf.keras.layers.Dense(1, activation='sigmoid', name='custom_output_layer')(x) model = tf.keras.Model(inputs=inputs, outputs=x, name='my_custom_model_name') model.summary() input_tensors = [tf.TensorSpec(shape=inp.shape, dtype=tf.float32, name=inp.name) for inp in model.inputs] concrete_function = tf.function(lambda x: model(x)).get_concrete_function(x=input_tensors) print(concrete_function.inputs) # we can see 'custom_input_layer:0' is there. So is the 'true' output 'my_custom_model_name/custom_output_layer/BiasAdd/ReadVariableOp/resource:0' print(concrete_function.outputs) # pesky Identity node gets inserted ``` ### Relevant log output ```shell Model: "my_custom_model_name" _________________________________________________________________ Layer (type) Output Shape Param # ================================================================= custom_input_layer (InputLa [(None, 224, 224, 3)] 0 yer) flatten (Flatten) (None, 150528) 0 dense (Dense) (None, 512) 77070848 dense_1 (Dense) (None, 256) 131328 dense_2 (Dense) (None, 128) 32896 custom_output_layer (Dense) (None, 1) 129 ================================================================= Total params: 77,235,201 Trainable params: 77,235,201 Non-trainable params: 0 _________________________________________________________________ [<tf.Tensor 'custom_input_layer:0' shape=(None, 224, 224, 3) dtype=float32>, <tf.Tensor 'my_custom_model_name/dense/MatMul/ReadVariableOp/resource:0' shape=() dtype=resource>, <tf.Tensor 'my_custom_model_name/dense/BiasAdd/ReadVariableOp/resource:0' shape=() dtype=resource>, <tf.Tensor 'my_custom_model_name/dense_1/MatMul/ReadVariableOp/resource:0' shape=() dtype=resource>, <tf.Tensor 'my_custom_model_name/dense_1/BiasAdd/ReadVariableOp/resource:0' shape=() dtype=resource>, <tf.Tensor 'my_custom_model_name/dense_2/MatMul/ReadVariableOp/resource:0' shape=() dtype=resource>, <tf.Tensor 'my_custom_model_name/dense_2/BiasAdd/ReadVariableOp/resource:0' shape=() dtype=resource>, <tf.Tensor 'my_custom_model_name/custom_output_layer/MatMul/ReadVariableOp/resource:0' shape=() dtype=resource>, <tf.Tensor 'my_custom_model_name/custom_output_layer/BiasAdd/ReadVariableOp/resource:0' shape=() dtype=resource>] [<tf.Tensor 'Identity:0' shape=(None, 1) dtype=float32>] ``` </details>
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/60289/reactions", "total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/60289/timeline
null
null
false
https://api.github.com/repos/tensorflow/tensorflow/issues/60288
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/60288/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/60288/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/60288/events
https://github.com/tensorflow/tensorflow/issues/60288
1,661,884,609
I_kwDOArmXAs5jDljB
60,288
"Failed to connect to remote host: Connection refused" on Colab TPU
{ "login": "davidkflau", "id": 46880725, "node_id": "MDQ6VXNlcjQ2ODgwNzI1", "avatar_url": "https://avatars.githubusercontent.com/u/46880725?v=4", "gravatar_id": "", "url": "https://api.github.com/users/davidkflau", "html_url": "https://github.com/davidkflau", "followers_url": "https://api.github.com/users/davidkflau/followers", "following_url": "https://api.github.com/users/davidkflau/following{/other_user}", "gists_url": "https://api.github.com/users/davidkflau/gists{/gist_id}", "starred_url": "https://api.github.com/users/davidkflau/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/davidkflau/subscriptions", "organizations_url": "https://api.github.com/users/davidkflau/orgs", "repos_url": "https://api.github.com/users/davidkflau/repos", "events_url": "https://api.github.com/users/davidkflau/events{/privacy}", "received_events_url": "https://api.github.com/users/davidkflau/received_events", "type": "User", "site_admin": false }
[ { "id": 386191887, "node_id": "MDU6TGFiZWwzODYxOTE4ODc=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/stat:awaiting%20response", "name": "stat:awaiting response", "color": "f4b400", "default": false, "description": "Status - Awaiting response from author" }, { "id": 473172988, "node_id": "MDU6TGFiZWw0NzMxNzI5ODg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/type:bug", "name": "type:bug", "color": "159b2e", "default": false, "description": "Bug" }, { "id": 474725938, "node_id": "MDU6TGFiZWw0NzQ3MjU5Mzg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/stale", "name": "stale", "color": "d4c5f9", "default": false, "description": "This label marks the issue/pr stale - to be closed automatically if no activity" }, { "id": 1097541661, "node_id": "MDU6TGFiZWwxMDk3NTQxNjYx", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/comp:tpus", "name": "comp:tpus", "color": "0052cc", "default": false, "description": "tpu, tpuestimator" }, { "id": 5206407904, "node_id": "LA_kwDOArmXAs8AAAABNlN64A", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/TF%202.12", "name": "TF 2.12", "color": "c5def5", "default": false, "description": "For issues related to Tensorflow 2.12" } ]
closed
false
{ "login": "synandi", "id": 98147397, "node_id": "U_kgDOBdmcRQ", "avatar_url": "https://avatars.githubusercontent.com/u/98147397?v=4", "gravatar_id": "", "url": "https://api.github.com/users/synandi", "html_url": "https://github.com/synandi", "followers_url": "https://api.github.com/users/synandi/followers", "following_url": "https://api.github.com/users/synandi/following{/other_user}", "gists_url": "https://api.github.com/users/synandi/gists{/gist_id}", "starred_url": "https://api.github.com/users/synandi/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/synandi/subscriptions", "organizations_url": "https://api.github.com/users/synandi/orgs", "repos_url": "https://api.github.com/users/synandi/repos", "events_url": "https://api.github.com/users/synandi/events{/privacy}", "received_events_url": "https://api.github.com/users/synandi/received_events", "type": "User", "site_admin": false }
[ { "login": "synandi", "id": 98147397, "node_id": "U_kgDOBdmcRQ", "avatar_url": "https://avatars.githubusercontent.com/u/98147397?v=4", "gravatar_id": "", "url": "https://api.github.com/users/synandi", "html_url": "https://github.com/synandi", "followers_url": "https://api.github.com/users/synandi/followers", "following_url": "https://api.github.com/users/synandi/following{/other_user}", "gists_url": "https://api.github.com/users/synandi/gists{/gist_id}", "starred_url": "https://api.github.com/users/synandi/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/synandi/subscriptions", "organizations_url": "https://api.github.com/users/synandi/orgs", "repos_url": "https://api.github.com/users/synandi/repos", "events_url": "https://api.github.com/users/synandi/events{/privacy}", "received_events_url": "https://api.github.com/users/synandi/received_events", "type": "User", "site_admin": false } ]
null
[ "Hi @davidkflau, Thank you for raising the issue!\r\nWe were able to replicate the issue in Colab using Tensorflow 2.12 and TPU. Please find the gist [here](https://colab.sandbox.google.com/gist/synandi/f1de44f03fd28314691b7d9ee3512600/60288_tpu.ipynb). It seems like we have to dig deep into the issue. We'll update here soon. Thank you!", "Hi @davidkflau ,\r\n\r\nAt present not all Ops are executable with TPUs. The iter operation might be one of them. Also, from the error log:\r\n```\r\nExecuting non-communication op <MultiDeviceIteratorGetNextFromShard> originally returned UnavailableError, and was replaced by InternalError to avoid invoking TF network error handling logic.\r\n```\r\n\r\nIt seems iter operation is not supported on TPUs. Please find the TPU supported Ops list [here](https://cloud.google.com/tpu/docs/tensorflow-ops) for reference. \r\n\r\nThank you!", "This issue is stale because it has been open for 7 days with no activity. It will be closed if no further activity occurs. Thank you.", "This issue was closed because it has been inactive for 7 days since being marked as stale. Please reopen if you'd like to work on this further.", "Are you satisfied with the resolution of your issue?\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=Yes&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/60288\">Yes</a>\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=No&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/60288\">No</a>\n" ]
2023-04-11T07:02:47
2023-05-07T01:58:28
2023-05-07T01:58:22
NONE
null
null
null
<details><summary>Click to expand!</summary> ### Issue Type Bug ### Have you reproduced the bug with TF nightly? No ### Source source ### Tensorflow Version tf 2.12.0 ### Custom Code Yes ### OS Platform and Distribution _No response_ ### Mobile device _No response_ ### Python version _No response_ ### Bazel version _No response_ ### GCC/Compiler version _No response_ ### CUDA/cuDNN version _No response_ ### GPU model and memory _No response_ ### Current Behaviour? ```shell I got an error "Failed to connect to remote host: Connection refused" when I use TPU to train my model on Colab, but it works if I use GPU to train. ``` ### Standalone code to reproduce the issue ```shell My notebook is https://colab.research.google.com/drive/1YUMZQe-z5cc9PAgGEch3xuEuloclNSRC?usp=sharing ``` ### Relevant log output ```shell Epoch 1/50 1/1240 [..............................] - ETA: 10:24:26 --------------------------------------------------------------------------- InternalError Traceback (most recent call last) <ipython-input-14-d0d9f97c5872> in <cell line: 2>() 1 # Train the model ----> 2 history = model.fit(train_generator, validation_data=val_generator, epochs=50, verbose=1, shuffle=True) 1 frames /usr/local/lib/python3.9/dist-packages/tensorflow/python/framework/ops.py in _numpy(self) 1126 return self._numpy_internal() 1127 except core._NotOkStatusException as e: # pylint: disable=protected-access -> 1128 raise core._status_to_exception(e) from None # pylint: disable=protected-access 1129 1130 @property InternalError: 9 root error(s) found. (0) INTERNAL: {{function_node __inference_train_function_107490}} failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:50612: Failed to connect to remote host: Connection refused Additional GRPC error information from remote target /job:localhost/replica:0/task:0/device:CPU:0: :UNKNOWN:failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:50612: Failed to connect to remote host: Connection refused {created_time:"2023-04-11T06:57:27.796149613+00:00", grpc_status:14} [[{{node MultiDeviceIteratorGetNextFromShard}}]] Executing non-communication op <MultiDeviceIteratorGetNextFromShard> originally returned UnavailableError, and was replaced by InternalError to avoid invoking TF network error handling logic. [[RemoteCall]] [[IteratorGetNextAsOptional]] [[strided_slice_91/_338]] (1) INTERNAL: {{function_node __inference_train_function_107490}} failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:50612: Failed to connect to remote host: Connection refused Additional GRPC error information from remote target /job:localhost/replica:0/task:0/device:CPU:0: :UNKNOWN:failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:50612: Failed to connect to remote host: Connection refused {created_time:"2023-04-11T06:57:27.796149613+00:00", grpc_status:14} [[{{node MultiDeviceIteratorGetNextFromShard}}]] Executing non-communication op <MultiDeviceIteratorGetNextFromShard> originally returned UnavailableError, and was replaced by InternalError to avoid invoking TF network error handling logic. [[RemoteCall]] [[IteratorGetNextAsOptional]] [[strided_slice_72/_312]] (2) INTERNAL: {{function_node __inference_train_function_107490}} failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:50612: Failed to connect to remote host: Connection refused Additional GRPC error information from remote target /job:localhost/replica:0/task:0/device:CPU:0: :UNKNOWN:failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:50612: Failed to connect to remote host: Connection refused {created_time:"2023-04-11T06:57:27.796149613+00:00", grpc_status:14} [[{{node MultiDeviceIteratorGetNextFromShard}}]] Executing non-communication op <MultiDeviceIteratorGetNextFromShard> originally returned UnavailableError, and was replaced by InternalError to avoid invoking TF network error handling logic. [[RemoteCall]] [[IteratorGetNextAsOptional]] [[strided_slice_37/_266]] (3) INTERNAL: {{function_node __inference_train_function_107490}} failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:50612: Failed to connect to remote host: Connection refused Additional GRPC error information from remote target /job:localhost/replica:0/task:0/device:CPU:0: :UNKNOWN:failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:50612: Failed to connect to remote host: Connection refused {created_time:"2023-04-11T06:57:27.796149613+00:00", grpc_status:14} [[{{node MultiDeviceIteratorGetNextFromShard}}]] Ex ... [truncated] ``` </details>
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/60288/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/60288/timeline
null
completed
false
https://api.github.com/repos/tensorflow/tensorflow/issues/60287
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/60287/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/60287/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/60287/events
https://github.com/tensorflow/tensorflow/issues/60287
1,661,081,933
I_kwDOArmXAs5jAhlN
60,287
tfp.stats.histogram weights argument bug when using multiple axes
{ "login": "joaozenobio", "id": 81932394, "node_id": "MDQ6VXNlcjgxOTMyMzk0", "avatar_url": "https://avatars.githubusercontent.com/u/81932394?v=4", "gravatar_id": "", "url": "https://api.github.com/users/joaozenobio", "html_url": "https://github.com/joaozenobio", "followers_url": "https://api.github.com/users/joaozenobio/followers", "following_url": "https://api.github.com/users/joaozenobio/following{/other_user}", "gists_url": "https://api.github.com/users/joaozenobio/gists{/gist_id}", "starred_url": "https://api.github.com/users/joaozenobio/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/joaozenobio/subscriptions", "organizations_url": "https://api.github.com/users/joaozenobio/orgs", "repos_url": "https://api.github.com/users/joaozenobio/repos", "events_url": "https://api.github.com/users/joaozenobio/events{/privacy}", "received_events_url": "https://api.github.com/users/joaozenobio/received_events", "type": "User", "site_admin": false }
[ { "id": 386191887, "node_id": "MDU6TGFiZWwzODYxOTE4ODc=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/stat:awaiting%20response", "name": "stat:awaiting response", "color": "f4b400", "default": false, "description": "Status - Awaiting response from author" }, { "id": 473172988, "node_id": "MDU6TGFiZWw0NzMxNzI5ODg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/type:bug", "name": "type:bug", "color": "159b2e", "default": false, "description": "Bug" }, { "id": 1097545817, "node_id": "MDU6TGFiZWwxMDk3NTQ1ODE3", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/comp:apis", "name": "comp:apis", "color": "0052cc", "default": false, "description": "Highlevel API related issues" }, { "id": 4032183365, "node_id": "LA_kwDOArmXAs7wVjxF", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/TF%202.9", "name": "TF 2.9", "color": "1CF842", "default": false, "description": "Issues found in the TF 2.9 release (or RCs)" } ]
closed
false
{ "login": "tilakrayal", "id": 81610181, "node_id": "MDQ6VXNlcjgxNjEwMTgx", "avatar_url": "https://avatars.githubusercontent.com/u/81610181?v=4", "gravatar_id": "", "url": "https://api.github.com/users/tilakrayal", "html_url": "https://github.com/tilakrayal", "followers_url": "https://api.github.com/users/tilakrayal/followers", "following_url": "https://api.github.com/users/tilakrayal/following{/other_user}", "gists_url": "https://api.github.com/users/tilakrayal/gists{/gist_id}", "starred_url": "https://api.github.com/users/tilakrayal/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/tilakrayal/subscriptions", "organizations_url": "https://api.github.com/users/tilakrayal/orgs", "repos_url": "https://api.github.com/users/tilakrayal/repos", "events_url": "https://api.github.com/users/tilakrayal/events{/privacy}", "received_events_url": "https://api.github.com/users/tilakrayal/received_events", "type": "User", "site_admin": false }
[ { "login": "tilakrayal", "id": 81610181, "node_id": "MDQ6VXNlcjgxNjEwMTgx", "avatar_url": "https://avatars.githubusercontent.com/u/81610181?v=4", "gravatar_id": "", "url": "https://api.github.com/users/tilakrayal", "html_url": "https://github.com/tilakrayal", "followers_url": "https://api.github.com/users/tilakrayal/followers", "following_url": "https://api.github.com/users/tilakrayal/following{/other_user}", "gists_url": "https://api.github.com/users/tilakrayal/gists{/gist_id}", "starred_url": "https://api.github.com/users/tilakrayal/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/tilakrayal/subscriptions", "organizations_url": "https://api.github.com/users/tilakrayal/orgs", "repos_url": "https://api.github.com/users/tilakrayal/repos", "events_url": "https://api.github.com/users/tilakrayal/events{/privacy}", "received_events_url": "https://api.github.com/users/tilakrayal/received_events", "type": "User", "site_admin": false } ]
null
[ "If you read the tensorflow documentation for tfp.stats.histogram(https://www.tensorflow.org/probability/api_docs/python/tfp/stats/histogram), upon reading the description of 'axis', it says : \"Optional 0-D or 1-D integer Tensor with constant values.\" which means that tensorflow expects the axis to be passed as a tensor to generate the required results.\r\n\r\nYou can try passing the axis as a tensor, something like this : axis = tf.constant(0, 1)\r\n", "@joaozenobio,\r\nLooks like this issue is more related to tensorflow propability repo. Could you please raise the issue in the respective repo from here for further assistance. \r\nhttps://github.com/tensorflow/probability/issues\r\nThank you!\r\n", "@ayushsh314, I've tried using this code now:\r\n```\r\nimport tensorflow_probability as tfp\r\nimport tensorflow as tf\r\nx = tf.constant([[1, 2, 3], [1, 2, 3.]])\r\nw = tf.constant([[1, 1, 1], [1, 1, 1.]])\r\ne = tf.constant([0, 2.5, 10])\r\naxis = tf.constant([0, 1])\r\ntfp.stats.histogram(x=x, edges=e, axis=axis, weights=w)\r\n```\r\n\r\nIt gives me the same error:\r\n\r\n```\r\nTraceback (most recent call last):\r\n File \"/opt/.pycharm_helpers/pydev/pydevconsole.py\", line 364, in runcode\r\n coro = func()\r\n File \"<input>\", line 1, in <module>\r\n File \"/usr/local/lib/python3.8/dist-packages/tensorflow_probability/python/stats/quantiles.py\", line 393, in histogram\r\n raise ValueError('Number of dimensions of `x` and `weights` must '\r\nValueError: Number of dimensions of `x` and `weights` must coincide. Found: x has 2, weights has 1\r\n```\r\n", "@tilakrayal, I will raise a new issue there and make a reference to this one, thanks.", "@joaozenobio,\r\nPlease feel free to move this issue to closed status, as it has been tracked in the respective repo. Thank you!", "Are you satisfied with the resolution of your issue?\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=Yes&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/60287\">Yes</a>\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=No&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/60287\">No</a>\n" ]
2023-04-10T17:10:39
2023-04-12T10:02:17
2023-04-12T10:02:15
NONE
null
null
null
<details><summary>Click to expand!</summary> ### Issue Type Bug ### Have you reproduced the bug with TF nightly? No ### Source binary ### Tensorflow Version 2.9.1 ### Custom Code No ### OS Platform and Distribution Linux Ubuntu 22.04 ### Mobile device _No response_ ### Python version 3.8.10 ### Bazel version _No response_ ### GCC/Compiler version _No response_ ### CUDA/cuDNN version _No response_ ### GPU model and memory _No response_ ### Current Behaviour? ```shell Tensorflow throws a ValueError when using weights and multiple axes at the same time, saying that the input and weights arguments should have the same shape, even though they already have. Hint: Does not happen when using only one axis. ``` ### Standalone code to reproduce the issue ```shell import tensorflow_probability as tfp import tensorflow as tf x = tf.constant([[1, 2, 3], [1, 2, 3.]]) w = tf.constant([[1, 1, 1], [1, 1, 1.]]) e = tf.constant([0, 2.5, 10]) axis = (0, 1) tfp.stats.histogram(x=x, edges=e, axis=axis, weights=w) ``` ### Relevant log output ```shell Traceback (most recent call last): File "/opt/.pycharm_helpers/pydev/pydevconsole.py", line 364, in runcode coro = func() File "<input>", line 1, in <module> File "/usr/local/lib/python3.8/dist-packages/tensorflow_probability/python/stats/quantiles.py", line 393, in histogram raise ValueError('Number of dimensions of `x` and `weights` must ' ValueError: Number of dimensions of `x` and `weights` must coincide. Found: x has 2, weights has 1 ``` </details>
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/60287/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/60287/timeline
null
completed
false
https://api.github.com/repos/tensorflow/tensorflow/issues/60286
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/60286/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/60286/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/60286/events
https://github.com/tensorflow/tensorflow/issues/60286
1,660,707,852
I_kwDOArmXAs5i_GQM
60,286
bitcast op testcase bug
{ "login": "loongknown", "id": 40852095, "node_id": "MDQ6VXNlcjQwODUyMDk1", "avatar_url": "https://avatars.githubusercontent.com/u/40852095?v=4", "gravatar_id": "", "url": "https://api.github.com/users/loongknown", "html_url": "https://github.com/loongknown", "followers_url": "https://api.github.com/users/loongknown/followers", "following_url": "https://api.github.com/users/loongknown/following{/other_user}", "gists_url": "https://api.github.com/users/loongknown/gists{/gist_id}", "starred_url": "https://api.github.com/users/loongknown/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/loongknown/subscriptions", "organizations_url": "https://api.github.com/users/loongknown/orgs", "repos_url": "https://api.github.com/users/loongknown/repos", "events_url": "https://api.github.com/users/loongknown/events{/privacy}", "received_events_url": "https://api.github.com/users/loongknown/received_events", "type": "User", "site_admin": false }
[ { "id": 404586594, "node_id": "MDU6TGFiZWw0MDQ1ODY1OTQ=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/stat:awaiting%20tensorflower", "name": "stat:awaiting tensorflower", "color": "f4b400", "default": false, "description": "Status - Awaiting response from tensorflower" }, { "id": 473172988, "node_id": "MDU6TGFiZWw0NzMxNzI5ODg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/type:bug", "name": "type:bug", "color": "159b2e", "default": false, "description": "Bug" }, { "id": 1097543484, "node_id": "MDU6TGFiZWwxMDk3NTQzNDg0", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/comp:runtime", "name": "comp:runtime", "color": "0052cc", "default": false, "description": "c++ runtime, performance issues (cpu)" }, { "id": 1133285679, "node_id": "MDU6TGFiZWwxMTMzMjg1Njc5", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/comp:xla", "name": "comp:xla", "color": "0052cc", "default": false, "description": "XLA" }, { "id": 5206407904, "node_id": "LA_kwDOArmXAs8AAAABNlN64A", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/TF%202.12", "name": "TF 2.12", "color": "c5def5", "default": false, "description": "For issues related to Tensorflow 2.12" } ]
open
false
{ "login": "cheshire", "id": 348959, "node_id": "MDQ6VXNlcjM0ODk1OQ==", "avatar_url": "https://avatars.githubusercontent.com/u/348959?v=4", "gravatar_id": "", "url": "https://api.github.com/users/cheshire", "html_url": "https://github.com/cheshire", "followers_url": "https://api.github.com/users/cheshire/followers", "following_url": "https://api.github.com/users/cheshire/following{/other_user}", "gists_url": "https://api.github.com/users/cheshire/gists{/gist_id}", "starred_url": "https://api.github.com/users/cheshire/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/cheshire/subscriptions", "organizations_url": "https://api.github.com/users/cheshire/orgs", "repos_url": "https://api.github.com/users/cheshire/repos", "events_url": "https://api.github.com/users/cheshire/events{/privacy}", "received_events_url": "https://api.github.com/users/cheshire/received_events", "type": "User", "site_admin": false }
[ { "login": "cheshire", "id": 348959, "node_id": "MDQ6VXNlcjM0ODk1OQ==", "avatar_url": "https://avatars.githubusercontent.com/u/348959?v=4", "gravatar_id": "", "url": "https://api.github.com/users/cheshire", "html_url": "https://github.com/cheshire", "followers_url": "https://api.github.com/users/cheshire/followers", "following_url": "https://api.github.com/users/cheshire/following{/other_user}", "gists_url": "https://api.github.com/users/cheshire/gists{/gist_id}", "starred_url": "https://api.github.com/users/cheshire/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/cheshire/subscriptions", "organizations_url": "https://api.github.com/users/cheshire/orgs", "repos_url": "https://api.github.com/users/cheshire/repos", "events_url": "https://api.github.com/users/cheshire/events{/privacy}", "received_events_url": "https://api.github.com/users/cheshire/received_events", "type": "User", "site_admin": false }, { "login": "sachinprasadhs", "id": 73069040, "node_id": "MDQ6VXNlcjczMDY5MDQw", "avatar_url": "https://avatars.githubusercontent.com/u/73069040?v=4", "gravatar_id": "", "url": "https://api.github.com/users/sachinprasadhs", "html_url": "https://github.com/sachinprasadhs", "followers_url": "https://api.github.com/users/sachinprasadhs/followers", "following_url": "https://api.github.com/users/sachinprasadhs/following{/other_user}", "gists_url": "https://api.github.com/users/sachinprasadhs/gists{/gist_id}", "starred_url": "https://api.github.com/users/sachinprasadhs/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sachinprasadhs/subscriptions", "organizations_url": "https://api.github.com/users/sachinprasadhs/orgs", "repos_url": "https://api.github.com/users/sachinprasadhs/repos", "events_url": "https://api.github.com/users/sachinprasadhs/events{/privacy}", "received_events_url": "https://api.github.com/users/sachinprasadhs/received_events", "type": "User", "site_admin": false } ]
null
[ "The test code is as follows:\r\nTEST_F(GpuKernelTilingTest, module_0615_entry_bitcast_2) { \r\n const char* testcase = R\"( \r\n ¦ HloModule m, is_scheduled=true \r\n ¦ ENTRY out_of_fusion { \r\n ¦ ¦ p0 = f32[1]{0} parameter(0) \r\n ¦ ¦ ROOT res = f32[] bitcast(f32[1]{0} p0) \r\n ¦ } \r\n )\"; \r\n auto module = ParseAndReturnVerifiedModule(testcase).value(); \r\n EXPECT_TRUE(RunAndCompareNoHloPasses(std::move(module), ErrorSpec(1e-5))); \r\n } \r\n ", "Due to the entry parameter not being an alias for the output, the input parameter memory was freed before memcpying its data to host.", "Is it possible to repro with pre-optimizations HLO? Note that `bitcast` does not exist in input HLO, it only appears after optimizations." ]
2023-04-10T12:16:03
2023-04-19T01:52:40
null
NONE
null
null
null
<details><summary>Click to expand!</summary> ### Issue Type Bug ### Have you reproduced the bug with TF nightly? Yes ### Source source ### Tensorflow Version master ### Custom Code Yes ### OS Platform and Distribution _No response_ ### Mobile device _No response_ ### Python version _No response_ ### Bazel version _No response_ ### GCC/Compiler version _No response_ ### CUDA/cuDNN version _No response_ ### GPU model and memory _No response_ ### Current Behaviour? ```shell A bug happened! gpu xla testcase: XLA_TEST_F(Resnet50FusionTest, module_0615_entry_bitcast) { const char* testcase = R"( ¦ HloModule m, is_scheduled=true ¦ ENTRY out_of_fusion { ¦ ¦ p0 = f32[1]{0} parameter(0) ¦ ¦ ROOT res = f32[] bitcast(f32[1]{0} p0) ¦ } )"; auto module = ParseAndReturnVerifiedModule(testcase).value(); EXPECT_TRUE(RunAndCompareNoHloPasses(std::move(module), ErrorSpec(1e-5))); } will cause following bug: 2023-04-07 07:42:59.490547: I tensorflow/compiler/xla/service/platform_util.cc:72] platform Host present but no XLA compiler available: could not find registered compiler for platform Host -- was support for that platform linked in? 2023-04-07 07:42:59.659576: E tensorflow/compiler/xla/stream_executor/cuda/cuda_driver.cc:1162] failed to enqueue async memcpy from device to host: CUDA_ERROR_INVALID_VALUE: invalid argument; host dst: 0x7fff996f4360; GPU src: 0x7f4e8da00000; size: 4=0x4 2023-04-07 07:42:59.659624: I tensorflow/compiler/xla/stream_executor/stream.cc:2535] INTERNAL: Unknown error 2023-04-07 07:42:59.659679: I tensorflow/compiler/xla/stream_executor/stream.cc:2539] [stream=0x5562acc10570,impl=0x5562acbb8160] INTERNAL: stream did not block host until done; was already in an error state 2023-04-07 07:42:59.659694: I tensorflow/compiler/xla/stream_executor/stream.cc:2535] INTERNAL: Unknown error 2023-04-07 07:42:59.659703: I tensorflow/compiler/xla/stream_executor/stream.cc:2539] [stream=0x5562acc10570,impl=0x5562acbb8160] INTERNAL: stream did not block host until done; was already in an error state 2023-04-07 07:42:59.659711: W tensorflow/compiler/xla/stream_executor/stream.cc:277] Error blocking host until done in stream destructor: INTERNAL: stream did not block host until done; was already in an error state 2023-04-07 07:42:59.659745: E tensorflow/compiler/xla/stream_executor/cuda/cuda_driver.cc:755] failed to free device memory at 0x7f4e8da00000; result: CUDA_ERROR_INVALID_VALUE: invalid argument tensorflow/compiler/xla/service/gpu/tests/gpu_kernel_tiling_test.cc:58: Failure Value of: RunAndCompareNoHloPasses(std::move(module), ErrorSpec(1e-5)) Actual: false (INTERNAL: stream did not block host until done; was already in an error state) Expected: true ``` ### Standalone code to reproduce the issue ```shell see current behaviour ``` ### Relevant log output ```shell 2023-04-07 07:42:59.490547: I tensorflow/compiler/xla/service/platform_util.cc:72] platform Host present but no XLA compiler available: could not find registered compiler for platform Host -- was support for that platform linked in? 2023-04-07 07:42:59.659576: E tensorflow/compiler/xla/stream_executor/cuda/cuda_driver.cc:1162] failed to enqueue async memcpy from device to host: CUDA_ERROR_INVALID_VALUE: invalid argument; host dst: 0x7fff996f4360; GPU src: 0x7f4e8da00000; size: 4=0x4 2023-04-07 07:42:59.659624: I tensorflow/compiler/xla/stream_executor/stream.cc:2535] INTERNAL: Unknown error 2023-04-07 07:42:59.659679: I tensorflow/compiler/xla/stream_executor/stream.cc:2539] [stream=0x5562acc10570,impl=0x5562acbb8160] INTERNAL: stream did not block host until done; was already in an error state 2023-04-07 07:42:59.659694: I tensorflow/compiler/xla/stream_executor/stream.cc:2535] INTERNAL: Unknown error 2023-04-07 07:42:59.659703: I tensorflow/compiler/xla/stream_executor/stream.cc:2539] [stream=0x5562acc10570,impl=0x5562acbb8160] INTERNAL: stream did not block host until done; was already in an error state 2023-04-07 07:42:59.659711: W tensorflow/compiler/xla/stream_executor/stream.cc:277] Error blocking host until done in stream destructor: INTERNAL: stream did not block host until done; was already in an error state 2023-04-07 07:42:59.659745: E tensorflow/compiler/xla/stream_executor/cuda/cuda_driver.cc:755] failed to free device memory at 0x7f4e8da00000; result: CUDA_ERROR_INVALID_VALUE: invalid argument tensorflow/compiler/xla/service/gpu/tests/gpu_kernel_tiling_test.cc:58: Failure Value of: RunAndCompareNoHloPasses(std::move(module), ErrorSpec(1e-5)) Actual: false (INTERNAL: stream did not block host until done; was already in an error state) Expected: true ``` </details>
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/60286/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/60286/timeline
null
null
false
https://api.github.com/repos/tensorflow/tensorflow/issues/60285
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/60285/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/60285/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/60285/events
https://github.com/tensorflow/tensorflow/issues/60285
1,660,263,234
I_kwDOArmXAs5i9ZtC
60,285
linked page is not valid!
{ "login": "jntdst", "id": 8072997, "node_id": "MDQ6VXNlcjgwNzI5OTc=", "avatar_url": "https://avatars.githubusercontent.com/u/8072997?v=4", "gravatar_id": "", "url": "https://api.github.com/users/jntdst", "html_url": "https://github.com/jntdst", "followers_url": "https://api.github.com/users/jntdst/followers", "following_url": "https://api.github.com/users/jntdst/following{/other_user}", "gists_url": "https://api.github.com/users/jntdst/gists{/gist_id}", "starred_url": "https://api.github.com/users/jntdst/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/jntdst/subscriptions", "organizations_url": "https://api.github.com/users/jntdst/orgs", "repos_url": "https://api.github.com/users/jntdst/repos", "events_url": "https://api.github.com/users/jntdst/events{/privacy}", "received_events_url": "https://api.github.com/users/jntdst/received_events", "type": "User", "site_admin": false }
[ { "id": 284443156, "node_id": "MDU6TGFiZWwyODQ0NDMxNTY=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/type:docs-bug", "name": "type:docs-bug", "color": "159b2e", "default": false, "description": "Document issues" }, { "id": 386191887, "node_id": "MDU6TGFiZWwzODYxOTE4ODc=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/stat:awaiting%20response", "name": "stat:awaiting response", "color": "f4b400", "default": false, "description": "Status - Awaiting response from author" }, { "id": 473172988, "node_id": "MDU6TGFiZWw0NzMxNzI5ODg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/type:bug", "name": "type:bug", "color": "159b2e", "default": false, "description": "Bug" }, { "id": 474725938, "node_id": "MDU6TGFiZWw0NzQ3MjU5Mzg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/stale", "name": "stale", "color": "d4c5f9", "default": false, "description": "This label marks the issue/pr stale - to be closed automatically if no activity" }, { "id": 5206407904, "node_id": "LA_kwDOArmXAs8AAAABNlN64A", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/TF%202.12", "name": "TF 2.12", "color": "c5def5", "default": false, "description": "For issues related to Tensorflow 2.12" } ]
closed
false
{ "login": "sachinprasadhs", "id": 73069040, "node_id": "MDQ6VXNlcjczMDY5MDQw", "avatar_url": "https://avatars.githubusercontent.com/u/73069040?v=4", "gravatar_id": "", "url": "https://api.github.com/users/sachinprasadhs", "html_url": "https://github.com/sachinprasadhs", "followers_url": "https://api.github.com/users/sachinprasadhs/followers", "following_url": "https://api.github.com/users/sachinprasadhs/following{/other_user}", "gists_url": "https://api.github.com/users/sachinprasadhs/gists{/gist_id}", "starred_url": "https://api.github.com/users/sachinprasadhs/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sachinprasadhs/subscriptions", "organizations_url": "https://api.github.com/users/sachinprasadhs/orgs", "repos_url": "https://api.github.com/users/sachinprasadhs/repos", "events_url": "https://api.github.com/users/sachinprasadhs/events{/privacy}", "received_events_url": "https://api.github.com/users/sachinprasadhs/received_events", "type": "User", "site_admin": false }
[ { "login": "sachinprasadhs", "id": 73069040, "node_id": "MDQ6VXNlcjczMDY5MDQw", "avatar_url": "https://avatars.githubusercontent.com/u/73069040?v=4", "gravatar_id": "", "url": "https://api.github.com/users/sachinprasadhs", "html_url": "https://github.com/sachinprasadhs", "followers_url": "https://api.github.com/users/sachinprasadhs/followers", "following_url": "https://api.github.com/users/sachinprasadhs/following{/other_user}", "gists_url": "https://api.github.com/users/sachinprasadhs/gists{/gist_id}", "starred_url": "https://api.github.com/users/sachinprasadhs/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sachinprasadhs/subscriptions", "organizations_url": "https://api.github.com/users/sachinprasadhs/orgs", "repos_url": "https://api.github.com/users/sachinprasadhs/repos", "events_url": "https://api.github.com/users/sachinprasadhs/events{/privacy}", "received_events_url": "https://api.github.com/users/sachinprasadhs/received_events", "type": "User", "site_admin": false } ]
null
[ "hi i am new to opensource , can you tell explain a little bit so that i can look into it ", "https://www.deepmind.com/blog/trfl is not valid.\r\nthis is an external link in https://www.tensorflow.org/resources/libraries-extensions page.\r\nhttps://www.deepmind.com/blog/trfl is link of \"TRFL \" text.", "Can I work on this issue", "Can you please say the file location where the error occurs", "Hi @jntdst \r\nThank you for reporting the issue! We will update here soon.", "Hi @synandi Can you help me i can solve this problem. I Try to find but i cant able to find. As per @jntdst Version 2.8 now current version is 2.12.0. May be in the update it's resolved.", "Hello، I filled Tensorflow version by mistake. I mean the current version.\nBecause of, GitHub didn't allow me to send a report without a version, and\nI also used the Github default version. I still see the link on the page.\ndon't you see?\n\nOn Tue, Apr 11, 2023, 10:28 PM Kannan N ***@***.***> wrote:\n\n> Hi @synandi <https://github.com/synandi> Can you help me i can solve this\n> problem. I Try to find but i cant able to find. As per @jntdst\n> <https://github.com/jntdst> Version 2.8 now current version is 2.12.0.\n> May be in the update it's resolved.\n>\n> —\n> Reply to this email directly, view it on GitHub\n> <https://github.com/tensorflow/tensorflow/issues/60285#issuecomment-1503850500>,\n> or unsubscribe\n> <https://github.com/notifications/unsubscribe-auth/AB5S6JI75JRJXYOTDWIQXOTXAWLVHANCNFSM6AAAAAAWYTKQ5A>\n> .\n> You are receiving this because you were mentioned.Message ID:\n> ***@***.***>\n>\n", "@jntdst can you assisn me the issue I will check and try to solve the issue ", "@jntdst can you tell me more details i have more experience in working with tensorflow and keras", "@jntdst, Apologies for the delay. We have raised a PR internally, this issue will be closed once the PR is merged. Thank you! ", "Hi, \r\n\r\nThanks for reporting the issue. \r\n\r\nThe link has been updated in the https://www.tensorflow.org/resources/libraries-extensions\r\nNow TFRL will redirect to github repository https://github.com/deepmind/trfl/.\r\nPlease check and feel free to close the issue. Thanks!", "This issue is stale because it has been open for 7 days with no activity. It will be closed if no further activity occurs. Thank you.", "This issue was closed because it has been inactive for 7 days since being marked as stale. Please reopen if you'd like to work on this further.", "Are you satisfied with the resolution of your issue?\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=Yes&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/60285\">Yes</a>\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=No&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/60285\">No</a>\n" ]
2023-04-10T05:33:32
2023-07-07T02:08:46
2023-07-07T02:08:44
NONE
null
null
null
<details><summary>Click to expand!</summary> ### Issue Type Documentation Bug ### Have you reproduced the bug with TF nightly? Yes ### Source source ### Tensorflow Version 2.8 ### Custom Code Yes ### OS Platform and Distribution _No response_ ### Mobile device _No response_ ### Python version _No response_ ### Bazel version _No response_ ### GCC/Compiler version _No response_ ### CUDA/cuDNN version _No response_ ### GPU model and memory _No response_ ### Current Behaviour? ```shell TRFL in https://www.tensorflow.org/resources/libraries-extensions is not valid:) ``` ### Standalone code to reproduce the issue ```shell TRFL in https://www.tensorflow.org/resources/libraries-extensions is not valid:) ``` ### Relevant log output _No response_</details>
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/60285/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/60285/timeline
null
completed
false
https://api.github.com/repos/tensorflow/tensorflow/issues/60284
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/60284/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/60284/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/60284/events
https://github.com/tensorflow/tensorflow/issues/60284
1,660,221,494
I_kwDOArmXAs5i9Pg2
60,284
Anyway to set the attr of operation after added to the gragh in C API?
{ "login": "AsakusaRinne", "id": 47343601, "node_id": "MDQ6VXNlcjQ3MzQzNjAx", "avatar_url": "https://avatars.githubusercontent.com/u/47343601?v=4", "gravatar_id": "", "url": "https://api.github.com/users/AsakusaRinne", "html_url": "https://github.com/AsakusaRinne", "followers_url": "https://api.github.com/users/AsakusaRinne/followers", "following_url": "https://api.github.com/users/AsakusaRinne/following{/other_user}", "gists_url": "https://api.github.com/users/AsakusaRinne/gists{/gist_id}", "starred_url": "https://api.github.com/users/AsakusaRinne/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/AsakusaRinne/subscriptions", "organizations_url": "https://api.github.com/users/AsakusaRinne/orgs", "repos_url": "https://api.github.com/users/AsakusaRinne/repos", "events_url": "https://api.github.com/users/AsakusaRinne/events{/privacy}", "received_events_url": "https://api.github.com/users/AsakusaRinne/received_events", "type": "User", "site_admin": false }
[ { "id": 404586594, "node_id": "MDU6TGFiZWw0MDQ1ODY1OTQ=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/stat:awaiting%20tensorflower", "name": "stat:awaiting tensorflower", "color": "f4b400", "default": false, "description": "Status - Awaiting response from tensorflower" }, { "id": 473184161, "node_id": "MDU6TGFiZWw0NzMxODQxNjE=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/type:support", "name": "type:support", "color": "159b2e", "default": false, "description": "Support issues" }, { "id": 1097545817, "node_id": "MDU6TGFiZWwxMDk3NTQ1ODE3", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/comp:apis", "name": "comp:apis", "color": "0052cc", "default": false, "description": "Highlevel API related issues" }, { "id": 4829271983, "node_id": "LA_kwDOArmXAs8AAAABH9jXrw", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/TF%202.11", "name": "TF 2.11", "color": "46B4D7", "default": false, "description": "Issues related to TF 2.11" } ]
open
false
{ "login": "sachinprasadhs", "id": 73069040, "node_id": "MDQ6VXNlcjczMDY5MDQw", "avatar_url": "https://avatars.githubusercontent.com/u/73069040?v=4", "gravatar_id": "", "url": "https://api.github.com/users/sachinprasadhs", "html_url": "https://github.com/sachinprasadhs", "followers_url": "https://api.github.com/users/sachinprasadhs/followers", "following_url": "https://api.github.com/users/sachinprasadhs/following{/other_user}", "gists_url": "https://api.github.com/users/sachinprasadhs/gists{/gist_id}", "starred_url": "https://api.github.com/users/sachinprasadhs/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sachinprasadhs/subscriptions", "organizations_url": "https://api.github.com/users/sachinprasadhs/orgs", "repos_url": "https://api.github.com/users/sachinprasadhs/repos", "events_url": "https://api.github.com/users/sachinprasadhs/events{/privacy}", "received_events_url": "https://api.github.com/users/sachinprasadhs/received_events", "type": "User", "site_admin": false }
[ { "login": "sachinprasadhs", "id": 73069040, "node_id": "MDQ6VXNlcjczMDY5MDQw", "avatar_url": "https://avatars.githubusercontent.com/u/73069040?v=4", "gravatar_id": "", "url": "https://api.github.com/users/sachinprasadhs", "html_url": "https://github.com/sachinprasadhs", "followers_url": "https://api.github.com/users/sachinprasadhs/followers", "following_url": "https://api.github.com/users/sachinprasadhs/following{/other_user}", "gists_url": "https://api.github.com/users/sachinprasadhs/gists{/gist_id}", "starred_url": "https://api.github.com/users/sachinprasadhs/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sachinprasadhs/subscriptions", "organizations_url": "https://api.github.com/users/sachinprasadhs/orgs", "repos_url": "https://api.github.com/users/sachinprasadhs/repos", "events_url": "https://api.github.com/users/sachinprasadhs/events{/privacy}", "received_events_url": "https://api.github.com/users/sachinprasadhs/received_events", "type": "User", "site_admin": false } ]
null
[ "Also, is there any corresponding C API for `GetHandleShapeAndType` and `SetHandleShapeAndType` in `python_api.h`?" ]
2023-04-10T04:43:53
2023-04-18T18:47:13
null
CONTRIBUTOR
null
null
null
<details><summary>Click to expand!</summary> ### Issue Type Support ### Have you reproduced the bug with TF nightly? No ### Source binary ### Tensorflow Version tf2.11 ### Custom Code No ### OS Platform and Distribution Windows and Linux ### Current Behaviour? Hello, I'm a developer of [Tensorflow.NET](https://github.com/SciSharp/TensorFlow.NET), which is a tensorflow binding for dotnet. When I implemented some feature, I could not find a C API to add attributes to an operation that has already been created and added to the graph. However, there is indeed such C API for python. It's located [here](https://github.com/tensorflow/tensorflow/blob/master/tensorflow/c/python_api.h#L33). Among exported C APIs of `libtensorflow`, only the following API was found: ```c TF_CAPI_EXPORT extern void TF_SetAttrValueProto(TF_OperationDescription* desc, const char* attr_name, const void* proto, size_t proto_len, TF_Status* status); ``` However, `TF_OperationDescription` is released after adding the operation to graph by calling `TF_FinishOperation`. Therefore I can't use the API to add attributes. Is there any other way for us to add attributes for operations which have been added to graph? ### Standalone code to reproduce the issue ```shell The code is wrote in csharp. I'll give a minimal example if needed. ``` ### Relevant log output _No response_</details>
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/60284/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/60284/timeline
null
null
false
https://api.github.com/repos/tensorflow/tensorflow/issues/60283
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/60283/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/60283/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/60283/events
https://github.com/tensorflow/tensorflow/issues/60283
1,660,138,064
I_kwDOArmXAs5i87JQ
60,283
windows link error
{ "login": "yisir323", "id": 86275589, "node_id": "MDQ6VXNlcjg2Mjc1NTg5", "avatar_url": "https://avatars.githubusercontent.com/u/86275589?v=4", "gravatar_id": "", "url": "https://api.github.com/users/yisir323", "html_url": "https://github.com/yisir323", "followers_url": "https://api.github.com/users/yisir323/followers", "following_url": "https://api.github.com/users/yisir323/following{/other_user}", "gists_url": "https://api.github.com/users/yisir323/gists{/gist_id}", "starred_url": "https://api.github.com/users/yisir323/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/yisir323/subscriptions", "organizations_url": "https://api.github.com/users/yisir323/orgs", "repos_url": "https://api.github.com/users/yisir323/repos", "events_url": "https://api.github.com/users/yisir323/events{/privacy}", "received_events_url": "https://api.github.com/users/yisir323/received_events", "type": "User", "site_admin": false }
[ { "id": 404586594, "node_id": "MDU6TGFiZWw0MDQ1ODY1OTQ=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/stat:awaiting%20tensorflower", "name": "stat:awaiting tensorflower", "color": "f4b400", "default": false, "description": "Status - Awaiting response from tensorflower" }, { "id": 473173351, "node_id": "MDU6TGFiZWw0NzMxNzMzNTE=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/type:build/install", "name": "type:build/install", "color": "159b2e", "default": false, "description": "Build and install issues" }, { "id": 1188421838, "node_id": "MDU6TGFiZWwxMTg4NDIxODM4", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/subtype:windows", "name": "subtype:windows", "color": "b619ea", "default": false, "description": "Windows Build/Installation Issues" }, { "id": 5206407904, "node_id": "LA_kwDOArmXAs8AAAABNlN64A", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/TF%202.12", "name": "TF 2.12", "color": "c5def5", "default": false, "description": "For issues related to Tensorflow 2.12" }, { "id": 5244472328, "node_id": "LA_kwDOArmXAs8AAAABOJhMCA", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/subtype:cpu-intel", "name": "subtype:cpu-intel", "color": "507561", "default": false, "description": "To track windows cpu issues" } ]
open
false
{ "login": "sachinprasadhs", "id": 73069040, "node_id": "MDQ6VXNlcjczMDY5MDQw", "avatar_url": "https://avatars.githubusercontent.com/u/73069040?v=4", "gravatar_id": "", "url": "https://api.github.com/users/sachinprasadhs", "html_url": "https://github.com/sachinprasadhs", "followers_url": "https://api.github.com/users/sachinprasadhs/followers", "following_url": "https://api.github.com/users/sachinprasadhs/following{/other_user}", "gists_url": "https://api.github.com/users/sachinprasadhs/gists{/gist_id}", "starred_url": "https://api.github.com/users/sachinprasadhs/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sachinprasadhs/subscriptions", "organizations_url": "https://api.github.com/users/sachinprasadhs/orgs", "repos_url": "https://api.github.com/users/sachinprasadhs/repos", "events_url": "https://api.github.com/users/sachinprasadhs/events{/privacy}", "received_events_url": "https://api.github.com/users/sachinprasadhs/received_events", "type": "User", "site_admin": false }
[ { "login": "sachinprasadhs", "id": 73069040, "node_id": "MDQ6VXNlcjczMDY5MDQw", "avatar_url": "https://avatars.githubusercontent.com/u/73069040?v=4", "gravatar_id": "", "url": "https://api.github.com/users/sachinprasadhs", "html_url": "https://github.com/sachinprasadhs", "followers_url": "https://api.github.com/users/sachinprasadhs/followers", "following_url": "https://api.github.com/users/sachinprasadhs/following{/other_user}", "gists_url": "https://api.github.com/users/sachinprasadhs/gists{/gist_id}", "starred_url": "https://api.github.com/users/sachinprasadhs/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sachinprasadhs/subscriptions", "organizations_url": "https://api.github.com/users/sachinprasadhs/orgs", "repos_url": "https://api.github.com/users/sachinprasadhs/repos", "events_url": "https://api.github.com/users/sachinprasadhs/events{/privacy}", "received_events_url": "https://api.github.com/users/sachinprasadhs/received_events", "type": "User", "site_admin": false } ]
null
[ "the following are the two log files:\r\n[err - 副本.txt](https://github.com/tensorflow/tensorflow/files/11187225/err.-.txt)\r\n[stdout-23850.txt](https://github.com/tensorflow/tensorflow/files/11187248/stdout-23850.txt)\r\n", "@SuryanarayanaY,\r\nI was able to reproduce the issue on tensorflow v2.12. Kindly find the reference below.\r\n```\r\n# Execution platform: @local_execution_config_platform//:platform\r\nERROR: C:/tensorflow/tensorflow/BUILD:1309:11: Linking tensorflow/tensorflow_cc.dll failed: (Exit 1120): link.exe failed: error executing command \r\n \r\n```", "@mraunak , Could you please take a look into the issue. Thanks!", "Hi, @yisir323, sorry for the delayed response. Could you please run the above command again on the latest commit and let us know the issue you are facing?\r\n", "Hi all, any chance there's been some progress on this issue ?", "please check this issue https://github.com/tensorflow/tensorflow/issues/61226\r\nSeems similar to this one. \r\nSeems tensorflow_cc target not supported in windows in some tensorflow versions" ]
2023-04-10T02:34:42
2023-08-18T15:42:54
null
NONE
null
null
null
<details><summary>Click to expand!</summary> ### Issue Type Build/Install ### Have you reproduced the bug with TF nightly? No ### Source source ### Tensorflow Version 2.12.0 ### Custom Code No ### OS Platform and Distribution Windows 10 professional ### Mobile device _No response_ ### Python version 3.8.5 64bit ### Bazel version 5.3.0 ### GCC/Compiler version visual studio 2019 ### CUDA/cuDNN version _No response_ ### GPU model and memory cpu model ### Current Behaviour? ```shell A bug happened!when I compile TensorFlow 2.12.0 to produce Windows C++ API files. I have tried severl times. The same erro happended. I hope you can help me,thank you ``` ### Standalone code to reproduce the issue ```shell I used Windows 10 operating system, Visual Studio 2019 C++, Bazel 5.3.0, and TensorFlow 2.12.0 to compile Windows C++ API files. My Bazel build command is: "G:\Bazel5\Bazel --output_user_root=g:\tfoutPut4 build --config=opt --define=no_tensorflow_py_deps=true --jobs=8 --subcommands //tensorflow:tensorflow_cc.dll //tensorflow:install_headers > log.txt 2> err.txt". The compilation was successful, but the linking failed with the error message: "ERROR: G:/tensorflow/tensorflow/BUILD:1219:21: Linking tensorflow/tensorflow_cc.dll failed: (Exit 1120): link.exe failed: error executing command". ``` ### Relevant log output ```shell ERROR: G:/tensorflow/tensorflow/BUILD:1219:21: Linking tensorflow/tensorflow_cc.dll failed: (Exit 1120): link.exe failed: error executing command cd /d G:/tfoutput4/ic7qrvhc/execroot/org_tensorflow SET LIB=C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.29.30133\ATLMFC\lib\x64;C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.29.30133\lib\x64;C:\Program Files (x86)\Windows Kits\NETFXSDK\4.8\lib\um\x64;C:\Program Files (x86)\Windows Kits\10\lib\10.0.19041.0\ucrt\x64;C:\Program Files (x86)\Windows Kits\10\lib\10.0.19041.0\um\x64 SET PATH=C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\Common7\IDE\\Extensions\Microsoft\IntelliCode\CLI;C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.29.30133\bin\HostX64\x64;C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\Common7\IDE\VC\VCPackages;C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\Common7\IDE\CommonExtensions\Microsoft\TestWindow;C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\Common7\IDE\CommonExtensions\Microsoft\TeamFoundation\Team Explorer;C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\MSBuild\Current\bin\Roslyn;C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\Team Tools\Performance Tools\x64;C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\Team Tools\Performance Tools;C:\Program Files (x86)\Microsoft Visual Studio\Shared\Common\VSPerfCollectionTools\vs2019\\x64;C:\Program Files (x86)\Microsoft Visual Studio\Shared\Common\VSPerfCollectionTools\vs2019\;C:\Program Files (x86)\Microsoft SDKs\Windows\v10.0A\bin\NETFX 4.8 Tools\x64\;C:\Program Files (x86)\HTML Help Workshop;C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\Common7\Tools\devinit;C:\Program Files (x86)\Windows Kits\10\bin\10.0.19041.0\x64;C:\Program Files (x86)\Windows Kits\10\bin\x64;C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\\MSBuild\Current\Bin;C:\Windows\Microsoft.NET\Framework64\v4.0.30319;C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\Common7\IDE\;C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\Common7\Tools\;;C:\Windows\system32;C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\Llvm\x64\bin;C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\Common7\IDE\CommonExtensions\Microsoft\CMake\CMake\bin;C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\Common7\IDE\CommonExtensions\Microsoft\CMake\Ninja SET PWD=/proc/self/cwd SET PYTHON_BIN_PATH=C:/ProgramData/Anaconda3/python.exe SET PYTHON_LIB_PATH=C:/ProgramData/Anaconda3/Lib/site-packages SET RUNFILES_MANIFEST_ONLY=1 SET TEMP=C:\Users\yisir\AppData\Local\Temp SET TF2_BEHAVIOR=1 SET TMP=C:\Users\yisir\AppData\Local\Temp C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.29.30133\bin\HostX64\x64\link.exe @bazel-out/x64_windows-opt/bin/tensorflow/tensorflow_cc.dll-2.params # Configuration: 86b0c99414660dd887a605e34d6ccaa371dc6e6122db6d3c5d156e9013ebeb17 # Execution platform: @local_execution_config_platform//:platform INFO: Elapsed time: 8232.786s, Critical Path: 458.51s INFO: 15506 processes: 3617 internal, 11889 local. FAILED: Build did NOT complete successfully FAILED: Build did NOT complete successfully The following is an excerpt from another log file stdout-23850 int my dirctory G:/tfoutput4/ic7qrvhc/execroot/org_tensorflow/bazel-out/_tmp/actions/ : tensorflow_cc.dll.if.exp: error LNK2001: unresolved external symbol "public: int __cdecl tensorflow::BytesList::value_size(void)const " (?value_size@BytesList@tensorflow@@QEBAHXZ) tensorflow_cc.dll.if.exp: error LNK2001: unresolved external symbol "public: int __cdecl tensorflow::FloatList::value_size(void)const " (?value_size@FloatList@tensorflow@@QEBAHXZ) tensorflow_cc.dll.if.exp: error LNK2001: unresolved external symbol "public: int __cdecl tensorflow::Int64List::value_size(void)const " (?value_size@Int64List@tensorflow@@QEBAHXZ) ibtensorflow_framework.so.2.12.0.if.lib(libtensorflow_framework.so.2.12.0): error LNK2005: TF_NewBufferFromString already defined in tf_buffer.lib(tf_buffer.obj) libtensorflow_framework.so.2.12.0.if.lib(libtensorflow_framework.so.2.12.0): error LNK2005: TF_NewTensor already defined in tf_tensor.lib(tf_tensor.obj) libtensorflow_framework.so.2.12.0.if.lib(libtensorflow_framework.so.2.12.0): error LNK2005: TF_TensorData already defined in tf_tensor.lib(tf_tensor.obj) Creating library bazel-out/x64_windows-opt/bin/tensorflow/tensorflow_cc.dll.if.lib and object bazel-out/x64_windows-opt/bin/tensorflow/tensorflow_cc.dll.if.exp LINK: warning LNK4217: symbol "TFE_NewContextOptions" (defined in "c_api.lo.lib(c_api.obj)") already imported in "pass_utils.lib(utils.obj)" (function "?InitializeTFRuntime@quant@mlir@@YAPEAUTFE_Context@@XZ" (?InitializeTFRuntime@quant@mlir@@YAPEAUTFE_Context@@XZ)) LINK: warning LNK4286: symbol "TFE_NewContextOptions" (defined in "c_api.lo.lib(c_api.obj)") already imported in "tf_dialect_passes.lo.lib(constant_fold.obj)" ``` </details>
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/60283/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/60283/timeline
null
null
false
https://api.github.com/repos/tensorflow/tensorflow/issues/60282
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/60282/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/60282/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/60282/events
https://github.com/tensorflow/tensorflow/issues/60282
1,660,032,387
I_kwDOArmXAs5i8hWD
60,282
Enabling XNNPACK with Raspberry Pi Zero/W
{ "login": "samveen", "id": 1241434, "node_id": "MDQ6VXNlcjEyNDE0MzQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1241434?v=4", "gravatar_id": "", "url": "https://api.github.com/users/samveen", "html_url": "https://github.com/samveen", "followers_url": "https://api.github.com/users/samveen/followers", "following_url": "https://api.github.com/users/samveen/following{/other_user}", "gists_url": "https://api.github.com/users/samveen/gists{/gist_id}", "starred_url": "https://api.github.com/users/samveen/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/samveen/subscriptions", "organizations_url": "https://api.github.com/users/samveen/orgs", "repos_url": "https://api.github.com/users/samveen/repos", "events_url": "https://api.github.com/users/samveen/events{/privacy}", "received_events_url": "https://api.github.com/users/samveen/received_events", "type": "User", "site_admin": false }
[ { "id": 404586594, "node_id": "MDU6TGFiZWw0MDQ1ODY1OTQ=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/stat:awaiting%20tensorflower", "name": "stat:awaiting tensorflower", "color": "f4b400", "default": false, "description": "Status - Awaiting response from tensorflower" }, { "id": 473173351, "node_id": "MDU6TGFiZWw0NzMxNzMzNTE=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/type:build/install", "name": "type:build/install", "color": "159b2e", "default": false, "description": "Build and install issues" }, { "id": 750616506, "node_id": "MDU6TGFiZWw3NTA2MTY1MDY=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/comp:lite", "name": "comp:lite", "color": "0052cc", "default": false, "description": "TF Lite related issues" }, { "id": 2726299159, "node_id": "MDU6TGFiZWwyNzI2Mjk5MTU5", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/comp:lite-xnnpack", "name": "comp:lite-xnnpack", "color": "97F7B2", "default": false, "description": "TensorFlow Lite XNNPack related issues" }, { "id": 5206407904, "node_id": "LA_kwDOArmXAs8AAAABNlN64A", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/TF%202.12", "name": "TF 2.12", "color": "c5def5", "default": false, "description": "For issues related to Tensorflow 2.12" } ]
open
false
{ "login": "terryheo", "id": 2908505, "node_id": "MDQ6VXNlcjI5MDg1MDU=", "avatar_url": "https://avatars.githubusercontent.com/u/2908505?v=4", "gravatar_id": "", "url": "https://api.github.com/users/terryheo", "html_url": "https://github.com/terryheo", "followers_url": "https://api.github.com/users/terryheo/followers", "following_url": "https://api.github.com/users/terryheo/following{/other_user}", "gists_url": "https://api.github.com/users/terryheo/gists{/gist_id}", "starred_url": "https://api.github.com/users/terryheo/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/terryheo/subscriptions", "organizations_url": "https://api.github.com/users/terryheo/orgs", "repos_url": "https://api.github.com/users/terryheo/repos", "events_url": "https://api.github.com/users/terryheo/events{/privacy}", "received_events_url": "https://api.github.com/users/terryheo/received_events", "type": "User", "site_admin": false }
[ { "login": "terryheo", "id": 2908505, "node_id": "MDQ6VXNlcjI5MDg1MDU=", "avatar_url": "https://avatars.githubusercontent.com/u/2908505?v=4", "gravatar_id": "", "url": "https://api.github.com/users/terryheo", "html_url": "https://github.com/terryheo", "followers_url": "https://api.github.com/users/terryheo/followers", "following_url": "https://api.github.com/users/terryheo/following{/other_user}", "gists_url": "https://api.github.com/users/terryheo/gists{/gist_id}", "starred_url": "https://api.github.com/users/terryheo/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/terryheo/subscriptions", "organizations_url": "https://api.github.com/users/terryheo/orgs", "repos_url": "https://api.github.com/users/terryheo/repos", "events_url": "https://api.github.com/users/terryheo/events{/privacy}", "received_events_url": "https://api.github.com/users/terryheo/received_events", "type": "User", "site_admin": false }, { "login": "sachinprasadhs", "id": 73069040, "node_id": "MDQ6VXNlcjczMDY5MDQw", "avatar_url": "https://avatars.githubusercontent.com/u/73069040?v=4", "gravatar_id": "", "url": "https://api.github.com/users/sachinprasadhs", "html_url": "https://github.com/sachinprasadhs", "followers_url": "https://api.github.com/users/sachinprasadhs/followers", "following_url": "https://api.github.com/users/sachinprasadhs/following{/other_user}", "gists_url": "https://api.github.com/users/sachinprasadhs/gists{/gist_id}", "starred_url": "https://api.github.com/users/sachinprasadhs/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sachinprasadhs/subscriptions", "organizations_url": "https://api.github.com/users/sachinprasadhs/orgs", "repos_url": "https://api.github.com/users/sachinprasadhs/repos", "events_url": "https://api.github.com/users/sachinprasadhs/events{/privacy}", "received_events_url": "https://api.github.com/users/sachinprasadhs/received_events", "type": "User", "site_admin": false } ]
null
[ "Hi @samveen \r\n\r\nAs per the TFLite [documentation](https://www.tensorflow.org/lite/guide/build_cmake_arm#build_for_raspberry_pi_zero_armv6), the support for XNNPACK is disabled for ARMv6 since there is no NEON support. \r\n\r\nHave you observed the same behaviour with `-mfpu=vfpv2` as suggested by [README for xxnpack](https://github.com/google/XNNPACK#supported-architectures)?\r\n\r\nThanks.", "As can be seen in the log output, no matter what the user supplied values of `-march` and `-mfpu` are, the build integration of tflite with XNNPACK will add `-march=armv8.2-a+dotprod -mfpu=neon-fp-armv8` to the build flags for XNNPACK. \r\n\r\nFrom the [XNNPACK readme](https://github.com/google/XNNPACK#supported-architectures), it's clear that there is a subset of XNNPACK that is usable for Raspberry Pi Zero/ Zero W). However, what is not clear is that can tflite use just that subset of XNNPACK when it's being built for the Zero/Zero W.\r\n\r\nI'll try and build XNNPACK on the Pi Zero as per [the instructions](https://github.com/google/XNNPACK#raspberry-pi) and get back to you on the build state.\r\n", "@pjpratik\r\n- I've opened an issue against XNNPACK for more details (google/XNNPACK#4636) but there's been no response there\r\n- I've managed to native build a version of XNNPACK on the ZeroW (upwards of 24 hours to build) with the following:\r\n```bash ./scripts/build-local.sh -DXNNPACK_ENABLE_ARM_DOTPROD:BOOL=OFF```\r\n- One of the DOTPROD kernels has Neon assembly instruction which causes the build to fail, this the need for `XNNPACK_ENABLE_ARM_DOTPROD:BOOL=OFF`\r\n- The script runs tests against the build, but hasn't completed the 3rd test for `FP32 MobileNet v3 Large` even after 24 hours of running, which leads me believe that it might be stuck instead of taking time (the expected time on the Zero/Zero W is less that for `FP32 MobileNet v2 1.0X` which completes in less than 3 seconds)\r\n- In light of the above sticking point, I'm hoping I get some response from the XNNPACK team, even a 'no longer possible' one, which should give some clarity.", "@samveen Thanks for the information.\r\n\r\n@sachinprasadhs Could you please look into this issue?\r\n\r\nThanks.", "@pjpratik @sachinprasadhs I've created an issue against XNNPACK with a lot more details with regards to RPi0 builds - google/XNNPACK#4701 , giving the issues I've faced, the build process I followed and details of my native build environment. Hopefully that should give more insight into the underlying issues." ]
2023-04-09T23:07:03
2023-04-25T21:11:38
null
NONE
null
null
null
<details><summary>Click to expand!</summary> ### Issue Type Build/Install ### Have you reproduced the bug with TF nightly? No ### Source source ### Tensorflow Version 2.12.0 ### Custom Code No ### OS Platform and Distribution Linux Raspberrypi OS 32-bit (Debian bullseye) ### Mobile device Raspberry Pi Zero W ### Python version 3.9.2 ### Bazel version cmake 3.18.4 ### GCC/Compiler version GNU c++ (Raspbian 10.2.1-6+rpi1) 10.2.1 20210110 ### CUDA/cuDNN version NA ### GPU model and memory NA ### Current Behaviour? The tf-lite build instructions for Raspberry Pi Zero/Zero W state that the following should be part of the CFLAGS/CXXFLAGS: `-march=armv6 -mfpu=vfp -mfloat-abi=hard -funsafe-math-optimizations` As per the [README for xxnpack](https://github.com/google/XNNPACK#raspberry-pi), XNNPACK supports running on the armv6 with vpf that's the Raspberry Pi Zero W. However all build instructions for Raspberry Pi Zero request explicitly disabling xnnpack. Given the support for rpi0 in xnnpack documentation, I tried to build tf-lite with xnnpack enabled. When the xnnpack sub-build is enabled, the following conflicting CFLAGS are added to the compiler invocation during the xnnpack sub-build: ``` -marm -march=armv8.2-a+dotprod -mfpu=neon-fp-armv8``` Please document/extend the cmake and build instructions to allow tf-lite to build correctly with xnnpack enabled for the Raspberry Pi Zero/Zero W. ### Standalone code to reproduce the issue ```shell cmake \ -DCMAKE_C_FLAGS='-march=armv6 -mfpu=vfp -mfloat-abi=hard -funsafe-math-optimizations -I/usr/include/python3.9 -I/usr/lib/python3/dist-packages/pybind11/include -I/usr/lib/python3/dist-packages/numpy/core/include' \ -DCMAKE_CXX_FLAGS='-march=armv6 -mfpu=vfp -mfloat-abi=hard -funsafe-math-optimizations -I/usr/include/python3.9 -I/usr/lib/python3/dist-packages/pybind11/include -I/usr/lib/python3/dist-packages/numpy/core/include' \ -DCMAKE_VERBOSE_MAKEFILE:BOOL=ON \ -DCMAKE_SYSTEM_NAME=Linux \ -DCMAKE_SYSTEM_PROCESSOR=armv6 \ -DTFLITE_ENABLE_XNNPACK=ON \ /home/samveen/tensorflow/build/../tensorflow/lite ... cmake --build . --verbose -t _pywrap_tensorflow_interpreter_wrapper ``` ### Relevant log output ```shell /usr/bin/gmake -f _deps/xnnpack-build/CMakeFiles/microkernels-prod.dir/build.make _deps/xnnpack-build/CMakeFiles/microkernels-prod.dir/build gmake[3]: Entering directory '/home/samveen/tensorflow/build/gen/tflite_pip/python3/cmake_build' [ 47%] Building C object _deps/xnnpack-build/CMakeFiles/microkernels-prod.dir/src/amalgam/neondot.c.o cd /home/samveen/tensorflow/build/gen/tflite_pip/python3/cmake_build/_deps/xnnpack-build && /usr/bin/cc -DEIGEN_MPL2_ONLY -DFXDIV_USE_INLINE_ASSEMBLY=0 -DNOMINMAX=1 -DPTHREADPOOL_NO_DEPRECATED_API=1 -DXNN_ENABLE_ARM_BF16=1 -DXNN_ENABLE_ARM_DOTPROD=1 -DXNN_ENABLE_ARM_FP16_SCALAR=1 -DXNN_ENABLE_ARM_FP16_VECTOR=1 -DXNN_ENABLE_ASSEMBLY=1 -DXNN_ENABLE_DWCONV_MULTIPASS=0 -DXNN_ENABLE_GEMM_M_SPECIALIZATION=1 -DXNN_ENABLE_JIT=0 -DXNN_ENABLE_MEMOPT=1 -DXNN_ENABLE_RISCV_VECTOR=1 -DXNN_ENABLE_SPARSE=1 -I/home/samveen/tensorflow/build/gen/tflite_pip/python3/cmake_build/xnnpack/src -I/home/samveen/tensorflow/build/gen/tflite_pip/python3/cmake_build/pthreadpool-source/include -I/home/samveen/tensorflow/build/gen/tflite_pip/python3/cmake_build/FXdiv-source/include -I/home/samveen/tensorflow/build/gen/tflite_pip/python3/cmake_build/FP16-source/include -march=armv6 -mfpu=vfp -mfloat-abi=hard -funsafe-math-optimizations -I/usr/include/python3.9 -I/usr/lib/python3/dist-packages/pybind11/include -I/usr/lib/python3/dist-packages/numpy/core/include -O3 -DNDEBUG -fPIC -Wno-psabi -O2 -pthread -std=c99 -marm -march=armv8.2-a+dotprod -mfpu=neon-fp-armv8 -o CMakeFiles/microkernels-prod.dir/src/amalgam/neondot.c.o -c /home/samveen/tensorflow/build/gen/tflite_pip/python3/cmake_build/xnnpack/src/amalgam/neondot.c /tmp/ccotLSur.s: Assembler messages: /tmp/ccotLSur.s:63: Error: selected processor does not support `vsdot.s8 q8,q12,d7[0]' in ARM mode /tmp/ccotLSur.s:65: Error: selected processor does not support `vsdot.s8 q9,q10,d7[0]' in ARM mode /tmp/ccotLSur.s:68: Error: selected processor does not support `vsdot.s8 q11,q10,d7[0]' in ARM mode /tmp/ccotLSur.s:71: Error: selected processor does not support `vsdot.s8 q14,q10,d7[0]' in ARM mode /tmp/ccotLSur.s:74: Error: selected processor does not support `vsdot.s8 q8,q10,d7[1]' in ARM mode /tmp/ccotLSur.s:77: Error: selected processor does not support `vsdot.s8 q9,q10,d7[1]' in ARM mode /tmp/ccotLSur.s:80: Error: selected processor does not support `vsdot.s8 q11,q10,d7[1]' in ARM mode ... ``` </details>
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/60282/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/60282/timeline
null
null
false
https://api.github.com/repos/tensorflow/tensorflow/issues/60281
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/60281/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/60281/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/60281/events
https://github.com/tensorflow/tensorflow/issues/60281
1,660,014,592
I_kwDOArmXAs5i8dAA
60,281
M1 mac LLVM bug for tensor multiplication
{ "login": "AlbertoSinigaglia", "id": 25763924, "node_id": "MDQ6VXNlcjI1NzYzOTI0", "avatar_url": "https://avatars.githubusercontent.com/u/25763924?v=4", "gravatar_id": "", "url": "https://api.github.com/users/AlbertoSinigaglia", "html_url": "https://github.com/AlbertoSinigaglia", "followers_url": "https://api.github.com/users/AlbertoSinigaglia/followers", "following_url": "https://api.github.com/users/AlbertoSinigaglia/following{/other_user}", "gists_url": "https://api.github.com/users/AlbertoSinigaglia/gists{/gist_id}", "starred_url": "https://api.github.com/users/AlbertoSinigaglia/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/AlbertoSinigaglia/subscriptions", "organizations_url": "https://api.github.com/users/AlbertoSinigaglia/orgs", "repos_url": "https://api.github.com/users/AlbertoSinigaglia/repos", "events_url": "https://api.github.com/users/AlbertoSinigaglia/events{/privacy}", "received_events_url": "https://api.github.com/users/AlbertoSinigaglia/received_events", "type": "User", "site_admin": false }
[ { "id": 386191887, "node_id": "MDU6TGFiZWwzODYxOTE4ODc=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/stat:awaiting%20response", "name": "stat:awaiting response", "color": "f4b400", "default": false, "description": "Status - Awaiting response from author" }, { "id": 473172988, "node_id": "MDU6TGFiZWw0NzMxNzI5ODg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/type:bug", "name": "type:bug", "color": "159b2e", "default": false, "description": "Bug" }, { "id": 474725938, "node_id": "MDU6TGFiZWw0NzQ3MjU5Mzg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/stale", "name": "stale", "color": "d4c5f9", "default": false, "description": "This label marks the issue/pr stale - to be closed automatically if no activity" }, { "id": 1097547147, "node_id": "MDU6TGFiZWwxMDk3NTQ3MTQ3", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/comp:ops", "name": "comp:ops", "color": "0052cc", "default": false, "description": "OPs related issues" }, { "id": 1205765054, "node_id": "MDU6TGFiZWwxMjA1NzY1MDU0", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/subtype:macOS", "name": "subtype:macOS", "color": "b619ea", "default": false, "description": "macOS Build/Installation issues" }, { "id": 4829271983, "node_id": "LA_kwDOArmXAs8AAAABH9jXrw", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/TF%202.11", "name": "TF 2.11", "color": "46B4D7", "default": false, "description": "Issues related to TF 2.11" } ]
closed
false
{ "login": "sachinprasadhs", "id": 73069040, "node_id": "MDQ6VXNlcjczMDY5MDQw", "avatar_url": "https://avatars.githubusercontent.com/u/73069040?v=4", "gravatar_id": "", "url": "https://api.github.com/users/sachinprasadhs", "html_url": "https://github.com/sachinprasadhs", "followers_url": "https://api.github.com/users/sachinprasadhs/followers", "following_url": "https://api.github.com/users/sachinprasadhs/following{/other_user}", "gists_url": "https://api.github.com/users/sachinprasadhs/gists{/gist_id}", "starred_url": "https://api.github.com/users/sachinprasadhs/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sachinprasadhs/subscriptions", "organizations_url": "https://api.github.com/users/sachinprasadhs/orgs", "repos_url": "https://api.github.com/users/sachinprasadhs/repos", "events_url": "https://api.github.com/users/sachinprasadhs/events{/privacy}", "received_events_url": "https://api.github.com/users/sachinprasadhs/received_events", "type": "User", "site_admin": false }
[ { "login": "sachinprasadhs", "id": 73069040, "node_id": "MDQ6VXNlcjczMDY5MDQw", "avatar_url": "https://avatars.githubusercontent.com/u/73069040?v=4", "gravatar_id": "", "url": "https://api.github.com/users/sachinprasadhs", "html_url": "https://github.com/sachinprasadhs", "followers_url": "https://api.github.com/users/sachinprasadhs/followers", "following_url": "https://api.github.com/users/sachinprasadhs/following{/other_user}", "gists_url": "https://api.github.com/users/sachinprasadhs/gists{/gist_id}", "starred_url": "https://api.github.com/users/sachinprasadhs/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sachinprasadhs/subscriptions", "organizations_url": "https://api.github.com/users/sachinprasadhs/orgs", "repos_url": "https://api.github.com/users/sachinprasadhs/repos", "events_url": "https://api.github.com/users/sachinprasadhs/events{/privacy}", "received_events_url": "https://api.github.com/users/sachinprasadhs/received_events", "type": "User", "site_admin": false } ]
null
[ "@SuryanarayanaY \r\nI was able to reproduce the issue on Mac M1 using tf 2.11. Please find the below screenshot for reference:\r\n<img width=\"565\" alt=\"Screenshot 2023-04-12 at 3 12 54 PM\" src=\"https://user-images.githubusercontent.com/111861663/231423500-0dd0eafd-f081-4000-9d01-34a7190b2539.png\">\r\nI was able to execute the code without error on colab using tf2.11 and tf2.12. Please find the gist of [tf2.11](https://colab.research.google.com/gist/tiruk007/c1366ad9bf92608d71a884b46bfc58a0/untitled187.ipynb) and [tf2.12](https://colab.research.google.com/gist/tiruk007/069354340b8af5dfd3f5751b263c23de/untitled188.ipynb) for reference.\r\n\r\nThank you !\r\n", "@AlbertoSinigaglia ,\r\n\r\nI have explicitly tried the code with `Colab` on CPU and GPU by using tf.device() and it works fine for both.Reference [gist](https://colab.sandbox.google.com/gist/SuryanarayanaY/b260d9fb9990274e679cab1de774685d/60281.ipynb).\r\n\r\nWhen tried the code on Mac by with `tf.device('CPU')` the code works fine and the problem raises when used `tf.device('GPU')`. Please refer the attached logs below.\r\n\r\n[60281_mac_logs.txt](https://github.com/tensorflow/tensorflow/files/11210566/60281_mac_logs.txt)\r\n\r\n\r\nThis seems to be issue specific to `tensorflow-macos` which is maintained by Apple it self. Request you to file an issue there also and mostly should be addressed by them.Efforts from our side also will be in place to collaborate with Apple team to resolve the issue.\r\n\r\nThanks!", "> @AlbertoSinigaglia ,\r\n> \r\n> I have explicitly tried the code with `Colab` on CPU and GPU by using tf.device() and it works fine for both.Reference [gist](https://colab.sandbox.google.com/gist/SuryanarayanaY/b260d9fb9990274e679cab1de774685d/60281.ipynb).\r\n> \r\n> When tried the code on Mac by with `tf.device('CPU')` the code works fine and the problem raises when used `tf.device('GPU')`. Please refer the attached logs below.\r\n> \r\n> [60281_mac_logs.txt](https://github.com/tensorflow/tensorflow/files/11210566/60281_mac_logs.txt)\r\n> \r\n> This seems to be issue specific to `tensorflow-macos` which is maintained by Apple it self. Request you to file an issue there also and mostly should be addressed by them.Efforts from our side also will be in place to collaborate with Apple team to resolve the issue.\r\n> \r\n> Thanks!\r\n\r\nWill do that, even though I have already many pending requests to Apple, with no answer since months...", "@nitins17 , Could you please have a look and confirm whether any pointers here?\r\n\r\nCC: @learning-to-play ", "Hi,\r\n\r\nThe issue seems to be resolved with the latest Tensorflow version.\r\n\r\nYou can now install Tensorflow package on M1 from 2.13 using pip install Tensorflow.\r\n\r\nBelow is the command to install Tensorflow package, once it is installed, code mentioned in the issue runs without any error.\r\n\r\n!pip install tensorflow==2.13rc1", "This issue is stale because it has been open for 7 days with no activity. It will be closed if no further activity occurs. Thank you.", "This issue was closed because it has been inactive for 7 days since being marked as stale. Please reopen if you'd like to work on this further.", "Are you satisfied with the resolution of your issue?\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=Yes&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/60281\">Yes</a>\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=No&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/60281\">No</a>\n" ]
2023-04-09T21:53:47
2023-06-22T02:02:01
2023-06-22T02:01:59
NONE
null
null
null
### Issue Type Bug ### Have you reproduced the bug with TF nightly? No ### Source source ### Tensorflow Version 2.8.0, 2.11 ### Custom Code No ### OS Platform and Distribution MaxOS 12.3.1 ### Python version 3.9, 3.10 ### GPU model and memory M1 Max 26 cores GPU 32 GB ram ### Current Behaviour? ```shell For some reason, it does not allow me to matrix multiply those 2 tensors (on M1, Colab works just fine) ``` ### Standalone code to reproduce the issue ```shell import tensorflow as tf import numpy as np class EncoderBlock(tf.keras.layers.Layer): def __init__(self,**kwargs): super().__init__(**kwargs) self.n_heads = 2 def build(self, input_shape): self.WQ = self.add_weight("WQ_encoder", (self.n_heads, input_shape[-1], 10)) # however, an easy fix is the using the following: # self.WQ = self.add_weight("WQ_encoder", (1, self.n_heads, input_shape[-1], 10)) # but clearly there is a problem, as the broadcast should take place nicely like on Colab def call(self, inputs, mask, *args): inputs = inputs[:,None,...] _ = tf.matmul(inputs,self.WQ) # ^^^^^^^^^^^^^^^^^^^^^^^^^^^ EncoderBlock()(np.random.randn(3,10,13), np.ones((3,10))) ``` ### Relevant log output ```shell -:5:10: error: incompatible dimensions -:5:10: error: invalid shape LLVM ERROR: Failed to infer result type(s). ```
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/60281/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/60281/timeline
null
completed
false
https://api.github.com/repos/tensorflow/tensorflow/issues/60280
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/60280/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/60280/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/60280/events
https://github.com/tensorflow/tensorflow/issues/60280
1,659,977,747
I_kwDOArmXAs5i8UAT
60,280
Cannot use extended batch shape with channel_first Conv2D
{ "login": "Yang-Yuan", "id": 37008375, "node_id": "MDQ6VXNlcjM3MDA4Mzc1", "avatar_url": "https://avatars.githubusercontent.com/u/37008375?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Yang-Yuan", "html_url": "https://github.com/Yang-Yuan", "followers_url": "https://api.github.com/users/Yang-Yuan/followers", "following_url": "https://api.github.com/users/Yang-Yuan/following{/other_user}", "gists_url": "https://api.github.com/users/Yang-Yuan/gists{/gist_id}", "starred_url": "https://api.github.com/users/Yang-Yuan/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Yang-Yuan/subscriptions", "organizations_url": "https://api.github.com/users/Yang-Yuan/orgs", "repos_url": "https://api.github.com/users/Yang-Yuan/repos", "events_url": "https://api.github.com/users/Yang-Yuan/events{/privacy}", "received_events_url": "https://api.github.com/users/Yang-Yuan/received_events", "type": "User", "site_admin": false }
[ { "id": 386191887, "node_id": "MDU6TGFiZWwzODYxOTE4ODc=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/stat:awaiting%20response", "name": "stat:awaiting response", "color": "f4b400", "default": false, "description": "Status - Awaiting response from author" }, { "id": 473172988, "node_id": "MDU6TGFiZWw0NzMxNzI5ODg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/type:bug", "name": "type:bug", "color": "159b2e", "default": false, "description": "Bug" }, { "id": 474725938, "node_id": "MDU6TGFiZWw0NzQ3MjU5Mzg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/stale", "name": "stale", "color": "d4c5f9", "default": false, "description": "This label marks the issue/pr stale - to be closed automatically if no activity" }, { "id": 1097547147, "node_id": "MDU6TGFiZWwxMDk3NTQ3MTQ3", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/comp:ops", "name": "comp:ops", "color": "0052cc", "default": false, "description": "OPs related issues" }, { "id": 5206407904, "node_id": "LA_kwDOArmXAs8AAAABNlN64A", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/TF%202.12", "name": "TF 2.12", "color": "c5def5", "default": false, "description": "For issues related to Tensorflow 2.12" } ]
closed
false
{ "login": "sushreebarsa", "id": 84765720, "node_id": "MDQ6VXNlcjg0NzY1NzIw", "avatar_url": "https://avatars.githubusercontent.com/u/84765720?v=4", "gravatar_id": "", "url": "https://api.github.com/users/sushreebarsa", "html_url": "https://github.com/sushreebarsa", "followers_url": "https://api.github.com/users/sushreebarsa/followers", "following_url": "https://api.github.com/users/sushreebarsa/following{/other_user}", "gists_url": "https://api.github.com/users/sushreebarsa/gists{/gist_id}", "starred_url": "https://api.github.com/users/sushreebarsa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sushreebarsa/subscriptions", "organizations_url": "https://api.github.com/users/sushreebarsa/orgs", "repos_url": "https://api.github.com/users/sushreebarsa/repos", "events_url": "https://api.github.com/users/sushreebarsa/events{/privacy}", "received_events_url": "https://api.github.com/users/sushreebarsa/received_events", "type": "User", "site_admin": false }
[ { "login": "sushreebarsa", "id": 84765720, "node_id": "MDQ6VXNlcjg0NzY1NzIw", "avatar_url": "https://avatars.githubusercontent.com/u/84765720?v=4", "gravatar_id": "", "url": "https://api.github.com/users/sushreebarsa", "html_url": "https://github.com/sushreebarsa", "followers_url": "https://api.github.com/users/sushreebarsa/followers", "following_url": "https://api.github.com/users/sushreebarsa/following{/other_user}", "gists_url": "https://api.github.com/users/sushreebarsa/gists{/gist_id}", "starred_url": "https://api.github.com/users/sushreebarsa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sushreebarsa/subscriptions", "organizations_url": "https://api.github.com/users/sushreebarsa/orgs", "repos_url": "https://api.github.com/users/sushreebarsa/repos", "events_url": "https://api.github.com/users/sushreebarsa/events{/privacy}", "received_events_url": "https://api.github.com/users/sushreebarsa/received_events", "type": "User", "site_admin": false } ]
null
[ "@Yang-Yuan Thanks for reporting an issue!\r\nCould you please elaborate the issue here by stating the example if you are using any. Thank you!", "This issue is stale because it has been open for 7 days with no activity. It will be closed if no further activity occurs. Thank you.", "This issue was closed because it has been inactive for 7 days since being marked as stale. Please reopen if you'd like to work on this further.", "Are you satisfied with the resolution of your issue?\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=Yes&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/60280\">Yes</a>\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=No&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/60280\">No</a>\n" ]
2023-04-09T19:25:50
2023-04-27T01:54:26
2023-04-27T01:54:23
NONE
null
null
null
<details><summary>Click to expand!</summary> ### Issue Type Bug ### Have you reproduced the bug with TF nightly? No ### Source source ### Tensorflow Version 2.12 ### Custom Code Yes ### OS Platform and Distribution Ubuntu 1804 ### Mobile device _No response_ ### Python version _No response_ ### Bazel version _No response_ ### GCC/Compiler version _No response_ ### CUDA/cuDNN version _No response_ ### GPU model and memory _No response_ ### Current Behaviour? ```shell Given input tensor for shape, say [batch_dim_1 = 4, batch_dim_2 = 5, channels = 6, Height = 7, Width = 8] to a channels_first (keras) Conv2D of stride 2, the "_get_sequence" function at Line 1288 in nn_ops.py sets strides to [1, 2, 2, 1], which is wrong. Strides should be [1, 1, 2, 2] for the input tensor will be reshaped to [batch_dim_1 * batch_dim_2, channels, Height, Width] later in squeeze_batch_dim in nn_ops.py. ``` ### Standalone code to reproduce the issue ```shell As described above. ``` ### Relevant log output _No response_</details>
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/60280/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/60280/timeline
null
completed
false
https://api.github.com/repos/tensorflow/tensorflow/issues/60279
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/60279/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/60279/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/60279/events
https://github.com/tensorflow/tensorflow/issues/60279
1,659,958,175
I_kwDOArmXAs5i8POf
60,279
AttributeError: 'Delegate' object has no attribute '_library'
{ "login": "jukomol", "id": 41579086, "node_id": "MDQ6VXNlcjQxNTc5MDg2", "avatar_url": "https://avatars.githubusercontent.com/u/41579086?v=4", "gravatar_id": "", "url": "https://api.github.com/users/jukomol", "html_url": "https://github.com/jukomol", "followers_url": "https://api.github.com/users/jukomol/followers", "following_url": "https://api.github.com/users/jukomol/following{/other_user}", "gists_url": "https://api.github.com/users/jukomol/gists{/gist_id}", "starred_url": "https://api.github.com/users/jukomol/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/jukomol/subscriptions", "organizations_url": "https://api.github.com/users/jukomol/orgs", "repos_url": "https://api.github.com/users/jukomol/repos", "events_url": "https://api.github.com/users/jukomol/events{/privacy}", "received_events_url": "https://api.github.com/users/jukomol/received_events", "type": "User", "site_admin": false }
[ { "id": 750616506, "node_id": "MDU6TGFiZWw3NTA2MTY1MDY=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/comp:lite", "name": "comp:lite", "color": "0052cc", "default": false, "description": "TF Lite related issues" } ]
closed
false
{ "login": "tilakrayal", "id": 81610181, "node_id": "MDQ6VXNlcjgxNjEwMTgx", "avatar_url": "https://avatars.githubusercontent.com/u/81610181?v=4", "gravatar_id": "", "url": "https://api.github.com/users/tilakrayal", "html_url": "https://github.com/tilakrayal", "followers_url": "https://api.github.com/users/tilakrayal/followers", "following_url": "https://api.github.com/users/tilakrayal/following{/other_user}", "gists_url": "https://api.github.com/users/tilakrayal/gists{/gist_id}", "starred_url": "https://api.github.com/users/tilakrayal/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/tilakrayal/subscriptions", "organizations_url": "https://api.github.com/users/tilakrayal/orgs", "repos_url": "https://api.github.com/users/tilakrayal/repos", "events_url": "https://api.github.com/users/tilakrayal/events{/privacy}", "received_events_url": "https://api.github.com/users/tilakrayal/received_events", "type": "User", "site_admin": false }
[ { "login": "tilakrayal", "id": 81610181, "node_id": "MDQ6VXNlcjgxNjEwMTgx", "avatar_url": "https://avatars.githubusercontent.com/u/81610181?v=4", "gravatar_id": "", "url": "https://api.github.com/users/tilakrayal", "html_url": "https://github.com/tilakrayal", "followers_url": "https://api.github.com/users/tilakrayal/followers", "following_url": "https://api.github.com/users/tilakrayal/following{/other_user}", "gists_url": "https://api.github.com/users/tilakrayal/gists{/gist_id}", "starred_url": "https://api.github.com/users/tilakrayal/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/tilakrayal/subscriptions", "organizations_url": "https://api.github.com/users/tilakrayal/orgs", "repos_url": "https://api.github.com/users/tilakrayal/repos", "events_url": "https://api.github.com/users/tilakrayal/events{/privacy}", "received_events_url": "https://api.github.com/users/tilakrayal/received_events", "type": "User", "site_admin": false } ]
null
[]
2023-04-09T18:12:20
2023-04-09T19:28:19
2023-04-09T19:28:19
NONE
null
null
null
**System information** - ubuntu 18.04.6 lts - tflite-runtime installed from Source, Using 'sudo apt-get install python3-tflite-runtime' [version: 2.5.0] - Python Verison: 3.6 - edgetpu-compiler 16 amd64 **Provide the text output from tflite_convert** syncx@syncx:~/cubesatnet_improvised/tflite/python/examples/classification$ python3 classify_image.py \ > --model models/mobilenet_v2_1.0_224_inat_bird_quant_edgetpu.tflite \ > --labels models/inat_bird_labels.txt \ > --input images/parrot.jpg Traceback (most recent call last): File "classify_image.py", line 122, in <module> main() File "classify_image.py", line 99, in main interpreter = make_interpreter(args.model) File "classify_image.py", line 73, in make_interpreter {'device': device[0]} if device else {}) File "/usr/lib/python3/dist-packages/tflite_runtime/interpreter.py", line 160, in load_delegate delegate = Delegate(library, options) File "/usr/lib/python3/dist-packages/tflite_runtime/interpreter.py", line 89, in __init__ self._library = ctypes.pydll.LoadLibrary(library) File "/usr/lib/python3.6/ctypes/__init__.py", line 426, in LoadLibrary return self._dlltype(name) File "/usr/lib/python3.6/ctypes/__init__.py", line 348, in __init__ self._handle = _dlopen(self._name, mode) OSError: libedgetpu.so.1: cannot open shared object file: No such file or directory Exception ignored in: <bound method Delegate.__del__ of <tflite_runtime.interpreter.Delegate object at 0x7fa771c0ae48>> Traceback (most recent call last): File "/usr/lib/python3/dist-packages/tflite_runtime/interpreter.py", line 124, in __del__ if self._library is not None: AttributeError: 'Delegate' object has no attribute '_library' **Standalone code to reproduce the issue** python3 classify_image.py \ --model models/mobilenet_v2_1.0_224_inat_bird_quant_edgetpu.tflite \ --labels models/inat_bird_labels.txt \ --input images/parrot.jpg I am trying coral dev board micro. So, I tried "https://github.com/google-coral/tflite/tree/master/python/examples/classification" in this example. It produces the above error. I followed the instructions properly and tried everything I found on Google, but I am unsure what is occurring with this issue.
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/60279/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/60279/timeline
null
completed
false
https://api.github.com/repos/tensorflow/tensorflow/issues/60278
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/60278/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/60278/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/60278/events
https://github.com/tensorflow/tensorflow/issues/60278
1,659,763,606
I_kwDOArmXAs5i7fuW
60,278
A check fail can be triggered in MatrixSolve
{ "login": "shijy16", "id": 31403391, "node_id": "MDQ6VXNlcjMxNDAzMzkx", "avatar_url": "https://avatars.githubusercontent.com/u/31403391?v=4", "gravatar_id": "", "url": "https://api.github.com/users/shijy16", "html_url": "https://github.com/shijy16", "followers_url": "https://api.github.com/users/shijy16/followers", "following_url": "https://api.github.com/users/shijy16/following{/other_user}", "gists_url": "https://api.github.com/users/shijy16/gists{/gist_id}", "starred_url": "https://api.github.com/users/shijy16/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/shijy16/subscriptions", "organizations_url": "https://api.github.com/users/shijy16/orgs", "repos_url": "https://api.github.com/users/shijy16/repos", "events_url": "https://api.github.com/users/shijy16/events{/privacy}", "received_events_url": "https://api.github.com/users/shijy16/received_events", "type": "User", "site_admin": false }
[ { "id": 386191887, "node_id": "MDU6TGFiZWwzODYxOTE4ODc=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/stat:awaiting%20response", "name": "stat:awaiting response", "color": "f4b400", "default": false, "description": "Status - Awaiting response from author" }, { "id": 473172988, "node_id": "MDU6TGFiZWw0NzMxNzI5ODg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/type:bug", "name": "type:bug", "color": "159b2e", "default": false, "description": "Bug" }, { "id": 474725938, "node_id": "MDU6TGFiZWw0NzQ3MjU5Mzg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/stale", "name": "stale", "color": "d4c5f9", "default": false, "description": "This label marks the issue/pr stale - to be closed automatically if no activity" }, { "id": 1097547147, "node_id": "MDU6TGFiZWwxMDk3NTQ3MTQ3", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/comp:ops", "name": "comp:ops", "color": "0052cc", "default": false, "description": "OPs related issues" }, { "id": 5206407904, "node_id": "LA_kwDOArmXAs8AAAABNlN64A", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/TF%202.12", "name": "TF 2.12", "color": "c5def5", "default": false, "description": "For issues related to Tensorflow 2.12" } ]
closed
false
{ "login": "SuryanarayanaY", "id": 116063290, "node_id": "U_kgDOBur8Og", "avatar_url": "https://avatars.githubusercontent.com/u/116063290?v=4", "gravatar_id": "", "url": "https://api.github.com/users/SuryanarayanaY", "html_url": "https://github.com/SuryanarayanaY", "followers_url": "https://api.github.com/users/SuryanarayanaY/followers", "following_url": "https://api.github.com/users/SuryanarayanaY/following{/other_user}", "gists_url": "https://api.github.com/users/SuryanarayanaY/gists{/gist_id}", "starred_url": "https://api.github.com/users/SuryanarayanaY/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/SuryanarayanaY/subscriptions", "organizations_url": "https://api.github.com/users/SuryanarayanaY/orgs", "repos_url": "https://api.github.com/users/SuryanarayanaY/repos", "events_url": "https://api.github.com/users/SuryanarayanaY/events{/privacy}", "received_events_url": "https://api.github.com/users/SuryanarayanaY/received_events", "type": "User", "site_admin": false }
[ { "login": "SuryanarayanaY", "id": 116063290, "node_id": "U_kgDOBur8Og", "avatar_url": "https://avatars.githubusercontent.com/u/116063290?v=4", "gravatar_id": "", "url": "https://api.github.com/users/SuryanarayanaY", "html_url": "https://github.com/SuryanarayanaY", "followers_url": "https://api.github.com/users/SuryanarayanaY/followers", "following_url": "https://api.github.com/users/SuryanarayanaY/following{/other_user}", "gists_url": "https://api.github.com/users/SuryanarayanaY/gists{/gist_id}", "starred_url": "https://api.github.com/users/SuryanarayanaY/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/SuryanarayanaY/subscriptions", "organizations_url": "https://api.github.com/users/SuryanarayanaY/orgs", "repos_url": "https://api.github.com/users/SuryanarayanaY/repos", "events_url": "https://api.github.com/users/SuryanarayanaY/events{/privacy}", "received_events_url": "https://api.github.com/users/SuryanarayanaY/received_events", "type": "User", "site_admin": false } ]
null
[ "@SuryanarayanaY \r\nI was able to reproduce the issue on Colab using tf 2.12 and tf-nightly. Please find the gist of [2.12](https://colab.research.google.com/gist/tiruk007/d6c87adf711369429ae38ead62a7d322/untitled182.ipynb) and [tf-nightly](https://colab.research.google.com/gist/tiruk007/9f02ac71d52e640f864f0736c59fed97/tf-nightly.ipynb#scrollTo=Az7CQKKwobxM) for reference.\r\n\r\nThank you !", "Hi @shijy16 ,\r\n\r\nThe issue got resolved now with tf-nightly(2.14.0-dev20230514) and now TF is successfully able to raise the intended Error.\r\nPlease refer to attached [gist](https://colab.research.google.com/gist/SuryanarayanaY/11f2a25b393d2532bf781b08b3849ff6/60278.ipynb).\r\n\r\nPlease check and confirm and let us know if we can close the issue as it resolved now.\r\n\r\nThanks!", "This issue is stale because it has been open for 7 days with no activity. It will be closed if no further activity occurs. Thank you.", "This issue was closed because it has been inactive for 7 days since being marked as stale. Please reopen if you'd like to work on this further.", "Are you satisfied with the resolution of your issue?\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=Yes&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/60278\">Yes</a>\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=No&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/60278\">No</a>\n" ]
2023-04-09T06:07:44
2023-05-30T01:58:53
2023-05-30T01:58:51
NONE
null
null
null
<details><summary>Click to expand!</summary> ### Issue Type Bug ### Have you reproduced the bug with TF nightly? Yes ### Source binary ### Tensorflow Version 2.13.0-dev20230406 ### Custom Code Yes ### OS Platform and Distribution Linux Ubuntu 20.04 ### Mobile device _No response_ ### Python version 3.10 ### Bazel version _No response_ ### GCC/Compiler version _No response_ ### CUDA/cuDNN version CUDA 11.8 ### GPU model and memory _No response_ ### Current Behaviour? ```shell The following code can trigger a crash in `tf.raw_ops.MatrixSolve` due to check-fail(multiply overflow) in the latest version of TensorFlow. ``` ### Standalone code to reproduce the issue ```shell import tensorflow as tf with tf.device("CPU"): adjoint = False matrix = tf.random.uniform([0, 3, 15, 7847250026211090813, 11], dtype=tf.float64, minval=-1024, maxval=1024) rhs = tf.random.uniform([11], dtype=tf.float64, minval=-1024, maxval=1024) res = tf.raw_ops.MatrixSolve( adjoint=adjoint, matrix=matrix, rhs=rhs, ) ``` ### Relevant log output ```shell 2023-04-09 14:04:15.420939: I tensorflow/core/util/port.cc:110] oneDNN custom operations are on. You may see slightly different numerical results due to floating-point round-off errors from different computation orders. To turn them off, set the environment variable `TF_ENABLE_ONEDNN_OPTS=0`. 2023-04-09 14:04:15.468322: I tensorflow/core/platform/cpu_feature_guard.cc:182] This TensorFlow binary is optimized to use available CPU instructions in performance-critical operations. To enable the following instructions: AVX2 AVX512F AVX512_VNNI FMA, in other operations, rebuild TensorFlow with the appropriate compiler flags. 2023-04-09 14:04:16.265727: W tensorflow/compiler/tf2tensorrt/utils/py_utils.cc:38] TF-TRT Warning: Could not find TensorRT 2023-04-09 14:04:17.807591: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1638] Created device /job:localhost/replica:0/task:0/device:GPU:0 with 14561 MB memory: -> device: 0, name: Tesla V100-PCIE-16GB, pci bus id: 0000:2f:00.0, compute capability: 7.0 2023-04-09 14:04:17.844083: F tensorflow/core/framework/tensor_shape.cc:201] Non-OK-status: InitDims(dim_sizes) status: INVALID_ARGUMENT: Encountered overflow when multiplying 7847250026211090813 with 11, result: -1 Aborted (core dumped) ``` </details>
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/60278/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/60278/timeline
null
completed
false
https://api.github.com/repos/tensorflow/tensorflow/issues/60277
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/60277/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/60277/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/60277/events
https://github.com/tensorflow/tensorflow/issues/60277
1,659,763,202
I_kwDOArmXAs5i7foC
60,277
A check fail can be triggered in TridiagonalMatMul
{ "login": "shijy16", "id": 31403391, "node_id": "MDQ6VXNlcjMxNDAzMzkx", "avatar_url": "https://avatars.githubusercontent.com/u/31403391?v=4", "gravatar_id": "", "url": "https://api.github.com/users/shijy16", "html_url": "https://github.com/shijy16", "followers_url": "https://api.github.com/users/shijy16/followers", "following_url": "https://api.github.com/users/shijy16/following{/other_user}", "gists_url": "https://api.github.com/users/shijy16/gists{/gist_id}", "starred_url": "https://api.github.com/users/shijy16/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/shijy16/subscriptions", "organizations_url": "https://api.github.com/users/shijy16/orgs", "repos_url": "https://api.github.com/users/shijy16/repos", "events_url": "https://api.github.com/users/shijy16/events{/privacy}", "received_events_url": "https://api.github.com/users/shijy16/received_events", "type": "User", "site_admin": false }
[ { "id": 386191887, "node_id": "MDU6TGFiZWwzODYxOTE4ODc=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/stat:awaiting%20response", "name": "stat:awaiting response", "color": "f4b400", "default": false, "description": "Status - Awaiting response from author" }, { "id": 473172988, "node_id": "MDU6TGFiZWw0NzMxNzI5ODg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/type:bug", "name": "type:bug", "color": "159b2e", "default": false, "description": "Bug" }, { "id": 474725938, "node_id": "MDU6TGFiZWw0NzQ3MjU5Mzg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/stale", "name": "stale", "color": "d4c5f9", "default": false, "description": "This label marks the issue/pr stale - to be closed automatically if no activity" }, { "id": 1097547147, "node_id": "MDU6TGFiZWwxMDk3NTQ3MTQ3", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/comp:ops", "name": "comp:ops", "color": "0052cc", "default": false, "description": "OPs related issues" }, { "id": 5206407904, "node_id": "LA_kwDOArmXAs8AAAABNlN64A", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/TF%202.12", "name": "TF 2.12", "color": "c5def5", "default": false, "description": "For issues related to Tensorflow 2.12" } ]
closed
false
{ "login": "SuryanarayanaY", "id": 116063290, "node_id": "U_kgDOBur8Og", "avatar_url": "https://avatars.githubusercontent.com/u/116063290?v=4", "gravatar_id": "", "url": "https://api.github.com/users/SuryanarayanaY", "html_url": "https://github.com/SuryanarayanaY", "followers_url": "https://api.github.com/users/SuryanarayanaY/followers", "following_url": "https://api.github.com/users/SuryanarayanaY/following{/other_user}", "gists_url": "https://api.github.com/users/SuryanarayanaY/gists{/gist_id}", "starred_url": "https://api.github.com/users/SuryanarayanaY/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/SuryanarayanaY/subscriptions", "organizations_url": "https://api.github.com/users/SuryanarayanaY/orgs", "repos_url": "https://api.github.com/users/SuryanarayanaY/repos", "events_url": "https://api.github.com/users/SuryanarayanaY/events{/privacy}", "received_events_url": "https://api.github.com/users/SuryanarayanaY/received_events", "type": "User", "site_admin": false }
[ { "login": "SuryanarayanaY", "id": 116063290, "node_id": "U_kgDOBur8Og", "avatar_url": "https://avatars.githubusercontent.com/u/116063290?v=4", "gravatar_id": "", "url": "https://api.github.com/users/SuryanarayanaY", "html_url": "https://github.com/SuryanarayanaY", "followers_url": "https://api.github.com/users/SuryanarayanaY/followers", "following_url": "https://api.github.com/users/SuryanarayanaY/following{/other_user}", "gists_url": "https://api.github.com/users/SuryanarayanaY/gists{/gist_id}", "starred_url": "https://api.github.com/users/SuryanarayanaY/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/SuryanarayanaY/subscriptions", "organizations_url": "https://api.github.com/users/SuryanarayanaY/orgs", "repos_url": "https://api.github.com/users/SuryanarayanaY/repos", "events_url": "https://api.github.com/users/SuryanarayanaY/events{/privacy}", "received_events_url": "https://api.github.com/users/SuryanarayanaY/received_events", "type": "User", "site_admin": false } ]
null
[ "@sachinprasadhs \r\nI was able to reproduce the issue on Colab using TF v2.11 and tf-nightly. Please find the gist of [2.12](https://colab.research.google.com/gist/tiruk007/f1f72fe0b887bddd0598f90dabab5da2/untitled185.ipynb) and [tf-nightly]( https://colab.research.google.com/gist/tiruk007/bd93c0da07e5ae4f8221d5664f718f53/untitled186.ipynb)for reference.\r\n\r\nThank you !", "This should not be a real issue. The check failure is an overflow due to \r\n\r\n```py\r\n superdiag = tf.random.uniform([5, 13, 5, 0, 6291163412844499803, 7], dtype=tf.float64, minval=-1024, maxval=1024)\r\n```\r\n\r\nThis is similar to writing the overflow itself, it won't show up in a real model.", "Hi @shijy16 ,\r\n\r\nThis has been fixed. tested with TF2.16v and found raising an exception rather than check fail. Refer [gist](https://colab.sandbox.google.com/gist/SuryanarayanaY/30733cd9b19b8509065f590c1c747e45/60277_nightly_success.ipynb).", "This issue is stale because it has been open for 7 days with no activity. It will be closed if no further activity occurs. Thank you.", "This issue was closed because it has been inactive for 7 days since being marked as stale. Please reopen if you'd like to work on this further.", "Are you satisfied with the resolution of your issue?\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=Yes&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/60277\">Yes</a>\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=No&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/60277\">No</a>\n" ]
2023-04-09T06:05:40
2024-04-20T01:47:28
2024-04-20T01:47:26
NONE
null
null
null
<details><summary>Click to expand!</summary> ### Issue Type Bug ### Have you reproduced the bug with TF nightly? Yes ### Source binary ### Tensorflow Version 2.13.0-dev20230406 ### Custom Code No ### OS Platform and Distribution Linux Ubuntu 20.04 ### Mobile device _No response_ ### Python version 3.10 ### Bazel version _No response_ ### GCC/Compiler version _No response_ ### CUDA/cuDNN version CUDA 11.8 ### GPU model and memory _No response_ ### Current Behaviour? ```shell The following code can trigger a crash in `tf.raw_ops.TridiagonalMatMul` due to check-fail(multiply overflow) in the latest version of TensorFlow. ``` ### Standalone code to reproduce the issue ```shell import tensorflow as tf with tf.device("CPU"): superdiag = tf.random.uniform([5, 13, 5, 0, 6291163412844499803, 7], dtype=tf.float64, minval=-1024, maxval=1024) maindiag = tf.random.uniform([], dtype=tf.float64, minval=-1024, maxval=1024) subdiag = tf.random.uniform([9, 3, 3], dtype=tf.float64, minval=-1024, maxval=1024) rhs = tf.random.uniform([0, 3, 2, 8, 12, 8], dtype=tf.float64, minval=-1024, maxval=1024) res = tf.raw_ops.TridiagonalMatMul( superdiag=superdiag, maindiag=maindiag, subdiag=subdiag, rhs=rhs, ) ``` ### Relevant log output ```shell 2023-04-09 14:03:29.795879: I tensorflow/core/util/port.cc:110] oneDNN custom operations are on. You may see slightly different numerical results due to floating-point round-off errors from different computation orders. To turn them off, set the environment variable `TF_ENABLE_ONEDNN_OPTS=0`. 2023-04-09 14:03:29.841868: I tensorflow/core/platform/cpu_feature_guard.cc:182] This TensorFlow binary is optimized to use available CPU instructions in performance-critical operations. To enable the following instructions: AVX2 AVX512F AVX512_VNNI FMA, in other operations, rebuild TensorFlow with the appropriate compiler flags. 2023-04-09 14:03:30.668006: W tensorflow/compiler/tf2tensorrt/utils/py_utils.cc:38] TF-TRT Warning: Could not find TensorRT 2023-04-09 14:03:32.219934: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1638] Created device /job:localhost/replica:0/task:0/device:GPU:0 with 14561 MB memory: -> device: 0, name: Tesla V100-PCIE-16GB, pci bus id: 0000:2f:00.0, compute capability: 7.0 2023-04-09 14:03:32.257496: F tensorflow/core/framework/tensor_shape.cc:201] Non-OK-status: InitDims(dim_sizes) status: INVALID_ARGUMENT: Encountered overflow when multiplying 6291163412844499803 with 7, result: -1 Aborted (core dumped) ``` </details>
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/60277/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/60277/timeline
null
completed
false
https://api.github.com/repos/tensorflow/tensorflow/issues/60276
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/60276/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/60276/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/60276/events
https://github.com/tensorflow/tensorflow/issues/60276
1,659,762,205
I_kwDOArmXAs5i7fYd
60,276
A check fail can be triggered in Gather
{ "login": "shijy16", "id": 31403391, "node_id": "MDQ6VXNlcjMxNDAzMzkx", "avatar_url": "https://avatars.githubusercontent.com/u/31403391?v=4", "gravatar_id": "", "url": "https://api.github.com/users/shijy16", "html_url": "https://github.com/shijy16", "followers_url": "https://api.github.com/users/shijy16/followers", "following_url": "https://api.github.com/users/shijy16/following{/other_user}", "gists_url": "https://api.github.com/users/shijy16/gists{/gist_id}", "starred_url": "https://api.github.com/users/shijy16/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/shijy16/subscriptions", "organizations_url": "https://api.github.com/users/shijy16/orgs", "repos_url": "https://api.github.com/users/shijy16/repos", "events_url": "https://api.github.com/users/shijy16/events{/privacy}", "received_events_url": "https://api.github.com/users/shijy16/received_events", "type": "User", "site_admin": false }
[ { "id": 386191887, "node_id": "MDU6TGFiZWwzODYxOTE4ODc=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/stat:awaiting%20response", "name": "stat:awaiting response", "color": "f4b400", "default": false, "description": "Status - Awaiting response from author" }, { "id": 473172988, "node_id": "MDU6TGFiZWw0NzMxNzI5ODg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/type:bug", "name": "type:bug", "color": "159b2e", "default": false, "description": "Bug" }, { "id": 474725938, "node_id": "MDU6TGFiZWw0NzQ3MjU5Mzg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/stale", "name": "stale", "color": "d4c5f9", "default": false, "description": "This label marks the issue/pr stale - to be closed automatically if no activity" }, { "id": 1097547147, "node_id": "MDU6TGFiZWwxMDk3NTQ3MTQ3", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/comp:ops", "name": "comp:ops", "color": "0052cc", "default": false, "description": "OPs related issues" }, { "id": 5206407904, "node_id": "LA_kwDOArmXAs8AAAABNlN64A", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/TF%202.12", "name": "TF 2.12", "color": "c5def5", "default": false, "description": "For issues related to Tensorflow 2.12" } ]
closed
false
{ "login": "SuryanarayanaY", "id": 116063290, "node_id": "U_kgDOBur8Og", "avatar_url": "https://avatars.githubusercontent.com/u/116063290?v=4", "gravatar_id": "", "url": "https://api.github.com/users/SuryanarayanaY", "html_url": "https://github.com/SuryanarayanaY", "followers_url": "https://api.github.com/users/SuryanarayanaY/followers", "following_url": "https://api.github.com/users/SuryanarayanaY/following{/other_user}", "gists_url": "https://api.github.com/users/SuryanarayanaY/gists{/gist_id}", "starred_url": "https://api.github.com/users/SuryanarayanaY/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/SuryanarayanaY/subscriptions", "organizations_url": "https://api.github.com/users/SuryanarayanaY/orgs", "repos_url": "https://api.github.com/users/SuryanarayanaY/repos", "events_url": "https://api.github.com/users/SuryanarayanaY/events{/privacy}", "received_events_url": "https://api.github.com/users/SuryanarayanaY/received_events", "type": "User", "site_admin": false }
[ { "login": "SuryanarayanaY", "id": 116063290, "node_id": "U_kgDOBur8Og", "avatar_url": "https://avatars.githubusercontent.com/u/116063290?v=4", "gravatar_id": "", "url": "https://api.github.com/users/SuryanarayanaY", "html_url": "https://github.com/SuryanarayanaY", "followers_url": "https://api.github.com/users/SuryanarayanaY/followers", "following_url": "https://api.github.com/users/SuryanarayanaY/following{/other_user}", "gists_url": "https://api.github.com/users/SuryanarayanaY/gists{/gist_id}", "starred_url": "https://api.github.com/users/SuryanarayanaY/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/SuryanarayanaY/subscriptions", "organizations_url": "https://api.github.com/users/SuryanarayanaY/orgs", "repos_url": "https://api.github.com/users/SuryanarayanaY/repos", "events_url": "https://api.github.com/users/SuryanarayanaY/events{/privacy}", "received_events_url": "https://api.github.com/users/SuryanarayanaY/received_events", "type": "User", "site_admin": false } ]
null
[ "@shijy16 This ticket is related to vulnerabilities. Please consult https://github.com/tensorflow/tensorflow/blob/master/SECURITY.md . Please refer to [this](https://github.com/tensorflow/tensorflow/issues/60197#issuecomment-1496337927) comment as well. Thank you!\r\n\r\n", "@sushreebarsa \r\n\r\nHi, thank you. I will report this issue to OSS VRP.\r\n\r\nBut I am not very clear about the boundary between vulnerability and bug. As stated in the security.md:\r\n````\r\nIf an assertion failure only leads to program termination and no other exploits, we will no longer consider assertion failures (e.g., CHECK-fails) as vulnerabilities.\r\n````\r\nThe check-fails are not regarded as vulnerabilities. Why is this one related to vulnerabilities? ", "@sushreebarsa \r\nHi, OSS VRP has replied that this issue is not severe enough to be tracked as a security bug.", "Hi @shijy16 ,\r\n\r\nThis has been fixed at tf-nightly as per [gist](https://colab.sandbox.google.com/gist/SuryanarayanaY/fd19bf2247cf811eb947cb2f4ac80cce/60276.ipynb). Now it's raising exception.\r\n", "This issue is stale because it has been open for 7 days with no activity. It will be closed if no further activity occurs. Thank you.", "This issue was closed because it has been inactive for 7 days since being marked as stale. Please reopen if you'd like to work on this further.", "Are you satisfied with the resolution of your issue?\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=Yes&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/60276\">Yes</a>\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=No&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/60276\">No</a>\n" ]
2023-04-09T06:01:12
2024-03-23T01:47:00
2024-03-23T01:46:57
NONE
null
null
null
<details><summary>Click to expand!</summary> ### Issue Type Bug ### Have you reproduced the bug with TF nightly? Yes ### Source binary ### Tensorflow Version 2.13.0-dev20230406 ### Custom Code Yes ### OS Platform and Distribution Linux Ubuntu 20.04 ### Mobile device _No response_ ### Python version 3.10 ### Bazel version _No response_ ### GCC/Compiler version _No response_ ### CUDA/cuDNN version CUDA 11.8 ### GPU model and memory _No response_ ### Current Behaviour? ```shell The following code can trigger a crash in `tf.raw_ops.Gather` due to check-fail in the latest version of TensorFlow. ``` ### Standalone code to reproduce the issue ```shell import tensorflow as tf with tf.device("GPU:0"): validate_indices = False params = tf.saturate_cast(tf.random.uniform([13, 15, 7, 13, 14], minval=-1024, maxval=1024, dtype=tf.int64), dtype=tf.half) indices = tf.saturate_cast(tf.random.uniform([11, 12, 6, 15, 11, 3], minval=-1024, maxval=1024, dtype=tf.int64), dtype=tf.int64) res = tf.raw_ops.Gather( validate_indices=validate_indices, params=params, indices=indices, ) ``` ### Relevant log output ```shell 2023-04-09 13:58:03.392638: I tensorflow/core/util/port.cc:110] oneDNN custom operations are on. You may see slightly different numerical results due to floating-point round-off errors from different computation orders. To turn them off, set the environment variable `TF_ENABLE_ONEDNN_OPTS=0`. 2023-04-09 13:58:03.438587: I tensorflow/core/platform/cpu_feature_guard.cc:182] This TensorFlow binary is optimized to use available CPU instructions in performance-critical operations. To enable the following instructions: AVX2 AVX512F AVX512_VNNI FMA, in other operations, rebuild TensorFlow with the appropriate compiler flags. 2023-04-09 13:58:04.254390: W tensorflow/compiler/tf2tensorrt/utils/py_utils.cc:38] TF-TRT Warning: Could not find TensorRT 2023-04-09 13:58:05.786420: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1638] Created device /job:localhost/replica:0/task:0/device:GPU:0 with 14561 MB memory: -> device: 0, name: Tesla V100-PCIE-16GB, pci bus id: 0000:2f:00.0, compute capability: 7.0 2023-04-09 13:58:06.047489: F ./tensorflow/core/util/gpu_launch_config.h:160] Check failed: work_element_count >= 0 (0 vs. -549025096) Aborted (core dumped) ``` </details>
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/60276/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/60276/timeline
null
completed
false
https://api.github.com/repos/tensorflow/tensorflow/issues/60275
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/60275/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/60275/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/60275/events
https://github.com/tensorflow/tensorflow/issues/60275
1,659,761,078
I_kwDOArmXAs5i7fG2
60,275
A check fail can be triggered in MatrixLogarithm
{ "login": "shijy16", "id": 31403391, "node_id": "MDQ6VXNlcjMxNDAzMzkx", "avatar_url": "https://avatars.githubusercontent.com/u/31403391?v=4", "gravatar_id": "", "url": "https://api.github.com/users/shijy16", "html_url": "https://github.com/shijy16", "followers_url": "https://api.github.com/users/shijy16/followers", "following_url": "https://api.github.com/users/shijy16/following{/other_user}", "gists_url": "https://api.github.com/users/shijy16/gists{/gist_id}", "starred_url": "https://api.github.com/users/shijy16/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/shijy16/subscriptions", "organizations_url": "https://api.github.com/users/shijy16/orgs", "repos_url": "https://api.github.com/users/shijy16/repos", "events_url": "https://api.github.com/users/shijy16/events{/privacy}", "received_events_url": "https://api.github.com/users/shijy16/received_events", "type": "User", "site_admin": false }
[ { "id": 386191887, "node_id": "MDU6TGFiZWwzODYxOTE4ODc=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/stat:awaiting%20response", "name": "stat:awaiting response", "color": "f4b400", "default": false, "description": "Status - Awaiting response from author" }, { "id": 473172988, "node_id": "MDU6TGFiZWw0NzMxNzI5ODg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/type:bug", "name": "type:bug", "color": "159b2e", "default": false, "description": "Bug" }, { "id": 474725938, "node_id": "MDU6TGFiZWw0NzQ3MjU5Mzg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/stale", "name": "stale", "color": "d4c5f9", "default": false, "description": "This label marks the issue/pr stale - to be closed automatically if no activity" }, { "id": 1097547147, "node_id": "MDU6TGFiZWwxMDk3NTQ3MTQ3", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/comp:ops", "name": "comp:ops", "color": "0052cc", "default": false, "description": "OPs related issues" }, { "id": 5206407904, "node_id": "LA_kwDOArmXAs8AAAABNlN64A", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/TF%202.12", "name": "TF 2.12", "color": "c5def5", "default": false, "description": "For issues related to Tensorflow 2.12" } ]
closed
false
{ "login": "SuryanarayanaY", "id": 116063290, "node_id": "U_kgDOBur8Og", "avatar_url": "https://avatars.githubusercontent.com/u/116063290?v=4", "gravatar_id": "", "url": "https://api.github.com/users/SuryanarayanaY", "html_url": "https://github.com/SuryanarayanaY", "followers_url": "https://api.github.com/users/SuryanarayanaY/followers", "following_url": "https://api.github.com/users/SuryanarayanaY/following{/other_user}", "gists_url": "https://api.github.com/users/SuryanarayanaY/gists{/gist_id}", "starred_url": "https://api.github.com/users/SuryanarayanaY/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/SuryanarayanaY/subscriptions", "organizations_url": "https://api.github.com/users/SuryanarayanaY/orgs", "repos_url": "https://api.github.com/users/SuryanarayanaY/repos", "events_url": "https://api.github.com/users/SuryanarayanaY/events{/privacy}", "received_events_url": "https://api.github.com/users/SuryanarayanaY/received_events", "type": "User", "site_admin": false }
[ { "login": "SuryanarayanaY", "id": 116063290, "node_id": "U_kgDOBur8Og", "avatar_url": "https://avatars.githubusercontent.com/u/116063290?v=4", "gravatar_id": "", "url": "https://api.github.com/users/SuryanarayanaY", "html_url": "https://github.com/SuryanarayanaY", "followers_url": "https://api.github.com/users/SuryanarayanaY/followers", "following_url": "https://api.github.com/users/SuryanarayanaY/following{/other_user}", "gists_url": "https://api.github.com/users/SuryanarayanaY/gists{/gist_id}", "starred_url": "https://api.github.com/users/SuryanarayanaY/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/SuryanarayanaY/subscriptions", "organizations_url": "https://api.github.com/users/SuryanarayanaY/orgs", "repos_url": "https://api.github.com/users/SuryanarayanaY/repos", "events_url": "https://api.github.com/users/SuryanarayanaY/events{/privacy}", "received_events_url": "https://api.github.com/users/SuryanarayanaY/received_events", "type": "User", "site_admin": false } ]
null
[ "@sachinprasadhs,\r\nI was able to reproduce the issue on tensorflow v2.12 and nightly. Kindly find the gist and the screen shot for the reference.\r\n\r\n```\r\n(tf) tilakrayal@tilak-cpu-instance:~$ python3 mkjfgkkll.py\r\n2023-04-10 09:16:56.384974: I tensorflow/tsl/cuda/cudart_stub.cc:28] Could not find cuda drivers on your machine, GPU will not be used.\r\n2023-04-10 09:16:56.956235: I tensorflow/tsl/cuda/cudart_stub.cc:28] Could not find cuda drivers on your machine, GPU will not be used.\r\n2023-04-10 09:16:56.959832: I tensorflow/core/platform/cpu_feature_guard.cc:182] This TensorFlow binary is optimized to use available CPU instructions in performance-critical operations.\r\nTo enable the following instructions: AVX2 FMA, in other operations, rebuild TensorFlow with the appropriate compiler flags.\r\n2023-04-10 09:16:59.274496: W tensorflow/compiler/tf2tensorrt/utils/py_utils.cc:38] TF-TRT Warning: Could not find TensorRT\r\n2023-04-10 09:17:02.144480: F tensorflow/core/framework/tensor_shape.cc:201] Non-OK-status: InitDims(dim_sizes) status: INVALID_ARGUMENT: Encountered overflow when multiplying 13 with 8440370290997831992, result: -1\r\nAborted\r\n```", "Hi @shijy16 \r\nThis has been fixed. tested with TF2.16v and found raising an exception rather than check fail.Please refer [gist](https://colab.sandbox.google.com/gist/SuryanarayanaY/dcc83ff235a447e466eac66a9310966d/60275_nightly_success.ipynb).\r\nThanks!", "This issue is stale because it has been open for 7 days with no activity. It will be closed if no further activity occurs. Thank you.", "This issue was closed because it has been inactive for 7 days since being marked as stale. Please reopen if you'd like to work on this further.", "Are you satisfied with the resolution of your issue?\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=Yes&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/60275\">Yes</a>\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=No&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/60275\">No</a>\n" ]
2023-04-09T05:57:00
2024-04-20T01:47:32
2024-04-20T01:47:27
NONE
null
null
null
<details><summary>Click to expand!</summary> ### Issue Type Bug ### Have you reproduced the bug with TF nightly? Yes ### Source binary ### Tensorflow Version 2.13.0-dev20230406 ### Custom Code No ### OS Platform and Distribution Linux Ubuntu 20.04 ### Mobile device _No response_ ### Python version 3.10 ### Bazel version _No response_ ### GCC/Compiler version _No response_ ### CUDA/cuDNN version CUDA 11.8 ### GPU model and memory _No response_ ### Current Behaviour? ```shell The following code can trigger a crash in `tf.raw_ops.MatrixLogarithm` due to check-fail in the latest version of TensorFlow. ``` ### Standalone code to reproduce the issue ```shell import tensorflow as tf with tf.device("CPU"): input = tf.complex(tf.random.uniform([0, 9, 13, 15, 13, 8440370290997831992], dtype=tf.float32, minval=-1024, maxval=1024),tf.random.uniform([0, 9, 13, 15, 13, 8440370290997831992], dtype=tf.float32, minval=-1024, maxval=1024)) res = tf.raw_ops.MatrixLogarithm( input=input, ) ``` ### Relevant log output ```shell 2023-04-09 13:53:45.787590: I tensorflow/core/util/port.cc:110] oneDNN custom operations are on. You may see slightly different numerical results due to floating-point round-off errors from different computation orders. To turn them off, set the environment variable `TF_ENABLE_ONEDNN_OPTS=0`. 2023-04-09 13:53:45.833409: I tensorflow/core/platform/cpu_feature_guard.cc:182] This TensorFlow binary is optimized to use available CPU instructions in performance-critical operations. To enable the following instructions: AVX2 AVX512F AVX512_VNNI FMA, in other operations, rebuild TensorFlow with the appropriate compiler flags. 2023-04-09 13:53:46.651440: W tensorflow/compiler/tf2tensorrt/utils/py_utils.cc:38] TF-TRT Warning: Could not find TensorRT 2023-04-09 13:53:48.212756: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1638] Created device /job:localhost/replica:0/task:0/device:GPU:0 with 14561 MB memory: -> device: 0, name: Tesla V100-PCIE-16GB, pci bus id: 0000:2f:00.0, compute capability: 7.0 2023-04-09 13:53:48.249022: F tensorflow/core/framework/tensor_shape.cc:201] Non-OK-status: InitDims(dim_sizes) status: INVALID_ARGUMENT: Encountered overflow when multiplying 13 with 8440370290997831992, result: -1 Aborted (core dumped) ``` </details>
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/60275/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/60275/timeline
null
completed
false
https://api.github.com/repos/tensorflow/tensorflow/issues/60274
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/60274/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/60274/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/60274/events
https://github.com/tensorflow/tensorflow/issues/60274
1,659,760,555
I_kwDOArmXAs5i7e-r
60,274
A check fail can be triggered in Cholesky
{ "login": "shijy16", "id": 31403391, "node_id": "MDQ6VXNlcjMxNDAzMzkx", "avatar_url": "https://avatars.githubusercontent.com/u/31403391?v=4", "gravatar_id": "", "url": "https://api.github.com/users/shijy16", "html_url": "https://github.com/shijy16", "followers_url": "https://api.github.com/users/shijy16/followers", "following_url": "https://api.github.com/users/shijy16/following{/other_user}", "gists_url": "https://api.github.com/users/shijy16/gists{/gist_id}", "starred_url": "https://api.github.com/users/shijy16/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/shijy16/subscriptions", "organizations_url": "https://api.github.com/users/shijy16/orgs", "repos_url": "https://api.github.com/users/shijy16/repos", "events_url": "https://api.github.com/users/shijy16/events{/privacy}", "received_events_url": "https://api.github.com/users/shijy16/received_events", "type": "User", "site_admin": false }
[ { "id": 386191887, "node_id": "MDU6TGFiZWwzODYxOTE4ODc=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/stat:awaiting%20response", "name": "stat:awaiting response", "color": "f4b400", "default": false, "description": "Status - Awaiting response from author" }, { "id": 473172988, "node_id": "MDU6TGFiZWw0NzMxNzI5ODg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/type:bug", "name": "type:bug", "color": "159b2e", "default": false, "description": "Bug" }, { "id": 474725938, "node_id": "MDU6TGFiZWw0NzQ3MjU5Mzg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/stale", "name": "stale", "color": "d4c5f9", "default": false, "description": "This label marks the issue/pr stale - to be closed automatically if no activity" }, { "id": 1097547147, "node_id": "MDU6TGFiZWwxMDk3NTQ3MTQ3", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/comp:ops", "name": "comp:ops", "color": "0052cc", "default": false, "description": "OPs related issues" }, { "id": 5206407904, "node_id": "LA_kwDOArmXAs8AAAABNlN64A", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/TF%202.12", "name": "TF 2.12", "color": "c5def5", "default": false, "description": "For issues related to Tensorflow 2.12" } ]
closed
false
{ "login": "SuryanarayanaY", "id": 116063290, "node_id": "U_kgDOBur8Og", "avatar_url": "https://avatars.githubusercontent.com/u/116063290?v=4", "gravatar_id": "", "url": "https://api.github.com/users/SuryanarayanaY", "html_url": "https://github.com/SuryanarayanaY", "followers_url": "https://api.github.com/users/SuryanarayanaY/followers", "following_url": "https://api.github.com/users/SuryanarayanaY/following{/other_user}", "gists_url": "https://api.github.com/users/SuryanarayanaY/gists{/gist_id}", "starred_url": "https://api.github.com/users/SuryanarayanaY/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/SuryanarayanaY/subscriptions", "organizations_url": "https://api.github.com/users/SuryanarayanaY/orgs", "repos_url": "https://api.github.com/users/SuryanarayanaY/repos", "events_url": "https://api.github.com/users/SuryanarayanaY/events{/privacy}", "received_events_url": "https://api.github.com/users/SuryanarayanaY/received_events", "type": "User", "site_admin": false }
[ { "login": "SuryanarayanaY", "id": 116063290, "node_id": "U_kgDOBur8Og", "avatar_url": "https://avatars.githubusercontent.com/u/116063290?v=4", "gravatar_id": "", "url": "https://api.github.com/users/SuryanarayanaY", "html_url": "https://github.com/SuryanarayanaY", "followers_url": "https://api.github.com/users/SuryanarayanaY/followers", "following_url": "https://api.github.com/users/SuryanarayanaY/following{/other_user}", "gists_url": "https://api.github.com/users/SuryanarayanaY/gists{/gist_id}", "starred_url": "https://api.github.com/users/SuryanarayanaY/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/SuryanarayanaY/subscriptions", "organizations_url": "https://api.github.com/users/SuryanarayanaY/orgs", "repos_url": "https://api.github.com/users/SuryanarayanaY/repos", "events_url": "https://api.github.com/users/SuryanarayanaY/events{/privacy}", "received_events_url": "https://api.github.com/users/SuryanarayanaY/received_events", "type": "User", "site_admin": false } ]
null
[ " The gradient computation on GPU is faster for large matrices but not for large batch dimensions when the submatrices are small. In this case it might be faster to use the cpu \r\n\r\n> `", "@SuryanarayanaY \r\nI was able to reproduce the issue on Colab using tf 2.12 and tf-nightly. Please find the gist of [2.12](https://colab.research.google.com/gist/tiruk007/a8ac5acfde8ceff7c0b28fc5e8d1941f/untitled181.ipynb) and [tf-nightly](https://colab.research.google.com/gist/tiruk007/28ba594db7ef2ef77fab1ab2521fa754/untitled182.ipynb) for reference.\r\n\r\nThank you!", "Hi @shijy16 ,\r\n\r\nThe issue got resolved now with tf-nightly(2.14.0-dev20230514) and now TF is successfully able to raise the intended Error.\r\nPlease refer to attached [gist](https://colab.research.google.com/gist/SuryanarayanaY/b238a78a3b1e85af4cb11013966b39ba/60274.ipynb).\r\n\r\nPlease check and confirm and let us know if we can close the issue as it resolved now.\r\n\r\nThanks!", "This issue is stale because it has been open for 7 days with no activity. It will be closed if no further activity occurs. Thank you.", "This issue was closed because it has been inactive for 7 days since being marked as stale. Please reopen if you'd like to work on this further.", "Are you satisfied with the resolution of your issue?\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=Yes&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/60274\">Yes</a>\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=No&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/60274\">No</a>\n" ]
2023-04-09T05:54:19
2023-05-30T01:58:56
2023-05-30T01:58:53
NONE
null
null
null
<details><summary>Click to expand!</summary> ### Issue Type Bug ### Have you reproduced the bug with TF nightly? Yes ### Source binary ### Tensorflow Version 2.13.0-dev20230406 ### Custom Code No ### OS Platform and Distribution Linux Ubuntu 20.04 ### Mobile device _No response_ ### Python version 3.10 ### Bazel version _No response_ ### GCC/Compiler version _No response_ ### CUDA/cuDNN version CUDA 11.8 ### GPU model and memory _No response_ ### Current Behaviour? ```shell The following code can trigger a crash in `tf.raw_ops.Cholesky` due to check-fail in the latest version of TensorFlow. ``` ### Standalone code to reproduce the issue ```shell import tensorflow as tf with tf.device("CPU"): input = tf.complex(tf.random.uniform([6, 1, 0, 11, 5241981715460094077, 8], dtype=tf.float64, minval=-1024, maxval=1024),tf.random.uniform([6, 1, 0, 11, 5241981715460094077, 8], dtype=tf.float64, minval=-1024, maxval=1024)) res = tf.raw_ops.Cholesky( input=input, ) ``` ### Relevant log output ```shell 2023-04-09 13:50:29.887381: I tensorflow/core/util/port.cc:110] oneDNN custom operations are on. You may see slightly different numerical results due to floating-point round-off errors from different computation orders. To turn them off, set the environment variable `TF_ENABLE_ONEDNN_OPTS=0`. 2023-04-09 13:50:29.932917: I tensorflow/core/platform/cpu_feature_guard.cc:182] This TensorFlow binary is optimized to use available CPU instructions in performance-critical operations. To enable the following instructions: AVX2 AVX512F AVX512_VNNI FMA, in other operations, rebuild TensorFlow with the appropriate compiler flags. 2023-04-09 13:50:30.753764: W tensorflow/compiler/tf2tensorrt/utils/py_utils.cc:38] TF-TRT Warning: Could not find TensorRT 2023-04-09 13:50:32.285931: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1638] Created device /job:localhost/replica:0/task:0/device:GPU:0 with 14561 MB memory: -> device: 0, name: Tesla V100-PCIE-16GB, pci bus id: 0000:2f:00.0, compute capability: 7.0 2023-04-09 13:50:32.321965: F tensorflow/core/framework/tensor_shape.cc:201] Non-OK-status: InitDims(dim_sizes) status: INVALID_ARGUMENT: Encountered overflow when multiplying 5241981715460094077 with 8, result: -1 Aborted (core dumped) ``` </details>
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/60274/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/60274/timeline
null
completed
false
https://api.github.com/repos/tensorflow/tensorflow/issues/60273
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/60273/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/60273/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/60273/events
https://github.com/tensorflow/tensorflow/issues/60273
1,659,759,782
I_kwDOArmXAs5i7eym
60,273
A check fail can be triggered in UnicodeDecodeWithOffsets
{ "login": "shijy16", "id": 31403391, "node_id": "MDQ6VXNlcjMxNDAzMzkx", "avatar_url": "https://avatars.githubusercontent.com/u/31403391?v=4", "gravatar_id": "", "url": "https://api.github.com/users/shijy16", "html_url": "https://github.com/shijy16", "followers_url": "https://api.github.com/users/shijy16/followers", "following_url": "https://api.github.com/users/shijy16/following{/other_user}", "gists_url": "https://api.github.com/users/shijy16/gists{/gist_id}", "starred_url": "https://api.github.com/users/shijy16/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/shijy16/subscriptions", "organizations_url": "https://api.github.com/users/shijy16/orgs", "repos_url": "https://api.github.com/users/shijy16/repos", "events_url": "https://api.github.com/users/shijy16/events{/privacy}", "received_events_url": "https://api.github.com/users/shijy16/received_events", "type": "User", "site_admin": false }
[ { "id": 386191887, "node_id": "MDU6TGFiZWwzODYxOTE4ODc=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/stat:awaiting%20response", "name": "stat:awaiting response", "color": "f4b400", "default": false, "description": "Status - Awaiting response from author" }, { "id": 404586594, "node_id": "MDU6TGFiZWw0MDQ1ODY1OTQ=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/stat:awaiting%20tensorflower", "name": "stat:awaiting tensorflower", "color": "f4b400", "default": false, "description": "Status - Awaiting response from tensorflower" }, { "id": 473172988, "node_id": "MDU6TGFiZWw0NzMxNzI5ODg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/type:bug", "name": "type:bug", "color": "159b2e", "default": false, "description": "Bug" }, { "id": 474725938, "node_id": "MDU6TGFiZWw0NzQ3MjU5Mzg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/stale", "name": "stale", "color": "d4c5f9", "default": false, "description": "This label marks the issue/pr stale - to be closed automatically if no activity" }, { "id": 1097547147, "node_id": "MDU6TGFiZWwxMDk3NTQ3MTQ3", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/comp:ops", "name": "comp:ops", "color": "0052cc", "default": false, "description": "OPs related issues" }, { "id": 5206407904, "node_id": "LA_kwDOArmXAs8AAAABNlN64A", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/TF%202.12", "name": "TF 2.12", "color": "c5def5", "default": false, "description": "For issues related to Tensorflow 2.12" } ]
closed
false
{ "login": "tilakrayal", "id": 81610181, "node_id": "MDQ6VXNlcjgxNjEwMTgx", "avatar_url": "https://avatars.githubusercontent.com/u/81610181?v=4", "gravatar_id": "", "url": "https://api.github.com/users/tilakrayal", "html_url": "https://github.com/tilakrayal", "followers_url": "https://api.github.com/users/tilakrayal/followers", "following_url": "https://api.github.com/users/tilakrayal/following{/other_user}", "gists_url": "https://api.github.com/users/tilakrayal/gists{/gist_id}", "starred_url": "https://api.github.com/users/tilakrayal/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/tilakrayal/subscriptions", "organizations_url": "https://api.github.com/users/tilakrayal/orgs", "repos_url": "https://api.github.com/users/tilakrayal/repos", "events_url": "https://api.github.com/users/tilakrayal/events{/privacy}", "received_events_url": "https://api.github.com/users/tilakrayal/received_events", "type": "User", "site_admin": false }
[ { "login": "tilakrayal", "id": 81610181, "node_id": "MDQ6VXNlcjgxNjEwMTgx", "avatar_url": "https://avatars.githubusercontent.com/u/81610181?v=4", "gravatar_id": "", "url": "https://api.github.com/users/tilakrayal", "html_url": "https://github.com/tilakrayal", "followers_url": "https://api.github.com/users/tilakrayal/followers", "following_url": "https://api.github.com/users/tilakrayal/following{/other_user}", "gists_url": "https://api.github.com/users/tilakrayal/gists{/gist_id}", "starred_url": "https://api.github.com/users/tilakrayal/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/tilakrayal/subscriptions", "organizations_url": "https://api.github.com/users/tilakrayal/orgs", "repos_url": "https://api.github.com/users/tilakrayal/repos", "events_url": "https://api.github.com/users/tilakrayal/events{/privacy}", "received_events_url": "https://api.github.com/users/tilakrayal/received_events", "type": "User", "site_admin": false } ]
null
[ "Hi @shijy16, thank you for reporting the issue!\r\nI was able to replicate the issue using tf-nightly(2.13.0-dev20230406). Please find the screenshot below.\r\n![image](https://user-images.githubusercontent.com/98147397/231736730-a6520439-4f32-430e-abcc-e3c224f1da8b.png)\r\n Thank you!", "@shijy16,\r\nTsplits has to be one of the dtype from tf.dtypes.\r\n\r\n`Tsplits | An optional tf.DType from: tf.int32, tf.int64. Defaults to tf.int64.`\r\n\r\nI tried to execute the mentioned code on tf-nightly with alternative work-around and it was executed without any fail or error. Kindly find the gist of it [here](https://colab.research.google.com/gist/tilakrayal/4a38cf2173412697737e43c6140000cb/untitled1679.ipynb). Thank you!", "This issue is stale because it has been open for 7 days with no activity. It will be closed if no further activity occurs. Thank you.", "This issue was closed because it has been inactive for 7 days since being marked as stale. Please reopen if you'd like to work on this further.", "Are you satisfied with the resolution of your issue?\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=Yes&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/60273\">Yes</a>\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=No&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/60273\">No</a>\n" ]
2023-04-09T05:50:27
2024-02-10T01:46:05
2024-02-10T01:46:02
NONE
null
null
null
<details><summary>Click to expand!</summary> ### Issue Type Bug ### Have you reproduced the bug with TF nightly? Yes ### Source binary ### Tensorflow Version 2.13.0-dev20230406 ### Custom Code No ### OS Platform and Distribution Linux Ubuntu 20.04 ### Mobile device _No response_ ### Python version 3.10 ### Bazel version _No response_ ### GCC/Compiler version _No response_ ### CUDA/cuDNN version CUDA 11.8 ### GPU model and memory _No response_ ### Current Behaviour? ```shell The following code can trigger a crash in `tf.raw_ops.UnicodeDecodeWithOffsets` due to check-fail in the latest version of TensorFlow. ``` ### Standalone code to reproduce the issue ```shell import tensorflow as tf import numpy as np with tf.device("GPU:0"): input_encoding = "l9" errors = "strict" replacement_char = 965 replace_control_characters = True Tsplits = tf.int32 input = tf.strings.unicode_encode(np.random.randint(0, 128, size=[2, 15, 16, 1, 6, 18], dtype=np.int32), output_encoding='UTF-8') res = tf.raw_ops.UnicodeDecodeWithOffsets( input_encoding=input_encoding, errors=errors, replacement_char=replacement_char, replace_control_characters=replace_control_characters, Tsplits=Tsplits, input=input, ) ``` ### Relevant log output ```shell 2023-04-09 13:47:10.094296: I tensorflow/core/util/port.cc:110] oneDNN custom operations are on. You may see slightly different numerical results due to floating-point round-off errors from different computation orders. To turn them off, set the environment variable `TF_ENABLE_ONEDNN_OPTS=0`. 2023-04-09 13:47:10.141240: I tensorflow/core/platform/cpu_feature_guard.cc:182] This TensorFlow binary is optimized to use available CPU instructions in performance-critical operations. To enable the following instructions: AVX2 AVX512F AVX512_VNNI FMA, in other operations, rebuild TensorFlow with the appropriate compiler flags. 2023-04-09 13:47:10.947591: W tensorflow/compiler/tf2tensorrt/utils/py_utils.cc:38] TF-TRT Warning: Could not find TensorRT 2023-04-09 13:47:12.490727: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1638] Created device /job:localhost/replica:0/task:0/device:GPU:0 with 14561 MB memory: -> device: 0, name: Tesla V100-PCIE-16GB, pci bus id: 0000:2f:00.0, compute capability: 7.0 2023-04-09 13:47:12.779782: F tensorflow/core/framework/tensor.cc:770] Check failed: dtype() == expected_dtype (9 vs. 3) int32 expected, got int64 Aborted (core dumped) ``` </details>
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/60273/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/60273/timeline
null
completed
false
https://api.github.com/repos/tensorflow/tensorflow/issues/60271
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/60271/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/60271/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/60271/events
https://github.com/tensorflow/tensorflow/issues/60271
1,659,660,764
I_kwDOArmXAs5i7Gnc
60,271
M2 GPU utilization decays from 50% to 10% in non batched inference for huggingface distilbert-base-cased
{ "login": "kechan", "id": 122762, "node_id": "MDQ6VXNlcjEyMjc2Mg==", "avatar_url": "https://avatars.githubusercontent.com/u/122762?v=4", "gravatar_id": "", "url": "https://api.github.com/users/kechan", "html_url": "https://github.com/kechan", "followers_url": "https://api.github.com/users/kechan/followers", "following_url": "https://api.github.com/users/kechan/following{/other_user}", "gists_url": "https://api.github.com/users/kechan/gists{/gist_id}", "starred_url": "https://api.github.com/users/kechan/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kechan/subscriptions", "organizations_url": "https://api.github.com/users/kechan/orgs", "repos_url": "https://api.github.com/users/kechan/repos", "events_url": "https://api.github.com/users/kechan/events{/privacy}", "received_events_url": "https://api.github.com/users/kechan/received_events", "type": "User", "site_admin": false }
[ { "id": 386191887, "node_id": "MDU6TGFiZWwzODYxOTE4ODc=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/stat:awaiting%20response", "name": "stat:awaiting response", "color": "f4b400", "default": false, "description": "Status - Awaiting response from author" }, { "id": 474725938, "node_id": "MDU6TGFiZWw0NzQ3MjU5Mzg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/stale", "name": "stale", "color": "d4c5f9", "default": false, "description": "This label marks the issue/pr stale - to be closed automatically if no activity" }, { "id": 1097545817, "node_id": "MDU6TGFiZWwxMDk3NTQ1ODE3", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/comp:apis", "name": "comp:apis", "color": "0052cc", "default": false, "description": "Highlevel API related issues" }, { "id": 1097547538, "node_id": "MDU6TGFiZWwxMDk3NTQ3NTM4", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/comp:gpu", "name": "comp:gpu", "color": "0052cc", "default": false, "description": "GPU related issues" }, { "id": 1205765054, "node_id": "MDU6TGFiZWwxMjA1NzY1MDU0", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/subtype:macOS", "name": "subtype:macOS", "color": "b619ea", "default": false, "description": "macOS Build/Installation issues" }, { "id": 1463677878, "node_id": "MDU6TGFiZWwxNDYzNjc3ODc4", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/type:performance", "name": "type:performance", "color": "159b2e", "default": false, "description": "Performance Issue" }, { "id": 4032183365, "node_id": "LA_kwDOArmXAs7wVjxF", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/TF%202.9", "name": "TF 2.9", "color": "1CF842", "default": false, "description": "Issues found in the TF 2.9 release (or RCs)" } ]
closed
false
{ "login": "SuryanarayanaY", "id": 116063290, "node_id": "U_kgDOBur8Og", "avatar_url": "https://avatars.githubusercontent.com/u/116063290?v=4", "gravatar_id": "", "url": "https://api.github.com/users/SuryanarayanaY", "html_url": "https://github.com/SuryanarayanaY", "followers_url": "https://api.github.com/users/SuryanarayanaY/followers", "following_url": "https://api.github.com/users/SuryanarayanaY/following{/other_user}", "gists_url": "https://api.github.com/users/SuryanarayanaY/gists{/gist_id}", "starred_url": "https://api.github.com/users/SuryanarayanaY/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/SuryanarayanaY/subscriptions", "organizations_url": "https://api.github.com/users/SuryanarayanaY/orgs", "repos_url": "https://api.github.com/users/SuryanarayanaY/repos", "events_url": "https://api.github.com/users/SuryanarayanaY/events{/privacy}", "received_events_url": "https://api.github.com/users/SuryanarayanaY/received_events", "type": "User", "site_admin": false }
[ { "login": "SuryanarayanaY", "id": 116063290, "node_id": "U_kgDOBur8Og", "avatar_url": "https://avatars.githubusercontent.com/u/116063290?v=4", "gravatar_id": "", "url": "https://api.github.com/users/SuryanarayanaY", "html_url": "https://github.com/SuryanarayanaY", "followers_url": "https://api.github.com/users/SuryanarayanaY/followers", "following_url": "https://api.github.com/users/SuryanarayanaY/following{/other_user}", "gists_url": "https://api.github.com/users/SuryanarayanaY/gists{/gist_id}", "starred_url": "https://api.github.com/users/SuryanarayanaY/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/SuryanarayanaY/subscriptions", "organizations_url": "https://api.github.com/users/SuryanarayanaY/orgs", "repos_url": "https://api.github.com/users/SuryanarayanaY/repos", "events_url": "https://api.github.com/users/SuryanarayanaY/events{/privacy}", "received_events_url": "https://api.github.com/users/SuryanarayanaY/received_events", "type": "User", "site_admin": false } ]
null
[ "More details:\r\n\r\nI found no evidence yet this is a heat throttling issue, 'cos after the huge drop in GPU utilization, other processes will overtake using the GPU.\r\nI wonder what's going on? Is there any profiling tips I can do to help investigate. I am aware I can \"fix\" this by doing batch inferences. (or just use CPU as some may recommend for non batch inference). But seeing this GPU utilization decay is still unsettling, since this can potentially happen for a training session (which is far longer).\r\n\r\nSo I would like to know the root cause. I have experience in TF in colab (and GCP linux), and I don't quite remember seeing this sort of behavior. I understood M2 Max is new.", "I found out this has something to do with the variation in length of input tokens from one inference to the next. It doesn't seem to like receiving lengths that vary greatly, maybe this causes some sort of weird fragmentation in GPU memory?? Here's the code that only extract IMDB sentences that has >512 tokens. And it is able to sustain GPU utilization, with ~30it/s.\r\n\r\n```\r\nfrom transformers import AutoTokenizer, TFDistilBertForSequenceClassification\r\n\r\ntokenizer = AutoTokenizer.from_pretrained(\"distilbert-base-cased\")\r\nmodel = TFDistilBertForSequenceClassification.from_pretrained('distilbert-base-cased')\r\n\r\nfrom datasets import load_dataset\r\nimdb = load_dataset('imdb')\r\n\r\nprint('starting collecting sentences with tokens >= 512')\r\nsentences = [sentence for sentence in imdb['train']['text'] if tokenizer(sentence, truncation=True, return_tensors='tf')['input_ids'].shape[-1] >= 512]\r\nprint('finished collecting sentences with tokens >= 512')\r\n\r\nfor k, sentence in tqdm(enumerate(sentences)):\r\n inputs = tokenizer(sentence, truncation=True, return_tensors='tf')\r\n\r\n output = model(inputs).logits\r\n pred = np.argmax(output.numpy(), axis=1)\r\n \r\n if k % 100 == 0:\r\n print(f\"len(input_ids): {inputs['input_ids'].shape[-1]}\")\r\n\r\n``` \r\n\r\nprint\r\n\r\n```\r\n7it [00:00, 31.12it/s]\r\nlen(input_ids): 512\r\n107it [00:03, 32.38it/s]\r\nlen(input_ids): 512\r\n...\r\n...\r\n3804it [02:00, 31.85it/s]\r\nlen(input_ids): 512\r\n3904it [02:03, 32.50it/s]\r\nlen(input_ids): 512\r\n3946it [02:04, 31.70it/s]\r\n```\r\n\r\nAny ideas, is there a serious bug lurking behind? If you have instructions/tips on how to debug, I would be eager to try.", "Hi @kechan ,\r\n\r\nI just tried the code on Linux environment just to cross check the behaviour but got an error. Please refer to attached [gist](https://colab.sandbox.google.com/gist/SuryanarayanaY/0954c3cd6b8bc90db9decfd171bdfffe/60271.ipynb) and confirm whether the attached code is missing anything ? \r\n\r\nSince you are using tensorflow-macos with metal plugin request you to please post the issue in Apple forum also. \r\n\r\nThanks!", "@SuryanarayanaY Thanks for looking into it. \r\n\r\nI went to Colab notebook. That error I believed is due to incorrect import of tqdm. It should be:\r\n\r\n`from tqdm import tqdm`\r\n\r\nI will modify my code snippet to include the pip and imports from your notebook\r\n\r\nI changed it my own copy of colab notebook, and it worked. Please bear in mind this issue is not reproducible on Colab with GPU acceleration. It happens only with metal on apple silicon. \r\n\r\nAnd yes, here is the issue I logged on their forum:\r\n\r\nhttps://developer.apple.com/forums/thread/727890?answerId=750313022#750313022\r\n\r\nI am aware it may be a bit complicated to triage in lot of cases where more than one group is involved. However, if you can provide me tips, I can try debug this as far as I could, and cross-post whatever I find over with Apple. \r\n\r\nWhile I understood the problem, and know how to work around it, I felt that the Apple GPU is not fulfilling its potential, since aligning every input length to the max_len (to ensure data uniformity) may not memory-efficient.", "Hi @kechan,\r\n\r\nI got a query here. I gone through the code and In the code I can't see anywhere you have used tensorflow or keras. Is that Transformers using tensorflow at backend ? Is that the reason you posted issue here ? I am not sure whether the issue needs to be addressed here ? Please confirm the dependency with Tensorflow/keras. Thanks!\r\n", "@SuryanarayanaY This is the transformers module from HuggingFace. It sort of a higher level framework that sits atop both Tensorflow and Pytorch. The code snippet given is backed by TF, as indicated by the model name “ TFDistilBertForSequenceClassification”. While this code is only for inference, I can also reproduce this issue during training, (i.e. calling model.fit)", "@kechan ,\r\n\r\nThanks for the confirmation.You mean that `TFDistilBertForSequenceClassification` is completely built upon Tensorflow as backend right? \r\n\r\nAFAIK, This is the problem with only Mac M2 as you confirmed its fine on Colab/Linux, this needs to be addressed by Apple and I see you have already logged a ticket there. I can see some response there and hope it will be addressed\r\n\r\nIf the problem also observed with Linux/colab then we might also have a look into it.I see this is not the case here.\r\n", "@SuryanarayanaY This issue is specific to Apple M2 Max with Metal (GPU). And yes, TFDistil**** means it is backed by tensorflow in the backend. When I get the chance, I will attempt to build a case where huggingface is not involved, and see if it can reproduce. ", "@kechan ,\r\nThanks for confirmation. But we are not supporting `tensorflow-macos` and it is not same as `tensorflow`. If you can reproduce the behaviour with only `tensorflow` involved then we will definitely have a look into the issue. Thanks!", "This issue is stale because it has been open for 7 days with no activity. It will be closed if no further activity occurs. Thank you.", "This issue was closed because it has been inactive for 7 days since being marked as stale. Please reopen if you'd like to work on this further.", "Are you satisfied with the resolution of your issue?\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=Yes&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/60271\">Yes</a>\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=No&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/60271\">No</a>\n" ]
2023-04-08T22:13:45
2023-05-09T01:54:56
2023-05-09T01:54:52
NONE
null
null
null
<details><summary>Click to expand!</summary> ### Issue Type Performance ### Have you reproduced the bug with TF nightly? No ### Source source ### Tensorflow Version tensorflow-macos 2.9, tensorflow-metal 0.5.0 ### Custom Code Yes ### OS Platform and Distribution MacOS 13.3 ### Mobile device _No response_ ### Python version Python 3.10.9 ### Bazel version _No response_ ### GCC/Compiler version _No response_ ### CUDA/cuDNN version N/A ### GPU model and memory Apple M2 Max (unified memory) ### Current Behaviour? ```shell MacBook Pro M2 Max 96gb macOS 13.3 tensorflow-macos 2.9.0 tensorflow-metal 0.5.0 GPU utilization should hold steady when running inference for HuggingFace TFDistilBertForSequenceClassification from pretrained 'distilbert-base-cased'. Instead utilization dropped steadily from 50% to 10% (and sometimes, below 2%). It becomes excruciatingly slow. ``` ### Standalone code to reproduce the issue ```shell # if needed, from HuggingFace !pip install transformers !pip install datasets from transformers import AutoTokenizer, TFDistilBertForSequenceClassification from datasets import load_dataset from tqdm import tqdm imdb = load_dataset('imdb') sentences = imdb['train']['text'][:500] tokenizer = AutoTokenizer.from_pretrained("distilbert-base-cased") model = TFDistilBertForSequenceClassification.from_pretrained('distilbert-base-cased') for i, sentence in tqdm(enumerate(sentences)): inputs = tokenizer(sentence, truncation=True, return_tensors='tf') output = model(inputs).logits pred = np.argmax(output.numpy(), axis=1) if i % 100 == 0: print(f"len(input_ids): {inputs['input_ids'].shape[-1]}") ``` ### Relevant log output ```shell Output from print: Metal device set to: Apple M2 Max systemMemory: 96.00 GB maxCacheSize: 36.00 GB 3it [00:00, 10.87it/s] len(input_ids): 391 101it [00:13, 6.38it/s] len(input_ids): 215 201it [00:34, 4.78it/s] len(input_ids): 237 301it [00:55, 4.26it/s] len(input_ids): 256 401it [01:54, 1.12it/s] len(input_ids): 55 500it [03:40, 2.27it/s] ``` </details>
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/60271/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/60271/timeline
null
completed
false
https://api.github.com/repos/tensorflow/tensorflow/issues/60270
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/60270/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/60270/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/60270/events
https://github.com/tensorflow/tensorflow/issues/60270
1,659,644,438
I_kwDOArmXAs5i7CoW
60,270
Doc Feature Request: For tf 2, explain how to distribute a pretrained model across multiple nodes.
{ "login": "arivero", "id": 43174, "node_id": "MDQ6VXNlcjQzMTc0", "avatar_url": "https://avatars.githubusercontent.com/u/43174?v=4", "gravatar_id": "", "url": "https://api.github.com/users/arivero", "html_url": "https://github.com/arivero", "followers_url": "https://api.github.com/users/arivero/followers", "following_url": "https://api.github.com/users/arivero/following{/other_user}", "gists_url": "https://api.github.com/users/arivero/gists{/gist_id}", "starred_url": "https://api.github.com/users/arivero/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/arivero/subscriptions", "organizations_url": "https://api.github.com/users/arivero/orgs", "repos_url": "https://api.github.com/users/arivero/repos", "events_url": "https://api.github.com/users/arivero/events{/privacy}", "received_events_url": "https://api.github.com/users/arivero/received_events", "type": "User", "site_admin": false }
[ { "id": 404586594, "node_id": "MDU6TGFiZWw0MDQ1ODY1OTQ=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/stat:awaiting%20tensorflower", "name": "stat:awaiting tensorflower", "color": "f4b400", "default": false, "description": "Status - Awaiting response from tensorflower" }, { "id": 473173272, "node_id": "MDU6TGFiZWw0NzMxNzMyNzI=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/type:feature", "name": "type:feature", "color": "159b2e", "default": false, "description": "Feature requests" }, { "id": 996845227, "node_id": "MDU6TGFiZWw5OTY4NDUyMjc=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/comp:dist-strat", "name": "comp:dist-strat", "color": "0052cc", "default": false, "description": "Distribution Strategy related issues" } ]
open
false
{ "login": "SuryanarayanaY", "id": 116063290, "node_id": "U_kgDOBur8Og", "avatar_url": "https://avatars.githubusercontent.com/u/116063290?v=4", "gravatar_id": "", "url": "https://api.github.com/users/SuryanarayanaY", "html_url": "https://github.com/SuryanarayanaY", "followers_url": "https://api.github.com/users/SuryanarayanaY/followers", "following_url": "https://api.github.com/users/SuryanarayanaY/following{/other_user}", "gists_url": "https://api.github.com/users/SuryanarayanaY/gists{/gist_id}", "starred_url": "https://api.github.com/users/SuryanarayanaY/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/SuryanarayanaY/subscriptions", "organizations_url": "https://api.github.com/users/SuryanarayanaY/orgs", "repos_url": "https://api.github.com/users/SuryanarayanaY/repos", "events_url": "https://api.github.com/users/SuryanarayanaY/events{/privacy}", "received_events_url": "https://api.github.com/users/SuryanarayanaY/received_events", "type": "User", "site_admin": false }
[ { "login": "SuryanarayanaY", "id": 116063290, "node_id": "U_kgDOBur8Og", "avatar_url": "https://avatars.githubusercontent.com/u/116063290?v=4", "gravatar_id": "", "url": "https://api.github.com/users/SuryanarayanaY", "html_url": "https://github.com/SuryanarayanaY", "followers_url": "https://api.github.com/users/SuryanarayanaY/followers", "following_url": "https://api.github.com/users/SuryanarayanaY/following{/other_user}", "gists_url": "https://api.github.com/users/SuryanarayanaY/gists{/gist_id}", "starred_url": "https://api.github.com/users/SuryanarayanaY/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/SuryanarayanaY/subscriptions", "organizations_url": "https://api.github.com/users/SuryanarayanaY/orgs", "repos_url": "https://api.github.com/users/SuryanarayanaY/repos", "events_url": "https://api.github.com/users/SuryanarayanaY/events{/privacy}", "received_events_url": "https://api.github.com/users/SuryanarayanaY/received_events", "type": "User", "site_admin": false } ]
null
[ "@arivero \r\n\r\nRunning a large language model on a cluster of GPUs can be achieved with TensorFlow's distribution strategies. Since TensorFlow 2.x provides a much easier interface to work with, I'll outline a high-level approach for you to follow using TensorFlow 2.x, Keras, and Horovod.\r\n\r\nInstall the necessary packages:\r\nInstall TensorFlow 2.x.\r\nInstall Horovod, a distributed deep learning framework, which works well with TensorFlow, Keras, and other DL frameworks.\r\nSet up the cluster:\r\nFor an in-house cluster of GPUs, make sure all devices are connected to the same network and have the necessary GPU drivers and software installed (CUDA, cuDNN, etc.).\r\nFor a cloud-based cluster, use the provider's GPU-based instances and set up a virtual private network (VPN) between the instances.\r\nConfigure TensorFlow and Horovod:\r\nImport TensorFlow, Keras, and Horovod.\r\nInitialize Horovod by calling horovod.tensorflow.keras.init().\r\nPrepare your model:\r\nLoad your large language model using TensorFlow or Keras, e.g., tf.keras.models.load_model('path/to/model').\r\nWrap the model's optimizer with horovod.DistributedOptimizer(optimizer).\r\nCompile the model with the wrapped optimizer and appropriate loss and metric functions.\r\nConfigure the training and evaluation steps:\r\nSet up your dataset and data pipeline.\r\nWrap your dataset with tf.data.experimental.parallel_interleave() or tf.data.experimental.CsvDataset.from_generator() to distribute the data across multiple GPUs.\r\nDefine a custom training loop or use the built-in model.fit() and model.evaluate() functions. With Horovod, the training and evaluation steps will be automatically distributed across the available GPUs.\r\nRun the training and evaluation:\r\nUse horovodrun to launch your script on all the available devices. For example, horovodrun -np 4 -H localhost:4 python your_script.py will run your script on 4 GPUs.\r\nThis high-level approach should provide a starting point for running a large language model on a cluster of GPUs using TensorFlow 2.x, Keras, and Horovod. You may need to fine-tune the configuration and code to adapt to your specific setup and requirements.", "@Adesoji1 just to be sure can you confirm that if I use a model such that **it does not fit in one GPU** but its graph can be put across four GPUs, then horovod allows me to run inference? I can not see in the documentation any decent sample of model parallelism, not even GPUs in the same machine, and we are speaking of multi-node clusters.\r\n\r\nEven if it does, I still think that a tensorflow only tutorial would be a good thing, as distributing graphs was one of the design goals of tensorflow, so it could be good to exhibit this capability.\r\n\r\n", "Hi @arivero ,\r\n\r\nFor training on multiple works you can go through the attached tutorials [here](https://www.tensorflow.org/tutorials/distribute/multi_worker_with_keras) and [here](https://www.tensorflow.org/tutorials/distribute/multi_worker_with_ctl).All these uses data parallelism concept.\r\n\r\nHowever if you are looking for model parallelism right now Tensorflow not supporting model parallelism.Please refer to the source [here](https://www.tensorflow.org/api_docs/python/tf/distribute#:~:text=Data%20parallelism%20is,in%20the%20future).Here Model parallelism refers to splitting the Model on to different Ops and placing them on to different devices/workers and executing the Ops in Parallel. Right now Tensorflow supports data Parallelism i.e. splitting the data into different devices/workers.\r\n\r\nIf I am still missing something here please let me know. Thanks!\r\n", "Thanks, yes, I was looking for model parallelism, I see that it is not supported for training, but I was hoping that some support for inference only, when the graph is already know and trained. There is some legacy information around where it is suggested to use submodels and tf.device() contexts, to deploy manually, but it is mainly for tensorflow 1.x and not sure if it really works across servers.\r\n\r\nWhat I was looking for was a recipe such as:\r\n- build the model.\r\n- from the model, obtain the graph.\r\n- for each node, launch a server for all the devices it manages, or allows allocation.\r\n- for the graph, loop manually across, using tf.device() or something similar to allocate each operation to a device.\r\n- or, alternatively, give to tf a list of all the target devices and let it to allocate as it needs.\r\n- execute." ]
2023-04-08T20:59:21
2023-05-15T04:28:48
null
NONE
null
null
null
When I read the original TF paper, I was told that > Dataflow simplifies distributed execution, because it makes communication between subcomputations explicit. > It enables the same TensorFlow program to be deployed to a cluster of GPUs for training, a cluster of TPUs for serving, and a cellphone for mobile inference. > Each operation resides on a particular device, such as a CPU or GPU in a particular task. A device is responsible for executing a kernel for each operation assigned to it. > (...) > The TensorFlow runtime places operations on devices, subject to implicit or explicit constraints in the graph. > The placement algorithm computes a feasible set of devices for each operation, calculates the sets of operations that must be colocated, and selects a satisfying device for each colocation group. I work with small models, so I have never need more than one device. But now large models are all the rage, and a lot of competition is about just getting the weights of a pretrained model and run them. So I want cluster all the GPUs of a room to just run a LLM, either ad-hoc, keras or HF. I would expect a tutorial for this to be available somewhere. It is not. I guess one still needs to configure a cluster description and, if such option is available still in 2.x, launch an script in each machine to join them into a cluster. And then somehow launch a master script in some machine that loads the model, deploys its graph across the cluster, and runs it. Without needing any mirroring or any parameter collection, so that the current objects in distribute.strategy seem very big for such task. Perhaps eventually the example could include some ClusterResolver for common cloud services, but ideally it should be for in-home heterogeneous architecture. Of course it could be still sensible to do such tutorial with the distribute.strategy tools, if it were considered as a first introduction to distribution of tasks, and that the next natural thing is to learn also to do a loss calculation, a backpropagation, and a training step.
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/60270/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/60270/timeline
null
null
false
https://api.github.com/repos/tensorflow/tensorflow/issues/60269
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/60269/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/60269/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/60269/events
https://github.com/tensorflow/tensorflow/issues/60269
1,659,606,439
I_kwDOArmXAs5i65Wn
60,269
Tensorflow not recognizing GPU in Spyder
{ "login": "WennPaper", "id": 67032259, "node_id": "MDQ6VXNlcjY3MDMyMjU5", "avatar_url": "https://avatars.githubusercontent.com/u/67032259?v=4", "gravatar_id": "", "url": "https://api.github.com/users/WennPaper", "html_url": "https://github.com/WennPaper", "followers_url": "https://api.github.com/users/WennPaper/followers", "following_url": "https://api.github.com/users/WennPaper/following{/other_user}", "gists_url": "https://api.github.com/users/WennPaper/gists{/gist_id}", "starred_url": "https://api.github.com/users/WennPaper/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/WennPaper/subscriptions", "organizations_url": "https://api.github.com/users/WennPaper/orgs", "repos_url": "https://api.github.com/users/WennPaper/repos", "events_url": "https://api.github.com/users/WennPaper/events{/privacy}", "received_events_url": "https://api.github.com/users/WennPaper/received_events", "type": "User", "site_admin": false }
[ { "id": 473173351, "node_id": "MDU6TGFiZWw0NzMxNzMzNTE=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/type:build/install", "name": "type:build/install", "color": "159b2e", "default": false, "description": "Build and install issues" }, { "id": 1188421838, "node_id": "MDU6TGFiZWwxMTg4NDIxODM4", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/subtype:windows", "name": "subtype:windows", "color": "b619ea", "default": false, "description": "Windows Build/Installation Issues" }, { "id": 5206407904, "node_id": "LA_kwDOArmXAs8AAAABNlN64A", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/TF%202.12", "name": "TF 2.12", "color": "c5def5", "default": false, "description": "For issues related to Tensorflow 2.12" } ]
closed
false
{ "login": "tiruk007", "id": 111861663, "node_id": "U_kgDOBqrfnw", "avatar_url": "https://avatars.githubusercontent.com/u/111861663?v=4", "gravatar_id": "", "url": "https://api.github.com/users/tiruk007", "html_url": "https://github.com/tiruk007", "followers_url": "https://api.github.com/users/tiruk007/followers", "following_url": "https://api.github.com/users/tiruk007/following{/other_user}", "gists_url": "https://api.github.com/users/tiruk007/gists{/gist_id}", "starred_url": "https://api.github.com/users/tiruk007/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/tiruk007/subscriptions", "organizations_url": "https://api.github.com/users/tiruk007/orgs", "repos_url": "https://api.github.com/users/tiruk007/repos", "events_url": "https://api.github.com/users/tiruk007/events{/privacy}", "received_events_url": "https://api.github.com/users/tiruk007/received_events", "type": "User", "site_admin": false }
[ { "login": "tiruk007", "id": 111861663, "node_id": "U_kgDOBqrfnw", "avatar_url": "https://avatars.githubusercontent.com/u/111861663?v=4", "gravatar_id": "", "url": "https://api.github.com/users/tiruk007", "html_url": "https://github.com/tiruk007", "followers_url": "https://api.github.com/users/tiruk007/followers", "following_url": "https://api.github.com/users/tiruk007/following{/other_user}", "gists_url": "https://api.github.com/users/tiruk007/gists{/gist_id}", "starred_url": "https://api.github.com/users/tiruk007/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/tiruk007/subscriptions", "organizations_url": "https://api.github.com/users/tiruk007/orgs", "repos_url": "https://api.github.com/users/tiruk007/repos", "events_url": "https://api.github.com/users/tiruk007/events{/privacy}", "received_events_url": "https://api.github.com/users/tiruk007/received_events", "type": "User", "site_admin": false } ]
null
[ "@WenTheProgrammer \r\nSorry for the late reply, Beginning with Tensorflow 2.11, support for GPU on native windows has changed. You will need to install TensorFlow in WSL2 or install tensorflow-cpu within windows machines or try the TensorFlow-DirectML-Plugin.\r\nhttps://www.tensorflow.org/install/pip#windows-native\r\nhttps://www.tensorflow.org/install/pip#windows-wsl2\r\n\r\nGoing forward, Tensorflow support will be developed and maintained by Tensorflow Official build collaborators (Intel, AWS, ARM, linaro etc.). For more details please take a look at this [link].(https://blog.tensorflow.org/2022/09/announcing-tensorflow-official-build-collaborators.html)\r\n\r\nThank you !", "Simply following the instructions in this link worked for me!\r\nhttps://www.tensorflow.org/install/pip#windows-native", "Are you satisfied with the resolution of your issue?\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=Yes&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/60269\">Yes</a>\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=No&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/60269\">No</a>\n" ]
2023-04-08T18:29:39
2023-04-12T01:24:52
2023-04-12T01:24:49
NONE
null
null
null
I have followed this YouTube tutorial since I want to use GPU for tensorflow model training: https://www.youtube.com/watch?v=yLVFwAaFACk&ab_channel=DigitalSreeni. However, I was still not able to detect GPU of my computer in Spyder: ``` from tensorflow.python.client import device_lib print(device_lib.list_local_devices()) [name: "/device:CPU:0" device_type: "CPU" memory_limit: 268435456 locality { } incarnation: 17504734730771000338 xla_global_id: -1 ] ``` My system is Windows 11. My tensorflow version is 2.12.0. My GPUs are NVIDIA GeForce RTX 2060 and Intel® UHD Graphics 630. My NVIDIA CUDA version is 12.1. I used cudnn-windows-x86_64-8.8.1.3_cuda12-archive. My Anaconda is fully updated. My Spyder version is 5.4.2. Any help will be much appreciated!
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/60269/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/60269/timeline
null
completed
false
https://api.github.com/repos/tensorflow/tensorflow/issues/60268
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/60268/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/60268/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/60268/events
https://github.com/tensorflow/tensorflow/issues/60268
1,659,560,907
I_kwDOArmXAs5i6uPL
60,268
Hey why you all are stopping the tensorflow GPU support for windows. It sucks you know. I am here sitting infront of my computer since 12 hours and trying to analyze whats going wrong and why my GPU is not showing on the tensorflow. And after some reserch I found that you are stopping the suppport . WHY?????????????????????????
{ "login": "Satya-prakash3", "id": 68553443, "node_id": "MDQ6VXNlcjY4NTUzNDQz", "avatar_url": "https://avatars.githubusercontent.com/u/68553443?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Satya-prakash3", "html_url": "https://github.com/Satya-prakash3", "followers_url": "https://api.github.com/users/Satya-prakash3/followers", "following_url": "https://api.github.com/users/Satya-prakash3/following{/other_user}", "gists_url": "https://api.github.com/users/Satya-prakash3/gists{/gist_id}", "starred_url": "https://api.github.com/users/Satya-prakash3/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Satya-prakash3/subscriptions", "organizations_url": "https://api.github.com/users/Satya-prakash3/orgs", "repos_url": "https://api.github.com/users/Satya-prakash3/repos", "events_url": "https://api.github.com/users/Satya-prakash3/events{/privacy}", "received_events_url": "https://api.github.com/users/Satya-prakash3/received_events", "type": "User", "site_admin": false }
[ { "id": 386191887, "node_id": "MDU6TGFiZWwzODYxOTE4ODc=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/stat:awaiting%20response", "name": "stat:awaiting response", "color": "f4b400", "default": false, "description": "Status - Awaiting response from author" }, { "id": 473173351, "node_id": "MDU6TGFiZWw0NzMxNzMzNTE=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/type:build/install", "name": "type:build/install", "color": "159b2e", "default": false, "description": "Build and install issues" }, { "id": 474725938, "node_id": "MDU6TGFiZWw0NzQ3MjU5Mzg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/stale", "name": "stale", "color": "d4c5f9", "default": false, "description": "This label marks the issue/pr stale - to be closed automatically if no activity" }, { "id": 1188421838, "node_id": "MDU6TGFiZWwxMTg4NDIxODM4", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/subtype:windows", "name": "subtype:windows", "color": "b619ea", "default": false, "description": "Windows Build/Installation Issues" }, { "id": 5206407904, "node_id": "LA_kwDOArmXAs8AAAABNlN64A", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/TF%202.12", "name": "TF 2.12", "color": "c5def5", "default": false, "description": "For issues related to Tensorflow 2.12" } ]
closed
false
{ "login": "tilakrayal", "id": 81610181, "node_id": "MDQ6VXNlcjgxNjEwMTgx", "avatar_url": "https://avatars.githubusercontent.com/u/81610181?v=4", "gravatar_id": "", "url": "https://api.github.com/users/tilakrayal", "html_url": "https://github.com/tilakrayal", "followers_url": "https://api.github.com/users/tilakrayal/followers", "following_url": "https://api.github.com/users/tilakrayal/following{/other_user}", "gists_url": "https://api.github.com/users/tilakrayal/gists{/gist_id}", "starred_url": "https://api.github.com/users/tilakrayal/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/tilakrayal/subscriptions", "organizations_url": "https://api.github.com/users/tilakrayal/orgs", "repos_url": "https://api.github.com/users/tilakrayal/repos", "events_url": "https://api.github.com/users/tilakrayal/events{/privacy}", "received_events_url": "https://api.github.com/users/tilakrayal/received_events", "type": "User", "site_admin": false }
[ { "login": "tilakrayal", "id": 81610181, "node_id": "MDQ6VXNlcjgxNjEwMTgx", "avatar_url": "https://avatars.githubusercontent.com/u/81610181?v=4", "gravatar_id": "", "url": "https://api.github.com/users/tilakrayal", "html_url": "https://github.com/tilakrayal", "followers_url": "https://api.github.com/users/tilakrayal/followers", "following_url": "https://api.github.com/users/tilakrayal/following{/other_user}", "gists_url": "https://api.github.com/users/tilakrayal/gists{/gist_id}", "starred_url": "https://api.github.com/users/tilakrayal/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/tilakrayal/subscriptions", "organizations_url": "https://api.github.com/users/tilakrayal/orgs", "repos_url": "https://api.github.com/users/tilakrayal/repos", "events_url": "https://api.github.com/users/tilakrayal/events{/privacy}", "received_events_url": "https://api.github.com/users/tilakrayal/received_events", "type": "User", "site_admin": false } ]
null
[ "Hi, In [this TensorFlow blog](https://blog.tensorflow.org/2022/09/whats-new-in-tensorflow-210.html) please see section \"Expanded GPU support on Windows\". Also please see [TensorFlow install page](https://www.tensorflow.org/install/pip) and [this page](https://learn.microsoft.com/en-us/windows/ai/directml/gpu-tensorflow-plugin) for more info. Please feel free to sign up to the mailing list [email protected] to be notified of the most recent updates.\r\n", "This issue is stale because it has been open for 7 days with no activity. It will be closed if no further activity occurs. Thank you.", "This issue was closed because it has been inactive for 7 days since being marked as stale. Please reopen if you'd like to work on this further.", "Are you satisfied with the resolution of your issue?\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=Yes&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/60268\">Yes</a>\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=No&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/60268\">No</a>\n" ]
2023-04-08T15:45:16
2023-05-04T01:52:37
2023-05-04T01:52:34
NONE
null
null
null
Please go to Stack Overflow for help and support: https://stackoverflow.com/questions/tagged/tensorflow If you open a GitHub issue, here is our policy: 1. It must be a bug, a feature request, or a significant problem with the documentation (for small docs fixes please send a PR instead). 2. The form below must be filled out. 3. It shouldn't be a TensorBoard issue. Those go [here](https://github.com/tensorflow/tensorboard/issues). **Here's why we have that policy**: TensorFlow developers respond to issues. We want to focus on work that benefits the whole community, e.g., fixing bugs and adding features. Support only helps individuals. GitHub also notifies thousands of people when issues are filed. We want them to see you communicating an interesting problem, rather than being redirected to Stack Overflow. ------------------------ ### System information - **Have I written custom code (as opposed to using a stock example script provided in TensorFlow)**: - **OS Platform and Distribution (e.g., Linux Ubuntu 16.04)**: - **Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on a mobile device**: - **TensorFlow installed from (source or binary)**: - **TensorFlow version (use command below)**: - **Python version**: - **Bazel version (if compiling from source)**: - **GCC/Compiler version (if compiling from source)**: - **CUDA/cuDNN version**: - **GPU model and memory**: - **Exact command to reproduce**: You can collect some of this information using our environment capture script: https://github.com/tensorflow/tensorflow/tree/master/tools/tf_env_collect.sh You can obtain the TensorFlow version with: ```bash python -c "import tensorflow as tf; print(tf.version.GIT_VERSION, tf.version.VERSION)" ``` ### Describe the problem Describe the problem clearly here. Be sure to convey here why it's a bug in TensorFlow or a feature request. ### Source code / logs Include any logs or source code that would be helpful to diagnose the problem. If including tracebacks, please include the full traceback. Large logs and files should be attached. Try to provide a reproducible test case that is the bare minimum necessary to generate the problem.
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/60268/reactions", "total_count": 1, "+1": 0, "-1": 1, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/60268/timeline
null
completed
false
https://api.github.com/repos/tensorflow/tensorflow/issues/60267
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/60267/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/60267/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/60267/events
https://github.com/tensorflow/tensorflow/issues/60267
1,659,491,731
I_kwDOArmXAs5i6dWT
60,267
TF Hangs when calculating validation sample weights
{ "login": "beyarkay", "id": 33420535, "node_id": "MDQ6VXNlcjMzNDIwNTM1", "avatar_url": "https://avatars.githubusercontent.com/u/33420535?v=4", "gravatar_id": "", "url": "https://api.github.com/users/beyarkay", "html_url": "https://github.com/beyarkay", "followers_url": "https://api.github.com/users/beyarkay/followers", "following_url": "https://api.github.com/users/beyarkay/following{/other_user}", "gists_url": "https://api.github.com/users/beyarkay/gists{/gist_id}", "starred_url": "https://api.github.com/users/beyarkay/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/beyarkay/subscriptions", "organizations_url": "https://api.github.com/users/beyarkay/orgs", "repos_url": "https://api.github.com/users/beyarkay/repos", "events_url": "https://api.github.com/users/beyarkay/events{/privacy}", "received_events_url": "https://api.github.com/users/beyarkay/received_events", "type": "User", "site_admin": false }
[ { "id": 404586594, "node_id": "MDU6TGFiZWw0MDQ1ODY1OTQ=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/stat:awaiting%20tensorflower", "name": "stat:awaiting tensorflower", "color": "f4b400", "default": false, "description": "Status - Awaiting response from tensorflower" }, { "id": 1097546578, "node_id": "MDU6TGFiZWwxMDk3NTQ2NTc4", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/comp:keras", "name": "comp:keras", "color": "0052cc", "default": false, "description": "Keras related issues" }, { "id": 1205765054, "node_id": "MDU6TGFiZWwxMjA1NzY1MDU0", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/subtype:macOS", "name": "subtype:macOS", "color": "b619ea", "default": false, "description": "macOS Build/Installation issues" }, { "id": 1463677878, "node_id": "MDU6TGFiZWwxNDYzNjc3ODc4", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/type:performance", "name": "type:performance", "color": "159b2e", "default": false, "description": "Performance Issue" }, { "id": 4032183365, "node_id": "LA_kwDOArmXAs7wVjxF", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/TF%202.9", "name": "TF 2.9", "color": "1CF842", "default": false, "description": "Issues found in the TF 2.9 release (or RCs)" } ]
open
false
{ "login": "SuryanarayanaY", "id": 116063290, "node_id": "U_kgDOBur8Og", "avatar_url": "https://avatars.githubusercontent.com/u/116063290?v=4", "gravatar_id": "", "url": "https://api.github.com/users/SuryanarayanaY", "html_url": "https://github.com/SuryanarayanaY", "followers_url": "https://api.github.com/users/SuryanarayanaY/followers", "following_url": "https://api.github.com/users/SuryanarayanaY/following{/other_user}", "gists_url": "https://api.github.com/users/SuryanarayanaY/gists{/gist_id}", "starred_url": "https://api.github.com/users/SuryanarayanaY/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/SuryanarayanaY/subscriptions", "organizations_url": "https://api.github.com/users/SuryanarayanaY/orgs", "repos_url": "https://api.github.com/users/SuryanarayanaY/repos", "events_url": "https://api.github.com/users/SuryanarayanaY/events{/privacy}", "received_events_url": "https://api.github.com/users/SuryanarayanaY/received_events", "type": "User", "site_admin": false }
[ { "login": "SuryanarayanaY", "id": 116063290, "node_id": "U_kgDOBur8Og", "avatar_url": "https://avatars.githubusercontent.com/u/116063290?v=4", "gravatar_id": "", "url": "https://api.github.com/users/SuryanarayanaY", "html_url": "https://github.com/SuryanarayanaY", "followers_url": "https://api.github.com/users/SuryanarayanaY/followers", "following_url": "https://api.github.com/users/SuryanarayanaY/following{/other_user}", "gists_url": "https://api.github.com/users/SuryanarayanaY/gists{/gist_id}", "starred_url": "https://api.github.com/users/SuryanarayanaY/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/SuryanarayanaY/subscriptions", "organizations_url": "https://api.github.com/users/SuryanarayanaY/orgs", "repos_url": "https://api.github.com/users/SuryanarayanaY/repos", "events_url": "https://api.github.com/users/SuryanarayanaY/events{/privacy}", "received_events_url": "https://api.github.com/users/SuryanarayanaY/received_events", "type": "User", "site_admin": false } ]
null
[ "In addition to this, isn't it a bug that setting the `class_weight` parameter in `model.fit` does not apply those class weights to the `validation_data`?\r\n\r\nFor example, this code:\r\n\r\n\r\n```py\r\nmodel.fit(\r\n X_trn, \r\n y_trn,\r\n # NOTE: Validation loss is *incorrect* because it doesn't take into account the class weights\r\n validation_data=(X_val, y_val),\r\n class_weight=calculate_weights_for_my_imbalanced_classes(y_trn),\r\n)\r\n```\r\n\r\nresults in `loss` values around 0.001, but `val_loss` values of around 4.0, because I have one very dominant class (~99% of the observations) and 49 classes in the remaining 1%.\r\n\r\nShouldn't the `class_weight` dictionary be applied to the `val_loss` calculation if `validation_data` is provided?", "@sushreebarsa is this a known issue? or is there any solution planned?", "Hello @beyarkay! I was able to run the code successfully on colab using TF v2.12, please find the [gist](https://colab.research.google.com/gist/sushreebarsa/9aa8f3c9c8b6e7b0ecb705f364ac6d1a/60267.ipynb) here and try to upgrade the TF version to latest. Thank you!", "I am unable to update to the latest version of TF because of [this macos/metal bug](https://developer.apple.com/forums/thread/722389?740707022). Is there any fix that I can use besides updating? (since it seems like apple isn't going to be fixing the issue super soon)", "@beyarkay Thank you for the response!\r\n@SuryanarayanaY Could you please have a look at this issue?\r\nThank you!", "Hi @beyarkay ,\r\n\r\nIf you want to use latest tensorflow-macos with metal plugin, you need to use legacy optimizer. The constraint you have mentioned for updating to new version is due to the optimizer issue.Suppose if you are using `keras.optimizers.Adam(1e-5)` replace it with `tf.keras.optimizers.legacy.Adam(1e-5)` and it should work fine. \r\n\r\nPlease try this and let us know of still having any problem. Thanks!\r\n", "Thanks! That works perfectly. Are there any differences between `keras.optimizers.Adam` and `tf.keras.optimizers.legacy.Adam` that I should know about which might cause me issues in the future?", "Okay nevermind, it's not working now for some reason. I'll paste the code I'm using (although I literally only used the legacy version of Adam) but it's having the same error. I've tried restarting my notebook, but no luck.\r\n\r\n\r\n<details>\r\n<summary>Code</summary>\r\n\r\n```py\r\nimport numpy as np\r\nimport keras\r\nimport tensorflow as tf\r\nimport sklearn.model_selection\r\n\r\nX = np.random.randint(low=300, high=900, size=(215699, 30, 30))\r\ny = np.random.randint(low=0, high=51, size=(215699,))\r\nX_trn, X_val, y_trn, y_val = sklearn.model_selection.train_test_split(X, y)\r\n\r\nm = tf.keras.Sequential(\r\n [\r\n keras.layers.Input(shape=X.shape[1:]),\r\n keras.layers.Flatten(),\r\n keras.layers.Dense(units=64, activation=\"relu\",),\r\n keras.layers.Dense(units=64, activation=\"relu\",),\r\n keras.layers.Dense(len(np.unique(y))),\r\n ]\r\n)\r\nm.compile(\r\n optimizer=tf.keras.optimizers.legacy.Adam(1e-5),\r\n loss=keras.losses.SparseCategoricalCrossentropy(from_logits=True),\r\n)\r\n\r\nsample_weights_val = np.ones(y_val.shape)\r\n\r\nhistory = m.fit(\r\n X_trn,\r\n y_trn,\r\n validation_data=(X_val, y_val, sample_weights_val),\r\n batch_size=128,\r\n epochs=5,\r\n)\r\n```\r\n\r\n</details>\r\n\r\nAnd the output is:\r\n\r\n```\r\nEpoch 1/5\r\n 12/1264 [..............................] - ETA: 5s - loss: 844.2266 \r\n\r\n2023-04-14 11:53:32.963873: I tensorflow/core/grappler/optimizers/custom_graph_optimizer_registry.cc:113] Plugin optimizer for device_type GPU is enabled.\r\n\r\n1256/1264 [============================>.] - ETA: 0s - loss: 125.0102\r\n```", "@beyarkay ,\r\n\r\nI have replicated the issue with tensorflow-macos==2.11 version and its still an issue with 2.11 version also. The code hangs as reported and i have to interrupt it manually after around 2 minutes.For reference I have attached the logs below.\r\n\r\n```\r\n(tf-metal) suryanarayanay-macbookpro:~ suryanarayanay$ python 60267.py\r\nMetal device set to: Apple M1 Pro\r\n\r\nsystemMemory: 16.00 GB\r\nmaxCacheSize: 5.33 GB\r\n\r\n2023-04-14 19:14:12.631493: I tensorflow/core/common_runtime/pluggable_device/pluggable_device_factory.cc:306] Could not identify NUMA node of platform GPU ID 0, defaulting to 0. Your kernel may not have been built with NUMA support.\r\n2023-04-14 19:14:12.631513: I tensorflow/core/common_runtime/pluggable_device/pluggable_device_factory.cc:272] Created TensorFlow device (/job:localhost/replica:0/task:0/device:GPU:0 with 0 MB memory) -> physical PluggableDevice (device: 0, name: METAL, pci bus id: <undefined>)\r\n2023-04-14 19:14:13.425947: W tensorflow/tsl/platform/profile_utils/cpu_utils.cc:128] Failed to get CPU frequency: 0 Hz\r\nEpoch 1/5\r\n2023-04-14 19:14:13.569687: I tensorflow/core/grappler/optimizers/custom_graph_optimizer_registry.cc:114] Plugin optimizer for device_type GPU is enabled.\r\n1264/1264 [==============================] - ETA: 0s - loss: 111.5523^CTraceback (most recent call last):\r\n File \"/Users/suryanarayanay/60267.py\", line 35, in <module>\r\n history = m.fit(\r\n File \"/Users/suryanarayanay/miniconda/envs/tf-metal/lib/python3.9/site-packages/keras/utils/traceback_utils.py\", line 65, in error_handler\r\n return fn(*args, **kwargs)\r\n File \"/Users/suryanarayanay/miniconda/envs/tf-metal/lib/python3.9/site-packages/keras/engine/training.py\", line 1680, in fit\r\n self._eval_data_handler = data_adapter.get_data_handler(\r\n File \"/Users/suryanarayanay/miniconda/envs/tf-metal/lib/python3.9/site-packages/keras/engine/data_adapter.py\", line 1579, in get_data_handler\r\n return DataHandler(*args, **kwargs)\r\n File \"/Users/suryanarayanay/miniconda/envs/tf-metal/lib/python3.9/site-packages/keras/engine/data_adapter.py\", line 1259, in __init__\r\n self._adapter = adapter_cls(\r\n File \"/Users/suryanarayanay/miniconda/envs/tf-metal/lib/python3.9/site-packages/keras/engine/data_adapter.py\", line 251, in __init__\r\n (sample_weights, _, _) = training_utils.handle_partial_sample_weights(\r\n File \"/Users/suryanarayanay/miniconda/envs/tf-metal/lib/python3.9/site-packages/keras/engine/training_utils.py\", line 78, in handle_partial_sample_weights\r\n partial_sample_weight = any_sample_weight and any(\r\n File \"/Users/suryanarayanay/miniconda/envs/tf-metal/lib/python3.9/site-packages/keras/engine/training_utils.py\", line 78, in <genexpr>\r\n partial_sample_weight = any_sample_weight and any(\r\n File \"/Users/suryanarayanay/miniconda/envs/tf-metal/lib/python3.9/site-packages/tensorflow/python/framework/ops.py\", line 7327, in __next__\r\n result = self._tensor[self._index]\r\n File \"/Users/suryanarayanay/miniconda/envs/tf-metal/lib/python3.9/site-packages/tensorflow/python/util/traceback_utils.py\", line 150, in error_handler\r\n return fn(*args, **kwargs)\r\n File \"/Users/suryanarayanay/miniconda/envs/tf-metal/lib/python3.9/site-packages/tensorflow/python/util/dispatch.py\", line 1176, in op_dispatch_handler\r\n return dispatch_target(*args, **kwargs)\r\n File \"/Users/suryanarayanay/miniconda/envs/tf-metal/lib/python3.9/site-packages/tensorflow/python/ops/array_ops.py\", line 1096, in _slice_helper\r\n return strided_slice(\r\n File \"/Users/suryanarayanay/miniconda/envs/tf-metal/lib/python3.9/site-packages/tensorflow/python/util/traceback_utils.py\", line 150, in error_handler\r\n return fn(*args, **kwargs)\r\n File \"/Users/suryanarayanay/miniconda/envs/tf-metal/lib/python3.9/site-packages/tensorflow/python/util/dispatch.py\", line 1176, in op_dispatch_handler\r\n return dispatch_target(*args, **kwargs)\r\n File \"/Users/suryanarayanay/miniconda/envs/tf-metal/lib/python3.9/site-packages/tensorflow/python/ops/array_ops.py\", line 1269, in strided_slice\r\n op = gen_array_ops.strided_slice(\r\n File \"/Users/suryanarayanay/miniconda/envs/tf-metal/lib/python3.9/site-packages/tensorflow/python/ops/gen_array_ops.py\", line 10672, in strided_slice\r\n _result = pywrap_tfe.TFE_Py_FastPathExecute(\r\nKeyboardInterrupt\r\n\r\n(tf-metal) suryanarayanay-macbookpro:~ suryanarayanay$ python3 -c \"import tensorflow as tf; print(tf.__version__)\"\r\n2.11.0\r\n(tf-metal) suryanarayanay-macbookpro:~ suryanarayanay$ \r\n```\r\n\r\nI have also tested with tensorflow-macos 2.12 versions and the same behaviour observed there also.Attched logs below for reference.\r\n[60267_logs(macos-2.12).txt](https://github.com/tensorflow/tensorflow/files/11233613/60267_logs.macos-2.12.txt)\r\n", "Thanks for looking at it! Is there any hope for a fix?", "@nitins17 , Do you have any pointers ? The same code works fine with tensorflow==2.12 on colab but fails with tensorflow-macos. \r\n\r\ncc: @learning-to-play " ]
2023-04-08T11:18:36
2023-04-14T14:17:22
null
NONE
null
null
null
<details><summary>Click to expand!</summary> ### Issue Type Performance ### Have you reproduced the bug with TF nightly? No ### Source binary ### Tensorflow Version unknown 2.9.2 ### Custom Code Yes ### OS Platform and Distribution MacOS 12.4 ### Mobile device NA ### Python version Python 3.10.5 ### Bazel version NA ### GCC/Compiler version NA ### CUDA/cuDNN version NA ### GPU model and memory NA ### Current Behaviour? While using `validation_data` in `model.fit`, TF hangs when it's finished the first epoch (but before updating the progress bar with the validation loss). Specifically, this happens when a 3-tuple is passed to `validation_data`, where the third element is an array specifying the sample weights. This happens even if the sample weights are all `1.0`. ### Standalone code to reproduce the issue ```shell import numpy as np import keras import tensorflow as tf import sklearn.model_selection X = np.random.randint(low=300, high=900, size=(215699, 30, 30)) y = np.random.randint(low=0, high=51, size=(215699,)) X_trn, X_val, y_trn, y_val = sklearn.model_selection.train_test_split(X, y) m = tf.keras.Sequential( [ keras.layers.Input(shape=X.shape[1:]), keras.layers.Flatten(), keras.layers.Dense(units=64, activation="relu",), keras.layers.Dense(units=64, activation="relu",), keras.layers.Dense(len(np.unique(y))), ] ) m.compile( optimizer=keras.optimizers.Adam(1e-5), loss=keras.losses.SparseCategoricalCrossentropy(from_logits=True), ) sample_weights_val = np.ones(y_val.shape) history = m.fit( X_trn, y_trn, validation_data=(X_val, y_val, sample_weights_val), batch_size=128, epochs=5, ) ``` ### Relevant log output ```shell Epoch 1/5 2023-04-08 13:18:01.491389: W tensorflow/core/platform/profile_utils/cpu_utils.cc:128] Failed to get CPU frequency: 0 Hz 2023-04-08 13:18:01.621051: I tensorflow/core/grappler/optimizers/custom_graph_optimizer_registry.cc:113] Plugin optimizer for device_type GPU is enabled. 1264/1264 [==============================] - ETA: 0s - loss: 124.2101 ``` At this point Tensorflow stops and I've got to interrupt it in order to get control back. </details>
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/60267/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/60267/timeline
null
null
false
https://api.github.com/repos/tensorflow/tensorflow/issues/60266
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/60266/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/60266/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/60266/events
https://github.com/tensorflow/tensorflow/issues/60266
1,659,429,776
I_kwDOArmXAs5i6OOQ
60,266
tf.GradientTape.gradients() does not support graph control flow operations like tf.cond or tf.while at this time. Use tf.gradients() instead
{ "login": "dwzdtx", "id": 49052372, "node_id": "MDQ6VXNlcjQ5MDUyMzcy", "avatar_url": "https://avatars.githubusercontent.com/u/49052372?v=4", "gravatar_id": "", "url": "https://api.github.com/users/dwzdtx", "html_url": "https://github.com/dwzdtx", "followers_url": "https://api.github.com/users/dwzdtx/followers", "following_url": "https://api.github.com/users/dwzdtx/following{/other_user}", "gists_url": "https://api.github.com/users/dwzdtx/gists{/gist_id}", "starred_url": "https://api.github.com/users/dwzdtx/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/dwzdtx/subscriptions", "organizations_url": "https://api.github.com/users/dwzdtx/orgs", "repos_url": "https://api.github.com/users/dwzdtx/repos", "events_url": "https://api.github.com/users/dwzdtx/events{/privacy}", "received_events_url": "https://api.github.com/users/dwzdtx/received_events", "type": "User", "site_admin": false }
[ { "id": 386191887, "node_id": "MDU6TGFiZWwzODYxOTE4ODc=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/stat:awaiting%20response", "name": "stat:awaiting response", "color": "f4b400", "default": false, "description": "Status - Awaiting response from author" }, { "id": 473184161, "node_id": "MDU6TGFiZWw0NzMxODQxNjE=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/type:support", "name": "type:support", "color": "159b2e", "default": false, "description": "Support issues" }, { "id": 474725938, "node_id": "MDU6TGFiZWw0NzQ3MjU5Mzg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/stale", "name": "stale", "color": "d4c5f9", "default": false, "description": "This label marks the issue/pr stale - to be closed automatically if no activity" }, { "id": 1097547147, "node_id": "MDU6TGFiZWwxMDk3NTQ3MTQ3", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/comp:ops", "name": "comp:ops", "color": "0052cc", "default": false, "description": "OPs related issues" } ]
closed
false
{ "login": "tilakrayal", "id": 81610181, "node_id": "MDQ6VXNlcjgxNjEwMTgx", "avatar_url": "https://avatars.githubusercontent.com/u/81610181?v=4", "gravatar_id": "", "url": "https://api.github.com/users/tilakrayal", "html_url": "https://github.com/tilakrayal", "followers_url": "https://api.github.com/users/tilakrayal/followers", "following_url": "https://api.github.com/users/tilakrayal/following{/other_user}", "gists_url": "https://api.github.com/users/tilakrayal/gists{/gist_id}", "starred_url": "https://api.github.com/users/tilakrayal/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/tilakrayal/subscriptions", "organizations_url": "https://api.github.com/users/tilakrayal/orgs", "repos_url": "https://api.github.com/users/tilakrayal/repos", "events_url": "https://api.github.com/users/tilakrayal/events{/privacy}", "received_events_url": "https://api.github.com/users/tilakrayal/received_events", "type": "User", "site_admin": false }
[ { "login": "tilakrayal", "id": 81610181, "node_id": "MDQ6VXNlcjgxNjEwMTgx", "avatar_url": "https://avatars.githubusercontent.com/u/81610181?v=4", "gravatar_id": "", "url": "https://api.github.com/users/tilakrayal", "html_url": "https://github.com/tilakrayal", "followers_url": "https://api.github.com/users/tilakrayal/followers", "following_url": "https://api.github.com/users/tilakrayal/following{/other_user}", "gists_url": "https://api.github.com/users/tilakrayal/gists{/gist_id}", "starred_url": "https://api.github.com/users/tilakrayal/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/tilakrayal/subscriptions", "organizations_url": "https://api.github.com/users/tilakrayal/orgs", "repos_url": "https://api.github.com/users/tilakrayal/repos", "events_url": "https://api.github.com/users/tilakrayal/events{/privacy}", "received_events_url": "https://api.github.com/users/tilakrayal/received_events", "type": "User", "site_admin": false } ]
null
[ "@dwzdtx,\r\n**TF.gradients** : \r\n`tf.gradients` is only valid in a graph context. In particular, it is valid in the context of a `tf.function` wrapper, where code is executing as a graph.\r\n\r\n```\r\[email protected]\r\ndef example():\r\n a = tf.constant(0.)\r\n b = 2 * a\r\n return tf.gradients(a + b, [a, b], stop_gradients=[a, b])\r\nexample()\r\n```\r\n**tf.GradientTape** :\r\n\r\nTensorFlow provides the **tf.GradientTape** API for automatic differentiation. TensorFlow \"records\" relevant operations executed inside the context of a `tf.GradientTape` onto a \"tape\". TensorFlow then uses that tape to compute the gradients of a \"recorded\" computation using reverse mode differentiation. `tf.GradientTape not really required tf.function wrapper. It automatically runs in Graph mode.`\r\n\r\n```\r\nx = tf.constant(3.0)\r\nwith tf.GradientTape() as g:\r\n g.watch(x)\r\n y = x * x\r\ndy_dx = g.gradient(y, x)\r\nprint(dy_dx)\r\n```\r\n\r\nAlso please provide the complete code and the tensorflow version you are using which helps to debug the issue. Thank you!", "This issue is stale because it has been open for 7 days with no activity. It will be closed if no further activity occurs. Thank you.", "This issue was closed because it has been inactive for 7 days since being marked as stale. Please reopen if you'd like to work on this further.", "Are you satisfied with the resolution of your issue?\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=Yes&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/60266\">Yes</a>\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=No&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/60266\">No</a>\n" ]
2023-04-08T07:24:56
2023-04-25T01:54:37
2023-04-25T01:54:35
NONE
null
null
null
Please go to Stack Overflow for help and support: https://stackoverflow.com/questions/tagged/tensorflow If you open a GitHub issue, here is our policy: 1. It must be a bug, a feature request, or a significant problem with the documentation (for small docs fixes please send a PR instead). 2. The form below must be filled out. 3. It shouldn't be a TensorBoard issue. Those go [here](https://github.com/tensorflow/tensorboard/issues). **Here's why we have that policy**: TensorFlow developers respond to issues. We want to focus on work that benefits the whole community, e.g., fixing bugs and adding features. Support only helps individuals. GitHub also notifies thousands of people when issues are filed. We want them to see you communicating an interesting problem, rather than being redirected to Stack Overflow. ------------------------ ### System information - **Have I written custom code (as opposed to using a stock example script provided in TensorFlow)**: - **OS Platform and Distribution (e.g., Linux Ubuntu 16.04)**: - **Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on a mobile device**: - **TensorFlow installed from (source or binary)**: - **TensorFlow version (use command below)**: - **Python version**: - **Bazel version (if compiling from source)**: - **GCC/Compiler version (if compiling from source)**: - **CUDA/cuDNN version**: - **GPU model and memory**: - **Exact command to reproduce**: You can collect some of this information using our environment capture script: https://github.com/tensorflow/tensorflow/tree/master/tools/tf_env_collect.sh You can obtain the TensorFlow version with: ```bash python -c "import tensorflow as tf; print(tf.version.GIT_VERSION, tf.version.VERSION)" ``` ### Describe the problem Describe the problem clearly here. Be sure to convey here why it's a bug in TensorFlow or a feature request. ### Source code / logs Include any logs or source code that would be helpful to diagnose the problem. If including tracebacks, please include the full traceback. Large logs and files should be attached. Try to provide a reproducible test case that is the bare minimum necessary to generate the problem.
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/60266/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/60266/timeline
null
completed
false
https://api.github.com/repos/tensorflow/tensorflow/issues/60264
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/60264/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/60264/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/60264/events
https://github.com/tensorflow/tensorflow/issues/60264
1,658,796,681
I_kwDOArmXAs5i3zqJ
60,264
Cannot compile TensorFlow 2.10 with GPu support on Windows
{ "login": "Rayndell", "id": 40670939, "node_id": "MDQ6VXNlcjQwNjcwOTM5", "avatar_url": "https://avatars.githubusercontent.com/u/40670939?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Rayndell", "html_url": "https://github.com/Rayndell", "followers_url": "https://api.github.com/users/Rayndell/followers", "following_url": "https://api.github.com/users/Rayndell/following{/other_user}", "gists_url": "https://api.github.com/users/Rayndell/gists{/gist_id}", "starred_url": "https://api.github.com/users/Rayndell/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Rayndell/subscriptions", "organizations_url": "https://api.github.com/users/Rayndell/orgs", "repos_url": "https://api.github.com/users/Rayndell/repos", "events_url": "https://api.github.com/users/Rayndell/events{/privacy}", "received_events_url": "https://api.github.com/users/Rayndell/received_events", "type": "User", "site_admin": false }
[ { "id": 386191887, "node_id": "MDU6TGFiZWwzODYxOTE4ODc=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/stat:awaiting%20response", "name": "stat:awaiting response", "color": "f4b400", "default": false, "description": "Status - Awaiting response from author" }, { "id": 473173351, "node_id": "MDU6TGFiZWw0NzMxNzMzNTE=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/type:build/install", "name": "type:build/install", "color": "159b2e", "default": false, "description": "Build and install issues" }, { "id": 1188421838, "node_id": "MDU6TGFiZWwxMTg4NDIxODM4", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/subtype:windows", "name": "subtype:windows", "color": "b619ea", "default": false, "description": "Windows Build/Installation Issues" }, { "id": 4511033337, "node_id": "LA_kwDOArmXAs8AAAABDODn-Q", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/TF%202.10", "name": "TF 2.10", "color": "C15088", "default": false, "description": "" } ]
closed
false
{ "login": "SuryanarayanaY", "id": 116063290, "node_id": "U_kgDOBur8Og", "avatar_url": "https://avatars.githubusercontent.com/u/116063290?v=4", "gravatar_id": "", "url": "https://api.github.com/users/SuryanarayanaY", "html_url": "https://github.com/SuryanarayanaY", "followers_url": "https://api.github.com/users/SuryanarayanaY/followers", "following_url": "https://api.github.com/users/SuryanarayanaY/following{/other_user}", "gists_url": "https://api.github.com/users/SuryanarayanaY/gists{/gist_id}", "starred_url": "https://api.github.com/users/SuryanarayanaY/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/SuryanarayanaY/subscriptions", "organizations_url": "https://api.github.com/users/SuryanarayanaY/orgs", "repos_url": "https://api.github.com/users/SuryanarayanaY/repos", "events_url": "https://api.github.com/users/SuryanarayanaY/events{/privacy}", "received_events_url": "https://api.github.com/users/SuryanarayanaY/received_events", "type": "User", "site_admin": false }
[ { "login": "SuryanarayanaY", "id": 116063290, "node_id": "U_kgDOBur8Og", "avatar_url": "https://avatars.githubusercontent.com/u/116063290?v=4", "gravatar_id": "", "url": "https://api.github.com/users/SuryanarayanaY", "html_url": "https://github.com/SuryanarayanaY", "followers_url": "https://api.github.com/users/SuryanarayanaY/followers", "following_url": "https://api.github.com/users/SuryanarayanaY/following{/other_user}", "gists_url": "https://api.github.com/users/SuryanarayanaY/gists{/gist_id}", "starred_url": "https://api.github.com/users/SuryanarayanaY/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/SuryanarayanaY/subscriptions", "organizations_url": "https://api.github.com/users/SuryanarayanaY/orgs", "repos_url": "https://api.github.com/users/SuryanarayanaY/repos", "events_url": "https://api.github.com/users/SuryanarayanaY/events{/privacy}", "received_events_url": "https://api.github.com/users/SuryanarayanaY/received_events", "type": "User", "site_admin": false } ]
null
[ "Oh, and I have already tried some workarounds, like creating a CUDNN_INSTALL_PATH environment variable and enablind the Developer mode, like suggested in this post : https://discuss.tensorflow.org/t/error-building-tensorflow-2-8-in-windows-10/7984", "The error message you are seeing suggests that there is an issue with the LLVM project in your TensorFlow build.\r\n\r\nHere are some possible steps you can try to resolve the error:\r\n\r\nCheck your LLVM version: TensorFlow 2.10 requires LLVM 9.0, which you can download from the LLVM website. Make sure to download the correct version of LLVM that matches your system.\r\n\r\nCheck your Bazel version: Make sure that you have installed the correct version of Bazel that matches the TensorFlow version you are trying to build. You can find the required Bazel version in the TensorFlow documentation.\r\n\r\nClean the Bazel cache: Try cleaning the Bazel cache by running \"bazel clean\" in your TensorFlow source directory. This will clear any cached build artifacts that may be causing issues.\r\n\r\nRebuild the LLVM project: Try rebuilding the LLVM project by running \"bazel build //external:llvm-project\" in your TensorFlow source directory. This will rebuild the LLVM project from scratch.\r\n\r\nRebuild TensorFlow: Once you have rebuilt the LLVM project, try rebuilding TensorFlow by running \"bazel build --config=opt //tensorflow/tools/pip_package:build_pip_package\" in your TensorFlow source directory. This will create a new TensorFlow pip package with GPU support.", "Thank you very much for your answer.\r\n\r\nI'm using Bazel 5.1.0, which is the correct version that should be used with TF 2.10.\r\nI installed LLVM 9.0 on my system, however it does not seem to change anything (LLVM install folder has been added to the Windows Path) as it still tries to fetch the llvm project.\r\nFinally, i tried building the llvm project manually with the bazel command and had this error:\r\n\r\nERROR: D:/tensorflow/tensorflow/WORKSPACE:15:14: in llvm_configure rule //external:llvm-project: Found reference to a workspace rule in a context where a build rule was expected; probably a reference to a target in that external repository, properly specified as @reponame//path/to/package:target, should have been specified by the requesting rule.\r\n\r\nA bazel clean did not help.", "I have some updates. After some further manual cleaning another error came out:\r\n\r\nERROR: An error occurred during the fetch of repository 'envoy_api':\r\n Traceback (most recent call last):\r\n File \"D:/tensorflow/bazel-out/zfk46uyn/external/bazel_tools/tools/build_defs/repo/http.bzl\", line 100, column 45, in _http_archive_impl\r\n download_info = ctx.download_and_extract(\r\nError in download_and_extract: java.io.IOException: Error downloading [https://github.com/envoyproxy/data-plane-api/archive/c83ed7ea9eb5fb3b93d1ad52b59750f1958b8bde.tar.gz] to D:/tensorflow/bazel-out/zfk46uyn/external/envoy_api/temp17372839701998073658/c83ed7ea9eb5fb3b93d1ad52b59750f1958b8bde.tar.gz: Unknown host: codeload.github.com\r\n\r\nSo it seems I have troubles fetching the envoy_api project now... In general I also have a lot of warnings stating that files were not found when trying to download some projects:\r\n\r\nWARNING: Download from https://storage.googleapis.com/mirror.tensorflow.org/github.com/tensorflow/runtime/archive/6ca793b5d862ef6c50f242d77a811f06cce9b60a.tar.gz failed: class java.io.FileNotFoundException GET returned 404 Not Found\r\nWARNING: Download from https://storage.googleapis.com/mirror.tensorflow.org/github.com/llvm/llvm-project/archive/0538e5431afdb1fa05bdcedf70ee502ccfcd112a.tar.gz failed: class java.io.FileNotFoundException GET returned 404 Not Found\r\nWARNING: Download from https://github.com/envoyproxy/data-plane-api/archive/c83ed7ea9eb5fb3b93d1ad52b59750f1958b8bde.tar.gz failed: class com.google.devtools.build.lib.bazel.repository.downloader.UnrecoverableHttpException Unknown host: codeload.github.com", "You can find the download link for the c83ed7ea9eb5fb3b93d1ad52b59750f1958b8bde.tar.gz file in the error message. Download the file and extract it to the D:/tensorflow/bazel-out/zfk46uyn/external/envoy_api directory.\r\n\r\nOnce the file is in the correct directory, try running the build command again and see if the issue is resolved.\r\nI'm afraid if this does not work, it may either be a network issue (your ISP forbids you from visiting the urls) or a bazel issue.", "So, I am progressing a little bit. Basically I had troubles creating symlinks under my account for some reason. I started from the beginning from a fresh Windows account on my machine and this solved it.\r\n\r\nHowever, I am still running into issues when linking the project:\r\n\r\nERROR: D:/tensorflow/tensorflow/tensorflow/BUILD:1034:21: Linking tensorflow/libtensorflow_framework.so.2.10.1 failed: (Exit 1189): link.exe failed: error executing command\r\n cd /d D:/tensorflow/bazel-out/zfk46uyn/execroot/org_tensorflow\r\n SET INCLUDE=C:\\Program Files\\Microsoft Visual Studio\\2022\\Professional\\VC\\Tools\\MSVC\\14.34.31933\\include;C:\\Program Files\\Microsoft Visual Studio\\2022\\Professional\\VC\\Tools\\MSVC\\14.34.31933\\ATLMFC\\include;C:\\Program Files\\Microsoft Visual Studio\\2022\\Professional\\VC\\Auxiliary\\VS\\include;C:\\Program Files (x86)\\Windows Kits\\10\\include\\10.0.22000.0\\ucrt;C:\\Program Files (x86)\\Windows Kits\\10\\\\include\\10.0.22000.0\\\\um;C:\\Program Files (x86)\\Windows Kits\\10\\\\include\\10.0.22000.0\\\\shared;C:\\Program Files (x86)\\Windows Kits\\10\\\\include\\10.0.22000.0\\\\winrt;C:\\Program Files (x86)\\Windows Kits\\10\\\\include\\10.0.22000.0\\\\cppwinrt;C:\\Program Files (x86)\\Windows Kits\\NETFXSDK\\4.8\\include\\um\r\n SET LIB=C:\\Program Files\\Microsoft Visual Studio\\2022\\Professional\\VC\\Tools\\MSVC\\14.34.31933\\ATLMFC\\lib\\x64;C:\\Program Files\\Microsoft Visual Studio\\2022\\Professional\\VC\\Tools\\MSVC\\14.34.31933\\lib\\x64;C:\\Program Files (x86)\\Windows Kits\\NETFXSDK\\4.8\\lib\\um\\x64;C:\\Program Files (x86)\\Windows Kits\\10\\lib\\10.0.22000.0\\ucrt\\x64;C:\\Program Files (x86)\\Windows Kits\\10\\\\lib\\10.0.22000.0\\\\um\\x64\r\n SET PATH=C:\\Program Files\\Microsoft Visual Studio\\2022\\Professional\\VC\\Tools\\MSVC\\14.34.31933\\bin\\HostX64\\x64;C:\\Program Files\\Microsoft Visual Studio\\2022\\Professional\\Common7\\IDE\\VC\\VCPackages;C:\\Program Files\\Microsoft Visual Studio\\2022\\Professional\\Common7\\IDE\\CommonExtensions\\Microsoft\\TestWindow;C:\\Program Files\\Microsoft Visual Studio\\2022\\Professional\\Common7\\IDE\\CommonExtensions\\Microsoft\\TeamFoundation\\Team Explorer;C:\\Program Files\\Microsoft Visual Studio\\2022\\Professional\\MSBuild\\Current\\bin\\Roslyn;C:\\Program Files\\Microsoft Visual Studio\\2022\\Professional\\Team Tools\\Performance Tools\\x64;C:\\Program Files\\Microsoft Visual Studio\\2022\\Professional\\Team Tools\\Performance Tools;C:\\Program Files (x86)\\Microsoft Visual Studio\\Shared\\Common\\VSPerfCollectionTools\\vs2019\\\\x64;C:\\Program Files (x86)\\Microsoft Visual Studio\\Shared\\Common\\VSPerfCollectionTools\\vs2019\\;C:\\Program Files (x86)\\Microsoft SDKs\\Windows\\v10.0A\\bin\\NETFX 4.8 Tools\\x64\\;C:\\Program Files\\Microsoft Visual Studio\\2022\\Professional\\Common7\\IDE\\CommonExtensions\\Microsoft\\FSharp\\Tools;C:\\Program Files (x86)\\Windows Kits\\10\\bin\\10.0.22000.0\\\\x64;C:\\Program Files (x86)\\Windows Kits\\10\\bin\\\\x64;C:\\Program Files\\Microsoft Visual Studio\\2022\\Professional\\\\MSBuild\\Current\\Bin\\amd64;C:\\Windows\\Microsoft.NET\\Framework64\\v4.0.30319;C:\\Program Files\\Microsoft Visual Studio\\2022\\Professional\\Common7\\IDE\\;C:\\Program Files\\Microsoft Visual Studio\\2022\\Professional\\Common7\\Tools\\;;C:\\Windows\\system32;C:\\Program Files\\Microsoft Visual Studio\\2022\\Professional\\Common7\\IDE\\CommonExtensions\\Microsoft\\CMake\\CMake\\bin;C:\\Program Files\\Microsoft Visual Studio\\2022\\Professional\\Common7\\IDE\\CommonExtensions\\Microsoft\\CMake\\Ninja;C:\\Program Files\\Microsoft Visual Studio\\2022\\Professional\\Common7\\IDE\\VC\\Linux\\bin\\ConnectionManagerExe\r\n SET PWD=/proc/self/cwd\r\n SET RUNFILES_MANIFEST_ONLY=1\r\n SET TEMP=C:\\Users\\AURELI~1\\AppData\\Local\\Temp\r\n SET TMP=C:\\Users\\AURELI~1\\AppData\\Local\\Temp\r\n C:\\Program Files\\Microsoft Visual Studio\\2022\\Professional\\VC\\Tools\\MSVC\\14.34.31933\\bin\\HostX64\\x64\\link.exe @bazel-out/x64_windows-opt-exec-50AE0418/bin/tensorflow/libtensorflow_framework.so.2.10.1-2.params\r\n# Configuration: 235f51f52e7e1d2ff49596414691042bdab9491882365c09175bc46cf2ee6814\r\n# Execution platform: @local_execution_config_platform//:platform\r\nLINK : warning LNK4044: option '/lm' non reconnue ; ignorée\r\nLINK : fatal error LNK1189: limite de 65535 objets dépassée pour la bibliothèque\r\nTarget //tensorflow:tensorflow_cc.dll failed to build\r\n\r\nWhat I understood from the last LINK error (it is in french, it means \"Link error 1189 library limit of 65535 objects exceeded\") is that MSVC is trying to create a dll or a lib with too many objects in it. As I understood it is a MSVC limitation, however it is strange I did not encounter this error before, since I previously built the 2.4 TF version without any of this type.\r\n\r\nSo, is there a means to overcome this limitation (seems unlikely), or to prevent TF from putting too many objects in the binaries? For example by choosing which objects to exclude from the compilation (I certainly do not need all that exists in the TensorFlow release)?", "@Rayndell ,\r\n\r\nCould you please cross check with the tested configuration for TF2.10 versions (CUDA=11.2 and cuDNN=8.1) and let us know if the build has any problem. We can't guarantee that CUDA 11.8 works with Tf2.10v or not. But if the build fails with CUDA-11.2 then definitely we will have a look .\r\n\r\nThanks!", "Thanks for the response. Actually I succeeded by downgrading to the 2.7 version (haven't tested 2.8 and 2.9) and using Python 3.9. The built went well with CUDA 11.8. I am not sure if I will have the time to re-test the 2.10 build with lower versions of CUDA though.", "@Rayndell ,\r\n\r\nHigher CUDA versions may also work if taken care of backward compatibility.Since we have tested configurations and also documented them we recommend users to follow same and we guarantee that they work and if not will be taken care by us.\r\n\r\nIn case your purpose resolved can we mark it as closed ? Please spare some time to close the issue and in future if have any problems please feel free to open a ticket. Thanks!\r\n\r\n", "Are you satisfied with the resolution of your issue?\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=Yes&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/60264\">Yes</a>\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=No&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/60264\">No</a>\n" ]
2023-04-07T13:16:27
2024-05-15T14:12:10
2023-04-27T13:25:14
NONE
null
null
null
<details><summary>Click to expand!</summary> ### Issue Type Build/Install ### Have you reproduced the bug with TF nightly? No ### Source source ### Tensorflow Version tf 2.10 ### Custom Code No ### OS Platform and Distribution Windows Server 2016 ### Mobile device _No response_ ### Python version 3.8.8 ### Bazel version 5.1.0 ### GCC/Compiler version _No response_ ### CUDA/cuDNN version 11.8/8.6 ### GPU model and memory Nvidia GeForce GTX 1080 Ti ### Current Behaviour? ```shell I am running into issues with bazel when trying to compile TensorFlow 2.10 with CUDA 11.8. I know that this configuration has not been tested, but I need to compile TF with GPU support on native Windows since we are integrating it into our software in my company. Hence the 2.10 version which is the last one with native Windows GPU support. I build against CUDA 11.8 since it is one that support the latest Nvidia GPUs. I used Bazel 5.1.0 since it is the one that apparently should be used with TensorFlow 2.10. Basically, everything went fine with the configuration until I try to lauch bazel with the following command: bazel --output_user_root=D:/TensorFlow/bazel-out build --config=opt --config=cuda --define=no_tensorflow_py_deps=true //tensorflow/tools/pip_package:build_pip_package Before that everything went well with the configure.py script, which automatically found Python and CUDA 11.8. The first error message I get is this one : ERROR: D:/tensorflow/tensorflow/WORKSPACE:15:14: fetching llvm_configure rule //external:llvm-project File "D:/tensorflow/bazel-out/zfk46uyn/external/llvm-raw/utils/bazel/configure.bzl", line 74, column 25, in _llvm_configure_impl _overlay_directories(repository_ctx) File "D:/tensorflow/bazel-out/zfk46uyn/external/llvm-raw/utils/bazel/configure.bzl", line 63, column 13, in _overlay_directories fail(("Failed to execute overlay script: '{cmd}'\n" + Error in fail: Failed to execute overlay script: 'C:/Python38/python.exe D:/tensorflow/bazel-out/zfk46uyn/external/llvm-raw/utils/bazel/overlay_directories.py --src D:/tensorflow/bazel-out/zfk46uyn/external/llvm-raw --overlay D:/tensorflow/bazel-out/zfk46uyn/external/llvm-raw/utils/bazel/llvm-project-overlay --target .' Everything subsequent error seem to depend on that first error. I added the full log to this message. Many thanks for your kind help. ``` ### Standalone code to reproduce the issue ```shell git clone https://github.com/tensorflow/tensorflow.git cd tensorflow git checkout r2.10 python ./configure.py bazel --output_user_root=D:/TensorFlow/bazel-out build --config=opt --config=cuda --define=no_tensorflow_py_deps=true //tensorflow/tools/pip_package:build_pip_package ``` ### Relevant log output ```shell WARNING: The following configs were expanded more than once: [cuda]. For repeatable flags, repeats are counted twice and may lead to unexpected behavior. INFO: Options provided by the client: Inherited 'common' options: --isatty=1 --terminal_columns=120 INFO: Reading rc options for 'build' from d:\tensorflow\tensorflow\.bazelrc: Inherited 'common' options: --experimental_repo_remote_exec INFO: Options provided by the client: 'build' options: --python_path=C:/Python38/python.exe INFO: Reading rc options for 'build' from d:\tensorflow\tensorflow\.bazelrc: 'build' options: --define framework_shared_object=true --define=use_fast_cpp_protos=true --define=allow_oversize_protos=true --spawn_strategy=standalone -c opt --announce_rc --define=grpc_no_ares=true --noincompatible_remove_legacy_whole_archive --enable_platform_specific_config --define=with_xla_support=true --config=short_logs --config=v2 --define=no_aws_support=true --define=no_hdfs_support=true --experimental_cc_shared_library --experimental_link_static_libraries_once=false INFO: Reading rc options for 'build' from d:\tensorflow\tensorflow\.tf_configure.bazelrc: 'build' options: --action_env PYTHON_BIN_PATH=C:/Python38/python.exe --action_env PYTHON_LIB_PATH=C:/Python38/lib/site-packages --python_path=C:/Python38/python.exe --action_env CUDA_TOOLKIT_PATH=C:/Program Files/NVIDIA GPU Computing Toolkit/CUDA/v11.8 --action_env CUDNN_INSTALL_PATH=C:/Program Files/NVIDIA GPU Computing Toolkit/CUDA/v11.8 --action_env TF_CUDA_COMPUTE_CAPABILITIES=3.5,5.2,6.1,7.0,7.5,8.6,8.9 --config=cuda --copt=/d2ReducedOptimizeHugeFunctions --host_copt=/d2ReducedOptimizeHugeFunctions INFO: Reading rc options for 'build' from d:\tensorflow\tensorflow\.bazelrc: 'build' options: --deleted_packages=tensorflow/compiler/mlir/tfrt,tensorflow/compiler/mlir/tfrt/benchmarks,tensorflow/compiler/mlir/tfrt/jit/python_binding,tensorflow/compiler/mlir/tfrt/jit/transforms,tensorflow/compiler/mlir/tfrt/python_tests,tensorflow/compiler/mlir/tfrt/tests,tensorflow/compiler/mlir/tfrt/tests/ir,tensorflow/compiler/mlir/tfrt/tests/analysis,tensorflow/compiler/mlir/tfrt/tests/jit,tensorflow/compiler/mlir/tfrt/tests/lhlo_to_tfrt,tensorflow/compiler/mlir/tfrt/tests/lhlo_to_jitrt,tensorflow/compiler/mlir/tfrt/tests/tf_to_corert,tensorflow/compiler/mlir/tfrt/tests/tf_to_tfrt_data,tensorflow/compiler/mlir/tfrt/tests/saved_model,tensorflow/compiler/mlir/tfrt/transforms/lhlo_gpu_to_tfrt_gpu,tensorflow/core/runtime_fallback,tensorflow/core/runtime_fallback/conversion,tensorflow/core/runtime_fallback/kernel,tensorflow/core/runtime_fallback/opdefs,tensorflow/core/runtime_fallback/runtime,tensorflow/core/runtime_fallback/util,tensorflow/core/tfrt/common,tensorflow/core/tfrt/eager,tensorflow/core/tfrt/eager/backends/cpu,tensorflow/core/tfrt/eager/backends/gpu,tensorflow/core/tfrt/eager/core_runtime,tensorflow/core/tfrt/eager/cpp_tests/core_runtime,tensorflow/core/tfrt/gpu,tensorflow/core/tfrt/run_handler_thread_pool,tensorflow/core/tfrt/runtime,tensorflow/core/tfrt/saved_model,tensorflow/core/tfrt/graph_executor,tensorflow/core/tfrt/saved_model/tests,tensorflow/core/tfrt/tpu,tensorflow/core/tfrt/utils INFO: Found applicable config definition build:short_logs in file d:\tensorflow\tensorflow\.bazelrc: --output_filter=DONT_MATCH_ANYTHING INFO: Found applicable config definition build:v2 in file d:\tensorflow\tensorflow\.bazelrc: --define=tf_api_version=2 --action_env=TF2_BEHAVIOR=1 INFO: Found applicable config definition build:cuda in file d:\tensorflow\tensorflow\.bazelrc: --repo_env TF_NEED_CUDA=1 --crosstool_top=@local_config_cuda//crosstool:toolchain --@local_config_cuda//:enable_cuda INFO: Found applicable config definition build:opt in file d:\tensorflow\tensorflow\.tf_configure.bazelrc: --copt=/arch:AVX --host_copt=/arch:AVX INFO: Found applicable config definition build:cuda in file d:\tensorflow\tensorflow\.bazelrc: --repo_env TF_NEED_CUDA=1 --crosstool_top=@local_config_cuda//crosstool:toolchain --@local_config_cuda//:enable_cuda INFO: Found applicable config definition build:windows in file d:\tensorflow\tensorflow\.bazelrc: --copt=/W0 --host_copt=/W0 --copt=/Zc:__cplusplus --host_copt=/Zc:__cplusplus --copt=/D_USE_MATH_DEFINES --host_copt=/D_USE_MATH_DEFINES --features=compiler_param_file --copt=/d2ReducedOptimizeHugeFunctions --host_copt=/d2ReducedOptimizeHugeFunctions --cxxopt=/std:c++17 --host_cxxopt=/std:c++17 --config=monolithic --copt=-DWIN32_LEAN_AND_MEAN --host_copt=-DWIN32_LEAN_AND_MEAN --copt=-DNOGDI --host_copt=-DNOGDI --copt=/experimental:preprocessor --host_copt=/experimental:preprocessor --linkopt=/DEBUG --host_linkopt=/DEBUG --linkopt=/OPT:REF --host_linkopt=/OPT:REF --linkopt=/OPT:ICF --host_linkopt=/OPT:ICF --verbose_failures --features=compiler_param_file --distinct_host_configuration=false INFO: Found applicable config definition build:monolithic in file d:\tensorflow\tensorflow\.bazelrc: --define framework_shared_object=false --experimental_link_static_libraries_once=false INFO: Repository llvm-project instantiated at: D:/tensorflow/tensorflow/WORKSPACE:15:14: in <toplevel> D:/tensorflow/tensorflow/tensorflow/workspace2.bzl:889:21: in workspace D:/tensorflow/tensorflow/tensorflow/workspace2.bzl:527:15: in _tf_repositories D:/tensorflow/tensorflow/third_party/llvm/setup.bzl:22:19: in llvm_setup Repository rule llvm_configure defined at: D:/tensorflow/bazel-out/zfk46uyn/external/llvm-raw/utils/bazel/configure.bzl:84:33: in <toplevel> ERROR: An error occurred during the fetch of repository 'llvm-project': Traceback (most recent call last): File "D:/tensorflow/bazel-out/zfk46uyn/external/llvm-raw/utils/bazel/configure.bzl", line 74, column 25, in _llvm_configure_impl _overlay_directories(repository_ctx) File "D:/tensorflow/bazel-out/zfk46uyn/external/llvm-raw/utils/bazel/configure.bzl", line 63, column 13, in _overlay_directories fail(("Failed to execute overlay script: '{cmd}'\n" + Error in fail: Failed to execute overlay script: 'C:/Python38/python.exe D:/tensorflow/bazel-out/zfk46uyn/external/llvm-raw/utils/bazel/overlay_directories.py --src D:/tensorflow/bazel-out/zfk46uyn/external/llvm-raw --overlay D:/tensorflow/bazel-out/zfk46uyn/external/llvm-raw/utils/bazel/llvm-project-overlay --target .' Exited with code 1 stdout: stderr: Traceback (most recent call last): File "D:/tensorflow/bazel-out/zfk46uyn/external/llvm-raw/utils/bazel/overlay_directories.py", line 92, in <module> main(parse_arguments()) File "D:/tensorflow/bazel-out/zfk46uyn/external/llvm-raw/utils/bazel/overlay_directories.py", line 80, in main _symlink_abs(os.path.join(args.overlay, relpath), File "D:/tensorflow/bazel-out/zfk46uyn/external/llvm-raw/utils/bazel/overlay_directories.py", line 64, in _symlink_abs os.symlink(os.path.abspath(from_path), os.path.abspath(to_path)) OSError: [WinError 1314] Le client ne dispose pas dÆun privilÞge nÚcessaire: 'D:\\tensorflow\\bazel-out\\zfk46uyn\\external\\llvm-raw\\utils\\bazel\\llvm-project-overlay\\.bazelignore' -> 'D:\\tensorflow\\bazel-out\\zfk46uyn\\external\\llvm-project\\.bazelignore' ERROR: D:/tensorflow/tensorflow/WORKSPACE:15:14: fetching llvm_configure rule //external:llvm-project: Traceback (most recent call last): File "D:/tensorflow/bazel-out/zfk46uyn/external/llvm-raw/utils/bazel/configure.bzl", line 74, column 25, in _llvm_configure_impl _overlay_directories(repository_ctx) File "D:/tensorflow/bazel-out/zfk46uyn/external/llvm-raw/utils/bazel/configure.bzl", line 63, column 13, in _overlay_directories fail(("Failed to execute overlay script: '{cmd}'\n" + Error in fail: Failed to execute overlay script: 'C:/Python38/python.exe D:/tensorflow/bazel-out/zfk46uyn/external/llvm-raw/utils/bazel/overlay_directories.py --src D:/tensorflow/bazel-out/zfk46uyn/external/llvm-raw --overlay D:/tensorflow/bazel-out/zfk46uyn/external/llvm-raw/utils/bazel/llvm-project-overlay --target .' Exited with code 1 stdout: stderr: Traceback (most recent call last): File "D:/tensorflow/bazel-out/zfk46uyn/external/llvm-raw/utils/bazel/overlay_directories.py", line 92, in <module> main(parse_arguments()) File "D:/tensorflow/bazel-out/zfk46uyn/external/llvm-raw/utils/bazel/overlay_directories.py", line 80, in main _symlink_abs(os.path.join(args.overlay, relpath), File "D:/tensorflow/bazel-out/zfk46uyn/external/llvm-raw/utils/bazel/overlay_directories.py", line 64, in _symlink_abs os.symlink(os.path.abspath(from_path), os.path.abspath(to_path)) OSError: [WinError 1314] Le client ne dispose pas dÆun privilÞge nÚcessaire: 'D:\\tensorflow\\bazel-out\\zfk46uyn\\external\\llvm-raw\\utils\\bazel\\llvm-project-overlay\\.bazelignore' -> 'D:\\tensorflow\\bazel-out\\zfk46uyn\\external\\llvm-project\\.bazelignore' INFO: Repository flatbuffers instantiated at: D:/tensorflow/tensorflow/WORKSPACE:15:14: in <toplevel> D:/tensorflow/tensorflow/tensorflow/workspace2.bzl:882:28: in workspace D:/tensorflow/tensorflow/tensorflow/workspace2.bzl:61:16: in _initialize_third_party D:/tensorflow/tensorflow/third_party/flatbuffers/workspace.bzl:6:20: in repo D:/tensorflow/tensorflow/third_party/repo.bzl:136:21: in tf_http_archive Repository rule _tf_http_archive defined at: D:/tensorflow/tensorflow/third_party/repo.bzl:89:35: in <toplevel> ERROR: D:/tensorflow/tensorflow/tensorflow/tools/pip_package/BUILD:278:10: //tensorflow/tools/pip_package:build_pip_package depends on //tensorflow/compiler/mlir/tensorflow:gen_mlir_passthrough_op_py in repository @ which failed to fetch. no such package '@llvm-project//mlir': Failed to execute overlay script: 'C:/Python38/python.exe D:/tensorflow/bazel-out/zfk46uyn/external/llvm-raw/utils/bazel/overlay_directories.py --src D:/tensorflow/bazel-out/zfk46uyn/external/llvm-raw --overlay D:/tensorflow/bazel-out/zfk46uyn/external/llvm-raw/utils/bazel/llvm-project-overlay --target .' Exited with code 1 stdout: stderr: Traceback (most recent call last): File "D:/tensorflow/bazel-out/zfk46uyn/external/llvm-raw/utils/bazel/overlay_directories.py", line 92, in <module> main(parse_arguments()) File "D:/tensorflow/bazel-out/zfk46uyn/external/llvm-raw/utils/bazel/overlay_directories.py", line 80, in main _symlink_abs(os.path.join(args.overlay, relpath), File "D:/tensorflow/bazel-out/zfk46uyn/external/llvm-raw/utils/bazel/overlay_directories.py", line 64, in _symlink_abs os.symlink(os.path.abspath(from_path), os.path.abspath(to_path)) OSError: [WinError 1314] Le client ne dispose pas dÆun privilÞge nÚcessaire: 'D:\\tensorflow\\bazel-out\\zfk46uyn\\external\\llvm-raw\\utils\\bazel\\llvm-project-overlay\\.bazelignore' -> 'D:\\tensorflow\\bazel-out\\zfk46uyn\\external\\llvm-project\\.bazelignore' ERROR: Analysis of target '//tensorflow/tools/pip_package:build_pip_package' failed; build aborted: Analysis failed INFO: Elapsed time: 1.558s INFO: 0 processes. FAILED: Build did NOT complete successfully (38 packages loaded, 2 targets configured) currently loading: tensorflow/lite/python ... (2 packages) Fetching https://storage.googleapis.com/mirror.tensorflow.org/github.com/google/flatbuffers/archive/v2.0.6.tar.gz ``` </details>
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/60264/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/60264/timeline
null
completed
false
https://api.github.com/repos/tensorflow/tensorflow/issues/60263
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/60263/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/60263/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/60263/events
https://github.com/tensorflow/tensorflow/issues/60263
1,658,666,779
I_kwDOArmXAs5i3T8b
60,263
Windows bazel says python is not an executable when building
{ "login": "TurgutBababalim", "id": 107309614, "node_id": "U_kgDOBmVqLg", "avatar_url": "https://avatars.githubusercontent.com/u/107309614?v=4", "gravatar_id": "", "url": "https://api.github.com/users/TurgutBababalim", "html_url": "https://github.com/TurgutBababalim", "followers_url": "https://api.github.com/users/TurgutBababalim/followers", "following_url": "https://api.github.com/users/TurgutBababalim/following{/other_user}", "gists_url": "https://api.github.com/users/TurgutBababalim/gists{/gist_id}", "starred_url": "https://api.github.com/users/TurgutBababalim/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/TurgutBababalim/subscriptions", "organizations_url": "https://api.github.com/users/TurgutBababalim/orgs", "repos_url": "https://api.github.com/users/TurgutBababalim/repos", "events_url": "https://api.github.com/users/TurgutBababalim/events{/privacy}", "received_events_url": "https://api.github.com/users/TurgutBababalim/received_events", "type": "User", "site_admin": false }
[ { "id": 386191887, "node_id": "MDU6TGFiZWwzODYxOTE4ODc=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/stat:awaiting%20response", "name": "stat:awaiting response", "color": "f4b400", "default": false, "description": "Status - Awaiting response from author" }, { "id": 473173351, "node_id": "MDU6TGFiZWw0NzMxNzMzNTE=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/type:build/install", "name": "type:build/install", "color": "159b2e", "default": false, "description": "Build and install issues" }, { "id": 474725938, "node_id": "MDU6TGFiZWw0NzQ3MjU5Mzg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/stale", "name": "stale", "color": "d4c5f9", "default": false, "description": "This label marks the issue/pr stale - to be closed automatically if no activity" }, { "id": 1188421838, "node_id": "MDU6TGFiZWwxMTg4NDIxODM4", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/subtype:windows", "name": "subtype:windows", "color": "b619ea", "default": false, "description": "Windows Build/Installation Issues" }, { "id": 5206407904, "node_id": "LA_kwDOArmXAs8AAAABNlN64A", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/TF%202.12", "name": "TF 2.12", "color": "c5def5", "default": false, "description": "For issues related to Tensorflow 2.12" } ]
closed
false
{ "login": "synandi", "id": 98147397, "node_id": "U_kgDOBdmcRQ", "avatar_url": "https://avatars.githubusercontent.com/u/98147397?v=4", "gravatar_id": "", "url": "https://api.github.com/users/synandi", "html_url": "https://github.com/synandi", "followers_url": "https://api.github.com/users/synandi/followers", "following_url": "https://api.github.com/users/synandi/following{/other_user}", "gists_url": "https://api.github.com/users/synandi/gists{/gist_id}", "starred_url": "https://api.github.com/users/synandi/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/synandi/subscriptions", "organizations_url": "https://api.github.com/users/synandi/orgs", "repos_url": "https://api.github.com/users/synandi/repos", "events_url": "https://api.github.com/users/synandi/events{/privacy}", "received_events_url": "https://api.github.com/users/synandi/received_events", "type": "User", "site_admin": false }
[ { "login": "synandi", "id": 98147397, "node_id": "U_kgDOBdmcRQ", "avatar_url": "https://avatars.githubusercontent.com/u/98147397?v=4", "gravatar_id": "", "url": "https://api.github.com/users/synandi", "html_url": "https://github.com/synandi", "followers_url": "https://api.github.com/users/synandi/followers", "following_url": "https://api.github.com/users/synandi/following{/other_user}", "gists_url": "https://api.github.com/users/synandi/gists{/gist_id}", "starred_url": "https://api.github.com/users/synandi/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/synandi/subscriptions", "organizations_url": "https://api.github.com/users/synandi/orgs", "repos_url": "https://api.github.com/users/synandi/repos", "events_url": "https://api.github.com/users/synandi/events{/privacy}", "received_events_url": "https://api.github.com/users/synandi/received_events", "type": "User", "site_admin": false } ]
null
[ "The error message you are seeing suggests that Bazel is unable to locate the Python executable specified in the PATH environment variable.\r\n\r\nHere are a few things you can try to fix the issue:\r\n\r\n1. Verify that the Python executable is in your PATH: Make sure that the directory containing the Python executable is actually included in your PATH environment variable. You can verify this by running echo %PATH% in the Command Prompt and checking whether the directory containing the Python executable is listed. Next, Use the full path to the Python executable: Instead of relying on the PATH environment variable, you can try specifying the full path to the Python executable in the configure.py script. For example, you can try running python configure.py --interpreter=C:/Users/Asus/AppData/Local/Programs/Python/Python311/python.exe.\r\n\r\n2.Try using a different version of Python: It's possible that the version of Python you are using is not compatible with TensorFlow. You can try using a different version of Python (e.g., Python 3.7) and see if that resolves the issue and check your Bazel version: Make sure that you are using the correct version of Bazel that is compatible with TensorFlow 2.12. You can check the Bazel version requirements in the TensorFlow documentation.\r\n\r\nIf all fails, then try using a pre-built TensorFlow package: If you are still having issues building TensorFlow from source, you can try using a pre-built TensorFlow package instead. You can download pre-built TensorFlow packages for Windows from the TensorFlow website.", "Hi @TurgutBababalim, As per the official documentation, Tensorflow 2.12 is compatible with Bazel 5.3.0. Please try again with the supported versions. Kindly refer to the [tested build configurations](https://www.tensorflow.org/install/source_windows#cpu). Thank you! ", "This issue is stale because it has been open for 7 days with no activity. It will be closed if no further activity occurs. Thank you.", "This issue was closed because it has been inactive for 7 days since being marked as stale. Please reopen if you'd like to work on this further.", "Are you satisfied with the resolution of your issue?\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=Yes&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/60263\">Yes</a>\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=No&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/60263\">No</a>\n" ]
2023-04-07T10:51:38
2023-04-27T01:54:29
2023-04-27T01:54:27
NONE
null
null
null
<details><summary>Click to expand!</summary> ### Issue Type Build/Install ### Have you reproduced the bug with TF nightly? No ### Source source ### Tensorflow Version r2.12 ### Custom Code No ### OS Platform and Distribution Widnows 10 ### Mobile device Asus pc ### Python version 3.11 ### Bazel version 6.1.1 ### GCC/Compiler version msbuild 17.5.1+f6fdcf537 ### CUDA/cuDNN version _No response_ ### GPU model and memory _No response_ ### Current Behaviour? ```shell I'm trying to build c++ tflite for windows using bazel by following the [official documentation][1]. So far I've installed everything it want's me to and added them to `PATH`. Then I cloned the github repo and checked out to `r2.12` branch. Then I ran `python ./configure.py` and selected default for everything (said yes to override eigen strong inline). When doing so it declared that my python is located on `C:\Users\Asus\AppData\Local\Programs\Python\Python311\python.exe`. After that running `bazel build -c opt //tensorflow/lite:tensorflowlite` on the directory where I've cloned tensorflow in cmd casuses the below error: I checked whether python was there or not, it indeed is. Simply running `C:/Users/Asus/AppData/Local/Programs/Python/Python311/python.exe` in cmd indeed opens python. So I checked the internet for some solutions, I've removed the "python installers" from my system, added python to PATH, tried the same steps with tensorflow source zip instead of cloning it, nothing works. Some people suggested chaning some stuff inside the `py` directory of tensorflow but it didn't work aswell. Why is this happening? What causes bazel to not see python even though it's there? How can I fix this and get a build with windows? [1]: https://www.tensorflow.org/install/source_windows ``` ### Standalone code to reproduce the issue ```shell Steps I've followed: - run: `pip3 install -U six numpy wheel packaging pip3 install -U keras_preprocessing --no-deps` - Install bazel 6.1.1 and add it to PATH. - Install MSYS2 and add bin to PATH. - Install visual studio and setup the needed tools. -git clone https://github.com/tensorflow/tensorflow.git cd tensorflow - git checkout r2.12 - bazel build -c opt //tensorflow/lite:tensorflowlite ``` ### Relevant log output ```shell Starting local Bazel server and connecting to it... INFO: Options provided by the client: Inherited 'common' options: --isatty=1 --terminal_columns=117 INFO: Reading rc options for 'build' from c:\users\asus\desktop\tensorflow\.bazelrc: Inherited 'common' options: --experimental_repo_remote_exec INFO: Options provided by the client: 'build' options: --python_path=C:/Users/Asus/AppData/Local/Programs/Python/Python311/python.exe INFO: Reading rc options for 'build' from c:\users\asus\desktop\tensorflow\.bazelrc: 'build' options: --define framework_shared_object=true --define tsl_protobuf_header_only=true --define=use_fast_cpp_protos=true --define=allow_oversize_protos=true --spawn_strategy=standalone -c opt --announce_rc --define=grpc_no_ares=true --noincompatible_remove_legacy_whole_archive --enable_platform_specific_config --define=with_xla_support=true --config=short_logs --config=v2 --define=no_aws_support=true --define=no_hdfs_support=true --experimental_cc_shared_library --experimental_link_static_libraries_once=false --incompatible_enforce_config_setting_visibility INFO: Reading rc options for 'build' from c:\users\asus\desktop\tensorflow\.tf_configure.bazelrc: 'build' options: --action_env PYTHON_BIN_PATH=C:/Users/Asus/AppData/Local/Programs/Python/Python311/python.exe --action_env PYTHON_LIB_PATH=C:/Users/Asus/AppData/Local/Programs/Python/Python311/Lib/site-packages --python_path=C:/Users/Asus/AppData/Local/Programs/Python/Python311/python.exe --copt=/d2ReducedOptimizeHugeFunctions --host_copt=/d2ReducedOptimizeHugeFunctions --define=override_eigen_strong_inline=true INFO: Reading rc options for 'build' from c:\users\asus\desktop\tensorflow\.bazelrc: 'build' options: --deleted_packages=tensorflow/compiler/mlir/tfrt,tensorflow/compiler/mlir/tfrt/benchmarks,tensorflow/compiler/mlir/tfrt/jit/python_binding,tensorflow/compiler/mlir/tfrt/jit/transforms,tensorflow/compiler/mlir/tfrt/python_tests,tensorflow/compiler/mlir/tfrt/tests,tensorflow/compiler/mlir/tfrt/tests/ir,tensorflow/compiler/mlir/tfrt/tests/analysis,tensorflow/compiler/mlir/tfrt/tests/jit,tensorflow/compiler/mlir/tfrt/tests/lhlo_to_tfrt,tensorflow/compiler/mlir/tfrt/tests/lhlo_to_jitrt,tensorflow/compiler/mlir/tfrt/tests/tf_to_corert,tensorflow/compiler/mlir/tfrt/tests/tf_to_tfrt_data,tensorflow/compiler/mlir/tfrt/tests/saved_model,tensorflow/compiler/mlir/tfrt/transforms/lhlo_gpu_to_tfrt_gpu,tensorflow/core/runtime_fallback,tensorflow/core/runtime_fallback/conversion,tensorflow/core/runtime_fallback/kernel,tensorflow/core/runtime_fallback/opdefs,tensorflow/core/runtime_fallback/runtime,tensorflow/core/runtime_fallback/util,tensorflow/core/tfrt/eager,tensorflow/core/tfrt/eager/backends/cpu,tensorflow/core/tfrt/eager/backends/gpu,tensorflow/core/tfrt/eager/core_runtime,tensorflow/core/tfrt/eager/cpp_tests/core_runtime,tensorflow/core/tfrt/gpu,tensorflow/core/tfrt/run_handler_thread_pool,tensorflow/core/tfrt/runtime,tensorflow/core/tfrt/saved_model,tensorflow/core/tfrt/graph_executor,tensorflow/core/tfrt/saved_model/tests,tensorflow/core/tfrt/tpu,tensorflow/core/tfrt/utils INFO: Found applicable config definition build:short_logs in file c:\users\asus\desktop\tensorflow\.bazelrc: --output_filter=DONT_MATCH_ANYTHING INFO: Found applicable config definition build:v2 in file c:\users\asus\desktop\tensorflow\.bazelrc: --define=tf_api_version=2 --action_env=TF2_BEHAVIOR=1 INFO: Found applicable config definition build:windows in file c:\users\asus\desktop\tensorflow\.bazelrc: --copt=/W0 --host_copt=/W0 --copt=/Zc:__cplusplus --host_copt=/Zc:__cplusplus --copt=/D_USE_MATH_DEFINES --host_copt=/D_USE_MATH_DEFINES --features=compiler_param_file --copt=/d2ReducedOptimizeHugeFunctions --host_copt=/d2ReducedOptimizeHugeFunctions --cxxopt=/std:c++17 --host_cxxopt=/std:c++17 --config=monolithic --copt=-DWIN32_LEAN_AND_MEAN --host_copt=-DWIN32_LEAN_AND_MEAN --copt=-DNOGDI --host_copt=-DNOGDI --copt=/Zc:preprocessor --host_copt=/Zc:preprocessor --linkopt=/DEBUG --host_linkopt=/DEBUG --linkopt=/OPT:REF --host_linkopt=/OPT:REF --linkopt=/OPT:ICF --host_linkopt=/OPT:ICF --verbose_failures --features=compiler_param_file --distinct_host_configuration=false INFO: Found applicable config definition build:monolithic in file c:\users\asus\desktop\tensorflow\.bazelrc: --define framework_shared_object=false --define tsl_protobuf_header_only=false --experimental_link_static_libraries_once=false INFO: Repository local_config_python instantiated at: C:/users/asus/desktop/tensorflow/WORKSPACE:15:14: in <toplevel> C:/users/asus/desktop/tensorflow/tensorflow/workspace2.bzl:957:19: in workspace C:/users/asus/desktop/tensorflow/tensorflow/workspace2.bzl:104:21: in _tf_toolchains Repository rule python_configure defined at: C:/users/asus/desktop/tensorflow/third_party/py/python_configure.bzl:298:35: in <toplevel> ERROR: An error occurred during the fetch of repository 'local_config_python': Traceback (most recent call last): File "C:/users/asus/desktop/tensorflow/third_party/py/python_configure.bzl", line 271, column 40, in _python_autoconf_impl _create_local_python_repository(repository_ctx) File "C:/users/asus/desktop/tensorflow/third_party/py/python_configure.bzl", line 212, column 22, in _create_local_python_repository _check_python_bin(repository_ctx, python_bin) File "C:/users/asus/desktop/tensorflow/third_party/py/python_configure.bzl", line 145, column 25, in _check_python_bin auto_config_fail("--define %s='%s' is not executable. Is it the python binary?" % ( File "C:/users/asus/desktop/tensorflow/third_party/remote_config/common.bzl", line 12, column 9, in auto_config_fail fail("%sConfiguration Error:%s %s\n" % (red, no_color, msg)) Error in fail: Configuration Error: --define PYTHON_BIN_PATH='C:/Users/Asus/AppData/Local/Programs/Python/Python311/python.exe' is not executable. Is it the python binary? ERROR: C:/users/asus/desktop/tensorflow/WORKSPACE:15:14: fetching python_configure rule //external:local_config_python: Traceback (most recent call last): File "C:/users/asus/desktop/tensorflow/third_party/py/python_configure.bzl", line 271, column 40, in _python_autoconf_impl _create_local_python_repository(repository_ctx) File "C:/users/asus/desktop/tensorflow/third_party/py/python_configure.bzl", line 212, column 22, in _create_local_python_repository _check_python_bin(repository_ctx, python_bin) File "C:/users/asus/desktop/tensorflow/third_party/py/python_configure.bzl", line 145, column 25, in _check_python_bin auto_config_fail("--define %s='%s' is not executable. Is it the python binary?" % ( File "C:/users/asus/desktop/tensorflow/third_party/remote_config/common.bzl", line 12, column 9, in auto_config_fail fail("%sConfiguration Error:%s %s\n" % (red, no_color, msg)) Error in fail: Configuration Error: --define PYTHON_BIN_PATH='C:/Users/Asus/AppData/Local/Programs/Python/Python311/python.exe' is not executable. Is it the python binary? INFO: Repository local_execution_config_python instantiated at: C:/users/asus/desktop/tensorflow/WORKSPACE:15:14: in <toplevel> C:/users/asus/desktop/tensorflow/tensorflow/workspace2.bzl:957:19: in workspace C:/users/asus/desktop/tensorflow/tensorflow/workspace2.bzl:94:27: in _tf_toolchains C:/users/asus/desktop/tensorflow/tensorflow/tools/toolchains/remote_config/configs.bzl:6:28: in initialize_rbe_configs C:/users/asus/desktop/tensorflow/tensorflow/tools/toolchains/remote_config/rbe_config.bzl:158:27: in _tensorflow_local_config Repository rule local_python_configure defined at: C:/users/asus/desktop/tensorflow/third_party/py/python_configure.bzl:279:41: in <toplevel> INFO: Repository go_sdk instantiated at: C:/users/asus/desktop/tensorflow/WORKSPACE:23:14: in <toplevel> C:/users/asus/desktop/tensorflow/tensorflow/workspace0.bzl:134:20: in workspace C:/users/asus/_bazel_asus/ddsftcyc/external/com_github_grpc_grpc/bazel/grpc_extra_deps.bzl:36:27: in grpc_extra_deps C:/users/asus/_bazel_asus/ddsftcyc/external/io_bazel_rules_go/go/private/sdk.bzl:431:28: in go_register_toolchains C:/users/asus/_bazel_asus/ddsftcyc/external/io_bazel_rules_go/go/private/sdk.bzl:130:21: in go_download_sdk Repository rule _go_download_sdk defined at: C:/users/asus/_bazel_asus/ddsftcyc/external/io_bazel_rules_go/go/private/sdk.bzl:117:35: in <toplevel> ERROR: Analysis of target '//tensorflow/lite:tensorflowlite' failed; build aborted: Configuration Error: --define PYTHON_BIN_PATH='C:/Users/Asus/AppData/Local/Programs/Python/Python311/python.exe' is not executable. Is it the python binary? INFO: Elapsed time: 224.163s INFO: 0 processes. FAILED: Build did NOT complete successfully (32 packages loaded, 15 targets configured) ``` </details>
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/60263/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/60263/timeline
null
completed
false
https://api.github.com/repos/tensorflow/tensorflow/issues/60262
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/60262/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/60262/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/60262/events
https://github.com/tensorflow/tensorflow/issues/60262
1,658,315,549
I_kwDOArmXAs5i1-Md
60,262
Collected Tensorflow profiles are not recognized in Tensorboard
{ "login": "stefanbucur", "id": 281483, "node_id": "MDQ6VXNlcjI4MTQ4Mw==", "avatar_url": "https://avatars.githubusercontent.com/u/281483?v=4", "gravatar_id": "", "url": "https://api.github.com/users/stefanbucur", "html_url": "https://github.com/stefanbucur", "followers_url": "https://api.github.com/users/stefanbucur/followers", "following_url": "https://api.github.com/users/stefanbucur/following{/other_user}", "gists_url": "https://api.github.com/users/stefanbucur/gists{/gist_id}", "starred_url": "https://api.github.com/users/stefanbucur/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/stefanbucur/subscriptions", "organizations_url": "https://api.github.com/users/stefanbucur/orgs", "repos_url": "https://api.github.com/users/stefanbucur/repos", "events_url": "https://api.github.com/users/stefanbucur/events{/privacy}", "received_events_url": "https://api.github.com/users/stefanbucur/received_events", "type": "User", "site_admin": false }
[ { "id": 284285184, "node_id": "MDU6TGFiZWwyODQyODUxODQ=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/comp:tensorboard", "name": "comp:tensorboard", "color": "0052cc", "default": false, "description": "Tensorboard related issues" }, { "id": 404586594, "node_id": "MDU6TGFiZWw0MDQ1ODY1OTQ=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/stat:awaiting%20tensorflower", "name": "stat:awaiting tensorflower", "color": "f4b400", "default": false, "description": "Status - Awaiting response from tensorflower" }, { "id": 473172988, "node_id": "MDU6TGFiZWw0NzMxNzI5ODg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/type:bug", "name": "type:bug", "color": "159b2e", "default": false, "description": "Bug" }, { "id": 5206407904, "node_id": "LA_kwDOArmXAs8AAAABNlN64A", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/TF%202.12", "name": "TF 2.12", "color": "c5def5", "default": false, "description": "For issues related to Tensorflow 2.12" } ]
open
false
{ "login": "sachinprasadhs", "id": 73069040, "node_id": "MDQ6VXNlcjczMDY5MDQw", "avatar_url": "https://avatars.githubusercontent.com/u/73069040?v=4", "gravatar_id": "", "url": "https://api.github.com/users/sachinprasadhs", "html_url": "https://github.com/sachinprasadhs", "followers_url": "https://api.github.com/users/sachinprasadhs/followers", "following_url": "https://api.github.com/users/sachinprasadhs/following{/other_user}", "gists_url": "https://api.github.com/users/sachinprasadhs/gists{/gist_id}", "starred_url": "https://api.github.com/users/sachinprasadhs/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sachinprasadhs/subscriptions", "organizations_url": "https://api.github.com/users/sachinprasadhs/orgs", "repos_url": "https://api.github.com/users/sachinprasadhs/repos", "events_url": "https://api.github.com/users/sachinprasadhs/events{/privacy}", "received_events_url": "https://api.github.com/users/sachinprasadhs/received_events", "type": "User", "site_admin": false }
[ { "login": "sachinprasadhs", "id": 73069040, "node_id": "MDQ6VXNlcjczMDY5MDQw", "avatar_url": "https://avatars.githubusercontent.com/u/73069040?v=4", "gravatar_id": "", "url": "https://api.github.com/users/sachinprasadhs", "html_url": "https://github.com/sachinprasadhs", "followers_url": "https://api.github.com/users/sachinprasadhs/followers", "following_url": "https://api.github.com/users/sachinprasadhs/following{/other_user}", "gists_url": "https://api.github.com/users/sachinprasadhs/gists{/gist_id}", "starred_url": "https://api.github.com/users/sachinprasadhs/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sachinprasadhs/subscriptions", "organizations_url": "https://api.github.com/users/sachinprasadhs/orgs", "repos_url": "https://api.github.com/users/sachinprasadhs/repos", "events_url": "https://api.github.com/users/sachinprasadhs/events{/privacy}", "received_events_url": "https://api.github.com/users/sachinprasadhs/received_events", "type": "User", "site_admin": false } ]
null
[ "Seems we have encountered similar problems. @stefanbucur Can you find `events.out.tfevents.*` in the directory where `plugins` is located?", "The Tf profile is working well for me.\r\nBut I am not able to see any loss values in TensorBoard.\r\n", "> \r\n\r\nYes, here is the full directory contents:\r\n\r\n```\r\n$ ls -R logs/\r\nlogs/:\r\nfit\r\n\r\nlogs/fit:\r\n20230417-090906\r\n\r\nlogs/fit/20230417-090906:\r\nplugins train\r\n\r\nlogs/fit/20230417-090906/plugins:\r\nprofile\r\n\r\nlogs/fit/20230417-090906/plugins/profile:\r\n2023_04_17_09_09_10\r\n\r\nlogs/fit/20230417-090906/plugins/profile/2023_04_17_09_09_10:\r\nsaturn.xplane.pb\r\n\r\nlogs/fit/20230417-090906/train:\r\nevents.out.tfevents.1681736947.saturn.73263.0.v2\r\n```", "I must have done something right, now it works fine.", "Update: I was able to get it working, *under certain conditions*.\r\n\r\nIf I do a `$ tensorboard --logdir logs/` command, per the instructions in [the tutorial](https://www.tensorflow.org/tensorboard/tensorboard_profiling_keras), profiling will not work.\r\n\r\nIf instead I run `tensorboard` on the specific subdir that contains the profile (`$ tensorboard --logdir logs/fit/20230417-090906/`), then the profile will show up, but **only after I refresh the browser window once**. Once I refresh the browser window, and I access the profile tab, `*.hlo_proto.pb` files start showing up alongside the original `*.xplane.pb` profile.\r\n\r\nNote that refreshing the window won't fix it in the original case (opening the top-level `logs/` dir).\r\n\r\nJust a guess, but perhaps there is a regression in how tensorboard traverses the logs directory tree?" ]
2023-04-07T03:33:16
2023-04-17T13:24:33
null
NONE
null
null
null
<details><summary>Click to expand!</summary> ### Issue Type Bug ### Have you reproduced the bug with TF nightly? Yes ### Source source ### Tensorflow Version tf 2.13.0-dev20230406 ### Custom Code No ### OS Platform and Distribution Linux Ubuntu 22.04 ### Mobile device n/a ### Python version 3.9.16 ### Bazel version n/a ### GCC/Compiler version n/a ### CUDA/cuDNN version 11.8.0/8.6.0.163 ### GPU model and memory NVIDIA GeForce RTX 3080 Ti 12GiB ### Current Behaviour? I am following the tutorial at https://www.tensorflow.org/tutorials/quickstart/beginner I modified the code according to the instructions at https://www.tensorflow.org/tensorboard/tensorboard_profiling_keras in order to enable profiling for a range of batches during training. With this change, training seems to proceed as normal, with the logs indicating that a profiler session is created, and a profile is collected. The logs directory contains one non-empty `plugins/profile/<date>/<host>.xplane.pb` file. But when I run tensorboard (either main or tb-nightly) on the logs, it fails to detect a profile (the Profile tab is missing from the UI). I also confirm I ran `pip install -U tensorboard-plugin-profile` first. I would have expected one of these two outcomes: either (a) tensorboard would show me the profiles, or (b) if something went wrong either when collecting or displaying the profiles, an error message would have indicated it so I can fix the issue. ### Standalone code to reproduce the issue ```shell # The code is at https://www.tensorflow.org/tutorials/quickstart/beginner # I change the model.fit() call to use the Tensorboard callback to collect a profile: log_dir = "logs/fit/" + datetime.datetime.now().strftime("%Y%m%d-%H%M%S") tensorboard_callback = tf.keras.callbacks.TensorBoard( log_dir=log_dir, histogram_freq=1, profile_batch=(500, 600)) model.fit(x_train, y_train, epochs=5, callbacks=[tensorboard_callback]) ``` ### Relevant log output ```shell 2023-04-06 23:17:28.048863: I tensorflow/tsl/profiler/lib/profiler_session.cc:104] Profiler session initializing. 2023-04-06 23:17:28.048880: I tensorflow/tsl/profiler/lib/profiler_session.cc:119] Profiler session started. 2023-04-06 23:17:28.048915: I tensorflow/compiler/xla/backends/profiler/gpu/cupti_tracer.cc:1671] Profiler found 1 GPUs 2023-04-06 23:17:28.237604: I tensorflow/tsl/profiler/lib/profiler_session.cc:131] Profiler session tear down. 2023-04-06 23:17:28.237742: I tensorflow/compiler/xla/backends/profiler/gpu/cupti_tracer.cc:1805] CUPTI activity buffer flushed Epoch 1/5 2023-04-06 23:17:28.747772: I tensorflow/compiler/xla/service/service.cc:168] XLA service 0x7f08c0180cf0 initialized for platform CUDA (this does not guarantee that XLA will be used). Devices: 2023-04-06 23:17:28.747785: I tensorflow/compiler/xla/service/service.cc:176] StreamExecutor device (0): NVIDIA GeForce RTX 3080 Ti, Compute Capability 8.6 2023-04-06 23:17:28.751189: I tensorflow/compiler/mlir/tensorflow/utils/dump_mlir_util.cc:255] disabling MLIR crash reproducer, set env var `MLIR_CRASH_REPRODUCER_DIRECTORY` to enable. 2023-04-06 23:17:28.834436: I tensorflow/compiler/xla/stream_executor/cuda/cuda_dnn.cc:426] Loaded cuDNN version 8600 2023-04-06 23:17:28.868033: I tensorflow/tsl/platform/default/subprocess.cc:304] Start cannot spawn child process: No such file or directory 2023-04-06 23:17:28.900180: I ./tensorflow/compiler/jit/device_compiler.h:186] Compiled cluster using XLA! This line is logged at most once for the lifetime of the process. 522/1875 [=======>......................] - ETA: 5s - loss: 0.4875 - accuracy: 0.8590 2023-04-06 23:17:30.991051: I tensorflow/tsl/profiler/lib/profiler_session.cc:104] Profiler session initializing. 2023-04-06 23:17:30.991106: I tensorflow/tsl/profiler/lib/profiler_session.cc:119] Profiler session started. 645/1875 [=========>....................] - ETA: 4s - loss: 0.4499 - accuracy: 0.8701 2023-04-06 23:17:31.542500: I tensorflow/tsl/profiler/lib/profiler_session.cc:70] Profiler session collecting data. 2023-04-06 23:17:31.545123: I tensorflow/compiler/xla/backends/profiler/gpu/cupti_tracer.cc:1805] CUPTI activity buffer flushed 2023-04-06 23:17:31.570874: I tensorflow/compiler/xla/backends/profiler/gpu/cupti_collector.cc:541] GpuTracer has collected 6158 callback api events and 5891 activity events. 2023-04-06 23:17:31.598454: I tensorflow/tsl/profiler/lib/profiler_session.cc:131] Profiler session tear down. 1875/1875 [==============================] - 8s 4ms/step - loss: 0.3017 - accuracy: 0.9121 Epoch 2/5 1875/1875 [==============================] - 7s 4ms/step - loss: 0.1441 - accuracy: 0.9570 Epoch 3/5 1875/1875 [==============================] - 7s 4ms/step - loss: 0.1075 - accuracy: 0.9685 Epoch 4/5 1875/1875 [==============================] - 6s 3ms/step - loss: 0.0878 - accuracy: 0.9732 Epoch 5/5 1875/1875 [==============================] - 6s 3ms/step - loss: 0.0737 - accuracy: 0.9771 ``` </details>
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/60262/reactions", "total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/60262/timeline
null
null
false
https://api.github.com/repos/tensorflow/tensorflow/issues/60261
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/60261/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/60261/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/60261/events
https://github.com/tensorflow/tensorflow/issues/60261
1,658,221,168
I_kwDOArmXAs5i1nJw
60,261
[lite]Compiler build warnings
{ "login": "samveen", "id": 1241434, "node_id": "MDQ6VXNlcjEyNDE0MzQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1241434?v=4", "gravatar_id": "", "url": "https://api.github.com/users/samveen", "html_url": "https://github.com/samveen", "followers_url": "https://api.github.com/users/samveen/followers", "following_url": "https://api.github.com/users/samveen/following{/other_user}", "gists_url": "https://api.github.com/users/samveen/gists{/gist_id}", "starred_url": "https://api.github.com/users/samveen/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/samveen/subscriptions", "organizations_url": "https://api.github.com/users/samveen/orgs", "repos_url": "https://api.github.com/users/samveen/repos", "events_url": "https://api.github.com/users/samveen/events{/privacy}", "received_events_url": "https://api.github.com/users/samveen/received_events", "type": "User", "site_admin": false }
[ { "id": 404586594, "node_id": "MDU6TGFiZWw0MDQ1ODY1OTQ=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/stat:awaiting%20tensorflower", "name": "stat:awaiting tensorflower", "color": "f4b400", "default": false, "description": "Status - Awaiting response from tensorflower" }, { "id": 473173351, "node_id": "MDU6TGFiZWw0NzMxNzMzNTE=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/type:build/install", "name": "type:build/install", "color": "159b2e", "default": false, "description": "Build and install issues" }, { "id": 750616506, "node_id": "MDU6TGFiZWw3NTA2MTY1MDY=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/comp:lite", "name": "comp:lite", "color": "0052cc", "default": false, "description": "TF Lite related issues" }, { "id": 5206407904, "node_id": "LA_kwDOArmXAs8AAAABNlN64A", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/TF%202.12", "name": "TF 2.12", "color": "c5def5", "default": false, "description": "For issues related to Tensorflow 2.12" } ]
closed
false
{ "login": "terryheo", "id": 2908505, "node_id": "MDQ6VXNlcjI5MDg1MDU=", "avatar_url": "https://avatars.githubusercontent.com/u/2908505?v=4", "gravatar_id": "", "url": "https://api.github.com/users/terryheo", "html_url": "https://github.com/terryheo", "followers_url": "https://api.github.com/users/terryheo/followers", "following_url": "https://api.github.com/users/terryheo/following{/other_user}", "gists_url": "https://api.github.com/users/terryheo/gists{/gist_id}", "starred_url": "https://api.github.com/users/terryheo/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/terryheo/subscriptions", "organizations_url": "https://api.github.com/users/terryheo/orgs", "repos_url": "https://api.github.com/users/terryheo/repos", "events_url": "https://api.github.com/users/terryheo/events{/privacy}", "received_events_url": "https://api.github.com/users/terryheo/received_events", "type": "User", "site_admin": false }
[ { "login": "terryheo", "id": 2908505, "node_id": "MDQ6VXNlcjI5MDg1MDU=", "avatar_url": "https://avatars.githubusercontent.com/u/2908505?v=4", "gravatar_id": "", "url": "https://api.github.com/users/terryheo", "html_url": "https://github.com/terryheo", "followers_url": "https://api.github.com/users/terryheo/followers", "following_url": "https://api.github.com/users/terryheo/following{/other_user}", "gists_url": "https://api.github.com/users/terryheo/gists{/gist_id}", "starred_url": "https://api.github.com/users/terryheo/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/terryheo/subscriptions", "organizations_url": "https://api.github.com/users/terryheo/orgs", "repos_url": "https://api.github.com/users/terryheo/repos", "events_url": "https://api.github.com/users/terryheo/events{/privacy}", "received_events_url": "https://api.github.com/users/terryheo/received_events", "type": "User", "site_admin": false }, { "login": "pkgoogle", "id": 132095473, "node_id": "U_kgDOB9-d8Q", "avatar_url": "https://avatars.githubusercontent.com/u/132095473?v=4", "gravatar_id": "", "url": "https://api.github.com/users/pkgoogle", "html_url": "https://github.com/pkgoogle", "followers_url": "https://api.github.com/users/pkgoogle/followers", "following_url": "https://api.github.com/users/pkgoogle/following{/other_user}", "gists_url": "https://api.github.com/users/pkgoogle/gists{/gist_id}", "starred_url": "https://api.github.com/users/pkgoogle/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/pkgoogle/subscriptions", "organizations_url": "https://api.github.com/users/pkgoogle/orgs", "repos_url": "https://api.github.com/users/pkgoogle/repos", "events_url": "https://api.github.com/users/pkgoogle/events{/privacy}", "received_events_url": "https://api.github.com/users/pkgoogle/received_events", "type": "User", "site_admin": false } ]
null
[ "According to the log output, there appears to be a warning relating to the Eigen library in the TensorFlow source. The warning notice specifically states that a function called check_is_representable() is deprecated.\r\n\r\nThis warning is most likely generated by the Eigen library being used with a later version of the compiler, which causes the warning.\r\n\r\nWhile this warning should have no effect on TensorFlow's operation, it's always a good idea to avoid utilizing deprecated functions in your code. One method is to upgrade to a more recent version of the library that does not use deprecated functions.\r\n\r\nYou can also attempt silencing the warning with a compiler flag, although this is generally not recommended because it may hide the warning.", "Hi @samveen did the above response answer your question?", "@pkgoogle No, that did not help at all. \r\n\r\nI have made no changes to the codebase, and this warning occurs. The comment is suggesting that I modify the tensorflow build system for the lite build, which defeats the purpose of reporting this issue. This probably ties in with build failures for RasPi 0/1 as per thew build status section of the README. \r\n\r\nIt would be great to know the last commit ID that allowed this to build successfully, as I have not been able to get that information from digging into the commit history.", "Hi @samveen, Are you actually able to compile despite the warning? Generally speaking, warnings will take a long time to get to as they are lower priority. Which README section are you referring to? Thanks for any additional information you can provide.", "@pkgoogle \r\n\r\n Please look at the table listed here: \r\nhttps://github.com/tensorflow/tensorflow#official-builds\r\n\r\nAs for the build, if you give me a revision or git tag, I'll run a build for it and give you the results (though it will be slow, as it'll be a native build)", "Hi @samveen, can you try with nightly? It seems the official build is blocked by a malformed docker issue rather than the actual build.", "OK. I will run a native 32-bit build for tf lite on my raspberry Pi Zero W and let you know the result. (The build will take quite a bit or time to complete).", "Progress report:\r\n- Instructions source https://www.tensorflow.org/lite/guide/build_cmake\r\n- Source details:\r\n ```\r\n samveen@facez:~/tensorflow_src $ git remote -v\r\n origin https://github.com/tensorflow/tensorflow.git (fetch)\r\n origin https://github.com/tensorflow/tensorflow.git (push)\r\n samveen@facez:~/tensorflow_src $ git describe --tags\r\n v2.12.1\r\n ```\r\n- CMake command and options:\r\n ```\r\n cmake ../tensorflow_src/tensorflow/lite\r\n ```\r\n- Build command:\r\n ```\r\n ~/tflite_build $ cmake --build . -j 1 -t label_image\r\n ```\r\n- End result: Error with build due to missing options for libatomic in `examples/label_image/CMakeLists.txt`\r\n\r\n(snipped)\r\n```\r\n/usr/bin/ld: eigen_support.cc:(.text._ZN14EigenForTFLite15ThreadPoolTemplINS_20StlThreadEnvironmentEE11WaitForWorkEPNS_10EventCount6WaiterEPNS1_4TaskE[_ZN14EigenForTFLite15ThreadPoolTemplINS_20StlThreadEnvironmentEE11WaitForWorkEPNS_10EventCount6WaiterEPNS1_4TaskE]+0x778): undefined reference to `__atomic_load_8'\r\n/usr/bin/ld: eigen_support.cc:(.text._ZN14EigenForTFLite15ThreadPoolTemplINS_20StlThreadEnvironmentEE11WaitForWorkEPNS_10EventCount6WaiterEPNS1_4TaskE[_ZN14EigenForTFLite15ThreadPoolTemplINS_20StlThreadEnvironmentEE11WaitForWorkEPNS_10EventCount6WaiterEPNS1_4TaskE]+0x7fc): undefined reference to `__atomic_compare_exchange_8'\r\n/usr/bin/ld: eigen_support.cc:(.text._ZN14EigenForTFLite15ThreadPoolTemplINS_20StlThreadEnvironmentEE11WaitForWorkEPNS_10EventCount6WaiterEPNS1_4TaskE[_ZN14EigenForTFLite15ThreadPoolTemplINS_20StlThreadEnvironmentEE11WaitForWorkEPNS_10EventCount6WaiterEPNS1_4TaskE]+0x860): undefined reference to `__atomic_load_8'\r\n/usr/bin/ld: eigen_support.cc:(.text._ZN14EigenForTFLite15ThreadPoolTemplINS_20StlThreadEnvironmentEE11WaitForWorkEPNS_10EventCount6WaiterEPNS1_4TaskE[_ZN14EigenForTFLite15ThreadPoolTemplINS_20StlThreadEnvironmentEE11WaitForWorkEPNS_10EventCount6WaiterEPNS1_4TaskE]+0x8c4): undefined reference to `__atomic_load_8'\r\ncollect2: error: ld returned 1 exit status\r\ngmake[3]: *** [examples/label_image/CMakeFiles/label_image.dir/build.make:370: examples/label_image/label_image] Error 1\r\ngmake[2]: *** [CMakeFiles/Makefile2:6608: examples/label_image/CMakeFiles/label_image.dir/all] Error 2\r\ngmake[1]: *** [CMakeFiles/Makefile2:6615: examples/label_image/CMakeFiles/label_image.dir/rule] Error 2\r\n```\r\n\r\nI am modifying the CMake config and restarting the process.", "I've managed to get target `benchmark_model` build. However, using the examples as listed in https://github.com/tensorflow/tensorflow/tree/master/tensorflow/tools/benchmark using the model files from https://storage.googleapis.com/download.tensorflow.org/models/inception5h.zip gives me the following output:\r\n\r\n```\r\nsamveen@piz:~/tflite_build $ ./tools/benchmark/benchmark_model --graph=../tf/tensorflow_inception_graph.pb --input_layer=\"input:0\" --input_layer_shape=\"1,224,224,3\" --input_layer_type=\"float\" --output_layer=\"output:0\"\r\nSTARTING!\r\nUnconsumed cmdline flags: --input_layer_type=float --output_layer=output:0\r\nLog parameter values verbosely: [0]\r\nGraph: [../tf/tensorflow_inception_graph.pb]\r\nInput layers: [input:0]\r\nInput shapes: [1,224,224,3]\r\nERROR: The model is not a valid Flatbuffer buffer\r\nFailed to load model ../tf/tensorflow_inception_graph.pb\r\nBenchmarking failed```", "After fixing the error due to missing linkage against `libatomic` for the image_label target, the build fails as below:\r\n\r\n```\r\n[100%] Built target tensorflow-lite\r\n[100%] Linking CXX executable label_image\r\n/usr/bin/ld: CMakeFiles/label_image.dir/__/__/tools/evaluation/utils.cc.o: in function `tflite::evaluation::CreateXNNPACKDelegate(TfLiteXNNPackDelegateOptions const*)':\r\nutils.cc:(.text+0x1b04): undefined reference to `TfLiteXnnpackDelegatePluginCApi'\r\ncollect2: error: ld returned 1 exit status\r\ngmake[3]: *** [examples/label_image/CMakeFiles/label_image.dir/build.make:370: examples/label_image/label_image] Error 1\r\ngmake[2]: *** [CMakeFiles/Makefile2:6608: examples/label_image/CMakeFiles/label_image.dir/all] Error 2\r\ngmake[1]: *** [CMakeFiles/Makefile2:6615: examples/label_image/CMakeFiles/label_image.dir/rule] Error 2\r\n```", "I was able to replicate with linux (debian) on the nightly branch with the instructions from https://www.tensorflow.org/lite/guide/build_cmake\r\n\r\nspecifically:\r\n```sh\r\ngit clone https://github.com/tensorflow/tensorflow.git tensorflow_src\r\ncd tensorflow_src\r\ngit switch nightly\r\ngit pull\r\ncd ..\r\nmkdir tflite_build\r\ncd tflite_build\r\ncmake ../tensorflow_src/tensorflow/lite\r\ncmake --build . -j\r\ncmake --build . -j -t benchmark_model #builds properly\r\ncmake --build . -j -t label_image #this fails\r\n```\r\n\r\nError:\r\n```sh\r\n[100%] Building CXX object examples/label_image/CMakeFiles/label_image.dir/__/__/profiling/profile_summary_formatter.cc.o\r\n[100%] Building CXX object examples/label_image/CMakeFiles/label_image.dir/__/__/profiling/memory_info.cc.o\r\n[100%] Building CXX object examples/label_image/CMakeFiles/label_image.dir/__/__/tools/evaluation/utils.cc.o\r\n[100%] Building CXX object examples/label_image/CMakeFiles/label_image.dir/__/__/profiling/profile_summarizer.cc.o\r\n[100%] Building CXX object examples/label_image/CMakeFiles/label_image.dir/__/__/tools/tool_params.cc.o\r\n[100%] Building CXX object examples/label_image/CMakeFiles/label_image.dir/__/__/tools/delegates/xnnpack_delegate_provider.cc.o\r\n[100%] Linking CXX executable label_image\r\n/usr/bin/ld: CMakeFiles/label_image.dir/__/__/tools/evaluation/utils.cc.o: in function `tflite::evaluation::CreateXNNPACKDelegate(TfLiteXNNPackDelegateOptions const*)':\r\nutils.cc:(.text+0x2f4f): undefined reference to `TfLiteXnnpackDelegatePluginCApi'\r\ncollect2: error: ld returned 1 exit status\r\ngmake[3]: *** [examples/label_image/CMakeFiles/label_image.dir/build.make:375: examples/label_image/label_image] Error 1\r\ngmake[2]: *** [CMakeFiles/Makefile2:7494: examples/label_image/CMakeFiles/label_image.dir/all] Error 2\r\ngmake[1]: *** [CMakeFiles/Makefile2:7501: examples/label_image/CMakeFiles/label_image.dir/rule] Error 2\r\ngmake: *** [Makefile:2522: label_image] Error 2\r\n```\r\n\r\nHi @terryheo, can you please take a look? Thanks.", "Are you satisfied with the resolution of your issue?\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=Yes&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/60261\">Yes</a>\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=No&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/60261\">No</a>\n" ]
2023-04-07T01:06:15
2023-08-09T20:59:17
2023-08-09T20:59:14
NONE
null
null
null
<details><summary>Click to expand!</summary> ### Issue Type Build/Install ### Have you reproduced the bug with TF nightly? No ### Source source ### Tensorflow Version 2.12.0 ### Custom Code No ### OS Platform and Distribution Linux Raspberrypi OS 32-bit (bullseye) - (Linux 6.1.19+ \# 1637 Tue Mar 14 11:01:56 GMT 2023 armv6l GNU/Linux) ### Mobile device Raspberry Pi Zero W ### Python version 3.9.2 ### Bazel version CMake build used ### GCC/Compiler version GNU c++ (Raspbian 10.2.1-6+rpi1) 10.2.1 20210110 ### CUDA/cuDNN version _N.A._ ### GPU model and memory _N.A._ ### Current Behaviour? I get the following warning while building tensorflow-lite with cmake on a Raspberry Pi Zero W running Raspberrypi OS lite 32-bit (Debian bullseye). ``` [ 54%] Building CXX object CMakeFiles/tensorflow-lite.dir/kernels/conv3d.cc.o /usr/bin/c++ -DCPUINFO_SUPPORTED_PLATFORM=1 -DEIGEN_MPL2_ONLY -DNOMINMAX=1 -DPTHREADPOOL_NO_DEPRECATED_API=1 -I/home/samveen/tensorflow -I/home/samveen/tensorflow/build/gemmlowp -I/home/samveen/tensorflow/build/eigen -I/home/samveen/tensorflow/build/neon2sse -I/home/samveen/tensorflow/build/abseil-cpp -I/home/samveen/tensorflow/build/farmhash/src -I/home/samveen/tensorflow/build/flatbuffers/include -I/home/samveen/tensorflow/build/ruy -I/home/samveen/tensorflow/build/cpuinfo/include -I/home/samveen/tensorflow/build/pthreadpool-source/include -march=armv6 -mfpu=vfp -mfloat-abi=hard -funsafe-math-optimizations -O3 -DNDEBUG -fPIC -DEIGEN_NEON_GEBP_NR=4 -DTFL_STATIC_LIBRARY_BUILD -pthread -std=gnu++17 -o CMakeFiles/tensorflow-lite.dir/kernels/conv3d.cc.o -c /home/samveen/tensorflow/tensorflow/lite/kernels/conv3d.cc In file included from /home/samveen/tensorflow/build/eigen/Eigen/Core:266, from /home/samveen/tensorflow/third_party/eigen3/Eigen/Core:1, from /home/samveen/tensorflow/tensorflow/lite/kernels/internal/optimized/optimized_ops.h:39, from /home/samveen/tensorflow/tensorflow/lite/kernels/conv3d.cc:25: /home/samveen/tensorflow/build/eigen/Eigen/src/Core/functors/UnaryFunctors.h: In instantiation of ‘Eigen::internal::scalar_unary_pow_op<Scalar, ExponentScalar, false, false, false, false>::scalar_unary_pow_op(const ExponentScalar&) [with Scalar = float; ExponentScalar = double]’: /home/samveen/tensorflow/build/eigen/Eigen/src/Core/../plugins/ArrayCwiseUnaryOps.h:714:66: required from ‘Eigen::ArrayBase<Derived>::UnaryPowReturnType<ScalarExponent> Eigen::ArrayBase<Derived>::pow(const ScalarExponent&) const [with ScalarExponent = double; Derived = Eigen::ArrayWrapper<Eigen::Map<Eigen::Matrix<float, -1, -1>, 0, Eigen::Stride<0, 0> > >; Eigen::ArrayBase<Derived>::UnaryPowReturnType<ScalarExponent> = Eigen::CwiseUnaryOp<Eigen::internal::scalar_unary_pow_op<float, double, false, false, false, false>, const Eigen::ArrayWrapper<Eigen::Map<Eigen::Matrix<float, -1, -1>, 0, Eigen::Stride<0, 0> > > >]’ /home/samveen/tensorflow/tensorflow/lite/kernels/internal/optimized/optimized_ops.h:3327:78: required from here /home/samveen/tensorflow/build/eigen/Eigen/src/Core/functors/UnaryFunctors.h:1218:27: warning: ‘std::enable_if_t<(! IsExactlyRepresentable), void> Eigen::internal::scalar_unary_pow_op<Scalar, ExponentScalar, false, false, false, false>::check_is_representable() const [with bool IsExactlyRepresentable = false; Scalar = float; ExponentScalar = double; std::enable_if_t<(! IsExactlyRepresentable), void> = void]’ is deprecated [-Wdeprecated-declarations] 1218 | check_is_representable(); | ~~~~~~~~~~~~~~~~~~~~~~^~ /home/samveen/tensorflow/build/eigen/Eigen/src/Core/functors/UnaryFunctors.h:1214:68: note: declared here 1214 | EIGEN_DEPRECATED std::enable_if_t<!IsExactlyRepresentable, void> check_is_representable() const {} | ^~~~~~~~~~~~~~~~~~~~~~ ``` ### Standalone code to reproduce the issue Standard build on a Pi Zero W running Raspberry Pi OS lite 32-bit (Debian bullseye) ```shell mkdir build && cd build ARMCC_FLAGS="-march=armv6 -mfpu=vfp -mfloat-abi=hard -funsafe-math-optimizations" cmake -DCMAKE_C_FLAGS="${ARMCC_FLAGS}" -DCMAKE_CXX_FLAGS="${ARMCC_FLAGS}" \ -DCMAKE_VERBOSE_MAKEFILE:BOOL=ON -DCMAKE_SYSTEM_NAME=Linux -DCMAKE_SYSTEM_PROCESSOR=armv6 \ -DTFLITE_ENABLE_XNNPACK=OFF ../tensorflow/lite/ cmake --build . ``` ### Relevant log output ```shell [ 54%] Building CXX object CMakeFiles/tensorflow-lite.dir/kernels/conv3d.cc.o /usr/bin/c++ -DCPUINFO_SUPPORTED_PLATFORM=1 -DEIGEN_MPL2_ONLY -DNOMINMAX=1 -DPTHREADPOOL_NO_DEPRECATED_API=1 -I/home/samveen/tensorflow -I/home/samveen/tensorflow/build/gemmlowp -I/home/samveen/tensorflow/build/eigen -I/home/samveen/tensorflow/build/neon2sse -I/home/samveen/tensorflow/build/abseil-cpp -I/home/samveen/tensorflow/build/farmhash/src -I/home/samveen/tensorflow/build/flatbuffers/include -I/home/samveen/tensorflow/build/ruy -I/home/samveen/tensorflow/build/cpuinfo/include -I/home/samveen/tensorflow/build/pthreadpool-source/include -march=armv6 -mfpu=vfp -mfloat-abi=hard -funsafe-math-optimizations -O3 -DNDEBUG -fPIC -DEIGEN_NEON_GEBP_NR=4 -DTFL_STATIC_LIBRARY_BUILD -pthread -std=gnu++17 -o CMakeFiles/tensorflow-lite.dir/kernels/conv3d.cc.o -c /home/samveen/tensorflow/tensorflow/lite/kernels/conv3d.cc In file included from /home/samveen/tensorflow/build/eigen/Eigen/Core:266, from /home/samveen/tensorflow/third_party/eigen3/Eigen/Core:1, from /home/samveen/tensorflow/tensorflow/lite/kernels/internal/optimized/optimized_ops.h:39, from /home/samveen/tensorflow/tensorflow/lite/kernels/conv3d.cc:25: /home/samveen/tensorflow/build/eigen/Eigen/src/Core/functors/UnaryFunctors.h: In instantiation of ‘Eigen::internal::scalar_unary_pow_op<Scalar, ExponentScalar, false, false, false, false>::scalar_unary_pow_op(const ExponentScalar&) [with Scalar = float; ExponentScalar = double]’: /home/samveen/tensorflow/build/eigen/Eigen/src/Core/../plugins/ArrayCwiseUnaryOps.h:714:66: required from ‘Eigen::ArrayBase<Derived>::UnaryPowReturnType<ScalarExponent> Eigen::ArrayBase<Derived>::pow(const ScalarExponent&) const [with ScalarExponent = double; Derived = Eigen::ArrayWrapper<Eigen::Map<Eigen::Matrix<float, -1, -1>, 0, Eigen::Stride<0, 0> > >; Eigen::ArrayBase<Derived>::UnaryPowReturnType<ScalarExponent> = Eigen::CwiseUnaryOp<Eigen::internal::scalar_unary_pow_op<float, double, false, false, false, false>, const Eigen::ArrayWrapper<Eigen::Map<Eigen::Matrix<float, -1, -1>, 0, Eigen::Stride<0, 0> > > >]’ /home/samveen/tensorflow/tensorflow/lite/kernels/internal/optimized/optimized_ops.h:3327:78: required from here /home/samveen/tensorflow/build/eigen/Eigen/src/Core/functors/UnaryFunctors.h:1218:27: warning: ‘std::enable_if_t<(! IsExactlyRepresentable), void> Eigen::internal::scalar_unary_pow_op<Scalar, ExponentScalar, false, false, false, false>::check_is_representable() const [with bool IsExactlyRepresentable = false; Scalar = float; ExponentScalar = double; std::enable_if_t<(! IsExactlyRepresentable), void> = void]’ is deprecated [-Wdeprecated-declarations] 1218 | check_is_representable(); | ~~~~~~~~~~~~~~~~~~~~~~^~ /home/samveen/tensorflow/build/eigen/Eigen/src/Core/functors/UnaryFunctors.h:1214:68: note: declared here 1214 | EIGEN_DEPRECATED std::enable_if_t<!IsExactlyRepresentable, void> check_is_representable() const {} | ^~~~~~~~~~~~~~~~~~~~~~ ``` </details>
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/60261/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/60261/timeline
null
completed
false
https://api.github.com/repos/tensorflow/tensorflow/issues/60260
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/60260/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/60260/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/60260/events
https://github.com/tensorflow/tensorflow/pull/60260
1,657,921,563
PR_kwDOArmXAs5Ny1a4
60,260
Update the RBE images to the latest container versions
{ "login": "tensorflow-jenkins", "id": 16359713, "node_id": "MDQ6VXNlcjE2MzU5NzEz", "avatar_url": "https://avatars.githubusercontent.com/u/16359713?v=4", "gravatar_id": "", "url": "https://api.github.com/users/tensorflow-jenkins", "html_url": "https://github.com/tensorflow-jenkins", "followers_url": "https://api.github.com/users/tensorflow-jenkins/followers", "following_url": "https://api.github.com/users/tensorflow-jenkins/following{/other_user}", "gists_url": "https://api.github.com/users/tensorflow-jenkins/gists{/gist_id}", "starred_url": "https://api.github.com/users/tensorflow-jenkins/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/tensorflow-jenkins/subscriptions", "organizations_url": "https://api.github.com/users/tensorflow-jenkins/orgs", "repos_url": "https://api.github.com/users/tensorflow-jenkins/repos", "events_url": "https://api.github.com/users/tensorflow-jenkins/events{/privacy}", "received_events_url": "https://api.github.com/users/tensorflow-jenkins/received_events", "type": "User", "site_admin": false }
[ { "id": 390482148, "node_id": "MDU6TGFiZWwzOTA0ODIxNDg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/awaiting%20review", "name": "awaiting review", "color": "bc3869", "default": false, "description": "Pull request awaiting review" }, { "id": 987666414, "node_id": "MDU6TGFiZWw5ODc2NjY0MTQ=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/ready%20to%20pull", "name": "ready to pull", "color": "2cd643", "default": false, "description": "PR ready for merge process" }, { "id": 1169364458, "node_id": "MDU6TGFiZWwxMTY5MzY0NDU4", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/size:S", "name": "size:S", "color": "adafea", "default": false, "description": "CL Change Size: Small" } ]
closed
false
{ "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false }
[ { "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false } ]
null
[]
2023-04-06T19:16:25
2023-04-10T17:30:19
2023-04-10T17:30:19
COLLABORATOR
null
false
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/pulls/60260", "html_url": "https://github.com/tensorflow/tensorflow/pull/60260", "diff_url": "https://github.com/tensorflow/tensorflow/pull/60260.diff", "patch_url": "https://github.com/tensorflow/tensorflow/pull/60260.patch", "merged_at": "2023-04-10T17:30:19" }
This PR was created by a GitHub Actions workflow to update all the SIG Build-based RBE containers to the most recent containers. See: - https://github.com/tensorflow/tensorflow/blob/master/tensorflow/tools/toolchains/remote_config/configs.bzl - https://github.com/tensorflow/tensorflow/blob/master/.github/workflows/update-rbe.yml
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/60260/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/60260/timeline
null
null
true
https://api.github.com/repos/tensorflow/tensorflow/issues/60259
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/60259/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/60259/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/60259/events
https://github.com/tensorflow/tensorflow/pull/60259
1,657,651,342
PR_kwDOArmXAs5Nx9_m
60,259
Update boringssl to allow compilation in MacOS XCode 14.3
{ "login": "feranick", "id": 35967, "node_id": "MDQ6VXNlcjM1OTY3", "avatar_url": "https://avatars.githubusercontent.com/u/35967?v=4", "gravatar_id": "", "url": "https://api.github.com/users/feranick", "html_url": "https://github.com/feranick", "followers_url": "https://api.github.com/users/feranick/followers", "following_url": "https://api.github.com/users/feranick/following{/other_user}", "gists_url": "https://api.github.com/users/feranick/gists{/gist_id}", "starred_url": "https://api.github.com/users/feranick/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/feranick/subscriptions", "organizations_url": "https://api.github.com/users/feranick/orgs", "repos_url": "https://api.github.com/users/feranick/repos", "events_url": "https://api.github.com/users/feranick/events{/privacy}", "received_events_url": "https://api.github.com/users/feranick/received_events", "type": "User", "site_admin": false }
[]
closed
false
null
[]
null
[ "Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).\n\nView this [failed invocation](https://github.com/tensorflow/tensorflow/pull/60259/checks?check_run_id=12571837686) of the CLA check for more information.\n\nFor the most up to date status, view the checks section at the bottom of the pull request.", "This has not been merged in the 2.12.1 release. Not sure why, but it should. ", "It did not land on master and was not cherrypicked. Too late now for 2.12.x series since @learning-to-play and team decided to only patch the last release, so now only 2.13 will get patches.", "@feranick Please see if [TF patching guidelines](https://github.com/tensorflow/tensorflow#patching-guidelines) can provide a solution for your case.", "I have a solution to my case. I found it, reported here, created a pull request, that was reviewed and accepted for release. But then it was neither landed on master nor cherrypicked. As a result, the problem remains for whoever is trying to compile 2.12.x on MacOS. Patching guidelines are just that, a guideline for a specific patch. Since my patch has not been cherrypicked, suggesting the use of the patching guidelines becomes pointless and irrelevant.\r\n\r\nSo this (resolved) bug report is the only place where one can find a solution, and manually apply the patch. I would expect more, at the very least list it in the \"known issues\" so there is some guidance. Again, I am fine as I found a solution myself, but frankly going to the trouble to push it upstream through the official channels only to find that it's considered irrelevant, doesn't really inspire any future effort on my part to contribute patches. \r\n\r\nBesides 2.13.0 is out now and does not suffer from this. \r\n\r\nThank you for your help." ]
2023-04-06T15:35:56
2023-07-12T16:08:36
2023-05-31T14:47:44
CONTRIBUTOR
null
false
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/pulls/60259", "html_url": "https://github.com/tensorflow/tensorflow/pull/60259", "diff_url": "https://github.com/tensorflow/tensorflow/pull/60259.diff", "patch_url": "https://github.com/tensorflow/tensorflow/pull/60259.patch", "merged_at": null }
Current version of boringssl pulled for TF 2.12.x does not compile with TF using XCode 14.3 due to an unused variable and an aggressive compiler flag (-Werror,-Wunused-but-set-variable) This patch adds links to an updated version of boringssl (used for TF Master), that fixes the issue. This fixes TF issue #60191
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/60259/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/60259/timeline
null
null
true
https://api.github.com/repos/tensorflow/tensorflow/issues/60258
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/60258/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/60258/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/60258/events
https://github.com/tensorflow/tensorflow/pull/60258
1,657,524,277
PR_kwDOArmXAs5Nxj4T
60,258
Update example code to use TensorFlow 2.0 behaviour
{ "login": "pjpratik", "id": 118897289, "node_id": "U_kgDOBxY6iQ", "avatar_url": "https://avatars.githubusercontent.com/u/118897289?v=4", "gravatar_id": "", "url": "https://api.github.com/users/pjpratik", "html_url": "https://github.com/pjpratik", "followers_url": "https://api.github.com/users/pjpratik/followers", "following_url": "https://api.github.com/users/pjpratik/following{/other_user}", "gists_url": "https://api.github.com/users/pjpratik/gists{/gist_id}", "starred_url": "https://api.github.com/users/pjpratik/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/pjpratik/subscriptions", "organizations_url": "https://api.github.com/users/pjpratik/orgs", "repos_url": "https://api.github.com/users/pjpratik/repos", "events_url": "https://api.github.com/users/pjpratik/events{/privacy}", "received_events_url": "https://api.github.com/users/pjpratik/received_events", "type": "User", "site_admin": false }
[ { "id": 390482148, "node_id": "MDU6TGFiZWwzOTA0ODIxNDg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/awaiting%20review", "name": "awaiting review", "color": "bc3869", "default": false, "description": "Pull request awaiting review" }, { "id": 750616506, "node_id": "MDU6TGFiZWw3NTA2MTY1MDY=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/comp:lite", "name": "comp:lite", "color": "0052cc", "default": false, "description": "TF Lite related issues" }, { "id": 987666414, "node_id": "MDU6TGFiZWw5ODc2NjY0MTQ=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/ready%20to%20pull", "name": "ready to pull", "color": "2cd643", "default": false, "description": "PR ready for merge process" }, { "id": 1169364458, "node_id": "MDU6TGFiZWwxMTY5MzY0NDU4", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/size:S", "name": "size:S", "color": "adafea", "default": false, "description": "CL Change Size: Small" } ]
closed
false
{ "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false }
[ { "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false } ]
null
[ "Hi @yishuangP Can you please review this PR ? Thank you!", "Hi @yishuangP Can you please review this PR ? Thank you!", "Hi @yishuangP Can you please review this PR ? Thank you!", "Hi @JunyoungLim Can you please review this PR ? Thank you!", "Hi @JunyoungLim Can you please review this PR ? Thank you!" ]
2023-04-06T14:23:51
2023-08-02T03:42:18
2023-08-02T00:10:05
CONTRIBUTOR
null
false
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/pulls/60258", "html_url": "https://github.com/tensorflow/tensorflow/pull/60258", "diff_url": "https://github.com/tensorflow/tensorflow/pull/60258.diff", "patch_url": "https://github.com/tensorflow/tensorflow/pull/60258.patch", "merged_at": "2023-08-02T00:10:04" }
The sample code provided in the inference guide is outdated. This commit replaces the deprecated tf.Session and tf.placeholder with their TensorFlow 2.0 equivalents. This update ensures that the code is compatible with the latest version of TensorFlow. Thanks.
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/60258/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/60258/timeline
null
null
true
https://api.github.com/repos/tensorflow/tensorflow/issues/60257
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/60257/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/60257/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/60257/events
https://github.com/tensorflow/tensorflow/pull/60257
1,657,472,550
PR_kwDOArmXAs5NxZSX
60,257
lite: add tensors and nodes size in SignatureRunner
{ "login": "aflaischer", "id": 26463144, "node_id": "MDQ6VXNlcjI2NDYzMTQ0", "avatar_url": "https://avatars.githubusercontent.com/u/26463144?v=4", "gravatar_id": "", "url": "https://api.github.com/users/aflaischer", "html_url": "https://github.com/aflaischer", "followers_url": "https://api.github.com/users/aflaischer/followers", "following_url": "https://api.github.com/users/aflaischer/following{/other_user}", "gists_url": "https://api.github.com/users/aflaischer/gists{/gist_id}", "starred_url": "https://api.github.com/users/aflaischer/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/aflaischer/subscriptions", "organizations_url": "https://api.github.com/users/aflaischer/orgs", "repos_url": "https://api.github.com/users/aflaischer/repos", "events_url": "https://api.github.com/users/aflaischer/events{/privacy}", "received_events_url": "https://api.github.com/users/aflaischer/received_events", "type": "User", "site_admin": false }
[ { "id": 474725938, "node_id": "MDU6TGFiZWw0NzQ3MjU5Mzg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/stale", "name": "stale", "color": "d4c5f9", "default": false, "description": "This label marks the issue/pr stale - to be closed automatically if no activity" }, { "id": 750616506, "node_id": "MDU6TGFiZWw3NTA2MTY1MDY=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/comp:lite", "name": "comp:lite", "color": "0052cc", "default": false, "description": "TF Lite related issues" }, { "id": 1169364458, "node_id": "MDU6TGFiZWwxMTY5MzY0NDU4", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/size:S", "name": "size:S", "color": "adafea", "default": false, "description": "CL Change Size: Small" } ]
closed
false
{ "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false }
[ { "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false } ]
null
[ "Hi @gbaned \r\nIs there something I should check to make the merge progress?", "> Hi @gbaned Is there something I should check to make the merge progress?\r\n\r\nHi @aflaischer Can you please take a look on below error. Thank you!\r\n\r\nclang: error: unable to execute command: Segmentation fault: 11\r\nclang: error: clang frontend command failed due to signal (use -v to see invocation)", "Hi @gbaned \r\n\r\nFrom which job is it coming? it seems I don't have access to feedback/copybara\r\nwhat is the command to run?\r\n\r\nIn any case it seems like an environment issue no? if the clang command is segfaulting \r\n\r\nShould I rebase my changes perhaps?\r\n", "Hi @yishuangP Can you please review this PR ? Thank you!", "Hi @yishuangP Can you please review this PR ? Thank you!", "Hi @aflaischer Can you please resolve conflicts? Thank you!", "This PR is stale because it has been open for 14 days with no activity. It will be closed if no further activity occurs. Thank you.", "This PR was closed because it has been inactive for 14 days since being marked as stale. Please reopen if you'd like to work on this further." ]
2023-04-06T13:53:13
2023-09-30T01:47:10
2023-09-30T01:47:03
NONE
null
false
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/pulls/60257", "html_url": "https://github.com/tensorflow/tensorflow/pull/60257", "diff_url": "https://github.com/tensorflow/tensorflow/pull/60257.diff", "patch_url": "https://github.com/tensorflow/tensorflow/pull/60257.patch", "merged_at": null }
number of tensors and nodes is already available in Subgraph class, map these sizes in SignatureRunner. It avoids to use GetSubgraphIndexFromSignature() and subgraph() from Interpreter class to retrieve these sizes for a given signature.
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/60257/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/60257/timeline
null
null
true
https://api.github.com/repos/tensorflow/tensorflow/issues/60256
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/60256/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/60256/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/60256/events
https://github.com/tensorflow/tensorflow/issues/60256
1,657,346,945
I_kwDOArmXAs5iyRuB
60,256
pip install tensorflow for Mac M1 Python3.11 matching distribution not found - nightly build does
{ "login": "alexlatif", "id": 25416855, "node_id": "MDQ6VXNlcjI1NDE2ODU1", "avatar_url": "https://avatars.githubusercontent.com/u/25416855?v=4", "gravatar_id": "", "url": "https://api.github.com/users/alexlatif", "html_url": "https://github.com/alexlatif", "followers_url": "https://api.github.com/users/alexlatif/followers", "following_url": "https://api.github.com/users/alexlatif/following{/other_user}", "gists_url": "https://api.github.com/users/alexlatif/gists{/gist_id}", "starred_url": "https://api.github.com/users/alexlatif/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/alexlatif/subscriptions", "organizations_url": "https://api.github.com/users/alexlatif/orgs", "repos_url": "https://api.github.com/users/alexlatif/repos", "events_url": "https://api.github.com/users/alexlatif/events{/privacy}", "received_events_url": "https://api.github.com/users/alexlatif/received_events", "type": "User", "site_admin": false }
[ { "id": 473172988, "node_id": "MDU6TGFiZWw0NzMxNzI5ODg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/type:bug", "name": "type:bug", "color": "159b2e", "default": false, "description": "Bug" }, { "id": 1205765054, "node_id": "MDU6TGFiZWwxMjA1NzY1MDU0", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/subtype:macOS", "name": "subtype:macOS", "color": "b619ea", "default": false, "description": "macOS Build/Installation issues" }, { "id": 5206407904, "node_id": "LA_kwDOArmXAs8AAAABNlN64A", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/TF%202.12", "name": "TF 2.12", "color": "c5def5", "default": false, "description": "For issues related to Tensorflow 2.12" } ]
closed
false
{ "login": "SuryanarayanaY", "id": 116063290, "node_id": "U_kgDOBur8Og", "avatar_url": "https://avatars.githubusercontent.com/u/116063290?v=4", "gravatar_id": "", "url": "https://api.github.com/users/SuryanarayanaY", "html_url": "https://github.com/SuryanarayanaY", "followers_url": "https://api.github.com/users/SuryanarayanaY/followers", "following_url": "https://api.github.com/users/SuryanarayanaY/following{/other_user}", "gists_url": "https://api.github.com/users/SuryanarayanaY/gists{/gist_id}", "starred_url": "https://api.github.com/users/SuryanarayanaY/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/SuryanarayanaY/subscriptions", "organizations_url": "https://api.github.com/users/SuryanarayanaY/orgs", "repos_url": "https://api.github.com/users/SuryanarayanaY/repos", "events_url": "https://api.github.com/users/SuryanarayanaY/events{/privacy}", "received_events_url": "https://api.github.com/users/SuryanarayanaY/received_events", "type": "User", "site_admin": false }
[ { "login": "SuryanarayanaY", "id": 116063290, "node_id": "U_kgDOBur8Og", "avatar_url": "https://avatars.githubusercontent.com/u/116063290?v=4", "gravatar_id": "", "url": "https://api.github.com/users/SuryanarayanaY", "html_url": "https://github.com/SuryanarayanaY", "followers_url": "https://api.github.com/users/SuryanarayanaY/followers", "following_url": "https://api.github.com/users/SuryanarayanaY/following{/other_user}", "gists_url": "https://api.github.com/users/SuryanarayanaY/gists{/gist_id}", "starred_url": "https://api.github.com/users/SuryanarayanaY/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/SuryanarayanaY/subscriptions", "organizations_url": "https://api.github.com/users/SuryanarayanaY/orgs", "repos_url": "https://api.github.com/users/SuryanarayanaY/repos", "events_url": "https://api.github.com/users/SuryanarayanaY/events{/privacy}", "received_events_url": "https://api.github.com/users/SuryanarayanaY/received_events", "type": "User", "site_admin": false } ]
null
[ "If you are encountering the error \"matching distribution not found\" while trying to install TensorFlow on a Mac M1 with Python 3.11, it might be because TensorFlow does not have an official release that supports Python 3.11 yet. \r\n\r\nOne option is to use a nightly build of TensorFlow, which may have support for Python 3.11. To install a nightly build of TensorFlow, you can use the following command in your terminal:\r\n\r\n`pip install tf-nightly\r\n`\r\nThis will install the latest nightly build of TensorFlow, which may contain support for Python 3.11. However, keep in mind that nightly builds are not guaranteed to be stable and may contain bugs.\r\n\r\nAlternatively, you could try installing an earlier version of Python, such as Python 3.9, and then install TensorFlow using pip. To do this, you can use the following commands in your terminal:\r\n\r\n\r\n```\r\nbrew install pyenv\r\npyenv install 3.9.10\r\npyenv global 3.9.10\r\npip install tensorflow\r\n\r\n```\r\nThis will install Python 3.9.10 using pyenv, set it as the global Python version, and then install TensorFlow using pip.\r\n\r\n\r\n\r\n\r\n\r\n\r\n", "I have the same problem. `tf-nightly` indeed works but not `tensorflow`. I've tried with python 3.9.10 (exactly the instructions above) and the 3.8, 3.10 and 3.11 that `pyenv` currently install. It won't find `tensorflow`, `tensorflow-macos` or `tensorflow-deps` or `tensorflow-metal` that I've seen in other tutorials.", "Upgrade pip, use venv, only install necessary package `pip install TensorFlow` or\r\ndo `pip install --upgrade --force-reinstall TensorFlow` or \r\nTry installing TensorFlow from source instead of using pip. To do this, you can follow the instructions on the TensorFlow website: https://www.tensorflow.org/install/source.\r\n", "Thank you! I managed to install TensorFlow after following the instructions from Apple (https://developer.apple.com/metal/tensorflow-plugin/) which only worked after downgrading to Python 3.10, but then I got stuck on installing `tensorflow-text`. I guess I can install that from source, too, but I gave up on working with my m1 for now. Thanks again!", "@alexlatif,\r\nHave you got the chance to have a look at this https://github.com/tensorflow/tensorflow/issues/60209 issue which is requesting for a similar feature and the issue is still open. Also please take a look at this issue from the Apple discussion forum for the reference\r\nhttps://developer.apple.com/forums/thread/691403?answerId=750196022#750196022\r\n\r\nThank you!", "I have an Apple with M1 chip and I can't install tensorflow either.\r\n\r\n```\r\n➜ python -m venv env\r\n➜ source env/bin/activate\r\n\r\n(env) ➜ python --version\r\nPython 3.9.12\r\n\r\n(env) ➜ pip --version \r\npip 23.0.1 from /Users/dcavazos/src/sandbox/env/lib/python3.9/site-packages/pip (python 3.9)\r\n\r\n(env) ➜ pip install tensorflow\r\nERROR: Could not find a version that satisfies the requirement tensorflow (from versions: none)\r\nERROR: No matching distribution found for tensorflow\r\n```\r\n\r\nIt seems that `tf-nightly` works, but it would be nice to be able to install plain old `tensorflow`.", "@davidcavazos,\r\nBoth tensorflow-macos and tensorflow-metal were developed & maintained by Apple. \r\n**pip install tensorflow-macos** installs the Apple package and **pip install tensorflow** installs Tensorflow package.\r\nAlso please have a look at this [comment](https://github.com/tensorflow/tensorflow/issues/60209#issuecomment-1512424619) from the developer for the reference. Thank you!", "This issue is stale because it has been open for 7 days with no activity. It will be closed if no further activity occurs. Thank you.", "I recommend maintaining the issue open until closed.\r\nApparently there is a related discussion on a different thread.\r\n\r\n[[Python3.11 arm64 wheels for tensorflow-macos](https://github.com/tensorflow/tensorflow/issues/60209#top)](https://github.com/tensorflow/tensorflow/issues/60209#issuecomment-1512424619)", "Not stale.\r\n\r\nTensorflow docs state _Tensorflow is tested on Python 3.8–3.11_. That is patently false.\r\n\r\n```\r\n$ python3 -m pip install tensorflow\r\nERROR: Could not find a version that satisfies the requirement tensorflow (from versions: none)\r\nERROR: No matching distribution found for tensorflow\r\n\r\n$ python3 -V\r\nPython 3.10.11\r\n\r\n$ sw_vers\r\nProductName:\t\tmacOS\r\nProductVersion:\t\t13.3.1\r\nBuildVersion:\t\t22E261\r\n\r\n$ uname -a\r\nDarwin US-TDWYF57V1F 22.4.0 Darwin Kernel Version 22.4.0: Mon Mar 6 20:59:28 PST 2023; root:xnu-8796.101.5~3/RELEASE_ARM64_T6000 arm64\r\n\r\n$ python3 -m pip --version\r\npip 23.1.2\r\n```", "I just tested it and it looks like `pip install tensorflow` on an M1 machine will now install `tensorflow==2.13.0rc0` successfully.", "I have a similar issue of pip not finding any version beside 2.13.x on a Mac M1.\r\n\r\n```\r\n(delft_p38) Lucas-M1-MBP:delft lfoppiano$ pip install --upgrade pip \r\nRequirement already satisfied: pip in /Users/lfoppiano/anaconda3/envs/delft_p38/lib/python3.8/site-packages (23.1.2)\r\n(delft_p38) Lucas-M1-MBP:delft lfoppiano$ python --version\r\nPython 3.8.17\r\n(delft_p38) Lucas-M1-MBP:delft lfoppiano$ pip install tensorflow==2.9.3\r\nERROR: Could not find a version that satisfies the requirement tensorflow==2.9.3 (from versions: 2.13.0rc0, 2.13.0rc1, 2.13.0rc2, 2.13.0)\r\nERROR: No matching distribution found for tensorflow==2.9.3\r\n(delft_p38) Lucas-M1-MBP:delft lfoppiano$ \r\n```", "Hello,\r\nStarting from TF2.13v tensorflow team changed the setup.py file to allow users to install the tensorflow package based on the platform they are trying to install.\r\n\r\nFrom Tf2.13v onwards:\r\n\r\nhttps://github.com/tensorflow/tensorflow/blob/f841394b1b714c5cc5366536411cf146c8c570df/tensorflow/tools/pip_package/setup.py#L140-L157\r\n\r\n\r\nFor TF2.12v:\r\nhttps://github.com/tensorflow/tensorflow/blob/8e2b6655c0c488290179ab90a0daed0f6d3006f7/tensorflow/tools/pip_package/setup.py#L143-L156\r\n\r\n\r\nYou can find that in TF2.12v `tensorflow-macos` was not added under collaborate build. Users has to install `tensorflow-macos` explicitly on Mac M1/M2(Apple chip).\r\n\r\nHowever from Tf2.13 tensorflow team added `tensorflow-macos` under collaborate build hence you can able to install it using `pip install tensorflow` itself. \r\n\r\nPlease note that the package being installed on Mac M1/M2 (Apple chip) is still Apple's Package only even though you are using `pip install tensorflow`. \r\n", "@alexlatif ,\r\n\r\nI hope the above explanation clears your queries. Please let us know whether we are good to close the issue now.\r\n\r\nThanks!", "This issue is stale because it has been open for 7 days with no activity. It will be closed if no further activity occurs. Thank you.", "This issue was closed because it has been inactive for 7 days since being marked as stale. Please reopen if you'd like to work on this further.", "Are you satisfied with the resolution of your issue?\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=Yes&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/60256\">Yes</a>\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=No&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/60256\">No</a>\n" ]
2023-04-06T12:34:47
2023-10-07T01:47:44
2023-10-07T01:47:40
NONE
null
null
null
<details><summary>Click to expand!</summary> ### Issue Type Bug ### Have you reproduced the bug with TF nightly? Yes ### Source source ### Tensorflow Version 2.12 ### Custom Code No ### OS Platform and Distribution Mac OSX M2 ### Mobile device _No response_ ### Python version 3.11 ### Bazel version _No response_ ### GCC/Compiler version _No response_ ### CUDA/cuDNN version _No response_ ### GPU model and memory _No response_ ### Current Behaviour? ```shell please could you support mac M1's in a way where we dont have to build from source tf-nightly is working out of the box but standard pip tensorflow is currently not supported ``` ### Standalone code to reproduce the issue ```shell pip install tensorflow ERROR: Could not find a version that satisfies the requirement tensorflow (from versions: none) ERROR: No matching distribution found for tensorflow pip install tensorflow-macos ERROR: Could not find a version that satisfies the requirement tensorflow-macos (from versions: none) ERROR: No matching distribution found for tensorflow-macos pip install tf-nightly Downloading tf_nightly-2.13.0.dev20230406-cp311-cp311-macosx_12_0_arm64.whl (2.1 kB) ``` ### Relevant log output _No response_</details>
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/60256/reactions", "total_count": 2, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 1, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/60256/timeline
null
completed
false
https://api.github.com/repos/tensorflow/tensorflow/issues/60255
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/60255/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/60255/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/60255/events
https://github.com/tensorflow/tensorflow/issues/60255
1,657,282,754
I_kwDOArmXAs5iyCDC
60,255
Use after free in propagator_state.cc
{ "login": "PaDarochek", "id": 69221349, "node_id": "MDQ6VXNlcjY5MjIxMzQ5", "avatar_url": "https://avatars.githubusercontent.com/u/69221349?v=4", "gravatar_id": "", "url": "https://api.github.com/users/PaDarochek", "html_url": "https://github.com/PaDarochek", "followers_url": "https://api.github.com/users/PaDarochek/followers", "following_url": "https://api.github.com/users/PaDarochek/following{/other_user}", "gists_url": "https://api.github.com/users/PaDarochek/gists{/gist_id}", "starred_url": "https://api.github.com/users/PaDarochek/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/PaDarochek/subscriptions", "organizations_url": "https://api.github.com/users/PaDarochek/orgs", "repos_url": "https://api.github.com/users/PaDarochek/repos", "events_url": "https://api.github.com/users/PaDarochek/events{/privacy}", "received_events_url": "https://api.github.com/users/PaDarochek/received_events", "type": "User", "site_admin": false }
[ { "id": 404586594, "node_id": "MDU6TGFiZWw0MDQ1ODY1OTQ=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/stat:awaiting%20tensorflower", "name": "stat:awaiting tensorflower", "color": "f4b400", "default": false, "description": "Status - Awaiting response from tensorflower" }, { "id": 473172988, "node_id": "MDU6TGFiZWw0NzMxNzI5ODg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/type:bug", "name": "type:bug", "color": "159b2e", "default": false, "description": "Bug" }, { "id": 1097543484, "node_id": "MDU6TGFiZWwxMDk3NTQzNDg0", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/comp:runtime", "name": "comp:runtime", "color": "0052cc", "default": false, "description": "c++ runtime, performance issues (cpu)" }, { "id": 5206407904, "node_id": "LA_kwDOArmXAs8AAAABNlN64A", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/TF%202.12", "name": "TF 2.12", "color": "c5def5", "default": false, "description": "For issues related to Tensorflow 2.12" } ]
open
false
{ "login": "sachinprasadhs", "id": 73069040, "node_id": "MDQ6VXNlcjczMDY5MDQw", "avatar_url": "https://avatars.githubusercontent.com/u/73069040?v=4", "gravatar_id": "", "url": "https://api.github.com/users/sachinprasadhs", "html_url": "https://github.com/sachinprasadhs", "followers_url": "https://api.github.com/users/sachinprasadhs/followers", "following_url": "https://api.github.com/users/sachinprasadhs/following{/other_user}", "gists_url": "https://api.github.com/users/sachinprasadhs/gists{/gist_id}", "starred_url": "https://api.github.com/users/sachinprasadhs/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sachinprasadhs/subscriptions", "organizations_url": "https://api.github.com/users/sachinprasadhs/orgs", "repos_url": "https://api.github.com/users/sachinprasadhs/repos", "events_url": "https://api.github.com/users/sachinprasadhs/events{/privacy}", "received_events_url": "https://api.github.com/users/sachinprasadhs/received_events", "type": "User", "site_admin": false }
[ { "login": "sachinprasadhs", "id": 73069040, "node_id": "MDQ6VXNlcjczMDY5MDQw", "avatar_url": "https://avatars.githubusercontent.com/u/73069040?v=4", "gravatar_id": "", "url": "https://api.github.com/users/sachinprasadhs", "html_url": "https://github.com/sachinprasadhs", "followers_url": "https://api.github.com/users/sachinprasadhs/followers", "following_url": "https://api.github.com/users/sachinprasadhs/following{/other_user}", "gists_url": "https://api.github.com/users/sachinprasadhs/gists{/gist_id}", "starred_url": "https://api.github.com/users/sachinprasadhs/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sachinprasadhs/subscriptions", "organizations_url": "https://api.github.com/users/sachinprasadhs/orgs", "repos_url": "https://api.github.com/users/sachinprasadhs/repos", "events_url": "https://api.github.com/users/sachinprasadhs/events{/privacy}", "received_events_url": "https://api.github.com/users/sachinprasadhs/received_events", "type": "User", "site_admin": false } ]
null
[ "cc @mihaimaruseac \r\n\r\nCode where `next_iter` is initialized and used:\r\nhttps://github.com/tensorflow/tensorflow/blob/6f692f73cb2043b4a0b0446539cd8c15b3dd9220/tensorflow/core/common_runtime/propagator_state.cc#L755-L772\r\n\r\n`ActivateLoopInvs`:\r\nhttps://github.com/tensorflow/tensorflow/blob/6f692f73cb2043b4a0b0446539cd8c15b3dd9220/tensorflow/core/common_runtime/propagator_state.cc#L701-L715\r\n\r\n`AdjustOutstandingOpsLocked`:\r\nhttps://github.com/tensorflow/tensorflow/blob/6f692f73cb2043b4a0b0446539cd8c15b3dd9220/tensorflow/core/common_runtime/propagator_state.cc#L878-L891\r\n\r\n`CleanupIterations`:\r\nhttps://github.com/tensorflow/tensorflow/blob/6f692f73cb2043b4a0b0446539cd8c15b3dd9220/tensorflow/core/common_runtime/propagator_state.cc#L774-L799\r\n\r\n`iter_state` is deleted on line 778.", "To solve the \"use after free\" error in propagator_state.cc, you need to ensure that the memory pointed to by next_iter is not deleted or accessed after it has been deleted.\r\n\r\nOne approach to achieve this is to modify the code so that the ownership of next_iter is transferred to another object or function, which is responsible for managing its lifetime. For example, you can use a smart pointer such as std::unique_ptr or std::shared_ptr to automatically manage the memory of next_iter.\r\n\r\nAnother approach is to modify the code to ensure that any functions that may access or modify next_iter after it has been deleted, are modified to prevent this from happening. This may involve adding checks to ensure that the pointer is valid before accessing it, or modifying the control flow of the program to ensure that the pointer is not accessed after it has been deleted.\r\n\r\nIn either case, it's important to carefully review and test the modified code to ensure that it is correct and does not introduce new bugs. Additionally, it's important to understand the root cause of the error and address any underlying design or architecture issues that may have contributed to the error, to prevent similar issues from arising in the future. can I work on this? @tiruk007", "@PaDarochek Can you report this (and similar) via OSS VRP? This way, you can also get a bounty if this is a vulnerability. https://github.com/tensorflow/tensorflow/blob/master/SECURITY.md#reporting-vulnerabilities\r\n\r\n@bhagirath20 Anyone can send PRs to fix any of the open issues. The first PR that passes review and the merge process is the one that gets merged.\r\nhttps://github.com/tensorflow/tensorflow/blob/master/CONTRIBUTING.md", "how can I further proceed in this? I have done some changes in code in my repo. and pull request. but it is not visible on TensorFlow main repo pull request page. how can reviewer view and accept my pull request? https://github.com/bhagirath20/tensorflow/pull/1/commits/daa460d88dc256b8b22fd65fe629a400f41289cd . @mihaimaruseac @tiruk007 ", "@mihaimaruseac Reported via OSS VRP.", "Thanks @PaDarochek .\r\n\r\n@bhagirath20 you need to open a PR against TF repo, not against your own repo.", "Btw, [this PR](https://github.com/bhagirath20/tensorflow/pull/1/files) does not fix use after free. The function calling `CleanupIterations` will still have an ordinary (non unique ptr) pointer that is freed. Also, now the pointer is always deleted that is worse than before. Moreover, the code does not compile. I composed a hello world example for this:\r\n\r\n```\r\n#include <iostream>\r\n#include <memory>\r\n\r\nvoid foo(std::unique_ptr<int>& val) {\r\n std::cout << \"val = \" << *val << std::endl;\r\n val.reset();\r\n}\r\n\r\nint main() {\r\n int *a = new int(10);\r\n auto u = std::unique_ptr<int>(a);\r\n foo(u);\r\n std::cout << *a << std::endl;\r\n}\r\n```\r\n\r\n $ clang++ -fsanitize=address main.cpp\r\n $ ./a.out\r\n\r\n```\r\nval = 10\r\n=================================================================\r\n==141988==ERROR: AddressSanitizer: heap-use-after-free on address 0x602000000010 at pc 0x5633173797e0 bp 0x7ffffd860df0 sp 0x7ffffd860de8\r\nREAD of size 4 at 0x602000000010 thread T0\r\n #0 0x5633173797df in main (/tmp/a.out+0xde7df) (BuildId: 6ea64e75951ea28d632e046622292c29f16dbef4)\r\n #1 0x7f302ec37d8f in __libc_start_call_main csu/../sysdeps/nptl/libc_start_call_main.h:58:16\r\n #2 0x7f302ec37e3f in __libc_start_main csu/../csu/libc-start.c:392:3\r\n #3 0x5633172b93c4 in _start (/tmp/a.out+0x1e3c4) (BuildId: 6ea64e75951ea28d632e046622292c29f16dbef4)\r\n```", "I suppose the fix needs some architectural changes from maintainers familiar with TensorFlow code base.", "Btw, the text seems to be generated by ChatGPT ;)\r\n\r\n![Screenshot from 2023-04-07 18-31-49](https://user-images.githubusercontent.com/22149206/230635883-277ea25c-a959-4301-abd1-d0ee7b7ff8af.png)" ]
2023-04-06T11:55:35
2023-04-11T21:17:11
null
CONTRIBUTOR
null
null
null
<details><summary>Click to expand!</summary> ### Issue Type Bug ### Have you reproduced the bug with TF nightly? Yes ### Source source ### Tensorflow Version tf2.12 ### Custom Code No ### OS Platform and Distribution _No response_ ### Mobile device _No response_ ### Python version _No response_ ### Bazel version _No response_ ### GCC/Compiler version _No response_ ### CUDA/cuDNN version _No response_ ### GPU model and memory _No response_ ### Current Behaviour? ```shell Pointer `next_iter` from function `PropagatorState::FrameState::IncrementIteration` is passed as the 1st parameter into `ActivateLoopInvs` where it is passed as the 1st parameter into `AdjustOutstandingOpsLocked`, then inside this function it is passed into `CleanupIterations` where it is deleted. Then in `PropagatorState::FrameState::IncrementIteration` this possibly freed pointer is used in `return`-statement. This behavior was introduced by https://github.com/tensorflow/tensorflow/commit/ae2a0e5c473f2a575767262021c26852d22886f8. Before this commit, no `return` was performed on the possibly freed pointer. ``` ### Standalone code to reproduce the issue ```shell Bug was found by Svace static analysis tool. ``` ### Relevant log output _No response_</details>
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/60255/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/60255/timeline
null
null
false
https://api.github.com/repos/tensorflow/tensorflow/issues/60254
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/60254/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/60254/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/60254/events
https://github.com/tensorflow/tensorflow/issues/60254
1,656,995,698
I_kwDOArmXAs5iw79y
60,254
WSL2 fit function not works tensorflow 2.12.0
{ "login": "ghost", "id": 10137, "node_id": "MDQ6VXNlcjEwMTM3", "avatar_url": "https://avatars.githubusercontent.com/u/10137?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ghost", "html_url": "https://github.com/ghost", "followers_url": "https://api.github.com/users/ghost/followers", "following_url": "https://api.github.com/users/ghost/following{/other_user}", "gists_url": "https://api.github.com/users/ghost/gists{/gist_id}", "starred_url": "https://api.github.com/users/ghost/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ghost/subscriptions", "organizations_url": "https://api.github.com/users/ghost/orgs", "repos_url": "https://api.github.com/users/ghost/repos", "events_url": "https://api.github.com/users/ghost/events{/privacy}", "received_events_url": "https://api.github.com/users/ghost/received_events", "type": "User", "site_admin": false }
[ { "id": 473172988, "node_id": "MDU6TGFiZWw0NzMxNzI5ODg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/type:bug", "name": "type:bug", "color": "159b2e", "default": false, "description": "Bug" }, { "id": 4257391797, "node_id": "LA_kwDOArmXAs79wqS1", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/wsl2", "name": "wsl2", "color": "A352E6", "default": false, "description": "Windows Subsystem for Linux" }, { "id": 5206407904, "node_id": "LA_kwDOArmXAs8AAAABNlN64A", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/TF%202.12", "name": "TF 2.12", "color": "c5def5", "default": false, "description": "For issues related to Tensorflow 2.12" } ]
closed
false
{ "login": "synandi", "id": 98147397, "node_id": "U_kgDOBdmcRQ", "avatar_url": "https://avatars.githubusercontent.com/u/98147397?v=4", "gravatar_id": "", "url": "https://api.github.com/users/synandi", "html_url": "https://github.com/synandi", "followers_url": "https://api.github.com/users/synandi/followers", "following_url": "https://api.github.com/users/synandi/following{/other_user}", "gists_url": "https://api.github.com/users/synandi/gists{/gist_id}", "starred_url": "https://api.github.com/users/synandi/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/synandi/subscriptions", "organizations_url": "https://api.github.com/users/synandi/orgs", "repos_url": "https://api.github.com/users/synandi/repos", "events_url": "https://api.github.com/users/synandi/events{/privacy}", "received_events_url": "https://api.github.com/users/synandi/received_events", "type": "User", "site_admin": false }
[ { "login": "synandi", "id": 98147397, "node_id": "U_kgDOBdmcRQ", "avatar_url": "https://avatars.githubusercontent.com/u/98147397?v=4", "gravatar_id": "", "url": "https://api.github.com/users/synandi", "html_url": "https://github.com/synandi", "followers_url": "https://api.github.com/users/synandi/followers", "following_url": "https://api.github.com/users/synandi/following{/other_user}", "gists_url": "https://api.github.com/users/synandi/gists{/gist_id}", "starred_url": "https://api.github.com/users/synandi/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/synandi/subscriptions", "organizations_url": "https://api.github.com/users/synandi/orgs", "repos_url": "https://api.github.com/users/synandi/repos", "events_url": "https://api.github.com/users/synandi/events{/privacy}", "received_events_url": "https://api.github.com/users/synandi/received_events", "type": "User", "site_admin": false } ]
null
[ "I am not getting any error on Python 3.9.16 for your code. try to use this or reproduce error with TF nightly. it may indicate that there are compatibility issues between TensorFlow and that specific version of Python.\r\n\r\nHere are a few things you could try to resolve the issue:\r\n\r\nCheck if the version of TensorFlow you are using is compatible with Python 3.10.9-3.10.10. You can do this by checking the TensorFlow documentation or release notes.\r\n\r\nUpdate your version of TensorFlow to a more recent version that is compatible with Python 3.10.9-3.10.10.\r\n\r\nDowngrade your version of Python to one that is compatible with your version of TensorFlow.\r\n\r\nCheck if there are any other dependencies or packages that are causing conflicts with TensorFlow and try to resolve those issues.\r\n\r\nIf none of the above steps work, consider reaching out again.", "какая блять ебанина, нахуй вы это придумали блять, через две жопы запускать обучение", "Are you satisfied with the resolution of your issue?\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=Yes&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/60254\">Yes</a>\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=No&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/60254\">No</a>\n" ]
2023-04-06T09:17:25
2023-04-07T15:17:25
2023-04-07T15:17:22
NONE
null
null
null
<details><summary>Click to expand!</summary> ### Issue Type Bug ### Have you reproduced the bug with TF nightly? No ### Source binary ### Tensorflow Version v2.12.0-rc1-12-g0db597d0d75 2.12.0 ### Custom Code No ### OS Platform and Distribution WSL2 Ubuntu / Windows 10 19044 64bit ### Mobile device _No response_ ### Python version 3.10.9-3.10.10 ### Bazel version - ### GCC/Compiler version - ### CUDA/cuDNN version 11.8.0 / 8.6.0.163 ### GPU model and memory 1050ti 4GB ### Current Behaviour? ```shell Installed all using this instructions https://www.tensorflow.org/install/pip?hl=ru#windows-wsl2 Python see my GPU, but model.fit function not works. ``` ### Standalone code to reproduce the issue ```shell import tensorflow as tf from tensorflow.python.client import device_lib import numpy as np print(tf.__version__) print(f"Tensor Flow Version: {tf.__version__}") print(f"Keras Version: {tf.keras.__version__}") print() gpu = len(tf.config.list_physical_devices('GPU'))>0 print("GPU is", "available" if gpu else "NOT AVAILABLE") samples = np.array([ [u'Россия', 0], [u'Вчера смотрел в кино - потрясающий фильм! Актёры высшие, невероятные декорации, безудержный драйв на протяжении всего фильма. Давно не испытывал такого восторга от просмотра! 10/10', 1], [u'Норм фильм,в своём стиле не понимаю что другие ожидали))одно смутило когда сцена в клубе все танчили пока бойня была типо ниче не замечая а как картежника завалили все с истериками побежали,типа хуясе тут все в настаящую))))да и пёсель зачетный))', 1], [u'Да пипец блин, меня хватило на 10 минут. Это днище', 0], [u'Бредовый фильм не советую', 0], ]) test = np.array([ [u'Фильм говно', 0], [u'Классный фильм', 1], [u'Не советую к просмотру', 0], [u'Тупой фильм', 0], ]) train_text = [] train_label = [] test_text = [] test_label = [] for sample in samples: train_text.append(sample[0]) train_label.append(float(sample[1])) for tst in test: test_text.append(tst[0]) test_label.append(float(tst[1])) dataset = {'train': 0, 'test': 0} dataset['train'] = tf.data.Dataset.from_tensor_slices((train_text, train_label)) dataset['test'] = tf.data.Dataset.from_tensor_slices((test_text, test_label)) train_dataset, test_dataset = dataset['train'], dataset['test'] for text, lable in train_dataset.take(2): print(text) BUFFER_SIZE = 10000 BATCH_SIZE = 128 train_dataset = train_dataset.shuffle(BUFFER_SIZE).batch(BATCH_SIZE).prefetch(tf.data.AUTOTUNE) test_dataset = test_dataset.batch(BATCH_SIZE).prefetch(tf.data.AUTOTUNE) VOCAB_SIZE = 20000 encoder = tf.keras.layers.TextVectorization( standardize='lower', max_tokens=VOCAB_SIZE, encoding='utf-8') encoder.adapt(train_dataset.map(lambda text, label: text)) model = tf.keras.Sequential([ encoder, tf.keras.layers.Embedding( input_dim=len(encoder.get_vocabulary()), output_dim=64, # Use masking to handle the variable sequence lengths mask_zero=True), tf.keras.layers.Bidirectional(tf.keras.layers.LSTM(128)), tf.keras.layers.Dense(64, activation='relu'), tf.keras.layers.Dense(1) ]) model.compile(loss=tf.keras.losses.BinaryCrossentropy(from_logits=True), optimizer=tf.keras.optimizers.Adam(1e-4), metrics=['accuracy']) history = model.fit(train_dataset, epochs=250, validation_data=test_dataset) sample_text = 'меня хватило на 10 минут' predictions = model.predict(np.array([sample_text])) print(predictions) ``` ### Relevant log output ```shell 2023-04-06 12:06:58.601576: I tensorflow/core/platform/cpu_feature_guard.cc:182] This TensorFlow binary is optimized to use available CPU instructions in performance-critical operations. To enable the following instructions: AVX2 FMA, in other operations, rebuild TensorFlow with the appropriate compiler flags. 2023-04-06 12:07:00.057818: W tensorflow/compiler/tf2tensorrt/utils/py_utils.cc:38] TF-TRT Warning: Could not find TensorRT 2.12.0 Tensor Flow Version: 2.12.0 Keras Version: 2.12.0 2023-04-06 12:07:01.276945: I tensorflow/compiler/xla/stream_executor/cuda/cuda_gpu_executor.cc:982] could not open file to read NUMA node: /sys/bus/pci/devices/0000:01:00.0/numa_node Your kernel may have been built without NUMA support. 2023-04-06 12:07:01.462465: I tensorflow/compiler/xla/stream_executor/cuda/cuda_gpu_executor.cc:982] could not open file to read NUMA node: /sys/bus/pci/devices/0000:01:00.0/numa_node Your kernel may have been built without NUMA support. 2023-04-06 12:07:01.462581: I tensorflow/compiler/xla/stream_executor/cuda/cuda_gpu_executor.cc:982] could not open file to read NUMA node: /sys/bus/pci/devices/0000:01:00.0/numa_node Your kernel may have been built without NUMA support. GPU is available 2023-04-06 12:07:01.477422: I tensorflow/compiler/xla/stream_executor/cuda/cuda_gpu_executor.cc:982] could not open file to read NUMA node: /sys/bus/pci/devices/0000:01:00.0/numa_node Your kernel may have been built without NUMA support. 2023-04-06 12:07:01.477546: I tensorflow/compiler/xla/stream_executor/cuda/cuda_gpu_executor.cc:982] could not open file to read NUMA node: /sys/bus/pci/devices/0000:01:00.0/numa_node Your kernel may have been built without NUMA support. 2023-04-06 12:07:01.477680: I tensorflow/compiler/xla/stream_executor/cuda/cuda_gpu_executor.cc:982] could not open file to read NUMA node: /sys/bus/pci/devices/0000:01:00.0/numa_node Your kernel may have been built without NUMA support. 2023-04-06 12:07:06.851452: I tensorflow/compiler/xla/stream_executor/cuda/cuda_gpu_executor.cc:982] could not open file to read NUMA node: /sys/bus/pci/devices/0000:01:00.0/numa_node Your kernel may have been built without NUMA support. 2023-04-06 12:07:06.852698: I tensorflow/compiler/xla/stream_executor/cuda/cuda_gpu_executor.cc:982] could not open file to read NUMA node: /sys/bus/pci/devices/0000:01:00.0/numa_node Your kernel may have been built without NUMA support. 2023-04-06 12:07:06.852765: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1722] Could not identify NUMA node of platform GPU id 0, defaulting to 0. Your kernel may not have been built with NUMA support. 2023-04-06 12:07:06.852885: I tensorflow/compiler/xla/stream_executor/cuda/cuda_gpu_executor.cc:982] could not open file to read NUMA node: /sys/bus/pci/devices/0000:01:00.0/numa_node Your kernel may have been built without NUMA support. 2023-04-06 12:07:06.873685: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1635] Created device /job:localhost/replica:0/task:0/device:GPU:0 with 2519 MB memory: -> device: 0, name: NVIDIA GeForce GTX 1050 Ti, pci bus id: 0000:01:00.0, compute capability: 6.1 2023-04-06 12:07:17.597288: I tensorflow/core/common_runtime/executor.cc:1197] [/device:CPU:0] (DEBUG INFO) Executor start aborting (this does not indicate an error and you can ignore this message): INVALID_ARGUMENT: You must feed a value for placeholder tensor 'Placeholder/_1' with dtype float and shape [92] [[{{node Placeholder/_1}}]] tf.Tensor(b'\xd0\xa0\xd0\xbe\xd1\x81\xd1\x81\xd0\xb8\xd1\x8f', shape=(), dtype=string) tf.Tensor(b'\xd0\x92\xd1\x87\xd0\xb5\xd1\x80\xd0\xb0 \xd1\x81\xd0\xbc\xd0\xbe\xd1\x82\xd1\x80\xd0\xb5\xd0\xbb \xd0\xb2 \xd0\xba\xd0\xb8\xd0\xbd\xd0\xbe - \xd0\xbf\xd0\xbe\xd1\x82\xd1\x80\xd1\x8f\xd1\x81\xd0\xb0\xd1\x8e\xd1\x89\xd0\xb8\xd0\xb9 \xd1\x84\xd0\xb8\xd0\xbb\xd1\x8c\xd0\xbc! \xd0\x90\xd0\xba\xd1\x82\xd1\x91\xd1\x80\xd1\x8b \xd0\xb2\xd1\x8b\xd1\x81\xd1\x88\xd0\xb8\xd0\xb5, \xd0\xbd\xd0\xb5\xd0\xb2\xd0\xb5\xd1\x80\xd0\xbe\xd1\x8f\xd1\x82\xd0\xbd\xd1\x8b\xd0\xb5 \xd0\xb4\xd0\xb5\xd0\xba\xd0\xbe\xd1\x80\xd0\xb0\xd1\x86\xd0\xb8\xd0\xb8, \xd0\xb1\xd0\xb5\xd0\xb7\xd1\x83\xd0\xb4\xd0\xb5\xd1\x80\xd0\xb6\xd0\xbd\xd1\x8b\xd0\xb9 \xd0\xb4\xd1\x80\xd0\xb0\xd0\xb9\xd0\xb2 \xd0\xbd\xd0\xb0 \xd0\xbf\xd1\x80\xd0\xbe\xd1\x82\xd1\x8f\xd0\xb6\xd0\xb5\xd0\xbd\xd0\xb8\xd0\xb8 \xd0\xb2\xd1\x81\xd0\xb5\xd0\xb3\xd0\xbe \xd1\x84\xd0\xb8\xd0\xbb\xd1\x8c\xd0\xbc\xd0\xb0. \xd0\x94\xd0\xb0\xd0\xb2\xd0\xbd\xd0\xbe \xd0\xbd\xd0\xb5 \xd0\xb8\xd1\x81\xd0\xbf\xd1\x8b\xd1\x82\xd1\x8b\xd0\xb2\xd0\xb0\xd0\xbb \xd1\x82\xd0\xb0\xd0\xba\xd0\xbe\xd0\xb3\xd0\xbe \xd0\xb2\xd0\xbe\xd1\x81\xd1\x82\xd0\xbe\xd1\x80\xd0\xb3\xd0\xb0 \xd0\xbe\xd1\x82 \xd0\xbf\xd1\x80\xd0\xbe\xd1\x81\xd0\xbc\xd0\xbe\xd1\x82\xd1\x80\xd0\xb0! 10/10', shape=(), dtype=string)2023-04-06 12:07:18.366287: I tensorflow/core/common_runtime/executor.cc:1197] [/device:CPU:0] (DEBUG INFO) Executor start aborting (this does not indicate an error and you can ignore this message): INVALID_ARGUMENT: You must feed a value for placeholder tensor 'Placeholder/_1' with dtype float and shape [92] [[{{node Placeholder/_1}}]] 2023-04-06 12:07:18.366750: I tensorflow/core/common_runtime/executor.cc:1197] [/device:CPU:0] (DEBUG INFO) Executor start aborting (this does not indicate an error and you can ignore this message): INVALID_ARGUMENT: You must feed a value for placeholder tensor 'Placeholder/_0' with dtype string and shape [92] [[{{node Placeholder/_0}}]] 2023-04-06 12:07:23.301274: I tensorflow/core/common_runtime/executor.cc:1197] [/device:CPU:0] (DEBUG INFO) Executor start aborting (this does not indicate an error and you can ignore this message): INVALID_ARGUMENT: You must feed a value for placeholder tensor 'Placeholder/_1' with dtype float and shape [92] [[{{node Placeholder/_1}}]] 2023-04-06 12:07:23.301919: I tensorflow/core/common_runtime/executor.cc:1197] [/device:CPU:0] (DEBUG INFO) Executor start aborting (this does not indicate an error and you can ignore this message): INVALID_ARGUMENT: You must feed a value for placeholder tensor 'Placeholder/_0' with dtype string and shape [92] [[{{node Placeholder/_0}}]] Epoch 1/250 2023-04-06 12:07:26.986857: I tensorflow/core/common_runtime/executor.cc:1197] [/device:CPU:0] (DEBUG INFO) Executor start aborting (this does not indicate an error and you can ignore this message): INVALID_ARGUMENT: You must feed a value for placeholder tensor 'gradients/ReverseV2_grad/ReverseV2/ReverseV2/axis' with dtype int32 and shape [1] [[{{node gradients/ReverseV2_grad/ReverseV2/ReverseV2/axis}}]] 2023-04-06 12:07:30.238269: I tensorflow/core/common_runtime/executor.cc:1197] [/device:CPU:0] (DEBUG INFO) Executor start aborting (this does not indicate an error and you can ignore this message): INVALID_ARGUMENT: You must feed a value for placeholder tensor 'gradients/ReverseV2_grad/ReverseV2/ReverseV2/axis' with dtype int32 and shape [1] [[{{node gradients/ReverseV2_grad/ReverseV2/ReverseV2/axis}}]] 2023-04-06 12:07:31.901964: W tensorflow/core/common_runtime/type_inference.cc:339] Type inference failed. This indicates an invalid graph that escaped type checking. Error message: INVALID_ARGUMENT: expected compatible input types, but input 1: type_id: TFT_OPTIONAL args { type_id: TFT_PRODUCT args { type_id: TFT_TENSOR args { type_id: TFT_INT32 } } } is neither a subtype nor a supertype of the combined inputs preceding it: type_id: TFT_OPTIONAL args { type_id: TFT_PRODUCT args { type_id: TFT_TENSOR args { type_id: TFT_FLOAT } } } while inferring type of node 'cond_40/output/_23' 2023-04-06 12:07:38.520941: I tensorflow/compiler/xla/stream_executor/cuda/cuda_dnn.cc:424] Loaded cuDNN version 8600 2023-04-06 12:07:39.881521: I tensorflow/compiler/xla/service/service.cc:169] XLA service 0x1da1c010 initialized for platform CUDA (this does not guarantee that XLA will be used). Devices: 2023-04-06 12:07:39.881632: I tensorflow/compiler/xla/service/service.cc:177] StreamExecutor device (0): NVIDIA GeForce GTX 1050 Ti, Compute Capability 6.1 2023-04-06 12:07:39.994222: I tensorflow/compiler/mlir/tensorflow/utils/dump_mlir_util.cc:269] disabling MLIR crash reproducer, set env var `MLIR_CRASH_REPRODUCER_DIRECTORY` to enable. 2023-04-06 12:07:40.402391: W tensorflow/compiler/xla/service/gpu/llvm_gpu_backend/gpu_backend_lib.cc:530] Can't find libdevice directory ${CUDA_DIR}/nvvm/libdevice. This may result in compilation or runtime failures, if the program we try to run uses routines from libdevice. Searched for CUDA in the following directories: ./cuda_sdk_lib /usr/local/cuda-11.8 /usr/local/cuda . You can choose the search directory by setting xla_gpu_cuda_data_dir in HloModule's DebugOptions. For most apps, setting the environment variable XLA_FLAGS=--xla_gpu_cuda_data_dir=/path/to/cuda will work. 2023-04-06 12:07:40.405914: W tensorflow/compiler/xla/service/gpu/llvm_gpu_backend/gpu_backend_lib.cc:274] libdevice is required by this HLO module but was not found at ./libdevice.10.bc 2023-04-06 12:07:40.408337: W tensorflow/core/framework/op_kernel.cc:1830] OP_REQUIRES failed at xla_ops.cc:362 : INTERNAL: libdevice not found at ./libdevice.10.bc 2023-04-06 12:07:40.408428: I tensorflow/core/common_runtime/executor.cc:1197] [/job:localhost/replica:0/task:0/device:GPU:0] (DEBUG INFO) Executor start aborting (this does not indicate an error and you can ignore this message): INTERNAL: libdevice not found at ./libdevice.10.bc [[{{node StatefulPartitionedCall_10}}]] 2023-04-06 12:07:40.444717: W tensorflow/compiler/xla/service/gpu/llvm_gpu_backend/gpu_backend_lib.cc:274] libdevice is required by this HLO module but was not found at ./libdevice.10.bc 2023-04-06 12:07:40.445387: W tensorflow/core/framework/op_kernel.cc:1830] OP_REQUIRES failed at xla_ops.cc:362 : INTERNAL: libdevice not found at ./libdevice.10.bc 2023-04-06 12:07:40.475982: W tensorflow/compiler/xla/service/gpu/llvm_gpu_backend/gpu_backend_lib.cc:274] libdevice is required by this HLO module but was not found at ./libdevice.10.bc 2023-04-06 12:07:40.476520: W tensorflow/core/framework/op_kernel.cc:1830] OP_REQUIRES failed at xla_ops.cc:362 : INTERNAL: libdevice not found at ./libdevice.10.bc 2023-04-06 12:07:40.509245: W tensorflow/compiler/xla/service/gpu/llvm_gpu_backend/gpu_backend_lib.cc:274] libdevice is required by this HLO module but was not found at ./libdevice.10.bc 2023-04-06 12:07:40.509756: W tensorflow/core/framework/op_kernel.cc:1830] OP_REQUIRES failed at xla_ops.cc:362 : INTERNAL: libdevice not found at ./libdevice.10.bc Traceback (most recent call last): File "/home/yatebyaeby/test.py", line 168, in <module> history = model.fit(train_dataset, epochs=250, File "/home/yatebyaeby/miniconda3/lib/python3.10/site-packages/keras/utils/traceback_utils.py", line 70, in error_handler raise e.with_traceback(filtered_tb) from None File "/home/yatebyaeby/miniconda3/lib/python3.10/site-packages/tensorflow/python/eager/execute.py", line 52, in quick_execute tensors = pywrap_tfe.TFE_Py_Execute(ctx._handle, device_name, op_name, tensorflow.python.framework.errors_impl.InternalError: Graph execution error: Detected at node 'StatefulPartitionedCall_10' defined at (most recent call last): File "/home/yatebyaeby/test.py", line 168, in <module> history = model.fit(train_dataset, epochs=250, File "/home/yatebyaeby/miniconda3/lib/python3.10/site-packages/keras/utils/traceback_utils.py", line 65, in error_handler return fn(*args, **kwargs) File "/home/yatebyaeby/miniconda3/lib/python3.10/site-packages/keras/engine/training.py", line 1685, in fit tmp_logs = self.train_function(iterator) File "/home/yatebyaeby/miniconda3/lib/python3.10/site-packages/keras/engine/training.py", line 1284, in train_function return step_function(self, iterator) File "/home/yatebyaeby/miniconda3/lib/python3.10/site-packages/keras/engine/training.py", line 1268, in step_function outputs = model.distribute_strategy.run(run_step, args=(data,)) File "/home/yatebyaeby/miniconda3/lib/python3.10/site-packages/keras/engine/training.py", line 1249, in run_step outputs = model.train_step(data) File "/home/yatebyaeby/miniconda3/lib/python3.10/site-packages/keras/engine/training.py", line 1054, in train_step self.optimizer.minimize(loss, self.trainable_variables, tape=tape) File "/home/yatebyaeby/miniconda3/lib/python3.10/site-packages/keras/optimizers/optimizer.py", line 543, in minimize self.apply_gradients(grads_and_vars) File "/home/yatebyaeby/miniconda3/lib/python3.10/site-packages/keras/optimizers/optimizer.py", line 1174, in apply_gradients return super().apply_gradients(grads_and_vars, name=name) File "/home/yatebyaeby/miniconda3/lib/python3.10/site-packages/keras/optimizers/optimizer.py", line 650, in apply_gradients iteration = self._internal_apply_gradients(grads_and_vars) File "/home/yatebyaeby/miniconda3/lib/python3.10/site-packages/keras/optimizers/optimizer.py", line 1200, in _internal_apply_gradients return tf.__internal__.distribute.interim.maybe_merge_call( File "/home/yatebyaeby/miniconda3/lib/python3.10/site-packages/keras/optimizers/optimizer.py", line 1250, in _distributed_apply_gradients_fn distribution.extended.update( File "/home/yatebyaeby/miniconda3/lib/python3.10/site-packages/keras/optimizers/optimizer.py", line 1245, in apply_grad_to_update_var return self._update_step_xla(grad, var, id(self._var_key(var))) Node: 'StatefulPartitionedCall_10' libdevice not found at ./libdevice.10.bc [[{{node StatefulPartitionedCall_10}}]] [Op:__inference_train_function_14740] ``` </details>
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/60254/reactions", "total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/60254/timeline
null
completed
false
https://api.github.com/repos/tensorflow/tensorflow/issues/60253
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/60253/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/60253/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/60253/events
https://github.com/tensorflow/tensorflow/issues/60253
1,656,981,970
I_kwDOArmXAs5iw4nS
60,253
Does tensorflow lite not support compilation with both parameters set on windows? "--cpu=x64_x86_windows --define tflite_with_xnnpack=true"
{ "login": "gootaoo", "id": 10524797, "node_id": "MDQ6VXNlcjEwNTI0Nzk3", "avatar_url": "https://avatars.githubusercontent.com/u/10524797?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gootaoo", "html_url": "https://github.com/gootaoo", "followers_url": "https://api.github.com/users/gootaoo/followers", "following_url": "https://api.github.com/users/gootaoo/following{/other_user}", "gists_url": "https://api.github.com/users/gootaoo/gists{/gist_id}", "starred_url": "https://api.github.com/users/gootaoo/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gootaoo/subscriptions", "organizations_url": "https://api.github.com/users/gootaoo/orgs", "repos_url": "https://api.github.com/users/gootaoo/repos", "events_url": "https://api.github.com/users/gootaoo/events{/privacy}", "received_events_url": "https://api.github.com/users/gootaoo/received_events", "type": "User", "site_admin": false }
[ { "id": 386191887, "node_id": "MDU6TGFiZWwzODYxOTE4ODc=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/stat:awaiting%20response", "name": "stat:awaiting response", "color": "f4b400", "default": false, "description": "Status - Awaiting response from author" }, { "id": 473172988, "node_id": "MDU6TGFiZWw0NzMxNzI5ODg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/type:bug", "name": "type:bug", "color": "159b2e", "default": false, "description": "Bug" }, { "id": 750616506, "node_id": "MDU6TGFiZWw3NTA2MTY1MDY=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/comp:lite", "name": "comp:lite", "color": "0052cc", "default": false, "description": "TF Lite related issues" }, { "id": 4829271983, "node_id": "LA_kwDOArmXAs8AAAABH9jXrw", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/TF%202.11", "name": "TF 2.11", "color": "46B4D7", "default": false, "description": "Issues related to TF 2.11" } ]
closed
false
{ "login": "pjpratik", "id": 118897289, "node_id": "U_kgDOBxY6iQ", "avatar_url": "https://avatars.githubusercontent.com/u/118897289?v=4", "gravatar_id": "", "url": "https://api.github.com/users/pjpratik", "html_url": "https://github.com/pjpratik", "followers_url": "https://api.github.com/users/pjpratik/followers", "following_url": "https://api.github.com/users/pjpratik/following{/other_user}", "gists_url": "https://api.github.com/users/pjpratik/gists{/gist_id}", "starred_url": "https://api.github.com/users/pjpratik/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/pjpratik/subscriptions", "organizations_url": "https://api.github.com/users/pjpratik/orgs", "repos_url": "https://api.github.com/users/pjpratik/repos", "events_url": "https://api.github.com/users/pjpratik/events{/privacy}", "received_events_url": "https://api.github.com/users/pjpratik/received_events", "type": "User", "site_admin": false }
[ { "login": "pjpratik", "id": 118897289, "node_id": "U_kgDOBxY6iQ", "avatar_url": "https://avatars.githubusercontent.com/u/118897289?v=4", "gravatar_id": "", "url": "https://api.github.com/users/pjpratik", "html_url": "https://github.com/pjpratik", "followers_url": "https://api.github.com/users/pjpratik/followers", "following_url": "https://api.github.com/users/pjpratik/following{/other_user}", "gists_url": "https://api.github.com/users/pjpratik/gists{/gist_id}", "starred_url": "https://api.github.com/users/pjpratik/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/pjpratik/subscriptions", "organizations_url": "https://api.github.com/users/pjpratik/orgs", "repos_url": "https://api.github.com/users/pjpratik/repos", "events_url": "https://api.github.com/users/pjpratik/events{/privacy}", "received_events_url": "https://api.github.com/users/pjpratik/received_events", "type": "User", "site_admin": false } ]
null
[ "Hi @gootaoo and @sushreebarsa, this issue similar to https://github.com/grpc/grpc/issues/29167\r\nI think, the actual issue is x86_windows(32 bits) is not supported yet for Windows. You can successfully create a build with\r\n bazel --output_user_root=./../tensorflow_build build -s --config=opt --define tflite_with_xnnpack=true --cpu=x64_\r\nwindows //tensorflow/lite:tensorflowlite.dll", "Thanks for reply, @mraunak and @sushreebarsa it should support compiling x86 (32-bit) compilation. When I remove the tflite_with_xnnpack parameter, it can be compiled successfully.\r\n", "@gootaoo could you please confirm if your CPU supports SSE2, SSE4, AVX, AVX2, or AVX512. As per documentation https://blog.tensorflow.org/2020/07/accelerating-tensorflow-lite-xnnpack-integration.html, the 'xnnpack' optimizes these instruction sets.", "@gootaoo Could you please refer to the comment above and update on the same. Thank you!", "Hi @mraunak @sushreebarsa , my cpu supports SSE2, SSE4.1, SSE4.2, AVX and AVX2, i want to compile the Windows 32-bit TFLite library and support XNNPACK acceleration. Is there any other way?", "Hi @gootaoo \r\n\r\nThe bazel build support for XNNPACK on 32 built windows might not be supported as [this](https://github.com/google/XNNPACK/issues/4637#issuecomment-1502152928) comment suggests.\r\n\r\nThe CMAKE build has support for XNNPACK on Windows as per the [documentation](https://www.tensorflow.org/lite/guide/build_cmake#available_options_to_build_tensorflow_lite).\r\n\r\nCould you please try building using CMAKE using these [instructions](https://www.tensorflow.org/lite/guide/build_cmake) and using `DTFLITE_ENABLE_XNNPACK = ON`.\r\n\r\n`cmake ../tensorflow_src/tensorflow/lite -DTFLITE_ENABLE_XNNPACK = ON`\r\n\r\nThanks.", "Hi @pjpratik when i run: cmake -DCMAKE_GENERATOR_PLATFORM=Win32 -DTFLITE_ENABLE_XNNPACK=ON ../../tensorflow-r2.5/tensorflow/lite, i got errors : \r\n\r\n`Completed 'pthreadpool'\r\n Building Custom Rule C:/Users/xxx/Desktop/tensorflow-r2.5-tflite-win/tflitecpp-x86/pthreadpool-download/CMakeLists.txt\r\n Building Custom Rule C:/Users/xxx/Desktop/tensorflow-r2.5-tflite-win/tflitecpp-x86/pthreadpool-download/CMakeLists.txt\r\nCMake Error at C:/Users/xxx/Desktop/tensorflow-r2.5-tflite-win/tflitecpp-x86/xnnpack/CMakeLists.txt:2928 (ADD_SUBDIRECTORY):\r\n ADD_SUBDIRECTORY given source\r\n \"C:/Users/xxx/Desktop/tensorflow-r2.5-tflite-win/tflitecpp-x86/clog-source/deps/clog\"\r\n which is not an existing directory.\r\n\r\n\r\nCMake Error at C:/Users/xxx/Desktop/tensorflow-r2.5-tflite-win/tflitecpp-x86/xnnpack/CMakeLists.txt:2932 (SET_PROPERTY):\r\n SET_PROPERTY could not find TARGET clog. Perhaps it has not yet been created.\r\n\r\n\r\nCMake Error at C:/Users/xxx/Desktop/tensorflow-r2.5-tflite-win/tflitecpp-x86/cpuinfo-source/CMakeLists.txt:255 (ADD_SUBDIRECTORY):\r\n ADD_SUBDIRECTORY not given a binary directory but the given source\r\n directory\r\n \"C:/Users/xxx/Desktop/tensorflow-r2.5-tflite-win/tflitecpp-x86/clog-source\"\r\n is not a subdirectory of\r\n \"C:/Users/xxx/Desktop/tensorflow-r2.5-tflite-win/tflitecpp-x86/cpuinfo-source\".\r\n When specifying an out-of-tree source a binary directory must be explicitly\r\n specified.\r\n\r\n\r\nCMake Error at C:/Users/xxx/Desktop/tensorflow-r2.5-tflite-win/tflitecpp-x86/cpuinfo-source/CMakeLists.txt:258 (SET_PROPERTY):\r\n SET_PROPERTY could not find TARGET clog. Perhaps it has not yet been created.`\r\n\r\n**When I build the TFLite C library, I can get a XNNPACK.lib library, reference it in the project has no effect, how can I add the XNNPACK delegate ?**\r\n\r\nThanks.", "Hi @gootaoo \r\n\r\nThe CMake should choose platform automatically when building the files if not specified. \r\n\r\nCan you please try `cmake tensorflow/lite -DTFLITE_ENABLE_XNNPACK=ON` ?\r\n\r\nAlso, can you try with latest stable version which is `r2.12`.\r\n\r\n I have tried to build on x64 windows with `r2.12` and was able to build without any error. Please find the screenshots below.\r\n\r\n<img width=\"956\" alt=\"Screenshot 2023-04-24 at 11 55 29 AM\" src=\"https://user-images.githubusercontent.com/118897289/233917267-09171f37-7ba3-4b44-be56-27054963f691.png\">\r\n\r\n<img width=\"751\" alt=\"Screenshot 2023-04-24 at 11 56 14 AM\" src=\"https://user-images.githubusercontent.com/118897289/233917245-a170254d-a3b6-401b-ba36-8b8659c716f3.png\">\r\n\r\nThanks.\r\n\r\n\r\n", "Hi @pjpratik x64 compilation is fine, i just want to compile an x86 (32-bit) TFLite library and support XNNPACK acceleration (or other acceleration), do I need to find a 32-bit window computer? thanks.", "Hi @gootaoo \r\n\r\nCould you please try with `cmake -A Win32 ..\\tensorflow\\lite -DTFLITE_ENABLE_XNNPACK=ON` command on your machine?\r\n\r\nPlease see the relevant thread [#47166](https://github.com/tensorflow/tensorflow/issues/47166) and let us know if it helps.\r\n\r\nThanks.", "This issue is stale because it has been open for 7 days with no activity. It will be closed if no further activity occurs. Thank you.", "Hi @pjpratik \r\nIt works fine for me, thank you so much !", "Hi @gootaoo \r\n\r\nGlad it worked. Feel free to close the issue if it is resolved.\r\n\r\nThanks." ]
2023-04-06T09:09:12
2023-05-10T14:33:46
2023-05-10T14:33:46
NONE
null
null
null
<details><summary>Click to expand!</summary> ### Issue Type Bug ### Have you reproduced the bug with TF nightly? Yes ### Source source ### Tensorflow Version r2.9,r2.10,2.11 ### Custom Code No ### OS Platform and Distribution Windows 11 ### Mobile device _No response_ ### Python version _No response_ ### Bazel version _No response_ ### GCC/Compiler version _No response_ ### CUDA/cuDNN version _No response_ ### GPU model and memory _No response_ ### Current Behaviour? ```shell run: bazel --output_user_root=./../tensorflow_build build -s --config=opt --define tflite_with_xnnpack=true --cpu=x64_x86_windows //tensorflow/lite:tensorflowlite.dll ``` ### Standalone code to reproduce the issue ```shell result: ERROR: C:/users/togrey/desktop/tensorflow_build/master1/gaunzc4b/external/XNNPACK/BUILD.bazel:4762:26: configurable attribute "deps" in @XNNPACK//:amalgam_microkernels doesn't match this configuration. Would a default condition help? Conditions checked: @XNNPACK//:aarch32 @XNNPACK//:aarch64 @XNNPACK//:x86 @XNNPACK//:emscripten_wasm @XNNPACK//:emscripten_wasmsimd @XNNPACK//:emscripten_wasmrelaxedsimd @XNNPACK//:riscv To see a condition's definition, run: bazel query --output=build <condition label>. On tf version r2.9: ERROR: C:/users/togrey/desktop/tensorflow_build/2.11/gaunzc4b/external/cpuinfo/BUILD.bazel:103:11: configurable attribute "srcs" in @cpuinfo//:cpuinfo_impl doesn't match this configuration. Would a default condition help? Conditions checked: @cpuinfo//:linux_x86_64 @cpuinfo//:linux_arm @cpuinfo//:linux_armhf @cpuinfo//:linux_armv7a @cpuinfo//:linux_armeabi @cpuinfo//:linux_aarch64 @cpuinfo//:linux_mips64 @cpuinfo//:linux_riscv64 @cpuinfo//:linux_s390x @cpuinfo//:macos_x86_64 @cpuinfo//:macos_arm64 @cpuinfo//:windows_x86_64 @cpuinfo//:android_armv7 @cpuinfo//:android_arm64 @cpuinfo//:android_x86 @cpuinfo//:android_x86_64 @cpuinfo//:ios_x86_64 @cpuinfo//:ios_x86 @cpuinfo//:ios_armv7 @cpuinfo//:ios_arm64 @cpuinfo//:ios_arm64e @cpuinfo//:ios_sim_arm64 @cpuinfo//:watchos_x86_64 @cpuinfo//:watchos_x86 @cpuinfo//:watchos_armv7k @cpuinfo//:watchos_arm64_32 @cpuinfo//:tvos_x86_64 @cpuinfo//:tvos_arm64 @cpuinfo//:emscripten_wasm To see a condition's definition, run: bazel query --output=build <condition label>. ``` ### Relevant log output _No response_</details>
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/60253/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/60253/timeline
null
completed
false
https://api.github.com/repos/tensorflow/tensorflow/issues/60252
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/60252/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/60252/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/60252/events
https://github.com/tensorflow/tensorflow/pull/60252
1,656,957,049
PR_kwDOArmXAs5NvuOR
60,252
Fixed the broken link in overview.md file
{ "login": "tilakrayal", "id": 81610181, "node_id": "MDQ6VXNlcjgxNjEwMTgx", "avatar_url": "https://avatars.githubusercontent.com/u/81610181?v=4", "gravatar_id": "", "url": "https://api.github.com/users/tilakrayal", "html_url": "https://github.com/tilakrayal", "followers_url": "https://api.github.com/users/tilakrayal/followers", "following_url": "https://api.github.com/users/tilakrayal/following{/other_user}", "gists_url": "https://api.github.com/users/tilakrayal/gists{/gist_id}", "starred_url": "https://api.github.com/users/tilakrayal/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/tilakrayal/subscriptions", "organizations_url": "https://api.github.com/users/tilakrayal/orgs", "repos_url": "https://api.github.com/users/tilakrayal/repos", "events_url": "https://api.github.com/users/tilakrayal/events{/privacy}", "received_events_url": "https://api.github.com/users/tilakrayal/received_events", "type": "User", "site_admin": false }
[ { "id": 390482148, "node_id": "MDU6TGFiZWwzOTA0ODIxNDg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/awaiting%20review", "name": "awaiting review", "color": "bc3869", "default": false, "description": "Pull request awaiting review" }, { "id": 750616506, "node_id": "MDU6TGFiZWw3NTA2MTY1MDY=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/comp:lite", "name": "comp:lite", "color": "0052cc", "default": false, "description": "TF Lite related issues" }, { "id": 987666414, "node_id": "MDU6TGFiZWw5ODc2NjY0MTQ=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/ready%20to%20pull", "name": "ready to pull", "color": "2cd643", "default": false, "description": "PR ready for merge process" }, { "id": 1169364259, "node_id": "MDU6TGFiZWwxMTY5MzY0MjU5", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/size:XS", "name": "size:XS", "color": "adafea", "default": false, "description": "CL Change Size: Extra Small" } ]
closed
false
{ "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false }
[ { "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false } ]
null
[ "Hi @yishuangP Can you please review this PR ? Thank you!", "Hi @lu-wang-g Can you please review this PR ? Thank you!" ]
2023-04-06T08:56:44
2023-06-15T10:49:33
2023-06-10T22:54:22
CONTRIBUTOR
null
false
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/pulls/60252", "html_url": "https://github.com/tensorflow/tensorflow/pull/60252", "diff_url": "https://github.com/tensorflow/tensorflow/pull/60252.diff", "patch_url": "https://github.com/tensorflow/tensorflow/pull/60252.patch", "merged_at": "2023-06-10T22:54:22" }
Fixed the broken link for **TensorFlow Lite Task Library** in `overview.md` file
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/60252/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/60252/timeline
null
null
true
https://api.github.com/repos/tensorflow/tensorflow/issues/60251
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/60251/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/60251/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/60251/events
https://github.com/tensorflow/tensorflow/pull/60251
1,656,784,909
PR_kwDOArmXAs5NvLNY
60,251
Update padding='SAME' in tf.image.ssim API
{ "login": "SuryanarayanaY", "id": 116063290, "node_id": "U_kgDOBur8Og", "avatar_url": "https://avatars.githubusercontent.com/u/116063290?v=4", "gravatar_id": "", "url": "https://api.github.com/users/SuryanarayanaY", "html_url": "https://github.com/SuryanarayanaY", "followers_url": "https://api.github.com/users/SuryanarayanaY/followers", "following_url": "https://api.github.com/users/SuryanarayanaY/following{/other_user}", "gists_url": "https://api.github.com/users/SuryanarayanaY/gists{/gist_id}", "starred_url": "https://api.github.com/users/SuryanarayanaY/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/SuryanarayanaY/subscriptions", "organizations_url": "https://api.github.com/users/SuryanarayanaY/orgs", "repos_url": "https://api.github.com/users/SuryanarayanaY/repos", "events_url": "https://api.github.com/users/SuryanarayanaY/events{/privacy}", "received_events_url": "https://api.github.com/users/SuryanarayanaY/received_events", "type": "User", "site_admin": false }
[ { "id": 474725938, "node_id": "MDU6TGFiZWw0NzQ3MjU5Mzg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/stale", "name": "stale", "color": "d4c5f9", "default": false, "description": "This label marks the issue/pr stale - to be closed automatically if no activity" }, { "id": 1097547147, "node_id": "MDU6TGFiZWwxMDk3NTQ3MTQ3", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/comp:ops", "name": "comp:ops", "color": "0052cc", "default": false, "description": "OPs related issues" }, { "id": 1169364259, "node_id": "MDU6TGFiZWwxMTY5MzY0MjU5", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/size:XS", "name": "size:XS", "color": "adafea", "default": false, "description": "CL Change Size: Extra Small" } ]
closed
false
{ "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false }
[ { "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false } ]
null
[ "Hi @cantonios Can you please review this PR ? Thank you!", "Hi @SuryanarayanaY Can you please check @cantonios's [comments](https://github.com/tensorflow/tensorflow/pull/60251#pullrequestreview-1419096529) ? Thank you!", "Hi @SuryanarayanaY Any update on this PR? Please. Thank you!", "I need some information on which tests are failing.Shall we need to update the all the failed test cases ? A test demo shall be appreciated.\r\n Are those tests listed here at i[mage_ops_test.py](https://github.com/tensorflow/tensorflow/blob/master/tensorflow/python/ops/image_ops_test.py) ?", "Hi @cantonios Can you please assist on above [comments](https://github.com/tensorflow/tensorflow/pull/60251#issuecomment-1582164124) from @SuryanarayanaY. Thank you!", "`//tensorflow/python:image_ops_test_cpu` fails, for example. Pretty much every existing test that actually uses ssim.\r\n\r\nYes, all the tests need to be updated.", "Hi @SuryanarayanaY Any update on this PR? Please. Thank you!\r\n", "Hi @SuryanarayanaY Any update on this PR? Please. Thank you!", "Need some time to work on this.Thanks!", "This PR is stale because it has been open for 14 days with no activity. It will be closed if no further activity occurs. Thank you.", "This PR was closed because it has been inactive for 14 days since being marked as stale. Please reopen if you'd like to work on this further." ]
2023-04-06T06:59:28
2024-02-08T19:59:57
2023-08-19T01:45:36
COLLABORATOR
null
false
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/pulls/60251", "html_url": "https://github.com/tensorflow/tensorflow/pull/60251", "diff_url": "https://github.com/tensorflow/tensorflow/pull/60251.diff", "patch_url": "https://github.com/tensorflow/tensorflow/pull/60251.patch", "merged_at": null }
Currently the API `tf.image.ssim` is using `padding='VALID'` internally. But with this padding the shape of the output is not matching with what documentation states. With `return_index_map=True` the output shape should be `broadcast(img1.shape[:-1], img2.shape[:-1])`. But with` padding='VALID'`, for input of shape `(16, 2106, 80, 1)` the current output shape is `(16, 2096, 70)` which is not matching with the expected output which should be `(16, 2106, 80)`. With `padding='SAME'` the output is matching to the desired output. Please refer to the attached [gist](https://colab.research.google.com/gist/SuryanarayanaY/d75ef4fcbd69b5211975fd4d29490084/59067_r1.ipynb) showcasing all the mentioned details. Fixes #59067
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/60251/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/60251/timeline
null
null
true
https://api.github.com/repos/tensorflow/tensorflow/issues/60250
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/60250/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/60250/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/60250/events
https://github.com/tensorflow/tensorflow/pull/60250
1,656,596,441
PR_kwDOArmXAs5NukJ1
60,250
Fixed bug with DEBUG_MODE bug when performing from_tensor_slices on a ragged tensor
{ "login": "jsparson1", "id": 94084697, "node_id": "U_kgDOBZueWQ", "avatar_url": "https://avatars.githubusercontent.com/u/94084697?v=4", "gravatar_id": "", "url": "https://api.github.com/users/jsparson1", "html_url": "https://github.com/jsparson1", "followers_url": "https://api.github.com/users/jsparson1/followers", "following_url": "https://api.github.com/users/jsparson1/following{/other_user}", "gists_url": "https://api.github.com/users/jsparson1/gists{/gist_id}", "starred_url": "https://api.github.com/users/jsparson1/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/jsparson1/subscriptions", "organizations_url": "https://api.github.com/users/jsparson1/orgs", "repos_url": "https://api.github.com/users/jsparson1/repos", "events_url": "https://api.github.com/users/jsparson1/events{/privacy}", "received_events_url": "https://api.github.com/users/jsparson1/received_events", "type": "User", "site_admin": false }
[ { "id": 474725938, "node_id": "MDU6TGFiZWw0NzQ3MjU5Mzg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/stale", "name": "stale", "color": "d4c5f9", "default": false, "description": "This label marks the issue/pr stale - to be closed automatically if no activity" }, { "id": 1114343535, "node_id": "MDU6TGFiZWwxMTE0MzQzNTM1", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/comp:data", "name": "comp:data", "color": "0052cc", "default": false, "description": "tf.data related issues" }, { "id": 1169364259, "node_id": "MDU6TGFiZWwxMTY5MzY0MjU5", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/size:XS", "name": "size:XS", "color": "adafea", "default": false, "description": "CL Change Size: Extra Small" } ]
closed
false
{ "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false }
[ { "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false } ]
null
[ "Please don't use \"add file\"/\"update file\"/\"fix file\"/etc. commit messages. These are hard to reason about when looking at the history of the file/repository. Instead, please write explanatory git commit messages.\r\n\r\nThe commit message is also the title of the PR if the PR has only one commit. It is thus twice important to have commit messages that are relevant, as PRs would be easier to understand and easier to analyze in search results.\r\n\r\nFor how to write good quality git commit messages, please consult https://cbea.ms/git-commit/ ", "Note that the proposed fix is not really a fix -- it just switches off eager mode for ragged tensor results, which is not what should happen.\r\n\r\nInstead, the problem is really the `ops.convert_to_tensor` on the following line:\r\nhttps://github.com/tensorflow/tensorflow/blob/06390d9be42502bb14c055be3978e5cd52a0f376/tensorflow/python/data/ops/structured_function.py#L240\r\n\r\nThe dataset elements can be ragged or sparse tensors, so this conversion must instead honor the type specs in `self._output_structure`. Maybe it is even the case that for ragged/sparse tensors, these must have been constructed explicitly in the mapping function and no further conversion is necessary (while for a usual tensor, the mapping function might return a Python list that needs to be converted to a tensor)?\r\n\r\nLast but not least, such a change requires tests to verify that the fix works and that the problem will never appear again (and apart the ragged tensors mentioned in #60239, it should also include support for sparse tensors).", "Hi @jsparson1 Can you please check @mihaimaruseac's comments and keep us posted ? Thank you!", "> Hi @jsparson1 Can you please check @mihaimaruseac's comments and keep us posted ? Thank you!<\r\n\r\nYes, I can and I plan on it right now I have some other stuff I'm dealing with, I will be able to work on improving my fix and writing tests in the coming days, thank you all for your feedback.", "ข้อทราบข้อมูล ไฟล์งานที่คุณ ส่งคำขอดึง ระบบของเราด้วย\r\nเพราะข้อมูลที่คุณส่งมา ทั้งหมด คือไฟล์งานของ ทีม ระบบ GitHub ทั้งหมด\r\n\r\nทีม Marketplace\r\nKhaokho29th\r\n\r\nเมื่อ 5 พ.ค. 2023 20:28 น. \"Josh Parson\" ***@***.***> เขียนว่า\r\n\r\nHi @jsparson1 <https://github.com/jsparson1> Can you please check\r\n@mihaimaruseac <https://github.com/mihaimaruseac>'s comments and keep us\r\nposted ? Thank you!\r\nYes I can and I plan on it right now I'm in the middle of exams, I will be\r\nable to work on improving my fix in the coming days, thank you all for your\r\nfeedback.\r\n\r\n—\r\nReply to this email directly, view it on GitHub\r\n<https://github.com/tensorflow/tensorflow/pull/60250#issuecomment-1536256217>,\r\nor unsubscribe\r\n<https://github.com/notifications/unsubscribe-auth/ATYRUDCSE3NSIZMCFWHK5NDXET57DANCNFSM6AAAAAAWU3AWLI>\r\n.\r\nYou are receiving this because you are subscribed to this thread.Message\r\nID: ***@***.***>\r\n", "> Note that the proposed fix is not really a fix -- it just switches off eager mode for ragged tensor results, which is not what should happen.\r\n> \r\n> Instead, the problem is really the `ops.convert_to_tensor` on the following line:\r\n> \r\n> https://github.com/tensorflow/tensorflow/blob/06390d9be42502bb14c055be3978e5cd52a0f376/tensorflow/python/data/ops/structured_function.py#L240\r\n> \r\n> The dataset elements can be ragged or sparse tensors, so this conversion must instead honor the type specs in `self._output_structure`. Maybe it is even the case that for ragged/sparse tensors, these must have been constructed explicitly in the mapping function and no further conversion is necessary (while for a usual tensor, the mapping function might return a Python list that needs to be converted to a tensor)?\r\n> \r\n> Last but not least, such a change requires tests to verify that the fix works and that the problem will never appear again (and apart the ragged tensors mentioned in #60239, it should also include support for sparse tensors).\r\n\r\nI just got an opportunity to look at it again and I actually think its the previous line\r\n`print(\"TestStart\")`\r\n `ret = structure.to_tensor_list(self._output_structure, ret)`\r\n `print(\"TestEnd\")`\r\n\r\n\r\nNote only TestStart prints out\r\nTestStart\r\n2023-05-10 22:16:10.385226: W tensorflow/core/framework/op_kernel.cc:1817] INVALID_ARGUMENT: ValueError: Value [1 2] is not convertible to a tensor with dtype <dtype: 'variant'> and shape ().\r\nTraceback (most recent call last):\r\n\r\na possible fix could be padding the ragged tensors but that's kind hacky I will look into an alternative solution", "You are right that the crash already happens in `to_tensor_list`.\r\n\r\nProblem is that the ragged tensor has already been converted using the https://www.tensorflow.org/api_docs/python/tf/raw_ops/RaggedTensorToVariant, so the `_output_structure` contains just \"this is a Tensor of dtype variant\" instead of \"this is a ragged tensor\". But maybe we could modify the `TensorSpec._to_components` to be able to handle such situation -- i.e., if it gets a ragged tensor and should convert it to `variant` dtype, it could use the above mentioned method to do it, instead of `ops.convert_to_tensor`? I just tried, but I could not make it work easily; maybe we should investigate more how exactly the processing works without the debug mode and handle the conversions ragged<->dense as it is done there.", "Hi @jsparson1 Any update on this PR? Please. Thank you!", "This PR is stale because it has been open for 14 days with no activity. It will be closed if no further activity occurs. Thank you.", "This PR was closed because it has been inactive for 14 days since being marked as stale. Please reopen if you'd like to work on this further." ]
2023-04-06T03:12:51
2023-08-10T01:54:37
2023-08-10T01:54:32
NONE
null
false
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/pulls/60250", "html_url": "https://github.com/tensorflow/tensorflow/pull/60250", "diff_url": "https://github.com/tensorflow/tensorflow/pull/60250.diff", "patch_url": "https://github.com/tensorflow/tensorflow/pull/60250.patch", "merged_at": null }
Fixed bug with DEBUG_MODE bug when performing from_tensor_slices on a ragged tensor related to issue #60239 Thank you, if there are any suggestions feel free to comment.
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/60250/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/60250/timeline
null
null
true
https://api.github.com/repos/tensorflow/tensorflow/issues/60249
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/60249/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/60249/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/60249/events
https://github.com/tensorflow/tensorflow/pull/60249
1,656,392,319
PR_kwDOArmXAs5Nt4qB
60,249
Fixes error with DEBUG_MODE and ragged tensors for Dataset.from_tensor_slices()
{ "login": "jsparson1", "id": 94084697, "node_id": "U_kgDOBZueWQ", "avatar_url": "https://avatars.githubusercontent.com/u/94084697?v=4", "gravatar_id": "", "url": "https://api.github.com/users/jsparson1", "html_url": "https://github.com/jsparson1", "followers_url": "https://api.github.com/users/jsparson1/followers", "following_url": "https://api.github.com/users/jsparson1/following{/other_user}", "gists_url": "https://api.github.com/users/jsparson1/gists{/gist_id}", "starred_url": "https://api.github.com/users/jsparson1/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/jsparson1/subscriptions", "organizations_url": "https://api.github.com/users/jsparson1/orgs", "repos_url": "https://api.github.com/users/jsparson1/repos", "events_url": "https://api.github.com/users/jsparson1/events{/privacy}", "received_events_url": "https://api.github.com/users/jsparson1/received_events", "type": "User", "site_admin": false }
[ { "id": 1169364458, "node_id": "MDU6TGFiZWwxMTY5MzY0NDU4", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/size:S", "name": "size:S", "color": "adafea", "default": false, "description": "CL Change Size: Small" } ]
closed
false
{ "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false }
[ { "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false } ]
null
[ "Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).\n\nView this [failed invocation](https://github.com/tensorflow/tensorflow/pull/60249/checks?check_run_id=12552778778) of the CLA check for more information.\n\nFor the most up to date status, view the checks section at the bottom of the pull request." ]
2023-04-05T22:39:30
2023-04-06T03:06:22
2023-04-06T03:06:22
NONE
null
false
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/pulls/60249", "html_url": "https://github.com/tensorflow/tensorflow/pull/60249", "diff_url": "https://github.com/tensorflow/tensorflow/pull/60249.diff", "patch_url": "https://github.com/tensorflow/tensorflow/pull/60249.patch", "merged_at": null }
This change fixes issue #60239. Thank you, if you have any changes feel free to comment
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/60249/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/60249/timeline
null
null
true
https://api.github.com/repos/tensorflow/tensorflow/issues/60248
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/60248/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/60248/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/60248/events
https://github.com/tensorflow/tensorflow/pull/60248
1,656,195,584
PR_kwDOArmXAs5NtOg5
60,248
r2.12 cherry-pick: 828e7e6b894 "Make sure tflite doesn't call xnnpack kernels directly when tflite_with_xnnpack is explicitly set to false."
{ "login": "tensorflow-jenkins", "id": 16359713, "node_id": "MDQ6VXNlcjE2MzU5NzEz", "avatar_url": "https://avatars.githubusercontent.com/u/16359713?v=4", "gravatar_id": "", "url": "https://api.github.com/users/tensorflow-jenkins", "html_url": "https://github.com/tensorflow-jenkins", "followers_url": "https://api.github.com/users/tensorflow-jenkins/followers", "following_url": "https://api.github.com/users/tensorflow-jenkins/following{/other_user}", "gists_url": "https://api.github.com/users/tensorflow-jenkins/gists{/gist_id}", "starred_url": "https://api.github.com/users/tensorflow-jenkins/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/tensorflow-jenkins/subscriptions", "organizations_url": "https://api.github.com/users/tensorflow-jenkins/orgs", "repos_url": "https://api.github.com/users/tensorflow-jenkins/repos", "events_url": "https://api.github.com/users/tensorflow-jenkins/events{/privacy}", "received_events_url": "https://api.github.com/users/tensorflow-jenkins/received_events", "type": "User", "site_admin": false }
[]
closed
false
null
[]
null
[]
2023-04-05T19:51:59
2023-04-13T15:34:18
2023-04-13T04:00:01
COLLABORATOR
null
false
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/pulls/60248", "html_url": "https://github.com/tensorflow/tensorflow/pull/60248", "diff_url": "https://github.com/tensorflow/tensorflow/pull/60248.diff", "patch_url": "https://github.com/tensorflow/tensorflow/pull/60248.patch", "merged_at": "2023-04-13T04:00:01" }
Refer to the original commit: https://github.com/tensorflow/tensorflow/commit/828e7e6b89428c553621366a5c7ac7722e157409
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/60248/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/60248/timeline
null
null
true
https://api.github.com/repos/tensorflow/tensorflow/issues/60247
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/60247/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/60247/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/60247/events
https://github.com/tensorflow/tensorflow/issues/60247
1,655,923,088
I_kwDOArmXAs5is2GQ
60,247
output Tensor data pointer is NULL before calling Invoke()
{ "login": "aflaischer", "id": 26463144, "node_id": "MDQ6VXNlcjI2NDYzMTQ0", "avatar_url": "https://avatars.githubusercontent.com/u/26463144?v=4", "gravatar_id": "", "url": "https://api.github.com/users/aflaischer", "html_url": "https://github.com/aflaischer", "followers_url": "https://api.github.com/users/aflaischer/followers", "following_url": "https://api.github.com/users/aflaischer/following{/other_user}", "gists_url": "https://api.github.com/users/aflaischer/gists{/gist_id}", "starred_url": "https://api.github.com/users/aflaischer/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/aflaischer/subscriptions", "organizations_url": "https://api.github.com/users/aflaischer/orgs", "repos_url": "https://api.github.com/users/aflaischer/repos", "events_url": "https://api.github.com/users/aflaischer/events{/privacy}", "received_events_url": "https://api.github.com/users/aflaischer/received_events", "type": "User", "site_admin": false }
[ { "id": 473172988, "node_id": "MDU6TGFiZWw0NzMxNzI5ODg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/type:bug", "name": "type:bug", "color": "159b2e", "default": false, "description": "Bug" }, { "id": 750616506, "node_id": "MDU6TGFiZWw3NTA2MTY1MDY=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/comp:lite", "name": "comp:lite", "color": "0052cc", "default": false, "description": "TF Lite related issues" }, { "id": 4511033337, "node_id": "LA_kwDOArmXAs8AAAABDODn-Q", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/TF%202.10", "name": "TF 2.10", "color": "C15088", "default": false, "description": "" } ]
closed
false
{ "login": "sachinprasadhs", "id": 73069040, "node_id": "MDQ6VXNlcjczMDY5MDQw", "avatar_url": "https://avatars.githubusercontent.com/u/73069040?v=4", "gravatar_id": "", "url": "https://api.github.com/users/sachinprasadhs", "html_url": "https://github.com/sachinprasadhs", "followers_url": "https://api.github.com/users/sachinprasadhs/followers", "following_url": "https://api.github.com/users/sachinprasadhs/following{/other_user}", "gists_url": "https://api.github.com/users/sachinprasadhs/gists{/gist_id}", "starred_url": "https://api.github.com/users/sachinprasadhs/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sachinprasadhs/subscriptions", "organizations_url": "https://api.github.com/users/sachinprasadhs/orgs", "repos_url": "https://api.github.com/users/sachinprasadhs/repos", "events_url": "https://api.github.com/users/sachinprasadhs/events{/privacy}", "received_events_url": "https://api.github.com/users/sachinprasadhs/received_events", "type": "User", "site_admin": false }
[ { "login": "sachinprasadhs", "id": 73069040, "node_id": "MDQ6VXNlcjczMDY5MDQw", "avatar_url": "https://avatars.githubusercontent.com/u/73069040?v=4", "gravatar_id": "", "url": "https://api.github.com/users/sachinprasadhs", "html_url": "https://github.com/sachinprasadhs", "followers_url": "https://api.github.com/users/sachinprasadhs/followers", "following_url": "https://api.github.com/users/sachinprasadhs/following{/other_user}", "gists_url": "https://api.github.com/users/sachinprasadhs/gists{/gist_id}", "starred_url": "https://api.github.com/users/sachinprasadhs/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sachinprasadhs/subscriptions", "organizations_url": "https://api.github.com/users/sachinprasadhs/orgs", "repos_url": "https://api.github.com/users/sachinprasadhs/repos", "events_url": "https://api.github.com/users/sachinprasadhs/events{/privacy}", "received_events_url": "https://api.github.com/users/sachinprasadhs/received_events", "type": "User", "site_admin": false } ]
null
[ "The behavior you are seeing where the data pointer of the output tensor is null before calling Invoke() is expected.\r\n\r\nWhen you call interpreter_->AllocateTensors() it allocates the memory for input and output tensors, but it doesn't fill it with any data. So, the data pointer of the output tensor will be null until you run the model using Invoke().\r\n\r\nAfter calling Invoke(), the output tensor should have valid data. In your code, you can see that the output tensor data pointer is not null after calling Invoke().\r\n\r\nSo, you can proceed with running your model after calling Invoke().", "Hello,\r\n\r\nHere I'm displaying the address of the input tensor data and output tensor data, I know that I put no data in the input tensor but what I want to understand is if it is normal to have the address of the tensor data changed dynamically.\r\n\r\nIf you look closely even the input tensor data address is changed:\r\nBefore Invoke inputTensor= **0x56253a528800** outputTensor= 0\r\nAfter Invoke inputTensor= **0x56253ab84d00** outputTensor= 0x56253ab84e00\r\n\r\nHere is an example with another model;\r\nBefore Invoke inputTensor= 0x557794e44700 outputTensor= 0x557794e44a00\r\nAfter Invoke inputTensor= 0x557794e44700 outputTensor= 0x557794e44a00\r\n\r\nThe addresses are not changed, after the Invoke() call.\r\n\r\nI also made a test by adding a loop of 10 runs and the addresses are only changed on the first run:\r\nBefore Invoke inputTensor= 0x559539f2c800 outputTensor= 0\r\nAfter Invoke inputTensor= 0x55953a588d00 outputTensor= 0x55953a588e00\r\nBefore Invoke inputTensor= 0x55953a588d00 outputTensor= 0x55953a588e00\r\nAfter Invoke inputTensor= 0x55953a588d00 outputTensor= 0x55953a588e00\r\nBefore Invoke inputTensor= 0x55953a588d00 outputTensor= 0x55953a588e00\r\nAfter Invoke inputTensor= 0x55953a588d00 outputTensor= 0x55953a588e00\r\nBefore Invoke inputTensor= 0x55953a588d00 outputTensor= 0x55953a588e00\r\nAfter Invoke inputTensor= 0x55953a588d00 outputTensor= 0x55953a588e00\r\nBefore Invoke inputTensor= 0x55953a588d00 outputTensor= 0x55953a588e00\r\nAfter Invoke inputTensor= 0x55953a588d00 outputTensor= 0x55953a588e00\r\nBefore Invoke inputTensor= 0x55953a588d00 outputTensor= 0x55953a588e00\r\nAfter Invoke inputTensor= 0x55953a588d00 outputTensor= 0x55953a588e00\r\nBefore Invoke inputTensor= 0x55953a588d00 outputTensor= 0x55953a588e00\r\nAfter Invoke inputTensor= 0x55953a588d00 outputTensor= 0x55953a588e00\r\nBefore Invoke inputTensor= 0x55953a588d00 outputTensor= 0x55953a588e00\r\nAfter Invoke inputTensor= 0x55953a588d00 outputTensor= 0x55953a588e00\r\nBefore Invoke inputTensor= 0x55953a588d00 outputTensor= 0x55953a588e00\r\nAfter Invoke inputTensor= 0x55953a588d00 outputTensor= 0x55953a588e00\r\nBefore Invoke inputTensor= 0x55953a588d00 outputTensor= 0x55953a588e00\r\nAfter Invoke inputTensor= 0x55953a588d00 outputTensor= 0x55953a588e00\r\n\r\ncode with loop:\r\n```\r\nbool ModelTfLite::Invoke()\r\n{\r\n TfLiteStatus status;\r\n\r\n interpreter_->AllocateTensors();\r\n\r\n for(int i = 0; i < 10; i++) {\r\n void* inputTensor = interpreter_->input_tensor(0)->data.data;\r\n void* outputTensor = interpreter_->output_tensor(0)->data.data;\r\n std::cout << \"Before Invoke inputTensor= \" << inputTensor << \" outputTensor= \" << outputTensor << \"\\n\";\r\n\r\n status = interpreter_->Invoke();\r\n\r\n inputTensor = interpreter_->input_tensor(0)->data.data;\r\n outputTensor = interpreter_->output_tensor(0)->data.data;\r\n std::cout << \"After Invoke inputTensor= \" << inputTensor << \" outputTensor= \" << outputTensor << \"\\n\";\r\n\r\n if(status != kTfLiteOk) {\r\n std::cout << \"Failed to run Invoke(): \" << status << \"\\n\" ;\r\n return false;\r\n }\r\n }\r\n return true;\r\n}\r\n```\r\n\r\nSo my question is it expected to have the data tensor pointer dynamically changed even if I never call AllocateTensors again?", "It is normal for the memory addresses of the input and output tensors to change dynamically during the runtime of the program. When you call interpreter_->AllocateTensors(), the interpreter allocates memory for the input and output tensors. The memory allocation may cause the memory addresses to change, as the interpreter may allocate memory in a different location.\r\n\r\nAdditionally, when you call interpreter_->Invoke(), the interpreter may perform some internal operations that could change the memory addresses of the input and output tensors. However, this should not cause any issues as long as you access the tensors using the interpreter_->input_tensor() and interpreter_->output_tensor() functions, as these functions will return the correct pointers to the input and output tensors regardless of their memory addresses.\r\n\r\nTherefore, it is expected that the memory addresses of the input and output tensors may change dynamically during the runtime of your program.", "Ok, I see, thanks for the explanation.\r\nSo if I have understood correctly, this should be the nominal way of using tensors:\r\n\r\n```\r\nbool ModelTfLite::Invoke()\r\n{\r\n TfLiteStatus status;\r\n\r\n interpreter_->AllocateTensors();\r\n\r\n for(int i = 0; i < 10; i++) {\r\n\r\n void* inputTensor = interpreter_->input_tensor(0)->data.data;\r\n\r\n // fill input data\r\n\r\n status = interpreter_->Invoke();\r\n\r\n if(status != kTfLiteOk) {\r\n std::cout << \"Failed to run Invoke(): \" << status << \"\\n\" ;\r\n return false;\r\n }\r\n\r\n void* outputTensor = interpreter_->output_tensor(0)->data.data;\r\n\r\n // use output data\r\n\r\n }\r\n return true;\r\n}\r\n```\r\n\r\n interpreter_->input_tensor(0)->data.data or interpreter_->output_tensor(0)->data.data should never be saved in some other variables", "Yeah that's correct. ", "Are you satisfied with the resolution of your issue?\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=Yes&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/60247\">Yes</a>\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=No&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/60247\">No</a>\n" ]
2023-04-05T16:11:08
2023-04-10T14:32:30
2023-04-10T14:32:27
NONE
null
null
null
<details><summary>Click to expand!</summary> ### Issue Type Bug ### Have you reproduced the bug with TF nightly? Yes ### Source source ### Tensorflow Version tf2.10 ### Custom Code Yes ### OS Platform and Distribution Ubuntu 20.04.4 LTS ### Mobile device _No response_ ### Python version Python 3.8.10 ### Bazel version bazel 6.1.1 ### GCC/Compiler version gcc (Ubuntu 9.4.0-1ubuntu1~20.04.1) 9.4.0 ### CUDA/cuDNN version _No response_ ### GPU model and memory _No response_ ### Current Behaviour? ```shell Hello, I run into the following issue, I try to retrieve the data pointer from the output tensor of my tensorflow lite model before running Invoke() and it is NULL. Is it the expected behavior? I would have supposed that after calling AllocateTensors() the tensors could be used. ``` ### Standalone code to reproduce the issue ```shell I run the following code: class ModelTfLite { public: ModelTfLite(const std::string& path); ~ModelTfLite() = default; bool Invoke(); private: std::unique_ptr<tflite::FlatBufferModel> model_; tflite::ops::builtin::BuiltinOpResolver resolver_; std::unique_ptr<tflite::Interpreter> interpreter_; }; ModelTfLite::ModelTfLite(const std::string& path) { model_ = tflite::FlatBufferModel::BuildFromFile(path.c_str()); assert(model_ != nullptr); tflite::InterpreterBuilder builder(*model_, resolver_); builder(&interpreter_); assert(interpreter_ != nullptr); } bool ModelTfLite::Invoke() { TfLiteStatus status; interpreter_->AllocateTensors(); void* inputTensor = interpreter_->input_tensor(0)->data.data; void* outputTensor = interpreter_->output_tensor(0)->data.data; std::cout << "Before Invoke inputTensor= " << inputTensor << " outputTensor= " << outputTensor << "\n" ; status = interpreter_->Invoke(); inputTensor = interpreter_->input_tensor(0)->data.data; outputTensor = interpreter_->output_tensor(0)->data.data; std::cout << "After Invoke inputTensor= " << inputTensor << " outputTensor= " << outputTensor << "\n" ; if(status != kTfLiteOk) { std::cout << "Failed to run Invoke(): " << status << "\n" ; return false; } return true; } main: int main(int argc, char* argv[]) { if (argc != 2) { fprintf(stderr, "testmodel <tflite model>\n"); return 1; } const char* filename = argv[1]; ModelTfLite m(filename); m.Invoke(); return 0; } ``` ### Relevant log output ```shell Before Invoke inputTensor= 0x56253a528800 outputTensor= 0 After Invoke inputTensor= 0x56253ab84d00 outputTensor= 0x56253ab84e00 ``` </details>
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/60247/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/60247/timeline
null
completed
false
https://api.github.com/repos/tensorflow/tensorflow/issues/60246
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/60246/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/60246/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/60246/events
https://github.com/tensorflow/tensorflow/pull/60246
1,655,854,565
PR_kwDOArmXAs5NsHEW
60,246
Allow User to Add New Training Data
{ "login": "BenRichey2", "id": 65559849, "node_id": "MDQ6VXNlcjY1NTU5ODQ5", "avatar_url": "https://avatars.githubusercontent.com/u/65559849?v=4", "gravatar_id": "", "url": "https://api.github.com/users/BenRichey2", "html_url": "https://github.com/BenRichey2", "followers_url": "https://api.github.com/users/BenRichey2/followers", "following_url": "https://api.github.com/users/BenRichey2/following{/other_user}", "gists_url": "https://api.github.com/users/BenRichey2/gists{/gist_id}", "starred_url": "https://api.github.com/users/BenRichey2/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/BenRichey2/subscriptions", "organizations_url": "https://api.github.com/users/BenRichey2/orgs", "repos_url": "https://api.github.com/users/BenRichey2/repos", "events_url": "https://api.github.com/users/BenRichey2/events{/privacy}", "received_events_url": "https://api.github.com/users/BenRichey2/received_events", "type": "User", "site_admin": false }
[ { "id": 1169364259, "node_id": "MDU6TGFiZWwxMTY5MzY0MjU5", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/size:XS", "name": "size:XS", "color": "adafea", "default": false, "description": "CL Change Size: Extra Small" } ]
closed
false
{ "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false }
[ { "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false } ]
null
[ "Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).\n\nView this [failed invocation](https://github.com/tensorflow/tensorflow/pull/60246/checks?check_run_id=12543019493) of the CLA check for more information.\n\nFor the most up to date status, view the checks section at the bottom of the pull request." ]
2023-04-05T15:35:45
2023-04-05T15:36:05
2023-04-05T15:36:05
NONE
null
false
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/pulls/60246", "html_url": "https://github.com/tensorflow/tensorflow/pull/60246", "diff_url": "https://github.com/tensorflow/tensorflow/pull/60246.diff", "patch_url": "https://github.com/tensorflow/tensorflow/pull/60246.patch", "merged_at": null }
Allows the user to add new training data to the training set. It is assumed that the new data is in the '/root/custom_data' directory in the Docker container you're training with.
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/60246/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/60246/timeline
null
null
true
https://api.github.com/repos/tensorflow/tensorflow/issues/60245
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/60245/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/60245/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/60245/events
https://github.com/tensorflow/tensorflow/issues/60245
1,655,783,387
I_kwDOArmXAs5isT_b
60,245
Why training speed per step decrease when number of workers increase in distributed training on CPUs?
{ "login": "lalalapotter", "id": 27332689, "node_id": "MDQ6VXNlcjI3MzMyNjg5", "avatar_url": "https://avatars.githubusercontent.com/u/27332689?v=4", "gravatar_id": "", "url": "https://api.github.com/users/lalalapotter", "html_url": "https://github.com/lalalapotter", "followers_url": "https://api.github.com/users/lalalapotter/followers", "following_url": "https://api.github.com/users/lalalapotter/following{/other_user}", "gists_url": "https://api.github.com/users/lalalapotter/gists{/gist_id}", "starred_url": "https://api.github.com/users/lalalapotter/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/lalalapotter/subscriptions", "organizations_url": "https://api.github.com/users/lalalapotter/orgs", "repos_url": "https://api.github.com/users/lalalapotter/repos", "events_url": "https://api.github.com/users/lalalapotter/events{/privacy}", "received_events_url": "https://api.github.com/users/lalalapotter/received_events", "type": "User", "site_admin": false }
[ { "id": 386191887, "node_id": "MDU6TGFiZWwzODYxOTE4ODc=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/stat:awaiting%20response", "name": "stat:awaiting response", "color": "f4b400", "default": false, "description": "Status - Awaiting response from author" }, { "id": 474725938, "node_id": "MDU6TGFiZWw0NzQ3MjU5Mzg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/stale", "name": "stale", "color": "d4c5f9", "default": false, "description": "This label marks the issue/pr stale - to be closed automatically if no activity" }, { "id": 996845227, "node_id": "MDU6TGFiZWw5OTY4NDUyMjc=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/comp:dist-strat", "name": "comp:dist-strat", "color": "0052cc", "default": false, "description": "Distribution Strategy related issues" }, { "id": 1463677878, "node_id": "MDU6TGFiZWwxNDYzNjc3ODc4", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/type:performance", "name": "type:performance", "color": "159b2e", "default": false, "description": "Performance Issue" }, { "id": 4032183365, "node_id": "LA_kwDOArmXAs7wVjxF", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/TF%202.9", "name": "TF 2.9", "color": "1CF842", "default": false, "description": "Issues found in the TF 2.9 release (or RCs)" } ]
closed
false
{ "login": "SuryanarayanaY", "id": 116063290, "node_id": "U_kgDOBur8Og", "avatar_url": "https://avatars.githubusercontent.com/u/116063290?v=4", "gravatar_id": "", "url": "https://api.github.com/users/SuryanarayanaY", "html_url": "https://github.com/SuryanarayanaY", "followers_url": "https://api.github.com/users/SuryanarayanaY/followers", "following_url": "https://api.github.com/users/SuryanarayanaY/following{/other_user}", "gists_url": "https://api.github.com/users/SuryanarayanaY/gists{/gist_id}", "starred_url": "https://api.github.com/users/SuryanarayanaY/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/SuryanarayanaY/subscriptions", "organizations_url": "https://api.github.com/users/SuryanarayanaY/orgs", "repos_url": "https://api.github.com/users/SuryanarayanaY/repos", "events_url": "https://api.github.com/users/SuryanarayanaY/events{/privacy}", "received_events_url": "https://api.github.com/users/SuryanarayanaY/received_events", "type": "User", "site_admin": false }
[ { "login": "SuryanarayanaY", "id": 116063290, "node_id": "U_kgDOBur8Og", "avatar_url": "https://avatars.githubusercontent.com/u/116063290?v=4", "gravatar_id": "", "url": "https://api.github.com/users/SuryanarayanaY", "html_url": "https://github.com/SuryanarayanaY", "followers_url": "https://api.github.com/users/SuryanarayanaY/followers", "following_url": "https://api.github.com/users/SuryanarayanaY/following{/other_user}", "gists_url": "https://api.github.com/users/SuryanarayanaY/gists{/gist_id}", "starred_url": "https://api.github.com/users/SuryanarayanaY/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/SuryanarayanaY/subscriptions", "organizations_url": "https://api.github.com/users/SuryanarayanaY/orgs", "repos_url": "https://api.github.com/users/SuryanarayanaY/repos", "events_url": "https://api.github.com/users/SuryanarayanaY/events{/privacy}", "received_events_url": "https://api.github.com/users/SuryanarayanaY/received_events", "type": "User", "site_admin": false } ]
null
[ "Hi, @tiruk007, do you have any comment on this? Or do you need more information?", "When you increase the number of workers in distributed training on CPUs in TensorFlow, the training speed per step may decrease due to something called communication overhead.\r\n\r\nBasically in distributed training, the workers need to communicate frequently with each other to exchange stuff like weights and other info. This communication involves sending data over the network, which can be slow and expensive compared to local computations on a single machine. As you add more workers, the amount of communication increases, leading to higher overhead.\r\n\r\nFurthermore, the communication overhead can become a bottleneck that limits the amount of work each worker can perform per step. This can lead to a situation where the workers spend more time waiting for each other to finish their tasks, rather than actually performing computations. As a result, the training speed per step may decrease as you add more workers.\r\n\r\nTo get rid of this issue, you can try to optimize the communication between workers, for example, by reducing the amount of data that needs to be exchanged or by using more efficient communication protocols. The other way would be to use GPUs or TPUs that basically can compute tasks faster than a typical CPU.", "Hi @pogrushan, thanks a lot for your reply. I wonder if there is any benchmark efficiency performance test results on CPUs for us to refer to?", "Hi @lalalapotter ,\r\n\r\nThanks for reaching us. Yes, with increase in no of workers there is some performance affect due to cross communications. AFAIK I am not aware of any benchmarks especially for CPU. I will update if find any such results.\r\n\r\nSince you mentioned that you are using same physical node can you try [tf.distribute.MirroredStrategy](https://www.tensorflow.org/api_docs/python/tf/distribute/MirroredStrategy) and confirm the outcome. Thanks!\r\n", "Hi @SuryanarayanaY,\r\n\r\nThanks for answering the question : ). Actually I use the [tf.distribute.MultiWorkerMirroredStrategy](https://www.tensorflow.org/api_docs/python/tf/distribute/MultiWorkerMirroredStrategy) same as the [keras example](https://www.tensorflow.org/tutorials/distribute/multi_worker_with_keras) and trained on multiple nodes(2 workers per node). Following is the test results on my cluster, could you please check if the scalability is normal for TensoFlow CPU training. \r\n\r\n|# of worker | time per step(ms)|\r\n-- | --\r\n2 | 62\r\n3 | 76\r\n4 | 87\r\n5 | 94\r\n6 | 98\r\n7 | 110\r\n8 | 116\r\n9 | 121\r\n10 | 124\r\n\r\nBesides, do you know any environment variable or other methods that can improve the scalability(training speed per step)?", "Update:\r\nI found that if I use `MirroredStrategy` rather than `MultiWorkerMirroredStrategy`, the training speed per step do not decrease that much when worker number increases. So what is the difference between `MirroredStrategy` and `MultiWorkerMirroredStrategy`?", "Hi @lalalapotter ,\r\n\r\n`MirroredStrategy` to be used when all the devices are in same physical machines. Whereas `MultiWorkerMirroredStrategy` to be used when we want to use Devices/accelerators that spread across different physical machines/servers. Hence you observed the difference in performance as you are using single physical server.\r\n\r\nIf the issue resolved can we mark it as closed.Please feel free to close the issue if resolved for you. Thanks!", "Hi @SuryanarayanaY,\r\nThanks for your quick reply! Actually I have tried run distributed training on different physical nodes with `MirroredStrategy` and get better performance than `MultiWorkerStrategy`. I wonder if there is any problem to run distributed training on different physical nodes with `MirroredStrategy`? FYI, my test code are as follows:\r\n\r\n```python\r\nimport os\r\nimport json\r\n\r\nimport tensorflow as tf\r\nfrom tensorflow.python.distribute import collective_util\r\n\r\nimport mnist_setup\r\n\r\n\r\nper_worker_batch_size = 64\r\ntf_config = {\r\n 'cluster': {\r\n 'worker': ['node-001:12345', 'node-002:23456']\r\n },\r\n 'task': {'type': 'worker', 'index': 0}\r\n}\r\nos.environ['TF_CONFIG'] = json.dumps(tf_config)\r\ntf_config = json.loads(os.environ['TF_CONFIG'])\r\nnum_workers = len(tf_config['cluster']['worker'])\r\n\r\nstrategy = tf.distribute.MirroredStrategy()\r\n\r\nglobal_batch_size = per_worker_batch_size * num_workers\r\nmulti_worker_dataset = mnist_setup.mnist_dataset(global_batch_size)\r\n\r\nwith strategy.scope():\r\n # Model building/compiling need to be within `strategy.scope()`.\r\n multi_worker_model = mnist_setup.build_and_compile_cnn_model()\r\n\r\nprint(multi_worker_model.summary())\r\nmulti_worker_model.fit(multi_worker_dataset, epochs=30)\r\n\r\n```\r\n", "Hi @lalalapotter ,\r\n\r\nFor training on different nodes there will be some additional communication overload compared to training within same machine. Hence there are two different strategies for both. The way MirroredStrategy designed not suitable for Multiple physical devices. Both the implementations are different and specific to their use case. Thanks!", "Hi @SuryanarayanaY,\r\nThanks for your reply. I wonder if there is any benchmark test result on efficiency for me to compare with? And if there is any method to optimize the efficiency while using MultiWorkerMirroredStrategy and ring all reduce(cannot use NCCL) algorithm.", "@lalalapotter ,\r\n\r\nAFAIK, There is no such benchmarks for comparing. As per our documentation NCCL is the best performant for GPU but wont work for CPUs. \r\n\r\nPlease refer to the argument `communication_options` from `[MultiWorkerMirroredStrategy](https://www.tensorflow.org/api_docs/python/tf/distribute/MultiWorkerMirroredStrategy)` which have options to choose like AUTO,RING, NCCL and refer this doc [link](https://www.tensorflow.org/api_docs/python/tf/distribute/experimental/CommunicationOptions) for more details.\r\n\r\nThanks!", "This issue is stale because it has been open for 7 days with no activity. It will be closed if no further activity occurs. Thank you.", "This issue was closed because it has been inactive for 7 days since being marked as stale. Please reopen if you'd like to work on this further.", "Are you satisfied with the resolution of your issue?\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=Yes&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/60245\">Yes</a>\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=No&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/60245\">No</a>\n" ]
2023-04-05T14:53:02
2023-06-01T02:15:45
2023-06-01T02:15:43
NONE
null
null
null
<details><summary>Click to expand!</summary> ### Issue Type Performance ### Have you reproduced the bug with TF nightly? Yes ### Source binary ### Tensorflow Version 2.9.1 ### Custom Code Yes ### OS Platform and Distribution Linux Ubuntu 16.04 ### Mobile device None ### Python version 3.7 ### Bazel version None ### GCC/Compiler version None ### CUDA/cuDNN version None ### GPU model and memory None ### Current Behaviour? When I follow the tutorial, [Multi-worker training with Keras](https://www.tensorflow.org/tutorials/distribute/multi_worker_with_keras), using CPUs to do training. I found that the speed of each step(given the batch size of each worker is constant) decrease when I increase the number of workers. I know there will be communication cost when the number of workers is increasing, but I run it in the same physical node and the speed drop sharply. I expect that the speed of each step should be similar or just decrease within a small proportion when increasing the workers. Or could you please give an explanation? ### Standalone code to reproduce the issue Just follow the tutorial in colab: [link](https://colab.research.google.com/github/tensorflow/docs/blob/master/site/en/tutorials/distribute/multi_worker_with_keras.ipynb) and increase the number of workers. ### Relevant log output _No response_</details>
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/60245/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/60245/timeline
null
completed
false
https://api.github.com/repos/tensorflow/tensorflow/issues/60244
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/60244/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/60244/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/60244/events
https://github.com/tensorflow/tensorflow/issues/60244
1,655,781,748
I_kwDOArmXAs5isTl0
60,244
Why training speed per step decrease when number of workers increase in distributed training on multiple cpus?
{ "login": "lalalapotter", "id": 27332689, "node_id": "MDQ6VXNlcjI3MzMyNjg5", "avatar_url": "https://avatars.githubusercontent.com/u/27332689?v=4", "gravatar_id": "", "url": "https://api.github.com/users/lalalapotter", "html_url": "https://github.com/lalalapotter", "followers_url": "https://api.github.com/users/lalalapotter/followers", "following_url": "https://api.github.com/users/lalalapotter/following{/other_user}", "gists_url": "https://api.github.com/users/lalalapotter/gists{/gist_id}", "starred_url": "https://api.github.com/users/lalalapotter/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/lalalapotter/subscriptions", "organizations_url": "https://api.github.com/users/lalalapotter/orgs", "repos_url": "https://api.github.com/users/lalalapotter/repos", "events_url": "https://api.github.com/users/lalalapotter/events{/privacy}", "received_events_url": "https://api.github.com/users/lalalapotter/received_events", "type": "User", "site_admin": false }
[ { "id": 1463677878, "node_id": "MDU6TGFiZWwxNDYzNjc3ODc4", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/type:performance", "name": "type:performance", "color": "159b2e", "default": false, "description": "Performance Issue" } ]
closed
false
{ "login": "synandi", "id": 98147397, "node_id": "U_kgDOBdmcRQ", "avatar_url": "https://avatars.githubusercontent.com/u/98147397?v=4", "gravatar_id": "", "url": "https://api.github.com/users/synandi", "html_url": "https://github.com/synandi", "followers_url": "https://api.github.com/users/synandi/followers", "following_url": "https://api.github.com/users/synandi/following{/other_user}", "gists_url": "https://api.github.com/users/synandi/gists{/gist_id}", "starred_url": "https://api.github.com/users/synandi/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/synandi/subscriptions", "organizations_url": "https://api.github.com/users/synandi/orgs", "repos_url": "https://api.github.com/users/synandi/repos", "events_url": "https://api.github.com/users/synandi/events{/privacy}", "received_events_url": "https://api.github.com/users/synandi/received_events", "type": "User", "site_admin": false }
[ { "login": "synandi", "id": 98147397, "node_id": "U_kgDOBdmcRQ", "avatar_url": "https://avatars.githubusercontent.com/u/98147397?v=4", "gravatar_id": "", "url": "https://api.github.com/users/synandi", "html_url": "https://github.com/synandi", "followers_url": "https://api.github.com/users/synandi/followers", "following_url": "https://api.github.com/users/synandi/following{/other_user}", "gists_url": "https://api.github.com/users/synandi/gists{/gist_id}", "starred_url": "https://api.github.com/users/synandi/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/synandi/subscriptions", "organizations_url": "https://api.github.com/users/synandi/orgs", "repos_url": "https://api.github.com/users/synandi/repos", "events_url": "https://api.github.com/users/synandi/events{/privacy}", "received_events_url": "https://api.github.com/users/synandi/received_events", "type": "User", "site_admin": false } ]
null
[ "Are you satisfied with the resolution of your issue?\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=Yes&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/60244\">Yes</a>\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=No&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/60244\">No</a>\n" ]
2023-04-05T14:52:01
2023-04-05T15:18:16
2023-04-05T15:18:13
NONE
null
null
null
<details><summary>Click to expand!</summary> ### Issue Type Performance ### Have you reproduced the bug with TF nightly? Yes ### Source binary ### Tensorflow Version 2.9.1 ### Custom Code Yes ### OS Platform and Distribution Linux Ubuntu 16.04 ### Mobile device None ### Python version 3.7 ### Bazel version None ### GCC/Compiler version None ### CUDA/cuDNN version None ### GPU model and memory None ### Current Behaviour? ```shell When I follow the tutorial, [Distrited training with Keras](https://www.tensorflow.org/tutorials/distribute/keras), using CPU to do training. I found that the speed of each step(given the batch size of each worker is constant) decrease when I increase the number of workers. I know there will be communication cost when the number of workers is increasing, but I run it in the same physical node and the speed drop sharply. I expect that the speed of each step should be similar or just decrease within a small proportion when increasing the workers. ``` ### Standalone code to reproduce the issue ```shell Just follow the tutorial in colab: https://colab.research.google.com/github/tensorflow/docs/blob/master/site/en/tutorials/distribute/keras.ipynb and increase the number of workers. ``` ### Relevant log output _No response_</details>
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/60244/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/60244/timeline
null
completed
false
https://api.github.com/repos/tensorflow/tensorflow/issues/60243
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/60243/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/60243/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/60243/events
https://github.com/tensorflow/tensorflow/issues/60243
1,655,641,930
I_kwDOArmXAs5irxdK
60,243
Cannot Install tensorflow-gpu on python=3.10.11
{ "login": "shvamabps", "id": 37547983, "node_id": "MDQ6VXNlcjM3NTQ3OTgz", "avatar_url": "https://avatars.githubusercontent.com/u/37547983?v=4", "gravatar_id": "", "url": "https://api.github.com/users/shvamabps", "html_url": "https://github.com/shvamabps", "followers_url": "https://api.github.com/users/shvamabps/followers", "following_url": "https://api.github.com/users/shvamabps/following{/other_user}", "gists_url": "https://api.github.com/users/shvamabps/gists{/gist_id}", "starred_url": "https://api.github.com/users/shvamabps/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/shvamabps/subscriptions", "organizations_url": "https://api.github.com/users/shvamabps/orgs", "repos_url": "https://api.github.com/users/shvamabps/repos", "events_url": "https://api.github.com/users/shvamabps/events{/privacy}", "received_events_url": "https://api.github.com/users/shvamabps/received_events", "type": "User", "site_admin": false }
[ { "id": 386191887, "node_id": "MDU6TGFiZWwzODYxOTE4ODc=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/stat:awaiting%20response", "name": "stat:awaiting response", "color": "f4b400", "default": false, "description": "Status - Awaiting response from author" }, { "id": 473173351, "node_id": "MDU6TGFiZWw0NzMxNzMzNTE=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/type:build/install", "name": "type:build/install", "color": "159b2e", "default": false, "description": "Build and install issues" }, { "id": 1188421838, "node_id": "MDU6TGFiZWwxMTg4NDIxODM4", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/subtype:windows", "name": "subtype:windows", "color": "b619ea", "default": false, "description": "Windows Build/Installation Issues" }, { "id": 5206407904, "node_id": "LA_kwDOArmXAs8AAAABNlN64A", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/TF%202.12", "name": "TF 2.12", "color": "c5def5", "default": false, "description": "For issues related to Tensorflow 2.12" } ]
closed
false
{ "login": "SuryanarayanaY", "id": 116063290, "node_id": "U_kgDOBur8Og", "avatar_url": "https://avatars.githubusercontent.com/u/116063290?v=4", "gravatar_id": "", "url": "https://api.github.com/users/SuryanarayanaY", "html_url": "https://github.com/SuryanarayanaY", "followers_url": "https://api.github.com/users/SuryanarayanaY/followers", "following_url": "https://api.github.com/users/SuryanarayanaY/following{/other_user}", "gists_url": "https://api.github.com/users/SuryanarayanaY/gists{/gist_id}", "starred_url": "https://api.github.com/users/SuryanarayanaY/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/SuryanarayanaY/subscriptions", "organizations_url": "https://api.github.com/users/SuryanarayanaY/orgs", "repos_url": "https://api.github.com/users/SuryanarayanaY/repos", "events_url": "https://api.github.com/users/SuryanarayanaY/events{/privacy}", "received_events_url": "https://api.github.com/users/SuryanarayanaY/received_events", "type": "User", "site_admin": false }
[ { "login": "SuryanarayanaY", "id": 116063290, "node_id": "U_kgDOBur8Og", "avatar_url": "https://avatars.githubusercontent.com/u/116063290?v=4", "gravatar_id": "", "url": "https://api.github.com/users/SuryanarayanaY", "html_url": "https://github.com/SuryanarayanaY", "followers_url": "https://api.github.com/users/SuryanarayanaY/followers", "following_url": "https://api.github.com/users/SuryanarayanaY/following{/other_user}", "gists_url": "https://api.github.com/users/SuryanarayanaY/gists{/gist_id}", "starred_url": "https://api.github.com/users/SuryanarayanaY/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/SuryanarayanaY/subscriptions", "organizations_url": "https://api.github.com/users/SuryanarayanaY/orgs", "repos_url": "https://api.github.com/users/SuryanarayanaY/repos", "events_url": "https://api.github.com/users/SuryanarayanaY/events{/privacy}", "received_events_url": "https://api.github.com/users/SuryanarayanaY/received_events", "type": "User", "site_admin": false } ]
null
[ "Same condition happened with python 3.9.12.\r\nI am using virtualenv to install tensorflow-gpu.\r\n`pip install virtualenv`\r\n`virtualenv venv`\r\n`./venv/Scripts/activate.bat`\r\n`pip install tensorflow-gpu`\r\n", "TensorFlow GPU is currently not available for Python 3.10.11\r\nDowngrade your Python version to one of the supported versions \r\nJust uninstall current python and reinstall python version like 3.9 or below to use gpu.\r\n", "@KrishnaSChavan I installed 3.9.12 version, still it wasn't working.\r\nAccording to you, which python version is supported for tf-gpu.", "Please use `tensorflow` instead of `tensorflow-gpu`. See first bullet in TF 2.12 release notes: https://github.com/tensorflow/tensorflow/releases/tag/v2.12.0", "@shvamabps Please refer to the comment above and let us know if that helps?\r\nThank you!", "![image](https://user-images.githubusercontent.com/37547983/230294789-2736964d-7bce-42ce-909a-3b8371813765.png)\r\nActually, I am using conda, the above image shows more details regarding tf.\r\nI have got GPU (Nvidia GeForce RTX 3050) but it is not recognizing it. \r\nI even have tried installing the cuda and cuDNN pacakges in conda. \r\n@mihaimaruseac @sushreebarsa ", "@shvamabps For the users of TF v2.11 or above are recommended to use Windows WSL for GPU Access. Could you please see the instructions here - https://www.tensorflow.org/install/pip#windows-wsl2\r\nIf you are using Conda, you can create a Conda environment and install inside the conda env.\r\nYou could also give docker containers a try if you prefer that over creating your own conda env (https://www.tensorflow.org/install/docker)\r\nThank you!", "I have tried all of that. Torch recognizes the GPU but tf doesn't", "Hi @shvamabps ,\r\n\r\nPlease cross check the detailed instructions mentioned in documentation for [windows-native](https://www.tensorflow.org/install/pip#step-by-step_instructions) and for [wsl2](https://www.tensorflow.org/install/pip#step-by-step_instructions) for enabling GPU setup. By default Tensorflow will not detect GPU unless you install GPU driver and then CUDA/cuDNN toolkit and setting the path and all these steps are manual.\r\n\r\nAfter ensuring installation of GPU driver ensure it is up and running with `nvidia-smi` command. Installation instructions of GPU driver is not explicitly mentioned in Tensorflow documentation. You can check with nvidia website for same. If you have already installed GPU driver please share the output of `nvidia-smi` .\r\n\r\nPlease use `pip install tensorflow` only instead of `tensorflow-gpu`. Please make a note again that TF <=2.10 version you can have GPU support on native windows however for TF>=2.11 you should install wsl2 on windows to use GPU support.\r\n\r\nThanks!\r\n\r\n", "Why do I have to install in WSL2. Can't the only windows not be used for that purpose?? What issues are there in that case if I use TF without WSL2. ", "Please see https://github.com/tensorflow/tensorflow/issues/59918#issuecomment-1513386150 Due to the fact that there are so few developers with Windows expertise in TF OSS team and so few users of TF GPU on Windows it was decided more than a year ago to drop native GPU support on Windows and instead use the Linux support provided by WSL2. There is also the alternative of using a Linux environment, cloud, Google Collab, etc.", "Hi @shvamabps ,\r\n\r\nPlease have a look of above [comment](https://github.com/tensorflow/tensorflow/issues/60243#issuecomment-1513563671). WSL2 is needed on windows to enable GPU to be utilized by TF(>=2.11 version) and the purpose is ease of maintenance of builds by our team and also GPU performance on native windows might not be as good as compared to Linux (WSL2) environment . More context can be seen in attached issue in above comment.", "Thanks for the clarifications. \r\nIt was a lot helpful.", "Hi @shvamabps ,\r\n\r\nGlad that we are of some help. Could you please spare some time to close the issue if resolved. Thanks", "Are you satisfied with the resolution of your issue?\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=Yes&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/60243\">Yes</a>\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=No&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/60243\">No</a>\n", "I'm experiencing the exact same error under ubuntu 22.04 with CUDA 12.1 and both Python 3.9.16 and Python 3.10. And as per other commenters, installing just `tf-nightly` installs ok but prevents my setup from using my RTX 4090 GPU at all which is… not ideal :)\r\n\r\nThe same setup has Pytorch running fine so it's not an issue with CUDA or anything else. \r\n\r\n\r\n```\r\npip install tf-nightly-gpu\r\nCollecting tf-nightly-gpu\r\n Downloading tf-nightly-gpu-2.12.0.tar.gz (2.6 kB)\r\n Preparing metadata (setup.py) ... error\r\n error: subprocess-exited-with-error\r\n\r\n × python setup.py egg_info did not run successfully.\r\n │ exit code: 1\r\n ╰─> [41 lines of output]\r\n Traceback (most recent call last):\r\n File \"/home/…/python3.10/site-packages/setuptools/_vendor/packaging/requirements.py\", line 35, in __init__\r\n parsed = parse_requirement(requirement_string)\r\n File \"/home/…/python3.10/site-packages/setuptools/_vendor/packaging/_parser.py\", line 64, in parse_requirement\r\n return _parse_requirement(Tokenizer(source, rules=DEFAULT_RULES))\r\n File \"/home/…/python3.10/site-packages/setuptools/_vendor/packaging/_parser.py\", line 82, in _parse_requirement\r\n url, specifier, marker = _parse_requirement_details(tokenizer)\r\n File \"/home/…/python3.10/site-packages/setuptools/_vendor/packaging/_parser.py\", line 126, in _parse_requirement_details\r\n marker = _parse_requirement_marker(\r\n File \"/home/…python3.10/site-packages/setuptools/_vendor/packaging/_parser.py\", line 147, in _parse_requirement_marker\r\n tokenizer.raise_syntax_error(\r\n File \"/home/…python3.10/site-packages/setuptools/_vendor/packaging/_tokenizer.py\", line 163, in raise_syntax_error\r\n raise ParserSyntaxError(\r\n setuptools.extern.packaging._tokenizer.ParserSyntaxError: Expected end or semicolon (after name and no valid version specifier)\r\n python_version>\"3.7\"\r\n ^\r\n\r\n The above exception was the direct cause of the following exception:\r\n\r\n Traceback (most recent call last):\r\n File \"<string>\", line 2, in <module>\r\n File \"<pip-setuptools-caller>\", line 34, in <module>\r\n File \"/tmp/pip-install-rweboy03/tf-nightly-gpu_e9119949fe52419d9624f697273ca4ab/setup.py\", line 40, in <module>\r\n setuptools.setup()\r\n File \"/home/…/python3.10/site-packages/setuptools/__init__.py\", line 106, in setup\r\n _install_setup_requires(attrs)\r\n File \"/home/…/python3.10/site-packages/setuptools/__init__.py\", line 77, in _install_setup_requires\r\n dist.parse_config_files(ignore_option_errors=True)\r\n File \"/home/…python3.10/site-packages/_virtualenv.py\", line 22, in parse_config_files\r\n result = old_parse_config_files(self, *args, **kwargs)\r\n File \"/home/…python3.10/site-packages/setuptools/dist.py\", line 910, in parse_config_files\r\n self._finalize_requires()\r\n File \"/home/…/python3.10/site-packages/setuptools/dist.py\", line 607, in _finalize_requires\r\n self._move_install_requirements_markers()\r\n File \"/home/…/python3.10/site-packages/setuptools/dist.py\", line 647, in _move_install_requirements_markers\r\n inst_reqs = list(_reqs.parse(spec_inst_reqs))\r\n File \"/home/…/python3.10/site-packages/setuptools/_vendor/packaging/requirements.py\", line 37, in __init__\r\n raise InvalidRequirement(str(e)) from e\r\n setuptools.extern.packaging.requirements.InvalidRequirement: Expected end or semicolon (after name and no valid version specifier)\r\n python_version>\"3.7\"\r\n ^\r\n [end of output]\r\n\r\n note: This error originates from a subprocess, and is likely not a problem with pip.\r\nerror: metadata-generation-failed\r\n```", "I had the same problem with python 3.11 on OS X. I don't think I have a GPU. I commented out the `tensorflow-gpu` lines in `requirements.txt`, and everything installed.\r\n\r\nNow maybe nothing will work well without a GPU, we'll see.", "same problem with `python==3.10.6` and `tensorflow==2.12.0` on ubuntu 20.04.\r\nI have checked colab python and tensorflow version: `python==3.10.12` , `tensorflow=2.12.0`\r\nAny help is appreciated.", "why is this closed? the problem is still on", "Because tensorflow-gpu has been deprecated.\r\n\r\nOn Tue, 11 Jul 2023 at 11:04, Ionelia ***@***.***> wrote:\r\n\r\n> why is this closed? the problem is still on\r\n>\r\n> —\r\n> Reply to this email directly, view it on GitHub\r\n> <https://github.com/tensorflow/tensorflow/issues/60243#issuecomment-1630538522>,\r\n> or unsubscribe\r\n> <https://github.com/notifications/unsubscribe-auth/AABD62N4YKF5TVWJ7GESCCDXPUQLXANCNFSM6AAAAAAWUC66UE>\r\n> .\r\n> You are receiving this because you commented.Message ID:\r\n> ***@***.***>\r\n>\r\n", "ah ok. \r\n\r\nit seems like there is no release of tensorflow for cuda 12 yet. i got the same error on python37 and above. ", "answering the question, tensorflow-gpu will not work sometimes, you will have to know what you are doing, first check the compatibility of:\r\n\r\n TensorFlow + Python + Nvidia \"stuff\" (drivers, CUDA toolkit, cuDNN)\r\n\r\nIf any of these are incompatible with each other for what you are doing then you need to check what you have and install the proper versions for each.\r\n\r\nI am telling you this by assuming that your WSL2 is working properly and you understand how it works, if not then watch some videos that some folks explain how it works for you to understand.\r\n\r\nif you can do what you want on Linux then use Ubuntu from the start.\r\n\r\nFYI: [https://www.tensorflow.org/install/source_windows](url)\r\n\r\n> Note: GPU support on native-Windows is only available for 2.10 or earlier versions, starting in TF 2.11, CUDA build is not supported for Windows. For using TensorFlow GPU on Windows, you will need to build/install TensorFlow in WSL2 or use tensorflow-cpu with TensorFlow-DirectML-Plugin\r\n\r\n\r\nAdvice: \r\n\r\n-I strongly recommend using Ubuntu, WSL2 is good but Ubuntu is simply the best for the resources it consumes when compared to Windows + WSL2.\r\n-Start asking yourself which version of Tensorflow you need then install all dependencies for GPU support." ]
2023-04-05T13:39:31
2023-12-10T15:11:39
2023-04-27T05:10:55
NONE
null
null
null
<details><summary>Click to expand!</summary> ### Issue Type Build/Install ### Have you reproduced the bug with TF nightly? No ### Source source ### Tensorflow Version 2.12.0 ### Custom Code No ### OS Platform and Distribution Windows 11 ### Mobile device _No response_ ### Python version 3.10.11 ### Bazel version _No response_ ### GCC/Compiler version _No response_ ### CUDA/cuDNN version _No response_ ### GPU model and memory _No response_ ### Current Behaviour? ```shell A bug happened! ``` ### Standalone code to reproduce the issue ```shell pip install tensorflow-gpu ``` ### Relevant log output ```shell Collecting tensorflow-gpu Downloading tensorflow-gpu-2.12.0.tar.gz (2.6 kB) Preparing metadata (setup.py) ... error error: subprocess-exited-with-error × python setup.py egg_info did not run successfully. │ exit code: 1 ╰─> [41 lines of output] Traceback (most recent call last): File "C:\Users\shiva\OneDrive\Desktop\LipNet\venv\lib\site-packages\setuptools\_vendor\packaging\requirements.py", line 35, in __init__ parsed = parse_requirement(requirement_string) File "C:\Users\shiva\OneDrive\Desktop\LipNet\venv\lib\site-packages\setuptools\_vendor\packaging\_parser.py", line 64, in parse_requirement return _parse_requirement(Tokenizer(source, rules=DEFAULT_RULES)) File "C:\Users\shiva\OneDrive\Desktop\LipNet\venv\lib\site-packages\setuptools\_vendor\packaging\_parser.py", line 82, in _parse_requirement url, specifier, marker = _parse_requirement_details(tokenizer) File "C:\Users\shiva\OneDrive\Desktop\LipNet\venv\lib\site-packages\setuptools\_vendor\packaging\_parser.py", line 126, in _parse_requirement_details marker = _parse_requirement_marker( File "C:\Users\shiva\OneDrive\Desktop\LipNet\venv\lib\site-packages\setuptools\_vendor\packaging\_parser.py", line 147, in _parse_requirement_marker tokenizer.raise_syntax_error( File "C:\Users\shiva\OneDrive\Desktop\LipNet\venv\lib\site-packages\setuptools\_vendor\packaging\_tokenizer.py", line 163, in raise_syntax_error raise ParserSyntaxError( setuptools.extern.packaging._tokenizer.ParserSyntaxError: Expected end or semicolon (after name and no valid version specifier) python_version>"3.7" note: This error originates from a subprocess, and is likely not a problem with pip. error: metadata-generation-failed × Encountered error while generating package metadata. ╰─> See above for output. note: This is an issue with the package mentioned above, not pip. hint: See above for details. ``` </details>
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/60243/reactions", "total_count": 13, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 13 }
https://api.github.com/repos/tensorflow/tensorflow/issues/60243/timeline
null
completed
false
https://api.github.com/repos/tensorflow/tensorflow/issues/60242
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/60242/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/60242/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/60242/events
https://github.com/tensorflow/tensorflow/pull/60242
1,655,639,293
PR_kwDOArmXAs5NrYGY
60,242
Fix null pointer dereference in xla::cpu::CustomCallOpLowering::rewriteTypedCustomCall()
{ "login": "SweetVishnya", "id": 22149206, "node_id": "MDQ6VXNlcjIyMTQ5MjA2", "avatar_url": "https://avatars.githubusercontent.com/u/22149206?v=4", "gravatar_id": "", "url": "https://api.github.com/users/SweetVishnya", "html_url": "https://github.com/SweetVishnya", "followers_url": "https://api.github.com/users/SweetVishnya/followers", "following_url": "https://api.github.com/users/SweetVishnya/following{/other_user}", "gists_url": "https://api.github.com/users/SweetVishnya/gists{/gist_id}", "starred_url": "https://api.github.com/users/SweetVishnya/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/SweetVishnya/subscriptions", "organizations_url": "https://api.github.com/users/SweetVishnya/orgs", "repos_url": "https://api.github.com/users/SweetVishnya/repos", "events_url": "https://api.github.com/users/SweetVishnya/events{/privacy}", "received_events_url": "https://api.github.com/users/SweetVishnya/received_events", "type": "User", "site_admin": false }
[ { "id": 390482148, "node_id": "MDU6TGFiZWwzOTA0ODIxNDg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/awaiting%20review", "name": "awaiting review", "color": "bc3869", "default": false, "description": "Pull request awaiting review" }, { "id": 987666414, "node_id": "MDU6TGFiZWw5ODc2NjY0MTQ=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/ready%20to%20pull", "name": "ready to pull", "color": "2cd643", "default": false, "description": "PR ready for merge process" }, { "id": 1133285679, "node_id": "MDU6TGFiZWwxMTMzMjg1Njc5", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/comp:xla", "name": "comp:xla", "color": "0052cc", "default": false, "description": "XLA" }, { "id": 1169364259, "node_id": "MDU6TGFiZWwxMTY5MzY0MjU5", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/size:XS", "name": "size:XS", "color": "adafea", "default": false, "description": "CL Change Size: Extra Small" } ]
closed
false
{ "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false }
[ { "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false } ]
null
[ "Leaving to XLA team to review", "@ezhulenev, can you take a look?", "@frgossen, can you review this fix, please?" ]
2023-04-05T13:37:55
2023-04-27T17:54:24
2023-04-27T17:54:23
CONTRIBUTOR
null
false
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/pulls/60242", "html_url": "https://github.com/tensorflow/tensorflow/pull/60242", "diff_url": "https://github.com/tensorflow/tensorflow/pull/60242.diff", "patch_url": "https://github.com/tensorflow/tensorflow/pull/60242.patch", "merged_at": "2023-04-27T17:54:23" }
The bug was found by Svace static analyzer: 1. op.getBackendConfig() can be null 2. dict will be nullptr 3. dict.begin() dereferences a null pointer Closes #60223 cc @mihaimaruseac
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/60242/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/60242/timeline
null
null
true
https://api.github.com/repos/tensorflow/tensorflow/issues/60241
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/60241/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/60241/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/60241/events
https://github.com/tensorflow/tensorflow/issues/60241
1,655,452,430
I_kwDOArmXAs5irDMO
60,241
Tensorflow-gpu version 2.12.0 is not available
{ "login": "KnSun99", "id": 123467428, "node_id": "U_kgDOB1v2pA", "avatar_url": "https://avatars.githubusercontent.com/u/123467428?v=4", "gravatar_id": "", "url": "https://api.github.com/users/KnSun99", "html_url": "https://github.com/KnSun99", "followers_url": "https://api.github.com/users/KnSun99/followers", "following_url": "https://api.github.com/users/KnSun99/following{/other_user}", "gists_url": "https://api.github.com/users/KnSun99/gists{/gist_id}", "starred_url": "https://api.github.com/users/KnSun99/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/KnSun99/subscriptions", "organizations_url": "https://api.github.com/users/KnSun99/orgs", "repos_url": "https://api.github.com/users/KnSun99/repos", "events_url": "https://api.github.com/users/KnSun99/events{/privacy}", "received_events_url": "https://api.github.com/users/KnSun99/received_events", "type": "User", "site_admin": false }
[ { "id": 386191887, "node_id": "MDU6TGFiZWwzODYxOTE4ODc=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/stat:awaiting%20response", "name": "stat:awaiting response", "color": "f4b400", "default": false, "description": "Status - Awaiting response from author" }, { "id": 473173351, "node_id": "MDU6TGFiZWw0NzMxNzMzNTE=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/type:build/install", "name": "type:build/install", "color": "159b2e", "default": false, "description": "Build and install issues" }, { "id": 474725938, "node_id": "MDU6TGFiZWw0NzQ3MjU5Mzg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/stale", "name": "stale", "color": "d4c5f9", "default": false, "description": "This label marks the issue/pr stale - to be closed automatically if no activity" }, { "id": 1188421838, "node_id": "MDU6TGFiZWwxMTg4NDIxODM4", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/subtype:windows", "name": "subtype:windows", "color": "b619ea", "default": false, "description": "Windows Build/Installation Issues" }, { "id": 5206407904, "node_id": "LA_kwDOArmXAs8AAAABNlN64A", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/TF%202.12", "name": "TF 2.12", "color": "c5def5", "default": false, "description": "For issues related to Tensorflow 2.12" } ]
closed
false
{ "login": "sachinprasadhs", "id": 73069040, "node_id": "MDQ6VXNlcjczMDY5MDQw", "avatar_url": "https://avatars.githubusercontent.com/u/73069040?v=4", "gravatar_id": "", "url": "https://api.github.com/users/sachinprasadhs", "html_url": "https://github.com/sachinprasadhs", "followers_url": "https://api.github.com/users/sachinprasadhs/followers", "following_url": "https://api.github.com/users/sachinprasadhs/following{/other_user}", "gists_url": "https://api.github.com/users/sachinprasadhs/gists{/gist_id}", "starred_url": "https://api.github.com/users/sachinprasadhs/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sachinprasadhs/subscriptions", "organizations_url": "https://api.github.com/users/sachinprasadhs/orgs", "repos_url": "https://api.github.com/users/sachinprasadhs/repos", "events_url": "https://api.github.com/users/sachinprasadhs/events{/privacy}", "received_events_url": "https://api.github.com/users/sachinprasadhs/received_events", "type": "User", "site_admin": false }
[ { "login": "sachinprasadhs", "id": 73069040, "node_id": "MDQ6VXNlcjczMDY5MDQw", "avatar_url": "https://avatars.githubusercontent.com/u/73069040?v=4", "gravatar_id": "", "url": "https://api.github.com/users/sachinprasadhs", "html_url": "https://github.com/sachinprasadhs", "followers_url": "https://api.github.com/users/sachinprasadhs/followers", "following_url": "https://api.github.com/users/sachinprasadhs/following{/other_user}", "gists_url": "https://api.github.com/users/sachinprasadhs/gists{/gist_id}", "starred_url": "https://api.github.com/users/sachinprasadhs/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sachinprasadhs/subscriptions", "organizations_url": "https://api.github.com/users/sachinprasadhs/orgs", "repos_url": "https://api.github.com/users/sachinprasadhs/repos", "events_url": "https://api.github.com/users/sachinprasadhs/events{/privacy}", "received_events_url": "https://api.github.com/users/sachinprasadhs/received_events", "type": "User", "site_admin": false } ]
null
[ "tensorflow doesn't support native gpu on windows since 2.11", "@Sun-kangning,\r\nTensorFlow 2.10 was the last TensorFlow release that supported GPU on native-Windows. Starting with TensorFlow 2.11, you will need to install [TensorFlow in WSL2](https://tensorflow.org/install/pip#windows-wsl2), or install tensorflow-cpu and, optionally, try the [TensorFlow-DirectML-Plugin](https://github.com/microsoft/tensorflow-directml-plugin#tensorflow-directml-plugin-)\r\n\r\nKindly find the official doc link for the reference.\r\nhttps://www.tensorflow.org/install/pip\r\n\r\nThank you!", "I will try Linux system, thanks for your reply!", "The `tensorflow` and `tensorflow-gpu` packages are the same since TF 2.1.0. To conserve space on PyPI, the redundant package has been removed. Please consult the release notes, it is the first item mentioned there: https://github.com/tensorflow/tensorflow/releases/tag/v2.12.0\r\n\r\n\r\n@tilakrayal and @123mbcz123 have provided incorrect answers for this issue", "Ok, thank you very much for your reply!", "Tensorflow2.12.0 using GPU. What versions of cuda and cudnn are required?\r\nWindows11, Python3.10.10. I'm using cuda12.1.0 and cudnn8.8.1.3 and can't drive the GPU.", "Same issue. Tf 2.12, Python 3.10, Windows 11, cuda12.1, cudnn 8.9.0 with Nvidia RTX 3060 for laptops. DeviceQuery result was PASS. Tensorflow output is just my CPU with no GPU detected. Been years and I've never seen one CUDA install smooth at first try.", "Are you using WSL? #59918", "Win11,Not WSL\r\n\r\nhttps://pypi.org/project/tensorflow-gpu/#description\r\n\r\n", "See note at top of 2.11.1 (which applies to 2.11.0 and 2.12.0 too): https://github.com/tensorflow/tensorflow/releases/tag/v2.11.1", "Please follow the tested build configurations published [here](https://www.tensorflow.org/install/source_windows#cpu) for windows CPU and GPU, as mentioned in above comments, 2.10 was the last last Tensorflow version which supported GPU on native windows.\r\n\r\nIf you are trying with the `Windows-WSl2` installation https://www.tensorflow.org/install/pip#windows-wsl2 then you can try with the `cuDNN 8.6`, `CUDA 11.8` and `python version 3.8-3.11`", "This issue is stale because it has been open for 7 days with no activity. It will be closed if no further activity occurs. Thank you.", "This issue was closed because it has been inactive for 7 days since being marked as stale. Please reopen if you'd like to work on this further.", "Are you satisfied with the resolution of your issue?\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=Yes&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/60241\">Yes</a>\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=No&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/60241\">No</a>\n", "I have Nvidia GeForce 720m can I use it for training with tensorflow 2.12.0\n", "Which version of cuda and cudnn are you using?" ]
2023-04-05T11:35:30
2023-05-15T02:26:26
2023-05-06T01:50:04
NONE
null
null
null
<details><summary>Click to expand!</summary> ### Issue Type Build/Install ### Have you reproduced the bug with TF nightly? No ### Source source ### Tensorflow Version tf2.12.0 ### Custom Code No ### OS Platform and Distribution Win11 ### Mobile device _No response_ ### Python version 3.10.10 ### Bazel version _No response_ ### GCC/Compiler version _No response_ ### CUDA/cuDNN version _No response_ ### GPU model and memory _No response_ ### Current Behaviour? ```shell No version 2.12.0 of the tensorflow-gpu was found. ``` ### Standalone code to reproduce the issue ```shell Not have ``` ### Relevant log output _No response_</details>
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/60241/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/60241/timeline
null
completed
false
https://api.github.com/repos/tensorflow/tensorflow/issues/60240
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/60240/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/60240/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/60240/events
https://github.com/tensorflow/tensorflow/pull/60240
1,655,424,225
PR_kwDOArmXAs5Nqpka
60,240
Fix cwise_ops_test import issue
{ "login": "i-chaochen", "id": 913790, "node_id": "MDQ6VXNlcjkxMzc5MA==", "avatar_url": "https://avatars.githubusercontent.com/u/913790?v=4", "gravatar_id": "", "url": "https://api.github.com/users/i-chaochen", "html_url": "https://github.com/i-chaochen", "followers_url": "https://api.github.com/users/i-chaochen/followers", "following_url": "https://api.github.com/users/i-chaochen/following{/other_user}", "gists_url": "https://api.github.com/users/i-chaochen/gists{/gist_id}", "starred_url": "https://api.github.com/users/i-chaochen/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/i-chaochen/subscriptions", "organizations_url": "https://api.github.com/users/i-chaochen/orgs", "repos_url": "https://api.github.com/users/i-chaochen/repos", "events_url": "https://api.github.com/users/i-chaochen/events{/privacy}", "received_events_url": "https://api.github.com/users/i-chaochen/received_events", "type": "User", "site_admin": false }
[ { "id": 390482148, "node_id": "MDU6TGFiZWwzOTA0ODIxNDg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/awaiting%20review", "name": "awaiting review", "color": "bc3869", "default": false, "description": "Pull request awaiting review" }, { "id": 987666414, "node_id": "MDU6TGFiZWw5ODc2NjY0MTQ=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/ready%20to%20pull", "name": "ready to pull", "color": "2cd643", "default": false, "description": "PR ready for merge process" }, { "id": 1169364259, "node_id": "MDU6TGFiZWwxMTY5MzY0MjU5", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/size:XS", "name": "size:XS", "color": "adafea", "default": false, "description": "CL Change Size: Extra Small" } ]
closed
false
{ "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false }
[ { "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false } ]
null
[]
2023-04-05T11:15:51
2023-04-21T18:15:38
2023-04-21T18:15:38
CONTRIBUTOR
null
false
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/pulls/60240", "html_url": "https://github.com/tensorflow/tensorflow/pull/60240", "diff_url": "https://github.com/tensorflow/tensorflow/pull/60240.diff", "patch_url": "https://github.com/tensorflow/tensorflow/pull/60240.patch", "merged_at": "2023-04-21T18:15:37" }
We found this recent failed unit test is because gradient_checker_v2 is not included in the BUILD file and this can fix it. ``` FAIL: //tensorflow/python/kernel_tests/math_ops:cwise_ops_test_gpu (see /root/.cache/bazel/_bazel_root/8f7dd4c2e00ecc9d40debccd14018321/execroot/org_tensorflow/bazel-out/k8-opt/testlogs/tensorflow/python/kernel_tests/math_ops/cwise_ops_test_gpu/test.log) INFO: From Testing //tensorflow/python/kernel_tests/math_ops:cwise_ops_test_gpu: ==================== Test output for //tensorflow/python/kernel_tests/math_ops:cwise_ops_test_gpu: 2023-04-05 10:27:17.163180: I tensorflow/core/platform/cpu_feature_guard.cc:182] This TensorFlow binary is optimized to use available CPU instructions in performance-critical operations. To enable the following instructions: SSE3 SSE4.1 SSE4.2 AVX AVX2 FMA, in other operations, rebuild TensorFlow with the appropriate compiler flags. Traceback (most recent call last): File "/root/.cache/bazel/_bazel_root/8f7dd4c2e00ecc9d40debccd14018321/execroot/org_tensorflow/bazel-out/k8-opt/bin/tensorflow/python/kernel_tests/math_ops/cwise_ops_test_gpu.runfiles/org_tensorflow/tensorflow/python/kernel_tests/math_ops/cwise_ops_test.py", line 33, in <module> from tensorflow.python.ops import gradient_checker_v2 ImportError: cannot import name 'gradient_checker_v2' from 'tensorflow.python.ops' (/root/.cache/bazel/_bazel_root/8f7dd4c2e00ecc9d40debccd14018321/execroot/org_tensorflow/bazel-out/k8-opt/bin/tensorflow/python/kernel_tests/math_ops/cwise_ops_test_gpu.runfiles/org_tensorflow/tensorflow/python/ops/__init__.py) ================================================================================```
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/60240/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/60240/timeline
null
null
true
https://api.github.com/repos/tensorflow/tensorflow/issues/60239
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/60239/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/60239/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/60239/events
https://github.com/tensorflow/tensorflow/issues/60239
1,655,353,620
I_kwDOArmXAs5iqrEU
60,239
In tf.data.experimental.enable_debug_mode, tf.data.Dataset.ragged_batch fails with an error
{ "login": "foxik", "id": 560016, "node_id": "MDQ6VXNlcjU2MDAxNg==", "avatar_url": "https://avatars.githubusercontent.com/u/560016?v=4", "gravatar_id": "", "url": "https://api.github.com/users/foxik", "html_url": "https://github.com/foxik", "followers_url": "https://api.github.com/users/foxik/followers", "following_url": "https://api.github.com/users/foxik/following{/other_user}", "gists_url": "https://api.github.com/users/foxik/gists{/gist_id}", "starred_url": "https://api.github.com/users/foxik/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/foxik/subscriptions", "organizations_url": "https://api.github.com/users/foxik/orgs", "repos_url": "https://api.github.com/users/foxik/repos", "events_url": "https://api.github.com/users/foxik/events{/privacy}", "received_events_url": "https://api.github.com/users/foxik/received_events", "type": "User", "site_admin": false }
[ { "id": 404586594, "node_id": "MDU6TGFiZWw0MDQ1ODY1OTQ=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/stat:awaiting%20tensorflower", "name": "stat:awaiting tensorflower", "color": "f4b400", "default": false, "description": "Status - Awaiting response from tensorflower" }, { "id": 473172988, "node_id": "MDU6TGFiZWw0NzMxNzI5ODg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/type:bug", "name": "type:bug", "color": "159b2e", "default": false, "description": "Bug" }, { "id": 1114343535, "node_id": "MDU6TGFiZWwxMTE0MzQzNTM1", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/comp:data", "name": "comp:data", "color": "0052cc", "default": false, "description": "tf.data related issues" }, { "id": 5206407904, "node_id": "LA_kwDOArmXAs8AAAABNlN64A", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/TF%202.12", "name": "TF 2.12", "color": "c5def5", "default": false, "description": "For issues related to Tensorflow 2.12" } ]
open
false
{ "login": "sachinprasadhs", "id": 73069040, "node_id": "MDQ6VXNlcjczMDY5MDQw", "avatar_url": "https://avatars.githubusercontent.com/u/73069040?v=4", "gravatar_id": "", "url": "https://api.github.com/users/sachinprasadhs", "html_url": "https://github.com/sachinprasadhs", "followers_url": "https://api.github.com/users/sachinprasadhs/followers", "following_url": "https://api.github.com/users/sachinprasadhs/following{/other_user}", "gists_url": "https://api.github.com/users/sachinprasadhs/gists{/gist_id}", "starred_url": "https://api.github.com/users/sachinprasadhs/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sachinprasadhs/subscriptions", "organizations_url": "https://api.github.com/users/sachinprasadhs/orgs", "repos_url": "https://api.github.com/users/sachinprasadhs/repos", "events_url": "https://api.github.com/users/sachinprasadhs/events{/privacy}", "received_events_url": "https://api.github.com/users/sachinprasadhs/received_events", "type": "User", "site_admin": false }
[ { "login": "sachinprasadhs", "id": 73069040, "node_id": "MDQ6VXNlcjczMDY5MDQw", "avatar_url": "https://avatars.githubusercontent.com/u/73069040?v=4", "gravatar_id": "", "url": "https://api.github.com/users/sachinprasadhs", "html_url": "https://github.com/sachinprasadhs", "followers_url": "https://api.github.com/users/sachinprasadhs/followers", "following_url": "https://api.github.com/users/sachinprasadhs/following{/other_user}", "gists_url": "https://api.github.com/users/sachinprasadhs/gists{/gist_id}", "starred_url": "https://api.github.com/users/sachinprasadhs/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sachinprasadhs/subscriptions", "organizations_url": "https://api.github.com/users/sachinprasadhs/orgs", "repos_url": "https://api.github.com/users/sachinprasadhs/repos", "events_url": "https://api.github.com/users/sachinprasadhs/events{/privacy}", "received_events_url": "https://api.github.com/users/sachinprasadhs/received_events", "type": "User", "site_admin": false }, { "login": "wilsingosti", "id": 93937952, "node_id": "U_kgDOBZlhIA", "avatar_url": "https://avatars.githubusercontent.com/u/93937952?v=4", "gravatar_id": "", "url": "https://api.github.com/users/wilsingosti", "html_url": "https://github.com/wilsingosti", "followers_url": "https://api.github.com/users/wilsingosti/followers", "following_url": "https://api.github.com/users/wilsingosti/following{/other_user}", "gists_url": "https://api.github.com/users/wilsingosti/gists{/gist_id}", "starred_url": "https://api.github.com/users/wilsingosti/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/wilsingosti/subscriptions", "organizations_url": "https://api.github.com/users/wilsingosti/orgs", "repos_url": "https://api.github.com/users/wilsingosti/repos", "events_url": "https://api.github.com/users/wilsingosti/events{/privacy}", "received_events_url": "https://api.github.com/users/wilsingosti/received_events", "type": "User", "site_admin": false } ]
null
[]
2023-04-05T10:26:05
2023-04-26T18:40:08
null
CONTRIBUTOR
null
null
null
<details><summary>Click to expand!</summary> ### Issue Type Bug ### Have you reproduced the bug with TF nightly? Yes ### Source binary ### Tensorflow Version TF 2.12.0, TF nightly 2.13.0-dev20230404 ### Custom Code Yes ### OS Platform and Distribution _No response_ ### Mobile device _No response_ ### Python version _No response_ ### Bazel version _No response_ ### GCC/Compiler version _No response_ ### CUDA/cuDNN version _No response_ ### GPU model and memory _No response_ ### Current Behaviour? Consider the following code creating ragged batches using `tf.data.Dataset.ragged_batch`: ```python data = tf.data.Dataset.from_tensor_slices(tf.ragged.constant([[1, 2], [3]])) list(data.ragged_batch(2)) ``` The above code works fine in normal mode. However, if you enable debug mode using `tf.data.experimental.enable_debug_mode()`, the same code crashes with an error. ### Standalone code to reproduce the issue I reproduced the error in https://colab.research.google.com/drive/1nf1BHjssx2YhF0ZbbgPg1QSALSS4Z89r?usp=sharing , both for TF 2.12.0 and TF nightly 2.13.0-dev20230404. The code for triggering the bug is the following: ```python tf.data.experimental.enable_debug_mode() data = tf.data.Dataset.from_tensor_slices(tf.ragged.constant([[1, 2], [3]])) list(data.ragged_batch(2)) ``` ### Relevant log output Here is the error printed by TF 2.12.0 ``` --------------------------------------------------------------------------- InvalidArgumentError Traceback (most recent call last) <ipython-input-3-34b7e4bb8c4b> in <cell line: 4>() 2 tf.data.experimental.enable_debug_mode() 3 data = tf.data.Dataset.from_tensor_slices(tf.ragged.constant([[1, 2], [3]])) ----> 4 list(data.ragged_batch(2)) 3 frames /usr/local/lib/python3.9/dist-packages/tensorflow/python/framework/ops.py in raise_from_not_ok_status(e, name) 6651 def raise_from_not_ok_status(e, name): 6652 e.message += (" name: " + str(name if name is not None else "")) -> 6653 raise core._status_to_exception(e) from None # pylint: disable=protected-access 6654 6655 InvalidArgumentError: {{function_node __wrapped__IteratorGetNext_output_types_1_device_/job:localhost/replica:0/task:0/device:CPU:0}} ValueError: Value [1 2] is not convertible to a tensor with dtype <dtype: 'variant'> and shape (). Traceback (most recent call last): File "/usr/local/lib/python3.9/dist-packages/tensorflow/python/data/util/structure.py", line 347, in reduce_fn component = ops.convert_to_tensor(component, spec.dtype) File "/usr/local/lib/python3.9/dist-packages/tensorflow/python/profiler/trace.py", line 183, in wrapped return func(*args, **kwargs) File "/usr/local/lib/python3.9/dist-packages/tensorflow/python/framework/ops.py", line 1440, in convert_to_tensor return tensor_conversion_registry.convert( File "/usr/local/lib/python3.9/dist-packages/tensorflow/python/framework/tensor_conversion_registry.py", line 209, in convert return overload(dtype, name) # pylint: disable=not-callable File "/usr/local/lib/python3.9/dist-packages/tensorflow/python/framework/ops.py", line 1335, in __tf_tensor__ return super().__tf_tensor__(dtype, name) File "/usr/local/lib/python3.9/dist-packages/tensorflow/python/framework/ops.py", line 967, in __tf_tensor__ raise ValueError( ValueError: Tensor conversion requested dtype variant for Tensor with dtype int32: <tf.Tensor: shape=(2,), dtype=int32, numpy=array([1, 2], dtype=int32)> During handling of the above exception, another exception occurred: Traceback (most recent call last): File "/usr/local/lib/python3.9/dist-packages/tensorflow/python/ops/script_ops.py", line 266, in __call__ return func(device, token, args) File "/usr/local/lib/python3.9/dist-packages/tensorflow/python/ops/script_ops.py", line 144, in __call__ outputs = self._call(device, args) File "/usr/local/lib/python3.9/dist-packages/tensorflow/python/ops/script_ops.py", line 151, in _call ret = self._func(*args) File "/usr/local/lib/python3.9/dist-packages/tensorflow/python/autograph/impl/api.py", line 643, in wrapper return func(*args, **kwargs) File "/usr/local/lib/python3.9/dist-packages/tensorflow/python/data/ops/structured_function.py", line 213, in py_function_wrapper ret = structure.to_tensor_list(self._output_structure, ret) File "/usr/local/lib/python3.9/dist-packages/tensorflow/python/data/util/structure.py", line 410, in to_tensor_list return _to_tensor_list_helper( File "/usr/local/lib/python3.9/dist-packages/tensorflow/python/data/util/structure.py", line 360, in _to_tensor_list_helper return functools.reduce( File "/usr/local/lib/python3.9/dist-packages/tensorflow/python/data/util/structure.py", line 349, in reduce_fn raise ValueError( ValueError: Value [1 2] is not convertible to a tensor with dtype <dtype: 'variant'> and shape (). [[{{node EagerPyFunc}}]] [Op:IteratorGetNext] name: ``` </details>
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/60239/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/60239/timeline
null
null
false
https://api.github.com/repos/tensorflow/tensorflow/issues/60238
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/60238/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/60238/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/60238/events
https://github.com/tensorflow/tensorflow/pull/60238
1,655,262,603
PR_kwDOArmXAs5NqGXF
60,238
[Linaro:ARM_CI] Stop using ambe config as not needed
{ "login": "elfringham", "id": 10442001, "node_id": "MDQ6VXNlcjEwNDQyMDAx", "avatar_url": "https://avatars.githubusercontent.com/u/10442001?v=4", "gravatar_id": "", "url": "https://api.github.com/users/elfringham", "html_url": "https://github.com/elfringham", "followers_url": "https://api.github.com/users/elfringham/followers", "following_url": "https://api.github.com/users/elfringham/following{/other_user}", "gists_url": "https://api.github.com/users/elfringham/gists{/gist_id}", "starred_url": "https://api.github.com/users/elfringham/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/elfringham/subscriptions", "organizations_url": "https://api.github.com/users/elfringham/orgs", "repos_url": "https://api.github.com/users/elfringham/repos", "events_url": "https://api.github.com/users/elfringham/events{/privacy}", "received_events_url": "https://api.github.com/users/elfringham/received_events", "type": "User", "site_admin": false }
[ { "id": 390482148, "node_id": "MDU6TGFiZWwzOTA0ODIxNDg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/awaiting%20review", "name": "awaiting review", "color": "bc3869", "default": false, "description": "Pull request awaiting review" }, { "id": 987666414, "node_id": "MDU6TGFiZWw5ODc2NjY0MTQ=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/ready%20to%20pull", "name": "ready to pull", "color": "2cd643", "default": false, "description": "PR ready for merge process" }, { "id": 1169364458, "node_id": "MDU6TGFiZWwxMTY5MzY0NDU4", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/size:S", "name": "size:S", "color": "adafea", "default": false, "description": "CL Change Size: Small" } ]
closed
false
{ "login": "nitins17", "id": 29348997, "node_id": "MDQ6VXNlcjI5MzQ4OTk3", "avatar_url": "https://avatars.githubusercontent.com/u/29348997?v=4", "gravatar_id": "", "url": "https://api.github.com/users/nitins17", "html_url": "https://github.com/nitins17", "followers_url": "https://api.github.com/users/nitins17/followers", "following_url": "https://api.github.com/users/nitins17/following{/other_user}", "gists_url": "https://api.github.com/users/nitins17/gists{/gist_id}", "starred_url": "https://api.github.com/users/nitins17/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/nitins17/subscriptions", "organizations_url": "https://api.github.com/users/nitins17/orgs", "repos_url": "https://api.github.com/users/nitins17/repos", "events_url": "https://api.github.com/users/nitins17/events{/privacy}", "received_events_url": "https://api.github.com/users/nitins17/received_events", "type": "User", "site_admin": false }
[ { "login": "nitins17", "id": 29348997, "node_id": "MDQ6VXNlcjI5MzQ4OTk3", "avatar_url": "https://avatars.githubusercontent.com/u/29348997?v=4", "gravatar_id": "", "url": "https://api.github.com/users/nitins17", "html_url": "https://github.com/nitins17", "followers_url": "https://api.github.com/users/nitins17/followers", "following_url": "https://api.github.com/users/nitins17/following{/other_user}", "gists_url": "https://api.github.com/users/nitins17/gists{/gist_id}", "starred_url": "https://api.github.com/users/nitins17/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/nitins17/subscriptions", "organizations_url": "https://api.github.com/users/nitins17/orgs", "repos_url": "https://api.github.com/users/nitins17/repos", "events_url": "https://api.github.com/users/nitins17/events{/privacy}", "received_events_url": "https://api.github.com/users/nitins17/received_events", "type": "User", "site_admin": false }, { "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false } ]
null
[ "Please cherry pick this into the r2.12 branch to keep it able to build aarch64 with the CI scripts. The ambe config was removed from the docker container used to build this branch and so this cherry pick is needed to keep the branch able to build for aarch64. Without this cherry pick, the scripts will abort and no wheels will be produced for aarch64.", "For reference, the r2.12 commit that broke aarch64 build: https://github.com/tensorflow/tensorflow/commit/6fa05df43b00038b048f4f0e51ef522da6532fec\r\n" ]
2023-04-05T09:28:32
2023-05-31T11:07:12
2023-04-06T09:58:46
CONTRIBUTOR
null
false
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/pulls/60238", "html_url": "https://github.com/tensorflow/tensorflow/pull/60238", "diff_url": "https://github.com/tensorflow/tensorflow/pull/60238.diff", "patch_url": "https://github.com/tensorflow/tensorflow/pull/60238.patch", "merged_at": "2023-04-06T09:58:46" }
The use of the ambe config to build and test aarch64 is not needed and so stop using it. The ambe config will be removed in the future so this must be done in preparation. Also make cpu_arm64_pip.sh and cpu_arm64_nonpip.sh more similar for easier future maintenance.
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/60238/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/60238/timeline
null
null
true
https://api.github.com/repos/tensorflow/tensorflow/issues/60237
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/60237/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/60237/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/60237/events
https://github.com/tensorflow/tensorflow/issues/60237
1,655,248,558
I_kwDOArmXAs5iqRau
60,237
tensorflow-2.12.0 not support GPU
{ "login": "ghost", "id": 10137, "node_id": "MDQ6VXNlcjEwMTM3", "avatar_url": "https://avatars.githubusercontent.com/u/10137?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ghost", "html_url": "https://github.com/ghost", "followers_url": "https://api.github.com/users/ghost/followers", "following_url": "https://api.github.com/users/ghost/following{/other_user}", "gists_url": "https://api.github.com/users/ghost/gists{/gist_id}", "starred_url": "https://api.github.com/users/ghost/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ghost/subscriptions", "organizations_url": "https://api.github.com/users/ghost/orgs", "repos_url": "https://api.github.com/users/ghost/repos", "events_url": "https://api.github.com/users/ghost/events{/privacy}", "received_events_url": "https://api.github.com/users/ghost/received_events", "type": "User", "site_admin": false }
[ { "id": 386191887, "node_id": "MDU6TGFiZWwzODYxOTE4ODc=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/stat:awaiting%20response", "name": "stat:awaiting response", "color": "f4b400", "default": false, "description": "Status - Awaiting response from author" }, { "id": 473172988, "node_id": "MDU6TGFiZWw0NzMxNzI5ODg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/type:bug", "name": "type:bug", "color": "159b2e", "default": false, "description": "Bug" }, { "id": 473173351, "node_id": "MDU6TGFiZWw0NzMxNzMzNTE=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/type:build/install", "name": "type:build/install", "color": "159b2e", "default": false, "description": "Build and install issues" }, { "id": 473184161, "node_id": "MDU6TGFiZWw0NzMxODQxNjE=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/type:support", "name": "type:support", "color": "159b2e", "default": false, "description": "Support issues" }, { "id": 1097547538, "node_id": "MDU6TGFiZWwxMDk3NTQ3NTM4", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/comp:gpu", "name": "comp:gpu", "color": "0052cc", "default": false, "description": "GPU related issues" }, { "id": 5206407904, "node_id": "LA_kwDOArmXAs8AAAABNlN64A", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/TF%202.12", "name": "TF 2.12", "color": "c5def5", "default": false, "description": "For issues related to Tensorflow 2.12" } ]
closed
false
{ "login": "synandi", "id": 98147397, "node_id": "U_kgDOBdmcRQ", "avatar_url": "https://avatars.githubusercontent.com/u/98147397?v=4", "gravatar_id": "", "url": "https://api.github.com/users/synandi", "html_url": "https://github.com/synandi", "followers_url": "https://api.github.com/users/synandi/followers", "following_url": "https://api.github.com/users/synandi/following{/other_user}", "gists_url": "https://api.github.com/users/synandi/gists{/gist_id}", "starred_url": "https://api.github.com/users/synandi/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/synandi/subscriptions", "organizations_url": "https://api.github.com/users/synandi/orgs", "repos_url": "https://api.github.com/users/synandi/repos", "events_url": "https://api.github.com/users/synandi/events{/privacy}", "received_events_url": "https://api.github.com/users/synandi/received_events", "type": "User", "site_admin": false }
[ { "login": "synandi", "id": 98147397, "node_id": "U_kgDOBdmcRQ", "avatar_url": "https://avatars.githubusercontent.com/u/98147397?v=4", "gravatar_id": "", "url": "https://api.github.com/users/synandi", "html_url": "https://github.com/synandi", "followers_url": "https://api.github.com/users/synandi/followers", "following_url": "https://api.github.com/users/synandi/following{/other_user}", "gists_url": "https://api.github.com/users/synandi/gists{/gist_id}", "starred_url": "https://api.github.com/users/synandi/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/synandi/subscriptions", "organizations_url": "https://api.github.com/users/synandi/orgs", "repos_url": "https://api.github.com/users/synandi/repos", "events_url": "https://api.github.com/users/synandi/events{/privacy}", "received_events_url": "https://api.github.com/users/synandi/received_events", "type": "User", "site_admin": false } ]
null
[ "Hi @yatebyaeby, As per the official documentation, TensorFlow 2.10 was the last TensorFlow release that supported GPU on native-Windows. Starting with TensorFlow 2.11, you will need to install [TensorFlow in WSL2](https://tensorflow.org/install/pip#windows-wsl2). Hence, please try installing Tensorflow in WSL2. \r\n\r\nAlso note that, TensorFlow with GPU access is supported for WSL2 on Windows 10 19044 or higher. This corresponds to Windows 10 version 21H2, the November 2021 update. You can get the latest update from here: [Download Windows 10](https://www.microsoft.com/software-download/windows10). For instructions, see [Install WSL2](https://docs.microsoft.com/windows/wsl/install) and [NVIDIA’s setup docs](https://docs.nvidia.com/cuda/wsl-user-guide/index.html) for CUDA in WSL. Thank you!", "> Hi @yatebyaeby, As per the official documentation, TensorFlow 2.10 was the last TensorFlow release that supported GPU on native-Windows. Starting with TensorFlow 2.11, you will need to install [TensorFlow in WSL2](https://tensorflow.org/install/pip#windows-wsl2). Hence, please try installing Tensorflow in WSL2.\r\n> \r\n> Also note that, TensorFlow with GPU access is supported for WSL2 on Windows 10 19044 or higher. This corresponds to Windows 10 version 21H2, the November 2021 update. You can get the latest update from here: [Download Windows 10](https://www.microsoft.com/software-download/windows10). For instructions, see [Install WSL2](https://docs.microsoft.com/windows/wsl/install) and [NVIDIA’s setup docs](https://docs.nvidia.com/cuda/wsl-user-guide/index.html) for CUDA in WSL. Thank you!\r\n\r\noh, thanks for reply", "Are you satisfied with the resolution of your issue?\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=Yes&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/60237\">Yes</a>\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=No&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/60237\">No</a>\n" ]
2023-04-05T09:19:30
2023-04-05T13:23:20
2023-04-05T13:23:17
NONE
null
null
null
<details><summary>Click to expand!</summary> ### Issue Type Bug ### Have you reproduced the bug with TF nightly? No ### Source binary ### Tensorflow Version v2.12.0-rc1-12-g0db597d0d75 2.12.0 ### Custom Code No ### OS Platform and Distribution Windows 10 ### Mobile device - ### Python version 3.10.10 ### Bazel version - ### GCC/Compiler version - ### CUDA/cuDNN version cuda_11.8.0_522.06_windows / cudnn-windows-x86_64-8.6.0.163_cuda11 ### GPU model and memory 1050ti 4 GB ### Current Behaviour? ```shell Supporting GPU calcs. Ive tried version tf 2.10, all works, but 2.10 have some issues, that 2.12 dont have ``` ### Standalone code to reproduce the issue ```shell import tensorflow as tf from tensorflow.python.client import device_lib import numpy as np print(tf.__version__) print(f"Tensor Flow Version: {tf.__version__}") print(f"Keras Version: {tf.keras.__version__}") print() gpu = len(tf.config.list_physical_devices('GPU'))>0 print("GPU is", "available" if gpu else "NOT AVAILABLE") ``` ### Relevant log output ```shell 2.12.0 Tensor Flow Version: 2.12.0 Keras Version: 2.12.0 GPU is NOT AVAILABLE ``` </details>
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/60237/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/60237/timeline
null
completed
false
https://api.github.com/repos/tensorflow/tensorflow/issues/60236
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/60236/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/60236/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/60236/events
https://github.com/tensorflow/tensorflow/issues/60236
1,654,873,943
I_kwDOArmXAs5io19X
60,236
Distributed training using multiple GPUs hangs when enabling eager execution
{ "login": "Liqi1003", "id": 37407230, "node_id": "MDQ6VXNlcjM3NDA3MjMw", "avatar_url": "https://avatars.githubusercontent.com/u/37407230?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Liqi1003", "html_url": "https://github.com/Liqi1003", "followers_url": "https://api.github.com/users/Liqi1003/followers", "following_url": "https://api.github.com/users/Liqi1003/following{/other_user}", "gists_url": "https://api.github.com/users/Liqi1003/gists{/gist_id}", "starred_url": "https://api.github.com/users/Liqi1003/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Liqi1003/subscriptions", "organizations_url": "https://api.github.com/users/Liqi1003/orgs", "repos_url": "https://api.github.com/users/Liqi1003/repos", "events_url": "https://api.github.com/users/Liqi1003/events{/privacy}", "received_events_url": "https://api.github.com/users/Liqi1003/received_events", "type": "User", "site_admin": false }
[ { "id": 404586594, "node_id": "MDU6TGFiZWw0MDQ1ODY1OTQ=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/stat:awaiting%20tensorflower", "name": "stat:awaiting tensorflower", "color": "f4b400", "default": false, "description": "Status - Awaiting response from tensorflower" }, { "id": 473172988, "node_id": "MDU6TGFiZWw0NzMxNzI5ODg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/type:bug", "name": "type:bug", "color": "159b2e", "default": false, "description": "Bug" }, { "id": 1097547538, "node_id": "MDU6TGFiZWwxMDk3NTQ3NTM4", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/comp:gpu", "name": "comp:gpu", "color": "0052cc", "default": false, "description": "GPU related issues" }, { "id": 4829271983, "node_id": "LA_kwDOArmXAs8AAAABH9jXrw", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/TF%202.11", "name": "TF 2.11", "color": "46B4D7", "default": false, "description": "Issues related to TF 2.11" } ]
open
false
{ "login": "sachinprasadhs", "id": 73069040, "node_id": "MDQ6VXNlcjczMDY5MDQw", "avatar_url": "https://avatars.githubusercontent.com/u/73069040?v=4", "gravatar_id": "", "url": "https://api.github.com/users/sachinprasadhs", "html_url": "https://github.com/sachinprasadhs", "followers_url": "https://api.github.com/users/sachinprasadhs/followers", "following_url": "https://api.github.com/users/sachinprasadhs/following{/other_user}", "gists_url": "https://api.github.com/users/sachinprasadhs/gists{/gist_id}", "starred_url": "https://api.github.com/users/sachinprasadhs/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sachinprasadhs/subscriptions", "organizations_url": "https://api.github.com/users/sachinprasadhs/orgs", "repos_url": "https://api.github.com/users/sachinprasadhs/repos", "events_url": "https://api.github.com/users/sachinprasadhs/events{/privacy}", "received_events_url": "https://api.github.com/users/sachinprasadhs/received_events", "type": "User", "site_admin": false }
[ { "login": "sachinprasadhs", "id": 73069040, "node_id": "MDQ6VXNlcjczMDY5MDQw", "avatar_url": "https://avatars.githubusercontent.com/u/73069040?v=4", "gravatar_id": "", "url": "https://api.github.com/users/sachinprasadhs", "html_url": "https://github.com/sachinprasadhs", "followers_url": "https://api.github.com/users/sachinprasadhs/followers", "following_url": "https://api.github.com/users/sachinprasadhs/following{/other_user}", "gists_url": "https://api.github.com/users/sachinprasadhs/gists{/gist_id}", "starred_url": "https://api.github.com/users/sachinprasadhs/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sachinprasadhs/subscriptions", "organizations_url": "https://api.github.com/users/sachinprasadhs/orgs", "repos_url": "https://api.github.com/users/sachinprasadhs/repos", "events_url": "https://api.github.com/users/sachinprasadhs/events{/privacy}", "received_events_url": "https://api.github.com/users/sachinprasadhs/received_events", "type": "User", "site_admin": false } ]
null
[ "@Liqi1003 \r\n\r\nThe issue you're experiencing is likely due to a combination of factors: eager execution, MirroredStrategy, and multiple GPUs. As the warning message indicates, using MirroredStrategy eagerly has significant overhead and is not currently recommended.\r\n\r\nTo resolve this issue, you can try the following:\r\n\r\nWrap the code inside a tf.function. This will help reduce the overhead of running MirroredStrategy eagerly, as suggested by the warning message. \r\n\r\n``\r\n\r\[email protected]\r\ndef train_step(inputs, labels):\r\n with strategy.scope():\r\n model = keras.Sequential([\r\n keras.layers.Input(shape=(32, 32, 3)),\r\n keras.layers.GlobalMaxPool2D(),\r\n keras.layers.BatchNormalization(axis=-1),\r\n keras.layers.Dense(10, ), ])\r\n optimizer = keras.optimizers.Adam(learning_rate=0.1)\r\n loss = tf.keras.losses.MeanSquaredError(\r\n reduction=tf.keras.losses.Reduction.NONE)\r\n model.compile(optimizer=optimizer, loss=loss)\r\n\r\n return model.fit(inputs, labels)\r\n\r\nloss = train_step(train_input, train_label)\r\n\r\n``\r\nDisable eager execution by removing the following lines:\r\ntf.config.run_functions_eagerly(True)\r\ntf.data.experimental.enable_debug_mode()\r\n\r\nDisabling eager execution may help resolve the issue as well, but it is essential to understand that your code will not run eagerly, and you may need to adjust your code accordingly if it relies on eager execution.\r\n\r\nPlease try these solutions and see if they resolve the issue. If the problem persists, further investigation may be required to determine the root cause", "Thanks @Adesoji1 for your pointers. \r\n@Liqi1003 , Usually when you run the multi GPU distributed training in the eager mode, for each GPU it creates a new session and these sessions will not be synchronized since these are running in the eager mode and executes immediately. \r\nEven though `tf.distribute.Srategy` works well with both `eager` and `tf.function`, it works best with `tf.function` and `eager` mode is recommended for debug mode. ", "Thanks for the responses.\r\n\r\n@Adesoji1 \r\n1. Wrapping the function inside `@tf.function`, I see the same behavior in both TF2.11 and TF nightly.\r\n2. Turning off eager execution does solve the problem, but I wanted to use eager execution to help me debug the program, which is not working now.\r\n\r\n@sachinprasadhs, I understand that `tf.distribute.Strategy` works best with `tf.function` rather than `eager` mode. My previous code was using function mode. However, I'm trying to use eager execution to help me debug. I think it is officially supported, but currently it simply hangs/crashes and I cannot use it.\r\n", "@Liqi1003 glad to hear that Turning off eager execution does solve the problem.", "@sachinprasadhs Is this issue still under investigation or do I need to provide further information? Currently I am still unable to use eager mode with distributed training in the nightly version." ]
2023-04-05T03:33:55
2023-04-26T18:56:44
null
NONE
null
null
null
<details><summary>Click to expand!</summary> ### Issue Type Bug ### Have you reproduced the bug with TF nightly? Yes ### Source binary ### Tensorflow Version tf 2.11.0 ### Custom Code Yes ### OS Platform and Distribution Linux Ubuntu 20.04.5 LTS ### Mobile device _No response_ ### Python version 3.8.10 (docker tensorflow:devel-gpu) ### Bazel version _No response_ ### GCC/Compiler version _No response_ ### CUDA/cuDNN version 11.7 ### GPU model and memory _No response_ ### Current Behaviour? ```shell After adding the following code to enable eager execution: ` tf.config.run_functions_eagerly(True) tf.data.experimental.enable_debug_mode() ` Distributed training using MirroredStrategy with more than 2 GPUs hangs forever. Using 1 GPU does not trigger the bug. Using MirroredStrategy with multiple logical CPUs also does not trigger the bug. Whether adding the second line (`tf.data.experimental.enable_debug_mode()`) or not does not matter. The model we used is a simple Sequential model trained on CIFAR-10 dataset. The model structure is given as follows: ` Input - GlobalMaxPool2D - BatchNormalization- Dense ` Current behavior: Using tf 2.11.0, the program hangs at the line of code: `loss = model.fit(train_input, train_label)` Also, the program cannot be stopped gracefully by keyboard interruption. Using tf nightly, the program reports an error (see below). Expected behavior: The program should print the values of loss as an eager tensor. ``` ### Standalone code to reproduce the issue ```shell The code is also available at https://colab.research.google.com/drive/1BiAxZEO9IGak_4XOeZcyXRhJEByZ-X6B?usp=sharing import keras import tensorflow as tf tf.config.run_functions_eagerly(True) tf.data.experimental.enable_debug_mode() if __name__ == "__main__": # Using at least 2 GPU triggers the bug strategy = tf.distribute.MirroredStrategy(["/GPU:0", "/GPU:1"]) # Training data, batch_size=240 train_input = tf.random.uniform(shape=(240, 32, 32, 3)) train_label = tf.random.uniform(shape=(240, 10), minval=0, maxval=2, dtype=tf.int32) with strategy.scope(): model = keras.Sequential([ keras.layers.Input(shape=(32, 32, 3)), keras.layers.GlobalMaxPool2D(), keras.layers.BatchNormalization(axis=-1), keras.layers.Dense(10, ), ]) optimizer = keras.optimizers.Adam(learning_rate=0.1) loss = tf.keras.losses.MeanSquaredError( reduction=tf.keras.losses.Reduction.NONE) model.compile(optimizer=optimizer, loss=loss) # One step training loss = model.fit(train_input, train_label) print(loss) ``` ### Relevant log output ```shell -------------- Output using tf 2.11.0 ----------------------------- tf-docker /mnt/src/reproduce > python ./reproduce_eager.py 2023-04-05 03:23:45.884503: I tensorflow/core/platform/cpu_feature_guard.cc:193] This TensorFlow binary is optimized with oneAPI Deep Neural Network Library (oneDNN) to use the following CPU instructions in performance-critical operations: AVX2 AVX512F FMA To enable them in other operations, rebuild TensorFlow with the appropriate compiler flags. 2023-04-05 03:23:48.001421: I tensorflow/core/platform/cpu_feature_guard.cc:193] This TensorFlow binary is optimized with oneAPI Deep Neural Network Library (oneDNN) to use the following CPU instructions in performance-critical operations: AVX2 AVX512F FMA To enable them in other operations, rebuild TensorFlow with the appropriate compiler flags. 2023-04-05 03:23:53.074754: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1613] Created device /job:localhost/replica:0/task:0/device:GPU:0 with 9636 MB memory: -> device: 0, name: NVIDIA GeForce RTX 2080 Ti, pci bus id: 0000:3d:00.0, compute capability: 7.5 2023-04-05 03:23:53.076188: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1613] Created device /job:localhost/replica:0/task:0/device:GPU:1 with 9636 MB memory: -> device: 1, name: NVIDIA GeForce RTX 2080 Ti, pci bus id: 0000:3f:00.0, compute capability: 7.5 2023-04-05 03:23:53.077442: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1613] Created device /job:localhost/replica:0/task:0/device:GPU:2 with 9636 MB memory: -> device: 2, name: NVIDIA GeForce RTX 2080 Ti, pci bus id: 0000:40:00.0, compute capability: 7.5 2023-04-05 03:23:53.078666: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1613] Created device /job:localhost/replica:0/task:0/device:GPU:3 with 9636 MB memory: -> device: 3, name: NVIDIA GeForce RTX 2080 Ti, pci bus id: 0000:41:00.0, compute capability: 7.5 2023-04-05 03:23:53.079887: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1613] Created device /job:localhost/replica:0/task:0/device:GPU:4 with 9636 MB memory: -> device: 4, name: NVIDIA GeForce RTX 2080 Ti, pci bus id: 0000:61:00.0, compute capability: 7.5 2023-04-05 03:23:53.081109: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1613] Created device /job:localhost/replica:0/task:0/device:GPU:5 with 9636 MB memory: -> device: 5, name: NVIDIA GeForce RTX 2080 Ti, pci bus id: 0000:62:00.0, compute capability: 7.5 2023-04-05 03:23:53.082252: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1613] Created device /job:localhost/replica:0/task:0/device:GPU:6 with 9636 MB memory: -> device: 6, name: NVIDIA GeForce RTX 2080 Ti, pci bus id: 0000:63:00.0, compute capability: 7.5 2023-04-05 03:23:53.083395: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1613] Created device /job:localhost/replica:0/task:0/device:GPU:7 with 9636 MB memory: -> device: 7, name: NVIDIA GeForce RTX 2080 Ti, pci bus id: 0000:64:00.0, compute capability: 7.5 WARNING:tensorflow:Using MirroredStrategy eagerly has significant overhead currently. We will be working on improving this in the future, but for now please wrap `call_for_each_replica` or `experimental_run` or `run` inside a tf.function to get the best performance. (program hangs here) -------------------------------------------------------------------- -------------- Output using tf nightly ----------------------------- tf-docker /mnt/src/reproduce > python ./reproduce_eager.py 2023-04-05 03:29:24.607254: I tensorflow/core/platform/cpu_feature_guard.cc:182] This TensorFlow binary is optimized to use available CPU instructions in performance-critical operations. To enable the following instructions: AVX2 AVX512F FMA, in other operations, rebuild TensorFlow with the appropriate compiler flags. 2023-04-05 03:29:25.559092: W tensorflow/compiler/tf2tensorrt/utils/py_utils.cc:38] TF-TRT Warning: Could not find TensorRT 2023-04-05 03:29:32.898888: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1635] Created device /job:localhost/replica:0/task:0/device:GPU:0 with 9598 MB memory: -> device: 0, name: NVIDIA GeForce RTX 2080 Ti, pci bus id: 0000:3d:00.0, compute capability: 7.5 2023-04-05 03:29:32.900404: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1635] Created device /job:localhost/replica:0/task:0/device:GPU:1 with 9598 MB memory: -> device: 1, name: NVIDIA GeForce RTX 2080 Ti, pci bus id: 0000:3f:00.0, compute capability: 7.5 2023-04-05 03:29:32.901638: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1635] Created device /job:localhost/replica:0/task:0/device:GPU:2 with 9598 MB memory: -> device: 2, name: NVIDIA GeForce RTX 2080 Ti, pci bus id: 0000:40:00.0, compute capability: 7.5 2023-04-05 03:29:32.902870: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1635] Created device /job:localhost/replica:0/task:0/device:GPU:3 with 9598 MB memory: -> device: 3, name: NVIDIA GeForce RTX 2080 Ti, pci bus id: 0000:41:00.0, compute capability: 7.5 2023-04-05 03:29:32.904072: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1635] Created device /job:localhost/replica:0/task:0/device:GPU:4 with 9598 MB memory: -> device: 4, name: NVIDIA GeForce RTX 2080 Ti, pci bus id: 0000:61:00.0, compute capability: 7.5 2023-04-05 03:29:32.905328: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1635] Created device /job:localhost/replica:0/task:0/device:GPU:5 with 9598 MB memory: -> device: 5, name: NVIDIA GeForce RTX 2080 Ti, pci bus id: 0000:62:00.0, compute capability: 7.5 2023-04-05 03:29:32.906501: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1635] Created device /job:localhost/replica:0/task:0/device:GPU:6 with 9598 MB memory: -> device: 6, name: NVIDIA GeForce RTX 2080 Ti, pci bus id: 0000:63:00.0, compute capability: 7.5 2023-04-05 03:29:32.907653: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1635] Created device /job:localhost/replica:0/task:0/device:GPU:7 with 9598 MB memory: -> device: 7, name: NVIDIA GeForce RTX 2080 Ti, pci bus id: 0000:64:00.0, compute capability: 7.5 2023-04-05 03:29:33.578635: I tensorflow/core/common_runtime/executor.cc:1210] [/device:CPU:0] (DEBUG INFO) Executor start aborting (this does not indicate an error and you can ignore this message): INVALID_ARGUMENT: You must feed a value for placeholder tensor 'Placeholder/_9' with dtype int32 and shape [240,10] [[{{node Placeholder/_9}}]] 2023-04-05 03:29:33.578971: I tensorflow/core/common_runtime/executor.cc:1210] [/device:CPU:0] (DEBUG INFO) Executor start aborting (this does not indicate an error and you can ignore this message): INVALID_ARGUMENT: You must feed a value for placeholder tensor 'Placeholder/_9' with dtype int32 and shape [240,10] [[{{node Placeholder/_9}}]] WARNING:tensorflow:Using MirroredStrategy eagerly has significant overhead currently. We will be working on improving this in the future, but for now please wrap `call_for_each_replica` or `experimental_run` or `run` inside a tf.function to get the best performance. 2023-04-05 03:29:35.301668: E tensorflow/core/common_runtime/base_collective_executor.cc:249] BaseCollectiveExecutor::StartAbort UNKNOWN: Error invoking NCCL: unhandled cuda error Traceback (most recent call last): File "./reproduce_eager.py", line 27, in <module> loss = model.fit(train_input, train_label) File "/usr/local/lib/python3.8/dist-packages/keras/src/utils/traceback_utils.py", line 70, in error_handler raise e.with_traceback(filtered_tb) from None File "/usr/lib/python3.8/multiprocessing/pool.py", line 364, in map return self._map_async(func, iterable, mapstar, chunksize).get() File "/usr/lib/python3.8/multiprocessing/pool.py", line 771, in get raise self._value File "/usr/lib/python3.8/multiprocessing/pool.py", line 125, in worker result = (True, func(*args, **kwds)) File "/usr/lib/python3.8/multiprocessing/pool.py", line 48, in mapstar return list(map(*args)) tensorflow.python.framework.errors_impl.UnknownError: {{function_node __wrapped__CollectiveReduceV2_Nordering_token_1_device_/job:localhost/replica:0/task:0/device:GPU:1}} Collective ops is aborted by: Error invoking NCCL: unhandled cuda error The error could be from a previous operation. Restart your program to reset. [Op:CollectiveReduceV2] name: -------------------------------------------------------------------- ``` </details>
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/60236/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/60236/timeline
null
null
false
https://api.github.com/repos/tensorflow/tensorflow/issues/60235
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/60235/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/60235/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/60235/events
https://github.com/tensorflow/tensorflow/issues/60235
1,654,868,832
I_kwDOArmXAs5io0tg
60,235
Metadata server host isn't configurable with tf.io.gfile
{ "login": "samos123", "id": 388784, "node_id": "MDQ6VXNlcjM4ODc4NA==", "avatar_url": "https://avatars.githubusercontent.com/u/388784?v=4", "gravatar_id": "", "url": "https://api.github.com/users/samos123", "html_url": "https://github.com/samos123", "followers_url": "https://api.github.com/users/samos123/followers", "following_url": "https://api.github.com/users/samos123/following{/other_user}", "gists_url": "https://api.github.com/users/samos123/gists{/gist_id}", "starred_url": "https://api.github.com/users/samos123/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/samos123/subscriptions", "organizations_url": "https://api.github.com/users/samos123/orgs", "repos_url": "https://api.github.com/users/samos123/repos", "events_url": "https://api.github.com/users/samos123/events{/privacy}", "received_events_url": "https://api.github.com/users/samos123/received_events", "type": "User", "site_admin": false }
[ { "id": 404586594, "node_id": "MDU6TGFiZWw0MDQ1ODY1OTQ=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/stat:awaiting%20tensorflower", "name": "stat:awaiting tensorflower", "color": "f4b400", "default": false, "description": "Status - Awaiting response from tensorflower" }, { "id": 473172988, "node_id": "MDU6TGFiZWw0NzMxNzI5ODg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/type:bug", "name": "type:bug", "color": "159b2e", "default": false, "description": "Bug" }, { "id": 1478826728, "node_id": "MDU6TGFiZWwxNDc4ODI2NzI4", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/comp:core", "name": "comp:core", "color": "024391", "default": false, "description": "issues related to core part of tensorflow" }, { "id": 5206407904, "node_id": "LA_kwDOArmXAs8AAAABNlN64A", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/TF%202.12", "name": "TF 2.12", "color": "c5def5", "default": false, "description": "For issues related to Tensorflow 2.12" } ]
closed
false
{ "login": "MichaelHudgins", "id": 30155094, "node_id": "MDQ6VXNlcjMwMTU1MDk0", "avatar_url": "https://avatars.githubusercontent.com/u/30155094?v=4", "gravatar_id": "", "url": "https://api.github.com/users/MichaelHudgins", "html_url": "https://github.com/MichaelHudgins", "followers_url": "https://api.github.com/users/MichaelHudgins/followers", "following_url": "https://api.github.com/users/MichaelHudgins/following{/other_user}", "gists_url": "https://api.github.com/users/MichaelHudgins/gists{/gist_id}", "starred_url": "https://api.github.com/users/MichaelHudgins/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/MichaelHudgins/subscriptions", "organizations_url": "https://api.github.com/users/MichaelHudgins/orgs", "repos_url": "https://api.github.com/users/MichaelHudgins/repos", "events_url": "https://api.github.com/users/MichaelHudgins/events{/privacy}", "received_events_url": "https://api.github.com/users/MichaelHudgins/received_events", "type": "User", "site_admin": false }
[ { "login": "MichaelHudgins", "id": 30155094, "node_id": "MDQ6VXNlcjMwMTU1MDk0", "avatar_url": "https://avatars.githubusercontent.com/u/30155094?v=4", "gravatar_id": "", "url": "https://api.github.com/users/MichaelHudgins", "html_url": "https://github.com/MichaelHudgins", "followers_url": "https://api.github.com/users/MichaelHudgins/followers", "following_url": "https://api.github.com/users/MichaelHudgins/following{/other_user}", "gists_url": "https://api.github.com/users/MichaelHudgins/gists{/gist_id}", "starred_url": "https://api.github.com/users/MichaelHudgins/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/MichaelHudgins/subscriptions", "organizations_url": "https://api.github.com/users/MichaelHudgins/orgs", "repos_url": "https://api.github.com/users/MichaelHudgins/repos", "events_url": "https://api.github.com/users/MichaelHudgins/events{/privacy}", "received_events_url": "https://api.github.com/users/MichaelHudgins/received_events", "type": "User", "site_admin": false } ]
null
[ "Given the implementation is currently using a metadata url and not an ip i wonder if the more correct varaible would be `GCE_METADATA_HOST`. I am not sure what the difference would really end up being. ", "It seems it's inconsistent across different clients. Looking at google-auth-library-python, the GCE_METADATA_HOST should be used to override the endpoint and GCE_METADATA_IP is only used for the ping check: https://github.com/googleapis/google-auth-library-python/blob/34b78973418101fbf2326d9dba6d68e2eeb1b4c8/google/auth/compute_engine/_metadata.py#L36\r\n\r\nThis makes me think that GCE_METADATA_HOST would be more appropriate. That being said other parts in tensorflow like TPU client use GCE_METADATA_IP. Maybe you could make it such that both work?", "Yeah it doesn't seem terribly consistent unfortunately. I would lean towards adding `GCE_METADATA_HOST` for the c++ and maybe also allow it in the TPU location linked above. ", "That sounds good to me", "Fixed in: https://github.com/tensorflow/tensorflow/commit/7c0225a6167fcad0b1836a3948de1e52d2c436f3", "@samos123 closing the issue, feel free to reopen if solution does not work. ", "Are you satisfied with the resolution of your issue?\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=Yes&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/60235\">Yes</a>\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=No&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/60235\">No</a>\n" ]
2023-04-05T03:24:11
2023-04-05T20:42:21
2023-04-05T20:42:19
NONE
null
null
null
<details><summary>Click to expand!</summary> ### Issue Type Bug ### Have you reproduced the bug with TF nightly? Yes ### Source source ### Tensorflow Version latest ### Custom Code Yes ### OS Platform and Distribution _No response_ ### Mobile device _No response_ ### Python version _No response_ ### Bazel version _No response_ ### GCC/Compiler version _No response_ ### CUDA/cuDNN version _No response_ ### GPU model and memory _No response_ ### Current Behaviour? setting the env var `GCE_METADATA_IP` to something other than `http://metadata.google.internal` has no effect to get the default service account token. This is currently hardcoded here https://github.com/tensorflow/tensorflow/blob/aaa18fec1cba172911259ca7b619fe32e4667fac/tensorflow/tsl/platform/cloud/compute_engine_metadata_client.cc#L28 Expected: Respect the `GCE_METADATA_IP` env variable to be able to override `http://metadata.google.internal` Note that TPU client already does this correctly: https://github.com/tensorflow/tensorflow/pull/40317 ### Standalone code to reproduce the issue ```shell export GCE_METADATA_IP=http://127.0.0.1:8000 import tensorflow as tf tf.io.gfile.listdir("gs://sam-poc") ``` ### Relevant log output _No response_</details>
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/60235/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/60235/timeline
null
completed
false
https://api.github.com/repos/tensorflow/tensorflow/issues/60234
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/60234/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/60234/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/60234/events
https://github.com/tensorflow/tensorflow/issues/60234
1,654,761,278
I_kwDOArmXAs5ioac-
60,234
TFLite NNAPI Delegate converts INT8 UnidirectionalSequenceLSTM to incorrect NN operation type
{ "login": "q-ycong-p", "id": 50014064, "node_id": "MDQ6VXNlcjUwMDE0MDY0", "avatar_url": "https://avatars.githubusercontent.com/u/50014064?v=4", "gravatar_id": "", "url": "https://api.github.com/users/q-ycong-p", "html_url": "https://github.com/q-ycong-p", "followers_url": "https://api.github.com/users/q-ycong-p/followers", "following_url": "https://api.github.com/users/q-ycong-p/following{/other_user}", "gists_url": "https://api.github.com/users/q-ycong-p/gists{/gist_id}", "starred_url": "https://api.github.com/users/q-ycong-p/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/q-ycong-p/subscriptions", "organizations_url": "https://api.github.com/users/q-ycong-p/orgs", "repos_url": "https://api.github.com/users/q-ycong-p/repos", "events_url": "https://api.github.com/users/q-ycong-p/events{/privacy}", "received_events_url": "https://api.github.com/users/q-ycong-p/received_events", "type": "User", "site_admin": false }
[ { "id": 404586594, "node_id": "MDU6TGFiZWw0MDQ1ODY1OTQ=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/stat:awaiting%20tensorflower", "name": "stat:awaiting tensorflower", "color": "f4b400", "default": false, "description": "Status - Awaiting response from tensorflower" }, { "id": 473172988, "node_id": "MDU6TGFiZWw0NzMxNzI5ODg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/type:bug", "name": "type:bug", "color": "159b2e", "default": false, "description": "Bug" }, { "id": 750616506, "node_id": "MDU6TGFiZWw3NTA2MTY1MDY=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/comp:lite", "name": "comp:lite", "color": "0052cc", "default": false, "description": "TF Lite related issues" }, { "id": 1661751498, "node_id": "MDU6TGFiZWwxNjYxNzUxNDk4", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/TFLiteConverter", "name": "TFLiteConverter", "color": "bfdadc", "default": false, "description": "For issues related to TFLite converter" }, { "id": 2671351731, "node_id": "MDU6TGFiZWwyNjcxMzUxNzMx", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/ModelOptimizationToolkit", "name": "ModelOptimizationToolkit", "color": "BFD629", "default": false, "description": "TF Model Optimization Toolkit" }, { "id": 2671354709, "node_id": "MDU6TGFiZWwyNjcxMzU0NzA5", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/TFLiteNNAPIDelegate", "name": "TFLiteNNAPIDelegate", "color": "65916E", "default": false, "description": "For issues related to TFLite NNAPI Delegate" }, { "id": 5206407904, "node_id": "LA_kwDOArmXAs8AAAABNlN64A", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/TF%202.12", "name": "TF 2.12", "color": "c5def5", "default": false, "description": "For issues related to Tensorflow 2.12" } ]
open
false
{ "login": "sirakiin", "id": 4479310, "node_id": "MDQ6VXNlcjQ0NzkzMTA=", "avatar_url": "https://avatars.githubusercontent.com/u/4479310?v=4", "gravatar_id": "", "url": "https://api.github.com/users/sirakiin", "html_url": "https://github.com/sirakiin", "followers_url": "https://api.github.com/users/sirakiin/followers", "following_url": "https://api.github.com/users/sirakiin/following{/other_user}", "gists_url": "https://api.github.com/users/sirakiin/gists{/gist_id}", "starred_url": "https://api.github.com/users/sirakiin/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sirakiin/subscriptions", "organizations_url": "https://api.github.com/users/sirakiin/orgs", "repos_url": "https://api.github.com/users/sirakiin/repos", "events_url": "https://api.github.com/users/sirakiin/events{/privacy}", "received_events_url": "https://api.github.com/users/sirakiin/received_events", "type": "User", "site_admin": false }
[ { "login": "sirakiin", "id": 4479310, "node_id": "MDQ6VXNlcjQ0NzkzMTA=", "avatar_url": "https://avatars.githubusercontent.com/u/4479310?v=4", "gravatar_id": "", "url": "https://api.github.com/users/sirakiin", "html_url": "https://github.com/sirakiin", "followers_url": "https://api.github.com/users/sirakiin/followers", "following_url": "https://api.github.com/users/sirakiin/following{/other_user}", "gists_url": "https://api.github.com/users/sirakiin/gists{/gist_id}", "starred_url": "https://api.github.com/users/sirakiin/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sirakiin/subscriptions", "organizations_url": "https://api.github.com/users/sirakiin/orgs", "repos_url": "https://api.github.com/users/sirakiin/repos", "events_url": "https://api.github.com/users/sirakiin/events{/privacy}", "received_events_url": "https://api.github.com/users/sirakiin/received_events", "type": "User", "site_admin": false }, { "login": "sachinprasadhs", "id": 73069040, "node_id": "MDQ6VXNlcjczMDY5MDQw", "avatar_url": "https://avatars.githubusercontent.com/u/73069040?v=4", "gravatar_id": "", "url": "https://api.github.com/users/sachinprasadhs", "html_url": "https://github.com/sachinprasadhs", "followers_url": "https://api.github.com/users/sachinprasadhs/followers", "following_url": "https://api.github.com/users/sachinprasadhs/following{/other_user}", "gists_url": "https://api.github.com/users/sachinprasadhs/gists{/gist_id}", "starred_url": "https://api.github.com/users/sachinprasadhs/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sachinprasadhs/subscriptions", "organizations_url": "https://api.github.com/users/sachinprasadhs/orgs", "repos_url": "https://api.github.com/users/sachinprasadhs/repos", "events_url": "https://api.github.com/users/sachinprasadhs/events{/privacy}", "received_events_url": "https://api.github.com/users/sachinprasadhs/received_events", "type": "User", "site_admin": false } ]
null
[ "I've checked a few NNAPI delegate related posts. It looks like @miaowang14 has knowledge on this topic? If so I'd really appreciate some pointer! Thanks!", "Here is the dummy TFLite model to reproduce the NNAPI delegate issue: [lstm_w_emb_and_dense_3.8b.tflite.zip](https://github.com/tensorflow/tensorflow/files/11154211/lstm_w_emb_and_dense_3.8b.tflite.zip)\r\n", "Additionally, I've also tried the post-training dynamic range quantization which I would prefer to use. The result TFLite model of such quantization has float32 weights. Running that model with `use-nnapi` enabled shows that LSTM is not partitioned on NNAPI delegate. With `setprop debug.nn.vlog 1`, logcat info still does not show why LSTM cannot be partitioned to NNAPI delegate.\r\n\r\nWith the full integer INT8 quantization in post, at least I see that the entire graph is partitioned to NNAPI delegate. Would appreciate your thoughts here too!", "Hi @tiruk007, any chance dev can take a look? Thanks!", "For LSTM operation types, TFLite `builtin_ops.h` contains 3 variants `kTfLiteBuiltinLstm`, `kTfLiteBuiltinUnidirectionalSequenceLstm` and `kTfLiteBuiltinBidirectionalSequenceLstm` which is not distinguished by data types, see [here](https://github.com/tensorflow/tensorflow/blob/master/tensorflow/lite/builtin_ops.h#L74). On the NNAPI side, there're more LSTM operation variants, especially the quantized op has a separate operation type `ANEURALNETWORKS_QUANTIZED_LSTM`, which is distinguished from the float `ANEURALNETWORKS_UNIDIRECTIONAL_SEQUENCE_LSTM` variant, [here](https://developer.android.com/ndk/reference/group/neural-networks#group___neural_networks_1ggaabbe492c60331b13038e39d4207940e0aaf30e491ad0b1fc7602cbde695b2c859).\r\n\r\nMy understanding is that a full int8 TFLite `kTfLiteBuiltinUnidirectionalSequenceLstm` should be converted to NNAPI `ANEURALNETWORKS_QUANTIZED_LSTM` instead of the float variant.\r\n\r\nHowever, in TFLite's `nnapi_delegate.cc`'s `Map` function, `kTfLiteBuiltinUnidirectionalSequenceLstm` is mapped to `ANEURALNETWORKS_UNIDIRECTIONAL_SEQUENCE_LSTM`, see [here](https://github.com/tensorflow/tensorflow/blob/master/tensorflow/lite/delegates/nnapi/nnapi_delegate.cc#L3810-L3837). This seems to lead to the NNAPI operation creation issue in post? Pls point out what i'm missing.\r\n\r\nBesides, the `Validate` function seems to check and ensure `kTfLiteBuiltinUnidirectionalSequenceLstm` is not hybrid - which is a bit confusing. Could someone explain to me pls?" ]
2023-04-05T00:46:36
2023-10-05T22:19:28
null
NONE
null
null
null
<details><summary>Click to expand!</summary> ### Issue Type Bug ### Have you reproduced the bug with TF nightly? No ### Source source ### Tensorflow Version tf 2.12.0 ### Custom Code No ### OS Platform and Distribution Android 12, aarch64 ### Mobile device Pixel 4 xl ### Python version _No response_ ### Bazel version _No response_ ### GCC/Compiler version _No response_ ### CUDA/cuDNN version _No response_ ### GPU model and memory _No response_ ### Current Behaviour? ```shell I am trying to run a basic LSTM TFLite model with NNAPI delegate to explore the acceleration from Snapdragon 855's DSP Hexagon 690. I converted the simple LSTM model with full integer post-training quantization with intention to maximize hardware acceleration support, and ran this model on Pixel 4xl (snapdragon 855) with the latest pre-downloaded TFLite benchmark binary tool. I am able to run other non-8bit model - env setup is correct. But 8bit model encountered error ` Unsupported input operand type for UNIDIRECTIONAL_SEQUENCE_LSTM op: TENSOR_QUANT8_ASYMM_SIGNED`. I looked at NNAPI's operation support doc. It seems that operation `ANEURALNETWORKS_QUANTIZED_LSTM` is supported with the int8 inputs/outputs weights. But logcat suggests that TFLite NNAPI Model building process has converted the 8bit TFlite `UnidirectionalSequenceLSTM` to the non-quantized version `ANEURALNETWORKS_UNIDIRECTIONAL_SEQUENCE_LSTM`. Could this incorrect TFLite->NN operation conversion led to [this error](https://android.googlesource.com/platform/frameworks/ml/+/master/nn/common/operations/UnidirectionalSequenceLSTM.cpp#156)? ``` ### Standalone code to reproduce the issue ```shell ### To make the dummy TFLite model def representative_dataset(): """Just to make dummy input data for full integer quantization""" for _ in range(100): data = np.random.rand(8, 16) yield [data.astype(np.float32)] import tensorflow as tf from tensorflow.keras.models import Model from tensorflow.keras.layers import Input, Embedding, LSTM, Dense # make keras model units = 512 batch_size = 8 model_in = Input(shape=(16,), batch_size=batch_size) model = Model(model_in, Dense(units, activation="relu")(LSTM(736)(Embedding(4001, units,)(model_in)))) # convert to TFLite format converter.optimizations = [tf.lite.Optimize.DEFAULT] converter.representative_dataset = representative_dataset converter._experimental_default_to_single_batch_in_tensor_list_ops = True tflite_model = converter.convert() ``` ### To run on device with TFLite benchmark tool Whether to turn `disable_nnapi_cpu` to true or false makes no difference. ``` ./android_aarch64_benchmark_model --graph=/data/local/model/lstm_w_emb_and_dense_3.8b.tflite --use_nnapi=true --verbose=true ``` ``` ### Relevant log output ```shell --------- beginning of main 2023-04-04 17:24:18.427 19036-19036 tflite pid-19036 I STARTING! 2023-04-04 17:24:18.428 19036-19036 tflite pid-19036 I Log parameter values verbosely: [1] 2023-04-04 17:24:18.428 19036-19036 tflite pid-19036 I Min num runs: [50] 2023-04-04 17:24:18.428 19036-19036 tflite pid-19036 I Min runs duration (seconds): [1] 2023-04-04 17:24:18.428 19036-19036 tflite pid-19036 I Max runs duration (seconds): [150] 2023-04-04 17:24:18.428 19036-19036 tflite pid-19036 I Inter-run delay (seconds): [-1] 2023-04-04 17:24:18.428 19036-19036 tflite pid-19036 I Number of prorated runs per second: [-1] 2023-04-04 17:24:18.428 19036-19036 tflite pid-19036 I Num threads: [-1] 2023-04-04 17:24:18.428 19036-19036 tflite pid-19036 I Use caching: [0] 2023-04-04 17:24:18.428 19036-19036 tflite pid-19036 I Benchmark name: [] 2023-04-04 17:24:18.428 19036-19036 tflite pid-19036 I Output prefix: [] 2023-04-04 17:24:18.428 19036-19036 tflite pid-19036 I Min warmup runs: [1] 2023-04-04 17:24:18.428 19036-19036 tflite pid-19036 I Min warmup runs duration (seconds): [0.5] 2023-04-04 17:24:18.428 19036-19036 tflite pid-19036 I Run w/o invoking kernels: [0] 2023-04-04 17:24:18.428 19036-19036 tflite pid-19036 I Report the peak memory footprint: [0] 2023-04-04 17:24:18.428 19036-19036 tflite pid-19036 I Memory footprint check interval (ms): [50] 2023-04-04 17:24:18.428 19036-19036 tflite pid-19036 I Graph: [/data/local/model/lstm_w_emb_and_dense_3.8b.tflite] 2023-04-04 17:24:18.428 19036-19036 tflite pid-19036 I Input layers: [] 2023-04-04 17:24:18.428 19036-19036 tflite pid-19036 I Input shapes: [] 2023-04-04 17:24:18.428 19036-19036 tflite pid-19036 I Input value ranges: [] 2023-04-04 17:24:18.428 19036-19036 tflite pid-19036 I Input value files: [] 2023-04-04 17:24:18.428 19036-19036 tflite pid-19036 I Allow fp16: [0] 2023-04-04 17:24:18.428 19036-19036 tflite pid-19036 I Require full delegation: [0] 2023-04-04 17:24:18.428 19036-19036 tflite pid-19036 I Enable op profiling: [0] 2023-04-04 17:24:18.428 19036-19036 tflite pid-19036 I Max initial profiling buffer entries: [1024] 2023-04-04 17:24:18.428 19036-19036 tflite pid-19036 I Allow dynamic increase on profiling buffer entries: [0] 2023-04-04 17:24:18.428 19036-19036 tflite pid-19036 I CSV File to export profiling data to: [] 2023-04-04 17:24:18.428 19036-19036 tflite pid-19036 I Print pre-invoke interpreter state: [0] 2023-04-04 17:24:18.428 19036-19036 tflite pid-19036 I Print post-invoke interpreter state: [0] 2023-04-04 17:24:18.428 19036-19036 tflite pid-19036 I Release dynamic tensor memory: [0] 2023-04-04 17:24:18.428 19036-19036 tflite pid-19036 I Optimize memory usage for large tensors: [0] 2023-04-04 17:24:18.428 19036-19036 tflite pid-19036 I Disable delegate clustering: [0] 2023-04-04 17:24:18.428 19036-19036 tflite pid-19036 I File path to export outputs layer to: [] 2023-04-04 17:24:18.428 19036-19036 tflite pid-19036 I print out all supported flags: [0] 2023-04-04 17:24:18.428 19036-19036 tflite pid-19036 I #threads used for CPU inference: [-1] 2023-04-04 17:24:18.428 19036-19036 tflite pid-19036 I Max number of delegated partitions: [0] 2023-04-04 17:24:18.428 19036-19036 tflite pid-19036 I Min nodes per partition: [0] 2023-04-04 17:24:18.428 19036-19036 tflite pid-19036 I Index of the first node that could be delegated: [0] 2023-04-04 17:24:18.428 19036-19036 tflite pid-19036 I Index of the first node that could be delegated: [2147483647] 2023-04-04 17:24:18.428 19036-19036 tflite pid-19036 I Directory for delegate serialization: [] 2023-04-04 17:24:18.429 19036-19036 tflite pid-19036 I Model-specific token/key for delegate serialization.: [] 2023-04-04 17:24:18.429 19036-19036 tflite pid-19036 I External delegate path: [] 2023-04-04 17:24:18.429 19036-19036 tflite pid-19036 I External delegate options: [] 2023-04-04 17:24:18.429 19036-19036 tflite pid-19036 I Use gpu: [0] 2023-04-04 17:24:18.429 19036-19036 tflite pid-19036 I Allow lower precision in gpu: [1] 2023-04-04 17:24:18.429 19036-19036 tflite pid-19036 I Enable running quant models in gpu: [1] 2023-04-04 17:24:18.429 19036-19036 tflite pid-19036 I Prefer maximizing the throughput in gpu: [0] 2023-04-04 17:24:18.429 19036-19036 tflite pid-19036 I GPU backend: [] 2023-04-04 17:24:18.429 19036-19036 tflite pid-19036 I Use Hexagon: [0] 2023-04-04 17:24:18.429 19036-19036 tflite pid-19036 I Hexagon lib path: [/data/local/tmp] 2023-04-04 17:24:18.429 19036-19036 tflite pid-19036 I Hexagon profiling: [0] 2023-04-04 17:24:18.429 19036-19036 tflite pid-19036 I Use NNAPI: [1] 2023-04-04 17:24:18.429 19036-19036 tflite pid-19036 I NNAPI execution preference: [] 2023-04-04 17:24:18.429 19036-19036 tflite pid-19036 I Model execution priority in nnapi: [] 2023-04-04 17:24:18.429 19036-19036 tflite pid-19036 I NNAPI accelerator name: [] 2023-04-04 17:24:18.475 19036-19036 Manager pid-19036 I DeviceManager::DeviceManager 2023-04-04 17:24:18.475 19036-19036 Manager pid-19036 I findAvailableDevices 2023-04-04 17:24:18.475 19036-19036 ProcessState pid-19036 D Binder ioctl to enable oneway spam detection failed: Invalid argument 2023-04-04 17:24:17.843 0-0 <no-tag> kernel I c7 19036 binder: 19036:19036 ioctl 40046210 7ff47b1524 returned -22 2023-04-04 17:24:18.476 19036-19036 hw-ProcessState pid-19036 D Binder ioctl to enable oneway spam detection failed: Invalid argument 2023-04-04 17:24:17.844 0-0 <no-tag> kernel I c6 19036 binder: 19036:19036 ioctl 40046210 7ff47b1484 returned -22 2023-04-04 17:24:18.480 19036-19036 Manager pid-19036 I Found interface qti-default 2023-04-04 17:24:18.480 19036-19036 Manager pid-19036 I Found interface qti-dsp 2023-04-04 17:24:18.480 19036-19036 Manager pid-19036 I Found interface qti-gpu 2023-04-04 17:24:18.480 19036-19036 Manager pid-19036 I Found interface google-edgetpu 2023-04-04 17:24:18.480 19036-19036 tflite pid-19036 I NNAPI accelerators available: [qti-default,qti-dsp,qti-gpu,google-edgetpu,nnapi-reference] 2023-04-04 17:24:18.480 19036-19036 tflite pid-19036 I Disable NNAPI cpu: [0] 2023-04-04 17:24:18.480 19036-19036 tflite pid-19036 I Allow fp16 in NNAPI: [0] 2023-04-04 17:24:18.480 19036-19036 tflite pid-19036 I Allow dynamic dimensions in NNAPI: [0] 2023-04-04 17:24:18.480 19036-19036 tflite pid-19036 I Use burst mode in NNAPI: [0] 2023-04-04 17:24:18.480 19036-19036 tflite pid-19036 I Use xnnpack: [0] 2023-04-04 17:24:18.480 19036-19036 tflite pid-19036 I Loaded model /data/local/model/lstm_w_emb_and_dense_3.8b.tflite 2023-04-04 17:24:18.480 19036-19036 tflite pid-19036 I Initialized TensorFlow Lite runtime. 2023-04-04 17:24:18.481 19036-19036 tflite pid-19036 I Created TensorFlow Lite delegate for NNAPI. 2023-04-04 17:24:18.481 19036-19036 tflite pid-19036 I NNAPI delegate created. 2023-04-04 17:24:18.482 19036-19036 tflite pid-19036 I Replacing 6 node(s) with delegate (TfLiteNnapiDelegate) node, yielding 1 partitions for the whole graph. 2023-04-04 17:24:18.482 19036-19036 ModelBuilder pid-19036 I setOperandValue for operand 2 size 2048512 2023-04-04 17:24:18.482 19036-19036 TypeManager pid-19036 I TypeManager::TypeManager 2023-04-04 17:24:18.482 19036-19036 TypeManager pid-19036 I Failed to read /vendor/etc/nnapi_extensions_app_allowlist ; No app allowlisted for vendor extensions use. 2023-04-04 17:24:18.482 19036-19036 TypeManager pid-19036 I NNAPI Vendor extensions enabled: 1 2023-04-04 17:24:18.482 19036-19036 TypeManager pid-19036 I Registered extension com.google.edgetpu_precompiled 2023-04-04 17:24:18.482 19036-19036 ModelBuilder pid-19036 I Saving large value 2023-04-04 17:24:18.482 19036-19036 ModelBuilder pid-19036 I setOperandValue for operand 3 size 4 2023-04-04 17:24:18.482 19036-19036 ModelBuilder pid-19036 I Copied small value to offset 0 2023-04-04 17:24:18.482 19036-19036 ModelBuilder pid-19036 I setOperandValue for operand 5 size 376832 2023-04-04 17:24:18.482 19036-19036 ModelBuilder pid-19036 I Saving large value 2023-04-04 17:24:18.482 19036-19036 ModelBuilder pid-19036 I setOperandValue for operand 6 size 376832 2023-04-04 17:24:18.482 19036-19036 ModelBuilder pid-19036 I Saving large value 2023-04-04 17:24:18.482 19036-19036 ModelBuilder pid-19036 I setOperandValue for operand 7 size 376832 2023-04-04 17:24:18.482 19036-19036 ModelBuilder pid-19036 I Saving large value 2023-04-04 17:24:18.482 19036-19036 ModelBuilder pid-19036 I setOperandValue for operand 8 size 376832 2023-04-04 17:24:18.482 19036-19036 ModelBuilder pid-19036 I Saving large value 2023-04-04 17:24:18.483 19036-19036 ModelBuilder pid-19036 I setOperandValue for operand 9 size 541696 2023-04-04 17:24:18.483 19036-19036 ModelBuilder pid-19036 I Saving large value 2023-04-04 17:24:18.483 19036-19036 ModelBuilder pid-19036 I setOperandValue for operand 10 size 541696 2023-04-04 17:24:18.483 19036-19036 ModelBuilder pid-19036 I Saving large value 2023-04-04 17:24:18.483 19036-19036 ModelBuilder pid-19036 I setOperandValue for operand 11 size 541696 2023-04-04 17:24:18.483 19036-19036 ModelBuilder pid-19036 I Saving large value 2023-04-04 17:24:18.483 19036-19036 ModelBuilder pid-19036 I setOperandValue for operand 12 size 541696 2023-04-04 17:24:18.483 19036-19036 ModelBuilder pid-19036 I Saving large value 2023-04-04 17:24:18.483 19036-19036 ModelBuilder pid-19036 I setOperandValue for operand 13 size 0 2023-04-04 17:24:18.483 19036-19036 ModelBuilder pid-19036 I setOperandValue for operand 14 size 0 2023-04-04 17:24:18.483 19036-19036 ModelBuilder pid-19036 I setOperandValue for operand 15 size 0 2023-04-04 17:24:18.483 19036-19036 ModelBuilder pid-19036 I setOperandValue for operand 16 size 2944 2023-04-04 17:24:18.483 19036-19036 ModelBuilder pid-19036 I Saving large value 2023-04-04 17:24:18.483 19036-19036 ModelBuilder pid-19036 I setOperandValue for operand 17 size 2944 2023-04-04 17:24:18.483 19036-19036 ModelBuilder pid-19036 I Saving large value 2023-04-04 17:24:18.483 19036-19036 ModelBuilder pid-19036 I setOperandValue for operand 18 size 2944 2023-04-04 17:24:18.483 19036-19036 ModelBuilder pid-19036 I Saving large value 2023-04-04 17:24:18.483 19036-19036 ModelBuilder pid-19036 I setOperandValue for operand 19 size 2944 2023-04-04 17:24:18.483 19036-19036 ModelBuilder pid-19036 I Saving large value 2023-04-04 17:24:18.483 19036-19036 ModelBuilder pid-19036 I setOperandValue for operand 20 size 0 2023-04-04 17:24:18.483 19036-19036 ModelBuilder pid-19036 I setOperandValue for operand 21 size 0 2023-04-04 17:24:18.483 19036-19036 ModelBuilder pid-19036 I setOperandValue for operand 24 size 4 2023-04-04 17:24:18.483 19036-19036 ModelBuilder pid-19036 I Copied small value to offset 4 2023-04-04 17:24:18.483 19036-19036 ModelBuilder pid-19036 I setOperandValue for operand 25 size 4 2023-04-04 17:24:18.483 19036-19036 ModelBuilder pid-19036 I Copied small value to offset 8 2023-04-04 17:24:18.483 19036-19036 ModelBuilder pid-19036 I setOperandValue for operand 26 size 4 2023-04-04 17:24:18.483 19036-19036 ModelBuilder pid-19036 I Copied small value to offset 12 2023-04-04 17:24:18.483 19036-19036 ModelBuilder pid-19036 I setOperandValue for operand 27 size 1 2023-04-04 17:24:18.483 19036-19036 ModelBuilder pid-19036 I Copied small value to offset 16 2023-04-04 17:24:18.483 19036-19036 ModelBuilder pid-19036 I setOperandValue for operand 28 size 0 2023-04-04 17:24:18.483 19036-19036 ModelBuilder pid-19036 I setOperandValue for operand 29 size 0 2023-04-04 17:24:18.483 19036-19036 ModelBuilder pid-19036 I setOperandValue for operand 30 size 0 2023-04-04 17:24:18.483 19036-19036 ModelBuilder pid-19036 I setOperandValue for operand 31 size 0 2023-04-04 17:24:18.483 19036-19036 Operations pid-19036 E NN_RET_CHECK failed (packages/modules/NeuralNetworks/common/operations/UnidirectionalSequenceLSTM.cpp:160): Unsupported input operand type for UNIDIRECTIONAL_SEQUENCE_LSTM op: TENSOR_QUANT8_ASYMM_SIGNED 2023-04-04 17:24:18.483 19036-19036 ModelBuilder pid-19036 E Invalid Operation: NN_RET_CHECK failed (packages/modules/NeuralNetworks/common/operations/UnidirectionalSequenceLSTM.cpp:160): Unsupported input operand type for UNIDIRECTIONAL_SEQUENCE_LSTM op: TENSOR_QUANT8_ASYMM_SIGNED 2023-04-04 17:24:18.483 19036-19036 tflite pid-19036 E NN API returned error ANEURALNETWORKS_BAD_DATA at line 1131 while adding operation. 2023-04-04 17:24:18.483 19036-19036 tflite pid-19036 E Node number 6 (TfLiteNnapiDelegate) failed to prepare. 2023-04-04 17:24:18.483 19036-19036 tflite pid-19036 E Restored original execution plan after delegate application failure. 2023-04-04 17:24:18.484 19036-19036 tflite pid-19036 E Failed to apply NNAPI delegate. 2023-04-04 17:24:18.484 19036-19036 tflite pid-19036 E Benchmarking failed. ``` </details>
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/60234/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/60234/timeline
null
null
false
https://api.github.com/repos/tensorflow/tensorflow/issues/60233
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/60233/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/60233/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/60233/events
https://github.com/tensorflow/tensorflow/pull/60233
1,654,548,839
PR_kwDOArmXAs5NnuDG
60,233
[NVIDIA XLA:GPU] Fused MHA Support in XLA GPU: Compiler lowerings and runtime
{ "login": "AyanmoI", "id": 42984676, "node_id": "MDQ6VXNlcjQyOTg0Njc2", "avatar_url": "https://avatars.githubusercontent.com/u/42984676?v=4", "gravatar_id": "", "url": "https://api.github.com/users/AyanmoI", "html_url": "https://github.com/AyanmoI", "followers_url": "https://api.github.com/users/AyanmoI/followers", "following_url": "https://api.github.com/users/AyanmoI/following{/other_user}", "gists_url": "https://api.github.com/users/AyanmoI/gists{/gist_id}", "starred_url": "https://api.github.com/users/AyanmoI/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/AyanmoI/subscriptions", "organizations_url": "https://api.github.com/users/AyanmoI/orgs", "repos_url": "https://api.github.com/users/AyanmoI/repos", "events_url": "https://api.github.com/users/AyanmoI/events{/privacy}", "received_events_url": "https://api.github.com/users/AyanmoI/received_events", "type": "User", "site_admin": false }
[ { "id": 1133285679, "node_id": "MDU6TGFiZWwxMTMzMjg1Njc5", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/comp:xla", "name": "comp:xla", "color": "0052cc", "default": false, "description": "XLA" }, { "id": 1173072136, "node_id": "MDU6TGFiZWwxMTczMDcyMTM2", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/size:XL", "name": "size:XL", "color": "adafea", "default": false, "description": "CL Change Size:Extra Large" } ]
closed
false
{ "login": "cheshire", "id": 348959, "node_id": "MDQ6VXNlcjM0ODk1OQ==", "avatar_url": "https://avatars.githubusercontent.com/u/348959?v=4", "gravatar_id": "", "url": "https://api.github.com/users/cheshire", "html_url": "https://github.com/cheshire", "followers_url": "https://api.github.com/users/cheshire/followers", "following_url": "https://api.github.com/users/cheshire/following{/other_user}", "gists_url": "https://api.github.com/users/cheshire/gists{/gist_id}", "starred_url": "https://api.github.com/users/cheshire/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/cheshire/subscriptions", "organizations_url": "https://api.github.com/users/cheshire/orgs", "repos_url": "https://api.github.com/users/cheshire/repos", "events_url": "https://api.github.com/users/cheshire/events{/privacy}", "received_events_url": "https://api.github.com/users/cheshire/received_events", "type": "User", "site_admin": false }
[ { "login": "cheshire", "id": 348959, "node_id": "MDQ6VXNlcjM0ODk1OQ==", "avatar_url": "https://avatars.githubusercontent.com/u/348959?v=4", "gravatar_id": "", "url": "https://api.github.com/users/cheshire", "html_url": "https://github.com/cheshire", "followers_url": "https://api.github.com/users/cheshire/followers", "following_url": "https://api.github.com/users/cheshire/following{/other_user}", "gists_url": "https://api.github.com/users/cheshire/gists{/gist_id}", "starred_url": "https://api.github.com/users/cheshire/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/cheshire/subscriptions", "organizations_url": "https://api.github.com/users/cheshire/orgs", "repos_url": "https://api.github.com/users/cheshire/repos", "events_url": "https://api.github.com/users/cheshire/events{/privacy}", "received_events_url": "https://api.github.com/users/cheshire/received_events", "type": "User", "site_admin": false }, { "login": "reedwm", "id": 6510203, "node_id": "MDQ6VXNlcjY1MTAyMDM=", "avatar_url": "https://avatars.githubusercontent.com/u/6510203?v=4", "gravatar_id": "", "url": "https://api.github.com/users/reedwm", "html_url": "https://github.com/reedwm", "followers_url": "https://api.github.com/users/reedwm/followers", "following_url": "https://api.github.com/users/reedwm/following{/other_user}", "gists_url": "https://api.github.com/users/reedwm/gists{/gist_id}", "starred_url": "https://api.github.com/users/reedwm/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/reedwm/subscriptions", "organizations_url": "https://api.github.com/users/reedwm/orgs", "repos_url": "https://api.github.com/users/reedwm/repos", "events_url": "https://api.github.com/users/reedwm/events{/privacy}", "received_events_url": "https://api.github.com/users/reedwm/received_events", "type": "User", "site_admin": false }, { "login": "chsigg", "id": 7523982, "node_id": "MDQ6VXNlcjc1MjM5ODI=", "avatar_url": "https://avatars.githubusercontent.com/u/7523982?v=4", "gravatar_id": "", "url": "https://api.github.com/users/chsigg", "html_url": "https://github.com/chsigg", "followers_url": "https://api.github.com/users/chsigg/followers", "following_url": "https://api.github.com/users/chsigg/following{/other_user}", "gists_url": "https://api.github.com/users/chsigg/gists{/gist_id}", "starred_url": "https://api.github.com/users/chsigg/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/chsigg/subscriptions", "organizations_url": "https://api.github.com/users/chsigg/orgs", "repos_url": "https://api.github.com/users/chsigg/repos", "events_url": "https://api.github.com/users/chsigg/events{/privacy}", "received_events_url": "https://api.github.com/users/chsigg/received_events", "type": "User", "site_admin": false }, { "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false }, { "login": "gcforster", "id": 108087815, "node_id": "U_kgDOBnFKBw", "avatar_url": "https://avatars.githubusercontent.com/u/108087815?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gcforster", "html_url": "https://github.com/gcforster", "followers_url": "https://api.github.com/users/gcforster/followers", "following_url": "https://api.github.com/users/gcforster/following{/other_user}", "gists_url": "https://api.github.com/users/gcforster/gists{/gist_id}", "starred_url": "https://api.github.com/users/gcforster/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gcforster/subscriptions", "organizations_url": "https://api.github.com/users/gcforster/orgs", "repos_url": "https://api.github.com/users/gcforster/repos", "events_url": "https://api.github.com/users/gcforster/events{/privacy}", "received_events_url": "https://api.github.com/users/gcforster/received_events", "type": "User", "site_admin": false }, { "login": "xla-rotation", "id": 116104012, "node_id": "U_kgDOBuubTA", "avatar_url": "https://avatars.githubusercontent.com/u/116104012?v=4", "gravatar_id": "", "url": "https://api.github.com/users/xla-rotation", "html_url": "https://github.com/xla-rotation", "followers_url": "https://api.github.com/users/xla-rotation/followers", "following_url": "https://api.github.com/users/xla-rotation/following{/other_user}", "gists_url": "https://api.github.com/users/xla-rotation/gists{/gist_id}", "starred_url": "https://api.github.com/users/xla-rotation/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/xla-rotation/subscriptions", "organizations_url": "https://api.github.com/users/xla-rotation/orgs", "repos_url": "https://api.github.com/users/xla-rotation/repos", "events_url": "https://api.github.com/users/xla-rotation/events{/privacy}", "received_events_url": "https://api.github.com/users/xla-rotation/received_events", "type": "User", "site_admin": false } ]
null
[ "Hi @AyanmoI Can you please resolve conflicts? Thank you!", "Hi @AyanmoI Can you please resolve conflicts? Thank you!", "@cheshire Can u take a look. The comments are addressed. ", "@AyanmoI Could you mark the previous comments as \"resolved\" explicitly if they were? Some of the previous issues still seem to apply?", "DotDimensionMerger broke all tests. Thanks to swift action on our parts we have been able to resolve this quickly. Thanks to [Ilia Sergachev](mailto:[email protected]) for moving the pass (https://github.com/openxla/xla/commit/0b3cc823a5dda412c324552e440e779212fb081b). The FMHA pipeline was moved to run before the Triton gemm and cublas gemm rewriter. All changes work successfully now.", "@cheshire I have addressed all pending comments and the CI is clean. Looks like this can be merged now?", "@cheshire the failures seem unrelated.", "@ddunl Is it possible to present the failures in a more UI-friendly way? It's very confusing to figure out what test is actually failing from \"Py+CPP Test Suite - Ubuntu CPU, Python\".", "I believe it is, that's how it is for XLA afaik. tagging @jakeharmon8 @MichaelHudgins ", "There are some linting errors, looking as to why they are not exposed (seems like opening PRs on XLA repo is much easier):\r\n\r\n```\r\n(other warnings about 80 cols)\r\n...\r\n\t///tensorflow/compiler/xla/service/gpu/tests/gpu_fused_mha_test.cc:487](/tensorflow/compiler/xla/service/gpu/tests/gpu_fused_mha_test.cc?l=487)\r\nLines should be <= 80 columns wide [whitespace/line_length] [2]\r\n\t///tensorflow/compiler/xla/service/gpu/tests/gpu_fused_mha_test.cc:881](/tensorflow/compiler/xla/service/gpu/tests/gpu_fused_mha_test.cc?l=881)\r\nLines should be <= 80 columns wide [whitespace/line_length] [2]\r\n\t///tensorflow/compiler/xla/service/gpu/tests/gpu_fused_mha_test.cc:884](/tensorflow/compiler/xla/service/gpu/tests/gpu_fused_mha_test.cc?l=884)\r\nLines should be <= 80 columns wide [whitespace/line_length] [2]\r\n\t///tensorflow/compiler/xla/service/gpu/tests/gpu_fused_mha_test.cc:910](/tensorflow/compiler/xla/service/gpu/tests/gpu_fused_mha_test.cc?l=910)\r\nLines should be <= 80 columns wide [whitespace/line_length] [2]\r\n\t///tensorflow/compiler/xla/service/gpu/tests/gpu_fused_mha_test.cc:913](/tensorflow/compiler/xla/service/gpu/tests/gpu_fused_mha_test.cc?l=913)\r\nLines should be <= 80 columns wide [whitespace/line_length] [2]\r\n\t///tensorflow/compiler/xla/service/gpu/tests/gpu_fused_mha_test.cc:1182](/tensorflow/compiler/xla/service/gpu/tests/gpu_fused_mha_test.cc?l=1182)\r\nLines should be <= 80 columns wide [whitespace/line_length] [2]\r\n\t///tensorflow/compiler/xla/service/gpu/tests/gpu_fused_mha_test.cc:1185](/tensorflow/compiler/xla/service/gpu/tests/gpu_fused_mha_test.cc?l=1185)\r\nCould not find a newline character at the end of the file. [whitespace/ending_newline] [5]\r\n\t///tensorflow/compiler/xla/service/gpu/tests/gpu_fused_mha_test.cc:1559](/tensorflow/compiler/xla/service/gpu/tests/gpu_fused_mha_test.cc?l=1559)\r\nheader guard has wrong style, please use: TENSORFLOW_COMPILER_XLA_SERVICE_GPU_FUSED_MHA_THUNK_H_ [build/header_guard] [5]\r\n\t///tensorflow/compiler/xla/service/gpu/fused_mha_thunk.h:16](/tensorflow/compiler/xla/service/gpu/fused_mha_thunk.h?l=16)\r\n line should be \"#endif // TENSORFLOW_COMPILER_XLA_SERVICE_GPU_FUSED_MHA_THUNK_H_\" [build/header_guard] [5]\r\n\t///tensorflow/compiler/xla/service/gpu/fused_mha_thunk.h:79](http://google3/third_party/tensorflow/compiler/xla/service/gpu/fused_mha_thunk.h?l=79)\r\nCould not find a newline character at the end of the file. [whitespace/ending_newline] [5]\r\n\t//depot/[google3/third_party/tensorflow/compiler/xla/service/gpu/gpu_fused_mha_runner.cc:576](/tensorflow/compiler/xla/service/gpu/gpu_fused_mha_runner.cc?l=576)\r\n header guard has wrong style, please use: TENSORFLOW_COMPILER_XLA_SERVICE_GPU_GPU_FUSED_MHA_RUNNER_H_ [build/header_guard] [5]\r\n\t///tensorflow/compiler/xla/service/gpu/gpu_fused_mha_runner.h:16](/tensorflow/compiler/xla/service/gpu/gpu_fused_mha_runner.h?l=16)\r\n line should be \"#endif // TENSORFLOW_COMPILER_XLA_SERVICE_GPU_GPU_FUSED_MHA_RUNNER_H_\" [build/header_guard] [5]\r\n\t///tensorflow/compiler/xla/service/gpu/gpu_fused_mha_runner.h:260](/tensorflow/compiler/xla/service/gpu/gpu_fused_mha_runner.h?l=260)\r\nCould not find a newline character at the end of the file. [whitespace/ending_newline] [5]\r\n\t///tensorflow/compiler/xla/service/gpu/gpu_fused_mha_runner.h:260](/tensorflow/compiler/xla/service/gpu/gpu_fused_mha_runner.h?l=260)\r\nCould not find a newline character at the end of the file. [whitespace/ending_newline] [5]\r\n\t///tensorflow/compiler/xla/service/gpu/fused_mha_thunk.cc:98](/tensorflow/compiler/xla/service/gpu/fused_mha_thunk.cc?l=98)\r\n```", "@AyanmoI it looks like the internal errors from the linter are due to long names (_e.g._, \"GetModuleFMHABMM_BMM_arg_layout_manipulation_arg_reversal_HloString_F16();\") that are nearly 80 characters. There should be two options to fix this: 1) renaming with shorter names; or 2) adding \"// NOLINT\" to the end of each line reported above. I think the subsequent tests were blocked by this, so we can force those to run once the changes are made.", "> @AyanmoI it looks like the internal errors from the linter are due to long names (_e.g._, \"GetModuleFMHABMM_BMM_arg_layout_manipulation_arg_reversal_HloString_F16();\") that are nearly 80 characters. There should be two options to fix this: 1) renaming with shorter names; or 2) adding \"// NOLINT\" to the end of each line reported above. I think the subsequent tests were blocked by this, so we can force those to run once the changes are made.\r\n\r\n@gcforster Can you give me the complete log of all these func names/lines? I can add \"// NOLINT\" to those lines. I think it would make sense to have the long names for better description.", "@cheshire @gcforster I have eye-balled and added some `// NOLINT` to lines. Hope this works. Also, I had added these tests right from the beginning. Curious why these failures weren't showing up earlier?", "Sounds good. The errors I see are in file gpu_fused_mha_test.cc: (It looks like a couple may be missing based on the latest commits still)\r\nLine 410: GetModuleFMHABMM_BMM_arg_layout_manipulation_arg_reversal_HloString_F16\r\nLine 413: GetModuleFMHABMM_BMM_arg_layout_manipulation_arg_reversal_HloString_BF16\r\nLine 487: GetModuleFMHABMM_BMM2_non_contracting_dim_stride_not_1_HloString_F16\r\nLine 881: GetModuleFMHABMM1_Scale_Bias_Mask_Softmax_BMM2_HloString_F16_smaller\r\nLine 884: GetModuleFMHABMM1_Scale_Bias_Mask_Softmax_BMM2_HloString_BF16_smaller\r\nLine 910: GetModuleFMHABMM1_Scale_Bias_Mask_Softmax_BMM2_arg_reversal_HloString_F16\r\nLine 913: GetModuleFMHABMM1_Scale_Bias_Mask_Softmax_BMM2_arg_reversal_HloString_BF16\r\nLine 1182: GetModuleFMHABMM1_Scale_Mask_Softmax_BMM2_arg_reversal_HloString_F16\r\nLine 1185: GetModuleFMHABMM1_Scale_Mask_Softmax_BMM2_arg_reversal_HloString_BF16\r\nLine 1559: Needs new line at end of file", "> that are nearly 80 characters.\r\n\r\nOk. I was counting the no. of cols to <= 80. I'll add NOLINT to the end of all the lines having these function names.", "> Sounds good. The errors I see are in file gpu_fused_mha_test.cc: (It looks like a couple may be missing based on the latest commits still) Line 410: GetModuleFMHABMM_BMM_arg_layout_manipulation_arg_reversal_HloString_F16 Line 413: GetModuleFMHABMM_BMM_arg_layout_manipulation_arg_reversal_HloString_BF16 Line 487: GetModuleFMHABMM_BMM2_non_contracting_dim_stride_not_1_HloString_F16 Line 881: GetModuleFMHABMM1_Scale_Bias_Mask_Softmax_BMM2_HloString_F16_smaller Line 884: GetModuleFMHABMM1_Scale_Bias_Mask_Softmax_BMM2_HloString_BF16_smaller Line 910: GetModuleFMHABMM1_Scale_Bias_Mask_Softmax_BMM2_arg_reversal_HloString_F16 Line 913: GetModuleFMHABMM1_Scale_Bias_Mask_Softmax_BMM2_arg_reversal_HloString_BF16 Line 1182: GetModuleFMHABMM1_Scale_Mask_Softmax_BMM2_arg_reversal_HloString_F16 Line 1185: GetModuleFMHABMM1_Scale_Mask_Softmax_BMM2_arg_reversal_HloString_BF16 Line 1559: Needs new line at end of file\r\n\r\nDone.", "@cheshire @gcforster Looks like these tests just timeout:\r\n```\r\nFailed targets (4)\r\n[//tensorflow/examples/custom_ops_doc/multiplex_1:multiplex_1_test](https://source.cloud.google.com/results/invocations/efa7af75-200d-46f3-9fe4-5ac98ba01877/targets/%2F%2Ftensorflow%2Fexamples%2Fcustom_ops_doc%2Fmultiplex_1:multiplex_1_test)\r\nTimed out\r\n9:14:49 AM\r\n03:46\r\n[//tensorflow/python/data/experimental/kernel_tests:group_by_reducer_test](https://source.cloud.google.com/results/invocations/efa7af75-200d-46f3-9fe4-5ac98ba01877/targets/%2F%2Ftensorflow%2Fpython%2Fdata%2Fexperimental%2Fkernel_tests:group_by_reducer_test)\r\nTimed out\r\n9:14:49 AM\r\n03:47\r\n[//tensorflow/python/data/kernel_tests:interleave_test](https://source.cloud.google.com/results/invocations/efa7af75-200d-46f3-9fe4-5ac98ba01877/targets/%2F%2Ftensorflow%2Fpython%2Fdata%2Fkernel_tests:interleave_test)\r\nTimed out\r\n9:14:49 AM\r\n04:29\r\n[//tensorflow/python/framework:ops_test](https://source.cloud.google.com/results/invocations/efa7af75-200d-46f3-9fe4-5ac98ba01877/targets/%2F%2Ftensorflow%2Fpython%2Fframework:ops_test)\r\nTimed out\r\n9:14:49 AM\r\n03:43\r\n```", "> There are some linting errors, looking as to why they are not exposed (seems like opening PRs on XLA repo is much easier):\r\n> \r\n> ```\r\n> (other warnings about 80 cols)\r\n> ...\r\n> \t///tensorflow/compiler/xla/service/gpu/tests/gpu_fused_mha_test.cc:487](/tensorflow/compiler/xla/service/gpu/tests/gpu_fused_mha_test.cc?l=487)\r\n> Lines should be <= 80 columns wide [whitespace/line_length] [2]\r\n> \t///tensorflow/compiler/xla/service/gpu/tests/gpu_fused_mha_test.cc:881](/tensorflow/compiler/xla/service/gpu/tests/gpu_fused_mha_test.cc?l=881)\r\n> Lines should be <= 80 columns wide [whitespace/line_length] [2]\r\n> \t///tensorflow/compiler/xla/service/gpu/tests/gpu_fused_mha_test.cc:884](/tensorflow/compiler/xla/service/gpu/tests/gpu_fused_mha_test.cc?l=884)\r\n> Lines should be <= 80 columns wide [whitespace/line_length] [2]\r\n> \t///tensorflow/compiler/xla/service/gpu/tests/gpu_fused_mha_test.cc:910](/tensorflow/compiler/xla/service/gpu/tests/gpu_fused_mha_test.cc?l=910)\r\n> Lines should be <= 80 columns wide [whitespace/line_length] [2]\r\n> \t///tensorflow/compiler/xla/service/gpu/tests/gpu_fused_mha_test.cc:913](/tensorflow/compiler/xla/service/gpu/tests/gpu_fused_mha_test.cc?l=913)\r\n> Lines should be <= 80 columns wide [whitespace/line_length] [2]\r\n> \t///tensorflow/compiler/xla/service/gpu/tests/gpu_fused_mha_test.cc:1182](/tensorflow/compiler/xla/service/gpu/tests/gpu_fused_mha_test.cc?l=1182)\r\n> Lines should be <= 80 columns wide [whitespace/line_length] [2]\r\n> \t///tensorflow/compiler/xla/service/gpu/tests/gpu_fused_mha_test.cc:1185](/tensorflow/compiler/xla/service/gpu/tests/gpu_fused_mha_test.cc?l=1185)\r\n> Could not find a newline character at the end of the file. [whitespace/ending_newline] [5]\r\n> \t///tensorflow/compiler/xla/service/gpu/tests/gpu_fused_mha_test.cc:1559](/tensorflow/compiler/xla/service/gpu/tests/gpu_fused_mha_test.cc?l=1559)\r\n> header guard has wrong style, please use: TENSORFLOW_COMPILER_XLA_SERVICE_GPU_FUSED_MHA_THUNK_H_ [build/header_guard] [5]\r\n> \t///tensorflow/compiler/xla/service/gpu/fused_mha_thunk.h:16](/tensorflow/compiler/xla/service/gpu/fused_mha_thunk.h?l=16)\r\n> line should be \"#endif // TENSORFLOW_COMPILER_XLA_SERVICE_GPU_FUSED_MHA_THUNK_H_\" [build/header_guard] [5]\r\n> \t///tensorflow/compiler/xla/service/gpu/fused_mha_thunk.h:79](http://google3/third_party/tensorflow/compiler/xla/service/gpu/fused_mha_thunk.h?l=79)\r\n> Could not find a newline character at the end of the file. [whitespace/ending_newline] [5]\r\n> \t//depot/[google3/third_party/tensorflow/compiler/xla/service/gpu/gpu_fused_mha_runner.cc:576](/tensorflow/compiler/xla/service/gpu/gpu_fused_mha_runner.cc?l=576)\r\n> header guard has wrong style, please use: TENSORFLOW_COMPILER_XLA_SERVICE_GPU_GPU_FUSED_MHA_RUNNER_H_ [build/header_guard] [5]\r\n> \t///tensorflow/compiler/xla/service/gpu/gpu_fused_mha_runner.h:16](/tensorflow/compiler/xla/service/gpu/gpu_fused_mha_runner.h?l=16)\r\n> line should be \"#endif // TENSORFLOW_COMPILER_XLA_SERVICE_GPU_GPU_FUSED_MHA_RUNNER_H_\" [build/header_guard] [5]\r\n> \t///tensorflow/compiler/xla/service/gpu/gpu_fused_mha_runner.h:260](/tensorflow/compiler/xla/service/gpu/gpu_fused_mha_runner.h?l=260)\r\n> Could not find a newline character at the end of the file. [whitespace/ending_newline] [5]\r\n> \t///tensorflow/compiler/xla/service/gpu/gpu_fused_mha_runner.h:260](/tensorflow/compiler/xla/service/gpu/gpu_fused_mha_runner.h?l=260)\r\n> Could not find a newline character at the end of the file. [whitespace/ending_newline] [5]\r\n> \t///tensorflow/compiler/xla/service/gpu/fused_mha_thunk.cc:98](/tensorflow/compiler/xla/service/gpu/fused_mha_thunk.cc?l=98)\r\n> ```\r\n\r\n@cheshire I see your point about moving this to OpenXLA since we are blocked unnecessarily by random TF test failures. I have moved TF stuff to OpenXLA internally and it needs some effort to do this manually. Maybe we can forced merge this since we know the failures are unrelated. I am going to open the next PR in OpenXLA. Otherwise, if you have a script to do the transfer automatically, that'll be really useful. I'd keep moving this work to OpenXLA manually as a last resort.", "The tests are currently pending. I'll keep you posted.", "@AyanmoI There are some build errors. \r\n\r\n```\r\n[third_party/tensorflow/compiler/xla/service/gpu/cudnn_fused_mha_rewriter_test.cc:23](//depot/google3/third_party/tensorflow/compiler/xla/service/gpu/cudnn_fused_mha_rewriter_test.cc?l=23&ws=tap-presubmit-server/55736082&snapshot=2):10: error: module //third_party/tensorflow/compiler/xla/service/gpu:cudnn_fused_mha_rewriter_test does not depend on a module exporting 'third_party/tensorflow/compiler/xla/status_macros.h'\r\nsee [http://go/cpp-features#layering_check](https://www.google.com/url?q=http://go/cpp-features%23layering_check&sa=D); to fix run:\r\n\tbuild_cleaner //third_party/tensorflow/compiler/xla/service/gpu:cudnn_fused_mha_rewriter_test\r\n#include \"third_party/tensorflow/compiler/xla/status_macros.h\"\r\n ^\r\n[third_party/tensorflow/compiler/xla/service/gpu/cudnn_fused_mha_rewriter_test.cc:25](//depot/google3/third_party/tensorflow/compiler/xla/service/gpu/cudnn_fused_mha_rewriter_test.cc?l=25&ws=tap-presubmit-server/55736082&snapshot=2):10: error: module //third_party/tensorflow/compiler/xla/service/gpu:cudnn_fused_mha_rewriter_test does not depend on a module exporting 'third_party/tensorflow/compiler/xla/util.h'\r\nsee [http://go/cpp-features#layering_check](https://www.google.com/url?q=http://go/cpp-features%23layering_check&sa=D); to fix run:\r\n\tbuild_cleaner //third_party/tensorflow/compiler/xla/service/gpu:cudnn_fused_mha_rewriter_test\r\n#include \"third_party/tensorflow/compiler/xla/util.h\"\r\n ^\r\n[third_party/tensorflow/compiler/xla/service/gpu/cudnn_fused_mha_rewriter_test.cc:26](//depot/google3/third_party/tensorflow/compiler/xla/service/gpu/cudnn_fused_mha_rewriter_test.cc?l=26&ws=tap-presubmit-server/55736082&snapshot=2):10: error: module //third_party/tensorflow/compiler/xla/service/gpu:cudnn_fused_mha_rewriter_test does not directly depend on a module exporting 'third_party/tensorflow/compiler/xla/xla_data.proto.h', which is part of indirectly-used module blaze-out/k8-cuda11-opt/bin/third_party/tensorflow/compiler/xla/xla_data.proto.h\r\nsee [http://go/cpp-features#layering_check](https://www.google.com/url?q=http://go/cpp-features%23layering_check&sa=D); to fix run:\r\n\tbuild_cleaner //third_party/tensorflow/compiler/xla/service/gpu:cudnn_fused_mha_rewriter_test\r\n#include \"third_party/tensorflow/compiler/xla/xla_data.proto.h\"\r\n ^\r\n[third_party/tensorflow/compiler/xla/service/gpu/cudnn_fused_mha_rewriter_test.cc:71](//depot/google3/third_party/tensorflow/compiler/xla/service/gpu/cudnn_fused_mha_rewriter_test.cc?l=71&ws=tap-presubmit-server/55736082&snapshot=2):42: error: unused variable 'cc' [-Werror,-Wunused-variable]\r\n stream_executor::CudaComputeCapability cc = GetCudaComputeCapability();\r\n ^\r\n[third_party/tensorflow/compiler/xla/service/gpu/cudnn_fused_mha_rewriter_test.cc:241](//depot/google3/third_party/tensorflow/compiler/xla/service/gpu/cudnn_fused_mha_rewriter_test.cc?l=241&ws=tap-presubmit-server/55736082&snapshot=2):42: error: unused variable 'cc' [-Werror,-Wunused-variable]\r\n stream_executor::CudaComputeCapability cc = GetCudaComputeCapability();\r\n ^\r\n5 errors generated.\r\n```\r\n\r\nhttps://github.com/tensorflow/tensorflow/pull/60233/files#diff-10e7b23ad8d7400d5a23bc499fa11b06bbac4271975b009930a68a3c124fa1f7R2880 needs deps added for includes, and there is an unused variable in the error message pasted above.", "@AyanmoI There is a merge conflict. Can you run 'git pull --rebase' and update the PR?", "@AyanmoI There is still a build failure. xla_cc_test \"cudnn_fused_conv_rewriter_test\" is missing //third_party/tensorflow/compiler/xla:status_macros and //third_party/tensorflow/compiler/xla:util from deps.", "@gcforster Still seems to have some unrelated test failures. I don't see any more build issues. Can you take a look?", "@AyanmoI I see a build failure still. The only message is about cc_library \"cudnn_fused_mha_rewriter\" (in the BUILD file) needing \"//third_party/tensorflow/compiler/xla/stream_executor:stream_executor_install_hdrs_gather\" under deps. This is due to the include \"third_party/tensorflow/compiler/xla/stream_executor/dnn.h\"", "> @AyanmoI I see a build failure still. The only message is about cc_library \"cudnn_fused_mha_rewriter\" (in the BUILD file) needing \"//third_party/tensorflow/compiler/xla/stream_executor:stream_executor_install_hdrs_gather\" under deps. This is due to the include \"third_party/tensorflow/compiler/xla/stream_executor/dnn.h\"\r\n\r\nLet me see if I can remove the dependency of dnn.h. Otherwise, I'll add to the BUILD file.", "@gcforster What do u see now?", "@AyanmoI Build errors:\r\n\r\n[third_party/tensorflow/compiler/xla/service/gpu/tests/gpu_fused_mha_test.cc:34](https://cs.corp.google.com/piper///depot/google3/third_party/tensorflow/compiler/xla/service/gpu/tests/gpu_fused_mha_test.cc?l=34&ws=tap-presubmit-server/56911180&snapshot=2):10: error: module //third_party/tensorflow/compiler/xla/service/gpu/tests:gpu_fused_mha_test_gpu does not depend on a module exporting 'third_party/tensorflow/compiler/xla/service/gpu/cublas_cudnn.h'\r\n\r\nand\r\n\r\nIn file included from [third_party/tensorflow/compiler/xla/service/gpu/cudnn_fused_mha_rewriter.cc:16](https://cs.corp.google.com/piper///depot/google3/third_party/tensorflow/compiler/xla/service/gpu/cudnn_fused_mha_rewriter.cc?l=16&ws=tap-presubmit-server/56911180&snapshot=2):\r\n[./third_party/tensorflow/compiler/xla/service/gpu/cudnn_fused_mha_rewriter.h:21](https://cs.corp.google.com/piper///depot/google3/third_party/tensorflow/compiler/xla/service/gpu/cudnn_fused_mha_rewriter.h?l=21&ws=tap-presubmit-server/56911180&snapshot=2):10: error: module //third_party/tensorflow/compiler/xla/service/gpu:cudnn_fused_mha_rewriter does not depend on a module exporting 'third_party/tensorflow/compiler/xla/stream_executor/dnn.h'\r\n\r\nChanges needed for these errors:\r\nthird_party/tensorflow/compiler/xla/service/gpu/BUILD\r\ncc_library \"cudnn_fused_mha_rewriter\" deps\r\n(remove) \"//third_party/tensorflow/compiler/xla/stream_executor:dnn_proto_cc\"\r\n(add) \"//third_party/tensorflow/compiler/xla/stream_executor:stream_executor_install_hdrs_gather\"\r\n\r\nthird_party/tensorflow/compiler/xla/service/gpu/tests/BUILD\r\nxla_test \"gpu_fused_mha_test\" deps\r\n(remove) \"//third_party/absl/memory\"\r\n(add) \"//third_party/tensorflow/compiler/xla/service/gpu:cublas_cudnn\"", "One thing that might be worth trying - you can add `--features=layering_check` to your bazel command. I'm not sure that this will work how we want in TF (there's lots of BUILD files that disable layering_check) but layering_check is what's producing the build errors internally. (XLA external CI is updated to use layering_check as well as of today)", "> \r\n\r\n@gcforster I can see `stream_executor_install_hdrs_gather` defined anywhere. I get this error locally when I include `\"//tensorflow/compiler/xla/stream_executor:stream_executor_install_hdrs_gather\",` in the deps for `cudnn_fused_mha_rewriter`\r\n```\r\nERROR: /workspace/tensorflow/tensorflow/compiler/xla/service/gpu/BUILD:2866:11: in deps attribute of cc_library rule //tensorflow/compiler/xla/service/gpu:cudnn_fused_mha_rewriter: _transitive_hdrs rule '//tensorflow/compiler/xla/stream_executor:stream_executor_install_hdrs_gather' is misplaced here (expected genrule, cc_library, cc_inc_library, cc_embed_data, go_library, objc_library, cc_import, cc_proto_library, gentpl, gentplvars, genantlr, sh_library, cc_binary or cc_test) and '//tensorflow/compiler/xla/stream_executor:stream_executor_install_hdrs_gather' does not have mandatory providers: 'CcInfo'\r\nERROR: /workspace/tensorflow/tensorflow/compiler/xla/service/gpu/BUILD:2866:11: Analysis of target '//tensorflow/compiler/xla/service/gpu:cudnn_fused_mha_rewriter' failed\r\nERROR: Analysis of target '//tensorflow/compiler/xla/service/gpu:cudnn_fused_mha_rewriter_test' failed; build aborted:\r\nINFO: Elapsed time: 5.771s\r\nINFO: 0 processes.\r\nFAILED: Build did NOT complete successfully (177 packages loaded, 16067 targets configured)\r\nERROR: Couldn't start the build. Unable to run tests\r\n```", "> One thing that might be worth trying - you can add `--features=layering_check` to your bazel command. I'm not sure that this will work how we want in TF (there's lots of BUILD files that disable layering_check) but layering_check is what's producing the build errors internally. (XLA external CI is updated to use layering_check as well as of today)\r\n\r\n@ddunl `--features=layering_check` doesn't seem to reveal these build issues locally." ]
2023-04-04T20:40:33
2023-12-18T10:53:52
2023-06-13T20:18:42
CONTRIBUTOR
null
false
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/pulls/60233", "html_url": "https://github.com/tensorflow/tensorflow/pull/60233", "diff_url": "https://github.com/tensorflow/tensorflow/pull/60233.diff", "patch_url": "https://github.com/tensorflow/tensorflow/pull/60233.patch", "merged_at": null }
cuDNN graph API will support the runtime generation of a fused kernel for various flavors of Fused Dot Attention modules. Currently XLA fuser does not have the capability to perform such fusions and integration of cuDNN graph API support makes it a great opportunity to optimize the graph further and enhance performance. This PR adds the plumbing for the following patterns for inference use case only: BMM1 - BMM2 BMM1 - Scale - Bias - Mask - Softmax - BMM2 BMM1 - Scale - Bias - Mask - Softmax - Dropout - BMM2 BMM1 - Scale - Mask - Softmax - BMM2 BMM1 - Scale - Mask - Softmax - Dropout - BMM2 BMM1 - Softmax - BMM2 BMM1 - Softmax - Dropout - BMM2 BMM1 - Scale - Bias - Softmax - BMM2 BMM1 - Scale - Bias - Softmax - Dropout - BMM2 <img width="386" alt="image" src="https://github.com/tensorflow/tensorflow/assets/42984676/c575bba3-532f-483d-a9f4-9cf427ce0fa5"> The stream executor changes have been merged via https://github.com/tensorflow/tensorflow/pull/60145
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/60233/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/60233/timeline
null
null
true
https://api.github.com/repos/tensorflow/tensorflow/issues/60232
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/60232/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/60232/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/60232/events
https://github.com/tensorflow/tensorflow/issues/60232
1,654,220,356
I_kwDOArmXAs5imWZE
60,232
TFlite Convert Fails to check for bias type int32
{ "login": "Naveen-Dodda", "id": 44787761, "node_id": "MDQ6VXNlcjQ0Nzg3NzYx", "avatar_url": "https://avatars.githubusercontent.com/u/44787761?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Naveen-Dodda", "html_url": "https://github.com/Naveen-Dodda", "followers_url": "https://api.github.com/users/Naveen-Dodda/followers", "following_url": "https://api.github.com/users/Naveen-Dodda/following{/other_user}", "gists_url": "https://api.github.com/users/Naveen-Dodda/gists{/gist_id}", "starred_url": "https://api.github.com/users/Naveen-Dodda/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Naveen-Dodda/subscriptions", "organizations_url": "https://api.github.com/users/Naveen-Dodda/orgs", "repos_url": "https://api.github.com/users/Naveen-Dodda/repos", "events_url": "https://api.github.com/users/Naveen-Dodda/events{/privacy}", "received_events_url": "https://api.github.com/users/Naveen-Dodda/received_events", "type": "User", "site_admin": false }
[ { "id": 404586594, "node_id": "MDU6TGFiZWw0MDQ1ODY1OTQ=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/stat:awaiting%20tensorflower", "name": "stat:awaiting tensorflower", "color": "f4b400", "default": false, "description": "Status - Awaiting response from tensorflower" }, { "id": 473184161, "node_id": "MDU6TGFiZWw0NzMxODQxNjE=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/type:support", "name": "type:support", "color": "159b2e", "default": false, "description": "Support issues" }, { "id": 1661751498, "node_id": "MDU6TGFiZWwxNjYxNzUxNDk4", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/TFLiteConverter", "name": "TFLiteConverter", "color": "bfdadc", "default": false, "description": "For issues related to TFLite converter" } ]
open
false
{ "login": "LukeBoyer", "id": 46931380, "node_id": "MDQ6VXNlcjQ2OTMxMzgw", "avatar_url": "https://avatars.githubusercontent.com/u/46931380?v=4", "gravatar_id": "", "url": "https://api.github.com/users/LukeBoyer", "html_url": "https://github.com/LukeBoyer", "followers_url": "https://api.github.com/users/LukeBoyer/followers", "following_url": "https://api.github.com/users/LukeBoyer/following{/other_user}", "gists_url": "https://api.github.com/users/LukeBoyer/gists{/gist_id}", "starred_url": "https://api.github.com/users/LukeBoyer/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/LukeBoyer/subscriptions", "organizations_url": "https://api.github.com/users/LukeBoyer/orgs", "repos_url": "https://api.github.com/users/LukeBoyer/repos", "events_url": "https://api.github.com/users/LukeBoyer/events{/privacy}", "received_events_url": "https://api.github.com/users/LukeBoyer/received_events", "type": "User", "site_admin": false }
[ { "login": "LukeBoyer", "id": 46931380, "node_id": "MDQ6VXNlcjQ2OTMxMzgw", "avatar_url": "https://avatars.githubusercontent.com/u/46931380?v=4", "gravatar_id": "", "url": "https://api.github.com/users/LukeBoyer", "html_url": "https://github.com/LukeBoyer", "followers_url": "https://api.github.com/users/LukeBoyer/followers", "following_url": "https://api.github.com/users/LukeBoyer/following{/other_user}", "gists_url": "https://api.github.com/users/LukeBoyer/gists{/gist_id}", "starred_url": "https://api.github.com/users/LukeBoyer/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/LukeBoyer/subscriptions", "organizations_url": "https://api.github.com/users/LukeBoyer/orgs", "repos_url": "https://api.github.com/users/LukeBoyer/repos", "events_url": "https://api.github.com/users/LukeBoyer/events{/privacy}", "received_events_url": "https://api.github.com/users/LukeBoyer/received_events", "type": "User", "site_admin": false }, { "login": "sachinprasadhs", "id": 73069040, "node_id": "MDQ6VXNlcjczMDY5MDQw", "avatar_url": "https://avatars.githubusercontent.com/u/73069040?v=4", "gravatar_id": "", "url": "https://api.github.com/users/sachinprasadhs", "html_url": "https://github.com/sachinprasadhs", "followers_url": "https://api.github.com/users/sachinprasadhs/followers", "following_url": "https://api.github.com/users/sachinprasadhs/following{/other_user}", "gists_url": "https://api.github.com/users/sachinprasadhs/gists{/gist_id}", "starred_url": "https://api.github.com/users/sachinprasadhs/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sachinprasadhs/subscriptions", "organizations_url": "https://api.github.com/users/sachinprasadhs/orgs", "repos_url": "https://api.github.com/users/sachinprasadhs/repos", "events_url": "https://api.github.com/users/sachinprasadhs/events{/privacy}", "received_events_url": "https://api.github.com/users/sachinprasadhs/received_events", "type": "User", "site_admin": false } ]
null
[ "Hi @Naveen-Dodda , Thanks for creating the issue.\r\nThis issue was discussed with the TFLite team, we are looking into the issue.\r\nIt makes more sense to throw an error during conversion itself than throwing error during Interpreter to avoid more confusion.\r\n@haozha111 , to give more context this works fine with the float conversion but fails with the below configuration.\r\n\r\n```\r\nconverter.target_spec.supported_ops = [\r\n tf.lite.OpsSet.EXPERIMENTAL_TFLITE_BUILTINS_ACTIVATIONS_INT16_WEIGHTS_INT8\r\n]\r\n```", "Is there a specific reason why INT16_WEIGHTS_INT8 cannot operate with INT32 dtype bias ?" ]
2023-04-04T16:41:06
2023-04-06T17:42:53
null
NONE
null
null
null
TFlite converter allows bias type int32; but interpreter fails to allocate tensors. 1) [Colab to reproduce issue]https://gist.github.com/Naveen-Dodda/2427001bc4b8fb1e05f0a4d84d201e4e): Demonstrate how the model is built and converted to tflite. ### 3. Failure after conversion The conversion works fine but Interpreter fails to allocate tensors. I am wondering if this issue can be fixed. RuntimeError Traceback (most recent call last) <ipython-input-8-514827761d7e> in <cell line: 5>() 3 signatures = quantizer.get_signature_list() 4 print(signatures) ----> 5 quantizer.allocate_tensors() /usr/local/lib/python3.9/dist-packages/tensorflow/lite/python/interpreter.py in allocate_tensors(self) 505 def allocate_tensors(self): 506 self._ensure_safe() --> 507 return self._interpreter.AllocateTensors() 508 509 def _safe_to_run(self): RuntimeError: tensorflow/lite/kernels/depthwise_conv.cc:149 bias->type != kTfLiteInt64 (INT32 != INT64)Node number 1 (DEPTHWISE_CONV_2D) failed to prepare.Failed to apply the default TensorFlow Lite delegate indexed at 0 ### 5. (optional) Any other info / logs https://github.com/tensorflow/tensorflow/blob/v2.12.0/tensorflow/lite/python/lite.py#L479 https://github.com/tensorflow/tensorflow/blob/master/tensorflow/lite/kernels/depthwise_conv.cc#L149
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/60232/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/60232/timeline
null
null
false
https://api.github.com/repos/tensorflow/tensorflow/issues/60231
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/60231/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/60231/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/60231/events
https://github.com/tensorflow/tensorflow/pull/60231
1,654,178,418
PR_kwDOArmXAs5Nmdux
60,231
Fix null pointer dereference in FuseMhloMulAndConvolutionPattern::matchAndRewrite
{ "login": "PaDarochek", "id": 69221349, "node_id": "MDQ6VXNlcjY5MjIxMzQ5", "avatar_url": "https://avatars.githubusercontent.com/u/69221349?v=4", "gravatar_id": "", "url": "https://api.github.com/users/PaDarochek", "html_url": "https://github.com/PaDarochek", "followers_url": "https://api.github.com/users/PaDarochek/followers", "following_url": "https://api.github.com/users/PaDarochek/following{/other_user}", "gists_url": "https://api.github.com/users/PaDarochek/gists{/gist_id}", "starred_url": "https://api.github.com/users/PaDarochek/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/PaDarochek/subscriptions", "organizations_url": "https://api.github.com/users/PaDarochek/orgs", "repos_url": "https://api.github.com/users/PaDarochek/repos", "events_url": "https://api.github.com/users/PaDarochek/events{/privacy}", "received_events_url": "https://api.github.com/users/PaDarochek/received_events", "type": "User", "site_admin": false }
[ { "id": 987666414, "node_id": "MDU6TGFiZWw5ODc2NjY0MTQ=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/ready%20to%20pull", "name": "ready to pull", "color": "2cd643", "default": false, "description": "PR ready for merge process" }, { "id": 1169364259, "node_id": "MDU6TGFiZWwxMTY5MzY0MjU5", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/size:XS", "name": "size:XS", "color": "adafea", "default": false, "description": "CL Change Size: Extra Small" } ]
closed
false
{ "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false }
[ { "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false } ]
null
[ "Please don't use \"add file\"/\"update file\"/\"fix file\"/etc. commit messages. These are hard to reason about when looking at the history of the file/repository. Instead, please write explanatory git commit messages.\r\n\r\nThe commit message is also the title of the PR if the PR has only one commit. It is thus twice important to have commit messages that are relevant, as PRs would be easier to understand and easier to analyze in search results.\r\n\r\nFor how to write good quality git commit messages, please consult https://cbea.ms/git-commit/ ", "cc @mihaimaruseac \r\nFixed `nullptr`, renamed commit and PR" ]
2023-04-04T16:09:52
2023-04-11T09:30:56
2023-04-10T16:48:33
CONTRIBUTOR
null
false
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/pulls/60231", "html_url": "https://github.com/tensorflow/tensorflow/pull/60231", "diff_url": "https://github.com/tensorflow/tensorflow/pull/60231.diff", "patch_url": "https://github.com/tensorflow/tensorflow/pull/60231.patch", "merged_at": "2023-04-10T16:48:33" }
The bug was found by Svace static analyzer: 1. broadcast_op may be null because it is checked for null on https://github.com/tensorflow/tensorflow/blob/r2.12/tensorflow/compiler/mlir/lite/stablehlo/transforms/fuse_convolution_pass.cc#L66 2. later it is zero-dereferenced by broadcast_op.getBroadcastDimensions() cc @mihaimaruseac
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/60231/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/60231/timeline
null
null
true
https://api.github.com/repos/tensorflow/tensorflow/issues/60230
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/60230/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/60230/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/60230/events
https://github.com/tensorflow/tensorflow/pull/60230
1,654,143,153
PR_kwDOArmXAs5NmWKm
60,230
Fix null pointer dereference in Prepare
{ "login": "PaDarochek", "id": 69221349, "node_id": "MDQ6VXNlcjY5MjIxMzQ5", "avatar_url": "https://avatars.githubusercontent.com/u/69221349?v=4", "gravatar_id": "", "url": "https://api.github.com/users/PaDarochek", "html_url": "https://github.com/PaDarochek", "followers_url": "https://api.github.com/users/PaDarochek/followers", "following_url": "https://api.github.com/users/PaDarochek/following{/other_user}", "gists_url": "https://api.github.com/users/PaDarochek/gists{/gist_id}", "starred_url": "https://api.github.com/users/PaDarochek/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/PaDarochek/subscriptions", "organizations_url": "https://api.github.com/users/PaDarochek/orgs", "repos_url": "https://api.github.com/users/PaDarochek/repos", "events_url": "https://api.github.com/users/PaDarochek/events{/privacy}", "received_events_url": "https://api.github.com/users/PaDarochek/received_events", "type": "User", "site_admin": false }
[ { "id": 750616506, "node_id": "MDU6TGFiZWw3NTA2MTY1MDY=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/comp:lite", "name": "comp:lite", "color": "0052cc", "default": false, "description": "TF Lite related issues" }, { "id": 987666414, "node_id": "MDU6TGFiZWw5ODc2NjY0MTQ=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/ready%20to%20pull", "name": "ready to pull", "color": "2cd643", "default": false, "description": "PR ready for merge process" }, { "id": 1169364458, "node_id": "MDU6TGFiZWwxMTY5MzY0NDU4", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/size:S", "name": "size:S", "color": "adafea", "default": false, "description": "CL Change Size: Small" } ]
closed
false
{ "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false }
[ { "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false } ]
null
[ "Please don't use \"add file\"/\"update file\"/\"fix file\"/etc. commit messages. These are hard to reason about when looking at the history of the file/repository. Instead, please write explanatory git commit messages.\r\n\r\nThe commit message is also the title of the PR if the PR has only one commit. It is thus twice important to have commit messages that are relevant, as PRs would be easier to understand and easier to analyze in search results.\r\n\r\nFor how to write good quality git commit messages, please consult https://cbea.ms/git-commit/ ", "cc @mihaimaruseac \r\nFixed `params` checking, renamed commit and PR", "@gbaned, can we proceed with merging this?", "Still needs to go via internal CI and review. See https://github.com/tensorflow/tensorflow/blob/master/CONTRIBUTING.md#typical-pull-request-workflow--, especially the diagram at the bottom" ]
2023-04-04T15:47:30
2023-06-22T18:11:38
2023-05-04T19:23:28
CONTRIBUTOR
null
false
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/pulls/60230", "html_url": "https://github.com/tensorflow/tensorflow/pull/60230", "diff_url": "https://github.com/tensorflow/tensorflow/pull/60230.diff", "patch_url": "https://github.com/tensorflow/tensorflow/pull/60230.patch", "merged_at": "2023-05-04T19:23:28" }
The bug was found by Svace static analyzer: 1. params may be null because it is checked for null on https://github.com/tensorflow/tensorflow/blob/r2.12/tensorflow/lite/kernels/add.cc#L143 2. later it is zero-dereferenced by params->activation cc @mihaimaruseac
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/60230/reactions", "total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/60230/timeline
null
null
true
https://api.github.com/repos/tensorflow/tensorflow/issues/60229
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/60229/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/60229/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/60229/events
https://github.com/tensorflow/tensorflow/issues/60229
1,654,111,666
I_kwDOArmXAs5il72y
60,229
Problem on installation document, wrong $LD_LIBRARY_PATH
{ "login": "KiWeng", "id": 47965209, "node_id": "MDQ6VXNlcjQ3OTY1MjA5", "avatar_url": "https://avatars.githubusercontent.com/u/47965209?v=4", "gravatar_id": "", "url": "https://api.github.com/users/KiWeng", "html_url": "https://github.com/KiWeng", "followers_url": "https://api.github.com/users/KiWeng/followers", "following_url": "https://api.github.com/users/KiWeng/following{/other_user}", "gists_url": "https://api.github.com/users/KiWeng/gists{/gist_id}", "starred_url": "https://api.github.com/users/KiWeng/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/KiWeng/subscriptions", "organizations_url": "https://api.github.com/users/KiWeng/orgs", "repos_url": "https://api.github.com/users/KiWeng/repos", "events_url": "https://api.github.com/users/KiWeng/events{/privacy}", "received_events_url": "https://api.github.com/users/KiWeng/received_events", "type": "User", "site_admin": false }
[ { "id": 284443156, "node_id": "MDU6TGFiZWwyODQ0NDMxNTY=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/type:docs-bug", "name": "type:docs-bug", "color": "159b2e", "default": false, "description": "Document issues" }, { "id": 386191887, "node_id": "MDU6TGFiZWwzODYxOTE4ODc=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/stat:awaiting%20response", "name": "stat:awaiting response", "color": "f4b400", "default": false, "description": "Status - Awaiting response from author" }, { "id": 473172988, "node_id": "MDU6TGFiZWw0NzMxNzI5ODg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/type:bug", "name": "type:bug", "color": "159b2e", "default": false, "description": "Bug" }, { "id": 5206407904, "node_id": "LA_kwDOArmXAs8AAAABNlN64A", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/TF%202.12", "name": "TF 2.12", "color": "c5def5", "default": false, "description": "For issues related to Tensorflow 2.12" } ]
closed
false
{ "login": "sushreebarsa", "id": 84765720, "node_id": "MDQ6VXNlcjg0NzY1NzIw", "avatar_url": "https://avatars.githubusercontent.com/u/84765720?v=4", "gravatar_id": "", "url": "https://api.github.com/users/sushreebarsa", "html_url": "https://github.com/sushreebarsa", "followers_url": "https://api.github.com/users/sushreebarsa/followers", "following_url": "https://api.github.com/users/sushreebarsa/following{/other_user}", "gists_url": "https://api.github.com/users/sushreebarsa/gists{/gist_id}", "starred_url": "https://api.github.com/users/sushreebarsa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sushreebarsa/subscriptions", "organizations_url": "https://api.github.com/users/sushreebarsa/orgs", "repos_url": "https://api.github.com/users/sushreebarsa/repos", "events_url": "https://api.github.com/users/sushreebarsa/events{/privacy}", "received_events_url": "https://api.github.com/users/sushreebarsa/received_events", "type": "User", "site_admin": false }
[ { "login": "sushreebarsa", "id": 84765720, "node_id": "MDQ6VXNlcjg0NzY1NzIw", "avatar_url": "https://avatars.githubusercontent.com/u/84765720?v=4", "gravatar_id": "", "url": "https://api.github.com/users/sushreebarsa", "html_url": "https://github.com/sushreebarsa", "followers_url": "https://api.github.com/users/sushreebarsa/followers", "following_url": "https://api.github.com/users/sushreebarsa/following{/other_user}", "gists_url": "https://api.github.com/users/sushreebarsa/gists{/gist_id}", "starred_url": "https://api.github.com/users/sushreebarsa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sushreebarsa/subscriptions", "organizations_url": "https://api.github.com/users/sushreebarsa/orgs", "repos_url": "https://api.github.com/users/sushreebarsa/repos", "events_url": "https://api.github.com/users/sushreebarsa/events{/privacy}", "received_events_url": "https://api.github.com/users/sushreebarsa/received_events", "type": "User", "site_admin": false } ]
null
[ "@KiWeng Could you have a look at this [PR](https://github.com/tensorflow/docs/pull/2217) which might resolve this issue?\r\nThank you!\r\n", "@KiWeng - just to mention that the proposed solution here does not solve this issue properly as using double quotes would also resolve the left hand side of the phrase, while `$LD_LIBRARY_PATH` should stay unresolved.\r\n\r\nSo one would have to use `echo 'export LD_LIBRARY_PATH=$LD_LIBRARY_PATH:'\"$CONDA_PREFIX/lib/:$CUDNN_PATH/lib\" > $CONDA_PREFIX/etc/conda/activate.d/env_vars.sh` - note use of single quotes for the first part and double quotes (which resolve the variable) for the second part.\r\nI had this issue too at first\r\n\r\nBut it is now fixed in the PR I submitted - which will hopefully go online soon.", "@sushreebarsa @maurerle Thanks, I think the problem is now solved ", "Are you satisfied with the resolution of your issue?\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=Yes&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/60229\">Yes</a>\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=No&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/60229\">No</a>\n" ]
2023-04-04T15:26:22
2023-04-06T08:24:36
2023-04-06T08:24:33
NONE
null
null
null
<details><summary>Click to expand!</summary> ### Issue Type Documentation Bug ### Have you reproduced the bug with TF nightly? No ### Source binary ### Tensorflow Version tf v2.12 ### Custom Code No ### OS Platform and Distribution _No response_ ### Mobile device _No response_ ### Python version _No response_ ### Bazel version _No response_ ### GCC/Compiler version _No response_ ### CUDA/cuDNN version _No response_ ### GPU model and memory _No response_ ### Current Behaviour? ```shell bug: mkdir -p $CONDA_PREFIX/etc/conda/activate.d CUDNN_PATH=$(dirname $(python -c "import nvidia.cudnn;print(nvidia.cudnn.__file__)")) echo 'export LD_LIBRARY_PATH=$LD_LIBRARY_PATH:$CONDA_PREFIX/lib/:$CUDNN_PATH/lib' > $CONDA_PREFIX/etc/conda/activate.d/env_vars.sh symptom: error on creating $CONDA_PREFIX/etc/conda/activate.d/env_vars.sh, causing the $LD_LIBRARY_PATH cannot be set properly, using single quotes instead of double quotes solution: CUDNN_PATH=$(dirname $(python -c "import nvidia.cudnn;print(nvidia.cudnn.__file__)")) echo "export LD_LIBRARY_PATH=$LD_LIBRARY_PATH:$CONDA_PREFIX/lib/:${CUDNN_PATH}/lib" > $CONDA_PREFIX/etc/conda/activate.d/env_vars.sh ``` ### Standalone code to reproduce the issue ```shell mkdir -p $CONDA_PREFIX/etc/conda/activate.d CUDNN_PATH=$(dirname $(python -c "import nvidia.cudnn;print(nvidia.cudnn.__file__)")) echo 'export LD_LIBRARY_PATH=$LD_LIBRARY_PATH:$CONDA_PREFIX/lib/:$CUDNN_PATH/lib' > $CONDA_PREFIX/etc/conda/activate.d/env_vars.sh ``` ### Relevant log output _No response_</details>
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/60229/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/60229/timeline
null
completed
false
https://api.github.com/repos/tensorflow/tensorflow/issues/60228
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/60228/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/60228/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/60228/events
https://github.com/tensorflow/tensorflow/issues/60228
1,654,103,095
I_kwDOArmXAs5il5w3
60,228
INVALID_ARGUMENT: You must feed a value for placeholder tensor while creating Dataset iterator
{ "login": "lychanl", "id": 17790533, "node_id": "MDQ6VXNlcjE3NzkwNTMz", "avatar_url": "https://avatars.githubusercontent.com/u/17790533?v=4", "gravatar_id": "", "url": "https://api.github.com/users/lychanl", "html_url": "https://github.com/lychanl", "followers_url": "https://api.github.com/users/lychanl/followers", "following_url": "https://api.github.com/users/lychanl/following{/other_user}", "gists_url": "https://api.github.com/users/lychanl/gists{/gist_id}", "starred_url": "https://api.github.com/users/lychanl/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/lychanl/subscriptions", "organizations_url": "https://api.github.com/users/lychanl/orgs", "repos_url": "https://api.github.com/users/lychanl/repos", "events_url": "https://api.github.com/users/lychanl/events{/privacy}", "received_events_url": "https://api.github.com/users/lychanl/received_events", "type": "User", "site_admin": false }
[ { "id": 386191887, "node_id": "MDU6TGFiZWwzODYxOTE4ODc=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/stat:awaiting%20response", "name": "stat:awaiting response", "color": "f4b400", "default": false, "description": "Status - Awaiting response from author" }, { "id": 473172988, "node_id": "MDU6TGFiZWw0NzMxNzI5ODg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/type:bug", "name": "type:bug", "color": "159b2e", "default": false, "description": "Bug" }, { "id": 474725938, "node_id": "MDU6TGFiZWw0NzQ3MjU5Mzg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/stale", "name": "stale", "color": "d4c5f9", "default": false, "description": "This label marks the issue/pr stale - to be closed automatically if no activity" }, { "id": 1114343535, "node_id": "MDU6TGFiZWwxMTE0MzQzNTM1", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/comp:data", "name": "comp:data", "color": "0052cc", "default": false, "description": "tf.data related issues" }, { "id": 5206407904, "node_id": "LA_kwDOArmXAs8AAAABNlN64A", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/TF%202.12", "name": "TF 2.12", "color": "c5def5", "default": false, "description": "For issues related to Tensorflow 2.12" } ]
closed
false
{ "login": "sachinprasadhs", "id": 73069040, "node_id": "MDQ6VXNlcjczMDY5MDQw", "avatar_url": "https://avatars.githubusercontent.com/u/73069040?v=4", "gravatar_id": "", "url": "https://api.github.com/users/sachinprasadhs", "html_url": "https://github.com/sachinprasadhs", "followers_url": "https://api.github.com/users/sachinprasadhs/followers", "following_url": "https://api.github.com/users/sachinprasadhs/following{/other_user}", "gists_url": "https://api.github.com/users/sachinprasadhs/gists{/gist_id}", "starred_url": "https://api.github.com/users/sachinprasadhs/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sachinprasadhs/subscriptions", "organizations_url": "https://api.github.com/users/sachinprasadhs/orgs", "repos_url": "https://api.github.com/users/sachinprasadhs/repos", "events_url": "https://api.github.com/users/sachinprasadhs/events{/privacy}", "received_events_url": "https://api.github.com/users/sachinprasadhs/received_events", "type": "User", "site_admin": false }
[ { "login": "sachinprasadhs", "id": 73069040, "node_id": "MDQ6VXNlcjczMDY5MDQw", "avatar_url": "https://avatars.githubusercontent.com/u/73069040?v=4", "gravatar_id": "", "url": "https://api.github.com/users/sachinprasadhs", "html_url": "https://github.com/sachinprasadhs", "followers_url": "https://api.github.com/users/sachinprasadhs/followers", "following_url": "https://api.github.com/users/sachinprasadhs/following{/other_user}", "gists_url": "https://api.github.com/users/sachinprasadhs/gists{/gist_id}", "starred_url": "https://api.github.com/users/sachinprasadhs/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sachinprasadhs/subscriptions", "organizations_url": "https://api.github.com/users/sachinprasadhs/orgs", "repos_url": "https://api.github.com/users/sachinprasadhs/repos", "events_url": "https://api.github.com/users/sachinprasadhs/events{/privacy}", "received_events_url": "https://api.github.com/users/sachinprasadhs/received_events", "type": "User", "site_admin": false } ]
null
[ "Changed tensorflow version to 2.11.1, the same bug does not occur", "@lychanl,\r\nI tried to execute the mentioned code in the latest stable tensorflow v2.12 and it was executed without any issue/error. Kindly find the gist of it [here](https://colab.research.google.com/gist/tilakrayal/7fb0054b3dd5a9422a808b866fc63beb/untitled1066.ipynb).\r\nThank you!\r\n", "Using Tensorflow Datasets (tf.data.Dataset used in TFDS) I've been getting spammed with the same log with Tensorflow 2.12.x and was not an issue using the same setup from roughly 2.4/2.5 to present", "Running the test code, I see the same annoying issue in TF 2.12\r\n`2023-04-17 14:48:51.110417: I tensorflow/core/platform/cpu_feature_guard.cc:182] This TensorFlow binary is optimized to use available CPU instructions in performance-critical operations.\r\nTo enable the following instructions: AVX2 FMA, in other operations, rebuild TensorFlow with the appropriate compiler flags.\r\n2023-04-17 14:48:52.662722: W tensorflow/compiler/tf2tensorrt/utils/py_utils.cc:38] TF-TRT Warning: Could not find TensorRT\r\n2023-04-17 14:48:54.976207: I tensorflow/compiler/xla/stream_executor/cuda/cuda_gpu_executor.cc:996] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero. See more at https://github.com/torvalds/linux/blob/v6.0/Documentation/ABI/testing/sysfs-bus-pci#L344-L355\r\n2023-04-17 14:48:54.977348: I tensorflow/compiler/xla/stream_executor/cuda/cuda_gpu_executor.cc:996] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero. See more at https://github.com/torvalds/linux/blob/v6.0/Documentation/ABI/testing/sysfs-bus-pci#L344-L355\r\n2023-04-17 14:48:55.362289: I tensorflow/compiler/xla/stream_executor/cuda/cuda_gpu_executor.cc:996] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero. See more at https://github.com/torvalds/linux/blob/v6.0/Documentation/ABI/testing/sysfs-bus-pci#L344-L355\r\n2023-04-17 14:48:55.363494: I tensorflow/compiler/xla/stream_executor/cuda/cuda_gpu_executor.cc:996] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero. See more at https://github.com/torvalds/linux/blob/v6.0/Documentation/ABI/testing/sysfs-bus-pci#L344-L355\r\n2023-04-17 14:48:55.364605: I tensorflow/compiler/xla/stream_executor/cuda/cuda_gpu_executor.cc:996] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero. See more at https://github.com/torvalds/linux/blob/v6.0/Documentation/ABI/testing/sysfs-bus-pci#L344-L355\r\n2023-04-17 14:48:55.365682: I tensorflow/compiler/xla/stream_executor/cuda/cuda_gpu_executor.cc:996] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero. See more at https://github.com/torvalds/linux/blob/v6.0/Documentation/ABI/testing/sysfs-bus-pci#L344-L355\r\n2023-04-17 14:48:56.357589: I tensorflow/compiler/xla/stream_executor/cuda/cuda_gpu_executor.cc:996] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero. See more at https://github.com/torvalds/linux/blob/v6.0/Documentation/ABI/testing/sysfs-bus-pci#L344-L355\r\n2023-04-17 14:48:56.358620: I tensorflow/compiler/xla/stream_executor/cuda/cuda_gpu_executor.cc:996] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero. See more at https://github.com/torvalds/linux/blob/v6.0/Documentation/ABI/testing/sysfs-bus-pci#L344-L355\r\n2023-04-17 14:48:56.359587: I tensorflow/compiler/xla/stream_executor/cuda/cuda_gpu_executor.cc:996] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero. See more at https://github.com/torvalds/linux/blob/v6.0/Documentation/ABI/testing/sysfs-bus-pci#L344-L355\r\n2023-04-17 14:48:56.360554: I tensorflow/compiler/xla/stream_executor/cuda/cuda_gpu_executor.cc:996] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero. See more at https://github.com/torvalds/linux/blob/v6.0/Documentation/ABI/testing/sysfs-bus-pci#L344-L355\r\n2023-04-17 14:48:56.361518: I tensorflow/compiler/xla/stream_executor/cuda/cuda_gpu_executor.cc:996] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero. See more at https://github.com/torvalds/linux/blob/v6.0/Documentation/ABI/testing/sysfs-bus-pci#L344-L355\r\n2023-04-17 14:48:56.362469: I tensorflow/compiler/xla/stream_executor/cuda/cuda_gpu_executor.cc:996] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero. See more at https://github.com/torvalds/linux/blob/v6.0/Documentation/ABI/testing/sysfs-bus-pci#L344-L355\r\n2023-04-17 14:49:03.316204: I tensorflow/compiler/xla/stream_executor/cuda/cuda_gpu_executor.cc:996] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero. See more at https://github.com/torvalds/linux/blob/v6.0/Documentation/ABI/testing/sysfs-bus-pci#L344-L355\r\n2023-04-17 14:49:03.317328: I tensorflow/compiler/xla/stream_executor/cuda/cuda_gpu_executor.cc:996] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero. See more at https://github.com/torvalds/linux/blob/v6.0/Documentation/ABI/testing/sysfs-bus-pci#L344-L355\r\n2023-04-17 14:49:03.318322: I tensorflow/compiler/xla/stream_executor/cuda/cuda_gpu_executor.cc:996] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero. See more at https://github.com/torvalds/linux/blob/v6.0/Documentation/ABI/testing/sysfs-bus-pci#L344-L355\r\n2023-04-17 14:49:03.319325: I tensorflow/compiler/xla/stream_executor/cuda/cuda_gpu_executor.cc:996] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero. See more at https://github.com/torvalds/linux/blob/v6.0/Documentation/ABI/testing/sysfs-bus-pci#L344-L355\r\n2023-04-17 14:49:03.320306: I tensorflow/compiler/xla/stream_executor/cuda/cuda_gpu_executor.cc:996] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero. See more at https://github.com/torvalds/linux/blob/v6.0/Documentation/ABI/testing/sysfs-bus-pci#L344-L355\r\n2023-04-17 14:49:03.321258: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1635] Created device /job:localhost/replica:0/task:0/device:GPU:0 with 22004 MB memory: -> device: 0, name: NVIDIA GeForce RTX 4090, pci bus id: 0000:41:00.0, compute capability: 8.9\r\n2023-04-17 14:49:03.322420: I tensorflow/compiler/xla/stream_executor/cuda/cuda_gpu_executor.cc:996] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero. See more at https://github.com/torvalds/linux/blob/v6.0/Documentation/ABI/testing/sysfs-bus-pci#L344-L355\r\n2023-04-17 14:49:03.323273: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1635] Created device /job:localhost/replica:0/task:0/device:GPU:1 with 6609 MB memory: -> device: 1, name: NVIDIA GeForce RTX 2070, pci bus id: 0000:09:00.0, compute capability: 7.5\r\n2023-04-17 14:49:03.724125: I tensorflow/core/common_runtime/executor.cc:1197] [/device:CPU:0] (DEBUG INFO) Executor start aborting (this does not indicate an error and you can ignore this message): INVALID_ARGUMENT: You must feed a value for placeholder tensor 'Placeholder/_0' with dtype int32\r\n\t [[{{node Placeholder/_0}}]]\r\n`", "This issue is stale because it has been open for 7 days with no activity. It will be closed if no further activity occurs. Thank you.", "This issue was closed because it has been inactive for 7 days since being marked as stale. Please reopen if you'd like to work on this further.", "Are you satisfied with the resolution of your issue?\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=Yes&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/60228\">Yes</a>\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=No&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/60228\">No</a>\n", "And what is the solution? Does any new version fix this problem?", "For me, this issue went away with TF v2.13.", "I was able to run this in 2.14 without any error, please find the attached Gist for reference, let me know if I'm missing any detail here.\r\n\r\nhttps://gist.github.com/sachinprasadhs/8751bb475c90511f75bc03c033d2f30e", "This issue is stale because it has been open for 7 days with no activity. It will be closed if no further activity occurs. Thank you.", "This issue was closed because it has been inactive for 7 days since being marked as stale. Please reopen if you'd like to work on this further.", "Are you satisfied with the resolution of your issue?\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=Yes&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/60228\">Yes</a>\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=No&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/60228\">No</a>\n" ]
2023-04-04T15:21:12
2023-11-01T01:48:56
2023-11-01T01:48:54
NONE
null
null
null
<details><summary>Click to expand!</summary> ### Issue Type Bug ### Have you reproduced the bug with TF nightly? No ### Source binary ### Tensorflow Version 2.12.0 ### Custom Code No ### OS Platform and Distribution Linux Ubuntu 22.04 ### Mobile device _No response_ ### Python version 3.10.6 ### Bazel version _No response_ ### GCC/Compiler version _No response_ ### CUDA/cuDNN version CUDA Toolkit 11.8, cuDNN 8.6.0 ### GPU model and memory NVIDIA GeForce RTX 3060 Mobile, 6GB ### Current Behaviour? ```shell I get messages like the one below 2023-04-04 17:05:27.821386: I tensorflow/core/common_runtime/executor.cc:1197] [/device:CPU:0] (DEBUG INFO) Executor start aborting (this does not indicate an error and you can ignore this message): INVALID_ARGUMENT: You must feed a value for placeholder tensor 'Placeholder/_0' with dtype int32 [[{{node Placeholder/_0}}]] ``` while creating dataset iterator. While the code works, such message is annoying when the iterator is created in a loop, as it happens every time. ```python ### Standalone code to reproduce the issue import tensorflow as tf def generator(): while True: yield (1, 0.1) dtypes = (tf.int32, tf.float32) shapes = ((), ()) dataset = tf.data.Dataset.from_generator(generator, dtypes, output_shapes=shapes) iter(dataset.take(1)) ``` ### Relevant log output ```shell 2023-04-04 17:13:32.866627: I tensorflow/core/util/port.cc:110] oneDNN custom operations are on. You may see slightly different numerical results due to floating-point round-off errors from different computation orders. To turn them off, set the environment variable `TF_ENABLE_ONEDNN_OPTS=0`. 2023-04-04 17:13:32.894884: I tensorflow/core/platform/cpu_feature_guard.cc:182] This TensorFlow binary is optimized to use available CPU instructions in performance-critical operations. To enable the following instructions: AVX2 AVX512F AVX512_VNNI FMA, in other operations, rebuild TensorFlow with the appropriate compiler flags. 2023-04-04 17:13:33.371610: W tensorflow/compiler/tf2tensorrt/utils/py_utils.cc:38] TF-TRT Warning: Could not find TensorRT 2023-04-04 17:14:59.902102: I tensorflow/compiler/xla/stream_executor/cuda/cuda_gpu_executor.cc:996] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero. See more at https://github.com/torvalds/linux/blob/v6.0/Documentation/ABI/testing/sysfs-bus-pci#L344-L355 2023-04-04 17:14:59.920891: I tensorflow/compiler/xla/stream_executor/cuda/cuda_gpu_executor.cc:996] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero. See more at https://github.com/torvalds/linux/blob/v6.0/Documentation/ABI/testing/sysfs-bus-pci#L344-L355 2023-04-04 17:14:59.921057: I tensorflow/compiler/xla/stream_executor/cuda/cuda_gpu_executor.cc:996] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero. See more at https://github.com/torvalds/linux/blob/v6.0/Documentation/ABI/testing/sysfs-bus-pci#L344-L355 2023-04-04 17:14:59.922666: I tensorflow/compiler/xla/stream_executor/cuda/cuda_gpu_executor.cc:996] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero. See more at https://github.com/torvalds/linux/blob/v6.0/Documentation/ABI/testing/sysfs-bus-pci#L344-L355 2023-04-04 17:14:59.922823: I tensorflow/compiler/xla/stream_executor/cuda/cuda_gpu_executor.cc:996] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero. See more at https://github.com/torvalds/linux/blob/v6.0/Documentation/ABI/testing/sysfs-bus-pci#L344-L355 2023-04-04 17:14:59.922907: I tensorflow/compiler/xla/stream_executor/cuda/cuda_gpu_executor.cc:996] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero. See more at https://github.com/torvalds/linux/blob/v6.0/Documentation/ABI/testing/sysfs-bus-pci#L344-L355 2023-04-04 17:15:00.284459: I tensorflow/compiler/xla/stream_executor/cuda/cuda_gpu_executor.cc:996] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero. See more at https://github.com/torvalds/linux/blob/v6.0/Documentation/ABI/testing/sysfs-bus-pci#L344-L355 2023-04-04 17:15:00.284586: I tensorflow/compiler/xla/stream_executor/cuda/cuda_gpu_executor.cc:996] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero. See more at https://github.com/torvalds/linux/blob/v6.0/Documentation/ABI/testing/sysfs-bus-pci#L344-L355 2023-04-04 17:15:00.284664: I tensorflow/compiler/xla/stream_executor/cuda/cuda_gpu_executor.cc:996] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero. See more at https://github.com/torvalds/linux/blob/v6.0/Documentation/ABI/testing/sysfs-bus-pci#L344-L355 2023-04-04 17:15:00.284741: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1635] Created device /job:localhost/replica:0/task:0/device:GPU:0 with 4069 MB memory: -> device: 0, name: NVIDIA GeForce RTX 3060 Laptop GPU, pci bus id: 0000:01:00.0, compute capability: 8.6 2023-04-04 17:15:18.283352: I tensorflow/core/common_runtime/executor.cc:1197] [/device:CPU:0] (DEBUG INFO) Executor start aborting (this does not indicate an error and you can ignore this message): INVALID_ARGUMENT: You must feed a value for placeholder tensor 'Placeholder/_0' with dtype int32 [[{{node Placeholder/_0}}]] ``` </details>
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/60228/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/60228/timeline
null
completed
false
https://api.github.com/repos/tensorflow/tensorflow/issues/60227
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/60227/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/60227/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/60227/events
https://github.com/tensorflow/tensorflow/pull/60227
1,654,043,439
PR_kwDOArmXAs5NmAll
60,227
Fix null pointer dereference in DirectSession::RunInternal
{ "login": "PaDarochek", "id": 69221349, "node_id": "MDQ6VXNlcjY5MjIxMzQ5", "avatar_url": "https://avatars.githubusercontent.com/u/69221349?v=4", "gravatar_id": "", "url": "https://api.github.com/users/PaDarochek", "html_url": "https://github.com/PaDarochek", "followers_url": "https://api.github.com/users/PaDarochek/followers", "following_url": "https://api.github.com/users/PaDarochek/following{/other_user}", "gists_url": "https://api.github.com/users/PaDarochek/gists{/gist_id}", "starred_url": "https://api.github.com/users/PaDarochek/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/PaDarochek/subscriptions", "organizations_url": "https://api.github.com/users/PaDarochek/orgs", "repos_url": "https://api.github.com/users/PaDarochek/repos", "events_url": "https://api.github.com/users/PaDarochek/events{/privacy}", "received_events_url": "https://api.github.com/users/PaDarochek/received_events", "type": "User", "site_admin": false }
[ { "id": 390482148, "node_id": "MDU6TGFiZWwzOTA0ODIxNDg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/awaiting%20review", "name": "awaiting review", "color": "bc3869", "default": false, "description": "Pull request awaiting review" }, { "id": 987666414, "node_id": "MDU6TGFiZWw5ODc2NjY0MTQ=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/ready%20to%20pull", "name": "ready to pull", "color": "2cd643", "default": false, "description": "PR ready for merge process" }, { "id": 1169364259, "node_id": "MDU6TGFiZWwxMTY5MzY0MjU5", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/size:XS", "name": "size:XS", "color": "adafea", "default": false, "description": "CL Change Size: Extra Small" }, { "id": 1478826728, "node_id": "MDU6TGFiZWwxNDc4ODI2NzI4", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/comp:core", "name": "comp:core", "color": "024391", "default": false, "description": "issues related to core part of tensorflow" } ]
closed
false
{ "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false }
[ { "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false } ]
null
[ "Please don't use \"add file\"/\"update file\"/\"fix file\"/etc. commit messages. These are hard to reason about when looking at the history of the file/repository. Instead, please write explanatory git commit messages.\r\n\r\nThe commit message is also the title of the PR if the PR has only one commit. It is thus twice important to have commit messages that are relevant, as PRs would be easier to understand and easier to analyze in search results.\r\n\r\nFor how to write good quality git commit messages, please consult https://cbea.ms/git-commit/ ", "cc @mihaimaruseac \r\nChanged `run_metadata` checking, added return with error in case when it equals `nullptr`. Renamed commit and PR", "@gbaned, can we continue merging it?", "> @gbaned, can we continue merging it?\r\n\r\nHi @SweetVishnya This PR is giving internal checks failures. We are looking on it. Thank you!", "From internal CI:\r\n\r\n> Use absl::AbortedError etc. instead of tsl::errors::Aborted. You will need to write explicitly the e.g. absl::StrCat. This is required to get correct absl::SourceLocation propagation within Google codebase\r\n\r\nCan you please fix this?", "@gbaned, what about the status of this PR? Can we continue merging it?", "> @gbaned, what about the status of this PR? Can we continue merging it?\r\n\r\nHi @PaDarochek It is in the process of internal review. Thank you!", "Hi @PaDarochek Can you please check @mrry's [comments](https://github.com/tensorflow/tensorflow/pull/60227#discussion_r1348959514) and keep us posted ? Thank you!", "@gbaned @mrry Added guards on each subsequent use of `run_metadata`, rebased branch on master. Can you please take a look? Thanks!" ]
2023-04-04T14:49:40
2023-10-21T11:12:48
2023-10-20T00:42:30
CONTRIBUTOR
null
false
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/pulls/60227", "html_url": "https://github.com/tensorflow/tensorflow/pull/60227", "diff_url": "https://github.com/tensorflow/tensorflow/pull/60227.diff", "patch_url": "https://github.com/tensorflow/tensorflow/pull/60227.patch", "merged_at": "2023-10-20T00:42:30" }
The bug was found by Svace static analyzer: 1. run_metadata may be null because it is checked for null on https://github.com/tensorflow/tensorflow/blob/r2.12/tensorflow/core/common_runtime/direct_session.cc#L545 2. later it is zero-dereferenced by run_metadata->mutable_step_stats() cc @mihaimaruseac
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/60227/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/60227/timeline
null
null
true
https://api.github.com/repos/tensorflow/tensorflow/issues/60226
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/60226/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/60226/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/60226/events
https://github.com/tensorflow/tensorflow/pull/60226
1,654,009,390
PR_kwDOArmXAs5Nl5Vo
60,226
Fix direct_session.cc
{ "login": "PaDarochek", "id": 69221349, "node_id": "MDQ6VXNlcjY5MjIxMzQ5", "avatar_url": "https://avatars.githubusercontent.com/u/69221349?v=4", "gravatar_id": "", "url": "https://api.github.com/users/PaDarochek", "html_url": "https://github.com/PaDarochek", "followers_url": "https://api.github.com/users/PaDarochek/followers", "following_url": "https://api.github.com/users/PaDarochek/following{/other_user}", "gists_url": "https://api.github.com/users/PaDarochek/gists{/gist_id}", "starred_url": "https://api.github.com/users/PaDarochek/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/PaDarochek/subscriptions", "organizations_url": "https://api.github.com/users/PaDarochek/orgs", "repos_url": "https://api.github.com/users/PaDarochek/repos", "events_url": "https://api.github.com/users/PaDarochek/events{/privacy}", "received_events_url": "https://api.github.com/users/PaDarochek/received_events", "type": "User", "site_admin": false }
[ { "id": 1169364259, "node_id": "MDU6TGFiZWwxMTY5MzY0MjU5", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/size:XS", "name": "size:XS", "color": "adafea", "default": false, "description": "CL Change Size: Extra Small" } ]
closed
false
{ "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false }
[ { "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false } ]
null
[ "Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).\n\nView this [failed invocation](https://github.com/tensorflow/tensorflow/pull/60226/checks?check_run_id=12510917626) of the CLA check for more information.\n\nFor the most up to date status, view the checks section at the bottom of the pull request.", "Please don't use \"add file\"/\"update file\"/\"fix file\"/etc. commit messages. These are hard to reason about when looking at the history of the file/repository. Instead, please write explanatory git commit messages.\r\n\r\nThe commit message is also the title of the PR if the PR has only one commit. It is thus twice important to have commit messages that are relevant, as PRs would be easier to understand and easier to analyze in search results.\r\n\r\nFor how to write good quality git commit messages, please consult https://cbea.ms/git-commit/ " ]
2023-04-04T14:30:46
2023-04-04T17:13:49
2023-04-04T14:48:51
CONTRIBUTOR
null
false
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/pulls/60226", "html_url": "https://github.com/tensorflow/tensorflow/pull/60226", "diff_url": "https://github.com/tensorflow/tensorflow/pull/60226.diff", "patch_url": "https://github.com/tensorflow/tensorflow/pull/60226.patch", "merged_at": null }
The bug was found by Svace static analyzer: 1. run_metadata may be null 2. later it is zero-dereferenced by run_metadata->mutable_step_stats() cc @mihaimaruseac
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/60226/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/60226/timeline
null
null
true
https://api.github.com/repos/tensorflow/tensorflow/issues/60225
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/60225/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/60225/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/60225/events
https://github.com/tensorflow/tensorflow/pull/60225
1,653,916,216
PR_kwDOArmXAs5NllE2
60,225
Fix null pointer dereference in grappler::GetInputs
{ "login": "SweetVishnya", "id": 22149206, "node_id": "MDQ6VXNlcjIyMTQ5MjA2", "avatar_url": "https://avatars.githubusercontent.com/u/22149206?v=4", "gravatar_id": "", "url": "https://api.github.com/users/SweetVishnya", "html_url": "https://github.com/SweetVishnya", "followers_url": "https://api.github.com/users/SweetVishnya/followers", "following_url": "https://api.github.com/users/SweetVishnya/following{/other_user}", "gists_url": "https://api.github.com/users/SweetVishnya/gists{/gist_id}", "starred_url": "https://api.github.com/users/SweetVishnya/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/SweetVishnya/subscriptions", "organizations_url": "https://api.github.com/users/SweetVishnya/orgs", "repos_url": "https://api.github.com/users/SweetVishnya/repos", "events_url": "https://api.github.com/users/SweetVishnya/events{/privacy}", "received_events_url": "https://api.github.com/users/SweetVishnya/received_events", "type": "User", "site_admin": false }
[ { "id": 390482148, "node_id": "MDU6TGFiZWwzOTA0ODIxNDg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/awaiting%20review", "name": "awaiting review", "color": "bc3869", "default": false, "description": "Pull request awaiting review" }, { "id": 987666414, "node_id": "MDU6TGFiZWw5ODc2NjY0MTQ=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/ready%20to%20pull", "name": "ready to pull", "color": "2cd643", "default": false, "description": "PR ready for merge process" }, { "id": 1097545273, "node_id": "MDU6TGFiZWwxMDk3NTQ1Mjcz", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/comp:grappler", "name": "comp:grappler", "color": "0052cc", "default": false, "description": "Grappler related issues" }, { "id": 1169364259, "node_id": "MDU6TGFiZWwxMTY5MzY0MjU5", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/size:XS", "name": "size:XS", "color": "adafea", "default": false, "description": "CL Change Size: Extra Small" } ]
closed
false
{ "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false }
[ { "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false } ]
null
[]
2023-04-04T13:39:14
2023-04-10T16:55:35
2023-04-10T16:55:35
CONTRIBUTOR
null
false
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/pulls/60225", "html_url": "https://github.com/tensorflow/tensorflow/pull/60225", "diff_url": "https://github.com/tensorflow/tensorflow/pull/60225.diff", "patch_url": "https://github.com/tensorflow/tensorflow/pull/60225.patch", "merged_at": "2023-04-10T16:55:35" }
The bug was found by Svace static analyzer: 1. there may be zero for-loop iterations and inode stays nullptr 2. later it is zero-dereferenced by inode->name() cc @mihaimaruseac
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/60225/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/60225/timeline
null
null
true
https://api.github.com/repos/tensorflow/tensorflow/issues/60224
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/60224/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/60224/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/60224/events
https://github.com/tensorflow/tensorflow/pull/60224
1,653,880,872
PR_kwDOArmXAs5NldWA
60,224
Fix null pointer dereference in tf2xla ParseShardingFromEdgeSource
{ "login": "SweetVishnya", "id": 22149206, "node_id": "MDQ6VXNlcjIyMTQ5MjA2", "avatar_url": "https://avatars.githubusercontent.com/u/22149206?v=4", "gravatar_id": "", "url": "https://api.github.com/users/SweetVishnya", "html_url": "https://github.com/SweetVishnya", "followers_url": "https://api.github.com/users/SweetVishnya/followers", "following_url": "https://api.github.com/users/SweetVishnya/following{/other_user}", "gists_url": "https://api.github.com/users/SweetVishnya/gists{/gist_id}", "starred_url": "https://api.github.com/users/SweetVishnya/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/SweetVishnya/subscriptions", "organizations_url": "https://api.github.com/users/SweetVishnya/orgs", "repos_url": "https://api.github.com/users/SweetVishnya/repos", "events_url": "https://api.github.com/users/SweetVishnya/events{/privacy}", "received_events_url": "https://api.github.com/users/SweetVishnya/received_events", "type": "User", "site_admin": false }
[ { "id": 1169364259, "node_id": "MDU6TGFiZWwxMTY5MzY0MjU5", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/size:XS", "name": "size:XS", "color": "adafea", "default": false, "description": "CL Change Size: Extra Small" } ]
closed
false
{ "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false }
[ { "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false } ]
null
[ "Wasn't it fixed by https://github.com/tensorflow/tensorflow/pull/58912?", "@apach301, yeah, my bad, this PR is a duplicate." ]
2023-04-04T13:20:54
2023-04-04T14:01:58
2023-04-04T14:01:57
CONTRIBUTOR
null
false
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/pulls/60224", "html_url": "https://github.com/tensorflow/tensorflow/pull/60224", "diff_url": "https://github.com/tensorflow/tensorflow/pull/60224.diff", "patch_url": "https://github.com/tensorflow/tensorflow/pull/60224.patch", "merged_at": null }
The bug was found by Svace static analyzer: 1. edge.src() is null 2. edge.DebugString() dereferences src_ (that is null) via src_->name() cc @mihaimaruseac
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/60224/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/60224/timeline
null
null
true
https://api.github.com/repos/tensorflow/tensorflow/issues/60223
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/60223/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/60223/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/60223/events
https://github.com/tensorflow/tensorflow/issues/60223
1,653,874,838
I_kwDOArmXAs5ilCCW
60,223
Null pointer dereference in lmhlo_to_cpu_runtime.cc
{ "login": "PaDarochek", "id": 69221349, "node_id": "MDQ6VXNlcjY5MjIxMzQ5", "avatar_url": "https://avatars.githubusercontent.com/u/69221349?v=4", "gravatar_id": "", "url": "https://api.github.com/users/PaDarochek", "html_url": "https://github.com/PaDarochek", "followers_url": "https://api.github.com/users/PaDarochek/followers", "following_url": "https://api.github.com/users/PaDarochek/following{/other_user}", "gists_url": "https://api.github.com/users/PaDarochek/gists{/gist_id}", "starred_url": "https://api.github.com/users/PaDarochek/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/PaDarochek/subscriptions", "organizations_url": "https://api.github.com/users/PaDarochek/orgs", "repos_url": "https://api.github.com/users/PaDarochek/repos", "events_url": "https://api.github.com/users/PaDarochek/events{/privacy}", "received_events_url": "https://api.github.com/users/PaDarochek/received_events", "type": "User", "site_admin": false }
[ { "id": 473172988, "node_id": "MDU6TGFiZWw0NzMxNzI5ODg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/type:bug", "name": "type:bug", "color": "159b2e", "default": false, "description": "Bug" }, { "id": 1097543484, "node_id": "MDU6TGFiZWwxMDk3NTQzNDg0", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/comp:runtime", "name": "comp:runtime", "color": "0052cc", "default": false, "description": "c++ runtime, performance issues (cpu)" }, { "id": 3911105852, "node_id": "LA_kwDOArmXAs7pHr08", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/awaiting%20PR%20merge", "name": "awaiting PR merge", "color": "4080bf", "default": false, "description": "awaiting PR merge" }, { "id": 5206407904, "node_id": "LA_kwDOArmXAs8AAAABNlN64A", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/TF%202.12", "name": "TF 2.12", "color": "c5def5", "default": false, "description": "For issues related to Tensorflow 2.12" } ]
closed
false
{ "login": "pjpratik", "id": 118897289, "node_id": "U_kgDOBxY6iQ", "avatar_url": "https://avatars.githubusercontent.com/u/118897289?v=4", "gravatar_id": "", "url": "https://api.github.com/users/pjpratik", "html_url": "https://github.com/pjpratik", "followers_url": "https://api.github.com/users/pjpratik/followers", "following_url": "https://api.github.com/users/pjpratik/following{/other_user}", "gists_url": "https://api.github.com/users/pjpratik/gists{/gist_id}", "starred_url": "https://api.github.com/users/pjpratik/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/pjpratik/subscriptions", "organizations_url": "https://api.github.com/users/pjpratik/orgs", "repos_url": "https://api.github.com/users/pjpratik/repos", "events_url": "https://api.github.com/users/pjpratik/events{/privacy}", "received_events_url": "https://api.github.com/users/pjpratik/received_events", "type": "User", "site_admin": false }
[ { "login": "pjpratik", "id": 118897289, "node_id": "U_kgDOBxY6iQ", "avatar_url": "https://avatars.githubusercontent.com/u/118897289?v=4", "gravatar_id": "", "url": "https://api.github.com/users/pjpratik", "html_url": "https://github.com/pjpratik", "followers_url": "https://api.github.com/users/pjpratik/followers", "following_url": "https://api.github.com/users/pjpratik/following{/other_user}", "gists_url": "https://api.github.com/users/pjpratik/gists{/gist_id}", "starred_url": "https://api.github.com/users/pjpratik/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/pjpratik/subscriptions", "organizations_url": "https://api.github.com/users/pjpratik/orgs", "repos_url": "https://api.github.com/users/pjpratik/repos", "events_url": "https://api.github.com/users/pjpratik/events{/privacy}", "received_events_url": "https://api.github.com/users/pjpratik/received_events", "type": "User", "site_admin": false } ]
null
[ "@mihaimaruseac \r\n\r\nhttps://github.com/tensorflow/tensorflow/blob/c1169a1ba98e1c5d0874cd44ffeb605bfd1cefba/tensorflow/compiler/xla/mlir/backends/cpu/transforms/lmhlo_to_cpu_runtime.cc#L145-L149", "@SweetVishnya Thanks for the PR.\r\n\r\n@PaDarochek The issue will be closed once the PR is merged.\r\n\r\nThanks.", "Are you satisfied with the resolution of your issue?\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=Yes&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/60223\">Yes</a>\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=No&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/60223\">No</a>\n" ]
2023-04-04T13:17:18
2023-04-27T17:54:24
2023-04-27T17:54:22
CONTRIBUTOR
null
null
null
<details><summary>Click to expand!</summary> ### Issue Type Bug ### Have you reproduced the bug with TF nightly? Yes ### Source source ### Tensorflow Version tf 2.12 ### Custom Code No ### OS Platform and Distribution _No response_ ### Mobile device _No response_ ### Python version _No response_ ### Bazel version _No response_ ### GCC/Compiler version _No response_ ### CUDA/cuDNN version _No response_ ### GPU model and memory _No response_ ### Current Behaviour? ```shell Variable `dict` may be `nullptr` and is dereferenced on line 149 in `tensorflow/compiler/xla/mlir/backends/cpu/transforms/lmhlo_to_cpu_runtime.cc`. `dict` is initialized on line 146 and may equal `nullptr`. Then it is dereferenced on line 149. ``` ### Standalone code to reproduce the issue ```shell Bug was found by Svace static analysis tool. ``` ### Relevant log output _No response_</details>
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/60223/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/60223/timeline
null
completed
false
https://api.github.com/repos/tensorflow/tensorflow/issues/60222
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/60222/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/60222/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/60222/events
https://github.com/tensorflow/tensorflow/pull/60222
1,653,849,968
PR_kwDOArmXAs5NlWml
60,222
Fix null pointer dereference in mlir::GetOutermostOpsOfType
{ "login": "SweetVishnya", "id": 22149206, "node_id": "MDQ6VXNlcjIyMTQ5MjA2", "avatar_url": "https://avatars.githubusercontent.com/u/22149206?v=4", "gravatar_id": "", "url": "https://api.github.com/users/SweetVishnya", "html_url": "https://github.com/SweetVishnya", "followers_url": "https://api.github.com/users/SweetVishnya/followers", "following_url": "https://api.github.com/users/SweetVishnya/following{/other_user}", "gists_url": "https://api.github.com/users/SweetVishnya/gists{/gist_id}", "starred_url": "https://api.github.com/users/SweetVishnya/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/SweetVishnya/subscriptions", "organizations_url": "https://api.github.com/users/SweetVishnya/orgs", "repos_url": "https://api.github.com/users/SweetVishnya/repos", "events_url": "https://api.github.com/users/SweetVishnya/events{/privacy}", "received_events_url": "https://api.github.com/users/SweetVishnya/received_events", "type": "User", "site_admin": false }
[ { "id": 390482148, "node_id": "MDU6TGFiZWwzOTA0ODIxNDg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/awaiting%20review", "name": "awaiting review", "color": "bc3869", "default": false, "description": "Pull request awaiting review" }, { "id": 987666414, "node_id": "MDU6TGFiZWw5ODc2NjY0MTQ=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/ready%20to%20pull", "name": "ready to pull", "color": "2cd643", "default": false, "description": "PR ready for merge process" }, { "id": 1169364259, "node_id": "MDU6TGFiZWwxMTY5MzY0MjU5", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/size:XS", "name": "size:XS", "color": "adafea", "default": false, "description": "CL Change Size: Extra Small" } ]
closed
false
{ "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false }
[ { "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false } ]
null
[ "Here are the internal errors, @SweetVishnya can you please verify ? Thank you!\r\n\r\nTraceback (most recent call last):\r\n File \"/py/absl/testing/parameterized.py\", line 320, in bound_param_test\r\n return test_method(self, *testcase_params)\r\n File \"/tensorflow/python/tpu/google/sparse_core/tpu_embedding_v3_test.py\", line 658, in test_single_feature_single_table_backwards_pass_with_csr_input_with_minibatching\r\n tpu_embedding_v3_test_utils.create_input_data_based_on_hw_requirement(\r\nTypeError: create_input_data_based_on_hw_requirement() missing 1 required positional argument: 'num_minibatches_per_physical_sparse_core'", "> Here are the internal errors, @SweetVishnya can you please verify ? Thank you!\r\n> \r\n> Traceback (most recent call last): File \"/py/absl/testing/parameterized.py\", line 320, in bound_param_test return test_method(self, *testcase_params) File \"/tensorflow/python/tpu/google/sparse_core/tpu_embedding_v3_test.py\", line 658, in test_single_feature_single_table_backwards_pass_with_csr_input_with_minibatching tpu_embedding_v3_test_utils.create_input_data_based_on_hw_requirement( TypeError: create_input_data_based_on_hw_requirement() missing 1 required positional argument: 'num_minibatches_per_physical_sparse_core'\r\n\r\nThis seems to be unrelated to the code affected by this PR. I'll try to rebase when I get to PC.", "@gbaned, rebased on master. I hope the unrelated test crashes will go away.", "@gbaned, can you, please, rerun internal checks, so, we can continue merging process?", "> @gbaned, can you, please, rerun internal checks, so, we can continue merging process?\r\n\r\nHi @SweetVishnya Sorry for the delay. I have triggered the checks. Thank you!", "> > @gbaned, can you, please, rerun internal checks, so, we can continue merging process?\r\n> \r\n> Hi @SweetVishnya Sorry for the delay. I have triggered the checks. Thank you!\r\n\r\nIt seems that internal checks were cancelled: kokoro team removed the label. Maybe, we need additional approval from @mihaimaruseac", "The kokoro label is removed when the kokoro CI starts, it's just the way the automation works." ]
2023-04-04T13:02:20
2023-05-05T15:34:01
2023-05-05T15:34:00
CONTRIBUTOR
null
false
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/pulls/60222", "html_url": "https://github.com/tensorflow/tensorflow/pull/60222", "diff_url": "https://github.com/tensorflow/tensorflow/pull/60222.diff", "patch_url": "https://github.com/tensorflow/tensorflow/pull/60222.patch", "merged_at": "2023-05-05T15:34:00" }
The bug was found by Svace static analyzer: 1. v is null 2. v.emitError() dereferences a null pointer cc @mihaimaruseac
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/60222/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/60222/timeline
null
null
true
https://api.github.com/repos/tensorflow/tensorflow/issues/60221
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/60221/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/60221/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/60221/events
https://github.com/tensorflow/tensorflow/pull/60221
1,653,824,557
PR_kwDOArmXAs5NlRHL
60,221
Fix null pointer dereference in tsl::profiler::CreateStub
{ "login": "SweetVishnya", "id": 22149206, "node_id": "MDQ6VXNlcjIyMTQ5MjA2", "avatar_url": "https://avatars.githubusercontent.com/u/22149206?v=4", "gravatar_id": "", "url": "https://api.github.com/users/SweetVishnya", "html_url": "https://github.com/SweetVishnya", "followers_url": "https://api.github.com/users/SweetVishnya/followers", "following_url": "https://api.github.com/users/SweetVishnya/following{/other_user}", "gists_url": "https://api.github.com/users/SweetVishnya/gists{/gist_id}", "starred_url": "https://api.github.com/users/SweetVishnya/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/SweetVishnya/subscriptions", "organizations_url": "https://api.github.com/users/SweetVishnya/orgs", "repos_url": "https://api.github.com/users/SweetVishnya/repos", "events_url": "https://api.github.com/users/SweetVishnya/events{/privacy}", "received_events_url": "https://api.github.com/users/SweetVishnya/received_events", "type": "User", "site_admin": false }
[ { "id": 987666414, "node_id": "MDU6TGFiZWw5ODc2NjY0MTQ=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/ready%20to%20pull", "name": "ready to pull", "color": "2cd643", "default": false, "description": "PR ready for merge process" }, { "id": 1169364259, "node_id": "MDU6TGFiZWwxMTY5MzY0MjU5", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/size:XS", "name": "size:XS", "color": "adafea", "default": false, "description": "CL Change Size: Extra Small" } ]
closed
false
{ "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false }
[ { "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false } ]
null
[]
2023-04-04T12:46:31
2023-04-10T16:51:56
2023-04-10T16:51:56
CONTRIBUTOR
null
false
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/pulls/60221", "html_url": "https://github.com/tensorflow/tensorflow/pull/60221", "diff_url": "https://github.com/tensorflow/tensorflow/pull/60221.diff", "patch_url": "https://github.com/tensorflow/tensorflow/pull/60221.patch", "merged_at": "2023-04-10T16:51:56" }
The bug was found by Svace static analyzer: 1. channel may be null 2. it is passed to grpc::ProfileAnalysis::NewStub(channel) 3. then passed to grpc::ProfileAnalysis::Stub::Stub(channel) 4. then constructor grpc::internal::RpcMethod::RpcMethod() dereferences channel via channel->RegisterMethod(name) cc @mihaimaruseac
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/60221/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/60221/timeline
null
null
true
https://api.github.com/repos/tensorflow/tensorflow/issues/60220
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/60220/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/60220/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/60220/events
https://github.com/tensorflow/tensorflow/issues/60220
1,653,809,769
I_kwDOArmXAs5ikyJp
60,220
Null pointer dereference in conv_ops_fused_int8.cc
{ "login": "PaDarochek", "id": 69221349, "node_id": "MDQ6VXNlcjY5MjIxMzQ5", "avatar_url": "https://avatars.githubusercontent.com/u/69221349?v=4", "gravatar_id": "", "url": "https://api.github.com/users/PaDarochek", "html_url": "https://github.com/PaDarochek", "followers_url": "https://api.github.com/users/PaDarochek/followers", "following_url": "https://api.github.com/users/PaDarochek/following{/other_user}", "gists_url": "https://api.github.com/users/PaDarochek/gists{/gist_id}", "starred_url": "https://api.github.com/users/PaDarochek/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/PaDarochek/subscriptions", "organizations_url": "https://api.github.com/users/PaDarochek/orgs", "repos_url": "https://api.github.com/users/PaDarochek/repos", "events_url": "https://api.github.com/users/PaDarochek/events{/privacy}", "received_events_url": "https://api.github.com/users/PaDarochek/received_events", "type": "User", "site_admin": false }
[ { "id": 473172988, "node_id": "MDU6TGFiZWw0NzMxNzI5ODg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/type:bug", "name": "type:bug", "color": "159b2e", "default": false, "description": "Bug" }, { "id": 1097547147, "node_id": "MDU6TGFiZWwxMDk3NTQ3MTQ3", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/comp:ops", "name": "comp:ops", "color": "0052cc", "default": false, "description": "OPs related issues" }, { "id": 3911105852, "node_id": "LA_kwDOArmXAs7pHr08", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/awaiting%20PR%20merge", "name": "awaiting PR merge", "color": "4080bf", "default": false, "description": "awaiting PR merge" }, { "id": 5206407904, "node_id": "LA_kwDOArmXAs8AAAABNlN64A", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/TF%202.12", "name": "TF 2.12", "color": "c5def5", "default": false, "description": "For issues related to Tensorflow 2.12" } ]
closed
false
{ "login": "sachinprasadhs", "id": 73069040, "node_id": "MDQ6VXNlcjczMDY5MDQw", "avatar_url": "https://avatars.githubusercontent.com/u/73069040?v=4", "gravatar_id": "", "url": "https://api.github.com/users/sachinprasadhs", "html_url": "https://github.com/sachinprasadhs", "followers_url": "https://api.github.com/users/sachinprasadhs/followers", "following_url": "https://api.github.com/users/sachinprasadhs/following{/other_user}", "gists_url": "https://api.github.com/users/sachinprasadhs/gists{/gist_id}", "starred_url": "https://api.github.com/users/sachinprasadhs/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sachinprasadhs/subscriptions", "organizations_url": "https://api.github.com/users/sachinprasadhs/orgs", "repos_url": "https://api.github.com/users/sachinprasadhs/repos", "events_url": "https://api.github.com/users/sachinprasadhs/events{/privacy}", "received_events_url": "https://api.github.com/users/sachinprasadhs/received_events", "type": "User", "site_admin": false }
[ { "login": "sachinprasadhs", "id": 73069040, "node_id": "MDQ6VXNlcjczMDY5MDQw", "avatar_url": "https://avatars.githubusercontent.com/u/73069040?v=4", "gravatar_id": "", "url": "https://api.github.com/users/sachinprasadhs", "html_url": "https://github.com/sachinprasadhs", "followers_url": "https://api.github.com/users/sachinprasadhs/followers", "following_url": "https://api.github.com/users/sachinprasadhs/following{/other_user}", "gists_url": "https://api.github.com/users/sachinprasadhs/gists{/gist_id}", "starred_url": "https://api.github.com/users/sachinprasadhs/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sachinprasadhs/subscriptions", "organizations_url": "https://api.github.com/users/sachinprasadhs/orgs", "repos_url": "https://api.github.com/users/sachinprasadhs/repos", "events_url": "https://api.github.com/users/sachinprasadhs/events{/privacy}", "received_events_url": "https://api.github.com/users/sachinprasadhs/received_events", "type": "User", "site_admin": false } ]
null
[ "@mihaimaruseac \r\n\r\nhttps://github.com/tensorflow/tensorflow/blob/c1169a1ba98e1c5d0874cd44ffeb605bfd1cefba/tensorflow/core/kernels/conv_ops_fused_int8.cc#L200-L271", "Thanks for reporting the issue, this looks like edge case scenario, I have created a PR to address the issue. Thanks!", "Are you satisfied with the resolution of your issue?\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=Yes&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/60220\">Yes</a>\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=No&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/60220\">No</a>\n" ]
2023-04-04T12:37:10
2023-04-12T18:34:02
2023-04-12T18:33:53
CONTRIBUTOR
null
null
null
<details><summary>Click to expand!</summary> ### Issue Type Bug ### Have you reproduced the bug with TF nightly? Yes ### Source source ### Tensorflow Version tf 2.12 ### Custom Code No ### OS Platform and Distribution _No response_ ### Mobile device _No response_ ### Python version _No response_ ### Bazel version _No response_ ### GCC/Compiler version _No response_ ### CUDA/cuDNN version _No response_ ### GPU model and memory _No response_ ### Current Behaviour? ```shell Pointer `side_input_ptr` is dereferenced and passed as the first argument into a call to `std::fmaf` in `tensorflow/core/kernels/conv_ops_fused_int8.cc`. If we are at 0th iteration in a `for`-loop (line 210) and `side_input_base == nullptr` then `col == 0` and `side_input_ptr` will also equal `nullptr` (line 265). After assign to `side_input_ptr`, this pointer is dereferenced on line 269. ``` ### Standalone code to reproduce the issue ```shell Bug was found by Svace static analysis tool. ``` ### Relevant log output _No response_</details>
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/60220/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/60220/timeline
null
completed
false
https://api.github.com/repos/tensorflow/tensorflow/issues/60219
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/60219/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/60219/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/60219/events
https://github.com/tensorflow/tensorflow/pull/60219
1,653,800,309
PR_kwDOArmXAs5NlL5A
60,219
Add fuzzer for running static graph computations
{ "login": "DavidKorczynski", "id": 657617, "node_id": "MDQ6VXNlcjY1NzYxNw==", "avatar_url": "https://avatars.githubusercontent.com/u/657617?v=4", "gravatar_id": "", "url": "https://api.github.com/users/DavidKorczynski", "html_url": "https://github.com/DavidKorczynski", "followers_url": "https://api.github.com/users/DavidKorczynski/followers", "following_url": "https://api.github.com/users/DavidKorczynski/following{/other_user}", "gists_url": "https://api.github.com/users/DavidKorczynski/gists{/gist_id}", "starred_url": "https://api.github.com/users/DavidKorczynski/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/DavidKorczynski/subscriptions", "organizations_url": "https://api.github.com/users/DavidKorczynski/orgs", "repos_url": "https://api.github.com/users/DavidKorczynski/repos", "events_url": "https://api.github.com/users/DavidKorczynski/events{/privacy}", "received_events_url": "https://api.github.com/users/DavidKorczynski/received_events", "type": "User", "site_admin": false }
[ { "id": 1169364458, "node_id": "MDU6TGFiZWwxMTY5MzY0NDU4", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/size:S", "name": "size:S", "color": "adafea", "default": false, "description": "CL Change Size: Small" }, { "id": 1478826728, "node_id": "MDU6TGFiZWwxNDc4ODI2NzI4", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/comp:core", "name": "comp:core", "color": "024391", "default": false, "description": "issues related to core part of tensorflow" } ]
closed
false
{ "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false }
[ { "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false } ]
null
[ "Anything more for me to do here?", "> Anything more for me to do here?\r\n\r\nHi @DavidKorczynski No action pending at this moment. We will let you know if anything needed from you. Thank you!", "Hi @DavidKorczynski Can you please resolve conflicts? Thank you!", "I think was added by way of https://github.com/tensorflow/tensorflow/commit/71912f6e38c484a41b9417b25794a3f7b7a3d39c -- so no need to merge now and we can close this." ]
2023-04-04T12:30:59
2023-05-05T10:36:29
2023-05-05T10:36:26
CONTRIBUTOR
null
false
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/pulls/60219", "html_url": "https://github.com/tensorflow/tensorflow/pull/60219", "diff_url": "https://github.com/tensorflow/tensorflow/pull/60219.diff", "patch_url": "https://github.com/tensorflow/tensorflow/pull/60219.patch", "merged_at": null }
null
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/60219/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/60219/timeline
null
null
true
https://api.github.com/repos/tensorflow/tensorflow/issues/60218
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/60218/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/60218/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/60218/events
https://github.com/tensorflow/tensorflow/issues/60218
1,653,794,858
I_kwDOArmXAs5ikugq
60,218
TensorFlow Lite Converter Issue
{ "login": "surajraoo", "id": 101349429, "node_id": "U_kgDOBgp4NQ", "avatar_url": "https://avatars.githubusercontent.com/u/101349429?v=4", "gravatar_id": "", "url": "https://api.github.com/users/surajraoo", "html_url": "https://github.com/surajraoo", "followers_url": "https://api.github.com/users/surajraoo/followers", "following_url": "https://api.github.com/users/surajraoo/following{/other_user}", "gists_url": "https://api.github.com/users/surajraoo/gists{/gist_id}", "starred_url": "https://api.github.com/users/surajraoo/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/surajraoo/subscriptions", "organizations_url": "https://api.github.com/users/surajraoo/orgs", "repos_url": "https://api.github.com/users/surajraoo/repos", "events_url": "https://api.github.com/users/surajraoo/events{/privacy}", "received_events_url": "https://api.github.com/users/surajraoo/received_events", "type": "User", "site_admin": false }
[ { "id": 386191887, "node_id": "MDU6TGFiZWwzODYxOTE4ODc=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/stat:awaiting%20response", "name": "stat:awaiting response", "color": "f4b400", "default": false, "description": "Status - Awaiting response from author" }, { "id": 474725938, "node_id": "MDU6TGFiZWw0NzQ3MjU5Mzg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/stale", "name": "stale", "color": "d4c5f9", "default": false, "description": "This label marks the issue/pr stale - to be closed automatically if no activity" }, { "id": 750616506, "node_id": "MDU6TGFiZWw3NTA2MTY1MDY=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/comp:lite", "name": "comp:lite", "color": "0052cc", "default": false, "description": "TF Lite related issues" }, { "id": 1661751498, "node_id": "MDU6TGFiZWwxNjYxNzUxNDk4", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/TFLiteConverter", "name": "TFLiteConverter", "color": "bfdadc", "default": false, "description": "For issues related to TFLite converter" } ]
closed
false
{ "login": "pjpratik", "id": 118897289, "node_id": "U_kgDOBxY6iQ", "avatar_url": "https://avatars.githubusercontent.com/u/118897289?v=4", "gravatar_id": "", "url": "https://api.github.com/users/pjpratik", "html_url": "https://github.com/pjpratik", "followers_url": "https://api.github.com/users/pjpratik/followers", "following_url": "https://api.github.com/users/pjpratik/following{/other_user}", "gists_url": "https://api.github.com/users/pjpratik/gists{/gist_id}", "starred_url": "https://api.github.com/users/pjpratik/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/pjpratik/subscriptions", "organizations_url": "https://api.github.com/users/pjpratik/orgs", "repos_url": "https://api.github.com/users/pjpratik/repos", "events_url": "https://api.github.com/users/pjpratik/events{/privacy}", "received_events_url": "https://api.github.com/users/pjpratik/received_events", "type": "User", "site_admin": false }
[ { "login": "pjpratik", "id": 118897289, "node_id": "U_kgDOBxY6iQ", "avatar_url": "https://avatars.githubusercontent.com/u/118897289?v=4", "gravatar_id": "", "url": "https://api.github.com/users/pjpratik", "html_url": "https://github.com/pjpratik", "followers_url": "https://api.github.com/users/pjpratik/followers", "following_url": "https://api.github.com/users/pjpratik/following{/other_user}", "gists_url": "https://api.github.com/users/pjpratik/gists{/gist_id}", "starred_url": "https://api.github.com/users/pjpratik/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/pjpratik/subscriptions", "organizations_url": "https://api.github.com/users/pjpratik/orgs", "repos_url": "https://api.github.com/users/pjpratik/repos", "events_url": "https://api.github.com/users/pjpratik/events{/privacy}", "received_events_url": "https://api.github.com/users/pjpratik/received_events", "type": "User", "site_admin": false } ]
null
[ "Hi @surajraoo \r\n\r\nWe see that the issue [template]( https://github.com/tensorflow/tensorflow/issues/new?assignees=&labels=TFLiteConverter&template=tflite-converter-issue.md) has not been filled, could you please do so as it helps us analyze the issue.\r\n\r\nPlease refer to [this](https://www.tensorflow.org/lite/models/convert/convert_models) guide to quickly get started on converting your model.\r\n\r\n Thanks.", "This issue is stale because it has been open for 7 days with no activity. It will be closed if no further activity occurs. Thank you.", "This issue was closed because it has been inactive for 7 days since being marked as stale. Please reopen if you'd like to work on this further." ]
2023-04-04T12:27:28
2023-04-25T17:21:13
2023-04-21T01:53:33
NONE
null
null
null
### 1. System information - OS Platform and Distribution (e.g., Linux Ubuntu 16.04): - TensorFlow installation (pip package or built from source): - TensorFlow library (version, if pip package or github SHA, if built from source): ### 2. Code Provide code to help us reproduce your issues using one of the following options: #### Option A: Reference colab notebooks 1) Reference [TensorFlow Model Colab](https://colab.research.google.com/gist/ymodak/e96a4270b953201d5362c61c1e8b78aa/tensorflow-datasets.ipynb?authuser=1): Demonstrate how to build your TF model. 2) Reference [TensorFlow Lite Model Colab](https://colab.research.google.com/gist/ymodak/0dfeb28255e189c5c48d9093f296e9a8/tensorflow-lite-debugger-colab.ipynb): Demonstrate how to convert your TF model to a TF Lite model (with quantization, if used) and run TFLite Inference (if possible). ``` (You can paste links or attach files by dragging & dropping them below) - Provide links to your updated versions of the above two colab notebooks. - Provide links to your TensorFlow model and (optionally) TensorFlow Lite Model. ``` #### Option B: Paste your code here or provide a link to a custom end-to-end colab ``` (You can paste links or attach files by dragging & dropping them below) - Include code to invoke the TFLite Converter Python API and the errors. - Provide links to your TensorFlow model and (optionally) TensorFlow Lite Model. ``` ### 3. Failure after conversion If the conversion is successful, but the generated model is wrong, then state what is wrong: - Model produces wrong results and/or has lesser accuracy. - Model produces correct results, but it is slower than expected. ### 4. (optional) RNN conversion support If converting TF RNN to TFLite fused RNN ops, please prefix [RNN] in the title. ### 5. (optional) Any other info / logs Include any logs or source code that would be helpful to diagnose the problem. If including tracebacks, please include the full traceback. Large logs and files should be attached.
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/60218/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/60218/timeline
null
completed
false
https://api.github.com/repos/tensorflow/tensorflow/issues/60217
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/60217/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/60217/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/60217/events
https://github.com/tensorflow/tensorflow/issues/60217
1,653,442,342
I_kwDOArmXAs5ijYcm
60,217
Bazel build issue
{ "login": "yama-can", "id": 108400691, "node_id": "U_kgDOBnYQMw", "avatar_url": "https://avatars.githubusercontent.com/u/108400691?v=4", "gravatar_id": "", "url": "https://api.github.com/users/yama-can", "html_url": "https://github.com/yama-can", "followers_url": "https://api.github.com/users/yama-can/followers", "following_url": "https://api.github.com/users/yama-can/following{/other_user}", "gists_url": "https://api.github.com/users/yama-can/gists{/gist_id}", "starred_url": "https://api.github.com/users/yama-can/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/yama-can/subscriptions", "organizations_url": "https://api.github.com/users/yama-can/orgs", "repos_url": "https://api.github.com/users/yama-can/repos", "events_url": "https://api.github.com/users/yama-can/events{/privacy}", "received_events_url": "https://api.github.com/users/yama-can/received_events", "type": "User", "site_admin": false }
[ { "id": 386191887, "node_id": "MDU6TGFiZWwzODYxOTE4ODc=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/stat:awaiting%20response", "name": "stat:awaiting response", "color": "f4b400", "default": false, "description": "Status - Awaiting response from author" }, { "id": 473173351, "node_id": "MDU6TGFiZWw0NzMxNzMzNTE=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/type:build/install", "name": "type:build/install", "color": "159b2e", "default": false, "description": "Build and install issues" }, { "id": 474725938, "node_id": "MDU6TGFiZWw0NzQ3MjU5Mzg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/stale", "name": "stale", "color": "d4c5f9", "default": false, "description": "This label marks the issue/pr stale - to be closed automatically if no activity" }, { "id": 1222092379, "node_id": "MDU6TGFiZWwxMjIyMDkyMzc5", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/subtype:bazel", "name": "subtype:bazel", "color": "b619ea", "default": false, "description": "Bazel related Build_Installation issues" } ]
closed
false
{ "login": "SuryanarayanaY", "id": 116063290, "node_id": "U_kgDOBur8Og", "avatar_url": "https://avatars.githubusercontent.com/u/116063290?v=4", "gravatar_id": "", "url": "https://api.github.com/users/SuryanarayanaY", "html_url": "https://github.com/SuryanarayanaY", "followers_url": "https://api.github.com/users/SuryanarayanaY/followers", "following_url": "https://api.github.com/users/SuryanarayanaY/following{/other_user}", "gists_url": "https://api.github.com/users/SuryanarayanaY/gists{/gist_id}", "starred_url": "https://api.github.com/users/SuryanarayanaY/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/SuryanarayanaY/subscriptions", "organizations_url": "https://api.github.com/users/SuryanarayanaY/orgs", "repos_url": "https://api.github.com/users/SuryanarayanaY/repos", "events_url": "https://api.github.com/users/SuryanarayanaY/events{/privacy}", "received_events_url": "https://api.github.com/users/SuryanarayanaY/received_events", "type": "User", "site_admin": false }
[ { "login": "SuryanarayanaY", "id": 116063290, "node_id": "U_kgDOBur8Og", "avatar_url": "https://avatars.githubusercontent.com/u/116063290?v=4", "gravatar_id": "", "url": "https://api.github.com/users/SuryanarayanaY", "html_url": "https://github.com/SuryanarayanaY", "followers_url": "https://api.github.com/users/SuryanarayanaY/followers", "following_url": "https://api.github.com/users/SuryanarayanaY/following{/other_user}", "gists_url": "https://api.github.com/users/SuryanarayanaY/gists{/gist_id}", "starred_url": "https://api.github.com/users/SuryanarayanaY/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/SuryanarayanaY/subscriptions", "organizations_url": "https://api.github.com/users/SuryanarayanaY/orgs", "repos_url": "https://api.github.com/users/SuryanarayanaY/repos", "events_url": "https://api.github.com/users/SuryanarayanaY/events{/privacy}", "received_events_url": "https://api.github.com/users/SuryanarayanaY/received_events", "type": "User", "site_admin": false } ]
null
[ " bazel build --config=opt //tensorflow/tools/pip_package:build_pip_package", "@yama-can,\r\nIn order to expedite the trouble-shooting process, could you please provide the following information OS Platform, TensorFlow version, Installed using virtualenv? pip? conda?, Bazel version, GCC/Compiler version, CUDA/cuDNN version.\r\n\r\nAlso there is a similar issue already assigned to the developer which is still in progress and requesting to follow the same for the updates.\r\nhttps://github.com/tensorflow/tensorflow/issues/58453\r\n Thank you!\r\n\r\n\r\n\r\n", "@yama-can, since you have used only --config=opt, I think you are running it on CPU/windows. If that's the case then, you need to run configure.py (located at https://github.com/tensorflow/tensorflow/blob/master/configure.py) before you run the build command(bazel build --config=opt //tensorflow/tools/pip_package:build_pip_package). I sent an image to demonstrate it's command and output. Hope this helps!\r\n\r\n![image](https://user-images.githubusercontent.com/83710963/231277832-27499835-ad99-4980-8f50-f8e3fbead3c4.png)\r\n\r\n\r\n", "Thank you!!\r\nI have successfully built tensorflow.", "@yama-can ,\r\n\r\n@mraunak given the right answer.\r\n\r\nWhenever we choose `--config=opt`option in bazel build command, we must run `./configure.py` and this is mandatory for this option. During `./configure.py` there will be default option for this based on the platform we are using. Please refer the below line from `/configure.py` where default is chosen already based on the platform. \r\n\r\n**For windows:**\r\n`Please specify optimization flags to use during compilation when bazel option \"--config=opt\" is specified [Default is /arch:AVX]:`\r\n\r\n**For Linux:**\r\n`Please specify optimization flags to use during compilation when bazel option \"--config=opt\" is specified [Default is -Wno-sign-compare]:`\r\n\r\nIf you would have run the `./configure.py` then it might be resolved already for you. Please feel free to close the issue if resolved already. Thanks!\r\n", "This issue is stale because it has been open for 7 days with no activity. It will be closed if no further activity occurs. Thank you.", "This issue was closed because it has been inactive for 7 days since being marked as stale. Please reopen if you'd like to work on this further.", "Are you satisfied with the resolution of your issue?\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=Yes&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/60217\">Yes</a>\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=No&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/60217\">No</a>\n" ]
2023-04-04T08:38:33
2023-05-03T01:53:05
2023-05-03T01:53:02
NONE
null
null
null
ERROR: Config value 'opt' is not defined in any .rc file comes out.
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/60217/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/60217/timeline
null
completed
false
https://api.github.com/repos/tensorflow/tensorflow/issues/60216
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/60216/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/60216/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/60216/events
https://github.com/tensorflow/tensorflow/issues/60216
1,653,356,984
I_kwDOArmXAs5ijDm4
60,216
TensorFlow 2.12.0 depends on an older Numpy version than TensorFlow 2.11 does
{ "login": "Dobiasd", "id": 5544610, "node_id": "MDQ6VXNlcjU1NDQ2MTA=", "avatar_url": "https://avatars.githubusercontent.com/u/5544610?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Dobiasd", "html_url": "https://github.com/Dobiasd", "followers_url": "https://api.github.com/users/Dobiasd/followers", "following_url": "https://api.github.com/users/Dobiasd/following{/other_user}", "gists_url": "https://api.github.com/users/Dobiasd/gists{/gist_id}", "starred_url": "https://api.github.com/users/Dobiasd/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Dobiasd/subscriptions", "organizations_url": "https://api.github.com/users/Dobiasd/orgs", "repos_url": "https://api.github.com/users/Dobiasd/repos", "events_url": "https://api.github.com/users/Dobiasd/events{/privacy}", "received_events_url": "https://api.github.com/users/Dobiasd/received_events", "type": "User", "site_admin": false }
[ { "id": 386191887, "node_id": "MDU6TGFiZWwzODYxOTE4ODc=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/stat:awaiting%20response", "name": "stat:awaiting response", "color": "f4b400", "default": false, "description": "Status - Awaiting response from author" }, { "id": 473173351, "node_id": "MDU6TGFiZWw0NzMxNzMzNTE=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/type:build/install", "name": "type:build/install", "color": "159b2e", "default": false, "description": "Build and install issues" }, { "id": 474725938, "node_id": "MDU6TGFiZWw0NzQ3MjU5Mzg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/stale", "name": "stale", "color": "d4c5f9", "default": false, "description": "This label marks the issue/pr stale - to be closed automatically if no activity" }, { "id": 1093464312, "node_id": "MDU6TGFiZWwxMDkzNDY0MzEy", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/type:others", "name": "type:others", "color": "159b2e", "default": false, "description": "issues not falling in bug, perfromance, support, build and install or feature" }, { "id": 5206407904, "node_id": "LA_kwDOArmXAs8AAAABNlN64A", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/TF%202.12", "name": "TF 2.12", "color": "c5def5", "default": false, "description": "For issues related to Tensorflow 2.12" } ]
closed
false
{ "login": "SuryanarayanaY", "id": 116063290, "node_id": "U_kgDOBur8Og", "avatar_url": "https://avatars.githubusercontent.com/u/116063290?v=4", "gravatar_id": "", "url": "https://api.github.com/users/SuryanarayanaY", "html_url": "https://github.com/SuryanarayanaY", "followers_url": "https://api.github.com/users/SuryanarayanaY/followers", "following_url": "https://api.github.com/users/SuryanarayanaY/following{/other_user}", "gists_url": "https://api.github.com/users/SuryanarayanaY/gists{/gist_id}", "starred_url": "https://api.github.com/users/SuryanarayanaY/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/SuryanarayanaY/subscriptions", "organizations_url": "https://api.github.com/users/SuryanarayanaY/orgs", "repos_url": "https://api.github.com/users/SuryanarayanaY/repos", "events_url": "https://api.github.com/users/SuryanarayanaY/events{/privacy}", "received_events_url": "https://api.github.com/users/SuryanarayanaY/received_events", "type": "User", "site_admin": false }
[ { "login": "SuryanarayanaY", "id": 116063290, "node_id": "U_kgDOBur8Og", "avatar_url": "https://avatars.githubusercontent.com/u/116063290?v=4", "gravatar_id": "", "url": "https://api.github.com/users/SuryanarayanaY", "html_url": "https://github.com/SuryanarayanaY", "followers_url": "https://api.github.com/users/SuryanarayanaY/followers", "following_url": "https://api.github.com/users/SuryanarayanaY/following{/other_user}", "gists_url": "https://api.github.com/users/SuryanarayanaY/gists{/gist_id}", "starred_url": "https://api.github.com/users/SuryanarayanaY/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/SuryanarayanaY/subscriptions", "organizations_url": "https://api.github.com/users/SuryanarayanaY/orgs", "repos_url": "https://api.github.com/users/SuryanarayanaY/repos", "events_url": "https://api.github.com/users/SuryanarayanaY/events{/privacy}", "received_events_url": "https://api.github.com/users/SuryanarayanaY/received_events", "type": "User", "site_admin": false } ]
null
[ "Numpy was pinned to <1.24 since it affected few tests on Ragged Tensors. Agree that we should fix those tests and remove the upperbound in future releases.", "@Dobiasd ,\r\n\r\nThanks for bringing this. The dependencies are already mentioned in `setup.py` file under `REQUIRED_PACKAGES` [here](https://github.com/tensorflow/tensorflow/blob/master/tensorflow/tools/pip_package/setup.py) which has to be followed for now. It might be missed in release notes. But this `setup.py` file is upto date and correctly listed the dependencies\r\n\r\nThe latest TF versions might not be compatible for the mentioned reason in above [comment](https://github.com/tensorflow/tensorflow/issues/60216#issuecomment-1496598836) and we hope the issue will be resolved soon.\r\n\r\nThanks!\r\n\r\n\r\n\r\n", "Ok, thanks! :+1:\r\n\r\nIt would be cool to eliminate this upper bound for the dependency version since any such upper bounds can be annoying.", "@Dobiasd ,\r\n\r\nThe upper bound is due to the reason mentioned above and definitely will be resolved at earliest possible.\r\n\r\nMeanwhile if there is any functionality that affected by this limitation, please let us know.It may help us and provides more context for prioritising. Thanks !", "Yes, I understood. Thanks. 👍", "@Dobiasd ,\r\n\r\nDo you want this issue to be open till the upper bound is removed? The reason for this limit has been mentioned in [comment-1496598836](https://github.com/tensorflow/tensorflow/issues/60216#issuecomment-1496598836) and likely to be resolved in Future releases.For current versions required numpy version are mentioned in seyup.py as you aware already.\r\n\r\nPlease confirm. Thanks!\r\n", "Thanks for asking! :heart:\r\n\r\nSince I learned, the upper bound is not an oversight but intended, and since you're aware, I don't care if we keep this issue open or close it. Do with it whatever makes it simpler for you organization-wise. :relaxed:", "Please, keep this issue opened till the upper bound is removed.\r\nCan we hope this will be soon by the way ?", "Will be fixed in 2.13.0 release.", "Can you give an approximative target date for release 2.13 (may be an rc release) ?", "Branch was cut last week, so RC0 should arrive soon. It used to be that RC0 arrived in at most 2 days after branch cut but now there are some delays.", "[RC0 wheels are now published](https://pypi.org/project/tensorflow/2.13.0rc0/#files)", "Hi @Dobiad,\r\n\r\nNow the Upper bound on numpy version is removed in r2.13 version.Please refer the source code [here](https://github.com/tensorflow/tensorflow/blob/525da8a93eca846e32e5c41eddc0496b25a2ef5b/tensorflow/tools/pip_package/setup.py#LL93C1).\r\n\r\nAlso please refer the [gist](https://colab.research.google.com/gist/SuryanarayanaY/e45e1bfa8b05dbbea1e35fd8c641b1f4/60216.ipynb) which downloads numpy version -1.24.2 when installing `tensorflow==2.13.0rc0`.\r\n\r\nPlease spare some time in closing the issue as it is resolved now. Thanks!", "Thanks a lot; not only for the fix, but also for these great explanations! :heart:", "Are you satisfied with the resolution of your issue?\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=Yes&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/60216\">Yes</a>\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=No&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/60216\">No</a>\n", "> [RC0 wheels are now published](https://pypi.org/project/tensorflow/2.13.0rc0/#files)\r\n\r\nFyi, @mihaimaruseac \r\n\r\nI've installed this 2.13.0r0 with Python 3.10 for transformers and got error and rolling back to 2.12. \r\n\r\n```\r\nSuccessfully installed keras-2.13.1rc0 tensorboard-2.13.0 tensorflow-2.13.0rc0 tensorflow-estimator-2.13.0rc0\r\n\r\nile \"<frozen importlib._bootstrap>\", line 1050, in _gcd_import\r\n File \"<frozen importlib._bootstrap>\", line 1027, in _find_and_load\r\n File \"<frozen importlib._bootstrap>\", line 1006, in _find_and_load_unlocked\r\n File \"<frozen importlib._bootstrap>\", line 688, in _load_unlocked\r\n File \"<frozen importlib._bootstrap_external>\", line 883, in exec_module\r\n File \"<frozen importlib._bootstrap>\", line 241, in _call_with_frames_removed\r\n File \"/home/dev/anaconda3/lib/python3.10/site-packages/transformers/models/distilbert/modeling_tf_distilbert.py\", line 34, in <module>\r\n from ...modeling_tf_utils import (\r\n File \"/home/x/anaconda3/lib/python3.10/site-packages/transformers/modeling_tf_utils.py\", line 70, in <module>\r\n from keras.engine import data_adapter\r\n\r\nModuleNotFoundError: No module named 'keras.engine'\r\n\r\nRuntimeError: Failed to import transformers.models.distilbert.modeling_tf_distilbert because of the following error (look up to see its traceback):\r\nNo module named 'keras.engine'\r\n```\r\nMaybe because transformers from huggingface haven't update with this rc version.", "The problem still exists with TensorFlow 2.13.0:\r\n\r\n```bash\r\npip install tensorflow==2.13.0 numpy==1.25.1 \r\n```\r\n\r\n```\r\nERROR: Cannot install numpy==1.25.1 and tensorflow==2.13.0 because these package versions have conflicting dependencies.\r\n\r\nThe conflict is caused by:\r\n The user requested numpy==1.25.1\r\n tensorflow 2.13.0 depends on numpy<=1.24.3 and >=1.22\r\n\r\n```\r\n\r\n@SuryanarayanaY So it seems the upper bound has not been removed. :confused:", "There was no upper bound for numpy with tensorflow 2.11 but it didn't mean that tensorflow 2.11 is working fine with numpy 1.24 or numpy 1.25, which were not released when tensorflow 2.11 was released. May be there should have been an upper bound limit for numpy in tensorflow 2.11 !\r\nI think you can't ask for a given tensorflow release to be by default compatible with all numpy releases in the future (they could have breaking changes needing changes in tensorflow...). So it's not abnormal to have an upper bound limit for numpy in tensorflow : it just means that more recent numpy releases (if any) have not been tested yet against tensorflow.\r\n\r\nI think this issue should be closed and another one opened asking for tensorflow compatibility with numpy 1.25 (which is only one month old by the way)\r\n\r\nI hope the next release of tensorflow (2.13.1 or 2.14.0) will accept numpy 1.25 (but maybe not numpy 1.26 !)", "Of course another possibilioty is to remove all upper bound limits and let tensorflow users open issues saying \"Hi, I tried to use tensorflow 2.13 with last numpy 1.25.1, I encountered this problem...\". \r\n\r\nTwo different ways to deal with compatibily/dependency issues... ", "Thanks for the explanation. :+1:\r\n\r\nHowever, I understood [this comment](https://github.com/tensorflow/tensorflow/issues/60216#issuecomment-1545394985)\r\n\r\n> Now the Upper bound on numpy version is removed in r2.13 version.\r\n\r\nsuch that the upper bound will be removed completely; maybe only pinning the major version (`numpy<2`), not the minor one.\r\n\r\nBut if we believe, numpy will introduce incompatibilities in a minor version change, then it might be unsafe, I agree.\r\n\r\nSo, I guess the question is: \"Do we trust the numpy devs to version correctly, i.e., bump the major version on breaking changes?\"", "I looked numpy changelogs. There are at least expired deprecations between minor versions.\r\n\r\nBut I'm just a tensorflow user. So don't take my comments as if they were from the tensorflow team and let them answer about the upper bound on numpy.", "Hi @Dobiasd ,\r\n\r\nAt present TF2.13v setup.py indicates numpy should be 'numpy >= 1.22, <= 1.24.3' as below. Since there would be always some delay in testing TF with latest numpy compatibilities. Engineering team was proactive in that and now we can see there is upper bound for numpy version with TF2.13v.If there would have been no upper bound then that should be addressed which is not the case now.\r\n\r\nhttps://github.com/tensorflow/tensorflow/blob/1cb1a030a62b169d90d34c747ab9b09f332bf905/tensorflow/tools/pip_package/setup.py#L93\r\n\r\nCurrently Master branch has no upper bound on numpy as mentioned below and its working fine with tf-nightly as per attached [gist](https://colab.sandbox.google.com/gist/SuryanarayanaY/e81cf3451f81a8260907c32e5bfc3a9f/60216.ipynb). \r\n\r\nhttps://github.com/tensorflow/tensorflow/blob/9d6a57027317e673b4d0fea6372fe3aa69cb2714/tensorflow/tools/pip_package/setup.py#L93\r\n\r\nSince this is continuous integration process and there will be always need for changes like this. I hope you also agree to that. We need to refer the latest commit always. Thanks for understanding.\r\n", "Thanks for the explanation. So if I understand correctly, the current `master` branch version does not have an upper bound for the NumPy version, but that does not mean that the next official release will also not have one. I.e., the upper bound for NumPy might be re-introduced again at some point, right?", "@Dobiasd ,\r\n\r\nYes you are right. There may be a chance that the upper versions has to be capped if there are compatibility issues(which we are not sure in advance) with latest versions. ", "This issue is stale because it has been open for 7 days with no activity. It will be closed if no further activity occurs. Thank you.", "This issue was closed because it has been inactive for 7 days since being marked as stale. Please reopen if you'd like to work on this further.", "Are you satisfied with the resolution of your issue?\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=Yes&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/60216\">Yes</a>\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=No&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/60216\">No</a>\n", "Just to add my 2 cents, the common practice in python, and the recommended one by core python and pypa developers, is to use upper bounds, and, at least in most (well-designed) libraries, on the major version. I think the reason is that if a minor version update of a _dependency_ (say numpy) breaks compatibility, the end user can simply downgrade that dependency version himself. But if tensorflow fixes the numpy dependency more strictly, it may simply not install into a given python environment, and the user can do absolutely nothing about it." ]
2023-04-04T07:38:52
2023-09-07T11:10:26
2023-08-06T01:48:42
NONE
null
null
null
```bash pip install tensorflow==2.11.1 numpy==1.24.2 ``` works fine (as does `pip install tensorflow==2.11.0 numpy==1.24.2`). But ```bash pip install tensorflow==2.12.0 numpy==1.24.2 ``` does not: ``` ERROR: Cannot install numpy==1.24.2 and tensorflow==2.12.0 because these package versions have conflicting dependencies. The conflict is caused by: The user requested numpy==1.24.2 tensorflow 2.12.0 depends on numpy<1.24 and >=1.22 To fix this you could try to: 1. loosen the range of package versions you've specified 2. remove package versions to allow pip attempt to solve the dependency conflict ``` To me, this looks unintended (I did not find anything in the documentation or release notes about it), so I've opened this issue. In case this behavior actually is intended (and not a bug in the dependency declarations), please just close the issue. (A remark in the docs would be cool though.)
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/60216/reactions", "total_count": 3, "+1": 3, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/60216/timeline
null
completed
false
https://api.github.com/repos/tensorflow/tensorflow/issues/60214
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/60214/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/60214/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/60214/events
https://github.com/tensorflow/tensorflow/issues/60214
1,652,894,217
I_kwDOArmXAs5ihSoJ
60,214
api for model parallelism
{ "login": "pure-rgb", "id": 45315076, "node_id": "MDQ6VXNlcjQ1MzE1MDc2", "avatar_url": "https://avatars.githubusercontent.com/u/45315076?v=4", "gravatar_id": "", "url": "https://api.github.com/users/pure-rgb", "html_url": "https://github.com/pure-rgb", "followers_url": "https://api.github.com/users/pure-rgb/followers", "following_url": "https://api.github.com/users/pure-rgb/following{/other_user}", "gists_url": "https://api.github.com/users/pure-rgb/gists{/gist_id}", "starred_url": "https://api.github.com/users/pure-rgb/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/pure-rgb/subscriptions", "organizations_url": "https://api.github.com/users/pure-rgb/orgs", "repos_url": "https://api.github.com/users/pure-rgb/repos", "events_url": "https://api.github.com/users/pure-rgb/events{/privacy}", "received_events_url": "https://api.github.com/users/pure-rgb/received_events", "type": "User", "site_admin": false }
[ { "id": 386191887, "node_id": "MDU6TGFiZWwzODYxOTE4ODc=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/stat:awaiting%20response", "name": "stat:awaiting response", "color": "f4b400", "default": false, "description": "Status - Awaiting response from author" }, { "id": 473184161, "node_id": "MDU6TGFiZWw0NzMxODQxNjE=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/type:support", "name": "type:support", "color": "159b2e", "default": false, "description": "Support issues" }, { "id": 474725938, "node_id": "MDU6TGFiZWw0NzQ3MjU5Mzg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/stale", "name": "stale", "color": "d4c5f9", "default": false, "description": "This label marks the issue/pr stale - to be closed automatically if no activity" }, { "id": 1097545817, "node_id": "MDU6TGFiZWwxMDk3NTQ1ODE3", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/comp:apis", "name": "comp:apis", "color": "0052cc", "default": false, "description": "Highlevel API related issues" }, { "id": 5206407904, "node_id": "LA_kwDOArmXAs8AAAABNlN64A", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/TF%202.12", "name": "TF 2.12", "color": "c5def5", "default": false, "description": "For issues related to Tensorflow 2.12" } ]
closed
false
{ "login": "sachinprasadhs", "id": 73069040, "node_id": "MDQ6VXNlcjczMDY5MDQw", "avatar_url": "https://avatars.githubusercontent.com/u/73069040?v=4", "gravatar_id": "", "url": "https://api.github.com/users/sachinprasadhs", "html_url": "https://github.com/sachinprasadhs", "followers_url": "https://api.github.com/users/sachinprasadhs/followers", "following_url": "https://api.github.com/users/sachinprasadhs/following{/other_user}", "gists_url": "https://api.github.com/users/sachinprasadhs/gists{/gist_id}", "starred_url": "https://api.github.com/users/sachinprasadhs/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sachinprasadhs/subscriptions", "organizations_url": "https://api.github.com/users/sachinprasadhs/orgs", "repos_url": "https://api.github.com/users/sachinprasadhs/repos", "events_url": "https://api.github.com/users/sachinprasadhs/events{/privacy}", "received_events_url": "https://api.github.com/users/sachinprasadhs/received_events", "type": "User", "site_admin": false }
[ { "login": "sachinprasadhs", "id": 73069040, "node_id": "MDQ6VXNlcjczMDY5MDQw", "avatar_url": "https://avatars.githubusercontent.com/u/73069040?v=4", "gravatar_id": "", "url": "https://api.github.com/users/sachinprasadhs", "html_url": "https://github.com/sachinprasadhs", "followers_url": "https://api.github.com/users/sachinprasadhs/followers", "following_url": "https://api.github.com/users/sachinprasadhs/following{/other_user}", "gists_url": "https://api.github.com/users/sachinprasadhs/gists{/gist_id}", "starred_url": "https://api.github.com/users/sachinprasadhs/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sachinprasadhs/subscriptions", "organizations_url": "https://api.github.com/users/sachinprasadhs/orgs", "repos_url": "https://api.github.com/users/sachinprasadhs/repos", "events_url": "https://api.github.com/users/sachinprasadhs/events{/privacy}", "received_events_url": "https://api.github.com/users/sachinprasadhs/received_events", "type": "User", "site_admin": false } ]
null
[ "`tf.keras.utils.multi_gpu_model` can be used to replicate a Keras model across multiple GPUs, using data parallelism.\r\n`tf.split` and `tf.concat`are low-level TensorFlow operations that can be used to split tensors across multiple devices and combine their results.\r\n\r\nAs for training and inference of large language models on consumer-level GPUs with limited memory TensorFlow provides several solutions, such as:\r\n**Gradient checkpointing**: This technique allows the model to be split into smaller pieces, which can be processed one at a time, reducing the amount of memory required.\r\n\r\n**Mixed precision training**: This technique uses lower-precision floating point numbers (e.g., `float16`) for some parts of the computation, reducing memory usage and improving training speed.\r\n\r\n**Model pruning:** This technique involves removing some of the model parameters that are less important, reducing the memory required for both training and inference.\r\n\r\n\r\nwhile TensorFlow does not have built-in support for tensor parallelism like Hugging Face's PyTorch Transformers library, it is still possible to implement tensor parallelism in TensorFlow using the low-level APIs mentioned above, such as `tf.split` and `tf.concat`. \r\n", "> tf.keras.utils.multi_gpu_model\r\n\r\nDoesn't support. It is deprecated. \r\n\r\n> Mixed precision training\r\n\r\nGood tools. But not a solutions for model parallel.\r\n\r\n> Gradient checkpointing\r\n\r\nGood tools. Doesn't support in tensorflow. (pytorch does, lol)\r\n\r\n> Model pruning\r\n\r\nSeriously! Any official proven example that shows effectiveness of this approach on LLM models? \r\n\r\n", "In TensorFlow, you can use the `tf.distribute` API with `tf.keras` to implement model parallelism for distributed training. Here's a brief overview of how to use it:\r\n\r\n1. First, you need to define a `tf.distribute.Strategy` object that represents the distribution strategy you want to use. The `tf.distribute.MirroredStrategy` is commonly used for model parallelism, as it replicates the model across multiple devices and synchronizes the gradients during training.\r\n\r\n2. Next, you need to create a `tf.keras` model and compile it as usual. However, you should set the `tf.distribute.Strategy` object as the `tf.keras` optimizer, using the `tf.distribute.Strategy.scope()` context manager.\r\n\r\n3. Finally, you can train the model using the `tf.keras` API as usual, but wrapped in a `tf.distribute.Strategy.scope()` context manager. This will ensure that the model is replicated and synchronized across multiple devices during training.\r\n\r\nHere's an example code snippet that demonstrates how to implement model parallelism using `tf.distribute` with `tf.keras`:\r\n\r\n```import tensorflow as tf\r\n\r\n# Define the distribution strategy\r\nstrategy = tf.distribute.MirroredStrategy()\r\n\r\n# Define the model inside the strategy scope\r\nwith strategy.scope():\r\n model = tf.keras.models.Sequential([\r\n tf.keras.layers.Dense(64, activation='relu', input_shape=(784,)),\r\n tf.keras.layers.Dense(64, activation='relu'),\r\n tf.keras.layers.Dense(10, activation='softmax')\r\n ])\r\n \r\n # Compile the model as usual, but use the strategy optimizer\r\n model.compile(optimizer=tf.keras.optimizers.Adam(),\r\n loss=tf.keras.losses.SparseCategoricalCrossentropy(),\r\n metrics=[tf.keras.metrics.SparseCategoricalAccuracy()])\r\n\r\n# Train the model using the strategy scope\r\ntrain_dataset = tf.data.Dataset.from_tensor_slices((x_train, y_train)).batch(64)\r\nwith strategy.scope():\r\n model.fit(train_dataset, epochs=10)\r\n```\r\nThis code defines a simple feedforward neural network with two hidden layers and trains it on the MNIST dataset using the `tf.keras` API with `tf.distribute.MirroredStrategy` for model parallelism. Note that the code is almost identical to the non-distributed version, except for the `tf.distribute.Strategy` object and the `tf.distribute.Strategy.scope()` context managers.", "@pogrushan \r\n\r\nWhat you did is called data-parallelism and not model parallelism. ", "I'm not sure if you can achieve Tensor parallel (TP) similar to hugging face implementation, closest one would be [tf.split ](https://www.tensorflow.org/api_docs/python/tf/split) which splits the Tensors into multiple tensors based on the provided axis, the challenge in this would be when using multiple devices to use the synchronous training. \r\nFor this issue, you may find [spatial parallel training](https://cloud.google.com/blog/products/ai-machine-learning/train-ml-models-on-large-images-and-3d-volumes-with-spatial-partitioning-on-cloud-tpus) useful.\r\n\r\nFor model parallelism and data parallelism, you can refer `DTensor`, a concept which enables synchronous distributed training. \r\nBelow are the guides and tutorials which can be helpful for you.\r\n1. [Distributed Training with DTensors ](https://www.tensorflow.org/tutorials/distribute/dtensor_ml_tutorial)\r\n2. [DTensor Concepts](https://www.tensorflow.org/guide/dtensor_overview)", "This issue is stale because it has been open for 7 days with no activity. It will be closed if no further activity occurs. Thank you.", "This issue was closed because it has been inactive for 7 days since being marked as stale. Please reopen if you'd like to work on this further.", "Are you satisfied with the resolution of your issue?\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=Yes&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/60214\">Yes</a>\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=No&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/60214\">No</a>\n" ]
2023-04-03T23:09:21
2023-04-28T01:54:59
2023-04-28T01:54:57
NONE
null
null
null
<details><summary>Click to expand!</summary> ### Issue Type Support ### Have you reproduced the bug with TF nightly? Yes ### Source source ### Tensorflow Version 2.12 ### Custom Code Yes ### OS Platform and Distribution _No response_ ### Mobile device _No response_ ### Python version _No response_ ### Bazel version _No response_ ### GCC/Compiler version _No response_ ### CUDA/cuDNN version _No response_ ### GPU model and memory _No response_ ### Current Behaviour? ```shell By using tf.distribute, only the data parallel is documented in the website. https://www.tensorflow.org/guide/distributed_training Now, what are the APIs that can be used for model parallelism? In huggingface, it is documented that, there are many types of parallelism. Read here https://huggingface.co/docs/transformers/v4.15.0/parallelism What the solutions tensorflow provides for large language model training/inference for consumer level GPU. GPU that has 16GB, 24GB v-ram. Is it possible to do [Tensor-Parallel](https://huggingface.co/docs/transformers/v4.15.0/parallelism#tensor-parallelism) in Tensorflow. How model parallism can be applied with APIs in Tensorflow and Keras? ``` ### Standalone code to reproduce the issue ```shell mirrored_strategy = tf.distribute.MirroredStrategy() cluster_resolver = tf.distribute.cluster_resolver.TPUClusterResolver() ``` ### Relevant log output _No response_</details>
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/60214/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/60214/timeline
null
completed
false